X-Git-Url: https://git.hcoop.net/clinton/abcde.git/blobdiff_plain/8fc41c4f89c3b52235f03d921a28d290bef53218..4c2499e18e98cd9623007a950efce27928f6f3b0:/abcde diff --git a/abcde b/abcde index 849c9a4..99e1cf5 100755 --- a/abcde +++ b/abcde @@ -1,6 +1,6 @@ #!/bin/sh # Copyright (c) 1998-2001 Robert Woodcock -# Copyright (c) 2003-2004 Jesus Climent +# Copyright (c) 2003-2005 Jesus Climent # This code is hereby licensed for public consumption under either the # GNU GPL v2 or greater, or Larry Wall's Artistic license - your choice. # @@ -11,7 +11,7 @@ # Copyright for this work is to expire January 1, 2010, after which it # shall be public domain. -VERSION="2.3.0" +VERSION="2.3.99" usage () { @@ -31,6 +31,7 @@ echo "-d " echo " Specify CDROM device to grab" echo "-D Debugging mode (equivalent to sh -x abcde)" echo "-e Erase encoded track information from status file" +#echo "-E Set the encoding information for the tags" echo "-h This help information" #echo "-i Tag files while encoding, when possible (local only) -NWY-" echo "-j <#> Number of encoder processes to run at once (localhost)" @@ -42,12 +43,14 @@ echo "-N Noninteractive. Never prompt for anything" echo "-m Modify playlist to include CRLF endings, to comply with some players" echo "-M Create a CUE file" echo "-o " -echo " Output file type(s) (ogg,mp3,flac,spx,mpc). Defaults to ogg" +echo " Output file type(s) (vorbis,mp3,flac,spx,mpc). Defaults to vorbis" echo "-p Pad track numbers with 0's (if less than 10 tracks)" echo "-P Use UNIX pipes to read+encode without wav files" echo "-r " echo " Also encode on these remote hosts" -echo "-R Add replaygain values to the tag info (only for ogg,flac)" +echo "-R Add replaygain values to the tag info (only for vorbis,flac)" +echo "-s " +echo " Show dielfs from the CDDB info (year,genre)" echo "-S <#> Set the CD speed" #echo "-t File types to preprocess (wav)" #echo "-T Set postprocessing options" @@ -61,7 +64,8 @@ echo " Add a comment to the CD tracks" echo "-W <#> Contatenate CDs: -T #01 -w \"CD #\"" echo "" echo "Tracks is a space-delimited list of tracks to grab." -echo "Ranges specified with hyphens are allowed." +echo "Ranges specified with hyphens are allowed (i.e., 1-5)." +echo "" #echo "Double hyphens are used to concatenate tracks" } @@ -147,7 +151,7 @@ checkerrors () fi # Take the last line in the status file if there's multiple matches PATTERN="^$1(:.*)?$" - BLURB="$(egrep $PATTERN $ABCDETEMPDIR/errors | tail -n 1)" + BLURB="$(egrep $PATTERN "$ABCDETEMPDIR/errors" | tail -n 1)" if [ -z "$BLURB" ]; then # negative, we did not have a negative... @@ -158,6 +162,31 @@ checkerrors () fi } +# page [file] +# Finds the right pager in the system to display a file +page () +{ + PAGEFILE="$1" + # Use the debian sensible-pager wrapper to pick the pager + # user has requested via their $PAGER environment variable + if [ -x "/usr/bin/sensible-pager" ]; then + /usr/bin/sensible-pager "$PAGEFILE" + elif [ -x "$PAGER" ]; then + # That failed, try to load the preferred editor, starting + # with their PAGER variable + $PAGER "$PAGEFILE" + # If that fails, check for less + elif [ -x /usr/bin/less ]; then + /usr/bin/less -f "$PAGEFILE" + # more should be on all UNIX systems + elif [ -x /bin/more ]; then + /bin/more "$PAGEFILE" + else + # No bananas, just cat the thing + cat "$PAGEFILE" >&2 + fi +} + # run_command [blurb] [command...] # Runs a command, silently if necessary, and updates the status file run_command () @@ -299,7 +328,7 @@ splitvarious () TRACKNAME=$(echo "$DTITLEARTIST" | cut -f1 -d~) ;; esac - elif [ "$ONETRACK" = "y" ]; then + elif [ "$VARIOUSARTISTS" = "y" ] && [ "$ONETRACK" = "y" ]; then TRACKARTIST="Various" else TRACKARTIST="$DARTIST" @@ -372,7 +401,7 @@ local id="" "gangsta") id=59 ;; "top 40") id=60 ;; "christian rap") id=61 ;; - "pop/funk") id=62 ;; + "pop/funk"|"pop / funk") id=62 ;; "jungle") id=63 ;; "native american") id=64 ;; "cabaret") id=65 ;; @@ -458,6 +487,7 @@ local id="" "anime") id=145 ;; "jpop") id=146 ;; "synthpop") id=147 ;; + "rock/pop"|"rock / pop") id=148 ;; *) return 1 ;; esac echo ${id} @@ -487,30 +517,43 @@ do_tag () # id3v2 v0.1.9 claims to have solved the -c bug, so we merge both id3 and id3v2 GENREID=$(do_getgenreid "${CDGENRE}") - # FIXME # track numbers in mp3 come with 1/10, so we cannot happily substitute them with $TRACKNUM - run_command tagtrack-$1 $TAGGER $TAGGEROPTS -c "$COMMENTOUTPUT" \ - -A "$DALBUM" -a "$TRACKARTIST" -t "$TRACKNAME" -y "$CDYEAR" \ - -g "$GENREID" -T "${TRACKNUM:-$1/$TRACKS}" \ - "$ABCDETEMPDIR/track$1.$OUTPUT" + case "$ID3SYNTAX" in + id3);; + eyed3) + # FIXME # track numbers in mp3 come with 1/10, so we cannot happily substitute them with $TRACKNUM + run_command tagtrack-$1 $TAGGER $TAGGEROPTS --commen=::"$COMMENTOUTPUT" \ + -A "$DALBUM" -a "$TRACKARTIST" -t "$TRACKNAME" -Y "$CDYEAR" \ + -G "$GENREID" -n "${TRACKNUM:-$1}" "${TRACKNUM:+-N $TRACKS}" \ + "${ENCODING:+--set-encoding=$ENCODING}" + "$ABCDETEMPDIR/track$1.$OUTPUT" + ;; + *) + # FIXME # track numbers in mp3 come with 1/10, so we cannot happily substitute them with $TRACKNUM + run_command tagtrack-$1 $TAGGER $TAGGEROPTS -c "$COMMENTOUTPUT" \ + -A "$DALBUM" -a "$TRACKARTIST" -t "$TRACKNAME" -y "$CDYEAR" \ + -g "$GENREID" -T "${TRACKNUM:-$1/$TRACKS}" \ + "$ABCDETEMPDIR/track$1.$OUTPUT" + ;; + esac ;; - ogg) + vorbis|ogg) case "$OGGENCODERSYNTAX" in vorbize|oggenc) # vorbiscomment can't do in-place modification, mv the file first - if [ -f "$ABCDETEMPDIR/track$1.$OUTPUT" -a ! -f "$ABCDETEMPDIR/track$1.uncommented.$OUTPUT" ]; then - mv "$ABCDETEMPDIR/track$1.$OUTPUT" "$ABCDETEMPDIR/track$1.uncommented.$OUTPUT" + if [ -f "$ABCDETEMPDIR/track$1.$OGGOUTPUTCONTAINER" -a ! -f "$ABCDETEMPDIR/track$1.uncommented.$OGGOUTPUTCONTAINER" ]; then + mv "$ABCDETEMPDIR/track$1.$OGGOUTPUTCONTAINER" "$ABCDETEMPDIR/track$1.uncommented.$OGGOUTPUTCONTAINER" fi ( # These are from http://www.xiph.org/ogg/vorbis/doc/v-comment.html echo ARTIST="$TRACKARTIST" echo ALBUM="$DALBUM" echo TITLE="$TRACKNAME" - if [ -n "$CDYEAR" ]; then + if [ -n "$CDYEAR" ]; then echo DATE="$CDYEAR" - fi - if [ -n "$CDGENRE" ]; then + fi + if [ -n "$CDGENRE" ]; then echo GENRE="$CDGENRE" - fi + fi echo TRACKNUMBER=${TRACKNUM:-$1} echo CDDB=$CDDBDISCID if [ "$(eval echo ${COMMENT})" != "" ]; then @@ -520,18 +563,17 @@ do_tag () esac fi ) | run_command tagtrack-$1 $VORBISCOMMENT $VORBISCOMMENTOPTS -w \ - "$ABCDETEMPDIR/track$1.uncommented.$OUTPUT" "$ABCDETEMPDIR/track$1.$OUTPUT" + "$ABCDETEMPDIR/track$1.uncommented.$OGGOUTPUTCONTAINER" "$ABCDETEMPDIR/track$1.$OGGOUTPUTCONTAINER" # Doublecheck that the commented file was created successfully before wiping the original - if [ -f "$ABCDETEMPDIR/track$1.$OUTPUT" ]; then - rm -f "$ABCDETEMPDIR/track$1.uncommented.$OUTPUT" + if [ -f "$ABCDETEMPDIR/track$1.$OGGOUTPUTCONTAINER" ]; then + rm -f "$ABCDETEMPDIR/track$1.uncommented.$OGGOUTPUTCONTAINER" else - mv "$ABCDETEMPDIR/track$1.uncommented.$OUTPUT" "$ABCDETEMPDIR/track$1.$OUTPUT" + mv "$ABCDETEMPDIR/track$1.uncommented.$OGGOUTPUTCONTAINER" "$ABCDETEMPDIR/track$1.$OGGOUTPUTCONTAINER" fi ;; esac ;; flac) -## FIXME ## [ "$FLACONOGG" = "y" ] && OUTPUT=ogg ( echo ARTIST="$TRACKARTIST" echo ALBUM="$DALBUM" @@ -550,7 +592,7 @@ do_tag () *) echo COMMENT="$COMMENTOUTPUT";; esac fi - ) | run_command tagtrack-$1 $METAFLAC $METAFLACOPTS --import-tags-from=- "$ABCDETEMPDIR/track$1.$OUTPUT" + ) | run_command tagtrack-$1 $METAFLAC $METAFLACOPTS --import-tags-from=- "$ABCDETEMPDIR/track$1.$FLACOUTPUTCONTAINER" ;; spx) run_command tagtrack-$1 true @@ -611,7 +653,7 @@ do_encode () mp3) TEMPARG="PIPE_$MP3ENCODERSYNTAX" ;; - ogg) + vorbis|ogg) TEMPARG="PIPE_$OGGENCODERSYNTAX" ;; flac) @@ -624,7 +666,7 @@ do_encode () TEMPARG="PIPE_$MPPENCODER" ;; esac - IN=${!TEMPARG} + IN="$( eval echo "\$$TEMPARG" )" else IN="$ABCDETEMPDIR/track$1.wav" case "$OUTPUT" in @@ -635,12 +677,12 @@ do_encode () FILEARG="-if $IN" ;; *) - FILEARG=$IN + FILEARG="$IN" ;; esac ;; *) - FILEARG=$IN + FILEARG="$IN" ;; esac fi @@ -648,7 +690,17 @@ do_encode () if [ -s "$IN" -o X"$USEPIPES" = "Xy" ] ; then for OUTPUT in $(echo $OUTPUTTYPE | tr , \ ) do - OUT="$ABCDETEMPDIR/track$1.$OUTPUT" + case "$OUTPUT" in + vorbis|ogg) + OUT="$ABCDETEMPDIR/track$1.$OGGOUTPUTCONTAINER" + ;; + flac) + OUT="$ABCDETEMPDIR/track$1.$FLACOUTPUTCONTAINER" + ;; + *) + OUT="$ABCDETEMPDIR/track$1.$OUTPUT" + ;; + esac if [ X"$USEPIPES" = "Xy" ]; then RUN_COMMAND="" else @@ -672,7 +724,7 @@ do_encode () ;; esac ;; - ogg) + vorbis|ogg) case "$2" in %local*%) case "$OGGENCODERSYNTAX" in @@ -689,7 +741,7 @@ do_encode () case "$2" in %local*%) case "$FLACENCODERSYNTAX" in - flac) $RUN_COMMAND nice $ENCNICE $FLACENCODER $FLACENCODEROPTS -o "$OUT" "$IN" ;; + flac) $RUN_COMMAND nice $ENCNICE $FLACENCODER $FLACENCODEROPTS -o "$OUT" "$IN" ;; esac ;; @@ -823,9 +875,18 @@ do_encode () # done #} +# do_single_gain +# variables used: +# FIXME # +do_single_gain () +{ +: +} + # do_batch_gain # variables used: # MP3GAIN, MP3GAINOPTS, VORBISGAIN, VORBISGAINOPTS +# FIXME # do_batch_gain () { # The commands here don't go through run_command because they're never supposed to be silenced @@ -908,6 +969,14 @@ do_move () { for OUTPUT in $(echo $OUTPUTTYPE | tr , \ ) do + case $OUTPUT in + vorbis|ogg) + OUTPUT=$OGGOUTPUTCONTAINER + ;; + flac) + OUTPUT=$FLACOUTPUTCONTAINER + ;; + esac # Create ALBUMFILE, ARTISTFILE, TRACKFILE # Munge filenames as follows: # ' ' -> '_' @@ -940,7 +1009,33 @@ do_move () OUTPUTFILEDIR=$(dirname "$OUTPUTDIR/$OUTPUTFILE") # mkdir -p shouldn't return an error if the directory already exists mkdir -p "$OUTPUTFILEDIR" + # Silence the Moving output since it overlaps with encoding processes... + #run_command '' vecho "Moving track$1.$OUTPUT to $OUTPUTDIR/$OUTPUTFILE.$OUTPUT" run_command movetrack-$1 mv "$ABCDETEMPDIR/track$1.$OUTPUT" "$OUTPUTDIR/$OUTPUTFILE.$OUTPUT" + # Lets move the cue file + if CUEFILE=$(checkstatus cuefile) >/dev/null ; then + if [ -r "$ABCDETEMPDIR/$CUEFILE" ]; then + if checkstatus movecue-$OUTPUT; then :; else + # Silence the Copying output since it overlaps with encoding processes... + #run_command '' vecho "Copying cue file to its destination directory..." + if checkstatus onetrack >/dev/null ; then + case $OUTPUT in + # NOTE: Creating a cue file with the 3-char-extension files is to comply with + # http://brianvictor.tripod.com/mp3cue.htm#details + [a-z0-9][a-z0-9][a-z0-9]) + run_command movecue-$OUTPUT cp "$ABCDETEMPDIR/$CUEFILE" "$OUTPUTDIR/$OUTPUTFILE.cue" + ;; + *) + run_command movecue-$OUTPUT cp "$ABCDETEMPDIR/$CUEFILE" "$OUTPUTDIR/$OUTPUTFILE.$OUTPUT.cue" + ;; + esac + else + run_command movecue-$OUTPUT cp "$ABCDETEMPDIR/$CUEFILE" "$OUTPUTFILEDIR/$CUEFILE" + fi + echo movecue-$OUTPUT >> "$ABCDETEMPDIR/status" + fi + fi + fi done } @@ -959,6 +1054,7 @@ do_playlist () ALBUMFILE=$(mungefilename "$DALBUM") ARTISTFILE=$(mungefilename "$DARTIST") GENRE=$(mungegenre "$GENRE") + YEAR=${CDYEAR:-$CDYEAR} if [ "$VARIOUSARTISTS" = "y" ] ; then PLAYLISTFILE=$(eval echo $VAPLAYLISTFORMAT) else @@ -1047,12 +1143,20 @@ do_discid () #elif [ -z "$DISCID" ]; then if [ -z "$DISCID" ]; then vecho -n "Getting CD track info... " + # In OSX, unmount the disc before a query + if [ "$OSFLAVOUR" = "OSX" ]; then + disktool -u ${CDROM#/dev/} + fi TRACKINFO=$($CDDISCID $CDROM) # Make sure there's a CD in there by checking cd-discid's return code if [ "$?" = "1" ]; then echo "abcde error: CD could not be read. Perhaps there's no CD in the drive?" >&2 exit 1 fi + # In OSX, remount the disc again + if [ "$OSFLAVOUR" = "OSX" ]; then + disktool -m ${CDROM#/dev/} + fi WEHAVEACD=y else TRACKINFO=$(cat "$WAVOUTPUTDIR/abcde.$DISCID/discid") @@ -1077,7 +1181,7 @@ do_discid () cdparanoia|debug) if [ "$WEHAVEACD" = "y" ]; then vecho "Querying the CD for audio tracks..." - CDPARANOIAOUTPUT="$( $CDROMREADER -d $CDROM -Q --verbose 2>&1 )" + CDPARANOIAOUTPUT="$( $CDROMREADER -$CDPARANOIACDROMBUS $CDROM -Q --verbose 2>&1 )" RET=$? if [ ! "$RET" = "0" ];then echo "Warning: Something went wrong while querying the CD... Maybe a DATA CD?" @@ -1086,7 +1190,7 @@ do_discid () CDPARANOIAAUDIOTRACKS="$TRACKS" else if [ -f "$ABCDETEMPDIR/status" ] && checkstatus cdparanoia-audio-tracks ; then - TRACKS=$( cat $ABCDETEMPDIR/cdparanoia-audio-tracks ) + TRACKS=$( cat "$ABCDETEMPDIR/cdparanoia-audio-tracks" ) else TRACKS=$(echo $TRACKINFO | cut -f2 -d' ') fi @@ -1203,10 +1307,17 @@ do_discid () fi cat /dev/null > "$ABCDETEMPDIR/status" fi - if [ X"$CUEFILE" = "Xy" -a X"$WEHAVEACD" = "Xy" ]; then - if checkstatus cuefile ; then :; else - $MKCUE $MKCUEOPTS > $ABCDETEMPDIR/cue-$(echo $TRACKINFO | cut -f1 -d' ').txt - echo cuefile >> "$ABCDETEMPDIR/status" + if [ X"$MAKECUEFILE" = "Xy" -a X"$WEHAVEACD" = "Xy" ]; then + if checkstatus cuefile > /dev/null 2>&1 ; then :; else + CUEFILE=cue-$(echo "$TRACKINFO" | cut -f1 -d' ').txt + vecho "Creating cue file..." + if $CUEREADER $CUEREADEROPTS > "$ABCDETEMPDIR/$CUEFILE"; then + echo cuefile=$CUEFILE >> "$ABCDETEMPDIR/status" + else + echo "abcde: reading the CUE sheet with mkcue is still considered experimental" + echo "abcde: and there was a problem with the CD reading. abcde will continue," + echo "abcde: but consider reporting the problem to the abcde author" + fi fi fi # If we got the CDPARANOIA status and it is not recorded, save it now @@ -1222,6 +1333,37 @@ do_discid () echo "$TRACKINFO" > "$ABCDETEMPDIR/discid" } +# do_cleancue +# Create a proper CUE file based on the CUE file we created before. +do_cleancue() +{ + # FIXME # we can get the name of the cuefile from the status file + if CUEFILE_IN="$ABCDETEMPDIR"/$(checkstatus cuefile); then + CUEFILE_OUT=$CUEFILE_IN.out + ### FIXME ### checkstatus cddb + if [ -e "$CDDBDATA" ]; then + vecho "Adding metadata to the cue file..." + # FIXME It doesn't preserve spaces! Why? + # FIXME parse $track into PERFORMER and TITLE - abcde already has code for this? + n=1 + echo "PERFORMER \"$DARTIST\"" >> "$CUEFILE_OUT" + echo "TITLE \"$DALBUM\"" >> "$CUEFILE_OUT" + cat "$CUEFILE_IN" | while read line + do + if echo "$line" | grep -q "INDEX" + then + eval track="\$TRACK$n" + n=$(expr $n + 1) + echo "TITLE \"$track\"" >> "$CUEFILE_OUT" + fi + echo "$line" >> "$CUEFILE_OUT" + done + mv "$CUEFILE_OUT" "$CUEFILE_IN" + echo "cleancuefile" >> "$ABCDETEMPDIR/status" + fi + fi +} + # do_cddbparse # Parses a CDDB file and outputs the title and the track names. # Variables: CDDBFILE @@ -1233,6 +1375,18 @@ do_cddbparse () vecho "ONETRACK mode selected: displaying only the title of the CD..." fi echo "---- $(grep DTITLE "${CDDBPARSEFILE}" | cut '-d=' -f2- | tr -d \\r\\n ) ----" + if [ X"$SHOWCDDBYEAR" = "Xy" ]; then + PARSEDYEAR=$(grep DYEAR "${CDDBPARSEFILE}" | cut '-d=' -f2-) + if [ ! X"$PARSEDYEAR" = "X" ]; then + echo "Year: $PARSEDYEAR" + fi + fi + if [ X"$SHOWCDDBGENRE" = "Xy" ]; then + PARSEDGENRE=$(grep DGENRE "${CDDBPARSEFILE}" | cut '-d=' -f2-) + if [ ! X"$PARSEDGENRE" = "X" ]; then + echo "Genre: $PARSEDGENRE" + fi + fi if [ ! "$ONETRACK" = "y" ]; then for TRACK in $(f_seq_row 1 $TRACKS) do @@ -1414,7 +1568,7 @@ do_cddbread () # Multiple exact, (possibly multiple) inexact matches IN= if [ "$RESPONSECODE" = "211" ]; then IN=in; fi - if [ "$(wc -l < $ABCDETEMPDIR/cddbquery | tr -d ' ')" -eq 3 ]; then + if [ "$(wc -l < "$ABCDETEMPDIR/cddbquery" | tr -d ' ')" -eq 3 ]; then echo "One ${IN}exact match:" >> "$ABCDETEMPDIR/cddbchoices" tail -n +2 "$ABCDETEMPDIR/cddbquery" | head -n 1 >> "$ABCDETEMPDIR/cddbchoices" echo cddb-choice=1 >> "$ABCDETEMPDIR/status" @@ -1486,47 +1640,59 @@ do_cddbedit () else # The user has a choice to make, display the info in a pager if necessary if [ $(cat "$ABCDETEMPDIR/cddbchoices" | wc -l) -ge 24 ]; then - # Use the debian sensible-pager wrapper to pick the pager - # user has requested via their $PAGER environment variable - if [ -x "/usr/bin/sensible-pager" ]; then - /usr/bin/sensible-pager "$ABCDETEMPDIR/cddbchoices" - elif [ -x "$PAGER" ]; then - # That failed, try to load the preferred editor, starting - # with their PAGER variable - $PAGER "$ABCDETEMPDIR/cddbchoices" - # If that fails, check for less - elif [ -x /usr/bin/less ]; then - /usr/bin/less -f "$ABCDETEMPDIR/cddbchoices" - # more should be on all UNIX systems - elif [ -x /bin/more ]; then - /bin/more "$ABCDETEMPDIR/cddbchoices" - else - # No bananas, just cat the thing - cat "$ABCDETEMPDIR/cddbchoices" >&2 - fi + page "$ABCDETEMPDIR/cddbchoices" else # It's all going to fit in one page, cat it cat "$ABCDETEMPDIR/cddbchoices" >&2 fi + CDDBCHOICENUM="" + # Setting the choice to an impossible integer to avoid errors in the numeric comparisons + CDCHOICENUM=-1 # I'll take CDDB read #3 for $400, Alex - echo -n "Which entry would you like abcde to use (0 for none)? [0-$CDDBCHOICES]: " >&2 - read CDDBCHOICE - [ X"$CDDBCHOICE" = "X" ] && CDDBCHOICE=1 - # Make sure we get a valid choice - CDCHOICENUM=$(echo $CDDBCHOICE | xargs printf %d 2>/dev/null) - while [ $CDCHOICENUM -lt 0 ] || [ $CDCHOICENUM -gt $CDDBCHOICES ]; do - echo "Invalid selection. Please choose a number between 1 and $CDDBCHOICES." >&2 - echo -n "Selection [0-$CDDBCHOICES]: " >&2 + while [ $CDCHOICENUM -lt 0 ] || [ $CDCHOICENUM -gt $CDDBCHOICES ]; do + echo -n "Which entry would you like abcde to use (0 for none)? [0-$CDDBCHOICES]: " >&2 read CDDBCHOICE - CDCHOICENUM=$(echo $CDDBCHOICE | xargs printf %d 2>/dev/null) + [ X"$CDDBCHOICE" = "X" ] && CDDBCHOICE=1 + if echo $CDDBCHOICE | egrep -q "[[:digit:]]+,[[:digit:]]+" ; then + if [ ! X"$DIFF" = "X" ]; then + PARSECHOICE1=$(echo $CDDBCHOICE | cut -d"," -f1) + PARSECHOICE2=$(echo $CDDBCHOICE | cut -d"," -f2) + if [ $PARSECHOICE1 -lt 1 ] || [ $PARSECHOICE1 -gt $CDDBCHOICES ] || \ + [ $PARSECHOICE2 -lt 1 ] || [ $PARSECHOICE2 -gt $CDDBCHOICES ] || \ + [ $PARSECHOICE1 -eq $PARSECHOICE2 ]; then + echo "Invalid diff range. Please select two coma-separated numbers between 1 and $CDDBCHOICES" >&2 + else + + # We parse the 2 choices to diff, store them in temporary files and diff them. + for PARSECHOICE in $(echo $CDDBCHOICE | tr , \ ); do + do_cddbparse "$ABCDETEMPDIR/cddbread.$PARSECHOICE" > "$ABCDETEMPDIR/cddbread.parsechoice.$PARSECHOICE" + done + echo "Showing diff between choices $PARSECHOICE1 and $PARSECHOICE2..." > "$ABCDETEMPDIR/cddbread.diff" + $DIFF $DIFFOPTS "$ABCDETEMPDIR/cddbread.parsechoice.$PARSECHOICE1" "$ABCDETEMPDIR/cddbread.parsechoice.$PARSECHOICE2" >> "$ABCDETEMPDIR/cddbread.diff" + if [ $(cat "$ABCDETEMPDIR/cddbread.diff" | wc -l) -ge 24 ]; then + page "$ABCDETEMPDIR/cddbread.diff" + else + cat "$ABCDETEMPDIR/cddbread.diff" >&2 + fi + fi + else + echo "The diff program was not found in your path. Please choose a number between 0 and $CDDBCHOICES." >&2 + fi + else + if [ $CDCHOICENUM -lt 0 ] || [ $CDCHOICENUM -gt $CDDBCHOICES ]; then + # Make sure we get a valid choice + CDCHOICENUM=$(echo $CDDBCHOICE | xargs printf %d 2>/dev/null) + echo "Invalid selection. Please choose a number between 0 and $CDDBCHOICES." >&2 + fi + fi done if [ "$CDCHOICENUM" = "0" ]; then vecho "Creating empty CDDB template..." UNKNOWNDISK=y - $CDDBTOOL template $(cat "$ABCDETEMPDIR/discid") > $ABCDETEMPDIR/cddbread.0 + $CDDBTOOL template $(cat "$ABCDETEMPDIR/discid") > "$ABCDETEMPDIR/cddbread.0" else - echo "Selected: #$CDCHOICENUM ($(grep ^DTITLE= $ABCDETEMPDIR/cddbread.$CDCHOICENUM | cut -f2- -d= | tr -d \\r\\n))" >&2 + echo "Selected: #$CDCHOICENUM ($(grep ^DTITLE= "$ABCDETEMPDIR/cddbread.$CDCHOICENUM" | cut -f2- -d= | tr -d \\r\\n))" >&2 do_cddbparse "$ABCDETEMPDIR/cddbread.$CDCHOICENUM" fi echo "cddb-choice=$CDCHOICENUM" >> "$ABCDETEMPDIR/status" @@ -1575,7 +1741,7 @@ do_cddbedit () CDCHOICENUM=1 echo "cddb-choice=$CDCHOICENUM" >> "$ABCDETEMPDIR/status" fi - echo "Selected: #$CDCHOICENUM ($(grep ^DTITLE= $ABCDETEMPDIR/cddbread.$CDCHOICENUM | cut -f2- -d= | tr -d \\r\\n))" >&2 + echo "Selected: #$CDCHOICENUM ($(grep ^DTITLE= "$ABCDETEMPDIR/cddbread.$CDCHOICENUM" | cut -f2- -d= | tr -d \\r\\n))" >&2 fi fi @@ -1610,13 +1776,17 @@ do_cddbedit () if [ -x $(which "${EDITOR%%\ *}") ]; then # That failed, try to load the preferred editor, starting # with their EDITOR variable - eval $(echo "$EDITOR") "$CDDBDATA" + eval $(echo "$EDITOR") \"$CDDBDATA\" fi # If that fails, check for a vi elif which vi >/dev/null 2>&1; then vi "$CDDBDATA" + elif [ -x /usr/bin/vim ]; then + /usr/bin/vim "$CDDBDATA" elif [ -x /usr/bin/vi ]; then /usr/bin/vi "$CDDBDATA" + elif [ -x /bin/vi ]; then + /bin/vi "$CDDBDATA" # nano should be on all (modern, i.e., sarge) debian systems elif which nano >/dev/null 2>&1 ; then nano "$CDDBDATA" @@ -1722,7 +1892,7 @@ do_cddbedit () echo "variousartiststyle=$VARIOUSARTISTSTYLE" >> "$ABCDETEMPDIR/status" if [ "$EDITCDDB" = "y" ] && [ "$UNINTENTIONALLY_ANGER_THE_FREEDB_PEOPLE" = "y" ]; then - if [ $CDDBDATAMD5SUM != "" ] && [ $CDDBDATAMD5SUM != $($MD5SUM "$CDDBDATA" | cut -d " " -f 1) ]; then + if [ "$CDDBDATAMD5SUM" != "" ] && [ "$CDDBDATAMD5SUM" != "$($MD5SUM "$CDDBDATA" | cut -d " " -f 1)" ]; then # This works but does not have the necessary error checking # yet. If you are familiar with the CDDB spec # (see http://www.freedb.org/src/latest/DBFORMAT) @@ -1774,9 +1944,10 @@ do_cdread () # We need the first and last track for cdda2wav FIRSTTRACK=$2 LASTTRACK=$3 + UTRACKNUM=$FIRSTTRACK case "$CDROMREADERSYNTAX" in - cdparanoia) UTRACKNUM="$FIRSTTRACK-$LASTTRACK" ;; - cdda2wav) UTRACKNUM="$FIRSTTRACK+$LASTRACK" ;; + cdparanoia) READTRACKNUMS="$FIRSTTRACK-$LASTTRACK" ;; + cdda2wav) READTRACKNUMS="$FIRSTTRACK+$LASTRACK" ;; *) echo "abcde error: $CDROMREADERSYNTAX does not support ONETRACK mode" exit 1 ;; esac @@ -1786,7 +1957,7 @@ do_cdread () CDDBTRACKNUM=$(expr $UTRACKNUM - 1) if [ "$USEPIPES" = "y" ]; then TEMPARG="PIPE_$CDROMREADERSYNTAX" - FILEARG=${!TEMPARG} + FILEARG="$( eval echo "\$$TEMPARG" )" REDIR="" PIPE_MESSAGE="and encoding " else @@ -1797,13 +1968,13 @@ do_cdread () FILEARG="-f $WAVDATA" ;; *) - FILEARG=$WAVDATA + FILEARG="$WAVDATA" ;; esac REDIR=">&2" fi if [ "$1" = "onetrack" ]; then - echo "Grabbing ${PIPE_MESSAGE}tracks $UTRACKNUM..." >&2 + echo "Grabbing ${PIPE_MESSAGE}tracks $UTRACKNUM - $LASTTRACK as one track ..." >&2 else if [ -r "$CDDBDATA" ]; then TRACKNAME=$(grep ^TTITLE$CDDBTRACKNUM= "$CDDBDATA" | head -n 1 | cut -f2 -d= | tr -d \[:cntrl:\]) @@ -1813,7 +1984,8 @@ do_cdread () fi fi case "$CDROMREADERSYNTAX" in - cdparanoia) nice $READNICE $CDROMREADER -d $CDROM $UTRACKNUM $FILEARG $REDIR ;; + cdparanoia) + nice $READNICE $CDROMREADER -$CDPARANOIACDROMBUS $CDROM ${READTRACKNUMS:-$UTRACKNUM} "$FILEARG" $REDIR ;; cdda2wav) if [ "$OSFLAVOUR" = "OSX" ] ; then # Hei, we have to unmount the device before running anything like cdda2wav in OSX @@ -1829,11 +2001,11 @@ do_cdread () CDDA2WAVCDROM="$CDROMID" fi fi - nice $READNICE $CDROMREADER -D $CDDA2WAVCDROM -t $UTRACKNUM $FILEARG $REDIR + nice $READNICE $CDROMREADER -D $CDDA2WAVCDROM -t ${READTRACKNUMS:-$UTRACKNUM} "$FILEARG" $REDIR ;; ## FIXME ## We have an exception for dagrab, since it uses -f ## FIXME ## Shall we just use -f $FILEARG ?? - dagrab) nice $READNICE $CDROMREADER -d $CDROM -v $UTRACKNUM $FILEARG $REDIR + dagrab) nice $READNICE $CDROMREADER -d $CDROM -v $UTRACKNUM "$FILEARG" $REDIR ;; cddafs) # Find the track's mounted path @@ -1842,11 +2014,11 @@ do_cdread () FILEPATH=$(find "$FILEPATH" | grep "/$REALTRACKNUM "); # If the file exists, copy it if [ -e "$FILEPATH" ] ; then - nice $READNICE $CDROMREADER "$FILEPATH" $FILEARG $REDIR + nice $READNICE $CDROMREADER "$FILEPATH" "$FILEARG" $REDIR else false fi ;; - debug) nice $READNICE $CDROMREADER -d $CDROM -w $UTRACKNUM-[:1] $FILEARG $REDIR + debug) nice $READNICE $CDROMREADER -$CDPARANOIACDROMBUS $CDROM -w $UTRACKNUM-[:1] "$FILEARG" $REDIR ;; esac RETURN=$? @@ -1869,6 +2041,9 @@ do_cdread () echo readencodetrack-$UTRACKNUM >> "$ABCDETEMPDIR/status" else echo readtrack-$UTRACKNUM >> "$ABCDETEMPDIR/status" + if [ "$1" = "onetrack" ]; then + echo onetrack >> "$ABCDETEMPDIR/status" + fi fi fi } @@ -1915,6 +2090,13 @@ pre_read () : } +# post_read +# Empty post_read function, to be defined in the configuration file. +post_read () +{ +: +} + ############################################################################### # End of functions # @@ -1926,9 +2108,15 @@ CDDBURL="http://freedb.freedb.org/~cddb/cddb.cgi" CDDBSUBMIT=freedb-submit@freedb.org CDDBPROTO=5 HELLOINFO="$(whoami)@$(hostname)" +CDDBCOPYLOCAL="n" +CDDBLOCALDIR="$HOME/.cddb" +CDDBUSELOCAL="n" + +# List of fields we parse and show during the CDDB parsing... +SHOWCDDBFIELDS="year,genre" + INTERACTIVE=y CDROMREADERSYNTAX=cdparanoia -OUTPUTTYPE=ogg ENCODERSYNTAX=default MP3ENCODERSYNTAX=default @@ -1937,6 +2125,7 @@ FLACENCODERSYNTAX=default SPEEXENCODERSYNTAX=default MPPENCODERSYNTAX=default NORMALIZERSYNTAX=default +CUEREADERSYNTAX=default OUTPUTFORMAT='${ARTISTFILE}-${ALBUMFILE}/${TRACKNUM}.${TRACKFILE}' # Use the following VAOUTPUTFORMAT to revert to 2.0.x VA format: @@ -1958,13 +2147,13 @@ VARIOUSARTISTS=n VARIOUSARTISTSTYLE=forward KEEPWAVS=n PADTRACKS=n -CDDBCOPYLOCAL="n" -CDDBLOCALDIR="$HOME/.cddb" -CDDBUSELOCAL="n" # If using scsi devices, cdda2wav needs a CDROMID, instead of a device node # i.e. CDROMID="1,0,0" CDROMID="" +# If we are using the IDE bus, we need CDPARANOIACDROMBUS defined as "d" +# If we are using the ide-scsi emulation layer, we need to define a "g" +CDPARANOIACDROMBUS="d" # program paths - defaults to checking your $PATH # mp3 @@ -1986,6 +2175,7 @@ MPPENC=mppenc ID3=id3 ID3V2=id3v2 +EYED3=eyeD3 CDPARANOIA=cdparanoia CDDA2WAV=cdda2wav DAGRAB=dagrab @@ -2001,6 +2191,8 @@ NORMALIZE=normalize-audio CDSPEED=eject VORBISGAIN=vorbisgain MKCUE=mkcue +MKTOC=cdrdao +DIFF=diff # Options for programs called from abcde # mp3 @@ -2014,7 +2206,7 @@ MP3ENCOPTS= VORBIZEOPTS= OGGENCOPTS= # flac -FLACOPTS= +FLACOPTS="-f" # speex SPEEXENCOPTS= # mpc @@ -2033,6 +2225,7 @@ NORMALIZEOPTS= CDSPEEDOPTS="-x" CDSPEEDVALUE= MKCUEOPTS= +MKTOCOPTS="" VORBISCOMMENTOPTS="-R" METAFLACOPTS="--no-utf8-convert" @@ -2042,10 +2235,15 @@ MAXPROCS=1 # List of actions to perform - by default, run to completion ACTIONS=cddb,read,encode,tag,move,clean +# List of prefered outputs - by default, run with whatever we have in the path +# This option is basicaly for Debian package dependencies +DEFAULT_OUTPUT_BINARIES=vorbis:oggenc,flac:flac,mp3:lame,mp3:bladeenc,spx:speex + # Asume fetch if under FreeBSD. curl is used for Mac OS X. wget is used for Linux/OpenBSD/NetBSD. # Let's use these checkings to determine the OS flavour, which will be used later if [ X$(uname) = "XFreeBSD" ] ; then HTTPGET=fetch + MD5SUM=md5 NEEDCDROMID=y OSFLAVOUR=FBSD elif [ X$(uname) = "XDarwin" ] ; then @@ -2053,9 +2251,13 @@ elif [ X$(uname) = "XDarwin" ] ; then OSFLAVOUR=OSX # We should have disktool in OSX, but let's be sure... NEEDDISKTOOL=y + CDROMREADERSYNTAX=cddafs elif [ X$(uname) = "XOpenBSD" ] ; then HTTPGET=wget MD5SUM=md5 +elif [ X$(uname) = "XNetBSD" ] ; then + HTTPGET=ftp + MD5SUM=md5 else HTTPGET=wget fi @@ -2091,6 +2293,7 @@ if [ "$HTTPGETOPTS" = "" ] ; then wget) HTTPGETOPTS="-q -O -";; curl) HTTPGETOPTS="-f -s";; fetch)HTTPGETOPTS="-q -o -";; + ftp) HTTPGETOPTS="-q -o -";; *) echo "abcde warning: HTTPGET in non-standard and HTTPGETOPTS are not defined." >&2 ;; esac fi @@ -2113,12 +2316,12 @@ if [ "$CDROM" = "" ] ; then fi # Parse command line options -#while getopts 1a:bc:C:d:Dhj:klLnNo:pr:S:t:T:vVx opt ; do -while getopts 1a:A:bc:C:d:Dehj:klLmMnNo:pPr:Rs:S:t:T:vVxw:W: opt ; do +#while getopts 1a:A:bc:C:d:Dehj:klLmMnNo:pPr:Rs:S:t:T:vVxw:W: opt ; do +while getopts 1a:bc:C:d:Dehj:klLmMnNo:pPr:Rs:S:t:T:vVxw:W: opt ; do case "$opt" in 1) ONETRACK=y ;; a) ACTIONS="$OPTARG" ;; - A) EXPACTIONS="$OPTARG";; + A) EXPACTIONS="$OPTARG" ;; b) BATCH=y ;; c) if [ -e "$OPTARG" ] ; then . "$OPTARG" ; else echo "abcde error: config file \"$OPTARG\" cannot be found." >&2 ; exit 1 ; fi ;; C) DISCID="${OPTARG#abcde.}" ;; @@ -2127,6 +2330,7 @@ while getopts 1a:A:bc:C:d:Dehj:klLmMnNo:pPr:Rs:S:t:T:vVxw:W: opt ; do e) ERASEENCODEDSTATUS=y ;; h) usage; exit ;; e) ERASEENCODEDSTATUS=y ;; + E) ENCODING="$OPTARG" ;; # f) FORCECDDBUSELOCAL=y ;; i) INLINETAG=y ;; j) MAXPROCS="$OPTARG" ;; @@ -2136,13 +2340,13 @@ while getopts 1a:A:bc:C:d:Dehj:klLmMnNo:pPr:Rs:S:t:T:vVxw:W: opt ; do n) CDDBAVAIL=n ;; N) INTERACTIVE=n ;; m) DOSPLAYLIST=y ;; - M) CUEFILE=y ;; + M) MAKECUEFILE=y ;; o) OUTPUTTYPE="$OPTARG" ;; p) PADTRACKS=y ;; P) USEPIPES=y ;; r) REMOTEHOSTS="$OPTARG" ;; R) REPLAYGAIN=y ;; - s) STARTTRACKNUMBER="$OPTARG" ;; + s) SHOWCDDBFIELDS="$OPTARG" ;; S) CDSPEEDVALUE="$OPTARG" ;; # t) PREPROCESSFORMATS="$OPTARG" # PREPROCESS=y ;; @@ -2175,8 +2379,10 @@ shift $(($OPTIND - 1)) if [ "$ONETRACK" = "y" ]; then # FIXME # remove check as soon as we find out about the other readers case "$CDROMREADERSYNTAX" in - dagrab|cddafs|debug) echo "abcde error: ONETRACK reading is not suported with $CDROMREADERSYNTAX yet" - exit 1 ;; + cdparanoia) ;; + cdda2wav) ;; + *) echo "abcde error: $CDROMREADERSYNTAX does not support ONETRACK mode" + exit 1 ;; esac if [ "$BATCH" = "y" ]; then echo "abcde error: BATCH mode is not compatible with ONETRACK mode" @@ -2234,6 +2440,14 @@ do esac done +for SHOWCDDBFIELD in $(echo $SHOWCDDBFIELDS | tr , \ ); do + case $SHOWCDDBFIELD in + y*|Y*) SHOWCDDBYEAR="y";; + g*|G*) SHOWCDDBGENRE="y";; + *) ;; + esac +done + # Sanity checks: # At this point a CDROM has to be defined, so we check it exists. @@ -2263,8 +2477,8 @@ fi # - lowdisk algorithm # - anything else? if [ X"$USEPIPES" = "Xy" ]; then - if [ $(echo $OUTPUTTYPE | tr , \ | wc -w ) -gt 1 ]; then - echo "abcde error: Unix pipes not compatible with multiple outputs" + if [ $(echo "$OUTPUTTYPE" | tr , \ | wc -w ) -gt 1 ]; then + echo "abcde error: Unix pipes not compatible with multiple outputs" >&2 exit 1 fi if [ X"$DONORMALIZE" = "Xy" ]; then @@ -2282,6 +2496,24 @@ if [ X"$USEPIPES" = "Xy" ]; then fi fi +# Check the encoding format from the ones available in the system, if nothing has been configured in the system. +if [ X"$OUTPUTTYPE" = "X" ]; then + for DEFAULT_OUTPUT in $( echo "$DEFAULT_OUTPUT_BINARIES" | tr , \ ); do + DEFAULT_OUTPUT_FORMAT="$(echo $DEFAULT_OUTPUT | cut -d ":" -f 1)" + DEFAULT_OUTPUT_BINARY="$(echo $DEFAULT_OUTPUT | cut -d ":" -f 2)" + if [ -x $(which $DEFAULT_OUTPUT_BINARY) ] ; then + OUTPUTTYPE=$DEFAULT_OUTPUT_FORMAT + vecho "No default output type defined. Autoselecting $OUTPUTTYPE..." >&2 + break + fi + done + if [ X"$OUTPUTTYPE" = "X" ]; then + echo "abcde error: no encoder found in the PATH" >&2 + echo "hits: are all dependencies installed? has the \$PATH been modified?" >&2 + exit 1 + fi +fi + # Decide which CDROM reader we're gonna use case "$CDROMREADERSYNTAX" in cdparanoia|debug) @@ -2311,26 +2543,21 @@ case "$NORMALIZERSYNTAX" in esac # Allow -o OUTPUT(1):OPTIONS(1),...,OUTPUT(N):OPTIONS(N) mode of operation -if echo $OUTPUTTYPE | grep ":" > /dev/null 2>&1 ; then - OLDFS="$FS" - export FS="," - for OUTPUT in "$OUTPUTTYPE" - do +if echo "$OUTPUTTYPE" | grep ":" > /dev/null 2>&1 ; then + for OUTPUT in $(echo $OUTPUTTYPE | tr , \ ); do case "$OUTPUT" in - ogg:*) OGGENCODEROPTSCLI="$( echo $OUTPUT | cut -d: -f2- )" ;; + vorbis:*|ogg:*) OGGENCODEROPTSCLI="$( echo $OUTPUT | cut -d: -f2- )" ;; mp3:*) MP3ENCODEROPTSCLI="$( echo $OUTPUT | cut -d: -f2- )" ;; flac:*) FLACENCODEROPTSCLI="$( echo $OUTPUT | cut -d: -f2- )" ;; spx:*) SPEEXENCODEROPTSCLI="$( echo $OUTPUT | cut -d: -f2- )" ;; mpc:*) MPPENCODEROPTSCLI="$( echo $OUTPUT | cut -d: -f2- )" ;; esac done - for OUTPUT in "$OUTPUTTYPE" - do + for OUTPUT in $(echo $OUTPUTTYPE | tr , \ ); do TEMPOUTPUT=$( echo "$OUTPUT" | cut -d: -f1 ) TEMPOUTPUTTYPE="${TEMPOUTPUTTYPE:+$TEMPOUTPUTTYPE,}$TEMPOUTPUT" done OUTPUTTYPE="$TEMPOUTPUTTYPE" - FS="$OLDFS" fi # If nothing has been specified, use oggenc for oggs and lame for mp3s and flac for flacs and speexenc for speex and mppenc for mpps @@ -2339,18 +2566,26 @@ fi for OUTPUT in $(echo $OUTPUTTYPE | tr , \ ) do case $OUTPUT in - ogg) [ "$OGGENCODERSYNTAX" = "default" ] && OGGENCODERSYNTAX=oggenc - [ "$DOTAG" = "y" ] && NEEDCOMMENTER=y - [ "$REPLAYGAIN" = "y" ] && NEEDVORBISGAIN=y - ;; - mp3) [ "$MP3ENCODERSYNTAX" = "default" ] && MP3ENCODERSYNTAX=lame - [ "$DOTAG" = "y" ] && NEEDTAGGER=y - ;; - flac) [ "$FLACENCODERSYNTAX" = "default" ] && FLACENCODERSYNTAX=flac - [ "$DOTAG" = "y" ] && NEEDMETAFLAC=y - ;; - spx) [ "$SPEEXENCODERSYNTAX" = "default" ] && SPEEXENCODERSYNTAX=speexenc ;; - mpc) [ "$MPPENCODERSYNTAX" = "default" ] && MPPENCODERSYNTAX=mppenc ;; + vorbis|ogg) + [ "$OGGENCODERSYNTAX" = "default" ] && OGGENCODERSYNTAX=oggenc + [ "$DOTAG" = "y" ] && NEEDCOMMENTER=y + [ "$REPLAYGAIN" = "y" ] && NEEDVORBISGAIN=y + OGGOUTPUTCONTAINER=ogg + ;; + mp3) + [ "$MP3ENCODERSYNTAX" = "default" ] && MP3ENCODERSYNTAX=lame + [ "$DOTAG" = "y" ] && NEEDTAGGER=y + ;; + flac) + [ "$FLACENCODERSYNTAX" = "default" ] && FLACENCODERSYNTAX=flac + [ "$DOTAG" = "y" ] && NEEDMETAFLAC=y + ;; + spx) + [ "$SPEEXENCODERSYNTAX" = "default" ] && SPEEXENCODERSYNTAX=speexenc + ;; + mpc) + [ "$MPPENCODERSYNTAX" = "default" ] && MPPENCODERSYNTAX=mppenc + ;; *) echo "abcde error: Invalid OUTPUTTYPE defined" >&2 exit 1 ;; @@ -2398,9 +2633,14 @@ case "$FLACENCODERSYNTAX" in flac) FLACENCODEROPTS="${FLACENCODEROPTSCLI:-$FLACOPTS}" FLACENCODER="$FLAC" - ## FIXME ## FLAC streams can be encapsulated on a Ogg transport layer + # FLAC streams can be encapsulated on a Ogg transport layer if echo "$FLACENCODEROPTS" | egrep -q -- "(^| )--ogg($| )" ;then - FLACONOGG=y + echo "abcde error: FLAC on an Ogg container is not yet supported" >&2 + echo " due to problem with adding comments to such files" >&2 + exit 1 + FLACOUTPUTCONTAINER=ogg + else + FLACOUTPUTCONTAINER=flac fi ;; esac @@ -2427,6 +2667,24 @@ else TAGGEROPTS="$ID3V2OPTS" fi +# Options for mkcue +case "$CUEREADERSYNTAX" in + default|mkcue) + CUEREADEROPTS="${CDROM}" + CUEREADER="$MKCUE" + ;; +esac + +# Check if both OGGEOUTPUTCONTAINER and FLACOUTPUTCONTAINER are the same, and differentiante them +if [ X"$OGGOUTPUTCONTAINER" = "Xogg" ] && [ X"$FLACOUTPUTCONTAINER" = "Xogg" ]; then + echo "abcde error: FLAC on an Ogg container is not yet supported" >&2 + echo " due to problem with adding comments to such files" >&2 + exit 1 + OGGOUTPUTCONTAINER=ogg.ogg + FLACOUTPUTCONTAINER=flac.ogg + vecho "abcde warning: modified file endings due to conflicting transport layers in Ogg/Vorbis and Ogg/FLAC" +fi + # Clean up nice options (either use '-n NICELEVEL or -NICELEVEL') if [ "$ENCNICE" ]; then @@ -2452,8 +2710,8 @@ fi if [ ! "$CDDBAVAIL" = "n" ] && [ "$DOCDDB" = "y" ]; then NEEDHTTPGET=y fi -if [ "$CUEFILE" = "y" ]; then - NEEDMKCUE=y +if [ "$MAKECUEFILE" = "y" ]; then + NEEDCUEREADER=y fi if [ X"$CDSPEEDVALUE" != "X" ]; then @@ -2480,22 +2738,22 @@ if [ "$USEPIPES" = "y" ]; then case "$OUTPUT" in mp3) PIPEENCODERSVARCHECK="PIPE_$MP3ENCODERSYNTAX" ;; - ogg) + vorbis|ogg) PIPEENCODERSVARCHECK="PIPE_$OGGENCODERSYNTAX" ;; flac) - PIPEENCODERSVARCHECK="PIPE_$FLACENCODERSYTNAX" ;; + PIPEENCODERSVARCHECK="PIPE_$FLACENCODERSYNTAX" ;; spx) PIPEENCODERSVARCHECK="PIPE_$SPEEXENCODER" ;; mpc) PIPEENCODERSVARCHECK="PIPE_$MPPENCODER" ;; esac - if [ ! -n "${!PIPERIPPERSVARCHECK}" ] ; then + if [ ! -n "$( eval echo "\$$PIPERIPPERSVARCHECK" )" ] ; then echo "abcde error: no support for pipes with given ripper" >&2 echo "read the USEPIPES file from the source tarball to help" >&2 echo "on a Debian system, read /usr/share/doc/abcde/USEPIPES.gz" >&2 exit 1; fi - if [ ! -n "${!PIPEENCODERSVARCHECK}" ] ; then + if [ ! -n "$( eval echo "\$$PIPEENCODERSVARCHECK" )" ] ; then echo "abcde error: no support for pipes with given encoder" >&2 echo "read the USEPIPES file from the source tarball to help" >&2 echo "on a Debian system, read /usr/share/doc/abcde/USEPIPES.gz" >&2 @@ -2503,7 +2761,6 @@ if [ "$USEPIPES" = "y" ]; then fi fi - # Make sure a buncha things exist for X in $CDROMREADER $CDDISCID ${NEEDTAGGER+$TAGGER} $MP3ENCODER \ $OGGENCODER $FLACENCODER $SPEEXENCODER $MPPENCODER \ @@ -2511,7 +2768,7 @@ for X in $CDROMREADER $CDDISCID ${NEEDTAGGER+$TAGGER} $MP3ENCODER \ ${NEEDCOMMENTER+$VORBISCOMMENT} ${NEEDMETAFLAC+$METAFLAC} \ ${NEEDNORMALIZER+$NORMALIZER} ${NEEDEJECT+$EJECT} \ ${NEEDDISKTOOL+disktool} ${NEEDCDSPEED+$CDSPEED} \ - ${NEEDVORBISGAIN+$VORBISGAIN} ${NEEDMKCUE+$MKCUE} + ${NEEDVORBISGAIN+$VORBISGAIN} ${NEEDCUEREADER+$CUEREADER} do # Cut off the command-line options we just added in X=$(echo $X | cut -d' ' -f2) @@ -2528,9 +2785,15 @@ CDROMREADER="$CDROMREADER $CDROMREADEROPTS" CDDBTOOL="$CDDBTOOL $CDDBTOOLOPTS" HTTPGET="$HTTPGET $HTTPGETOPTS" +# And last but not least, check if we can diff between files +if [ -x $(which $DIFF) ]; then :; else + vecho "[WAR] Disabling diff since we cannot find it in the \$PATH..." + DIFF="" +fi + # Here it used to say: # One thousand lines in, we can start doing stuff with things -# Well, right now we are at line 2157 ;) +# Well, right now we are at line 2736 ;) # Export needed things so they can be read in this subshell export CDDBTOOL ABCDETEMPDIR TRACKQUEUE LOWDISK EJECTCD EJECT EJECTOPTS @@ -2657,6 +2920,9 @@ if [ "$BATCH" = "y" ] || [ "$ONETRACK" = "y" ]; then echo NEXTTRACK fi +# Execute the user-defined post_read funtion before ejecting CD +post_read + # We are now finished with the cdrom - it can be safely ejected. Note that # abcde will not have completed yet. if [ "$EJECTCD" = "y" ] && [ -x $(which $EJECT) ]; then @@ -2825,6 +3091,12 @@ do if checkstatus encodetrack-$UTRACKNUM; then if checkstatus tagtrack-$UTRACKNUM; then :; else do_tag $UTRACKNUM; fi fi + # Lets tag the cue file + if checkstatus cleancuefile >/dev/null; then :; else + if checkstatus cuefile >/dev/null ; then + do_cleancue + fi + fi fi if [ "$DOMOVE" = "y" ]; then if checkstatus tagtrack-$UTRACKNUM; then @@ -2833,6 +3105,8 @@ do fi ) & done + + # Go through it again and make sure there's no distmp3 stragglers, otherwise # we'll delete the files they're working on ## FIXME ## Check also for files which are encoded using PIPEs.