X-Git-Url: https://git.hcoop.net/clinton/abcde.git/blobdiff_plain/5a433968f923c2180b54b2d75103c8e09889e05e..65f3ebb1eb2e4d92774d4b8fdfaa21488d58c297:/abcde diff --git a/abcde b/abcde index 6fe90c3..7c83716 100755 --- a/abcde +++ b/abcde @@ -30,6 +30,7 @@ echo " Specify discid to resume from (only needed if you no longer have th echo "-d " echo " Specify CDROM device to grab" echo "-D Debugging mode (equivalent to sh -x abcde)" +echo "-e Erase encoded track information from status file" echo "-h This help information" #echo "-i Tag files while encoding, when possible (local only) -NWY-" echo "-j <#> Number of encoder processes to run at once (localhost)" @@ -41,12 +42,12 @@ echo "-N Noninteractive. Never prompt for anything" echo "-m Modify playlist to include CRLF endings, to comply with some players" echo "-M Create a CUE file" echo "-o " -echo " Output file type(s) (ogg,mp3,flac,spx,mpc). Defaults to ogg" +echo " Output file type(s) (vorbis,mp3,flac,spx,mpc). Defaults to vorbis" echo "-p Pad track numbers with 0's (if less than 10 tracks)" echo "-P Use UNIX pipes to read+encode without wav files" echo "-r " echo " Also encode on these remote hosts" -echo "-R Add replaygain values to the tag info (only for ogg,flac)" +echo "-R Add replaygain values to the tag info (only for vorbis,flac)" echo "-S <#> Set the CD speed" #echo "-t File types to preprocess (wav)" #echo "-T Set postprocessing options" @@ -60,7 +61,9 @@ echo " Add a comment to the CD tracks" echo "-W <#> Contatenate CDs: -T #01 -w \"CD #\"" echo "" echo "Tracks is a space-delimited list of tracks to grab." -echo "Ranges specified with hyphens are allowed." +echo "Ranges specified with hyphens are allowed (i.e., 1-5)." +echo "" +#echo "Double hyphens are used to concatenate tracks" } # Funtions to replace the need of seq, which is too distribution dependant. @@ -85,6 +88,31 @@ f_seq_line () echo } +# Functions to replace the need of awk {print $1} and {print $NF} +get_first() +{ +if [ X"$1" = "X" ]; then + for first in `cat`; do + break + done +else + first=$1 +fi +echo $first +} + +get_last() +{ +if [ X"$1" = "X" ]; then + for stdin in `cat`; do + last=$stdin + done +else + for last in $@ ; do :; done +fi +echo $last +} + # checkstatus [blurb] # Returns "0" if the blurb was found, returns 1 if it wasn't # Puts the blurb content, if available, on stdout. @@ -120,7 +148,7 @@ checkerrors () fi # Take the last line in the status file if there's multiple matches PATTERN="^$1(:.*)?$" - BLURB="$(egrep $PATTERN $ABCDETEMPDIR/errors | tail -n 1)" + BLURB="$(egrep $PATTERN "$ABCDETEMPDIR/errors" | tail -n 1)" if [ -z "$BLURB" ]; then # negative, we did not have a negative... @@ -451,7 +479,7 @@ do_tag () if [ -n "$STARTTRACKNUMBER" -a -n "$STARTTRACKNUMBERTAG" ] ; then # Get the trackpadding from the current track CURRENTTRACKPADDING=$(echo -n $UTRACKNUM | wc -c) - TRACKNUM=$( printf %0.${CURRENTTRACKPADDING}d $(expr ${UTRACKNUM} + ${STARTTRACKNUMBER} - 1 )) + TRACKNUM=$( printf %0.${CURRENTTRACKPADDING}d $(expr ${UTRACKNUM} + ${STARTTRACKNUMBER} - $FIRSTTRACK )) fi for OUTPUT in $(echo $OUTPUTTYPE | tr , \ ) do @@ -466,24 +494,24 @@ do_tag () -g "$GENREID" -T "${TRACKNUM:-$1/$TRACKS}" \ "$ABCDETEMPDIR/track$1.$OUTPUT" ;; - ogg) + vorbis|ogg) case "$OGGENCODERSYNTAX" in vorbize|oggenc) # vorbiscomment can't do in-place modification, mv the file first - if [ -f "$ABCDETEMPDIR/track$1.$OUTPUT" -a ! -f "$ABCDETEMPDIR/track$1.uncommented.$OUTPUT" ]; then - mv "$ABCDETEMPDIR/track$1.$OUTPUT" "$ABCDETEMPDIR/track$1.uncommented.$OUTPUT" + if [ -f "$ABCDETEMPDIR/track$1.$OGGOUTPUTCONTAINER" -a ! -f "$ABCDETEMPDIR/track$1.uncommented.$OGGOUTPUTCONTAINER" ]; then + mv "$ABCDETEMPDIR/track$1.$OGGOUTPUTCONTAINER" "$ABCDETEMPDIR/track$1.uncommented.$OGGOUTPUTCONTAINER" fi ( # These are from http://www.xiph.org/ogg/vorbis/doc/v-comment.html echo ARTIST="$TRACKARTIST" echo ALBUM="$DALBUM" echo TITLE="$TRACKNAME" - if [ -n "$CDYEAR" ]; then + if [ -n "$CDYEAR" ]; then echo DATE="$CDYEAR" - fi - if [ -n "$CDGENRE" ]; then + fi + if [ -n "$CDGENRE" ]; then echo GENRE="$CDGENRE" - fi + fi echo TRACKNUMBER=${TRACKNUM:-$1} echo CDDB=$CDDBDISCID if [ "$(eval echo ${COMMENT})" != "" ]; then @@ -492,29 +520,28 @@ do_tag () *) echo COMMENT="$COMMENTOUTPUT";; esac fi - ) | run_command tagtrack-$1 $VORBISCOMMENT -w \ - "$ABCDETEMPDIR/track$1.uncommented.$OUTPUT" "$ABCDETEMPDIR/track$1.$OUTPUT" + ) | run_command tagtrack-$1 $VORBISCOMMENT $VORBISCOMMENTOPTS -w \ + "$ABCDETEMPDIR/track$1.uncommented.$OGGOUTPUTCONTAINER" "$ABCDETEMPDIR/track$1.$OGGOUTPUTCONTAINER" # Doublecheck that the commented file was created successfully before wiping the original - if [ -f "$ABCDETEMPDIR/track$1.$OUTPUT" ]; then - rm -f "$ABCDETEMPDIR/track$1.uncommented.$OUTPUT" + if [ -f "$ABCDETEMPDIR/track$1.$OGGOUTPUTCONTAINER" ]; then + rm -f "$ABCDETEMPDIR/track$1.uncommented.$OGGOUTPUTCONTAINER" else - mv "$ABCDETEMPDIR/track$1.uncommented.$OUTPUT" "$ABCDETEMPDIR/track$1.$OUTPUT" + mv "$ABCDETEMPDIR/track$1.uncommented.$OGGOUTPUTCONTAINER" "$ABCDETEMPDIR/track$1.$OGGOUTPUTCONTAINER" fi ;; esac ;; flac) -## FIXME ## [ "$FLACONOGG" = "y" ] && OUTPUT=ogg - ( + ( echo ARTIST="$TRACKARTIST" echo ALBUM="$DALBUM" echo TITLE="$TRACKNAME" - if [ -n "$CDYEAR" ]; then + if [ -n "$CDYEAR" ]; then echo DATE="$CDYEAR" - fi - if [ -n "$CDGENRE" ]; then + fi + if [ -n "$CDGENRE" ]; then echo GENRE="$CDGENRE" - fi + fi echo TRACKNUMBER=${TRACKNUM:-$1} echo CDDB=$CDDBDISCID if [ "$(eval echo ${COMMENT})" != "" ]; then @@ -523,7 +550,7 @@ do_tag () *) echo COMMENT="$COMMENTOUTPUT";; esac fi - ) | run_command tagtrack-$1 $METAFLAC --no-utf8-convert --import-tags-from=- "$ABCDETEMPDIR/track$1.$OUTPUT" + ) | run_command tagtrack-$1 $METAFLAC $METAFLACOPTS --import-tags-from=- "$ABCDETEMPDIR/track$1.$FLACOUTPUTCONTAINER" ;; spx) run_command tagtrack-$1 true @@ -584,7 +611,7 @@ do_encode () mp3) TEMPARG="PIPE_$MP3ENCODERSYNTAX" ;; - ogg) + vorbis|ogg) TEMPARG="PIPE_$OGGENCODERSYNTAX" ;; flac) @@ -608,12 +635,12 @@ do_encode () FILEARG="-if $IN" ;; *) - FILEARG=$IN + FILEARG="$IN" ;; esac ;; *) - FILEARG=$IN + FILEARG="$IN" ;; esac fi @@ -621,7 +648,17 @@ do_encode () if [ -s "$IN" -o X"$USEPIPES" = "Xy" ] ; then for OUTPUT in $(echo $OUTPUTTYPE | tr , \ ) do - OUT="$ABCDETEMPDIR/track$1.$OUTPUT" + case "$OUTPUT" in + vorbis|ogg) + OUT="$ABCDETEMPDIR/track$1.$OGGOUTPUTCONTAINER" + ;; + flac) + OUT="$ABCDETEMPDIR/track$1.$FLACOUTPUTCONTAINER" + ;; + *) + OUT="$ABCDETEMPDIR/track$1.$OUTPUT" + ;; + esac if [ X"$USEPIPES" = "Xy" ]; then RUN_COMMAND="" else @@ -645,7 +682,7 @@ do_encode () ;; esac ;; - ogg) + vorbis|ogg) case "$2" in %local*%) case "$OGGENCODERSYNTAX" in @@ -662,7 +699,7 @@ do_encode () case "$2" in %local*%) case "$FLACENCODERSYNTAX" in - flac) $RUN_COMMAND nice $ENCNICE $FLACENCODER $FLACENCODEROPTS -o "$OUT" "$IN" ;; + flac) $RUN_COMMAND nice $ENCNICE $FLACENCODER $FLACENCODEROPTS -o "$OUT" "$IN" ;; esac ;; @@ -796,9 +833,18 @@ do_encode () # done #} +# do_single_gain +# variables used: +# FIXME # +do_single_gain () +{ +: +} + # do_batch_gain # variables used: # MP3GAIN, MP3GAINOPTS, VORBISGAIN, VORBISGAINOPTS +# FIXME # do_batch_gain () { # The commands here don't go through run_command because they're never supposed to be silenced @@ -881,6 +927,14 @@ do_move () { for OUTPUT in $(echo $OUTPUTTYPE | tr , \ ) do + case $OUTPUT in + vorbis|ogg) + OUTPUT=$OGGOUTPUTCONTAINER + ;; + flac) + OUTPUT=$FLACOUTPUTCONTAINER + ;; + esac # Create ALBUMFILE, ARTISTFILE, TRACKFILE # Munge filenames as follows: # ' ' -> '_' @@ -898,7 +952,7 @@ do_move () if [ -n "$STARTTRACKNUMBER" ] ; then # Get the trackpadding from the current track CURRENTTRACKPADDING=$(echo -n $UTRACKNUM | wc -c) - TRACKNUM=$( printf %0.${CURRENTTRACKPADDING}d $(expr ${UTRACKNUM} + ${STARTTRACKNUMBER} - 1 )) + TRACKNUM=$( printf %0.${CURRENTTRACKPADDING}d $(expr ${UTRACKNUM} + ${STARTTRACKNUMBER} - $FIRSTTRACK )) else TRACKNUM=${UTRACKNUM} fi @@ -913,7 +967,31 @@ do_move () OUTPUTFILEDIR=$(dirname "$OUTPUTDIR/$OUTPUTFILE") # mkdir -p shouldn't return an error if the directory already exists mkdir -p "$OUTPUTFILEDIR" + vecho "Moving $ABCDETEMPDIR/track$1.$OUTPUT to $OUTPUTDIR/$OUTPUTFILE.$OUTPUT" run_command movetrack-$1 mv "$ABCDETEMPDIR/track$1.$OUTPUT" "$OUTPUTDIR/$OUTPUTFILE.$OUTPUT" + # Lets move the cue file + if CUEFILE=$(checkstatus cuefile) >/dev/null ; then + if [ -r "$ABCDETEMPDIR/$CUEFILE" ]; then + if checkstatus movecue-$OUTPUT; then :; else + vecho "Copying cue file to its destination directory..." + if checkstatus onetrack >/dev/null ; then + case $OUTPUT in + # NOTE: Creating a cue file with the 3-char-extension files is to comply with + # http://brianvictor.tripod.com/mp3cue.htm#details + [a-z0-9][a-z0-9][a-z0-9]) + run_command movecue-$OUTPUT cp "$ABCDETEMPDIR/$CUEFILE" "$OUTPUTDIR/$OUTPUTFILE.cue" + ;; + *) + run_command movecue-$OUTPUT cp "$ABCDETEMPDIR/$CUEFILE" "$OUTPUTDIR/$OUTPUTFILE.$OUTPUT.cue" + ;; + esac + else + run_command movecue-$OUTPUT cp "$ABCDETEMPDIR/$CUEFILE" "$OUTPUTFILEDIR/$CUEFILE" + fi + echo movecue-$OUTPUT >> "$ABCDETEMPDIR/status" + fi + fi + fi done } @@ -932,6 +1010,7 @@ do_playlist () ALBUMFILE=$(mungefilename "$DALBUM") ARTISTFILE=$(mungefilename "$DARTIST") GENRE=$(mungegenre "$GENRE") + YEAR=${CDYEAR:-$CDYEAR} if [ "$VARIOUSARTISTS" = "y" ] ; then PLAYLISTFILE=$(eval echo $VAPLAYLISTFORMAT) else @@ -974,7 +1053,7 @@ do_playlist () if [ -n "$STARTTRACKNUMBER" ] ; then # Get the trackpadding from the current track CURRENTTRACKPADDING=$(echo -n $UTRACKNUM | wc -c) - TRACKNUM=$( printf %0.${CURRENTTRACKPADDING}d $(expr ${UTRACKNUM} + ${STARTTRACKNUMBER} - 1 )) + TRACKNUM=$( printf %0.${CURRENTTRACKPADDING}d $(expr ${UTRACKNUM} + ${STARTTRACKNUMBER} - $FIRSTTRACK )) else TRACKNUM=${UTRACKNUM} fi @@ -1020,12 +1099,20 @@ do_discid () #elif [ -z "$DISCID" ]; then if [ -z "$DISCID" ]; then vecho -n "Getting CD track info... " + # In OSX, unmount the disc before a query + if [ "$OSFLAVOUR" = "OSX" ]; then + disktool -u ${CDROM#/dev/} + fi TRACKINFO=$($CDDISCID $CDROM) # Make sure there's a CD in there by checking cd-discid's return code if [ "$?" = "1" ]; then echo "abcde error: CD could not be read. Perhaps there's no CD in the drive?" >&2 exit 1 fi + # In OSX, remount the disc again + if [ "$OSFLAVOUR" = "OSX" ]; then + disktool -m ${CDROM#/dev/} + fi WEHAVEACD=y else TRACKINFO=$(cat "$WAVOUTPUTDIR/abcde.$DISCID/discid") @@ -1055,11 +1142,11 @@ do_discid () if [ ! "$RET" = "0" ];then echo "Warning: Something went wrong while querying the CD... Maybe a DATA CD?" fi - TRACKS="$( echo "$CDPARANOIAOUTPUT" | egrep '^[[:space:]]+[[:digit:]]' | tail -n 1 | awk '{print $1}' | tr -d "." | tr '\n' ' ' )" + TRACKS="$( echo "$CDPARANOIAOUTPUT" | egrep '^[[:space:]]+[[:digit:]]' | tail -n 1 | get_first | tr -d "." | tr '\n' ' ' )" CDPARANOIAAUDIOTRACKS="$TRACKS" else if [ -f "$ABCDETEMPDIR/status" ] && checkstatus cdparanoia-audio-tracks ; then - TRACKS=$( cat $ABCDETEMPDIR/cdparanoia-audio-tracks ) + TRACKS=$( cat "$ABCDETEMPDIR/cdparanoia-audio-tracks" ) else TRACKS=$(echo $TRACKINFO | cut -f2 -d' ') fi @@ -1070,7 +1157,7 @@ do_discid () else TRACKS=$(echo $TRACKINFO | cut -f2 -d' ') fi - if echo "$TRACKS" | grep [[:digit:]] > /dev/null 2>&1 ;then :;else + if echo "$TRACKS" | grep "[[:digit:]]" > /dev/null 2>&1 ;then :;else echo "The disc does not contain any tracks. Giving up..." exit 0 fi @@ -1105,8 +1192,6 @@ do_discid () echo Grabbing tracks: "$TRACKQUEUE" fi -# for LASTTRACK in $TRACKQUEUE; do :; done - QUEUEDTRACKS=$(echo $TRACKQUEUE | wc -w | tr -d ' ') # We have the discid, create a temp directory after it to store all the temp @@ -1178,10 +1263,12 @@ do_discid () fi cat /dev/null > "$ABCDETEMPDIR/status" fi - if [ X"$CUEFILE" = "Xy" -a X"$WEHAVEACD" = "Xy" ]; then - if checkstatus cuefile ; then :; else - $MKCUE $MKCUEOPTS > $ABCDETEMPDIR/cue-$(echo $TRACKINFO | cut -f1 -d' ').txt - echo cuefile >> "$ABCDETEMPDIR/status" + if [ X"$MAKECUEFILE" = "Xy" -a X"$WEHAVEACD" = "Xy" ]; then + if checkstatus cuefile > /dev/null 2>&1 ; then :; else + CUEFILE=cue-$(echo "$TRACKINFO" | cut -f1 -d' ').txt + vecho "Creating cue file..." + $MKCUE $MKCUEOPTS > "$ABCDETEMPDIR/$CUEFILE" + echo cuefile=$CUEFILE >> "$ABCDETEMPDIR/status" fi fi # If we got the CDPARANOIA status and it is not recorded, save it now @@ -1197,6 +1284,37 @@ do_discid () echo "$TRACKINFO" > "$ABCDETEMPDIR/discid" } +# do_cleancue +# Create a proper CUE file based on the CUE file we created before. +do_cleancue() +{ + # FIXME # we can get the name of the cuefile from the status file + if CUEFILE_IN="$ABCDETEMPDIR"/$(checkstatus cuefile); then + CUEFILE_OUT=$CUEFILE_IN.out + ### FIXME ### checkstatus cddb + if [ -e "$CDDBDATA" ]; then + vecho "Adding metadata to the cue file..." + # FIXME It doesn't preserve spaces! Why? + # FIXME parse $track into PERFORMER and TITLE - abcde already has code for this? + n=1 + echo "PERFORMER \"$DARTIST\"" >> "$CUEFILE_OUT" + echo "TITLE \"$DALBUM\"" >> "$CUEFILE_OUT" + cat "$CUEFILE_IN" | while read line + do + if echo "$line" | grep -q "INDEX" + then + eval track="\$TRACK$n" + n=$(expr $n + 1) + echo "TITLE \"$track\"" >> "$CUEFILE_OUT" + fi + echo "$line" >> "$CUEFILE_OUT" + done + mv "$CUEFILE_OUT" "$CUEFILE_IN" + echo "cleancuefile" >> "$ABCDETEMPDIR/status" + fi + fi +} + # do_cddbparse # Parses a CDDB file and outputs the title and the track names. # Variables: CDDBFILE @@ -1243,7 +1361,7 @@ do_localcddb () echo "y" >&2 fi if [ "$USELOCALRESP" = "y" ]; then - #echo "Using local copy of CDDB data" + #echo "Using local copy of CDDB data" cp "${CDDBLOCALFILE}" "$ABCDETEMPDIR/cddbread.1" echo 999 > "$ABCDETEMPDIR/cddbquery" # Assuming 999 isn't used by CDDB echo cddb-readcomplete >> "$ABCDETEMPDIR/status" @@ -1254,7 +1372,6 @@ do_localcddb () #echo "Not using local copy of CDDB data" CDDBLOCALSUCCESS="n" fi - CDDBLOCALSUCCESS="y" else CDDBLOCALSUCCESS="n" fi @@ -1390,7 +1507,7 @@ do_cddbread () # Multiple exact, (possibly multiple) inexact matches IN= if [ "$RESPONSECODE" = "211" ]; then IN=in; fi - if [ "$(wc -l < $ABCDETEMPDIR/cddbquery | tr -d ' ')" -eq 3 ]; then + if [ "$(wc -l < "$ABCDETEMPDIR/cddbquery" | tr -d ' ')" -eq 3 ]; then echo "One ${IN}exact match:" >> "$ABCDETEMPDIR/cddbchoices" tail -n +2 "$ABCDETEMPDIR/cddbquery" | head -n 1 >> "$ABCDETEMPDIR/cddbchoices" echo cddb-choice=1 >> "$ABCDETEMPDIR/status" @@ -1500,9 +1617,9 @@ do_cddbedit () if [ "$CDCHOICENUM" = "0" ]; then vecho "Creating empty CDDB template..." UNKNOWNDISK=y - $CDDBTOOL template $(cat "$ABCDETEMPDIR/discid") > $ABCDETEMPDIR/cddbread.0 + $CDDBTOOL template $(cat "$ABCDETEMPDIR/discid") > "$ABCDETEMPDIR/cddbread.0" else - echo "Selected: #$CDCHOICENUM ($(grep ^DTITLE= $ABCDETEMPDIR/cddbread.$CDCHOICENUM | cut -f2- -d= | tr -d \\r\\n))" >&2 + echo "Selected: #$CDCHOICENUM ($(grep ^DTITLE= "$ABCDETEMPDIR/cddbread.$CDCHOICENUM" | cut -f2- -d= | tr -d \\r\\n))" >&2 do_cddbparse "$ABCDETEMPDIR/cddbread.$CDCHOICENUM" fi echo "cddb-choice=$CDCHOICENUM" >> "$ABCDETEMPDIR/status" @@ -1551,7 +1668,7 @@ do_cddbedit () CDCHOICENUM=1 echo "cddb-choice=$CDCHOICENUM" >> "$ABCDETEMPDIR/status" fi - echo "Selected: #$CDCHOICENUM ($(grep ^DTITLE= $ABCDETEMPDIR/cddbread.$CDCHOICENUM | cut -f2- -d= | tr -d \\r\\n))" >&2 + echo "Selected: #$CDCHOICENUM ($(grep ^DTITLE= "$ABCDETEMPDIR/cddbread.$CDCHOICENUM" | cut -f2- -d= | tr -d \\r\\n))" >&2 fi fi @@ -1586,13 +1703,17 @@ do_cddbedit () if [ -x $(which "${EDITOR%%\ *}") ]; then # That failed, try to load the preferred editor, starting # with their EDITOR variable - eval $(echo "$EDITOR") "$CDDBDATA" + eval $(echo "$EDITOR") \"$CDDBDATA\" fi # If that fails, check for a vi elif which vi >/dev/null 2>&1; then vi "$CDDBDATA" + elif [ -x /usr/bin/vim ]; then + /usr/bin/vim "$CDDBDATA" elif [ -x /usr/bin/vi ]; then /usr/bin/vi "$CDDBDATA" + elif [ -x /bin/vi ]; then + /bin/vi "$CDDBDATA" # nano should be on all (modern, i.e., sarge) debian systems elif which nano >/dev/null 2>&1 ; then nano "$CDDBDATA" @@ -1750,9 +1871,10 @@ do_cdread () # We need the first and last track for cdda2wav FIRSTTRACK=$2 LASTTRACK=$3 + UTRACKNUM=$FIRSTTRACK case "$CDROMREADERSYNTAX" in - cdparanoia) UTRACKNUM="1-" ;; - cdda2wav) UTRACKNUM="1+$LASTRACK" ;; + cdparanoia) READTRACKNUMS="$FIRSTTRACK-$LASTTRACK" ;; + cdda2wav) READTRACKNUMS="$FIRSTTRACK+$LASTRACK" ;; *) echo "abcde error: $CDROMREADERSYNTAX does not support ONETRACK mode" exit 1 ;; esac @@ -1762,7 +1884,7 @@ do_cdread () CDDBTRACKNUM=$(expr $UTRACKNUM - 1) if [ "$USEPIPES" = "y" ]; then TEMPARG="PIPE_$CDROMREADERSYNTAX" - FILEARG=${!TEMPARG} + FILEARG="${!TEMPARG}" REDIR="" PIPE_MESSAGE="and encoding " else @@ -1773,19 +1895,24 @@ do_cdread () FILEARG="-f $WAVDATA" ;; *) - FILEARG=$WAVDATA + FILEARG="$WAVDATA" ;; esac REDIR=">&2" fi - if [ -r "$CDDBDATA" ]; then - TRACKNAME=$(grep ^TTITLE$CDDBTRACKNUM= "$CDDBDATA" | head -n 1 | cut -f2 -d= | tr -d \[:cntrl:\]) - echo "Grabbing ${PIPE_MESSAGE}track $UTRACKNUM: $TRACKNAME..." >&2 + if [ "$1" = "onetrack" ]; then + echo "Grabbing ${PIPE_MESSAGE}tracks $UTRACKNUM - $LASTTRACK as one track ..." >&2 else - echo "Grabbing ${PIPE_MESSAGE}track $UTRACKNUM..." >&2 + if [ -r "$CDDBDATA" ]; then + TRACKNAME=$(grep ^TTITLE$CDDBTRACKNUM= "$CDDBDATA" | head -n 1 | cut -f2 -d= | tr -d \[:cntrl:\]) + echo "Grabbing ${PIPE_MESSAGE}track $UTRACKNUM: $TRACKNAME..." >&2 + else + echo "Grabbing ${PIPE_MESSAGE}track $UTRACKNUM..." >&2 + fi fi case "$CDROMREADERSYNTAX" in - cdparanoia) nice $READNICE $CDROMREADER -d $CDROM $UTRACKNUM $FILEARG $REDIR ;; + cdparanoia) + nice $READNICE $CDROMREADER -d $CDROM ${READTRACKNUMS:-$UTRACKNUM} "$FILEARG" $REDIR ;; cdda2wav) if [ "$OSFLAVOUR" = "OSX" ] ; then # Hei, we have to unmount the device before running anything like cdda2wav in OSX @@ -1801,11 +1928,11 @@ do_cdread () CDDA2WAVCDROM="$CDROMID" fi fi - nice $READNICE $CDROMREADER -D $CDDA2WAVCDROM -t $UTRACKNUM $FILEARG $REDIR + nice $READNICE $CDROMREADER -D $CDDA2WAVCDROM -t ${READTRACKNUMS:-$UTRACKNUM} "$FILEARG" $REDIR ;; ## FIXME ## We have an exception for dagrab, since it uses -f ## FIXME ## Shall we just use -f $FILEARG ?? - dagrab) nice $READNICE $CDROMREADER -d $CDROM -v $UTRACKNUM $FILEARG $REDIR + dagrab) nice $READNICE $CDROMREADER -d $CDROM -v $UTRACKNUM "$FILEARG" $REDIR ;; cddafs) # Find the track's mounted path @@ -1814,11 +1941,11 @@ do_cdread () FILEPATH=$(find "$FILEPATH" | grep "/$REALTRACKNUM "); # If the file exists, copy it if [ -e "$FILEPATH" ] ; then - nice $READNICE $CDROMREADER "$FILEPATH" $FILEARG $REDIR + nice $READNICE $CDROMREADER "$FILEPATH" "$FILEARG" $REDIR else false fi ;; - debug) nice $READNICE $CDROMREADER -d $CDROM -w $UTRACKNUM-[:1] $FILEARG $REDIR + debug) nice $READNICE $CDROMREADER -d $CDROM -w $UTRACKNUM-[:1] "$FILEARG" $REDIR ;; esac RETURN=$? @@ -1841,6 +1968,9 @@ do_cdread () echo readencodetrack-$UTRACKNUM >> "$ABCDETEMPDIR/status" else echo readtrack-$UTRACKNUM >> "$ABCDETEMPDIR/status" + if [ "$1" = "onetrack" ]; then + echo onetrack >> "$ABCDETEMPDIR/status" + fi fi fi } @@ -1887,6 +2017,13 @@ pre_read () : } +# post_read +# Empty post_read function, to be defined in the configuration file. +post_read () +{ +: +} + ############################################################################### # End of functions # @@ -1900,7 +2037,6 @@ CDDBPROTO=5 HELLOINFO="$(whoami)@$(hostname)" INTERACTIVE=y CDROMREADERSYNTAX=cdparanoia -OUTPUTTYPE=ogg ENCODERSYNTAX=default MP3ENCODERSYNTAX=default @@ -1986,7 +2122,7 @@ MP3ENCOPTS= VORBIZEOPTS= OGGENCOPTS= # flac -FLACOPTS= +FLACOPTS="-f" # speex SPEEXENCOPTS= # mpc @@ -2005,6 +2141,8 @@ NORMALIZEOPTS= CDSPEEDOPTS="-x" CDSPEEDVALUE= MKCUEOPTS= +VORBISCOMMENTOPTS="-R" +METAFLACOPTS="--no-utf8-convert" # Default to one process if -j isn't specified MAXPROCS=1 @@ -2012,6 +2150,10 @@ MAXPROCS=1 # List of actions to perform - by default, run to completion ACTIONS=cddb,read,encode,tag,move,clean +# List of prefered outputs - by default, run with whatever we have in the path +# This option is basicaly for Debian package dependencies +DEFAULT_OUTPUT_BINARIES=vorbis:oggenc,flac:flac,mp3:lame,mp3:bladeenc,spx:speex + # Asume fetch if under FreeBSD. curl is used for Mac OS X. wget is used for Linux/OpenBSD/NetBSD. # Let's use these checkings to determine the OS flavour, which will be used later if [ X$(uname) = "XFreeBSD" ] ; then @@ -2023,6 +2165,7 @@ elif [ X$(uname) = "XDarwin" ] ; then OSFLAVOUR=OSX # We should have disktool in OSX, but let's be sure... NEEDDISKTOOL=y + CDROMREADERSYNTAX=cddafs elif [ X$(uname) = "XOpenBSD" ] ; then HTTPGET=wget MD5SUM=md5 @@ -2084,7 +2227,7 @@ fi # Parse command line options #while getopts 1a:bc:C:d:Dhj:klLnNo:pr:S:t:T:vVx opt ; do -while getopts 1a:A:bc:C:d:Dhj:klLmMnNo:pPr:Rs:S:t:T:vVxw:W: opt ; do +while getopts 1a:A:bc:C:d:Dehj:klLmMnNo:pPr:Rs:S:t:T:vVxw:W: opt ; do case "$opt" in 1) ONETRACK=y ;; a) ACTIONS="$OPTARG" ;; @@ -2094,7 +2237,9 @@ while getopts 1a:A:bc:C:d:Dhj:klLmMnNo:pPr:Rs:S:t:T:vVxw:W: opt ; do C) DISCID="${OPTARG#abcde.}" ;; d) CDROM="$OPTARG" ;; D) set -x ;; + e) ERASEENCODEDSTATUS=y ;; h) usage; exit ;; + e) ERASEENCODEDSTATUS=y ;; # f) FORCECDDBUSELOCAL=y ;; i) INLINETAG=y ;; j) MAXPROCS="$OPTARG" ;; @@ -2104,7 +2249,7 @@ while getopts 1a:A:bc:C:d:Dhj:klLmMnNo:pPr:Rs:S:t:T:vVxw:W: opt ; do n) CDDBAVAIL=n ;; N) INTERACTIVE=n ;; m) DOSPLAYLIST=y ;; - M) CUEFILE=y ;; + M) MAKECUEFILE=y ;; o) OUTPUTTYPE="$OPTARG" ;; p) PADTRACKS=y ;; P) USEPIPES=y ;; @@ -2126,7 +2271,13 @@ while getopts 1a:A:bc:C:d:Dhj:klLmMnNo:pPr:Rs:S:t:T:vVxw:W: opt ; do V) EXTRAVERBOSE="y" ;; x) EJECTCD="y" ;; w) COMMENT="$OPTARG" ;; - W) STARTTRACKNUMBER="${OPTARG}01" ; STARTTRACKNUMBERTAG="y" ; COMMENT="CD${OPTARG}" ;; + W) if echo $OPTARG | grep -q "[[:digit:]]" ; then + STARTTRACKNUMBER="${OPTARG}01" ; STARTTRACKNUMBERTAG="y" ; COMMENT="CD${OPTARG}" + else + echo "abcde error: argument of -W must be integer" + exit 1 + fi + ;; ?) usage; exit ;; esac done @@ -2137,8 +2288,10 @@ shift $(($OPTIND - 1)) if [ "$ONETRACK" = "y" ]; then # FIXME # remove check as soon as we find out about the other readers case "$CDROMREADERSYNTAX" in - dagrab|cddafs|debug) echo "abcde error: ONETRACK reading is not suported with $CDROMREADERSYNTAX yet" - exit 1 ;; + cdparanoia) ;; + cdda2wav) ;; + *) echo "abcde error: $CDROMREADERSYNTAX does not support ONETRACK mode" + exit 1 ;; esac if [ "$BATCH" = "y" ]; then echo "abcde error: BATCH mode is not compatible with ONETRACK mode" @@ -2198,6 +2351,24 @@ done # Sanity checks: +# Check the encoding format, if nothing has been configured in the system, from the ones available in the system +if [ X"$OUTPUTTYPE" = "X" ]; then + for DEFAULT_OUTPUT in $( echo "$DEFAULT_OUTPUT_BINARIES" | tr , \ ); do + DEFAULT_OUTPUT_FORMAT="$(echo $DEFAULT_OUTPUT | cut -d ":" -f 1)" + DEFAULT_OUTPUT_BINARY="$(echo $DEFAULT_OUTPUT | cut -d ":" -f 2)" + if which $DEFAULT_OUTPUT_BINARY > /dev/null 2>&1 ; then + OUTPUTTYPE=$DEFAULT_OUTPUT_FORMAT + vecho "No default output type defined. Autoselecting $OUTPUTTYPE..." >&2 + break + fi + done + if [ X"$OUTPUTTYPE" = "X" ]; then + echo "abcde error: no encoder found in the PATH" >&2 + echo "hits: are all dependencies installed? has the \$PATH been modified?" >&2 + exit 1 + fi +fi + # At this point a CDROM has to be defined, so we check it exists. if [ X"$CDROM" != "X" ] ; then if [ "$CDROMREADERSYNTAX" = "cdda2wav" ] && [ "$NEEDCDROMID" = "y" ] ; then @@ -2225,8 +2396,8 @@ fi # - lowdisk algorithm # - anything else? if [ X"$USEPIPES" = "Xy" ]; then - if [ $(echo $OUTPUTTYPE | tr , \ | wc -w ) -gt 1 ]; then - echo "abcde error: Unix pipes not compatible with multiple outputs" + if [ $(echo "$OUTPUTTYPE" | tr , \ | wc -w ) -gt 1 ]; then + echo "abcde error: Unix pipes not compatible with multiple outputs" >&2 exit 1 fi if [ X"$DONORMALIZE" = "Xy" ]; then @@ -2273,26 +2444,21 @@ case "$NORMALIZERSYNTAX" in esac # Allow -o OUTPUT(1):OPTIONS(1),...,OUTPUT(N):OPTIONS(N) mode of operation -if echo $OUTPUTTYPE | grep ":" > /dev/null 2>&1 ; then - OLDFS="$FS" - export FS="," - for OUTPUT in "$OUTPUTTYPE" - do +if echo "$OUTPUTTYPE" | grep ":" > /dev/null 2>&1 ; then + for OUTPUT in $(echo $OUTPUTTYPE | tr , \ ); do case "$OUTPUT" in - ogg:*) OGGENCODEROPTSCLI="$( echo $OUTPUT | cut -d: -f2- )" ;; + vorbis:*|ogg:*) OGGENCODEROPTSCLI="$( echo $OUTPUT | cut -d: -f2- )" ;; mp3:*) MP3ENCODEROPTSCLI="$( echo $OUTPUT | cut -d: -f2- )" ;; flac:*) FLACENCODEROPTSCLI="$( echo $OUTPUT | cut -d: -f2- )" ;; spx:*) SPEEXENCODEROPTSCLI="$( echo $OUTPUT | cut -d: -f2- )" ;; mpc:*) MPPENCODEROPTSCLI="$( echo $OUTPUT | cut -d: -f2- )" ;; esac done - for OUTPUT in "$OUTPUTTYPE" - do + for OUTPUT in $(echo $OUTPUTTYPE | tr , \ ); do TEMPOUTPUT=$( echo "$OUTPUT" | cut -d: -f1 ) TEMPOUTPUTTYPE="${TEMPOUTPUTTYPE:+$TEMPOUTPUTTYPE,}$TEMPOUTPUT" done OUTPUTTYPE="$TEMPOUTPUTTYPE" - FS="$OLDFS" fi # If nothing has been specified, use oggenc for oggs and lame for mp3s and flac for flacs and speexenc for speex and mppenc for mpps @@ -2301,18 +2467,26 @@ fi for OUTPUT in $(echo $OUTPUTTYPE | tr , \ ) do case $OUTPUT in - ogg) [ "$OGGENCODERSYNTAX" = "default" ] && OGGENCODERSYNTAX=oggenc - [ "$DOTAG" = "y" ] && NEEDCOMMENTER=y - [ "$REPLAYGAIN" = "y" ] && NEEDVORBISGAIN=y - ;; - mp3) [ "$MP3ENCODERSYNTAX" = "default" ] && MP3ENCODERSYNTAX=lame - [ "$DOTAG" = "y" ] && NEEDTAGGER=y - ;; - flac) [ "$FLACENCODERSYNTAX" = "default" ] && FLACENCODERSYNTAX=flac - [ "$DOTAG" = "y" ] && NEEDMETAFLAC=y - ;; - spx) [ "$SPEEXENCODERSYNTAX" = "default" ] && SPEEXENCODERSYNTAX=speexenc ;; - mpc) [ "$MPPENCODERSYNTAX" = "default" ] && MPPENCODERSYNTAX=mppenc ;; + vorbis|ogg) + [ "$OGGENCODERSYNTAX" = "default" ] && OGGENCODERSYNTAX=oggenc + [ "$DOTAG" = "y" ] && NEEDCOMMENTER=y + [ "$REPLAYGAIN" = "y" ] && NEEDVORBISGAIN=y + OGGOUTPUTCONTAINER=ogg + ;; + mp3) + [ "$MP3ENCODERSYNTAX" = "default" ] && MP3ENCODERSYNTAX=lame + [ "$DOTAG" = "y" ] && NEEDTAGGER=y + ;; + flac) + [ "$FLACENCODERSYNTAX" = "default" ] && FLACENCODERSYNTAX=flac + [ "$DOTAG" = "y" ] && NEEDMETAFLAC=y + ;; + spx) + [ "$SPEEXENCODERSYNTAX" = "default" ] && SPEEXENCODERSYNTAX=speexenc + ;; + mpc) + [ "$MPPENCODERSYNTAX" = "default" ] && MPPENCODERSYNTAX=mppenc + ;; *) echo "abcde error: Invalid OUTPUTTYPE defined" >&2 exit 1 ;; @@ -2360,9 +2534,14 @@ case "$FLACENCODERSYNTAX" in flac) FLACENCODEROPTS="${FLACENCODEROPTSCLI:-$FLACOPTS}" FLACENCODER="$FLAC" - ## FIXME ## FLAC streams can be encapsulated on a Ogg transport layer + # FLAC streams can be encapsulated on a Ogg transport layer if echo "$FLACENCODEROPTS" | egrep -q -- "(^| )--ogg($| )" ;then - FLACONOGG=y + echo "abcde error: FLAC on an Ogg container is not yet supported" >&2 + echo " due to problem with adding comments to such files" >&2 + exit 1 + FLACOUTPUTCONTAINER=ogg + else + FLACOUTPUTCONTAINER=flac fi ;; esac @@ -2389,6 +2568,16 @@ else TAGGEROPTS="$ID3V2OPTS" fi +# Check if both OGGEOUTPUTCONTAINER and FLACOUTPUTCONTAINER are the same, and differentiante them +if [ X"$OGGOUTPUTCONTAINER" = "Xogg" ] && [ X"$FLACOUTPUTCONTAINER" = "Xogg" ]; then + echo "abcde error: FLAC on an Ogg container is not yet supported" >&2 + echo " due to problem with adding comments to such files" >&2 + exit 1 + OGGOUTPUTCONTAINER=ogg.ogg + FLACOUTPUTCONTAINER=flac.ogg + vecho "abcde warning: modified file endings due to conflicting transport layers in Ogg/Vorbis and Ogg/FLAC" +fi + # Clean up nice options (either use '-n NICELEVEL or -NICELEVEL') if [ "$ENCNICE" ]; then @@ -2402,11 +2591,21 @@ if [ "$DISTMP3NICE" ]; then fi # Don't check for stuff if it's not needed -if [ "$REMOTEHOSTS" ]; then NEEDDISTMP3=y; fi -[ "$DONORMALIZE" = "y" ] && NEEDNORMALIZER=y -[ "$EJECTCD" = "y" ] && NEEDEJECT=y -[ ! "$CDDBAVAIL" = "n" ] && [ "$DOCDDB" = "y" ] && NEEDHTTPGET=y -[ "$CUEFILE" = "y" ] && NEEDMKCUE=y +if [ "$REMOTEHOSTS" ]; then + NEEDDISTMP3=y +fi +if [ "$DONORMALIZE" = "y" ]; then + NEEDNORMALIZER=y +fi +if [ "$EJECTCD" = "y" ]; then + NEEDEJECT=y +fi +if [ ! "$CDDBAVAIL" = "n" ] && [ "$DOCDDB" = "y" ]; then + NEEDHTTPGET=y +fi +if [ "$CUEFILE" = "y" ]; then + NEEDMKCUE=y +fi if [ X"$CDSPEEDVALUE" != "X" ]; then case "$CDROMREADERSYNTAX" in @@ -2432,10 +2631,10 @@ if [ "$USEPIPES" = "y" ]; then case "$OUTPUT" in mp3) PIPEENCODERSVARCHECK="PIPE_$MP3ENCODERSYNTAX" ;; - ogg) + vorbis|ogg) PIPEENCODERSVARCHECK="PIPE_$OGGENCODERSYNTAX" ;; flac) - PIPEENCODERSVARCHECK="PIPE_$FLACENCODERSYTNAX" ;; + PIPEENCODERSVARCHECK="PIPE_$FLACENCODERSYNTAX" ;; spx) PIPEENCODERSVARCHECK="PIPE_$SPEEXENCODER" ;; mpc) @@ -2455,7 +2654,6 @@ if [ "$USEPIPES" = "y" ]; then fi fi - # Make sure a buncha things exist for X in $CDROMREADER $CDDISCID ${NEEDTAGGER+$TAGGER} $MP3ENCODER \ $OGGENCODER $FLACENCODER $SPEEXENCODER $MPPENCODER \ @@ -2526,6 +2724,16 @@ if [ X"$CDSPEEDVALUE" != "X" ]; then esac fi +# Define the first and last track, since we might need them later in several places +FIRSTTRACK=$( get_first $TRACKQUEUE ) +LASTTRACK=$( get_last $TRACKQUEUE ) + +if [ -f "$ABCDETEMPDIR/status" ] && [ X"$ERASEENCODEDSTATUS" = "Xy" ]; then + mv "$ABCDETEMPDIR/status" "$ABCDETEMPDIR/status.old" + grep -v ^encodetracklocation- < "$ABCDETEMPDIR/status.old" \ + | grep -v ^encode-output > "$ABCDETEMPDIR/status" +fi + # Create playlist if needed (backgroundable) and start reading in tracks ( @@ -2544,11 +2752,9 @@ if [ "$LOWDISK" = "y" ] || [ "$ONETRACK" = "y" ]; then fi if [ "$ONETRACK" = "y" ]; then - FIRSTTRACK=$( echo $TRACKQUEUE | awk '{print $1}' ) TRACKS="$FIRSTTRACK" - for UTRACKNUM in $TRACKQUEUE; do :;done if checkstatus readtrack-$FIRSTTRACK; then :; else - do_cdread onetrack $FIRSTTRACK $UTRACKNUM + do_cdread onetrack $FIRSTTRACK $LASTTRACK fi else for UTRACKNUM in $TRACKQUEUE @@ -2601,6 +2807,9 @@ if [ "$BATCH" = "y" ] || [ "$ONETRACK" = "y" ]; then echo NEXTTRACK fi +# Execute the user-defined post_read funtion before ejecting CD +post_read + # We are now finished with the cdrom - it can be safely ejected. Note that # abcde will not have completed yet. if [ "$EJECTCD" = "y" ] && [ -x $(which $EJECT) ]; then @@ -2670,8 +2879,7 @@ fi # If we are using ONETRACK, we can proceed with the normal encoding using just the $FIRSTTRACK as TRACKQUEUE if [ "$ONETRACK" = "y" ] ; then - FIRSTTRACK=$( echo $TRACKQUEUE | awk '{print $1}') - TRACKQUEUE=$FIRSTTRACK + TRACKQUEUE="$FIRSTTRACK" TRACKS="$FIRSTTRACK" fi @@ -2770,6 +2978,12 @@ do if checkstatus encodetrack-$UTRACKNUM; then if checkstatus tagtrack-$UTRACKNUM; then :; else do_tag $UTRACKNUM; fi fi + # Lets tag the cue file + if checkstatus cleancuefile >/dev/null; then :; else + if checkstatus cuefile >/dev/null ; then + do_cleancue + fi + fi fi if [ "$DOMOVE" = "y" ]; then if checkstatus tagtrack-$UTRACKNUM; then @@ -2778,6 +2992,8 @@ do fi ) & done + + # Go through it again and make sure there's no distmp3 stragglers, otherwise # we'll delete the files they're working on ## FIXME ## Check also for files which are encoded using PIPEs.