f_seq_line ()
{
i=$1
- while [ $i -ne `expr $2 + 1` ]
- do
- printf $i" "
- i=`expr $i + 1`
- done
- echo
+ if echo i | grep -q "[[:digit:]]" ; then
+ while [ $i -ne `expr $2 + 1` ]
+ do
+ printf $i" "
+ i=`expr $i + 1`
+ done
+ echo
+ else
+ echo "abcde: syntax error while processing track numbers" >&2
+ exit 1
+ fi
}
# Functions to replace the need of awk {print $1} and {print $NF}
do_replaygain()
{
- run_command "" echo "Adding reply-gain information..."
- for OUTPUT in $( echo $OUTPUTTYPE | tr , \ )
- do
- OUTPUTFILES=""
- for UTRACKNUM in $TRACKQUEUE
+ if checkstatus replaygain; then :; else
+ run_command "" echo "Adding reply-gain information..."
+ for OUTPUT in $( echo $OUTPUTTYPE | tr , \ )
+ # THE OUTPUT NEEDS TO BE CORRECTED WITH THE CONTAINER?
do
- CDDBTRACKNUM=$(expr $UTRACKNUM - 1)
- do_getcddbinfo TRACKNAME
- splitvarious
- TRACKFILE=$(mungefilename "$TRACKNAME")
- ARTISTFILE=$(mungefilename "$TRACKARTIST")
- ALBUMFILE=$(mungefilename "$DALBUM")
- do_gettrucknum
- if [ "$VARIOUSARTISTS" = "y" ]; then
- OUTPUTFILE=$(eval echo $VAOUTPUTFORMAT)
- else
- OUTPUTFILE=$(eval echo $OUTPUTFORMAT)
- fi
- OUTPUTFILES="$OUTPUTDIR/$OUTPUTFILE.$OUTPUT $OUTPUTFILES"
+ case $OUTPUT in
+ vorbis|ogg)
+ OUTPUT=$OGGOUTPUTCONTAINER
+ ;;
+ flac)
+ OUTPUT=$FLACOUTPUTCONTAINER
+ ;;
+ esac
+ OUTPUTFILES=""
+ for UTRACKNUM in $TRACKQUEUE
+ do
+ CDDBTRACKNUM=$(expr $UTRACKNUM - 1)
+ do_getcddbinfo TRACKNAME
+ splitvarious
+ TRACKFILE="$(mungefilename "$TRACKNAME")"
+ ARTISTFILE="$(mungefilename "$TRACKARTIST")"
+ ALBUMFILE="$(mungefilename "$DALBUM")"
+ do_gettracknum
+ if [ "$VARIOUSARTISTS" = "y" ]; then
+ OUTPUTFILE=$(eval echo $VAOUTPUTFORMAT)
+ else
+ OUTPUTFILE=$(eval echo $OUTPUTFORMAT)
+ fi
+ OUTPUTFILES="$OUTPUTDIR/$OUTPUTFILE.$OUTPUT $OUTPUTFILES"
+ done
+ case "$OUTPUT" in
+ flac)
+ run_command replaygain-flac $METAFLAC --add-replay-gain $OUTPUTFILES
+ ;;
+ vorbis|ogg)
+ run_command replaygain-vorbis $VORBISGAIN --album $OUTPUTFILES
+ ;;
+ *);;
+ esac
done
- case "$OUTPUT" in
- flac);;
- ogg);;
- *);;
- esac
- echo vorbisgain-$OUTPUT >> "$ABCDETEMPDIR/status"
- done
- echo vorbisgain >> "$ABCDETEMPDIR/status"
+ if checkerrors replaygain-.{3,6}; then
+ run_command replaygain false
+ else
+ run_command replaygain true
+ fi
+ fi
}
# This code splits the a Various Artist track name from one of the following
if [ "$VARIOUSARTISTS" = "y" ] && [ ! "$ONETRACK" = "y" ]; then
case "$VARIOUSARTISTSTYLE" in
forward)
- DTITLEARTIST=$(echo "$TRACKNAME" | sed 's- / -~-g')
- TRACKARTIST=$(echo "$DTITLEARTIST" | cut -f1 -d~)
- TRACKNAME=$(echo "$DTITLEARTIST" | cut -f2 -d~)
+ DTITLEARTIST="$(echo "$TRACKNAME" | sed 's- / -~-g')"
+ TRACKARTIST="$(echo "$DTITLEARTIST" | cut -f1 -d~)"
+ TRACKNAME="$(echo "$DTITLEARTIST" | cut -f2 -d~)"
;;
forward-dash)
- DTITLEARTIST=$(echo "$TRACKNAME" | sed 's, - ,~,g')
- TRACKARTIST=$(echo "$DTITLEARTIST" | cut -f1 -d~)
- TRACKNAME=$(echo "$DTITLEARTIST" | cut -f2 -d~)
+ DTITLEARTIST="$(echo "$TRACKNAME" | sed 's, - ,~,g')"
+ TRACKARTIST="$(echo "$DTITLEARTIST" | cut -f1 -d~)"
+ TRACKNAME="$(echo "$DTITLEARTIST" | cut -f2 -d~)"
;;
reverse)
- DTITLEARTIST=$(echo "$TRACKNAME" | sed 's- / -~-g')
- TRACKARTIST=$(echo "$DTITLEARTIST" | cut -f2 -d~)
- TRACKNAME=$(echo "$DTITLEARTIST" | cut -f1 -d~)
+ DTITLEARTIST="$(echo "$TRACKNAME" | sed 's- / -~-g')"
+ TRACKARTIST="$(echo "$DTITLEARTIST" | cut -f2 -d~)"
+ TRACKNAME="$(echo "$DTITLEARTIST" | cut -f1 -d~)"
;;
reverse-dash)
- DTITLEARTIST=$(echo "$TRACKNAME" | sed 's, - ,~,g')
- TRACKARTIST=$(echo "$DTITLEARTIST" | cut -f2 -d~)
- TRACKNAME=$(echo "$DTITLEARTIST" | cut -f1 -d~)
+ DTITLEARTIST="$(echo "$TRACKNAME" | sed 's, - ,~,g')"
+ TRACKARTIST="$(echo "$DTITLEARTIST" | cut -f2 -d~)"
+ TRACKNAME="$(echo "$DTITLEARTIST" | cut -f1 -d~)"
;;
colon)
- DTITLEARTIST=$(echo "$TRACKNAME" | sed 's-: -~-g')
- TRACKARTIST=$(echo "$DTITLEARTIST" | cut -f1 -d~)
- TRACKNAME=$(echo "$DTITLEARTIST" | cut -f2 -d~)
+ DTITLEARTIST="$(echo "$TRACKNAME" | sed 's-: -~-g')"
+ TRACKARTIST="$(echo "$DTITLEARTIST" | cut -f1 -d~)"
+ TRACKNAME="$(echo "$DTITLEARTIST" | cut -f2 -d~)"
;;
trailing-paren)
- DTITLEARTIST=$(echo "$TRACKNAME" | sed 's,^\(.*\) (\(.*\)),\1~\2,')
- TRACKARTIST=$(echo "$DTITLEARTIST" | cut -f2 -d~)
- TRACKNAME=$(echo "$DTITLEARTIST" | cut -f1 -d~)
+ DTITLEARTIST="$(echo "$TRACKNAME" | sed 's,^\(.*\) (\(.*\)),\1~\2,')"
+ TRACKARTIST="$(echo "$DTITLEARTIST" | cut -f2 -d~)"
+ TRACKNAME="$(echo "$DTITLEARTIST" | cut -f1 -d~)"
;;
esac
elif [ "$VARIOUSARTISTS" = "y" ] && [ "$ONETRACK" = "y" ]; then
;;
esac
done
- if checkerrors "tagtrack-(.{3,4})-$1"; then
+ if checkerrors "tagtrack-(.{3,6})-$1"; then
run_command tagtrack-$1 false
else
run_command tagtrack-$1 true
esac
done
# Only remove .wav if the encoding succeeded
- if checkerrors "encodetrack-(.{3,4})-$1"; then
+ if checkerrors "encodetrack-(.{3,6})-$1"; then
run_command encodetrack-$1 false
else
run_command encodetrack-$1 true
# ''' -> ''
# '?' -> ''
# Eat control characters
- ALBUMFILE=$(mungefilename "$DALBUM")
- ARTISTFILE=$(mungefilename "$TRACKARTIST")
- TRACKFILE=$(mungefilename "$TRACKNAME")
- GENRE=$(mungegenre "$GENRE")
- YEAR=$(echo $CDYEAR)
+ ALBUMFILE="$(mungefilename "$DALBUM")"
+ ARTISTFILE="$(mungefilename "$TRACKARTIST")"
+ TRACKFILE="$(mungefilename "$TRACKNAME")"
+ GENRE="$(mungegenre "$GENRE")"
+ YEAR="$(echo $CDYEAR)"
# If we want to start the tracks with a given number, we need to modify the
# TRACKNUM value before evaluation
# if [ -n "$STARTTRACKNUMBER" ] ; then
# Supported variables for OUTPUTFORMAT are GENRE, ALBUMFILE, ARTISTFILE,
# TRACKFILE, and TRACKNUM.
if [ "$VARIOUSARTISTS" = "y" ]; then
- OUTPUTFILE=$(eval echo $VAOUTPUTFORMAT)
- else
- OUTPUTFILE=$(eval echo $OUTPUTFORMAT)
+ OUTPUTFILE="$(eval echo "$VAOUTPUTFORMAT")"
+ else
+ OUTPUTFILE="$(eval echo "$OUTPUTFORMAT")"
fi
if checkerrors "tagtrack-$OUTPUT-$1"; then :; else
# Once we know the specific output was successful, we can change the OUTPUT to the value containing the container
;;
esac
# Check that the directory for OUTPUTFILE exists, if it doesn't, create it
- OUTPUTFILEDIR=$(dirname "$OUTPUTDIR/$OUTPUTFILE")
+ OUTPUTFILEDIR="$(dirname "$OUTPUTDIR/$OUTPUTFILE")"
# mkdir -p shouldn't return an error if the directory already exists
mkdir -p "$OUTPUTFILEDIR"
run_command movetrack-$1 mv "$ABCDETEMPDIR/track$1.$OUTPUT" "$OUTPUTDIR/$OUTPUTFILE.$OUTPUT"
# Create a playlist file for the playlist data to go into.
# We used to wipe it out if it existed. Now we request permision if interactive.
for LASTTRACK in $TRACKQUEUE; do :; done
- ALBUMFILE=$(mungefilename "$DALBUM")
- ARTISTFILE=$(mungefilename "$DARTIST")
+ ALBUMFILE="$(mungefilename "$DALBUM")"
+ ARTISTFILE="$(mungefilename "$DARTIST")"
GENRE=$(mungegenre "$GENRE")
YEAR=${CDYEAR:-$CDYEAR}
if [ "$VARIOUSARTISTS" = "y" ] ; then
#TRACKNAME=$(grep ^TTITLE$CDDBTRACKNUM= "$CDDBDATA" | cut -f2 -d= | tr -d \[:cntrl:\] | sed 's/\ \+$//')
do_getcddbinfo TRACKNAME
splitvarious
- TRACKFILE=$(mungefilename "$TRACKNAME")
- ARTISTFILE=$(mungefilename "$TRACKARTIST")
- ALBUMFILE=$(mungefilename "$DALBUM")
+ TRACKFILE="$(mungefilename "$TRACKNAME")"
+ ARTISTFILE="$(mungefilename "$TRACKARTIST")"
+ ALBUMFILE="$(mungefilename "$DALBUM")"
# If we want to start the tracks with a given number, we need to modify the
# TRACKNUM value before evaluation
# if [ -n "$STARTTRACKNUMBER" ] ; then
# else
# TRACKNUM=${UTRACKNUM}
# fi
- do_gettrucknum
+ do_gettracknum
if [ "$VARIOUSARTISTS" = "y" ]; then
OUTPUTFILE=$(eval echo $VAOUTPUTFORMAT)
else
DOPOSTPROCESS=n
DOTAG=n
DOMOVE=n
+DOREPLAYGAIN=n
DOPLAYLIST=n
DOCLEAN=n
# postprocess) DOPREPROCESS=y; DOENCODE=y; DOREAD=y;;
tag) DOTAG=y; DOREAD=y; DOENCODE=y; DOCDDB=y;;
move) DOMOVE=y; DOTAG=y; DOREAD=y; DOENCODE=y; DOCDDB=y;;
+ replaygain) DOCDDB=y; DOREAD=y; DOENCODE=y; DOTAG=y; DOMOVE=y; DOREPLAYGAIN=y;;
playlist) DOCDDB=y; DOPLAYLIST=y;;
clean) DOCLEAN=y;;
esac
done
+if [ "$DONORMALIZE" = "y" ] && [ "$DOREPLAYGAIN" = "y" ]; then
+ # FIXME # should we abort on error or just inform the user?
+ :
+fi
+
for SHOWCDDBFIELD in $(echo $SHOWCDDBFIELDS | tr , \ ); do
case $SHOWCDDBFIELD in
y*|Y*) SHOWCDDBYEAR="y";;
# Allow -o OUTPUT(1):OPTIONS(1),...,OUTPUT(N):OPTIONS(N) mode of operation
if echo "$OUTPUTTYPE" | grep ":" > /dev/null 2>&1 ; then
- for OUTPUT in $(echo $OUTPUTTYPE | tr , \ ); do
+ for OUTPUT in "$(echo "$OUTPUTTYPE" | tr , \ )"; do
case "$OUTPUT" in
vorbis:*|ogg:*) OGGENCODEROPTSCLI="$( echo $OUTPUT | cut -d: -f2- )" ;;
mp3:*) MP3ENCODEROPTSCLI="$( echo $OUTPUT | cut -d: -f2- )" ;;
mpc:*) MPPENCODEROPTSCLI="$( echo $OUTPUT | cut -d: -f2- )" ;;
esac
done
- for OUTPUT in $(echo $OUTPUTTYPE | tr , \ ); do
+ for OUTPUT in "$(echo "$OUTPUTTYPE" | tr , \ )"; do
TEMPOUTPUT=$( echo "$OUTPUT" | cut -d: -f1 )
TEMPOUTPUTTYPE="${TEMPOUTPUTTYPE:+$TEMPOUTPUTTYPE,}$TEMPOUTPUT"
done
fi
do_cddbedit
- eval $($CDDBTOOL parse "$CDDBDATA")
+ eval "$($CDDBTOOL parse "$CDDBDATA")"
fi
# Before reading tracks, we set the speed of the device
fi
# If the above didn't catch the stragglers, this will
wait
-if checkstatus replaygain; then :; else
+if [ "$DOREPLAYGAIN" = "y" ]; then
do_replaygain
fi
# Check to see if run_command logged any errors