X-Git-Url: https://git.hcoop.net/clinton/Smoothieware.git/blobdiff_plain/ead133628f0da15ef73c1e46c961b8280a912d50..276e7c00a440dab56d3b81428b38a5e072d896bd:/src/modules/robot/Robot.cpp diff --git a/src/modules/robot/Robot.cpp b/src/modules/robot/Robot.cpp index e89f3ff3..d218c1ff 100644 --- a/src/modules/robot/Robot.cpp +++ b/src/modules/robot/Robot.cpp @@ -33,6 +33,7 @@ #include "ExtruderPublicAccess.h" #include "GcodeDispatch.h" #include "ActuatorCoordinates.h" +#include "EndstopsPublicAccess.h" #include "mbed.h" // for us_ticker_read() #include "mri.h" @@ -53,6 +54,7 @@ #define z_axis_max_speed_checksum CHECKSUM("z_axis_max_speed") #define segment_z_moves_checksum CHECKSUM("segment_z_moves") #define save_g92_checksum CHECKSUM("save_g92") +#define save_g54_checksum CHECKSUM("save_g54") #define set_g92_checksum CHECKSUM("set_g92") // arm solutions @@ -76,8 +78,7 @@ #define dir_pin_checksum CHEKCSUM("dir_pin") #define en_pin_checksum CHECKSUM("en_pin") -#define steps_per_mm_checksum CHECKSUM("steps_per_mm") -#define max_rate_checksum CHECKSUM("max_rate") +#define max_speed_checksum CHECKSUM("max_speed") #define acceleration_checksum CHECKSUM("acceleration") #define z_acceleration_checksum CHECKSUM("z_acceleration") @@ -87,7 +88,16 @@ #define laser_module_default_power_checksum CHECKSUM("laser_module_default_power") -#define ARC_ANGULAR_TRAVEL_EPSILON 5E-7F // Float (radians) +#define enable_checksum CHECKSUM("enable") +#define halt_checksum CHECKSUM("halt") +#define soft_endstop_checksum CHECKSUM("soft_endstop") +#define xmin_checksum CHECKSUM("x_min") +#define ymin_checksum CHECKSUM("y_min") +#define zmin_checksum CHECKSUM("z_min") +#define xmax_checksum CHECKSUM("x_max") +#define ymax_checksum CHECKSUM("y_max") +#define zmax_checksum CHECKSUM("z_max") + #define PI 3.14159265358979323846F // force to be float, do not use M_PI // The Robot converts GCodes into actual movements, and then adds them to the Planner, which passes them to the Conveyor so they can be added to the queue @@ -178,9 +188,11 @@ void Robot::load_config() this->max_speeds[X_AXIS] = THEKERNEL->config->value(x_axis_max_speed_checksum )->by_default(60000.0F)->as_number() / 60.0F; this->max_speeds[Y_AXIS] = THEKERNEL->config->value(y_axis_max_speed_checksum )->by_default(60000.0F)->as_number() / 60.0F; this->max_speeds[Z_AXIS] = THEKERNEL->config->value(z_axis_max_speed_checksum )->by_default( 300.0F)->as_number() / 60.0F; + this->max_speed = THEKERNEL->config->value(max_speed_checksum )->by_default( -60.0F)->as_number() / 60.0F; this->segment_z_moves = THEKERNEL->config->value(segment_z_moves_checksum )->by_default(true)->as_bool(); this->save_g92 = THEKERNEL->config->value(save_g92_checksum )->by_default(false)->as_bool(); + this->save_g54 = THEKERNEL->config->value(save_g54_checksum )->by_default(THEKERNEL->is_grbl_mode())->as_bool(); string g92 = THEKERNEL->config->value(set_g92_checksum )->by_default("")->as_string(); if(!g92.empty()) { // optional setting for a fixed G92 offset @@ -194,7 +206,7 @@ void Robot::load_config() this->s_value = THEKERNEL->config->value(laser_module_default_power_checksum)->by_default(0.8F)->as_number(); // Make our Primary XYZ StepperMotors, and potentially A B C - uint16_t const checksums[][6] = { + uint16_t const motor_checksums[][6] = { ACTUATOR_CHECKSUMS("alpha"), // X ACTUATOR_CHECKSUMS("beta"), // Y ACTUATOR_CHECKSUMS("gamma"), // Z @@ -216,7 +228,7 @@ void Robot::load_config() for (size_t a = 0; a < MAX_ROBOT_ACTUATORS; a++) { Pin pins[3]; //step, dir, enable for (size_t i = 0; i < 3; i++) { - pins[i].from_string(THEKERNEL->config->value(checksums[a][i])->by_default("nc")->as_string())->as_output(); + pins[i].from_string(THEKERNEL->config->value(motor_checksums[a][i])->by_default("nc")->as_string())->as_output(); } if(!pins[0].connected() || !pins[1].connected()) { // step and dir must be defined, but enable is optional @@ -237,9 +249,9 @@ void Robot::load_config() return; } - actuators[a]->change_steps_per_mm(THEKERNEL->config->value(checksums[a][3])->by_default(a == 2 ? 2560.0F : 80.0F)->as_number()); - actuators[a]->set_max_rate(THEKERNEL->config->value(checksums[a][4])->by_default(30000.0F)->as_number()/60.0F); // it is in mm/min and converted to mm/sec - actuators[a]->set_acceleration(THEKERNEL->config->value(checksums[a][5])->by_default(NAN)->as_number()); // mm/secs² + actuators[a]->change_steps_per_mm(THEKERNEL->config->value(motor_checksums[a][3])->by_default(a == 2 ? 2560.0F : 80.0F)->as_number()); + actuators[a]->set_max_rate(THEKERNEL->config->value(motor_checksums[a][4])->by_default(30000.0F)->as_number()/60.0F); // it is in mm/min and converted to mm/sec + actuators[a]->set_acceleration(THEKERNEL->config->value(motor_checksums[a][5])->by_default(NAN)->as_number()); // mm/secs² } check_max_actuator_speeds(); // check the configs are sane @@ -256,10 +268,26 @@ void Robot::load_config() // so the first move can be correct if homing is not performed ActuatorCoordinates actuator_pos; arm_solution->cartesian_to_actuator(machine_position, actuator_pos); - for (size_t i = 0; i < n_motors; i++) + for (size_t i = X_AXIS; i <= Z_AXIS; i++) { actuators[i]->change_last_milestone(actuator_pos[i]); + } + + // initialize any extra axis to machine position + for (size_t i = A_AXIS; i < n_motors; i++) { + actuators[i]->change_last_milestone(machine_position[i]); + } //this->clearToolOffset(); + + soft_endstop_enabled= THEKERNEL->config->value(soft_endstop_checksum, enable_checksum)->by_default(false)->as_bool(); + soft_endstop_halt= THEKERNEL->config->value(soft_endstop_checksum, halt_checksum)->by_default(true)->as_bool(); + + soft_endstop_min[X_AXIS]= THEKERNEL->config->value(soft_endstop_checksum, xmin_checksum)->by_default(NAN)->as_number(); + soft_endstop_min[Y_AXIS]= THEKERNEL->config->value(soft_endstop_checksum, ymin_checksum)->by_default(NAN)->as_number(); + soft_endstop_min[Z_AXIS]= THEKERNEL->config->value(soft_endstop_checksum, zmin_checksum)->by_default(NAN)->as_number(); + soft_endstop_max[X_AXIS]= THEKERNEL->config->value(soft_endstop_checksum, xmax_checksum)->by_default(NAN)->as_number(); + soft_endstop_max[Y_AXIS]= THEKERNEL->config->value(soft_endstop_checksum, ymax_checksum)->by_default(NAN)->as_number(); + soft_endstop_max[Z_AXIS]= THEKERNEL->config->value(soft_endstop_checksum, zmax_checksum)->by_default(NAN)->as_number(); } uint8_t Robot::register_motor(StepperMotor *motor) @@ -324,14 +352,14 @@ void Robot::get_current_machine_position(float *pos) const arm_solution->actuator_to_cartesian(current_position, pos); } -void Robot::print_position(uint8_t subcode, std::string& res) const +void Robot::print_position(uint8_t subcode, std::string& res, bool ignore_extruders) const { // M114.1 is a new way to do this (similar to how GRBL does it). // it returns the realtime position based on the current step position of the actuators. // this does require a FK to get a machine position from the actuator position // and then invert all the transforms to get a workspace position from machine position // M114 just does it the old way uses machine_position and does inverse transforms to get the requested position - int n = 0; + uint32_t n = 0; char buf[64]; if(subcode == 0) { // M114 print WCS wcs_t pos= mcs2wcs(machine_position); @@ -372,13 +400,14 @@ void Robot::print_position(uint8_t subcode, std::string& res) const } } + if(n > sizeof(buf)) n= sizeof(buf); res.append(buf, n); #if MAX_ROBOT_ACTUATORS > 3 // deal with the ABC axis for (int i = A_AXIS; i < n_motors; ++i) { n= 0; - if(actuators[i]->is_extruder()) continue; // don't show an extruder as that will be E + if(ignore_extruders && actuators[i]->is_extruder()) continue; // don't show an extruder as that will be E if(subcode == 4) { // M114.4 print last milestone n= snprintf(buf, sizeof(buf), " %c:%1.4f", 'A'+i-A_AXIS, machine_position[i]); @@ -386,6 +415,7 @@ void Robot::print_position(uint8_t subcode, std::string& res) const // current actuator position n= snprintf(buf, sizeof(buf), " %c:%1.4f", 'A'+i-A_AXIS, actuators[i]->get_current_position()); } + if(n > sizeof(buf)) n= sizeof(buf); if(n > 0) res.append(buf, n); } #endif @@ -562,6 +592,17 @@ void Robot::on_gcode_received(void *argument) actuators[selected_extruder]->change_last_milestone(get_e_scale_fnc ? e*get_e_scale_fnc() : e); } } + if(gcode->subcode == 0 && gcode->get_num_args() > 0) { + for (int i = A_AXIS; i < n_motors; i++) { + // ABC just need to set machine_position and compensated_machine_position if specified + char axis= 'A'+i-3; + if(!actuators[i]->is_extruder() && gcode->has_letter(axis)) { + float ap= gcode->get_value(axis); + machine_position[i]= compensated_machine_position[i]= ap; + actuators[i]->change_last_milestone(ap); // this updates the last_milestone in the actuator + } + } + } #endif return; @@ -630,7 +671,7 @@ void Robot::on_gcode_received(void *argument) case 114:{ std::string buf; - print_position(gcode->subcode, buf); + print_position(gcode->subcode, buf, true); // ignore extruders as they will print E themselves gcode->txt_after_ok.append(buf); return; } @@ -653,6 +694,8 @@ void Robot::on_gcode_received(void *argument) if(actuators[i]->is_extruder()) continue; //extruders handle this themselves gcode->stream->printf(" %c: %g ", 'A' + i - A_AXIS, actuators[i]->get_max_rate()); } + }else{ + gcode->stream->printf(" S: %g ", this->max_speed); } gcode->add_nl = true; @@ -676,6 +719,9 @@ void Robot::on_gcode_received(void *argument) actuators[i]->set_max_rate(v); } } + + }else{ + if(gcode->has_letter('S')) max_speed= gcode->get_value('S'); } @@ -737,6 +783,26 @@ void Robot::on_gcode_received(void *argument) } break; + case 211: // M211 Sn turns soft endstops on/off + if(gcode->has_letter('S')) { + soft_endstop_enabled= gcode->get_uint('S') == 1; + }else{ + gcode->stream->printf("Soft endstops are %s", soft_endstop_enabled ? "Enabled" : "Disabled"); + for (int i = X_AXIS; i <= Z_AXIS; ++i) { + if(isnan(soft_endstop_min[i])) { + gcode->stream->printf(",%c min is disabled", 'X'+i); + } + if(isnan(soft_endstop_max[i])) { + gcode->stream->printf(",%c max is disabled", 'X'+i); + } + if(!is_homed(i)) { + gcode->stream->printf(",%c axis is not homed", 'X'+i); + } + } + gcode->stream->printf("\n"); + } + break; + case 220: // M220 - speed override percentage if (gcode->has_letter('S')) { float factor = gcode->get_value('S'); @@ -778,7 +844,7 @@ void Robot::on_gcode_received(void *argument) gcode->stream->printf(";X- Junction Deviation, Z- Z junction deviation, S - Minimum Planner speed mm/sec:\nM205 X%1.5f Z%1.5f S%1.5f\n", THEKERNEL->planner->junction_deviation, isnan(THEKERNEL->planner->z_junction_deviation)?-1:THEKERNEL->planner->z_junction_deviation, THEKERNEL->planner->minimum_planner_speed); - gcode->stream->printf(";Max cartesian feedrates in mm/sec:\nM203 X%1.5f Y%1.5f Z%1.5f\n", this->max_speeds[X_AXIS], this->max_speeds[Y_AXIS], this->max_speeds[Z_AXIS]); + gcode->stream->printf(";Max cartesian feedrates in mm/sec:\nM203 X%1.5f Y%1.5f Z%1.5f S%1.5f\n", this->max_speeds[X_AXIS], this->max_speeds[Y_AXIS], this->max_speeds[Z_AXIS], this->max_speed); gcode->stream->printf(";Max actuator feedrates in mm/sec:\nM203.1 "); for (int i = 0; i < n_motors; ++i) { @@ -800,16 +866,18 @@ void Robot::on_gcode_received(void *argument) // save wcs_offsets and current_wcs // TODO this may need to be done whenever they change to be compliant - gcode->stream->printf(";WCS settings\n"); - gcode->stream->printf("%s\n", wcs2gcode(current_wcs).c_str()); - int n = 1; - for(auto &i : wcs_offsets) { - if(i != wcs_t(0, 0, 0)) { - float x, y, z; - std::tie(x, y, z) = i; - gcode->stream->printf("G10 L2 P%d X%f Y%f Z%f ; %s\n", n, x, y, z, wcs2gcode(n-1).c_str()); + if(save_g54) { + gcode->stream->printf(";WCS settings\n"); + gcode->stream->printf("%s\n", wcs2gcode(current_wcs).c_str()); + int n = 1; + for(auto &i : wcs_offsets) { + if(i != wcs_t(0, 0, 0)) { + float x, y, z; + std::tie(x, y, z) = i; + gcode->stream->printf("G10 L2 P%d X%f Y%f Z%f ; %s\n", n, x, y, z, wcs2gcode(n-1).c_str()); + } + ++n; } - ++n; } if(save_g92) { // linuxcnc saves G92, so we do too if configured, default is to not save to maintain backward compatibility @@ -926,7 +994,7 @@ void Robot::process_move(Gcode *gcode, enum MOTION_MODE_T motion_mode) } }else{ - // already in machine coordinates, we do not add tool offset for that + // already in machine coordinates, we do not add wcs or tool offset for that for(int i= X_AXIS; i <= Z_AXIS; ++i) { if(!isnan(param[i])) target[i] = param[i]; } @@ -998,6 +1066,9 @@ void Robot::process_move(Gcode *gcode, enum MOTION_MODE_T motion_mode) break; } + // needed to act as start of next arc command + memcpy(arc_milestone, target, sizeof(arc_milestone)); + if(moved) { // set machine_position to the calculated target memcpy(machine_position, target, n_motors*sizeof(float)); @@ -1112,6 +1183,41 @@ bool Robot::append_milestone(const float target[], float rate_mm_s) compensationTransform(transformed_target, false); } + // check soft endstops only for homed axis that are enabled + if(soft_endstop_enabled) { + for (int i = 0; i <= Z_AXIS; ++i) { + if(!is_homed(i)) continue; + if( (!isnan(soft_endstop_min[i]) && transformed_target[i] < soft_endstop_min[i]) || (!isnan(soft_endstop_max[i]) && transformed_target[i] > soft_endstop_max[i]) ) { + if(soft_endstop_halt) { + if(THEKERNEL->is_grbl_mode()) { + THEKERNEL->streams->printf("error:"); + }else{ + THEKERNEL->streams->printf("Error: "); + } + + THEKERNEL->streams->printf("Soft Endstop %c was exceeded - reset or $X or M999 required\n", i+'X'); + THEKERNEL->call_event(ON_HALT, nullptr); + return false; + + //} else if(soft_endstop_truncate) { + // TODO VERY hard to do need to go back and change the target, and calculate intercept with the edge + // and store all preceding vectors that have on eor more points ourtside of bounds so we can create a propper clip against the boundaries + + } else { + // ignore it + if(THEKERNEL->is_grbl_mode()) { + THEKERNEL->streams->printf("error:"); + }else{ + THEKERNEL->streams->printf("Error: "); + } + THEKERNEL->streams->printf("Soft Endstop %c was exceeded - entire move ignored\n", i+'X'); + return false; + } + } + } + } + + bool move= false; float sos= 0; // sum of squares for just primary axis (XYZ usually) @@ -1145,20 +1251,23 @@ bool Robot::append_milestone(const float target[], float rate_mm_s) // as the last milestone won't be updated we do not actually lose any moves as they will be accounted for in the next move if(!auxilliary_move && distance < 0.00001F) return false; - if(!auxilliary_move) { for (size_t i = X_AXIS; i < N_PRIMARY_AXIS; i++) { // find distance unit vector for primary axis only unit_vec[i] = deltas[i] / distance; // Do not move faster than the configured cartesian limits for XYZ - if ( max_speeds[i] > 0 ) { + if ( i <= Z_AXIS && max_speeds[i] > 0 ) { float axis_speed = fabsf(unit_vec[i] * rate_mm_s); if (axis_speed > max_speeds[i]) rate_mm_s *= ( max_speeds[i] / axis_speed ); } } + + if(this->max_speed > 0 && rate_mm_s > this->max_speed) { + rate_mm_s= this->max_speed; + } } // find actuator position given the machine position, use actual adjusted target @@ -1225,8 +1334,16 @@ bool Robot::append_milestone(const float target[], float rate_mm_s) } } + // if we are in feed hold wait here until it is released, this means that even segemnted lines will pause + while(THEKERNEL->get_feed_hold()) { + THEKERNEL->call_event(ON_IDLE, this); + // if we also got a HALT then break out of this + if(THEKERNEL->is_halted()) return false; + } + // Append the block to the planner // NOTE that distance here should be either the distance travelled by the XYZ axis, or the E mm travel if a solo E move + // NOTE this call will bock until there is room in the block queue, on_idle will continue to be called if(THEKERNEL->planner->append_block( actuator_pos, n_motors, rate_mm_s, distance, auxilliary_move ? nullptr : unit_vec, acceleration, s_value, is_g123)) { // this is the new compensated machine position memcpy(this->compensated_machine_position, transformed_target, n_motors*sizeof(float)); @@ -1336,10 +1453,11 @@ bool Robot::append_line(Gcode *gcode, const float target[], float rate_mm_s, flo // We always add another point after this loop so we stop at segments-1, ie i < segments for (int i = 1; i < segments; i++) { if(THEKERNEL->is_halted()) return false; // don't queue any more segments - for (int i = 0; i < n_motors; i++) - segment_end[i] += segment_delta[i]; + for (int j = 0; j < n_motors; j++) + segment_end[j] += segment_delta[j]; // Append the end of this segment to the queue + // this can block waiting for free block queue or if in feed hold bool b= this->append_milestone(segment_end, rate_mm_s); moved= moved || b; } @@ -1366,29 +1484,41 @@ bool Robot::append_arc(Gcode * gcode, const float target[], const float offset[] return false; } - // Scary math - float center_axis0 = this->machine_position[this->plane_axis_0] + offset[this->plane_axis_0]; - float center_axis1 = this->machine_position[this->plane_axis_1] + offset[this->plane_axis_1]; - float linear_travel = target[this->plane_axis_2] - this->machine_position[this->plane_axis_2]; - float r_axis0 = -offset[this->plane_axis_0]; // Radius vector from center to current location + // Scary math. + // We need to use arc_milestone here to get accurate arcs as previous machine_position may have been skipped due to small movements + float center_axis0 = this->arc_milestone[this->plane_axis_0] + offset[this->plane_axis_0]; + float center_axis1 = this->arc_milestone[this->plane_axis_1] + offset[this->plane_axis_1]; + float linear_travel = target[this->plane_axis_2] - this->arc_milestone[this->plane_axis_2]; + float r_axis0 = -offset[this->plane_axis_0]; // Radius vector from center to start position float r_axis1 = -offset[this->plane_axis_1]; - float rt_axis0 = target[this->plane_axis_0] - center_axis0; - float rt_axis1 = target[this->plane_axis_1] - center_axis1; - - // Patch from GRBL Firmware - Christoph Baumann 04072015 - // CCW angle between position and target from circle center. Only one atan2() trig computation required. - float angular_travel = atan2f(r_axis0 * rt_axis1 - r_axis1 * rt_axis0, r_axis0 * rt_axis0 + r_axis1 * rt_axis1); - if (is_clockwise) { // Correct atan2 output per direction - if (angular_travel >= -ARC_ANGULAR_TRAVEL_EPSILON) { angular_travel -= (2 * PI); } + float rt_axis0 = target[this->plane_axis_0] - this->arc_milestone[this->plane_axis_0] - offset[this->plane_axis_0]; // Radius vector from center to target position + float rt_axis1 = target[this->plane_axis_1] - this->arc_milestone[this->plane_axis_1] - offset[this->plane_axis_1]; + float angular_travel = 0; + //check for condition where atan2 formula will fail due to everything canceling out exactly + if((this->arc_milestone[this->plane_axis_0]==target[this->plane_axis_0]) && (this->arc_milestone[this->plane_axis_1]==target[this->plane_axis_1])) { + if (is_clockwise) { // set angular_travel to -2pi for a clockwise full circle + angular_travel = (-2 * PI); + } else { // set angular_travel to 2pi for a counterclockwise full circle + angular_travel = (2 * PI); + } } else { - if (angular_travel <= ARC_ANGULAR_TRAVEL_EPSILON) { angular_travel += (2 * PI); } + // Patch from GRBL Firmware - Christoph Baumann 04072015 + // CCW angle between position and target from circle center. Only one atan2() trig computation required. + // Only run if not a full circle or angular travel will incorrectly result in 0.0f + angular_travel = atan2f(r_axis0 * rt_axis1 - r_axis1 * rt_axis0, r_axis0 * rt_axis0 + r_axis1 * rt_axis1); + if (plane_axis_2 == Y_AXIS) { is_clockwise = !is_clockwise; } //Math for XZ plane is reverse of other 2 planes + if (is_clockwise) { // adjust angular_travel to be in the range of -2pi to 0 for clockwise arcs + if (angular_travel > 0) { angular_travel -= (2 * PI); } + } else { // adjust angular_travel to be in the range of 0 to 2pi for counterclockwise arcs + if (angular_travel < 0) { angular_travel += (2 * PI); } + } } // Find the distance for this gcode float millimeters_of_travel = hypotf(angular_travel * radius, fabsf(linear_travel)); // We don't care about non-XYZ moves ( for example the extruder produces some of those ) - if( millimeters_of_travel < 0.00001F ) { + if( millimeters_of_travel < 0.000001F ) { return false; } @@ -1400,83 +1530,90 @@ bool Robot::append_arc(Gcode * gcode, const float target[], const float offset[] arc_segment = min_err_segment; } } + + // catch fall through on above + if(arc_segment < 0.0001F) { + arc_segment= 0.5F; /// the old default, so we avoid the divide by zero + } + // Figure out how many segments for this gcode // TODO for deltas we need to make sure we are at least as many segments as requested, also if mm_per_line_segment is set we need to use the - uint16_t segments = ceilf(millimeters_of_travel / arc_segment); - - //printf("Radius %f - Segment Length %f - Number of Segments %d\r\n",radius,arc_segment,segments); // Testing Purposes ONLY - float theta_per_segment = angular_travel / segments; - float linear_per_segment = linear_travel / segments; - - /* Vector rotation by transformation matrix: r is the original vector, r_T is the rotated vector, - and phi is the angle of rotation. Based on the solution approach by Jens Geisler. - r_T = [cos(phi) -sin(phi); - sin(phi) cos(phi] * r ; - For arc generation, the center of the circle is the axis of rotation and the radius vector is - defined from the circle center to the initial position. Each line segment is formed by successive - vector rotations. This requires only two cos() and sin() computations to form the rotation - matrix for the duration of the entire arc. Error may accumulate from numerical round-off, since - all float numbers are single precision on the Arduino. (True float precision will not have - round off issues for CNC applications.) Single precision error can accumulate to be greater than - tool precision in some cases. Therefore, arc path correction is implemented. - - Small angle approximation may be used to reduce computation overhead further. This approximation - holds for everything, but very small circles and large mm_per_arc_segment values. In other words, - theta_per_segment would need to be greater than 0.1 rad and N_ARC_CORRECTION would need to be large - to cause an appreciable drift error. N_ARC_CORRECTION~=25 is more than small enough to correct for - numerical drift error. N_ARC_CORRECTION may be on the order a hundred(s) before error becomes an - issue for CNC machines with the single precision Arduino calculations. - This approximation also allows mc_arc to immediately insert a line segment into the planner - without the initial overhead of computing cos() or sin(). By the time the arc needs to be applied - a correction, the planner should have caught up to the lag caused by the initial mc_arc overhead. - This is important when there are successive arc motions. - */ - // Vector rotation matrix values - float cos_T = 1 - 0.5F * theta_per_segment * theta_per_segment; // Small angle approximation - float sin_T = theta_per_segment; + uint16_t segments = floorf(millimeters_of_travel / arc_segment); + bool moved= false; - // TODO we need to handle the ABC axis here by segmenting them - float arc_target[n_motors]; - float sin_Ti; - float cos_Ti; - float r_axisi; - uint16_t i; - int8_t count = 0; + if(segments > 1) { + float theta_per_segment = angular_travel / segments; + float linear_per_segment = linear_travel / segments; + + /* Vector rotation by transformation matrix: r is the original vector, r_T is the rotated vector, + and phi is the angle of rotation. Based on the solution approach by Jens Geisler. + r_T = [cos(phi) -sin(phi); + sin(phi) cos(phi] * r ; + For arc generation, the center of the circle is the axis of rotation and the radius vector is + defined from the circle center to the initial position. Each line segment is formed by successive + vector rotations. This requires only two cos() and sin() computations to form the rotation + matrix for the duration of the entire arc. Error may accumulate from numerical round-off, since + all float numbers are single precision on the Arduino. (True float precision will not have + round off issues for CNC applications.) Single precision error can accumulate to be greater than + tool precision in some cases. Therefore, arc path correction is implemented. + + Small angle approximation may be used to reduce computation overhead further. This approximation + holds for everything, but very small circles and large mm_per_arc_segment values. In other words, + theta_per_segment would need to be greater than 0.1 rad and N_ARC_CORRECTION would need to be large + to cause an appreciable drift error. N_ARC_CORRECTION~=25 is more than small enough to correct for + numerical drift error. N_ARC_CORRECTION may be on the order a hundred(s) before error becomes an + issue for CNC machines with the single precision Arduino calculations. + This approximation also allows mc_arc to immediately insert a line segment into the planner + without the initial overhead of computing cos() or sin(). By the time the arc needs to be applied + a correction, the planner should have caught up to the lag caused by the initial mc_arc overhead. + This is important when there are successive arc motions. + */ + // Vector rotation matrix values + float cos_T = 1 - 0.5F * theta_per_segment * theta_per_segment; // Small angle approximation + float sin_T = theta_per_segment; + + // TODO we need to handle the ABC axis here by segmenting them + float arc_target[n_motors]; + float sin_Ti; + float cos_Ti; + float r_axisi; + uint16_t i; + int8_t count = 0; + + // init array for all axis + memcpy(arc_target, machine_position, n_motors*sizeof(float)); + + // Initialize the linear axis + arc_target[this->plane_axis_2] = this->machine_position[this->plane_axis_2]; + + for (i = 1; i < segments; i++) { // Increment (segments-1) + if(THEKERNEL->is_halted()) return false; // don't queue any more segments - // init array for all axis - memcpy(arc_target, machine_position, n_motors*sizeof(float)); + if (count < this->arc_correction ) { + // Apply vector rotation matrix + r_axisi = r_axis0 * sin_T + r_axis1 * cos_T; + r_axis0 = r_axis0 * cos_T - r_axis1 * sin_T; + r_axis1 = r_axisi; + count++; + } else { + // Arc correction to radius vector. Computed only every N_ARC_CORRECTION increments. + // Compute exact location by applying transformation matrix from initial radius vector(=-offset). + cos_Ti = cosf(i * theta_per_segment); + sin_Ti = sinf(i * theta_per_segment); + r_axis0 = -offset[this->plane_axis_0] * cos_Ti + offset[this->plane_axis_1] * sin_Ti; + r_axis1 = -offset[this->plane_axis_0] * sin_Ti - offset[this->plane_axis_1] * cos_Ti; + count = 0; + } - // Initialize the linear axis - arc_target[this->plane_axis_2] = this->machine_position[this->plane_axis_2]; + // Update arc_target location + arc_target[this->plane_axis_0] = center_axis0 + r_axis0; + arc_target[this->plane_axis_1] = center_axis1 + r_axis1; + arc_target[this->plane_axis_2] += linear_per_segment; - bool moved= false; - for (i = 1; i < segments; i++) { // Increment (segments-1) - if(THEKERNEL->is_halted()) return false; // don't queue any more segments - - if (count < this->arc_correction ) { - // Apply vector rotation matrix - r_axisi = r_axis0 * sin_T + r_axis1 * cos_T; - r_axis0 = r_axis0 * cos_T - r_axis1 * sin_T; - r_axis1 = r_axisi; - count++; - } else { - // Arc correction to radius vector. Computed only every N_ARC_CORRECTION increments. - // Compute exact location by applying transformation matrix from initial radius vector(=-offset). - cos_Ti = cosf(i * theta_per_segment); - sin_Ti = sinf(i * theta_per_segment); - r_axis0 = -offset[this->plane_axis_0] * cos_Ti + offset[this->plane_axis_1] * sin_Ti; - r_axis1 = -offset[this->plane_axis_0] * sin_Ti - offset[this->plane_axis_1] * cos_Ti; - count = 0; + // Append this segment to the queue + bool b= this->append_milestone(arc_target, rate_mm_s); + moved= moved || b; } - - // Update arc_target location - arc_target[this->plane_axis_0] = center_axis0 + r_axis0; - arc_target[this->plane_axis_1] = center_axis1 + r_axis1; - arc_target[this->plane_axis_2] += linear_per_segment; - - // Append this segment to the queue - bool b= this->append_milestone(arc_target, rate_mm_s); - moved= moved || b; } // Ensure last segment arrives at target location. @@ -1538,3 +1675,19 @@ float Robot::get_feed_rate() const { return THEKERNEL->gcode_dispatch->get_modal_command() == 0 ? seek_rate : feed_rate; } + +bool Robot::is_homed(uint8_t i) const +{ + if(i >= 3) return false; // safety + + // if we are homing we ignore soft endstops so return false + bool homing; + bool ok = PublicData::get_value(endstops_checksum, get_homing_status_checksum, 0, &homing); + if(!ok || homing) return false; + + // check individual axis homing status + bool homed[3]; + ok = PublicData::get_value(endstops_checksum, get_homed_status_checksum, 0, homed); + if(!ok) return false; + return homed[i]; +}