From 986545b57f27403e9f8729bb6252957bc8baf2ea Mon Sep 17 00:00:00 2001 From: Stefan Monnier Date: Sun, 17 Nov 2013 18:11:27 -0500 Subject: [PATCH] * lisp/emacs-lisp/nadvice.el (remove-function): Align with add-function's behavior. --- lisp/ChangeLog | 3 +++ lisp/emacs-lisp/nadvice.el | 2 +- 2 files changed, 4 insertions(+), 1 deletion(-) diff --git a/lisp/ChangeLog b/lisp/ChangeLog index f408df795a..a749f70b4f 100644 --- a/lisp/ChangeLog +++ b/lisp/ChangeLog @@ -1,5 +1,8 @@ 2013-11-17 Stefan Monnier + * emacs-lisp/nadvice.el (remove-function): Align with + add-function's behavior. + * progmodes/gdb-mi.el: Avoid backtracking in regexp matcher. (gdb--string-regexp): New constant. (gdb-tooltip-print, gdb-var-evaluate-expression-handler) diff --git a/lisp/emacs-lisp/nadvice.el b/lisp/emacs-lisp/nadvice.el index 576e72088e..0352164caf 100644 --- a/lisp/emacs-lisp/nadvice.el +++ b/lisp/emacs-lisp/nadvice.el @@ -284,7 +284,7 @@ of the piece of advice." (cond ((eq 'local (car-safe place)) (setq place `(advice--buffer-local ,@(cdr place)))) ((symbolp place) - (error "Use (default-value '%S) or (local '%S)" place place))) + (setq place `(default-value ',place)))) (gv-letplace (getter setter) place (macroexp-let2 nil new `(advice--remove-function ,getter ,function) `(unless (eq ,new ,getter) ,(funcall setter new))))) -- 2.20.1