Fix some minor races in hosts lacking mkostemp.
authorPaul Eggert <eggert@cs.ucla.edu>
Sun, 4 Aug 2013 16:56:56 +0000 (09:56 -0700)
committerPaul Eggert <eggert@cs.ucla.edu>
Sun, 4 Aug 2013 16:56:56 +0000 (09:56 -0700)
commite0fdb6943066032db294720915c3bd644bf2bcd1
tree0aa420b81dc0187e2efec3ff4fe3cf046ad1c598
parent484ab23924d39b3e26d54074fd659633e1660ef4
Fix some minor races in hosts lacking mkostemp.

Gnulib's emulation of mkostemp doesn't have races that Emacs's does.
* configure.ac (mkostemp): Remove check for this function;
gnulib does the check now.
(mkstemp): Remove check for this no-longer-used function.
* lib/mkostemp.c, lib/secure_getenv.c, lib/tempname.c, lib/tempname.h:
* m4/mkostemp.m4, m4/secure_getenv.m4, m4/tempname.m4:
New files, copied from Gnulib.
* lib/gnulib.mk, m4/gnulib-comp.m4: Regenerate.
* admin/merge-gnulib (GNULIB_MODULES): Add mkostemp.
* lib-src/movemail.c (main):
* lib-src/update-game-score.c (write_scores):
Use mkostemp (which now works on all platforms, due to changes
in the portability layer) rather than mktemp (which has a race)
or mkstemp (which we no longer bother with).
* src/callproc.c (create_temp_file):
* src/filelock.c (create_lock_file):
Assume mkostemp, since it's now provided by Gnulib.

Fixes: debbugs:15015
19 files changed:
ChangeLog
admin/ChangeLog
admin/merge-gnulib
configure.ac
lib-src/ChangeLog
lib-src/movemail.c
lib-src/update-game-score.c
lib/gnulib.mk
lib/mkostemp.c [new file with mode: 0644]
lib/secure_getenv.c [new file with mode: 0644]
lib/tempname.c [new file with mode: 0644]
lib/tempname.h [new file with mode: 0644]
m4/gnulib-comp.m4
m4/mkostemp.m4 [new file with mode: 0644]
m4/secure_getenv.m4 [new file with mode: 0644]
m4/tempname.m4 [new file with mode: 0644]
src/ChangeLog
src/callproc.c
src/filelock.c