Replace completion-base-size by completion-base-position to fix bugs
authorStefan Monnier <monnier@iro.umontreal.ca>
Thu, 15 Oct 2009 01:50:17 +0000 (01:50 +0000)
committerStefan Monnier <monnier@iro.umontreal.ca>
Thu, 15 Oct 2009 01:50:17 +0000 (01:50 +0000)
commitd5e637154f5084076b1a348155fc68139747acca
tree8c95bf13b4ca185b32dfa84ab9fe1b409f43632b
parentb0d6136e736a7c3a843bb56049ed19219312150c
Replace completion-base-size by completion-base-position to fix bugs
such as (bug#4699).
* simple.el (completion-base-position): New var.
(completion-base-size): Mark as obsolete.
(choose-completion): Make it work for mouse events as well.
Pass the new base-position to choose-completion-string.
(choose-completion-guess-base-position): New function, extracted from
choose-completion-delete-max-match.
(choose-completion-delete-max-match): Use it.  Make obsolete.
(choose-completion-string): Use the new base-position info.
(completion-root-regexp): Delete.
(completion-setup-function): Preserve completion-base-position.
Eliminate obsolete base-size manipulation.
* minibuffer.el (display-completion-list): Don't mess with base-size.
(minibuffer-completion-help): Set completion-base-position instead.
* mouse.el (mouse-choose-completion): Redefine as a mere alias to
choose-completion.
* textmodes/bibtex.el (bibtex-complete):
* emacs-lisp/crm.el (crm--choose-completion-string):
Adjust to new calling convention.
* complete.el (partial-completion-mode): Use minibufferp to avoid
bumping into incompatible change to choose-completion-string-functions.
* ido.el (ido-choose-completion-string): Make its calling convention
more permissive.
* comint.el (comint-dynamic-list-input-ring-select): Remove obsolete
base-size manipulation.
(comint-dynamic-list-input-ring): Use dotimes and push.
* iswitchb.el (iswitchb-completion-help): Remove dead-code call to
fundamental-mode.  Use `or'.
12 files changed:
etc/NEWS
lisp/ChangeLog
lisp/comint.el
lisp/complete.el
lisp/emacs-lisp/crm.el
lisp/ido.el
lisp/international/quail.el
lisp/iswitchb.el
lisp/minibuffer.el
lisp/mouse.el
lisp/simple.el
lisp/textmodes/bibtex.el