1 2011-10-11 Stefan Monnier <monnier@iro.umontreal.ca>
3 * minibuf.c (Finternal_complete_buffer): Fix last change (bug#9709).
5 2011-10-08 Glenn Morris <rgm@gnu.org>
7 * callint.c (Fcall_interactively): Give a more explicit error for the
8 'c' case with a non-character input. (Bug#8479)
10 2011-10-08 Eli Zaretskii <eliz@gnu.org>
12 * xdisp.c (hscroll_window_tree): Support hscroll in right-to-left
14 (set_cursor_from_row): Fix cursor positioning in mixed L2R+R2L
15 lines that are hscrolled on the left.
17 * dispnew.c (buffer_posn_from_coords): Account for a possible
18 presence of header-line. (Bug#4426)
20 2011-10-07 Stefan Monnier <monnier@iro.umontreal.ca>
22 * buffer.c (syms_of_buffer) <enable-multibyte-characters>: Don't
23 advertise functionality which we discourage or doesn't work.
25 2011-10-07 Paul Eggert <eggert@cs.ucla.edu>
27 * alloc.c (GC_LISP_OBJECT_ALIGNMENT): Use offsetof, not __alignof__
28 or sizeof. __alignof__ gives the wrong answer on Fedora x86-64
29 with GCC 4.6.1 when configured with CC='gcc -m32' --with-wide-int;
30 this makes Emacs dump core during garbage collection on rare
31 occasions. sizeof is obviously inferior to offsetof here, so
33 (GC_POINTER_ALIGNMENT): New macro.
34 (mark_memory): Omit 3rd (offset) arg; caller changed.
35 Don't assume EMACS_INT alignment is the same as pointer alignment.
37 2011-10-03 Stefan Monnier <monnier@iro.umontreal.ca>
39 * keyboard.c (read_key_sequence_remapped): New var.
40 (read_key_sequence): Compute remapping in the right buffer.
41 (command_loop_1): Use read_key_sequence's remapping directly.
43 2011-10-02 Stefan Monnier <monnier@iro.umontreal.ca>
45 * dired.c (file_name_completion): Don't expand file name.
46 (Ffile_name_completion, Ffile_name_all_completions): Expand file name
47 before checking file name handler.
49 * minibuf.c (Finternal_complete_buffer): Only show internal buffers if
50 they've been requested explicitly (bug#9591).
52 2011-10-01 Andreas Schwab <schwab@linux-m68k.org>
54 * keymap.c (Fsingle_key_description): Use make_specified_string
55 instead of build_string to build string from push_key_description.
58 2011-09-30 Paul Eggert <eggert@cs.ucla.edu>
60 * buffer.h (struct buffer): Use time_t, not int, for a time stamp.
61 This fixes a Y2038 bug on 64-bit hosts.
62 * buffer.c (reset_buffer):
63 * fileio.c (Fdo_auto_save, Fset_buffer_auto_saved)
64 (Fclear_buffer_auto_save_failure):
65 Use 0, not -1, to represent an unset failure time, since time_t
68 Remove dependency on glibc malloc internals.
69 * alloc.c (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
70 Move back here from lisp.h, but with their new implementations.
71 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
72 (XMALLOC_OVERRUN_SIZE_SIZE): Move these new lisp.h macros here.
73 * charset.c (charset_table_init): New static var.
74 (syms_of_charset): Use it instead of xmalloc. This removes a
75 dependency on glibc malloc internals. See Eli Zaretskii's comment in
76 <http://lists.gnu.org/archive/html/emacs-devel/2011-09/msg00815.html>.
77 * lisp.h (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
79 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
80 (XMALLOC_OVERRUN_SIZE_SIZE): Move to alloc.c.
82 2011-09-30 Jan Djärv <jan.h.d@swipnet.se>
84 * nsterm.m (windowDidResize): Call x_set_window_size only when
85 ns_in_resize is true. Otherwise set pixelwidth/height and
86 call change_frame_size (Bug#9628).
88 2011-09-30 Paul Eggert <eggert@cs.ucla.edu>
90 Port --enable-checking=all to Fedora 14 x86-64.
91 * charset.c (syms_of_charset): Also account for glibc malloc's
92 internal overhead when calculating the initial malloc maximum.
94 Port --enable-checking=all to Fedora 14 x86.
95 * alloc.c (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
97 (xmalloc_put_size, xmalloc_get_size, overrun_check_malloc)
98 (overrun_check_realloc, overrun_check_free):
99 Use XMALLOC_OVERRUN_SIZE_SIZE, not sizeof (size_t).
100 That way, xmalloc returns a properly-aligned pointer even if
101 XMALLOC_OVERRUN_CHECK is defined. The old debugging code happened
102 to align OK on typical 64-bit hosts, but not on Fedora 14 x86.
103 * charset.c (syms_of_charset): Take XMALLOC_OVERRUN_CHECK_OVERHEAD
104 into account when calculating the initial malloc maximum.
105 * lisp.h (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
106 Move here from alloc.c, so that charset.c can use it too.
107 Properly align; the old code wasn't right for common 32-bit hosts
108 when configured with --enable-checking=all.
109 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
110 (XMALLOC_OVERRUN_SIZE_SIZE): New macros.
112 2011-09-29 Eli Zaretskii <eliz@gnu.org>
114 * sysdep.c (snprintf) [!EOVERFLOW]: If EOVERFLOW is not defined,
117 2011-09-28 Eli Zaretskii <eliz@gnu.org>
119 * xdisp.c (compute_display_string_end): If there's no display
120 string at CHARPOS, return -1.
122 * bidi.c (bidi_fetch_char): When compute_display_string_end
123 returns a negative value, treat the character as a normal
124 character not covered by a display string. (Bug#9624)
126 2011-09-28 Juanma Barranquero <lekktu@gmail.com>
128 * lread.c (Fread_from_string): Fix typo in docstring.
130 2011-09-27 Eli Zaretskii <eliz@gnu.org>
132 * xdisp.c (handle_invisible_prop): If invisible text ends on a
133 newline, reseat the iterator instead of bidi-iterating there one
134 character at a time. (Bug#9610)
135 (BUFFER_POS_REACHED_P, move_it_in_display_line_to): Bail when past
136 TO_CHARPOS if the bidi iterator is at base embedding level.
138 2011-09-27 Andreas Schwab <schwab@linux-m68k.org>
140 * lread.c (readevalloop): Use correct code for NBSP.
141 (read1): Likewise. (Bug#9608)
143 2011-09-25 Michael Albinus <michael.albinus@gmx.de>
145 * dbusbind.c (Fdbus_register_signal): When service is not
146 registered, use nil in Vdbus_registered_objects_table. (Bug#9581)
148 2011-09-25 Glenn Morris <rgm@gnu.org>
150 * buffer.c (truncate-lines): Doc fix.
152 2011-09-24 Chong Yidong <cyd@stupidchicken.com>
154 * window.c (Fwindow_prev_buffers, Fset_window_prev_buffers)
155 (Fset_window_next_buffers): Doc fix.
157 2011-09-24 Glenn Morris <rgm@gnu.org>
159 * minibuf.c (read_minibuf): Disable line truncation. (Bug#5715)
161 2011-09-24 Paul Eggert <eggert@cs.ucla.edu>
163 Fix minor problems found by static checking.
164 * xdisp.c (string_from_display_spec): Don't assume vecsize fits in int.
165 * indent.c (Fvertical_motion): Fix == vs = typo.
167 2011-09-24 Eli Zaretskii <eliz@gnu.org>
169 * dispnew.c (syms_of_display) <redisplay-dont-pause>:
170 Default value is now t. Doc fix.
172 * indent.c (Fvertical_motion): Compute and apply the overshoot
173 logic when moving up, not only when moving down. Fix the
174 confusing name and values of the it_overshoot_expected variable;
175 logic changes accordingly. (Bug#9254) (Bug#9549)
177 * xdisp.c (pos_visible_p): Produce correct pixel coordinates when
178 CHARPOS is covered by a display string which includes newlines.
179 (move_it_vertically_backward): Avoid inflooping when START_CHARPOS
180 is covered by a display string with embedded newlines.
182 2011-09-24 Michael Albinus <michael.albinus@gmx.de>
184 * dbusbind.c (Fdbus_register_signal): Add match rule to
185 Vdbus_registered_objects_table. (Bug#9581)
186 (Fdbus_register_method, Vdbus_registered_objects_table):
189 2011-09-24 Jim Meyering <meyering@redhat.com>
191 do not ignore write error for any output size
192 The previous change was incomplete.
193 While it makes emacs --batch detect the vast majority of stdout
194 write failures, errors were still ignored whenever the output size is
195 k * (BUFSIZ+1) - 4. E.g., on a system with BUFSIZ of 4096,
196 $ emacs --batch --eval '(print (format "%4093d" 0))' > /dev/full \
197 && echo FAIL: ignored write error
198 FAIL: ignored write error
199 $ emacs --batch --eval '(print (format "%20481d" 0))' > /dev/full \
200 && echo FAIL: ignored write error
201 FAIL: ignored write error
202 * emacs.c (Fkill_emacs): Also test ferror. (Bug#9574)
204 2011-09-23 Andreas Schwab <schwab@linux-m68k.org>
206 * emacs.c (Fkill_emacs): In noninteractive mode exit
207 non-successfully if a write error occurred on stdout. (Bug#9574)
209 2011-09-21 Eli Zaretskii <eliz@gnu.org>
211 * xdisp.c (pop_it): Allow it->object that is a cons cell to pass
214 * dispextern.h (struct it): Update the comment documenting what
217 2011-09-20 Eli Zaretskii <eliz@gnu.org>
219 * xdisp.c (set_cursor_from_row): If the row ends in a newline from
220 a display string, extend search for cursor position to end of row.
221 (find_row_edges): If the row ends in a newline from a display
222 string, increment its MATRIX_ROW_END_CHARPOS by one. (Bug#9549)
223 Handle the case of a display string with multiple newlines.
224 (Fcurrent_bidi_paragraph_direction): Fix search for previous
225 non-empty line. Fixes confusing cursor motion with arrow keys at
226 the beginning of a line that starts with whitespace.
228 2011-09-19 Lars Magne Ingebrigtsen <larsi@gnus.org>
230 * lread.c (Fread_from_string): Document what FINAL-STRING-INDEX is
233 2011-09-18 Chong Yidong <cyd@stupidchicken.com>
235 * xfns.c (Fx_create_frame): Handle the bitmapIcon resource as
238 2011-09-18 Eli Zaretskii <eliz@gnu.org>
240 * xdisp.c (display_line): Record maximum and minimum buffer
241 positions even if no glyphs were produced (e.g., by a zero-width
242 stretch). Fixes bug#9530 on a TTY. Under word-wrap, don't record
243 buffer positions that will be removed from the glyph row because
245 (produce_stretch_glyph): Fix a bug in :align-to on a TTY when the
246 column is beyond frame width: don't subtract 1 "pixel" when
247 computing width of the stretch.
248 (reseat_at_next_visible_line_start): Undo the change made on
249 2011-09-17 that saved paragraph information and restored it after
250 the call to `reseat'. (Bug#9545)
252 2011-09-18 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
254 * xdisp.c (expose_window): Save original value of phys_cursor_on_p
255 and turn window cursor on if cleared (Bug#9415).
257 2011-09-18 Andreas Schwab <schwab@linux-m68k.org>
259 * search.c (boyer_moore): Take unibyte characters from pattern
260 literally. (Bug#9458)
262 2011-09-18 Eli Zaretskii <eliz@gnu.org>
264 * xdisp.c (reseat_at_next_visible_line_start): Fix last change.
266 2011-09-18 Paul Eggert <eggert@cs.ucla.edu>
268 Fix minor problem found by static checking.
269 * xdisp.c (reseat_at_next_visible_line_start): Mark locals as
270 initialized, to pacify gcc -Wuninitialized.
272 * fileio.c: Report proper errno when syscall falls.
273 (Finsert_file_contents): Save and restore errno,
274 so that report_file_error outputs the correct diagnostic.
275 (Fwrite_region) [CLASH_DETECTION]: Likewise.
277 2011-09-18 Eli Zaretskii <eliz@gnu.org>
279 * .gdbinit (pgx): Fix references to fields of `struct glyph'.
281 2011-09-17 Eli Zaretskii <eliz@gnu.org>
283 * xdisp.c (produce_stretch_glyph): Another fix for changes made on
284 2011-08-30T17:32:44Z!eliz@gnu.org. (Bug#9530)
286 2011-09-17 Eli Zaretskii <eliz@gnu.org>
288 * xdisp.c (reseat_at_next_visible_line_start): Keep information
289 about the current paragraph and restore it after the call to
292 * bidi.c (MAX_PARAGRAPH_SEARCH): New macro.
293 (bidi_find_paragraph_start): Search back for paragraph beginning
294 at most MAX_PARAGRAPH_SEARCH lines; if not found, return BEGV_BYTE.
295 (bidi_move_to_visually_next): Only trigger paragraph-related
296 computations when the last character is a newline or at EOB, not
297 just any NEUTRAL_B. (Bug#9470)
299 * xdisp.c (set_cursor_from_row): Don't invoke special treatment of
300 truncated lines if point is covered by a display string. (Bug#9524)
302 2011-09-16 Paul Eggert <eggert@cs.ucla.edu>
304 * xselect.c: Relax test for outgoing X longs (Bug#9498).
305 (cons_to_x_long): New function.
306 (lisp_data_to_selection_data): Use it. Correct the test for
307 short-versus-long data; it was negated. Break out of vector
308 loop, for efficiency, when a long datum is discovered.
310 2011-09-16 Stefan Monnier <monnier@iro.umontreal.ca>
312 * eval.c (Fquote): Document its non-consing behavior (bug#9482).
314 2011-09-16 Eli Zaretskii <eliz@gnu.org>
316 * image.c (tiff_handler): Work around a bug in MinGW GCC 3.x (see
317 GCC PR/17406) by declaring this function with external scope.
319 2011-09-15 Paul Eggert <eggert@cs.ucla.edu>
321 * editfns.c (Fformat): Fix bug in text-property fix (Bug#9514).
322 Don't mishandle (length (format "%%")) and (format "%4000s%%" "").
324 2011-09-15 Andreas Schwab <schwab@linux-m68k.org>
326 * editfns.c (Fformat): Correctly handle text properties on "%%".
328 2011-09-15 Eli Zaretskii <eliz@gnu.org>
330 * xterm.c (x_draw_composite_glyph_string_foreground):
331 * w32term.c (x_draw_composite_glyph_string_foreground):
332 * term.c (encode_terminal_code):
333 * composite.c (composition_update_it, get_composition_id):
334 * xdisp.c (get_next_display_element)
335 (fill_composite_glyph_string): Add comments about special meaning
336 of TAB characters in a composition.
338 2011-09-15 Paul Eggert <eggert@cs.ucla.edu>
340 * editfns.c (Fformat): Fix off-by-1 bug for "%%b" (Bug#9514).
341 This occurs when processing a multibyte format.
342 Problem reported by Wolfgang Jenker.
344 2011-09-15 Johan Bockgård <bojohan@gnu.org>
346 * xdisp.c (try_cursor_movement): Only check for exact match if
347 cursor hpos found by set_cursor_from_row is valid. (Bug#9495)
349 2011-09-14 Paul Eggert <eggert@cs.ucla.edu>
351 Remove unused external symbols.
352 * dispextern.h (calc_pixel_width_or_height): Remove decl.
353 * xdisp.c (calc_pixel_width_or_height): Now static.
354 * doprnt.c (exprintf) [! (HAVE_X_WINDOWS && USE_X_TOOLKIT)]: Remove.
355 * indent.c (check_display_width):
356 * w32term.c: Fix comment to match code.
357 * xterm.c, xterm.h (x_catching_errors): Remove.
359 2011-09-14 Paul Eggert <eggert@cs.ucla.edu>
361 * xselect.c: Use signed conversions more consistently (Bug#9498).
362 (selection_data_to_lisp_data): Assume incoming selection data are
363 signed integers, not unsigned. This is to be consistent with
364 outgoing selection data, which was modified to use signed integers
365 in as part of the fix to Bug#9196 in response to Jan D.'s comment
366 in <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9196#32> that X11
367 expects long, not unsigned long.
369 2011-09-14 Eli Zaretskii <eliz@gnu.org>
371 * xdisp.c (try_window_reusing_current_matrix): Fix incorrect
372 computation of loop end. Reported by Johan Bockgård
375 2011-09-13 Chong Yidong <cyd@stupidchicken.com>
377 * frame.c (Fother_visible_frames_p): Function deleted.
379 2011-09-12 Eli Zaretskii <eliz@gnu.org>
381 * indent.c (compute_motion): Process display vector front to back
382 rather than the other way around. (Bug#2496)
384 2011-09-12 Stefan Monnier <monnier@iro.umontreal.ca>
386 * fileio.c (Finsert_file_contents): Don't assume beg_offset is 0.
388 2011-09-11 Chong Yidong <cyd@stupidchicken.com>
390 * minibuf.c (Fread_from_minibuffer): Doc fix.
392 2011-09-11 Eli Zaretskii <eliz@gnu.org>
394 * xdisp.c (produce_stretch_glyph): Fix a typo made in changes from
395 2011-08-30T17:32:44Z!eliz@gnu.org. (Bug#9475)
397 2011-09-11 Lars Magne Ingebrigtsen <larsi@gnus.org>
399 * fileio.c (Fvisited_file_modtime): Document `(-1 65535)' as a
400 value for non-existent files.
402 2011-09-11 Eli Zaretskii <eliz@gnu.org>
404 * fileio.c (Finsert_file_contents): If the file cannot be opened,
405 set its "size" to -1. This will set the modtime_size field of
406 the corresponding buffer to -1, which is what
407 verify-visited-file-modtime expects for files that do not exist.
410 2011-09-11 Paul Eggert <eggert@cs.ucla.edu>
412 * keymap.h (KEY_DESCRIPTION_SIZE, push_key_description): Move decls
414 * lisp.h: ... from here. push_key_description is no longer
415 defined in keyboard.c, so its declaration should not be in
416 lisp.h's "Defined in keyboard.c" section, and KEY_DESCRIPTION_SIZE
417 logically belongs with push_key_description.
419 2011-09-10 Paul Eggert <eggert@cs.ucla.edu>
421 * buffer.h: Include <sys/types.h> instead of <time.h>.
422 Otherwise, off_t wasn't defined on FreeBSD 9.0-BETA2 i386.
423 Problem reported by Herbert J. Skuhra.
425 2011-09-10 Lars Magne Ingebrigtsen <larsi@gnus.org>
427 * xml.c (parse_region): Make the parsing work for
428 non-comment-starting XML files again (bug#9144).
430 2011-09-10 Andreas Schwab <schwab@linux-m68k.org>
432 * image.c (gif_load): Fix calculation of bottom and right corner.
435 2011-09-10 Eli Zaretskii <eliz@gnu.org>
437 * xdisp.c (MAX_DISP_SCAN): Decrease to 250. Prevents sluggish
438 redisplay in small windows.
440 2011-09-09 Eli Zaretskii <eliz@gnu.org>
442 * frame.c (x_report_frame_params): Cast to avoid compiler warnings.
444 2011-09-08 Martin Rudalics <rudalics@gmx.at>
446 * window.c (Fset_window_prev_buffers, Fset_window_next_buffers):
447 Operate on live windows only.
449 2011-09-08 Juanma Barranquero <lekktu@gmail.com>
451 * emacs.c (my_heap_start): #ifdef to avoid warnings when unused.
453 2011-09-07 Eli Zaretskii <eliz@gnu.org>
455 * xdisp.c (move_it_in_display_line_to): Call RESTORE_IT on ppos_it
456 only under bidi iteration.
458 2011-09-07 Jan Djärv <jan.h.d@swipnet.se>
460 * gtkutil.c (xg_make_tool_item): Insert comment about eventbox.
462 2011-09-06 Paul Eggert <eggert@cs.ucla.edu>
464 isnan: Fix porting problem to Solaris 10 with bundled gcc.
465 Without this fix, the command to link temacs failed due to an
466 undefined symbol __builtin_isnan. This is because
467 /usr/include/iso/math_c99.h #defines isnan(x) to
468 __builtin_isnan(x), but the bundled gcc, which identifies itself
469 as gcc 3.4.3 (csl-sol210-3_4-branch+sol_rpath), does not have
471 * floatfns.c (isnan): #undef, and then #define to a clone of
473 (Fisnan): Always define, since it's always available now.
474 (syms_of_floatfns): Always define isnan at the Lisp level.
476 2011-09-06 Paul Eggert <eggert@cs.ucla.edu>
478 * Makefile.in (gl-stamp): move-if-change now in build-aux (Bug#9169).
480 2011-09-06 Paul Eggert <eggert@cs.ucla.edu>
482 * fileio.c: Fix bugs with large file offsets (Bug#9428).
483 The previous code assumed that file offsets (off_t values) fit in
484 EMACS_INT variables, which is not true on typical 32-bit hosts.
485 The code messed up by falsely reporting buffer overflow in cases
486 such as (insert-file-contents "big" nil 1 2) into an empty buffer
487 when "big" contains more than 2**29 bytes, even though this
488 inserts just one byte and does not overflow the buffer.
489 (Finsert_file_contents): Store file offsets as off_t
490 values, not as EMACS_INT values. Check for overflow when
491 converting between EMACS_INT and off_t. When checking for
492 buffer overflow or for overlap, take the offsets into account.
493 Don't use EMACS_INT for small values where int suffices.
494 When checking for overlap, fix a typo: ZV was used where
495 ZV_BYTE was intended.
496 (Fwrite_region): Don't assume off_t fits into 'long'.
497 * buffer.h (struct buffer.modtime_size): Now off_t, not EMACS_INT.
499 2011-09-05 Michael Albinus <michael.albinus@gmx.de>
501 * dbusbind.c (xd_signature_cat): Rename from signature_cat.
503 2011-09-04 Paul Eggert <eggert@cs.ucla.edu>
505 sprintf-related integer and memory overflow issues (Bug#9412).
507 * doprnt.c (doprnt): Support printing ptrdiff_t and intmax_t values.
508 (esprintf, exprintf, evxprintf): New functions.
509 * keyboard.c (command_loop_level): Now EMACS_INT, not int.
510 (cmd_error): kbd macro iterations count is now EMACS_INT, not int.
511 (modify_event_symbol): Do not assume that the length of
512 name_alist_or_stem is safe to alloca and fits in int.
513 (Fexecute_extended_command): Likewise for function name and binding.
514 (Frecursion_depth): Wrap around reliably on integer overflow.
515 * keymap.c (push_key_description): First arg is now EMACS_INT, not int,
516 since some callers pass EMACS_INT values.
517 (Fsingle_key_description): Don't crash if symbol name contains more
518 than MAX_ALLOCA bytes.
519 * minibuf.c (minibuf_level): Now EMACS_INT, not int.
520 (get_minibuffer): Arg is now EMACS_INT, not int.
521 * lisp.h (get_minibuffer, push_key_description): Reflect API changes.
522 (esprintf, exprintf, evxprintf): New decls.
523 * window.h (command_loop_level, minibuf_level): Reflect API changes.
525 * dbusbind.c (signature_cat): New function.
526 (xd_signature, Fdbus_register_signal):
527 Do not overrun buffer; instead, report string overflow.
529 * dispnew.c (add_window_display_history): Don't overrun buffer.
530 Truncate instead; this is OK since it's just a log.
532 * editfns.c (Fcurrent_time_zone): Don't overrun buffer
533 even if the time zone offset is outlandishly large.
534 Don't mishandle offset == INT_MIN.
536 * emacs.c (main) [NS_IMPL_COCOA]: Don't overrun buffer
537 when creating daemon; the previous buffer-overflow check was incorrect.
539 * eval.c (verror): Simplify by rewriting in terms of evxprintf,
540 which has the guts of the old verror function.
542 * filelock.c (lock_file_1, lock_file): Don't blindly alloca long name;
543 use SAFE_ALLOCA instead. Use esprintf to avoid int-overflow issues.
545 * font.c: Include <float.h>, for DBL_MAX_10_EXP.
546 (font_unparse_xlfd): Don't blindly alloca long strings.
547 Don't assume XINT result fits in int, or that XFLOAT_DATA * 10
548 fits in int, when using sprintf. Use single snprintf to count
549 length of string rather than counting it via multiple sprintfs;
550 that's simpler and more reliable.
551 (font_unparse_fcname): Use it to avoid sprintf buffer overrun.
552 (generate_otf_features) [0 && HAVE_LIBOTF]: Use esprintf, not
553 sprintf, in case result does not fit in int.
555 * fontset.c (num_auto_fontsets): Now printmax_t, not int.
556 (fontset_from_font): Print it.
558 * frame.c (tty_frame_count): Now printmax_t, not int.
559 (make_terminal_frame, set_term_frame_name): Print it.
560 (x_report_frame_params): In X, window IDs are unsigned long,
561 not signed long, so print them as unsigned.
562 (validate_x_resource_name): Check for implausibly long names,
563 and don't assume name length fits in 'int'.
564 (x_get_resource_string): Don't blindly alloca invocation name;
565 use SAFE_ALLOCA. Use esprintf, not sprintf, in case result does
568 * gtkutil.c: Include <float.h>, for DBL_MAX_10_EXP.
569 (xg_check_special_colors, xg_set_geometry):
570 Make sprintf buffers a bit bigger, to avoid potential buffer overrun.
572 * lread.c (dir_warning): Don't blindly alloca buffer; use SAFE_ALLOCA.
573 Use esprintf, not sprintf, in case result does not fit in int.
575 * macros.c (executing_kbd_macro_iterations): Now EMACS_INT, not int.
576 (Fend_kbd_macro): Don't mishandle MOST_NEGATIVE_FIXNUM by treating
577 it as a large positive number.
578 (Fexecute_kbd_macro): Don't assume repeat count fits in int.
579 * macros.h (executing_kbd_macro_iterations): Now EMACS_INT, not int.
581 * nsterm.m ((NSSize)windowWillResize): Use esprintf, not sprintf,
582 in case result does not fit in int.
584 * print.c (float_to_string): Detect width overflow more reliably.
585 (print_object): Make sprintf buffer a bit bigger, to avoid potential
586 buffer overrun. Don't assume list length fits in 'int'. Treat
587 print length of 0 as 0, not as infinity; to be consistent with other
588 uses of print length in this function. Don't overflow print length
589 index. Don't assume hash table size fits in 'long', or that
590 vectorlike size fits in 'unsigned long'.
592 * process.c (make_process): Use printmax_t, not int, to format
593 process-name gensyms.
595 * sysdep.c (snprintf) [! HAVE_SNPRINTF]: New function.
597 * term.c (produce_glyphless_glyph): Make sprintf buffer a bit bigger
598 to avoid potential buffer overrun.
600 * xfaces.c (x_update_menu_appearance): Don't overrun buffer
601 if X resource line is longer than 512 bytes.
603 * xfns.c (x_window): Make sprintf buffer a bit bigger
604 to avoid potential buffer overrun.
606 * xterm.c (x_io_error_quitter): Don't overrun sprintf buffer.
608 * xterm.h (x_check_errors): Add ATTRIBUTE_FORMAT_PRINTF.
610 2011-09-04 Paul Eggert <eggert@cs.ucla.edu>
612 Integer overflow fixes for scrolling, etc.
613 Without these, Emacs silently mishandles large integers sometimes.
614 For example, "C-u 4294967297 M-x recenter" was treated as if
615 it were "C-u 1 M-x recenter" on a typical 64-bit host.
617 * xdisp.c (try_window_id): Check Emacs fixnum range before
620 * window.c (window_scroll_line_based, Frecenter):
621 Check that an Emacs fixnum is in range before assigning it to 'int'.
622 (Frecenter, Fmove_to_window_line): Use EMACS_INT, not int, for
623 values converted from Emacs fixnums.
624 (Frecenter): Don't wrap around a line count if it is out of 'int'
625 range; instead, treat it as an extreme value.
626 (Fset_window_configuration, compare_window_configurations):
627 Use ptrdiff_t, not int, for index that might exceed 2 GiB.
629 * search.c (Freplace_match): Use ptrdiff_t, not int, for indexes
630 that can exceed INT_MAX. Check that EMACS_INT value is in range
631 before assigning it to the (possibly-narrower) index.
632 (match_limit): Don't assume that a fixnum can fit in 'int'.
634 * print.c (print_object): Use ptrdiff_t, not int, for index that can
637 * indent.c (position_indentation): Now takes ptrdiff_t, not int.
638 (Fvertical_motion): Don't wrap around LINES values that don't fit
639 in 'int'. Instead, treat them as extreme values. This is good
640 enough for windows, which can't have more than INT_MAX lines anyway.
642 2011-09-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
644 * Require libxml/parser.h to avoid compilation warning.
646 * emacs.c (shut_down_emacs): Call xmlCleanupParser on shutdown.
648 * xml.c (parse_region): Don't call xmlCleanupParser after parsing,
649 since this reportedly can destroy thread storage.
651 2011-08-30 Chong Yidong <cyd@stupidchicken.com>
653 * syntax.c (find_defun_start): Update all cache variables if
654 exiting early (Bug#9401).
656 2011-08-30 Eli Zaretskii <eliz@gnu.org>
658 * image.c (x_bitmap_pixmap): Cast to int to avoid compiler warnings.
660 * xdisp.c (produce_stretch_glyph): No longer static, compiled also
661 when HAVE_WINDOW_SYSTEM is not defined. Support both GUI and TTY
662 frames. Call tty_append_glyph in the TTY case. (Bug#9402)
664 * term.c (tty_append_glyph): New function.
665 (produce_stretch_glyph): Static function and its prototype deleted.
667 * dispextern.h (produce_stretch_glyph, tty_append_glyph):
670 2011-08-29 Paul Eggert <eggert@cs.ucla.edu>
672 * image.c (parse_image_spec): Check for nonnegative, not for positive,
673 when checking :margin (Bug#9390).
674 (IMAGE_NON_NEGATIVE_INTEGER_VALUE_OR_PAIR):
675 Rename from IMAGE_POSITIVE_INTEGER_VALUE_OR_PAIR,
676 so that the name doesn't mislead. All uses changed.
678 2011-08-28 Johan Bockgård <bojohan@gnu.org>
680 * term.c (init_tty) [HAVE_GPM]: Move mouse settings after
683 2011-08-27 Eli Zaretskii <eliz@gnu.org>
685 * xdisp.c (move_it_to): Don't bail out early when reaching
686 position beyond to_charpos, if we are scanning backwards.
687 (move_it_vertically_backward): When DY == 0, make sure we get to
688 the first character in the line after the newline.
690 2011-08-27 Paul Eggert <eggert@cs.ucla.edu>
692 * ccl.c: Improve and simplify overflow checking (Bug#9196).
693 (ccl_driver): Do not generate an out-of-range pointer.
694 (Fccl_execute_on_string): Remove unnecessary check for
695 integer overflow, noted by Stefan Monnier in
696 <http://lists.gnu.org/archive/html/emacs-devel/2011-08/msg00979.html>.
697 Remove a FIXME that didn't need fixing.
698 Simplify the newly-introduced buffer reallocation code.
700 2011-08-27 Juanma Barranquero <lekktu@gmail.com>
702 * makefile.w32-in ($(BLD)/alloc.$(O)): Depend on lib/verify.h.
704 2011-08-26 Paul Eggert <eggert@cs.ucla.edu>
706 Integer and memory overflow issues (Bug#9196).
708 * doc.c (get_doc_string): Rework so that
709 get_doc_string_buffer_size is the actual buffer size, rather than
710 being 1 less than the actual buffer size; this makes xpalloc more
713 * image.c (x_allocate_bitmap_record, cache_image):
714 * xselect.c (Fx_register_dnd_atom):
715 Simplify previous changes by using xpalloc.
717 * buffer.c (overlay_str_len): Now ptrdiff_t, not EMACS_INT,
718 since either will do and ptrdiff_t is convenient with xpalloc.
720 * charset.c (charset_table_size)
721 (struct charset_sort_data.priority): Now ptrdiff_t.
722 (charset_compare): Don't overflow if priorities differ greatly.
723 (Fsort_charsets): Don't assume list length fits in int.
724 Check for size-calculation overflow when allocating sort data.
725 (syms_of_charset): Allocate an initial charset table that is
726 just under 64 KiB, to avoid problems with glibc malloc and mmap.
728 * cmds.c (internal_self_insert): Check for size-calculation overflow.
730 * composite.h (struct composition.glyph_len): Now int, not unsigned.
731 The actual value is always <= INT_MAX, and leaving it unsigned made
732 overflow checking harder.
734 * dispextern.h (struct glyph_matrix.rows_allocated)
735 (struct face_cache.size): Now ptrdiff_t, for convenience in use
736 with xpalloc. The values are still always <= INT_MAX.
738 * indent.c (compute_motion): Adjust to region_cache_forward sig change.
740 * lisp.h (xnmalloc, xnrealloc, xpalloc): New decls.
741 (SAFE_NALLOCA): New macro.
743 * region-cache.c (struct boundary.pos, find_cache_boundary)
744 (move_cache_gap, insert_cache_boundary, delete_cache_boundaries)
745 (set_cache_region, invalidate_region_cache)
746 (revalidate_region_cache, know_region_cache, region_cache_forward)
747 (region_cache_backward, pp_cache):
748 Use ptrdiff_t, not EMACS_INT, since either will do. This is needed
749 so that ptrdiff_t * can be passed to xpalloc.
750 (struct region_cache): Similarly, for gap_start, gap_len, cache_len,
751 beg_unchanged, end_unchanged, buffer_beg, buffer_end members.
752 (pp_cache): Don't assume cache_len fits in int.
753 * region-cache.h: Adjust extern decls to match.
755 * search.c (scan_buffer, Freplace_match): Use ptrdiff_t, not
756 EMACS_INT, since either will do, for xpalloc.
758 * alloc.c: Include verify.h, and check that int fits in ptrdiff_t.
759 (xnmalloc, xnrealloc, xpalloc): New functions.
761 * bidi.c (bidi_shelve_header_size): New constant.
762 (bidi_cache_ensure_space, bidi_shelve_cache): Use it.
763 (bidi_cache_ensure_space): Avoid integer overflow when allocating.
765 * bidi.c (bidi_cache_shrink):
766 * buffer.c (overlays_at, overlays_in, record_overlay_string)
768 Don't update size of array until after memory allocation succeeds,
769 because xmalloc/xrealloc may not return.
770 (struct sortstrlist.bytes): Now ptrdiff_t, as EMACS_INT doesn't help
771 now that we have proper integer overflow checking.
772 (record_overlay_string, overlay_strings): Catch overflows when
773 calculating size of overlay_str_buf.
775 * callproc.c (Fcall_process): Check for size overflow when
776 calculating size of args2.
777 (child_setup): Avoid overflow by using size_t rather than ptrdiff_t.
778 Normally we prefer signed values, but sticking with ptrdiff_t would
779 require adding more-complicated checks.
781 * ccl.c (Fccl_execute_on_string): Check for memory overflow.
782 Use ptrdiff_t rather than EMACS_INT where ptrdiff_t will do.
783 Redo buffer-overflow calculations to avoid integer overflow.
784 Add a FIXME comment where memory seems to be over-allocated.
786 * character.c (Fstring): Check for size-calculation overflow.
788 * coding.c (produce_chars): Redo buffer-overflow calculations to avoid
789 unnecessary integer overflow. Check for size overflow.
790 (encode_coding_object): Don't update size until xmalloc succeeds.
792 * composite.c (get_composition_id): Check for overflow in glyph
795 Integer and memory overflow fixes for display code.
796 * dispextern.h (struct glyph_pool.nglyphs): Now ptrdiff_t, not int.
797 * dispnew.c (adjust_glyph_matrix, realloc_glyph_pool)
798 (scrolling_window): Check for overflow in size calculations.
799 (line_draw_cost, realloc_glyph_pool, add_row_entry):
800 Don't assume glyph table len fits in int.
801 (struct row_entry.bucket, row_entry_pool_size, row_entry_idx)
802 (row_table_size): Now ptrdiff_t, not int.
803 (scrolling_window): Avoid overflow in size calculations.
804 Don't update size until allocation succeeds.
805 * fns.c (concat): Check for overflow in size calculations.
806 (next_almost_prime): Verify NEXT_ALMOST_PRIME_LIMIT.
807 * lisp.h (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): New macros.
808 (NEXT_ALMOST_PRIME_LIMIT): New constant.
810 * doc.c (get_doc_string_buffer_size): Now ptrdiff_t, not int.
811 (get_doc_string): Check for size calculation overflow.
812 Don't update size until allocation succeeds.
813 (get_doc_string, Fsubstitute_command_keys): Use ptrdiff_t, not
814 EMACS_INT, where ptrdiff_t will do.
815 (Fsubstitute_command_keys): Check for string overflow.
817 * editfns.c (set_time_zone_rule): Don't assume environment length
819 (message_length): Now ptrdiff_t, not int.
820 (Fmessage_box): Don't update size until allocation succeeds.
821 Don't assume message length fits in int.
822 (Fformat): Use ptrdiff_t, not EMACS_INT, where ptrdiff_t will do.
824 * emacs.c (main): Do not reallocate argv, since there is a null at
825 the end that can be overwritten, and this way there's no need to
826 worry about size-calculation overflow.
827 (sort_args): Check for size-calculation overflow.
829 * eval.c (init_eval_once, grow_specpdl): Don't update size until
831 (call_debugger, grow_specpdl): Redo calculations to avoid overflow.
833 * frame.c (set_menu_bar_lines, x_set_frame_parameters)
834 (x_set_scroll_bar_width, x_figure_window_size):
835 Check for integer overflow.
836 (x_set_alpha): Do not assume XINT fits in int.
838 * frame.h (struct frame): Use int, not EMACS_INT, where int works.
839 This is for the members text_lines, text_cols, total_lines, total_cols,
840 where the system imposes an 'int' limit.
842 * fringe.c (Fdefine_fringe_bitmap):
843 Don't update size until alloc works.
845 * ftfont.c (ftfont_get_open_type_spec, setup_otf_gstring)
846 (ftfont_shape_by_flt): Check for integer overflow in size calculations.
848 * gtkutil.c (get_utf8_string, xg_store_widget_in_map):
849 Check for size-calculation overflow.
850 (get_utf8_string): Use ptrdiff_t, not size_t, where either will
851 do, as we prefer signed integers.
852 (id_to_widget.max_size, id_to_widget.used)
853 (xg_store_widget_in_map, xg_remove_widget_from_map)
854 (xg_get_widget_from_map, xg_get_scroll_id_for_window)
855 (xg_remove_scroll_bar, xg_update_scrollbar_pos):
856 Use and return ptrdiff_t, not int.
857 (xg_gtk_scroll_destroy): Don't assume ptrdiff_t fits in int.
858 * gtkutil.h: Change prototypes to match the above.
860 * image.c (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): Remove; these
861 are duplicate now that they've been promoted to lisp.h.
862 (x_allocate_bitmap_record, x_alloc_image_color)
863 (make_image_cache, cache_image, xpm_load):
864 Don't update size until alloc is done.
865 (xpm_load, lookup_rgb_color, lookup_pixel_color, x_to_xcolors)
867 Check for size calculation overflow.
868 (ct_colors_allocated_max): New constant.
869 (x_to_xcolors, x_detect_edges): Reorder multiplicands to avoid
872 * keyboard.c (read_char, menu_bar_items, tool_bar_items)
873 (read_char_x_menu_prompt, read_char_minibuf_menu_width)
874 (read_char_minibuf_menu_prompt, follow_key, read_key_sequence):
875 Use ptrdiff_t, not int, to count maps.
876 (read_char_minibuf_menu_prompt): Check for overflow in size
877 calculations. Don't update size until allocation succeeds.
878 Redo calculations to avoid overflow.
879 * keyboard.h: Change prototypes to match the above.
881 * keymap.c (cmm_size, current_minor_maps): Use ptrdiff_t, not int,
883 (current_minor_maps): Check for size calculation overflow.
884 * keymap.h: Change prototypes to match the above.
886 * lread.c (read1, init_obarray): Don't update size until alloc done.
888 * macros.c (Fstart_kbd_macro): Don't update size until alloc done.
889 (store_kbd_macro_char): Reorder multiplicands to avoid overflow.
891 * nsterm.h (struct ns_color_table.size, struct ns_color_table.avail):
892 Now ptrdiff_t, not int.
893 * nsterm.m (ns_index_color): Use ptrdiff_t, not int, for table indexes.
894 (ns_draw_fringe_bitmap): Rewrite to avoid overflow.
896 * process.c (Fnetwork_interface_list): Check for overflow
899 * region-cache.c (move_cache_gap): Check for size calculation overflow.
901 * scroll.c (do_line_insertion_deletion_costs): Check for size calc
902 overflow. Don't bother calling xmalloc when xrealloc will do.
904 * search.c (Freplace_match): Check for size calculation overflow.
905 (Fset_match_data): Don't assume list lengths fit in 'int'.
907 * sysdep.c (system_process_attributes): Use ptrdiff_t, not int,
908 for command line length. Do not attempt to address one before the
909 beginning of an array, as that's not portable.
911 * term.c (max_frame_lines): Remove; unused.
912 (encode_terminal_src_size, encode_terminal_dst_size): Now ptrdiff_t,
914 (encode_terminal_code, calculate_costs): Check for size
915 calculation overflow.
916 (encode_terminal_code): Use ptrdiff_t, not int, to record glyph
917 table lengths and related sizes. Don't update size until alloc
918 done. Redo calculations to avoid overflow.
919 (calculate_costs): Don't bother calling xmalloc when xrealloc will do.
921 * termcap.c (tgetent): Use ptrdiff_t, not int, to record results of
922 subtracting pointers.
923 (gobble_line): Check for overflow more carefully. Don't update size
926 * tparam.c (tparam1): Use ptrdiff_t, not int, for sizes.
927 Don't update size until alloc done.
928 Redo size calculations to avoid overflow.
929 Check for size calculation overflow.
930 (main) [DEBUG]: Fix typo in invoking tparam1.
932 * xdisp.c (store_mode_line_noprop_char, x_consider_frame_title):
933 Use ptrdiff_t, not int, for sizes.
934 (store_mode_line_noprop_char): Don't update size until alloc done.
936 * xfaces.c (lface_id_to_name_size, Finternal_make_lisp_face):
937 Use ptrdiff_t, not int, for sizes.
938 (Finternal_make_lisp_face, cache_face):
939 Check for size calculation overflow.
940 (cache_face): Treat size calculation overflows as if they were
941 memory exhaustion (the usual treatment), rather than aborting.
943 * xfns.c (x_encode_text, x_set_name_internal)
944 (Fx_change_window_property): Use ptrdiff_t, not int, to count
945 sizes, since they can exceed INT_MAX in size. Check for size
946 calculation overflow.
948 * xgselect.c (gfds_size): Now ptrdiff_t, for convenience with xpalloc.
949 (xg_select): Check for size calculation overflow.
950 Don't update size until alloc done.
952 * xrdb.c (get_environ_db): Don't assume path length fits in int,
953 as sprintf is limited to int lengths.
955 * xselect.c (X_LONG_SIZE, X_SHRT_MAX, X_SHRT_MIN, X_LONG_MAX)
956 (X_LONG_MIN): New macros.
957 Use them to make the following changes clearer.
958 (MAX_SELECTION_QUANTUM): Make the other bounds on this value clearer.
959 This change doesn't affect the value now, but it may help remind
960 future maintainers not to raise the value too much later.
961 (SELECTION_QUANTUM): Remove, replacing with ...
962 (selection_quantum): ... new function, which avoids overflow.
964 (struct selection_data.size): Now ptrdiff_t, not int, to avoid
965 assumption that selection length fits in 'int'.
966 (x_reply_selection_request, x_handle_selection_request)
967 (x_get_window_property, receive_incremental_selection)
968 (x_get_window_property_as_lisp_data, selection_data_to_lisp_data)
969 (lisp_data_to_selection_data, clean_local_selection_data):
970 Use ptrdiff_t, not int, to record length of selection.
971 (x_reply_selection_request, x_get_window_property)
972 (receive_incremental_selection, x_property_data_to_lisp):
973 Redo calculations to avoid overflow.
974 (x_reply_selection_request): When sending hint, ceiling it at
975 X_LONG_MAX rather than relying on wraparound overflow to send
977 (x_get_window_property, receive_incremental_selection)
978 (lisp_data_to_selection_data, x_property_data_to_lisp):
979 Check for size-calculation overflow.
980 (x_get_window_property, receive_incremental_selection)
981 (lisp_data_to_selection_data, Fx_register_dnd_atom):
982 Don't store size until memory allocation succeeds.
983 (x_get_window_property): Plug memory leak on memory exhaustion.
984 Don't double-block input; malloc is safe here. Don't assume 2**34
985 - 4 fits in unsigned long. Add an xassert to check
986 XGetWindowProperty overflow. Be more careful about overflow
987 calculations, and distinguish size from memory overflow better.
988 (receive_incremental_selection): When tracing, don't assume
989 unsigned int is less than INT_MAX.
990 (x_selection_data_to_lisp_data): Remove unnecessary (and in theory
991 harmful) conversions of unsigned short to int.
992 (lisp_data_to_selection_data): Don't assume that integers
993 in the range -65535 through -1 fit in an X unsigned short.
994 Don't assume that ULONG_MAX == X_ULONG_MAX. Don't store into
995 result parameters unless successful. Rely on cons_to_unsigned
996 to report problems with elements; the old code wasn't right anyway.
997 (x_check_property_data): Check for int overflow; we cannot use
998 a wider type due to X limits.
999 (x_handle_dnd_message): Use unsigned int, to avoid int overflow.
1001 * xsmfns.c (smc_save_yourself_CB): Check for size calc overflow.
1003 * xterm.c (x_color_cells, x_send_scrollbar_event, handle_one_xevent)
1004 (x_term_init): Check for size calculation overflow.
1005 (x_color_cells): Don't store size until memory allocation succeeds.
1006 (handle_one_xevent): Use ptrdiff_t, not int, for byte counts.
1007 Don't assume alloca size is less than MAX_ALLOCA.
1008 (x_term_init): Don't assume length fits in int (sprintf is limited
1011 Use ptrdiff_t for composition IDs.
1012 * character.c (lisp_string_width):
1013 * composite.c (composition_table_size, n_compositions)
1014 (get_composition_id, composition_gstring_from_id):
1015 * dispextern.h (struct glyph_string.cmp_id, struct composition_it.id):
1016 * xdisp.c (BUILD_COMPOSITE_GLYPH_STRING):
1017 * window.c (Frecenter):
1018 Use ptrdiff_t, not int, for composition IDs.
1019 * composite.c (get_composition_id): Check for integer overflow.
1020 * composite.h: Adjust prototypes to match the above changes.
1022 Use ptrdiff_t for hash table indexes.
1023 * category.c (hash_get_category_set):
1024 * ccl.c (ccl_driver):
1025 * charset.h (struct charset.hash_index, CHECK_CHARSET_GET_ID):
1026 * coding.c (coding_system_charset_list, detect_coding_system):
1027 * coding.h (struct coding_system.id):
1028 * composite.c (get_composition_id, gstring_lookup_cache):
1029 * fns.c (hash_lookup, hash_put, Fgethash, Fputhash):
1030 * image.c (xpm_get_color_table_h):
1031 * lisp.h (hash_lookup, hash_put):
1032 * minibuf.c (Ftest_completion):
1033 Use ptrdiff_t for hash table indexes, not int (which is too
1034 narrow, on 64-bit hosts) or EMACS_INT (which is too wide, on
1035 32-bit --with-wide-int hosts).
1037 * charset.c (Fdefine_charset_internal): Check for integer overflow.
1038 Add a FIXME comment about memory leaks.
1039 (syms_of_charset): Don't assume xmalloc returns.
1041 Don't assume that stated character widths fit in int.
1042 * character.c (Fchar_width, c_string_width, lisp_string_width):
1043 * character.h (CHAR_WIDTH):
1044 * indent.c (MULTIBYTE_BYTES_WIDTH):
1045 Use sanitize_char_width to avoid undefined and/or bad behavior
1046 with outlandish widths.
1047 * character.h (sanitize_tab_width): Rename from sanitize_width,
1048 now that we have two such functions. All uses changed.
1049 (sanitize_char_width): New inline function.
1051 Don't assume that tab-width fits in int.
1052 * character.h (sanitize_width): New inline function.
1053 (SANE_TAB_WIDTH): New macro.
1054 (ASCII_CHAR_WIDTH): Use it.
1055 * indent.c (sane_tab_width): Remove. All uses replaced by
1056 SANE_TAB_WIDTH (current_buffer).
1057 * xdisp.c (init_iterator): Use SANE_TAB_WIDTH.
1059 * fileio.c: Integer overflow issues with file modes.
1060 (Fset_file_modes, auto_save_1): Don't assume EMACS_INT fits in int.
1062 * charset.c (read_hex): New arg OVERFLOW. All uses changed.
1063 Remove unreachable code.
1064 (read_hex, load_charset_map_from_file): Check for integer overflow.
1066 * xterm.c: don't go over XClientMessageEvent limit
1067 (scroll_bar_windows_size): Now ptrdiff_t, as we prefer signed.
1068 (x_send_scroll_bar_event): Likewise. Check that the size does not
1069 exceed limits imposed by XClientMessageEvent, as well as the usual
1070 ptrdiff_t and size_t limits.
1072 * keyboard.c: Overflow, signedness and related fixes.
1073 (make_lispy_movement): Use same integer type in forward decl
1074 that is used in the definition.
1075 (read_key_sequence, keyremap_step):
1076 Change bufsize argument back to int, undoing my 2011-03-30 change.
1077 We prefer signed types, and int is wide enough here.
1078 (parse_tool_bar_item): Don't assume tool_bar_max_label_size is less
1079 than TYPE_MAXIMUM (EMACS_INT) / 2. Don't let the label size grow
1080 larger than STRING_BYTES_BOUND. Use ptrdiff_t for Emacs string
1081 length, not size_t. Use ptrdiff_t for index, not int.
1082 (keyremap_step, read_key_sequence): Redo bufsize check to avoid
1083 possibility of integer overflow.
1085 Overflow, signedness and related fixes for images.
1087 * dispextern.h (struct it.stack[0].u.image.image_id)
1088 (struct_it.image_id, struct image.id, struct image_cache.size)
1089 (struct image_cache.used, struct image_cache.ref_count):
1090 * gtkutil.c (update_frame_tool_bar):
1091 * image.c (x_reference_bitmap, Fimage_size, Fimage_mask_p)
1092 (Fimage_metadata, free_image_cache, clear_image_cache, lookup_image)
1093 (cache_image, mark_image_cache, x_kill_gs_process, Flookup_image):
1094 * nsmenu.m (update_frame_tool_bar):
1095 * xdisp.c (calc_pixel_width_or_height):
1096 * xfns.c (image_cache_refcount):
1097 Image IDs are now ptrdiff_t, not int, to avoid arbitrary limits
1098 on typical 64-bit hosts.
1100 * image.c (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): New macros.
1101 (x_bitmap_pixmap, x_create_x_image_and_pixmap):
1102 Omit unnecessary casts to int.
1103 (parse_image_spec): Check that integers fall into 'int' range
1104 when the callers expect that.
1105 (image_ascent): Redo ascent calculation to avoid int overflow.
1106 (clear_image_cache): Avoid overflow when sqrt (INT_MAX) < nimages.
1107 (lookup_image): Remove unnecessary tests.
1108 (xbm_image_p): Locals are now of int, not EMACS_INT,
1109 since parse_image_check makes sure they fit into int.
1110 (png_load, gif_load, svg_load_image):
1111 Prefer int to unsigned where either will do.
1112 (tiff_handler): New function, combining the cores of the
1113 old tiff_error_handler and tiff_warning_handler.
1114 This function is rewritten to use vsnprintf and thereby avoid
1115 stack buffer overflows. It uses only the features of vsnprintf
1116 that are common to both POSIX and native Microsoft.
1117 (tiff_error_handler, tiff_warning_handler): Use it.
1118 (tiff_load, gif_load, imagemagick_load_image):
1119 Don't assume :index value fits in 'int'.
1120 (gif_load): Omit unnecessary cast to double, and avoid double-rounding.
1121 (imagemagick_load_image): Check that crop parameters fit into
1122 the integer types that MagickCropImage accepts. Don't assume
1123 Vimagemagick_render_type has a nonnegative value. Don't assume
1124 size_t fits in 'long'.
1125 (gs_load): Use printmax_t to print the widest integers possible.
1126 Check for integer overflow when computing image height and width.
1128 2011-08-26 Eli Zaretskii <eliz@gnu.org>
1130 * xdisp.c (redisplay_window): Don't force window start if point
1131 will be invisible in the resulting window. (Bug#9324)
1133 2011-08-25 Eli Zaretskii <eliz@gnu.org>
1135 * xdisp.c (compute_display_string_pos): Return 2 in DISP_PROP when
1136 the display spec is of the form `(space ...)'.
1137 (handle_display_spec): Return the value returned by
1138 handle_single_display_spec, not just 1 or zero.
1139 (handle_single_display_spec): If the display spec is of the form
1140 `(space ...)', and specifies display in the text area, return 2
1142 (try_cursor_movement): Check for the need to scroll more
1143 accurately, and prefer exact match for point under bidi.
1144 Don't advance `row' beyond the last row of the window.
1146 * dispextern.h (struct bidi_it): Rename the disp_prop_p member
1147 into disp_prop; all users changed.
1149 * bidi.c (bidi_fetch_char): If compute_display_string_pos returns
1150 DISP_PROP = 2, substitute the u+2029 PARAGRAPH SEPARATOR character
1151 for the text covered by the display property.
1153 2011-08-25 Chong Yidong <cyd@stupidchicken.com>
1155 * buffer.c (Fbury_buffer_internal): Rename from Funrecord_buffer.
1156 Change return value to nil.
1157 (Frecord_buffer): Delete unused function.
1159 2011-08-24 Eli Zaretskii <eliz@gnu.org>
1161 * xdisp.c (Fcurrent_bidi_paragraph_direction): For unibyte
1162 buffers, return left-to-right.
1163 (set_cursor_from_row): Consider candidate row a win if its glyph
1164 represents a newline and point is on that newline. Fixes cursor
1165 positioning on the newline at EOL of R2L text within L2R
1166 paragraph, and vice versa.
1167 (try_cursor_movement): Check continued rows, in addition to
1168 continuation rows. Fixes unwarranted scroll when point enters a
1169 continued line of R2L text within an L2R paragraph, or vice versa.
1170 (cursor_row_p): Consider the case of point being equal to
1171 MATRIX_ROW_END_CHARPOS. Prevents cursor being stuck when moving
1172 from the end of a short line to the beginning of a continued line
1173 of R2L text within L2R paragraph.
1174 (RECORD_MAX_MIN_POS): For max_pos, use IT_CHARPOS even for
1175 composed characters.
1177 * bidi.c (bidi_check_type): Use xassert.
1178 (bidi_cache_iterator_state): Update the disp_pos and disp_prop_p
1181 2011-08-23 Eli Zaretskii <eliz@gnu.org>
1183 * bidi.c (bidi_get_type): Abort if we get zero as the bidi type of
1186 2011-08-23 Chong Yidong <cyd@stupidchicken.com>
1188 * nsfont.m (ns_otf_to_script): Fix typo.
1190 2011-08-22 Kenichi Handa <handa@m17n.org>
1192 * chartab.c (Fset_char_table_extra_slot): Do not inhibit setting a
1193 extra slot even if the purpose is char-code-property-table.
1195 2011-08-23 Eli Zaretskii <eliz@gnu.org>
1197 * xdisp.c (redisplay_window): When computing centering_position,
1198 account for the height of the header line. (Bug#8874)
1200 * dispnew.c (buffer_posn_from_coords): Use buf_charpos_to_bytepos
1201 instead of CHAR_TO_BYTE. Fixes a crash when a completion
1202 candidate is selected by the mouse, and that candidate has a
1203 composed character under the mouse.
1205 * xdisp.c (x_produce_glyphs): Set it->nglyphs to 1. Fixes pixel
1206 coordinates reported by pos-visible-in-window-p for a composed
1207 character in column zero.
1209 2011-08-23 Stefan Monnier <monnier@iro.umontreal.ca>
1211 * cmds.c (Fself_insert_command): Mention post-self-insert-hook.
1213 2011-08-22 Eli Zaretskii <eliz@gnu.org>
1215 * xdisp.c (BUFFER_POS_REACHED_P): If this is a composition,
1216 consider it a hit if to_charpos is anywhere in the range of the
1217 composed buffer positions.
1219 2011-08-22 Chong Yidong <cyd@stupidchicken.com>
1221 * image.c (gif_load): Don't assume that each subimage has the same
1222 dimensions as the base image. Handle disposal method that is
1223 "undefined" by the gif spec (Bug#9335).
1225 2011-08-20 Chong Yidong <cyd@stupidchicken.com>
1227 * eval.c (Fsignal): Handle `debug' symbol in error handler (Bug#9329).
1228 (Fcondition_case): Document `debug' symbol in error handler.
1230 2011-08-19 Eli Zaretskii <eliz@gnu.org>
1232 * xfaces.c (face_at_buffer_position): Avoid repeated evaluation of
1233 face ID by FACE_FROM_ID, and avoid a crash when mouse is moved
1234 from an Org mode buffer to a Speedbar frame.
1236 * xdisp.c (RECORD_MAX_MIN_POS): If the display element comes from
1237 a composition, take its buffer position from IT->cmp_it.charpos.
1238 Fixes cursor positioning at the beginning of a line that begins
1239 with a composed character.
1241 2011-08-18 Eli Zaretskii <eliz@gnu.org>
1243 * bidi.c (bidi_get_type): If bidi_type_table reports zero as the
1244 character bidirectional type, use STRONG_L instead. Fixes crashes
1245 in a buffer produced by `describe-categories'.
1247 * dispextern.h (struct bidi_it): Move disp_pos and disp_prop_p
1248 members before the level stack, so they would be saved and
1249 restored when copying iterator state. Fixes incorrect reordering
1250 around TABs covered by display properties.
1252 2011-08-18 Andreas Schwab <schwab@linux-m68k.org>
1254 * process.c (Fnetwork_interface_list): Correctly determine buffer
1257 2011-08-17 Chong Yidong <cyd@stupidchicken.com>
1259 * eval.c (internal_condition_case, internal_condition_case_1)
1260 (internal_condition_case_2, internal_condition_case_n):
1261 Remove unnecessary aborts (Bug#9081).
1263 2011-08-17 Eli Zaretskii <eliz@gnu.org>
1265 * lread.c (Fload) [DOS_NT]: If `openp' returns -2, but the file
1266 has no `load' handler, try opening the file locally. (Bug#9311)
1268 2011-08-16 Ken Brown <kbrown@cornell.edu>
1270 * gmalloc.c: Expand comment.
1272 2011-08-16 Eli Zaretskii <eliz@gnu.org>
1274 * xdisp.c (set_cursor_from_row): Don't accept a previous candidate
1275 if it fails the cursor_row_p test. Fixes cursor positioning at ZV.
1277 2011-08-16 Ken Brown <kbrown@cornell.edu>
1279 Fix memory allocation problems in Cygwin build (Bug#9273).
1281 * unexcw.c ( __malloc_initialized): Declare external variable.
1282 (fixup_executable): Force the dumped emacs to reinitialize malloc.
1284 * gmalloc.c [CYGWIN] (bss_sbrk_heapbase, bss_sbrk_heapinfo):
1286 (malloc_initialize_1) [CYGWIN]: Prepare for reinitializing the
1288 (_free_internal_nolock) [CYGWIN]: Ignore requests to free storage
1290 [CYGWIN] (special_realloc): New function.
1291 (_realloc_internal_nolock) [CYGWIN]: Use the new function on
1292 requests to realloc storage in the static heap.
1294 2011-08-15 Paul Eggert <eggert@cs.ucla.edu>
1296 * bidi.c (bidi_initialize): Remove unused local.
1298 2011-08-15 Eli Zaretskii <eliz@gnu.org>
1300 * biditype.h: File removed.
1302 * bidimirror.h: File removed.
1304 * deps.mk (bidi.o): Remove biditype.h and
1307 * makefile.w32-in ($(BLD)/bidi.$(O)): Remove biditype.h and
1310 * dispextern.h: Fix a typo in the comment to bidi_type_t.
1312 * chartab.c: Improve commentary for the uniprop_table API.
1314 * bidi.c (bidi_paragraph_init): Support zero value of
1315 bidi_ignore_explicit_marks_for_paragraph_level.
1316 (bidi_initialize): Use uniprop_table instead of including
1317 biditype.h and bidimirror.h.
1319 * xdisp.c (move_it_in_display_line_to): Don't reset pixel
1320 coordinates of the iterator when restoring from ppos_it.
1323 2011-08-14 Kenichi Handa <handa@m17n.org>
1325 * process.c (create_process): Call setup_process_coding_systems
1326 after the pid of the process is set to -1 (Bug#8162).
1328 2011-08-14 Eli Zaretskii <eliz@gnu.org>
1330 * xdisp.c (move_it_in_display_line_to): Don't invoke
1331 IT_RESET_X_ASCENT_DESCENT when iterator position was restored from
1332 ppos_it. Fixes vertical cursor motion when line beginning is
1333 covered by an image. (Bug#9296)
1335 2011-08-14 Jan Djärv <jan.h.d@swipnet.se>
1337 * nsterm.h (ns_run_ascript): Declare.
1338 (NSAPP_DATA2_RUNASSCRIPT): Define.
1340 * nsfns.m (as_script, as_result, as_status): New static variables.
1341 (ns_run_ascript): New function.
1342 (Fns_do_applescript): Set variables as_*. Make an NSApplicationDefined
1343 event with data2 set to NSAPP_DATA2_RUNASSCRIPT, post it and then start
1344 the event loop. Get status from as_status (Bug#7276).
1346 * nsterm.m (sendEvent): If event is NSApplicationDefined and
1347 data2 is NSAPP_DATA2_RUNASSCRIPT, call ns_run_ascript and then exit
1348 the event loop (Bug#7276).
1350 2011-08-14 Andreas Schwab <schwab@linux-m68k.org>
1352 * gnutls.c (QCgnutls_bootprop_priority)
1353 (QCgnutls_bootprop_trustfiles, QCgnutls_bootprop_keylist)
1354 (QCgnutls_bootprop_crlfiles, QCgnutls_bootprop_callbacks)
1355 (QCgnutls_bootprop_loglevel, QCgnutls_bootprop_hostname)
1356 (QCgnutls_bootprop_min_prime_bits, QCgnutls_bootprop_verify_flags)
1357 (QCgnutls_bootprop_verify_hostname_error)
1358 (QCgnutls_bootprop_callbacks_verify): Rename from
1359 Qgnutls_bootprop_..., all uses changed.
1361 * xfaces.c (QCignore_defface): Rename from Qignore_defface, all
1364 2011-08-14 Paul Eggert <eggert@cs.ucla.edu>
1366 * xfaces.c (Qframe_set_background_mode): Now static.
1367 * dispextern.h (Qframe_set_background_mode): Remove decl.
1369 * process.c (Fnetwork_interface_info): Declare local only if needed.
1371 2011-08-13 Jan Djärv <jan.h.d@swipnet.se>
1373 * process.c: Include ifaddrs.h and net/if_dl.h if available (Bug#8477).
1374 (Fnetwork_interface_list): Allocate in increments of bytes instead
1375 of sizeof (struct ifreq). Iterate over ifconf.ifc_req by counting
1376 bytes (Bug#8477). Count bytes correctly when ifr_addr is a struct
1378 (struct ifflag_def): notrailers is smart on OSX.
1379 (Fnetwork_interface_info): Handle case when ifr_flags is negative.
1380 Get hardware address with getifaddrs if available.
1382 2011-08-12 Eli Zaretskii <eliz@gnu.org>
1384 * xdisp.c (iterate_out_of_display_property): xassert that
1385 IT->position is set to within IT->object's boundaries. Break from
1386 the loop as soon as EOB is reached; avoids infloops in redisplay
1387 when IT->position is set up wrongly due to some bug.
1388 Set IT->current to match the bidi iterator unconditionally.
1389 (push_display_prop): Allow GET_FROM_STRING as IT->method on
1390 entry. Force push_it to save on the stack the current
1391 buffer/string position, to be restored by pop_it. Fix flags in
1392 the iterator structure wrt the object coming from a display
1393 property, as `line-prefix' and `wrap-prefix' are not ``replacing''
1394 properties. (Bug#9284)
1396 2011-08-09 Andreas Schwab <schwab@linux-m68k.org>
1398 * fontset.c (fontset_get_font_group): Add proper type checks.
1401 2011-08-09 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
1403 * unexmacosx.c (print_load_command_name): Add cases LC_FUNCTION_STARTS
1404 and LC_VERSION_MIN_MACOSX.
1405 (copy_linkedit_data) [LC_FUNCTION_STARTS]: New function.
1406 (dump_it) [LC_FUNCTION_STARTS]: Use it.
1408 2011-08-08 Eli Zaretskii <eliz@gnu.org>
1410 * xdisp.c (forward_to_next_line_start): Allow to use the
1411 no-display-properties-and-no-overlays under bidi display.
1412 Set disp_pos in the bidi iterator to avoid searches for display
1413 properties and overlays.
1415 2011-08-08 Chong Yidong <cyd@stupidchicken.com>
1417 * editfns.c (Fset_time_zone_rule): Document relationship with the
1420 * ftfont.c (ftfont_pattern_entity): Copy the extras argument to
1421 the font entity extracted from the cache (Bug#8109).
1423 2011-08-07 Chong Yidong <cyd@stupidchicken.com>
1425 * composite.c (autocmp_chars): Don't reset point. That is done by
1426 restore_point_unwind (Bug#5984).
1428 2011-08-07 Juri Linkov <juri@jurta.org>
1430 * editfns.c (Fformat_time_string): Doc fix, add tag `usage:'
1431 to show the arg `TIME' instead of `TIMEVAL'.
1433 2011-08-06 Eli Zaretskii <eliz@gnu.org>
1435 * xdisp.c (set_cursor_from_row): Fix cursor positioning when a
1436 display property strides EOL and includes a newline, as in
1437 longlines-mode. (Bug#9254)
1438 (move_it_in_display_line_to): Fix vertical-motion in a buffer with
1439 word-wrap under bidirectional display. (Bug#9224)
1441 * bidi.c (bidi_unshelve_cache): Don't reset the cache if JUST_FREE
1442 is non-zero, even if the data buffer is NULL. Fixes a crash in
1443 vertical-motion with longlines-mode. (Bug#9254)
1445 2011-08-05 Eli Zaretskii <eliz@gnu.org>
1447 * bidi.c <bidi_cache_total_alloc>: Now static.
1448 (bidi_initialize): Initialize bidi_cache_total_alloc.
1450 * xdisp.c (display_line): Release buffer allocated for shelved bidi
1453 * bidi.c (bidi_shelve_cache, bidi_unshelve_cache): Track total
1454 amount allocated this far in `bidi_cache_total_alloc'.
1455 (bidi_unshelve_cache): Accept an additional argument JUST_FREE; if
1456 non-zero, only free the data buffer without restoring the cache
1457 contents. All callers changed.
1459 * dispextern.h (bidi_unshelve_cache): Update prototype.
1461 * xdisp.c (SAVE_IT, pos_visible_p, move_it_in_display_line_to)
1462 (move_it_in_display_line, move_it_to)
1463 (move_it_vertically_backward, move_it_by_lines): Replace the call
1464 to xfree to an equivalent call to bidi_unshelve_cache.
1465 (move_it_in_display_line_to): Fix logic of returning
1466 MOVE_POS_MATCH_OR_ZV in the bidi case. (Bug#9224)
1468 2011-08-05 Eli Zaretskii <eliz@gnu.org>
1470 * xdisp.c (set_cursor_from_row): Prefer the candidate glyph that
1471 came from a string character with a `cursor' property. (Bug#9229)
1473 2011-08-04 Jan Djärv <jan.h.d@swipnet.se>
1475 * Makefile.in (LIB_PTHREAD): New variable.
1476 (LIBES): Add LIB_PTHREAD (Bug#9216).
1478 * alloc.c, emacs.c, gmalloc.c, gtkutil.c, keyboard.c, syssignal.h:
1479 Rename HAVE_GTK_AND_PTHREAD to HAVE_PTHREAD (Bug#9216).
1481 2011-08-04 Andreas Schwab <schwab@linux-m68k.org>
1483 * regex.c (re_iswctype): Remove some redundant boolean
1486 2011-08-04 Jan Djärv <jan.h.d@swipnet.se>
1488 * xterm.c (x_find_topmost_parent): New function.
1489 (x_set_frame_alpha): Find topmost parent window with
1490 x_find_topmost_parent and set the property there also (bug#9181).
1491 (handle_one_xevent): Call x_set_frame_alpha on ReparentNotify.
1493 2011-08-04 Paul Eggert <eggert@cs.ucla.edu>
1495 * callproc.c (Fcall_process): Avoid vfork clobbering
1496 the local vars buffer, coding_systems, current_dir.
1498 2011-08-03 Stefan Monnier <monnier@iro.umontreal.ca>
1500 * keymap.c (Fmake_composed_keymap): Move to subr.el.
1502 2011-08-03 Paul Eggert <eggert@cs.ucla.edu>
1504 * fontset.c (dump_fontset) [FONTSET_DEBUG]: Declare EXTERNALLY_VISIBLE
1505 so that it is not optimized away.
1507 * xdisp.c (compute_display_string_pos): Remove unused local.
1509 2011-08-02 Eli Zaretskii <eliz@gnu.org>
1511 Fix slow cursor motion and scrolling in large buffers with
1512 selective display, like Org Mode buffers. (Bug#9218)
1514 * dispextern.h (struct bidi_it): New member disp_prop_p.
1516 * xdisp.c: Remove one-slot cache of display string positions.
1517 (compute_display_string_pos): Accept an additional argument
1518 DISP_PROP_P; callers changed. Scan at most 5K characters forward
1519 for a display string or property. If found, set DISP_PROP_P
1522 * bidi.c (bidi_fetch_char): Accept an additional argument
1523 DISP_PROP_P, and pass it to compute_display_string_pos.
1524 Only handle text covered by a display string if DISP_PROP_P is returned
1525 non-zero. All callers of bidi_fetch_char changed.
1527 2011-08-02 Stefan Monnier <monnier@iro.umontreal.ca>
1529 * keymap.c (Fdefine_key): Fix Lisp_Object/int mixup; apply some CSE.
1531 2010-12-03 Don March <don@ohspite.net>
1533 * keymap.c (Fdefine_key): Fix non-prefix key error message when
1534 last character M-[char] is translated to ESC [char] (bug#7541).
1536 2011-08-02 Kenichi Handa <handa@m17n.org>
1538 * lisp.h (uniprop_table): Extern it.
1540 * chartab.c (uniprop_table): Make it non-static.
1542 2011-08-01 Eli Zaretskii <eliz@gnu.org>
1544 * xdisp.c (forward_to_next_line_start): Accept additional argument
1545 BIDI_IT_PREV, and store into it the state of the bidi iterator had
1547 (reseat_at_next_visible_line_start): Use the bidi iterator state
1548 returned by forward_to_next_line_start to restore the state of
1549 it->bidi_it after backing up to previous newline. (Bug#9212)
1551 2011-07-30 Andreas Schwab <schwab@linux-m68k.org>
1553 * regex.c (re_comp): Protoize.
1554 (re_exec): Fix return type.
1555 (regexec): Fix type of `ret'. (Bug#9203)
1557 2011-07-28 Paul Eggert <eggert@cs.ucla.edu>
1559 * image.c (check_image_size): Use 1024x1024 if unknown frame (Bug#9189).
1560 This is needed if max-image-size is a floating-point number.
1562 2011-07-28 Andreas Schwab <schwab@linux-m68k.org>
1564 * print.c (print_object): Print empty symbol as ##.
1566 * lread.c (read1): Read ## as empty symbol.
1568 2011-07-28 Alp Aker <alp.tekin.aker@gmail.com>
1570 * nsfns.m (x_set_foreground_color): Set f->foreground_pixel when
1571 setting frame foreground color (Bug#9175).
1572 (x_set_background_color): Likewise.
1574 * nsmenu.m (-setText): Size tooltip dimensions precisely to
1575 contents (Bug#9176).
1576 (EmacsTooltip -init): Remove bezels and add shadows to
1579 * nsterm.m (ns_dumpglyphs_stretch): Avoid overwriting left fringe
1580 or scroll bar (Bug#8470).
1582 * nsfont.m (nsfont_open): Remove assignment to voffset and
1583 unnecessary vars hshink, expand, hd, full_height, min_height.
1584 (nsfont_draw): Use s->ybase as baseline for glyph drawing (Bug#8913).
1586 * nsterm.h (nsfont_info): Remove voffset field.
1588 2011-07-28 Alp Aker <alp.tekin.aker@gmail.com>
1590 Implement strike-through and overline on NextStep (Bug#8863).
1592 * nsfont.m (nsfont_open): Use underline position provided by font,
1593 instead of hard-coded value of 2.
1594 (nsfont_draw): Call ns_draw_text_decoration instead.
1596 * nsterm.h: Add declaration for ns_draw_text_decoration.
1598 * nsterm.m (ns_draw_text_decoration): New function for drawing
1599 underline, overline, and strike-through.
1600 (ns_dumpglyphs_image, ns_dumpglyphs_stretch): Add call to
1601 ns_draw_text_decoration. Change treatment of cursor drawing to
1602 accommodate underlining, etc.
1604 2011-07-28 Eli Zaretskii <eliz@gnu.org>
1606 * buffer.c (init_buffer_once): Set bidi-display-reordering to t by
1609 2011-07-28 Paul Eggert <eggert@cs.ucla.edu>
1611 * alloc.c (memory_full) [!SYNC_INPUT]: Fix signal-related race.
1612 Without this fix, if a signal arrives just after memory fills up,
1613 'malloc' might be invoked reentrantly.
1615 * image.c (x_check_image_size) [!HAVE_X_WINDOWS]: Return 1.
1616 In other words, assume that every image size is allowed, on non-X
1617 hosts. This assumption is probably wrong, but it lets Emacs compile.
1619 2011-07-28 Andreas Schwab <schwab@linux-m68k.org>
1621 * regex.c (re_iswctype): Convert return values to boolean.
1623 2011-07-28 Eli Zaretskii <eliz@fencepost.gnu.org>
1625 * xdisp.c (compute_display_string_pos): Don't use cached display
1626 string position if the buffer had its restriction changed.
1629 2011-07-28 Paul Eggert <eggert@cs.ucla.edu>
1631 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
1633 2011-07-28 Paul Eggert <eggert@cs.ucla.edu>
1635 Integer signedness and overflow and related fixes. (Bug#9079)
1637 * bidi.c: Integer size and overflow fixes.
1638 (bidi_cache_size, bidi_cache_idx, bidi_cache_last_idx)
1639 (bidi_cache_start, bidi_cache_fetch_state, bidi_cache_search)
1640 (bidi_cache_find_level_change, bidi_cache_ensure_space)
1641 (bidi_cache_iterator_state, bidi_cache_find, bidi_cache_start_stack)
1642 (bidi_find_other_level_edge):
1643 Use ptrdiff_t instead of EMACS_INT where either will do.
1644 This works better on 32-bit hosts configured --with-wide-int.
1645 (bidi_cache_ensure_space): Check for size-calculation overflow.
1646 Use % rather than repeated addition, for better worst-case speed.
1647 Don't set bidi_cache_size until after xrealloc returns, because it
1649 (bidi_dump_cached_states): Use ptrdiff_t, not int, to avoid overflow.
1650 (bidi_cache_ensure_space): Also check that the bidi cache size
1651 does not exceed that of the largest Lisp string or buffer. See Eli
1652 Zaretskii in <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9079#29>.
1654 * alloc.c (__malloc_size_t): Remove.
1655 All uses replaced by size_t. See Andreas Schwab's note
1656 <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9079#8>.
1658 * image.c: Improve checking for integer overflow.
1659 (check_image_size): Assume that f is nonnull, since
1660 it is always nonnull in practice. This is one less thing to
1661 worry about when checking for integer overflow later.
1662 (x_check_image_size): New function, which checks for integer
1663 overflow issues inside X.
1664 (x_create_x_image_and_pixmap, xbm_read_bitmap_data): Use it.
1665 This removes the need for a memory_full check.
1666 (xbm_image_p): Rewrite to avoid integer multiplication overflow.
1667 (Create_Pixmap_From_Bitmap_Data, xbm_load): Use x_check_image_size.
1668 (xbm_read_bitmap_data): Change locals back to 'int', since
1669 their values must fit in 'int'.
1670 (xpm_load_image, png_load, tiff_load):
1671 Invoke x_create_x_image_and_pixmap earlier,
1672 to avoid much needless work if the image is too large.
1673 (tiff_load): Treat overly large images as if
1674 x_create_x_image_and_pixmap failed, not as malloc failures.
1675 (gs_load): Use x_check_image_size.
1677 * gtkutil.c: Omit integer casts.
1678 (xg_get_pixbuf_from_pixmap): Remove unnecessary cast.
1679 (xg_set_toolkit_scroll_bar_thumb): Rewrite to avoid need for cast.
1681 * image.c (png_load): Don't assume height * row_bytes fits in 'int'.
1683 * xfaces.c (Fbitmap_spec_p): Fix integer overflow bug.
1684 Without this fix, (bitmap-spec-p '(34359738368 1 "x"))
1685 would wrongly return t on a 64-bit host.
1687 * dispnew.c (init_display): Use *_RANGE_OVERFLOW macros.
1688 The plain *_OVERFLOW macros run afoul of GCC bug 49705
1689 <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=49705>
1690 and therefore cause GCC to emit a bogus diagnostic in some cases.
1692 * image.c: Integer signedness and overflow and related fixes.
1693 This is not an exhaustive set of fixes, but it's time to
1694 record what I've got.
1695 (lookup_pixel_color, check_image_size): Remove redundant decls.
1696 (check_image_size): Don't assume that arbitrary EMACS_INT values
1697 fit in 'int', or that arbitrary 'double' values fit in 'int'.
1698 (x_alloc_image_color, x_create_x_image_and_pixmap, png_load)
1699 (tiff_load, imagemagick_load_image):
1700 Check for overflow in size calculations.
1701 (x_create_x_image_and_pixmap): Remove unnecessary test for
1702 xmalloc returning NULL; that can't happen.
1703 (xbm_read_bitmap_data): Don't assume sizes fit into 'int'.
1704 (xpm_color_bucket): Use better integer hashing function.
1705 (xpm_cache_color): Don't possibly over-allocate memory.
1706 (struct png_memory_storage, tiff_memory_source, tiff_seek_in_memory)
1707 (gif_memory_source):
1708 Use ptrdiff_t, not int or size_t, to record sizes.
1709 (png_load): Don't assume values greater than 2**31 fit in 'int'.
1710 (our_stdio_fill_input_buffer): Prefer ptrdiff_t to size_t when
1711 either works, as we prefer signed integers.
1712 (tiff_read_from_memory, tiff_write_from_memory):
1713 Return tsize_t, not size_t, since that's what the TIFF API wants.
1714 (tiff_read_from_memory): Don't fail simply because the read would
1715 go past EOF; instead, return a short read.
1716 (tiff_load): Omit no-longer-needed casts.
1717 (Fimagemagick_types): Don't assume size fits into 'int'.
1719 Improve hashing quality when configured --with-wide-int.
1720 * fns.c (hash_string): New function, taken from sxhash_string.
1721 Do not discard information about ASCII character case; this
1722 discarding is no longer needed.
1723 (sxhash-string): Use it. Change sig to match it. Caller changed.
1724 * lisp.h: Declare it.
1725 * lread.c (hash_string): Remove, since we now use fns.c's version.
1726 The fns.c version returns a wider integer if --with-wide-int is
1727 specified, so this should help the quality of the hashing a bit.
1729 * emacs.c: Integer overflow minor fix.
1730 (heap_bss_diff): Now uprintmax_t, not unsigned long. All used changed.
1731 Define only if GNU_LINUX.
1732 (main, Fdump_emacs): Set and use heap_bss_diff only if GNU_LINUX.
1734 * dispnew.c: Integer signedness and overflow fixes.
1735 Remove unnecessary forward decls, that were a maintenance hassle.
1736 (history_tick): Now uprintmax_t, so it's more likely to avoid overflow.
1738 (adjust_glyph_matrix, realloc_glyph_pool, adjust_frame_message_buffer)
1739 (scrolling_window): Use ptrdiff_t, not int, for byte count.
1740 (prepare_desired_row, line_draw_cost):
1741 Use int, not unsigned, where either works.
1742 (save_current_matrix, restore_current_matrix):
1743 Use ptrdiff_t, not size_t, where either works.
1744 (init_display): Check for overflow more accurately, and without
1745 relying on undefined behavior.
1747 * editfns.c (pWIDE, pWIDElen, signed_wide, unsigned_wide):
1748 Remove, replacing with the new symbols in lisp.h. All uses changed.
1749 * fileio.c (make_temp_name):
1750 * filelock.c (lock_file_1, lock_file):
1751 * xdisp.c (message_dolog):
1752 Don't assume PRIdMAX etc. works; this isn't portable to pre-C99 hosts.
1753 Use pMd etc. instead.
1754 * lisp.h (printmax_t, uprintmax_t, pMd, pMu): New types and macros,
1755 replacing the pWIDE etc. symbols removed from editfns.c.
1757 * keyboard.h (num_input_events): Now uintmax_t.
1758 This is (very slightly) less likely to mess up due to wraparound.
1761 * buffer.c: Integer signedness fixes.
1762 (alloc_buffer_text, enlarge_buffer_text):
1763 Use ptrdiff_t rather than size_t when either will do, as we prefer
1766 * alloc.c: Integer signedness and overflow fixes.
1767 Do not impose an arbitrary 32-bit limit on malloc sizes when debugging.
1768 (__malloc_size_t): Default to size_t, not to int.
1769 (pure_size, pure_bytes_used_before_overflow, stack_copy_size)
1770 (Fgarbage_collect, mark_object_loop_halt, mark_object):
1771 Prefer ptrdiff_t to size_t when either would do, as we prefer
1773 (XMALLOC_OVERRUN_CHECK_OVERHEAD): New macro.
1774 (xmalloc_overrun_check_header, xmalloc_overrun_check_trailer):
1775 Now const. Initialize with values that are in range even if char
1777 (XMALLOC_PUT_SIZE, XMALLOC_GET_SIZE): Remove, replacing with ...
1778 (xmalloc_put_size, xmalloc_get_size): New functions. All uses changed.
1779 These functions do the right thing with sizes > 2**32.
1780 (check_depth): Now ptrdiff_t, not int.
1781 (overrun_check_malloc, overrun_check_realloc, overrun_check_free):
1782 Adjust to new way of storing sizes. Check for size overflow bugs
1784 (STRING_BYTES_MAX): Adjust to new overheads. The old code was
1785 slightly wrong anyway, as it missed one instance of
1786 XMALLOC_OVERRUN_CHECK_OVERHEAD.
1787 (refill_memory_reserve): Omit needless cast to size_t.
1788 (mark_object_loop_halt): Mark as externally visible.
1790 * xselect.c: Integer signedness and overflow fixes.
1791 (Fx_register_dnd_atom, x_handle_dnd_message):
1792 Use ptrdiff_t, not size_t, since we prefer signed.
1793 (Fx_register_dnd_atom): Check for ptrdiff_t (and size_t) overflow.
1794 * xterm.h (struct x_display_info): Use ptrdiff_t, not size_t, for
1795 x_dnd_atoms_size and x_dnd_atoms_length.
1797 * doprnt.c: Prefer signed to unsigned when either works.
1799 * doprnt.c (doprnt):
1801 * xdisp.c (vmessage):
1802 Use ptrdiff_t, not size_t, when using or implementing doprnt,
1803 since the sizes cannot exceed ptrdiff_t bounds anyway, and we
1804 prefer signed arithmetic to avoid comparison confusion.
1805 * doprnt.c (doprnt): Avoid a "+ 1" that can't overflow,
1806 but is a bit tricky.
1808 Assume freestanding C89 headers, string.h, stdlib.h.
1809 * data.c, doprnt.c, floatfns.c, print.c:
1810 Include float.h unconditionally.
1811 * gmalloc.c: Assume C89-at-least behavior for preprocessor,
1812 limits.h, stddef.h, string.h. Use memset instead of 'flood'.
1813 * regex.c: Likewise for stddef.h, string.h.
1814 (ISASCII): Remove; can assume it returns 1 now. All uses removed.
1815 * s/aix4-2.h (HAVE_STRING_H): Remove obsolete undef.
1816 * s/ms-w32.h (HAVE_LIMITS_H, HAVE_STRING_H, HAVE_STDLIB_H)
1817 (STDC_HEADERS): Remove obsolete defines.
1818 * sysdep.c: Include limits.h unconditionally.
1820 Assume support for memcmp, memcpy, memmove, memset.
1821 * lisp.h, sysdep.c (memcmp, memcpy, memmove, memset):
1822 * regex.c (memcmp, memcpy):
1823 Remove; we assume C89 now.
1825 * gmalloc.c (memcpy, memset, memmove): Remove; we assume C89 now.
1826 (__malloc_safe_bcopy): Remove; no longer needed.
1828 * lisp.h (struct vectorlike_header, struct Lisp_Subr): Signed sizes.
1829 Use EMACS_INT, not EMACS_UINT, for sizes. The code works equally
1830 well either way, and we prefer signed to unsigned.
1832 2011-07-27 Lars Magne Ingebrigtsen <larsi@gnus.org>
1834 * gnutls.c (emacs_gnutls_read): Don't message anything if the peer
1835 closes the connection while we're reading (bug#9182).
1837 2011-07-25 Jan Djärv <jan.h.d@swipnet.se>
1839 * nsmenu.m (ns_popup_dialog): Add an "ok" button if no buttons
1840 are specified (Bug#9168).
1842 2011-07-25 Paul Eggert <eggert@cs.ucla.edu>
1844 * bidi.c (bidi_dump_cached_states): Fix printf format mismatch.
1845 Found by GCC static checking and --with-wide-int on a 32-bit host.
1847 2011-07-25 Eli Zaretskii <eliz@gnu.org>
1849 * xdisp.c (compute_display_string_pos): Fix logic of caching
1850 previous display string position. Initialize cached_prev_pos to
1851 -1. Fixes slow-down at the beginning of a buffer.
1853 2011-07-24 Eli Zaretskii <eliz@gnu.org>
1855 * xfaces.c (check_lface_attrs) [HAVE_WINDOW_SYSTEM]: Allow `nil'
1856 for attrs[LFACE_FONTSET_INDEX].
1858 2011-07-23 Paul Eggert <eggert@cs.ucla.edu>
1860 * xml.c (parse_region): Remove unused local
1861 that was recently introduced.
1863 2011-07-23 Eli Zaretskii <eliz@gnu.org>
1865 * xfns.c (unwind_create_frame) [GLYPH_DEBUG]: Adapt to changes in
1866 2008-02-22T17:42:09Z!monnier@iro.umontreal.ca.
1868 * xdisp.c (move_it_in_display_line_to): Record the best matching
1869 position for TO_CHARPOS while scanning the line, and restore it on
1870 exit if none of the characters scanned was an exact match.
1871 Fixes vertical-motion and pos-visible-in-window-p under bidi redisplay
1872 when exact match is impossible due to invisible text, and the
1873 lines are truncated.
1875 2011-07-23 Jan Djärv <jan.h.d@swipnet.se>
1877 * nsterm.m (initFrameFromEmacs): Set NSTitledWindowMask in styleMask
1880 2011-07-22 Eli Zaretskii <eliz@gnu.org>
1882 Fix a significant slow-down of cursor motion with C-n, C-p,
1883 C-f/C-b, and C-v/M-v that couldn't keep up with keyboard
1884 auto-repeat under bidi redisplay in fontified buffers.
1885 * xdisp.c (compute_stop_pos_backwards): New function.
1886 (next_element_from_buffer): Call compute_stop_pos_backwards to
1887 find a suitable prev_stop when we find ourselves before
1889 (reseat): Don't look for prev_stop, as that could mean a very long
1891 <cached_disp_pos, cached_disp_buffer, cached_disp_modiff>
1892 <cached_disp_overlay_modiff>: Cache for last found display string
1894 (compute_display_string_pos): Return the cached position if asked
1895 about the same buffer in the same area of character positions, and
1896 the buffer wasn't changed since the time the display string
1897 position was cached.
1899 2011-07-22 Eli Zaretskii <eliz@gnu.org>
1901 * xdisp.c (rows_from_pos_range): Don't ignore glyphs whose object
1902 is an integer, which is important for empty lines. (Bug#9149)
1904 2011-07-22 Chong Yidong <cyd@stupidchicken.com>
1906 * frame.c (Fmodify_frame_parameters): In tty case, update the
1907 default face if necessary (Bug#4238).
1909 2011-07-21 Chong Yidong <cyd@stupidchicken.com>
1911 * editfns.c (Fstring_to_char): No need to explain what a character
1912 is in the docstring (Bug#6576).
1914 2011-07-20 Lars Magne Ingebrigtsen <larsi@gnus.org>
1916 * xml.c (parse_region): Make sure we always return a tree.
1918 2011-07-20 HAMANO Kiyoto <khiker.mail@gmail.com>
1920 * xml.c (parse_region): If a document contains only comments,
1923 2011-07-20 Lars Magne Ingebrigtsen <larsi@gnus.org>
1925 * xml.c (make_dom): Return comments, too.
1927 2011-07-19 Paul Eggert <eggert@cs.ucla.edu>
1930 See http://lists.gnu.org/archive/html/emacs-devel/2011-07/msg00688.html
1931 and the surrounding thread.
1932 * minibuf.c (read_minibuf_noninteractive): Rewrite to use getchar
1933 rather than fgets, and retry after EINTR. Otherwise, 'emacs
1934 --batch -f byte-compile-file' fails on OpenBSD if an inactivity
1936 * s/openbsd.h (BROKEN_SIGIO): Define.
1937 * unexelf.c (unexec) [__OpenBSD__]:
1938 Don't update the .mdebug section of the Alpha COFF symbol table.
1940 2011-07-19 Lars Magne Ingebrigtsen <larsi@gnus.org>
1942 * lread.c (syms_of_lread): Clarify when `lexical-binding' is used
1945 2011-07-18 Paul Eggert <eggert@cs.ucla.edu>
1947 * fileio.c (Fcopy_file) [!MSDOS]: Tighten created file's mask.
1948 This fixes some race conditions on the permissions of any newly
1951 * alloc.c (valid_pointer_p): Use pipe, not open.
1952 This fixes some permissions issues when debugging.
1954 * fileio.c (Fcopy_file): Adjust mode if fchown fails. (Bug#9002)
1955 If fchown fails to set both uid and gid, try to set just gid,
1956 as that is sometimes allowed. Adjust the file's mode to eliminate
1957 setuid or setgid bits that are inappropriate if fchown fails.
1959 2011-07-18 Stefan Monnier <monnier@iro.umontreal.ca>
1961 * xdisp.c (next_element_from_string, next_element_from_buffer): Use EQ
1962 to compare Lisp_Objects.
1963 * gnutls.c (syms_of_gnutls): Rename Vgnutls_log_level to
1964 global_gnutls_log_level, don't mistake it for a Lisp_Object.
1965 (init_gnutls_functions, emacs_gnutls_handle_error): Fix up uses.
1967 2011-07-17 Andreas Schwab <schwab@linux-m68k.org>
1969 * lread.c (read_integer): Unread even EOF character.
1970 (read1): Likewise. Properly record start position of symbol.
1972 * lread.c (read1): Read `#:' as empty uninterned symbol if no
1973 symbol character follows.
1975 2011-07-17 Paul Eggert <eggert@cs.ucla.edu>
1977 * fileio.c (Fcopy_file): Pacify gcc re fchown. (Bug#9002)
1978 This works around a problem with the previous change to Fcopy_file.
1979 Recent glibc declares fchown with __attribute__((warn_unused_result)),
1980 and without this change, GCC might complain about discarding
1981 fchown's return value.
1983 2011-07-16 Juanma Barranquero <lekktu@gmail.com>
1985 * makefile.w32-in (GLOBAL_SOURCES): Add gnutls.c (followup to bug#9059).
1987 2011-07-16 Paul Eggert <eggert@cs.ucla.edu>
1989 * fileio.c (Fcopy_file): Don't diagnose fchown failures. (Bug#9002)
1991 2011-07-16 Lars Magne Ingebrigtsen <larsi@gnus.org>
1993 * gnutls.c (syms_of_gnutls): Define `gnutls-log-level' here, since
1994 it's used from the C level.
1996 * process.c: Use the same condition for POLL_FOR_INPUT in both
1997 keyboard.c and process.c (bug#1858).
1999 2011-07-09 Lawrence Mitchell <wence@gmx.li>
2001 * gnutls.c (Qgnutls_bootprop_min_prime_bits): New variable.
2002 (Fgnutls_boot): Use it.
2004 2011-07-15 Andreas Schwab <schwab@linux-m68k.org>
2006 * doc.c (Fsubstitute_command_keys): Revert last change.
2008 2011-07-15 Lars Magne Ingebrigtsen <larsi@gnus.org>
2010 * doc.c (Fsubstitute_command_keys): Clarify that \= really only
2011 quotes the next character, and doesn't affect other longer
2012 sequences (bug#8935).
2014 * lread.c (syms_of_lread): Clarify that is isn't only
2015 `eval-buffer' and `eval-defun' that's affected by
2016 `lexical-binding' (bug#8460).
2018 2011-07-15 Eli Zaretskii <eliz@gnu.org>
2020 * xdisp.c (move_it_in_display_line_to): Fix vertical motion with
2021 bidi redisplay when a line includes both an image and is
2024 2011-07-14 Paul Eggert <eggert@cs.ucla.edu>
2026 Fix minor problems found by static checking.
2027 * bidi.c (bidi_cache_size): Now EMACS_INT, not size_t.
2028 (elsz): Now a signed constant, not a size_t var. We prefer signed
2029 types to unsigned, to avoid integer comparison confusion. Without
2030 this change, GCC 4.6.1 with -Wunsafe-loop-optimizations complains
2031 "cannot optimize loop, the loop counter may overflow", a symptom
2033 * indent.c (Fvertical_motion): Mark locals as initialized.
2034 * xdisp.c (reseat_to_string): Fix pointer signedness issue.
2036 2011-07-14 Lars Magne Ingebrigtsen <larsi@gnus.org>
2038 * search.c (Fre_search_backward): Mention `case-fold-search' in
2039 all the re_search_* functions (bug#8138).
2041 * keyboard.c (Fopen_dribble_file): Document when the file is
2044 2011-07-14 Eli Zaretskii <eliz@gnu.org>
2046 * bidi.c (bidi_dump_cached_states): Fix format of displaying
2049 Support bidi reordering of display and overlay strings.
2050 * xdisp.c (compute_display_string_pos)
2051 (compute_display_string_end): Accept additional argument STRING.
2052 (init_iterator, reseat_1): Initialize bidi_it->string.s to NULL.
2053 (reseat_to_string): Initialize bidi_it->string.s and
2054 bidi_it->string.schars.
2055 (Fcurrent_bidi_paragraph_direction): Initialize itb.string.s to
2056 NULL (avoids a crash in bidi_paragraph_init).
2057 Initialize itb.string.lstring.
2058 (init_iterator): Call bidi_init_it only of a valid
2059 buffer position was specified. Initialize paragraph_embedding to
2061 (reseat_to_string): Initialize the bidi iterator.
2062 (display_string): If we need to ignore text properties of
2063 LISP_STRING, set IT->stop_charpos to IT->end_charpos. (The
2064 original value of -1 will not work with bidi.)
2065 (compute_display_string_pos): First arg is now struct
2066 `text_pos *'; all callers changed. Support display properties on
2068 (compute_display_string_end): Support display properties on Lisp
2070 (init_iterator, reseat_1, reseat_to_string): Initialize the
2071 string.bufpos member to 0 (zero, for compatibility with IT_CHARPOS
2072 when iterating on a string not from display properties).
2073 (compute_display_string_pos, compute_display_string_end):
2074 Fix calculation of the object to scan. Fixes an error when using
2076 (next_element_from_buffer): Don't abort when IT_CHARPOS is before
2077 base_level_stop; instead, set base_level_stop to BEGV.
2078 Fixes crashes in vertical-motion.
2079 (next_element_from_buffer): Improve commentary for when
2080 the iterator is before prev_stop.
2081 (init_iterator): Initialize bidi_p from the default value of
2082 bidi-display-reordering, not from buffer-local value. Use the
2083 buffer-local value only if initializing for buffer iteration.
2084 (handle_invisible_prop): Support invisible properties on strings
2085 that are being bidi-reordered.
2086 (set_iterator_to_next): Support bidi reordering of C strings and
2088 (next_element_from_string): Support bidi reordering of Lisp
2090 (handle_stop_backwards): Support Lisp strings as well.
2091 (display_string): Support display of R2L glyph rows.
2092 Use IT_STRING_CHARPOS when displaying from a Lisp string.
2093 (init_iterator): Don't initialize it->bidi_p for strings
2095 (reseat_to_string): Initialize it->bidi_p for strings here.
2096 (next_element_from_string, next_element_from_c_string)
2097 (next_element_from_buffer): Add xassert's for correspondence
2098 between IT's object being iterated and it->bidi_it.string
2100 (face_before_or_after_it_pos): Support bidi iteration.
2101 (next_element_from_c_string): Handle the case of the first string
2102 character that is not the first one in the visual order.
2103 (get_visually_first_element): New function, refactored from common
2104 parts of next_element_from_buffer, next_element_from_string, and
2105 next_element_from_c_string.
2106 (tool_bar_lines_needed, redisplay_tool_bar)
2107 (display_menu_bar): Force left-to-right direction. Add a FIXME
2108 comment for making that be controlled by a user option.
2109 (push_it, pop_it): Save and restore the state of the
2110 bidi iterator. Save and restore the bidi_p flag.
2111 (pop_it): Iterate out of display property for string iteration as
2113 (iterate_out_of_display_property): Support iteration over strings.
2114 (handle_single_display_spec): Set up it->bidi_it for iteration
2115 over a display string, and call bidi_init_it.
2116 (handle_single_display_spec, next_overlay_string)
2117 (get_overlay_strings_1, push_display_prop): Set up the bidi
2118 iterator for displaying display or overlay strings.
2119 (forward_to_next_line_start): Don't use the shortcut if
2121 (back_to_previous_visible_line_start): If handle_display_prop
2122 pushed the iterator stack, restore the internal state of the bidi
2123 iterator by calling bidi_pop_it same number of times.
2124 (reseat_at_next_visible_line_start): If ON_NEWLINE_P is non-zero,
2125 and we are bidi-iterating, don't decrement the iterator position;
2126 instead, set the first_elt flag in the bidi iterator, to produce
2128 (reseat_1): Remove redundant setting of string_from_display_prop_p.
2129 (push_display_prop): xassert that we are iterating a buffer.
2130 (push_it, pop_it): Save and restore paragraph_embedding member.
2131 (handle_single_display_spec, next_overlay_string)
2132 (get_overlay_strings_1, reseat_1, reseat_to_string)
2133 (push_display_prop): Set up the `unibyte' member of bidi_it.string
2134 correctly. Don't assume unibyte strings are not bidi-reordered.
2135 (compute_display_string_pos)
2136 (compute_display_string_end): Fix handling the case of C string.
2137 (push_it, pop_it): Save and restore from_disp_prop_p.
2138 (handle_single_display_spec, push_display_prop): Set the
2139 from_disp_prop_p flag.
2140 (get_overlay_strings_1): Reset the from_disp_prop_p flag.
2141 (pop_it): Call iterate_out_of_display_property only if we are
2142 popping after iteration over a string that came from a display
2143 property. Fix a typo in popping stretch info. Add an assertion
2144 for verifying that the iterator position is in sync with the bidi
2146 (handle_single_display_spec, get_overlay_strings_1)
2147 (push_display_prop): Fix initialization of paragraph direction for
2148 string when that of the parent object is not yet determined.
2149 (reseat_1): Call bidi_init_it to resync the bidi
2150 iterator with IT's position. (Bug#7616)
2151 (find_row_edges): If ROW->start.pos gives position
2152 smaller than min_pos, use it as ROW->minpos. (Bug#7616)
2153 (handle_stop, back_to_previous_visible_line_start, reseat_1):
2154 Reset the from_disp_prop_p flag.
2155 (SAVE_IT, RESTORE_IT): New macros.
2156 (pos_visible_p, face_before_or_after_it_pos)
2157 (back_to_previous_visible_line_start)
2158 (move_it_in_display_line_to, move_it_in_display_line)
2159 (move_it_to, move_it_vertically_backward, move_it_by_lines)
2160 (try_scrolling, redisplay_window, display_line): Use them when
2161 saving a temporary copy of the iterator and restoring it back.
2162 (back_to_previous_visible_line_start, reseat_1)
2163 (init_iterator): Empty the bidi cache "stack".
2164 (move_it_in_display_line_to): If iterator ended up at
2165 EOL, but we never saw any buffer positions smaller than
2166 to_charpos, return MOVE_POS_MATCH_OR_ZV. Fixes vertical cursor
2167 motion in bidi-reordered lines.
2168 (move_it_in_display_line_to): Record prev_method and prev_pos
2169 immediately before the call to set_iterator_to_next. Fixes cursor
2170 motion in bidi-reordered lines with stretch glyphs and strings
2171 displayed in margins. (Bug#8133) (Bug#8867)
2172 Return MOVE_POS_MATCH_OR_ZV only if iterator position is past
2174 (pos_visible_p): Support positions in bidi-reordered lines.
2175 Save and restore bidi cache.
2177 * bidi.c (bidi_level_of_next_char): clen should be EMACS_NT, not int.
2178 (bidi_paragraph_info): Delete unused struct.
2179 (bidi_cache_idx, bidi_cache_last_idx): Declare EMACS_INT.
2180 (bidi_cache_start): New variable.
2181 (bidi_cache_reset): Reset bidi_cache_idx to bidi_cache_start, not
2183 (bidi_cache_fetch_state, bidi_cache_search)
2184 (bidi_cache_find_level_change, bidi_cache_iterator_state)
2185 (bidi_cache_find, bidi_peek_at_next_level)
2186 (bidi_level_of_next_char, bidi_find_other_level_edge)
2187 (bidi_move_to_visually_next): Compare cache index with
2188 bidi_cache_start rather than with zero.
2189 (bidi_fetch_char): Accept new argument STRING; all callers
2190 changed. Support iteration over a string. Support strings with
2191 display properties. Support unibyte strings. Fix the type of
2192 `len' according to what STRING_CHAR_AND_LENGTH expects.
2193 (bidi_paragraph_init, bidi_resolve_explicit_1)
2194 (bidi_resolve_explicit, bidi_resolve_weak)
2195 (bidi_level_of_next_char, bidi_move_to_visually_next):
2196 Support iteration over a string.
2197 (bidi_set_sor_type, bidi_resolve_explicit_1)
2198 (bidi_resolve_explicit, bidi_type_of_next_char): ignore_bn_limit
2199 can now be zero (for strings); special values 0 and -1 were
2200 changed to -1 and -2, respectively.
2201 (bidi_char_at_pos): New function.
2202 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak):
2203 Call it instead of FETCH_MULTIBYTE_CHAR.
2204 (bidi_move_to_visually_next): Abort if charpos or bytepos were not
2205 initialized to valid values.
2206 (bidi_init_it): Don't initialize charpos and bytepos with invalid
2208 (bidi_level_of_next_char): Allow the sentinel "position" to pass
2209 the test for valid cached positions. Fix the logic for looking up
2210 the sentinel state in the cache. GCPRO the Lisp string we are
2212 (bidi_push_it, bidi_pop_it): New functions.
2213 (bidi_initialize): Initialize the bidi cache start stack pointer.
2214 (bidi_cache_ensure_space): New function, refactored from part of
2215 bidi_cache_iterator_state. Don't assume the required size is just
2216 one BIDI_CACHE_CHUNK away.
2217 (bidi_cache_start_stack, bidi_push_it): Use IT_STACK_SIZE.
2218 (bidi_count_bytes, bidi_char_at_pos): New functions.
2219 (bidi_cache_search): Don't assume bidi_cache_last_idx is
2220 always valid if bidi_cache_idx is valid.
2221 (bidi_cache_find_level_change): xassert that bidi_cache_last_idx
2222 is valid if it's going to be used.
2223 (bidi_shelve_cache, bidi_unshelve_cache): New functions.
2224 (bidi_cache_fetch_state, bidi_cache_search)
2225 (bidi_cache_find_level_change, bidi_cache_ensure_space)
2226 (bidi_cache_iterator_state, bidi_cache_find)
2227 (bidi_find_other_level_edge, bidi_cache_start_stack):
2228 All variables related to cache indices are now EMACS_INT.
2230 * dispextern.h (struct bidi_string_data): New structure.
2231 (struct bidi_it): New member `string'. Make flag members be 1-bit
2232 fields, and put them last in the struct.
2233 (compute_display_string_pos, compute_display_string_end):
2235 (bidi_push_it, bidi_pop_it): Add prototypes.
2236 (struct iterator_stack_entry): New members bidi_p,
2237 paragraph_embedding, and from_disp_prop_p.
2238 (struct it): Member bidi_p is now a bit field 1 bit wide.
2239 (bidi_shelve_cache, bidi_unshelve_cache):
2242 * .gdbinit (xvectype, xvector, xcompiled, xchartable, xboolvector)
2243 (xpr, xfont, xbacktrace): Use "header.size" when accessing vectors
2244 and vector-like objects.
2246 * dispnew.c (buffer_posn_from_coords): Save and restore the bidi
2247 cache around display iteration.
2249 * window.c (Fwindow_end, window_scroll_pixel_based)
2250 (displayed_window_lines, Frecenter): Save and restore the bidi
2251 cache around display iteration.
2253 2011-07-14 Lars Magne Ingebrigtsen <larsi@gnus.org>
2255 * editfns.c (Fdelete_region): Clarify the use of the named
2256 parameters (bug#6788).
2258 2011-07-14 Martin Rudalics <rudalics@gmx.at>
2260 * indent.c (Fvertical_motion): Set and restore w->pointm when
2261 saving and restoring the window's buffer (Bug#9006).
2263 2011-07-13 Lars Magne Ingebrigtsen <larsi@gnus.org>
2265 * editfns.c (Fstring_to_char): Clarify just what is returned
2266 (bug#6576). Text by Eli Zaretskii.
2268 2011-07-13 Juanma Barranquero <lekktu@gmail.com>
2270 * gnutls.c (init_gnutls_functions): Honor gnutls_log_level (bug#9059).
2272 2011-07-13 Eli Zaretskii <eliz@gnu.org>
2274 * buffer.c (mmap_find): Fix a typo.
2276 2011-07-13 Johan Bockgård <bojohan@gnu.org>
2278 Fix execution of x selection hooks.
2279 * xselect.c (Qx_lost_selection_functions)
2280 (Qx_sent_selection_functions): New vars.
2281 (syms_of_xselect): DEFSYM them.
2282 (x_handle_selection_request): Pass Qx_sent_selection_functions
2283 rather than Vx_sent_selection_functions to Frun_hook_with_args.
2284 (x_handle_selection_clear,x_clear_frame_selections):
2285 Pass Qx_lost_selection_functions rather than
2286 Vx_lost_selection_functions to Frun_hook_with_args.
2288 2011-07-13 Paul Eggert <eggert@cs.ucla.edu>
2290 * buffer.c (Fget_buffer_create): Initialize inhibit_shrinking.
2291 The old code sometimes used this field without initializing it.
2293 * alloc.c (gc_sweep): Don't read past end of array.
2294 In theory, the old code could also have corrupted Emacs internals,
2295 though it'd be very unlikely.
2297 2011-07-12 Andreas Schwab <schwab@linux-m68k.org>
2299 * character.c (Fcharacterp): Don't advertise optional ignored
2300 argument. (Bug#4026)
2302 2011-07-12 Lars Magne Ingebrigtsen <larsi@gnus.org>
2304 * keymap.c (syms_of_keymap): Clarify that "modifier" is "modifier
2307 * window.c (Fset_window_start): Doc fix (bug#4199).
2308 (Fset_window_hscroll): Ditto.
2310 2011-07-12 Paul Eggert <eggert@cs.ucla.edu>
2312 Fix minor new problems caught by GCC 4.6.1.
2313 * term.c (init_tty): Remove unused local.
2314 * xsettings.c (store_monospaced_changed): Define this function only
2315 if (defined HAVE_GSETTINGS || defined HAVE_GCONF), as it's
2318 2011-07-12 Chong Yidong <cyd@stupidchicken.com>
2320 * xdisp.c (Vresize_mini_windows): Minor doc fix (Bug#3300).
2322 2011-07-11 Lars Magne Ingebrigtsen <larsi@gnus.org>
2324 * xdisp.c (syms_of_xdisp): Make it explicit that the mini-windows
2325 are the mini-buffer and the echo area (bug#3320).
2327 * term.c (init_tty): Remove support for supdup, c10 and perq
2328 terminals, which are no longer supported (bug#1482).
2330 2011-07-10 Johan Bockgård <bojohan@gnu.org>
2332 * xdisp.c (Ftool_bar_lines_needed): Fix WINDOWP check.
2334 2011-07-10 Jan Djärv <jan.h.d@swipnet.se>
2336 * xmenu.c (menu_highlight_callback): Only pass frame to show_help_event
2337 for non-popups (Bug#3642).
2339 2011-07-10 Andreas Schwab <schwab@linux-m68k.org>
2341 * alloc.c (reset_malloc_hooks): Protoize.
2342 * buffer.c (mmap_init, mmap_find, mmap_free_1, mmap_enlarge)
2343 (mmap_set_vars, mmap_alloc, mmap_free, mmap_realloc): Likewise.
2344 * cm.c (losecursor): Likewise.
2345 * data.c (fmod): Likewise.
2346 * dispnew.c (swap_glyphs_in_rows): Likewise.
2347 * emacs.c (memory_warning_signal): Likewise.
2348 * floatfns.c (float_error): Likewise.
2349 * font.c (check_gstring, check_otf_features, otf_tag_symbol)
2350 (otf_open, font_otf_capability, generate_otf_features)
2351 (font_otf_DeviceTable, font_otf_ValueRecord, font_otf_Anchor):
2353 * image.c (pbm_read_file): Likewise.
2354 * indent.c (string_display_width): Likewise.
2355 * intervals.c (check_for_interval, search_for_interval)
2356 (inc_interval_count, count_intervals, root_interval)
2357 (adjust_intervals_for_insertion, make_new_interval): Likewise.
2358 * lread.c (defalias): Likewise.
2359 * ralloc.c (r_alloc_check): Likewise.
2360 * regex.c (set_image_of_range_1, set_image_of_range)
2361 (regex_grow_registers): Likewise.
2362 * sysdep.c (strerror): Likewise.
2363 * termcap.c (valid_filename_p, tprint, main): Likewise.
2364 * tparam.c (main): Likewise.
2365 * unexhp9k800.c (run_time_remap, save_data_space)
2366 (update_file_ptrs, read_header, write_header, calculate_checksum)
2367 (copy_file, copy_rest, display_header): Likewise.
2368 * widget.c (mark_shell_size_user_specified, create_frame_gcs):
2370 * xdisp.c (check_it): Likewise.
2371 * xfaces.c (register_color, unregister_color, unregister_colors):
2373 * xfns.c (print_fontset_result): Likewise.
2374 * xrdb.c (member, fatal, main): Likewise.
2376 2011-07-10 Paul Eggert <eggert@cs.ucla.edu>
2378 Fix minor problems found by static checking (Bug#9031).
2379 * chartab.c (char_table_set_range, map_sub_char_table):
2380 Remove unused locals.
2381 (uniprop_table): Now static.
2382 * composite.c (_work_char): Remove unused static var.
2384 2011-07-09 Juanma Barranquero <lekktu@gmail.com>
2386 * chartab.c (uniprop_table_uncompress): Remove unused local variable.
2388 2011-07-09 Jan Djärv <jan.h.d@swipnet.se>
2390 * gtkutil.c (qttip_cb): Remove code without function.
2392 2011-07-09 Eli Zaretskii <eliz@gnu.org>
2394 * w32.c (pthread_sigmask): New stub.
2396 2011-07-08 Paul Eggert <eggert@cs.ucla.edu>
2398 Use pthread_sigmask, not sigprocmask (Bug#9010).
2399 sigprocmask is portable only for single-threaded applications, and
2400 Emacs can be multi-threaded when it uses GTK.
2401 * Makefile.in (LIB_PTHREAD_SIGMASK): New macro.
2403 * callproc.c (Fcall_process):
2404 * process.c (create_process):
2405 * sysdep.c (sys_sigblock, sys_sigunblock, sys_sigsetmask):
2406 Use pthread_sigmask, not sigprocmask.
2408 2011-07-08 Jan Djärv <jan.h.d@swipnet.se>
2410 * gtkutil.c (qttip_cb): Set line wrap to FALSE for tooltip widget.
2411 (xg_prepare_tooltip): Revert text in x->ttip_lbl, margins was
2414 2011-07-08 Jan Djärv <jan.h.d@swipnet.se>
2416 * gtkutil.c (xg_prepare_tooltip): Fix indentation and comment.
2417 Put text in x->ttip_lbl instead of gtk_tooltip_set_text (Bug#8591).
2418 (xg_hide_tooltip): Fix comment.
2420 * nsterm.m (initFrameFromEmacs): Don't use ns_return_types
2421 in registerServicesMenuSendTypes.
2422 (validRequestorForSendType): Don't check ns_return_types.
2424 * nsfns.m (Fx_open_connection): Put NSStringPboardType into
2427 2011-07-08 Jason Rumney <jasonr@gnu.org>
2429 * w32fns.c (w32_wnd_proc) [WM_TIMER, WM_SET_CURSOR]: Avoid using
2430 frame struct members of non-existent frames (Bug#6284).
2432 2011-07-08 Jan Djärv <jan.h.d@swipnet.se>
2434 * nsterm.m (keyDown): Call to wantsToDelayTextChangeNotifications and
2435 variable firstTime not needed on OSX >= 10.6.
2436 (setPosition): setFloatValue:knobProportion: is deprecated on OSX
2437 >= 10.5. Use setKnobProportion, setDoubleValue.
2439 * nsterm.h (MAC_OS_X_VERSION_10_3, MAC_OS_X_VERSION_10_4)
2440 (MAC_OS_X_VERSION_10_5): Define if not defined.
2441 (EmacsView, EmacsTooltip): Implements NSWindowDelegate on OSX >= 10.6.
2442 (EmacsMenu): Implements NSMenuDelegate on OSX >= 10.6.
2443 (EmacsToolbar): Implements NSToolbarDelegate on OSX >= 10.6.
2445 * nsselect.m (ns_string_from_pasteboard): Don't use deprecated methods
2446 cString and lossyCString on OSX >= 10.4
2448 * nsmenu.m (fillWithWidgetValue): Don't use depercated method
2449 sizeToFit on OSX >= 10.2.
2451 * nsimage.m (allocInitFromFile): Don't use deprecated method
2452 bestRepresentationForDevice on OSX >= 10.6.
2454 * nsfns.m (check_ns_display_info): Cast to long and use %ld in error
2457 * emacs.c: Declare unexec_init_emacs_zone.
2459 * nsgui.h: Fix compiler warning about gnulib redefining verify.
2461 * nsselect.m (ns_get_local_selection): Change to extern (Bug#8842).
2463 * nsmenu.m (ns_update_menubar): Remove useless setDelegate call
2464 on svcsMenu (Bug#8842).
2466 * nsfns.m (Fx_open_connection): Remove NSStringPboardType from
2468 (Fns_list_services): Just return Qnil on 10.6, code not working there.
2470 * nsterm.m (QUTF8_STRING): Declare.
2471 (initFrameFromEmacs): Call registerServicesMenuSendTypes.
2472 (validRequestorForSendType): Return type is (id).
2473 Change indexOfObjectIdenticalTo to indexOfObject.
2474 Check if we have local selection before returning self (Bug#8842).
2475 (writeSelectionToPasteboard): Put local selection into paste board
2476 if we have a local selection (Bug#8842).
2477 (syms_of_nsterm): DEFSYM QUTF8_STRING.
2479 * nsterm.h (MAC_OS_X_VERSION_10_6): Define here instead of nsterm.m.
2480 (ns_get_local_selection): Declare.
2482 2011-07-07 Lars Magne Ingebrigtsen <larsi@gnus.org>
2484 * keymap.c (describe_map_tree): Don't insert a double newline at
2485 the end of the buffer (bug#1169) and return whether we inserted
2488 * callint.c (Fcall_interactively): Change "reading args" to
2489 "providing args" to try to clarify what it does (bug#1010).
2491 2011-07-07 Kenichi Handa <handa@m17n.org>
2493 * composite.c (composition_compute_stop_pos): Ignore a static
2494 composition starting before CHARPOS (Bug#8915).
2496 * xdisp.c (handle_composition_prop): Likewise.
2498 2011-07-07 Eli Zaretskii <eliz@gnu.org>
2500 * term.c (produce_glyphs) <xassert>: Allow IT_GLYPHLESS in it->what.
2503 2011-07-07 Kenichi Handa <handa@m17n.org>
2505 * character.h (unicode_category_t): New enum type.
2507 * chartab.c (uniprop_decoder_t, uniprop_encoder_t): New types.
2508 (Qchar_code_property_table): New variable.
2509 (UNIPROP_TABLE_P, UNIPROP_GET_DECODER)
2510 (UNIPROP_COMPRESSED_FORM_P): New macros.
2511 (char_table_ascii): Uncompress the compressed values.
2512 (sub_char_table_ref): New arg is_uniprop. Callers changed.
2513 Uncompress the compressed values.
2514 (sub_char_table_ref_and_range): Likewise.
2515 (char_table_ref_and_range): Uncompress the compressed values.
2516 (sub_char_table_set): New arg is_uniprop. Callers changed.
2517 Uncompress the compressed values.
2518 (sub_char_table_set_range): Args changed. Callers changed.
2519 (char_table_set_range): Adjuted for the above change.
2520 (map_sub_char_table): Delete args default_val and parent. Add arg
2521 top. Give decoded values to a Lisp function.
2522 (map_char_table): Adjust for the above change. Give decoded
2523 values to a Lisp function. Gcpro more variables.
2524 (uniprop_table_uncompress)
2525 (uniprop_decode_value_run_length): New functions.
2526 (uniprop_decoder, uniprop_decoder_count): New variables.
2527 (uniprop_get_decoder, uniprop_encode_value_character)
2528 (uniprop_encode_value_run_length, uniprop_encode_value_numeric):
2530 (uniprop_encoder, uniprop_encoder_count): New variables.
2531 (uniprop_get_encoder, uniprop_table)
2532 (Funicode_property_table_internal, Fget_unicode_property_internal)
2533 (Fput_unicode_property_internal): New functions.
2534 (syms_of_chartab): DEFSYM Qchar_code_property_table, defsubr
2535 Sunicode_property_table_internal, Sget_unicode_property_internal,
2536 and Sput_unicode_property_internal. Defvar_lisp
2537 char-code-property-alist.
2539 * composite.c (CHAR_COMPOSABLE_P): Adjust for the change of
2540 Vunicode_category_table.
2542 * font.c (font_range): Adjust for the change of
2543 Vunicode_category_table.
2545 2011-07-07 Dan Nicolaescu <dann@ics.uci.edu>
2547 * m/iris4d.h: Remove file, move contents ...
2548 * s/irix6-5.h: ... here.
2550 2011-07-06 Paul Eggert <eggert@cs.ucla.edu>
2552 Remove unportable assumption about struct layout (Bug#8884).
2553 * alloc.c (mark_buffer):
2554 * buffer.c (reset_buffer_local_variables, Fbuffer_local_variables)
2555 (clone_per_buffer_values): Don't assume that
2556 sizeof (struct buffer) is a multiple of sizeof (Lisp_Object).
2557 This isn't true in general, and it's particularly not true
2558 if Emacs is configured with --with-wide-int.
2559 * buffer.h (FIRST_FIELD_PER_BUFFER, LAST_FIELD_PER_BUFFER):
2560 New macros, used in the buffer.c change.
2562 2011-07-05 Jan Djärv <jan.h.d@swipnet.se>
2564 * xsettings.c: Use both GConf and GSettings if both are available.
2565 (store_config_changed_event): Add comment.
2566 (dpyinfo_valid, store_font_name_changed, map_tool_bar_style)
2567 (store_tool_bar_style_changed): New functions.
2568 (store_monospaced_changed): Add comment. Call dpyinfo_valid.
2569 (struct xsettings): Move font inside HAVE_XFT.
2570 (GSETTINGS_TOOL_BAR_STYLE, GSETTINGS_FONT_NAME): New defines.
2571 (GSETTINGS_MONO_FONT): Rename from SYSTEM_MONO_FONT.
2572 Move inside HAVE_XFT.
2573 (something_changed_gsettingsCB): Rename from something_changedCB.
2574 Check for changes in GSETTINGS_TOOL_BAR_STYLE and GSETTINGS_FONT_NAME
2576 (GCONF_TOOL_BAR_STYLE, GCONF_FONT_NAME): New defines.
2577 (GCONF_MONO_FONT): Rename from SYSTEM_MONO_FONT. Move inside HAVE_XFT.
2578 (something_changed_gconfCB): Rename from something_changedCB.
2579 Check for changes in GCONF_TOOL_BAR_STYLE and GCONF_FONT_NAME also.
2580 (parse_settings): Move check for font inside HAVE_XFT.
2581 (read_settings, apply_xft_settings): Add comment.
2582 (read_and_apply_settings): Add comment. Call map_tool_bar_style and
2583 store_tool_bar_style_changed. Move check for font inside HAVE_XFT and
2584 call store_font_name_changed.
2585 (xft_settings_event): Add comment.
2586 (init_gsettings): Add comment. Get values for GSETTINGS_TOOL_BAR_STYLE
2587 and GSETTINGS_FONT_NAME. Move check for fonts within HAVE_XFT.
2588 (init_gconf): Add comment. Get values for GCONF_TOOL_BAR_STYLE
2589 and GCONF_FONT_NAME. Move check for fonts within HAVE_XFT.
2590 (xsettings_initialize): Call init_gsettings last.
2591 (xsettings_get_system_font, xsettings_get_system_normal_font):
2594 2011-07-05 Paul Eggert <eggert@cs.ucla.edu>
2596 Random fixes. E.g., (random) never returned negative values.
2597 * fns.c (Frandom): Use GET_EMACS_TIME for random seed, and add the
2598 subseconds part to the entropy, as that's a bit more random.
2599 Prefer signed to unsigned, since the signedness doesn't matter and
2600 in general we prefer signed. When given a limit, use a
2601 denominator equal to INTMASK + 1, not to VALMASK + 1, because the
2602 latter isn't right if USE_2_TAGS_FOR_INTS.
2603 * sysdep.c (get_random): Return a value in the range 0..INTMASK,
2604 not 0..VALMASK. Don't discard "excess" bits that random () returns.
2606 2011-07-04 Stefan Monnier <monnier@iro.umontreal.ca>
2608 * textprop.c (text_property_stickiness):
2609 Obey Vtext_property_default_nonsticky.
2610 (syms_of_textprop): Add `display' to Vtext_property_default_nonsticky.
2611 * w32fns.c (syms_of_w32fns):
2612 * xfns.c (syms_of_xfns): Don't Add `display' since it's there by default.
2614 2011-07-04 Paul Eggert <eggert@cs.ucla.edu>
2616 * fileio.c (barf_or_query_if_file_exists): Use S_ISDIR.
2617 This is more efficient than Ffile_directory_p and avoids a minor race.
2619 2011-07-04 Lars Magne Ingebrigtsen <larsi@gnus.org>
2621 * buffer.c (Foverlay_put): Say what the return value is
2624 * fileio.c (barf_or_query_if_file_exists): Check first if the file
2625 is a directory before asking whether to use the file name
2627 (barf_or_query_if_file_exists): Make the "File is a directory"
2628 error be more correct.
2630 * fns.c (Frequire): Remove the mention of the .gz files, since
2631 that's installation-specific, but keep the mention of
2632 `get-load-suffixes'.
2634 2011-07-04 Paul Eggert <eggert@cs.ucla.edu>
2636 * editfns.c (Fformat_time_string): Don't assume strlen fits in int.
2637 Report string overflow if the output is too long.
2639 2011-07-04 Juanma Barranquero <lekktu@gmail.com>
2641 * gnutls.c (Fgnutls_boot): Don't mention :verify-error.
2642 (syms_of_gnutls): Remove duplicate DEFSYM for
2643 Qgnutls_bootprop_verify_hostname_error, an error for
2644 Qgnutls_bootprop_verify_error (which is no longer used).
2646 * eval.c (find_handler_clause): Remove parameters `sig' and `data',
2647 unused since 2011-01-26T20:02:07Z!monnier@iro.umontreal.ca. All callers changed.
2648 Also (re)move comments that are misplaced or no longer relevant.
2650 2011-07-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
2652 * callint.c (Finteractive): Clarify the meaning of "@" (bug#8813).
2654 2011-07-03 Chong Yidong <cyd@stupidchicken.com>
2656 * xfaces.c (Finternal_merge_in_global_face): Modify the foreground
2657 and background color parameters if they have been changed.
2659 2011-07-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
2661 * editfns.c (Fformat): Clarify the - and 0 flags (bug#6659).
2663 2011-07-03 Paul Eggert <eggert@cs.ucla.edu>
2665 * xsettings.c (SYSTEM_FONT): Define only when used.
2666 No need to define when HAVE_GSETTINGS || !HAVE_XFT.
2668 * keymap.c (access_keymap_1): Now static.
2670 2011-07-02 Chong Yidong <cyd@stupidchicken.com>
2672 * keyboard.c (command_loop_1): If a down-mouse event is unbound,
2673 leave any prefix arg for the up event (Bug#1586).
2675 2011-07-02 Lars Magne Ingebrigtsen <larsi@gnus.org>
2677 * lread.c (syms_of_lread): Mention single symbols defined by
2678 `defvar' or `defconst' (bug#7154).
2680 * fns.c (Frequire): Mention .el.gz files (bug#7314).
2681 (Frequire): Mention get-load-suffixes.
2683 2011-07-02 Martin Rudalics <rudalics@gmx.at>
2685 * window.h (window): Remove clone_number slot.
2686 * window.c (Fwindow_clone_number, Fset_window_clone_number):
2688 (make_parent_window, make_window, saved_window)
2689 (Fset_window_configuration, save_window_save): Don't deal with
2691 * buffer.c (Qclone_number): Remove declaration.
2692 (sort_overlays, overlay_strings): Don't deal with clone numbers.
2694 2011-07-02 Stefan Monnier <monnier@iro.umontreal.ca>
2696 Add multiple inheritance to keymaps.
2697 * keymap.c (Fmake_composed_keymap): New function.
2698 (Fset_keymap_parent): Simplify.
2699 (fix_submap_inheritance): Remove.
2700 (access_keymap_1): New function extracted from access_keymap to handle
2701 embedded parents and handle lists of maps.
2702 (access_keymap): Use it.
2703 (Fkeymap_prompt, map_keymap_internal, map_keymap, store_in_keymap)
2704 (Fcopy_keymap): Handle embedded parents.
2705 (Fcommand_remapping, define_as_prefix): Simplify.
2706 (Fkey_binding): Simplify.
2707 (syms_of_keymap): Move minibuffer-local-completion-map,
2708 minibuffer-local-filename-completion-map,
2709 minibuffer-local-must-match-map, and
2710 minibuffer-local-filename-must-match-map to Elisp.
2711 (syms_of_keymap): Defsubr make-composed-keymap.
2712 * keyboard.c (menu_bar_items): Use map_keymap_canonical.
2713 (parse_menu_item): Trivial simplification.
2715 2011-07-01 Glenn Morris <rgm@gnu.org>
2717 * Makefile.in (SETTINGS_LIBS): Fix typo.
2719 2011-07-01 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny patch)
2721 * coding.c (Fencode_coding_string): Record the last coding system
2722 used, as the function doc string says (bug#8738).
2724 2011-07-01 Jan Djärv <jan.h.d@swipnet.se>
2726 * xsettings.c (store_monospaced_changed): Take new font as arg and
2727 check for change against current_mono_font.
2728 (EMACS_TYPE_SETTINGS): Remove this and related defines.
2729 (emacs_settings_constructor, emacs_settings_get_property)
2730 (emacs_settings_set_property, emacs_settings_class_init)
2731 (emacs_settings_init, gsettings_obj): Remove.
2732 (something_changedCB): New function for HAVE_GSETTINGS.
2733 (something_changedCB): HAVE_GCONF: Call store_monospaced_changed
2734 with value as argument.
2735 (init_gsettings): Check that GSETTINGS_SCHEMA exists before calling
2736 g_settings_new (Bug#8967). Do not create gsettings_obj.
2737 Remove calls to g_settings_bind. Connect something_changedCB to
2740 * xgselect.c: Add defined (HAVE_GSETTINGS).
2741 (xgselect_initialize): Ditto.
2743 * process.c: Add defined (HAVE_GSETTINGS) for xgselect.h
2744 (wait_reading_process_output): Add defined (HAVE_GSETTINGS) for
2747 2011-07-01 Paul Eggert <eggert@cs.ucla.edu>
2749 * eval.c (struct backtrace): Simplify and port the data structure.
2750 Do not assume that "int nargs : BITS_PER_INT - 2;" produces a
2751 signed bit field, as this assumption is not portable and it makes
2752 Emacs crash when compiled with Sun C 5.8 on sparc. Do not use
2753 "char debug_on_exit : 1" as this is not portable either; instead,
2754 use the portable "unsigned int debug_on_exit : 1". Remove unused
2755 member evalargs. Remove obsolete comments about cc bombing out.
2757 2011-06-30 Jan Djärv <jan.h.d@swipnet.se>
2759 * xsettings.c: Include glib-object.h, gio/gio.h if HAVE_GSETTINGS.
2760 Let HAVE_GSETTINGS override HAVE_GCONF.
2761 (store_monospaced_changed): New function.
2762 (EMACS_SETTINGS): A new type derived from GObject to handle
2763 GSettings notifications.
2764 (emacs_settings_constructor, emacs_settings_get_property)
2765 (emacs_settings_set_property, emacs_settings_class_init):
2767 (gsettings_client, gsettings_obj): New variables.
2768 (GSETTINGS_SCHEMA): New define.
2769 (something_changedCB): Call store_monospaced_changed.
2770 (init_gsettings): New function.
2771 (xsettings_initialize): Call init_gsettings.
2772 (syms_of_xsettings): Initialize gsettings_client, gsettings_obj
2775 * Makefile.in (SETTINGS_CFLAGS, SETTINGS_LIBS): Rename from
2778 2011-06-29 Martin Rudalics <rudalics@gmx.at>
2780 * window.c (resize_root_window, grow_mini_window)
2781 (shrink_mini_window): Rename Qresize_root_window to
2782 Qwindow_resize_root_window and Qresize_root_window_vertically to
2783 Qwindow_resize_root_window_vertically.
2785 2011-06-28 Paul Eggert <eggert@cs.ucla.edu>
2787 * gnutls.c (Qgnutls_bootprop_verify_error): Remove unused var.
2789 2011-06-27 Juanma Barranquero <lekktu@gmail.com>
2791 * makefile.w32-in: Redesign dependencies so they reflect more
2792 clearly which files are directly included by each source file,
2793 and not through other includes.
2795 2011-06-27 Martin Rudalics <rudalics@gmx.at>
2797 * buffer.c (Qclone_number): Declare static and DEFSYM it.
2798 (sort_overlays, overlay_strings): When an overlay's clone number
2799 matches the window's clone number process the overlay even if
2800 the overlay's window property doesn't match the current window.
2802 * window.c (Fwindow_vchild): Rename to Fwindow_top_child.
2803 (Fwindow_hchild): Rename to Fwindow_left_child.
2804 (Fwindow_next): Rename to Fwindow_next_sibling.
2805 (Fwindow_prev): Rename to Fwindow_prev_sibling.
2806 (resize_window_check): Rename to window_resize_check.
2807 (resize_window_apply): Rename to window_resize_apply.
2808 (Fresize_window_apply): Rename to Fwindow_resize_apply.
2809 (Fdelete_other_windows_internal, resize_frame_windows)
2810 (Fsplit_window_internal, Fdelete_window_internal)
2811 (grow_mini_window, shrink_mini_window)
2812 (Fresize_mini_window_internal): Fix callers accordingly.
2814 2011-06-26 Jan Djärv <jan.h.d@swipnet.se>
2816 * emacsgtkfixed.h: State that this is only used with Gtk+3.
2817 (emacs_fixed_set_min_size): Remove.
2818 (emacs_fixed_new): Take frame as argument.
2820 * emacsgtkfixed.c: State that this is only used with Gtk+3.
2821 (_EmacsFixedPrivate): Remove minwidth/height.
2822 Add struct frame *f.
2823 (emacs_fixed_init): Initialize priv->f.
2824 (get_parent_class, emacs_fixed_set_min_size): Remove.
2825 (emacs_fixed_new): Set priv->f to argument.
2826 (emacs_fixed_get_preferred_width)
2827 (emacs_fixed_get_preferred_height): Use min_width/height from
2828 frames size_hint to set minimum and natural (Bug#8919).
2829 (XSetWMSizeHints, XSetWMNormalHints): Override these functions
2830 and use min_width/height from frames size_hint to set
2831 min_width/height (Bug#8919).
2833 * gtkutil.c (xg_create_frame_widgets): Pass f to emacs_fixed_new.
2834 (x_wm_set_size_hint): Remove call to emacs_fixed_set_min_size.
2837 2011-06-26 Eli Zaretskii <eliz@gnu.org>
2839 * bidi.c (bidi_paragraph_init): Test for ZV_BYTE before calling
2840 bidi_at_paragraph_end, since fast_looking_at doesn't like to be
2843 2011-06-26 Chong Yidong <cyd@stupidchicken.com>
2845 * process.c (wait_reading_process_output): Bypass select if
2846 waiting for a cell while ignoring keyboard input, and input is
2847 pending. Suggested by Jan Djärv (Bug#8869).
2849 2011-06-25 Paul Eggert <eggert@cs.ucla.edu>
2851 Use gnulib's dup2 module instead of rolling our own.
2852 * sysdep.c (dup2) [!HAVE_DUP2]: Remove; gnulib now does this.
2854 2011-06-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
2856 * dispnew.c (scrolling_window): Before scrolling, turn off a
2857 mouse-highlight in the window being scrolled.
2859 2011-06-24 Juanma Barranquero <lekktu@gmail.com>
2861 Move DEFSYM to lisp.h and use everywhere.
2863 * character.h (DEFSYM): Move declaration...
2864 * lisp.h (DEFSYM): ...here.
2870 * w32select.c: Don't include character.h.
2872 * alloc.c (syms_of_alloc):
2873 * buffer.c (syms_of_buffer):
2874 * bytecode.c (syms_of_bytecode):
2875 * callint.c (syms_of_callint):
2876 * casefiddle.c (syms_of_casefiddle):
2877 * casetab.c (init_casetab_once):
2878 * category.c (init_category_once, syms_of_category):
2879 * ccl.c (syms_of_ccl):
2880 * cmds.c (syms_of_cmds):
2881 * composite.c (syms_of_composite):
2882 * dbusbind.c (syms_of_dbusbind):
2883 * dired.c (syms_of_dired):
2884 * dispnew.c (syms_of_display):
2885 * doc.c (syms_of_doc):
2886 * editfns.c (syms_of_editfns):
2887 * emacs.c (syms_of_emacs):
2888 * eval.c (syms_of_eval):
2889 * fileio.c (syms_of_fileio):
2890 * fns.c (syms_of_fns):
2891 * frame.c (syms_of_frame):
2892 * fringe.c (syms_of_fringe):
2893 * insdel.c (syms_of_insdel):
2894 * keymap.c (syms_of_keymap):
2895 * lread.c (init_obarray, syms_of_lread):
2896 * macros.c (syms_of_macros):
2897 * msdos.c (syms_of_msdos):
2898 * print.c (syms_of_print):
2899 * process.c (syms_of_process):
2900 * search.c (syms_of_search):
2901 * sound.c (syms_of_sound):
2902 * syntax.c (init_syntax_once, syms_of_syntax):
2903 * terminal.c (syms_of_terminal):
2904 * textprop.c (syms_of_textprop):
2905 * undo.c (syms_of_undo):
2906 * w32.c (globals_of_w32):
2907 * window.c (syms_of_window):
2908 * xdisp.c (syms_of_xdisp):
2909 * xfaces.c (syms_of_xfaces):
2910 * xfns.c (syms_of_xfns):
2911 * xmenu.c (syms_of_xmenu):
2912 * xsettings.c (syms_of_xsettings):
2913 * xterm.c (syms_of_xterm): Use DEFSYM.
2915 2011-06-24 Teodor Zlatanov <tzz@lifelogs.com>
2917 * gnutls.c (syms_of_gnutls): Use the DEFSYM macro from character.h.
2919 2011-06-23 Paul Eggert <eggert@cs.ucla.edu>
2921 Integer and buffer overflow fixes (Bug#8873).
2923 * print.c (printchar, strout): Check for string overflow.
2924 (PRINTPREPARE, printchar, strout):
2925 Don't set size unless allocation succeeds.
2927 * minibuf.c (read_minibuf_noninteractive): Use ptrdiff_t, not int,
2928 for sizes. Check for string overflow more accurately.
2929 Simplify newline removal at end; this suppresses a GCC 4.6.0 warning.
2931 * macros.c: Integer and buffer overflow fixes.
2932 * keyboard.h (struct keyboard.kbd_macro_bufsize):
2933 * macros.c (Fstart_kbd_macro, store_kbd_macro_char):
2934 Use ptrdiff_t, not int, for sizes.
2935 Don't increment bufsize until after realloc succeeds.
2936 Check for size-calculation overflow.
2937 (Fstart_kbd_macro): Use EMACS_INT, not int, for XINT result.
2939 * lisp.h (DEFVAR_KBOARD): Use offsetof instead of char * finagling.
2941 * lread.c: Integer overflow fixes.
2942 (read_integer): Radix is now EMACS_INT, not int,
2943 to improve quality of diagnostics for out-of-range radices.
2944 Calculate buffer size correctly for out-of-range radices.
2945 (read1): Check for integer overflow in radices, and in
2946 read-circle numbers.
2947 (read_escape): Avoid int overflow.
2948 (Fload, openp, read_buffer_size, read1)
2949 (substitute_object_recurse, read_vector, read_list, map_obarray):
2950 Use ptrdiff_t, not int, for sizes.
2951 (read1): Use EMACS_INT, not int, for sizes.
2952 Check for size overflow.
2954 * image.c (cache_image): Check for size arithmetic overflow.
2956 * lread.c: Integer overflow issues.
2957 (saved_doc_string_size, saved_doc_string_length)
2958 (prev_saved_doc_string_size, prev_saved_doc_string_length):
2959 Now ptrdiff_t, not int.
2960 (read1): Don't assume doc string length fits in int. Check for
2961 out-of-range doc string lengths.
2962 (read_list): Don't assume file position fits in int.
2963 (read_escape): Check for hex character overflow.
2965 2011-06-22 Leo Liu <sdl.web@gmail.com>
2967 * minibuf.c (Fcompleting_read_default, Vcompleting_read_function):
2968 Move to minibuffer.el.
2970 2011-06-22 Paul Eggert <eggert@cs.ucla.edu>
2972 Fixes for GLYPH_DEBUG found by GCC 4.6.0 static checking.
2973 The following patches are for when GLYPH_DEBUG && !XASSERT.
2974 * dispextern.h (trace_redisplay_p, dump_glyph_string):
2975 * dispnew.c (flush_stdout):
2976 * xdisp.c (dump_glyph_row, dump_glyph_matrix, dump_glyph):
2977 Mark as externally visible.
2978 * dispnew.c (check_window_matrix_pointers): Now static.
2979 * dispnew.c (window_to_frame_vpos):
2980 * xfns.c (unwind_create_frame):
2981 * xterm.c (x_check_font): Remove unused local.
2982 * scroll.c (CHECK_BOUNDS):
2983 * xfaces.c (cache_fache): Rename local to avoid shadowing.
2984 * xfns.c, w32fns.c (image_cache_refcount, dpyinfo_refcount): Now static.
2985 * xdisp.c (check_window_end): Now a no-op if !XASSERTS.
2986 (debug_first_unchanged_at_end_vpos, debug_last_unchanged_at_beg_vpos)
2987 (debug_dvpos, debug_dy, debug_delta, debug_delta_bytes, debug_end_vpos):
2989 (debug_method_add): Use va_list and vsprintf rather than relying
2990 on undefined behavior with wrong number of arguments.
2991 (dump_glyph, dump_glyph_row, Fdump_glyph_matrix):
2992 Don't assume ptrdiff_t and EMACS_INT are the same width as int.
2993 In this code, it's OK to assume C99 behavior for ptrdiff_t formats
2994 since we're not interested in debugging glyphs with old libraries.
2995 * xfaces.c (cache_face): Move debugging code earlier; this pacifies
2996 GCC 4.6.0's static checking.
2998 2011-06-22 Paul Eggert <eggert@cs.ucla.edu>
3000 Integer overflow and signedness fixes (Bug#8873).
3001 A few related buffer overrun fixes, too.
3003 * font.c (font_score): Use EMACS_INT, not int, to store XINT value.
3005 * dispextern.h (struct face.stipple):
3006 * image.c (x_bitmap_height, x_bitmap_width, x_bitmap_pixmap)
3007 (x_bitmap_mask, x_allocate_bitmap_record)
3008 (x_create_bitmap_from_data, x_create_bitmap_from_file)
3009 (x_destroy_bitmap, x_destroy_all_bitmaps, x_create_bitmap_mask)
3010 (x_create_bitmap_from_xpm_data):
3011 * nsterm.h (struct ns_display_info.bitmaps_size, .bitmaps_last):
3012 * w32term.h (struct w32_display_info.icon_bitmap_id, .bitmaps_size)
3014 * xfaces.c (load_pixmap):
3015 * xterm.c (x_bitmap_icon, x_wm_set_icon_pixmap):
3016 * xterm.h (struct x_display_info.icon_bitmap_id, .bitmaps_size)
3017 (.bitmaps_last, struct x_output.icon_bitmap):
3018 Use ptrdiff_t, not int, for bitmap indexes.
3019 (x_allocate_bitmap_record): Check for size overflow.
3020 * dispextern.h, lisp.h: Adjust to API changes elsewhere.
3022 Use ptrdiff_t, not int, for overlay counts.
3023 * buffer.h (overlays_at, sort_overlays, GET_OVERLAYS_AT):
3024 * editfns.c (overlays_around, get_pos_property):
3025 * textprop.c (get_char_property_and_overlay):
3026 * xdisp.c (next_overlay_change, note_mouse_highlight):
3027 * xfaces.c (face_at_buffer_position):
3028 * buffer.c (OVERLAY_COUNT_MAX): New macro.
3029 (overlays_at, overlays_in, sort_overlays, Foverlays_at)
3030 (Fnext_overlay_change, Fprevious_overlay_change)
3031 (mouse_face_overlay_overlaps, Foverlays_in):
3032 Use ptrdiff_t, not int, for sizes.
3033 (overlays_at, overlays_in): Check for size-calculation overflow.
3035 * xterm.c (xim_initialize, same_x_server): Strlen may not fit in int.
3037 * xsmfns.c (smc_save_yourself_CB, x_session_initialize): Avoid strlen.
3038 (x_session_initialize): Do not assume string length fits in int.
3040 * xsettings.c (apply_xft_settings): Fix potential buffer overrun.
3041 This is unlikely, but can occur if DPI is outlandish.
3043 * xsettings.c (Ffont_get_system_normal_font, Ffont_get_system_font):
3044 * xselect.c (Fx_get_atom_name): Avoid need for strlen.
3046 * xrdb.c: Don't assume strlen fits in int; avoid some strlens.
3047 * xrdb.c (magic_file_p, search_magic_path):
3048 Omit last arg SUFFIX; it was always 0. All callers changed.
3049 (magic_file_p): Use ptrdiff_t, not int. Check for size overflow.
3051 * xfont.c (xfont_match): Avoid need for strlen.
3053 * xfns.c: Don't assume strlen fits in int.
3054 (xic_create_fontsetname, x_window): Use ptrdiff_t, not int.
3056 * xdisp.c (message_log_check_duplicate): Return intmax_t,
3057 not unsigned long, as we prefer signed integers. All callers changed.
3058 Detect integer overflow in repeat count.
3059 (message_dolog): Don't assume print length fits in 39 bytes.
3060 (display_mode_element): Don't assume strlen fits in int.
3062 * termcap.c: Don't assume sizes fit in int and never overflow.
3063 (struct termcap_buffer, tgetent): Use ptrdiff_t, not int, for sizes.
3064 (gobble_line): Check for size-calculation overflow.
3066 * minibuf.c (Fread_buffer):
3067 * lread.c (intern, intern_c_string):
3068 * image.c (xpm_scan) [HAVE_NS && !HAVE_XPM]:
3069 Don't assume string length fits in int.
3071 * keyboard.c (parse_tool_bar_item):
3072 * gtkutil.c (style_changed_cb): Avoid need for strlen.
3074 * font.c: Don't assume string length fits in int.
3075 (font_parse_xlfd, font_parse_fcname, font_unparse_fcname):
3076 Use ptrdiff_t, not int.
3077 (font_intern_prop): Don't assume string length fits in int.
3078 Don't assume integer property fits in fixnum.
3079 * font.h (font_intern_prop): 2nd arg is now ptrdiff_t, not int.
3081 * filelock.c: Fix some buffer overrun and integer overflow issues.
3082 (get_boot_time): Don't assume gzip command string fits in 100 bytes.
3083 Reformulate so as not to need the command string.
3084 Invoke gzip -cd rather than gunzip, as it's more portable.
3085 (lock_info_type, lock_file_1, lock_file):
3086 Don't assume pid_t and time_t fit in unsigned long.
3087 (LOCK_PID_MAX): Remove; we now use more-reliable bounds.
3088 (current_lock_owner): Prefer signed type for sizes.
3089 Use memcpy, not strncpy, where memcpy is what is really wanted.
3090 Don't assume (via atoi) that time_t and pid_t fit in int.
3091 Check for time_t and/or pid_t out of range, e.g., via a network share.
3092 Don't alloca where an auto var works fine.
3094 * fileio.c: Fix some integer overflow issues.
3095 (file_name_as_directory, Fexpand_file_name, Fsubstitute_in_file_name):
3096 Don't assume string length fits in int.
3097 (directory_file_name): Don't assume string length fits in long.
3098 (make_temp_name): Don't assume pid fits in int, or that its print
3099 length is less than 20.
3101 * data.c (Fsubr_name): Rewrite to avoid a strlen call.
3103 * coding.c (make_subsidiaries): Don't assume string length fits in int.
3105 * callproc.c (child_setup): Rewrite to avoid two strlen calls.
3107 * process.c (Fformat_network_address): Use EMACS_INT, not EMACS_UINT.
3108 We prefer signed integers, even for size calculations.
3110 * emacs.c: Don't assume string length fits in 'int'.
3111 (DEFINE_DUMMY_FUNCTION, sort_args): Use ptrdiff_t, not int.
3112 (main): Don't invoke strlen when not needed.
3114 * dbusbind.c (XD_ERROR): Don't arbitrarily truncate string.
3115 (XD_DEBUG_MESSAGE): Don't waste a byte.
3117 * callproc.c (getenv_internal_1, getenv_internal)
3119 * buffer.c (init_buffer): Don't assume string length fits in 'int'.
3121 * lread.c (invalid_syntax): Omit length argument.
3122 All uses changed. This doesn't fix a bug, but it simplifies the
3123 code away from its former Hollerith-constant appearance, and it's
3124 one less 'int' to worry about when looking at integer-overflow issues.
3125 (string_to_number): Simplify 2011-04-26 change by invoking xsignal1.
3127 * lisp.h (DEFUN): Remove bogus use of sizeof (struct Lisp_Subr).
3128 This didn't break anything, but it didn't help either.
3129 It's confusing to put a bogus integer in a place where the actual
3130 value does not matter.
3131 (LIST_END_P): Remove unused macro and its bogus comment.
3132 (make_fixnum_or_float): Remove unnecessary cast to EMACS_INT.
3134 * lisp.h (union Lisp_Object.i): EMACS_INT, not EMACS_UINT.
3135 This is for consistency with the ordinary, non-USE_LISP_UNION_TYPE,
3137 (struct Lisp_Bool_Vector.size): EMACS_INT, not EMACS_UINT.
3138 We prefer signed types, and the value cannot exceed the EMACS_INT
3139 range anyway (because otherwise the length would not be representable).
3140 (XSET) [USE_LISP_UNION_TYPE]: Use uintptr_t and intptr_t,
3141 not EMACS_UINT and EMACS_INT, when converting pointer to integer.
3142 This avoids a GCC warning when WIDE_EMACS_INT.
3144 * indent.c (sane_tab_width): New function.
3145 (current_column, scan_for_column, Findent_to, position_indentation)
3146 (compute_motion): Use it. This is just for clarity.
3147 (Fcompute_motion): Don't assume hscroll and tab offset fit in int.
3149 * image.c (xbm_image_p): Don't assume stated width, height fit in int.
3151 * lisp.h (lint_assume): New macro.
3152 * composite.c (composition_gstring_put_cache):
3153 * ftfont.c (ftfont_shape_by_flt): Use it to pacify GCC 4.6.0.
3155 * editfns.c, insdel.c:
3156 Omit unnecessary forward decls, to simplify future changes.
3158 * ftfont.c (ftfont_shape_by_flt): Use signed integers for lengths.
3160 * font.c (Ffont_shape_gstring): Don't assume glyph len fits in 'int'.
3162 * fns.c (Ffillarray): Don't assume bool vector size fits in 'int'.
3163 Use much-faster test for byte-length change.
3164 Don't assume string byte-length fits in 'int'.
3165 Check that character arg fits in 'int'.
3166 (mapcar1): Declare byte as byte, for clarity.
3168 * alloc.c (Fmake_bool_vector): Avoid unnecessary multiplication.
3170 * fns.c (concat): Catch string overflow earlier.
3171 Do not rely on integer wraparound.
3173 * dispextern.h (struct it.overlay_strings_charpos)
3174 (struct it.selective): Now EMACS_INT, not int.
3175 * xdisp.c (forward_to_next_line_start)
3176 (back_to_previous_visible_line_start)
3177 (reseat_at_next_visible_line_start, next_element_from_buffer):
3178 Don't arbitrarily truncate the value of 'selective' to int.
3180 * xdisp.c (init_iterator): Use XINT, not XFASTINT; it might be < 0.
3182 * composite.c: Don't truncate sizes to 'int'.
3183 (composition_gstring_p, composition_reseat_it)
3184 (composition_adjust_point): Use EMACS_INT, not int.
3185 (get_composition_id, composition_gstring_put_cache): Use EMACS_INT,
3186 not EMACS_UINT, for indexes.
3188 * category.h (CATEGORY_SET_P): Remove unnecessary cast to EMACS_INT.
3190 * buffer.c: Include <verify.h>.
3191 (struct sortvec.priority, struct sortstr.priority):
3192 Now EMACS_INT, not int.
3193 (compare_overlays, cmp_for_strings): Avoid subtraction overflow.
3194 (struct sortstr.size, record_overlay_string)
3195 (struct sortstrlist.size, struct sortlist.used):
3196 Don't truncate size to int.
3197 (record_overlay_string): Check for size-calculation overflow.
3198 (init_buffer_once): Check at compile-time, not run-time.
3200 2011-06-22 Jim Meyering <meyering@redhat.com>
3202 Don't leak an XBM-image-sized buffer
3203 * image.c (xbm_load): Free the image buffer after using it.
3205 2011-06-21 Paul Eggert <eggert@cs.ucla.edu>
3208 * composite.c (find_automatic_composition): Omit needless 'return 0;'
3209 that Sun C diagnosed.
3210 * fns.c (secure_hash): Fix pointer signedness issue.
3211 * intervals.c (static_offset_intervals): New function.
3212 (offset_intervals): Use it.
3214 2011-06-21 Leo Liu <sdl.web@gmail.com>
3217 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha256.h and
3220 * fns.c (secure_hash): Rename from crypto_hash_function and change
3221 the first arg to accept symbols.
3222 (Fsecure_hash): New primitive.
3223 (syms_of_fns): New symbols.
3225 2011-06-20 Deniz Dogan <deniz@dogan.se>
3227 * process.c (Fset_process_buffer): Clarify return value in
3230 2011-06-18 Chong Yidong <cyd@stupidchicken.com>
3232 * dispnew.c (add_window_display_history): Use BVAR.
3234 * xdisp.c (debug_method_add): Use BVAR.
3235 (check_window_end, dump_glyph_matrix, dump_glyph)
3236 (dump_glyph_row, dump_glyph_string): Convert arglist to ANSI C.
3238 * xfaces.c (check_lface_attrs, check_lface, dump_realized_face):
3241 * xfns.c (Fx_create_frame, x_create_tip_frame): Delay image cache
3242 check till after the cache is created in init_frame_faces.
3244 2011-06-17 Stefan Monnier <monnier@iro.umontreal.ca>
3246 * fns.c (Fsafe_length): Yet another int/Lisp_Object mixup.
3248 2011-06-16 Paul Eggert <eggert@cs.ucla.edu>
3250 * lisp.h: Include <limits.h>, for INT_MAX, LONG_MAX, LLONG_MAX.
3251 Without this, prin1 mishandles Lisp_Misc_Save_Value printing on
3252 hosts with pre-C99 libraries, because pD is wrongly defined to "t".
3254 Improve buffer-overflow checking (Bug#8873).
3255 * fileio.c (Finsert_file_contents):
3256 * insdel.c (insert_from_buffer_1, replace_range, replace_range_2):
3257 Remove the old (too-loose) buffer overflow checks.
3258 They weren't needed, since make_gap checks for buffer overflow.
3259 * insdel.c (make_gap_larger): Catch buffer overflows that were missed.
3260 The old code merely checked for Emacs fixnum overflow, and relied
3261 on undefined (wraparound) behavior. The new code avoids undefined
3262 behavior, and also checks for ptrdiff_t and/or size_t overflow.
3264 * editfns.c (Finsert_char): Don't dump core with very negative counts.
3265 Tune. Don't use wider integers than needed. Don't use alloca.
3266 Use a bigger 'string' buffer. Rewrite to avoid 'n > 0' test.
3268 * insdel.c (replace_range): Fix buf overflow when insbytes < outgoing.
3270 * insdel.c, lisp.h (buffer_overflow): New function.
3271 (insert_from_buffer_1, replace_range, replace_range_2):
3272 * insdel.c (make_gap_larger):
3273 * editfns.c (Finsert_char):
3274 * fileio.c (Finsert_file_contents): Use it, to normalize wording.
3276 * buffer.h (BUF_BYTES_MAX): Cast to ptrdiff_t so that it's signed.
3278 2011-06-15 Paul Eggert <eggert@cs.ucla.edu>
3280 Integer overflow and signedness fixes (Bug#8873).
3282 * ccl.c (ASCENDING_ORDER): New macro, to work around GCC bug 43772.
3283 (GET_CCL_RANGE, IN_INT_RANGE): Use it.
3285 * fileio.c: Don't assume EMACS_INT fits in off_t.
3286 (emacs_lseek): New static function.
3287 (Finsert_file_contents, Fwrite_region): Use it.
3288 Use SEEK_SET, SEEK_CUR, SEEK_END as appropriate.
3290 * fns.c (Fload_average): Don't assume 100 * load average fits in int.
3292 * fns.c: Don't overflow int when computing a list length.
3293 * fns.c (QUIT_COUNT_HEURISTIC): New constant.
3294 (Flength, Fsafe_length): Use EMACS_INT, not int, to avoid unwanted
3295 truncation on 64-bit hosts. Check for QUIT every
3296 QUIT_COUNT_HEURISTIC entries rather than every other entry; that's
3297 faster and is responsive enough.
3298 (Flength): Report an error instead of overflowing an integer.
3299 (Fsafe_length): Return a float if the value is not representable
3300 as a fixnum. This shouldn't happen except in contrived situations.
3301 (Fnthcdr, Fsort): Don't assume list length fits in int.
3302 (Fcopy_sequence): Don't assume vector length fits in int.
3304 * alloc.c: Check that resized vectors' lengths fit in fixnums.
3305 (header_size, word_size): New constants.
3306 (allocate_vectorlike): Don't check size overflow here.
3307 (allocate_vector): Check it here instead, since this is the only
3308 caller of allocate_vectorlike that could cause overflow.
3309 Check that the new vector's length is representable as a fixnum.
3311 * fns.c (next_almost_prime): Don't return a multiple of 3 or 5.
3312 The previous code was bogus. For example, next_almost_prime (32)
3313 returned 39, which is undesirable as it is a multiple of 3; and
3314 next_almost_prime (24) returned 25, which is a multiple of 5 so
3315 why was the code bothering to check for multiples of 7?
3317 * bytecode.c (exec_byte_code): Use ptrdiff_t, not int, for vector length.
3319 * eval.c, doprnt.c (SIZE_MAX): Remove; inttypes.h defines this now.
3321 Variadic C functions now count arguments with ptrdiff_t.
3322 This partly undoes my 2011-03-30 change, which replaced int with size_t.
3323 Back then I didn't know that the Emacs coding style prefers signed int.
3324 Also, in the meantime I found a few more instances where arguments
3325 were being counted with int, which may truncate counts on 64-bit
3326 machines, or EMACS_INT, which may be unnecessarily wide.
3327 * lisp.h (struct Lisp_Subr.function.aMANY)
3328 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call):
3329 Arg counts are now ptrdiff_t, not size_t.
3330 All variadic functions and their callers changed accordingly.
3331 (struct gcpro.nvars): Now size_t, not size_t. All uses changed.
3332 * bytecode.c (exec_byte_code): Check maxdepth for overflow,
3333 to avoid potential buffer overrun. Don't assume arg counts fit in 'int'.
3334 * callint.c (Fcall_interactively): Check arg count for overflow,
3335 to avoid potential buffer overrun. Use signed char, not 'int',
3336 for 'varies' array, so that we needn't bother to check its size
3337 calculation for overflow.
3338 * editfns.c (Fformat): Use ptrdiff_t, not EMACS_INT, to count args.
3339 * eval.c (apply_lambda):
3340 * fns.c (Fmapconcat): Use XFASTINT, not XINT, to get args length.
3341 (struct textprop_rec.argnum): Now ptrdiff_t, not int. All uses changed.
3342 (mapconcat): Use ptrdiff_t, not int and EMACS_INT, to count args.
3344 * callint.c (Fcall_interactively): Don't use index var as event count.
3346 * vm-limit.c (check_memory_limits): Fix incorrect extern function decls.
3347 * mem-limits.h (SIZE): Remove; no longer used.
3349 * xterm.c (x_alloc_nearest_color_1): Prefer int to long when int works.
3351 Remove unnecessary casts.
3352 * xterm.c (x_term_init):
3353 * xfns.c (x_set_border_pixel):
3354 * widget.c (create_frame_gcs): Remove casts to unsigned long etc.
3355 These aren't needed now that we assume ANSI C.
3357 * sound.c (Fplay_sound_internal): Remove cast to unsigned long.
3358 It's more likely to cause problems (due to unsigned overflow)
3361 * dired.c (Ffile_attributes): Don't use 32-bit hack on 64-bit hosts.
3363 * unexelf.c (unexec): Don't assume BSS addr fits in unsigned.
3365 * xterm.c (handle_one_xevent): Omit unnecessary casts to unsigned.
3367 * keyboard.c (modify_event_symbol): Don't limit alist len to UINT_MAX.
3369 * lisp.h (CHAR_TABLE_SET): Omit now-redundant test.
3371 * lread.c (Fload): Don't compare a possibly-garbage time_t value.
3373 GLYPH_CODE_FACE returns EMACS_INT, not int.
3374 * dispextern.h (merge_faces):
3375 * xfaces.c (merge_faces):
3376 * xdisp.c (get_next_display_element, next_element_from_display_vector):
3377 Don't assume EMACS_INT fits in int.
3379 * character.h (CHAR_VALID_P): Remove unused parameter.
3380 * fontset.c, lisp.h, xdisp.c: All uses changed.
3382 * editfns.c (Ftranslate_region_internal): Omit redundant test.
3384 * fns.c (concat): Minor tuning based on overflow analysis.
3385 This doesn't fix any bugs. Use int to hold character, instead
3386 of constantly refetching from Emacs object. Use XFASTINT, not
3387 XINT, for value known to be a character. Don't bother comparing
3388 a single byte to 0400, as it's always less.
3390 * floatfns.c (Fexpt):
3391 * fileio.c (make_temp_name): Omit unnecessary cast to unsigned.
3393 * editfns.c (Ftranslate_region_internal): Use int, not EMACS_INT
3396 * doc.c (get_doc_string): Omit (unsigned)c that mishandled negatives.
3398 * data.c (Faset): If ARRAY is a string, check that NEWELT is a char.
3399 Without this fix, on a 64-bit host (aset S 0 4294967386) would
3400 incorrectly succeed when S was a string, because 4294967386 was
3401 truncated before it was used.
3403 * chartab.c (Fchar_table_range): Use CHARACTERP to check range.
3404 Otherwise, an out-of-range integer could cause undefined behavior
3407 * composite.c: Use int, not EMACS_INT, for characters.
3408 (fill_gstring_body, composition_compute_stop_pos): Use int, not
3409 EMACS_INT, for values that are known to be in character range.
3410 This doesn't fix any bugs but is the usual style inside Emacs and
3411 may generate better code on 32-bit machines.
3413 Make sure a 64-bit char is never passed to ENCODE_CHAR.
3414 This is for reasons similar to the recent CHAR_STRING fix.
3415 * charset.c (Fencode_char): Check that character arg is actually
3416 a character. Pass an int to ENCODE_CHAR.
3417 * charset.h (ENCODE_CHAR): Verify that the character argument is no
3418 wider than 'int', as a compile-time check to prevent future regressions
3421 * character.c (char_string): Remove unnecessary casts.
3423 Make sure a 64-bit char is never passed to CHAR_STRING.
3424 Otherwise, CHAR_STRING would do the wrong thing on a 64-bit platform,
3425 by silently ignoring the top 32 bits, allowing some values
3426 that were far too large to be valid characters.
3427 * character.h: Include <verify.h>.
3428 (CHAR_STRING, CHAR_STRING_ADVANCE): Verify that the character
3429 arguments are no wider than unsigned, as a compile-time check
3430 to prevent future regressions in this area.
3432 * editfns.c (Fchar_to_string, general_insert_function, Finsert_char)
3433 (Fsubst_char_in_region):
3435 * xdisp.c (decode_mode_spec_coding):
3436 Adjust to CHAR_STRING's new requirement.
3437 * editfns.c (Finsert_char, Fsubst_char_in_region):
3438 * fns.c (concat): Check that character args are actually
3439 characters. Without this test, these functions did the wrong
3440 thing with wildly out-of-range values on 64-bit hosts.
3442 Remove incorrect casts to 'unsigned' that lose info on 64-bit hosts.
3443 These casts should not be needed on 32-bit hosts, either.
3444 * keyboard.c (read_char):
3445 * lread.c (Fload): Remove casts to unsigned.
3447 * lisp.h (UNSIGNED_CMP): New macro.
3448 This fixes comparison bugs on 64-bit hosts.
3449 (ASCII_CHAR_P): Use it.
3450 * casefiddle.c (casify_object):
3451 * character.h (ASCII_BYTE_P, CHAR_VALID_P)
3452 (SINGLE_BYTE_CHAR_P, CHAR_STRING):
3453 * composite.h (COMPOSITION_ENCODE_RULE_VALID):
3454 * dispextern.h (FACE_FROM_ID):
3455 * keyboard.c (read_char): Use UNSIGNED_CMP.
3457 * xmenu.c (dialog_selection_callback) [!USE_GTK]: Cast to intptr_t,
3458 not to EMACS_INT, to avoid GCC warning.
3460 * xfns.c (x_set_scroll_bar_default_width): Remove unused 'int' locals.
3462 * buffer.h (PTR_BYTE_POS, BUF_PTR_BYTE_POS): Remove harmful cast.
3463 The cast incorrectly truncated 64-bit byte offsets to 32 bits, and
3464 isn't needed on 32-bit machines.
3466 * buffer.c (Fgenerate_new_buffer_name):
3467 Use EMACS_INT for count, not int.
3468 (advance_to_char_boundary): Return EMACS_INT, not int.
3470 * data.c (Qcompiled_function): Now static.
3472 * window.c (window_body_lines): Now static.
3474 * image.c (gif_load): Rename local to avoid shadowing.
3476 * lisp.h (SAFE_ALLOCA_LISP): Check for integer overflow.
3477 (struct Lisp_Save_Value): Use ptrdiff_t, not int, for 'integer' member.
3478 * alloc.c (make_save_value): Integer argument is now of type
3480 (mark_object): Use ptrdiff_t, not int.
3481 * lisp.h (pD): New macro.
3482 * print.c (print_object): Use it.
3484 * alloc.c: Use EMACS_INT, not int, to count objects.
3485 (total_conses, total_markers, total_symbols, total_vector_size)
3486 (total_free_conses, total_free_markers, total_free_symbols)
3487 (total_free_floats, total_floats, total_free_intervals)
3488 (total_intervals, total_strings, total_free_strings):
3489 Now EMACS_INT, not int. All uses changed.
3490 (Fgarbage_collect): Compute overall total using a double, so that
3491 integer overflow is less likely to be a problem. Check for overflow
3492 when converting back to an integer.
3493 (n_interval_blocks, n_string_blocks, n_float_blocks, n_cons_blocks)
3494 (n_vectors, n_symbol_blocks, n_marker_blocks): Remove.
3495 These were 'int' variables that could overflow on 64-bit hosts;
3496 they were never used, so remove them instead of repairing them.
3497 (nzombies, ngcs, max_live, max_zombies): Now EMACS_INT, not 'int'.
3498 (inhibit_garbage_collection): Set gc_cons_threshold to max value.
3499 Previously, this ceilinged at INT_MAX, but that doesn't work on
3501 (allocate_pseudovector): Don't use EMACS_INT when int would do.
3503 * alloc.c (Fmake_bool_vector): Don't assume vector size fits in int.
3504 (allocate_vectorlike): Check for ptrdiff_t overflow.
3505 (mark_vectorlike, mark_char_table, mark_object): Avoid EMACS_UINT
3506 when a (possibly-narrower) signed value would do just as well.
3507 We prefer using signed arithmetic, to avoid comparison confusion.
3509 * alloc.c: Catch some string size overflows that we were missing.
3510 (XMALLOC_OVERRUN_CHECK_SIZE) [!XMALLOC_OVERRUN_CHECK]: Define to 0,
3511 for convenience in STRING_BYTES_MAX.
3512 (STRING_BYTES_MAX): New macro, superseding the old one in lisp.h.
3513 The definition here is exact; the one in lisp.h was approximate.
3514 (allocate_string_data): Check for string overflow. This catches
3515 some instances we weren't catching before. Also, it catches
3516 size_t overflow on (unusual) hosts where SIZE_MAX <= min
3517 (PTRDIFF_MAX, MOST_POSITIVE_FIXNUM), e.g., when size_t is 32 bits
3518 and ptrdiff_t and EMACS_INT are both 64 bits.
3520 * character.c, coding.c, doprnt.c, editfns.c, eval.c:
3521 All uses of STRING_BYTES_MAX replaced by STRING_BYTES_BOUND.
3522 * lisp.h (STRING_BYTES_BOUND): Rename from STRING_BYTES_MAX.
3524 * character.c (string_escape_byte8): Fix nbytes/nchars typo.
3526 * alloc.c (Fmake_string): Check for out-of-range init.
3528 2011-06-15 Stefan Monnier <monnier@iro.umontreal.ca>
3530 * eval.c (Fdefvaralias): Also mark the target as variable-special-p.
3532 2011-06-14 Jan Djärv <jan.h.d@swipnet.se>
3534 * xfns.c (x_set_scroll_bar_default_width): Remove argument to
3535 xg_get_default_scrollbar_width.
3537 * gtkutil.c: Include emacsgtkfixed.h if HAVE_GTK3.
3538 (int_gtk_range_get_value): Move to the scroll bar part of the file.
3539 (style_changed_cb): Call update_theme_scrollbar_width and call
3540 x_set_scroll_bar_default_width and xg_frame_set_char_size for
3541 all frames (Bug#8505).
3542 (xg_create_frame_widgets): Call emacs_fixed_new if HAVE_GTK3 (Bug#8505).
3543 Call gtk_window_set_resizable if HAVE_GTK3.
3544 (x_wm_set_size_hint): Call emacs_fixed_set_min_size with min width
3545 and height if HAVE_GTK3 (Bug#8505).
3546 (scroll_bar_width_for_theme): New variable.
3547 (update_theme_scrollbar_width): New function.
3548 (xg_get_default_scrollbar_width): Move code to
3549 update_theme_scrollbar_width, just return scroll_bar_width_for_theme.
3550 (xg_initialize): Call update_theme_scrollbar_width.
3552 * gtkutil.h (xg_get_default_scrollbar_width): Remove argument.
3554 * emacsgtkfixed.c, emacsgtkfixed.h: New files.
3556 2011-06-12 Martin Rudalics <rudalics@gmx.at>
3558 * frame.c (make_frame): Call other_buffer_safely instead of
3561 * window.c (temp_output_buffer_show): Call display_buffer with
3562 second argument Vtemp_buffer_show_specifiers and reset latter
3563 immediately after the call.
3564 (Vtemp_buffer_show_specifiers): New variable.
3565 (auto_window_vscroll_p, next_screen_context_lines)
3566 (Vscroll_preserve_screen_position): Remove leading asterisks from
3569 2011-06-12 Paul Eggert <eggert@cs.ucla.edu>
3571 Fix minor problems found by GCC 4.6.0 static checking.
3572 * buffer.c (Qclone_number): Remove for now, as it's unused.
3573 (record_buffer, Funrecord_buffer): Rename local to avoid shadowing.
3574 (record_buffer): Remove unused local.
3575 * frame.c (other_visible_frames, frame_buffer_list): Now static.
3576 (set_frame_buffer_list): Remove; unused.
3577 * frame.h (other_visible_frames): Remove decl.
3578 * keyboard.h (menu_items_inuse): Declare only if USE_GTK || USE_MOTIF.
3579 * lisp.h (frame_buffer_list, set_frame_buffer_list): Remove decls.
3580 (add_gpm_wait_descriptor, delete_gpm_wait_descriptor): Declare only
3582 * menu.c (menu_items_inuse): Now static unless USE_GTK || USE_MOTIF.
3583 * process.c (add_gpm_wait_descriptor, delete_gpm_wait_descriptor):
3584 Define only if HAVE_GPM.
3585 * widget.c (EmacsFrameResize, emacsFrameClassRec): Now static.
3586 (update_hints_inhibit): Remove; never set. All uses removed.
3587 * widgetprv.h (emacsFrameClassRec): Remove decl.
3588 * window.c (delete_deletable_window): Now returns void, since it
3589 wasn't returning anything.
3590 (compare_window_configurations): Remove unused locals.
3591 * xfns.c (x_set_scroll_bar_default_width): Remove unused locals.
3592 * xmenu.c (x_menu_set_in_use): Define only if USE_GTK || USE_MOTIF.
3593 (dialog_selection_callback) [!USE_GTK]: Prefer intptr_t for integers
3594 the same widths as pointers. This follows up on the 2011-05-06 patch.
3595 * xterm.c (x_alloc_lighter_color_for_widget): Define only if USE_LUCID.
3596 * xterm.h: Likewise.
3597 (x_menu_set_in_use): Declare only if USE_GTK || USE_MOTIF.
3599 2011-06-12 Juanma Barranquero <lekktu@gmail.com>
3601 * makefile.w32-in: Update dependencies.
3602 (LISP_H): Add lib/intprops.h.
3604 2011-06-11 Chong Yidong <cyd@stupidchicken.com>
3606 * image.c (gif_load): Add animation frame delay to the metadata.
3607 (syms_of_image): Use DEFSYM. New symbol `delay'.
3609 2011-06-11 Martin Rudalics <rudalics@gmx.at>
3611 * window.c (delete_deletable_window): Re-add.
3612 (Fset_window_configuration): Rewrite to handle dead buffers and
3613 consequently deletable windows.
3614 (window_tree, Fwindow_tree): Remove. Supply functionality in
3616 (compare_window_configurations): Simplify code.
3618 2011-06-11 Andreas Schwab <schwab@linux-m68k.org>
3620 * image.c (imagemagick_load_image): Fix type mismatch.
3621 (Fimagemagick_types): Likewise.
3623 * window.h (replace_buffer_in_windows): Declare.
3625 2011-06-11 Martin Rudalics <rudalics@gmx.at>
3627 * buffer.c: New Lisp objects Qbuffer_list_update_hook and
3628 Qclone_number. Remove external declaration of Qdelete_window.
3629 (Fbuffer_list): Rewrite doc-string. Minor restructuring of
3631 (Fget_buffer_create, Fmake_indirect_buffer, Frename_buffer):
3632 Run Qbuffer_list_update_hook if allowed.
3633 (Fother_buffer): Rewrite doc-string. Major rewrite for new
3634 buffer list implementation.
3635 (other_buffer_safely): New function.
3636 (Fkill_buffer): Replace call to replace_buffer_in_all_windows by
3637 calls to replace_buffer_in_windows and
3638 replace_buffer_in_windows_safely. Run Qbuffer_list_update_hook
3640 (record_buffer): Inhibit quitting and rewrite using quittable
3641 functions. Run Qbuffer_list_update_hook if allowed.
3642 (Frecord_buffer, Funrecord_buffer): New functions.
3643 (switch_to_buffer_1, Fswitch_to_buffer): Remove.
3644 Move switch-to-buffer to window.el.
3645 (bury-buffer): Move to window.el.
3646 (Vbuffer_list_update_hook): New variable.
3648 * lisp.h (other_buffer_safely): Add prototype in buffer.c
3651 * window.h (resize_frame_windows): Move up in code.
3652 (Fwindow_frame): Remove EXFUN.
3653 (replace_buffer_in_all_windows): Remove prototype.
3654 (replace_buffer_in_windows_safely): Add prototype.
3656 * window.c: Declare Qdelete_window static again. Move down
3657 declaration of select_count.
3658 (Fnext_window, Fprevious_window): Rewrite doc-strings.
3659 (Fother_window): Move to window.el.
3660 (window_loop): Remove DELETE_BUFFER_WINDOWS and UNSHOW_BUFFER
3661 cases. Add REPLACE_BUFFER_IN_WINDOWS_SAFELY case.
3662 (Fdelete_windows_on, Freplace_buffer_in_windows): Move to
3664 (replace_buffer_in_windows): Implement by calling
3665 Qreplace_buffer_in_windows.
3666 (replace_buffer_in_all_windows): Remove with some functionality
3667 moved into replace_buffer_in_windows_safely.
3668 (replace_buffer_in_windows_safely): New function.
3669 (select_window_norecord, select_frame_norecord): Move in front
3670 of run_window_configuration_change_hook. Remove now obsolete
3672 (Fset_window_buffer): Rewrite doc-string.
3673 Call Qrecord_window_buffer.
3674 (keys_of_window): Move binding for other-window to window.el.
3676 2011-06-11 Chong Yidong <cyd@stupidchicken.com>
3678 * dispextern.h (struct image): Replace data member, whose int_val
3679 and ptr_val fields were not used by anything, with a single
3682 * image.c (Fimage_metadata, make_image, mark_image, tiff_load)
3683 (gif_clear_image, gif_load, imagemagick_load_image)
3684 (gs_clear_image, gs_load): Callers changed.
3686 2011-06-10 Paul Eggert <eggert@cs.ucla.edu>
3688 * buffer.h: Include <time.h>, for time_t.
3689 Needed to build on FreeBSD 8.2. Problem reported by Herbert J. Skuhra.
3691 Fix minor problems found by static checking.
3693 * image.c (PixelGetMagickColor): Declare if ImageMagick headers don't.
3695 Make identifiers static if they are not used in other modules.
3696 * data.c (Qcompiled_function, Qframe, Qvector):
3697 * image.c (QimageMagick, Qsvg):
3698 * minibuf.c (Qmetadata):
3699 * window.c (resize_window_check, resize_root_window): Now static.
3700 * window.h (resize_window_check, resize_root_window): Remove decls.
3702 * window.c (window_deletion_count, delete_deletable_window):
3704 (window_body_lines): Now static.
3705 (Fdelete_other_windows_internal): Mark vars as initialized.
3706 Make sure 'resize_failed' is initialized.
3707 (run_window_configuration_change_hook): Rename local to avoid shadowing.
3708 (resize_window_apply): Remove unused local.
3709 * window.h (delete_deletable_window): Remove decl.
3711 * image.c (gif_load, svg_load_image): Rename locals to avoid shadowing.
3712 (imagemagick_load_image): Fix pointer signedness problem by changing
3713 last arg from unsigned char * to char *. All uses changed.
3714 Also, fix a local for similar reasons.
3715 Remove unused locals. Remove locals to avoid shadowing.
3716 (fn_rsvg_handle_free): Remove; unused.
3717 (svg_load, svg_load_image): Fix pointer signedness problem.
3718 (imagemagick_load_image): Don't use garbage pointer image_wand.
3720 * ftfont.c (ftfont_get_metrics, ftfont_drive_otf): Remove unused locals.
3722 2011-06-10 Chong Yidong <cyd@stupidchicken.com>
3724 * image.c (gif_load): Fix omitted cast error introduced by
3727 2011-06-10 Martin Rudalics <rudalics@gmx.at>
3729 * window.h (resize_proportionally, orig_total_lines)
3730 (orig_top_line): Remove from window structure.
3731 (set_window_height, set_window_width, change_window_heights)
3732 (Fdelete_window): Remove prototypes.
3733 (resize_frame_windows): Remove duplicate declaration.
3735 2011-06-10 Eli Zaretskii <eliz@gnu.org>
3737 * window.h (resize_frame_windows, resize_window_check)
3738 (delete_deletable_window, resize_root_window)
3739 (resize_frame_windows): Declare prototypes.
3741 * window.c (resize_window_apply): Make definition be "static" to
3742 match the prototype.
3744 2011-06-10 Martin Rudalics <rudalics@gmx.at>
3746 * window.c: Remove declarations of Qwindow_size_fixed,
3747 window_min_size_1, window_min_size_2, window_min_size,
3748 size_window, window_fixed_size_p, enlarge_window, delete_window.
3749 Remove static from declaration of Qdelete_window, it's
3750 temporarily needed by Fbury_buffer.
3751 (replace_window): Don't assign orig_top_line and
3753 (Fdelete_window, delete_window): Remove. Window deletion is
3754 handled by window.el.
3755 (window_loop): Remove DELETE_OTHER_WINDOWS case.
3756 Replace Fdelete_window calls with calls to Qdelete_window.
3757 (Fdelete_other_windows): Remove. Deleting other windows is
3758 handled by window.el.
3759 (window_fixed_size_p): Remove. Fixed-sizeness of windows is
3760 handled in window.el.
3761 (window_min_size_2, window_min_size_1, window_min_size): Remove.
3762 Window minimum sizes are handled in window.el.
3763 (shrink_windows, size_window, set_window_height)
3764 (set_window_width, change_window_heights, window_height)
3765 (window_width, CURBEG, CURSIZE, enlarge_window)
3766 (adjust_window_trailing_edge, Fadjust_window_trailing_edge)
3767 (Fenlarge_window, Fshrink_window): Remove. Window resizing is
3768 handled in window.el.
3769 (make_dummy_parent): Rename to make_parent_window and give it a
3770 second argument horflag.
3771 (make_window): Don't set resize_proportionally any more.
3772 (Fsplit_window): Remove. Windows are split in window.el.
3773 (save_restore_action, save_restore_orig_size)
3774 (shrink_window_lowest_first, save_restore_orig_size): Remove.
3775 Resize mini windows in window.el.
3776 (grow_mini_window, shrink_mini_window): Implement by calling
3777 Qresize_root_window_vertically, resize_window_check and
3778 resize_window_apply.
3779 (saved_window, Fset_window_configuration, save_window_save):
3780 Do not handle orig_top_line, orig_total_lines, and
3781 resize_proportionally.
3782 (window_min_height, window_min_width): Move to window.el.
3783 (keys_of_window): Move bindings for delete-other-windows,
3784 split-window, delete-window and enlarge-window to window.el.
3786 * buffer.c: Temporarily extern Qdelete_window.
3787 (Fbury_buffer): Temporarily call Qdelete_window instead of
3788 Fdelete_window (Fbury_buffer will move to window.el soon).
3790 * frame.c (set_menu_bar_lines_1): Remove code handling
3791 orig_top_line and orig_total_lines.
3793 * dispnew.c (adjust_frame_glyphs_initially): Don't use
3794 set_window_height but set heights directly.
3795 (change_frame_size_1): Use resize_frame_windows.
3797 * xdisp.c (init_xdisp): Don't use set_window_height but set
3800 * xfns.c (x_set_menu_bar_lines, x_set_tool_bar_lines):
3801 Use resize_frame_windows instead of change_window_heights and run
3802 run_window_configuration_change_hook.
3804 * w32fns.c (x_set_tool_bar_lines): Use resize_frame_windows
3805 instead of change_window_heights and run
3806 run_window_configuration_change_hook.
3808 2011-06-09 Martin Rudalics <rudalics@gmx.at>
3810 * window.c (replace_window): Rename second argument REPLACEMENT to
3811 NEW. New third argument SETFLAG. Rewrite.
3812 (delete_window, make_dummy_parent): Call replace_window with
3814 (window_list_1): Move down in code.
3815 (run_window_configuration_change_hook): Move set_buffer part
3816 before select_frame_norecord part in order to unwind correctly.
3817 Rename count1 to count.
3818 (recombine_windows, delete_deletable_window, resize_root_window)
3819 (Fdelete_other_windows_internal)
3820 (Frun_window_configuration_change_hook, make_parent_window)
3821 (resize_window_check, resize_window_apply, Fresize_window_apply)
3822 (resize_frame_windows, Fsplit_window_internal)
3823 (Fdelete_window_internal, Fresize_mini_window_internal):
3825 (syms_of_window): New variables Vwindow_splits and Vwindow_nest.
3827 2011-06-08 Martin Rudalics <rudalics@gmx.at>
3829 * window.h (window): Add some new members to window structure -
3830 normal_lines, normal_cols, new_total, new_normal, clone_number,
3831 splits, nest, prev_buffers, next_buffers.
3832 (WINDOW_TOTAL_SIZE): Move here from window.c.
3833 (MIN_SAFE_WINDOW_WIDTH, MIN_SAFE_WINDOW_HEIGHT): Define here.
3835 * window.c (Fwindow_height, Fwindow_width, Fwindow_full_width_p):
3837 (make_dummy_parent): Set new members of windows structure.
3838 (make_window): Move down in code. Handle new members of window
3840 (Fwindow_clone_number, Fwindow_splits, Fset_window_splits)
3841 (Fwindow_nest, Fset_window_nest, Fwindow_new_total)
3842 (Fwindow_normal_size, Fwindow_new_normal, Fwindow_prev_buffers)
3843 (Fset_window_prev_buffers, Fwindow_next_buffers)
3844 (Fset_window_next_buffers, Fset_window_clone_number):
3846 (Fwindow_hscroll, Fwindow_at, Fwindow_point, Fwindow_start)
3847 (Fwindow_end, Fwindow_line_height, Fset_window_dedicated_p):
3849 (Fwindow_parameters, Fwindow_parameter, Fset_window_parameter):
3850 Argument WINDOW can be now internal window too.
3851 (Fwindow_use_time): Move up in code.
3852 (Fget_buffer_window): Rename argument FRAME to ALL-FRAMES.
3854 (Fset_window_configuration, saved_window)
3855 (Fcurrent_window_configuration, save_window_save): Handle new
3856 members of window structure.
3857 (WINDOW_TOTAL_SIZE, MIN_SAFE_WINDOW_WIDTH)
3858 (MIN_SAFE_WINDOW_HEIGHT): Move to window.h.
3859 (syms_of_window): New Lisp objects Qrecord_window_buffer,
3860 Qwindow_deletable_p, Qdelete_window, Qreplace_buffer_in_windows,
3861 Qget_mru_window, Qresize_root_window,
3862 Qresize_root_window_vertically, Qsafe, Qabove, Qbelow,
3863 Qauto_buffer_name; staticpro them.
3865 2011-06-07 Martin Rudalics <rudalics@gmx.at>
3867 * window.c (Fwindow_total_size, Fwindow_left_column)
3868 (Fwindow_top_line, window_body_lines, Fwindow_body_size)
3869 (Fwindow_list_1): New functions.
3870 (window_box_text_cols): Replace with window_body_cols.
3871 (Fwindow_width, Fscroll_left, Fscroll_right):
3872 Use window_body_cols instead of window_box_text_cols.
3873 (delete_window, Fset_window_configuration):
3874 Call delete_all_subwindows with window as argument.
3875 (delete_all_subwindows): Take a window as argument and not a
3877 (window_loop): Remove handling of GET_LRU_WINDOW and
3879 (Fget_lru_window, Fget_largest_window): Move to window.el.
3881 * window.h: Extern window_body_cols instead of
3882 window_box_text_cols. delete_all_subwindows now takes a
3883 Lisp_Object as argument.
3885 * indent.c (compute_motion, Fcompute_motion):
3886 Use window_body_cols instead of window_box_text_cols.
3888 * frame.c (delete_frame): Call delete_all_subwindows with root
3891 2011-06-07 Daniel Colascione <dan.colascione@gmail.com>
3893 * fns.c (Fputhash): Document return value.
3895 2011-06-06 Chong Yidong <cyd@stupidchicken.com>
3897 * image.c (gif_load): Implement gif89a spec "no disposal" method.
3899 2011-06-06 Paul Eggert <eggert@cs.ucla.edu>
3901 Cons<->int and similar integer overflow fixes (Bug#8794).
3903 Check for overflow when converting integer to cons and back.
3904 * charset.c (Fdefine_charset_internal, Fdecode_char):
3905 Use cons_to_unsigned to catch overflow.
3906 (Fencode_char): Use INTEGER_TO_CONS.
3907 * composite.h (LGLYPH_CODE): Use cons_to_unsigned.
3908 (LGLYPH_SET_CODE): Use INTEGER_TO_CONS.
3909 * data.c (long_to_cons, cons_to_long): Remove.
3910 (cons_to_unsigned, cons_to_signed): New functions.
3911 These signal an error for invalid or out-of-range values.
3912 * dired.c (Ffile_attributes): Use INTEGER_TO_CONS.
3913 * fileio.c (Fset_visited_file_modtime): Use CONS_TO_INTEGER.
3914 * font.c (Ffont_variation_glyphs):
3915 * fontset.c (Finternal_char_font): Use INTEGER_TO_CONS.
3916 * lisp.h: Include <intprops.h>.
3917 (INTEGER_TO_CONS, CONS_TO_INTEGER): New macros.
3918 (cons_to_signed, cons_to_unsigned): New decls.
3919 (long_to_cons, cons_to_long): Remove decls.
3920 * undo.c (record_first_change): Use INTEGER_TO_CONS.
3921 (Fprimitive_undo): Use CONS_TO_INTEGER.
3922 * xfns.c (Fx_window_property): Likewise.
3923 * xselect.c: Include <limits.h>.
3924 (x_own_selection, selection_data_to_lisp_data):
3925 Use INTEGER_TO_CONS.
3926 (x_handle_selection_request, x_handle_selection_clear)
3927 (x_get_foreign_selection, Fx_disown_selection_internal)
3928 (Fx_get_atom_name, x_send_client_event): Use CONS_TO_INTEGER.
3929 (lisp_data_to_selection_data): Use cons_to_unsigned.
3930 (x_fill_property_data): Use cons_to_signed.
3931 Report values out of range.
3933 Check for buffer and string overflow more precisely.
3934 * buffer.h (BUF_BYTES_MAX): New macro.
3935 * lisp.h (STRING_BYTES_MAX): New macro.
3936 * alloc.c (Fmake_string):
3937 * character.c (string_escape_byte8):
3938 * coding.c (coding_alloc_by_realloc):
3939 * doprnt.c (doprnt):
3940 * editfns.c (Fformat):
3942 Use STRING_BYTES_MAX, not MOST_POSITIVE_FIXNUM,
3943 since they may not be the same number.
3944 * editfns.c (Finsert_char):
3945 * fileio.c (Finsert_file_contents):
3946 Likewise for BUF_BYTES_MAX.
3948 * image.c: Use ptrdiff_t, not int, for sizes.
3949 (slurp_file): Switch from int to ptrdiff_t.
3951 (slurp_file): Check that file size fits in both size_t (for
3952 malloc) and ptrdiff_t (for sanity and safety).
3954 * fileio.c (Fverify_visited_file_modtime): Avoid time overflow
3955 if b->modtime has its maximal value.
3957 * dired.c (Ffile_attributes): Don't assume EMACS_INT has >32 bits.
3959 Don't assume time_t can fit into int.
3960 * buffer.h (struct buffer.modtime): Now time_t, not int.
3961 * fileio.c (Fvisited_file_modtime): No need for time_t cast now.
3962 * undo.c (Fprimitive_undo): Use time_t, not int, for time_t value.
3964 Minor fixes for signed vs unsigned integers.
3965 * character.h (MAYBE_UNIFY_CHAR):
3966 * charset.c (maybe_unify_char):
3967 * keyboard.c (read_char, reorder_modifiers):
3968 XINT -> XFASTINT, since the integer must be nonnegative.
3969 * ftfont.c (ftfont_spec_pattern):
3970 * keymap.c (access_keymap, silly_event_symbol_error):
3971 XUINT -> XFASTINT, since the integer must be nonnegative.
3972 (Fsingle_key_description, preferred_sequence_p): XUINT -> XINT,
3973 since it makes no difference and we prefer signed.
3974 * keyboard.c (record_char): Use XUINT when all the neighbors do.
3975 (access_keymap): NATNUMP -> INTEGERP, since the integer must be
3978 2011-06-06 Stefan Monnier <monnier@iro.umontreal.ca>
3980 * window.h (Fwindow_frame): Declare.
3982 2011-06-06 Paul Eggert <eggert@cs.ucla.edu>
3984 * alloc.c: Simplify handling of large-request failures (Bug#8800).
3985 (SPARE_MEMORY): Always define.
3986 (LARGE_REQUEST): Remove.
3987 (memory_full): Use SPARE_MEMORY rather than LARGE_REQUEST.
3989 2011-06-06 Martin Rudalics <rudalics@gmx.at>
3991 * lisp.h: Move EXFUNS for Fframe_root_window,
3992 Fframe_first_window and Fset_frame_selected_window to window.h.
3994 * window.h: Move EXFUNS for Fframe_root_window,
3995 Fframe_first_window and Fset_frame_selected_window here from
3998 * frame.c (Fwindow_frame, Fframe_first_window)
3999 (Fframe_root_window, Fframe_selected_window)
4000 (Fset_frame_selected_window): Move to window.c.
4001 (Factive_minibuffer_window): Move to minibuf.c.
4002 (Fother_visible_frames_p): New function.
4004 * minibuf.c (Factive_minibuffer_window): Move here from frame.c.
4006 * window.c (decode_window, decode_any_window): Move up in code.
4007 (Fwindowp, Fwindow_live_p): Rewrite doc-strings.
4008 (inhibit_frame_unsplittable): Remove unused variable.
4009 (Fwindow_buffer): Move up and rewrite doc-string.
4010 (Fwindow_parent, Fwindow_vchild, Fwindow_hchild, Fwindow_next)
4011 (Fwindow_prev): New functions.
4012 (Fwindow_frame): Move here from frame.c. Accept any window as
4014 (Fframe_root_window, Fframe_first_window)
4015 (Fframe_selected_window): Move here from frame.c. Accept frame
4016 or arbitrary window as argument. Update doc-strings.
4017 (Fminibuffer_window): Move up in code.
4018 (Fwindow_minibuffer_p): Move up in code and simplify.
4019 (Fset_frame_selected_window): Move here from frame.c.
4021 (Fselected_window, select_window, Fselect_window): Move up in
4022 code. Minor doc-string fixes.
4024 2011-06-06 Paul Eggert <eggert@cs.ucla.edu>
4026 * alloc.c (memory_full) [SYSTEM_MALLOC]: Port to MacOS (Bug#8800).
4027 Do not assume that spare memory exists; that assumption is valid
4028 only if SYSTEM_MALLOC.
4029 (LARGE_REQUEST): New macro, so that the issue of large requests
4030 is separated from the issue of spare memory.
4032 2011-06-05 Andreas Schwab <schwab@linux-m68k.org>
4034 * editfns.c (Fformat): Correctly handle zero flag with hexadecimal
4037 * gtkutil.c (xg_get_default_scrollbar_width): Avoid warning.
4039 * xfns.c (x_set_scroll_bar_default_width): Move declarations
4042 2011-06-05 Jan Djärv <jan.h.d@swipnet.se>
4044 * gtkutil.c (xg_get_default_scrollbar_width): New function.
4046 * gtkutil.h: Declare xg_get_default_scrollbar_width.
4048 * xfns.c (x_set_scroll_bar_default_width): If USE_GTK, get
4049 min width by calling x_set_scroll_bar_default_width (Bug#8505).
4051 2011-06-05 Juanma Barranquero <lekktu@gmail.com>
4053 * xdisp.c (single_display_spec_intangible_p): Remove declaration.
4055 2011-06-04 Chong Yidong <cyd@stupidchicken.com>
4057 * xselect.c (x_clipboard_manager_save): Remove redundant arg.
4058 (x_clipboard_manager_save): Add return value.
4059 (x_clipboard_manager_error_1, x_clipboard_manager_error_2):
4061 (x_clipboard_manager_save_frame, x_clipboard_manager_save_all):
4062 Obey Vx_select_enable_clipboard_manager. Catch errors in
4063 x_clipboard_manager_save (Bug#8779).
4064 (Vx_select_enable_clipboard_manager): New variable.
4065 (x_get_foreign_selection): Reduce scope of x_catch_errors (Bug#8790).
4067 2011-06-04 Dan Nicolaescu <dann@ics.uci.edu>
4069 * emacs.c (main): Warn when starting a GTK emacs in daemon mode.
4071 2011-06-04 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
4073 * fringe.c (update_window_fringes): Don't update overlay arrow bitmap
4074 in the current matrix if keep_current_p is non-zero.
4076 2011-06-04 Eli Zaretskii <eliz@gnu.org>
4078 * bidi.c (bidi_level_of_next_char): Fix last change.
4080 2011-06-03 Eli Zaretskii <eliz@gnu.org>
4082 Support bidi reordering of text covered by display properties.
4084 * bidi.c (bidi_copy_it): Use offsetof instead of emulating it.
4085 (bidi_fetch_char, bidi_fetch_char_advance): New functions.
4086 (bidi_cache_search, bidi_cache_iterator_state)
4087 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak)
4088 (bidi_level_of_next_char, bidi_move_to_visually_next):
4089 Support character positions inside a run of characters covered by a
4091 (bidi_paragraph_init, bidi_resolve_explicit_1)
4092 (bidi_level_of_next_char): Call bidi_fetch_char and
4093 bidi_fetch_char_advance instead of FETCH_CHAR and
4095 (bidi_init_it): Initialize new members.
4096 (LRE_CHAR, RLE_CHAR, PDF_CHAR, LRO_CHAR, RLO_CHAR): Remove macro
4098 (bidi_explicit_dir_char): Lookup character type in bidi_type_table,
4099 instead of using explicit *_CHAR codes.
4100 (bidi_resolve_explicit, bidi_resolve_weak):
4101 Use FETCH_MULTIBYTE_CHAR instead of FETCH_CHAR, as reordering of
4102 bidirectional text is supported only in multibyte buffers.
4103 (bidi_init_it): Accept additional argument FRAME_WINDOW_P and use
4104 it to initialize the frame_window_p member of struct bidi_it.
4105 (bidi_cache_iterator_state, bidi_resolve_explicit_1)
4106 (bidi_resolve_explicit, bidi_resolve_weak)
4107 (bidi_level_of_next_char, bidi_move_to_visually_next): Abort if
4108 bidi_it->nchars is non-positive.
4109 (bidi_level_of_next_char): Don't try to lookup the cache for the
4110 next/previous character if nothing is cached there yet, or if we
4111 were just reseat()'ed to a new position.
4113 * xdisp.c (set_cursor_from_row): Set start and stop points
4114 according to the row's direction when priming the loop that looks
4115 for the glyph on which to display cursor.
4116 (single_display_spec_intangible_p): Function deleted.
4117 (display_prop_intangible_p): Reimplement to call
4118 handle_display_spec instead of single_display_spec_intangible_p.
4119 Accept 3 additional arguments needed by handle_display_spec.
4120 This fixes incorrect cursor motion across display property with complex
4121 values: lists, `(when COND...)' forms, etc.
4122 (single_display_spec_string_p): Support property values that are
4123 lists with the argument STRING its top-level element.
4124 (display_prop_string_p): Fix the condition for processing a
4125 property that is a list to be consistent with handle_display_spec.
4126 (handle_display_spec): New function, refactored from the
4127 last portion of handle_display_prop.
4128 (compute_display_string_pos): Accept additional argument
4129 FRAME_WINDOW_P. Call handle_display_spec to determine whether the
4130 value of a `display' property is a "replacing spec".
4131 (handle_single_display_spec): Accept 2 additional arguments BUFPOS
4132 and FRAME_WINDOW_P. If IT is NULL, don't set up the iterator from
4133 the display property, but just return a value indicating whether
4134 the display property will replace the characters it covers.
4135 (Fcurrent_bidi_paragraph_direction): Initialize the nchars and
4136 frame_window_p members of struct bidi_it.
4137 (compute_display_string_pos, compute_display_string_end):
4139 (push_it): Accept second argument POSITION, where pop_it should
4140 jump to continue iteration.
4141 (reseat_1): Initialize bidi_it.disp_pos.
4143 * keyboard.c (adjust_point_for_property): Adjust the call to
4144 display_prop_intangible_p to its new signature.
4146 * dispextern.h (struct bidi_it): New member frame_window_p.
4147 (bidi_init_it): Update prototypes.
4148 (display_prop_intangible_p): Update prototype.
4149 (compute_display_string_pos, compute_display_string_end):
4151 (struct bidi_it): New members nchars and disp_pos. ch_len is now
4154 2011-06-02 Paul Eggert <eggert@cs.ucla.edu>
4156 Malloc failure behavior now depends on size of allocation.
4157 * alloc.c (buffer_memory_full, memory_full): New arg NBYTES.
4158 * lisp.h: Change signatures accordingly.
4159 * alloc.c, buffer.c, editfns.c, menu.c, minibuf.c, xterm.c:
4160 All callers changed. (Bug#8762)
4162 * gnutls.c: Use Emacs's memory allocators.
4163 Without this change, the gnutls library would invoke malloc etc.
4164 directly, which causes problems on non-SYNC_INPUT hosts, and which
4165 runs afoul of improving memory_full behavior. (Bug#8761)
4166 (fn_gnutls_global_set_mem_functions): New macro or function pointer.
4167 (emacs_gnutls_global_init): Use it to specify xmalloc, xrealloc,
4168 xfree instead of the default malloc, realloc, free.
4169 (Fgnutls_boot): No need to check for memory allocation failure,
4170 since xmalloc does that for us.
4172 Remove arbitrary limit of 2**31 entries in hash tables. (Bug#8771)
4173 * category.c (hash_get_category_set):
4174 * ccl.c (ccl_driver):
4175 * charset.c (Fdefine_charset_internal):
4176 * charset.h (struct charset.hash_index):
4177 * composite.c (get_composition_id, gstring_lookup_cache)
4178 (composition_gstring_put_cache):
4179 * composite.h (struct composition.hash_index):
4180 * dispextern.h (struct image.hash):
4181 * fns.c (next_almost_prime, larger_vector, cmpfn_eql)
4182 (cmpfn_equal, cmpfn_user_defined, hashfn_eq, hashfn_eql)
4183 (hashfn_equal, hashfn_user_defined, make_hash_table)
4184 (maybe_resize_hash_table, hash_lookup, hash_put)
4185 (hash_remove_from_table, hash_clear, sweep_weak_table, SXHASH_COMBINE)
4186 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector)
4187 (Fsxhash, Fgethash, Fputhash, Fmaphash):
4188 * image.c (make_image, search_image_cache, lookup_image)
4189 (xpm_put_color_table_h):
4190 * lisp.h (struct Lisp_Hash_Table):
4191 * minibuf.c (Ftry_completion, Fall_completions, Ftest_completion):
4192 * print.c (print): Use 'EMACS_UINT' and 'EMACS_INT'
4193 for hashes and hash indexes, instead of 'unsigned' and 'int'.
4194 * alloc.c (allocate_vectorlike):
4195 Check for overflow in vector size calculations.
4196 * ccl.c (ccl_driver):
4197 Check for overflow when converting EMACS_INT to int.
4198 * fns.c, image.c: Remove unnecessary static decls that would otherwise
4199 need to be updated by these changes.
4200 * fns.c (make_hash_table, maybe_resize_hash_table):
4201 Check for integer overflow with large hash tables.
4202 (make_hash_table, maybe_resize_hash_table, Fmake_hash_table):
4203 Prefer the faster XFLOAT_DATA to XFLOATINT where either will do.
4204 (SXHASH_REDUCE): New macro.
4205 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector):
4206 Use it instead of discarding useful hash info with large hash values.
4207 (sxhash_float): New function.
4208 (sxhash): Use it. No more need for "& INTMASK" due to above changes.
4209 * lisp.h (FIXNUM_BITS): New macro, useful for SXHASH_REDUCE etc.
4210 (MOST_NEGATIVE_FIXNUM, MOST_POSITIVE_FIXNUM, INTMASK):
4211 Rewrite to use FIXNUM_BITS, as this simplifies things.
4212 (next_almost_prime, larger_vector, sxhash, hash_lookup, hash_put):
4213 Adjust signatures to match updated version of code.
4214 (consing_since_gc): Now EMACS_INT, since a single hash table can
4215 use more than INT_MAX bytes.
4217 2011-06-01 Dan Nicolaescu <dann@ics.uci.edu>
4219 Make it possible to build with GCC-4.6+ -O2 -flto.
4221 * emacs.c (__malloc_initialize_hook): Mark as EXTERNALLY_VISIBLE.
4223 2011-06-01 Stefan Monnier <monnier@iro.umontreal.ca>
4225 * minibuf.c (get_minibuffer, read_minibuf_unwind):
4226 Call minibuffer-inactive-mode.
4228 2011-05-31 Juanma Barranquero <lekktu@gmail.com>
4230 * makefile.w32-in ($(BLD)/data.$(O), $(BLD)/editfns.$(O)):
4231 Update dependencies.
4233 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
4235 * data.c (init_data): Remove code for UTS, this system is not
4238 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
4240 Don't force ./temacs to start in terminal mode.
4242 * frame.c (make_initial_frame): Initialize faces in all cases, not
4243 only when CANNOT_DUMP is defined.
4244 * dispnew.c (init_display): Remove CANNOT_DUMP condition.
4246 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
4248 * dispnew.c (add_window_display_history): Use const for the string
4249 pointer. Remove declaration, not needed.
4251 2011-05-31 Paul Eggert <eggert@cs.ucla.edu>
4253 Use 'inline', not 'INLINE'.
4254 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00914.html>
4255 * alloc.c, fontset.c (INLINE): Remove.
4256 * alloc.c, bidi.c, charset.c, coding.c, dispnew.c, fns.c, image.c:
4257 * intervals.c, keyboard.c, process.c, syntax.c, textprop.c, w32term.c:
4258 * xdisp.c, xfaces.c, xterm.c: Replace all uses of INLINE with inline.
4259 * gmalloc.c (register_heapinfo): Use inline unconditionally.
4260 * lisp.h (LISP_MAKE_RVALUE): Use inline, not __inline__.
4262 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
4264 Make it possible to run ./temacs.
4266 * callproc.c (set_initial_environment): Remove CANNOT_DUMP code,
4267 syms_of_callproc does the same thing. Remove test for
4268 "initialized", do it in the caller.
4269 * emacs.c (main): Avoid calling set_initial_environment when dumping.
4271 2011-05-31 Stefan Monnier <monnier@iro.umontreal.ca>
4273 * minibuf.c (Finternal_complete_buffer): Return `category' metadata.
4274 (read_minibuf): Use get_minibuffer.
4275 (syms_of_minibuf): Use DEFSYM.
4276 (Qmetadata): New var.
4277 * data.c (Qbuffer): Don't make it static.
4278 (syms_of_data): Use DEFSYM.
4280 2011-05-31 Paul Eggert <eggert@cs.ucla.edu>
4282 * ccl.c (CCL_CODE_RANGE): Allow negative numbers. (Bug#8751)
4283 (CCL_CODE_MIN): New macro.
4285 2011-05-30 Paul Eggert <eggert@cs.ucla.edu>
4287 * alloc.c (lisp_align_malloc): Omit unnecessary val==NULL tests.
4289 * eval.c (Qdebug): Now static.
4290 * lisp.h (Qdebug): Remove decl. This reverts a part of the
4291 2011-04-26T11:26:05Z!dan.colascione@gmail.com that inadvertently undid part of
4292 2011-04-14T06:48:41Z!eggert@cs.ucla.edu.
4294 2011-05-29 Chong Yidong <cyd@stupidchicken.com>
4296 * image.c: Various fixes to ImageMagick code comments.
4297 (Fimagemagick_types): Doc fix.
4299 2011-05-29 Paul Eggert <eggert@cs.ucla.edu>
4301 Minor fixes prompted by GCC 4.6.0 warnings.
4303 * xselect.c (converted_selections, conversion_fail_tag): Now static.
4305 * emacs.c [HAVE_X_WINDOWS]: Include "xterm.h".
4306 (x_clipboard_manager_save_all): Move extern decl to ...
4307 * xterm.h: ... here, so that it can be checked for consistency.
4309 2011-05-29 Chong Yidong <cyd@stupidchicken.com>
4311 * xselect.c (x_clipboard_manager_save_frame)
4312 (x_clipboard_manager_save_all): New functions.
4313 (Fx_clipboard_manager_save): Lisp function deleted.
4315 * emacs.c (Fkill_emacs): Call x_clipboard_manager_save_all.
4316 * frame.c (delete_frame): Call x_clipboard_manager_save_frame.
4318 * xterm.h: Update prototype.
4320 2011-05-28 William Xu <william.xwl@gmail.com>
4322 * nsterm.m (ns_term_shutdown): Synchronize user defaults before
4325 2011-05-28 Jim Meyering <meyering@redhat.com>
4327 Avoid a sign-extension bug in crypto_hash_function.
4328 * fns.c (to_uchar): Define.
4329 (crypto_hash_function): Use it to convert some newly-signed
4330 variables to unsigned, to avoid sign-extension bugs. For example,
4331 without this change, (md5 "truc") would evaluate to
4332 45723a2aff78ff4fff7fff1114760e62 rather than the expected
4333 45723a2af3788c4ff17f8d1114760e62. Reported by Antoine Levitt in
4334 https://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00883.html.
4336 2011-05-27 Paul Eggert <eggert@cs.ucla.edu>
4338 Integer overflow fixes.
4340 * dbusbind.c: Serial number integer overflow fixes.
4341 (CHECK_DBUS_SERIAL_GET_SERIAL): New macro.
4342 (Fdbus_call_method_asynchronously, xd_read_message_1): Use a float
4343 to hold a serial number that is too large for a fixnum.
4344 (Fdbus_method_return_internal, Fdbus_method_error_internal):
4345 Check for serial numbers out of range. Decode any serial number
4346 that was so large that it became a float. (Bug#8722)
4348 * dbusbind.c: Use XFASTINT rather than XUINT, and check for nonneg.
4349 (Fdbus_call_method, Fdbus_call_method_asynchronously):
4350 Use XFASTINT rather than XUINT when numbers are nonnegative.
4351 (xd_append_arg, Fdbus_method_return_internal):
4352 (Fdbus_method_error_internal): Likewise. Also, for unsigned
4353 arguments, check that Lisp number is nonnegative, rather than
4354 silently wrapping negative numbers around. (Bug#8722)
4355 (xd_read_message_1): Don't assume dbus_uint32_t can fit in int.
4358 * data.c (arith_driver, Flsh): Avoid unnecessary casts to EMACS_UINT.
4360 * ccl.c (ccl_driver): Redo slightly to avoid the need for 'unsigned'.
4362 ccl: add integer overflow checks
4363 * ccl.c (CCL_CODE_MAX, GET_CCL_RANGE, GET_CCL_CODE, GET_CCL_INT):
4364 (IN_INT_RANGE): New macros.
4365 (ccl_driver): Use them to check for integer overflow when
4366 decoding a CCL program. Many of the new checks are whether XINT (x)
4367 fits in int; it doesn't always, on 64-bit hosts. The new version
4368 doesn't catch all possible integer overflows, but it's an
4369 improvement. (Bug#8719)
4371 * alloc.c (make_event_array): Use XINT, not XUINT.
4372 There's no need for unsigned here.
4374 * mem-limits.h (EXCEEDS_LISP_PTR) [!USE_LSB_TAG]: EMACS_UINT -> uintptr_t
4375 This follows up to the 2011-05-06 change that substituted uintptr_t
4376 for EMACS_INT. This case wasn't caught back then.
4378 Rework Fformat to avoid integer overflow issues.
4379 * editfns.c: Include <float.h> unconditionally, as it's everywhere
4380 now (part of C89). Include <verify.h>.
4381 (MAX_10_EXP, CONVERTED_BYTE_SIZE): Remove; no longer needed.
4382 (pWIDE, pWIDElen, signed_wide, unsigned_wide): New defns.
4383 (Fformat): Avoid the prepass trying to compute sizes; it was only
4384 approximate and thus did not catch overflow reliably. Instead, walk
4385 through the format just once, formatting and computing sizes as we go,
4386 checking for integer overflow at every step, and allocating a larger
4387 buffer as needed. Keep track separately whether the format is
4388 multibyte. Keep only the most-recently calculated precision, rather
4389 than them all. Record whether each argument has been converted to
4390 string. Use EMACS_INT, not int, for byte and char and arg counts.
4391 Support field widths and precisions larger than INT_MAX. Avoid
4392 sprintf's undefined behavior with conversion specifications such as %#d
4393 and %.0c. Fix bug with strchr succeeding on '\0' when looking for
4394 flags. Fix bug with (format "%c" 256.0). Avoid integer overflow when
4395 formatting out-of-range floating point numbers with int
4398 * lisp.h (FIXNUM_OVERFLOW_P): Work even if arg is a NaN.
4400 * data.c: Avoid integer truncation in expressions involving floats.
4401 * data.c: Include <intprops.h>.
4402 (arith_driver): When there's an integer overflow in an expression
4403 involving floating point, convert the integers to floating point
4404 so that the resulting value does not suffer from catastrophic
4405 integer truncation. For example, on a 64-bit host (* 4
4406 most-negative-fixnum 0.5) should yield about -4.6e+18, not zero.
4407 Do not rely on undefined behavior after integer overflow.
4409 merge count_size_as_multibyte, parse_str_to_multibyte
4410 * character.c, character.h (count_size_as_multibyte):
4411 Rename from parse_str_to_multibyte; all uses changed.
4412 Check for integer overflow.
4413 * insdel.c, lisp.h (count_size_as_multibyte): Remove,
4414 since it's now a duplicate of the other. This is more of
4415 a character than a buffer op, so better that it's in character.c.
4416 * fns.c, print.c: Adjust to above changes.
4418 2011-05-27 Stefan Monnier <monnier@iro.umontreal.ca>
4420 * xselect.c (x_convert_selection): Yet another int/Lisp_Object mixup.
4422 2011-05-27 Paul Eggert <eggert@cs.ucla.edu>
4424 * xselect.c: Fix minor problems prompted by GCC 4.6.0 warnings.
4425 (x_handle_selection_request, frame_for_x_selection): Remove unused vars.
4426 (x_clipboard_manager_save): Now static.
4427 (Fx_clipboard_manager_save): Rename local to avoid shadowing.
4429 * fns.c: Fix minor problems prompted by GCC 4.6.0 warnings.
4430 (crypto_hash_function): Now static.
4431 Fix pointer signedness problems. Avoid unnecessary initializations.
4433 2011-05-27 Chong Yidong <cyd@stupidchicken.com>
4435 * termhooks.h (Vselection_alist): Make it terminal-local.
4437 * terminal.c (create_terminal): Initialize it.
4439 * xselect.c: Support for clipboard managers.
4440 (Vselection_alist): Move to termhooks.h as terminal-local var.
4441 (LOCAL_SELECTION): New macro.
4442 (x_atom_to_symbol): Handle x_display_info_for_display fail case.
4443 (symbol_to_x_atom): Remove gratuitous arg.
4444 (x_handle_selection_request, lisp_data_to_selection_data)
4445 (x_get_foreign_selection, Fx_register_dnd_atom): Callers changed.
4446 (x_own_selection, x_get_local_selection, x_convert_selection):
4447 New arg, specifying work frame. Use terminal-local Vselection_alist.
4448 (some_frame_on_display): Delete unused function.
4449 (Fx_own_selection_internal, Fx_get_selection_internal)
4450 (Fx_disown_selection_internal, Fx_selection_owner_p)
4451 (Fx_selection_exists_p): New optional frame arg.
4452 (frame_for_x_selection, Fx_clipboard_manager_save): New functions.
4453 (x_handle_selection_clear): Don't treat other terminals with the
4454 same keyboard specially. Use the terminal-local Vselection_alist.
4455 (x_clear_frame_selections): Use Frun_hook_with_args.
4457 * xterm.c (x_term_init): Intern ATOM and CLIPBOARD_MANAGER atoms.
4459 * xterm.h: Add support for those atoms.
4461 2011-05-26 Chong Yidong <cyd@stupidchicken.com>
4463 * xselect.c: ICCCM-compliant handling of MULTIPLE targets.
4464 (converted_selections, conversion_fail_tag): New global variables.
4465 (x_selection_request_lisp_error): Free the above.
4466 (x_get_local_selection): Remove unnecessary code.
4467 (x_reply_selection_request): Args changed; handle arbitrary array
4468 of converted selections stored in converted_selections.
4469 Separate the XChangeProperty and SelectionNotify steps.
4470 (x_handle_selection_request): Rewrite to handle MULTIPLE target.
4471 (x_convert_selection): New function.
4472 (x_handle_selection_event): Simplify.
4473 (x_get_foreign_selection): Don't ignore incoming requests while
4474 waiting for an answer; this will fail when we implement
4475 SAVE_TARGETS, and seems unnecessary anyway.
4476 (selection_data_to_lisp_data): Recognize ATOM_PAIR type.
4477 (Vx_sent_selection_functions): Doc fix.
4479 2011-05-26 Leo Liu <sdl.web@gmail.com>
4481 * editfns.c (Ftranspose_regions): Allow empty regions. (Bug#8699)
4483 2011-05-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
4485 * dispextern.h (struct glyph_row): New member fringe_bitmap_periodic_p.
4487 * dispnew.c (shift_glyph_matrix, scrolling_window): Mark scrolled row
4488 for fringe update if it has periodic bitmap.
4489 (row_equal_p): Also compare left_fringe_offset, right_fringe_offset,
4490 and fringe_bitmap_periodic_p.
4492 * fringe.c (get_fringe_bitmap_data): New function.
4493 (draw_fringe_bitmap_1, update_window_fringes): Use it.
4494 (update_window_fringes): Record periodicity of fringe bitmap in glyph
4495 row. Mark glyph row for fringe update if periodicity changed.
4497 * xdisp.c (try_window_reusing_current_matrix): Don't mark scrolled row
4498 for fringe update unless it has periodic bitmap.
4500 2011-05-25 Kenichi Handa <handa@m17n.org>
4502 * xdisp.c (get_next_display_element): Set correct it->face_id for
4503 a static composition.
4505 2011-05-24 Leo Liu <sdl.web@gmail.com>
4508 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha1.h.
4510 * fns.c (crypto_hash_function, Fsha1): New function.
4511 (Fmd5): Use crypto_hash_function.
4512 (syms_of_fns): Add Ssha1.
4514 2011-05-22 Paul Eggert <eggert@cs.ucla.edu>
4516 * gnutls.c: Remove unused macros.
4517 (fn_gnutls_transport_set_lowat, fn_gnutls_transport_set_pull_function):
4518 (fn_gnutls_transport_set_push_function) [!WINDOWSNT]:
4519 Remove macros that are defined and never used.
4520 Caught by gcc -Wunused-macros (GCC 4.6.0, Fedora 14).
4522 2011-05-22 Chong Yidong <cyd@stupidchicken.com>
4524 * xselect.c (syms_of_xselect): Remove unused symbol SAVE_TARGETS.
4525 (Fx_get_selection_internal): Minor cleanup.
4526 (Fx_own_selection_internal): Rename arguments for consistency with
4529 2011-05-22 Paul Eggert <eggert@cs.ucla.edu>
4531 * xselect.c (QSAVE_TARGETS): New static var, to fix build failure.
4533 2011-05-22 Chong Yidong <cyd@stupidchicken.com>
4535 * xselect.c (syms_of_xselect): Include character.h; use DEFSYM.
4537 2011-05-21 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
4539 * dispnew.c (scrolling_window): Don't exclude the case that the
4540 last enabled row in the desired matrix touches the bottom boundary.
4542 2011-05-21 Glenn Morris <rgm@gnu.org>
4544 * Makefile.in ($(etc)/DOC): Make second command line even shorter.
4545 (SOME_MACHINE_OBJECTS): Replace FONT_OBJ by its maximal expansion,
4546 and add some more files.
4548 2011-05-20 Eli Zaretskii <eliz@gnu.org>
4550 * callproc.c (Fcall_process) [MSDOS]: Fix arguments to
4551 report_file_error introduced by the change from 2011-05-07.
4553 2011-05-20 Paul Eggert <eggert@cs.ucla.edu>
4555 * systime.h (Time): Define only if emacs is defined.
4556 This is to allow ../lib-src/profile.c to be compiled on FreeBSD,
4557 where the include path doesn't have X11/X.h by default. See
4558 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00561.html>.
4560 2011-05-20 Kenichi Handa <handa@m17n.org>
4562 * composite.c (find_automatic_composition): Fix previous change.
4564 2011-05-20 Glenn Morris <rgm@gnu.org>
4566 * lisp.mk: New file, split from Makefile.in.
4567 * Makefile.in (lisp): Move to separate file, inserted by @lisp_frag@.
4568 (shortlisp): Remove.
4569 ($(etc)/DOC): Edit lisp.mk rather than using $shortlisp.
4571 2011-05-19 Glenn Morris <rgm@gnu.org>
4573 * Makefile.in (MSDOS_SUPPORT_REAL, MSDOS_SUPPORT, NS_SUPPORT)
4574 (REAL_MOUSE_SUPPORT, GPM_MOUSE_SUPPORT, MOUSE_SUPPORT, TOOLTIP_SUPPORT)
4575 (BASE_WINDOW_SUPPORT, X_WINDOW_SUPPORT, WINDOW_SUPPORT): Remove.
4576 (lisp): Set the order to that of loadup.el.
4577 (shortlisp): Make it a copy of $lisp.
4578 (SOME_MACHINE_LISP): Remove.
4579 ($(etc)/DOC): Depend just on $lisp, not $SOME_MACHINE_LISP too.
4580 Use just $shortlisp, not $SOME_MACHINE_LISP too.
4582 2011-05-18 Kenichi Handa <handa@m17n.org>
4584 * composite.c (CHAR_COMPOSABLE_P): Add more check for efficiency.
4585 (BACKWARD_CHAR): Wrap the arg STOP by parenthesis.
4586 (find_automatic_composition): Mostly rewrite for efficiency.
4588 2011-05-18 Juanma Barranquero <lekktu@gmail.com>
4590 * makefile.w32-in: Update dependencies.
4592 2011-05-18 Christoph Scholtes <cschol2112@googlemail.com>
4594 * menu.c: Include limits.h (fixes the MS-Windows build broken by
4595 2011-06-18T18:49:19Z!cyd@stupidchicken.com).
4597 2011-05-18 Paul Eggert <eggert@cs.ucla.edu>
4599 Fix some integer overflow issues, such as string length overflow.
4601 * insdel.c (count_size_as_multibyte): Check for string overflow.
4603 * character.c (lisp_string_width): Check for string overflow.
4604 Use EMACS_INT, not int, for string indexes and lengths; in
4605 particular, 2nd arg is now EMACS_INT, not int. Do not crash if
4606 the resulting string length overflows an EMACS_INT; instead,
4607 report a string overflow if no precision given. When checking for
4608 precision exhaustion, use a check that cannot possibly have
4609 integer overflow. (Bug#8675)
4610 * character.h (lisp_string_width): Adjust to new signature.
4612 * alloc.c (string_overflow): New function.
4613 (Fmake_string): Use it. This doesn't change behavior, but saves
4614 a few bytes and will simplify future changes.
4615 * character.c (string_escape_byte8): Likewise.
4616 * lisp.h (string_overflow): New decl.
4618 Fixups, following up to the user-interface timestamp change.
4619 * nsterm.m (last_mouse_movement_time, ns_mouse_position): Use Time
4620 for UI timestamps, instead of unsigned long.
4621 * msdos.c (mouse_get_pos): Likewise.
4622 * w32inevt.c (movement_time, w32_console_mouse_position): Likewise.
4623 * w32gui.h (Time): Define by including "systime.h" rather than by
4624 declaring it ourselves. (Bug#8664)
4626 * dispextern.h (struct image): Don't assume time_t <= unsigned long.
4627 * image.c (clear_image_cache): Likewise.
4629 * term.c (term_mouse_position): Don't assume time_t wraparound.
4631 Be more systematic about user-interface timestamps.
4632 Before, the code sometimes used 'Time', sometimes 'unsigned long',
4633 and sometimes 'EMACS_UINT', to represent these timestamps.
4634 This change causes it to use 'Time' uniformly, as that's what X uses.
4635 This makes the code easier to follow, and makes it easier to catch
4636 integer overflow bugs such as Bug#8664.
4637 * frame.c (Fmouse_position, Fmouse_pixel_position):
4638 Use Time, not unsigned long, for user-interface timestamps.
4639 * keyboard.c (last_event_timestamp, kbd_buffer_get_event): Likewise.
4640 (button_down_time, make_lispy_position, make_lispy_movement): Likewise.
4641 * keyboard.h (last_event_timestamp): Likewise.
4642 * menu.c (Fx_popup_menu) [!HAVE_X_WINDOWS]: Likewise.
4643 * menu.h (xmenu_show): Likewise.
4644 * term.c (term_mouse_position): Likewise.
4645 * termhooks.h (struct input_event.timestamp): Likewise.
4646 (struct terminal.mouse_position_hook): Likewise.
4647 * xmenu.c (create_and_show_popup_menu, xmenu_show): Likewise.
4648 * xterm.c (XTmouse_position, x_scroll_bar_report_motion): Likewise.
4649 * systime.h (Time): New decl. Pull it in from <X11/X.h> if
4650 HAVE_X_WINDOWS, otherwise define it as unsigned long, which is
4652 * menu.h, termhooks.h: Include "systime.h", for Time.
4654 * keyboard.c (make_lispy_event): Fix problem in integer overflow.
4655 Don't assume that the difference between two unsigned long values
4656 can fit into an integer. At this point, we know button_down_time
4657 <= event->timestamp, so the difference must be nonnegative, so
4658 there's no need to cast the result if double-click-time is
4659 nonnegative, as it should be; check that it's nonnegative, just in
4660 case. This bug is triggered when events are more than 2**31 ms
4661 apart (about 25 days). (Bug#8664)
4663 * xselect.c (last_event_timestamp): Remove duplicate decl.
4664 (x_own_selection): Remove needless cast to unsigned long.
4666 * xmenu.c (set_frame_menubar): Use int, not EMACS_UINT, for indexes
4667 that always fit in int. Use a sentinel instead of a counter, to
4668 avoid a temp and to allay GCC's concerns about possible int overflow.
4669 * frame.h (struct frame): Use int for menu_bar_items_used
4670 instead of EMACS_INT, since it always fits in int.
4672 * menu.c (grow_menu_items): Check for int overflow.
4674 * xmenu.c (set_frame_menubar): Don't mishandle vectors with no nils.
4676 * xterm.c: Use EMACS_INT for Emacs modifiers, and int for X modifiers.
4677 Before, the code was not consistent. These values cannot exceed
4678 2**31 - 1 so there's no need to make them unsigned.
4679 (x_x_to_emacs_modifiers): Accept int and return EMACS_INT.
4680 (x_emacs_to_x_modifiers): Accept EMACS_INT and return int.
4681 (x_x_to_emacs_modifiers, x_emacs_to_x_modifiers): Reject non-integers
4683 * xterm.h (x_x_to_emacs_modifiers): Adjust to signature change.
4685 * lisp.h (XINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_INT.
4686 (XUINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_UINT.
4687 Otherwise, GCC 4.6.0 warns about printf (pI, XINT (...)),
4688 presumably because the widths might not match.
4690 * window.c (size_window): Avoid needless test at loop start.
4692 2011-05-18 Courtney Bane <emacs-bugs-7626@cbane.org> (tiny change)
4694 * term.c (Fresume_tty): Restore hooks before reinitializing (bug#8687).
4696 2011-05-12 Drew Adams <drew.adams@oracle.com>
4698 * textprop.c (Fprevious_single_char_property_change): Doc fix (bug#8655).
4700 2011-05-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
4702 * w32term.c (w32_draw_fringe_bitmap): Rename local vars `left' and
4703 `width' to `bar_area_x' and `bar_area_width', respectively.
4704 (x_scroll_run): Take account of fringe background extension.
4706 * xterm.c (x_draw_fringe_bitmap) [USE_TOOLKIT_SCROLL_BARS]:
4707 Rename local vars `left' and `width' to `bar_area_x' and
4708 `bar_area_width', respectively.
4709 (x_scroll_run) [USE_TOOLKIT_SCROLL_BARS]: Take account of fringe
4710 background extension.
4712 2011-05-10 Jim Meyering <meyering@redhat.com>
4714 * xdisp.c (x_intersect_rectangles): Fix typo "the the -> the".
4716 2011-05-10 Juanma Barranquero <lekktu@gmail.com>
4718 * image.c (Finit_image_library): Return t for built-in image types,
4719 like pbm and xbm. (Bug#8640)
4721 2011-05-09 Andreas Schwab <schwab@linux-m68k.org>
4723 * w32menu.c (set_frame_menubar): Fix submenu allocation.
4725 2011-05-07 Eli Zaretskii <eliz@gnu.org>
4727 * w32console.c (Fset_screen_color): Doc fix.
4728 (Fget_screen_color): New function.
4729 (syms_of_ntterm): Defsubr it.
4731 * callproc.c (call_process_cleanup) [MSDOS]: Don't close and
4732 unlink the temporary file if Fcall_process didn't create it in the
4734 (Fcall_process) [MSDOS]: Don't create tempfile if stdout of the
4735 child process will be redirected to a file specified with `:file'.
4736 Don't try to re-open tempfile in that case, and set fd[0] to -1 as
4737 cue to call_process_cleanup not to close that handle.
4739 2011-05-07 Ben Key <bkey76@gmail.com>
4741 * makefile.w32-in: The bootstrap-temacs rule now makes use of
4742 one of two shell specific rules, either bootstrap-temacs-CMD or
4743 bootstrap-temacs-SH. The bootstrap-temacs-SH rule is identical
4744 to the previous implementation of the bootstrap-temacs rule.
4745 The bootstrap-temacs-CMD rule is similar to the previous
4746 implementation of the bootstrap-temacs rule except that it
4747 makes use of the ESC_CFLAGS variable instead of the CFLAGS
4750 These changes, along with some changes to nt/configure.bat,
4751 nt/gmake.defs, and nt/nmake.defs, are required to extend my
4752 earlier fix to add support for --cflags and --ldflags options
4753 that include quotes so that it works whether make uses cmd or
4756 2011-05-06 Michael Albinus <michael.albinus@gmx.de>
4758 * dbusbind.c (QCdbus_type_unix_fd): Declare static.
4759 (xd_remove_watch): Don't check QCdbus_type_unix_fd for SYMBOLP, it
4761 (Fdbus_init_bus, xd_read_queued_messages): Bus can be a symbol or
4762 a string. Handle both cases.
4763 (Fdbus_call_method_asynchronously, Fdbus_register_signal)
4764 (Fdbus_register_method): Use Qinvalid_function.
4766 2011-05-06 Juanma Barranquero <lekktu@gmail.com>
4768 * makefile.w32-in: Update dependencies.
4769 (LISP_H): Add inttypes.h and stdin.h.
4770 (PROCESS_H): Add unistd.h.
4772 2011-05-06 Eli Zaretskii <eliz@gnu.org>
4774 * lread.c: Include limits.h (fixes the MS-Windows build broken by
4775 2011-05-06T07:13:19Z!eggert@cs.ucla.edu).
4777 2011-05-06 Paul Eggert <eggert@cs.ucla.edu>
4779 * image.c (Finit_image_library) [!HAVE_NTGUI]: Omit unused local.
4781 * term.c (vfatal): Remove stray call to va_end.
4782 It's not needed and the C Standard doesn't allow it here anyway.
4784 Use C99's va_copy to avoid undefined behavior on x86-64 GNU/Linux.
4785 * eval.c (verror): doprnt a copy of ap, not the original. (Bug#8545)
4787 * eval.c (verror): OK to create a string of up to MOST_POSITIVE_FIXNUM
4790 * term.c: Don't include <stdarg.h>, as <lisp.h> does that.
4792 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
4794 * process.c (Fformat_network_address): Fix typo: args2 -> *args2.
4796 * xmenu.c (set_frame_menubar): Fix typo: int * -> int (3 times).
4798 * coding.c (detect_coding_charset): Fix typo: * 2 -> *4 (Bug#8601).
4800 * charset.h (struct charset.code_space): Now has 15 elements, not 16.
4801 * charset.c (Fdefine_charset_internal): Don't initialize
4802 charset.code_space[15]. The value was garbage, on hosts with
4803 32-bit int (Bug#8600).
4805 * lread.c (read_integer): Be more consistent with string-to-number.
4806 Use string_to_number to do the actual conversion; this avoids
4807 rounding errors and fixes some other screwups. Without this fix,
4808 for example, #x1fffffffffffffff was misread as -2305843009213693952.
4809 (digit_to_number): Move earlier, for benefit of read_integer.
4810 Return -1 if the digit is out of range for the base, -2 if it is
4811 not a digit in any supported base. (Bug#8602)
4813 * doprnt.c (doprnt): Support arbitrary pI values, such as "I64".
4815 * dispnew.c (scrolling_window): Return 1 if we scrolled,
4816 to match comment at start of function. This also removes a
4817 GCC warning about overflow in a 32+64-bit port.
4819 * lisp.h (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Simplify.
4821 * dbusbind.c: Do not use XPNTR on a value that may be an integer.
4822 Reported by Stefan Monnier in
4823 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00919.html>.
4824 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
4825 Use SYMBOLP-guarded XSYMBOL, not XPNTR.
4827 * lisp.h (EMACS_INTPTR): Remove. All uses changed to intptr_t.
4828 (EMACS_UINTPTR): Likewise, with uintptr_t.
4830 * lisp.h: Prefer 64-bit EMACS_INT if available.
4831 (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Define to 64-bit
4832 on 32-bit hosts that have 64-bit int, so that they can access
4834 However, temporarily disable this change unless the temporary
4835 symbol WIDE_EMACS_INT is defined.
4837 * lread.c, process.c: Do not include <inttypes.h>; lisp.h does it now.
4839 Prefer intptr_t/uintptr_t for integers the same widths as pointers.
4840 This removes an assumption that EMACS_INT and long are the same
4841 width as pointers. The assumption is true for Emacs porting targets
4842 now, but we want to make other targets possible.
4843 * lisp.h: Include <inttypes.h>, for INTPTR_MAX, UINTPTR_MAX.
4844 (EMACS_INTPTR, EMACS_UINTPTR): New macros.
4845 In the rest of the code, change types of integers that hold casted
4846 pointers to EMACS_INTPTR and EMACS_UINTPTR, systematically
4847 replacing EMACS_INT, long, EMACS_UINT, and unsigned long.
4848 (XTYPE): Don't cast arg to EMACS_UINT; normally is not needed.
4849 (XSET): Cast type of XTYPE arg to EMACS_INTPTR; it is needed here.
4850 No need to cast type when ORing.
4851 (XPNTR): Return a value of type EMACS_INTPTR or EMACS_UINTPTR.
4852 * alloc.c (lisp_align_malloc): Remove a no-longer-needed cast.
4853 * doc.c (store_function_docstring): Use EMACS_INTPTR, so as not to
4854 assume EMACS_INT is the same width as char *.
4855 * gtkutil.c (xg_gtk_scroll_destroy, xg_tool_bar_button_cb):
4856 (xg_tool_bar_callback, xg_tool_bar_help_callback, xg_make_tool_item):
4857 Remove no-longer-needed casts.
4858 (xg_create_scroll_bar, xg_tool_bar_button_cb, xg_tool_bar_callback):
4859 (xg_tool_bar_help_callback, xg_make_tool_item):
4860 Use EMACS_INTPTR to hold an integer
4861 that will be cast to void *; this can avoid a GCC warning
4862 if EMACS_INT is not the same width as void *.
4863 * menu.c (find_and_call_menu_selection): Remove no-longer-needed cast.
4864 * xdisp.c (display_echo_area_1, resize_mini_window_1):
4865 (current_message_1, set_message_1):
4866 Use a local to convert to proper width without a cast.
4867 * xmenu.c (dialog_selection_callback): Likewise.
4869 * sysdep.c (get_random): Don't assume EMACS_INT is no wider than long.
4870 Also, don't assume VALBITS / RAND_BITS is less than 5,
4871 and don't rely on undefined behavior when shifting a 1 left into
4873 * lisp.h (get_random): Change signature to match.
4875 * lread.c (hash_string): Use size_t, not int, for hash computation.
4876 Normally we prefer signed values; but hashing is special, because
4877 it's better to use unsigned division on hash table sizes so that
4878 the remainder is nonnegative. Also, size_t is the natural width
4879 for hashing into memory. The previous code used 'int', which doesn't
4880 retain enough info to hash well into very large tables.
4881 (oblookup, oblookup_last_bucket_number, Funintern): Likewise.
4883 * dbusbind.c: Don't possibly lose pointer info when converting.
4884 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
4885 Use XPNTR rather than XHASH, so that the high-order bits of
4886 the pointer aren't lost when converting through void *.
4888 * eval.c (Fautoload): Don't double-shift a pointer.
4890 * fns.c (Frandom): Let EMACS_UINT be wider than unsigned long.
4892 2011-05-06 Juanma Barranquero <lekktu@gmail.com>
4894 * gnutls.c (DEF_GNUTLS_FN):
4895 * image.c (DEF_IMGLIB_FN): Make function pointers static.
4897 2011-05-05 Andreas Schwab <schwab@linux-m68k.org>
4899 * lread.c (lisp_file_lexically_bound_p): Stop scanning at end
4902 2011-05-05 Eli Zaretskii <eliz@gnu.org>
4904 * w32heap.c (allocate_heap) [USE_LISP_UNION_TYPE || USE_LSB_TAG]:
4905 New version that can reserve upto 2GB of heap space.
4907 2011-05-05 Chong Yidong <cyd@stupidchicken.com>
4909 * nsfns.m (Fns_read_file_name): Doc fix (Bug#8534).
4911 2011-05-05 Teodor Zlatanov <tzz@lifelogs.com>
4913 * gnutls.c (fn_gnutls_certificate_set_x509_key_file): Add alias to
4914 `gnutls_certificate_set_x509_key_file'.
4916 2011-05-05 Juanma Barranquero <lekktu@gmail.com>
4918 * makefile.w32-in ($(BLD)/image.$(O), $(BLD)/process.$(O)):
4919 Update dependencies.
4921 2011-05-04 Juanma Barranquero <lekktu@gmail.com>
4923 * gnutls.h (emacs_gnutls_write, emacs_gnutls_read):
4924 * gnutls.c (emacs_gnutls_write, emacs_gnutls_read):
4925 Remove unused parameter `fildes'.
4926 * process.c (read_process_output, send_process): Don't pass it.
4928 2011-05-04 Juanma Barranquero <lekktu@gmail.com>
4930 Fix previous change: the library cache is defined in w32.c.
4931 * image.c (CACHE_IMAGE_TYPE) [!HAVE_NTGUI]: Define to noop.
4932 (Finit_image_library): Wrap Vlibrary_cache on "#ifdef HAVE_NTGUI".
4934 2011-05-04 Juanma Barranquero <lekktu@gmail.com>
4936 Implement dynamic loading of GnuTLS on Windows.
4938 * gnutls.h (GNUTLS_EMACS_ERROR_NOT_LOADED): New macro.
4939 (emacs_gnutls_write, emacs_gnutls_read): Mark as extern.
4940 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
4943 * gnutls.c (Qgnutls_dll): Define.
4944 (DEF_GNUTLS_FN, LOAD_GNUTLS_FN): New macros.
4945 (gnutls_*): Declare function pointers.
4946 (init_gnutls_functions): New function to initialize function pointers.
4947 (emacs_gnutls_handshake, Fgnutls_error_string, Fgnutls_deinit)
4948 (emacs_gnutls_global_init, Fgnutls_bye): Use function pointers.
4949 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
4950 Wrappers for gnutls_record_check_pending and gnutls_transport_set_errno.
4951 (emacs_gnutls_write, emacs_gnutls_read)
4952 (emacs_gnutls_handle_error, Fgnutls_error_fatalp)
4953 (Fgnutls_available_p): New function.
4954 (Fgnutls_boot): Call Fgnutls_available_p. Use function pointers.
4955 (syms_of_gnutls) <Qgnutls_dll>: Initialize and staticpro it.
4956 (syms_of_gnutls) <Sgnutls_available_p>: defsubr it.
4958 * image.c: Include w32.h.
4959 (Vimage_type_cache): Delete.
4960 (syms_of_image) <Vimage_type_cache>: Don't initialize and staticpro it.
4961 (CACHE_IMAGE_TYPE, Finit_image_library): Use Vlibrary_cache instead.
4962 (w32_delayed_load): Move to w32.c.
4964 * w32.h (VlibraryCache, QCloaded_from, w32_delayed_load): Declare.
4966 * w32.c (QCloaded_from, Vlibrary_cache): Define.
4967 (w32_delayed_load): Move from image.c. When loading a library, record
4968 its filename in the :loaded-from property of the library id.
4969 (globals_of_w32) <QCloaded_from, Vlibrary_cache>:
4970 Initialize and staticpro them.
4971 (emacs_gnutls_pull, emacs_gnutls_push): Call emacs_gnutls_* functions.
4973 * process.c: Include lisp.h before w32.h, not after.
4974 (wait_reading_process_output): Call emacs_gnutls_record_check_pending
4975 instead of gnutls_record_check_pending.
4977 * callproc.c, emacs.c: Include lisp.h before w32.h, not after.
4979 2011-05-04 Teodor Zlatanov <tzz@lifelogs.com>
4981 * gnutls.c (Fgnutls_boot): Support :keylist and :crlfiles options
4982 instead of :keyfiles. Give GnuTLS the keylist and the CRL lists
4985 2011-05-03 Jan Djärv <jan.h.d@swipnet.se>
4987 * xterm.c (x_set_frame_alpha): Do not set property on anything
4988 else than FRAME_X_OUTER_WINDOW (Bug#8608).
4990 2011-05-02 Juanma Barranquero <lekktu@gmail.com>
4992 * sysdep.c (get_tty_size) [WINDOWSNT]: Implement. (Bug#8596)
4994 2011-05-02 Juanma Barranquero <lekktu@gmail.com>
4996 * gnutls.c (Qgnutls_log_level, Qgnutls_code, Qgnutls_anon)
4997 (Qgnutls_x509pki, Qgnutls_e_interrupted, Qgnutls_e_again)
4998 (Qgnutls_e_invalid_session, Qgnutls_e_not_ready_for_handshake)
4999 (gnutls_global_initialized, Qgnutls_bootprop_priority)
5000 (Qgnutls_bootprop_trustfiles, Qgnutls_bootprop_keyfiles)
5001 (Qgnutls_bootprop_callbacks, Qgnutls_bootprop_loglevel)
5002 (Qgnutls_bootprop_hostname, Qgnutls_bootprop_verify_flags)
5003 (Qgnutls_bootprop_verify_error, Qgnutls_bootprop_verify_hostname_error)
5004 (Qgnutls_bootprop_callbacks_verify): Make static.
5006 2011-05-01 Andreas Schwab <schwab@linux-m68k.org>
5008 * callproc.c: Indentation fixup.
5010 * sysdep.c (wait_for_termination_1): Make static.
5011 (wait_for_termination, interruptible_wait_for_termination):
5012 Move after wait_for_termination_1.
5014 2011-05-01 Lars Magne Ingebrigtsen <larsi@gnus.org>
5016 * sysdep.c (interruptible_wait_for_termination): New function
5017 which is like wait_for_termination, but allows keyboard
5020 * callproc.c (Fcall_process): Add (:file "file") as an option for
5022 (Fcall_process_region): Ditto.
5024 2011-04-30 Eli Zaretskii <eliz@gnu.org>
5026 * dosfns.c (Fint86, Fdos_memget, Fdos_memput): Use `ASIZE (FOO)'
5027 rather than `XVECTOR (FOO)->size'.
5029 * process.c: Remove HAVE_INTTYPES_H condition from inclusion of
5030 inttypes.h, as a gnulib replacement is used if it not available in
5033 2011-04-21 Eli Zaretskii <eliz@gnu.org>
5035 Lift the MOST_POSITIVE_FIXNUM/4 limitation on visited files.
5036 * fileio.c (Finsert_file_contents): Don't limit file size to 1/4
5037 of MOST_POSITIVE_FIXNUM. (Bug#8528)
5039 * coding.c (coding_alloc_by_realloc): Error out if destination
5040 will grow beyond MOST_POSITIVE_FIXNUM.
5041 (decode_coding_emacs_mule): Abort if there isn't enough place in
5042 charbuf for the composition carryover bytes. Reserve an extra
5043 space for up to 2 characters produced in a loop.
5044 (decode_coding_iso_2022): Abort if there isn't enough place in
5045 charbuf for the composition carryover bytes.
5047 2011-04-21 Eli Zaretskii <eliz@gnu.org>
5049 * doprnt.c (doprnt) [!HAVE_LONG_LONG_INT]: Error out instead of
5050 aborting when %lld or %lll format is passed.
5051 [!HAVE_UNSIGNED_LONG_LONG_INT]: Error out instead of aborting when
5052 %llo or %llx format is passed. (Bug#8545)
5054 * window.c (window_scroll_line_based): Use a marker instead of
5055 simple variables to record original value of point. (Bug#7952)
5057 * doprnt.c (doprnt): Fix the case where a multibyte sequence
5058 produced by %s or %c overflows available buffer space. (Bug#8545)
5060 2011-04-28 Paul Eggert <eggert@cs.ucla.edu>
5062 * doprnt.c (doprnt): Omit useless test; int overflow check (Bug#8545).
5063 (SIZE_MAX): Move defn after all includes, as they might #define it.
5065 2011-04-28 Juanma Barranquero <lekktu@gmail.com>
5067 * w32.c (init_environment): Warn about defaulting HOME to C:\.
5069 2011-04-28 Juanma Barranquero <lekktu@gmail.com>
5071 * keyboard.c (Qdelayed_warnings_hook): Define.
5072 (command_loop_1): Run `delayed-warnings-hook'
5073 if Vdelayed_warnings_list is non-nil.
5074 (syms_of_keyboard) <delayed-warnings-hook>: DEFSYM it.
5075 (syms_of_keyboard) <delayed-warnings-list>: DEFVAR_LISP it.
5077 2011-04-28 Eli Zaretskii <eliz@gnu.org>
5079 * doprnt.c (doprnt): Don't return value smaller than the buffer
5080 size if the message was truncated. (Bug#8545).
5082 2011-04-28 Juanma Barranquero <lekktu@gmail.com>
5084 * w32fns.c (Fx_change_window_property, Fx_delete_window_property)
5085 (Fx_window_property): #if-0 the whole functions, not just the bodies.
5087 2011-04-27 Paul Eggert <eggert@cs.ucla.edu>
5089 * doprnt.c (doprnt): Support "ll" length modifier, for long long.
5091 2011-04-27 Juanma Barranquero <lekktu@gmail.com>
5093 * makefile.w32-in: Update dependencies.
5095 2011-04-27 Eli Zaretskii <eliz@gnu.org>
5097 Improve `doprnt' and its usage. (Bug#8545)
5098 * doprnt.c (doprnt): Make sure `format' is never accessed beyond
5099 `format_end'. Remove support for %l as a conversion specifier.
5100 Don't use xrealloc. Improve diagnostics when the %l size modifier
5101 is used. Update the commentary.
5103 * eval.c (verror): Simplify calculation of size_t.
5105 * coding.c (Ffind_operation_coding_system): Fix diagnostic error
5108 2011-04-27 Yoshiaki Kasahara <kasahara@nc.kyushu-u.ac.jp> (tiny change)
5110 * buffer.c (init_buffer) [USE_MMAP_FOR_BUFFERS]: Adjust to aliasing
5113 2011-04-27 Paul Eggert <eggert@cs.ucla.edu>
5115 * nsmenu.m: Replace all uses of XVECTOR with ASIZE and AREF.
5116 This makes this file independent of the recent pseudovector change.
5118 2011-04-26 Paul Eggert <eggert@cs.ucla.edu>
5120 * keyboard.c (handle_user_signal): Fix pointer signedness problem.
5122 * gnutls.c (emacs_gnutls_handle_error): Remove unused local.
5123 (Fgnutls_boot): gnutls_certificate_verify_peers2 wants unsigned *.
5124 Remove unused local.
5125 (emacs_gnutls_write): Don't use uninitialized rtnval if nbyte <= 0.
5127 * lisp.h: Fix a problem with aliasing and vector headers. (Bug#8546)
5128 GCC 4.6.0 optimizes based on type-based alias analysis.
5129 For example, if b is of type struct buffer * and v of type struct
5130 Lisp_Vector *, then gcc -O2 was incorrectly assuming that &b->size
5131 != &v->size, and therefore "v->size = 1; b->size = 2; return
5132 v->size;" must therefore return 1. This assumption is incorrect
5133 for Emacs, since it type-puns struct Lisp_Vector * with many other
5134 types. To fix this problem, this patch adds a new type struct
5135 vectorlike_header that documents the constraints on layout of vectors
5136 and pseudovectors, and helps optimizing compilers not get fooled
5137 by Emacs's type punning. It also adds the macros XSETTYPED_PVECTYPE
5138 XSETTYPED_PSEUDOVECTOR, TYPED_PSEUDOVECTORP, for similar reasons.
5139 * lisp.h (XSETTYPED_PVECTYPE): New macro, specifying the name of
5141 (XSETPVECTYPE): Rewrite in terms of new macro.
5142 (XSETPVECTYPESIZE): New macro, specifying both type and size.
5143 This is a bit clearer, and further avoids the possibility of
5144 undesirable aliasing.
5145 (XSETTYPED_PSEUDOVECTOR): New macro, specifying the size.
5146 (XSETPSEUDOVECTOR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR.
5147 (XSETSUBR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR and XSIZE,
5148 since Lisp_Subr is a special case (no "next" field).
5149 (ASIZE): Now uses header.size rather than size.
5150 All previous uses of XVECTOR (foo)->size replaced to use this macro,
5151 to avoid the hassle of writing XVECTOR (foo)->header.size.
5152 (struct vectorlike_header): New type.
5153 (TYPED_PSEUDOVECTORP): New macro, also specifying the C type of the
5154 object, to help avoid aliasing.
5155 (PSEUDOVECTORP): Rewrite in terms of TYPED_PSEUDOVECTORP.
5156 (SUBRP): Likewise, since Lisp_Subr is a special case.
5157 * lisp.h (struct Lisp_Vector, struct Lisp_Char_Table):
5158 (struct Lisp_Sub_Char_Table, struct Lisp_Bool_Vector):
5159 (struct Lisp_Hash_Table): Combine first two members into a single
5160 struct vectorlike_header member. All uses of "size" and "next" members
5161 changed to be "header.size" and "header.next".
5162 * buffer.h (struct buffer): Likewise.
5163 * font.h (struct font_spec, struct font_entity, struct font): Likewise.
5164 * frame.h (struct frame): Likewise.
5165 * process.h (struct Lisp_Process): Likewise.
5166 * termhooks.h (struct terminal): Likewise.
5167 * window.c (struct save_window_data, struct saved_window): Likewise.
5168 * window.h (struct window): Likewise.
5169 * alloc.c (allocate_buffer, Fmake_bool_vector, allocate_pseudovector):
5170 Use XSETPVECTYPESIZE, not XSETPVECTYPE, to avoid aliasing problems.
5171 * buffer.c (init_buffer_once): Likewise.
5172 * lread.c (defsubr): Use XSETTYPED_PVECTYPE, since Lisp_Subr is a
5174 * process.c (Fformat_network_address): Use local var for size,
5177 * bytecode.c (exec_byte_code): Don't use XVECTOR before CHECK_VECTOR.
5179 Make the Lisp reader and string-to-float more consistent (Bug#8525)
5180 * data.c (atof): Remove decl; no longer used or needed.
5181 (digit_to_number): Move to lread.c.
5182 (Fstring_to_number): Use new string_to_number function, to be
5183 consistent with how the Lisp reader treats infinities and NaNs.
5184 Do not assume that floating-point numbers represent EMACS_INT
5185 without losing information; this is not true on most 64-bit hosts.
5186 Avoid double-rounding errors, by insisting on integers when
5187 parsing non-base-10 numbers, as the documentation specifies.
5188 * lisp.h (string_to_number): New decl, replacing ...
5189 (isfloat_string): Remove.
5190 * lread.c: Include <inttypes.h>, for uintmax_t and strtoumax.
5191 (read1): Do not accept +. and -. as integers; this
5192 appears to have been a coding error. Similarly, do not accept
5193 strings like +-1e0 as floating point numbers. Do not report
5194 overflow for integer overflows unless the base is not 10 which
5195 means we have no simple and reliable way to continue.
5196 Break out the floating-point parsing into a new
5197 function string_to_number, so that Fstring_to_number parses
5198 floating point numbers consistently with the Lisp reader.
5199 (digit_to_number): Move here from data.c. Make it static inline.
5200 (E_CHAR, EXP_INT): Remove, replacing with ...
5201 (E_EXP): New macro, to solve the "1.0e+" problem mentioned below.
5202 (string_to_number): New function, replacing isfloat_string.
5203 This function checks for valid syntax and produces the resulting
5204 Lisp float number too. Rework it so that string-to-number
5205 no longer mishandles examples like "1.0e+". Use strtoumax,
5206 so that overflow for non-base-10 numbers is reported only when
5207 there's no portable and simple way to convert to floating point.
5209 * textprop.c (set_text_properties_1): Rewrite for clarity,
5210 and to avoid GCC warning about integer overflow.
5212 * intervals.h (struct interval): Use EMACS_INT for members
5213 where EMACS_UINT might cause problems. See
5214 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html>.
5215 (CHECK_TOTAL_LENGTH): Remove cast to EMACS_INT; no longer needed.
5216 * intervals.c (interval_deletion_adjustment): Now returns EMACS_INT.
5218 (offset_intervals): Tell GCC not to worry about length overflow
5219 when negating a negative length.
5221 * alloc.c (overrun_check_malloc, overrun_check_realloc): Now static.
5222 (overrun_check_free): Likewise.
5224 * alloc.c (SDATA_SIZE) [!GC_CHECK_STRING_BYTES]: Avoid runtime check
5225 in the common case where SDATA_DATA_OFFSET is a multiple of Emacs
5228 * gnutls.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
5229 (gnutls_make_error): Rename local to avoid shadowing.
5230 (gnutls_emacs_global_deinit): ifdef out; not used.
5231 (Fgnutls_boot): Use const for pointer to readonly storage.
5232 Comment out unused local. Fix pointer signedness problems.
5234 * lread.c (openp): Don't stuff size_t into an 'int'.
5235 Use <= on length, not < on length + 1, to avoid GCC 4.6.0 warning
5236 about possible signed overflow.
5238 * gtkutil.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
5239 (GDK_KEY_g): Don't define if already defined.
5240 (xg_prepare_tooltip): Avoid pointer signedness problem.
5241 (xg_set_toolkit_scroll_bar_thumb): Redo to avoid two casts.
5243 * process.c (Fnetwork_interface_info): Avoid left-shift undefined
5244 behavior with 1 << 31. GCC 4.6.0 warns about this on 32-bit hosts.
5246 * xfns.c (Fx_window_property): Simplify a bit,
5247 to make a bit faster and to avoid GCC 4.6.0 warning.
5248 * xselect.c (x_get_window_property, x_handle_dnd_message): Likewise.
5250 * fns.c (internal_equal): Don't assume size_t fits in int.
5252 * alloc.c (compact_small_strings): Tighten assertion a little.
5254 Replace pEd with more-general pI, and fix some printf arg casts.
5255 * lisp.h (pI): New macro, generalizing old pEd macro to other
5256 conversion specifiers. For example, use "...%"pI"d..." rather
5257 than "...%"pEd"...".
5258 (pEd): Remove. All uses replaced with similar uses of pI.
5259 * src/m/amdx86-64.h, src/m/ia64.h, src/m/ibms390x.h: Likewise.
5260 * alloc.c (check_pure_size): Don't overflow by converting size to int.
5261 * bidi.c (bidi_dump_cached_states): Use pI to avoid cast.
5262 * data.c (Fnumber_to_string): Use pI instead of if-then-else-abort.
5263 * dbusbind.c (xd_append_arg): Use pI to avoid cast.
5264 (Fdbus_method_return_internal, Fdbus_method_error_internal): Likewise.
5265 * font.c (font_unparse_xlfd): Avoid potential buffer overrun on
5267 (font_unparse_xlfd, font_unparse_fcname): Use pI to avoid casts.
5268 * keyboard.c (record_char, modify_event_symbol): Use pI to avoid casts.
5269 * print.c (safe_debug_print, print_object): Likewise.
5270 (print_object): Don't overflow by converting EMACS_INT or EMACS_UINT
5272 Use pI instead of if-then-else-abort. Use %p to avoid casts,
5273 avoiding the 0 flag, which is not portable.
5274 * process.c (Fmake_network_process): Use pI to avoid cast.
5275 * region-cache.c (pp_cache): Likewise.
5276 * xdisp.c (decode_mode_spec): Likewise.
5277 * xrdb.c (x_load_resources) [USE_MOTIF]: Use pI to avoid undefined
5278 behavior on 64-bit hosts with printf arg.
5279 * xselect.c (x_queue_event): Use %p to avoid casts, avoiding 0 flag.
5280 (x_stop_queuing_selection_requests): Likewise.
5281 (x_get_window_property): Don't truncate byte count to an 'int'
5284 * frame.c (frame_name_fnn_p): Get rid of strtol, which isn't right
5285 here, since it parses constructs like leading '-' and spaces,
5286 which are not wanted; and it overflows with large numbers.
5287 Instead, simply match F[0-9]+, which is what is wanted anyway.
5289 * alloc.c: Remove unportable assumptions about struct layout.
5290 (SDATA_SELECTOR, SDATA_DATA_OFFSET): New macros.
5291 (SDATA_OF_STRING, SDATA_SIZE, allocate_string_data):
5292 (allocate_vectorlike, make_pure_vector): Use the new macros,
5293 plus offsetof, to remove unportable assumptions about struct layout.
5294 These assumptions hold on all porting targets that I know of, but
5295 they are not guaranteed, they're easy to remove, and removing them
5296 makes further changes easier.
5298 * alloc.c (BLOCK BYTES): Fix typo by changing "ablock" to "ablocks".
5299 This doesn't fix a bug but makes the code clearer.
5300 (string_overrun_cookie): Now const. Use initializers that
5301 don't formally overflow signed char, to avoid warnings.
5302 (allocate_string_data) [GC_CHECK_STRING_OVERRUN]: Fix typo that
5303 can cause Emacs to crash when string overrun checking is enabled.
5304 (allocate_buffer): Don't assume sizeof (struct buffer) is a
5305 multiple of sizeof (EMACS_INT); it need not be, if
5306 alignof(EMACS_INT) < sizeof (EMACS_INT).
5307 (check_sblock, check_string_bytes, check_string_free_list): Protoize.
5309 2011-04-26 Juanma Barranquero <lekktu@gmail.com>
5311 * keyboard.c (QCrtl): Rename from Qrtl. All uses changed.
5313 2011-04-26 Teodor Zlatanov <tzz@lifelogs.com>
5315 * gnutls.c (emacs_gnutls_handshake): Return an error if we're not
5316 supposed to be handshaking. (Bug#8556)
5317 Reported by Paul Eggert <eggert@cs.ucla.edu>.
5319 2011-04-26 Daniel Colascione <dan.colascione@gmail.com>
5321 * lisp.h (Qdebug): List symbol.
5322 * eval.c (Qdebug): Restore global linkage.
5323 * keyboard.c (debug-on-event): New variable.
5324 (handle_user_signal): Break into debugger when debug-on-event
5325 matches the current signal symbol.
5327 2011-04-25 Dan Nicolaescu <dann@ics.uci.edu>
5329 * alloc.c (check_sblock, check_string_bytes)
5330 (check_string_free_list): Convert to standard C.
5332 2011-04-25 Teodor Zlatanov <tzz@lifelogs.com>
5334 * w32.c (emacs_gnutls_push): Fix typo.
5336 2011-04-25 Eli Zaretskii <eliz@gnu.org>
5338 * gnutls.c (emacs_gnutls_handshake): Avoid compiler warnings about
5339 "cast to pointer from integer of different size".
5341 Improve doprnt and its use in verror. (Bug#8545)
5342 * doprnt.c (doprnt): Document the set of format control sequences
5343 supported by the function. Use SAFE_ALLOCA instead of always
5346 * eval.c (verror): Don't limit the buffer size at size_max-1, that
5347 is one byte too soon. Don't use xrealloc; instead xfree and
5350 2011-04-24 Teodor Zlatanov <tzz@lifelogs.com>
5352 * gnutls.h: Add GNUTLS_STAGE_CALLBACKS enum to denote we're in the
5355 * gnutls.c: Renamed global_initialized to
5356 gnutls_global_initialized. Added internals for the
5357 :verify-hostname-error, :verify-error, and :verify-flags
5358 parameters of `gnutls-boot' and documented those parameters in the
5359 docstring. Start callback support.
5360 (emacs_gnutls_handshake): Add Woe32 support. Retry handshake
5361 unless a fatal error occurred. Call gnutls_alert_send_appropriate
5362 on error. Return error code.
5363 (emacs_gnutls_write): Call emacs_gnutls_handle_error.
5364 (emacs_gnutls_read): Likewise.
5365 (Fgnutls_boot): Return handshake error code.
5366 (emacs_gnutls_handle_error): New function.
5367 (wsaerror_to_errno): Likewise.
5369 * w32.h (emacs_gnutls_pull): Add prototype.
5370 (emacs_gnutls_push): Likewise.
5372 * w32.c (emacs_gnutls_pull): New function for GnuTLS on Woe32.
5373 (emacs_gnutls_push): Likewise.
5375 2011-04-24 Claudio Bley <claudio.bley@gmail.com> (tiny change)
5377 * process.c (wait_reading_process_output): Check if GnuTLS
5378 buffered some data internally if no FDs are set for TLS
5381 * makefile.w32-in (OBJ2): Add gnutls.$(O).
5382 (LIBS): Link to USER_LIBS.
5383 ($(BLD)/gnutls.$(0)): New target.
5385 2011-04-24 Eli Zaretskii <eliz@gnu.org>
5387 * xdisp.c (handle_single_display_spec): Rename the
5388 display_replaced_before_p argument into display_replaced_p, to
5389 make it consistent with the commentary. Fix typos in the
5392 * textprop.c (syms_of_textprop): Remove dead code.
5393 (copy_text_properties): Delete obsolete commentary about an
5394 interface that was deleted long ago. Fix typos in the description
5397 * msdos.c (XMenuActivate, XMenuAddSelection): Adjust argument list
5398 to changes in oldXMenu/XMenu.h from 2011-04-16.
5399 <menu_help_message, prev_menu_help_message>: Constify.
5400 (IT_menu_make_room): menu->help_text is now `const char **';
5403 * msdos.h (XMenuActivate, XMenuAddSelection): Adjust prototypes
5404 to changes in oldXMenu/XMenu.h from 2011-04-16.
5405 (struct XMenu): Declare `help_text' `const char **'.
5407 * xfaces.c <Qunspecified>: Make extern again.
5409 * syntax.c: Include sys/types.h before including regex.h, as
5412 * doc.c (get_doc_string): Improve the format passed to `error'.
5414 * doprnt.c (doprnt): Improve commentary.
5416 * term.c (init_tty) [MSDOS]: Fix 1st argument to maybe_fatal.
5418 * Makefile.in (TAGS): Depend on $(M_FILE) and $(S_FILE), and scan
5421 * makefile.w32-in (globals.h): Add a dummy recipe, to make any
5422 changes in globals.h immediately force recompilation.
5423 (TAGS): Depend on $(CURDIR)/m/intel386.h and
5424 $(CURDIR)/s/ms-w32.h.
5425 (TAGS-gmake): Scan $(CURDIR)/m/intel386.h and $(CURDIR)/s/ms-w32.h.
5427 * character.c (Fchar_direction): Function deleted.
5428 (syms_of_character): Don't defsubr it.
5429 <char-direction-table>: Deleted.
5431 2011-04-23 Eli Zaretskii <eliz@gnu.org>
5433 Fix doprnt so it could be used again safely in `verror'. (Bug#8435)
5434 * doprnt.c: Include limits.h.
5435 (SIZE_MAX): New macro.
5436 (doprnt): Return a size_t value. 2nd arg is now size_t.
5437 Many local variables are now size_t instead of int or unsigned.
5438 Improve overflow protection. Support `l' modifier for integer
5439 conversions. Support %l conversion. Don't assume an EMACS_INT
5440 argument for integer conversions and for %c.
5442 * lisp.h (doprnt): Restore prototype.
5444 * makefile.w32-in ($(BLD)/callint.$(O)): Depend on
5447 * Makefile.in (base_obj): Add back doprnt.o.
5449 * deps.mk (doprnt.o): Add back prerequisites.
5450 (callint.o): Depend on character.h.
5452 * eval.c (internal_lisp_condition_case): Include the handler
5453 representation in the error message.
5454 (verror): Call doprnt instead of vsnprintf. Fix an off-by-one bug
5455 when breaking from the loop.
5457 * xdisp.c (vmessage): Call doprnt instead of vsnprintf.
5459 * callint.c (Fcall_interactively): When displaying error message
5460 about invalid control letter, pass the character's codepoint, not
5461 a pointer to its multibyte form. Improve display of the character
5462 in octal and display also its hex code.
5464 * character.c (char_string): Use %x to display the (unsigned)
5465 codepoint of an invalid character, to avoid displaying a bogus
5468 * font.c (check_otf_features): Pass SDATA of SYMBOL_NAME to
5469 `error', not SYMBOL_NAME itself.
5471 * coding.c (Fencode_sjis_char, Fencode_big5_char): Use %c for
5472 character arguments to `error'.
5474 * charset.c (check_iso_charset_parameter): Fix incorrect argument
5475 to `error' in error message about FINAL_CHAR argument. Make sure
5476 FINAL_CHAR is a character, and use %c when it is passed as
5477 argument to `error'.
5479 2011-04-23 Eli Zaretskii <eliz@gnu.org>
5481 * s/ms-w32.h (localtime): Redirect to sys_localtime.
5483 * w32.c: Include <time.h>.
5484 (sys_localtime): New function.
5486 2011-04-23 Chong Yidong <cyd@stupidchicken.com>
5488 * xdisp.c (init_xdisp): Initialize echo_area_window (Bug#6451).
5490 * buffer.c (syms_of_buffer): Doc fix (Bug#6902).
5492 2011-04-23 Samuel Thibault <sthibault@debian.org> (tiny change)
5494 * sysdep.c (wait_for_termination): On GNU Hurd, kill returns -1 on
5497 2011-04-19 Eli Zaretskii <eliz@gnu.org>
5499 * syntax.h (SETUP_SYNTAX_TABLE_FOR_OBJECT): Fix setting of
5500 gl_state.e_property when gl_state.object is Qt.
5502 * insdel.c (make_gap_larger): Remove limitation of buffer size
5505 2011-04-18 Chong Yidong <cyd@stupidchicken.com>
5507 * xdisp.c (lookup_glyphless_char_display)
5508 (produce_glyphless_glyph): Handle cons cell entry in
5509 glyphless-char-display.
5510 (Vglyphless_char_display): Document it.
5512 * term.c (produce_glyphless_glyph): Handle cons cell entry in
5513 glyphless-char-display.
5515 2011-04-17 Chong Yidong <cyd@stupidchicken.com>
5517 * xdisp.c (get_next_display_element): Remove unnecessary ifdefs.
5519 * termhooks.h (FRAME_WINDOW_P): Remove duplicated definitions.
5521 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): Add missing
5522 definition for no-X builds.
5524 2011-04-16 Paul Eggert <eggert@cs.ucla.edu>
5526 Static checks with GCC 4.6.0 and non-default toolkits.
5528 * s/sol2-6.h, s/unixware.h (PTY_TTY_NAME_SPRINTF): Protoize decl.
5530 * process.c (keyboard_bit_set): Define only if SIGIO.
5531 (send_process_trap): Mark it with NO_RETURN if it doesn't return.
5532 (send_process): Repair possible setjmp clobbering.
5534 * s/usg5-4-common.h (SETUP_SLAVE_PTY): Don't pass extra arg to 'fatal'.
5536 * eval.c: Include <stdio.h>, for vsnprintf on non-GNU/Linux hosts.
5538 * data.c (arith_error): Mark with NO_RETURN if it doesn't return.
5540 * alloc.c (bytes_used_when_full, SPARE_MEMORY, BYTES_USED):
5541 Define only if needed.
5543 * sysdep.c (_FILE_OFFSET_BITS): Make this hack even uglier
5544 by pacifying GCC about it. Maybe it's time to retire it?
5545 * xfaces.c (USG, __TIMEVAL__): Likewise.
5547 * dispextern.h (struct redisplay_interface): Rename param
5549 * termhooks.h (struct terminal): Likewise.
5550 * xterm.c (xembed_send_message): Likewise.
5552 * insdel.c (make_gap_smaller): Define only if
5553 USE_MMAP_FOR_BUFFERS || REL_ALLOC || DOUG_LEA_MALLOC.
5555 * keyboard.c (read_char): Make a var volatile so longjmp won't clobber
5558 * emacs.c (MAX_HEAP_BSS_DIFF, my_edata): Move to where they're used,
5559 so that we aren't warned about unused symbols.
5561 * xfns.c (Fx_file_dialog): Rename local to avoid shadowing.
5563 * xdisp.c (x_produce_glyphs): Mark var as initialized (Bug#8512).
5565 * xfns.c (x_real_positions): Mark locals as initialized.
5567 * xmenu.c (xmenu_show): Don't use uninitialized vars.
5569 * xterm.c: Fix problems found by static analysis with other toolkits.
5570 (toolkit_scroll_bar_interaction): Define and use only if USE_X_TOOLKIT.
5571 (x_dispatch_event): Declare static if USE_GTK, and
5572 define if USE_GTK || USE_X_TOOLKIT.
5573 (SET_SAVED_BUTTON_EVENT): Define only if USE_X_TOOLKIT || USE_GTK.
5574 * xterm.h (x_dispatch_event): Extern only if USE_X_TOOLKIT.
5575 * xterm.c, xterm.h (x_mouse_leave): Bring this function back, but only
5576 if defined HAVE_MENUS && !defined USE_X_TOOLKIT && !defined USE_GTK.
5578 * xmenu.c (menu_help_callback): Pointer type fixes.
5579 Use const pointers when pointing at readonly data. Avoid pointer
5581 (FALSE): Remove unused macro.
5582 (update_frame_menubar): Remove unused decl.
5584 * xfns.c (Fx_hide_tip): Move locals to avoid shadowing.
5586 * menu.c (push_submenu_start, push_submenu_end): Do not define unless
5587 USE_X_TOOLKIT || USE_GTK || HAVE_NS || defined HAVE_NTGUI.
5588 (single_menu_item): Rename local to avoid shadowing.
5590 * keyboard.c (make_lispy_event): Remove unused local var.
5592 * frame.c, frame.h (x_get_resource_string): Bring this back, but
5593 only if HAVE_X_WINDOWS && !USE_X_TOOLKIT.
5595 * bitmaps: Change bitmaps from unsigned char back to the X11
5596 compatible char. Avoid the old compiler warnings about
5597 out-of-range initializers by using, for example, '\xab' rather
5600 * xgselect.c (xgselect_initialize): Check vs interface
5601 even if ! (defined (USE_GTK) || defined (HAVE_GCONF)).
5603 * xmenu.c (xmenu_show): Rename parm to avoid shadowing.
5605 * xterm.c (x_create_toolkit_scroll_bar): Use const * for pointers
5606 to read-only memory.
5608 * fns.c (vector): Remove; this old hack is no longer needed.
5610 * xsmfns.c (create_client_leader_window): Rename shadowing arg.
5612 (gdk_x11_set_sm_client_id) [!USE_GTK]: Don't define.
5614 * xrdb.c (x_load_resources): Omit unused local.
5616 * xfns.c (free_frame_menubar, atof): Remove duplicate decls.
5617 (x_window): Rename locals to avoid shadowing.
5618 (USG): Use the kludged USG macro, to pacify gcc.
5620 * xterm.c (x_alloc_nearest_color_for_widget): Remove; unused.
5621 (x_term_init): Remove local to avoid shadowing.
5623 * xfns.c, xterm.c (_XEditResCheckMessages): Protoize decl.
5625 * xdisp.c, dispextern.h (set_vertical_scroll_bar): Now extern if
5626 USE_TOOLKIT_SCROLL_BARS && !USE_GTK, as xterm.c needs it then.
5628 2011-04-16 Eli Zaretskii <eliz@gnu.org>
5630 * gnutls.c (Fgnutls_boot): Don't pass Lisp_Object to `error'.
5632 Fix regex.c, syntax.c and friends for buffers > 2GB.
5633 * syntax.h (struct gl_state_s): Declare character position members
5636 * syntax.c (update_syntax_table): Declare 2nd argument EMACS_INT.
5638 * textprop.c (verify_interval_modification, interval_of):
5639 Declare arguments EMACS_INT.
5641 * intervals.c (adjust_intervals_for_insertion): Declare arguments
5644 * intervals.h (CHECK_TOTAL_LENGTH): Cast to EMACS_INT, not `int'.
5646 * indent.c (Fvertical_motion): Local variable it_start is now
5649 * regex.c (re_match, re_match_2, re_match_2_internal)
5650 (bcmp_translate, regcomp, regexec, print_double_string)
5651 (group_in_compile_stack, re_search, re_search_2, regex_compile)
5652 (re_compile_pattern, re_exec): Declare arguments and local
5653 variables `size_t' and `ssize_t' and return values `regoff_t', as
5655 (POP_FAILURE_REG_OR_COUNT) <pfreg>: Declare `long'.
5656 (CHECK_INFINITE_LOOP) <failure>: Declare `ssize_t'.
5657 <compile_stack_type>: `size' and `avail' are now `size_t'.
5659 * regex.h <regoff_t>: Use ssize_t, not int.
5660 (re_search, re_search_2, re_match, re_match_2): Arguments that
5661 specify buffer/string position and length are now ssize_t and
5662 size_t. Return type is regoff_t.
5664 2011-04-16 Ben Key <bkey76@gmail.com>
5666 * nsfont.m: Fixed bugs in ns_get_family and
5667 ns_descriptor_to_entity that were caused by using free to
5668 deallocate memory blocks that were allocated by xmalloc (via
5669 xstrdup). This caused Emacs to crash when compiled with
5670 XMALLOC_OVERRUN_CHECK defined (when Emacs was configured with
5671 --enable-checking=xmallocoverrun). xfree is now used to
5672 deallocate these memory blocks.
5674 2011-04-15 Paul Eggert <eggert@cs.ucla.edu>
5676 * sysdep.c (emacs_read): Remove unnecessary check vs MAX_RW_COUNT.
5678 emacs_write: Accept and return EMACS_INT for sizes.
5679 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html
5681 * gnutls.c, gnutls.h (emacs_gnutls_read, emacs_gnutls_write):
5682 Accept and return EMACS_INT.
5683 (emacs_gnutls_write): Return the number of bytes written on
5685 * sysdep.c, lisp.h (emacs_read, emacs_write): Likewise.
5686 (emacs_read, emacs_write): Remove check for negative size, as the
5687 Emacs source code has been audited now.
5688 * sysdep.c (MAX_RW_COUNT): New macro, to work around kernel bugs.
5689 (emacs_read, emacs_write): Use it.
5690 * process.c (send_process): Adjust to the new signatures of
5691 emacs_write and emacs_gnutls_write. Do not attempt to store
5692 a byte offset into an 'int'; it might overflow.
5693 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00483.html
5695 * sound.c: Don't assume sizes fit in 'int'.
5696 (struct sound_device.period_size, alsa_period_size):
5697 Return EMACS_INT, not int.
5698 (struct sound_device.write, vox_write, alsa_write):
5699 Accept EMACS_INT, not int.
5700 (wav_play, au_play): Use EMACS_INT to store sizes and to
5701 record read return values.
5703 2011-04-15 Ben Key <bkey76@gmail.com>
5705 * keyboard.c (Qundefined): Don't declare static since it is used
5707 * xfaces.c (Qbold, Qexpanded, Qitalic, Qcondensed): Don't declare
5708 static since they are used in nsfont.m.
5710 2011-04-15 Stefan Monnier <monnier@iro.umontreal.ca>
5712 * process.c (Qprocessp): Don't declare static.
5713 * lisp.h (Qprocessp): Declare again.
5715 2011-04-15 Juanma Barranquero <lekktu@gmail.com>
5717 * font.c (Qopentype): Don't make static (used from w32uniscribe.c).
5719 2011-04-14 Paul Eggert <eggert@cs.ucla.edu>
5721 Improve C-level modularity by making more things 'static'.
5723 Don't publish debugger-only interfaces to other modules.
5724 * lisp.h (safe_debug_print, debug_output_compilation_hack):
5725 (verify_bytepos, count_markers): Move decls to the only modules
5727 * region-cache.h (pp_cache): Likewise.
5728 * window.h (check_all_windows): Likewise.
5729 * marker.c, print.c, region-cache.c, window.c: Decls moved here.
5731 * sysdep.c (croak): Now static, if
5732 defined TIOCNOTTY || defined USG5 || defined CYGWIN.
5733 * syssignal.h (croak): Declare only if not static.
5735 * alloc.c (refill_memory_reserve): Now static if
5736 !defined REL_ALLOC || defined SYSTEM_MALLOC.
5737 * lisp.h (refill_memory_reserve): Declare only if not static.
5739 * xsettings.c, xsettings.h (xsettings_get_system_normal_font):
5740 Define only if USE_LUCID.
5742 * xrdb.c (x_customization_string, x_rm_string): Now static.
5744 * xmenu.c (x_menu_wait_for_event): Export only if USE_MOTIF.
5745 * xterm.h (x_menu_wait_for_event): Declare only if USE_MOTIF.
5747 * xdisp.c (draw_row_with_mouse_face): Now static.
5748 * dispextern.h (draw_row_with_mouse_fave): Remove decl.
5750 * window.h (check_all_windows): Mark externally visible.
5752 * window.c (window_deletion_count): Now static.
5754 * undo.c: Make symbols static if they're not exported.
5755 (last_undo_buffer, last_boundary_position, pending_boundary):
5758 * textprop.c (interval_insert_behind_hooks): Now static.
5759 (interval_insert_in_front_hooks): Likewise.
5761 * term.c: Make symbols static if they're not exported.
5762 (tty_turn_off_highlight, get_tty_terminal, max_frame_cols):
5763 (max_frame_lines, tty_set_terminal_modes):
5764 (tty_reset_terminal_modes, tty_turn_off_highlight):
5765 (get_tty_terminal): Now static.
5766 (term_mouse_moveto): Do not define if HAVE_WINDOW_SYSTEM.
5767 * termhooks.h (term_mouse_moveto): Do not declare if
5769 * dispextern.h (tty_set_terminal_modes, tty_reset_terminal_modes):
5770 (tty_turn_off_highlight, get_tty_terminal): Remove decls.
5772 * sysdep.c: Make symbols static if they're not exported.
5773 (emacs_get_tty, emacs_set_tty, old_fcntl_flags, old_fcntl_owner):
5775 (sigprocmask_set, full_mask): Remove; unused.
5776 (wait_debugging): Mark as visible.
5777 * syssignal.h (SIGFULLMASK, full_mask): Remove decls.
5778 * systty.h (emacs_get_tty, emacs_set_tty): Remove decls.
5780 * syntax.c (syntax_temp): Define only if !__GNUC__.
5782 * sound.c (current_sound_device, current_sound): Now static.
5784 * search.c (searchbufs, searchbuf_head): Now static.
5786 * scroll.c (scroll_cost): Remove; unused.
5787 * dispextern.h (scroll_cost): Remove decl.
5789 * region-cache.h (pp_cache): Mark as externally visible.
5791 * process.c: Make symbols static if they're not exported.
5792 (process_tick, update_tick, create_process, chan_process):
5793 (Vprocess_alist, proc_buffered_char, datagram_access):
5794 (fd_callback_data, send_process_frame, process_sent_to): Now static.
5795 (deactivate_process): Mark defn as static, as well as decl.
5796 * lisp.h (create_process): Remove decl.
5797 * process.h (chan_process, Vprocess_alist): Remove decls.
5799 * print.c: Make symbols static if they're not exported.
5800 (print_depth, new_backquote_output, being_printed, print_buffer):
5801 (print_buffer_size, print_buffer_pos, print_buffer_pos_byte):
5802 (print_interval, print_number_index, initial_stderr_stream):
5804 * lisp.h (Fprinc): Remove decl.
5805 (debug_output_compilation_hack): Mark as externally visible.
5807 * sysdep.c (croak): Move decl from here to syssignal.h.
5808 * syssignal.h (croak): Put it here, so the API can be checked when
5809 'croak' is called from dissociate_if_controlling_tty.
5811 * minibuf.c: Make symbols static if they're not exported.
5812 (minibuf_save_list, choose_minibuf_frame): Now static.
5813 * lisp.h (choose_minibuf_frame): Remove decl.
5815 * lisp.h (verify_bytepos, count_markers): Mark as externally visible.
5817 * lread.c: Make symbols static if they're not exported.
5818 (read_objects, initial_obarray, oblookup_last_bucket_number):
5820 (make_symbol): Remove; unused.
5821 * lisp.h (initial_obarray, make_symbol): Remove decls.
5823 * keyboard.c: Make symbols static if they're not exported.
5824 (single_kboard, recent_keys_index, total_keys, recent_keys):
5825 (this_command_key_count_reset, raw_keybuf, raw_keybuf_count):
5826 (this_single_command_key_start, echoing, last_auto_save):
5827 (read_key_sequence_cmd, dribble, recursive_edit_unwind):
5828 (command_loop, echo_now, keyboard_init_hook, help_char_p):
5829 (quit_throw_to_read_char, command_loop_2, top_level_1, poll_timer):
5830 (Vlispy_mouse_stem, double_click_count):
5832 (force_auto_save_soon): Define only if SIGDANGER.
5833 (ignore_mouse_drag_p): Now static if
5834 !defined HAVE_WINDOW_SYSTEM || defined USE_GTK || defined HAVE_NS.
5835 (print_help): Remove; unused.
5836 (stop_character, last_timer_event): Mark as externally visible.
5837 * keyboard.h (ignore_mouse_drag_p): Declare only if
5838 defined HAVE_WINDOW_SYSTEM && !defined USE_GTK && !defined HAVE_NS.
5839 (echo_now, help_char_p, quit_throw_to_read_char): Remove decls.
5840 * lisp.h (echoing): Remove decl.
5841 (force_auto_save_soon): Declare only if SIGDANGER.
5842 * xdisp.c (redisplay_window): Simplify code, to make it more
5843 obvious that ignore_mouse_drag_p is not accessed if !defined
5844 USE_GTK && !defined HAVE_NS.
5846 * intervals.c: Make symbols static if they're not exported.
5847 (merge_properties_sticky, merge_interval_right, delete_interval):
5849 * intervals.h (merge_interval_right, delete_interval): Remove decls.
5851 * insdel.c: Make symbols static if they're not exported.
5852 However, leave prepare_to_modify_buffer alone. It's never
5853 called from outside this function, but that appears to be a bug.
5854 (combine_after_change_list, combine_after_change_buffer):
5855 (adjust_after_replace, signal_before_change): Now static.
5856 (adjust_after_replace_noundo): Remove; unused.
5857 * lisp.h (adjust_after_replace, adjust_after_replace_noundo):
5858 (signal_before_change): Remove decls.
5860 * indent.c (val_compute_motion, val_vmotion): Now static.
5862 * image.c: Make symbols static if they're not exported.
5863 * dispextern.h (x_create_bitmap_from_xpm_data): Do not declare
5865 * image.c (x_create_bitmap_from_xpm_data): Do not define if USE_GTK.
5866 (xpm_color_cache, ct_table, ct_colors_allocated): Now static.
5868 * fringe.c (standard_bitmaps): Now static.
5869 (max_used_fringe_bitmap): Now static, unless HAVE_NS.
5871 * frame.c: Make symbols static if they're not exported.
5872 (x_report_frame_params, make_terminal_frame): Now static.
5873 (get_frame_param): Now static, unless HAVE_NS.
5874 (x_fullscreen_adjust): Define if WINDOWSNT, not if HAVE_WINDOW_SYSTEM.
5875 (x_get_resource_string): Remove; not used.
5876 * frame.h (make_terminal_frame, x_report_frame_params):
5877 (x_get_resource_string); Remove decls.
5878 (x_fullscreen_adjust): Declare only if WINDOWSNT.
5879 * lisp.h (get_frame_param): Declare only if HAVE_NS.
5881 * font.c, fontset.c: Make symbols static if they're not exported.
5882 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): New macro.
5883 (FACE_SUITABLE_FOR_CHAR_P): Use it.
5884 * font.c (font_close_object): Now static.
5885 * font.h (font_close_object): Remove.
5886 * fontset.c (FONTSET_OBJLIST): Remove.
5887 (free_realized_fontset) #if-0 the body, which does nothing.
5888 (face_suitable_for_char_p): #if-0, as it's never called.
5889 * fontset.h (face_suitable_for_char_p): Remove decl.
5890 * xfaces.c (face_at_string_position):
5891 Use FACE_SUITABLE_FOR_ASCII_CHAR_P, not FACE_SUITABLE_FOR_CHAR_P,
5892 since 0 is always ASCII.
5894 * fns.c (weak_hash_tables): Now static.
5896 * fileio.c: Make symbols static if they're not exported.
5897 (auto_saving, auto_save_mode_bits, auto_save_error_occurred):
5898 (Vwrite_region_annotation_buffers): Now static.
5900 * eval.c: Make symbols static if they're not exported.
5901 (backtrace_list, lisp_eval_depth, when_entered_debugger): Now static.
5902 * lisp.h (backtrace_list): Remove decl.
5904 * emacs.c: Make symbols static if they're not exported.
5905 (malloc_state_ptr, malloc_using_checking, syms_of_emacs):
5906 (fatal_error_code, fatal_error_signal_hook, standard_args):
5908 (fatal_error_signal): Now static, unless FLOAT_CATCH_SIGKILL.
5909 (DEFINE_DUMMY_FUNCTION): Mark function as externally visible.
5910 (__CTOR_LIST__, __DTOR_LIST__): Now externally visible.
5911 * lisp.h (fatal_error_signal_hook): Remove decl.
5912 (fatal_error_signal): Declare only if FLOAT_CATCH_SIGKILL.
5914 * editfns.c: Move a (normally-unused) function to its only use.
5915 * editfns.c, lisp.h (get_operating_system_release): Remove.
5916 * process.c (init_process) [DARWIN_OS]: Do it inline, as it is not
5917 worth the hassle of breaking this out.
5919 * xterm.c: Make symbols static if they're not exported.
5920 (x_raise_frame, x_lower_frame, x_wm_set_window_state):
5921 (x_wm_set_icon_pixmap, x_initialize, XTread_socket_fake_io_error):
5922 (x_destroy_window, x_delete_display):
5924 (x_dispatch_event): Now static if ! (USE_MOTIF || USE_X_TOOLKIT).
5925 (x_mouse_leave): Remove; unused.
5926 * xterm.h (x_display_info_for_name, x_raise_frame, x_lower_frame):
5927 (x_destroy_window, x_wm_set_window_state, x_wm_set_icon_pixmap):
5928 (x_delete_display, x_initialize, x_set_border_pixel, x_screen_planes):
5930 (x_mouse_leave): Declare only if WINDOWSNT.
5931 (x_dispatch_event): Declare only if USE_MOTIF or USE_X_TOOLKIT.
5932 (xic_create_fontsetname): Declare only if HAVE_X_WINDOWS &&
5935 * ftxfont.c: Make symbols static if they're not exported.
5936 (ftxfont_driver): Export only if !defined HAVE_XFT && def8ined
5938 * font.h (ftxfont_driver): Likewise.
5940 * xfns.c: Make symbols static if they're not exported.
5941 (x_last_font_name, x_display_info_for_name):
5942 (x_set_foreground_color, x_set_background_color, x_set_mouse_color):
5943 (x_set_cursor_color, x_set_border_pixel, x_set_border_color):
5944 (x_set_cursor_type, x_set_icon_type, x_set_icon_name):
5945 (x_set_scroll_bar_foreground, x_set_scroll_bar_background):
5946 (x_explicitly_set_name, x_set_title, xic_defaut_fontset, tip_timer):
5947 (last_show_tip_args): Now static.
5948 (xic_defaut_fontset, xic_create_fontsetname): Define only if
5949 defined HAVE_X_WINDOWS && defined USE_X_TOOLKIT
5950 (x_screen_planes): Remove; unused.
5951 * dispextern.h (x_screen_planes): Remove decl.
5953 * dispnew.c: Make symbols static if they're not exported.
5954 * dispextern.h (redraw_garbaged_frames, scrolling):
5955 (increment_row_positions): Remove.
5956 * dispnew.c (new_glyph_matrix, increment_row_positions, scrolling):
5957 (delayed_size_change, glyph_matrix_count, glyph_pool_count):
5959 (redraw_garbaged_frames): Remove; unused.
5961 * xfaces.c: Make symbols static if they're not exported.
5962 * dispextern.h (ascii_face_of_lisp_face, free_realized_face):
5964 * xterm.h (defined_color): Remove decls.
5965 (x_free_dpy_colors): Declare only if USE_X_TOOLKIT.
5966 * xfaces.c (tty_suppress_bold_inverse_default_colors_p):
5967 (menu_face_changed_default, defined_color, free_realized_face):
5968 (x_free_dpy_colors): Define only if USE_X_TOOLKIT.
5969 (ascii_face_of_lisp_face): Remove; unused.
5971 * xdisp.c: Make symbols static if they're not exported.
5972 * dispextern.h (scratch_glyph_row, window_box_edges):
5973 (glyph_to_pixel_coords, set_cursor_from_row):
5974 (get_next_display_element, set_iterator_to_next):
5975 (highlight_trailing_whitespace, frame_to_window_pixel_xy):
5976 (show_mouse_face): Remove decls
5977 * frame.h (message_buf_print): Likewise.
5978 * lisp.h (pop_message, set_message, check_point_in_composition):
5980 * xterm.h (set_vertical_scroll_bar): Likewise.
5981 * xdisp.c (list_of_error, Vmessage_stack, line_number_displayed):
5982 (message_buf_print, scratch_glyph_row, displayed_buffer):
5983 (set_iterator_to_next, pop_message, set_message, set_cursor_from_row):
5984 (get_next_display_element, show_mouse_face, window_box_edges):
5985 (frame_to_window_pixel_xy, check_point_in_composition):
5986 (set_vertical_scroll_bar, highlight_trailing_whitespace): Now static.
5987 (glyph_to_pixel_coords): Remove; unused.
5989 * dired.c (file_name_completion): Now static.
5991 * dbusbind.c (xd_in_read_queued_messages): Now static.
5993 * lisp.h (circular_list_error, FOREACH): Remove; unused.
5994 * data.c (circular_list_error): Remove.
5996 * commands.h (last_point_position, last_point_position_buffer):
5997 (last_point_position_window): Remove decls.
5998 * keyboard.c: Make these variables static.
6000 * coding.h (coding, code_convert_region, encode_coding_gap):
6002 * coding.c (Vsjis_coding_system, Vbig5_coding_system):
6003 (iso_code_class, detect_coding, code_convert_region): Now static.
6004 (encode_coding_gap): Remove; unused.
6006 * chartab.c (chartab_chars, chartab_bits): Now static.
6008 * charset.h (charset_iso_8859_1): Remove decl.
6009 * charset.c (charset_iso_8859_1, charset_emacs, map_charset_for_dump):
6012 * ccl.h (check_ccl_update, Vccl_program_table): Remove decls.
6013 * ccl.c (Vccl_program_table): Now static.
6014 (check_ccl_update): Remove; unused.
6016 * category.c (SET_CATEGORY_SET, set_category_set): Move here.
6017 * category.h: ... from here.
6018 * category.c (check_category_table, set_category_set): Now static.
6020 * casetab.c (Vascii_upcase_table, Vascii_eqv_table): Now static.
6021 * lisp.h: Remove these decls.
6023 * buffer.c (buffer_count): Remove unused var.
6025 * bidi.c (bidi_dump_cached_states): Mark as externally visible,
6026 so that it's not optimized away.
6027 (bidi_ignore_explicit_marks_for_paragraph_level): Likewise.
6028 * dispextern.h (bidi_dump_cached_states): Remove, since it's
6029 exported only to the debugger.
6031 * atimer.c (alarm_signal_handler, run_all_atimers): Now static.
6032 * atimer.h (run_all_atimers): Remove; not exported.
6034 font.c: Make copy_font_spec and merge_font_spec ordinary C functions.
6035 * font.c (copy_font_spec): Rename from Fcopy_font_spec, since it
6036 was inaccessible from Lisp.
6037 (merge_font_spec): Likewise, renaming from Fmerge_font_spec.
6038 * font.c, font.h, fontset.c, xfaces.c, xfont.c: Change all uses.
6040 alloc.c: Import and export fewer symbols, and remove unused items.
6041 * lisp.h (suppress_checking, die): Declare only if ENABLE_CHECKING
6043 (suppress_checking): Add EXTERNALLY_VISIBLE attribute, so that
6044 it's not optimized away by whole-program optimization.
6045 (message_enable_multibyte, free_misc): Remove.
6046 (catchlist, handlerlist, mark_backtrace):
6047 Declare only if BYTE_MARK_STACK.
6048 (mark_byte_stack): Likewise, fixing a ifdef-vs-if typo.
6049 * alloc.c (pure): Export only if VIRT_ADDR_VARIES is defined.
6050 (message_enable_multibyte): Remove decl.
6051 (free_misc, interval_free_list, float_block, float_block_index):
6052 (n_float_blocks, float_free_list, cons_block, cons_block_index):
6053 (cons_free_list, last_marked_index):
6055 (suppress_checking, die): Define only if ENABLE_CHECKING is defined.
6056 * eval.c (catchlist, handlerlist): Export only if BYTE_MARK_STACK.
6057 (mark_backtrace): Define only if BYTE_MARK_STACK.
6058 * xdisp.c (message_enable_multibyte): Now static.
6060 Declare Lisp_Object Q* variables to be 'static' if not exported.
6061 This makes it easier for human readers (and static analyzers)
6062 to see whether these variables are used from other modules.
6063 * alloc.c, buffer.c, bytecode.c, callint.c, casetab.c, category.c:
6064 * ccl.c, character.c, charset.c, cmds.c, coding.c, composite.c:
6065 * data.c, dbusbind.c, dired.c, editfns.c, eval.c, fileio.c, fns.c:
6066 * font.c, frame.c, fringe.c, ftfont.c, image.c, keyboard.c, keymap.c:
6067 * lread.c, macros.c, minibuf.c, print.c, process.c, search.c:
6068 * sound.c, syntax.c, textprop.c, window.c, xdisp.c, xfaces.c, xfns.c:
6069 * xmenu.c, xselect.c:
6070 Declare Q* vars static if they are not used in other modules.
6071 * ccl.h, character.h, charset.h, coding.h, composite.h, font.h:
6072 * frame.h, intervals.h, keyboard.h, lisp.h, process.h, syntax.h:
6073 Remove decls of unexported vars.
6074 * keyboard.h (EVENT_HEAD_UNMODIFIED): Remove now-unused macro.
6076 * lisp.h (DEFINE_FUNC): Make sname 'static'.
6078 Make Emacs functions such as Fatom 'static' by default.
6079 This makes it easier for human readers (and static analyzers)
6080 to see whether these functions can be called from other modules.
6081 DEFUN now defines a static function. To make the function external
6082 so that it can be used in other C modules, use the new macro DEFUE.
6083 * lisp.h (Funibyte_char_to_multibyte, Fsyntax_table_p):
6084 (Finit_image_library):
6085 (Feval_region, Fbacktrace, Ffetch_bytecode, Fswitch_to_buffer):
6086 (Ffile_executable_p, Fmake_symbolic_link, Fcommand_execute):
6087 (Fget_process, Fdocumentation_property, Fbyte_code, Ffile_attributes):
6088 Remove decls, since these functions are now static.
6089 (Funintern, Fget_internal_run_time): New decls, since these functions
6090 were already external.
6092 * alloc.c, buffer.c, callint.c, callproc.c, casefiddle.c, casetab.c:
6093 * ccl.c, character.c, chartab.c, cmds.c, coding.c, data.c, dispnew.c:
6094 * doc.c, editfns.c, emacs.c, eval.c, fileio.c, filelock.c, floatfns.c:
6095 * fns.c, font.c, fontset.c, frame.c, image.c, indent.c:
6096 * keyboard.c, keymap.c, lread.c:
6097 * macros.c, marker.c, menu.c, minibuf.c, print.c, process.c, search.c:
6098 * syntax.c, term.c, terminal.c, textprop.c, undo.c:
6099 * window.c, xdisp.c, xfaces.c, xfns.c, xmenu.c, xsettings.c:
6100 Mark functions with DEFUE instead of DEFUN,
6101 if they are used in other modules.
6102 * buffer.c (Fset_buffer_major_mode, Fdelete_overlay): New forward
6103 decls for now-static functions.
6104 * buffer.h (Fdelete_overlay): Remove decl.
6105 * callproc.c (Fgetenv_internal): Mark as internal.
6106 * composite.c (Fremove_list_of_text_properties): Remove decl.
6107 (Fcomposition_get_gstring): New forward static decl.
6108 * composite.h (Fcomposite_get_gstring): Remove decl.
6109 * dired.c (Ffile_attributes): New forward static decl.
6110 * doc.c (Fdocumntation_property): New forward static decl.
6111 * eval.c (Ffetch_bytecode): New forward static decl.
6112 (Funintern): Remove extern decl; now in .h file where it belongs.
6113 * fileio.c (Fmake_symbolic_link): New forward static decl.
6114 * image.c (Finit_image_library): New forward static decl.
6115 * insdel.c (Fcombine_after_change_execute): Make forward decl static.
6116 * intervals.h (Fprevious_property_change):
6117 (Fremove_list_of_text_properties): Remove decls.
6118 * keyboard.c (Fthis_command_keys): Remove decl.
6119 (Fcommand_execute): New forward static decl.
6120 * keymap.c (Flookup_key): New forward static decl.
6121 (Fcopy_keymap): Now static.
6122 * keymap.h (Flookup_key): Remove decl.
6123 * process.c (Fget_process): New forward static decl.
6124 (Fprocess_datagram_address): Mark as internal.
6125 * syntax.c (Fsyntax_table_p): New forward static decl.
6126 (skip_chars): Remove duplicate decl.
6127 * textprop.c (Fprevious_property_change): New forward static decl.
6128 * window.c (Fset_window_fringes, Fset_window_scroll_bars):
6130 (Fset_window_margins, Fset_window_vscroll): New forward static decls.
6131 * window.h (Fset_window_vscroll, Fset_window_margins): Remove decls.
6133 * editfns.c (Fformat): Remove unreachable code.
6135 2011-04-14 Andreas Schwab <schwab@linux-m68k.org>
6137 * fileio.c (Finsert_file_contents): Fix typo in 2005-05-13
6140 2011-04-13 Eli Zaretskii <eliz@gnu.org>
6142 * xdisp.c (handle_invisible_prop): Don't call bidi_paragraph_init
6143 when at ZV. (Bug#8487)
6145 2011-04-12 Andreas Schwab <schwab@linux-m68k.org>
6147 * charset.c (Fclear_charset_maps): Use xfree instead of free.
6149 * keyboard.c (parse_tool_bar_item): Likewise.
6150 * sound.c (sound_cleanup, alsa_close): Likewise.
6151 * termcap.c (tgetent): Likewise.
6152 * xfns.c (x_default_font_parameter): Likewise.
6153 * xsettings.c (read_and_apply_settings): Likewise.
6155 * alloc.c (overrun_check_malloc, overrun_check_realloc)
6156 (overrun_check_free): Protoize.
6158 2011-04-12 Paul Eggert <eggert@cs.ucla.edu>
6160 * sysdep.c (emacs_read, emacs_write): Check for negative sizes
6161 since callers should never pass a negative size.
6162 Change the signature to match that of plain 'read' and 'write'; see
6163 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00397.html>.
6164 * lisp.h: Update prototypes of emacs_write and emacs_read.
6166 2011-04-11 Eli Zaretskii <eliz@gnu.org>
6168 * xdisp.c (redisplay_window): Don't try to determine the character
6169 position of the scroll margin if the window start point w->startp
6170 is outside the buffer's accessible region. (Bug#8468)
6172 2011-04-10 Eli Zaretskii <eliz@gnu.org>
6174 Fix write-region and its subroutines for buffers > 2GB.
6175 * fileio.c (a_write, e_write): Modify declaration of arguments and
6176 local variables to support buffers larger than 2GB.
6177 (Fcopy_file): Use EMACS_INT for return value of emacs_read.
6179 * sysdep.c (emacs_write, emacs_read): Use ssize_t for last
6180 argument, local variables, and return value.
6182 * lisp.h: Update prototypes of emacs_write and emacs_read.
6184 * sound.c (vox_write): Use ssize_t for return value of emacs_write.
6186 2011-04-10 Paul Eggert <eggert@cs.ucla.edu>
6188 * xdisp.c (vmessage): Use memchr, not strnlen, which some hosts lack.
6190 Fix more problems found by GCC 4.6.0's static checks.
6192 * xdisp.c (vmessage): Use a better test for character truncation.
6194 * charset.c (load_charset_map): <, not <=, for optimization,
6195 and to avoid potential problems with integer overflow.
6196 * chartab.c (sub_char_table_set_range, char_table_set_range): Likewise.
6197 * casetab.c (set_identity, shuffle): Likewise.
6198 * editfns.c (Fformat): Likewise.
6199 * syntax.c (skip_chars): Likewise.
6201 * xmenu.c (set_frame_menubar): Allocate smaller local vectors.
6202 This also lets GCC 4.6.0 generate slightly better loop code.
6204 * callint.c (Fcall_interactively): <, not <=, for optimization.
6205 (Fcall_interactively): Count the number of arguments produced,
6206 not the number of arguments given. This is simpler and lets GCC
6207 4.6.0 generate slightly better code.
6209 * ftfont.c: Distingish more carefully between FcChar8 and char.
6210 The previous code passed unsigned char * to a functions like
6211 strlen and xstrcasecmp that expect char *, which does not
6212 conform to the C standard.
6213 (get_adstyle_property, ftfont_pattern_entity): Use FcChar8 for
6214 arguments to FcPatternGetString, and explicitly cast FcChar8 * to
6215 char * when the C standard requires it.
6217 * keyboard.c (read_char): Remove unused var.
6219 * eval.c: Port to Windows vsnprintf (Bug#8435).
6221 (SIZE_MAX): Define if the headers do not.
6222 (verror): Do not give up if vsnprintf returns a negative count.
6223 Instead, grow the buffer. This ports to Windows vsnprintf, which
6224 does not conform to C99. Problem reported by Eli Zaretskii.
6225 Also, simplify the allocation scheme, by avoiding the need for
6226 calling realloc, and removing the ALLOCATED variable.
6228 * eval.c (verror): Initial buffer size is 4000 (not 200) bytes.
6230 Remove invocations of doprnt, as Emacs now uses vsnprintf.
6231 But keep the doprint source code for now, as we might revamp it
6232 and use it again (Bug#8435).
6233 * lisp.h (doprnt): Remove.
6234 * Makefile.in (base_obj): Remove doprnt.o.
6235 * deps.mk (doprnt.o): Remove.
6237 error: Print 32- and 64-bit integers portably (Bug#8435).
6238 Without this change, on typical 64-bit hosts error ("...%d...", N)
6239 was used to print both 32- and 64-bit integers N, which relied on
6241 * lisp.h, src/m/amdx86-64.h, src/m/ia64.h, src/m/ibms390x.h (pEd):
6243 * lisp.h (error, verror): Mark as printf-like functions.
6244 * eval.c (verror): Use vsnprintf, not doprnt, to do the real work.
6245 Report overflow in size calculations when allocating printf buffer.
6246 Do not truncate output string at its first null byte.
6247 * xdisp.c (vmessage): Use vsnprintf, not doprnt, to do the real work.
6248 Truncate the output at a character boundary, since vsnprintf does not
6250 * charset.c (check_iso_charset_parameter): Convert internal
6251 character to string before calling 'error', since %c now has the
6253 * coding.c (Fdecode_sjis_char, Fdecode_big5_char): Avoid int
6254 overflow when computing char to be passed to 'error'. Do not
6255 pass Lisp_Object to 'error'; pass the integer instead.
6256 * nsfns.m (Fns_do_applescript): Use int, not long, since it's
6257 formatted with plain %d.
6259 * eval.c (internal_lisp_condition_case): Don't pass spurious arg.
6261 * keyboard.c (access_keymap_keyremap): Print func name, not garbage.
6263 * coding.c (Fdecode_sjis_char): Don't assume CODE fits in int.
6265 * xterm.c (x_catch_errors): Remove duplicate declaration.
6267 * term.c (maybe_fatal): Mark its 3rd arg as a printf format, too.
6269 * xdisp.c, lisp.h (message_nolog): Remove; unused.
6271 2011-04-10 Jim Meyering <meyering@redhat.com>
6273 use ssize_t and size_t for read- and write-like emacs_gnutls_* functions
6274 * gnutls.c (emacs_gnutls_read): Adjust signature to be more read-like:
6275 return ssize_t not "int", and use size_t as the buffer length.
6276 (emacs_gnutls_write): Likewise, and make the buffer pointer "const".
6277 * gnutls.h: Update declarations.
6278 * process.c (read_process_output): Use ssize_t, to match.
6279 (send_process): Likewise.
6281 2011-04-09 Chong Yidong <cyd@stupidchicken.com>
6283 * image.c (Fimagemagick_types): Doc fix, and comment cleanup.
6285 2011-04-09 Chong Yidong <cyd@stupidchicken.com>
6287 * ftfont.c (get_adstyle_property, ftfont_pattern_entity):
6288 Use unsigned char, to match FcChar8 type definition.
6290 * xterm.c (handle_one_xevent):
6291 * xmenu.c (create_and_show_popup_menu):
6292 * xselect.c (x_decline_selection_request)
6293 (x_reply_selection_request): Avoid type-punned deref of X events.
6295 2011-04-09 Eli Zaretskii <eliz@gnu.org>
6297 Fix some uses of `int' instead of EMACS_INT.
6298 * search.c (string_match_1, fast_string_match)
6299 (fast_c_string_match_ignore_case, fast_string_match_ignore_case)
6300 (scan_buffer, find_next_newline_no_quit)
6301 (find_before_next_newline, search_command, Freplace_match)
6302 (Fmatch_data): Make some `int' variables be EMACS_INT.
6304 * xdisp.c (display_count_lines): 3rd argument and return value now
6305 EMACS_INT. All callers changed.
6306 (pint2hrstr): Last argument is now EMACS_INT.
6308 * coding.c (detect_coding_utf_8, detect_coding_emacs_mule)
6309 (detect_coding_iso_2022, detect_coding_sjis, detect_coding_big5)
6310 (detect_coding_ccl, detect_coding_charset, decode_coding_utf_8)
6311 (decode_coding_utf_16, decode_coding_emacs_mule)
6312 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5)
6313 (decode_coding_ccl, decode_coding_charset)
6314 <consumed_chars, consumed_chars_base>: Declare EMACS_INT.
6315 (decode_coding_iso_2022, decode_coding_emacs_mule)
6316 (decode_coding_sjis, decode_coding_big5, decode_coding_charset)
6317 <char_offset, last_offset>: Declare EMACS_INT.
6318 (encode_coding_utf_8, encode_coding_utf_16)
6319 (encode_coding_emacs_mule, encode_invocation_designation)
6320 (encode_designation_at_bol, encode_coding_iso_2022)
6321 (encode_coding_sjis, encode_coding_big5, encode_coding_ccl)
6322 (encode_coding_raw_text, encode_coding_charset) <produced_chars>:
6324 (ASSURE_DESTINATION): Declare more_bytes EMACS_INT.
6325 (encode_invocation_designation): Last argument P_NCHARS is now
6327 (decode_eol): Declare pos_byte, pos, and pos_end EMACS_INT.
6328 (produce_chars): from_nchars and to_nchars are now EMACS_INT.
6330 * coding.h (struct coding_system) <head_ascii>: Declare EMACS_INT.
6333 * ccl.c (Fccl_execute_on_string): Declare some variables
6336 2011-04-08 Samuel Thibault <sthibault@debian.org> (tiny change)
6338 * term.c (init_tty): Fix incorrect ifdef placement (Bug#8450).
6340 2011-03-19 Christoph Scholtes <cschol2112@googlemail.com>
6342 * process.c (Fformat_network_address): Doc fix.
6344 2011-04-08 T.V. Raman <tv.raman.tv@gmail.com> (tiny change)
6346 * xml.c (parse_region): Avoid creating spurious whiespace nodes.
6348 2011-04-08 Chong Yidong <cyd@stupidchicken.com>
6350 * keyboard.c (read_char): Call Lisp function help-form-show,
6351 instead of using internal_with_output_to_temp_buffer.
6352 (Qhelp_form_show): New var.
6353 (syms_of_keyboard): Use DEFSYM macro.
6355 * print.c (internal_with_output_to_temp_buffer): Function deleted.
6357 * lisp.h (internal_with_output_to_temp_buffer): Remove prototype.
6359 2011-04-06 Chong Yidong <cyd@stupidchicken.com>
6361 * process.c (Flist_processes): Remove to Lisp.
6362 (list_processes_1): Delete.
6364 2011-04-06 Eli Zaretskii <eliz@gnu.org>
6366 * msdos.c (careadlinkat, careadlinkatcwd): MS-DOS replacements.
6368 * w32.c (careadlinkat, careadlinkatcwd): New always-fail stubs.
6370 2011-04-06 Paul Eggert <eggert@cs.ucla.edu>
6372 Fix more problems found by GCC 4.6.0's static checks.
6374 * xmenu.c (Fx_popup_dialog): Don't assume string is free of formats.
6376 * menu.c (Fx_popup_menu): Don't assume error_name lacks printf formats.
6378 * lisp.h (message, message_nolog, fatal): Mark as printf-like.
6380 * xdisp.c (vmessage): Mark as a printf-like function.
6382 * term.c (vfatal, maybe_fatal): Mark as printf-like functions.
6384 * sound.c (sound_warning): Don't crash if arg contains a printf format.
6386 * image.c (tiff_error_handler, tiff_warning_handler): Mark as
6387 printf-like functions.
6388 (tiff_load): Add casts to remove these marks before passing them
6389 to system-supplied API.
6391 * eval.c (Fsignal): Remove excess argument to 'fatal'.
6393 * coding.c (EMIT_ONE_BYTE, EMIT_TWO_BYTES): Use unsigned, not int.
6394 This avoids several warnings with gcc -Wstrict-overflow.
6395 (DECODE_COMPOSITION_RULE): If the rule is invalid, goto invalid_code
6396 directly, rather than having caller test rule sign. This avoids
6397 some unnecessary tests.
6398 * composite.h (COMPOSITION_ENCODE_RULE_VALID): New macro.
6399 (COMPOSITION_ENCODE_RULE): Arguments now must be valid. This
6400 affects only one use, in DECODE_COMPOSITION_RULE, which is changed.
6402 * xfont.c (xfont_text_extents): Remove var that was set but not used.
6403 (xfont_open): Avoid unnecessary tests.
6405 * composite.c (composition_gstring_put_cache): Use unsigned integer.
6407 * composite.h, composite.c (composition_gstring_put_cache):
6408 Use EMACS_INT, not int, for length.
6410 * composite.h (COMPOSITION_DECODE_REFS): New macro,
6411 breaking out part of COMPOSITION_DECODE_RULE.
6412 (COMPOSITION_DECODE_RULE): Use it.
6413 * composite.c (get_composition_id): Remove unused local vars,
6414 by using the new macro.
6416 * textprop.c (set_text_properties_1): Change while to do-while,
6417 since the condition is always true at first.
6419 * intervals.c (graft_intervals_into_buffer): Mark var as used.
6420 (interval_deletion_adjustment): Return unsigned value.
6423 * process.c (list_processes_1, create_pty, read_process_output):
6424 (exec_sentinel): Remove vars that were set but not used.
6425 (create_pty): Remove unnecessary "volatile"s.
6426 (Fnetwork_interface_info): Avoid possibility of int overflow.
6427 (read_process_output): Do adaptive read buffering even if carryover.
6428 (read_process_output): Simplify nbytes computation if buffered.
6430 * bytecode.c (exec_byte_code): Rename local to avoid shadowing.
6432 * syntax.c (scan_words): Remove var that was set but not used.
6433 (update_syntax_table): Use unsigned instead of int.
6435 * lread.c (lisp_file_lexically_bound_p): Use ints rather than endptrs.
6436 (lisp_file_lexically_bound_p, read1): Use unsigned instead of int.
6437 (safe_to_load_p): Make the end-of-loop test the inverse of the in-loop.
6439 * print.c (print_error_message): Avoid int overflow.
6441 * font.c (font_list_entities): Redo for clarity,
6442 so that reader need not know FONT_DPI_INDEX + 1 == FONT_SPACING_INDEX.
6444 * font.c (font_find_for_lface, Ffont_get_glyphs): Remove unused vars.
6445 (font_score): Avoid potential overflow in diff calculation.
6447 * fns.c (substring_both): Remove var that is set but not used.
6448 (sxhash): Redo loop for clarity and to avoid wraparound warning.
6450 * eval.c (funcall_lambda): Rename local to avoid shadowing.
6452 * alloc.c (mark_object_loop_halt, mark_object): Use size_t, not int.
6453 Otherwise, GCC 4.6.0 optimizes the loop check away since the check
6454 can always succeed if overflow has undefined behavior.
6456 * search.c (boyer_moore, wordify): Remove vars set but not used.
6457 (wordify): Omit three unnecessary tests.
6459 * indent.c (MULTIBYTE_BYTES_WIDTH): Don't compute wide_column.
6460 All callers changed. This avoids the need for an unused var.
6462 * casefiddle.c (casify_region): Remove var that is set but not used.
6464 * dired.c (file_name_completion): Remove var that is set but not used.
6466 * fileio.c (Finsert_file_contents): Make EOF condition clearer.
6468 * fileio.c (Finsert_file_contents): Avoid signed integer overflow.
6469 (Finsert_file_contents): Remove unnecessary code checking fd.
6471 * minibuf.c (read_minibuf_noninteractive): Use size_t for sizes.
6472 Check for integer overflow on size calculations.
6474 * buffer.c (Fprevious_overlay_change): Remove var that is set
6477 * keyboard.c (menu_bar_items, read_char_minibuf_menu_prompt):
6478 Remove vars that are set but not used.
6479 (timer_check_2): Don't assume timer-list and idle-timer-list are lists.
6480 (timer_check_2): Mark vars as initialized.
6482 * gtkutil.c (xg_get_file_with_chooser): Mark var as initialized.
6484 * image.c (lookup_image): Remove var that is set but not used.
6485 (xbm_load): Use parse_p, for gcc -Werror=unused-but-set-variable.
6487 * fontset.c (Finternal_char_font, Ffontset_info): Remove vars
6488 that are set but not used.
6490 * xfns.c (make_invisible_cursor): Don't return garbage
6491 if XCreateBitmapFromData fails (Bug#8410).
6493 * xselect.c (x_get_local_selection, x_handle_property_notify):
6494 Remove vars that are set but not used.
6496 * xfns.c (x_create_tip_frame): Remove var that is set but not used.
6497 (make_invisible_cursor): Initialize a possibly-uninitialized variable.
6499 * xterm.c (x_scroll_bar_to_input_event) [!USE_GTK]:
6500 Remove var that is set but not used.
6501 (scroll_bar_windows_size): Now size_t, not int.
6502 (x_send_scroll_bar_event): Use size_t, not int, for sizes.
6505 * xfaces.c (realize_named_face): Remove vars that are set but not used.
6506 (map_tty_color) [!defined MSDOS]: Likewise.
6508 * term.c (tty_write_glyphs): Use size_t; this avoids overflow warning.
6510 * coding.c: Remove vars that are set but not used.
6511 (DECODE_COMPOSITION_RULE): Remove 2nd arg, which is unused.
6512 All callers changed.
6513 (decode_coding_utf_8, decode_coding_utf_16 decode_coding_emacs_mule):
6514 (decode_coding_iso_2022, encode_coding_sjis, encode_coding_big5):
6515 (decode_coding_charset): Remove vars that are set but not used.
6517 * bytecode.c (Fbyte_code) [!defined BYTE_CODE_SAFE]: Remove var
6518 that is set but not used.
6520 * print.c (print_object): Remove var that is set but not used.
6522 Replace 2 copies of readlink code with 1 gnulib version (Bug#8401).
6523 The gnulib version avoids calling malloc in the usual case,
6524 and on 64-bit hosts doesn't have some arbitrary 32-bit limits.
6525 * fileio.c (Ffile_symlink_p): Use emacs_readlink.
6526 * filelock.c (current_lock_owner): Likewise.
6527 * lisp.h (READLINK_BUFSIZE, emacs_readlink): New function.
6528 * sysdep.c: Include allocator.h, careadlinkat.h.
6529 (emacs_no_realloc_allocator): New static constant.
6530 (emacs_readlink): New function.
6531 * deps.mk (sysdep.o): Depend on ../lib/allocator.h and on
6532 ../lib/careadlinkat.h.
6534 2011-04-04 Stefan Monnier <monnier@iro.umontreal.ca>
6536 * keyboard.c (safe_run_hook_funcall): Fix last change (don't stop at the
6537 first non-nil return value).
6539 2011-04-03 Jan Djärv <jan.h.d@swipnet.se>
6541 * nsterm.m (ns_update_auto_hide_menu_bar): Define MAC_OS_X_VERSION_10_6
6542 if not defined (Bug#8403).
6544 2011-04-02 Juanma Barranquero <lekktu@gmail.com>
6546 * xdisp.c (display_count_lines): Remove parameter `start',
6547 unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
6548 (get_char_face_and_encoding): Remove parameter `multibyte_p',
6549 unused since 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
6550 (fill_stretch_glyph_string): Remove parameters `row' and `area',
6551 unused at least since Kim's GUI unification at 2003-03-16T20:45:46Z!storm@cua.dk
6552 and thereabouts. All callers changed.
6553 (get_per_char_metric): Remove parameter `f', unused since
6554 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
6556 2011-04-02 Jim Meyering <meyering@redhat.com>
6558 do not dereference NULL upon failed strdup
6559 * nsfont.m (ns_descriptor_to_entity): Use xstrdup, not strdup.
6560 (ns_get_family): Likewise.
6562 2011-04-02 Juanma Barranquero <lekktu@gmail.com>
6564 * eval.c (unwind_to_catch) [DEBUG_GCPRO]: Remove redundant assignment.
6566 2011-04-02 Jan Djärv <jan.h.d@swipnet.se>
6568 * nsterm.m (ns_update_auto_hide_menu_bar): Only for OSX 10.6 or
6571 2011-04-01 Stefan Monnier <monnier@iro.umontreal.ca>
6573 Add lexical binding.
6575 * window.c (Ftemp_output_buffer_show): New fun.
6576 (Fsave_window_excursion):
6577 * print.c (Fwith_output_to_temp_buffer): Move to subr.el.
6579 * lread.c (lisp_file_lexically_bound_p): New function.
6580 (Fload): Bind Qlexical_binding.
6581 (readevalloop): Remove `evalfun' arg.
6582 Bind Qinternal_interpreter_environment.
6583 (Feval_buffer): Bind Qlexical_binding.
6584 (defvar_int, defvar_bool, defvar_lisp_nopro, defvar_kboard):
6586 (syms_of_lread): Declare `lexical-binding'.
6588 * lisp.h (struct Lisp_Symbol): New field `declared_special'.
6590 * keyboard.c (eval_dyn): New fun.
6591 (menu_item_eval_property): Use it.
6593 * image.c (parse_image_spec): Use Ffunctionp.
6595 * fns.c (concat, mapcar1): Accept byte-code-functions.
6597 * eval.c (Fsetq): Handle lexical vars.
6598 (Fdefun, Fdefmacro, Ffunction): Make closures when needed.
6599 (Fdefconst, Fdefvaralias, Fdefvar): Mark as dynamic.
6600 (FletX, Flet): Obey lexical binding.
6601 (Fcommandp): Handle closures.
6602 (Feval): New `lexical' arg.
6603 (eval_sub): New function extracted from Feval. Use it almost
6604 everywhere where Feval was used. Look up vars in lexical env.
6606 (Ffunctionp): Move from subr.el.
6607 (Ffuncall): Handle closures.
6608 (apply_lambda): Remove `eval_flags'.
6609 (funcall_lambda): Handle closures and new byte-code-functions.
6610 (Fspecial_variable_p): New function.
6611 (syms_of_eval): Initialize the Vinternal_interpreter_environment var,
6612 but without exporting it to Lisp.
6614 * doc.c (Fdocumentation, store_function_docstring):
6615 * data.c (Finteractive_form): Handle closures.
6617 * callint.c (Fcall_interactively): Preserve lexical-binding mode for
6620 * bytecode.c (Bstack_ref, Bstack_set, Bstack_set2, BdiscardN):
6622 (exec_byte_code): New function extracted from Fbyte_code to handle new
6623 calling convention for byte-code-functions. Add new byte-codes.
6625 * buffer.c (defvar_per_buffer): Set new `declared_special' field.
6627 * alloc.c (Fmake_symbol): Init new `declared_special' field.
6629 2011-03-31 Juanma Barranquero <lekktu@gmail.com>
6631 * xdisp.c (redisplay_internal): Fix prototype.
6633 2011-03-31 Eli Zaretskii <eliz@gnu.org>
6635 * xdisp.c (SCROLL_LIMIT): New macro.
6636 (try_scrolling): Use it when setting scroll_limit.
6637 Limit scrolling to 100 screen lines.
6638 (redisplay_window): Even when falling back on "recentering",
6639 position point in the window according to scroll-conservatively,
6640 scroll-margin, and scroll-*-aggressively variables. (Bug#6671)
6642 (try_scrolling): When point is above the window, allow searching
6643 as far as scroll_max, or one screenful, to compute vertical
6644 distance from PT to the scroll margin position. This prevents
6645 try_scrolling from unnecessarily failing when
6646 scroll-conservatively is set to a value slightly larger than the
6647 window height. Clean up the case of PT below the margin at bottom
6648 of window: scroll_max can no longer be INT_MAX. When aggressive
6649 scrolling is in use, don't let point enter the opposite scroll
6650 margin as result of the scroll.
6651 (syms_of_xdisp) <scroll-conservatively>: Document the
6652 threshold of 100 lines for never-recentering scrolling.
6654 2011-03-31 Juanma Barranquero <lekktu@gmail.com>
6656 * dispextern.h (move_it_by_lines):
6657 * xdisp.c (move_it_by_lines): Remove parameter `need_y_p', unused
6658 since 2000-12-29T14:24:09Z!gerd@gnu.org. All callers changed.
6659 (message_log_check_duplicate): Remove parameters `prev_bol' and
6660 `this_bol', unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
6661 (redisplay_internal): Remove parameter `preserve_echo_area',
6662 unused since 1999-07-21T21:43:52Z!gerd@gnu.org. All callers changed.
6664 * indent.c (Fvertical_motion):
6665 * window.c (window_scroll_pixel_based, Frecenter):
6666 Don't pass `need_y_p' to `move_it_by_lines'.
6668 2011-03-30 Stefan Monnier <monnier@iro.umontreal.ca>
6670 * eval.c (struct backtrace): Don't cheat with negative numbers, but do
6671 steal a few bits to be more compact.
6672 (interactive_p, Fbacktrace, Fbacktrace_frame, mark_backtrace):
6673 Remove unneeded casts.
6675 * bytecode.c (Fbyte_code): CAR and CDR can GC.
6677 2011-03-30 Zachary Kanfer <zkanfer@gmail.com> (tiny change)
6679 * keyboard.c (Fexecute_extended_command): Do log the "suggest key
6680 binding" message (bug#7967).
6682 2011-03-30 Paul Eggert <eggert@cs.ucla.edu>
6684 Fix more problems found by GCC 4.6.0's static checks.
6686 * unexelf.c (unexec) [! (defined _SYSTYPE_SYSV || defined __sgi)]:
6687 Remove unused local var.
6689 * editfns.c (Fmessage_box): Remove unused local var.
6691 * xdisp.c (try_window_reusing_current_matrix, x_produce_glyphs):
6692 (note_mode_line_or_margin_highlight, note_mouse_highlight):
6693 Omit unused local vars.
6694 * window.c (shrink_windows): Omit unused local var.
6695 * menu.c (digest_single_submenu): Omit unused local var.
6696 * dispnew.c (update_window) [PERIODIC_PREEMPTION_CHECKING]:
6697 Omit unused local var.
6699 * keyboard.c (parse_modifiers_uncached, parse_modifiers):
6700 Don't assume string length fits in int.
6701 (keyremap_step, read_key_sequence): Use size_t for sizes.
6702 (read_key_sequence): Don't check last_real_key_start redundantly.
6704 * callproc.c (Fcall_process, Fcall_process_region): Use SAFE_ALLOCA
6705 instead of alloca (Bug#8344).
6707 * eval.c (Fbacktrace): Don't assume nargs fits in int.
6708 (Fbacktrace_frame): Don't assume nframes fits in int.
6710 * syntax.c (scan_sexps_forward): Avoid pointer wraparound.
6712 * xterm.c (x_make_frame_visible, same_x_server): Redo to avoid overflow
6715 * term.c (produce_glyphless_glyph): Remove unnecessary test.
6717 * cm.c (calccost): Turn while-do into do-while, for clarity.
6719 * keyboard.c (syms_of_keyboard): Use the same style as later
6720 in this function when indexing through an array. This also
6721 works around GCC bug 48267.
6723 * image.c (tiff_load): Fix off-by-one image count (Bug#8336).
6725 * xselect.c (x_check_property_data): Return correct size (Bug#8335).
6727 * chartab.c (sub_char_table_ref_and_range): Redo for slight
6728 efficiency gain, and to bypass a gcc -Wstrict-overflow warning.
6730 * keyboard.c, keyboard.h (num_input_events): Now size_t.
6731 This avoids undefined behavior on integer overflow, and is a bit
6732 more convenient anyway since it is compared to a size_t variable.
6734 Variadic C functions now count arguments with size_t, not int.
6735 This avoids an unnecessary limitation on 64-bit machines, which
6736 caused (substring ...) to crash on large vectors (Bug#8344).
6737 * lisp.h (struct Lisp_Subr.function.aMANY): Now takes size_t, not int.
6738 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call): Likewise.
6739 All variadic functions and their callers changed accordingly.
6740 (struct gcpro.nvars): Now size_t, not int. All uses changed.
6741 * data.c (arith_driver, float_arith_driver): Likewise.
6742 * editfns.c (general_insert_function): Likewise.
6743 * eval.c (struct backtrace.nargs, interactive_p)
6744 (internal_condition_case_n, run_hook_with_args, apply_lambda)
6745 (funcall_lambda, mark_backtrace): Likewise.
6746 * fns.c (concat): Likewise.
6747 * frame.c (x_set_frame_parameters): Likewise.
6748 * fns.c (get_key_arg): Now accepts and returns size_t, and returns
6749 0 if not found, not -1. All callers changed.
6751 * alloc.c (garbage_collect): Don't assume stack size fits in int.
6752 (stack_copy_size): Now size_t, not int.
6753 (stack_copy, stack_copy_size): Define only if MAX_SAVE_STACK > 0.
6755 2011-03-28 Juanma Barranquero <lekktu@gmail.com>
6757 * coding.c (encode_designation_at_bol): Remove parameter `charbuf_end',
6758 unused since 2002-03-01T01:17:24Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
6759 All callers changed.
6761 * lisp.h (multibyte_char_to_unibyte):
6762 * character.c (multibyte_char_to_unibyte): Remove parameter `rev_tbl',
6763 unused since 2002-03-01T01:16:34Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
6764 * character.h (CHAR_TO_BYTE8):
6765 * cmds.c (internal_self_insert):
6766 * editfns.c (general_insert_function):
6767 * keymap.c (push_key_description):
6768 * search.c (Freplace_match):
6769 * xdisp.c (message_dolog, set_message_1): All callers changed.
6771 2011-03-28 Stefan Monnier <monnier@iro.umontreal.ca>
6773 * keyboard.c (safe_run_hook_funcall): New function.
6774 (safe_run_hooks_1, safe_run_hooks_error, safe_run_hooks): On error,
6775 don't set the hook to nil, but remove the offending function instead.
6776 (Qcommand_hook_internal): Remove, unused.
6777 (syms_of_keyboard): Don't initialize Qcommand_hook_internal nor define
6778 Vcommand_hook_internal.
6780 * eval.c (enum run_hooks_condition): Remove.
6781 (funcall_nil, funcall_not): New functions.
6782 (run_hook_with_args): Call each function through a `funcall' argument.
6783 Remove `cond' argument, now redundant.
6784 (Frun_hooks, Frun_hook_with_args, Frun_hook_with_args_until_success)
6785 (Frun_hook_with_args_until_failure): Adjust accordingly.
6786 (run_hook_wrapped_funcall, Frun_hook_wrapped): New functions.
6788 2011-03-28 Juanma Barranquero <lekktu@gmail.com>
6790 * dispextern.h (string_buffer_position): Remove declaration.
6792 * print.c (strout): Remove parameter `multibyte', unused since
6793 1999-08-21T19:30:21Z!gerd@gnu.org. All callers changed.
6795 * search.c (boyer_moore): Remove parameters `len', `pos' and `lim',
6796 never used since function introduction in 1998-02-08T21:33:56Z!rms@gnu.org.
6797 All callers changed.
6799 * w32.c (_wsa_errlist): Use braces for struct initializers.
6801 * xdisp.c (string_buffer_position_lim): Remove parameter `w',
6802 never used since function introduction in 2001-03-09T18:41:50Z!gerd@gnu.org.
6803 All callers changed.
6804 (string_buffer_position): Likewise. Also, make static (it's never
6805 used outside xdisp.c).
6806 (cursor_row_p): Remove parameter `w', unused since
6807 2000-10-17T16:08:57Z!gerd@gnu.org. All callers changed.
6808 (decode_mode_spec): Remove parameter `precision', introduced during
6809 Gerd Moellmann's rewrite at 1999-07-21T21:43:52Z!gerd@gnu.org, but never used.
6810 All callers changed.
6812 2011-03-27 Jan Djärv <jan.h.d@swipnet.se>
6814 * nsterm.m (syms_of_nsterm): Use doc: for ns-auto-hide-menu-bar.
6816 2011-03-27 Anders Lindgren <andlind@gmail.com>
6818 * nsterm.m (ns_menu_bar_is_hidden): New variable.
6819 (ns_constrain_all_frames, ns_menu_bar_should_be_hidden)
6820 (ns_update_auto_hide_menu_bar): New functions.
6821 (ns_update_begin): Call ns_update_auto_hide_menu_bar.
6822 (applicationDidBecomeActive): Call ns_update_auto_hide_menu_bar and
6823 ns_constrain_all_frames.
6824 (constrainFrameRect): Return at once if ns_menu_bar_should_be_hidden.
6825 (syms_of_nsterm): DEFVAR ns-auto-hide-menu-bar, init to Qnil.
6827 2011-03-27 Jan Djärv <jan.h.d@swipnet.se>
6829 * nsmenu.m (runDialogAt): Remove argument to timer_check.
6831 2011-03-27 Glenn Morris <rgm@gnu.org>
6833 * syssignal.h: Replace RETSIGTYPE with void.
6834 * atimer.c, data.c, dispnew.c, emacs.c, floatfns.c, keyboard.c:
6835 * keyboard.h, lisp.h, process.c, sysdep.c, xterm.c:
6836 Replace SIGTYPE with void everywhere.
6837 * s/usg5-4-common.h (SIGTYPE): Remove definition.
6838 * s/template.h (SIGTYPE): Remove commented out definition.
6840 2011-03-26 Eli Zaretskii <eliz@gnu.org>
6842 * xdisp.c (redisplay_window): Don't check buffer's clip_changed
6843 flag as a prerequisite for invoking try_scrolling. (Bug#6671)
6845 2011-03-26 Juanma Barranquero <lekktu@gmail.com>
6847 * w32.c (read_unc_volume): Use parameter `henum', instead of
6848 global variable `wget_enum_handle'.
6850 * keymap.c (describe_vector): Remove parameters `indices' and
6851 `char_table_depth', unused since 2002-03-01T01:43:26Z!handa@m17n.org.
6852 (describe_map, Fdescribe_vector): Adjust calls to `describe_vector'.
6854 * keyboard.h (timer_check, show_help_echo): Remove unused parameters.
6856 * keyboard.c (timer_check): Remove parameter `do_it_now',
6857 unused since 1996-04-12T06:01:29Z!rms@gnu.org.
6858 (show_help_echo): Remove parameter `ok_to_overwrite_keystroke_echo',
6859 unused since 2008-04-19T19:30:53Z!monnier@iro.umontreal.ca.
6861 * keyboard.c (read_char):
6862 * w32menu.c (w32_menu_display_help):
6863 * xmenu.c (show_help_event, menu_help_callback):
6864 Adjust calls to `show_help_echo'.
6866 * gtkutil.c (xg_maybe_add_timer):
6867 * keyboard.c (readable_events):
6868 * process.c (wait_reading_process_output):
6869 * xmenu.c (x_menu_wait_for_event): Adjust calls to `timer_check'.
6871 * insdel.c (adjust_markers_gap_motion):
6872 Remove; no-op since 1998-01-02T21:29:48Z!rms@gnu.org.
6873 (gap_left, gap_right): Don't call it.
6875 2011-03-25 Chong Yidong <cyd@stupidchicken.com>
6877 * xdisp.c (handle_fontified_prop): Discard changes to clip_changed
6878 incurred during fontification.
6880 2011-03-25 Juanma Barranquero <lekktu@gmail.com>
6882 * buffer.c (defvar_per_buffer): Remove unused parameter `doc'.
6883 (DEFVAR_PER_BUFFER): Don't pass it.
6885 * dispnew.c (row_equal_p, add_row_entry): Remove unused parameter `w'.
6886 (scrolling_window): Don't pass it.
6888 2011-03-25 Juanma Barranquero <lekktu@gmail.com>
6890 * dispextern.h (glyph_matric): Use #if GLYPH_DEBUG, not #ifdef.
6892 * fileio.c (check_executable) [DOS_NT]: Remove unused variables `len'
6894 (Fset_file_selinux_context) [HAVE_LIBSELINUX]: Move here declaration
6895 of variables specific to SELinux and computation of `encoded_absname'.
6897 * image.c (XPutPixel): Remove unused variable `height'.
6899 * keyboard.c (make_lispy_event): Remove unused variable `hpos'.
6901 * unexw32.c (get_section_info): Remove unused variable `section'.
6903 * w32.c (stat): Remove unused variables `drive_root' and `devtype'.
6904 (system_process_attributes): Remove unused variable `sess'.
6905 (sys_read): Remove unused variable `err'.
6907 * w32fns.c (top): Wrap variables with #if GLYPH_DEBUG, not #ifdef.
6908 (w32_wnd_proc): Remove unused variable `isdead'.
6909 (unwind_create_frame): Use #if GLYPH_DEBUG, not #ifdef.
6910 (Fx_server_max_request_size): Remove unused variable `dpyinfo'.
6911 (x_create_tip_frame): Remove unused variable `tem'.
6913 * w32inevt.c (w32_console_read_socket):
6914 Remove unused variable `no_events'.
6916 * w32term.c (x_draw_composite_glyph_string_foreground):
6917 Remove unused variable `width'.
6919 2011-03-24 Juanma Barranquero <lekktu@gmail.com>
6921 * w32term.c (x_set_glyph_string_clipping):
6922 Don't pass uninitialized region to CombineRgn.
6924 2011-03-23 Juanma Barranquero <lekktu@gmail.com>
6926 * w32fns.c (x_set_menu_bar_lines): Remove unused variable `olines'.
6927 (w32_wnd_proc): Pass NULL to Windows API, not uninitialized buffer.
6928 (Fx_close_connection): Remove unused variable `i'.
6930 * w32font.c (w32font_draw): Return number of glyphs.
6931 (w32font_open_internal): Remove unused variable `i'.
6932 (w32font_driver): Add missing initializer.
6934 * w32menu.c (utf8to16): Remove unused variable `utf16'.
6935 (fill_in_menu): Remove unused variable `items_added'.
6937 * w32term.c (last_mouse_press_frame): Remove static global variable.
6938 (w32_clip_to_row): Remove unused variable `f'.
6939 (x_delete_terminal): Remove unused variable `i'.
6941 * w32uniscribe.c (uniscribe_shape): Remove unused variable `nclusters'.
6942 (NOTHING): Remove unused static global variable.
6943 (uniscribe_check_otf): Remove unused variable `table'.
6944 (uniscribe_font_driver): Add missing initializers.
6946 2011-03-23 Julien Danjou <julien@danjou.info>
6948 * term.c (Fsuspend_tty, Fresume_tty):
6949 * minibuf.c (read_minibuf, run_exit_minibuf_hook):
6950 * window.c (temp_output_buffer_show):
6951 * insdel.c (signal_before_change):
6952 * frame.c (Fhandle_switch_frame):
6953 * fileio.c (Fdo_auto_save):
6954 * emacs.c (Fkill_emacs):
6955 * editfns.c (save_excursion_restore):
6956 * cmds.c (internal_self_insert):
6957 * callint.c (Fcall_interactively):
6958 * buffer.c (Fkill_all_local_variables):
6959 * keyboard.c (Fcommand_execute, Fsuspend_emacs, safe_run_hooks_1):
6961 (command_loop_1): Use Frun_hooks. Call safe_run_hooks
6962 unconditionnaly since it does the check itself.
6964 2011-03-23 Paul Eggert <eggert@cs.ucla.edu>
6966 Fix more problems found by GCC 4.5.2's static checks.
6968 * coding.c (encode_coding_raw_text): Avoid unnecessary test
6969 the first time through the loop, since we know p0 < p1 then.
6970 This also avoids a gcc -Wstrict-overflow warning.
6972 * lisp.h (SAFE_ALLOCA, SAFE_ALLOCA_LISP): Avoid 'int' overflow
6973 leading to a memory leak, possible in functions like
6974 load_charset_map_from_file that can allocate an unbounded number
6975 of objects (Bug#8318).
6977 * xmenu.c (set_frame_menubar): Use EMACS_UINT, not int, for indexes
6978 that could (at least in theory) be that large.
6980 * xdisp.c (message_log_check_duplicate): Return unsigned long, not int.
6981 This is less likely to overflow, and avoids undefined behavior if
6982 overflow does occur. All callers changed. Use strtoul to scan
6983 for the unsigned long integer.
6984 (pint2hrstr): Simplify and tune code slightly.
6985 This also avoids a (bogus) GCC warning with gcc -Wstrict-overflow.
6987 * scroll.c (do_scrolling): Work around GCC bug 48228.
6988 See <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=48228>.
6990 * frame.c (Fmodify_frame_parameters): Simplify loop counter.
6991 This also avoids a warning with gcc -Wstrict-overflow.
6992 (validate_x_resource_name): Simplify count usage.
6993 This also avoids a warning with gcc -Wstrict-overflow.
6995 * fileio.c (Fcopy_file): Report error if fchown or fchmod
6998 * emacs.c (Fdaemon_initialized): Do not ignore I/O errors (Bug#8303).
7000 * process.c (Fmake_network_process): Use socklen_t, not int,
7001 where POSIX says socklen_t is required in portable programs.
7002 This fixes a porting bug on hosts like 64-bit HP-UX, where
7003 socklen_t is wider than int (Bug#8277).
7004 (Fmake_network_process, server_accept_connection):
7005 (wait_reading_process_output, read_process_output):
7008 * process.c: Rename or move locals to avoid shadowing.
7009 (list_processes_1, Fmake_network_process):
7010 (read_process_output_error_handler, exec_sentinel_error_handler):
7011 Rename or move locals.
7012 (Fmake_network_process): Define label "retry_connect" only if needed.
7013 (Fnetwork_interface_info): Fix pointer signedness.
7014 (process_send_signal): Add cast to avoid pointer signedness problem.
7015 (FIRST_PROC_DESC, IF_NON_BLOCKING_CONNECT): Remove unused macros.
7016 (create_process): Use 'volatile' to avoid vfork clobbering (Bug#8298).
7018 Make tparam.h and terminfo.c consistent.
7019 * cm.c (tputs, tgoto, BC, UP): Remove extern decls.
7020 Include tparam.h instead, since it declares them.
7021 * cm.h (PC): Remove extern decl; tparam.h now does this.
7022 * deps.mk (cm.o, terminfo.o): Depend on tparam.h.
7023 * terminfo.c: Include tparam.h, to check interfaces.
7024 (tparm): Make 1st arg a const pointer in decl. Put it at top level.
7025 (tparam): Adjust signature to match interface in tparam.h;
7026 this removes some undefined behavior. Check that outstring and len
7027 are zero, which they always are with Emacs.
7028 * tparam.h (PC, BC, UP): New extern decls.
7030 * xftfont.c (xftfont_shape): Now static, and defined only if needed.
7031 (xftfont_open): Rename locals to avoid shadowing.
7033 * ftfont.c (ftfont_resolve_generic_family): Fix pointer signedness.
7034 (ftfont_otf_capability, ftfont_shape): Omit decls if not needed.
7035 (OTF_TAG_SYM): Omit macro if not needed.
7036 (ftfont_list): Remove unused local.
7037 (get_adstyle_property, ftfont_pattern_entity):
7038 (ftfont_lookup_cache, ftfont_open, ftfont_anchor_point):
7039 Rename locals to avoid shadowing.
7041 * xfont.c (xfont_list_family): Mark var as initialized.
7043 * xml.c (make_dom): Now static.
7045 * composite.c (composition_compute_stop_pos): Rename local to
7047 (composition_reseat_it): Remove unused locals.
7048 (find_automatic_composition, composition_adjust_point): Likewise.
7049 (composition_update_it): Mark var as initialized.
7050 (find_automatic_composition): Mark vars as initialized,
7051 with a FIXME (Bug#8290).
7053 character.h: Rename locals to avoid shadowing.
7054 * character.h (PREV_CHAR_BOUNDARY, FETCH_STRING_CHAR_ADVANCE):
7055 (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE, FETCH_CHAR_ADVANCE):
7056 (FETCH_CHAR_ADVANCE_NO_CHECK, INC_POS, DEC_POS, BUF_INC_POS):
7057 (BUF_DEC_POS): Be more systematic about renaming local temporaries
7060 * textprop.c (property_change_between_p): Remove; unused.
7062 * intervals.c (interval_start_pos): Now static.
7064 * intervals.h (CHECK_TOTAL_LENGTH): Avoid empty "else".
7066 * atimer.c (start_atimer, append_atimer_lists, set_alarm):
7067 Rename locals to avoid shadowing.
7069 * sound.c (wav_play, au_play, Fplay_sound_internal):
7070 Fix pointer signedness.
7071 (alsa_choose_format): Remove unused local var.
7072 (wav_play): Initialize a variable to 0, to prevent undefined
7073 behavior (Bug#8278).
7075 * region-cache.c (insert_cache_boundary): Redo var to avoid shadowing.
7077 * region-cache.h (pp_cache): New decl, for gcc -Wmissing-prototypes.
7079 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork
7080 clobbering (Bug#8298).
7081 * sysdep.c (sys_subshell): Likewise.
7082 Previously, the sys_subshell 'volatile' was incorrectly IF_LINTted out.
7084 * lisp.h (child_setup): Now NO_RETURN unless DOS_NT.
7085 This should get cleaned up, so that child_setup has the
7086 same signature on all platforms.
7088 * callproc.c (call_process_cleanup): Now static.
7089 (relocate_fd): Rename locals to avoid shadowing.
7091 2011-03-22 Chong Yidong <cyd@stupidchicken.com>
7093 * xterm.c (x_clear_frame): Remove XClearWindow call. This appears
7094 not to be necessary, and produces flickering.
7096 2011-03-20 Glenn Morris <rgm@gnu.org>
7098 * config.in: Remove file.
7100 2011-03-20 Juanma Barranquero <lekktu@gmail.com>
7102 * minibuf.c (Vcompleting_read_function): Don't declare, global variables
7103 are now in src/globals.h.
7104 (syms_of_minibuf): Remove spurious & from previous change.
7106 2011-03-20 Leo <sdl.web@gmail.com>
7108 * minibuf.c (completing-read-function): New variable.
7109 (completing-read-default): Rename from completing-read.
7110 (completing-read): Call completing-read-function.
7112 2011-03-19 Juanma Barranquero <lekktu@gmail.com>
7114 * xfaces.c (Fx_load_color_file):
7115 Read color file from absolute filename (bug#8250).
7117 2011-03-19 Juanma Barranquero <lekktu@gmail.com>
7119 * makefile.w32-in: Update dependencies.
7121 2011-03-17 Eli Zaretskii <eliz@gnu.org>
7123 * makefile.w32-in ($(BLD)/unexw32.$(O)): Depend on $(SRC)/unexec.h.
7125 2011-03-17 Paul Eggert <eggert@cs.ucla.edu>
7127 Fix more problems found by GCC 4.5.2's static checks.
7129 * process.c (make_serial_process_unwind, send_process_trap):
7130 (sigchld_handler): Now static.
7132 * process.c (allocate_pty): Let PTY_ITERATION declare iteration vars.
7133 That way, the code declares only the vars that it needs.
7134 * s/aix4-2.h (PTY_ITERATION): Declare iteration vars.
7135 * s/cygwin.h (PTY_ITERATION): Likewise.
7136 * s/darwin.h (PTY_ITERATION): Likewise.
7137 * s/gnu-linux.h (PTY_ITERATION): Likewise.
7139 * s/irix6-5.h (PTY_OPEN): Declare stb, to loosen coupling.
7140 * process.c (allocate_pty): Don't declare stb unless it's needed.
7142 * bytecode.c (MAYBE_GC): Rewrite so as not to use empty "else".
7143 (CONSTANTLIM): Remove; unused.
7144 (METER_CODE, Bscan_buffer, Bread_char, Bset_mark):
7145 Define only if needed.
7147 * unexelf.c (unexec): Name an expression,
7148 to avoid gcc -Wbad-function-cast warning.
7149 Use a different way to cause a compilation error if anyone uses
7150 n rather than nn, a way that does not involve shadowing.
7151 (ELF_BSS_SECTION_NAME, OLD_PROGRAM_H): Remove; unused.
7153 * deps.mk (unexalpha.o): Remove; unused.
7155 New file unexec.h, the (simple) interface for unexec (Bug#8267).
7156 * unexec.h: New file.
7157 * deps.mk (emacs.o, unexaix.o, unexcw.o, unexcoff.o, unexelf.o):
7158 (unexhp9k800.o, unexmacosx.o, unexsol.o, unexw32.o):
7160 * emacs.c [!defined CANNOT_DUMP]: Include unexec.h.
7161 * unexaix.c, unexcoff.c, unexcw.c, unexelf.c, unexhp9k800.c:
7162 * unexmacosx.c, unexsol.c, unexw32.c: Include unexec.h.
7163 Change as necessary to match prototype in unexec.h.
7165 * syntax.c (Fforward_comment, scan_lists): Rename locals to avoid
7167 (back_comment, skip_chars): Mark vars as initialized.
7169 * character.h (FETCH_STRING_CHAR_ADVANCE_NO_CHECK, BUF_INC_POS):
7170 Rename locals to avoid shadowing.
7172 * lread.c (read1): Rewrite so as not to use empty "else".
7173 (Fload, readevalloop, read1): Rename locals to avoid shadowing.
7175 * print.c (Fredirect_debugging_output): Fix pointer signedess.
7177 * lisp.h (debug_output_compilation_hack): Add decl here, to avoid
7178 warning when compiling print.c.
7180 * font.c (font_unparse_fcname): Abort in an "impossible" situation
7181 instead of using an uninitialized var.
7182 (font_sort_entities): Mark var as initialized.
7184 * character.h (FETCH_CHAR_ADVANCE): Rename locals to avoid shadowing.
7186 * font.c (font_unparse_xlfd): Don't mix pointers to variables with
7187 pointers to constants.
7188 (font_parse_fcname): Remove unused vars.
7189 (font_delete_unmatched): Now static.
7190 (font_get_spec): Remove; unused.
7191 (font_style_to_value, font_prop_validate_style, font_unparse_fcname):
7192 (font_update_drivers, Ffont_get_glyphs, font_add_log):
7193 Rename or move locals to avoid shadowing.
7195 * fns.c (require_nesting_list, require_unwind): Now static.
7196 (Ffillarray): Rename locals to avoid shadowing.
7198 * floatfns.c (domain_error2): Define only if needed.
7199 (Ffrexp, Fldexp): Rename locals to avoid shadowing.
7201 * alloc.c (mark_backtrace): Move decl from here ...
7202 * lisp.h: ... to here, so that it can be checked.
7204 * eval.c (call_debugger, do_debug_on_call, grow_specpdl): Now static.
7205 (Fdefvar): Rewrite so as not to use empty "else".
7206 (lisp_indirect_variable): Name an expression,
7207 to avoid gcc -Wbad-function-cast warning.
7208 (Fdefvar): Rename locals to avoid shadowing.
7210 * callint.c (quotify_arg, quotify_args): Now static.
7211 (Fcall_interactively): Rename locals to avoid shadowing.
7212 Use const pointer when appropriate.
7214 * lisp.h (get_system_name, get_operating_system_release):
7215 Move decls here, to check interfaces.
7216 * process.c (get_operating_system_release): Move decl to lisp.h.
7217 * xrdb.c (get_system_name): Likewise.
7218 * editfns.c (init_editfns, Fuser_login_name, Fuser_uid):
7219 (Fuser_real_uid, Fuser_full_name): Remove unnecessary casts,
7220 some of which prompt warnings from gcc -Wbad-function-cast.
7221 (Fformat_time_string, Fencode_time, Finsert_char):
7222 (Ftranslate_region_internal, Fformat):
7223 Rename or remove local vars to avoid shadowing.
7224 (Ftranslate_region_internal): Mark var as initialized.
7226 * doc.c (Fdocumentation, Fsnarf_documentation): Move locals to
7229 * lisp.h (eassert): Check that the argument compiles, even if
7230 ENABLE_CHECKING is not defined.
7232 * data.c (Findirect_variable): Name an expression, to avoid
7233 gcc -Wbad-function-cast warning.
7234 (default_value, arithcompare, arith_driver, arith_error): Now static.
7235 (store_symval_forwarding): Rename local to avoid shadowing.
7236 (Fmake_variable_buffer_local, Fmake_local_variable):
7237 Mark variables as initialized.
7238 (do_blv_forwarding, do_symval_forwarding): Remove; unused.
7240 * alloc.c (check_cons_list): Do not define unless GC_CHECK_CONS_LIST.
7241 (Fmake_vector, Fvector, Fmake_byte_code, Fgarbage_collect):
7242 Rename locals to avoid shadowing.
7243 (mark_stack): Move local variables into the #ifdef region where
7245 (BLOCK_INPUT_ALLOC, UNBLOCK_INPUT_ALLOC): Define only if
7246 ! defined SYSTEM_MALLOC && ! defined SYNC_INPUT, as they are not
7248 (CHECK_ALLOCATED): Define only if GC_CHECK_MARKED_OBJECTS.
7249 (GC_STRING_CHARS): Remove; not used.
7250 (Fmemory_limit): Cast sbrk's returned value to char *.
7252 * lisp.h (check_cons_list): Declare if GC_CHECK_CONS_LIST; this
7253 avoids undefined behavior in theory.
7255 * regex.c (IF_LINT): Add defn, for benefit of ../lib-src.
7257 Use functions, not macros, for up- and down-casing (Bug#8254).
7258 * buffer.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
7259 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Remove. All callers changed
7260 to use the following functions instead of these macros.
7261 (downcase): Adjust to lack of DOWNCASE_TABLE. Return int, not
7262 EMACS_INT, since callers assume the returned value fits in int.
7263 (upcase1): Likewise, for UPCASE_TABLE.
7264 (uppercasep, lowercasep, upcase): New static inline functions.
7265 * editfns.c (Fchar_equal): Remove no-longer-needed workaround for
7266 the race-condition problem in the old DOWNCASE.
7268 * regex.c (CHARSET_LOOKUP_RANGE_TABLE_RAW, POP_FAILURE_REG_OR_COUNT):
7269 Rename locals to avoid shadowing.
7270 (regex_compile, re_match_2_internal): Move locals to avoid shadowing.
7271 (regex_compile, re_search_2, re_match_2_internal):
7272 Remove unused local vars.
7273 (FREE_VAR): Rewrite so as not to use empty "else",
7274 which gcc can warn about.
7275 (regex_compile, re_match_2_internal): Mark locals as initialized.
7276 (RETALLOC_IF): Define only if needed.
7277 (WORDCHAR_P): Likewise. This one is never needed, but is used
7278 only in a comment talking about a compiler bug, so put inside
7279 the #if 0 of that comment.
7280 (CHARSET_LOOKUP_BITMAP, FAIL_STACK_FULL, RESET_FAIL_STACK):
7281 (PUSH_FAILURE_ELT, BUF_PUSH_3, STOP_ADDR_VSTRING):
7284 * search.c (boyer_moore): Rename locals to avoid shadowing.
7285 * character.h (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE):
7286 (PREV_CHAR_BOUNDARY): Likewise.
7288 * search.c (simple_search): Remove unused var.
7290 * dired.c (compile_pattern): Move decl from here ...
7291 * lisp.h: ... to here, so that it can be checked.
7292 (struct re_registers): New forward decl.
7294 * character.h (INC_POS, DEC_POS): Rename locals to avoid shadowing.
7296 * indent.c (MULTIBYTE_BYTES_WIDTH): New args bytes, width.
7298 (MULTIBYTE_BYTES_WIDTH, scan_for_column, compute_motion):
7299 Rename locals to avoid shadowing.
7300 (Fvertical_motion): Mark locals as initialized.
7302 * casefiddle.c (casify_object, casify_region): Now static.
7303 (casify_region): Mark local as initialized.
7305 * cmds.c (internal_self_insert): Rename local to avoid shadowing.
7307 * lisp.h (GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR, GCPRO5_VAR, GCPRO6_VAR):
7308 New macros, so that the caller can use some names other than
7309 gcpro1, gcpro2, etc.
7310 (GCPRO2, GCPRO3, GCPRO4, GCPRO5, GCPRO6): Reimplement in terms
7312 (GCPRO1_VAR, UNGCPRO_VAR): Change the meaning of the second
7313 argument, for consistency with GCPRO2_VAR, etc: it is now the
7314 prefix of the variable, not the variable itself. All uses
7316 * dired.c (directory_files_internal, file_name_completion):
7317 Rename locals to avoid shadowing.
7319 Fix a race condition diagnosed by gcc -Wsequence-point (Bug#8254).
7320 An expression of the form (DOWNCASE (x) == DOWNCASE (y)), found in
7321 dired.c's scmp function, had undefined behavior.
7322 * lisp.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
7323 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Move from here ...
7324 * buffer.h: ... to here, because these macros use current_buffer,
7325 and the new implementation with inline functions needs to have
7326 current_buffer in scope now, rather than later when the macros
7328 (downcase, upcase1): New static inline functions.
7329 (DOWNCASE, UPCASE1): Reimplement using these functions.
7330 This avoids undefined behavior in expressions like
7331 DOWNCASE (x) == DOWNCASE (y), which previously suffered
7332 from race conditions in accessing the global variables
7333 case_temp1 and case_temp2.
7334 * casetab.c (case_temp1, case_temp2): Remove; no longer needed.
7335 * lisp.h (case_temp1, case_temp2): Remove their decls.
7336 * character.h (ASCII_CHAR_P): Move from here ...
7337 * lisp.h: ... to here, so that the inline functions mentioned
7340 * dired.c (directory_files_internal_unwind): Now static.
7342 * fileio.c (file_name_as_directory, directory_file_name):
7343 (barf_or_query_if_file_exists, auto_save_error, auto_save_1):
7345 (file_name_as_directory): Use const pointers when appropriate.
7346 (Fexpand_file_name): Likewise. In particular, newdir might
7347 point at constant storage, so make it a const pointer.
7348 (Fmake_directory_internal, Fread_file_name): Remove unused vars.
7349 (Ffile_selinux_context, Fset_file_selinux_context): Fix pointer
7351 (Fset_file_times, Finsert_file_contents, auto_save_error):
7352 Rename locals to avoid shadowing.
7354 * minibuf.c (choose_minibuf_frame_1): Now static.
7355 (Ftry_completion, Fall_completions): Rename or remove locals
7358 * marker.c (bytepos_to_charpos): Remove; unused.
7360 * lisp.h (verify_bytepos, count_markers): New decls,
7361 so that gcc does not warn that these functions aren't declared.
7363 * insdel.c (check_markers, make_gap_larger, make_gap_smaller):
7364 (reset_var_on_error, Fcombine_after_change_execute_1): Now static.
7365 (CHECK_MARKERS): Redo to avoid gcc -Wempty-body diagnostic.
7366 (copy_text): Remove unused local var.
7368 * filelock.c (within_one_second): Now static.
7369 (lock_file_1): Rename local to avoid shadowing.
7371 * buffer.c (fix_overlays_before): Mark locals as initialized.
7372 (fix_start_end_in_overlays): Likewise. This function should be
7373 simplified by using pointers-to-pointers, but that's a different
7375 (switch_to_buffer_1): Now static.
7376 (Fkill_buffer, record_buffer, Fbury_buffer, Fset_buffer_multibyte):
7377 (report_overlay_modification): Rename locals to avoid shadowing.
7379 * sysdep.c (system_process_attributes): Rename vars to avoid shadowing.
7380 Fix pointer signedness issue.
7381 (sys_subshell): Mark local as volatile if checking for lint,
7382 to suppress a gcc -Wclobbered warning that does not seem to be right.
7383 (MAXPATHLEN): Define only if needed.
7385 * process.c (serial_open, serial_configure): Move decls from here ...
7386 * systty.h: ... to here, so that they can be checked.
7388 * fns.c (get_random, seed_random): Move extern decls from here ...
7389 * lisp.h: ... to here, so that they can be checked.
7391 * sysdep.c (reset_io): Now static.
7392 (wait_for_termination_signal): Remove; unused.
7394 * keymap.c (keymap_parent, keymap_memberp, map_keymap_internal):
7395 (copy_keymap_item, append_key, push_text_char_description):
7397 (Fwhere_is_internal): Don't test CONSP (sequences) unnecessarily.
7398 (DENSE_TABLE_SIZE): Remove; unused.
7399 (get_keymap, access_keymap, Fdefine_key, Fwhere_is_internal):
7400 (describe_map_tree):
7401 Rename locals to avoid shadowing.
7403 * keyboard.c: Declare functions static if they are not used elsewhere.
7404 (echo_char, echo_dash, cmd_error, top_level_2):
7405 (poll_for_input, handle_async_input): Now static.
7406 (read_char, kbd_buffer_get_event, make_lispy_position):
7407 (make_lispy_event, make_lispy_movement, apply_modifiers):
7408 (decode_keyboard_code, tty_read_avail_input, menu_bar_items):
7409 (parse_tool_bar_item, read_key_sequence, Fread_key_sequence):
7410 (Fread_key_sequence_vector): Rename locals to avoid shadowing.
7411 (read_key_sequence, read_char): Mark locals as initialized.
7412 (Fexit_recursive_edit, Fabort_recursive_edit): Mark with NO_RETURN.
7414 * keyboard.h (make_ctrl_char): New decl.
7415 (mark_kboards): Move decl here ...
7416 * alloc.c (mark_kboards): ... from here.
7418 * lisp.h (force_auto_save_soon): New decl.
7420 * emacs.c (init_cmdargs): Rename local to avoid shadowing.
7421 (DEFINE_DUMMY_FUNCTION): New macro.
7422 (__do_global_ctors, __do_global_ctors_aux, __do_global_dtors, __main):
7424 (main): Add casts to avoid warnings
7425 if GCC considers string literals to be constants.
7427 * lisp.h (fatal_error_signal): Add decl, since it's exported.
7429 * dbusbind.c: Pointer signedness fixes.
7430 (xd_signature, xd_append_arg, xd_initialize):
7431 (Fdbus_call_method, Fdbus_call_method_asynchronously):
7432 (Fdbus_method_return_internal, Fdbus_method_error_internal):
7433 (Fdbus_send_signal, xd_read_message_1, Fdbus_register_service):
7434 (Fdbus_register_signal): Use SSDATA when the context wants char *.
7436 * dbusbind.c (Fdbus_init_bus): Add cast to avoid warning
7437 if GCC considers string literals to be constants.
7438 (Fdbus_register_service, Fdbus_register_method): Remove unused vars.
7440 2011-03-16 Stefan Monnier <monnier@iro.umontreal.ca>
7442 * print.c (PRINT_CIRCLE_CANDIDATE_P): New macro.
7443 (print_preprocess, print_object): New macro to fix last change.
7445 * print.c (print_preprocess): Don't forget font objects.
7447 2011-03-16 Juanma Barranquero <lekktu@gmail.com>
7449 * emacs.c (USAGE3): Doc fixes.
7451 2011-03-15 Andreas Schwab <schwab@linux-m68k.org>
7453 * coding.c (detect_coding_iso_2022): Reorganize code to clarify
7456 2011-03-14 Juanma Barranquero <lekktu@gmail.com>
7458 * lisp.h (VWindow_system, Qfile_name_history):
7459 * keyboard.h (lispy_function_keys) [WINDOWSNT]:
7460 * w32term.h (w32_system_caret_hwnd, w32_system_caret_height)
7461 (w32_system_caret_x, w32_system_caret_y): Declare extern.
7463 * w32select.c: Don't #include "keyboard.h".
7464 (run_protected): Add extern declaration for waiting_for_input.
7466 * w32.c (Qlocal, noninteractive1, inhibit_window_system):
7467 * w32console.c (detect_input_pending, read_input_pending)
7468 (encode_terminal_code):
7469 * w32fns.c (quit_char, lispy_function_keys, Qtooltip)
7470 (w32_system_caret_hwnd, w32_system_caret_height, w32_system_caret_x)
7471 (w32_system_caret_y, Qfile_name_history):
7472 * w32font.c (w32font_driver, QCantialias, QCotf, QClang):
7473 * w32inevt.c (reinvoke_input_signal, lispy_function_keys):
7474 * w32menu.c (Qmenu_bar, QCtoggle, QCradio, Qoverriding_local_map)
7475 (Qoverriding_terminal_local_map, Qmenu_bar_update_hook):
7476 * w32proc.c (Qlocal, report_file_error):
7477 * w32term.c (Vwindow_system, updating_frame):
7478 * w32uniscribe.c (initialized, uniscribe_font_driver):
7479 Remove unneeded extern declarations.
7481 2011-03-14 Chong Yidong <cyd@stupidchicken.com>
7483 * buffer.c (Fmake_indirect_buffer): Fix incorrect assertions.
7485 2011-03-13 Chong Yidong <cyd@stupidchicken.com>
7487 * buffer.h (BUF_BEGV, BUF_BEGV_BYTE, BUF_ZV, BUF_ZV_BYTE, BUF_PT)
7488 (BUF_PT_BYTE): Rewrite to handle indirect buffers (Bug#8219).
7489 These macros can no longer be used for assignment.
7491 * buffer.c (Fget_buffer_create, Fmake_indirect_buffer):
7492 Assign struct members directly, instead of using BUF_BEGV etc.
7493 (record_buffer_markers, fetch_buffer_markers): New functions for
7494 recording and fetching special buffer markers.
7495 (set_buffer_internal_1, set_buffer_temp): Use them.
7497 * lread.c (unreadchar): Use SET_BUF_PT_BOTH.
7499 * insdel.c (adjust_point): Use SET_BUF_PT_BOTH.
7501 * intervals.c (temp_set_point_both): Use SET_BUF_PT_BOTH.
7502 (get_local_map): Use SET_BUF_BEGV_BOTH and SET_BUF_ZV_BOTH.
7504 * xdisp.c (hscroll_window_tree):
7505 (reconsider_clip_changes): Use PT instead of BUF_PT.
7507 2011-03-13 Eli Zaretskii <eliz@gnu.org>
7509 * makefile.w32-in ($(BLD)/editfns.$(O)): Depend on
7510 $(EMACS_ROOT)/lib/intprops.h.
7512 2011-03-13 Paul Eggert <eggert@cs.ucla.edu>
7514 Fix more problems found by GCC 4.5.2's static checks.
7516 * gtkutil.c (xg_get_pixbuf_from_pixmap): Add cast from char *
7517 to unsigned char * to avoid compiler diagnostic.
7518 (xg_free_frame_widgets): Make it clear that a local variable is
7519 needed only if USE_GTK_TOOLTIP.
7520 (gdk_window_get_screen): Make it clear that this macro is needed
7521 only if USE_GTK_TOOLTIP.
7522 (int_gtk_range_get_value): New function, which avoids a diagnostic
7523 from gcc -Wbad-function-cast.
7524 (xg_set_toolkit_scroll_bar_thumb): Use it.
7525 (xg_tool_bar_callback, xg_tool_item_stale_p): Rewrite to avoid
7526 diagnostic from gcc -Wbad-function-cast.
7527 (get_utf8_string, xg_get_file_with_chooser):
7528 Rename locals to avoid shadowing.
7529 (create_dialog): Move locals to avoid shadowing.
7531 * xgselect.c (xg_select): Remove unused var.
7533 * image.c (four_corners_best): Mark locals as initialized.
7534 (gif_load): Initialize transparent_p to zero (Bug#8238).
7535 Mark another local as initialized.
7536 (my_png_error, my_error_exit): Mark with NO_RETURN.
7538 * image.c (clear_image_cache): Now static.
7539 (DIM, HAVE_STDLIB_H_1): Remove unused macros.
7540 (xpm_load): Redo to avoid "discards qualifiers" gcc warning.
7541 (x_edge_detection): Remove unnecessary cast that
7542 gcc -Wbad-function-cast diagnoses.
7543 (gif_load): Fix pointer signedness.
7544 (clear_image_cache, xbm_read_bitmap_data, x_detect_edges):
7545 (jpeg_load, gif_load): Rename locals to avoid shadowing.
7547 2011-03-12 Paul Eggert <eggert@cs.ucla.edu>
7549 Improve quality of tests for time stamp overflow.
7550 For example, without this patch (encode-time 0 0 0 1 1
7551 1152921504606846976) returns the obviously-bogus value (-948597
7552 62170) on my RHEL 5.5 x86-64 host. With the patch, it correctly
7553 reports time overflow. See
7554 <http://lists.gnu.org/archive/html/emacs-devel/2011-03/msg00470.html>.
7555 * deps.mk (editfns.o): Depend on ../lib/intprops.h.
7556 * editfns.c: Include limits.h and intprops.h.
7557 (TIME_T_MIN, TIME_T_MAX): New macros.
7558 (time_overflow): Move earlier, to before first use.
7559 (hi_time, lo_time): New functions, for an accurate test for
7561 (Fcurrent_time, Fget_internal_run_time, make_time): Use them.
7562 (Fget_internal_run_time): Don't assume time_t fits in int.
7563 (make_time): Use list2 instead of Fcons twice.
7564 (Fdecode_time): More accurate test for out-of-range times.
7565 (check_tm_member): New function.
7566 (Fencode_time): Use it, to test for out-of-range times.
7567 (lisp_time_argument): Don't rely on undefined left-shift and
7568 right-shift behavior when checking for time stamp overflow.
7570 * editfns.c (time_overflow): New function, refactoring common code.
7571 (Fformat_time_string, Fdecode_time, Fencode_time):
7572 (Fcurrent_time_string): Use it.
7574 Move 'make_time' to be next to its inverse 'lisp_time_argument'.
7575 * dired.c (make_time): Move to ...
7576 * editfns.c (make_time): ... here.
7577 * systime.h: Note the move.
7579 2011-03-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
7581 * fringe.c (update_window_fringes): Remove unused variables.
7583 * unexmacosx.c (copy_data_segment): Also copy __got section.
7586 2011-03-12 Eli Zaretskii <eliz@gnu.org>
7588 * termcap.c [MSDOS]: Include "msdos.h".
7589 (find_capability, tgetnum, tgetflag, tgetstr, tputs, tgetent):
7590 Constify `char *' arguments and their references according to
7591 prototypes in tparam.h.
7593 * deps.mk (termcap.o): Depend on tparam.h and msdos.h.
7595 * msdos.c (XMenuAddPane): 3rd argument is `const char *' now.
7596 Adapt all references accordingly.
7598 * msdos.h (XMenuAddPane): 3rd argument is `const char *' now.
7600 2011-03-11 Tom Tromey <tromey@redhat.com>
7602 * buffer.c (syms_of_buffer): Remove obsolete comment.
7604 2011-03-11 Eli Zaretskii <eliz@gnu.org>
7606 * termhooks.h (encode_terminal_code): Declare prototype.
7608 * msdos.c (encode_terminal_code): Don't declare prototype.
7610 * term.c (encode_terminal_code): Now external again, used by
7611 w32console.c and msdos.c.
7613 * makefile.w32-in ($(BLD)/term.$(O), ($(BLD)/tparam.$(O)):
7614 Depend on $(SRC)/tparam.h, see 2011-03-11T07:24:21Z!eggert@cs.ucla.edu.
7616 2011-03-11 Paul Eggert <eggert@cs.ucla.edu>
7618 Fix some minor problems found by GCC 4.5.2's static checks.
7620 * fringe.c (update_window_fringes): Mark locals as initialized
7622 (destroy_fringe_bitmap, init_fringe_bitmap): Now static.
7624 * alloc.c (mark_fringe_data): Move decl from here ...
7625 * lisp.h (mark_fringe_data) [HAVE_WINDOW_SYSTEM]: ... to here,
7626 to check its interface.
7627 (init_fringe_once): Do not declare unless HAVE_WINDOW_SYSTEM.
7629 * fontset.c (free_realized_fontset): Now static.
7630 (Fset_fontset_font): Rename local to avoid shadowing.
7631 (fontset_font): Mark local as initialized.
7632 (FONTSET_SPEC, FONTSET_REPERTORY, RFONT_DEF_REPERTORY): Remove; unused.
7634 * xrdb.c: Include "xterm.h", to check x_load_resources's interface.
7636 * xselect.c (x_disown_buffer_selections): Remove; not used.
7637 (TRACE3) [!defined TRACE_SELECTION]: Remove; not used.
7638 (x_own_selection, Fx_disown_selection_internal): Rename locals
7640 (x_handle_dnd_message): Remove local to avoid shadowing.
7642 * lisp.h (GCPRO1_VAR, UNGCPRO_VAR): New macros,
7643 so that the caller can use some name other than gcpro1.
7644 (GCPRO1, UNGCPRO): Reimplement in terms of the new macros.
7645 * xfns.c (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
7646 (Fx_backspace_delete_keys_p):
7647 Use them to avoid shadowing, and rename vars to avoid shadowing.
7648 (x_decode_color, x_set_name, x_window): Now static.
7649 (Fx_create_frame): Add braces to silence GCC warning.
7650 (Fx_file_dialog, Fx_select_font): Fix pointer signedness.
7651 (x_real_positions, xg_set_icon_from_xpm_data, x_create_tip_frame):
7652 Remove unused locals.
7653 (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
7654 (Fx_backspace_delete_keys_p): Rename locals to avoid shadowing.
7655 Some of these renamings use the new GCPRO1_VAR and UNGCPRO_VAR
7658 * xterm.h (x_mouse_leave): New decl.
7660 * xterm.c (x_copy_dpy_color, x_focus_on_frame, x_unfocus_frame):
7661 Remove unused functions.
7662 (x_shift_glyphs_for_insert, XTflash, XTring_bell):
7663 (x_calc_absolute_position): Now static.
7664 (XTread_socket): Don't define label "out" unless it's used.
7665 Don't declare local "event" unless it's used.
7666 (x_iconify_frame, x_free_frame_resources): Don't declare locals
7667 unless they are used.
7668 (XEMBED_VERSION, xembed_set_info): Don't define unless needed.
7669 (x_fatal_error_signal): Remove; not used.
7670 (x_draw_image_foreground, redo_mouse_highlight, XTmouse_position):
7671 (x_scroll_bar_report_motion, handle_one_xevent, x_draw_bar_cursor):
7672 (x_error_catcher, x_connection_closed, x_error_handler):
7673 (x_error_quitter, xembed_send_message, x_iconify_frame):
7674 (my_log_handler): Rename locals to avoid shadowing.
7675 (x_delete_glyphs, x_ins_del_lines): Mark with NO_RETURN.
7676 (x_connection_closed): Tell GCC not to suggest NO_RETURN.
7678 * xfaces.c (clear_face_cache, Fx_list_fonts, Fface_font):
7679 Rename or move locals to avoid shadowing.
7680 (tty_defined_color, merge_face_heights): Now static.
7681 (free_realized_faces_for_fontset): Remove; not used.
7682 (Fx_list_fonts): Mark variable that gcc -Wuninitialized
7683 does not deduce is never used uninitialized.
7684 (STRDUPA, LSTRDUPA, FONT_POINT_SIZE_QUANTUM): Remove; not used.
7685 (LFACEP): Define only if XASSERTS, as it's not needed otherwise.
7687 * terminal.c (store_terminal_param): Now static.
7689 * xmenu.c (menu_highlight_callback): Now static.
7690 (set_frame_menubar): Remove unused local.
7691 (xmenu_show): Rename parameter to avoid shadowing.
7692 (xmenu_show, xdialog_show, xmenu_show): Make local pointers "const"
7693 since they might point to immutable storage.
7694 (next_menubar_widget_id): Declare only if USE_X_TOOLKIT,
7695 since it's unused otherwise.
7697 * xdisp.c (produce_glyphless_glyph): Initialize lower_xoff.
7698 Add a FIXME, since the code still doesn't look right. (Bug#8215)
7699 (Fcurrent_bidi_paragraph_direction): Simplify slightly; this
7700 avoids a gcc -Wuninitialized diagnostic.
7701 (display_line, BUILD_COMPOSITE_GLYPH_STRING, draw_glyphs):
7702 (note_mouse_highlight): Mark variables that gcc -Wuninitialized
7703 does not deduce are never used uninitialized.
7705 * lisp.h (IF_LINT): New macro, copied from ../lib-src/emacsclient.c.
7707 * xdisp.c (redisplay_window): Rename local to avoid shadowing.
7708 * window.c (window_loop, size_window):
7709 (run_window_configuration_change_hook, enlarge_window): Likewise.
7711 * window.c (display_buffer): Now static.
7712 (size_window): Mark variables that gcc -Wuninitialized
7713 does not deduce are never used uninitialized.
7714 * window.h (check_all_windows): New decl, to forestall
7715 gcc -Wmissing-prototypes diagnostic.
7716 * dispextern.h (bidi_dump_cached_states): Likewise.
7718 * charset.h (CHECK_CHARSET_GET_CHARSET): Rename locals to avoid
7720 * charset.c (map_charset_for_dump, Fchar_charset): Likewise.
7722 (Fsort_charsets): Redo min/max calculation to shorten the code a bit
7723 and to avoid gcc -Wuninitialized warning.
7724 (load_charset_map): Mark variables that gcc -Wuninitialized
7725 does not deduce are never used uninitialized.
7726 (load_charset): Abort instead of using uninitialized var (Bug#8229).
7728 * coding.c (coding_set_source, coding_set_destination):
7729 Use "else { /* comment */ }" rather than "else /* comment */;"
7730 for clarity, and to avoid gcc -Wempty-body warning.
7731 (Fdefine_coding_system_internal): Don't redeclare 'i' inside
7732 a block, when the outer 'i' will do.
7733 (decode_coding_utf_8, decode_coding_utf_16, detect_coding_emacs_mule):
7734 (emacs_mule_char, decode_coding_emacs_mule, detect_coding_iso_2022):
7735 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5):
7736 (decode_coding_raw_text, decode_coding_charset, get_translation_table):
7737 (Fdecode_sjis_char, Fdefine_coding_system_internal):
7738 Rename locals to avoid shadowing.
7739 * character.h (FETCH_STRING_CHAR_ADVANCE): Likewise.
7740 * coding.c (emacs_mule_char, encode_invocation_designation):
7741 Now static, since they're not used elsewhere.
7742 (decode_coding_iso_2022): Add "default: abort ();" as a safety check.
7743 (decode_coding_object, encode_coding_object, detect_coding_system):
7744 (decode_coding_emacs_mule): Mark variables that gcc
7745 -Wuninitialized does not deduce are never used uninitialized.
7746 (detect_coding_iso_2022): Initialize a local variable that might
7747 be used uninitialized. Leave a FIXME because it's not clear that
7748 this initialization is needed. (Bug#8211)
7749 (ISO_CODE_LF, ISO_CODE_CR, CODING_ISO_FLAG_EUC_TW_SHIFT):
7750 (ONE_MORE_BYTE_NO_CHECK, UTF_BOM, UTF_16_INVALID_P):
7751 (SHIFT_OUT_OK, ENCODE_CONTROL_SEQUENCE_INTRODUCER):
7752 (ENCODE_DIRECTION_R2L, ENCODE_DIRECTION_L2R):
7753 Remove unused macros.
7755 * category.c (hash_get_category_set): Remove unused local var.
7756 (copy_category_table): Now static, since it's not used elsewhere.
7757 * character.c (string_count_byte8): Likewise.
7759 * ccl.c (CCL_WRITE_STRING, CCL_ENCODE_CHAR, Fccl_execute_on_string):
7760 (Fregister_code_conversion_map): Rename locals to avoid shadowing.
7762 * chartab.c (copy_sub_char_table): Now static, since it's not used
7764 (sub_char_table_ref_and_range, char_table_ref_and_range):
7765 Rename locals to avoid shadowing.
7766 (ASET_RANGE, GET_SUB_CHAR_TABLE): Remove unused macros.
7768 * bidi.c (bidi_check_type): Now static, since it's not used elsewhere.
7769 (BIDI_BOB): Remove unused macro.
7771 * cm.c (cmgoto): Mark variables that gcc -Wuninitialized does not
7772 deduce are never used uninitialized.
7773 * term.c (encode_terminal_code): Likewise.
7775 * term.c (encode_terminal_code): Now static. Remove unused local.
7777 * tparam.h: New file.
7778 * term.c, tparam.h: Include it.
7779 * deps.mk (term.o, tparam.o): Depend on tparam.h.
7780 * term.c (tputs, tgetent, tgetflag, tgetnum, tparam, tgetstr):
7781 Move these decls to tparam.h, and make them agree with what
7782 is actually in tparam.c. The previous trick of using incompatible
7783 decls in different modules does not conform to the C standard.
7784 All callers of tparam changed to use tparam's actual API.
7785 * tparam.c (tparam1, tparam, tgoto):
7786 Use const pointers where appropriate.
7788 * cm.c (calccost, cmgoto): Use const pointers where appropriate.
7789 * cm.h (struct cm): Likewise.
7790 * dispextern.h (do_line_insertion_deletion_costs): Likewise.
7791 * scroll.c (ins_del_costs, do_line_insertion_deletion_costs): Likewise.
7792 * term.c (tty_ins_del_lines, calculate_costs, struct fkey_table):
7793 (term_get_fkeys_1, append_glyphless_glyph, produce_glyphless_glyph):
7794 (turn_on_face, init_tty): Likewise.
7795 * termchar.h (struct tty_display_info): Likewise.
7797 * term.c (term_mouse_position): Rename local to avoid shadowing.
7799 * alloc.c (mark_ttys): Move decl from here ...
7800 * lisp.h (mark_ttys): ... to here, so that it's checked against defn.
7802 2011-03-11 Andreas Schwab <schwab@linux-m68k.org>
7804 * .gdbinit (pwinx, xbuffer): Fix access to buffer name.
7806 2011-03-09 Juanma Barranquero <lekktu@gmail.com>
7808 * search.c (compile_pattern_1): Remove argument regp, unused since
7809 revid:rms@gnu.org-19941211082627-3x1g1wyqkjmwloig.
7810 (compile_pattern): Don't pass it.
7812 2011-03-08 Jan Djärv <jan.h.d@swipnet.se>
7814 * xterm.h (DEFAULT_GDK_DISPLAY): New define.
7815 (GDK_WINDOW_XID, gtk_widget_get_preferred_size): New defines
7817 (GTK_WIDGET_TO_X_WIN): Use GDK_WINDOW_XID.
7819 * xmenu.c (menu_position_func): Call gtk_widget_get_preferred_size.
7821 * gtkutil.c: Include gtkx.h if HAVE_GTK3. If ! HAVE_GTK3, define
7822 gdk_window_get_screen, gdk_window_get_geometry,
7823 gdk_x11_window_lookup_for_display and GDK_KEY_g.
7824 (xg_set_screen): Use DEFAULT_GDK_DISPLAY.
7825 (xg_get_pixbuf_from_pixmap): New function.
7826 (xg_get_pixbuf_from_pix_and_mask): Change parameters from GdkPixmap
7827 to Pixmap, take frame as parameter, remove GdkColormap parameter.
7828 Call xg_get_pixbuf_from_pixmap instead of
7829 gdk_pixbuf_get_from_drawable.
7830 (xg_get_image_for_pixmap): Do not make GdkPixmaps, call
7831 xg_get_pixbuf_from_pix_and_mask with Pixmap parameters instead.
7832 (xg_check_special_colors): Use GtkStyleContext and its functions
7834 (xg_prepare_tooltip, xg_hide_tooltip): Call gdk_window_get_screen.
7835 (xg_prepare_tooltip, create_dialog, menubar_map_cb)
7836 (xg_update_frame_menubar, xg_tool_bar_detach_callback)
7837 (xg_tool_bar_attach_callback, xg_update_tool_bar_sizes):
7838 Call gtk_widget_get_preferred_size.
7839 (xg_frame_resized): gdk_window_get_geometry only takes 5
7841 (xg_win_to_widget, xg_event_is_for_menubar):
7842 Call gdk_x11_window_lookup_for_display.
7843 (xg_set_widget_bg): New function.
7844 (delete_cb): New function.
7845 (xg_create_frame_widgets): Connect delete-event to delete_cb.
7846 Call xg_set_widget_bg. Only set backgrund pixmap for ! HAVE_GTK3
7847 (xg_set_background_color): Call xg_set_widget_bg.
7848 (xg_set_frame_icon): Call xg_get_pixbuf_from_pix_and_mask.
7849 (xg_create_scroll_bar): vadj is a GtkAdjustment for HAVE_GTK3.
7850 Only call gtk_range_set_update_policy if ! HAVE_GTK3.
7851 (xg_make_tool_item): Only connect xg_tool_bar_item_expose_callback
7853 (update_frame_tool_bar): Call gtk_widget_hide.
7854 (xg_initialize): Use GDK_KEY_g.
7856 * xsmfns.c (gdk_set_sm_client_id): Define to gdk_set_sm_client_id
7858 (x_session_initialize): Call gdk_x11_set_sm_client_id.
7860 * xterm.c (XFillRectangle): Use cairo routines for HAVE_GTK3.
7861 (x_term_init): Disable Xinput(2) with GDK_CORE_DEVICE_EVENTS.
7862 Load ~/emacs.d/gtkrc only for ! HAVE_GTK3.
7864 2011-03-08 Juanma Barranquero <lekktu@gmail.com>
7866 * w32xfns.c (select_palette): Check success of RealizePalette against
7867 GDI_ERROR, not zero.
7869 See ChangeLog.11 for earlier changes.
7875 Copyright (C) 2011 Free Software Foundation, Inc.
7877 This file is part of GNU Emacs.
7879 GNU Emacs is free software: you can redistribute it and/or modify
7880 it under the terms of the GNU General Public License as published by
7881 the Free Software Foundation, either version 3 of the License, or
7882 (at your option) any later version.
7884 GNU Emacs is distributed in the hope that it will be useful,
7885 but WITHOUT ANY WARRANTY; without even the implied warranty of
7886 MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
7887 GNU General Public License for more details.
7889 You should have received a copy of the GNU General Public License
7890 along with GNU Emacs. If not, see <http://www.gnu.org/licenses/>.