efba68d99d6deedffffa9216f18f3d07737332a5
[bpt/emacs.git] / src / ChangeLog
1 2011-12-03 Eli Zaretskii <eliz@gnu.org>
2
3 * xdisp.c (handle_invisible_prop): If the invisible text ends just
4 before a newline, prepare the bidi iterator for consuming the
5 newline, and keep the current paragraph direction. (Bug#10183)
6
7 2011-12-02 Juri Linkov <juri@jurta.org>
8
9 * search.c (Fword_search_regexp): New Lisp function created from
10 `wordify'. Change type of arg `lax' from `int' to `Lisp_Object'.
11 (Fword_search_backward, Fword_search_forward)
12 (Fword_search_backward_lax, Fword_search_forward_lax):
13 Use `Fword_search_regexp' instead of `wordify'. Doc fix.
14 (syms_of_search): Define `Sword_search_regexp'. (Bug#10145)
15
16 2011-12-01 Stefan Monnier <monnier@iro.umontreal.ca>
17
18 * fileio.c (Finsert_file_contents): Move after-change-function call
19 to before the "handled:" label, since all "goto handled" appear in
20 cases where the *-change-functions have already been properly called
21 (bug#10117).
22
23 2011-12-01 Andreas Schwab <schwab@linux-m68k.org>
24
25 * keyboard.c (interrupt_signal): Don't call kill-emacs when
26 waiting for input. (Bug#10169)
27
28 2011-11-30 Eli Zaretskii <eliz@gnu.org>
29
30 * dispnew.c (adjust_glyph_matrix): Remove the assertion that
31 verifies glyph row's hash code--we have just reallocated the
32 glyphs, so their contents can be complete garbage. (Bug#10164)
33
34 2011-11-30 Juanma Barranquero <lekktu@gmail.com>
35
36 * dispnew.c (adjust_glyph_matrix) [XASSERTS]: Add missing check.
37
38 2011-11-30 Eli Zaretskii <eliz@gnu.org>
39
40 * dispnew.c (adjust_glyph_matrix) [XASSERTS]: Ensure ROW's
41 attributes are tested _before_ calling verify_row_hash, to protect
42 against GCC re-ordering of the tests. (Bug#10164)
43
44 2011-11-29 Jan Djärv <jan.h.d@swipnet.se>
45
46 * xterm.h (struct x_output): net_wm_state_hidden_seen is new.
47
48 * xterm.c (handle_one_xevent): Only set async_visible and friends
49 if net_wm_state_hidden_seen is non-zero (Bug#10002)
50 (get_current_wm_state): Set net_wm_state_hidden_seen to 1 if
51 _NET_WM_STATE_HIDDEN is in NET_WM_STATE.
52
53 2011-11-28 Paul Eggert <eggert@cs.ucla.edu>
54
55 Remove GCPRO-related macros that exist only to avoid shadowing locals.
56 * lisp.h (GCPRO1_VAR, GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR, GCPRO5_VAR)
57 (GCPRO6_VAR, UNGCPRO_VAR): Remove. See
58 <http://lists.gnu.org/archive/html/emacs-diffs/2011-11/msg00265.html>.
59 All uses changed to use GCPRO1 etc.
60 (GCPRO1, GCPRO2, GCPRO3, GCPRO4, GCPRO5, GCPRO6, UNGCPRO):
61 Revert to old implementation (i.e., before 2011-03-11).
62
63 2011-11-28 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
64
65 * dispnew.c (scrolling_window): Truncate overlaps in copy destination
66 of scroll runs so as to avoid assigning disabled bogus rows and
67 unnecessary graphics copy operations.
68
69 2011-11-27 Eli Zaretskii <eliz@gnu.org>
70
71 * s/ms-w32.h (utimbuf) [_MSC_VER]: Don't define.
72 (snprintf) [_MSC_VER]: Redirect to _snprintf.
73 (strtoll) [_MSC_VER]: Redirect to _strtoi64.
74 (malloc, free, realloc, calloc): Redirect to e_* only when
75 compiling Emacs.
76
77 * lisp.h (GCTYPEBITS): Move before first use.
78 (ALIGN_GCTYPEBITS) [_MSC_VER]: Define.
79 (DECL_ALIGN) [_MSC_VER]: Use it, as MSVC doesn't like bit ops in
80 this macro definition.
81
82 * s/ms-w32.h (tzname): Redirect to _tzname for all values of
83 _MSC_VER.
84
85 2011-11-27 Jan Djärv <jan.h.d@swipnet.se>
86
87 * gtkutil.c (xg_create_frame_widgets): Call
88 gtk_window_set_has_resize_grip (FALSE) if that function is
89 present with Gtk+ 2.0.
90
91 2011-11-26 Paul Eggert <eggert@cs.ucla.edu>
92
93 * fileio.c (Finsert_file_contents): Undo previous change; see
94 <http://lists.gnu.org/archive/html/emacs-diffs/2011-11/msg00265.html>.
95
96 2011-11-26 Paul Eggert <eggert@cs.ucla.edu>
97
98 Rename locals to avoid shadowing.
99 * fileio.c (Finsert_file_contents):
100 Rename inner 'gcpro1' to 'inner_gcpro1' to avoid shadowing.
101 * process.c (wait_reading_process_output):
102 Rename inner 'proc' to 'p' to avoid shadowing.
103 Indent for consistency with usual Emacs style.
104
105 2011-11-25 Eli Zaretskii <eliz@gnu.org>
106
107 * xdisp.c (redisplay_window): If cursor row is not fully visible
108 after recentering, and scroll-conservatively is set to a large
109 number, scroll window by a few more lines to make the cursor fully
110 visible and out of scroll-margin. (Bug#10105)
111 (start_display): Don't move to the next line if the display should
112 start at a newline that is part of a display vector or an overlay
113 string. (Bug#10119)
114
115 2011-11-24 Juri Linkov <juri@jurta.org>
116
117 * image.c (imagemagick_load_image): Move `MagickSetResolution' down
118 after the `MagickPingImage' call. (Bug#10112)
119
120 2011-11-23 Chong Yidong <cyd@gnu.org>
121
122 * window.c (Fcoordinates_in_window_p): Accept only live windows.
123
124 2011-11-23 Martin Rudalics <rudalics@gmx.at>
125
126 * buffer.c (Fkill_buffer): Run replace_buffer_in_windows before
127 making another buffer current. (Bug#10114)
128
129 2011-11-23 Glenn Morris <rgm@gnu.org>
130
131 * font.c (font_find_for_lface) [HAVE_NS]: Ignore case. (Bug#2526)
132
133 2011-11-23 Chong Yidong <cyd@gnu.org>
134
135 * xdisp.c (compute_stop_pos): Check validity of end_charpos before
136 using it (Bug#5984).
137
138 2011-11-22 Eli Zaretskii <eliz@gnu.org>
139
140 * dispnew.c (adjust_glyph_matrix): Don't verify hash code of mode-
141 and header-lines, as they don't have one computed for them.
142 (Bug#10098)
143
144 * .gdbinit (prow): Make displayed values more self-explaining.
145 Add row's hash code.
146
147 2011-11-21 Lars Magne Ingebrigtsen <larsi@gnus.org>
148
149 * process.c (wait_reading_process_output): Fix asynchrounous
150 GnuTLS socket handling on some versions of the GnuTLS library.
151 (wait_reading_process_output): Add comment and URL.
152
153 2011-11-21 Jan Djärv <jan.h.d@swipnet.se>
154
155 * xterm.c (x_clear_frame): Reinstate the XClearWindow call.
156
157 2011-11-21 Chong Yidong <cyd@gnu.org>
158
159 * window.c (Fnext_window, Fprevious_window): Doc fix.
160
161 2011-11-20 Stefan Monnier <monnier@iro.umontreal.ca>
162
163 * window.c (get_phys_cursor_glyph): Fix Lisp_Object/int mixup.
164
165 2011-11-20 Juanma Barranquero <lekktu@gmail.com>
166
167 * nsfont.m (syms_of_nsfont) <ns-reg-to-script>: Fix typo.
168
169 2011-11-20 Martin Rudalics <rudalics@gmx.at>
170
171 * window.c (Fset_window_combination_limit): Rename argument
172 STATUS to LIMIT.
173 (Vwindow_combination_limit): Remove "status" from doc-string.
174
175 2011-11-20 Andreas Schwab <schwab@linux-m68k.org>
176
177 * m/ibms390.h: Remove.
178 * m/ibms390x.h: Don't include "ibms390.h".
179
180 2011-11-20 Stefan Monnier <monnier@iro.umontreal.ca>
181
182 * fileio.c (Finsert_file_contents): Add missing gcpro1 variable.
183 Suggested by Dmitry Antipov <dmantipov@yandex.ru>.
184
185 2011-11-20 Juanma Barranquero <lekktu@gmail.com>
186
187 * casetab.c (Fset_case_table):
188 * charset.c (Fcharset_after): Fix typos.
189
190 2011-11-20 Paul Eggert <eggert@cs.ucla.edu>
191
192 Standardize on VIRT_ADDR_VARIES behavior (Bug#10042).
193 Otherwise, valgrind does not work on some platforms.
194 Problem reported by Andreas Schwab in
195 <http://lists.gnu.org/archive/html/emacs-devel/2011-11/msg00081.html>.
196 * puresize.h (pure, PURE_P): Always behave as if VIRT_ADDR_VARIES
197 is set, removing the need for VIRT_ADDRESS_VARIES.
198 (PURE_P): Use a more-efficient implementation that needs just one
199 comparison, not two: on x86-64 with GCC 4.6.2, this cut down the
200 number of instructions from 6 (xorl, cmpq, jge, xorl, cmpq, setge)
201 to 4 (xorl, subq, cmpq, setbe).
202 * alloc.c (pure): Always extern now, since that's the
203 VIRT_ADDR_VARIES behavior.
204 (PURE_POINTER_P): Use a single comparison, not two, for
205 consistency with the new puresize.h.
206 * lisp.h (PNTR_COMPARISON_TYPE): Remove; no longer needed.
207 * m/ibms390.h, m/intel386.h, m/template.h, s/cygwin.h, s/hpux10-20.h:
208 Remove VIRT_ADDR_VARIES no longer needed.
209
210 2011-11-19 Eli Zaretskii <eliz@gnu.org>
211
212 * xdisp.c (x_write_glyphs, draw_phys_cursor_glyph)
213 (erase_phys_cursor, update_window_cursor, show_mouse_face)
214 (cursor_in_mouse_face_p): If the cursor position is out of bounds,
215 behave as if the cursor position were at the window margin.
216
217 * window.c (get_phys_cursor_glyph): If the window is hscrolled,
218 and the cursor position is out of bounds, behave as if the cursor
219 position were at the window margin. (Bug#10075)
220
221 2011-11-18 Chong Yidong <cyd@gnu.org>
222
223 * window.c (Fwindow_combination_limit): Make first argument
224 non-optional, since it is meaningless for live windows like the
225 selected window.
226
227 2011-11-18 Dmitry Antipov <dmantipov@yandex.ru>
228
229 * keymap.c (Fwhere_is_internal): Add missing RETURN_UNGCPROs.
230
231 2011-11-18 Stefan Monnier <monnier@iro.umontreal.ca>
232
233 * intervals.c: Fix grafting over the whole buffer (bug#10071).
234 (graft_intervals_into_buffer): Simplify.
235
236 2011-11-18 Eli Zaretskii <eliz@gnu.org>
237
238 * dispnew.c (swap_glyph_pointers): Swap the used[] arrays and the
239 hash values of the two rows.
240 (copy_row_except_pointers): Preserve the used[] arrays and the
241 hash values of the two rows. (Bug#10035)
242 (add_row_entry): Add xassert to verify that ROW's hash code is valid.
243
244 * xdisp.c (row_hash): New function, body extracted from
245 compute_line_metrics.
246 (compute_line_metrics): Call row_hash, instead of computing the
247 hash code inline.
248
249 * dispnew.c (verify_row_hash): Call row_hash for computing the
250 hash code of a row, instead of duplicating code from xdisp.c.
251
252 * dispextern.h (row_hash): Add prototype.
253
254 2011-11-18 Tassilo Horn <tassilo@member.fsf.org>
255
256 * frame.c (delete_frame): Don't delete the terminal when the last
257 X frame is closed if emacs is built with GTK toolkit.
258
259 2011-11-17 Juanma Barranquero <lekktu@gmail.com>
260
261 * window.c (syms_of_window) <window-combination-resize>: Fix typo.
262
263 2011-11-17 Martin Rudalics <rudalics@gmx.at>
264
265 * window.c (Vwindow_splits): Rename to
266 Vwindow_combination_resize. Suggested by Juri Linkov.
267 (Fsplit_window_internal): Use Vwindow_combination_resize instead
268 of Vwindow_splits.
269
270 2011-11-16 Juanma Barranquero <lekktu@gmail.com>
271
272 * nsfns.m (Fns_font_name):
273 * window.c (syms_of_window) <window-combination-limit>: Fix typos.
274
275 2011-11-16 Martin Rudalics <rudalics@gmx.at>
276
277 * window.h (window): Rename slot "nest" to "combination_limit".
278 * window.c (Fwindow_nest): Rename to Fwindow_combination_limit.
279 (Fset_window_nest): Rename to Fset_window_combination_limit.
280 (Vwindow_nest): Rename to Vwindow_combination_limit.
281 (recombine_windows, make_parent_window, make_window)
282 (Fsplit_window_internal, saved_window)
283 (Fset_window_configuration, save_window_save): Rename all
284 occurrences of window_nest to window_combination_limit.
285
286 2011-11-15 Juanma Barranquero <lekktu@gmail.com>
287
288 * image.c (imagemagick_load_image): Fix typo.
289
290 2011-11-14 Eli Zaretskii <eliz@gnu.org>
291
292 * xdisp.c (display_line): Move the call to
293 highlight_trailing_whitespace before the call to
294 compute_line_metrics, since the latter needs to see the final
295 faces of all the glyphs to compute ROW's hash value. Fixes
296 assertion violations in row_equal_p. (Bug#10035)
297
298 2011-11-14 Juanma Barranquero <lekktu@gmail.com>
299
300 * w32proc.c (reader_thread): Don't check pending input if cp->fd < 0,
301 just return (bug#10044).
302
303 2011-11-12 Eli Zaretskii <eliz@gnu.org>
304
305 * makefile.w32-in (HEAPSIZE): New variable, allows to build temacs
306 with user-defined heap size. Bump the default size of the temacs
307 heap to 27MB, to avoid memory warning when running temacs.
308 ($(TEMACS)): Use HEAPSIZE instead of a hardcoded value.
309
310 * dispnew.c (scrolling_window): Fix incorrect indices in accessing
311 current_matrix and desired_matrix. (Bug#9990)
312 (verify_row_hash) [XASSERTS]: New function.
313 (adjust_glyph_matrix, row_equal_p): Use it in xassert to verify
314 that the hash value of glyph rows is correct.
315
316 2011-11-12 Martin Rudalics <rudalics@gmx.at>
317
318 * window.h (window): Remove splits slot.
319 * window.c (Fwindow_splits, Fset_window_splits): Remove.
320 (Fdelete_other_windows_internal, make_parent_window)
321 (make_window, Fsplit_window_internal, Fdelete_window_internal)
322 (Fset_window_configuration, save_window_save): Don't deal with
323 split status of windows.
324 (saved_window): Remove splits slot.
325 (Vwindow_splits): Rewrite doc-string.
326
327 2011-11-11 Jan Djärv <jan.h.d@swipnet.se>
328
329 * xfns.c (unwind_create_frame):
330 * nsfns.m (unwind_create_frame):
331 * w32fns.c (unwind_create_frame): Use Fmemq to check if frame is in
332 Vframe_list (Bug#9999).
333
334 2011-11-11 Dmitry Antipov <dmantipov@yandex.ru>
335
336 * xdisp.c (syms_of_xdisp): Remove duplicated definition of Qtext.
337
338 2011-11-11 Kenichi Handa <handa@m17n.org>
339
340 * callproc.c (Fcall_process): Set the member dst_multibyte of
341 process_coding.
342
343 2011-11-11 Johan Bockgård <bojohan@gnu.org>
344
345 * xdisp.c (fill_composite_glyph_string): Always set s->face, to
346 avoid a crash (bug#9496).
347
348 2011-11-09 Chong Yidong <cyd@gnu.org>
349
350 * window.c (Fwindow_inside_edges, Fwindow_inside_pixel_edges)
351 (Fwindow_inside_absolute_pixel_edges): Only allow live windows.
352
353 2011-11-08 Paul Eggert <eggert@cs.ucla.edu>
354
355 * s/gnu.h (GC_MARK_STACK): Define to GC_MAKE_GCPROS_NOOPS (Bug#9926).
356
357 2011-11-08 Paul Eggert <eggert@cs.ucla.edu>
358
359 Avoid some portability problems by eschewing 'extern inline' functions.
360 The trivial performance wins aren't worth the portability hassles; see
361 <http://lists.gnu.org/archive/html/emacs-devel/2011-11/msg00084.html>
362 et seq.
363 * dispextern.h (window_box, window_box_height, window_text_bottom_y)
364 (window_box_width, window_box_left, window_box_left_offset)
365 (window_box_right, window_box_right_offset): Undo previous change,
366 by removing the "extern"s.
367 * intervals.c (adjust_intervals_for_insertion)
368 (adjust_intervals_for_deletion): Undo previous change,
369 making these static again.
370 (offset_intervals, temp_set_point_both, temp_set_point)
371 (copy_intervals_to_string): No longer inline.
372 * xdisp.c (window_text_bottom_y, window_box_width)
373 (window_box_height, window_box_left_offset)
374 (window_box_right_offset, window_box_left, window_box_right)
375 (window_box): No longer inline.
376
377 2011-11-08 Chong Yidong <cyd@gnu.org>
378
379 * window.c (Fwindow_left_column, Fwindow_top_line): Doc fix.
380 (Fwindow_body_height, Fwindow_body_width): Move from Lisp. Signal
381 an error if not a live window.
382 (Fwindow_total_width, Fwindow_total_height): Move from Lisp.
383 (Fwindow_total_size, Fwindow_body_size): Move to Lisp.
384
385 2011-11-07 Juanma Barranquero <lekktu@gmail.com>
386
387 * lisp.h (syms_of_abbrev): Remove declaration.
388 Reported by CHENG Gao <chenggao@royau.me>.
389
390 2011-11-07 Eli Zaretskii <eliz@gnu.org>
391
392 * w32.c (check_windows_init_file): Don't look for term/w32-win.el
393 if Vpurify_flag is non-nil. Fixes a crash when running w32 build
394 of temacs in GUI mode.
395
396 2011-11-07 Martin Rudalics <rudalics@gmx.at>
397
398 * window.h: Declare delete_all_child_windows instead of
399 delete_all_subwindows.
400 * window.c (Fwindow_nest, Fset_window_nest)
401 (Fset_window_new_total, Fset_window_new_normal)
402 (Fwindow_resize_apply): Don't use term subwindow in doc-strings.
403 (delete_all_subwindows): Rename to delete_all_child_windows.
404 (Fdelete_other_windows_internal, Fset_window_configuration):
405 Call delete_all_child_windows instead of delete_all_subwindows.
406 * frame.c (delete_frame): Call delete_all_child_windows instead
407 of delete_all_subwindows.
408
409 2011-11-07 Paul Eggert <eggert@cs.ucla.edu>
410
411 * alloc.c (DEADP): New macro, for porting to GNU/Hurd (Bug#9926).
412 This is also needed for porting to any host where GC_MARK_STACK is
413 not GC_MAKE_GCPROS_NOOPS.
414 (which_symbols): Use it.
415
416 2011-11-07 Kenichi Handa <handa@m17n.org>
417
418 * coding.c (coding_set_destination): Check coding->src_pos only
419 when coding->src_object is a buffer (bug#9910).
420
421 * process.c (send_process): Set the member src_multibyte of coding
422 to 0 (bug#9911) when sending a unibyte text.
423
424 * callproc.c (Fcall_process): Set the member src_multibyte of
425 process_coding to 0 (bug#9912).
426
427 2011-11-06 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
428
429 * xmenu.c (cleanup_widget_value_tree): New function.
430 (xmenu_show, xdialog_show): Use it in record_unwind_protect instead of
431 calling free_menubar_widget_value_tree directly (Bug#9830).
432
433 2011-11-06 Paul Eggert <eggert@cs.ucla.edu>
434
435 Fix some portability problems with 'inline'.
436 * dispextern.h (window_box, window_box_height, window_text_bottom_y)
437 (window_box_width, window_box_left, window_box_left_offset)
438 (window_box_right, window_box_right_offset): Declare extern.
439 Otherwise, these inline functions do not conform to C99 and
440 are miscompiled by Microsoft compilers. Reported by Eli Zaretskii in
441 <http://lists.gnu.org/archive/html/emacs-devel/2011-11/msg00084.html>.
442 * intervals.c (adjust_intervals_for_insertion)
443 (adjust_intervals_for_deletion): Now extern, because otherwise the
444 extern inline functions 'offset_intervals' couldn't refer to it.
445 (static_offset_intervals): Remove.
446 (offset_intervals): Rewrite using the old contents of
447 static_offset_intervals. The old version didn't conform to C99
448 because an extern inline function contained a reference to an
449 identifier with static linkage.
450
451 2011-11-06 Andreas Schwab <schwab@linux-m68k.org>
452
453 * keyboard.c (interrupt_signal): Don't call kill-emacs while in
454 GC.
455
456 2011-11-06 Eli Zaretskii <eliz@gnu.org>
457
458 * xdisp.c (init_iterator, reseat_to_string): Don't set the
459 iterator's bidi_p flag if Vpurify_flag is non-nil. (Bug#9963)
460 (Fcurrent_bidi_paragraph_direction): If Vpurify_flag is non-nil,
461 return Qleft_to_right.
462
463 2011-11-06 Chong Yidong <cyd@gnu.org>
464
465 * window.c (Fwindow_live_p, Fwindow_frame, Fframe_root_window)
466 (Fminibuffer_window, Fwindow_buffer, Fwindow_splits)
467 (Fset_window_splits, Fwindow_nest, Fset_window_nest)
468 (Fwindow_use_time, Fwindow_total_size, Fwindow_normal_size)
469 (Fwindow_new_normal, Fwindow_left_column, Fwindow_top_line)
470 (Fwindow_margins, Fwindow_fringes, Fwindow_scroll_bars)
471 (Fwindow_vscroll): Doc fix.
472 (Fwindow_top_child, Fwindow_left_child): Eliminate a nil default
473 argument, since it makes no sense to pass a live window and for
474 consistency with window-child.
475
476 2011-11-05 Christoph Scholtes <cschol2112@googlemail.com>
477
478 * makefile.w32-in ($(TEMACS), (gl-stamp)): Use $(THISDIR) to
479 support MSVC.
480
481 2011-11-05 Jason Rumney <jasonr@gnu.org>
482
483 * w32font.c (font_matches_spec): Filter out non-Japanese kana fonts.
484 (add_font_entity_to_list): Filter out non-Japanese Shift-JIS
485 fonts (Bug#6029).
486 (add_font_entity_to_list): Fix logic errors in mixed boolean and
487 bitwise arithmetic preventing use of unicode-sip and non-truetype
488 opentype fonts.
489
490 2011-11-05 Eli Zaretskii <eliz@gnu.org>
491
492 * s/ms-w32.h (fstat, stat, utime): Move redirections to
493 "emacs"-only part.
494
495 * w32fns.c (x_create_tip_frame, Fx_create_frame): Rearrange
496 initialization code to keep similarity to xfns.c after changes
497 from 2011-11-05.
498
499 2011-11-05 Jan Djärv <jan.h.d@swipnet.se>
500
501 * nsfns.m: Declare image_cache_refcount if GLYPH_DEBUG.
502 (unwind_create_frame): New function (Bug#9943).
503 (Fx_create_frame): Restructure code to be more similar to the one in
504 xfns.c. Call record_unwind_protect with unwind_create_frame (Bug#9943).
505 Initialize image_cache_refcount if GLYPH_DEBUG (Bug#9943).
506 Move terminal->reference_count++ just before making the frame official
507 (Bug#9943).
508
509 * nsterm.m (x_free_frame_resources): New function.
510 (x_destroy_window): Move code to x_free_frame_resources.
511
512 * xfns.c (unwind_create_frame): Fix comment.
513 (Fx_create_frame, x_create_tip_frame): Move
514 terminal->reference_count++ just before making the frame
515 official. Move initialization of image_cache_refcount and
516 dpyinfo_refcount before calling init_frame_faces (Bug#9943).
517
518 2011-11-05 Eli Zaretskii <eliz@gnu.org>
519
520 Support MSVC build with newer versions of Visual Studio.
521 * makefile.w32-in (TAGS-gmake): Don't use $(patsubst ...), as
522 Nmake barfs on that. Use $(OBJ*_c) variables instead, defined on
523 nt/gmake.defs.
524
525 * lisp.h (ENUM_BF): New macro, for enumerated types in bitfields,
526 which are not supported by MSVC.
527 (Lisp_Symbol, Lisp_Misc_Any, Lisp_Marker, Lisp_Misc_Overlay)
528 (Lisp_Save_Value, Lisp_Free): Use ENUM_BF for enumerated types in
529 bitfields.
530 (Lisp_Object) [USE_LISP_UNION_TYPE]: Use ENUM_BF for enumerated
531 types in bitfields.
532 (DEFUN) [_MSC_VER]: Define in a different way for MSVC.
533
534 * w32fns.c [_MSC_VER]: DECLARE_HANDLE for any MSVC version.
535
536 2011-11-05 Fabrice Popineau <fabrice.popineau@supelec.fr> (tiny change)
537
538 Support MSVC build with newer versions of Visual Studio.
539 * w32.c: Don't include w32api.h for MSVC.
540 (init_environment) [_MSC_VER]: Call sys_access, not _access.
541
542 * s/ms-w32.h <sigset_t, ssize_t> [_MSC_VER]: Typedefs for MSVC.
543 [_MSC_VER]: Include sys/timeb.h, sys/stat.h, and signal.h.
544 (fstat, stat, utime) [_MSC_VER]: Redirect to their sys_* cousins.
545 (malloc, free, realloc, calloc) [_MSC_VER]: Always redirect to the
546 e_* cousins.
547 (alloca) [_MSC_VER]: Define to _alloca.
548
549 * lisp.h (DECL_ALIGN) [_MSC_VER]: Define for MSVC.
550
551 * regex.c <re_char> [_MSC_VER]: A separate definition for MSVC.
552
553 2011-11-04 Eli Zaretskii <eliz@gnu.org>
554
555 * xdisp.c (note_mouse_highlight): If either of
556 previous/next-single-property-change returns nil, treat that as
557 the beginning or the end of the buffer. (Bug#9955)
558
559 2011-11-04 Jan Djärv <jan.h.d@swipnet.se>
560
561 * gtkutil.c (xg_make_tool_item): Add callbacks if one of wimage or
562 label is not null (Bug#9951).
563 (xg_tool_item_stale_p): Handle the fact that wimage and/or wlbl
564 may be NULL.
565
566 2011-11-04 Eli Zaretskii <eliz@gnu.org>
567
568 * window.c (Fwindow_body_size): Mention in the doc string that the
569 return value is in frame's canonical units. (Bug#9949)
570
571 2011-11-03 Eli Zaretskii <eliz@gnu.org>
572
573 * xdisp.c (note_mouse_highlight): Initialize `area'. (Bug#9947)
574
575 * w32fns.c (unwind_create_frame): If needed, free the glyph
576 matrices of the partially constructed frame. (Bug#9943)
577 * xfns.c (unwind_create_frame): Likewise.
578
579 2011-11-01 Eli Zaretskii <eliz@gnu.org>
580
581 * xdisp.c (mouse_face_from_buffer_pos): Fix a typo in a comment.
582 Don't stop backward scan on the continuation glyph, even though
583 its CHARPOS is positive.
584 (mouse_face_from_buffer_pos, note_mouse_highlight): Rename
585 cover_string to disp_string.
586
587 2011-11-01 Martin Rudalics <rudalics@gmx.at>
588
589 * window.c (temp_output_buffer_show): Don't use
590 Vtemp_buffer_show_specifiers.
591 (Vtemp_buffer_show_specifiers): Remove unused variable.
592
593 2011-10-30 Eli Zaretskii <eliz@gnu.org>
594
595 * xdisp.c (try_cursor_movement): Make sure ROW isn't decremented
596 past the beginning of the current glyph matrix.
597
598 2011-10-30 Adam Sjøgren <asjo@koldfront.dk> (tiny change)
599
600 * xterm.c: Include X11/Xproto.h if HAVE_GTK3.
601 (x_error_handler): Ignore BadMatch for X_SetInputFocus for
602 HAVE_GTK3 (Bug#9869).
603
604 * gtkutil.c (xg_win_to_widget, xg_event_is_for_menubar): Initialize
605 type to GDK_NOTHING so valgrind does not complain (Bug#9901).
606
607 * xterm.h (x_display_info): Add Xatom_net_wm_state_hidden (Bug#9893).
608
609 * xterm.c: Declare x_handle_net_wm_state to return int.
610 (handle_one_xevent): Check if we are iconified but don't have
611 _NET_WM_STATE_HIDDEN. If do, treat as deiconify (Bug#9893).
612 (get_current_wm_state): Return non-zero if not hidden,
613 check for _NET_WM_STATE_HIDDEN (Bug#9893).
614 (do_ewmh_fullscreen): Ignore return value from get_current_wm_state.
615 (x_handle_net_wm_state): Return what get_current_wm_state returns.
616 (x_term_init): Initialize dpyinfo->Xatom_net_wm_state_hidden.
617
618 2011-10-29 Paul Eggert <eggert@cs.ucla.edu>
619
620 * alloc.c (which_symbols): Declare EXTERNALLY_VISIBLE,
621 so that this new function doesn't get optimized away by a
622 whole-program optimizer. Make the 2nd arg EMACS_INT, not int.
623
624 2011-10-29 Andreas Schwab <schwab@linux-m68k.org>
625
626 * frame.h (MOUSE_HL_INFO): Remove excess parens.
627
628 2011-10-29 Eli Zaretskii <eliz@gnu.org>
629
630 Fix the `xbytecode' command.
631 * .gdbinit (xprintbytestr): New command.
632 (xwhichsymbols): Rename from `which'; all callers changed.
633 (xbytecode): Print the byte-code string as well.
634
635 2011-10-29 Kim Storm <storm@cua.dk>
636
637 * alloc.c (which_symbols): New function.
638
639 2011-10-29 Andreas Schwab <schwab@linux-m68k.org>
640
641 * minibuf.c (read_minibuf_noninteractive): Allow reading empty
642 line. (Bug#9903)
643
644 2011-10-29 Glenn Morris <rgm@gnu.org>
645
646 * process.c (wait_reading_process_output): Revert 2009-08-30 change.
647 Not clear what it was for, and it causes various bugs. (Bug#9839)
648
649 2011-10-28 Eli Zaretskii <eliz@gnu.org>
650
651 * xdisp.c (note_mouse_highlight): Initialize `part', to avoid a
652 possible random value that matches one of those tested as
653 condition to clear the mouse face.
654
655 2011-10-28 Chong Yidong <cyd@gnu.org>
656
657 * xdisp.c (note_mouse_highlight): Fix use of uninitialized var.
658
659 2011-10-28 Dan Nicolaescu <dann@ics.uci.edu>
660
661 * window.c (make_window): Initialize phys_cursor_on_p.
662
663 2011-10-28 Stefan Monnier <monnier@iro.umontreal.ca>
664
665 * lisp.h (struct Lisp_Symbol): Update comments.
666
667 2011-10-28 Juanma Barranquero <lekktu@gmail.com>
668
669 * w32font.c (w32_load_unicows_or_gdi32): Add missing return.
670
671 2011-10-28 Eli Zaretskii <eliz@gnu.org>
672
673 Fix Emacs on Windows 9X (bug#8562). Thanks to oslsachem
674 <oslsachem@gmail.com> for helping to debug this.
675
676 * w32font.c (g_b_init_is_w9x, g_b_init_get_outline_metrics_w)
677 (g_b_init_get_text_metrics_w, g_b_init_get_glyph_outline_w)
678 (g_b_init_get_glyph_outline_w): New static variables.
679 (GetOutlineTextMetricsW_Proc, GetTextMetricsW_Proc)
680 (GetGlyphOutlineW_Proc): New typedefs.
681 (w32_load_unicows_or_gdi32, get_outline_metrics_w)
682 (get_text_metrics_w, get_glyph_outline_w, globals_of_w32font):
683 New functions.
684 (w32font_open_internal, compute_metrics):
685 Call get_outline_metrics_w, get_text_metrics_w, and get_glyph_outline_w
686 instead of calling the "wide" APIs directly.
687
688 * emacs.c (main) [HAVE_NTGUI]: Call globals_of_w32font.
689
690 * w32.h (syms_of_w32font): Add prototype.
691
692 2011-10-27 Juanma Barranquero <lekktu@gmail.com>
693
694 * window.c (Fframe_root_window, Fframe_first_window, Fwindow_end)
695 (Fframe_selected_window, Ftemp_output_buffer_show, Fnext_window)
696 (Fdelete_window_internal, Fwindow_parameters): Fix typos in docstrings.
697 (Fmove_to_window_line): Doc fix.
698
699 2011-10-27 Chong Yidong <cyd@gnu.org>
700
701 * process.c (make_process): Set gnutls_state to NULL.
702
703 * gnutls.c (emacs_gnutls_deinit): Deinit the gnutls_state if it is
704 non-NULL, regardless of GNUTLS_INITSTAGE.
705 (Fgnutls_boot): Cleanups. Call emacs_gnutls_deinit if we signal
706 an error. Set process slots as soon as we allocate them.
707
708 * gnutls.h (GNUTLS_LOG, GNUTLS_LOG2): Fix macros.
709
710 2011-10-27 Chong Yidong <cyd@gnu.org>
711
712 * gnutls.c (emacs_gnutls_deinit): New function.
713 Deallocate credentials structures as well as calling gnutls_deinit.
714 (Fgnutls_deinit, Fgnutls_boot): Use it.
715
716 * process.c (make_process): Initialize GnuTLS credentials to NULL.
717 (deactivate_process): Call emacs_gnutls_deinit.
718
719 2011-10-27 Juanma Barranquero <lekktu@gmail.com>
720
721 * image.c (x_create_x_image_and_pixmap):
722 * w32.c (sys_rename, w32_delayed_load):
723 * w32font.c (fill_in_logfont):
724 * w32reg.c (x_get_string_resource): Silence compiler warnings.
725
726 2011-10-26 Juanma Barranquero <lekktu@gmail.com>
727
728 * w32fns.c (w32_default_color_map): New function,
729 extracted from Fw32_default_color_map.
730 (Fw32_default_color_map, Fx_open_connection): Use it. (Bug#9785)
731
732 2011-10-25 Paul Eggert <eggert@cs.ucla.edu>
733
734 * dispextern.h (Fcontrolling_tty_p): New decl (Bug#6649 part 2).
735
736 2011-10-25 Stefan Monnier <monnier@iro.umontreal.ca>
737
738 * keyboard.c (test_undefined): New function (bug#9751).
739 (read_key_sequence): Use it to detect when a key is bound to `undefined'.
740
741 2011-10-25 Enami Tsugutomo <tsugutomo.enami@jp.sony.com>
742
743 * sysdep.c (init_sys_modes): Fix the check for the controlling
744 terminal (Bug#6649).
745
746 2011-10-20 Eli Zaretskii <eliz@gnu.org>
747
748 * dispextern.h (struct bidi_it): New member next_en_type.
749
750 * bidi.c (bidi_line_init): Initialize the next_en_type member.
751 (bidi_resolve_explicit_1): When next_en_pos is valid for the
752 current character, check also for next_en_type being WEAK_EN.
753 (bidi_resolve_weak): Don't enter the expensive loop if the current
754 position is before next_en_pos. Record the bidi type of the first
755 non-ET, non-BN character we find, in addition to its position.
756 (bidi_level_of_next_char): Invalidate next_en_type when
757 next_en_pos is over-stepped.
758
759 2011-10-20 Paul Eggert <eggert@cs.ucla.edu>
760
761 Time zone name fixes for non-ASCII locales (Bug#641, Bug#9794)
762 * editfns.c: Rewrite current-time-zone so that it invokes
763 the equivalent of (format-time-string "%Z") to get the time zone name.
764 This fixes a bug when the time zone name contains characters that
765 need converting from the system time locale to Emacs internal format.
766 This fixes a shortcoming that I introduced in my 1999-10-19 patch:
767 that patch fixed format-time-string to do the conversion, but
768 I forgot to fix current-time-zone.
769 (format_time_string): New function, containing most of
770 what Fformat_time_string used to contain.
771 (Fformat_time_string): Rewrite in terms of format_time_string.
772 This doesn't change this function's behavior.
773 (current-time-zone): Rewrite to use format_time_string.
774 This fixes the bug reported by Michael Schierl in
775 <http://lists.gnu.org/archive/html/emacs-devel/2007-06/msg00334.html>.
776 Jason Rumney's 2007-06-07 change worked around this bug, but
777 didn't fix it.
778 * systime.h (tzname, timezone): Remove no-longer-used declarations.
779
780 2011-10-19 Eli Zaretskii <eliz@gnu.org>
781
782 * xdisp.c (start_display): If the character at POS is displayed
783 via a display vector, reset IT->current.dpvec_index to zero.
784 (try_window_reusing_current_matrix): If a line ends in a display
785 vector or the next line starts in a display vector, continue
786 redrawing the window even though the character position of
787 start_row was reached.
788 (Bug#9771, part 2)
789
790 2011-10-18 Chong Yidong <cyd@gnu.org>
791
792 * xdisp.c (get_next_display_element): Handle U+2010 and U+2011
793 with nobreak-char-display too.
794
795 2011-10-18 Eli Zaretskii <eliz@gnu.org>
796
797 Fix part 3 of bug#9771.
798 * bidi.c (bidi_line_init): Initialize next_en_pos to zero, not -1.
799 (bidi_resolve_neutral): Don't enter the expensive loop looking for
800 non-neutral characters if the current character is a paragraph
801 separator (a.k.a. Newline). This avoids running the same
802 expensive loop twice, once when we consume the preceding newline
803 and the other time when the line actually needs to be displayed.
804 Avoid the loop when we see neutrals on the base embedding level
805 following a character whose directionality is the same as the
806 paragraph's. This avoids running the expensive loop when a line
807 ends in a long sequence of neutrals, like control characters.
808 Add assertion against STRONG_AL type. Slightly rearrange code
809 that determines the type of a neutral given the first non-neutral
810 that follows it.
811 (bidi_level_of_next_char): Set next_en_pos to zero when
812 invalidating its info.
813
814 2011-10-17 Eli Zaretskii <eliz@gnu.org>
815
816 * xdisp.c (push_display_prop): Determine whether to record string
817 or buffer position by IT->string, not by IT->method. Allow
818 GET_FROM_DISPLAY_VECTOR as IT->method on entry. (Bug#9771, part 4)
819 (move_it_vertically_backward): Don't look for character position
820 immediately after the newline when in a continuation line.
821 (Bug#9771, part 1)
822
823 2011-10-15 Martin Rudalics <rudalics@gmx.at>
824
825 * window.c (coordinates_in_window): Rewrite and delabelize
826 vertical border check. (Bug#5357) (Bug#9618)
827
828 2011-10-14 Stefan Monnier <monnier@iro.umontreal.ca>
829
830 * xterm.c (frame_highlight, frame_unhighlight): Ignore unexplained
831 errors in XSetWindowBorder (bug#9310).
832
833 2011-10-13 Dmitry Antipov <dmantipov@yandex.ru>
834
835 * editfns.c (Fset_time_zone_rule): Replace free with xfree to
836 avoid crash when xmalloc overrun checking is enabled.
837
838 2011-10-13 Eli Zaretskii <eliz@gnu.org>
839
840 * xdisp.c (Fcurrent_bidi_paragraph_direction): Initialize
841 itb.paragraph_dir to NEUTRAL_DIR. Fixes an occasional incorrect
842 cursor motion with <left> and <right> arrow keys.
843
844 * bidi.c (bidi_init_it): Don't initialize paragraph_dir here, as
845 some callers set that themselves.
846
847 2011-10-12 Eli Zaretskii <eliz@gnu.org>
848
849 * xdisp.c (find_row_edges): Handle the case where ROW comes from a
850 display string and the previous row comes from the same string and
851 is empty. (Bug#9739) (Bug#9738)
852
853 2011-10-12 Stefan Monnier <monnier@iro.umontreal.ca>
854
855 * doc.c (get_doc_string): Encode file name (bug#9735).
856
857 2011-10-12 Eli Zaretskii <eliz@gnu.org>
858
859 * bidi.c (bidi_level_of_next_char):
860 * xdisp.c (get_visually_first_element): Remove old incorrect
861 comments regarding the Unicode Line Separator character.
862
863 * bidi.c (bidi_init_it): Initialize paragraph_dir to NEUTRAL_DIR.
864
865 2011-10-12 Dmitry Antipov <dmantipov@yandex.ru>
866
867 * alloc.c (Fgc_status): Do not access beyond zombies array
868 boundary if nzombies > MAX_ZOMBIES.
869 * alloc.c (dump_zombies): Add missing format specifier.
870
871 2011-10-12 Paul Eggert <eggert@cs.ucla.edu>
872
873 * xdisp.c (set_cursor_from_row): Simplify conditionals,
874 to pacify GCC 4.6.1 x86-64 with -O2 -Wstrict-overflow.
875
876 * lread.c (read_escape): Allow hex escapes as large as ?\xfffffff.
877 Some packages use them to denote characters with modifiers.
878
879 2011-10-11 Andreas Schwab <schwab@linux-m68k.org>
880
881 * lisp.h (GCPRO1_VAR, GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR)
882 (GCPRO5_VAR, GCPRO6_VAR, UNGCPRO_VAR): Add whitespace to avoid
883 matching a pp-number. Rename parameter var to var1.
884
885 2011-10-11 Stefan Monnier <monnier@iro.umontreal.ca>
886
887 * minibuf.c (Finternal_complete_buffer): Fix last change (bug#9709).
888
889 2011-10-08 Glenn Morris <rgm@gnu.org>
890
891 * callint.c (Fcall_interactively): Give a more explicit error for the
892 'c' case with a non-character input. (Bug#8479)
893
894 2011-10-08 Eli Zaretskii <eliz@gnu.org>
895
896 * xdisp.c (hscroll_window_tree): Support hscroll in right-to-left
897 lines.
898 (set_cursor_from_row): Fix cursor positioning in mixed L2R+R2L
899 lines that are hscrolled on the left.
900
901 * dispnew.c (buffer_posn_from_coords): Account for a possible
902 presence of header-line. (Bug#4426)
903
904 2011-10-07 Stefan Monnier <monnier@iro.umontreal.ca>
905
906 * buffer.c (syms_of_buffer) <enable-multibyte-characters>:
907 Don't advertise functionality which we discourage or doesn't work.
908
909 2011-10-07 Paul Eggert <eggert@cs.ucla.edu>
910
911 * alloc.c (GC_LISP_OBJECT_ALIGNMENT): Use offsetof, not __alignof__
912 or sizeof. __alignof__ gives the wrong answer on Fedora x86-64
913 with GCC 4.6.1 when configured with CC='gcc -m32' --with-wide-int;
914 this makes Emacs dump core during garbage collection on rare
915 occasions. sizeof is obviously inferior to offsetof here, so
916 stick with offsetof.
917 (GC_POINTER_ALIGNMENT): New macro.
918 (mark_memory): Omit 3rd (offset) arg; caller changed.
919 Don't assume EMACS_INT alignment is the same as pointer alignment.
920
921 2011-10-03 Stefan Monnier <monnier@iro.umontreal.ca>
922
923 * keyboard.c (read_key_sequence_remapped): New var.
924 (read_key_sequence): Compute remapping in the right buffer.
925 (command_loop_1): Use read_key_sequence's remapping directly.
926
927 2011-10-02 Stefan Monnier <monnier@iro.umontreal.ca>
928
929 * dired.c (file_name_completion): Don't expand file name.
930 (Ffile_name_completion, Ffile_name_all_completions): Expand file name
931 before checking file name handler.
932
933 * minibuf.c (Finternal_complete_buffer): Only show internal buffers if
934 they've been requested explicitly (bug#9591).
935
936 2011-10-01 Andreas Schwab <schwab@linux-m68k.org>
937
938 * keymap.c (Fsingle_key_description): Use make_specified_string
939 instead of build_string to build string from push_key_description.
940 (Bug#5193)
941
942 2011-09-30 Paul Eggert <eggert@cs.ucla.edu>
943
944 * buffer.h (struct buffer): Use time_t, not int, for a time stamp.
945 This fixes a Y2038 bug on 64-bit hosts.
946 * buffer.c (reset_buffer):
947 * fileio.c (Fdo_auto_save, Fset_buffer_auto_saved)
948 (Fclear_buffer_auto_save_failure):
949 Use 0, not -1, to represent an unset failure time, since time_t
950 might not be signed.
951
952 Remove dependency on glibc malloc internals.
953 * alloc.c (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
954 Move back here from lisp.h, but with their new implementations.
955 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
956 (XMALLOC_OVERRUN_SIZE_SIZE): Move these new lisp.h macros here.
957 * charset.c (charset_table_init): New static var.
958 (syms_of_charset): Use it instead of xmalloc. This removes a
959 dependency on glibc malloc internals. See Eli Zaretskii's comment in
960 <http://lists.gnu.org/archive/html/emacs-devel/2011-09/msg00815.html>.
961 * lisp.h (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
962 Move back to alloc.c.
963 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
964 (XMALLOC_OVERRUN_SIZE_SIZE): Move to alloc.c.
965
966 2011-09-30 Jan Djärv <jan.h.d@swipnet.se>
967
968 * nsterm.m (windowDidResize): Call x_set_window_size only when
969 ns_in_resize is true. Otherwise set pixelwidth/height and
970 call change_frame_size (Bug#9628).
971
972 2011-09-30 Paul Eggert <eggert@cs.ucla.edu>
973
974 Port --enable-checking=all to Fedora 14 x86-64.
975 * charset.c (syms_of_charset): Also account for glibc malloc's
976 internal overhead when calculating the initial malloc maximum.
977
978 Port --enable-checking=all to Fedora 14 x86.
979 * alloc.c (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
980 Move to lisp.h.
981 (xmalloc_put_size, xmalloc_get_size, overrun_check_malloc)
982 (overrun_check_realloc, overrun_check_free):
983 Use XMALLOC_OVERRUN_SIZE_SIZE, not sizeof (size_t).
984 That way, xmalloc returns a properly-aligned pointer even if
985 XMALLOC_OVERRUN_CHECK is defined. The old debugging code happened
986 to align OK on typical 64-bit hosts, but not on Fedora 14 x86.
987 * charset.c (syms_of_charset): Take XMALLOC_OVERRUN_CHECK_OVERHEAD
988 into account when calculating the initial malloc maximum.
989 * lisp.h (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
990 Move here from alloc.c, so that charset.c can use it too.
991 Properly align; the old code wasn't right for common 32-bit hosts
992 when configured with --enable-checking=all.
993 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
994 (XMALLOC_OVERRUN_SIZE_SIZE): New macros.
995
996 2011-09-29 Eli Zaretskii <eliz@gnu.org>
997
998 * sysdep.c (snprintf) [!EOVERFLOW]: If EOVERFLOW is not defined,
999 use EDOM.
1000
1001 2011-09-28 Eli Zaretskii <eliz@gnu.org>
1002
1003 * xdisp.c (compute_display_string_end): If there's no display
1004 string at CHARPOS, return -1.
1005
1006 * bidi.c (bidi_fetch_char): When compute_display_string_end
1007 returns a negative value, treat the character as a normal
1008 character not covered by a display string. (Bug#9624)
1009
1010 2011-09-28 Juanma Barranquero <lekktu@gmail.com>
1011
1012 * lread.c (Fread_from_string): Fix typo in docstring.
1013
1014 2011-09-27 Eli Zaretskii <eliz@gnu.org>
1015
1016 * xdisp.c (handle_invisible_prop): If invisible text ends on a
1017 newline, reseat the iterator instead of bidi-iterating there one
1018 character at a time. (Bug#9610)
1019 (BUFFER_POS_REACHED_P, move_it_in_display_line_to): Bail when past
1020 TO_CHARPOS if the bidi iterator is at base embedding level.
1021
1022 2011-09-27 Andreas Schwab <schwab@linux-m68k.org>
1023
1024 * lread.c (readevalloop): Use correct code for NBSP.
1025 (read1): Likewise. (Bug#9608)
1026
1027 2011-09-25 Michael Albinus <michael.albinus@gmx.de>
1028
1029 * dbusbind.c (Fdbus_register_signal): When service is not
1030 registered, use nil in Vdbus_registered_objects_table. (Bug#9581)
1031
1032 2011-09-25 Glenn Morris <rgm@gnu.org>
1033
1034 * buffer.c (truncate-lines): Doc fix.
1035
1036 2011-09-24 Chong Yidong <cyd@stupidchicken.com>
1037
1038 * window.c (Fwindow_prev_buffers, Fset_window_prev_buffers)
1039 (Fset_window_next_buffers): Doc fix.
1040
1041 2011-09-24 Glenn Morris <rgm@gnu.org>
1042
1043 * minibuf.c (read_minibuf): Disable line truncation. (Bug#5715)
1044
1045 2011-09-24 Paul Eggert <eggert@cs.ucla.edu>
1046
1047 Fix minor problems found by static checking.
1048 * xdisp.c (string_from_display_spec): Don't assume vecsize fits in int.
1049 * indent.c (Fvertical_motion): Fix == vs = typo.
1050
1051 2011-09-24 Eli Zaretskii <eliz@gnu.org>
1052
1053 * dispnew.c (syms_of_display) <redisplay-dont-pause>:
1054 Default value is now t. Doc fix.
1055
1056 * indent.c (Fvertical_motion): Compute and apply the overshoot
1057 logic when moving up, not only when moving down. Fix the
1058 confusing name and values of the it_overshoot_expected variable;
1059 logic changes accordingly. (Bug#9254) (Bug#9549)
1060
1061 * xdisp.c (pos_visible_p): Produce correct pixel coordinates when
1062 CHARPOS is covered by a display string which includes newlines.
1063 (move_it_vertically_backward): Avoid inflooping when START_CHARPOS
1064 is covered by a display string with embedded newlines.
1065
1066 2011-09-24 Michael Albinus <michael.albinus@gmx.de>
1067
1068 * dbusbind.c (Fdbus_register_signal): Add match rule to
1069 Vdbus_registered_objects_table. (Bug#9581)
1070 (Fdbus_register_method, Vdbus_registered_objects_table):
1071 Fix docstring.
1072
1073 2011-09-24 Jim Meyering <meyering@redhat.com>
1074
1075 do not ignore write error for any output size
1076 The previous change was incomplete.
1077 While it makes emacs --batch detect the vast majority of stdout
1078 write failures, errors were still ignored whenever the output size is
1079 k * (BUFSIZ+1) - 4. E.g., on a system with BUFSIZ of 4096,
1080 $ emacs --batch --eval '(print (format "%4093d" 0))' > /dev/full \
1081 && echo FAIL: ignored write error
1082 FAIL: ignored write error
1083 $ emacs --batch --eval '(print (format "%20481d" 0))' > /dev/full \
1084 && echo FAIL: ignored write error
1085 FAIL: ignored write error
1086 * emacs.c (Fkill_emacs): Also test ferror. (Bug#9574)
1087
1088 2011-09-23 Andreas Schwab <schwab@linux-m68k.org>
1089
1090 * emacs.c (Fkill_emacs): In noninteractive mode exit
1091 non-successfully if a write error occurred on stdout. (Bug#9574)
1092
1093 2011-09-21 Eli Zaretskii <eliz@gnu.org>
1094
1095 * xdisp.c (pop_it): Allow it->object that is a cons cell to pass
1096 the xassert test.
1097
1098 * dispextern.h (struct it): Update the comment documenting what
1099 can it->OBJECT be.
1100
1101 2011-09-20 Eli Zaretskii <eliz@gnu.org>
1102
1103 * xdisp.c (set_cursor_from_row): If the row ends in a newline from
1104 a display string, extend search for cursor position to end of row.
1105 (find_row_edges): If the row ends in a newline from a display
1106 string, increment its MATRIX_ROW_END_CHARPOS by one. (Bug#9549)
1107 Handle the case of a display string with multiple newlines.
1108 (Fcurrent_bidi_paragraph_direction): Fix search for previous
1109 non-empty line. Fixes confusing cursor motion with arrow keys at
1110 the beginning of a line that starts with whitespace.
1111
1112 2011-09-19 Lars Magne Ingebrigtsen <larsi@gnus.org>
1113
1114 * lread.c (Fread_from_string): Document what FINAL-STRING-INDEX is
1115 (bug#9493).
1116
1117 2011-09-18 Chong Yidong <cyd@stupidchicken.com>
1118
1119 * xfns.c (Fx_create_frame): Handle the bitmapIcon resource as
1120 boolean (Bug#9154).
1121
1122 2011-09-18 Eli Zaretskii <eliz@gnu.org>
1123
1124 * xdisp.c (display_line): Record maximum and minimum buffer
1125 positions even if no glyphs were produced (e.g., by a zero-width
1126 stretch). Fixes bug#9530 on a TTY. Under word-wrap, don't record
1127 buffer positions that will be removed from the glyph row because
1128 they don't fit.
1129 (produce_stretch_glyph): Fix a bug in :align-to on a TTY when the
1130 column is beyond frame width: don't subtract 1 "pixel" when
1131 computing width of the stretch.
1132 (reseat_at_next_visible_line_start): Undo the change made on
1133 2011-09-17 that saved paragraph information and restored it after
1134 the call to `reseat'. (Bug#9545)
1135
1136 2011-09-18 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
1137
1138 * xdisp.c (expose_window): Save original value of phys_cursor_on_p
1139 and turn window cursor on if cleared (Bug#9415).
1140
1141 2011-09-18 Andreas Schwab <schwab@linux-m68k.org>
1142
1143 * search.c (boyer_moore): Take unibyte characters from pattern
1144 literally. (Bug#9458)
1145
1146 2011-09-18 Eli Zaretskii <eliz@gnu.org>
1147
1148 * xdisp.c (reseat_at_next_visible_line_start): Fix last change.
1149
1150 2011-09-18 Paul Eggert <eggert@cs.ucla.edu>
1151
1152 Fix minor problem found by static checking.
1153 * xdisp.c (reseat_at_next_visible_line_start): Mark locals as
1154 initialized, to pacify gcc -Wuninitialized.
1155
1156 * fileio.c: Report proper errno when syscall falls.
1157 (Finsert_file_contents): Save and restore errno,
1158 so that report_file_error outputs the correct diagnostic.
1159 (Fwrite_region) [CLASH_DETECTION]: Likewise.
1160
1161 2011-09-18 Eli Zaretskii <eliz@gnu.org>
1162
1163 * .gdbinit (pgx): Fix references to fields of `struct glyph'.
1164
1165 2011-09-17 Eli Zaretskii <eliz@gnu.org>
1166
1167 * xdisp.c (produce_stretch_glyph): Another fix for changes made on
1168 2011-08-30T17:32:44Z!eliz@gnu.org. (Bug#9530)
1169
1170 2011-09-17 Eli Zaretskii <eliz@gnu.org>
1171
1172 * xdisp.c (reseat_at_next_visible_line_start): Keep information
1173 about the current paragraph and restore it after the call to reseat.
1174
1175 * bidi.c (MAX_PARAGRAPH_SEARCH): New macro.
1176 (bidi_find_paragraph_start): Search back for paragraph beginning
1177 at most MAX_PARAGRAPH_SEARCH lines; if not found, return BEGV_BYTE.
1178 (bidi_move_to_visually_next): Only trigger paragraph-related
1179 computations when the last character is a newline or at EOB, not
1180 just any NEUTRAL_B. (Bug#9470)
1181
1182 * xdisp.c (set_cursor_from_row): Don't invoke special treatment of
1183 truncated lines if point is covered by a display string. (Bug#9524)
1184
1185 2011-09-16 Paul Eggert <eggert@cs.ucla.edu>
1186
1187 * xselect.c: Relax test for outgoing X longs (Bug#9498).
1188 (cons_to_x_long): New function.
1189 (lisp_data_to_selection_data): Use it. Correct the test for
1190 short-versus-long data; it was negated. Break out of vector
1191 loop, for efficiency, when a long datum is discovered.
1192
1193 2011-09-16 Stefan Monnier <monnier@iro.umontreal.ca>
1194
1195 * eval.c (Fquote): Document its non-consing behavior (bug#9482).
1196
1197 2011-09-16 Eli Zaretskii <eliz@gnu.org>
1198
1199 * image.c (tiff_handler): Work around a bug in MinGW GCC 3.x (see
1200 GCC PR/17406) by declaring this function with external scope.
1201
1202 2011-09-15 Paul Eggert <eggert@cs.ucla.edu>
1203
1204 * editfns.c (Fformat): Fix bug in text-property fix (Bug#9514).
1205 Don't mishandle (length (format "%%")) and (format "%4000s%%" "").
1206
1207 2011-09-15 Andreas Schwab <schwab@linux-m68k.org>
1208
1209 * editfns.c (Fformat): Correctly handle text properties on "%%".
1210
1211 2011-09-15 Eli Zaretskii <eliz@gnu.org>
1212
1213 * xterm.c (x_draw_composite_glyph_string_foreground):
1214 * w32term.c (x_draw_composite_glyph_string_foreground):
1215 * term.c (encode_terminal_code):
1216 * composite.c (composition_update_it, get_composition_id):
1217 * xdisp.c (get_next_display_element)
1218 (fill_composite_glyph_string): Add comments about special meaning
1219 of TAB characters in a composition.
1220
1221 2011-09-15 Paul Eggert <eggert@cs.ucla.edu>
1222
1223 * editfns.c (Fformat): Fix off-by-1 bug for "%%b" (Bug#9514).
1224 This occurs when processing a multibyte format.
1225 Problem reported by Wolfgang Jenker.
1226
1227 2011-09-15 Johan Bockgård <bojohan@gnu.org>
1228
1229 * xdisp.c (try_cursor_movement): Only check for exact match if
1230 cursor hpos found by set_cursor_from_row is valid. (Bug#9495)
1231
1232 2011-09-14 Paul Eggert <eggert@cs.ucla.edu>
1233
1234 Remove unused external symbols.
1235 * dispextern.h (calc_pixel_width_or_height): Remove decl.
1236 * xdisp.c (calc_pixel_width_or_height): Now static.
1237 * doprnt.c (exprintf) [! (HAVE_X_WINDOWS && USE_X_TOOLKIT)]: Remove.
1238 * indent.c (check_display_width):
1239 * w32term.c: Fix comment to match code.
1240 * xterm.c, xterm.h (x_catching_errors): Remove.
1241
1242 2011-09-14 Paul Eggert <eggert@cs.ucla.edu>
1243
1244 * xselect.c: Use signed conversions more consistently (Bug#9498).
1245 (selection_data_to_lisp_data): Assume incoming selection data are
1246 signed integers, not unsigned. This is to be consistent with
1247 outgoing selection data, which was modified to use signed integers
1248 in as part of the fix to Bug#9196 in response to Jan D.'s comment
1249 in <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9196#32> that X11
1250 expects long, not unsigned long.
1251
1252 2011-09-14 Eli Zaretskii <eliz@gnu.org>
1253
1254 * xdisp.c (try_window_reusing_current_matrix): Fix incorrect
1255 computation of loop end. Reported by Johan Bockgård
1256 <bojohan@gnu.org>.
1257
1258 2011-09-13 Chong Yidong <cyd@stupidchicken.com>
1259
1260 * frame.c (Fother_visible_frames_p): Function deleted.
1261
1262 2011-09-12 Eli Zaretskii <eliz@gnu.org>
1263
1264 * indent.c (compute_motion): Process display vector front to back
1265 rather than the other way around. (Bug#2496)
1266
1267 2011-09-12 Stefan Monnier <monnier@iro.umontreal.ca>
1268
1269 * fileio.c (Finsert_file_contents): Don't assume beg_offset is 0.
1270
1271 2011-09-11 Chong Yidong <cyd@stupidchicken.com>
1272
1273 * minibuf.c (Fread_from_minibuffer): Doc fix.
1274
1275 2011-09-11 Eli Zaretskii <eliz@gnu.org>
1276
1277 * xdisp.c (produce_stretch_glyph): Fix a typo made in changes from
1278 2011-08-30T17:32:44Z!eliz@gnu.org. (Bug#9475)
1279
1280 2011-09-11 Lars Magne Ingebrigtsen <larsi@gnus.org>
1281
1282 * fileio.c (Fvisited_file_modtime): Document `(-1 65535)' as a
1283 value for non-existent files.
1284
1285 2011-09-11 Eli Zaretskii <eliz@gnu.org>
1286
1287 * fileio.c (Finsert_file_contents): If the file cannot be opened,
1288 set its "size" to -1. This will set the modtime_size field of
1289 the corresponding buffer to -1, which is what
1290 verify-visited-file-modtime expects for files that do not exist.
1291 (Bug#9139)
1292
1293 2011-09-11 Paul Eggert <eggert@cs.ucla.edu>
1294
1295 * keymap.h (KEY_DESCRIPTION_SIZE, push_key_description): Move decls
1296 here ...
1297 * lisp.h: ... from here. push_key_description is no longer
1298 defined in keyboard.c, so its declaration should not be in
1299 lisp.h's "Defined in keyboard.c" section, and KEY_DESCRIPTION_SIZE
1300 logically belongs with push_key_description.
1301
1302 2011-09-10 Paul Eggert <eggert@cs.ucla.edu>
1303
1304 * buffer.h: Include <sys/types.h> instead of <time.h>.
1305 Otherwise, off_t wasn't defined on FreeBSD 9.0-BETA2 i386.
1306 Problem reported by Herbert J. Skuhra.
1307
1308 2011-09-10 Lars Magne Ingebrigtsen <larsi@gnus.org>
1309
1310 * xml.c (parse_region): Make the parsing work for
1311 non-comment-starting XML files again (bug#9144).
1312
1313 2011-09-10 Andreas Schwab <schwab@linux-m68k.org>
1314
1315 * image.c (gif_load): Fix calculation of bottom and right corner.
1316 (Bug#9468)
1317
1318 2011-09-10 Eli Zaretskii <eliz@gnu.org>
1319
1320 * xdisp.c (MAX_DISP_SCAN): Decrease to 250. Prevents sluggish
1321 redisplay in small windows.
1322
1323 2011-09-09 Eli Zaretskii <eliz@gnu.org>
1324
1325 * frame.c (x_report_frame_params): Cast to avoid compiler warnings.
1326
1327 2011-09-08 Martin Rudalics <rudalics@gmx.at>
1328
1329 * window.c (Fset_window_prev_buffers, Fset_window_next_buffers):
1330 Operate on live windows only.
1331
1332 2011-09-08 Juanma Barranquero <lekktu@gmail.com>
1333
1334 * emacs.c (my_heap_start): #ifdef to avoid warnings when unused.
1335
1336 2011-09-07 Eli Zaretskii <eliz@gnu.org>
1337
1338 * xdisp.c (move_it_in_display_line_to): Call RESTORE_IT on ppos_it
1339 only under bidi iteration.
1340
1341 2011-09-07 Jan Djärv <jan.h.d@swipnet.se>
1342
1343 * gtkutil.c (xg_make_tool_item): Insert comment about eventbox.
1344
1345 2011-09-06 Paul Eggert <eggert@cs.ucla.edu>
1346
1347 isnan: Fix porting problem to Solaris 10 with bundled gcc.
1348 Without this fix, the command to link temacs failed due to an
1349 undefined symbol __builtin_isnan. This is because
1350 /usr/include/iso/math_c99.h #defines isnan(x) to
1351 __builtin_isnan(x), but the bundled gcc, which identifies itself
1352 as gcc 3.4.3 (csl-sol210-3_4-branch+sol_rpath), does not have
1353 a __builtin_isnan.
1354 * floatfns.c (isnan): #undef, and then #define to a clone of
1355 what's in data.c.
1356 (Fisnan): Always define, since it's always available now.
1357 (syms_of_floatfns): Always define isnan at the Lisp level.
1358
1359 2011-09-06 Paul Eggert <eggert@cs.ucla.edu>
1360
1361 * Makefile.in (gl-stamp): move-if-change now in build-aux (Bug#9169).
1362
1363 2011-09-06 Paul Eggert <eggert@cs.ucla.edu>
1364
1365 * fileio.c: Fix bugs with large file offsets (Bug#9428).
1366 The previous code assumed that file offsets (off_t values) fit in
1367 EMACS_INT variables, which is not true on typical 32-bit hosts.
1368 The code messed up by falsely reporting buffer overflow in cases
1369 such as (insert-file-contents "big" nil 1 2) into an empty buffer
1370 when "big" contains more than 2**29 bytes, even though this
1371 inserts just one byte and does not overflow the buffer.
1372 (Finsert_file_contents): Store file offsets as off_t
1373 values, not as EMACS_INT values. Check for overflow when
1374 converting between EMACS_INT and off_t. When checking for
1375 buffer overflow or for overlap, take the offsets into account.
1376 Don't use EMACS_INT for small values where int suffices.
1377 When checking for overlap, fix a typo: ZV was used where
1378 ZV_BYTE was intended.
1379 (Fwrite_region): Don't assume off_t fits into 'long'.
1380 * buffer.h (struct buffer.modtime_size): Now off_t, not EMACS_INT.
1381
1382 2011-09-05 Michael Albinus <michael.albinus@gmx.de>
1383
1384 * dbusbind.c (xd_signature_cat): Rename from signature_cat.
1385
1386 2011-09-04 Paul Eggert <eggert@cs.ucla.edu>
1387
1388 sprintf-related integer and memory overflow issues (Bug#9412).
1389
1390 * doprnt.c (doprnt): Support printing ptrdiff_t and intmax_t values.
1391 (esprintf, exprintf, evxprintf): New functions.
1392 * keyboard.c (command_loop_level): Now EMACS_INT, not int.
1393 (cmd_error): Kbd macro iterations count is now EMACS_INT, not int.
1394 (modify_event_symbol): Do not assume that the length of
1395 name_alist_or_stem is safe to alloca and fits in int.
1396 (Fexecute_extended_command): Likewise for function name and binding.
1397 (Frecursion_depth): Wrap around reliably on integer overflow.
1398 * keymap.c (push_key_description): First arg is now EMACS_INT, not int,
1399 since some callers pass EMACS_INT values.
1400 (Fsingle_key_description): Don't crash if symbol name contains more
1401 than MAX_ALLOCA bytes.
1402 * minibuf.c (minibuf_level): Now EMACS_INT, not int.
1403 (get_minibuffer): Arg is now EMACS_INT, not int.
1404 * lisp.h (get_minibuffer, push_key_description): Reflect API changes.
1405 (esprintf, exprintf, evxprintf): New decls.
1406 * window.h (command_loop_level, minibuf_level): Reflect API changes.
1407
1408 * dbusbind.c (signature_cat): New function.
1409 (xd_signature, Fdbus_register_signal):
1410 Do not overrun buffer; instead, report string overflow.
1411
1412 * dispnew.c (add_window_display_history): Don't overrun buffer.
1413 Truncate instead; this is OK since it's just a log.
1414
1415 * editfns.c (Fcurrent_time_zone): Don't overrun buffer
1416 even if the time zone offset is outlandishly large.
1417 Don't mishandle offset == INT_MIN.
1418
1419 * emacs.c (main) [NS_IMPL_COCOA]: Don't overrun buffer
1420 when creating daemon; the previous buffer-overflow check was incorrect.
1421
1422 * eval.c (verror): Simplify by rewriting in terms of evxprintf,
1423 which has the guts of the old verror function.
1424
1425 * filelock.c (lock_file_1, lock_file): Don't blindly alloca long name;
1426 use SAFE_ALLOCA instead. Use esprintf to avoid int-overflow issues.
1427
1428 * font.c: Include <float.h>, for DBL_MAX_10_EXP.
1429 (font_unparse_xlfd): Don't blindly alloca long strings.
1430 Don't assume XINT result fits in int, or that XFLOAT_DATA * 10
1431 fits in int, when using sprintf. Use single snprintf to count
1432 length of string rather than counting it via multiple sprintfs;
1433 that's simpler and more reliable.
1434 (font_unparse_fcname): Use it to avoid sprintf buffer overrun.
1435 (generate_otf_features) [0 && HAVE_LIBOTF]: Use esprintf, not
1436 sprintf, in case result does not fit in int.
1437
1438 * fontset.c (num_auto_fontsets): Now printmax_t, not int.
1439 (fontset_from_font): Print it.
1440
1441 * frame.c (tty_frame_count): Now printmax_t, not int.
1442 (make_terminal_frame, set_term_frame_name): Print it.
1443 (x_report_frame_params): In X, window IDs are unsigned long,
1444 not signed long, so print them as unsigned.
1445 (validate_x_resource_name): Check for implausibly long names,
1446 and don't assume name length fits in 'int'.
1447 (x_get_resource_string): Don't blindly alloca invocation name;
1448 use SAFE_ALLOCA. Use esprintf, not sprintf, in case result does
1449 not fit in int.
1450
1451 * gtkutil.c: Include <float.h>, for DBL_MAX_10_EXP.
1452 (xg_check_special_colors, xg_set_geometry):
1453 Make sprintf buffers a bit bigger, to avoid potential buffer overrun.
1454
1455 * lread.c (dir_warning): Don't blindly alloca buffer; use SAFE_ALLOCA.
1456 Use esprintf, not sprintf, in case result does not fit in int.
1457
1458 * macros.c (executing_kbd_macro_iterations): Now EMACS_INT, not int.
1459 (Fend_kbd_macro): Don't mishandle MOST_NEGATIVE_FIXNUM by treating
1460 it as a large positive number.
1461 (Fexecute_kbd_macro): Don't assume repeat count fits in int.
1462 * macros.h (executing_kbd_macro_iterations): Now EMACS_INT, not int.
1463
1464 * nsterm.m ((NSSize)windowWillResize): Use esprintf, not sprintf,
1465 in case result does not fit in int.
1466
1467 * print.c (float_to_string): Detect width overflow more reliably.
1468 (print_object): Make sprintf buffer a bit bigger, to avoid potential
1469 buffer overrun. Don't assume list length fits in 'int'. Treat
1470 print length of 0 as 0, not as infinity; to be consistent with other
1471 uses of print length in this function. Don't overflow print length
1472 index. Don't assume hash table size fits in 'long', or that
1473 vectorlike size fits in 'unsigned long'.
1474
1475 * process.c (make_process): Use printmax_t, not int, to format
1476 process-name gensyms.
1477
1478 * sysdep.c (snprintf) [! HAVE_SNPRINTF]: New function.
1479
1480 * term.c (produce_glyphless_glyph): Make sprintf buffer a bit bigger
1481 to avoid potential buffer overrun.
1482
1483 * xfaces.c (x_update_menu_appearance): Don't overrun buffer
1484 if X resource line is longer than 512 bytes.
1485
1486 * xfns.c (x_window): Make sprintf buffer a bit bigger
1487 to avoid potential buffer overrun.
1488
1489 * xterm.c (x_io_error_quitter): Don't overrun sprintf buffer.
1490
1491 * xterm.h (x_check_errors): Add ATTRIBUTE_FORMAT_PRINTF.
1492
1493 2011-09-04 Paul Eggert <eggert@cs.ucla.edu>
1494
1495 Integer overflow fixes for scrolling, etc.
1496 Without these, Emacs silently mishandles large integers sometimes.
1497 For example, "C-u 4294967297 M-x recenter" was treated as if
1498 it were "C-u 1 M-x recenter" on a typical 64-bit host.
1499
1500 * xdisp.c (try_window_id): Check Emacs fixnum range before
1501 converting to 'int'.
1502
1503 * window.c (window_scroll_line_based, Frecenter):
1504 Check that an Emacs fixnum is in range before assigning it to 'int'.
1505 (Frecenter, Fmove_to_window_line): Use EMACS_INT, not int, for
1506 values converted from Emacs fixnums.
1507 (Frecenter): Don't wrap around a line count if it is out of 'int'
1508 range; instead, treat it as an extreme value.
1509 (Fset_window_configuration, compare_window_configurations):
1510 Use ptrdiff_t, not int, for index that might exceed 2 GiB.
1511
1512 * search.c (Freplace_match): Use ptrdiff_t, not int, for indexes
1513 that can exceed INT_MAX. Check that EMACS_INT value is in range
1514 before assigning it to the (possibly-narrower) index.
1515 (match_limit): Don't assume that a fixnum can fit in 'int'.
1516
1517 * print.c (print_object): Use ptrdiff_t, not int, for index that can
1518 exceed INT_MAX.
1519
1520 * indent.c (position_indentation): Now takes ptrdiff_t, not int.
1521 (Fvertical_motion): Don't wrap around LINES values that don't fit
1522 in 'int'. Instead, treat them as extreme values. This is good
1523 enough for windows, which can't have more than INT_MAX lines anyway.
1524
1525 2011-09-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
1526
1527 * Require libxml/parser.h to avoid compilation warning.
1528
1529 * emacs.c (shut_down_emacs): Call xmlCleanupParser on shutdown.
1530
1531 * xml.c (parse_region): Don't call xmlCleanupParser after parsing,
1532 since this reportedly can destroy thread storage.
1533
1534 2011-08-30 Chong Yidong <cyd@stupidchicken.com>
1535
1536 * syntax.c (find_defun_start): Update all cache variables if
1537 exiting early (Bug#9401).
1538
1539 2011-08-30 Eli Zaretskii <eliz@gnu.org>
1540
1541 * image.c (x_bitmap_pixmap): Cast to int to avoid compiler warnings.
1542
1543 * xdisp.c (produce_stretch_glyph): No longer static, compiled also
1544 when HAVE_WINDOW_SYSTEM is not defined. Support both GUI and TTY
1545 frames. Call tty_append_glyph in the TTY case. (Bug#9402)
1546
1547 * term.c (tty_append_glyph): New function.
1548 (produce_stretch_glyph): Static function and its prototype deleted.
1549
1550 * dispextern.h (produce_stretch_glyph, tty_append_glyph):
1551 Add prototypes.
1552
1553 2011-08-29 Paul Eggert <eggert@cs.ucla.edu>
1554
1555 * image.c (parse_image_spec): Check for nonnegative, not for positive,
1556 when checking :margin (Bug#9390).
1557 (IMAGE_NON_NEGATIVE_INTEGER_VALUE_OR_PAIR):
1558 Rename from IMAGE_POSITIVE_INTEGER_VALUE_OR_PAIR,
1559 so that the name doesn't mislead. All uses changed.
1560
1561 2011-08-28 Johan Bockgård <bojohan@gnu.org>
1562
1563 * term.c (init_tty) [HAVE_GPM]: Move mouse settings after
1564 set_tty_hooks.
1565
1566 2011-08-27 Eli Zaretskii <eliz@gnu.org>
1567
1568 * xdisp.c (move_it_to): Don't bail out early when reaching
1569 position beyond to_charpos, if we are scanning backwards.
1570 (move_it_vertically_backward): When DY == 0, make sure we get to
1571 the first character in the line after the newline.
1572
1573 2011-08-27 Paul Eggert <eggert@cs.ucla.edu>
1574
1575 * ccl.c: Improve and simplify overflow checking (Bug#9196).
1576 (ccl_driver): Do not generate an out-of-range pointer.
1577 (Fccl_execute_on_string): Remove unnecessary check for
1578 integer overflow, noted by Stefan Monnier in
1579 <http://lists.gnu.org/archive/html/emacs-devel/2011-08/msg00979.html>.
1580 Remove a FIXME that didn't need fixing.
1581 Simplify the newly-introduced buffer reallocation code.
1582
1583 2011-08-27 Juanma Barranquero <lekktu@gmail.com>
1584
1585 * makefile.w32-in ($(BLD)/alloc.$(O)): Depend on lib/verify.h.
1586
1587 2011-08-26 Paul Eggert <eggert@cs.ucla.edu>
1588
1589 Integer and memory overflow issues (Bug#9196).
1590
1591 * doc.c (get_doc_string): Rework so that
1592 get_doc_string_buffer_size is the actual buffer size, rather than
1593 being 1 less than the actual buffer size; this makes xpalloc more
1594 convenient.
1595
1596 * image.c (x_allocate_bitmap_record, cache_image):
1597 * xselect.c (Fx_register_dnd_atom):
1598 Simplify previous changes by using xpalloc.
1599
1600 * buffer.c (overlay_str_len): Now ptrdiff_t, not EMACS_INT,
1601 since either will do and ptrdiff_t is convenient with xpalloc.
1602
1603 * charset.c (charset_table_size)
1604 (struct charset_sort_data.priority): Now ptrdiff_t.
1605 (charset_compare): Don't overflow if priorities differ greatly.
1606 (Fsort_charsets): Don't assume list length fits in int.
1607 Check for size-calculation overflow when allocating sort data.
1608 (syms_of_charset): Allocate an initial charset table that is
1609 just under 64 KiB, to avoid problems with glibc malloc and mmap.
1610
1611 * cmds.c (internal_self_insert): Check for size-calculation overflow.
1612
1613 * composite.h (struct composition.glyph_len): Now int, not unsigned.
1614 The actual value is always <= INT_MAX, and leaving it unsigned made
1615 overflow checking harder.
1616
1617 * dispextern.h (struct glyph_matrix.rows_allocated)
1618 (struct face_cache.size): Now ptrdiff_t, for convenience in use
1619 with xpalloc. The values are still always <= INT_MAX.
1620
1621 * indent.c (compute_motion): Adjust to region_cache_forward sig change.
1622
1623 * lisp.h (xnmalloc, xnrealloc, xpalloc): New decls.
1624 (SAFE_NALLOCA): New macro.
1625
1626 * region-cache.c (struct boundary.pos, find_cache_boundary)
1627 (move_cache_gap, insert_cache_boundary, delete_cache_boundaries)
1628 (set_cache_region, invalidate_region_cache)
1629 (revalidate_region_cache, know_region_cache, region_cache_forward)
1630 (region_cache_backward, pp_cache):
1631 Use ptrdiff_t, not EMACS_INT, since either will do. This is needed
1632 so that ptrdiff_t * can be passed to xpalloc.
1633 (struct region_cache): Similarly, for gap_start, gap_len, cache_len,
1634 beg_unchanged, end_unchanged, buffer_beg, buffer_end members.
1635 (pp_cache): Don't assume cache_len fits in int.
1636 * region-cache.h: Adjust extern decls to match.
1637
1638 * search.c (scan_buffer, Freplace_match): Use ptrdiff_t, not
1639 EMACS_INT, since either will do, for xpalloc.
1640
1641 * alloc.c: Include verify.h, and check that int fits in ptrdiff_t.
1642 (xnmalloc, xnrealloc, xpalloc): New functions.
1643
1644 * bidi.c (bidi_shelve_header_size): New constant.
1645 (bidi_cache_ensure_space, bidi_shelve_cache): Use it.
1646 (bidi_cache_ensure_space): Avoid integer overflow when allocating.
1647
1648 * bidi.c (bidi_cache_shrink):
1649 * buffer.c (overlays_at, overlays_in, record_overlay_string)
1650 (overlay_strings):
1651 Don't update size of array until after memory allocation succeeds,
1652 because xmalloc/xrealloc may not return.
1653 (struct sortstrlist.bytes): Now ptrdiff_t, as EMACS_INT doesn't help
1654 now that we have proper integer overflow checking.
1655 (record_overlay_string, overlay_strings): Catch overflows when
1656 calculating size of overlay_str_buf.
1657
1658 * callproc.c (Fcall_process): Check for size overflow when
1659 calculating size of args2.
1660 (child_setup): Avoid overflow by using size_t rather than ptrdiff_t.
1661 Normally we prefer signed values, but sticking with ptrdiff_t would
1662 require adding more-complicated checks.
1663
1664 * ccl.c (Fccl_execute_on_string): Check for memory overflow.
1665 Use ptrdiff_t rather than EMACS_INT where ptrdiff_t will do.
1666 Redo buffer-overflow calculations to avoid integer overflow.
1667 Add a FIXME comment where memory seems to be over-allocated.
1668
1669 * character.c (Fstring): Check for size-calculation overflow.
1670
1671 * coding.c (produce_chars): Redo buffer-overflow calculations to avoid
1672 unnecessary integer overflow. Check for size overflow.
1673 (encode_coding_object): Don't update size until xmalloc succeeds.
1674
1675 * composite.c (get_composition_id): Check for overflow in glyph
1676 length calculations.
1677
1678 Integer and memory overflow fixes for display code.
1679 * dispextern.h (struct glyph_pool.nglyphs): Now ptrdiff_t, not int.
1680 * dispnew.c (adjust_glyph_matrix, realloc_glyph_pool)
1681 (scrolling_window): Check for overflow in size calculations.
1682 (line_draw_cost, realloc_glyph_pool, add_row_entry):
1683 Don't assume glyph table len fits in int.
1684 (struct row_entry.bucket, row_entry_pool_size, row_entry_idx)
1685 (row_table_size): Now ptrdiff_t, not int.
1686 (scrolling_window): Avoid overflow in size calculations.
1687 Don't update size until allocation succeeds.
1688 * fns.c (concat): Check for overflow in size calculations.
1689 (next_almost_prime): Verify NEXT_ALMOST_PRIME_LIMIT.
1690 * lisp.h (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): New macros.
1691 (NEXT_ALMOST_PRIME_LIMIT): New constant.
1692
1693 * doc.c (get_doc_string_buffer_size): Now ptrdiff_t, not int.
1694 (get_doc_string): Check for size calculation overflow.
1695 Don't update size until allocation succeeds.
1696 (get_doc_string, Fsubstitute_command_keys): Use ptrdiff_t, not
1697 EMACS_INT, where ptrdiff_t will do.
1698 (Fsubstitute_command_keys): Check for string overflow.
1699
1700 * editfns.c (set_time_zone_rule): Don't assume environment length
1701 fits in int.
1702 (message_length): Now ptrdiff_t, not int.
1703 (Fmessage_box): Don't update size until allocation succeeds.
1704 Don't assume message length fits in int.
1705 (Fformat): Use ptrdiff_t, not EMACS_INT, where ptrdiff_t will do.
1706
1707 * emacs.c (main): Do not reallocate argv, since there is a null at
1708 the end that can be overwritten, and this way there's no need to
1709 worry about size-calculation overflow.
1710 (sort_args): Check for size-calculation overflow.
1711
1712 * eval.c (init_eval_once, grow_specpdl): Don't update size until
1713 alloc succeeds.
1714 (call_debugger, grow_specpdl): Redo calculations to avoid overflow.
1715
1716 * frame.c (set_menu_bar_lines, x_set_frame_parameters)
1717 (x_set_scroll_bar_width, x_figure_window_size):
1718 Check for integer overflow.
1719 (x_set_alpha): Do not assume XINT fits in int.
1720
1721 * frame.h (struct frame): Use int, not EMACS_INT, where int works.
1722 This is for the members text_lines, text_cols, total_lines, total_cols,
1723 where the system imposes an 'int' limit.
1724
1725 * fringe.c (Fdefine_fringe_bitmap):
1726 Don't update size until alloc works.
1727
1728 * ftfont.c (ftfont_get_open_type_spec, setup_otf_gstring)
1729 (ftfont_shape_by_flt): Check for integer overflow in size calculations.
1730
1731 * gtkutil.c (get_utf8_string, xg_store_widget_in_map):
1732 Check for size-calculation overflow.
1733 (get_utf8_string): Use ptrdiff_t, not size_t, where either will
1734 do, as we prefer signed integers.
1735 (id_to_widget.max_size, id_to_widget.used)
1736 (xg_store_widget_in_map, xg_remove_widget_from_map)
1737 (xg_get_widget_from_map, xg_get_scroll_id_for_window)
1738 (xg_remove_scroll_bar, xg_update_scrollbar_pos):
1739 Use and return ptrdiff_t, not int.
1740 (xg_gtk_scroll_destroy): Don't assume ptrdiff_t fits in int.
1741 * gtkutil.h: Change prototypes to match the above.
1742
1743 * image.c (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): Remove; these
1744 are duplicate now that they've been promoted to lisp.h.
1745 (x_allocate_bitmap_record, x_alloc_image_color)
1746 (make_image_cache, cache_image, xpm_load):
1747 Don't update size until alloc is done.
1748 (xpm_load, lookup_rgb_color, lookup_pixel_color, x_to_xcolors)
1749 (x_detect_edges):
1750 Check for size calculation overflow.
1751 (ct_colors_allocated_max): New constant.
1752 (x_to_xcolors, x_detect_edges): Reorder multiplicands to avoid
1753 overflow.
1754
1755 * keyboard.c (read_char, menu_bar_items, tool_bar_items)
1756 (read_char_x_menu_prompt, read_char_minibuf_menu_width)
1757 (read_char_minibuf_menu_prompt, follow_key, read_key_sequence):
1758 Use ptrdiff_t, not int, to count maps.
1759 (read_char_minibuf_menu_prompt): Check for overflow in size
1760 calculations. Don't update size until allocation succeeds.
1761 Redo calculations to avoid overflow.
1762 * keyboard.h: Change prototypes to match the above.
1763
1764 * keymap.c (cmm_size, current_minor_maps): Use ptrdiff_t, not int,
1765 to count maps.
1766 (current_minor_maps): Check for size calculation overflow.
1767 * keymap.h: Change prototypes to match the above.
1768
1769 * lread.c (read1, init_obarray): Don't update size until alloc done.
1770
1771 * macros.c (Fstart_kbd_macro): Don't update size until alloc done.
1772 (store_kbd_macro_char): Reorder multiplicands to avoid overflow.
1773
1774 * nsterm.h (struct ns_color_table.size, struct ns_color_table.avail):
1775 Now ptrdiff_t, not int.
1776 * nsterm.m (ns_index_color): Use ptrdiff_t, not int, for table indexes.
1777 (ns_draw_fringe_bitmap): Rewrite to avoid overflow.
1778
1779 * process.c (Fnetwork_interface_list): Check for overflow
1780 in size calculation.
1781
1782 * region-cache.c (move_cache_gap): Check for size calculation overflow.
1783
1784 * scroll.c (do_line_insertion_deletion_costs): Check for size calc
1785 overflow. Don't bother calling xmalloc when xrealloc will do.
1786
1787 * search.c (Freplace_match): Check for size calculation overflow.
1788 (Fset_match_data): Don't assume list lengths fit in 'int'.
1789
1790 * sysdep.c (system_process_attributes): Use ptrdiff_t, not int,
1791 for command line length. Do not attempt to address one before the
1792 beginning of an array, as that's not portable.
1793
1794 * term.c (max_frame_lines): Remove; unused.
1795 (encode_terminal_src_size, encode_terminal_dst_size): Now ptrdiff_t,
1796 not int.
1797 (encode_terminal_code, calculate_costs): Check for size
1798 calculation overflow.
1799 (encode_terminal_code): Use ptrdiff_t, not int, to record glyph
1800 table lengths and related sizes. Don't update size until alloc
1801 done. Redo calculations to avoid overflow.
1802 (calculate_costs): Don't bother calling xmalloc when xrealloc will do.
1803
1804 * termcap.c (tgetent): Use ptrdiff_t, not int, to record results of
1805 subtracting pointers.
1806 (gobble_line): Check for overflow more carefully. Don't update size
1807 until alloc done.
1808
1809 * tparam.c (tparam1): Use ptrdiff_t, not int, for sizes.
1810 Don't update size until alloc done.
1811 Redo size calculations to avoid overflow.
1812 Check for size calculation overflow.
1813 (main) [DEBUG]: Fix typo in invoking tparam1.
1814
1815 * xdisp.c (store_mode_line_noprop_char, x_consider_frame_title):
1816 Use ptrdiff_t, not int, for sizes.
1817 (store_mode_line_noprop_char): Don't update size until alloc done.
1818
1819 * xfaces.c (lface_id_to_name_size, Finternal_make_lisp_face):
1820 Use ptrdiff_t, not int, for sizes.
1821 (Finternal_make_lisp_face, cache_face):
1822 Check for size calculation overflow.
1823 (cache_face): Treat size calculation overflows as if they were
1824 memory exhaustion (the usual treatment), rather than aborting.
1825
1826 * xfns.c (x_encode_text, x_set_name_internal)
1827 (Fx_change_window_property): Use ptrdiff_t, not int, to count
1828 sizes, since they can exceed INT_MAX in size. Check for size
1829 calculation overflow.
1830
1831 * xgselect.c (gfds_size): Now ptrdiff_t, for convenience with xpalloc.
1832 (xg_select): Check for size calculation overflow.
1833 Don't update size until alloc done.
1834
1835 * xrdb.c (get_environ_db): Don't assume path length fits in int,
1836 as sprintf is limited to int lengths.
1837
1838 * xselect.c (X_LONG_SIZE, X_SHRT_MAX, X_SHRT_MIN, X_LONG_MAX)
1839 (X_LONG_MIN): New macros.
1840 Use them to make the following changes clearer.
1841 (MAX_SELECTION_QUANTUM): Make the other bounds on this value clearer.
1842 This change doesn't affect the value now, but it may help remind
1843 future maintainers not to raise the value too much later.
1844 (SELECTION_QUANTUM): Remove, replacing with ...
1845 (selection_quantum): ... new function, which avoids overflow.
1846 All uses changed.
1847 (struct selection_data.size): Now ptrdiff_t, not int, to avoid
1848 assumption that selection length fits in 'int'.
1849 (x_reply_selection_request, x_handle_selection_request)
1850 (x_get_window_property, receive_incremental_selection)
1851 (x_get_window_property_as_lisp_data, selection_data_to_lisp_data)
1852 (lisp_data_to_selection_data, clean_local_selection_data):
1853 Use ptrdiff_t, not int, to record length of selection.
1854 (x_reply_selection_request, x_get_window_property)
1855 (receive_incremental_selection, x_property_data_to_lisp):
1856 Redo calculations to avoid overflow.
1857 (x_reply_selection_request): When sending hint, ceiling it at
1858 X_LONG_MAX rather than relying on wraparound overflow to send
1859 something.
1860 (x_get_window_property, receive_incremental_selection)
1861 (lisp_data_to_selection_data, x_property_data_to_lisp):
1862 Check for size-calculation overflow.
1863 (x_get_window_property, receive_incremental_selection)
1864 (lisp_data_to_selection_data, Fx_register_dnd_atom):
1865 Don't store size until memory allocation succeeds.
1866 (x_get_window_property): Plug memory leak on memory exhaustion.
1867 Don't double-block input; malloc is safe here. Don't assume 2**34
1868 - 4 fits in unsigned long. Add an xassert to check
1869 XGetWindowProperty overflow. Be more careful about overflow
1870 calculations, and distinguish size from memory overflow better.
1871 (receive_incremental_selection): When tracing, don't assume
1872 unsigned int is less than INT_MAX.
1873 (x_selection_data_to_lisp_data): Remove unnecessary (and in theory
1874 harmful) conversions of unsigned short to int.
1875 (lisp_data_to_selection_data): Don't assume that integers
1876 in the range -65535 through -1 fit in an X unsigned short.
1877 Don't assume that ULONG_MAX == X_ULONG_MAX. Don't store into
1878 result parameters unless successful. Rely on cons_to_unsigned
1879 to report problems with elements; the old code wasn't right anyway.
1880 (x_check_property_data): Check for int overflow; we cannot use
1881 a wider type due to X limits.
1882 (x_handle_dnd_message): Use unsigned int, to avoid int overflow.
1883
1884 * xsmfns.c (smc_save_yourself_CB): Check for size calc overflow.
1885
1886 * xterm.c (x_color_cells, x_send_scrollbar_event, handle_one_xevent)
1887 (x_term_init): Check for size calculation overflow.
1888 (x_color_cells): Don't store size until memory allocation succeeds.
1889 (handle_one_xevent): Use ptrdiff_t, not int, for byte counts.
1890 Don't assume alloca size is less than MAX_ALLOCA.
1891 (x_term_init): Don't assume length fits in int (sprintf is limited
1892 to int size).
1893
1894 Use ptrdiff_t for composition IDs.
1895 * character.c (lisp_string_width):
1896 * composite.c (composition_table_size, n_compositions)
1897 (get_composition_id, composition_gstring_from_id):
1898 * dispextern.h (struct glyph_string.cmp_id, struct composition_it.id):
1899 * xdisp.c (BUILD_COMPOSITE_GLYPH_STRING):
1900 * window.c (Frecenter):
1901 Use ptrdiff_t, not int, for composition IDs.
1902 * composite.c (get_composition_id): Check for integer overflow.
1903 * composite.h: Adjust prototypes to match the above changes.
1904
1905 Use ptrdiff_t for hash table indexes.
1906 * category.c (hash_get_category_set):
1907 * ccl.c (ccl_driver):
1908 * charset.h (struct charset.hash_index, CHECK_CHARSET_GET_ID):
1909 * coding.c (coding_system_charset_list, detect_coding_system):
1910 * coding.h (struct coding_system.id):
1911 * composite.c (get_composition_id, gstring_lookup_cache):
1912 * fns.c (hash_lookup, hash_put, Fgethash, Fputhash):
1913 * image.c (xpm_get_color_table_h):
1914 * lisp.h (hash_lookup, hash_put):
1915 * minibuf.c (Ftest_completion):
1916 Use ptrdiff_t for hash table indexes, not int (which is too
1917 narrow, on 64-bit hosts) or EMACS_INT (which is too wide, on
1918 32-bit --with-wide-int hosts).
1919
1920 * charset.c (Fdefine_charset_internal): Check for integer overflow.
1921 Add a FIXME comment about memory leaks.
1922 (syms_of_charset): Don't assume xmalloc returns.
1923
1924 Don't assume that stated character widths fit in int.
1925 * character.c (Fchar_width, c_string_width, lisp_string_width):
1926 * character.h (CHAR_WIDTH):
1927 * indent.c (MULTIBYTE_BYTES_WIDTH):
1928 Use sanitize_char_width to avoid undefined and/or bad behavior
1929 with outlandish widths.
1930 * character.h (sanitize_tab_width): Rename from sanitize_width,
1931 now that we have two such functions. All uses changed.
1932 (sanitize_char_width): New inline function.
1933
1934 Don't assume that tab-width fits in int.
1935 * character.h (sanitize_width): New inline function.
1936 (SANE_TAB_WIDTH): New macro.
1937 (ASCII_CHAR_WIDTH): Use it.
1938 * indent.c (sane_tab_width): Remove. All uses replaced by
1939 SANE_TAB_WIDTH (current_buffer).
1940 * xdisp.c (init_iterator): Use SANE_TAB_WIDTH.
1941
1942 * fileio.c: Integer overflow issues with file modes.
1943 (Fset_file_modes, auto_save_1): Don't assume EMACS_INT fits in int.
1944
1945 * charset.c (read_hex): New arg OVERFLOW. All uses changed.
1946 Remove unreachable code.
1947 (read_hex, load_charset_map_from_file): Check for integer overflow.
1948
1949 * xterm.c: don't go over XClientMessageEvent limit
1950 (scroll_bar_windows_size): Now ptrdiff_t, as we prefer signed.
1951 (x_send_scroll_bar_event): Likewise. Check that the size does not
1952 exceed limits imposed by XClientMessageEvent, as well as the usual
1953 ptrdiff_t and size_t limits.
1954
1955 * keyboard.c: Overflow, signedness and related fixes.
1956 (make_lispy_movement): Use same integer type in forward decl
1957 that is used in the definition.
1958 (read_key_sequence, keyremap_step):
1959 Change bufsize argument back to int, undoing my 2011-03-30 change.
1960 We prefer signed types, and int is wide enough here.
1961 (parse_tool_bar_item): Don't assume tool_bar_max_label_size is less
1962 than TYPE_MAXIMUM (EMACS_INT) / 2. Don't let the label size grow
1963 larger than STRING_BYTES_BOUND. Use ptrdiff_t for Emacs string
1964 length, not size_t. Use ptrdiff_t for index, not int.
1965 (keyremap_step, read_key_sequence): Redo bufsize check to avoid
1966 possibility of integer overflow.
1967
1968 Overflow, signedness and related fixes for images.
1969
1970 * dispextern.h (struct it.stack[0].u.image.image_id)
1971 (struct_it.image_id, struct image.id, struct image_cache.size)
1972 (struct image_cache.used, struct image_cache.ref_count):
1973 * gtkutil.c (update_frame_tool_bar):
1974 * image.c (x_reference_bitmap, Fimage_size, Fimage_mask_p)
1975 (Fimage_metadata, free_image_cache, clear_image_cache, lookup_image)
1976 (cache_image, mark_image_cache, x_kill_gs_process, Flookup_image):
1977 * nsmenu.m (update_frame_tool_bar):
1978 * xdisp.c (calc_pixel_width_or_height):
1979 * xfns.c (image_cache_refcount):
1980 Image IDs are now ptrdiff_t, not int, to avoid arbitrary limits
1981 on typical 64-bit hosts.
1982
1983 * image.c (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): New macros.
1984 (x_bitmap_pixmap, x_create_x_image_and_pixmap):
1985 Omit unnecessary casts to int.
1986 (parse_image_spec): Check that integers fall into 'int' range
1987 when the callers expect that.
1988 (image_ascent): Redo ascent calculation to avoid int overflow.
1989 (clear_image_cache): Avoid overflow when sqrt (INT_MAX) < nimages.
1990 (lookup_image): Remove unnecessary tests.
1991 (xbm_image_p): Locals are now of int, not EMACS_INT,
1992 since parse_image_check makes sure they fit into int.
1993 (png_load, gif_load, svg_load_image):
1994 Prefer int to unsigned where either will do.
1995 (tiff_handler): New function, combining the cores of the
1996 old tiff_error_handler and tiff_warning_handler.
1997 This function is rewritten to use vsnprintf and thereby avoid
1998 stack buffer overflows. It uses only the features of vsnprintf
1999 that are common to both POSIX and native Microsoft.
2000 (tiff_error_handler, tiff_warning_handler): Use it.
2001 (tiff_load, gif_load, imagemagick_load_image):
2002 Don't assume :index value fits in 'int'.
2003 (gif_load): Omit unnecessary cast to double, and avoid double-rounding.
2004 (imagemagick_load_image): Check that crop parameters fit into
2005 the integer types that MagickCropImage accepts. Don't assume
2006 Vimagemagick_render_type has a nonnegative value. Don't assume
2007 size_t fits in 'long'.
2008 (gs_load): Use printmax_t to print the widest integers possible.
2009 Check for integer overflow when computing image height and width.
2010
2011 2011-08-26 Eli Zaretskii <eliz@gnu.org>
2012
2013 * xdisp.c (redisplay_window): Don't force window start if point
2014 will be invisible in the resulting window. (Bug#9324)
2015
2016 2011-08-25 Eli Zaretskii <eliz@gnu.org>
2017
2018 * xdisp.c (compute_display_string_pos): Return 2 in DISP_PROP when
2019 the display spec is of the form `(space ...)'.
2020 (handle_display_spec): Return the value returned by
2021 handle_single_display_spec, not just 1 or zero.
2022 (handle_single_display_spec): If the display spec is of the form
2023 `(space ...)', and specifies display in the text area, return 2
2024 rather than 1.
2025 (try_cursor_movement): Check for the need to scroll more
2026 accurately, and prefer exact match for point under bidi.
2027 Don't advance `row' beyond the last row of the window.
2028
2029 * dispextern.h (struct bidi_it): Rename the disp_prop_p member
2030 into disp_prop; all users changed.
2031
2032 * bidi.c (bidi_fetch_char): If compute_display_string_pos returns
2033 DISP_PROP = 2, substitute the u+2029 PARAGRAPH SEPARATOR character
2034 for the text covered by the display property.
2035
2036 2011-08-25 Chong Yidong <cyd@stupidchicken.com>
2037
2038 * buffer.c (Fbury_buffer_internal): Rename from Funrecord_buffer.
2039 Change return value to nil.
2040 (Frecord_buffer): Delete unused function.
2041
2042 2011-08-24 Eli Zaretskii <eliz@gnu.org>
2043
2044 * xdisp.c (Fcurrent_bidi_paragraph_direction): For unibyte
2045 buffers, return left-to-right.
2046 (set_cursor_from_row): Consider candidate row a win if its glyph
2047 represents a newline and point is on that newline. Fixes cursor
2048 positioning on the newline at EOL of R2L text within L2R
2049 paragraph, and vice versa.
2050 (try_cursor_movement): Check continued rows, in addition to
2051 continuation rows. Fixes unwarranted scroll when point enters a
2052 continued line of R2L text within an L2R paragraph, or vice versa.
2053 (cursor_row_p): Consider the case of point being equal to
2054 MATRIX_ROW_END_CHARPOS. Prevents cursor being stuck when moving
2055 from the end of a short line to the beginning of a continued line
2056 of R2L text within L2R paragraph.
2057 (RECORD_MAX_MIN_POS): For max_pos, use IT_CHARPOS even for
2058 composed characters.
2059
2060 * bidi.c (bidi_check_type): Use xassert.
2061 (bidi_cache_iterator_state): Update the disp_pos and disp_prop_p
2062 members.
2063
2064 2011-08-23 Eli Zaretskii <eliz@gnu.org>
2065
2066 * bidi.c (bidi_get_type): Abort if we get zero as the bidi type of
2067 a character.
2068
2069 2011-08-23 Chong Yidong <cyd@stupidchicken.com>
2070
2071 * nsfont.m (ns_otf_to_script): Fix typo.
2072
2073 2011-08-22 Kenichi Handa <handa@m17n.org>
2074
2075 * chartab.c (Fset_char_table_extra_slot): Do not inhibit setting a
2076 extra slot even if the purpose is char-code-property-table.
2077
2078 2011-08-23 Eli Zaretskii <eliz@gnu.org>
2079
2080 * xdisp.c (redisplay_window): When computing centering_position,
2081 account for the height of the header line. (Bug#8874)
2082
2083 * dispnew.c (buffer_posn_from_coords): Use buf_charpos_to_bytepos
2084 instead of CHAR_TO_BYTE. Fixes a crash when a completion
2085 candidate is selected by the mouse, and that candidate has a
2086 composed character under the mouse.
2087
2088 * xdisp.c (x_produce_glyphs): Set it->nglyphs to 1. Fixes pixel
2089 coordinates reported by pos-visible-in-window-p for a composed
2090 character in column zero.
2091
2092 2011-08-23 Stefan Monnier <monnier@iro.umontreal.ca>
2093
2094 * cmds.c (Fself_insert_command): Mention post-self-insert-hook.
2095
2096 2011-08-22 Eli Zaretskii <eliz@gnu.org>
2097
2098 * xdisp.c (BUFFER_POS_REACHED_P): If this is a composition,
2099 consider it a hit if to_charpos is anywhere in the range of the
2100 composed buffer positions.
2101
2102 2011-08-22 Chong Yidong <cyd@stupidchicken.com>
2103
2104 * image.c (gif_load): Don't assume that each subimage has the same
2105 dimensions as the base image. Handle disposal method that is
2106 "undefined" by the gif spec (Bug#9335).
2107
2108 2011-08-20 Chong Yidong <cyd@stupidchicken.com>
2109
2110 * eval.c (Fsignal): Handle `debug' symbol in error handler (Bug#9329).
2111 (Fcondition_case): Document `debug' symbol in error handler.
2112
2113 2011-08-19 Eli Zaretskii <eliz@gnu.org>
2114
2115 * xfaces.c (face_at_buffer_position): Avoid repeated evaluation of
2116 face ID by FACE_FROM_ID, and avoid a crash when mouse is moved
2117 from an Org mode buffer to a Speedbar frame.
2118
2119 * xdisp.c (RECORD_MAX_MIN_POS): If the display element comes from
2120 a composition, take its buffer position from IT->cmp_it.charpos.
2121 Fixes cursor positioning at the beginning of a line that begins
2122 with a composed character.
2123
2124 2011-08-18 Eli Zaretskii <eliz@gnu.org>
2125
2126 * bidi.c (bidi_get_type): If bidi_type_table reports zero as the
2127 character bidirectional type, use STRONG_L instead. Fixes crashes
2128 in a buffer produced by `describe-categories'.
2129
2130 * dispextern.h (struct bidi_it): Move disp_pos and disp_prop_p
2131 members before the level stack, so they would be saved and
2132 restored when copying iterator state. Fixes incorrect reordering
2133 around TABs covered by display properties.
2134
2135 2011-08-18 Andreas Schwab <schwab@linux-m68k.org>
2136
2137 * process.c (Fnetwork_interface_list): Correctly determine buffer size.
2138
2139 2011-08-17 Chong Yidong <cyd@stupidchicken.com>
2140
2141 * eval.c (internal_condition_case, internal_condition_case_1)
2142 (internal_condition_case_2, internal_condition_case_n):
2143 Remove unnecessary aborts (Bug#9081).
2144
2145 2011-08-17 Eli Zaretskii <eliz@gnu.org>
2146
2147 * lread.c (Fload) [DOS_NT]: If `openp' returns -2, but the file
2148 has no `load' handler, try opening the file locally. (Bug#9311)
2149
2150 2011-08-16 Ken Brown <kbrown@cornell.edu>
2151
2152 * gmalloc.c: Expand comment.
2153
2154 2011-08-16 Eli Zaretskii <eliz@gnu.org>
2155
2156 * xdisp.c (set_cursor_from_row): Don't accept a previous candidate
2157 if it fails the cursor_row_p test. Fixes cursor positioning at ZV.
2158
2159 2011-08-16 Ken Brown <kbrown@cornell.edu>
2160
2161 Fix memory allocation problems in Cygwin build (Bug#9273).
2162
2163 * unexcw.c ( __malloc_initialized): Declare external variable.
2164 (fixup_executable): Force the dumped emacs to reinitialize malloc.
2165
2166 * gmalloc.c [CYGWIN] (bss_sbrk_heapbase, bss_sbrk_heapinfo):
2167 New variables.
2168 (malloc_initialize_1) [CYGWIN]: Prepare for reinitializing the
2169 dumped emacs.
2170 (_free_internal_nolock) [CYGWIN]: Ignore requests to free storage
2171 in the static heap.
2172 [CYGWIN] (special_realloc): New function.
2173 (_realloc_internal_nolock) [CYGWIN]: Use the new function on
2174 requests to realloc storage in the static heap.
2175
2176 2011-08-15 Paul Eggert <eggert@cs.ucla.edu>
2177
2178 * bidi.c (bidi_initialize): Remove unused local.
2179
2180 2011-08-15 Eli Zaretskii <eliz@gnu.org>
2181
2182 * bidimirror.h:
2183 * biditype.h: Remove file.
2184 * makefile.w32-in ($(BLD)/bidi.$(O)):
2185 * deps.mk (bidi.o): Remove biditype.h and bidimirror.h.
2186
2187 * dispextern.h: Fix a typo in the comment to bidi_type_t.
2188
2189 * chartab.c: Improve commentary for the uniprop_table API.
2190
2191 * bidi.c (bidi_paragraph_init): Support zero value of
2192 bidi_ignore_explicit_marks_for_paragraph_level.
2193 (bidi_initialize): Use uniprop_table instead of including
2194 biditype.h and bidimirror.h.
2195
2196 * xdisp.c (move_it_in_display_line_to): Don't reset pixel
2197 coordinates of the iterator when restoring from ppos_it.
2198 (Bug#9296)
2199
2200 2011-08-14 Kenichi Handa <handa@m17n.org>
2201
2202 * process.c (create_process): Call setup_process_coding_systems
2203 after the pid of the process is set to -1 (Bug#8162).
2204
2205 2011-08-14 Eli Zaretskii <eliz@gnu.org>
2206
2207 * xdisp.c (move_it_in_display_line_to): Don't invoke
2208 IT_RESET_X_ASCENT_DESCENT when iterator position was restored from
2209 ppos_it. Fixes vertical cursor motion when line beginning is
2210 covered by an image. (Bug#9296)
2211
2212 2011-08-14 Jan Djärv <jan.h.d@swipnet.se>
2213
2214 * nsterm.h (ns_run_ascript): Declare.
2215 (NSAPP_DATA2_RUNASSCRIPT): Define.
2216
2217 * nsfns.m (as_script, as_result, as_status): New static variables.
2218 (ns_run_ascript): New function.
2219 (Fns_do_applescript): Set variables as_*. Make an NSApplicationDefined
2220 event with data2 set to NSAPP_DATA2_RUNASSCRIPT, post it and then start
2221 the event loop. Get status from as_status (Bug#7276).
2222
2223 * nsterm.m (sendEvent): If event is NSApplicationDefined and
2224 data2 is NSAPP_DATA2_RUNASSCRIPT, call ns_run_ascript and then exit
2225 the event loop (Bug#7276).
2226
2227 2011-08-14 Andreas Schwab <schwab@linux-m68k.org>
2228
2229 * gnutls.c (QCgnutls_bootprop_priority)
2230 (QCgnutls_bootprop_trustfiles, QCgnutls_bootprop_keylist)
2231 (QCgnutls_bootprop_crlfiles, QCgnutls_bootprop_callbacks)
2232 (QCgnutls_bootprop_loglevel, QCgnutls_bootprop_hostname)
2233 (QCgnutls_bootprop_min_prime_bits, QCgnutls_bootprop_verify_flags)
2234 (QCgnutls_bootprop_verify_hostname_error)
2235 (QCgnutls_bootprop_callbacks_verify): Rename from
2236 Qgnutls_bootprop_..., all uses changed.
2237
2238 * xfaces.c (QCignore_defface): Rename from Qignore_defface, all
2239 uses changed.
2240
2241 2011-08-14 Paul Eggert <eggert@cs.ucla.edu>
2242
2243 * xfaces.c (Qframe_set_background_mode): Now static.
2244 * dispextern.h (Qframe_set_background_mode): Remove decl.
2245
2246 * process.c (Fnetwork_interface_info): Declare local only if needed.
2247
2248 2011-08-13 Jan Djärv <jan.h.d@swipnet.se>
2249
2250 * process.c: Include ifaddrs.h and net/if_dl.h if available (Bug#8477).
2251 (Fnetwork_interface_list): Allocate in increments of bytes instead
2252 of sizeof (struct ifreq). Iterate over ifconf.ifc_req by counting
2253 bytes (Bug#8477). Count bytes correctly when ifr_addr is a struct
2254 sockaddr.
2255 (struct ifflag_def): notrailers is smart on OSX.
2256 (Fnetwork_interface_info): Handle case when ifr_flags is negative.
2257 Get hardware address with getifaddrs if available.
2258
2259 2011-08-12 Eli Zaretskii <eliz@gnu.org>
2260
2261 * xdisp.c (iterate_out_of_display_property): xassert that
2262 IT->position is set to within IT->object's boundaries. Break from
2263 the loop as soon as EOB is reached; avoids infloops in redisplay
2264 when IT->position is set up wrongly due to some bug.
2265 Set IT->current to match the bidi iterator unconditionally.
2266 (push_display_prop): Allow GET_FROM_STRING as IT->method on
2267 entry. Force push_it to save on the stack the current
2268 buffer/string position, to be restored by pop_it. Fix flags in
2269 the iterator structure wrt the object coming from a display
2270 property, as `line-prefix' and `wrap-prefix' are not ``replacing''
2271 properties. (Bug#9284)
2272
2273 2011-08-09 Andreas Schwab <schwab@linux-m68k.org>
2274
2275 * fontset.c (fontset_get_font_group): Add proper type checks.
2276 (Bug#9172)
2277
2278 2011-08-09 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
2279
2280 * unexmacosx.c (print_load_command_name): Add cases LC_FUNCTION_STARTS
2281 and LC_VERSION_MIN_MACOSX.
2282 (copy_linkedit_data) [LC_FUNCTION_STARTS]: New function.
2283 (dump_it) [LC_FUNCTION_STARTS]: Use it.
2284
2285 2011-08-08 Eli Zaretskii <eliz@gnu.org>
2286
2287 * xdisp.c (forward_to_next_line_start): Allow to use the
2288 no-display-properties-and-no-overlays under bidi display.
2289 Set disp_pos in the bidi iterator to avoid searches for display
2290 properties and overlays.
2291
2292 2011-08-08 Chong Yidong <cyd@stupidchicken.com>
2293
2294 * editfns.c (Fset_time_zone_rule): Document relationship with the
2295 setenv function.
2296
2297 * ftfont.c (ftfont_pattern_entity): Copy the extras argument to
2298 the font entity extracted from the cache (Bug#8109).
2299
2300 2011-08-07 Chong Yidong <cyd@stupidchicken.com>
2301
2302 * composite.c (autocmp_chars): Don't reset point. That is done by
2303 restore_point_unwind (Bug#5984).
2304
2305 2011-08-07 Juri Linkov <juri@jurta.org>
2306
2307 * editfns.c (Fformat_time_string): Doc fix, add tag `usage:'
2308 to show the arg `TIME' instead of `TIMEVAL'.
2309
2310 2011-08-06 Eli Zaretskii <eliz@gnu.org>
2311
2312 * xdisp.c (set_cursor_from_row): Fix cursor positioning when a
2313 display property strides EOL and includes a newline, as in
2314 longlines-mode. (Bug#9254)
2315 (move_it_in_display_line_to): Fix vertical-motion in a buffer with
2316 word-wrap under bidirectional display. (Bug#9224)
2317
2318 * bidi.c (bidi_unshelve_cache): Don't reset the cache if JUST_FREE
2319 is non-zero, even if the data buffer is NULL. Fixes a crash in
2320 vertical-motion with longlines-mode. (Bug#9254)
2321
2322 2011-08-05 Eli Zaretskii <eliz@gnu.org>
2323
2324 * bidi.c <bidi_cache_total_alloc>: Now static.
2325 (bidi_initialize): Initialize bidi_cache_total_alloc.
2326
2327 * xdisp.c (display_line): Release buffer allocated for shelved bidi
2328 cache. (Bug#9221)
2329
2330 * bidi.c (bidi_shelve_cache, bidi_unshelve_cache): Track total
2331 amount allocated this far in `bidi_cache_total_alloc'.
2332 (bidi_unshelve_cache): Accept an additional argument JUST_FREE; if
2333 non-zero, only free the data buffer without restoring the cache
2334 contents. All callers changed.
2335
2336 * dispextern.h (bidi_unshelve_cache): Update prototype.
2337
2338 * xdisp.c (SAVE_IT, pos_visible_p, move_it_in_display_line_to)
2339 (move_it_in_display_line, move_it_to)
2340 (move_it_vertically_backward, move_it_by_lines): Replace the call
2341 to xfree to an equivalent call to bidi_unshelve_cache.
2342 (move_it_in_display_line_to): Fix logic of returning
2343 MOVE_POS_MATCH_OR_ZV in the bidi case. (Bug#9224)
2344
2345 2011-08-05 Eli Zaretskii <eliz@gnu.org>
2346
2347 * xdisp.c (set_cursor_from_row): Prefer the candidate glyph that
2348 came from a string character with a `cursor' property. (Bug#9229)
2349
2350 2011-08-04 Jan Djärv <jan.h.d@swipnet.se>
2351
2352 * Makefile.in (LIB_PTHREAD): New variable.
2353 (LIBES): Add LIB_PTHREAD (Bug#9216).
2354
2355 * alloc.c, emacs.c, gmalloc.c, gtkutil.c, keyboard.c, syssignal.h:
2356 Rename HAVE_GTK_AND_PTHREAD to HAVE_PTHREAD (Bug#9216).
2357
2358 2011-08-04 Andreas Schwab <schwab@linux-m68k.org>
2359
2360 * regex.c (re_iswctype): Remove some redundant boolean conversions.
2361
2362 2011-08-04 Jan Djärv <jan.h.d@swipnet.se>
2363
2364 * xterm.c (x_find_topmost_parent): New function.
2365 (x_set_frame_alpha): Find topmost parent window with
2366 x_find_topmost_parent and set the property there also (bug#9181).
2367 (handle_one_xevent): Call x_set_frame_alpha on ReparentNotify.
2368
2369 2011-08-04 Paul Eggert <eggert@cs.ucla.edu>
2370
2371 * callproc.c (Fcall_process): Avoid vfork clobbering
2372 the local vars buffer, coding_systems, current_dir.
2373
2374 2011-08-03 Stefan Monnier <monnier@iro.umontreal.ca>
2375
2376 * keymap.c (Fmake_composed_keymap): Move to subr.el.
2377
2378 2011-08-03 Paul Eggert <eggert@cs.ucla.edu>
2379
2380 * fontset.c (dump_fontset) [FONTSET_DEBUG]: Declare EXTERNALLY_VISIBLE
2381 so that it is not optimized away.
2382
2383 * xdisp.c (compute_display_string_pos): Remove unused local.
2384
2385 2011-08-02 Eli Zaretskii <eliz@gnu.org>
2386
2387 Fix slow cursor motion and scrolling in large buffers with
2388 selective display, like Org Mode buffers. (Bug#9218)
2389
2390 * dispextern.h (struct bidi_it): New member disp_prop_p.
2391
2392 * xdisp.c: Remove one-slot cache of display string positions.
2393 (compute_display_string_pos): Accept an additional argument
2394 DISP_PROP_P; callers changed. Scan at most 5K characters forward
2395 for a display string or property. If found, set DISP_PROP_P
2396 non-zero.
2397
2398 * bidi.c (bidi_fetch_char): Accept an additional argument
2399 DISP_PROP_P, and pass it to compute_display_string_pos.
2400 Only handle text covered by a display string if DISP_PROP_P is returned
2401 non-zero. All callers of bidi_fetch_char changed.
2402
2403 2011-08-02 Stefan Monnier <monnier@iro.umontreal.ca>
2404
2405 * keymap.c (Fdefine_key): Fix Lisp_Object/int mixup; apply some CSE.
2406
2407 2010-12-03 Don March <don@ohspite.net>
2408
2409 * keymap.c (Fdefine_key): Fix non-prefix key error message when
2410 last character M-[char] is translated to ESC [char] (bug#7541).
2411
2412 2011-08-02 Kenichi Handa <handa@m17n.org>
2413
2414 * lisp.h (uniprop_table): Extern it.
2415
2416 * chartab.c (uniprop_table): Make it non-static.
2417
2418 2011-08-01 Eli Zaretskii <eliz@gnu.org>
2419
2420 * xdisp.c (forward_to_next_line_start): Accept additional argument
2421 BIDI_IT_PREV, and store into it the state of the bidi iterator had
2422 on the newline.
2423 (reseat_at_next_visible_line_start): Use the bidi iterator state
2424 returned by forward_to_next_line_start to restore the state of
2425 it->bidi_it after backing up to previous newline. (Bug#9212)
2426
2427 2011-07-30 Andreas Schwab <schwab@linux-m68k.org>
2428
2429 * regex.c (re_comp): Protoize.
2430 (re_exec): Fix return type.
2431 (regexec): Fix type of `ret'. (Bug#9203)
2432
2433 2011-07-28 Paul Eggert <eggert@cs.ucla.edu>
2434
2435 * image.c (check_image_size): Use 1024x1024 if unknown frame (Bug#9189).
2436 This is needed if max-image-size is a floating-point number.
2437
2438 2011-07-28 Andreas Schwab <schwab@linux-m68k.org>
2439
2440 * print.c (print_object): Print empty symbol as ##.
2441
2442 * lread.c (read1): Read ## as empty symbol.
2443
2444 2011-07-28 Alp Aker <alp.tekin.aker@gmail.com>
2445
2446 * nsfns.m (x_set_foreground_color): Set f->foreground_pixel when
2447 setting frame foreground color (Bug#9175).
2448 (x_set_background_color): Likewise.
2449
2450 * nsmenu.m (-setText): Size tooltip dimensions precisely to
2451 contents (Bug#9176).
2452 (EmacsTooltip -init): Remove bezels and add shadows to
2453 tooltip windows.
2454
2455 * nsterm.m (ns_dumpglyphs_stretch): Avoid overwriting left fringe
2456 or scroll bar (Bug#8470).
2457
2458 * nsfont.m (nsfont_open): Remove assignment to voffset and
2459 unnecessary vars hshink, expand, hd, full_height, min_height.
2460 (nsfont_draw): Use s->ybase as baseline for glyph drawing (Bug#8913).
2461
2462 * nsterm.h (nsfont_info): Remove voffset field.
2463
2464 2011-07-28 Alp Aker <alp.tekin.aker@gmail.com>
2465
2466 Implement strike-through and overline on NextStep (Bug#8863).
2467
2468 * nsfont.m (nsfont_open): Use underline position provided by font,
2469 instead of hard-coded value of 2.
2470 (nsfont_draw): Call ns_draw_text_decoration instead.
2471
2472 * nsterm.h: Add declaration for ns_draw_text_decoration.
2473
2474 * nsterm.m (ns_draw_text_decoration): New function for drawing
2475 underline, overline, and strike-through.
2476 (ns_dumpglyphs_image, ns_dumpglyphs_stretch): Add call to
2477 ns_draw_text_decoration. Change treatment of cursor drawing to
2478 accommodate underlining, etc.
2479
2480 2011-07-28 Eli Zaretskii <eliz@gnu.org>
2481
2482 * buffer.c (init_buffer_once): Set bidi-display-reordering to t by
2483 default.
2484
2485 2011-07-28 Paul Eggert <eggert@cs.ucla.edu>
2486
2487 * alloc.c (memory_full) [!SYNC_INPUT]: Fix signal-related race.
2488 Without this fix, if a signal arrives just after memory fills up,
2489 'malloc' might be invoked reentrantly.
2490
2491 * image.c (x_check_image_size) [!HAVE_X_WINDOWS]: Return 1.
2492 In other words, assume that every image size is allowed, on non-X
2493 hosts. This assumption is probably wrong, but it lets Emacs compile.
2494
2495 2011-07-28 Andreas Schwab <schwab@linux-m68k.org>
2496
2497 * regex.c (re_iswctype): Convert return values to boolean.
2498
2499 2011-07-28 Eli Zaretskii <eliz@fencepost.gnu.org>
2500
2501 * xdisp.c (compute_display_string_pos): Don't use cached display
2502 string position if the buffer had its restriction changed.
2503 (Bug#9184)
2504
2505 2011-07-28 Paul Eggert <eggert@cs.ucla.edu>
2506
2507 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
2508
2509 2011-07-28 Paul Eggert <eggert@cs.ucla.edu>
2510
2511 Integer signedness and overflow and related fixes. (Bug#9079)
2512
2513 * bidi.c: Integer size and overflow fixes.
2514 (bidi_cache_size, bidi_cache_idx, bidi_cache_last_idx)
2515 (bidi_cache_start, bidi_cache_fetch_state, bidi_cache_search)
2516 (bidi_cache_find_level_change, bidi_cache_ensure_space)
2517 (bidi_cache_iterator_state, bidi_cache_find, bidi_cache_start_stack)
2518 (bidi_find_other_level_edge):
2519 Use ptrdiff_t instead of EMACS_INT where either will do.
2520 This works better on 32-bit hosts configured --with-wide-int.
2521 (bidi_cache_ensure_space): Check for size-calculation overflow.
2522 Use % rather than repeated addition, for better worst-case speed.
2523 Don't set bidi_cache_size until after xrealloc returns, because it
2524 might not return.
2525 (bidi_dump_cached_states): Use ptrdiff_t, not int, to avoid overflow.
2526 (bidi_cache_ensure_space): Also check that the bidi cache size
2527 does not exceed that of the largest Lisp string or buffer. See Eli
2528 Zaretskii in <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9079#29>.
2529
2530 * alloc.c (__malloc_size_t): Remove.
2531 All uses replaced by size_t. See Andreas Schwab's note
2532 <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9079#8>.
2533
2534 * image.c: Improve checking for integer overflow.
2535 (check_image_size): Assume that f is nonnull, since
2536 it is always nonnull in practice. This is one less thing to
2537 worry about when checking for integer overflow later.
2538 (x_check_image_size): New function, which checks for integer
2539 overflow issues inside X.
2540 (x_create_x_image_and_pixmap, xbm_read_bitmap_data): Use it.
2541 This removes the need for a memory_full check.
2542 (xbm_image_p): Rewrite to avoid integer multiplication overflow.
2543 (Create_Pixmap_From_Bitmap_Data, xbm_load): Use x_check_image_size.
2544 (xbm_read_bitmap_data): Change locals back to 'int', since
2545 their values must fit in 'int'.
2546 (xpm_load_image, png_load, tiff_load):
2547 Invoke x_create_x_image_and_pixmap earlier,
2548 to avoid much needless work if the image is too large.
2549 (tiff_load): Treat overly large images as if
2550 x_create_x_image_and_pixmap failed, not as malloc failures.
2551 (gs_load): Use x_check_image_size.
2552
2553 * gtkutil.c: Omit integer casts.
2554 (xg_get_pixbuf_from_pixmap): Remove unnecessary cast.
2555 (xg_set_toolkit_scroll_bar_thumb): Rewrite to avoid need for cast.
2556
2557 * image.c (png_load): Don't assume height * row_bytes fits in 'int'.
2558
2559 * xfaces.c (Fbitmap_spec_p): Fix integer overflow bug.
2560 Without this fix, (bitmap-spec-p '(34359738368 1 "x"))
2561 would wrongly return t on a 64-bit host.
2562
2563 * dispnew.c (init_display): Use *_RANGE_OVERFLOW macros.
2564 The plain *_OVERFLOW macros run afoul of GCC bug 49705
2565 <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=49705>
2566 and therefore cause GCC to emit a bogus diagnostic in some cases.
2567
2568 * image.c: Integer signedness and overflow and related fixes.
2569 This is not an exhaustive set of fixes, but it's time to
2570 record what I've got.
2571 (lookup_pixel_color, check_image_size): Remove redundant decls.
2572 (check_image_size): Don't assume that arbitrary EMACS_INT values
2573 fit in 'int', or that arbitrary 'double' values fit in 'int'.
2574 (x_alloc_image_color, x_create_x_image_and_pixmap, png_load)
2575 (tiff_load, imagemagick_load_image):
2576 Check for overflow in size calculations.
2577 (x_create_x_image_and_pixmap): Remove unnecessary test for
2578 xmalloc returning NULL; that can't happen.
2579 (xbm_read_bitmap_data): Don't assume sizes fit into 'int'.
2580 (xpm_color_bucket): Use better integer hashing function.
2581 (xpm_cache_color): Don't possibly over-allocate memory.
2582 (struct png_memory_storage, tiff_memory_source, tiff_seek_in_memory)
2583 (gif_memory_source):
2584 Use ptrdiff_t, not int or size_t, to record sizes.
2585 (png_load): Don't assume values greater than 2**31 fit in 'int'.
2586 (our_stdio_fill_input_buffer): Prefer ptrdiff_t to size_t when
2587 either works, as we prefer signed integers.
2588 (tiff_read_from_memory, tiff_write_from_memory):
2589 Return tsize_t, not size_t, since that's what the TIFF API wants.
2590 (tiff_read_from_memory): Don't fail simply because the read would
2591 go past EOF; instead, return a short read.
2592 (tiff_load): Omit no-longer-needed casts.
2593 (Fimagemagick_types): Don't assume size fits into 'int'.
2594
2595 Improve hashing quality when configured --with-wide-int.
2596 * fns.c (hash_string): New function, taken from sxhash_string.
2597 Do not discard information about ASCII character case; this
2598 discarding is no longer needed.
2599 (sxhash-string): Use it. Change sig to match it. Caller changed.
2600 * lisp.h: Declare it.
2601 * lread.c (hash_string): Remove, since we now use fns.c's version.
2602 The fns.c version returns a wider integer if --with-wide-int is
2603 specified, so this should help the quality of the hashing a bit.
2604
2605 * emacs.c: Integer overflow minor fix.
2606 (heap_bss_diff): Now uprintmax_t, not unsigned long. All used changed.
2607 Define only if GNU_LINUX.
2608 (main, Fdump_emacs): Set and use heap_bss_diff only if GNU_LINUX.
2609
2610 * dispnew.c: Integer signedness and overflow fixes.
2611 Remove unnecessary forward decls, that were a maintenance hassle.
2612 (history_tick): Now uprintmax_t, so it's more likely to avoid overflow.
2613 All uses changed.
2614 (adjust_glyph_matrix, realloc_glyph_pool, adjust_frame_message_buffer)
2615 (scrolling_window): Use ptrdiff_t, not int, for byte count.
2616 (prepare_desired_row, line_draw_cost):
2617 Use int, not unsigned, where either works.
2618 (save_current_matrix, restore_current_matrix):
2619 Use ptrdiff_t, not size_t, where either works.
2620 (init_display): Check for overflow more accurately, and without
2621 relying on undefined behavior.
2622
2623 * editfns.c (pWIDE, pWIDElen, signed_wide, unsigned_wide):
2624 Remove, replacing with the new symbols in lisp.h. All uses changed.
2625 * fileio.c (make_temp_name):
2626 * filelock.c (lock_file_1, lock_file):
2627 * xdisp.c (message_dolog):
2628 Don't assume PRIdMAX etc. works; this isn't portable to pre-C99 hosts.
2629 Use pMd etc. instead.
2630 * lisp.h (printmax_t, uprintmax_t, pMd, pMu): New types and macros,
2631 replacing the pWIDE etc. symbols removed from editfns.c.
2632
2633 * keyboard.h (num_input_events): Now uintmax_t.
2634 This is (very slightly) less likely to mess up due to wraparound.
2635 All uses changed.
2636
2637 * buffer.c: Integer signedness fixes.
2638 (alloc_buffer_text, enlarge_buffer_text):
2639 Use ptrdiff_t rather than size_t when either will do, as we prefer
2640 signed integers.
2641
2642 * alloc.c: Integer signedness and overflow fixes.
2643 Do not impose an arbitrary 32-bit limit on malloc sizes when debugging.
2644 (__malloc_size_t): Default to size_t, not to int.
2645 (pure_size, pure_bytes_used_before_overflow, stack_copy_size)
2646 (Fgarbage_collect, mark_object_loop_halt, mark_object):
2647 Prefer ptrdiff_t to size_t when either would do, as we prefer
2648 signed integers.
2649 (XMALLOC_OVERRUN_CHECK_OVERHEAD): New macro.
2650 (xmalloc_overrun_check_header, xmalloc_overrun_check_trailer):
2651 Now const. Initialize with values that are in range even if char
2652 is signed.
2653 (XMALLOC_PUT_SIZE, XMALLOC_GET_SIZE): Remove, replacing with ...
2654 (xmalloc_put_size, xmalloc_get_size): New functions. All uses changed.
2655 These functions do the right thing with sizes > 2**32.
2656 (check_depth): Now ptrdiff_t, not int.
2657 (overrun_check_malloc, overrun_check_realloc, overrun_check_free):
2658 Adjust to new way of storing sizes. Check for size overflow bugs
2659 in rest of code.
2660 (STRING_BYTES_MAX): Adjust to new overheads. The old code was
2661 slightly wrong anyway, as it missed one instance of
2662 XMALLOC_OVERRUN_CHECK_OVERHEAD.
2663 (refill_memory_reserve): Omit needless cast to size_t.
2664 (mark_object_loop_halt): Mark as externally visible.
2665
2666 * xselect.c: Integer signedness and overflow fixes.
2667 (Fx_register_dnd_atom, x_handle_dnd_message):
2668 Use ptrdiff_t, not size_t, since we prefer signed.
2669 (Fx_register_dnd_atom): Check for ptrdiff_t (and size_t) overflow.
2670 * xterm.h (struct x_display_info): Use ptrdiff_t, not size_t, for
2671 x_dnd_atoms_size and x_dnd_atoms_length.
2672
2673 * doprnt.c: Prefer signed to unsigned when either works.
2674 * eval.c (verror):
2675 * doprnt.c (doprnt):
2676 * lisp.h (doprnt):
2677 * xdisp.c (vmessage):
2678 Use ptrdiff_t, not size_t, when using or implementing doprnt,
2679 since the sizes cannot exceed ptrdiff_t bounds anyway, and we
2680 prefer signed arithmetic to avoid comparison confusion.
2681 * doprnt.c (doprnt): Avoid a "+ 1" that can't overflow,
2682 but is a bit tricky.
2683
2684 Assume freestanding C89 headers, string.h, stdlib.h.
2685 * data.c, doprnt.c, floatfns.c, print.c:
2686 Include float.h unconditionally.
2687 * gmalloc.c: Assume C89-at-least behavior for preprocessor,
2688 limits.h, stddef.h, string.h. Use memset instead of 'flood'.
2689 * regex.c: Likewise for stddef.h, string.h.
2690 (ISASCII): Remove; can assume it returns 1 now. All uses removed.
2691 * s/aix4-2.h (HAVE_STRING_H): Remove obsolete undef.
2692 * s/ms-w32.h (HAVE_LIMITS_H, HAVE_STRING_H, HAVE_STDLIB_H)
2693 (STDC_HEADERS): Remove obsolete defines.
2694 * sysdep.c: Include limits.h unconditionally.
2695
2696 Assume support for memcmp, memcpy, memmove, memset.
2697 * lisp.h, sysdep.c (memcmp, memcpy, memmove, memset):
2698 * regex.c (memcmp, memcpy):
2699 Remove; we assume C89 now.
2700
2701 * gmalloc.c (memcpy, memset, memmove): Remove; we assume C89 now.
2702 (__malloc_safe_bcopy): Remove; no longer needed.
2703
2704 * lisp.h (struct vectorlike_header, struct Lisp_Subr): Signed sizes.
2705 Use EMACS_INT, not EMACS_UINT, for sizes. The code works equally
2706 well either way, and we prefer signed to unsigned.
2707
2708 2011-07-27 Lars Magne Ingebrigtsen <larsi@gnus.org>
2709
2710 * gnutls.c (emacs_gnutls_read): Don't message anything if the peer
2711 closes the connection while we're reading (bug#9182).
2712
2713 2011-07-25 Jan Djärv <jan.h.d@swipnet.se>
2714
2715 * nsmenu.m (ns_popup_dialog): Add an "ok" button if no buttons
2716 are specified (Bug#9168).
2717
2718 2011-07-25 Paul Eggert <eggert@cs.ucla.edu>
2719
2720 * bidi.c (bidi_dump_cached_states): Fix printf format mismatch.
2721 Found by GCC static checking and --with-wide-int on a 32-bit host.
2722
2723 2011-07-25 Eli Zaretskii <eliz@gnu.org>
2724
2725 * xdisp.c (compute_display_string_pos): Fix logic of caching
2726 previous display string position. Initialize cached_prev_pos to
2727 -1. Fixes slow-down at the beginning of a buffer.
2728
2729 2011-07-24 Eli Zaretskii <eliz@gnu.org>
2730
2731 * xfaces.c (check_lface_attrs) [HAVE_WINDOW_SYSTEM]: Allow `nil'
2732 for attrs[LFACE_FONTSET_INDEX].
2733
2734 2011-07-23 Paul Eggert <eggert@cs.ucla.edu>
2735
2736 * xml.c (parse_region): Remove unused local
2737 that was recently introduced.
2738
2739 2011-07-23 Eli Zaretskii <eliz@gnu.org>
2740
2741 * xfns.c (unwind_create_frame) [GLYPH_DEBUG]: Adapt to changes in
2742 2008-02-22T17:42:09Z!monnier@iro.umontreal.ca.
2743
2744 * xdisp.c (move_it_in_display_line_to): Record the best matching
2745 position for TO_CHARPOS while scanning the line, and restore it on
2746 exit if none of the characters scanned was an exact match.
2747 Fixes vertical-motion and pos-visible-in-window-p under bidi redisplay
2748 when exact match is impossible due to invisible text, and the
2749 lines are truncated.
2750
2751 2011-07-23 Jan Djärv <jan.h.d@swipnet.se>
2752
2753 * nsterm.m (initFrameFromEmacs): Set NSTitledWindowMask in styleMask
2754 for OSX >= 10.7.
2755
2756 2011-07-22 Eli Zaretskii <eliz@gnu.org>
2757
2758 Fix a significant slow-down of cursor motion with C-n, C-p,
2759 C-f/C-b, and C-v/M-v that couldn't keep up with keyboard
2760 auto-repeat under bidi redisplay in fontified buffers.
2761 * xdisp.c (compute_stop_pos_backwards): New function.
2762 (next_element_from_buffer): Call compute_stop_pos_backwards to
2763 find a suitable prev_stop when we find ourselves before
2764 base_level_stop.
2765 (reseat): Don't look for prev_stop, as that could mean a very long
2766 run.
2767 <cached_disp_pos, cached_disp_buffer, cached_disp_modiff>
2768 <cached_disp_overlay_modiff>: Cache for last found display string
2769 position.
2770 (compute_display_string_pos): Return the cached position if asked
2771 about the same buffer in the same area of character positions, and
2772 the buffer wasn't changed since the time the display string
2773 position was cached.
2774
2775 2011-07-22 Eli Zaretskii <eliz@gnu.org>
2776
2777 * xdisp.c (rows_from_pos_range): Don't ignore glyphs whose object
2778 is an integer, which is important for empty lines. (Bug#9149)
2779
2780 2011-07-22 Chong Yidong <cyd@stupidchicken.com>
2781
2782 * frame.c (Fmodify_frame_parameters): In tty case, update the
2783 default face if necessary (Bug#4238).
2784
2785 2011-07-21 Chong Yidong <cyd@stupidchicken.com>
2786
2787 * editfns.c (Fstring_to_char): No need to explain what a character
2788 is in the docstring (Bug#6576).
2789
2790 2011-07-20 Lars Magne Ingebrigtsen <larsi@gnus.org>
2791
2792 * xml.c (parse_region): Make sure we always return a tree.
2793
2794 2011-07-20 HAMANO Kiyoto <khiker.mail@gmail.com>
2795
2796 * xml.c (parse_region): If a document contains only comments,
2797 return that, too.
2798
2799 2011-07-20 Lars Magne Ingebrigtsen <larsi@gnus.org>
2800
2801 * xml.c (make_dom): Return comments, too.
2802
2803 2011-07-19 Paul Eggert <eggert@cs.ucla.edu>
2804
2805 Port to OpenBSD.
2806 See http://lists.gnu.org/archive/html/emacs-devel/2011-07/msg00688.html
2807 and the surrounding thread.
2808 * minibuf.c (read_minibuf_noninteractive): Rewrite to use getchar
2809 rather than fgets, and retry after EINTR. Otherwise, 'emacs
2810 --batch -f byte-compile-file' fails on OpenBSD if an inactivity
2811 timer goes off.
2812 * s/openbsd.h (BROKEN_SIGIO): Define.
2813 * unexelf.c (unexec) [__OpenBSD__]:
2814 Don't update the .mdebug section of the Alpha COFF symbol table.
2815
2816 2011-07-19 Lars Magne Ingebrigtsen <larsi@gnus.org>
2817
2818 * lread.c (syms_of_lread): Clarify when `lexical-binding' is used
2819 (bug#8460).
2820
2821 2011-07-18 Paul Eggert <eggert@cs.ucla.edu>
2822
2823 * fileio.c (Fcopy_file) [!MSDOS]: Tighten created file's mask.
2824 This fixes some race conditions on the permissions of any newly
2825 created file.
2826
2827 * alloc.c (valid_pointer_p): Use pipe, not open.
2828 This fixes some permissions issues when debugging.
2829
2830 * fileio.c (Fcopy_file): Adjust mode if fchown fails. (Bug#9002)
2831 If fchown fails to set both uid and gid, try to set just gid,
2832 as that is sometimes allowed. Adjust the file's mode to eliminate
2833 setuid or setgid bits that are inappropriate if fchown fails.
2834
2835 2011-07-18 Stefan Monnier <monnier@iro.umontreal.ca>
2836
2837 * xdisp.c (next_element_from_string, next_element_from_buffer): Use EQ
2838 to compare Lisp_Objects.
2839 * gnutls.c (syms_of_gnutls): Rename Vgnutls_log_level to
2840 global_gnutls_log_level, don't mistake it for a Lisp_Object.
2841 (init_gnutls_functions, emacs_gnutls_handle_error): Fix up uses.
2842
2843 2011-07-17 Andreas Schwab <schwab@linux-m68k.org>
2844
2845 * lread.c (read_integer): Unread even EOF character.
2846 (read1): Likewise. Properly record start position of symbol.
2847
2848 * lread.c (read1): Read `#:' as empty uninterned symbol if no
2849 symbol character follows.
2850
2851 2011-07-17 Paul Eggert <eggert@cs.ucla.edu>
2852
2853 * fileio.c (Fcopy_file): Pacify gcc re fchown. (Bug#9002)
2854 This works around a problem with the previous change to Fcopy_file.
2855 Recent glibc declares fchown with __attribute__((warn_unused_result)),
2856 and without this change, GCC might complain about discarding
2857 fchown's return value.
2858
2859 2011-07-16 Juanma Barranquero <lekktu@gmail.com>
2860
2861 * makefile.w32-in (GLOBAL_SOURCES): Add gnutls.c (followup to bug#9059).
2862
2863 2011-07-16 Paul Eggert <eggert@cs.ucla.edu>
2864
2865 * fileio.c (Fcopy_file): Don't diagnose fchown failures. (Bug#9002)
2866
2867 2011-07-16 Lars Magne Ingebrigtsen <larsi@gnus.org>
2868
2869 * gnutls.c (syms_of_gnutls): Define `gnutls-log-level' here, since
2870 it's used from the C level.
2871
2872 * process.c: Use the same condition for POLL_FOR_INPUT in both
2873 keyboard.c and process.c (bug#1858).
2874
2875 2011-07-09 Lawrence Mitchell <wence@gmx.li>
2876
2877 * gnutls.c (Qgnutls_bootprop_min_prime_bits): New variable.
2878 (Fgnutls_boot): Use it.
2879
2880 2011-07-15 Andreas Schwab <schwab@linux-m68k.org>
2881
2882 * doc.c (Fsubstitute_command_keys): Revert last change.
2883
2884 2011-07-15 Lars Magne Ingebrigtsen <larsi@gnus.org>
2885
2886 * doc.c (Fsubstitute_command_keys): Clarify that \= really only
2887 quotes the next character, and doesn't affect other longer
2888 sequences (bug#8935).
2889
2890 * lread.c (syms_of_lread): Clarify that is isn't only
2891 `eval-buffer' and `eval-defun' that's affected by
2892 `lexical-binding' (bug#8460).
2893
2894 2011-07-15 Eli Zaretskii <eliz@gnu.org>
2895
2896 * xdisp.c (move_it_in_display_line_to): Fix vertical motion with
2897 bidi redisplay when a line includes both an image and is truncated.
2898
2899 2011-07-14 Paul Eggert <eggert@cs.ucla.edu>
2900
2901 Fix minor problems found by static checking.
2902 * bidi.c (bidi_cache_size): Now EMACS_INT, not size_t.
2903 (elsz): Now a signed constant, not a size_t var. We prefer signed
2904 types to unsigned, to avoid integer comparison confusion. Without
2905 this change, GCC 4.6.1 with -Wunsafe-loop-optimizations complains
2906 "cannot optimize loop, the loop counter may overflow", a symptom
2907 of the confusion.
2908 * indent.c (Fvertical_motion): Mark locals as initialized.
2909 * xdisp.c (reseat_to_string): Fix pointer signedness issue.
2910
2911 2011-07-14 Lars Magne Ingebrigtsen <larsi@gnus.org>
2912
2913 * search.c (Fre_search_backward): Mention `case-fold-search' in
2914 all the re_search_* functions (bug#8138).
2915
2916 * keyboard.c (Fopen_dribble_file): Document when the file is
2917 closed (bug#8056).
2918
2919 2011-07-14 Eli Zaretskii <eliz@gnu.org>
2920
2921 * bidi.c (bidi_dump_cached_states): Fix format of displaying
2922 bidi_cache_idx.
2923
2924 Support bidi reordering of display and overlay strings.
2925 * xdisp.c (compute_display_string_pos)
2926 (compute_display_string_end): Accept additional argument STRING.
2927 (init_iterator, reseat_1): Initialize bidi_it->string.s to NULL.
2928 (reseat_to_string): Initialize bidi_it->string.s and
2929 bidi_it->string.schars.
2930 (Fcurrent_bidi_paragraph_direction): Initialize itb.string.s to
2931 NULL (avoids a crash in bidi_paragraph_init).
2932 Initialize itb.string.lstring.
2933 (init_iterator): Call bidi_init_it only of a valid
2934 buffer position was specified. Initialize paragraph_embedding to
2935 L2R.
2936 (reseat_to_string): Initialize the bidi iterator.
2937 (display_string): If we need to ignore text properties of
2938 LISP_STRING, set IT->stop_charpos to IT->end_charpos. (The
2939 original value of -1 will not work with bidi.)
2940 (compute_display_string_pos): First arg is now struct
2941 `text_pos *'; all callers changed. Support display properties on
2942 Lisp strings.
2943 (compute_display_string_end): Support display properties on Lisp
2944 strings.
2945 (init_iterator, reseat_1, reseat_to_string): Initialize the
2946 string.bufpos member to 0 (zero, for compatibility with IT_CHARPOS
2947 when iterating on a string not from display properties).
2948 (compute_display_string_pos, compute_display_string_end):
2949 Fix calculation of the object to scan. Fixes an error when using
2950 arrow keys.
2951 (next_element_from_buffer): Don't abort when IT_CHARPOS is before
2952 base_level_stop; instead, set base_level_stop to BEGV.
2953 Fixes crashes in vertical-motion.
2954 (next_element_from_buffer): Improve commentary for when
2955 the iterator is before prev_stop.
2956 (init_iterator): Initialize bidi_p from the default value of
2957 bidi-display-reordering, not from buffer-local value. Use the
2958 buffer-local value only if initializing for buffer iteration.
2959 (handle_invisible_prop): Support invisible properties on strings
2960 that are being bidi-reordered.
2961 (set_iterator_to_next): Support bidi reordering of C strings and
2962 Lisp strings.
2963 (next_element_from_string): Support bidi reordering of Lisp
2964 strings.
2965 (handle_stop_backwards): Support Lisp strings as well.
2966 (display_string): Support display of R2L glyph rows.
2967 Use IT_STRING_CHARPOS when displaying from a Lisp string.
2968 (init_iterator): Don't initialize it->bidi_p for strings
2969 here.
2970 (reseat_to_string): Initialize it->bidi_p for strings here.
2971 (next_element_from_string, next_element_from_c_string)
2972 (next_element_from_buffer): Add xassert's for correspondence
2973 between IT's object being iterated and it->bidi_it.string
2974 structure.
2975 (face_before_or_after_it_pos): Support bidi iteration.
2976 (next_element_from_c_string): Handle the case of the first string
2977 character that is not the first one in the visual order.
2978 (get_visually_first_element): New function, refactored from common
2979 parts of next_element_from_buffer, next_element_from_string, and
2980 next_element_from_c_string.
2981 (tool_bar_lines_needed, redisplay_tool_bar)
2982 (display_menu_bar): Force left-to-right direction. Add a FIXME
2983 comment for making that be controlled by a user option.
2984 (push_it, pop_it): Save and restore the state of the
2985 bidi iterator. Save and restore the bidi_p flag.
2986 (pop_it): Iterate out of display property for string iteration as
2987 well.
2988 (iterate_out_of_display_property): Support iteration over strings.
2989 (handle_single_display_spec): Set up it->bidi_it for iteration
2990 over a display string, and call bidi_init_it.
2991 (handle_single_display_spec, next_overlay_string)
2992 (get_overlay_strings_1, push_display_prop): Set up the bidi
2993 iterator for displaying display or overlay strings.
2994 (forward_to_next_line_start): Don't use the shortcut if
2995 bidi-iterating.
2996 (back_to_previous_visible_line_start): If handle_display_prop
2997 pushed the iterator stack, restore the internal state of the bidi
2998 iterator by calling bidi_pop_it same number of times.
2999 (reseat_at_next_visible_line_start): If ON_NEWLINE_P is non-zero,
3000 and we are bidi-iterating, don't decrement the iterator position;
3001 instead, set the first_elt flag in the bidi iterator, to produce
3002 the same effect.
3003 (reseat_1): Remove redundant setting of string_from_display_prop_p.
3004 (push_display_prop): xassert that we are iterating a buffer.
3005 (push_it, pop_it): Save and restore paragraph_embedding member.
3006 (handle_single_display_spec, next_overlay_string)
3007 (get_overlay_strings_1, reseat_1, reseat_to_string)
3008 (push_display_prop): Set up the `unibyte' member of bidi_it.string
3009 correctly. Don't assume unibyte strings are not bidi-reordered.
3010 (compute_display_string_pos)
3011 (compute_display_string_end): Fix handling the case of C string.
3012 (push_it, pop_it): Save and restore from_disp_prop_p.
3013 (handle_single_display_spec, push_display_prop): Set the
3014 from_disp_prop_p flag.
3015 (get_overlay_strings_1): Reset the from_disp_prop_p flag.
3016 (pop_it): Call iterate_out_of_display_property only if we are
3017 popping after iteration over a string that came from a display
3018 property. Fix a typo in popping stretch info. Add an assertion
3019 for verifying that the iterator position is in sync with the bidi
3020 iterator.
3021 (handle_single_display_spec, get_overlay_strings_1)
3022 (push_display_prop): Fix initialization of paragraph direction for
3023 string when that of the parent object is not yet determined.
3024 (reseat_1): Call bidi_init_it to resync the bidi
3025 iterator with IT's position. (Bug#7616)
3026 (find_row_edges): If ROW->start.pos gives position
3027 smaller than min_pos, use it as ROW->minpos. (Bug#7616)
3028 (handle_stop, back_to_previous_visible_line_start, reseat_1):
3029 Reset the from_disp_prop_p flag.
3030 (SAVE_IT, RESTORE_IT): New macros.
3031 (pos_visible_p, face_before_or_after_it_pos)
3032 (back_to_previous_visible_line_start)
3033 (move_it_in_display_line_to, move_it_in_display_line)
3034 (move_it_to, move_it_vertically_backward, move_it_by_lines)
3035 (try_scrolling, redisplay_window, display_line): Use them when
3036 saving a temporary copy of the iterator and restoring it back.
3037 (back_to_previous_visible_line_start, reseat_1)
3038 (init_iterator): Empty the bidi cache "stack".
3039 (move_it_in_display_line_to): If iterator ended up at
3040 EOL, but we never saw any buffer positions smaller than
3041 to_charpos, return MOVE_POS_MATCH_OR_ZV. Fixes vertical cursor
3042 motion in bidi-reordered lines.
3043 (move_it_in_display_line_to): Record prev_method and prev_pos
3044 immediately before the call to set_iterator_to_next. Fixes cursor
3045 motion in bidi-reordered lines with stretch glyphs and strings
3046 displayed in margins. (Bug#8133) (Bug#8867)
3047 Return MOVE_POS_MATCH_OR_ZV only if iterator position is past
3048 TO_CHARPOS.
3049 (pos_visible_p): Support positions in bidi-reordered lines.
3050 Save and restore bidi cache.
3051
3052 * bidi.c (bidi_level_of_next_char): clen should be EMACS_NT, not int.
3053 (bidi_paragraph_info): Delete unused struct.
3054 (bidi_cache_idx, bidi_cache_last_idx): Declare EMACS_INT.
3055 (bidi_cache_start): New variable.
3056 (bidi_cache_reset): Reset bidi_cache_idx to bidi_cache_start, not
3057 to zero.
3058 (bidi_cache_fetch_state, bidi_cache_search)
3059 (bidi_cache_find_level_change, bidi_cache_iterator_state)
3060 (bidi_cache_find, bidi_peek_at_next_level)
3061 (bidi_level_of_next_char, bidi_find_other_level_edge)
3062 (bidi_move_to_visually_next): Compare cache index with
3063 bidi_cache_start rather than with zero.
3064 (bidi_fetch_char): Accept new argument STRING; all callers
3065 changed. Support iteration over a string. Support strings with
3066 display properties. Support unibyte strings. Fix the type of
3067 `len' according to what STRING_CHAR_AND_LENGTH expects.
3068 (bidi_paragraph_init, bidi_resolve_explicit_1)
3069 (bidi_resolve_explicit, bidi_resolve_weak)
3070 (bidi_level_of_next_char, bidi_move_to_visually_next):
3071 Support iteration over a string.
3072 (bidi_set_sor_type, bidi_resolve_explicit_1)
3073 (bidi_resolve_explicit, bidi_type_of_next_char): ignore_bn_limit
3074 can now be zero (for strings); special values 0 and -1 were
3075 changed to -1 and -2, respectively.
3076 (bidi_char_at_pos): New function.
3077 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak):
3078 Call it instead of FETCH_MULTIBYTE_CHAR.
3079 (bidi_move_to_visually_next): Abort if charpos or bytepos were not
3080 initialized to valid values.
3081 (bidi_init_it): Don't initialize charpos and bytepos with invalid
3082 values.
3083 (bidi_level_of_next_char): Allow the sentinel "position" to pass
3084 the test for valid cached positions. Fix the logic for looking up
3085 the sentinel state in the cache. GCPRO the Lisp string we are
3086 iterating.
3087 (bidi_push_it, bidi_pop_it): New functions.
3088 (bidi_initialize): Initialize the bidi cache start stack pointer.
3089 (bidi_cache_ensure_space): New function, refactored from part of
3090 bidi_cache_iterator_state. Don't assume the required size is just
3091 one BIDI_CACHE_CHUNK away.
3092 (bidi_cache_start_stack, bidi_push_it): Use IT_STACK_SIZE.
3093 (bidi_count_bytes, bidi_char_at_pos): New functions.
3094 (bidi_cache_search): Don't assume bidi_cache_last_idx is
3095 always valid if bidi_cache_idx is valid.
3096 (bidi_cache_find_level_change): xassert that bidi_cache_last_idx
3097 is valid if it's going to be used.
3098 (bidi_shelve_cache, bidi_unshelve_cache): New functions.
3099 (bidi_cache_fetch_state, bidi_cache_search)
3100 (bidi_cache_find_level_change, bidi_cache_ensure_space)
3101 (bidi_cache_iterator_state, bidi_cache_find)
3102 (bidi_find_other_level_edge, bidi_cache_start_stack):
3103 All variables related to cache indices are now EMACS_INT.
3104
3105 * dispextern.h (struct bidi_string_data): New structure.
3106 (struct bidi_it): New member `string'. Make flag members be 1-bit
3107 fields, and put them last in the struct.
3108 (compute_display_string_pos, compute_display_string_end):
3109 Update prototypes.
3110 (bidi_push_it, bidi_pop_it): Add prototypes.
3111 (struct iterator_stack_entry): New members bidi_p,
3112 paragraph_embedding, and from_disp_prop_p.
3113 (struct it): Member bidi_p is now a bit field 1 bit wide.
3114 (bidi_shelve_cache, bidi_unshelve_cache):
3115 Declare prototypes.
3116
3117 * .gdbinit (xvectype, xvector, xcompiled, xchartable, xboolvector)
3118 (xpr, xfont, xbacktrace): Use "header.size" when accessing vectors
3119 and vector-like objects.
3120
3121 * dispnew.c (buffer_posn_from_coords): Save and restore the bidi
3122 cache around display iteration.
3123
3124 * window.c (Fwindow_end, window_scroll_pixel_based)
3125 (displayed_window_lines, Frecenter): Save and restore the bidi
3126 cache around display iteration.
3127
3128 2011-07-14 Lars Magne Ingebrigtsen <larsi@gnus.org>
3129
3130 * editfns.c (Fdelete_region): Clarify the use of the named
3131 parameters (bug#6788).
3132
3133 2011-07-14 Martin Rudalics <rudalics@gmx.at>
3134
3135 * indent.c (Fvertical_motion): Set and restore w->pointm when
3136 saving and restoring the window's buffer (Bug#9006).
3137
3138 2011-07-13 Lars Magne Ingebrigtsen <larsi@gnus.org>
3139
3140 * editfns.c (Fstring_to_char): Clarify just what is returned
3141 (bug#6576). Text by Eli Zaretskii.
3142
3143 2011-07-13 Juanma Barranquero <lekktu@gmail.com>
3144
3145 * gnutls.c (init_gnutls_functions): Honor gnutls_log_level (bug#9059).
3146
3147 2011-07-13 Eli Zaretskii <eliz@gnu.org>
3148
3149 * buffer.c (mmap_find): Fix a typo.
3150
3151 2011-07-13 Johan Bockgård <bojohan@gnu.org>
3152
3153 Fix execution of x selection hooks.
3154 * xselect.c (Qx_lost_selection_functions)
3155 (Qx_sent_selection_functions): New vars.
3156 (syms_of_xselect): DEFSYM them.
3157 (x_handle_selection_request): Pass Qx_sent_selection_functions
3158 rather than Vx_sent_selection_functions to Frun_hook_with_args.
3159 (x_handle_selection_clear,x_clear_frame_selections):
3160 Pass Qx_lost_selection_functions rather than
3161 Vx_lost_selection_functions to Frun_hook_with_args.
3162
3163 2011-07-13 Paul Eggert <eggert@cs.ucla.edu>
3164
3165 * buffer.c (Fget_buffer_create): Initialize inhibit_shrinking.
3166 The old code sometimes used this field without initializing it.
3167
3168 * alloc.c (gc_sweep): Don't read past end of array.
3169 In theory, the old code could also have corrupted Emacs internals,
3170 though it'd be very unlikely.
3171
3172 2011-07-12 Andreas Schwab <schwab@linux-m68k.org>
3173
3174 * character.c (Fcharacterp): Don't advertise optional ignored
3175 argument. (Bug#4026)
3176
3177 2011-07-12 Lars Magne Ingebrigtsen <larsi@gnus.org>
3178
3179 * keymap.c (syms_of_keymap): Clarify that "modifier" is "modifier
3180 key" (bug#4257).
3181
3182 * window.c (Fset_window_start): Doc fix (bug#4199).
3183 (Fset_window_hscroll): Ditto.
3184
3185 2011-07-12 Paul Eggert <eggert@cs.ucla.edu>
3186
3187 Fix minor new problems caught by GCC 4.6.1.
3188 * term.c (init_tty): Remove unused local.
3189 * xsettings.c (store_monospaced_changed): Define this function only
3190 if (defined HAVE_GSETTINGS || defined HAVE_GCONF), as it's
3191 not used otherwise.
3192
3193 2011-07-12 Chong Yidong <cyd@stupidchicken.com>
3194
3195 * xdisp.c (Vresize_mini_windows): Minor doc fix (Bug#3300).
3196
3197 2011-07-11 Lars Magne Ingebrigtsen <larsi@gnus.org>
3198
3199 * xdisp.c (syms_of_xdisp): Make it explicit that the mini-windows
3200 are the mini-buffer and the echo area (bug#3320).
3201
3202 * term.c (init_tty): Remove support for supdup, c10 and perq
3203 terminals, which are no longer supported (bug#1482).
3204
3205 2011-07-10 Johan Bockgård <bojohan@gnu.org>
3206
3207 * xdisp.c (Ftool_bar_lines_needed): Fix WINDOWP check.
3208
3209 2011-07-10 Jan Djärv <jan.h.d@swipnet.se>
3210
3211 * xmenu.c (menu_highlight_callback): Only pass frame to show_help_event
3212 for non-popups (Bug#3642).
3213
3214 2011-07-10 Andreas Schwab <schwab@linux-m68k.org>
3215
3216 * alloc.c (reset_malloc_hooks): Protoize.
3217 * buffer.c (mmap_init, mmap_find, mmap_free_1, mmap_enlarge)
3218 (mmap_set_vars, mmap_alloc, mmap_free, mmap_realloc): Likewise.
3219 * cm.c (losecursor): Likewise.
3220 * data.c (fmod): Likewise.
3221 * dispnew.c (swap_glyphs_in_rows): Likewise.
3222 * emacs.c (memory_warning_signal): Likewise.
3223 * floatfns.c (float_error): Likewise.
3224 * font.c (check_gstring, check_otf_features, otf_tag_symbol)
3225 (otf_open, font_otf_capability, generate_otf_features)
3226 (font_otf_DeviceTable, font_otf_ValueRecord, font_otf_Anchor):
3227 Likewise.
3228 * image.c (pbm_read_file): Likewise.
3229 * indent.c (string_display_width): Likewise.
3230 * intervals.c (check_for_interval, search_for_interval)
3231 (inc_interval_count, count_intervals, root_interval)
3232 (adjust_intervals_for_insertion, make_new_interval): Likewise.
3233 * lread.c (defalias): Likewise.
3234 * ralloc.c (r_alloc_check): Likewise.
3235 * regex.c (set_image_of_range_1, set_image_of_range)
3236 (regex_grow_registers): Likewise.
3237 * sysdep.c (strerror): Likewise.
3238 * termcap.c (valid_filename_p, tprint, main): Likewise.
3239 * tparam.c (main): Likewise.
3240 * unexhp9k800.c (run_time_remap, save_data_space)
3241 (update_file_ptrs, read_header, write_header, calculate_checksum)
3242 (copy_file, copy_rest, display_header): Likewise.
3243 * widget.c (mark_shell_size_user_specified, create_frame_gcs):
3244 Likewise.
3245 * xdisp.c (check_it): Likewise.
3246 * xfaces.c (register_color, unregister_color, unregister_colors):
3247 Likewise.
3248 * xfns.c (print_fontset_result): Likewise.
3249 * xrdb.c (member, fatal, main): Likewise.
3250
3251 2011-07-10 Paul Eggert <eggert@cs.ucla.edu>
3252
3253 Fix minor problems found by static checking (Bug#9031).
3254 * chartab.c (char_table_set_range, map_sub_char_table):
3255 Remove unused locals.
3256 (uniprop_table): Now static.
3257 * composite.c (_work_char): Remove unused static var.
3258
3259 2011-07-09 Juanma Barranquero <lekktu@gmail.com>
3260
3261 * chartab.c (uniprop_table_uncompress): Remove unused local variable.
3262
3263 2011-07-09 Jan Djärv <jan.h.d@swipnet.se>
3264
3265 * gtkutil.c (qttip_cb): Remove code without function.
3266
3267 2011-07-09 Eli Zaretskii <eliz@gnu.org>
3268
3269 * w32.c (pthread_sigmask): New stub.
3270
3271 2011-07-08 Paul Eggert <eggert@cs.ucla.edu>
3272
3273 Use pthread_sigmask, not sigprocmask (Bug#9010).
3274 sigprocmask is portable only for single-threaded applications, and
3275 Emacs can be multi-threaded when it uses GTK.
3276 * Makefile.in (LIB_PTHREAD_SIGMASK): New macro.
3277 (LIBES): Use it.
3278 * callproc.c (Fcall_process):
3279 * process.c (create_process):
3280 * sysdep.c (sys_sigblock, sys_sigunblock, sys_sigsetmask):
3281 Use pthread_sigmask, not sigprocmask.
3282
3283 2011-07-08 Jan Djärv <jan.h.d@swipnet.se>
3284
3285 * gtkutil.c (qttip_cb): Set line wrap to FALSE for tooltip widget.
3286 (xg_prepare_tooltip): Revert text in x->ttip_lbl, margins was
3287 wrong (Bug#8591).
3288
3289 2011-07-08 Jan Djärv <jan.h.d@swipnet.se>
3290
3291 * gtkutil.c (xg_prepare_tooltip): Fix indentation and comment.
3292 Put text in x->ttip_lbl instead of gtk_tooltip_set_text (Bug#8591).
3293 (xg_hide_tooltip): Fix comment.
3294
3295 * nsterm.m (initFrameFromEmacs): Don't use ns_return_types
3296 in registerServicesMenuSendTypes.
3297 (validRequestorForSendType): Don't check ns_return_types.
3298
3299 * nsfns.m (Fx_open_connection): Put NSStringPboardType into
3300 ns_return_type.
3301
3302 2011-07-08 Jason Rumney <jasonr@gnu.org>
3303
3304 * w32term.c (x_make_frame_visible): Use SH_SHOWNORMAL rather than
3305 SH_SHOW for hidden windows (Bug#5482).
3306
3307 * w32fns.c (w32_wnd_proc) [WM_TIMER, WM_SET_CURSOR]: Avoid using
3308 frame struct members of non-existent frames (Bug#6284).
3309
3310 2011-07-08 Jan Djärv <jan.h.d@swipnet.se>
3311
3312 * nsterm.m (keyDown): Call to wantsToDelayTextChangeNotifications and
3313 variable firstTime not needed on OSX >= 10.6.
3314 (setPosition): setFloatValue:knobProportion: is deprecated on OSX
3315 >= 10.5. Use setKnobProportion, setDoubleValue.
3316
3317 * nsterm.h (MAC_OS_X_VERSION_10_3, MAC_OS_X_VERSION_10_4)
3318 (MAC_OS_X_VERSION_10_5): Define if not defined.
3319 (EmacsView, EmacsTooltip): Implements NSWindowDelegate on OSX >= 10.6.
3320 (EmacsMenu): Implements NSMenuDelegate on OSX >= 10.6.
3321 (EmacsToolbar): Implements NSToolbarDelegate on OSX >= 10.6.
3322
3323 * nsselect.m (ns_string_from_pasteboard): Don't use deprecated methods
3324 cString and lossyCString on OSX >= 10.4
3325
3326 * nsmenu.m (fillWithWidgetValue): Don't use deprecated method
3327 sizeToFit on OSX >= 10.2.
3328
3329 * nsimage.m (allocInitFromFile): Don't use deprecated method
3330 bestRepresentationForDevice on OSX >= 10.6.
3331
3332 * nsfns.m (check_ns_display_info): Cast to long and use %ld in error
3333 to avoid warning.
3334
3335 * emacs.c: Declare unexec_init_emacs_zone.
3336
3337 * nsgui.h: Fix compiler warning about gnulib redefining verify.
3338
3339 * nsselect.m (ns_get_local_selection): Change to extern (Bug#8842).
3340
3341 * nsmenu.m (ns_update_menubar): Remove useless setDelegate call
3342 on svcsMenu (Bug#8842).
3343
3344 * nsfns.m (Fx_open_connection): Remove NSStringPboardType from
3345 ns_return_types.
3346 (Fns_list_services): Just return Qnil on 10.6, code not working there.
3347
3348 * nsterm.m (QUTF8_STRING): Declare.
3349 (initFrameFromEmacs): Call registerServicesMenuSendTypes.
3350 (validRequestorForSendType): Return type is (id).
3351 Change indexOfObjectIdenticalTo to indexOfObject.
3352 Check if we have local selection before returning self (Bug#8842).
3353 (writeSelectionToPasteboard): Put local selection into paste board
3354 if we have a local selection (Bug#8842).
3355 (syms_of_nsterm): DEFSYM QUTF8_STRING.
3356
3357 * nsterm.h (MAC_OS_X_VERSION_10_6): Define here instead of nsterm.m.
3358 (ns_get_local_selection): Declare.
3359
3360 2011-07-07 Lars Magne Ingebrigtsen <larsi@gnus.org>
3361
3362 * keymap.c (describe_map_tree): Don't insert a double newline at
3363 the end of the buffer (bug#1169) and return whether we inserted
3364 something.
3365
3366 * callint.c (Fcall_interactively): Change "reading args" to
3367 "providing args" to try to clarify what it does (bug#1010).
3368
3369 2011-07-07 Kenichi Handa <handa@m17n.org>
3370
3371 * composite.c (composition_compute_stop_pos): Ignore a static
3372 composition starting before CHARPOS (Bug#8915).
3373
3374 * xdisp.c (handle_composition_prop): Likewise.
3375
3376 2011-07-07 Eli Zaretskii <eliz@gnu.org>
3377
3378 * term.c (produce_glyphs) <xassert>: Allow IT_GLYPHLESS in it->what.
3379 (Bug#9015)
3380
3381 2011-07-07 Kenichi Handa <handa@m17n.org>
3382
3383 * character.h (unicode_category_t): New enum type.
3384
3385 * chartab.c (uniprop_decoder_t, uniprop_encoder_t): New types.
3386 (Qchar_code_property_table): New variable.
3387 (UNIPROP_TABLE_P, UNIPROP_GET_DECODER)
3388 (UNIPROP_COMPRESSED_FORM_P): New macros.
3389 (char_table_ascii): Uncompress the compressed values.
3390 (sub_char_table_ref): New arg is_uniprop. Callers changed.
3391 Uncompress the compressed values.
3392 (sub_char_table_ref_and_range): Likewise.
3393 (char_table_ref_and_range): Uncompress the compressed values.
3394 (sub_char_table_set): New arg is_uniprop. Callers changed.
3395 Uncompress the compressed values.
3396 (sub_char_table_set_range): Args changed. Callers changed.
3397 (char_table_set_range): Adjuted for the above change.
3398 (map_sub_char_table): Delete args default_val and parent. Add arg
3399 top. Give decoded values to a Lisp function.
3400 (map_char_table): Adjust for the above change. Give decoded
3401 values to a Lisp function. Gcpro more variables.
3402 (uniprop_table_uncompress)
3403 (uniprop_decode_value_run_length): New functions.
3404 (uniprop_decoder, uniprop_decoder_count): New variables.
3405 (uniprop_get_decoder, uniprop_encode_value_character)
3406 (uniprop_encode_value_run_length, uniprop_encode_value_numeric):
3407 New functions.
3408 (uniprop_encoder, uniprop_encoder_count): New variables.
3409 (uniprop_get_encoder, uniprop_table)
3410 (Funicode_property_table_internal, Fget_unicode_property_internal)
3411 (Fput_unicode_property_internal): New functions.
3412 (syms_of_chartab): DEFSYM Qchar_code_property_table, defsubr
3413 Sunicode_property_table_internal, Sget_unicode_property_internal,
3414 and Sput_unicode_property_internal. Defvar_lisp
3415 char-code-property-alist.
3416
3417 * composite.c (CHAR_COMPOSABLE_P): Adjust for the change of
3418 Vunicode_category_table.
3419
3420 * font.c (font_range): Adjust for the change of
3421 Vunicode_category_table.
3422
3423 2011-07-07 Dan Nicolaescu <dann@ics.uci.edu>
3424
3425 * m/iris4d.h: Remove file, move contents ...
3426 * s/irix6-5.h: ... here.
3427
3428 2011-07-06 Paul Eggert <eggert@cs.ucla.edu>
3429
3430 Remove unportable assumption about struct layout (Bug#8884).
3431 * alloc.c (mark_buffer):
3432 * buffer.c (reset_buffer_local_variables, Fbuffer_local_variables)
3433 (clone_per_buffer_values): Don't assume that
3434 sizeof (struct buffer) is a multiple of sizeof (Lisp_Object).
3435 This isn't true in general, and it's particularly not true
3436 if Emacs is configured with --with-wide-int.
3437 * buffer.h (FIRST_FIELD_PER_BUFFER, LAST_FIELD_PER_BUFFER):
3438 New macros, used in the buffer.c change.
3439
3440 2011-07-05 Jan Djärv <jan.h.d@swipnet.se>
3441
3442 * xsettings.c: Use both GConf and GSettings if both are available.
3443 (store_config_changed_event): Add comment.
3444 (dpyinfo_valid, store_font_name_changed, map_tool_bar_style)
3445 (store_tool_bar_style_changed): New functions.
3446 (store_monospaced_changed): Add comment. Call dpyinfo_valid.
3447 (struct xsettings): Move font inside HAVE_XFT.
3448 (GSETTINGS_TOOL_BAR_STYLE, GSETTINGS_FONT_NAME): New defines.
3449 (GSETTINGS_MONO_FONT): Rename from SYSTEM_MONO_FONT.
3450 Move inside HAVE_XFT.
3451 (something_changed_gsettingsCB): Rename from something_changedCB.
3452 Check for changes in GSETTINGS_TOOL_BAR_STYLE and GSETTINGS_FONT_NAME
3453 also.
3454 (GCONF_TOOL_BAR_STYLE, GCONF_FONT_NAME): New defines.
3455 (GCONF_MONO_FONT): Rename from SYSTEM_MONO_FONT. Move inside HAVE_XFT.
3456 (something_changed_gconfCB): Rename from something_changedCB.
3457 Check for changes in GCONF_TOOL_BAR_STYLE and GCONF_FONT_NAME also.
3458 (parse_settings): Move check for font inside HAVE_XFT.
3459 (read_settings, apply_xft_settings): Add comment.
3460 (read_and_apply_settings): Add comment. Call map_tool_bar_style and
3461 store_tool_bar_style_changed. Move check for font inside HAVE_XFT and
3462 call store_font_name_changed.
3463 (xft_settings_event): Add comment.
3464 (init_gsettings): Add comment. Get values for GSETTINGS_TOOL_BAR_STYLE
3465 and GSETTINGS_FONT_NAME. Move check for fonts within HAVE_XFT.
3466 (init_gconf): Add comment. Get values for GCONF_TOOL_BAR_STYLE
3467 and GCONF_FONT_NAME. Move check for fonts within HAVE_XFT.
3468 (xsettings_initialize): Call init_gsettings last.
3469 (xsettings_get_system_font, xsettings_get_system_normal_font):
3470 Add comment.
3471
3472 2011-07-05 Paul Eggert <eggert@cs.ucla.edu>
3473
3474 Random fixes. E.g., (random) never returned negative values.
3475 * fns.c (Frandom): Use GET_EMACS_TIME for random seed, and add the
3476 subseconds part to the entropy, as that's a bit more random.
3477 Prefer signed to unsigned, since the signedness doesn't matter and
3478 in general we prefer signed. When given a limit, use a
3479 denominator equal to INTMASK + 1, not to VALMASK + 1, because the
3480 latter isn't right if USE_2_TAGS_FOR_INTS.
3481 * sysdep.c (get_random): Return a value in the range 0..INTMASK,
3482 not 0..VALMASK. Don't discard "excess" bits that random () returns.
3483
3484 2011-07-04 Stefan Monnier <monnier@iro.umontreal.ca>
3485
3486 * textprop.c (text_property_stickiness):
3487 Obey Vtext_property_default_nonsticky.
3488 (syms_of_textprop): Add `display' to Vtext_property_default_nonsticky.
3489 * w32fns.c (syms_of_w32fns):
3490 * xfns.c (syms_of_xfns): Don't Add `display' since it's there by default.
3491
3492 2011-07-04 Paul Eggert <eggert@cs.ucla.edu>
3493
3494 * fileio.c (barf_or_query_if_file_exists): Use S_ISDIR.
3495 This is more efficient than Ffile_directory_p and avoids a minor race.
3496
3497 2011-07-04 Lars Magne Ingebrigtsen <larsi@gnus.org>
3498
3499 * buffer.c (Foverlay_put): Say what the return value is
3500 (bug#7835).
3501
3502 * fileio.c (barf_or_query_if_file_exists): Check first if the file
3503 is a directory before asking whether to use the file name
3504 (bug#7564).
3505 (barf_or_query_if_file_exists): Make the "File is a directory"
3506 error be more correct.
3507
3508 * fns.c (Frequire): Remove the mention of the .gz files, since
3509 that's installation-specific, but keep the mention of
3510 `get-load-suffixes'.
3511
3512 2011-07-04 Paul Eggert <eggert@cs.ucla.edu>
3513
3514 * editfns.c (Fformat_time_string): Don't assume strlen fits in int.
3515 Report string overflow if the output is too long.
3516
3517 2011-07-04 Juanma Barranquero <lekktu@gmail.com>
3518
3519 * gnutls.c (Fgnutls_boot): Don't mention :verify-error.
3520 (syms_of_gnutls): Remove duplicate DEFSYM for
3521 Qgnutls_bootprop_verify_hostname_error, an error for
3522 Qgnutls_bootprop_verify_error (which is no longer used).
3523
3524 * eval.c (find_handler_clause): Remove parameters `sig' and `data',
3525 unused since 2011-01-26T20:02:07Z!monnier@iro.umontreal.ca. All callers changed.
3526 Also (re)move comments that are misplaced or no longer relevant.
3527
3528 2011-07-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
3529
3530 * callint.c (Finteractive): Clarify the meaning of "@" (bug#8813).
3531
3532 2011-07-03 Chong Yidong <cyd@stupidchicken.com>
3533
3534 * xfaces.c (Finternal_merge_in_global_face): Modify the foreground
3535 and background color parameters if they have been changed.
3536
3537 2011-07-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
3538
3539 * editfns.c (Fformat): Clarify the - and 0 flags (bug#6659).
3540
3541 2011-07-03 Paul Eggert <eggert@cs.ucla.edu>
3542
3543 * xsettings.c (SYSTEM_FONT): Define only when used.
3544 No need to define when HAVE_GSETTINGS || !HAVE_XFT.
3545
3546 * keymap.c (access_keymap_1): Now static.
3547
3548 2011-07-02 Chong Yidong <cyd@stupidchicken.com>
3549
3550 * keyboard.c (command_loop_1): If a down-mouse event is unbound,
3551 leave any prefix arg for the up event (Bug#1586).
3552
3553 2011-07-02 Lars Magne Ingebrigtsen <larsi@gnus.org>
3554
3555 * lread.c (syms_of_lread): Mention single symbols defined by
3556 `defvar' or `defconst' (bug#7154).
3557
3558 * fns.c (Frequire): Mention .el.gz files (bug#7314).
3559 (Frequire): Mention get-load-suffixes.
3560
3561 2011-07-02 Martin Rudalics <rudalics@gmx.at>
3562
3563 * window.h (window): Remove clone_number slot.
3564 * window.c (Fwindow_clone_number, Fset_window_clone_number):
3565 Remove.
3566 (make_parent_window, make_window, saved_window)
3567 (Fset_window_configuration, save_window_save): Don't deal with
3568 clone numbers.
3569 * buffer.c (Qclone_number): Remove declaration.
3570 (sort_overlays, overlay_strings): Don't deal with clone numbers.
3571
3572 2011-07-02 Stefan Monnier <monnier@iro.umontreal.ca>
3573
3574 Add multiple inheritance to keymaps.
3575 * keymap.c (Fmake_composed_keymap): New function.
3576 (Fset_keymap_parent): Simplify.
3577 (fix_submap_inheritance): Remove.
3578 (access_keymap_1): New function extracted from access_keymap to handle
3579 embedded parents and handle lists of maps.
3580 (access_keymap): Use it.
3581 (Fkeymap_prompt, map_keymap_internal, map_keymap, store_in_keymap)
3582 (Fcopy_keymap): Handle embedded parents.
3583 (Fcommand_remapping, define_as_prefix): Simplify.
3584 (Fkey_binding): Simplify.
3585 (syms_of_keymap): Move minibuffer-local-completion-map,
3586 minibuffer-local-filename-completion-map,
3587 minibuffer-local-must-match-map, and
3588 minibuffer-local-filename-must-match-map to Elisp.
3589 (syms_of_keymap): Defsubr make-composed-keymap.
3590 * keyboard.c (menu_bar_items): Use map_keymap_canonical.
3591 (parse_menu_item): Trivial simplification.
3592
3593 2011-07-01 Glenn Morris <rgm@gnu.org>
3594
3595 * Makefile.in (SETTINGS_LIBS): Fix typo.
3596
3597 2011-07-01 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny patch)
3598
3599 * coding.c (Fencode_coding_string): Record the last coding system
3600 used, as the function doc string says (bug#8738).
3601
3602 2011-07-01 Jan Djärv <jan.h.d@swipnet.se>
3603
3604 * xsettings.c (store_monospaced_changed): Take new font as arg and
3605 check for change against current_mono_font.
3606 (EMACS_TYPE_SETTINGS): Remove this and related defines.
3607 (emacs_settings_constructor, emacs_settings_get_property)
3608 (emacs_settings_set_property, emacs_settings_class_init)
3609 (emacs_settings_init, gsettings_obj): Remove.
3610 (something_changedCB): New function for HAVE_GSETTINGS.
3611 (something_changedCB): HAVE_GCONF: Call store_monospaced_changed
3612 with value as argument.
3613 (init_gsettings): Check that GSETTINGS_SCHEMA exists before calling
3614 g_settings_new (Bug#8967). Do not create gsettings_obj.
3615 Remove calls to g_settings_bind. Connect something_changedCB to
3616 "changed".
3617
3618 * xgselect.c: Add defined (HAVE_GSETTINGS).
3619 (xgselect_initialize): Ditto.
3620
3621 * process.c: Add defined (HAVE_GSETTINGS) for xgselect.h
3622 (wait_reading_process_output): Add defined (HAVE_GSETTINGS) for
3623 xg_select.
3624
3625 2011-07-01 Paul Eggert <eggert@cs.ucla.edu>
3626
3627 * eval.c (struct backtrace): Simplify and port the data structure.
3628 Do not assume that "int nargs : BITS_PER_INT - 2;" produces a
3629 signed bit field, as this assumption is not portable and it makes
3630 Emacs crash when compiled with Sun C 5.8 on sparc. Do not use
3631 "char debug_on_exit : 1" as this is not portable either; instead,
3632 use the portable "unsigned int debug_on_exit : 1". Remove unused
3633 member evalargs. Remove obsolete comments about cc bombing out.
3634
3635 2011-06-30 Jan Djärv <jan.h.d@swipnet.se>
3636
3637 * xsettings.c: Include glib-object.h, gio/gio.h if HAVE_GSETTINGS.
3638 Let HAVE_GSETTINGS override HAVE_GCONF.
3639 (store_monospaced_changed): New function.
3640 (EMACS_SETTINGS): A new type derived from GObject to handle
3641 GSettings notifications.
3642 (emacs_settings_constructor, emacs_settings_get_property)
3643 (emacs_settings_set_property, emacs_settings_class_init):
3644 New functions.
3645 (gsettings_client, gsettings_obj): New variables.
3646 (GSETTINGS_SCHEMA): New define.
3647 (something_changedCB): Call store_monospaced_changed.
3648 (init_gsettings): New function.
3649 (xsettings_initialize): Call init_gsettings.
3650 (syms_of_xsettings): Initialize gsettings_client, gsettings_obj
3651 to NULL.
3652
3653 * Makefile.in (SETTINGS_CFLAGS, SETTINGS_LIBS): Rename from
3654 GCONF_CFLAGS/LIBS.
3655
3656 2011-06-29 Martin Rudalics <rudalics@gmx.at>
3657
3658 * window.c (resize_root_window, grow_mini_window)
3659 (shrink_mini_window): Rename Qresize_root_window to
3660 Qwindow_resize_root_window and Qresize_root_window_vertically to
3661 Qwindow_resize_root_window_vertically.
3662
3663 2011-06-28 Paul Eggert <eggert@cs.ucla.edu>
3664
3665 * gnutls.c (Qgnutls_bootprop_verify_error): Remove unused var.
3666
3667 2011-06-27 Juanma Barranquero <lekktu@gmail.com>
3668
3669 * makefile.w32-in: Redesign dependencies so they reflect more
3670 clearly which files are directly included by each source file,
3671 and not through other includes.
3672
3673 2011-06-27 Martin Rudalics <rudalics@gmx.at>
3674
3675 * buffer.c (Qclone_number): Declare static and DEFSYM it.
3676 (sort_overlays, overlay_strings): When an overlay's clone number
3677 matches the window's clone number process the overlay even if
3678 the overlay's window property doesn't match the current window.
3679
3680 * window.c (Fwindow_vchild): Rename to Fwindow_top_child.
3681 (Fwindow_hchild): Rename to Fwindow_left_child.
3682 (Fwindow_next): Rename to Fwindow_next_sibling.
3683 (Fwindow_prev): Rename to Fwindow_prev_sibling.
3684 (resize_window_check): Rename to window_resize_check.
3685 (resize_window_apply): Rename to window_resize_apply.
3686 (Fresize_window_apply): Rename to Fwindow_resize_apply.
3687 (Fdelete_other_windows_internal, resize_frame_windows)
3688 (Fsplit_window_internal, Fdelete_window_internal)
3689 (grow_mini_window, shrink_mini_window)
3690 (Fresize_mini_window_internal): Fix callers accordingly.
3691
3692 2011-06-26 Jan Djärv <jan.h.d@swipnet.se>
3693
3694 * emacsgtkfixed.h: State that this is only used with Gtk+3.
3695 (emacs_fixed_set_min_size): Remove.
3696 (emacs_fixed_new): Take frame as argument.
3697
3698 * emacsgtkfixed.c: State that this is only used with Gtk+3.
3699 (_EmacsFixedPrivate): Remove minwidth/height.
3700 Add struct frame *f.
3701 (emacs_fixed_init): Initialize priv->f.
3702 (get_parent_class, emacs_fixed_set_min_size): Remove.
3703 (emacs_fixed_new): Set priv->f to argument.
3704 (emacs_fixed_get_preferred_width)
3705 (emacs_fixed_get_preferred_height): Use min_width/height from
3706 frames size_hint to set minimum and natural (Bug#8919).
3707 (XSetWMSizeHints, XSetWMNormalHints): Override these functions
3708 and use min_width/height from frames size_hint to set
3709 min_width/height (Bug#8919).
3710
3711 * gtkutil.c (xg_create_frame_widgets): Pass f to emacs_fixed_new.
3712 (x_wm_set_size_hint): Remove call to emacs_fixed_set_min_size.
3713 Fix indentation.
3714
3715 2011-06-26 Eli Zaretskii <eliz@gnu.org>
3716
3717 * bidi.c (bidi_paragraph_init): Test for ZV_BYTE before calling
3718 bidi_at_paragraph_end, since fast_looking_at doesn't like to be
3719 called at ZV.
3720
3721 2011-06-26 Chong Yidong <cyd@stupidchicken.com>
3722
3723 * process.c (wait_reading_process_output): Bypass select if
3724 waiting for a cell while ignoring keyboard input, and input is
3725 pending. Suggested by Jan Djärv (Bug#8869).
3726
3727 2011-06-25 Paul Eggert <eggert@cs.ucla.edu>
3728
3729 Use gnulib's dup2 module instead of rolling our own.
3730 * sysdep.c (dup2) [!HAVE_DUP2]: Remove; gnulib now does this.
3731
3732 2011-06-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
3733
3734 * dispnew.c (scrolling_window): Before scrolling, turn off a
3735 mouse-highlight in the window being scrolled.
3736
3737 2011-06-24 Juanma Barranquero <lekktu@gmail.com>
3738
3739 Move DEFSYM to lisp.h and use everywhere.
3740
3741 * character.h (DEFSYM): Move declaration...
3742 * lisp.h (DEFSYM): ...here.
3743
3744 * gnutls.c:
3745 * minibuf.c:
3746 * w32menu.c:
3747 * w32proc.c:
3748 * w32select.c: Don't include character.h.
3749
3750 * alloc.c (syms_of_alloc):
3751 * buffer.c (syms_of_buffer):
3752 * bytecode.c (syms_of_bytecode):
3753 * callint.c (syms_of_callint):
3754 * casefiddle.c (syms_of_casefiddle):
3755 * casetab.c (init_casetab_once):
3756 * category.c (init_category_once, syms_of_category):
3757 * ccl.c (syms_of_ccl):
3758 * cmds.c (syms_of_cmds):
3759 * composite.c (syms_of_composite):
3760 * dbusbind.c (syms_of_dbusbind):
3761 * dired.c (syms_of_dired):
3762 * dispnew.c (syms_of_display):
3763 * doc.c (syms_of_doc):
3764 * editfns.c (syms_of_editfns):
3765 * emacs.c (syms_of_emacs):
3766 * eval.c (syms_of_eval):
3767 * fileio.c (syms_of_fileio):
3768 * fns.c (syms_of_fns):
3769 * frame.c (syms_of_frame):
3770 * fringe.c (syms_of_fringe):
3771 * insdel.c (syms_of_insdel):
3772 * keymap.c (syms_of_keymap):
3773 * lread.c (init_obarray, syms_of_lread):
3774 * macros.c (syms_of_macros):
3775 * msdos.c (syms_of_msdos):
3776 * print.c (syms_of_print):
3777 * process.c (syms_of_process):
3778 * search.c (syms_of_search):
3779 * sound.c (syms_of_sound):
3780 * syntax.c (init_syntax_once, syms_of_syntax):
3781 * terminal.c (syms_of_terminal):
3782 * textprop.c (syms_of_textprop):
3783 * undo.c (syms_of_undo):
3784 * w32.c (globals_of_w32):
3785 * window.c (syms_of_window):
3786 * xdisp.c (syms_of_xdisp):
3787 * xfaces.c (syms_of_xfaces):
3788 * xfns.c (syms_of_xfns):
3789 * xmenu.c (syms_of_xmenu):
3790 * xsettings.c (syms_of_xsettings):
3791 * xterm.c (syms_of_xterm): Use DEFSYM.
3792
3793 2011-06-24 Teodor Zlatanov <tzz@lifelogs.com>
3794
3795 * gnutls.c (syms_of_gnutls): Use the DEFSYM macro from character.h.
3796
3797 2011-06-23 Paul Eggert <eggert@cs.ucla.edu>
3798
3799 Integer and buffer overflow fixes (Bug#8873).
3800
3801 * print.c (printchar, strout): Check for string overflow.
3802 (PRINTPREPARE, printchar, strout):
3803 Don't set size unless allocation succeeds.
3804
3805 * minibuf.c (read_minibuf_noninteractive): Use ptrdiff_t, not int,
3806 for sizes. Check for string overflow more accurately.
3807 Simplify newline removal at end; this suppresses a GCC 4.6.0 warning.
3808
3809 * macros.c: Integer and buffer overflow fixes.
3810 * keyboard.h (struct keyboard.kbd_macro_bufsize):
3811 * macros.c (Fstart_kbd_macro, store_kbd_macro_char):
3812 Use ptrdiff_t, not int, for sizes.
3813 Don't increment bufsize until after realloc succeeds.
3814 Check for size-calculation overflow.
3815 (Fstart_kbd_macro): Use EMACS_INT, not int, for XINT result.
3816
3817 * lisp.h (DEFVAR_KBOARD): Use offsetof instead of char * finagling.
3818
3819 * lread.c: Integer overflow fixes.
3820 (read_integer): Radix is now EMACS_INT, not int,
3821 to improve quality of diagnostics for out-of-range radices.
3822 Calculate buffer size correctly for out-of-range radices.
3823 (read1): Check for integer overflow in radices, and in
3824 read-circle numbers.
3825 (read_escape): Avoid int overflow.
3826 (Fload, openp, read_buffer_size, read1)
3827 (substitute_object_recurse, read_vector, read_list, map_obarray):
3828 Use ptrdiff_t, not int, for sizes.
3829 (read1): Use EMACS_INT, not int, for sizes.
3830 Check for size overflow.
3831
3832 * image.c (cache_image): Check for size arithmetic overflow.
3833
3834 * lread.c: Integer overflow issues.
3835 (saved_doc_string_size, saved_doc_string_length)
3836 (prev_saved_doc_string_size, prev_saved_doc_string_length):
3837 Now ptrdiff_t, not int.
3838 (read1): Don't assume doc string length fits in int. Check for
3839 out-of-range doc string lengths.
3840 (read_list): Don't assume file position fits in int.
3841 (read_escape): Check for hex character overflow.
3842
3843 2011-06-22 Leo Liu <sdl.web@gmail.com>
3844
3845 * minibuf.c (Fcompleting_read_default, Vcompleting_read_function):
3846 Move to minibuffer.el.
3847
3848 2011-06-22 Paul Eggert <eggert@cs.ucla.edu>
3849
3850 Fixes for GLYPH_DEBUG found by GCC 4.6.0 static checking.
3851 The following patches are for when GLYPH_DEBUG && !XASSERT.
3852 * dispextern.h (trace_redisplay_p, dump_glyph_string):
3853 * dispnew.c (flush_stdout):
3854 * xdisp.c (dump_glyph_row, dump_glyph_matrix, dump_glyph):
3855 Mark as externally visible.
3856 * dispnew.c (check_window_matrix_pointers): Now static.
3857 * dispnew.c (window_to_frame_vpos):
3858 * xfns.c (unwind_create_frame):
3859 * xterm.c (x_check_font): Remove unused local.
3860 * scroll.c (CHECK_BOUNDS):
3861 * xfaces.c (cache_fache): Rename local to avoid shadowing.
3862 * xfns.c, w32fns.c (image_cache_refcount, dpyinfo_refcount): Now static.
3863 * xdisp.c (check_window_end): Now a no-op if !XASSERTS.
3864 (debug_first_unchanged_at_end_vpos, debug_last_unchanged_at_beg_vpos)
3865 (debug_dvpos, debug_dy, debug_delta, debug_delta_bytes, debug_end_vpos):
3866 Now static.
3867 (debug_method_add): Use va_list and vsprintf rather than relying
3868 on undefined behavior with wrong number of arguments.
3869 (dump_glyph, dump_glyph_row, Fdump_glyph_matrix):
3870 Don't assume ptrdiff_t and EMACS_INT are the same width as int.
3871 In this code, it's OK to assume C99 behavior for ptrdiff_t formats
3872 since we're not interested in debugging glyphs with old libraries.
3873 * xfaces.c (cache_face): Move debugging code earlier; this pacifies
3874 GCC 4.6.0's static checking.
3875
3876 2011-06-22 Paul Eggert <eggert@cs.ucla.edu>
3877
3878 Integer overflow and signedness fixes (Bug#8873).
3879 A few related buffer overrun fixes, too.
3880
3881 * font.c (font_score): Use EMACS_INT, not int, to store XINT value.
3882
3883 * dispextern.h (struct face.stipple):
3884 * image.c (x_bitmap_height, x_bitmap_width, x_bitmap_pixmap)
3885 (x_bitmap_mask, x_allocate_bitmap_record)
3886 (x_create_bitmap_from_data, x_create_bitmap_from_file)
3887 (x_destroy_bitmap, x_destroy_all_bitmaps, x_create_bitmap_mask)
3888 (x_create_bitmap_from_xpm_data):
3889 * nsterm.h (struct ns_display_info.bitmaps_size, .bitmaps_last):
3890 * w32term.h (struct w32_display_info.icon_bitmap_id, .bitmaps_size)
3891 (.bitmaps_last):
3892 * xfaces.c (load_pixmap):
3893 * xterm.c (x_bitmap_icon, x_wm_set_icon_pixmap):
3894 * xterm.h (struct x_display_info.icon_bitmap_id, .bitmaps_size)
3895 (.bitmaps_last, struct x_output.icon_bitmap):
3896 Use ptrdiff_t, not int, for bitmap indexes.
3897 (x_allocate_bitmap_record): Check for size overflow.
3898 * dispextern.h, lisp.h: Adjust to API changes elsewhere.
3899
3900 Use ptrdiff_t, not int, for overlay counts.
3901 * buffer.h (overlays_at, sort_overlays, GET_OVERLAYS_AT):
3902 * editfns.c (overlays_around, get_pos_property):
3903 * textprop.c (get_char_property_and_overlay):
3904 * xdisp.c (next_overlay_change, note_mouse_highlight):
3905 * xfaces.c (face_at_buffer_position):
3906 * buffer.c (OVERLAY_COUNT_MAX): New macro.
3907 (overlays_at, overlays_in, sort_overlays, Foverlays_at)
3908 (Fnext_overlay_change, Fprevious_overlay_change)
3909 (mouse_face_overlay_overlaps, Foverlays_in):
3910 Use ptrdiff_t, not int, for sizes.
3911 (overlays_at, overlays_in): Check for size-calculation overflow.
3912
3913 * xterm.c (xim_initialize, same_x_server): Strlen may not fit in int.
3914
3915 * xsmfns.c (smc_save_yourself_CB, x_session_initialize): Avoid strlen.
3916 (x_session_initialize): Do not assume string length fits in int.
3917
3918 * xsettings.c (apply_xft_settings): Fix potential buffer overrun.
3919 This is unlikely, but can occur if DPI is outlandish.
3920
3921 * xsettings.c (Ffont_get_system_normal_font, Ffont_get_system_font):
3922 * xselect.c (Fx_get_atom_name): Avoid need for strlen.
3923
3924 * xrdb.c: Don't assume strlen fits in int; avoid some strlens.
3925 * xrdb.c (magic_file_p, search_magic_path):
3926 Omit last arg SUFFIX; it was always 0. All callers changed.
3927 (magic_file_p): Use ptrdiff_t, not int. Check for size overflow.
3928
3929 * xfont.c (xfont_match): Avoid need for strlen.
3930
3931 * xfns.c: Don't assume strlen fits in int.
3932 (xic_create_fontsetname, x_window): Use ptrdiff_t, not int.
3933
3934 * xdisp.c (message_log_check_duplicate): Return intmax_t,
3935 not unsigned long, as we prefer signed integers. All callers changed.
3936 Detect integer overflow in repeat count.
3937 (message_dolog): Don't assume print length fits in 39 bytes.
3938 (display_mode_element): Don't assume strlen fits in int.
3939
3940 * termcap.c: Don't assume sizes fit in int and never overflow.
3941 (struct termcap_buffer, tgetent): Use ptrdiff_t, not int, for sizes.
3942 (gobble_line): Check for size-calculation overflow.
3943
3944 * minibuf.c (Fread_buffer):
3945 * lread.c (intern, intern_c_string):
3946 * image.c (xpm_scan) [HAVE_NS && !HAVE_XPM]:
3947 Don't assume string length fits in int.
3948
3949 * keyboard.c (parse_tool_bar_item):
3950 * gtkutil.c (style_changed_cb): Avoid need for strlen.
3951
3952 * font.c: Don't assume string length fits in int.
3953 (font_parse_xlfd, font_parse_fcname, font_unparse_fcname):
3954 Use ptrdiff_t, not int.
3955 (font_intern_prop): Don't assume string length fits in int.
3956 Don't assume integer property fits in fixnum.
3957 * font.h (font_intern_prop): 2nd arg is now ptrdiff_t, not int.
3958
3959 * filelock.c: Fix some buffer overrun and integer overflow issues.
3960 (get_boot_time): Don't assume gzip command string fits in 100 bytes.
3961 Reformulate so as not to need the command string.
3962 Invoke gzip -cd rather than gunzip, as it's more portable.
3963 (lock_info_type, lock_file_1, lock_file):
3964 Don't assume pid_t and time_t fit in unsigned long.
3965 (LOCK_PID_MAX): Remove; we now use more-reliable bounds.
3966 (current_lock_owner): Prefer signed type for sizes.
3967 Use memcpy, not strncpy, where memcpy is what is really wanted.
3968 Don't assume (via atoi) that time_t and pid_t fit in int.
3969 Check for time_t and/or pid_t out of range, e.g., via a network share.
3970 Don't alloca where an auto var works fine.
3971
3972 * fileio.c: Fix some integer overflow issues.
3973 (file_name_as_directory, Fexpand_file_name, Fsubstitute_in_file_name):
3974 Don't assume string length fits in int.
3975 (directory_file_name): Don't assume string length fits in long.
3976 (make_temp_name): Don't assume pid fits in int, or that its print
3977 length is less than 20.
3978
3979 * data.c (Fsubr_name): Rewrite to avoid a strlen call.
3980
3981 * coding.c (make_subsidiaries): Don't assume string length fits in int.
3982
3983 * callproc.c (child_setup): Rewrite to avoid two strlen calls.
3984
3985 * process.c (Fformat_network_address): Use EMACS_INT, not EMACS_UINT.
3986 We prefer signed integers, even for size calculations.
3987
3988 * emacs.c: Don't assume string length fits in 'int'.
3989 (DEFINE_DUMMY_FUNCTION, sort_args): Use ptrdiff_t, not int.
3990 (main): Don't invoke strlen when not needed.
3991
3992 * dbusbind.c (XD_ERROR): Don't arbitrarily truncate string.
3993 (XD_DEBUG_MESSAGE): Don't waste a byte.
3994
3995 * callproc.c (getenv_internal_1, getenv_internal)
3996 (Fgetenv_internal):
3997 * buffer.c (init_buffer): Don't assume string length fits in 'int'.
3998
3999 * lread.c (invalid_syntax): Omit length argument.
4000 All uses changed. This doesn't fix a bug, but it simplifies the
4001 code away from its former Hollerith-constant appearance, and it's
4002 one less 'int' to worry about when looking at integer-overflow issues.
4003 (string_to_number): Simplify 2011-04-26 change by invoking xsignal1.
4004
4005 * lisp.h (DEFUN): Remove bogus use of sizeof (struct Lisp_Subr).
4006 This didn't break anything, but it didn't help either.
4007 It's confusing to put a bogus integer in a place where the actual
4008 value does not matter.
4009 (LIST_END_P): Remove unused macro and its bogus comment.
4010 (make_fixnum_or_float): Remove unnecessary cast to EMACS_INT.
4011
4012 * lisp.h (union Lisp_Object.i): EMACS_INT, not EMACS_UINT.
4013 This is for consistency with the ordinary, non-USE_LISP_UNION_TYPE,
4014 implementation.
4015 (struct Lisp_Bool_Vector.size): EMACS_INT, not EMACS_UINT.
4016 We prefer signed types, and the value cannot exceed the EMACS_INT
4017 range anyway (because otherwise the length would not be representable).
4018 (XSET) [USE_LISP_UNION_TYPE]: Use uintptr_t and intptr_t,
4019 not EMACS_UINT and EMACS_INT, when converting pointer to integer.
4020 This avoids a GCC warning when WIDE_EMACS_INT.
4021
4022 * indent.c (sane_tab_width): New function.
4023 (current_column, scan_for_column, Findent_to, position_indentation)
4024 (compute_motion): Use it. This is just for clarity.
4025 (Fcompute_motion): Don't assume hscroll and tab offset fit in int.
4026
4027 * image.c (xbm_image_p): Don't assume stated width, height fit in int.
4028
4029 * lisp.h (lint_assume): New macro.
4030 * composite.c (composition_gstring_put_cache):
4031 * ftfont.c (ftfont_shape_by_flt): Use it to pacify GCC 4.6.0.
4032
4033 * editfns.c, insdel.c:
4034 Omit unnecessary forward decls, to simplify future changes.
4035
4036 * ftfont.c (ftfont_shape_by_flt): Use signed integers for lengths.
4037
4038 * font.c (Ffont_shape_gstring): Don't assume glyph len fits in 'int'.
4039
4040 * fns.c (Ffillarray): Don't assume bool vector size fits in 'int'.
4041 Use much-faster test for byte-length change.
4042 Don't assume string byte-length fits in 'int'.
4043 Check that character arg fits in 'int'.
4044 (mapcar1): Declare byte as byte, for clarity.
4045
4046 * alloc.c (Fmake_bool_vector): Avoid unnecessary multiplication.
4047
4048 * fns.c (concat): Catch string overflow earlier.
4049 Do not rely on integer wraparound.
4050
4051 * dispextern.h (struct it.overlay_strings_charpos)
4052 (struct it.selective): Now EMACS_INT, not int.
4053 * xdisp.c (forward_to_next_line_start)
4054 (back_to_previous_visible_line_start)
4055 (reseat_at_next_visible_line_start, next_element_from_buffer):
4056 Don't arbitrarily truncate the value of 'selective' to int.
4057
4058 * xdisp.c (init_iterator): Use XINT, not XFASTINT; it might be < 0.
4059
4060 * composite.c: Don't truncate sizes to 'int'.
4061 (composition_gstring_p, composition_reseat_it)
4062 (composition_adjust_point): Use EMACS_INT, not int.
4063 (get_composition_id, composition_gstring_put_cache): Use EMACS_INT,
4064 not EMACS_UINT, for indexes.
4065
4066 * category.h (CATEGORY_SET_P): Remove unnecessary cast to EMACS_INT.
4067
4068 * buffer.c: Include <verify.h>.
4069 (struct sortvec.priority, struct sortstr.priority):
4070 Now EMACS_INT, not int.
4071 (compare_overlays, cmp_for_strings): Avoid subtraction overflow.
4072 (struct sortstr.size, record_overlay_string)
4073 (struct sortstrlist.size, struct sortlist.used):
4074 Don't truncate size to int.
4075 (record_overlay_string): Check for size-calculation overflow.
4076 (init_buffer_once): Check at compile-time, not run-time.
4077
4078 2011-06-22 Jim Meyering <meyering@redhat.com>
4079
4080 Don't leak an XBM-image-sized buffer
4081 * image.c (xbm_load): Free the image buffer after using it.
4082
4083 2011-06-21 Paul Eggert <eggert@cs.ucla.edu>
4084
4085 Port to Sun C.
4086 * composite.c (find_automatic_composition): Omit needless 'return 0;'
4087 that Sun C diagnosed.
4088 * fns.c (secure_hash): Fix pointer signedness issue.
4089 * intervals.c (static_offset_intervals): New function.
4090 (offset_intervals): Use it.
4091
4092 2011-06-21 Leo Liu <sdl.web@gmail.com>
4093
4094 * deps.mk (fns.o):
4095 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha256.h and
4096 sha512.h.
4097
4098 * fns.c (secure_hash): Rename from crypto_hash_function and change
4099 the first arg to accept symbols.
4100 (Fsecure_hash): New primitive.
4101 (syms_of_fns): New symbols.
4102
4103 2011-06-20 Deniz Dogan <deniz@dogan.se>
4104
4105 * process.c (Fset_process_buffer): Clarify return value in
4106 docstring.
4107
4108 2011-06-18 Chong Yidong <cyd@stupidchicken.com>
4109
4110 * dispnew.c (add_window_display_history): Use BVAR.
4111
4112 * xdisp.c (debug_method_add): Use BVAR.
4113 (check_window_end, dump_glyph_matrix, dump_glyph)
4114 (dump_glyph_row, dump_glyph_string): Convert arglist to ANSI C.
4115
4116 * xfaces.c (check_lface_attrs, check_lface, dump_realized_face):
4117 Likewise.
4118
4119 * xfns.c (Fx_create_frame, x_create_tip_frame): Delay image cache
4120 check till after the cache is created in init_frame_faces.
4121
4122 2011-06-17 Stefan Monnier <monnier@iro.umontreal.ca>
4123
4124 * fns.c (Fsafe_length): Yet another int/Lisp_Object mixup.
4125
4126 2011-06-16 Paul Eggert <eggert@cs.ucla.edu>
4127
4128 * lisp.h: Include <limits.h>, for INT_MAX, LONG_MAX, LLONG_MAX.
4129 Without this, prin1 mishandles Lisp_Misc_Save_Value printing on
4130 hosts with pre-C99 libraries, because pD is wrongly defined to "t".
4131
4132 Improve buffer-overflow checking (Bug#8873).
4133 * fileio.c (Finsert_file_contents):
4134 * insdel.c (insert_from_buffer_1, replace_range, replace_range_2):
4135 Remove the old (too-loose) buffer overflow checks.
4136 They weren't needed, since make_gap checks for buffer overflow.
4137 * insdel.c (make_gap_larger): Catch buffer overflows that were missed.
4138 The old code merely checked for Emacs fixnum overflow, and relied
4139 on undefined (wraparound) behavior. The new code avoids undefined
4140 behavior, and also checks for ptrdiff_t and/or size_t overflow.
4141
4142 * editfns.c (Finsert_char): Don't dump core with very negative counts.
4143 Tune. Don't use wider integers than needed. Don't use alloca.
4144 Use a bigger 'string' buffer. Rewrite to avoid 'n > 0' test.
4145
4146 * insdel.c (replace_range): Fix buf overflow when insbytes < outgoing.
4147
4148 * insdel.c, lisp.h (buffer_overflow): New function.
4149 (insert_from_buffer_1, replace_range, replace_range_2):
4150 * insdel.c (make_gap_larger):
4151 * editfns.c (Finsert_char):
4152 * fileio.c (Finsert_file_contents): Use it, to normalize wording.
4153
4154 * buffer.h (BUF_BYTES_MAX): Cast to ptrdiff_t so that it's signed.
4155
4156 2011-06-15 Paul Eggert <eggert@cs.ucla.edu>
4157
4158 Integer overflow and signedness fixes (Bug#8873).
4159
4160 * ccl.c (ASCENDING_ORDER): New macro, to work around GCC bug 43772.
4161 (GET_CCL_RANGE, IN_INT_RANGE): Use it.
4162
4163 * fileio.c: Don't assume EMACS_INT fits in off_t.
4164 (emacs_lseek): New static function.
4165 (Finsert_file_contents, Fwrite_region): Use it.
4166 Use SEEK_SET, SEEK_CUR, SEEK_END as appropriate.
4167
4168 * fns.c (Fload_average): Don't assume 100 * load average fits in int.
4169
4170 * fns.c: Don't overflow int when computing a list length.
4171 * fns.c (QUIT_COUNT_HEURISTIC): New constant.
4172 (Flength, Fsafe_length): Use EMACS_INT, not int, to avoid unwanted
4173 truncation on 64-bit hosts. Check for QUIT every
4174 QUIT_COUNT_HEURISTIC entries rather than every other entry; that's
4175 faster and is responsive enough.
4176 (Flength): Report an error instead of overflowing an integer.
4177 (Fsafe_length): Return a float if the value is not representable
4178 as a fixnum. This shouldn't happen except in contrived situations.
4179 (Fnthcdr, Fsort): Don't assume list length fits in int.
4180 (Fcopy_sequence): Don't assume vector length fits in int.
4181
4182 * alloc.c: Check that resized vectors' lengths fit in fixnums.
4183 (header_size, word_size): New constants.
4184 (allocate_vectorlike): Don't check size overflow here.
4185 (allocate_vector): Check it here instead, since this is the only
4186 caller of allocate_vectorlike that could cause overflow.
4187 Check that the new vector's length is representable as a fixnum.
4188
4189 * fns.c (next_almost_prime): Don't return a multiple of 3 or 5.
4190 The previous code was bogus. For example, next_almost_prime (32)
4191 returned 39, which is undesirable as it is a multiple of 3; and
4192 next_almost_prime (24) returned 25, which is a multiple of 5 so
4193 why was the code bothering to check for multiples of 7?
4194
4195 * bytecode.c (exec_byte_code): Use ptrdiff_t, not int, for vector length.
4196
4197 * eval.c, doprnt.c (SIZE_MAX): Remove; inttypes.h defines this now.
4198
4199 Variadic C functions now count arguments with ptrdiff_t.
4200 This partly undoes my 2011-03-30 change, which replaced int with size_t.
4201 Back then I didn't know that the Emacs coding style prefers signed int.
4202 Also, in the meantime I found a few more instances where arguments
4203 were being counted with int, which may truncate counts on 64-bit
4204 machines, or EMACS_INT, which may be unnecessarily wide.
4205 * lisp.h (struct Lisp_Subr.function.aMANY)
4206 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call):
4207 Arg counts are now ptrdiff_t, not size_t.
4208 All variadic functions and their callers changed accordingly.
4209 (struct gcpro.nvars): Now size_t, not size_t. All uses changed.
4210 * bytecode.c (exec_byte_code): Check maxdepth for overflow,
4211 to avoid potential buffer overrun. Don't assume arg counts fit in 'int'.
4212 * callint.c (Fcall_interactively): Check arg count for overflow,
4213 to avoid potential buffer overrun. Use signed char, not 'int',
4214 for 'varies' array, so that we needn't bother to check its size
4215 calculation for overflow.
4216 * editfns.c (Fformat): Use ptrdiff_t, not EMACS_INT, to count args.
4217 * eval.c (apply_lambda):
4218 * fns.c (Fmapconcat): Use XFASTINT, not XINT, to get args length.
4219 (struct textprop_rec.argnum): Now ptrdiff_t, not int. All uses changed.
4220 (mapconcat): Use ptrdiff_t, not int and EMACS_INT, to count args.
4221
4222 * callint.c (Fcall_interactively): Don't use index var as event count.
4223
4224 * vm-limit.c (check_memory_limits): Fix incorrect extern function decls.
4225 * mem-limits.h (SIZE): Remove; no longer used.
4226
4227 * xterm.c (x_alloc_nearest_color_1): Prefer int to long when int works.
4228
4229 Remove unnecessary casts.
4230 * xterm.c (x_term_init):
4231 * xfns.c (x_set_border_pixel):
4232 * widget.c (create_frame_gcs): Remove casts to unsigned long etc.
4233 These aren't needed now that we assume ANSI C.
4234
4235 * sound.c (Fplay_sound_internal): Remove cast to unsigned long.
4236 It's more likely to cause problems (due to unsigned overflow)
4237 than to cure them.
4238
4239 * dired.c (Ffile_attributes): Don't use 32-bit hack on 64-bit hosts.
4240
4241 * unexelf.c (unexec): Don't assume BSS addr fits in unsigned.
4242
4243 * xterm.c (handle_one_xevent): Omit unnecessary casts to unsigned.
4244
4245 * keyboard.c (modify_event_symbol): Don't limit alist len to UINT_MAX.
4246
4247 * lisp.h (CHAR_TABLE_SET): Omit now-redundant test.
4248
4249 * lread.c (Fload): Don't compare a possibly-garbage time_t value.
4250
4251 GLYPH_CODE_FACE returns EMACS_INT, not int.
4252 * dispextern.h (merge_faces):
4253 * xfaces.c (merge_faces):
4254 * xdisp.c (get_next_display_element, next_element_from_display_vector):
4255 Don't assume EMACS_INT fits in int.
4256
4257 * character.h (CHAR_VALID_P): Remove unused parameter.
4258 * fontset.c, lisp.h, xdisp.c: All uses changed.
4259
4260 * editfns.c (Ftranslate_region_internal): Omit redundant test.
4261
4262 * fns.c (concat): Minor tuning based on overflow analysis.
4263 This doesn't fix any bugs. Use int to hold character, instead
4264 of constantly refetching from Emacs object. Use XFASTINT, not
4265 XINT, for value known to be a character. Don't bother comparing
4266 a single byte to 0400, as it's always less.
4267
4268 * floatfns.c (Fexpt):
4269 * fileio.c (make_temp_name): Omit unnecessary cast to unsigned.
4270
4271 * editfns.c (Ftranslate_region_internal): Use int, not EMACS_INT
4272 for characters.
4273
4274 * doc.c (get_doc_string): Omit (unsigned)c that mishandled negatives.
4275
4276 * data.c (Faset): If ARRAY is a string, check that NEWELT is a char.
4277 Without this fix, on a 64-bit host (aset S 0 4294967386) would
4278 incorrectly succeed when S was a string, because 4294967386 was
4279 truncated before it was used.
4280
4281 * chartab.c (Fchar_table_range): Use CHARACTERP to check range.
4282 Otherwise, an out-of-range integer could cause undefined behavior
4283 on a 64-bit host.
4284
4285 * composite.c: Use int, not EMACS_INT, for characters.
4286 (fill_gstring_body, composition_compute_stop_pos): Use int, not
4287 EMACS_INT, for values that are known to be in character range.
4288 This doesn't fix any bugs but is the usual style inside Emacs and
4289 may generate better code on 32-bit machines.
4290
4291 Make sure a 64-bit char is never passed to ENCODE_CHAR.
4292 This is for reasons similar to the recent CHAR_STRING fix.
4293 * charset.c (Fencode_char): Check that character arg is actually
4294 a character. Pass an int to ENCODE_CHAR.
4295 * charset.h (ENCODE_CHAR): Verify that the character argument is no
4296 wider than 'int', as a compile-time check to prevent future regressions
4297 in this area.
4298
4299 * character.c (char_string): Remove unnecessary casts.
4300
4301 Make sure a 64-bit char is never passed to CHAR_STRING.
4302 Otherwise, CHAR_STRING would do the wrong thing on a 64-bit platform,
4303 by silently ignoring the top 32 bits, allowing some values
4304 that were far too large to be valid characters.
4305 * character.h: Include <verify.h>.
4306 (CHAR_STRING, CHAR_STRING_ADVANCE): Verify that the character
4307 arguments are no wider than unsigned, as a compile-time check
4308 to prevent future regressions in this area.
4309 * data.c (Faset):
4310 * editfns.c (Fchar_to_string, general_insert_function, Finsert_char)
4311 (Fsubst_char_in_region):
4312 * fns.c (concat):
4313 * xdisp.c (decode_mode_spec_coding):
4314 Adjust to CHAR_STRING's new requirement.
4315 * editfns.c (Finsert_char, Fsubst_char_in_region):
4316 * fns.c (concat): Check that character args are actually
4317 characters. Without this test, these functions did the wrong
4318 thing with wildly out-of-range values on 64-bit hosts.
4319
4320 Remove incorrect casts to 'unsigned' that lose info on 64-bit hosts.
4321 These casts should not be needed on 32-bit hosts, either.
4322 * keyboard.c (read_char):
4323 * lread.c (Fload): Remove casts to unsigned.
4324
4325 * lisp.h (UNSIGNED_CMP): New macro.
4326 This fixes comparison bugs on 64-bit hosts.
4327 (ASCII_CHAR_P): Use it.
4328 * casefiddle.c (casify_object):
4329 * character.h (ASCII_BYTE_P, CHAR_VALID_P)
4330 (SINGLE_BYTE_CHAR_P, CHAR_STRING):
4331 * composite.h (COMPOSITION_ENCODE_RULE_VALID):
4332 * dispextern.h (FACE_FROM_ID):
4333 * keyboard.c (read_char): Use UNSIGNED_CMP.
4334
4335 * xmenu.c (dialog_selection_callback) [!USE_GTK]: Cast to intptr_t,
4336 not to EMACS_INT, to avoid GCC warning.
4337
4338 * xfns.c (x_set_scroll_bar_default_width): Remove unused 'int' locals.
4339
4340 * buffer.h (PTR_BYTE_POS, BUF_PTR_BYTE_POS): Remove harmful cast.
4341 The cast incorrectly truncated 64-bit byte offsets to 32 bits, and
4342 isn't needed on 32-bit machines.
4343
4344 * buffer.c (Fgenerate_new_buffer_name):
4345 Use EMACS_INT for count, not int.
4346 (advance_to_char_boundary): Return EMACS_INT, not int.
4347
4348 * data.c (Qcompiled_function): Now static.
4349
4350 * window.c (window_body_lines): Now static.
4351
4352 * image.c (gif_load): Rename local to avoid shadowing.
4353
4354 * lisp.h (SAFE_ALLOCA_LISP): Check for integer overflow.
4355 (struct Lisp_Save_Value): Use ptrdiff_t, not int, for 'integer' member.
4356 * alloc.c (make_save_value): Integer argument is now of type
4357 ptrdiff_t, not int.
4358 (mark_object): Use ptrdiff_t, not int.
4359 * lisp.h (pD): New macro.
4360 * print.c (print_object): Use it.
4361
4362 * alloc.c: Use EMACS_INT, not int, to count objects.
4363 (total_conses, total_markers, total_symbols, total_vector_size)
4364 (total_free_conses, total_free_markers, total_free_symbols)
4365 (total_free_floats, total_floats, total_free_intervals)
4366 (total_intervals, total_strings, total_free_strings):
4367 Now EMACS_INT, not int. All uses changed.
4368 (Fgarbage_collect): Compute overall total using a double, so that
4369 integer overflow is less likely to be a problem. Check for overflow
4370 when converting back to an integer.
4371 (n_interval_blocks, n_string_blocks, n_float_blocks, n_cons_blocks)
4372 (n_vectors, n_symbol_blocks, n_marker_blocks): Remove.
4373 These were 'int' variables that could overflow on 64-bit hosts;
4374 they were never used, so remove them instead of repairing them.
4375 (nzombies, ngcs, max_live, max_zombies): Now EMACS_INT, not 'int'.
4376 (inhibit_garbage_collection): Set gc_cons_threshold to max value.
4377 Previously, this ceilinged at INT_MAX, but that doesn't work on
4378 64-bit machines.
4379 (allocate_pseudovector): Don't use EMACS_INT when int would do.
4380
4381 * alloc.c (Fmake_bool_vector): Don't assume vector size fits in int.
4382 (allocate_vectorlike): Check for ptrdiff_t overflow.
4383 (mark_vectorlike, mark_char_table, mark_object): Avoid EMACS_UINT
4384 when a (possibly-narrower) signed value would do just as well.
4385 We prefer using signed arithmetic, to avoid comparison confusion.
4386
4387 * alloc.c: Catch some string size overflows that we were missing.
4388 (XMALLOC_OVERRUN_CHECK_SIZE) [!XMALLOC_OVERRUN_CHECK]: Define to 0,
4389 for convenience in STRING_BYTES_MAX.
4390 (STRING_BYTES_MAX): New macro, superseding the old one in lisp.h.
4391 The definition here is exact; the one in lisp.h was approximate.
4392 (allocate_string_data): Check for string overflow. This catches
4393 some instances we weren't catching before. Also, it catches
4394 size_t overflow on (unusual) hosts where SIZE_MAX <= min
4395 (PTRDIFF_MAX, MOST_POSITIVE_FIXNUM), e.g., when size_t is 32 bits
4396 and ptrdiff_t and EMACS_INT are both 64 bits.
4397
4398 * character.c, coding.c, doprnt.c, editfns.c, eval.c:
4399 All uses of STRING_BYTES_MAX replaced by STRING_BYTES_BOUND.
4400 * lisp.h (STRING_BYTES_BOUND): Rename from STRING_BYTES_MAX.
4401
4402 * character.c (string_escape_byte8): Fix nbytes/nchars typo.
4403
4404 * alloc.c (Fmake_string): Check for out-of-range init.
4405
4406 2011-06-15 Stefan Monnier <monnier@iro.umontreal.ca>
4407
4408 * eval.c (Fdefvaralias): Also mark the target as variable-special-p.
4409
4410 2011-06-14 Jan Djärv <jan.h.d@swipnet.se>
4411
4412 * xfns.c (x_set_scroll_bar_default_width): Remove argument to
4413 xg_get_default_scrollbar_width.
4414
4415 * gtkutil.c: Include emacsgtkfixed.h if HAVE_GTK3.
4416 (int_gtk_range_get_value): Move to the scroll bar part of the file.
4417 (style_changed_cb): Call update_theme_scrollbar_width and call
4418 x_set_scroll_bar_default_width and xg_frame_set_char_size for
4419 all frames (Bug#8505).
4420 (xg_create_frame_widgets): Call emacs_fixed_new if HAVE_GTK3 (Bug#8505).
4421 Call gtk_window_set_resizable if HAVE_GTK3.
4422 (x_wm_set_size_hint): Call emacs_fixed_set_min_size with min width
4423 and height if HAVE_GTK3 (Bug#8505).
4424 (scroll_bar_width_for_theme): New variable.
4425 (update_theme_scrollbar_width): New function.
4426 (xg_get_default_scrollbar_width): Move code to
4427 update_theme_scrollbar_width, just return scroll_bar_width_for_theme.
4428 (xg_initialize): Call update_theme_scrollbar_width.
4429
4430 * gtkutil.h (xg_get_default_scrollbar_width): Remove argument.
4431
4432 * emacsgtkfixed.c, emacsgtkfixed.h: New files.
4433
4434 2011-06-12 Martin Rudalics <rudalics@gmx.at>
4435
4436 * frame.c (make_frame): Call other_buffer_safely instead of
4437 other_buffer.
4438
4439 * window.c (temp_output_buffer_show): Call display_buffer with
4440 second argument Vtemp_buffer_show_specifiers and reset latter
4441 immediately after the call.
4442 (Vtemp_buffer_show_specifiers): New variable.
4443 (auto_window_vscroll_p, next_screen_context_lines)
4444 (Vscroll_preserve_screen_position): Remove leading asterisks from
4445 doc-strings.
4446
4447 2011-06-12 Paul Eggert <eggert@cs.ucla.edu>
4448
4449 Fix minor problems found by GCC 4.6.0 static checking.
4450 * buffer.c (Qclone_number): Remove for now, as it's unused.
4451 (record_buffer, Funrecord_buffer): Rename local to avoid shadowing.
4452 (record_buffer): Remove unused local.
4453 * frame.c (other_visible_frames, frame_buffer_list): Now static.
4454 (set_frame_buffer_list): Remove; unused.
4455 * frame.h (other_visible_frames): Remove decl.
4456 * keyboard.h (menu_items_inuse): Declare only if USE_GTK || USE_MOTIF.
4457 * lisp.h (frame_buffer_list, set_frame_buffer_list): Remove decls.
4458 (add_gpm_wait_descriptor, delete_gpm_wait_descriptor): Declare only
4459 if HAVE_GPM.
4460 * menu.c (menu_items_inuse): Now static unless USE_GTK || USE_MOTIF.
4461 * process.c (add_gpm_wait_descriptor, delete_gpm_wait_descriptor):
4462 Define only if HAVE_GPM.
4463 * widget.c (EmacsFrameResize, emacsFrameClassRec): Now static.
4464 (update_hints_inhibit): Remove; never set. All uses removed.
4465 * widgetprv.h (emacsFrameClassRec): Remove decl.
4466 * window.c (delete_deletable_window): Now returns void, since it
4467 wasn't returning anything.
4468 (compare_window_configurations): Remove unused locals.
4469 * xfns.c (x_set_scroll_bar_default_width): Remove unused locals.
4470 * xmenu.c (x_menu_set_in_use): Define only if USE_GTK || USE_MOTIF.
4471 (dialog_selection_callback) [!USE_GTK]: Prefer intptr_t for integers
4472 the same widths as pointers. This follows up on the 2011-05-06 patch.
4473 * xterm.c (x_alloc_lighter_color_for_widget): Define only if USE_LUCID.
4474 * xterm.h: Likewise.
4475 (x_menu_set_in_use): Declare only if USE_GTK || USE_MOTIF.
4476
4477 2011-06-12 Juanma Barranquero <lekktu@gmail.com>
4478
4479 * makefile.w32-in: Update dependencies.
4480 (LISP_H): Add lib/intprops.h.
4481
4482 2011-06-11 Chong Yidong <cyd@stupidchicken.com>
4483
4484 * image.c (gif_load): Add animation frame delay to the metadata.
4485 (syms_of_image): Use DEFSYM. New symbol `delay'.
4486
4487 2011-06-11 Martin Rudalics <rudalics@gmx.at>
4488
4489 * window.c (delete_deletable_window): Re-add.
4490 (Fset_window_configuration): Rewrite to handle dead buffers and
4491 consequently deletable windows.
4492 (window_tree, Fwindow_tree): Remove. Supply functionality in
4493 window.el.
4494 (compare_window_configurations): Simplify code.
4495
4496 2011-06-11 Andreas Schwab <schwab@linux-m68k.org>
4497
4498 * image.c (imagemagick_load_image): Fix type mismatch.
4499 (Fimagemagick_types): Likewise.
4500
4501 * window.h (replace_buffer_in_windows): Declare.
4502
4503 2011-06-11 Martin Rudalics <rudalics@gmx.at>
4504
4505 * buffer.c: New Lisp objects Qbuffer_list_update_hook and
4506 Qclone_number. Remove external declaration of Qdelete_window.
4507 (Fbuffer_list): Rewrite doc-string. Minor restructuring of
4508 code.
4509 (Fget_buffer_create, Fmake_indirect_buffer, Frename_buffer):
4510 Run Qbuffer_list_update_hook if allowed.
4511 (Fother_buffer): Rewrite doc-string. Major rewrite for new
4512 buffer list implementation.
4513 (other_buffer_safely): New function.
4514 (Fkill_buffer): Replace call to replace_buffer_in_all_windows by
4515 calls to replace_buffer_in_windows and
4516 replace_buffer_in_windows_safely. Run Qbuffer_list_update_hook
4517 if allowed.
4518 (record_buffer): Inhibit quitting and rewrite using quittable
4519 functions. Run Qbuffer_list_update_hook if allowed.
4520 (Frecord_buffer, Funrecord_buffer): New functions.
4521 (switch_to_buffer_1, Fswitch_to_buffer): Remove.
4522 Move switch-to-buffer to window.el.
4523 (bury-buffer): Move to window.el.
4524 (Vbuffer_list_update_hook): New variable.
4525
4526 * lisp.h (other_buffer_safely): Add prototype in buffer.c
4527 section.
4528
4529 * window.h (resize_frame_windows): Move up in code.
4530 (Fwindow_frame): Remove EXFUN.
4531 (replace_buffer_in_all_windows): Remove prototype.
4532 (replace_buffer_in_windows_safely): Add prototype.
4533
4534 * window.c: Declare Qdelete_window static again. Move down
4535 declaration of select_count.
4536 (Fnext_window, Fprevious_window): Rewrite doc-strings.
4537 (Fother_window): Move to window.el.
4538 (window_loop): Remove DELETE_BUFFER_WINDOWS and UNSHOW_BUFFER
4539 cases. Add REPLACE_BUFFER_IN_WINDOWS_SAFELY case.
4540 (Fdelete_windows_on, Freplace_buffer_in_windows): Move to
4541 window.el.
4542 (replace_buffer_in_windows): Implement by calling
4543 Qreplace_buffer_in_windows.
4544 (replace_buffer_in_all_windows): Remove with some functionality
4545 moved into replace_buffer_in_windows_safely.
4546 (replace_buffer_in_windows_safely): New function.
4547 (select_window_norecord, select_frame_norecord): Move in front
4548 of run_window_configuration_change_hook. Remove now obsolete
4549 declarations.
4550 (Fset_window_buffer): Rewrite doc-string.
4551 Call Qrecord_window_buffer.
4552 (keys_of_window): Move binding for other-window to window.el.
4553
4554 2011-06-11 Chong Yidong <cyd@stupidchicken.com>
4555
4556 * dispextern.h (struct image): Replace data member, whose int_val
4557 and ptr_val fields were not used by anything, with a single
4558 lisp_val object.
4559
4560 * image.c (Fimage_metadata, make_image, mark_image, tiff_load)
4561 (gif_clear_image, gif_load, imagemagick_load_image)
4562 (gs_clear_image, gs_load): Callers changed.
4563
4564 2011-06-10 Paul Eggert <eggert@cs.ucla.edu>
4565
4566 * buffer.h: Include <time.h>, for time_t.
4567 Needed to build on FreeBSD 8.2. Problem reported by Herbert J. Skuhra.
4568
4569 Fix minor problems found by static checking.
4570
4571 * image.c (PixelGetMagickColor): Declare if ImageMagick headers don't.
4572
4573 Make identifiers static if they are not used in other modules.
4574 * data.c (Qcompiled_function, Qframe, Qvector):
4575 * image.c (QimageMagick, Qsvg):
4576 * minibuf.c (Qmetadata):
4577 * window.c (resize_window_check, resize_root_window): Now static.
4578 * window.h (resize_window_check, resize_root_window): Remove decls.
4579
4580 * window.c (window_deletion_count, delete_deletable_window):
4581 Remove; unused.
4582 (window_body_lines): Now static.
4583 (Fdelete_other_windows_internal): Mark vars as initialized.
4584 Make sure 'resize_failed' is initialized.
4585 (run_window_configuration_change_hook): Rename local to avoid shadowing.
4586 (resize_window_apply): Remove unused local.
4587 * window.h (delete_deletable_window): Remove decl.
4588
4589 * image.c (gif_load, svg_load_image): Rename locals to avoid shadowing.
4590 (imagemagick_load_image): Fix pointer signedness problem by changing
4591 last arg from unsigned char * to char *. All uses changed.
4592 Also, fix a local for similar reasons.
4593 Remove unused locals. Remove locals to avoid shadowing.
4594 (fn_rsvg_handle_free): Remove; unused.
4595 (svg_load, svg_load_image): Fix pointer signedness problem.
4596 (imagemagick_load_image): Don't use garbage pointer image_wand.
4597
4598 * ftfont.c (ftfont_get_metrics, ftfont_drive_otf): Remove unused locals.
4599
4600 2011-06-10 Chong Yidong <cyd@stupidchicken.com>
4601
4602 * image.c (gif_load): Fix omitted cast error introduced by
4603 2011-06-06 change.
4604
4605 2011-06-10 Martin Rudalics <rudalics@gmx.at>
4606
4607 * window.h (resize_proportionally, orig_total_lines)
4608 (orig_top_line): Remove from window structure.
4609 (set_window_height, set_window_width, change_window_heights)
4610 (Fdelete_window): Remove prototypes.
4611 (resize_frame_windows): Remove duplicate declaration.
4612
4613 2011-06-10 Eli Zaretskii <eliz@gnu.org>
4614
4615 * window.h (resize_frame_windows, resize_window_check)
4616 (delete_deletable_window, resize_root_window)
4617 (resize_frame_windows): Declare prototypes.
4618
4619 * window.c (resize_window_apply): Make definition be "static" to
4620 match the prototype.
4621
4622 2011-06-10 Martin Rudalics <rudalics@gmx.at>
4623
4624 * window.c: Remove declarations of Qwindow_size_fixed,
4625 window_min_size_1, window_min_size_2, window_min_size,
4626 size_window, window_fixed_size_p, enlarge_window, delete_window.
4627 Remove static from declaration of Qdelete_window, it's
4628 temporarily needed by Fbury_buffer.
4629 (replace_window): Don't assign orig_top_line and
4630 orig_total_lines.
4631 (Fdelete_window, delete_window): Remove. Window deletion is
4632 handled by window.el.
4633 (window_loop): Remove DELETE_OTHER_WINDOWS case.
4634 Replace Fdelete_window calls with calls to Qdelete_window.
4635 (Fdelete_other_windows): Remove. Deleting other windows is
4636 handled by window.el.
4637 (window_fixed_size_p): Remove. Fixed-sizeness of windows is
4638 handled in window.el.
4639 (window_min_size_2, window_min_size_1, window_min_size): Remove.
4640 Window minimum sizes are handled in window.el.
4641 (shrink_windows, size_window, set_window_height)
4642 (set_window_width, change_window_heights, window_height)
4643 (window_width, CURBEG, CURSIZE, enlarge_window)
4644 (adjust_window_trailing_edge, Fadjust_window_trailing_edge)
4645 (Fenlarge_window, Fshrink_window): Remove. Window resizing is
4646 handled in window.el.
4647 (make_dummy_parent): Rename to make_parent_window and give it a
4648 second argument horflag.
4649 (make_window): Don't set resize_proportionally any more.
4650 (Fsplit_window): Remove. Windows are split in window.el.
4651 (save_restore_action, save_restore_orig_size)
4652 (shrink_window_lowest_first, save_restore_orig_size): Remove.
4653 Resize mini windows in window.el.
4654 (grow_mini_window, shrink_mini_window): Implement by calling
4655 Qresize_root_window_vertically, resize_window_check and
4656 resize_window_apply.
4657 (saved_window, Fset_window_configuration, save_window_save):
4658 Do not handle orig_top_line, orig_total_lines, and
4659 resize_proportionally.
4660 (window_min_height, window_min_width): Move to window.el.
4661 (keys_of_window): Move bindings for delete-other-windows,
4662 split-window, delete-window and enlarge-window to window.el.
4663
4664 * buffer.c: Temporarily extern Qdelete_window.
4665 (Fbury_buffer): Temporarily call Qdelete_window instead of
4666 Fdelete_window (Fbury_buffer will move to window.el soon).
4667
4668 * frame.c (set_menu_bar_lines_1): Remove code handling
4669 orig_top_line and orig_total_lines.
4670
4671 * dispnew.c (adjust_frame_glyphs_initially): Don't use
4672 set_window_height but set heights directly.
4673 (change_frame_size_1): Use resize_frame_windows.
4674
4675 * xdisp.c (init_xdisp): Don't use set_window_height but set
4676 heights directly.
4677
4678 * xfns.c (x_set_menu_bar_lines, x_set_tool_bar_lines):
4679 Use resize_frame_windows instead of change_window_heights and run
4680 run_window_configuration_change_hook.
4681
4682 * w32fns.c (x_set_tool_bar_lines): Use resize_frame_windows
4683 instead of change_window_heights and run
4684 run_window_configuration_change_hook.
4685
4686 2011-06-09 Martin Rudalics <rudalics@gmx.at>
4687
4688 * window.c (replace_window): Rename second argument REPLACEMENT to
4689 NEW. New third argument SETFLAG. Rewrite.
4690 (delete_window, make_dummy_parent): Call replace_window with
4691 third argument 1.
4692 (window_list_1): Move down in code.
4693 (run_window_configuration_change_hook): Move set_buffer part
4694 before select_frame_norecord part in order to unwind correctly.
4695 Rename count1 to count.
4696 (recombine_windows, delete_deletable_window, resize_root_window)
4697 (Fdelete_other_windows_internal)
4698 (Frun_window_configuration_change_hook, make_parent_window)
4699 (resize_window_check, resize_window_apply, Fresize_window_apply)
4700 (resize_frame_windows, Fsplit_window_internal)
4701 (Fdelete_window_internal, Fresize_mini_window_internal):
4702 New functions.
4703 (syms_of_window): New variables Vwindow_splits and Vwindow_nest.
4704
4705 2011-06-08 Martin Rudalics <rudalics@gmx.at>
4706
4707 * window.h (window): Add some new members to window structure -
4708 normal_lines, normal_cols, new_total, new_normal, clone_number,
4709 splits, nest, prev_buffers, next_buffers.
4710 (WINDOW_TOTAL_SIZE): Move here from window.c.
4711 (MIN_SAFE_WINDOW_WIDTH, MIN_SAFE_WINDOW_HEIGHT): Define here.
4712
4713 * window.c (Fwindow_height, Fwindow_width, Fwindow_full_width_p):
4714 Remove.
4715 (make_dummy_parent): Set new members of windows structure.
4716 (make_window): Move down in code. Handle new members of window
4717 structure.
4718 (Fwindow_clone_number, Fwindow_splits, Fset_window_splits)
4719 (Fwindow_nest, Fset_window_nest, Fwindow_new_total)
4720 (Fwindow_normal_size, Fwindow_new_normal, Fwindow_prev_buffers)
4721 (Fset_window_prev_buffers, Fwindow_next_buffers)
4722 (Fset_window_next_buffers, Fset_window_clone_number):
4723 New functions.
4724 (Fwindow_hscroll, Fwindow_at, Fwindow_point, Fwindow_start)
4725 (Fwindow_end, Fwindow_line_height, Fset_window_dedicated_p):
4726 Doc-string fixes.
4727 (Fwindow_parameters, Fwindow_parameter, Fset_window_parameter):
4728 Argument WINDOW can be now internal window too.
4729 (Fwindow_use_time): Move up in code.
4730 (Fget_buffer_window): Rename argument FRAME to ALL-FRAMES.
4731 Rewrite doc-string.
4732 (Fset_window_configuration, saved_window)
4733 (Fcurrent_window_configuration, save_window_save): Handle new
4734 members of window structure.
4735 (WINDOW_TOTAL_SIZE, MIN_SAFE_WINDOW_WIDTH)
4736 (MIN_SAFE_WINDOW_HEIGHT): Move to window.h.
4737 (syms_of_window): New Lisp objects Qrecord_window_buffer,
4738 Qwindow_deletable_p, Qdelete_window, Qreplace_buffer_in_windows,
4739 Qget_mru_window, Qresize_root_window,
4740 Qresize_root_window_vertically, Qsafe, Qabove, Qbelow,
4741 Qauto_buffer_name; staticpro them.
4742
4743 2011-06-07 Martin Rudalics <rudalics@gmx.at>
4744
4745 * window.c (Fwindow_total_size, Fwindow_left_column)
4746 (Fwindow_top_line, window_body_lines, Fwindow_body_size)
4747 (Fwindow_list_1): New functions.
4748 (window_box_text_cols): Replace with window_body_cols.
4749 (Fwindow_width, Fscroll_left, Fscroll_right):
4750 Use window_body_cols instead of window_box_text_cols.
4751 (delete_window, Fset_window_configuration):
4752 Call delete_all_subwindows with window as argument.
4753 (delete_all_subwindows): Take a window as argument and not a
4754 structure. Rewrite.
4755 (window_loop): Remove handling of GET_LRU_WINDOW and
4756 GET_LARGEST_WINDOW.
4757 (Fget_lru_window, Fget_largest_window): Move to window.el.
4758
4759 * window.h: Extern window_body_cols instead of
4760 window_box_text_cols. delete_all_subwindows now takes a
4761 Lisp_Object as argument.
4762
4763 * indent.c (compute_motion, Fcompute_motion):
4764 Use window_body_cols instead of window_box_text_cols.
4765
4766 * frame.c (delete_frame): Call delete_all_subwindows with root
4767 window as argument.
4768
4769 2011-06-07 Daniel Colascione <dan.colascione@gmail.com>
4770
4771 * fns.c (Fputhash): Document return value.
4772
4773 2011-06-06 Chong Yidong <cyd@stupidchicken.com>
4774
4775 * image.c (gif_load): Implement gif89a spec "no disposal" method.
4776
4777 2011-06-06 Paul Eggert <eggert@cs.ucla.edu>
4778
4779 Cons<->int and similar integer overflow fixes (Bug#8794).
4780
4781 Check for overflow when converting integer to cons and back.
4782 * charset.c (Fdefine_charset_internal, Fdecode_char):
4783 Use cons_to_unsigned to catch overflow.
4784 (Fencode_char): Use INTEGER_TO_CONS.
4785 * composite.h (LGLYPH_CODE): Use cons_to_unsigned.
4786 (LGLYPH_SET_CODE): Use INTEGER_TO_CONS.
4787 * data.c (long_to_cons, cons_to_long): Remove.
4788 (cons_to_unsigned, cons_to_signed): New functions.
4789 These signal an error for invalid or out-of-range values.
4790 * dired.c (Ffile_attributes): Use INTEGER_TO_CONS.
4791 * fileio.c (Fset_visited_file_modtime): Use CONS_TO_INTEGER.
4792 * font.c (Ffont_variation_glyphs):
4793 * fontset.c (Finternal_char_font): Use INTEGER_TO_CONS.
4794 * lisp.h: Include <intprops.h>.
4795 (INTEGER_TO_CONS, CONS_TO_INTEGER): New macros.
4796 (cons_to_signed, cons_to_unsigned): New decls.
4797 (long_to_cons, cons_to_long): Remove decls.
4798 * undo.c (record_first_change): Use INTEGER_TO_CONS.
4799 (Fprimitive_undo): Use CONS_TO_INTEGER.
4800 * xfns.c (Fx_window_property): Likewise.
4801 * xselect.c: Include <limits.h>.
4802 (x_own_selection, selection_data_to_lisp_data):
4803 Use INTEGER_TO_CONS.
4804 (x_handle_selection_request, x_handle_selection_clear)
4805 (x_get_foreign_selection, Fx_disown_selection_internal)
4806 (Fx_get_atom_name, x_send_client_event): Use CONS_TO_INTEGER.
4807 (lisp_data_to_selection_data): Use cons_to_unsigned.
4808 (x_fill_property_data): Use cons_to_signed.
4809 Report values out of range.
4810
4811 Check for buffer and string overflow more precisely.
4812 * buffer.h (BUF_BYTES_MAX): New macro.
4813 * lisp.h (STRING_BYTES_MAX): New macro.
4814 * alloc.c (Fmake_string):
4815 * character.c (string_escape_byte8):
4816 * coding.c (coding_alloc_by_realloc):
4817 * doprnt.c (doprnt):
4818 * editfns.c (Fformat):
4819 * eval.c (verror):
4820 Use STRING_BYTES_MAX, not MOST_POSITIVE_FIXNUM,
4821 since they may not be the same number.
4822 * editfns.c (Finsert_char):
4823 * fileio.c (Finsert_file_contents):
4824 Likewise for BUF_BYTES_MAX.
4825
4826 * image.c: Use ptrdiff_t, not int, for sizes.
4827 (slurp_file): Switch from int to ptrdiff_t.
4828 All uses changed.
4829 (slurp_file): Check that file size fits in both size_t (for
4830 malloc) and ptrdiff_t (for sanity and safety).
4831
4832 * fileio.c (Fverify_visited_file_modtime): Avoid time overflow
4833 if b->modtime has its maximal value.
4834
4835 * dired.c (Ffile_attributes): Don't assume EMACS_INT has >32 bits.
4836
4837 Don't assume time_t can fit into int.
4838 * buffer.h (struct buffer.modtime): Now time_t, not int.
4839 * fileio.c (Fvisited_file_modtime): No need for time_t cast now.
4840 * undo.c (Fprimitive_undo): Use time_t, not int, for time_t value.
4841
4842 Minor fixes for signed vs unsigned integers.
4843 * character.h (MAYBE_UNIFY_CHAR):
4844 * charset.c (maybe_unify_char):
4845 * keyboard.c (read_char, reorder_modifiers):
4846 XINT -> XFASTINT, since the integer must be nonnegative.
4847 * ftfont.c (ftfont_spec_pattern):
4848 * keymap.c (access_keymap, silly_event_symbol_error):
4849 XUINT -> XFASTINT, since the integer must be nonnegative.
4850 (Fsingle_key_description, preferred_sequence_p): XUINT -> XINT,
4851 since it makes no difference and we prefer signed.
4852 * keyboard.c (record_char): Use XUINT when all the neighbors do.
4853 (access_keymap): NATNUMP -> INTEGERP, since the integer must be
4854 nonnegative.
4855
4856 2011-06-06 Stefan Monnier <monnier@iro.umontreal.ca>
4857
4858 * window.h (Fwindow_frame): Declare.
4859
4860 2011-06-06 Paul Eggert <eggert@cs.ucla.edu>
4861
4862 * alloc.c: Simplify handling of large-request failures (Bug#8800).
4863 (SPARE_MEMORY): Always define.
4864 (LARGE_REQUEST): Remove.
4865 (memory_full): Use SPARE_MEMORY rather than LARGE_REQUEST.
4866
4867 2011-06-06 Martin Rudalics <rudalics@gmx.at>
4868
4869 * lisp.h: Move EXFUNS for Fframe_root_window,
4870 Fframe_first_window and Fset_frame_selected_window to window.h.
4871
4872 * window.h: Move EXFUNS for Fframe_root_window,
4873 Fframe_first_window and Fset_frame_selected_window here from
4874 lisp.h.
4875
4876 * frame.c (Fwindow_frame, Fframe_first_window)
4877 (Fframe_root_window, Fframe_selected_window)
4878 (Fset_frame_selected_window): Move to window.c.
4879 (Factive_minibuffer_window): Move to minibuf.c.
4880 (Fother_visible_frames_p): New function.
4881
4882 * minibuf.c (Factive_minibuffer_window): Move here from frame.c.
4883
4884 * window.c (decode_window, decode_any_window): Move up in code.
4885 (Fwindowp, Fwindow_live_p): Rewrite doc-strings.
4886 (inhibit_frame_unsplittable): Remove unused variable.
4887 (Fwindow_buffer): Move up and rewrite doc-string.
4888 (Fwindow_parent, Fwindow_vchild, Fwindow_hchild, Fwindow_next)
4889 (Fwindow_prev): New functions.
4890 (Fwindow_frame): Move here from frame.c. Accept any window as
4891 argument.
4892 (Fframe_root_window, Fframe_first_window)
4893 (Fframe_selected_window): Move here from frame.c. Accept frame
4894 or arbitrary window as argument. Update doc-strings.
4895 (Fminibuffer_window): Move up in code.
4896 (Fwindow_minibuffer_p): Move up in code and simplify.
4897 (Fset_frame_selected_window): Move here from frame.c.
4898 Marginal rewrite.
4899 (Fselected_window, select_window, Fselect_window): Move up in
4900 code. Minor doc-string fixes.
4901
4902 2011-06-06 Paul Eggert <eggert@cs.ucla.edu>
4903
4904 * alloc.c (memory_full) [SYSTEM_MALLOC]: Port to MacOS (Bug#8800).
4905 Do not assume that spare memory exists; that assumption is valid
4906 only if SYSTEM_MALLOC.
4907 (LARGE_REQUEST): New macro, so that the issue of large requests
4908 is separated from the issue of spare memory.
4909
4910 2011-06-05 Andreas Schwab <schwab@linux-m68k.org>
4911
4912 * editfns.c (Fformat): Correctly handle zero flag with hexadecimal
4913 format. (Bug#8806)
4914
4915 * gtkutil.c (xg_get_default_scrollbar_width): Avoid warning.
4916
4917 * xfns.c (x_set_scroll_bar_default_width): Move declarations
4918 before statements.
4919
4920 2011-06-05 Jan Djärv <jan.h.d@swipnet.se>
4921
4922 * gtkutil.c (xg_get_default_scrollbar_width): New function.
4923
4924 * gtkutil.h: Declare xg_get_default_scrollbar_width.
4925
4926 * xfns.c (x_set_scroll_bar_default_width): If USE_GTK, get
4927 min width by calling x_set_scroll_bar_default_width (Bug#8505).
4928
4929 2011-06-05 Juanma Barranquero <lekktu@gmail.com>
4930
4931 * xdisp.c (single_display_spec_intangible_p): Remove declaration.
4932
4933 2011-06-04 Chong Yidong <cyd@stupidchicken.com>
4934
4935 * xselect.c (x_clipboard_manager_save): Remove redundant arg.
4936 (x_clipboard_manager_save): Add return value.
4937 (x_clipboard_manager_error_1, x_clipboard_manager_error_2):
4938 New error handlers.
4939 (x_clipboard_manager_save_frame, x_clipboard_manager_save_all):
4940 Obey Vx_select_enable_clipboard_manager. Catch errors in
4941 x_clipboard_manager_save (Bug#8779).
4942 (Vx_select_enable_clipboard_manager): New variable.
4943 (x_get_foreign_selection): Reduce scope of x_catch_errors (Bug#8790).
4944
4945 2011-06-04 Dan Nicolaescu <dann@ics.uci.edu>
4946
4947 * emacs.c (main): Warn when starting a GTK emacs in daemon mode.
4948
4949 2011-06-04 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
4950
4951 * fringe.c (update_window_fringes): Don't update overlay arrow bitmap
4952 in the current matrix if keep_current_p is non-zero.
4953
4954 2011-06-04 Eli Zaretskii <eliz@gnu.org>
4955
4956 * bidi.c (bidi_level_of_next_char): Fix last change.
4957
4958 2011-06-03 Eli Zaretskii <eliz@gnu.org>
4959
4960 Support bidi reordering of text covered by display properties.
4961
4962 * bidi.c (bidi_copy_it): Use offsetof instead of emulating it.
4963 (bidi_fetch_char, bidi_fetch_char_advance): New functions.
4964 (bidi_cache_search, bidi_cache_iterator_state)
4965 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak)
4966 (bidi_level_of_next_char, bidi_move_to_visually_next):
4967 Support character positions inside a run of characters covered by a
4968 display string.
4969 (bidi_paragraph_init, bidi_resolve_explicit_1)
4970 (bidi_level_of_next_char): Call bidi_fetch_char and
4971 bidi_fetch_char_advance instead of FETCH_CHAR and
4972 FETCH_CHAR_ADVANCE.
4973 (bidi_init_it): Initialize new members.
4974 (LRE_CHAR, RLE_CHAR, PDF_CHAR, LRO_CHAR, RLO_CHAR): Remove macro
4975 definitions.
4976 (bidi_explicit_dir_char): Lookup character type in bidi_type_table,
4977 instead of using explicit *_CHAR codes.
4978 (bidi_resolve_explicit, bidi_resolve_weak):
4979 Use FETCH_MULTIBYTE_CHAR instead of FETCH_CHAR, as reordering of
4980 bidirectional text is supported only in multibyte buffers.
4981 (bidi_init_it): Accept additional argument FRAME_WINDOW_P and use
4982 it to initialize the frame_window_p member of struct bidi_it.
4983 (bidi_cache_iterator_state, bidi_resolve_explicit_1)
4984 (bidi_resolve_explicit, bidi_resolve_weak)
4985 (bidi_level_of_next_char, bidi_move_to_visually_next): Abort if
4986 bidi_it->nchars is non-positive.
4987 (bidi_level_of_next_char): Don't try to lookup the cache for the
4988 next/previous character if nothing is cached there yet, or if we
4989 were just reseat()'ed to a new position.
4990
4991 * xdisp.c (set_cursor_from_row): Set start and stop points
4992 according to the row's direction when priming the loop that looks
4993 for the glyph on which to display cursor.
4994 (single_display_spec_intangible_p): Function deleted.
4995 (display_prop_intangible_p): Reimplement to call
4996 handle_display_spec instead of single_display_spec_intangible_p.
4997 Accept 3 additional arguments needed by handle_display_spec.
4998 This fixes incorrect cursor motion across display property with complex
4999 values: lists, `(when COND...)' forms, etc.
5000 (single_display_spec_string_p): Support property values that are
5001 lists with the argument STRING its top-level element.
5002 (display_prop_string_p): Fix the condition for processing a
5003 property that is a list to be consistent with handle_display_spec.
5004 (handle_display_spec): New function, refactored from the
5005 last portion of handle_display_prop.
5006 (compute_display_string_pos): Accept additional argument
5007 FRAME_WINDOW_P. Call handle_display_spec to determine whether the
5008 value of a `display' property is a "replacing spec".
5009 (handle_single_display_spec): Accept 2 additional arguments BUFPOS
5010 and FRAME_WINDOW_P. If IT is NULL, don't set up the iterator from
5011 the display property, but just return a value indicating whether
5012 the display property will replace the characters it covers.
5013 (Fcurrent_bidi_paragraph_direction): Initialize the nchars and
5014 frame_window_p members of struct bidi_it.
5015 (compute_display_string_pos, compute_display_string_end):
5016 New functions.
5017 (push_it): Accept second argument POSITION, where pop_it should
5018 jump to continue iteration.
5019 (reseat_1): Initialize bidi_it.disp_pos.
5020
5021 * keyboard.c (adjust_point_for_property): Adjust the call to
5022 display_prop_intangible_p to its new signature.
5023
5024 * dispextern.h (struct bidi_it): New member frame_window_p.
5025 (bidi_init_it): Update prototypes.
5026 (display_prop_intangible_p): Update prototype.
5027 (compute_display_string_pos, compute_display_string_end):
5028 Declare prototypes.
5029 (struct bidi_it): New members nchars and disp_pos. ch_len is now
5030 EMACS_INT.
5031
5032 2011-06-02 Paul Eggert <eggert@cs.ucla.edu>
5033
5034 Malloc failure behavior now depends on size of allocation.
5035 * alloc.c (buffer_memory_full, memory_full): New arg NBYTES.
5036 * lisp.h: Change signatures accordingly.
5037 * alloc.c, buffer.c, editfns.c, menu.c, minibuf.c, xterm.c:
5038 All callers changed. (Bug#8762)
5039
5040 * gnutls.c: Use Emacs's memory allocators.
5041 Without this change, the gnutls library would invoke malloc etc.
5042 directly, which causes problems on non-SYNC_INPUT hosts, and which
5043 runs afoul of improving memory_full behavior. (Bug#8761)
5044 (fn_gnutls_global_set_mem_functions): New macro or function pointer.
5045 (emacs_gnutls_global_init): Use it to specify xmalloc, xrealloc,
5046 xfree instead of the default malloc, realloc, free.
5047 (Fgnutls_boot): No need to check for memory allocation failure,
5048 since xmalloc does that for us.
5049
5050 Remove arbitrary limit of 2**31 entries in hash tables. (Bug#8771)
5051 * category.c (hash_get_category_set):
5052 * ccl.c (ccl_driver):
5053 * charset.c (Fdefine_charset_internal):
5054 * charset.h (struct charset.hash_index):
5055 * composite.c (get_composition_id, gstring_lookup_cache)
5056 (composition_gstring_put_cache):
5057 * composite.h (struct composition.hash_index):
5058 * dispextern.h (struct image.hash):
5059 * fns.c (next_almost_prime, larger_vector, cmpfn_eql)
5060 (cmpfn_equal, cmpfn_user_defined, hashfn_eq, hashfn_eql)
5061 (hashfn_equal, hashfn_user_defined, make_hash_table)
5062 (maybe_resize_hash_table, hash_lookup, hash_put)
5063 (hash_remove_from_table, hash_clear, sweep_weak_table, SXHASH_COMBINE)
5064 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector)
5065 (Fsxhash, Fgethash, Fputhash, Fmaphash):
5066 * image.c (make_image, search_image_cache, lookup_image)
5067 (xpm_put_color_table_h):
5068 * lisp.h (struct Lisp_Hash_Table):
5069 * minibuf.c (Ftry_completion, Fall_completions, Ftest_completion):
5070 * print.c (print): Use 'EMACS_UINT' and 'EMACS_INT'
5071 for hashes and hash indexes, instead of 'unsigned' and 'int'.
5072 * alloc.c (allocate_vectorlike):
5073 Check for overflow in vector size calculations.
5074 * ccl.c (ccl_driver):
5075 Check for overflow when converting EMACS_INT to int.
5076 * fns.c, image.c: Remove unnecessary static decls that would otherwise
5077 need to be updated by these changes.
5078 * fns.c (make_hash_table, maybe_resize_hash_table):
5079 Check for integer overflow with large hash tables.
5080 (make_hash_table, maybe_resize_hash_table, Fmake_hash_table):
5081 Prefer the faster XFLOAT_DATA to XFLOATINT where either will do.
5082 (SXHASH_REDUCE): New macro.
5083 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector):
5084 Use it instead of discarding useful hash info with large hash values.
5085 (sxhash_float): New function.
5086 (sxhash): Use it. No more need for "& INTMASK" due to above changes.
5087 * lisp.h (FIXNUM_BITS): New macro, useful for SXHASH_REDUCE etc.
5088 (MOST_NEGATIVE_FIXNUM, MOST_POSITIVE_FIXNUM, INTMASK):
5089 Rewrite to use FIXNUM_BITS, as this simplifies things.
5090 (next_almost_prime, larger_vector, sxhash, hash_lookup, hash_put):
5091 Adjust signatures to match updated version of code.
5092 (consing_since_gc): Now EMACS_INT, since a single hash table can
5093 use more than INT_MAX bytes.
5094
5095 2011-06-01 Dan Nicolaescu <dann@ics.uci.edu>
5096
5097 Make it possible to build with GCC-4.6+ -O2 -flto.
5098
5099 * emacs.c (__malloc_initialize_hook): Mark as EXTERNALLY_VISIBLE.
5100
5101 2011-06-01 Stefan Monnier <monnier@iro.umontreal.ca>
5102
5103 * minibuf.c (get_minibuffer, read_minibuf_unwind):
5104 Call minibuffer-inactive-mode.
5105
5106 2011-05-31 Juanma Barranquero <lekktu@gmail.com>
5107
5108 * makefile.w32-in ($(BLD)/data.$(O), $(BLD)/editfns.$(O)):
5109 Update dependencies.
5110
5111 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
5112
5113 * data.c (init_data): Remove code for UTS, this system is not
5114 supported anymore.
5115
5116 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
5117
5118 Don't force ./temacs to start in terminal mode.
5119
5120 * frame.c (make_initial_frame): Initialize faces in all cases, not
5121 only when CANNOT_DUMP is defined.
5122 * dispnew.c (init_display): Remove CANNOT_DUMP condition.
5123
5124 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
5125
5126 * dispnew.c (add_window_display_history): Use const for the string
5127 pointer. Remove declaration, not needed.
5128
5129 2011-05-31 Paul Eggert <eggert@cs.ucla.edu>
5130
5131 Use 'inline', not 'INLINE'.
5132 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00914.html>
5133 * alloc.c, fontset.c (INLINE): Remove.
5134 * alloc.c, bidi.c, charset.c, coding.c, dispnew.c, fns.c, image.c:
5135 * intervals.c, keyboard.c, process.c, syntax.c, textprop.c, w32term.c:
5136 * xdisp.c, xfaces.c, xterm.c: Replace all uses of INLINE with inline.
5137 * gmalloc.c (register_heapinfo): Use inline unconditionally.
5138 * lisp.h (LISP_MAKE_RVALUE): Use inline, not __inline__.
5139
5140 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
5141
5142 Make it possible to run ./temacs.
5143
5144 * callproc.c (set_initial_environment): Remove CANNOT_DUMP code,
5145 syms_of_callproc does the same thing. Remove test for
5146 "initialized", do it in the caller.
5147 * emacs.c (main): Avoid calling set_initial_environment when dumping.
5148
5149 2011-05-31 Stefan Monnier <monnier@iro.umontreal.ca>
5150
5151 * minibuf.c (Finternal_complete_buffer): Return `category' metadata.
5152 (read_minibuf): Use get_minibuffer.
5153 (syms_of_minibuf): Use DEFSYM.
5154 (Qmetadata): New var.
5155 * data.c (Qbuffer): Don't make it static.
5156 (syms_of_data): Use DEFSYM.
5157
5158 2011-05-31 Paul Eggert <eggert@cs.ucla.edu>
5159
5160 * ccl.c (CCL_CODE_RANGE): Allow negative numbers. (Bug#8751)
5161 (CCL_CODE_MIN): New macro.
5162
5163 2011-05-30 Paul Eggert <eggert@cs.ucla.edu>
5164
5165 * alloc.c (lisp_align_malloc): Omit unnecessary val==NULL tests.
5166
5167 * eval.c (Qdebug): Now static.
5168 * lisp.h (Qdebug): Remove decl. This reverts a part of the
5169 2011-04-26T11:26:05Z!dan.colascione@gmail.com that inadvertently undid part of
5170 2011-04-14T06:48:41Z!eggert@cs.ucla.edu.
5171
5172 2011-05-29 Chong Yidong <cyd@stupidchicken.com>
5173
5174 * image.c: Various fixes to ImageMagick code comments.
5175 (Fimagemagick_types): Doc fix.
5176
5177 2011-05-29 Paul Eggert <eggert@cs.ucla.edu>
5178
5179 Minor fixes prompted by GCC 4.6.0 warnings.
5180
5181 * xselect.c (converted_selections, conversion_fail_tag): Now static.
5182
5183 * emacs.c [HAVE_X_WINDOWS]: Include "xterm.h".
5184 (x_clipboard_manager_save_all): Move extern decl to ...
5185 * xterm.h: ... here, so that it can be checked for consistency.
5186
5187 2011-05-29 Chong Yidong <cyd@stupidchicken.com>
5188
5189 * xselect.c (x_clipboard_manager_save_frame)
5190 (x_clipboard_manager_save_all): New functions.
5191 (Fx_clipboard_manager_save): Lisp function deleted.
5192
5193 * emacs.c (Fkill_emacs): Call x_clipboard_manager_save_all.
5194 * frame.c (delete_frame): Call x_clipboard_manager_save_frame.
5195
5196 * xterm.h: Update prototype.
5197
5198 2011-05-28 William Xu <william.xwl@gmail.com>
5199
5200 * nsterm.m (ns_term_shutdown): Synchronize user defaults before
5201 exiting (Bug#8239).
5202
5203 2011-05-28 Jim Meyering <meyering@redhat.com>
5204
5205 Avoid a sign-extension bug in crypto_hash_function.
5206 * fns.c (to_uchar): Define.
5207 (crypto_hash_function): Use it to convert some newly-signed
5208 variables to unsigned, to avoid sign-extension bugs. For example,
5209 without this change, (md5 "truc") would evaluate to
5210 45723a2aff78ff4fff7fff1114760e62 rather than the expected
5211 45723a2af3788c4ff17f8d1114760e62. Reported by Antoine Levitt in
5212 https://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00883.html.
5213
5214 2011-05-27 Paul Eggert <eggert@cs.ucla.edu>
5215
5216 Integer overflow fixes.
5217
5218 * dbusbind.c: Serial number integer overflow fixes.
5219 (CHECK_DBUS_SERIAL_GET_SERIAL): New macro.
5220 (Fdbus_call_method_asynchronously, xd_read_message_1): Use a float
5221 to hold a serial number that is too large for a fixnum.
5222 (Fdbus_method_return_internal, Fdbus_method_error_internal):
5223 Check for serial numbers out of range. Decode any serial number
5224 that was so large that it became a float. (Bug#8722)
5225
5226 * dbusbind.c: Use XFASTINT rather than XUINT, and check for nonneg.
5227 (Fdbus_call_method, Fdbus_call_method_asynchronously):
5228 Use XFASTINT rather than XUINT when numbers are nonnegative.
5229 (xd_append_arg, Fdbus_method_return_internal):
5230 (Fdbus_method_error_internal): Likewise. Also, for unsigned
5231 arguments, check that Lisp number is nonnegative, rather than
5232 silently wrapping negative numbers around. (Bug#8722)
5233 (xd_read_message_1): Don't assume dbus_uint32_t can fit in int.
5234 (Bug#8722)
5235
5236 * data.c (arith_driver, Flsh): Avoid unnecessary casts to EMACS_UINT.
5237
5238 * ccl.c (ccl_driver): Redo slightly to avoid the need for 'unsigned'.
5239
5240 ccl: add integer overflow checks
5241 * ccl.c (CCL_CODE_MAX, GET_CCL_RANGE, GET_CCL_CODE, GET_CCL_INT):
5242 (IN_INT_RANGE): New macros.
5243 (ccl_driver): Use them to check for integer overflow when
5244 decoding a CCL program. Many of the new checks are whether XINT (x)
5245 fits in int; it doesn't always, on 64-bit hosts. The new version
5246 doesn't catch all possible integer overflows, but it's an
5247 improvement. (Bug#8719)
5248
5249 * alloc.c (make_event_array): Use XINT, not XUINT.
5250 There's no need for unsigned here.
5251
5252 * mem-limits.h (EXCEEDS_LISP_PTR) [!USE_LSB_TAG]: EMACS_UINT -> uintptr_t
5253 This follows up to the 2011-05-06 change that substituted uintptr_t
5254 for EMACS_INT. This case wasn't caught back then.
5255
5256 Rework Fformat to avoid integer overflow issues.
5257 * editfns.c: Include <float.h> unconditionally, as it's everywhere
5258 now (part of C89). Include <verify.h>.
5259 (MAX_10_EXP, CONVERTED_BYTE_SIZE): Remove; no longer needed.
5260 (pWIDE, pWIDElen, signed_wide, unsigned_wide): New defns.
5261 (Fformat): Avoid the prepass trying to compute sizes; it was only
5262 approximate and thus did not catch overflow reliably. Instead, walk
5263 through the format just once, formatting and computing sizes as we go,
5264 checking for integer overflow at every step, and allocating a larger
5265 buffer as needed. Keep track separately whether the format is
5266 multibyte. Keep only the most-recently calculated precision, rather
5267 than them all. Record whether each argument has been converted to
5268 string. Use EMACS_INT, not int, for byte and char and arg counts.
5269 Support field widths and precisions larger than INT_MAX. Avoid
5270 sprintf's undefined behavior with conversion specifications such as %#d
5271 and %.0c. Fix bug with strchr succeeding on '\0' when looking for
5272 flags. Fix bug with (format "%c" 256.0). Avoid integer overflow when
5273 formatting out-of-range floating point numbers with int
5274 formats. (Bug#8668)
5275
5276 * lisp.h (FIXNUM_OVERFLOW_P): Work even if arg is a NaN.
5277
5278 * data.c: Avoid integer truncation in expressions involving floats.
5279 * data.c: Include <intprops.h>.
5280 (arith_driver): When there's an integer overflow in an expression
5281 involving floating point, convert the integers to floating point
5282 so that the resulting value does not suffer from catastrophic
5283 integer truncation. For example, on a 64-bit host (* 4
5284 most-negative-fixnum 0.5) should yield about -4.6e+18, not zero.
5285 Do not rely on undefined behavior after integer overflow.
5286
5287 merge count_size_as_multibyte, parse_str_to_multibyte
5288 * character.c, character.h (count_size_as_multibyte):
5289 Rename from parse_str_to_multibyte; all uses changed.
5290 Check for integer overflow.
5291 * insdel.c, lisp.h (count_size_as_multibyte): Remove,
5292 since it's now a duplicate of the other. This is more of
5293 a character than a buffer op, so better that it's in character.c.
5294 * fns.c, print.c: Adjust to above changes.
5295
5296 2011-05-27 Stefan Monnier <monnier@iro.umontreal.ca>
5297
5298 * xselect.c (x_convert_selection): Yet another int/Lisp_Object mixup.
5299
5300 2011-05-27 Paul Eggert <eggert@cs.ucla.edu>
5301
5302 * xselect.c: Fix minor problems prompted by GCC 4.6.0 warnings.
5303 (x_handle_selection_request, frame_for_x_selection): Remove unused vars.
5304 (x_clipboard_manager_save): Now static.
5305 (Fx_clipboard_manager_save): Rename local to avoid shadowing.
5306
5307 * fns.c: Fix minor problems prompted by GCC 4.6.0 warnings.
5308 (crypto_hash_function): Now static.
5309 Fix pointer signedness problems. Avoid unnecessary initializations.
5310
5311 2011-05-27 Chong Yidong <cyd@stupidchicken.com>
5312
5313 * termhooks.h (Vselection_alist): Make it terminal-local.
5314
5315 * terminal.c (create_terminal): Initialize it.
5316
5317 * xselect.c: Support for clipboard managers.
5318 (Vselection_alist): Move to termhooks.h as terminal-local var.
5319 (LOCAL_SELECTION): New macro.
5320 (x_atom_to_symbol): Handle x_display_info_for_display fail case.
5321 (symbol_to_x_atom): Remove gratuitous arg.
5322 (x_handle_selection_request, lisp_data_to_selection_data)
5323 (x_get_foreign_selection, Fx_register_dnd_atom): Callers changed.
5324 (x_own_selection, x_get_local_selection, x_convert_selection):
5325 New arg, specifying work frame. Use terminal-local Vselection_alist.
5326 (some_frame_on_display): Delete unused function.
5327 (Fx_own_selection_internal, Fx_get_selection_internal)
5328 (Fx_disown_selection_internal, Fx_selection_owner_p)
5329 (Fx_selection_exists_p): New optional frame arg.
5330 (frame_for_x_selection, Fx_clipboard_manager_save): New functions.
5331 (x_handle_selection_clear): Don't treat other terminals with the
5332 same keyboard specially. Use the terminal-local Vselection_alist.
5333 (x_clear_frame_selections): Use Frun_hook_with_args.
5334
5335 * xterm.c (x_term_init): Intern ATOM and CLIPBOARD_MANAGER atoms.
5336
5337 * xterm.h: Add support for those atoms.
5338
5339 2011-05-26 Chong Yidong <cyd@stupidchicken.com>
5340
5341 * xselect.c: ICCCM-compliant handling of MULTIPLE targets.
5342 (converted_selections, conversion_fail_tag): New global variables.
5343 (x_selection_request_lisp_error): Free the above.
5344 (x_get_local_selection): Remove unnecessary code.
5345 (x_reply_selection_request): Args changed; handle arbitrary array
5346 of converted selections stored in converted_selections.
5347 Separate the XChangeProperty and SelectionNotify steps.
5348 (x_handle_selection_request): Rewrite to handle MULTIPLE target.
5349 (x_convert_selection): New function.
5350 (x_handle_selection_event): Simplify.
5351 (x_get_foreign_selection): Don't ignore incoming requests while
5352 waiting for an answer; this will fail when we implement
5353 SAVE_TARGETS, and seems unnecessary anyway.
5354 (selection_data_to_lisp_data): Recognize ATOM_PAIR type.
5355 (Vx_sent_selection_functions): Doc fix.
5356
5357 2011-05-26 Leo Liu <sdl.web@gmail.com>
5358
5359 * editfns.c (Ftranspose_regions): Allow empty regions. (Bug#8699)
5360
5361 2011-05-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
5362
5363 * dispextern.h (struct glyph_row): New member fringe_bitmap_periodic_p.
5364
5365 * dispnew.c (shift_glyph_matrix, scrolling_window): Mark scrolled row
5366 for fringe update if it has periodic bitmap.
5367 (row_equal_p): Also compare left_fringe_offset, right_fringe_offset,
5368 and fringe_bitmap_periodic_p.
5369
5370 * fringe.c (get_fringe_bitmap_data): New function.
5371 (draw_fringe_bitmap_1, update_window_fringes): Use it.
5372 (update_window_fringes): Record periodicity of fringe bitmap in glyph
5373 row. Mark glyph row for fringe update if periodicity changed.
5374
5375 * xdisp.c (try_window_reusing_current_matrix): Don't mark scrolled row
5376 for fringe update unless it has periodic bitmap.
5377
5378 2011-05-25 Kenichi Handa <handa@m17n.org>
5379
5380 * xdisp.c (get_next_display_element): Set correct it->face_id for
5381 a static composition.
5382
5383 2011-05-24 Leo Liu <sdl.web@gmail.com>
5384
5385 * deps.mk (fns.o):
5386 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha1.h.
5387
5388 * fns.c (crypto_hash_function, Fsha1): New function.
5389 (Fmd5): Use crypto_hash_function.
5390 (syms_of_fns): Add Ssha1.
5391
5392 2011-05-22 Paul Eggert <eggert@cs.ucla.edu>
5393
5394 * gnutls.c: Remove unused macros.
5395 (fn_gnutls_transport_set_lowat, fn_gnutls_transport_set_pull_function):
5396 (fn_gnutls_transport_set_push_function) [!WINDOWSNT]:
5397 Remove macros that are defined and never used.
5398 Caught by gcc -Wunused-macros (GCC 4.6.0, Fedora 14).
5399
5400 2011-05-22 Chong Yidong <cyd@stupidchicken.com>
5401
5402 * xselect.c (syms_of_xselect): Remove unused symbol SAVE_TARGETS.
5403 (Fx_get_selection_internal): Minor cleanup.
5404 (Fx_own_selection_internal): Rename arguments for consistency with
5405 select.el.
5406
5407 2011-05-22 Paul Eggert <eggert@cs.ucla.edu>
5408
5409 * xselect.c (QSAVE_TARGETS): New static var, to fix build failure.
5410
5411 2011-05-22 Chong Yidong <cyd@stupidchicken.com>
5412
5413 * xselect.c (syms_of_xselect): Include character.h; use DEFSYM.
5414
5415 2011-05-21 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
5416
5417 * dispnew.c (scrolling_window): Don't exclude the case that the
5418 last enabled row in the desired matrix touches the bottom boundary.
5419
5420 2011-05-21 Glenn Morris <rgm@gnu.org>
5421
5422 * Makefile.in ($(etc)/DOC): Make second command line even shorter.
5423 (SOME_MACHINE_OBJECTS): Replace FONT_OBJ by its maximal expansion,
5424 and add some more files.
5425
5426 2011-05-20 Eli Zaretskii <eliz@gnu.org>
5427
5428 * callproc.c (Fcall_process) [MSDOS]: Fix arguments to
5429 report_file_error introduced by the change from 2011-05-07.
5430
5431 2011-05-20 Paul Eggert <eggert@cs.ucla.edu>
5432
5433 * systime.h (Time): Define only if emacs is defined.
5434 This is to allow ../lib-src/profile.c to be compiled on FreeBSD,
5435 where the include path doesn't have X11/X.h by default. See
5436 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00561.html>.
5437
5438 2011-05-20 Kenichi Handa <handa@m17n.org>
5439
5440 * composite.c (find_automatic_composition): Fix previous change.
5441
5442 2011-05-20 Glenn Morris <rgm@gnu.org>
5443
5444 * lisp.mk: New file, split from Makefile.in.
5445 * Makefile.in (lisp): Move to separate file, inserted by @lisp_frag@.
5446 (shortlisp): Remove.
5447 ($(etc)/DOC): Edit lisp.mk rather than using $shortlisp.
5448
5449 2011-05-19 Glenn Morris <rgm@gnu.org>
5450
5451 * Makefile.in (MSDOS_SUPPORT_REAL, MSDOS_SUPPORT, NS_SUPPORT)
5452 (REAL_MOUSE_SUPPORT, GPM_MOUSE_SUPPORT, MOUSE_SUPPORT, TOOLTIP_SUPPORT)
5453 (BASE_WINDOW_SUPPORT, X_WINDOW_SUPPORT, WINDOW_SUPPORT): Remove.
5454 (lisp): Set the order to that of loadup.el.
5455 (shortlisp): Make it a copy of $lisp.
5456 (SOME_MACHINE_LISP): Remove.
5457 ($(etc)/DOC): Depend just on $lisp, not $SOME_MACHINE_LISP too.
5458 Use just $shortlisp, not $SOME_MACHINE_LISP too.
5459
5460 2011-05-18 Kenichi Handa <handa@m17n.org>
5461
5462 * composite.c (CHAR_COMPOSABLE_P): Add more check for efficiency.
5463 (BACKWARD_CHAR): Wrap the arg STOP by parenthesis.
5464 (find_automatic_composition): Mostly rewrite for efficiency.
5465
5466 2011-05-18 Juanma Barranquero <lekktu@gmail.com>
5467
5468 * makefile.w32-in: Update dependencies.
5469
5470 2011-05-18 Christoph Scholtes <cschol2112@googlemail.com>
5471
5472 * menu.c: Include limits.h (fixes the MS-Windows build broken by
5473 2011-06-18T18:49:19Z!cyd@stupidchicken.com).
5474
5475 2011-05-18 Paul Eggert <eggert@cs.ucla.edu>
5476
5477 Fix some integer overflow issues, such as string length overflow.
5478
5479 * insdel.c (count_size_as_multibyte): Check for string overflow.
5480
5481 * character.c (lisp_string_width): Check for string overflow.
5482 Use EMACS_INT, not int, for string indexes and lengths; in
5483 particular, 2nd arg is now EMACS_INT, not int. Do not crash if
5484 the resulting string length overflows an EMACS_INT; instead,
5485 report a string overflow if no precision given. When checking for
5486 precision exhaustion, use a check that cannot possibly have
5487 integer overflow. (Bug#8675)
5488 * character.h (lisp_string_width): Adjust to new signature.
5489
5490 * alloc.c (string_overflow): New function.
5491 (Fmake_string): Use it. This doesn't change behavior, but saves
5492 a few bytes and will simplify future changes.
5493 * character.c (string_escape_byte8): Likewise.
5494 * lisp.h (string_overflow): New decl.
5495
5496 Fixups, following up to the user-interface timestamp change.
5497 * nsterm.m (last_mouse_movement_time, ns_mouse_position): Use Time
5498 for UI timestamps, instead of unsigned long.
5499 * msdos.c (mouse_get_pos): Likewise.
5500 * w32inevt.c (movement_time, w32_console_mouse_position): Likewise.
5501 * w32gui.h (Time): Define by including "systime.h" rather than by
5502 declaring it ourselves. (Bug#8664)
5503
5504 * dispextern.h (struct image): Don't assume time_t <= unsigned long.
5505 * image.c (clear_image_cache): Likewise.
5506
5507 * term.c (term_mouse_position): Don't assume time_t wraparound.
5508
5509 Be more systematic about user-interface timestamps.
5510 Before, the code sometimes used 'Time', sometimes 'unsigned long',
5511 and sometimes 'EMACS_UINT', to represent these timestamps.
5512 This change causes it to use 'Time' uniformly, as that's what X uses.
5513 This makes the code easier to follow, and makes it easier to catch
5514 integer overflow bugs such as Bug#8664.
5515 * frame.c (Fmouse_position, Fmouse_pixel_position):
5516 Use Time, not unsigned long, for user-interface timestamps.
5517 * keyboard.c (last_event_timestamp, kbd_buffer_get_event): Likewise.
5518 (button_down_time, make_lispy_position, make_lispy_movement): Likewise.
5519 * keyboard.h (last_event_timestamp): Likewise.
5520 * menu.c (Fx_popup_menu) [!HAVE_X_WINDOWS]: Likewise.
5521 * menu.h (xmenu_show): Likewise.
5522 * term.c (term_mouse_position): Likewise.
5523 * termhooks.h (struct input_event.timestamp): Likewise.
5524 (struct terminal.mouse_position_hook): Likewise.
5525 * xmenu.c (create_and_show_popup_menu, xmenu_show): Likewise.
5526 * xterm.c (XTmouse_position, x_scroll_bar_report_motion): Likewise.
5527 * systime.h (Time): New decl. Pull it in from <X11/X.h> if
5528 HAVE_X_WINDOWS, otherwise define it as unsigned long, which is
5529 what it was before.
5530 * menu.h, termhooks.h: Include "systime.h", for Time.
5531
5532 * keyboard.c (make_lispy_event): Fix problem in integer overflow.
5533 Don't assume that the difference between two unsigned long values
5534 can fit into an integer. At this point, we know button_down_time
5535 <= event->timestamp, so the difference must be nonnegative, so
5536 there's no need to cast the result if double-click-time is
5537 nonnegative, as it should be; check that it's nonnegative, just in
5538 case. This bug is triggered when events are more than 2**31 ms
5539 apart (about 25 days). (Bug#8664)
5540
5541 * xselect.c (last_event_timestamp): Remove duplicate decl.
5542 (x_own_selection): Remove needless cast to unsigned long.
5543
5544 * xmenu.c (set_frame_menubar): Use int, not EMACS_UINT, for indexes
5545 that always fit in int. Use a sentinel instead of a counter, to
5546 avoid a temp and to allay GCC's concerns about possible int overflow.
5547 * frame.h (struct frame): Use int for menu_bar_items_used
5548 instead of EMACS_INT, since it always fits in int.
5549
5550 * menu.c (grow_menu_items): Check for int overflow.
5551
5552 * xmenu.c (set_frame_menubar): Don't mishandle vectors with no nils.
5553
5554 * xterm.c: Use EMACS_INT for Emacs modifiers, and int for X modifiers.
5555 Before, the code was not consistent. These values cannot exceed
5556 2**31 - 1 so there's no need to make them unsigned.
5557 (x_x_to_emacs_modifiers): Accept int and return EMACS_INT.
5558 (x_emacs_to_x_modifiers): Accept EMACS_INT and return int.
5559 (x_x_to_emacs_modifiers, x_emacs_to_x_modifiers): Reject non-integers
5560 as modifiers.
5561 * xterm.h (x_x_to_emacs_modifiers): Adjust to signature change.
5562
5563 * lisp.h (XINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_INT.
5564 (XUINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_UINT.
5565 Otherwise, GCC 4.6.0 warns about printf (pI, XINT (...)),
5566 presumably because the widths might not match.
5567
5568 * window.c (size_window): Avoid needless test at loop start.
5569
5570 2011-05-18 Courtney Bane <emacs-bugs-7626@cbane.org> (tiny change)
5571
5572 * term.c (Fresume_tty): Restore hooks before reinitializing (bug#8687).
5573
5574 2011-05-12 Drew Adams <drew.adams@oracle.com>
5575
5576 * textprop.c (Fprevious_single_char_property_change): Doc fix (bug#8655).
5577
5578 2011-05-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
5579
5580 * w32term.c (w32_draw_fringe_bitmap): Rename local vars `left' and
5581 `width' to `bar_area_x' and `bar_area_width', respectively.
5582 (x_scroll_run): Take account of fringe background extension.
5583
5584 * xterm.c (x_draw_fringe_bitmap) [USE_TOOLKIT_SCROLL_BARS]:
5585 Rename local vars `left' and `width' to `bar_area_x' and
5586 `bar_area_width', respectively.
5587 (x_scroll_run) [USE_TOOLKIT_SCROLL_BARS]: Take account of fringe
5588 background extension.
5589
5590 2011-05-10 Jim Meyering <meyering@redhat.com>
5591
5592 * xdisp.c (x_intersect_rectangles): Fix typo "the the -> the".
5593
5594 2011-05-10 Juanma Barranquero <lekktu@gmail.com>
5595
5596 * image.c (Finit_image_library): Return t for built-in image types,
5597 like pbm and xbm. (Bug#8640)
5598
5599 2011-05-09 Andreas Schwab <schwab@linux-m68k.org>
5600
5601 * w32menu.c (set_frame_menubar): Fix submenu allocation.
5602
5603 2011-05-07 Eli Zaretskii <eliz@gnu.org>
5604
5605 * w32console.c (Fset_screen_color): Doc fix.
5606 (Fget_screen_color): New function.
5607 (syms_of_ntterm): Defsubr it.
5608
5609 * callproc.c (call_process_cleanup) [MSDOS]: Don't close and
5610 unlink the temporary file if Fcall_process didn't create it in the
5611 first place.
5612 (Fcall_process) [MSDOS]: Don't create tempfile if stdout of the
5613 child process will be redirected to a file specified with `:file'.
5614 Don't try to re-open tempfile in that case, and set fd[0] to -1 as
5615 cue to call_process_cleanup not to close that handle.
5616
5617 2011-05-07 Ben Key <bkey76@gmail.com>
5618
5619 * makefile.w32-in: The bootstrap-temacs rule now makes use of
5620 one of two shell specific rules, either bootstrap-temacs-CMD or
5621 bootstrap-temacs-SH. The bootstrap-temacs-SH rule is identical
5622 to the previous implementation of the bootstrap-temacs rule.
5623 The bootstrap-temacs-CMD rule is similar to the previous
5624 implementation of the bootstrap-temacs rule except that it
5625 makes use of the ESC_CFLAGS variable instead of the CFLAGS
5626 variable.
5627
5628 These changes, along with some changes to nt/configure.bat,
5629 nt/gmake.defs, and nt/nmake.defs, are required to extend my
5630 earlier fix to add support for --cflags and --ldflags options
5631 that include quotes so that it works whether make uses cmd or
5632 sh as the shell.
5633
5634 2011-05-06 Michael Albinus <michael.albinus@gmx.de>
5635
5636 * dbusbind.c (QCdbus_type_unix_fd): Declare static.
5637 (xd_remove_watch): Don't check QCdbus_type_unix_fd for SYMBOLP, it
5638 is a constant.
5639 (Fdbus_init_bus, xd_read_queued_messages): Bus can be a symbol or
5640 a string. Handle both cases.
5641 (Fdbus_call_method_asynchronously, Fdbus_register_signal)
5642 (Fdbus_register_method): Use Qinvalid_function.
5643
5644 2011-05-06 Juanma Barranquero <lekktu@gmail.com>
5645
5646 * makefile.w32-in: Update dependencies.
5647 (LISP_H): Add inttypes.h and stdin.h.
5648 (PROCESS_H): Add unistd.h.
5649
5650 2011-05-06 Eli Zaretskii <eliz@gnu.org>
5651
5652 * lread.c: Include limits.h (fixes the MS-Windows build broken by
5653 2011-05-06T07:13:19Z!eggert@cs.ucla.edu).
5654
5655 2011-05-06 Paul Eggert <eggert@cs.ucla.edu>
5656
5657 * image.c (Finit_image_library) [!HAVE_NTGUI]: Omit unused local.
5658
5659 * term.c (vfatal): Remove stray call to va_end.
5660 It's not needed and the C Standard doesn't allow it here anyway.
5661
5662 Use C99's va_copy to avoid undefined behavior on x86-64 GNU/Linux.
5663 * eval.c (verror): doprnt a copy of ap, not the original. (Bug#8545)
5664
5665 * eval.c (verror): OK to create a string of up to MOST_POSITIVE_FIXNUM
5666 bytes.
5667
5668 * term.c: Don't include <stdarg.h>, as <lisp.h> does that.
5669
5670 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
5671
5672 * process.c (Fformat_network_address): Fix typo: args2 -> *args2.
5673
5674 * xmenu.c (set_frame_menubar): Fix typo: int * -> int (3 times).
5675
5676 * coding.c (detect_coding_charset): Fix typo: * 2 -> *4 (Bug#8601).
5677
5678 * charset.h (struct charset.code_space): Now has 15 elements, not 16.
5679 * charset.c (Fdefine_charset_internal): Don't initialize
5680 charset.code_space[15]. The value was garbage, on hosts with
5681 32-bit int (Bug#8600).
5682
5683 * lread.c (read_integer): Be more consistent with string-to-number.
5684 Use string_to_number to do the actual conversion; this avoids
5685 rounding errors and fixes some other screwups. Without this fix,
5686 for example, #x1fffffffffffffff was misread as -2305843009213693952.
5687 (digit_to_number): Move earlier, for benefit of read_integer.
5688 Return -1 if the digit is out of range for the base, -2 if it is
5689 not a digit in any supported base. (Bug#8602)
5690
5691 * doprnt.c (doprnt): Support arbitrary pI values, such as "I64".
5692
5693 * dispnew.c (scrolling_window): Return 1 if we scrolled,
5694 to match comment at start of function. This also removes a
5695 GCC warning about overflow in a 32+64-bit port.
5696
5697 * lisp.h (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Simplify.
5698
5699 * dbusbind.c: Do not use XPNTR on a value that may be an integer.
5700 Reported by Stefan Monnier in
5701 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00919.html>.
5702 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
5703 Use SYMBOLP-guarded XSYMBOL, not XPNTR.
5704
5705 * lisp.h (EMACS_INTPTR): Remove. All uses changed to intptr_t.
5706 (EMACS_UINTPTR): Likewise, with uintptr_t.
5707
5708 * lisp.h: Prefer 64-bit EMACS_INT if available.
5709 (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Define to 64-bit
5710 on 32-bit hosts that have 64-bit int, so that they can access
5711 large files.
5712 However, temporarily disable this change unless the temporary
5713 symbol WIDE_EMACS_INT is defined.
5714
5715 * lread.c, process.c: Do not include <inttypes.h>; lisp.h does it now.
5716
5717 Prefer intptr_t/uintptr_t for integers the same widths as pointers.
5718 This removes an assumption that EMACS_INT and long are the same
5719 width as pointers. The assumption is true for Emacs porting targets
5720 now, but we want to make other targets possible.
5721 * lisp.h: Include <inttypes.h>, for INTPTR_MAX, UINTPTR_MAX.
5722 (EMACS_INTPTR, EMACS_UINTPTR): New macros.
5723 In the rest of the code, change types of integers that hold casted
5724 pointers to EMACS_INTPTR and EMACS_UINTPTR, systematically
5725 replacing EMACS_INT, long, EMACS_UINT, and unsigned long.
5726 (XTYPE): Don't cast arg to EMACS_UINT; normally is not needed.
5727 (XSET): Cast type of XTYPE arg to EMACS_INTPTR; it is needed here.
5728 No need to cast type when ORing.
5729 (XPNTR): Return a value of type EMACS_INTPTR or EMACS_UINTPTR.
5730 * alloc.c (lisp_align_malloc): Remove a no-longer-needed cast.
5731 * doc.c (store_function_docstring): Use EMACS_INTPTR, so as not to
5732 assume EMACS_INT is the same width as char *.
5733 * gtkutil.c (xg_gtk_scroll_destroy, xg_tool_bar_button_cb):
5734 (xg_tool_bar_callback, xg_tool_bar_help_callback, xg_make_tool_item):
5735 Remove no-longer-needed casts.
5736 (xg_create_scroll_bar, xg_tool_bar_button_cb, xg_tool_bar_callback):
5737 (xg_tool_bar_help_callback, xg_make_tool_item):
5738 Use EMACS_INTPTR to hold an integer
5739 that will be cast to void *; this can avoid a GCC warning
5740 if EMACS_INT is not the same width as void *.
5741 * menu.c (find_and_call_menu_selection): Remove no-longer-needed cast.
5742 * xdisp.c (display_echo_area_1, resize_mini_window_1):
5743 (current_message_1, set_message_1):
5744 Use a local to convert to proper width without a cast.
5745 * xmenu.c (dialog_selection_callback): Likewise.
5746
5747 * sysdep.c (get_random): Don't assume EMACS_INT is no wider than long.
5748 Also, don't assume VALBITS / RAND_BITS is less than 5,
5749 and don't rely on undefined behavior when shifting a 1 left into
5750 the sign bit.
5751 * lisp.h (get_random): Change signature to match.
5752
5753 * lread.c (hash_string): Use size_t, not int, for hash computation.
5754 Normally we prefer signed values; but hashing is special, because
5755 it's better to use unsigned division on hash table sizes so that
5756 the remainder is nonnegative. Also, size_t is the natural width
5757 for hashing into memory. The previous code used 'int', which doesn't
5758 retain enough info to hash well into very large tables.
5759 (oblookup, oblookup_last_bucket_number, Funintern): Likewise.
5760
5761 * dbusbind.c: Don't possibly lose pointer info when converting.
5762 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
5763 Use XPNTR rather than XHASH, so that the high-order bits of
5764 the pointer aren't lost when converting through void *.
5765
5766 * eval.c (Fautoload): Don't double-shift a pointer.
5767
5768 * fns.c (Frandom): Let EMACS_UINT be wider than unsigned long.
5769
5770 2011-05-06 Juanma Barranquero <lekktu@gmail.com>
5771
5772 * gnutls.c (DEF_GNUTLS_FN):
5773 * image.c (DEF_IMGLIB_FN): Make function pointers static.
5774
5775 2011-05-05 Andreas Schwab <schwab@linux-m68k.org>
5776
5777 * lread.c (lisp_file_lexically_bound_p): Stop scanning at end
5778 marker. (Bug#8610)
5779
5780 2011-05-05 Eli Zaretskii <eliz@gnu.org>
5781
5782 * w32heap.c (allocate_heap) [USE_LISP_UNION_TYPE || USE_LSB_TAG]:
5783 New version that can reserve upto 2GB of heap space.
5784
5785 2011-05-05 Chong Yidong <cyd@stupidchicken.com>
5786
5787 * nsfns.m (Fns_read_file_name): Doc fix (Bug#8534).
5788
5789 2011-05-05 Teodor Zlatanov <tzz@lifelogs.com>
5790
5791 * gnutls.c (fn_gnutls_certificate_set_x509_key_file): Add alias to
5792 `gnutls_certificate_set_x509_key_file'.
5793
5794 2011-05-05 Juanma Barranquero <lekktu@gmail.com>
5795
5796 * makefile.w32-in ($(BLD)/image.$(O), $(BLD)/process.$(O)):
5797 Update dependencies.
5798
5799 2011-05-04 Juanma Barranquero <lekktu@gmail.com>
5800
5801 * gnutls.h (emacs_gnutls_write, emacs_gnutls_read):
5802 * gnutls.c (emacs_gnutls_write, emacs_gnutls_read):
5803 Remove unused parameter `fildes'.
5804 * process.c (read_process_output, send_process): Don't pass it.
5805
5806 2011-05-04 Juanma Barranquero <lekktu@gmail.com>
5807
5808 Fix previous change: the library cache is defined in w32.c.
5809 * image.c (CACHE_IMAGE_TYPE) [!HAVE_NTGUI]: Define to noop.
5810 (Finit_image_library): Wrap Vlibrary_cache on "#ifdef HAVE_NTGUI".
5811
5812 2011-05-04 Juanma Barranquero <lekktu@gmail.com>
5813
5814 Implement dynamic loading of GnuTLS on Windows.
5815
5816 * gnutls.h (GNUTLS_EMACS_ERROR_NOT_LOADED): New macro.
5817 (emacs_gnutls_write, emacs_gnutls_read): Mark as extern.
5818 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
5819 Declare.
5820
5821 * gnutls.c (Qgnutls_dll): Define.
5822 (DEF_GNUTLS_FN, LOAD_GNUTLS_FN): New macros.
5823 (gnutls_*): Declare function pointers.
5824 (init_gnutls_functions): New function to initialize function pointers.
5825 (emacs_gnutls_handshake, Fgnutls_error_string, Fgnutls_deinit)
5826 (emacs_gnutls_global_init, Fgnutls_bye): Use function pointers.
5827 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
5828 Wrappers for gnutls_record_check_pending and gnutls_transport_set_errno.
5829 (emacs_gnutls_write, emacs_gnutls_read)
5830 (emacs_gnutls_handle_error, Fgnutls_error_fatalp)
5831 (Fgnutls_available_p): New function.
5832 (Fgnutls_boot): Call Fgnutls_available_p. Use function pointers.
5833 (syms_of_gnutls) <Qgnutls_dll>: Initialize and staticpro it.
5834 (syms_of_gnutls) <Sgnutls_available_p>: defsubr it.
5835
5836 * image.c: Include w32.h.
5837 (Vimage_type_cache): Delete.
5838 (syms_of_image) <Vimage_type_cache>: Don't initialize and staticpro it.
5839 (CACHE_IMAGE_TYPE, Finit_image_library): Use Vlibrary_cache instead.
5840 (w32_delayed_load): Move to w32.c.
5841
5842 * w32.h (VlibraryCache, QCloaded_from, w32_delayed_load): Declare.
5843
5844 * w32.c (QCloaded_from, Vlibrary_cache): Define.
5845 (w32_delayed_load): Move from image.c. When loading a library, record
5846 its filename in the :loaded-from property of the library id.
5847 (globals_of_w32) <QCloaded_from, Vlibrary_cache>:
5848 Initialize and staticpro them.
5849 (emacs_gnutls_pull, emacs_gnutls_push): Call emacs_gnutls_* functions.
5850
5851 * process.c: Include lisp.h before w32.h, not after.
5852 (wait_reading_process_output): Call emacs_gnutls_record_check_pending
5853 instead of gnutls_record_check_pending.
5854
5855 * callproc.c, emacs.c: Include lisp.h before w32.h, not after.
5856
5857 2011-05-04 Teodor Zlatanov <tzz@lifelogs.com>
5858
5859 * gnutls.c (Fgnutls_boot): Support :keylist and :crlfiles options
5860 instead of :keyfiles. Give GnuTLS the keylist and the CRL lists
5861 as passed in.
5862
5863 2011-05-03 Jan Djärv <jan.h.d@swipnet.se>
5864
5865 * xterm.c (x_set_frame_alpha): Do not set property on anything
5866 else than FRAME_X_OUTER_WINDOW (Bug#8608).
5867
5868 2011-05-02 Juanma Barranquero <lekktu@gmail.com>
5869
5870 * sysdep.c (get_tty_size) [WINDOWSNT]: Implement. (Bug#8596)
5871
5872 2011-05-02 Juanma Barranquero <lekktu@gmail.com>
5873
5874 * gnutls.c (Qgnutls_log_level, Qgnutls_code, Qgnutls_anon)
5875 (Qgnutls_x509pki, Qgnutls_e_interrupted, Qgnutls_e_again)
5876 (Qgnutls_e_invalid_session, Qgnutls_e_not_ready_for_handshake)
5877 (gnutls_global_initialized, Qgnutls_bootprop_priority)
5878 (Qgnutls_bootprop_trustfiles, Qgnutls_bootprop_keyfiles)
5879 (Qgnutls_bootprop_callbacks, Qgnutls_bootprop_loglevel)
5880 (Qgnutls_bootprop_hostname, Qgnutls_bootprop_verify_flags)
5881 (Qgnutls_bootprop_verify_error, Qgnutls_bootprop_verify_hostname_error)
5882 (Qgnutls_bootprop_callbacks_verify): Make static.
5883
5884 2011-05-01 Andreas Schwab <schwab@linux-m68k.org>
5885
5886 * callproc.c: Indentation fixup.
5887
5888 * sysdep.c (wait_for_termination_1): Make static.
5889 (wait_for_termination, interruptible_wait_for_termination):
5890 Move after wait_for_termination_1.
5891
5892 2011-05-01 Lars Magne Ingebrigtsen <larsi@gnus.org>
5893
5894 * sysdep.c (interruptible_wait_for_termination): New function
5895 which is like wait_for_termination, but allows keyboard
5896 interruptions.
5897
5898 * callproc.c (Fcall_process): Add (:file "file") as an option for
5899 the STDOUT buffer.
5900 (Fcall_process_region): Ditto.
5901
5902 2011-04-30 Eli Zaretskii <eliz@gnu.org>
5903
5904 * dosfns.c (Fint86, Fdos_memget, Fdos_memput): Use `ASIZE (FOO)'
5905 rather than `XVECTOR (FOO)->size'.
5906
5907 * process.c: Remove HAVE_INTTYPES_H condition from inclusion of
5908 inttypes.h, as a gnulib replacement is used if it not available in
5909 system headers.
5910
5911 2011-04-21 Eli Zaretskii <eliz@gnu.org>
5912
5913 Lift the MOST_POSITIVE_FIXNUM/4 limitation on visited files.
5914 * fileio.c (Finsert_file_contents): Don't limit file size to 1/4
5915 of MOST_POSITIVE_FIXNUM. (Bug#8528)
5916
5917 * coding.c (coding_alloc_by_realloc): Error out if destination
5918 will grow beyond MOST_POSITIVE_FIXNUM.
5919 (decode_coding_emacs_mule): Abort if there isn't enough place in
5920 charbuf for the composition carryover bytes. Reserve an extra
5921 space for up to 2 characters produced in a loop.
5922 (decode_coding_iso_2022): Abort if there isn't enough place in
5923 charbuf for the composition carryover bytes.
5924
5925 2011-04-21 Eli Zaretskii <eliz@gnu.org>
5926
5927 * doprnt.c (doprnt) [!HAVE_LONG_LONG_INT]: Error out instead of
5928 aborting when %lld or %lll format is passed.
5929 [!HAVE_UNSIGNED_LONG_LONG_INT]: Error out instead of aborting when
5930 %llo or %llx format is passed. (Bug#8545)
5931
5932 * window.c (window_scroll_line_based): Use a marker instead of
5933 simple variables to record original value of point. (Bug#7952)
5934
5935 * doprnt.c (doprnt): Fix the case where a multibyte sequence
5936 produced by %s or %c overflows available buffer space. (Bug#8545)
5937
5938 2011-04-28 Paul Eggert <eggert@cs.ucla.edu>
5939
5940 * doprnt.c (doprnt): Omit useless test; int overflow check (Bug#8545).
5941 (SIZE_MAX): Move defn after all includes, as they might #define it.
5942
5943 2011-04-28 Juanma Barranquero <lekktu@gmail.com>
5944
5945 * w32.c (init_environment): Warn about defaulting HOME to C:\.
5946
5947 2011-04-28 Juanma Barranquero <lekktu@gmail.com>
5948
5949 * keyboard.c (Qdelayed_warnings_hook): Define.
5950 (command_loop_1): Run `delayed-warnings-hook'
5951 if Vdelayed_warnings_list is non-nil.
5952 (syms_of_keyboard) <delayed-warnings-hook>: DEFSYM it.
5953 (syms_of_keyboard) <delayed-warnings-list>: DEFVAR_LISP it.
5954
5955 2011-04-28 Eli Zaretskii <eliz@gnu.org>
5956
5957 * doprnt.c (doprnt): Don't return value smaller than the buffer
5958 size if the message was truncated. (Bug#8545).
5959
5960 2011-04-28 Juanma Barranquero <lekktu@gmail.com>
5961
5962 * w32fns.c (Fx_change_window_property, Fx_delete_window_property)
5963 (Fx_window_property): #if-0 the whole functions, not just the bodies.
5964
5965 2011-04-27 Paul Eggert <eggert@cs.ucla.edu>
5966
5967 * doprnt.c (doprnt): Support "ll" length modifier, for long long.
5968
5969 2011-04-27 Juanma Barranquero <lekktu@gmail.com>
5970
5971 * makefile.w32-in: Update dependencies.
5972
5973 2011-04-27 Eli Zaretskii <eliz@gnu.org>
5974
5975 Improve `doprnt' and its usage. (Bug#8545)
5976 * doprnt.c (doprnt): Make sure `format' is never accessed beyond
5977 `format_end'. Remove support for %l as a conversion specifier.
5978 Don't use xrealloc. Improve diagnostics when the %l size modifier
5979 is used. Update the commentary.
5980
5981 * eval.c (verror): Simplify calculation of size_t.
5982
5983 * coding.c (Ffind_operation_coding_system): Fix diagnostic error
5984 messages.
5985
5986 2011-04-27 Yoshiaki Kasahara <kasahara@nc.kyushu-u.ac.jp> (tiny change)
5987
5988 * buffer.c (init_buffer) [USE_MMAP_FOR_BUFFERS]: Adjust to aliasing
5989 change.
5990
5991 2011-04-27 Paul Eggert <eggert@cs.ucla.edu>
5992
5993 * nsmenu.m: Replace all uses of XVECTOR with ASIZE and AREF.
5994 This makes this file independent of the recent pseudovector change.
5995
5996 2011-04-26 Paul Eggert <eggert@cs.ucla.edu>
5997
5998 * keyboard.c (handle_user_signal): Fix pointer signedness problem.
5999
6000 * gnutls.c (emacs_gnutls_handle_error): Remove unused local.
6001 (Fgnutls_boot): gnutls_certificate_verify_peers2 wants unsigned *.
6002 Remove unused local.
6003 (emacs_gnutls_write): Don't use uninitialized rtnval if nbyte <= 0.
6004
6005 * lisp.h: Fix a problem with aliasing and vector headers. (Bug#8546)
6006 GCC 4.6.0 optimizes based on type-based alias analysis.
6007 For example, if b is of type struct buffer * and v of type struct
6008 Lisp_Vector *, then gcc -O2 was incorrectly assuming that &b->size
6009 != &v->size, and therefore "v->size = 1; b->size = 2; return
6010 v->size;" must therefore return 1. This assumption is incorrect
6011 for Emacs, since it type-puns struct Lisp_Vector * with many other
6012 types. To fix this problem, this patch adds a new type struct
6013 vectorlike_header that documents the constraints on layout of vectors
6014 and pseudovectors, and helps optimizing compilers not get fooled
6015 by Emacs's type punning. It also adds the macros XSETTYPED_PVECTYPE
6016 XSETTYPED_PSEUDOVECTOR, TYPED_PSEUDOVECTORP, for similar reasons.
6017 * lisp.h (XSETTYPED_PVECTYPE): New macro, specifying the name of
6018 the size member.
6019 (XSETPVECTYPE): Rewrite in terms of new macro.
6020 (XSETPVECTYPESIZE): New macro, specifying both type and size.
6021 This is a bit clearer, and further avoids the possibility of
6022 undesirable aliasing.
6023 (XSETTYPED_PSEUDOVECTOR): New macro, specifying the size.
6024 (XSETPSEUDOVECTOR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR.
6025 (XSETSUBR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR and XSIZE,
6026 since Lisp_Subr is a special case (no "next" field).
6027 (ASIZE): Now uses header.size rather than size.
6028 All previous uses of XVECTOR (foo)->size replaced to use this macro,
6029 to avoid the hassle of writing XVECTOR (foo)->header.size.
6030 (struct vectorlike_header): New type.
6031 (TYPED_PSEUDOVECTORP): New macro, also specifying the C type of the
6032 object, to help avoid aliasing.
6033 (PSEUDOVECTORP): Rewrite in terms of TYPED_PSEUDOVECTORP.
6034 (SUBRP): Likewise, since Lisp_Subr is a special case.
6035 * lisp.h (struct Lisp_Vector, struct Lisp_Char_Table):
6036 (struct Lisp_Sub_Char_Table, struct Lisp_Bool_Vector):
6037 (struct Lisp_Hash_Table): Combine first two members into a single
6038 struct vectorlike_header member. All uses of "size" and "next" members
6039 changed to be "header.size" and "header.next".
6040 * buffer.h (struct buffer): Likewise.
6041 * font.h (struct font_spec, struct font_entity, struct font): Likewise.
6042 * frame.h (struct frame): Likewise.
6043 * process.h (struct Lisp_Process): Likewise.
6044 * termhooks.h (struct terminal): Likewise.
6045 * window.c (struct save_window_data, struct saved_window): Likewise.
6046 * window.h (struct window): Likewise.
6047 * alloc.c (allocate_buffer, Fmake_bool_vector, allocate_pseudovector):
6048 Use XSETPVECTYPESIZE, not XSETPVECTYPE, to avoid aliasing problems.
6049 * buffer.c (init_buffer_once): Likewise.
6050 * lread.c (defsubr): Use XSETTYPED_PVECTYPE, since Lisp_Subr is a
6051 special case.
6052 * process.c (Fformat_network_address): Use local var for size,
6053 for brevity.
6054
6055 * bytecode.c (exec_byte_code): Don't use XVECTOR before CHECK_VECTOR.
6056
6057 Make the Lisp reader and string-to-float more consistent (Bug#8525)
6058 * data.c (atof): Remove decl; no longer used or needed.
6059 (digit_to_number): Move to lread.c.
6060 (Fstring_to_number): Use new string_to_number function, to be
6061 consistent with how the Lisp reader treats infinities and NaNs.
6062 Do not assume that floating-point numbers represent EMACS_INT
6063 without losing information; this is not true on most 64-bit hosts.
6064 Avoid double-rounding errors, by insisting on integers when
6065 parsing non-base-10 numbers, as the documentation specifies.
6066 * lisp.h (string_to_number): New decl, replacing ...
6067 (isfloat_string): Remove.
6068 * lread.c: Include <inttypes.h>, for uintmax_t and strtoumax.
6069 (read1): Do not accept +. and -. as integers; this
6070 appears to have been a coding error. Similarly, do not accept
6071 strings like +-1e0 as floating point numbers. Do not report
6072 overflow for integer overflows unless the base is not 10 which
6073 means we have no simple and reliable way to continue.
6074 Break out the floating-point parsing into a new
6075 function string_to_number, so that Fstring_to_number parses
6076 floating point numbers consistently with the Lisp reader.
6077 (digit_to_number): Move here from data.c. Make it static inline.
6078 (E_CHAR, EXP_INT): Remove, replacing with ...
6079 (E_EXP): New macro, to solve the "1.0e+" problem mentioned below.
6080 (string_to_number): New function, replacing isfloat_string.
6081 This function checks for valid syntax and produces the resulting
6082 Lisp float number too. Rework it so that string-to-number
6083 no longer mishandles examples like "1.0e+". Use strtoumax,
6084 so that overflow for non-base-10 numbers is reported only when
6085 there's no portable and simple way to convert to floating point.
6086
6087 * textprop.c (set_text_properties_1): Rewrite for clarity,
6088 and to avoid GCC warning about integer overflow.
6089
6090 * intervals.h (struct interval): Use EMACS_INT for members
6091 where EMACS_UINT might cause problems. See
6092 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html>.
6093 (CHECK_TOTAL_LENGTH): Remove cast to EMACS_INT; no longer needed.
6094 * intervals.c (interval_deletion_adjustment): Now returns EMACS_INT.
6095 All uses changed.
6096 (offset_intervals): Tell GCC not to worry about length overflow
6097 when negating a negative length.
6098
6099 * alloc.c (overrun_check_malloc, overrun_check_realloc): Now static.
6100 (overrun_check_free): Likewise.
6101
6102 * alloc.c (SDATA_SIZE) [!GC_CHECK_STRING_BYTES]: Avoid runtime check
6103 in the common case where SDATA_DATA_OFFSET is a multiple of Emacs
6104 word size.
6105
6106 * gnutls.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
6107 (gnutls_make_error): Rename local to avoid shadowing.
6108 (gnutls_emacs_global_deinit): ifdef out; not used.
6109 (Fgnutls_boot): Use const for pointer to readonly storage.
6110 Comment out unused local. Fix pointer signedness problems.
6111
6112 * lread.c (openp): Don't stuff size_t into an 'int'.
6113 Use <= on length, not < on length + 1, to avoid GCC 4.6.0 warning
6114 about possible signed overflow.
6115
6116 * gtkutil.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
6117 (GDK_KEY_g): Don't define if already defined.
6118 (xg_prepare_tooltip): Avoid pointer signedness problem.
6119 (xg_set_toolkit_scroll_bar_thumb): Redo to avoid two casts.
6120
6121 * process.c (Fnetwork_interface_info): Avoid left-shift undefined
6122 behavior with 1 << 31. GCC 4.6.0 warns about this on 32-bit hosts.
6123
6124 * xfns.c (Fx_window_property): Simplify a bit,
6125 to make a bit faster and to avoid GCC 4.6.0 warning.
6126 * xselect.c (x_get_window_property, x_handle_dnd_message): Likewise.
6127
6128 * fns.c (internal_equal): Don't assume size_t fits in int.
6129
6130 * alloc.c (compact_small_strings): Tighten assertion a little.
6131
6132 Replace pEd with more-general pI, and fix some printf arg casts.
6133 * lisp.h (pI): New macro, generalizing old pEd macro to other
6134 conversion specifiers. For example, use "...%"pI"d..." rather
6135 than "...%"pEd"...".
6136 (pEd): Remove. All uses replaced with similar uses of pI.
6137 * src/m/amdx86-64.h, src/m/ia64.h, src/m/ibms390x.h: Likewise.
6138 * alloc.c (check_pure_size): Don't overflow by converting size to int.
6139 * bidi.c (bidi_dump_cached_states): Use pI to avoid cast.
6140 * data.c (Fnumber_to_string): Use pI instead of if-then-else-abort.
6141 * dbusbind.c (xd_append_arg): Use pI to avoid cast.
6142 (Fdbus_method_return_internal, Fdbus_method_error_internal): Likewise.
6143 * font.c (font_unparse_xlfd): Avoid potential buffer overrun on
6144 64-bit hosts.
6145 (font_unparse_xlfd, font_unparse_fcname): Use pI to avoid casts.
6146 * keyboard.c (record_char, modify_event_symbol): Use pI to avoid casts.
6147 * print.c (safe_debug_print, print_object): Likewise.
6148 (print_object): Don't overflow by converting EMACS_INT or EMACS_UINT
6149 to int.
6150 Use pI instead of if-then-else-abort. Use %p to avoid casts,
6151 avoiding the 0 flag, which is not portable.
6152 * process.c (Fmake_network_process): Use pI to avoid cast.
6153 * region-cache.c (pp_cache): Likewise.
6154 * xdisp.c (decode_mode_spec): Likewise.
6155 * xrdb.c (x_load_resources) [USE_MOTIF]: Use pI to avoid undefined
6156 behavior on 64-bit hosts with printf arg.
6157 * xselect.c (x_queue_event): Use %p to avoid casts, avoiding 0 flag.
6158 (x_stop_queuing_selection_requests): Likewise.
6159 (x_get_window_property): Don't truncate byte count to an 'int'
6160 when tracing.
6161
6162 * frame.c (frame_name_fnn_p): Get rid of strtol, which isn't right
6163 here, since it parses constructs like leading '-' and spaces,
6164 which are not wanted; and it overflows with large numbers.
6165 Instead, simply match F[0-9]+, which is what is wanted anyway.
6166
6167 * alloc.c: Remove unportable assumptions about struct layout.
6168 (SDATA_SELECTOR, SDATA_DATA_OFFSET): New macros.
6169 (SDATA_OF_STRING, SDATA_SIZE, allocate_string_data):
6170 (allocate_vectorlike, make_pure_vector): Use the new macros,
6171 plus offsetof, to remove unportable assumptions about struct layout.
6172 These assumptions hold on all porting targets that I know of, but
6173 they are not guaranteed, they're easy to remove, and removing them
6174 makes further changes easier.
6175
6176 * alloc.c (BLOCK BYTES): Fix typo by changing "ablock" to "ablocks".
6177 This doesn't fix a bug but makes the code clearer.
6178 (string_overrun_cookie): Now const. Use initializers that
6179 don't formally overflow signed char, to avoid warnings.
6180 (allocate_string_data) [GC_CHECK_STRING_OVERRUN]: Fix typo that
6181 can cause Emacs to crash when string overrun checking is enabled.
6182 (allocate_buffer): Don't assume sizeof (struct buffer) is a
6183 multiple of sizeof (EMACS_INT); it need not be, if
6184 alignof(EMACS_INT) < sizeof (EMACS_INT).
6185 (check_sblock, check_string_bytes, check_string_free_list): Protoize.
6186
6187 2011-04-26 Juanma Barranquero <lekktu@gmail.com>
6188
6189 * keyboard.c (QCrtl): Rename from Qrtl. All uses changed.
6190
6191 2011-04-26 Teodor Zlatanov <tzz@lifelogs.com>
6192
6193 * gnutls.c (emacs_gnutls_handshake): Return an error if we're not
6194 supposed to be handshaking. (Bug#8556)
6195 Reported by Paul Eggert <eggert@cs.ucla.edu>.
6196
6197 2011-04-26 Daniel Colascione <dan.colascione@gmail.com>
6198
6199 * lisp.h (Qdebug): List symbol.
6200 * eval.c (Qdebug): Restore global linkage.
6201 * keyboard.c (debug-on-event): New variable.
6202 (handle_user_signal): Break into debugger when debug-on-event
6203 matches the current signal symbol.
6204
6205 2011-04-25 Dan Nicolaescu <dann@ics.uci.edu>
6206
6207 * alloc.c (check_sblock, check_string_bytes)
6208 (check_string_free_list): Convert to standard C.
6209
6210 2011-04-25 Teodor Zlatanov <tzz@lifelogs.com>
6211
6212 * w32.c (emacs_gnutls_push): Fix typo.
6213
6214 2011-04-25 Eli Zaretskii <eliz@gnu.org>
6215
6216 * gnutls.c (emacs_gnutls_handshake): Avoid compiler warnings about
6217 "cast to pointer from integer of different size".
6218
6219 Improve doprnt and its use in verror. (Bug#8545)
6220 * doprnt.c (doprnt): Document the set of format control sequences
6221 supported by the function. Use SAFE_ALLOCA instead of always
6222 using `alloca'.
6223
6224 * eval.c (verror): Don't limit the buffer size at size_max-1, that
6225 is one byte too soon. Don't use xrealloc; instead xfree and
6226 xmalloc anew.
6227
6228 2011-04-24 Teodor Zlatanov <tzz@lifelogs.com>
6229
6230 * gnutls.h: Add GNUTLS_STAGE_CALLBACKS enum to denote we're in the
6231 callbacks stage.
6232
6233 * gnutls.c: Renamed global_initialized to
6234 gnutls_global_initialized. Added internals for the
6235 :verify-hostname-error, :verify-error, and :verify-flags
6236 parameters of `gnutls-boot' and documented those parameters in the
6237 docstring. Start callback support.
6238 (emacs_gnutls_handshake): Add Woe32 support. Retry handshake
6239 unless a fatal error occurred. Call gnutls_alert_send_appropriate
6240 on error. Return error code.
6241 (emacs_gnutls_write): Call emacs_gnutls_handle_error.
6242 (emacs_gnutls_read): Likewise.
6243 (Fgnutls_boot): Return handshake error code.
6244 (emacs_gnutls_handle_error): New function.
6245 (wsaerror_to_errno): Likewise.
6246
6247 * w32.h (emacs_gnutls_pull): Add prototype.
6248 (emacs_gnutls_push): Likewise.
6249
6250 * w32.c (emacs_gnutls_pull): New function for GnuTLS on Woe32.
6251 (emacs_gnutls_push): Likewise.
6252
6253 2011-04-24 Claudio Bley <claudio.bley@gmail.com> (tiny change)
6254
6255 * process.c (wait_reading_process_output): Check if GnuTLS
6256 buffered some data internally if no FDs are set for TLS
6257 connections.
6258
6259 * makefile.w32-in (OBJ2): Add gnutls.$(O).
6260 (LIBS): Link to USER_LIBS.
6261 ($(BLD)/gnutls.$(0)): New target.
6262
6263 2011-04-24 Eli Zaretskii <eliz@gnu.org>
6264
6265 * xdisp.c (handle_single_display_spec): Rename the
6266 display_replaced_before_p argument into display_replaced_p, to
6267 make it consistent with the commentary. Fix typos in the
6268 commentary.
6269
6270 * textprop.c (syms_of_textprop): Remove dead code.
6271 (copy_text_properties): Delete obsolete commentary about an
6272 interface that was deleted long ago. Fix typos in the description
6273 of arguments.
6274
6275 * msdos.c (XMenuActivate, XMenuAddSelection): Adjust argument list
6276 to changes in oldXMenu/XMenu.h from 2011-04-16.
6277 <menu_help_message, prev_menu_help_message>: Constify.
6278 (IT_menu_make_room): menu->help_text is now `const char **';
6279 adjust.
6280
6281 * msdos.h (XMenuActivate, XMenuAddSelection): Adjust prototypes
6282 to changes in oldXMenu/XMenu.h from 2011-04-16.
6283 (struct XMenu): Declare `help_text' `const char **'.
6284
6285 * xfaces.c <Qunspecified>: Make extern again.
6286
6287 * syntax.c: Include sys/types.h before including regex.h, as
6288 required by Posix.
6289
6290 * doc.c (get_doc_string): Improve the format passed to `error'.
6291
6292 * doprnt.c (doprnt): Improve commentary.
6293
6294 * term.c (init_tty) [MSDOS]: Fix 1st argument to maybe_fatal.
6295
6296 * Makefile.in (TAGS): Depend on $(M_FILE) and $(S_FILE), and scan
6297 them with etags.
6298
6299 * makefile.w32-in (globals.h): Add a dummy recipe, to make any
6300 changes in globals.h immediately force recompilation.
6301 (TAGS): Depend on $(CURDIR)/m/intel386.h and
6302 $(CURDIR)/s/ms-w32.h.
6303 (TAGS-gmake): Scan $(CURDIR)/m/intel386.h and $(CURDIR)/s/ms-w32.h.
6304
6305 * character.c (Fchar_direction): Function deleted.
6306 (syms_of_character): Don't defsubr it.
6307 <char-direction-table>: Deleted.
6308
6309 2011-04-23 Eli Zaretskii <eliz@gnu.org>
6310
6311 Fix doprnt so it could be used again safely in `verror'. (Bug#8435)
6312 * doprnt.c: Include limits.h.
6313 (SIZE_MAX): New macro.
6314 (doprnt): Return a size_t value. 2nd arg is now size_t.
6315 Many local variables are now size_t instead of int or unsigned.
6316 Improve overflow protection. Support `l' modifier for integer
6317 conversions. Support %l conversion. Don't assume an EMACS_INT
6318 argument for integer conversions and for %c.
6319
6320 * lisp.h (doprnt): Restore prototype.
6321
6322 * makefile.w32-in ($(BLD)/callint.$(O)): Depend on
6323 $(SRC)/character.h.
6324
6325 * Makefile.in (base_obj): Add back doprnt.o.
6326
6327 * deps.mk (doprnt.o): Add back prerequisites.
6328 (callint.o): Depend on character.h.
6329
6330 * eval.c (internal_lisp_condition_case): Include the handler
6331 representation in the error message.
6332 (verror): Call doprnt instead of vsnprintf. Fix an off-by-one bug
6333 when breaking from the loop.
6334
6335 * xdisp.c (vmessage): Call doprnt instead of vsnprintf.
6336
6337 * callint.c (Fcall_interactively): When displaying error message
6338 about invalid control letter, pass the character's codepoint, not
6339 a pointer to its multibyte form. Improve display of the character
6340 in octal and display also its hex code.
6341
6342 * character.c (char_string): Use %x to display the (unsigned)
6343 codepoint of an invalid character, to avoid displaying a bogus
6344 negative value.
6345
6346 * font.c (check_otf_features): Pass SDATA of SYMBOL_NAME to
6347 `error', not SYMBOL_NAME itself.
6348
6349 * coding.c (Fencode_sjis_char, Fencode_big5_char): Use %c for
6350 character arguments to `error'.
6351
6352 * charset.c (check_iso_charset_parameter): Fix incorrect argument
6353 to `error' in error message about FINAL_CHAR argument. Make sure
6354 FINAL_CHAR is a character, and use %c when it is passed as
6355 argument to `error'.
6356
6357 2011-04-23 Eli Zaretskii <eliz@gnu.org>
6358
6359 * s/ms-w32.h (localtime): Redirect to sys_localtime.
6360
6361 * w32.c: Include <time.h>.
6362 (sys_localtime): New function.
6363
6364 2011-04-23 Chong Yidong <cyd@stupidchicken.com>
6365
6366 * xdisp.c (init_xdisp): Initialize echo_area_window (Bug#6451).
6367
6368 * buffer.c (syms_of_buffer): Doc fix (Bug#6902).
6369
6370 2011-04-23 Samuel Thibault <sthibault@debian.org> (tiny change)
6371
6372 * sysdep.c (wait_for_termination): On GNU Hurd, kill returns -1 on
6373 zombies (Bug#8467).
6374
6375 2011-04-19 Eli Zaretskii <eliz@gnu.org>
6376
6377 * syntax.h (SETUP_SYNTAX_TABLE_FOR_OBJECT): Fix setting of
6378 gl_state.e_property when gl_state.object is Qt.
6379
6380 * insdel.c (make_gap_larger): Remove limitation of buffer size
6381 to <= INT_MAX.
6382
6383 2011-04-18 Chong Yidong <cyd@stupidchicken.com>
6384
6385 * xdisp.c (lookup_glyphless_char_display)
6386 (produce_glyphless_glyph): Handle cons cell entry in
6387 glyphless-char-display.
6388 (Vglyphless_char_display): Document it.
6389
6390 * term.c (produce_glyphless_glyph): Handle cons cell entry in
6391 glyphless-char-display.
6392
6393 2011-04-17 Chong Yidong <cyd@stupidchicken.com>
6394
6395 * xdisp.c (get_next_display_element): Remove unnecessary ifdefs.
6396
6397 * termhooks.h (FRAME_WINDOW_P): Remove duplicated definitions.
6398
6399 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): Add missing
6400 definition for no-X builds.
6401
6402 2011-04-16 Paul Eggert <eggert@cs.ucla.edu>
6403
6404 Static checks with GCC 4.6.0 and non-default toolkits.
6405
6406 * s/sol2-6.h, s/unixware.h (PTY_TTY_NAME_SPRINTF): Protoize decl.
6407
6408 * process.c (keyboard_bit_set): Define only if SIGIO.
6409 (send_process_trap): Mark it with NO_RETURN if it doesn't return.
6410 (send_process): Repair possible setjmp clobbering.
6411
6412 * s/usg5-4-common.h (SETUP_SLAVE_PTY): Don't pass extra arg to 'fatal'.
6413
6414 * eval.c: Include <stdio.h>, for vsnprintf on non-GNU/Linux hosts.
6415
6416 * data.c (arith_error): Mark with NO_RETURN if it doesn't return.
6417
6418 * alloc.c (bytes_used_when_full, SPARE_MEMORY, BYTES_USED):
6419 Define only if needed.
6420
6421 * sysdep.c (_FILE_OFFSET_BITS): Make this hack even uglier
6422 by pacifying GCC about it. Maybe it's time to retire it?
6423 * xfaces.c (USG, __TIMEVAL__): Likewise.
6424
6425 * dispextern.h (struct redisplay_interface): Rename param
6426 to avoid shadowing.
6427 * termhooks.h (struct terminal): Likewise.
6428 * xterm.c (xembed_send_message): Likewise.
6429
6430 * insdel.c (make_gap_smaller): Define only if
6431 USE_MMAP_FOR_BUFFERS || REL_ALLOC || DOUG_LEA_MALLOC.
6432
6433 * keyboard.c (read_char): Make a var volatile so longjmp won't clobber
6434 it.
6435
6436 * emacs.c (MAX_HEAP_BSS_DIFF, my_edata): Move to where they're used,
6437 so that we aren't warned about unused symbols.
6438
6439 * xfns.c (Fx_file_dialog): Rename local to avoid shadowing.
6440
6441 * xdisp.c (x_produce_glyphs): Mark var as initialized (Bug#8512).
6442
6443 * xfns.c (x_real_positions): Mark locals as initialized.
6444
6445 * xmenu.c (xmenu_show): Don't use uninitialized vars.
6446
6447 * xterm.c: Fix problems found by static analysis with other toolkits.
6448 (toolkit_scroll_bar_interaction): Define and use only if USE_X_TOOLKIT.
6449 (x_dispatch_event): Declare static if USE_GTK, and
6450 define if USE_GTK || USE_X_TOOLKIT.
6451 (SET_SAVED_BUTTON_EVENT): Define only if USE_X_TOOLKIT || USE_GTK.
6452 * xterm.h (x_dispatch_event): Extern only if USE_X_TOOLKIT.
6453 * xterm.c, xterm.h (x_mouse_leave): Bring this function back, but only
6454 if defined HAVE_MENUS && !defined USE_X_TOOLKIT && !defined USE_GTK.
6455
6456 * xmenu.c (menu_help_callback): Pointer type fixes.
6457 Use const pointers when pointing at readonly data. Avoid pointer
6458 signedness clashes.
6459 (FALSE): Remove unused macro.
6460 (update_frame_menubar): Remove unused decl.
6461
6462 * xfns.c (Fx_hide_tip): Move locals to avoid shadowing.
6463
6464 * menu.c (push_submenu_start, push_submenu_end): Do not define unless
6465 USE_X_TOOLKIT || USE_GTK || HAVE_NS || defined HAVE_NTGUI.
6466 (single_menu_item): Rename local to avoid shadowing.
6467
6468 * keyboard.c (make_lispy_event): Remove unused local var.
6469
6470 * frame.c, frame.h (x_get_resource_string): Bring this back, but
6471 only if HAVE_X_WINDOWS && !USE_X_TOOLKIT.
6472
6473 * bitmaps: Change bitmaps from unsigned char back to the X11
6474 compatible char. Avoid the old compiler warnings about
6475 out-of-range initializers by using, for example, '\xab' rather
6476 than 0xab.
6477
6478 * xgselect.c (xgselect_initialize): Check vs interface
6479 even if ! (defined (USE_GTK) || defined (HAVE_GCONF)).
6480
6481 * xmenu.c (xmenu_show): Rename parm to avoid shadowing.
6482
6483 * xterm.c (x_create_toolkit_scroll_bar): Use const * for pointers
6484 to read-only memory.
6485
6486 * fns.c (vector): Remove; this old hack is no longer needed.
6487
6488 * xsmfns.c (create_client_leader_window): Rename shadowing arg.
6489 Remove unused var.
6490 (gdk_x11_set_sm_client_id) [!USE_GTK]: Don't define.
6491
6492 * xrdb.c (x_load_resources): Omit unused local.
6493
6494 * xfns.c (free_frame_menubar, atof): Remove duplicate decls.
6495 (x_window): Rename locals to avoid shadowing.
6496 (USG): Use the kludged USG macro, to pacify gcc.
6497
6498 * xterm.c (x_alloc_nearest_color_for_widget): Remove; unused.
6499 (x_term_init): Remove local to avoid shadowing.
6500
6501 * xfns.c, xterm.c (_XEditResCheckMessages): Protoize decl.
6502
6503 * xdisp.c, dispextern.h (set_vertical_scroll_bar): Now extern if
6504 USE_TOOLKIT_SCROLL_BARS && !USE_GTK, as xterm.c needs it then.
6505
6506 2011-04-16 Eli Zaretskii <eliz@gnu.org>
6507
6508 * gnutls.c (Fgnutls_boot): Don't pass Lisp_Object to `error'.
6509
6510 Fix regex.c, syntax.c and friends for buffers > 2GB.
6511 * syntax.h (struct gl_state_s): Declare character position members
6512 EMACS_INT.
6513
6514 * syntax.c (update_syntax_table): Declare 2nd argument EMACS_INT.
6515
6516 * textprop.c (verify_interval_modification, interval_of):
6517 Declare arguments EMACS_INT.
6518
6519 * intervals.c (adjust_intervals_for_insertion): Declare arguments
6520 EMACS_INT.
6521
6522 * intervals.h (CHECK_TOTAL_LENGTH): Cast to EMACS_INT, not `int'.
6523
6524 * indent.c (Fvertical_motion): Local variable it_start is now
6525 EMACS_INT.
6526
6527 * regex.c (re_match, re_match_2, re_match_2_internal)
6528 (bcmp_translate, regcomp, regexec, print_double_string)
6529 (group_in_compile_stack, re_search, re_search_2, regex_compile)
6530 (re_compile_pattern, re_exec): Declare arguments and local
6531 variables `size_t' and `ssize_t' and return values `regoff_t', as
6532 appropriate.
6533 (POP_FAILURE_REG_OR_COUNT) <pfreg>: Declare `long'.
6534 (CHECK_INFINITE_LOOP) <failure>: Declare `ssize_t'.
6535 <compile_stack_type>: `size' and `avail' are now `size_t'.
6536
6537 * regex.h <regoff_t>: Use ssize_t, not int.
6538 (re_search, re_search_2, re_match, re_match_2): Arguments that
6539 specify buffer/string position and length are now ssize_t and
6540 size_t. Return type is regoff_t.
6541
6542 2011-04-16 Ben Key <bkey76@gmail.com>
6543
6544 * nsfont.m: Fixed bugs in ns_get_family and
6545 ns_descriptor_to_entity that were caused by using free to
6546 deallocate memory blocks that were allocated by xmalloc (via
6547 xstrdup). This caused Emacs to crash when compiled with
6548 XMALLOC_OVERRUN_CHECK defined (when Emacs was configured with
6549 --enable-checking=xmallocoverrun). xfree is now used to
6550 deallocate these memory blocks.
6551
6552 2011-04-15 Paul Eggert <eggert@cs.ucla.edu>
6553
6554 * sysdep.c (emacs_read): Remove unnecessary check vs MAX_RW_COUNT.
6555
6556 emacs_write: Accept and return EMACS_INT for sizes.
6557 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html
6558 et seq.
6559 * gnutls.c, gnutls.h (emacs_gnutls_read, emacs_gnutls_write):
6560 Accept and return EMACS_INT.
6561 (emacs_gnutls_write): Return the number of bytes written on
6562 partial writes.
6563 * sysdep.c, lisp.h (emacs_read, emacs_write): Likewise.
6564 (emacs_read, emacs_write): Remove check for negative size, as the
6565 Emacs source code has been audited now.
6566 * sysdep.c (MAX_RW_COUNT): New macro, to work around kernel bugs.
6567 (emacs_read, emacs_write): Use it.
6568 * process.c (send_process): Adjust to the new signatures of
6569 emacs_write and emacs_gnutls_write. Do not attempt to store
6570 a byte offset into an 'int'; it might overflow.
6571 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00483.html
6572
6573 * sound.c: Don't assume sizes fit in 'int'.
6574 (struct sound_device.period_size, alsa_period_size):
6575 Return EMACS_INT, not int.
6576 (struct sound_device.write, vox_write, alsa_write):
6577 Accept EMACS_INT, not int.
6578 (wav_play, au_play): Use EMACS_INT to store sizes and to
6579 record read return values.
6580
6581 2011-04-15 Ben Key <bkey76@gmail.com>
6582
6583 * keyboard.c (Qundefined): Don't declare static since it is used
6584 in nsfns.m.
6585 * xfaces.c (Qbold, Qexpanded, Qitalic, Qcondensed): Don't declare
6586 static since they are used in nsfont.m.
6587
6588 2011-04-15 Stefan Monnier <monnier@iro.umontreal.ca>
6589
6590 * process.c (Qprocessp): Don't declare static.
6591 * lisp.h (Qprocessp): Declare again.
6592
6593 2011-04-15 Juanma Barranquero <lekktu@gmail.com>
6594
6595 * font.c (Qopentype): Don't make static (used from w32uniscribe.c).
6596
6597 2011-04-14 Paul Eggert <eggert@cs.ucla.edu>
6598
6599 Improve C-level modularity by making more things 'static'.
6600
6601 Don't publish debugger-only interfaces to other modules.
6602 * lisp.h (safe_debug_print, debug_output_compilation_hack):
6603 (verify_bytepos, count_markers): Move decls to the only modules
6604 that need them.
6605 * region-cache.h (pp_cache): Likewise.
6606 * window.h (check_all_windows): Likewise.
6607 * marker.c, print.c, region-cache.c, window.c: Decls moved here.
6608
6609 * sysdep.c (croak): Now static, if
6610 defined TIOCNOTTY || defined USG5 || defined CYGWIN.
6611 * syssignal.h (croak): Declare only if not static.
6612
6613 * alloc.c (refill_memory_reserve): Now static if
6614 !defined REL_ALLOC || defined SYSTEM_MALLOC.
6615 * lisp.h (refill_memory_reserve): Declare only if not static.
6616
6617 * xsettings.c, xsettings.h (xsettings_get_system_normal_font):
6618 Define only if USE_LUCID.
6619
6620 * xrdb.c (x_customization_string, x_rm_string): Now static.
6621
6622 * xmenu.c (x_menu_wait_for_event): Export only if USE_MOTIF.
6623 * xterm.h (x_menu_wait_for_event): Declare only if USE_MOTIF.
6624
6625 * xdisp.c (draw_row_with_mouse_face): Now static.
6626 * dispextern.h (draw_row_with_mouse_fave): Remove decl.
6627
6628 * window.h (check_all_windows): Mark externally visible.
6629
6630 * window.c (window_deletion_count): Now static.
6631
6632 * undo.c: Make symbols static if they're not exported.
6633 (last_undo_buffer, last_boundary_position, pending_boundary):
6634 Now static.
6635
6636 * textprop.c (interval_insert_behind_hooks): Now static.
6637 (interval_insert_in_front_hooks): Likewise.
6638
6639 * term.c: Make symbols static if they're not exported.
6640 (tty_turn_off_highlight, get_tty_terminal, max_frame_cols):
6641 (max_frame_lines, tty_set_terminal_modes):
6642 (tty_reset_terminal_modes, tty_turn_off_highlight):
6643 (get_tty_terminal): Now static.
6644 (term_mouse_moveto): Do not define if HAVE_WINDOW_SYSTEM.
6645 * termhooks.h (term_mouse_moveto): Do not declare if
6646 HAVE_WINDOW_SYSTEM.
6647 * dispextern.h (tty_set_terminal_modes, tty_reset_terminal_modes):
6648 (tty_turn_off_highlight, get_tty_terminal): Remove decls.
6649
6650 * sysdep.c: Make symbols static if they're not exported.
6651 (emacs_get_tty, emacs_set_tty, old_fcntl_flags, old_fcntl_owner):
6652 Now static.
6653 (sigprocmask_set, full_mask): Remove; unused.
6654 (wait_debugging): Mark as visible.
6655 * syssignal.h (SIGFULLMASK, full_mask): Remove decls.
6656 * systty.h (emacs_get_tty, emacs_set_tty): Remove decls.
6657
6658 * syntax.c (syntax_temp): Define only if !__GNUC__.
6659
6660 * sound.c (current_sound_device, current_sound): Now static.
6661
6662 * search.c (searchbufs, searchbuf_head): Now static.
6663
6664 * scroll.c (scroll_cost): Remove; unused.
6665 * dispextern.h (scroll_cost): Remove decl.
6666
6667 * region-cache.h (pp_cache): Mark as externally visible.
6668
6669 * process.c: Make symbols static if they're not exported.
6670 (process_tick, update_tick, create_process, chan_process):
6671 (Vprocess_alist, proc_buffered_char, datagram_access):
6672 (fd_callback_data, send_process_frame, process_sent_to): Now static.
6673 (deactivate_process): Mark defn as static, as well as decl.
6674 * lisp.h (create_process): Remove decl.
6675 * process.h (chan_process, Vprocess_alist): Remove decls.
6676
6677 * print.c: Make symbols static if they're not exported.
6678 (print_depth, new_backquote_output, being_printed, print_buffer):
6679 (print_buffer_size, print_buffer_pos, print_buffer_pos_byte):
6680 (print_interval, print_number_index, initial_stderr_stream):
6681 Now static.
6682 * lisp.h (Fprinc): Remove decl.
6683 (debug_output_compilation_hack): Mark as externally visible.
6684
6685 * sysdep.c (croak): Move decl from here to syssignal.h.
6686 * syssignal.h (croak): Put it here, so the API can be checked when
6687 'croak' is called from dissociate_if_controlling_tty.
6688
6689 * minibuf.c: Make symbols static if they're not exported.
6690 (minibuf_save_list, choose_minibuf_frame): Now static.
6691 * lisp.h (choose_minibuf_frame): Remove decl.
6692
6693 * lisp.h (verify_bytepos, count_markers): Mark as externally visible.
6694
6695 * lread.c: Make symbols static if they're not exported.
6696 (read_objects, initial_obarray, oblookup_last_bucket_number):
6697 Now static.
6698 (make_symbol): Remove; unused.
6699 * lisp.h (initial_obarray, make_symbol): Remove decls.
6700
6701 * keyboard.c: Make symbols static if they're not exported.
6702 (single_kboard, recent_keys_index, total_keys, recent_keys):
6703 (this_command_key_count_reset, raw_keybuf, raw_keybuf_count):
6704 (this_single_command_key_start, echoing, last_auto_save):
6705 (read_key_sequence_cmd, dribble, recursive_edit_unwind):
6706 (command_loop, echo_now, keyboard_init_hook, help_char_p):
6707 (quit_throw_to_read_char, command_loop_2, top_level_1, poll_timer):
6708 (Vlispy_mouse_stem, double_click_count):
6709 Now static.
6710 (force_auto_save_soon): Define only if SIGDANGER.
6711 (ignore_mouse_drag_p): Now static if
6712 !defined HAVE_WINDOW_SYSTEM || defined USE_GTK || defined HAVE_NS.
6713 (print_help): Remove; unused.
6714 (stop_character, last_timer_event): Mark as externally visible.
6715 * keyboard.h (ignore_mouse_drag_p): Declare only if
6716 defined HAVE_WINDOW_SYSTEM && !defined USE_GTK && !defined HAVE_NS.
6717 (echo_now, help_char_p, quit_throw_to_read_char): Remove decls.
6718 * lisp.h (echoing): Remove decl.
6719 (force_auto_save_soon): Declare only if SIGDANGER.
6720 * xdisp.c (redisplay_window): Simplify code, to make it more
6721 obvious that ignore_mouse_drag_p is not accessed if !defined
6722 USE_GTK && !defined HAVE_NS.
6723
6724 * intervals.c: Make symbols static if they're not exported.
6725 (merge_properties_sticky, merge_interval_right, delete_interval):
6726 Now static.
6727 * intervals.h (merge_interval_right, delete_interval): Remove decls.
6728
6729 * insdel.c: Make symbols static if they're not exported.
6730 However, leave prepare_to_modify_buffer alone. It's never
6731 called from outside this function, but that appears to be a bug.
6732 (combine_after_change_list, combine_after_change_buffer):
6733 (adjust_after_replace, signal_before_change): Now static.
6734 (adjust_after_replace_noundo): Remove; unused.
6735 * lisp.h (adjust_after_replace, adjust_after_replace_noundo):
6736 (signal_before_change): Remove decls.
6737
6738 * indent.c (val_compute_motion, val_vmotion): Now static.
6739
6740 * image.c: Make symbols static if they're not exported.
6741 * dispextern.h (x_create_bitmap_from_xpm_data): Do not declare
6742 if USE_GTK.
6743 * image.c (x_create_bitmap_from_xpm_data): Do not define if USE_GTK.
6744 (xpm_color_cache, ct_table, ct_colors_allocated): Now static.
6745
6746 * fringe.c (standard_bitmaps): Now static.
6747 (max_used_fringe_bitmap): Now static, unless HAVE_NS.
6748
6749 * frame.c: Make symbols static if they're not exported.
6750 (x_report_frame_params, make_terminal_frame): Now static.
6751 (get_frame_param): Now static, unless HAVE_NS.
6752 (x_fullscreen_adjust): Define if WINDOWSNT, not if HAVE_WINDOW_SYSTEM.
6753 (x_get_resource_string): Remove; not used.
6754 * frame.h (make_terminal_frame, x_report_frame_params):
6755 (x_get_resource_string); Remove decls.
6756 (x_fullscreen_adjust): Declare only if WINDOWSNT.
6757 * lisp.h (get_frame_param): Declare only if HAVE_NS.
6758
6759 * font.c, fontset.c: Make symbols static if they're not exported.
6760 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): New macro.
6761 (FACE_SUITABLE_FOR_CHAR_P): Use it.
6762 * font.c (font_close_object): Now static.
6763 * font.h (font_close_object): Remove.
6764 * fontset.c (FONTSET_OBJLIST): Remove.
6765 (free_realized_fontset) #if-0 the body, which does nothing.
6766 (face_suitable_for_char_p): #if-0, as it's never called.
6767 * fontset.h (face_suitable_for_char_p): Remove decl.
6768 * xfaces.c (face_at_string_position):
6769 Use FACE_SUITABLE_FOR_ASCII_CHAR_P, not FACE_SUITABLE_FOR_CHAR_P,
6770 since 0 is always ASCII.
6771
6772 * fns.c (weak_hash_tables): Now static.
6773
6774 * fileio.c: Make symbols static if they're not exported.
6775 (auto_saving, auto_save_mode_bits, auto_save_error_occurred):
6776 (Vwrite_region_annotation_buffers): Now static.
6777
6778 * eval.c: Make symbols static if they're not exported.
6779 (backtrace_list, lisp_eval_depth, when_entered_debugger): Now static.
6780 * lisp.h (backtrace_list): Remove decl.
6781
6782 * emacs.c: Make symbols static if they're not exported.
6783 (malloc_state_ptr, malloc_using_checking, syms_of_emacs):
6784 (fatal_error_code, fatal_error_signal_hook, standard_args):
6785 Now static.
6786 (fatal_error_signal): Now static, unless FLOAT_CATCH_SIGKILL.
6787 (DEFINE_DUMMY_FUNCTION): Mark function as externally visible.
6788 (__CTOR_LIST__, __DTOR_LIST__): Now externally visible.
6789 * lisp.h (fatal_error_signal_hook): Remove decl.
6790 (fatal_error_signal): Declare only if FLOAT_CATCH_SIGKILL.
6791
6792 * editfns.c: Move a (normally-unused) function to its only use.
6793 * editfns.c, lisp.h (get_operating_system_release): Remove.
6794 * process.c (init_process) [DARWIN_OS]: Do it inline, as it is not
6795 worth the hassle of breaking this out.
6796
6797 * xterm.c: Make symbols static if they're not exported.
6798 (x_raise_frame, x_lower_frame, x_wm_set_window_state):
6799 (x_wm_set_icon_pixmap, x_initialize, XTread_socket_fake_io_error):
6800 (x_destroy_window, x_delete_display):
6801 Now static.
6802 (x_dispatch_event): Now static if ! (USE_MOTIF || USE_X_TOOLKIT).
6803 (x_mouse_leave): Remove; unused.
6804 * xterm.h (x_display_info_for_name, x_raise_frame, x_lower_frame):
6805 (x_destroy_window, x_wm_set_window_state, x_wm_set_icon_pixmap):
6806 (x_delete_display, x_initialize, x_set_border_pixel, x_screen_planes):
6807 Remove decls.
6808 (x_mouse_leave): Declare only if WINDOWSNT.
6809 (x_dispatch_event): Declare only if USE_MOTIF or USE_X_TOOLKIT.
6810 (xic_create_fontsetname): Declare only if HAVE_X_WINDOWS &&
6811 USE_X_TOOLKIT.
6812
6813 * ftxfont.c: Make symbols static if they're not exported.
6814 (ftxfont_driver): Export only if !defined HAVE_XFT && def8ined
6815 HAVE_FREETYPE.
6816 * font.h (ftxfont_driver): Likewise.
6817
6818 * xfns.c: Make symbols static if they're not exported.
6819 (x_last_font_name, x_display_info_for_name):
6820 (x_set_foreground_color, x_set_background_color, x_set_mouse_color):
6821 (x_set_cursor_color, x_set_border_pixel, x_set_border_color):
6822 (x_set_cursor_type, x_set_icon_type, x_set_icon_name):
6823 (x_set_scroll_bar_foreground, x_set_scroll_bar_background):
6824 (x_explicitly_set_name, x_set_title, xic_defaut_fontset, tip_timer):
6825 (last_show_tip_args): Now static.
6826 (xic_defaut_fontset, xic_create_fontsetname): Define only if
6827 defined HAVE_X_WINDOWS && defined USE_X_TOOLKIT
6828 (x_screen_planes): Remove; unused.
6829 * dispextern.h (x_screen_planes): Remove decl.
6830
6831 * dispnew.c: Make symbols static if they're not exported.
6832 * dispextern.h (redraw_garbaged_frames, scrolling):
6833 (increment_row_positions): Remove.
6834 * dispnew.c (new_glyph_matrix, increment_row_positions, scrolling):
6835 (delayed_size_change, glyph_matrix_count, glyph_pool_count):
6836 Now static.
6837 (redraw_garbaged_frames): Remove; unused.
6838
6839 * xfaces.c: Make symbols static if they're not exported.
6840 * dispextern.h (ascii_face_of_lisp_face, free_realized_face):
6841 Remove decls.
6842 * xterm.h (defined_color): Remove decls.
6843 (x_free_dpy_colors): Declare only if USE_X_TOOLKIT.
6844 * xfaces.c (tty_suppress_bold_inverse_default_colors_p):
6845 (menu_face_changed_default, defined_color, free_realized_face):
6846 (x_free_dpy_colors): Define only if USE_X_TOOLKIT.
6847 (ascii_face_of_lisp_face): Remove; unused.
6848
6849 * xdisp.c: Make symbols static if they're not exported.
6850 * dispextern.h (scratch_glyph_row, window_box_edges):
6851 (glyph_to_pixel_coords, set_cursor_from_row):
6852 (get_next_display_element, set_iterator_to_next):
6853 (highlight_trailing_whitespace, frame_to_window_pixel_xy):
6854 (show_mouse_face): Remove decls
6855 * frame.h (message_buf_print): Likewise.
6856 * lisp.h (pop_message, set_message, check_point_in_composition):
6857 Likewise.
6858 * xterm.h (set_vertical_scroll_bar): Likewise.
6859 * xdisp.c (list_of_error, Vmessage_stack, line_number_displayed):
6860 (message_buf_print, scratch_glyph_row, displayed_buffer):
6861 (set_iterator_to_next, pop_message, set_message, set_cursor_from_row):
6862 (get_next_display_element, show_mouse_face, window_box_edges):
6863 (frame_to_window_pixel_xy, check_point_in_composition):
6864 (set_vertical_scroll_bar, highlight_trailing_whitespace): Now static.
6865 (glyph_to_pixel_coords): Remove; unused.
6866
6867 * dired.c (file_name_completion): Now static.
6868
6869 * dbusbind.c (xd_in_read_queued_messages): Now static.
6870
6871 * lisp.h (circular_list_error, FOREACH): Remove; unused.
6872 * data.c (circular_list_error): Remove.
6873
6874 * commands.h (last_point_position, last_point_position_buffer):
6875 (last_point_position_window): Remove decls.
6876 * keyboard.c: Make these variables static.
6877
6878 * coding.h (coding, code_convert_region, encode_coding_gap):
6879 Remove decls.
6880 * coding.c (Vsjis_coding_system, Vbig5_coding_system):
6881 (iso_code_class, detect_coding, code_convert_region): Now static.
6882 (encode_coding_gap): Remove; unused.
6883
6884 * chartab.c (chartab_chars, chartab_bits): Now static.
6885
6886 * charset.h (charset_iso_8859_1): Remove decl.
6887 * charset.c (charset_iso_8859_1, charset_emacs, map_charset_for_dump):
6888 Now static.
6889
6890 * ccl.h (check_ccl_update, Vccl_program_table): Remove decls.
6891 * ccl.c (Vccl_program_table): Now static.
6892 (check_ccl_update): Remove; unused.
6893
6894 * category.c (SET_CATEGORY_SET, set_category_set): Move here.
6895 * category.h: ... from here.
6896 * category.c (check_category_table, set_category_set): Now static.
6897
6898 * casetab.c (Vascii_upcase_table, Vascii_eqv_table): Now static.
6899 * lisp.h: Remove these decls.
6900
6901 * buffer.c (buffer_count): Remove unused var.
6902
6903 * bidi.c (bidi_dump_cached_states): Mark as externally visible,
6904 so that it's not optimized away.
6905 (bidi_ignore_explicit_marks_for_paragraph_level): Likewise.
6906 * dispextern.h (bidi_dump_cached_states): Remove, since it's
6907 exported only to the debugger.
6908
6909 * atimer.c (alarm_signal_handler, run_all_atimers): Now static.
6910 * atimer.h (run_all_atimers): Remove; not exported.
6911
6912 font.c: Make copy_font_spec and merge_font_spec ordinary C functions.
6913 * font.c (copy_font_spec): Rename from Fcopy_font_spec, since it
6914 was inaccessible from Lisp.
6915 (merge_font_spec): Likewise, renaming from Fmerge_font_spec.
6916 * font.c, font.h, fontset.c, xfaces.c, xfont.c: Change all uses.
6917
6918 alloc.c: Import and export fewer symbols, and remove unused items.
6919 * lisp.h (suppress_checking, die): Declare only if ENABLE_CHECKING
6920 is defined.
6921 (suppress_checking): Add EXTERNALLY_VISIBLE attribute, so that
6922 it's not optimized away by whole-program optimization.
6923 (message_enable_multibyte, free_misc): Remove.
6924 (catchlist, handlerlist, mark_backtrace):
6925 Declare only if BYTE_MARK_STACK.
6926 (mark_byte_stack): Likewise, fixing a ifdef-vs-if typo.
6927 * alloc.c (pure): Export only if VIRT_ADDR_VARIES is defined.
6928 (message_enable_multibyte): Remove decl.
6929 (free_misc, interval_free_list, float_block, float_block_index):
6930 (n_float_blocks, float_free_list, cons_block, cons_block_index):
6931 (cons_free_list, last_marked_index):
6932 Now static.
6933 (suppress_checking, die): Define only if ENABLE_CHECKING is defined.
6934 * eval.c (catchlist, handlerlist): Export only if BYTE_MARK_STACK.
6935 (mark_backtrace): Define only if BYTE_MARK_STACK.
6936 * xdisp.c (message_enable_multibyte): Now static.
6937
6938 Declare Lisp_Object Q* variables to be 'static' if not exported.
6939 This makes it easier for human readers (and static analyzers)
6940 to see whether these variables are used from other modules.
6941 * alloc.c, buffer.c, bytecode.c, callint.c, casetab.c, category.c:
6942 * ccl.c, character.c, charset.c, cmds.c, coding.c, composite.c:
6943 * data.c, dbusbind.c, dired.c, editfns.c, eval.c, fileio.c, fns.c:
6944 * font.c, frame.c, fringe.c, ftfont.c, image.c, keyboard.c, keymap.c:
6945 * lread.c, macros.c, minibuf.c, print.c, process.c, search.c:
6946 * sound.c, syntax.c, textprop.c, window.c, xdisp.c, xfaces.c, xfns.c:
6947 * xmenu.c, xselect.c:
6948 Declare Q* vars static if they are not used in other modules.
6949 * ccl.h, character.h, charset.h, coding.h, composite.h, font.h:
6950 * frame.h, intervals.h, keyboard.h, lisp.h, process.h, syntax.h:
6951 Remove decls of unexported vars.
6952 * keyboard.h (EVENT_HEAD_UNMODIFIED): Remove now-unused macro.
6953
6954 * lisp.h (DEFINE_FUNC): Make sname 'static'.
6955
6956 Make Emacs functions such as Fatom 'static' by default.
6957 This makes it easier for human readers (and static analyzers)
6958 to see whether these functions can be called from other modules.
6959 DEFUN now defines a static function. To make the function external
6960 so that it can be used in other C modules, use the new macro DEFUE.
6961 * lisp.h (Funibyte_char_to_multibyte, Fsyntax_table_p):
6962 (Finit_image_library):
6963 (Feval_region, Fbacktrace, Ffetch_bytecode, Fswitch_to_buffer):
6964 (Ffile_executable_p, Fmake_symbolic_link, Fcommand_execute):
6965 (Fget_process, Fdocumentation_property, Fbyte_code, Ffile_attributes):
6966 Remove decls, since these functions are now static.
6967 (Funintern, Fget_internal_run_time): New decls, since these functions
6968 were already external.
6969
6970 * alloc.c, buffer.c, callint.c, callproc.c, casefiddle.c, casetab.c:
6971 * ccl.c, character.c, chartab.c, cmds.c, coding.c, data.c, dispnew.c:
6972 * doc.c, editfns.c, emacs.c, eval.c, fileio.c, filelock.c, floatfns.c:
6973 * fns.c, font.c, fontset.c, frame.c, image.c, indent.c:
6974 * keyboard.c, keymap.c, lread.c:
6975 * macros.c, marker.c, menu.c, minibuf.c, print.c, process.c, search.c:
6976 * syntax.c, term.c, terminal.c, textprop.c, undo.c:
6977 * window.c, xdisp.c, xfaces.c, xfns.c, xmenu.c, xsettings.c:
6978 Mark functions with DEFUE instead of DEFUN,
6979 if they are used in other modules.
6980 * buffer.c (Fset_buffer_major_mode, Fdelete_overlay): New forward
6981 decls for now-static functions.
6982 * buffer.h (Fdelete_overlay): Remove decl.
6983 * callproc.c (Fgetenv_internal): Mark as internal.
6984 * composite.c (Fremove_list_of_text_properties): Remove decl.
6985 (Fcomposition_get_gstring): New forward static decl.
6986 * composite.h (Fcomposite_get_gstring): Remove decl.
6987 * dired.c (Ffile_attributes): New forward static decl.
6988 * doc.c (Fdocumntation_property): New forward static decl.
6989 * eval.c (Ffetch_bytecode): New forward static decl.
6990 (Funintern): Remove extern decl; now in .h file where it belongs.
6991 * fileio.c (Fmake_symbolic_link): New forward static decl.
6992 * image.c (Finit_image_library): New forward static decl.
6993 * insdel.c (Fcombine_after_change_execute): Make forward decl static.
6994 * intervals.h (Fprevious_property_change):
6995 (Fremove_list_of_text_properties): Remove decls.
6996 * keyboard.c (Fthis_command_keys): Remove decl.
6997 (Fcommand_execute): New forward static decl.
6998 * keymap.c (Flookup_key): New forward static decl.
6999 (Fcopy_keymap): Now static.
7000 * keymap.h (Flookup_key): Remove decl.
7001 * process.c (Fget_process): New forward static decl.
7002 (Fprocess_datagram_address): Mark as internal.
7003 * syntax.c (Fsyntax_table_p): New forward static decl.
7004 (skip_chars): Remove duplicate decl.
7005 * textprop.c (Fprevious_property_change): New forward static decl.
7006 * window.c (Fset_window_fringes, Fset_window_scroll_bars):
7007 Now internal.
7008 (Fset_window_margins, Fset_window_vscroll): New forward static decls.
7009 * window.h (Fset_window_vscroll, Fset_window_margins): Remove decls.
7010
7011 * editfns.c (Fformat): Remove unreachable code.
7012
7013 2011-04-14 Andreas Schwab <schwab@linux-m68k.org>
7014
7015 * fileio.c (Finsert_file_contents): Fix typo in 2005-05-13
7016 change. (Bug#8496)
7017
7018 2011-04-13 Eli Zaretskii <eliz@gnu.org>
7019
7020 * xdisp.c (handle_invisible_prop): Don't call bidi_paragraph_init
7021 when at ZV. (Bug#8487)
7022
7023 2011-04-12 Andreas Schwab <schwab@linux-m68k.org>
7024
7025 * charset.c (Fclear_charset_maps): Use xfree instead of free.
7026 (Bug#8437)
7027 * keyboard.c (parse_tool_bar_item): Likewise.
7028 * sound.c (sound_cleanup, alsa_close): Likewise.
7029 * termcap.c (tgetent): Likewise.
7030 * xfns.c (x_default_font_parameter): Likewise.
7031 * xsettings.c (read_and_apply_settings): Likewise.
7032
7033 * alloc.c (overrun_check_malloc, overrun_check_realloc)
7034 (overrun_check_free): Protoize.
7035
7036 2011-04-12 Paul Eggert <eggert@cs.ucla.edu>
7037
7038 * sysdep.c (emacs_read, emacs_write): Check for negative sizes
7039 since callers should never pass a negative size.
7040 Change the signature to match that of plain 'read' and 'write'; see
7041 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00397.html>.
7042 * lisp.h: Update prototypes of emacs_write and emacs_read.
7043
7044 2011-04-11 Eli Zaretskii <eliz@gnu.org>
7045
7046 * xdisp.c (redisplay_window): Don't try to determine the character
7047 position of the scroll margin if the window start point w->startp
7048 is outside the buffer's accessible region. (Bug#8468)
7049
7050 2011-04-10 Eli Zaretskii <eliz@gnu.org>
7051
7052 Fix write-region and its subroutines for buffers > 2GB.
7053 * fileio.c (a_write, e_write): Modify declaration of arguments and
7054 local variables to support buffers larger than 2GB.
7055 (Fcopy_file): Use EMACS_INT for return value of emacs_read.
7056
7057 * sysdep.c (emacs_write, emacs_read): Use ssize_t for last
7058 argument, local variables, and return value.
7059
7060 * lisp.h: Update prototypes of emacs_write and emacs_read.
7061
7062 * sound.c (vox_write): Use ssize_t for return value of emacs_write.
7063
7064 2011-04-10 Paul Eggert <eggert@cs.ucla.edu>
7065
7066 * xdisp.c (vmessage): Use memchr, not strnlen, which some hosts lack.
7067
7068 Fix more problems found by GCC 4.6.0's static checks.
7069
7070 * xdisp.c (vmessage): Use a better test for character truncation.
7071
7072 * charset.c (load_charset_map): <, not <=, for optimization,
7073 and to avoid potential problems with integer overflow.
7074 * chartab.c (sub_char_table_set_range, char_table_set_range): Likewise.
7075 * casetab.c (set_identity, shuffle): Likewise.
7076 * editfns.c (Fformat): Likewise.
7077 * syntax.c (skip_chars): Likewise.
7078
7079 * xmenu.c (set_frame_menubar): Allocate smaller local vectors.
7080 This also lets GCC 4.6.0 generate slightly better loop code.
7081
7082 * callint.c (Fcall_interactively): <, not <=, for optimization.
7083 (Fcall_interactively): Count the number of arguments produced,
7084 not the number of arguments given. This is simpler and lets GCC
7085 4.6.0 generate slightly better code.
7086
7087 * ftfont.c: Distingish more carefully between FcChar8 and char.
7088 The previous code passed unsigned char * to a functions like
7089 strlen and xstrcasecmp that expect char *, which does not
7090 conform to the C standard.
7091 (get_adstyle_property, ftfont_pattern_entity): Use FcChar8 for
7092 arguments to FcPatternGetString, and explicitly cast FcChar8 * to
7093 char * when the C standard requires it.
7094
7095 * keyboard.c (read_char): Remove unused var.
7096
7097 * eval.c: Port to Windows vsnprintf (Bug#8435).
7098 Include <limits.h>.
7099 (SIZE_MAX): Define if the headers do not.
7100 (verror): Do not give up if vsnprintf returns a negative count.
7101 Instead, grow the buffer. This ports to Windows vsnprintf, which
7102 does not conform to C99. Problem reported by Eli Zaretskii.
7103 Also, simplify the allocation scheme, by avoiding the need for
7104 calling realloc, and removing the ALLOCATED variable.
7105
7106 * eval.c (verror): Initial buffer size is 4000 (not 200) bytes.
7107
7108 Remove invocations of doprnt, as Emacs now uses vsnprintf.
7109 But keep the doprint source code for now, as we might revamp it
7110 and use it again (Bug#8435).
7111 * lisp.h (doprnt): Remove.
7112 * Makefile.in (base_obj): Remove doprnt.o.
7113 * deps.mk (doprnt.o): Remove.
7114
7115 error: Print 32- and 64-bit integers portably (Bug#8435).
7116 Without this change, on typical 64-bit hosts error ("...%d...", N)
7117 was used to print both 32- and 64-bit integers N, which relied on
7118 undefined behavior.
7119 * lisp.h, src/m/amdx86-64.h, src/m/ia64.h, src/m/ibms390x.h (pEd):
7120 New macro.
7121 * lisp.h (error, verror): Mark as printf-like functions.
7122 * eval.c (verror): Use vsnprintf, not doprnt, to do the real work.
7123 Report overflow in size calculations when allocating printf buffer.
7124 Do not truncate output string at its first null byte.
7125 * xdisp.c (vmessage): Use vsnprintf, not doprnt, to do the real work.
7126 Truncate the output at a character boundary, since vsnprintf does not
7127 do that.
7128 * charset.c (check_iso_charset_parameter): Convert internal
7129 character to string before calling 'error', since %c now has the
7130 printf meaning.
7131 * coding.c (Fdecode_sjis_char, Fdecode_big5_char): Avoid int
7132 overflow when computing char to be passed to 'error'. Do not
7133 pass Lisp_Object to 'error'; pass the integer instead.
7134 * nsfns.m (Fns_do_applescript): Use int, not long, since it's
7135 formatted with plain %d.
7136
7137 * eval.c (internal_lisp_condition_case): Don't pass spurious arg.
7138
7139 * keyboard.c (access_keymap_keyremap): Print func name, not garbage.
7140
7141 * coding.c (Fdecode_sjis_char): Don't assume CODE fits in int.
7142
7143 * xterm.c (x_catch_errors): Remove duplicate declaration.
7144
7145 * term.c (maybe_fatal): Mark its 3rd arg as a printf format, too.
7146
7147 * xdisp.c, lisp.h (message_nolog): Remove; unused.
7148
7149 2011-04-10 Jim Meyering <meyering@redhat.com>
7150
7151 use ssize_t and size_t for read- and write-like emacs_gnutls_* functions
7152 * gnutls.c (emacs_gnutls_read): Adjust signature to be more read-like:
7153 return ssize_t not "int", and use size_t as the buffer length.
7154 (emacs_gnutls_write): Likewise, and make the buffer pointer "const".
7155 * gnutls.h: Update declarations.
7156 * process.c (read_process_output): Use ssize_t, to match.
7157 (send_process): Likewise.
7158
7159 2011-04-09 Chong Yidong <cyd@stupidchicken.com>
7160
7161 * image.c (Fimagemagick_types): Doc fix, and comment cleanup.
7162
7163 2011-04-09 Chong Yidong <cyd@stupidchicken.com>
7164
7165 * ftfont.c (get_adstyle_property, ftfont_pattern_entity):
7166 Use unsigned char, to match FcChar8 type definition.
7167
7168 * xterm.c (handle_one_xevent):
7169 * xmenu.c (create_and_show_popup_menu):
7170 * xselect.c (x_decline_selection_request)
7171 (x_reply_selection_request): Avoid type-punned deref of X events.
7172
7173 2011-04-09 Eli Zaretskii <eliz@gnu.org>
7174
7175 Fix some uses of `int' instead of EMACS_INT.
7176 * search.c (string_match_1, fast_string_match)
7177 (fast_c_string_match_ignore_case, fast_string_match_ignore_case)
7178 (scan_buffer, find_next_newline_no_quit)
7179 (find_before_next_newline, search_command, Freplace_match)
7180 (Fmatch_data): Make some `int' variables be EMACS_INT.
7181
7182 * xdisp.c (display_count_lines): 3rd argument and return value now
7183 EMACS_INT. All callers changed.
7184 (pint2hrstr): Last argument is now EMACS_INT.
7185
7186 * coding.c (detect_coding_utf_8, detect_coding_emacs_mule)
7187 (detect_coding_iso_2022, detect_coding_sjis, detect_coding_big5)
7188 (detect_coding_ccl, detect_coding_charset, decode_coding_utf_8)
7189 (decode_coding_utf_16, decode_coding_emacs_mule)
7190 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5)
7191 (decode_coding_ccl, decode_coding_charset)
7192 <consumed_chars, consumed_chars_base>: Declare EMACS_INT.
7193 (decode_coding_iso_2022, decode_coding_emacs_mule)
7194 (decode_coding_sjis, decode_coding_big5, decode_coding_charset)
7195 <char_offset, last_offset>: Declare EMACS_INT.
7196 (encode_coding_utf_8, encode_coding_utf_16)
7197 (encode_coding_emacs_mule, encode_invocation_designation)
7198 (encode_designation_at_bol, encode_coding_iso_2022)
7199 (encode_coding_sjis, encode_coding_big5, encode_coding_ccl)
7200 (encode_coding_raw_text, encode_coding_charset) <produced_chars>:
7201 Declare EMACS_INT.
7202 (ASSURE_DESTINATION): Declare more_bytes EMACS_INT.
7203 (encode_invocation_designation): Last argument P_NCHARS is now
7204 EMACS_INT.
7205 (decode_eol): Declare pos_byte, pos, and pos_end EMACS_INT.
7206 (produce_chars): from_nchars and to_nchars are now EMACS_INT.
7207
7208 * coding.h (struct coding_system) <head_ascii>: Declare EMACS_INT.
7209 All users changed.
7210
7211 * ccl.c (Fccl_execute_on_string): Declare some variables
7212 EMACS_INT.
7213
7214 2011-04-08 Samuel Thibault <sthibault@debian.org> (tiny change)
7215
7216 * term.c (init_tty): Fix incorrect ifdef placement (Bug#8450).
7217
7218 2011-03-19 Christoph Scholtes <cschol2112@googlemail.com>
7219
7220 * process.c (Fformat_network_address): Doc fix.
7221
7222 2011-04-08 T.V. Raman <tv.raman.tv@gmail.com> (tiny change)
7223
7224 * xml.c (parse_region): Avoid creating spurious whitespace nodes.
7225
7226 2011-04-08 Chong Yidong <cyd@stupidchicken.com>
7227
7228 * keyboard.c (read_char): Call Lisp function help-form-show,
7229 instead of using internal_with_output_to_temp_buffer.
7230 (Qhelp_form_show): New var.
7231 (syms_of_keyboard): Use DEFSYM macro.
7232
7233 * print.c (internal_with_output_to_temp_buffer): Function deleted.
7234
7235 * lisp.h (internal_with_output_to_temp_buffer): Remove prototype.
7236
7237 2011-04-06 Chong Yidong <cyd@stupidchicken.com>
7238
7239 * process.c (Flist_processes): Remove to Lisp.
7240 (list_processes_1): Delete.
7241
7242 2011-04-06 Eli Zaretskii <eliz@gnu.org>
7243
7244 * msdos.c (careadlinkat, careadlinkatcwd): MS-DOS replacements.
7245
7246 * w32.c (careadlinkat, careadlinkatcwd): New always-fail stubs.
7247
7248 2011-04-06 Paul Eggert <eggert@cs.ucla.edu>
7249
7250 Fix more problems found by GCC 4.6.0's static checks.
7251
7252 * xmenu.c (Fx_popup_dialog): Don't assume string is free of formats.
7253
7254 * menu.c (Fx_popup_menu): Don't assume error_name lacks printf formats.
7255
7256 * lisp.h (message, message_nolog, fatal): Mark as printf-like.
7257
7258 * xdisp.c (vmessage): Mark as a printf-like function.
7259
7260 * term.c (vfatal, maybe_fatal): Mark as printf-like functions.
7261
7262 * sound.c (sound_warning): Don't crash if arg contains a printf format.
7263
7264 * image.c (tiff_error_handler, tiff_warning_handler): Mark as
7265 printf-like functions.
7266 (tiff_load): Add casts to remove these marks before passing them
7267 to system-supplied API.
7268
7269 * eval.c (Fsignal): Remove excess argument to 'fatal'.
7270
7271 * coding.c (EMIT_ONE_BYTE, EMIT_TWO_BYTES): Use unsigned, not int.
7272 This avoids several warnings with gcc -Wstrict-overflow.
7273 (DECODE_COMPOSITION_RULE): If the rule is invalid, goto invalid_code
7274 directly, rather than having caller test rule sign. This avoids
7275 some unnecessary tests.
7276 * composite.h (COMPOSITION_ENCODE_RULE_VALID): New macro.
7277 (COMPOSITION_ENCODE_RULE): Arguments now must be valid. This
7278 affects only one use, in DECODE_COMPOSITION_RULE, which is changed.
7279
7280 * xfont.c (xfont_text_extents): Remove var that was set but not used.
7281 (xfont_open): Avoid unnecessary tests.
7282
7283 * composite.c (composition_gstring_put_cache): Use unsigned integer.
7284
7285 * composite.h, composite.c (composition_gstring_put_cache):
7286 Use EMACS_INT, not int, for length.
7287
7288 * composite.h (COMPOSITION_DECODE_REFS): New macro,
7289 breaking out part of COMPOSITION_DECODE_RULE.
7290 (COMPOSITION_DECODE_RULE): Use it.
7291 * composite.c (get_composition_id): Remove unused local vars,
7292 by using the new macro.
7293
7294 * textprop.c (set_text_properties_1): Change while to do-while,
7295 since the condition is always true at first.
7296
7297 * intervals.c (graft_intervals_into_buffer): Mark var as used.
7298 (interval_deletion_adjustment): Return unsigned value.
7299 All uses changed.
7300
7301 * process.c (list_processes_1, create_pty, read_process_output):
7302 (exec_sentinel): Remove vars that were set but not used.
7303 (create_pty): Remove unnecessary "volatile"s.
7304 (Fnetwork_interface_info): Avoid possibility of int overflow.
7305 (read_process_output): Do adaptive read buffering even if carryover.
7306 (read_process_output): Simplify nbytes computation if buffered.
7307
7308 * bytecode.c (exec_byte_code): Rename local to avoid shadowing.
7309
7310 * syntax.c (scan_words): Remove var that was set but not used.
7311 (update_syntax_table): Use unsigned instead of int.
7312
7313 * lread.c (lisp_file_lexically_bound_p): Use ints rather than endptrs.
7314 (lisp_file_lexically_bound_p, read1): Use unsigned instead of int.
7315 (safe_to_load_p): Make the end-of-loop test the inverse of the in-loop.
7316
7317 * print.c (print_error_message): Avoid int overflow.
7318
7319 * font.c (font_list_entities): Redo for clarity,
7320 so that reader need not know FONT_DPI_INDEX + 1 == FONT_SPACING_INDEX.
7321
7322 * font.c (font_find_for_lface, Ffont_get_glyphs): Remove unused vars.
7323 (font_score): Avoid potential overflow in diff calculation.
7324
7325 * fns.c (substring_both): Remove var that is set but not used.
7326 (sxhash): Redo loop for clarity and to avoid wraparound warning.
7327
7328 * eval.c (funcall_lambda): Rename local to avoid shadowing.
7329
7330 * alloc.c (mark_object_loop_halt, mark_object): Use size_t, not int.
7331 Otherwise, GCC 4.6.0 optimizes the loop check away since the check
7332 can always succeed if overflow has undefined behavior.
7333
7334 * search.c (boyer_moore, wordify): Remove vars set but not used.
7335 (wordify): Omit three unnecessary tests.
7336
7337 * indent.c (MULTIBYTE_BYTES_WIDTH): Don't compute wide_column.
7338 All callers changed. This avoids the need for an unused var.
7339
7340 * casefiddle.c (casify_region): Remove var that is set but not used.
7341
7342 * dired.c (file_name_completion): Remove var that is set but not used.
7343
7344 * fileio.c (Finsert_file_contents): Make EOF condition clearer.
7345
7346 * fileio.c (Finsert_file_contents): Avoid signed integer overflow.
7347 (Finsert_file_contents): Remove unnecessary code checking fd.
7348
7349 * minibuf.c (read_minibuf_noninteractive): Use size_t for sizes.
7350 Check for integer overflow on size calculations.
7351
7352 * buffer.c (Fprevious_overlay_change): Remove var that is set
7353 but not used.
7354
7355 * keyboard.c (menu_bar_items, read_char_minibuf_menu_prompt):
7356 Remove vars that are set but not used.
7357 (timer_check_2): Don't assume timer-list and idle-timer-list are lists.
7358 (timer_check_2): Mark vars as initialized.
7359
7360 * gtkutil.c (xg_get_file_with_chooser): Mark var as initialized.
7361
7362 * image.c (lookup_image): Remove var that is set but not used.
7363 (xbm_load): Use parse_p, for gcc -Werror=unused-but-set-variable.
7364
7365 * fontset.c (Finternal_char_font, Ffontset_info): Remove vars
7366 that are set but not used.
7367
7368 * xfns.c (make_invisible_cursor): Don't return garbage
7369 if XCreateBitmapFromData fails (Bug#8410).
7370
7371 * xselect.c (x_get_local_selection, x_handle_property_notify):
7372 Remove vars that are set but not used.
7373
7374 * xfns.c (x_create_tip_frame): Remove var that is set but not used.
7375 (make_invisible_cursor): Initialize a possibly-uninitialized variable.
7376
7377 * xterm.c (x_scroll_bar_to_input_event) [!USE_GTK]:
7378 Remove var that is set but not used.
7379 (scroll_bar_windows_size): Now size_t, not int.
7380 (x_send_scroll_bar_event): Use size_t, not int, for sizes.
7381 Check for overflow.
7382
7383 * xfaces.c (realize_named_face): Remove vars that are set but not used.
7384 (map_tty_color) [!defined MSDOS]: Likewise.
7385
7386 * term.c (tty_write_glyphs): Use size_t; this avoids overflow warning.
7387
7388 * coding.c: Remove vars that are set but not used.
7389 (DECODE_COMPOSITION_RULE): Remove 2nd arg, which is unused.
7390 All callers changed.
7391 (decode_coding_utf_8, decode_coding_utf_16 decode_coding_emacs_mule):
7392 (decode_coding_iso_2022, encode_coding_sjis, encode_coding_big5):
7393 (decode_coding_charset): Remove vars that are set but not used.
7394
7395 * bytecode.c (Fbyte_code) [!defined BYTE_CODE_SAFE]: Remove var
7396 that is set but not used.
7397
7398 * print.c (print_object): Remove var that is set but not used.
7399
7400 Replace 2 copies of readlink code with 1 gnulib version (Bug#8401).
7401 The gnulib version avoids calling malloc in the usual case,
7402 and on 64-bit hosts doesn't have some arbitrary 32-bit limits.
7403 * fileio.c (Ffile_symlink_p): Use emacs_readlink.
7404 * filelock.c (current_lock_owner): Likewise.
7405 * lisp.h (READLINK_BUFSIZE, emacs_readlink): New function.
7406 * sysdep.c: Include allocator.h, careadlinkat.h.
7407 (emacs_no_realloc_allocator): New static constant.
7408 (emacs_readlink): New function.
7409 * deps.mk (sysdep.o): Depend on ../lib/allocator.h and on
7410 ../lib/careadlinkat.h.
7411
7412 2011-04-04 Stefan Monnier <monnier@iro.umontreal.ca>
7413
7414 * keyboard.c (safe_run_hook_funcall): Fix last change (don't stop at the
7415 first non-nil return value).
7416
7417 2011-04-03 Jan Djärv <jan.h.d@swipnet.se>
7418
7419 * nsterm.m (ns_update_auto_hide_menu_bar): Define MAC_OS_X_VERSION_10_6
7420 if not defined (Bug#8403).
7421
7422 2011-04-02 Juanma Barranquero <lekktu@gmail.com>
7423
7424 * xdisp.c (display_count_lines): Remove parameter `start',
7425 unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
7426 (get_char_face_and_encoding): Remove parameter `multibyte_p',
7427 unused since 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
7428 (fill_stretch_glyph_string): Remove parameters `row' and `area',
7429 unused at least since Kim's GUI unification at 2003-03-16T20:45:46Z!storm@cua.dk
7430 and thereabouts. All callers changed.
7431 (get_per_char_metric): Remove parameter `f', unused since
7432 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
7433
7434 2011-04-02 Jim Meyering <meyering@redhat.com>
7435
7436 do not dereference NULL upon failed strdup
7437 * nsfont.m (ns_descriptor_to_entity): Use xstrdup, not strdup.
7438 (ns_get_family): Likewise.
7439
7440 2011-04-02 Juanma Barranquero <lekktu@gmail.com>
7441
7442 * eval.c (unwind_to_catch) [DEBUG_GCPRO]: Remove redundant assignment.
7443
7444 2011-04-02 Jan Djärv <jan.h.d@swipnet.se>
7445
7446 * nsterm.m (ns_update_auto_hide_menu_bar): Only for OSX 10.6 or
7447 later (Bug#8403).
7448
7449 2011-04-01 Stefan Monnier <monnier@iro.umontreal.ca>
7450
7451 Add lexical binding.
7452
7453 * window.c (Ftemp_output_buffer_show): New fun.
7454 (Fsave_window_excursion):
7455 * print.c (Fwith_output_to_temp_buffer): Move to subr.el.
7456
7457 * lread.c (lisp_file_lexically_bound_p): New function.
7458 (Fload): Bind Qlexical_binding.
7459 (readevalloop): Remove `evalfun' arg.
7460 Bind Qinternal_interpreter_environment.
7461 (Feval_buffer): Bind Qlexical_binding.
7462 (defvar_int, defvar_bool, defvar_lisp_nopro, defvar_kboard):
7463 Mark as dynamic.
7464 (syms_of_lread): Declare `lexical-binding'.
7465
7466 * lisp.h (struct Lisp_Symbol): New field `declared_special'.
7467
7468 * keyboard.c (eval_dyn): New fun.
7469 (menu_item_eval_property): Use it.
7470
7471 * image.c (parse_image_spec): Use Ffunctionp.
7472
7473 * fns.c (concat, mapcar1): Accept byte-code-functions.
7474
7475 * eval.c (Fsetq): Handle lexical vars.
7476 (Fdefun, Fdefmacro, Ffunction): Make closures when needed.
7477 (Fdefconst, Fdefvaralias, Fdefvar): Mark as dynamic.
7478 (FletX, Flet): Obey lexical binding.
7479 (Fcommandp): Handle closures.
7480 (Feval): New `lexical' arg.
7481 (eval_sub): New function extracted from Feval. Use it almost
7482 everywhere where Feval was used. Look up vars in lexical env.
7483 Handle closures.
7484 (Ffunctionp): Move from subr.el.
7485 (Ffuncall): Handle closures.
7486 (apply_lambda): Remove `eval_flags'.
7487 (funcall_lambda): Handle closures and new byte-code-functions.
7488 (Fspecial_variable_p): New function.
7489 (syms_of_eval): Initialize the Vinternal_interpreter_environment var,
7490 but without exporting it to Lisp.
7491
7492 * doc.c (Fdocumentation, store_function_docstring):
7493 * data.c (Finteractive_form): Handle closures.
7494
7495 * callint.c (Fcall_interactively): Preserve lexical-binding mode for
7496 interactive spec.
7497
7498 * bytecode.c (Bstack_ref, Bstack_set, Bstack_set2, BdiscardN):
7499 New byte-codes.
7500 (exec_byte_code): New function extracted from Fbyte_code to handle new
7501 calling convention for byte-code-functions. Add new byte-codes.
7502
7503 * buffer.c (defvar_per_buffer): Set new `declared_special' field.
7504
7505 * alloc.c (Fmake_symbol): Init new `declared_special' field.
7506
7507 2011-03-31 Juanma Barranquero <lekktu@gmail.com>
7508
7509 * xdisp.c (redisplay_internal): Fix prototype.
7510
7511 2011-03-31 Eli Zaretskii <eliz@gnu.org>
7512
7513 * xdisp.c (SCROLL_LIMIT): New macro.
7514 (try_scrolling): Use it when setting scroll_limit.
7515 Limit scrolling to 100 screen lines.
7516 (redisplay_window): Even when falling back on "recentering",
7517 position point in the window according to scroll-conservatively,
7518 scroll-margin, and scroll-*-aggressively variables. (Bug#6671)
7519
7520 (try_scrolling): When point is above the window, allow searching
7521 as far as scroll_max, or one screenful, to compute vertical
7522 distance from PT to the scroll margin position. This prevents
7523 try_scrolling from unnecessarily failing when
7524 scroll-conservatively is set to a value slightly larger than the
7525 window height. Clean up the case of PT below the margin at bottom
7526 of window: scroll_max can no longer be INT_MAX. When aggressive
7527 scrolling is in use, don't let point enter the opposite scroll
7528 margin as result of the scroll.
7529 (syms_of_xdisp) <scroll-conservatively>: Document the
7530 threshold of 100 lines for never-recentering scrolling.
7531
7532 2011-03-31 Juanma Barranquero <lekktu@gmail.com>
7533
7534 * dispextern.h (move_it_by_lines):
7535 * xdisp.c (move_it_by_lines): Remove parameter `need_y_p', unused
7536 since 2000-12-29T14:24:09Z!gerd@gnu.org. All callers changed.
7537 (message_log_check_duplicate): Remove parameters `prev_bol' and
7538 `this_bol', unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
7539 (redisplay_internal): Remove parameter `preserve_echo_area',
7540 unused since 1999-07-21T21:43:52Z!gerd@gnu.org. All callers changed.
7541
7542 * indent.c (Fvertical_motion):
7543 * window.c (window_scroll_pixel_based, Frecenter):
7544 Don't pass `need_y_p' to `move_it_by_lines'.
7545
7546 2011-03-30 Stefan Monnier <monnier@iro.umontreal.ca>
7547
7548 * eval.c (struct backtrace): Don't cheat with negative numbers, but do
7549 steal a few bits to be more compact.
7550 (interactive_p, Fbacktrace, Fbacktrace_frame, mark_backtrace):
7551 Remove unneeded casts.
7552
7553 * bytecode.c (Fbyte_code): CAR and CDR can GC.
7554
7555 2011-03-30 Zachary Kanfer <zkanfer@gmail.com> (tiny change)
7556
7557 * keyboard.c (Fexecute_extended_command): Do log the "suggest key
7558 binding" message (bug#7967).
7559
7560 2011-03-30 Paul Eggert <eggert@cs.ucla.edu>
7561
7562 Fix more problems found by GCC 4.6.0's static checks.
7563
7564 * unexelf.c (unexec) [! (defined _SYSTYPE_SYSV || defined __sgi)]:
7565 Remove unused local var.
7566
7567 * editfns.c (Fmessage_box): Remove unused local var.
7568
7569 * xdisp.c (try_window_reusing_current_matrix, x_produce_glyphs):
7570 (note_mode_line_or_margin_highlight, note_mouse_highlight):
7571 Omit unused local vars.
7572 * window.c (shrink_windows): Omit unused local var.
7573 * menu.c (digest_single_submenu): Omit unused local var.
7574 * dispnew.c (update_window) [PERIODIC_PREEMPTION_CHECKING]:
7575 Omit unused local var.
7576
7577 * keyboard.c (parse_modifiers_uncached, parse_modifiers):
7578 Don't assume string length fits in int.
7579 (keyremap_step, read_key_sequence): Use size_t for sizes.
7580 (read_key_sequence): Don't check last_real_key_start redundantly.
7581
7582 * callproc.c (Fcall_process, Fcall_process_region): Use SAFE_ALLOCA
7583 instead of alloca (Bug#8344).
7584
7585 * eval.c (Fbacktrace): Don't assume nargs fits in int.
7586 (Fbacktrace_frame): Don't assume nframes fits in int.
7587
7588 * syntax.c (scan_sexps_forward): Avoid pointer wraparound.
7589
7590 * xterm.c (x_make_frame_visible, same_x_server): Redo to avoid overflow
7591 concerns.
7592
7593 * term.c (produce_glyphless_glyph): Remove unnecessary test.
7594
7595 * cm.c (calccost): Turn while-do into do-while, for clarity.
7596
7597 * keyboard.c (syms_of_keyboard): Use the same style as later
7598 in this function when indexing through an array. This also
7599 works around GCC bug 48267.
7600
7601 * image.c (tiff_load): Fix off-by-one image count (Bug#8336).
7602
7603 * xselect.c (x_check_property_data): Return correct size (Bug#8335).
7604
7605 * chartab.c (sub_char_table_ref_and_range): Redo for slight
7606 efficiency gain, and to bypass a gcc -Wstrict-overflow warning.
7607
7608 * keyboard.c, keyboard.h (num_input_events): Now size_t.
7609 This avoids undefined behavior on integer overflow, and is a bit
7610 more convenient anyway since it is compared to a size_t variable.
7611
7612 Variadic C functions now count arguments with size_t, not int.
7613 This avoids an unnecessary limitation on 64-bit machines, which
7614 caused (substring ...) to crash on large vectors (Bug#8344).
7615 * lisp.h (struct Lisp_Subr.function.aMANY): Now takes size_t, not int.
7616 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call): Likewise.
7617 All variadic functions and their callers changed accordingly.
7618 (struct gcpro.nvars): Now size_t, not int. All uses changed.
7619 * data.c (arith_driver, float_arith_driver): Likewise.
7620 * editfns.c (general_insert_function): Likewise.
7621 * eval.c (struct backtrace.nargs, interactive_p)
7622 (internal_condition_case_n, run_hook_with_args, apply_lambda)
7623 (funcall_lambda, mark_backtrace): Likewise.
7624 * fns.c (concat): Likewise.
7625 * frame.c (x_set_frame_parameters): Likewise.
7626 * fns.c (get_key_arg): Now accepts and returns size_t, and returns
7627 0 if not found, not -1. All callers changed.
7628
7629 * alloc.c (garbage_collect): Don't assume stack size fits in int.
7630 (stack_copy_size): Now size_t, not int.
7631 (stack_copy, stack_copy_size): Define only if MAX_SAVE_STACK > 0.
7632
7633 2011-03-28 Juanma Barranquero <lekktu@gmail.com>
7634
7635 * coding.c (encode_designation_at_bol): Remove parameter `charbuf_end',
7636 unused since 2002-03-01T01:17:24Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
7637 All callers changed.
7638
7639 * lisp.h (multibyte_char_to_unibyte):
7640 * character.c (multibyte_char_to_unibyte): Remove parameter `rev_tbl',
7641 unused since 2002-03-01T01:16:34Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
7642 * character.h (CHAR_TO_BYTE8):
7643 * cmds.c (internal_self_insert):
7644 * editfns.c (general_insert_function):
7645 * keymap.c (push_key_description):
7646 * search.c (Freplace_match):
7647 * xdisp.c (message_dolog, set_message_1): All callers changed.
7648
7649 2011-03-28 Stefan Monnier <monnier@iro.umontreal.ca>
7650
7651 * keyboard.c (safe_run_hook_funcall): New function.
7652 (safe_run_hooks_1, safe_run_hooks_error, safe_run_hooks): On error,
7653 don't set the hook to nil, but remove the offending function instead.
7654 (Qcommand_hook_internal): Remove, unused.
7655 (syms_of_keyboard): Don't initialize Qcommand_hook_internal nor define
7656 Vcommand_hook_internal.
7657
7658 * eval.c (enum run_hooks_condition): Remove.
7659 (funcall_nil, funcall_not): New functions.
7660 (run_hook_with_args): Call each function through a `funcall' argument.
7661 Remove `cond' argument, now redundant.
7662 (Frun_hooks, Frun_hook_with_args, Frun_hook_with_args_until_success)
7663 (Frun_hook_with_args_until_failure): Adjust accordingly.
7664 (run_hook_wrapped_funcall, Frun_hook_wrapped): New functions.
7665
7666 2011-03-28 Juanma Barranquero <lekktu@gmail.com>
7667
7668 * dispextern.h (string_buffer_position): Remove declaration.
7669
7670 * print.c (strout): Remove parameter `multibyte', unused since
7671 1999-08-21T19:30:21Z!gerd@gnu.org. All callers changed.
7672
7673 * search.c (boyer_moore): Remove parameters `len', `pos' and `lim',
7674 never used since function introduction in 1998-02-08T21:33:56Z!rms@gnu.org.
7675 All callers changed.
7676
7677 * w32.c (_wsa_errlist): Use braces for struct initializers.
7678
7679 * xdisp.c (string_buffer_position_lim): Remove parameter `w',
7680 never used since function introduction in 2001-03-09T18:41:50Z!gerd@gnu.org.
7681 All callers changed.
7682 (string_buffer_position): Likewise. Also, make static (it's never
7683 used outside xdisp.c).
7684 (cursor_row_p): Remove parameter `w', unused since
7685 2000-10-17T16:08:57Z!gerd@gnu.org. All callers changed.
7686 (decode_mode_spec): Remove parameter `precision', introduced during
7687 Gerd Moellmann's rewrite at 1999-07-21T21:43:52Z!gerd@gnu.org, but never used.
7688 All callers changed.
7689
7690 2011-03-27 Jan Djärv <jan.h.d@swipnet.se>
7691
7692 * nsterm.m (syms_of_nsterm): Use doc: for ns-auto-hide-menu-bar.
7693
7694 2011-03-27 Anders Lindgren <andlind@gmail.com>
7695
7696 * nsterm.m (ns_menu_bar_is_hidden): New variable.
7697 (ns_constrain_all_frames, ns_menu_bar_should_be_hidden)
7698 (ns_update_auto_hide_menu_bar): New functions.
7699 (ns_update_begin): Call ns_update_auto_hide_menu_bar.
7700 (applicationDidBecomeActive): Call ns_update_auto_hide_menu_bar and
7701 ns_constrain_all_frames.
7702 (constrainFrameRect): Return at once if ns_menu_bar_should_be_hidden.
7703 (syms_of_nsterm): DEFVAR ns-auto-hide-menu-bar, init to Qnil.
7704
7705 2011-03-27 Jan Djärv <jan.h.d@swipnet.se>
7706
7707 * nsmenu.m (runDialogAt): Remove argument to timer_check.
7708
7709 2011-03-27 Glenn Morris <rgm@gnu.org>
7710
7711 * syssignal.h: Replace RETSIGTYPE with void.
7712 * atimer.c, data.c, dispnew.c, emacs.c, floatfns.c, keyboard.c:
7713 * keyboard.h, lisp.h, process.c, sysdep.c, xterm.c:
7714 Replace SIGTYPE with void everywhere.
7715 * s/usg5-4-common.h (SIGTYPE): Remove definition.
7716 * s/template.h (SIGTYPE): Remove commented out definition.
7717
7718 2011-03-26 Eli Zaretskii <eliz@gnu.org>
7719
7720 * xdisp.c (redisplay_window): Don't check buffer's clip_changed
7721 flag as a prerequisite for invoking try_scrolling. (Bug#6671)
7722
7723 2011-03-26 Juanma Barranquero <lekktu@gmail.com>
7724
7725 * w32.c (read_unc_volume): Use parameter `henum', instead of
7726 global variable `wget_enum_handle'.
7727
7728 * keymap.c (describe_vector): Remove parameters `indices' and
7729 `char_table_depth', unused since 2002-03-01T01:43:26Z!handa@m17n.org.
7730 (describe_map, Fdescribe_vector): Adjust calls to `describe_vector'.
7731
7732 * keyboard.h (timer_check, show_help_echo): Remove unused parameters.
7733
7734 * keyboard.c (timer_check): Remove parameter `do_it_now',
7735 unused since 1996-04-12T06:01:29Z!rms@gnu.org.
7736 (show_help_echo): Remove parameter `ok_to_overwrite_keystroke_echo',
7737 unused since 2008-04-19T19:30:53Z!monnier@iro.umontreal.ca.
7738
7739 * keyboard.c (read_char):
7740 * w32menu.c (w32_menu_display_help):
7741 * xmenu.c (show_help_event, menu_help_callback):
7742 Adjust calls to `show_help_echo'.
7743
7744 * gtkutil.c (xg_maybe_add_timer):
7745 * keyboard.c (readable_events):
7746 * process.c (wait_reading_process_output):
7747 * xmenu.c (x_menu_wait_for_event): Adjust calls to `timer_check'.
7748
7749 * insdel.c (adjust_markers_gap_motion):
7750 Remove; no-op since 1998-01-02T21:29:48Z!rms@gnu.org.
7751 (gap_left, gap_right): Don't call it.
7752
7753 2011-03-25 Chong Yidong <cyd@stupidchicken.com>
7754
7755 * xdisp.c (handle_fontified_prop): Discard changes to clip_changed
7756 incurred during fontification.
7757
7758 2011-03-25 Juanma Barranquero <lekktu@gmail.com>
7759
7760 * buffer.c (defvar_per_buffer): Remove unused parameter `doc'.
7761 (DEFVAR_PER_BUFFER): Don't pass it.
7762
7763 * dispnew.c (row_equal_p, add_row_entry): Remove unused parameter `w'.
7764 (scrolling_window): Don't pass it.
7765
7766 2011-03-25 Juanma Barranquero <lekktu@gmail.com>
7767
7768 * dispextern.h (glyph_matric): Use #if GLYPH_DEBUG, not #ifdef.
7769
7770 * fileio.c (check_executable) [DOS_NT]: Remove unused variables `len'
7771 and `suffix'.
7772 (Fset_file_selinux_context) [HAVE_LIBSELINUX]: Move here declaration
7773 of variables specific to SELinux and computation of `encoded_absname'.
7774
7775 * image.c (XPutPixel): Remove unused variable `height'.
7776
7777 * keyboard.c (make_lispy_event): Remove unused variable `hpos'.
7778
7779 * unexw32.c (get_section_info): Remove unused variable `section'.
7780
7781 * w32.c (stat): Remove unused variables `drive_root' and `devtype'.
7782 (system_process_attributes): Remove unused variable `sess'.
7783 (sys_read): Remove unused variable `err'.
7784
7785 * w32fns.c (top): Wrap variables with #if GLYPH_DEBUG, not #ifdef.
7786 (w32_wnd_proc): Remove unused variable `isdead'.
7787 (unwind_create_frame): Use #if GLYPH_DEBUG, not #ifdef.
7788 (Fx_server_max_request_size): Remove unused variable `dpyinfo'.
7789 (x_create_tip_frame): Remove unused variable `tem'.
7790
7791 * w32inevt.c (w32_console_read_socket):
7792 Remove unused variable `no_events'.
7793
7794 * w32term.c (x_draw_composite_glyph_string_foreground):
7795 Remove unused variable `width'.
7796
7797 2011-03-24 Juanma Barranquero <lekktu@gmail.com>
7798
7799 * w32term.c (x_set_glyph_string_clipping):
7800 Don't pass uninitialized region to CombineRgn.
7801
7802 2011-03-23 Juanma Barranquero <lekktu@gmail.com>
7803
7804 * w32fns.c (x_set_menu_bar_lines): Remove unused variable `olines'.
7805 (w32_wnd_proc): Pass NULL to Windows API, not uninitialized buffer.
7806 (Fx_close_connection): Remove unused variable `i'.
7807
7808 * w32font.c (w32font_draw): Return number of glyphs.
7809 (w32font_open_internal): Remove unused variable `i'.
7810 (w32font_driver): Add missing initializer.
7811
7812 * w32menu.c (utf8to16): Remove unused variable `utf16'.
7813 (fill_in_menu): Remove unused variable `items_added'.
7814
7815 * w32term.c (last_mouse_press_frame): Remove static global variable.
7816 (w32_clip_to_row): Remove unused variable `f'.
7817 (x_delete_terminal): Remove unused variable `i'.
7818
7819 * w32uniscribe.c (uniscribe_shape): Remove unused variable `nclusters'.
7820 (NOTHING): Remove unused static global variable.
7821 (uniscribe_check_otf): Remove unused variable `table'.
7822 (uniscribe_font_driver): Add missing initializers.
7823
7824 2011-03-23 Julien Danjou <julien@danjou.info>
7825
7826 * term.c (Fsuspend_tty, Fresume_tty):
7827 * minibuf.c (read_minibuf, run_exit_minibuf_hook):
7828 * window.c (temp_output_buffer_show):
7829 * insdel.c (signal_before_change):
7830 * frame.c (Fhandle_switch_frame):
7831 * fileio.c (Fdo_auto_save):
7832 * emacs.c (Fkill_emacs):
7833 * editfns.c (save_excursion_restore):
7834 * cmds.c (internal_self_insert):
7835 * callint.c (Fcall_interactively):
7836 * buffer.c (Fkill_all_local_variables):
7837 * keyboard.c (Fcommand_execute, Fsuspend_emacs, safe_run_hooks_1):
7838 Use Frun_hooks.
7839 (command_loop_1): Use Frun_hooks. Call safe_run_hooks
7840 unconditionally since it does the check itself.
7841
7842 2011-03-23 Paul Eggert <eggert@cs.ucla.edu>
7843
7844 Fix more problems found by GCC 4.5.2's static checks.
7845
7846 * coding.c (encode_coding_raw_text): Avoid unnecessary test
7847 the first time through the loop, since we know p0 < p1 then.
7848 This also avoids a gcc -Wstrict-overflow warning.
7849
7850 * lisp.h (SAFE_ALLOCA, SAFE_ALLOCA_LISP): Avoid 'int' overflow
7851 leading to a memory leak, possible in functions like
7852 load_charset_map_from_file that can allocate an unbounded number
7853 of objects (Bug#8318).
7854
7855 * xmenu.c (set_frame_menubar): Use EMACS_UINT, not int, for indexes
7856 that could (at least in theory) be that large.
7857
7858 * xdisp.c (message_log_check_duplicate): Return unsigned long, not int.
7859 This is less likely to overflow, and avoids undefined behavior if
7860 overflow does occur. All callers changed. Use strtoul to scan
7861 for the unsigned long integer.
7862 (pint2hrstr): Simplify and tune code slightly.
7863 This also avoids a (bogus) GCC warning with gcc -Wstrict-overflow.
7864
7865 * scroll.c (do_scrolling): Work around GCC bug 48228.
7866 See <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=48228>.
7867
7868 * frame.c (Fmodify_frame_parameters): Simplify loop counter.
7869 This also avoids a warning with gcc -Wstrict-overflow.
7870 (validate_x_resource_name): Simplify count usage.
7871 This also avoids a warning with gcc -Wstrict-overflow.
7872
7873 * fileio.c (Fcopy_file): Report error if fchown or fchmod
7874 fail (Bug#8306).
7875
7876 * emacs.c (Fdaemon_initialized): Do not ignore I/O errors (Bug#8303).
7877
7878 * process.c (Fmake_network_process): Use socklen_t, not int,
7879 where POSIX says socklen_t is required in portable programs.
7880 This fixes a porting bug on hosts like 64-bit HP-UX, where
7881 socklen_t is wider than int (Bug#8277).
7882 (Fmake_network_process, server_accept_connection):
7883 (wait_reading_process_output, read_process_output):
7884 Likewise.
7885
7886 * process.c: Rename or move locals to avoid shadowing.
7887 (list_processes_1, Fmake_network_process):
7888 (read_process_output_error_handler, exec_sentinel_error_handler):
7889 Rename or move locals.
7890 (Fmake_network_process): Define label "retry_connect" only if needed.
7891 (Fnetwork_interface_info): Fix pointer signedness.
7892 (process_send_signal): Add cast to avoid pointer signedness problem.
7893 (FIRST_PROC_DESC, IF_NON_BLOCKING_CONNECT): Remove unused macros.
7894 (create_process): Use 'volatile' to avoid vfork clobbering (Bug#8298).
7895
7896 Make tparam.h and terminfo.c consistent.
7897 * cm.c (tputs, tgoto, BC, UP): Remove extern decls.
7898 Include tparam.h instead, since it declares them.
7899 * cm.h (PC): Remove extern decl; tparam.h now does this.
7900 * deps.mk (cm.o, terminfo.o): Depend on tparam.h.
7901 * terminfo.c: Include tparam.h, to check interfaces.
7902 (tparm): Make 1st arg a const pointer in decl. Put it at top level.
7903 (tparam): Adjust signature to match interface in tparam.h;
7904 this removes some undefined behavior. Check that outstring and len
7905 are zero, which they always are with Emacs.
7906 * tparam.h (PC, BC, UP): New extern decls.
7907
7908 * xftfont.c (xftfont_shape): Now static, and defined only if needed.
7909 (xftfont_open): Rename locals to avoid shadowing.
7910
7911 * ftfont.c (ftfont_resolve_generic_family): Fix pointer signedness.
7912 (ftfont_otf_capability, ftfont_shape): Omit decls if not needed.
7913 (OTF_TAG_SYM): Omit macro if not needed.
7914 (ftfont_list): Remove unused local.
7915 (get_adstyle_property, ftfont_pattern_entity):
7916 (ftfont_lookup_cache, ftfont_open, ftfont_anchor_point):
7917 Rename locals to avoid shadowing.
7918
7919 * xfont.c (xfont_list_family): Mark var as initialized.
7920
7921 * xml.c (make_dom): Now static.
7922
7923 * composite.c (composition_compute_stop_pos): Rename local to
7924 avoid shadowing.
7925 (composition_reseat_it): Remove unused locals.
7926 (find_automatic_composition, composition_adjust_point): Likewise.
7927 (composition_update_it): Mark var as initialized.
7928 (find_automatic_composition): Mark vars as initialized,
7929 with a FIXME (Bug#8290).
7930
7931 character.h: Rename locals to avoid shadowing.
7932 * character.h (PREV_CHAR_BOUNDARY, FETCH_STRING_CHAR_ADVANCE):
7933 (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE, FETCH_CHAR_ADVANCE):
7934 (FETCH_CHAR_ADVANCE_NO_CHECK, INC_POS, DEC_POS, BUF_INC_POS):
7935 (BUF_DEC_POS): Be more systematic about renaming local temporaries
7936 to avoid shadowing.
7937
7938 * textprop.c (property_change_between_p): Remove; unused.
7939
7940 * intervals.c (interval_start_pos): Now static.
7941
7942 * intervals.h (CHECK_TOTAL_LENGTH): Avoid empty "else".
7943
7944 * atimer.c (start_atimer, append_atimer_lists, set_alarm):
7945 Rename locals to avoid shadowing.
7946
7947 * sound.c (wav_play, au_play, Fplay_sound_internal):
7948 Fix pointer signedness.
7949 (alsa_choose_format): Remove unused local var.
7950 (wav_play): Initialize a variable to 0, to prevent undefined
7951 behavior (Bug#8278).
7952
7953 * region-cache.c (insert_cache_boundary): Redo var to avoid shadowing.
7954
7955 * region-cache.h (pp_cache): New decl, for gcc -Wmissing-prototypes.
7956
7957 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork
7958 clobbering (Bug#8298).
7959 * sysdep.c (sys_subshell): Likewise.
7960 Previously, the sys_subshell 'volatile' was incorrectly IF_LINTted out.
7961
7962 * lisp.h (child_setup): Now NO_RETURN unless DOS_NT.
7963 This should get cleaned up, so that child_setup has the
7964 same signature on all platforms.
7965
7966 * callproc.c (call_process_cleanup): Now static.
7967 (relocate_fd): Rename locals to avoid shadowing.
7968
7969 2011-03-22 Chong Yidong <cyd@stupidchicken.com>
7970
7971 * xterm.c (x_clear_frame): Remove XClearWindow call. This appears
7972 not to be necessary, and produces flickering.
7973
7974 2011-03-20 Glenn Morris <rgm@gnu.org>
7975
7976 * config.in: Remove file.
7977
7978 2011-03-20 Juanma Barranquero <lekktu@gmail.com>
7979
7980 * minibuf.c (Vcompleting_read_function): Don't declare, global variables
7981 are now in src/globals.h.
7982 (syms_of_minibuf): Remove spurious & from previous change.
7983
7984 2011-03-20 Leo <sdl.web@gmail.com>
7985
7986 * minibuf.c (completing-read-function): New variable.
7987 (completing-read-default): Rename from completing-read.
7988 (completing-read): Call completing-read-function.
7989
7990 2011-03-19 Juanma Barranquero <lekktu@gmail.com>
7991
7992 * xfaces.c (Fx_load_color_file):
7993 Read color file from absolute filename (bug#8250).
7994
7995 2011-03-19 Juanma Barranquero <lekktu@gmail.com>
7996
7997 * makefile.w32-in: Update dependencies.
7998
7999 2011-03-17 Eli Zaretskii <eliz@gnu.org>
8000
8001 * makefile.w32-in ($(BLD)/unexw32.$(O)): Depend on $(SRC)/unexec.h.
8002
8003 2011-03-17 Paul Eggert <eggert@cs.ucla.edu>
8004
8005 Fix more problems found by GCC 4.5.2's static checks.
8006
8007 * process.c (make_serial_process_unwind, send_process_trap):
8008 (sigchld_handler): Now static.
8009
8010 * process.c (allocate_pty): Let PTY_ITERATION declare iteration vars.
8011 That way, the code declares only the vars that it needs.
8012 * s/aix4-2.h (PTY_ITERATION): Declare iteration vars.
8013 * s/cygwin.h (PTY_ITERATION): Likewise.
8014 * s/darwin.h (PTY_ITERATION): Likewise.
8015 * s/gnu-linux.h (PTY_ITERATION): Likewise.
8016
8017 * s/irix6-5.h (PTY_OPEN): Declare stb, to loosen coupling.
8018 * process.c (allocate_pty): Don't declare stb unless it's needed.
8019
8020 * bytecode.c (MAYBE_GC): Rewrite so as not to use empty "else".
8021 (CONSTANTLIM): Remove; unused.
8022 (METER_CODE, Bscan_buffer, Bread_char, Bset_mark):
8023 Define only if needed.
8024
8025 * unexelf.c (unexec): Name an expression,
8026 to avoid gcc -Wbad-function-cast warning.
8027 Use a different way to cause a compilation error if anyone uses
8028 n rather than nn, a way that does not involve shadowing.
8029 (ELF_BSS_SECTION_NAME, OLD_PROGRAM_H): Remove; unused.
8030
8031 * deps.mk (unexalpha.o): Remove; unused.
8032
8033 New file unexec.h, the (simple) interface for unexec (Bug#8267).
8034 * unexec.h: New file.
8035 * deps.mk (emacs.o, unexaix.o, unexcw.o, unexcoff.o, unexelf.o):
8036 (unexhp9k800.o, unexmacosx.o, unexsol.o, unexw32.o):
8037 Depend on unexec.h.
8038 * emacs.c [!defined CANNOT_DUMP]: Include unexec.h.
8039 * unexaix.c, unexcoff.c, unexcw.c, unexelf.c, unexhp9k800.c:
8040 * unexmacosx.c, unexsol.c, unexw32.c: Include unexec.h.
8041 Change as necessary to match prototype in unexec.h.
8042
8043 * syntax.c (Fforward_comment, scan_lists): Rename locals to avoid
8044 shadowing.
8045 (back_comment, skip_chars): Mark vars as initialized.
8046
8047 * character.h (FETCH_STRING_CHAR_ADVANCE_NO_CHECK, BUF_INC_POS):
8048 Rename locals to avoid shadowing.
8049
8050 * lread.c (read1): Rewrite so as not to use empty "else".
8051 (Fload, readevalloop, read1): Rename locals to avoid shadowing.
8052
8053 * print.c (Fredirect_debugging_output): Fix pointer signedess.
8054
8055 * lisp.h (debug_output_compilation_hack): Add decl here, to avoid
8056 warning when compiling print.c.
8057
8058 * font.c (font_unparse_fcname): Abort in an "impossible" situation
8059 instead of using an uninitialized var.
8060 (font_sort_entities): Mark var as initialized.
8061
8062 * character.h (FETCH_CHAR_ADVANCE): Rename locals to avoid shadowing.
8063
8064 * font.c (font_unparse_xlfd): Don't mix pointers to variables with
8065 pointers to constants.
8066 (font_parse_fcname): Remove unused vars.
8067 (font_delete_unmatched): Now static.
8068 (font_get_spec): Remove; unused.
8069 (font_style_to_value, font_prop_validate_style, font_unparse_fcname):
8070 (font_update_drivers, Ffont_get_glyphs, font_add_log):
8071 Rename or move locals to avoid shadowing.
8072
8073 * fns.c (require_nesting_list, require_unwind): Now static.
8074 (Ffillarray): Rename locals to avoid shadowing.
8075
8076 * floatfns.c (domain_error2): Define only if needed.
8077 (Ffrexp, Fldexp): Rename locals to avoid shadowing.
8078
8079 * alloc.c (mark_backtrace): Move decl from here ...
8080 * lisp.h: ... to here, so that it can be checked.
8081
8082 * eval.c (call_debugger, do_debug_on_call, grow_specpdl): Now static.
8083 (Fdefvar): Rewrite so as not to use empty "else".
8084 (lisp_indirect_variable): Name an expression,
8085 to avoid gcc -Wbad-function-cast warning.
8086 (Fdefvar): Rename locals to avoid shadowing.
8087
8088 * callint.c (quotify_arg, quotify_args): Now static.
8089 (Fcall_interactively): Rename locals to avoid shadowing.
8090 Use const pointer when appropriate.
8091
8092 * lisp.h (get_system_name, get_operating_system_release):
8093 Move decls here, to check interfaces.
8094 * process.c (get_operating_system_release): Move decl to lisp.h.
8095 * xrdb.c (get_system_name): Likewise.
8096 * editfns.c (init_editfns, Fuser_login_name, Fuser_uid):
8097 (Fuser_real_uid, Fuser_full_name): Remove unnecessary casts,
8098 some of which prompt warnings from gcc -Wbad-function-cast.
8099 (Fformat_time_string, Fencode_time, Finsert_char):
8100 (Ftranslate_region_internal, Fformat):
8101 Rename or remove local vars to avoid shadowing.
8102 (Ftranslate_region_internal): Mark var as initialized.
8103
8104 * doc.c (Fdocumentation, Fsnarf_documentation): Move locals to
8105 avoid shadowing.
8106
8107 * lisp.h (eassert): Check that the argument compiles, even if
8108 ENABLE_CHECKING is not defined.
8109
8110 * data.c (Findirect_variable): Name an expression, to avoid
8111 gcc -Wbad-function-cast warning.
8112 (default_value, arithcompare, arith_driver, arith_error): Now static.
8113 (store_symval_forwarding): Rename local to avoid shadowing.
8114 (Fmake_variable_buffer_local, Fmake_local_variable):
8115 Mark variables as initialized.
8116 (do_blv_forwarding, do_symval_forwarding): Remove; unused.
8117
8118 * alloc.c (check_cons_list): Do not define unless GC_CHECK_CONS_LIST.
8119 (Fmake_vector, Fvector, Fmake_byte_code, Fgarbage_collect):
8120 Rename locals to avoid shadowing.
8121 (mark_stack): Move local variables into the #ifdef region where
8122 they're used.
8123 (BLOCK_INPUT_ALLOC, UNBLOCK_INPUT_ALLOC): Define only if
8124 ! defined SYSTEM_MALLOC && ! defined SYNC_INPUT, as they are not
8125 needed otherwise.
8126 (CHECK_ALLOCATED): Define only if GC_CHECK_MARKED_OBJECTS.
8127 (GC_STRING_CHARS): Remove; not used.
8128 (Fmemory_limit): Cast sbrk's returned value to char *.
8129
8130 * lisp.h (check_cons_list): Declare if GC_CHECK_CONS_LIST; this
8131 avoids undefined behavior in theory.
8132
8133 * regex.c (IF_LINT): Add defn, for benefit of ../lib-src.
8134
8135 Use functions, not macros, for up- and down-casing (Bug#8254).
8136 * buffer.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
8137 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Remove. All callers changed
8138 to use the following functions instead of these macros.
8139 (downcase): Adjust to lack of DOWNCASE_TABLE. Return int, not
8140 EMACS_INT, since callers assume the returned value fits in int.
8141 (upcase1): Likewise, for UPCASE_TABLE.
8142 (uppercasep, lowercasep, upcase): New static inline functions.
8143 * editfns.c (Fchar_equal): Remove no-longer-needed workaround for
8144 the race-condition problem in the old DOWNCASE.
8145
8146 * regex.c (CHARSET_LOOKUP_RANGE_TABLE_RAW, POP_FAILURE_REG_OR_COUNT):
8147 Rename locals to avoid shadowing.
8148 (regex_compile, re_match_2_internal): Move locals to avoid shadowing.
8149 (regex_compile, re_search_2, re_match_2_internal):
8150 Remove unused local vars.
8151 (FREE_VAR): Rewrite so as not to use empty "else",
8152 which gcc can warn about.
8153 (regex_compile, re_match_2_internal): Mark locals as initialized.
8154 (RETALLOC_IF): Define only if needed.
8155 (WORDCHAR_P): Likewise. This one is never needed, but is used
8156 only in a comment talking about a compiler bug, so put inside
8157 the #if 0 of that comment.
8158 (CHARSET_LOOKUP_BITMAP, FAIL_STACK_FULL, RESET_FAIL_STACK):
8159 (PUSH_FAILURE_ELT, BUF_PUSH_3, STOP_ADDR_VSTRING):
8160 Remove; unused.
8161
8162 * search.c (boyer_moore): Rename locals to avoid shadowing.
8163 * character.h (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE):
8164 (PREV_CHAR_BOUNDARY): Likewise.
8165
8166 * search.c (simple_search): Remove unused var.
8167
8168 * dired.c (compile_pattern): Move decl from here ...
8169 * lisp.h: ... to here, so that it can be checked.
8170 (struct re_registers): New forward decl.
8171
8172 * character.h (INC_POS, DEC_POS): Rename locals to avoid shadowing.
8173
8174 * indent.c (MULTIBYTE_BYTES_WIDTH): New args bytes, width.
8175 All uses changed.
8176 (MULTIBYTE_BYTES_WIDTH, scan_for_column, compute_motion):
8177 Rename locals to avoid shadowing.
8178 (Fvertical_motion): Mark locals as initialized.
8179
8180 * casefiddle.c (casify_object, casify_region): Now static.
8181 (casify_region): Mark local as initialized.
8182
8183 * cmds.c (internal_self_insert): Rename local to avoid shadowing.
8184
8185 * lisp.h (GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR, GCPRO5_VAR, GCPRO6_VAR):
8186 New macros, so that the caller can use some names other than
8187 gcpro1, gcpro2, etc.
8188 (GCPRO2, GCPRO3, GCPRO4, GCPRO5, GCPRO6): Reimplement in terms
8189 of the new macros.
8190 (GCPRO1_VAR, UNGCPRO_VAR): Change the meaning of the second
8191 argument, for consistency with GCPRO2_VAR, etc: it is now the
8192 prefix of the variable, not the variable itself. All uses
8193 changed.
8194 * dired.c (directory_files_internal, file_name_completion):
8195 Rename locals to avoid shadowing.
8196
8197 Fix a race condition diagnosed by gcc -Wsequence-point (Bug#8254).
8198 An expression of the form (DOWNCASE (x) == DOWNCASE (y)), found in
8199 dired.c's scmp function, had undefined behavior.
8200 * lisp.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
8201 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Move from here ...
8202 * buffer.h: ... to here, because these macros use current_buffer,
8203 and the new implementation with inline functions needs to have
8204 current_buffer in scope now, rather than later when the macros
8205 are used.
8206 (downcase, upcase1): New static inline functions.
8207 (DOWNCASE, UPCASE1): Reimplement using these functions.
8208 This avoids undefined behavior in expressions like
8209 DOWNCASE (x) == DOWNCASE (y), which previously suffered
8210 from race conditions in accessing the global variables
8211 case_temp1 and case_temp2.
8212 * casetab.c (case_temp1, case_temp2): Remove; no longer needed.
8213 * lisp.h (case_temp1, case_temp2): Remove their decls.
8214 * character.h (ASCII_CHAR_P): Move from here ...
8215 * lisp.h: ... to here, so that the inline functions mentioned
8216 above can use them.
8217
8218 * dired.c (directory_files_internal_unwind): Now static.
8219
8220 * fileio.c (file_name_as_directory, directory_file_name):
8221 (barf_or_query_if_file_exists, auto_save_error, auto_save_1):
8222 Now static.
8223 (file_name_as_directory): Use const pointers when appropriate.
8224 (Fexpand_file_name): Likewise. In particular, newdir might
8225 point at constant storage, so make it a const pointer.
8226 (Fmake_directory_internal, Fread_file_name): Remove unused vars.
8227 (Ffile_selinux_context, Fset_file_selinux_context): Fix pointer
8228 signedness issues.
8229 (Fset_file_times, Finsert_file_contents, auto_save_error):
8230 Rename locals to avoid shadowing.
8231
8232 * minibuf.c (choose_minibuf_frame_1): Now static.
8233 (Ftry_completion, Fall_completions): Rename or remove locals
8234 to avoid shadowing.
8235
8236 * marker.c (bytepos_to_charpos): Remove; unused.
8237
8238 * lisp.h (verify_bytepos, count_markers): New decls,
8239 so that gcc does not warn that these functions aren't declared.
8240
8241 * insdel.c (check_markers, make_gap_larger, make_gap_smaller):
8242 (reset_var_on_error, Fcombine_after_change_execute_1): Now static.
8243 (CHECK_MARKERS): Redo to avoid gcc -Wempty-body diagnostic.
8244 (copy_text): Remove unused local var.
8245
8246 * filelock.c (within_one_second): Now static.
8247 (lock_file_1): Rename local to avoid shadowing.
8248
8249 * buffer.c (fix_overlays_before): Mark locals as initialized.
8250 (fix_start_end_in_overlays): Likewise. This function should be
8251 simplified by using pointers-to-pointers, but that's a different
8252 matter.
8253 (switch_to_buffer_1): Now static.
8254 (Fkill_buffer, record_buffer, Fbury_buffer, Fset_buffer_multibyte):
8255 (report_overlay_modification): Rename locals to avoid shadowing.
8256
8257 * sysdep.c (system_process_attributes): Rename vars to avoid shadowing.
8258 Fix pointer signedness issue.
8259 (sys_subshell): Mark local as volatile if checking for lint,
8260 to suppress a gcc -Wclobbered warning that does not seem to be right.
8261 (MAXPATHLEN): Define only if needed.
8262
8263 * process.c (serial_open, serial_configure): Move decls from here ...
8264 * systty.h: ... to here, so that they can be checked.
8265
8266 * fns.c (get_random, seed_random): Move extern decls from here ...
8267 * lisp.h: ... to here, so that they can be checked.
8268
8269 * sysdep.c (reset_io): Now static.
8270 (wait_for_termination_signal): Remove; unused.
8271
8272 * keymap.c (keymap_parent, keymap_memberp, map_keymap_internal):
8273 (copy_keymap_item, append_key, push_text_char_description):
8274 Now static.
8275 (Fwhere_is_internal): Don't test CONSP (sequences) unnecessarily.
8276 (DENSE_TABLE_SIZE): Remove; unused.
8277 (get_keymap, access_keymap, Fdefine_key, Fwhere_is_internal):
8278 (describe_map_tree):
8279 Rename locals to avoid shadowing.
8280
8281 * keyboard.c: Declare functions static if they are not used elsewhere.
8282 (echo_char, echo_dash, cmd_error, top_level_2):
8283 (poll_for_input, handle_async_input): Now static.
8284 (read_char, kbd_buffer_get_event, make_lispy_position):
8285 (make_lispy_event, make_lispy_movement, apply_modifiers):
8286 (decode_keyboard_code, tty_read_avail_input, menu_bar_items):
8287 (parse_tool_bar_item, read_key_sequence, Fread_key_sequence):
8288 (Fread_key_sequence_vector): Rename locals to avoid shadowing.
8289 (read_key_sequence, read_char): Mark locals as initialized.
8290 (Fexit_recursive_edit, Fabort_recursive_edit): Mark with NO_RETURN.
8291
8292 * keyboard.h (make_ctrl_char): New decl.
8293 (mark_kboards): Move decl here ...
8294 * alloc.c (mark_kboards): ... from here.
8295
8296 * lisp.h (force_auto_save_soon): New decl.
8297
8298 * emacs.c (init_cmdargs): Rename local to avoid shadowing.
8299 (DEFINE_DUMMY_FUNCTION): New macro.
8300 (__do_global_ctors, __do_global_ctors_aux, __do_global_dtors, __main):
8301 Use it.
8302 (main): Add casts to avoid warnings
8303 if GCC considers string literals to be constants.
8304
8305 * lisp.h (fatal_error_signal): Add decl, since it's exported.
8306
8307 * dbusbind.c: Pointer signedness fixes.
8308 (xd_signature, xd_append_arg, xd_initialize):
8309 (Fdbus_call_method, Fdbus_call_method_asynchronously):
8310 (Fdbus_method_return_internal, Fdbus_method_error_internal):
8311 (Fdbus_send_signal, xd_read_message_1, Fdbus_register_service):
8312 (Fdbus_register_signal): Use SSDATA when the context wants char *.
8313
8314 * dbusbind.c (Fdbus_init_bus): Add cast to avoid warning
8315 if GCC considers string literals to be constants.
8316 (Fdbus_register_service, Fdbus_register_method): Remove unused vars.
8317
8318 2011-03-16 Stefan Monnier <monnier@iro.umontreal.ca>
8319
8320 * print.c (PRINT_CIRCLE_CANDIDATE_P): New macro.
8321 (print_preprocess, print_object): New macro to fix last change.
8322
8323 * print.c (print_preprocess): Don't forget font objects.
8324
8325 2011-03-16 Juanma Barranquero <lekktu@gmail.com>
8326
8327 * emacs.c (USAGE3): Doc fixes.
8328
8329 2011-03-15 Andreas Schwab <schwab@linux-m68k.org>
8330
8331 * coding.c (detect_coding_iso_2022): Reorganize code to clarify
8332 structure.
8333
8334 2011-03-14 Juanma Barranquero <lekktu@gmail.com>
8335
8336 * lisp.h (VWindow_system, Qfile_name_history):
8337 * keyboard.h (lispy_function_keys) [WINDOWSNT]:
8338 * w32term.h (w32_system_caret_hwnd, w32_system_caret_height)
8339 (w32_system_caret_x, w32_system_caret_y): Declare extern.
8340
8341 * w32select.c: Don't #include "keyboard.h".
8342 (run_protected): Add extern declaration for waiting_for_input.
8343
8344 * w32.c (Qlocal, noninteractive1, inhibit_window_system):
8345 * w32console.c (detect_input_pending, read_input_pending)
8346 (encode_terminal_code):
8347 * w32fns.c (quit_char, lispy_function_keys, Qtooltip)
8348 (w32_system_caret_hwnd, w32_system_caret_height, w32_system_caret_x)
8349 (w32_system_caret_y, Qfile_name_history):
8350 * w32font.c (w32font_driver, QCantialias, QCotf, QClang):
8351 * w32inevt.c (reinvoke_input_signal, lispy_function_keys):
8352 * w32menu.c (Qmenu_bar, QCtoggle, QCradio, Qoverriding_local_map)
8353 (Qoverriding_terminal_local_map, Qmenu_bar_update_hook):
8354 * w32proc.c (Qlocal, report_file_error):
8355 * w32term.c (Vwindow_system, updating_frame):
8356 * w32uniscribe.c (initialized, uniscribe_font_driver):
8357 Remove unneeded extern declarations.
8358
8359 2011-03-14 Chong Yidong <cyd@stupidchicken.com>
8360
8361 * buffer.c (Fmake_indirect_buffer): Fix incorrect assertions.
8362
8363 2011-03-13 Chong Yidong <cyd@stupidchicken.com>
8364
8365 * buffer.h (BUF_BEGV, BUF_BEGV_BYTE, BUF_ZV, BUF_ZV_BYTE, BUF_PT)
8366 (BUF_PT_BYTE): Rewrite to handle indirect buffers (Bug#8219).
8367 These macros can no longer be used for assignment.
8368
8369 * buffer.c (Fget_buffer_create, Fmake_indirect_buffer):
8370 Assign struct members directly, instead of using BUF_BEGV etc.
8371 (record_buffer_markers, fetch_buffer_markers): New functions for
8372 recording and fetching special buffer markers.
8373 (set_buffer_internal_1, set_buffer_temp): Use them.
8374
8375 * lread.c (unreadchar): Use SET_BUF_PT_BOTH.
8376
8377 * insdel.c (adjust_point): Use SET_BUF_PT_BOTH.
8378
8379 * intervals.c (temp_set_point_both): Use SET_BUF_PT_BOTH.
8380 (get_local_map): Use SET_BUF_BEGV_BOTH and SET_BUF_ZV_BOTH.
8381
8382 * xdisp.c (hscroll_window_tree):
8383 (reconsider_clip_changes): Use PT instead of BUF_PT.
8384
8385 2011-03-13 Eli Zaretskii <eliz@gnu.org>
8386
8387 * makefile.w32-in ($(BLD)/editfns.$(O)): Depend on
8388 $(EMACS_ROOT)/lib/intprops.h.
8389
8390 2011-03-13 Paul Eggert <eggert@cs.ucla.edu>
8391
8392 Fix more problems found by GCC 4.5.2's static checks.
8393
8394 * gtkutil.c (xg_get_pixbuf_from_pixmap): Add cast from char *
8395 to unsigned char * to avoid compiler diagnostic.
8396 (xg_free_frame_widgets): Make it clear that a local variable is
8397 needed only if USE_GTK_TOOLTIP.
8398 (gdk_window_get_screen): Make it clear that this macro is needed
8399 only if USE_GTK_TOOLTIP.
8400 (int_gtk_range_get_value): New function, which avoids a diagnostic
8401 from gcc -Wbad-function-cast.
8402 (xg_set_toolkit_scroll_bar_thumb): Use it.
8403 (xg_tool_bar_callback, xg_tool_item_stale_p): Rewrite to avoid
8404 diagnostic from gcc -Wbad-function-cast.
8405 (get_utf8_string, xg_get_file_with_chooser):
8406 Rename locals to avoid shadowing.
8407 (create_dialog): Move locals to avoid shadowing.
8408
8409 * xgselect.c (xg_select): Remove unused var.
8410
8411 * image.c (four_corners_best): Mark locals as initialized.
8412 (gif_load): Initialize transparent_p to zero (Bug#8238).
8413 Mark another local as initialized.
8414 (my_png_error, my_error_exit): Mark with NO_RETURN.
8415
8416 * image.c (clear_image_cache): Now static.
8417 (DIM, HAVE_STDLIB_H_1): Remove unused macros.
8418 (xpm_load): Redo to avoid "discards qualifiers" gcc warning.
8419 (x_edge_detection): Remove unnecessary cast that
8420 gcc -Wbad-function-cast diagnoses.
8421 (gif_load): Fix pointer signedness.
8422 (clear_image_cache, xbm_read_bitmap_data, x_detect_edges):
8423 (jpeg_load, gif_load): Rename locals to avoid shadowing.
8424
8425 2011-03-12 Paul Eggert <eggert@cs.ucla.edu>
8426
8427 Improve quality of tests for time stamp overflow.
8428 For example, without this patch (encode-time 0 0 0 1 1
8429 1152921504606846976) returns the obviously-bogus value (-948597
8430 62170) on my RHEL 5.5 x86-64 host. With the patch, it correctly
8431 reports time overflow. See
8432 <http://lists.gnu.org/archive/html/emacs-devel/2011-03/msg00470.html>.
8433 * deps.mk (editfns.o): Depend on ../lib/intprops.h.
8434 * editfns.c: Include limits.h and intprops.h.
8435 (TIME_T_MIN, TIME_T_MAX): New macros.
8436 (time_overflow): Move earlier, to before first use.
8437 (hi_time, lo_time): New functions, for an accurate test for
8438 out-of-range times.
8439 (Fcurrent_time, Fget_internal_run_time, make_time): Use them.
8440 (Fget_internal_run_time): Don't assume time_t fits in int.
8441 (make_time): Use list2 instead of Fcons twice.
8442 (Fdecode_time): More accurate test for out-of-range times.
8443 (check_tm_member): New function.
8444 (Fencode_time): Use it, to test for out-of-range times.
8445 (lisp_time_argument): Don't rely on undefined left-shift and
8446 right-shift behavior when checking for time stamp overflow.
8447
8448 * editfns.c (time_overflow): New function, refactoring common code.
8449 (Fformat_time_string, Fdecode_time, Fencode_time):
8450 (Fcurrent_time_string): Use it.
8451
8452 Move 'make_time' to be next to its inverse 'lisp_time_argument'.
8453 * dired.c (make_time): Move to ...
8454 * editfns.c (make_time): ... here.
8455 * systime.h: Note the move.
8456
8457 2011-03-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
8458
8459 * fringe.c (update_window_fringes): Remove unused variables.
8460
8461 * unexmacosx.c (copy_data_segment): Also copy __got section.
8462 (Bug#8223)
8463
8464 2011-03-12 Eli Zaretskii <eliz@gnu.org>
8465
8466 * termcap.c [MSDOS]: Include "msdos.h".
8467 (find_capability, tgetnum, tgetflag, tgetstr, tputs, tgetent):
8468 Constify `char *' arguments and their references according to
8469 prototypes in tparam.h.
8470
8471 * deps.mk (termcap.o): Depend on tparam.h and msdos.h.
8472
8473 * msdos.c (XMenuAddPane): 3rd argument is `const char *' now.
8474 Adapt all references accordingly.
8475
8476 * msdos.h (XMenuAddPane): 3rd argument is `const char *' now.
8477
8478 2011-03-11 Tom Tromey <tromey@redhat.com>
8479
8480 * buffer.c (syms_of_buffer): Remove obsolete comment.
8481
8482 2011-03-11 Eli Zaretskii <eliz@gnu.org>
8483
8484 * termhooks.h (encode_terminal_code): Declare prototype.
8485
8486 * msdos.c (encode_terminal_code): Don't declare prototype.
8487
8488 * term.c (encode_terminal_code): Now external again, used by
8489 w32console.c and msdos.c.
8490
8491 * makefile.w32-in ($(BLD)/term.$(O), ($(BLD)/tparam.$(O)):
8492 Depend on $(SRC)/tparam.h, see 2011-03-11T07:24:21Z!eggert@cs.ucla.edu.
8493
8494 2011-03-11 Paul Eggert <eggert@cs.ucla.edu>
8495
8496 Fix some minor problems found by GCC 4.5.2's static checks.
8497
8498 * fringe.c (update_window_fringes): Mark locals as initialized
8499 (Bug#8227).
8500 (destroy_fringe_bitmap, init_fringe_bitmap): Now static.
8501
8502 * alloc.c (mark_fringe_data): Move decl from here ...
8503 * lisp.h (mark_fringe_data) [HAVE_WINDOW_SYSTEM]: ... to here,
8504 to check its interface.
8505 (init_fringe_once): Do not declare unless HAVE_WINDOW_SYSTEM.
8506
8507 * fontset.c (free_realized_fontset): Now static.
8508 (Fset_fontset_font): Rename local to avoid shadowing.
8509 (fontset_font): Mark local as initialized.
8510 (FONTSET_SPEC, FONTSET_REPERTORY, RFONT_DEF_REPERTORY): Remove; unused.
8511
8512 * xrdb.c: Include "xterm.h", to check x_load_resources's interface.
8513
8514 * xselect.c (x_disown_buffer_selections): Remove; not used.
8515 (TRACE3) [!defined TRACE_SELECTION]: Remove; not used.
8516 (x_own_selection, Fx_disown_selection_internal): Rename locals
8517 to avoid shadowing.
8518 (x_handle_dnd_message): Remove local to avoid shadowing.
8519
8520 * lisp.h (GCPRO1_VAR, UNGCPRO_VAR): New macros,
8521 so that the caller can use some name other than gcpro1.
8522 (GCPRO1, UNGCPRO): Reimplement in terms of the new macros.
8523 * xfns.c (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
8524 (Fx_backspace_delete_keys_p):
8525 Use them to avoid shadowing, and rename vars to avoid shadowing.
8526 (x_decode_color, x_set_name, x_window): Now static.
8527 (Fx_create_frame): Add braces to silence GCC warning.
8528 (Fx_file_dialog, Fx_select_font): Fix pointer signedness.
8529 (x_real_positions, xg_set_icon_from_xpm_data, x_create_tip_frame):
8530 Remove unused locals.
8531 (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
8532 (Fx_backspace_delete_keys_p): Rename locals to avoid shadowing.
8533 Some of these renamings use the new GCPRO1_VAR and UNGCPRO_VAR
8534 macros.
8535
8536 * xterm.h (x_mouse_leave): New decl.
8537
8538 * xterm.c (x_copy_dpy_color, x_focus_on_frame, x_unfocus_frame):
8539 Remove unused functions.
8540 (x_shift_glyphs_for_insert, XTflash, XTring_bell):
8541 (x_calc_absolute_position): Now static.
8542 (XTread_socket): Don't define label "out" unless it's used.
8543 Don't declare local "event" unless it's used.
8544 (x_iconify_frame, x_free_frame_resources): Don't declare locals
8545 unless they are used.
8546 (XEMBED_VERSION, xembed_set_info): Don't define unless needed.
8547 (x_fatal_error_signal): Remove; not used.
8548 (x_draw_image_foreground, redo_mouse_highlight, XTmouse_position):
8549 (x_scroll_bar_report_motion, handle_one_xevent, x_draw_bar_cursor):
8550 (x_error_catcher, x_connection_closed, x_error_handler):
8551 (x_error_quitter, xembed_send_message, x_iconify_frame):
8552 (my_log_handler): Rename locals to avoid shadowing.
8553 (x_delete_glyphs, x_ins_del_lines): Mark with NO_RETURN.
8554 (x_connection_closed): Tell GCC not to suggest NO_RETURN.
8555
8556 * xfaces.c (clear_face_cache, Fx_list_fonts, Fface_font):
8557 Rename or move locals to avoid shadowing.
8558 (tty_defined_color, merge_face_heights): Now static.
8559 (free_realized_faces_for_fontset): Remove; not used.
8560 (Fx_list_fonts): Mark variable that gcc -Wuninitialized
8561 does not deduce is never used uninitialized.
8562 (STRDUPA, LSTRDUPA, FONT_POINT_SIZE_QUANTUM): Remove; not used.
8563 (LFACEP): Define only if XASSERTS, as it's not needed otherwise.
8564
8565 * terminal.c (store_terminal_param): Now static.
8566
8567 * xmenu.c (menu_highlight_callback): Now static.
8568 (set_frame_menubar): Remove unused local.
8569 (xmenu_show): Rename parameter to avoid shadowing.
8570 (xmenu_show, xdialog_show, xmenu_show): Make local pointers "const"
8571 since they might point to immutable storage.
8572 (next_menubar_widget_id): Declare only if USE_X_TOOLKIT,
8573 since it's unused otherwise.
8574
8575 * xdisp.c (produce_glyphless_glyph): Initialize lower_xoff.
8576 Add a FIXME, since the code still doesn't look right. (Bug#8215)
8577 (Fcurrent_bidi_paragraph_direction): Simplify slightly; this
8578 avoids a gcc -Wuninitialized diagnostic.
8579 (display_line, BUILD_COMPOSITE_GLYPH_STRING, draw_glyphs):
8580 (note_mouse_highlight): Mark variables that gcc -Wuninitialized
8581 does not deduce are never used uninitialized.
8582
8583 * lisp.h (IF_LINT): New macro, copied from ../lib-src/emacsclient.c.
8584
8585 * xdisp.c (redisplay_window): Rename local to avoid shadowing.
8586 * window.c (window_loop, size_window):
8587 (run_window_configuration_change_hook, enlarge_window): Likewise.
8588
8589 * window.c (display_buffer): Now static.
8590 (size_window): Mark variables that gcc -Wuninitialized
8591 does not deduce are never used uninitialized.
8592 * window.h (check_all_windows): New decl, to forestall
8593 gcc -Wmissing-prototypes diagnostic.
8594 * dispextern.h (bidi_dump_cached_states): Likewise.
8595
8596 * charset.h (CHECK_CHARSET_GET_CHARSET): Rename locals to avoid
8597 shadowing.
8598 * charset.c (map_charset_for_dump, Fchar_charset): Likewise.
8599 Include <limits.h>.
8600 (Fsort_charsets): Redo min/max calculation to shorten the code a bit
8601 and to avoid gcc -Wuninitialized warning.
8602 (load_charset_map): Mark variables that gcc -Wuninitialized
8603 does not deduce are never used uninitialized.
8604 (load_charset): Abort instead of using uninitialized var (Bug#8229).
8605
8606 * coding.c (coding_set_source, coding_set_destination):
8607 Use "else { /* comment */ }" rather than "else /* comment */;"
8608 for clarity, and to avoid gcc -Wempty-body warning.
8609 (Fdefine_coding_system_internal): Don't redeclare 'i' inside
8610 a block, when the outer 'i' will do.
8611 (decode_coding_utf_8, decode_coding_utf_16, detect_coding_emacs_mule):
8612 (emacs_mule_char, decode_coding_emacs_mule, detect_coding_iso_2022):
8613 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5):
8614 (decode_coding_raw_text, decode_coding_charset, get_translation_table):
8615 (Fdecode_sjis_char, Fdefine_coding_system_internal):
8616 Rename locals to avoid shadowing.
8617 * character.h (FETCH_STRING_CHAR_ADVANCE): Likewise.
8618 * coding.c (emacs_mule_char, encode_invocation_designation):
8619 Now static, since they're not used elsewhere.
8620 (decode_coding_iso_2022): Add "default: abort ();" as a safety check.
8621 (decode_coding_object, encode_coding_object, detect_coding_system):
8622 (decode_coding_emacs_mule): Mark variables that gcc
8623 -Wuninitialized does not deduce are never used uninitialized.
8624 (detect_coding_iso_2022): Initialize a local variable that might
8625 be used uninitialized. Leave a FIXME because it's not clear that
8626 this initialization is needed. (Bug#8211)
8627 (ISO_CODE_LF, ISO_CODE_CR, CODING_ISO_FLAG_EUC_TW_SHIFT):
8628 (ONE_MORE_BYTE_NO_CHECK, UTF_BOM, UTF_16_INVALID_P):
8629 (SHIFT_OUT_OK, ENCODE_CONTROL_SEQUENCE_INTRODUCER):
8630 (ENCODE_DIRECTION_R2L, ENCODE_DIRECTION_L2R):
8631 Remove unused macros.
8632
8633 * category.c (hash_get_category_set): Remove unused local var.
8634 (copy_category_table): Now static, since it's not used elsewhere.
8635 * character.c (string_count_byte8): Likewise.
8636
8637 * ccl.c (CCL_WRITE_STRING, CCL_ENCODE_CHAR, Fccl_execute_on_string):
8638 (Fregister_code_conversion_map): Rename locals to avoid shadowing.
8639
8640 * chartab.c (copy_sub_char_table): Now static, since it's not used
8641 elsewhere.
8642 (sub_char_table_ref_and_range, char_table_ref_and_range):
8643 Rename locals to avoid shadowing.
8644 (ASET_RANGE, GET_SUB_CHAR_TABLE): Remove unused macros.
8645
8646 * bidi.c (bidi_check_type): Now static, since it's not used elsewhere.
8647 (BIDI_BOB): Remove unused macro.
8648
8649 * cm.c (cmgoto): Mark variables that gcc -Wuninitialized does not
8650 deduce are never used uninitialized.
8651 * term.c (encode_terminal_code): Likewise.
8652
8653 * term.c (encode_terminal_code): Now static. Remove unused local.
8654
8655 * tparam.h: New file.
8656 * term.c, tparam.h: Include it.
8657 * deps.mk (term.o, tparam.o): Depend on tparam.h.
8658 * term.c (tputs, tgetent, tgetflag, tgetnum, tparam, tgetstr):
8659 Move these decls to tparam.h, and make them agree with what
8660 is actually in tparam.c. The previous trick of using incompatible
8661 decls in different modules does not conform to the C standard.
8662 All callers of tparam changed to use tparam's actual API.
8663 * tparam.c (tparam1, tparam, tgoto):
8664 Use const pointers where appropriate.
8665
8666 * cm.c (calccost, cmgoto): Use const pointers where appropriate.
8667 * cm.h (struct cm): Likewise.
8668 * dispextern.h (do_line_insertion_deletion_costs): Likewise.
8669 * scroll.c (ins_del_costs, do_line_insertion_deletion_costs): Likewise.
8670 * term.c (tty_ins_del_lines, calculate_costs, struct fkey_table):
8671 (term_get_fkeys_1, append_glyphless_glyph, produce_glyphless_glyph):
8672 (turn_on_face, init_tty): Likewise.
8673 * termchar.h (struct tty_display_info): Likewise.
8674
8675 * term.c (term_mouse_position): Rename local to avoid shadowing.
8676
8677 * alloc.c (mark_ttys): Move decl from here ...
8678 * lisp.h (mark_ttys): ... to here, so that it's checked against defn.
8679
8680 2011-03-11 Andreas Schwab <schwab@linux-m68k.org>
8681
8682 * .gdbinit (pwinx, xbuffer): Fix access to buffer name.
8683
8684 2011-03-09 Juanma Barranquero <lekktu@gmail.com>
8685
8686 * search.c (compile_pattern_1): Remove argument regp, unused since
8687 revid:rms@gnu.org-19941211082627-3x1g1wyqkjmwloig.
8688 (compile_pattern): Don't pass it.
8689
8690 2011-03-08 Jan Djärv <jan.h.d@swipnet.se>
8691
8692 * xterm.h (DEFAULT_GDK_DISPLAY): New define.
8693 (GDK_WINDOW_XID, gtk_widget_get_preferred_size): New defines
8694 for ! HAVE_GTK3.
8695 (GTK_WIDGET_TO_X_WIN): Use GDK_WINDOW_XID.
8696
8697 * xmenu.c (menu_position_func): Call gtk_widget_get_preferred_size.
8698
8699 * gtkutil.c: Include gtkx.h if HAVE_GTK3. If ! HAVE_GTK3, define
8700 gdk_window_get_screen, gdk_window_get_geometry,
8701 gdk_x11_window_lookup_for_display and GDK_KEY_g.
8702 (xg_set_screen): Use DEFAULT_GDK_DISPLAY.
8703 (xg_get_pixbuf_from_pixmap): New function.
8704 (xg_get_pixbuf_from_pix_and_mask): Change parameters from GdkPixmap
8705 to Pixmap, take frame as parameter, remove GdkColormap parameter.
8706 Call xg_get_pixbuf_from_pixmap instead of
8707 gdk_pixbuf_get_from_drawable.
8708 (xg_get_image_for_pixmap): Do not make GdkPixmaps, call
8709 xg_get_pixbuf_from_pix_and_mask with Pixmap parameters instead.
8710 (xg_check_special_colors): Use GtkStyleContext and its functions
8711 for HAVE_GTK3.
8712 (xg_prepare_tooltip, xg_hide_tooltip): Call gdk_window_get_screen.
8713 (xg_prepare_tooltip, create_dialog, menubar_map_cb)
8714 (xg_update_frame_menubar, xg_tool_bar_detach_callback)
8715 (xg_tool_bar_attach_callback, xg_update_tool_bar_sizes):
8716 Call gtk_widget_get_preferred_size.
8717 (xg_frame_resized): gdk_window_get_geometry only takes 5
8718 parameters.
8719 (xg_win_to_widget, xg_event_is_for_menubar):
8720 Call gdk_x11_window_lookup_for_display.
8721 (xg_set_widget_bg): New function.
8722 (delete_cb): New function.
8723 (xg_create_frame_widgets): Connect delete-event to delete_cb.
8724 Call xg_set_widget_bg. Only set background pixmap for ! HAVE_GTK3
8725 (xg_set_background_color): Call xg_set_widget_bg.
8726 (xg_set_frame_icon): Call xg_get_pixbuf_from_pix_and_mask.
8727 (xg_create_scroll_bar): vadj is a GtkAdjustment for HAVE_GTK3.
8728 Only call gtk_range_set_update_policy if ! HAVE_GTK3.
8729 (xg_make_tool_item): Only connect xg_tool_bar_item_expose_callback
8730 if ! HAVE_GTK3.
8731 (update_frame_tool_bar): Call gtk_widget_hide.
8732 (xg_initialize): Use GDK_KEY_g.
8733
8734 * xsmfns.c (gdk_set_sm_client_id): Define to gdk_set_sm_client_id
8735 if ! HAVE_GTK3
8736 (x_session_initialize): Call gdk_x11_set_sm_client_id.
8737
8738 * xterm.c (XFillRectangle): Use cairo routines for HAVE_GTK3.
8739 (x_term_init): Disable Xinput(2) with GDK_CORE_DEVICE_EVENTS.
8740 Load ~/emacs.d/gtkrc only for ! HAVE_GTK3.
8741
8742 2011-03-08 Juanma Barranquero <lekktu@gmail.com>
8743
8744 * w32xfns.c (select_palette): Check success of RealizePalette against
8745 GDI_ERROR, not zero.
8746
8747 See ChangeLog.11 for earlier changes.
8748
8749 ;; Local Variables:
8750 ;; coding: utf-8
8751 ;; End:
8752
8753 Copyright (C) 2011 Free Software Foundation, Inc.
8754
8755 This file is part of GNU Emacs.
8756
8757 GNU Emacs is free software: you can redistribute it and/or modify
8758 it under the terms of the GNU General Public License as published by
8759 the Free Software Foundation, either version 3 of the License, or
8760 (at your option) any later version.
8761
8762 GNU Emacs is distributed in the hope that it will be useful,
8763 but WITHOUT ANY WARRANTY; without even the implied warranty of
8764 MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
8765 GNU General Public License for more details.
8766
8767 You should have received a copy of the GNU General Public License
8768 along with GNU Emacs. If not, see <http://www.gnu.org/licenses/>.