1 2012-07-06 Dmitry Antipov <dmantipov@yandex.ru>
3 Fix marker debugging code.
4 * marker.c (byte_char_debug_check): Do not perform the check
5 if buffer is not multibyte.
6 (buf_charpos_to_bytepos, buf_bytepos_to_charpos): Call
7 byte_char_debug_check with correct arguments.
9 2012-07-06 Dmitry Antipov <dmantipov@yandex.ru>
11 Compile marker debugging code only if ENABLE_CHECKING is defined.
12 * marker.c (byte_char_debug_check, count_markers): Use
13 only if ENABLE_CHECKING is defined.
14 (byte_debug_flag): Remove.
15 (CONSIDER, buf_charpos_to_bytepos, buf_bytepos_to_charpos):
16 Always call byte_char_debug_check if ENABLE_CHECKING is defined.
18 2012-07-06 Dmitry Antipov <dmantipov@yandex.ru>
20 Avoid code repetition in marker-related functions.
21 * marker.c (attach_marker): New function.
22 (Fset_marker, set_marker_restricted, set_marker_both)
23 (set_marker_restricted_both): Use it.
24 (Fset_marker, set_marker_restricted, Fbuffer_has_markers_at):
25 Consistently rename charno to charpos.
26 (marker_position): Add eassert.
27 (marker_byte_position): Convert to eassert.
29 2012-07-06 Dmitry Antipov <dmantipov@yandex.ru>
31 Simplify list operations in unchain_overlay and unchain_marker.
32 * buffer.c (unchain_overlay): Simplify. Add comment.
33 * marker.c (unchain_marker): Simplify. Fix comments.
35 2012-07-06 Dmitry Antipov <dmantipov@yandex.ru>
37 Introduce fast path for the widely used marker operation.
38 * alloc.c (build_marker): New function.
39 * lisp.h (build_marker): New prototype.
40 * buffer.c (clone_per_buffer_values, Fmake_indirect_buffer): Use it.
41 * composite.c (autocmp_chars): Likewise.
42 * editfns.c (buildmark): Remove.
43 (Fpoint_marker, Fpoint_min_marker, Fpoint_max_marker)
44 (save_restriction_save): Use build_marker.
45 * marker.c (buf_charpos_to_bytepos, buf_bytepos_to_charpos): Likewise.
46 * window.c (save_window_save): Likewise.
48 2012-07-06 Dmitry Antipov <dmantipov@yandex.ru>
50 Do not use Fdelete_overlay in delete_all_overlays
51 to avoid redundant calls to unchain_overlay.
52 * buffer.c (drop_overlay): New function.
53 (delete_all_overlays, Fdelete_overlay): Use it.
54 * minibuf.c (get_minibuffer): Fix comment.
56 2012-07-06 Paul Eggert <eggert@cs.ucla.edu>
58 Port to OpenBSD 5.1 amd64.
59 * sysdep.c [BSD_SYSTEM]: Include <sys/param.h> before <sys/sysctl.h>.
60 This is needed for OpenBSD, and should be harmless on all BSD systems.
61 Also, include <sys/sysctl.h>, as it should be available on all
62 BSD_SYSTEM hosts given that we're already calling sysctl in that case.
63 (list_system_processes) [__OpenBSD__]: Use DARWIN_OS style mib, but
64 use p_pid member, not kp_proc.pid.
66 2012-07-06 Glenn Morris <rgm@gnu.org>
68 * Makefile.in (emacs$(EXEEXT)): Don't check for load-path shadows.
70 2012-07-05 Paul Eggert <eggert@cs.ucla.edu>
72 More xmalloc and related cleanup.
73 * alloc.c, bidi.c, buffer.c, buffer.h, bytecode.c, callint.c:
74 * callproc.c, charset.c, coding.c, composite.c, data.c, dispnew.c:
75 * doc.c, editfns.c, emacs.c, eval.c, fileio.c, filelock.c, fns.c:
76 * font.c, fontset.c, frame.c, fringe.c, ftfont.c, ftxfont.c, gmalloc.c:
77 * gtkutil.c, image.c, keyboard.c, keymap.c, lread.c, macros.c, menu.c:
78 * nsfns.m, nsfont.m, nsmenu.m, nsterm.m, print.c, process.c, ralloc.c:
79 * regex.c, region-cache.c, scroll.c, search.c, sound.c, syntax.c:
80 * sysdep.c, term.c, termcap.c, unexmacosx.c, window.c, xdisp.c:
81 * xfaces.c, xfns.c, xftfont.c, xgselect.c, xmenu.c, xrdb.c, xselect.c:
83 Omit needless casts involving void * pointers and allocation.
84 Prefer "P = xmalloc (sizeof *P)" to "P = xmalloc (sizeof (TYPE_OF_P))",
85 as the former is more robust if P's type is changed.
86 Prefer xzalloc to xmalloc + memset 0.
87 Simplify malloc-or-realloc to realloc.
88 Don't worry about xmalloc returning a null pointer.
89 Prefer xstrdup to xmalloc + strcpy.
90 * editfns.c (Fmessage_box): Grow message_text by at least 80 when
92 * keyboard.c (apply_modifiers_uncached): Prefer local array to
95 2012-07-05 Eli Zaretskii <eliz@gnu.org>
97 * xdisp.c (display_line): Fix horizontal pixel coordinates when
98 hscroll is larger than the line width. Fixes long and futile
99 looping inside extend_face_to_end_of_line (on a TTY) producing
100 glyphs that are not needed and thrown away.
102 2012-07-05 Dmitry Antipov <dmantipov@yandex.ru>
104 * marker.c (set_marker_restricted_both): Simplify by using
107 2012-07-05 Paul Eggert <eggert@cs.ucla.edu>
109 * editfns.c (region_limit): Simplify by using clip_to_bounds.
111 2012-07-05 Jan Djärv <jan.h.d@swipnet.se>
113 * gtkutil.c (gtk_scrollbar_new, gtk_box_new): Define when HAVE_GTK3 is
114 not defined (Bug#11768).
115 (xg_create_frame_widgets): Use gtk_plug_new_for_display (Bug#11768).
116 (xg_create_frame_widgets, create_dialog, xg_get_file_with_chooser)
117 (make_widget_for_menu_item, xg_make_tool_item): Use gtk_box_new
118 followed by gtk_box_set_homogeneous (Bug#11768).
119 (xg_update_menu_item): Use GTK_IS_BOX (Bug#11768).
120 (update_theme_scrollbar_width, xg_create_scroll_bar): Use
121 gtk_scrollbar_new (Bug#11768).
122 (xg_event_is_for_scrollbar): Use Gdk Device functions for HAVE_GTK3.
123 (is_box_type): New function (Bug#11768).
124 (xg_tool_item_stale_p): Call is_box_type.
125 (xg_initialize): Get settings by calling gtk_settings_get_for_screen
126 with default display (Bug#11768).
128 2012-07-05 Eli Zaretskii <eliz@gnu.org>
130 * xdisp.c (window_hscroll_limited): New function.
131 (pos_visible_p, init_iterator): Use it to avoid overflow of pixel
132 coordinates when window's hscroll is set to insanely large
135 2012-07-05 Juanma Barranquero <lekktu@gmail.com>
137 * makefile.w32-in ($(BLD)/dired.$(O), $(BLD)/fileio.$(O)): Fix typo.
138 ($(BLD)/terminal.$(O), $(BLD)/syntax.$(O)): Update dependencies.
140 2012-07-05 Dmitry Antipov <dmantipov@yandex.ru>
143 * lisp.h (xzalloc): New prototype. Omit needless casts.
144 * alloc.c (xzalloc): New function. Omit needless casts.
145 * charset.c: Omit needless casts. Convert all calls to
146 xmalloc with following memset to xzalloc.
147 * dispnew.c: Likewise.
148 * fringe.c: Likewise.
152 * w32fns.c: Likewise.
153 * w32font.c: Likewise.
154 * w32term.c: Likewise.
155 * xfaces.c: Likewise.
158 * atimer.c: Omit needless casts.
159 * buffer.c: Likewise.
160 * callproc.c: Likewise.
162 * coding.c: Likewise.
163 * composite.c: Likewise.
165 * doprnt.c: Likewise.
166 * editfns.c: Likewise.
169 * filelock.c: Likewise.
171 * gtkutil.c: Likewise.
172 * keyboard.c: Likewise.
175 * minibuf.c: Likewise.
178 * process.c: Likewise.
179 * region-cache.c: Likewise.
180 * search.c: Likewise.
181 * sysdep.c: Likewise.
182 * termcap.c: Likewise.
183 * terminal.c: Likewise.
184 * tparam.c: Likewise.
185 * w16select.c: Likewise.
187 * w32reg.c: Likewise.
188 * w32select.c: Likewise.
189 * w32uniscribe.c: Likewise.
190 * widget.c: Likewise.
194 * xselect.c: Likewise.
196 2012-07-05 Paul Eggert <eggert@cs.ucla.edu>
198 * fileio.c (time_error_value): Check the right error number.
199 Problem reported by Troels Nielsen in
200 <http://lists.gnu.org/archive/html/emacs-devel/2012-07/msg00095.html>.
202 2012-07-04 Paul Eggert <eggert@cs.ucla.edu>
204 * window.c (set_window_hscroll): Revert the 100000 hscroll limit.
205 This should be fixed in a better way; see Eli Zaretskii in
206 <http://lists.gnu.org/archive/html/emacs-devel/2012-07/msg00088.html>.
207 (HSCROLL_MAX): Remove; this is now internal to set_window_hscroll.
209 * fileio.c (time_error_value): Rename from special_mtime.
210 The old name's problems were noted by Eli Zaretskii in
211 <http://lists.gnu.org/archive/html/emacs-devel/2012-07/msg00087.html>.
213 * emacs.c (gdb_pvec_type): Change it back to enum pvec_type.
214 This variable's comment says Emacs needs at least one GDB-visible
215 symbol of type enum pvec_type, to work around GDB problems.
216 The symbol's value doesn't matter.
218 * alloc.c (PSEUDOVECTOR_NBYTES): Remove stray ';'
219 that causes compilation to fail on pre-C99 compilers.
221 2012-07-04 Juanma Barranquero <lekktu@gmail.com>
223 * s/ms-w32.h (LISP_FLOAT_TYPE, HAVE_MEMCMP, HAVE_MEMCPY)
224 (HAVE_MEMMOVE, HAVE_MEMSET): Don't set, obsolete.
226 2012-07-04 Dmitry Antipov <dmantipov@yandex.ru>
228 * buffer.c (init_buffer_once): Fix initialization of
229 headers for buffer_defaults and buffer_local_symbols.
230 Reported by Juanma Barranquero <lekktu@gmail.com>.
232 2012-07-04 Stefan Monnier <monnier@iro.umontreal.ca>
234 Turn VECTOR_FREE_LIST_FLAG into PVEC_FREE.
235 * lisp.h (enum pvec_type): Use fewer bits.
236 (PSEUDOVECTOR_SIZE_BITS): New constant.
237 (PSEUDOVECTOR_SIZE_MASK, PVEC_TYPE_MASK): Use it.
238 (XSETPVECTYPESIZE, XSETTYPED_PSEUDOVECTOR, DEFUN): Adapt code to
240 (PSEUDOVECTOR_TYPEP): New macro.
241 (TYPED_PSEUDOVECTORP): Use it.
242 * fns.c (internal_equal): Adapt code to extract pvectype.
243 * emacs.c (gdb_pvec_type): Update type.
244 * alloc.c (PSEUDOVECTOR_NBYTES): New macro.
245 (VECTOR_FREE_LIST_SIZE_MASK): Remove (=> PSEUDOVECTOR_SIZE_MASK).
246 (VECTOR_FREE_LIST_FLAG): Remove (=> PVEC_FREE).
247 (SETUP_ON_FREE_LIST): Use XSETPVECTYPESIZE.
248 (sweep_vectors): Use it. Use local var `total_bytes' instead of
249 abusing vector->header.next.nbytes.
250 (live_vector_p): Use PVEC_TYPE.
251 (mark_object): Adapt code to extract pvectype. Use switch.
253 2012-07-04 Paul Eggert <eggert@cs.ucla.edu>
255 * doprnt.c (doprnt): Don't assume string length fits in 'int'.
256 Tighten new eassert a bit.
258 2012-07-04 Dmitry Antipov <dmantipov@yandex.ru>
260 Fix compilation with --enable-gcc-warnings and -O1
262 * doprnt.c (doprnt): Change type of tem to int, initialize
263 to avoid compiler warning. Add eassert.
264 * search.c (simple_search): Initialize match_byte to avoid
265 compiler warning. Add eassert.
267 2012-07-04 Paul Eggert <eggert@cs.ucla.edu>
269 Avoid weird behavior with large horizontal scrolls.
270 Without this change, for example, large hscroll values would
271 mess up Emacs's display on Fedora 15 x86, presumably due to
272 overflows in int calculations in the display code.
273 Also, if buffers had long lines, Emacs would freeze.
274 * window.c (HSCROLL_MAX): Reduce to 100000, and make it visible to GDB.
275 (set_window_hscroll): New function, containing the old guts of
276 Fset_window_hscroll. Return the clipped value.
277 (Fset_window_hscroll, Fscroll_left, Fscroll_right): Use it.
278 This avoids the need to check against PTRDIFF_MAX.
280 * buffer.c (Fgenerate_new_buffer_name): Fix sprintf format mismatch.
282 2012-07-04 Dmitry Antipov <dmantipov@yandex.ru>
284 * buffer.c (Fgenerate_new_buffer_name): Fix type mismatch.
286 2012-07-04 Paul Eggert <eggert@cs.ucla.edu>
288 * regex.c: Suppress GCC warning on RHEL 6. (Bug#11207)
289 Conditionalize the pragmas on GCC 4.5 or later, not GCC 4.3 or later,
290 since GCC 4.4.6 issues a bogus warning for them.
292 Fix bugs in file timestamp newness comparisons.
293 * fileio.c (Ffile_newer_than_file_p):
294 * lread.c (Fload): Use full timestamp resolution of files,
295 not just the 1-second resolution, so that files that are only
296 slightly newer still count as newer.
297 * fileio.c (Ffile_newer_than_file_p): Don't assume file
298 timestamps fit in 'int'; this fixes a Y2038 bug on most hosts.
300 2012-07-03 Paul Eggert <eggert@cs.ucla.edu>
302 * fileio.c: Improve handling of file time marker. (Bug#11852)
303 (special_mtime): New function.
304 (Finsert_file_contents, Fverify_visited_file_modtime):
305 Use it to set special mtime values consistently.
307 2012-07-03 Andreas Schwab <schwab@linux-m68k.org>
309 * fileio.c (Finsert_file_contents): Properly handle st_mtime
310 marker for non-existing file. (Bug#11852)
312 2012-07-03 Glenn Morris <rgm@gnu.org>
314 * lisp.h (Fread_file_name): Restore EXFUN (it's not a normal DEFUN
315 and did not make it into globals.h).
317 2012-07-03 Tom Tromey <tromey@redhat.com>
319 * window.c (Fset_window_margins, Fset_window_fringes)
320 (Fset_window_scroll_bars, Fset_window_vscroll): No longer static.
321 * textprop.c (Fprevious_property_change): No longer static.
322 * syntax.c (Fsyntax_table_p): No longer static.
323 * process.c (Fget_process, Fprocess_datagram_address): No longer
325 * keymap.c (Flookup_key, Fcopy_keymap): No longer static.
326 * keyboard.c (Fcommand_execute): No longer static.
328 * insdel.c (Fcombine_after_change_execute): No longer static.
329 * image.c (Finit_image_library): No longer static.
330 * fileio.c (Fmake_symbolic_link): No longer static.
331 * eval.c (Ffetch_bytecode): No longer static.
332 * editfns.c (Fuser_full_name): No longer static.
333 * doc.c (Fdocumentation_property, Fsnarf_documentation):
335 * buffer.c (Fset_buffer_major_mode, Fdelete_overlay): No longer
337 * dired.c (Ffile_attributes): No longer static.
338 * composite.c (Fcomposition_get_gstring): No longer static.
339 * callproc.c (Fgetenv_internal): No longer static.
341 * ccl.h: Remove EXFUNs.
342 * buffer.h: Remove EXFUNs.
343 * dispextern.h: Remove EXFUNs.
344 * intervals.h: Remove EXFUNs.
345 * fontset.h: Remove EXFUN.
346 * font.h: Remove EXFUNs.
347 * dosfns.c (system_process_attributes): Remove EXFUN.
348 * keymap.h: Remove EXFUNs.
349 * lisp.h: Remove EXFUNs.
350 * w32term.h: Remove EXFUNs.
351 * window.h: Remove EXFUNs.
352 * xsettings.h: Remove EXFUN.
353 * xterm.h: Remove EXFUN.
355 2012-07-03 Glenn Morris <rgm@gnu.org>
357 * lisp.h (Frandom): Make it visible to C.
358 * buffer.c (Fgenerate_new_buffer_name): Speed up finding a new
359 buffer for invisible buffers. (Bug#1229)
361 2012-07-03 Dmitry Antipov <dmantipov@yandex.ru>
363 Fix block vector allocation code to allow VECTOR_BLOCK_SIZE
364 values which aren't power of 2.
365 * alloc.c (VECTOR_FREE_LIST_SIZE_MASK): New macro. Verify
366 it's value and the value of VECTOR_BLOCK_SIZE. Adjust users
369 2012-07-03 Stefan Monnier <monnier@iro.umontreal.ca>
371 * lisp.h (Lisp_Misc, Lisp_Fwd): Move around to group better.
373 * alloc.c (mark_object): Revert part of last patch to use `switch'.
375 2012-07-03 Dmitry Antipov <dmantipov@yandex.ru>
377 * alloc.c (allocate_vector_block): Remove redundant
378 calls to mallopt if DOUG_LEA_MALLOC is defined.
379 (allocate_vectorlike): If DOUG_LEA_MALLOC is defined,
380 avoid calls to mallopt if zero_vector is returned.
382 2012-07-03 Dmitry Antipov <dmantipov@yandex.ru>
384 * alloc.c (check_string_bytes): If GC_CHECK_STRING_BYTES
385 is enabled, avoid dereferencing NULL current_sblock if
388 2012-07-03 Dmitry Antipov <dmantipov@yandex.ru>
390 Cleanup basic buffer management.
391 * buffer.h (struct buffer): Change layout to use generic vector
392 marking code. Fix some comments. Change type of 'clip_changed'
393 to bitfield. Remove unused #ifndef old.
394 (FIRST_FIELD_PER_BUFFER, LAST_FIELD_PER_BUFFER): Remove.
395 (GET_OVERLAYS_AT): Fix indentation.
396 (for_each_per_buffer_object_at): New macro.
397 * buffer.c (clone_per_buffer_values, reset_buffer_local_variables)
398 (Fbuffer_local_variables): Use it.
399 (init_buffer_once, syms_of_buffer): Remove unused #ifndef old.
400 * alloc.c (allocate_buffer): Adjust to match new layout of
401 struct buffer. Fix comment.
402 (mark_overlay): New function.
403 (mark_buffer): Use it. Use mark_vectorlike to mark normal
404 Lisp area of struct buffer.
405 (mark_object): Use it. Adjust marking of misc objects
406 and related comments.
408 2012-07-02 Paul Eggert <eggert@cs.ucla.edu>
410 * alloc.c (mark_object): Remove "#ifdef GC_CHECK_MARKED_OBJECTS"
411 wrapper that is not needed because the wrapped code is a no-op (zero
412 machine instructions) when GC_CHECK_MARKED_OBJECTS is not defined.
413 This avoids a -Wunused-macros diagnostic with GCC 4.7.1 x86-64.
415 2012-07-02 Dmitry Antipov <dmantipov@yandex.ru>
417 * alloc.c (mark_buffer): Simplify. Remove prototype.
418 (mark_object): Add comment. Reorganize marking of vector-like
419 objects. Use CHECK_LIVE for all vector-like objects except buffers
420 and subroutines when GC_CHECK_MARKED_OBJECTS is defined. Avoid
421 redundant calls to mark_vectorlike for bool vectors.
423 2012-06-30 Glenn Morris <rgm@gnu.org>
425 * nsterm.m (ns_init_paths): Ignore site-lisp if --no-site-lisp.
427 * epaths.in (PATH_SITELOADSEARCH): New.
428 * lread.c (init_lread): Use PATH_SITELOADSEARCH.
429 This is rather than relying on --enable-locallisppath elements
430 having "site-lisp" in their names. (Bug#10208#25, 11658)
432 2012-06-30 Eli Zaretskii <eliz@gnu.org>
434 * w32proc.c (sys_select): Accept and ignore one more argument.
436 * w32.c (emacs_gnutls_pull): Call select with one more argument.
438 * sysselect.h [DOS_NT]: Don't include sys/select.h.
439 (pselect) [!MS_DOS]: Redirect to sys_select.
441 * sysdep.c: Don't include dos.h and dosfns.h.
443 * process.c (sys_select):
444 * msdos.c (sys_select): Accept one more argument and ignore it.
446 * msdos.c (event_timestamp, sys_select): Use gnulib's gettime;
447 adapt data types and code to that.
450 * msdos.c (gettime, settime): Define away the prototypes in dos.h,
451 which clashes with the gnulib function of the same name.
453 2012-06-30 Andreas Schwab <schwab@linux-m68k.org>
455 * font.c (font_style_to_value, font_style_symbolic)
456 (font_prop_validate_style): Add type checks for values in
459 * lisp.h (CHECK_RANGED_INTEGER): Make value to check the first
461 * character.c, charset.c, menu.c, process.c, window.c: Adjust all
464 2012-06-29 Eli Zaretskii <eliz@gnu.org>
466 * xdisp.c (try_window_id): Undo last change.
468 * w32.c (getwd): Adjust commentary about startup_dir.
469 (init_environment): Always call sys_access, even in non-MSVC
470 builds. Don't chdir to the directory of the Emacs executable.
471 This undoes code from 1997 which was justified by the need to
472 "avoid conflicts when removing and renaming directories". But its
473 downside was that every relative file name was being interpreted
474 relative to the directory of the Emacs executable, which can never
475 be TRT. In particular, it broke sys_access when called with
477 (sys_access): Map GetLastError to errno.
479 2012-06-29 Dmitry Antipov <dmantipov@yandex.ru>
481 * window.h (struct window): Change type of 'fringes_outside_margins'
482 to bitfield. Fix comment. Adjust users accordingly.
483 (struct window): Change type of 'window_end_bytepos' to ptrdiff_t.
485 * xdisp.c (try_window_id): Change type of 'first_vpos' and 'vpos'
488 2012-06-29 Andreas Schwab <schwab@linux-m68k.org>
490 * gnutls.c (emacs_gnutls_handshake):
491 Add QUIT to make the loop interruptible.
493 2012-06-29 Glenn Morris <rgm@gnu.org>
495 * charset.c (init_charset): Make lack of etc/charsets fatal.
497 2012-06-29 Dmitry Antipov <dmantipov@yandex.ru>
499 * editfns.c (region_limit): Fix type mismatch.
501 2012-06-29 Dmitry Antipov <dmantipov@yandex.ru>
503 * nsfns.m: Fix GLYPH_DEBUG usage assuming that it may be
504 undefined. Convert from xassert to eassert.
505 * nsmenu.m: Convert from xassert to eassert.
506 * nsterm.m: Likewise.
508 2012-06-28 Stefan Monnier <monnier@iro.umontreal.ca>
510 * editfns.c (region_limit): Clip to narrowing (bug#11770).
512 2012-06-28 Paul Eggert <eggert@cs.ucla.edu>
514 Avoid integer overflow on scroll-left and scroll-right.
515 * window.c (HSCROLL_MAX): New macro.
516 (Fscroll_left, Fscroll_right): Avoid undefined behavior on integer
517 overflow when requested scroll falls outside ptrdiff_t range.
519 2012-06-28 Dmitry Antipov <dmantipov@yandex.ru>
521 * window.h (struct window): Change type of 'hscroll',
522 'min_hscroll' and 'last_point' from Lisp_Object to ptrdiff_t,
523 'last_modified' and 'last_overlay_modified' to EMACS_INT.
524 Adjust users accordingly.
525 * xdisp.c (try_cursor_movement): Replace type check with eassert.
526 * window.c (Fscroll_left, Fscroll_right): Change type of 'hscroll'
527 from EMACS_INT to ptrdiff_t.
528 (make_window): Omit redundant initialization.
530 2012-06-28 Juanma Barranquero <lekktu@gmail.com>
532 * makefile.w32-in ($(BLD)/regex.$(O)): Update dependencies.
534 2012-06-28 Dmitry Antipov <dmantipov@yandex.ru>
536 * window.h (struct window): Change type of 'use_time' and
537 'sequence_number' from Lisp_Object to int.
538 * frame.c (make_frame): Adjust users accordingly.
539 * print.c (print_object): Likewise.
540 * window.c (select_window, Fwindow_use_time, make_parent_window)
541 (make_window): Likewise.
543 2012-06-28 Dmitry Antipov <dmantipov@yandex.ru>
545 * dispextern.h (GLYPH_DEBUG): Now defined in config.h if
546 enabled with --enable-checking=[all,glyphs] configure option.
547 Fix GLYPH_DEBUG usage assuming that it may be undefined,
548 adjust comments accordingly.
549 * dispnew.c: Fix GLYPH_DEBUG usage assuming that it may be
550 undefined, adjust comments accordingly.
552 * scroll.c: Likewise.
553 * w32fns.c: Likewise.
554 * w32term.c: Likewise.
556 * xfaces.c: Likewise.
560 2012-06-28 Dmitry Antipov <dmantipov@yandex.ru>
562 Generalize run-time debugging checks.
563 * dispextern.h (XASSERTS): Remove.
564 * fontset.c (xassert): Remove.
565 Convert from xassert to eassert.
566 * alloc.c: Convert from xassert to eassert.
568 * dispnew.c: Likewise.
570 * fringe.c: Likewise.
571 * ftfont.c: Likewise.
572 * gtkutil.c: Likewise.
574 * keyboard.c: Likewise.
576 * process.c: Likewise.
577 * scroll.c: Likewise.
580 * w32console.c: Likewise.
581 * w32fns.c: Likewise.
582 * w32term.c: Likewise.
583 * window.c: Likewise.
585 * xfaces.c: Likewise.
587 * xselect.c: Likewise.
590 2012-06-27 Stefan Monnier <monnier@iro.umontreal.ca>
592 * fns.c (maybe_resize_hash_table): Output message when growing the
595 2012-06-27 Dmitry Antipov <dmantipov@yandex.ru>
597 * alloc.c (allocate_string_data): Remove dead code.
598 * xsettings.c (XSETTINGS_FONT_NAME): Move under HAVE_XFT to
599 avoid GCC warning about unused macro.
601 2012-06-27 Dmitry Antipov <dmantipov@yandex.ru>
603 * alloc.c (allocate_string): Omit intervals initialization.
604 * alloc.c (make_uninit_multibyte_string): Initialize intervals
605 as in make_pure_string and make_pure_c_string.
607 2012-06-27 Dmitry Antipov <dmantipov@yandex.ru>
609 * alloc.c (allocate_string): Fix last change.
611 2012-06-27 Dmitry Antipov <dmantipov@yandex.ru>
613 * alloc.c (allocate_string): Remove two redundant calls
614 to memset, add explicit initialization where appropriate.
616 2012-06-27 Glenn Morris <rgm@gnu.org>
618 * lisp.mk (lisp): Remove paths.elc.
620 2012-06-27 Chong Yidong <cyd@gnu.org>
622 * doc.c (Fsubstitute_command_keys): Fix punctuation.
624 2012-06-26 John Wiegley <johnw@newartisans.com>
626 * unexmacosx.c (copy_data_segment): Add two section names used
627 on Mac OS X Lion: __mod_init_func and __mod_term_func.
629 * alloc.c (mark_memory): Do not check with -faddress-sanitizer
630 when building with Clang.
632 2012-06-26 Stefan Monnier <monnier@iro.umontreal.ca>
634 * eval.c (Fapply): Allow calling it with a single argument.
636 2012-06-26 Eli Zaretskii <eliz@gnu.org>
638 * s/ms-w32.h (strcasecmp, strncasecmp) [_MSC_VER]: Redirect to
639 _stricmp and _strnicmp.
640 (HAVE_STRCASECMP, HAVE_STRNCASECMP): Define to 1.
642 2012-06-26 Dmitry Antipov <dmantipov@yandex.ru>
644 * alloc.c (allocate_window): Zero out non-Lisp part of newly
646 (allocate_process): Likewise for new process.
647 (allocate_terminal): Change to use offsetof.
648 (allocate_frame): Likewise.
649 * frame.c (make_frame): Omit redundant initialization.
650 * window.c (make_parent_window): Use memset.
651 (make_window): Omit redundant initialization.
652 * process.c (make_process): Omit redundant initialization.
653 * terminal.c (create_terminal): Likewise.
655 2012-06-26 Dmitry Antipov <dmantipov@yandex.ru>
657 * term.c (delete_tty): Remove redundant call to memset.
659 2012-06-26 Dmitry Antipov <dmantipov@yandex.ru>
661 * alloc.c: Remove build_string.
662 * lisp.h: Define build_string as static inline. This provides
663 a better opportunity to optimize away calls to strlen when the
664 function is called with compile-time constant argument.
665 * image.c (imagemagick_error): Convert to build_string.
666 * w32proc.c (sys_spawnve): Likewise.
667 * xterm.c (x_term_init): Likewise.
669 2012-06-26 Paul Eggert <eggert@cs.ucla.edu>
671 Use sprintf return value instead of invoking strlen on result.
672 In the old days this wasn't portable, since some sprintf
673 implementations returned char *. But they died out years ago and
674 Emacs already assumes sprintf returns int.
675 Similarly for float_to_string.
676 This patch speeds up (number-to-string 1000) by 3% on Fedora 15 x86-64.
677 * ccl.c (ccl_driver):
678 * character.c (string_escape_byte8):
679 * data.c (Fnumber_to_string):
681 * print.c (print_object):
682 * xdisp.c (message_dolog):
683 * xfns.c (syms_of_xfns):
684 Use sprintf or float_to_string result to avoid need to call strlen.
685 * data.c (Fnumber_to_string):
686 Use make_unibyte_string, since the string must be ASCII.
687 * lisp.h, print.c (float_to_string): Now returns int length.
688 * term.c (produce_glyphless_glyph):
689 Use sprintf result rather than recomputing it.
691 Clean out last vestiges of the old HAVE_CONFIG_H stuff.
692 * Makefile.in (ALL_CFLAGS):
693 * makefile.w32-in (LOCAL_FLAGS): Remove -DHAVE_CONFIG_H.
694 * gmalloc.c, regex.c: Include <config.h> unconditionally.
696 2012-06-25 Dmitry Antipov <dmantipov@yandex.ru>
698 * dispextern.h (xstrcasecmp): Define to library function
699 strcasecmp if available.
700 * xfaces.c: Do not use xstrcasecmp if strcasecmp is available.
702 2012-06-25 Andreas Schwab <schwab@linux-m68k.org>
704 * keyboard.c (menu_bar_items, menu_bar_item, read_key_sequence):
705 Avoid comma operator.
706 * menu.c (push_submenu_start, push_submenu_end)
707 (push_left_right_boundary, push_menu_pane): Likewise.
708 * msdos.c (dos_rawgetc): Likewise.
710 2012-06-25 Dmitry Antipov <dmantipov@yandex.ru>
712 * xfns.c (xic_create_fontsetname): Remove redundant calls
715 2012-06-25 Paul Eggert <eggert@cs.ucla.edu>
717 * gtkutil.c (get_utf8_string): Remove redundant assignment.
718 sprintf already null-terminates its output.
720 * xfns.c (x_window): Remove redundant cast.
722 2012-06-25 Dmitry Antipov <dmantipov@yandex.ru>
724 * xmenu.c (xmenu_show, xdialog_show): Explicit cast from
725 `const char *' to `char *' to avoid compiler warning.
727 2012-06-24 Paul Eggert <eggert@cs.ucla.edu>
729 * xterm.c (x_term_init): Build proper-sized _XSETTINGS_Snnn string
730 instead of truncating it to 63 (admittedly a generous limit).
732 * process.c: Fix spelling and caps in comments.
734 2012-06-24 Dan Nicolaescu <dann@ics.uci.edu>
736 * emacs.c (setpgrp): Remove definition, unused.
737 * sysdep.c (setpgrp): Remove definition, not used in this file.
739 2012-06-24 Juanma Barranquero <lekktu@gmail.com>
741 * makefile.w32-in: Update dependencies.
743 2012-06-24 Eli Zaretskii <eliz@gnu.org>
745 * makefile.w32-in (TIMESPEC_H): Remove nt/inc/sys/time.h.
746 (SYSTIME_H): Add nt/inc/sys/time.h.
748 * systime.h [WINDOWSNT]: Include sys/time.h.
750 * s/ms-w32.h (struct timespec): Definition moved from
751 nt/inc/sys/time.h. Suggested by Paul Eggert <eggert@cs.ucla.edu>.
753 2012-06-24 Paul Eggert <eggert@cs.ucla.edu>
755 Switch from NO_RETURN to C11's _Noreturn (Bug#11750).
756 * buffer.h (buffer_slot_type_mismatch):
757 * data.c (arith_error) [!FORWARD_SIGNAL_TO_MAIN_THREAD]:
758 * eval.c (unwind_to_catch):
759 * image.c (my_png_error, my_error_exit):
760 * keyboard.c (quit_throw_to_read_char, user_error)
761 (Fexit_recursive_edit, Fabort_recursive_edit):
762 * lisp.h (die, args_out_of_range, args_out_of_range_3)
763 (wrong_type_argument, buffer_overflow, __executable_start)
764 (memory_full, buffer_memory_full, string_overflow, Fthrow)
765 (xsignal, xsignal0, xsignal1, xsignal2, xsignal3, signal_error)
766 (error, verror, nsberror, report_file_error, Ftop_level, Fkill_emacs)
768 (child_setup) [!DOS_NT]:
769 * lread.c (end_of_file_error, invalid_syntax):
770 * process.c (send_process_trap) [!FORWARD_SIGNAL_TO_MAIN_THREAD]:
771 * puresize.h (pure_write_error):
772 * search.c (matcher_overflow):
773 * sound.c (sound_perror, alsa_sound_perror):
774 * sysdep.c, syssignal.h (croak):
775 * term.c (maybe_fatal, vfatal):
776 * textprop.c (text_read_only):
777 * undo.c (user_error):
778 * unexmacosx.c (unexec_error):
779 * xterm.c (x_ins_del_lines, x_delete_glyphs):
780 Use _Noreturn rather than NO_RETURN.
781 No need for separate decl merely because of _Noreturn.
782 * sound.c (sound_warning, parse_sound):
783 Remove unnecessary forward decls.
785 2012-06-24 Paul Eggert <eggert@cs.ucla.edu>
787 Fix bug when time_t is unsigned and as wide as intmax_t (Bug#9000).
788 * lisp.h (WAIT_READING_MAX): New macro.
789 * dispnew.c (Fsleep_for, sit_for):
790 * keyboard.c (kbd_buffer_get_event):
791 * process.c (Faccept_process_output):
792 Use it to avoid bogus compiler warnings with obsolescent GCC versions.
793 This improves on the previous patch, which introduced a bug
794 when time_t is unsigned and as wide as intmax_t.
795 See <http://bugs.gnu.org/9000#51>.
797 2012-06-23 Eli Zaretskii <eliz@gnu.org>
799 * dispnew.c (sit_for, Fsleep_for):
800 * keyboard.c (kbd_buffer_get_event):
801 * process.c (Faccept_process_output): Avoid compiler warnings when
802 comparing a 32-bit time_t with a 64-bit INTMAX_MAX.
804 2012-06-23 Juanma Barranquero <lekktu@gmail.com>
806 * makefile.w32-in: Update dependencies.
808 * w32.c (ltime): Add return type and declare static.
809 (w32_get_internal_run_time): Remove usused variable `time_100ns'.
811 2012-06-23 Paul Eggert <eggert@cs.ucla.edu>
813 * sysdep.c [__FreeBSD__]: Fix more recently-introduced typos.
814 Privately reported by Herbert J. Skuhra.
815 (make_lisp_timeval) [__FreeBSD__]: Rename from TIMELIST.
817 (system_process_attributes) [__FreeBSD__]: Invoke make_lisp_time,
818 not make_lisp_timeval, when the argument is of type EMACS_TIME.
820 2012-06-23 Eli Zaretskii <eliz@gnu.org>
822 * w32proc.c (Fw32_get_locale_info): Fix an off-by-one error in
823 last argument of make_unibyte_string.
825 * keyboard.c (kbd_buffer_get_event): Include the codepage and the
826 language ID in the event parameters.
828 * w32term.c (w32_read_socket): Put the new keyboard codepage into
829 event.code, not the obscure "character set ID".
831 2012-06-23 Chong Yidong <cyd@gnu.org>
833 * xmenu.c (x_menu_wait_for_event): Adapt GTK3 to new xg_select.
835 2012-06-23 Eli Zaretskii <eliz@gnu.org>
837 Fix the MS-Windows build broken by 2012-06-22T21:17:42Z!eggert@cs.ucla.edu.
838 * w32.c (fdutimens): New function.
840 * w32proc.c (sys_select): Adapt to change in the EMACS_TIME type.
842 * s/ms-w32.h (pselect): Redirect to sys_select.
844 * sysselect.h [WINDOWSNT]: Don't include sys/select.h.
846 * ralloc.c (r_alloc_inhibit_buffer_relocation): Fix stupid thinko
847 in the logic of incrementing and decrementing the value of
848 use_relocatable_buffers.
850 2012-06-23 Paul Eggert <eggert@cs.ucla.edu>
852 * sysdep.c [__FreeBSD__]: Fix recently-introduced typos.
853 Privately reported by Herbert J. Skuhra.
854 [__FreeBSD__]: Remove "*/" typo after "#include".
855 (timeval_to_EMACS_TIME) [__FreeBSD__]: New static function.
856 (TIMEVAL) [__FreeBSD__]: Now a static function rather than a macro.
857 (TIMEVAL, system_process_attributes) [__FreeBSD__]:
858 Don't assume EMACS_TIME and struct timeval are the same type.
860 2012-06-22 Paul Eggert <eggert@cs.ucla.edu>
862 Support higher-resolution time stamps (Bug#9000).
863 The time stamps are only nanosecond-resolution at the C level,
864 since that's the best that any real-world system supports now.
865 But they are picosecond-resolution at the Lisp level, as that's
866 easy, and leaves room for future OS improvements.
868 * Makefile.in (LIB_CLOCK_GETTIME): New macro.
871 * alloc.c (Fgarbage_collect): Port to higher-res time stamps.
872 Don't get current time unless it's needed.
874 * atimer.c: Include <sys/time.h> unconditionally, since gnulib
875 now provides it if it's absent.
876 (start_atimer): Port to higher-res time stamps.
877 Check for time stamp overflow. Don't get current time more
878 often than is needed.
880 * buffer.h (struct buffer): Buffer modtime now has high resolution.
881 Include systime.h, not time.h.
882 (NONEXISTENT_MODTIME_NSECS, UNKNOWN_MODTIME_NSECS): New macros.
884 * dired.c: Include stat-time.h.
885 (Ffile-attributes): File times now have higher resolution.
887 * dispextern.h [HAVE_WINDOW_SYSTEM]: Include systime.h.
888 (struct image): Timestamp now has higher resolution.
890 * dispnew.c (PERIODIC_PREEMPTION_CHECKING): Remove, as Emacs always
891 has at least microseconds now. All uses removed.
892 (update_frame, update_single_window, update_window, update_frame_1)
893 (Fsleep_for, sit_for): Port to higher-resolution time stamps.
895 * editfns.c (time_overflow): Now extern.
896 (Fcurrent_time, Fget_internal_run_time, make_time, lisp_time_argument)
897 (float-time, Fformat_time_string, Fcurrent_time_string)
898 (Fcurrent_time_zone): Accept and generate higher-resolution
900 (make_time_tail, make_lisp_time, dissassemble_lisp_time)
901 (decode_time_components, lisp_seconds_argument): New functions.
902 (make_time): Now static.
903 (lisp_time_argument): Now returns EMACS_TIME. New arg ppsec.
904 Report an error if the time is invalid, rather than having the caller
907 * fileio.c: Include <stat-time.h>
908 (Fcopy_file): Copy higher-resolution time stamps.
909 Prefer to set the time stamp via a file descriptor if that works.
910 (Fset_file_times, Finsert_file_contents, Fwrite_region)
911 (Fverify_visited_file_modtime, Fclear_visited_file_modtime)
912 (Fvisited_file_modtime, Fset_visited_file_modtime):
913 Support higher-resolution time stamps.
915 * fns.c (Frandom): Use nanoseconds, not microseconds, for seed.
917 * gtkutil.c (xg_maybe_add_timer): Port to higher-res time stamps.
919 * image.c (prepare_image_for_display, clear_image_cache)
920 (lookup_image): Port to higer-resolution time stamps.
922 * keyboard.c (start_polling, bind_polling_period):
923 Check for time stamp overflow.
924 (read_char, kbd_buffer_get_event, timer_start_idle)
925 (timer_stop_idle, timer_resume_idle, timer_check_2, timer_check)
926 (Fcurrent_idle_time, init_keyboard, set_waiting_for_input):
927 Port to higher-resolution time stamps. Do not assume time_t is signed.
928 (decode_timer): New function. Timers are now vectors of length 9,
929 not 8, to accommodate the picosecond component.
930 (timer_check_2): Use it.
932 * nsterm.m (select_timeout, timeval_subtract): Remove.
933 (ns_timeout): Use Emacs's facilities for time stamp arithmetic,
934 as they're a bit more accurate and handle overflow better.
935 (ns_select): Change prototype to be compatible with pselect.
936 (ns_select, ns_term_shutdown): Port to ns-resolution time stamps.
937 * nsterm.h (ns_select): Adjust prototype.
939 * msdos.c (EMACS_TIME_ZERO_OR_NEG_P): Remove, as it assumes
940 us-resolution time stamps.
941 (sys_select): Use the new EMACS_TIME_SIGN macro instead.
943 * lread.c (read_filtered_event): Port to ns-resolution time stamps.
945 * lisp.h (time_overflow): New decl.
946 (wait_reading_process_output): First arg is now intmax_t, not int,
947 to accommodate larger waits.
949 * process.h (struct Lisp_Process.read_output_delay):
950 Now counts nanoseconds, not microseconds.
951 * process.c (ADAPTIVE_READ_BUFFERING): Don't worry about
953 (READ_OUTPUT_DELAY_INCREMENT, Faccept_process_output)
954 (wait_reading_process_output):
955 Port to ns-resolution time stamps.
956 (Faccept_process_output, wait_reading_process_output):
957 Check for time stamp overflow. Do not assume time_t is signed.
958 (select_wrapper): Remove; we now use pselect.
959 (Fprocess_attributes): Now generates ns-resolution time stamps.
961 * sysdep.c: Include utimens.h. Don't include utime.h
962 or worry about struct utimbuf; gnulib does that for us now.
963 (gettimeofday): Remove; gnulib provides a substitute.
964 (make_timeval): New function.
965 (set_file_times): Now sets ns-resolution time stamps.
966 New arg FD; all uses changed.
967 (time_from_jiffies, ltime_from_jiffies, get_up_time)
968 (system_process_attributes):
969 Now returns ns-resolution time stamp. All uses changed.
970 Check for time stamp overflow.
972 * sysselect.h: Don't depend on HAVE_SYS_SELECT_H; gnulib
973 provides a substitute now.
975 * systime.h: Include timespec.h rather than sys/time.h and time.h,
976 since it guarantees struct timespec.
977 (EMACS_TIME): Now struct timespec, so that we can support
978 ns-resolution time stamps.
979 (EMACS_TIME_RESOLUTION, LOG10_EMACS_TIME_RESOLUTION): New macros.
980 (EMACS_HAS_USECS): Remove; Emacs always has sub-second time stamps now.
981 (EMACS_USECS): Remove.
982 (EMACS_SET_USECS): The underlying time stamp now has ns resolution,
983 so multiply the arg by 1000 before storing it.
984 (EMACS_NSECS, EMACS_SECS_ADDR, EMACS_SET_NSECS, EMACS_SET_SECS_NSECS):
986 (EMACS_GET_TIME, EMACS_ADD_TIME, EMACS_SUB_TIME):
987 Port to ns-resolution time stamps.
988 (EMACS_TIME_NEG_P): Remove; replaced by....
989 (EMACS_TIME_SIGN): New macro.
990 (EMACS_SET_INVALID_TIME, EMACS_TIME_VALID_P)
991 (EMACS_TIME_FROM_DOUBLE, EMACS_TIME_TO_DOUBLE): New macros.
992 (set_file_times, make_time, lisp_time_argument): Adjust signature.
993 (make_timeval, make_lisp_time, decode_time_components): New decls.
994 (EMACS_TIME_CMP): Remove; no longer used. Plus, it was buggy, in
995 that it mishandled time_t overflow. You can't compare by subtracting!
996 (EMACS_TIME_EQ, EMACS_TIME_NE, EMACS_TIME_GT, EMACS_TIME_GE)
997 (EMACS_TIME_LT, EMACS_TIME_LE): Rewrite in terms of timespec_cmp.
999 * term.c: Include <sys/time.h>.
1000 (timeval_to_Time): New function, for proper overflow wraparound.
1001 (term_mouse_position, term_mouse_click): Use it.
1003 * undo.c (record_first_change): Support higher-resolution time stamps
1005 (Fprimitive_undo): Use them when restoring time stamps.
1007 * w32.c (ltime, U64_TO_LISP_TIME, process_times, emacs_gnutls_pull)
1008 (w32_get_internal_run_time):
1009 Port to higher-resolution Emacs time stamps.
1010 (ltime): Now accepts single 64-bit integer, as that's more convenient
1013 * xdisp.c (start_hourglass): Port to ns-resolution time stamps.
1015 * xgselect.c, xgselect.h (xg_select): Add sigmask argument,
1016 for compatibility with pselect. Support ns-resolution time stamps.
1018 * xmenu.c (x_menu_wait_for_event): Support ns-resolution time stamps.
1020 * xselect.c (wait_for_property_change, x_get_foreign_selection):
1021 Check for time stamp overflow, and support ns-resolution time stamps.
1023 * xterm.c: Don't include sys/time.h; gnulib does that for us now.
1024 Don't worry about whether HAVE_TIMEVAL and HAVE_SELECT are set.
1025 (timeval_subtract): Remove; no longer needed.
1026 (XTflash, XTring_bell, x_wait_for_event):
1027 Port to ns-resolution time stamps. Don't assume time_t is signed.
1029 2012-06-22 Chong Yidong <cyd@gnu.org>
1031 * xdisp.c (x_consider_frame_title): Revert last change.
1033 2012-06-22 Eli Zaretskii <eliz@gnu.org>
1035 * alloc.c (NSTATICS): Enlarge to 0x650. Otherwise, Emacs compiled
1036 with -DENABLE_CHECKING -DXASSERTS -DGLYPH_DEBUG=1 -DBYTE_CODE_METER
1037 aborts in staticpro during startup. (Without -DBYTE_CODE_METER,
1038 staticidx goes up to 1597 out of 1600 = 0x640.)
1040 2012-06-20 Paul Eggert <eggert@cs.ucla.edu>
1042 * fileio.c (Fdefault_file_modes): Block input while fiddling with umask.
1043 Otherwise, the umask might be mistakenly 0 while handling input signals.
1045 2012-06-19 Stefan Monnier <monnier@iro.umontreal.ca>
1047 * minibuf.c (Fread_string): Bind minibuffer-completion-table.
1049 2012-06-19 Dmitry Antipov <dmantipov@yandex.ru>
1051 * alloc.c, bytecode.c, ccl.c, coding.c, composite.c, data.c, dosfns.c:
1052 * font.c, image.c, keyboard.c, lread.c, menu.c, minibuf.c, msdos.c:
1053 * print.c, syntax.c, window.c, xmenu.c, xselect.c: Replace direct
1054 access to `contents' member of Lisp_Vector objects with AREF and ASET
1057 2012-06-19 Chong Yidong <cyd@gnu.org>
1059 * frame.c (delete_frame): When selecting a frame on a different
1060 text terminal, do not alter the terminal's top-frame.
1062 * xdisp.c (format_mode_line_unwind_data): Record the target
1063 frame's selected window and its terminal's top-frame.
1064 (unwind_format_mode_line): Restore them.
1065 (x_consider_frame_title, display_mode_line, Fformat_mode_line):
1067 (x_consider_frame_title): Do not condition on HAVE_WINDOW_SYSTEM,
1068 since tty frames can be explicitly named.
1069 (prepare_menu_bars): Likewise.
1071 * term.c (Ftty_top_frame): New function.
1073 2012-06-18 Paul Eggert <eggert@cs.ucla.edu>
1075 Port byte-code-meter to modern targets.
1076 * bytecode.c (METER_CODE) [BYTE_CODE_METER]: Don't assume
1077 !CHECK_LISP_OBJECT_TYPE && !USE_LSB_TAG. Problem with
1078 CHECK_LISP_OBJECT_TYPE reported by Dmitry Antipov in
1079 <http://lists.gnu.org/archive/html/emacs-devel/2012-06/msg00282.html>.
1080 (METER_1, METER_2): Simplify.
1082 2012-06-18 Stefan Monnier <monnier@iro.umontreal.ca>
1084 * data.c (Fdefalias): Return `symbol' (bug#11686).
1086 2012-06-18 Martin Rudalics <rudalics@gmx.at>
1088 * buffer.c (Fkill_buffer): Don't throw an error when the buffer
1089 gets killed during executing of this function (Bug#11665).
1090 Try to always return Qt when the buffer has been actually killed.
1091 (Vkill_buffer_query_functions): In doc-string say that functions
1092 run by this hook should not change the current buffer.
1094 2012-06-18 Paul Eggert <eggert@cs.ucla.edu>
1096 Fix recently-introduced process.c problems found by static checking.
1097 * process.c (write_queue_push, write_queue_pop, send_process):
1098 Use ptrdiff_t, not int or EMACS_INT, for buffer lengths and offsets.
1099 (write_queue_pop): Fix pointer signedness problem.
1100 (send_process): Remove unused local.
1102 2012-06-17 Chong Yidong <cyd@gnu.org>
1104 * xdisp.c (redisplay_internal): No need to redisplay terminal
1105 frames that are not on top.
1107 2012-06-17 Troels Nielsen <bn.troels@gmail.com>
1109 * process.c (make_process): Initialize write_queue.
1110 (write_queue_push, write_queue_pop): New functions.
1111 (send_process): Use them to maintain correct ordering of process
1114 2012-06-17 Paul Eggert <eggert@cs.ucla.edu>
1116 * lisp.h (eassert): Assume C89 or later.
1117 This removes the need for CHECK.
1118 (CHECK): Remove. Its comments about always evaluating its
1119 argument were confusing, as 'eassert' typically does not evaluate
1122 * coding.c (produce_chars): Use ptrdiff_t, not int.
1124 * xterm.c (x_draw_underwave): Check for integer overflow.
1125 This pacifies gcc 4.7.0 -Wunsafe-loop-optimizations on x86-64.
1127 2012-06-17 Jan Djärv <jan.h.d@swipnet.se>
1129 * nsterm.m (x_free_frame_resources): Move xfree so freed memory isn't
1130 referenced (Bug#11583).
1132 2012-06-16 Aurelien Aptel <aurelien.aptel@gmail.com>
1134 Implement wave-style variant of underlining.
1135 * dispextern.h (face_underline_type): New enum.
1136 (face): Add field for underline type.
1137 * nsterm.m (ns_draw_underwave): New function.
1138 (ns_draw_text_decoration): Use it.
1139 * w32term.c (w32_restore_glyph_string_clip, w32_draw_underwave):
1141 (x_draw_glyph_string): Use them.
1142 * xfaces.c (Qline, Qwave): New Lisp objects.
1143 (check_lface_attrs, merge_face_ref)
1144 (Finternal_set_lisp_face_attribute, realize_x_face):
1145 Handle wave-style underline face attributes.
1146 * xterm.c (x_draw_underwave): New function.
1147 (x_draw_glyph_string): Use it.
1149 2012-06-16 Juanma Barranquero <lekktu@gmail.com>
1151 * makefile.w32-in ($(BLD)/emacs.$(O), $(BLD)/fringe.$(O))
1152 ($(BLD)/xml.$(O), $(BLD)/intervals.$(O), $(BLD)/macros.$(O))
1153 ($(BLD)/minibuf.$(O), $(BLD)/regex.$(O), $(BLD)/region-cache.$(O))
1154 ($(BLD)/textprop.$(O), $(BLD)/undo.$(O), $(BLD)/window.$(O))
1155 ($(BLD)/w32select.$(O)): Update dependencies.
1157 2012-06-16 Andreas Schwab <schwab@linux-m68k.org>
1159 * buffer.h (FETCH_MULTIBYTE_CHAR): Define as inline.
1160 (BUF_FETCH_MULTIBYTE_CHAR): Likewise.
1161 * character.c (_fetch_multibyte_char_p): Remove.
1162 * alloc.c: Include "character.h" before "buffer.h".
1164 * buffer.c: Likewise.
1165 * bytecode.c: Likewise.
1166 * callint.c: Likewise.
1167 * callproc.c: Likewise.
1168 * casefiddle.c: Likewise.
1169 * casetab.c: Likewise.
1170 * category.c: Likewise.
1172 * coding.c: Likewise.
1173 * composite.c: Likewise.
1174 * dired.c: Likewise.
1175 * dispnew.c: Likewise.
1177 * dosfns.c: Likewise.
1178 * editfns.c: Likewise.
1179 * emacs.c: Likewise.
1180 * fileio.c: Likewise.
1181 * filelock.c: Likewise.
1183 * fontset.c: Likewise.
1184 * fringe.c: Likewise.
1185 * indent.c: Likewise.
1186 * insdel.c: Likewise.
1187 * intervals.c: Likewise.
1188 * keyboard.c: Likewise.
1189 * keymap.c: Likewise.
1190 * lread.c: Likewise.
1191 * macros.c: Likewise.
1192 * marker.c: Likewise.
1193 * minibuf.c: Likewise.
1194 * nsfns.m: Likewise.
1195 * nsmenu.m: Likewise.
1196 * print.c: Likewise.
1197 * process.c: Likewise.
1198 * regex.c: Likewise.
1199 * region-cache.c: Likewise.
1200 * search.c: Likewise.
1201 * syntax.c: Likewise.
1203 * textprop.c: Likewise.
1205 * unexsol.c: Likewise.
1206 * w16select.c: Likewise.
1207 * w32fns.c: Likewise.
1208 * w32menu.c: Likewise.
1209 * window.c: Likewise.
1210 * xdisp.c: Likewise.
1212 * xmenu.c: Likewise.
1214 * xselect.c: Likewise.
1216 2012-06-16 Eli Zaretskii <eliz@gnu.org>
1218 * xdisp.c (set_cursor_from_row): Don't dereference glyphs_end.
1219 If all the glyphs of the glyph row came from strings, and we have no
1220 cursor positioning clues, put the cursor on the first glyph of the
1222 (handle_face_prop): Use chunk-relative overlay string index when
1223 indexing into it->string_overlays array. (Bug#11653)
1224 (set_cursor_from_row): Use the leftmost glyph as GLYPH_BEFORE, not
1225 the rightmost. (Bug#11720)
1227 2012-06-16 Andreas Schwab <schwab@linux-m68k.org>
1229 * category.h (CHAR_HAS_CATEGORY): Define as inline.
1230 (CATEGORY_MEMBER): Enforce 1/0 value.
1231 * category.c (_temp_category_set): Remove.
1233 2012-06-16 Eli Zaretskii <eliz@gnu.org>
1235 * window.c (Fdelete_other_windows_internal)
1236 (Fdelete_window_internal): Don't access frame's mouse highlight
1237 info of the initial frame. (Bug#11677)
1239 2012-06-14 Paul Eggert <eggert@cs.ucla.edu>
1241 * .gdbinit (xgetint): Fix recently-introduced paren typo.
1242 Assume USE_2_TAGS_FOR_INTS.
1243 (xreload): Adjust $tagmask width to match recent lisp.h change.
1245 Simplify lisp.h in minor ways that should not affect code.
1246 * lisp.h (USE_2_TAGS_FOR_INTS): Remove, as it was always defined.
1247 (LISP_INT_TAG, case_Lisp_Int, LISP_STRING_TAG, LISP_INT_TAG_P)
1248 (LISP_INT1_TAG, enum Lisp_Type, XINT, XUINT, make_number):
1249 Simplify under the assumption that USE_2_TAGS_FOR_INTS is defined.
1250 (INTTYPEBITS): New macro, for clarity.
1251 (INTMASK, MOST_POSITIVE_FIXNUM): Use it.
1252 (LISP_INT1_TAG, LISP_STRING_TAG, LISP_INT_TAG_P):
1253 Simplify now that USE_LSB_TAG is always defined.
1254 (TYPEMASK, XINT) [USE_LSB_TAG]: Remove unnecessary cast.
1255 (make_number) [!USE_LSB_TAG]: Use INTMASK; that's simpler.
1257 2012-06-13 Juanma Barranquero <lekktu@gmail.com>
1259 * makefile.w32-in ($(BLD)/data.$(O)): Update dependencies.
1261 2012-06-13 Glenn Morris <rgm@gnu.org>
1263 * s/bsd-common.h (BSD4_3):
1264 * s/usg5-4-common.h (USG5_4): No longer define; unused.
1266 2012-06-13 Andreas Schwab <schwab@linux-m68k.org>
1268 * lisp.h (Lisp_Object) [CHECK_LISP_OBJECT_TYPE]: Define as struct
1271 (XHASH, XTYPE, XINT, XUINT, make_number, XSET, XPNTR, XUNTAG):
1273 * emacs.c (gdb_use_struct): Rename from gdb_use_union.
1274 * .gdbinit: Check gdb_use_struct instead of gdb_use_union.
1275 * alloc.c (widen_to_Lisp_Object): Remove.
1276 (mark_memory): Use XIL instead of widen_to_Lisp_Object.
1277 * frame.c (delete_frame): Remove outdated comment.
1278 * w32fns.c (Fw32_register_hot_key): Use XLI instead of checking
1279 USE_LISP_UNION_TYPE.
1280 (Fw32_unregister_hot_key): Likewise.
1281 (Fw32_toggle_lock_key): Likewise.
1282 * w32menu.c (add_menu_item): Likewise.
1283 (w32_menu_display_help): Use XIL instead of checking
1284 USE_LISP_UNION_TYPE.
1285 * w32heap.c (allocate_heap): Don't check USE_LISP_UNION_TYPE.
1286 (init_heap): Likewise.
1287 * w32term.c (w32_read_socket): Update comment.
1289 2012-06-13 Glenn Morris <rgm@gnu.org>
1291 * s/usg5-4-common.h, src/s/unixware.h:
1292 Remove define/undef of HAVE_SYSV_SIGPAUSE (not used since 2010-05-04).
1294 * s/gnu.h (POSIX_SIGNALS): Remove (not used since 2010-05-04).
1296 2012-06-13 Paul Eggert <eggert@cs.ucla.edu>
1298 USE_LISP_UNION_TYPE + USE_LSB_TAG cleanup (Bug#11604)
1299 * alloc.c (make_number) [!defined make_number]:
1300 Remove, as lisp.h always defines this now.
1301 (mark_maybe_pointer): Simplify since USE_LSB_TAG is always defined now.
1302 (roundup_size): Verify that it is a power of 2.
1303 * data.c (Fmake_variable_buffer_local, Fmake_local_variable):
1304 * ftfont.c (ftfont_driver): Use LISP_INITIALLY_ZERO.
1305 * lisp.h (USE_LSB_TAG): Allow the builder to compile with
1306 -DUSE_LSB_TAG=0, to override the automatically-selected default.
1307 USE_LSB_TAG now is always defined to be either 0 or 1.
1309 (union Lisp_Object): Don't worry about WORDS_BIGENDIAN; the
1310 code works fine either way, and efficiency is not a concern here,
1311 as the union type is for debugging, not for production.
1312 (LISP_MAKE_RVALUE, make_number) [USE_LISP_UNION_TYPE]:
1313 Use an inline function on all platforms when using the union type,
1314 since this is simpler and 'static inline' can be used portably
1316 (LISP_INITIALLY_ZERO): New macro.
1317 (XFASTINT, XSETFASTINT) [USE_LISP_UNION_TYPE]: Remove.
1318 (XSET) [USE_LISP_UNION_TYPE]: Don't overparenthesize.
1320 2012-06-12 Glenn Morris <rgm@gnu.org>
1322 * s/gnu-kfreebsd.h, s/hpux11.h, s/openbsd.h, s/sol2-10.h: Remove files.
1324 * s/gnu-linux.h (HAVE_PROCFS): Move to configure.
1326 * s/hpux10-20.h, s/openbsd.h, s/usg5-4-common.h:
1327 Move BROKEN_SIGIO to configure.
1329 * s/bsd-common.h, s/darwin.h, s/gnu-kfreebsd.h, s/hpux10-20.h:
1330 Move NO_TERMIO to configure.
1332 2012-06-12 Chong Yidong <cyd@gnu.org>
1334 * image.c (imagemagick_load_image): Use MagickFlattenImage if
1335 MagickMergeImageLayers is undefined. Use pixel pusher loop if
1336 MagickExportImagePixels is undefined.
1338 2012-06-12 Paul Eggert <eggert@cs.ucla.edu>
1340 * image.c (imagemagick_load_image): Remove unused label.
1342 2012-06-11 Glenn Morris <rgm@gnu.org>
1344 * s/aix4-2.h, s/bsd-common.h, s/cygwin.h, s/darwin.h:
1345 * s/gnu-kfreebsd.h, s/gnu-linux.h, s/gnu.h, s/hpux10-20.h:
1346 * s/irix6-5.h, s/ms-w32.h, s/msdos.h, s/template.h:
1347 * s/usg5-4-common.h: Move SYSTEM_TYPE to configure.
1349 2012-06-11 Stefan Monnier <monnier@iro.umontreal.ca>
1351 * alloc.c (make_byte_code): New function.
1352 (Fmake_byte_code): Use it. Don't purify here.
1353 * lread.c (read1): Use it as well to avoid extra allocation.
1355 2012-06-11 Chong Yidong <cyd@gnu.org>
1357 * image.c (imagemagick_load_image): Implement transparency.
1359 2012-06-10 Andreas Schwab <schwab@linux-m68k.org>
1361 * regex.c (at_begline_loc_p): Also recognize `(?N:' and correctly
1362 account for preceding backslashes. (Bug#11663)
1364 2012-06-09 Chong Yidong <cyd@gnu.org>
1366 * term.c: Support italics in capable terminals (Bug#9652).
1367 (no_color_bit): Replace unused NC_BLINK with NC_ITALIC.
1368 (turn_on_face): Output using TS_enter_italic_mode if available.
1369 Don't handle unused blinking and alt-charset cases.
1370 (turn_off_face): Handle italic case; discard unused tty_blinking_p
1371 and tty_alt_charset_p cases.
1372 (tty_capable_p, init_tty): Support italics.
1374 * termchar.h (struct tty_display_info): Add field for italics.
1375 Remove unused blink field.
1377 * xfaces.c (tty_supports_face_attributes_p, realize_tty_face):
1380 * dispextern.h: Replace unused TTY_CAP_BLINK with TTY_CAP_ITALIC.
1381 (struct face): Remove unused fields tty_dim_p, tty_blinking_p, and
1382 tty_alt_charset_p. Add tty_italic_p.
1384 2012-06-09 Michael Albinus <michael.albinus@gmx.de>
1386 * dbusbind.c (XD_BASIC_DBUS_TYPE): Use dbus_type_is_valid and
1387 dbus_type_is_basic if available.
1388 (xd_extract_signed, xd_extract_unsigned): Rename from
1389 extract_signed and extract_unsigned, respectively. Adapt callers.
1391 2012-06-09 Chong Yidong <cyd@gnu.org>
1393 * xfaces.c (face_for_overlay_string): Handle face remapping (Bug#2066).
1395 * fringe.c (Fset_fringe_bitmap_face): Handle the noninteractive
1398 2012-06-08 Paul Eggert <eggert@cs.ucla.edu>
1400 * xdisp.c (vmessage): Treat frame message as multibyte.
1401 Without this change, (let ((§ 1)) (make-variable-buffer-local '§))
1402 would generate the diagnostic "Making \302\247 buffer-local while
1405 2012-06-08 Eli Zaretskii <eliz@gnu.org>
1407 * dispnew.c (showing_window_margins_p): Undo last change, which
1408 was done due to an inadvertent commit.
1409 (adjust_frame_glyphs_for_frame_redisplay): Do call
1410 showing_window_margins_p.
1412 2012-06-08 Stefan Monnier <monnier@iro.umontreal.ca>
1414 * eval.c (Fmake_var_non_special): New primitive.
1415 (syms_of_eval): Defsubr it.
1416 * lread.c (syms_of_lread): Mark `values' as lexically scoped.
1418 2012-06-08 Juanma Barranquero <lekktu@gmail.com>
1420 * dispnew.c (showing_window_margins_p): Wrap in #if 0 to prevent unused
1421 function warning (the only call is inside #if 0 since 2012-06-08T08:44:45Z!eliz@gnu.org).
1423 2012-06-08 Eli Zaretskii <eliz@gnu.org>
1425 * alloc.c (allocate_vectorlike): Fix last change.
1427 2012-06-08 Dmitry Antipov <dmantipov@yandex.ru>
1429 Block-based vector allocation of small vectors.
1430 * lisp.h (struct vectorlike_header): New field `nbytes',
1431 adjust comment accordingly.
1432 * alloc.c (enum mem_type): New type `MEM_TYPE_VECTOR_BLOCK'
1433 to denote vector blocks. Adjust users (live_vector_p,
1434 mark_maybe_pointer, valid_lisp_object_p) accordingly.
1435 (COMMON_MULTIPLE): Move outside #if USE_LSB_TAG.
1436 (VECTOR_BLOCK_SIZE, vroundup, VECTOR_BLOCK_BYTES),
1437 (VBLOCK_BYTES_MIN, VBLOCK_BYTES_MAX, VECTOR_MAX_FREE_LIST_INDEX),
1438 (VECTOR_FREE_LIST_FLAG, ADVANCE, VINDEX, SETUP_ON_FREE_LIST),
1439 (VECTOR_SIZE, VECTOR_IN_BLOCK): New macros.
1440 (roundup_size): New constant.
1441 (struct vector_block): New data type.
1442 (vector_blocks, vector_free_lists, zero_vector): New variables.
1443 (all_vectors): Rename to `large_vectors'.
1444 (allocate_vector_from_block, init_vectors, allocate_vector_from_block)
1445 (sweep_vectors): New functions.
1446 (allocate_vectorlike): Return `zero_vector' as the only vector of
1447 0 items. Allocate new vector from block if vector size is less than
1448 or equal to VBLOCK_BYTES_MAX.
1449 (Fgarbage_collect): Move all vector sweeping code to sweep_vectors.
1450 (init_alloc_once): Add call to init_vectors.
1452 2012-06-08 Stefan Monnier <monnier@iro.umontreal.ca>
1454 * eval.c (Fmacroexpand): Stop if the macro returns the same form.
1456 2012-06-07 Paul Eggert <eggert@cs.ucla.edu>
1458 * doprnt.c (doprnt): Truncate multibyte char correctly.
1459 Without this change, doprnt (buf, 2, "%s", FORMAT_END, AP)
1460 would mishandle a string argument "Xc" if X was a multibyte
1461 character of length 2: it would truncate after X's first byte
1462 rather than including all of X.
1464 2012-06-06 Chong Yidong <cyd@gnu.org>
1466 * buffer.c (word_wrap): Doc fix.
1468 2012-06-04 Paul Eggert <eggert@cs.ucla.edu>
1470 * xdisp.c (note_mode_line_or_margin_highlight): Pacify gcc -Wall.
1472 2012-06-03 Glenn Morris <rgm@gnu.org>
1474 * xdisp.c (tool-bar-style): Doc fix.
1476 2012-06-03 Ulrich Müller <ulm@gentoo.org>
1478 * Makefile.in (PAXCTL): Define.
1479 (temacs$(EXEEXT)): Disable memory randomization for the temacs
1480 binary via PaX flags if the paxctl utility is available.
1481 (emacs$(EXEEXT), bootstrap-emacs$(EXEEXT)):
1482 Restore PaX flags to their default. (Bug#11398)
1484 2012-06-03 Chong Yidong <cyd@gnu.org>
1486 * xdisp.c (decode_mode_spec_coding): Display a space for a unibyte
1489 2012-06-03 Chong Yidong <cyd@gnu.org>
1491 * xdisp.c (calc_pixel_width_or_height): Use Fbuffer_local_value.
1492 (note_mode_line_or_margin_highlight): If there is no help echo,
1493 use mode-line-default-help-echo. Handle the case where the mouse
1494 position is past the end of the mode line string.
1496 * buffer.c (buffer_local_value_1): New function, split from
1497 Fbuffer_local_value; can return Qunbound.
1498 (Fbuffer_local_value): Use it.
1499 (Vmode_line_format): Docstring tweaks.
1501 2012-06-02 Paul Eggert <eggert@cs.ucla.edu>
1503 * sysdep.c (system_process_attributes): Improve comment.
1505 2012-06-02 Stefan Monnier <monnier@iro.umontreal.ca>
1507 * keyboard.c: Export real-this-command to Elisp.
1508 (syms_of_keyboard): Rename real_this_command to Vreal_this_command
1509 and DEFVAR it. Update all users.
1511 2012-06-02 Paul Eggert <eggert@cs.ucla.edu>
1513 * minibuf.c (Fassoc_string): Remove duplicate declaration.
1515 * sysdep.c (system_process_attributes) [SOLARIS2 && HAVE_PROCFS]:
1516 Convert pctcpu and pctmem to Lisp float properly.
1517 Let the compiler fold better, as 100.0/0x8000 is exact.
1519 2012-06-02 Andreas Schwab <schwab@linux-m68k.org>
1521 * alloc.c (CONS_BLOCK_SIZE): Account for padding at the end of
1524 2012-06-01 Paul Eggert <eggert@cs.ucla.edu>
1526 * xfns.c (x_set_tool_bar_lines) [USE_GTK]: Adjust to bitfield change.
1528 2012-06-01 Dmitry Antipov <dmantipov@yandex.ru>
1530 For a 'struct window', replace some Lisp_Object fields to
1531 bitfields where appropriate, remove unused fields.
1532 * window.h (struct window): Remove unused 'last_mark_x' and
1533 'last_mark_y' fields. Rename 'mini_p' field to 'mini',
1534 change it's type from Lisp_Object to bitfield.
1535 Change type of 'force_start', 'optional_new_start',
1536 'last_had_star', 'update_mode_line' and 'start_at_line_beg'
1537 fields from Lisp_Object to bitfield. Adjust users accordingly.
1539 2012-05-31 Paul Eggert <eggert@cs.ucla.edu>
1541 Pacify gcc -Wdouble-precision when using Xaw.
1542 * xterm.c (xaw_jump_callback, x_set_toolkit_scroll_bar_thumb)
1543 [HAVE_X_WINDOWS && USE_TOOLKIT_SCROLL_BARS && !USE_MOTIF && !USE_GTK]:
1544 Use 'float' consistently, rather than 'float' in most places
1545 and 'double' in a couple of places.
1547 2012-05-31 Eli Zaretskii <eliz@gnu.org>
1549 * xdisp.c (handle_stop): Detect whether we have overlay strings
1550 loaded by testing it->current.overlay_string_index to be
1551 non-negative, instead of checking whether n_overlay_strings is
1552 positive. (Bug#11587)
1554 2012-05-31 Chong Yidong <cyd@gnu.org>
1556 * keymap.c (describe_map_tree): Revert 2011-07-07 change (Bug#1169).
1558 * doc.c (Fsubstitute_command_keys): Doc fix.
1560 2012-05-31 Eli Zaretskii <eliz@gnu.org>
1562 * search.c (search_buffer): Remove calls to
1563 r_alloc_inhibit_buffer_relocation, as it is now called by
1564 maybe_unify_char, which was the cause of relocation of buffer text
1567 2012-05-31 Eli Zaretskii <eliz@gnu.org>
1569 * charset.c (maybe_unify_char): Inhibit relocation of buffer text
1570 for the duration of call to load_charset, to avoid problems with
1571 callers of maybe_unify_char that access buffer text through C
1574 * ralloc.c (r_alloc_inhibit_buffer_relocation): Increment and
1575 decrement the inhibition flag, instead of just setting or
1578 2012-05-31 Paul Eggert <eggert@cs.ucla.edu>
1580 Remove obsolete '#define static' cruft.
1581 * s/hpux10-20.h (_FILE_OFFSET_BITS): Don't #undef.
1582 This #undef was "temporary" in 2000; it is no longer needed
1583 now that '#define static' has gone away.
1584 * xfns.c, xterm.h (gray_bitmap_width, gray_bitmap_height)
1585 (gray_bitmap_bits): Remove; no longer needed.
1586 All uses replaced with definiens.
1587 * xterm.c: Include "bitmaps/gray.xbm".
1589 2012-05-30 Paul Eggert <eggert@cs.ucla.edu>
1591 Clean up __executable_start, monstartup when --enable-profiling.
1592 The following changes affect the code only when profiling.
1593 * dispnew.c (__executable_start): Rename from safe_bcopy.
1594 Define only on platforms that need it.
1595 * emacs.c: Include <sys/gmon.h> when profiling.
1596 (_mcleanup): Remove decl, since <sys/gmon.h> does it now.
1597 (__executable_start): Remove decl, since lisp.h does it now.
1598 (safe_bcopy): Remove decl; no longer has that name.
1599 (main): Coalesce #if into single bit of code, for simplicity.
1600 Cast pointers to uintptr_t, since standard libraries want integers
1602 * lisp.h (__executable_start): New decl.
1604 2012-05-31 Glenn Morris <rgm@gnu.org>
1606 * image.c (Fimagemagick_types): Doc fix.
1608 2012-05-30 Jim Meyering <meyering@redhat.com>
1610 * callproc.c (Fcall_process_region): Include directory component
1611 in mkstemp error message (Bug#11586).
1613 2012-05-30 Paul Eggert <eggert@cs.ucla.edu>
1615 * alloc.c, lisp.h (make_pure_vector): Now static.
1617 2012-05-30 Stefan Monnier <monnier@iro.umontreal.ca>
1619 * eval.c (Fdefun, Fdefmacro, Vmacro_declaration_function):
1620 Move to byte-run.el.
1621 (Fautoload): Do the hash-doc more carefully.
1622 * data.c (Fdefalias): Purify definition, except for keymaps.
1623 (Qdefun): Move from eval.c.
1624 * lisp.h (Qdefun): Remove.
1625 * lread.c (read1): Tiny simplification.
1627 2012-05-29 Troels Nielsen <bn.troels@gmail.com>
1629 Do not create empty overlays with the evaporate property (Bug#9642).
1630 * buffer.c (Fmove_overlay): Reinstate the earlier fix for
1631 Bug#9642, but explicitly check that the buffer the overlay would
1632 be moved to is live and rearrange lines to make sure that errors
1633 will not put the overlay in an inconsistent state.
1634 (Fdelete_overlay): Cosmetics.
1636 2012-05-28 Eli Zaretskii <eliz@gnu.org>
1638 * w32term.c (my_bring_window_to_top): New function.
1639 (x_raise_frame): Use handle returned by DeferWindowPos, which
1640 could be different from the original one.
1641 Call my_bring_window_to_top instead of my_set_foreground_window.
1644 * w32fns.c (w32_wnd_proc): Accept and process WM_EMACS_BRINGTOTOP
1645 by calling BringWindowToTop.
1647 * w32term.h (WM_EMACS_BRINGTOTOP): New message.
1648 (WM_EMACS_END): Increase by one.
1650 2012-05-28 Paul Eggert <eggert@cs.ucla.edu>
1652 * bidi.c (bidi_mirror_char): Put eassert before conversion to int.
1653 This avoids undefined behavior that might cause the eassert
1654 to not catch an out-of-range value.
1656 2012-05-28 Juanma Barranquero <lekktu@gmail.com>
1658 * makefile.w32-in ($(BLD)/w32inevt.$(O), $(BLD)/w32console.$(O)):
1659 Update dependencies.
1661 2012-05-27 Eli Zaretskii <eliz@gnu.org>
1663 * bidi.c (bidi_mirror_char): Fix last change.
1665 2012-05-27 Andreas Schwab <schwab@linux-m68k.org>
1667 * unexmacosx.c (copy_data_segment): Truncate after 16 characters
1668 when referring to sectname field in printf format.
1670 2012-05-27 Paul Eggert <eggert@cs.ucla.edu>
1672 * lisp.h [REL_ALLOC]: Omit duplicate prototypes.
1673 Only r_alloc_inhibit_buffer_relocation needed to be added;
1674 the others were already declared.
1676 * bidi.c (bidi_mirror_char): Don't possibly truncate the integer
1677 before checking whether it's out of range. Put the check inside
1679 <http://lists.gnu.org/archive/html/emacs-devel/2012-05/msg00485.html>.
1681 2012-05-27 Ken Brown <kbrown@cornell.edu>
1683 * callproc.c (Fcall_process): Restore a line that was accidentally
1684 commented out in the 2011-02-13 change (bug#11547).
1686 2012-05-27 Eli Zaretskii <eliz@gnu.org>
1688 * lisp.h [REL_ALLOC]: Add prototypes for external functions
1689 defined on ralloc.c.
1691 * buffer.c [REL_ALLOC]: Remove prototypes of
1692 r_alloc_reset_variable, r_alloc, r_re_alloc, and r_alloc_free,
1693 they are now on lisp.h.
1695 * ralloc.c (r_alloc_inhibit_buffer_relocation): New function.
1697 * search.c (search_buffer): Use it to inhibit relocation of buffer
1698 text while re_search_2 is doing its job, because re_search_2 is
1699 passed C pointers to buffer text. (Bug#11519)
1701 * msdos.c (internal_terminal_init) <Vwindow_system_version>:
1704 * xdisp.c (move_it_to): Under MOVE_TO_Y, when restoring iterator
1705 state after an additional call to move_it_in_display_line_to, keep
1706 the values of it->max_ascent and it->max_descent found for the
1708 (pos_visible_p): Revert the comparison against bottom_y to what it
1709 was in revid eliz@gnu.org-20120513182235-4p6386j761ld0nwb.
1712 2012-05-26 Paul Eggert <eggert@cs.ucla.edu>
1714 Fix coding-related core dumps with gcc -ftrapv.
1715 The code was computing A - B, where A and B are pointers, and B is
1716 random garbage. This can lead to core dumps on platforms that
1717 have special pointer registers, and it also leads to core dumps on
1718 x86-64 when compiled with gcc -ftrapv. The fix is to compute
1719 A - B only when B is initialized properly.
1720 * coding.c (coding_set_source, coding_set_destination): Return void.
1721 (coding_change_source, coding_change_destinations): New functions,
1722 with the old behaviors of coding_set_source and coding_set_destination.
1723 All callers that need an offset changed to use these new functions.
1725 2012-05-26 Glenn Morris <rgm@gnu.org>
1727 * nsterm.m (ns_init_paths): Don't mess with INFOPATH. (Bug#2791)
1729 2012-05-26 Eli Zaretskii <eliz@gnu.org>
1731 Extend mouse support on W32 text-mode console.
1732 * xdisp.c (draw_row_with_mouse_face):
1733 Call tty_draw_row_with_mouse_face for WINDOWSNT as well.
1735 * w32console.c: Include window.h.
1736 (w32con_write_glyphs_with_face, tty_draw_row_with_mouse_face):
1738 (initialize_w32_display): Initialize mouse-highlight data.
1740 * w32inevt.c: Include termchar.h and window.h.
1741 (do_mouse_event): Support mouse-autoselect-window. When the mouse
1742 moves, call note_mouse_highlight. If help_echo changed, call
1743 gen_help_event to produce help-echo message in the echo area.
1744 Call clear_mouse_face if mouse_face_hidden is set in the mouse
1747 2012-05-26 Paul Eggert <eggert@cs.ucla.edu>
1749 * lread.c (read1): Simplify slightly to avoid an overflow warning
1750 with GCC 4.7.0 on x86-64.
1752 2012-05-26 Eli Zaretskii <eliz@gnu.org>
1754 * bidi.c (bidi_mirror_char): Revert last change: an int is
1755 definitely wide enough here.
1757 2012-05-25 Paul Eggert <eggert@cs.ucla.edu>
1759 Fix integer width and related bugs (Bug#9874).
1760 * alloc.c (pure_bytes_used_lisp, pure_bytes_used_non_lisp):
1761 (allocate_vectorlike, buffer_memory_full, struct sdata, SDATA_SIZE)
1762 (string_bytes, check_sblock, allocate_string_data):
1763 (compact_small_strings, Fmake_bool_vector, make_string)
1764 (make_unibyte_string, make_multibyte_string)
1765 (make_string_from_bytes, make_specified_string)
1766 (allocate_vectorlike, Fmake_vector, find_string_data_in_pure)
1767 (make_pure_string, make_pure_c_string, make_pure_vector, Fpurecopy)
1769 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1770 (allocate_pseudovector):
1771 Use int, not EMACS_INT, where int is wide enough.
1772 (inhibit_garbage_collection, Fgarbage_collect):
1773 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1774 * bidi.c (bidi_mirror_char): Use EMACS_INT, not int, where
1775 int might not be wide enough.
1776 (bidi_cache_search, bidi_cache_find, bidi_init_it)
1777 (bidi_count_bytes, bidi_char_at_pos, bidi_fetch_char)
1778 (bidi_at_paragraph_end, bidi_find_paragraph_start)
1779 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak)
1780 (bidi_level_of_next_char, bidi_move_to_visually_next):
1781 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1782 * buffer.c (copy_overlays, Fgenerate_new_buffer_name)
1783 (Fkill_buffer, Fset_buffer_major_mode)
1784 (advance_to_char_boundary, Fbuffer_swap_text)
1785 (Fset_buffer_multibyte, overlays_at, overlays_in)
1786 (overlay_touches_p, struct sortvec, record_overlay_string)
1787 (overlay_strings, recenter_overlay_lists)
1788 (adjust_overlays_for_insert, adjust_overlays_for_delete)
1789 (fix_start_end_in_overlays, fix_overlays_before, modify_overlay)
1790 (Fmove_overlay, Fnext_overlay_change, Fprevious_overlay_change)
1791 (Foverlay_recenter, last_overlay_modification_hooks_used)
1792 (report_overlay_modification, evaporate_overlays, enlarge_buffer_text):
1793 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1794 (validate_region): Omit unnecessary test for b <= e,
1795 since that's guaranteed by the previous test.
1796 (adjust_overlays_for_delete): Avoid pos + length overflow.
1797 (Fmove_overlay, Fdelete_overlay, add_overlay_mod_hooklist)
1798 (report_overlay_modification):
1799 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1800 (Foverlays_at, Fnext_overlay_change, Fprevious_overlay_change):
1801 Omit pointer cast, which isn't needed anyway, and doesn't work
1802 after the EMACS_INT -> ptrdiff_t change.
1803 (Fmove_overlay): Clip BEG and END to ptrdiff_t to avoid overflow.
1804 * buffer.h: Adjust decls to match defn changes elsewhere.
1805 (struct buffer_text, struct buffer):
1806 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1807 Use EMACS_INT, not int, where int might not be wide enough.
1808 * bytecode.c (unmark_byte_stack, exec_byte_code): Use ptrdiff_t,
1809 not int, to avoid needless 32-bit limit on 64-bit hosts.
1810 (exec_byte_code): Use tighter memory-full test, one that checks
1811 for alloca overflow. Don't compute the address of the object just
1812 before an array, as that's not portable. Use EMACS_INT, not
1813 ptrdiff_t or int, where ptrdiff_t or int might not be wide enough.
1814 * callint.c (Fcall_interactively):
1815 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1816 * callproc.c (call_process_kill, Fcall_process):
1817 Don't assume pid_t fits into an Emacs fixnum.
1818 (call_process_cleanup, Fcall_process, child_setup):
1819 Don't assume pid_t fits into int.
1820 (call_process_cleanup, Fcall_process, delete_temp_file)
1821 (Fcall_process_region):
1822 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1823 (Fcall_process): Simplify handling of volatile integers.
1824 Use int, not EMACS_INT, where int will do.
1825 * casefiddle.c (casify_object, casify_region, operate_on_word)
1826 (Fupcase_word, Fdowncase_word, Fcapitalize_word):
1827 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1828 (casify_object): Avoid integer overflow when overallocating buffer.
1829 * casetab.c (set_identity, shuffle): Prefer int to unsigned when
1830 either works. Use lint_assume to convince GCC 4.6.1 that it's OK.
1831 * category.c (Fchar_category_set): Don't assume fixnum fits in int.
1832 * category.h (CATEGORYP): Don't assume arg is nonnegative.
1833 * ccl.c (GET_CCL_INT): Remove; no longer needed, since the
1834 integers are now checked earlier. All uses replaced with XINT.
1836 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1837 For CCL_MapSingle, check that content and value are in int range.
1838 (ccl_driver, Fregister_code_conversion_map):
1839 Check that Vcode_version_map_vector is a vector.
1840 (resolve_symbol_ccl_program): Check that vector header is in range.
1841 Always copy the vector, so that we can check its contents reliably
1842 now rather than having to recheck each instruction as it's being
1843 executed. Check that vector words fit in 'int'.
1844 (ccl_get_compiled_code, Fregister_ccl_program)
1845 (Fregister_code_conversion_map): Use ptrdiff_t, not int, for
1846 program indexes, to avoid needless 32-bit limit on 64-bit hosts.
1847 (Fccl_execute, Fccl_execute_on_string): Check that initial reg
1848 contents are in range.
1849 (Fccl_execute_on_string): Check that status is in range.
1850 * ccl.h (struct ccl_program.idx): Now ptrdiff_t, not int.
1851 * character.c (char_resolve_modifier_mask, Fchar_resolve_modifiers):
1852 Accept and return EMACS_INT, not int, because callers can pass values
1854 (c_string_width, strwidth, lisp_string_width, chars_in_text)
1855 (multibyte_chars_in_text, parse_str_as_multibyte)
1856 (str_as_multibyte, count_size_as_multibyte, str_to_multibyte)
1857 (str_as_unibyte, str_to_unibyte, string_count_byte8)
1858 (string_escape_byte8, Fget_byte):
1859 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1860 (Funibyte_string): Use CHECK_RANGED_INTEGER, not CHECK_NATNUM, to
1861 avoid mishandling large integers.
1862 * character.h: Adjust decls to match defn changes elsewhere.
1863 * charset.c (load_charset_map_from_file, find_charsets_in_text)
1864 (Ffind_charset_region):
1865 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1866 (load_charset_map_from_file): Redo idx calculation to avoid overflow.
1867 (load_charset_map_from_vector, Fdefine_charset_internal):
1868 Don't assume fixnum fits in int.
1869 (load_charset_map_from_vector, Fmap_charset_chars):
1870 Remove now-unnecessary CHECK_NATNUMs.
1871 (Fdefine_charset_internal): Check ranges here, more carefully.
1872 Don't rely on undefined behavior with signed left shift overflow.
1873 Don't assume unsigned int fits into fixnum, or that fixnum fits
1874 into unsigned int. Don't require max_code to be a valid fixnum;
1875 that's not true for gb10830 4-byte on a 32-bit host. Allow
1876 invalid_code to be a cons, for the same reason. Require code_offset
1877 to be a character. Avoid int overflow if max_char is close
1879 (CODE_POINT_TO_INDEX): On 32-bit hosts, return int, not unsigned;
1880 this is intended anyway and avoids some undefined behavior.
1881 (load_charset_map): Pass unsigned, not int, as 2nd arg of
1882 INDEX_TO_CODE_POINT, as that's what it expects.
1883 (Funify_charset, encode_char): Don't stuff unsigned vals into int vars.
1884 * charset.h (DECODE_CHAR): Return int, not unsigned;
1885 this is what was intended anyway, and it avoids undefined behavior.
1886 (CHARSET_OFFSET): Remove unused macro, instead of fixing its
1887 integer-overflow issues.
1888 (ENCODE_CHAR): Return unsigned on all hosts, not just on 32-bit hosts.
1889 Formerly, it returned EMACS_INT on 64-bit hosts in the common case
1890 where the argument is EMACS_INT, and this behavior is not intended.
1891 * chartab.c (Fmake_char_table, Fset_char_table_range)
1892 (uniprop_get_decoder, uniprop_get_encoder):
1893 Don't assume fixnum fits in int.
1894 * cmds.c (move_point): New function, that does the gist of
1895 Fforward_char and Fbackward_char, but does so while checking
1896 for integer overflow more accurately.
1897 (Fforward_char, Fbackward_char): Use it.
1898 (Fforward_line, Fend_of_line, internal_self_insert)
1899 (internal_self_insert):
1900 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1901 Fix a FIXME, by checking for integer overflow when calculating
1902 target_clm and actual_clm.
1903 * coding.c (detect_coding_XXX, encode_coding_XXX, CODING_DECODE_CHAR)
1904 (CODING_ENCODE_CHAR, CODING_CHAR_CHARSET, CODING_CHAR_CHARSET_P)
1905 (ASSURE_DESTINATION, coding_alloc_by_realloc)
1906 (coding_alloc_by_making_gap, alloc_destination)
1907 (detect_coding_utf_8, encode_coding_utf_8, decode_coding_utf_16)
1908 (encode_coding_utf_16, detect_coding_emacs_mule)
1909 (decode_coding_emacs_mule, encode_coding_emacs_mule)
1910 (detect_coding_iso_2022, decode_coding_iso_2022)
1911 (encode_invocation_designation, encode_designation_at_bol)
1912 (encode_coding_iso_2022, detect_coding_sjis, detect_coding_big5)
1913 (decode_coding_sjis, decode_coding_big5, encode_coding_sjis)
1914 (encode_coding_big5, detect_coding_ccl, decode_coding_ccl)
1915 (encode_coding_ccl, encode_coding_raw_text)
1916 (detect_coding_charset, decode_coding_charset)
1917 (encode_coding_charset, detect_eol, decode_eol, produce_chars)
1918 (produce_composition, produce_charset, produce_annotation)
1919 (decode_coding, handle_composition_annotation)
1920 (handle_charset_annotation, consume_chars, decode_coding_gap)
1921 (decode_coding_object, encode_coding_object, detect_coding_system)
1922 (Ffind_coding_systems_region_internal, Fcheck_coding_systems_region)
1923 (code_convert_region, code_convert_string)
1924 (Fdefine_coding_system_internal)
1925 (coding_set_source, coding_set_destination):
1926 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1927 (setup_iso_safe_charsets, consume_chars, Funencodable_char_position)
1928 (Fdefine_coding_system_internal):
1929 Don't assume fixnums fit in int.
1930 (decode_coding_gap, decode_coding_object, encode_coding_object)
1931 (Fread_coding_system, Fdetect_coding_region)
1932 (Funencodable_char_position, Fcheck_coding_systems_region)
1933 (get_translation, handle_composition_annotation, consume_chars):
1934 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1935 (consume_chars): Rewrite to not calculate an address outside buffer.
1936 (Ffind_operation_coding_system): NATNUMP can eval its arg twice.
1937 Don't access memory outside of the args array.
1938 (Fdefine_coding_system_internal): Check for charset-id overflow.
1939 (ENCODE_ISO_CHARACTER): Use unsigned, not int, to store the unsigned
1940 result of ENCODE_CHAR.
1941 * coding.h: Adjust decls to match defn changes elsewhere.
1942 (struct coding_system):
1943 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1944 * composite.c (get_composition_id, find_composition)
1945 (run_composition_function, update_compositions)
1946 (compose_text, composition_gstring_put_cache)
1947 (composition_gstring_p, composition_gstring_width)
1948 (fill_gstring_header, fill_gstring_body, autocmp_chars)
1949 (composition_compute_stop_pos, composition_reseat_it)
1950 (composition_update_it, struct position_record)
1951 (find_automatic_composition, composition_adjust_point)
1952 (Fcomposition_get_gstring, Ffind_composition_internal):
1953 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1954 (update_compositions):
1955 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1956 * composite.h: Adjust decls to match defn changes elsewhere.
1957 (struct composition):
1958 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1959 * data.c (let_shadows_buffer_binding_p, let_shadows_global_binding_p):
1960 Do not attempt to compute the address of the object just before a
1961 buffer; this is not portable.
1963 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1964 (Faset): Use int, not EMACS_INT, where int is wide enough.
1965 (Fstring_to_number): Don't assume fixnums fit in int.
1966 (Frem): Don't assume arg is nonnegative.
1967 * dbusbind.c (xd_append_arg): Check for integers out of range.
1968 (Fdbus_call_method): Don't overflow the timeout int.
1969 (extract_signed, extract_unsigned): New functions.
1970 (XD_CHECK_DBUS_SERIAL): Remove; superseded by extract_unsigned.
1971 (xd_get_connection_references): Return ptrdiff_t, not int.
1973 (xd_signature, xd_append_arg, xd_retrieve_arg, Fdbus_message_internal)
1974 (xd_read_message_1):
1975 Use int, not unsigned, where the dbus API uses int.
1976 (Fdbus_message_internal): Don't overflow mtype.
1977 (syms_of_dbusbind): Allocate right-sized buffer for integers.
1978 * dired.c (directory_files_internal, file_name_completion, scmp)
1979 (file_name_completion_stat):
1980 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1981 (file_name_completion): Don't overflow matchcount.
1982 (file_name_completion_stat): Use SAFE_ALLOCA, not alloca.
1983 * dispextern.h: Adjust decls to match defn changes elsewhere.
1984 (struct text_pos, struct glyph, struct bidi_saved_info)
1985 (struct bidi_string_data, struct bidi_it, struct composition_it)
1987 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1988 (struct display_pos, struct composition_it, struct it):
1989 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1990 * dispnew.c (increment_matrix_positions)
1991 (increment_row_positions, mode_line_string)
1992 (marginal_area_string):
1993 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1994 (change_frame_size_1, Fredisplay, Fframe_or_buffer_changed_p):
1995 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1996 (duration_to_sec_usec): New function, to check for overflow better.
1997 (Fsleep_for, sit_for): Use it.
1998 * doc.c (get_doc_string, store_function_docstring):
1999 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2000 (get_doc_string, Fsnarf_documentation):
2001 Use int, not EMACS_INT, where int is wide enough.
2003 Use SAFE_ALLOCA, not alloca.
2004 Check for overflow when converting EMACS_INT to off_t.
2005 * doprnt.c (doprnt):
2006 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2007 * editfns.c (init_editfns, Fuser_uid, Fuser_real_uid):
2008 Don't assume uid_t fits into fixnum.
2009 (buildmark, Fgoto_char, overlays_around, find_field, Fdelete_field)
2010 (Ffield_string, Ffield_string_no_properties, Ffield_beginning)
2011 (Ffield_end, Fconstrain_to_field, Fline_beginning_position)
2012 (Fline_end_position, Fprevious_char, Fchar_after, Fchar_before)
2013 (general_insert_function)
2014 (Finsert_char, make_buffer_string, make_buffer_string_both)
2015 (update_buffer_properties, Fbuffer_substring)
2016 (Fbuffer_substring_no_properties, Fcompare_buffer_substrings)
2017 (Fsubst_char_in_region, check_translation)
2018 (Ftranslate_region_internal, save_restriction_restore, Fformat)
2019 (transpose_markers, Ftranspose_regions):
2020 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2021 (clip_to_bounds): Move to lisp.h as an inline function).
2022 (Fconstrain_to_field): Don't assume integers are nonnegative.
2023 (Fline_beginning_position, Fsave_excursion, Fsave_current_buffer):
2024 (Fsubst_char_in_region, Fsave_restriction):
2025 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2026 (Femacs_pid): Don't assume pid_t fits into fixnum.
2027 (lo_time): Use int, not EMACS_INT, when int suffices.
2028 (lisp_time_argument): Check for usec out of range.
2029 (Fencode_time): Don't assume fixnum fits in int.
2030 (Fuser_login_name, Fuser_full_name): Signal an error
2031 if a uid argument is out of range, rather than relying on
2033 (Fformat_time_string): Remove now-unnecessary check.
2034 lisp_time_argument checks for out-of-range usec now.
2035 Use ptrdiff_t, not size_t, where ptrdiff_t will do.
2036 * emacs.c (gdb_valbits, gdb_gctypebits): Now int, not EMACS_INT.
2037 (gdb_data_seg_bits): Now uintptr_t, not EMACS_INT.
2038 (PVEC_FLAG, gdb_array_mark_flag): Now ptrdiff_t, not EMACS_INT.
2039 (init_cmdargs, Fdump_emacs):
2040 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2041 (Fkill_emacs): Don't assume fixnum fits in int; instead, take just
2042 the bottom (typically) 32 bits of the fixnum.
2043 * eval.c (specpdl_size, call_debugger):
2044 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2045 (when_entered_debugger, Fbacktrace_debug):
2046 Don't assume fixnum can fit in int.
2047 (Fdefvaralias, Fdefvar): Do not attempt to compute the address of
2048 the object just before a buffer; this is not portable.
2049 (FletX, Flet, Funwind_protect, do_autoload, Feval, funcall_lambda)
2050 (grow_specpdl, unbind_to):
2051 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2052 (Fapply, apply_lambda): Don't assume ptrdiff_t can hold fixnum.
2053 (grow_specpdl): Simplify allocation by using xpalloc.
2054 (Fprog1, Fprog2): Don't assume list length fits in int. Simplify.
2055 * fileio.c (Ffind_file_name_handler, Fcopy_file, Frename_file)
2056 (Finsert_file_contents, Fwrite_region, Fdo_auto_save):
2057 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2058 (Ffind_file_name_handler, non_regular_inserted, Finsert_file_contents)
2060 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2061 (Fcopy_file, non_regular_nbytes, read_non_regular)
2062 (Finsert_file_contents):
2063 Use int, not EMACS_INT, where int is wide enough.
2064 (READ_BUF_SIZE): Verify that it fits in int.
2065 (Finsert_file_contents): Check that counts are in proper range,
2066 rather than assuming fixnums fit into ptrdiff_t etc.
2067 Don't assume fixnums fit into int.
2068 * floatfns.c (Fexpt): Avoid undefined signed * signed overflow.
2069 * fns.c (Fcompare_strings, Fstring_lessp, struct textprop_rec, concat)
2070 (string_char_byte_cache_charpos, string_char_byte_cache_bytepos)
2071 (string_char_to_byte, string_byte_to_char)
2072 (string_make_multibyte, string_to_multibyte)
2073 (string_make_unibyte, Fstring_as_unibyte, Fstring_as_multibyte)
2074 (Fstring_to_unibyte, Fsubstring, Fsubstring_no_properties)
2075 (substring_both, Fdelete, internal_equal, Ffillarray)
2076 (Fclear_string, mapcar1)
2077 (Fbase64_encode_region, Fbase64_encode_string, base64_encode_1)
2078 (Fbase64_decode_region, Fbase64_decode_string, base64_decode_1)
2079 (larger_vector, make_hash_table, maybe_resize_hash_table)
2080 (hash_lookup, hash_remove_from_table, hash_clear, sweep_weak_table)
2081 (Fmaphash, secure_hash):
2082 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2083 (concat): Check for string index and length overflow.
2084 (Fmapconcat): Don't assume fixnums fit into ptrdiff_t.
2086 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2087 (larger_vector): New API (vec, incr_min, size_max) replaces old
2088 one (vec, new_size, init). This catches size overflow.
2089 INIT was removed because it was always Qnil.
2090 All callers changed.
2091 (INDEX_SIZE_BOUND): New macro, which calculates more precisely
2092 the upper bound on a hash table index size.
2093 (make_hash_table, maybe_resize_hash_table): Use it.
2094 (secure_hash): Computer start_byte and end_byte only after
2095 they're known to be in ptrdiff_t range.
2096 * font.c (font_intern_prop, font_at, font_range, Ffont_shape_gstring)
2097 (Ffont_get_glyphs, Ffont_at):
2098 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2099 (font_style_to_value, font_prop_validate_style, font_expand_wildcards)
2100 (Flist_fonts, Fopen_font):
2101 Don't assume fixnum can fit in int.
2102 (check_gstring): Don't assume index can fit in int.
2103 (font_match_p): Check that fixnum is a character, not a nonnegative
2104 fixnum, since the later code needs to stuff it into an int.
2105 (font_find_for_lface): Use SAFE_ALLOCA_LISP, not alloca.
2106 (font_fill_lglyph_metrics): Use unsigned, not EMACS_INT, to avoid
2107 conversion overflow issues.
2108 (Fopen_font): Check for integer out of range.
2109 (Ffont_get_glyphs): Don't assume index can fit in int.
2110 * font.h: Adjust decls to match defn changes elsewhere.
2111 * fontset.c (reorder_font_vector): Redo score calculation to avoid
2113 (num_auto_fontsets, fontset_from_font): Use ptrdiff_t, not
2114 printmax_t, where ptrdiff_t is wide enough.
2115 (Finternal_char_font):
2116 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2117 * frame.c (Fset_mouse_position, Fset_mouse_pixel_position)
2118 (Fset_frame_height, Fset_frame_width, Fset_frame_size)
2119 (Fset_frame_position, x_set_frame_parameters)
2120 (x_set_line_spacing, x_set_border_width)
2121 (x_set_internal_border_width, x_set_alpha, x_figure_window_size):
2122 Check that fixnums are in proper range for system types.
2123 (frame_name_fnn_p, Fframe_parameter, Fmodify_frame_parameters):
2124 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2125 (Fmodify_frame_parameters): Don't assume fixnum fits in int.
2126 Use SAFE_ALLOCA_LISP, not alloca.
2127 * frame.h (struct frame): Use intptr_t, not EMACS_INT, where
2128 intptr_t is wide enough.
2129 * fringe.c (lookup_fringe_bitmap, get_logical_fringe_bitmap)
2130 (Fdefine_fringe_bitmap): Don't assume fixnum fits in int.
2131 (Ffringe_bitmaps_at_pos): Don't assume index fits in int.
2132 Check for fixnum out of range.
2133 * ftfont.c (ftfont_list): Don't assume index fits in int.
2134 Check that fixnums are in proper range for system types.
2135 (ftfont_shape_by_flt):
2136 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2137 * gnutls.c (emacs_gnutls_write, emacs_gnutls_read):
2138 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2139 (Fgnutls_error_fatalp, Fgnutls_error_string, Fgnutls_boot):
2140 Check that fixnums are in proper range for system types.
2141 * gnutls.h: Adjust decls to match defn changes elsewhere.
2142 * gtkutil.c (xg_dialog_run):
2143 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2144 (update_frame_tool_bar):
2145 Check that fixnums are in proper range for system types.
2146 * image.c (parse_image_spec): Redo count calculation to avoid overflow.
2147 (lookup_image): Check that fixnums are in range for system types.
2148 * indent.c (last_known_column, last_known_column_point):
2149 (current_column_bol_cache):
2150 (skip_invisible, current_column, check_display_width):
2151 (check_display_width, scan_for_column, current_column_1)
2152 (Findent_to, Fcurrent_indentation, position_indentation)
2153 (indented_beyond_p, Fmove_to_column, compute_motion):
2154 (Fcompute_motion, Fvertical_motion):
2155 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2156 (last_known_column_modified): Use EMACS_INT, not int.
2157 (check_display_width):
2159 Check that fixnums and floats are in proper range for system types.
2160 (compute_motion): Don't assume index or fixnum fits in int.
2161 (compute_motion, Fcompute_motion):
2162 Use int, not EMACS_INT, when it is wide enough.
2163 (vmotion): Omit local var start_hpos that is always 0; that way
2164 we don't need to worry about overflow in expressions involving it.
2165 * indent.h: Adjust decls to match defn changes elsewhere.
2167 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2168 Use int, not EMACS_INT, where int is wide enough.
2169 Remove unused members ovstring_chars_done and tab_offset;
2171 * insdel.c (move_gap, move_gap_both, gap_left, gap_right)
2172 (adjust_markers_for_delete, adjust_markers_for_insert, adjust_point)
2173 (adjust_markers_for_replace, make_gap_larger, make_gap_smaller)
2174 (make_gap, copy_text, insert, insert_and_inherit)
2175 (insert_before_markers, insert_before_markers_and_inherit)
2176 (insert_1, count_combining_before, count_combining_after)
2177 (insert_1_both, insert_from_string)
2178 (insert_from_string_before_markers, insert_from_string_1)
2179 (insert_from_gap, insert_from_buffer, insert_from_buffer_1)
2180 (adjust_after_replace, adjust_after_insert, replace_range)
2181 (replace_range_2, del_range, del_range_1, del_range_byte)
2182 (del_range_both, del_range_2, modify_region)
2183 (prepare_to_modify_buffer, signal_before_change)
2184 (signal_after_change, Fcombine_after_change_execute):
2185 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2186 * intervals.c (traverse_intervals, rotate_right, rotate_left)
2187 (balance_an_interval, split_interval_right, split_interval_left)
2188 (find_interval, next_interval, update_interval)
2189 (adjust_intervals_for_insertion, delete_node, delete_interval)
2190 (interval_deletion_adjustment, adjust_intervals_for_deletion)
2191 (static_offset_intervals, offset_intervals)
2192 (merge_interval_right, merge_interval_left, make_new_interval)
2193 (graft_intervals_into_buffer, temp_set_point_both)
2194 (temp_set_point, set_point, adjust_for_invis_intang)
2195 (set_point_both, move_if_not_intangible, get_property_and_range)
2196 (get_local_map, copy_intervals, copy_intervals_to_string)
2197 (compare_string_intervals, set_intervals_multibyte_1):
2198 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2199 * intervals.h: Adjust decls to match defn changes elsewhere.
2201 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2202 * keyboard.c (this_command_key_count, this_single_command_key_start)
2203 (before_command_key_count, before_command_echo_length, echo_now)
2204 (echo_length, recursive_edit_1, Frecursive_edit, Ftrack_mouse)
2205 (command_loop_1, safe_run_hooks, read_char, timer_check_2)
2206 (menu_item_eval_property, read_key_sequence, Fread_key_sequence)
2207 (Fread_key_sequence_vector, Fexecute_extended_command, Fsuspend_emacs):
2208 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2209 (last_non_minibuf_size, last_point_position, echo_truncate)
2210 (command_loop_1, adjust_point_for_property, read_char, gen_help_event)
2211 (make_lispy_position, make_lispy_event, parse_modifiers_uncached)
2212 (parse_modifiers, modify_event_symbol, Fexecute_extended_command)
2213 (stuff_buffered_input):
2214 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2215 (last_auto_save, command_loop_1, read_char):
2216 Use EMACS_INT, not int, to avoid integer overflow.
2217 (record_char): Avoid overflow in total_keys computation.
2218 (parse_modifiers_uncached): Redo index calculation to avoid overflow.
2219 * keyboard.h: Adjust decls to match defn changes elsewhere.
2220 * keymap.c (Fdefine_key, Fcurrent_active_maps, accessible_keymaps_1)
2221 (Fkey_description, Fdescribe_vector, Flookup_key):
2222 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2223 (click_position): New function, to check that positions are in range.
2224 (Fcurrent_active_maps):
2226 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2227 (Faccessible_keymaps, Fkey_description):
2228 (preferred_sequence_p):
2229 Don't assume fixnum can fit into int.
2230 (Fkey_description): Use SAFE_ALLOCA_LISP, not alloca.
2231 Check for integer overflow in size calculations.
2232 (Ftext_char_description): Use CHECK_CHARACTER, not CHECK_NUMBER, to
2233 avoid mishandling large integers.
2234 * lisp.h: Adjust decls to match defn changes elsewhere.
2235 (ARRAY_MARK_FLAG, PSEUDOVECTOR_FLAG, struct Lisp_String)
2236 (struct vectorlike_header, struct Lisp_Subr, struct Lisp_Hash_Table)
2237 (struct Lisp_Marker):
2238 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2239 (clip_to_bounds): Now an inline function, moved here from editfns.c.
2240 (GLYPH_CODE_P): Check for overflow in system types, subsuming the
2241 need for GLYPH_CODE_CHAR_VALID_P and doing proper checking ourselves.
2242 All callers changed.
2243 (GLYPH_CODE_CHAR, GLYPH_CODE_FACE):
2244 Assume the arg has valid form, since it always does.
2245 (TYPE_RANGED_INTEGERP): Avoid bug when checking against a wide
2246 unsigned integer system type.
2247 (CHECK_RANGED_INTEGER, CHECK_TYPE_RANGED_INTEGER): New macros.
2248 (struct catchtag, specpdl_size, SPECPDL_INDEX, USE_SAFE_ALLOCA):
2249 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2250 (struct catchtag): Use EMACS_INT, not int, since it may be a fixnum.
2251 (duration_to_sec_usec): New decl.
2252 * lread.c (read_from_string_index, read_from_string_index_byte)
2253 (read_from_string_limit, readchar, unreadchar, openp)
2254 (read_internal_start, read1, oblookup):
2255 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2256 (Fload, readevalloop, Feval_buffer, Feval_region):
2257 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2258 (openp): Check for out-of-range argument to 'access'.
2259 (read1): Use int, not EMACS_INT, where int is wide enough.
2260 Don't assume fixnum fits into int.
2261 Fix off-by-one error that can read outside a buffer.
2262 (read_filtered_event): Use duration_to_sec_usec
2263 to do proper overflow checking on durations.
2264 * macros.c (Fstart_kbd_macro): Use xpalloc to check for overflow
2265 in size calculation.
2266 (Fexecute_kbd_macro):
2267 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2268 * marker.c (cached_charpos, cached_bytepos, CONSIDER)
2269 (byte_char_debug_check, buf_charpos_to_bytepos, verify_bytepos)
2270 (buf_bytepos_to_charpos, Fset_marker, set_marker_restricted)
2271 (set_marker_both, set_marker_restricted_both, marker_position)
2272 (marker_byte_position, Fbuffer_has_markers_at):
2273 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2274 (Fset_marker, set_marker_restricted): Don't assume fixnum fits in int.
2275 * menu.c (ensure_menu_items): Rename from grow_menu_items.
2276 It now merely ensures that the menu is large enough, without
2277 necessarily growing it, as this avoids some integer overflow issues.
2278 All callers changed.
2279 (keymap_panes, parse_single_submenu, Fx_popup_menu):
2280 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2281 (parse_single_submenu, Fx_popup_menu): Don't assume fixnum fits in int.
2282 Use SAFE_ALLOCA_LISP, not alloca.
2283 (find_and_return_menu_selection): Avoid unnecessary casts of pointers
2284 to EMACS_INT. Check that fixnums are in proper range for system types.
2285 * minibuf.c (minibuf_prompt_width, string_to_object)
2286 (Fminibuffer_contents, Fminibuffer_contents_no_properties)
2287 (Fminibuffer_completion_contents, Ftry_completion, Fall_completions):
2288 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2289 (get_minibuffer, read_minibuf_unwind):
2290 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2291 (read_minibuf): Omit unnecessary arg BACKUP_N, which is always nil;
2292 this simplifies overflow checking. All callers changed.
2293 (read_minibuf, Fread_buffer, Ftry_completion, Fall_completions)
2295 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2296 * nsfns.m (check_ns_display_info): Don't assume fixnum fits in long.
2297 (x_set_menu_bar_lines, x_set_tool_bar_lines, Fx_create_frame):
2298 Check that fixnums are in proper range for system types.
2299 (Fx_create_frame, Fx_show_tip):
2300 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2301 * nsfont.m (ns_findfonts, nsfont_list_family):
2302 Don't assume fixnum fits in long.
2303 * nsmenu.m (ns_update_menubar, ns_menu_show, ns_popup_dialog):
2304 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2305 (ns_update_menubar): Use intptr_t, not EMACS_INT, when intptr_t is
2307 * nsselect.m (ns_get_local_selection, clean_local_selection_data):
2308 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2309 * print.c (print_buffer_size, print_buffer_pos, print_buffer_pos_byte)
2310 (PRINTDECLARE, PRINTPREPARE):
2311 (strout, print_string):
2312 (print, print_preprocess, print_check_string_charset_prop)
2314 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2316 (temp_output_buffer_setup, Fprin1_to_string, print_object):
2317 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2318 (PRINTPREPARE): Use int, not ptrdiff_t, where int is wide enough.
2319 (printchar, strout): Use xpalloc to catch size calculation overflow.
2320 (Fexternal_debugging_output): Don't overflow EMACS_INT->int conversion.
2321 (print_error_message): Use SAFE_ALLOCA, not alloca.
2322 (print_object): Use int, not EMACS_INT, where int is wide enough.
2323 (print_depth, new_backquote_output, print_number_index):
2324 Use ptrdiff_t, not int, where int might not be wide enough.
2325 * process.c (Fdelete_process): Don't assume pid fits into EMACS_INT.
2326 (Fset_process_window_size, Fformat_network_address)
2327 (get_lisp_to_sockaddr_size, set_socket_option, Fmake_network_process)
2329 Check that fixnums are in proper range for system types.
2330 (Fsignal_process): Simplify by avoiding a goto.
2331 Check for process-ids out of pid_t range rather than relying on
2333 (process_tick, update_tick): Use EMACS_INT, not int.
2334 (Fformat_network_address, read_process_output, send_process)
2335 (Fprocess_send_region, status_notify):
2336 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2337 (Fformat_network_address, Fmake_serial_process, Fmake_network_process)
2338 (wait_reading_process_output, read_process_output, exec_sentinel):
2339 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2340 (conv_lisp_to_sockaddr): Don't assume fixnums fit into int.
2341 (Faccept_process_output): Use duration_to_sec_usec to do proper
2342 overflow checking on durations.
2343 (emacs_get_tty_pgrp, Fprocess_running_child_p, process_send_signal):
2344 Don't assume pid_t fits in int.
2345 * process.h (struct Lisp_Process): Members tick and update_tick
2346 are now of type EMACS_INT, not int.
2347 * puresize.h (PURESIZE_RATIO): Shrink this to 8/6 on 32-bit hosts
2348 configured --with-wide-int.
2349 * scroll.c (calculate_scrolling, calculate_direct_scrolling)
2350 (line_ins_del): Use int, not EMACS_INT, where int is wide enough.
2351 * search.c (looking_at_1, string_match_1):
2352 (fast_string_match, fast_c_string_match_ignore_case)
2353 (fast_string_match_ignore_case, fast_looking_at, scan_buffer)
2354 (scan_newline, find_before_next_newline, search_command)
2355 (trivial_regexp_p, search_buffer, simple_search, boyer_moore)
2356 (set_search_regs, wordify):
2359 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2360 (string_match_1, search_buffer, set_search_regs):
2362 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2363 (wordify): Check for overflow in size calculation.
2364 (Freplace_match): Avoid potential buffer overflow in search_regs.start.
2365 (Fset_match_data): Don't assume fixnum fits in ptrdiff_t.
2366 Check that fixnums are in proper range for system types.
2367 * sound.c (struct sound_device)
2368 (wav_play, au_play, vox_write, alsa_period_size, alsa_write):
2369 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2370 (Fplay_sound_internal):
2371 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2372 * syntax.c (struct lisp_parse_state, find_start_modiff)
2373 (Finternal_describe_syntax_value, scan_lists, scan_sexps_forward):
2374 (Fparse_partial_sexp):
2375 Don't assume fixnums can fit in int.
2376 (struct lisp_parse_state, find_start_pos, find_start_value)
2377 (find_start_value_byte, find_start_begv)
2378 (update_syntax_table, char_quoted, dec_bytepos)
2379 (find_defun_start, prev_char_comend_first, back_comment):
2380 (scan_words, skip_chars, skip_syntaxes, forw_comment, Fforward_comment)
2381 (scan_lists, Fbackward_prefix_chars, scan_sexps_forward):
2382 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2383 (Finternal_describe_syntax_value): Check that match_lisp is a
2384 character, not an integer, since the code stuffs it into int.
2385 (scan_words, scan_sexps_forward):
2386 Check that fixnums are in proper range for system types.
2388 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2389 (scan_sexps_forward):
2390 Use CHARACTERP, not INTEGERP, since the value must fit into int.
2391 (Fparse_partial_sexp): Fix doc; element 8 is not ignored.
2392 * syntax.h: Adjust decls to match defn changes elsewhere.
2393 (struct gl_state_s):
2394 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2395 (SETUP_SYNTAX_TABLE_FOR_OBJECT): Use PTRDIFF_MAX, not
2396 MOST_POSITIVE_FIXNUM.
2397 * sysdep.c (wait_for_termination_1, wait_for_termination)
2398 (interruptible_wait_for_termination, mkdir):
2399 Don't assume pid_t fits in int; on 64-bit AIX pid_t is 64-bit.
2400 (emacs_read, emacs_write):
2401 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2402 (system_process_attributes): Don't assume uid_t, gid_t, EMACS_INT,
2403 and double all fit in int.
2404 * term.c (set_tty_color_mode):
2405 Check that fixnums are in proper range for system types.
2406 * termhooks.h (struct input_event):
2407 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2408 * textprop.c (validate_interval_range, interval_of)
2409 (Fadd_text_properties, set_text_properties_1)
2410 (Fremove_text_properties, Fremove_list_of_text_properties)
2411 (Ftext_property_any, Ftext_property_not_all)
2412 (copy_text_properties, text_property_list, extend_property_ranges)
2413 (verify_interval_modification):
2414 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2415 (Fnext_single_char_property_change)
2416 (Fprevious_single_char_property_change):
2417 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2418 (copy_text_properties):
2419 Check for integer overflow in index calculation.
2420 * undo.c (last_boundary_position, record_point, record_insert)
2421 (record_delete, record_marker_adjustment, record_change)
2422 (record_property_change):
2423 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2424 (truncate_undo_list, Fprimitive_undo): Don't assume fixnum fits in int.
2425 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2426 * w32fns.c (Fx_create_frame, x_create_tip_frame, Fx_show_tip)
2427 (Fx_hide_tip, Fx_file_dialog):
2428 * w32menu.c (set_frame_menubar):
2429 Use ptrdiff_t, not int, for consistency with rest of code.
2430 * window.c (window_scroll_preserve_hpos, window_scroll_preserve_vpos)
2431 (select_window, Fdelete_other_windows_internal)
2432 (window_scroll_pixel_based, window_scroll_line_based)
2433 (Frecenter, Fset_window_configuration):
2434 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2435 (Fset_window_hscroll, run_window_configuration_change_hook)
2436 (set_window_buffer, temp_output_buffer_show, scroll_command)
2437 (Fscroll_other_window, Frecenter):
2438 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2439 (Fwindow_line_height, window_scroll, Fscroll_left, Fscroll_right):
2440 Don't assume fixnum fits in int.
2441 (Fset_window_scroll_bars):
2442 Check that fixnums are in proper range for system types.
2443 * xdisp.c (help_echo_pos, pos_visible_p, string_pos_nchars_ahead)
2444 (string_pos, c_string_pos, number_of_chars, init_iterator)
2445 (in_ellipses_for_invisible_text_p, init_from_display_pos)
2446 (compute_stop_pos, next_overlay_change, compute_display_string_pos)
2447 (compute_display_string_end, handle_face_prop)
2448 (face_before_or_after_it_pos, handle_invisible_prop)
2449 (handle_display_prop, handle_display_spec, handle_single_display_spec)
2450 (display_prop_intangible_p, string_buffer_position_lim)
2451 (string_buffer_position, handle_composition_prop, load_overlay_strings)
2452 (get_overlay_strings_1, get_overlay_strings)
2453 (iterate_out_of_display_property, forward_to_next_line_start)
2454 (back_to_previous_visible_line_start, reseat, reseat_to_string)
2455 (get_next_display_element, set_iterator_to_next)
2456 (get_visually_first_element, compute_stop_pos_backwards)
2457 (handle_stop_backwards, next_element_from_buffer)
2458 (move_it_in_display_line_to, move_it_in_display_line)
2459 (move_it_to, move_it_vertically_backward, move_it_by_lines)
2460 (add_to_log, message_dolog, message_log_check_duplicate)
2461 (message2, message2_nolog, message3, message3_nolog
2462 (with_echo_area_buffer, display_echo_area_1, resize_mini_window_1)
2463 (current_message_1, truncate_echo_area, truncate_message_1)
2464 (set_message, set_message_1, store_mode_line_noprop)
2465 (hscroll_window_tree, debug_delta, debug_delta_bytes, debug_end_vpos)
2466 (text_outside_line_unchanged_p, check_point_in_composition)
2467 (reconsider_clip_changes)
2468 (redisplay_internal, set_cursor_from_row, try_scrolling)
2469 (try_cursor_movement, set_vertical_scroll_bar, redisplay_window)
2470 (redisplay_window, find_last_unchanged_at_beg_row)
2471 (find_first_unchanged_at_end_row, row_containing_pos, try_window_id)
2472 (trailing_whitespace_p, find_row_edges, display_line)
2473 (RECORD_MAX_MIN_POS, Fcurrent_bidi_paragraph_direction)
2474 (display_mode_element, store_mode_line_string)
2475 (pint2str, pint2hrstr, decode_mode_spec)
2476 (display_count_lines, display_string, draw_glyphs)
2477 (x_produce_glyphs, x_insert_glyphs)
2478 (rows_from_pos_range, mouse_face_from_buffer_pos)
2479 (fast_find_string_pos, mouse_face_from_string_pos)
2480 (note_mode_line_or_margin_highlight, note_mouse_highlight):
2481 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2482 (safe_call, init_from_display_pos, handle_fontified_prop)
2483 (handle_single_display_spec, load_overlay_strings)
2484 (with_echo_area_buffer, setup_echo_area_for_printing)
2485 (display_echo_area, echo_area_display)
2486 (x_consider_frame_title, prepare_menu_bars, update_menu_bar)
2487 (update_tool_bar, hscroll_window_tree, redisplay_internal)
2488 (redisplay_window, dump_glyph_row, display_mode_line)
2489 (Fformat_mode_line, decode_mode_spec, on_hot_spot_p):
2490 (handle_display_spec, display_prop_string_p):
2491 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2492 (handle_single_display_spec, build_desired_tool_bar_string)
2493 (redisplay_tool_bar, scroll_window_tree, Fdump_glyph_matrix)
2494 (get_specified_cursor_type):
2495 Check that fixnums are in proper range for system types.
2496 (struct overlay_entry, resize_mini_window, Fdump_glyph_row)
2497 (Flookup_image_map):
2498 Don't assume fixnums fit in int.
2499 (compare_overlay_entries):
2500 Avoid mishandling comparisons due to subtraction overflow.
2501 (load_overlay_strings): Use SAFE_NALLOCA, not alloca.
2502 (last_escape_glyph_face_id, last_glyphless_glyph_face_id):
2503 (handle_tool_bar_click):
2504 Use int, not unsigned, since we prefer signed and the signedness
2505 doesn't matter here.
2506 (get_next_display_element, next_element_from_display_vector):
2507 Use int, not EMACS_INT, when int is wide enough.
2508 (start_hourglass): Use duration_to_sec_usec to do proper
2509 overflow checking on durations.
2510 * xfaces.c (Fbitmap_spec_p):
2511 Check that fixnums are in proper range for system types.
2512 (compare_fonts_by_sort_order):
2513 Avoid mishandling comparisons due to subtraction overflow.
2514 (Fx_family_fonts, realize_basic_faces):
2515 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2517 Don't assume fixnum fits in int.
2518 Use SAFE_ALLOCA_LISP, not alloca.
2519 (merge_face_heights): Remove unnecessary cast to EMACS_INT.
2520 (Finternal_make_lisp_face): Don't allocate more than MAX_FACE_ID.
2521 (face_at_buffer_position, face_for_overlay_string)
2522 (face_at_string_position):
2523 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2524 (merge_faces): Use int, not EMACS_INT, where int is wide enough.
2525 * xfns.c (x_set_menu_bar_lines, x_set_tool_bar_lines, x_icon_verify)
2527 Check that fixnums are in proper range for system types.
2528 (Fx_create_frame, x_create_tip_frame, Fx_show_tip)
2529 (Fx_hide_tip, Fx_file_dialog, Fx_select_font):
2530 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2531 (Fx_change_window_property): Don't assume fixnums fit in int.
2532 * xfont.c (xfont_chars_supported):
2533 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2534 * xmenu.c (Fx_popup_dialog, set_frame_menubar)
2535 (create_and_show_popup_menu, create_and_show_dialog, xmenu_show):
2536 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2537 * xml.c (parse_region):
2538 * xrdb.c (magic_file_p):
2539 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2540 * xselect.c (TRACE1): Don't assume pid_t promotes to int.
2541 (x_get_local_selection, x_reply_selection_request)
2542 (x_handle_selection_request, wait_for_property_change):
2543 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2544 (selection_data_to_lisp_data): Use short, not EMACS_INT, where
2545 short is wide enough.
2546 (x_send_client_event): Don't assume fixnum fits in int.
2547 * xterm.c (x_x_to_emacs_modifiers):
2548 Don't assume EMACS_INT overflows nicely into int.
2549 (x_emacs_to_x_modifiers): Use EMACS_INT, not int, because values
2551 (handle_one_xevent): NATNUMP can eval its arg twice.
2552 (x_connection_closed):
2553 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2554 * xterm.h: Adjust decls to match defn changes elsewhere.
2555 (struct scroll_bar): Use struct vectorlike_header
2556 rather than rolling our own approximation.
2557 (SCROLL_BAR_VEC_SIZE): Remove; not used.
2559 2012-05-25 Glenn Morris <rgm@gnu.org>
2561 * lisp.mk (lisp): Update for more files being compiled now.
2563 2012-05-25 Stefan Monnier <monnier@iro.umontreal.ca>
2565 * lread.c: Remove `read_pure' which makes no difference.
2566 (read_pure): Remove var.
2567 (unreadpure): Remove function.
2568 (readevalloop): Don't call read_list with -1 flag.
2569 (read1, read_vector): Don't test read_pure any more.
2570 (read_list): Simplify.
2572 * fileio.c, character.h: Minor style tweaks.
2574 2012-05-24 Dmitry Antipov <dmantipov@yandex.ru>
2576 * window.h (clip_changed): Remove useless declaration.
2578 2012-05-22 Juanma Barranquero <lekktu@gmail.com>
2580 * makefile.w32-in: Follow-up to 2012-05-22T16:20:27Z!eggert@cs.ucla.edu.
2581 (TAGS, TAGS-gmake, CONFIG_H): Remove further references to m/intel386.h.
2583 2012-05-22 Paul Eggert <eggert@cs.ucla.edu>
2586 This directory predates autoconf and is no longer needed nowadays.
2587 Move its few remaining bits of functionality to where they're needed.
2588 * m/README, m/alpha.h, m/amdx86-64.h, m/ia64.h, m/ibmrs6000.h:
2589 * m/ibms390x.h, m/intel386.h, m/m68k.h, m/macppc.h, m/sparc.h:
2590 * m/template.h: Remove.
2591 * Makefile.in (M_FILE): Remove. All uses removed.
2592 * alloc.c (POINTERS_MIGHT_HIDE_IN_OBJECTS):
2593 * lisp.h (USE_LSB_TAG):
2594 * mem-limits.h (EXCEEDS_LISP_PTR):
2595 Use VAL_MAX, not VALBITS, in #if.
2596 * lisp.h (EMACS_INT_MAX): New macro, useful in #if.
2597 (EMACS_UINT): Define unconditionally now.
2598 (BITS_PER_CHAR, BITS_PER_SHORT, BITS_PER_INT, BITS_PER_LONG)
2599 (BITS_PER_EMACS_INT): New constants, replacing
2600 what used to be in config.h, but not useful in #if.
2601 (GCTYPEBITS, VALBITS): Define unconditionally, since m/* files don't
2602 define them any more.
2603 (VAL_MAX): New macro.
2605 * puresize.h (PURESIZE_RATIO): Use EMACS_INT_MAX, not
2606 BITS_PER_EMACS_INT, in #if.
2607 * s/aix4-2.h (BROKEN_FIONREAD, BROKEN_SIGAIO, BROKEN_SIGPTY)
2608 (BROKEN_SIGPOLL): Move here from m/ibmrs6000.h, which was removed.
2609 * s/gnu-linux.h (ULIMIT_BREAK_VALUE) [__i386__]:
2610 * s/ms-w32.h (DATA_START):
2611 Move here from removed file m/intel386.h.
2612 * s/gnu.h (NLIST_STRUCT): Remove undef; 'configure' does this.
2613 * s/irix6-5.h (_LP64): Remove; lisp.h no longer needs this.
2615 2012-05-21 Paul Eggert <eggert@cs.ucla.edu>
2617 Assume C89 or later.
2618 * alloc.c, buffer.c, lisp.h: Replace POINTER_TYPE with void.
2619 * alloc.c (overrun_check_malloc, overrun_check_realloc, xmalloc)
2621 * buffer.c (mmap_free_1, mmap_enlarge): Omit needless casts.
2622 * editfns.c, fns.c, gmalloc.c, insdel.c, sysdep.c, termcap.c (NULL):
2623 * textprop.c, tparam.c (NULL): Remove.
2624 * ralloc.c, vm-limit.c (POINTER): Assume void * works.
2625 * regex.c (SIGN_EXTEND_CHAR): Assume signed char works.
2626 * regex.h (_RE_ARGS): Remove. All uses rewritten to use prototypes.
2627 * unexelf.c (ElfBitsW): Assume c89 preprocessor or better.
2628 * xterm.c (input_signal_count): Assume volatile works.
2630 2012-05-21 Ken Brown <kbrown@cornell.edu>
2632 * xgselect.c (xg_select): Fix first argument in call to 'select'
2635 2012-05-20 Ken Brown <kbrown@cornell.edu>
2637 * gmalloc.c (_free_internal_nolock, _realloc_internal_nolock)
2638 [CYGWIN]: Cast ptr to (char *) before comparing to _heapbase.
2640 2012-05-19 Ken Brown <kbrown@cornell.edu>
2642 * xfns.c (x_in_use): Remove `static' qualifier.
2643 * xterm.h (x_in_use): Declare.
2644 * xgselect.c: Include xterm.h.
2645 (xg_select): Test `x_in_use' instead of `inhibit_window_system'
2646 and `display_arg' (bug#9754).
2648 2012-05-19 Paul Eggert <eggert@cs.ucla.edu>
2650 * s/ms-w32.h (HAVE_GETDOMAINNAME): Remove; not needed.
2652 * m/vax.h: Remove; no longer needed since HAVE_FTIME is being removed.
2653 * s/ms-w32.h (HAVE_FTIME): Remove; not needed.
2655 2012-05-18 Eli Zaretskii <eliz@gnu.org>
2657 Fix compilation with -DGLYPH_DEBUG=1 on MS-Windows.
2659 * w32term.c [GLYPH_DEBUG]: Add prototype for x_check_font.
2660 (x_check_font) [GLYPH_DEBUG]: New function, copied from xterm.c
2662 * w32fns.c (unwind_create_frame) [GLYPH_DEBUG]: Fix broken
2663 reference to image_cache->refcount.
2664 (x_create_tip_frame): Fix broken use of FRAME_IMAGE_CACHE.
2666 2012-05-17 Juri Linkov <juri@jurta.org>
2668 * search.c (Fword_search_regexp, Fword_search_backward)
2669 (Fword_search_forward, Fword_search_backward_lax)
2670 (Fword_search_forward_lax): Move functions to isearch.el
2671 (bug#10145, bug#11381).
2673 2012-05-16 Paul Eggert <eggert@cs.ucla.edu>
2675 * xgselect.c (xg_select): Just invoke 'select' if -nw (Bug#9754).
2677 2012-05-15 Stefan Monnier <monnier@iro.umontreal.ca>
2679 * lread.c (init_obarray): Declare Qt and Qnil as special.
2681 2012-05-14 Glenn Morris <rgm@gnu.org>
2683 * nsterm.m (ns_init_paths): Fix typo ("libexec" not "lib-exec").
2684 Put "libexec" before "bin", for the sake of init_callproc_1.
2686 2012-05-14 Paul Eggert <eggert@cs.ucla.edu>
2688 * keyboard.c (kbd_buffer_get_event) [!HAVE_DBUS]: Omit unused local.
2690 * unexaix.c: Port to more-recent AIX compilers.
2691 (report_error, report_error_1, make_hdr, copy_sym)
2692 (mark_x, adjust_lnnoptrs, unrelocate_symbols):
2693 Make arguments const char *, not char *, to avoid violations of C
2694 standard and to fix some AIX warnings reported by Gilles Pion.
2696 2012-05-14 Eli Zaretskii <eliz@gnu.org>
2698 * xdisp.c (handle_stop): Don't call get_overlay_strings_1 if we
2699 already have overlays loaded.
2700 (handle_single_display_spec): Before returning without displaying
2701 fringe bitmap, synchronize the bidi iterator with the main display
2702 iterator, by calling iterate_out_of_display_property.
2703 (iterate_out_of_display_property): Detect buffer iteration by
2704 testing that it->string is a Lisp string.
2705 (get_next_display_element): When the current object is exhausted,
2706 and there's something on it->stack, call set_iterator_to_next to
2707 proceed with what's on the stack, instead of returning zero.
2708 (set_iterator_to_next): If called at the end of a Lisp string,
2709 proceed to consider_string_end without incrementing string
2710 position. Don't increment display vector index past the end of
2711 the display vector. (Bug#11417)
2712 (pos_visible_p): Don't report a position visible when move_it_to
2713 stopped at the last line of window, which happens to be scanned
2714 backwards by the bidi iteration. (Bug#11464)
2716 2012-05-14 Eli Zaretskii <eliz@gnu.org>
2718 * xdisp.c (handle_single_display_spec): Return 1 for left-margin
2719 and right-margin display specs even if the spec is invalid or we
2720 are on a TTY, and thus unable to display on the fringes.
2721 That's because the text with the property will not be displayed anyway,
2722 so we need to signal to the caller that this is a "replacing"
2723 display spec. This fixes display when the spec is invalid or we
2726 2012-05-14 Paul Eggert <eggert@cs.ucla.edu>
2728 * unexaix.c (make_hdr): Fix typo in prototype.
2729 This bug broke the build on AIX. Problem reported by Gilles Pion.
2731 2012-05-14 Michael Albinus <michael.albinus@gmx.de>
2733 * keyboard.c (kbd_buffer_get_event): Read special events also in
2734 batch mode. (Bug#11415)
2736 2012-05-12 Glenn Morris <rgm@gnu.org>
2738 * ns.mk: Update for ns_appbindir no longer having trailing "/".
2740 2012-05-12 Eli Zaretskii <eliz@gnu.org>
2742 * lisp.mk (lisp): Add newcomment.elc.
2744 2012-05-12 Glenn Morris <rgm@gnu.org>
2746 * Makefile.in (MKDIR_P): New, set by configure.
2747 * ns.mk (${ns_appdir}, ${ns_appbindir}Emacs): Use $MKDIR_P.
2749 2012-05-11 Paul Eggert <eggert@cs.ucla.edu>
2751 Remove unused function hourglass_started.
2752 * dispextern.h (hourglass_started):
2753 * w32fns.c (hourglass_started):
2754 * xdisp.c (hourglass_started): Remove.
2756 2012-05-10 Juanma Barranquero <lekktu@gmail.com>
2758 * makefile.w32-in ($(BLD)/gmalloc.$(O), $(BLD)/w32menu.$(O)):
2759 Update dependencies.
2761 2012-05-10 Paul Eggert <eggert@cs.ucla.edu>
2763 * xgselect.c (xg_select): Put maxfds+1 into a var.
2764 This is slightly clearer, and pacifies Ubuntu 12.04 gcc.
2766 * sound.c (DEFAULT_ALSA_SOUND_DEVICE): Define only if HAVE_ALSA.
2768 2012-05-10 Dave Abrahams <dave@boostpro.com>
2770 * filelock.c (syms_of_filelock): New boolean create-lockfiles.
2771 (lock_file): If create_lockfiles is 0, do nothing. (Bug#11227)
2773 2012-05-09 Michael Albinus <michael.albinus@gmx.de>
2775 * dbusbind.c (xd_registered_buses): New internal Lisp object.
2776 Rename all occurences of Vdbus_registered_buses to xd_registered_buses.
2777 (syms_of_dbusbind): Remove declaration of Vdbus_registered_buses.
2778 Initialize xd_registered_buses.
2780 2012-05-09 Paul Eggert <eggert@cs.ucla.edu>
2782 Untag more efficiently if USE_LSB_TAG.
2783 This is based on a proposal by YAMAMOTO Mitsuharu in
2784 <http://lists.gnu.org/archive/html/emacs-devel/2008-01/msg01876.html>.
2785 For an admittedly artificial (nth 8000 longlist) benchmark on
2786 Fedora 15 x86-64, this yields a 25% CPU speedup. Also, it shrinks
2787 Emacs's overall text size by 1%.
2788 * lisp.h (XUNTAG): New macro.
2789 (XCONS, XVECTOR, XSTRING, XSYMBOL, XFLOAT, XMISC, XPROCESS, XWINDOW)
2790 (XTERMINAL, XSUBR, XBUFFER, XCHAR_TABLE, XSUB_CHAR_TABLE, XBOOL_VECTOR)
2791 (XSETTYPED_PSEUDOVECTOR, XHASH_TABLE, TYPED_PSEUDOVECTORP): Use it.
2792 * eval.c (Fautoload):
2793 * font.h (XFONT_SPEC, XFONT_ENTITY, XFONT_OBJECT):
2794 * frame.h (XFRAME): Use XUNTAG.
2796 Port recent dbusbind.c changes to 32-bit --with-wide-int.
2797 * dbusbind.c (xd_append_arg, xd_retrieve_arg, Fdbus_message_internal):
2798 Remove unportable assumptions about print widths of types like
2800 (xd_get_connection_address, Fdbus_init_bus): Cast Emacs integer to
2801 intptr_t when converting between pointer and integer, to avoid GCC
2802 warnings about wrong width.
2804 2012-05-09 Eli Zaretskii <eliz@gnu.org>
2806 * w32proc.c (new_child): Force Windows to reserve only 64KB of
2807 stack for each reader_thread, instead of defaulting to 8MB
2808 determined by the linker. This avoids failures in creating
2809 subprocesses on Windows 7, see the discussion in this thread:
2810 http://lists.gnu.org/archive/html/emacs-devel/2012-03/msg00119.html.
2812 2012-05-07 Jérémy Compostella <jeremy.compostella@gmail.com>
2814 Fix up display of the *Minibuf-0* buffer in the mini window.
2815 * keyboard.c (read_char): Don't clear the echo area if there's no
2817 * xdisp.c (redisplay_internal): Redisplay the mini window (with the
2818 contents of *Minibuf-0*) if there's no message displayed in its stead.
2820 2012-05-07 Michael Albinus <michael.albinus@gmx.de>
2822 * dbusbind.c (XD_DEBUG_MESSAGE): Don't print message twice in
2825 2012-05-06 Chong Yidong <cyd@gnu.org>
2827 * lisp.mk (lisp): Update.
2829 2012-05-05 Jim Meyering <meyering@redhat.com>
2831 * w32font.c (fill_in_logfont): NUL-terminate a string (Bug#11372).
2833 2012-05-04 Stefan Monnier <monnier@iro.umontreal.ca>
2835 * data.c (PUT_ERROR): New macro.
2836 (syms_of_data): Use it. Add new error type `user-error'.
2837 * undo.c (user_error): New function.
2838 (Fprimitive_undo): Use it.
2839 * print.c (print_error_message): Adjust print style for `user-error'.
2840 * keyboard.c (user_error): New function.
2841 (Fexit_recursive_edit, Fabort_recursive_edit): Use it.
2843 2012-05-03 Paul Eggert <eggert@cs.ucla.edu>
2845 Do not limit current-time-string to years 1000..9999.
2846 * editfns.c (TM_YEAR_IN_ASCTIME_RANGE): Remove.
2847 (Fcurrent_time_string): Support any year that is supported by the
2848 underlying localtime representation. Don't use asctime, as it
2849 has undefined behavior for years outside the range -999..9999.
2851 2012-05-02 Paul Eggert <eggert@cs.ucla.edu>
2853 Fix race conditions involving setenv, gmtime, localtime, asctime.
2854 Without this fix, interrupts could mess up code that uses these
2855 nonreentrant functions, since setting TZ invalidates existing
2856 tm_zone or tzname values, and since most of these functions return
2857 pointers to static storage.
2858 * editfns.c (format_time_string, Fdecode_time, Fencode_time)
2859 (Fcurrent_time_string, Fcurrent_time_zone, Fset_time_zone_rule):
2860 Grow the critical sections to include not just invoking
2861 localtime/gmtime, but also accessing these functions' results
2862 including their tm_zone values if any, and any related TZ setting.
2863 (format_time_string): Last arg is now struct tm *, not struct tm **,
2864 so that the struct tm is saved in the critical section.
2865 All callers changed. Simplify allocation of initial buffer, partly
2866 motivated by the fact that memory allocation needs to be outside
2867 the critical section.
2869 2012-05-02 Dmitry Antipov <dmantipov@yandex.ru>
2871 * intervals.c (adjust_intervals_for_insertion): Initialize `newi'
2872 with RESET_INTERVAL.
2874 * buffer.c (Fget_buffer_create, Fmake_indirect_buffer):
2875 Remove duplicated buffer name initialization.
2877 2012-05-02 Jim Meyering <jim@meyering.net>
2879 * xterm.c (x_term_init): Use memcpy instead of strncpy (Bug#11373).
2881 * xfns.c (x_window): Use xstrdup (Bug#11375).
2883 2012-05-02 Eli Zaretskii <eliz@gnu.org>
2885 * xdisp.c (pos_visible_p): If already at a newline from the
2886 display string before the 'while' loop, don't walk back the glyphs
2887 from it3.glyph_row. Solves assertion violation when the display
2888 string begins with a newline (egg.el). (Bug#11367)
2890 2012-05-01 Stefan Monnier <monnier@iro.umontreal.ca>
2892 * keyboard.c (Fexecute_extended_command, Vsuggest_key_bindings):
2895 2012-05-01 Glenn Morris <rgm@gnu.org>
2897 * syssignal.h: Remove reference to BROKEN_SIGINFO (last used in
2898 s/ptx4.h), BROKEN_SIGTSTP (last used in m/ustation.h, m/dpx2.h),
2899 and BROKEN_SIGURG (was in s/gnu-linux.h prior to 2008-02-10).
2900 All were removed before 23.1.
2902 * dispnew.c: Remove HAVE_LIBNCURSES test;
2903 it is always true on relevant platforms.
2905 * Makefile.in (LD_SWITCH_X_SITE_RPATH):
2906 Rename from LD_SWITCH_X_SITE_AUX_RPATH.
2908 * Makefile.in (LD_SWITCH_X_SITE_AUX): Remove; no longer used.
2910 2012-04-30 Andreas Schwab <schwab@linux-m68k.org>
2912 * .gdbinit (xpr): Remove checks for no longer existing misc types.
2913 (xintfwd, xboolfwd, xobjfwd, xbufobjfwd, xkbobjfwd, xbuflocal):
2916 2012-04-28 Paul Eggert <eggert@cs.ucla.edu>
2918 Do not avoid creating empty evaporating overlays (Bug#9642).
2919 * buffer.c (Fmove_overlay): Revert the change of 2012-04-23.
2920 That is, do not delete an evaporating overlay if it becomes
2921 empty after its bounds are adjusted to fit within its buffer.
2922 This fix caused other problems, and I'm reverting it until we get
2923 to the bottom of them.
2925 2012-04-27 Chong Yidong <cyd@gnu.org>
2927 * xselect.c (x_convert_selection): Initialize a pointer (Bug#11315).
2929 2012-04-27 Eli Zaretskii <eliz@gnu.org>
2931 * xdisp.c (pos_visible_p): If the window start position is beyond
2932 ZV, start the display from buffer beginning. Prevents assertion
2933 violation in init_iterator when the minibuffer window is scrolled
2936 * window.c (window_scroll_pixel_based): Likewise.
2938 2012-04-27 Chong Yidong <cyd@gnu.org>
2940 * keymap.c (where_is_internal): Doc fix (Bug#10872).
2942 2012-04-27 Glenn Morris <rgm@gnu.org>
2944 * fileio.c (Fcopy_file, Fset_file_selinux_context):
2945 Ignore ENOTSUP failures from setfilecon functions. (Bug#11245)
2947 2012-04-27 Eli Zaretskii <eliz@gnu.org>
2949 * dispnew.c (swap_glyph_pointers, copy_row_except_pointers):
2950 Don't overrun array limits of glyph row's used[] array. (Bug#11288)
2952 2012-04-26 Eli Zaretskii <eliz@gnu.org>
2954 * xdisp.c (IT_DISPLAYING_WHITESPACE): In addition to the loaded
2955 display element, check also the underlying string or buffer
2956 character. (Bug#11341)
2958 * w32menu.c: Include w32heap.h.
2959 (add_menu_item): If the call to AppendMenuW (via
2960 unicode_append_menu) fails, disable Unicode menus only if we are
2961 running on Windows 9X/Me.
2963 2012-04-24 Andreas Schwab <schwab@linux-m68k.org>
2965 * .gdbinit (xpr): Handle USE_2_TAGS_FOR_INTS.
2966 (xgetint): Add missing shift for LSB tags.
2968 2012-04-24 Martin Rudalics <rudalics@gmx.at>
2970 * keyboard.c (read_char): Don't wipe echo area for select window
2971 events: These might get delayed via `mouse-autoselect-window'
2974 2012-04-24 Juanma Barranquero <lekktu@gmail.com>
2976 * gnutls.c (init_gnutls_functions): Protect against (unlikely)
2977 manipulation of :loaded-from data.
2979 2012-04-23 Juanma Barranquero <lekktu@gmail.com>
2981 * gnutls.c (init_gnutls_functions): The value of :loaded-from is
2982 now a cons (bug#11311).
2984 2012-04-23 Paul Eggert <eggert@cs.ucla.edu>
2986 Do not create empty overlays with the evaporate property (Bug#9642).
2987 * buffer.c (Fmove_overlay): Delete an evaporating overlay
2988 if it becomes empty after its bounds are adjusted to fit within
2989 its buffer. Without this fix, in a nonempty buffer (let ((o
2990 (make-overlay 1 2))) (overlay-put o 'evaporate t) (move-overlay o 0 1))
2991 yields an empty overlay that has the evaporate property, which is
2992 not supposed to happen.
2994 Fix minor GTK3 problems found by static checking.
2995 * emacsgtkfixed.c (EMACS_TYPE_FIXED, EMACS_FIXED, EmacsFixed)
2996 (EmacsFixedPrivate, EmacsFixedClass, struct _EmacsFixed)
2997 (struct _EmacsFixedClass, emacs_fixed_get_type):
2998 Move decls here from emacsgtkfixed.h, since they needn't be public.
2999 (emacs_fixed_get_type): Now static.
3000 (emacs_fixed_class_init): Omit unused local.
3001 (emacs_fixed_child_type): Remove; unused.
3002 * emacsgtkfixed.h (EMACS_TYPE_FIXED, EMACS_FIXED, EmacsFixed)
3003 (EmacsFixedPrivate, EmacsFixedClass, struct _EmacsFixed)
3004 (struct _EmacsFixedClass): Move to emacsgtkfixed.c.
3005 (EMACS_FIXED_CLASS, EMACS_IS_FIXED, EMACS_IS_FIXED_CLASS)
3006 (EMACS_FIXED_GET_CLASS): Remove; unused.
3007 * gtkutil.c (xg_create_frame_widgets) [!HAVE_GTK3]: Omit unused local.
3009 * keyboard.c (handle_async_input): Define only if SYNC_INPUT || SIGIO.
3010 Problem reported by Juanma Barranquero for Windows -Wunused-function.
3012 2012-04-22 Paul Eggert <eggert@cs.ucla.edu>
3014 Modernize and clean up gmalloc.c to assume C89 (Bug#9119).
3015 * gmalloc.c (_MALLOC_INTERNAL, _MALLOC_H, _PP, __ptr_t)
3016 (__malloc_size_t, __malloc_ptrdiff_t):
3017 Remove. All uses removed, replaced by the definiens if needed,
3018 since we can assume C89 or better now.
3019 Include <stdint.h>, for PTRDIFF_MAX, uintptr_t.
3020 (protect_malloc_state, align, get_contiguous_space)
3021 (malloc_atfork_handler_prepare, malloc_atfork_handler_parent)
3022 (malloc_atfork_handler_child, malloc_enable_thread)
3023 (malloc_initialize_1, __malloc_initialize, morecore_nolock)
3024 (_malloc_internal_nolock, _malloc_internal, malloc, _malloc)
3025 (_free, _realloc, _free_internal_nolock, _free_internal, free, cfree)
3026 (special_realloc, _realloc_internal_nolock, _realloc_internal)
3027 (realloc, calloc, __default_morecore, memalign, valloc, checkhdr)
3028 (freehook, mallochook, reallochook, mabort, mcheck, mprobe):
3029 Define using prototypes, not old style.
3030 (align, _malloc_internal_nolock, _free_internal_nolock, memalign):
3031 Don't assume ptrdiff_t and uintptr_t are no wider than unsigned long.
3032 (align): Don't assume that signed integer overflow wraps around.
3033 Omit unused local var.
3034 (malloc_initialize_1, morecore_nolock, _malloc_internal_nolock)
3035 (_free_internal_nolock, memalign, mallochook, reallochook):
3036 Omit no-longer-needed casts.
3037 (valloc): Use getpagesize, not __getpagesize.
3038 (MAGICWORD, MAGICFREE): Now randomish size_t values, not 32-bit.
3039 (struct hdr): The 'magic' member is now size_t, not unsigned long.
3041 * dbusbind.c (XD_DBUS_VALIDATE_OBJECT): Define only if needed.
3043 2012-04-22 Michael Albinus <michael.albinus@gmx.de>
3045 Move functions from C to Lisp. Make non-blocking method calls
3046 the default. Implement further D-Bus standard interfaces.
3048 * dbusbind.c (DBUS_NUM_MESSAGE_TYPES): Declare.
3049 (QCdbus_request_name_allow_replacement)
3050 (QCdbus_request_name_replace_existing)
3051 (QCdbus_request_name_do_not_queue)
3052 (QCdbus_request_name_reply_primary_owner)
3053 (QCdbus_request_name_reply_in_queue)
3054 (QCdbus_request_name_reply_exists)
3055 (QCdbus_request_name_reply_already_owner): Move to dbus.el.
3056 (QCdbus_registered_serial, QCdbus_registered_method)
3057 (QCdbus_registered_signal): New Lisp objects.
3058 (XD_DEBUG_MESSAGE): Use sizeof.
3059 (XD_MESSAGE_TYPE_TO_STRING, XD_OBJECT_TO_STRING)
3060 (XD_DBUS_VALIDATE_BUS_ADDRESS, XD_DBUS_VALIDATE_OBJECT)
3061 (XD_DBUS_VALIDATE_BUS_NAME, XD_DBUS_VALIDATE_PATH)
3062 (XD_DBUS_VALIDATE_INTERFACE, XD_DBUS_VALIDATE_MEMBER): New macros.
3063 (XD_CHECK_DBUS_SERIAL): Rename from CHECK_DBUS_SERIAL_GET_SERIAL.
3064 (xd_signature, xd_append_arg): Allow float for integer types.
3065 (xd_get_connection_references): New function.
3066 (xd_get_connection_address): Rename from xd_initialize.
3067 Return cached address.
3068 (xd_remove_watch): Do not unset $DBUS_SESSION_BUS_ADDRESS.
3069 (xd_close_bus): Rename from Fdbus_close_bus. Not needed on Lisp
3071 (Fdbus_init_bus): New optional arg PRIVATE. Cache address.
3072 Return number of refcounts.
3073 (Fdbus_get_unique_name): Make stronger parameter check.
3074 (Fdbus_message_internal): New defun.
3075 (Fdbus_call_method, Fdbus_call_method_asynchronously)
3076 (Fdbus_method_return_internal, Fdbus_method_error_internal)
3077 (Fdbus_send_signal, Fdbus_register_service)
3078 (Fdbus_register_signal, Fdbus_register_method): Move to dbus.el.
3079 (xd_read_message_1): Obey new structure of Vdbus_registered_objects.
3080 (xd_read_queued_messages): Obey new structure of Vdbus_registered_buses.
3081 (Vdbus_compiled_version, Vdbus_runtime_version)
3082 (Vdbus_message_type_invalid, Vdbus_message_type_method_call)
3083 (Vdbus_message_type_method_return, Vdbus_message_type_error)
3084 (Vdbus_message_type_signal): New defvars.
3085 (Vdbus_registered_buses, Vdbus_registered_objects_table):
3088 2012-04-22 Paul Eggert <eggert@cs.ucla.edu>
3090 Fix GC_MALLOC_CHECK debugging output on 64-bit hosts.
3091 * alloc.c (emacs_blocked_malloc) [GC_MALLOC_CHECK]:
3092 Do not assume ptrdiff_t is the same width as 'int'.
3094 * alloc.c: Handle unusual debugging option combinations.
3095 (GC_CHECK_MARKED_OBJECTS): Undef if ! GC_MARK_STACK,
3096 since the two debugging options are incompatible.
3097 (GC_MALLOC_CHECK): Similarly, undef if GC_CHECK_MARKED_OBJECTS
3099 (mem_init, mem_insert, mem_insert_fixup):
3100 Define if GC_MARK_STACK || GC_MALLOC_CHECK.
3101 (NEED_MEM_INSERT): Remove; no longer needed.
3103 2012-04-22 Leo Liu <sdl.web@gmail.com>
3105 * sysdep.c (list_system_processes): Support Darwin (Bug#5725).
3107 2012-04-22 Paul Eggert <eggert@cs.ucla.edu>
3109 * sysdep.c [__FreeBSD__]: Minor cleanups.
3110 (list_system_processes, system_process_attributes) [__FreeBSD__]:
3111 Use Emacs indenting style more consistently. Avoid some casts.
3112 Use 'double' consistently rather than mixing 'float' and 'double'.
3114 2012-04-21 Eduard Wiebe <usenet@pusto.de>
3116 * sysdep.c (list_system_processes, system_process_attributes):
3117 Add implementation for FreeBSD (Bug#5243).
3119 2012-04-21 Andreas Schwab <schwab@linux-m68k.org>
3121 * lisp.mk (lisp): Update.
3123 2012-04-20 Paul Eggert <eggert@cs.ucla.edu>
3125 * keyboard.c (process_pending_signals): Define only if SYNC_INPUT.
3126 It is never used otherwise.
3128 2012-04-20 Stefan Monnier <monnier@iro.umontreal.ca>
3130 * print.c (print_preprocess): Only check print_depth if print-circle
3132 (print_object): Check for cycles even when print-circle is nil and
3133 print-gensym is t, but only check print_depth if print-circle is nil.
3135 2012-04-20 Chong Yidong <cyd@gnu.org>
3137 * process.c (wait_reading_process_output): If EIO occurs on a pty,
3138 set the status to "failed" and ensure that sentinel is run.
3140 2012-04-20 Glenn Morris <rgm@gnu.org>
3142 * process.c (Fset_process_inherit_coding_system_flag)
3143 (Fset_process_query_on_exit_flag): Doc fix (mention return value).
3144 (Fmake_network_process, Fmake_serial_process): Doc fix.
3146 2012-04-20 Eli Zaretskii <eliz@gnu.org>
3148 * xdisp.c (string_buffer_position_lim): Limit starting position to
3150 (set_cursor_from_row): If called for a mode-line or header-line
3151 row, return zero immediately.
3152 (try_cursor_movement): If inside continuation line, don't back up
3153 farther than the first row after the header line, if any.
3154 Don't consider the header-line row as "partially visible", even if
3155 MATRIX_ROW_PARTIALLY_VISIBLE_P returns non-zero. (Bug#11261)
3157 2012-04-20 Atsuo Ohki <ohki@gssm.otsuka.tsukuba.ac.jp> (tiny change)
3159 * lread.c (lisp_file_lexically_bound_p): Fix hang at ";-*-\n"
3162 2012-04-20 Teodor Zlatanov <tzz@lifelogs.com>
3163 2012-04-18 Paul Eggert <eggert@cs.ucla.edu>
3165 configure: new option --enable-gcc-warnings (Bug#11207)
3166 * Makefile.in (C_WARNINGS_SWITCH): Remove.
3167 (WARN_CFLAGS, WERROR_CFLAGS): New macros.
3168 (ALL_CFLAGS): Use new macros rather than old.
3169 * process.c: Ignore -Wstrict-overflow to work around GCC bug 52904.
3170 * regex.c: Ignore -Wstrict-overflow. If !emacs, also ignore
3171 -Wunused-but-set-variable, -Wunused-function, -Wunused-macros,
3172 -Wunused-result, -Wunused-variable. This should go away once
3173 the Emacs and Gnulib regex code is merged.
3174 (xmalloc, xrealloc): Now static.
3176 2012-04-17 Paul Eggert <eggert@cs.ucla.edu>
3178 * dired.c (Fsystem_groups): Remove unused local.
3180 2012-04-17 Glenn Morris <rgm@gnu.org>
3182 * dired.c (Fsystem_users): Doc fix.
3184 2012-04-17 Dmitry Antipov <dmantipov@yandex.ru>
3186 * dired.c (Fsystem_users, Fsystem_groups): New functions. (Bug#7900)
3187 (syms_of_dired): Add them.
3189 2012-04-16 Paul Eggert <eggert@cs.ucla.edu>
3191 Fix minor alloc.c problems found by static checking.
3192 * alloc.c (_malloc_internal, _free_internal) [!DOUG_LEA_MALLOC]:
3193 New extern decls, to avoid calling undeclared functions.
3194 (dont_register_blocks): Define if ((!SYSTEM_MALLOC && !SYNC_INPUT)
3195 && GC_MALLOC_CHECK), not if ((GC_MARK_STACK || defined
3196 GC_MALLOC_CHECK) && GC_MALLOC_CHECK), to match when it's used.
3197 (NEED_MEM_INSERT): New macro.
3198 (mem_insert, mem_insert_fixup) [!NEED_MEM_INSERT]: Remove; unused.
3199 Remove one incorrect comment and fix another.
3201 Fix minor ralloc.c problems found by static checking.
3202 See http://lists.gnu.org/archive/html/emacs-devel/2011-12/msg00720.html
3203 * ralloc.c (ALIGNED, ROUND_TO_PAGE, HEAP_PTR_SIZE)
3204 (r_alloc_size_in_use, r_alloc_freeze, r_alloc_thaw): Remove; unused.
3205 (r_alloc_sbrk): Now static.
3207 Improve ralloc.c interface checking.
3208 See http://lists.gnu.org/archive/html/emacs-devel/2011-12/msg00720.html
3209 * buffer.c (ralloc_reset_variable, r_alloc, r_re_alloc)
3210 (r_alloc_free) [REL_ALLOC]: Move decls from here ...
3211 * lisp.h (r_alloc, r_alloc_free, r_re_alloc, r_alloc_reset_variable)
3212 [REL_ALLOC]: ... to here, to check interface.
3213 * m/ia64.h (r_alloc, r_alloc_free) [REL_ALLOC && !_MALLOC_INTERNAL]:
3214 Remove decls. This fixes an "It stinks!".
3216 * alloc.c (which_symbols): Fix alignment issue / type clash.
3218 2012-04-15 Andreas Schwab <schwab@linux-m68k.org>
3220 * lisp.h (struct Lisp_Symbol): Remove explicit padding.
3221 (struct Lisp_Misc_Any): Likewise.
3222 (struct Lisp_Free): Likewise.
3223 * alloc.c (union aligned_Lisp_Symbol): Define.
3224 (SYMBOL_BLOCK_SIZE, struct symbol_block): Use union
3225 aligned_Lisp_Symbol instead of struct Lisp_Symbol.
3226 (union aligned_Lisp_Misc): Define.
3227 (MARKER_BLOCK_SIZE, struct marker_block): Use union
3228 aligned_Lisp_Misc instead of union Lisp_Misc.
3229 (Fmake_symbol, allocate_misc, gc_sweep): Adjust.
3231 2012-04-14 Paul Eggert <eggert@cs.ucla.edu>
3233 Make GC_MAKE_GCPROS_NOOPS the default (Bug#9926).
3234 * lisp.h (GC_MARK_STACK): Default to GC_MAKE_GCPROS_NOOPS.
3235 * s/cygwin.h, s/darwin.h, s/freebsd.h, s/gnu.h, s/irix6-5.h, s/msdos.h:
3236 * s/netbsd.h, s/sol2-6.h:
3237 Remove definition of GC_MARK_STACK, since the default now works.
3238 * s/aix4-2.h, s/hpux10-20.h, s/unixware.h:
3239 Define GC_MARK_STACK to GC_USE_GCPROS_AS_BEFORE, since that's
3240 no longer the default.
3241 * s/gnu-linux.h (GC_MARK_STACK): Adjust to change in default.
3243 2012-04-14 Atsuo Ohki <ohki@gssm.otsuka.tsukuba.ac.jp> (tiny change)
3245 * lread.c (lisp_file_lexically_bound_p):
3246 Fix hang at ";-*-\n" (bug#11238).
3248 2012-04-14 Eli Zaretskii <eliz@gnu.org>
3250 * xdisp.c (find_last_unchanged_at_beg_row): Don't consider a row
3251 "unchanged" if its end.pos is beyond ZV. (Bug#11199)
3253 2012-04-14 Jan Djärv <jan.h.d@swipnet.se>
3255 * nsterm.m (constrainFrameRect): Always constrain when there is only
3256 one screen (Bug#10962).
3258 2012-04-13 Ken Brown <kbrown@cornell.edu>
3260 * s/cygwin.h (PTY_OPEN): Don't try to close a bogus file descriptor.
3262 2012-04-13 Reuben Thomas <rrt@sc3d.org>
3264 * indent.c (Fmove_to_column): Change interactive spec (Bug#739).
3266 2012-04-11 Daniel Colascione <dancol@dancol.org>
3268 * s/cygwin.h: The vfork the #define in cygwin.h was protecting
3269 against is gone. It's better to use vfork now so that when Cygwin
3270 gains a new, working vfork, we use it automatically (bug#10398).
3272 2012-04-11 Stefan Monnier <monnier@iro.umontreal.ca>
3274 * window.c (save_window_save): Obey window-point-insertion-type.
3276 2012-04-11 Glenn Morris <rgm@gnu.org>
3278 * Makefile.in (GNUSTEP_CFLAGS): Rename from C_SWITCH_X_SYSTEM.
3280 2012-04-11 Stefan Monnier <monnier@iro.umontreal.ca>
3282 * alloc.c (lisp_align_malloc): Remove unneeded prototype.
3284 2012-04-10 Jason S. Cornez <jcornez@ravenpack.com> (tiny change)
3286 * keyboard.c: Override inhibit-quit after the third C-g (bug#6585).
3287 (force_quit_count): New var.
3288 (handle_interrupt): Use it.
3290 2012-04-10 Juanma Barranquero <lekktu@gmail.com>
3292 * w32.c (w32_delayed_load): Record the full path of the library
3293 being loaded (bug#10424).
3295 2012-04-09 Glenn Morris <rgm@gnu.org>
3297 * doc.c (Fsnarf_documentation): Check variables, functions are bound,
3298 not just in the obarray, before snarfing them. (Bug#11036)
3300 * Makefile.in ($(leimdir)/leim-list.el):
3301 Pass EMACS rather than BUILT_EMACS.
3303 2012-04-09 Teodor Zlatanov <tzz@lifelogs.com>
3305 * process.c (make_process):
3306 * process.h: Add integer `gnutls_handshakes_tried' member to
3309 * gnutls.h: Add `GNUTLS_EMACS_HANDSHAKES_LIMIT' upper limit.
3310 Add convenience `GNUTLS_LOG2i' macro.
3312 * gnutls.c (gnutls_log_function2i): Convenience log function.
3313 (emacs_gnutls_read): Use new log functions,
3314 `gnutls_handshakes_tried' process member, and
3315 `GNUTLS_EMACS_HANDSHAKES_LIMIT' to limit the number of handshake
3316 attempts per process (connection).
3318 2012-04-09 Chong Yidong <cyd@gnu.org>
3320 * eval.c (Fuser_variable_p, user_variable_p_eh)
3321 (lisp_indirect_variable): Functions deleted.
3322 (Fdefvar): Caller changed.
3324 * callint.c (Finteractive, Fcall_interactively):
3325 * minibuf.c (Fread_variable): Callers changed.
3327 2012-04-09 Eli Zaretskii <eliz@gnu.org>
3329 * xdisp.c (set_cursor_from_row): If the display string appears in
3330 the buffer at position that is closer to point than the position
3331 after the display string, display the cursor on the first glyph of
3332 the display string. Fixes cursor display when a 'display' text
3333 property immediately follows invisible text. (Bug#11094)
3335 2012-04-09 Paul Eggert <eggert@cs.ucla.edu>
3337 composite.c: use 'double' consistently
3338 * composite.c (get_composition_id): Use 'double' consistently
3339 instead of converting 'float' to 'double' and vice versa; this is
3340 easier to understand and avoids a GCC warning.
3342 2012-04-09 Glenn Morris <rgm@gnu.org>
3344 * Makefile.in: Generate leim-list with bootstrap-emacs, in
3345 preparation for dumping it with emacs. (Bug#4789)
3346 (leimdir): New variable.
3347 ($(leimdir)/leim-list.el): New rule.
3348 (emacs$(EXEEXT)): Depend on leim-list.el.
3350 * buffer.c (Qucs_set_table_for_input): Remove. (Bug#9821)
3351 (Fget_buffer_create): Don't call Qucs_set_table_for_input.
3352 (init_buffer_once, syms_of_buffer): Remove Qucs_set_table_for_input.
3354 2012-04-08 Andreas Schwab <schwab@linux-m68k.org>
3356 * lisp.h (struct Lisp_Symbol): Add explicit padding to ensure
3359 2012-04-07 Juanma Barranquero <lekktu@gmail.com>
3361 * xml.c (init_libxml2_functions) [WINDOWSNT]:
3362 Remove unused local variable.
3364 2012-04-07 Paul Eggert <eggert@cs.ucla.edu>
3366 Avoid unnecessary pointer scanning in garbage collection (Bug#10780).
3367 * alloc.c (POINTERS_MIGHT_HIDE_IN_OBJECTS): New macro.
3368 (mark_memory): Mark Lisp_Objects only if pointers might hide in
3369 objects, as mark_maybe_pointer will catch them otherwise.
3370 (GC_LISP_OBJECT_ALIGNMENT): Remove; no longer needed.
3371 * s/gnu-linux.h (GC_LISP_OBJECT_ALIGNMENT) [__mc68000__]: Likewise.
3373 2012-04-07 Paul Eggert <eggert@cs.ucla.edu>
3375 Fix typo that broke non-Windows builds.
3376 * xml.c (libxml2_loaded_p) [!!WINDOWSNT]: 'inine' -> 'inline'.
3378 2012-04-07 Eli Zaretskii <eliz@gnu.org>
3380 Support building on MS-Windows with libxml2.
3382 * makefile.w32-in (OBJ2): Add xml.$(O).
3383 (GLOBAL_SOURCES): Add xml.c.
3384 ($(BLD)/xml.$(O)): New dependency list.
3386 * xml.c (DEF_XML2_FN, LOAD_XML2_FN) [WINDOWSNT]: New macros.
3387 (fn_htmlReadMemory, fn_xmlReadMemory, fn_xmlDocGetRootElement)
3388 (fn_xmlFreeDoc, fn_xmlCleanupParser, fn_xmlCheckVersion)
3389 [!WINDOWSNT]: New macros.
3390 (init_libxml2_functions, libxml2_loaded_p): New functions.
3391 (parse_region): Call fn_xmlCheckVersion instead of using the macro
3392 LIBXML_TEST_VERSION. Call libxml2 functions via the fn_* macros.
3393 (xml_cleanup_parser): New function, export for fn_xmlCleanupParser.
3394 Calls xmlCleanupParser only if libxml2 was loaded (or statically
3396 (Flibxml_parse_html_region, Flibxml_parse_xml_region):
3397 Call init_libxml2_functions before calling libxml2 functions.
3398 (syms_of_xml) <Qlibxml2_dll>: DEFSYM it.
3400 * emacs.c: Don't include libxml/parser.h.
3401 (shut_down_emacs): Call xml_cleanup_parser, instead of calling
3402 xmlCleanupParser directly.
3404 * lisp.h [HAVE_LIBXML2]: Add prototype for xml_cleanup_parser.
3406 2012-04-07 Eli Zaretskii <eliz@gnu.org>
3408 * indent.c (Fvertical_motion): If there is a display string at
3409 point, use it.vpos to compute how many lines to backtrack after
3410 move_it_to point. (Bug#11133)
3412 2012-04-06 Eli Zaretskii <eliz@gnu.org>
3414 * buffer.h (FETCH_CHAR, FETCH_MULTIBYTE_CHAR):
3415 * character.h (STRING_CHAR, STRING_CHAR_AND_LENGTH): Add comments
3416 about subtle differences between FETCH_CHAR* and STRING_CHAR*
3417 macros related to unification of CJK characters. For the details,
3418 see the discussion following the message here:
3419 http://debbugs.gnu.org/cgi/bugreport.cgi?bug=11073#14.
3421 2012-04-04 Chong Yidong <cyd@gnu.org>
3423 * keyboard.c (Vdelayed_warnings_list): Doc fix.
3425 2012-04-01 Eli Zaretskii <eliz@gnu.org>
3427 * w32menu.c (simple_dialog_show, add_menu_item): Use SAFE_ALLOCA
3428 instead of alloca. (Bug#11138)
3430 2012-04-01 Andreas Schwab <schwab@linux-m68k.org>
3432 * w32menu.c (is_simple_dialog): Properly check lisp types.
3435 2012-03-31 Eli Zaretskii <eliz@gnu.org>
3437 * xdisp.c (move_it_by_lines): When DVPOS is positive, and the
3438 position we get to after a call to move_it_to fails the
3439 IS_POS_VALID_AFTER_MOVE_P test, move to the next buffer position
3440 only if we wind up in a string from display property. (Bug#11063)
3442 * window.c (Fdelete_other_windows_internal): Invalidate the row
3443 and column information about mouse highlight, so that redisplay
3444 restores it after reallocating the glyph matrices. (Bug#7464)
3446 * xdisp.c (set_cursor_from_row): If `cursor' property on a display
3447 string comes from a `display' text property, use the buffer
3448 position of that property as if we actually saw that position in
3450 (move_it_by_lines): Remove the assertion that
3451 "it->current_x == 0 && it->hpos == 0" which can be legitimately
3452 violated when there's a before-string at the beginning of a line.
3455 2012-03-30 Eli Zaretskii <eliz@gnu.org>
3457 * xdisp.c (append_space_for_newline): If the default face was
3458 remapped, use the remapped face for the appended newline.
3459 (extend_face_to_end_of_line): Use the remapped default face for
3460 extending the face to the end of the line.
3461 (display_line): Call extend_face_to_end_of_line when the default
3462 face was remapped. (Bug#11068)
3464 2012-03-29 Eli Zaretskii <eliz@gnu.org>
3466 * s/ms-w32.h: Discourage from defining HAVE_GETCWD.
3468 2012-03-28 Stefan Monnier <monnier@iro.umontreal.ca>
3470 * keyboard.c (safe_run_hooks_error): Don't unquote strings.
3472 2012-03-27 Glenn Morris <rgm@gnu.org>
3474 * search.c (Fword_search_backward_lax, Fword_search_forward_lax):
3477 2012-03-26 Kenichi Handa <handa@m17n.org>
3479 * dispextern.h (struct glyph): Fix previous change. Change the
3480 bit length of glyphless.ch to 25 (Bug#11082).
3482 2012-03-26 Chong Yidong <cyd@gnu.org>
3484 * keyboard.c (Vselection_inhibit_update_commands): New variable.
3485 (command_loop_1): Use it; inhibit selection update for
3486 handle-select-window too (Bug#8996).
3488 2012-03-25 Fabrice Popineau <fabrice.popineau@supelec.fr>
3490 * w32heap.c (_heap_init, _heap_term): Remove dead MSVC-specific code.
3492 2012-03-25 Kenichi Handa <handa@m17n.org>
3494 * dispextern.h (struct glyph): Change the bit length of
3495 glyphless.ch to 22 to make the member glyphless fit in 32 bits.
3497 2012-03-24 Eli Zaretskii <eliz@gnu.org>
3499 * s/ms-w32.h (tzname): Include time.h before redirecting to
3500 _tzname. Fixes the MSVC build. (Bug#9960)
3502 2012-03-24 Andreas Schwab <schwab@linux-m68k.org>
3504 * xdisp.c (produce_glyphless_glyph): Limit length of acronym to 6
3507 * xterm.c (XTread_socket): Only modify handling_signal if
3508 !SYNC_INPUT. (Bug#11080)
3510 2012-03-23 Eli Zaretskii <eliz@gnu.org>
3512 * bidi.c (bidi_fetch_char): Use STRING_CHAR_AND_LENGTH instead of
3513 FETCH_MULTIBYTE_CHAR followed by CHAR_BYTES. Prevents crashes
3514 when fetching a multibyte character consumes more bytes than
3515 CHAR_BYTES returns, due to unification of CJK characters in
3516 string_char. (Bug#11073)
3518 2012-03-23 Troels Nielsen <bn.troels@gmail.com> (tiny change)
3520 * process.c (wait_reading_process_output): Handle pty disconnect
3521 by refraining from sending oneself a SIGCHLD (bug#10933).
3523 2012-03-22 Chong Yidong <cyd@gnu.org>
3525 * dispextern.h (struct it): New member string_from_prefix_prop_p.
3527 * xdisp.c (push_prefix_prop): Rename from push_display_prop.
3528 Mark string as coming from a prefix property.
3529 (handle_face_prop): Use default face for prefix strings (Bug#4281).
3530 (pop_it, reseat_1): Save and restore string_from_prefix_prop_p.
3532 2012-03-21 Chong Yidong <cyd@gnu.org>
3534 * xfaces.c (Vface_remapping_alist): Doc fix.
3536 2012-03-20 Eli Zaretskii <eliz@gnu.org>
3538 * w32proc.c (Fw32_set_console_codepage)
3539 (Fw32_set_console_output_codepage, Fw32_get_codepage_charset):
3542 2012-03-20 Chong Yidong <cyd@gnu.org>
3544 * dispnew.c (Fredisplay, Vredisplay_preemption_period): Update doc
3545 to reflect default non-nil value of redisplay-dont-pause.
3547 2012-03-19 Kenichi Handa <handa@m17n.org>
3549 * ftfont.c (ftfont_drive_otf): Mask bits of character code to make
3550 it fit in a valid range (Bug#11003).
3552 2012-03-18 Eli Zaretskii <eliz@gnu.org>
3554 * xdisp.c (cursor_row_p): Even if the glyph row ends in a string
3555 that is not from display property, accept the row as a "cursor
3556 row" if one of the string's character has a non-nil `cursor'
3557 property. Fixes cursor positioning when there are newlines in
3558 overlay strings, e.g. in icomplete.el. (Bug#11035)
3560 2012-03-12 Paul Eggert <eggert@cs.ucla.edu>
3562 * buffer.c (compare_overlays): Don't assume args differ (Bug#6830).
3564 2012-03-12 Chong Yidong <cyd@gnu.org>
3566 * eval.c (inhibit_lisp_code): Rename from
3567 inhibit_window_configuration_change_hook; move from window.c.
3569 * xfns.c (unwind_create_frame_1, Fx_create_frame):
3570 * window.c (run_window_configuration_change_hook)
3571 (syms_of_window): Callers changed.
3573 2012-03-11 Chong Yidong <cyd@gnu.org>
3575 * keymap.c (Fkey_description): Doc fix (Bug#9700).
3577 * editfns.c (Fconstrain_to_field): Doc fix (Bug#9452).
3579 2012-03-10 Chong Yidong <cyd@gnu.org>
3581 * frame.c (other_visible_frames): Don't assume the selected frame
3582 is visible (Bug#10955).
3584 2012-03-09 Stefan Monnier <monnier@iro.umontreal.ca>
3586 * buffer.c (compare_overlays): Avoid qsort's instability (bug#6830).
3588 2012-03-08 Jan Djärv <jan.h.d@swipnet.se>
3590 * gtkutil.c (x_wm_set_size_hint): Use one row in call to
3591 FRAME_TEXT_LINES_TO_PIXEL_HEIGHT so base_height is greater than
3594 2012-03-03 Glenn Morris <rgm@gnu.org>
3596 * alloc.c (Fgarbage_collect, misc-objects-consed): Doc fixes.
3598 2012-03-02 Eli Zaretskii <eliz@gnu.org>
3600 * xdisp.c (try_window_reusing_current_matrix): Don't move cursor
3601 position past the first glyph_row that ends at ZV. (Bug#10902)
3602 (redisplay_window, next_element_from_string): Fix typos in
3604 (redisplay_window): Pass to move_it_vertically the margin in
3605 pixels, not in screen lines.
3607 2012-03-02 Glenn Morris <rgm@gnu.org>
3609 * buffer.c (buffer-list-update-hook): Doc fix.
3611 2012-02-29 Eli Zaretskii <eliz@gnu.org>
3613 * xdisp.c (get_overlay_strings_1): Under bidi redisplay, call
3614 push_it before setting up the iterator for the first overlay
3615 string, even if we have an empty string loaded.
3616 (next_overlay_string): If there's an empty string on the iterator
3617 stack, pop the stack. (Bug#10903)
3619 2012-02-25 Paul Eggert <eggert@cs.ucla.edu>
3621 Generalize fix for crash due to non-contiguous EMACS_INT (Bug#10780).
3622 Suggested by Stefan Monnier in
3623 <http://lists.gnu.org/archive/html/emacs-devel/2012-02/msg00692.html>.
3624 * alloc.c (widen_to_Lisp_Object): New static function.
3625 (mark_memory): Also mark Lisp_Objects by fetching pointer words
3626 and widening them to Lisp_Objects. This would work even if
3627 USE_LSB_TAG is defined and wide integers are used, which might
3628 happen in a future version of Emacs.
3630 2012-02-25 Chong Yidong <cyd@gnu.org>
3632 * fileio.c (Ffile_selinux_context, Fset_file_selinux_context):
3635 * xselect.c (Fx_selection_exists_p): Doc fix.
3636 (x_clipboard_manager_save_all): Print an informative message
3637 before saving to clipboard manager.
3639 2012-02-24 Chong Yidong <cyd@gnu.org>
3641 * keyboard.c (process_special_events): Handle all X selection
3642 requests in kbd_buffer, not just the next one (Bug#8869).
3644 2012-02-23 Chong Yidong <cyd@gnu.org>
3646 * xfns.c (Fx_create_frame): Avoid window-configuration-change-hook
3647 call when setting menu-bar-lines and tool-bar-lines parameters.
3648 (unwind_create_frame_1): New helper function.
3650 * window.c (inhibit_window_configuration_change_hook): New var.
3651 (run_window_configuration_change_hook): Obey it.
3652 (syms_of_window): Initialize it.
3654 2012-02-22 Chong Yidong <cyd@gnu.org>
3656 * xterm.c (x_draw_image_relief): Add missing type check for
3657 Vtool_bar_button_margin (Bug#10743).
3659 2012-02-21 Chong Yidong <cyd@gnu.org>
3661 * fileio.c (Vfile_name_handler_alist): Doc fix.
3663 * buffer.c (Fget_file_buffer): Protect against invalid file
3664 handler return value.
3666 2012-02-20 Paul Eggert <eggert@cs.ucla.edu>
3668 * .gdbinit (xreload): Don't assume EMACS_INT fits in 'long'
3669 when computing $valmask.
3671 Fix crash due to non-contiguous EMACS_INT (Bug#10780).
3672 * lisp.h (VALBITS): Move definition up, so that USE_LSB_TAG can use it.
3673 (USE_LSB_TAG): Do not define if UINTPTR_MAX >> VALBITS == 0.
3674 It's useless in that case, and it can cause problems on hosts
3675 that allocate halves of EMACS_INT values separately.
3676 Reported by Dan Horák. Diagnosed by Andreas Schwab in
3677 <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=10780#30>.
3678 * mem-limits.h (EXCEEDS_LISP_PTR): Define to 0 on hosts where
3679 UINTPTR_MAX >> VALBITS == 0. This is required by the above change;
3680 it avoids undefined behavior on hosts where shifting right by more
3681 than the word width has undefined behavior.
3683 2012-02-19 Chong Yidong <cyd@gnu.org>
3685 * fileio.c (Ffile_name_directory, Ffile_name_nondirectory)
3686 (Funhandled_file_name_directory, Ffile_name_as_directory)
3687 (Fdirectory_file_name, Fexpand_file_name)
3688 (Fsubstitute_in_file_name): Protect against invalid file handler
3689 return values (Bug#10845).
3691 2012-02-18 Eli Zaretskii <eliz@gnu.org>
3693 * .gdbinit (pitx): Fix incorrect references to fields of the
3696 2012-02-17 Chong Yidong <cyd@gnu.org>
3698 * syntax.c (Fscan_lists): Doc fix (Bug#10833).
3700 2012-02-15 Paul Eggert <eggert@cs.ucla.edu>
3702 * image.c (MAX_IMAGE_SIZE): Increase from 6.0 to 10.0; see
3703 <http://lists.gnu.org/archive/html/emacs-devel/2012-02/msg00540.html>.
3705 2012-02-15 Chong Yidong <cyd@gnu.org>
3707 * eval.c (Fdefvar, Fdefconst): Doc fix; note that the variable is
3708 marked as special. Also, starting docstrings with * is obsolete.
3710 2012-02-13 Andreas Schwab <schwab@linux-m68k.org>
3712 * gnutls.c (emacs_gnutls_write): Fix last change.
3714 2012-02-13 Lars Ingebrigtsen <larsi@gnus.org>
3716 * gnutls.c (emacs_gnutls_write): Set errno appropriately for
3719 2012-02-13 Stefan Monnier <monnier@iro.umontreal.ca>
3721 * keymap.c (Fsingle_key_description): Handle char ranges.
3723 2012-02-12 Chong Yidong <cyd@gnu.org>
3725 * xdisp.c (handle_stop): Avoid assigning -1 to it->face_id here,
3726 as that creates a dangerous corner case.
3728 * window.c (Fdelete_window_internal): Invalidate the mouse
3729 highlight (Bug#9904).
3731 2012-02-12 Glenn Morris <rgm@gnu.org>
3733 * xselect.c (Fx_own_selection_internal)
3734 (Fx_get_selection_internal, Fx_disown_selection_internal)
3735 (Fx_selection_owner_p, Fx_selection_exists_p): Doc fixes.
3736 * nsselect.m (Fx_own_selection_internal)
3737 (Fx_disown_selection_internal, Fx_selection_exists_p)
3738 (Fx_selection_owner_p, Fx_get_selection_internal):
3739 Sync docs and argument specs with the xselect.c versions.
3741 2012-02-11 Lars Ingebrigtsen <larsi@gnus.org>
3743 * gnutls.c (emacs_gnutls_write): Don't infloop if sendto fails.
3745 2012-02-11 Eli Zaretskii <eliz@gnu.org>
3747 * w32select.c (Fx_selection_exists_p): Sync doc string and
3748 argument list with xselect.c. (Bug#10783)
3750 * w16select.c (Fx_selection_exists_p): Sync doc string and
3751 argument list with xselect.c. (Bug#10783)
3753 2012-02-10 Glenn Morris <rgm@gnu.org>
3755 * fns.c (Fsecure_hash): Doc fix.
3757 2012-02-09 Kenichi Handa <handa@m17n.org>
3759 * coding.c (produce_chars): Fix updating of src_end (Bug#10701).
3761 2012-02-07 Chong Yidong <cyd@gnu.org>
3763 * buffer.c (Fbuffer_local_variables)
3764 (buffer_lisp_local_variables): Handle unbound vars correctly;
3765 don't let Qunbound leak into Lisp.
3767 2012-02-07 Glenn Morris <rgm@gnu.org>
3769 * image.c (Fimagemagick_types): Doc fix.
3771 * image.c (imagemagick-render-type): Change it from a lisp object
3772 to an integer. Move the doc here from the lisp manual.
3773 Treat all values not equal to 0 the same.
3775 2012-02-06 Chong Yidong <cyd@gnu.org>
3777 * doc.c (store_function_docstring): Avoid applying docstring of
3778 alias to base function (Bug#2603).
3780 2012-02-04 Andreas Schwab <schwab@linux-m68k.org>
3782 * .gdbinit (pp1, pv1): Remove redundant defines.
3785 2012-02-04 Chong Yidong <cyd@gnu.org>
3787 * nsterm.m: Declare a global (Bug#10694).
3789 2012-02-04 Eli Zaretskii <eliz@gnu.org>
3791 * w32.c (get_emacs_configuration_options):
3792 Include --enable-checking, if specified, in the return value.
3794 2012-02-04 Martin Rudalics <rudalics@gmx.at>
3796 * dispnew.c (change_frame_size_1): Calculate new_frame_total_cols
3797 after rounding frame sizes. (Bug#9723)
3799 2012-02-04 Eli Zaretskii <eliz@gnu.org>
3801 * keyboard.c (adjust_point_for_property): Don't position point
3802 before BEGV. (Bug#10696)
3804 2012-02-03 Paul Eggert <eggert@cs.ucla.edu>
3806 Handle overflow when computing char display width (Bug#9496).
3807 * character.c (char_width): Return EMACS_INT, not int.
3808 (char_width, c_string_width): Check for overflow when
3809 computing the width; this is possible now that individual
3810 characters can have unbounded width. Problem introduced
3811 by merge from Emacs 23 on 2012-01-19.
3813 2012-02-02 Michael Albinus <michael.albinus@gmx.de>
3815 * dbusbind.c (Fdbus_register_method): Mention the return value
3816 :ignore in the docstring.
3818 2012-02-02 Glenn Morris <rgm@gnu.org>
3820 * callproc.c (Fcall_process, Fcall_process_region): Doc fix.
3822 * nsterm.m (syms_of_nsterm) <x-toolkit-scroll-bars>:
3823 Unconditionally set to t. (Bug#10673)
3824 * nsterm.m (syms_of_nsterm) <x-toolkit-scroll-bars>:
3825 * w32term.c (syms_of_w32term) <x-toolkit-scroll-bars>:
3826 * xterm.c (syms_of_xterm) <x-toolkit-scroll-bars>: Doc fix.
3828 2012-02-02 Kenichi Handa <handa@m17n.org>
3830 (x_produce_glyphs): Cancel previous change. If cmp->glyph_len is
3831 0, do not call append_composite_glyph.
3833 2012-02-02 Kenichi Handa <handa@m17n.org>
3835 * xdisp.c (BUILD_COMPOSITE_GLYPH_STRING): Initialize first_s to
3837 (x_produce_glyphs): If the component of a composition is a null
3838 string, set it->pixel_width to 1 to avoid zero-width glyph.
3840 2012-02-01 Eli Zaretskii <eliz@gnu.org>
3842 * ralloc.c (resize_bloc, r_alloc_sbrk): Don't call memmove if its
3843 first 2 arguments are identical. This makes inserting large
3844 output from a subprocess an order of magnitude faster on
3845 MS-Windows, where all sbrk'ed memory is always contiguous.
3847 2012-01-31 Glenn Morris <rgm@gnu.org>
3849 * nsterm.m (syms_of_nsterm) <x-toolkit-scroll-bars>:
3850 * w32term.c (syms_of_w32term) <x-toolkit-scroll-bars>:
3851 * xterm.c (syms_of_xterm) <x-toolkit-scroll-bars>: Sync docs.
3853 2012-01-29 Glenn Morris <rgm@gnu.org>
3855 * gnutls.c (syms_of_gnutls): More doc (from etc/NEWS).
3857 2012-01-28 Samuel Thibault <sthibault@debian.org> (tiny change)
3859 * s/gnu.h: Define POSIX_SIGNALS (Bug#10552).
3861 2012-01-28 Chong Yidong <cyd@gnu.org>
3863 * minibuf.c (syms_of_minibuf): Doc fix (Bug#10550).
3865 2012-01-26 Chong Yidong <cyd@gnu.org>
3867 * keyboard.c (Vecho_keystrokes): Document zero value (Bug#10503).
3869 * search.c (Fsearch_forward, Fsearch_backward): Document negative
3870 repeat counts (Bug#10507).
3872 2012-01-26 Glenn Morris <rgm@gnu.org>
3874 * lread.c (syms_of_lread): Doc fix.
3876 2012-01-25 HIROSHI OOTA <nil@mad.dog.cx> (tiny change)
3878 * coding.c (encode_designation_at_bol): Change return value to
3881 2012-01-25 Chong Yidong <cyd@gnu.org>
3883 * eval.c (Fuser_variable_p): Doc fix; mention custom-variable-p.
3885 2012-01-21 Chong Yidong <cyd@gnu.org>
3887 * floatfns.c (Fcopysign): Make the second argument non-optional,
3888 since nil is not allowed anyway.
3890 2012-01-21 Andreas Schwab <schwab@linux-m68k.org>
3892 * process.c (read_process_output): Use p instead of XPROCESS (proc).
3893 (send_process): Likewise.
3895 2012-01-19 Martin Rudalics <rudalics@gmx.at>
3897 * window.c (save_window_save, Fcurrent_window_configuration)
3898 (Vwindow_persistent_parameters): Do not use Qstate.
3899 Rewrite doc-strings.
3901 2012-01-19 Kenichi Handa <handa@m17n.org>
3903 * character.c (char_width): New function.
3904 (Fchar_width, c_string_width, lisp_string_width):
3905 Use char_width (Bug#9496).
3907 2012-01-16 Martin Rudalics <rudalics@gmx.at>
3909 * window.c (Vwindow_persistent_parameters): New variable.
3910 (Fset_window_configuration, save_window_save): Handle persistent
3913 2012-01-14 Eli Zaretskii <eliz@gnu.org>
3915 * w32fns.c (signal_user_input): Don't do a QUIT, to avoid
3916 thrashing the stack of the thread. (Bug#9087)
3918 2012-01-12 Paul Eggert <eggert@cs.ucla.edu>
3920 * xdisp.c (rows_from_pos_range): Add parens as per gcc -Wparentheses.
3922 2012-01-11 Eli Zaretskii <eliz@gnu.org>
3924 * xdisp.c (rows_from_pos_range): Handle the case where the
3925 highlight ends on a newline. (Bug#10464)
3926 (mouse_face_from_buffer_pos): Fix off-by-one error in calculating
3927 he end column for display of highlight that ends on a newline
3930 2012-01-11 Glenn Morris <rgm@gnu.org>
3932 * lread.c (init_lread): If no-site-lisp, remove site-lisp dirs
3933 from load-path also when installation-directory is nil. (Bug#10208)
3935 2012-01-10 Glenn Morris <rgm@gnu.org>
3937 * emacs.c (syms_of_emacs) <installation-directory>: Doc fix.
3939 * epaths.in (PATH_LOADSEARCH, PATH_EXEC, PATH_DATA, PATH_DOC):
3940 Update template values to be closer to their typical values these days.
3942 2012-01-09 Eli Zaretskii <eliz@gnu.org>
3944 * xdisp.c (rows_from_pos_range): Accept additional argument
3945 DISP_STRING, and accept any glyph in a row whose object is that
3946 string as eligible for mouse highlight. Fixes mouse highlight of
3947 display strings from overlays. (Bug#10464)
3949 2012-01-07 Paul Eggert <eggert@cs.ucla.edu>
3951 emacs: fix an auto-save permissions race condition (Bug#10400)
3952 * fileio.c (auto_saving_dir_umask): New static var.
3953 (Fmake_directory_internal): Use it.
3954 (do_auto_save_make_dir): Set it, instead of invoking chmod after
3955 creating the directory. The old code temporarily assigns
3956 too-generous permissions to the directory.
3957 (do_auto_save_eh): Clear it.
3958 (Fdo_auto_save): Catch all errors, not just file errors, so
3959 that the var is always cleared.
3961 2012-01-07 Eli Zaretskii <eliz@gnu.org>
3963 * search.c (scan_buffer): Pass character positions to
3964 know_region_cache, not byte positions. (Bug#6540)
3966 2012-01-07 LynX <_LynX@bk.ru> (tiny change)
3968 * w32.c (sys_rename): Report EXDEV when rename of a directory
3969 fails because the target is on another logical disk. (Bug#10284)
3971 2012-01-07 David Benjamin <davidben@mit.edu> (tiny change)
3973 * xterm.c (x_embed_request_focus): New function.
3975 * xterm.h: Add prototype.
3977 * xfns.c (Fx_focus_frame): Use it for embedded frames (Bug#9977).
3979 2012-01-05 Glenn Morris <rgm@gnu.org>
3981 * emacs.c (emacs_copyright): Update short copyright year to 2012.
3983 2012-01-01 Eli Zaretskii <eliz@gnu.org>
3985 * gnutls.c (init_gnutls_functions): Load gnutls_check_version.
3986 Load gnutls_transport_set_lowat only if GnuTLS version is below
3988 (emacs_gnutls_handshake): Call gnutls_transport_set_lowat only for
3989 GnuTLS versions below 2.11.1.
3991 2011-12-31 Antoine Levitt <antoine.levitt@gmail.com>
3993 * xdisp.c (syms_of_xdisp) <window-scroll-functions>: Add warning
3994 to the doc string advising against its use for altering the way
3995 windows are scrolled.
3997 2011-12-28 Kenichi Handa <handa@m17n.org>
3999 * coding.c (Fdefine_coding_system_internal): Make an utf-8 base
4000 coding-system ASCII compatible only when it does not produce BOM
4001 on encoding (Bug#10383).
4003 2011-12-26 Jan Djärv <jan.h.d@swipnet.se>
4005 * xmenu.c (x_menu_wait_for_event): Use xg_select for Gtk3 so menus
4007 (create_and_show_popup_menu): Always use menu_position_func for
4010 2011-12-24 Andreas Schwab <schwab@linux-m68k.org>
4012 * callint.c (Fcall_interactively): Don't truncate prompt string.
4014 2011-12-23 Eli Zaretskii <eliz@gnu.org>
4016 * xdisp.c (handle_invisible_prop): Handle correctly an invisible
4017 property that ends at ZV, so that the bidi iteration could be
4018 resumed from there (after widening). (Bug#10360)
4020 2011-12-22 Jan Djärv <jan.h.d@swipnet.se>
4022 * nsfont.m (ns_spec_to_descriptor): Do not autorelease fdesc.
4024 2011-12-21 Jan Djärv <jan.h.d@swipnet.se>
4026 * nsterm.m (x_free_frame_resources):
4027 Release f->output_data.ns->miniimage.
4028 (ns_index_color): Fix indentation. Do not retain
4029 color_table->colors[i].
4031 * nsmenu.m (ns_update_menubar): Call free_menubar_widget_value_tree
4034 * nsfns.m (x_set_background_color): Assign return value from
4035 ns_index_color to face-background instead of NSColor*.
4036 (ns_implicitly_set_icon_type): Fix indentation.
4037 Change assignment in for loop to comparison.
4039 * emacs.c (ns_pool): New variable.
4040 (main): Assign ns_pool.
4041 (Fkill_emacs): Call ns_release_autorelease_pool.
4043 * nsfont.m (ns_spec_to_descriptor): Fix indentation,
4044 autorelease fdesc, release fdAttrs and tdict.
4045 (ns_get_covering_families): Release charset.
4046 (ns_findfonts): Release NSFontDescriptor created with new.
4047 (ns_uni_to_glyphs): Fix indentation.
4048 (setString): Release attrStr before assigning new value.
4050 2011-12-18 Jan Djärv <jan.h.d@swipnet.se>
4052 * nsmenu.m (NSMenuDidBeginTrackingNotification): Declare if OSX < 10.5
4054 (trackingNotification): Surround with ifdef NS_IMPL_COCOA.
4055 (syms_of_nsmenu): Set trackingMenu to 1 if not NS_IMPL_COCOA.
4057 2011-12-18 David Reitter <reitter@cmu.edu>
4059 * nsterm.m (ns_term_init): Subscribe for notifications
4060 NSMenuDidBeginTrackingNotification and NSMenuDidEndTrackingNotification
4061 to method trackingNotification in EmacsMenu.
4063 * nsmenu.m (trackingMenu): New variable.
4064 (trackingNotification): New method (from Aquamacs).
4065 (menuNeedsUpdate): Expand comment and return if trackingMenu is 0,
4066 from Aquamacs (Bug#7030).
4068 2011-12-18 Jan Djärv <jan.h.d@swipnet.se>
4070 * nsselect.m (CUT_BUFFER_SUPPORT): Remove define.
4071 (symbol_to_nsstring): Fix indentation.
4072 (ns_symbol_to_pb): New function.
4073 (Fns_get_selection_internal): Rename from Fns_get_cut_buffer_internal.
4074 (Fns_rotate_cut_buffers_internal): Remove.
4075 (Fns_store_selection_internal): Rename from
4076 Fns_store_cut_buffer_internal.
4077 (ns_get_foreign_selection, Fx_own_selection_internal)
4078 (Fx_disown_selection_internal, Fx_selection_exists_p)
4079 (Fns_get_selection_internal, Fns_store_selection_internal):
4080 Use ns_symbol_to_pb and check if return value is nil.
4081 (syms_of_nsselect): Remove ifdef CUT_BUFFER_SUPPORT. Remove defsubr
4082 Sns_rotate_cut_buffers_internal. Sns_get_cut_buffer_internal
4083 renamed to Sns_get_selection_internal, Sns_store_cut_buffer_internal
4084 renamed to Sns_store_selection_internal.
4085 (ns_handle_selection_request): Move code to Fx_own_selection_internal
4086 and remove this function.
4087 (ns_handle_selection_clear): Remove, never used.
4088 (Fx_own_selection_internal): Move code from ns_handle_selection_request
4091 2011-12-17 Ken Brown <kbrown@cornell.edu>
4093 * fileio.c (check_writable) [CYGWIN]: Return non-zero if UID or
4094 GID is unknown (Bug#10257).
4096 2011-12-17 Paul Eggert <eggert@cs.ucla.edu>
4098 * s/gnu-linux.h: Fix mark_memory typo (Bug#10286).
4099 (GC_MARK_SECONDARY_STACK): Omit removed 3rd arg to mark_memory,
4100 which caused a build failure on GNU/Linux IA-64. This problem was
4101 introduced by my 2011-10-07 patch.
4103 2011-12-15 Juri Linkov <juri@jurta.org>
4105 * image.c (imagemagick_error): New function. (Bug#10112)
4106 (imagemagick_load_image): Comment out `MagickSetResolution' call.
4107 Use `imagemagick_error' where ImageMagick functions return
4109 (Fimagemagick_types): Add `Fnreverse' to return the list in the
4112 2011-12-15 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
4114 * xftfont.c (xftfont_draw): Use the font metrics of s->font to
4115 fill background (Bug#8992).
4117 2011-12-13 Martin Rudalics <rudalics@gmx.at>
4119 * window.c (Vwindow_combination_resize)
4120 (Vwindow_combination_limit): Use t instead of non-nil in
4122 (Vrecenter_redisplay): Add first sentence of doc-string on
4124 (Frecenter): Fix doc-string typo.
4126 2011-12-11 Kenichi Handa <handa@m17n.org>
4128 * coding.c (Funencodable_char_position): Pay attention to the
4129 buffer text relocation (Bug#9389).
4131 2011-12-10 Jan Djärv <jan.h.d@swipnet.se>
4133 * xterm.c (x_term_init): Move call to gdk_window_add_filter before
4134 gtk_init (Bug#10100).
4136 2011-12-10 Eli Zaretskii <eliz@gnu.org>
4138 * xdisp.c (RECORD_MAX_MIN_POS): Use IT->cmp_it.charpos only if
4139 IT->string is nil. (Bug#10263)
4141 2011-12-10 Jan Djärv <jan.h.d@swipnet.se>
4143 * nsterm.h (x_free_frame_resources): Declare.
4145 * nsfns.m (ns_get_defaults_value): New function (Bug#10103).
4146 (Fns_get_resource, x_get_string_resource): Call ns_get_defaults_value.
4148 * nsterm.h (ns_get_defaults_value): Declare.
4150 * nsterm.m (ns_default): Call ns_get_defaults_value.
4152 2011-12-09 Eli Zaretskii <eliz@gnu.org>
4154 * xdisp.c (try_scrolling): Don't set scroll_down_p if dy is zero.
4157 2011-12-09 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
4159 * unexelf.c (unexec) [NS_IMPL_GNUSTEP]: Take account of the case
4160 that where the value of an _OBJC_* symbol points to is in the .bss
4161 section (Bug#10240).
4163 2011-12-08 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny change)
4165 * coding.c (encode_coding_ccl): Check (charbuf < charbuf_end)
4166 after the loop to call ccl_driver at least once (Bug#8619).
4168 2011-12-08 Kenichi Handa <handa@m17n.org>
4170 * ftfont.c (get_adstyle_property): Fix previous change
4173 2011-12-07 Juanma Barranquero <lekktu@gmail.com>
4175 * w32.c (init_environment): If no_site_lisp, remove site-lisp
4176 dirs from the default value of EMACSLOADPATH (bug#10208).
4178 2011-12-07 Glenn Morris <rgm@gnu.org>
4180 * lread.c (init_lread): If no_site_lisp, exclude site-lisp/ in
4181 installation and source directories as well. (Bug#10208)
4183 2011-12-06 Chong Yidong <cyd@gnu.org>
4185 * minibuf.c (Fread_from_minibuffer): Doc fix (Bug#10228).
4187 2011-12-06 Glenn Morris <rgm@gnu.org>
4189 * process.c (start_process_unwind): Treat any pid <= 0, except -2,
4190 as an error, not just -1. (Bug#10217)
4192 2011-12-05 Chong Yidong <cyd@gnu.org>
4194 * keyboard.c (process_special_events): New function.
4195 (swallow_events, Finput_pending_p): Use it (Bug#10195).
4197 2011-12-05 Paul Eggert <eggert@cs.ucla.edu>
4199 * coding.c (encode_designation_at_bol): Don't use uninitialized
4200 local variable (Bug#9318).
4202 2011-12-05 Kenichi Handa <handa@m17n.org>
4204 * ftfont.c (get_adstyle_property): If the font is not BDF nor PCF,
4205 return Qnil (Bug#8046, Bug#10193).
4207 2011-12-05 Kenichi Handa <handa@m17n.org>
4209 * coding.c (encode_designation_at_bol): New args charbuf_end and
4210 dst. Return the number of produced bytes. Callers changed.
4211 (coding_set_source): Return how many bytes coding->source was
4213 (coding_set_destination): Return how many bytes
4214 coding->destination was relocated.
4215 (CODING_DECODE_CHAR, CODING_ENCODE_CHAR, CODING_CHAR_CHARSET)
4216 (CODING_CHAR_CHARSET_P): Adjust for the avove changes.
4218 2011-12-05 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny change)
4220 * coding.c (CODING_CHAR_CHARSET_P): New macro.
4221 (encode_coding_emacs_mule, encode_coding_iso_2022): Use the above
4224 2011-12-05 Andreas Schwab <schwab@linux-m68k.org>
4226 The following changes are to fix Bug#9318.
4228 * coding.c (CODING_ENCODE_CHAR, CODING_CHAR_CHARSET): New macros.
4229 (encode_coding_emacs_mule, ENCODE_ISO_CHARACTER)
4230 (encode_coding_iso_2022, encode_coding_sjis)
4231 (encode_coding_big5, encode_coding_charset): Use the above macros.
4233 2011-12-05 Juanma Barranquero <lekktu@gmail.com>
4235 * lisp.h (process_quit_flag): Fix external declaration.
4237 2011-12-04 Stefan Monnier <monnier@iro.umontreal.ca>
4239 Don't macro-inline non-performance-critical code.
4240 * eval.c (process_quit_flag): New function.
4241 * lisp.h (QUIT): Use it.
4243 2011-12-04 Jan Djärv <jan.h.d@swipnet.se>
4245 * nsfns.m (get_geometry_from_preferences): New function.
4246 (Fx_create_frame): Call get_geometry_from_preferences (Bug#10103).
4248 2011-12-04 Andreas Schwab <schwab@linux-m68k.org>
4250 * emacs.c (Qkill_emacs): Define.
4251 (syms_of_emacs): Initialize it.
4252 * keyboard.c (interrupt_signal): Don't call Fkill_emacs here, set
4253 Qquit_flag to `kill-emacs' instead.
4254 (quit_throw_to_read_char): Add parameter `from_signal'.
4255 All callers changed. Call Fkill_emacs if requested and safe.
4256 * lisp.h (QUIT): Call Fkill_emacs if requested.
4258 2011-12-03 Jan Djärv <jan.h.d@swipnet.se>
4260 * widget.c (update_wm_hints): Return if wmshell is null.
4261 (widget_update_wm_size_hints): New function.
4263 * widget.h (widget_update_wm_size_hints): Declare.
4265 * xterm.c (x_wm_set_size_hint): If USE_X_TOOLKIT, call
4266 widget_update_wm_size_hints (Bug#10104).
4268 2011-12-03 Eli Zaretskii <eliz@gnu.org>
4270 * xdisp.c (handle_invisible_prop): If the invisible text ends just
4271 before a newline, prepare the bidi iterator for consuming the
4272 newline, and keep the current paragraph direction. (Bug#10183)
4273 (redisplay_window): Don't let `margin' become negative. (Bug#10192)
4275 2011-12-02 Juri Linkov <juri@jurta.org>
4277 * search.c (Fword_search_regexp): New Lisp function created from
4278 `wordify'. Change type of arg `lax' from `int' to `Lisp_Object'.
4279 (Fword_search_backward, Fword_search_forward)
4280 (Fword_search_backward_lax, Fword_search_forward_lax):
4281 Use `Fword_search_regexp' instead of `wordify'. Doc fix.
4282 (syms_of_search): Define `Sword_search_regexp'. (Bug#10145)
4284 2011-12-01 Stefan Monnier <monnier@iro.umontreal.ca>
4286 * fileio.c (Finsert_file_contents): Move after-change-function call
4287 to before the "handled:" label, since all "goto handled" appear in
4288 cases where the *-change-functions have already been properly called
4291 2011-12-01 Andreas Schwab <schwab@linux-m68k.org>
4293 * keyboard.c (interrupt_signal): Don't call kill-emacs when
4294 waiting for input. (Bug#10169)
4296 2011-11-30 Eli Zaretskii <eliz@gnu.org>
4298 * dispnew.c (adjust_glyph_matrix): Remove the assertion that
4299 verifies glyph row's hash code--we have just reallocated the
4300 glyphs, so their contents can be complete garbage. (Bug#10164)
4302 2011-11-30 Juanma Barranquero <lekktu@gmail.com>
4304 * dispnew.c (adjust_glyph_matrix) [XASSERTS]: Add missing check.
4306 2011-11-30 Eli Zaretskii <eliz@gnu.org>
4308 * dispnew.c (adjust_glyph_matrix) [XASSERTS]: Ensure ROW's
4309 attributes are tested _before_ calling verify_row_hash, to protect
4310 against GCC re-ordering of the tests. (Bug#10164)
4312 2011-11-29 Jan Djärv <jan.h.d@swipnet.se>
4314 * xterm.h (struct x_output): net_wm_state_hidden_seen is new.
4316 * xterm.c (handle_one_xevent): Only set async_visible and friends
4317 if net_wm_state_hidden_seen is non-zero (Bug#10002)
4318 (get_current_wm_state): Set net_wm_state_hidden_seen to 1 if
4319 _NET_WM_STATE_HIDDEN is in NET_WM_STATE.
4321 2011-11-28 Paul Eggert <eggert@cs.ucla.edu>
4323 Remove GCPRO-related macros that exist only to avoid shadowing locals.
4324 * lisp.h (GCPRO1_VAR, GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR, GCPRO5_VAR)
4325 (GCPRO6_VAR, UNGCPRO_VAR): Remove. See
4326 <http://lists.gnu.org/archive/html/emacs-diffs/2011-11/msg00265.html>.
4327 All uses changed to use GCPRO1 etc.
4328 (GCPRO1, GCPRO2, GCPRO3, GCPRO4, GCPRO5, GCPRO6, UNGCPRO):
4329 Revert to old implementation (i.e., before 2011-03-11).
4331 2011-11-28 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
4333 * dispnew.c (scrolling_window): Truncate overlaps in copy destination
4334 of scroll runs so as to avoid assigning disabled bogus rows and
4335 unnecessary graphics copy operations.
4337 2011-11-27 Eli Zaretskii <eliz@gnu.org>
4339 * s/ms-w32.h (utimbuf) [_MSC_VER]: Don't define.
4340 (snprintf) [_MSC_VER]: Redirect to _snprintf.
4341 (strtoll) [_MSC_VER]: Redirect to _strtoi64.
4342 (malloc, free, realloc, calloc): Redirect to e_* only when
4345 * lisp.h (GCTYPEBITS): Move before first use.
4346 (ALIGN_GCTYPEBITS) [_MSC_VER]: Define.
4347 (DECL_ALIGN) [_MSC_VER]: Use it, as MSVC doesn't like bit ops in
4348 this macro definition.
4350 * s/ms-w32.h (tzname): Redirect to _tzname for all values of
4353 2011-11-27 Jan Djärv <jan.h.d@swipnet.se>
4355 * gtkutil.c (xg_create_frame_widgets):
4356 Call gtk_window_set_has_resize_grip (FALSE) if that function is
4357 present with Gtk+ 2.0.
4359 2011-11-26 Paul Eggert <eggert@cs.ucla.edu>
4361 * fileio.c (Finsert_file_contents): Undo previous change; see
4362 <http://lists.gnu.org/archive/html/emacs-diffs/2011-11/msg00265.html>.
4364 2011-11-26 Paul Eggert <eggert@cs.ucla.edu>
4366 Rename locals to avoid shadowing.
4367 * fileio.c (Finsert_file_contents):
4368 Rename inner 'gcpro1' to 'inner_gcpro1' to avoid shadowing.
4369 * process.c (wait_reading_process_output):
4370 Rename inner 'proc' to 'p' to avoid shadowing.
4371 Indent for consistency with usual Emacs style.
4373 2011-11-25 Eli Zaretskii <eliz@gnu.org>
4375 * xdisp.c (redisplay_window): If cursor row is not fully visible
4376 after recentering, and scroll-conservatively is set to a large
4377 number, scroll window by a few more lines to make the cursor fully
4378 visible and out of scroll-margin. (Bug#10105)
4379 (start_display): Don't move to the next line if the display should
4380 start at a newline that is part of a display vector or an overlay
4383 2011-11-24 Juri Linkov <juri@jurta.org>
4385 * image.c (imagemagick_load_image): Move `MagickSetResolution' down
4386 after the `MagickPingImage' call. (Bug#10112)
4388 2011-11-23 Chong Yidong <cyd@gnu.org>
4390 * window.c (Fcoordinates_in_window_p): Accept only live windows.
4392 2011-11-23 Martin Rudalics <rudalics@gmx.at>
4394 * buffer.c (Fkill_buffer): Run replace_buffer_in_windows before
4395 making another buffer current. (Bug#10114)
4397 2011-11-23 Glenn Morris <rgm@gnu.org>
4399 * font.c (font_find_for_lface) [HAVE_NS]: Ignore case. (Bug#2526)
4401 2011-11-23 Chong Yidong <cyd@gnu.org>
4403 * xdisp.c (compute_stop_pos): Check validity of end_charpos before
4404 using it (Bug#5984).
4406 2011-11-22 Eli Zaretskii <eliz@gnu.org>
4408 * dispnew.c (adjust_glyph_matrix): Don't verify hash code of mode-
4409 and header-lines, as they don't have one computed for them.
4412 * .gdbinit (prow): Make displayed values more self-explaining.
4413 Add row's hash code.
4415 2011-11-21 Lars Magne Ingebrigtsen <larsi@gnus.org>
4417 * process.c (wait_reading_process_output): Fix asynchrounous
4418 GnuTLS socket handling on some versions of the GnuTLS library.
4419 (wait_reading_process_output): Add comment and URL.
4421 2011-11-21 Jan Djärv <jan.h.d@swipnet.se>
4423 * xterm.c (x_clear_frame): Reinstate the XClearWindow call.
4425 2011-11-21 Chong Yidong <cyd@gnu.org>
4427 * window.c (Fnext_window, Fprevious_window): Doc fix.
4429 2011-11-20 Stefan Monnier <monnier@iro.umontreal.ca>
4431 * window.c (get_phys_cursor_glyph): Fix Lisp_Object/int mixup.
4433 2011-11-20 Juanma Barranquero <lekktu@gmail.com>
4435 * nsfont.m (syms_of_nsfont) <ns-reg-to-script>: Fix typo.
4437 2011-11-20 Martin Rudalics <rudalics@gmx.at>
4439 * window.c (Fset_window_combination_limit): Rename argument
4441 (Vwindow_combination_limit): Remove "status" from doc-string.
4443 2011-11-20 Andreas Schwab <schwab@linux-m68k.org>
4445 * m/ibms390.h: Remove.
4446 * m/ibms390x.h: Don't include "ibms390.h".
4448 2011-11-20 Stefan Monnier <monnier@iro.umontreal.ca>
4450 * fileio.c (Finsert_file_contents): Add missing gcpro1 variable.
4451 Suggested by Dmitry Antipov <dmantipov@yandex.ru>.
4453 2011-11-20 Juanma Barranquero <lekktu@gmail.com>
4455 * casetab.c (Fset_case_table):
4456 * charset.c (Fcharset_after): Fix typos.
4458 2011-11-20 Paul Eggert <eggert@cs.ucla.edu>
4460 Standardize on VIRT_ADDR_VARIES behavior (Bug#10042).
4461 Otherwise, valgrind does not work on some platforms.
4462 Problem reported by Andreas Schwab in
4463 <http://lists.gnu.org/archive/html/emacs-devel/2011-11/msg00081.html>.
4464 * puresize.h (pure, PURE_P): Always behave as if VIRT_ADDR_VARIES
4465 is set, removing the need for VIRT_ADDRESS_VARIES.
4466 (PURE_P): Use a more-efficient implementation that needs just one
4467 comparison, not two: on x86-64 with GCC 4.6.2, this cut down the
4468 number of instructions from 6 (xorl, cmpq, jge, xorl, cmpq, setge)
4469 to 4 (xorl, subq, cmpq, setbe).
4470 * alloc.c (pure): Always extern now, since that's the
4471 VIRT_ADDR_VARIES behavior.
4472 (PURE_POINTER_P): Use a single comparison, not two, for
4473 consistency with the new puresize.h.
4474 * lisp.h (PNTR_COMPARISON_TYPE): Remove; no longer needed.
4475 * m/ibms390.h, m/intel386.h, m/template.h, s/cygwin.h, s/hpux10-20.h:
4476 Remove VIRT_ADDR_VARIES no longer needed.
4478 2011-11-19 Eli Zaretskii <eliz@gnu.org>
4480 * xdisp.c (x_write_glyphs, draw_phys_cursor_glyph)
4481 (erase_phys_cursor, update_window_cursor, show_mouse_face)
4482 (cursor_in_mouse_face_p): If the cursor position is out of bounds,
4483 behave as if the cursor position were at the window margin.
4485 * window.c (get_phys_cursor_glyph): If the window is hscrolled,
4486 and the cursor position is out of bounds, behave as if the cursor
4487 position were at the window margin. (Bug#10075)
4489 2011-11-18 Chong Yidong <cyd@gnu.org>
4491 * window.c (Fwindow_combination_limit): Make first argument
4492 non-optional, since it is meaningless for live windows like the
4495 2011-11-18 Dmitry Antipov <dmantipov@yandex.ru>
4497 * keymap.c (Fwhere_is_internal): Add missing RETURN_UNGCPROs.
4499 2011-11-18 Stefan Monnier <monnier@iro.umontreal.ca>
4501 * intervals.c: Fix grafting over the whole buffer (bug#10071).
4502 (graft_intervals_into_buffer): Simplify.
4504 2011-11-18 Eli Zaretskii <eliz@gnu.org>
4506 * dispnew.c (swap_glyph_pointers): Swap the used[] arrays and the
4507 hash values of the two rows.
4508 (copy_row_except_pointers): Preserve the used[] arrays and the
4509 hash values of the two rows. (Bug#10035)
4510 (add_row_entry): Add xassert to verify that ROW's hash code is valid.
4512 * xdisp.c (row_hash): New function, body extracted from
4513 compute_line_metrics.
4514 (compute_line_metrics): Call row_hash, instead of computing the
4517 * dispnew.c (verify_row_hash): Call row_hash for computing the
4518 hash code of a row, instead of duplicating code from xdisp.c.
4520 * dispextern.h (row_hash): Add prototype.
4522 2011-11-18 Tassilo Horn <tassilo@member.fsf.org>
4524 * frame.c (delete_frame): Don't delete the terminal when the last
4525 X frame is closed if emacs is built with GTK toolkit.
4527 2011-11-17 Juanma Barranquero <lekktu@gmail.com>
4529 * window.c (syms_of_window) <window-combination-resize>: Fix typo.
4531 2011-11-17 Martin Rudalics <rudalics@gmx.at>
4533 * window.c (Vwindow_splits): Rename to
4534 Vwindow_combination_resize. Suggested by Juri Linkov.
4535 (Fsplit_window_internal): Use Vwindow_combination_resize instead
4538 2011-11-16 Juanma Barranquero <lekktu@gmail.com>
4540 * nsfns.m (Fns_font_name):
4541 * window.c (syms_of_window) <window-combination-limit>: Fix typos.
4543 2011-11-16 Martin Rudalics <rudalics@gmx.at>
4545 * window.h (window): Rename slot "nest" to "combination_limit".
4546 * window.c (Fwindow_nest): Rename to Fwindow_combination_limit.
4547 (Fset_window_nest): Rename to Fset_window_combination_limit.
4548 (Vwindow_nest): Rename to Vwindow_combination_limit.
4549 (recombine_windows, make_parent_window, make_window)
4550 (Fsplit_window_internal, saved_window)
4551 (Fset_window_configuration, save_window_save): Rename all
4552 occurrences of window_nest to window_combination_limit.
4554 2011-11-15 Juanma Barranquero <lekktu@gmail.com>
4556 * image.c (imagemagick_load_image): Fix typo.
4558 2011-11-14 Eli Zaretskii <eliz@gnu.org>
4560 * xdisp.c (display_line): Move the call to
4561 highlight_trailing_whitespace before the call to
4562 compute_line_metrics, since the latter needs to see the final
4563 faces of all the glyphs to compute ROW's hash value.
4564 Fixes assertion violations in row_equal_p. (Bug#10035)
4566 2011-11-14 Juanma Barranquero <lekktu@gmail.com>
4568 * w32proc.c (reader_thread): Don't check pending input if cp->fd < 0,
4569 just return (bug#10044).
4571 2011-11-12 Eli Zaretskii <eliz@gnu.org>
4573 * makefile.w32-in (HEAPSIZE): New variable, allows to build temacs
4574 with user-defined heap size. Bump the default size of the temacs
4575 heap to 27MB, to avoid memory warning when running temacs.
4576 ($(TEMACS)): Use HEAPSIZE instead of a hardcoded value.
4578 * dispnew.c (scrolling_window): Fix incorrect indices in accessing
4579 current_matrix and desired_matrix. (Bug#9990)
4580 (verify_row_hash) [XASSERTS]: New function.
4581 (adjust_glyph_matrix, row_equal_p): Use it in xassert to verify
4582 that the hash value of glyph rows is correct.
4584 2011-11-12 Martin Rudalics <rudalics@gmx.at>
4586 * window.h (window): Remove splits slot.
4587 * window.c (Fwindow_splits, Fset_window_splits): Remove.
4588 (Fdelete_other_windows_internal, make_parent_window)
4589 (make_window, Fsplit_window_internal, Fdelete_window_internal)
4590 (Fset_window_configuration, save_window_save): Don't deal with
4591 split status of windows.
4592 (saved_window): Remove splits slot.
4593 (Vwindow_splits): Rewrite doc-string.
4595 2011-11-11 Jan Djärv <jan.h.d@swipnet.se>
4597 * xfns.c (unwind_create_frame):
4598 * nsfns.m (unwind_create_frame):
4599 * w32fns.c (unwind_create_frame): Use Fmemq to check if frame is in
4600 Vframe_list (Bug#9999).
4602 2011-11-11 Dmitry Antipov <dmantipov@yandex.ru>
4604 * xdisp.c (syms_of_xdisp): Remove duplicated definition of Qtext.
4606 2011-11-11 Kenichi Handa <handa@m17n.org>
4608 * callproc.c (Fcall_process): Set the member dst_multibyte of
4611 2011-11-11 Johan Bockgård <bojohan@gnu.org>
4613 * xdisp.c (fill_composite_glyph_string): Always set s->face, to
4614 avoid a crash (bug#9496).
4616 2011-11-09 Chong Yidong <cyd@gnu.org>
4618 * window.c (Fwindow_inside_edges, Fwindow_inside_pixel_edges)
4619 (Fwindow_inside_absolute_pixel_edges): Only allow live windows.
4621 2011-11-08 Paul Eggert <eggert@cs.ucla.edu>
4623 * s/gnu.h (GC_MARK_STACK): Define to GC_MAKE_GCPROS_NOOPS (Bug#9926).
4625 2011-11-08 Paul Eggert <eggert@cs.ucla.edu>
4627 Avoid some portability problems by eschewing 'extern inline' functions.
4628 The trivial performance wins aren't worth the portability hassles; see
4629 <http://lists.gnu.org/archive/html/emacs-devel/2011-11/msg00084.html>
4631 * dispextern.h (window_box, window_box_height, window_text_bottom_y)
4632 (window_box_width, window_box_left, window_box_left_offset)
4633 (window_box_right, window_box_right_offset): Undo previous change,
4634 by removing the "extern"s.
4635 * intervals.c (adjust_intervals_for_insertion)
4636 (adjust_intervals_for_deletion): Undo previous change,
4637 making these static again.
4638 (offset_intervals, temp_set_point_both, temp_set_point)
4639 (copy_intervals_to_string): No longer inline.
4640 * xdisp.c (window_text_bottom_y, window_box_width)
4641 (window_box_height, window_box_left_offset)
4642 (window_box_right_offset, window_box_left, window_box_right)
4643 (window_box): No longer inline.
4645 2011-11-08 Chong Yidong <cyd@gnu.org>
4647 * window.c (Fwindow_left_column, Fwindow_top_line): Doc fix.
4648 (Fwindow_body_height, Fwindow_body_width): Move from Lisp.
4649 Signal an error if not a live window.
4650 (Fwindow_total_width, Fwindow_total_height): Move from Lisp.
4651 (Fwindow_total_size, Fwindow_body_size): Move to Lisp.
4653 2011-11-07 Juanma Barranquero <lekktu@gmail.com>
4655 * lisp.h (syms_of_abbrev): Remove declaration.
4656 Reported by CHENG Gao <chenggao@royau.me>.
4658 2011-11-07 Eli Zaretskii <eliz@gnu.org>
4660 * w32.c (check_windows_init_file): Don't look for term/w32-win.el
4661 if Vpurify_flag is non-nil. Fixes a crash when running w32 build
4662 of temacs in GUI mode.
4664 2011-11-07 Martin Rudalics <rudalics@gmx.at>
4666 * window.h: Declare delete_all_child_windows instead of
4667 delete_all_subwindows.
4668 * window.c (Fwindow_nest, Fset_window_nest)
4669 (Fset_window_new_total, Fset_window_new_normal)
4670 (Fwindow_resize_apply): Don't use term subwindow in doc-strings.
4671 (delete_all_subwindows): Rename to delete_all_child_windows.
4672 (Fdelete_other_windows_internal, Fset_window_configuration):
4673 Call delete_all_child_windows instead of delete_all_subwindows.
4674 * frame.c (delete_frame): Call delete_all_child_windows instead
4675 of delete_all_subwindows.
4677 2011-11-07 Paul Eggert <eggert@cs.ucla.edu>
4679 * alloc.c (DEADP): New macro, for porting to GNU/Hurd (Bug#9926).
4680 This is also needed for porting to any host where GC_MARK_STACK is
4681 not GC_MAKE_GCPROS_NOOPS.
4682 (which_symbols): Use it.
4684 2011-11-07 Kenichi Handa <handa@m17n.org>
4686 * coding.c (coding_set_destination): Check coding->src_pos only
4687 when coding->src_object is a buffer (bug#9910).
4689 * process.c (send_process): Set the member src_multibyte of coding
4690 to 0 (bug#9911) when sending a unibyte text.
4692 * callproc.c (Fcall_process): Set the member src_multibyte of
4693 process_coding to 0 (bug#9912).
4695 2011-11-06 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
4697 * xmenu.c (cleanup_widget_value_tree): New function.
4698 (xmenu_show, xdialog_show): Use it in record_unwind_protect instead of
4699 calling free_menubar_widget_value_tree directly (Bug#9830).
4701 2011-11-06 Paul Eggert <eggert@cs.ucla.edu>
4703 Fix some portability problems with 'inline'.
4704 * dispextern.h (window_box, window_box_height, window_text_bottom_y)
4705 (window_box_width, window_box_left, window_box_left_offset)
4706 (window_box_right, window_box_right_offset): Declare extern.
4707 Otherwise, these inline functions do not conform to C99 and
4708 are miscompiled by Microsoft compilers. Reported by Eli Zaretskii in
4709 <http://lists.gnu.org/archive/html/emacs-devel/2011-11/msg00084.html>.
4710 * intervals.c (adjust_intervals_for_insertion)
4711 (adjust_intervals_for_deletion): Now extern, because otherwise the
4712 extern inline functions 'offset_intervals' couldn't refer to it.
4713 (static_offset_intervals): Remove.
4714 (offset_intervals): Rewrite using the old contents of
4715 static_offset_intervals. The old version didn't conform to C99
4716 because an extern inline function contained a reference to an
4717 identifier with static linkage.
4719 2011-11-06 Andreas Schwab <schwab@linux-m68k.org>
4721 * keyboard.c (interrupt_signal): Don't call kill-emacs while in
4724 2011-11-06 Eli Zaretskii <eliz@gnu.org>
4726 * xdisp.c (init_iterator, reseat_to_string): Don't set the
4727 iterator's bidi_p flag if Vpurify_flag is non-nil. (Bug#9963)
4728 (Fcurrent_bidi_paragraph_direction): If Vpurify_flag is non-nil,
4729 return Qleft_to_right.
4731 2011-11-06 Chong Yidong <cyd@gnu.org>
4733 * window.c (Fwindow_live_p, Fwindow_frame, Fframe_root_window)
4734 (Fminibuffer_window, Fwindow_buffer, Fwindow_splits)
4735 (Fset_window_splits, Fwindow_nest, Fset_window_nest)
4736 (Fwindow_use_time, Fwindow_total_size, Fwindow_normal_size)
4737 (Fwindow_new_normal, Fwindow_left_column, Fwindow_top_line)
4738 (Fwindow_margins, Fwindow_fringes, Fwindow_scroll_bars)
4739 (Fwindow_vscroll): Doc fix.
4740 (Fwindow_top_child, Fwindow_left_child): Eliminate a nil default
4741 argument, since it makes no sense to pass a live window and for
4742 consistency with window-child.
4744 2011-11-05 Christoph Scholtes <cschol2112@googlemail.com>
4746 * makefile.w32-in ($(TEMACS), (gl-stamp)): Use $(THISDIR) to
4749 2011-11-05 Jason Rumney <jasonr@gnu.org>
4751 * w32font.c (font_matches_spec): Filter out non-Japanese kana fonts.
4752 (add_font_entity_to_list): Filter out non-Japanese Shift-JIS
4754 (add_font_entity_to_list): Fix logic errors in mixed boolean and
4755 bitwise arithmetic preventing use of unicode-sip and non-truetype
4758 2011-11-05 Eli Zaretskii <eliz@gnu.org>
4760 * s/ms-w32.h (fstat, stat, utime): Move redirections to
4763 * w32fns.c (x_create_tip_frame, Fx_create_frame): Rearrange
4764 initialization code to keep similarity to xfns.c after changes
4767 2011-11-05 Jan Djärv <jan.h.d@swipnet.se>
4769 * nsfns.m: Declare image_cache_refcount if GLYPH_DEBUG.
4770 (unwind_create_frame): New function (Bug#9943).
4771 (Fx_create_frame): Restructure code to be more similar to the one in
4772 xfns.c. Call record_unwind_protect with unwind_create_frame (Bug#9943).
4773 Initialize image_cache_refcount if GLYPH_DEBUG (Bug#9943).
4774 Move terminal->reference_count++ just before making the frame official
4777 * nsterm.m (x_free_frame_resources): New function.
4778 (x_destroy_window): Move code to x_free_frame_resources.
4780 * xfns.c (unwind_create_frame): Fix comment.
4781 (Fx_create_frame, x_create_tip_frame):
4782 Move terminal->reference_count++ just before making the frame
4783 official. Move initialization of image_cache_refcount and
4784 dpyinfo_refcount before calling init_frame_faces (Bug#9943).
4786 2011-11-05 Eli Zaretskii <eliz@gnu.org>
4788 Support MSVC build with newer versions of Visual Studio.
4789 * makefile.w32-in (TAGS-gmake): Don't use $(patsubst ...), as
4790 Nmake barfs on that. Use $(OBJ*_c) variables instead, defined on
4793 * lisp.h (ENUM_BF): New macro, for enumerated types in bitfields,
4794 which are not supported by MSVC.
4795 (Lisp_Symbol, Lisp_Misc_Any, Lisp_Marker, Lisp_Misc_Overlay)
4796 (Lisp_Save_Value, Lisp_Free): Use ENUM_BF for enumerated types in
4798 (Lisp_Object) [USE_LISP_UNION_TYPE]: Use ENUM_BF for enumerated
4800 (DEFUN) [_MSC_VER]: Define in a different way for MSVC.
4802 * w32fns.c [_MSC_VER]: DECLARE_HANDLE for any MSVC version.
4804 2011-11-05 Fabrice Popineau <fabrice.popineau@supelec.fr> (tiny change)
4806 Support MSVC build with newer versions of Visual Studio.
4807 * w32.c: Don't include w32api.h for MSVC.
4808 (init_environment) [_MSC_VER]: Call sys_access, not _access.
4810 * s/ms-w32.h <sigset_t, ssize_t> [_MSC_VER]: Typedefs for MSVC.
4811 [_MSC_VER]: Include sys/timeb.h, sys/stat.h, and signal.h.
4812 (fstat, stat, utime) [_MSC_VER]: Redirect to their sys_* cousins.
4813 (malloc, free, realloc, calloc) [_MSC_VER]: Always redirect to the
4815 (alloca) [_MSC_VER]: Define to _alloca.
4817 * lisp.h (DECL_ALIGN) [_MSC_VER]: Define for MSVC.
4819 * regex.c <re_char> [_MSC_VER]: A separate definition for MSVC.
4821 2011-11-04 Eli Zaretskii <eliz@gnu.org>
4823 * xdisp.c (note_mouse_highlight): If either of
4824 previous/next-single-property-change returns nil, treat that as
4825 the beginning or the end of the buffer. (Bug#9955)
4827 2011-11-04 Jan Djärv <jan.h.d@swipnet.se>
4829 * gtkutil.c (xg_make_tool_item): Add callbacks if one of wimage or
4830 label is not null (Bug#9951).
4831 (xg_tool_item_stale_p): Handle the fact that wimage and/or wlbl
4834 2011-11-04 Eli Zaretskii <eliz@gnu.org>
4836 * window.c (Fwindow_body_size): Mention in the doc string that the
4837 return value is in frame's canonical units. (Bug#9949)
4839 2011-11-03 Eli Zaretskii <eliz@gnu.org>
4841 * xdisp.c (note_mouse_highlight): Initialize `area'. (Bug#9947)
4843 * w32fns.c (unwind_create_frame): If needed, free the glyph
4844 matrices of the partially constructed frame. (Bug#9943)
4845 * xfns.c (unwind_create_frame): Likewise.
4847 2011-11-01 Eli Zaretskii <eliz@gnu.org>
4849 * xdisp.c (mouse_face_from_buffer_pos): Fix a typo in a comment.
4850 Don't stop backward scan on the continuation glyph, even though
4851 its CHARPOS is positive.
4852 (mouse_face_from_buffer_pos, note_mouse_highlight):
4853 Rename cover_string to disp_string.
4855 2011-11-01 Martin Rudalics <rudalics@gmx.at>
4857 * window.c (temp_output_buffer_show): Don't use
4858 Vtemp_buffer_show_specifiers.
4859 (Vtemp_buffer_show_specifiers): Remove unused variable.
4861 2011-10-30 Eli Zaretskii <eliz@gnu.org>
4863 * xdisp.c (try_cursor_movement): Make sure ROW isn't decremented
4864 past the beginning of the current glyph matrix.
4866 2011-10-30 Adam Sjøgren <asjo@koldfront.dk> (tiny change)
4868 * xterm.c: Include X11/Xproto.h if HAVE_GTK3.
4869 (x_error_handler): Ignore BadMatch for X_SetInputFocus for
4870 HAVE_GTK3 (Bug#9869).
4872 * gtkutil.c (xg_win_to_widget, xg_event_is_for_menubar): Initialize
4873 type to GDK_NOTHING so valgrind does not complain (Bug#9901).
4875 * xterm.h (x_display_info): Add Xatom_net_wm_state_hidden (Bug#9893).
4877 * xterm.c: Declare x_handle_net_wm_state to return int.
4878 (handle_one_xevent): Check if we are iconified but don't have
4879 _NET_WM_STATE_HIDDEN. If do, treat as deiconify (Bug#9893).
4880 (get_current_wm_state): Return non-zero if not hidden,
4881 check for _NET_WM_STATE_HIDDEN (Bug#9893).
4882 (do_ewmh_fullscreen): Ignore return value from get_current_wm_state.
4883 (x_handle_net_wm_state): Return what get_current_wm_state returns.
4884 (x_term_init): Initialize dpyinfo->Xatom_net_wm_state_hidden.
4886 2011-10-29 Paul Eggert <eggert@cs.ucla.edu>
4888 * alloc.c (which_symbols): Declare EXTERNALLY_VISIBLE,
4889 so that this new function doesn't get optimized away by a
4890 whole-program optimizer. Make the 2nd arg EMACS_INT, not int.
4892 2011-10-29 Andreas Schwab <schwab@linux-m68k.org>
4894 * frame.h (MOUSE_HL_INFO): Remove excess parens.
4896 2011-10-29 Eli Zaretskii <eliz@gnu.org>
4898 Fix the `xbytecode' command.
4899 * .gdbinit (xprintbytestr): New command.
4900 (xwhichsymbols): Rename from `which'; all callers changed.
4901 (xbytecode): Print the byte-code string as well.
4903 2011-10-29 Kim Storm <storm@cua.dk>
4905 * alloc.c (which_symbols): New function.
4907 2011-10-29 Andreas Schwab <schwab@linux-m68k.org>
4909 * minibuf.c (read_minibuf_noninteractive): Allow reading empty
4912 2011-10-29 Glenn Morris <rgm@gnu.org>
4914 * process.c (wait_reading_process_output): Revert 2009-08-30 change.
4915 Not clear what it was for, and it causes various bugs. (Bug#9839)
4917 2011-10-28 Eli Zaretskii <eliz@gnu.org>
4919 * xdisp.c (note_mouse_highlight): Initialize `part', to avoid a
4920 possible random value that matches one of those tested as
4921 condition to clear the mouse face.
4923 2011-10-28 Chong Yidong <cyd@gnu.org>
4925 * xdisp.c (note_mouse_highlight): Fix use of uninitialized var.
4927 2011-10-28 Dan Nicolaescu <dann@ics.uci.edu>
4929 * window.c (make_window): Initialize phys_cursor_on_p.
4931 2011-10-28 Stefan Monnier <monnier@iro.umontreal.ca>
4933 * lisp.h (struct Lisp_Symbol): Update comments.
4935 2011-10-28 Juanma Barranquero <lekktu@gmail.com>
4937 * w32font.c (w32_load_unicows_or_gdi32): Add missing return.
4939 2011-10-28 Eli Zaretskii <eliz@gnu.org>
4941 Fix Emacs on Windows 9X (bug#8562). Thanks to oslsachem
4942 <oslsachem@gmail.com> for helping to debug this.
4944 * w32font.c (g_b_init_is_w9x, g_b_init_get_outline_metrics_w)
4945 (g_b_init_get_text_metrics_w, g_b_init_get_glyph_outline_w)
4946 (g_b_init_get_glyph_outline_w): New static variables.
4947 (GetOutlineTextMetricsW_Proc, GetTextMetricsW_Proc)
4948 (GetGlyphOutlineW_Proc): New typedefs.
4949 (w32_load_unicows_or_gdi32, get_outline_metrics_w)
4950 (get_text_metrics_w, get_glyph_outline_w, globals_of_w32font):
4952 (w32font_open_internal, compute_metrics):
4953 Call get_outline_metrics_w, get_text_metrics_w, and get_glyph_outline_w
4954 instead of calling the "wide" APIs directly.
4956 * emacs.c (main) [HAVE_NTGUI]: Call globals_of_w32font.
4958 * w32.h (syms_of_w32font): Add prototype.
4960 2011-10-27 Juanma Barranquero <lekktu@gmail.com>
4962 * window.c (Fframe_root_window, Fframe_first_window, Fwindow_end)
4963 (Fframe_selected_window, Ftemp_output_buffer_show, Fnext_window)
4964 (Fdelete_window_internal, Fwindow_parameters): Fix typos in docstrings.
4965 (Fmove_to_window_line): Doc fix.
4967 2011-10-27 Chong Yidong <cyd@gnu.org>
4969 * process.c (make_process): Set gnutls_state to NULL.
4971 * gnutls.c (emacs_gnutls_deinit): Deinit the gnutls_state if it is
4972 non-NULL, regardless of GNUTLS_INITSTAGE.
4973 (Fgnutls_boot): Cleanups. Call emacs_gnutls_deinit if we signal
4974 an error. Set process slots as soon as we allocate them.
4976 * gnutls.h (GNUTLS_LOG, GNUTLS_LOG2): Fix macros.
4978 2011-10-27 Chong Yidong <cyd@gnu.org>
4980 * gnutls.c (emacs_gnutls_deinit): New function.
4981 Deallocate credentials structures as well as calling gnutls_deinit.
4982 (Fgnutls_deinit, Fgnutls_boot): Use it.
4984 * process.c (make_process): Initialize GnuTLS credentials to NULL.
4985 (deactivate_process): Call emacs_gnutls_deinit.
4987 2011-10-27 Juanma Barranquero <lekktu@gmail.com>
4989 * image.c (x_create_x_image_and_pixmap):
4990 * w32.c (sys_rename, w32_delayed_load):
4991 * w32font.c (fill_in_logfont):
4992 * w32reg.c (x_get_string_resource): Silence compiler warnings.
4994 2011-10-26 Juanma Barranquero <lekktu@gmail.com>
4996 * w32fns.c (w32_default_color_map): New function,
4997 extracted from Fw32_default_color_map.
4998 (Fw32_default_color_map, Fx_open_connection): Use it. (Bug#9785)
5000 2011-10-25 Paul Eggert <eggert@cs.ucla.edu>
5002 * dispextern.h (Fcontrolling_tty_p): New decl (Bug#6649 part 2).
5004 2011-10-25 Stefan Monnier <monnier@iro.umontreal.ca>
5006 * keyboard.c (test_undefined): New function (bug#9751).
5007 (read_key_sequence): Use it to detect when a key is bound to `undefined'.
5009 2011-10-25 Enami Tsugutomo <tsugutomo.enami@jp.sony.com>
5011 * sysdep.c (init_sys_modes): Fix the check for the controlling
5012 terminal (Bug#6649).
5014 2011-10-20 Eli Zaretskii <eliz@gnu.org>
5016 * dispextern.h (struct bidi_it): New member next_en_type.
5018 * bidi.c (bidi_line_init): Initialize the next_en_type member.
5019 (bidi_resolve_explicit_1): When next_en_pos is valid for the
5020 current character, check also for next_en_type being WEAK_EN.
5021 (bidi_resolve_weak): Don't enter the expensive loop if the current
5022 position is before next_en_pos. Record the bidi type of the first
5023 non-ET, non-BN character we find, in addition to its position.
5024 (bidi_level_of_next_char): Invalidate next_en_type when
5025 next_en_pos is over-stepped.
5027 2011-10-20 Paul Eggert <eggert@cs.ucla.edu>
5029 Time zone name fixes for non-ASCII locales (Bug#641, Bug#9794)
5030 * editfns.c: Rewrite current-time-zone so that it invokes
5031 the equivalent of (format-time-string "%Z") to get the time zone name.
5032 This fixes a bug when the time zone name contains characters that
5033 need converting from the system time locale to Emacs internal format.
5034 This fixes a shortcoming that I introduced in my 1999-10-19 patch:
5035 that patch fixed format-time-string to do the conversion, but
5036 I forgot to fix current-time-zone.
5037 (format_time_string): New function, containing most of
5038 what Fformat_time_string used to contain.
5039 (Fformat_time_string): Rewrite in terms of format_time_string.
5040 This doesn't change this function's behavior.
5041 (current-time-zone): Rewrite to use format_time_string.
5042 This fixes the bug reported by Michael Schierl in
5043 <http://lists.gnu.org/archive/html/emacs-devel/2007-06/msg00334.html>.
5044 Jason Rumney's 2007-06-07 change worked around this bug, but
5046 * systime.h (tzname, timezone): Remove no-longer-used declarations.
5048 2011-10-19 Eli Zaretskii <eliz@gnu.org>
5050 * xdisp.c (start_display): If the character at POS is displayed
5051 via a display vector, reset IT->current.dpvec_index to zero.
5052 (try_window_reusing_current_matrix): If a line ends in a display
5053 vector or the next line starts in a display vector, continue
5054 redrawing the window even though the character position of
5055 start_row was reached.
5058 2011-10-18 Chong Yidong <cyd@gnu.org>
5060 * xdisp.c (get_next_display_element): Handle U+2010 and U+2011
5061 with nobreak-char-display too.
5063 2011-10-18 Eli Zaretskii <eliz@gnu.org>
5065 Fix part 3 of bug#9771.
5066 * bidi.c (bidi_line_init): Initialize next_en_pos to zero, not -1.
5067 (bidi_resolve_neutral): Don't enter the expensive loop looking for
5068 non-neutral characters if the current character is a paragraph
5069 separator (a.k.a. Newline). This avoids running the same
5070 expensive loop twice, once when we consume the preceding newline
5071 and the other time when the line actually needs to be displayed.
5072 Avoid the loop when we see neutrals on the base embedding level
5073 following a character whose directionality is the same as the
5074 paragraph's. This avoids running the expensive loop when a line
5075 ends in a long sequence of neutrals, like control characters.
5076 Add assertion against STRONG_AL type. Slightly rearrange code
5077 that determines the type of a neutral given the first non-neutral
5079 (bidi_level_of_next_char): Set next_en_pos to zero when
5080 invalidating its info.
5082 2011-10-17 Eli Zaretskii <eliz@gnu.org>
5084 * xdisp.c (push_display_prop): Determine whether to record string
5085 or buffer position by IT->string, not by IT->method. Allow
5086 GET_FROM_DISPLAY_VECTOR as IT->method on entry. (Bug#9771, part 4)
5087 (move_it_vertically_backward): Don't look for character position
5088 immediately after the newline when in a continuation line.
5091 2011-10-15 Martin Rudalics <rudalics@gmx.at>
5093 * window.c (coordinates_in_window): Rewrite and delabelize
5094 vertical border check. (Bug#5357) (Bug#9618)
5096 2011-10-14 Stefan Monnier <monnier@iro.umontreal.ca>
5098 * xterm.c (frame_highlight, frame_unhighlight): Ignore unexplained
5099 errors in XSetWindowBorder (bug#9310).
5101 2011-10-13 Dmitry Antipov <dmantipov@yandex.ru>
5103 * editfns.c (Fset_time_zone_rule): Replace free with xfree to
5104 avoid crash when xmalloc overrun checking is enabled.
5106 2011-10-13 Eli Zaretskii <eliz@gnu.org>
5108 * xdisp.c (Fcurrent_bidi_paragraph_direction): Initialize
5109 itb.paragraph_dir to NEUTRAL_DIR. Fixes an occasional incorrect
5110 cursor motion with <left> and <right> arrow keys.
5112 * bidi.c (bidi_init_it): Don't initialize paragraph_dir here, as
5113 some callers set that themselves.
5115 2011-10-12 Eli Zaretskii <eliz@gnu.org>
5117 * xdisp.c (find_row_edges): Handle the case where ROW comes from a
5118 display string and the previous row comes from the same string and
5119 is empty. (Bug#9739) (Bug#9738)
5121 2011-10-12 Stefan Monnier <monnier@iro.umontreal.ca>
5123 * doc.c (get_doc_string): Encode file name (bug#9735).
5125 2011-10-12 Eli Zaretskii <eliz@gnu.org>
5127 * bidi.c (bidi_level_of_next_char):
5128 * xdisp.c (get_visually_first_element): Remove old incorrect
5129 comments regarding the Unicode Line Separator character.
5131 * bidi.c (bidi_init_it): Initialize paragraph_dir to NEUTRAL_DIR.
5133 2011-10-12 Dmitry Antipov <dmantipov@yandex.ru>
5135 * alloc.c (Fgc_status): Do not access beyond zombies array
5136 boundary if nzombies > MAX_ZOMBIES.
5137 * alloc.c (dump_zombies): Add missing format specifier.
5139 2011-10-12 Paul Eggert <eggert@cs.ucla.edu>
5141 * xdisp.c (set_cursor_from_row): Simplify conditionals,
5142 to pacify GCC 4.6.1 x86-64 with -O2 -Wstrict-overflow.
5144 * lread.c (read_escape): Allow hex escapes as large as ?\xfffffff.
5145 Some packages use them to denote characters with modifiers.
5147 2011-10-11 Andreas Schwab <schwab@linux-m68k.org>
5149 * lisp.h (GCPRO1_VAR, GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR)
5150 (GCPRO5_VAR, GCPRO6_VAR, UNGCPRO_VAR): Add whitespace to avoid
5151 matching a pp-number. Rename parameter var to var1.
5153 2011-10-11 Stefan Monnier <monnier@iro.umontreal.ca>
5155 * minibuf.c (Finternal_complete_buffer): Fix last change (bug#9709).
5157 2011-10-08 Glenn Morris <rgm@gnu.org>
5159 * callint.c (Fcall_interactively): Give a more explicit error for the
5160 'c' case with a non-character input. (Bug#8479)
5162 2011-10-08 Eli Zaretskii <eliz@gnu.org>
5164 * xdisp.c (hscroll_window_tree): Support hscroll in right-to-left
5166 (set_cursor_from_row): Fix cursor positioning in mixed L2R+R2L
5167 lines that are hscrolled on the left.
5169 * dispnew.c (buffer_posn_from_coords): Account for a possible
5170 presence of header-line. (Bug#4426)
5172 2011-10-07 Stefan Monnier <monnier@iro.umontreal.ca>
5174 * buffer.c (syms_of_buffer) <enable-multibyte-characters>:
5175 Don't advertise functionality which we discourage or doesn't work.
5177 2011-10-07 Paul Eggert <eggert@cs.ucla.edu>
5179 * alloc.c (GC_LISP_OBJECT_ALIGNMENT): Use offsetof, not __alignof__
5180 or sizeof. __alignof__ gives the wrong answer on Fedora x86-64
5181 with GCC 4.6.1 when configured with CC='gcc -m32' --with-wide-int;
5182 this makes Emacs dump core during garbage collection on rare
5183 occasions. sizeof is obviously inferior to offsetof here, so
5184 stick with offsetof.
5185 (GC_POINTER_ALIGNMENT): New macro.
5186 (mark_memory): Omit 3rd (offset) arg; caller changed.
5187 Don't assume EMACS_INT alignment is the same as pointer alignment.
5189 2011-10-03 Stefan Monnier <monnier@iro.umontreal.ca>
5191 * keyboard.c (read_key_sequence_remapped): New var.
5192 (read_key_sequence): Compute remapping in the right buffer.
5193 (command_loop_1): Use read_key_sequence's remapping directly.
5195 2011-10-02 Stefan Monnier <monnier@iro.umontreal.ca>
5197 * dired.c (file_name_completion): Don't expand file name.
5198 (Ffile_name_completion, Ffile_name_all_completions): Expand file name
5199 before checking file name handler.
5201 * minibuf.c (Finternal_complete_buffer): Only show internal buffers if
5202 they've been requested explicitly (bug#9591).
5204 2011-10-01 Andreas Schwab <schwab@linux-m68k.org>
5206 * keymap.c (Fsingle_key_description): Use make_specified_string
5207 instead of build_string to build string from push_key_description.
5210 2011-09-30 Paul Eggert <eggert@cs.ucla.edu>
5212 * buffer.h (struct buffer): Use time_t, not int, for a time stamp.
5213 This fixes a Y2038 bug on 64-bit hosts.
5214 * buffer.c (reset_buffer):
5215 * fileio.c (Fdo_auto_save, Fset_buffer_auto_saved)
5216 (Fclear_buffer_auto_save_failure):
5217 Use 0, not -1, to represent an unset failure time, since time_t
5218 might not be signed.
5220 Remove dependency on glibc malloc internals.
5221 * alloc.c (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
5222 Move back here from lisp.h, but with their new implementations.
5223 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
5224 (XMALLOC_OVERRUN_SIZE_SIZE): Move these new lisp.h macros here.
5225 * charset.c (charset_table_init): New static var.
5226 (syms_of_charset): Use it instead of xmalloc. This removes a
5227 dependency on glibc malloc internals. See Eli Zaretskii's comment in
5228 <http://lists.gnu.org/archive/html/emacs-devel/2011-09/msg00815.html>.
5229 * lisp.h (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
5230 Move back to alloc.c.
5231 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
5232 (XMALLOC_OVERRUN_SIZE_SIZE): Move to alloc.c.
5234 2011-09-30 Jan Djärv <jan.h.d@swipnet.se>
5236 * nsterm.m (windowDidResize): Call x_set_window_size only when
5237 ns_in_resize is true. Otherwise set pixelwidth/height and
5238 call change_frame_size (Bug#9628).
5240 2011-09-30 Paul Eggert <eggert@cs.ucla.edu>
5242 Port --enable-checking=all to Fedora 14 x86-64.
5243 * charset.c (syms_of_charset): Also account for glibc malloc's
5244 internal overhead when calculating the initial malloc maximum.
5246 Port --enable-checking=all to Fedora 14 x86.
5247 * alloc.c (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
5249 (xmalloc_put_size, xmalloc_get_size, overrun_check_malloc)
5250 (overrun_check_realloc, overrun_check_free):
5251 Use XMALLOC_OVERRUN_SIZE_SIZE, not sizeof (size_t).
5252 That way, xmalloc returns a properly-aligned pointer even if
5253 XMALLOC_OVERRUN_CHECK is defined. The old debugging code happened
5254 to align OK on typical 64-bit hosts, but not on Fedora 14 x86.
5255 * charset.c (syms_of_charset): Take XMALLOC_OVERRUN_CHECK_OVERHEAD
5256 into account when calculating the initial malloc maximum.
5257 * lisp.h (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
5258 Move here from alloc.c, so that charset.c can use it too.
5259 Properly align; the old code wasn't right for common 32-bit hosts
5260 when configured with --enable-checking=all.
5261 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
5262 (XMALLOC_OVERRUN_SIZE_SIZE): New macros.
5264 2011-09-29 Eli Zaretskii <eliz@gnu.org>
5266 * sysdep.c (snprintf) [!EOVERFLOW]: If EOVERFLOW is not defined,
5269 2011-09-28 Eli Zaretskii <eliz@gnu.org>
5271 * xdisp.c (compute_display_string_end): If there's no display
5272 string at CHARPOS, return -1.
5274 * bidi.c (bidi_fetch_char): When compute_display_string_end
5275 returns a negative value, treat the character as a normal
5276 character not covered by a display string. (Bug#9624)
5278 2011-09-28 Juanma Barranquero <lekktu@gmail.com>
5280 * lread.c (Fread_from_string): Fix typo in docstring.
5282 2011-09-27 Eli Zaretskii <eliz@gnu.org>
5284 * xdisp.c (handle_invisible_prop): If invisible text ends on a
5285 newline, reseat the iterator instead of bidi-iterating there one
5286 character at a time. (Bug#9610)
5287 (BUFFER_POS_REACHED_P, move_it_in_display_line_to): Bail when past
5288 TO_CHARPOS if the bidi iterator is at base embedding level.
5290 2011-09-27 Andreas Schwab <schwab@linux-m68k.org>
5292 * lread.c (readevalloop): Use correct code for NBSP.
5293 (read1): Likewise. (Bug#9608)
5295 2011-09-25 Michael Albinus <michael.albinus@gmx.de>
5297 * dbusbind.c (Fdbus_register_signal): When service is not
5298 registered, use nil in Vdbus_registered_objects_table. (Bug#9581)
5300 2011-09-25 Glenn Morris <rgm@gnu.org>
5302 * buffer.c (truncate-lines): Doc fix.
5304 2011-09-24 Chong Yidong <cyd@stupidchicken.com>
5306 * window.c (Fwindow_prev_buffers, Fset_window_prev_buffers)
5307 (Fset_window_next_buffers): Doc fix.
5309 2011-09-24 Glenn Morris <rgm@gnu.org>
5311 * minibuf.c (read_minibuf): Disable line truncation. (Bug#5715)
5313 2011-09-24 Paul Eggert <eggert@cs.ucla.edu>
5315 Fix minor problems found by static checking.
5316 * xdisp.c (string_from_display_spec): Don't assume vecsize fits in int.
5317 * indent.c (Fvertical_motion): Fix == vs = typo.
5319 2011-09-24 Eli Zaretskii <eliz@gnu.org>
5321 * dispnew.c (syms_of_display) <redisplay-dont-pause>:
5322 Default value is now t. Doc fix.
5324 * indent.c (Fvertical_motion): Compute and apply the overshoot
5325 logic when moving up, not only when moving down. Fix the
5326 confusing name and values of the it_overshoot_expected variable;
5327 logic changes accordingly. (Bug#9254) (Bug#9549)
5329 * xdisp.c (pos_visible_p): Produce correct pixel coordinates when
5330 CHARPOS is covered by a display string which includes newlines.
5331 (move_it_vertically_backward): Avoid inflooping when START_CHARPOS
5332 is covered by a display string with embedded newlines.
5334 2011-09-24 Michael Albinus <michael.albinus@gmx.de>
5336 * dbusbind.c (Fdbus_register_signal): Add match rule to
5337 Vdbus_registered_objects_table. (Bug#9581)
5338 (Fdbus_register_method, Vdbus_registered_objects_table):
5341 2011-09-24 Jim Meyering <meyering@redhat.com>
5343 do not ignore write error for any output size
5344 The previous change was incomplete.
5345 While it makes emacs --batch detect the vast majority of stdout
5346 write failures, errors were still ignored whenever the output size is
5347 k * (BUFSIZ+1) - 4. E.g., on a system with BUFSIZ of 4096,
5348 $ emacs --batch --eval '(print (format "%4093d" 0))' > /dev/full \
5349 && echo FAIL: ignored write error
5350 FAIL: ignored write error
5351 $ emacs --batch --eval '(print (format "%20481d" 0))' > /dev/full \
5352 && echo FAIL: ignored write error
5353 FAIL: ignored write error
5354 * emacs.c (Fkill_emacs): Also test ferror. (Bug#9574)
5356 2011-09-23 Andreas Schwab <schwab@linux-m68k.org>
5358 * emacs.c (Fkill_emacs): In noninteractive mode exit
5359 non-successfully if a write error occurred on stdout. (Bug#9574)
5361 2011-09-21 Eli Zaretskii <eliz@gnu.org>
5363 * xdisp.c (pop_it): Allow it->object that is a cons cell to pass
5366 * dispextern.h (struct it): Update the comment documenting what
5369 2011-09-20 Eli Zaretskii <eliz@gnu.org>
5371 * xdisp.c (set_cursor_from_row): If the row ends in a newline from
5372 a display string, extend search for cursor position to end of row.
5373 (find_row_edges): If the row ends in a newline from a display
5374 string, increment its MATRIX_ROW_END_CHARPOS by one. (Bug#9549)
5375 Handle the case of a display string with multiple newlines.
5376 (Fcurrent_bidi_paragraph_direction): Fix search for previous
5377 non-empty line. Fixes confusing cursor motion with arrow keys at
5378 the beginning of a line that starts with whitespace.
5380 2011-09-19 Lars Magne Ingebrigtsen <larsi@gnus.org>
5382 * lread.c (Fread_from_string): Document what FINAL-STRING-INDEX is
5385 2011-09-18 Chong Yidong <cyd@stupidchicken.com>
5387 * xfns.c (Fx_create_frame): Handle the bitmapIcon resource as
5390 2011-09-18 Eli Zaretskii <eliz@gnu.org>
5392 * xdisp.c (display_line): Record maximum and minimum buffer
5393 positions even if no glyphs were produced (e.g., by a zero-width
5394 stretch). Fixes bug#9530 on a TTY. Under word-wrap, don't record
5395 buffer positions that will be removed from the glyph row because
5397 (produce_stretch_glyph): Fix a bug in :align-to on a TTY when the
5398 column is beyond frame width: don't subtract 1 "pixel" when
5399 computing width of the stretch.
5400 (reseat_at_next_visible_line_start): Undo the change made on
5401 2011-09-17 that saved paragraph information and restored it after
5402 the call to `reseat'. (Bug#9545)
5404 2011-09-18 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
5406 * xdisp.c (expose_window): Save original value of phys_cursor_on_p
5407 and turn window cursor on if cleared (Bug#9415).
5409 2011-09-18 Andreas Schwab <schwab@linux-m68k.org>
5411 * search.c (boyer_moore): Take unibyte characters from pattern
5412 literally. (Bug#9458)
5414 2011-09-18 Eli Zaretskii <eliz@gnu.org>
5416 * xdisp.c (reseat_at_next_visible_line_start): Fix last change.
5418 2011-09-18 Paul Eggert <eggert@cs.ucla.edu>
5420 Fix minor problem found by static checking.
5421 * xdisp.c (reseat_at_next_visible_line_start): Mark locals as
5422 initialized, to pacify gcc -Wuninitialized.
5424 * fileio.c: Report proper errno when syscall falls.
5425 (Finsert_file_contents): Save and restore errno,
5426 so that report_file_error outputs the correct diagnostic.
5427 (Fwrite_region) [CLASH_DETECTION]: Likewise.
5429 2011-09-18 Eli Zaretskii <eliz@gnu.org>
5431 * .gdbinit (pgx): Fix references to fields of `struct glyph'.
5433 2011-09-17 Eli Zaretskii <eliz@gnu.org>
5435 * xdisp.c (produce_stretch_glyph): Another fix for changes made on
5436 2011-08-30T17:32:44Z!eliz@gnu.org. (Bug#9530)
5438 2011-09-17 Eli Zaretskii <eliz@gnu.org>
5440 * xdisp.c (reseat_at_next_visible_line_start): Keep information
5441 about the current paragraph and restore it after the call to reseat.
5443 * bidi.c (MAX_PARAGRAPH_SEARCH): New macro.
5444 (bidi_find_paragraph_start): Search back for paragraph beginning
5445 at most MAX_PARAGRAPH_SEARCH lines; if not found, return BEGV_BYTE.
5446 (bidi_move_to_visually_next): Only trigger paragraph-related
5447 computations when the last character is a newline or at EOB, not
5448 just any NEUTRAL_B. (Bug#9470)
5450 * xdisp.c (set_cursor_from_row): Don't invoke special treatment of
5451 truncated lines if point is covered by a display string. (Bug#9524)
5453 2011-09-16 Paul Eggert <eggert@cs.ucla.edu>
5455 * xselect.c: Relax test for outgoing X longs (Bug#9498).
5456 (cons_to_x_long): New function.
5457 (lisp_data_to_selection_data): Use it. Correct the test for
5458 short-versus-long data; it was negated. Break out of vector
5459 loop, for efficiency, when a long datum is discovered.
5461 2011-09-16 Stefan Monnier <monnier@iro.umontreal.ca>
5463 * eval.c (Fquote): Document its non-consing behavior (bug#9482).
5465 2011-09-16 Eli Zaretskii <eliz@gnu.org>
5467 * image.c (tiff_handler): Work around a bug in MinGW GCC 3.x (see
5468 GCC PR/17406) by declaring this function with external scope.
5470 2011-09-15 Paul Eggert <eggert@cs.ucla.edu>
5472 * editfns.c (Fformat): Fix bug in text-property fix (Bug#9514).
5473 Don't mishandle (length (format "%%")) and (format "%4000s%%" "").
5475 2011-09-15 Andreas Schwab <schwab@linux-m68k.org>
5477 * editfns.c (Fformat): Correctly handle text properties on "%%".
5479 2011-09-15 Eli Zaretskii <eliz@gnu.org>
5481 * xterm.c (x_draw_composite_glyph_string_foreground):
5482 * w32term.c (x_draw_composite_glyph_string_foreground):
5483 * term.c (encode_terminal_code):
5484 * composite.c (composition_update_it, get_composition_id):
5485 * xdisp.c (get_next_display_element)
5486 (fill_composite_glyph_string): Add comments about special meaning
5487 of TAB characters in a composition.
5489 2011-09-15 Paul Eggert <eggert@cs.ucla.edu>
5491 * editfns.c (Fformat): Fix off-by-1 bug for "%%b" (Bug#9514).
5492 This occurs when processing a multibyte format.
5493 Problem reported by Wolfgang Jenker.
5495 2011-09-15 Johan Bockgård <bojohan@gnu.org>
5497 * xdisp.c (try_cursor_movement): Only check for exact match if
5498 cursor hpos found by set_cursor_from_row is valid. (Bug#9495)
5500 2011-09-14 Paul Eggert <eggert@cs.ucla.edu>
5502 Remove unused external symbols.
5503 * dispextern.h (calc_pixel_width_or_height): Remove decl.
5504 * xdisp.c (calc_pixel_width_or_height): Now static.
5505 * doprnt.c (exprintf) [! (HAVE_X_WINDOWS && USE_X_TOOLKIT)]: Remove.
5506 * indent.c (check_display_width):
5507 * w32term.c: Fix comment to match code.
5508 * xterm.c, xterm.h (x_catching_errors): Remove.
5510 2011-09-14 Paul Eggert <eggert@cs.ucla.edu>
5512 * xselect.c: Use signed conversions more consistently (Bug#9498).
5513 (selection_data_to_lisp_data): Assume incoming selection data are
5514 signed integers, not unsigned. This is to be consistent with
5515 outgoing selection data, which was modified to use signed integers
5516 in as part of the fix to Bug#9196 in response to Jan D.'s comment
5517 in <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9196#32> that X11
5518 expects long, not unsigned long.
5520 2011-09-14 Eli Zaretskii <eliz@gnu.org>
5522 * xdisp.c (try_window_reusing_current_matrix): Fix incorrect
5523 computation of loop end. Reported by Johan Bockgård
5526 2011-09-13 Chong Yidong <cyd@stupidchicken.com>
5528 * frame.c (Fother_visible_frames_p): Function deleted.
5530 2011-09-12 Eli Zaretskii <eliz@gnu.org>
5532 * indent.c (compute_motion): Process display vector front to back
5533 rather than the other way around. (Bug#2496)
5535 2011-09-12 Stefan Monnier <monnier@iro.umontreal.ca>
5537 * fileio.c (Finsert_file_contents): Don't assume beg_offset is 0.
5539 2011-09-11 Chong Yidong <cyd@stupidchicken.com>
5541 * minibuf.c (Fread_from_minibuffer): Doc fix.
5543 2011-09-11 Eli Zaretskii <eliz@gnu.org>
5545 * xdisp.c (produce_stretch_glyph): Fix a typo made in changes from
5546 2011-08-30T17:32:44Z!eliz@gnu.org. (Bug#9475)
5548 2011-09-11 Lars Magne Ingebrigtsen <larsi@gnus.org>
5550 * fileio.c (Fvisited_file_modtime): Document `(-1 65535)' as a
5551 value for non-existent files.
5553 2011-09-11 Eli Zaretskii <eliz@gnu.org>
5555 * fileio.c (Finsert_file_contents): If the file cannot be opened,
5556 set its "size" to -1. This will set the modtime_size field of
5557 the corresponding buffer to -1, which is what
5558 verify-visited-file-modtime expects for files that do not exist.
5561 2011-09-11 Paul Eggert <eggert@cs.ucla.edu>
5563 * keymap.h (KEY_DESCRIPTION_SIZE, push_key_description): Move decls
5565 * lisp.h: ... from here. push_key_description is no longer
5566 defined in keyboard.c, so its declaration should not be in
5567 lisp.h's "Defined in keyboard.c" section, and KEY_DESCRIPTION_SIZE
5568 logically belongs with push_key_description.
5570 2011-09-10 Paul Eggert <eggert@cs.ucla.edu>
5572 * buffer.h: Include <sys/types.h> instead of <time.h>.
5573 Otherwise, off_t wasn't defined on FreeBSD 9.0-BETA2 i386.
5574 Problem reported by Herbert J. Skuhra.
5576 2011-09-10 Lars Magne Ingebrigtsen <larsi@gnus.org>
5578 * xml.c (parse_region): Make the parsing work for
5579 non-comment-starting XML files again (bug#9144).
5581 2011-09-10 Andreas Schwab <schwab@linux-m68k.org>
5583 * image.c (gif_load): Fix calculation of bottom and right corner.
5586 2011-09-10 Eli Zaretskii <eliz@gnu.org>
5588 * xdisp.c (MAX_DISP_SCAN): Decrease to 250. Prevents sluggish
5589 redisplay in small windows.
5591 2011-09-09 Eli Zaretskii <eliz@gnu.org>
5593 * frame.c (x_report_frame_params): Cast to avoid compiler warnings.
5595 2011-09-08 Martin Rudalics <rudalics@gmx.at>
5597 * window.c (Fset_window_prev_buffers, Fset_window_next_buffers):
5598 Operate on live windows only.
5600 2011-09-08 Juanma Barranquero <lekktu@gmail.com>
5602 * emacs.c (my_heap_start): #ifdef to avoid warnings when unused.
5604 2011-09-07 Eli Zaretskii <eliz@gnu.org>
5606 * xdisp.c (move_it_in_display_line_to): Call RESTORE_IT on ppos_it
5607 only under bidi iteration.
5609 2011-09-07 Jan Djärv <jan.h.d@swipnet.se>
5611 * gtkutil.c (xg_make_tool_item): Insert comment about eventbox.
5613 2011-09-06 Paul Eggert <eggert@cs.ucla.edu>
5615 isnan: Fix porting problem to Solaris 10 with bundled gcc.
5616 Without this fix, the command to link temacs failed due to an
5617 undefined symbol __builtin_isnan. This is because
5618 /usr/include/iso/math_c99.h #defines isnan(x) to
5619 __builtin_isnan(x), but the bundled gcc, which identifies itself
5620 as gcc 3.4.3 (csl-sol210-3_4-branch+sol_rpath), does not have
5622 * floatfns.c (isnan): #undef, and then #define to a clone of
5624 (Fisnan): Always define, since it's always available now.
5625 (syms_of_floatfns): Always define isnan at the Lisp level.
5627 2011-09-06 Paul Eggert <eggert@cs.ucla.edu>
5629 * Makefile.in (gl-stamp): move-if-change now in build-aux (Bug#9169).
5631 2011-09-06 Paul Eggert <eggert@cs.ucla.edu>
5633 * fileio.c: Fix bugs with large file offsets (Bug#9428).
5634 The previous code assumed that file offsets (off_t values) fit in
5635 EMACS_INT variables, which is not true on typical 32-bit hosts.
5636 The code messed up by falsely reporting buffer overflow in cases
5637 such as (insert-file-contents "big" nil 1 2) into an empty buffer
5638 when "big" contains more than 2**29 bytes, even though this
5639 inserts just one byte and does not overflow the buffer.
5640 (Finsert_file_contents): Store file offsets as off_t
5641 values, not as EMACS_INT values. Check for overflow when
5642 converting between EMACS_INT and off_t. When checking for
5643 buffer overflow or for overlap, take the offsets into account.
5644 Don't use EMACS_INT for small values where int suffices.
5645 When checking for overlap, fix a typo: ZV was used where
5646 ZV_BYTE was intended.
5647 (Fwrite_region): Don't assume off_t fits into 'long'.
5648 * buffer.h (struct buffer.modtime_size): Now off_t, not EMACS_INT.
5650 2011-09-05 Michael Albinus <michael.albinus@gmx.de>
5652 * dbusbind.c (xd_signature_cat): Rename from signature_cat.
5654 2011-09-04 Paul Eggert <eggert@cs.ucla.edu>
5656 sprintf-related integer and memory overflow issues (Bug#9412).
5658 * doprnt.c (doprnt): Support printing ptrdiff_t and intmax_t values.
5659 (esprintf, exprintf, evxprintf): New functions.
5660 * keyboard.c (command_loop_level): Now EMACS_INT, not int.
5661 (cmd_error): Kbd macro iterations count is now EMACS_INT, not int.
5662 (modify_event_symbol): Do not assume that the length of
5663 name_alist_or_stem is safe to alloca and fits in int.
5664 (Fexecute_extended_command): Likewise for function name and binding.
5665 (Frecursion_depth): Wrap around reliably on integer overflow.
5666 * keymap.c (push_key_description): First arg is now EMACS_INT, not int,
5667 since some callers pass EMACS_INT values.
5668 (Fsingle_key_description): Don't crash if symbol name contains more
5669 than MAX_ALLOCA bytes.
5670 * minibuf.c (minibuf_level): Now EMACS_INT, not int.
5671 (get_minibuffer): Arg is now EMACS_INT, not int.
5672 * lisp.h (get_minibuffer, push_key_description): Reflect API changes.
5673 (esprintf, exprintf, evxprintf): New decls.
5674 * window.h (command_loop_level, minibuf_level): Reflect API changes.
5676 * dbusbind.c (signature_cat): New function.
5677 (xd_signature, Fdbus_register_signal):
5678 Do not overrun buffer; instead, report string overflow.
5680 * dispnew.c (add_window_display_history): Don't overrun buffer.
5681 Truncate instead; this is OK since it's just a log.
5683 * editfns.c (Fcurrent_time_zone): Don't overrun buffer
5684 even if the time zone offset is outlandishly large.
5685 Don't mishandle offset == INT_MIN.
5687 * emacs.c (main) [NS_IMPL_COCOA]: Don't overrun buffer
5688 when creating daemon; the previous buffer-overflow check was incorrect.
5690 * eval.c (verror): Simplify by rewriting in terms of evxprintf,
5691 which has the guts of the old verror function.
5693 * filelock.c (lock_file_1, lock_file): Don't blindly alloca long name;
5694 use SAFE_ALLOCA instead. Use esprintf to avoid int-overflow issues.
5696 * font.c: Include <float.h>, for DBL_MAX_10_EXP.
5697 (font_unparse_xlfd): Don't blindly alloca long strings.
5698 Don't assume XINT result fits in int, or that XFLOAT_DATA * 10
5699 fits in int, when using sprintf. Use single snprintf to count
5700 length of string rather than counting it via multiple sprintfs;
5701 that's simpler and more reliable.
5702 (font_unparse_fcname): Use it to avoid sprintf buffer overrun.
5703 (generate_otf_features) [0 && HAVE_LIBOTF]: Use esprintf, not
5704 sprintf, in case result does not fit in int.
5706 * fontset.c (num_auto_fontsets): Now printmax_t, not int.
5707 (fontset_from_font): Print it.
5709 * frame.c (tty_frame_count): Now printmax_t, not int.
5710 (make_terminal_frame, set_term_frame_name): Print it.
5711 (x_report_frame_params): In X, window IDs are unsigned long,
5712 not signed long, so print them as unsigned.
5713 (validate_x_resource_name): Check for implausibly long names,
5714 and don't assume name length fits in 'int'.
5715 (x_get_resource_string): Don't blindly alloca invocation name;
5716 use SAFE_ALLOCA. Use esprintf, not sprintf, in case result does
5719 * gtkutil.c: Include <float.h>, for DBL_MAX_10_EXP.
5720 (xg_check_special_colors, xg_set_geometry):
5721 Make sprintf buffers a bit bigger, to avoid potential buffer overrun.
5723 * lread.c (dir_warning): Don't blindly alloca buffer; use SAFE_ALLOCA.
5724 Use esprintf, not sprintf, in case result does not fit in int.
5726 * macros.c (executing_kbd_macro_iterations): Now EMACS_INT, not int.
5727 (Fend_kbd_macro): Don't mishandle MOST_NEGATIVE_FIXNUM by treating
5728 it as a large positive number.
5729 (Fexecute_kbd_macro): Don't assume repeat count fits in int.
5730 * macros.h (executing_kbd_macro_iterations): Now EMACS_INT, not int.
5732 * nsterm.m ((NSSize)windowWillResize): Use esprintf, not sprintf,
5733 in case result does not fit in int.
5735 * print.c (float_to_string): Detect width overflow more reliably.
5736 (print_object): Make sprintf buffer a bit bigger, to avoid potential
5737 buffer overrun. Don't assume list length fits in 'int'. Treat
5738 print length of 0 as 0, not as infinity; to be consistent with other
5739 uses of print length in this function. Don't overflow print length
5740 index. Don't assume hash table size fits in 'long', or that
5741 vectorlike size fits in 'unsigned long'.
5743 * process.c (make_process): Use printmax_t, not int, to format
5744 process-name gensyms.
5746 * sysdep.c (snprintf) [! HAVE_SNPRINTF]: New function.
5748 * term.c (produce_glyphless_glyph): Make sprintf buffer a bit bigger
5749 to avoid potential buffer overrun.
5751 * xfaces.c (x_update_menu_appearance): Don't overrun buffer
5752 if X resource line is longer than 512 bytes.
5754 * xfns.c (x_window): Make sprintf buffer a bit bigger
5755 to avoid potential buffer overrun.
5757 * xterm.c (x_io_error_quitter): Don't overrun sprintf buffer.
5759 * xterm.h (x_check_errors): Add ATTRIBUTE_FORMAT_PRINTF.
5761 2011-09-04 Paul Eggert <eggert@cs.ucla.edu>
5763 Integer overflow fixes for scrolling, etc.
5764 Without these, Emacs silently mishandles large integers sometimes.
5765 For example, "C-u 4294967297 M-x recenter" was treated as if
5766 it were "C-u 1 M-x recenter" on a typical 64-bit host.
5768 * xdisp.c (try_window_id): Check Emacs fixnum range before
5769 converting to 'int'.
5771 * window.c (window_scroll_line_based, Frecenter):
5772 Check that an Emacs fixnum is in range before assigning it to 'int'.
5773 (Frecenter, Fmove_to_window_line): Use EMACS_INT, not int, for
5774 values converted from Emacs fixnums.
5775 (Frecenter): Don't wrap around a line count if it is out of 'int'
5776 range; instead, treat it as an extreme value.
5777 (Fset_window_configuration, compare_window_configurations):
5778 Use ptrdiff_t, not int, for index that might exceed 2 GiB.
5780 * search.c (Freplace_match): Use ptrdiff_t, not int, for indexes
5781 that can exceed INT_MAX. Check that EMACS_INT value is in range
5782 before assigning it to the (possibly-narrower) index.
5783 (match_limit): Don't assume that a fixnum can fit in 'int'.
5785 * print.c (print_object): Use ptrdiff_t, not int, for index that can
5788 * indent.c (position_indentation): Now takes ptrdiff_t, not int.
5789 (Fvertical_motion): Don't wrap around LINES values that don't fit
5790 in 'int'. Instead, treat them as extreme values. This is good
5791 enough for windows, which can't have more than INT_MAX lines anyway.
5793 2011-09-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
5795 * Require libxml/parser.h to avoid compilation warning.
5797 * emacs.c (shut_down_emacs): Call xmlCleanupParser on shutdown.
5799 * xml.c (parse_region): Don't call xmlCleanupParser after parsing,
5800 since this reportedly can destroy thread storage.
5802 2011-08-30 Chong Yidong <cyd@stupidchicken.com>
5804 * syntax.c (find_defun_start): Update all cache variables if
5805 exiting early (Bug#9401).
5807 2011-08-30 Eli Zaretskii <eliz@gnu.org>
5809 * image.c (x_bitmap_pixmap): Cast to int to avoid compiler warnings.
5811 * xdisp.c (produce_stretch_glyph): No longer static, compiled also
5812 when HAVE_WINDOW_SYSTEM is not defined. Support both GUI and TTY
5813 frames. Call tty_append_glyph in the TTY case. (Bug#9402)
5815 * term.c (tty_append_glyph): New function.
5816 (produce_stretch_glyph): Static function and its prototype deleted.
5818 * dispextern.h (produce_stretch_glyph, tty_append_glyph):
5821 2011-08-29 Paul Eggert <eggert@cs.ucla.edu>
5823 * image.c (parse_image_spec): Check for nonnegative, not for positive,
5824 when checking :margin (Bug#9390).
5825 (IMAGE_NON_NEGATIVE_INTEGER_VALUE_OR_PAIR):
5826 Rename from IMAGE_POSITIVE_INTEGER_VALUE_OR_PAIR,
5827 so that the name doesn't mislead. All uses changed.
5829 2011-08-28 Johan Bockgård <bojohan@gnu.org>
5831 * term.c (init_tty) [HAVE_GPM]: Move mouse settings after
5834 2011-08-27 Eli Zaretskii <eliz@gnu.org>
5836 * xdisp.c (move_it_to): Don't bail out early when reaching
5837 position beyond to_charpos, if we are scanning backwards.
5838 (move_it_vertically_backward): When DY == 0, make sure we get to
5839 the first character in the line after the newline.
5841 2011-08-27 Paul Eggert <eggert@cs.ucla.edu>
5843 * ccl.c: Improve and simplify overflow checking (Bug#9196).
5844 (ccl_driver): Do not generate an out-of-range pointer.
5845 (Fccl_execute_on_string): Remove unnecessary check for
5846 integer overflow, noted by Stefan Monnier in
5847 <http://lists.gnu.org/archive/html/emacs-devel/2011-08/msg00979.html>.
5848 Remove a FIXME that didn't need fixing.
5849 Simplify the newly-introduced buffer reallocation code.
5851 2011-08-27 Juanma Barranquero <lekktu@gmail.com>
5853 * makefile.w32-in ($(BLD)/alloc.$(O)): Depend on lib/verify.h.
5855 2011-08-26 Paul Eggert <eggert@cs.ucla.edu>
5857 Integer and memory overflow issues (Bug#9196).
5859 * doc.c (get_doc_string): Rework so that
5860 get_doc_string_buffer_size is the actual buffer size, rather than
5861 being 1 less than the actual buffer size; this makes xpalloc more
5864 * image.c (x_allocate_bitmap_record, cache_image):
5865 * xselect.c (Fx_register_dnd_atom):
5866 Simplify previous changes by using xpalloc.
5868 * buffer.c (overlay_str_len): Now ptrdiff_t, not EMACS_INT,
5869 since either will do and ptrdiff_t is convenient with xpalloc.
5871 * charset.c (charset_table_size)
5872 (struct charset_sort_data.priority): Now ptrdiff_t.
5873 (charset_compare): Don't overflow if priorities differ greatly.
5874 (Fsort_charsets): Don't assume list length fits in int.
5875 Check for size-calculation overflow when allocating sort data.
5876 (syms_of_charset): Allocate an initial charset table that is
5877 just under 64 KiB, to avoid problems with glibc malloc and mmap.
5879 * cmds.c (internal_self_insert): Check for size-calculation overflow.
5881 * composite.h (struct composition.glyph_len): Now int, not unsigned.
5882 The actual value is always <= INT_MAX, and leaving it unsigned made
5883 overflow checking harder.
5885 * dispextern.h (struct glyph_matrix.rows_allocated)
5886 (struct face_cache.size): Now ptrdiff_t, for convenience in use
5887 with xpalloc. The values are still always <= INT_MAX.
5889 * indent.c (compute_motion): Adjust to region_cache_forward sig change.
5891 * lisp.h (xnmalloc, xnrealloc, xpalloc): New decls.
5892 (SAFE_NALLOCA): New macro.
5894 * region-cache.c (struct boundary.pos, find_cache_boundary)
5895 (move_cache_gap, insert_cache_boundary, delete_cache_boundaries)
5896 (set_cache_region, invalidate_region_cache)
5897 (revalidate_region_cache, know_region_cache, region_cache_forward)
5898 (region_cache_backward, pp_cache):
5899 Use ptrdiff_t, not EMACS_INT, since either will do. This is needed
5900 so that ptrdiff_t * can be passed to xpalloc.
5901 (struct region_cache): Similarly, for gap_start, gap_len, cache_len,
5902 beg_unchanged, end_unchanged, buffer_beg, buffer_end members.
5903 (pp_cache): Don't assume cache_len fits in int.
5904 * region-cache.h: Adjust extern decls to match.
5906 * search.c (scan_buffer, Freplace_match): Use ptrdiff_t, not
5907 EMACS_INT, since either will do, for xpalloc.
5909 * alloc.c: Include verify.h, and check that int fits in ptrdiff_t.
5910 (xnmalloc, xnrealloc, xpalloc): New functions.
5912 * bidi.c (bidi_shelve_header_size): New constant.
5913 (bidi_cache_ensure_space, bidi_shelve_cache): Use it.
5914 (bidi_cache_ensure_space): Avoid integer overflow when allocating.
5916 * bidi.c (bidi_cache_shrink):
5917 * buffer.c (overlays_at, overlays_in, record_overlay_string)
5919 Don't update size of array until after memory allocation succeeds,
5920 because xmalloc/xrealloc may not return.
5921 (struct sortstrlist.bytes): Now ptrdiff_t, as EMACS_INT doesn't help
5922 now that we have proper integer overflow checking.
5923 (record_overlay_string, overlay_strings): Catch overflows when
5924 calculating size of overlay_str_buf.
5926 * callproc.c (Fcall_process): Check for size overflow when
5927 calculating size of args2.
5928 (child_setup): Avoid overflow by using size_t rather than ptrdiff_t.
5929 Normally we prefer signed values, but sticking with ptrdiff_t would
5930 require adding more-complicated checks.
5932 * ccl.c (Fccl_execute_on_string): Check for memory overflow.
5933 Use ptrdiff_t rather than EMACS_INT where ptrdiff_t will do.
5934 Redo buffer-overflow calculations to avoid integer overflow.
5935 Add a FIXME comment where memory seems to be over-allocated.
5937 * character.c (Fstring): Check for size-calculation overflow.
5939 * coding.c (produce_chars): Redo buffer-overflow calculations to avoid
5940 unnecessary integer overflow. Check for size overflow.
5941 (encode_coding_object): Don't update size until xmalloc succeeds.
5943 * composite.c (get_composition_id): Check for overflow in glyph
5944 length calculations.
5946 Integer and memory overflow fixes for display code.
5947 * dispextern.h (struct glyph_pool.nglyphs): Now ptrdiff_t, not int.
5948 * dispnew.c (adjust_glyph_matrix, realloc_glyph_pool)
5949 (scrolling_window): Check for overflow in size calculations.
5950 (line_draw_cost, realloc_glyph_pool, add_row_entry):
5951 Don't assume glyph table len fits in int.
5952 (struct row_entry.bucket, row_entry_pool_size, row_entry_idx)
5953 (row_table_size): Now ptrdiff_t, not int.
5954 (scrolling_window): Avoid overflow in size calculations.
5955 Don't update size until allocation succeeds.
5956 * fns.c (concat): Check for overflow in size calculations.
5957 (next_almost_prime): Verify NEXT_ALMOST_PRIME_LIMIT.
5958 * lisp.h (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): New macros.
5959 (NEXT_ALMOST_PRIME_LIMIT): New constant.
5961 * doc.c (get_doc_string_buffer_size): Now ptrdiff_t, not int.
5962 (get_doc_string): Check for size calculation overflow.
5963 Don't update size until allocation succeeds.
5964 (get_doc_string, Fsubstitute_command_keys): Use ptrdiff_t, not
5965 EMACS_INT, where ptrdiff_t will do.
5966 (Fsubstitute_command_keys): Check for string overflow.
5968 * editfns.c (set_time_zone_rule): Don't assume environment length
5970 (message_length): Now ptrdiff_t, not int.
5971 (Fmessage_box): Don't update size until allocation succeeds.
5972 Don't assume message length fits in int.
5973 (Fformat): Use ptrdiff_t, not EMACS_INT, where ptrdiff_t will do.
5975 * emacs.c (main): Do not reallocate argv, since there is a null at
5976 the end that can be overwritten, and this way there's no need to
5977 worry about size-calculation overflow.
5978 (sort_args): Check for size-calculation overflow.
5980 * eval.c (init_eval_once, grow_specpdl): Don't update size until
5982 (call_debugger, grow_specpdl): Redo calculations to avoid overflow.
5984 * frame.c (set_menu_bar_lines, x_set_frame_parameters)
5985 (x_set_scroll_bar_width, x_figure_window_size):
5986 Check for integer overflow.
5987 (x_set_alpha): Do not assume XINT fits in int.
5989 * frame.h (struct frame): Use int, not EMACS_INT, where int works.
5990 This is for the members text_lines, text_cols, total_lines, total_cols,
5991 where the system imposes an 'int' limit.
5993 * fringe.c (Fdefine_fringe_bitmap):
5994 Don't update size until alloc works.
5996 * ftfont.c (ftfont_get_open_type_spec, setup_otf_gstring)
5997 (ftfont_shape_by_flt): Check for integer overflow in size calculations.
5999 * gtkutil.c (get_utf8_string, xg_store_widget_in_map):
6000 Check for size-calculation overflow.
6001 (get_utf8_string): Use ptrdiff_t, not size_t, where either will
6002 do, as we prefer signed integers.
6003 (id_to_widget.max_size, id_to_widget.used)
6004 (xg_store_widget_in_map, xg_remove_widget_from_map)
6005 (xg_get_widget_from_map, xg_get_scroll_id_for_window)
6006 (xg_remove_scroll_bar, xg_update_scrollbar_pos):
6007 Use and return ptrdiff_t, not int.
6008 (xg_gtk_scroll_destroy): Don't assume ptrdiff_t fits in int.
6009 * gtkutil.h: Change prototypes to match the above.
6011 * image.c (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): Remove; these
6012 are duplicate now that they've been promoted to lisp.h.
6013 (x_allocate_bitmap_record, x_alloc_image_color)
6014 (make_image_cache, cache_image, xpm_load):
6015 Don't update size until alloc is done.
6016 (xpm_load, lookup_rgb_color, lookup_pixel_color, x_to_xcolors)
6018 Check for size calculation overflow.
6019 (ct_colors_allocated_max): New constant.
6020 (x_to_xcolors, x_detect_edges): Reorder multiplicands to avoid
6023 * keyboard.c (read_char, menu_bar_items, tool_bar_items)
6024 (read_char_x_menu_prompt, read_char_minibuf_menu_width)
6025 (read_char_minibuf_menu_prompt, follow_key, read_key_sequence):
6026 Use ptrdiff_t, not int, to count maps.
6027 (read_char_minibuf_menu_prompt): Check for overflow in size
6028 calculations. Don't update size until allocation succeeds.
6029 Redo calculations to avoid overflow.
6030 * keyboard.h: Change prototypes to match the above.
6032 * keymap.c (cmm_size, current_minor_maps): Use ptrdiff_t, not int,
6034 (current_minor_maps): Check for size calculation overflow.
6035 * keymap.h: Change prototypes to match the above.
6037 * lread.c (read1, init_obarray): Don't update size until alloc done.
6039 * macros.c (Fstart_kbd_macro): Don't update size until alloc done.
6040 (store_kbd_macro_char): Reorder multiplicands to avoid overflow.
6042 * nsterm.h (struct ns_color_table.size, struct ns_color_table.avail):
6043 Now ptrdiff_t, not int.
6044 * nsterm.m (ns_index_color): Use ptrdiff_t, not int, for table indexes.
6045 (ns_draw_fringe_bitmap): Rewrite to avoid overflow.
6047 * process.c (Fnetwork_interface_list): Check for overflow
6048 in size calculation.
6050 * region-cache.c (move_cache_gap): Check for size calculation overflow.
6052 * scroll.c (do_line_insertion_deletion_costs): Check for size calc
6053 overflow. Don't bother calling xmalloc when xrealloc will do.
6055 * search.c (Freplace_match): Check for size calculation overflow.
6056 (Fset_match_data): Don't assume list lengths fit in 'int'.
6058 * sysdep.c (system_process_attributes): Use ptrdiff_t, not int,
6059 for command line length. Do not attempt to address one before the
6060 beginning of an array, as that's not portable.
6062 * term.c (max_frame_lines): Remove; unused.
6063 (encode_terminal_src_size, encode_terminal_dst_size): Now ptrdiff_t,
6065 (encode_terminal_code, calculate_costs): Check for size
6066 calculation overflow.
6067 (encode_terminal_code): Use ptrdiff_t, not int, to record glyph
6068 table lengths and related sizes. Don't update size until alloc
6069 done. Redo calculations to avoid overflow.
6070 (calculate_costs): Don't bother calling xmalloc when xrealloc will do.
6072 * termcap.c (tgetent): Use ptrdiff_t, not int, to record results of
6073 subtracting pointers.
6074 (gobble_line): Check for overflow more carefully. Don't update size
6077 * tparam.c (tparam1): Use ptrdiff_t, not int, for sizes.
6078 Don't update size until alloc done.
6079 Redo size calculations to avoid overflow.
6080 Check for size calculation overflow.
6081 (main) [DEBUG]: Fix typo in invoking tparam1.
6083 * xdisp.c (store_mode_line_noprop_char, x_consider_frame_title):
6084 Use ptrdiff_t, not int, for sizes.
6085 (store_mode_line_noprop_char): Don't update size until alloc done.
6087 * xfaces.c (lface_id_to_name_size, Finternal_make_lisp_face):
6088 Use ptrdiff_t, not int, for sizes.
6089 (Finternal_make_lisp_face, cache_face):
6090 Check for size calculation overflow.
6091 (cache_face): Treat size calculation overflows as if they were
6092 memory exhaustion (the usual treatment), rather than aborting.
6094 * xfns.c (x_encode_text, x_set_name_internal)
6095 (Fx_change_window_property): Use ptrdiff_t, not int, to count
6096 sizes, since they can exceed INT_MAX in size. Check for size
6097 calculation overflow.
6099 * xgselect.c (gfds_size): Now ptrdiff_t, for convenience with xpalloc.
6100 (xg_select): Check for size calculation overflow.
6101 Don't update size until alloc done.
6103 * xrdb.c (get_environ_db): Don't assume path length fits in int,
6104 as sprintf is limited to int lengths.
6106 * xselect.c (X_LONG_SIZE, X_SHRT_MAX, X_SHRT_MIN, X_LONG_MAX)
6107 (X_LONG_MIN): New macros.
6108 Use them to make the following changes clearer.
6109 (MAX_SELECTION_QUANTUM): Make the other bounds on this value clearer.
6110 This change doesn't affect the value now, but it may help remind
6111 future maintainers not to raise the value too much later.
6112 (SELECTION_QUANTUM): Remove, replacing with ...
6113 (selection_quantum): ... new function, which avoids overflow.
6115 (struct selection_data.size): Now ptrdiff_t, not int, to avoid
6116 assumption that selection length fits in 'int'.
6117 (x_reply_selection_request, x_handle_selection_request)
6118 (x_get_window_property, receive_incremental_selection)
6119 (x_get_window_property_as_lisp_data, selection_data_to_lisp_data)
6120 (lisp_data_to_selection_data, clean_local_selection_data):
6121 Use ptrdiff_t, not int, to record length of selection.
6122 (x_reply_selection_request, x_get_window_property)
6123 (receive_incremental_selection, x_property_data_to_lisp):
6124 Redo calculations to avoid overflow.
6125 (x_reply_selection_request): When sending hint, ceiling it at
6126 X_LONG_MAX rather than relying on wraparound overflow to send
6128 (x_get_window_property, receive_incremental_selection)
6129 (lisp_data_to_selection_data, x_property_data_to_lisp):
6130 Check for size-calculation overflow.
6131 (x_get_window_property, receive_incremental_selection)
6132 (lisp_data_to_selection_data, Fx_register_dnd_atom):
6133 Don't store size until memory allocation succeeds.
6134 (x_get_window_property): Plug memory leak on memory exhaustion.
6135 Don't double-block input; malloc is safe here. Don't assume 2**34
6136 - 4 fits in unsigned long. Add an xassert to check
6137 XGetWindowProperty overflow. Be more careful about overflow
6138 calculations, and distinguish size from memory overflow better.
6139 (receive_incremental_selection): When tracing, don't assume
6140 unsigned int is less than INT_MAX.
6141 (x_selection_data_to_lisp_data): Remove unnecessary (and in theory
6142 harmful) conversions of unsigned short to int.
6143 (lisp_data_to_selection_data): Don't assume that integers
6144 in the range -65535 through -1 fit in an X unsigned short.
6145 Don't assume that ULONG_MAX == X_ULONG_MAX. Don't store into
6146 result parameters unless successful. Rely on cons_to_unsigned
6147 to report problems with elements; the old code wasn't right anyway.
6148 (x_check_property_data): Check for int overflow; we cannot use
6149 a wider type due to X limits.
6150 (x_handle_dnd_message): Use unsigned int, to avoid int overflow.
6152 * xsmfns.c (smc_save_yourself_CB): Check for size calc overflow.
6154 * xterm.c (x_color_cells, x_send_scrollbar_event, handle_one_xevent)
6155 (x_term_init): Check for size calculation overflow.
6156 (x_color_cells): Don't store size until memory allocation succeeds.
6157 (handle_one_xevent): Use ptrdiff_t, not int, for byte counts.
6158 Don't assume alloca size is less than MAX_ALLOCA.
6159 (x_term_init): Don't assume length fits in int (sprintf is limited
6162 Use ptrdiff_t for composition IDs.
6163 * character.c (lisp_string_width):
6164 * composite.c (composition_table_size, n_compositions)
6165 (get_composition_id, composition_gstring_from_id):
6166 * dispextern.h (struct glyph_string.cmp_id, struct composition_it.id):
6167 * xdisp.c (BUILD_COMPOSITE_GLYPH_STRING):
6168 * window.c (Frecenter):
6169 Use ptrdiff_t, not int, for composition IDs.
6170 * composite.c (get_composition_id): Check for integer overflow.
6171 * composite.h: Adjust prototypes to match the above changes.
6173 Use ptrdiff_t for hash table indexes.
6174 * category.c (hash_get_category_set):
6175 * ccl.c (ccl_driver):
6176 * charset.h (struct charset.hash_index, CHECK_CHARSET_GET_ID):
6177 * coding.c (coding_system_charset_list, detect_coding_system):
6178 * coding.h (struct coding_system.id):
6179 * composite.c (get_composition_id, gstring_lookup_cache):
6180 * fns.c (hash_lookup, hash_put, Fgethash, Fputhash):
6181 * image.c (xpm_get_color_table_h):
6182 * lisp.h (hash_lookup, hash_put):
6183 * minibuf.c (Ftest_completion):
6184 Use ptrdiff_t for hash table indexes, not int (which is too
6185 narrow, on 64-bit hosts) or EMACS_INT (which is too wide, on
6186 32-bit --with-wide-int hosts).
6188 * charset.c (Fdefine_charset_internal): Check for integer overflow.
6189 Add a FIXME comment about memory leaks.
6190 (syms_of_charset): Don't assume xmalloc returns.
6192 Don't assume that stated character widths fit in int.
6193 * character.c (Fchar_width, c_string_width, lisp_string_width):
6194 * character.h (CHAR_WIDTH):
6195 * indent.c (MULTIBYTE_BYTES_WIDTH):
6196 Use sanitize_char_width to avoid undefined and/or bad behavior
6197 with outlandish widths.
6198 * character.h (sanitize_tab_width): Rename from sanitize_width,
6199 now that we have two such functions. All uses changed.
6200 (sanitize_char_width): New inline function.
6202 Don't assume that tab-width fits in int.
6203 * character.h (sanitize_width): New inline function.
6204 (SANE_TAB_WIDTH): New macro.
6205 (ASCII_CHAR_WIDTH): Use it.
6206 * indent.c (sane_tab_width): Remove. All uses replaced by
6207 SANE_TAB_WIDTH (current_buffer).
6208 * xdisp.c (init_iterator): Use SANE_TAB_WIDTH.
6210 * fileio.c: Integer overflow issues with file modes.
6211 (Fset_file_modes, auto_save_1): Don't assume EMACS_INT fits in int.
6213 * charset.c (read_hex): New arg OVERFLOW. All uses changed.
6214 Remove unreachable code.
6215 (read_hex, load_charset_map_from_file): Check for integer overflow.
6217 * xterm.c: Don't go over XClientMessageEvent limit.
6218 (scroll_bar_windows_size): Now ptrdiff_t, as we prefer signed.
6219 (x_send_scroll_bar_event): Likewise. Check that the size does not
6220 exceed limits imposed by XClientMessageEvent, as well as the usual
6221 ptrdiff_t and size_t limits.
6223 * keyboard.c: Overflow, signedness and related fixes.
6224 (make_lispy_movement): Use same integer type in forward decl
6225 that is used in the definition.
6226 (read_key_sequence, keyremap_step):
6227 Change bufsize argument back to int, undoing my 2011-03-30 change.
6228 We prefer signed types, and int is wide enough here.
6229 (parse_tool_bar_item): Don't assume tool_bar_max_label_size is less
6230 than TYPE_MAXIMUM (EMACS_INT) / 2. Don't let the label size grow
6231 larger than STRING_BYTES_BOUND. Use ptrdiff_t for Emacs string
6232 length, not size_t. Use ptrdiff_t for index, not int.
6233 (keyremap_step, read_key_sequence): Redo bufsize check to avoid
6234 possibility of integer overflow.
6236 Overflow, signedness and related fixes for images.
6238 * dispextern.h (struct it.stack[0].u.image.image_id)
6239 (struct_it.image_id, struct image.id, struct image_cache.size)
6240 (struct image_cache.used, struct image_cache.ref_count):
6241 * gtkutil.c (update_frame_tool_bar):
6242 * image.c (x_reference_bitmap, Fimage_size, Fimage_mask_p)
6243 (Fimage_metadata, free_image_cache, clear_image_cache, lookup_image)
6244 (cache_image, mark_image_cache, x_kill_gs_process, Flookup_image):
6245 * nsmenu.m (update_frame_tool_bar):
6246 * xdisp.c (calc_pixel_width_or_height):
6247 * xfns.c (image_cache_refcount):
6248 Image IDs are now ptrdiff_t, not int, to avoid arbitrary limits
6249 on typical 64-bit hosts.
6251 * image.c (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): New macros.
6252 (x_bitmap_pixmap, x_create_x_image_and_pixmap):
6253 Omit unnecessary casts to int.
6254 (parse_image_spec): Check that integers fall into 'int' range
6255 when the callers expect that.
6256 (image_ascent): Redo ascent calculation to avoid int overflow.
6257 (clear_image_cache): Avoid overflow when sqrt (INT_MAX) < nimages.
6258 (lookup_image): Remove unnecessary tests.
6259 (xbm_image_p): Locals are now of int, not EMACS_INT,
6260 since parse_image_check makes sure they fit into int.
6261 (png_load, gif_load, svg_load_image):
6262 Prefer int to unsigned where either will do.
6263 (tiff_handler): New function, combining the cores of the
6264 old tiff_error_handler and tiff_warning_handler.
6265 This function is rewritten to use vsnprintf and thereby avoid
6266 stack buffer overflows. It uses only the features of vsnprintf
6267 that are common to both POSIX and native Microsoft.
6268 (tiff_error_handler, tiff_warning_handler): Use it.
6269 (tiff_load, gif_load, imagemagick_load_image):
6270 Don't assume :index value fits in 'int'.
6271 (gif_load): Omit unnecessary cast to double, and avoid double-rounding.
6272 (imagemagick_load_image): Check that crop parameters fit into
6273 the integer types that MagickCropImage accepts. Don't assume
6274 Vimagemagick_render_type has a nonnegative value. Don't assume
6275 size_t fits in 'long'.
6276 (gs_load): Use printmax_t to print the widest integers possible.
6277 Check for integer overflow when computing image height and width.
6279 2011-08-26 Eli Zaretskii <eliz@gnu.org>
6281 * xdisp.c (redisplay_window): Don't force window start if point
6282 will be invisible in the resulting window. (Bug#9324)
6284 2011-08-25 Eli Zaretskii <eliz@gnu.org>
6286 * xdisp.c (compute_display_string_pos): Return 2 in DISP_PROP when
6287 the display spec is of the form `(space ...)'.
6288 (handle_display_spec): Return the value returned by
6289 handle_single_display_spec, not just 1 or zero.
6290 (handle_single_display_spec): If the display spec is of the form
6291 `(space ...)', and specifies display in the text area, return 2
6293 (try_cursor_movement): Check for the need to scroll more
6294 accurately, and prefer exact match for point under bidi.
6295 Don't advance `row' beyond the last row of the window.
6297 * dispextern.h (struct bidi_it): Rename the disp_prop_p member
6298 into disp_prop; all users changed.
6300 * bidi.c (bidi_fetch_char): If compute_display_string_pos returns
6301 DISP_PROP = 2, substitute the u+2029 PARAGRAPH SEPARATOR character
6302 for the text covered by the display property.
6304 2011-08-25 Chong Yidong <cyd@stupidchicken.com>
6306 * buffer.c (Fbury_buffer_internal): Rename from Funrecord_buffer.
6307 Change return value to nil.
6308 (Frecord_buffer): Delete unused function.
6310 2011-08-24 Eli Zaretskii <eliz@gnu.org>
6312 * xdisp.c (Fcurrent_bidi_paragraph_direction): For unibyte
6313 buffers, return left-to-right.
6314 (set_cursor_from_row): Consider candidate row a win if its glyph
6315 represents a newline and point is on that newline. Fixes cursor
6316 positioning on the newline at EOL of R2L text within L2R
6317 paragraph, and vice versa.
6318 (try_cursor_movement): Check continued rows, in addition to
6319 continuation rows. Fixes unwarranted scroll when point enters a
6320 continued line of R2L text within an L2R paragraph, or vice versa.
6321 (cursor_row_p): Consider the case of point being equal to
6322 MATRIX_ROW_END_CHARPOS. Prevents cursor being stuck when moving
6323 from the end of a short line to the beginning of a continued line
6324 of R2L text within L2R paragraph.
6325 (RECORD_MAX_MIN_POS): For max_pos, use IT_CHARPOS even for
6326 composed characters.
6328 * bidi.c (bidi_check_type): Use xassert.
6329 (bidi_cache_iterator_state): Update the disp_pos and disp_prop_p
6332 2011-08-23 Eli Zaretskii <eliz@gnu.org>
6334 * bidi.c (bidi_get_type): Abort if we get zero as the bidi type of
6337 2011-08-23 Chong Yidong <cyd@stupidchicken.com>
6339 * nsfont.m (ns_otf_to_script): Fix typo.
6341 2011-08-22 Kenichi Handa <handa@m17n.org>
6343 * chartab.c (Fset_char_table_extra_slot): Do not inhibit setting a
6344 extra slot even if the purpose is char-code-property-table.
6346 2011-08-23 Eli Zaretskii <eliz@gnu.org>
6348 * xdisp.c (redisplay_window): When computing centering_position,
6349 account for the height of the header line. (Bug#8874)
6351 * dispnew.c (buffer_posn_from_coords): Use buf_charpos_to_bytepos
6352 instead of CHAR_TO_BYTE. Fixes a crash when a completion
6353 candidate is selected by the mouse, and that candidate has a
6354 composed character under the mouse.
6356 * xdisp.c (x_produce_glyphs): Set it->nglyphs to 1. Fixes pixel
6357 coordinates reported by pos-visible-in-window-p for a composed
6358 character in column zero.
6360 2011-08-23 Stefan Monnier <monnier@iro.umontreal.ca>
6362 * cmds.c (Fself_insert_command): Mention post-self-insert-hook.
6364 2011-08-22 Eli Zaretskii <eliz@gnu.org>
6366 * xdisp.c (BUFFER_POS_REACHED_P): If this is a composition,
6367 consider it a hit if to_charpos is anywhere in the range of the
6368 composed buffer positions.
6370 2011-08-22 Chong Yidong <cyd@stupidchicken.com>
6372 * image.c (gif_load): Don't assume that each subimage has the same
6373 dimensions as the base image. Handle disposal method that is
6374 "undefined" by the gif spec (Bug#9335).
6376 2011-08-20 Chong Yidong <cyd@stupidchicken.com>
6378 * eval.c (Fsignal): Handle `debug' symbol in error handler (Bug#9329).
6379 (Fcondition_case): Document `debug' symbol in error handler.
6381 2011-08-19 Eli Zaretskii <eliz@gnu.org>
6383 * xfaces.c (face_at_buffer_position): Avoid repeated evaluation of
6384 face ID by FACE_FROM_ID, and avoid a crash when mouse is moved
6385 from an Org mode buffer to a Speedbar frame.
6387 * xdisp.c (RECORD_MAX_MIN_POS): If the display element comes from
6388 a composition, take its buffer position from IT->cmp_it.charpos.
6389 Fixes cursor positioning at the beginning of a line that begins
6390 with a composed character.
6392 2011-08-18 Eli Zaretskii <eliz@gnu.org>
6394 * bidi.c (bidi_get_type): If bidi_type_table reports zero as the
6395 character bidirectional type, use STRONG_L instead. Fixes crashes
6396 in a buffer produced by `describe-categories'.
6398 * dispextern.h (struct bidi_it): Move disp_pos and disp_prop_p
6399 members before the level stack, so they would be saved and
6400 restored when copying iterator state. Fixes incorrect reordering
6401 around TABs covered by display properties.
6403 2011-08-18 Andreas Schwab <schwab@linux-m68k.org>
6405 * process.c (Fnetwork_interface_list): Correctly determine buffer size.
6407 2011-08-17 Chong Yidong <cyd@stupidchicken.com>
6409 * eval.c (internal_condition_case, internal_condition_case_1)
6410 (internal_condition_case_2, internal_condition_case_n):
6411 Remove unnecessary aborts (Bug#9081).
6413 2011-08-17 Eli Zaretskii <eliz@gnu.org>
6415 * lread.c (Fload) [DOS_NT]: If `openp' returns -2, but the file
6416 has no `load' handler, try opening the file locally. (Bug#9311)
6418 2011-08-16 Ken Brown <kbrown@cornell.edu>
6420 * gmalloc.c: Expand comment.
6422 2011-08-16 Eli Zaretskii <eliz@gnu.org>
6424 * xdisp.c (set_cursor_from_row): Don't accept a previous candidate
6425 if it fails the cursor_row_p test. Fixes cursor positioning at ZV.
6427 2011-08-16 Ken Brown <kbrown@cornell.edu>
6429 Fix memory allocation problems in Cygwin build (Bug#9273).
6431 * unexcw.c ( __malloc_initialized): Declare external variable.
6432 (fixup_executable): Force the dumped emacs to reinitialize malloc.
6434 * gmalloc.c [CYGWIN] (bss_sbrk_heapbase, bss_sbrk_heapinfo):
6436 (malloc_initialize_1) [CYGWIN]: Prepare for reinitializing the
6438 (_free_internal_nolock) [CYGWIN]: Ignore requests to free storage
6440 [CYGWIN] (special_realloc): New function.
6441 (_realloc_internal_nolock) [CYGWIN]: Use the new function on
6442 requests to realloc storage in the static heap.
6444 2011-08-15 Paul Eggert <eggert@cs.ucla.edu>
6446 * bidi.c (bidi_initialize): Remove unused local.
6448 2011-08-15 Eli Zaretskii <eliz@gnu.org>
6451 * biditype.h: Remove file.
6452 * makefile.w32-in ($(BLD)/bidi.$(O)):
6453 * deps.mk (bidi.o): Remove biditype.h and bidimirror.h.
6455 * dispextern.h: Fix a typo in the comment to bidi_type_t.
6457 * chartab.c: Improve commentary for the uniprop_table API.
6459 * bidi.c (bidi_paragraph_init): Support zero value of
6460 bidi_ignore_explicit_marks_for_paragraph_level.
6461 (bidi_initialize): Use uniprop_table instead of including
6462 biditype.h and bidimirror.h.
6464 * xdisp.c (move_it_in_display_line_to): Don't reset pixel
6465 coordinates of the iterator when restoring from ppos_it.
6468 2011-08-14 Kenichi Handa <handa@m17n.org>
6470 * process.c (create_process): Call setup_process_coding_systems
6471 after the pid of the process is set to -1 (Bug#8162).
6473 2011-08-14 Eli Zaretskii <eliz@gnu.org>
6475 * xdisp.c (move_it_in_display_line_to): Don't invoke
6476 IT_RESET_X_ASCENT_DESCENT when iterator position was restored from
6477 ppos_it. Fixes vertical cursor motion when line beginning is
6478 covered by an image. (Bug#9296)
6480 2011-08-14 Jan Djärv <jan.h.d@swipnet.se>
6482 * nsterm.h (ns_run_ascript): Declare.
6483 (NSAPP_DATA2_RUNASSCRIPT): Define.
6485 * nsfns.m (as_script, as_result, as_status): New static variables.
6486 (ns_run_ascript): New function.
6487 (Fns_do_applescript): Set variables as_*. Make an NSApplicationDefined
6488 event with data2 set to NSAPP_DATA2_RUNASSCRIPT, post it and then start
6489 the event loop. Get status from as_status (Bug#7276).
6491 * nsterm.m (sendEvent): If event is NSApplicationDefined and
6492 data2 is NSAPP_DATA2_RUNASSCRIPT, call ns_run_ascript and then exit
6493 the event loop (Bug#7276).
6495 2011-08-14 Andreas Schwab <schwab@linux-m68k.org>
6497 * gnutls.c (QCgnutls_bootprop_priority)
6498 (QCgnutls_bootprop_trustfiles, QCgnutls_bootprop_keylist)
6499 (QCgnutls_bootprop_crlfiles, QCgnutls_bootprop_callbacks)
6500 (QCgnutls_bootprop_loglevel, QCgnutls_bootprop_hostname)
6501 (QCgnutls_bootprop_min_prime_bits, QCgnutls_bootprop_verify_flags)
6502 (QCgnutls_bootprop_verify_hostname_error)
6503 (QCgnutls_bootprop_callbacks_verify): Rename from
6504 Qgnutls_bootprop_..., all uses changed.
6506 * xfaces.c (QCignore_defface): Rename from Qignore_defface, all
6509 2011-08-14 Paul Eggert <eggert@cs.ucla.edu>
6511 * xfaces.c (Qframe_set_background_mode): Now static.
6512 * dispextern.h (Qframe_set_background_mode): Remove decl.
6514 * process.c (Fnetwork_interface_info): Declare local only if needed.
6516 2011-08-13 Jan Djärv <jan.h.d@swipnet.se>
6518 * process.c: Include ifaddrs.h and net/if_dl.h if available (Bug#8477).
6519 (Fnetwork_interface_list): Allocate in increments of bytes instead
6520 of sizeof (struct ifreq). Iterate over ifconf.ifc_req by counting
6521 bytes (Bug#8477). Count bytes correctly when ifr_addr is a struct
6523 (struct ifflag_def): notrailers is smart on OSX.
6524 (Fnetwork_interface_info): Handle case when ifr_flags is negative.
6525 Get hardware address with getifaddrs if available.
6527 2011-08-12 Eli Zaretskii <eliz@gnu.org>
6529 * xdisp.c (iterate_out_of_display_property): xassert that
6530 IT->position is set to within IT->object's boundaries. Break from
6531 the loop as soon as EOB is reached; avoids infloops in redisplay
6532 when IT->position is set up wrongly due to some bug.
6533 Set IT->current to match the bidi iterator unconditionally.
6534 (push_display_prop): Allow GET_FROM_STRING as IT->method on
6535 entry. Force push_it to save on the stack the current
6536 buffer/string position, to be restored by pop_it. Fix flags in
6537 the iterator structure wrt the object coming from a display
6538 property, as `line-prefix' and `wrap-prefix' are not ``replacing''
6539 properties. (Bug#9284)
6541 2011-08-09 Andreas Schwab <schwab@linux-m68k.org>
6543 * fontset.c (fontset_get_font_group): Add proper type checks.
6546 2011-08-09 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
6548 * unexmacosx.c (print_load_command_name): Add cases LC_FUNCTION_STARTS
6549 and LC_VERSION_MIN_MACOSX.
6550 (copy_linkedit_data) [LC_FUNCTION_STARTS]: New function.
6551 (dump_it) [LC_FUNCTION_STARTS]: Use it.
6553 2011-08-08 Eli Zaretskii <eliz@gnu.org>
6555 * xdisp.c (forward_to_next_line_start): Allow to use the
6556 no-display-properties-and-no-overlays under bidi display.
6557 Set disp_pos in the bidi iterator to avoid searches for display
6558 properties and overlays.
6560 2011-08-08 Chong Yidong <cyd@stupidchicken.com>
6562 * editfns.c (Fset_time_zone_rule): Document relationship with the
6565 * ftfont.c (ftfont_pattern_entity): Copy the extras argument to
6566 the font entity extracted from the cache (Bug#8109).
6568 2011-08-07 Chong Yidong <cyd@stupidchicken.com>
6570 * composite.c (autocmp_chars): Don't reset point. That is done by
6571 restore_point_unwind (Bug#5984).
6573 2011-08-07 Juri Linkov <juri@jurta.org>
6575 * editfns.c (Fformat_time_string): Doc fix, add tag `usage:'
6576 to show the arg `TIME' instead of `TIMEVAL'.
6578 2011-08-06 Eli Zaretskii <eliz@gnu.org>
6580 * xdisp.c (set_cursor_from_row): Fix cursor positioning when a
6581 display property strides EOL and includes a newline, as in
6582 longlines-mode. (Bug#9254)
6583 (move_it_in_display_line_to): Fix vertical-motion in a buffer with
6584 word-wrap under bidirectional display. (Bug#9224)
6586 * bidi.c (bidi_unshelve_cache): Don't reset the cache if JUST_FREE
6587 is non-zero, even if the data buffer is NULL. Fixes a crash in
6588 vertical-motion with longlines-mode. (Bug#9254)
6590 2011-08-05 Eli Zaretskii <eliz@gnu.org>
6592 * bidi.c <bidi_cache_total_alloc>: Now static.
6593 (bidi_initialize): Initialize bidi_cache_total_alloc.
6595 * xdisp.c (display_line): Release buffer allocated for shelved bidi
6598 * bidi.c (bidi_shelve_cache, bidi_unshelve_cache): Track total
6599 amount allocated this far in `bidi_cache_total_alloc'.
6600 (bidi_unshelve_cache): Accept an additional argument JUST_FREE; if
6601 non-zero, only free the data buffer without restoring the cache
6602 contents. All callers changed.
6604 * dispextern.h (bidi_unshelve_cache): Update prototype.
6606 * xdisp.c (SAVE_IT, pos_visible_p, move_it_in_display_line_to)
6607 (move_it_in_display_line, move_it_to)
6608 (move_it_vertically_backward, move_it_by_lines): Replace the call
6609 to xfree to an equivalent call to bidi_unshelve_cache.
6610 (move_it_in_display_line_to): Fix logic of returning
6611 MOVE_POS_MATCH_OR_ZV in the bidi case. (Bug#9224)
6613 2011-08-05 Eli Zaretskii <eliz@gnu.org>
6615 * xdisp.c (set_cursor_from_row): Prefer the candidate glyph that
6616 came from a string character with a `cursor' property. (Bug#9229)
6618 2011-08-04 Jan Djärv <jan.h.d@swipnet.se>
6620 * Makefile.in (LIB_PTHREAD): New variable.
6621 (LIBES): Add LIB_PTHREAD (Bug#9216).
6623 * alloc.c, emacs.c, gmalloc.c, gtkutil.c, keyboard.c, syssignal.h:
6624 Rename HAVE_GTK_AND_PTHREAD to HAVE_PTHREAD (Bug#9216).
6626 2011-08-04 Andreas Schwab <schwab@linux-m68k.org>
6628 * regex.c (re_iswctype): Remove some redundant boolean conversions.
6630 2011-08-04 Jan Djärv <jan.h.d@swipnet.se>
6632 * xterm.c (x_find_topmost_parent): New function.
6633 (x_set_frame_alpha): Find topmost parent window with
6634 x_find_topmost_parent and set the property there also (bug#9181).
6635 (handle_one_xevent): Call x_set_frame_alpha on ReparentNotify.
6637 2011-08-04 Paul Eggert <eggert@cs.ucla.edu>
6639 * callproc.c (Fcall_process): Avoid vfork clobbering
6640 the local vars buffer, coding_systems, current_dir.
6642 2011-08-03 Stefan Monnier <monnier@iro.umontreal.ca>
6644 * keymap.c (Fmake_composed_keymap): Move to subr.el.
6646 2011-08-03 Paul Eggert <eggert@cs.ucla.edu>
6648 * fontset.c (dump_fontset) [FONTSET_DEBUG]: Declare EXTERNALLY_VISIBLE
6649 so that it is not optimized away.
6651 * xdisp.c (compute_display_string_pos): Remove unused local.
6653 2011-08-02 Eli Zaretskii <eliz@gnu.org>
6655 Fix slow cursor motion and scrolling in large buffers with
6656 selective display, like Org Mode buffers. (Bug#9218)
6658 * dispextern.h (struct bidi_it): New member disp_prop_p.
6660 * xdisp.c: Remove one-slot cache of display string positions.
6661 (compute_display_string_pos): Accept an additional argument
6662 DISP_PROP_P; callers changed. Scan at most 5K characters forward
6663 for a display string or property. If found, set DISP_PROP_P
6666 * bidi.c (bidi_fetch_char): Accept an additional argument
6667 DISP_PROP_P, and pass it to compute_display_string_pos.
6668 Only handle text covered by a display string if DISP_PROP_P is returned
6669 non-zero. All callers of bidi_fetch_char changed.
6671 2011-08-02 Stefan Monnier <monnier@iro.umontreal.ca>
6673 * keymap.c (Fdefine_key): Fix Lisp_Object/int mixup; apply some CSE.
6675 2010-12-03 Don March <don@ohspite.net>
6677 * keymap.c (Fdefine_key): Fix non-prefix key error message when
6678 last character M-[char] is translated to ESC [char] (bug#7541).
6680 2011-08-02 Kenichi Handa <handa@m17n.org>
6682 * lisp.h (uniprop_table): Extern it.
6684 * chartab.c (uniprop_table): Make it non-static.
6686 2011-08-01 Eli Zaretskii <eliz@gnu.org>
6688 * xdisp.c (forward_to_next_line_start): Accept additional argument
6689 BIDI_IT_PREV, and store into it the state of the bidi iterator had
6691 (reseat_at_next_visible_line_start): Use the bidi iterator state
6692 returned by forward_to_next_line_start to restore the state of
6693 it->bidi_it after backing up to previous newline. (Bug#9212)
6695 2011-07-30 Andreas Schwab <schwab@linux-m68k.org>
6697 * regex.c (re_comp): Protoize.
6698 (re_exec): Fix return type.
6699 (regexec): Fix type of `ret'. (Bug#9203)
6701 2011-07-28 Paul Eggert <eggert@cs.ucla.edu>
6703 * image.c (check_image_size): Use 1024x1024 if unknown frame (Bug#9189).
6704 This is needed if max-image-size is a floating-point number.
6706 2011-07-28 Andreas Schwab <schwab@linux-m68k.org>
6708 * print.c (print_object): Print empty symbol as ##.
6710 * lread.c (read1): Read ## as empty symbol.
6712 2011-07-28 Alp Aker <alp.tekin.aker@gmail.com>
6714 * nsfns.m (x_set_foreground_color): Set f->foreground_pixel when
6715 setting frame foreground color (Bug#9175).
6716 (x_set_background_color): Likewise.
6718 * nsmenu.m (-setText): Size tooltip dimensions precisely to
6719 contents (Bug#9176).
6720 (EmacsTooltip -init): Remove bezels and add shadows to
6723 * nsterm.m (ns_dumpglyphs_stretch): Avoid overwriting left fringe
6724 or scroll bar (Bug#8470).
6726 * nsfont.m (nsfont_open): Remove assignment to voffset and
6727 unnecessary vars hshink, expand, hd, full_height, min_height.
6728 (nsfont_draw): Use s->ybase as baseline for glyph drawing (Bug#8913).
6730 * nsterm.h (nsfont_info): Remove voffset field.
6732 2011-07-28 Alp Aker <alp.tekin.aker@gmail.com>
6734 Implement strike-through and overline on NextStep (Bug#8863).
6736 * nsfont.m (nsfont_open): Use underline position provided by font,
6737 instead of hard-coded value of 2.
6738 (nsfont_draw): Call ns_draw_text_decoration instead.
6740 * nsterm.h: Add declaration for ns_draw_text_decoration.
6742 * nsterm.m (ns_draw_text_decoration): New function for drawing
6743 underline, overline, and strike-through.
6744 (ns_dumpglyphs_image, ns_dumpglyphs_stretch): Add call to
6745 ns_draw_text_decoration. Change treatment of cursor drawing to
6746 accommodate underlining, etc.
6748 2011-07-28 Eli Zaretskii <eliz@gnu.org>
6750 * buffer.c (init_buffer_once): Set bidi-display-reordering to t by
6753 2011-07-28 Paul Eggert <eggert@cs.ucla.edu>
6755 * alloc.c (memory_full) [!SYNC_INPUT]: Fix signal-related race.
6756 Without this fix, if a signal arrives just after memory fills up,
6757 'malloc' might be invoked reentrantly.
6759 * image.c (x_check_image_size) [!HAVE_X_WINDOWS]: Return 1.
6760 In other words, assume that every image size is allowed, on non-X
6761 hosts. This assumption is probably wrong, but it lets Emacs compile.
6763 2011-07-28 Andreas Schwab <schwab@linux-m68k.org>
6765 * regex.c (re_iswctype): Convert return values to boolean.
6767 2011-07-28 Eli Zaretskii <eliz@fencepost.gnu.org>
6769 * xdisp.c (compute_display_string_pos): Don't use cached display
6770 string position if the buffer had its restriction changed.
6773 2011-07-28 Paul Eggert <eggert@cs.ucla.edu>
6775 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
6777 2011-07-28 Paul Eggert <eggert@cs.ucla.edu>
6779 Integer signedness and overflow and related fixes. (Bug#9079)
6781 * bidi.c: Integer size and overflow fixes.
6782 (bidi_cache_size, bidi_cache_idx, bidi_cache_last_idx)
6783 (bidi_cache_start, bidi_cache_fetch_state, bidi_cache_search)
6784 (bidi_cache_find_level_change, bidi_cache_ensure_space)
6785 (bidi_cache_iterator_state, bidi_cache_find, bidi_cache_start_stack)
6786 (bidi_find_other_level_edge):
6787 Use ptrdiff_t instead of EMACS_INT where either will do.
6788 This works better on 32-bit hosts configured --with-wide-int.
6789 (bidi_cache_ensure_space): Check for size-calculation overflow.
6790 Use % rather than repeated addition, for better worst-case speed.
6791 Don't set bidi_cache_size until after xrealloc returns, because it
6793 (bidi_dump_cached_states): Use ptrdiff_t, not int, to avoid overflow.
6794 (bidi_cache_ensure_space): Also check that the bidi cache size
6795 does not exceed that of the largest Lisp string or buffer. See Eli
6796 Zaretskii in <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9079#29>.
6798 * alloc.c (__malloc_size_t): Remove.
6799 All uses replaced by size_t. See Andreas Schwab's note
6800 <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9079#8>.
6802 * image.c: Improve checking for integer overflow.
6803 (check_image_size): Assume that f is nonnull, since
6804 it is always nonnull in practice. This is one less thing to
6805 worry about when checking for integer overflow later.
6806 (x_check_image_size): New function, which checks for integer
6807 overflow issues inside X.
6808 (x_create_x_image_and_pixmap, xbm_read_bitmap_data): Use it.
6809 This removes the need for a memory_full check.
6810 (xbm_image_p): Rewrite to avoid integer multiplication overflow.
6811 (Create_Pixmap_From_Bitmap_Data, xbm_load): Use x_check_image_size.
6812 (xbm_read_bitmap_data): Change locals back to 'int', since
6813 their values must fit in 'int'.
6814 (xpm_load_image, png_load, tiff_load):
6815 Invoke x_create_x_image_and_pixmap earlier,
6816 to avoid much needless work if the image is too large.
6817 (tiff_load): Treat overly large images as if
6818 x_create_x_image_and_pixmap failed, not as malloc failures.
6819 (gs_load): Use x_check_image_size.
6821 * gtkutil.c: Omit integer casts.
6822 (xg_get_pixbuf_from_pixmap): Remove unnecessary cast.
6823 (xg_set_toolkit_scroll_bar_thumb): Rewrite to avoid need for cast.
6825 * image.c (png_load): Don't assume height * row_bytes fits in 'int'.
6827 * xfaces.c (Fbitmap_spec_p): Fix integer overflow bug.
6828 Without this fix, (bitmap-spec-p '(34359738368 1 "x"))
6829 would wrongly return t on a 64-bit host.
6831 * dispnew.c (init_display): Use *_RANGE_OVERFLOW macros.
6832 The plain *_OVERFLOW macros run afoul of GCC bug 49705
6833 <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=49705>
6834 and therefore cause GCC to emit a bogus diagnostic in some cases.
6836 * image.c: Integer signedness and overflow and related fixes.
6837 This is not an exhaustive set of fixes, but it's time to
6838 record what I've got.
6839 (lookup_pixel_color, check_image_size): Remove redundant decls.
6840 (check_image_size): Don't assume that arbitrary EMACS_INT values
6841 fit in 'int', or that arbitrary 'double' values fit in 'int'.
6842 (x_alloc_image_color, x_create_x_image_and_pixmap, png_load)
6843 (tiff_load, imagemagick_load_image):
6844 Check for overflow in size calculations.
6845 (x_create_x_image_and_pixmap): Remove unnecessary test for
6846 xmalloc returning NULL; that can't happen.
6847 (xbm_read_bitmap_data): Don't assume sizes fit into 'int'.
6848 (xpm_color_bucket): Use better integer hashing function.
6849 (xpm_cache_color): Don't possibly over-allocate memory.
6850 (struct png_memory_storage, tiff_memory_source, tiff_seek_in_memory)
6851 (gif_memory_source):
6852 Use ptrdiff_t, not int or size_t, to record sizes.
6853 (png_load): Don't assume values greater than 2**31 fit in 'int'.
6854 (our_stdio_fill_input_buffer): Prefer ptrdiff_t to size_t when
6855 either works, as we prefer signed integers.
6856 (tiff_read_from_memory, tiff_write_from_memory):
6857 Return tsize_t, not size_t, since that's what the TIFF API wants.
6858 (tiff_read_from_memory): Don't fail simply because the read would
6859 go past EOF; instead, return a short read.
6860 (tiff_load): Omit no-longer-needed casts.
6861 (Fimagemagick_types): Don't assume size fits into 'int'.
6863 Improve hashing quality when configured --with-wide-int.
6864 * fns.c (hash_string): New function, taken from sxhash_string.
6865 Do not discard information about ASCII character case; this
6866 discarding is no longer needed.
6867 (sxhash-string): Use it. Change sig to match it. Caller changed.
6868 * lisp.h: Declare it.
6869 * lread.c (hash_string): Remove, since we now use fns.c's version.
6870 The fns.c version returns a wider integer if --with-wide-int is
6871 specified, so this should help the quality of the hashing a bit.
6873 * emacs.c: Integer overflow minor fix.
6874 (heap_bss_diff): Now uprintmax_t, not unsigned long. All used changed.
6875 Define only if GNU_LINUX.
6876 (main, Fdump_emacs): Set and use heap_bss_diff only if GNU_LINUX.
6878 * dispnew.c: Integer signedness and overflow fixes.
6879 Remove unnecessary forward decls, that were a maintenance hassle.
6880 (history_tick): Now uprintmax_t, so it's more likely to avoid overflow.
6882 (adjust_glyph_matrix, realloc_glyph_pool, adjust_frame_message_buffer)
6883 (scrolling_window): Use ptrdiff_t, not int, for byte count.
6884 (prepare_desired_row, line_draw_cost):
6885 Use int, not unsigned, where either works.
6886 (save_current_matrix, restore_current_matrix):
6887 Use ptrdiff_t, not size_t, where either works.
6888 (init_display): Check for overflow more accurately, and without
6889 relying on undefined behavior.
6891 * editfns.c (pWIDE, pWIDElen, signed_wide, unsigned_wide):
6892 Remove, replacing with the new symbols in lisp.h. All uses changed.
6893 * fileio.c (make_temp_name):
6894 * filelock.c (lock_file_1, lock_file):
6895 * xdisp.c (message_dolog):
6896 Don't assume PRIdMAX etc. works; this isn't portable to pre-C99 hosts.
6897 Use pMd etc. instead.
6898 * lisp.h (printmax_t, uprintmax_t, pMd, pMu): New types and macros,
6899 replacing the pWIDE etc. symbols removed from editfns.c.
6901 * keyboard.h (num_input_events): Now uintmax_t.
6902 This is (very slightly) less likely to mess up due to wraparound.
6905 * buffer.c: Integer signedness fixes.
6906 (alloc_buffer_text, enlarge_buffer_text):
6907 Use ptrdiff_t rather than size_t when either will do, as we prefer
6910 * alloc.c: Integer signedness and overflow fixes.
6911 Do not impose an arbitrary 32-bit limit on malloc sizes when debugging.
6912 (__malloc_size_t): Default to size_t, not to int.
6913 (pure_size, pure_bytes_used_before_overflow, stack_copy_size)
6914 (Fgarbage_collect, mark_object_loop_halt, mark_object):
6915 Prefer ptrdiff_t to size_t when either would do, as we prefer
6917 (XMALLOC_OVERRUN_CHECK_OVERHEAD): New macro.
6918 (xmalloc_overrun_check_header, xmalloc_overrun_check_trailer):
6919 Now const. Initialize with values that are in range even if char
6921 (XMALLOC_PUT_SIZE, XMALLOC_GET_SIZE): Remove, replacing with ...
6922 (xmalloc_put_size, xmalloc_get_size): New functions. All uses changed.
6923 These functions do the right thing with sizes > 2**32.
6924 (check_depth): Now ptrdiff_t, not int.
6925 (overrun_check_malloc, overrun_check_realloc, overrun_check_free):
6926 Adjust to new way of storing sizes. Check for size overflow bugs
6928 (STRING_BYTES_MAX): Adjust to new overheads. The old code was
6929 slightly wrong anyway, as it missed one instance of
6930 XMALLOC_OVERRUN_CHECK_OVERHEAD.
6931 (refill_memory_reserve): Omit needless cast to size_t.
6932 (mark_object_loop_halt): Mark as externally visible.
6934 * xselect.c: Integer signedness and overflow fixes.
6935 (Fx_register_dnd_atom, x_handle_dnd_message):
6936 Use ptrdiff_t, not size_t, since we prefer signed.
6937 (Fx_register_dnd_atom): Check for ptrdiff_t (and size_t) overflow.
6938 * xterm.h (struct x_display_info): Use ptrdiff_t, not size_t, for
6939 x_dnd_atoms_size and x_dnd_atoms_length.
6941 * doprnt.c: Prefer signed to unsigned when either works.
6943 * doprnt.c (doprnt):
6945 * xdisp.c (vmessage):
6946 Use ptrdiff_t, not size_t, when using or implementing doprnt,
6947 since the sizes cannot exceed ptrdiff_t bounds anyway, and we
6948 prefer signed arithmetic to avoid comparison confusion.
6949 * doprnt.c (doprnt): Avoid a "+ 1" that can't overflow,
6950 but is a bit tricky.
6952 Assume freestanding C89 headers, string.h, stdlib.h.
6953 * data.c, doprnt.c, floatfns.c, print.c:
6954 Include float.h unconditionally.
6955 * gmalloc.c: Assume C89-at-least behavior for preprocessor,
6956 limits.h, stddef.h, string.h. Use memset instead of 'flood'.
6957 * regex.c: Likewise for stddef.h, string.h.
6958 (ISASCII): Remove; can assume it returns 1 now. All uses removed.
6959 * s/aix4-2.h (HAVE_STRING_H): Remove obsolete undef.
6960 * s/ms-w32.h (HAVE_LIMITS_H, HAVE_STRING_H, HAVE_STDLIB_H)
6961 (STDC_HEADERS): Remove obsolete defines.
6962 * sysdep.c: Include limits.h unconditionally.
6964 Assume support for memcmp, memcpy, memmove, memset.
6965 * lisp.h, sysdep.c (memcmp, memcpy, memmove, memset):
6966 * regex.c (memcmp, memcpy):
6967 Remove; we assume C89 now.
6969 * gmalloc.c (memcpy, memset, memmove): Remove; we assume C89 now.
6970 (__malloc_safe_bcopy): Remove; no longer needed.
6972 * lisp.h (struct vectorlike_header, struct Lisp_Subr): Signed sizes.
6973 Use EMACS_INT, not EMACS_UINT, for sizes. The code works equally
6974 well either way, and we prefer signed to unsigned.
6976 2011-07-27 Lars Magne Ingebrigtsen <larsi@gnus.org>
6978 * gnutls.c (emacs_gnutls_read): Don't message anything if the peer
6979 closes the connection while we're reading (bug#9182).
6981 2011-07-25 Jan Djärv <jan.h.d@swipnet.se>
6983 * nsmenu.m (ns_popup_dialog): Add an "ok" button if no buttons
6984 are specified (Bug#9168).
6986 2011-07-25 Paul Eggert <eggert@cs.ucla.edu>
6988 * bidi.c (bidi_dump_cached_states): Fix printf format mismatch.
6989 Found by GCC static checking and --with-wide-int on a 32-bit host.
6991 2011-07-25 Eli Zaretskii <eliz@gnu.org>
6993 * xdisp.c (compute_display_string_pos): Fix logic of caching
6994 previous display string position. Initialize cached_prev_pos to
6995 -1. Fixes slow-down at the beginning of a buffer.
6997 2011-07-24 Eli Zaretskii <eliz@gnu.org>
6999 * xfaces.c (check_lface_attrs) [HAVE_WINDOW_SYSTEM]: Allow `nil'
7000 for attrs[LFACE_FONTSET_INDEX].
7002 2011-07-23 Paul Eggert <eggert@cs.ucla.edu>
7004 * xml.c (parse_region): Remove unused local
7005 that was recently introduced.
7007 2011-07-23 Eli Zaretskii <eliz@gnu.org>
7009 * xfns.c (unwind_create_frame) [GLYPH_DEBUG]: Adapt to changes in
7010 2008-02-22T17:42:09Z!monnier@iro.umontreal.ca.
7012 * xdisp.c (move_it_in_display_line_to): Record the best matching
7013 position for TO_CHARPOS while scanning the line, and restore it on
7014 exit if none of the characters scanned was an exact match.
7015 Fixes vertical-motion and pos-visible-in-window-p under bidi redisplay
7016 when exact match is impossible due to invisible text, and the
7017 lines are truncated.
7019 2011-07-23 Jan Djärv <jan.h.d@swipnet.se>
7021 * nsterm.m (initFrameFromEmacs): Set NSTitledWindowMask in styleMask
7024 2011-07-22 Eli Zaretskii <eliz@gnu.org>
7026 Fix a significant slow-down of cursor motion with C-n, C-p,
7027 C-f/C-b, and C-v/M-v that couldn't keep up with keyboard
7028 auto-repeat under bidi redisplay in fontified buffers.
7029 * xdisp.c (compute_stop_pos_backwards): New function.
7030 (next_element_from_buffer): Call compute_stop_pos_backwards to
7031 find a suitable prev_stop when we find ourselves before
7033 (reseat): Don't look for prev_stop, as that could mean a very long
7035 <cached_disp_pos, cached_disp_buffer, cached_disp_modiff>
7036 <cached_disp_overlay_modiff>: Cache for last found display string
7038 (compute_display_string_pos): Return the cached position if asked
7039 about the same buffer in the same area of character positions, and
7040 the buffer wasn't changed since the time the display string
7041 position was cached.
7043 2011-07-22 Eli Zaretskii <eliz@gnu.org>
7045 * xdisp.c (rows_from_pos_range): Don't ignore glyphs whose object
7046 is an integer, which is important for empty lines. (Bug#9149)
7048 2011-07-22 Chong Yidong <cyd@stupidchicken.com>
7050 * frame.c (Fmodify_frame_parameters): In tty case, update the
7051 default face if necessary (Bug#4238).
7053 2011-07-21 Chong Yidong <cyd@stupidchicken.com>
7055 * editfns.c (Fstring_to_char): No need to explain what a character
7056 is in the docstring (Bug#6576).
7058 2011-07-20 Lars Magne Ingebrigtsen <larsi@gnus.org>
7060 * xml.c (parse_region): Make sure we always return a tree.
7062 2011-07-20 HAMANO Kiyoto <khiker.mail@gmail.com>
7064 * xml.c (parse_region): If a document contains only comments,
7067 2011-07-20 Lars Magne Ingebrigtsen <larsi@gnus.org>
7069 * xml.c (make_dom): Return comments, too.
7071 2011-07-19 Paul Eggert <eggert@cs.ucla.edu>
7074 See http://lists.gnu.org/archive/html/emacs-devel/2011-07/msg00688.html
7075 and the surrounding thread.
7076 * minibuf.c (read_minibuf_noninteractive): Rewrite to use getchar
7077 rather than fgets, and retry after EINTR. Otherwise, 'emacs
7078 --batch -f byte-compile-file' fails on OpenBSD if an inactivity
7080 * s/openbsd.h (BROKEN_SIGIO): Define.
7081 * unexelf.c (unexec) [__OpenBSD__]:
7082 Don't update the .mdebug section of the Alpha COFF symbol table.
7084 2011-07-19 Lars Magne Ingebrigtsen <larsi@gnus.org>
7086 * lread.c (syms_of_lread): Clarify when `lexical-binding' is used
7089 2011-07-18 Paul Eggert <eggert@cs.ucla.edu>
7091 * fileio.c (Fcopy_file) [!MSDOS]: Tighten created file's mask.
7092 This fixes some race conditions on the permissions of any newly
7095 * alloc.c (valid_pointer_p): Use pipe, not open.
7096 This fixes some permissions issues when debugging.
7098 * fileio.c (Fcopy_file): Adjust mode if fchown fails. (Bug#9002)
7099 If fchown fails to set both uid and gid, try to set just gid,
7100 as that is sometimes allowed. Adjust the file's mode to eliminate
7101 setuid or setgid bits that are inappropriate if fchown fails.
7103 2011-07-18 Stefan Monnier <monnier@iro.umontreal.ca>
7105 * xdisp.c (next_element_from_string, next_element_from_buffer): Use EQ
7106 to compare Lisp_Objects.
7107 * gnutls.c (syms_of_gnutls): Rename Vgnutls_log_level to
7108 global_gnutls_log_level, don't mistake it for a Lisp_Object.
7109 (init_gnutls_functions, emacs_gnutls_handle_error): Fix up uses.
7111 2011-07-17 Andreas Schwab <schwab@linux-m68k.org>
7113 * lread.c (read_integer): Unread even EOF character.
7114 (read1): Likewise. Properly record start position of symbol.
7116 * lread.c (read1): Read `#:' as empty uninterned symbol if no
7117 symbol character follows.
7119 2011-07-17 Paul Eggert <eggert@cs.ucla.edu>
7121 * fileio.c (Fcopy_file): Pacify gcc re fchown. (Bug#9002)
7122 This works around a problem with the previous change to Fcopy_file.
7123 Recent glibc declares fchown with __attribute__((warn_unused_result)),
7124 and without this change, GCC might complain about discarding
7125 fchown's return value.
7127 2011-07-16 Juanma Barranquero <lekktu@gmail.com>
7129 * makefile.w32-in (GLOBAL_SOURCES): Add gnutls.c (followup to bug#9059).
7131 2011-07-16 Paul Eggert <eggert@cs.ucla.edu>
7133 * fileio.c (Fcopy_file): Don't diagnose fchown failures. (Bug#9002)
7135 2011-07-16 Lars Magne Ingebrigtsen <larsi@gnus.org>
7137 * gnutls.c (syms_of_gnutls): Define `gnutls-log-level' here, since
7138 it's used from the C level.
7140 * process.c: Use the same condition for POLL_FOR_INPUT in both
7141 keyboard.c and process.c (bug#1858).
7143 2011-07-09 Lawrence Mitchell <wence@gmx.li>
7145 * gnutls.c (Qgnutls_bootprop_min_prime_bits): New variable.
7146 (Fgnutls_boot): Use it.
7148 2011-07-15 Andreas Schwab <schwab@linux-m68k.org>
7150 * doc.c (Fsubstitute_command_keys): Revert last change.
7152 2011-07-15 Lars Magne Ingebrigtsen <larsi@gnus.org>
7154 * doc.c (Fsubstitute_command_keys): Clarify that \= really only
7155 quotes the next character, and doesn't affect other longer
7156 sequences (bug#8935).
7158 * lread.c (syms_of_lread): Clarify that is isn't only
7159 `eval-buffer' and `eval-defun' that's affected by
7160 `lexical-binding' (bug#8460).
7162 2011-07-15 Eli Zaretskii <eliz@gnu.org>
7164 * xdisp.c (move_it_in_display_line_to): Fix vertical motion with
7165 bidi redisplay when a line includes both an image and is truncated.
7167 2011-07-14 Paul Eggert <eggert@cs.ucla.edu>
7169 Fix minor problems found by static checking.
7170 * bidi.c (bidi_cache_size): Now EMACS_INT, not size_t.
7171 (elsz): Now a signed constant, not a size_t var. We prefer signed
7172 types to unsigned, to avoid integer comparison confusion. Without
7173 this change, GCC 4.6.1 with -Wunsafe-loop-optimizations complains
7174 "cannot optimize loop, the loop counter may overflow", a symptom
7176 * indent.c (Fvertical_motion): Mark locals as initialized.
7177 * xdisp.c (reseat_to_string): Fix pointer signedness issue.
7179 2011-07-14 Lars Magne Ingebrigtsen <larsi@gnus.org>
7181 * search.c (Fre_search_backward): Mention `case-fold-search' in
7182 all the re_search_* functions (bug#8138).
7184 * keyboard.c (Fopen_dribble_file): Document when the file is
7187 2011-07-14 Eli Zaretskii <eliz@gnu.org>
7189 * bidi.c (bidi_dump_cached_states): Fix format of displaying
7192 Support bidi reordering of display and overlay strings.
7193 * xdisp.c (compute_display_string_pos)
7194 (compute_display_string_end): Accept additional argument STRING.
7195 (init_iterator, reseat_1): Initialize bidi_it->string.s to NULL.
7196 (reseat_to_string): Initialize bidi_it->string.s and
7197 bidi_it->string.schars.
7198 (Fcurrent_bidi_paragraph_direction): Initialize itb.string.s to
7199 NULL (avoids a crash in bidi_paragraph_init).
7200 Initialize itb.string.lstring.
7201 (init_iterator): Call bidi_init_it only of a valid
7202 buffer position was specified. Initialize paragraph_embedding to
7204 (reseat_to_string): Initialize the bidi iterator.
7205 (display_string): If we need to ignore text properties of
7206 LISP_STRING, set IT->stop_charpos to IT->end_charpos. (The
7207 original value of -1 will not work with bidi.)
7208 (compute_display_string_pos): First arg is now struct
7209 `text_pos *'; all callers changed. Support display properties on
7211 (compute_display_string_end): Support display properties on Lisp
7213 (init_iterator, reseat_1, reseat_to_string): Initialize the
7214 string.bufpos member to 0 (zero, for compatibility with IT_CHARPOS
7215 when iterating on a string not from display properties).
7216 (compute_display_string_pos, compute_display_string_end):
7217 Fix calculation of the object to scan. Fixes an error when using
7219 (next_element_from_buffer): Don't abort when IT_CHARPOS is before
7220 base_level_stop; instead, set base_level_stop to BEGV.
7221 Fixes crashes in vertical-motion.
7222 (next_element_from_buffer): Improve commentary for when
7223 the iterator is before prev_stop.
7224 (init_iterator): Initialize bidi_p from the default value of
7225 bidi-display-reordering, not from buffer-local value. Use the
7226 buffer-local value only if initializing for buffer iteration.
7227 (handle_invisible_prop): Support invisible properties on strings
7228 that are being bidi-reordered.
7229 (set_iterator_to_next): Support bidi reordering of C strings and
7231 (next_element_from_string): Support bidi reordering of Lisp
7233 (handle_stop_backwards): Support Lisp strings as well.
7234 (display_string): Support display of R2L glyph rows.
7235 Use IT_STRING_CHARPOS when displaying from a Lisp string.
7236 (init_iterator): Don't initialize it->bidi_p for strings
7238 (reseat_to_string): Initialize it->bidi_p for strings here.
7239 (next_element_from_string, next_element_from_c_string)
7240 (next_element_from_buffer): Add xassert's for correspondence
7241 between IT's object being iterated and it->bidi_it.string
7243 (face_before_or_after_it_pos): Support bidi iteration.
7244 (next_element_from_c_string): Handle the case of the first string
7245 character that is not the first one in the visual order.
7246 (get_visually_first_element): New function, refactored from common
7247 parts of next_element_from_buffer, next_element_from_string, and
7248 next_element_from_c_string.
7249 (tool_bar_lines_needed, redisplay_tool_bar)
7250 (display_menu_bar): Force left-to-right direction. Add a FIXME
7251 comment for making that be controlled by a user option.
7252 (push_it, pop_it): Save and restore the state of the
7253 bidi iterator. Save and restore the bidi_p flag.
7254 (pop_it): Iterate out of display property for string iteration as
7256 (iterate_out_of_display_property): Support iteration over strings.
7257 (handle_single_display_spec): Set up it->bidi_it for iteration
7258 over a display string, and call bidi_init_it.
7259 (handle_single_display_spec, next_overlay_string)
7260 (get_overlay_strings_1, push_display_prop): Set up the bidi
7261 iterator for displaying display or overlay strings.
7262 (forward_to_next_line_start): Don't use the shortcut if
7264 (back_to_previous_visible_line_start): If handle_display_prop
7265 pushed the iterator stack, restore the internal state of the bidi
7266 iterator by calling bidi_pop_it same number of times.
7267 (reseat_at_next_visible_line_start): If ON_NEWLINE_P is non-zero,
7268 and we are bidi-iterating, don't decrement the iterator position;
7269 instead, set the first_elt flag in the bidi iterator, to produce
7271 (reseat_1): Remove redundant setting of string_from_display_prop_p.
7272 (push_display_prop): xassert that we are iterating a buffer.
7273 (push_it, pop_it): Save and restore paragraph_embedding member.
7274 (handle_single_display_spec, next_overlay_string)
7275 (get_overlay_strings_1, reseat_1, reseat_to_string)
7276 (push_display_prop): Set up the `unibyte' member of bidi_it.string
7277 correctly. Don't assume unibyte strings are not bidi-reordered.
7278 (compute_display_string_pos)
7279 (compute_display_string_end): Fix handling the case of C string.
7280 (push_it, pop_it): Save and restore from_disp_prop_p.
7281 (handle_single_display_spec, push_display_prop): Set the
7282 from_disp_prop_p flag.
7283 (get_overlay_strings_1): Reset the from_disp_prop_p flag.
7284 (pop_it): Call iterate_out_of_display_property only if we are
7285 popping after iteration over a string that came from a display
7286 property. Fix a typo in popping stretch info. Add an assertion
7287 for verifying that the iterator position is in sync with the bidi
7289 (handle_single_display_spec, get_overlay_strings_1)
7290 (push_display_prop): Fix initialization of paragraph direction for
7291 string when that of the parent object is not yet determined.
7292 (reseat_1): Call bidi_init_it to resync the bidi
7293 iterator with IT's position. (Bug#7616)
7294 (find_row_edges): If ROW->start.pos gives position
7295 smaller than min_pos, use it as ROW->minpos. (Bug#7616)
7296 (handle_stop, back_to_previous_visible_line_start, reseat_1):
7297 Reset the from_disp_prop_p flag.
7298 (SAVE_IT, RESTORE_IT): New macros.
7299 (pos_visible_p, face_before_or_after_it_pos)
7300 (back_to_previous_visible_line_start)
7301 (move_it_in_display_line_to, move_it_in_display_line)
7302 (move_it_to, move_it_vertically_backward, move_it_by_lines)
7303 (try_scrolling, redisplay_window, display_line): Use them when
7304 saving a temporary copy of the iterator and restoring it back.
7305 (back_to_previous_visible_line_start, reseat_1)
7306 (init_iterator): Empty the bidi cache "stack".
7307 (move_it_in_display_line_to): If iterator ended up at
7308 EOL, but we never saw any buffer positions smaller than
7309 to_charpos, return MOVE_POS_MATCH_OR_ZV. Fixes vertical cursor
7310 motion in bidi-reordered lines.
7311 (move_it_in_display_line_to): Record prev_method and prev_pos
7312 immediately before the call to set_iterator_to_next. Fixes cursor
7313 motion in bidi-reordered lines with stretch glyphs and strings
7314 displayed in margins. (Bug#8133) (Bug#8867)
7315 Return MOVE_POS_MATCH_OR_ZV only if iterator position is past
7317 (pos_visible_p): Support positions in bidi-reordered lines.
7318 Save and restore bidi cache.
7320 * bidi.c (bidi_level_of_next_char): clen should be EMACS_NT, not int.
7321 (bidi_paragraph_info): Delete unused struct.
7322 (bidi_cache_idx, bidi_cache_last_idx): Declare EMACS_INT.
7323 (bidi_cache_start): New variable.
7324 (bidi_cache_reset): Reset bidi_cache_idx to bidi_cache_start, not
7326 (bidi_cache_fetch_state, bidi_cache_search)
7327 (bidi_cache_find_level_change, bidi_cache_iterator_state)
7328 (bidi_cache_find, bidi_peek_at_next_level)
7329 (bidi_level_of_next_char, bidi_find_other_level_edge)
7330 (bidi_move_to_visually_next): Compare cache index with
7331 bidi_cache_start rather than with zero.
7332 (bidi_fetch_char): Accept new argument STRING; all callers
7333 changed. Support iteration over a string. Support strings with
7334 display properties. Support unibyte strings. Fix the type of
7335 `len' according to what STRING_CHAR_AND_LENGTH expects.
7336 (bidi_paragraph_init, bidi_resolve_explicit_1)
7337 (bidi_resolve_explicit, bidi_resolve_weak)
7338 (bidi_level_of_next_char, bidi_move_to_visually_next):
7339 Support iteration over a string.
7340 (bidi_set_sor_type, bidi_resolve_explicit_1)
7341 (bidi_resolve_explicit, bidi_type_of_next_char): ignore_bn_limit
7342 can now be zero (for strings); special values 0 and -1 were
7343 changed to -1 and -2, respectively.
7344 (bidi_char_at_pos): New function.
7345 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak):
7346 Call it instead of FETCH_MULTIBYTE_CHAR.
7347 (bidi_move_to_visually_next): Abort if charpos or bytepos were not
7348 initialized to valid values.
7349 (bidi_init_it): Don't initialize charpos and bytepos with invalid
7351 (bidi_level_of_next_char): Allow the sentinel "position" to pass
7352 the test for valid cached positions. Fix the logic for looking up
7353 the sentinel state in the cache. GCPRO the Lisp string we are
7355 (bidi_push_it, bidi_pop_it): New functions.
7356 (bidi_initialize): Initialize the bidi cache start stack pointer.
7357 (bidi_cache_ensure_space): New function, refactored from part of
7358 bidi_cache_iterator_state. Don't assume the required size is just
7359 one BIDI_CACHE_CHUNK away.
7360 (bidi_cache_start_stack, bidi_push_it): Use IT_STACK_SIZE.
7361 (bidi_count_bytes, bidi_char_at_pos): New functions.
7362 (bidi_cache_search): Don't assume bidi_cache_last_idx is
7363 always valid if bidi_cache_idx is valid.
7364 (bidi_cache_find_level_change): xassert that bidi_cache_last_idx
7365 is valid if it's going to be used.
7366 (bidi_shelve_cache, bidi_unshelve_cache): New functions.
7367 (bidi_cache_fetch_state, bidi_cache_search)
7368 (bidi_cache_find_level_change, bidi_cache_ensure_space)
7369 (bidi_cache_iterator_state, bidi_cache_find)
7370 (bidi_find_other_level_edge, bidi_cache_start_stack):
7371 All variables related to cache indices are now EMACS_INT.
7373 * dispextern.h (struct bidi_string_data): New structure.
7374 (struct bidi_it): New member `string'. Make flag members be 1-bit
7375 fields, and put them last in the struct.
7376 (compute_display_string_pos, compute_display_string_end):
7378 (bidi_push_it, bidi_pop_it): Add prototypes.
7379 (struct iterator_stack_entry): New members bidi_p,
7380 paragraph_embedding, and from_disp_prop_p.
7381 (struct it): Member bidi_p is now a bit field 1 bit wide.
7382 (bidi_shelve_cache, bidi_unshelve_cache):
7385 * .gdbinit (xvectype, xvector, xcompiled, xchartable, xboolvector)
7386 (xpr, xfont, xbacktrace): Use "header.size" when accessing vectors
7387 and vector-like objects.
7389 * dispnew.c (buffer_posn_from_coords): Save and restore the bidi
7390 cache around display iteration.
7392 * window.c (Fwindow_end, window_scroll_pixel_based)
7393 (displayed_window_lines, Frecenter): Save and restore the bidi
7394 cache around display iteration.
7396 2011-07-14 Lars Magne Ingebrigtsen <larsi@gnus.org>
7398 * editfns.c (Fdelete_region): Clarify the use of the named
7399 parameters (bug#6788).
7401 2011-07-14 Martin Rudalics <rudalics@gmx.at>
7403 * indent.c (Fvertical_motion): Set and restore w->pointm when
7404 saving and restoring the window's buffer (Bug#9006).
7406 2011-07-13 Lars Magne Ingebrigtsen <larsi@gnus.org>
7408 * editfns.c (Fstring_to_char): Clarify just what is returned
7409 (bug#6576). Text by Eli Zaretskii.
7411 2011-07-13 Juanma Barranquero <lekktu@gmail.com>
7413 * gnutls.c (init_gnutls_functions): Honor gnutls_log_level (bug#9059).
7415 2011-07-13 Eli Zaretskii <eliz@gnu.org>
7417 * buffer.c (mmap_find): Fix a typo.
7419 2011-07-13 Johan Bockgård <bojohan@gnu.org>
7421 Fix execution of x selection hooks.
7422 * xselect.c (Qx_lost_selection_functions)
7423 (Qx_sent_selection_functions): New vars.
7424 (syms_of_xselect): DEFSYM them.
7425 (x_handle_selection_request): Pass Qx_sent_selection_functions
7426 rather than Vx_sent_selection_functions to Frun_hook_with_args.
7427 (x_handle_selection_clear,x_clear_frame_selections):
7428 Pass Qx_lost_selection_functions rather than
7429 Vx_lost_selection_functions to Frun_hook_with_args.
7431 2011-07-13 Paul Eggert <eggert@cs.ucla.edu>
7433 * buffer.c (Fget_buffer_create): Initialize inhibit_shrinking.
7434 The old code sometimes used this field without initializing it.
7436 * alloc.c (gc_sweep): Don't read past end of array.
7437 In theory, the old code could also have corrupted Emacs internals,
7438 though it'd be very unlikely.
7440 2011-07-12 Andreas Schwab <schwab@linux-m68k.org>
7442 * character.c (Fcharacterp): Don't advertise optional ignored
7443 argument. (Bug#4026)
7445 2011-07-12 Lars Magne Ingebrigtsen <larsi@gnus.org>
7447 * keymap.c (syms_of_keymap): Clarify that "modifier" is "modifier
7450 * window.c (Fset_window_start): Doc fix (bug#4199).
7451 (Fset_window_hscroll): Ditto.
7453 2011-07-12 Paul Eggert <eggert@cs.ucla.edu>
7455 Fix minor new problems caught by GCC 4.6.1.
7456 * term.c (init_tty): Remove unused local.
7457 * xsettings.c (store_monospaced_changed): Define this function only
7458 if (defined HAVE_GSETTINGS || defined HAVE_GCONF), as it's
7461 2011-07-12 Chong Yidong <cyd@stupidchicken.com>
7463 * xdisp.c (Vresize_mini_windows): Minor doc fix (Bug#3300).
7465 2011-07-11 Lars Magne Ingebrigtsen <larsi@gnus.org>
7467 * xdisp.c (syms_of_xdisp): Make it explicit that the mini-windows
7468 are the mini-buffer and the echo area (bug#3320).
7470 * term.c (init_tty): Remove support for supdup, c10 and perq
7471 terminals, which are no longer supported (bug#1482).
7473 2011-07-10 Johan Bockgård <bojohan@gnu.org>
7475 * xdisp.c (Ftool_bar_lines_needed): Fix WINDOWP check.
7477 2011-07-10 Jan Djärv <jan.h.d@swipnet.se>
7479 * xmenu.c (menu_highlight_callback): Only pass frame to show_help_event
7480 for non-popups (Bug#3642).
7482 2011-07-10 Andreas Schwab <schwab@linux-m68k.org>
7484 * alloc.c (reset_malloc_hooks): Protoize.
7485 * buffer.c (mmap_init, mmap_find, mmap_free_1, mmap_enlarge)
7486 (mmap_set_vars, mmap_alloc, mmap_free, mmap_realloc): Likewise.
7487 * cm.c (losecursor): Likewise.
7488 * data.c (fmod): Likewise.
7489 * dispnew.c (swap_glyphs_in_rows): Likewise.
7490 * emacs.c (memory_warning_signal): Likewise.
7491 * floatfns.c (float_error): Likewise.
7492 * font.c (check_gstring, check_otf_features, otf_tag_symbol)
7493 (otf_open, font_otf_capability, generate_otf_features)
7494 (font_otf_DeviceTable, font_otf_ValueRecord, font_otf_Anchor):
7496 * image.c (pbm_read_file): Likewise.
7497 * indent.c (string_display_width): Likewise.
7498 * intervals.c (check_for_interval, search_for_interval)
7499 (inc_interval_count, count_intervals, root_interval)
7500 (adjust_intervals_for_insertion, make_new_interval): Likewise.
7501 * lread.c (defalias): Likewise.
7502 * ralloc.c (r_alloc_check): Likewise.
7503 * regex.c (set_image_of_range_1, set_image_of_range)
7504 (regex_grow_registers): Likewise.
7505 * sysdep.c (strerror): Likewise.
7506 * termcap.c (valid_filename_p, tprint, main): Likewise.
7507 * tparam.c (main): Likewise.
7508 * unexhp9k800.c (run_time_remap, save_data_space)
7509 (update_file_ptrs, read_header, write_header, calculate_checksum)
7510 (copy_file, copy_rest, display_header): Likewise.
7511 * widget.c (mark_shell_size_user_specified, create_frame_gcs):
7513 * xdisp.c (check_it): Likewise.
7514 * xfaces.c (register_color, unregister_color, unregister_colors):
7516 * xfns.c (print_fontset_result): Likewise.
7517 * xrdb.c (member, fatal, main): Likewise.
7519 2011-07-10 Paul Eggert <eggert@cs.ucla.edu>
7521 Fix minor problems found by static checking (Bug#9031).
7522 * chartab.c (char_table_set_range, map_sub_char_table):
7523 Remove unused locals.
7524 (uniprop_table): Now static.
7525 * composite.c (_work_char): Remove unused static var.
7527 2011-07-09 Juanma Barranquero <lekktu@gmail.com>
7529 * chartab.c (uniprop_table_uncompress): Remove unused local variable.
7531 2011-07-09 Jan Djärv <jan.h.d@swipnet.se>
7533 * gtkutil.c (qttip_cb): Remove code without function.
7535 2011-07-09 Eli Zaretskii <eliz@gnu.org>
7537 * w32.c (pthread_sigmask): New stub.
7539 2011-07-08 Paul Eggert <eggert@cs.ucla.edu>
7541 Use pthread_sigmask, not sigprocmask (Bug#9010).
7542 sigprocmask is portable only for single-threaded applications, and
7543 Emacs can be multi-threaded when it uses GTK.
7544 * Makefile.in (LIB_PTHREAD_SIGMASK): New macro.
7546 * callproc.c (Fcall_process):
7547 * process.c (create_process):
7548 * sysdep.c (sys_sigblock, sys_sigunblock, sys_sigsetmask):
7549 Use pthread_sigmask, not sigprocmask.
7551 2011-07-08 Jan Djärv <jan.h.d@swipnet.se>
7553 * gtkutil.c (qttip_cb): Set line wrap to FALSE for tooltip widget.
7554 (xg_prepare_tooltip): Revert text in x->ttip_lbl, margins was
7557 2011-07-08 Jan Djärv <jan.h.d@swipnet.se>
7559 * gtkutil.c (xg_prepare_tooltip): Fix indentation and comment.
7560 Put text in x->ttip_lbl instead of gtk_tooltip_set_text (Bug#8591).
7561 (xg_hide_tooltip): Fix comment.
7563 * nsterm.m (initFrameFromEmacs): Don't use ns_return_types
7564 in registerServicesMenuSendTypes.
7565 (validRequestorForSendType): Don't check ns_return_types.
7567 * nsfns.m (Fx_open_connection): Put NSStringPboardType into
7570 2011-07-08 Jason Rumney <jasonr@gnu.org>
7572 * w32term.c (x_make_frame_visible): Use SH_SHOWNORMAL rather than
7573 SH_SHOW for hidden windows (Bug#5482).
7575 * w32fns.c (w32_wnd_proc) [WM_TIMER, WM_SET_CURSOR]: Avoid using
7576 frame struct members of non-existent frames (Bug#6284).
7578 2011-07-08 Jan Djärv <jan.h.d@swipnet.se>
7580 * nsterm.m (keyDown): Call to wantsToDelayTextChangeNotifications and
7581 variable firstTime not needed on OSX >= 10.6.
7582 (setPosition): setFloatValue:knobProportion: is deprecated on OSX
7583 >= 10.5. Use setKnobProportion, setDoubleValue.
7585 * nsterm.h (MAC_OS_X_VERSION_10_3, MAC_OS_X_VERSION_10_4)
7586 (MAC_OS_X_VERSION_10_5): Define if not defined.
7587 (EmacsView, EmacsTooltip): Implements NSWindowDelegate on OSX >= 10.6.
7588 (EmacsMenu): Implements NSMenuDelegate on OSX >= 10.6.
7589 (EmacsToolbar): Implements NSToolbarDelegate on OSX >= 10.6.
7591 * nsselect.m (ns_string_from_pasteboard): Don't use deprecated methods
7592 cString and lossyCString on OSX >= 10.4
7594 * nsmenu.m (fillWithWidgetValue): Don't use deprecated method
7595 sizeToFit on OSX >= 10.2.
7597 * nsimage.m (allocInitFromFile): Don't use deprecated method
7598 bestRepresentationForDevice on OSX >= 10.6.
7600 * nsfns.m (check_ns_display_info): Cast to long and use %ld in error
7603 * emacs.c: Declare unexec_init_emacs_zone.
7605 * nsgui.h: Fix compiler warning about gnulib redefining verify.
7607 * nsselect.m (ns_get_local_selection): Change to extern (Bug#8842).
7609 * nsmenu.m (ns_update_menubar): Remove useless setDelegate call
7610 on svcsMenu (Bug#8842).
7612 * nsfns.m (Fx_open_connection): Remove NSStringPboardType from
7614 (Fns_list_services): Just return Qnil on 10.6, code not working there.
7616 * nsterm.m (QUTF8_STRING): Declare.
7617 (initFrameFromEmacs): Call registerServicesMenuSendTypes.
7618 (validRequestorForSendType): Return type is (id).
7619 Change indexOfObjectIdenticalTo to indexOfObject.
7620 Check if we have local selection before returning self (Bug#8842).
7621 (writeSelectionToPasteboard): Put local selection into paste board
7622 if we have a local selection (Bug#8842).
7623 (syms_of_nsterm): DEFSYM QUTF8_STRING.
7625 * nsterm.h (MAC_OS_X_VERSION_10_6): Define here instead of nsterm.m.
7626 (ns_get_local_selection): Declare.
7628 2011-07-07 Lars Magne Ingebrigtsen <larsi@gnus.org>
7630 * keymap.c (describe_map_tree): Don't insert a double newline at
7631 the end of the buffer (bug#1169) and return whether we inserted
7634 * callint.c (Fcall_interactively): Change "reading args" to
7635 "providing args" to try to clarify what it does (bug#1010).
7637 2011-07-07 Kenichi Handa <handa@m17n.org>
7639 * composite.c (composition_compute_stop_pos): Ignore a static
7640 composition starting before CHARPOS (Bug#8915).
7642 * xdisp.c (handle_composition_prop): Likewise.
7644 2011-07-07 Eli Zaretskii <eliz@gnu.org>
7646 * term.c (produce_glyphs) <xassert>: Allow IT_GLYPHLESS in it->what.
7649 2011-07-07 Kenichi Handa <handa@m17n.org>
7651 * character.h (unicode_category_t): New enum type.
7653 * chartab.c (uniprop_decoder_t, uniprop_encoder_t): New types.
7654 (Qchar_code_property_table): New variable.
7655 (UNIPROP_TABLE_P, UNIPROP_GET_DECODER)
7656 (UNIPROP_COMPRESSED_FORM_P): New macros.
7657 (char_table_ascii): Uncompress the compressed values.
7658 (sub_char_table_ref): New arg is_uniprop. Callers changed.
7659 Uncompress the compressed values.
7660 (sub_char_table_ref_and_range): Likewise.
7661 (char_table_ref_and_range): Uncompress the compressed values.
7662 (sub_char_table_set): New arg is_uniprop. Callers changed.
7663 Uncompress the compressed values.
7664 (sub_char_table_set_range): Args changed. Callers changed.
7665 (char_table_set_range): Adjuted for the above change.
7666 (map_sub_char_table): Delete args default_val and parent. Add arg
7667 top. Give decoded values to a Lisp function.
7668 (map_char_table): Adjust for the above change. Give decoded
7669 values to a Lisp function. Gcpro more variables.
7670 (uniprop_table_uncompress)
7671 (uniprop_decode_value_run_length): New functions.
7672 (uniprop_decoder, uniprop_decoder_count): New variables.
7673 (uniprop_get_decoder, uniprop_encode_value_character)
7674 (uniprop_encode_value_run_length, uniprop_encode_value_numeric):
7676 (uniprop_encoder, uniprop_encoder_count): New variables.
7677 (uniprop_get_encoder, uniprop_table)
7678 (Funicode_property_table_internal, Fget_unicode_property_internal)
7679 (Fput_unicode_property_internal): New functions.
7680 (syms_of_chartab): DEFSYM Qchar_code_property_table, defsubr
7681 Sunicode_property_table_internal, Sget_unicode_property_internal,
7682 and Sput_unicode_property_internal. Defvar_lisp
7683 char-code-property-alist.
7685 * composite.c (CHAR_COMPOSABLE_P): Adjust for the change of
7686 Vunicode_category_table.
7688 * font.c (font_range): Adjust for the change of
7689 Vunicode_category_table.
7691 2011-07-07 Dan Nicolaescu <dann@ics.uci.edu>
7693 * m/iris4d.h: Remove file, move contents ...
7694 * s/irix6-5.h: ... here.
7696 2011-07-06 Paul Eggert <eggert@cs.ucla.edu>
7698 Remove unportable assumption about struct layout (Bug#8884).
7699 * alloc.c (mark_buffer):
7700 * buffer.c (reset_buffer_local_variables, Fbuffer_local_variables)
7701 (clone_per_buffer_values): Don't assume that
7702 sizeof (struct buffer) is a multiple of sizeof (Lisp_Object).
7703 This isn't true in general, and it's particularly not true
7704 if Emacs is configured with --with-wide-int.
7705 * buffer.h (FIRST_FIELD_PER_BUFFER, LAST_FIELD_PER_BUFFER):
7706 New macros, used in the buffer.c change.
7708 2011-07-05 Jan Djärv <jan.h.d@swipnet.se>
7710 * xsettings.c: Use both GConf and GSettings if both are available.
7711 (store_config_changed_event): Add comment.
7712 (dpyinfo_valid, store_font_name_changed, map_tool_bar_style)
7713 (store_tool_bar_style_changed): New functions.
7714 (store_monospaced_changed): Add comment. Call dpyinfo_valid.
7715 (struct xsettings): Move font inside HAVE_XFT.
7716 (GSETTINGS_TOOL_BAR_STYLE, GSETTINGS_FONT_NAME): New defines.
7717 (GSETTINGS_MONO_FONT): Rename from SYSTEM_MONO_FONT.
7718 Move inside HAVE_XFT.
7719 (something_changed_gsettingsCB): Rename from something_changedCB.
7720 Check for changes in GSETTINGS_TOOL_BAR_STYLE and GSETTINGS_FONT_NAME
7722 (GCONF_TOOL_BAR_STYLE, GCONF_FONT_NAME): New defines.
7723 (GCONF_MONO_FONT): Rename from SYSTEM_MONO_FONT. Move inside HAVE_XFT.
7724 (something_changed_gconfCB): Rename from something_changedCB.
7725 Check for changes in GCONF_TOOL_BAR_STYLE and GCONF_FONT_NAME also.
7726 (parse_settings): Move check for font inside HAVE_XFT.
7727 (read_settings, apply_xft_settings): Add comment.
7728 (read_and_apply_settings): Add comment. Call map_tool_bar_style and
7729 store_tool_bar_style_changed. Move check for font inside HAVE_XFT and
7730 call store_font_name_changed.
7731 (xft_settings_event): Add comment.
7732 (init_gsettings): Add comment. Get values for GSETTINGS_TOOL_BAR_STYLE
7733 and GSETTINGS_FONT_NAME. Move check for fonts within HAVE_XFT.
7734 (init_gconf): Add comment. Get values for GCONF_TOOL_BAR_STYLE
7735 and GCONF_FONT_NAME. Move check for fonts within HAVE_XFT.
7736 (xsettings_initialize): Call init_gsettings last.
7737 (xsettings_get_system_font, xsettings_get_system_normal_font):
7740 2011-07-05 Paul Eggert <eggert@cs.ucla.edu>
7742 Random fixes. E.g., (random) never returned negative values.
7743 * fns.c (Frandom): Use GET_EMACS_TIME for random seed, and add the
7744 subseconds part to the entropy, as that's a bit more random.
7745 Prefer signed to unsigned, since the signedness doesn't matter and
7746 in general we prefer signed. When given a limit, use a
7747 denominator equal to INTMASK + 1, not to VALMASK + 1, because the
7748 latter isn't right if USE_2_TAGS_FOR_INTS.
7749 * sysdep.c (get_random): Return a value in the range 0..INTMASK,
7750 not 0..VALMASK. Don't discard "excess" bits that random () returns.
7752 2011-07-04 Stefan Monnier <monnier@iro.umontreal.ca>
7754 * textprop.c (text_property_stickiness):
7755 Obey Vtext_property_default_nonsticky.
7756 (syms_of_textprop): Add `display' to Vtext_property_default_nonsticky.
7757 * w32fns.c (syms_of_w32fns):
7758 * xfns.c (syms_of_xfns): Don't Add `display' since it's there by default.
7760 2011-07-04 Paul Eggert <eggert@cs.ucla.edu>
7762 * fileio.c (barf_or_query_if_file_exists): Use S_ISDIR.
7763 This is more efficient than Ffile_directory_p and avoids a minor race.
7765 2011-07-04 Lars Magne Ingebrigtsen <larsi@gnus.org>
7767 * buffer.c (Foverlay_put): Say what the return value is
7770 * fileio.c (barf_or_query_if_file_exists): Check first if the file
7771 is a directory before asking whether to use the file name
7773 (barf_or_query_if_file_exists): Make the "File is a directory"
7774 error be more correct.
7776 * fns.c (Frequire): Remove the mention of the .gz files, since
7777 that's installation-specific, but keep the mention of
7778 `get-load-suffixes'.
7780 2011-07-04 Paul Eggert <eggert@cs.ucla.edu>
7782 * editfns.c (Fformat_time_string): Don't assume strlen fits in int.
7783 Report string overflow if the output is too long.
7785 2011-07-04 Juanma Barranquero <lekktu@gmail.com>
7787 * gnutls.c (Fgnutls_boot): Don't mention :verify-error.
7788 (syms_of_gnutls): Remove duplicate DEFSYM for
7789 Qgnutls_bootprop_verify_hostname_error, an error for
7790 Qgnutls_bootprop_verify_error (which is no longer used).
7792 * eval.c (find_handler_clause): Remove parameters `sig' and `data',
7793 unused since 2011-01-26T20:02:07Z!monnier@iro.umontreal.ca. All callers changed.
7794 Also (re)move comments that are misplaced or no longer relevant.
7796 2011-07-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
7798 * callint.c (Finteractive): Clarify the meaning of "@" (bug#8813).
7800 2011-07-03 Chong Yidong <cyd@stupidchicken.com>
7802 * xfaces.c (Finternal_merge_in_global_face): Modify the foreground
7803 and background color parameters if they have been changed.
7805 2011-07-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
7807 * editfns.c (Fformat): Clarify the - and 0 flags (bug#6659).
7809 2011-07-03 Paul Eggert <eggert@cs.ucla.edu>
7811 * xsettings.c (SYSTEM_FONT): Define only when used.
7812 No need to define when HAVE_GSETTINGS || !HAVE_XFT.
7814 * keymap.c (access_keymap_1): Now static.
7816 2011-07-02 Chong Yidong <cyd@stupidchicken.com>
7818 * keyboard.c (command_loop_1): If a down-mouse event is unbound,
7819 leave any prefix arg for the up event (Bug#1586).
7821 2011-07-02 Lars Magne Ingebrigtsen <larsi@gnus.org>
7823 * lread.c (syms_of_lread): Mention single symbols defined by
7824 `defvar' or `defconst' (bug#7154).
7826 * fns.c (Frequire): Mention .el.gz files (bug#7314).
7827 (Frequire): Mention get-load-suffixes.
7829 2011-07-02 Martin Rudalics <rudalics@gmx.at>
7831 * window.h (window): Remove clone_number slot.
7832 * window.c (Fwindow_clone_number, Fset_window_clone_number):
7834 (make_parent_window, make_window, saved_window)
7835 (Fset_window_configuration, save_window_save): Don't deal with
7837 * buffer.c (Qclone_number): Remove declaration.
7838 (sort_overlays, overlay_strings): Don't deal with clone numbers.
7840 2011-07-02 Stefan Monnier <monnier@iro.umontreal.ca>
7842 Add multiple inheritance to keymaps.
7843 * keymap.c (Fmake_composed_keymap): New function.
7844 (Fset_keymap_parent): Simplify.
7845 (fix_submap_inheritance): Remove.
7846 (access_keymap_1): New function extracted from access_keymap to handle
7847 embedded parents and handle lists of maps.
7848 (access_keymap): Use it.
7849 (Fkeymap_prompt, map_keymap_internal, map_keymap, store_in_keymap)
7850 (Fcopy_keymap): Handle embedded parents.
7851 (Fcommand_remapping, define_as_prefix): Simplify.
7852 (Fkey_binding): Simplify.
7853 (syms_of_keymap): Move minibuffer-local-completion-map,
7854 minibuffer-local-filename-completion-map,
7855 minibuffer-local-must-match-map, and
7856 minibuffer-local-filename-must-match-map to Elisp.
7857 (syms_of_keymap): Defsubr make-composed-keymap.
7858 * keyboard.c (menu_bar_items): Use map_keymap_canonical.
7859 (parse_menu_item): Trivial simplification.
7861 2011-07-01 Glenn Morris <rgm@gnu.org>
7863 * Makefile.in (SETTINGS_LIBS): Fix typo.
7865 2011-07-01 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny patch)
7867 * coding.c (Fencode_coding_string): Record the last coding system
7868 used, as the function doc string says (bug#8738).
7870 2011-07-01 Jan Djärv <jan.h.d@swipnet.se>
7872 * xsettings.c (store_monospaced_changed): Take new font as arg and
7873 check for change against current_mono_font.
7874 (EMACS_TYPE_SETTINGS): Remove this and related defines.
7875 (emacs_settings_constructor, emacs_settings_get_property)
7876 (emacs_settings_set_property, emacs_settings_class_init)
7877 (emacs_settings_init, gsettings_obj): Remove.
7878 (something_changedCB): New function for HAVE_GSETTINGS.
7879 (something_changedCB): HAVE_GCONF: Call store_monospaced_changed
7880 with value as argument.
7881 (init_gsettings): Check that GSETTINGS_SCHEMA exists before calling
7882 g_settings_new (Bug#8967). Do not create gsettings_obj.
7883 Remove calls to g_settings_bind. Connect something_changedCB to
7886 * xgselect.c: Add defined (HAVE_GSETTINGS).
7887 (xgselect_initialize): Ditto.
7889 * process.c: Add defined (HAVE_GSETTINGS) for xgselect.h
7890 (wait_reading_process_output): Add defined (HAVE_GSETTINGS) for
7893 2011-07-01 Paul Eggert <eggert@cs.ucla.edu>
7895 * eval.c (struct backtrace): Simplify and port the data structure.
7896 Do not assume that "int nargs : BITS_PER_INT - 2;" produces a
7897 signed bit field, as this assumption is not portable and it makes
7898 Emacs crash when compiled with Sun C 5.8 on sparc. Do not use
7899 "char debug_on_exit : 1" as this is not portable either; instead,
7900 use the portable "unsigned int debug_on_exit : 1". Remove unused
7901 member evalargs. Remove obsolete comments about cc bombing out.
7903 2011-06-30 Jan Djärv <jan.h.d@swipnet.se>
7905 * xsettings.c: Include glib-object.h, gio/gio.h if HAVE_GSETTINGS.
7906 Let HAVE_GSETTINGS override HAVE_GCONF.
7907 (store_monospaced_changed): New function.
7908 (EMACS_SETTINGS): A new type derived from GObject to handle
7909 GSettings notifications.
7910 (emacs_settings_constructor, emacs_settings_get_property)
7911 (emacs_settings_set_property, emacs_settings_class_init):
7913 (gsettings_client, gsettings_obj): New variables.
7914 (GSETTINGS_SCHEMA): New define.
7915 (something_changedCB): Call store_monospaced_changed.
7916 (init_gsettings): New function.
7917 (xsettings_initialize): Call init_gsettings.
7918 (syms_of_xsettings): Initialize gsettings_client, gsettings_obj
7921 * Makefile.in (SETTINGS_CFLAGS, SETTINGS_LIBS): Rename from
7924 2011-06-29 Martin Rudalics <rudalics@gmx.at>
7926 * window.c (resize_root_window, grow_mini_window)
7927 (shrink_mini_window): Rename Qresize_root_window to
7928 Qwindow_resize_root_window and Qresize_root_window_vertically to
7929 Qwindow_resize_root_window_vertically.
7931 2011-06-28 Paul Eggert <eggert@cs.ucla.edu>
7933 * gnutls.c (Qgnutls_bootprop_verify_error): Remove unused var.
7935 2011-06-27 Juanma Barranquero <lekktu@gmail.com>
7937 * makefile.w32-in: Redesign dependencies so they reflect more
7938 clearly which files are directly included by each source file,
7939 and not through other includes.
7941 2011-06-27 Martin Rudalics <rudalics@gmx.at>
7943 * buffer.c (Qclone_number): Declare static and DEFSYM it.
7944 (sort_overlays, overlay_strings): When an overlay's clone number
7945 matches the window's clone number process the overlay even if
7946 the overlay's window property doesn't match the current window.
7948 * window.c (Fwindow_vchild): Rename to Fwindow_top_child.
7949 (Fwindow_hchild): Rename to Fwindow_left_child.
7950 (Fwindow_next): Rename to Fwindow_next_sibling.
7951 (Fwindow_prev): Rename to Fwindow_prev_sibling.
7952 (resize_window_check): Rename to window_resize_check.
7953 (resize_window_apply): Rename to window_resize_apply.
7954 (Fresize_window_apply): Rename to Fwindow_resize_apply.
7955 (Fdelete_other_windows_internal, resize_frame_windows)
7956 (Fsplit_window_internal, Fdelete_window_internal)
7957 (grow_mini_window, shrink_mini_window)
7958 (Fresize_mini_window_internal): Fix callers accordingly.
7960 2011-06-26 Jan Djärv <jan.h.d@swipnet.se>
7962 * emacsgtkfixed.h: State that this is only used with Gtk+3.
7963 (emacs_fixed_set_min_size): Remove.
7964 (emacs_fixed_new): Take frame as argument.
7966 * emacsgtkfixed.c: State that this is only used with Gtk+3.
7967 (_EmacsFixedPrivate): Remove minwidth/height.
7968 Add struct frame *f.
7969 (emacs_fixed_init): Initialize priv->f.
7970 (get_parent_class, emacs_fixed_set_min_size): Remove.
7971 (emacs_fixed_new): Set priv->f to argument.
7972 (emacs_fixed_get_preferred_width)
7973 (emacs_fixed_get_preferred_height): Use min_width/height from
7974 frames size_hint to set minimum and natural (Bug#8919).
7975 (XSetWMSizeHints, XSetWMNormalHints): Override these functions
7976 and use min_width/height from frames size_hint to set
7977 min_width/height (Bug#8919).
7979 * gtkutil.c (xg_create_frame_widgets): Pass f to emacs_fixed_new.
7980 (x_wm_set_size_hint): Remove call to emacs_fixed_set_min_size.
7983 2011-06-26 Eli Zaretskii <eliz@gnu.org>
7985 * bidi.c (bidi_paragraph_init): Test for ZV_BYTE before calling
7986 bidi_at_paragraph_end, since fast_looking_at doesn't like to be
7989 2011-06-26 Chong Yidong <cyd@stupidchicken.com>
7991 * process.c (wait_reading_process_output): Bypass select if
7992 waiting for a cell while ignoring keyboard input, and input is
7993 pending. Suggested by Jan Djärv (Bug#8869).
7995 2011-06-25 Paul Eggert <eggert@cs.ucla.edu>
7997 Use gnulib's dup2 module instead of rolling our own.
7998 * sysdep.c (dup2) [!HAVE_DUP2]: Remove; gnulib now does this.
8000 2011-06-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
8002 * dispnew.c (scrolling_window): Before scrolling, turn off a
8003 mouse-highlight in the window being scrolled.
8005 2011-06-24 Juanma Barranquero <lekktu@gmail.com>
8007 Move DEFSYM to lisp.h and use everywhere.
8009 * character.h (DEFSYM): Move declaration...
8010 * lisp.h (DEFSYM): ...here.
8016 * w32select.c: Don't include character.h.
8018 * alloc.c (syms_of_alloc):
8019 * buffer.c (syms_of_buffer):
8020 * bytecode.c (syms_of_bytecode):
8021 * callint.c (syms_of_callint):
8022 * casefiddle.c (syms_of_casefiddle):
8023 * casetab.c (init_casetab_once):
8024 * category.c (init_category_once, syms_of_category):
8025 * ccl.c (syms_of_ccl):
8026 * cmds.c (syms_of_cmds):
8027 * composite.c (syms_of_composite):
8028 * dbusbind.c (syms_of_dbusbind):
8029 * dired.c (syms_of_dired):
8030 * dispnew.c (syms_of_display):
8031 * doc.c (syms_of_doc):
8032 * editfns.c (syms_of_editfns):
8033 * emacs.c (syms_of_emacs):
8034 * eval.c (syms_of_eval):
8035 * fileio.c (syms_of_fileio):
8036 * fns.c (syms_of_fns):
8037 * frame.c (syms_of_frame):
8038 * fringe.c (syms_of_fringe):
8039 * insdel.c (syms_of_insdel):
8040 * keymap.c (syms_of_keymap):
8041 * lread.c (init_obarray, syms_of_lread):
8042 * macros.c (syms_of_macros):
8043 * msdos.c (syms_of_msdos):
8044 * print.c (syms_of_print):
8045 * process.c (syms_of_process):
8046 * search.c (syms_of_search):
8047 * sound.c (syms_of_sound):
8048 * syntax.c (init_syntax_once, syms_of_syntax):
8049 * terminal.c (syms_of_terminal):
8050 * textprop.c (syms_of_textprop):
8051 * undo.c (syms_of_undo):
8052 * w32.c (globals_of_w32):
8053 * window.c (syms_of_window):
8054 * xdisp.c (syms_of_xdisp):
8055 * xfaces.c (syms_of_xfaces):
8056 * xfns.c (syms_of_xfns):
8057 * xmenu.c (syms_of_xmenu):
8058 * xsettings.c (syms_of_xsettings):
8059 * xterm.c (syms_of_xterm): Use DEFSYM.
8061 2011-06-24 Teodor Zlatanov <tzz@lifelogs.com>
8063 * gnutls.c (syms_of_gnutls): Use the DEFSYM macro from character.h.
8065 2011-06-23 Paul Eggert <eggert@cs.ucla.edu>
8067 Integer and buffer overflow fixes (Bug#8873).
8069 * print.c (printchar, strout): Check for string overflow.
8070 (PRINTPREPARE, printchar, strout):
8071 Don't set size unless allocation succeeds.
8073 * minibuf.c (read_minibuf_noninteractive): Use ptrdiff_t, not int,
8074 for sizes. Check for string overflow more accurately.
8075 Simplify newline removal at end; this suppresses a GCC 4.6.0 warning.
8077 * macros.c: Integer and buffer overflow fixes.
8078 * keyboard.h (struct keyboard.kbd_macro_bufsize):
8079 * macros.c (Fstart_kbd_macro, store_kbd_macro_char):
8080 Use ptrdiff_t, not int, for sizes.
8081 Don't increment bufsize until after realloc succeeds.
8082 Check for size-calculation overflow.
8083 (Fstart_kbd_macro): Use EMACS_INT, not int, for XINT result.
8085 * lisp.h (DEFVAR_KBOARD): Use offsetof instead of char * finagling.
8087 * lread.c: Integer overflow fixes.
8088 (read_integer): Radix is now EMACS_INT, not int,
8089 to improve quality of diagnostics for out-of-range radices.
8090 Calculate buffer size correctly for out-of-range radices.
8091 (read1): Check for integer overflow in radices, and in
8092 read-circle numbers.
8093 (read_escape): Avoid int overflow.
8094 (Fload, openp, read_buffer_size, read1)
8095 (substitute_object_recurse, read_vector, read_list, map_obarray):
8096 Use ptrdiff_t, not int, for sizes.
8097 (read1): Use EMACS_INT, not int, for sizes.
8098 Check for size overflow.
8100 * image.c (cache_image): Check for size arithmetic overflow.
8102 * lread.c: Integer overflow issues.
8103 (saved_doc_string_size, saved_doc_string_length)
8104 (prev_saved_doc_string_size, prev_saved_doc_string_length):
8105 Now ptrdiff_t, not int.
8106 (read1): Don't assume doc string length fits in int. Check for
8107 out-of-range doc string lengths.
8108 (read_list): Don't assume file position fits in int.
8109 (read_escape): Check for hex character overflow.
8111 2011-06-22 Leo Liu <sdl.web@gmail.com>
8113 * minibuf.c (Fcompleting_read_default, Vcompleting_read_function):
8114 Move to minibuffer.el.
8116 2011-06-22 Paul Eggert <eggert@cs.ucla.edu>
8118 Fixes for GLYPH_DEBUG found by GCC 4.6.0 static checking.
8119 The following patches are for when GLYPH_DEBUG && !XASSERT.
8120 * dispextern.h (trace_redisplay_p, dump_glyph_string):
8121 * dispnew.c (flush_stdout):
8122 * xdisp.c (dump_glyph_row, dump_glyph_matrix, dump_glyph):
8123 Mark as externally visible.
8124 * dispnew.c (check_window_matrix_pointers): Now static.
8125 * dispnew.c (window_to_frame_vpos):
8126 * xfns.c (unwind_create_frame):
8127 * xterm.c (x_check_font): Remove unused local.
8128 * scroll.c (CHECK_BOUNDS):
8129 * xfaces.c (cache_fache): Rename local to avoid shadowing.
8130 * xfns.c, w32fns.c (image_cache_refcount, dpyinfo_refcount): Now static.
8131 * xdisp.c (check_window_end): Now a no-op if !XASSERTS.
8132 (debug_first_unchanged_at_end_vpos, debug_last_unchanged_at_beg_vpos)
8133 (debug_dvpos, debug_dy, debug_delta, debug_delta_bytes, debug_end_vpos):
8135 (debug_method_add): Use va_list and vsprintf rather than relying
8136 on undefined behavior with wrong number of arguments.
8137 (dump_glyph, dump_glyph_row, Fdump_glyph_matrix):
8138 Don't assume ptrdiff_t and EMACS_INT are the same width as int.
8139 In this code, it's OK to assume C99 behavior for ptrdiff_t formats
8140 since we're not interested in debugging glyphs with old libraries.
8141 * xfaces.c (cache_face): Move debugging code earlier; this pacifies
8142 GCC 4.6.0's static checking.
8144 2011-06-22 Paul Eggert <eggert@cs.ucla.edu>
8146 Integer overflow and signedness fixes (Bug#8873).
8147 A few related buffer overrun fixes, too.
8149 * font.c (font_score): Use EMACS_INT, not int, to store XINT value.
8151 * dispextern.h (struct face.stipple):
8152 * image.c (x_bitmap_height, x_bitmap_width, x_bitmap_pixmap)
8153 (x_bitmap_mask, x_allocate_bitmap_record)
8154 (x_create_bitmap_from_data, x_create_bitmap_from_file)
8155 (x_destroy_bitmap, x_destroy_all_bitmaps, x_create_bitmap_mask)
8156 (x_create_bitmap_from_xpm_data):
8157 * nsterm.h (struct ns_display_info.bitmaps_size, .bitmaps_last):
8158 * w32term.h (struct w32_display_info.icon_bitmap_id, .bitmaps_size)
8160 * xfaces.c (load_pixmap):
8161 * xterm.c (x_bitmap_icon, x_wm_set_icon_pixmap):
8162 * xterm.h (struct x_display_info.icon_bitmap_id, .bitmaps_size)
8163 (.bitmaps_last, struct x_output.icon_bitmap):
8164 Use ptrdiff_t, not int, for bitmap indexes.
8165 (x_allocate_bitmap_record): Check for size overflow.
8166 * dispextern.h, lisp.h: Adjust to API changes elsewhere.
8168 Use ptrdiff_t, not int, for overlay counts.
8169 * buffer.h (overlays_at, sort_overlays, GET_OVERLAYS_AT):
8170 * editfns.c (overlays_around, get_pos_property):
8171 * textprop.c (get_char_property_and_overlay):
8172 * xdisp.c (next_overlay_change, note_mouse_highlight):
8173 * xfaces.c (face_at_buffer_position):
8174 * buffer.c (OVERLAY_COUNT_MAX): New macro.
8175 (overlays_at, overlays_in, sort_overlays, Foverlays_at)
8176 (Fnext_overlay_change, Fprevious_overlay_change)
8177 (mouse_face_overlay_overlaps, Foverlays_in):
8178 Use ptrdiff_t, not int, for sizes.
8179 (overlays_at, overlays_in): Check for size-calculation overflow.
8181 * xterm.c (xim_initialize, same_x_server): Strlen may not fit in int.
8183 * xsmfns.c (smc_save_yourself_CB, x_session_initialize): Avoid strlen.
8184 (x_session_initialize): Do not assume string length fits in int.
8186 * xsettings.c (apply_xft_settings): Fix potential buffer overrun.
8187 This is unlikely, but can occur if DPI is outlandish.
8189 * xsettings.c (Ffont_get_system_normal_font, Ffont_get_system_font):
8190 * xselect.c (Fx_get_atom_name): Avoid need for strlen.
8192 * xrdb.c: Don't assume strlen fits in int; avoid some strlens.
8193 * xrdb.c (magic_file_p, search_magic_path):
8194 Omit last arg SUFFIX; it was always 0. All callers changed.
8195 (magic_file_p): Use ptrdiff_t, not int. Check for size overflow.
8197 * xfont.c (xfont_match): Avoid need for strlen.
8199 * xfns.c: Don't assume strlen fits in int.
8200 (xic_create_fontsetname, x_window): Use ptrdiff_t, not int.
8202 * xdisp.c (message_log_check_duplicate): Return intmax_t,
8203 not unsigned long, as we prefer signed integers. All callers changed.
8204 Detect integer overflow in repeat count.
8205 (message_dolog): Don't assume print length fits in 39 bytes.
8206 (display_mode_element): Don't assume strlen fits in int.
8208 * termcap.c: Don't assume sizes fit in int and never overflow.
8209 (struct termcap_buffer, tgetent): Use ptrdiff_t, not int, for sizes.
8210 (gobble_line): Check for size-calculation overflow.
8212 * minibuf.c (Fread_buffer):
8213 * lread.c (intern, intern_c_string):
8214 * image.c (xpm_scan) [HAVE_NS && !HAVE_XPM]:
8215 Don't assume string length fits in int.
8217 * keyboard.c (parse_tool_bar_item):
8218 * gtkutil.c (style_changed_cb): Avoid need for strlen.
8220 * font.c: Don't assume string length fits in int.
8221 (font_parse_xlfd, font_parse_fcname, font_unparse_fcname):
8222 Use ptrdiff_t, not int.
8223 (font_intern_prop): Don't assume string length fits in int.
8224 Don't assume integer property fits in fixnum.
8225 * font.h (font_intern_prop): 2nd arg is now ptrdiff_t, not int.
8227 * filelock.c: Fix some buffer overrun and integer overflow issues.
8228 (get_boot_time): Don't assume gzip command string fits in 100 bytes.
8229 Reformulate so as not to need the command string.
8230 Invoke gzip -cd rather than gunzip, as it's more portable.
8231 (lock_info_type, lock_file_1, lock_file):
8232 Don't assume pid_t and time_t fit in unsigned long.
8233 (LOCK_PID_MAX): Remove; we now use more-reliable bounds.
8234 (current_lock_owner): Prefer signed type for sizes.
8235 Use memcpy, not strncpy, where memcpy is what is really wanted.
8236 Don't assume (via atoi) that time_t and pid_t fit in int.
8237 Check for time_t and/or pid_t out of range, e.g., via a network share.
8238 Don't alloca where an auto var works fine.
8240 * fileio.c: Fix some integer overflow issues.
8241 (file_name_as_directory, Fexpand_file_name, Fsubstitute_in_file_name):
8242 Don't assume string length fits in int.
8243 (directory_file_name): Don't assume string length fits in long.
8244 (make_temp_name): Don't assume pid fits in int, or that its print
8245 length is less than 20.
8247 * data.c (Fsubr_name): Rewrite to avoid a strlen call.
8249 * coding.c (make_subsidiaries): Don't assume string length fits in int.
8251 * callproc.c (child_setup): Rewrite to avoid two strlen calls.
8253 * process.c (Fformat_network_address): Use EMACS_INT, not EMACS_UINT.
8254 We prefer signed integers, even for size calculations.
8256 * emacs.c: Don't assume string length fits in 'int'.
8257 (DEFINE_DUMMY_FUNCTION, sort_args): Use ptrdiff_t, not int.
8258 (main): Don't invoke strlen when not needed.
8260 * dbusbind.c (XD_ERROR): Don't arbitrarily truncate string.
8261 (XD_DEBUG_MESSAGE): Don't waste a byte.
8263 * callproc.c (getenv_internal_1, getenv_internal)
8265 * buffer.c (init_buffer): Don't assume string length fits in 'int'.
8267 * lread.c (invalid_syntax): Omit length argument.
8268 All uses changed. This doesn't fix a bug, but it simplifies the
8269 code away from its former Hollerith-constant appearance, and it's
8270 one less 'int' to worry about when looking at integer-overflow issues.
8271 (string_to_number): Simplify 2011-04-26 change by invoking xsignal1.
8273 * lisp.h (DEFUN): Remove bogus use of sizeof (struct Lisp_Subr).
8274 This didn't break anything, but it didn't help either.
8275 It's confusing to put a bogus integer in a place where the actual
8276 value does not matter.
8277 (LIST_END_P): Remove unused macro and its bogus comment.
8278 (make_fixnum_or_float): Remove unnecessary cast to EMACS_INT.
8280 * lisp.h (union Lisp_Object.i): EMACS_INT, not EMACS_UINT.
8281 This is for consistency with the ordinary, non-USE_LISP_UNION_TYPE,
8283 (struct Lisp_Bool_Vector.size): EMACS_INT, not EMACS_UINT.
8284 We prefer signed types, and the value cannot exceed the EMACS_INT
8285 range anyway (because otherwise the length would not be representable).
8286 (XSET) [USE_LISP_UNION_TYPE]: Use uintptr_t and intptr_t,
8287 not EMACS_UINT and EMACS_INT, when converting pointer to integer.
8288 This avoids a GCC warning when WIDE_EMACS_INT.
8290 * indent.c (sane_tab_width): New function.
8291 (current_column, scan_for_column, Findent_to, position_indentation)
8292 (compute_motion): Use it. This is just for clarity.
8293 (Fcompute_motion): Don't assume hscroll and tab offset fit in int.
8295 * image.c (xbm_image_p): Don't assume stated width, height fit in int.
8297 * lisp.h (lint_assume): New macro.
8298 * composite.c (composition_gstring_put_cache):
8299 * ftfont.c (ftfont_shape_by_flt): Use it to pacify GCC 4.6.0.
8301 * editfns.c, insdel.c:
8302 Omit unnecessary forward decls, to simplify future changes.
8304 * ftfont.c (ftfont_shape_by_flt): Use signed integers for lengths.
8306 * font.c (Ffont_shape_gstring): Don't assume glyph len fits in 'int'.
8308 * fns.c (Ffillarray): Don't assume bool vector size fits in 'int'.
8309 Use much-faster test for byte-length change.
8310 Don't assume string byte-length fits in 'int'.
8311 Check that character arg fits in 'int'.
8312 (mapcar1): Declare byte as byte, for clarity.
8314 * alloc.c (Fmake_bool_vector): Avoid unnecessary multiplication.
8316 * fns.c (concat): Catch string overflow earlier.
8317 Do not rely on integer wraparound.
8319 * dispextern.h (struct it.overlay_strings_charpos)
8320 (struct it.selective): Now EMACS_INT, not int.
8321 * xdisp.c (forward_to_next_line_start)
8322 (back_to_previous_visible_line_start)
8323 (reseat_at_next_visible_line_start, next_element_from_buffer):
8324 Don't arbitrarily truncate the value of 'selective' to int.
8326 * xdisp.c (init_iterator): Use XINT, not XFASTINT; it might be < 0.
8328 * composite.c: Don't truncate sizes to 'int'.
8329 (composition_gstring_p, composition_reseat_it)
8330 (composition_adjust_point): Use EMACS_INT, not int.
8331 (get_composition_id, composition_gstring_put_cache): Use EMACS_INT,
8332 not EMACS_UINT, for indexes.
8334 * category.h (CATEGORY_SET_P): Remove unnecessary cast to EMACS_INT.
8336 * buffer.c: Include <verify.h>.
8337 (struct sortvec.priority, struct sortstr.priority):
8338 Now EMACS_INT, not int.
8339 (compare_overlays, cmp_for_strings): Avoid subtraction overflow.
8340 (struct sortstr.size, record_overlay_string)
8341 (struct sortstrlist.size, struct sortlist.used):
8342 Don't truncate size to int.
8343 (record_overlay_string): Check for size-calculation overflow.
8344 (init_buffer_once): Check at compile-time, not run-time.
8346 2011-06-22 Jim Meyering <meyering@redhat.com>
8348 Don't leak an XBM-image-sized buffer
8349 * image.c (xbm_load): Free the image buffer after using it.
8351 2011-06-21 Paul Eggert <eggert@cs.ucla.edu>
8354 * composite.c (find_automatic_composition): Omit needless 'return 0;'
8355 that Sun C diagnosed.
8356 * fns.c (secure_hash): Fix pointer signedness issue.
8357 * intervals.c (static_offset_intervals): New function.
8358 (offset_intervals): Use it.
8360 2011-06-21 Leo Liu <sdl.web@gmail.com>
8363 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha256.h and
8366 * fns.c (secure_hash): Rename from crypto_hash_function and change
8367 the first arg to accept symbols.
8368 (Fsecure_hash): New primitive.
8369 (syms_of_fns): New symbols.
8371 2011-06-20 Deniz Dogan <deniz@dogan.se>
8373 * process.c (Fset_process_buffer): Clarify return value in
8376 2011-06-18 Chong Yidong <cyd@stupidchicken.com>
8378 * dispnew.c (add_window_display_history): Use BVAR.
8380 * xdisp.c (debug_method_add): Use BVAR.
8381 (check_window_end, dump_glyph_matrix, dump_glyph)
8382 (dump_glyph_row, dump_glyph_string): Convert arglist to ANSI C.
8384 * xfaces.c (check_lface_attrs, check_lface, dump_realized_face):
8387 * xfns.c (Fx_create_frame, x_create_tip_frame): Delay image cache
8388 check till after the cache is created in init_frame_faces.
8390 2011-06-17 Stefan Monnier <monnier@iro.umontreal.ca>
8392 * fns.c (Fsafe_length): Yet another int/Lisp_Object mixup.
8394 2011-06-16 Paul Eggert <eggert@cs.ucla.edu>
8396 * lisp.h: Include <limits.h>, for INT_MAX, LONG_MAX, LLONG_MAX.
8397 Without this, prin1 mishandles Lisp_Misc_Save_Value printing on
8398 hosts with pre-C99 libraries, because pD is wrongly defined to "t".
8400 Improve buffer-overflow checking (Bug#8873).
8401 * fileio.c (Finsert_file_contents):
8402 * insdel.c (insert_from_buffer_1, replace_range, replace_range_2):
8403 Remove the old (too-loose) buffer overflow checks.
8404 They weren't needed, since make_gap checks for buffer overflow.
8405 * insdel.c (make_gap_larger): Catch buffer overflows that were missed.
8406 The old code merely checked for Emacs fixnum overflow, and relied
8407 on undefined (wraparound) behavior. The new code avoids undefined
8408 behavior, and also checks for ptrdiff_t and/or size_t overflow.
8410 * editfns.c (Finsert_char): Don't dump core with very negative counts.
8411 Tune. Don't use wider integers than needed. Don't use alloca.
8412 Use a bigger 'string' buffer. Rewrite to avoid 'n > 0' test.
8414 * insdel.c (replace_range): Fix buf overflow when insbytes < outgoing.
8416 * insdel.c, lisp.h (buffer_overflow): New function.
8417 (insert_from_buffer_1, replace_range, replace_range_2):
8418 * insdel.c (make_gap_larger):
8419 * editfns.c (Finsert_char):
8420 * fileio.c (Finsert_file_contents): Use it, to normalize wording.
8422 * buffer.h (BUF_BYTES_MAX): Cast to ptrdiff_t so that it's signed.
8424 2011-06-15 Paul Eggert <eggert@cs.ucla.edu>
8426 Integer overflow and signedness fixes (Bug#8873, Bug#8828).
8428 * ccl.c (ASCENDING_ORDER): New macro, to work around GCC bug 43772.
8429 (GET_CCL_RANGE, IN_INT_RANGE): Use it.
8431 * fileio.c: Don't assume EMACS_INT fits in off_t.
8432 (emacs_lseek): New static function.
8433 (Finsert_file_contents, Fwrite_region): Use it.
8434 Use SEEK_SET, SEEK_CUR, SEEK_END as appropriate.
8436 * fns.c (Fload_average): Don't assume 100 * load average fits in int.
8438 * fns.c: Don't overflow int when computing a list length.
8439 * fns.c (QUIT_COUNT_HEURISTIC): New constant.
8440 (Flength, Fsafe_length): Use EMACS_INT, not int, to avoid unwanted
8441 truncation on 64-bit hosts. Check for QUIT every
8442 QUIT_COUNT_HEURISTIC entries rather than every other entry; that's
8443 faster and is responsive enough.
8444 (Flength): Report an error instead of overflowing an integer.
8445 (Fsafe_length): Return a float if the value is not representable
8446 as a fixnum. This shouldn't happen except in contrived situations.
8447 (Fnthcdr, Fsort): Don't assume list length fits in int.
8448 (Fcopy_sequence): Don't assume vector length fits in int.
8450 * alloc.c: Check that resized vectors' lengths fit in fixnums.
8451 (header_size, word_size): New constants.
8452 (allocate_vectorlike): Don't check size overflow here.
8453 (allocate_vector): Check it here instead, since this is the only
8454 caller of allocate_vectorlike that could cause overflow.
8455 Check that the new vector's length is representable as a fixnum.
8457 * fns.c (next_almost_prime): Don't return a multiple of 3 or 5.
8458 The previous code was bogus. For example, next_almost_prime (32)
8459 returned 39, which is undesirable as it is a multiple of 3; and
8460 next_almost_prime (24) returned 25, which is a multiple of 5 so
8461 why was the code bothering to check for multiples of 7?
8463 * bytecode.c (exec_byte_code): Use ptrdiff_t, not int, for vector length.
8465 * eval.c, doprnt.c (SIZE_MAX): Remove; inttypes.h defines this now.
8467 Variadic C functions now count arguments with ptrdiff_t.
8468 This partly undoes my 2011-03-30 change, which replaced int with size_t.
8469 Back then I didn't know that the Emacs coding style prefers signed int.
8470 Also, in the meantime I found a few more instances where arguments
8471 were being counted with int, which may truncate counts on 64-bit
8472 machines, or EMACS_INT, which may be unnecessarily wide.
8473 * lisp.h (struct Lisp_Subr.function.aMANY)
8474 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call):
8475 Arg counts are now ptrdiff_t, not size_t.
8476 All variadic functions and their callers changed accordingly.
8477 (struct gcpro.nvars): Now size_t, not size_t. All uses changed.
8478 * bytecode.c (exec_byte_code): Check maxdepth for overflow,
8479 to avoid potential buffer overrun. Don't assume arg counts fit in 'int'.
8480 * callint.c (Fcall_interactively): Check arg count for overflow,
8481 to avoid potential buffer overrun. Use signed char, not 'int',
8482 for 'varies' array, so that we needn't bother to check its size
8483 calculation for overflow.
8484 * editfns.c (Fformat): Use ptrdiff_t, not EMACS_INT, to count args.
8485 * eval.c (apply_lambda):
8486 * fns.c (Fmapconcat): Use XFASTINT, not XINT, to get args length.
8487 (struct textprop_rec.argnum): Now ptrdiff_t, not int. All uses changed.
8488 (mapconcat): Use ptrdiff_t, not int and EMACS_INT, to count args.
8490 * callint.c (Fcall_interactively): Don't use index var as event count.
8492 * vm-limit.c (check_memory_limits): Fix incorrect extern function decls.
8493 * mem-limits.h (SIZE): Remove; no longer used.
8495 * xterm.c (x_alloc_nearest_color_1): Prefer int to long when int works.
8497 Remove unnecessary casts.
8498 * xterm.c (x_term_init):
8499 * xfns.c (x_set_border_pixel):
8500 * widget.c (create_frame_gcs): Remove casts to unsigned long etc.
8501 These aren't needed now that we assume ANSI C.
8503 * sound.c (Fplay_sound_internal): Remove cast to unsigned long.
8504 It's more likely to cause problems (due to unsigned overflow)
8507 * dired.c (Ffile_attributes): Don't use 32-bit hack on 64-bit hosts.
8509 * unexelf.c (unexec): Don't assume BSS addr fits in unsigned.
8511 * xterm.c (handle_one_xevent): Omit unnecessary casts to unsigned.
8513 * keyboard.c (modify_event_symbol): Don't limit alist len to UINT_MAX.
8515 * lisp.h (CHAR_TABLE_SET): Omit now-redundant test.
8517 * lread.c (Fload): Don't compare a possibly-garbage time_t value.
8519 GLYPH_CODE_FACE returns EMACS_INT, not int.
8520 * dispextern.h (merge_faces):
8521 * xfaces.c (merge_faces):
8522 * xdisp.c (get_next_display_element, next_element_from_display_vector):
8523 Don't assume EMACS_INT fits in int.
8525 * character.h (CHAR_VALID_P): Remove unused parameter.
8526 * fontset.c, lisp.h, xdisp.c: All uses changed.
8528 * editfns.c (Ftranslate_region_internal): Omit redundant test.
8530 * fns.c (concat): Minor tuning based on overflow analysis.
8531 This doesn't fix any bugs. Use int to hold character, instead
8532 of constantly refetching from Emacs object. Use XFASTINT, not
8533 XINT, for value known to be a character. Don't bother comparing
8534 a single byte to 0400, as it's always less.
8536 * floatfns.c (Fexpt):
8537 * fileio.c (make_temp_name): Omit unnecessary cast to unsigned.
8539 * editfns.c (Ftranslate_region_internal): Use int, not EMACS_INT
8542 * doc.c (get_doc_string): Omit (unsigned)c that mishandled negatives.
8544 * data.c (Faset): If ARRAY is a string, check that NEWELT is a char.
8545 Without this fix, on a 64-bit host (aset S 0 4294967386) would
8546 incorrectly succeed when S was a string, because 4294967386 was
8547 truncated before it was used.
8549 * chartab.c (Fchar_table_range): Use CHARACTERP to check range.
8550 Otherwise, an out-of-range integer could cause undefined behavior
8553 * composite.c: Use int, not EMACS_INT, for characters.
8554 (fill_gstring_body, composition_compute_stop_pos): Use int, not
8555 EMACS_INT, for values that are known to be in character range.
8556 This doesn't fix any bugs but is the usual style inside Emacs and
8557 may generate better code on 32-bit machines.
8559 Make sure a 64-bit char is never passed to ENCODE_CHAR.
8560 This is for reasons similar to the recent CHAR_STRING fix.
8561 * charset.c (Fencode_char): Check that character arg is actually
8562 a character. Pass an int to ENCODE_CHAR.
8563 * charset.h (ENCODE_CHAR): Verify that the character argument is no
8564 wider than 'int', as a compile-time check to prevent future regressions
8567 * character.c (char_string): Remove unnecessary casts.
8569 Make sure a 64-bit char is never passed to CHAR_STRING.
8570 Otherwise, CHAR_STRING would do the wrong thing on a 64-bit platform,
8571 by silently ignoring the top 32 bits, allowing some values
8572 that were far too large to be valid characters.
8573 * character.h: Include <verify.h>.
8574 (CHAR_STRING, CHAR_STRING_ADVANCE): Verify that the character
8575 arguments are no wider than unsigned, as a compile-time check
8576 to prevent future regressions in this area.
8578 * editfns.c (Fchar_to_string, general_insert_function, Finsert_char)
8579 (Fsubst_char_in_region):
8581 * xdisp.c (decode_mode_spec_coding):
8582 Adjust to CHAR_STRING's new requirement.
8583 * editfns.c (Finsert_char, Fsubst_char_in_region):
8584 * fns.c (concat): Check that character args are actually
8585 characters. Without this test, these functions did the wrong
8586 thing with wildly out-of-range values on 64-bit hosts.
8588 Remove incorrect casts to 'unsigned' that lose info on 64-bit hosts.
8589 These casts should not be needed on 32-bit hosts, either.
8590 * keyboard.c (read_char):
8591 * lread.c (Fload): Remove casts to unsigned.
8593 * lisp.h (UNSIGNED_CMP): New macro.
8594 This fixes comparison bugs on 64-bit hosts.
8595 (ASCII_CHAR_P): Use it.
8596 * casefiddle.c (casify_object):
8597 * character.h (ASCII_BYTE_P, CHAR_VALID_P)
8598 (SINGLE_BYTE_CHAR_P, CHAR_STRING):
8599 * composite.h (COMPOSITION_ENCODE_RULE_VALID):
8600 * dispextern.h (FACE_FROM_ID):
8601 * keyboard.c (read_char): Use UNSIGNED_CMP.
8603 * xmenu.c (dialog_selection_callback) [!USE_GTK]: Cast to intptr_t,
8604 not to EMACS_INT, to avoid GCC warning.
8606 * xfns.c (x_set_scroll_bar_default_width): Remove unused 'int' locals.
8608 * buffer.h (PTR_BYTE_POS, BUF_PTR_BYTE_POS): Remove harmful cast.
8609 The cast incorrectly truncated 64-bit byte offsets to 32 bits, and
8610 isn't needed on 32-bit machines.
8612 * buffer.c (Fgenerate_new_buffer_name):
8613 Use EMACS_INT for count, not int.
8614 (advance_to_char_boundary): Return EMACS_INT, not int.
8616 * data.c (Qcompiled_function): Now static.
8618 * window.c (window_body_lines): Now static.
8620 * image.c (gif_load): Rename local to avoid shadowing.
8622 * lisp.h (SAFE_ALLOCA_LISP): Check for integer overflow.
8623 (struct Lisp_Save_Value): Use ptrdiff_t, not int, for 'integer' member.
8624 * alloc.c (make_save_value): Integer argument is now of type
8626 (mark_object): Use ptrdiff_t, not int.
8627 * lisp.h (pD): New macro.
8628 * print.c (print_object): Use it.
8630 * alloc.c: Use EMACS_INT, not int, to count objects.
8631 (total_conses, total_markers, total_symbols, total_vector_size)
8632 (total_free_conses, total_free_markers, total_free_symbols)
8633 (total_free_floats, total_floats, total_free_intervals)
8634 (total_intervals, total_strings, total_free_strings):
8635 Now EMACS_INT, not int. All uses changed.
8636 (Fgarbage_collect): Compute overall total using a double, so that
8637 integer overflow is less likely to be a problem. Check for overflow
8638 when converting back to an integer.
8639 (n_interval_blocks, n_string_blocks, n_float_blocks, n_cons_blocks)
8640 (n_vectors, n_symbol_blocks, n_marker_blocks): Remove.
8641 These were 'int' variables that could overflow on 64-bit hosts;
8642 they were never used, so remove them instead of repairing them.
8643 (nzombies, ngcs, max_live, max_zombies): Now EMACS_INT, not 'int'.
8644 (inhibit_garbage_collection): Set gc_cons_threshold to max value.
8645 Previously, this ceilinged at INT_MAX, but that doesn't work on
8647 (allocate_pseudovector): Don't use EMACS_INT when int would do.
8649 * alloc.c (Fmake_bool_vector): Don't assume vector size fits in int.
8650 (allocate_vectorlike): Check for ptrdiff_t overflow.
8651 (mark_vectorlike, mark_char_table, mark_object): Avoid EMACS_UINT
8652 when a (possibly-narrower) signed value would do just as well.
8653 We prefer using signed arithmetic, to avoid comparison confusion.
8655 * alloc.c: Catch some string size overflows that we were missing.
8656 (XMALLOC_OVERRUN_CHECK_SIZE) [!XMALLOC_OVERRUN_CHECK]: Define to 0,
8657 for convenience in STRING_BYTES_MAX.
8658 (STRING_BYTES_MAX): New macro, superseding the old one in lisp.h.
8659 The definition here is exact; the one in lisp.h was approximate.
8660 (allocate_string_data): Check for string overflow. This catches
8661 some instances we weren't catching before. Also, it catches
8662 size_t overflow on (unusual) hosts where SIZE_MAX <= min
8663 (PTRDIFF_MAX, MOST_POSITIVE_FIXNUM), e.g., when size_t is 32 bits
8664 and ptrdiff_t and EMACS_INT are both 64 bits.
8666 * character.c, coding.c, doprnt.c, editfns.c, eval.c:
8667 All uses of STRING_BYTES_MAX replaced by STRING_BYTES_BOUND.
8668 * lisp.h (STRING_BYTES_BOUND): Rename from STRING_BYTES_MAX.
8670 * character.c (string_escape_byte8): Fix nbytes/nchars typo.
8672 * alloc.c (Fmake_string): Check for out-of-range init.
8674 2011-06-15 Stefan Monnier <monnier@iro.umontreal.ca>
8676 * eval.c (Fdefvaralias): Also mark the target as variable-special-p.
8678 2011-06-14 Jan Djärv <jan.h.d@swipnet.se>
8680 * xfns.c (x_set_scroll_bar_default_width): Remove argument to
8681 xg_get_default_scrollbar_width.
8683 * gtkutil.c: Include emacsgtkfixed.h if HAVE_GTK3.
8684 (int_gtk_range_get_value): Move to the scroll bar part of the file.
8685 (style_changed_cb): Call update_theme_scrollbar_width and call
8686 x_set_scroll_bar_default_width and xg_frame_set_char_size for
8687 all frames (Bug#8505).
8688 (xg_create_frame_widgets): Call emacs_fixed_new if HAVE_GTK3 (Bug#8505).
8689 Call gtk_window_set_resizable if HAVE_GTK3.
8690 (x_wm_set_size_hint): Call emacs_fixed_set_min_size with min width
8691 and height if HAVE_GTK3 (Bug#8505).
8692 (scroll_bar_width_for_theme): New variable.
8693 (update_theme_scrollbar_width): New function.
8694 (xg_get_default_scrollbar_width): Move code to
8695 update_theme_scrollbar_width, just return scroll_bar_width_for_theme.
8696 (xg_initialize): Call update_theme_scrollbar_width.
8698 * gtkutil.h (xg_get_default_scrollbar_width): Remove argument.
8700 * emacsgtkfixed.c, emacsgtkfixed.h: New files.
8702 2011-06-12 Martin Rudalics <rudalics@gmx.at>
8704 * frame.c (make_frame): Call other_buffer_safely instead of
8707 * window.c (temp_output_buffer_show): Call display_buffer with
8708 second argument Vtemp_buffer_show_specifiers and reset latter
8709 immediately after the call.
8710 (Vtemp_buffer_show_specifiers): New variable.
8711 (auto_window_vscroll_p, next_screen_context_lines)
8712 (Vscroll_preserve_screen_position): Remove leading asterisks from
8715 2011-06-12 Paul Eggert <eggert@cs.ucla.edu>
8717 Fix minor problems found by GCC 4.6.0 static checking.
8718 * buffer.c (Qclone_number): Remove for now, as it's unused.
8719 (record_buffer, Funrecord_buffer): Rename local to avoid shadowing.
8720 (record_buffer): Remove unused local.
8721 * frame.c (other_visible_frames, frame_buffer_list): Now static.
8722 (set_frame_buffer_list): Remove; unused.
8723 * frame.h (other_visible_frames): Remove decl.
8724 * keyboard.h (menu_items_inuse): Declare only if USE_GTK || USE_MOTIF.
8725 * lisp.h (frame_buffer_list, set_frame_buffer_list): Remove decls.
8726 (add_gpm_wait_descriptor, delete_gpm_wait_descriptor): Declare only
8728 * menu.c (menu_items_inuse): Now static unless USE_GTK || USE_MOTIF.
8729 * process.c (add_gpm_wait_descriptor, delete_gpm_wait_descriptor):
8730 Define only if HAVE_GPM.
8731 * widget.c (EmacsFrameResize, emacsFrameClassRec): Now static.
8732 (update_hints_inhibit): Remove; never set. All uses removed.
8733 * widgetprv.h (emacsFrameClassRec): Remove decl.
8734 * window.c (delete_deletable_window): Now returns void, since it
8735 wasn't returning anything.
8736 (compare_window_configurations): Remove unused locals.
8737 * xfns.c (x_set_scroll_bar_default_width): Remove unused locals.
8738 * xmenu.c (x_menu_set_in_use): Define only if USE_GTK || USE_MOTIF.
8739 (dialog_selection_callback) [!USE_GTK]: Prefer intptr_t for integers
8740 the same widths as pointers. This follows up on the 2011-05-06 patch.
8741 * xterm.c (x_alloc_lighter_color_for_widget): Define only if USE_LUCID.
8742 * xterm.h: Likewise.
8743 (x_menu_set_in_use): Declare only if USE_GTK || USE_MOTIF.
8745 2011-06-12 Juanma Barranquero <lekktu@gmail.com>
8747 * makefile.w32-in: Update dependencies.
8748 (LISP_H): Add lib/intprops.h.
8750 2011-06-11 Chong Yidong <cyd@stupidchicken.com>
8752 * image.c (gif_load): Add animation frame delay to the metadata.
8753 (syms_of_image): Use DEFSYM. New symbol `delay'.
8755 2011-06-11 Martin Rudalics <rudalics@gmx.at>
8757 * window.c (delete_deletable_window): Re-add.
8758 (Fset_window_configuration): Rewrite to handle dead buffers and
8759 consequently deletable windows.
8760 (window_tree, Fwindow_tree): Remove. Supply functionality in
8762 (compare_window_configurations): Simplify code.
8764 2011-06-11 Andreas Schwab <schwab@linux-m68k.org>
8766 * image.c (imagemagick_load_image): Fix type mismatch.
8767 (Fimagemagick_types): Likewise.
8769 * window.h (replace_buffer_in_windows): Declare.
8771 2011-06-11 Martin Rudalics <rudalics@gmx.at>
8773 * buffer.c: New Lisp objects Qbuffer_list_update_hook and
8774 Qclone_number. Remove external declaration of Qdelete_window.
8775 (Fbuffer_list): Rewrite doc-string. Minor restructuring of
8777 (Fget_buffer_create, Fmake_indirect_buffer, Frename_buffer):
8778 Run Qbuffer_list_update_hook if allowed.
8779 (Fother_buffer): Rewrite doc-string. Major rewrite for new
8780 buffer list implementation.
8781 (other_buffer_safely): New function.
8782 (Fkill_buffer): Replace call to replace_buffer_in_all_windows by
8783 calls to replace_buffer_in_windows and
8784 replace_buffer_in_windows_safely. Run Qbuffer_list_update_hook
8786 (record_buffer): Inhibit quitting and rewrite using quittable
8787 functions. Run Qbuffer_list_update_hook if allowed.
8788 (Frecord_buffer, Funrecord_buffer): New functions.
8789 (switch_to_buffer_1, Fswitch_to_buffer): Remove.
8790 Move switch-to-buffer to window.el.
8791 (bury-buffer): Move to window.el.
8792 (Vbuffer_list_update_hook): New variable.
8794 * lisp.h (other_buffer_safely): Add prototype in buffer.c
8797 * window.h (resize_frame_windows): Move up in code.
8798 (Fwindow_frame): Remove EXFUN.
8799 (replace_buffer_in_all_windows): Remove prototype.
8800 (replace_buffer_in_windows_safely): Add prototype.
8802 * window.c: Declare Qdelete_window static again. Move down
8803 declaration of select_count.
8804 (Fnext_window, Fprevious_window): Rewrite doc-strings.
8805 (Fother_window): Move to window.el.
8806 (window_loop): Remove DELETE_BUFFER_WINDOWS and UNSHOW_BUFFER
8807 cases. Add REPLACE_BUFFER_IN_WINDOWS_SAFELY case.
8808 (Fdelete_windows_on, Freplace_buffer_in_windows): Move to
8810 (replace_buffer_in_windows): Implement by calling
8811 Qreplace_buffer_in_windows.
8812 (replace_buffer_in_all_windows): Remove with some functionality
8813 moved into replace_buffer_in_windows_safely.
8814 (replace_buffer_in_windows_safely): New function.
8815 (select_window_norecord, select_frame_norecord): Move in front
8816 of run_window_configuration_change_hook. Remove now obsolete
8818 (Fset_window_buffer): Rewrite doc-string.
8819 Call Qrecord_window_buffer.
8820 (keys_of_window): Move binding for other-window to window.el.
8822 2011-06-11 Chong Yidong <cyd@stupidchicken.com>
8824 * dispextern.h (struct image): Replace data member, whose int_val
8825 and ptr_val fields were not used by anything, with a single
8828 * image.c (Fimage_metadata, make_image, mark_image, tiff_load)
8829 (gif_clear_image, gif_load, imagemagick_load_image)
8830 (gs_clear_image, gs_load): Callers changed.
8832 2011-06-10 Paul Eggert <eggert@cs.ucla.edu>
8834 * buffer.h: Include <time.h>, for time_t.
8835 Needed to build on FreeBSD 8.2. Problem reported by Herbert J. Skuhra.
8837 Fix minor problems found by static checking.
8839 * image.c (PixelGetMagickColor): Declare if ImageMagick headers don't.
8841 Make identifiers static if they are not used in other modules.
8842 * data.c (Qcompiled_function, Qframe, Qvector):
8843 * image.c (QimageMagick, Qsvg):
8844 * minibuf.c (Qmetadata):
8845 * window.c (resize_window_check, resize_root_window): Now static.
8846 * window.h (resize_window_check, resize_root_window): Remove decls.
8848 * window.c (window_deletion_count, delete_deletable_window):
8850 (window_body_lines): Now static.
8851 (Fdelete_other_windows_internal): Mark vars as initialized.
8852 Make sure 'resize_failed' is initialized.
8853 (run_window_configuration_change_hook): Rename local to avoid shadowing.
8854 (resize_window_apply): Remove unused local.
8855 * window.h (delete_deletable_window): Remove decl.
8857 * image.c (gif_load, svg_load_image): Rename locals to avoid shadowing.
8858 (imagemagick_load_image): Fix pointer signedness problem by changing
8859 last arg from unsigned char * to char *. All uses changed.
8860 Also, fix a local for similar reasons.
8861 Remove unused locals. Remove locals to avoid shadowing.
8862 (fn_rsvg_handle_free): Remove; unused.
8863 (svg_load, svg_load_image): Fix pointer signedness problem.
8864 (imagemagick_load_image): Don't use garbage pointer image_wand.
8866 * ftfont.c (ftfont_get_metrics, ftfont_drive_otf): Remove unused locals.
8868 2011-06-10 Chong Yidong <cyd@stupidchicken.com>
8870 * image.c (gif_load): Fix omitted cast error introduced by
8873 2011-06-10 Martin Rudalics <rudalics@gmx.at>
8875 * window.h (resize_proportionally, orig_total_lines)
8876 (orig_top_line): Remove from window structure.
8877 (set_window_height, set_window_width, change_window_heights)
8878 (Fdelete_window): Remove prototypes.
8879 (resize_frame_windows): Remove duplicate declaration.
8881 2011-06-10 Eli Zaretskii <eliz@gnu.org>
8883 * window.h (resize_frame_windows, resize_window_check)
8884 (delete_deletable_window, resize_root_window)
8885 (resize_frame_windows): Declare prototypes.
8887 * window.c (resize_window_apply): Make definition be "static" to
8888 match the prototype.
8890 2011-06-10 Martin Rudalics <rudalics@gmx.at>
8892 * window.c: Remove declarations of Qwindow_size_fixed,
8893 window_min_size_1, window_min_size_2, window_min_size,
8894 size_window, window_fixed_size_p, enlarge_window, delete_window.
8895 Remove static from declaration of Qdelete_window, it's
8896 temporarily needed by Fbury_buffer.
8897 (replace_window): Don't assign orig_top_line and
8899 (Fdelete_window, delete_window): Remove. Window deletion is
8900 handled by window.el.
8901 (window_loop): Remove DELETE_OTHER_WINDOWS case.
8902 Replace Fdelete_window calls with calls to Qdelete_window.
8903 (Fdelete_other_windows): Remove. Deleting other windows is
8904 handled by window.el.
8905 (window_fixed_size_p): Remove. Fixed-sizeness of windows is
8906 handled in window.el.
8907 (window_min_size_2, window_min_size_1, window_min_size): Remove.
8908 Window minimum sizes are handled in window.el.
8909 (shrink_windows, size_window, set_window_height)
8910 (set_window_width, change_window_heights, window_height)
8911 (window_width, CURBEG, CURSIZE, enlarge_window)
8912 (adjust_window_trailing_edge, Fadjust_window_trailing_edge)
8913 (Fenlarge_window, Fshrink_window): Remove. Window resizing is
8914 handled in window.el.
8915 (make_dummy_parent): Rename to make_parent_window and give it a
8916 second argument horflag.
8917 (make_window): Don't set resize_proportionally any more.
8918 (Fsplit_window): Remove. Windows are split in window.el.
8919 (save_restore_action, save_restore_orig_size)
8920 (shrink_window_lowest_first, save_restore_orig_size): Remove.
8921 Resize mini windows in window.el.
8922 (grow_mini_window, shrink_mini_window): Implement by calling
8923 Qresize_root_window_vertically, resize_window_check and
8924 resize_window_apply.
8925 (saved_window, Fset_window_configuration, save_window_save):
8926 Do not handle orig_top_line, orig_total_lines, and
8927 resize_proportionally.
8928 (window_min_height, window_min_width): Move to window.el.
8929 (keys_of_window): Move bindings for delete-other-windows,
8930 split-window, delete-window and enlarge-window to window.el.
8932 * buffer.c: Temporarily extern Qdelete_window.
8933 (Fbury_buffer): Temporarily call Qdelete_window instead of
8934 Fdelete_window (Fbury_buffer will move to window.el soon).
8936 * frame.c (set_menu_bar_lines_1): Remove code handling
8937 orig_top_line and orig_total_lines.
8939 * dispnew.c (adjust_frame_glyphs_initially): Don't use
8940 set_window_height but set heights directly.
8941 (change_frame_size_1): Use resize_frame_windows.
8943 * xdisp.c (init_xdisp): Don't use set_window_height but set
8946 * xfns.c (x_set_menu_bar_lines, x_set_tool_bar_lines):
8947 Use resize_frame_windows instead of change_window_heights and run
8948 run_window_configuration_change_hook.
8950 * w32fns.c (x_set_tool_bar_lines): Use resize_frame_windows
8951 instead of change_window_heights and run
8952 run_window_configuration_change_hook.
8954 2011-06-09 Martin Rudalics <rudalics@gmx.at>
8956 * window.c (replace_window): Rename second argument REPLACEMENT to
8957 NEW. New third argument SETFLAG. Rewrite.
8958 (delete_window, make_dummy_parent): Call replace_window with
8960 (window_list_1): Move down in code.
8961 (run_window_configuration_change_hook): Move set_buffer part
8962 before select_frame_norecord part in order to unwind correctly.
8963 Rename count1 to count.
8964 (recombine_windows, delete_deletable_window, resize_root_window)
8965 (Fdelete_other_windows_internal)
8966 (Frun_window_configuration_change_hook, make_parent_window)
8967 (resize_window_check, resize_window_apply, Fresize_window_apply)
8968 (resize_frame_windows, Fsplit_window_internal)
8969 (Fdelete_window_internal, Fresize_mini_window_internal):
8971 (syms_of_window): New variables Vwindow_splits and Vwindow_nest.
8973 2011-06-08 Martin Rudalics <rudalics@gmx.at>
8975 * window.h (window): Add some new members to window structure -
8976 normal_lines, normal_cols, new_total, new_normal, clone_number,
8977 splits, nest, prev_buffers, next_buffers.
8978 (WINDOW_TOTAL_SIZE): Move here from window.c.
8979 (MIN_SAFE_WINDOW_WIDTH, MIN_SAFE_WINDOW_HEIGHT): Define here.
8981 * window.c (Fwindow_height, Fwindow_width, Fwindow_full_width_p):
8983 (make_dummy_parent): Set new members of windows structure.
8984 (make_window): Move down in code. Handle new members of window
8986 (Fwindow_clone_number, Fwindow_splits, Fset_window_splits)
8987 (Fwindow_nest, Fset_window_nest, Fwindow_new_total)
8988 (Fwindow_normal_size, Fwindow_new_normal, Fwindow_prev_buffers)
8989 (Fset_window_prev_buffers, Fwindow_next_buffers)
8990 (Fset_window_next_buffers, Fset_window_clone_number):
8992 (Fwindow_hscroll, Fwindow_at, Fwindow_point, Fwindow_start)
8993 (Fwindow_end, Fwindow_line_height, Fset_window_dedicated_p):
8995 (Fwindow_parameters, Fwindow_parameter, Fset_window_parameter):
8996 Argument WINDOW can be now internal window too.
8997 (Fwindow_use_time): Move up in code.
8998 (Fget_buffer_window): Rename argument FRAME to ALL-FRAMES.
9000 (Fset_window_configuration, saved_window)
9001 (Fcurrent_window_configuration, save_window_save): Handle new
9002 members of window structure.
9003 (WINDOW_TOTAL_SIZE, MIN_SAFE_WINDOW_WIDTH)
9004 (MIN_SAFE_WINDOW_HEIGHT): Move to window.h.
9005 (syms_of_window): New Lisp objects Qrecord_window_buffer,
9006 Qwindow_deletable_p, Qdelete_window, Qreplace_buffer_in_windows,
9007 Qget_mru_window, Qresize_root_window,
9008 Qresize_root_window_vertically, Qsafe, Qabove, Qbelow,
9009 Qauto_buffer_name; staticpro them.
9011 2011-06-07 Martin Rudalics <rudalics@gmx.at>
9013 * window.c (Fwindow_total_size, Fwindow_left_column)
9014 (Fwindow_top_line, window_body_lines, Fwindow_body_size)
9015 (Fwindow_list_1): New functions.
9016 (window_box_text_cols): Replace with window_body_cols.
9017 (Fwindow_width, Fscroll_left, Fscroll_right):
9018 Use window_body_cols instead of window_box_text_cols.
9019 (delete_window, Fset_window_configuration):
9020 Call delete_all_subwindows with window as argument.
9021 (delete_all_subwindows): Take a window as argument and not a
9023 (window_loop): Remove handling of GET_LRU_WINDOW and
9025 (Fget_lru_window, Fget_largest_window): Move to window.el.
9027 * window.h: Extern window_body_cols instead of
9028 window_box_text_cols. delete_all_subwindows now takes a
9029 Lisp_Object as argument.
9031 * indent.c (compute_motion, Fcompute_motion):
9032 Use window_body_cols instead of window_box_text_cols.
9034 * frame.c (delete_frame): Call delete_all_subwindows with root
9037 2011-06-07 Daniel Colascione <dan.colascione@gmail.com>
9039 * fns.c (Fputhash): Document return value.
9041 2011-06-06 Chong Yidong <cyd@stupidchicken.com>
9043 * image.c (gif_load): Implement gif89a spec "no disposal" method.
9045 2011-06-06 Paul Eggert <eggert@cs.ucla.edu>
9047 Cons<->int and similar integer overflow fixes (Bug#8794).
9049 Check for overflow when converting integer to cons and back.
9050 * charset.c (Fdefine_charset_internal, Fdecode_char):
9051 Use cons_to_unsigned to catch overflow.
9052 (Fencode_char): Use INTEGER_TO_CONS.
9053 * composite.h (LGLYPH_CODE): Use cons_to_unsigned.
9054 (LGLYPH_SET_CODE): Use INTEGER_TO_CONS.
9055 * data.c (long_to_cons, cons_to_long): Remove.
9056 (cons_to_unsigned, cons_to_signed): New functions.
9057 These signal an error for invalid or out-of-range values.
9058 * dired.c (Ffile_attributes): Use INTEGER_TO_CONS.
9059 * fileio.c (Fset_visited_file_modtime): Use CONS_TO_INTEGER.
9060 * font.c (Ffont_variation_glyphs):
9061 * fontset.c (Finternal_char_font): Use INTEGER_TO_CONS.
9062 * lisp.h: Include <intprops.h>.
9063 (INTEGER_TO_CONS, CONS_TO_INTEGER): New macros.
9064 (cons_to_signed, cons_to_unsigned): New decls.
9065 (long_to_cons, cons_to_long): Remove decls.
9066 * undo.c (record_first_change): Use INTEGER_TO_CONS.
9067 (Fprimitive_undo): Use CONS_TO_INTEGER.
9068 * xfns.c (Fx_window_property): Likewise.
9069 * xselect.c: Include <limits.h>.
9070 (x_own_selection, selection_data_to_lisp_data):
9071 Use INTEGER_TO_CONS.
9072 (x_handle_selection_request, x_handle_selection_clear)
9073 (x_get_foreign_selection, Fx_disown_selection_internal)
9074 (Fx_get_atom_name, x_send_client_event): Use CONS_TO_INTEGER.
9075 (lisp_data_to_selection_data): Use cons_to_unsigned.
9076 (x_fill_property_data): Use cons_to_signed.
9077 Report values out of range.
9079 Check for buffer and string overflow more precisely.
9080 * buffer.h (BUF_BYTES_MAX): New macro.
9081 * lisp.h (STRING_BYTES_MAX): New macro.
9082 * alloc.c (Fmake_string):
9083 * character.c (string_escape_byte8):
9084 * coding.c (coding_alloc_by_realloc):
9085 * doprnt.c (doprnt):
9086 * editfns.c (Fformat):
9088 Use STRING_BYTES_MAX, not MOST_POSITIVE_FIXNUM,
9089 since they may not be the same number.
9090 * editfns.c (Finsert_char):
9091 * fileio.c (Finsert_file_contents):
9092 Likewise for BUF_BYTES_MAX.
9094 * image.c: Use ptrdiff_t, not int, for sizes.
9095 (slurp_file): Switch from int to ptrdiff_t.
9097 (slurp_file): Check that file size fits in both size_t (for
9098 malloc) and ptrdiff_t (for sanity and safety).
9100 * fileio.c (Fverify_visited_file_modtime): Avoid time overflow
9101 if b->modtime has its maximal value.
9103 * dired.c (Ffile_attributes): Don't assume EMACS_INT has >32 bits.
9105 Don't assume time_t can fit into int.
9106 * buffer.h (struct buffer.modtime): Now time_t, not int.
9107 * fileio.c (Fvisited_file_modtime): No need for time_t cast now.
9108 * undo.c (Fprimitive_undo): Use time_t, not int, for time_t value.
9110 Minor fixes for signed vs unsigned integers.
9111 * character.h (MAYBE_UNIFY_CHAR):
9112 * charset.c (maybe_unify_char):
9113 * keyboard.c (read_char, reorder_modifiers):
9114 XINT -> XFASTINT, since the integer must be nonnegative.
9115 * ftfont.c (ftfont_spec_pattern):
9116 * keymap.c (access_keymap, silly_event_symbol_error):
9117 XUINT -> XFASTINT, since the integer must be nonnegative.
9118 (Fsingle_key_description, preferred_sequence_p): XUINT -> XINT,
9119 since it makes no difference and we prefer signed.
9120 * keyboard.c (record_char): Use XUINT when all the neighbors do.
9121 (access_keymap): NATNUMP -> INTEGERP, since the integer must be
9124 2011-06-06 Stefan Monnier <monnier@iro.umontreal.ca>
9126 * window.h (Fwindow_frame): Declare.
9128 2011-06-06 Paul Eggert <eggert@cs.ucla.edu>
9130 * alloc.c: Simplify handling of large-request failures (Bug#8800).
9131 (SPARE_MEMORY): Always define.
9132 (LARGE_REQUEST): Remove.
9133 (memory_full): Use SPARE_MEMORY rather than LARGE_REQUEST.
9135 2011-06-06 Martin Rudalics <rudalics@gmx.at>
9137 * lisp.h: Move EXFUNS for Fframe_root_window,
9138 Fframe_first_window and Fset_frame_selected_window to window.h.
9140 * window.h: Move EXFUNS for Fframe_root_window,
9141 Fframe_first_window and Fset_frame_selected_window here from
9144 * frame.c (Fwindow_frame, Fframe_first_window)
9145 (Fframe_root_window, Fframe_selected_window)
9146 (Fset_frame_selected_window): Move to window.c.
9147 (Factive_minibuffer_window): Move to minibuf.c.
9148 (Fother_visible_frames_p): New function.
9150 * minibuf.c (Factive_minibuffer_window): Move here from frame.c.
9152 * window.c (decode_window, decode_any_window): Move up in code.
9153 (Fwindowp, Fwindow_live_p): Rewrite doc-strings.
9154 (inhibit_frame_unsplittable): Remove unused variable.
9155 (Fwindow_buffer): Move up and rewrite doc-string.
9156 (Fwindow_parent, Fwindow_vchild, Fwindow_hchild, Fwindow_next)
9157 (Fwindow_prev): New functions.
9158 (Fwindow_frame): Move here from frame.c. Accept any window as
9160 (Fframe_root_window, Fframe_first_window)
9161 (Fframe_selected_window): Move here from frame.c. Accept frame
9162 or arbitrary window as argument. Update doc-strings.
9163 (Fminibuffer_window): Move up in code.
9164 (Fwindow_minibuffer_p): Move up in code and simplify.
9165 (Fset_frame_selected_window): Move here from frame.c.
9167 (Fselected_window, select_window, Fselect_window): Move up in
9168 code. Minor doc-string fixes.
9170 2011-06-06 Paul Eggert <eggert@cs.ucla.edu>
9172 * alloc.c (memory_full) [SYSTEM_MALLOC]: Port to MacOS (Bug#8800).
9173 Do not assume that spare memory exists; that assumption is valid
9174 only if SYSTEM_MALLOC.
9175 (LARGE_REQUEST): New macro, so that the issue of large requests
9176 is separated from the issue of spare memory.
9178 2011-06-05 Andreas Schwab <schwab@linux-m68k.org>
9180 * editfns.c (Fformat): Correctly handle zero flag with hexadecimal
9183 * gtkutil.c (xg_get_default_scrollbar_width): Avoid warning.
9185 * xfns.c (x_set_scroll_bar_default_width): Move declarations
9188 2011-06-05 Jan Djärv <jan.h.d@swipnet.se>
9190 * gtkutil.c (xg_get_default_scrollbar_width): New function.
9192 * gtkutil.h: Declare xg_get_default_scrollbar_width.
9194 * xfns.c (x_set_scroll_bar_default_width): If USE_GTK, get
9195 min width by calling x_set_scroll_bar_default_width (Bug#8505).
9197 2011-06-05 Juanma Barranquero <lekktu@gmail.com>
9199 * xdisp.c (single_display_spec_intangible_p): Remove declaration.
9201 2011-06-04 Chong Yidong <cyd@stupidchicken.com>
9203 * xselect.c (x_clipboard_manager_save): Remove redundant arg.
9204 (x_clipboard_manager_save): Add return value.
9205 (x_clipboard_manager_error_1, x_clipboard_manager_error_2):
9207 (x_clipboard_manager_save_frame, x_clipboard_manager_save_all):
9208 Obey Vx_select_enable_clipboard_manager. Catch errors in
9209 x_clipboard_manager_save (Bug#8779).
9210 (Vx_select_enable_clipboard_manager): New variable.
9211 (x_get_foreign_selection): Reduce scope of x_catch_errors (Bug#8790).
9213 2011-06-04 Dan Nicolaescu <dann@ics.uci.edu>
9215 * emacs.c (main): Warn when starting a GTK emacs in daemon mode.
9217 2011-06-04 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
9219 * fringe.c (update_window_fringes): Don't update overlay arrow bitmap
9220 in the current matrix if keep_current_p is non-zero.
9222 2011-06-04 Eli Zaretskii <eliz@gnu.org>
9224 * bidi.c (bidi_level_of_next_char): Fix last change.
9226 2011-06-03 Eli Zaretskii <eliz@gnu.org>
9228 Support bidi reordering of text covered by display properties.
9230 * bidi.c (bidi_copy_it): Use offsetof instead of emulating it.
9231 (bidi_fetch_char, bidi_fetch_char_advance): New functions.
9232 (bidi_cache_search, bidi_cache_iterator_state)
9233 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak)
9234 (bidi_level_of_next_char, bidi_move_to_visually_next):
9235 Support character positions inside a run of characters covered by a
9237 (bidi_paragraph_init, bidi_resolve_explicit_1)
9238 (bidi_level_of_next_char): Call bidi_fetch_char and
9239 bidi_fetch_char_advance instead of FETCH_CHAR and
9241 (bidi_init_it): Initialize new members.
9242 (LRE_CHAR, RLE_CHAR, PDF_CHAR, LRO_CHAR, RLO_CHAR): Remove macro
9244 (bidi_explicit_dir_char): Lookup character type in bidi_type_table,
9245 instead of using explicit *_CHAR codes.
9246 (bidi_resolve_explicit, bidi_resolve_weak):
9247 Use FETCH_MULTIBYTE_CHAR instead of FETCH_CHAR, as reordering of
9248 bidirectional text is supported only in multibyte buffers.
9249 (bidi_init_it): Accept additional argument FRAME_WINDOW_P and use
9250 it to initialize the frame_window_p member of struct bidi_it.
9251 (bidi_cache_iterator_state, bidi_resolve_explicit_1)
9252 (bidi_resolve_explicit, bidi_resolve_weak)
9253 (bidi_level_of_next_char, bidi_move_to_visually_next): Abort if
9254 bidi_it->nchars is non-positive.
9255 (bidi_level_of_next_char): Don't try to lookup the cache for the
9256 next/previous character if nothing is cached there yet, or if we
9257 were just reseat()'ed to a new position.
9259 * xdisp.c (set_cursor_from_row): Set start and stop points
9260 according to the row's direction when priming the loop that looks
9261 for the glyph on which to display cursor.
9262 (single_display_spec_intangible_p): Function deleted.
9263 (display_prop_intangible_p): Reimplement to call
9264 handle_display_spec instead of single_display_spec_intangible_p.
9265 Accept 3 additional arguments needed by handle_display_spec.
9266 This fixes incorrect cursor motion across display property with complex
9267 values: lists, `(when COND...)' forms, etc.
9268 (single_display_spec_string_p): Support property values that are
9269 lists with the argument STRING its top-level element.
9270 (display_prop_string_p): Fix the condition for processing a
9271 property that is a list to be consistent with handle_display_spec.
9272 (handle_display_spec): New function, refactored from the
9273 last portion of handle_display_prop.
9274 (compute_display_string_pos): Accept additional argument
9275 FRAME_WINDOW_P. Call handle_display_spec to determine whether the
9276 value of a `display' property is a "replacing spec".
9277 (handle_single_display_spec): Accept 2 additional arguments BUFPOS
9278 and FRAME_WINDOW_P. If IT is NULL, don't set up the iterator from
9279 the display property, but just return a value indicating whether
9280 the display property will replace the characters it covers.
9281 (Fcurrent_bidi_paragraph_direction): Initialize the nchars and
9282 frame_window_p members of struct bidi_it.
9283 (compute_display_string_pos, compute_display_string_end):
9285 (push_it): Accept second argument POSITION, where pop_it should
9286 jump to continue iteration.
9287 (reseat_1): Initialize bidi_it.disp_pos.
9289 * keyboard.c (adjust_point_for_property): Adjust the call to
9290 display_prop_intangible_p to its new signature.
9292 * dispextern.h (struct bidi_it): New member frame_window_p.
9293 (bidi_init_it): Update prototypes.
9294 (display_prop_intangible_p): Update prototype.
9295 (compute_display_string_pos, compute_display_string_end):
9297 (struct bidi_it): New members nchars and disp_pos. ch_len is now
9300 2011-06-02 Paul Eggert <eggert@cs.ucla.edu>
9302 Malloc failure behavior now depends on size of allocation.
9303 * alloc.c (buffer_memory_full, memory_full): New arg NBYTES.
9304 * lisp.h: Change signatures accordingly.
9305 * alloc.c, buffer.c, editfns.c, menu.c, minibuf.c, xterm.c:
9306 All callers changed. (Bug#8762)
9308 * gnutls.c: Use Emacs's memory allocators.
9309 Without this change, the gnutls library would invoke malloc etc.
9310 directly, which causes problems on non-SYNC_INPUT hosts, and which
9311 runs afoul of improving memory_full behavior. (Bug#8761)
9312 (fn_gnutls_global_set_mem_functions): New macro or function pointer.
9313 (emacs_gnutls_global_init): Use it to specify xmalloc, xrealloc,
9314 xfree instead of the default malloc, realloc, free.
9315 (Fgnutls_boot): No need to check for memory allocation failure,
9316 since xmalloc does that for us.
9318 Remove arbitrary limit of 2**31 entries in hash tables. (Bug#8771)
9319 * category.c (hash_get_category_set):
9320 * ccl.c (ccl_driver):
9321 * charset.c (Fdefine_charset_internal):
9322 * charset.h (struct charset.hash_index):
9323 * composite.c (get_composition_id, gstring_lookup_cache)
9324 (composition_gstring_put_cache):
9325 * composite.h (struct composition.hash_index):
9326 * dispextern.h (struct image.hash):
9327 * fns.c (next_almost_prime, larger_vector, cmpfn_eql)
9328 (cmpfn_equal, cmpfn_user_defined, hashfn_eq, hashfn_eql)
9329 (hashfn_equal, hashfn_user_defined, make_hash_table)
9330 (maybe_resize_hash_table, hash_lookup, hash_put)
9331 (hash_remove_from_table, hash_clear, sweep_weak_table, SXHASH_COMBINE)
9332 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector)
9333 (Fsxhash, Fgethash, Fputhash, Fmaphash):
9334 * image.c (make_image, search_image_cache, lookup_image)
9335 (xpm_put_color_table_h):
9336 * lisp.h (struct Lisp_Hash_Table):
9337 * minibuf.c (Ftry_completion, Fall_completions, Ftest_completion):
9338 * print.c (print): Use 'EMACS_UINT' and 'EMACS_INT'
9339 for hashes and hash indexes, instead of 'unsigned' and 'int'.
9340 * alloc.c (allocate_vectorlike):
9341 Check for overflow in vector size calculations.
9342 * ccl.c (ccl_driver):
9343 Check for overflow when converting EMACS_INT to int.
9344 * fns.c, image.c: Remove unnecessary static decls that would otherwise
9345 need to be updated by these changes.
9346 * fns.c (make_hash_table, maybe_resize_hash_table):
9347 Check for integer overflow with large hash tables.
9348 (make_hash_table, maybe_resize_hash_table, Fmake_hash_table):
9349 Prefer the faster XFLOAT_DATA to XFLOATINT where either will do.
9350 (SXHASH_REDUCE): New macro.
9351 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector):
9352 Use it instead of discarding useful hash info with large hash values.
9353 (sxhash_float): New function.
9354 (sxhash): Use it. No more need for "& INTMASK" due to above changes.
9355 * lisp.h (FIXNUM_BITS): New macro, useful for SXHASH_REDUCE etc.
9356 (MOST_NEGATIVE_FIXNUM, MOST_POSITIVE_FIXNUM, INTMASK):
9357 Rewrite to use FIXNUM_BITS, as this simplifies things.
9358 (next_almost_prime, larger_vector, sxhash, hash_lookup, hash_put):
9359 Adjust signatures to match updated version of code.
9360 (consing_since_gc): Now EMACS_INT, since a single hash table can
9361 use more than INT_MAX bytes.
9363 2011-06-01 Dan Nicolaescu <dann@ics.uci.edu>
9365 Make it possible to build with GCC-4.6+ -O2 -flto.
9367 * emacs.c (__malloc_initialize_hook): Mark as EXTERNALLY_VISIBLE.
9369 2011-06-01 Stefan Monnier <monnier@iro.umontreal.ca>
9371 * minibuf.c (get_minibuffer, read_minibuf_unwind):
9372 Call minibuffer-inactive-mode.
9374 2011-05-31 Juanma Barranquero <lekktu@gmail.com>
9376 * makefile.w32-in ($(BLD)/data.$(O), $(BLD)/editfns.$(O)):
9377 Update dependencies.
9379 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
9381 * data.c (init_data): Remove code for UTS, this system is not
9384 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
9386 Don't force ./temacs to start in terminal mode.
9388 * frame.c (make_initial_frame): Initialize faces in all cases, not
9389 only when CANNOT_DUMP is defined.
9390 * dispnew.c (init_display): Remove CANNOT_DUMP condition.
9392 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
9394 * dispnew.c (add_window_display_history): Use const for the string
9395 pointer. Remove declaration, not needed.
9397 2011-05-31 Paul Eggert <eggert@cs.ucla.edu>
9399 Use 'inline', not 'INLINE'.
9400 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00914.html>
9401 * alloc.c, fontset.c (INLINE): Remove.
9402 * alloc.c, bidi.c, charset.c, coding.c, dispnew.c, fns.c, image.c:
9403 * intervals.c, keyboard.c, process.c, syntax.c, textprop.c, w32term.c:
9404 * xdisp.c, xfaces.c, xterm.c: Replace all uses of INLINE with inline.
9405 * gmalloc.c (register_heapinfo): Use inline unconditionally.
9406 * lisp.h (LISP_MAKE_RVALUE): Use inline, not __inline__.
9408 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
9410 Make it possible to run ./temacs.
9412 * callproc.c (set_initial_environment): Remove CANNOT_DUMP code,
9413 syms_of_callproc does the same thing. Remove test for
9414 "initialized", do it in the caller.
9415 * emacs.c (main): Avoid calling set_initial_environment when dumping.
9417 2011-05-31 Stefan Monnier <monnier@iro.umontreal.ca>
9419 * minibuf.c (Finternal_complete_buffer): Return `category' metadata.
9420 (read_minibuf): Use get_minibuffer.
9421 (syms_of_minibuf): Use DEFSYM.
9422 (Qmetadata): New var.
9423 * data.c (Qbuffer): Don't make it static.
9424 (syms_of_data): Use DEFSYM.
9426 2011-05-31 Paul Eggert <eggert@cs.ucla.edu>
9428 * ccl.c (CCL_CODE_RANGE): Allow negative numbers. (Bug#8751)
9429 (CCL_CODE_MIN): New macro.
9431 2011-05-30 Paul Eggert <eggert@cs.ucla.edu>
9433 * alloc.c (lisp_align_malloc): Omit unnecessary val==NULL tests.
9435 * eval.c (Qdebug): Now static.
9436 * lisp.h (Qdebug): Remove decl. This reverts a part of the
9437 2011-04-26T11:26:05Z!dan.colascione@gmail.com that inadvertently undid part of
9438 2011-04-14T06:48:41Z!eggert@cs.ucla.edu.
9440 2011-05-29 Chong Yidong <cyd@stupidchicken.com>
9442 * image.c: Various fixes to ImageMagick code comments.
9443 (Fimagemagick_types): Doc fix.
9445 2011-05-29 Paul Eggert <eggert@cs.ucla.edu>
9447 Minor fixes prompted by GCC 4.6.0 warnings.
9449 * xselect.c (converted_selections, conversion_fail_tag): Now static.
9451 * emacs.c [HAVE_X_WINDOWS]: Include "xterm.h".
9452 (x_clipboard_manager_save_all): Move extern decl to ...
9453 * xterm.h: ... here, so that it can be checked for consistency.
9455 2011-05-29 Chong Yidong <cyd@stupidchicken.com>
9457 * xselect.c (x_clipboard_manager_save_frame)
9458 (x_clipboard_manager_save_all): New functions.
9459 (Fx_clipboard_manager_save): Lisp function deleted.
9461 * emacs.c (Fkill_emacs): Call x_clipboard_manager_save_all.
9462 * frame.c (delete_frame): Call x_clipboard_manager_save_frame.
9464 * xterm.h: Update prototype.
9466 2011-05-28 William Xu <william.xwl@gmail.com>
9468 * nsterm.m (ns_term_shutdown): Synchronize user defaults before
9471 2011-05-28 Jim Meyering <meyering@redhat.com>
9473 Avoid a sign-extension bug in crypto_hash_function.
9474 * fns.c (to_uchar): Define.
9475 (crypto_hash_function): Use it to convert some newly-signed
9476 variables to unsigned, to avoid sign-extension bugs. For example,
9477 without this change, (md5 "truc") would evaluate to
9478 45723a2aff78ff4fff7fff1114760e62 rather than the expected
9479 45723a2af3788c4ff17f8d1114760e62. Reported by Antoine Levitt in
9480 https://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00883.html.
9482 2011-05-27 Paul Eggert <eggert@cs.ucla.edu>
9484 Integer overflow fixes.
9486 * dbusbind.c: Serial number integer overflow fixes.
9487 (CHECK_DBUS_SERIAL_GET_SERIAL): New macro.
9488 (Fdbus_call_method_asynchronously, xd_read_message_1): Use a float
9489 to hold a serial number that is too large for a fixnum.
9490 (Fdbus_method_return_internal, Fdbus_method_error_internal):
9491 Check for serial numbers out of range. Decode any serial number
9492 that was so large that it became a float. (Bug#8722)
9494 * dbusbind.c: Use XFASTINT rather than XUINT, and check for nonneg.
9495 (Fdbus_call_method, Fdbus_call_method_asynchronously):
9496 Use XFASTINT rather than XUINT when numbers are nonnegative.
9497 (xd_append_arg, Fdbus_method_return_internal):
9498 (Fdbus_method_error_internal): Likewise. Also, for unsigned
9499 arguments, check that Lisp number is nonnegative, rather than
9500 silently wrapping negative numbers around. (Bug#8722)
9501 (xd_read_message_1): Don't assume dbus_uint32_t can fit in int.
9504 * data.c (arith_driver, Flsh): Avoid unnecessary casts to EMACS_UINT.
9506 * ccl.c (ccl_driver): Redo slightly to avoid the need for 'unsigned'.
9508 ccl: Add integer overflow checks.
9509 * ccl.c (CCL_CODE_MAX, GET_CCL_RANGE, GET_CCL_CODE, GET_CCL_INT):
9510 (IN_INT_RANGE): New macros.
9511 (ccl_driver): Use them to check for integer overflow when
9512 decoding a CCL program. Many of the new checks are whether XINT (x)
9513 fits in int; it doesn't always, on 64-bit hosts. The new version
9514 doesn't catch all possible integer overflows, but it's an
9515 improvement. (Bug#8719)
9517 * alloc.c (make_event_array): Use XINT, not XUINT.
9518 There's no need for unsigned here.
9520 * mem-limits.h (EXCEEDS_LISP_PTR) [!USE_LSB_TAG]: EMACS_UINT -> uintptr_t
9521 This follows up to the 2011-05-06 change that substituted uintptr_t
9522 for EMACS_INT. This case wasn't caught back then.
9524 Rework Fformat to avoid integer overflow issues.
9525 * editfns.c: Include <float.h> unconditionally, as it's everywhere
9526 now (part of C89). Include <verify.h>.
9527 (MAX_10_EXP, CONVERTED_BYTE_SIZE): Remove; no longer needed.
9528 (pWIDE, pWIDElen, signed_wide, unsigned_wide): New defns.
9529 (Fformat): Avoid the prepass trying to compute sizes; it was only
9530 approximate and thus did not catch overflow reliably. Instead, walk
9531 through the format just once, formatting and computing sizes as we go,
9532 checking for integer overflow at every step, and allocating a larger
9533 buffer as needed. Keep track separately whether the format is
9534 multibyte. Keep only the most-recently calculated precision, rather
9535 than them all. Record whether each argument has been converted to
9536 string. Use EMACS_INT, not int, for byte and char and arg counts.
9537 Support field widths and precisions larger than INT_MAX. Avoid
9538 sprintf's undefined behavior with conversion specifications such as %#d
9539 and %.0c. Fix bug with strchr succeeding on '\0' when looking for
9540 flags. Fix bug with (format "%c" 256.0). Avoid integer overflow when
9541 formatting out-of-range floating point numbers with int
9544 * lisp.h (FIXNUM_OVERFLOW_P): Work even if arg is a NaN.
9546 * data.c: Avoid integer truncation in expressions involving floats.
9547 * data.c: Include <intprops.h>.
9548 (arith_driver): When there's an integer overflow in an expression
9549 involving floating point, convert the integers to floating point
9550 so that the resulting value does not suffer from catastrophic
9551 integer truncation. For example, on a 64-bit host (* 4
9552 most-negative-fixnum 0.5) should yield about -4.6e+18, not zero.
9553 Do not rely on undefined behavior after integer overflow.
9555 merge count_size_as_multibyte, parse_str_to_multibyte
9556 * character.c, character.h (count_size_as_multibyte):
9557 Rename from parse_str_to_multibyte; all uses changed.
9558 Check for integer overflow.
9559 * insdel.c, lisp.h (count_size_as_multibyte): Remove,
9560 since it's now a duplicate of the other. This is more of
9561 a character than a buffer op, so better that it's in character.c.
9562 * fns.c, print.c: Adjust to above changes.
9564 2011-05-27 Stefan Monnier <monnier@iro.umontreal.ca>
9566 * xselect.c (x_convert_selection): Yet another int/Lisp_Object mixup.
9568 2011-05-27 Paul Eggert <eggert@cs.ucla.edu>
9570 * xselect.c: Fix minor problems prompted by GCC 4.6.0 warnings.
9571 (x_handle_selection_request, frame_for_x_selection): Remove unused vars.
9572 (x_clipboard_manager_save): Now static.
9573 (Fx_clipboard_manager_save): Rename local to avoid shadowing.
9575 * fns.c: Fix minor problems prompted by GCC 4.6.0 warnings.
9576 (crypto_hash_function): Now static.
9577 Fix pointer signedness problems. Avoid unnecessary initializations.
9579 2011-05-27 Chong Yidong <cyd@stupidchicken.com>
9581 * termhooks.h (Vselection_alist): Make it terminal-local.
9583 * terminal.c (create_terminal): Initialize it.
9585 * xselect.c: Support for clipboard managers.
9586 (Vselection_alist): Move to termhooks.h as terminal-local var.
9587 (LOCAL_SELECTION): New macro.
9588 (x_atom_to_symbol): Handle x_display_info_for_display fail case.
9589 (symbol_to_x_atom): Remove gratuitous arg.
9590 (x_handle_selection_request, lisp_data_to_selection_data)
9591 (x_get_foreign_selection, Fx_register_dnd_atom): Callers changed.
9592 (x_own_selection, x_get_local_selection, x_convert_selection):
9593 New arg, specifying work frame. Use terminal-local Vselection_alist.
9594 (some_frame_on_display): Delete unused function.
9595 (Fx_own_selection_internal, Fx_get_selection_internal)
9596 (Fx_disown_selection_internal, Fx_selection_owner_p)
9597 (Fx_selection_exists_p): New optional frame arg.
9598 (frame_for_x_selection, Fx_clipboard_manager_save): New functions.
9599 (x_handle_selection_clear): Don't treat other terminals with the
9600 same keyboard specially. Use the terminal-local Vselection_alist.
9601 (x_clear_frame_selections): Use Frun_hook_with_args.
9603 * xterm.c (x_term_init): Intern ATOM and CLIPBOARD_MANAGER atoms.
9605 * xterm.h: Add support for those atoms.
9607 2011-05-26 Chong Yidong <cyd@stupidchicken.com>
9609 * xselect.c: ICCCM-compliant handling of MULTIPLE targets.
9610 (converted_selections, conversion_fail_tag): New global variables.
9611 (x_selection_request_lisp_error): Free the above.
9612 (x_get_local_selection): Remove unnecessary code.
9613 (x_reply_selection_request): Args changed; handle arbitrary array
9614 of converted selections stored in converted_selections.
9615 Separate the XChangeProperty and SelectionNotify steps.
9616 (x_handle_selection_request): Rewrite to handle MULTIPLE target.
9617 (x_convert_selection): New function.
9618 (x_handle_selection_event): Simplify.
9619 (x_get_foreign_selection): Don't ignore incoming requests while
9620 waiting for an answer; this will fail when we implement
9621 SAVE_TARGETS, and seems unnecessary anyway.
9622 (selection_data_to_lisp_data): Recognize ATOM_PAIR type.
9623 (Vx_sent_selection_functions): Doc fix.
9625 2011-05-26 Leo Liu <sdl.web@gmail.com>
9627 * editfns.c (Ftranspose_regions): Allow empty regions. (Bug#8699)
9629 2011-05-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
9631 * dispextern.h (struct glyph_row): New member fringe_bitmap_periodic_p.
9633 * dispnew.c (shift_glyph_matrix, scrolling_window): Mark scrolled row
9634 for fringe update if it has periodic bitmap.
9635 (row_equal_p): Also compare left_fringe_offset, right_fringe_offset,
9636 and fringe_bitmap_periodic_p.
9638 * fringe.c (get_fringe_bitmap_data): New function.
9639 (draw_fringe_bitmap_1, update_window_fringes): Use it.
9640 (update_window_fringes): Record periodicity of fringe bitmap in glyph
9641 row. Mark glyph row for fringe update if periodicity changed.
9643 * xdisp.c (try_window_reusing_current_matrix): Don't mark scrolled row
9644 for fringe update unless it has periodic bitmap.
9646 2011-05-25 Kenichi Handa <handa@m17n.org>
9648 * xdisp.c (get_next_display_element): Set correct it->face_id for
9649 a static composition.
9651 2011-05-24 Leo Liu <sdl.web@gmail.com>
9654 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha1.h.
9656 * fns.c (crypto_hash_function, Fsha1): New function.
9657 (Fmd5): Use crypto_hash_function.
9658 (syms_of_fns): Add Ssha1.
9660 2011-05-22 Paul Eggert <eggert@cs.ucla.edu>
9662 * gnutls.c: Remove unused macros.
9663 (fn_gnutls_transport_set_lowat, fn_gnutls_transport_set_pull_function):
9664 (fn_gnutls_transport_set_push_function) [!WINDOWSNT]:
9665 Remove macros that are defined and never used.
9666 Caught by gcc -Wunused-macros (GCC 4.6.0, Fedora 14).
9668 2011-05-22 Chong Yidong <cyd@stupidchicken.com>
9670 * xselect.c (syms_of_xselect): Remove unused symbol SAVE_TARGETS.
9671 (Fx_get_selection_internal): Minor cleanup.
9672 (Fx_own_selection_internal): Rename arguments for consistency with
9675 2011-05-22 Paul Eggert <eggert@cs.ucla.edu>
9677 * xselect.c (QSAVE_TARGETS): New static var, to fix build failure.
9679 2011-05-22 Chong Yidong <cyd@stupidchicken.com>
9681 * xselect.c (syms_of_xselect): Include character.h; use DEFSYM.
9683 2011-05-21 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
9685 * dispnew.c (scrolling_window): Don't exclude the case that the
9686 last enabled row in the desired matrix touches the bottom boundary.
9688 2011-05-21 Glenn Morris <rgm@gnu.org>
9690 * Makefile.in ($(etc)/DOC): Make second command line even shorter.
9691 (SOME_MACHINE_OBJECTS): Replace FONT_OBJ by its maximal expansion,
9692 and add some more files.
9694 2011-05-20 Eli Zaretskii <eliz@gnu.org>
9696 * callproc.c (Fcall_process) [MSDOS]: Fix arguments to
9697 report_file_error introduced by the change from 2011-05-07.
9699 2011-05-20 Paul Eggert <eggert@cs.ucla.edu>
9701 * systime.h (Time): Define only if emacs is defined.
9702 This is to allow ../lib-src/profile.c to be compiled on FreeBSD,
9703 where the include path doesn't have X11/X.h by default. See
9704 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00561.html>.
9706 2011-05-20 Kenichi Handa <handa@m17n.org>
9708 * composite.c (find_automatic_composition): Fix previous change.
9710 2011-05-20 Glenn Morris <rgm@gnu.org>
9712 * lisp.mk: New file, split from Makefile.in.
9713 * Makefile.in (lisp): Move to separate file, inserted by @lisp_frag@.
9714 (shortlisp): Remove.
9715 ($(etc)/DOC): Edit lisp.mk rather than using $shortlisp.
9717 2011-05-19 Glenn Morris <rgm@gnu.org>
9719 * Makefile.in (MSDOS_SUPPORT_REAL, MSDOS_SUPPORT, NS_SUPPORT)
9720 (REAL_MOUSE_SUPPORT, GPM_MOUSE_SUPPORT, MOUSE_SUPPORT, TOOLTIP_SUPPORT)
9721 (BASE_WINDOW_SUPPORT, X_WINDOW_SUPPORT, WINDOW_SUPPORT): Remove.
9722 (lisp): Set the order to that of loadup.el.
9723 (shortlisp): Make it a copy of $lisp.
9724 (SOME_MACHINE_LISP): Remove.
9725 ($(etc)/DOC): Depend just on $lisp, not $SOME_MACHINE_LISP too.
9726 Use just $shortlisp, not $SOME_MACHINE_LISP too.
9728 2011-05-18 Kenichi Handa <handa@m17n.org>
9730 * composite.c (CHAR_COMPOSABLE_P): Add more check for efficiency.
9731 (BACKWARD_CHAR): Wrap the arg STOP by parenthesis.
9732 (find_automatic_composition): Mostly rewrite for efficiency.
9734 2011-05-18 Juanma Barranquero <lekktu@gmail.com>
9736 * makefile.w32-in: Update dependencies.
9738 2011-05-18 Christoph Scholtes <cschol2112@googlemail.com>
9740 * menu.c: Include limits.h (fixes the MS-Windows build broken by
9741 2011-06-18T18:49:19Z!cyd@stupidchicken.com).
9743 2011-05-18 Paul Eggert <eggert@cs.ucla.edu>
9745 Fix some integer overflow issues, such as string length overflow.
9747 * insdel.c (count_size_as_multibyte): Check for string overflow.
9749 * character.c (lisp_string_width): Check for string overflow.
9750 Use EMACS_INT, not int, for string indexes and lengths; in
9751 particular, 2nd arg is now EMACS_INT, not int. Do not crash if
9752 the resulting string length overflows an EMACS_INT; instead,
9753 report a string overflow if no precision given. When checking for
9754 precision exhaustion, use a check that cannot possibly have
9755 integer overflow. (Bug#8675)
9756 * character.h (lisp_string_width): Adjust to new signature.
9758 * alloc.c (string_overflow): New function.
9759 (Fmake_string): Use it. This doesn't change behavior, but saves
9760 a few bytes and will simplify future changes.
9761 * character.c (string_escape_byte8): Likewise.
9762 * lisp.h (string_overflow): New decl.
9764 Fixups, following up to the user-interface timestamp change.
9765 * nsterm.m (last_mouse_movement_time, ns_mouse_position): Use Time
9766 for UI timestamps, instead of unsigned long.
9767 * msdos.c (mouse_get_pos): Likewise.
9768 * w32inevt.c (movement_time, w32_console_mouse_position): Likewise.
9769 * w32gui.h (Time): Define by including "systime.h" rather than by
9770 declaring it ourselves. (Bug#8664)
9772 * dispextern.h (struct image): Don't assume time_t <= unsigned long.
9773 * image.c (clear_image_cache): Likewise.
9775 * term.c (term_mouse_position): Don't assume time_t wraparound.
9777 Be more systematic about user-interface timestamps.
9778 Before, the code sometimes used 'Time', sometimes 'unsigned long',
9779 and sometimes 'EMACS_UINT', to represent these timestamps.
9780 This change causes it to use 'Time' uniformly, as that's what X uses.
9781 This makes the code easier to follow, and makes it easier to catch
9782 integer overflow bugs such as Bug#8664.
9783 * frame.c (Fmouse_position, Fmouse_pixel_position):
9784 Use Time, not unsigned long, for user-interface timestamps.
9785 * keyboard.c (last_event_timestamp, kbd_buffer_get_event): Likewise.
9786 (button_down_time, make_lispy_position, make_lispy_movement): Likewise.
9787 * keyboard.h (last_event_timestamp): Likewise.
9788 * menu.c (Fx_popup_menu) [!HAVE_X_WINDOWS]: Likewise.
9789 * menu.h (xmenu_show): Likewise.
9790 * term.c (term_mouse_position): Likewise.
9791 * termhooks.h (struct input_event.timestamp): Likewise.
9792 (struct terminal.mouse_position_hook): Likewise.
9793 * xmenu.c (create_and_show_popup_menu, xmenu_show): Likewise.
9794 * xterm.c (XTmouse_position, x_scroll_bar_report_motion): Likewise.
9795 * systime.h (Time): New decl. Pull it in from <X11/X.h> if
9796 HAVE_X_WINDOWS, otherwise define it as unsigned long, which is
9798 * menu.h, termhooks.h: Include "systime.h", for Time.
9800 * keyboard.c (make_lispy_event): Fix problem in integer overflow.
9801 Don't assume that the difference between two unsigned long values
9802 can fit into an integer. At this point, we know button_down_time
9803 <= event->timestamp, so the difference must be nonnegative, so
9804 there's no need to cast the result if double-click-time is
9805 nonnegative, as it should be; check that it's nonnegative, just in
9806 case. This bug is triggered when events are more than 2**31 ms
9807 apart (about 25 days). (Bug#8664)
9809 * xselect.c (last_event_timestamp): Remove duplicate decl.
9810 (x_own_selection): Remove needless cast to unsigned long.
9812 * xmenu.c (set_frame_menubar): Use int, not EMACS_UINT, for indexes
9813 that always fit in int. Use a sentinel instead of a counter, to
9814 avoid a temp and to allay GCC's concerns about possible int overflow.
9815 * frame.h (struct frame): Use int for menu_bar_items_used
9816 instead of EMACS_INT, since it always fits in int.
9818 * menu.c (grow_menu_items): Check for int overflow.
9820 * xmenu.c (set_frame_menubar): Don't mishandle vectors with no nils.
9822 * xterm.c: Use EMACS_INT for Emacs modifiers, and int for X modifiers.
9823 Before, the code was not consistent. These values cannot exceed
9824 2**31 - 1 so there's no need to make them unsigned.
9825 (x_x_to_emacs_modifiers): Accept int and return EMACS_INT.
9826 (x_emacs_to_x_modifiers): Accept EMACS_INT and return int.
9827 (x_x_to_emacs_modifiers, x_emacs_to_x_modifiers): Reject non-integers
9829 * xterm.h (x_x_to_emacs_modifiers): Adjust to signature change.
9831 * lisp.h (XINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_INT.
9832 (XUINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_UINT.
9833 Otherwise, GCC 4.6.0 warns about printf (pI, XINT (...)),
9834 presumably because the widths might not match.
9836 * window.c (size_window): Avoid needless test at loop start.
9838 2011-05-18 Courtney Bane <emacs-bugs-7626@cbane.org> (tiny change)
9840 * term.c (Fresume_tty): Restore hooks before reinitializing (bug#8687).
9842 2011-05-12 Drew Adams <drew.adams@oracle.com>
9844 * textprop.c (Fprevious_single_char_property_change): Doc fix (bug#8655).
9846 2011-05-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
9848 * w32term.c (w32_draw_fringe_bitmap): Rename local vars `left' and
9849 `width' to `bar_area_x' and `bar_area_width', respectively.
9850 (x_scroll_run): Take account of fringe background extension.
9852 * xterm.c (x_draw_fringe_bitmap) [USE_TOOLKIT_SCROLL_BARS]:
9853 Rename local vars `left' and `width' to `bar_area_x' and
9854 `bar_area_width', respectively.
9855 (x_scroll_run) [USE_TOOLKIT_SCROLL_BARS]: Take account of fringe
9856 background extension.
9858 2011-05-10 Jim Meyering <meyering@redhat.com>
9860 * xdisp.c (x_intersect_rectangles): Fix typo "the the -> the".
9862 2011-05-10 Juanma Barranquero <lekktu@gmail.com>
9864 * image.c (Finit_image_library): Return t for built-in image types,
9865 like pbm and xbm. (Bug#8640)
9867 2011-05-09 Andreas Schwab <schwab@linux-m68k.org>
9869 * w32menu.c (set_frame_menubar): Fix submenu allocation.
9871 2011-05-07 Eli Zaretskii <eliz@gnu.org>
9873 * w32console.c (Fset_screen_color): Doc fix.
9874 (Fget_screen_color): New function.
9875 (syms_of_ntterm): Defsubr it.
9877 * callproc.c (call_process_cleanup) [MSDOS]: Don't close and
9878 unlink the temporary file if Fcall_process didn't create it in the
9880 (Fcall_process) [MSDOS]: Don't create tempfile if stdout of the
9881 child process will be redirected to a file specified with `:file'.
9882 Don't try to re-open tempfile in that case, and set fd[0] to -1 as
9883 cue to call_process_cleanup not to close that handle.
9885 2011-05-07 Ben Key <bkey76@gmail.com>
9887 * makefile.w32-in: The bootstrap-temacs rule now makes use of
9888 one of two shell specific rules, either bootstrap-temacs-CMD or
9889 bootstrap-temacs-SH. The bootstrap-temacs-SH rule is identical
9890 to the previous implementation of the bootstrap-temacs rule.
9891 The bootstrap-temacs-CMD rule is similar to the previous
9892 implementation of the bootstrap-temacs rule except that it
9893 makes use of the ESC_CFLAGS variable instead of the CFLAGS
9896 These changes, along with some changes to nt/configure.bat,
9897 nt/gmake.defs, and nt/nmake.defs, are required to extend my
9898 earlier fix to add support for --cflags and --ldflags options
9899 that include quotes so that it works whether make uses cmd or
9902 2011-05-06 Michael Albinus <michael.albinus@gmx.de>
9904 * dbusbind.c (QCdbus_type_unix_fd): Declare static.
9905 (xd_remove_watch): Don't check QCdbus_type_unix_fd for SYMBOLP, it
9907 (Fdbus_init_bus, xd_read_queued_messages): Bus can be a symbol or
9908 a string. Handle both cases.
9909 (Fdbus_call_method_asynchronously, Fdbus_register_signal)
9910 (Fdbus_register_method): Use Qinvalid_function.
9912 2011-05-06 Juanma Barranquero <lekktu@gmail.com>
9914 * makefile.w32-in: Update dependencies.
9915 (LISP_H): Add inttypes.h and stdin.h.
9916 (PROCESS_H): Add unistd.h.
9918 2011-05-06 Eli Zaretskii <eliz@gnu.org>
9920 * lread.c: Include limits.h (fixes the MS-Windows build broken by
9921 2011-05-06T07:13:19Z!eggert@cs.ucla.edu).
9923 2011-05-06 Paul Eggert <eggert@cs.ucla.edu>
9925 * image.c (Finit_image_library) [!HAVE_NTGUI]: Omit unused local.
9927 * term.c (vfatal): Remove stray call to va_end.
9928 It's not needed and the C Standard doesn't allow it here anyway.
9930 Use C99's va_copy to avoid undefined behavior on x86-64 GNU/Linux.
9931 * eval.c (verror): doprnt a copy of ap, not the original. (Bug#8545)
9933 * eval.c (verror): OK to create a string of up to MOST_POSITIVE_FIXNUM
9936 * term.c: Don't include <stdarg.h>, as <lisp.h> does that.
9938 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
9940 * process.c (Fformat_network_address): Fix typo: args2 -> *args2.
9942 * xmenu.c (set_frame_menubar): Fix typo: int * -> int (3 times).
9944 * coding.c (detect_coding_charset): Fix typo: * 2 -> *4 (Bug#8601).
9946 * charset.h (struct charset.code_space): Now has 15 elements, not 16.
9947 * charset.c (Fdefine_charset_internal): Don't initialize
9948 charset.code_space[15]. The value was garbage, on hosts with
9949 32-bit int (Bug#8600).
9951 * lread.c (read_integer): Be more consistent with string-to-number.
9952 Use string_to_number to do the actual conversion; this avoids
9953 rounding errors and fixes some other screwups. Without this fix,
9954 for example, #x1fffffffffffffff was misread as -2305843009213693952.
9955 (digit_to_number): Move earlier, for benefit of read_integer.
9956 Return -1 if the digit is out of range for the base, -2 if it is
9957 not a digit in any supported base. (Bug#8602)
9959 * doprnt.c (doprnt): Support arbitrary pI values, such as "I64".
9961 * dispnew.c (scrolling_window): Return 1 if we scrolled,
9962 to match comment at start of function. This also removes a
9963 GCC warning about overflow in a 32+64-bit port.
9965 * lisp.h (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Simplify.
9967 * dbusbind.c: Do not use XPNTR on a value that may be an integer.
9968 Reported by Stefan Monnier in
9969 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00919.html>.
9970 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
9971 Use SYMBOLP-guarded XSYMBOL, not XPNTR.
9973 * lisp.h (EMACS_INTPTR): Remove. All uses changed to intptr_t.
9974 (EMACS_UINTPTR): Likewise, with uintptr_t.
9976 * lisp.h: Prefer 64-bit EMACS_INT if available.
9977 (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Define to 64-bit
9978 on 32-bit hosts that have 64-bit int, so that they can access
9980 However, temporarily disable this change unless the temporary
9981 symbol WIDE_EMACS_INT is defined.
9983 * lread.c, process.c: Do not include <inttypes.h>; lisp.h does it now.
9985 Prefer intptr_t/uintptr_t for integers the same widths as pointers.
9986 This removes an assumption that EMACS_INT and long are the same
9987 width as pointers. The assumption is true for Emacs porting targets
9988 now, but we want to make other targets possible.
9989 * lisp.h: Include <inttypes.h>, for INTPTR_MAX, UINTPTR_MAX.
9990 (EMACS_INTPTR, EMACS_UINTPTR): New macros.
9991 In the rest of the code, change types of integers that hold casted
9992 pointers to EMACS_INTPTR and EMACS_UINTPTR, systematically
9993 replacing EMACS_INT, long, EMACS_UINT, and unsigned long.
9994 (XTYPE): Don't cast arg to EMACS_UINT; normally is not needed.
9995 (XSET): Cast type of XTYPE arg to EMACS_INTPTR; it is needed here.
9996 No need to cast type when ORing.
9997 (XPNTR): Return a value of type EMACS_INTPTR or EMACS_UINTPTR.
9998 * alloc.c (lisp_align_malloc): Remove a no-longer-needed cast.
9999 * doc.c (store_function_docstring): Use EMACS_INTPTR, so as not to
10000 assume EMACS_INT is the same width as char *.
10001 * gtkutil.c (xg_gtk_scroll_destroy, xg_tool_bar_button_cb):
10002 (xg_tool_bar_callback, xg_tool_bar_help_callback, xg_make_tool_item):
10003 Remove no-longer-needed casts.
10004 (xg_create_scroll_bar, xg_tool_bar_button_cb, xg_tool_bar_callback):
10005 (xg_tool_bar_help_callback, xg_make_tool_item):
10006 Use EMACS_INTPTR to hold an integer
10007 that will be cast to void *; this can avoid a GCC warning
10008 if EMACS_INT is not the same width as void *.
10009 * menu.c (find_and_call_menu_selection): Remove no-longer-needed cast.
10010 * xdisp.c (display_echo_area_1, resize_mini_window_1):
10011 (current_message_1, set_message_1):
10012 Use a local to convert to proper width without a cast.
10013 * xmenu.c (dialog_selection_callback): Likewise.
10015 * sysdep.c (get_random): Don't assume EMACS_INT is no wider than long.
10016 Also, don't assume VALBITS / RAND_BITS is less than 5,
10017 and don't rely on undefined behavior when shifting a 1 left into
10019 * lisp.h (get_random): Change signature to match.
10021 * lread.c (hash_string): Use size_t, not int, for hash computation.
10022 Normally we prefer signed values; but hashing is special, because
10023 it's better to use unsigned division on hash table sizes so that
10024 the remainder is nonnegative. Also, size_t is the natural width
10025 for hashing into memory. The previous code used 'int', which doesn't
10026 retain enough info to hash well into very large tables.
10027 (oblookup, oblookup_last_bucket_number, Funintern): Likewise.
10029 * dbusbind.c: Don't possibly lose pointer info when converting.
10030 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
10031 Use XPNTR rather than XHASH, so that the high-order bits of
10032 the pointer aren't lost when converting through void *.
10034 * eval.c (Fautoload): Don't double-shift a pointer.
10036 * fns.c (Frandom): Let EMACS_UINT be wider than unsigned long.
10038 2011-05-06 Juanma Barranquero <lekktu@gmail.com>
10040 * gnutls.c (DEF_GNUTLS_FN):
10041 * image.c (DEF_IMGLIB_FN): Make function pointers static.
10043 2011-05-05 Andreas Schwab <schwab@linux-m68k.org>
10045 * lread.c (lisp_file_lexically_bound_p): Stop scanning at end
10048 2011-05-05 Eli Zaretskii <eliz@gnu.org>
10050 * w32heap.c (allocate_heap) [USE_LISP_UNION_TYPE || USE_LSB_TAG]:
10051 New version that can reserve upto 2GB of heap space.
10053 2011-05-05 Chong Yidong <cyd@stupidchicken.com>
10055 * nsfns.m (Fns_read_file_name): Doc fix (Bug#8534).
10057 2011-05-05 Teodor Zlatanov <tzz@lifelogs.com>
10059 * gnutls.c (fn_gnutls_certificate_set_x509_key_file): Add alias to
10060 `gnutls_certificate_set_x509_key_file'.
10062 2011-05-05 Juanma Barranquero <lekktu@gmail.com>
10064 * makefile.w32-in ($(BLD)/image.$(O), $(BLD)/process.$(O)):
10065 Update dependencies.
10067 2011-05-04 Juanma Barranquero <lekktu@gmail.com>
10069 * gnutls.h (emacs_gnutls_write, emacs_gnutls_read):
10070 * gnutls.c (emacs_gnutls_write, emacs_gnutls_read):
10071 Remove unused parameter `fildes'.
10072 * process.c (read_process_output, send_process): Don't pass it.
10074 2011-05-04 Juanma Barranquero <lekktu@gmail.com>
10076 Fix previous change: the library cache is defined in w32.c.
10077 * image.c (CACHE_IMAGE_TYPE) [!HAVE_NTGUI]: Define to noop.
10078 (Finit_image_library): Wrap Vlibrary_cache on "#ifdef HAVE_NTGUI".
10080 2011-05-04 Juanma Barranquero <lekktu@gmail.com>
10082 Implement dynamic loading of GnuTLS on Windows.
10084 * gnutls.h (GNUTLS_EMACS_ERROR_NOT_LOADED): New macro.
10085 (emacs_gnutls_write, emacs_gnutls_read): Mark as extern.
10086 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
10089 * gnutls.c (Qgnutls_dll): Define.
10090 (DEF_GNUTLS_FN, LOAD_GNUTLS_FN): New macros.
10091 (gnutls_*): Declare function pointers.
10092 (init_gnutls_functions): New function to initialize function pointers.
10093 (emacs_gnutls_handshake, Fgnutls_error_string, Fgnutls_deinit)
10094 (emacs_gnutls_global_init, Fgnutls_bye): Use function pointers.
10095 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
10096 Wrappers for gnutls_record_check_pending and gnutls_transport_set_errno.
10097 (emacs_gnutls_write, emacs_gnutls_read)
10098 (emacs_gnutls_handle_error, Fgnutls_error_fatalp)
10099 (Fgnutls_available_p): New function.
10100 (Fgnutls_boot): Call Fgnutls_available_p. Use function pointers.
10101 (syms_of_gnutls) <Qgnutls_dll>: Initialize and staticpro it.
10102 (syms_of_gnutls) <Sgnutls_available_p>: defsubr it.
10104 * image.c: Include w32.h.
10105 (Vimage_type_cache): Delete.
10106 (syms_of_image) <Vimage_type_cache>: Don't initialize and staticpro it.
10107 (CACHE_IMAGE_TYPE, Finit_image_library): Use Vlibrary_cache instead.
10108 (w32_delayed_load): Move to w32.c.
10110 * w32.h (VlibraryCache, QCloaded_from, w32_delayed_load): Declare.
10112 * w32.c (QCloaded_from, Vlibrary_cache): Define.
10113 (w32_delayed_load): Move from image.c. When loading a library, record
10114 its filename in the :loaded-from property of the library id.
10115 (globals_of_w32) <QCloaded_from, Vlibrary_cache>:
10116 Initialize and staticpro them.
10117 (emacs_gnutls_pull, emacs_gnutls_push): Call emacs_gnutls_* functions.
10119 * process.c: Include lisp.h before w32.h, not after.
10120 (wait_reading_process_output): Call emacs_gnutls_record_check_pending
10121 instead of gnutls_record_check_pending.
10123 * callproc.c, emacs.c: Include lisp.h before w32.h, not after.
10125 2011-05-04 Teodor Zlatanov <tzz@lifelogs.com>
10127 * gnutls.c (Fgnutls_boot): Support :keylist and :crlfiles options
10128 instead of :keyfiles. Give GnuTLS the keylist and the CRL lists
10131 2011-05-03 Jan Djärv <jan.h.d@swipnet.se>
10133 * xterm.c (x_set_frame_alpha): Do not set property on anything
10134 else than FRAME_X_OUTER_WINDOW (Bug#8608).
10136 2011-05-02 Juanma Barranquero <lekktu@gmail.com>
10138 * sysdep.c (get_tty_size) [WINDOWSNT]: Implement. (Bug#8596)
10140 2011-05-02 Juanma Barranquero <lekktu@gmail.com>
10142 * gnutls.c (Qgnutls_log_level, Qgnutls_code, Qgnutls_anon)
10143 (Qgnutls_x509pki, Qgnutls_e_interrupted, Qgnutls_e_again)
10144 (Qgnutls_e_invalid_session, Qgnutls_e_not_ready_for_handshake)
10145 (gnutls_global_initialized, Qgnutls_bootprop_priority)
10146 (Qgnutls_bootprop_trustfiles, Qgnutls_bootprop_keyfiles)
10147 (Qgnutls_bootprop_callbacks, Qgnutls_bootprop_loglevel)
10148 (Qgnutls_bootprop_hostname, Qgnutls_bootprop_verify_flags)
10149 (Qgnutls_bootprop_verify_error, Qgnutls_bootprop_verify_hostname_error)
10150 (Qgnutls_bootprop_callbacks_verify): Make static.
10152 2011-05-01 Andreas Schwab <schwab@linux-m68k.org>
10154 * callproc.c: Indentation fixup.
10156 * sysdep.c (wait_for_termination_1): Make static.
10157 (wait_for_termination, interruptible_wait_for_termination):
10158 Move after wait_for_termination_1.
10160 2011-05-01 Lars Magne Ingebrigtsen <larsi@gnus.org>
10162 * sysdep.c (interruptible_wait_for_termination): New function
10163 which is like wait_for_termination, but allows keyboard
10166 * callproc.c (Fcall_process): Add (:file "file") as an option for
10168 (Fcall_process_region): Ditto.
10170 2011-04-30 Eli Zaretskii <eliz@gnu.org>
10172 * dosfns.c (Fint86, Fdos_memget, Fdos_memput): Use `ASIZE (FOO)'
10173 rather than `XVECTOR (FOO)->size'.
10175 * process.c: Remove HAVE_INTTYPES_H condition from inclusion of
10176 inttypes.h, as a gnulib replacement is used if it not available in
10179 2011-04-21 Eli Zaretskii <eliz@gnu.org>
10181 Lift the MOST_POSITIVE_FIXNUM/4 limitation on visited files.
10182 * fileio.c (Finsert_file_contents): Don't limit file size to 1/4
10183 of MOST_POSITIVE_FIXNUM. (Bug#8528)
10185 * coding.c (coding_alloc_by_realloc): Error out if destination
10186 will grow beyond MOST_POSITIVE_FIXNUM.
10187 (decode_coding_emacs_mule): Abort if there isn't enough place in
10188 charbuf for the composition carryover bytes. Reserve an extra
10189 space for up to 2 characters produced in a loop.
10190 (decode_coding_iso_2022): Abort if there isn't enough place in
10191 charbuf for the composition carryover bytes.
10193 2011-04-21 Eli Zaretskii <eliz@gnu.org>
10195 * doprnt.c (doprnt) [!HAVE_LONG_LONG_INT]: Error out instead of
10196 aborting when %lld or %lll format is passed.
10197 [!HAVE_UNSIGNED_LONG_LONG_INT]: Error out instead of aborting when
10198 %llo or %llx format is passed. (Bug#8545)
10200 * window.c (window_scroll_line_based): Use a marker instead of
10201 simple variables to record original value of point. (Bug#7952)
10203 * doprnt.c (doprnt): Fix the case where a multibyte sequence
10204 produced by %s or %c overflows available buffer space. (Bug#8545)
10206 2011-04-28 Paul Eggert <eggert@cs.ucla.edu>
10208 * doprnt.c (doprnt): Omit useless test; int overflow check (Bug#8545).
10209 (SIZE_MAX): Move defn after all includes, as they might #define it.
10211 2011-04-28 Juanma Barranquero <lekktu@gmail.com>
10213 * w32.c (init_environment): Warn about defaulting HOME to C:\.
10215 2011-04-28 Juanma Barranquero <lekktu@gmail.com>
10217 * keyboard.c (Qdelayed_warnings_hook): Define.
10218 (command_loop_1): Run `delayed-warnings-hook'
10219 if Vdelayed_warnings_list is non-nil.
10220 (syms_of_keyboard) <delayed-warnings-hook>: DEFSYM it.
10221 (syms_of_keyboard) <delayed-warnings-list>: DEFVAR_LISP it.
10223 2011-04-28 Eli Zaretskii <eliz@gnu.org>
10225 * doprnt.c (doprnt): Don't return value smaller than the buffer
10226 size if the message was truncated. (Bug#8545).
10228 2011-04-28 Juanma Barranquero <lekktu@gmail.com>
10230 * w32fns.c (Fx_change_window_property, Fx_delete_window_property)
10231 (Fx_window_property): #if-0 the whole functions, not just the bodies.
10233 2011-04-27 Paul Eggert <eggert@cs.ucla.edu>
10235 * doprnt.c (doprnt): Support "ll" length modifier, for long long.
10237 2011-04-27 Juanma Barranquero <lekktu@gmail.com>
10239 * makefile.w32-in: Update dependencies.
10241 2011-04-27 Eli Zaretskii <eliz@gnu.org>
10243 Improve `doprnt' and its usage. (Bug#8545)
10244 * doprnt.c (doprnt): Make sure `format' is never accessed beyond
10245 `format_end'. Remove support for %l as a conversion specifier.
10246 Don't use xrealloc. Improve diagnostics when the %l size modifier
10247 is used. Update the commentary.
10249 * eval.c (verror): Simplify calculation of size_t.
10251 * coding.c (Ffind_operation_coding_system): Fix diagnostic error
10254 2011-04-27 Yoshiaki Kasahara <kasahara@nc.kyushu-u.ac.jp> (tiny change)
10256 * buffer.c (init_buffer) [USE_MMAP_FOR_BUFFERS]: Adjust to aliasing
10259 2011-04-27 Paul Eggert <eggert@cs.ucla.edu>
10261 * nsmenu.m: Replace all uses of XVECTOR with ASIZE and AREF.
10262 This makes this file independent of the recent pseudovector change.
10264 2011-04-26 Paul Eggert <eggert@cs.ucla.edu>
10266 * keyboard.c (handle_user_signal): Fix pointer signedness problem.
10268 * gnutls.c (emacs_gnutls_handle_error): Remove unused local.
10269 (Fgnutls_boot): gnutls_certificate_verify_peers2 wants unsigned *.
10270 Remove unused local.
10271 (emacs_gnutls_write): Don't use uninitialized rtnval if nbyte <= 0.
10273 * lisp.h: Fix a problem with aliasing and vector headers. (Bug#8546)
10274 GCC 4.6.0 optimizes based on type-based alias analysis.
10275 For example, if b is of type struct buffer * and v of type struct
10276 Lisp_Vector *, then gcc -O2 was incorrectly assuming that &b->size
10277 != &v->size, and therefore "v->size = 1; b->size = 2; return
10278 v->size;" must therefore return 1. This assumption is incorrect
10279 for Emacs, since it type-puns struct Lisp_Vector * with many other
10280 types. To fix this problem, this patch adds a new type struct
10281 vectorlike_header that documents the constraints on layout of vectors
10282 and pseudovectors, and helps optimizing compilers not get fooled
10283 by Emacs's type punning. It also adds the macros XSETTYPED_PVECTYPE
10284 XSETTYPED_PSEUDOVECTOR, TYPED_PSEUDOVECTORP, for similar reasons.
10285 * lisp.h (XSETTYPED_PVECTYPE): New macro, specifying the name of
10287 (XSETPVECTYPE): Rewrite in terms of new macro.
10288 (XSETPVECTYPESIZE): New macro, specifying both type and size.
10289 This is a bit clearer, and further avoids the possibility of
10290 undesirable aliasing.
10291 (XSETTYPED_PSEUDOVECTOR): New macro, specifying the size.
10292 (XSETPSEUDOVECTOR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR.
10293 (XSETSUBR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR and XSIZE,
10294 since Lisp_Subr is a special case (no "next" field).
10295 (ASIZE): Now uses header.size rather than size.
10296 All previous uses of XVECTOR (foo)->size replaced to use this macro,
10297 to avoid the hassle of writing XVECTOR (foo)->header.size.
10298 (struct vectorlike_header): New type.
10299 (TYPED_PSEUDOVECTORP): New macro, also specifying the C type of the
10300 object, to help avoid aliasing.
10301 (PSEUDOVECTORP): Rewrite in terms of TYPED_PSEUDOVECTORP.
10302 (SUBRP): Likewise, since Lisp_Subr is a special case.
10303 * lisp.h (struct Lisp_Vector, struct Lisp_Char_Table):
10304 (struct Lisp_Sub_Char_Table, struct Lisp_Bool_Vector):
10305 (struct Lisp_Hash_Table): Combine first two members into a single
10306 struct vectorlike_header member. All uses of "size" and "next" members
10307 changed to be "header.size" and "header.next".
10308 * buffer.h (struct buffer): Likewise.
10309 * font.h (struct font_spec, struct font_entity, struct font): Likewise.
10310 * frame.h (struct frame): Likewise.
10311 * process.h (struct Lisp_Process): Likewise.
10312 * termhooks.h (struct terminal): Likewise.
10313 * window.c (struct save_window_data, struct saved_window): Likewise.
10314 * window.h (struct window): Likewise.
10315 * alloc.c (allocate_buffer, Fmake_bool_vector, allocate_pseudovector):
10316 Use XSETPVECTYPESIZE, not XSETPVECTYPE, to avoid aliasing problems.
10317 * buffer.c (init_buffer_once): Likewise.
10318 * lread.c (defsubr): Use XSETTYPED_PVECTYPE, since Lisp_Subr is a
10320 * process.c (Fformat_network_address): Use local var for size,
10323 * bytecode.c (exec_byte_code): Don't use XVECTOR before CHECK_VECTOR.
10325 Make the Lisp reader and string-to-float more consistent (Bug#8525)
10326 * data.c (atof): Remove decl; no longer used or needed.
10327 (digit_to_number): Move to lread.c.
10328 (Fstring_to_number): Use new string_to_number function, to be
10329 consistent with how the Lisp reader treats infinities and NaNs.
10330 Do not assume that floating-point numbers represent EMACS_INT
10331 without losing information; this is not true on most 64-bit hosts.
10332 Avoid double-rounding errors, by insisting on integers when
10333 parsing non-base-10 numbers, as the documentation specifies.
10334 * lisp.h (string_to_number): New decl, replacing ...
10335 (isfloat_string): Remove.
10336 * lread.c: Include <inttypes.h>, for uintmax_t and strtoumax.
10337 (read1): Do not accept +. and -. as integers; this
10338 appears to have been a coding error. Similarly, do not accept
10339 strings like +-1e0 as floating point numbers. Do not report
10340 overflow for integer overflows unless the base is not 10 which
10341 means we have no simple and reliable way to continue.
10342 Break out the floating-point parsing into a new
10343 function string_to_number, so that Fstring_to_number parses
10344 floating point numbers consistently with the Lisp reader.
10345 (digit_to_number): Move here from data.c. Make it static inline.
10346 (E_CHAR, EXP_INT): Remove, replacing with ...
10347 (E_EXP): New macro, to solve the "1.0e+" problem mentioned below.
10348 (string_to_number): New function, replacing isfloat_string.
10349 This function checks for valid syntax and produces the resulting
10350 Lisp float number too. Rework it so that string-to-number
10351 no longer mishandles examples like "1.0e+". Use strtoumax,
10352 so that overflow for non-base-10 numbers is reported only when
10353 there's no portable and simple way to convert to floating point.
10355 * textprop.c (set_text_properties_1): Rewrite for clarity,
10356 and to avoid GCC warning about integer overflow.
10358 * intervals.h (struct interval): Use EMACS_INT for members
10359 where EMACS_UINT might cause problems. See
10360 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html>.
10361 (CHECK_TOTAL_LENGTH): Remove cast to EMACS_INT; no longer needed.
10362 * intervals.c (interval_deletion_adjustment): Now returns EMACS_INT.
10364 (offset_intervals): Tell GCC not to worry about length overflow
10365 when negating a negative length.
10367 * alloc.c (overrun_check_malloc, overrun_check_realloc): Now static.
10368 (overrun_check_free): Likewise.
10370 * alloc.c (SDATA_SIZE) [!GC_CHECK_STRING_BYTES]: Avoid runtime check
10371 in the common case where SDATA_DATA_OFFSET is a multiple of Emacs
10374 * gnutls.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
10375 (gnutls_make_error): Rename local to avoid shadowing.
10376 (gnutls_emacs_global_deinit): ifdef out; not used.
10377 (Fgnutls_boot): Use const for pointer to readonly storage.
10378 Comment out unused local. Fix pointer signedness problems.
10380 * lread.c (openp): Don't stuff size_t into an 'int'.
10381 Use <= on length, not < on length + 1, to avoid GCC 4.6.0 warning
10382 about possible signed overflow.
10384 * gtkutil.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
10385 (GDK_KEY_g): Don't define if already defined.
10386 (xg_prepare_tooltip): Avoid pointer signedness problem.
10387 (xg_set_toolkit_scroll_bar_thumb): Redo to avoid two casts.
10389 * process.c (Fnetwork_interface_info): Avoid left-shift undefined
10390 behavior with 1 << 31. GCC 4.6.0 warns about this on 32-bit hosts.
10392 * xfns.c (Fx_window_property): Simplify a bit,
10393 to make a bit faster and to avoid GCC 4.6.0 warning.
10394 * xselect.c (x_get_window_property, x_handle_dnd_message): Likewise.
10396 * fns.c (internal_equal): Don't assume size_t fits in int.
10398 * alloc.c (compact_small_strings): Tighten assertion a little.
10400 Replace pEd with more-general pI, and fix some printf arg casts.
10401 * lisp.h (pI): New macro, generalizing old pEd macro to other
10402 conversion specifiers. For example, use "...%"pI"d..." rather
10403 than "...%"pEd"...".
10404 (pEd): Remove. All uses replaced with similar uses of pI.
10405 * m/amdx86-64.h, m/ia64.h, m/ibms390x.h: Likewise.
10406 * alloc.c (check_pure_size): Don't overflow by converting size to int.
10407 * bidi.c (bidi_dump_cached_states): Use pI to avoid cast.
10408 * data.c (Fnumber_to_string): Use pI instead of if-then-else-abort.
10409 * dbusbind.c (xd_append_arg): Use pI to avoid cast.
10410 (Fdbus_method_return_internal, Fdbus_method_error_internal): Likewise.
10411 * font.c (font_unparse_xlfd): Avoid potential buffer overrun on
10413 (font_unparse_xlfd, font_unparse_fcname): Use pI to avoid casts.
10414 * keyboard.c (record_char, modify_event_symbol): Use pI to avoid casts.
10415 * print.c (safe_debug_print, print_object): Likewise.
10416 (print_object): Don't overflow by converting EMACS_INT or EMACS_UINT
10418 Use pI instead of if-then-else-abort. Use %p to avoid casts,
10419 avoiding the 0 flag, which is not portable.
10420 * process.c (Fmake_network_process): Use pI to avoid cast.
10421 * region-cache.c (pp_cache): Likewise.
10422 * xdisp.c (decode_mode_spec): Likewise.
10423 * xrdb.c (x_load_resources) [USE_MOTIF]: Use pI to avoid undefined
10424 behavior on 64-bit hosts with printf arg.
10425 * xselect.c (x_queue_event): Use %p to avoid casts, avoiding 0 flag.
10426 (x_stop_queuing_selection_requests): Likewise.
10427 (x_get_window_property): Don't truncate byte count to an 'int'
10430 * frame.c (frame_name_fnn_p): Get rid of strtol, which isn't right
10431 here, since it parses constructs like leading '-' and spaces,
10432 which are not wanted; and it overflows with large numbers.
10433 Instead, simply match F[0-9]+, which is what is wanted anyway.
10435 * alloc.c: Remove unportable assumptions about struct layout.
10436 (SDATA_SELECTOR, SDATA_DATA_OFFSET): New macros.
10437 (SDATA_OF_STRING, SDATA_SIZE, allocate_string_data):
10438 (allocate_vectorlike, make_pure_vector): Use the new macros,
10439 plus offsetof, to remove unportable assumptions about struct layout.
10440 These assumptions hold on all porting targets that I know of, but
10441 they are not guaranteed, they're easy to remove, and removing them
10442 makes further changes easier.
10444 * alloc.c (BLOCK BYTES): Fix typo by changing "ablock" to "ablocks".
10445 This doesn't fix a bug but makes the code clearer.
10446 (string_overrun_cookie): Now const. Use initializers that
10447 don't formally overflow signed char, to avoid warnings.
10448 (allocate_string_data) [GC_CHECK_STRING_OVERRUN]: Fix typo that
10449 can cause Emacs to crash when string overrun checking is enabled.
10450 (allocate_buffer): Don't assume sizeof (struct buffer) is a
10451 multiple of sizeof (EMACS_INT); it need not be, if
10452 alignof(EMACS_INT) < sizeof (EMACS_INT).
10453 (check_sblock, check_string_bytes, check_string_free_list): Protoize.
10455 2011-04-26 Juanma Barranquero <lekktu@gmail.com>
10457 * keyboard.c (QCrtl): Rename from Qrtl. All uses changed.
10459 2011-04-26 Teodor Zlatanov <tzz@lifelogs.com>
10461 * gnutls.c (emacs_gnutls_handshake): Return an error if we're not
10462 supposed to be handshaking. (Bug#8556)
10463 Reported by Paul Eggert <eggert@cs.ucla.edu>.
10465 2011-04-26 Daniel Colascione <dan.colascione@gmail.com>
10467 * lisp.h (Qdebug): List symbol.
10468 * eval.c (Qdebug): Restore global linkage.
10469 * keyboard.c (debug-on-event): New variable.
10470 (handle_user_signal): Break into debugger when debug-on-event
10471 matches the current signal symbol.
10473 2011-04-25 Dan Nicolaescu <dann@ics.uci.edu>
10475 * alloc.c (check_sblock, check_string_bytes)
10476 (check_string_free_list): Convert to standard C.
10478 2011-04-25 Teodor Zlatanov <tzz@lifelogs.com>
10480 * w32.c (emacs_gnutls_push): Fix typo.
10482 2011-04-25 Eli Zaretskii <eliz@gnu.org>
10484 * gnutls.c (emacs_gnutls_handshake): Avoid compiler warnings about
10485 "cast to pointer from integer of different size".
10487 Improve doprnt and its use in verror. (Bug#8545)
10488 * doprnt.c (doprnt): Document the set of format control sequences
10489 supported by the function. Use SAFE_ALLOCA instead of always
10492 * eval.c (verror): Don't limit the buffer size at size_max-1, that
10493 is one byte too soon. Don't use xrealloc; instead xfree and
10496 2011-04-24 Teodor Zlatanov <tzz@lifelogs.com>
10498 * gnutls.h: Add GNUTLS_STAGE_CALLBACKS enum to denote we're in the
10501 * gnutls.c: Renamed global_initialized to
10502 gnutls_global_initialized. Added internals for the
10503 :verify-hostname-error, :verify-error, and :verify-flags
10504 parameters of `gnutls-boot' and documented those parameters in the
10505 docstring. Start callback support.
10506 (emacs_gnutls_handshake): Add Woe32 support. Retry handshake
10507 unless a fatal error occurred. Call gnutls_alert_send_appropriate
10508 on error. Return error code.
10509 (emacs_gnutls_write): Call emacs_gnutls_handle_error.
10510 (emacs_gnutls_read): Likewise.
10511 (Fgnutls_boot): Return handshake error code.
10512 (emacs_gnutls_handle_error): New function.
10513 (wsaerror_to_errno): Likewise.
10515 * w32.h (emacs_gnutls_pull): Add prototype.
10516 (emacs_gnutls_push): Likewise.
10518 * w32.c (emacs_gnutls_pull): New function for GnuTLS on Woe32.
10519 (emacs_gnutls_push): Likewise.
10521 2011-04-24 Claudio Bley <claudio.bley@gmail.com> (tiny change)
10523 * process.c (wait_reading_process_output): Check if GnuTLS
10524 buffered some data internally if no FDs are set for TLS
10527 * makefile.w32-in (OBJ2): Add gnutls.$(O).
10528 (LIBS): Link to USER_LIBS.
10529 ($(BLD)/gnutls.$(0)): New target.
10531 2011-04-24 Eli Zaretskii <eliz@gnu.org>
10533 * xdisp.c (handle_single_display_spec): Rename the
10534 display_replaced_before_p argument into display_replaced_p, to
10535 make it consistent with the commentary. Fix typos in the
10538 * textprop.c (syms_of_textprop): Remove dead code.
10539 (copy_text_properties): Delete obsolete commentary about an
10540 interface that was deleted long ago. Fix typos in the description
10543 * msdos.c (XMenuActivate, XMenuAddSelection): Adjust argument list
10544 to changes in oldXMenu/XMenu.h from 2011-04-16.
10545 <menu_help_message, prev_menu_help_message>: Constify.
10546 (IT_menu_make_room): menu->help_text is now `const char **';
10549 * msdos.h (XMenuActivate, XMenuAddSelection): Adjust prototypes
10550 to changes in oldXMenu/XMenu.h from 2011-04-16.
10551 (struct XMenu): Declare `help_text' `const char **'.
10553 * xfaces.c <Qunspecified>: Make extern again.
10555 * syntax.c: Include sys/types.h before including regex.h, as
10558 * doc.c (get_doc_string): Improve the format passed to `error'.
10560 * doprnt.c (doprnt): Improve commentary.
10562 * term.c (init_tty) [MSDOS]: Fix 1st argument to maybe_fatal.
10564 * Makefile.in (TAGS): Depend on $(M_FILE) and $(S_FILE), and scan
10567 * makefile.w32-in (globals.h): Add a dummy recipe, to make any
10568 changes in globals.h immediately force recompilation.
10569 (TAGS): Depend on $(CURDIR)/m/intel386.h and
10570 $(CURDIR)/s/ms-w32.h.
10571 (TAGS-gmake): Scan $(CURDIR)/m/intel386.h and $(CURDIR)/s/ms-w32.h.
10573 * character.c (Fchar_direction): Function deleted.
10574 (syms_of_character): Don't defsubr it.
10575 <char-direction-table>: Deleted.
10577 2011-04-23 Eli Zaretskii <eliz@gnu.org>
10579 Fix doprnt so it could be used again safely in `verror'. (Bug#8435)
10580 * doprnt.c: Include limits.h.
10581 (SIZE_MAX): New macro.
10582 (doprnt): Return a size_t value. 2nd arg is now size_t.
10583 Many local variables are now size_t instead of int or unsigned.
10584 Improve overflow protection. Support `l' modifier for integer
10585 conversions. Support %l conversion. Don't assume an EMACS_INT
10586 argument for integer conversions and for %c.
10588 * lisp.h (doprnt): Restore prototype.
10590 * makefile.w32-in ($(BLD)/callint.$(O)): Depend on
10591 $(SRC)/character.h.
10593 * Makefile.in (base_obj): Add back doprnt.o.
10595 * deps.mk (doprnt.o): Add back prerequisites.
10596 (callint.o): Depend on character.h.
10598 * eval.c (internal_lisp_condition_case): Include the handler
10599 representation in the error message.
10600 (verror): Call doprnt instead of vsnprintf. Fix an off-by-one bug
10601 when breaking from the loop.
10603 * xdisp.c (vmessage): Call doprnt instead of vsnprintf.
10605 * callint.c (Fcall_interactively): When displaying error message
10606 about invalid control letter, pass the character's codepoint, not
10607 a pointer to its multibyte form. Improve display of the character
10608 in octal and display also its hex code.
10610 * character.c (char_string): Use %x to display the (unsigned)
10611 codepoint of an invalid character, to avoid displaying a bogus
10614 * font.c (check_otf_features): Pass SDATA of SYMBOL_NAME to
10615 `error', not SYMBOL_NAME itself.
10617 * coding.c (Fencode_sjis_char, Fencode_big5_char): Use %c for
10618 character arguments to `error'.
10620 * charset.c (check_iso_charset_parameter): Fix incorrect argument
10621 to `error' in error message about FINAL_CHAR argument. Make sure
10622 FINAL_CHAR is a character, and use %c when it is passed as
10623 argument to `error'.
10625 2011-04-23 Eli Zaretskii <eliz@gnu.org>
10627 * s/ms-w32.h (localtime): Redirect to sys_localtime.
10629 * w32.c: Include <time.h>.
10630 (sys_localtime): New function.
10632 2011-04-23 Chong Yidong <cyd@stupidchicken.com>
10634 * xdisp.c (init_xdisp): Initialize echo_area_window (Bug#6451).
10636 * buffer.c (syms_of_buffer): Doc fix (Bug#6902).
10638 2011-04-23 Samuel Thibault <sthibault@debian.org> (tiny change)
10640 * sysdep.c (wait_for_termination): On GNU Hurd, kill returns -1 on
10641 zombies (Bug#8467).
10643 2011-04-19 Eli Zaretskii <eliz@gnu.org>
10645 * syntax.h (SETUP_SYNTAX_TABLE_FOR_OBJECT): Fix setting of
10646 gl_state.e_property when gl_state.object is Qt.
10648 * insdel.c (make_gap_larger): Remove limitation of buffer size
10651 2011-04-18 Chong Yidong <cyd@stupidchicken.com>
10653 * xdisp.c (lookup_glyphless_char_display)
10654 (produce_glyphless_glyph): Handle cons cell entry in
10655 glyphless-char-display.
10656 (Vglyphless_char_display): Document it.
10658 * term.c (produce_glyphless_glyph): Handle cons cell entry in
10659 glyphless-char-display.
10661 2011-04-17 Chong Yidong <cyd@stupidchicken.com>
10663 * xdisp.c (get_next_display_element): Remove unnecessary ifdefs.
10665 * termhooks.h (FRAME_WINDOW_P): Remove duplicated definitions.
10667 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): Add missing
10668 definition for no-X builds.
10670 2011-04-16 Paul Eggert <eggert@cs.ucla.edu>
10672 Static checks with GCC 4.6.0 and non-default toolkits.
10674 * s/sol2-6.h, s/unixware.h (PTY_TTY_NAME_SPRINTF): Protoize decl.
10676 * process.c (keyboard_bit_set): Define only if SIGIO.
10677 (send_process_trap): Mark it with NO_RETURN if it doesn't return.
10678 (send_process): Repair possible setjmp clobbering.
10680 * s/usg5-4-common.h (SETUP_SLAVE_PTY): Don't pass extra arg to 'fatal'.
10682 * eval.c: Include <stdio.h>, for vsnprintf on non-GNU/Linux hosts.
10684 * data.c (arith_error): Mark with NO_RETURN if it doesn't return.
10686 * alloc.c (bytes_used_when_full, SPARE_MEMORY, BYTES_USED):
10687 Define only if needed.
10689 * sysdep.c (_FILE_OFFSET_BITS): Make this hack even uglier
10690 by pacifying GCC about it. Maybe it's time to retire it?
10691 * xfaces.c (USG, __TIMEVAL__): Likewise.
10693 * dispextern.h (struct redisplay_interface): Rename param
10694 to avoid shadowing.
10695 * termhooks.h (struct terminal): Likewise.
10696 * xterm.c (xembed_send_message): Likewise.
10698 * insdel.c (make_gap_smaller): Define only if
10699 USE_MMAP_FOR_BUFFERS || REL_ALLOC || DOUG_LEA_MALLOC.
10701 * keyboard.c (read_char): Make a var volatile so longjmp won't clobber
10704 * emacs.c (MAX_HEAP_BSS_DIFF, my_edata): Move to where they're used,
10705 so that we aren't warned about unused symbols.
10707 * xfns.c (Fx_file_dialog): Rename local to avoid shadowing.
10709 * xdisp.c (x_produce_glyphs): Mark var as initialized (Bug#8512).
10711 * xfns.c (x_real_positions): Mark locals as initialized.
10713 * xmenu.c (xmenu_show): Don't use uninitialized vars.
10715 * xterm.c: Fix problems found by static analysis with other toolkits.
10716 (toolkit_scroll_bar_interaction): Define and use only if USE_X_TOOLKIT.
10717 (x_dispatch_event): Declare static if USE_GTK, and
10718 define if USE_GTK || USE_X_TOOLKIT.
10719 (SET_SAVED_BUTTON_EVENT): Define only if USE_X_TOOLKIT || USE_GTK.
10720 * xterm.h (x_dispatch_event): Extern only if USE_X_TOOLKIT.
10721 * xterm.c, xterm.h (x_mouse_leave): Bring this function back, but only
10722 if defined HAVE_MENUS && !defined USE_X_TOOLKIT && !defined USE_GTK.
10724 * xmenu.c (menu_help_callback): Pointer type fixes.
10725 Use const pointers when pointing at readonly data. Avoid pointer
10726 signedness clashes.
10727 (FALSE): Remove unused macro.
10728 (update_frame_menubar): Remove unused decl.
10730 * xfns.c (Fx_hide_tip): Move locals to avoid shadowing.
10732 * menu.c (push_submenu_start, push_submenu_end): Do not define unless
10733 USE_X_TOOLKIT || USE_GTK || HAVE_NS || defined HAVE_NTGUI.
10734 (single_menu_item): Rename local to avoid shadowing.
10736 * keyboard.c (make_lispy_event): Remove unused local var.
10738 * frame.c, frame.h (x_get_resource_string): Bring this back, but
10739 only if HAVE_X_WINDOWS && !USE_X_TOOLKIT.
10741 * bitmaps: Change bitmaps from unsigned char back to the X11
10742 compatible char. Avoid the old compiler warnings about
10743 out-of-range initializers by using, for example, '\xab' rather
10746 * xgselect.c (xgselect_initialize): Check vs interface
10747 even if ! (defined (USE_GTK) || defined (HAVE_GCONF)).
10749 * xmenu.c (xmenu_show): Rename parm to avoid shadowing.
10751 * xterm.c (x_create_toolkit_scroll_bar): Use const * for pointers
10752 to read-only memory.
10754 * fns.c (vector): Remove; this old hack is no longer needed.
10756 * xsmfns.c (create_client_leader_window): Rename shadowing arg.
10758 (gdk_x11_set_sm_client_id) [!USE_GTK]: Don't define.
10760 * xrdb.c (x_load_resources): Omit unused local.
10762 * xfns.c (free_frame_menubar, atof): Remove duplicate decls.
10763 (x_window): Rename locals to avoid shadowing.
10764 (USG): Use the kludged USG macro, to pacify gcc.
10766 * xterm.c (x_alloc_nearest_color_for_widget): Remove; unused.
10767 (x_term_init): Remove local to avoid shadowing.
10769 * xfns.c, xterm.c (_XEditResCheckMessages): Protoize decl.
10771 * xdisp.c, dispextern.h (set_vertical_scroll_bar): Now extern if
10772 USE_TOOLKIT_SCROLL_BARS && !USE_GTK, as xterm.c needs it then.
10774 2011-04-16 Eli Zaretskii <eliz@gnu.org>
10776 * gnutls.c (Fgnutls_boot): Don't pass Lisp_Object to `error'.
10778 Fix regex.c, syntax.c and friends for buffers > 2GB.
10779 * syntax.h (struct gl_state_s): Declare character position members
10782 * syntax.c (update_syntax_table): Declare 2nd argument EMACS_INT.
10784 * textprop.c (verify_interval_modification, interval_of):
10785 Declare arguments EMACS_INT.
10787 * intervals.c (adjust_intervals_for_insertion): Declare arguments
10790 * intervals.h (CHECK_TOTAL_LENGTH): Cast to EMACS_INT, not `int'.
10792 * indent.c (Fvertical_motion): Local variable it_start is now
10795 * regex.c (re_match, re_match_2, re_match_2_internal)
10796 (bcmp_translate, regcomp, regexec, print_double_string)
10797 (group_in_compile_stack, re_search, re_search_2, regex_compile)
10798 (re_compile_pattern, re_exec): Declare arguments and local
10799 variables `size_t' and `ssize_t' and return values `regoff_t', as
10801 (POP_FAILURE_REG_OR_COUNT) <pfreg>: Declare `long'.
10802 (CHECK_INFINITE_LOOP) <failure>: Declare `ssize_t'.
10803 <compile_stack_type>: `size' and `avail' are now `size_t'.
10805 * regex.h <regoff_t>: Use ssize_t, not int.
10806 (re_search, re_search_2, re_match, re_match_2): Arguments that
10807 specify buffer/string position and length are now ssize_t and
10808 size_t. Return type is regoff_t.
10810 2011-04-16 Ben Key <bkey76@gmail.com>
10812 * nsfont.m: Fixed bugs in ns_get_family and
10813 ns_descriptor_to_entity that were caused by using free to
10814 deallocate memory blocks that were allocated by xmalloc (via
10815 xstrdup). This caused Emacs to crash when compiled with
10816 XMALLOC_OVERRUN_CHECK defined (when Emacs was configured with
10817 --enable-checking=xmallocoverrun). xfree is now used to
10818 deallocate these memory blocks.
10820 2011-04-15 Paul Eggert <eggert@cs.ucla.edu>
10822 * sysdep.c (emacs_read): Remove unnecessary check vs MAX_RW_COUNT.
10824 emacs_write: Accept and return EMACS_INT for sizes.
10825 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html
10827 * gnutls.c, gnutls.h (emacs_gnutls_read, emacs_gnutls_write):
10828 Accept and return EMACS_INT.
10829 (emacs_gnutls_write): Return the number of bytes written on
10831 * sysdep.c, lisp.h (emacs_read, emacs_write): Likewise.
10832 (emacs_read, emacs_write): Remove check for negative size, as the
10833 Emacs source code has been audited now.
10834 * sysdep.c (MAX_RW_COUNT): New macro, to work around kernel bugs.
10835 (emacs_read, emacs_write): Use it.
10836 * process.c (send_process): Adjust to the new signatures of
10837 emacs_write and emacs_gnutls_write. Do not attempt to store
10838 a byte offset into an 'int'; it might overflow.
10839 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00483.html
10841 * sound.c: Don't assume sizes fit in 'int'.
10842 (struct sound_device.period_size, alsa_period_size):
10843 Return EMACS_INT, not int.
10844 (struct sound_device.write, vox_write, alsa_write):
10845 Accept EMACS_INT, not int.
10846 (wav_play, au_play): Use EMACS_INT to store sizes and to
10847 record read return values.
10849 2011-04-15 Ben Key <bkey76@gmail.com>
10851 * keyboard.c (Qundefined): Don't declare static since it is used
10853 * xfaces.c (Qbold, Qexpanded, Qitalic, Qcondensed): Don't declare
10854 static since they are used in nsfont.m.
10856 2011-04-15 Stefan Monnier <monnier@iro.umontreal.ca>
10858 * process.c (Qprocessp): Don't declare static.
10859 * lisp.h (Qprocessp): Declare again.
10861 2011-04-15 Juanma Barranquero <lekktu@gmail.com>
10863 * font.c (Qopentype): Don't make static (used from w32uniscribe.c).
10865 2011-04-14 Paul Eggert <eggert@cs.ucla.edu>
10867 Improve C-level modularity by making more things 'static'.
10869 Don't publish debugger-only interfaces to other modules.
10870 * lisp.h (safe_debug_print, debug_output_compilation_hack):
10871 (verify_bytepos, count_markers): Move decls to the only modules
10873 * region-cache.h (pp_cache): Likewise.
10874 * window.h (check_all_windows): Likewise.
10875 * marker.c, print.c, region-cache.c, window.c: Decls moved here.
10877 * sysdep.c (croak): Now static, if
10878 defined TIOCNOTTY || defined USG5 || defined CYGWIN.
10879 * syssignal.h (croak): Declare only if not static.
10881 * alloc.c (refill_memory_reserve): Now static if
10882 !defined REL_ALLOC || defined SYSTEM_MALLOC.
10883 * lisp.h (refill_memory_reserve): Declare only if not static.
10885 * xsettings.c, xsettings.h (xsettings_get_system_normal_font):
10886 Define only if USE_LUCID.
10888 * xrdb.c (x_customization_string, x_rm_string): Now static.
10890 * xmenu.c (x_menu_wait_for_event): Export only if USE_MOTIF.
10891 * xterm.h (x_menu_wait_for_event): Declare only if USE_MOTIF.
10893 * xdisp.c (draw_row_with_mouse_face): Now static.
10894 * dispextern.h (draw_row_with_mouse_fave): Remove decl.
10896 * window.h (check_all_windows): Mark externally visible.
10898 * window.c (window_deletion_count): Now static.
10900 * undo.c: Make symbols static if they're not exported.
10901 (last_undo_buffer, last_boundary_position, pending_boundary):
10904 * textprop.c (interval_insert_behind_hooks): Now static.
10905 (interval_insert_in_front_hooks): Likewise.
10907 * term.c: Make symbols static if they're not exported.
10908 (tty_turn_off_highlight, get_tty_terminal, max_frame_cols):
10909 (max_frame_lines, tty_set_terminal_modes):
10910 (tty_reset_terminal_modes, tty_turn_off_highlight):
10911 (get_tty_terminal): Now static.
10912 (term_mouse_moveto): Do not define if HAVE_WINDOW_SYSTEM.
10913 * termhooks.h (term_mouse_moveto): Do not declare if
10914 HAVE_WINDOW_SYSTEM.
10915 * dispextern.h (tty_set_terminal_modes, tty_reset_terminal_modes):
10916 (tty_turn_off_highlight, get_tty_terminal): Remove decls.
10918 * sysdep.c: Make symbols static if they're not exported.
10919 (emacs_get_tty, emacs_set_tty, old_fcntl_flags, old_fcntl_owner):
10921 (sigprocmask_set, full_mask): Remove; unused.
10922 (wait_debugging): Mark as visible.
10923 * syssignal.h (SIGFULLMASK, full_mask): Remove decls.
10924 * systty.h (emacs_get_tty, emacs_set_tty): Remove decls.
10926 * syntax.c (syntax_temp): Define only if !__GNUC__.
10928 * sound.c (current_sound_device, current_sound): Now static.
10930 * search.c (searchbufs, searchbuf_head): Now static.
10932 * scroll.c (scroll_cost): Remove; unused.
10933 * dispextern.h (scroll_cost): Remove decl.
10935 * region-cache.h (pp_cache): Mark as externally visible.
10937 * process.c: Make symbols static if they're not exported.
10938 (process_tick, update_tick, create_process, chan_process):
10939 (Vprocess_alist, proc_buffered_char, datagram_access):
10940 (fd_callback_data, send_process_frame, process_sent_to): Now static.
10941 (deactivate_process): Mark defn as static, as well as decl.
10942 * lisp.h (create_process): Remove decl.
10943 * process.h (chan_process, Vprocess_alist): Remove decls.
10945 * print.c: Make symbols static if they're not exported.
10946 (print_depth, new_backquote_output, being_printed, print_buffer):
10947 (print_buffer_size, print_buffer_pos, print_buffer_pos_byte):
10948 (print_interval, print_number_index, initial_stderr_stream):
10950 * lisp.h (Fprinc): Remove decl.
10951 (debug_output_compilation_hack): Mark as externally visible.
10953 * sysdep.c (croak): Move decl from here to syssignal.h.
10954 * syssignal.h (croak): Put it here, so the API can be checked when
10955 'croak' is called from dissociate_if_controlling_tty.
10957 * minibuf.c: Make symbols static if they're not exported.
10958 (minibuf_save_list, choose_minibuf_frame): Now static.
10959 * lisp.h (choose_minibuf_frame): Remove decl.
10961 * lisp.h (verify_bytepos, count_markers): Mark as externally visible.
10963 * lread.c: Make symbols static if they're not exported.
10964 (read_objects, initial_obarray, oblookup_last_bucket_number):
10966 (make_symbol): Remove; unused.
10967 * lisp.h (initial_obarray, make_symbol): Remove decls.
10969 * keyboard.c: Make symbols static if they're not exported.
10970 (single_kboard, recent_keys_index, total_keys, recent_keys):
10971 (this_command_key_count_reset, raw_keybuf, raw_keybuf_count):
10972 (this_single_command_key_start, echoing, last_auto_save):
10973 (read_key_sequence_cmd, dribble, recursive_edit_unwind):
10974 (command_loop, echo_now, keyboard_init_hook, help_char_p):
10975 (quit_throw_to_read_char, command_loop_2, top_level_1, poll_timer):
10976 (Vlispy_mouse_stem, double_click_count):
10978 (force_auto_save_soon): Define only if SIGDANGER.
10979 (ignore_mouse_drag_p): Now static if
10980 !defined HAVE_WINDOW_SYSTEM || defined USE_GTK || defined HAVE_NS.
10981 (print_help): Remove; unused.
10982 (stop_character, last_timer_event): Mark as externally visible.
10983 * keyboard.h (ignore_mouse_drag_p): Declare only if
10984 defined HAVE_WINDOW_SYSTEM && !defined USE_GTK && !defined HAVE_NS.
10985 (echo_now, help_char_p, quit_throw_to_read_char): Remove decls.
10986 * lisp.h (echoing): Remove decl.
10987 (force_auto_save_soon): Declare only if SIGDANGER.
10988 * xdisp.c (redisplay_window): Simplify code, to make it more
10989 obvious that ignore_mouse_drag_p is not accessed if !defined
10990 USE_GTK && !defined HAVE_NS.
10992 * intervals.c: Make symbols static if they're not exported.
10993 (merge_properties_sticky, merge_interval_right, delete_interval):
10995 * intervals.h (merge_interval_right, delete_interval): Remove decls.
10997 * insdel.c: Make symbols static if they're not exported.
10998 However, leave prepare_to_modify_buffer alone. It's never
10999 called from outside this function, but that appears to be a bug.
11000 (combine_after_change_list, combine_after_change_buffer):
11001 (adjust_after_replace, signal_before_change): Now static.
11002 (adjust_after_replace_noundo): Remove; unused.
11003 * lisp.h (adjust_after_replace, adjust_after_replace_noundo):
11004 (signal_before_change): Remove decls.
11006 * indent.c (val_compute_motion, val_vmotion): Now static.
11008 * image.c: Make symbols static if they're not exported.
11009 * dispextern.h (x_create_bitmap_from_xpm_data): Do not declare
11011 * image.c (x_create_bitmap_from_xpm_data): Do not define if USE_GTK.
11012 (xpm_color_cache, ct_table, ct_colors_allocated): Now static.
11014 * fringe.c (standard_bitmaps): Now static.
11015 (max_used_fringe_bitmap): Now static, unless HAVE_NS.
11017 * frame.c: Make symbols static if they're not exported.
11018 (x_report_frame_params, make_terminal_frame): Now static.
11019 (get_frame_param): Now static, unless HAVE_NS.
11020 (x_fullscreen_adjust): Define if WINDOWSNT, not if HAVE_WINDOW_SYSTEM.
11021 (x_get_resource_string): Remove; not used.
11022 * frame.h (make_terminal_frame, x_report_frame_params):
11023 (x_get_resource_string); Remove decls.
11024 (x_fullscreen_adjust): Declare only if WINDOWSNT.
11025 * lisp.h (get_frame_param): Declare only if HAVE_NS.
11027 * font.c, fontset.c: Make symbols static if they're not exported.
11028 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): New macro.
11029 (FACE_SUITABLE_FOR_CHAR_P): Use it.
11030 * font.c (font_close_object): Now static.
11031 * font.h (font_close_object): Remove.
11032 * fontset.c (FONTSET_OBJLIST): Remove.
11033 (free_realized_fontset) #if-0 the body, which does nothing.
11034 (face_suitable_for_char_p): #if-0, as it's never called.
11035 * fontset.h (face_suitable_for_char_p): Remove decl.
11036 * xfaces.c (face_at_string_position):
11037 Use FACE_SUITABLE_FOR_ASCII_CHAR_P, not FACE_SUITABLE_FOR_CHAR_P,
11038 since 0 is always ASCII.
11040 * fns.c (weak_hash_tables): Now static.
11042 * fileio.c: Make symbols static if they're not exported.
11043 (auto_saving, auto_save_mode_bits, auto_save_error_occurred):
11044 (Vwrite_region_annotation_buffers): Now static.
11046 * eval.c: Make symbols static if they're not exported.
11047 (backtrace_list, lisp_eval_depth, when_entered_debugger): Now static.
11048 * lisp.h (backtrace_list): Remove decl.
11050 * emacs.c: Make symbols static if they're not exported.
11051 (malloc_state_ptr, malloc_using_checking, syms_of_emacs):
11052 (fatal_error_code, fatal_error_signal_hook, standard_args):
11054 (fatal_error_signal): Now static, unless FLOAT_CATCH_SIGKILL.
11055 (DEFINE_DUMMY_FUNCTION): Mark function as externally visible.
11056 (__CTOR_LIST__, __DTOR_LIST__): Now externally visible.
11057 * lisp.h (fatal_error_signal_hook): Remove decl.
11058 (fatal_error_signal): Declare only if FLOAT_CATCH_SIGKILL.
11060 * editfns.c: Move a (normally-unused) function to its only use.
11061 * editfns.c, lisp.h (get_operating_system_release): Remove.
11062 * process.c (init_process) [DARWIN_OS]: Do it inline, as it is not
11063 worth the hassle of breaking this out.
11065 * xterm.c: Make symbols static if they're not exported.
11066 (x_raise_frame, x_lower_frame, x_wm_set_window_state):
11067 (x_wm_set_icon_pixmap, x_initialize, XTread_socket_fake_io_error):
11068 (x_destroy_window, x_delete_display):
11070 (x_dispatch_event): Now static if ! (USE_MOTIF || USE_X_TOOLKIT).
11071 (x_mouse_leave): Remove; unused.
11072 * xterm.h (x_display_info_for_name, x_raise_frame, x_lower_frame):
11073 (x_destroy_window, x_wm_set_window_state, x_wm_set_icon_pixmap):
11074 (x_delete_display, x_initialize, x_set_border_pixel, x_screen_planes):
11076 (x_mouse_leave): Declare only if WINDOWSNT.
11077 (x_dispatch_event): Declare only if USE_MOTIF or USE_X_TOOLKIT.
11078 (xic_create_fontsetname): Declare only if HAVE_X_WINDOWS &&
11081 * ftxfont.c: Make symbols static if they're not exported.
11082 (ftxfont_driver): Export only if !defined HAVE_XFT && def8ined
11084 * font.h (ftxfont_driver): Likewise.
11086 * xfns.c: Make symbols static if they're not exported.
11087 (x_last_font_name, x_display_info_for_name):
11088 (x_set_foreground_color, x_set_background_color, x_set_mouse_color):
11089 (x_set_cursor_color, x_set_border_pixel, x_set_border_color):
11090 (x_set_cursor_type, x_set_icon_type, x_set_icon_name):
11091 (x_set_scroll_bar_foreground, x_set_scroll_bar_background):
11092 (x_explicitly_set_name, x_set_title, xic_defaut_fontset, tip_timer):
11093 (last_show_tip_args): Now static.
11094 (xic_defaut_fontset, xic_create_fontsetname): Define only if
11095 defined HAVE_X_WINDOWS && defined USE_X_TOOLKIT
11096 (x_screen_planes): Remove; unused.
11097 * dispextern.h (x_screen_planes): Remove decl.
11099 * dispnew.c: Make symbols static if they're not exported.
11100 * dispextern.h (redraw_garbaged_frames, scrolling):
11101 (increment_row_positions): Remove.
11102 * dispnew.c (new_glyph_matrix, increment_row_positions, scrolling):
11103 (delayed_size_change, glyph_matrix_count, glyph_pool_count):
11105 (redraw_garbaged_frames): Remove; unused.
11107 * xfaces.c: Make symbols static if they're not exported.
11108 * dispextern.h (ascii_face_of_lisp_face, free_realized_face):
11110 * xterm.h (defined_color): Remove decls.
11111 (x_free_dpy_colors): Declare only if USE_X_TOOLKIT.
11112 * xfaces.c (tty_suppress_bold_inverse_default_colors_p):
11113 (menu_face_changed_default, defined_color, free_realized_face):
11114 (x_free_dpy_colors): Define only if USE_X_TOOLKIT.
11115 (ascii_face_of_lisp_face): Remove; unused.
11117 * xdisp.c: Make symbols static if they're not exported.
11118 * dispextern.h (scratch_glyph_row, window_box_edges):
11119 (glyph_to_pixel_coords, set_cursor_from_row):
11120 (get_next_display_element, set_iterator_to_next):
11121 (highlight_trailing_whitespace, frame_to_window_pixel_xy):
11122 (show_mouse_face): Remove decls
11123 * frame.h (message_buf_print): Likewise.
11124 * lisp.h (pop_message, set_message, check_point_in_composition):
11126 * xterm.h (set_vertical_scroll_bar): Likewise.
11127 * xdisp.c (list_of_error, Vmessage_stack, line_number_displayed):
11128 (message_buf_print, scratch_glyph_row, displayed_buffer):
11129 (set_iterator_to_next, pop_message, set_message, set_cursor_from_row):
11130 (get_next_display_element, show_mouse_face, window_box_edges):
11131 (frame_to_window_pixel_xy, check_point_in_composition):
11132 (set_vertical_scroll_bar, highlight_trailing_whitespace): Now static.
11133 (glyph_to_pixel_coords): Remove; unused.
11135 * dired.c (file_name_completion): Now static.
11137 * dbusbind.c (xd_in_read_queued_messages): Now static.
11139 * lisp.h (circular_list_error, FOREACH): Remove; unused.
11140 * data.c (circular_list_error): Remove.
11142 * commands.h (last_point_position, last_point_position_buffer):
11143 (last_point_position_window): Remove decls.
11144 * keyboard.c: Make these variables static.
11146 * coding.h (coding, code_convert_region, encode_coding_gap):
11148 * coding.c (Vsjis_coding_system, Vbig5_coding_system):
11149 (iso_code_class, detect_coding, code_convert_region): Now static.
11150 (encode_coding_gap): Remove; unused.
11152 * chartab.c (chartab_chars, chartab_bits): Now static.
11154 * charset.h (charset_iso_8859_1): Remove decl.
11155 * charset.c (charset_iso_8859_1, charset_emacs, map_charset_for_dump):
11158 * ccl.h (check_ccl_update, Vccl_program_table): Remove decls.
11159 * ccl.c (Vccl_program_table): Now static.
11160 (check_ccl_update): Remove; unused.
11162 * category.c (SET_CATEGORY_SET, set_category_set): Move here.
11163 * category.h: ... from here.
11164 * category.c (check_category_table, set_category_set): Now static.
11166 * casetab.c (Vascii_upcase_table, Vascii_eqv_table): Now static.
11167 * lisp.h: Remove these decls.
11169 * buffer.c (buffer_count): Remove unused var.
11171 * bidi.c (bidi_dump_cached_states): Mark as externally visible,
11172 so that it's not optimized away.
11173 (bidi_ignore_explicit_marks_for_paragraph_level): Likewise.
11174 * dispextern.h (bidi_dump_cached_states): Remove, since it's
11175 exported only to the debugger.
11177 * atimer.c (alarm_signal_handler, run_all_atimers): Now static.
11178 * atimer.h (run_all_atimers): Remove; not exported.
11180 font.c: Make copy_font_spec and merge_font_spec ordinary C functions.
11181 * font.c (copy_font_spec): Rename from Fcopy_font_spec, since it
11182 was inaccessible from Lisp.
11183 (merge_font_spec): Likewise, renaming from Fmerge_font_spec.
11184 * font.c, font.h, fontset.c, xfaces.c, xfont.c: Change all uses.
11186 alloc.c: Import and export fewer symbols, and remove unused items.
11187 * lisp.h (suppress_checking, die): Declare only if ENABLE_CHECKING
11189 (suppress_checking): Add EXTERNALLY_VISIBLE attribute, so that
11190 it's not optimized away by whole-program optimization.
11191 (message_enable_multibyte, free_misc): Remove.
11192 (catchlist, handlerlist, mark_backtrace):
11193 Declare only if BYTE_MARK_STACK.
11194 (mark_byte_stack): Likewise, fixing a ifdef-vs-if typo.
11195 * alloc.c (pure): Export only if VIRT_ADDR_VARIES is defined.
11196 (message_enable_multibyte): Remove decl.
11197 (free_misc, interval_free_list, float_block, float_block_index):
11198 (n_float_blocks, float_free_list, cons_block, cons_block_index):
11199 (cons_free_list, last_marked_index):
11201 (suppress_checking, die): Define only if ENABLE_CHECKING is defined.
11202 * eval.c (catchlist, handlerlist): Export only if BYTE_MARK_STACK.
11203 (mark_backtrace): Define only if BYTE_MARK_STACK.
11204 * xdisp.c (message_enable_multibyte): Now static.
11206 Declare Lisp_Object Q* variables to be 'static' if not exported.
11207 This makes it easier for human readers (and static analyzers)
11208 to see whether these variables are used from other modules.
11209 * alloc.c, buffer.c, bytecode.c, callint.c, casetab.c, category.c:
11210 * ccl.c, character.c, charset.c, cmds.c, coding.c, composite.c:
11211 * data.c, dbusbind.c, dired.c, editfns.c, eval.c, fileio.c, fns.c:
11212 * font.c, frame.c, fringe.c, ftfont.c, image.c, keyboard.c, keymap.c:
11213 * lread.c, macros.c, minibuf.c, print.c, process.c, search.c:
11214 * sound.c, syntax.c, textprop.c, window.c, xdisp.c, xfaces.c, xfns.c:
11215 * xmenu.c, xselect.c:
11216 Declare Q* vars static if they are not used in other modules.
11217 * ccl.h, character.h, charset.h, coding.h, composite.h, font.h:
11218 * frame.h, intervals.h, keyboard.h, lisp.h, process.h, syntax.h:
11219 Remove decls of unexported vars.
11220 * keyboard.h (EVENT_HEAD_UNMODIFIED): Remove now-unused macro.
11222 * lisp.h (DEFINE_FUNC): Make sname 'static'.
11224 Make Emacs functions such as Fatom 'static' by default.
11225 This makes it easier for human readers (and static analyzers)
11226 to see whether these functions can be called from other modules.
11227 DEFUN now defines a static function. To make the function external
11228 so that it can be used in other C modules, use the new macro DEFUE.
11229 * lisp.h (Funibyte_char_to_multibyte, Fsyntax_table_p):
11230 (Finit_image_library):
11231 (Feval_region, Fbacktrace, Ffetch_bytecode, Fswitch_to_buffer):
11232 (Ffile_executable_p, Fmake_symbolic_link, Fcommand_execute):
11233 (Fget_process, Fdocumentation_property, Fbyte_code, Ffile_attributes):
11234 Remove decls, since these functions are now static.
11235 (Funintern, Fget_internal_run_time): New decls, since these functions
11236 were already external.
11238 * alloc.c, buffer.c, callint.c, callproc.c, casefiddle.c, casetab.c:
11239 * ccl.c, character.c, chartab.c, cmds.c, coding.c, data.c, dispnew.c:
11240 * doc.c, editfns.c, emacs.c, eval.c, fileio.c, filelock.c, floatfns.c:
11241 * fns.c, font.c, fontset.c, frame.c, image.c, indent.c:
11242 * keyboard.c, keymap.c, lread.c:
11243 * macros.c, marker.c, menu.c, minibuf.c, print.c, process.c, search.c:
11244 * syntax.c, term.c, terminal.c, textprop.c, undo.c:
11245 * window.c, xdisp.c, xfaces.c, xfns.c, xmenu.c, xsettings.c:
11246 Mark functions with DEFUE instead of DEFUN,
11247 if they are used in other modules.
11248 * buffer.c (Fset_buffer_major_mode, Fdelete_overlay): New forward
11249 decls for now-static functions.
11250 * buffer.h (Fdelete_overlay): Remove decl.
11251 * callproc.c (Fgetenv_internal): Mark as internal.
11252 * composite.c (Fremove_list_of_text_properties): Remove decl.
11253 (Fcomposition_get_gstring): New forward static decl.
11254 * composite.h (Fcomposite_get_gstring): Remove decl.
11255 * dired.c (Ffile_attributes): New forward static decl.
11256 * doc.c (Fdocumntation_property): New forward static decl.
11257 * eval.c (Ffetch_bytecode): New forward static decl.
11258 (Funintern): Remove extern decl; now in .h file where it belongs.
11259 * fileio.c (Fmake_symbolic_link): New forward static decl.
11260 * image.c (Finit_image_library): New forward static decl.
11261 * insdel.c (Fcombine_after_change_execute): Make forward decl static.
11262 * intervals.h (Fprevious_property_change):
11263 (Fremove_list_of_text_properties): Remove decls.
11264 * keyboard.c (Fthis_command_keys): Remove decl.
11265 (Fcommand_execute): New forward static decl.
11266 * keymap.c (Flookup_key): New forward static decl.
11267 (Fcopy_keymap): Now static.
11268 * keymap.h (Flookup_key): Remove decl.
11269 * process.c (Fget_process): New forward static decl.
11270 (Fprocess_datagram_address): Mark as internal.
11271 * syntax.c (Fsyntax_table_p): New forward static decl.
11272 (skip_chars): Remove duplicate decl.
11273 * textprop.c (Fprevious_property_change): New forward static decl.
11274 * window.c (Fset_window_fringes, Fset_window_scroll_bars):
11276 (Fset_window_margins, Fset_window_vscroll): New forward static decls.
11277 * window.h (Fset_window_vscroll, Fset_window_margins): Remove decls.
11279 * editfns.c (Fformat): Remove unreachable code.
11281 2011-04-14 Andreas Schwab <schwab@linux-m68k.org>
11283 * fileio.c (Finsert_file_contents): Fix typo in 2005-05-13
11286 2011-04-13 Eli Zaretskii <eliz@gnu.org>
11288 * xdisp.c (handle_invisible_prop): Don't call bidi_paragraph_init
11289 when at ZV. (Bug#8487)
11291 2011-04-12 Andreas Schwab <schwab@linux-m68k.org>
11293 * charset.c (Fclear_charset_maps): Use xfree instead of free.
11295 * keyboard.c (parse_tool_bar_item): Likewise.
11296 * sound.c (sound_cleanup, alsa_close): Likewise.
11297 * termcap.c (tgetent): Likewise.
11298 * xfns.c (x_default_font_parameter): Likewise.
11299 * xsettings.c (read_and_apply_settings): Likewise.
11301 * alloc.c (overrun_check_malloc, overrun_check_realloc)
11302 (overrun_check_free): Protoize.
11304 2011-04-12 Paul Eggert <eggert@cs.ucla.edu>
11306 * sysdep.c (emacs_read, emacs_write): Check for negative sizes
11307 since callers should never pass a negative size.
11308 Change the signature to match that of plain 'read' and 'write'; see
11309 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00397.html>.
11310 * lisp.h: Update prototypes of emacs_write and emacs_read.
11312 2011-04-11 Eli Zaretskii <eliz@gnu.org>
11314 * xdisp.c (redisplay_window): Don't try to determine the character
11315 position of the scroll margin if the window start point w->startp
11316 is outside the buffer's accessible region. (Bug#8468)
11318 2011-04-10 Eli Zaretskii <eliz@gnu.org>
11320 Fix write-region and its subroutines for buffers > 2GB.
11321 * fileio.c (a_write, e_write): Modify declaration of arguments and
11322 local variables to support buffers larger than 2GB.
11323 (Fcopy_file): Use EMACS_INT for return value of emacs_read.
11325 * sysdep.c (emacs_write, emacs_read): Use ssize_t for last
11326 argument, local variables, and return value.
11328 * lisp.h: Update prototypes of emacs_write and emacs_read.
11330 * sound.c (vox_write): Use ssize_t for return value of emacs_write.
11332 2011-04-10 Paul Eggert <eggert@cs.ucla.edu>
11334 * xdisp.c (vmessage): Use memchr, not strnlen, which some hosts lack.
11336 Fix more problems found by GCC 4.6.0's static checks.
11338 * xdisp.c (vmessage): Use a better test for character truncation.
11340 * charset.c (load_charset_map): <, not <=, for optimization,
11341 and to avoid potential problems with integer overflow.
11342 * chartab.c (sub_char_table_set_range, char_table_set_range): Likewise.
11343 * casetab.c (set_identity, shuffle): Likewise.
11344 * editfns.c (Fformat): Likewise.
11345 * syntax.c (skip_chars): Likewise.
11347 * xmenu.c (set_frame_menubar): Allocate smaller local vectors.
11348 This also lets GCC 4.6.0 generate slightly better loop code.
11350 * callint.c (Fcall_interactively): <, not <=, for optimization.
11351 (Fcall_interactively): Count the number of arguments produced,
11352 not the number of arguments given. This is simpler and lets GCC
11353 4.6.0 generate slightly better code.
11355 * ftfont.c: Distingish more carefully between FcChar8 and char.
11356 The previous code passed unsigned char * to a functions like
11357 strlen and xstrcasecmp that expect char *, which does not
11358 conform to the C standard.
11359 (get_adstyle_property, ftfont_pattern_entity): Use FcChar8 for
11360 arguments to FcPatternGetString, and explicitly cast FcChar8 * to
11361 char * when the C standard requires it.
11363 * keyboard.c (read_char): Remove unused var.
11365 * eval.c: Port to Windows vsnprintf (Bug#8435).
11366 Include <limits.h>.
11367 (SIZE_MAX): Define if the headers do not.
11368 (verror): Do not give up if vsnprintf returns a negative count.
11369 Instead, grow the buffer. This ports to Windows vsnprintf, which
11370 does not conform to C99. Problem reported by Eli Zaretskii.
11371 Also, simplify the allocation scheme, by avoiding the need for
11372 calling realloc, and removing the ALLOCATED variable.
11374 * eval.c (verror): Initial buffer size is 4000 (not 200) bytes.
11376 Remove invocations of doprnt, as Emacs now uses vsnprintf.
11377 But keep the doprint source code for now, as we might revamp it
11378 and use it again (Bug#8435).
11379 * lisp.h (doprnt): Remove.
11380 * Makefile.in (base_obj): Remove doprnt.o.
11381 * deps.mk (doprnt.o): Remove.
11383 error: Print 32- and 64-bit integers portably (Bug#8435).
11384 Without this change, on typical 64-bit hosts error ("...%d...", N)
11385 was used to print both 32- and 64-bit integers N, which relied on
11386 undefined behavior.
11387 * lisp.h, m/amdx86-64.h, m/ia64.h, m/ibms390x.h (pEd): New macro.
11388 * lisp.h (error, verror): Mark as printf-like functions.
11389 * eval.c (verror): Use vsnprintf, not doprnt, to do the real work.
11390 Report overflow in size calculations when allocating printf buffer.
11391 Do not truncate output string at its first null byte.
11392 * xdisp.c (vmessage): Use vsnprintf, not doprnt, to do the real work.
11393 Truncate the output at a character boundary, since vsnprintf does not
11395 * charset.c (check_iso_charset_parameter): Convert internal
11396 character to string before calling 'error', since %c now has the
11398 * coding.c (Fdecode_sjis_char, Fdecode_big5_char): Avoid int
11399 overflow when computing char to be passed to 'error'. Do not
11400 pass Lisp_Object to 'error'; pass the integer instead.
11401 * nsfns.m (Fns_do_applescript): Use int, not long, since it's
11402 formatted with plain %d.
11404 * eval.c (internal_lisp_condition_case): Don't pass spurious arg.
11406 * keyboard.c (access_keymap_keyremap): Print func name, not garbage.
11408 * coding.c (Fdecode_sjis_char): Don't assume CODE fits in int.
11410 * xterm.c (x_catch_errors): Remove duplicate declaration.
11412 * term.c (maybe_fatal): Mark its 3rd arg as a printf format, too.
11414 * xdisp.c, lisp.h (message_nolog): Remove; unused.
11416 2011-04-10 Jim Meyering <meyering@redhat.com>
11418 use ssize_t and size_t for read- and write-like emacs_gnutls_* functions
11419 * gnutls.c (emacs_gnutls_read): Adjust signature to be more read-like:
11420 return ssize_t not "int", and use size_t as the buffer length.
11421 (emacs_gnutls_write): Likewise, and make the buffer pointer "const".
11422 * gnutls.h: Update declarations.
11423 * process.c (read_process_output): Use ssize_t, to match.
11424 (send_process): Likewise.
11426 2011-04-09 Chong Yidong <cyd@stupidchicken.com>
11428 * image.c (Fimagemagick_types): Doc fix, and comment cleanup.
11430 2011-04-09 Chong Yidong <cyd@stupidchicken.com>
11432 * ftfont.c (get_adstyle_property, ftfont_pattern_entity):
11433 Use unsigned char, to match FcChar8 type definition.
11435 * xterm.c (handle_one_xevent):
11436 * xmenu.c (create_and_show_popup_menu):
11437 * xselect.c (x_decline_selection_request)
11438 (x_reply_selection_request): Avoid type-punned deref of X events.
11440 2011-04-09 Eli Zaretskii <eliz@gnu.org>
11442 Fix some uses of `int' instead of EMACS_INT.
11443 * search.c (string_match_1, fast_string_match)
11444 (fast_c_string_match_ignore_case, fast_string_match_ignore_case)
11445 (scan_buffer, find_next_newline_no_quit)
11446 (find_before_next_newline, search_command, Freplace_match)
11447 (Fmatch_data): Make some `int' variables be EMACS_INT.
11449 * xdisp.c (display_count_lines): 3rd argument and return value now
11450 EMACS_INT. All callers changed.
11451 (pint2hrstr): Last argument is now EMACS_INT.
11453 * coding.c (detect_coding_utf_8, detect_coding_emacs_mule)
11454 (detect_coding_iso_2022, detect_coding_sjis, detect_coding_big5)
11455 (detect_coding_ccl, detect_coding_charset, decode_coding_utf_8)
11456 (decode_coding_utf_16, decode_coding_emacs_mule)
11457 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5)
11458 (decode_coding_ccl, decode_coding_charset)
11459 <consumed_chars, consumed_chars_base>: Declare EMACS_INT.
11460 (decode_coding_iso_2022, decode_coding_emacs_mule)
11461 (decode_coding_sjis, decode_coding_big5, decode_coding_charset)
11462 <char_offset, last_offset>: Declare EMACS_INT.
11463 (encode_coding_utf_8, encode_coding_utf_16)
11464 (encode_coding_emacs_mule, encode_invocation_designation)
11465 (encode_designation_at_bol, encode_coding_iso_2022)
11466 (encode_coding_sjis, encode_coding_big5, encode_coding_ccl)
11467 (encode_coding_raw_text, encode_coding_charset) <produced_chars>:
11469 (ASSURE_DESTINATION): Declare more_bytes EMACS_INT.
11470 (encode_invocation_designation): Last argument P_NCHARS is now
11472 (decode_eol): Declare pos_byte, pos, and pos_end EMACS_INT.
11473 (produce_chars): from_nchars and to_nchars are now EMACS_INT.
11475 * coding.h (struct coding_system) <head_ascii>: Declare EMACS_INT.
11478 * ccl.c (Fccl_execute_on_string): Declare some variables
11481 2011-04-08 Samuel Thibault <sthibault@debian.org> (tiny change)
11483 * term.c (init_tty): Fix incorrect ifdef placement (Bug#8450).
11485 2011-03-19 Christoph Scholtes <cschol2112@googlemail.com>
11487 * process.c (Fformat_network_address): Doc fix.
11489 2011-04-08 T.V. Raman <tv.raman.tv@gmail.com> (tiny change)
11491 * xml.c (parse_region): Avoid creating spurious whitespace nodes.
11493 2011-04-08 Chong Yidong <cyd@stupidchicken.com>
11495 * keyboard.c (read_char): Call Lisp function help-form-show,
11496 instead of using internal_with_output_to_temp_buffer.
11497 (Qhelp_form_show): New var.
11498 (syms_of_keyboard): Use DEFSYM macro.
11500 * print.c (internal_with_output_to_temp_buffer): Function deleted.
11502 * lisp.h (internal_with_output_to_temp_buffer): Remove prototype.
11504 2011-04-06 Chong Yidong <cyd@stupidchicken.com>
11506 * process.c (Flist_processes): Remove to Lisp.
11507 (list_processes_1): Delete.
11509 2011-04-06 Eli Zaretskii <eliz@gnu.org>
11511 * msdos.c (careadlinkat, careadlinkatcwd): MS-DOS replacements.
11513 * w32.c (careadlinkat, careadlinkatcwd): New always-fail stubs.
11515 2011-04-06 Paul Eggert <eggert@cs.ucla.edu>
11517 Fix more problems found by GCC 4.6.0's static checks.
11519 * xmenu.c (Fx_popup_dialog): Don't assume string is free of formats.
11521 * menu.c (Fx_popup_menu): Don't assume error_name lacks printf formats.
11523 * lisp.h (message, message_nolog, fatal): Mark as printf-like.
11525 * xdisp.c (vmessage): Mark as a printf-like function.
11527 * term.c (vfatal, maybe_fatal): Mark as printf-like functions.
11529 * sound.c (sound_warning): Don't crash if arg contains a printf format.
11531 * image.c (tiff_error_handler, tiff_warning_handler): Mark as
11532 printf-like functions.
11533 (tiff_load): Add casts to remove these marks before passing them
11534 to system-supplied API.
11536 * eval.c (Fsignal): Remove excess argument to 'fatal'.
11538 * coding.c (EMIT_ONE_BYTE, EMIT_TWO_BYTES): Use unsigned, not int.
11539 This avoids several warnings with gcc -Wstrict-overflow.
11540 (DECODE_COMPOSITION_RULE): If the rule is invalid, goto invalid_code
11541 directly, rather than having caller test rule sign. This avoids
11542 some unnecessary tests.
11543 * composite.h (COMPOSITION_ENCODE_RULE_VALID): New macro.
11544 (COMPOSITION_ENCODE_RULE): Arguments now must be valid. This
11545 affects only one use, in DECODE_COMPOSITION_RULE, which is changed.
11547 * xfont.c (xfont_text_extents): Remove var that was set but not used.
11548 (xfont_open): Avoid unnecessary tests.
11550 * composite.c (composition_gstring_put_cache): Use unsigned integer.
11552 * composite.h, composite.c (composition_gstring_put_cache):
11553 Use EMACS_INT, not int, for length.
11555 * composite.h (COMPOSITION_DECODE_REFS): New macro,
11556 breaking out part of COMPOSITION_DECODE_RULE.
11557 (COMPOSITION_DECODE_RULE): Use it.
11558 * composite.c (get_composition_id): Remove unused local vars,
11559 by using the new macro.
11561 * textprop.c (set_text_properties_1): Change while to do-while,
11562 since the condition is always true at first.
11564 * intervals.c (graft_intervals_into_buffer): Mark var as used.
11565 (interval_deletion_adjustment): Return unsigned value.
11568 * process.c (list_processes_1, create_pty, read_process_output):
11569 (exec_sentinel): Remove vars that were set but not used.
11570 (create_pty): Remove unnecessary "volatile"s.
11571 (Fnetwork_interface_info): Avoid possibility of int overflow.
11572 (read_process_output): Do adaptive read buffering even if carryover.
11573 (read_process_output): Simplify nbytes computation if buffered.
11575 * bytecode.c (exec_byte_code): Rename local to avoid shadowing.
11577 * syntax.c (scan_words): Remove var that was set but not used.
11578 (update_syntax_table): Use unsigned instead of int.
11580 * lread.c (lisp_file_lexically_bound_p): Use ints rather than endptrs.
11581 (lisp_file_lexically_bound_p, read1): Use unsigned instead of int.
11582 (safe_to_load_p): Make the end-of-loop test the inverse of the in-loop.
11584 * print.c (print_error_message): Avoid int overflow.
11586 * font.c (font_list_entities): Redo for clarity,
11587 so that reader need not know FONT_DPI_INDEX + 1 == FONT_SPACING_INDEX.
11589 * font.c (font_find_for_lface, Ffont_get_glyphs): Remove unused vars.
11590 (font_score): Avoid potential overflow in diff calculation.
11592 * fns.c (substring_both): Remove var that is set but not used.
11593 (sxhash): Redo loop for clarity and to avoid wraparound warning.
11595 * eval.c (funcall_lambda): Rename local to avoid shadowing.
11597 * alloc.c (mark_object_loop_halt, mark_object): Use size_t, not int.
11598 Otherwise, GCC 4.6.0 optimizes the loop check away since the check
11599 can always succeed if overflow has undefined behavior.
11601 * search.c (boyer_moore, wordify): Remove vars set but not used.
11602 (wordify): Omit three unnecessary tests.
11604 * indent.c (MULTIBYTE_BYTES_WIDTH): Don't compute wide_column.
11605 All callers changed. This avoids the need for an unused var.
11607 * casefiddle.c (casify_region): Remove var that is set but not used.
11609 * dired.c (file_name_completion): Remove var that is set but not used.
11611 * fileio.c (Finsert_file_contents): Make EOF condition clearer.
11613 * fileio.c (Finsert_file_contents): Avoid signed integer overflow.
11614 (Finsert_file_contents): Remove unnecessary code checking fd.
11616 * minibuf.c (read_minibuf_noninteractive): Use size_t for sizes.
11617 Check for integer overflow on size calculations.
11619 * buffer.c (Fprevious_overlay_change): Remove var that is set
11622 * keyboard.c (menu_bar_items, read_char_minibuf_menu_prompt):
11623 Remove vars that are set but not used.
11624 (timer_check_2): Don't assume timer-list and idle-timer-list are lists.
11625 (timer_check_2): Mark vars as initialized.
11627 * gtkutil.c (xg_get_file_with_chooser): Mark var as initialized.
11629 * image.c (lookup_image): Remove var that is set but not used.
11630 (xbm_load): Use parse_p, for gcc -Werror=unused-but-set-variable.
11632 * fontset.c (Finternal_char_font, Ffontset_info): Remove vars
11633 that are set but not used.
11635 * xfns.c (make_invisible_cursor): Don't return garbage
11636 if XCreateBitmapFromData fails (Bug#8410).
11638 * xselect.c (x_get_local_selection, x_handle_property_notify):
11639 Remove vars that are set but not used.
11641 * xfns.c (x_create_tip_frame): Remove var that is set but not used.
11642 (make_invisible_cursor): Initialize a possibly-uninitialized variable.
11644 * xterm.c (x_scroll_bar_to_input_event) [!USE_GTK]:
11645 Remove var that is set but not used.
11646 (scroll_bar_windows_size): Now size_t, not int.
11647 (x_send_scroll_bar_event): Use size_t, not int, for sizes.
11648 Check for overflow.
11650 * xfaces.c (realize_named_face): Remove vars that are set but not used.
11651 (map_tty_color) [!defined MSDOS]: Likewise.
11653 * term.c (tty_write_glyphs): Use size_t; this avoids overflow warning.
11655 * coding.c: Remove vars that are set but not used.
11656 (DECODE_COMPOSITION_RULE): Remove 2nd arg, which is unused.
11657 All callers changed.
11658 (decode_coding_utf_8, decode_coding_utf_16 decode_coding_emacs_mule):
11659 (decode_coding_iso_2022, encode_coding_sjis, encode_coding_big5):
11660 (decode_coding_charset): Remove vars that are set but not used.
11662 * bytecode.c (Fbyte_code) [!defined BYTE_CODE_SAFE]: Remove var
11663 that is set but not used.
11665 * print.c (print_object): Remove var that is set but not used.
11667 Replace 2 copies of readlink code with 1 gnulib version (Bug#8401).
11668 The gnulib version avoids calling malloc in the usual case,
11669 and on 64-bit hosts doesn't have some arbitrary 32-bit limits.
11670 * fileio.c (Ffile_symlink_p): Use emacs_readlink.
11671 * filelock.c (current_lock_owner): Likewise.
11672 * lisp.h (READLINK_BUFSIZE, emacs_readlink): New function.
11673 * sysdep.c: Include allocator.h, careadlinkat.h.
11674 (emacs_no_realloc_allocator): New static constant.
11675 (emacs_readlink): New function.
11676 * deps.mk (sysdep.o): Depend on ../lib/allocator.h and on
11677 ../lib/careadlinkat.h.
11679 2011-04-04 Stefan Monnier <monnier@iro.umontreal.ca>
11681 * keyboard.c (safe_run_hook_funcall): Fix last change (don't stop at the
11682 first non-nil return value).
11684 2011-04-03 Jan Djärv <jan.h.d@swipnet.se>
11686 * nsterm.m (ns_update_auto_hide_menu_bar): Define MAC_OS_X_VERSION_10_6
11687 if not defined (Bug#8403).
11689 2011-04-02 Juanma Barranquero <lekktu@gmail.com>
11691 * xdisp.c (display_count_lines): Remove parameter `start',
11692 unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
11693 (get_char_face_and_encoding): Remove parameter `multibyte_p',
11694 unused since 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
11695 (fill_stretch_glyph_string): Remove parameters `row' and `area',
11696 unused at least since Kim's GUI unification at 2003-03-16T20:45:46Z!storm@cua.dk
11697 and thereabouts. All callers changed.
11698 (get_per_char_metric): Remove parameter `f', unused since
11699 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
11701 2011-04-02 Jim Meyering <meyering@redhat.com>
11703 do not dereference NULL upon failed strdup
11704 * nsfont.m (ns_descriptor_to_entity): Use xstrdup, not strdup.
11705 (ns_get_family): Likewise.
11707 2011-04-02 Juanma Barranquero <lekktu@gmail.com>
11709 * eval.c (unwind_to_catch) [DEBUG_GCPRO]: Remove redundant assignment.
11711 2011-04-02 Jan Djärv <jan.h.d@swipnet.se>
11713 * nsterm.m (ns_update_auto_hide_menu_bar): Only for OSX 10.6 or
11716 2011-04-01 Stefan Monnier <monnier@iro.umontreal.ca>
11718 Add lexical binding.
11720 * window.c (Ftemp_output_buffer_show): New fun.
11721 (Fsave_window_excursion):
11722 * print.c (Fwith_output_to_temp_buffer): Move to subr.el.
11724 * lread.c (lisp_file_lexically_bound_p): New function.
11725 (Fload): Bind Qlexical_binding.
11726 (readevalloop): Remove `evalfun' arg.
11727 Bind Qinternal_interpreter_environment.
11728 (Feval_buffer): Bind Qlexical_binding.
11729 (defvar_int, defvar_bool, defvar_lisp_nopro, defvar_kboard):
11731 (syms_of_lread): Declare `lexical-binding'.
11733 * lisp.h (struct Lisp_Symbol): New field `declared_special'.
11735 * keyboard.c (eval_dyn): New fun.
11736 (menu_item_eval_property): Use it.
11738 * image.c (parse_image_spec): Use Ffunctionp.
11740 * fns.c (concat, mapcar1): Accept byte-code-functions.
11742 * eval.c (Fsetq): Handle lexical vars.
11743 (Fdefun, Fdefmacro, Ffunction): Make closures when needed.
11744 (Fdefconst, Fdefvaralias, Fdefvar): Mark as dynamic.
11745 (FletX, Flet): Obey lexical binding.
11746 (Fcommandp): Handle closures.
11747 (Feval): New `lexical' arg.
11748 (eval_sub): New function extracted from Feval. Use it almost
11749 everywhere where Feval was used. Look up vars in lexical env.
11751 (Ffunctionp): Move from subr.el.
11752 (Ffuncall): Handle closures.
11753 (apply_lambda): Remove `eval_flags'.
11754 (funcall_lambda): Handle closures and new byte-code-functions.
11755 (Fspecial_variable_p): New function.
11756 (syms_of_eval): Initialize the Vinternal_interpreter_environment var,
11757 but without exporting it to Lisp.
11759 * doc.c (Fdocumentation, store_function_docstring):
11760 * data.c (Finteractive_form): Handle closures.
11762 * callint.c (Fcall_interactively): Preserve lexical-binding mode for
11765 * bytecode.c (Bstack_ref, Bstack_set, Bstack_set2, BdiscardN):
11767 (exec_byte_code): New function extracted from Fbyte_code to handle new
11768 calling convention for byte-code-functions. Add new byte-codes.
11770 * buffer.c (defvar_per_buffer): Set new `declared_special' field.
11772 * alloc.c (Fmake_symbol): Init new `declared_special' field.
11774 2011-03-31 Juanma Barranquero <lekktu@gmail.com>
11776 * xdisp.c (redisplay_internal): Fix prototype.
11778 2011-03-31 Eli Zaretskii <eliz@gnu.org>
11780 * xdisp.c (SCROLL_LIMIT): New macro.
11781 (try_scrolling): Use it when setting scroll_limit.
11782 Limit scrolling to 100 screen lines.
11783 (redisplay_window): Even when falling back on "recentering",
11784 position point in the window according to scroll-conservatively,
11785 scroll-margin, and scroll-*-aggressively variables. (Bug#6671)
11787 (try_scrolling): When point is above the window, allow searching
11788 as far as scroll_max, or one screenful, to compute vertical
11789 distance from PT to the scroll margin position. This prevents
11790 try_scrolling from unnecessarily failing when
11791 scroll-conservatively is set to a value slightly larger than the
11792 window height. Clean up the case of PT below the margin at bottom
11793 of window: scroll_max can no longer be INT_MAX. When aggressive
11794 scrolling is in use, don't let point enter the opposite scroll
11795 margin as result of the scroll.
11796 (syms_of_xdisp) <scroll-conservatively>: Document the
11797 threshold of 100 lines for never-recentering scrolling.
11799 2011-03-31 Juanma Barranquero <lekktu@gmail.com>
11801 * dispextern.h (move_it_by_lines):
11802 * xdisp.c (move_it_by_lines): Remove parameter `need_y_p', unused
11803 since 2000-12-29T14:24:09Z!gerd@gnu.org. All callers changed.
11804 (message_log_check_duplicate): Remove parameters `prev_bol' and
11805 `this_bol', unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
11806 (redisplay_internal): Remove parameter `preserve_echo_area',
11807 unused since 1999-07-21T21:43:52Z!gerd@gnu.org. All callers changed.
11809 * indent.c (Fvertical_motion):
11810 * window.c (window_scroll_pixel_based, Frecenter):
11811 Don't pass `need_y_p' to `move_it_by_lines'.
11813 2011-03-30 Stefan Monnier <monnier@iro.umontreal.ca>
11815 * eval.c (struct backtrace): Don't cheat with negative numbers, but do
11816 steal a few bits to be more compact.
11817 (interactive_p, Fbacktrace, Fbacktrace_frame, mark_backtrace):
11818 Remove unneeded casts.
11820 * bytecode.c (Fbyte_code): CAR and CDR can GC.
11822 2011-03-30 Zachary Kanfer <zkanfer@gmail.com> (tiny change)
11824 * keyboard.c (Fexecute_extended_command): Do log the "suggest key
11825 binding" message (bug#7967).
11827 2011-03-30 Paul Eggert <eggert@cs.ucla.edu>
11829 Fix more problems found by GCC 4.6.0's static checks.
11831 * unexelf.c (unexec) [! (defined _SYSTYPE_SYSV || defined __sgi)]:
11832 Remove unused local var.
11834 * editfns.c (Fmessage_box): Remove unused local var.
11836 * xdisp.c (try_window_reusing_current_matrix, x_produce_glyphs):
11837 (note_mode_line_or_margin_highlight, note_mouse_highlight):
11838 Omit unused local vars.
11839 * window.c (shrink_windows): Omit unused local var.
11840 * menu.c (digest_single_submenu): Omit unused local var.
11841 * dispnew.c (update_window) [PERIODIC_PREEMPTION_CHECKING]:
11842 Omit unused local var.
11844 * keyboard.c (parse_modifiers_uncached, parse_modifiers):
11845 Don't assume string length fits in int.
11846 (keyremap_step, read_key_sequence): Use size_t for sizes.
11847 (read_key_sequence): Don't check last_real_key_start redundantly.
11849 * callproc.c (Fcall_process, Fcall_process_region): Use SAFE_ALLOCA
11850 instead of alloca (Bug#8344).
11852 * eval.c (Fbacktrace): Don't assume nargs fits in int.
11853 (Fbacktrace_frame): Don't assume nframes fits in int.
11855 * syntax.c (scan_sexps_forward): Avoid pointer wraparound.
11857 * xterm.c (x_make_frame_visible, same_x_server): Redo to avoid overflow
11860 * term.c (produce_glyphless_glyph): Remove unnecessary test.
11862 * cm.c (calccost): Turn while-do into do-while, for clarity.
11864 * keyboard.c (syms_of_keyboard): Use the same style as later
11865 in this function when indexing through an array. This also
11866 works around GCC bug 48267.
11868 * image.c (tiff_load): Fix off-by-one image count (Bug#8336).
11870 * xselect.c (x_check_property_data): Return correct size (Bug#8335).
11872 * chartab.c (sub_char_table_ref_and_range): Redo for slight
11873 efficiency gain, and to bypass a gcc -Wstrict-overflow warning.
11875 * keyboard.c, keyboard.h (num_input_events): Now size_t.
11876 This avoids undefined behavior on integer overflow, and is a bit
11877 more convenient anyway since it is compared to a size_t variable.
11879 Variadic C functions now count arguments with size_t, not int.
11880 This avoids an unnecessary limitation on 64-bit machines, which
11881 caused (substring ...) to crash on large vectors (Bug#8344).
11882 * lisp.h (struct Lisp_Subr.function.aMANY): Now takes size_t, not int.
11883 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call): Likewise.
11884 All variadic functions and their callers changed accordingly.
11885 (struct gcpro.nvars): Now size_t, not int. All uses changed.
11886 * data.c (arith_driver, float_arith_driver): Likewise.
11887 * editfns.c (general_insert_function): Likewise.
11888 * eval.c (struct backtrace.nargs, interactive_p)
11889 (internal_condition_case_n, run_hook_with_args, apply_lambda)
11890 (funcall_lambda, mark_backtrace): Likewise.
11891 * fns.c (concat): Likewise.
11892 * frame.c (x_set_frame_parameters): Likewise.
11893 * fns.c (get_key_arg): Now accepts and returns size_t, and returns
11894 0 if not found, not -1. All callers changed.
11896 * alloc.c (garbage_collect): Don't assume stack size fits in int.
11897 (stack_copy_size): Now size_t, not int.
11898 (stack_copy, stack_copy_size): Define only if MAX_SAVE_STACK > 0.
11900 2011-03-28 Juanma Barranquero <lekktu@gmail.com>
11902 * coding.c (encode_designation_at_bol): Remove parameter `charbuf_end',
11903 unused since 2002-03-01T01:17:24Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
11904 All callers changed.
11906 * lisp.h (multibyte_char_to_unibyte):
11907 * character.c (multibyte_char_to_unibyte): Remove parameter `rev_tbl',
11908 unused since 2002-03-01T01:16:34Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
11909 * character.h (CHAR_TO_BYTE8):
11910 * cmds.c (internal_self_insert):
11911 * editfns.c (general_insert_function):
11912 * keymap.c (push_key_description):
11913 * search.c (Freplace_match):
11914 * xdisp.c (message_dolog, set_message_1): All callers changed.
11916 2011-03-28 Stefan Monnier <monnier@iro.umontreal.ca>
11918 * keyboard.c (safe_run_hook_funcall): New function.
11919 (safe_run_hooks_1, safe_run_hooks_error, safe_run_hooks): On error,
11920 don't set the hook to nil, but remove the offending function instead.
11921 (Qcommand_hook_internal): Remove, unused.
11922 (syms_of_keyboard): Don't initialize Qcommand_hook_internal nor define
11923 Vcommand_hook_internal.
11925 * eval.c (enum run_hooks_condition): Remove.
11926 (funcall_nil, funcall_not): New functions.
11927 (run_hook_with_args): Call each function through a `funcall' argument.
11928 Remove `cond' argument, now redundant.
11929 (Frun_hooks, Frun_hook_with_args, Frun_hook_with_args_until_success)
11930 (Frun_hook_with_args_until_failure): Adjust accordingly.
11931 (run_hook_wrapped_funcall, Frun_hook_wrapped): New functions.
11933 2011-03-28 Juanma Barranquero <lekktu@gmail.com>
11935 * dispextern.h (string_buffer_position): Remove declaration.
11937 * print.c (strout): Remove parameter `multibyte', unused since
11938 1999-08-21T19:30:21Z!gerd@gnu.org. All callers changed.
11940 * search.c (boyer_moore): Remove parameters `len', `pos' and `lim',
11941 never used since function introduction in 1998-02-08T21:33:56Z!rms@gnu.org.
11942 All callers changed.
11944 * w32.c (_wsa_errlist): Use braces for struct initializers.
11946 * xdisp.c (string_buffer_position_lim): Remove parameter `w',
11947 never used since function introduction in 2001-03-09T18:41:50Z!gerd@gnu.org.
11948 All callers changed.
11949 (string_buffer_position): Likewise. Also, make static (it's never
11950 used outside xdisp.c).
11951 (cursor_row_p): Remove parameter `w', unused since
11952 2000-10-17T16:08:57Z!gerd@gnu.org. All callers changed.
11953 (decode_mode_spec): Remove parameter `precision', introduced during
11954 Gerd Moellmann's rewrite at 1999-07-21T21:43:52Z!gerd@gnu.org, but never used.
11955 All callers changed.
11957 2011-03-27 Jan Djärv <jan.h.d@swipnet.se>
11959 * nsterm.m (syms_of_nsterm): Use doc: for ns-auto-hide-menu-bar.
11961 2011-03-27 Anders Lindgren <andlind@gmail.com>
11963 * nsterm.m (ns_menu_bar_is_hidden): New variable.
11964 (ns_constrain_all_frames, ns_menu_bar_should_be_hidden)
11965 (ns_update_auto_hide_menu_bar): New functions.
11966 (ns_update_begin): Call ns_update_auto_hide_menu_bar.
11967 (applicationDidBecomeActive): Call ns_update_auto_hide_menu_bar and
11968 ns_constrain_all_frames.
11969 (constrainFrameRect): Return at once if ns_menu_bar_should_be_hidden.
11970 (syms_of_nsterm): DEFVAR ns-auto-hide-menu-bar, init to Qnil.
11972 2011-03-27 Jan Djärv <jan.h.d@swipnet.se>
11974 * nsmenu.m (runDialogAt): Remove argument to timer_check.
11976 2011-03-27 Glenn Morris <rgm@gnu.org>
11978 * syssignal.h: Replace RETSIGTYPE with void.
11979 * atimer.c, data.c, dispnew.c, emacs.c, floatfns.c, keyboard.c:
11980 * keyboard.h, lisp.h, process.c, sysdep.c, xterm.c:
11981 Replace SIGTYPE with void everywhere.
11982 * s/usg5-4-common.h (SIGTYPE): Remove definition.
11983 * s/template.h (SIGTYPE): Remove commented out definition.
11985 2011-03-26 Eli Zaretskii <eliz@gnu.org>
11987 * xdisp.c (redisplay_window): Don't check buffer's clip_changed
11988 flag as a prerequisite for invoking try_scrolling. (Bug#6671)
11990 2011-03-26 Juanma Barranquero <lekktu@gmail.com>
11992 * w32.c (read_unc_volume): Use parameter `henum', instead of
11993 global variable `wget_enum_handle'.
11995 * keymap.c (describe_vector): Remove parameters `indices' and
11996 `char_table_depth', unused since 2002-03-01T01:43:26Z!handa@m17n.org.
11997 (describe_map, Fdescribe_vector): Adjust calls to `describe_vector'.
11999 * keyboard.h (timer_check, show_help_echo): Remove unused parameters.
12001 * keyboard.c (timer_check): Remove parameter `do_it_now',
12002 unused since 1996-04-12T06:01:29Z!rms@gnu.org.
12003 (show_help_echo): Remove parameter `ok_to_overwrite_keystroke_echo',
12004 unused since 2008-04-19T19:30:53Z!monnier@iro.umontreal.ca.
12006 * keyboard.c (read_char):
12007 * w32menu.c (w32_menu_display_help):
12008 * xmenu.c (show_help_event, menu_help_callback):
12009 Adjust calls to `show_help_echo'.
12011 * gtkutil.c (xg_maybe_add_timer):
12012 * keyboard.c (readable_events):
12013 * process.c (wait_reading_process_output):
12014 * xmenu.c (x_menu_wait_for_event): Adjust calls to `timer_check'.
12016 * insdel.c (adjust_markers_gap_motion):
12017 Remove; no-op since 1998-01-02T21:29:48Z!rms@gnu.org.
12018 (gap_left, gap_right): Don't call it.
12020 2011-03-25 Chong Yidong <cyd@stupidchicken.com>
12022 * xdisp.c (handle_fontified_prop): Discard changes to clip_changed
12023 incurred during fontification.
12025 2011-03-25 Juanma Barranquero <lekktu@gmail.com>
12027 * buffer.c (defvar_per_buffer): Remove unused parameter `doc'.
12028 (DEFVAR_PER_BUFFER): Don't pass it.
12030 * dispnew.c (row_equal_p, add_row_entry): Remove unused parameter `w'.
12031 (scrolling_window): Don't pass it.
12033 2011-03-25 Juanma Barranquero <lekktu@gmail.com>
12035 * dispextern.h (glyph_matric): Use #if GLYPH_DEBUG, not #ifdef.
12037 * fileio.c (check_executable) [DOS_NT]: Remove unused variables `len'
12039 (Fset_file_selinux_context) [HAVE_LIBSELINUX]: Move here declaration
12040 of variables specific to SELinux and computation of `encoded_absname'.
12042 * image.c (XPutPixel): Remove unused variable `height'.
12044 * keyboard.c (make_lispy_event): Remove unused variable `hpos'.
12046 * unexw32.c (get_section_info): Remove unused variable `section'.
12048 * w32.c (stat): Remove unused variables `drive_root' and `devtype'.
12049 (system_process_attributes): Remove unused variable `sess'.
12050 (sys_read): Remove unused variable `err'.
12052 * w32fns.c (top): Wrap variables with #if GLYPH_DEBUG, not #ifdef.
12053 (w32_wnd_proc): Remove unused variable `isdead'.
12054 (unwind_create_frame): Use #if GLYPH_DEBUG, not #ifdef.
12055 (Fx_server_max_request_size): Remove unused variable `dpyinfo'.
12056 (x_create_tip_frame): Remove unused variable `tem'.
12058 * w32inevt.c (w32_console_read_socket):
12059 Remove unused variable `no_events'.
12061 * w32term.c (x_draw_composite_glyph_string_foreground):
12062 Remove unused variable `width'.
12064 2011-03-24 Juanma Barranquero <lekktu@gmail.com>
12066 * w32term.c (x_set_glyph_string_clipping):
12067 Don't pass uninitialized region to CombineRgn.
12069 2011-03-23 Juanma Barranquero <lekktu@gmail.com>
12071 * w32fns.c (x_set_menu_bar_lines): Remove unused variable `olines'.
12072 (w32_wnd_proc): Pass NULL to Windows API, not uninitialized buffer.
12073 (Fx_close_connection): Remove unused variable `i'.
12075 * w32font.c (w32font_draw): Return number of glyphs.
12076 (w32font_open_internal): Remove unused variable `i'.
12077 (w32font_driver): Add missing initializer.
12079 * w32menu.c (utf8to16): Remove unused variable `utf16'.
12080 (fill_in_menu): Remove unused variable `items_added'.
12082 * w32term.c (last_mouse_press_frame): Remove static global variable.
12083 (w32_clip_to_row): Remove unused variable `f'.
12084 (x_delete_terminal): Remove unused variable `i'.
12086 * w32uniscribe.c (uniscribe_shape): Remove unused variable `nclusters'.
12087 (NOTHING): Remove unused static global variable.
12088 (uniscribe_check_otf): Remove unused variable `table'.
12089 (uniscribe_font_driver): Add missing initializers.
12091 2011-03-23 Julien Danjou <julien@danjou.info>
12093 * term.c (Fsuspend_tty, Fresume_tty):
12094 * minibuf.c (read_minibuf, run_exit_minibuf_hook):
12095 * window.c (temp_output_buffer_show):
12096 * insdel.c (signal_before_change):
12097 * frame.c (Fhandle_switch_frame):
12098 * fileio.c (Fdo_auto_save):
12099 * emacs.c (Fkill_emacs):
12100 * editfns.c (save_excursion_restore):
12101 * cmds.c (internal_self_insert):
12102 * callint.c (Fcall_interactively):
12103 * buffer.c (Fkill_all_local_variables):
12104 * keyboard.c (Fcommand_execute, Fsuspend_emacs, safe_run_hooks_1):
12106 (command_loop_1): Use Frun_hooks. Call safe_run_hooks
12107 unconditionally since it does the check itself.
12109 2011-03-23 Paul Eggert <eggert@cs.ucla.edu>
12111 Fix more problems found by GCC 4.5.2's static checks.
12113 * coding.c (encode_coding_raw_text): Avoid unnecessary test
12114 the first time through the loop, since we know p0 < p1 then.
12115 This also avoids a gcc -Wstrict-overflow warning.
12117 * lisp.h (SAFE_ALLOCA, SAFE_ALLOCA_LISP): Avoid 'int' overflow
12118 leading to a memory leak, possible in functions like
12119 load_charset_map_from_file that can allocate an unbounded number
12120 of objects (Bug#8318).
12122 * xmenu.c (set_frame_menubar): Use EMACS_UINT, not int, for indexes
12123 that could (at least in theory) be that large.
12125 * xdisp.c (message_log_check_duplicate): Return unsigned long, not int.
12126 This is less likely to overflow, and avoids undefined behavior if
12127 overflow does occur. All callers changed. Use strtoul to scan
12128 for the unsigned long integer.
12129 (pint2hrstr): Simplify and tune code slightly.
12130 This also avoids a (bogus) GCC warning with gcc -Wstrict-overflow.
12132 * scroll.c (do_scrolling): Work around GCC bug 48228.
12133 See <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=48228>.
12135 * frame.c (Fmodify_frame_parameters): Simplify loop counter.
12136 This also avoids a warning with gcc -Wstrict-overflow.
12137 (validate_x_resource_name): Simplify count usage.
12138 This also avoids a warning with gcc -Wstrict-overflow.
12140 * fileio.c (Fcopy_file): Report error if fchown or fchmod
12143 * emacs.c (Fdaemon_initialized): Do not ignore I/O errors (Bug#8303).
12145 * process.c (Fmake_network_process): Use socklen_t, not int,
12146 where POSIX says socklen_t is required in portable programs.
12147 This fixes a porting bug on hosts like 64-bit HP-UX, where
12148 socklen_t is wider than int (Bug#8277).
12149 (Fmake_network_process, server_accept_connection):
12150 (wait_reading_process_output, read_process_output):
12153 * process.c: Rename or move locals to avoid shadowing.
12154 (list_processes_1, Fmake_network_process):
12155 (read_process_output_error_handler, exec_sentinel_error_handler):
12156 Rename or move locals.
12157 (Fmake_network_process): Define label "retry_connect" only if needed.
12158 (Fnetwork_interface_info): Fix pointer signedness.
12159 (process_send_signal): Add cast to avoid pointer signedness problem.
12160 (FIRST_PROC_DESC, IF_NON_BLOCKING_CONNECT): Remove unused macros.
12161 (create_process): Use 'volatile' to avoid vfork clobbering (Bug#8298).
12163 Make tparam.h and terminfo.c consistent.
12164 * cm.c (tputs, tgoto, BC, UP): Remove extern decls.
12165 Include tparam.h instead, since it declares them.
12166 * cm.h (PC): Remove extern decl; tparam.h now does this.
12167 * deps.mk (cm.o, terminfo.o): Depend on tparam.h.
12168 * terminfo.c: Include tparam.h, to check interfaces.
12169 (tparm): Make 1st arg a const pointer in decl. Put it at top level.
12170 (tparam): Adjust signature to match interface in tparam.h;
12171 this removes some undefined behavior. Check that outstring and len
12172 are zero, which they always are with Emacs.
12173 * tparam.h (PC, BC, UP): New extern decls.
12175 * xftfont.c (xftfont_shape): Now static, and defined only if needed.
12176 (xftfont_open): Rename locals to avoid shadowing.
12178 * ftfont.c (ftfont_resolve_generic_family): Fix pointer signedness.
12179 (ftfont_otf_capability, ftfont_shape): Omit decls if not needed.
12180 (OTF_TAG_SYM): Omit macro if not needed.
12181 (ftfont_list): Remove unused local.
12182 (get_adstyle_property, ftfont_pattern_entity):
12183 (ftfont_lookup_cache, ftfont_open, ftfont_anchor_point):
12184 Rename locals to avoid shadowing.
12186 * xfont.c (xfont_list_family): Mark var as initialized.
12188 * xml.c (make_dom): Now static.
12190 * composite.c (composition_compute_stop_pos): Rename local to
12192 (composition_reseat_it): Remove unused locals.
12193 (find_automatic_composition, composition_adjust_point): Likewise.
12194 (composition_update_it): Mark var as initialized.
12195 (find_automatic_composition): Mark vars as initialized,
12196 with a FIXME (Bug#8290).
12198 character.h: Rename locals to avoid shadowing.
12199 * character.h (PREV_CHAR_BOUNDARY, FETCH_STRING_CHAR_ADVANCE):
12200 (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE, FETCH_CHAR_ADVANCE):
12201 (FETCH_CHAR_ADVANCE_NO_CHECK, INC_POS, DEC_POS, BUF_INC_POS):
12202 (BUF_DEC_POS): Be more systematic about renaming local temporaries
12203 to avoid shadowing.
12205 * textprop.c (property_change_between_p): Remove; unused.
12207 * intervals.c (interval_start_pos): Now static.
12209 * intervals.h (CHECK_TOTAL_LENGTH): Avoid empty "else".
12211 * atimer.c (start_atimer, append_atimer_lists, set_alarm):
12212 Rename locals to avoid shadowing.
12214 * sound.c (wav_play, au_play, Fplay_sound_internal):
12215 Fix pointer signedness.
12216 (alsa_choose_format): Remove unused local var.
12217 (wav_play): Initialize a variable to 0, to prevent undefined
12218 behavior (Bug#8278).
12220 * region-cache.c (insert_cache_boundary): Redo var to avoid shadowing.
12222 * region-cache.h (pp_cache): New decl, for gcc -Wmissing-prototypes.
12224 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork
12225 clobbering (Bug#8298).
12226 * sysdep.c (sys_subshell): Likewise.
12227 Previously, the sys_subshell 'volatile' was incorrectly IF_LINTted out.
12229 * lisp.h (child_setup): Now NO_RETURN unless DOS_NT.
12230 This should get cleaned up, so that child_setup has the
12231 same signature on all platforms.
12233 * callproc.c (call_process_cleanup): Now static.
12234 (relocate_fd): Rename locals to avoid shadowing.
12236 2011-03-22 Chong Yidong <cyd@stupidchicken.com>
12238 * xterm.c (x_clear_frame): Remove XClearWindow call. This appears
12239 not to be necessary, and produces flickering.
12241 2011-03-20 Glenn Morris <rgm@gnu.org>
12243 * config.in: Remove file.
12245 2011-03-20 Juanma Barranquero <lekktu@gmail.com>
12247 * minibuf.c (Vcompleting_read_function): Don't declare, global variables
12248 are now in src/globals.h.
12249 (syms_of_minibuf): Remove spurious & from previous change.
12251 2011-03-20 Leo Liu <sdl.web@gmail.com>
12253 * minibuf.c (completing-read-function): New variable.
12254 (completing-read-default): Rename from completing-read.
12255 (completing-read): Call completing-read-function.
12257 2011-03-19 Juanma Barranquero <lekktu@gmail.com>
12259 * xfaces.c (Fx_load_color_file):
12260 Read color file from absolute filename (bug#8250).
12262 2011-03-19 Juanma Barranquero <lekktu@gmail.com>
12264 * makefile.w32-in: Update dependencies.
12266 2011-03-17 Eli Zaretskii <eliz@gnu.org>
12268 * makefile.w32-in ($(BLD)/unexw32.$(O)): Depend on $(SRC)/unexec.h.
12270 2011-03-17 Paul Eggert <eggert@cs.ucla.edu>
12272 Fix more problems found by GCC 4.5.2's static checks.
12274 * process.c (make_serial_process_unwind, send_process_trap):
12275 (sigchld_handler): Now static.
12277 * process.c (allocate_pty): Let PTY_ITERATION declare iteration vars.
12278 That way, the code declares only the vars that it needs.
12279 * s/aix4-2.h (PTY_ITERATION): Declare iteration vars.
12280 * s/cygwin.h (PTY_ITERATION): Likewise.
12281 * s/darwin.h (PTY_ITERATION): Likewise.
12282 * s/gnu-linux.h (PTY_ITERATION): Likewise.
12284 * s/irix6-5.h (PTY_OPEN): Declare stb, to loosen coupling.
12285 * process.c (allocate_pty): Don't declare stb unless it's needed.
12287 * bytecode.c (MAYBE_GC): Rewrite so as not to use empty "else".
12288 (CONSTANTLIM): Remove; unused.
12289 (METER_CODE, Bscan_buffer, Bread_char, Bset_mark):
12290 Define only if needed.
12292 * unexelf.c (unexec): Name an expression,
12293 to avoid gcc -Wbad-function-cast warning.
12294 Use a different way to cause a compilation error if anyone uses
12295 n rather than nn, a way that does not involve shadowing.
12296 (ELF_BSS_SECTION_NAME, OLD_PROGRAM_H): Remove; unused.
12298 * deps.mk (unexalpha.o): Remove; unused.
12300 New file unexec.h, the (simple) interface for unexec (Bug#8267).
12301 * unexec.h: New file.
12302 * deps.mk (emacs.o, unexaix.o, unexcw.o, unexcoff.o, unexelf.o):
12303 (unexhp9k800.o, unexmacosx.o, unexsol.o, unexw32.o):
12304 Depend on unexec.h.
12305 * emacs.c [!defined CANNOT_DUMP]: Include unexec.h.
12306 * unexaix.c, unexcoff.c, unexcw.c, unexelf.c, unexhp9k800.c:
12307 * unexmacosx.c, unexsol.c, unexw32.c: Include unexec.h.
12308 Change as necessary to match prototype in unexec.h.
12310 * syntax.c (Fforward_comment, scan_lists): Rename locals to avoid
12312 (back_comment, skip_chars): Mark vars as initialized.
12314 * character.h (FETCH_STRING_CHAR_ADVANCE_NO_CHECK, BUF_INC_POS):
12315 Rename locals to avoid shadowing.
12317 * lread.c (read1): Rewrite so as not to use empty "else".
12318 (Fload, readevalloop, read1): Rename locals to avoid shadowing.
12320 * print.c (Fredirect_debugging_output): Fix pointer signedess.
12322 * lisp.h (debug_output_compilation_hack): Add decl here, to avoid
12323 warning when compiling print.c.
12325 * font.c (font_unparse_fcname): Abort in an "impossible" situation
12326 instead of using an uninitialized var.
12327 (font_sort_entities): Mark var as initialized.
12329 * character.h (FETCH_CHAR_ADVANCE): Rename locals to avoid shadowing.
12331 * font.c (font_unparse_xlfd): Don't mix pointers to variables with
12332 pointers to constants.
12333 (font_parse_fcname): Remove unused vars.
12334 (font_delete_unmatched): Now static.
12335 (font_get_spec): Remove; unused.
12336 (font_style_to_value, font_prop_validate_style, font_unparse_fcname):
12337 (font_update_drivers, Ffont_get_glyphs, font_add_log):
12338 Rename or move locals to avoid shadowing.
12340 * fns.c (require_nesting_list, require_unwind): Now static.
12341 (Ffillarray): Rename locals to avoid shadowing.
12343 * floatfns.c (domain_error2): Define only if needed.
12344 (Ffrexp, Fldexp): Rename locals to avoid shadowing.
12346 * alloc.c (mark_backtrace): Move decl from here ...
12347 * lisp.h: ... to here, so that it can be checked.
12349 * eval.c (call_debugger, do_debug_on_call, grow_specpdl): Now static.
12350 (Fdefvar): Rewrite so as not to use empty "else".
12351 (lisp_indirect_variable): Name an expression,
12352 to avoid gcc -Wbad-function-cast warning.
12353 (Fdefvar): Rename locals to avoid shadowing.
12355 * callint.c (quotify_arg, quotify_args): Now static.
12356 (Fcall_interactively): Rename locals to avoid shadowing.
12357 Use const pointer when appropriate.
12359 * lisp.h (get_system_name, get_operating_system_release):
12360 Move decls here, to check interfaces.
12361 * process.c (get_operating_system_release): Move decl to lisp.h.
12362 * xrdb.c (get_system_name): Likewise.
12363 * editfns.c (init_editfns, Fuser_login_name, Fuser_uid):
12364 (Fuser_real_uid, Fuser_full_name): Remove unnecessary casts,
12365 some of which prompt warnings from gcc -Wbad-function-cast.
12366 (Fformat_time_string, Fencode_time, Finsert_char):
12367 (Ftranslate_region_internal, Fformat):
12368 Rename or remove local vars to avoid shadowing.
12369 (Ftranslate_region_internal): Mark var as initialized.
12371 * doc.c (Fdocumentation, Fsnarf_documentation): Move locals to
12374 * lisp.h (eassert): Check that the argument compiles, even if
12375 ENABLE_CHECKING is not defined.
12377 * data.c (Findirect_variable): Name an expression, to avoid
12378 gcc -Wbad-function-cast warning.
12379 (default_value, arithcompare, arith_driver, arith_error): Now static.
12380 (store_symval_forwarding): Rename local to avoid shadowing.
12381 (Fmake_variable_buffer_local, Fmake_local_variable):
12382 Mark variables as initialized.
12383 (do_blv_forwarding, do_symval_forwarding): Remove; unused.
12385 * alloc.c (check_cons_list): Do not define unless GC_CHECK_CONS_LIST.
12386 (Fmake_vector, Fvector, Fmake_byte_code, Fgarbage_collect):
12387 Rename locals to avoid shadowing.
12388 (mark_stack): Move local variables into the #ifdef region where
12390 (BLOCK_INPUT_ALLOC, UNBLOCK_INPUT_ALLOC): Define only if
12391 ! defined SYSTEM_MALLOC && ! defined SYNC_INPUT, as they are not
12393 (CHECK_ALLOCATED): Define only if GC_CHECK_MARKED_OBJECTS.
12394 (GC_STRING_CHARS): Remove; not used.
12395 (Fmemory_limit): Cast sbrk's returned value to char *.
12397 * lisp.h (check_cons_list): Declare if GC_CHECK_CONS_LIST; this
12398 avoids undefined behavior in theory.
12400 * regex.c (IF_LINT): Add defn, for benefit of ../lib-src.
12402 Use functions, not macros, for up- and down-casing (Bug#8254).
12403 * buffer.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
12404 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Remove. All callers changed
12405 to use the following functions instead of these macros.
12406 (downcase): Adjust to lack of DOWNCASE_TABLE. Return int, not
12407 EMACS_INT, since callers assume the returned value fits in int.
12408 (upcase1): Likewise, for UPCASE_TABLE.
12409 (uppercasep, lowercasep, upcase): New static inline functions.
12410 * editfns.c (Fchar_equal): Remove no-longer-needed workaround for
12411 the race-condition problem in the old DOWNCASE.
12413 * regex.c (CHARSET_LOOKUP_RANGE_TABLE_RAW, POP_FAILURE_REG_OR_COUNT):
12414 Rename locals to avoid shadowing.
12415 (regex_compile, re_match_2_internal): Move locals to avoid shadowing.
12416 (regex_compile, re_search_2, re_match_2_internal):
12417 Remove unused local vars.
12418 (FREE_VAR): Rewrite so as not to use empty "else",
12419 which gcc can warn about.
12420 (regex_compile, re_match_2_internal): Mark locals as initialized.
12421 (RETALLOC_IF): Define only if needed.
12422 (WORDCHAR_P): Likewise. This one is never needed, but is used
12423 only in a comment talking about a compiler bug, so put inside
12424 the #if 0 of that comment.
12425 (CHARSET_LOOKUP_BITMAP, FAIL_STACK_FULL, RESET_FAIL_STACK):
12426 (PUSH_FAILURE_ELT, BUF_PUSH_3, STOP_ADDR_VSTRING):
12429 * search.c (boyer_moore): Rename locals to avoid shadowing.
12430 * character.h (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE):
12431 (PREV_CHAR_BOUNDARY): Likewise.
12433 * search.c (simple_search): Remove unused var.
12435 * dired.c (compile_pattern): Move decl from here ...
12436 * lisp.h: ... to here, so that it can be checked.
12437 (struct re_registers): New forward decl.
12439 * character.h (INC_POS, DEC_POS): Rename locals to avoid shadowing.
12441 * indent.c (MULTIBYTE_BYTES_WIDTH): New args bytes, width.
12443 (MULTIBYTE_BYTES_WIDTH, scan_for_column, compute_motion):
12444 Rename locals to avoid shadowing.
12445 (Fvertical_motion): Mark locals as initialized.
12447 * casefiddle.c (casify_object, casify_region): Now static.
12448 (casify_region): Mark local as initialized.
12450 * cmds.c (internal_self_insert): Rename local to avoid shadowing.
12452 * lisp.h (GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR, GCPRO5_VAR, GCPRO6_VAR):
12453 New macros, so that the caller can use some names other than
12454 gcpro1, gcpro2, etc.
12455 (GCPRO2, GCPRO3, GCPRO4, GCPRO5, GCPRO6): Reimplement in terms
12457 (GCPRO1_VAR, UNGCPRO_VAR): Change the meaning of the second
12458 argument, for consistency with GCPRO2_VAR, etc: it is now the
12459 prefix of the variable, not the variable itself. All uses
12461 * dired.c (directory_files_internal, file_name_completion):
12462 Rename locals to avoid shadowing.
12464 Fix a race condition diagnosed by gcc -Wsequence-point (Bug#8254).
12465 An expression of the form (DOWNCASE (x) == DOWNCASE (y)), found in
12466 dired.c's scmp function, had undefined behavior.
12467 * lisp.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
12468 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Move from here ...
12469 * buffer.h: ... to here, because these macros use current_buffer,
12470 and the new implementation with inline functions needs to have
12471 current_buffer in scope now, rather than later when the macros
12473 (downcase, upcase1): New static inline functions.
12474 (DOWNCASE, UPCASE1): Reimplement using these functions.
12475 This avoids undefined behavior in expressions like
12476 DOWNCASE (x) == DOWNCASE (y), which previously suffered
12477 from race conditions in accessing the global variables
12478 case_temp1 and case_temp2.
12479 * casetab.c (case_temp1, case_temp2): Remove; no longer needed.
12480 * lisp.h (case_temp1, case_temp2): Remove their decls.
12481 * character.h (ASCII_CHAR_P): Move from here ...
12482 * lisp.h: ... to here, so that the inline functions mentioned
12483 above can use them.
12485 * dired.c (directory_files_internal_unwind): Now static.
12487 * fileio.c (file_name_as_directory, directory_file_name):
12488 (barf_or_query_if_file_exists, auto_save_error, auto_save_1):
12490 (file_name_as_directory): Use const pointers when appropriate.
12491 (Fexpand_file_name): Likewise. In particular, newdir might
12492 point at constant storage, so make it a const pointer.
12493 (Fmake_directory_internal, Fread_file_name): Remove unused vars.
12494 (Ffile_selinux_context, Fset_file_selinux_context): Fix pointer
12496 (Fset_file_times, Finsert_file_contents, auto_save_error):
12497 Rename locals to avoid shadowing.
12499 * minibuf.c (choose_minibuf_frame_1): Now static.
12500 (Ftry_completion, Fall_completions): Rename or remove locals
12501 to avoid shadowing.
12503 * marker.c (bytepos_to_charpos): Remove; unused.
12505 * lisp.h (verify_bytepos, count_markers): New decls,
12506 so that gcc does not warn that these functions aren't declared.
12508 * insdel.c (check_markers, make_gap_larger, make_gap_smaller):
12509 (reset_var_on_error, Fcombine_after_change_execute_1): Now static.
12510 (CHECK_MARKERS): Redo to avoid gcc -Wempty-body diagnostic.
12511 (copy_text): Remove unused local var.
12513 * filelock.c (within_one_second): Now static.
12514 (lock_file_1): Rename local to avoid shadowing.
12516 * buffer.c (fix_overlays_before): Mark locals as initialized.
12517 (fix_start_end_in_overlays): Likewise. This function should be
12518 simplified by using pointers-to-pointers, but that's a different
12520 (switch_to_buffer_1): Now static.
12521 (Fkill_buffer, record_buffer, Fbury_buffer, Fset_buffer_multibyte):
12522 (report_overlay_modification): Rename locals to avoid shadowing.
12524 * sysdep.c (system_process_attributes): Rename vars to avoid shadowing.
12525 Fix pointer signedness issue.
12526 (sys_subshell): Mark local as volatile if checking for lint,
12527 to suppress a gcc -Wclobbered warning that does not seem to be right.
12528 (MAXPATHLEN): Define only if needed.
12530 * process.c (serial_open, serial_configure): Move decls from here ...
12531 * systty.h: ... to here, so that they can be checked.
12533 * fns.c (get_random, seed_random): Move extern decls from here ...
12534 * lisp.h: ... to here, so that they can be checked.
12536 * sysdep.c (reset_io): Now static.
12537 (wait_for_termination_signal): Remove; unused.
12539 * keymap.c (keymap_parent, keymap_memberp, map_keymap_internal):
12540 (copy_keymap_item, append_key, push_text_char_description):
12542 (Fwhere_is_internal): Don't test CONSP (sequences) unnecessarily.
12543 (DENSE_TABLE_SIZE): Remove; unused.
12544 (get_keymap, access_keymap, Fdefine_key, Fwhere_is_internal):
12545 (describe_map_tree):
12546 Rename locals to avoid shadowing.
12548 * keyboard.c: Declare functions static if they are not used elsewhere.
12549 (echo_char, echo_dash, cmd_error, top_level_2):
12550 (poll_for_input, handle_async_input): Now static.
12551 (read_char, kbd_buffer_get_event, make_lispy_position):
12552 (make_lispy_event, make_lispy_movement, apply_modifiers):
12553 (decode_keyboard_code, tty_read_avail_input, menu_bar_items):
12554 (parse_tool_bar_item, read_key_sequence, Fread_key_sequence):
12555 (Fread_key_sequence_vector): Rename locals to avoid shadowing.
12556 (read_key_sequence, read_char): Mark locals as initialized.
12557 (Fexit_recursive_edit, Fabort_recursive_edit): Mark with NO_RETURN.
12559 * keyboard.h (make_ctrl_char): New decl.
12560 (mark_kboards): Move decl here ...
12561 * alloc.c (mark_kboards): ... from here.
12563 * lisp.h (force_auto_save_soon): New decl.
12565 * emacs.c (init_cmdargs): Rename local to avoid shadowing.
12566 (DEFINE_DUMMY_FUNCTION): New macro.
12567 (__do_global_ctors, __do_global_ctors_aux, __do_global_dtors, __main):
12569 (main): Add casts to avoid warnings
12570 if GCC considers string literals to be constants.
12572 * lisp.h (fatal_error_signal): Add decl, since it's exported.
12574 * dbusbind.c: Pointer signedness fixes.
12575 (xd_signature, xd_append_arg, xd_initialize):
12576 (Fdbus_call_method, Fdbus_call_method_asynchronously):
12577 (Fdbus_method_return_internal, Fdbus_method_error_internal):
12578 (Fdbus_send_signal, xd_read_message_1, Fdbus_register_service):
12579 (Fdbus_register_signal): Use SSDATA when the context wants char *.
12581 * dbusbind.c (Fdbus_init_bus): Add cast to avoid warning
12582 if GCC considers string literals to be constants.
12583 (Fdbus_register_service, Fdbus_register_method): Remove unused vars.
12585 2011-03-16 Stefan Monnier <monnier@iro.umontreal.ca>
12587 * print.c (PRINT_CIRCLE_CANDIDATE_P): New macro.
12588 (print_preprocess, print_object): New macro to fix last change.
12590 * print.c (print_preprocess): Don't forget font objects.
12592 2011-03-16 Juanma Barranquero <lekktu@gmail.com>
12594 * emacs.c (USAGE3): Doc fixes.
12596 2011-03-15 Andreas Schwab <schwab@linux-m68k.org>
12598 * coding.c (detect_coding_iso_2022): Reorganize code to clarify
12601 2011-03-14 Juanma Barranquero <lekktu@gmail.com>
12603 * lisp.h (VWindow_system, Qfile_name_history):
12604 * keyboard.h (lispy_function_keys) [WINDOWSNT]:
12605 * w32term.h (w32_system_caret_hwnd, w32_system_caret_height)
12606 (w32_system_caret_x, w32_system_caret_y): Declare extern.
12608 * w32select.c: Don't #include "keyboard.h".
12609 (run_protected): Add extern declaration for waiting_for_input.
12611 * w32.c (Qlocal, noninteractive1, inhibit_window_system):
12612 * w32console.c (detect_input_pending, read_input_pending)
12613 (encode_terminal_code):
12614 * w32fns.c (quit_char, lispy_function_keys, Qtooltip)
12615 (w32_system_caret_hwnd, w32_system_caret_height, w32_system_caret_x)
12616 (w32_system_caret_y, Qfile_name_history):
12617 * w32font.c (w32font_driver, QCantialias, QCotf, QClang):
12618 * w32inevt.c (reinvoke_input_signal, lispy_function_keys):
12619 * w32menu.c (Qmenu_bar, QCtoggle, QCradio, Qoverriding_local_map)
12620 (Qoverriding_terminal_local_map, Qmenu_bar_update_hook):
12621 * w32proc.c (Qlocal, report_file_error):
12622 * w32term.c (Vwindow_system, updating_frame):
12623 * w32uniscribe.c (initialized, uniscribe_font_driver):
12624 Remove unneeded extern declarations.
12626 2011-03-14 Chong Yidong <cyd@stupidchicken.com>
12628 * buffer.c (Fmake_indirect_buffer): Fix incorrect assertions.
12630 2011-03-13 Chong Yidong <cyd@stupidchicken.com>
12632 * buffer.h (BUF_BEGV, BUF_BEGV_BYTE, BUF_ZV, BUF_ZV_BYTE, BUF_PT)
12633 (BUF_PT_BYTE): Rewrite to handle indirect buffers (Bug#8219).
12634 These macros can no longer be used for assignment.
12636 * buffer.c (Fget_buffer_create, Fmake_indirect_buffer):
12637 Assign struct members directly, instead of using BUF_BEGV etc.
12638 (record_buffer_markers, fetch_buffer_markers): New functions for
12639 recording and fetching special buffer markers.
12640 (set_buffer_internal_1, set_buffer_temp): Use them.
12642 * lread.c (unreadchar): Use SET_BUF_PT_BOTH.
12644 * insdel.c (adjust_point): Use SET_BUF_PT_BOTH.
12646 * intervals.c (temp_set_point_both): Use SET_BUF_PT_BOTH.
12647 (get_local_map): Use SET_BUF_BEGV_BOTH and SET_BUF_ZV_BOTH.
12649 * xdisp.c (hscroll_window_tree):
12650 (reconsider_clip_changes): Use PT instead of BUF_PT.
12652 2011-03-13 Eli Zaretskii <eliz@gnu.org>
12654 * makefile.w32-in ($(BLD)/editfns.$(O)): Depend on
12655 $(EMACS_ROOT)/lib/intprops.h.
12657 2011-03-13 Paul Eggert <eggert@cs.ucla.edu>
12659 Fix more problems found by GCC 4.5.2's static checks.
12661 * gtkutil.c (xg_get_pixbuf_from_pixmap): Add cast from char *
12662 to unsigned char * to avoid compiler diagnostic.
12663 (xg_free_frame_widgets): Make it clear that a local variable is
12664 needed only if USE_GTK_TOOLTIP.
12665 (gdk_window_get_screen): Make it clear that this macro is needed
12666 only if USE_GTK_TOOLTIP.
12667 (int_gtk_range_get_value): New function, which avoids a diagnostic
12668 from gcc -Wbad-function-cast.
12669 (xg_set_toolkit_scroll_bar_thumb): Use it.
12670 (xg_tool_bar_callback, xg_tool_item_stale_p): Rewrite to avoid
12671 diagnostic from gcc -Wbad-function-cast.
12672 (get_utf8_string, xg_get_file_with_chooser):
12673 Rename locals to avoid shadowing.
12674 (create_dialog): Move locals to avoid shadowing.
12676 * xgselect.c (xg_select): Remove unused var.
12678 * image.c (four_corners_best): Mark locals as initialized.
12679 (gif_load): Initialize transparent_p to zero (Bug#8238).
12680 Mark another local as initialized.
12681 (my_png_error, my_error_exit): Mark with NO_RETURN.
12683 * image.c (clear_image_cache): Now static.
12684 (DIM, HAVE_STDLIB_H_1): Remove unused macros.
12685 (xpm_load): Redo to avoid "discards qualifiers" gcc warning.
12686 (x_edge_detection): Remove unnecessary cast that
12687 gcc -Wbad-function-cast diagnoses.
12688 (gif_load): Fix pointer signedness.
12689 (clear_image_cache, xbm_read_bitmap_data, x_detect_edges):
12690 (jpeg_load, gif_load): Rename locals to avoid shadowing.
12692 2011-03-12 Paul Eggert <eggert@cs.ucla.edu>
12694 Improve quality of tests for time stamp overflow.
12695 For example, without this patch (encode-time 0 0 0 1 1
12696 1152921504606846976) returns the obviously-bogus value (-948597
12697 62170) on my RHEL 5.5 x86-64 host. With the patch, it correctly
12698 reports time overflow. See
12699 <http://lists.gnu.org/archive/html/emacs-devel/2011-03/msg00470.html>.
12700 * deps.mk (editfns.o): Depend on ../lib/intprops.h.
12701 * editfns.c: Include limits.h and intprops.h.
12702 (TIME_T_MIN, TIME_T_MAX): New macros.
12703 (time_overflow): Move earlier, to before first use.
12704 (hi_time, lo_time): New functions, for an accurate test for
12705 out-of-range times.
12706 (Fcurrent_time, Fget_internal_run_time, make_time): Use them.
12707 (Fget_internal_run_time): Don't assume time_t fits in int.
12708 (make_time): Use list2 instead of Fcons twice.
12709 (Fdecode_time): More accurate test for out-of-range times.
12710 (check_tm_member): New function.
12711 (Fencode_time): Use it, to test for out-of-range times.
12712 (lisp_time_argument): Don't rely on undefined left-shift and
12713 right-shift behavior when checking for time stamp overflow.
12715 * editfns.c (time_overflow): New function, refactoring common code.
12716 (Fformat_time_string, Fdecode_time, Fencode_time):
12717 (Fcurrent_time_string): Use it.
12719 Move 'make_time' to be next to its inverse 'lisp_time_argument'.
12720 * dired.c (make_time): Move to ...
12721 * editfns.c (make_time): ... here.
12722 * systime.h: Note the move.
12724 2011-03-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
12726 * fringe.c (update_window_fringes): Remove unused variables.
12728 * unexmacosx.c (copy_data_segment): Also copy __got section.
12731 2011-03-12 Eli Zaretskii <eliz@gnu.org>
12733 * termcap.c [MSDOS]: Include "msdos.h".
12734 (find_capability, tgetnum, tgetflag, tgetstr, tputs, tgetent):
12735 Constify `char *' arguments and their references according to
12736 prototypes in tparam.h.
12738 * deps.mk (termcap.o): Depend on tparam.h and msdos.h.
12740 * msdos.c (XMenuAddPane): 3rd argument is `const char *' now.
12741 Adapt all references accordingly.
12743 * msdos.h (XMenuAddPane): 3rd argument is `const char *' now.
12745 2011-03-11 Tom Tromey <tromey@redhat.com>
12747 * buffer.c (syms_of_buffer): Remove obsolete comment.
12749 2011-03-11 Eli Zaretskii <eliz@gnu.org>
12751 * termhooks.h (encode_terminal_code): Declare prototype.
12753 * msdos.c (encode_terminal_code): Don't declare prototype.
12755 * term.c (encode_terminal_code): Now external again, used by
12756 w32console.c and msdos.c.
12758 * makefile.w32-in ($(BLD)/term.$(O), ($(BLD)/tparam.$(O)):
12759 Depend on $(SRC)/tparam.h, see 2011-03-11T07:24:21Z!eggert@cs.ucla.edu.
12761 2011-03-11 Paul Eggert <eggert@cs.ucla.edu>
12763 Fix some minor problems found by GCC 4.5.2's static checks.
12765 * fringe.c (update_window_fringes): Mark locals as initialized
12767 (destroy_fringe_bitmap, init_fringe_bitmap): Now static.
12769 * alloc.c (mark_fringe_data): Move decl from here ...
12770 * lisp.h (mark_fringe_data) [HAVE_WINDOW_SYSTEM]: ... to here,
12771 to check its interface.
12772 (init_fringe_once): Do not declare unless HAVE_WINDOW_SYSTEM.
12774 * fontset.c (free_realized_fontset): Now static.
12775 (Fset_fontset_font): Rename local to avoid shadowing.
12776 (fontset_font): Mark local as initialized.
12777 (FONTSET_SPEC, FONTSET_REPERTORY, RFONT_DEF_REPERTORY): Remove; unused.
12779 * xrdb.c: Include "xterm.h", to check x_load_resources's interface.
12781 * xselect.c (x_disown_buffer_selections): Remove; not used.
12782 (TRACE3) [!defined TRACE_SELECTION]: Remove; not used.
12783 (x_own_selection, Fx_disown_selection_internal): Rename locals
12784 to avoid shadowing.
12785 (x_handle_dnd_message): Remove local to avoid shadowing.
12787 * lisp.h (GCPRO1_VAR, UNGCPRO_VAR): New macros,
12788 so that the caller can use some name other than gcpro1.
12789 (GCPRO1, UNGCPRO): Reimplement in terms of the new macros.
12790 * xfns.c (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
12791 (Fx_backspace_delete_keys_p):
12792 Use them to avoid shadowing, and rename vars to avoid shadowing.
12793 (x_decode_color, x_set_name, x_window): Now static.
12794 (Fx_create_frame): Add braces to silence GCC warning.
12795 (Fx_file_dialog, Fx_select_font): Fix pointer signedness.
12796 (x_real_positions, xg_set_icon_from_xpm_data, x_create_tip_frame):
12797 Remove unused locals.
12798 (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
12799 (Fx_backspace_delete_keys_p): Rename locals to avoid shadowing.
12800 Some of these renamings use the new GCPRO1_VAR and UNGCPRO_VAR
12803 * xterm.h (x_mouse_leave): New decl.
12805 * xterm.c (x_copy_dpy_color, x_focus_on_frame, x_unfocus_frame):
12806 Remove unused functions.
12807 (x_shift_glyphs_for_insert, XTflash, XTring_bell):
12808 (x_calc_absolute_position): Now static.
12809 (XTread_socket): Don't define label "out" unless it's used.
12810 Don't declare local "event" unless it's used.
12811 (x_iconify_frame, x_free_frame_resources): Don't declare locals
12812 unless they are used.
12813 (XEMBED_VERSION, xembed_set_info): Don't define unless needed.
12814 (x_fatal_error_signal): Remove; not used.
12815 (x_draw_image_foreground, redo_mouse_highlight, XTmouse_position):
12816 (x_scroll_bar_report_motion, handle_one_xevent, x_draw_bar_cursor):
12817 (x_error_catcher, x_connection_closed, x_error_handler):
12818 (x_error_quitter, xembed_send_message, x_iconify_frame):
12819 (my_log_handler): Rename locals to avoid shadowing.
12820 (x_delete_glyphs, x_ins_del_lines): Mark with NO_RETURN.
12821 (x_connection_closed): Tell GCC not to suggest NO_RETURN.
12823 * xfaces.c (clear_face_cache, Fx_list_fonts, Fface_font):
12824 Rename or move locals to avoid shadowing.
12825 (tty_defined_color, merge_face_heights): Now static.
12826 (free_realized_faces_for_fontset): Remove; not used.
12827 (Fx_list_fonts): Mark variable that gcc -Wuninitialized
12828 does not deduce is never used uninitialized.
12829 (STRDUPA, LSTRDUPA, FONT_POINT_SIZE_QUANTUM): Remove; not used.
12830 (LFACEP): Define only if XASSERTS, as it's not needed otherwise.
12832 * terminal.c (store_terminal_param): Now static.
12834 * xmenu.c (menu_highlight_callback): Now static.
12835 (set_frame_menubar): Remove unused local.
12836 (xmenu_show): Rename parameter to avoid shadowing.
12837 (xmenu_show, xdialog_show, xmenu_show): Make local pointers "const"
12838 since they might point to immutable storage.
12839 (next_menubar_widget_id): Declare only if USE_X_TOOLKIT,
12840 since it's unused otherwise.
12842 * xdisp.c (produce_glyphless_glyph): Initialize lower_xoff.
12843 Add a FIXME, since the code still doesn't look right. (Bug#8215)
12844 (Fcurrent_bidi_paragraph_direction): Simplify slightly; this
12845 avoids a gcc -Wuninitialized diagnostic.
12846 (display_line, BUILD_COMPOSITE_GLYPH_STRING, draw_glyphs):
12847 (note_mouse_highlight): Mark variables that gcc -Wuninitialized
12848 does not deduce are never used uninitialized.
12850 * lisp.h (IF_LINT): New macro, copied from ../lib-src/emacsclient.c.
12852 * xdisp.c (redisplay_window): Rename local to avoid shadowing.
12853 * window.c (window_loop, size_window):
12854 (run_window_configuration_change_hook, enlarge_window): Likewise.
12856 * window.c (display_buffer): Now static.
12857 (size_window): Mark variables that gcc -Wuninitialized
12858 does not deduce are never used uninitialized.
12859 * window.h (check_all_windows): New decl, to forestall
12860 gcc -Wmissing-prototypes diagnostic.
12861 * dispextern.h (bidi_dump_cached_states): Likewise.
12863 * charset.h (CHECK_CHARSET_GET_CHARSET): Rename locals to avoid
12865 * charset.c (map_charset_for_dump, Fchar_charset): Likewise.
12866 Include <limits.h>.
12867 (Fsort_charsets): Redo min/max calculation to shorten the code a bit
12868 and to avoid gcc -Wuninitialized warning.
12869 (load_charset_map): Mark variables that gcc -Wuninitialized
12870 does not deduce are never used uninitialized.
12871 (load_charset): Abort instead of using uninitialized var (Bug#8229).
12873 * coding.c (coding_set_source, coding_set_destination):
12874 Use "else { /* comment */ }" rather than "else /* comment */;"
12875 for clarity, and to avoid gcc -Wempty-body warning.
12876 (Fdefine_coding_system_internal): Don't redeclare 'i' inside
12877 a block, when the outer 'i' will do.
12878 (decode_coding_utf_8, decode_coding_utf_16, detect_coding_emacs_mule):
12879 (emacs_mule_char, decode_coding_emacs_mule, detect_coding_iso_2022):
12880 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5):
12881 (decode_coding_raw_text, decode_coding_charset, get_translation_table):
12882 (Fdecode_sjis_char, Fdefine_coding_system_internal):
12883 Rename locals to avoid shadowing.
12884 * character.h (FETCH_STRING_CHAR_ADVANCE): Likewise.
12885 * coding.c (emacs_mule_char, encode_invocation_designation):
12886 Now static, since they're not used elsewhere.
12887 (decode_coding_iso_2022): Add "default: abort ();" as a safety check.
12888 (decode_coding_object, encode_coding_object, detect_coding_system):
12889 (decode_coding_emacs_mule): Mark variables that gcc
12890 -Wuninitialized does not deduce are never used uninitialized.
12891 (detect_coding_iso_2022): Initialize a local variable that might
12892 be used uninitialized. Leave a FIXME because it's not clear that
12893 this initialization is needed. (Bug#8211)
12894 (ISO_CODE_LF, ISO_CODE_CR, CODING_ISO_FLAG_EUC_TW_SHIFT):
12895 (ONE_MORE_BYTE_NO_CHECK, UTF_BOM, UTF_16_INVALID_P):
12896 (SHIFT_OUT_OK, ENCODE_CONTROL_SEQUENCE_INTRODUCER):
12897 (ENCODE_DIRECTION_R2L, ENCODE_DIRECTION_L2R):
12898 Remove unused macros.
12900 * category.c (hash_get_category_set): Remove unused local var.
12901 (copy_category_table): Now static, since it's not used elsewhere.
12902 * character.c (string_count_byte8): Likewise.
12904 * ccl.c (CCL_WRITE_STRING, CCL_ENCODE_CHAR, Fccl_execute_on_string):
12905 (Fregister_code_conversion_map): Rename locals to avoid shadowing.
12907 * chartab.c (copy_sub_char_table): Now static, since it's not used
12909 (sub_char_table_ref_and_range, char_table_ref_and_range):
12910 Rename locals to avoid shadowing.
12911 (ASET_RANGE, GET_SUB_CHAR_TABLE): Remove unused macros.
12913 * bidi.c (bidi_check_type): Now static, since it's not used elsewhere.
12914 (BIDI_BOB): Remove unused macro.
12916 * cm.c (cmgoto): Mark variables that gcc -Wuninitialized does not
12917 deduce are never used uninitialized.
12918 * term.c (encode_terminal_code): Likewise.
12920 * term.c (encode_terminal_code): Now static. Remove unused local.
12922 * tparam.h: New file.
12923 * term.c, tparam.h: Include it.
12924 * deps.mk (term.o, tparam.o): Depend on tparam.h.
12925 * term.c (tputs, tgetent, tgetflag, tgetnum, tparam, tgetstr):
12926 Move these decls to tparam.h, and make them agree with what
12927 is actually in tparam.c. The previous trick of using incompatible
12928 decls in different modules does not conform to the C standard.
12929 All callers of tparam changed to use tparam's actual API.
12930 * tparam.c (tparam1, tparam, tgoto):
12931 Use const pointers where appropriate.
12933 * cm.c (calccost, cmgoto): Use const pointers where appropriate.
12934 * cm.h (struct cm): Likewise.
12935 * dispextern.h (do_line_insertion_deletion_costs): Likewise.
12936 * scroll.c (ins_del_costs, do_line_insertion_deletion_costs): Likewise.
12937 * term.c (tty_ins_del_lines, calculate_costs, struct fkey_table):
12938 (term_get_fkeys_1, append_glyphless_glyph, produce_glyphless_glyph):
12939 (turn_on_face, init_tty): Likewise.
12940 * termchar.h (struct tty_display_info): Likewise.
12942 * term.c (term_mouse_position): Rename local to avoid shadowing.
12944 * alloc.c (mark_ttys): Move decl from here ...
12945 * lisp.h (mark_ttys): ... to here, so that it's checked against defn.
12947 2011-03-11 Andreas Schwab <schwab@linux-m68k.org>
12949 * .gdbinit (pwinx, xbuffer): Fix access to buffer name.
12951 2011-03-09 Juanma Barranquero <lekktu@gmail.com>
12953 * search.c (compile_pattern_1): Remove argument regp, unused since
12954 revid:rms@gnu.org-19941211082627-3x1g1wyqkjmwloig.
12955 (compile_pattern): Don't pass it.
12957 2011-03-08 Jan Djärv <jan.h.d@swipnet.se>
12959 * xterm.h (DEFAULT_GDK_DISPLAY): New define.
12960 (GDK_WINDOW_XID, gtk_widget_get_preferred_size): New defines
12962 (GTK_WIDGET_TO_X_WIN): Use GDK_WINDOW_XID.
12964 * xmenu.c (menu_position_func): Call gtk_widget_get_preferred_size.
12966 * gtkutil.c: Include gtkx.h if HAVE_GTK3. If ! HAVE_GTK3, define
12967 gdk_window_get_screen, gdk_window_get_geometry,
12968 gdk_x11_window_lookup_for_display and GDK_KEY_g.
12969 (xg_set_screen): Use DEFAULT_GDK_DISPLAY.
12970 (xg_get_pixbuf_from_pixmap): New function.
12971 (xg_get_pixbuf_from_pix_and_mask): Change parameters from GdkPixmap
12972 to Pixmap, take frame as parameter, remove GdkColormap parameter.
12973 Call xg_get_pixbuf_from_pixmap instead of
12974 gdk_pixbuf_get_from_drawable.
12975 (xg_get_image_for_pixmap): Do not make GdkPixmaps, call
12976 xg_get_pixbuf_from_pix_and_mask with Pixmap parameters instead.
12977 (xg_check_special_colors): Use GtkStyleContext and its functions
12979 (xg_prepare_tooltip, xg_hide_tooltip): Call gdk_window_get_screen.
12980 (xg_prepare_tooltip, create_dialog, menubar_map_cb)
12981 (xg_update_frame_menubar, xg_tool_bar_detach_callback)
12982 (xg_tool_bar_attach_callback, xg_update_tool_bar_sizes):
12983 Call gtk_widget_get_preferred_size.
12984 (xg_frame_resized): gdk_window_get_geometry only takes 5
12986 (xg_win_to_widget, xg_event_is_for_menubar):
12987 Call gdk_x11_window_lookup_for_display.
12988 (xg_set_widget_bg): New function.
12989 (delete_cb): New function.
12990 (xg_create_frame_widgets): Connect delete-event to delete_cb.
12991 Call xg_set_widget_bg. Only set background pixmap for ! HAVE_GTK3
12992 (xg_set_background_color): Call xg_set_widget_bg.
12993 (xg_set_frame_icon): Call xg_get_pixbuf_from_pix_and_mask.
12994 (xg_create_scroll_bar): vadj is a GtkAdjustment for HAVE_GTK3.
12995 Only call gtk_range_set_update_policy if ! HAVE_GTK3.
12996 (xg_make_tool_item): Only connect xg_tool_bar_item_expose_callback
12998 (update_frame_tool_bar): Call gtk_widget_hide.
12999 (xg_initialize): Use GDK_KEY_g.
13001 * xsmfns.c (gdk_set_sm_client_id): Define to gdk_set_sm_client_id
13003 (x_session_initialize): Call gdk_x11_set_sm_client_id.
13005 * xterm.c (XFillRectangle): Use cairo routines for HAVE_GTK3.
13006 (x_term_init): Disable Xinput(2) with GDK_CORE_DEVICE_EVENTS.
13007 Load ~/emacs.d/gtkrc only for ! HAVE_GTK3.
13009 2011-03-08 Juanma Barranquero <lekktu@gmail.com>
13011 * w32xfns.c (select_palette): Check success of RealizePalette against
13012 GDI_ERROR, not zero.
13014 See ChangeLog.11 for earlier changes.
13016 ;; Local Variables:
13020 Copyright (C) 2011-2012 Free Software Foundation, Inc.
13022 This file is part of GNU Emacs.
13024 GNU Emacs is free software: you can redistribute it and/or modify
13025 it under the terms of the GNU General Public License as published by
13026 the Free Software Foundation, either version 3 of the License, or
13027 (at your option) any later version.
13029 GNU Emacs is distributed in the hope that it will be useful,
13030 but WITHOUT ANY WARRANTY; without even the implied warranty of
13031 MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
13032 GNU General Public License for more details.
13034 You should have received a copy of the GNU General Public License
13035 along with GNU Emacs. If not, see <http://www.gnu.org/licenses/>.