1 2011-04-06 Paul Eggert <eggert@cs.ucla.edu>
3 * xterm.c (x_catch_errors): Remove duplicate declaration.
5 * term.c (maybe_fatal): Mark its 3rd arg as a printf format, too.
7 * xdisp.c, lisp.h (message_nolog): Remove; unused.
9 2011-04-06 Eli Zaretskii <eliz@gnu.org>
11 * msdos.c (careadlinkat, careadlinkatcwd): MS-DOS replacements.
13 * w32.c (careadlinkat, careadlinkatcwd): New always-fail stubs.
15 2011-04-06 Paul Eggert <eggert@cs.ucla.edu>
17 Fix more problems found by GCC 4.6.0's static checks.
19 * xmenu.c (Fx_popup_dialog): Don't assume string is free of formats.
21 * menu.c (Fx_popup_menu): Don't assume error_name lacks printf formats.
23 * lisp.h (message, message_nolog, fatal): Mark as printf-like.
25 * xdisp.c (vmessage): Mark as a printf-like function.
27 * term.c (vfatal, maybe_fatal): Mark as printf-like functions.
29 * sound.c (sound_warning): Don't crash if arg contains a printf format.
31 * image.c (tiff_error_handler, tiff_warning_handler): Mark as
32 printf-like functions.
33 (tiff_load): Add casts to remove these marks before passing them
34 to system-supplied API.
36 * eval.c (Fsignal): Remove excess argument to 'fatal'.
38 * coding.c (EMIT_ONE_BYTE, EMIT_TWO_BYTES): Use unsigned, not int.
39 This avoids several warnings with gcc -Wstrict-overflow.
40 (DECODE_COMPOSITION_RULE): If the rule is invalid, goto invalid_code
41 directly, rather than having caller test rule sign. This avoids
42 some unnecessary tests.
43 * composite.h (COMPOSITION_ENCODE_RULE_VALID): New macro.
44 (COMPOSITION_ENCODE_RULE): Arguments now must be valid. This
45 affects only one use, in DECODE_COMPOSITION_RULE, which is changed.
47 * xfont.c (xfont_text_extents): Remove var that was set but not used.
48 (xfont_open): Avoid unnecessary tests.
50 * composite.c (composition_gstring_put_cache): Use unsigned integer.
52 * composite.h, composite.c (composition_gstring_put_cache):
53 Use EMACS_INT, not int, for length.
55 * composite.h (COMPOSITION_DECODE_REFS): New macro,
56 breaking out part of COMPOSITION_DECODE_RULE.
57 (COMPOSITION_DECODE_RULE): Use it.
58 * composite.c (get_composition_id): Remove unused local vars,
59 by using the new macro.
61 * textprop.c (set_text_properties_1): Change while to do-while,
62 since the condition is always true at first.
64 * intervals.c (graft_intervals_into_buffer): Mark var as used.
65 (interval_deletion_adjustment): Return unsigned value.
68 * process.c (list_processes_1, create_pty, read_process_output):
69 (exec_sentinel): Remove vars that were set but not used.
70 (create_pty): Remove unnecessary "volatile"s.
71 (Fnetwork_interface_info): Avoid possibility of int overflow.
72 (read_process_output): Do adaptive read buffering even if carryover.
73 (read_process_output): Simplify nbytes computation if buffered.
75 * bytecode.c (exec_byte_code): Rename local to avoid shadowing.
77 * syntax.c (scan_words): Remove var that was set but not used.
78 (update_syntax_table): Use unsigned instead of int.
80 * lread.c (lisp_file_lexically_bound_p): Use ints rather than endptrs.
81 (lisp_file_lexically_bound_p, read1): Use unsigned instead of int.
82 (safe_to_load_p): Make the end-of-loop test the inverse of the in-loop.
84 * print.c (print_error_message): Avoid int overflow.
86 * font.c (font_list_entities): Redo for clarity,
87 so that reader need not know FONT_DPI_INDEX + 1 == FONT_SPACING_INDEX.
89 * font.c (font_find_for_lface, Ffont_get_glyphs): Remove unused vars.
90 (font_score): Avoid potential overflow in diff calculation.
92 * fns.c (substring_both): Remove var that is set but not used.
93 (sxhash): Redo loop for clarity and to avoid wraparound warning.
95 * eval.c (funcall_lambda): Rename local to avoid shadowing.
97 * alloc.c (mark_object_loop_halt, mark_object): Use size_t, not int.
98 Otherwise, GCC 4.6.0 optimizes the loop check away since the check
99 can always succeed if overflow has undefined behavior.
101 * search.c (boyer_moore, wordify): Remove vars set but not used.
102 (wordify): Omit three unnecessary tests.
104 * indent.c (MULTIBYTE_BYTES_WIDTH): Don't compute wide_column.
105 All callers changed. This avoids the need for an unused var.
107 * casefiddle.c (casify_region): Remove var that is set but not used.
109 * dired.c (file_name_completion): Remove var that is set but not used.
111 * fileio.c (Finsert_file_contents): Make EOF condition clearer.
113 * fileio.c (Finsert_file_contents): Avoid signed integer overflow.
114 (Finsert_file_contents): Remove unnecessary code checking fd.
116 * minibuf.c (read_minibuf_noninteractive): Use size_t for sizes.
117 Check for integer overflow on size calculations.
119 * buffer.c (Fprevious_overlay_change): Remove var that is set
122 * keyboard.c (menu_bar_items, read_char_minibuf_menu_prompt):
123 Remove vars that are set but not used.
124 (timer_check_2): Don't assume timer-list and idle-timer-list are lists.
125 (timer_check_2): Mark vars as initialized.
127 * gtkutil.c (xg_get_file_with_chooser): Mark var as initialized.
129 * image.c (lookup_image): Remove var that is set but not used.
130 (xbm_load): Use parse_p, for gcc -Werror=unused-but-set-variable.
132 * fontset.c (Finternal_char_font, Ffontset_info): Remove vars
133 that are set but not used.
135 * xfns.c (make_invisible_cursor): Don't return garbage
136 if XCreateBitmapFromData fails (Bug#8410).
138 * xselect.c (x_get_local_selection, x_handle_property_notify):
139 Remove vars that are set but not used.
141 * xfns.c (x_create_tip_frame): Remove var that is set but not used.
142 (make_invisible_cursor): Initialize a possibly-uninitialized variable.
144 * xterm.c (x_scroll_bar_to_input_event) [!USE_GTK]:
145 Remove var that is set but not used.
146 (scroll_bar_windows_size): Now size_t, not int.
147 (x_send_scroll_bar_event): Use size_t, not int, for sizes.
150 * xfaces.c (realize_named_face): Remove vars that are set but not used.
151 (map_tty_color) [!defined MSDOS]: Likewise.
153 * term.c (tty_write_glyphs): Use size_t; this avoids overflow warning.
155 * coding.c: Remove vars that are set but not used.
156 (DECODE_COMPOSITION_RULE): Remove 2nd arg, which is unused.
158 (decode_coding_utf_8, decode_coding_utf_16 decode_coding_emacs_mule):
159 (decode_coding_iso_2022, encode_coding_sjis, encode_coding_big5):
160 (decode_coding_charset): Remove vars that are set but not used.
162 * bytecode.c (Fbyte_code) [!defined BYTE_CODE_SAFE]: Remove var
163 that is set but not used.
165 * print.c (print_object): Remove var that is set but not used.
167 Replace 2 copies of readlink code with 1 gnulib version (Bug#8401).
168 The gnulib version avoids calling malloc in the usual case,
169 and on 64-bit hosts doesn't have some arbitrary 32-bit limits.
170 * fileio.c (Ffile_symlink_p): Use emacs_readlink.
171 * filelock.c (current_lock_owner): Likewise.
172 * lisp.h (READLINK_BUFSIZE, emacs_readlink): New function.
173 * sysdep.c: Include allocator.h, careadlinkat.h.
174 (emacs_no_realloc_allocator): New static constant.
175 (emacs_readlink): New function.
176 * deps.mk (sysdep.o): Depend on ../lib/allocator.h and on
177 ../lib/careadlinkat.h.
179 2011-04-04 Stefan Monnier <monnier@iro.umontreal.ca>
181 * keyboard.c (safe_run_hook_funcall): Fix last change (don't stop at the
182 first non-nil return value).
184 2011-04-03 Jan Djärv <jan.h.d@swipnet.se>
186 * nsterm.m (ns_update_auto_hide_menu_bar): Define MAC_OS_X_VERSION_10_6
187 if not defined (Bug#8403).
189 2011-04-02 Juanma Barranquero <lekktu@gmail.com>
191 * xdisp.c (display_count_lines): Remove parameter `start',
192 unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
193 (get_char_face_and_encoding): Remove parameter `multibyte_p',
194 unused since 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
195 (fill_stretch_glyph_string): Remove parameters `row' and `area',
196 unused at least since Kim's GUI unification at 2003-03-16T20:45:46Z!storm@cua.dk
197 and thereabouts. All callers changed.
198 (get_per_char_metric): Remove parameter `f', unused since
199 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
201 2011-04-02 Jim Meyering <meyering@redhat.com>
203 do not dereference NULL upon failed strdup
204 * nsfont.m (ns_descriptor_to_entity): Use xstrdup, not strdup.
205 (ns_get_family): Likewise.
207 2011-04-02 Juanma Barranquero <lekktu@gmail.com>
209 * eval.c (unwind_to_catch) [DEBUG_GCPRO]: Remove redundant assignment.
211 2011-04-02 Jan Djärv <jan.h.d@swipnet.se>
213 * nsterm.m (ns_update_auto_hide_menu_bar): Only for OSX 10.6 or
216 2011-04-01 Stefan Monnier <monnier@iro.umontreal.ca>
220 * window.c (Ftemp_output_buffer_show): New fun.
221 (Fsave_window_excursion):
222 * print.c (Fwith_output_to_temp_buffer): Move to subr.el.
224 * lread.c (lisp_file_lexically_bound_p): New function.
225 (Fload): Bind Qlexical_binding.
226 (readevalloop): Remove `evalfun' arg.
227 Bind Qinternal_interpreter_environment.
228 (Feval_buffer): Bind Qlexical_binding.
229 (defvar_int, defvar_bool, defvar_lisp_nopro, defvar_kboard):
231 (syms_of_lread): Declare `lexical-binding'.
233 * lisp.h (struct Lisp_Symbol): New field `declared_special'.
235 * keyboard.c (eval_dyn): New fun.
236 (menu_item_eval_property): Use it.
238 * image.c (parse_image_spec): Use Ffunctionp.
240 * fns.c (concat, mapcar1): Accept byte-code-functions.
242 * eval.c (Fsetq): Handle lexical vars.
243 (Fdefun, Fdefmacro, Ffunction): Make closures when needed.
244 (Fdefconst, Fdefvaralias, Fdefvar): Mark as dynamic.
245 (FletX, Flet): Obey lexical binding.
246 (Fcommandp): Handle closures.
247 (Feval): New `lexical' arg.
248 (eval_sub): New function extracted from Feval. Use it almost
249 everywhere where Feval was used. Look up vars in lexical env.
251 (Ffunctionp): Move from subr.el.
252 (Ffuncall): Handle closures.
253 (apply_lambda): Remove `eval_flags'.
254 (funcall_lambda): Handle closures and new byte-code-functions.
255 (Fspecial_variable_p): New function.
256 (syms_of_eval): Initialize the Vinternal_interpreter_environment var,
257 but without exporting it to Lisp.
259 * doc.c (Fdocumentation, store_function_docstring):
260 * data.c (Finteractive_form): Handle closures.
262 * callint.c (Fcall_interactively): Preserve lexical-binding mode for
265 * bytecode.c (Bstack_ref, Bstack_set, Bstack_set2, BdiscardN): New
267 (exec_byte_code): New function extracted from Fbyte_code to handle new
268 calling convention for byte-code-functions. Add new byte-codes.
270 * buffer.c (defvar_per_buffer): Set new `declared_special' field.
272 * alloc.c (Fmake_symbol): Init new `declared_special' field.
274 2011-03-31 Juanma Barranquero <lekktu@gmail.com>
276 * xdisp.c (redisplay_internal): Fix prototype.
278 2011-03-31 Eli Zaretskii <eliz@gnu.org>
280 * xdisp.c (SCROLL_LIMIT): New macro.
281 (try_scrolling): Use it when setting scroll_limit. Limit
282 scrolling to 100 screen lines.
283 (redisplay_window): Even when falling back on "recentering",
284 position point in the window according to scroll-conservatively,
285 scroll-margin, and scroll-*-aggressively variables. (Bug#6671)
287 (try_scrolling): When point is above the window, allow searching
288 as far as scroll_max, or one screenful, to compute vertical
289 distance from PT to the scroll margin position. This prevents
290 try_scrolling from unnecessarily failing when
291 scroll-conservatively is set to a value slightly larger than the
292 window height. Clean up the case of PT below the margin at bottom
293 of window: scroll_max can no longer be INT_MAX. When aggressive
294 scrolling is in use, don't let point enter the opposite scroll
295 margin as result of the scroll.
296 (syms_of_xdisp) <scroll-conservatively>: Document the
297 threshold of 100 lines for never-recentering scrolling.
299 2011-03-31 Juanma Barranquero <lekktu@gmail.com>
301 * dispextern.h (move_it_by_lines):
302 * xdisp.c (move_it_by_lines): Remove parameter `need_y_p', unused
303 since 2000-12-29T14:24:09Z!gerd@gnu.org. All callers changed.
304 (message_log_check_duplicate): Remove parameters `prev_bol' and
305 `this_bol', unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
306 (redisplay_internal): Remove parameter `preserve_echo_area',
307 unused since 1999-07-21T21:43:52Z!gerd@gnu.org. All callers changed.
309 * indent.c (Fvertical_motion):
310 * window.c (window_scroll_pixel_based, Frecenter):
311 Don't pass `need_y_p' to `move_it_by_lines'.
313 2011-03-30 Stefan Monnier <monnier@iro.umontreal.ca>
315 * eval.c (struct backtrace): Don't cheat with negative numbers, but do
316 steal a few bits to be more compact.
317 (interactive_p, Fbacktrace, Fbacktrace_frame, mark_backtrace):
318 Remove unneeded casts.
320 * bytecode.c (Fbyte_code): CAR and CDR can GC.
322 2011-03-30 Zachary Kanfer <zkanfer@gmail.com> (tiny change)
324 * keyboard.c (Fexecute_extended_command): Do log the "suggest key
325 binding" message (bug#7967).
327 2011-03-30 Paul Eggert <eggert@cs.ucla.edu>
329 Fix more problems found by GCC 4.6.0's static checks.
331 * unexelf.c (unexec) [! (defined _SYSTYPE_SYSV || defined __sgi)]:
332 Remove unused local var.
334 * editfns.c (Fmessage_box): Remove unused local var.
336 * xdisp.c (try_window_reusing_current_matrix, x_produce_glyphs):
337 (note_mode_line_or_margin_highlight, note_mouse_highlight):
338 Omit unused local vars.
339 * window.c (shrink_windows): Omit unused local var.
340 * menu.c (digest_single_submenu): Omit unused local var.
341 * dispnew.c (update_window) [PERIODIC_PREEMPTION_CHECKING]:
342 Omit unused local var.
344 * keyboard.c (parse_modifiers_uncached, parse_modifiers):
345 Don't assume string length fits in int.
346 (keyremap_step, read_key_sequence): Use size_t for sizes.
347 (read_key_sequence): Don't check last_real_key_start redundantly.
349 * callproc.c (Fcall_process, Fcall_process_region): Use SAFE_ALLOCA
350 instead of alloca (Bug#8344).
352 * eval.c (Fbacktrace): Don't assume nargs fits in int.
353 (Fbacktrace_frame): Don't assume nframes fits in int.
355 * syntax.c (scan_sexps_forward): Avoid pointer wraparound.
357 * xterm.c (x_make_frame_visible, same_x_server): Redo to avoid overflow
360 * term.c (produce_glyphless_glyph): Remove unnecessary test.
362 * cm.c (calccost): Turn while-do into do-while, for clarity.
364 * keyboard.c (syms_of_keyboard): Use the same style as later
365 in this function when indexing through an array. This also
366 works around GCC bug 48267.
368 * image.c (tiff_load): Fix off-by-one image count (Bug#8336).
370 * xselect.c (x_check_property_data): Return correct size (Bug#8335).
372 * chartab.c (sub_char_table_ref_and_range): Redo for slight
373 efficiency gain, and to bypass a gcc -Wstrict-overflow warning.
375 * keyboard.c, keyboard.h (num_input_events): Now size_t.
376 This avoids undefined behavior on integer overflow, and is a bit
377 more convenient anyway since it is compared to a size_t variable.
379 Variadic C functions now count arguments with size_t, not int.
380 This avoids an unnecessary limitation on 64-bit machines, which
381 caused (substring ...) to crash on large vectors (Bug#8344).
382 * lisp.h (struct Lisp_Subr.function.aMANY): Now takes size_t, not int.
383 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call): Likewise.
384 All variadic functions and their callers changed accordingly.
385 (struct gcpro.nvars): Now size_t, not int. All uses changed.
386 * data.c (arith_driver, float_arith_driver): Likewise.
387 * editfns.c (general_insert_function): Likewise.
388 * eval.c (struct backtrace.nargs, interactive_p)
389 (internal_condition_case_n, run_hook_with_args, apply_lambda)
390 (funcall_lambda, mark_backtrace): Likewise.
391 * fns.c (concat): Likewise.
392 * frame.c (x_set_frame_parameters): Likewise.
393 * fns.c (get_key_arg): Now accepts and returns size_t, and returns
394 0 if not found, not -1. All callers changed.
396 * alloc.c (garbage_collect): Don't assume stack size fits in int.
397 (stack_copy_size): Now size_t, not int.
398 (stack_copy, stack_copy_size): Define only if MAX_SAVE_STACK > 0.
400 2011-03-28 Juanma Barranquero <lekktu@gmail.com>
402 * coding.c (encode_designation_at_bol): Remove parameter `charbuf_end',
403 unused since 2002-03-01T01:17:24Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
406 * lisp.h (multibyte_char_to_unibyte):
407 * character.c (multibyte_char_to_unibyte): Remove parameter `rev_tbl',
408 unused since 2002-03-01T01:16:34Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
409 * character.h (CHAR_TO_BYTE8):
410 * cmds.c (internal_self_insert):
411 * editfns.c (general_insert_function):
412 * keymap.c (push_key_description):
413 * search.c (Freplace_match):
414 * xdisp.c (message_dolog, set_message_1): All callers changed.
416 2011-03-28 Stefan Monnier <monnier@iro.umontreal.ca>
418 * keyboard.c (safe_run_hook_funcall): New function.
419 (safe_run_hooks_1, safe_run_hooks_error, safe_run_hooks): On error,
420 don't set the hook to nil, but remove the offending function instead.
421 (Qcommand_hook_internal): Remove, unused.
422 (syms_of_keyboard): Don't initialize Qcommand_hook_internal nor define
423 Vcommand_hook_internal.
425 * eval.c (enum run_hooks_condition): Remove.
426 (funcall_nil, funcall_not): New functions.
427 (run_hook_with_args): Call each function through a `funcall' argument.
428 Remove `cond' argument, now redundant.
429 (Frun_hooks, Frun_hook_with_args, Frun_hook_with_args_until_success)
430 (Frun_hook_with_args_until_failure): Adjust accordingly.
431 (run_hook_wrapped_funcall, Frun_hook_wrapped): New functions.
433 2011-03-28 Juanma Barranquero <lekktu@gmail.com>
435 * dispextern.h (string_buffer_position): Remove declaration.
437 * print.c (strout): Remove parameter `multibyte', unused since
438 1999-08-21T19:30:21Z!gerd@gnu.org. All callers changed.
440 * search.c (boyer_moore): Remove parameters `len', `pos' and `lim',
441 never used since function introduction in 1998-02-08T21:33:56Z!rms@gnu.org.
444 * w32.c (_wsa_errlist): Use braces for struct initializers.
446 * xdisp.c (string_buffer_position_lim): Remove parameter `w',
447 never used since function introduction in 2001-03-09T18:41:50Z!gerd@gnu.org.
449 (string_buffer_position): Likewise. Also, make static (it's never
450 used outside xdisp.c).
451 (cursor_row_p): Remove parameter `w', unused since
452 2000-10-17T16:08:57Z!gerd@gnu.org. All callers changed.
453 (decode_mode_spec): Remove parameter `precision', introduced during
454 Gerd Moellmann's rewrite at 1999-07-21T21:43:52Z!gerd@gnu.org, but never used.
457 2011-03-27 Jan Djärv <jan.h.d@swipnet.se>
459 * nsterm.m (syms_of_nsterm): Use doc: for ns-auto-hide-menu-bar.
461 2011-03-27 Anders Lindgren <andlind@gmail.com>
463 * nsterm.m (ns_menu_bar_is_hidden): New variable.
464 (ns_constrain_all_frames, ns_menu_bar_should_be_hidden)
465 (ns_update_auto_hide_menu_bar): New functions.
466 (ns_update_begin): Call ns_update_auto_hide_menu_bar.
467 (applicationDidBecomeActive): Call ns_update_auto_hide_menu_bar and
468 ns_constrain_all_frames.
469 (constrainFrameRect): Return at once if ns_menu_bar_should_be_hidden.
470 (syms_of_nsterm): DEFVAR ns-auto-hide-menu-bar, init to Qnil.
472 2011-03-27 Jan Djärv <jan.h.d@swipnet.se>
474 * nsmenu.m (runDialogAt): Remove argument to timer_check.
476 2011-03-27 Glenn Morris <rgm@gnu.org>
478 * syssignal.h: Replace RETSIGTYPE with void.
479 * atimer.c, data.c, dispnew.c, emacs.c, floatfns.c, keyboard.c:
480 * keyboard.h, lisp.h, process.c, sysdep.c, xterm.c:
481 Replace SIGTYPE with void everywhere.
482 * s/usg5-4-common.h (SIGTYPE): Remove definition.
483 * s/template.h (SIGTYPE): Remove commented out definition.
485 2011-03-26 Eli Zaretskii <eliz@gnu.org>
487 * xdisp.c (redisplay_window): Don't check buffer's clip_changed
488 flag as a prerequisite for invoking try_scrolling. (Bug#6671)
490 2011-03-26 Juanma Barranquero <lekktu@gmail.com>
492 * w32.c (read_unc_volume): Use parameter `henum', instead of
493 global variable `wget_enum_handle'.
495 * keymap.c (describe_vector): Remove parameters `indices' and
496 `char_table_depth', unused since 2002-03-01T01:43:26Z!handa@m17n.org.
497 (describe_map, Fdescribe_vector): Adjust calls to `describe_vector'.
499 * keyboard.h (timer_check, show_help_echo): Remove unused parameters.
501 * keyboard.c (timer_check): Remove parameter `do_it_now',
502 unused since 1996-04-12T06:01:29Z!rms@gnu.org.
503 (show_help_echo): Remove parameter `ok_to_overwrite_keystroke_echo',
504 unused since 2008-04-19T19:30:53Z!monnier@iro.umontreal.ca.
506 * keyboard.c (read_char):
507 * w32menu.c (w32_menu_display_help):
508 * xmenu.c (show_help_event, menu_help_callback):
509 Adjust calls to `show_help_echo'.
511 * gtkutil.c (xg_maybe_add_timer):
512 * keyboard.c (readable_events):
513 * process.c (wait_reading_process_output):
514 * xmenu.c (x_menu_wait_for_event): Adjust calls to `timer_check'.
516 * insdel.c (adjust_markers_gap_motion):
517 Remove; no-op since 1998-01-02T21:29:48Z!rms@gnu.org.
518 (gap_left, gap_right): Don't call it.
520 2011-03-25 Chong Yidong <cyd@stupidchicken.com>
522 * xdisp.c (handle_fontified_prop): Discard changes to clip_changed
523 incurred during fontification.
525 2011-03-25 Juanma Barranquero <lekktu@gmail.com>
527 * buffer.c (defvar_per_buffer): Remove unused parameter `doc'.
528 (DEFVAR_PER_BUFFER): Don't pass it.
530 * dispnew.c (row_equal_p, add_row_entry): Remove unused parameter `w'.
531 (scrolling_window): Don't pass it.
533 2011-03-25 Juanma Barranquero <lekktu@gmail.com>
535 * dispextern.h (glyph_matric): Use #if GLYPH_DEBUG, not #ifdef.
537 * fileio.c (check_executable) [DOS_NT]: Remove unused variables `len'
539 (Fset_file_selinux_context) [HAVE_LIBSELINUX]: Move here declaration
540 of variables specific to SELinux and computation of `encoded_absname'.
542 * image.c (XPutPixel): Remove unused variable `height'.
544 * keyboard.c (make_lispy_event): Remove unused variable `hpos'.
546 * unexw32.c (get_section_info): Remove unused variable `section'.
548 * w32.c (stat): Remove unused variables `drive_root' and `devtype'.
549 (system_process_attributes): Remove unused variable `sess'.
550 (sys_read): Remove unused variable `err'.
552 * w32fns.c (top): Wrap variables with #if GLYPH_DEBUG, not #ifdef.
553 (w32_wnd_proc): Remove unused variable `isdead'.
554 (unwind_create_frame): Use #if GLYPH_DEBUG, not #ifdef.
555 (Fx_server_max_request_size): Remove unused variable `dpyinfo'.
556 (x_create_tip_frame): Remove unused variable `tem'.
558 * w32inevt.c (w32_console_read_socket):
559 Remove unused variable `no_events'.
561 * w32term.c (x_draw_composite_glyph_string_foreground):
562 Remove unused variable `width'.
564 2011-03-24 Juanma Barranquero <lekktu@gmail.com>
566 * w32term.c (x_set_glyph_string_clipping):
567 Don't pass uninitialized region to CombineRgn.
569 2011-03-23 Juanma Barranquero <lekktu@gmail.com>
571 * w32fns.c (x_set_menu_bar_lines): Remove unused variable `olines'.
572 (w32_wnd_proc): Pass NULL to Windows API, not uninitialized buffer.
573 (Fx_close_connection): Remove unused variable `i'.
575 * w32font.c (w32font_draw): Return number of glyphs.
576 (w32font_open_internal): Remove unused variable `i'.
577 (w32font_driver): Add missing initializer.
579 * w32menu.c (utf8to16): Remove unused variable `utf16'.
580 (fill_in_menu): Remove unused variable `items_added'.
582 * w32term.c (last_mouse_press_frame): Remove static global variable.
583 (w32_clip_to_row): Remove unused variable `f'.
584 (x_delete_terminal): Remove unused variable `i'.
586 * w32uniscribe.c (uniscribe_shape): Remove unused variable `nclusters'.
587 (NOTHING): Remove unused static global variable.
588 (uniscribe_check_otf): Remove unused variable `table'.
589 (uniscribe_font_driver): Add missing initializers.
591 2011-03-23 Julien Danjou <julien@danjou.info>
593 * term.c (Fsuspend_tty, Fresume_tty):
594 * minibuf.c (read_minibuf, run_exit_minibuf_hook):
595 * window.c (temp_output_buffer_show):
596 * insdel.c (signal_before_change):
597 * frame.c (Fhandle_switch_frame):
598 * fileio.c (Fdo_auto_save):
599 * emacs.c (Fkill_emacs):
600 * editfns.c (save_excursion_restore):
601 * cmds.c (internal_self_insert):
602 * callint.c (Fcall_interactively):
603 * buffer.c (Fkill_all_local_variables):
604 * keyboard.c (Fcommand_execute, Fsuspend_emacs, safe_run_hooks_1):
606 (command_loop_1): Use Frun_hooks. Call safe_run_hooks
607 unconditionnaly since it does the check itself.
609 2011-03-23 Paul Eggert <eggert@cs.ucla.edu>
611 Fix more problems found by GCC 4.5.2's static checks.
613 * coding.c (encode_coding_raw_text): Avoid unnecessary test
614 the first time through the loop, since we know p0 < p1 then.
615 This also avoids a gcc -Wstrict-overflow warning.
617 * lisp.h (SAFE_ALLOCA, SAFE_ALLOCA_LISP): Avoid 'int' overflow
618 leading to a memory leak, possible in functions like
619 load_charset_map_from_file that can allocate an unbounded number
620 of objects (Bug#8318).
622 * xmenu.c (set_frame_menubar): Use EMACS_UINT, not int, for indexes
623 that could (at least in theory) be that large.
625 * xdisp.c (message_log_check_duplicate): Return unsigned long, not int.
626 This is less likely to overflow, and avoids undefined behavior if
627 overflow does occur. All callers changed. Use strtoul to scan
628 for the unsigned long integer.
629 (pint2hrstr): Simplify and tune code slightly.
630 This also avoids a (bogus) GCC warning with gcc -Wstrict-overflow.
632 * scroll.c (do_scrolling): Work around GCC bug 48228.
633 See <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=48228>.
635 * frame.c (Fmodify_frame_parameters): Simplify loop counter.
636 This also avoids a warning with gcc -Wstrict-overflow.
637 (validate_x_resource_name): Simplify count usage.
638 This also avoids a warning with gcc -Wstrict-overflow.
640 * fileio.c (Fcopy_file): Report error if fchown or fchmod
643 * emacs.c (Fdaemon_initialized): Do not ignore I/O errors (Bug#8303).
645 * process.c (Fmake_network_process): Use socklen_t, not int,
646 where POSIX says socklen_t is required in portable programs.
647 This fixes a porting bug on hosts like 64-bit HP-UX, where
648 socklen_t is wider than int (Bug#8277).
649 (Fmake_network_process, server_accept_connection):
650 (wait_reading_process_output, read_process_output):
653 * process.c: Rename or move locals to avoid shadowing.
654 (list_processes_1, Fmake_network_process):
655 (read_process_output_error_handler, exec_sentinel_error_handler):
656 Rename or move locals.
657 (Fmake_network_process): Define label "retry_connect" only if needed.
658 (Fnetwork_interface_info): Fix pointer signedness.
659 (process_send_signal): Add cast to avoid pointer signedness problem.
660 (FIRST_PROC_DESC, IF_NON_BLOCKING_CONNECT): Remove unused macros.
661 (create_process): Use 'volatile' to avoid vfork clobbering (Bug#8298).
663 Make tparam.h and terminfo.c consistent.
664 * cm.c (tputs, tgoto, BC, UP): Remove extern decls.
665 Include tparam.h instead, since it declares them.
666 * cm.h (PC): Remove extern decl; tparam.h now does this.
667 * deps.mk (cm.o, terminfo.o): Depend on tparam.h.
668 * terminfo.c: Include tparam.h, to check interfaces.
669 (tparm): Make 1st arg a const pointer in decl. Put it at top level.
670 (tparam): Adjust signature to match interface in tparam.h;
671 this removes some undefined behavior. Check that outstring and len
672 are zero, which they always are with Emacs.
673 * tparam.h (PC, BC, UP): New extern decls.
675 * xftfont.c (xftfont_shape): Now static, and defined only if needed.
676 (xftfont_open): Rename locals to avoid shadowing.
678 * ftfont.c (ftfont_resolve_generic_family): Fix pointer signedness.
679 (ftfont_otf_capability, ftfont_shape): Omit decls if not needed.
680 (OTF_TAG_SYM): Omit macro if not needed.
681 (ftfont_list): Remove unused local.
682 (get_adstyle_property, ftfont_pattern_entity):
683 (ftfont_lookup_cache, ftfont_open, ftfont_anchor_point):
684 Rename locals to avoid shadowing.
686 * xfont.c (xfont_list_family): Mark var as initialized.
688 * xml.c (make_dom): Now static.
690 * composite.c (composition_compute_stop_pos): Rename local to
692 (composition_reseat_it): Remove unused locals.
693 (find_automatic_composition, composition_adjust_point): Likewise.
694 (composition_update_it): Mark var as initialized.
695 (find_automatic_composition): Mark vars as initialized,
696 with a FIXME (Bug#8290).
698 character.h: Rename locals to avoid shadowing.
699 * character.h (PREV_CHAR_BOUNDARY, FETCH_STRING_CHAR_ADVANCE):
700 (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE, FETCH_CHAR_ADVANCE):
701 (FETCH_CHAR_ADVANCE_NO_CHECK, INC_POS, DEC_POS, BUF_INC_POS):
702 (BUF_DEC_POS): Be more systematic about renaming local temporaries
705 * textprop.c (property_change_between_p): Remove; unused.
707 * intervals.c (interval_start_pos): Now static.
709 * intervals.h (CHECK_TOTAL_LENGTH): Avoid empty "else".
711 * atimer.c (start_atimer, append_atimer_lists, set_alarm):
712 Rename locals to avoid shadowing.
714 * sound.c (wav_play, au_play, Fplay_sound_internal):
715 Fix pointer signedness.
716 (alsa_choose_format): Remove unused local var.
717 (wav_play): Initialize a variable to 0, to prevent undefined
720 * region-cache.c (insert_cache_boundary): Redo var to avoid shadowing.
722 * region-cache.h (pp_cache): New decl, for gcc -Wmissing-prototypes.
724 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork
725 clobbering (Bug#8298).
726 * sysdep.c (sys_subshell): Likewise.
727 Previously, the sys_subshell 'volatile' was incorrectly IF_LINTted out.
729 * lisp.h (child_setup): Now NO_RETURN unless DOS_NT.
730 This should get cleaned up, so that child_setup has the
731 same signature on all platforms.
733 * callproc.c (call_process_cleanup): Now static.
734 (relocate_fd): Rename locals to avoid shadowing.
736 2011-03-22 Chong Yidong <cyd@stupidchicken.com>
738 * xterm.c (x_clear_frame): Remove XClearWindow call. This appears
739 not to be necessary, and produces flickering.
741 2011-03-20 Glenn Morris <rgm@gnu.org>
743 * config.in: Remove file.
745 2011-03-20 Juanma Barranquero <lekktu@gmail.com>
747 * minibuf.c (Vcompleting_read_function): Don't declare, global variables
748 are now in src/globals.h.
749 (syms_of_minibuf): Remove spurious & from previous change.
751 2011-03-20 Leo <sdl.web@gmail.com>
753 * minibuf.c (completing-read-function): New variable.
754 (completing-read-default): Rename from completing-read.
755 (completing-read): Call completing-read-function.
757 2011-03-19 Juanma Barranquero <lekktu@gmail.com>
759 * xfaces.c (Fx_load_color_file):
760 Read color file from absolute filename (bug#8250).
762 2011-03-19 Juanma Barranquero <lekktu@gmail.com>
764 * makefile.w32-in: Update dependencies.
766 2011-03-17 Eli Zaretskii <eliz@gnu.org>
768 * makefile.w32-in ($(BLD)/unexw32.$(O)): Depend on $(SRC)/unexec.h.
770 2011-03-17 Paul Eggert <eggert@cs.ucla.edu>
772 Fix more problems found by GCC 4.5.2's static checks.
774 * process.c (make_serial_process_unwind, send_process_trap):
775 (sigchld_handler): Now static.
777 * process.c (allocate_pty): Let PTY_ITERATION declare iteration vars.
778 That way, the code declares only the vars that it needs.
779 * s/aix4-2.h (PTY_ITERATION): Declare iteration vars.
780 * s/cygwin.h (PTY_ITERATION): Likewise.
781 * s/darwin.h (PTY_ITERATION): Likewise.
782 * s/gnu-linux.h (PTY_ITERATION): Likewise.
784 * s/irix6-5.h (PTY_OPEN): Declare stb, to loosen coupling.
785 * process.c (allocate_pty): Don't declare stb unless it's needed.
787 * bytecode.c (MAYBE_GC): Rewrite so as not to use empty "else".
788 (CONSTANTLIM): Remove; unused.
789 (METER_CODE, Bscan_buffer, Bread_char, Bset_mark):
790 Define only if needed.
792 * unexelf.c (unexec): Name an expression,
793 to avoid gcc -Wbad-function-cast warning.
794 Use a different way to cause a compilation error if anyone uses
795 n rather than nn, a way that does not involve shadowing.
796 (ELF_BSS_SECTION_NAME, OLD_PROGRAM_H): Remove; unused.
798 * deps.mk (unexalpha.o): Remove; unused.
800 New file unexec.h, the (simple) interface for unexec (Bug#8267).
801 * unexec.h: New file.
802 * deps.mk (emacs.o, unexaix.o, unexcw.o, unexcoff.o, unexelf.o):
803 (unexhp9k800.o, unexmacosx.o, unexsol.o, unexw32.o):
805 * emacs.c [!defined CANNOT_DUMP]: Include unexec.h.
806 * unexaix.c, unexcoff.c, unexcw.c, unexelf.c, unexhp9k800.c:
807 * unexmacosx.c, unexsol.c, unexw32.c: Include unexec.h.
808 Change as necessary to match prototype in unexec.h.
810 * syntax.c (Fforward_comment, scan_lists): Rename locals to avoid
812 (back_comment, skip_chars): Mark vars as initialized.
814 * character.h (FETCH_STRING_CHAR_ADVANCE_NO_CHECK, BUF_INC_POS):
815 Rename locals to avoid shadowing.
817 * lread.c (read1): Rewrite so as not to use empty "else".
818 (Fload, readevalloop, read1): Rename locals to avoid shadowing.
820 * print.c (Fredirect_debugging_output): Fix pointer signedess.
822 * lisp.h (debug_output_compilation_hack): Add decl here, to avoid
823 warning when compiling print.c.
825 * font.c (font_unparse_fcname): Abort in an "impossible" situation
826 instead of using an uninitialized var.
827 (font_sort_entities): Mark var as initialized.
829 * character.h (FETCH_CHAR_ADVANCE): Rename locals to avoid shadowing.
831 * font.c (font_unparse_xlfd): Don't mix pointers to variables with
832 pointers to constants.
833 (font_parse_fcname): Remove unused vars.
834 (font_delete_unmatched): Now static.
835 (font_get_spec): Remove; unused.
836 (font_style_to_value, font_prop_validate_style, font_unparse_fcname):
837 (font_update_drivers, Ffont_get_glyphs, font_add_log):
838 Rename or move locals to avoid shadowing.
840 * fns.c (require_nesting_list, require_unwind): Now static.
841 (Ffillarray): Rename locals to avoid shadowing.
843 * floatfns.c (domain_error2): Define only if needed.
844 (Ffrexp, Fldexp): Rename locals to avoid shadowing.
846 * alloc.c (mark_backtrace): Move decl from here ...
847 * lisp.h: ... to here, so that it can be checked.
849 * eval.c (call_debugger, do_debug_on_call, grow_specpdl): Now static.
850 (Fdefvar): Rewrite so as not to use empty "else".
851 (lisp_indirect_variable): Name an expression,
852 to avoid gcc -Wbad-function-cast warning.
853 (Fdefvar): Rename locals to avoid shadowing.
855 * callint.c (quotify_arg, quotify_args): Now static.
856 (Fcall_interactively): Rename locals to avoid shadowing.
857 Use const pointer when appropriate.
859 * lisp.h (get_system_name, get_operating_system_release):
860 Move decls here, to check interfaces.
861 * process.c (get_operating_system_release): Move decl to lisp.h.
862 * xrdb.c (get_system_name): Likewise.
863 * editfns.c (init_editfns, Fuser_login_name, Fuser_uid):
864 (Fuser_real_uid, Fuser_full_name): Remove unnecessary casts,
865 some of which prompt warnings from gcc -Wbad-function-cast.
866 (Fformat_time_string, Fencode_time, Finsert_char):
867 (Ftranslate_region_internal, Fformat):
868 Rename or remove local vars to avoid shadowing.
869 (Ftranslate_region_internal): Mark var as initialized.
871 * doc.c (Fdocumentation, Fsnarf_documentation): Move locals to
874 * lisp.h (eassert): Check that the argument compiles, even if
875 ENABLE_CHECKING is not defined.
877 * data.c (Findirect_variable): Name an expression, to avoid
878 gcc -Wbad-function-cast warning.
879 (default_value, arithcompare, arith_driver, arith_error): Now static.
880 (store_symval_forwarding): Rename local to avoid shadowing.
881 (Fmake_variable_buffer_local, Fmake_local_variable):
882 Mark variables as initialized.
883 (do_blv_forwarding, do_symval_forwarding): Remove; unused.
885 * alloc.c (check_cons_list): Do not define unless GC_CHECK_CONS_LIST.
886 (Fmake_vector, Fvector, Fmake_byte_code, Fgarbage_collect):
887 Rename locals to avoid shadowing.
888 (mark_stack): Move local variables into the #ifdef region where
890 (BLOCK_INPUT_ALLOC, UNBLOCK_INPUT_ALLOC): Define only if
891 ! defined SYSTEM_MALLOC && ! defined SYNC_INPUT, as they are not
893 (CHECK_ALLOCATED): Define only if GC_CHECK_MARKED_OBJECTS.
894 (GC_STRING_CHARS): Remove; not used.
895 (Fmemory_limit): Cast sbrk's returned value to char *.
897 * lisp.h (check_cons_list): Declare if GC_CHECK_CONS_LIST; this
898 avoids undefined behavior in theory.
900 * regex.c (IF_LINT): Add defn, for benefit of ../lib-src.
902 Use functions, not macros, for up- and down-casing (Bug#8254).
903 * buffer.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
904 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Remove. All callers changed
905 to use the following functions instead of these macros.
906 (downcase): Adjust to lack of DOWNCASE_TABLE. Return int, not
907 EMACS_INT, since callers assume the returned value fits in int.
908 (upcase1): Likewise, for UPCASE_TABLE.
909 (uppercasep, lowercasep, upcase): New static inline functions.
910 * editfns.c (Fchar_equal): Remove no-longer-needed workaround for
911 the race-condition problem in the old DOWNCASE.
913 * regex.c (CHARSET_LOOKUP_RANGE_TABLE_RAW, POP_FAILURE_REG_OR_COUNT):
914 Rename locals to avoid shadowing.
915 (regex_compile, re_match_2_internal): Move locals to avoid shadowing.
916 (regex_compile, re_search_2, re_match_2_internal):
917 Remove unused local vars.
918 (FREE_VAR): Rewrite so as not to use empty "else",
919 which gcc can warn about.
920 (regex_compile, re_match_2_internal): Mark locals as initialized.
921 (RETALLOC_IF): Define only if needed.
922 (WORDCHAR_P): Likewise. This one is never needed, but is used
923 only in a comment talking about a compiler bug, so put inside
924 the #if 0 of that comment.
925 (CHARSET_LOOKUP_BITMAP, FAIL_STACK_FULL, RESET_FAIL_STACK):
926 (PUSH_FAILURE_ELT, BUF_PUSH_3, STOP_ADDR_VSTRING):
929 * search.c (boyer_moore): Rename locals to avoid shadowing.
930 * character.h (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE):
931 (PREV_CHAR_BOUNDARY): Likewise.
933 * search.c (simple_search): Remove unused var.
935 * dired.c (compile_pattern): Move decl from here ...
936 * lisp.h: ... to here, so that it can be checked.
937 (struct re_registers): New forward decl.
939 * character.h (INC_POS, DEC_POS): Rename locals to avoid shadowing.
941 * indent.c (MULTIBYTE_BYTES_WIDTH): New args bytes, width.
943 (MULTIBYTE_BYTES_WIDTH, scan_for_column, compute_motion):
944 Rename locals to avoid shadowing.
945 (Fvertical_motion): Mark locals as initialized.
947 * casefiddle.c (casify_object, casify_region): Now static.
948 (casify_region): Mark local as initialized.
950 * cmds.c (internal_self_insert): Rename local to avoid shadowing.
952 * lisp.h (GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR, GCPRO5_VAR, GCPRO6_VAR):
953 New macros, so that the caller can use some names other than
955 (GCPRO2, GCPRO3, GCPRO4, GCPRO5, GCPRO6): Reimplement in terms
957 (GCPRO1_VAR, UNGCPRO_VAR): Change the meaning of the second
958 argument, for consistency with GCPRO2_VAR, etc: it is now the
959 prefix of the variable, not the variable itself. All uses
961 * dired.c (directory_files_internal, file_name_completion):
962 Rename locals to avoid shadowing.
964 Fix a race condition diagnosed by gcc -Wsequence-point (Bug#8254).
965 An expression of the form (DOWNCASE (x) == DOWNCASE (y)), found in
966 dired.c's scmp function, had undefined behavior.
967 * lisp.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
968 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Move from here ...
969 * buffer.h: ... to here, because these macros use current_buffer,
970 and the new implementation with inline functions needs to have
971 current_buffer in scope now, rather than later when the macros
973 (downcase, upcase1): New static inline functions.
974 (DOWNCASE, UPCASE1): Reimplement using these functions.
975 This avoids undefined behavior in expressions like
976 DOWNCASE (x) == DOWNCASE (y), which previously suffered
977 from race conditions in accessing the global variables
978 case_temp1 and case_temp2.
979 * casetab.c (case_temp1, case_temp2): Remove; no longer needed.
980 * lisp.h (case_temp1, case_temp2): Remove their decls.
981 * character.h (ASCII_CHAR_P): Move from here ...
982 * lisp.h: ... to here, so that the inline functions mentioned
985 * dired.c (directory_files_internal_unwind): Now static.
987 * fileio.c (file_name_as_directory, directory_file_name):
988 (barf_or_query_if_file_exists, auto_save_error, auto_save_1):
990 (file_name_as_directory): Use const pointers when appropriate.
991 (Fexpand_file_name): Likewise. In particular, newdir might
992 point at constant storage, so make it a const pointer.
993 (Fmake_directory_internal, Fread_file_name): Remove unused vars.
994 (Ffile_selinux_context, Fset_file_selinux_context): Fix pointer
996 (Fset_file_times, Finsert_file_contents, auto_save_error):
997 Rename locals to avoid shadowing.
999 * minibuf.c (choose_minibuf_frame_1): Now static.
1000 (Ftry_completion, Fall_completions): Rename or remove locals
1003 * marker.c (bytepos_to_charpos): Remove; unused.
1005 * lisp.h (verify_bytepos, count_markers): New decls,
1006 so that gcc does not warn that these functions aren't declared.
1008 * insdel.c (check_markers, make_gap_larger, make_gap_smaller):
1009 (reset_var_on_error, Fcombine_after_change_execute_1): Now static.
1010 (CHECK_MARKERS): Redo to avoid gcc -Wempty-body diagnostic.
1011 (copy_text): Remove unused local var.
1013 * filelock.c (within_one_second): Now static.
1014 (lock_file_1): Rename local to avoid shadowing.
1016 * buffer.c (fix_overlays_before): Mark locals as initialized.
1017 (fix_start_end_in_overlays): Likewise. This function should be
1018 simplified by using pointers-to-pointers, but that's a different
1020 (switch_to_buffer_1): Now static.
1021 (Fkill_buffer, record_buffer, Fbury_buffer, Fset_buffer_multibyte):
1022 (report_overlay_modification): Rename locals to avoid shadowing.
1024 * sysdep.c (system_process_attributes): Rename vars to avoid shadowing.
1025 Fix pointer signedness issue.
1026 (sys_subshell): Mark local as volatile if checking for lint,
1027 to suppress a gcc -Wclobbered warning that does not seem to be right.
1028 (MAXPATHLEN): Define only if needed.
1030 * process.c (serial_open, serial_configure): Move decls from here ...
1031 * systty.h: ... to here, so that they can be checked.
1033 * fns.c (get_random, seed_random): Move extern decls from here ...
1034 * lisp.h: ... to here, so that they can be checked.
1036 * sysdep.c (reset_io): Now static.
1037 (wait_for_termination_signal): Remove; unused.
1039 * keymap.c (keymap_parent, keymap_memberp, map_keymap_internal):
1040 (copy_keymap_item, append_key, push_text_char_description):
1042 (Fwhere_is_internal): Don't test CONSP (sequences) unnecessarily.
1043 (DENSE_TABLE_SIZE): Remove; unused.
1044 (get_keymap, access_keymap, Fdefine_key, Fwhere_is_internal):
1045 (describe_map_tree):
1046 Rename locals to avoid shadowing.
1048 * keyboard.c: Declare functions static if they are not used elsewhere.
1049 (echo_char, echo_dash, cmd_error, top_level_2):
1050 (poll_for_input, handle_async_input): Now static.
1051 (read_char, kbd_buffer_get_event, make_lispy_position):
1052 (make_lispy_event, make_lispy_movement, apply_modifiers):
1053 (decode_keyboard_code, tty_read_avail_input, menu_bar_items):
1054 (parse_tool_bar_item, read_key_sequence, Fread_key_sequence):
1055 (Fread_key_sequence_vector): Rename locals to avoid shadowing.
1056 (read_key_sequence, read_char): Mark locals as initialized.
1057 (Fexit_recursive_edit, Fabort_recursive_edit): Mark with NO_RETURN.
1059 * keyboard.h (make_ctrl_char): New decl.
1060 (mark_kboards): Move decl here ...
1061 * alloc.c (mark_kboards): ... from here.
1063 * lisp.h (force_auto_save_soon): New decl.
1065 * emacs.c (init_cmdargs): Rename local to avoid shadowing.
1066 (DEFINE_DUMMY_FUNCTION): New macro.
1067 (__do_global_ctors, __do_global_ctors_aux, __do_global_dtors, __main):
1069 (main): Add casts to avoid warnings
1070 if GCC considers string literals to be constants.
1072 * lisp.h (fatal_error_signal): Add decl, since it's exported.
1074 * dbusbind.c: Pointer signedness fixes.
1075 (xd_signature, xd_append_arg, xd_initialize):
1076 (Fdbus_call_method, Fdbus_call_method_asynchronously):
1077 (Fdbus_method_return_internal, Fdbus_method_error_internal):
1078 (Fdbus_send_signal, xd_read_message_1, Fdbus_register_service):
1079 (Fdbus_register_signal): Use SSDATA when the context wants char *.
1081 * dbusbind.c (Fdbus_init_bus): Add cast to avoid warning
1082 if GCC considers string literals to be constants.
1083 (Fdbus_register_service, Fdbus_register_method): Remove unused vars.
1085 2011-03-16 Stefan Monnier <monnier@iro.umontreal.ca>
1087 * print.c (PRINT_CIRCLE_CANDIDATE_P): New macro.
1088 (print_preprocess, print_object): New macro to fix last change.
1090 * print.c (print_preprocess): Don't forget font objects.
1092 2011-03-16 Juanma Barranquero <lekktu@gmail.com>
1094 * emacs.c (USAGE3): Doc fixes.
1096 2011-03-15 Andreas Schwab <schwab@linux-m68k.org>
1098 * coding.c (detect_coding_iso_2022): Reorganize code to clarify
1101 2011-03-14 Juanma Barranquero <lekktu@gmail.com>
1103 * lisp.h (VWindow_system, Qfile_name_history):
1104 * keyboard.h (lispy_function_keys) [WINDOWSNT]:
1105 * w32term.h (w32_system_caret_hwnd, w32_system_caret_height)
1106 (w32_system_caret_x, w32_system_caret_y): Declare extern.
1108 * w32select.c: Don't #include "keyboard.h".
1109 (run_protected): Add extern declaration for waiting_for_input.
1111 * w32.c (Qlocal, noninteractive1, inhibit_window_system):
1112 * w32console.c (detect_input_pending, read_input_pending)
1113 (encode_terminal_code):
1114 * w32fns.c (quit_char, lispy_function_keys, Qtooltip)
1115 (w32_system_caret_hwnd, w32_system_caret_height, w32_system_caret_x)
1116 (w32_system_caret_y, Qfile_name_history):
1117 * w32font.c (w32font_driver, QCantialias, QCotf, QClang):
1118 * w32inevt.c (reinvoke_input_signal, lispy_function_keys):
1119 * w32menu.c (Qmenu_bar, QCtoggle, QCradio, Qoverriding_local_map)
1120 (Qoverriding_terminal_local_map, Qmenu_bar_update_hook):
1121 * w32proc.c (Qlocal, report_file_error):
1122 * w32term.c (Vwindow_system, updating_frame):
1123 * w32uniscribe.c (initialized, uniscribe_font_driver):
1124 Remove unneeded extern declarations.
1126 2011-03-14 Chong Yidong <cyd@stupidchicken.com>
1128 * buffer.c (Fmake_indirect_buffer): Fix incorrect assertions.
1130 2011-03-13 Chong Yidong <cyd@stupidchicken.com>
1132 * buffer.h (BUF_BEGV, BUF_BEGV_BYTE, BUF_ZV, BUF_ZV_BYTE, BUF_PT)
1133 (BUF_PT_BYTE): Rewrite to handle indirect buffers (Bug#8219).
1134 These macros can no longer be used for assignment.
1136 * buffer.c (Fget_buffer_create, Fmake_indirect_buffer):
1137 Assign struct members directly, instead of using BUF_BEGV etc.
1138 (record_buffer_markers, fetch_buffer_markers): New functions for
1139 recording and fetching special buffer markers.
1140 (set_buffer_internal_1, set_buffer_temp): Use them.
1142 * lread.c (unreadchar): Use SET_BUF_PT_BOTH.
1144 * insdel.c (adjust_point): Use SET_BUF_PT_BOTH.
1146 * intervals.c (temp_set_point_both): Use SET_BUF_PT_BOTH.
1147 (get_local_map): Use SET_BUF_BEGV_BOTH and SET_BUF_ZV_BOTH.
1149 * xdisp.c (hscroll_window_tree):
1150 (reconsider_clip_changes): Use PT instead of BUF_PT.
1152 2011-03-13 Eli Zaretskii <eliz@gnu.org>
1154 * makefile.w32-in ($(BLD)/editfns.$(O)): Depend on
1155 $(EMACS_ROOT)/lib/intprops.h.
1157 2011-03-13 Paul Eggert <eggert@cs.ucla.edu>
1159 Fix more problems found by GCC 4.5.2's static checks.
1161 * gtkutil.c (xg_get_pixbuf_from_pixmap): Add cast from char *
1162 to unsigned char * to avoid compiler diagnostic.
1163 (xg_free_frame_widgets): Make it clear that a local variable is
1164 needed only if USE_GTK_TOOLTIP.
1165 (gdk_window_get_screen): Make it clear that this macro is needed
1166 only if USE_GTK_TOOLTIP.
1167 (int_gtk_range_get_value): New function, which avoids a diagnostic
1168 from gcc -Wbad-function-cast.
1169 (xg_set_toolkit_scroll_bar_thumb): Use it.
1170 (xg_tool_bar_callback, xg_tool_item_stale_p): Rewrite to avoid
1171 diagnostic from gcc -Wbad-function-cast.
1172 (get_utf8_string, xg_get_file_with_chooser):
1173 Rename locals to avoid shadowing.
1174 (create_dialog): Move locals to avoid shadowing.
1176 * xgselect.c (xg_select): Remove unused var.
1178 * image.c (four_corners_best): Mark locals as initialized.
1179 (gif_load): Initialize transparent_p to zero (Bug#8238).
1180 Mark another local as initialized.
1181 (my_png_error, my_error_exit): Mark with NO_RETURN.
1183 * image.c (clear_image_cache): Now static.
1184 (DIM, HAVE_STDLIB_H_1): Remove unused macros.
1185 (xpm_load): Redo to avoid "discards qualifiers" gcc warning.
1186 (x_edge_detection): Remove unnecessary cast that
1187 gcc -Wbad-function-cast diagnoses.
1188 (gif_load): Fix pointer signedness.
1189 (clear_image_cache, xbm_read_bitmap_data, x_detect_edges):
1190 (jpeg_load, gif_load): Rename locals to avoid shadowing.
1192 2011-03-12 Paul Eggert <eggert@cs.ucla.edu>
1194 Improve quality of tests for time stamp overflow.
1195 For example, without this patch (encode-time 0 0 0 1 1
1196 1152921504606846976) returns the obviously-bogus value (-948597
1197 62170) on my RHEL 5.5 x86-64 host. With the patch, it correctly
1198 reports time overflow. See
1199 <http://lists.gnu.org/archive/html/emacs-devel/2011-03/msg00470.html>.
1200 * deps.mk (editfns.o): Depend on ../lib/intprops.h.
1201 * editfns.c: Include limits.h and intprops.h.
1202 (TIME_T_MIN, TIME_T_MAX): New macros.
1203 (time_overflow): Move earlier, to before first use.
1204 (hi_time, lo_time): New functions, for an accurate test for
1206 (Fcurrent_time, Fget_internal_run_time, make_time): Use them.
1207 (Fget_internal_run_time): Don't assume time_t fits in int.
1208 (make_time): Use list2 instead of Fcons twice.
1209 (Fdecode_time): More accurate test for out-of-range times.
1210 (check_tm_member): New function.
1211 (Fencode_time): Use it, to test for out-of-range times.
1212 (lisp_time_argument): Don't rely on undefined left-shift and
1213 right-shift behavior when checking for time stamp overflow.
1215 * editfns.c (time_overflow): New function, refactoring common code.
1216 (Fformat_time_string, Fdecode_time, Fencode_time):
1217 (Fcurrent_time_string): Use it.
1219 Move 'make_time' to be next to its inverse 'lisp_time_argument'.
1220 * dired.c (make_time): Move to ...
1221 * editfns.c (make_time): ... here.
1222 * systime.h: Note the move.
1224 2011-03-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
1226 * fringe.c (update_window_fringes): Remove unused variables.
1228 * unexmacosx.c (copy_data_segment): Also copy __got section.
1231 2011-03-12 Eli Zaretskii <eliz@gnu.org>
1233 * termcap.c [MSDOS]: Include "msdos.h".
1234 (find_capability, tgetnum, tgetflag, tgetstr, tputs, tgetent):
1235 Constify `char *' arguments and their references according to
1236 prototypes in tparam.h.
1238 * deps.mk (termcap.o): Depend on tparam.h and msdos.h.
1240 * msdos.c (XMenuAddPane): 3rd argument is `const char *' now.
1241 Adapt all references accordingly.
1243 * msdos.h (XMenuAddPane): 3rd argument is `const char *' now.
1245 2011-03-11 Tom Tromey <tromey@redhat.com>
1247 * buffer.c (syms_of_buffer): Remove obsolete comment.
1249 2011-03-11 Eli Zaretskii <eliz@gnu.org>
1251 * termhooks.h (encode_terminal_code): Declare prototype.
1253 * msdos.c (encode_terminal_code): Don't declare prototype.
1255 * term.c (encode_terminal_code): Now external again, used by
1256 w32console.c and msdos.c.
1258 * makefile.w32-in ($(BLD)/term.$(O), ($(BLD)/tparam.$(O)):
1259 Depend on $(SRC)/tparam.h, see 2011-03-11T07:24:21Z!eggert@cs.ucla.edu.
1261 2011-03-11 Paul Eggert <eggert@cs.ucla.edu>
1263 Fix some minor problems found by GCC 4.5.2's static checks.
1265 * fringe.c (update_window_fringes): Mark locals as initialized
1267 (destroy_fringe_bitmap, init_fringe_bitmap): Now static.
1269 * alloc.c (mark_fringe_data): Move decl from here ...
1270 * lisp.h (mark_fringe_data) [HAVE_WINDOW_SYSTEM]: ... to here,
1271 to check its interface.
1272 (init_fringe_once): Do not declare unless HAVE_WINDOW_SYSTEM.
1274 * fontset.c (free_realized_fontset): Now static.
1275 (Fset_fontset_font): Rename local to avoid shadowing.
1276 (fontset_font): Mark local as initialized.
1277 (FONTSET_SPEC, FONTSET_REPERTORY, RFONT_DEF_REPERTORY): Remove; unused.
1279 * xrdb.c: Include "xterm.h", to check x_load_resources's interface.
1281 * xselect.c (x_disown_buffer_selections): Remove; not used.
1282 (TRACE3) [!defined TRACE_SELECTION]: Remove; not used.
1283 (x_own_selection, Fx_disown_selection_internal): Rename locals
1285 (x_handle_dnd_message): Remove local to avoid shadowing.
1287 * lisp.h (GCPRO1_VAR, UNGCPRO_VAR): New macros,
1288 so that the caller can use some name other than gcpro1.
1289 (GCPRO1, UNGCPRO): Reimplement in terms of the new macros.
1290 * xfns.c (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
1291 (Fx_backspace_delete_keys_p):
1292 Use them to avoid shadowing, and rename vars to avoid shadowing.
1293 (x_decode_color, x_set_name, x_window): Now static.
1294 (Fx_create_frame): Add braces to silence GCC warning.
1295 (Fx_file_dialog, Fx_select_font): Fix pointer signedness.
1296 (x_real_positions, xg_set_icon_from_xpm_data, x_create_tip_frame):
1297 Remove unused locals.
1298 (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
1299 (Fx_backspace_delete_keys_p): Rename locals to avoid shadowing.
1300 Some of these renamings use the new GCPRO1_VAR and UNGCPRO_VAR
1303 * xterm.h (x_mouse_leave): New decl.
1305 * xterm.c (x_copy_dpy_color, x_focus_on_frame, x_unfocus_frame):
1306 Remove unused functions.
1307 (x_shift_glyphs_for_insert, XTflash, XTring_bell):
1308 (x_calc_absolute_position): Now static.
1309 (XTread_socket): Don't define label "out" unless it's used.
1310 Don't declare local "event" unless it's used.
1311 (x_iconify_frame, x_free_frame_resources): Don't declare locals
1312 unless they are used.
1313 (XEMBED_VERSION, xembed_set_info): Don't define unless needed.
1314 (x_fatal_error_signal): Remove; not used.
1315 (x_draw_image_foreground, redo_mouse_highlight, XTmouse_position):
1316 (x_scroll_bar_report_motion, handle_one_xevent, x_draw_bar_cursor):
1317 (x_error_catcher, x_connection_closed, x_error_handler):
1318 (x_error_quitter, xembed_send_message, x_iconify_frame):
1319 (my_log_handler): Rename locals to avoid shadowing.
1320 (x_delete_glyphs, x_ins_del_lines): Mark with NO_RETURN.
1321 (x_connection_closed): Tell GCC not to suggest NO_RETURN.
1323 * xfaces.c (clear_face_cache, Fx_list_fonts, Fface_font):
1324 Rename or move locals to avoid shadowing.
1325 (tty_defined_color, merge_face_heights): Now static.
1326 (free_realized_faces_for_fontset): Remove; not used.
1327 (Fx_list_fonts): Mark variable that gcc -Wuninitialized
1328 does not deduce is never used uninitialized.
1329 (STRDUPA, LSTRDUPA, FONT_POINT_SIZE_QUANTUM): Remove; not used.
1330 (LFACEP): Define only if XASSERTS, as it's not needed otherwise.
1332 * terminal.c (store_terminal_param): Now static.
1334 * xmenu.c (menu_highlight_callback): Now static.
1335 (set_frame_menubar): Remove unused local.
1336 (xmenu_show): Rename parameter to avoid shadowing.
1337 (xmenu_show, xdialog_show, xmenu_show): Make local pointers "const"
1338 since they might point to immutable storage.
1339 (next_menubar_widget_id): Declare only if USE_X_TOOLKIT,
1340 since it's unused otherwise.
1342 * xdisp.c (produce_glyphless_glyph): Initialize lower_xoff.
1343 Add a FIXME, since the code still doesn't look right. (Bug#8215)
1344 (Fcurrent_bidi_paragraph_direction): Simplify slightly; this
1345 avoids a gcc -Wuninitialized diagnostic.
1346 (display_line, BUILD_COMPOSITE_GLYPH_STRING, draw_glyphs):
1347 (note_mouse_highlight): Mark variables that gcc -Wuninitialized
1348 does not deduce are never used uninitialized.
1350 * lisp.h (IF_LINT): New macro, copied from ../lib-src/emacsclient.c.
1352 * xdisp.c (redisplay_window): Rename local to avoid shadowing.
1353 * window.c (window_loop, size_window):
1354 (run_window_configuration_change_hook, enlarge_window): Likewise.
1356 * window.c (display_buffer): Now static.
1357 (size_window): Mark variables that gcc -Wuninitialized
1358 does not deduce are never used uninitialized.
1359 * window.h (check_all_windows): New decl, to forestall
1360 gcc -Wmissing-prototypes diagnostic.
1361 * dispextern.h (bidi_dump_cached_states): Likewise.
1363 * charset.h (CHECK_CHARSET_GET_CHARSET): Rename locals to avoid
1365 * charset.c (map_charset_for_dump, Fchar_charset): Likewise.
1367 (Fsort_charsets): Redo min/max calculation to shorten the code a bit
1368 and to avoid gcc -Wuninitialized warning.
1369 (load_charset_map): Mark variables that gcc -Wuninitialized
1370 does not deduce are never used uninitialized.
1371 (load_charset): Abort instead of using uninitialized var (Bug#8229).
1373 * coding.c (coding_set_source, coding_set_destination):
1374 Use "else { /* comment */ }" rather than "else /* comment */;"
1375 for clarity, and to avoid gcc -Wempty-body warning.
1376 (Fdefine_coding_system_internal): Don't redeclare 'i' inside
1377 a block, when the outer 'i' will do.
1378 (decode_coding_utf_8, decode_coding_utf_16, detect_coding_emacs_mule):
1379 (emacs_mule_char, decode_coding_emacs_mule, detect_coding_iso_2022):
1380 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5):
1381 (decode_coding_raw_text, decode_coding_charset, get_translation_table):
1382 (Fdecode_sjis_char, Fdefine_coding_system_internal):
1383 Rename locals to avoid shadowing.
1384 * character.h (FETCH_STRING_CHAR_ADVANCE): Likewise.
1385 * coding.c (emacs_mule_char, encode_invocation_designation):
1386 Now static, since they're not used elsewhere.
1387 (decode_coding_iso_2022): Add "default: abort ();" as a safety check.
1388 (decode_coding_object, encode_coding_object, detect_coding_system):
1389 (decode_coding_emacs_mule): Mark variables that gcc
1390 -Wuninitialized does not deduce are never used uninitialized.
1391 (detect_coding_iso_2022): Initialize a local variable that might
1392 be used uninitialized. Leave a FIXME because it's not clear that
1393 this initialization is needed. (Bug#8211)
1394 (ISO_CODE_LF, ISO_CODE_CR, CODING_ISO_FLAG_EUC_TW_SHIFT):
1395 (ONE_MORE_BYTE_NO_CHECK, UTF_BOM, UTF_16_INVALID_P):
1396 (SHIFT_OUT_OK, ENCODE_CONTROL_SEQUENCE_INTRODUCER):
1397 (ENCODE_DIRECTION_R2L, ENCODE_DIRECTION_L2R):
1398 Remove unused macros.
1400 * category.c (hash_get_category_set): Remove unused local var.
1401 (copy_category_table): Now static, since it's not used elsewhere.
1402 * character.c (string_count_byte8): Likewise.
1404 * ccl.c (CCL_WRITE_STRING, CCL_ENCODE_CHAR, Fccl_execute_on_string):
1405 (Fregister_code_conversion_map): Rename locals to avoid shadowing.
1407 * chartab.c (copy_sub_char_table): Now static, since it's not used
1409 (sub_char_table_ref_and_range, char_table_ref_and_range):
1410 Rename locals to avoid shadowing.
1411 (ASET_RANGE, GET_SUB_CHAR_TABLE): Remove unused macros.
1413 * bidi.c (bidi_check_type): Now static, since it's not used elsewhere.
1414 (BIDI_BOB): Remove unused macro.
1416 * cm.c (cmgoto): Mark variables that gcc -Wuninitialized does not
1417 deduce are never used uninitialized.
1418 * term.c (encode_terminal_code): Likewise.
1420 * term.c (encode_terminal_code): Now static. Remove unused local.
1422 * tparam.h: New file.
1423 * term.c, tparam.h: Include it.
1424 * deps.mk (term.o, tparam.o): Depend on tparam.h.
1425 * term.c (tputs, tgetent, tgetflag, tgetnum, tparam, tgetstr):
1426 Move these decls to tparam.h, and make them agree with what
1427 is actually in tparam.c. The previous trick of using incompatible
1428 decls in different modules does not conform to the C standard.
1429 All callers of tparam changed to use tparam's actual API.
1430 * tparam.c (tparam1, tparam, tgoto):
1431 Use const pointers where appropriate.
1433 * cm.c (calccost, cmgoto): Use const pointers where appropriate.
1434 * cm.h (struct cm): Likewise.
1435 * dispextern.h (do_line_insertion_deletion_costs): Likewise.
1436 * scroll.c (ins_del_costs, do_line_insertion_deletion_costs): Likewise.
1437 * term.c (tty_ins_del_lines, calculate_costs, struct fkey_table):
1438 (term_get_fkeys_1, append_glyphless_glyph, produce_glyphless_glyph):
1439 (turn_on_face, init_tty): Likewise.
1440 * termchar.h (struct tty_display_info): Likewise.
1442 * term.c (term_mouse_position): Rename local to avoid shadowing.
1444 * alloc.c (mark_ttys): Move decl from here ...
1445 * lisp.h (mark_ttys): ... to here, so that it's checked against defn.
1447 2011-03-11 Andreas Schwab <schwab@linux-m68k.org>
1449 * .gdbinit (pwinx, xbuffer): Fix access to buffer name.
1451 2011-03-09 Juanma Barranquero <lekktu@gmail.com>
1453 * search.c (compile_pattern_1): Remove argument regp, unused since
1454 revid:rms@gnu.org-19941211082627-3x1g1wyqkjmwloig.
1455 (compile_pattern): Don't pass it.
1457 2011-03-08 Jan Djärv <jan.h.d@swipnet.se>
1459 * xterm.h (DEFAULT_GDK_DISPLAY): New define.
1460 (GDK_WINDOW_XID, gtk_widget_get_preferred_size): New defines
1462 (GTK_WIDGET_TO_X_WIN): Use GDK_WINDOW_XID.
1464 * xmenu.c (menu_position_func): Call gtk_widget_get_preferred_size.
1466 * gtkutil.c: Include gtkx.h if HAVE_GTK3. If ! HAVE_GTK3, define
1467 gdk_window_get_screen, gdk_window_get_geometry,
1468 gdk_x11_window_lookup_for_display and GDK_KEY_g.
1469 (xg_set_screen): Use DEFAULT_GDK_DISPLAY.
1470 (xg_get_pixbuf_from_pixmap): New function.
1471 (xg_get_pixbuf_from_pix_and_mask): Change parameters from GdkPixmap
1472 to Pixmap, take frame as parameter, remove GdkColormap parameter.
1473 Call xg_get_pixbuf_from_pixmap instead of
1474 gdk_pixbuf_get_from_drawable.
1475 (xg_get_image_for_pixmap): Do not make GdkPixmaps, call
1476 xg_get_pixbuf_from_pix_and_mask with Pixmap parameters instead.
1477 (xg_check_special_colors): Use GtkStyleContext and its functions
1479 (xg_prepare_tooltip, xg_hide_tooltip): Call gdk_window_get_screen.
1480 (xg_prepare_tooltip, create_dialog, menubar_map_cb)
1481 (xg_update_frame_menubar, xg_tool_bar_detach_callback)
1482 (xg_tool_bar_attach_callback, xg_update_tool_bar_sizes):
1483 Call gtk_widget_get_preferred_size.
1484 (xg_frame_resized): gdk_window_get_geometry only takes 5
1486 (xg_win_to_widget, xg_event_is_for_menubar):
1487 Call gdk_x11_window_lookup_for_display.
1488 (xg_set_widget_bg): New function.
1489 (delete_cb): New function.
1490 (xg_create_frame_widgets): connect delete-event to delete_cb.
1491 Call xg_set_widget_bg. Only set backgrund pixmap for ! HAVE_GTK3
1492 (xg_set_background_color): Call xg_set_widget_bg.
1493 (xg_set_frame_icon): Call xg_get_pixbuf_from_pix_and_mask.
1494 (xg_create_scroll_bar): vadj is a GtkAdjustment for HAVE_GTK3.
1495 Only call gtk_range_set_update_policy if ! HAVE_GTK3.
1496 (xg_make_tool_item): Only connect xg_tool_bar_item_expose_callback
1498 (update_frame_tool_bar): Call gtk_widget_hide.
1499 (xg_initialize): Use GDK_KEY_g.
1501 * xsmfns.c (gdk_set_sm_client_id): Define to gdk_set_sm_client_id
1503 (x_session_initialize): Call gdk_x11_set_sm_client_id.
1505 * xterm.c (XFillRectangle): Use cairo routines for HAVE_GTK3.
1506 (x_term_init): Disable Xinput(2) with GDK_CORE_DEVICE_EVENTS.
1507 Load ~/emacs.d/gtkrc only for ! HAVE_GTK3.
1509 2011-03-08 Juanma Barranquero <lekktu@gmail.com>
1511 * w32xfns.c (select_palette): Check success of RealizePalette against
1512 GDI_ERROR, not zero.
1514 See ChangeLog.11 for earlier changes.
1520 Copyright (C) 2011 Free Software Foundation, Inc.
1522 This file is part of GNU Emacs.
1524 GNU Emacs is free software: you can redistribute it and/or modify
1525 it under the terms of the GNU General Public License as published by
1526 the Free Software Foundation, either version 3 of the License, or
1527 (at your option) any later version.
1529 GNU Emacs is distributed in the hope that it will be useful,
1530 but WITHOUT ANY WARRANTY; without even the implied warranty of
1531 MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
1532 GNU General Public License for more details.
1534 You should have received a copy of the GNU General Public License
1535 along with GNU Emacs. If not, see <http://www.gnu.org/licenses/>.