1 2011-06-06 Paul Eggert <eggert@cs.ucla.edu>
3 Check for buffer and string overflow more precisely.
4 * buffer.h (BUF_BYTES_MAX): New macro.
5 * lisp.h (STRING_BYTES_MAX): New macro.
6 * alloc.c (Fmake_string):
7 * character.c (string_escape_byte8):
8 * coding.c (coding_alloc_by_realloc):
10 * editfns.c (Fformat):
12 Use STRING_BYTES_MAX, not MOST_POSITIVE_FIXNUM,
13 since they may not be the same number.
14 * editfns.c (Finsert_char):
15 * fileio.c (Finsert_file_contents):
16 Likewise for BUF_BYTES_MAX.
18 * image.c: Use ptrdiff_t, not int, for sizes.
19 (slurp_file): Switch from int to ptrdiff_t.
21 (slurp_file): Check that file size fits in both size_t (for
22 malloc) and ptrdiff_t (for sanity and safety).
24 * fileio.c (Fverify_visited_file_modtime): Avoid time overflow
25 if b->modtime has its maximal value.
27 * dired.c (Ffile_attributes): Don't assume EMACS_INT has >32 bits.
29 Don't assume time_t can fit into int.
30 * buffer.h (struct buffer.modtime): Now time_t, not int.
31 * fileio.c (Fvisited_file_modtime): No need for time_t cast now.
32 * undo.c (Fprimitive_undo): Use time_t, not int, for time_t value.
34 Minor fixes for signed vs unsigned integers.
35 * character.h (MAYBE_UNIFY_CHAR):
36 * charset.c (maybe_unify_char):
37 * keyboard.c (read_char, reorder_modifiers):
38 XINT -> XFASTINT, since the integer must be nonnegative.
39 * ftfont.c (ftfont_spec_pattern):
40 * keymap.c (access_keymap, silly_event_symbol_error):
41 XUINT -> XFASTINT, since the integer must be nonnegative.
42 (Fsingle_key_description, preferred_sequence_p): XUINT -> XINT,
43 since it makes no difference and we prefer signed.
44 * keyboard.c (record_char): Use XUINT when all the neighbors do.
45 (access_keymap): NATNUMP -> INTEGERP, since the integer must be
48 2011-06-06 Paul Eggert <eggert@cs.ucla.edu>
50 * alloc.c (memory_full) [SYSTEM_MALLOC]: Port to MacOS (Bug#8800).
51 Do not assume that spare memory exists; that assumption is valid
52 only if SYSTEM_MALLOC.
53 (LARGE_REQUEST): New macro, so that the issue of large requests
54 is separated from the issue of spare memory.
56 2011-06-05 Andreas Schwab <schwab@linux-m68k.org>
58 * editfns.c (Fformat): Correctly handle zero flag with hexadecimal
61 * gtkutil.c (xg_get_default_scrollbar_width): Avoid warning.
63 * xfns.c (x_set_scroll_bar_default_width): Move declarations
66 2011-06-05 Jan Djärv <jan.h.d@swipnet.se>
68 * gtkutil.c (xg_get_default_scrollbar_width): New function.
70 * gtkutil.h: Declare xg_get_default_scrollbar_width.
72 * xfns.c (x_set_scroll_bar_default_width): If USE_GTK, get
73 min width by calling x_set_scroll_bar_default_width (Bug#8505).
75 2011-06-05 Juanma Barranquero <lekktu@gmail.com>
77 * xdisp.c (single_display_spec_intangible_p): Remove declaration.
79 2011-06-04 Chong Yidong <cyd@stupidchicken.com>
81 * xselect.c (x_clipboard_manager_save): Remove redundant arg.
82 (x_clipboard_manager_save): Add return value.
83 (x_clipboard_manager_error_1, x_clipboard_manager_error_2): New
85 (x_clipboard_manager_save_frame, x_clipboard_manager_save_all):
86 Obey Vx_select_enable_clipboard_manager. Catch errors in
87 x_clipboard_manager_save (Bug#8779).
88 (Vx_select_enable_clipboard_manager): New variable.
89 (x_get_foreign_selection): Reduce scope of x_catch_errors (Bug#8790).
91 2011-06-04 Dan Nicolaescu <dann@ics.uci.edu>
93 * emacs.c (main): Warn when starting a GTK emacs in daemon mode.
95 2011-06-04 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
97 * fringe.c (update_window_fringes): Don't update overlay arrow bitmap
98 in the current matrix if keep_current_p is non-zero.
100 2011-06-04 Eli Zaretskii <eliz@gnu.org>
102 * bidi.c (bidi_level_of_next_char): Fix last change.
104 2011-06-03 Eli Zaretskii <eliz@gnu.org>
106 Support bidi reordering of text covered by display properties.
108 * bidi.c (bidi_copy_it): Use offsetof instead of emulating it.
109 (bidi_fetch_char, bidi_fetch_char_advance): New functions.
110 (bidi_cache_search, bidi_cache_iterator_state)
111 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak)
112 (bidi_level_of_next_char, bidi_move_to_visually_next): Support
113 character positions inside a run of characters covered by a
115 (bidi_paragraph_init, bidi_resolve_explicit_1)
116 (bidi_level_of_next_char): Call bidi_fetch_char and
117 bidi_fetch_char_advance instead of FETCH_CHAR and
119 (bidi_init_it): Initialize new members.
120 (LRE_CHAR, RLE_CHAR, PDF_CHAR, LRO_CHAR, RLO_CHAR): Remove macro
122 (bidi_explicit_dir_char): Lookup character type in bidi_type_table,
123 instead of using explicit *_CHAR codes.
124 (bidi_resolve_explicit, bidi_resolve_weak): Use
125 FETCH_MULTIBYTE_CHAR instead of FETCH_CHAR, as reordering of
126 bidirectional text is supported only in multibyte buffers.
127 (bidi_init_it): Accept additional argument FRAME_WINDOW_P and use
128 it to initialize the frame_window_p member of struct bidi_it.
129 (bidi_cache_iterator_state, bidi_resolve_explicit_1)
130 (bidi_resolve_explicit, bidi_resolve_weak)
131 (bidi_level_of_next_char, bidi_move_to_visually_next): Abort if
132 bidi_it->nchars is non-positive.
133 (bidi_level_of_next_char): Don't try to lookup the cache for the
134 next/previous character if nothing is cached there yet, or if we
135 were just reseat()'ed to a new position.
137 * xdisp.c (set_cursor_from_row): Set start and stop points
138 according to the row's direction when priming the loop that looks
139 for the glyph on which to display cursor.
140 (single_display_spec_intangible_p): Function deleted.
141 (display_prop_intangible_p): Reimplement to call
142 handle_display_spec instead of single_display_spec_intangible_p.
143 Accept 3 additional arguments needed by handle_display_spec. This
144 fixes incorrect cursor motion across display property with complex
145 values: lists, `(when COND...)' forms, etc.
146 (single_display_spec_string_p): Support property values that are
147 lists with the argument STRING its top-level element.
148 (display_prop_string_p): Fix the condition for processing a
149 property that is a list to be consistent with handle_display_spec.
150 (handle_display_spec): New function, refactored from the
151 last portion of handle_display_prop.
152 (compute_display_string_pos): Accept additional argument
153 FRAME_WINDOW_P. Call handle_display_spec to determine whether the
154 value of a `display' property is a "replacing spec".
155 (handle_single_display_spec): Accept 2 additional arguments BUFPOS
156 and FRAME_WINDOW_P. If IT is NULL, don't set up the iterator from
157 the display property, but just return a value indicating whether
158 the display property will replace the characters it covers.
159 (Fcurrent_bidi_paragraph_direction): Initialize the nchars and
160 frame_window_p members of struct bidi_it.
161 (compute_display_string_pos, compute_display_string_end): New
163 (push_it): Accept second argument POSITION, where pop_it should
164 jump to continue iteration.
165 (reseat_1): Initialize bidi_it.disp_pos.
167 * keyboard.c (adjust_point_for_property): Adjust the call to
168 display_prop_intangible_p to its new signature.
170 * dispextern.h (struct bidi_it): New member frame_window_p.
171 (bidi_init_it): Update prototypes.
172 (display_prop_intangible_p): Update prototype.
173 (compute_display_string_pos, compute_display_string_end): Declare
175 (struct bidi_it): New members nchars and disp_pos. ch_len is now
178 2011-06-02 Paul Eggert <eggert@cs.ucla.edu>
180 Malloc failure behavior now depends on size of allocation.
181 * alloc.c (buffer_memory_full, memory_full): New arg NBYTES.
182 * lisp.h: Change signatures accordingly.
183 * alloc.c, buffer.c, editfns.c, menu.c, minibuf.c, xterm.c:
184 All callers changed. (Bug#8762)
186 * gnutls.c: Use Emacs's memory allocators.
187 Without this change, the gnutls library would invoke malloc etc.
188 directly, which causes problems on non-SYNC_INPUT hosts, and which
189 runs afoul of improving memory_full behavior. (Bug#8761)
190 (fn_gnutls_global_set_mem_functions): New macro or function pointer.
191 (emacs_gnutls_global_init): Use it to specify xmalloc, xrealloc,
192 xfree instead of the default malloc, realloc, free.
193 (Fgnutls_boot): No need to check for memory allocation failure,
194 since xmalloc does that for us.
196 Remove arbitrary limit of 2**31 entries in hash tables. (Bug#8771)
197 * category.c (hash_get_category_set):
198 * ccl.c (ccl_driver):
199 * charset.c (Fdefine_charset_internal):
200 * charset.h (struct charset.hash_index):
201 * composite.c (get_composition_id, gstring_lookup_cache)
202 (composition_gstring_put_cache):
203 * composite.h (struct composition.hash_index):
204 * dispextern.h (struct image.hash):
205 * fns.c (next_almost_prime, larger_vector, cmpfn_eql)
206 (cmpfn_equal, cmpfn_user_defined, hashfn_eq, hashfn_eql)
207 (hashfn_equal, hashfn_user_defined, make_hash_table)
208 (maybe_resize_hash_table, hash_lookup, hash_put)
209 (hash_remove_from_table, hash_clear, sweep_weak_table, SXHASH_COMBINE)
210 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector)
211 (Fsxhash, Fgethash, Fputhash, Fmaphash):
212 * image.c (make_image, search_image_cache, lookup_image)
213 (xpm_put_color_table_h):
214 * lisp.h (struct Lisp_Hash_Table):
215 * minibuf.c (Ftry_completion, Fall_completions, Ftest_completion):
216 * print.c (print): Use 'EMACS_UINT' and 'EMACS_INT'
217 for hashes and hash indexes, instead of 'unsigned' and 'int'.
218 * alloc.c (allocate_vectorlike):
219 Check for overflow in vector size calculations.
220 * ccl.c (ccl_driver):
221 Check for overflow when converting EMACS_INT to int.
222 * fns.c, image.c: Remove unnecessary static decls that would otherwise
223 need to be updated by these changes.
224 * fns.c (make_hash_table, maybe_resize_hash_table):
225 Check for integer overflow with large hash tables.
226 (make_hash_table, maybe_resize_hash_table, Fmake_hash_table):
227 Prefer the faster XFLOAT_DATA to XFLOATINT where either will do.
228 (SXHASH_REDUCE): New macro.
229 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector):
230 Use it instead of discarding useful hash info with large hash values.
231 (sxhash_float): New function.
232 (sxhash): Use it. No more need for "& INTMASK" due to above changes.
233 * lisp.h (FIXNUM_BITS): New macro, useful for SXHASH_REDUCE etc.
234 (MOST_NEGATIVE_FIXNUM, MOST_POSITIVE_FIXNUM, INTMASK):
235 Rewrite to use FIXNUM_BITS, as this simplifies things.
236 (next_almost_prime, larger_vector, sxhash, hash_lookup, hash_put):
237 Adjust signatures to match updated version of code.
238 (consing_since_gc): Now EMACS_INT, since a single hash table can
239 use more than INT_MAX bytes.
241 2011-06-01 Dan Nicolaescu <dann@ics.uci.edu>
243 Make it possible to build with GCC-4.6+ -O2 -flto.
245 * emacs.c (__malloc_initialize_hook): Mark as EXTERNALLY_VISIBLE.
247 2011-06-01 Stefan Monnier <monnier@iro.umontreal.ca>
249 * minibuf.c (get_minibuffer, read_minibuf_unwind):
250 Call minibuffer-inactive-mode.
252 2011-05-31 Juanma Barranquero <lekktu@gmail.com>
254 * makefile.w32-in ($(BLD)/data.$(O), $(BLD)/editfns.$(O)):
257 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
259 * data.c (init_data): Remove code for UTS, this system is not
262 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
264 Don't force ./temacs to start in terminal mode.
266 * frame.c (make_initial_frame): Initialize faces in all cases, not
267 only when CANNOT_DUMP is defined.
268 * dispnew.c (init_display): Remove CANNOT_DUMP condition.
270 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
272 * dispnew.c (add_window_display_history): Use const for the string
273 pointer. Remove declaration, not needed.
275 2011-05-31 Paul Eggert <eggert@cs.ucla.edu>
277 Use 'inline', not 'INLINE'.
278 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00914.html>
279 * alloc.c, fontset.c (INLINE): Remove.
280 * alloc.c, bidi.c, charset.c, coding.c, dispnew.c, fns.c, image.c:
281 * intervals.c, keyboard.c, process.c, syntax.c, textprop.c, w32term.c:
282 * xdisp.c, xfaces.c, xterm.c: Replace all uses of INLINE with inline.
283 * gmalloc.c (register_heapinfo): Use inline unconditionally.
284 * lisp.h (LISP_MAKE_RVALUE): Use inline, not __inline__.
286 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
288 Make it possible to run ./temacs.
290 * callproc.c (set_initial_environment): Remove CANNOT_DUMP code,
291 syms_of_callproc does the same thing. Remove test for
292 "initialized", do it in the caller.
293 * emacs.c (main): Avoid calling set_initial_environment when dumping.
295 2011-05-31 Stefan Monnier <monnier@iro.umontreal.ca>
297 * minibuf.c (Finternal_complete_buffer): Return `category' metadata.
298 (read_minibuf): Use get_minibuffer.
299 (syms_of_minibuf): Use DEFSYM.
300 (Qmetadata): New var.
301 * data.c (Qbuffer): Don't make it static.
302 (syms_of_data): Use DEFSYM.
304 2011-05-31 Paul Eggert <eggert@cs.ucla.edu>
306 * ccl.c (CCL_CODE_RANGE): Allow negative numbers. (Bug#8751)
307 (CCL_CODE_MIN): New macro.
309 2011-05-30 Paul Eggert <eggert@cs.ucla.edu>
311 * alloc.c (lisp_align_malloc): Omit unnecessary val==NULL tests.
313 * eval.c (Qdebug): Now static.
314 * lisp.h (Qdebug): Remove decl. This reverts a part of the
315 2011-04-26T11:26:05Z!dan.colascione@gmail.com that inadvertently undid part of
316 2011-04-14T06:48:41Z!eggert@cs.ucla.edu.
318 2011-05-29 Chong Yidong <cyd@stupidchicken.com>
320 * image.c: Various fixes to ImageMagick code comments.
321 (Fimagemagick_types): Doc fix.
323 2011-05-29 Paul Eggert <eggert@cs.ucla.edu>
325 Minor fixes prompted by GCC 4.6.0 warnings.
327 * xselect.c (converted_selections, conversion_fail_tag): Now static.
329 * emacs.c [HAVE_X_WINDOWS]: Include "xterm.h".
330 (x_clipboard_manager_save_all): Move extern decl to ...
331 * xterm.h: ... here, so that it can be checked for consistency.
333 2011-05-29 Chong Yidong <cyd@stupidchicken.com>
335 * xselect.c (x_clipboard_manager_save_frame)
336 (x_clipboard_manager_save_all): New functions.
337 (Fx_clipboard_manager_save): Lisp function deleted.
339 * emacs.c (Fkill_emacs): Call x_clipboard_manager_save_all.
340 * frame.c (delete_frame): Call x_clipboard_manager_save_frame.
342 * xterm.h: Update prototype.
344 2011-05-28 William Xu <william.xwl@gmail.com>
346 * nsterm.m (ns_term_shutdown): Synchronize user defaults before
349 2011-05-28 Jim Meyering <meyering@redhat.com>
351 Avoid a sign-extension bug in crypto_hash_function.
352 * fns.c (to_uchar): Define.
353 (crypto_hash_function): Use it to convert some newly-signed
354 variables to unsigned, to avoid sign-extension bugs. For example,
355 without this change, (md5 "truc") would evaluate to
356 45723a2aff78ff4fff7fff1114760e62 rather than the expected
357 45723a2af3788c4ff17f8d1114760e62. Reported by Antoine Levitt in
358 https://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00883.html.
360 2011-05-27 Paul Eggert <eggert@cs.ucla.edu>
362 Integer overflow fixes.
364 * dbusbind.c: Serial number integer overflow fixes.
365 (CHECK_DBUS_SERIAL_GET_SERIAL): New macro.
366 (Fdbus_call_method_asynchronously, xd_read_message_1): Use a float
367 to hold a serial number that is too large for a fixnum.
368 (Fdbus_method_return_internal, Fdbus_method_error_internal):
369 Check for serial numbers out of range. Decode any serial number
370 that was so large that it became a float. (Bug#8722)
372 * dbusbind.c: Use XFASTINT rather than XUINT, and check for nonneg.
373 (Fdbus_call_method, Fdbus_call_method_asynchronously):
374 Use XFASTINT rather than XUINT when numbers are nonnegative.
375 (xd_append_arg, Fdbus_method_return_internal):
376 (Fdbus_method_error_internal): Likewise. Also, for unsigned
377 arguments, check that Lisp number is nonnegative, rather than
378 silently wrapping negative numbers around. (Bug#8722)
379 (xd_read_message_1): Don't assume dbus_uint32_t can fit in int.
382 * data.c (arith_driver, Flsh): Avoid unnecessary casts to EMACS_UINT.
384 * ccl.c (ccl_driver): Redo slightly to avoid the need for 'unsigned'.
386 ccl: add integer overflow checks
387 * ccl.c (CCL_CODE_MAX, GET_CCL_RANGE, GET_CCL_CODE, GET_CCL_INT):
388 (IN_INT_RANGE): New macros.
389 (ccl_driver): Use them to check for integer overflow when
390 decoding a CCL program. Many of the new checks are whether XINT (x)
391 fits in int; it doesn't always, on 64-bit hosts. The new version
392 doesn't catch all possible integer overflows, but it's an
393 improvement. (Bug#8719)
395 * alloc.c (make_event_array): Use XINT, not XUINT.
396 There's no need for unsigned here.
398 * mem-limits.h (EXCEEDS_LISP_PTR) [!USE_LSB_TAG]: EMACS_UINT -> uintptr_t
399 This follows up to the 2011-05-06 change that substituted uintptr_t
400 for EMACS_INT. This case wasn't caught back then.
402 Rework Fformat to avoid integer overflow issues.
403 * editfns.c: Include <float.h> unconditionally, as it's everywhere
404 now (part of C89). Include <verify.h>.
405 (MAX_10_EXP, CONVERTED_BYTE_SIZE): Remove; no longer needed.
406 (pWIDE, pWIDElen, signed_wide, unsigned_wide): New defns.
407 (Fformat): Avoid the prepass trying to compute sizes; it was only
408 approximate and thus did not catch overflow reliably. Instead, walk
409 through the format just once, formatting and computing sizes as we go,
410 checking for integer overflow at every step, and allocating a larger
411 buffer as needed. Keep track separately whether the format is
412 multibyte. Keep only the most-recently calculated precision, rather
413 than them all. Record whether each argument has been converted to
414 string. Use EMACS_INT, not int, for byte and char and arg counts.
415 Support field widths and precisions larger than INT_MAX. Avoid
416 sprintf's undefined behavior with conversion specifications such as %#d
417 and %.0c. Fix bug with strchr succeeding on '\0' when looking for
418 flags. Fix bug with (format "%c" 256.0). Avoid integer overflow when
419 formatting out-of-range floating point numbers with int
422 * lisp.h (FIXNUM_OVERFLOW_P): Work even if arg is a NaN.
424 * data.c: Avoid integer truncation in expressions involving floats.
425 * data.c: Include <intprops.h>.
426 (arith_driver): When there's an integer overflow in an expression
427 involving floating point, convert the integers to floating point
428 so that the resulting value does not suffer from catastrophic
429 integer truncation. For example, on a 64-bit host (* 4
430 most-negative-fixnum 0.5) should yield about -4.6e+18, not zero.
431 Do not rely on undefined behavior after integer overflow.
433 merge count_size_as_multibyte, parse_str_to_multibyte
434 * character.c, character.h (count_size_as_multibyte):
435 Rename from parse_str_to_multibyte; all uses changed.
436 Check for integer overflow.
437 * insdel.c, lisp.h (count_size_as_multibyte): Remove,
438 since it's now a duplicate of the other. This is more of
439 a character than a buffer op, so better that it's in character.c.
440 * fns.c, print.c: Adjust to above changes.
442 2011-05-27 Stefan Monnier <monnier@iro.umontreal.ca>
444 * xselect.c (x_convert_selection): Yet another int/Lisp_Object mixup.
446 2011-05-27 Paul Eggert <eggert@cs.ucla.edu>
448 * xselect.c: Fix minor problems prompted by GCC 4.6.0 warnings.
449 (x_handle_selection_request, frame_for_x_selection): Remove unused vars.
450 (x_clipboard_manager_save): Now static.
451 (Fx_clipboard_manager_save): Rename local to avoid shadowing.
453 * fns.c: Fix minor problems prompted by GCC 4.6.0 warnings.
454 (crypto_hash_function): Now static.
455 Fix pointer signedness problems. Avoid unnecessary initializations.
457 2011-05-27 Chong Yidong <cyd@stupidchicken.com>
459 * termhooks.h (Vselection_alist): Make it terminal-local.
461 * terminal.c (create_terminal): Initialize it.
463 * xselect.c: Support for clipboard managers.
464 (Vselection_alist): Move to termhooks.h as terminal-local var.
465 (LOCAL_SELECTION): New macro.
466 (x_atom_to_symbol): Handle x_display_info_for_display fail case.
467 (symbol_to_x_atom): Remove gratuitous arg.
468 (x_handle_selection_request, lisp_data_to_selection_data)
469 (x_get_foreign_selection, Fx_register_dnd_atom): Callers changed.
470 (x_own_selection, x_get_local_selection, x_convert_selection):
471 New arg, specifying work frame. Use terminal-local Vselection_alist.
472 (some_frame_on_display): Delete unused function.
473 (Fx_own_selection_internal, Fx_get_selection_internal)
474 (Fx_disown_selection_internal, Fx_selection_owner_p)
475 (Fx_selection_exists_p): New optional frame arg.
476 (frame_for_x_selection, Fx_clipboard_manager_save): New functions.
477 (x_handle_selection_clear): Don't treat other terminals with the
478 same keyboard specially. Use the terminal-local Vselection_alist.
479 (x_clear_frame_selections): Use Frun_hook_with_args.
481 * xterm.c (x_term_init): Intern ATOM and CLIPBOARD_MANAGER atoms.
483 * xterm.h: Add support for those atoms.
485 2011-05-26 Chong Yidong <cyd@stupidchicken.com>
487 * xselect.c: ICCCM-compliant handling of MULTIPLE targets.
488 (converted_selections, conversion_fail_tag): New global variables.
489 (x_selection_request_lisp_error): Free the above.
490 (x_get_local_selection): Remove unnecessary code.
491 (x_reply_selection_request): Args changed; handle arbitrary array
492 of converted selections stored in converted_selections.
493 Separate the XChangeProperty and SelectionNotify steps.
494 (x_handle_selection_request): Rewrite to handle MULTIPLE target.
495 (x_convert_selection): New function.
496 (x_handle_selection_event): Simplify.
497 (x_get_foreign_selection): Don't ignore incoming requests while
498 waiting for an answer; this will fail when we implement
499 SAVE_TARGETS, and seems unnecessary anyway.
500 (selection_data_to_lisp_data): Recognize ATOM_PAIR type.
501 (Vx_sent_selection_functions): Doc fix.
503 2011-05-26 Leo Liu <sdl.web@gmail.com>
505 * editfns.c (Ftranspose_regions): Allow empty regions. (Bug#8699)
507 2011-05-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
509 * dispextern.h (struct glyph_row): New member fringe_bitmap_periodic_p.
511 * dispnew.c (shift_glyph_matrix, scrolling_window): Mark scrolled row
512 for fringe update if it has periodic bitmap.
513 (row_equal_p): Also compare left_fringe_offset, right_fringe_offset,
514 and fringe_bitmap_periodic_p.
516 * fringe.c (get_fringe_bitmap_data): New function.
517 (draw_fringe_bitmap_1, update_window_fringes): Use it.
518 (update_window_fringes): Record periodicity of fringe bitmap in glyph
519 row. Mark glyph row for fringe update if periodicity changed.
521 * xdisp.c (try_window_reusing_current_matrix): Don't mark scrolled row
522 for fringe update unless it has periodic bitmap.
524 2011-05-25 Kenichi Handa <handa@m17n.org>
526 * xdisp.c (get_next_display_element): Set correct it->face_id for
527 a static composition.
529 2011-05-24 Leo Liu <sdl.web@gmail.com>
532 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha1.h.
534 * fns.c (crypto_hash_function, Fsha1): New function.
535 (Fmd5): Use crypto_hash_function.
536 (syms_of_fns): Add Ssha1.
538 2011-05-22 Paul Eggert <eggert@cs.ucla.edu>
540 * gnutls.c: Remove unused macros.
541 (fn_gnutls_transport_set_lowat, fn_gnutls_transport_set_pull_function):
542 (fn_gnutls_transport_set_push_function) [!WINDOWSNT]:
543 Remove macros that are defined and never used.
544 Caught by gcc -Wunused-macros (GCC 4.6.0, Fedora 14).
546 2011-05-22 Chong Yidong <cyd@stupidchicken.com>
548 * xselect.c (syms_of_xselect): Remove unused symbol SAVE_TARGETS.
549 (Fx_get_selection_internal): Minor cleanup.
550 (Fx_own_selection_internal): Rename arguments for consistency with
553 2011-05-22 Paul Eggert <eggert@cs.ucla.edu>
555 * xselect.c (QSAVE_TARGETS): New static var, to fix build failure.
557 2011-05-22 Chong Yidong <cyd@stupidchicken.com>
559 * xselect.c (syms_of_xselect): Include character.h; use DEFSYM.
561 2011-05-21 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
563 * dispnew.c (scrolling_window): Don't exclude the case that the
564 last enabled row in the desired matrix touches the bottom boundary.
566 2011-05-21 Glenn Morris <rgm@gnu.org>
568 * Makefile.in ($(etc)/DOC): Make second command line even shorter.
569 (SOME_MACHINE_OBJECTS): Replace FONT_OBJ by its maximal expansion,
570 and add some more files.
572 2011-05-20 Eli Zaretskii <eliz@gnu.org>
574 * callproc.c (Fcall_process) [MSDOS]: Fix arguments to
575 report_file_error introduced by the change from 2011-05-07.
577 2011-05-20 Paul Eggert <eggert@cs.ucla.edu>
579 * systime.h (Time): Define only if emacs is defined.
580 This is to allow ../lib-src/profile.c to be compiled on FreeBSD,
581 where the include path doesn't have X11/X.h by default. See
582 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00561.html>.
584 2011-05-20 Kenichi Handa <handa@m17n.org>
586 * composite.c (find_automatic_composition): Fix previous change.
588 2011-05-20 Glenn Morris <rgm@gnu.org>
590 * lisp.mk: New file, split from Makefile.in.
591 * Makefile.in (lisp): Move to separate file, inserted by @lisp_frag@.
593 ($(etc)/DOC): Edit lisp.mk rather than using $shortlisp.
595 2011-05-19 Glenn Morris <rgm@gnu.org>
597 * Makefile.in (MSDOS_SUPPORT_REAL, MSDOS_SUPPORT, NS_SUPPORT)
598 (REAL_MOUSE_SUPPORT, GPM_MOUSE_SUPPORT, MOUSE_SUPPORT, TOOLTIP_SUPPORT)
599 (BASE_WINDOW_SUPPORT, X_WINDOW_SUPPORT, WINDOW_SUPPORT): Remove.
600 (lisp): Set the order to that of loadup.el.
601 (shortlisp): Make it a copy of $lisp.
602 (SOME_MACHINE_LISP): Remove.
603 ($(etc)/DOC): Depend just on $lisp, not $SOME_MACHINE_LISP too.
604 Use just $shortlisp, not $SOME_MACHINE_LISP too.
606 2011-05-18 Kenichi Handa <handa@m17n.org>
608 * composite.c (CHAR_COMPOSABLE_P): Add more check for efficiency.
609 (BACKWARD_CHAR): Wrap the arg STOP by parenthesis.
610 (find_automatic_composition): Mostly rewrite for efficiency.
612 2011-05-18 Juanma Barranquero <lekktu@gmail.com>
614 * makefile.w32-in: Update dependencies.
616 2011-05-18 Christoph Scholtes <cschol2112@googlemail.com>
618 * menu.c: Include limits.h (fixes the MS-Windows build broken by
621 2011-05-18 Paul Eggert <eggert@cs.ucla.edu>
623 Fix some integer overflow issues, such as string length overflow.
625 * insdel.c (count_size_as_multibyte): Check for string overflow.
627 * character.c (lisp_string_width): Check for string overflow.
628 Use EMACS_INT, not int, for string indexes and lengths; in
629 particular, 2nd arg is now EMACS_INT, not int. Do not crash if
630 the resulting string length overflows an EMACS_INT; instead,
631 report a string overflow if no precision given. When checking for
632 precision exhaustion, use a check that cannot possibly have
633 integer overflow. (Bug#8675)
634 * character.h (lisp_string_width): Adjust to new signature.
636 * alloc.c (string_overflow): New function.
637 (Fmake_string): Use it. This doesn't change behavior, but saves
638 a few bytes and will simplify future changes.
639 * character.c (string_escape_byte8): Likewise.
640 * lisp.h (string_overflow): New decl.
642 Fixups, following up to the user-interface timestamp change.
643 * nsterm.m (last_mouse_movement_time, ns_mouse_position): Use Time
644 for UI timestamps, instead of unsigned long.
645 * msdos.c (mouse_get_pos): Likewise.
646 * w32inevt.c (movement_time, w32_console_mouse_position): Likewise.
647 * w32gui.h (Time): Define by including "systime.h" rather than by
648 declaring it ourselves. (Bug#8664)
650 * dispextern.h (struct image): Don't assume time_t <= unsigned long.
651 * image.c (clear_image_cache): Likewise.
653 * term.c (term_mouse_position): Don't assume time_t wraparound.
655 Be more systematic about user-interface timestamps.
656 Before, the code sometimes used 'Time', sometimes 'unsigned long',
657 and sometimes 'EMACS_UINT', to represent these timestamps.
658 This change causes it to use 'Time' uniformly, as that's what X uses.
659 This makes the code easier to follow, and makes it easier to catch
660 integer overflow bugs such as Bug#8664.
661 * frame.c (Fmouse_position, Fmouse_pixel_position):
662 Use Time, not unsigned long, for user-interface timestamps.
663 * keyboard.c (last_event_timestamp, kbd_buffer_get_event): Likewise.
664 (button_down_time, make_lispy_position, make_lispy_movement): Likewise.
665 * keyboard.h (last_event_timestamp): Likewise.
666 * menu.c (Fx_popup_menu) [!HAVE_X_WINDOWS]: Likewise.
667 * menu.h (xmenu_show): Likewise.
668 * term.c (term_mouse_position): Likewise.
669 * termhooks.h (struct input_event.timestamp): Likewise.
670 (struct terminal.mouse_position_hook): Likewise.
671 * xmenu.c (create_and_show_popup_menu, xmenu_show): Likewise.
672 * xterm.c (XTmouse_position, x_scroll_bar_report_motion): Likewise.
673 * systime.h (Time): New decl. Pull it in from <X11/X.h> if
674 HAVE_X_WINDOWS, otherwise define it as unsigned long, which is
676 * menu.h, termhooks.h: Include "systime.h", for Time.
678 * keyboard.c (make_lispy_event): Fix problem in integer overflow.
679 Don't assume that the difference between two unsigned long values
680 can fit into an integer. At this point, we know button_down_time
681 <= event->timestamp, so the difference must be nonnegative, so
682 there's no need to cast the result if double-click-time is
683 nonnegative, as it should be; check that it's nonnegative, just in
684 case. This bug is triggered when events are more than 2**31 ms
685 apart (about 25 days). (Bug#8664)
687 * xselect.c (last_event_timestamp): Remove duplicate decl.
688 (x_own_selection): Remove needless cast to unsigned long.
690 * xmenu.c (set_frame_menubar): Use int, not EMACS_UINT, for indexes
691 that always fit in int. Use a sentinel instead of a counter, to
692 avoid a temp and to allay GCC's concerns about possible int overflow.
693 * frame.h (struct frame): Use int for menu_bar_items_used
694 instead of EMACS_INT, since it always fits in int.
696 * menu.c (grow_menu_items): Check for int overflow.
698 * xmenu.c (set_frame_menubar): Don't mishandle vectors with no nils.
700 * xterm.c: Use EMACS_INT for Emacs modifiers, and int for X modifiers.
701 Before, the code was not consistent. These values cannot exceed
702 2**31 - 1 so there's no need to make them unsigned.
703 (x_x_to_emacs_modifiers): Accept int and return EMACS_INT.
704 (x_emacs_to_x_modifiers): Accept EMACS_INT and return int.
705 (x_x_to_emacs_modifiers, x_emacs_to_x_modifiers): Reject non-integers
707 * xterm.h (x_x_to_emacs_modifiers): Adjust to signature change.
709 * lisp.h (XINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_INT.
710 (XUINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_UINT.
711 Otherwise, GCC 4.6.0 warns about printf (pI, XINT (...)),
712 presumably because the widths might not match.
714 * window.c (size_window): Avoid needless test at loop start.
716 2011-05-18 Courtney Bane <emacs-bugs-7626@cbane.org> (tiny change)
718 * term.c (Fresume_tty): Restore hooks before reinitializing (bug#8687).
720 2011-05-12 Drew Adams <drew.adams@oracle.com>
722 * textprop.c (Fprevious_single_char_property_change): Doc fix (bug#8655).
724 2011-05-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
726 * w32term.c (w32_draw_fringe_bitmap): Rename local vars `left' and
727 `width' to `bar_area_x' and `bar_area_width', respectively.
728 (x_scroll_run): Take account of fringe background extension.
730 * xterm.c (x_draw_fringe_bitmap) [USE_TOOLKIT_SCROLL_BARS]:
731 Rename local vars `left' and `width' to `bar_area_x' and
732 `bar_area_width', respectively.
733 (x_scroll_run) [USE_TOOLKIT_SCROLL_BARS]: Take account of fringe
734 background extension.
736 2011-05-10 Jim Meyering <meyering@redhat.com>
738 * xdisp.c (x_intersect_rectangles): Fix typo "the the -> the".
740 2011-05-10 Juanma Barranquero <lekktu@gmail.com>
742 * image.c (Finit_image_library): Return t for built-in image types,
743 like pbm and xbm. (Bug#8640)
745 2011-05-09 Andreas Schwab <schwab@linux-m68k.org>
747 * w32menu.c (set_frame_menubar): Fix submenu allocation.
749 2011-05-07 Eli Zaretskii <eliz@gnu.org>
751 * w32console.c (Fset_screen_color): Doc fix.
752 (Fget_screen_color): New function.
753 (syms_of_ntterm): Defsubr it.
755 * callproc.c (call_process_cleanup) [MSDOS]: Don't close and
756 unlink the temporary file if Fcall_process didn't create it in the
758 (Fcall_process) [MSDOS]: Don't create tempfile if stdout of the
759 child process will be redirected to a file specified with `:file'.
760 Don't try to re-open tempfile in that case, and set fd[0] to -1 as
761 cue to call_process_cleanup not to close that handle.
763 2011-05-07 Ben Key <bkey76@gmail.com>
765 * makefile.w32-in: The bootstrap-temacs rule now makes use of
766 one of two shell specific rules, either bootstrap-temacs-CMD or
767 bootstrap-temacs-SH. The bootstrap-temacs-SH rule is identical
768 to the previous implementation of the bootstrap-temacs rule.
769 The bootstrap-temacs-CMD rule is similar to the previous
770 implementation of the bootstrap-temacs rule except that it
771 makes use of the ESC_CFLAGS variable instead of the CFLAGS
774 These changes, along with some changes to nt/configure.bat,
775 nt/gmake.defs, and nt/nmake.defs, are required to extend my
776 earlier fix to add support for --cflags and --ldflags options
777 that include quotes so that it works whether make uses cmd or
780 2011-05-06 Michael Albinus <michael.albinus@gmx.de>
782 * dbusbind.c (QCdbus_type_unix_fd): Declare static.
783 (xd_remove_watch): Don't check QCdbus_type_unix_fd for SYMBOLP, it
785 (Fdbus_init_bus, xd_read_queued_messages): Bus can be a symbol or
786 a string. Handle both cases.
787 (Fdbus_call_method_asynchronously, Fdbus_register_signal)
788 (Fdbus_register_method): Use Qinvalid_function.
790 2011-05-06 Juanma Barranquero <lekktu@gmail.com>
792 * makefile.w32-in: Update dependencies.
793 (LISP_H): Add inttypes.h and stdin.h.
794 (PROCESS_H): Add unistd.h.
796 2011-05-06 Eli Zaretskii <eliz@gnu.org>
798 * lread.c: Include limits.h (fixes the MS-Windows build broken by
799 2011-05-06T07:13:19Z!eggert@cs.ucla.edu).
801 2011-05-06 Paul Eggert <eggert@cs.ucla.edu>
803 * image.c (Finit_image_library) [!HAVE_NTGUI]: Omit unused local.
805 * term.c (vfatal): Remove stray call to va_end.
806 It's not needed and the C Standard doesn't allow it here anyway.
808 Use C99's va_copy to avoid undefined behavior on x86-64 GNU/Linux.
809 * eval.c (verror): doprnt a copy of ap, not the original. (Bug#8545)
811 * eval.c (verror): OK to create a string of up to MOST_POSITIVE_FIXNUM
814 * term.c: Don't include <stdarg.h>, as <lisp.h> does that.
816 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
818 * process.c (Fformat_network_address): Fix typo: args2 -> *args2.
820 * xmenu.c (set_frame_menubar): Fix typo: int * -> int (3 times).
822 * coding.c (detect_coding_charset): Fix typo: * 2 -> *4 (Bug#8601).
824 * charset.h (struct charset.code_space): Now has 15 elements, not 16.
825 * charset.c (Fdefine_charset_internal): Don't initialize
826 charset.code_space[15]. The value was garbage, on hosts with
827 32-bit int (Bug#8600).
829 * lread.c (read_integer): Be more consistent with string-to-number.
830 Use string_to_number to do the actual conversion; this avoids
831 rounding errors and fixes some other screwups. Without this fix,
832 for example, #x1fffffffffffffff was misread as -2305843009213693952.
833 (digit_to_number): Move earlier, for benefit of read_integer.
834 Return -1 if the digit is out of range for the base, -2 if it is
835 not a digit in any supported base. (Bug#8602)
837 * doprnt.c (doprnt): Support arbitrary pI values, such as "I64".
839 * dispnew.c (scrolling_window): Return 1 if we scrolled,
840 to match comment at start of function. This also removes a
841 GCC warning about overflow in a 32+64-bit port.
843 * lisp.h (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Simplify.
845 * dbusbind.c: Do not use XPNTR on a value that may be an integer.
846 Reported by Stefan Monnier in
847 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00919.html>.
848 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
849 Use SYMBOLP-guarded XSYMBOL, not XPNTR.
851 * lisp.h (EMACS_INTPTR): Remove. All uses changed to intptr_t.
852 (EMACS_UINTPTR): Likewise, with uintptr_t.
854 * lisp.h: Prefer 64-bit EMACS_INT if available.
855 (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Define to 64-bit
856 on 32-bit hosts that have 64-bit int, so that they can access
858 However, temporarily disable this change unless the temporary
859 symbol WIDE_EMACS_INT is defined.
861 * lread.c, process.c: Do not include <inttypes.h>; lisp.h does it now.
863 Prefer intptr_t/uintptr_t for integers the same widths as pointers.
864 This removes an assumption that EMACS_INT and long are the same
865 width as pointers. The assumption is true for Emacs porting targets
866 now, but we want to make other targets possible.
867 * lisp.h: Include <inttypes.h>, for INTPTR_MAX, UINTPTR_MAX.
868 (EMACS_INTPTR, EMACS_UINTPTR): New macros.
869 In the rest of the code, change types of integers that hold casted
870 pointers to EMACS_INTPTR and EMACS_UINTPTR, systematically
871 replacing EMACS_INT, long, EMACS_UINT, and unsigned long.
872 (XTYPE): Don't cast arg to EMACS_UINT; normally is not needed.
873 (XSET): Cast type of XTYPE arg to EMACS_INTPTR; it is needed here.
874 No need to cast type when ORing.
875 (XPNTR): Return a value of type EMACS_INTPTR or EMACS_UINTPTR.
876 * alloc.c (lisp_align_malloc): Remove a no-longer-needed cast.
877 * doc.c (store_function_docstring): Use EMACS_INTPTR, so as not to
878 assume EMACS_INT is the same width as char *.
879 * gtkutil.c (xg_gtk_scroll_destroy, xg_tool_bar_button_cb):
880 (xg_tool_bar_callback, xg_tool_bar_help_callback, xg_make_tool_item):
881 Remove no-longer-needed casts.
882 (xg_create_scroll_bar, xg_tool_bar_button_cb, xg_tool_bar_callback):
883 (xg_tool_bar_help_callback, xg_make_tool_item):
884 Use EMACS_INTPTR to hold an integer
885 that will be cast to void *; this can avoid a GCC warning
886 if EMACS_INT is not the same width as void *.
887 * menu.c (find_and_call_menu_selection): Remove no-longer-needed cast.
888 * xdisp.c (display_echo_area_1, resize_mini_window_1):
889 (current_message_1, set_message_1):
890 Use a local to convert to proper width without a cast.
891 * xmenu.c (dialog_selection_callback): Likewise.
893 * sysdep.c (get_random): Don't assume EMACS_INT is no wider than long.
894 Also, don't assume VALBITS / RAND_BITS is less than 5,
895 and don't rely on undefined behavior when shifting a 1 left into
897 * lisp.h (get_random): Change signature to match.
899 * lread.c (hash_string): Use size_t, not int, for hash computation.
900 Normally we prefer signed values; but hashing is special, because
901 it's better to use unsigned division on hash table sizes so that
902 the remainder is nonnegative. Also, size_t is the natural width
903 for hashing into memory. The previous code used 'int', which doesn't
904 retain enough info to hash well into very large tables.
905 (oblookup, oblookup_last_bucket_number, Funintern): Likewise.
907 * dbusbind.c: Don't possibly lose pointer info when converting.
908 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
909 Use XPNTR rather than XHASH, so that the high-order bits of
910 the pointer aren't lost when converting through void *.
912 * eval.c (Fautoload): Don't double-shift a pointer.
914 * fns.c (Frandom): Let EMACS_UINT be wider than unsigned long.
916 2011-05-06 Juanma Barranquero <lekktu@gmail.com>
918 * gnutls.c (DEF_GNUTLS_FN):
919 * image.c (DEF_IMGLIB_FN): Make function pointers static.
921 2011-05-05 Andreas Schwab <schwab@linux-m68k.org>
923 * lread.c (lisp_file_lexically_bound_p): Stop scanning at end
926 2011-05-05 Eli Zaretskii <eliz@gnu.org>
928 * w32heap.c (allocate_heap) [USE_LISP_UNION_TYPE || USE_LSB_TAG]:
929 New version that can reserve upto 2GB of heap space.
931 2011-05-05 Chong Yidong <cyd@stupidchicken.com>
933 * nsfns.m (Fns_read_file_name): Doc fix (Bug#8534).
935 2011-05-05 Teodor Zlatanov <tzz@lifelogs.com>
937 * gnutls.c (fn_gnutls_certificate_set_x509_key_file): Add alias to
938 `gnutls_certificate_set_x509_key_file'.
940 2011-05-05 Juanma Barranquero <lekktu@gmail.com>
942 * makefile.w32-in ($(BLD)/image.$(O), $(BLD)/process.$(O)):
945 2011-05-04 Juanma Barranquero <lekktu@gmail.com>
947 * gnutls.h (emacs_gnutls_write, emacs_gnutls_read):
948 * gnutls.c (emacs_gnutls_write, emacs_gnutls_read):
949 Remove unused parameter `fildes'.
950 * process.c (read_process_output, send_process): Don't pass it.
952 2011-05-04 Juanma Barranquero <lekktu@gmail.com>
954 Fix previous change: the library cache is defined in w32.c.
955 * image.c (CACHE_IMAGE_TYPE) [!HAVE_NTGUI]: Define to noop.
956 (Finit_image_library): Wrap Vlibrary_cache on "#ifdef HAVE_NTGUI".
958 2011-05-04 Juanma Barranquero <lekktu@gmail.com>
960 Implement dynamic loading of GnuTLS on Windows.
962 * gnutls.h (GNUTLS_EMACS_ERROR_NOT_LOADED): New macro.
963 (emacs_gnutls_write, emacs_gnutls_read): Mark as extern.
964 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
967 * gnutls.c (Qgnutls_dll): Define.
968 (DEF_GNUTLS_FN, LOAD_GNUTLS_FN): New macros.
969 (gnutls_*): Declare function pointers.
970 (init_gnutls_functions): New function to initialize function pointers.
971 (emacs_gnutls_handshake, Fgnutls_error_string, Fgnutls_deinit)
972 (emacs_gnutls_global_init, Fgnutls_bye): Use function pointers.
973 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
974 Wrappers for gnutls_record_check_pending and gnutls_transport_set_errno.
975 (emacs_gnutls_write, emacs_gnutls_read)
976 (emacs_gnutls_handle_error, Fgnutls_error_fatalp)
977 (Fgnutls_available_p): New function.
978 (Fgnutls_boot): Call Fgnutls_available_p. Use function pointers.
979 (syms_of_gnutls) <Qgnutls_dll>: Initialize and staticpro it.
980 (syms_of_gnutls) <Sgnutls_available_p>: defsubr it.
982 * image.c: Include w32.h.
983 (Vimage_type_cache): Delete.
984 (syms_of_image) <Vimage_type_cache>: Don't initialize and staticpro it.
985 (CACHE_IMAGE_TYPE, Finit_image_library): Use Vlibrary_cache instead.
986 (w32_delayed_load): Move to w32.c.
988 * w32.h (VlibraryCache, QCloaded_from, w32_delayed_load): Declare.
990 * w32.c (QCloaded_from, Vlibrary_cache): Define.
991 (w32_delayed_load): Move from image.c. When loading a library, record
992 its filename in the :loaded-from property of the library id.
993 (globals_of_w32) <QCloaded_from, Vlibrary_cache>:
994 Initialize and staticpro them.
995 (emacs_gnutls_pull, emacs_gnutls_push): Call emacs_gnutls_* functions.
997 * process.c: Include lisp.h before w32.h, not after.
998 (wait_reading_process_output): Call emacs_gnutls_record_check_pending
999 instead of gnutls_record_check_pending.
1001 * callproc.c, emacs.c: Include lisp.h before w32.h, not after.
1003 2011-05-04 Teodor Zlatanov <tzz@lifelogs.com>
1005 * gnutls.c (Fgnutls_boot): Support :keylist and :crlfiles options
1006 instead of :keyfiles. Give GnuTLS the keylist and the CRL lists
1009 2011-05-03 Jan Djärv <jan.h.d@swipnet.se>
1011 * xterm.c (x_set_frame_alpha): Do not set property on anything
1012 else than FRAME_X_OUTER_WINDOW (Bug#8608).
1014 2011-05-02 Juanma Barranquero <lekktu@gmail.com>
1016 * sysdep.c (get_tty_size) [WINDOWSNT]: Implement. (Bug#8596)
1018 2011-05-02 Juanma Barranquero <lekktu@gmail.com>
1020 * gnutls.c (Qgnutls_log_level, Qgnutls_code, Qgnutls_anon)
1021 (Qgnutls_x509pki, Qgnutls_e_interrupted, Qgnutls_e_again)
1022 (Qgnutls_e_invalid_session, Qgnutls_e_not_ready_for_handshake)
1023 (gnutls_global_initialized, Qgnutls_bootprop_priority)
1024 (Qgnutls_bootprop_trustfiles, Qgnutls_bootprop_keyfiles)
1025 (Qgnutls_bootprop_callbacks, Qgnutls_bootprop_loglevel)
1026 (Qgnutls_bootprop_hostname, Qgnutls_bootprop_verify_flags)
1027 (Qgnutls_bootprop_verify_error, Qgnutls_bootprop_verify_hostname_error)
1028 (Qgnutls_bootprop_callbacks_verify): Make static.
1030 2011-05-01 Andreas Schwab <schwab@linux-m68k.org>
1032 * callproc.c: Indentation fixup.
1034 * sysdep.c (wait_for_termination_1): Make static.
1035 (wait_for_termination, interruptible_wait_for_termination):
1036 Move after wait_for_termination_1.
1038 2011-05-01 Lars Magne Ingebrigtsen <larsi@gnus.org>
1040 * sysdep.c (interruptible_wait_for_termination): New function
1041 which is like wait_for_termination, but allows keyboard
1044 * callproc.c (Fcall_process): Add (:file "file") as an option for
1046 (Fcall_process_region): Ditto.
1048 2011-04-30 Eli Zaretskii <eliz@gnu.org>
1050 * dosfns.c (Fint86, Fdos_memget, Fdos_memput): Use `ASIZE (FOO)'
1051 rather than `XVECTOR (FOO)->size'.
1053 * process.c: Remove HAVE_INTTYPES_H condition from inclusion of
1054 inttypes.h, as a gnulib replacement is used if it not available in
1057 2011-04-21 Eli Zaretskii <eliz@gnu.org>
1059 Lift the MOST_POSITIVE_FIXNUM/4 limitation on visited files.
1060 * fileio.c (Finsert_file_contents): Don't limit file size to 1/4
1061 of MOST_POSITIVE_FIXNUM. (Bug#8528)
1063 * coding.c (coding_alloc_by_realloc): Error out if destination
1064 will grow beyond MOST_POSITIVE_FIXNUM.
1065 (decode_coding_emacs_mule): Abort if there isn't enough place in
1066 charbuf for the composition carryover bytes. Reserve an extra
1067 space for up to 2 characters produced in a loop.
1068 (decode_coding_iso_2022): Abort if there isn't enough place in
1069 charbuf for the composition carryover bytes.
1071 2011-04-21 Eli Zaretskii <eliz@gnu.org>
1073 * doprnt.c (doprnt) [!HAVE_LONG_LONG_INT]: Error out instead of
1074 aborting when %lld or %lll format is passed.
1075 [!HAVE_UNSIGNED_LONG_LONG_INT]: Error out instead of aborting when
1076 %llo or %llx format is passed. (Bug#8545)
1078 * window.c (window_scroll_line_based): Use a marker instead of
1079 simple variables to record original value of point. (Bug#7952)
1081 * doprnt.c (doprnt): Fix the case where a multibyte sequence
1082 produced by %s or %c overflows available buffer space. (Bug#8545)
1084 2011-04-28 Paul Eggert <eggert@cs.ucla.edu>
1086 * doprnt.c (doprnt): Omit useless test; int overflow check (Bug#8545).
1087 (SIZE_MAX): Move defn after all includes, as they might #define it.
1089 2011-04-28 Juanma Barranquero <lekktu@gmail.com>
1091 * w32.c (init_environment): Warn about defaulting HOME to C:\.
1093 2011-04-28 Juanma Barranquero <lekktu@gmail.com>
1095 * keyboard.c (Qdelayed_warnings_hook): Define.
1096 (command_loop_1): Run `delayed-warnings-hook'
1097 if Vdelayed_warnings_list is non-nil.
1098 (syms_of_keyboard) <delayed-warnings-hook>: DEFSYM it.
1099 (syms_of_keyboard) <delayed-warnings-list>: DEFVAR_LISP it.
1101 2011-04-28 Eli Zaretskii <eliz@gnu.org>
1103 * doprnt.c (doprnt): Don't return value smaller than the buffer
1104 size if the message was truncated. (Bug#8545).
1106 2011-04-28 Juanma Barranquero <lekktu@gmail.com>
1108 * w32fns.c (Fx_change_window_property, Fx_delete_window_property)
1109 (Fx_window_property): #if-0 the whole functions, not just the bodies.
1111 2011-04-27 Paul Eggert <eggert@cs.ucla.edu>
1113 * doprnt.c (doprnt): Support "ll" length modifier, for long long.
1115 2011-04-27 Juanma Barranquero <lekktu@gmail.com>
1117 * makefile.w32-in: Update dependencies.
1119 2011-04-27 Eli Zaretskii <eliz@gnu.org>
1121 Improve `doprnt' and its usage. (Bug#8545)
1122 * doprnt.c (doprnt): Make sure `format' is never accessed beyond
1123 `format_end'. Remove support for %l as a conversion specifier.
1124 Don't use xrealloc. Improve diagnostics when the %l size modifier
1125 is used. Update the commentary.
1127 * eval.c (verror): Simplify calculation of size_t.
1129 * coding.c (Ffind_operation_coding_system): Fix diagnostic error
1132 2011-04-27 Yoshiaki Kasahara <kasahara@nc.kyushu-u.ac.jp> (tiny change)
1134 * buffer.c (init_buffer) [USE_MMAP_FOR_BUFFERS]: Adjust to aliasing
1137 2011-04-27 Paul Eggert <eggert@cs.ucla.edu>
1139 * nsmenu.m: Replace all uses of XVECTOR with ASIZE and AREF.
1140 This makes this file independent of the recent pseudovector change.
1142 2011-04-26 Paul Eggert <eggert@cs.ucla.edu>
1144 * keyboard.c (handle_user_signal): Fix pointer signedness problem.
1146 * gnutls.c (emacs_gnutls_handle_error): Remove unused local.
1147 (Fgnutls_boot): gnutls_certificate_verify_peers2 wants unsigned *.
1148 Remove unused local.
1149 (emacs_gnutls_write): Don't use uninitialized rtnval if nbyte <= 0.
1151 * lisp.h: Fix a problem with aliasing and vector headers. (Bug#8546)
1152 GCC 4.6.0 optimizes based on type-based alias analysis.
1153 For example, if b is of type struct buffer * and v of type struct
1154 Lisp_Vector *, then gcc -O2 was incorrectly assuming that &b->size
1155 != &v->size, and therefore "v->size = 1; b->size = 2; return
1156 v->size;" must therefore return 1. This assumption is incorrect
1157 for Emacs, since it type-puns struct Lisp_Vector * with many other
1158 types. To fix this problem, this patch adds a new type struct
1159 vectorlike_header that documents the constraints on layout of vectors
1160 and pseudovectors, and helps optimizing compilers not get fooled
1161 by Emacs's type punning. It also adds the macros XSETTYPED_PVECTYPE
1162 XSETTYPED_PSEUDOVECTOR, TYPED_PSEUDOVECTORP, for similar reasons.
1163 * lisp.h (XSETTYPED_PVECTYPE): New macro, specifying the name of
1165 (XSETPVECTYPE): Rewrite in terms of new macro.
1166 (XSETPVECTYPESIZE): New macro, specifying both type and size.
1167 This is a bit clearer, and further avoids the possibility of
1168 undesirable aliasing.
1169 (XSETTYPED_PSEUDOVECTOR): New macro, specifying the size.
1170 (XSETPSEUDOVECTOR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR.
1171 (XSETSUBR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR and XSIZE,
1172 since Lisp_Subr is a special case (no "next" field).
1173 (ASIZE): Now uses header.size rather than size.
1174 All previous uses of XVECTOR (foo)->size replaced to use this macro,
1175 to avoid the hassle of writing XVECTOR (foo)->header.size.
1176 (struct vectorlike_header): New type.
1177 (TYPED_PSEUDOVECTORP): New macro, also specifying the C type of the
1178 object, to help avoid aliasing.
1179 (PSEUDOVECTORP): Rewrite in terms of TYPED_PSEUDOVECTORP.
1180 (SUBRP): Likewise, since Lisp_Subr is a special case.
1181 * lisp.h (struct Lisp_Vector, struct Lisp_Char_Table):
1182 (struct Lisp_Sub_Char_Table, struct Lisp_Bool_Vector):
1183 (struct Lisp_Hash_Table): Combine first two members into a single
1184 struct vectorlike_header member. All uses of "size" and "next" members
1185 changed to be "header.size" and "header.next".
1186 * buffer.h (struct buffer): Likewise.
1187 * font.h (struct font_spec, struct font_entity, struct font): Likewise.
1188 * frame.h (struct frame): Likewise.
1189 * process.h (struct Lisp_Process): Likewise.
1190 * termhooks.h (struct terminal): Likewise.
1191 * window.c (struct save_window_data, struct saved_window): Likewise.
1192 * window.h (struct window): Likewise.
1193 * alloc.c (allocate_buffer, Fmake_bool_vector, allocate_pseudovector):
1194 Use XSETPVECTYPESIZE, not XSETPVECTYPE, to avoid aliasing problems.
1195 * buffer.c (init_buffer_once): Likewise.
1196 * lread.c (defsubr): Use XSETTYPED_PVECTYPE, since Lisp_Subr is a
1198 * process.c (Fformat_network_address): Use local var for size,
1201 * bytecode.c (exec_byte_code): Don't use XVECTOR before CHECK_VECTOR.
1203 Make the Lisp reader and string-to-float more consistent (Bug#8525)
1204 * data.c (atof): Remove decl; no longer used or needed.
1205 (digit_to_number): Move to lread.c.
1206 (Fstring_to_number): Use new string_to_number function, to be
1207 consistent with how the Lisp reader treats infinities and NaNs.
1208 Do not assume that floating-point numbers represent EMACS_INT
1209 without losing information; this is not true on most 64-bit hosts.
1210 Avoid double-rounding errors, by insisting on integers when
1211 parsing non-base-10 numbers, as the documentation specifies.
1212 * lisp.h (string_to_number): New decl, replacing ...
1213 (isfloat_string): Remove.
1214 * lread.c: Include <inttypes.h>, for uintmax_t and strtoumax.
1215 (read1): Do not accept +. and -. as integers; this
1216 appears to have been a coding error. Similarly, do not accept
1217 strings like +-1e0 as floating point numbers. Do not report
1218 overflow for integer overflows unless the base is not 10 which
1219 means we have no simple and reliable way to continue.
1220 Break out the floating-point parsing into a new
1221 function string_to_number, so that Fstring_to_number parses
1222 floating point numbers consistently with the Lisp reader.
1223 (digit_to_number): Move here from data.c. Make it static inline.
1224 (E_CHAR, EXP_INT): Remove, replacing with ...
1225 (E_EXP): New macro, to solve the "1.0e+" problem mentioned below.
1226 (string_to_number): New function, replacing isfloat_string.
1227 This function checks for valid syntax and produces the resulting
1228 Lisp float number too. Rework it so that string-to-number
1229 no longer mishandles examples like "1.0e+". Use strtoumax,
1230 so that overflow for non-base-10 numbers is reported only when
1231 there's no portable and simple way to convert to floating point.
1233 * textprop.c (set_text_properties_1): Rewrite for clarity,
1234 and to avoid GCC warning about integer overflow.
1236 * intervals.h (struct interval): Use EMACS_INT for members
1237 where EMACS_UINT might cause problems. See
1238 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html>.
1239 (CHECK_TOTAL_LENGTH): Remove cast to EMACS_INT; no longer needed.
1240 * intervals.c (interval_deletion_adjustment): Now returns EMACS_INT.
1242 (offset_intervals): Tell GCC not to worry about length overflow
1243 when negating a negative length.
1245 * alloc.c (overrun_check_malloc, overrun_check_realloc): Now static.
1246 (overrun_check_free): Likewise.
1248 * alloc.c (SDATA_SIZE) [!GC_CHECK_STRING_BYTES]: Avoid runtime check
1249 in the common case where SDATA_DATA_OFFSET is a multiple of Emacs
1252 * gnutls.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
1253 (gnutls_make_error): Rename local to avoid shadowing.
1254 (gnutls_emacs_global_deinit): ifdef out; not used.
1255 (Fgnutls_boot): Use const for pointer to readonly storage.
1256 Comment out unused local. Fix pointer signedness problems.
1258 * lread.c (openp): Don't stuff size_t into an 'int'.
1259 Use <= on length, not < on length + 1, to avoid GCC 4.6.0 warning
1260 about possible signed overflow.
1262 * gtkutil.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
1263 (GDK_KEY_g): Don't define if already defined.
1264 (xg_prepare_tooltip): Avoid pointer signedness problem.
1265 (xg_set_toolkit_scroll_bar_thumb): Redo to avoid two casts.
1267 * process.c (Fnetwork_interface_info): Avoid left-shift undefined
1268 behavior with 1 << 31. GCC 4.6.0 warns about this on 32-bit hosts.
1270 * xfns.c (Fx_window_property): Simplify a bit,
1271 to make a bit faster and to avoid GCC 4.6.0 warning.
1272 * xselect.c (x_get_window_property, x_handle_dnd_message): Likewise.
1274 * fns.c (internal_equal): Don't assume size_t fits in int.
1276 * alloc.c (compact_small_strings): Tighten assertion a little.
1278 Replace pEd with more-general pI, and fix some printf arg casts.
1279 * lisp.h (pI): New macro, generalizing old pEd macro to other
1280 conversion specifiers. For example, use "...%"pI"d..." rather
1281 than "...%"pEd"...".
1282 (pEd): Remove. All uses replaced with similar uses of pI.
1283 * src/m/amdx86-64.h, src/m/ia64.h, src/m/ibms390x.h: Likewise.
1284 * alloc.c (check_pure_size): Don't overflow by converting size to int.
1285 * bidi.c (bidi_dump_cached_states): Use pI to avoid cast.
1286 * data.c (Fnumber_to_string): Use pI instead of if-then-else-abort.
1287 * dbusbind.c (xd_append_arg): Use pI to avoid cast.
1288 (Fdbus_method_return_internal, Fdbus_method_error_internal): Likewise.
1289 * font.c (font_unparse_xlfd): Avoid potential buffer overrun on
1291 (font_unparse_xlfd, font_unparse_fcname): Use pI to avoid casts.
1292 * keyboard.c (record_char, modify_event_symbol): Use pI to avoid casts.
1293 * print.c (safe_debug_print, print_object): Likewise.
1294 (print_object): Don't overflow by converting EMACS_INT or EMACS_UINT
1296 Use pI instead of if-then-else-abort. Use %p to avoid casts,
1297 avoiding the 0 flag, which is not portable.
1298 * process.c (Fmake_network_process): Use pI to avoid cast.
1299 * region-cache.c (pp_cache): Likewise.
1300 * xdisp.c (decode_mode_spec): Likewise.
1301 * xrdb.c (x_load_resources) [USE_MOTIF]: Use pI to avoid undefined
1302 behavior on 64-bit hosts with printf arg.
1303 * xselect.c (x_queue_event): Use %p to avoid casts, avoiding 0 flag.
1304 (x_stop_queuing_selection_requests): Likewise.
1305 (x_get_window_property): Don't truncate byte count to an 'int'
1308 * frame.c (frame_name_fnn_p): Get rid of strtol, which isn't right
1309 here, since it parses constructs like leading '-' and spaces,
1310 which are not wanted; and it overflows with large numbers.
1311 Instead, simply match F[0-9]+, which is what is wanted anyway.
1313 * alloc.c: Remove unportable assumptions about struct layout.
1314 (SDATA_SELECTOR, SDATA_DATA_OFFSET): New macros.
1315 (SDATA_OF_STRING, SDATA_SIZE, allocate_string_data):
1316 (allocate_vectorlike, make_pure_vector): Use the new macros,
1317 plus offsetof, to remove unportable assumptions about struct layout.
1318 These assumptions hold on all porting targets that I know of, but
1319 they are not guaranteed, they're easy to remove, and removing them
1320 makes further changes easier.
1322 * alloc.c (BLOCK BYTES): Fix typo by changing "ablock" to "ablocks".
1323 This doesn't fix a bug but makes the code clearer.
1324 (string_overrun_cookie): Now const. Use initializers that
1325 don't formally overflow signed char, to avoid warnings.
1326 (allocate_string_data) [GC_CHECK_STRING_OVERRUN]: Fix typo that
1327 can cause Emacs to crash when string overrun checking is enabled.
1328 (allocate_buffer): Don't assume sizeof (struct buffer) is a
1329 multiple of sizeof (EMACS_INT); it need not be, if
1330 alignof(EMACS_INT) < sizeof (EMACS_INT).
1331 (check_sblock, check_string_bytes, check_string_free_list): Protoize.
1333 2011-04-26 Juanma Barranquero <lekktu@gmail.com>
1335 * keyboard.c (QCrtl): Rename from Qrtl. All uses changed.
1337 2011-04-26 Teodor Zlatanov <tzz@lifelogs.com>
1339 * gnutls.c (emacs_gnutls_handshake): Return an error if we're not
1340 supposed to be handshaking. (Bug#8556)
1341 Reported by Paul Eggert <eggert@cs.ucla.edu>.
1343 2011-04-26 Daniel Colascione <dan.colascione@gmail.com>
1345 * lisp.h (Qdebug): List symbol.
1346 * eval.c (Qdebug): Restore global linkage.
1347 * keyboard.c (debug-on-event): New variable.
1348 (handle_user_signal): Break into debugger when debug-on-event
1349 matches the current signal symbol.
1351 2011-04-25 Dan Nicolaescu <dann@ics.uci.edu>
1353 * alloc.c (check_sblock, check_string_bytes)
1354 (check_string_free_list): Convert to standard C.
1356 2011-04-25 Teodor Zlatanov <tzz@lifelogs.com>
1358 * w32.c (emacs_gnutls_push): Fix typo.
1360 2011-04-25 Eli Zaretskii <eliz@gnu.org>
1362 * gnutls.c (emacs_gnutls_handshake): Avoid compiler warnings about
1363 "cast to pointer from integer of different size".
1365 Improve doprnt and its use in verror. (Bug#8545)
1366 * doprnt.c (doprnt): Document the set of format control sequences
1367 supported by the function. Use SAFE_ALLOCA instead of always
1370 * eval.c (verror): Don't limit the buffer size at size_max-1, that
1371 is one byte too soon. Don't use xrealloc; instead xfree and
1374 2011-04-24 Teodor Zlatanov <tzz@lifelogs.com>
1376 * gnutls.h: Add GNUTLS_STAGE_CALLBACKS enum to denote we're in the
1379 * gnutls.c: Renamed global_initialized to
1380 gnutls_global_initialized. Added internals for the
1381 :verify-hostname-error, :verify-error, and :verify-flags
1382 parameters of `gnutls-boot' and documented those parameters in the
1383 docstring. Start callback support.
1384 (emacs_gnutls_handshake): Add Woe32 support. Retry handshake
1385 unless a fatal error occured. Call gnutls_alert_send_appropriate
1386 on error. Return error code.
1387 (emacs_gnutls_write): Call emacs_gnutls_handle_error.
1388 (emacs_gnutls_read): Likewise.
1389 (Fgnutls_boot): Return handshake error code.
1390 (emacs_gnutls_handle_error): New function.
1391 (wsaerror_to_errno): Likewise.
1393 * w32.h (emacs_gnutls_pull): Add prototype.
1394 (emacs_gnutls_push): Likewise.
1396 * w32.c (emacs_gnutls_pull): New function for GnuTLS on Woe32.
1397 (emacs_gnutls_push): Likewise.
1399 2011-04-24 Claudio Bley <claudio.bley@gmail.com> (tiny change)
1401 * process.c (wait_reading_process_output): Check if GnuTLS
1402 buffered some data internally if no FDs are set for TLS
1405 * makefile.w32-in (OBJ2): Add gnutls.$(O).
1406 (LIBS): Link to USER_LIBS.
1407 ($(BLD)/gnutls.$(0)): New target.
1409 2011-04-24 Eli Zaretskii <eliz@gnu.org>
1411 * xdisp.c (handle_single_display_spec): Rename the
1412 display_replaced_before_p argument into display_replaced_p, to
1413 make it consistent with the commentary. Fix typos in the
1416 * textprop.c (syms_of_textprop): Remove dead code.
1417 (copy_text_properties): Delete obsolete commentary about an
1418 interface that was deleted long ago. Fix typos in the description
1421 * msdos.c (XMenuActivate, XMenuAddSelection): Adjust argument list
1422 to changes in oldXMenu/XMenu.h from 2011-04-16.
1423 <menu_help_message, prev_menu_help_message>: Constify.
1424 (IT_menu_make_room): menu->help_text is now `const char **';
1427 * msdos.h (XMenuActivate, XMenuAddSelection): Adjust prototypes
1428 to changes in oldXMenu/XMenu.h from 2011-04-16.
1429 (struct XMenu): Declare `help_text' `const char **'.
1431 * xfaces.c <Qunspecified>: Make extern again.
1433 * syntax.c: Include sys/types.h before including regex.h, as
1436 * doc.c (get_doc_string): Improve the format passed to `error'.
1438 * doprnt.c (doprnt): Improve commentary.
1440 * term.c (init_tty) [MSDOS]: Fix 1st argument to maybe_fatal.
1442 * Makefile.in (TAGS): Depend on $(M_FILE) and $(S_FILE), and scan
1445 * makefile.w32-in (globals.h): Add a dummy recipe, to make any
1446 changes in globals.h immediately force recompilation.
1447 (TAGS): Depend on $(CURDIR)/m/intel386.h and
1448 $(CURDIR)/s/ms-w32.h.
1449 (TAGS-gmake): Scan $(CURDIR)/m/intel386.h and $(CURDIR)/s/ms-w32.h.
1451 * character.c (Fchar_direction): Function deleted.
1452 (syms_of_character): Don't defsubr it.
1453 <char-direction-table>: Deleted.
1455 2011-04-23 Eli Zaretskii <eliz@gnu.org>
1457 Fix doprnt so it could be used again safely in `verror'. (Bug#8435)
1458 * doprnt.c: Include limits.h.
1459 (SIZE_MAX): New macro.
1460 (doprnt): Return a size_t value. 2nd arg is now size_t.
1461 Many local variables are now size_t instead of int or unsigned.
1462 Improve overflow protection. Support `l' modifier for integer
1463 conversions. Support %l conversion. Don't assume an EMACS_INT
1464 argument for integer conversions and for %c.
1466 * lisp.h (doprnt): Restore prototype.
1468 * makefile.w32-in ($(BLD)/callint.$(O)): Depend on
1471 * Makefile.in (base_obj): Add back doprnt.o.
1473 * deps.mk (doprnt.o): Add back prerequisites.
1474 (callint.o): Depend on character.h.
1476 * eval.c (internal_lisp_condition_case): Include the handler
1477 representation in the error message.
1478 (verror): Call doprnt instead of vsnprintf. Fix an off-by-one bug
1479 when breaking from the loop.
1481 * xdisp.c (vmessage): Call doprnt instead of vsnprintf.
1483 * callint.c (Fcall_interactively): When displaying error message
1484 about invalid control letter, pass the character's codepoint, not
1485 a pointer to its multibyte form. Improve display of the character
1486 in octal and display also its hex code.
1488 * character.c (char_string): Use %x to display the (unsigned)
1489 codepoint of an invalid character, to avoid displaying a bogus
1492 * font.c (check_otf_features): Pass SDATA of SYMBOL_NAME to
1493 `error', not SYMBOL_NAME itself.
1495 * coding.c (Fencode_sjis_char, Fencode_big5_char): Use %c for
1496 character arguments to `error'.
1498 * charset.c (check_iso_charset_parameter): Fix incorrect argument
1499 to `error' in error message about FINAL_CHAR argument. Make sure
1500 FINAL_CHAR is a character, and use %c when it is passed as
1501 argument to `error'.
1503 2011-04-23 Eli Zaretskii <eliz@gnu.org>
1505 * s/ms-w32.h (localtime): Redirect to sys_localtime.
1507 * w32.c: Include <time.h>.
1508 (sys_localtime): New function.
1510 2011-04-23 Chong Yidong <cyd@stupidchicken.com>
1512 * xdisp.c (init_xdisp): Initialize echo_area_window (Bug#6451).
1514 * buffer.c (syms_of_buffer): Doc fix (Bug#6902).
1516 2011-04-23 Samuel Thibault <sthibault@debian.org> (tiny change)
1518 * sysdep.c (wait_for_termination): On GNU Hurd, kill returns -1 on
1521 2011-04-19 Eli Zaretskii <eliz@gnu.org>
1523 * syntax.h (SETUP_SYNTAX_TABLE_FOR_OBJECT): Fix setting of
1524 gl_state.e_property when gl_state.object is Qt.
1526 * insdel.c (make_gap_larger): Remove limitation of buffer size
1529 2011-04-18 Chong Yidong <cyd@stupidchicken.com>
1531 * xdisp.c (lookup_glyphless_char_display)
1532 (produce_glyphless_glyph): Handle cons cell entry in
1533 glyphless-char-display.
1534 (Vglyphless_char_display): Document it.
1536 * term.c (produce_glyphless_glyph): Handle cons cell entry in
1537 glyphless-char-display.
1539 2011-04-17 Chong Yidong <cyd@stupidchicken.com>
1541 * xdisp.c (get_next_display_element): Remove unnecessary ifdefs.
1543 * termhooks.h (FRAME_WINDOW_P): Remove duplicated definitions.
1545 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): Add missing
1546 definition for no-X builds.
1548 2011-04-16 Paul Eggert <eggert@cs.ucla.edu>
1550 Static checks with GCC 4.6.0 and non-default toolkits.
1552 * s/sol2-6.h, s/unixware.h (PTY_TTY_NAME_SPRINTF): Protoize decl.
1554 * process.c (keyboard_bit_set): Define only if SIGIO.
1555 (send_process_trap): Mark it with NO_RETURN if it doesn't return.
1556 (send_process): Repair possible setjmp clobbering.
1558 * s/usg5-4-common.h (SETUP_SLAVE_PTY): Don't pass extra arg to 'fatal'.
1560 * eval.c: Include <stdio.h>, for vsnprintf on non-GNU/Linux hosts.
1562 * data.c (arith_error): Mark with NO_RETURN if it doesn't return.
1564 * alloc.c (bytes_used_when_full, SPARE_MEMORY, BYTES_USED):
1565 Define only if needed.
1567 * sysdep.c (_FILE_OFFSET_BITS): Make this hack even uglier
1568 by pacifying GCC about it. Maybe it's time to retire it?
1569 * xfaces.c (USG, __TIMEVAL__): Likewise.
1571 * dispextern.h (struct redisplay_interface): Rename param
1573 * termhooks.h (struct terminal): Likewise.
1574 * xterm.c (xembed_send_message): Likewise.
1576 * insdel.c (make_gap_smaller): Define only if
1577 USE_MMAP_FOR_BUFFERS || REL_ALLOC || DOUG_LEA_MALLOC.
1579 * keyboard.c (read_char): Make a var volatile so longjmp won't clobber
1582 * emacs.c (MAX_HEAP_BSS_DIFF, my_edata): Move to where they're used,
1583 so that we aren't warned about unused symbols.
1585 * xfns.c (Fx_file_dialog): Rename local to avoid shadowing.
1587 * xdisp.c (x_produce_glyphs): Mark var as initialized (Bug#8512).
1589 * xfns.c (x_real_positions): Mark locals as initialized.
1591 * xmenu.c (xmenu_show): Don't use uninitialized vars.
1593 * xterm.c: Fix problems found by static analysis with other toolkits.
1594 (toolkit_scroll_bar_interaction): Define and use only if USE_X_TOOLKIT.
1595 (x_dispatch_event): Declare static if USE_GTK, and
1596 define if USE_GTK || USE_X_TOOLKIT.
1597 (SET_SAVED_BUTTON_EVENT): Define only if USE_X_TOOLKIT || USE_GTK.
1598 * xterm.h (x_dispatch_event): Extern only if USE_X_TOOLKIT.
1599 * xterm.c, xterm.h (x_mouse_leave): Bring this function back, but only
1600 if defined HAVE_MENUS && !defined USE_X_TOOLKIT && !defined USE_GTK.
1602 * xmenu.c (menu_help_callback): Pointer type fixes.
1603 Use const pointers when pointing at readonly data. Avoid pointer
1605 (FALSE): Remove unused macro.
1606 (update_frame_menubar): Remove unused decl.
1608 * xfns.c (Fx_hide_tip): Move locals to avoid shadowing.
1610 * menu.c (push_submenu_start, push_submenu_end): Do not define unless
1611 USE_X_TOOLKIT || USE_GTK || HAVE_NS || defined HAVE_NTGUI.
1612 (single_menu_item): Rename local to avoid shadowing.
1614 * keyboard.c (make_lispy_event): Remove unused local var.
1616 * frame.c, frame.h (x_get_resource_string): Bring this back, but
1617 only if HAVE_X_WINDOWS && !USE_X_TOOLKIT.
1619 * bitmaps: Change bitmaps from unsigned char back to the X11
1620 compatible char. Avoid the old compiler warnings about
1621 out-of-range initializers by using, for example, '\xab' rather
1624 * xgselect.c (xgselect_initialize): Check vs interface
1625 even if ! (defined (USE_GTK) || defined (HAVE_GCONF)).
1627 * xmenu.c (xmenu_show): Rename parm to avoid shadowing.
1629 * xterm.c (x_create_toolkit_scroll_bar): Use const * for pointers
1630 to read-only memory.
1632 * fns.c (vector): Remove; this old hack is no longer needed.
1634 * xsmfns.c (create_client_leader_window): Rename shadowing arg.
1636 (gdk_x11_set_sm_client_id) [!USE_GTK]: Don't define.
1638 * xrdb.c (x_load_resources): Omit unused local.
1640 * xfns.c (free_frame_menubar, atof): Remove duplicate decls.
1641 (x_window): Rename locals to avoid shadowing.
1642 (USG): Use the kludged USG macro, to pacify gcc.
1644 * xterm.c (x_alloc_nearest_color_for_widget): Remove; unused.
1645 (x_term_init): Remove local to avoid shadowing.
1647 * xfns.c, xterm.c (_XEditResCheckMessages): Protoize decl.
1649 * xdisp.c, dispextern.h (set_vertical_scroll_bar): Now extern if
1650 USE_TOOLKIT_SCROLL_BARS && !USE_GTK, as xterm.c needs it then.
1652 2011-04-16 Eli Zaretskii <eliz@gnu.org>
1654 * gnutls.c (Fgnutls_boot): Don't pass Lisp_Object to `error'.
1656 Fix regex.c, syntax.c and friends for buffers > 2GB.
1657 * syntax.h (struct gl_state_s): Declare character position members
1660 * syntax.c (update_syntax_table): Declare 2nd argument EMACS_INT.
1662 * textprop.c (verify_interval_modification, interval_of):
1663 Declare arguments EMACS_INT.
1665 * intervals.c (adjust_intervals_for_insertion): Declare arguments
1668 * intervals.h (CHECK_TOTAL_LENGTH): Cast to EMACS_INT, not `int'.
1670 * indent.c (Fvertical_motion): Local variable it_start is now
1673 * regex.c (re_match, re_match_2, re_match_2_internal)
1674 (bcmp_translate, regcomp, regexec, print_double_string)
1675 (group_in_compile_stack, re_search, re_search_2, regex_compile)
1676 (re_compile_pattern, re_exec): Declare arguments and local
1677 variables `size_t' and `ssize_t' and return values `regoff_t', as
1679 (POP_FAILURE_REG_OR_COUNT) <pfreg>: Declare `long'.
1680 (CHECK_INFINITE_LOOP) <failure>: Declare `ssize_t'.
1681 <compile_stack_type>: `size' and `avail' are now `size_t'.
1683 * regex.h <regoff_t>: Use ssize_t, not int.
1684 (re_search, re_search_2, re_match, re_match_2): Arguments that
1685 specify buffer/string position and length are now ssize_t and
1686 size_t. Return type is regoff_t.
1688 2011-04-16 Ben Key <bkey76@gmail.com>
1690 * nsfont.m: Fixed bugs in ns_get_family and
1691 ns_descriptor_to_entity that were caused by using free to
1692 deallocate memory blocks that were allocated by xmalloc (via
1693 xstrdup). This caused Emacs to crash when compiled with
1694 XMALLOC_OVERRUN_CHECK defined (when Emacs was configured with
1695 --enable-checking=xmallocoverrun). xfree is now used to
1696 deallocate these memory blocks.
1698 2011-04-15 Paul Eggert <eggert@cs.ucla.edu>
1700 * sysdep.c (emacs_read): Remove unnecessary check vs MAX_RW_COUNT.
1702 emacs_write: Accept and return EMACS_INT for sizes.
1703 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html
1705 * gnutls.c, gnutls.h (emacs_gnutls_read, emacs_gnutls_write):
1706 Accept and return EMACS_INT.
1707 (emacs_gnutls_write): Return the number of bytes written on
1709 * sysdep.c, lisp.h (emacs_read, emacs_write): Likewise.
1710 (emacs_read, emacs_write): Remove check for negative size, as the
1711 Emacs source code has been audited now.
1712 * sysdep.c (MAX_RW_COUNT): New macro, to work around kernel bugs.
1713 (emacs_read, emacs_write): Use it.
1714 * process.c (send_process): Adjust to the new signatures of
1715 emacs_write and emacs_gnutls_write. Do not attempt to store
1716 a byte offset into an 'int'; it might overflow.
1717 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00483.html
1719 * sound.c: Don't assume sizes fit in 'int'.
1720 (struct sound_device.period_size, alsa_period_size):
1721 Return EMACS_INT, not int.
1722 (struct sound_device.write, vox_write, alsa_write):
1723 Accept EMACS_INT, not int.
1724 (wav_play, au_play): Use EMACS_INT to store sizes and to
1725 record read return values.
1727 2011-04-15 Ben Key <bkey76@gmail.com>
1729 * keyboard.c (Qundefined): Don't declare static since it is used
1731 * xfaces.c (Qbold, Qexpanded, Qitalic, Qcondensed): Don't declare
1732 static since they are used in nsfont.m.
1734 2011-04-15 Stefan Monnier <monnier@iro.umontreal.ca>
1736 * process.c (Qprocessp): Don't declare static.
1737 * lisp.h (Qprocessp): Declare again.
1739 2011-04-15 Juanma Barranquero <lekktu@gmail.com>
1741 * font.c (Qopentype): Don't make static (used from w32uniscribe.c).
1743 2011-04-14 Paul Eggert <eggert@cs.ucla.edu>
1745 Improve C-level modularity by making more things 'static'.
1747 Don't publish debugger-only interfaces to other modules.
1748 * lisp.h (safe_debug_print, debug_output_compilation_hack):
1749 (verify_bytepos, count_markers): Move decls to the only modules
1751 * region-cache.h (pp_cache): Likewise.
1752 * window.h (check_all_windows): Likewise.
1753 * marker.c, print.c, region-cache.c, window.c: Decls moved here.
1755 * sysdep.c (croak): Now static, if
1756 defined TIOCNOTTY || defined USG5 || defined CYGWIN.
1757 * syssignal.h (croak): Declare only if not static.
1759 * alloc.c (refill_memory_reserve): Now static if
1760 !defined REL_ALLOC || defined SYSTEM_MALLOC.
1761 * lisp.h (refill_memory_reserve): Declare only if not static.
1763 * xsettings.c, xsettings.h (xsettings_get_system_normal_font):
1764 Define only if USE_LUCID.
1766 * xrdb.c (x_customization_string, x_rm_string): Now static.
1768 * xmenu.c (x_menu_wait_for_event): Export only if USE_MOTIF.
1769 * xterm.h (x_menu_wait_for_event): Declare only if USE_MOTIF.
1771 * xdisp.c (draw_row_with_mouse_face): Now static.
1772 * dispextern.h (draw_row_with_mouse_fave): Remove decl.
1774 * window.h (check_all_windows): Mark externally visible.
1776 * window.c (window_deletion_count): Now static.
1778 * undo.c: Make symbols static if they're not exported.
1779 (last_undo_buffer, last_boundary_position, pending_boundary):
1782 * textprop.c (interval_insert_behind_hooks): Now static.
1783 (interval_insert_in_front_hooks): Likewise.
1785 * term.c: Make symbols static if they're not exported.
1786 (tty_turn_off_highlight, get_tty_terminal, max_frame_cols):
1787 (max_frame_lines, tty_set_terminal_modes):
1788 (tty_reset_terminal_modes, tty_turn_off_highlight):
1789 (get_tty_terminal): Now static.
1790 (term_mouse_moveto): Do not define if HAVE_WINDOW_SYSTEM.
1791 * termhooks.h (term_mouse_moveto): Do not declare if
1793 * dispextern.h (tty_set_terminal_modes, tty_reset_terminal_modes):
1794 (tty_turn_off_highlight, get_tty_terminal): Remove decls.
1796 * sysdep.c: Make symbols static if they're not exported.
1797 (emacs_get_tty, emacs_set_tty, old_fcntl_flags, old_fcntl_owner):
1799 (sigprocmask_set, full_mask): Remove; unused.
1800 (wait_debugging): Mark as visible.
1801 * syssignal.h (SIGFULLMASK, full_mask): Remove decls.
1802 * systty.h (emacs_get_tty, emacs_set_tty): Remove decls.
1804 * syntax.c (syntax_temp): Define only if !__GNUC__.
1806 * sound.c (current_sound_device, current_sound): Now static.
1808 * search.c (searchbufs, searchbuf_head): Now static.
1810 * scroll.c (scroll_cost): Remove; unused.
1811 * dispextern.h (scroll_cost): Remove decl.
1813 * region-cache.h (pp_cache): Mark as externally visible.
1815 * process.c: Make symbols static if they're not exported.
1816 (process_tick, update_tick, create_process, chan_process):
1817 (Vprocess_alist, proc_buffered_char, datagram_access):
1818 (fd_callback_data, send_process_frame, process_sent_to): Now static.
1819 (deactivate_process): Mark defn as static, as well as decl.
1820 * lisp.h (create_process): Remove decl.
1821 * process.h (chan_process, Vprocess_alist): Remove decls.
1823 * print.c: Make symbols static if they're not exported.
1824 (print_depth, new_backquote_output, being_printed, print_buffer):
1825 (print_buffer_size, print_buffer_pos, print_buffer_pos_byte):
1826 (print_interval, print_number_index, initial_stderr_stream):
1828 * lisp.h (Fprinc): Remove decl.
1829 (debug_output_compilation_hack): Mark as externally visible.
1831 * sysdep.c (croak): Move decl from here to syssignal.h.
1832 * syssignal.h (croak): Put it here, so the API can be checked when
1833 'croak' is called from dissociate_if_controlling_tty.
1835 * minibuf.c: Make symbols static if they're not exported.
1836 (minibuf_save_list, choose_minibuf_frame): Now static.
1837 * lisp.h (choose_minibuf_frame): Remove decl.
1839 * lisp.h (verify_bytepos, count_markers): Mark as externally visible.
1841 * lread.c: Make symbols static if they're not exported.
1842 (read_objects, initial_obarray, oblookup_last_bucket_number):
1844 (make_symbol): Remove; unused.
1845 * lisp.h (initial_obarray, make_symbol): Remove decls.
1847 * keyboard.c: Make symbols static if they're not exported.
1848 (single_kboard, recent_keys_index, total_keys, recent_keys):
1849 (this_command_key_count_reset, raw_keybuf, raw_keybuf_count):
1850 (this_single_command_key_start, echoing, last_auto_save):
1851 (read_key_sequence_cmd, dribble, recursive_edit_unwind):
1852 (command_loop, echo_now, keyboard_init_hook, help_char_p):
1853 (quit_throw_to_read_char, command_loop_2, top_level_1, poll_timer):
1854 (Vlispy_mouse_stem, double_click_count):
1856 (force_auto_save_soon): Define only if SIGDANGER.
1857 (ignore_mouse_drag_p): Now static if
1858 !defined HAVE_WINDOW_SYSTEM || defined USE_GTK || defined HAVE_NS.
1859 (print_help): Remove; unused.
1860 (stop_character, last_timer_event): Mark as externally visible.
1861 * keyboard.h (ignore_mouse_drag_p): Declare only if
1862 defined HAVE_WINDOW_SYSTEM && !defined USE_GTK && !defined HAVE_NS.
1863 (echo_now, help_char_p, quit_throw_to_read_char): Remove decls.
1864 * lisp.h (echoing): Remove decl.
1865 (force_auto_save_soon): Declare only if SIGDANGER.
1866 * xdisp.c (redisplay_window): Simplify code, to make it more
1867 obvious that ignore_mouse_drag_p is not accessed if !defined
1868 USE_GTK && !defined HAVE_NS.
1870 * intervals.c: Make symbols static if they're not exported.
1871 (merge_properties_sticky, merge_interval_right, delete_interval):
1873 * intervals.h (merge_interval_right, delete_interval): Remove decls.
1875 * insdel.c: Make symbols static if they're not exported.
1876 However, leave prepare_to_modify_buffer alone. It's never
1877 called from outside this function, but that appears to be a bug.
1878 (combine_after_change_list, combine_after_change_buffer):
1879 (adjust_after_replace, signal_before_change): Now static.
1880 (adjust_after_replace_noundo): Remove; unused.
1881 * lisp.h (adjust_after_replace, adjust_after_replace_noundo):
1882 (signal_before_change): Remove decls.
1884 * indent.c (val_compute_motion, val_vmotion): Now static.
1886 * image.c: Make symbols static if they're not exported.
1887 * dispextern.h (x_create_bitmap_from_xpm_data): Do not declare
1889 * image.c (x_create_bitmap_from_xpm_data): Do not define if USE_GTK.
1890 (xpm_color_cache, ct_table, ct_colors_allocated): Now static.
1892 * fringe.c (standard_bitmaps): Now static.
1893 (max_used_fringe_bitmap): Now static, unless HAVE_NS.
1895 * frame.c: Make symbols static if they're not exported.
1896 (x_report_frame_params, make_terminal_frame): Now static.
1897 (get_frame_param): Now static, unless HAVE_NS.
1898 (x_fullscreen_adjust): Define if WINDOWSNT, not if HAVE_WINDOW_SYSTEM.
1899 (x_get_resource_string): Remove; not used.
1900 * frame.h (make_terminal_frame, x_report_frame_params):
1901 (x_get_resource_string); Remove decls.
1902 (x_fullscreen_adjust): Declare only if WINDOWSNT.
1903 * lisp.h (get_frame_param): Declare only if HAVE_NS.
1905 * font.c, fontset.c: Make symbols static if they're not exported.
1906 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): New macro.
1907 (FACE_SUITABLE_FOR_CHAR_P): Use it.
1908 * font.c (font_close_object): Now static.
1909 * font.h (font_close_object): Remove.
1910 * fontset.c (FONTSET_OBJLIST): Remove.
1911 (free_realized_fontset) #if-0 the body, which does nothing.
1912 (face_suitable_for_char_p): #if-0, as it's never called.
1913 * fontset.h (face_suitable_for_char_p): Remove decl.
1914 * xfaces.c (face_at_string_position):
1915 Use FACE_SUITABLE_FOR_ASCII_CHAR_P, not FACE_SUITABLE_FOR_CHAR_P,
1916 since 0 is always ASCII.
1918 * fns.c (weak_hash_tables): Now static.
1920 * fileio.c: Make symbols static if they're not exported.
1921 (auto_saving, auto_save_mode_bits, auto_save_error_occurred):
1922 (Vwrite_region_annotation_buffers): Now static.
1924 * eval.c: Make symbols static if they're not exported.
1925 (backtrace_list, lisp_eval_depth, when_entered_debugger): Now static.
1926 * lisp.h (backtrace_list): Remove decl.
1928 * emacs.c: Make symbols static if they're not exported.
1929 (malloc_state_ptr, malloc_using_checking, syms_of_emacs):
1930 (fatal_error_code, fatal_error_signal_hook, standard_args):
1932 (fatal_error_signal): Now static, unless FLOAT_CATCH_SIGKILL.
1933 (DEFINE_DUMMY_FUNCTION): Mark function as externally visible.
1934 (__CTOR_LIST__, __DTOR_LIST__): Now externally visible.
1935 * lisp.h (fatal_error_signal_hook): Remove decl.
1936 (fatal_error_signal): Declare only if FLOAT_CATCH_SIGKILL.
1938 * editfns.c: Move a (normally-unused) function to its only use.
1939 * editfns.c, lisp.h (get_operating_system_release): Remove.
1940 * process.c (init_process) [DARWIN_OS]: Do it inline, as it is not
1941 worth the hassle of breaking this out.
1943 * xterm.c: Make symbols static if they're not exported.
1944 (x_raise_frame, x_lower_frame, x_wm_set_window_state):
1945 (x_wm_set_icon_pixmap, x_initialize, XTread_socket_fake_io_error):
1946 (x_destroy_window, x_delete_display):
1948 (x_dispatch_event): Now static if ! (USE_MOTIF || USE_X_TOOLKIT).
1949 (x_mouse_leave): Remove; unused.
1950 * xterm.h (x_display_info_for_name, x_raise_frame, x_lower_frame):
1951 (x_destroy_window, x_wm_set_window_state, x_wm_set_icon_pixmap):
1952 (x_delete_display, x_initialize, x_set_border_pixel, x_screen_planes):
1954 (x_mouse_leave): Declare only if WINDOWSNT.
1955 (x_dispatch_event): Declare only if USE_MOTIF or USE_X_TOOLKIT.
1956 (xic_create_fontsetname): Declare only if HAVE_X_WINDOWS &&
1959 * ftxfont.c: Make symbols static if they're not exported.
1960 (ftxfont_driver): Export only if !defined HAVE_XFT && def8ined
1962 * font.h (ftxfont_driver): Likewise.
1964 * xfns.c: Make symbols static if they're not exported.
1965 (x_last_font_name, x_display_info_for_name):
1966 (x_set_foreground_color, x_set_background_color, x_set_mouse_color):
1967 (x_set_cursor_color, x_set_border_pixel, x_set_border_color):
1968 (x_set_cursor_type, x_set_icon_type, x_set_icon_name):
1969 (x_set_scroll_bar_foreground, x_set_scroll_bar_background):
1970 (x_explicitly_set_name, x_set_title, xic_defaut_fontset, tip_timer):
1971 (last_show_tip_args): Now static.
1972 (xic_defaut_fontset, xic_create_fontsetname): Define only if
1973 defined HAVE_X_WINDOWS && defined USE_X_TOOLKIT
1974 (x_screen_planes): Remove; unused.
1975 * dispextern.h (x_screen_planes): Remove decl.
1977 * dispnew.c: Make symbols static if they're not exported.
1978 * dispextern.h (redraw_garbaged_frames, scrolling):
1979 (increment_row_positions): Remove.
1980 * dispnew.c (new_glyph_matrix, increment_row_positions, scrolling):
1981 (delayed_size_change, glyph_matrix_count, glyph_pool_count):
1983 (redraw_garbaged_frames): Remove; unused.
1985 * xfaces.c: Make symbols static if they're not exported.
1986 * dispextern.h (ascii_face_of_lisp_face, free_realized_face):
1988 * xterm.h (defined_color): Remove decls.
1989 (x_free_dpy_colors): Declare only if USE_X_TOOLKIT.
1990 * xfaces.c (tty_suppress_bold_inverse_default_colors_p):
1991 (menu_face_changed_default, defined_color, free_realized_face):
1992 (x_free_dpy_colors): Define only if USE_X_TOOLKIT.
1993 (ascii_face_of_lisp_face): Remove; unused.
1995 * xdisp.c: Make symbols static if they're not exported.
1996 * dispextern.h (scratch_glyph_row, window_box_edges):
1997 (glyph_to_pixel_coords, set_cursor_from_row):
1998 (get_next_display_element, set_iterator_to_next):
1999 (highlight_trailing_whitespace, frame_to_window_pixel_xy):
2000 (show_mouse_face): Remove decls
2001 * frame.h (message_buf_print): Likewise.
2002 * lisp.h (pop_message, set_message, check_point_in_composition):
2004 * xterm.h (set_vertical_scroll_bar): Likewise.
2005 * xdisp.c (list_of_error, Vmessage_stack, line_number_displayed):
2006 (message_buf_print, scratch_glyph_row, displayed_buffer):
2007 (set_iterator_to_next, pop_message, set_message, set_cursor_from_row):
2008 (get_next_display_element, show_mouse_face, window_box_edges):
2009 (frame_to_window_pixel_xy, check_point_in_composition):
2010 (set_vertical_scroll_bar, highlight_trailing_whitespace): Now static.
2011 (glyph_to_pixel_coords): Remove; unused.
2013 * dired.c (file_name_completion): Now static.
2015 * dbusbind.c (xd_in_read_queued_messages): Now static.
2017 * lisp.h (circular_list_error, FOREACH): Remove; unused.
2018 * data.c (circular_list_error): Remove.
2020 * commands.h (last_point_position, last_point_position_buffer):
2021 (last_point_position_window): Remove decls.
2022 * keyboard.c: Make these variables static.
2024 * coding.h (coding, code_convert_region, encode_coding_gap):
2026 * coding.c (Vsjis_coding_system, Vbig5_coding_system):
2027 (iso_code_class, detect_coding, code_convert_region): Now static.
2028 (encode_coding_gap): Remove; unused.
2030 * chartab.c (chartab_chars, chartab_bits): Now static.
2032 * charset.h (charset_iso_8859_1): Remove decl.
2033 * charset.c (charset_iso_8859_1, charset_emacs, map_charset_for_dump):
2036 * ccl.h (check_ccl_update, Vccl_program_table): Remove decls.
2037 * ccl.c (Vccl_program_table): Now static.
2038 (check_ccl_update): Remove; unused.
2040 * category.c (SET_CATEGORY_SET, set_category_set): Move here.
2041 * category.h: ... from here.
2042 * category.c (check_category_table, set_category_set): Now static.
2044 * casetab.c (Vascii_upcase_table, Vascii_eqv_table): Now static.
2045 * lisp.h: Remove these decls.
2047 * buffer.c (buffer_count): Remove unused var.
2049 * bidi.c (bidi_dump_cached_states): Mark as externally visible,
2050 so that it's not optimized away.
2051 (bidi_ignore_explicit_marks_for_paragraph_level): Likewise.
2052 * dispextern.h (bidi_dump_cached_states): Remove, since it's
2053 exported only to the debugger.
2055 * atimer.c (alarm_signal_handler, run_all_atimers): Now static.
2056 * atimer.h (run_all_atimers): Remove; not exported.
2058 font.c: Make copy_font_spec and merge_font_spec ordinary C functions.
2059 * font.c (copy_font_spec): Rename from Fcopy_font_spec, since it
2060 was inaccessible from Lisp.
2061 (merge_font_spec): Likewise, renaming from Fmerge_font_spec.
2062 * font.c, font.h, fontset.c, xfaces.c, xfont.c: Change all uses.
2064 alloc.c: Import and export fewer symbols, and remove unused items.
2065 * lisp.h (suppress_checking, die): Declare only if ENABLE_CHECKING
2067 (suppress_checking): Add EXTERNALLY_VISIBLE attribute, so that
2068 it's not optimized away by whole-program optimization.
2069 (message_enable_multibyte, free_misc): Remove.
2070 (catchlist, handlerlist, mark_backtrace):
2071 Declare only if BYTE_MARK_STACK.
2072 (mark_byte_stack): Likewise, fixing a ifdef-vs-if typo.
2073 * alloc.c (pure): Export only if VIRT_ADDR_VARIES is defined.
2074 (message_enable_multibyte): Remove decl.
2075 (free_misc, interval_free_list, float_block, float_block_index):
2076 (n_float_blocks, float_free_list, cons_block, cons_block_index):
2077 (cons_free_list, last_marked_index):
2079 (suppress_checking, die): Define only if ENABLE_CHECKING is defined.
2080 * eval.c (catchlist, handlerlist): Export only if BYTE_MARK_STACK.
2081 (mark_backtrace): Define only if BYTE_MARK_STACK.
2082 * xdisp.c (message_enable_multibyte): Now static.
2084 Declare Lisp_Object Q* variables to be 'static' if not exported.
2085 This makes it easier for human readers (and static analyzers)
2086 to see whether these variables are used from other modules.
2087 * alloc.c, buffer.c, bytecode.c, callint.c, casetab.c, category.c:
2088 * ccl.c, character.c, charset.c, cmds.c, coding.c, composite.c:
2089 * data.c, dbusbind.c, dired.c, editfns.c, eval.c, fileio.c, fns.c:
2090 * font.c, frame.c, fringe.c, ftfont.c, image.c, keyboard.c, keymap.c:
2091 * lread.c, macros.c, minibuf.c, print.c, process.c, search.c:
2092 * sound.c, syntax.c, textprop.c, window.c, xdisp.c, xfaces.c, xfns.c:
2093 * xmenu.c, xselect.c:
2094 Declare Q* vars static if they are not used in other modules.
2095 * ccl.h, character.h, charset.h, coding.h, composite.h, font.h:
2096 * frame.h, intervals.h, keyboard.h, lisp.h, process.h, syntax.h:
2097 Remove decls of unexported vars.
2098 * keyboard.h (EVENT_HEAD_UNMODIFIED): Remove now-unused macro.
2100 * lisp.h (DEFINE_FUNC): Make sname 'static'.
2102 Make Emacs functions such as Fatom 'static' by default.
2103 This makes it easier for human readers (and static analyzers)
2104 to see whether these functions can be called from other modules.
2105 DEFUN now defines a static function. To make the function external
2106 so that it can be used in other C modules, use the new macro DEFUE.
2107 * lisp.h (Funibyte_char_to_multibyte, Fsyntax_table_p):
2108 (Finit_image_library):
2109 (Feval_region, Fbacktrace, Ffetch_bytecode, Fswitch_to_buffer):
2110 (Ffile_executable_p, Fmake_symbolic_link, Fcommand_execute):
2111 (Fget_process, Fdocumentation_property, Fbyte_code, Ffile_attributes):
2112 Remove decls, since these functions are now static.
2113 (Funintern, Fget_internal_run_time): New decls, since these functions
2114 were already external.
2116 * alloc.c, buffer.c, callint.c, callproc.c, casefiddle.c, casetab.c:
2117 * ccl.c, character.c, chartab.c, cmds.c, coding.c, data.c, dispnew.c:
2118 * doc.c, editfns.c, emacs.c, eval.c, fileio.c, filelock.c, floatfns.c:
2119 * fns.c, font.c, fontset.c, frame.c, image.c, indent.c:
2120 * keyboard.c, keymap.c, lread.c:
2121 * macros.c, marker.c, menu.c, minibuf.c, print.c, process.c, search.c:
2122 * syntax.c, term.c, terminal.c, textprop.c, undo.c:
2123 * window.c, xdisp.c, xfaces.c, xfns.c, xmenu.c, xsettings.c:
2124 Mark functions with DEFUE instead of DEFUN,
2125 if they are used in other modules.
2126 * buffer.c (Fset_buffer_major_mode, Fdelete_overlay): New forward
2127 decls for now-static functions.
2128 * buffer.h (Fdelete_overlay): Remove decl.
2129 * callproc.c (Fgetenv_internal): Mark as internal.
2130 * composite.c (Fremove_list_of_text_properties): Remove decl.
2131 (Fcomposition_get_gstring): New forward static decl.
2132 * composite.h (Fcomposite_get_gstring): Remove decl.
2133 * dired.c (Ffile_attributes): New forward static decl.
2134 * doc.c (Fdocumntation_property): New forward static decl.
2135 * eval.c (Ffetch_bytecode): New forward static decl.
2136 (Funintern): Remove extern decl; now in .h file where it belongs.
2137 * fileio.c (Fmake_symbolic_link): New forward static decl.
2138 * image.c (Finit_image_library): New forward static decl.
2139 * insdel.c (Fcombine_after_change_execute): Make forward decl static.
2140 * intervals.h (Fprevious_property_change):
2141 (Fremove_list_of_text_properties): Remove decls.
2142 * keyboard.c (Fthis_command_keys): Remove decl.
2143 (Fcommand_execute): New forward static decl.
2144 * keymap.c (Flookup_key): New forward static decl.
2145 (Fcopy_keymap): Now static.
2146 * keymap.h (Flookup_key): Remove decl.
2147 * process.c (Fget_process): New forward static decl.
2148 (Fprocess_datagram_address): Mark as internal.
2149 * syntax.c (Fsyntax_table_p): New forward static decl.
2150 (skip_chars): Remove duplicate decl.
2151 * textprop.c (Fprevious_property_change): New forward static decl.
2152 * window.c (Fset_window_fringes, Fset_window_scroll_bars):
2154 (Fset_window_margins, Fset_window_vscroll): New forward static decls.
2155 * window.h (Fset_window_vscroll, Fset_window_margins): Remove decls.
2157 * editfns.c (Fformat): Remove unreachable code.
2159 2011-04-14 Andreas Schwab <schwab@linux-m68k.org>
2161 * fileio.c (Finsert_file_contents): Fix typo in 2005-05-13
2164 2011-04-13 Eli Zaretskii <eliz@gnu.org>
2166 * xdisp.c (handle_invisible_prop): Don't call bidi_paragraph_init
2167 when at ZV. (Bug#8487)
2169 2011-04-12 Andreas Schwab <schwab@linux-m68k.org>
2171 * charset.c (Fclear_charset_maps): Use xfree instead of free.
2173 * keyboard.c (parse_tool_bar_item): Likewise.
2174 * sound.c (sound_cleanup, alsa_close): Likewise.
2175 * termcap.c (tgetent): Likewise.
2176 * xfns.c (x_default_font_parameter): Likewise.
2177 * xsettings.c (read_and_apply_settings): Likewise.
2179 * alloc.c (overrun_check_malloc, overrun_check_realloc)
2180 (overrun_check_free): Protoize.
2182 2011-04-12 Paul Eggert <eggert@cs.ucla.edu>
2184 * sysdep.c (emacs_read, emacs_write): Check for negative sizes
2185 since callers should never pass a negative size.
2186 Change the signature to match that of plain 'read' and 'write'; see
2187 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00397.html>.
2188 * lisp.h: Update prototypes of emacs_write and emacs_read.
2190 2011-04-11 Eli Zaretskii <eliz@gnu.org>
2192 * xdisp.c (redisplay_window): Don't try to determine the character
2193 position of the scroll margin if the window start point w->startp
2194 is outside the buffer's accessible region. (Bug#8468)
2196 2011-04-10 Eli Zaretskii <eliz@gnu.org>
2198 Fix write-region and its subroutines for buffers > 2GB.
2199 * fileio.c (a_write, e_write): Modify declaration of arguments and
2200 local variables to support buffers larger than 2GB.
2201 (Fcopy_file): Use EMACS_INT for return value of emacs_read.
2203 * sysdep.c (emacs_write, emacs_read): Use ssize_t for last
2204 argument, local variables, and return value.
2206 * lisp.h: Update prototypes of emacs_write and emacs_read.
2208 * sound.c (vox_write): Use ssize_t for return value of emacs_write.
2210 2011-04-10 Paul Eggert <eggert@cs.ucla.edu>
2212 * xdisp.c (vmessage): Use memchr, not strnlen, which some hosts lack.
2214 Fix more problems found by GCC 4.6.0's static checks.
2216 * xdisp.c (vmessage): Use a better test for character truncation.
2218 * charset.c (load_charset_map): <, not <=, for optimization,
2219 and to avoid potential problems with integer overflow.
2220 * chartab.c (sub_char_table_set_range, char_table_set_range): Likewise.
2221 * casetab.c (set_identity, shuffle): Likewise.
2222 * editfns.c (Fformat): Likewise.
2223 * syntax.c (skip_chars): Likewise.
2225 * xmenu.c (set_frame_menubar): Allocate smaller local vectors.
2226 This also lets GCC 4.6.0 generate slightly better loop code.
2228 * callint.c (Fcall_interactively): <, not <=, for optimization.
2229 (Fcall_interactively): Count the number of arguments produced,
2230 not the number of arguments given. This is simpler and lets GCC
2231 4.6.0 generate slightly better code.
2233 * ftfont.c: Distingish more carefully between FcChar8 and char.
2234 The previous code passed unsigned char * to a functions like
2235 strlen and xstrcasecmp that expect char *, which does not
2236 conform to the C standard.
2237 (get_adstyle_property, ftfont_pattern_entity): Use FcChar8 for
2238 arguments to FcPatternGetString, and explicitly cast FcChar8 * to
2239 char * when the C standard requires it.
2241 * keyboard.c (read_char): Remove unused var.
2243 * eval.c: Port to Windows vsnprintf (Bug#8435).
2245 (SIZE_MAX): Define if the headers do not.
2246 (verror): Do not give up if vsnprintf returns a negative count.
2247 Instead, grow the buffer. This ports to Windows vsnprintf, which
2248 does not conform to C99. Problem reported by Eli Zaretskii.
2249 Also, simplify the allocation scheme, by avoiding the need for
2250 calling realloc, and removing the ALLOCATED variable.
2252 * eval.c (verror): Initial buffer size is 4000 (not 200) bytes.
2254 Remove invocations of doprnt, as Emacs now uses vsnprintf.
2255 But keep the doprint source code for now, as we might revamp it
2256 and use it again (Bug#8435).
2257 * lisp.h (doprnt): Remove.
2258 * Makefile.in (base_obj): Remove doprnt.o.
2259 * deps.mk (doprnt.o): Remove.
2261 error: Print 32- and 64-bit integers portably (Bug#8435).
2262 Without this change, on typical 64-bit hosts error ("...%d...", N)
2263 was used to print both 32- and 64-bit integers N, which relied on
2265 * lisp.h, src/m/amdx86-64.h, src/m/ia64.h, src/m/ibms390x.h (pEd):
2267 * lisp.h (error, verror): Mark as printf-like functions.
2268 * eval.c (verror): Use vsnprintf, not doprnt, to do the real work.
2269 Report overflow in size calculations when allocating printf buffer.
2270 Do not truncate output string at its first null byte.
2271 * xdisp.c (vmessage): Use vsnprintf, not doprnt, to do the real work.
2272 Truncate the output at a character boundary, since vsnprintf does not
2274 * charset.c (check_iso_charset_parameter): Convert internal
2275 character to string before calling 'error', since %c now has the
2277 * coding.c (Fdecode_sjis_char, Fdecode_big5_char): Avoid int
2278 overflow when computing char to be passed to 'error'. Do not
2279 pass Lisp_Object to 'error'; pass the integer instead.
2280 * nsfns.m (Fns_do_applescript): Use int, not long, since it's
2281 formatted with plain %d.
2283 * eval.c (internal_lisp_condition_case): Don't pass spurious arg.
2285 * keyboard.c (access_keymap_keyremap): Print func name, not garbage.
2287 * coding.c (Fdecode_sjis_char): Don't assume CODE fits in int.
2289 * xterm.c (x_catch_errors): Remove duplicate declaration.
2291 * term.c (maybe_fatal): Mark its 3rd arg as a printf format, too.
2293 * xdisp.c, lisp.h (message_nolog): Remove; unused.
2295 2011-04-10 Jim Meyering <meyering@redhat.com>
2297 use ssize_t and size_t for read- and write-like emacs_gnutls_* functions
2298 * gnutls.c (emacs_gnutls_read): Adjust signature to be more read-like:
2299 return ssize_t not "int", and use size_t as the buffer length.
2300 (emacs_gnutls_write): Likewise, and make the buffer pointer "const".
2301 * gnutls.h: Update declarations.
2302 * process.c (read_process_output): Use ssize_t, to match.
2303 (send_process): Likewise.
2305 2011-04-09 Chong Yidong <cyd@stupidchicken.com>
2307 * image.c (Fimagemagick_types): Doc fix, and comment cleanup.
2309 2011-04-09 Chong Yidong <cyd@stupidchicken.com>
2311 * ftfont.c (get_adstyle_property, ftfont_pattern_entity):
2312 Use unsigned char, to match FcChar8 type definition.
2314 * xterm.c (handle_one_xevent):
2315 * xmenu.c (create_and_show_popup_menu):
2316 * xselect.c (x_decline_selection_request)
2317 (x_reply_selection_request): Avoid type-punned deref of X events.
2319 2011-04-09 Eli Zaretskii <eliz@gnu.org>
2321 Fix some uses of `int' instead of EMACS_INT.
2322 * search.c (string_match_1, fast_string_match)
2323 (fast_c_string_match_ignore_case, fast_string_match_ignore_case)
2324 (scan_buffer, find_next_newline_no_quit)
2325 (find_before_next_newline, search_command, Freplace_match)
2326 (Fmatch_data): Make some `int' variables be EMACS_INT.
2328 * xdisp.c (display_count_lines): 3rd argument and return value now
2329 EMACS_INT. All callers changed.
2330 (pint2hrstr): Last argument is now EMACS_INT.
2332 * coding.c (detect_coding_utf_8, detect_coding_emacs_mule)
2333 (detect_coding_iso_2022, detect_coding_sjis, detect_coding_big5)
2334 (detect_coding_ccl, detect_coding_charset, decode_coding_utf_8)
2335 (decode_coding_utf_16, decode_coding_emacs_mule)
2336 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5)
2337 (decode_coding_ccl, decode_coding_charset)
2338 <consumed_chars, consumed_chars_base>: Declare EMACS_INT.
2339 (decode_coding_iso_2022, decode_coding_emacs_mule)
2340 (decode_coding_sjis, decode_coding_big5, decode_coding_charset)
2341 <char_offset, last_offset>: Declare EMACS_INT.
2342 (encode_coding_utf_8, encode_coding_utf_16)
2343 (encode_coding_emacs_mule, encode_invocation_designation)
2344 (encode_designation_at_bol, encode_coding_iso_2022)
2345 (encode_coding_sjis, encode_coding_big5, encode_coding_ccl)
2346 (encode_coding_raw_text, encode_coding_charset) <produced_chars>:
2348 (ASSURE_DESTINATION): Declare more_bytes EMACS_INT.
2349 (encode_invocation_designation): Last argument P_NCHARS is now
2351 (decode_eol): Declare pos_byte, pos, and pos_end EMACS_INT.
2352 (produce_chars): from_nchars and to_nchars are now EMACS_INT.
2354 * coding.h (struct coding_system) <head_ascii>: Declare EMACS_INT.
2357 * ccl.c (Fccl_execute_on_string): Declare some variables
2360 2011-04-08 Samuel Thibault <sthibault@debian.org> (tiny change)
2362 * term.c (init_tty): Fix incorrect ifdef placement (Bug#8450).
2364 2011-03-19 Christoph Scholtes <cschol2112@googlemail.com>
2366 * process.c (Fformat_network_address): Doc fix.
2368 2011-04-08 T.V. Raman <tv.raman.tv@gmail.com> (tiny change)
2370 * xml.c (parse_region): Avoid creating spurious whiespace nodes.
2372 2011-04-08 Chong Yidong <cyd@stupidchicken.com>
2374 * keyboard.c (read_char): Call Lisp function help-form-show,
2375 instead of using internal_with_output_to_temp_buffer.
2376 (Qhelp_form_show): New var.
2377 (syms_of_keyboard): Use DEFSYM macro.
2379 * print.c (internal_with_output_to_temp_buffer): Function deleted.
2381 * lisp.h (internal_with_output_to_temp_buffer): Remove prototype.
2383 2011-04-06 Chong Yidong <cyd@stupidchicken.com>
2385 * process.c (Flist_processes): Remove to Lisp.
2386 (list_processes_1): Delete.
2388 2011-04-06 Eli Zaretskii <eliz@gnu.org>
2390 * msdos.c (careadlinkat, careadlinkatcwd): MS-DOS replacements.
2392 * w32.c (careadlinkat, careadlinkatcwd): New always-fail stubs.
2394 2011-04-06 Paul Eggert <eggert@cs.ucla.edu>
2396 Fix more problems found by GCC 4.6.0's static checks.
2398 * xmenu.c (Fx_popup_dialog): Don't assume string is free of formats.
2400 * menu.c (Fx_popup_menu): Don't assume error_name lacks printf formats.
2402 * lisp.h (message, message_nolog, fatal): Mark as printf-like.
2404 * xdisp.c (vmessage): Mark as a printf-like function.
2406 * term.c (vfatal, maybe_fatal): Mark as printf-like functions.
2408 * sound.c (sound_warning): Don't crash if arg contains a printf format.
2410 * image.c (tiff_error_handler, tiff_warning_handler): Mark as
2411 printf-like functions.
2412 (tiff_load): Add casts to remove these marks before passing them
2413 to system-supplied API.
2415 * eval.c (Fsignal): Remove excess argument to 'fatal'.
2417 * coding.c (EMIT_ONE_BYTE, EMIT_TWO_BYTES): Use unsigned, not int.
2418 This avoids several warnings with gcc -Wstrict-overflow.
2419 (DECODE_COMPOSITION_RULE): If the rule is invalid, goto invalid_code
2420 directly, rather than having caller test rule sign. This avoids
2421 some unnecessary tests.
2422 * composite.h (COMPOSITION_ENCODE_RULE_VALID): New macro.
2423 (COMPOSITION_ENCODE_RULE): Arguments now must be valid. This
2424 affects only one use, in DECODE_COMPOSITION_RULE, which is changed.
2426 * xfont.c (xfont_text_extents): Remove var that was set but not used.
2427 (xfont_open): Avoid unnecessary tests.
2429 * composite.c (composition_gstring_put_cache): Use unsigned integer.
2431 * composite.h, composite.c (composition_gstring_put_cache):
2432 Use EMACS_INT, not int, for length.
2434 * composite.h (COMPOSITION_DECODE_REFS): New macro,
2435 breaking out part of COMPOSITION_DECODE_RULE.
2436 (COMPOSITION_DECODE_RULE): Use it.
2437 * composite.c (get_composition_id): Remove unused local vars,
2438 by using the new macro.
2440 * textprop.c (set_text_properties_1): Change while to do-while,
2441 since the condition is always true at first.
2443 * intervals.c (graft_intervals_into_buffer): Mark var as used.
2444 (interval_deletion_adjustment): Return unsigned value.
2447 * process.c (list_processes_1, create_pty, read_process_output):
2448 (exec_sentinel): Remove vars that were set but not used.
2449 (create_pty): Remove unnecessary "volatile"s.
2450 (Fnetwork_interface_info): Avoid possibility of int overflow.
2451 (read_process_output): Do adaptive read buffering even if carryover.
2452 (read_process_output): Simplify nbytes computation if buffered.
2454 * bytecode.c (exec_byte_code): Rename local to avoid shadowing.
2456 * syntax.c (scan_words): Remove var that was set but not used.
2457 (update_syntax_table): Use unsigned instead of int.
2459 * lread.c (lisp_file_lexically_bound_p): Use ints rather than endptrs.
2460 (lisp_file_lexically_bound_p, read1): Use unsigned instead of int.
2461 (safe_to_load_p): Make the end-of-loop test the inverse of the in-loop.
2463 * print.c (print_error_message): Avoid int overflow.
2465 * font.c (font_list_entities): Redo for clarity,
2466 so that reader need not know FONT_DPI_INDEX + 1 == FONT_SPACING_INDEX.
2468 * font.c (font_find_for_lface, Ffont_get_glyphs): Remove unused vars.
2469 (font_score): Avoid potential overflow in diff calculation.
2471 * fns.c (substring_both): Remove var that is set but not used.
2472 (sxhash): Redo loop for clarity and to avoid wraparound warning.
2474 * eval.c (funcall_lambda): Rename local to avoid shadowing.
2476 * alloc.c (mark_object_loop_halt, mark_object): Use size_t, not int.
2477 Otherwise, GCC 4.6.0 optimizes the loop check away since the check
2478 can always succeed if overflow has undefined behavior.
2480 * search.c (boyer_moore, wordify): Remove vars set but not used.
2481 (wordify): Omit three unnecessary tests.
2483 * indent.c (MULTIBYTE_BYTES_WIDTH): Don't compute wide_column.
2484 All callers changed. This avoids the need for an unused var.
2486 * casefiddle.c (casify_region): Remove var that is set but not used.
2488 * dired.c (file_name_completion): Remove var that is set but not used.
2490 * fileio.c (Finsert_file_contents): Make EOF condition clearer.
2492 * fileio.c (Finsert_file_contents): Avoid signed integer overflow.
2493 (Finsert_file_contents): Remove unnecessary code checking fd.
2495 * minibuf.c (read_minibuf_noninteractive): Use size_t for sizes.
2496 Check for integer overflow on size calculations.
2498 * buffer.c (Fprevious_overlay_change): Remove var that is set
2501 * keyboard.c (menu_bar_items, read_char_minibuf_menu_prompt):
2502 Remove vars that are set but not used.
2503 (timer_check_2): Don't assume timer-list and idle-timer-list are lists.
2504 (timer_check_2): Mark vars as initialized.
2506 * gtkutil.c (xg_get_file_with_chooser): Mark var as initialized.
2508 * image.c (lookup_image): Remove var that is set but not used.
2509 (xbm_load): Use parse_p, for gcc -Werror=unused-but-set-variable.
2511 * fontset.c (Finternal_char_font, Ffontset_info): Remove vars
2512 that are set but not used.
2514 * xfns.c (make_invisible_cursor): Don't return garbage
2515 if XCreateBitmapFromData fails (Bug#8410).
2517 * xselect.c (x_get_local_selection, x_handle_property_notify):
2518 Remove vars that are set but not used.
2520 * xfns.c (x_create_tip_frame): Remove var that is set but not used.
2521 (make_invisible_cursor): Initialize a possibly-uninitialized variable.
2523 * xterm.c (x_scroll_bar_to_input_event) [!USE_GTK]:
2524 Remove var that is set but not used.
2525 (scroll_bar_windows_size): Now size_t, not int.
2526 (x_send_scroll_bar_event): Use size_t, not int, for sizes.
2529 * xfaces.c (realize_named_face): Remove vars that are set but not used.
2530 (map_tty_color) [!defined MSDOS]: Likewise.
2532 * term.c (tty_write_glyphs): Use size_t; this avoids overflow warning.
2534 * coding.c: Remove vars that are set but not used.
2535 (DECODE_COMPOSITION_RULE): Remove 2nd arg, which is unused.
2536 All callers changed.
2537 (decode_coding_utf_8, decode_coding_utf_16 decode_coding_emacs_mule):
2538 (decode_coding_iso_2022, encode_coding_sjis, encode_coding_big5):
2539 (decode_coding_charset): Remove vars that are set but not used.
2541 * bytecode.c (Fbyte_code) [!defined BYTE_CODE_SAFE]: Remove var
2542 that is set but not used.
2544 * print.c (print_object): Remove var that is set but not used.
2546 Replace 2 copies of readlink code with 1 gnulib version (Bug#8401).
2547 The gnulib version avoids calling malloc in the usual case,
2548 and on 64-bit hosts doesn't have some arbitrary 32-bit limits.
2549 * fileio.c (Ffile_symlink_p): Use emacs_readlink.
2550 * filelock.c (current_lock_owner): Likewise.
2551 * lisp.h (READLINK_BUFSIZE, emacs_readlink): New function.
2552 * sysdep.c: Include allocator.h, careadlinkat.h.
2553 (emacs_no_realloc_allocator): New static constant.
2554 (emacs_readlink): New function.
2555 * deps.mk (sysdep.o): Depend on ../lib/allocator.h and on
2556 ../lib/careadlinkat.h.
2558 2011-04-04 Stefan Monnier <monnier@iro.umontreal.ca>
2560 * keyboard.c (safe_run_hook_funcall): Fix last change (don't stop at the
2561 first non-nil return value).
2563 2011-04-03 Jan Djärv <jan.h.d@swipnet.se>
2565 * nsterm.m (ns_update_auto_hide_menu_bar): Define MAC_OS_X_VERSION_10_6
2566 if not defined (Bug#8403).
2568 2011-04-02 Juanma Barranquero <lekktu@gmail.com>
2570 * xdisp.c (display_count_lines): Remove parameter `start',
2571 unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
2572 (get_char_face_and_encoding): Remove parameter `multibyte_p',
2573 unused since 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
2574 (fill_stretch_glyph_string): Remove parameters `row' and `area',
2575 unused at least since Kim's GUI unification at 2003-03-16T20:45:46Z!storm@cua.dk
2576 and thereabouts. All callers changed.
2577 (get_per_char_metric): Remove parameter `f', unused since
2578 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
2580 2011-04-02 Jim Meyering <meyering@redhat.com>
2582 do not dereference NULL upon failed strdup
2583 * nsfont.m (ns_descriptor_to_entity): Use xstrdup, not strdup.
2584 (ns_get_family): Likewise.
2586 2011-04-02 Juanma Barranquero <lekktu@gmail.com>
2588 * eval.c (unwind_to_catch) [DEBUG_GCPRO]: Remove redundant assignment.
2590 2011-04-02 Jan Djärv <jan.h.d@swipnet.se>
2592 * nsterm.m (ns_update_auto_hide_menu_bar): Only for OSX 10.6 or
2595 2011-04-01 Stefan Monnier <monnier@iro.umontreal.ca>
2597 Add lexical binding.
2599 * window.c (Ftemp_output_buffer_show): New fun.
2600 (Fsave_window_excursion):
2601 * print.c (Fwith_output_to_temp_buffer): Move to subr.el.
2603 * lread.c (lisp_file_lexically_bound_p): New function.
2604 (Fload): Bind Qlexical_binding.
2605 (readevalloop): Remove `evalfun' arg.
2606 Bind Qinternal_interpreter_environment.
2607 (Feval_buffer): Bind Qlexical_binding.
2608 (defvar_int, defvar_bool, defvar_lisp_nopro, defvar_kboard):
2610 (syms_of_lread): Declare `lexical-binding'.
2612 * lisp.h (struct Lisp_Symbol): New field `declared_special'.
2614 * keyboard.c (eval_dyn): New fun.
2615 (menu_item_eval_property): Use it.
2617 * image.c (parse_image_spec): Use Ffunctionp.
2619 * fns.c (concat, mapcar1): Accept byte-code-functions.
2621 * eval.c (Fsetq): Handle lexical vars.
2622 (Fdefun, Fdefmacro, Ffunction): Make closures when needed.
2623 (Fdefconst, Fdefvaralias, Fdefvar): Mark as dynamic.
2624 (FletX, Flet): Obey lexical binding.
2625 (Fcommandp): Handle closures.
2626 (Feval): New `lexical' arg.
2627 (eval_sub): New function extracted from Feval. Use it almost
2628 everywhere where Feval was used. Look up vars in lexical env.
2630 (Ffunctionp): Move from subr.el.
2631 (Ffuncall): Handle closures.
2632 (apply_lambda): Remove `eval_flags'.
2633 (funcall_lambda): Handle closures and new byte-code-functions.
2634 (Fspecial_variable_p): New function.
2635 (syms_of_eval): Initialize the Vinternal_interpreter_environment var,
2636 but without exporting it to Lisp.
2638 * doc.c (Fdocumentation, store_function_docstring):
2639 * data.c (Finteractive_form): Handle closures.
2641 * callint.c (Fcall_interactively): Preserve lexical-binding mode for
2644 * bytecode.c (Bstack_ref, Bstack_set, Bstack_set2, BdiscardN):
2646 (exec_byte_code): New function extracted from Fbyte_code to handle new
2647 calling convention for byte-code-functions. Add new byte-codes.
2649 * buffer.c (defvar_per_buffer): Set new `declared_special' field.
2651 * alloc.c (Fmake_symbol): Init new `declared_special' field.
2653 2011-03-31 Juanma Barranquero <lekktu@gmail.com>
2655 * xdisp.c (redisplay_internal): Fix prototype.
2657 2011-03-31 Eli Zaretskii <eliz@gnu.org>
2659 * xdisp.c (SCROLL_LIMIT): New macro.
2660 (try_scrolling): Use it when setting scroll_limit.
2661 Limit scrolling to 100 screen lines.
2662 (redisplay_window): Even when falling back on "recentering",
2663 position point in the window according to scroll-conservatively,
2664 scroll-margin, and scroll-*-aggressively variables. (Bug#6671)
2666 (try_scrolling): When point is above the window, allow searching
2667 as far as scroll_max, or one screenful, to compute vertical
2668 distance from PT to the scroll margin position. This prevents
2669 try_scrolling from unnecessarily failing when
2670 scroll-conservatively is set to a value slightly larger than the
2671 window height. Clean up the case of PT below the margin at bottom
2672 of window: scroll_max can no longer be INT_MAX. When aggressive
2673 scrolling is in use, don't let point enter the opposite scroll
2674 margin as result of the scroll.
2675 (syms_of_xdisp) <scroll-conservatively>: Document the
2676 threshold of 100 lines for never-recentering scrolling.
2678 2011-03-31 Juanma Barranquero <lekktu@gmail.com>
2680 * dispextern.h (move_it_by_lines):
2681 * xdisp.c (move_it_by_lines): Remove parameter `need_y_p', unused
2682 since 2000-12-29T14:24:09Z!gerd@gnu.org. All callers changed.
2683 (message_log_check_duplicate): Remove parameters `prev_bol' and
2684 `this_bol', unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
2685 (redisplay_internal): Remove parameter `preserve_echo_area',
2686 unused since 1999-07-21T21:43:52Z!gerd@gnu.org. All callers changed.
2688 * indent.c (Fvertical_motion):
2689 * window.c (window_scroll_pixel_based, Frecenter):
2690 Don't pass `need_y_p' to `move_it_by_lines'.
2692 2011-03-30 Stefan Monnier <monnier@iro.umontreal.ca>
2694 * eval.c (struct backtrace): Don't cheat with negative numbers, but do
2695 steal a few bits to be more compact.
2696 (interactive_p, Fbacktrace, Fbacktrace_frame, mark_backtrace):
2697 Remove unneeded casts.
2699 * bytecode.c (Fbyte_code): CAR and CDR can GC.
2701 2011-03-30 Zachary Kanfer <zkanfer@gmail.com> (tiny change)
2703 * keyboard.c (Fexecute_extended_command): Do log the "suggest key
2704 binding" message (bug#7967).
2706 2011-03-30 Paul Eggert <eggert@cs.ucla.edu>
2708 Fix more problems found by GCC 4.6.0's static checks.
2710 * unexelf.c (unexec) [! (defined _SYSTYPE_SYSV || defined __sgi)]:
2711 Remove unused local var.
2713 * editfns.c (Fmessage_box): Remove unused local var.
2715 * xdisp.c (try_window_reusing_current_matrix, x_produce_glyphs):
2716 (note_mode_line_or_margin_highlight, note_mouse_highlight):
2717 Omit unused local vars.
2718 * window.c (shrink_windows): Omit unused local var.
2719 * menu.c (digest_single_submenu): Omit unused local var.
2720 * dispnew.c (update_window) [PERIODIC_PREEMPTION_CHECKING]:
2721 Omit unused local var.
2723 * keyboard.c (parse_modifiers_uncached, parse_modifiers):
2724 Don't assume string length fits in int.
2725 (keyremap_step, read_key_sequence): Use size_t for sizes.
2726 (read_key_sequence): Don't check last_real_key_start redundantly.
2728 * callproc.c (Fcall_process, Fcall_process_region): Use SAFE_ALLOCA
2729 instead of alloca (Bug#8344).
2731 * eval.c (Fbacktrace): Don't assume nargs fits in int.
2732 (Fbacktrace_frame): Don't assume nframes fits in int.
2734 * syntax.c (scan_sexps_forward): Avoid pointer wraparound.
2736 * xterm.c (x_make_frame_visible, same_x_server): Redo to avoid overflow
2739 * term.c (produce_glyphless_glyph): Remove unnecessary test.
2741 * cm.c (calccost): Turn while-do into do-while, for clarity.
2743 * keyboard.c (syms_of_keyboard): Use the same style as later
2744 in this function when indexing through an array. This also
2745 works around GCC bug 48267.
2747 * image.c (tiff_load): Fix off-by-one image count (Bug#8336).
2749 * xselect.c (x_check_property_data): Return correct size (Bug#8335).
2751 * chartab.c (sub_char_table_ref_and_range): Redo for slight
2752 efficiency gain, and to bypass a gcc -Wstrict-overflow warning.
2754 * keyboard.c, keyboard.h (num_input_events): Now size_t.
2755 This avoids undefined behavior on integer overflow, and is a bit
2756 more convenient anyway since it is compared to a size_t variable.
2758 Variadic C functions now count arguments with size_t, not int.
2759 This avoids an unnecessary limitation on 64-bit machines, which
2760 caused (substring ...) to crash on large vectors (Bug#8344).
2761 * lisp.h (struct Lisp_Subr.function.aMANY): Now takes size_t, not int.
2762 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call): Likewise.
2763 All variadic functions and their callers changed accordingly.
2764 (struct gcpro.nvars): Now size_t, not int. All uses changed.
2765 * data.c (arith_driver, float_arith_driver): Likewise.
2766 * editfns.c (general_insert_function): Likewise.
2767 * eval.c (struct backtrace.nargs, interactive_p)
2768 (internal_condition_case_n, run_hook_with_args, apply_lambda)
2769 (funcall_lambda, mark_backtrace): Likewise.
2770 * fns.c (concat): Likewise.
2771 * frame.c (x_set_frame_parameters): Likewise.
2772 * fns.c (get_key_arg): Now accepts and returns size_t, and returns
2773 0 if not found, not -1. All callers changed.
2775 * alloc.c (garbage_collect): Don't assume stack size fits in int.
2776 (stack_copy_size): Now size_t, not int.
2777 (stack_copy, stack_copy_size): Define only if MAX_SAVE_STACK > 0.
2779 2011-03-28 Juanma Barranquero <lekktu@gmail.com>
2781 * coding.c (encode_designation_at_bol): Remove parameter `charbuf_end',
2782 unused since 2002-03-01T01:17:24Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
2783 All callers changed.
2785 * lisp.h (multibyte_char_to_unibyte):
2786 * character.c (multibyte_char_to_unibyte): Remove parameter `rev_tbl',
2787 unused since 2002-03-01T01:16:34Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
2788 * character.h (CHAR_TO_BYTE8):
2789 * cmds.c (internal_self_insert):
2790 * editfns.c (general_insert_function):
2791 * keymap.c (push_key_description):
2792 * search.c (Freplace_match):
2793 * xdisp.c (message_dolog, set_message_1): All callers changed.
2795 2011-03-28 Stefan Monnier <monnier@iro.umontreal.ca>
2797 * keyboard.c (safe_run_hook_funcall): New function.
2798 (safe_run_hooks_1, safe_run_hooks_error, safe_run_hooks): On error,
2799 don't set the hook to nil, but remove the offending function instead.
2800 (Qcommand_hook_internal): Remove, unused.
2801 (syms_of_keyboard): Don't initialize Qcommand_hook_internal nor define
2802 Vcommand_hook_internal.
2804 * eval.c (enum run_hooks_condition): Remove.
2805 (funcall_nil, funcall_not): New functions.
2806 (run_hook_with_args): Call each function through a `funcall' argument.
2807 Remove `cond' argument, now redundant.
2808 (Frun_hooks, Frun_hook_with_args, Frun_hook_with_args_until_success)
2809 (Frun_hook_with_args_until_failure): Adjust accordingly.
2810 (run_hook_wrapped_funcall, Frun_hook_wrapped): New functions.
2812 2011-03-28 Juanma Barranquero <lekktu@gmail.com>
2814 * dispextern.h (string_buffer_position): Remove declaration.
2816 * print.c (strout): Remove parameter `multibyte', unused since
2817 1999-08-21T19:30:21Z!gerd@gnu.org. All callers changed.
2819 * search.c (boyer_moore): Remove parameters `len', `pos' and `lim',
2820 never used since function introduction in 1998-02-08T21:33:56Z!rms@gnu.org.
2821 All callers changed.
2823 * w32.c (_wsa_errlist): Use braces for struct initializers.
2825 * xdisp.c (string_buffer_position_lim): Remove parameter `w',
2826 never used since function introduction in 2001-03-09T18:41:50Z!gerd@gnu.org.
2827 All callers changed.
2828 (string_buffer_position): Likewise. Also, make static (it's never
2829 used outside xdisp.c).
2830 (cursor_row_p): Remove parameter `w', unused since
2831 2000-10-17T16:08:57Z!gerd@gnu.org. All callers changed.
2832 (decode_mode_spec): Remove parameter `precision', introduced during
2833 Gerd Moellmann's rewrite at 1999-07-21T21:43:52Z!gerd@gnu.org, but never used.
2834 All callers changed.
2836 2011-03-27 Jan Djärv <jan.h.d@swipnet.se>
2838 * nsterm.m (syms_of_nsterm): Use doc: for ns-auto-hide-menu-bar.
2840 2011-03-27 Anders Lindgren <andlind@gmail.com>
2842 * nsterm.m (ns_menu_bar_is_hidden): New variable.
2843 (ns_constrain_all_frames, ns_menu_bar_should_be_hidden)
2844 (ns_update_auto_hide_menu_bar): New functions.
2845 (ns_update_begin): Call ns_update_auto_hide_menu_bar.
2846 (applicationDidBecomeActive): Call ns_update_auto_hide_menu_bar and
2847 ns_constrain_all_frames.
2848 (constrainFrameRect): Return at once if ns_menu_bar_should_be_hidden.
2849 (syms_of_nsterm): DEFVAR ns-auto-hide-menu-bar, init to Qnil.
2851 2011-03-27 Jan Djärv <jan.h.d@swipnet.se>
2853 * nsmenu.m (runDialogAt): Remove argument to timer_check.
2855 2011-03-27 Glenn Morris <rgm@gnu.org>
2857 * syssignal.h: Replace RETSIGTYPE with void.
2858 * atimer.c, data.c, dispnew.c, emacs.c, floatfns.c, keyboard.c:
2859 * keyboard.h, lisp.h, process.c, sysdep.c, xterm.c:
2860 Replace SIGTYPE with void everywhere.
2861 * s/usg5-4-common.h (SIGTYPE): Remove definition.
2862 * s/template.h (SIGTYPE): Remove commented out definition.
2864 2011-03-26 Eli Zaretskii <eliz@gnu.org>
2866 * xdisp.c (redisplay_window): Don't check buffer's clip_changed
2867 flag as a prerequisite for invoking try_scrolling. (Bug#6671)
2869 2011-03-26 Juanma Barranquero <lekktu@gmail.com>
2871 * w32.c (read_unc_volume): Use parameter `henum', instead of
2872 global variable `wget_enum_handle'.
2874 * keymap.c (describe_vector): Remove parameters `indices' and
2875 `char_table_depth', unused since 2002-03-01T01:43:26Z!handa@m17n.org.
2876 (describe_map, Fdescribe_vector): Adjust calls to `describe_vector'.
2878 * keyboard.h (timer_check, show_help_echo): Remove unused parameters.
2880 * keyboard.c (timer_check): Remove parameter `do_it_now',
2881 unused since 1996-04-12T06:01:29Z!rms@gnu.org.
2882 (show_help_echo): Remove parameter `ok_to_overwrite_keystroke_echo',
2883 unused since 2008-04-19T19:30:53Z!monnier@iro.umontreal.ca.
2885 * keyboard.c (read_char):
2886 * w32menu.c (w32_menu_display_help):
2887 * xmenu.c (show_help_event, menu_help_callback):
2888 Adjust calls to `show_help_echo'.
2890 * gtkutil.c (xg_maybe_add_timer):
2891 * keyboard.c (readable_events):
2892 * process.c (wait_reading_process_output):
2893 * xmenu.c (x_menu_wait_for_event): Adjust calls to `timer_check'.
2895 * insdel.c (adjust_markers_gap_motion):
2896 Remove; no-op since 1998-01-02T21:29:48Z!rms@gnu.org.
2897 (gap_left, gap_right): Don't call it.
2899 2011-03-25 Chong Yidong <cyd@stupidchicken.com>
2901 * xdisp.c (handle_fontified_prop): Discard changes to clip_changed
2902 incurred during fontification.
2904 2011-03-25 Juanma Barranquero <lekktu@gmail.com>
2906 * buffer.c (defvar_per_buffer): Remove unused parameter `doc'.
2907 (DEFVAR_PER_BUFFER): Don't pass it.
2909 * dispnew.c (row_equal_p, add_row_entry): Remove unused parameter `w'.
2910 (scrolling_window): Don't pass it.
2912 2011-03-25 Juanma Barranquero <lekktu@gmail.com>
2914 * dispextern.h (glyph_matric): Use #if GLYPH_DEBUG, not #ifdef.
2916 * fileio.c (check_executable) [DOS_NT]: Remove unused variables `len'
2918 (Fset_file_selinux_context) [HAVE_LIBSELINUX]: Move here declaration
2919 of variables specific to SELinux and computation of `encoded_absname'.
2921 * image.c (XPutPixel): Remove unused variable `height'.
2923 * keyboard.c (make_lispy_event): Remove unused variable `hpos'.
2925 * unexw32.c (get_section_info): Remove unused variable `section'.
2927 * w32.c (stat): Remove unused variables `drive_root' and `devtype'.
2928 (system_process_attributes): Remove unused variable `sess'.
2929 (sys_read): Remove unused variable `err'.
2931 * w32fns.c (top): Wrap variables with #if GLYPH_DEBUG, not #ifdef.
2932 (w32_wnd_proc): Remove unused variable `isdead'.
2933 (unwind_create_frame): Use #if GLYPH_DEBUG, not #ifdef.
2934 (Fx_server_max_request_size): Remove unused variable `dpyinfo'.
2935 (x_create_tip_frame): Remove unused variable `tem'.
2937 * w32inevt.c (w32_console_read_socket):
2938 Remove unused variable `no_events'.
2940 * w32term.c (x_draw_composite_glyph_string_foreground):
2941 Remove unused variable `width'.
2943 2011-03-24 Juanma Barranquero <lekktu@gmail.com>
2945 * w32term.c (x_set_glyph_string_clipping):
2946 Don't pass uninitialized region to CombineRgn.
2948 2011-03-23 Juanma Barranquero <lekktu@gmail.com>
2950 * w32fns.c (x_set_menu_bar_lines): Remove unused variable `olines'.
2951 (w32_wnd_proc): Pass NULL to Windows API, not uninitialized buffer.
2952 (Fx_close_connection): Remove unused variable `i'.
2954 * w32font.c (w32font_draw): Return number of glyphs.
2955 (w32font_open_internal): Remove unused variable `i'.
2956 (w32font_driver): Add missing initializer.
2958 * w32menu.c (utf8to16): Remove unused variable `utf16'.
2959 (fill_in_menu): Remove unused variable `items_added'.
2961 * w32term.c (last_mouse_press_frame): Remove static global variable.
2962 (w32_clip_to_row): Remove unused variable `f'.
2963 (x_delete_terminal): Remove unused variable `i'.
2965 * w32uniscribe.c (uniscribe_shape): Remove unused variable `nclusters'.
2966 (NOTHING): Remove unused static global variable.
2967 (uniscribe_check_otf): Remove unused variable `table'.
2968 (uniscribe_font_driver): Add missing initializers.
2970 2011-03-23 Julien Danjou <julien@danjou.info>
2972 * term.c (Fsuspend_tty, Fresume_tty):
2973 * minibuf.c (read_minibuf, run_exit_minibuf_hook):
2974 * window.c (temp_output_buffer_show):
2975 * insdel.c (signal_before_change):
2976 * frame.c (Fhandle_switch_frame):
2977 * fileio.c (Fdo_auto_save):
2978 * emacs.c (Fkill_emacs):
2979 * editfns.c (save_excursion_restore):
2980 * cmds.c (internal_self_insert):
2981 * callint.c (Fcall_interactively):
2982 * buffer.c (Fkill_all_local_variables):
2983 * keyboard.c (Fcommand_execute, Fsuspend_emacs, safe_run_hooks_1):
2985 (command_loop_1): Use Frun_hooks. Call safe_run_hooks
2986 unconditionnaly since it does the check itself.
2988 2011-03-23 Paul Eggert <eggert@cs.ucla.edu>
2990 Fix more problems found by GCC 4.5.2's static checks.
2992 * coding.c (encode_coding_raw_text): Avoid unnecessary test
2993 the first time through the loop, since we know p0 < p1 then.
2994 This also avoids a gcc -Wstrict-overflow warning.
2996 * lisp.h (SAFE_ALLOCA, SAFE_ALLOCA_LISP): Avoid 'int' overflow
2997 leading to a memory leak, possible in functions like
2998 load_charset_map_from_file that can allocate an unbounded number
2999 of objects (Bug#8318).
3001 * xmenu.c (set_frame_menubar): Use EMACS_UINT, not int, for indexes
3002 that could (at least in theory) be that large.
3004 * xdisp.c (message_log_check_duplicate): Return unsigned long, not int.
3005 This is less likely to overflow, and avoids undefined behavior if
3006 overflow does occur. All callers changed. Use strtoul to scan
3007 for the unsigned long integer.
3008 (pint2hrstr): Simplify and tune code slightly.
3009 This also avoids a (bogus) GCC warning with gcc -Wstrict-overflow.
3011 * scroll.c (do_scrolling): Work around GCC bug 48228.
3012 See <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=48228>.
3014 * frame.c (Fmodify_frame_parameters): Simplify loop counter.
3015 This also avoids a warning with gcc -Wstrict-overflow.
3016 (validate_x_resource_name): Simplify count usage.
3017 This also avoids a warning with gcc -Wstrict-overflow.
3019 * fileio.c (Fcopy_file): Report error if fchown or fchmod
3022 * emacs.c (Fdaemon_initialized): Do not ignore I/O errors (Bug#8303).
3024 * process.c (Fmake_network_process): Use socklen_t, not int,
3025 where POSIX says socklen_t is required in portable programs.
3026 This fixes a porting bug on hosts like 64-bit HP-UX, where
3027 socklen_t is wider than int (Bug#8277).
3028 (Fmake_network_process, server_accept_connection):
3029 (wait_reading_process_output, read_process_output):
3032 * process.c: Rename or move locals to avoid shadowing.
3033 (list_processes_1, Fmake_network_process):
3034 (read_process_output_error_handler, exec_sentinel_error_handler):
3035 Rename or move locals.
3036 (Fmake_network_process): Define label "retry_connect" only if needed.
3037 (Fnetwork_interface_info): Fix pointer signedness.
3038 (process_send_signal): Add cast to avoid pointer signedness problem.
3039 (FIRST_PROC_DESC, IF_NON_BLOCKING_CONNECT): Remove unused macros.
3040 (create_process): Use 'volatile' to avoid vfork clobbering (Bug#8298).
3042 Make tparam.h and terminfo.c consistent.
3043 * cm.c (tputs, tgoto, BC, UP): Remove extern decls.
3044 Include tparam.h instead, since it declares them.
3045 * cm.h (PC): Remove extern decl; tparam.h now does this.
3046 * deps.mk (cm.o, terminfo.o): Depend on tparam.h.
3047 * terminfo.c: Include tparam.h, to check interfaces.
3048 (tparm): Make 1st arg a const pointer in decl. Put it at top level.
3049 (tparam): Adjust signature to match interface in tparam.h;
3050 this removes some undefined behavior. Check that outstring and len
3051 are zero, which they always are with Emacs.
3052 * tparam.h (PC, BC, UP): New extern decls.
3054 * xftfont.c (xftfont_shape): Now static, and defined only if needed.
3055 (xftfont_open): Rename locals to avoid shadowing.
3057 * ftfont.c (ftfont_resolve_generic_family): Fix pointer signedness.
3058 (ftfont_otf_capability, ftfont_shape): Omit decls if not needed.
3059 (OTF_TAG_SYM): Omit macro if not needed.
3060 (ftfont_list): Remove unused local.
3061 (get_adstyle_property, ftfont_pattern_entity):
3062 (ftfont_lookup_cache, ftfont_open, ftfont_anchor_point):
3063 Rename locals to avoid shadowing.
3065 * xfont.c (xfont_list_family): Mark var as initialized.
3067 * xml.c (make_dom): Now static.
3069 * composite.c (composition_compute_stop_pos): Rename local to
3071 (composition_reseat_it): Remove unused locals.
3072 (find_automatic_composition, composition_adjust_point): Likewise.
3073 (composition_update_it): Mark var as initialized.
3074 (find_automatic_composition): Mark vars as initialized,
3075 with a FIXME (Bug#8290).
3077 character.h: Rename locals to avoid shadowing.
3078 * character.h (PREV_CHAR_BOUNDARY, FETCH_STRING_CHAR_ADVANCE):
3079 (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE, FETCH_CHAR_ADVANCE):
3080 (FETCH_CHAR_ADVANCE_NO_CHECK, INC_POS, DEC_POS, BUF_INC_POS):
3081 (BUF_DEC_POS): Be more systematic about renaming local temporaries
3084 * textprop.c (property_change_between_p): Remove; unused.
3086 * intervals.c (interval_start_pos): Now static.
3088 * intervals.h (CHECK_TOTAL_LENGTH): Avoid empty "else".
3090 * atimer.c (start_atimer, append_atimer_lists, set_alarm):
3091 Rename locals to avoid shadowing.
3093 * sound.c (wav_play, au_play, Fplay_sound_internal):
3094 Fix pointer signedness.
3095 (alsa_choose_format): Remove unused local var.
3096 (wav_play): Initialize a variable to 0, to prevent undefined
3097 behavior (Bug#8278).
3099 * region-cache.c (insert_cache_boundary): Redo var to avoid shadowing.
3101 * region-cache.h (pp_cache): New decl, for gcc -Wmissing-prototypes.
3103 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork
3104 clobbering (Bug#8298).
3105 * sysdep.c (sys_subshell): Likewise.
3106 Previously, the sys_subshell 'volatile' was incorrectly IF_LINTted out.
3108 * lisp.h (child_setup): Now NO_RETURN unless DOS_NT.
3109 This should get cleaned up, so that child_setup has the
3110 same signature on all platforms.
3112 * callproc.c (call_process_cleanup): Now static.
3113 (relocate_fd): Rename locals to avoid shadowing.
3115 2011-03-22 Chong Yidong <cyd@stupidchicken.com>
3117 * xterm.c (x_clear_frame): Remove XClearWindow call. This appears
3118 not to be necessary, and produces flickering.
3120 2011-03-20 Glenn Morris <rgm@gnu.org>
3122 * config.in: Remove file.
3124 2011-03-20 Juanma Barranquero <lekktu@gmail.com>
3126 * minibuf.c (Vcompleting_read_function): Don't declare, global variables
3127 are now in src/globals.h.
3128 (syms_of_minibuf): Remove spurious & from previous change.
3130 2011-03-20 Leo <sdl.web@gmail.com>
3132 * minibuf.c (completing-read-function): New variable.
3133 (completing-read-default): Rename from completing-read.
3134 (completing-read): Call completing-read-function.
3136 2011-03-19 Juanma Barranquero <lekktu@gmail.com>
3138 * xfaces.c (Fx_load_color_file):
3139 Read color file from absolute filename (bug#8250).
3141 2011-03-19 Juanma Barranquero <lekktu@gmail.com>
3143 * makefile.w32-in: Update dependencies.
3145 2011-03-17 Eli Zaretskii <eliz@gnu.org>
3147 * makefile.w32-in ($(BLD)/unexw32.$(O)): Depend on $(SRC)/unexec.h.
3149 2011-03-17 Paul Eggert <eggert@cs.ucla.edu>
3151 Fix more problems found by GCC 4.5.2's static checks.
3153 * process.c (make_serial_process_unwind, send_process_trap):
3154 (sigchld_handler): Now static.
3156 * process.c (allocate_pty): Let PTY_ITERATION declare iteration vars.
3157 That way, the code declares only the vars that it needs.
3158 * s/aix4-2.h (PTY_ITERATION): Declare iteration vars.
3159 * s/cygwin.h (PTY_ITERATION): Likewise.
3160 * s/darwin.h (PTY_ITERATION): Likewise.
3161 * s/gnu-linux.h (PTY_ITERATION): Likewise.
3163 * s/irix6-5.h (PTY_OPEN): Declare stb, to loosen coupling.
3164 * process.c (allocate_pty): Don't declare stb unless it's needed.
3166 * bytecode.c (MAYBE_GC): Rewrite so as not to use empty "else".
3167 (CONSTANTLIM): Remove; unused.
3168 (METER_CODE, Bscan_buffer, Bread_char, Bset_mark):
3169 Define only if needed.
3171 * unexelf.c (unexec): Name an expression,
3172 to avoid gcc -Wbad-function-cast warning.
3173 Use a different way to cause a compilation error if anyone uses
3174 n rather than nn, a way that does not involve shadowing.
3175 (ELF_BSS_SECTION_NAME, OLD_PROGRAM_H): Remove; unused.
3177 * deps.mk (unexalpha.o): Remove; unused.
3179 New file unexec.h, the (simple) interface for unexec (Bug#8267).
3180 * unexec.h: New file.
3181 * deps.mk (emacs.o, unexaix.o, unexcw.o, unexcoff.o, unexelf.o):
3182 (unexhp9k800.o, unexmacosx.o, unexsol.o, unexw32.o):
3184 * emacs.c [!defined CANNOT_DUMP]: Include unexec.h.
3185 * unexaix.c, unexcoff.c, unexcw.c, unexelf.c, unexhp9k800.c:
3186 * unexmacosx.c, unexsol.c, unexw32.c: Include unexec.h.
3187 Change as necessary to match prototype in unexec.h.
3189 * syntax.c (Fforward_comment, scan_lists): Rename locals to avoid
3191 (back_comment, skip_chars): Mark vars as initialized.
3193 * character.h (FETCH_STRING_CHAR_ADVANCE_NO_CHECK, BUF_INC_POS):
3194 Rename locals to avoid shadowing.
3196 * lread.c (read1): Rewrite so as not to use empty "else".
3197 (Fload, readevalloop, read1): Rename locals to avoid shadowing.
3199 * print.c (Fredirect_debugging_output): Fix pointer signedess.
3201 * lisp.h (debug_output_compilation_hack): Add decl here, to avoid
3202 warning when compiling print.c.
3204 * font.c (font_unparse_fcname): Abort in an "impossible" situation
3205 instead of using an uninitialized var.
3206 (font_sort_entities): Mark var as initialized.
3208 * character.h (FETCH_CHAR_ADVANCE): Rename locals to avoid shadowing.
3210 * font.c (font_unparse_xlfd): Don't mix pointers to variables with
3211 pointers to constants.
3212 (font_parse_fcname): Remove unused vars.
3213 (font_delete_unmatched): Now static.
3214 (font_get_spec): Remove; unused.
3215 (font_style_to_value, font_prop_validate_style, font_unparse_fcname):
3216 (font_update_drivers, Ffont_get_glyphs, font_add_log):
3217 Rename or move locals to avoid shadowing.
3219 * fns.c (require_nesting_list, require_unwind): Now static.
3220 (Ffillarray): Rename locals to avoid shadowing.
3222 * floatfns.c (domain_error2): Define only if needed.
3223 (Ffrexp, Fldexp): Rename locals to avoid shadowing.
3225 * alloc.c (mark_backtrace): Move decl from here ...
3226 * lisp.h: ... to here, so that it can be checked.
3228 * eval.c (call_debugger, do_debug_on_call, grow_specpdl): Now static.
3229 (Fdefvar): Rewrite so as not to use empty "else".
3230 (lisp_indirect_variable): Name an expression,
3231 to avoid gcc -Wbad-function-cast warning.
3232 (Fdefvar): Rename locals to avoid shadowing.
3234 * callint.c (quotify_arg, quotify_args): Now static.
3235 (Fcall_interactively): Rename locals to avoid shadowing.
3236 Use const pointer when appropriate.
3238 * lisp.h (get_system_name, get_operating_system_release):
3239 Move decls here, to check interfaces.
3240 * process.c (get_operating_system_release): Move decl to lisp.h.
3241 * xrdb.c (get_system_name): Likewise.
3242 * editfns.c (init_editfns, Fuser_login_name, Fuser_uid):
3243 (Fuser_real_uid, Fuser_full_name): Remove unnecessary casts,
3244 some of which prompt warnings from gcc -Wbad-function-cast.
3245 (Fformat_time_string, Fencode_time, Finsert_char):
3246 (Ftranslate_region_internal, Fformat):
3247 Rename or remove local vars to avoid shadowing.
3248 (Ftranslate_region_internal): Mark var as initialized.
3250 * doc.c (Fdocumentation, Fsnarf_documentation): Move locals to
3253 * lisp.h (eassert): Check that the argument compiles, even if
3254 ENABLE_CHECKING is not defined.
3256 * data.c (Findirect_variable): Name an expression, to avoid
3257 gcc -Wbad-function-cast warning.
3258 (default_value, arithcompare, arith_driver, arith_error): Now static.
3259 (store_symval_forwarding): Rename local to avoid shadowing.
3260 (Fmake_variable_buffer_local, Fmake_local_variable):
3261 Mark variables as initialized.
3262 (do_blv_forwarding, do_symval_forwarding): Remove; unused.
3264 * alloc.c (check_cons_list): Do not define unless GC_CHECK_CONS_LIST.
3265 (Fmake_vector, Fvector, Fmake_byte_code, Fgarbage_collect):
3266 Rename locals to avoid shadowing.
3267 (mark_stack): Move local variables into the #ifdef region where
3269 (BLOCK_INPUT_ALLOC, UNBLOCK_INPUT_ALLOC): Define only if
3270 ! defined SYSTEM_MALLOC && ! defined SYNC_INPUT, as they are not
3272 (CHECK_ALLOCATED): Define only if GC_CHECK_MARKED_OBJECTS.
3273 (GC_STRING_CHARS): Remove; not used.
3274 (Fmemory_limit): Cast sbrk's returned value to char *.
3276 * lisp.h (check_cons_list): Declare if GC_CHECK_CONS_LIST; this
3277 avoids undefined behavior in theory.
3279 * regex.c (IF_LINT): Add defn, for benefit of ../lib-src.
3281 Use functions, not macros, for up- and down-casing (Bug#8254).
3282 * buffer.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
3283 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Remove. All callers changed
3284 to use the following functions instead of these macros.
3285 (downcase): Adjust to lack of DOWNCASE_TABLE. Return int, not
3286 EMACS_INT, since callers assume the returned value fits in int.
3287 (upcase1): Likewise, for UPCASE_TABLE.
3288 (uppercasep, lowercasep, upcase): New static inline functions.
3289 * editfns.c (Fchar_equal): Remove no-longer-needed workaround for
3290 the race-condition problem in the old DOWNCASE.
3292 * regex.c (CHARSET_LOOKUP_RANGE_TABLE_RAW, POP_FAILURE_REG_OR_COUNT):
3293 Rename locals to avoid shadowing.
3294 (regex_compile, re_match_2_internal): Move locals to avoid shadowing.
3295 (regex_compile, re_search_2, re_match_2_internal):
3296 Remove unused local vars.
3297 (FREE_VAR): Rewrite so as not to use empty "else",
3298 which gcc can warn about.
3299 (regex_compile, re_match_2_internal): Mark locals as initialized.
3300 (RETALLOC_IF): Define only if needed.
3301 (WORDCHAR_P): Likewise. This one is never needed, but is used
3302 only in a comment talking about a compiler bug, so put inside
3303 the #if 0 of that comment.
3304 (CHARSET_LOOKUP_BITMAP, FAIL_STACK_FULL, RESET_FAIL_STACK):
3305 (PUSH_FAILURE_ELT, BUF_PUSH_3, STOP_ADDR_VSTRING):
3308 * search.c (boyer_moore): Rename locals to avoid shadowing.
3309 * character.h (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE):
3310 (PREV_CHAR_BOUNDARY): Likewise.
3312 * search.c (simple_search): Remove unused var.
3314 * dired.c (compile_pattern): Move decl from here ...
3315 * lisp.h: ... to here, so that it can be checked.
3316 (struct re_registers): New forward decl.
3318 * character.h (INC_POS, DEC_POS): Rename locals to avoid shadowing.
3320 * indent.c (MULTIBYTE_BYTES_WIDTH): New args bytes, width.
3322 (MULTIBYTE_BYTES_WIDTH, scan_for_column, compute_motion):
3323 Rename locals to avoid shadowing.
3324 (Fvertical_motion): Mark locals as initialized.
3326 * casefiddle.c (casify_object, casify_region): Now static.
3327 (casify_region): Mark local as initialized.
3329 * cmds.c (internal_self_insert): Rename local to avoid shadowing.
3331 * lisp.h (GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR, GCPRO5_VAR, GCPRO6_VAR):
3332 New macros, so that the caller can use some names other than
3333 gcpro1, gcpro2, etc.
3334 (GCPRO2, GCPRO3, GCPRO4, GCPRO5, GCPRO6): Reimplement in terms
3336 (GCPRO1_VAR, UNGCPRO_VAR): Change the meaning of the second
3337 argument, for consistency with GCPRO2_VAR, etc: it is now the
3338 prefix of the variable, not the variable itself. All uses
3340 * dired.c (directory_files_internal, file_name_completion):
3341 Rename locals to avoid shadowing.
3343 Fix a race condition diagnosed by gcc -Wsequence-point (Bug#8254).
3344 An expression of the form (DOWNCASE (x) == DOWNCASE (y)), found in
3345 dired.c's scmp function, had undefined behavior.
3346 * lisp.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
3347 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Move from here ...
3348 * buffer.h: ... to here, because these macros use current_buffer,
3349 and the new implementation with inline functions needs to have
3350 current_buffer in scope now, rather than later when the macros
3352 (downcase, upcase1): New static inline functions.
3353 (DOWNCASE, UPCASE1): Reimplement using these functions.
3354 This avoids undefined behavior in expressions like
3355 DOWNCASE (x) == DOWNCASE (y), which previously suffered
3356 from race conditions in accessing the global variables
3357 case_temp1 and case_temp2.
3358 * casetab.c (case_temp1, case_temp2): Remove; no longer needed.
3359 * lisp.h (case_temp1, case_temp2): Remove their decls.
3360 * character.h (ASCII_CHAR_P): Move from here ...
3361 * lisp.h: ... to here, so that the inline functions mentioned
3364 * dired.c (directory_files_internal_unwind): Now static.
3366 * fileio.c (file_name_as_directory, directory_file_name):
3367 (barf_or_query_if_file_exists, auto_save_error, auto_save_1):
3369 (file_name_as_directory): Use const pointers when appropriate.
3370 (Fexpand_file_name): Likewise. In particular, newdir might
3371 point at constant storage, so make it a const pointer.
3372 (Fmake_directory_internal, Fread_file_name): Remove unused vars.
3373 (Ffile_selinux_context, Fset_file_selinux_context): Fix pointer
3375 (Fset_file_times, Finsert_file_contents, auto_save_error):
3376 Rename locals to avoid shadowing.
3378 * minibuf.c (choose_minibuf_frame_1): Now static.
3379 (Ftry_completion, Fall_completions): Rename or remove locals
3382 * marker.c (bytepos_to_charpos): Remove; unused.
3384 * lisp.h (verify_bytepos, count_markers): New decls,
3385 so that gcc does not warn that these functions aren't declared.
3387 * insdel.c (check_markers, make_gap_larger, make_gap_smaller):
3388 (reset_var_on_error, Fcombine_after_change_execute_1): Now static.
3389 (CHECK_MARKERS): Redo to avoid gcc -Wempty-body diagnostic.
3390 (copy_text): Remove unused local var.
3392 * filelock.c (within_one_second): Now static.
3393 (lock_file_1): Rename local to avoid shadowing.
3395 * buffer.c (fix_overlays_before): Mark locals as initialized.
3396 (fix_start_end_in_overlays): Likewise. This function should be
3397 simplified by using pointers-to-pointers, but that's a different
3399 (switch_to_buffer_1): Now static.
3400 (Fkill_buffer, record_buffer, Fbury_buffer, Fset_buffer_multibyte):
3401 (report_overlay_modification): Rename locals to avoid shadowing.
3403 * sysdep.c (system_process_attributes): Rename vars to avoid shadowing.
3404 Fix pointer signedness issue.
3405 (sys_subshell): Mark local as volatile if checking for lint,
3406 to suppress a gcc -Wclobbered warning that does not seem to be right.
3407 (MAXPATHLEN): Define only if needed.
3409 * process.c (serial_open, serial_configure): Move decls from here ...
3410 * systty.h: ... to here, so that they can be checked.
3412 * fns.c (get_random, seed_random): Move extern decls from here ...
3413 * lisp.h: ... to here, so that they can be checked.
3415 * sysdep.c (reset_io): Now static.
3416 (wait_for_termination_signal): Remove; unused.
3418 * keymap.c (keymap_parent, keymap_memberp, map_keymap_internal):
3419 (copy_keymap_item, append_key, push_text_char_description):
3421 (Fwhere_is_internal): Don't test CONSP (sequences) unnecessarily.
3422 (DENSE_TABLE_SIZE): Remove; unused.
3423 (get_keymap, access_keymap, Fdefine_key, Fwhere_is_internal):
3424 (describe_map_tree):
3425 Rename locals to avoid shadowing.
3427 * keyboard.c: Declare functions static if they are not used elsewhere.
3428 (echo_char, echo_dash, cmd_error, top_level_2):
3429 (poll_for_input, handle_async_input): Now static.
3430 (read_char, kbd_buffer_get_event, make_lispy_position):
3431 (make_lispy_event, make_lispy_movement, apply_modifiers):
3432 (decode_keyboard_code, tty_read_avail_input, menu_bar_items):
3433 (parse_tool_bar_item, read_key_sequence, Fread_key_sequence):
3434 (Fread_key_sequence_vector): Rename locals to avoid shadowing.
3435 (read_key_sequence, read_char): Mark locals as initialized.
3436 (Fexit_recursive_edit, Fabort_recursive_edit): Mark with NO_RETURN.
3438 * keyboard.h (make_ctrl_char): New decl.
3439 (mark_kboards): Move decl here ...
3440 * alloc.c (mark_kboards): ... from here.
3442 * lisp.h (force_auto_save_soon): New decl.
3444 * emacs.c (init_cmdargs): Rename local to avoid shadowing.
3445 (DEFINE_DUMMY_FUNCTION): New macro.
3446 (__do_global_ctors, __do_global_ctors_aux, __do_global_dtors, __main):
3448 (main): Add casts to avoid warnings
3449 if GCC considers string literals to be constants.
3451 * lisp.h (fatal_error_signal): Add decl, since it's exported.
3453 * dbusbind.c: Pointer signedness fixes.
3454 (xd_signature, xd_append_arg, xd_initialize):
3455 (Fdbus_call_method, Fdbus_call_method_asynchronously):
3456 (Fdbus_method_return_internal, Fdbus_method_error_internal):
3457 (Fdbus_send_signal, xd_read_message_1, Fdbus_register_service):
3458 (Fdbus_register_signal): Use SSDATA when the context wants char *.
3460 * dbusbind.c (Fdbus_init_bus): Add cast to avoid warning
3461 if GCC considers string literals to be constants.
3462 (Fdbus_register_service, Fdbus_register_method): Remove unused vars.
3464 2011-03-16 Stefan Monnier <monnier@iro.umontreal.ca>
3466 * print.c (PRINT_CIRCLE_CANDIDATE_P): New macro.
3467 (print_preprocess, print_object): New macro to fix last change.
3469 * print.c (print_preprocess): Don't forget font objects.
3471 2011-03-16 Juanma Barranquero <lekktu@gmail.com>
3473 * emacs.c (USAGE3): Doc fixes.
3475 2011-03-15 Andreas Schwab <schwab@linux-m68k.org>
3477 * coding.c (detect_coding_iso_2022): Reorganize code to clarify
3480 2011-03-14 Juanma Barranquero <lekktu@gmail.com>
3482 * lisp.h (VWindow_system, Qfile_name_history):
3483 * keyboard.h (lispy_function_keys) [WINDOWSNT]:
3484 * w32term.h (w32_system_caret_hwnd, w32_system_caret_height)
3485 (w32_system_caret_x, w32_system_caret_y): Declare extern.
3487 * w32select.c: Don't #include "keyboard.h".
3488 (run_protected): Add extern declaration for waiting_for_input.
3490 * w32.c (Qlocal, noninteractive1, inhibit_window_system):
3491 * w32console.c (detect_input_pending, read_input_pending)
3492 (encode_terminal_code):
3493 * w32fns.c (quit_char, lispy_function_keys, Qtooltip)
3494 (w32_system_caret_hwnd, w32_system_caret_height, w32_system_caret_x)
3495 (w32_system_caret_y, Qfile_name_history):
3496 * w32font.c (w32font_driver, QCantialias, QCotf, QClang):
3497 * w32inevt.c (reinvoke_input_signal, lispy_function_keys):
3498 * w32menu.c (Qmenu_bar, QCtoggle, QCradio, Qoverriding_local_map)
3499 (Qoverriding_terminal_local_map, Qmenu_bar_update_hook):
3500 * w32proc.c (Qlocal, report_file_error):
3501 * w32term.c (Vwindow_system, updating_frame):
3502 * w32uniscribe.c (initialized, uniscribe_font_driver):
3503 Remove unneeded extern declarations.
3505 2011-03-14 Chong Yidong <cyd@stupidchicken.com>
3507 * buffer.c (Fmake_indirect_buffer): Fix incorrect assertions.
3509 2011-03-13 Chong Yidong <cyd@stupidchicken.com>
3511 * buffer.h (BUF_BEGV, BUF_BEGV_BYTE, BUF_ZV, BUF_ZV_BYTE, BUF_PT)
3512 (BUF_PT_BYTE): Rewrite to handle indirect buffers (Bug#8219).
3513 These macros can no longer be used for assignment.
3515 * buffer.c (Fget_buffer_create, Fmake_indirect_buffer):
3516 Assign struct members directly, instead of using BUF_BEGV etc.
3517 (record_buffer_markers, fetch_buffer_markers): New functions for
3518 recording and fetching special buffer markers.
3519 (set_buffer_internal_1, set_buffer_temp): Use them.
3521 * lread.c (unreadchar): Use SET_BUF_PT_BOTH.
3523 * insdel.c (adjust_point): Use SET_BUF_PT_BOTH.
3525 * intervals.c (temp_set_point_both): Use SET_BUF_PT_BOTH.
3526 (get_local_map): Use SET_BUF_BEGV_BOTH and SET_BUF_ZV_BOTH.
3528 * xdisp.c (hscroll_window_tree):
3529 (reconsider_clip_changes): Use PT instead of BUF_PT.
3531 2011-03-13 Eli Zaretskii <eliz@gnu.org>
3533 * makefile.w32-in ($(BLD)/editfns.$(O)): Depend on
3534 $(EMACS_ROOT)/lib/intprops.h.
3536 2011-03-13 Paul Eggert <eggert@cs.ucla.edu>
3538 Fix more problems found by GCC 4.5.2's static checks.
3540 * gtkutil.c (xg_get_pixbuf_from_pixmap): Add cast from char *
3541 to unsigned char * to avoid compiler diagnostic.
3542 (xg_free_frame_widgets): Make it clear that a local variable is
3543 needed only if USE_GTK_TOOLTIP.
3544 (gdk_window_get_screen): Make it clear that this macro is needed
3545 only if USE_GTK_TOOLTIP.
3546 (int_gtk_range_get_value): New function, which avoids a diagnostic
3547 from gcc -Wbad-function-cast.
3548 (xg_set_toolkit_scroll_bar_thumb): Use it.
3549 (xg_tool_bar_callback, xg_tool_item_stale_p): Rewrite to avoid
3550 diagnostic from gcc -Wbad-function-cast.
3551 (get_utf8_string, xg_get_file_with_chooser):
3552 Rename locals to avoid shadowing.
3553 (create_dialog): Move locals to avoid shadowing.
3555 * xgselect.c (xg_select): Remove unused var.
3557 * image.c (four_corners_best): Mark locals as initialized.
3558 (gif_load): Initialize transparent_p to zero (Bug#8238).
3559 Mark another local as initialized.
3560 (my_png_error, my_error_exit): Mark with NO_RETURN.
3562 * image.c (clear_image_cache): Now static.
3563 (DIM, HAVE_STDLIB_H_1): Remove unused macros.
3564 (xpm_load): Redo to avoid "discards qualifiers" gcc warning.
3565 (x_edge_detection): Remove unnecessary cast that
3566 gcc -Wbad-function-cast diagnoses.
3567 (gif_load): Fix pointer signedness.
3568 (clear_image_cache, xbm_read_bitmap_data, x_detect_edges):
3569 (jpeg_load, gif_load): Rename locals to avoid shadowing.
3571 2011-03-12 Paul Eggert <eggert@cs.ucla.edu>
3573 Improve quality of tests for time stamp overflow.
3574 For example, without this patch (encode-time 0 0 0 1 1
3575 1152921504606846976) returns the obviously-bogus value (-948597
3576 62170) on my RHEL 5.5 x86-64 host. With the patch, it correctly
3577 reports time overflow. See
3578 <http://lists.gnu.org/archive/html/emacs-devel/2011-03/msg00470.html>.
3579 * deps.mk (editfns.o): Depend on ../lib/intprops.h.
3580 * editfns.c: Include limits.h and intprops.h.
3581 (TIME_T_MIN, TIME_T_MAX): New macros.
3582 (time_overflow): Move earlier, to before first use.
3583 (hi_time, lo_time): New functions, for an accurate test for
3585 (Fcurrent_time, Fget_internal_run_time, make_time): Use them.
3586 (Fget_internal_run_time): Don't assume time_t fits in int.
3587 (make_time): Use list2 instead of Fcons twice.
3588 (Fdecode_time): More accurate test for out-of-range times.
3589 (check_tm_member): New function.
3590 (Fencode_time): Use it, to test for out-of-range times.
3591 (lisp_time_argument): Don't rely on undefined left-shift and
3592 right-shift behavior when checking for time stamp overflow.
3594 * editfns.c (time_overflow): New function, refactoring common code.
3595 (Fformat_time_string, Fdecode_time, Fencode_time):
3596 (Fcurrent_time_string): Use it.
3598 Move 'make_time' to be next to its inverse 'lisp_time_argument'.
3599 * dired.c (make_time): Move to ...
3600 * editfns.c (make_time): ... here.
3601 * systime.h: Note the move.
3603 2011-03-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
3605 * fringe.c (update_window_fringes): Remove unused variables.
3607 * unexmacosx.c (copy_data_segment): Also copy __got section.
3610 2011-03-12 Eli Zaretskii <eliz@gnu.org>
3612 * termcap.c [MSDOS]: Include "msdos.h".
3613 (find_capability, tgetnum, tgetflag, tgetstr, tputs, tgetent):
3614 Constify `char *' arguments and their references according to
3615 prototypes in tparam.h.
3617 * deps.mk (termcap.o): Depend on tparam.h and msdos.h.
3619 * msdos.c (XMenuAddPane): 3rd argument is `const char *' now.
3620 Adapt all references accordingly.
3622 * msdos.h (XMenuAddPane): 3rd argument is `const char *' now.
3624 2011-03-11 Tom Tromey <tromey@redhat.com>
3626 * buffer.c (syms_of_buffer): Remove obsolete comment.
3628 2011-03-11 Eli Zaretskii <eliz@gnu.org>
3630 * termhooks.h (encode_terminal_code): Declare prototype.
3632 * msdos.c (encode_terminal_code): Don't declare prototype.
3634 * term.c (encode_terminal_code): Now external again, used by
3635 w32console.c and msdos.c.
3637 * makefile.w32-in ($(BLD)/term.$(O), ($(BLD)/tparam.$(O)):
3638 Depend on $(SRC)/tparam.h, see 2011-03-11T07:24:21Z!eggert@cs.ucla.edu.
3640 2011-03-11 Paul Eggert <eggert@cs.ucla.edu>
3642 Fix some minor problems found by GCC 4.5.2's static checks.
3644 * fringe.c (update_window_fringes): Mark locals as initialized
3646 (destroy_fringe_bitmap, init_fringe_bitmap): Now static.
3648 * alloc.c (mark_fringe_data): Move decl from here ...
3649 * lisp.h (mark_fringe_data) [HAVE_WINDOW_SYSTEM]: ... to here,
3650 to check its interface.
3651 (init_fringe_once): Do not declare unless HAVE_WINDOW_SYSTEM.
3653 * fontset.c (free_realized_fontset): Now static.
3654 (Fset_fontset_font): Rename local to avoid shadowing.
3655 (fontset_font): Mark local as initialized.
3656 (FONTSET_SPEC, FONTSET_REPERTORY, RFONT_DEF_REPERTORY): Remove; unused.
3658 * xrdb.c: Include "xterm.h", to check x_load_resources's interface.
3660 * xselect.c (x_disown_buffer_selections): Remove; not used.
3661 (TRACE3) [!defined TRACE_SELECTION]: Remove; not used.
3662 (x_own_selection, Fx_disown_selection_internal): Rename locals
3664 (x_handle_dnd_message): Remove local to avoid shadowing.
3666 * lisp.h (GCPRO1_VAR, UNGCPRO_VAR): New macros,
3667 so that the caller can use some name other than gcpro1.
3668 (GCPRO1, UNGCPRO): Reimplement in terms of the new macros.
3669 * xfns.c (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
3670 (Fx_backspace_delete_keys_p):
3671 Use them to avoid shadowing, and rename vars to avoid shadowing.
3672 (x_decode_color, x_set_name, x_window): Now static.
3673 (Fx_create_frame): Add braces to silence GCC warning.
3674 (Fx_file_dialog, Fx_select_font): Fix pointer signedness.
3675 (x_real_positions, xg_set_icon_from_xpm_data, x_create_tip_frame):
3676 Remove unused locals.
3677 (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
3678 (Fx_backspace_delete_keys_p): Rename locals to avoid shadowing.
3679 Some of these renamings use the new GCPRO1_VAR and UNGCPRO_VAR
3682 * xterm.h (x_mouse_leave): New decl.
3684 * xterm.c (x_copy_dpy_color, x_focus_on_frame, x_unfocus_frame):
3685 Remove unused functions.
3686 (x_shift_glyphs_for_insert, XTflash, XTring_bell):
3687 (x_calc_absolute_position): Now static.
3688 (XTread_socket): Don't define label "out" unless it's used.
3689 Don't declare local "event" unless it's used.
3690 (x_iconify_frame, x_free_frame_resources): Don't declare locals
3691 unless they are used.
3692 (XEMBED_VERSION, xembed_set_info): Don't define unless needed.
3693 (x_fatal_error_signal): Remove; not used.
3694 (x_draw_image_foreground, redo_mouse_highlight, XTmouse_position):
3695 (x_scroll_bar_report_motion, handle_one_xevent, x_draw_bar_cursor):
3696 (x_error_catcher, x_connection_closed, x_error_handler):
3697 (x_error_quitter, xembed_send_message, x_iconify_frame):
3698 (my_log_handler): Rename locals to avoid shadowing.
3699 (x_delete_glyphs, x_ins_del_lines): Mark with NO_RETURN.
3700 (x_connection_closed): Tell GCC not to suggest NO_RETURN.
3702 * xfaces.c (clear_face_cache, Fx_list_fonts, Fface_font):
3703 Rename or move locals to avoid shadowing.
3704 (tty_defined_color, merge_face_heights): Now static.
3705 (free_realized_faces_for_fontset): Remove; not used.
3706 (Fx_list_fonts): Mark variable that gcc -Wuninitialized
3707 does not deduce is never used uninitialized.
3708 (STRDUPA, LSTRDUPA, FONT_POINT_SIZE_QUANTUM): Remove; not used.
3709 (LFACEP): Define only if XASSERTS, as it's not needed otherwise.
3711 * terminal.c (store_terminal_param): Now static.
3713 * xmenu.c (menu_highlight_callback): Now static.
3714 (set_frame_menubar): Remove unused local.
3715 (xmenu_show): Rename parameter to avoid shadowing.
3716 (xmenu_show, xdialog_show, xmenu_show): Make local pointers "const"
3717 since they might point to immutable storage.
3718 (next_menubar_widget_id): Declare only if USE_X_TOOLKIT,
3719 since it's unused otherwise.
3721 * xdisp.c (produce_glyphless_glyph): Initialize lower_xoff.
3722 Add a FIXME, since the code still doesn't look right. (Bug#8215)
3723 (Fcurrent_bidi_paragraph_direction): Simplify slightly; this
3724 avoids a gcc -Wuninitialized diagnostic.
3725 (display_line, BUILD_COMPOSITE_GLYPH_STRING, draw_glyphs):
3726 (note_mouse_highlight): Mark variables that gcc -Wuninitialized
3727 does not deduce are never used uninitialized.
3729 * lisp.h (IF_LINT): New macro, copied from ../lib-src/emacsclient.c.
3731 * xdisp.c (redisplay_window): Rename local to avoid shadowing.
3732 * window.c (window_loop, size_window):
3733 (run_window_configuration_change_hook, enlarge_window): Likewise.
3735 * window.c (display_buffer): Now static.
3736 (size_window): Mark variables that gcc -Wuninitialized
3737 does not deduce are never used uninitialized.
3738 * window.h (check_all_windows): New decl, to forestall
3739 gcc -Wmissing-prototypes diagnostic.
3740 * dispextern.h (bidi_dump_cached_states): Likewise.
3742 * charset.h (CHECK_CHARSET_GET_CHARSET): Rename locals to avoid
3744 * charset.c (map_charset_for_dump, Fchar_charset): Likewise.
3746 (Fsort_charsets): Redo min/max calculation to shorten the code a bit
3747 and to avoid gcc -Wuninitialized warning.
3748 (load_charset_map): Mark variables that gcc -Wuninitialized
3749 does not deduce are never used uninitialized.
3750 (load_charset): Abort instead of using uninitialized var (Bug#8229).
3752 * coding.c (coding_set_source, coding_set_destination):
3753 Use "else { /* comment */ }" rather than "else /* comment */;"
3754 for clarity, and to avoid gcc -Wempty-body warning.
3755 (Fdefine_coding_system_internal): Don't redeclare 'i' inside
3756 a block, when the outer 'i' will do.
3757 (decode_coding_utf_8, decode_coding_utf_16, detect_coding_emacs_mule):
3758 (emacs_mule_char, decode_coding_emacs_mule, detect_coding_iso_2022):
3759 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5):
3760 (decode_coding_raw_text, decode_coding_charset, get_translation_table):
3761 (Fdecode_sjis_char, Fdefine_coding_system_internal):
3762 Rename locals to avoid shadowing.
3763 * character.h (FETCH_STRING_CHAR_ADVANCE): Likewise.
3764 * coding.c (emacs_mule_char, encode_invocation_designation):
3765 Now static, since they're not used elsewhere.
3766 (decode_coding_iso_2022): Add "default: abort ();" as a safety check.
3767 (decode_coding_object, encode_coding_object, detect_coding_system):
3768 (decode_coding_emacs_mule): Mark variables that gcc
3769 -Wuninitialized does not deduce are never used uninitialized.
3770 (detect_coding_iso_2022): Initialize a local variable that might
3771 be used uninitialized. Leave a FIXME because it's not clear that
3772 this initialization is needed. (Bug#8211)
3773 (ISO_CODE_LF, ISO_CODE_CR, CODING_ISO_FLAG_EUC_TW_SHIFT):
3774 (ONE_MORE_BYTE_NO_CHECK, UTF_BOM, UTF_16_INVALID_P):
3775 (SHIFT_OUT_OK, ENCODE_CONTROL_SEQUENCE_INTRODUCER):
3776 (ENCODE_DIRECTION_R2L, ENCODE_DIRECTION_L2R):
3777 Remove unused macros.
3779 * category.c (hash_get_category_set): Remove unused local var.
3780 (copy_category_table): Now static, since it's not used elsewhere.
3781 * character.c (string_count_byte8): Likewise.
3783 * ccl.c (CCL_WRITE_STRING, CCL_ENCODE_CHAR, Fccl_execute_on_string):
3784 (Fregister_code_conversion_map): Rename locals to avoid shadowing.
3786 * chartab.c (copy_sub_char_table): Now static, since it's not used
3788 (sub_char_table_ref_and_range, char_table_ref_and_range):
3789 Rename locals to avoid shadowing.
3790 (ASET_RANGE, GET_SUB_CHAR_TABLE): Remove unused macros.
3792 * bidi.c (bidi_check_type): Now static, since it's not used elsewhere.
3793 (BIDI_BOB): Remove unused macro.
3795 * cm.c (cmgoto): Mark variables that gcc -Wuninitialized does not
3796 deduce are never used uninitialized.
3797 * term.c (encode_terminal_code): Likewise.
3799 * term.c (encode_terminal_code): Now static. Remove unused local.
3801 * tparam.h: New file.
3802 * term.c, tparam.h: Include it.
3803 * deps.mk (term.o, tparam.o): Depend on tparam.h.
3804 * term.c (tputs, tgetent, tgetflag, tgetnum, tparam, tgetstr):
3805 Move these decls to tparam.h, and make them agree with what
3806 is actually in tparam.c. The previous trick of using incompatible
3807 decls in different modules does not conform to the C standard.
3808 All callers of tparam changed to use tparam's actual API.
3809 * tparam.c (tparam1, tparam, tgoto):
3810 Use const pointers where appropriate.
3812 * cm.c (calccost, cmgoto): Use const pointers where appropriate.
3813 * cm.h (struct cm): Likewise.
3814 * dispextern.h (do_line_insertion_deletion_costs): Likewise.
3815 * scroll.c (ins_del_costs, do_line_insertion_deletion_costs): Likewise.
3816 * term.c (tty_ins_del_lines, calculate_costs, struct fkey_table):
3817 (term_get_fkeys_1, append_glyphless_glyph, produce_glyphless_glyph):
3818 (turn_on_face, init_tty): Likewise.
3819 * termchar.h (struct tty_display_info): Likewise.
3821 * term.c (term_mouse_position): Rename local to avoid shadowing.
3823 * alloc.c (mark_ttys): Move decl from here ...
3824 * lisp.h (mark_ttys): ... to here, so that it's checked against defn.
3826 2011-03-11 Andreas Schwab <schwab@linux-m68k.org>
3828 * .gdbinit (pwinx, xbuffer): Fix access to buffer name.
3830 2011-03-09 Juanma Barranquero <lekktu@gmail.com>
3832 * search.c (compile_pattern_1): Remove argument regp, unused since
3833 revid:rms@gnu.org-19941211082627-3x1g1wyqkjmwloig.
3834 (compile_pattern): Don't pass it.
3836 2011-03-08 Jan Djärv <jan.h.d@swipnet.se>
3838 * xterm.h (DEFAULT_GDK_DISPLAY): New define.
3839 (GDK_WINDOW_XID, gtk_widget_get_preferred_size): New defines
3841 (GTK_WIDGET_TO_X_WIN): Use GDK_WINDOW_XID.
3843 * xmenu.c (menu_position_func): Call gtk_widget_get_preferred_size.
3845 * gtkutil.c: Include gtkx.h if HAVE_GTK3. If ! HAVE_GTK3, define
3846 gdk_window_get_screen, gdk_window_get_geometry,
3847 gdk_x11_window_lookup_for_display and GDK_KEY_g.
3848 (xg_set_screen): Use DEFAULT_GDK_DISPLAY.
3849 (xg_get_pixbuf_from_pixmap): New function.
3850 (xg_get_pixbuf_from_pix_and_mask): Change parameters from GdkPixmap
3851 to Pixmap, take frame as parameter, remove GdkColormap parameter.
3852 Call xg_get_pixbuf_from_pixmap instead of
3853 gdk_pixbuf_get_from_drawable.
3854 (xg_get_image_for_pixmap): Do not make GdkPixmaps, call
3855 xg_get_pixbuf_from_pix_and_mask with Pixmap parameters instead.
3856 (xg_check_special_colors): Use GtkStyleContext and its functions
3858 (xg_prepare_tooltip, xg_hide_tooltip): Call gdk_window_get_screen.
3859 (xg_prepare_tooltip, create_dialog, menubar_map_cb)
3860 (xg_update_frame_menubar, xg_tool_bar_detach_callback)
3861 (xg_tool_bar_attach_callback, xg_update_tool_bar_sizes):
3862 Call gtk_widget_get_preferred_size.
3863 (xg_frame_resized): gdk_window_get_geometry only takes 5
3865 (xg_win_to_widget, xg_event_is_for_menubar):
3866 Call gdk_x11_window_lookup_for_display.
3867 (xg_set_widget_bg): New function.
3868 (delete_cb): New function.
3869 (xg_create_frame_widgets): Connect delete-event to delete_cb.
3870 Call xg_set_widget_bg. Only set backgrund pixmap for ! HAVE_GTK3
3871 (xg_set_background_color): Call xg_set_widget_bg.
3872 (xg_set_frame_icon): Call xg_get_pixbuf_from_pix_and_mask.
3873 (xg_create_scroll_bar): vadj is a GtkAdjustment for HAVE_GTK3.
3874 Only call gtk_range_set_update_policy if ! HAVE_GTK3.
3875 (xg_make_tool_item): Only connect xg_tool_bar_item_expose_callback
3877 (update_frame_tool_bar): Call gtk_widget_hide.
3878 (xg_initialize): Use GDK_KEY_g.
3880 * xsmfns.c (gdk_set_sm_client_id): Define to gdk_set_sm_client_id
3882 (x_session_initialize): Call gdk_x11_set_sm_client_id.
3884 * xterm.c (XFillRectangle): Use cairo routines for HAVE_GTK3.
3885 (x_term_init): Disable Xinput(2) with GDK_CORE_DEVICE_EVENTS.
3886 Load ~/emacs.d/gtkrc only for ! HAVE_GTK3.
3888 2011-03-08 Juanma Barranquero <lekktu@gmail.com>
3890 * w32xfns.c (select_palette): Check success of RealizePalette against
3891 GDI_ERROR, not zero.
3893 See ChangeLog.11 for earlier changes.
3899 Copyright (C) 2011 Free Software Foundation, Inc.
3901 This file is part of GNU Emacs.
3903 GNU Emacs is free software: you can redistribute it and/or modify
3904 it under the terms of the GNU General Public License as published by
3905 the Free Software Foundation, either version 3 of the License, or
3906 (at your option) any later version.
3908 GNU Emacs is distributed in the hope that it will be useful,
3909 but WITHOUT ANY WARRANTY; without even the implied warranty of
3910 MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
3911 GNU General Public License for more details.
3913 You should have received a copy of the GNU General Public License
3914 along with GNU Emacs. If not, see <http://www.gnu.org/licenses/>.