ac83d07cba57d7b41466224fdb274e4f6cd977c7
[bpt/emacs.git] / src / ChangeLog
1 2011-08-29 Paul Eggert <eggert@cs.ucla.edu>
2
3 sprintf-related integer and memory overflow issues.
4
5 * doprnt.c (doprnt): Support printing ptrdiff_t and intmax_t values.
6 (esprintf, esnprintf, exprintf, evxprintf): New functions.
7 * keyboard.c (command_loop_level): Now EMACS_INT, not int.
8 (cmd_error): kbd macro iterations count is now EMACS_INT, not int.
9 (modify_event_symbol): Do not assume that the length of
10 name_alist_or_stem is safe to alloca and fits in int.
11 (Fexecute_extended_command): Likewise for function name and binding.
12 (Frecursion_depth): Wrap around reliably on integer overflow.
13 * keymap.c (push_key_description): First arg is now EMACS_INT, not int,
14 since some callers pass EMACS_INT values.
15 (Fsingle_key_description): Don't crash if symbol name contains more
16 than MAX_ALLOCA bytes.
17 * minibuf.c (minibuf_level): Now EMACS_INT, not int.
18 (get_minibuffer): Arg is now EMACS_INT, not int.
19 * lisp.h (get_minibuffer, push_key_description): Reflect API changes.
20 (esprintf, esnprintf, exprintf, evxprintf): New decls.
21 * window.h (command_loop_level, minibuf_level): Reflect API changes.
22
23 * dbusbind.c (xd_signature, Fdbus_register_signal):
24 Do not overrun buffer; instead, report string overflow.
25
26 * dispnew.c (add_window_display_history): Don't overrun buffer.
27 Truncate instead; this is OK since it's just a log.
28
29 * editfns.c (Fcurrent_time_zone): Don't overrun buffer
30 even if the time zone offset is outlandishly large.
31 Don't mishandle offset == INT_MIN.
32
33 * emacs.c (main) [NS_IMPL_COCOA]: Don't overrun buffer
34 when creating daemon; the previous buffer-overflow check was incorrect.
35
36 * eval.c (verror): Simplify by rewriting in terms of evxprintf,
37 which has the guts of the old verror function.
38
39 * filelock.c (lock_file_1, lock_file): Don't blindly alloca long name;
40 use SAFE_ALLOCA instead. Use esprintf to avoid int-overflow issues.
41
42 * font.c (font_unparse_xlfd): Don't blindly alloca long strings.
43 Don't assume XINT result fits in int, or that XFLOAT_DATA * 10
44 fits in int, when using sprintf. Use single snprintf to count
45 length of string rather than counting it via multiple sprintfs;
46 that's simpler and more reliable.
47 (APPEND_SPRINTF): New macro.
48 (font_unparse_fcname): Use it to avoid sprintf buffer overrun.
49 (generate_otf_features) [0 && HAVE_LIBOTF]: Use esprintf, not
50 sprintf, in case result does not fit in int.
51
52 * fontset.c (num_auto_fontsets): Now printmax_t, not int.
53 (fontset_from_font): Print it.
54
55 * frame.c (tty_frame_count): Now printmax_t, not int.
56 (make_terminal_frame, set_term_frame_name): Print it.
57 (x_report_frame_params): In X, window IDs are unsigned long,
58 not signed long, so print them as unsigned.
59 (validate_x_resource_name): Check for implausibly long names,
60 and don't assume name length fits in 'int'.
61 (x_get_resource_string): Don't blindly alloca invocation name;
62 use SAFE_ALLOCA. Use esprintf, not sprintf, in case result does
63 not fit in int.
64
65 * gtkutil.c (xg_check_special_colors, xg_set_geometry):
66 Make sprintf buffers a bit bigger, to avoid potential buffer overrun.
67
68 * lread.c (dir_warning): Don't blindly alloca buffer; use SAFE_ALLOCA.
69 Use esprintf, not sprintf, in case result does not fit in int.
70
71 2011-08-26 Paul Eggert <eggert@cs.ucla.edu>
72
73 Integer and memory overflow issues (Bug#9196).
74
75 * doc.c (get_doc_string): Rework so that
76 get_doc_string_buffer_size is the actual buffer size, rather than
77 being 1 less than the actual buffer size; this makes xpalloc more
78 convenient.
79
80 * image.c (x_allocate_bitmap_record, cache_image):
81 * xselect.c (Fx_register_dnd_atom):
82 Simplify previous changes by using xpalloc.
83
84 * buffer.c (overlay_str_len): Now ptrdiff_t, not EMACS_INT,
85 since either will do and ptrdiff_t is convenient with xpalloc.
86
87 * charset.c (charset_table_size)
88 (struct charset_sort_data.priority): Now ptrdiff_t.
89 (charset_compare): Don't overflow if priorities differ greatly.
90 (Fsort_charsets): Don't assume list length fits in int.
91 Check for size-calculation overflow when allocating sort data.
92 (syms_of_charset): Allocate an initial charset table that is
93 just under 64 KiB, to avoid problems with glibc malloc and mmap.
94
95 * cmds.c (internal_self_insert): Check for size-calculation overflow.
96
97 * composite.h (struct composition.glyph_len): Now int, not unsigned.
98 The actual value is always <= INT_MAX, and leaving it unsigned made
99 overflow checking harder.
100
101 * dispextern.h (struct glyph_matrix.rows_allocated)
102 (struct face_cache.size): Now ptrdiff_t, for convenience in use
103 with xpalloc. The values are still always <= INT_MAX.
104
105 * indent.c (compute_motion): Adjust to region_cache_forward sig change.
106
107 * lisp.h (xnmalloc, xnrealloc, xpalloc): New decls.
108 (SAFE_NALLOCA): New macro.
109
110 * region-cache.c (struct boundary.pos, find_cache_boundary)
111 (move_cache_gap, insert_cache_boundary, delete_cache_boundaries)
112 (set_cache_region, invalidate_region_cache)
113 (revalidate_region_cache, know_region_cache, region_cache_forward)
114 (region_cache_backward, pp_cache):
115 Use ptrdiff_t, not EMACS_INT, since either will do. This is needed
116 so that ptrdiff_t * can be passed to xpalloc.
117 (struct region_cache): Similarly, for gap_start, gap_len, cache_len,
118 beg_unchanged, end_unchanged, buffer_beg, buffer_end members.
119 (pp_cache): Don't assume cache_len fits in int.
120 * region-cache.h: Adjust extern decls to match.
121
122 * search.c (scan_buffer, Freplace_match): Use ptrdiff_t, not
123 EMACS_INT, since either will do, for xpalloc.
124
125 * alloc.c: Include verify.h, and check that int fits in ptrdiff_t.
126 (xnmalloc, xnrealloc, xpalloc): New functions.
127
128 * bidi.c (bidi_shelve_header_size): New constant.
129 (bidi_cache_ensure_space, bidi_shelve_cache): Use it.
130 (bidi_cache_ensure_space): Avoid integer overflow when allocating.
131
132 * bidi.c (bidi_cache_shrink):
133 * buffer.c (overlays_at, overlays_in, record_overlay_string)
134 (overlay_strings):
135 Don't update size of array until after memory allocation succeeds,
136 because xmalloc/xrealloc may not return.
137 (struct sortstrlist.bytes): Now ptrdiff_t, as EMACS_INT doesn't help
138 now that we have proper integer overflow checking.
139 (record_overlay_string, overlay_strings): Catch overflows when
140 calculating size of overlay_str_buf.
141
142 * callproc.c (Fcall_process): Check for size overflow when
143 calculating size of args2.
144 (child_setup): Avoid overflow by using size_t rather than ptrdiff_t.
145 Normally we prefer signed values, but sticking with ptrdiff_t would
146 require adding more-complicated checks.
147
148 * ccl.c (Fccl_execute_on_string): Check for memory overflow.
149 Use ptrdiff_t rather than EMACS_INT where ptrdiff_t will do.
150 Redo buffer-overflow calculations to avoid integer overflow.
151 Add a FIXME comment where memory seems to be over-allocated.
152
153 * character.c (Fstring): Check for size-calculation overflow.
154
155 * coding.c (produce_chars): Redo buffer-overflow calculations to avoid
156 unnecessary integer overflow. Check for size overflow.
157 (encode_coding_object): Don't update size until xmalloc succeeds.
158
159 * composite.c (get_composition_id): Check for overflow in glyph
160 length calculations.
161
162 Integer and memory overflow fixes for display code.
163 * dispextern.h (struct glyph_pool.nglyphs): Now ptrdiff_t, not int.
164 * dispnew.c (adjust_glyph_matrix, realloc_glyph_pool)
165 (scrolling_window): Check for overflow in size calculations.
166 (line_draw_cost, realloc_glyph_pool, add_row_entry):
167 Don't assume glyph table len fits in int.
168 (struct row_entry.bucket, row_entry_pool_size, row_entry_idx)
169 (row_table_size): Now ptrdiff_t, not int.
170 (scrolling_window): Avoid overflow in size calculations.
171 Don't update size until allocation succeeds.
172 * fns.c (concat): Check for overflow in size calculations.
173 (next_almost_prime): Verify NEXT_ALMOST_PRIME_LIMIT.
174 * lisp.h (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): New macros.
175 (NEXT_ALMOST_PRIME_LIMIT): New constant.
176
177 * doc.c (get_doc_string_buffer_size): Now ptrdiff_t, not int.
178 (get_doc_string): Check for size calculation overflow.
179 Don't update size until allocation succeeds.
180 (get_doc_string, Fsubstitute_command_keys): Use ptrdiff_t, not
181 EMACS_INT, where ptrdiff_t will do.
182 (Fsubstitute_command_keys): Check for string overflow.
183
184 * editfns.c (set_time_zone_rule): Don't assume environment length
185 fits in int.
186 (message_length): Now ptrdiff_t, not int.
187 (Fmessage_box): Don't update size until allocation succeeds.
188 Don't assume message length fits in int.
189 (Fformat): Use ptrdiff_t, not EMACS_INT, where ptrdiff_t will do.
190
191 * emacs.c (main): Do not reallocate argv, since there is a null at
192 the end that can be overwritten, and this way there's no need to
193 worry about size-calculation overflow.
194 (sort_args): Check for size-calculation overflow.
195
196 * eval.c (init_eval_once, grow_specpdl): Don't update size until
197 alloc succeeds.
198 (call_debugger, grow_specpdl): Redo calculations to avoid overflow.
199
200 * frame.c (set_menu_bar_lines, x_set_frame_parameters)
201 (x_set_scroll_bar_width, x_figure_window_size):
202 Check for integer overflow.
203 (x_set_alpha): Do not assume XINT fits in int.
204
205 * frame.h (struct frame): Use int, not EMACS_INT, where int works.
206 This is for the members text_lines, text_cols, total_lines, total_cols,
207 where the system imposes an 'int' limit.
208
209 * fringe.c (Fdefine_fringe_bitmap):
210 Don't update size until alloc works.
211
212 * ftfont.c (ftfont_get_open_type_spec, setup_otf_gstring)
213 (ftfont_shape_by_flt): Check for integer overflow in size calculations.
214
215 * gtkutil.c (get_utf8_string, xg_store_widget_in_map):
216 Check for size-calculation overflow.
217 (get_utf8_string): Use ptrdiff_t, not size_t, where either will
218 do, as we prefer signed integers.
219 (id_to_widget.max_size, id_to_widget.used)
220 (xg_store_widget_in_map, xg_remove_widget_from_map)
221 (xg_get_widget_from_map, xg_get_scroll_id_for_window)
222 (xg_remove_scroll_bar, xg_update_scrollbar_pos):
223 Use and return ptrdiff_t, not int.
224 (xg_gtk_scroll_destroy): Don't assume ptrdiff_t fits in int.
225 * gtkutil.h: Change prototypes to match the above.
226
227 * image.c (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): Remove; these
228 are duplicate now that they've been promoted to lisp.h.
229 (x_allocate_bitmap_record, x_alloc_image_color)
230 (make_image_cache, cache_image, xpm_load):
231 Don't update size until alloc is done.
232 (xpm_load, lookup_rgb_color, lookup_pixel_color, x_to_xcolors)
233 (x_detect_edges):
234 Check for size calculation overflow.
235 (ct_colors_allocated_max): New constant.
236 (x_to_xcolors, x_detect_edges): Reorder multiplicands to avoid
237 overflow.
238
239 * keyboard.c (read_char, menu_bar_items, tool_bar_items)
240 (read_char_x_menu_prompt, read_char_minibuf_menu_width)
241 (read_char_minibuf_menu_prompt, follow_key, read_key_sequence):
242 Use ptrdiff_t, not int, to count maps.
243 (read_char_minibuf_menu_prompt): Check for overflow in size
244 calculations. Don't update size until allocation succeeds. Redo
245 calculations to avoid overflow.
246 * keyboard.h: Change prototypes to match the above.
247
248 * keymap.c (cmm_size, current_minor_maps): Use ptrdiff_t, not int,
249 to count maps.
250 (current_minor_maps): Check for size calculation overflow.
251 * keymap.h: Change prototypes to match the above.
252
253 * lread.c (read1, init_obarray): Don't update size until alloc done.
254
255 * macros.c (Fstart_kbd_macro): Don't update size until alloc done.
256 (store_kbd_macro_char): Reorder multiplicands to avoid overflow.
257
258 * nsterm.h (struct ns_color_table.size, struct ns_color_table.avail):
259 Now ptrdiff_t, not int.
260 * nsterm.m (ns_index_color): Use ptrdiff_t, not int, for table indexes.
261 (ns_draw_fringe_bitmap): Rewrite to avoid overflow.
262
263 * process.c (Fnetwork_interface_list): Check for overflow
264 in size calculation.
265
266 * region-cache.c (move_cache_gap): Check for size calculation overflow.
267
268 * scroll.c (do_line_insertion_deletion_costs): Check for size calc
269 overflow. Don't bother calling xmalloc when xrealloc will do.
270
271 * search.c (Freplace_match): Check for size calculation overflow.
272 (Fset_match_data): Don't assume list lengths fit in 'int'.
273
274 * sysdep.c (system_process_attributes): Use ptrdiff_t, not int,
275 for command line length. Do not attempt to address one before the
276 beginning of an array, as that's not portable.
277
278 * term.c (max_frame_lines): Remove; unused.
279 (encode_terminal_src_size, encode_terminal_dst_size): Now ptrdiff_t,
280 not int.
281 (encode_terminal_code, calculate_costs): Check for size
282 calculation overflow.
283 (encode_terminal_code): Use ptrdiff_t, not int, to record glyph
284 table lengths and related sizes. Don't update size until alloc
285 done. Redo calculations to avoid overflow.
286 (calculate_costs): Don't bother calling xmalloc when xrealloc will do.
287
288 * termcap.c (tgetent): Use ptrdiff_t, not int, to record results of
289 subtracting pointers.
290 (gobble_line): Check for overflow more carefully. Don't update size
291 until alloc done.
292
293 * tparam.c (tparam1): Use ptrdiff_t, not int, for sizes.
294 Don't update size until alloc done.
295 Redo size calculations to avoid overflow.
296 Check for size calculation overflow.
297 (main) [DEBUG]: Fix typo in invoking tparam1.
298
299 * xdisp.c (store_mode_line_noprop_char, x_consider_frame_title):
300 Use ptrdiff_t, not int, for sizes.
301 (store_mode_line_noprop_char): Don't update size until alloc done.
302
303 * xfaces.c (lface_id_to_name_size, Finternal_make_lisp_face):
304 Use ptrdiff_t, not int, for sizes.
305 (Finternal_make_lisp_face, cache_face):
306 Check for size calculation overflow.
307 (cache_face): Treat size calculation overflows as if they were
308 memory exhaustion (the usual treatment), rather than aborting.
309
310 * xfns.c (x_encode_text, x_set_name_internal)
311 (Fx_change_window_property): Use ptrdiff_t, not int, to count
312 sizes, since they can exceed INT_MAX in size. Check for size
313 calculation overflow.
314
315 * xgselect.c (gfds_size): Now ptrdiff_t, for convenience with xpalloc.
316 (xg_select): Check for size calculation overflow.
317 Don't update size until alloc done.
318
319 * xrdb.c (get_environ_db): Don't assume path length fits in int,
320 as sprintf is limited to int lengths.
321
322 * xselect.c (X_LONG_SIZE, X_SHRT_MAX, X_SHRT_MIN, X_LONG_MAX)
323 (X_LONG_MIN): New macros.
324 Use them to make the following changes clearer.
325 (MAX_SELECTION_QUANTUM): Make the other bounds on this value clearer.
326 This change doesn't affect the value now, but it may help remind
327 future maintainers not to raise the value too much later.
328 (SELECTION_QUANTUM): Remove, replacing with ...
329 (selection_quantum): ... new function, which avoids overflow.
330 All uses changed.
331 (struct selection_data.size): Now ptrdiff_t, not int, to avoid
332 assumption that selection length fits in 'int'.
333 (x_reply_selection_request, x_handle_selection_request)
334 (x_get_window_property, receive_incremental_selection)
335 (x_get_window_property_as_lisp_data, selection_data_to_lisp_data)
336 (lisp_data_to_selection_data, clean_local_selection_data):
337 Use ptrdiff_t, not int, to record length of selection.
338 (x_reply_selection_request, x_get_window_property)
339 (receive_incremental_selection, x_property_data_to_lisp):
340 Redo calculations to avoid overflow.
341 (x_reply_selection_request): When sending hint, ceiling it at
342 X_LONG_MAX rather than relying on wraparound overflow to send
343 something.
344 (x_get_window_property, receive_incremental_selection)
345 (lisp_data_to_selection_data, x_property_data_to_lisp):
346 Check for size-calculation overflow.
347 (x_get_window_property, receive_incremental_selection)
348 (lisp_data_to_selection_data, Fx_register_dnd_atom):
349 Don't store size until memory allocation succeeds.
350 (x_get_window_property): Plug memory leak on memory exhaustion.
351 Don't double-block input; malloc is safe here. Don't assume 2**34
352 - 4 fits in unsigned long. Add an xassert to check
353 XGetWindowProperty overflow. Be more careful about overflow
354 calculations, and distinguish size from memory overflow better.
355 (receive_incremental_selection): When tracing, don't assume
356 unsigned int is less than INT_MAX.
357 (x_selection_data_to_lisp_data): Remove unnecessary (and in theory
358 harmful) conversions of unsigned short to int.
359 (lisp_data_to_selection_data): Don't assume that integers
360 in the range -65535 through -1 fit in an X unsigned short.
361 Don't assume that ULONG_MAX == X_ULONG_MAX. Don't store into
362 result parameters unless successful. Rely on cons_to_unsigned
363 to report problems with elements; the old code wasn't right anyway.
364 (x_check_property_data): Check for int overflow; we cannot use
365 a wider type due to X limits.
366 (x_handle_dnd_message): Use unsigned int, to avoid int overflow.
367
368 * xsmfns.c (smc_save_yourself_CB): Check for size calc overflow.
369
370 * xterm.c (x_color_cells, x_send_scrollbar_event, handle_one_xevent)
371 (x_term_init): Check for size calculation overflow.
372 (x_color_cells): Don't store size until memory allocation succeeds.
373 (handle_one_xevent): Use ptrdiff_t, not int, for byte counts.
374 Don't assume alloca size is less than MAX_ALLOCA.
375 (x_term_init): Don't assume length fits in int (sprintf is limited
376 to int size).
377
378 Use ptrdiff_t for composition IDs.
379 * character.c (lisp_string_width):
380 * composite.c (composition_table_size, n_compositions)
381 (get_composition_id, composition_gstring_from_id):
382 * dispextern.h (struct glyph_string.cmp_id, struct composition_it.id):
383 * xdisp.c (BUILD_COMPOSITE_GLYPH_STRING):
384 * window.c (Frecenter):
385 Use ptrdiff_t, not int, for composition IDs.
386 * composite.c (get_composition_id): Check for integer overflow.
387 * composite.h: Adjust prototypes to match the above changes.
388
389 Use ptrdiff_t for hash table indexes.
390 * category.c (hash_get_category_set):
391 * ccl.c (ccl_driver):
392 * charset.h (struct charset.hash_index, CHECK_CHARSET_GET_ID):
393 * coding.c (coding_system_charset_list, detect_coding_system):
394 * coding.h (struct coding_system.id):
395 * composite.c (get_composition_id, gstring_lookup_cache):
396 * fns.c (hash_lookup, hash_put, Fgethash, Fputhash):
397 * image.c (xpm_get_color_table_h):
398 * lisp.h (hash_lookup, hash_put):
399 * minibuf.c (Ftest_completion):
400 Use ptrdiff_t for hash table indexes, not int (which is too
401 narrow, on 64-bit hosts) or EMACS_INT (which is too wide, on
402 32-bit --with-wide-int hosts).
403
404 * charset.c (Fdefine_charset_internal): Check for integer overflow.
405 Add a FIXME comment about memory leaks.
406 (syms_of_charset): Don't assume xmalloc returns.
407
408 Don't assume that stated character widths fit in int.
409 * character.c (Fchar_width, c_string_width, lisp_string_width):
410 * character.h (CHAR_WIDTH):
411 * indent.c (MULTIBYTE_BYTES_WIDTH):
412 Use sanitize_char_width to avoid undefined and/or bad behavior
413 with outlandish widths.
414 * character.h (sanitize_tab_width): Renamed from sanitize_width,
415 now that we have two such functions. All uses changed.
416 (sanitize_char_width): New inline function.
417
418 Don't assume that tab-width fits in int.
419 * character.h (sanitize_width): New inline function.
420 (SANE_TAB_WIDTH): New macro.
421 (ASCII_CHAR_WIDTH): Use it.
422 * indent.c (sane_tab_width): Remove. All uses replaced by
423 SANE_TAB_WIDTH (current_buffer).
424 * xdisp.c (init_iterator): Use SANE_TAB_WIDTH.
425
426 * fileio.c: Integer overflow issues with file modes.
427 (Fset_file_modes, auto_save_1): Don't assume EMACS_INT fits in int.
428
429 * charset.c (read_hex): New arg OVERFLOW. All uses changed.
430 Remove unreachable code.
431 (read_hex, load_charset_map_from_file): Check for integer overflow.
432
433 * xterm.c: don't go over XClientMessageEvent limit
434 (scroll_bar_windows_size): Now ptrdiff_t, as we prefer signed.
435 (x_send_scroll_bar_event): Likewise. Check that the size does not
436 exceed limits imposed by XClientMessageEvent, as well as the usual
437 ptrdiff_t and size_t limits.
438
439 * keyboard.c: Overflow, signedness and related fixes.
440 (make_lispy_movement): Use same integer type in forward decl
441 that is used in the definition.
442 (read_key_sequence, keyremap_step):
443 Change bufsize argument back to int, undoing my 2011-03-30 change.
444 We prefer signed types, and int is wide enough here.
445 (parse_tool_bar_item): Don't assume tool_bar_max_label_size is less
446 than TYPE_MAXIMUM (EMACS_INT) / 2. Don't let the label size grow
447 larger than STRING_BYTES_BOUND. Use ptrdiff_t for Emacs string
448 length, not size_t. Use ptrdiff_t for index, not int.
449 (keyremap_step, read_key_sequence): Redo bufsize check to avoid
450 possibility of integer overflow.
451
452 Overflow, signedness and related fixes for images.
453
454 * dispextern.h (struct it.stack[0].u.image.image_id)
455 (struct_it.image_id, struct image.id, struct image_cache.size)
456 (struct image_cache.used, struct image_cache.ref_count):
457 * gtkutil.c (update_frame_tool_bar):
458 * image.c (x_reference_bitmap, Fimage_size, Fimage_mask_p)
459 (Fimage_metadata, free_image_cache, clear_image_cache, lookup_image)
460 (cache_image, mark_image_cache, x_kill_gs_process, Flookup_image):
461 * nsmenu.m (update_frame_tool_bar):
462 * xdisp.c (calc_pixel_width_or_height):
463 * xfns.c (image_cache_refcount):
464 Image IDs are now ptrdiff_t, not int, to avoid arbitrary limits
465 on typical 64-bit hosts.
466
467 * image.c (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): New macros.
468 (x_bitmap_pixmap, x_create_x_image_and_pixmap):
469 Omit unnecessary casts to int.
470 (parse_image_spec): Check that integers fall into 'int' range
471 when the callers expect that.
472 (image_ascent): Redo ascent calculation to avoid int overflow.
473 (clear_image_cache): Avoid overflow when sqrt (INT_MAX) < nimages.
474 (lookup_image): Remove unnecessary tests.
475 (xbm_image_p): Locals are now of int, not EMACS_INT,
476 since parse_image_check makes sure they fit into int.
477 (png_load, gif_load, svg_load_image):
478 Prefer int to unsigned where either will do.
479 (tiff_handler): New function, combining the cores of the
480 old tiff_error_handler and tiff_warning_handler. This
481 function is rewritten to use vsnprintf and thereby avoid
482 stack buffer overflows. It uses only the features of vsnprintf
483 that are common to both POSIX and native Microsoft.
484 (tiff_error_handler, tiff_warning_handler): Use it.
485 (tiff_load, gif_load, imagemagick_load_image):
486 Don't assume :index value fits in 'int'.
487 (gif_load): Omit unnecessary cast to double, and avoid double-rounding.
488 (imagemagick_load_image): Check that crop parameters fit into
489 the integer types that MagickCropImage accepts. Don't assume
490 Vimagemagick_render_type has a nonnegative value. Don't assume
491 size_t fits in 'long'.
492 (gs_load): Use printmax_t to print the widest integers possible.
493 Check for integer overflow when computing image height and width.
494
495 2011-08-26 Eli Zaretskii <eliz@gnu.org>
496
497 * xdisp.c (redisplay_window): Don't force window start if point
498 will be invisible in the resulting window. (Bug#9324)
499
500 2011-08-25 Eli Zaretskii <eliz@gnu.org>
501
502 * xdisp.c (compute_display_string_pos): Return 2 in DISP_PROP when
503 the display spec is of the form `(space ...)'.
504 (handle_display_spec): Return the value returned by
505 handle_single_display_spec, not just 1 or zero.
506 (handle_single_display_spec): If the display spec is of the form
507 `(space ...)', and specifies display in the text area, return 2
508 rather than 1.
509 (try_cursor_movement): Check for the need to scroll more
510 accurately, and prefer exact match for point under bidi. Don't
511 advance `row' beyond the last row of the window.
512
513 * dispextern.h (struct bidi_it): Rename the disp_prop_p member
514 into disp_prop; all users changed.
515
516 * bidi.c (bidi_fetch_char): If compute_display_string_pos returns
517 DISP_PROP = 2, substitute the u+2029 PARAGRAPH SEPARATOR character
518 for the text covered by the display property.
519
520 2011-08-25 Chong Yidong <cyd@stupidchicken.com>
521
522 * buffer.c (Fbury_buffer_internal): Rename from Funrecord_buffer.
523 Change return value to nil.
524 (Frecord_buffer): Delete unused function.
525
526 2011-08-24 Eli Zaretskii <eliz@gnu.org>
527
528 * xdisp.c (Fcurrent_bidi_paragraph_direction): For unibyte
529 buffers, return left-to-right.
530 (set_cursor_from_row): Consider candidate row a win if its glyph
531 represents a newline and point is on that newline. Fixes cursor
532 positioning on the newline at EOL of R2L text within L2R
533 paragraph, and vice versa.
534 (try_cursor_movement): Check continued rows, in addition to
535 continuation rows. Fixes unwarranted scroll when point enters a
536 continued line of R2L text within an L2R paragraph, or vice versa.
537 (cursor_row_p): Consider the case of point being equal to
538 MATRIX_ROW_END_CHARPOS. Prevents cursor being stuck when moving
539 from the end of a short line to the beginning of a continued line
540 of R2L text within L2R paragraph.
541 (RECORD_MAX_MIN_POS): For max_pos, use IT_CHARPOS even for
542 composed characters.
543
544 * bidi.c (bidi_check_type): Use xassert.
545 (bidi_cache_iterator_state): Update the disp_pos and disp_prop_p
546 members.
547
548 2011-08-23 Eli Zaretskii <eliz@gnu.org>
549
550 * bidi.c (bidi_get_type): Abort if we get zero as the bidi type of
551 a character.
552
553 2011-08-23 Chong Yidong <cyd@stupidchicken.com>
554
555 * nsfont.m (ns_otf_to_script): Fix typo.
556
557 2011-08-22 Kenichi Handa <handa@m17n.org>
558
559 * chartab.c (Fset_char_table_extra_slot): Do not inhibit setting a
560 extra slot even if the purpose is char-code-property-table.
561
562 2011-08-23 Eli Zaretskii <eliz@gnu.org>
563
564 * xdisp.c (redisplay_window): When computing centering_position,
565 account for the height of the header line. (Bug#8874)
566
567 * dispnew.c (buffer_posn_from_coords): Use buf_charpos_to_bytepos
568 instead of CHAR_TO_BYTE. Fixes a crash when a completion
569 candidate is selected by the mouse, and that candidate has a
570 composed character under the mouse.
571
572 * xdisp.c (x_produce_glyphs): Set it->nglyphs to 1. Fixes pixel
573 coordinates reported by pos-visible-in-window-p for a composed
574 character in column zero.
575
576 2011-08-23 Stefan Monnier <monnier@iro.umontreal.ca>
577
578 * cmds.c (Fself_insert_command): Mention post-self-insert-hook.
579
580 2011-08-22 Eli Zaretskii <eliz@gnu.org>
581
582 * xdisp.c (BUFFER_POS_REACHED_P): If this is a composition,
583 consider it a hit if to_charpos is anywhere in the range of the
584 composed buffer positions.
585
586 2011-08-22 Chong Yidong <cyd@stupidchicken.com>
587
588 * image.c (gif_load): Don't assume that each subimage has the same
589 dimensions as the base image. Handle disposal method that is
590 "undefined" by the gif spec (Bug#9335).
591
592 2011-08-20 Chong Yidong <cyd@stupidchicken.com>
593
594 * eval.c (Fsignal): Handle `debug' symbol in error handler (Bug#9329).
595 (Fcondition_case): Document `debug' symbol in error handler.
596
597 2011-08-19 Eli Zaretskii <eliz@gnu.org>
598
599 * xfaces.c (face_at_buffer_position): Avoid repeated evaluation of
600 face ID by FACE_FROM_ID, and avoid a crash when mouse is moved
601 from an Org mode buffer to a Speedbar frame.
602
603 * xdisp.c (RECORD_MAX_MIN_POS): If the display element comes from
604 a composition, take its buffer position from IT->cmp_it.charpos.
605 Fixes cursor positioning at the beginning of a line that begins
606 with a composed character.
607
608 2011-08-18 Eli Zaretskii <eliz@gnu.org>
609
610 * bidi.c (bidi_get_type): If bidi_type_table reports zero as the
611 character bidirectional type, use STRONG_L instead. Fixes crashes
612 in a buffer produced by `describe-categories'.
613
614 * dispextern.h (struct bidi_it): Move disp_pos and disp_prop_p
615 members before the level stack, so they would be saved and
616 restored when copying iterator state. Fixes incorrect reordering
617 around TABs covered by display properties.
618
619 2011-08-18 Andreas Schwab <schwab@linux-m68k.org>
620
621 * process.c (Fnetwork_interface_list): Correctly determine buffer
622 size.
623
624 2011-08-17 Chong Yidong <cyd@stupidchicken.com>
625
626 * eval.c (internal_condition_case, internal_condition_case_1)
627 (internal_condition_case_2, internal_condition_case_n):
628 Remove unnecessary aborts (Bug#9081).
629
630 2011-08-17 Eli Zaretskii <eliz@gnu.org>
631
632 * lread.c (Fload) [DOS_NT]: If `openp' returns -2, but the file
633 has no `load' handler, try opening the file locally. (Bug#9311)
634
635 2011-08-16 Ken Brown <kbrown@cornell.edu>
636
637 * gmalloc.c: Expand comment.
638
639 2011-08-16 Eli Zaretskii <eliz@gnu.org>
640
641 * xdisp.c (set_cursor_from_row): Don't accept a previous candidate
642 if it fails the cursor_row_p test. Fixes cursor positioning at ZV.
643
644 2011-08-16 Ken Brown <kbrown@cornell.edu>
645
646 Fix memory allocation problems in Cygwin build (Bug#9273).
647
648 * unexcw.c ( __malloc_initialized): Declare external variable.
649 (fixup_executable): Force the dumped emacs to reinitialize malloc.
650
651 * gmalloc.c [CYGWIN] (bss_sbrk_heapbase, bss_sbrk_heapinfo):
652 New variables.
653 (malloc_initialize_1) [CYGWIN]: Prepare for reinitializing the
654 dumped emacs.
655 (_free_internal_nolock) [CYGWIN]: Ignore requests to free storage
656 in the static heap.
657 [CYGWIN] (special_realloc): New function.
658 (_realloc_internal_nolock) [CYGWIN]: Use the new function on
659 requests to realloc storage in the static heap.
660
661 2011-08-15 Paul Eggert <eggert@cs.ucla.edu>
662
663 * bidi.c (bidi_initialize): Remove unused local.
664
665 2011-08-15 Eli Zaretskii <eliz@gnu.org>
666
667 * biditype.h: File removed.
668
669 * bidimirror.h: File removed.
670
671 * deps.mk (bidi.o): Remove biditype.h and
672 bidimirror.h.
673
674 * makefile.w32-in ($(BLD)/bidi.$(O)): Remove biditype.h and
675 bidimirror.h.
676
677 * dispextern.h: Fix a typo in the comment to bidi_type_t.
678
679 * chartab.c: Improve commentary for the uniprop_table API.
680
681 * bidi.c (bidi_paragraph_init): Support zero value of
682 bidi_ignore_explicit_marks_for_paragraph_level.
683 (bidi_initialize): Use uniprop_table instead of including
684 biditype.h and bidimirror.h.
685
686 * xdisp.c (move_it_in_display_line_to): Don't reset pixel
687 coordinates of the iterator when restoring from ppos_it.
688 (Bug#9296)
689
690 2011-08-14 Kenichi Handa <handa@m17n.org>
691
692 * process.c (create_process): Call setup_process_coding_systems
693 after the pid of the process is set to -1 (Bug#8162).
694
695 2011-08-14 Eli Zaretskii <eliz@gnu.org>
696
697 * xdisp.c (move_it_in_display_line_to): Don't invoke
698 IT_RESET_X_ASCENT_DESCENT when iterator position was restored from
699 ppos_it. Fixes vertical cursor motion when line beginning is
700 covered by an image. (Bug#9296)
701
702 2011-08-14 Jan Djärv <jan.h.d@swipnet.se>
703
704 * nsterm.h (ns_run_ascript): Declare.
705 (NSAPP_DATA2_RUNASSCRIPT): Define.
706
707 * nsfns.m (as_script, as_result, as_status): New static variables.
708 (ns_run_ascript): New function.
709 (Fns_do_applescript): Set variables as_*. Make an NSApplicationDefined
710 event with data2 set to NSAPP_DATA2_RUNASSCRIPT, post it and then start
711 the event loop. Get status from as_status (Bug#7276).
712
713 * nsterm.m (sendEvent): If event is NSApplicationDefined and
714 data2 is NSAPP_DATA2_RUNASSCRIPT, call ns_run_ascript and then exit
715 the event loop (Bug#7276).
716
717 2011-08-14 Andreas Schwab <schwab@linux-m68k.org>
718
719 * gnutls.c (QCgnutls_bootprop_priority)
720 (QCgnutls_bootprop_trustfiles, QCgnutls_bootprop_keylist)
721 (QCgnutls_bootprop_crlfiles, QCgnutls_bootprop_callbacks)
722 (QCgnutls_bootprop_loglevel, QCgnutls_bootprop_hostname)
723 (QCgnutls_bootprop_min_prime_bits, QCgnutls_bootprop_verify_flags)
724 (QCgnutls_bootprop_verify_hostname_error)
725 (QCgnutls_bootprop_callbacks_verify): Rename from
726 Qgnutls_bootprop_..., all uses changed.
727
728 * xfaces.c (QCignore_defface): Rename from Qignore_defface, all
729 uses changed.
730
731 2011-08-14 Paul Eggert <eggert@cs.ucla.edu>
732
733 * xfaces.c (Qframe_set_background_mode): Now static.
734 * dispextern.h (Qframe_set_background_mode): Remove decl.
735
736 * process.c (Fnetwork_interface_info): Declare local only if needed.
737
738 2011-08-13 Jan Djärv <jan.h.d@swipnet.se>
739
740 * process.c: Include ifaddrs.h and net/if_dl.h if available (Bug#8477).
741 (Fnetwork_interface_list): Allocate in increments of bytes instead
742 of sizeof (struct ifreq). Iterate over ifconf.ifc_req by counting
743 bytes (Bug#8477). Count bytes correctly when ifr_addr is a struct
744 sockaddr.
745 (struct ifflag_def): notrailers is smart on OSX.
746 (Fnetwork_interface_info): Handle case when ifr_flags is negative.
747 Get hardware address with getifaddrs if available.
748
749 2011-08-12 Eli Zaretskii <eliz@gnu.org>
750
751 * xdisp.c (iterate_out_of_display_property): xassert that
752 IT->position is set to within IT->object's boundaries. Break from
753 the loop as soon as EOB is reached; avoids infloops in redisplay
754 when IT->position is set up wrongly due to some bug.
755 Set IT->current to match the bidi iterator unconditionally.
756 (push_display_prop): Allow GET_FROM_STRING as IT->method on
757 entry. Force push_it to save on the stack the current
758 buffer/string position, to be restored by pop_it. Fix flags in
759 the iterator structure wrt the object coming from a display
760 property, as `line-prefix' and `wrap-prefix' are not ``replacing''
761 properties. (Bug#9284)
762
763 2011-08-09 Andreas Schwab <schwab@linux-m68k.org>
764
765 * fontset.c (fontset_get_font_group): Add proper type checks.
766 (Bug#9172)
767
768 2011-08-09 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
769
770 * unexmacosx.c (print_load_command_name): Add cases LC_FUNCTION_STARTS
771 and LC_VERSION_MIN_MACOSX.
772 (copy_linkedit_data) [LC_FUNCTION_STARTS]: New function.
773 (dump_it) [LC_FUNCTION_STARTS]: Use it.
774
775 2011-08-08 Eli Zaretskii <eliz@gnu.org>
776
777 * xdisp.c (forward_to_next_line_start): Allow to use the
778 no-display-properties-and-no-overlays under bidi display.
779 Set disp_pos in the bidi iterator to avoid searches for display
780 properties and overlays.
781
782 2011-08-08 Chong Yidong <cyd@stupidchicken.com>
783
784 * editfns.c (Fset_time_zone_rule): Document relationship with the
785 setenv function.
786
787 * ftfont.c (ftfont_pattern_entity): Copy the extras argument to
788 the font entity extracted from the cache (Bug#8109).
789
790 2011-08-07 Chong Yidong <cyd@stupidchicken.com>
791
792 * composite.c (autocmp_chars): Don't reset point. That is done by
793 restore_point_unwind (Bug#5984).
794
795 2011-08-07 Juri Linkov <juri@jurta.org>
796
797 * editfns.c (Fformat_time_string): Doc fix, add tag `usage:'
798 to show the arg `TIME' instead of `TIMEVAL'.
799
800 2011-08-06 Eli Zaretskii <eliz@gnu.org>
801
802 * xdisp.c (set_cursor_from_row): Fix cursor positioning when a
803 display property strides EOL and includes a newline, as in
804 longlines-mode. (Bug#9254)
805 (move_it_in_display_line_to): Fix vertical-motion in a buffer with
806 word-wrap under bidirectional display. (Bug#9224)
807
808 * bidi.c (bidi_unshelve_cache): Don't reset the cache if JUST_FREE
809 is non-zero, even if the data buffer is NULL. Fixes a crash in
810 vertical-motion with longlines-mode. (Bug#9254)
811
812 2011-08-05 Eli Zaretskii <eliz@gnu.org>
813
814 * bidi.c <bidi_cache_total_alloc>: Now static.
815 (bidi_initialize): Initialize bidi_cache_total_alloc.
816
817 * xdisp.c (display_line): Release buffer allocated for shelved bidi
818 cache. (Bug#9221)
819
820 * bidi.c (bidi_shelve_cache, bidi_unshelve_cache): Track total
821 amount allocated this far in `bidi_cache_total_alloc'.
822 (bidi_unshelve_cache): Accept an additional argument JUST_FREE; if
823 non-zero, only free the data buffer without restoring the cache
824 contents. All callers changed.
825
826 * dispextern.h (bidi_unshelve_cache): Update prototype.
827
828 * xdisp.c (SAVE_IT, pos_visible_p, move_it_in_display_line_to)
829 (move_it_in_display_line, move_it_to)
830 (move_it_vertically_backward, move_it_by_lines): Replace the call
831 to xfree to an equivalent call to bidi_unshelve_cache.
832 (move_it_in_display_line_to): Fix logic of returning
833 MOVE_POS_MATCH_OR_ZV in the bidi case. (Bug#9224)
834
835 2011-08-05 Eli Zaretskii <eliz@gnu.org>
836
837 * xdisp.c (set_cursor_from_row): Prefer the candidate glyph that
838 came from a string character with a `cursor' property. (Bug#9229)
839
840 2011-08-04 Jan Djärv <jan.h.d@swipnet.se>
841
842 * Makefile.in (LIB_PTHREAD): New variable.
843 (LIBES): Add LIB_PTHREAD (Bug#9216).
844
845 * alloc.c, emacs.c, gmalloc.c, gtkutil.c, keyboard.c, syssignal.h:
846 Rename HAVE_GTK_AND_PTHREAD to HAVE_PTHREAD (Bug#9216).
847
848 2011-08-04 Andreas Schwab <schwab@linux-m68k.org>
849
850 * regex.c (re_iswctype): Remove some redundant boolean
851 conversions.
852
853 2011-08-04 Jan Djärv <jan.h.d@swipnet.se>
854
855 * xterm.c (x_find_topmost_parent): New function.
856 (x_set_frame_alpha): Find topmost parent window with
857 x_find_topmost_parent and set the property there also (bug#9181).
858 (handle_one_xevent): Call x_set_frame_alpha on ReparentNotify.
859
860 2011-08-04 Paul Eggert <eggert@cs.ucla.edu>
861
862 * callproc.c (Fcall_process): Avoid vfork clobbering
863 the local vars buffer, coding_systems, current_dir.
864
865 2011-08-03 Stefan Monnier <monnier@iro.umontreal.ca>
866
867 * keymap.c (Fmake_composed_keymap): Move to subr.el.
868
869 2011-08-03 Paul Eggert <eggert@cs.ucla.edu>
870
871 * fontset.c (dump_fontset) [FONTSET_DEBUG]: Declare EXTERNALLY_VISIBLE
872 so that it is not optimized away.
873
874 * xdisp.c (compute_display_string_pos): Remove unused local.
875
876 2011-08-02 Eli Zaretskii <eliz@gnu.org>
877
878 Fix slow cursor motion and scrolling in large buffers with
879 selective display, like Org Mode buffers. (Bug#9218)
880
881 * dispextern.h (struct bidi_it): New member disp_prop_p.
882
883 * xdisp.c: Remove one-slot cache of display string positions.
884 (compute_display_string_pos): Accept an additional argument
885 DISP_PROP_P; callers changed. Scan at most 5K characters forward
886 for a display string or property. If found, set DISP_PROP_P
887 non-zero.
888
889 * bidi.c (bidi_fetch_char): Accept an additional argument
890 DISP_PROP_P, and pass it to compute_display_string_pos.
891 Only handle text covered by a display string if DISP_PROP_P is returned
892 non-zero. All callers of bidi_fetch_char changed.
893
894 2011-08-02 Stefan Monnier <monnier@iro.umontreal.ca>
895
896 * keymap.c (Fdefine_key): Fix Lisp_Object/int mixup; apply some CSE.
897
898 2010-12-03 Don March <don@ohspite.net>
899
900 * keymap.c (Fdefine_key): Fix non-prefix key error message when
901 last character M-[char] is translated to ESC [char] (bug#7541).
902
903 2011-08-02 Kenichi Handa <handa@m17n.org>
904
905 * lisp.h (uniprop_table): Extern it.
906
907 * chartab.c (uniprop_table): Make it non-static.
908
909 2011-08-01 Eli Zaretskii <eliz@gnu.org>
910
911 * xdisp.c (forward_to_next_line_start): Accept additional argument
912 BIDI_IT_PREV, and store into it the state of the bidi iterator had
913 on the newline.
914 (reseat_at_next_visible_line_start): Use the bidi iterator state
915 returned by forward_to_next_line_start to restore the state of
916 it->bidi_it after backing up to previous newline. (Bug#9212)
917
918 2011-07-30 Andreas Schwab <schwab@linux-m68k.org>
919
920 * regex.c (re_comp): Protoize.
921 (re_exec): Fix return type.
922 (regexec): Fix type of `ret'. (Bug#9203)
923
924 2011-07-29 Paul Eggert <eggert@cs.ucla.edu>
925
926 * image.c (check_image_size): Use 1024x1024 if unknown frame (Bug#9189).
927 This is needed if max-image-size is a floating-point number.
928
929 2011-07-28 Andreas Schwab <schwab@linux-m68k.org>
930
931 * print.c (print_object): Print empty symbol as ##.
932
933 * lread.c (read1): Read ## as empty symbol.
934
935 2011-07-28 Alp Aker <alp.tekin.aker@gmail.com>
936
937 * nsfns.m (x_set_foreground_color): Set f->foreground_pixel when
938 setting frame foreground color (Bug#9175).
939 (x_set_background_color): Likewise.
940
941 * nsmenu.m (-setText): Size tooltip dimensions precisely to
942 contents (Bug#9176).
943 (EmacsTooltip -init): Remove bezels and add shadows to
944 tooltip windows.
945
946 * nsterm.m (ns_dumpglyphs_stretch): Avoid overwriting left fringe
947 or scroll bar (Bug#8470).
948
949 * nsfont.m (nsfont_open): Remove assignment to voffset and
950 unnecessary vars hshink, expand, hd, full_height, min_height.
951 (nsfont_draw): Use s->ybase as baseline for glyph drawing (Bug#8913).
952
953 * nsterm.h (nsfont_info): Remove voffset field.
954
955 2011-07-28 Alp Aker <alp.tekin.aker@gmail.com>
956
957 Implement strike-through and overline on NextStep (Bug#8863).
958
959 * nsfont.m (nsfont_open): Use underline position provided by font,
960 instead of hard-coded value of 2.
961 (nsfont_draw): Call ns_draw_text_decoration instead.
962
963 * nsterm.h: Add declaration for ns_draw_text_decoration.
964
965 * nsterm.m (ns_draw_text_decoration): New function for drawing
966 underline, overline, and strike-through.
967 (ns_dumpglyphs_image, ns_dumpglyphs_stretch): Add call to
968 ns_draw_text_decoration. Change treatment of cursor drawing to
969 accomodate underlining, etc.
970
971 2011-07-28 Eli Zaretskii <eliz@gnu.org>
972
973 * buffer.c (init_buffer_once): Set bidi-display-reordering to t by
974 default.
975
976 2011-07-28 Paul Eggert <eggert@cs.ucla.edu>
977
978 * alloc.c (memory_full) [!SYNC_INPUT]: Fix signal-related race.
979 Without this fix, if a signal arrives just after memory fills up,
980 'malloc' might be invoked reentrantly.
981
982 * image.c (x_check_image_size) [!HAVE_X_WINDOWS]: Return 1.
983 In other words, assume that every image size is allowed, on non-X
984 hosts. This assumption is probably wrong, but it lets Emacs compile.
985
986 2011-07-28 Andreas Schwab <schwab@linux-m68k.org>
987
988 * regex.c (re_iswctype): Convert return values to boolean.
989
990 2011-07-28 Eli Zaretskii <eliz@fencepost.gnu.org>
991
992 * xdisp.c (compute_display_string_pos): Don't use cached display
993 string position if the buffer had its restriction changed.
994 (Bug#9184)
995
996 2011-07-28 Paul Eggert <eggert@cs.ucla.edu>
997
998 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
999
1000 2011-07-28 Paul Eggert <eggert@cs.ucla.edu>
1001
1002 Integer signedness and overflow and related fixes. (Bug#9079)
1003
1004 * bidi.c: Integer size and overflow fixes.
1005 (bidi_cache_size, bidi_cache_idx, bidi_cache_last_idx)
1006 (bidi_cache_start, bidi_cache_fetch_state, bidi_cache_search)
1007 (bidi_cache_find_level_change, bidi_cache_ensure_space)
1008 (bidi_cache_iterator_state, bidi_cache_find, bidi_cache_start_stack)
1009 (bidi_find_other_level_edge):
1010 Use ptrdiff_t instead of EMACS_INT where either will do.
1011 This works better on 32-bit hosts configured --with-wide-int.
1012 (bidi_cache_ensure_space): Check for size-calculation overflow.
1013 Use % rather than repeated addition, for better worst-case speed.
1014 Don't set bidi_cache_size until after xrealloc returns, because it
1015 might not return.
1016 (bidi_dump_cached_states): Use ptrdiff_t, not int, to avoid overflow.
1017 (bidi_cache_ensure_space): Also check that the bidi cache size
1018 does not exceed that of the largest Lisp string or buffer. See Eli
1019 Zaretskii in <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9079#29>.
1020
1021 * alloc.c (__malloc_size_t): Remove.
1022 All uses replaced by size_t. See Andreas Schwab's note
1023 <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9079#8>.
1024
1025 * image.c: Improve checking for integer overflow.
1026 (check_image_size): Assume that f is nonnull, since
1027 it is always nonnull in practice. This is one less thing to
1028 worry about when checking for integer overflow later.
1029 (x_check_image_size): New function, which checks for integer
1030 overflow issues inside X.
1031 (x_create_x_image_and_pixmap, xbm_read_bitmap_data): Use it.
1032 This removes the need for a memory_full check.
1033 (xbm_image_p): Rewrite to avoid integer multiplication overflow.
1034 (Create_Pixmap_From_Bitmap_Data, xbm_load): Use x_check_image_size.
1035 (xbm_read_bitmap_data): Change locals back to 'int', since
1036 their values must fit in 'int'.
1037 (xpm_load_image, png_load, tiff_load):
1038 Invoke x_create_x_image_and_pixmap earlier,
1039 to avoid much needless work if the image is too large.
1040 (tiff_load): Treat overly large images as if
1041 x_create_x_image_and_pixmap failed, not as malloc failures.
1042 (gs_load): Use x_check_image_size.
1043
1044 * gtkutil.c: Omit integer casts.
1045 (xg_get_pixbuf_from_pixmap): Remove unnecessary cast.
1046 (xg_set_toolkit_scroll_bar_thumb): Rewrite to avoid need for cast.
1047
1048 * image.c (png_load): Don't assume height * row_bytes fits in 'int'.
1049
1050 * xfaces.c (Fbitmap_spec_p): Fix integer overflow bug.
1051 Without this fix, (bitmap-spec-p '(34359738368 1 "x"))
1052 would wrongly return t on a 64-bit host.
1053
1054 * dispnew.c (init_display): Use *_RANGE_OVERFLOW macros.
1055 The plain *_OVERFLOW macros run afoul of GCC bug 49705
1056 <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=49705>
1057 and therefore cause GCC to emit a bogus diagnostic in some cases.
1058
1059 * image.c: Integer signedness and overflow and related fixes.
1060 This is not an exhaustive set of fixes, but it's time to
1061 record what I've got.
1062 (lookup_pixel_color, check_image_size): Remove redundant decls.
1063 (check_image_size): Don't assume that arbitrary EMACS_INT values
1064 fit in 'int', or that arbitrary 'double' values fit in 'int'.
1065 (x_alloc_image_color, x_create_x_image_and_pixmap, png_load)
1066 (tiff_load, imagemagick_load_image):
1067 Check for overflow in size calculations.
1068 (x_create_x_image_and_pixmap): Remove unnecessary test for
1069 xmalloc returning NULL; that can't happen.
1070 (xbm_read_bitmap_data): Don't assume sizes fit into 'int'.
1071 (xpm_color_bucket): Use better integer hashing function.
1072 (xpm_cache_color): Don't possibly over-allocate memory.
1073 (struct png_memory_storage, tiff_memory_source, tiff_seek_in_memory)
1074 (gif_memory_source):
1075 Use ptrdiff_t, not int or size_t, to record sizes.
1076 (png_load): Don't assume values greater than 2**31 fit in 'int'.
1077 (our_stdio_fill_input_buffer): Prefer ptrdiff_t to size_t when
1078 either works, as we prefer signed integers.
1079 (tiff_read_from_memory, tiff_write_from_memory):
1080 Return tsize_t, not size_t, since that's what the TIFF API wants.
1081 (tiff_read_from_memory): Don't fail simply because the read would
1082 go past EOF; instead, return a short read.
1083 (tiff_load): Omit no-longer-needed casts.
1084 (Fimagemagick_types): Don't assume size fits into 'int'.
1085
1086 Improve hashing quality when configured --with-wide-int.
1087 * fns.c (hash_string): New function, taken from sxhash_string.
1088 Do not discard information about ASCII character case; this
1089 discarding is no longer needed.
1090 (sxhash-string): Use it. Change sig to match it. Caller changed.
1091 * lisp.h: Declare it.
1092 * lread.c (hash_string): Remove, since we now use fns.c's version.
1093 The fns.c version returns a wider integer if --with-wide-int is
1094 specified, so this should help the quality of the hashing a bit.
1095
1096 * emacs.c: Integer overflow minor fix.
1097 (heap_bss_diff): Now uprintmax_t, not unsigned long. All used changed.
1098 Define only if GNU_LINUX.
1099 (main, Fdump_emacs): Set and use heap_bss_diff only if GNU_LINUX.
1100
1101 * dispnew.c: Integer signedness and overflow fixes.
1102 Remove unnecessary forward decls, that were a maintenance hassle.
1103 (history_tick): Now uprintmax_t, so it's more likely to avoid overflow.
1104 All uses changed.
1105 (adjust_glyph_matrix, realloc_glyph_pool, adjust_frame_message_buffer)
1106 (scrolling_window): Use ptrdiff_t, not int, for byte count.
1107 (prepare_desired_row, line_draw_cost):
1108 Use int, not unsigned, where either works.
1109 (save_current_matrix, restore_current_matrix):
1110 Use ptrdiff_t, not size_t, where either works.
1111 (init_display): Check for overflow more accurately, and without
1112 relying on undefined behavior.
1113
1114 * editfns.c (pWIDE, pWIDElen, signed_wide, unsigned_wide):
1115 Remove, replacing with the new symbols in lisp.h. All uses changed.
1116 * fileio.c (make_temp_name):
1117 * filelock.c (lock_file_1, lock_file):
1118 * xdisp.c (message_dolog):
1119 Don't assume PRIdMAX etc. works; this isn't portable to pre-C99 hosts.
1120 Use pMd etc. instead.
1121 * lisp.h (printmax_t, uprintmax_t, pMd, pMu): New types and macros,
1122 replacing the pWIDE etc. symbols removed from editfns.c.
1123
1124 * keyboard.h (num_input_events): Now uintmax_t.
1125 This is (very slightly) less likely to mess up due to wraparound.
1126 All uses changed.
1127
1128 * buffer.c: Integer signedness fixes.
1129 (alloc_buffer_text, enlarge_buffer_text):
1130 Use ptrdiff_t rather than size_t when either will do, as we prefer
1131 signed integers.
1132
1133 * alloc.c: Integer signedness and overflow fixes.
1134 Do not impose an arbitrary 32-bit limit on malloc sizes when debugging.
1135 (__malloc_size_t): Default to size_t, not to int.
1136 (pure_size, pure_bytes_used_before_overflow, stack_copy_size)
1137 (Fgarbage_collect, mark_object_loop_halt, mark_object):
1138 Prefer ptrdiff_t to size_t when either would do, as we prefer
1139 signed integers.
1140 (XMALLOC_OVERRUN_CHECK_OVERHEAD): New macro.
1141 (xmalloc_overrun_check_header, xmalloc_overrun_check_trailer):
1142 Now const. Initialize with values that are in range even if char
1143 is signed.
1144 (XMALLOC_PUT_SIZE, XMALLOC_GET_SIZE): Remove, replacing with ...
1145 (xmalloc_put_size, xmalloc_get_size): New functions. All uses changed.
1146 These functions do the right thing with sizes > 2**32.
1147 (check_depth): Now ptrdiff_t, not int.
1148 (overrun_check_malloc, overrun_check_realloc, overrun_check_free):
1149 Adjust to new way of storing sizes. Check for size overflow bugs
1150 in rest of code.
1151 (STRING_BYTES_MAX): Adjust to new overheads. The old code was
1152 slightly wrong anyway, as it missed one instance of
1153 XMALLOC_OVERRUN_CHECK_OVERHEAD.
1154 (refill_memory_reserve): Omit needless cast to size_t.
1155 (mark_object_loop_halt): Mark as externally visible.
1156
1157 * xselect.c: Integer signedness and overflow fixes.
1158 (Fx_register_dnd_atom, x_handle_dnd_message):
1159 Use ptrdiff_t, not size_t, since we prefer signed.
1160 (Fx_register_dnd_atom): Check for ptrdiff_t (and size_t) overflow.
1161 * xterm.h (struct x_display_info): Use ptrdiff_t, not size_t, for
1162 x_dnd_atoms_size and x_dnd_atoms_length.
1163
1164 * doprnt.c: Prefer signed to unsigned when either works.
1165 * eval.c (verror):
1166 * doprnt.c (doprnt):
1167 * lisp.h (doprnt):
1168 * xdisp.c (vmessage):
1169 Use ptrdiff_t, not size_t, when using or implementing doprnt,
1170 since the sizes cannot exceed ptrdiff_t bounds anyway, and we
1171 prefer signed arithmetic to avoid comparison confusion.
1172 * doprnt.c (doprnt): Avoid a "+ 1" that can't overflow,
1173 but is a bit tricky.
1174
1175 Assume freestanding C89 headers, string.h, stdlib.h.
1176 * data.c, doprnt.c, floatfns.c, print.c:
1177 Include float.h unconditionally.
1178 * gmalloc.c: Assume C89-at-least behavior for preprocessor,
1179 limits.h, stddef.h, string.h. Use memset instead of 'flood'.
1180 * regex.c: Likewise for stddef.h, string.h.
1181 (ISASCII): Remove; can assume it returns 1 now. All uses removed.
1182 * s/aix4-2.h (HAVE_STRING_H): Remove obsolete undef.
1183 * s/ms-w32.h (HAVE_LIMITS_H, HAVE_STRING_H, HAVE_STDLIB_H)
1184 (STDC_HEADERS): Remove obsolete defines.
1185 * sysdep.c: Include limits.h unconditionally.
1186
1187 Assume support for memcmp, memcpy, memmove, memset.
1188 * lisp.h, sysdep.c (memcmp, memcpy, memmove, memset):
1189 * regex.c (memcmp, memcpy):
1190 Remove; we assume C89 now.
1191
1192 * gmalloc.c (memcpy, memset, memmove): Remove; we assume C89 now.
1193 (__malloc_safe_bcopy): Remove; no longer needed.
1194
1195 * lisp.h (struct vectorlike_header, struct Lisp_Subr): Signed sizes.
1196 Use EMACS_INT, not EMACS_UINT, for sizes. The code works equally
1197 well either way, and we prefer signed to unsigned.
1198
1199 2011-07-27 Lars Magne Ingebrigtsen <larsi@gnus.org>
1200
1201 * gnutls.c (emacs_gnutls_read): Don't message anything if the peer
1202 closes the connection while we're reading (bug#9182).
1203
1204 2011-07-25 Jan Djärv <jan.h.d@swipnet.se>
1205
1206 * nsmenu.m (ns_popup_dialog): Add an "ok" button if no buttons
1207 are specified (Bug#9168).
1208
1209 2011-07-25 Paul Eggert <eggert@cs.ucla.edu>
1210
1211 * bidi.c (bidi_dump_cached_states): Fix printf format mismatch.
1212 Found by GCC static checking and --with-wide-int on a 32-bit host.
1213
1214 2011-07-25 Eli Zaretskii <eliz@gnu.org>
1215
1216 * xdisp.c (compute_display_string_pos): Fix logic of caching
1217 previous display string position. Initialize cached_prev_pos to
1218 -1. Fixes slow-down at the beginning of a buffer.
1219
1220 2011-07-24 Eli Zaretskii <eliz@gnu.org>
1221
1222 * xfaces.c (check_lface_attrs) [HAVE_WINDOW_SYSTEM]: Allow `nil'
1223 for attrs[LFACE_FONTSET_INDEX].
1224
1225 2011-07-23 Paul Eggert <eggert@cs.ucla.edu>
1226
1227 * xml.c (parse_region): Remove unused local
1228 that was recently introduced.
1229
1230 2011-07-23 Eli Zaretskii <eliz@gnu.org>
1231
1232 * xfns.c (unwind_create_frame) [GLYPH_DEBUG]: Adapt to changes in
1233 2008-02-22T17:42:09Z!monnier@iro.umontreal.ca.
1234
1235 * xdisp.c (move_it_in_display_line_to): Record the best matching
1236 position for TO_CHARPOS while scanning the line, and restore it on
1237 exit if none of the characters scanned was an exact match.
1238 Fixes vertical-motion and pos-visible-in-window-p under bidi redisplay
1239 when exact match is impossible due to invisible text, and the
1240 lines are truncated.
1241
1242 2011-07-23 Jan Djärv <jan.h.d@swipnet.se>
1243
1244 * nsterm.m (initFrameFromEmacs): Set NSTitledWindowMask in styleMask
1245 for OSX >= 10.7.
1246
1247 2011-07-22 Eli Zaretskii <eliz@gnu.org>
1248
1249 Fix a significant slow-down of cursor motion with C-n, C-p,
1250 C-f/C-b, and C-v/M-v that couldn't keep up with keyboard
1251 auto-repeat under bidi redisplay in fontified buffers.
1252 * xdisp.c (compute_stop_pos_backwards): New function.
1253 (next_element_from_buffer): Call compute_stop_pos_backwards to
1254 find a suitable prev_stop when we find ourselves before
1255 base_level_stop.
1256 (reseat): Don't look for prev_stop, as that could mean a very long
1257 run.
1258 <cached_disp_pos, cached_disp_buffer, cached_disp_modiff>
1259 <cached_disp_overlay_modiff>: Cache for last found display string
1260 position.
1261 (compute_display_string_pos): Return the cached position if asked
1262 about the same buffer in the same area of character positions, and
1263 the buffer wasn't changed since the time the display string
1264 position was cached.
1265
1266 2011-07-22 Eli Zaretskii <eliz@gnu.org>
1267
1268 * xdisp.c (rows_from_pos_range): Don't ignore glyphs whose object
1269 is an integer, which is important for empty lines. (Bug#9149)
1270
1271 2011-07-22 Chong Yidong <cyd@stupidchicken.com>
1272
1273 * frame.c (Fmodify_frame_parameters): In tty case, update the
1274 default face if necessary (Bug#4238).
1275
1276 2011-07-21 Chong Yidong <cyd@stupidchicken.com>
1277
1278 * editfns.c (Fstring_to_char): No need to explain what a character
1279 is in the docstring (Bug#6576).
1280
1281 2011-07-20 Lars Magne Ingebrigtsen <larsi@gnus.org>
1282
1283 * xml.c (parse_region): Make sure we always return a tree.
1284
1285 2011-07-20 HAMANO Kiyoto <khiker.mail@gmail.com>
1286
1287 * xml.c (parse_region): If a document contains only comments,
1288 return that, too.
1289
1290 2011-07-20 Lars Magne Ingebrigtsen <larsi@gnus.org>
1291
1292 * xml.c (make_dom): Return comments, too.
1293
1294 2011-07-19 Paul Eggert <eggert@cs.ucla.edu>
1295
1296 Port to OpenBSD.
1297 See http://lists.gnu.org/archive/html/emacs-devel/2011-07/msg00688.html
1298 and the surrounding thread.
1299 * minibuf.c (read_minibuf_noninteractive): Rewrite to use getchar
1300 rather than fgets, and retry after EINTR. Otherwise, 'emacs
1301 --batch -f byte-compile-file' fails on OpenBSD if an inactivity
1302 timer goes off.
1303 * s/openbsd.h (BROKEN_SIGIO): Define.
1304 * unexelf.c (unexec) [__OpenBSD__]:
1305 Don't update the .mdebug section of the Alpha COFF symbol table.
1306
1307 2011-07-19 Lars Magne Ingebrigtsen <larsi@gnus.org>
1308
1309 * lread.c (syms_of_lread): Clarify when `lexical-binding' is used
1310 (bug#8460).
1311
1312 2011-07-18 Paul Eggert <eggert@cs.ucla.edu>
1313
1314 * fileio.c (Fcopy_file) [!MSDOS]: Tighten created file's mask.
1315 This fixes some race conditions on the permissions of any newly
1316 created file.
1317
1318 * alloc.c (valid_pointer_p): Use pipe, not open.
1319 This fixes some permissions issues when debugging.
1320
1321 * fileio.c (Fcopy_file): Adjust mode if fchown fails. (Bug#9002)
1322 If fchown fails to set both uid and gid, try to set just gid,
1323 as that is sometimes allowed. Adjust the file's mode to eliminate
1324 setuid or setgid bits that are inappropriate if fchown fails.
1325
1326 2011-07-18 Stefan Monnier <monnier@iro.umontreal.ca>
1327
1328 * xdisp.c (next_element_from_string, next_element_from_buffer): Use EQ
1329 to compare Lisp_Objects.
1330 * gnutls.c (syms_of_gnutls): Rename Vgnutls_log_level to
1331 global_gnutls_log_level, don't mistake it for a Lisp_Object.
1332 (init_gnutls_functions, emacs_gnutls_handle_error): Fix up uses.
1333
1334 2011-07-17 Andreas Schwab <schwab@linux-m68k.org>
1335
1336 * lread.c (read_integer): Unread even EOF character.
1337 (read1): Likewise. Properly record start position of symbol.
1338
1339 * lread.c (read1): Read `#:' as empty uninterned symbol if no
1340 symbol character follows.
1341
1342 2011-07-17 Paul Eggert <eggert@cs.ucla.edu>
1343
1344 * fileio.c (Fcopy_file): Pacify gcc re fchown. (Bug#9002)
1345 This works around a problem with the previous change to Fcopy_file.
1346 Recent glibc declares fchown with __attribute__((warn_unused_result)),
1347 and without this change, GCC might complain about discarding
1348 fchown's return value.
1349
1350 2011-07-16 Juanma Barranquero <lekktu@gmail.com>
1351
1352 * makefile.w32-in (GLOBAL_SOURCES): Add gnutls.c (followup to bug#9059).
1353
1354 2011-07-16 Paul Eggert <eggert@cs.ucla.edu>
1355
1356 * fileio.c (Fcopy_file): Don't diagnose fchown failures. (Bug#9002)
1357
1358 2011-07-16 Lars Magne Ingebrigtsen <larsi@gnus.org>
1359
1360 * gnutls.c (syms_of_gnutls): Define `gnutls-log-level' here, since
1361 it's used from the C level.
1362
1363 * process.c: Use the same condition for POLL_FOR_INPUT in both
1364 keyboard.c and process.c (bug#1858).
1365
1366 2011-07-09 Lawrence Mitchell <wence@gmx.li>
1367
1368 * gnutls.c (Qgnutls_bootprop_min_prime_bits): New variable.
1369 (Fgnutls_boot): Use it.
1370
1371 2011-07-15 Andreas Schwab <schwab@linux-m68k.org>
1372
1373 * doc.c (Fsubstitute_command_keys): Revert last change.
1374
1375 2011-07-15 Lars Magne Ingebrigtsen <larsi@gnus.org>
1376
1377 * doc.c (Fsubstitute_command_keys): Clarify that \= really only
1378 quotes the next character, and doesn't affect other longer
1379 sequences (bug#8935).
1380
1381 * lread.c (syms_of_lread): Clarify that is isn't only
1382 `eval-buffer' and `eval-defun' that's affected by
1383 `lexical-binding' (bug#8460).
1384
1385 2011-07-15 Eli Zaretskii <eliz@gnu.org>
1386
1387 * xdisp.c (move_it_in_display_line_to): Fix vertical motion with
1388 bidi redisplay when a line includes both an image and is
1389 truncated.
1390
1391 2011-07-14 Paul Eggert <eggert@cs.ucla.edu>
1392
1393 Fix minor problems found by static checking.
1394 * bidi.c (bidi_cache_size): Now EMACS_INT, not size_t.
1395 (elsz): Now a signed constant, not a size_t var. We prefer signed
1396 types to unsigned, to avoid integer comparison confusion. Without
1397 this change, GCC 4.6.1 with -Wunsafe-loop-optimizations complains
1398 "cannot optimize loop, the loop counter may overflow", a symptom
1399 of the confusion.
1400 * indent.c (Fvertical_motion): Mark locals as initialized.
1401 * xdisp.c (reseat_to_string): Fix pointer signedness issue.
1402
1403 2011-07-14 Lars Magne Ingebrigtsen <larsi@gnus.org>
1404
1405 * search.c (Fre_search_backward): Mention `case-fold-search' in
1406 all the re_search_* functions (bug#8138).
1407
1408 * keyboard.c (Fopen_dribble_file): Document when the file is
1409 closed (bug#8056).
1410
1411 2011-07-14 Eli Zaretskii <eliz@gnu.org>
1412
1413 * bidi.c (bidi_dump_cached_states): Fix format of displaying
1414 bidi_cache_idx.
1415
1416 Support bidi reordering of display and overlay strings.
1417 * xdisp.c (compute_display_string_pos)
1418 (compute_display_string_end): Accept additional argument STRING.
1419 (init_iterator, reseat_1): Initialize bidi_it->string.s to NULL.
1420 (reseat_to_string): Initialize bidi_it->string.s and
1421 bidi_it->string.schars.
1422 (Fcurrent_bidi_paragraph_direction): Initialize itb.string.s to
1423 NULL (avoids a crash in bidi_paragraph_init).
1424 Initialize itb.string.lstring.
1425 (init_iterator): Call bidi_init_it only of a valid
1426 buffer position was specified. Initialize paragraph_embedding to
1427 L2R.
1428 (reseat_to_string): Initialize the bidi iterator.
1429 (display_string): If we need to ignore text properties of
1430 LISP_STRING, set IT->stop_charpos to IT->end_charpos. (The
1431 original value of -1 will not work with bidi.)
1432 (compute_display_string_pos): First arg is now struct
1433 `text_pos *'; all callers changed. Support display properties on
1434 Lisp strings.
1435 (compute_display_string_end): Support display properties on Lisp
1436 strings.
1437 (init_iterator, reseat_1, reseat_to_string): Initialize the
1438 string.bufpos member to 0 (zero, for compatibility with IT_CHARPOS
1439 when iterating on a string not from display properties).
1440 (compute_display_string_pos, compute_display_string_end):
1441 Fix calculation of the object to scan. Fixes an error when using
1442 arrow keys.
1443 (next_element_from_buffer): Don't abort when IT_CHARPOS is before
1444 base_level_stop; instead, set base_level_stop to BEGV.
1445 Fixes crashes in vertical-motion.
1446 (next_element_from_buffer): Improve commentary for when
1447 the iterator is before prev_stop.
1448 (init_iterator): Initialize bidi_p from the default value of
1449 bidi-display-reordering, not from buffer-local value. Use the
1450 buffer-local value only if initializing for buffer iteration.
1451 (handle_invisible_prop): Support invisible properties on strings
1452 that are being bidi-reordered.
1453 (set_iterator_to_next): Support bidi reordering of C strings and
1454 Lisp strings.
1455 (next_element_from_string): Support bidi reordering of Lisp
1456 strings.
1457 (handle_stop_backwards): Support Lisp strings as well.
1458 (display_string): Support display of R2L glyph rows.
1459 Use IT_STRING_CHARPOS when displaying from a Lisp string.
1460 (init_iterator): Don't initialize it->bidi_p for strings
1461 here.
1462 (reseat_to_string): Initialize it->bidi_p for strings here.
1463 (next_element_from_string, next_element_from_c_string)
1464 (next_element_from_buffer): Add xassert's for correspondence
1465 between IT's object being iterated and it->bidi_it.string
1466 structure.
1467 (face_before_or_after_it_pos): Support bidi iteration.
1468 (next_element_from_c_string): Handle the case of the first string
1469 character that is not the first one in the visual order.
1470 (get_visually_first_element): New function, refactored from common
1471 parts of next_element_from_buffer, next_element_from_string, and
1472 next_element_from_c_string.
1473 (tool_bar_lines_needed, redisplay_tool_bar)
1474 (display_menu_bar): Force left-to-right direction. Add a FIXME
1475 comment for making that be controlled by a user option.
1476 (push_it, pop_it): Save and restore the state of the
1477 bidi iterator. Save and restore the bidi_p flag.
1478 (pop_it): Iterate out of display property for string iteration as
1479 well.
1480 (iterate_out_of_display_property): Support iteration over strings.
1481 (handle_single_display_spec): Set up it->bidi_it for iteration
1482 over a display string, and call bidi_init_it.
1483 (handle_single_display_spec, next_overlay_string)
1484 (get_overlay_strings_1, push_display_prop): Set up the bidi
1485 iterator for displaying display or overlay strings.
1486 (forward_to_next_line_start): Don't use the shortcut if
1487 bidi-iterating.
1488 (back_to_previous_visible_line_start): If handle_display_prop
1489 pushed the iterator stack, restore the internal state of the bidi
1490 iterator by calling bidi_pop_it same number of times.
1491 (reseat_at_next_visible_line_start): If ON_NEWLINE_P is non-zero,
1492 and we are bidi-iterating, don't decrement the iterator position;
1493 instead, set the first_elt flag in the bidi iterator, to produce
1494 the same effect.
1495 (reseat_1): Remove redundant setting of string_from_display_prop_p.
1496 (push_display_prop): xassert that we are iterating a buffer.
1497 (push_it, pop_it): Save and restore paragraph_embedding member.
1498 (handle_single_display_spec, next_overlay_string)
1499 (get_overlay_strings_1, reseat_1, reseat_to_string)
1500 (push_display_prop): Set up the `unibyte' member of bidi_it.string
1501 correctly. Don't assume unibyte strings are not bidi-reordered.
1502 (compute_display_string_pos)
1503 (compute_display_string_end): Fix handling the case of C string.
1504 (push_it, pop_it): Save and restore from_disp_prop_p.
1505 (handle_single_display_spec, push_display_prop): Set the
1506 from_disp_prop_p flag.
1507 (get_overlay_strings_1): Reset the from_disp_prop_p flag.
1508 (pop_it): Call iterate_out_of_display_property only if we are
1509 popping after iteration over a string that came from a display
1510 property. Fix a typo in popping stretch info. Add an assertion
1511 for verifying that the iterator position is in sync with the bidi
1512 iterator.
1513 (handle_single_display_spec, get_overlay_strings_1)
1514 (push_display_prop): Fix initialization of paragraph direction for
1515 string when that of the parent object is not yet determined.
1516 (reseat_1): Call bidi_init_it to resync the bidi
1517 iterator with IT's position. (Bug#7616)
1518 (find_row_edges): If ROW->start.pos gives position
1519 smaller than min_pos, use it as ROW->minpos. (Bug#7616)
1520 (handle_stop, back_to_previous_visible_line_start, reseat_1):
1521 Reset the from_disp_prop_p flag.
1522 (SAVE_IT, RESTORE_IT): New macros.
1523 (pos_visible_p, face_before_or_after_it_pos)
1524 (back_to_previous_visible_line_start)
1525 (move_it_in_display_line_to, move_it_in_display_line)
1526 (move_it_to, move_it_vertically_backward, move_it_by_lines)
1527 (try_scrolling, redisplay_window, display_line): Use them when
1528 saving a temporary copy of the iterator and restoring it back.
1529 (back_to_previous_visible_line_start, reseat_1)
1530 (init_iterator): Empty the bidi cache "stack".
1531 (move_it_in_display_line_to): If iterator ended up at
1532 EOL, but we never saw any buffer positions smaller than
1533 to_charpos, return MOVE_POS_MATCH_OR_ZV. Fixes vertical cursor
1534 motion in bidi-reordered lines.
1535 (move_it_in_display_line_to): Record prev_method and prev_pos
1536 immediately before the call to set_iterator_to_next. Fixes cursor
1537 motion in bidi-reordered lines with stretch glyphs and strings
1538 displayed in margins. (Bug#8133) (Bug#8867)
1539 Return MOVE_POS_MATCH_OR_ZV only if iterator position is past
1540 TO_CHARPOS.
1541 (pos_visible_p): Support positions in bidi-reordered lines.
1542 Save and restore bidi cache.
1543
1544 * bidi.c (bidi_level_of_next_char): clen should be EMACS_NT, not int.
1545 (bidi_paragraph_info): Delete unused struct.
1546 (bidi_cache_idx, bidi_cache_last_idx): Declare EMACS_INT.
1547 (bidi_cache_start): New variable.
1548 (bidi_cache_reset): Reset bidi_cache_idx to bidi_cache_start, not
1549 to zero.
1550 (bidi_cache_fetch_state, bidi_cache_search)
1551 (bidi_cache_find_level_change, bidi_cache_iterator_state)
1552 (bidi_cache_find, bidi_peek_at_next_level)
1553 (bidi_level_of_next_char, bidi_find_other_level_edge)
1554 (bidi_move_to_visually_next): Compare cache index with
1555 bidi_cache_start rather than with zero.
1556 (bidi_fetch_char): Accept new argument STRING; all callers
1557 changed. Support iteration over a string. Support strings with
1558 display properties. Support unibyte strings. Fix the type of
1559 `len' according to what STRING_CHAR_AND_LENGTH expects.
1560 (bidi_paragraph_init, bidi_resolve_explicit_1)
1561 (bidi_resolve_explicit, bidi_resolve_weak)
1562 (bidi_level_of_next_char, bidi_move_to_visually_next):
1563 Support iteration over a string.
1564 (bidi_set_sor_type, bidi_resolve_explicit_1)
1565 (bidi_resolve_explicit, bidi_type_of_next_char): ignore_bn_limit
1566 can now be zero (for strings); special values 0 and -1 were
1567 changed to -1 and -2, respectively.
1568 (bidi_char_at_pos): New function.
1569 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak):
1570 Call it instead of FETCH_MULTIBYTE_CHAR.
1571 (bidi_move_to_visually_next): Abort if charpos or bytepos were not
1572 initialized to valid values.
1573 (bidi_init_it): Don't initialize charpos and bytepos with invalid
1574 values.
1575 (bidi_level_of_next_char): Allow the sentinel "position" to pass
1576 the test for valid cached positions. Fix the logic for looking up
1577 the sentinel state in the cache. GCPRO the Lisp string we are
1578 iterating.
1579 (bidi_push_it, bidi_pop_it): New functions.
1580 (bidi_initialize): Initialize the bidi cache start stack pointer.
1581 (bidi_cache_ensure_space): New function, refactored from part of
1582 bidi_cache_iterator_state. Don't assume the required size is just
1583 one BIDI_CACHE_CHUNK away.
1584 (bidi_cache_start_stack, bidi_push_it): Use IT_STACK_SIZE.
1585 (bidi_count_bytes, bidi_char_at_pos): New functions.
1586 (bidi_cache_search): Don't assume bidi_cache_last_idx is
1587 always valid if bidi_cache_idx is valid.
1588 (bidi_cache_find_level_change): xassert that bidi_cache_last_idx
1589 is valid if it's going to be used.
1590 (bidi_shelve_cache, bidi_unshelve_cache): New functions.
1591 (bidi_cache_fetch_state, bidi_cache_search)
1592 (bidi_cache_find_level_change, bidi_cache_ensure_space)
1593 (bidi_cache_iterator_state, bidi_cache_find)
1594 (bidi_find_other_level_edge, bidi_cache_start_stack):
1595 All variables related to cache indices are now EMACS_INT.
1596
1597 * dispextern.h (struct bidi_string_data): New structure.
1598 (struct bidi_it): New member `string'. Make flag members be 1-bit
1599 fields, and put them last in the struct.
1600 (compute_display_string_pos, compute_display_string_end):
1601 Update prototypes.
1602 (bidi_push_it, bidi_pop_it): Add prototypes.
1603 (struct iterator_stack_entry): New members bidi_p,
1604 paragraph_embedding, and from_disp_prop_p.
1605 (struct it): Member bidi_p is now a bit field 1 bit wide.
1606 (bidi_shelve_cache, bidi_unshelve_cache):
1607 Declare prototypes.
1608
1609 * .gdbinit (xvectype, xvector, xcompiled, xchartable, xboolvector)
1610 (xpr, xfont, xbacktrace): Use "header.size" when accessing vectors
1611 and vector-like objects.
1612
1613 * dispnew.c (buffer_posn_from_coords): Save and restore the bidi
1614 cache around display iteration.
1615
1616 * window.c (Fwindow_end, window_scroll_pixel_based)
1617 (displayed_window_lines, Frecenter): Save and restore the bidi
1618 cache around display iteration.
1619
1620 2011-07-14 Lars Magne Ingebrigtsen <larsi@gnus.org>
1621
1622 * editfns.c (Fdelete_region): Clarify the use of the named
1623 parameters (bug#6788).
1624
1625 2011-07-14 Martin Rudalics <rudalics@gmx.at>
1626
1627 * indent.c (Fvertical_motion): Set and restore w->pointm when
1628 saving and restoring the window's buffer (Bug#9006).
1629
1630 2011-07-13 Lars Magne Ingebrigtsen <larsi@gnus.org>
1631
1632 * editfns.c (Fstring_to_char): Clarify just what is returned
1633 (bug#6576). Text by Eli Zaretskii.
1634
1635 2011-07-13 Juanma Barranquero <lekktu@gmail.com>
1636
1637 * gnutls.c (init_gnutls_functions): Honor gnutls_log_level (bug#9059).
1638
1639 2011-07-13 Eli Zaretskii <eliz@gnu.org>
1640
1641 * buffer.c (mmap_find): Fix a typo.
1642
1643 2011-07-13 Johan Bockgård <bojohan@gnu.org>
1644
1645 Fix execution of x selection hooks.
1646 * xselect.c (Qx_lost_selection_functions)
1647 (Qx_sent_selection_functions): New vars.
1648 (syms_of_xselect): DEFSYM them.
1649 (x_handle_selection_request): Pass Qx_sent_selection_functions
1650 rather than Vx_sent_selection_functions to Frun_hook_with_args.
1651 (x_handle_selection_clear,x_clear_frame_selections):
1652 Pass Qx_lost_selection_functions rather than
1653 Vx_lost_selection_functions to Frun_hook_with_args.
1654
1655 2011-07-13 Paul Eggert <eggert@cs.ucla.edu>
1656
1657 * buffer.c (Fget_buffer_create): Initialize inhibit_shrinking.
1658 The old code sometimes used this field without initializing it.
1659
1660 * alloc.c (gc_sweep): Don't read past end of array.
1661 In theory, the old code could also have corrupted Emacs internals,
1662 though it'd be very unlikely.
1663
1664 2011-07-12 Andreas Schwab <schwab@linux-m68k.org>
1665
1666 * character.c (Fcharacterp): Don't advertise optional ignored
1667 argument. (Bug#4026)
1668
1669 2011-07-12 Lars Magne Ingebrigtsen <larsi@gnus.org>
1670
1671 * keymap.c (syms_of_keymap): Clarify that "modifier" is "modifier
1672 key" (bug#4257).
1673
1674 * window.c (Fset_window_start): Doc fix (bug#4199).
1675 (Fset_window_hscroll): Ditto.
1676
1677 2011-07-12 Paul Eggert <eggert@cs.ucla.edu>
1678
1679 Fix minor new problems caught by GCC 4.6.1.
1680 * term.c (init_tty): Remove unused local.
1681 * xsettings.c (store_monospaced_changed): Define this function only
1682 if (defined HAVE_GSETTINGS || defined HAVE_GCONF), as it's
1683 not used otherwise.
1684
1685 2011-07-12 Chong Yidong <cyd@stupidchicken.com>
1686
1687 * xdisp.c (Vresize_mini_windows): Minor doc fix (Bug#3300).
1688
1689 2011-07-11 Lars Magne Ingebrigtsen <larsi@gnus.org>
1690
1691 * xdisp.c (syms_of_xdisp): Make it explicit that the mini-windows
1692 are the mini-buffer and the echo area (bug#3320).
1693
1694 * term.c (init_tty): Remove support for supdup, c10 and perq
1695 terminals, which are no longer supported (bug#1482).
1696
1697 2011-07-10 Johan Bockgård <bojohan@gnu.org>
1698
1699 * xdisp.c (Ftool_bar_lines_needed): Fix WINDOWP check.
1700
1701 2011-07-10 Jan Djärv <jan.h.d@swipnet.se>
1702
1703 * xmenu.c (menu_highlight_callback): Only pass frame to show_help_event
1704 for non-popups (Bug#3642).
1705
1706 2011-07-10 Andreas Schwab <schwab@linux-m68k.org>
1707
1708 * alloc.c (reset_malloc_hooks): Protoize.
1709 * buffer.c (mmap_init, mmap_find, mmap_free_1, mmap_enlarge)
1710 (mmap_set_vars, mmap_alloc, mmap_free, mmap_realloc): Likewise.
1711 * cm.c (losecursor): Likewise.
1712 * data.c (fmod): Likewise.
1713 * dispnew.c (swap_glyphs_in_rows): Likewise.
1714 * emacs.c (memory_warning_signal): Likewise.
1715 * floatfns.c (float_error): Likewise.
1716 * font.c (check_gstring, check_otf_features, otf_tag_symbol)
1717 (otf_open, font_otf_capability, generate_otf_features)
1718 (font_otf_DeviceTable, font_otf_ValueRecord, font_otf_Anchor):
1719 Likewise.
1720 * image.c (pbm_read_file): Likewise.
1721 * indent.c (string_display_width): Likewise.
1722 * intervals.c (check_for_interval, search_for_interval)
1723 (inc_interval_count, count_intervals, root_interval)
1724 (adjust_intervals_for_insertion, make_new_interval): Likewise.
1725 * lread.c (defalias): Likewise.
1726 * ralloc.c (r_alloc_check): Likewise.
1727 * regex.c (set_image_of_range_1, set_image_of_range)
1728 (regex_grow_registers): Likewise.
1729 * sysdep.c (strerror): Likewise.
1730 * termcap.c (valid_filename_p, tprint, main): Likewise.
1731 * tparam.c (main): Likewise.
1732 * unexhp9k800.c (run_time_remap, save_data_space)
1733 (update_file_ptrs, read_header, write_header, calculate_checksum)
1734 (copy_file, copy_rest, display_header): Likewise.
1735 * widget.c (mark_shell_size_user_specified, create_frame_gcs):
1736 Likewise.
1737 * xdisp.c (check_it): Likewise.
1738 * xfaces.c (register_color, unregister_color, unregister_colors):
1739 Likewise.
1740 * xfns.c (print_fontset_result): Likewise.
1741 * xrdb.c (member, fatal, main): Likewise.
1742
1743 2011-07-10 Paul Eggert <eggert@cs.ucla.edu>
1744
1745 Fix minor problems found by static checking (Bug#9031).
1746 * chartab.c (char_table_set_range, map_sub_char_table):
1747 Remove unused locals.
1748 (uniprop_table): Now static.
1749 * composite.c (_work_char): Remove unused static var.
1750
1751 2011-07-09 Juanma Barranquero <lekktu@gmail.com>
1752
1753 * chartab.c (uniprop_table_uncompress): Remove unused local variable.
1754
1755 2011-07-09 Jan Djärv <jan.h.d@swipnet.se>
1756
1757 * gtkutil.c (qttip_cb): Remove code without function.
1758
1759 2011-07-09 Eli Zaretskii <eliz@gnu.org>
1760
1761 * w32.c (pthread_sigmask): New stub.
1762
1763 2011-07-08 Paul Eggert <eggert@cs.ucla.edu>
1764
1765 Use pthread_sigmask, not sigprocmask (Bug#9010).
1766 sigprocmask is portable only for single-threaded applications, and
1767 Emacs can be multi-threaded when it uses GTK.
1768 * Makefile.in (LIB_PTHREAD_SIGMASK): New macro.
1769 (LIBES): Use it.
1770 * callproc.c (Fcall_process):
1771 * process.c (create_process):
1772 * sysdep.c (sys_sigblock, sys_sigunblock, sys_sigsetmask):
1773 Use pthread_sigmask, not sigprocmask.
1774
1775 2011-07-08 Jan Djärv <jan.h.d@swipnet.se>
1776
1777 * gtkutil.c (qttip_cb): Set line wrap to FALSE for tooltip widget.
1778 (xg_prepare_tooltip): Revert text in x->ttip_lbl, margins was
1779 wrong (Bug#8591).
1780
1781 2011-07-08 Jan Djärv <jan.h.d@swipnet.se>
1782
1783 * gtkutil.c (xg_prepare_tooltip): Fix indentation and comment.
1784 Put text in x->ttip_lbl instead of gtk_tooltip_set_text (Bug#8591).
1785 (xg_hide_tooltip): Fix comment.
1786
1787 * nsterm.m (initFrameFromEmacs): Don't use ns_return_types
1788 in registerServicesMenuSendTypes.
1789 (validRequestorForSendType): Don't check ns_return_types.
1790
1791 * nsfns.m (Fx_open_connection): Put NSStringPboardType into
1792 ns_return_type.
1793
1794 2011-07-08 Jason Rumney <jasonr@gnu.org>
1795
1796 * w32fns.c (w32_wnd_proc) [WM_TIMER, WM_SET_CURSOR]: Avoid using
1797 frame struct members of non-existent frames (Bug#6284).
1798
1799 2011-07-08 Jan Djärv <jan.h.d@swipnet.se>
1800
1801 * nsterm.m (keyDown): Call to wantsToDelayTextChangeNotifications and
1802 variable firstTime not needed on OSX >= 10.6.
1803 (setPosition): setFloatValue:knobProportion: is deprecated on OSX
1804 >= 10.5. Use setKnobProportion, setDoubleValue.
1805
1806 * nsterm.h (MAC_OS_X_VERSION_10_3, MAC_OS_X_VERSION_10_4)
1807 (MAC_OS_X_VERSION_10_5): Define if not defined.
1808 (EmacsView, EmacsTooltip): Implements NSWindowDelegate on OSX >= 10.6.
1809 (EmacsMenu): Implements NSMenuDelegate on OSX >= 10.6.
1810 (EmacsToolbar): Implements NSToolbarDelegate on OSX >= 10.6.
1811
1812 * nsselect.m (ns_string_from_pasteboard): Don't use deprecated methods
1813 cString and lossyCString on OSX >= 10.4
1814
1815 * nsmenu.m (fillWithWidgetValue): Don't use depercated method
1816 sizeToFit on OSX >= 10.2.
1817
1818 * nsimage.m (allocInitFromFile): Don't use deprecated method
1819 bestRepresentationForDevice on OSX >= 10.6.
1820
1821 * nsfns.m (check_ns_display_info): Cast to long and use %ld in error
1822 to avoid warning.
1823
1824 * emacs.c: Declare unexec_init_emacs_zone.
1825
1826 * nsgui.h: Fix compiler warning about gnulib redefining verify.
1827
1828 * nsselect.m (ns_get_local_selection): Change to extern (Bug#8842).
1829
1830 * nsmenu.m (ns_update_menubar): Remove useless setDelegate call
1831 on svcsMenu (Bug#8842).
1832
1833 * nsfns.m (Fx_open_connection): Remove NSStringPboardType from
1834 ns_return_types.
1835 (Fns_list_services): Just return Qnil on 10.6, code not working there.
1836
1837 * nsterm.m (QUTF8_STRING): Declare.
1838 (initFrameFromEmacs): Call registerServicesMenuSendTypes.
1839 (validRequestorForSendType): Return type is (id).
1840 Change indexOfObjectIdenticalTo to indexOfObject.
1841 Check if we have local selection before returning self (Bug#8842).
1842 (writeSelectionToPasteboard): Put local selection into paste board
1843 if we have a local selection (Bug#8842).
1844 (syms_of_nsterm): DEFSYM QUTF8_STRING.
1845
1846 * nsterm.h (MAC_OS_X_VERSION_10_6): Define here instead of nsterm.m.
1847 (ns_get_local_selection): Declare.
1848
1849 2011-07-07 Lars Magne Ingebrigtsen <larsi@gnus.org>
1850
1851 * keymap.c (describe_map_tree): Don't insert a double newline at
1852 the end of the buffer (bug#1169) and return whether we inserted
1853 something.
1854
1855 * callint.c (Fcall_interactively): Change "reading args" to
1856 "providing args" to try to clarify what it does (bug#1010).
1857
1858 2011-07-07 Kenichi Handa <handa@m17n.org>
1859
1860 * composite.c (composition_compute_stop_pos): Ignore a static
1861 composition starting before CHARPOS (Bug#8915).
1862
1863 * xdisp.c (handle_composition_prop): Likewise.
1864
1865 2011-07-07 Eli Zaretskii <eliz@gnu.org>
1866
1867 * term.c (produce_glyphs) <xassert>: Allow IT_GLYPHLESS in it->what.
1868 (Bug#9015)
1869
1870 2011-07-07 Kenichi Handa <handa@m17n.org>
1871
1872 * character.h (unicode_category_t): New enum type.
1873
1874 * chartab.c (uniprop_decoder_t, uniprop_encoder_t): New types.
1875 (Qchar_code_property_table): New variable.
1876 (UNIPROP_TABLE_P, UNIPROP_GET_DECODER)
1877 (UNIPROP_COMPRESSED_FORM_P): New macros.
1878 (char_table_ascii): Uncompress the compressed values.
1879 (sub_char_table_ref): New arg is_uniprop. Callers changed.
1880 Uncompress the compressed values.
1881 (sub_char_table_ref_and_range): Likewise.
1882 (char_table_ref_and_range): Uncompress the compressed values.
1883 (sub_char_table_set): New arg is_uniprop. Callers changed.
1884 Uncompress the compressed values.
1885 (sub_char_table_set_range): Args changed. Callers changed.
1886 (char_table_set_range): Adjuted for the above change.
1887 (map_sub_char_table): Delete args default_val and parent. Add arg
1888 top. Give decoded values to a Lisp function.
1889 (map_char_table): Adjust for the above change. Give decoded
1890 values to a Lisp function. Gcpro more variables.
1891 (uniprop_table_uncompress)
1892 (uniprop_decode_value_run_length): New functions.
1893 (uniprop_decoder, uniprop_decoder_count): New variables.
1894 (uniprop_get_decoder, uniprop_encode_value_character)
1895 (uniprop_encode_value_run_length, uniprop_encode_value_numeric):
1896 New functions.
1897 (uniprop_encoder, uniprop_encoder_count): New variables.
1898 (uniprop_get_encoder, uniprop_table)
1899 (Funicode_property_table_internal, Fget_unicode_property_internal)
1900 (Fput_unicode_property_internal): New functions.
1901 (syms_of_chartab): DEFSYM Qchar_code_property_table, defsubr
1902 Sunicode_property_table_internal, Sget_unicode_property_internal,
1903 and Sput_unicode_property_internal. Defvar_lisp
1904 char-code-property-alist.
1905
1906 * composite.c (CHAR_COMPOSABLE_P): Adjust for the change of
1907 Vunicode_category_table.
1908
1909 * font.c (font_range): Adjust for the change of
1910 Vunicode_category_table.
1911
1912 2011-07-07 Dan Nicolaescu <dann@ics.uci.edu>
1913
1914 * m/iris4d.h: Remove file, move contents ...
1915 * s/irix6-5.h: ... here.
1916
1917 2011-07-06 Paul Eggert <eggert@cs.ucla.edu>
1918
1919 Remove unportable assumption about struct layout (Bug#8884).
1920 * alloc.c (mark_buffer):
1921 * buffer.c (reset_buffer_local_variables, Fbuffer_local_variables)
1922 (clone_per_buffer_values): Don't assume that
1923 sizeof (struct buffer) is a multiple of sizeof (Lisp_Object).
1924 This isn't true in general, and it's particularly not true
1925 if Emacs is configured with --with-wide-int.
1926 * buffer.h (FIRST_FIELD_PER_BUFFER, LAST_FIELD_PER_BUFFER):
1927 New macros, used in the buffer.c change.
1928
1929 2011-07-05 Jan Djärv <jan.h.d@swipnet.se>
1930
1931 * xsettings.c: Use both GConf and GSettings if both are available.
1932 (store_config_changed_event): Add comment.
1933 (dpyinfo_valid, store_font_name_changed, map_tool_bar_style)
1934 (store_tool_bar_style_changed): New functions.
1935 (store_monospaced_changed): Add comment. Call dpyinfo_valid.
1936 (struct xsettings): Move font inside HAVE_XFT.
1937 (GSETTINGS_TOOL_BAR_STYLE, GSETTINGS_FONT_NAME): New defines.
1938 (GSETTINGS_MONO_FONT): Rename from SYSTEM_MONO_FONT.
1939 Move inside HAVE_XFT.
1940 (something_changed_gsettingsCB): Rename from something_changedCB.
1941 Check for changes in GSETTINGS_TOOL_BAR_STYLE and GSETTINGS_FONT_NAME
1942 also.
1943 (GCONF_TOOL_BAR_STYLE, GCONF_FONT_NAME): New defines.
1944 (GCONF_MONO_FONT): Rename from SYSTEM_MONO_FONT. Move inside HAVE_XFT.
1945 (something_changed_gconfCB): Rename from something_changedCB.
1946 Check for changes in GCONF_TOOL_BAR_STYLE and GCONF_FONT_NAME also.
1947 (parse_settings): Move check for font inside HAVE_XFT.
1948 (read_settings, apply_xft_settings): Add comment.
1949 (read_and_apply_settings): Add comment. Call map_tool_bar_style and
1950 store_tool_bar_style_changed. Move check for font inside HAVE_XFT and
1951 call store_font_name_changed.
1952 (xft_settings_event): Add comment.
1953 (init_gsettings): Add comment. Get values for GSETTINGS_TOOL_BAR_STYLE
1954 and GSETTINGS_FONT_NAME. Move check for fonts within HAVE_XFT.
1955 (init_gconf): Add comment. Get values for GCONF_TOOL_BAR_STYLE
1956 and GCONF_FONT_NAME. Move check for fonts within HAVE_XFT.
1957 (xsettings_initialize): Call init_gsettings last.
1958 (xsettings_get_system_font, xsettings_get_system_normal_font):
1959 Add comment.
1960
1961 2011-07-05 Paul Eggert <eggert@cs.ucla.edu>
1962
1963 Random fixes. E.g., (random) never returned negative values.
1964 * fns.c (Frandom): Use GET_EMACS_TIME for random seed, and add the
1965 subseconds part to the entropy, as that's a bit more random.
1966 Prefer signed to unsigned, since the signedness doesn't matter and
1967 in general we prefer signed. When given a limit, use a
1968 denominator equal to INTMASK + 1, not to VALMASK + 1, because the
1969 latter isn't right if USE_2_TAGS_FOR_INTS.
1970 * sysdep.c (get_random): Return a value in the range 0..INTMASK,
1971 not 0..VALMASK. Don't discard "excess" bits that random () returns.
1972
1973 2011-07-04 Stefan Monnier <monnier@iro.umontreal.ca>
1974
1975 * textprop.c (text_property_stickiness):
1976 Obey Vtext_property_default_nonsticky.
1977 (syms_of_textprop): Add `display' to Vtext_property_default_nonsticky.
1978 * w32fns.c (syms_of_w32fns):
1979 * xfns.c (syms_of_xfns): Don't Add `display' since it's there by default.
1980
1981 2011-07-04 Paul Eggert <eggert@cs.ucla.edu>
1982
1983 * fileio.c (barf_or_query_if_file_exists): Use S_ISDIR.
1984 This is more efficient than Ffile_directory_p and avoids a minor race.
1985
1986 2011-07-04 Lars Magne Ingebrigtsen <larsi@gnus.org>
1987
1988 * buffer.c (Foverlay_put): Say what the return value is
1989 (bug#7835).
1990
1991 * fileio.c (barf_or_query_if_file_exists): Check first if the file
1992 is a directory before asking whether to use the file name
1993 (bug#7564).
1994 (barf_or_query_if_file_exists): Make the "File is a directory"
1995 error be more correct.
1996
1997 * fns.c (Frequire): Remove the mention of the .gz files, since
1998 that's installation-specific, but keep the mention of
1999 `get-load-suffixes'.
2000
2001 2011-07-04 Paul Eggert <eggert@cs.ucla.edu>
2002
2003 * editfns.c (Fformat_time_string): Don't assume strlen fits in int.
2004 Report string overflow if the output is too long.
2005
2006 2011-07-04 Juanma Barranquero <lekktu@gmail.com>
2007
2008 * gnutls.c (Fgnutls_boot): Don't mention :verify-error.
2009 (syms_of_gnutls): Remove duplicate DEFSYM for
2010 Qgnutls_bootprop_verify_hostname_error, an error for
2011 Qgnutls_bootprop_verify_error (which is no longer used).
2012
2013 * eval.c (find_handler_clause): Remove parameters `sig' and `data',
2014 unused since 2011-01-26T20:02:07Z!monnier@iro.umontreal.ca. All callers changed.
2015 Also (re)move comments that are misplaced or no longer relevant.
2016
2017 2011-07-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
2018
2019 * callint.c (Finteractive): Clarify the meaning of "@" (bug#8813).
2020
2021 2011-07-03 Chong Yidong <cyd@stupidchicken.com>
2022
2023 * xfaces.c (Finternal_merge_in_global_face): Modify the foreground
2024 and background color parameters if they have been changed.
2025
2026 2011-07-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
2027
2028 * editfns.c (Fformat): Clarify the - and 0 flags (bug#6659).
2029
2030 2011-07-03 Paul Eggert <eggert@cs.ucla.edu>
2031
2032 * xsettings.c (SYSTEM_FONT): Define only when used.
2033 No need to define when HAVE_GSETTINGS || !HAVE_XFT.
2034
2035 * keymap.c (access_keymap_1): Now static.
2036
2037 2011-07-02 Chong Yidong <cyd@stupidchicken.com>
2038
2039 * keyboard.c (command_loop_1): If a down-mouse event is unbound,
2040 leave any prefix arg for the up event (Bug#1586).
2041
2042 2011-07-02 Lars Magne Ingebrigtsen <larsi@gnus.org>
2043
2044 * lread.c (syms_of_lread): Mention single symbols defined by
2045 `defvar' or `defconst' (bug#7154).
2046
2047 * fns.c (Frequire): Mention .el.gz files (bug#7314).
2048 (Frequire): Mention get-load-suffixes.
2049
2050 2011-07-02 Martin Rudalics <rudalics@gmx.at>
2051
2052 * window.h (window): Remove clone_number slot.
2053 * window.c (Fwindow_clone_number, Fset_window_clone_number):
2054 Remove.
2055 (make_parent_window, make_window, saved_window)
2056 (Fset_window_configuration, save_window_save): Don't deal with
2057 clone numbers.
2058 * buffer.c (Qclone_number): Remove declaration.
2059 (sort_overlays, overlay_strings): Don't deal with clone numbers.
2060
2061 2011-07-02 Stefan Monnier <monnier@iro.umontreal.ca>
2062
2063 Add multiple inheritance to keymaps.
2064 * keymap.c (Fmake_composed_keymap): New function.
2065 (Fset_keymap_parent): Simplify.
2066 (fix_submap_inheritance): Remove.
2067 (access_keymap_1): New function extracted from access_keymap to handle
2068 embedded parents and handle lists of maps.
2069 (access_keymap): Use it.
2070 (Fkeymap_prompt, map_keymap_internal, map_keymap, store_in_keymap)
2071 (Fcopy_keymap): Handle embedded parents.
2072 (Fcommand_remapping, define_as_prefix): Simplify.
2073 (Fkey_binding): Simplify.
2074 (syms_of_keymap): Move minibuffer-local-completion-map,
2075 minibuffer-local-filename-completion-map,
2076 minibuffer-local-must-match-map, and
2077 minibuffer-local-filename-must-match-map to Elisp.
2078 (syms_of_keymap): Defsubr make-composed-keymap.
2079 * keyboard.c (menu_bar_items): Use map_keymap_canonical.
2080 (parse_menu_item): Trivial simplification.
2081
2082 2011-07-01 Glenn Morris <rgm@gnu.org>
2083
2084 * Makefile.in (SETTINGS_LIBS): Fix typo.
2085
2086 2011-07-01 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny patch)
2087
2088 * coding.c (Fencode_coding_string): Record the last coding system
2089 used, as the function doc string says (bug#8738).
2090
2091 2011-07-01 Jan Djärv <jan.h.d@swipnet.se>
2092
2093 * xsettings.c (store_monospaced_changed): Take new font as arg and
2094 check for change against current_mono_font.
2095 (EMACS_TYPE_SETTINGS): Remove this and related defines.
2096 (emacs_settings_constructor, emacs_settings_get_property)
2097 (emacs_settings_set_property, emacs_settings_class_init)
2098 (emacs_settings_init, gsettings_obj): Remove.
2099 (something_changedCB): New function for HAVE_GSETTINGS.
2100 (something_changedCB): HAVE_GCONF: Call store_monospaced_changed
2101 with value as argument.
2102 (init_gsettings): Check that GSETTINGS_SCHEMA exists before calling
2103 g_settings_new (Bug#8967). Do not create gsettings_obj.
2104 Remove calls to g_settings_bind. Connect something_changedCB to
2105 "changed".
2106
2107 * xgselect.c: Add defined (HAVE_GSETTINGS).
2108 (xgselect_initialize): Ditto.
2109
2110 * process.c: Add defined (HAVE_GSETTINGS) for xgselect.h
2111 (wait_reading_process_output): Add defined (HAVE_GSETTINGS) for
2112 xg_select.
2113
2114 2011-07-01 Paul Eggert <eggert@cs.ucla.edu>
2115
2116 * eval.c (struct backtrace): Simplify and port the data structure.
2117 Do not assume that "int nargs : BITS_PER_INT - 2;" produces a
2118 signed bit field, as this assumption is not portable and it makes
2119 Emacs crash when compiled with Sun C 5.8 on sparc. Do not use
2120 "char debug_on_exit : 1" as this is not portable either; instead,
2121 use the portable "unsigned int debug_on_exit : 1". Remove unused
2122 member evalargs. Remove obsolete comments about cc bombing out.
2123
2124 2011-06-30 Jan Djärv <jan.h.d@swipnet.se>
2125
2126 * xsettings.c: Include glib-object.h, gio/gio.h if HAVE_GSETTINGS.
2127 Let HAVE_GSETTINGS override HAVE_GCONF.
2128 (store_monospaced_changed): New function.
2129 (EMACS_SETTINGS): A new type derived from GObject to handle
2130 GSettings notifications.
2131 (emacs_settings_constructor, emacs_settings_get_property)
2132 (emacs_settings_set_property, emacs_settings_class_init):
2133 New functions.
2134 (gsettings_client, gsettings_obj): New variables.
2135 (GSETTINGS_SCHEMA): New define.
2136 (something_changedCB): Call store_monospaced_changed.
2137 (init_gsettings): New function.
2138 (xsettings_initialize): Call init_gsettings.
2139 (syms_of_xsettings): Initialize gsettings_client, gsettings_obj
2140 to NULL.
2141
2142 * Makefile.in (SETTINGS_CFLAGS, SETTINGS_LIBS): Rename from
2143 GCONF_CFLAGS/LIBS.
2144
2145 2011-06-29 Martin Rudalics <rudalics@gmx.at>
2146
2147 * window.c (resize_root_window, grow_mini_window)
2148 (shrink_mini_window): Rename Qresize_root_window to
2149 Qwindow_resize_root_window and Qresize_root_window_vertically to
2150 Qwindow_resize_root_window_vertically.
2151
2152 2011-06-28 Paul Eggert <eggert@cs.ucla.edu>
2153
2154 * gnutls.c (Qgnutls_bootprop_verify_error): Remove unused var.
2155
2156 2011-06-27 Juanma Barranquero <lekktu@gmail.com>
2157
2158 * makefile.w32-in: Redesign dependencies so they reflect more
2159 clearly which files are directly included by each source file,
2160 and not through other includes.
2161
2162 2011-06-27 Martin Rudalics <rudalics@gmx.at>
2163
2164 * buffer.c (Qclone_number): Declare static and DEFSYM it.
2165 (sort_overlays, overlay_strings): When an overlay's clone number
2166 matches the window's clone number process the overlay even if
2167 the overlay's window property doesn't match the current window.
2168
2169 * window.c (Fwindow_vchild): Rename to Fwindow_top_child.
2170 (Fwindow_hchild): Rename to Fwindow_left_child.
2171 (Fwindow_next): Rename to Fwindow_next_sibling.
2172 (Fwindow_prev): Rename to Fwindow_prev_sibling.
2173 (resize_window_check): Rename to window_resize_check.
2174 (resize_window_apply): Rename to window_resize_apply.
2175 (Fresize_window_apply): Rename to Fwindow_resize_apply.
2176 (Fdelete_other_windows_internal, resize_frame_windows)
2177 (Fsplit_window_internal, Fdelete_window_internal)
2178 (grow_mini_window, shrink_mini_window)
2179 (Fresize_mini_window_internal): Fix callers accordingly.
2180
2181 2011-06-26 Jan Djärv <jan.h.d@swipnet.se>
2182
2183 * emacsgtkfixed.h: State that this is only used with Gtk+3.
2184 (emacs_fixed_set_min_size): Remove.
2185 (emacs_fixed_new): Take frame as argument.
2186
2187 * emacsgtkfixed.c: State that this is only used with Gtk+3.
2188 (_EmacsFixedPrivate): Remove minwidth/height.
2189 Add struct frame *f.
2190 (emacs_fixed_init): Initialize priv->f.
2191 (get_parent_class, emacs_fixed_set_min_size): Remove.
2192 (emacs_fixed_new): Set priv->f to argument.
2193 (emacs_fixed_get_preferred_width)
2194 (emacs_fixed_get_preferred_height): Use min_width/height from
2195 frames size_hint to set minimum and natural (Bug#8919).
2196 (XSetWMSizeHints, XSetWMNormalHints): Override these functions
2197 and use min_width/height from frames size_hint to set
2198 min_width/height (Bug#8919).
2199
2200 * gtkutil.c (xg_create_frame_widgets): Pass f to emacs_fixed_new.
2201 (x_wm_set_size_hint): Remove call to emacs_fixed_set_min_size.
2202 Fix indentation.
2203
2204 2011-06-26 Eli Zaretskii <eliz@gnu.org>
2205
2206 * bidi.c (bidi_paragraph_init): Test for ZV_BYTE before calling
2207 bidi_at_paragraph_end, since fast_looking_at doesn't like to be
2208 called at ZV.
2209
2210 2011-06-26 Chong Yidong <cyd@stupidchicken.com>
2211
2212 * process.c (wait_reading_process_output): Bypass select if
2213 waiting for a cell while ignoring keyboard input, and input is
2214 pending. Suggested by Jan Djärv (Bug#8869).
2215
2216 2011-06-25 Paul Eggert <eggert@cs.ucla.edu>
2217
2218 Use gnulib's dup2 module instead of rolling our own.
2219 * sysdep.c (dup2) [!HAVE_DUP2]: Remove; gnulib now does this.
2220
2221 2011-06-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
2222
2223 * dispnew.c (scrolling_window): Before scrolling, turn off a
2224 mouse-highlight in the window being scrolled.
2225
2226 2011-06-24 Juanma Barranquero <lekktu@gmail.com>
2227
2228 Move DEFSYM to lisp.h and use everywhere.
2229
2230 * character.h (DEFSYM): Move declaration...
2231 * lisp.h (DEFSYM): ...here.
2232
2233 * gnutls.c:
2234 * minibuf.c:
2235 * w32menu.c:
2236 * w32proc.c:
2237 * w32select.c: Don't include character.h.
2238
2239 * alloc.c (syms_of_alloc):
2240 * buffer.c (syms_of_buffer):
2241 * bytecode.c (syms_of_bytecode):
2242 * callint.c (syms_of_callint):
2243 * casefiddle.c (syms_of_casefiddle):
2244 * casetab.c (init_casetab_once):
2245 * category.c (init_category_once, syms_of_category):
2246 * ccl.c (syms_of_ccl):
2247 * cmds.c (syms_of_cmds):
2248 * composite.c (syms_of_composite):
2249 * dbusbind.c (syms_of_dbusbind):
2250 * dired.c (syms_of_dired):
2251 * dispnew.c (syms_of_display):
2252 * doc.c (syms_of_doc):
2253 * editfns.c (syms_of_editfns):
2254 * emacs.c (syms_of_emacs):
2255 * eval.c (syms_of_eval):
2256 * fileio.c (syms_of_fileio):
2257 * fns.c (syms_of_fns):
2258 * frame.c (syms_of_frame):
2259 * fringe.c (syms_of_fringe):
2260 * insdel.c (syms_of_insdel):
2261 * keymap.c (syms_of_keymap):
2262 * lread.c (init_obarray, syms_of_lread):
2263 * macros.c (syms_of_macros):
2264 * msdos.c (syms_of_msdos):
2265 * print.c (syms_of_print):
2266 * process.c (syms_of_process):
2267 * search.c (syms_of_search):
2268 * sound.c (syms_of_sound):
2269 * syntax.c (init_syntax_once, syms_of_syntax):
2270 * terminal.c (syms_of_terminal):
2271 * textprop.c (syms_of_textprop):
2272 * undo.c (syms_of_undo):
2273 * w32.c (globals_of_w32):
2274 * window.c (syms_of_window):
2275 * xdisp.c (syms_of_xdisp):
2276 * xfaces.c (syms_of_xfaces):
2277 * xfns.c (syms_of_xfns):
2278 * xmenu.c (syms_of_xmenu):
2279 * xsettings.c (syms_of_xsettings):
2280 * xterm.c (syms_of_xterm): Use DEFSYM.
2281
2282 2011-06-24 Teodor Zlatanov <tzz@lifelogs.com>
2283
2284 * gnutls.c (syms_of_gnutls): Use the DEFSYM macro from character.h.
2285
2286 2011-06-23 Paul Eggert <eggert@cs.ucla.edu>
2287
2288 Integer and buffer overflow fixes (Bug#8873).
2289
2290 * print.c (printchar, strout): Check for string overflow.
2291 (PRINTPREPARE, printchar, strout):
2292 Don't set size unless allocation succeeds.
2293
2294 * minibuf.c (read_minibuf_noninteractive): Use ptrdiff_t, not int,
2295 for sizes. Check for string overflow more accurately.
2296 Simplify newline removal at end; this suppresses a GCC 4.6.0 warning.
2297
2298 * macros.c: Integer and buffer overflow fixes.
2299 * keyboard.h (struct keyboard.kbd_macro_bufsize):
2300 * macros.c (Fstart_kbd_macro, store_kbd_macro_char):
2301 Use ptrdiff_t, not int, for sizes.
2302 Don't increment bufsize until after realloc succeeds.
2303 Check for size-calculation overflow.
2304 (Fstart_kbd_macro): Use EMACS_INT, not int, for XINT result.
2305
2306 * lisp.h (DEFVAR_KBOARD): Use offsetof instead of char * finagling.
2307
2308 * lread.c: Integer overflow fixes.
2309 (read_integer): Radix is now EMACS_INT, not int,
2310 to improve quality of diagnostics for out-of-range radices.
2311 Calculate buffer size correctly for out-of-range radices.
2312 (read1): Check for integer overflow in radices, and in
2313 read-circle numbers.
2314 (read_escape): Avoid int overflow.
2315 (Fload, openp, read_buffer_size, read1)
2316 (substitute_object_recurse, read_vector, read_list, map_obarray):
2317 Use ptrdiff_t, not int, for sizes.
2318 (read1): Use EMACS_INT, not int, for sizes.
2319 Check for size overflow.
2320
2321 * image.c (cache_image): Check for size arithmetic overflow.
2322
2323 * lread.c: Integer overflow issues.
2324 (saved_doc_string_size, saved_doc_string_length)
2325 (prev_saved_doc_string_size, prev_saved_doc_string_length):
2326 Now ptrdiff_t, not int.
2327 (read1): Don't assume doc string length fits in int. Check for
2328 out-of-range doc string lengths.
2329 (read_list): Don't assume file position fits in int.
2330 (read_escape): Check for hex character overflow.
2331
2332 2011-06-22 Leo Liu <sdl.web@gmail.com>
2333
2334 * minibuf.c (Fcompleting_read_default, Vcompleting_read_function):
2335 Move to minibuffer.el.
2336
2337 2011-06-22 Paul Eggert <eggert@cs.ucla.edu>
2338
2339 Fixes for GLYPH_DEBUG found by GCC 4.6.0 static checking.
2340 The following patches are for when GLYPH_DEBUG && !XASSERT.
2341 * dispextern.h (trace_redisplay_p, dump_glyph_string):
2342 * dispnew.c (flush_stdout):
2343 * xdisp.c (dump_glyph_row, dump_glyph_matrix, dump_glyph):
2344 Mark as externally visible.
2345 * dispnew.c (check_window_matrix_pointers): Now static.
2346 * dispnew.c (window_to_frame_vpos):
2347 * xfns.c (unwind_create_frame):
2348 * xterm.c (x_check_font): Remove unused local.
2349 * scroll.c (CHECK_BOUNDS):
2350 * xfaces.c (cache_fache): Rename local to avoid shadowing.
2351 * xfns.c, w32fns.c (image_cache_refcount, dpyinfo_refcount): Now static.
2352 * xdisp.c (check_window_end): Now a no-op if !XASSERTS.
2353 (debug_first_unchanged_at_end_vpos, debug_last_unchanged_at_beg_vpos)
2354 (debug_dvpos, debug_dy, debug_delta, debug_delta_bytes, debug_end_vpos):
2355 Now static.
2356 (debug_method_add): Use va_list and vsprintf rather than relying
2357 on undefined behavior with wrong number of arguments.
2358 (dump_glyph, dump_glyph_row, Fdump_glyph_matrix):
2359 Don't assume ptrdiff_t and EMACS_INT are the same width as int.
2360 In this code, it's OK to assume C99 behavior for ptrdiff_t formats
2361 since we're not interested in debugging glyphs with old libraries.
2362 * xfaces.c (cache_face): Move debugging code earlier; this pacifies
2363 GCC 4.6.0's static checking.
2364
2365 2011-06-22 Paul Eggert <eggert@cs.ucla.edu>
2366
2367 Integer overflow and signedness fixes (Bug#8873).
2368 A few related buffer overrun fixes, too.
2369
2370 * font.c (font_score): Use EMACS_INT, not int, to store XINT value.
2371
2372 * dispextern.h (struct face.stipple):
2373 * image.c (x_bitmap_height, x_bitmap_width, x_bitmap_pixmap)
2374 (x_bitmap_mask, x_allocate_bitmap_record)
2375 (x_create_bitmap_from_data, x_create_bitmap_from_file)
2376 (x_destroy_bitmap, x_destroy_all_bitmaps, x_create_bitmap_mask)
2377 (x_create_bitmap_from_xpm_data):
2378 * nsterm.h (struct ns_display_info.bitmaps_size, .bitmaps_last):
2379 * w32term.h (struct w32_display_info.icon_bitmap_id, .bitmaps_size)
2380 (.bitmaps_last):
2381 * xfaces.c (load_pixmap):
2382 * xterm.c (x_bitmap_icon, x_wm_set_icon_pixmap):
2383 * xterm.h (struct x_display_info.icon_bitmap_id, .bitmaps_size)
2384 (.bitmaps_last, struct x_output.icon_bitmap):
2385 Use ptrdiff_t, not int, for bitmap indexes.
2386 (x_allocate_bitmap_record): Check for size overflow.
2387 * dispextern.h, lisp.h: Adjust to API changes elsewhere.
2388
2389 Use ptrdiff_t, not int, for overlay counts.
2390 * buffer.h (overlays_at, sort_overlays, GET_OVERLAYS_AT):
2391 * editfns.c (overlays_around, get_pos_property):
2392 * textprop.c (get_char_property_and_overlay):
2393 * xdisp.c (next_overlay_change, note_mouse_highlight):
2394 * xfaces.c (face_at_buffer_position):
2395 * buffer.c (OVERLAY_COUNT_MAX): New macro.
2396 (overlays_at, overlays_in, sort_overlays, Foverlays_at)
2397 (Fnext_overlay_change, Fprevious_overlay_change)
2398 (mouse_face_overlay_overlaps, Foverlays_in):
2399 Use ptrdiff_t, not int, for sizes.
2400 (overlays_at, overlays_in): Check for size-calculation overflow.
2401
2402 * xterm.c (xim_initialize, same_x_server): Strlen may not fit in int.
2403
2404 * xsmfns.c (smc_save_yourself_CB, x_session_initialize): Avoid strlen.
2405 (x_session_initialize): Do not assume string length fits in int.
2406
2407 * xsettings.c (apply_xft_settings): Fix potential buffer overrun.
2408 This is unlikely, but can occur if DPI is outlandish.
2409
2410 * xsettings.c (Ffont_get_system_normal_font, Ffont_get_system_font):
2411 * xselect.c (Fx_get_atom_name): Avoid need for strlen.
2412
2413 * xrdb.c: Don't assume strlen fits in int; avoid some strlens.
2414 * xrdb.c (magic_file_p, search_magic_path):
2415 Omit last arg SUFFIX; it was always 0. All callers changed.
2416 (magic_file_p): Use ptrdiff_t, not int. Check for size overflow.
2417
2418 * xfont.c (xfont_match): Avoid need for strlen.
2419
2420 * xfns.c: Don't assume strlen fits in int.
2421 (xic_create_fontsetname, x_window): Use ptrdiff_t, not int.
2422
2423 * xdisp.c (message_log_check_duplicate): Return intmax_t,
2424 not unsigned long, as we prefer signed integers. All callers changed.
2425 Detect integer overflow in repeat count.
2426 (message_dolog): Don't assume print length fits in 39 bytes.
2427 (display_mode_element): Don't assume strlen fits in int.
2428
2429 * termcap.c: Don't assume sizes fit in int and never overflow.
2430 (struct termcap_buffer, tgetent): Use ptrdiff_t, not int, for sizes.
2431 (gobble_line): Check for size-calculation overflow.
2432
2433 * minibuf.c (Fread_buffer):
2434 * lread.c (intern, intern_c_string):
2435 * image.c (xpm_scan) [HAVE_NS && !HAVE_XPM]:
2436 Don't assume string length fits in int.
2437
2438 * keyboard.c (parse_tool_bar_item):
2439 * gtkutil.c (style_changed_cb): Avoid need for strlen.
2440
2441 * font.c: Don't assume string length fits in int.
2442 (font_parse_xlfd, font_parse_fcname, font_unparse_fcname):
2443 Use ptrdiff_t, not int.
2444 (font_intern_prop): Don't assume string length fits in int.
2445 Don't assume integer property fits in fixnum.
2446 * font.h (font_intern_prop): 2nd arg is now ptrdiff_t, not int.
2447
2448 * filelock.c: Fix some buffer overrun and integer overflow issues.
2449 (get_boot_time): Don't assume gzip command string fits in 100 bytes.
2450 Reformulate so as not to need the command string.
2451 Invoke gzip -cd rather than gunzip, as it's more portable.
2452 (lock_info_type, lock_file_1, lock_file):
2453 Don't assume pid_t and time_t fit in unsigned long.
2454 (LOCK_PID_MAX): Remove; we now use more-reliable bounds.
2455 (current_lock_owner): Prefer signed type for sizes.
2456 Use memcpy, not strncpy, where memcpy is what is really wanted.
2457 Don't assume (via atoi) that time_t and pid_t fit in int.
2458 Check for time_t and/or pid_t out of range, e.g., via a network share.
2459 Don't alloca where an auto var works fine.
2460
2461 * fileio.c: Fix some integer overflow issues.
2462 (file_name_as_directory, Fexpand_file_name, Fsubstitute_in_file_name):
2463 Don't assume string length fits in int.
2464 (directory_file_name): Don't assume string length fits in long.
2465 (make_temp_name): Don't assume pid fits in int, or that its print
2466 length is less than 20.
2467
2468 * data.c (Fsubr_name): Rewrite to avoid a strlen call.
2469
2470 * coding.c (make_subsidiaries): Don't assume string length fits in int.
2471
2472 * callproc.c (child_setup): Rewrite to avoid two strlen calls.
2473
2474 * process.c (Fformat_network_address): Use EMACS_INT, not EMACS_UINT.
2475 We prefer signed integers, even for size calculations.
2476
2477 * emacs.c: Don't assume string length fits in 'int'.
2478 (DEFINE_DUMMY_FUNCTION, sort_args): Use ptrdiff_t, not int.
2479 (main): Don't invoke strlen when not needed.
2480
2481 * dbusbind.c (XD_ERROR): Don't arbitrarily truncate string.
2482 (XD_DEBUG_MESSAGE): Don't waste a byte.
2483
2484 * callproc.c (getenv_internal_1, getenv_internal)
2485 (Fgetenv_internal):
2486 * buffer.c (init_buffer): Don't assume string length fits in 'int'.
2487
2488 * lread.c (invalid_syntax): Omit length argument.
2489 All uses changed. This doesn't fix a bug, but it simplifies the
2490 code away from its former Hollerith-constant appearance, and it's
2491 one less 'int' to worry about when looking at integer-overflow issues.
2492 (string_to_number): Simplify 2011-04-26 change by invoking xsignal1.
2493
2494 * lisp.h (DEFUN): Remove bogus use of sizeof (struct Lisp_Subr).
2495 This didn't break anything, but it didn't help either.
2496 It's confusing to put a bogus integer in a place where the actual
2497 value does not matter.
2498 (LIST_END_P): Remove unused macro and its bogus comment.
2499 (make_fixnum_or_float): Remove unnecessary cast to EMACS_INT.
2500
2501 * lisp.h (union Lisp_Object.i): EMACS_INT, not EMACS_UINT.
2502 This is for consistency with the ordinary, non-USE_LISP_UNION_TYPE,
2503 implementation.
2504 (struct Lisp_Bool_Vector.size): EMACS_INT, not EMACS_UINT.
2505 We prefer signed types, and the value cannot exceed the EMACS_INT
2506 range anyway (because otherwise the length would not be representable).
2507 (XSET) [USE_LISP_UNION_TYPE]: Use uintptr_t and intptr_t,
2508 not EMACS_UINT and EMACS_INT, when converting pointer to integer.
2509 This avoids a GCC warning when WIDE_EMACS_INT.
2510
2511 * indent.c (sane_tab_width): New function.
2512 (current_column, scan_for_column, Findent_to, position_indentation)
2513 (compute_motion): Use it. This is just for clarity.
2514 (Fcompute_motion): Don't assume hscroll and tab offset fit in int.
2515
2516 * image.c (xbm_image_p): Don't assume stated width, height fit in int.
2517
2518 * lisp.h (lint_assume): New macro.
2519 * composite.c (composition_gstring_put_cache):
2520 * ftfont.c (ftfont_shape_by_flt): Use it to pacify GCC 4.6.0.
2521
2522 * editfns.c, insdel.c:
2523 Omit unnecessary forward decls, to simplify future changes.
2524
2525 * ftfont.c (ftfont_shape_by_flt): Use signed integers for lengths.
2526
2527 * font.c (Ffont_shape_gstring): Don't assume glyph len fits in 'int'.
2528
2529 * fns.c (Ffillarray): Don't assume bool vector size fits in 'int'.
2530 Use much-faster test for byte-length change.
2531 Don't assume string byte-length fits in 'int'.
2532 Check that character arg fits in 'int'.
2533 (mapcar1): Declare byte as byte, for clarity.
2534
2535 * alloc.c (Fmake_bool_vector): Avoid unnecessary multiplication.
2536
2537 * fns.c (concat): Catch string overflow earlier.
2538 Do not rely on integer wraparound.
2539
2540 * dispextern.h (struct it.overlay_strings_charpos)
2541 (struct it.selective): Now EMACS_INT, not int.
2542 * xdisp.c (forward_to_next_line_start)
2543 (back_to_previous_visible_line_start)
2544 (reseat_at_next_visible_line_start, next_element_from_buffer):
2545 Don't arbitrarily truncate the value of 'selective' to int.
2546
2547 * xdisp.c (init_iterator): Use XINT, not XFASTINT; it might be < 0.
2548
2549 * composite.c: Don't truncate sizes to 'int'.
2550 (composition_gstring_p, composition_reseat_it)
2551 (composition_adjust_point): Use EMACS_INT, not int.
2552 (get_composition_id, composition_gstring_put_cache): Use EMACS_INT,
2553 not EMACS_UINT, for indexes.
2554
2555 * category.h (CATEGORY_SET_P): Remove unnecessary cast to EMACS_INT.
2556
2557 * buffer.c: Include <verify.h>.
2558 (struct sortvec.priority, struct sortstr.priority):
2559 Now EMACS_INT, not int.
2560 (compare_overlays, cmp_for_strings): Avoid subtraction overflow.
2561 (struct sortstr.size, record_overlay_string)
2562 (struct sortstrlist.size, struct sortlist.used):
2563 Don't truncate size to int.
2564 (record_overlay_string): Check for size-calculation overflow.
2565 (init_buffer_once): Check at compile-time, not run-time.
2566
2567 2011-06-22 Jim Meyering <meyering@redhat.com>
2568
2569 Don't leak an XBM-image-sized buffer
2570 * image.c (xbm_load): Free the image buffer after using it.
2571
2572 2011-06-21 Paul Eggert <eggert@cs.ucla.edu>
2573
2574 Port to Sun C.
2575 * composite.c (find_automatic_composition): Omit needless 'return 0;'
2576 that Sun C diagnosed.
2577 * fns.c (secure_hash): Fix pointer signedness issue.
2578 * intervals.c (static_offset_intervals): New function.
2579 (offset_intervals): Use it.
2580
2581 2011-06-21 Leo Liu <sdl.web@gmail.com>
2582
2583 * deps.mk (fns.o):
2584 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha256.h and
2585 sha512.h.
2586
2587 * fns.c (secure_hash): Rename from crypto_hash_function and change
2588 the first arg to accept symbols.
2589 (Fsecure_hash): New primitive.
2590 (syms_of_fns): New symbols.
2591
2592 2011-06-20 Deniz Dogan <deniz@dogan.se>
2593
2594 * process.c (Fset_process_buffer): Clarify return value in
2595 docstring.
2596
2597 2011-06-18 Chong Yidong <cyd@stupidchicken.com>
2598
2599 * dispnew.c (add_window_display_history): Use BVAR.
2600
2601 * xdisp.c (debug_method_add): Use BVAR.
2602 (check_window_end, dump_glyph_matrix, dump_glyph)
2603 (dump_glyph_row, dump_glyph_string): Convert arglist to ANSI C.
2604
2605 * xfaces.c (check_lface_attrs, check_lface, dump_realized_face):
2606 Likewise.
2607
2608 * xfns.c (Fx_create_frame, x_create_tip_frame): Delay image cache
2609 check till after the cache is created in init_frame_faces.
2610
2611 2011-06-17 Stefan Monnier <monnier@iro.umontreal.ca>
2612
2613 * fns.c (Fsafe_length): Yet another int/Lisp_Object mixup.
2614
2615 2011-06-16 Paul Eggert <eggert@cs.ucla.edu>
2616
2617 * lisp.h: Include <limits.h>, for INT_MAX, LONG_MAX, LLONG_MAX.
2618 Without this, prin1 mishandles Lisp_Misc_Save_Value printing on
2619 hosts with pre-C99 libraries, because pD is wrongly defined to "t".
2620
2621 Improve buffer-overflow checking (Bug#8873).
2622 * fileio.c (Finsert_file_contents):
2623 * insdel.c (insert_from_buffer_1, replace_range, replace_range_2):
2624 Remove the old (too-loose) buffer overflow checks.
2625 They weren't needed, since make_gap checks for buffer overflow.
2626 * insdel.c (make_gap_larger): Catch buffer overflows that were missed.
2627 The old code merely checked for Emacs fixnum overflow, and relied
2628 on undefined (wraparound) behavior. The new code avoids undefined
2629 behavior, and also checks for ptrdiff_t and/or size_t overflow.
2630
2631 * editfns.c (Finsert_char): Don't dump core with very negative counts.
2632 Tune. Don't use wider integers than needed. Don't use alloca.
2633 Use a bigger 'string' buffer. Rewrite to avoid 'n > 0' test.
2634
2635 * insdel.c (replace_range): Fix buf overflow when insbytes < outgoing.
2636
2637 * insdel.c, lisp.h (buffer_overflow): New function.
2638 (insert_from_buffer_1, replace_range, replace_range_2):
2639 * insdel.c (make_gap_larger):
2640 * editfns.c (Finsert_char):
2641 * fileio.c (Finsert_file_contents): Use it, to normalize wording.
2642
2643 * buffer.h (BUF_BYTES_MAX): Cast to ptrdiff_t so that it's signed.
2644
2645 2011-06-15 Paul Eggert <eggert@cs.ucla.edu>
2646
2647 Integer overflow and signedness fixes (Bug#8873).
2648
2649 * ccl.c (ASCENDING_ORDER): New macro, to work around GCC bug 43772.
2650 (GET_CCL_RANGE, IN_INT_RANGE): Use it.
2651
2652 * fileio.c: Don't assume EMACS_INT fits in off_t.
2653 (emacs_lseek): New static function.
2654 (Finsert_file_contents, Fwrite_region): Use it.
2655 Use SEEK_SET, SEEK_CUR, SEEK_END as appropriate.
2656
2657 * fns.c (Fload_average): Don't assume 100 * load average fits in int.
2658
2659 * fns.c: Don't overflow int when computing a list length.
2660 * fns.c (QUIT_COUNT_HEURISTIC): New constant.
2661 (Flength, Fsafe_length): Use EMACS_INT, not int, to avoid unwanted
2662 truncation on 64-bit hosts. Check for QUIT every
2663 QUIT_COUNT_HEURISTIC entries rather than every other entry; that's
2664 faster and is responsive enough.
2665 (Flength): Report an error instead of overflowing an integer.
2666 (Fsafe_length): Return a float if the value is not representable
2667 as a fixnum. This shouldn't happen except in contrived situations.
2668 (Fnthcdr, Fsort): Don't assume list length fits in int.
2669 (Fcopy_sequence): Don't assume vector length fits in int.
2670
2671 * alloc.c: Check that resized vectors' lengths fit in fixnums.
2672 (header_size, word_size): New constants.
2673 (allocate_vectorlike): Don't check size overflow here.
2674 (allocate_vector): Check it here instead, since this is the only
2675 caller of allocate_vectorlike that could cause overflow.
2676 Check that the new vector's length is representable as a fixnum.
2677
2678 * fns.c (next_almost_prime): Don't return a multiple of 3 or 5.
2679 The previous code was bogus. For example, next_almost_prime (32)
2680 returned 39, which is undesirable as it is a multiple of 3; and
2681 next_almost_prime (24) returned 25, which is a multiple of 5 so
2682 why was the code bothering to check for multiples of 7?
2683
2684 * bytecode.c (exec_byte_code): Use ptrdiff_t, not int, for vector length.
2685
2686 * eval.c, doprnt.c (SIZE_MAX): Remove; inttypes.h defines this now.
2687
2688 Variadic C functions now count arguments with ptrdiff_t.
2689 This partly undoes my 2011-03-30 change, which replaced int with size_t.
2690 Back then I didn't know that the Emacs coding style prefers signed int.
2691 Also, in the meantime I found a few more instances where arguments
2692 were being counted with int, which may truncate counts on 64-bit
2693 machines, or EMACS_INT, which may be unnecessarily wide.
2694 * lisp.h (struct Lisp_Subr.function.aMANY)
2695 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call):
2696 Arg counts are now ptrdiff_t, not size_t.
2697 All variadic functions and their callers changed accordingly.
2698 (struct gcpro.nvars): Now size_t, not size_t. All uses changed.
2699 * bytecode.c (exec_byte_code): Check maxdepth for overflow,
2700 to avoid potential buffer overrun. Don't assume arg counts fit in 'int'.
2701 * callint.c (Fcall_interactively): Check arg count for overflow,
2702 to avoid potential buffer overrun. Use signed char, not 'int',
2703 for 'varies' array, so that we needn't bother to check its size
2704 calculation for overflow.
2705 * editfns.c (Fformat): Use ptrdiff_t, not EMACS_INT, to count args.
2706 * eval.c (apply_lambda):
2707 * fns.c (Fmapconcat): Use XFASTINT, not XINT, to get args length.
2708 (struct textprop_rec.argnum): Now ptrdiff_t, not int. All uses changed.
2709 (mapconcat): Use ptrdiff_t, not int and EMACS_INT, to count args.
2710
2711 * callint.c (Fcall_interactively): Don't use index var as event count.
2712
2713 * vm-limit.c (check_memory_limits): Fix incorrect extern function decls.
2714 * mem-limits.h (SIZE): Remove; no longer used.
2715
2716 * xterm.c (x_alloc_nearest_color_1): Prefer int to long when int works.
2717
2718 Remove unnecessary casts.
2719 * xterm.c (x_term_init):
2720 * xfns.c (x_set_border_pixel):
2721 * widget.c (create_frame_gcs): Remove casts to unsigned long etc.
2722 These aren't needed now that we assume ANSI C.
2723
2724 * sound.c (Fplay_sound_internal): Remove cast to unsigned long.
2725 It's more likely to cause problems (due to unsigned overflow)
2726 than to cure them.
2727
2728 * dired.c (Ffile_attributes): Don't use 32-bit hack on 64-bit hosts.
2729
2730 * unexelf.c (unexec): Don't assume BSS addr fits in unsigned.
2731
2732 * xterm.c (handle_one_xevent): Omit unnecessary casts to unsigned.
2733
2734 * keyboard.c (modify_event_symbol): Don't limit alist len to UINT_MAX.
2735
2736 * lisp.h (CHAR_TABLE_SET): Omit now-redundant test.
2737
2738 * lread.c (Fload): Don't compare a possibly-garbage time_t value.
2739
2740 GLYPH_CODE_FACE returns EMACS_INT, not int.
2741 * dispextern.h (merge_faces):
2742 * xfaces.c (merge_faces):
2743 * xdisp.c (get_next_display_element, next_element_from_display_vector):
2744 Don't assume EMACS_INT fits in int.
2745
2746 * character.h (CHAR_VALID_P): Remove unused parameter.
2747 * fontset.c, lisp.h, xdisp.c: All uses changed.
2748
2749 * editfns.c (Ftranslate_region_internal): Omit redundant test.
2750
2751 * fns.c (concat): Minor tuning based on overflow analysis.
2752 This doesn't fix any bugs. Use int to hold character, instead
2753 of constantly refetching from Emacs object. Use XFASTINT, not
2754 XINT, for value known to be a character. Don't bother comparing
2755 a single byte to 0400, as it's always less.
2756
2757 * floatfns.c (Fexpt):
2758 * fileio.c (make_temp_name): Omit unnecessary cast to unsigned.
2759
2760 * editfns.c (Ftranslate_region_internal): Use int, not EMACS_INT
2761 for characters.
2762
2763 * doc.c (get_doc_string): Omit (unsigned)c that mishandled negatives.
2764
2765 * data.c (Faset): If ARRAY is a string, check that NEWELT is a char.
2766 Without this fix, on a 64-bit host (aset S 0 4294967386) would
2767 incorrectly succeed when S was a string, because 4294967386 was
2768 truncated before it was used.
2769
2770 * chartab.c (Fchar_table_range): Use CHARACTERP to check range.
2771 Otherwise, an out-of-range integer could cause undefined behavior
2772 on a 64-bit host.
2773
2774 * composite.c: Use int, not EMACS_INT, for characters.
2775 (fill_gstring_body, composition_compute_stop_pos): Use int, not
2776 EMACS_INT, for values that are known to be in character range.
2777 This doesn't fix any bugs but is the usual style inside Emacs and
2778 may generate better code on 32-bit machines.
2779
2780 Make sure a 64-bit char is never passed to ENCODE_CHAR.
2781 This is for reasons similar to the recent CHAR_STRING fix.
2782 * charset.c (Fencode_char): Check that character arg is actually
2783 a character. Pass an int to ENCODE_CHAR.
2784 * charset.h (ENCODE_CHAR): Verify that the character argument is no
2785 wider than 'int', as a compile-time check to prevent future regressions
2786 in this area.
2787
2788 * character.c (char_string): Remove unnecessary casts.
2789
2790 Make sure a 64-bit char is never passed to CHAR_STRING.
2791 Otherwise, CHAR_STRING would do the wrong thing on a 64-bit platform,
2792 by silently ignoring the top 32 bits, allowing some values
2793 that were far too large to be valid characters.
2794 * character.h: Include <verify.h>.
2795 (CHAR_STRING, CHAR_STRING_ADVANCE): Verify that the character
2796 arguments are no wider than unsigned, as a compile-time check
2797 to prevent future regressions in this area.
2798 * data.c (Faset):
2799 * editfns.c (Fchar_to_string, general_insert_function, Finsert_char)
2800 (Fsubst_char_in_region):
2801 * fns.c (concat):
2802 * xdisp.c (decode_mode_spec_coding):
2803 Adjust to CHAR_STRING's new requirement.
2804 * editfns.c (Finsert_char, Fsubst_char_in_region):
2805 * fns.c (concat): Check that character args are actually
2806 characters. Without this test, these functions did the wrong
2807 thing with wildly out-of-range values on 64-bit hosts.
2808
2809 Remove incorrect casts to 'unsigned' that lose info on 64-bit hosts.
2810 These casts should not be needed on 32-bit hosts, either.
2811 * keyboard.c (read_char):
2812 * lread.c (Fload): Remove casts to unsigned.
2813
2814 * lisp.h (UNSIGNED_CMP): New macro.
2815 This fixes comparison bugs on 64-bit hosts.
2816 (ASCII_CHAR_P): Use it.
2817 * casefiddle.c (casify_object):
2818 * character.h (ASCII_BYTE_P, CHAR_VALID_P)
2819 (SINGLE_BYTE_CHAR_P, CHAR_STRING):
2820 * composite.h (COMPOSITION_ENCODE_RULE_VALID):
2821 * dispextern.h (FACE_FROM_ID):
2822 * keyboard.c (read_char): Use UNSIGNED_CMP.
2823
2824 * xmenu.c (dialog_selection_callback) [!USE_GTK]: Cast to intptr_t,
2825 not to EMACS_INT, to avoid GCC warning.
2826
2827 * xfns.c (x_set_scroll_bar_default_width): Remove unused 'int' locals.
2828
2829 * buffer.h (PTR_BYTE_POS, BUF_PTR_BYTE_POS): Remove harmful cast.
2830 The cast incorrectly truncated 64-bit byte offsets to 32 bits, and
2831 isn't needed on 32-bit machines.
2832
2833 * buffer.c (Fgenerate_new_buffer_name):
2834 Use EMACS_INT for count, not int.
2835 (advance_to_char_boundary): Return EMACS_INT, not int.
2836
2837 * data.c (Qcompiled_function): Now static.
2838
2839 * window.c (window_body_lines): Now static.
2840
2841 * image.c (gif_load): Rename local to avoid shadowing.
2842
2843 * lisp.h (SAFE_ALLOCA_LISP): Check for integer overflow.
2844 (struct Lisp_Save_Value): Use ptrdiff_t, not int, for 'integer' member.
2845 * alloc.c (make_save_value): Integer argument is now of type
2846 ptrdiff_t, not int.
2847 (mark_object): Use ptrdiff_t, not int.
2848 * lisp.h (pD): New macro.
2849 * print.c (print_object): Use it.
2850
2851 * alloc.c: Use EMACS_INT, not int, to count objects.
2852 (total_conses, total_markers, total_symbols, total_vector_size)
2853 (total_free_conses, total_free_markers, total_free_symbols)
2854 (total_free_floats, total_floats, total_free_intervals)
2855 (total_intervals, total_strings, total_free_strings):
2856 Now EMACS_INT, not int. All uses changed.
2857 (Fgarbage_collect): Compute overall total using a double, so that
2858 integer overflow is less likely to be a problem. Check for overflow
2859 when converting back to an integer.
2860 (n_interval_blocks, n_string_blocks, n_float_blocks, n_cons_blocks)
2861 (n_vectors, n_symbol_blocks, n_marker_blocks): Remove.
2862 These were 'int' variables that could overflow on 64-bit hosts;
2863 they were never used, so remove them instead of repairing them.
2864 (nzombies, ngcs, max_live, max_zombies): Now EMACS_INT, not 'int'.
2865 (inhibit_garbage_collection): Set gc_cons_threshold to max value.
2866 Previously, this ceilinged at INT_MAX, but that doesn't work on
2867 64-bit machines.
2868 (allocate_pseudovector): Don't use EMACS_INT when int would do.
2869
2870 * alloc.c (Fmake_bool_vector): Don't assume vector size fits in int.
2871 (allocate_vectorlike): Check for ptrdiff_t overflow.
2872 (mark_vectorlike, mark_char_table, mark_object): Avoid EMACS_UINT
2873 when a (possibly-narrower) signed value would do just as well.
2874 We prefer using signed arithmetic, to avoid comparison confusion.
2875
2876 * alloc.c: Catch some string size overflows that we were missing.
2877 (XMALLOC_OVERRUN_CHECK_SIZE) [!XMALLOC_OVERRUN_CHECK]: Define to 0,
2878 for convenience in STRING_BYTES_MAX.
2879 (STRING_BYTES_MAX): New macro, superseding the old one in lisp.h.
2880 The definition here is exact; the one in lisp.h was approximate.
2881 (allocate_string_data): Check for string overflow. This catches
2882 some instances we weren't catching before. Also, it catches
2883 size_t overflow on (unusual) hosts where SIZE_MAX <= min
2884 (PTRDIFF_MAX, MOST_POSITIVE_FIXNUM), e.g., when size_t is 32 bits
2885 and ptrdiff_t and EMACS_INT are both 64 bits.
2886
2887 * character.c, coding.c, doprnt.c, editfns.c, eval.c:
2888 All uses of STRING_BYTES_MAX replaced by STRING_BYTES_BOUND.
2889 * lisp.h (STRING_BYTES_BOUND): Rename from STRING_BYTES_MAX.
2890
2891 * character.c (string_escape_byte8): Fix nbytes/nchars typo.
2892
2893 * alloc.c (Fmake_string): Check for out-of-range init.
2894
2895 2011-06-15 Stefan Monnier <monnier@iro.umontreal.ca>
2896
2897 * eval.c (Fdefvaralias): Also mark the target as variable-special-p.
2898
2899 2011-06-14 Jan Djärv <jan.h.d@swipnet.se>
2900
2901 * xfns.c (x_set_scroll_bar_default_width): Remove argument to
2902 xg_get_default_scrollbar_width.
2903
2904 * gtkutil.c: Include emacsgtkfixed.h if HAVE_GTK3.
2905 (int_gtk_range_get_value): Move to the scroll bar part of the file.
2906 (style_changed_cb): Call update_theme_scrollbar_width and call
2907 x_set_scroll_bar_default_width and xg_frame_set_char_size for
2908 all frames (Bug#8505).
2909 (xg_create_frame_widgets): Call emacs_fixed_new if HAVE_GTK3 (Bug#8505).
2910 Call gtk_window_set_resizable if HAVE_GTK3.
2911 (x_wm_set_size_hint): Call emacs_fixed_set_min_size with min width
2912 and height if HAVE_GTK3 (Bug#8505).
2913 (scroll_bar_width_for_theme): New variable.
2914 (update_theme_scrollbar_width): New function.
2915 (xg_get_default_scrollbar_width): Move code to
2916 update_theme_scrollbar_width, just return scroll_bar_width_for_theme.
2917 (xg_initialize): Call update_theme_scrollbar_width.
2918
2919 * gtkutil.h (xg_get_default_scrollbar_width): Remove argument.
2920
2921 * emacsgtkfixed.c, emacsgtkfixed.h: New files.
2922
2923 2011-06-12 Martin Rudalics <rudalics@gmx.at>
2924
2925 * frame.c (make_frame): Call other_buffer_safely instead of
2926 other_buffer.
2927
2928 * window.c (temp_output_buffer_show): Call display_buffer with
2929 second argument Vtemp_buffer_show_specifiers and reset latter
2930 immediately after the call.
2931 (Vtemp_buffer_show_specifiers): New variable.
2932 (auto_window_vscroll_p, next_screen_context_lines)
2933 (Vscroll_preserve_screen_position): Remove leading asterisks from
2934 doc-strings.
2935
2936 2011-06-12 Paul Eggert <eggert@cs.ucla.edu>
2937
2938 Fix minor problems found by GCC 4.6.0 static checking.
2939 * buffer.c (Qclone_number): Remove for now, as it's unused.
2940 (record_buffer, Funrecord_buffer): Rename local to avoid shadowing.
2941 (record_buffer): Remove unused local.
2942 * frame.c (other_visible_frames, frame_buffer_list): Now static.
2943 (set_frame_buffer_list): Remove; unused.
2944 * frame.h (other_visible_frames): Remove decl.
2945 * keyboard.h (menu_items_inuse): Declare only if USE_GTK || USE_MOTIF.
2946 * lisp.h (frame_buffer_list, set_frame_buffer_list): Remove decls.
2947 (add_gpm_wait_descriptor, delete_gpm_wait_descriptor): Declare only
2948 if HAVE_GPM.
2949 * menu.c (menu_items_inuse): Now static unless USE_GTK || USE_MOTIF.
2950 * process.c (add_gpm_wait_descriptor, delete_gpm_wait_descriptor):
2951 Define only if HAVE_GPM.
2952 * widget.c (EmacsFrameResize, emacsFrameClassRec): Now static.
2953 (update_hints_inhibit): Remove; never set. All uses removed.
2954 * widgetprv.h (emacsFrameClassRec): Remove decl.
2955 * window.c (delete_deletable_window): Now returns void, since it
2956 wasn't returning anything.
2957 (compare_window_configurations): Remove unused locals.
2958 * xfns.c (x_set_scroll_bar_default_width): Remove unused locals.
2959 * xmenu.c (x_menu_set_in_use): Define only if USE_GTK || USE_MOTIF.
2960 (dialog_selection_callback) [!USE_GTK]: Prefer intptr_t for integers
2961 the same widths as pointers. This follows up on the 2011-05-06 patch.
2962 * xterm.c (x_alloc_lighter_color_for_widget): Define only if USE_LUCID.
2963 * xterm.h: Likewise.
2964 (x_menu_set_in_use): Declare only if USE_GTK || USE_MOTIF.
2965
2966 2011-06-12 Juanma Barranquero <lekktu@gmail.com>
2967
2968 * makefile.w32-in: Update dependencies.
2969 (LISP_H): Add lib/intprops.h.
2970
2971 2011-06-11 Chong Yidong <cyd@stupidchicken.com>
2972
2973 * image.c (gif_load): Add animation frame delay to the metadata.
2974 (syms_of_image): Use DEFSYM. New symbol `delay'.
2975
2976 2011-06-11 Martin Rudalics <rudalics@gmx.at>
2977
2978 * window.c (delete_deletable_window): Re-add.
2979 (Fset_window_configuration): Rewrite to handle dead buffers and
2980 consequently deletable windows.
2981 (window_tree, Fwindow_tree): Remove. Supply functionality in
2982 window.el.
2983 (compare_window_configurations): Simplify code.
2984
2985 2011-06-11 Andreas Schwab <schwab@linux-m68k.org>
2986
2987 * image.c (imagemagick_load_image): Fix type mismatch.
2988 (Fimagemagick_types): Likewise.
2989
2990 * window.h (replace_buffer_in_windows): Declare.
2991
2992 2011-06-11 Martin Rudalics <rudalics@gmx.at>
2993
2994 * buffer.c: New Lisp objects Qbuffer_list_update_hook and
2995 Qclone_number. Remove external declaration of Qdelete_window.
2996 (Fbuffer_list): Rewrite doc-string. Minor restructuring of
2997 code.
2998 (Fget_buffer_create, Fmake_indirect_buffer, Frename_buffer):
2999 Run Qbuffer_list_update_hook if allowed.
3000 (Fother_buffer): Rewrite doc-string. Major rewrite for new
3001 buffer list implementation.
3002 (other_buffer_safely): New function.
3003 (Fkill_buffer): Replace call to replace_buffer_in_all_windows by
3004 calls to replace_buffer_in_windows and
3005 replace_buffer_in_windows_safely. Run Qbuffer_list_update_hook
3006 if allowed.
3007 (record_buffer): Inhibit quitting and rewrite using quittable
3008 functions. Run Qbuffer_list_update_hook if allowed.
3009 (Frecord_buffer, Funrecord_buffer): New functions.
3010 (switch_to_buffer_1, Fswitch_to_buffer): Remove.
3011 Move switch-to-buffer to window.el.
3012 (bury-buffer): Move to window.el.
3013 (Vbuffer_list_update_hook): New variable.
3014
3015 * lisp.h (other_buffer_safely): Add prototype in buffer.c
3016 section.
3017
3018 * window.h (resize_frame_windows): Move up in code.
3019 (Fwindow_frame): Remove EXFUN.
3020 (replace_buffer_in_all_windows): Remove prototype.
3021 (replace_buffer_in_windows_safely): Add prototype.
3022
3023 * window.c: Declare Qdelete_window static again. Move down
3024 declaration of select_count.
3025 (Fnext_window, Fprevious_window): Rewrite doc-strings.
3026 (Fother_window): Move to window.el.
3027 (window_loop): Remove DELETE_BUFFER_WINDOWS and UNSHOW_BUFFER
3028 cases. Add REPLACE_BUFFER_IN_WINDOWS_SAFELY case.
3029 (Fdelete_windows_on, Freplace_buffer_in_windows): Move to
3030 window.el.
3031 (replace_buffer_in_windows): Implement by calling
3032 Qreplace_buffer_in_windows.
3033 (replace_buffer_in_all_windows): Remove with some functionality
3034 moved into replace_buffer_in_windows_safely.
3035 (replace_buffer_in_windows_safely): New function.
3036 (select_window_norecord, select_frame_norecord): Move in front
3037 of run_window_configuration_change_hook. Remove now obsolete
3038 declarations.
3039 (Fset_window_buffer): Rewrite doc-string.
3040 Call Qrecord_window_buffer.
3041 (keys_of_window): Move binding for other-window to window.el.
3042
3043 2011-06-11 Chong Yidong <cyd@stupidchicken.com>
3044
3045 * dispextern.h (struct image): Replace data member, whose int_val
3046 and ptr_val fields were not used by anything, with a single
3047 lisp_val object.
3048
3049 * image.c (Fimage_metadata, make_image, mark_image, tiff_load)
3050 (gif_clear_image, gif_load, imagemagick_load_image)
3051 (gs_clear_image, gs_load): Callers changed.
3052
3053 2011-06-10 Paul Eggert <eggert@cs.ucla.edu>
3054
3055 * buffer.h: Include <time.h>, for time_t.
3056 Needed to build on FreeBSD 8.2. Problem reported by Herbert J. Skuhra.
3057
3058 Fix minor problems found by static checking.
3059
3060 * image.c (PixelGetMagickColor): Declare if ImageMagick headers don't.
3061
3062 Make identifiers static if they are not used in other modules.
3063 * data.c (Qcompiled_function, Qframe, Qvector):
3064 * image.c (QimageMagick, Qsvg):
3065 * minibuf.c (Qmetadata):
3066 * window.c (resize_window_check, resize_root_window): Now static.
3067 * window.h (resize_window_check, resize_root_window): Remove decls.
3068
3069 * window.c (window_deletion_count, delete_deletable_window):
3070 Remove; unused.
3071 (window_body_lines): Now static.
3072 (Fdelete_other_windows_internal): Mark vars as initialized.
3073 Make sure 'resize_failed' is initialized.
3074 (run_window_configuration_change_hook): Rename local to avoid shadowing.
3075 (resize_window_apply): Remove unused local.
3076 * window.h (delete_deletable_window): Remove decl.
3077
3078 * image.c (gif_load, svg_load_image): Rename locals to avoid shadowing.
3079 (imagemagick_load_image): Fix pointer signedness problem by changing
3080 last arg from unsigned char * to char *. All uses changed.
3081 Also, fix a local for similar reasons.
3082 Remove unused locals. Remove locals to avoid shadowing.
3083 (fn_rsvg_handle_free): Remove; unused.
3084 (svg_load, svg_load_image): Fix pointer signedness problem.
3085 (imagemagick_load_image): Don't use garbage pointer image_wand.
3086
3087 * ftfont.c (ftfont_get_metrics, ftfont_drive_otf): Remove unused locals.
3088
3089 2011-06-10 Chong Yidong <cyd@stupidchicken.com>
3090
3091 * image.c (gif_load): Fix omitted cast error introduced by
3092 2011-06-06 change.
3093
3094 2011-06-10 Martin Rudalics <rudalics@gmx.at>
3095
3096 * window.h (resize_proportionally, orig_total_lines)
3097 (orig_top_line): Remove from window structure.
3098 (set_window_height, set_window_width, change_window_heights)
3099 (Fdelete_window): Remove prototypes.
3100 (resize_frame_windows): Remove duplicate declaration.
3101
3102 2011-06-10 Eli Zaretskii <eliz@gnu.org>
3103
3104 * window.h (resize_frame_windows, resize_window_check)
3105 (delete_deletable_window, resize_root_window)
3106 (resize_frame_windows): Declare prototypes.
3107
3108 * window.c (resize_window_apply): Make definition be "static" to
3109 match the prototype.
3110
3111 2011-06-10 Martin Rudalics <rudalics@gmx.at>
3112
3113 * window.c: Remove declarations of Qwindow_size_fixed,
3114 window_min_size_1, window_min_size_2, window_min_size,
3115 size_window, window_fixed_size_p, enlarge_window, delete_window.
3116 Remove static from declaration of Qdelete_window, it's
3117 temporarily needed by Fbury_buffer.
3118 (replace_window): Don't assign orig_top_line and
3119 orig_total_lines.
3120 (Fdelete_window, delete_window): Remove. Window deletion is
3121 handled by window.el.
3122 (window_loop): Remove DELETE_OTHER_WINDOWS case.
3123 Replace Fdelete_window calls with calls to Qdelete_window.
3124 (Fdelete_other_windows): Remove. Deleting other windows is
3125 handled by window.el.
3126 (window_fixed_size_p): Remove. Fixed-sizeness of windows is
3127 handled in window.el.
3128 (window_min_size_2, window_min_size_1, window_min_size): Remove.
3129 Window minimum sizes are handled in window.el.
3130 (shrink_windows, size_window, set_window_height)
3131 (set_window_width, change_window_heights, window_height)
3132 (window_width, CURBEG, CURSIZE, enlarge_window)
3133 (adjust_window_trailing_edge, Fadjust_window_trailing_edge)
3134 (Fenlarge_window, Fshrink_window): Remove. Window resizing is
3135 handled in window.el.
3136 (make_dummy_parent): Rename to make_parent_window and give it a
3137 second argument horflag.
3138 (make_window): Don't set resize_proportionally any more.
3139 (Fsplit_window): Remove. Windows are split in window.el.
3140 (save_restore_action, save_restore_orig_size)
3141 (shrink_window_lowest_first, save_restore_orig_size): Remove.
3142 Resize mini windows in window.el.
3143 (grow_mini_window, shrink_mini_window): Implement by calling
3144 Qresize_root_window_vertically, resize_window_check and
3145 resize_window_apply.
3146 (saved_window, Fset_window_configuration, save_window_save):
3147 Do not handle orig_top_line, orig_total_lines, and
3148 resize_proportionally.
3149 (window_min_height, window_min_width): Move to window.el.
3150 (keys_of_window): Move bindings for delete-other-windows,
3151 split-window, delete-window and enlarge-window to window.el.
3152
3153 * buffer.c: Temporarily extern Qdelete_window.
3154 (Fbury_buffer): Temporarily call Qdelete_window instead of
3155 Fdelete_window (Fbury_buffer will move to window.el soon).
3156
3157 * frame.c (set_menu_bar_lines_1): Remove code handling
3158 orig_top_line and orig_total_lines.
3159
3160 * dispnew.c (adjust_frame_glyphs_initially): Don't use
3161 set_window_height but set heights directly.
3162 (change_frame_size_1): Use resize_frame_windows.
3163
3164 * xdisp.c (init_xdisp): Don't use set_window_height but set
3165 heights directly.
3166
3167 * xfns.c (x_set_menu_bar_lines, x_set_tool_bar_lines):
3168 Use resize_frame_windows instead of change_window_heights and run
3169 run_window_configuration_change_hook.
3170
3171 * w32fns.c (x_set_tool_bar_lines): Use resize_frame_windows
3172 instead of change_window_heights and run
3173 run_window_configuration_change_hook.
3174
3175 2011-06-09 Martin Rudalics <rudalics@gmx.at>
3176
3177 * window.c (replace_window): Rename second argument REPLACEMENT to
3178 NEW. New third argument SETFLAG. Rewrite.
3179 (delete_window, make_dummy_parent): Call replace_window with
3180 third argument 1.
3181 (window_list_1): Move down in code.
3182 (run_window_configuration_change_hook): Move set_buffer part
3183 before select_frame_norecord part in order to unwind correctly.
3184 Rename count1 to count.
3185 (recombine_windows, delete_deletable_window, resize_root_window)
3186 (Fdelete_other_windows_internal)
3187 (Frun_window_configuration_change_hook, make_parent_window)
3188 (resize_window_check, resize_window_apply, Fresize_window_apply)
3189 (resize_frame_windows, Fsplit_window_internal)
3190 (Fdelete_window_internal, Fresize_mini_window_internal):
3191 New functions.
3192 (syms_of_window): New variables Vwindow_splits and Vwindow_nest.
3193
3194 2011-06-08 Martin Rudalics <rudalics@gmx.at>
3195
3196 * window.h (window): Add some new members to window structure -
3197 normal_lines, normal_cols, new_total, new_normal, clone_number,
3198 splits, nest, prev_buffers, next_buffers.
3199 (WINDOW_TOTAL_SIZE): Move here from window.c.
3200 (MIN_SAFE_WINDOW_WIDTH, MIN_SAFE_WINDOW_HEIGHT): Define here.
3201
3202 * window.c (Fwindow_height, Fwindow_width, Fwindow_full_width_p):
3203 Remove.
3204 (make_dummy_parent): Set new members of windows structure.
3205 (make_window): Move down in code. Handle new members of window
3206 structure.
3207 (Fwindow_clone_number, Fwindow_splits, Fset_window_splits)
3208 (Fwindow_nest, Fset_window_nest, Fwindow_new_total)
3209 (Fwindow_normal_size, Fwindow_new_normal, Fwindow_prev_buffers)
3210 (Fset_window_prev_buffers, Fwindow_next_buffers)
3211 (Fset_window_next_buffers, Fset_window_clone_number):
3212 New functions.
3213 (Fwindow_hscroll, Fwindow_at, Fwindow_point, Fwindow_start)
3214 (Fwindow_end, Fwindow_line_height, Fset_window_dedicated_p):
3215 Doc-string fixes.
3216 (Fwindow_parameters, Fwindow_parameter, Fset_window_parameter):
3217 Argument WINDOW can be now internal window too.
3218 (Fwindow_use_time): Move up in code.
3219 (Fget_buffer_window): Rename argument FRAME to ALL-FRAMES.
3220 Rewrite doc-string.
3221 (Fset_window_configuration, saved_window)
3222 (Fcurrent_window_configuration, save_window_save): Handle new
3223 members of window structure.
3224 (WINDOW_TOTAL_SIZE, MIN_SAFE_WINDOW_WIDTH)
3225 (MIN_SAFE_WINDOW_HEIGHT): Move to window.h.
3226 (syms_of_window): New Lisp objects Qrecord_window_buffer,
3227 Qwindow_deletable_p, Qdelete_window, Qreplace_buffer_in_windows,
3228 Qget_mru_window, Qresize_root_window,
3229 Qresize_root_window_vertically, Qsafe, Qabove, Qbelow,
3230 Qauto_buffer_name; staticpro them.
3231
3232 2011-06-07 Martin Rudalics <rudalics@gmx.at>
3233
3234 * window.c (Fwindow_total_size, Fwindow_left_column)
3235 (Fwindow_top_line, window_body_lines, Fwindow_body_size)
3236 (Fwindow_list_1): New functions.
3237 (window_box_text_cols): Replace with window_body_cols.
3238 (Fwindow_width, Fscroll_left, Fscroll_right):
3239 Use window_body_cols instead of window_box_text_cols.
3240 (delete_window, Fset_window_configuration):
3241 Call delete_all_subwindows with window as argument.
3242 (delete_all_subwindows): Take a window as argument and not a
3243 structure. Rewrite.
3244 (window_loop): Remove handling of GET_LRU_WINDOW and
3245 GET_LARGEST_WINDOW.
3246 (Fget_lru_window, Fget_largest_window): Move to window.el.
3247
3248 * window.h: Extern window_body_cols instead of
3249 window_box_text_cols. delete_all_subwindows now takes a
3250 Lisp_Object as argument.
3251
3252 * indent.c (compute_motion, Fcompute_motion):
3253 Use window_body_cols instead of window_box_text_cols.
3254
3255 * frame.c (delete_frame): Call delete_all_subwindows with root
3256 window as argument.
3257
3258 2011-06-07 Daniel Colascione <dan.colascione@gmail.com>
3259
3260 * fns.c (Fputhash): Document return value.
3261
3262 2011-06-06 Chong Yidong <cyd@stupidchicken.com>
3263
3264 * image.c (gif_load): Implement gif89a spec "no disposal" method.
3265
3266 2011-06-06 Paul Eggert <eggert@cs.ucla.edu>
3267
3268 Cons<->int and similar integer overflow fixes (Bug#8794).
3269
3270 Check for overflow when converting integer to cons and back.
3271 * charset.c (Fdefine_charset_internal, Fdecode_char):
3272 Use cons_to_unsigned to catch overflow.
3273 (Fencode_char): Use INTEGER_TO_CONS.
3274 * composite.h (LGLYPH_CODE): Use cons_to_unsigned.
3275 (LGLYPH_SET_CODE): Use INTEGER_TO_CONS.
3276 * data.c (long_to_cons, cons_to_long): Remove.
3277 (cons_to_unsigned, cons_to_signed): New functions.
3278 These signal an error for invalid or out-of-range values.
3279 * dired.c (Ffile_attributes): Use INTEGER_TO_CONS.
3280 * fileio.c (Fset_visited_file_modtime): Use CONS_TO_INTEGER.
3281 * font.c (Ffont_variation_glyphs):
3282 * fontset.c (Finternal_char_font): Use INTEGER_TO_CONS.
3283 * lisp.h: Include <intprops.h>.
3284 (INTEGER_TO_CONS, CONS_TO_INTEGER): New macros.
3285 (cons_to_signed, cons_to_unsigned): New decls.
3286 (long_to_cons, cons_to_long): Remove decls.
3287 * undo.c (record_first_change): Use INTEGER_TO_CONS.
3288 (Fprimitive_undo): Use CONS_TO_INTEGER.
3289 * xfns.c (Fx_window_property): Likewise.
3290 * xselect.c: Include <limits.h>.
3291 (x_own_selection, selection_data_to_lisp_data):
3292 Use INTEGER_TO_CONS.
3293 (x_handle_selection_request, x_handle_selection_clear)
3294 (x_get_foreign_selection, Fx_disown_selection_internal)
3295 (Fx_get_atom_name, x_send_client_event): Use CONS_TO_INTEGER.
3296 (lisp_data_to_selection_data): Use cons_to_unsigned.
3297 (x_fill_property_data): Use cons_to_signed.
3298 Report values out of range.
3299
3300 Check for buffer and string overflow more precisely.
3301 * buffer.h (BUF_BYTES_MAX): New macro.
3302 * lisp.h (STRING_BYTES_MAX): New macro.
3303 * alloc.c (Fmake_string):
3304 * character.c (string_escape_byte8):
3305 * coding.c (coding_alloc_by_realloc):
3306 * doprnt.c (doprnt):
3307 * editfns.c (Fformat):
3308 * eval.c (verror):
3309 Use STRING_BYTES_MAX, not MOST_POSITIVE_FIXNUM,
3310 since they may not be the same number.
3311 * editfns.c (Finsert_char):
3312 * fileio.c (Finsert_file_contents):
3313 Likewise for BUF_BYTES_MAX.
3314
3315 * image.c: Use ptrdiff_t, not int, for sizes.
3316 (slurp_file): Switch from int to ptrdiff_t.
3317 All uses changed.
3318 (slurp_file): Check that file size fits in both size_t (for
3319 malloc) and ptrdiff_t (for sanity and safety).
3320
3321 * fileio.c (Fverify_visited_file_modtime): Avoid time overflow
3322 if b->modtime has its maximal value.
3323
3324 * dired.c (Ffile_attributes): Don't assume EMACS_INT has >32 bits.
3325
3326 Don't assume time_t can fit into int.
3327 * buffer.h (struct buffer.modtime): Now time_t, not int.
3328 * fileio.c (Fvisited_file_modtime): No need for time_t cast now.
3329 * undo.c (Fprimitive_undo): Use time_t, not int, for time_t value.
3330
3331 Minor fixes for signed vs unsigned integers.
3332 * character.h (MAYBE_UNIFY_CHAR):
3333 * charset.c (maybe_unify_char):
3334 * keyboard.c (read_char, reorder_modifiers):
3335 XINT -> XFASTINT, since the integer must be nonnegative.
3336 * ftfont.c (ftfont_spec_pattern):
3337 * keymap.c (access_keymap, silly_event_symbol_error):
3338 XUINT -> XFASTINT, since the integer must be nonnegative.
3339 (Fsingle_key_description, preferred_sequence_p): XUINT -> XINT,
3340 since it makes no difference and we prefer signed.
3341 * keyboard.c (record_char): Use XUINT when all the neighbors do.
3342 (access_keymap): NATNUMP -> INTEGERP, since the integer must be
3343 nonnegative.
3344
3345 2011-06-06 Stefan Monnier <monnier@iro.umontreal.ca>
3346
3347 * window.h (Fwindow_frame): Declare.
3348
3349 2011-06-06 Paul Eggert <eggert@cs.ucla.edu>
3350
3351 * alloc.c: Simplify handling of large-request failures (Bug#8800).
3352 (SPARE_MEMORY): Always define.
3353 (LARGE_REQUEST): Remove.
3354 (memory_full): Use SPARE_MEMORY rather than LARGE_REQUEST.
3355
3356 2011-06-06 Martin Rudalics <rudalics@gmx.at>
3357
3358 * lisp.h: Move EXFUNS for Fframe_root_window,
3359 Fframe_first_window and Fset_frame_selected_window to window.h.
3360
3361 * window.h: Move EXFUNS for Fframe_root_window,
3362 Fframe_first_window and Fset_frame_selected_window here from
3363 lisp.h.
3364
3365 * frame.c (Fwindow_frame, Fframe_first_window)
3366 (Fframe_root_window, Fframe_selected_window)
3367 (Fset_frame_selected_window): Move to window.c.
3368 (Factive_minibuffer_window): Move to minibuf.c.
3369 (Fother_visible_frames_p): New function.
3370
3371 * minibuf.c (Factive_minibuffer_window): Move here from frame.c.
3372
3373 * window.c (decode_window, decode_any_window): Move up in code.
3374 (Fwindowp, Fwindow_live_p): Rewrite doc-strings.
3375 (inhibit_frame_unsplittable): Remove unused variable.
3376 (Fwindow_buffer): Move up and rewrite doc-string.
3377 (Fwindow_parent, Fwindow_vchild, Fwindow_hchild, Fwindow_next)
3378 (Fwindow_prev): New functions.
3379 (Fwindow_frame): Move here from frame.c. Accept any window as
3380 argument.
3381 (Fframe_root_window, Fframe_first_window)
3382 (Fframe_selected_window): Move here from frame.c. Accept frame
3383 or arbitrary window as argument. Update doc-strings.
3384 (Fminibuffer_window): Move up in code.
3385 (Fwindow_minibuffer_p): Move up in code and simplify.
3386 (Fset_frame_selected_window): Move here from frame.c.
3387 Marginal rewrite.
3388 (Fselected_window, select_window, Fselect_window): Move up in
3389 code. Minor doc-string fixes.
3390
3391 2011-06-06 Paul Eggert <eggert@cs.ucla.edu>
3392
3393 * alloc.c (memory_full) [SYSTEM_MALLOC]: Port to MacOS (Bug#8800).
3394 Do not assume that spare memory exists; that assumption is valid
3395 only if SYSTEM_MALLOC.
3396 (LARGE_REQUEST): New macro, so that the issue of large requests
3397 is separated from the issue of spare memory.
3398
3399 2011-06-05 Andreas Schwab <schwab@linux-m68k.org>
3400
3401 * editfns.c (Fformat): Correctly handle zero flag with hexadecimal
3402 format. (Bug#8806)
3403
3404 * gtkutil.c (xg_get_default_scrollbar_width): Avoid warning.
3405
3406 * xfns.c (x_set_scroll_bar_default_width): Move declarations
3407 before statements.
3408
3409 2011-06-05 Jan Djärv <jan.h.d@swipnet.se>
3410
3411 * gtkutil.c (xg_get_default_scrollbar_width): New function.
3412
3413 * gtkutil.h: Declare xg_get_default_scrollbar_width.
3414
3415 * xfns.c (x_set_scroll_bar_default_width): If USE_GTK, get
3416 min width by calling x_set_scroll_bar_default_width (Bug#8505).
3417
3418 2011-06-05 Juanma Barranquero <lekktu@gmail.com>
3419
3420 * xdisp.c (single_display_spec_intangible_p): Remove declaration.
3421
3422 2011-06-04 Chong Yidong <cyd@stupidchicken.com>
3423
3424 * xselect.c (x_clipboard_manager_save): Remove redundant arg.
3425 (x_clipboard_manager_save): Add return value.
3426 (x_clipboard_manager_error_1, x_clipboard_manager_error_2):
3427 New error handlers.
3428 (x_clipboard_manager_save_frame, x_clipboard_manager_save_all):
3429 Obey Vx_select_enable_clipboard_manager. Catch errors in
3430 x_clipboard_manager_save (Bug#8779).
3431 (Vx_select_enable_clipboard_manager): New variable.
3432 (x_get_foreign_selection): Reduce scope of x_catch_errors (Bug#8790).
3433
3434 2011-06-04 Dan Nicolaescu <dann@ics.uci.edu>
3435
3436 * emacs.c (main): Warn when starting a GTK emacs in daemon mode.
3437
3438 2011-06-04 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
3439
3440 * fringe.c (update_window_fringes): Don't update overlay arrow bitmap
3441 in the current matrix if keep_current_p is non-zero.
3442
3443 2011-06-04 Eli Zaretskii <eliz@gnu.org>
3444
3445 * bidi.c (bidi_level_of_next_char): Fix last change.
3446
3447 2011-06-03 Eli Zaretskii <eliz@gnu.org>
3448
3449 Support bidi reordering of text covered by display properties.
3450
3451 * bidi.c (bidi_copy_it): Use offsetof instead of emulating it.
3452 (bidi_fetch_char, bidi_fetch_char_advance): New functions.
3453 (bidi_cache_search, bidi_cache_iterator_state)
3454 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak)
3455 (bidi_level_of_next_char, bidi_move_to_visually_next):
3456 Support character positions inside a run of characters covered by a
3457 display string.
3458 (bidi_paragraph_init, bidi_resolve_explicit_1)
3459 (bidi_level_of_next_char): Call bidi_fetch_char and
3460 bidi_fetch_char_advance instead of FETCH_CHAR and
3461 FETCH_CHAR_ADVANCE.
3462 (bidi_init_it): Initialize new members.
3463 (LRE_CHAR, RLE_CHAR, PDF_CHAR, LRO_CHAR, RLO_CHAR): Remove macro
3464 definitions.
3465 (bidi_explicit_dir_char): Lookup character type in bidi_type_table,
3466 instead of using explicit *_CHAR codes.
3467 (bidi_resolve_explicit, bidi_resolve_weak):
3468 Use FETCH_MULTIBYTE_CHAR instead of FETCH_CHAR, as reordering of
3469 bidirectional text is supported only in multibyte buffers.
3470 (bidi_init_it): Accept additional argument FRAME_WINDOW_P and use
3471 it to initialize the frame_window_p member of struct bidi_it.
3472 (bidi_cache_iterator_state, bidi_resolve_explicit_1)
3473 (bidi_resolve_explicit, bidi_resolve_weak)
3474 (bidi_level_of_next_char, bidi_move_to_visually_next): Abort if
3475 bidi_it->nchars is non-positive.
3476 (bidi_level_of_next_char): Don't try to lookup the cache for the
3477 next/previous character if nothing is cached there yet, or if we
3478 were just reseat()'ed to a new position.
3479
3480 * xdisp.c (set_cursor_from_row): Set start and stop points
3481 according to the row's direction when priming the loop that looks
3482 for the glyph on which to display cursor.
3483 (single_display_spec_intangible_p): Function deleted.
3484 (display_prop_intangible_p): Reimplement to call
3485 handle_display_spec instead of single_display_spec_intangible_p.
3486 Accept 3 additional arguments needed by handle_display_spec.
3487 This fixes incorrect cursor motion across display property with complex
3488 values: lists, `(when COND...)' forms, etc.
3489 (single_display_spec_string_p): Support property values that are
3490 lists with the argument STRING its top-level element.
3491 (display_prop_string_p): Fix the condition for processing a
3492 property that is a list to be consistent with handle_display_spec.
3493 (handle_display_spec): New function, refactored from the
3494 last portion of handle_display_prop.
3495 (compute_display_string_pos): Accept additional argument
3496 FRAME_WINDOW_P. Call handle_display_spec to determine whether the
3497 value of a `display' property is a "replacing spec".
3498 (handle_single_display_spec): Accept 2 additional arguments BUFPOS
3499 and FRAME_WINDOW_P. If IT is NULL, don't set up the iterator from
3500 the display property, but just return a value indicating whether
3501 the display property will replace the characters it covers.
3502 (Fcurrent_bidi_paragraph_direction): Initialize the nchars and
3503 frame_window_p members of struct bidi_it.
3504 (compute_display_string_pos, compute_display_string_end):
3505 New functions.
3506 (push_it): Accept second argument POSITION, where pop_it should
3507 jump to continue iteration.
3508 (reseat_1): Initialize bidi_it.disp_pos.
3509
3510 * keyboard.c (adjust_point_for_property): Adjust the call to
3511 display_prop_intangible_p to its new signature.
3512
3513 * dispextern.h (struct bidi_it): New member frame_window_p.
3514 (bidi_init_it): Update prototypes.
3515 (display_prop_intangible_p): Update prototype.
3516 (compute_display_string_pos, compute_display_string_end):
3517 Declare prototypes.
3518 (struct bidi_it): New members nchars and disp_pos. ch_len is now
3519 EMACS_INT.
3520
3521 2011-06-02 Paul Eggert <eggert@cs.ucla.edu>
3522
3523 Malloc failure behavior now depends on size of allocation.
3524 * alloc.c (buffer_memory_full, memory_full): New arg NBYTES.
3525 * lisp.h: Change signatures accordingly.
3526 * alloc.c, buffer.c, editfns.c, menu.c, minibuf.c, xterm.c:
3527 All callers changed. (Bug#8762)
3528
3529 * gnutls.c: Use Emacs's memory allocators.
3530 Without this change, the gnutls library would invoke malloc etc.
3531 directly, which causes problems on non-SYNC_INPUT hosts, and which
3532 runs afoul of improving memory_full behavior. (Bug#8761)
3533 (fn_gnutls_global_set_mem_functions): New macro or function pointer.
3534 (emacs_gnutls_global_init): Use it to specify xmalloc, xrealloc,
3535 xfree instead of the default malloc, realloc, free.
3536 (Fgnutls_boot): No need to check for memory allocation failure,
3537 since xmalloc does that for us.
3538
3539 Remove arbitrary limit of 2**31 entries in hash tables. (Bug#8771)
3540 * category.c (hash_get_category_set):
3541 * ccl.c (ccl_driver):
3542 * charset.c (Fdefine_charset_internal):
3543 * charset.h (struct charset.hash_index):
3544 * composite.c (get_composition_id, gstring_lookup_cache)
3545 (composition_gstring_put_cache):
3546 * composite.h (struct composition.hash_index):
3547 * dispextern.h (struct image.hash):
3548 * fns.c (next_almost_prime, larger_vector, cmpfn_eql)
3549 (cmpfn_equal, cmpfn_user_defined, hashfn_eq, hashfn_eql)
3550 (hashfn_equal, hashfn_user_defined, make_hash_table)
3551 (maybe_resize_hash_table, hash_lookup, hash_put)
3552 (hash_remove_from_table, hash_clear, sweep_weak_table, SXHASH_COMBINE)
3553 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector)
3554 (Fsxhash, Fgethash, Fputhash, Fmaphash):
3555 * image.c (make_image, search_image_cache, lookup_image)
3556 (xpm_put_color_table_h):
3557 * lisp.h (struct Lisp_Hash_Table):
3558 * minibuf.c (Ftry_completion, Fall_completions, Ftest_completion):
3559 * print.c (print): Use 'EMACS_UINT' and 'EMACS_INT'
3560 for hashes and hash indexes, instead of 'unsigned' and 'int'.
3561 * alloc.c (allocate_vectorlike):
3562 Check for overflow in vector size calculations.
3563 * ccl.c (ccl_driver):
3564 Check for overflow when converting EMACS_INT to int.
3565 * fns.c, image.c: Remove unnecessary static decls that would otherwise
3566 need to be updated by these changes.
3567 * fns.c (make_hash_table, maybe_resize_hash_table):
3568 Check for integer overflow with large hash tables.
3569 (make_hash_table, maybe_resize_hash_table, Fmake_hash_table):
3570 Prefer the faster XFLOAT_DATA to XFLOATINT where either will do.
3571 (SXHASH_REDUCE): New macro.
3572 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector):
3573 Use it instead of discarding useful hash info with large hash values.
3574 (sxhash_float): New function.
3575 (sxhash): Use it. No more need for "& INTMASK" due to above changes.
3576 * lisp.h (FIXNUM_BITS): New macro, useful for SXHASH_REDUCE etc.
3577 (MOST_NEGATIVE_FIXNUM, MOST_POSITIVE_FIXNUM, INTMASK):
3578 Rewrite to use FIXNUM_BITS, as this simplifies things.
3579 (next_almost_prime, larger_vector, sxhash, hash_lookup, hash_put):
3580 Adjust signatures to match updated version of code.
3581 (consing_since_gc): Now EMACS_INT, since a single hash table can
3582 use more than INT_MAX bytes.
3583
3584 2011-06-01 Dan Nicolaescu <dann@ics.uci.edu>
3585
3586 Make it possible to build with GCC-4.6+ -O2 -flto.
3587
3588 * emacs.c (__malloc_initialize_hook): Mark as EXTERNALLY_VISIBLE.
3589
3590 2011-06-01 Stefan Monnier <monnier@iro.umontreal.ca>
3591
3592 * minibuf.c (get_minibuffer, read_minibuf_unwind):
3593 Call minibuffer-inactive-mode.
3594
3595 2011-05-31 Juanma Barranquero <lekktu@gmail.com>
3596
3597 * makefile.w32-in ($(BLD)/data.$(O), $(BLD)/editfns.$(O)):
3598 Update dependencies.
3599
3600 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
3601
3602 * data.c (init_data): Remove code for UTS, this system is not
3603 supported anymore.
3604
3605 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
3606
3607 Don't force ./temacs to start in terminal mode.
3608
3609 * frame.c (make_initial_frame): Initialize faces in all cases, not
3610 only when CANNOT_DUMP is defined.
3611 * dispnew.c (init_display): Remove CANNOT_DUMP condition.
3612
3613 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
3614
3615 * dispnew.c (add_window_display_history): Use const for the string
3616 pointer. Remove declaration, not needed.
3617
3618 2011-05-31 Paul Eggert <eggert@cs.ucla.edu>
3619
3620 Use 'inline', not 'INLINE'.
3621 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00914.html>
3622 * alloc.c, fontset.c (INLINE): Remove.
3623 * alloc.c, bidi.c, charset.c, coding.c, dispnew.c, fns.c, image.c:
3624 * intervals.c, keyboard.c, process.c, syntax.c, textprop.c, w32term.c:
3625 * xdisp.c, xfaces.c, xterm.c: Replace all uses of INLINE with inline.
3626 * gmalloc.c (register_heapinfo): Use inline unconditionally.
3627 * lisp.h (LISP_MAKE_RVALUE): Use inline, not __inline__.
3628
3629 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
3630
3631 Make it possible to run ./temacs.
3632
3633 * callproc.c (set_initial_environment): Remove CANNOT_DUMP code,
3634 syms_of_callproc does the same thing. Remove test for
3635 "initialized", do it in the caller.
3636 * emacs.c (main): Avoid calling set_initial_environment when dumping.
3637
3638 2011-05-31 Stefan Monnier <monnier@iro.umontreal.ca>
3639
3640 * minibuf.c (Finternal_complete_buffer): Return `category' metadata.
3641 (read_minibuf): Use get_minibuffer.
3642 (syms_of_minibuf): Use DEFSYM.
3643 (Qmetadata): New var.
3644 * data.c (Qbuffer): Don't make it static.
3645 (syms_of_data): Use DEFSYM.
3646
3647 2011-05-31 Paul Eggert <eggert@cs.ucla.edu>
3648
3649 * ccl.c (CCL_CODE_RANGE): Allow negative numbers. (Bug#8751)
3650 (CCL_CODE_MIN): New macro.
3651
3652 2011-05-30 Paul Eggert <eggert@cs.ucla.edu>
3653
3654 * alloc.c (lisp_align_malloc): Omit unnecessary val==NULL tests.
3655
3656 * eval.c (Qdebug): Now static.
3657 * lisp.h (Qdebug): Remove decl. This reverts a part of the
3658 2011-04-26T11:26:05Z!dan.colascione@gmail.com that inadvertently undid part of
3659 2011-04-14T06:48:41Z!eggert@cs.ucla.edu.
3660
3661 2011-05-29 Chong Yidong <cyd@stupidchicken.com>
3662
3663 * image.c: Various fixes to ImageMagick code comments.
3664 (Fimagemagick_types): Doc fix.
3665
3666 2011-05-29 Paul Eggert <eggert@cs.ucla.edu>
3667
3668 Minor fixes prompted by GCC 4.6.0 warnings.
3669
3670 * xselect.c (converted_selections, conversion_fail_tag): Now static.
3671
3672 * emacs.c [HAVE_X_WINDOWS]: Include "xterm.h".
3673 (x_clipboard_manager_save_all): Move extern decl to ...
3674 * xterm.h: ... here, so that it can be checked for consistency.
3675
3676 2011-05-29 Chong Yidong <cyd@stupidchicken.com>
3677
3678 * xselect.c (x_clipboard_manager_save_frame)
3679 (x_clipboard_manager_save_all): New functions.
3680 (Fx_clipboard_manager_save): Lisp function deleted.
3681
3682 * emacs.c (Fkill_emacs): Call x_clipboard_manager_save_all.
3683 * frame.c (delete_frame): Call x_clipboard_manager_save_frame.
3684
3685 * xterm.h: Update prototype.
3686
3687 2011-05-28 William Xu <william.xwl@gmail.com>
3688
3689 * nsterm.m (ns_term_shutdown): Synchronize user defaults before
3690 exiting (Bug#8239).
3691
3692 2011-05-28 Jim Meyering <meyering@redhat.com>
3693
3694 Avoid a sign-extension bug in crypto_hash_function.
3695 * fns.c (to_uchar): Define.
3696 (crypto_hash_function): Use it to convert some newly-signed
3697 variables to unsigned, to avoid sign-extension bugs. For example,
3698 without this change, (md5 "truc") would evaluate to
3699 45723a2aff78ff4fff7fff1114760e62 rather than the expected
3700 45723a2af3788c4ff17f8d1114760e62. Reported by Antoine Levitt in
3701 https://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00883.html.
3702
3703 2011-05-27 Paul Eggert <eggert@cs.ucla.edu>
3704
3705 Integer overflow fixes.
3706
3707 * dbusbind.c: Serial number integer overflow fixes.
3708 (CHECK_DBUS_SERIAL_GET_SERIAL): New macro.
3709 (Fdbus_call_method_asynchronously, xd_read_message_1): Use a float
3710 to hold a serial number that is too large for a fixnum.
3711 (Fdbus_method_return_internal, Fdbus_method_error_internal):
3712 Check for serial numbers out of range. Decode any serial number
3713 that was so large that it became a float. (Bug#8722)
3714
3715 * dbusbind.c: Use XFASTINT rather than XUINT, and check for nonneg.
3716 (Fdbus_call_method, Fdbus_call_method_asynchronously):
3717 Use XFASTINT rather than XUINT when numbers are nonnegative.
3718 (xd_append_arg, Fdbus_method_return_internal):
3719 (Fdbus_method_error_internal): Likewise. Also, for unsigned
3720 arguments, check that Lisp number is nonnegative, rather than
3721 silently wrapping negative numbers around. (Bug#8722)
3722 (xd_read_message_1): Don't assume dbus_uint32_t can fit in int.
3723 (Bug#8722)
3724
3725 * data.c (arith_driver, Flsh): Avoid unnecessary casts to EMACS_UINT.
3726
3727 * ccl.c (ccl_driver): Redo slightly to avoid the need for 'unsigned'.
3728
3729 ccl: add integer overflow checks
3730 * ccl.c (CCL_CODE_MAX, GET_CCL_RANGE, GET_CCL_CODE, GET_CCL_INT):
3731 (IN_INT_RANGE): New macros.
3732 (ccl_driver): Use them to check for integer overflow when
3733 decoding a CCL program. Many of the new checks are whether XINT (x)
3734 fits in int; it doesn't always, on 64-bit hosts. The new version
3735 doesn't catch all possible integer overflows, but it's an
3736 improvement. (Bug#8719)
3737
3738 * alloc.c (make_event_array): Use XINT, not XUINT.
3739 There's no need for unsigned here.
3740
3741 * mem-limits.h (EXCEEDS_LISP_PTR) [!USE_LSB_TAG]: EMACS_UINT -> uintptr_t
3742 This follows up to the 2011-05-06 change that substituted uintptr_t
3743 for EMACS_INT. This case wasn't caught back then.
3744
3745 Rework Fformat to avoid integer overflow issues.
3746 * editfns.c: Include <float.h> unconditionally, as it's everywhere
3747 now (part of C89). Include <verify.h>.
3748 (MAX_10_EXP, CONVERTED_BYTE_SIZE): Remove; no longer needed.
3749 (pWIDE, pWIDElen, signed_wide, unsigned_wide): New defns.
3750 (Fformat): Avoid the prepass trying to compute sizes; it was only
3751 approximate and thus did not catch overflow reliably. Instead, walk
3752 through the format just once, formatting and computing sizes as we go,
3753 checking for integer overflow at every step, and allocating a larger
3754 buffer as needed. Keep track separately whether the format is
3755 multibyte. Keep only the most-recently calculated precision, rather
3756 than them all. Record whether each argument has been converted to
3757 string. Use EMACS_INT, not int, for byte and char and arg counts.
3758 Support field widths and precisions larger than INT_MAX. Avoid
3759 sprintf's undefined behavior with conversion specifications such as %#d
3760 and %.0c. Fix bug with strchr succeeding on '\0' when looking for
3761 flags. Fix bug with (format "%c" 256.0). Avoid integer overflow when
3762 formatting out-of-range floating point numbers with int
3763 formats. (Bug#8668)
3764
3765 * lisp.h (FIXNUM_OVERFLOW_P): Work even if arg is a NaN.
3766
3767 * data.c: Avoid integer truncation in expressions involving floats.
3768 * data.c: Include <intprops.h>.
3769 (arith_driver): When there's an integer overflow in an expression
3770 involving floating point, convert the integers to floating point
3771 so that the resulting value does not suffer from catastrophic
3772 integer truncation. For example, on a 64-bit host (* 4
3773 most-negative-fixnum 0.5) should yield about -4.6e+18, not zero.
3774 Do not rely on undefined behavior after integer overflow.
3775
3776 merge count_size_as_multibyte, parse_str_to_multibyte
3777 * character.c, character.h (count_size_as_multibyte):
3778 Rename from parse_str_to_multibyte; all uses changed.
3779 Check for integer overflow.
3780 * insdel.c, lisp.h (count_size_as_multibyte): Remove,
3781 since it's now a duplicate of the other. This is more of
3782 a character than a buffer op, so better that it's in character.c.
3783 * fns.c, print.c: Adjust to above changes.
3784
3785 2011-05-27 Stefan Monnier <monnier@iro.umontreal.ca>
3786
3787 * xselect.c (x_convert_selection): Yet another int/Lisp_Object mixup.
3788
3789 2011-05-27 Paul Eggert <eggert@cs.ucla.edu>
3790
3791 * xselect.c: Fix minor problems prompted by GCC 4.6.0 warnings.
3792 (x_handle_selection_request, frame_for_x_selection): Remove unused vars.
3793 (x_clipboard_manager_save): Now static.
3794 (Fx_clipboard_manager_save): Rename local to avoid shadowing.
3795
3796 * fns.c: Fix minor problems prompted by GCC 4.6.0 warnings.
3797 (crypto_hash_function): Now static.
3798 Fix pointer signedness problems. Avoid unnecessary initializations.
3799
3800 2011-05-27 Chong Yidong <cyd@stupidchicken.com>
3801
3802 * termhooks.h (Vselection_alist): Make it terminal-local.
3803
3804 * terminal.c (create_terminal): Initialize it.
3805
3806 * xselect.c: Support for clipboard managers.
3807 (Vselection_alist): Move to termhooks.h as terminal-local var.
3808 (LOCAL_SELECTION): New macro.
3809 (x_atom_to_symbol): Handle x_display_info_for_display fail case.
3810 (symbol_to_x_atom): Remove gratuitous arg.
3811 (x_handle_selection_request, lisp_data_to_selection_data)
3812 (x_get_foreign_selection, Fx_register_dnd_atom): Callers changed.
3813 (x_own_selection, x_get_local_selection, x_convert_selection):
3814 New arg, specifying work frame. Use terminal-local Vselection_alist.
3815 (some_frame_on_display): Delete unused function.
3816 (Fx_own_selection_internal, Fx_get_selection_internal)
3817 (Fx_disown_selection_internal, Fx_selection_owner_p)
3818 (Fx_selection_exists_p): New optional frame arg.
3819 (frame_for_x_selection, Fx_clipboard_manager_save): New functions.
3820 (x_handle_selection_clear): Don't treat other terminals with the
3821 same keyboard specially. Use the terminal-local Vselection_alist.
3822 (x_clear_frame_selections): Use Frun_hook_with_args.
3823
3824 * xterm.c (x_term_init): Intern ATOM and CLIPBOARD_MANAGER atoms.
3825
3826 * xterm.h: Add support for those atoms.
3827
3828 2011-05-26 Chong Yidong <cyd@stupidchicken.com>
3829
3830 * xselect.c: ICCCM-compliant handling of MULTIPLE targets.
3831 (converted_selections, conversion_fail_tag): New global variables.
3832 (x_selection_request_lisp_error): Free the above.
3833 (x_get_local_selection): Remove unnecessary code.
3834 (x_reply_selection_request): Args changed; handle arbitrary array
3835 of converted selections stored in converted_selections.
3836 Separate the XChangeProperty and SelectionNotify steps.
3837 (x_handle_selection_request): Rewrite to handle MULTIPLE target.
3838 (x_convert_selection): New function.
3839 (x_handle_selection_event): Simplify.
3840 (x_get_foreign_selection): Don't ignore incoming requests while
3841 waiting for an answer; this will fail when we implement
3842 SAVE_TARGETS, and seems unnecessary anyway.
3843 (selection_data_to_lisp_data): Recognize ATOM_PAIR type.
3844 (Vx_sent_selection_functions): Doc fix.
3845
3846 2011-05-26 Leo Liu <sdl.web@gmail.com>
3847
3848 * editfns.c (Ftranspose_regions): Allow empty regions. (Bug#8699)
3849
3850 2011-05-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
3851
3852 * dispextern.h (struct glyph_row): New member fringe_bitmap_periodic_p.
3853
3854 * dispnew.c (shift_glyph_matrix, scrolling_window): Mark scrolled row
3855 for fringe update if it has periodic bitmap.
3856 (row_equal_p): Also compare left_fringe_offset, right_fringe_offset,
3857 and fringe_bitmap_periodic_p.
3858
3859 * fringe.c (get_fringe_bitmap_data): New function.
3860 (draw_fringe_bitmap_1, update_window_fringes): Use it.
3861 (update_window_fringes): Record periodicity of fringe bitmap in glyph
3862 row. Mark glyph row for fringe update if periodicity changed.
3863
3864 * xdisp.c (try_window_reusing_current_matrix): Don't mark scrolled row
3865 for fringe update unless it has periodic bitmap.
3866
3867 2011-05-25 Kenichi Handa <handa@m17n.org>
3868
3869 * xdisp.c (get_next_display_element): Set correct it->face_id for
3870 a static composition.
3871
3872 2011-05-24 Leo Liu <sdl.web@gmail.com>
3873
3874 * deps.mk (fns.o):
3875 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha1.h.
3876
3877 * fns.c (crypto_hash_function, Fsha1): New function.
3878 (Fmd5): Use crypto_hash_function.
3879 (syms_of_fns): Add Ssha1.
3880
3881 2011-05-22 Paul Eggert <eggert@cs.ucla.edu>
3882
3883 * gnutls.c: Remove unused macros.
3884 (fn_gnutls_transport_set_lowat, fn_gnutls_transport_set_pull_function):
3885 (fn_gnutls_transport_set_push_function) [!WINDOWSNT]:
3886 Remove macros that are defined and never used.
3887 Caught by gcc -Wunused-macros (GCC 4.6.0, Fedora 14).
3888
3889 2011-05-22 Chong Yidong <cyd@stupidchicken.com>
3890
3891 * xselect.c (syms_of_xselect): Remove unused symbol SAVE_TARGETS.
3892 (Fx_get_selection_internal): Minor cleanup.
3893 (Fx_own_selection_internal): Rename arguments for consistency with
3894 select.el.
3895
3896 2011-05-22 Paul Eggert <eggert@cs.ucla.edu>
3897
3898 * xselect.c (QSAVE_TARGETS): New static var, to fix build failure.
3899
3900 2011-05-22 Chong Yidong <cyd@stupidchicken.com>
3901
3902 * xselect.c (syms_of_xselect): Include character.h; use DEFSYM.
3903
3904 2011-05-21 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
3905
3906 * dispnew.c (scrolling_window): Don't exclude the case that the
3907 last enabled row in the desired matrix touches the bottom boundary.
3908
3909 2011-05-21 Glenn Morris <rgm@gnu.org>
3910
3911 * Makefile.in ($(etc)/DOC): Make second command line even shorter.
3912 (SOME_MACHINE_OBJECTS): Replace FONT_OBJ by its maximal expansion,
3913 and add some more files.
3914
3915 2011-05-20 Eli Zaretskii <eliz@gnu.org>
3916
3917 * callproc.c (Fcall_process) [MSDOS]: Fix arguments to
3918 report_file_error introduced by the change from 2011-05-07.
3919
3920 2011-05-20 Paul Eggert <eggert@cs.ucla.edu>
3921
3922 * systime.h (Time): Define only if emacs is defined.
3923 This is to allow ../lib-src/profile.c to be compiled on FreeBSD,
3924 where the include path doesn't have X11/X.h by default. See
3925 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00561.html>.
3926
3927 2011-05-20 Kenichi Handa <handa@m17n.org>
3928
3929 * composite.c (find_automatic_composition): Fix previous change.
3930
3931 2011-05-20 Glenn Morris <rgm@gnu.org>
3932
3933 * lisp.mk: New file, split from Makefile.in.
3934 * Makefile.in (lisp): Move to separate file, inserted by @lisp_frag@.
3935 (shortlisp): Remove.
3936 ($(etc)/DOC): Edit lisp.mk rather than using $shortlisp.
3937
3938 2011-05-19 Glenn Morris <rgm@gnu.org>
3939
3940 * Makefile.in (MSDOS_SUPPORT_REAL, MSDOS_SUPPORT, NS_SUPPORT)
3941 (REAL_MOUSE_SUPPORT, GPM_MOUSE_SUPPORT, MOUSE_SUPPORT, TOOLTIP_SUPPORT)
3942 (BASE_WINDOW_SUPPORT, X_WINDOW_SUPPORT, WINDOW_SUPPORT): Remove.
3943 (lisp): Set the order to that of loadup.el.
3944 (shortlisp): Make it a copy of $lisp.
3945 (SOME_MACHINE_LISP): Remove.
3946 ($(etc)/DOC): Depend just on $lisp, not $SOME_MACHINE_LISP too.
3947 Use just $shortlisp, not $SOME_MACHINE_LISP too.
3948
3949 2011-05-18 Kenichi Handa <handa@m17n.org>
3950
3951 * composite.c (CHAR_COMPOSABLE_P): Add more check for efficiency.
3952 (BACKWARD_CHAR): Wrap the arg STOP by parenthesis.
3953 (find_automatic_composition): Mostly rewrite for efficiency.
3954
3955 2011-05-18 Juanma Barranquero <lekktu@gmail.com>
3956
3957 * makefile.w32-in: Update dependencies.
3958
3959 2011-05-18 Christoph Scholtes <cschol2112@googlemail.com>
3960
3961 * menu.c: Include limits.h (fixes the MS-Windows build broken by
3962 2011-06-18T18:49:19Z!cyd@stupidchicken.com).
3963
3964 2011-05-18 Paul Eggert <eggert@cs.ucla.edu>
3965
3966 Fix some integer overflow issues, such as string length overflow.
3967
3968 * insdel.c (count_size_as_multibyte): Check for string overflow.
3969
3970 * character.c (lisp_string_width): Check for string overflow.
3971 Use EMACS_INT, not int, for string indexes and lengths; in
3972 particular, 2nd arg is now EMACS_INT, not int. Do not crash if
3973 the resulting string length overflows an EMACS_INT; instead,
3974 report a string overflow if no precision given. When checking for
3975 precision exhaustion, use a check that cannot possibly have
3976 integer overflow. (Bug#8675)
3977 * character.h (lisp_string_width): Adjust to new signature.
3978
3979 * alloc.c (string_overflow): New function.
3980 (Fmake_string): Use it. This doesn't change behavior, but saves
3981 a few bytes and will simplify future changes.
3982 * character.c (string_escape_byte8): Likewise.
3983 * lisp.h (string_overflow): New decl.
3984
3985 Fixups, following up to the user-interface timestamp change.
3986 * nsterm.m (last_mouse_movement_time, ns_mouse_position): Use Time
3987 for UI timestamps, instead of unsigned long.
3988 * msdos.c (mouse_get_pos): Likewise.
3989 * w32inevt.c (movement_time, w32_console_mouse_position): Likewise.
3990 * w32gui.h (Time): Define by including "systime.h" rather than by
3991 declaring it ourselves. (Bug#8664)
3992
3993 * dispextern.h (struct image): Don't assume time_t <= unsigned long.
3994 * image.c (clear_image_cache): Likewise.
3995
3996 * term.c (term_mouse_position): Don't assume time_t wraparound.
3997
3998 Be more systematic about user-interface timestamps.
3999 Before, the code sometimes used 'Time', sometimes 'unsigned long',
4000 and sometimes 'EMACS_UINT', to represent these timestamps.
4001 This change causes it to use 'Time' uniformly, as that's what X uses.
4002 This makes the code easier to follow, and makes it easier to catch
4003 integer overflow bugs such as Bug#8664.
4004 * frame.c (Fmouse_position, Fmouse_pixel_position):
4005 Use Time, not unsigned long, for user-interface timestamps.
4006 * keyboard.c (last_event_timestamp, kbd_buffer_get_event): Likewise.
4007 (button_down_time, make_lispy_position, make_lispy_movement): Likewise.
4008 * keyboard.h (last_event_timestamp): Likewise.
4009 * menu.c (Fx_popup_menu) [!HAVE_X_WINDOWS]: Likewise.
4010 * menu.h (xmenu_show): Likewise.
4011 * term.c (term_mouse_position): Likewise.
4012 * termhooks.h (struct input_event.timestamp): Likewise.
4013 (struct terminal.mouse_position_hook): Likewise.
4014 * xmenu.c (create_and_show_popup_menu, xmenu_show): Likewise.
4015 * xterm.c (XTmouse_position, x_scroll_bar_report_motion): Likewise.
4016 * systime.h (Time): New decl. Pull it in from <X11/X.h> if
4017 HAVE_X_WINDOWS, otherwise define it as unsigned long, which is
4018 what it was before.
4019 * menu.h, termhooks.h: Include "systime.h", for Time.
4020
4021 * keyboard.c (make_lispy_event): Fix problem in integer overflow.
4022 Don't assume that the difference between two unsigned long values
4023 can fit into an integer. At this point, we know button_down_time
4024 <= event->timestamp, so the difference must be nonnegative, so
4025 there's no need to cast the result if double-click-time is
4026 nonnegative, as it should be; check that it's nonnegative, just in
4027 case. This bug is triggered when events are more than 2**31 ms
4028 apart (about 25 days). (Bug#8664)
4029
4030 * xselect.c (last_event_timestamp): Remove duplicate decl.
4031 (x_own_selection): Remove needless cast to unsigned long.
4032
4033 * xmenu.c (set_frame_menubar): Use int, not EMACS_UINT, for indexes
4034 that always fit in int. Use a sentinel instead of a counter, to
4035 avoid a temp and to allay GCC's concerns about possible int overflow.
4036 * frame.h (struct frame): Use int for menu_bar_items_used
4037 instead of EMACS_INT, since it always fits in int.
4038
4039 * menu.c (grow_menu_items): Check for int overflow.
4040
4041 * xmenu.c (set_frame_menubar): Don't mishandle vectors with no nils.
4042
4043 * xterm.c: Use EMACS_INT for Emacs modifiers, and int for X modifiers.
4044 Before, the code was not consistent. These values cannot exceed
4045 2**31 - 1 so there's no need to make them unsigned.
4046 (x_x_to_emacs_modifiers): Accept int and return EMACS_INT.
4047 (x_emacs_to_x_modifiers): Accept EMACS_INT and return int.
4048 (x_x_to_emacs_modifiers, x_emacs_to_x_modifiers): Reject non-integers
4049 as modifiers.
4050 * xterm.h (x_x_to_emacs_modifiers): Adjust to signature change.
4051
4052 * lisp.h (XINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_INT.
4053 (XUINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_UINT.
4054 Otherwise, GCC 4.6.0 warns about printf (pI, XINT (...)),
4055 presumably because the widths might not match.
4056
4057 * window.c (size_window): Avoid needless test at loop start.
4058
4059 2011-05-18 Courtney Bane <emacs-bugs-7626@cbane.org> (tiny change)
4060
4061 * term.c (Fresume_tty): Restore hooks before reinitializing (bug#8687).
4062
4063 2011-05-12 Drew Adams <drew.adams@oracle.com>
4064
4065 * textprop.c (Fprevious_single_char_property_change): Doc fix (bug#8655).
4066
4067 2011-05-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
4068
4069 * w32term.c (w32_draw_fringe_bitmap): Rename local vars `left' and
4070 `width' to `bar_area_x' and `bar_area_width', respectively.
4071 (x_scroll_run): Take account of fringe background extension.
4072
4073 * xterm.c (x_draw_fringe_bitmap) [USE_TOOLKIT_SCROLL_BARS]:
4074 Rename local vars `left' and `width' to `bar_area_x' and
4075 `bar_area_width', respectively.
4076 (x_scroll_run) [USE_TOOLKIT_SCROLL_BARS]: Take account of fringe
4077 background extension.
4078
4079 2011-05-10 Jim Meyering <meyering@redhat.com>
4080
4081 * xdisp.c (x_intersect_rectangles): Fix typo "the the -> the".
4082
4083 2011-05-10 Juanma Barranquero <lekktu@gmail.com>
4084
4085 * image.c (Finit_image_library): Return t for built-in image types,
4086 like pbm and xbm. (Bug#8640)
4087
4088 2011-05-09 Andreas Schwab <schwab@linux-m68k.org>
4089
4090 * w32menu.c (set_frame_menubar): Fix submenu allocation.
4091
4092 2011-05-07 Eli Zaretskii <eliz@gnu.org>
4093
4094 * w32console.c (Fset_screen_color): Doc fix.
4095 (Fget_screen_color): New function.
4096 (syms_of_ntterm): Defsubr it.
4097
4098 * callproc.c (call_process_cleanup) [MSDOS]: Don't close and
4099 unlink the temporary file if Fcall_process didn't create it in the
4100 first place.
4101 (Fcall_process) [MSDOS]: Don't create tempfile if stdout of the
4102 child process will be redirected to a file specified with `:file'.
4103 Don't try to re-open tempfile in that case, and set fd[0] to -1 as
4104 cue to call_process_cleanup not to close that handle.
4105
4106 2011-05-07 Ben Key <bkey76@gmail.com>
4107
4108 * makefile.w32-in: The bootstrap-temacs rule now makes use of
4109 one of two shell specific rules, either bootstrap-temacs-CMD or
4110 bootstrap-temacs-SH. The bootstrap-temacs-SH rule is identical
4111 to the previous implementation of the bootstrap-temacs rule.
4112 The bootstrap-temacs-CMD rule is similar to the previous
4113 implementation of the bootstrap-temacs rule except that it
4114 makes use of the ESC_CFLAGS variable instead of the CFLAGS
4115 variable.
4116
4117 These changes, along with some changes to nt/configure.bat,
4118 nt/gmake.defs, and nt/nmake.defs, are required to extend my
4119 earlier fix to add support for --cflags and --ldflags options
4120 that include quotes so that it works whether make uses cmd or
4121 sh as the shell.
4122
4123 2011-05-06 Michael Albinus <michael.albinus@gmx.de>
4124
4125 * dbusbind.c (QCdbus_type_unix_fd): Declare static.
4126 (xd_remove_watch): Don't check QCdbus_type_unix_fd for SYMBOLP, it
4127 is a constant.
4128 (Fdbus_init_bus, xd_read_queued_messages): Bus can be a symbol or
4129 a string. Handle both cases.
4130 (Fdbus_call_method_asynchronously, Fdbus_register_signal)
4131 (Fdbus_register_method): Use Qinvalid_function.
4132
4133 2011-05-06 Juanma Barranquero <lekktu@gmail.com>
4134
4135 * makefile.w32-in: Update dependencies.
4136 (LISP_H): Add inttypes.h and stdin.h.
4137 (PROCESS_H): Add unistd.h.
4138
4139 2011-05-06 Eli Zaretskii <eliz@gnu.org>
4140
4141 * lread.c: Include limits.h (fixes the MS-Windows build broken by
4142 2011-05-06T07:13:19Z!eggert@cs.ucla.edu).
4143
4144 2011-05-06 Paul Eggert <eggert@cs.ucla.edu>
4145
4146 * image.c (Finit_image_library) [!HAVE_NTGUI]: Omit unused local.
4147
4148 * term.c (vfatal): Remove stray call to va_end.
4149 It's not needed and the C Standard doesn't allow it here anyway.
4150
4151 Use C99's va_copy to avoid undefined behavior on x86-64 GNU/Linux.
4152 * eval.c (verror): doprnt a copy of ap, not the original. (Bug#8545)
4153
4154 * eval.c (verror): OK to create a string of up to MOST_POSITIVE_FIXNUM
4155 bytes.
4156
4157 * term.c: Don't include <stdarg.h>, as <lisp.h> does that.
4158
4159 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
4160
4161 * process.c (Fformat_network_address): Fix typo: args2 -> *args2.
4162
4163 * xmenu.c (set_frame_menubar): Fix typo: int * -> int (3 times).
4164
4165 * coding.c (detect_coding_charset): Fix typo: * 2 -> *4 (Bug#8601).
4166
4167 * charset.h (struct charset.code_space): Now has 15 elements, not 16.
4168 * charset.c (Fdefine_charset_internal): Don't initialize
4169 charset.code_space[15]. The value was garbage, on hosts with
4170 32-bit int (Bug#8600).
4171
4172 * lread.c (read_integer): Be more consistent with string-to-number.
4173 Use string_to_number to do the actual conversion; this avoids
4174 rounding errors and fixes some other screwups. Without this fix,
4175 for example, #x1fffffffffffffff was misread as -2305843009213693952.
4176 (digit_to_number): Move earlier, for benefit of read_integer.
4177 Return -1 if the digit is out of range for the base, -2 if it is
4178 not a digit in any supported base. (Bug#8602)
4179
4180 * doprnt.c (doprnt): Support arbitrary pI values, such as "I64".
4181
4182 * dispnew.c (scrolling_window): Return 1 if we scrolled,
4183 to match comment at start of function. This also removes a
4184 GCC warning about overflow in a 32+64-bit port.
4185
4186 * lisp.h (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Simplify.
4187
4188 * dbusbind.c: Do not use XPNTR on a value that may be an integer.
4189 Reported by Stefan Monnier in
4190 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00919.html>.
4191 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
4192 Use SYMBOLP-guarded XSYMBOL, not XPNTR.
4193
4194 * lisp.h (EMACS_INTPTR): Remove. All uses changed to intptr_t.
4195 (EMACS_UINTPTR): Likewise, with uintptr_t.
4196
4197 * lisp.h: Prefer 64-bit EMACS_INT if available.
4198 (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Define to 64-bit
4199 on 32-bit hosts that have 64-bit int, so that they can access
4200 large files.
4201 However, temporarily disable this change unless the temporary
4202 symbol WIDE_EMACS_INT is defined.
4203
4204 * lread.c, process.c: Do not include <inttypes.h>; lisp.h does it now.
4205
4206 Prefer intptr_t/uintptr_t for integers the same widths as pointers.
4207 This removes an assumption that EMACS_INT and long are the same
4208 width as pointers. The assumption is true for Emacs porting targets
4209 now, but we want to make other targets possible.
4210 * lisp.h: Include <inttypes.h>, for INTPTR_MAX, UINTPTR_MAX.
4211 (EMACS_INTPTR, EMACS_UINTPTR): New macros.
4212 In the rest of the code, change types of integers that hold casted
4213 pointers to EMACS_INTPTR and EMACS_UINTPTR, systematically
4214 replacing EMACS_INT, long, EMACS_UINT, and unsigned long.
4215 (XTYPE): Don't cast arg to EMACS_UINT; normally is not needed.
4216 (XSET): Cast type of XTYPE arg to EMACS_INTPTR; it is needed here.
4217 No need to cast type when ORing.
4218 (XPNTR): Return a value of type EMACS_INTPTR or EMACS_UINTPTR.
4219 * alloc.c (lisp_align_malloc): Remove a no-longer-needed cast.
4220 * doc.c (store_function_docstring): Use EMACS_INTPTR, so as not to
4221 assume EMACS_INT is the same width as char *.
4222 * gtkutil.c (xg_gtk_scroll_destroy, xg_tool_bar_button_cb):
4223 (xg_tool_bar_callback, xg_tool_bar_help_callback, xg_make_tool_item):
4224 Remove no-longer-needed casts.
4225 (xg_create_scroll_bar, xg_tool_bar_button_cb, xg_tool_bar_callback):
4226 (xg_tool_bar_help_callback, xg_make_tool_item):
4227 Use EMACS_INTPTR to hold an integer
4228 that will be cast to void *; this can avoid a GCC warning
4229 if EMACS_INT is not the same width as void *.
4230 * menu.c (find_and_call_menu_selection): Remove no-longer-needed cast.
4231 * xdisp.c (display_echo_area_1, resize_mini_window_1):
4232 (current_message_1, set_message_1):
4233 Use a local to convert to proper width without a cast.
4234 * xmenu.c (dialog_selection_callback): Likewise.
4235
4236 * sysdep.c (get_random): Don't assume EMACS_INT is no wider than long.
4237 Also, don't assume VALBITS / RAND_BITS is less than 5,
4238 and don't rely on undefined behavior when shifting a 1 left into
4239 the sign bit.
4240 * lisp.h (get_random): Change signature to match.
4241
4242 * lread.c (hash_string): Use size_t, not int, for hash computation.
4243 Normally we prefer signed values; but hashing is special, because
4244 it's better to use unsigned division on hash table sizes so that
4245 the remainder is nonnegative. Also, size_t is the natural width
4246 for hashing into memory. The previous code used 'int', which doesn't
4247 retain enough info to hash well into very large tables.
4248 (oblookup, oblookup_last_bucket_number, Funintern): Likewise.
4249
4250 * dbusbind.c: Don't possibly lose pointer info when converting.
4251 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
4252 Use XPNTR rather than XHASH, so that the high-order bits of
4253 the pointer aren't lost when converting through void *.
4254
4255 * eval.c (Fautoload): Don't double-shift a pointer.
4256
4257 * fns.c (Frandom): Let EMACS_UINT be wider than unsigned long.
4258
4259 2011-05-06 Juanma Barranquero <lekktu@gmail.com>
4260
4261 * gnutls.c (DEF_GNUTLS_FN):
4262 * image.c (DEF_IMGLIB_FN): Make function pointers static.
4263
4264 2011-05-05 Andreas Schwab <schwab@linux-m68k.org>
4265
4266 * lread.c (lisp_file_lexically_bound_p): Stop scanning at end
4267 marker. (Bug#8610)
4268
4269 2011-05-05 Eli Zaretskii <eliz@gnu.org>
4270
4271 * w32heap.c (allocate_heap) [USE_LISP_UNION_TYPE || USE_LSB_TAG]:
4272 New version that can reserve upto 2GB of heap space.
4273
4274 2011-05-05 Chong Yidong <cyd@stupidchicken.com>
4275
4276 * nsfns.m (Fns_read_file_name): Doc fix (Bug#8534).
4277
4278 2011-05-05 Teodor Zlatanov <tzz@lifelogs.com>
4279
4280 * gnutls.c (fn_gnutls_certificate_set_x509_key_file): Add alias to
4281 `gnutls_certificate_set_x509_key_file'.
4282
4283 2011-05-05 Juanma Barranquero <lekktu@gmail.com>
4284
4285 * makefile.w32-in ($(BLD)/image.$(O), $(BLD)/process.$(O)):
4286 Update dependencies.
4287
4288 2011-05-04 Juanma Barranquero <lekktu@gmail.com>
4289
4290 * gnutls.h (emacs_gnutls_write, emacs_gnutls_read):
4291 * gnutls.c (emacs_gnutls_write, emacs_gnutls_read):
4292 Remove unused parameter `fildes'.
4293 * process.c (read_process_output, send_process): Don't pass it.
4294
4295 2011-05-04 Juanma Barranquero <lekktu@gmail.com>
4296
4297 Fix previous change: the library cache is defined in w32.c.
4298 * image.c (CACHE_IMAGE_TYPE) [!HAVE_NTGUI]: Define to noop.
4299 (Finit_image_library): Wrap Vlibrary_cache on "#ifdef HAVE_NTGUI".
4300
4301 2011-05-04 Juanma Barranquero <lekktu@gmail.com>
4302
4303 Implement dynamic loading of GnuTLS on Windows.
4304
4305 * gnutls.h (GNUTLS_EMACS_ERROR_NOT_LOADED): New macro.
4306 (emacs_gnutls_write, emacs_gnutls_read): Mark as extern.
4307 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
4308 Declare.
4309
4310 * gnutls.c (Qgnutls_dll): Define.
4311 (DEF_GNUTLS_FN, LOAD_GNUTLS_FN): New macros.
4312 (gnutls_*): Declare function pointers.
4313 (init_gnutls_functions): New function to initialize function pointers.
4314 (emacs_gnutls_handshake, Fgnutls_error_string, Fgnutls_deinit)
4315 (emacs_gnutls_global_init, Fgnutls_bye): Use function pointers.
4316 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
4317 Wrappers for gnutls_record_check_pending and gnutls_transport_set_errno.
4318 (emacs_gnutls_write, emacs_gnutls_read)
4319 (emacs_gnutls_handle_error, Fgnutls_error_fatalp)
4320 (Fgnutls_available_p): New function.
4321 (Fgnutls_boot): Call Fgnutls_available_p. Use function pointers.
4322 (syms_of_gnutls) <Qgnutls_dll>: Initialize and staticpro it.
4323 (syms_of_gnutls) <Sgnutls_available_p>: defsubr it.
4324
4325 * image.c: Include w32.h.
4326 (Vimage_type_cache): Delete.
4327 (syms_of_image) <Vimage_type_cache>: Don't initialize and staticpro it.
4328 (CACHE_IMAGE_TYPE, Finit_image_library): Use Vlibrary_cache instead.
4329 (w32_delayed_load): Move to w32.c.
4330
4331 * w32.h (VlibraryCache, QCloaded_from, w32_delayed_load): Declare.
4332
4333 * w32.c (QCloaded_from, Vlibrary_cache): Define.
4334 (w32_delayed_load): Move from image.c. When loading a library, record
4335 its filename in the :loaded-from property of the library id.
4336 (globals_of_w32) <QCloaded_from, Vlibrary_cache>:
4337 Initialize and staticpro them.
4338 (emacs_gnutls_pull, emacs_gnutls_push): Call emacs_gnutls_* functions.
4339
4340 * process.c: Include lisp.h before w32.h, not after.
4341 (wait_reading_process_output): Call emacs_gnutls_record_check_pending
4342 instead of gnutls_record_check_pending.
4343
4344 * callproc.c, emacs.c: Include lisp.h before w32.h, not after.
4345
4346 2011-05-04 Teodor Zlatanov <tzz@lifelogs.com>
4347
4348 * gnutls.c (Fgnutls_boot): Support :keylist and :crlfiles options
4349 instead of :keyfiles. Give GnuTLS the keylist and the CRL lists
4350 as passed in.
4351
4352 2011-05-03 Jan Djärv <jan.h.d@swipnet.se>
4353
4354 * xterm.c (x_set_frame_alpha): Do not set property on anything
4355 else than FRAME_X_OUTER_WINDOW (Bug#8608).
4356
4357 2011-05-02 Juanma Barranquero <lekktu@gmail.com>
4358
4359 * sysdep.c (get_tty_size) [WINDOWSNT]: Implement. (Bug#8596)
4360
4361 2011-05-02 Juanma Barranquero <lekktu@gmail.com>
4362
4363 * gnutls.c (Qgnutls_log_level, Qgnutls_code, Qgnutls_anon)
4364 (Qgnutls_x509pki, Qgnutls_e_interrupted, Qgnutls_e_again)
4365 (Qgnutls_e_invalid_session, Qgnutls_e_not_ready_for_handshake)
4366 (gnutls_global_initialized, Qgnutls_bootprop_priority)
4367 (Qgnutls_bootprop_trustfiles, Qgnutls_bootprop_keyfiles)
4368 (Qgnutls_bootprop_callbacks, Qgnutls_bootprop_loglevel)
4369 (Qgnutls_bootprop_hostname, Qgnutls_bootprop_verify_flags)
4370 (Qgnutls_bootprop_verify_error, Qgnutls_bootprop_verify_hostname_error)
4371 (Qgnutls_bootprop_callbacks_verify): Make static.
4372
4373 2011-05-01 Andreas Schwab <schwab@linux-m68k.org>
4374
4375 * callproc.c: Indentation fixup.
4376
4377 * sysdep.c (wait_for_termination_1): Make static.
4378 (wait_for_termination, interruptible_wait_for_termination):
4379 Move after wait_for_termination_1.
4380
4381 2011-05-01 Lars Magne Ingebrigtsen <larsi@gnus.org>
4382
4383 * sysdep.c (interruptible_wait_for_termination): New function
4384 which is like wait_for_termination, but allows keyboard
4385 interruptions.
4386
4387 * callproc.c (Fcall_process): Add (:file "file") as an option for
4388 the STDOUT buffer.
4389 (Fcall_process_region): Ditto.
4390
4391 2011-04-30 Eli Zaretskii <eliz@gnu.org>
4392
4393 * dosfns.c (Fint86, Fdos_memget, Fdos_memput): Use `ASIZE (FOO)'
4394 rather than `XVECTOR (FOO)->size'.
4395
4396 * process.c: Remove HAVE_INTTYPES_H condition from inclusion of
4397 inttypes.h, as a gnulib replacement is used if it not available in
4398 system headers.
4399
4400 2011-04-21 Eli Zaretskii <eliz@gnu.org>
4401
4402 Lift the MOST_POSITIVE_FIXNUM/4 limitation on visited files.
4403 * fileio.c (Finsert_file_contents): Don't limit file size to 1/4
4404 of MOST_POSITIVE_FIXNUM. (Bug#8528)
4405
4406 * coding.c (coding_alloc_by_realloc): Error out if destination
4407 will grow beyond MOST_POSITIVE_FIXNUM.
4408 (decode_coding_emacs_mule): Abort if there isn't enough place in
4409 charbuf for the composition carryover bytes. Reserve an extra
4410 space for up to 2 characters produced in a loop.
4411 (decode_coding_iso_2022): Abort if there isn't enough place in
4412 charbuf for the composition carryover bytes.
4413
4414 2011-04-21 Eli Zaretskii <eliz@gnu.org>
4415
4416 * doprnt.c (doprnt) [!HAVE_LONG_LONG_INT]: Error out instead of
4417 aborting when %lld or %lll format is passed.
4418 [!HAVE_UNSIGNED_LONG_LONG_INT]: Error out instead of aborting when
4419 %llo or %llx format is passed. (Bug#8545)
4420
4421 * window.c (window_scroll_line_based): Use a marker instead of
4422 simple variables to record original value of point. (Bug#7952)
4423
4424 * doprnt.c (doprnt): Fix the case where a multibyte sequence
4425 produced by %s or %c overflows available buffer space. (Bug#8545)
4426
4427 2011-04-28 Paul Eggert <eggert@cs.ucla.edu>
4428
4429 * doprnt.c (doprnt): Omit useless test; int overflow check (Bug#8545).
4430 (SIZE_MAX): Move defn after all includes, as they might #define it.
4431
4432 2011-04-28 Juanma Barranquero <lekktu@gmail.com>
4433
4434 * w32.c (init_environment): Warn about defaulting HOME to C:\.
4435
4436 2011-04-28 Juanma Barranquero <lekktu@gmail.com>
4437
4438 * keyboard.c (Qdelayed_warnings_hook): Define.
4439 (command_loop_1): Run `delayed-warnings-hook'
4440 if Vdelayed_warnings_list is non-nil.
4441 (syms_of_keyboard) <delayed-warnings-hook>: DEFSYM it.
4442 (syms_of_keyboard) <delayed-warnings-list>: DEFVAR_LISP it.
4443
4444 2011-04-28 Eli Zaretskii <eliz@gnu.org>
4445
4446 * doprnt.c (doprnt): Don't return value smaller than the buffer
4447 size if the message was truncated. (Bug#8545).
4448
4449 2011-04-28 Juanma Barranquero <lekktu@gmail.com>
4450
4451 * w32fns.c (Fx_change_window_property, Fx_delete_window_property)
4452 (Fx_window_property): #if-0 the whole functions, not just the bodies.
4453
4454 2011-04-27 Paul Eggert <eggert@cs.ucla.edu>
4455
4456 * doprnt.c (doprnt): Support "ll" length modifier, for long long.
4457
4458 2011-04-27 Juanma Barranquero <lekktu@gmail.com>
4459
4460 * makefile.w32-in: Update dependencies.
4461
4462 2011-04-27 Eli Zaretskii <eliz@gnu.org>
4463
4464 Improve `doprnt' and its usage. (Bug#8545)
4465 * doprnt.c (doprnt): Make sure `format' is never accessed beyond
4466 `format_end'. Remove support for %l as a conversion specifier.
4467 Don't use xrealloc. Improve diagnostics when the %l size modifier
4468 is used. Update the commentary.
4469
4470 * eval.c (verror): Simplify calculation of size_t.
4471
4472 * coding.c (Ffind_operation_coding_system): Fix diagnostic error
4473 messages.
4474
4475 2011-04-27 Yoshiaki Kasahara <kasahara@nc.kyushu-u.ac.jp> (tiny change)
4476
4477 * buffer.c (init_buffer) [USE_MMAP_FOR_BUFFERS]: Adjust to aliasing
4478 change.
4479
4480 2011-04-27 Paul Eggert <eggert@cs.ucla.edu>
4481
4482 * nsmenu.m: Replace all uses of XVECTOR with ASIZE and AREF.
4483 This makes this file independent of the recent pseudovector change.
4484
4485 2011-04-26 Paul Eggert <eggert@cs.ucla.edu>
4486
4487 * keyboard.c (handle_user_signal): Fix pointer signedness problem.
4488
4489 * gnutls.c (emacs_gnutls_handle_error): Remove unused local.
4490 (Fgnutls_boot): gnutls_certificate_verify_peers2 wants unsigned *.
4491 Remove unused local.
4492 (emacs_gnutls_write): Don't use uninitialized rtnval if nbyte <= 0.
4493
4494 * lisp.h: Fix a problem with aliasing and vector headers. (Bug#8546)
4495 GCC 4.6.0 optimizes based on type-based alias analysis.
4496 For example, if b is of type struct buffer * and v of type struct
4497 Lisp_Vector *, then gcc -O2 was incorrectly assuming that &b->size
4498 != &v->size, and therefore "v->size = 1; b->size = 2; return
4499 v->size;" must therefore return 1. This assumption is incorrect
4500 for Emacs, since it type-puns struct Lisp_Vector * with many other
4501 types. To fix this problem, this patch adds a new type struct
4502 vectorlike_header that documents the constraints on layout of vectors
4503 and pseudovectors, and helps optimizing compilers not get fooled
4504 by Emacs's type punning. It also adds the macros XSETTYPED_PVECTYPE
4505 XSETTYPED_PSEUDOVECTOR, TYPED_PSEUDOVECTORP, for similar reasons.
4506 * lisp.h (XSETTYPED_PVECTYPE): New macro, specifying the name of
4507 the size member.
4508 (XSETPVECTYPE): Rewrite in terms of new macro.
4509 (XSETPVECTYPESIZE): New macro, specifying both type and size.
4510 This is a bit clearer, and further avoids the possibility of
4511 undesirable aliasing.
4512 (XSETTYPED_PSEUDOVECTOR): New macro, specifying the size.
4513 (XSETPSEUDOVECTOR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR.
4514 (XSETSUBR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR and XSIZE,
4515 since Lisp_Subr is a special case (no "next" field).
4516 (ASIZE): Now uses header.size rather than size.
4517 All previous uses of XVECTOR (foo)->size replaced to use this macro,
4518 to avoid the hassle of writing XVECTOR (foo)->header.size.
4519 (struct vectorlike_header): New type.
4520 (TYPED_PSEUDOVECTORP): New macro, also specifying the C type of the
4521 object, to help avoid aliasing.
4522 (PSEUDOVECTORP): Rewrite in terms of TYPED_PSEUDOVECTORP.
4523 (SUBRP): Likewise, since Lisp_Subr is a special case.
4524 * lisp.h (struct Lisp_Vector, struct Lisp_Char_Table):
4525 (struct Lisp_Sub_Char_Table, struct Lisp_Bool_Vector):
4526 (struct Lisp_Hash_Table): Combine first two members into a single
4527 struct vectorlike_header member. All uses of "size" and "next" members
4528 changed to be "header.size" and "header.next".
4529 * buffer.h (struct buffer): Likewise.
4530 * font.h (struct font_spec, struct font_entity, struct font): Likewise.
4531 * frame.h (struct frame): Likewise.
4532 * process.h (struct Lisp_Process): Likewise.
4533 * termhooks.h (struct terminal): Likewise.
4534 * window.c (struct save_window_data, struct saved_window): Likewise.
4535 * window.h (struct window): Likewise.
4536 * alloc.c (allocate_buffer, Fmake_bool_vector, allocate_pseudovector):
4537 Use XSETPVECTYPESIZE, not XSETPVECTYPE, to avoid aliasing problems.
4538 * buffer.c (init_buffer_once): Likewise.
4539 * lread.c (defsubr): Use XSETTYPED_PVECTYPE, since Lisp_Subr is a
4540 special case.
4541 * process.c (Fformat_network_address): Use local var for size,
4542 for brevity.
4543
4544 * bytecode.c (exec_byte_code): Don't use XVECTOR before CHECK_VECTOR.
4545
4546 Make the Lisp reader and string-to-float more consistent (Bug#8525)
4547 * data.c (atof): Remove decl; no longer used or needed.
4548 (digit_to_number): Move to lread.c.
4549 (Fstring_to_number): Use new string_to_number function, to be
4550 consistent with how the Lisp reader treats infinities and NaNs.
4551 Do not assume that floating-point numbers represent EMACS_INT
4552 without losing information; this is not true on most 64-bit hosts.
4553 Avoid double-rounding errors, by insisting on integers when
4554 parsing non-base-10 numbers, as the documentation specifies.
4555 * lisp.h (string_to_number): New decl, replacing ...
4556 (isfloat_string): Remove.
4557 * lread.c: Include <inttypes.h>, for uintmax_t and strtoumax.
4558 (read1): Do not accept +. and -. as integers; this
4559 appears to have been a coding error. Similarly, do not accept
4560 strings like +-1e0 as floating point numbers. Do not report
4561 overflow for integer overflows unless the base is not 10 which
4562 means we have no simple and reliable way to continue.
4563 Break out the floating-point parsing into a new
4564 function string_to_number, so that Fstring_to_number parses
4565 floating point numbers consistently with the Lisp reader.
4566 (digit_to_number): Move here from data.c. Make it static inline.
4567 (E_CHAR, EXP_INT): Remove, replacing with ...
4568 (E_EXP): New macro, to solve the "1.0e+" problem mentioned below.
4569 (string_to_number): New function, replacing isfloat_string.
4570 This function checks for valid syntax and produces the resulting
4571 Lisp float number too. Rework it so that string-to-number
4572 no longer mishandles examples like "1.0e+". Use strtoumax,
4573 so that overflow for non-base-10 numbers is reported only when
4574 there's no portable and simple way to convert to floating point.
4575
4576 * textprop.c (set_text_properties_1): Rewrite for clarity,
4577 and to avoid GCC warning about integer overflow.
4578
4579 * intervals.h (struct interval): Use EMACS_INT for members
4580 where EMACS_UINT might cause problems. See
4581 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html>.
4582 (CHECK_TOTAL_LENGTH): Remove cast to EMACS_INT; no longer needed.
4583 * intervals.c (interval_deletion_adjustment): Now returns EMACS_INT.
4584 All uses changed.
4585 (offset_intervals): Tell GCC not to worry about length overflow
4586 when negating a negative length.
4587
4588 * alloc.c (overrun_check_malloc, overrun_check_realloc): Now static.
4589 (overrun_check_free): Likewise.
4590
4591 * alloc.c (SDATA_SIZE) [!GC_CHECK_STRING_BYTES]: Avoid runtime check
4592 in the common case where SDATA_DATA_OFFSET is a multiple of Emacs
4593 word size.
4594
4595 * gnutls.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
4596 (gnutls_make_error): Rename local to avoid shadowing.
4597 (gnutls_emacs_global_deinit): ifdef out; not used.
4598 (Fgnutls_boot): Use const for pointer to readonly storage.
4599 Comment out unused local. Fix pointer signedness problems.
4600
4601 * lread.c (openp): Don't stuff size_t into an 'int'.
4602 Use <= on length, not < on length + 1, to avoid GCC 4.6.0 warning
4603 about possible signed overflow.
4604
4605 * gtkutil.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
4606 (GDK_KEY_g): Don't define if already defined.
4607 (xg_prepare_tooltip): Avoid pointer signedness problem.
4608 (xg_set_toolkit_scroll_bar_thumb): Redo to avoid two casts.
4609
4610 * process.c (Fnetwork_interface_info): Avoid left-shift undefined
4611 behavior with 1 << 31. GCC 4.6.0 warns about this on 32-bit hosts.
4612
4613 * xfns.c (Fx_window_property): Simplify a bit,
4614 to make a bit faster and to avoid GCC 4.6.0 warning.
4615 * xselect.c (x_get_window_property, x_handle_dnd_message): Likewise.
4616
4617 * fns.c (internal_equal): Don't assume size_t fits in int.
4618
4619 * alloc.c (compact_small_strings): Tighten assertion a little.
4620
4621 Replace pEd with more-general pI, and fix some printf arg casts.
4622 * lisp.h (pI): New macro, generalizing old pEd macro to other
4623 conversion specifiers. For example, use "...%"pI"d..." rather
4624 than "...%"pEd"...".
4625 (pEd): Remove. All uses replaced with similar uses of pI.
4626 * src/m/amdx86-64.h, src/m/ia64.h, src/m/ibms390x.h: Likewise.
4627 * alloc.c (check_pure_size): Don't overflow by converting size to int.
4628 * bidi.c (bidi_dump_cached_states): Use pI to avoid cast.
4629 * data.c (Fnumber_to_string): Use pI instead of if-then-else-abort.
4630 * dbusbind.c (xd_append_arg): Use pI to avoid cast.
4631 (Fdbus_method_return_internal, Fdbus_method_error_internal): Likewise.
4632 * font.c (font_unparse_xlfd): Avoid potential buffer overrun on
4633 64-bit hosts.
4634 (font_unparse_xlfd, font_unparse_fcname): Use pI to avoid casts.
4635 * keyboard.c (record_char, modify_event_symbol): Use pI to avoid casts.
4636 * print.c (safe_debug_print, print_object): Likewise.
4637 (print_object): Don't overflow by converting EMACS_INT or EMACS_UINT
4638 to int.
4639 Use pI instead of if-then-else-abort. Use %p to avoid casts,
4640 avoiding the 0 flag, which is not portable.
4641 * process.c (Fmake_network_process): Use pI to avoid cast.
4642 * region-cache.c (pp_cache): Likewise.
4643 * xdisp.c (decode_mode_spec): Likewise.
4644 * xrdb.c (x_load_resources) [USE_MOTIF]: Use pI to avoid undefined
4645 behavior on 64-bit hosts with printf arg.
4646 * xselect.c (x_queue_event): Use %p to avoid casts, avoiding 0 flag.
4647 (x_stop_queuing_selection_requests): Likewise.
4648 (x_get_window_property): Don't truncate byte count to an 'int'
4649 when tracing.
4650
4651 * frame.c (frame_name_fnn_p): Get rid of strtol, which isn't right
4652 here, since it parses constructs like leading '-' and spaces,
4653 which are not wanted; and it overflows with large numbers.
4654 Instead, simply match F[0-9]+, which is what is wanted anyway.
4655
4656 * alloc.c: Remove unportable assumptions about struct layout.
4657 (SDATA_SELECTOR, SDATA_DATA_OFFSET): New macros.
4658 (SDATA_OF_STRING, SDATA_SIZE, allocate_string_data):
4659 (allocate_vectorlike, make_pure_vector): Use the new macros,
4660 plus offsetof, to remove unportable assumptions about struct layout.
4661 These assumptions hold on all porting targets that I know of, but
4662 they are not guaranteed, they're easy to remove, and removing them
4663 makes further changes easier.
4664
4665 * alloc.c (BLOCK BYTES): Fix typo by changing "ablock" to "ablocks".
4666 This doesn't fix a bug but makes the code clearer.
4667 (string_overrun_cookie): Now const. Use initializers that
4668 don't formally overflow signed char, to avoid warnings.
4669 (allocate_string_data) [GC_CHECK_STRING_OVERRUN]: Fix typo that
4670 can cause Emacs to crash when string overrun checking is enabled.
4671 (allocate_buffer): Don't assume sizeof (struct buffer) is a
4672 multiple of sizeof (EMACS_INT); it need not be, if
4673 alignof(EMACS_INT) < sizeof (EMACS_INT).
4674 (check_sblock, check_string_bytes, check_string_free_list): Protoize.
4675
4676 2011-04-26 Juanma Barranquero <lekktu@gmail.com>
4677
4678 * keyboard.c (QCrtl): Rename from Qrtl. All uses changed.
4679
4680 2011-04-26 Teodor Zlatanov <tzz@lifelogs.com>
4681
4682 * gnutls.c (emacs_gnutls_handshake): Return an error if we're not
4683 supposed to be handshaking. (Bug#8556)
4684 Reported by Paul Eggert <eggert@cs.ucla.edu>.
4685
4686 2011-04-26 Daniel Colascione <dan.colascione@gmail.com>
4687
4688 * lisp.h (Qdebug): List symbol.
4689 * eval.c (Qdebug): Restore global linkage.
4690 * keyboard.c (debug-on-event): New variable.
4691 (handle_user_signal): Break into debugger when debug-on-event
4692 matches the current signal symbol.
4693
4694 2011-04-25 Dan Nicolaescu <dann@ics.uci.edu>
4695
4696 * alloc.c (check_sblock, check_string_bytes)
4697 (check_string_free_list): Convert to standard C.
4698
4699 2011-04-25 Teodor Zlatanov <tzz@lifelogs.com>
4700
4701 * w32.c (emacs_gnutls_push): Fix typo.
4702
4703 2011-04-25 Eli Zaretskii <eliz@gnu.org>
4704
4705 * gnutls.c (emacs_gnutls_handshake): Avoid compiler warnings about
4706 "cast to pointer from integer of different size".
4707
4708 Improve doprnt and its use in verror. (Bug#8545)
4709 * doprnt.c (doprnt): Document the set of format control sequences
4710 supported by the function. Use SAFE_ALLOCA instead of always
4711 using `alloca'.
4712
4713 * eval.c (verror): Don't limit the buffer size at size_max-1, that
4714 is one byte too soon. Don't use xrealloc; instead xfree and
4715 xmalloc anew.
4716
4717 2011-04-24 Teodor Zlatanov <tzz@lifelogs.com>
4718
4719 * gnutls.h: Add GNUTLS_STAGE_CALLBACKS enum to denote we're in the
4720 callbacks stage.
4721
4722 * gnutls.c: Renamed global_initialized to
4723 gnutls_global_initialized. Added internals for the
4724 :verify-hostname-error, :verify-error, and :verify-flags
4725 parameters of `gnutls-boot' and documented those parameters in the
4726 docstring. Start callback support.
4727 (emacs_gnutls_handshake): Add Woe32 support. Retry handshake
4728 unless a fatal error occurred. Call gnutls_alert_send_appropriate
4729 on error. Return error code.
4730 (emacs_gnutls_write): Call emacs_gnutls_handle_error.
4731 (emacs_gnutls_read): Likewise.
4732 (Fgnutls_boot): Return handshake error code.
4733 (emacs_gnutls_handle_error): New function.
4734 (wsaerror_to_errno): Likewise.
4735
4736 * w32.h (emacs_gnutls_pull): Add prototype.
4737 (emacs_gnutls_push): Likewise.
4738
4739 * w32.c (emacs_gnutls_pull): New function for GnuTLS on Woe32.
4740 (emacs_gnutls_push): Likewise.
4741
4742 2011-04-24 Claudio Bley <claudio.bley@gmail.com> (tiny change)
4743
4744 * process.c (wait_reading_process_output): Check if GnuTLS
4745 buffered some data internally if no FDs are set for TLS
4746 connections.
4747
4748 * makefile.w32-in (OBJ2): Add gnutls.$(O).
4749 (LIBS): Link to USER_LIBS.
4750 ($(BLD)/gnutls.$(0)): New target.
4751
4752 2011-04-24 Eli Zaretskii <eliz@gnu.org>
4753
4754 * xdisp.c (handle_single_display_spec): Rename the
4755 display_replaced_before_p argument into display_replaced_p, to
4756 make it consistent with the commentary. Fix typos in the
4757 commentary.
4758
4759 * textprop.c (syms_of_textprop): Remove dead code.
4760 (copy_text_properties): Delete obsolete commentary about an
4761 interface that was deleted long ago. Fix typos in the description
4762 of arguments.
4763
4764 * msdos.c (XMenuActivate, XMenuAddSelection): Adjust argument list
4765 to changes in oldXMenu/XMenu.h from 2011-04-16.
4766 <menu_help_message, prev_menu_help_message>: Constify.
4767 (IT_menu_make_room): menu->help_text is now `const char **';
4768 adjust.
4769
4770 * msdos.h (XMenuActivate, XMenuAddSelection): Adjust prototypes
4771 to changes in oldXMenu/XMenu.h from 2011-04-16.
4772 (struct XMenu): Declare `help_text' `const char **'.
4773
4774 * xfaces.c <Qunspecified>: Make extern again.
4775
4776 * syntax.c: Include sys/types.h before including regex.h, as
4777 required by Posix.
4778
4779 * doc.c (get_doc_string): Improve the format passed to `error'.
4780
4781 * doprnt.c (doprnt): Improve commentary.
4782
4783 * term.c (init_tty) [MSDOS]: Fix 1st argument to maybe_fatal.
4784
4785 * Makefile.in (TAGS): Depend on $(M_FILE) and $(S_FILE), and scan
4786 them with etags.
4787
4788 * makefile.w32-in (globals.h): Add a dummy recipe, to make any
4789 changes in globals.h immediately force recompilation.
4790 (TAGS): Depend on $(CURDIR)/m/intel386.h and
4791 $(CURDIR)/s/ms-w32.h.
4792 (TAGS-gmake): Scan $(CURDIR)/m/intel386.h and $(CURDIR)/s/ms-w32.h.
4793
4794 * character.c (Fchar_direction): Function deleted.
4795 (syms_of_character): Don't defsubr it.
4796 <char-direction-table>: Deleted.
4797
4798 2011-04-23 Eli Zaretskii <eliz@gnu.org>
4799
4800 Fix doprnt so it could be used again safely in `verror'. (Bug#8435)
4801 * doprnt.c: Include limits.h.
4802 (SIZE_MAX): New macro.
4803 (doprnt): Return a size_t value. 2nd arg is now size_t.
4804 Many local variables are now size_t instead of int or unsigned.
4805 Improve overflow protection. Support `l' modifier for integer
4806 conversions. Support %l conversion. Don't assume an EMACS_INT
4807 argument for integer conversions and for %c.
4808
4809 * lisp.h (doprnt): Restore prototype.
4810
4811 * makefile.w32-in ($(BLD)/callint.$(O)): Depend on
4812 $(SRC)/character.h.
4813
4814 * Makefile.in (base_obj): Add back doprnt.o.
4815
4816 * deps.mk (doprnt.o): Add back prerequisites.
4817 (callint.o): Depend on character.h.
4818
4819 * eval.c (internal_lisp_condition_case): Include the handler
4820 representation in the error message.
4821 (verror): Call doprnt instead of vsnprintf. Fix an off-by-one bug
4822 when breaking from the loop.
4823
4824 * xdisp.c (vmessage): Call doprnt instead of vsnprintf.
4825
4826 * callint.c (Fcall_interactively): When displaying error message
4827 about invalid control letter, pass the character's codepoint, not
4828 a pointer to its multibyte form. Improve display of the character
4829 in octal and display also its hex code.
4830
4831 * character.c (char_string): Use %x to display the (unsigned)
4832 codepoint of an invalid character, to avoid displaying a bogus
4833 negative value.
4834
4835 * font.c (check_otf_features): Pass SDATA of SYMBOL_NAME to
4836 `error', not SYMBOL_NAME itself.
4837
4838 * coding.c (Fencode_sjis_char, Fencode_big5_char): Use %c for
4839 character arguments to `error'.
4840
4841 * charset.c (check_iso_charset_parameter): Fix incorrect argument
4842 to `error' in error message about FINAL_CHAR argument. Make sure
4843 FINAL_CHAR is a character, and use %c when it is passed as
4844 argument to `error'.
4845
4846 2011-04-23 Eli Zaretskii <eliz@gnu.org>
4847
4848 * s/ms-w32.h (localtime): Redirect to sys_localtime.
4849
4850 * w32.c: Include <time.h>.
4851 (sys_localtime): New function.
4852
4853 2011-04-23 Chong Yidong <cyd@stupidchicken.com>
4854
4855 * xdisp.c (init_xdisp): Initialize echo_area_window (Bug#6451).
4856
4857 * buffer.c (syms_of_buffer): Doc fix (Bug#6902).
4858
4859 2011-04-23 Samuel Thibault <sthibault@debian.org> (tiny change)
4860
4861 * sysdep.c (wait_for_termination): On GNU Hurd, kill returns -1 on
4862 zombies (Bug#8467).
4863
4864 2011-04-19 Eli Zaretskii <eliz@gnu.org>
4865
4866 * syntax.h (SETUP_SYNTAX_TABLE_FOR_OBJECT): Fix setting of
4867 gl_state.e_property when gl_state.object is Qt.
4868
4869 * insdel.c (make_gap_larger): Remove limitation of buffer size
4870 to <= INT_MAX.
4871
4872 2011-04-18 Chong Yidong <cyd@stupidchicken.com>
4873
4874 * xdisp.c (lookup_glyphless_char_display)
4875 (produce_glyphless_glyph): Handle cons cell entry in
4876 glyphless-char-display.
4877 (Vglyphless_char_display): Document it.
4878
4879 * term.c (produce_glyphless_glyph): Handle cons cell entry in
4880 glyphless-char-display.
4881
4882 2011-04-17 Chong Yidong <cyd@stupidchicken.com>
4883
4884 * xdisp.c (get_next_display_element): Remove unnecessary ifdefs.
4885
4886 * termhooks.h (FRAME_WINDOW_P): Remove duplicated definitions.
4887
4888 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): Add missing
4889 definition for no-X builds.
4890
4891 2011-04-16 Paul Eggert <eggert@cs.ucla.edu>
4892
4893 Static checks with GCC 4.6.0 and non-default toolkits.
4894
4895 * s/sol2-6.h, s/unixware.h (PTY_TTY_NAME_SPRINTF): Protoize decl.
4896
4897 * process.c (keyboard_bit_set): Define only if SIGIO.
4898 (send_process_trap): Mark it with NO_RETURN if it doesn't return.
4899 (send_process): Repair possible setjmp clobbering.
4900
4901 * s/usg5-4-common.h (SETUP_SLAVE_PTY): Don't pass extra arg to 'fatal'.
4902
4903 * eval.c: Include <stdio.h>, for vsnprintf on non-GNU/Linux hosts.
4904
4905 * data.c (arith_error): Mark with NO_RETURN if it doesn't return.
4906
4907 * alloc.c (bytes_used_when_full, SPARE_MEMORY, BYTES_USED):
4908 Define only if needed.
4909
4910 * sysdep.c (_FILE_OFFSET_BITS): Make this hack even uglier
4911 by pacifying GCC about it. Maybe it's time to retire it?
4912 * xfaces.c (USG, __TIMEVAL__): Likewise.
4913
4914 * dispextern.h (struct redisplay_interface): Rename param
4915 to avoid shadowing.
4916 * termhooks.h (struct terminal): Likewise.
4917 * xterm.c (xembed_send_message): Likewise.
4918
4919 * insdel.c (make_gap_smaller): Define only if
4920 USE_MMAP_FOR_BUFFERS || REL_ALLOC || DOUG_LEA_MALLOC.
4921
4922 * keyboard.c (read_char): Make a var volatile so longjmp won't clobber
4923 it.
4924
4925 * emacs.c (MAX_HEAP_BSS_DIFF, my_edata): Move to where they're used,
4926 so that we aren't warned about unused symbols.
4927
4928 * xfns.c (Fx_file_dialog): Rename local to avoid shadowing.
4929
4930 * xdisp.c (x_produce_glyphs): Mark var as initialized (Bug#8512).
4931
4932 * xfns.c (x_real_positions): Mark locals as initialized.
4933
4934 * xmenu.c (xmenu_show): Don't use uninitialized vars.
4935
4936 * xterm.c: Fix problems found by static analysis with other toolkits.
4937 (toolkit_scroll_bar_interaction): Define and use only if USE_X_TOOLKIT.
4938 (x_dispatch_event): Declare static if USE_GTK, and
4939 define if USE_GTK || USE_X_TOOLKIT.
4940 (SET_SAVED_BUTTON_EVENT): Define only if USE_X_TOOLKIT || USE_GTK.
4941 * xterm.h (x_dispatch_event): Extern only if USE_X_TOOLKIT.
4942 * xterm.c, xterm.h (x_mouse_leave): Bring this function back, but only
4943 if defined HAVE_MENUS && !defined USE_X_TOOLKIT && !defined USE_GTK.
4944
4945 * xmenu.c (menu_help_callback): Pointer type fixes.
4946 Use const pointers when pointing at readonly data. Avoid pointer
4947 signedness clashes.
4948 (FALSE): Remove unused macro.
4949 (update_frame_menubar): Remove unused decl.
4950
4951 * xfns.c (Fx_hide_tip): Move locals to avoid shadowing.
4952
4953 * menu.c (push_submenu_start, push_submenu_end): Do not define unless
4954 USE_X_TOOLKIT || USE_GTK || HAVE_NS || defined HAVE_NTGUI.
4955 (single_menu_item): Rename local to avoid shadowing.
4956
4957 * keyboard.c (make_lispy_event): Remove unused local var.
4958
4959 * frame.c, frame.h (x_get_resource_string): Bring this back, but
4960 only if HAVE_X_WINDOWS && !USE_X_TOOLKIT.
4961
4962 * bitmaps: Change bitmaps from unsigned char back to the X11
4963 compatible char. Avoid the old compiler warnings about
4964 out-of-range initializers by using, for example, '\xab' rather
4965 than 0xab.
4966
4967 * xgselect.c (xgselect_initialize): Check vs interface
4968 even if ! (defined (USE_GTK) || defined (HAVE_GCONF)).
4969
4970 * xmenu.c (xmenu_show): Rename parm to avoid shadowing.
4971
4972 * xterm.c (x_create_toolkit_scroll_bar): Use const * for pointers
4973 to read-only memory.
4974
4975 * fns.c (vector): Remove; this old hack is no longer needed.
4976
4977 * xsmfns.c (create_client_leader_window): Rename shadowing arg.
4978 Remove unused var.
4979 (gdk_x11_set_sm_client_id) [!USE_GTK]: Don't define.
4980
4981 * xrdb.c (x_load_resources): Omit unused local.
4982
4983 * xfns.c (free_frame_menubar, atof): Remove duplicate decls.
4984 (x_window): Rename locals to avoid shadowing.
4985 (USG): Use the kludged USG macro, to pacify gcc.
4986
4987 * xterm.c (x_alloc_nearest_color_for_widget): Remove; unused.
4988 (x_term_init): Remove local to avoid shadowing.
4989
4990 * xfns.c, xterm.c (_XEditResCheckMessages): Protoize decl.
4991
4992 * xdisp.c, dispextern.h (set_vertical_scroll_bar): Now extern if
4993 USE_TOOLKIT_SCROLL_BARS && !USE_GTK, as xterm.c needs it then.
4994
4995 2011-04-16 Eli Zaretskii <eliz@gnu.org>
4996
4997 * gnutls.c (Fgnutls_boot): Don't pass Lisp_Object to `error'.
4998
4999 Fix regex.c, syntax.c and friends for buffers > 2GB.
5000 * syntax.h (struct gl_state_s): Declare character position members
5001 EMACS_INT.
5002
5003 * syntax.c (update_syntax_table): Declare 2nd argument EMACS_INT.
5004
5005 * textprop.c (verify_interval_modification, interval_of):
5006 Declare arguments EMACS_INT.
5007
5008 * intervals.c (adjust_intervals_for_insertion): Declare arguments
5009 EMACS_INT.
5010
5011 * intervals.h (CHECK_TOTAL_LENGTH): Cast to EMACS_INT, not `int'.
5012
5013 * indent.c (Fvertical_motion): Local variable it_start is now
5014 EMACS_INT.
5015
5016 * regex.c (re_match, re_match_2, re_match_2_internal)
5017 (bcmp_translate, regcomp, regexec, print_double_string)
5018 (group_in_compile_stack, re_search, re_search_2, regex_compile)
5019 (re_compile_pattern, re_exec): Declare arguments and local
5020 variables `size_t' and `ssize_t' and return values `regoff_t', as
5021 appropriate.
5022 (POP_FAILURE_REG_OR_COUNT) <pfreg>: Declare `long'.
5023 (CHECK_INFINITE_LOOP) <failure>: Declare `ssize_t'.
5024 <compile_stack_type>: `size' and `avail' are now `size_t'.
5025
5026 * regex.h <regoff_t>: Use ssize_t, not int.
5027 (re_search, re_search_2, re_match, re_match_2): Arguments that
5028 specify buffer/string position and length are now ssize_t and
5029 size_t. Return type is regoff_t.
5030
5031 2011-04-16 Ben Key <bkey76@gmail.com>
5032
5033 * nsfont.m: Fixed bugs in ns_get_family and
5034 ns_descriptor_to_entity that were caused by using free to
5035 deallocate memory blocks that were allocated by xmalloc (via
5036 xstrdup). This caused Emacs to crash when compiled with
5037 XMALLOC_OVERRUN_CHECK defined (when Emacs was configured with
5038 --enable-checking=xmallocoverrun). xfree is now used to
5039 deallocate these memory blocks.
5040
5041 2011-04-15 Paul Eggert <eggert@cs.ucla.edu>
5042
5043 * sysdep.c (emacs_read): Remove unnecessary check vs MAX_RW_COUNT.
5044
5045 emacs_write: Accept and return EMACS_INT for sizes.
5046 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html
5047 et seq.
5048 * gnutls.c, gnutls.h (emacs_gnutls_read, emacs_gnutls_write):
5049 Accept and return EMACS_INT.
5050 (emacs_gnutls_write): Return the number of bytes written on
5051 partial writes.
5052 * sysdep.c, lisp.h (emacs_read, emacs_write): Likewise.
5053 (emacs_read, emacs_write): Remove check for negative size, as the
5054 Emacs source code has been audited now.
5055 * sysdep.c (MAX_RW_COUNT): New macro, to work around kernel bugs.
5056 (emacs_read, emacs_write): Use it.
5057 * process.c (send_process): Adjust to the new signatures of
5058 emacs_write and emacs_gnutls_write. Do not attempt to store
5059 a byte offset into an 'int'; it might overflow.
5060 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00483.html
5061
5062 * sound.c: Don't assume sizes fit in 'int'.
5063 (struct sound_device.period_size, alsa_period_size):
5064 Return EMACS_INT, not int.
5065 (struct sound_device.write, vox_write, alsa_write):
5066 Accept EMACS_INT, not int.
5067 (wav_play, au_play): Use EMACS_INT to store sizes and to
5068 record read return values.
5069
5070 2011-04-15 Ben Key <bkey76@gmail.com>
5071
5072 * keyboard.c (Qundefined): Don't declare static since it is used
5073 in nsfns.m.
5074 * xfaces.c (Qbold, Qexpanded, Qitalic, Qcondensed): Don't declare
5075 static since they are used in nsfont.m.
5076
5077 2011-04-15 Stefan Monnier <monnier@iro.umontreal.ca>
5078
5079 * process.c (Qprocessp): Don't declare static.
5080 * lisp.h (Qprocessp): Declare again.
5081
5082 2011-04-15 Juanma Barranquero <lekktu@gmail.com>
5083
5084 * font.c (Qopentype): Don't make static (used from w32uniscribe.c).
5085
5086 2011-04-14 Paul Eggert <eggert@cs.ucla.edu>
5087
5088 Improve C-level modularity by making more things 'static'.
5089
5090 Don't publish debugger-only interfaces to other modules.
5091 * lisp.h (safe_debug_print, debug_output_compilation_hack):
5092 (verify_bytepos, count_markers): Move decls to the only modules
5093 that need them.
5094 * region-cache.h (pp_cache): Likewise.
5095 * window.h (check_all_windows): Likewise.
5096 * marker.c, print.c, region-cache.c, window.c: Decls moved here.
5097
5098 * sysdep.c (croak): Now static, if
5099 defined TIOCNOTTY || defined USG5 || defined CYGWIN.
5100 * syssignal.h (croak): Declare only if not static.
5101
5102 * alloc.c (refill_memory_reserve): Now static if
5103 !defined REL_ALLOC || defined SYSTEM_MALLOC.
5104 * lisp.h (refill_memory_reserve): Declare only if not static.
5105
5106 * xsettings.c, xsettings.h (xsettings_get_system_normal_font):
5107 Define only if USE_LUCID.
5108
5109 * xrdb.c (x_customization_string, x_rm_string): Now static.
5110
5111 * xmenu.c (x_menu_wait_for_event): Export only if USE_MOTIF.
5112 * xterm.h (x_menu_wait_for_event): Declare only if USE_MOTIF.
5113
5114 * xdisp.c (draw_row_with_mouse_face): Now static.
5115 * dispextern.h (draw_row_with_mouse_fave): Remove decl.
5116
5117 * window.h (check_all_windows): Mark externally visible.
5118
5119 * window.c (window_deletion_count): Now static.
5120
5121 * undo.c: Make symbols static if they're not exported.
5122 (last_undo_buffer, last_boundary_position, pending_boundary):
5123 Now static.
5124
5125 * textprop.c (interval_insert_behind_hooks): Now static.
5126 (interval_insert_in_front_hooks): Likewise.
5127
5128 * term.c: Make symbols static if they're not exported.
5129 (tty_turn_off_highlight, get_tty_terminal, max_frame_cols):
5130 (max_frame_lines, tty_set_terminal_modes):
5131 (tty_reset_terminal_modes, tty_turn_off_highlight):
5132 (get_tty_terminal): Now static.
5133 (term_mouse_moveto): Do not define if HAVE_WINDOW_SYSTEM.
5134 * termhooks.h (term_mouse_moveto): Do not declare if
5135 HAVE_WINDOW_SYSTEM.
5136 * dispextern.h (tty_set_terminal_modes, tty_reset_terminal_modes):
5137 (tty_turn_off_highlight, get_tty_terminal): Remove decls.
5138
5139 * sysdep.c: Make symbols static if they're not exported.
5140 (emacs_get_tty, emacs_set_tty, old_fcntl_flags, old_fcntl_owner):
5141 Now static.
5142 (sigprocmask_set, full_mask): Remove; unused.
5143 (wait_debugging): Mark as visible.
5144 * syssignal.h (SIGFULLMASK, full_mask): Remove decls.
5145 * systty.h (emacs_get_tty, emacs_set_tty): Remove decls.
5146
5147 * syntax.c (syntax_temp): Define only if !__GNUC__.
5148
5149 * sound.c (current_sound_device, current_sound): Now static.
5150
5151 * search.c (searchbufs, searchbuf_head): Now static.
5152
5153 * scroll.c (scroll_cost): Remove; unused.
5154 * dispextern.h (scroll_cost): Remove decl.
5155
5156 * region-cache.h (pp_cache): Mark as externally visible.
5157
5158 * process.c: Make symbols static if they're not exported.
5159 (process_tick, update_tick, create_process, chan_process):
5160 (Vprocess_alist, proc_buffered_char, datagram_access):
5161 (fd_callback_data, send_process_frame, process_sent_to): Now static.
5162 (deactivate_process): Mark defn as static, as well as decl.
5163 * lisp.h (create_process): Remove decl.
5164 * process.h (chan_process, Vprocess_alist): Remove decls.
5165
5166 * print.c: Make symbols static if they're not exported.
5167 (print_depth, new_backquote_output, being_printed, print_buffer):
5168 (print_buffer_size, print_buffer_pos, print_buffer_pos_byte):
5169 (print_interval, print_number_index, initial_stderr_stream):
5170 Now static.
5171 * lisp.h (Fprinc): Remove decl.
5172 (debug_output_compilation_hack): Mark as externally visible.
5173
5174 * sysdep.c (croak): Move decl from here to syssignal.h.
5175 * syssignal.h (croak): Put it here, so the API can be checked when
5176 'croak' is called from dissociate_if_controlling_tty.
5177
5178 * minibuf.c: Make symbols static if they're not exported.
5179 (minibuf_save_list, choose_minibuf_frame): Now static.
5180 * lisp.h (choose_minibuf_frame): Remove decl.
5181
5182 * lisp.h (verify_bytepos, count_markers): Mark as externally visible.
5183
5184 * lread.c: Make symbols static if they're not exported.
5185 (read_objects, initial_obarray, oblookup_last_bucket_number):
5186 Now static.
5187 (make_symbol): Remove; unused.
5188 * lisp.h (initial_obarray, make_symbol): Remove decls.
5189
5190 * keyboard.c: Make symbols static if they're not exported.
5191 (single_kboard, recent_keys_index, total_keys, recent_keys):
5192 (this_command_key_count_reset, raw_keybuf, raw_keybuf_count):
5193 (this_single_command_key_start, echoing, last_auto_save):
5194 (read_key_sequence_cmd, dribble, recursive_edit_unwind):
5195 (command_loop, echo_now, keyboard_init_hook, help_char_p):
5196 (quit_throw_to_read_char, command_loop_2, top_level_1, poll_timer):
5197 (Vlispy_mouse_stem, double_click_count):
5198 Now static.
5199 (force_auto_save_soon): Define only if SIGDANGER.
5200 (ignore_mouse_drag_p): Now static if
5201 !defined HAVE_WINDOW_SYSTEM || defined USE_GTK || defined HAVE_NS.
5202 (print_help): Remove; unused.
5203 (stop_character, last_timer_event): Mark as externally visible.
5204 * keyboard.h (ignore_mouse_drag_p): Declare only if
5205 defined HAVE_WINDOW_SYSTEM && !defined USE_GTK && !defined HAVE_NS.
5206 (echo_now, help_char_p, quit_throw_to_read_char): Remove decls.
5207 * lisp.h (echoing): Remove decl.
5208 (force_auto_save_soon): Declare only if SIGDANGER.
5209 * xdisp.c (redisplay_window): Simplify code, to make it more
5210 obvious that ignore_mouse_drag_p is not accessed if !defined
5211 USE_GTK && !defined HAVE_NS.
5212
5213 * intervals.c: Make symbols static if they're not exported.
5214 (merge_properties_sticky, merge_interval_right, delete_interval):
5215 Now static.
5216 * intervals.h (merge_interval_right, delete_interval): Remove decls.
5217
5218 * insdel.c: Make symbols static if they're not exported.
5219 However, leave prepare_to_modify_buffer alone. It's never
5220 called from outside this function, but that appears to be a bug.
5221 (combine_after_change_list, combine_after_change_buffer):
5222 (adjust_after_replace, signal_before_change): Now static.
5223 (adjust_after_replace_noundo): Remove; unused.
5224 * lisp.h (adjust_after_replace, adjust_after_replace_noundo):
5225 (signal_before_change): Remove decls.
5226
5227 * indent.c (val_compute_motion, val_vmotion): Now static.
5228
5229 * image.c: Make symbols static if they're not exported.
5230 * dispextern.h (x_create_bitmap_from_xpm_data): Do not declare
5231 if USE_GTK.
5232 * image.c (x_create_bitmap_from_xpm_data): Do not define if USE_GTK.
5233 (xpm_color_cache, ct_table, ct_colors_allocated): Now static.
5234
5235 * fringe.c (standard_bitmaps): Now static.
5236 (max_used_fringe_bitmap): Now static, unless HAVE_NS.
5237
5238 * frame.c: Make symbols static if they're not exported.
5239 (x_report_frame_params, make_terminal_frame): Now static.
5240 (get_frame_param): Now static, unless HAVE_NS.
5241 (x_fullscreen_adjust): Define if WINDOWSNT, not if HAVE_WINDOW_SYSTEM.
5242 (x_get_resource_string): Remove; not used.
5243 * frame.h (make_terminal_frame, x_report_frame_params):
5244 (x_get_resource_string); Remove decls.
5245 (x_fullscreen_adjust): Declare only if WINDOWSNT.
5246 * lisp.h (get_frame_param): Declare only if HAVE_NS.
5247
5248 * font.c, fontset.c: Make symbols static if they're not exported.
5249 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): New macro.
5250 (FACE_SUITABLE_FOR_CHAR_P): Use it.
5251 * font.c (font_close_object): Now static.
5252 * font.h (font_close_object): Remove.
5253 * fontset.c (FONTSET_OBJLIST): Remove.
5254 (free_realized_fontset) #if-0 the body, which does nothing.
5255 (face_suitable_for_char_p): #if-0, as it's never called.
5256 * fontset.h (face_suitable_for_char_p): Remove decl.
5257 * xfaces.c (face_at_string_position):
5258 Use FACE_SUITABLE_FOR_ASCII_CHAR_P, not FACE_SUITABLE_FOR_CHAR_P,
5259 since 0 is always ASCII.
5260
5261 * fns.c (weak_hash_tables): Now static.
5262
5263 * fileio.c: Make symbols static if they're not exported.
5264 (auto_saving, auto_save_mode_bits, auto_save_error_occurred):
5265 (Vwrite_region_annotation_buffers): Now static.
5266
5267 * eval.c: Make symbols static if they're not exported.
5268 (backtrace_list, lisp_eval_depth, when_entered_debugger): Now static.
5269 * lisp.h (backtrace_list): Remove decl.
5270
5271 * emacs.c: Make symbols static if they're not exported.
5272 (malloc_state_ptr, malloc_using_checking, syms_of_emacs):
5273 (fatal_error_code, fatal_error_signal_hook, standard_args):
5274 Now static.
5275 (fatal_error_signal): Now static, unless FLOAT_CATCH_SIGKILL.
5276 (DEFINE_DUMMY_FUNCTION): Mark function as externally visible.
5277 (__CTOR_LIST__, __DTOR_LIST__): Now externally visible.
5278 * lisp.h (fatal_error_signal_hook): Remove decl.
5279 (fatal_error_signal): Declare only if FLOAT_CATCH_SIGKILL.
5280
5281 * editfns.c: Move a (normally-unused) function to its only use.
5282 * editfns.c, lisp.h (get_operating_system_release): Remove.
5283 * process.c (init_process) [DARWIN_OS]: Do it inline, as it is not
5284 worth the hassle of breaking this out.
5285
5286 * xterm.c: Make symbols static if they're not exported.
5287 (x_raise_frame, x_lower_frame, x_wm_set_window_state):
5288 (x_wm_set_icon_pixmap, x_initialize, XTread_socket_fake_io_error):
5289 (x_destroy_window, x_delete_display):
5290 Now static.
5291 (x_dispatch_event): Now static if ! (USE_MOTIF || USE_X_TOOLKIT).
5292 (x_mouse_leave): Remove; unused.
5293 * xterm.h (x_display_info_for_name, x_raise_frame, x_lower_frame):
5294 (x_destroy_window, x_wm_set_window_state, x_wm_set_icon_pixmap):
5295 (x_delete_display, x_initialize, x_set_border_pixel, x_screen_planes):
5296 Remove decls.
5297 (x_mouse_leave): Declare only if WINDOWSNT.
5298 (x_dispatch_event): Declare only if USE_MOTIF or USE_X_TOOLKIT.
5299 (xic_create_fontsetname): Declare only if HAVE_X_WINDOWS &&
5300 USE_X_TOOLKIT.
5301
5302 * ftxfont.c: Make symbols static if they're not exported.
5303 (ftxfont_driver): Export only if !defined HAVE_XFT && def8ined
5304 HAVE_FREETYPE.
5305 * font.h (ftxfont_driver): Likewise.
5306
5307 * xfns.c: Make symbols static if they're not exported.
5308 (x_last_font_name, x_display_info_for_name):
5309 (x_set_foreground_color, x_set_background_color, x_set_mouse_color):
5310 (x_set_cursor_color, x_set_border_pixel, x_set_border_color):
5311 (x_set_cursor_type, x_set_icon_type, x_set_icon_name):
5312 (x_set_scroll_bar_foreground, x_set_scroll_bar_background):
5313 (x_explicitly_set_name, x_set_title, xic_defaut_fontset, tip_timer):
5314 (last_show_tip_args): Now static.
5315 (xic_defaut_fontset, xic_create_fontsetname): Define only if
5316 defined HAVE_X_WINDOWS && defined USE_X_TOOLKIT
5317 (x_screen_planes): Remove; unused.
5318 * dispextern.h (x_screen_planes): Remove decl.
5319
5320 * dispnew.c: Make symbols static if they're not exported.
5321 * dispextern.h (redraw_garbaged_frames, scrolling):
5322 (increment_row_positions): Remove.
5323 * dispnew.c (new_glyph_matrix, increment_row_positions, scrolling):
5324 (delayed_size_change, glyph_matrix_count, glyph_pool_count):
5325 Now static.
5326 (redraw_garbaged_frames): Remove; unused.
5327
5328 * xfaces.c: Make symbols static if they're not exported.
5329 * dispextern.h (ascii_face_of_lisp_face, free_realized_face):
5330 Remove decls.
5331 * xterm.h (defined_color): Remove decls.
5332 (x_free_dpy_colors): Declare only if USE_X_TOOLKIT.
5333 * xfaces.c (tty_suppress_bold_inverse_default_colors_p):
5334 (menu_face_changed_default, defined_color, free_realized_face):
5335 (x_free_dpy_colors): Define only if USE_X_TOOLKIT.
5336 (ascii_face_of_lisp_face): Remove; unused.
5337
5338 * xdisp.c: Make symbols static if they're not exported.
5339 * dispextern.h (scratch_glyph_row, window_box_edges):
5340 (glyph_to_pixel_coords, set_cursor_from_row):
5341 (get_next_display_element, set_iterator_to_next):
5342 (highlight_trailing_whitespace, frame_to_window_pixel_xy):
5343 (show_mouse_face): Remove decls
5344 * frame.h (message_buf_print): Likewise.
5345 * lisp.h (pop_message, set_message, check_point_in_composition):
5346 Likewise.
5347 * xterm.h (set_vertical_scroll_bar): Likewise.
5348 * xdisp.c (list_of_error, Vmessage_stack, line_number_displayed):
5349 (message_buf_print, scratch_glyph_row, displayed_buffer):
5350 (set_iterator_to_next, pop_message, set_message, set_cursor_from_row):
5351 (get_next_display_element, show_mouse_face, window_box_edges):
5352 (frame_to_window_pixel_xy, check_point_in_composition):
5353 (set_vertical_scroll_bar, highlight_trailing_whitespace): Now static.
5354 (glyph_to_pixel_coords): Remove; unused.
5355
5356 * dired.c (file_name_completion): Now static.
5357
5358 * dbusbind.c (xd_in_read_queued_messages): Now static.
5359
5360 * lisp.h (circular_list_error, FOREACH): Remove; unused.
5361 * data.c (circular_list_error): Remove.
5362
5363 * commands.h (last_point_position, last_point_position_buffer):
5364 (last_point_position_window): Remove decls.
5365 * keyboard.c: Make these variables static.
5366
5367 * coding.h (coding, code_convert_region, encode_coding_gap):
5368 Remove decls.
5369 * coding.c (Vsjis_coding_system, Vbig5_coding_system):
5370 (iso_code_class, detect_coding, code_convert_region): Now static.
5371 (encode_coding_gap): Remove; unused.
5372
5373 * chartab.c (chartab_chars, chartab_bits): Now static.
5374
5375 * charset.h (charset_iso_8859_1): Remove decl.
5376 * charset.c (charset_iso_8859_1, charset_emacs, map_charset_for_dump):
5377 Now static.
5378
5379 * ccl.h (check_ccl_update, Vccl_program_table): Remove decls.
5380 * ccl.c (Vccl_program_table): Now static.
5381 (check_ccl_update): Remove; unused.
5382
5383 * category.c (SET_CATEGORY_SET, set_category_set): Move here.
5384 * category.h: ... from here.
5385 * category.c (check_category_table, set_category_set): Now static.
5386
5387 * casetab.c (Vascii_upcase_table, Vascii_eqv_table): Now static.
5388 * lisp.h: Remove these decls.
5389
5390 * buffer.c (buffer_count): Remove unused var.
5391
5392 * bidi.c (bidi_dump_cached_states): Mark as externally visible,
5393 so that it's not optimized away.
5394 (bidi_ignore_explicit_marks_for_paragraph_level): Likewise.
5395 * dispextern.h (bidi_dump_cached_states): Remove, since it's
5396 exported only to the debugger.
5397
5398 * atimer.c (alarm_signal_handler, run_all_atimers): Now static.
5399 * atimer.h (run_all_atimers): Remove; not exported.
5400
5401 font.c: Make copy_font_spec and merge_font_spec ordinary C functions.
5402 * font.c (copy_font_spec): Rename from Fcopy_font_spec, since it
5403 was inaccessible from Lisp.
5404 (merge_font_spec): Likewise, renaming from Fmerge_font_spec.
5405 * font.c, font.h, fontset.c, xfaces.c, xfont.c: Change all uses.
5406
5407 alloc.c: Import and export fewer symbols, and remove unused items.
5408 * lisp.h (suppress_checking, die): Declare only if ENABLE_CHECKING
5409 is defined.
5410 (suppress_checking): Add EXTERNALLY_VISIBLE attribute, so that
5411 it's not optimized away by whole-program optimization.
5412 (message_enable_multibyte, free_misc): Remove.
5413 (catchlist, handlerlist, mark_backtrace):
5414 Declare only if BYTE_MARK_STACK.
5415 (mark_byte_stack): Likewise, fixing a ifdef-vs-if typo.
5416 * alloc.c (pure): Export only if VIRT_ADDR_VARIES is defined.
5417 (message_enable_multibyte): Remove decl.
5418 (free_misc, interval_free_list, float_block, float_block_index):
5419 (n_float_blocks, float_free_list, cons_block, cons_block_index):
5420 (cons_free_list, last_marked_index):
5421 Now static.
5422 (suppress_checking, die): Define only if ENABLE_CHECKING is defined.
5423 * eval.c (catchlist, handlerlist): Export only if BYTE_MARK_STACK.
5424 (mark_backtrace): Define only if BYTE_MARK_STACK.
5425 * xdisp.c (message_enable_multibyte): Now static.
5426
5427 Declare Lisp_Object Q* variables to be 'static' if not exported.
5428 This makes it easier for human readers (and static analyzers)
5429 to see whether these variables are used from other modules.
5430 * alloc.c, buffer.c, bytecode.c, callint.c, casetab.c, category.c:
5431 * ccl.c, character.c, charset.c, cmds.c, coding.c, composite.c:
5432 * data.c, dbusbind.c, dired.c, editfns.c, eval.c, fileio.c, fns.c:
5433 * font.c, frame.c, fringe.c, ftfont.c, image.c, keyboard.c, keymap.c:
5434 * lread.c, macros.c, minibuf.c, print.c, process.c, search.c:
5435 * sound.c, syntax.c, textprop.c, window.c, xdisp.c, xfaces.c, xfns.c:
5436 * xmenu.c, xselect.c:
5437 Declare Q* vars static if they are not used in other modules.
5438 * ccl.h, character.h, charset.h, coding.h, composite.h, font.h:
5439 * frame.h, intervals.h, keyboard.h, lisp.h, process.h, syntax.h:
5440 Remove decls of unexported vars.
5441 * keyboard.h (EVENT_HEAD_UNMODIFIED): Remove now-unused macro.
5442
5443 * lisp.h (DEFINE_FUNC): Make sname 'static'.
5444
5445 Make Emacs functions such as Fatom 'static' by default.
5446 This makes it easier for human readers (and static analyzers)
5447 to see whether these functions can be called from other modules.
5448 DEFUN now defines a static function. To make the function external
5449 so that it can be used in other C modules, use the new macro DEFUE.
5450 * lisp.h (Funibyte_char_to_multibyte, Fsyntax_table_p):
5451 (Finit_image_library):
5452 (Feval_region, Fbacktrace, Ffetch_bytecode, Fswitch_to_buffer):
5453 (Ffile_executable_p, Fmake_symbolic_link, Fcommand_execute):
5454 (Fget_process, Fdocumentation_property, Fbyte_code, Ffile_attributes):
5455 Remove decls, since these functions are now static.
5456 (Funintern, Fget_internal_run_time): New decls, since these functions
5457 were already external.
5458
5459 * alloc.c, buffer.c, callint.c, callproc.c, casefiddle.c, casetab.c:
5460 * ccl.c, character.c, chartab.c, cmds.c, coding.c, data.c, dispnew.c:
5461 * doc.c, editfns.c, emacs.c, eval.c, fileio.c, filelock.c, floatfns.c:
5462 * fns.c, font.c, fontset.c, frame.c, image.c, indent.c:
5463 * keyboard.c, keymap.c, lread.c:
5464 * macros.c, marker.c, menu.c, minibuf.c, print.c, process.c, search.c:
5465 * syntax.c, term.c, terminal.c, textprop.c, undo.c:
5466 * window.c, xdisp.c, xfaces.c, xfns.c, xmenu.c, xsettings.c:
5467 Mark functions with DEFUE instead of DEFUN,
5468 if they are used in other modules.
5469 * buffer.c (Fset_buffer_major_mode, Fdelete_overlay): New forward
5470 decls for now-static functions.
5471 * buffer.h (Fdelete_overlay): Remove decl.
5472 * callproc.c (Fgetenv_internal): Mark as internal.
5473 * composite.c (Fremove_list_of_text_properties): Remove decl.
5474 (Fcomposition_get_gstring): New forward static decl.
5475 * composite.h (Fcomposite_get_gstring): Remove decl.
5476 * dired.c (Ffile_attributes): New forward static decl.
5477 * doc.c (Fdocumntation_property): New forward static decl.
5478 * eval.c (Ffetch_bytecode): New forward static decl.
5479 (Funintern): Remove extern decl; now in .h file where it belongs.
5480 * fileio.c (Fmake_symbolic_link): New forward static decl.
5481 * image.c (Finit_image_library): New forward static decl.
5482 * insdel.c (Fcombine_after_change_execute): Make forward decl static.
5483 * intervals.h (Fprevious_property_change):
5484 (Fremove_list_of_text_properties): Remove decls.
5485 * keyboard.c (Fthis_command_keys): Remove decl.
5486 (Fcommand_execute): New forward static decl.
5487 * keymap.c (Flookup_key): New forward static decl.
5488 (Fcopy_keymap): Now static.
5489 * keymap.h (Flookup_key): Remove decl.
5490 * process.c (Fget_process): New forward static decl.
5491 (Fprocess_datagram_address): Mark as internal.
5492 * syntax.c (Fsyntax_table_p): New forward static decl.
5493 (skip_chars): Remove duplicate decl.
5494 * textprop.c (Fprevious_property_change): New forward static decl.
5495 * window.c (Fset_window_fringes, Fset_window_scroll_bars):
5496 Now internal.
5497 (Fset_window_margins, Fset_window_vscroll): New forward static decls.
5498 * window.h (Fset_window_vscroll, Fset_window_margins): Remove decls.
5499
5500 * editfns.c (Fformat): Remove unreachable code.
5501
5502 2011-04-14 Andreas Schwab <schwab@linux-m68k.org>
5503
5504 * fileio.c (Finsert_file_contents): Fix typo in 2005-05-13
5505 change. (Bug#8496)
5506
5507 2011-04-13 Eli Zaretskii <eliz@gnu.org>
5508
5509 * xdisp.c (handle_invisible_prop): Don't call bidi_paragraph_init
5510 when at ZV. (Bug#8487)
5511
5512 2011-04-12 Andreas Schwab <schwab@linux-m68k.org>
5513
5514 * charset.c (Fclear_charset_maps): Use xfree instead of free.
5515 (Bug#8437)
5516 * keyboard.c (parse_tool_bar_item): Likewise.
5517 * sound.c (sound_cleanup, alsa_close): Likewise.
5518 * termcap.c (tgetent): Likewise.
5519 * xfns.c (x_default_font_parameter): Likewise.
5520 * xsettings.c (read_and_apply_settings): Likewise.
5521
5522 * alloc.c (overrun_check_malloc, overrun_check_realloc)
5523 (overrun_check_free): Protoize.
5524
5525 2011-04-12 Paul Eggert <eggert@cs.ucla.edu>
5526
5527 * sysdep.c (emacs_read, emacs_write): Check for negative sizes
5528 since callers should never pass a negative size.
5529 Change the signature to match that of plain 'read' and 'write'; see
5530 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00397.html>.
5531 * lisp.h: Update prototypes of emacs_write and emacs_read.
5532
5533 2011-04-11 Eli Zaretskii <eliz@gnu.org>
5534
5535 * xdisp.c (redisplay_window): Don't try to determine the character
5536 position of the scroll margin if the window start point w->startp
5537 is outside the buffer's accessible region. (Bug#8468)
5538
5539 2011-04-10 Eli Zaretskii <eliz@gnu.org>
5540
5541 Fix write-region and its subroutines for buffers > 2GB.
5542 * fileio.c (a_write, e_write): Modify declaration of arguments and
5543 local variables to support buffers larger than 2GB.
5544 (Fcopy_file): Use EMACS_INT for return value of emacs_read.
5545
5546 * sysdep.c (emacs_write, emacs_read): Use ssize_t for last
5547 argument, local variables, and return value.
5548
5549 * lisp.h: Update prototypes of emacs_write and emacs_read.
5550
5551 * sound.c (vox_write): Use ssize_t for return value of emacs_write.
5552
5553 2011-04-10 Paul Eggert <eggert@cs.ucla.edu>
5554
5555 * xdisp.c (vmessage): Use memchr, not strnlen, which some hosts lack.
5556
5557 Fix more problems found by GCC 4.6.0's static checks.
5558
5559 * xdisp.c (vmessage): Use a better test for character truncation.
5560
5561 * charset.c (load_charset_map): <, not <=, for optimization,
5562 and to avoid potential problems with integer overflow.
5563 * chartab.c (sub_char_table_set_range, char_table_set_range): Likewise.
5564 * casetab.c (set_identity, shuffle): Likewise.
5565 * editfns.c (Fformat): Likewise.
5566 * syntax.c (skip_chars): Likewise.
5567
5568 * xmenu.c (set_frame_menubar): Allocate smaller local vectors.
5569 This also lets GCC 4.6.0 generate slightly better loop code.
5570
5571 * callint.c (Fcall_interactively): <, not <=, for optimization.
5572 (Fcall_interactively): Count the number of arguments produced,
5573 not the number of arguments given. This is simpler and lets GCC
5574 4.6.0 generate slightly better code.
5575
5576 * ftfont.c: Distingish more carefully between FcChar8 and char.
5577 The previous code passed unsigned char * to a functions like
5578 strlen and xstrcasecmp that expect char *, which does not
5579 conform to the C standard.
5580 (get_adstyle_property, ftfont_pattern_entity): Use FcChar8 for
5581 arguments to FcPatternGetString, and explicitly cast FcChar8 * to
5582 char * when the C standard requires it.
5583
5584 * keyboard.c (read_char): Remove unused var.
5585
5586 * eval.c: Port to Windows vsnprintf (Bug#8435).
5587 Include <limits.h>.
5588 (SIZE_MAX): Define if the headers do not.
5589 (verror): Do not give up if vsnprintf returns a negative count.
5590 Instead, grow the buffer. This ports to Windows vsnprintf, which
5591 does not conform to C99. Problem reported by Eli Zaretskii.
5592 Also, simplify the allocation scheme, by avoiding the need for
5593 calling realloc, and removing the ALLOCATED variable.
5594
5595 * eval.c (verror): Initial buffer size is 4000 (not 200) bytes.
5596
5597 Remove invocations of doprnt, as Emacs now uses vsnprintf.
5598 But keep the doprint source code for now, as we might revamp it
5599 and use it again (Bug#8435).
5600 * lisp.h (doprnt): Remove.
5601 * Makefile.in (base_obj): Remove doprnt.o.
5602 * deps.mk (doprnt.o): Remove.
5603
5604 error: Print 32- and 64-bit integers portably (Bug#8435).
5605 Without this change, on typical 64-bit hosts error ("...%d...", N)
5606 was used to print both 32- and 64-bit integers N, which relied on
5607 undefined behavior.
5608 * lisp.h, src/m/amdx86-64.h, src/m/ia64.h, src/m/ibms390x.h (pEd):
5609 New macro.
5610 * lisp.h (error, verror): Mark as printf-like functions.
5611 * eval.c (verror): Use vsnprintf, not doprnt, to do the real work.
5612 Report overflow in size calculations when allocating printf buffer.
5613 Do not truncate output string at its first null byte.
5614 * xdisp.c (vmessage): Use vsnprintf, not doprnt, to do the real work.
5615 Truncate the output at a character boundary, since vsnprintf does not
5616 do that.
5617 * charset.c (check_iso_charset_parameter): Convert internal
5618 character to string before calling 'error', since %c now has the
5619 printf meaning.
5620 * coding.c (Fdecode_sjis_char, Fdecode_big5_char): Avoid int
5621 overflow when computing char to be passed to 'error'. Do not
5622 pass Lisp_Object to 'error'; pass the integer instead.
5623 * nsfns.m (Fns_do_applescript): Use int, not long, since it's
5624 formatted with plain %d.
5625
5626 * eval.c (internal_lisp_condition_case): Don't pass spurious arg.
5627
5628 * keyboard.c (access_keymap_keyremap): Print func name, not garbage.
5629
5630 * coding.c (Fdecode_sjis_char): Don't assume CODE fits in int.
5631
5632 * xterm.c (x_catch_errors): Remove duplicate declaration.
5633
5634 * term.c (maybe_fatal): Mark its 3rd arg as a printf format, too.
5635
5636 * xdisp.c, lisp.h (message_nolog): Remove; unused.
5637
5638 2011-04-10 Jim Meyering <meyering@redhat.com>
5639
5640 use ssize_t and size_t for read- and write-like emacs_gnutls_* functions
5641 * gnutls.c (emacs_gnutls_read): Adjust signature to be more read-like:
5642 return ssize_t not "int", and use size_t as the buffer length.
5643 (emacs_gnutls_write): Likewise, and make the buffer pointer "const".
5644 * gnutls.h: Update declarations.
5645 * process.c (read_process_output): Use ssize_t, to match.
5646 (send_process): Likewise.
5647
5648 2011-04-09 Chong Yidong <cyd@stupidchicken.com>
5649
5650 * image.c (Fimagemagick_types): Doc fix, and comment cleanup.
5651
5652 2011-04-09 Chong Yidong <cyd@stupidchicken.com>
5653
5654 * ftfont.c (get_adstyle_property, ftfont_pattern_entity):
5655 Use unsigned char, to match FcChar8 type definition.
5656
5657 * xterm.c (handle_one_xevent):
5658 * xmenu.c (create_and_show_popup_menu):
5659 * xselect.c (x_decline_selection_request)
5660 (x_reply_selection_request): Avoid type-punned deref of X events.
5661
5662 2011-04-09 Eli Zaretskii <eliz@gnu.org>
5663
5664 Fix some uses of `int' instead of EMACS_INT.
5665 * search.c (string_match_1, fast_string_match)
5666 (fast_c_string_match_ignore_case, fast_string_match_ignore_case)
5667 (scan_buffer, find_next_newline_no_quit)
5668 (find_before_next_newline, search_command, Freplace_match)
5669 (Fmatch_data): Make some `int' variables be EMACS_INT.
5670
5671 * xdisp.c (display_count_lines): 3rd argument and return value now
5672 EMACS_INT. All callers changed.
5673 (pint2hrstr): Last argument is now EMACS_INT.
5674
5675 * coding.c (detect_coding_utf_8, detect_coding_emacs_mule)
5676 (detect_coding_iso_2022, detect_coding_sjis, detect_coding_big5)
5677 (detect_coding_ccl, detect_coding_charset, decode_coding_utf_8)
5678 (decode_coding_utf_16, decode_coding_emacs_mule)
5679 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5)
5680 (decode_coding_ccl, decode_coding_charset)
5681 <consumed_chars, consumed_chars_base>: Declare EMACS_INT.
5682 (decode_coding_iso_2022, decode_coding_emacs_mule)
5683 (decode_coding_sjis, decode_coding_big5, decode_coding_charset)
5684 <char_offset, last_offset>: Declare EMACS_INT.
5685 (encode_coding_utf_8, encode_coding_utf_16)
5686 (encode_coding_emacs_mule, encode_invocation_designation)
5687 (encode_designation_at_bol, encode_coding_iso_2022)
5688 (encode_coding_sjis, encode_coding_big5, encode_coding_ccl)
5689 (encode_coding_raw_text, encode_coding_charset) <produced_chars>:
5690 Declare EMACS_INT.
5691 (ASSURE_DESTINATION): Declare more_bytes EMACS_INT.
5692 (encode_invocation_designation): Last argument P_NCHARS is now
5693 EMACS_INT.
5694 (decode_eol): Declare pos_byte, pos, and pos_end EMACS_INT.
5695 (produce_chars): from_nchars and to_nchars are now EMACS_INT.
5696
5697 * coding.h (struct coding_system) <head_ascii>: Declare EMACS_INT.
5698 All users changed.
5699
5700 * ccl.c (Fccl_execute_on_string): Declare some variables
5701 EMACS_INT.
5702
5703 2011-04-08 Samuel Thibault <sthibault@debian.org> (tiny change)
5704
5705 * term.c (init_tty): Fix incorrect ifdef placement (Bug#8450).
5706
5707 2011-03-19 Christoph Scholtes <cschol2112@googlemail.com>
5708
5709 * process.c (Fformat_network_address): Doc fix.
5710
5711 2011-04-08 T.V. Raman <tv.raman.tv@gmail.com> (tiny change)
5712
5713 * xml.c (parse_region): Avoid creating spurious whiespace nodes.
5714
5715 2011-04-08 Chong Yidong <cyd@stupidchicken.com>
5716
5717 * keyboard.c (read_char): Call Lisp function help-form-show,
5718 instead of using internal_with_output_to_temp_buffer.
5719 (Qhelp_form_show): New var.
5720 (syms_of_keyboard): Use DEFSYM macro.
5721
5722 * print.c (internal_with_output_to_temp_buffer): Function deleted.
5723
5724 * lisp.h (internal_with_output_to_temp_buffer): Remove prototype.
5725
5726 2011-04-06 Chong Yidong <cyd@stupidchicken.com>
5727
5728 * process.c (Flist_processes): Remove to Lisp.
5729 (list_processes_1): Delete.
5730
5731 2011-04-06 Eli Zaretskii <eliz@gnu.org>
5732
5733 * msdos.c (careadlinkat, careadlinkatcwd): MS-DOS replacements.
5734
5735 * w32.c (careadlinkat, careadlinkatcwd): New always-fail stubs.
5736
5737 2011-04-06 Paul Eggert <eggert@cs.ucla.edu>
5738
5739 Fix more problems found by GCC 4.6.0's static checks.
5740
5741 * xmenu.c (Fx_popup_dialog): Don't assume string is free of formats.
5742
5743 * menu.c (Fx_popup_menu): Don't assume error_name lacks printf formats.
5744
5745 * lisp.h (message, message_nolog, fatal): Mark as printf-like.
5746
5747 * xdisp.c (vmessage): Mark as a printf-like function.
5748
5749 * term.c (vfatal, maybe_fatal): Mark as printf-like functions.
5750
5751 * sound.c (sound_warning): Don't crash if arg contains a printf format.
5752
5753 * image.c (tiff_error_handler, tiff_warning_handler): Mark as
5754 printf-like functions.
5755 (tiff_load): Add casts to remove these marks before passing them
5756 to system-supplied API.
5757
5758 * eval.c (Fsignal): Remove excess argument to 'fatal'.
5759
5760 * coding.c (EMIT_ONE_BYTE, EMIT_TWO_BYTES): Use unsigned, not int.
5761 This avoids several warnings with gcc -Wstrict-overflow.
5762 (DECODE_COMPOSITION_RULE): If the rule is invalid, goto invalid_code
5763 directly, rather than having caller test rule sign. This avoids
5764 some unnecessary tests.
5765 * composite.h (COMPOSITION_ENCODE_RULE_VALID): New macro.
5766 (COMPOSITION_ENCODE_RULE): Arguments now must be valid. This
5767 affects only one use, in DECODE_COMPOSITION_RULE, which is changed.
5768
5769 * xfont.c (xfont_text_extents): Remove var that was set but not used.
5770 (xfont_open): Avoid unnecessary tests.
5771
5772 * composite.c (composition_gstring_put_cache): Use unsigned integer.
5773
5774 * composite.h, composite.c (composition_gstring_put_cache):
5775 Use EMACS_INT, not int, for length.
5776
5777 * composite.h (COMPOSITION_DECODE_REFS): New macro,
5778 breaking out part of COMPOSITION_DECODE_RULE.
5779 (COMPOSITION_DECODE_RULE): Use it.
5780 * composite.c (get_composition_id): Remove unused local vars,
5781 by using the new macro.
5782
5783 * textprop.c (set_text_properties_1): Change while to do-while,
5784 since the condition is always true at first.
5785
5786 * intervals.c (graft_intervals_into_buffer): Mark var as used.
5787 (interval_deletion_adjustment): Return unsigned value.
5788 All uses changed.
5789
5790 * process.c (list_processes_1, create_pty, read_process_output):
5791 (exec_sentinel): Remove vars that were set but not used.
5792 (create_pty): Remove unnecessary "volatile"s.
5793 (Fnetwork_interface_info): Avoid possibility of int overflow.
5794 (read_process_output): Do adaptive read buffering even if carryover.
5795 (read_process_output): Simplify nbytes computation if buffered.
5796
5797 * bytecode.c (exec_byte_code): Rename local to avoid shadowing.
5798
5799 * syntax.c (scan_words): Remove var that was set but not used.
5800 (update_syntax_table): Use unsigned instead of int.
5801
5802 * lread.c (lisp_file_lexically_bound_p): Use ints rather than endptrs.
5803 (lisp_file_lexically_bound_p, read1): Use unsigned instead of int.
5804 (safe_to_load_p): Make the end-of-loop test the inverse of the in-loop.
5805
5806 * print.c (print_error_message): Avoid int overflow.
5807
5808 * font.c (font_list_entities): Redo for clarity,
5809 so that reader need not know FONT_DPI_INDEX + 1 == FONT_SPACING_INDEX.
5810
5811 * font.c (font_find_for_lface, Ffont_get_glyphs): Remove unused vars.
5812 (font_score): Avoid potential overflow in diff calculation.
5813
5814 * fns.c (substring_both): Remove var that is set but not used.
5815 (sxhash): Redo loop for clarity and to avoid wraparound warning.
5816
5817 * eval.c (funcall_lambda): Rename local to avoid shadowing.
5818
5819 * alloc.c (mark_object_loop_halt, mark_object): Use size_t, not int.
5820 Otherwise, GCC 4.6.0 optimizes the loop check away since the check
5821 can always succeed if overflow has undefined behavior.
5822
5823 * search.c (boyer_moore, wordify): Remove vars set but not used.
5824 (wordify): Omit three unnecessary tests.
5825
5826 * indent.c (MULTIBYTE_BYTES_WIDTH): Don't compute wide_column.
5827 All callers changed. This avoids the need for an unused var.
5828
5829 * casefiddle.c (casify_region): Remove var that is set but not used.
5830
5831 * dired.c (file_name_completion): Remove var that is set but not used.
5832
5833 * fileio.c (Finsert_file_contents): Make EOF condition clearer.
5834
5835 * fileio.c (Finsert_file_contents): Avoid signed integer overflow.
5836 (Finsert_file_contents): Remove unnecessary code checking fd.
5837
5838 * minibuf.c (read_minibuf_noninteractive): Use size_t for sizes.
5839 Check for integer overflow on size calculations.
5840
5841 * buffer.c (Fprevious_overlay_change): Remove var that is set
5842 but not used.
5843
5844 * keyboard.c (menu_bar_items, read_char_minibuf_menu_prompt):
5845 Remove vars that are set but not used.
5846 (timer_check_2): Don't assume timer-list and idle-timer-list are lists.
5847 (timer_check_2): Mark vars as initialized.
5848
5849 * gtkutil.c (xg_get_file_with_chooser): Mark var as initialized.
5850
5851 * image.c (lookup_image): Remove var that is set but not used.
5852 (xbm_load): Use parse_p, for gcc -Werror=unused-but-set-variable.
5853
5854 * fontset.c (Finternal_char_font, Ffontset_info): Remove vars
5855 that are set but not used.
5856
5857 * xfns.c (make_invisible_cursor): Don't return garbage
5858 if XCreateBitmapFromData fails (Bug#8410).
5859
5860 * xselect.c (x_get_local_selection, x_handle_property_notify):
5861 Remove vars that are set but not used.
5862
5863 * xfns.c (x_create_tip_frame): Remove var that is set but not used.
5864 (make_invisible_cursor): Initialize a possibly-uninitialized variable.
5865
5866 * xterm.c (x_scroll_bar_to_input_event) [!USE_GTK]:
5867 Remove var that is set but not used.
5868 (scroll_bar_windows_size): Now size_t, not int.
5869 (x_send_scroll_bar_event): Use size_t, not int, for sizes.
5870 Check for overflow.
5871
5872 * xfaces.c (realize_named_face): Remove vars that are set but not used.
5873 (map_tty_color) [!defined MSDOS]: Likewise.
5874
5875 * term.c (tty_write_glyphs): Use size_t; this avoids overflow warning.
5876
5877 * coding.c: Remove vars that are set but not used.
5878 (DECODE_COMPOSITION_RULE): Remove 2nd arg, which is unused.
5879 All callers changed.
5880 (decode_coding_utf_8, decode_coding_utf_16 decode_coding_emacs_mule):
5881 (decode_coding_iso_2022, encode_coding_sjis, encode_coding_big5):
5882 (decode_coding_charset): Remove vars that are set but not used.
5883
5884 * bytecode.c (Fbyte_code) [!defined BYTE_CODE_SAFE]: Remove var
5885 that is set but not used.
5886
5887 * print.c (print_object): Remove var that is set but not used.
5888
5889 Replace 2 copies of readlink code with 1 gnulib version (Bug#8401).
5890 The gnulib version avoids calling malloc in the usual case,
5891 and on 64-bit hosts doesn't have some arbitrary 32-bit limits.
5892 * fileio.c (Ffile_symlink_p): Use emacs_readlink.
5893 * filelock.c (current_lock_owner): Likewise.
5894 * lisp.h (READLINK_BUFSIZE, emacs_readlink): New function.
5895 * sysdep.c: Include allocator.h, careadlinkat.h.
5896 (emacs_no_realloc_allocator): New static constant.
5897 (emacs_readlink): New function.
5898 * deps.mk (sysdep.o): Depend on ../lib/allocator.h and on
5899 ../lib/careadlinkat.h.
5900
5901 2011-04-04 Stefan Monnier <monnier@iro.umontreal.ca>
5902
5903 * keyboard.c (safe_run_hook_funcall): Fix last change (don't stop at the
5904 first non-nil return value).
5905
5906 2011-04-03 Jan Djärv <jan.h.d@swipnet.se>
5907
5908 * nsterm.m (ns_update_auto_hide_menu_bar): Define MAC_OS_X_VERSION_10_6
5909 if not defined (Bug#8403).
5910
5911 2011-04-02 Juanma Barranquero <lekktu@gmail.com>
5912
5913 * xdisp.c (display_count_lines): Remove parameter `start',
5914 unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
5915 (get_char_face_and_encoding): Remove parameter `multibyte_p',
5916 unused since 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
5917 (fill_stretch_glyph_string): Remove parameters `row' and `area',
5918 unused at least since Kim's GUI unification at 2003-03-16T20:45:46Z!storm@cua.dk
5919 and thereabouts. All callers changed.
5920 (get_per_char_metric): Remove parameter `f', unused since
5921 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
5922
5923 2011-04-02 Jim Meyering <meyering@redhat.com>
5924
5925 do not dereference NULL upon failed strdup
5926 * nsfont.m (ns_descriptor_to_entity): Use xstrdup, not strdup.
5927 (ns_get_family): Likewise.
5928
5929 2011-04-02 Juanma Barranquero <lekktu@gmail.com>
5930
5931 * eval.c (unwind_to_catch) [DEBUG_GCPRO]: Remove redundant assignment.
5932
5933 2011-04-02 Jan Djärv <jan.h.d@swipnet.se>
5934
5935 * nsterm.m (ns_update_auto_hide_menu_bar): Only for OSX 10.6 or
5936 later (Bug#8403).
5937
5938 2011-04-01 Stefan Monnier <monnier@iro.umontreal.ca>
5939
5940 Add lexical binding.
5941
5942 * window.c (Ftemp_output_buffer_show): New fun.
5943 (Fsave_window_excursion):
5944 * print.c (Fwith_output_to_temp_buffer): Move to subr.el.
5945
5946 * lread.c (lisp_file_lexically_bound_p): New function.
5947 (Fload): Bind Qlexical_binding.
5948 (readevalloop): Remove `evalfun' arg.
5949 Bind Qinternal_interpreter_environment.
5950 (Feval_buffer): Bind Qlexical_binding.
5951 (defvar_int, defvar_bool, defvar_lisp_nopro, defvar_kboard):
5952 Mark as dynamic.
5953 (syms_of_lread): Declare `lexical-binding'.
5954
5955 * lisp.h (struct Lisp_Symbol): New field `declared_special'.
5956
5957 * keyboard.c (eval_dyn): New fun.
5958 (menu_item_eval_property): Use it.
5959
5960 * image.c (parse_image_spec): Use Ffunctionp.
5961
5962 * fns.c (concat, mapcar1): Accept byte-code-functions.
5963
5964 * eval.c (Fsetq): Handle lexical vars.
5965 (Fdefun, Fdefmacro, Ffunction): Make closures when needed.
5966 (Fdefconst, Fdefvaralias, Fdefvar): Mark as dynamic.
5967 (FletX, Flet): Obey lexical binding.
5968 (Fcommandp): Handle closures.
5969 (Feval): New `lexical' arg.
5970 (eval_sub): New function extracted from Feval. Use it almost
5971 everywhere where Feval was used. Look up vars in lexical env.
5972 Handle closures.
5973 (Ffunctionp): Move from subr.el.
5974 (Ffuncall): Handle closures.
5975 (apply_lambda): Remove `eval_flags'.
5976 (funcall_lambda): Handle closures and new byte-code-functions.
5977 (Fspecial_variable_p): New function.
5978 (syms_of_eval): Initialize the Vinternal_interpreter_environment var,
5979 but without exporting it to Lisp.
5980
5981 * doc.c (Fdocumentation, store_function_docstring):
5982 * data.c (Finteractive_form): Handle closures.
5983
5984 * callint.c (Fcall_interactively): Preserve lexical-binding mode for
5985 interactive spec.
5986
5987 * bytecode.c (Bstack_ref, Bstack_set, Bstack_set2, BdiscardN):
5988 New byte-codes.
5989 (exec_byte_code): New function extracted from Fbyte_code to handle new
5990 calling convention for byte-code-functions. Add new byte-codes.
5991
5992 * buffer.c (defvar_per_buffer): Set new `declared_special' field.
5993
5994 * alloc.c (Fmake_symbol): Init new `declared_special' field.
5995
5996 2011-03-31 Juanma Barranquero <lekktu@gmail.com>
5997
5998 * xdisp.c (redisplay_internal): Fix prototype.
5999
6000 2011-03-31 Eli Zaretskii <eliz@gnu.org>
6001
6002 * xdisp.c (SCROLL_LIMIT): New macro.
6003 (try_scrolling): Use it when setting scroll_limit.
6004 Limit scrolling to 100 screen lines.
6005 (redisplay_window): Even when falling back on "recentering",
6006 position point in the window according to scroll-conservatively,
6007 scroll-margin, and scroll-*-aggressively variables. (Bug#6671)
6008
6009 (try_scrolling): When point is above the window, allow searching
6010 as far as scroll_max, or one screenful, to compute vertical
6011 distance from PT to the scroll margin position. This prevents
6012 try_scrolling from unnecessarily failing when
6013 scroll-conservatively is set to a value slightly larger than the
6014 window height. Clean up the case of PT below the margin at bottom
6015 of window: scroll_max can no longer be INT_MAX. When aggressive
6016 scrolling is in use, don't let point enter the opposite scroll
6017 margin as result of the scroll.
6018 (syms_of_xdisp) <scroll-conservatively>: Document the
6019 threshold of 100 lines for never-recentering scrolling.
6020
6021 2011-03-31 Juanma Barranquero <lekktu@gmail.com>
6022
6023 * dispextern.h (move_it_by_lines):
6024 * xdisp.c (move_it_by_lines): Remove parameter `need_y_p', unused
6025 since 2000-12-29T14:24:09Z!gerd@gnu.org. All callers changed.
6026 (message_log_check_duplicate): Remove parameters `prev_bol' and
6027 `this_bol', unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
6028 (redisplay_internal): Remove parameter `preserve_echo_area',
6029 unused since 1999-07-21T21:43:52Z!gerd@gnu.org. All callers changed.
6030
6031 * indent.c (Fvertical_motion):
6032 * window.c (window_scroll_pixel_based, Frecenter):
6033 Don't pass `need_y_p' to `move_it_by_lines'.
6034
6035 2011-03-30 Stefan Monnier <monnier@iro.umontreal.ca>
6036
6037 * eval.c (struct backtrace): Don't cheat with negative numbers, but do
6038 steal a few bits to be more compact.
6039 (interactive_p, Fbacktrace, Fbacktrace_frame, mark_backtrace):
6040 Remove unneeded casts.
6041
6042 * bytecode.c (Fbyte_code): CAR and CDR can GC.
6043
6044 2011-03-30 Zachary Kanfer <zkanfer@gmail.com> (tiny change)
6045
6046 * keyboard.c (Fexecute_extended_command): Do log the "suggest key
6047 binding" message (bug#7967).
6048
6049 2011-03-30 Paul Eggert <eggert@cs.ucla.edu>
6050
6051 Fix more problems found by GCC 4.6.0's static checks.
6052
6053 * unexelf.c (unexec) [! (defined _SYSTYPE_SYSV || defined __sgi)]:
6054 Remove unused local var.
6055
6056 * editfns.c (Fmessage_box): Remove unused local var.
6057
6058 * xdisp.c (try_window_reusing_current_matrix, x_produce_glyphs):
6059 (note_mode_line_or_margin_highlight, note_mouse_highlight):
6060 Omit unused local vars.
6061 * window.c (shrink_windows): Omit unused local var.
6062 * menu.c (digest_single_submenu): Omit unused local var.
6063 * dispnew.c (update_window) [PERIODIC_PREEMPTION_CHECKING]:
6064 Omit unused local var.
6065
6066 * keyboard.c (parse_modifiers_uncached, parse_modifiers):
6067 Don't assume string length fits in int.
6068 (keyremap_step, read_key_sequence): Use size_t for sizes.
6069 (read_key_sequence): Don't check last_real_key_start redundantly.
6070
6071 * callproc.c (Fcall_process, Fcall_process_region): Use SAFE_ALLOCA
6072 instead of alloca (Bug#8344).
6073
6074 * eval.c (Fbacktrace): Don't assume nargs fits in int.
6075 (Fbacktrace_frame): Don't assume nframes fits in int.
6076
6077 * syntax.c (scan_sexps_forward): Avoid pointer wraparound.
6078
6079 * xterm.c (x_make_frame_visible, same_x_server): Redo to avoid overflow
6080 concerns.
6081
6082 * term.c (produce_glyphless_glyph): Remove unnecessary test.
6083
6084 * cm.c (calccost): Turn while-do into do-while, for clarity.
6085
6086 * keyboard.c (syms_of_keyboard): Use the same style as later
6087 in this function when indexing through an array. This also
6088 works around GCC bug 48267.
6089
6090 * image.c (tiff_load): Fix off-by-one image count (Bug#8336).
6091
6092 * xselect.c (x_check_property_data): Return correct size (Bug#8335).
6093
6094 * chartab.c (sub_char_table_ref_and_range): Redo for slight
6095 efficiency gain, and to bypass a gcc -Wstrict-overflow warning.
6096
6097 * keyboard.c, keyboard.h (num_input_events): Now size_t.
6098 This avoids undefined behavior on integer overflow, and is a bit
6099 more convenient anyway since it is compared to a size_t variable.
6100
6101 Variadic C functions now count arguments with size_t, not int.
6102 This avoids an unnecessary limitation on 64-bit machines, which
6103 caused (substring ...) to crash on large vectors (Bug#8344).
6104 * lisp.h (struct Lisp_Subr.function.aMANY): Now takes size_t, not int.
6105 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call): Likewise.
6106 All variadic functions and their callers changed accordingly.
6107 (struct gcpro.nvars): Now size_t, not int. All uses changed.
6108 * data.c (arith_driver, float_arith_driver): Likewise.
6109 * editfns.c (general_insert_function): Likewise.
6110 * eval.c (struct backtrace.nargs, interactive_p)
6111 (internal_condition_case_n, run_hook_with_args, apply_lambda)
6112 (funcall_lambda, mark_backtrace): Likewise.
6113 * fns.c (concat): Likewise.
6114 * frame.c (x_set_frame_parameters): Likewise.
6115 * fns.c (get_key_arg): Now accepts and returns size_t, and returns
6116 0 if not found, not -1. All callers changed.
6117
6118 * alloc.c (garbage_collect): Don't assume stack size fits in int.
6119 (stack_copy_size): Now size_t, not int.
6120 (stack_copy, stack_copy_size): Define only if MAX_SAVE_STACK > 0.
6121
6122 2011-03-28 Juanma Barranquero <lekktu@gmail.com>
6123
6124 * coding.c (encode_designation_at_bol): Remove parameter `charbuf_end',
6125 unused since 2002-03-01T01:17:24Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
6126 All callers changed.
6127
6128 * lisp.h (multibyte_char_to_unibyte):
6129 * character.c (multibyte_char_to_unibyte): Remove parameter `rev_tbl',
6130 unused since 2002-03-01T01:16:34Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
6131 * character.h (CHAR_TO_BYTE8):
6132 * cmds.c (internal_self_insert):
6133 * editfns.c (general_insert_function):
6134 * keymap.c (push_key_description):
6135 * search.c (Freplace_match):
6136 * xdisp.c (message_dolog, set_message_1): All callers changed.
6137
6138 2011-03-28 Stefan Monnier <monnier@iro.umontreal.ca>
6139
6140 * keyboard.c (safe_run_hook_funcall): New function.
6141 (safe_run_hooks_1, safe_run_hooks_error, safe_run_hooks): On error,
6142 don't set the hook to nil, but remove the offending function instead.
6143 (Qcommand_hook_internal): Remove, unused.
6144 (syms_of_keyboard): Don't initialize Qcommand_hook_internal nor define
6145 Vcommand_hook_internal.
6146
6147 * eval.c (enum run_hooks_condition): Remove.
6148 (funcall_nil, funcall_not): New functions.
6149 (run_hook_with_args): Call each function through a `funcall' argument.
6150 Remove `cond' argument, now redundant.
6151 (Frun_hooks, Frun_hook_with_args, Frun_hook_with_args_until_success)
6152 (Frun_hook_with_args_until_failure): Adjust accordingly.
6153 (run_hook_wrapped_funcall, Frun_hook_wrapped): New functions.
6154
6155 2011-03-28 Juanma Barranquero <lekktu@gmail.com>
6156
6157 * dispextern.h (string_buffer_position): Remove declaration.
6158
6159 * print.c (strout): Remove parameter `multibyte', unused since
6160 1999-08-21T19:30:21Z!gerd@gnu.org. All callers changed.
6161
6162 * search.c (boyer_moore): Remove parameters `len', `pos' and `lim',
6163 never used since function introduction in 1998-02-08T21:33:56Z!rms@gnu.org.
6164 All callers changed.
6165
6166 * w32.c (_wsa_errlist): Use braces for struct initializers.
6167
6168 * xdisp.c (string_buffer_position_lim): Remove parameter `w',
6169 never used since function introduction in 2001-03-09T18:41:50Z!gerd@gnu.org.
6170 All callers changed.
6171 (string_buffer_position): Likewise. Also, make static (it's never
6172 used outside xdisp.c).
6173 (cursor_row_p): Remove parameter `w', unused since
6174 2000-10-17T16:08:57Z!gerd@gnu.org. All callers changed.
6175 (decode_mode_spec): Remove parameter `precision', introduced during
6176 Gerd Moellmann's rewrite at 1999-07-21T21:43:52Z!gerd@gnu.org, but never used.
6177 All callers changed.
6178
6179 2011-03-27 Jan Djärv <jan.h.d@swipnet.se>
6180
6181 * nsterm.m (syms_of_nsterm): Use doc: for ns-auto-hide-menu-bar.
6182
6183 2011-03-27 Anders Lindgren <andlind@gmail.com>
6184
6185 * nsterm.m (ns_menu_bar_is_hidden): New variable.
6186 (ns_constrain_all_frames, ns_menu_bar_should_be_hidden)
6187 (ns_update_auto_hide_menu_bar): New functions.
6188 (ns_update_begin): Call ns_update_auto_hide_menu_bar.
6189 (applicationDidBecomeActive): Call ns_update_auto_hide_menu_bar and
6190 ns_constrain_all_frames.
6191 (constrainFrameRect): Return at once if ns_menu_bar_should_be_hidden.
6192 (syms_of_nsterm): DEFVAR ns-auto-hide-menu-bar, init to Qnil.
6193
6194 2011-03-27 Jan Djärv <jan.h.d@swipnet.se>
6195
6196 * nsmenu.m (runDialogAt): Remove argument to timer_check.
6197
6198 2011-03-27 Glenn Morris <rgm@gnu.org>
6199
6200 * syssignal.h: Replace RETSIGTYPE with void.
6201 * atimer.c, data.c, dispnew.c, emacs.c, floatfns.c, keyboard.c:
6202 * keyboard.h, lisp.h, process.c, sysdep.c, xterm.c:
6203 Replace SIGTYPE with void everywhere.
6204 * s/usg5-4-common.h (SIGTYPE): Remove definition.
6205 * s/template.h (SIGTYPE): Remove commented out definition.
6206
6207 2011-03-26 Eli Zaretskii <eliz@gnu.org>
6208
6209 * xdisp.c (redisplay_window): Don't check buffer's clip_changed
6210 flag as a prerequisite for invoking try_scrolling. (Bug#6671)
6211
6212 2011-03-26 Juanma Barranquero <lekktu@gmail.com>
6213
6214 * w32.c (read_unc_volume): Use parameter `henum', instead of
6215 global variable `wget_enum_handle'.
6216
6217 * keymap.c (describe_vector): Remove parameters `indices' and
6218 `char_table_depth', unused since 2002-03-01T01:43:26Z!handa@m17n.org.
6219 (describe_map, Fdescribe_vector): Adjust calls to `describe_vector'.
6220
6221 * keyboard.h (timer_check, show_help_echo): Remove unused parameters.
6222
6223 * keyboard.c (timer_check): Remove parameter `do_it_now',
6224 unused since 1996-04-12T06:01:29Z!rms@gnu.org.
6225 (show_help_echo): Remove parameter `ok_to_overwrite_keystroke_echo',
6226 unused since 2008-04-19T19:30:53Z!monnier@iro.umontreal.ca.
6227
6228 * keyboard.c (read_char):
6229 * w32menu.c (w32_menu_display_help):
6230 * xmenu.c (show_help_event, menu_help_callback):
6231 Adjust calls to `show_help_echo'.
6232
6233 * gtkutil.c (xg_maybe_add_timer):
6234 * keyboard.c (readable_events):
6235 * process.c (wait_reading_process_output):
6236 * xmenu.c (x_menu_wait_for_event): Adjust calls to `timer_check'.
6237
6238 * insdel.c (adjust_markers_gap_motion):
6239 Remove; no-op since 1998-01-02T21:29:48Z!rms@gnu.org.
6240 (gap_left, gap_right): Don't call it.
6241
6242 2011-03-25 Chong Yidong <cyd@stupidchicken.com>
6243
6244 * xdisp.c (handle_fontified_prop): Discard changes to clip_changed
6245 incurred during fontification.
6246
6247 2011-03-25 Juanma Barranquero <lekktu@gmail.com>
6248
6249 * buffer.c (defvar_per_buffer): Remove unused parameter `doc'.
6250 (DEFVAR_PER_BUFFER): Don't pass it.
6251
6252 * dispnew.c (row_equal_p, add_row_entry): Remove unused parameter `w'.
6253 (scrolling_window): Don't pass it.
6254
6255 2011-03-25 Juanma Barranquero <lekktu@gmail.com>
6256
6257 * dispextern.h (glyph_matric): Use #if GLYPH_DEBUG, not #ifdef.
6258
6259 * fileio.c (check_executable) [DOS_NT]: Remove unused variables `len'
6260 and `suffix'.
6261 (Fset_file_selinux_context) [HAVE_LIBSELINUX]: Move here declaration
6262 of variables specific to SELinux and computation of `encoded_absname'.
6263
6264 * image.c (XPutPixel): Remove unused variable `height'.
6265
6266 * keyboard.c (make_lispy_event): Remove unused variable `hpos'.
6267
6268 * unexw32.c (get_section_info): Remove unused variable `section'.
6269
6270 * w32.c (stat): Remove unused variables `drive_root' and `devtype'.
6271 (system_process_attributes): Remove unused variable `sess'.
6272 (sys_read): Remove unused variable `err'.
6273
6274 * w32fns.c (top): Wrap variables with #if GLYPH_DEBUG, not #ifdef.
6275 (w32_wnd_proc): Remove unused variable `isdead'.
6276 (unwind_create_frame): Use #if GLYPH_DEBUG, not #ifdef.
6277 (Fx_server_max_request_size): Remove unused variable `dpyinfo'.
6278 (x_create_tip_frame): Remove unused variable `tem'.
6279
6280 * w32inevt.c (w32_console_read_socket):
6281 Remove unused variable `no_events'.
6282
6283 * w32term.c (x_draw_composite_glyph_string_foreground):
6284 Remove unused variable `width'.
6285
6286 2011-03-24 Juanma Barranquero <lekktu@gmail.com>
6287
6288 * w32term.c (x_set_glyph_string_clipping):
6289 Don't pass uninitialized region to CombineRgn.
6290
6291 2011-03-23 Juanma Barranquero <lekktu@gmail.com>
6292
6293 * w32fns.c (x_set_menu_bar_lines): Remove unused variable `olines'.
6294 (w32_wnd_proc): Pass NULL to Windows API, not uninitialized buffer.
6295 (Fx_close_connection): Remove unused variable `i'.
6296
6297 * w32font.c (w32font_draw): Return number of glyphs.
6298 (w32font_open_internal): Remove unused variable `i'.
6299 (w32font_driver): Add missing initializer.
6300
6301 * w32menu.c (utf8to16): Remove unused variable `utf16'.
6302 (fill_in_menu): Remove unused variable `items_added'.
6303
6304 * w32term.c (last_mouse_press_frame): Remove static global variable.
6305 (w32_clip_to_row): Remove unused variable `f'.
6306 (x_delete_terminal): Remove unused variable `i'.
6307
6308 * w32uniscribe.c (uniscribe_shape): Remove unused variable `nclusters'.
6309 (NOTHING): Remove unused static global variable.
6310 (uniscribe_check_otf): Remove unused variable `table'.
6311 (uniscribe_font_driver): Add missing initializers.
6312
6313 2011-03-23 Julien Danjou <julien@danjou.info>
6314
6315 * term.c (Fsuspend_tty, Fresume_tty):
6316 * minibuf.c (read_minibuf, run_exit_minibuf_hook):
6317 * window.c (temp_output_buffer_show):
6318 * insdel.c (signal_before_change):
6319 * frame.c (Fhandle_switch_frame):
6320 * fileio.c (Fdo_auto_save):
6321 * emacs.c (Fkill_emacs):
6322 * editfns.c (save_excursion_restore):
6323 * cmds.c (internal_self_insert):
6324 * callint.c (Fcall_interactively):
6325 * buffer.c (Fkill_all_local_variables):
6326 * keyboard.c (Fcommand_execute, Fsuspend_emacs, safe_run_hooks_1):
6327 Use Frun_hooks.
6328 (command_loop_1): Use Frun_hooks. Call safe_run_hooks
6329 unconditionnaly since it does the check itself.
6330
6331 2011-03-23 Paul Eggert <eggert@cs.ucla.edu>
6332
6333 Fix more problems found by GCC 4.5.2's static checks.
6334
6335 * coding.c (encode_coding_raw_text): Avoid unnecessary test
6336 the first time through the loop, since we know p0 < p1 then.
6337 This also avoids a gcc -Wstrict-overflow warning.
6338
6339 * lisp.h (SAFE_ALLOCA, SAFE_ALLOCA_LISP): Avoid 'int' overflow
6340 leading to a memory leak, possible in functions like
6341 load_charset_map_from_file that can allocate an unbounded number
6342 of objects (Bug#8318).
6343
6344 * xmenu.c (set_frame_menubar): Use EMACS_UINT, not int, for indexes
6345 that could (at least in theory) be that large.
6346
6347 * xdisp.c (message_log_check_duplicate): Return unsigned long, not int.
6348 This is less likely to overflow, and avoids undefined behavior if
6349 overflow does occur. All callers changed. Use strtoul to scan
6350 for the unsigned long integer.
6351 (pint2hrstr): Simplify and tune code slightly.
6352 This also avoids a (bogus) GCC warning with gcc -Wstrict-overflow.
6353
6354 * scroll.c (do_scrolling): Work around GCC bug 48228.
6355 See <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=48228>.
6356
6357 * frame.c (Fmodify_frame_parameters): Simplify loop counter.
6358 This also avoids a warning with gcc -Wstrict-overflow.
6359 (validate_x_resource_name): Simplify count usage.
6360 This also avoids a warning with gcc -Wstrict-overflow.
6361
6362 * fileio.c (Fcopy_file): Report error if fchown or fchmod
6363 fail (Bug#8306).
6364
6365 * emacs.c (Fdaemon_initialized): Do not ignore I/O errors (Bug#8303).
6366
6367 * process.c (Fmake_network_process): Use socklen_t, not int,
6368 where POSIX says socklen_t is required in portable programs.
6369 This fixes a porting bug on hosts like 64-bit HP-UX, where
6370 socklen_t is wider than int (Bug#8277).
6371 (Fmake_network_process, server_accept_connection):
6372 (wait_reading_process_output, read_process_output):
6373 Likewise.
6374
6375 * process.c: Rename or move locals to avoid shadowing.
6376 (list_processes_1, Fmake_network_process):
6377 (read_process_output_error_handler, exec_sentinel_error_handler):
6378 Rename or move locals.
6379 (Fmake_network_process): Define label "retry_connect" only if needed.
6380 (Fnetwork_interface_info): Fix pointer signedness.
6381 (process_send_signal): Add cast to avoid pointer signedness problem.
6382 (FIRST_PROC_DESC, IF_NON_BLOCKING_CONNECT): Remove unused macros.
6383 (create_process): Use 'volatile' to avoid vfork clobbering (Bug#8298).
6384
6385 Make tparam.h and terminfo.c consistent.
6386 * cm.c (tputs, tgoto, BC, UP): Remove extern decls.
6387 Include tparam.h instead, since it declares them.
6388 * cm.h (PC): Remove extern decl; tparam.h now does this.
6389 * deps.mk (cm.o, terminfo.o): Depend on tparam.h.
6390 * terminfo.c: Include tparam.h, to check interfaces.
6391 (tparm): Make 1st arg a const pointer in decl. Put it at top level.
6392 (tparam): Adjust signature to match interface in tparam.h;
6393 this removes some undefined behavior. Check that outstring and len
6394 are zero, which they always are with Emacs.
6395 * tparam.h (PC, BC, UP): New extern decls.
6396
6397 * xftfont.c (xftfont_shape): Now static, and defined only if needed.
6398 (xftfont_open): Rename locals to avoid shadowing.
6399
6400 * ftfont.c (ftfont_resolve_generic_family): Fix pointer signedness.
6401 (ftfont_otf_capability, ftfont_shape): Omit decls if not needed.
6402 (OTF_TAG_SYM): Omit macro if not needed.
6403 (ftfont_list): Remove unused local.
6404 (get_adstyle_property, ftfont_pattern_entity):
6405 (ftfont_lookup_cache, ftfont_open, ftfont_anchor_point):
6406 Rename locals to avoid shadowing.
6407
6408 * xfont.c (xfont_list_family): Mark var as initialized.
6409
6410 * xml.c (make_dom): Now static.
6411
6412 * composite.c (composition_compute_stop_pos): Rename local to
6413 avoid shadowing.
6414 (composition_reseat_it): Remove unused locals.
6415 (find_automatic_composition, composition_adjust_point): Likewise.
6416 (composition_update_it): Mark var as initialized.
6417 (find_automatic_composition): Mark vars as initialized,
6418 with a FIXME (Bug#8290).
6419
6420 character.h: Rename locals to avoid shadowing.
6421 * character.h (PREV_CHAR_BOUNDARY, FETCH_STRING_CHAR_ADVANCE):
6422 (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE, FETCH_CHAR_ADVANCE):
6423 (FETCH_CHAR_ADVANCE_NO_CHECK, INC_POS, DEC_POS, BUF_INC_POS):
6424 (BUF_DEC_POS): Be more systematic about renaming local temporaries
6425 to avoid shadowing.
6426
6427 * textprop.c (property_change_between_p): Remove; unused.
6428
6429 * intervals.c (interval_start_pos): Now static.
6430
6431 * intervals.h (CHECK_TOTAL_LENGTH): Avoid empty "else".
6432
6433 * atimer.c (start_atimer, append_atimer_lists, set_alarm):
6434 Rename locals to avoid shadowing.
6435
6436 * sound.c (wav_play, au_play, Fplay_sound_internal):
6437 Fix pointer signedness.
6438 (alsa_choose_format): Remove unused local var.
6439 (wav_play): Initialize a variable to 0, to prevent undefined
6440 behavior (Bug#8278).
6441
6442 * region-cache.c (insert_cache_boundary): Redo var to avoid shadowing.
6443
6444 * region-cache.h (pp_cache): New decl, for gcc -Wmissing-prototypes.
6445
6446 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork
6447 clobbering (Bug#8298).
6448 * sysdep.c (sys_subshell): Likewise.
6449 Previously, the sys_subshell 'volatile' was incorrectly IF_LINTted out.
6450
6451 * lisp.h (child_setup): Now NO_RETURN unless DOS_NT.
6452 This should get cleaned up, so that child_setup has the
6453 same signature on all platforms.
6454
6455 * callproc.c (call_process_cleanup): Now static.
6456 (relocate_fd): Rename locals to avoid shadowing.
6457
6458 2011-03-22 Chong Yidong <cyd@stupidchicken.com>
6459
6460 * xterm.c (x_clear_frame): Remove XClearWindow call. This appears
6461 not to be necessary, and produces flickering.
6462
6463 2011-03-20 Glenn Morris <rgm@gnu.org>
6464
6465 * config.in: Remove file.
6466
6467 2011-03-20 Juanma Barranquero <lekktu@gmail.com>
6468
6469 * minibuf.c (Vcompleting_read_function): Don't declare, global variables
6470 are now in src/globals.h.
6471 (syms_of_minibuf): Remove spurious & from previous change.
6472
6473 2011-03-20 Leo <sdl.web@gmail.com>
6474
6475 * minibuf.c (completing-read-function): New variable.
6476 (completing-read-default): Rename from completing-read.
6477 (completing-read): Call completing-read-function.
6478
6479 2011-03-19 Juanma Barranquero <lekktu@gmail.com>
6480
6481 * xfaces.c (Fx_load_color_file):
6482 Read color file from absolute filename (bug#8250).
6483
6484 2011-03-19 Juanma Barranquero <lekktu@gmail.com>
6485
6486 * makefile.w32-in: Update dependencies.
6487
6488 2011-03-17 Eli Zaretskii <eliz@gnu.org>
6489
6490 * makefile.w32-in ($(BLD)/unexw32.$(O)): Depend on $(SRC)/unexec.h.
6491
6492 2011-03-17 Paul Eggert <eggert@cs.ucla.edu>
6493
6494 Fix more problems found by GCC 4.5.2's static checks.
6495
6496 * process.c (make_serial_process_unwind, send_process_trap):
6497 (sigchld_handler): Now static.
6498
6499 * process.c (allocate_pty): Let PTY_ITERATION declare iteration vars.
6500 That way, the code declares only the vars that it needs.
6501 * s/aix4-2.h (PTY_ITERATION): Declare iteration vars.
6502 * s/cygwin.h (PTY_ITERATION): Likewise.
6503 * s/darwin.h (PTY_ITERATION): Likewise.
6504 * s/gnu-linux.h (PTY_ITERATION): Likewise.
6505
6506 * s/irix6-5.h (PTY_OPEN): Declare stb, to loosen coupling.
6507 * process.c (allocate_pty): Don't declare stb unless it's needed.
6508
6509 * bytecode.c (MAYBE_GC): Rewrite so as not to use empty "else".
6510 (CONSTANTLIM): Remove; unused.
6511 (METER_CODE, Bscan_buffer, Bread_char, Bset_mark):
6512 Define only if needed.
6513
6514 * unexelf.c (unexec): Name an expression,
6515 to avoid gcc -Wbad-function-cast warning.
6516 Use a different way to cause a compilation error if anyone uses
6517 n rather than nn, a way that does not involve shadowing.
6518 (ELF_BSS_SECTION_NAME, OLD_PROGRAM_H): Remove; unused.
6519
6520 * deps.mk (unexalpha.o): Remove; unused.
6521
6522 New file unexec.h, the (simple) interface for unexec (Bug#8267).
6523 * unexec.h: New file.
6524 * deps.mk (emacs.o, unexaix.o, unexcw.o, unexcoff.o, unexelf.o):
6525 (unexhp9k800.o, unexmacosx.o, unexsol.o, unexw32.o):
6526 Depend on unexec.h.
6527 * emacs.c [!defined CANNOT_DUMP]: Include unexec.h.
6528 * unexaix.c, unexcoff.c, unexcw.c, unexelf.c, unexhp9k800.c:
6529 * unexmacosx.c, unexsol.c, unexw32.c: Include unexec.h.
6530 Change as necessary to match prototype in unexec.h.
6531
6532 * syntax.c (Fforward_comment, scan_lists): Rename locals to avoid
6533 shadowing.
6534 (back_comment, skip_chars): Mark vars as initialized.
6535
6536 * character.h (FETCH_STRING_CHAR_ADVANCE_NO_CHECK, BUF_INC_POS):
6537 Rename locals to avoid shadowing.
6538
6539 * lread.c (read1): Rewrite so as not to use empty "else".
6540 (Fload, readevalloop, read1): Rename locals to avoid shadowing.
6541
6542 * print.c (Fredirect_debugging_output): Fix pointer signedess.
6543
6544 * lisp.h (debug_output_compilation_hack): Add decl here, to avoid
6545 warning when compiling print.c.
6546
6547 * font.c (font_unparse_fcname): Abort in an "impossible" situation
6548 instead of using an uninitialized var.
6549 (font_sort_entities): Mark var as initialized.
6550
6551 * character.h (FETCH_CHAR_ADVANCE): Rename locals to avoid shadowing.
6552
6553 * font.c (font_unparse_xlfd): Don't mix pointers to variables with
6554 pointers to constants.
6555 (font_parse_fcname): Remove unused vars.
6556 (font_delete_unmatched): Now static.
6557 (font_get_spec): Remove; unused.
6558 (font_style_to_value, font_prop_validate_style, font_unparse_fcname):
6559 (font_update_drivers, Ffont_get_glyphs, font_add_log):
6560 Rename or move locals to avoid shadowing.
6561
6562 * fns.c (require_nesting_list, require_unwind): Now static.
6563 (Ffillarray): Rename locals to avoid shadowing.
6564
6565 * floatfns.c (domain_error2): Define only if needed.
6566 (Ffrexp, Fldexp): Rename locals to avoid shadowing.
6567
6568 * alloc.c (mark_backtrace): Move decl from here ...
6569 * lisp.h: ... to here, so that it can be checked.
6570
6571 * eval.c (call_debugger, do_debug_on_call, grow_specpdl): Now static.
6572 (Fdefvar): Rewrite so as not to use empty "else".
6573 (lisp_indirect_variable): Name an expression,
6574 to avoid gcc -Wbad-function-cast warning.
6575 (Fdefvar): Rename locals to avoid shadowing.
6576
6577 * callint.c (quotify_arg, quotify_args): Now static.
6578 (Fcall_interactively): Rename locals to avoid shadowing.
6579 Use const pointer when appropriate.
6580
6581 * lisp.h (get_system_name, get_operating_system_release):
6582 Move decls here, to check interfaces.
6583 * process.c (get_operating_system_release): Move decl to lisp.h.
6584 * xrdb.c (get_system_name): Likewise.
6585 * editfns.c (init_editfns, Fuser_login_name, Fuser_uid):
6586 (Fuser_real_uid, Fuser_full_name): Remove unnecessary casts,
6587 some of which prompt warnings from gcc -Wbad-function-cast.
6588 (Fformat_time_string, Fencode_time, Finsert_char):
6589 (Ftranslate_region_internal, Fformat):
6590 Rename or remove local vars to avoid shadowing.
6591 (Ftranslate_region_internal): Mark var as initialized.
6592
6593 * doc.c (Fdocumentation, Fsnarf_documentation): Move locals to
6594 avoid shadowing.
6595
6596 * lisp.h (eassert): Check that the argument compiles, even if
6597 ENABLE_CHECKING is not defined.
6598
6599 * data.c (Findirect_variable): Name an expression, to avoid
6600 gcc -Wbad-function-cast warning.
6601 (default_value, arithcompare, arith_driver, arith_error): Now static.
6602 (store_symval_forwarding): Rename local to avoid shadowing.
6603 (Fmake_variable_buffer_local, Fmake_local_variable):
6604 Mark variables as initialized.
6605 (do_blv_forwarding, do_symval_forwarding): Remove; unused.
6606
6607 * alloc.c (check_cons_list): Do not define unless GC_CHECK_CONS_LIST.
6608 (Fmake_vector, Fvector, Fmake_byte_code, Fgarbage_collect):
6609 Rename locals to avoid shadowing.
6610 (mark_stack): Move local variables into the #ifdef region where
6611 they're used.
6612 (BLOCK_INPUT_ALLOC, UNBLOCK_INPUT_ALLOC): Define only if
6613 ! defined SYSTEM_MALLOC && ! defined SYNC_INPUT, as they are not
6614 needed otherwise.
6615 (CHECK_ALLOCATED): Define only if GC_CHECK_MARKED_OBJECTS.
6616 (GC_STRING_CHARS): Remove; not used.
6617 (Fmemory_limit): Cast sbrk's returned value to char *.
6618
6619 * lisp.h (check_cons_list): Declare if GC_CHECK_CONS_LIST; this
6620 avoids undefined behavior in theory.
6621
6622 * regex.c (IF_LINT): Add defn, for benefit of ../lib-src.
6623
6624 Use functions, not macros, for up- and down-casing (Bug#8254).
6625 * buffer.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
6626 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Remove. All callers changed
6627 to use the following functions instead of these macros.
6628 (downcase): Adjust to lack of DOWNCASE_TABLE. Return int, not
6629 EMACS_INT, since callers assume the returned value fits in int.
6630 (upcase1): Likewise, for UPCASE_TABLE.
6631 (uppercasep, lowercasep, upcase): New static inline functions.
6632 * editfns.c (Fchar_equal): Remove no-longer-needed workaround for
6633 the race-condition problem in the old DOWNCASE.
6634
6635 * regex.c (CHARSET_LOOKUP_RANGE_TABLE_RAW, POP_FAILURE_REG_OR_COUNT):
6636 Rename locals to avoid shadowing.
6637 (regex_compile, re_match_2_internal): Move locals to avoid shadowing.
6638 (regex_compile, re_search_2, re_match_2_internal):
6639 Remove unused local vars.
6640 (FREE_VAR): Rewrite so as not to use empty "else",
6641 which gcc can warn about.
6642 (regex_compile, re_match_2_internal): Mark locals as initialized.
6643 (RETALLOC_IF): Define only if needed.
6644 (WORDCHAR_P): Likewise. This one is never needed, but is used
6645 only in a comment talking about a compiler bug, so put inside
6646 the #if 0 of that comment.
6647 (CHARSET_LOOKUP_BITMAP, FAIL_STACK_FULL, RESET_FAIL_STACK):
6648 (PUSH_FAILURE_ELT, BUF_PUSH_3, STOP_ADDR_VSTRING):
6649 Remove; unused.
6650
6651 * search.c (boyer_moore): Rename locals to avoid shadowing.
6652 * character.h (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE):
6653 (PREV_CHAR_BOUNDARY): Likewise.
6654
6655 * search.c (simple_search): Remove unused var.
6656
6657 * dired.c (compile_pattern): Move decl from here ...
6658 * lisp.h: ... to here, so that it can be checked.
6659 (struct re_registers): New forward decl.
6660
6661 * character.h (INC_POS, DEC_POS): Rename locals to avoid shadowing.
6662
6663 * indent.c (MULTIBYTE_BYTES_WIDTH): New args bytes, width.
6664 All uses changed.
6665 (MULTIBYTE_BYTES_WIDTH, scan_for_column, compute_motion):
6666 Rename locals to avoid shadowing.
6667 (Fvertical_motion): Mark locals as initialized.
6668
6669 * casefiddle.c (casify_object, casify_region): Now static.
6670 (casify_region): Mark local as initialized.
6671
6672 * cmds.c (internal_self_insert): Rename local to avoid shadowing.
6673
6674 * lisp.h (GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR, GCPRO5_VAR, GCPRO6_VAR):
6675 New macros, so that the caller can use some names other than
6676 gcpro1, gcpro2, etc.
6677 (GCPRO2, GCPRO3, GCPRO4, GCPRO5, GCPRO6): Reimplement in terms
6678 of the new macros.
6679 (GCPRO1_VAR, UNGCPRO_VAR): Change the meaning of the second
6680 argument, for consistency with GCPRO2_VAR, etc: it is now the
6681 prefix of the variable, not the variable itself. All uses
6682 changed.
6683 * dired.c (directory_files_internal, file_name_completion):
6684 Rename locals to avoid shadowing.
6685
6686 Fix a race condition diagnosed by gcc -Wsequence-point (Bug#8254).
6687 An expression of the form (DOWNCASE (x) == DOWNCASE (y)), found in
6688 dired.c's scmp function, had undefined behavior.
6689 * lisp.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
6690 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Move from here ...
6691 * buffer.h: ... to here, because these macros use current_buffer,
6692 and the new implementation with inline functions needs to have
6693 current_buffer in scope now, rather than later when the macros
6694 are used.
6695 (downcase, upcase1): New static inline functions.
6696 (DOWNCASE, UPCASE1): Reimplement using these functions.
6697 This avoids undefined behavior in expressions like
6698 DOWNCASE (x) == DOWNCASE (y), which previously suffered
6699 from race conditions in accessing the global variables
6700 case_temp1 and case_temp2.
6701 * casetab.c (case_temp1, case_temp2): Remove; no longer needed.
6702 * lisp.h (case_temp1, case_temp2): Remove their decls.
6703 * character.h (ASCII_CHAR_P): Move from here ...
6704 * lisp.h: ... to here, so that the inline functions mentioned
6705 above can use them.
6706
6707 * dired.c (directory_files_internal_unwind): Now static.
6708
6709 * fileio.c (file_name_as_directory, directory_file_name):
6710 (barf_or_query_if_file_exists, auto_save_error, auto_save_1):
6711 Now static.
6712 (file_name_as_directory): Use const pointers when appropriate.
6713 (Fexpand_file_name): Likewise. In particular, newdir might
6714 point at constant storage, so make it a const pointer.
6715 (Fmake_directory_internal, Fread_file_name): Remove unused vars.
6716 (Ffile_selinux_context, Fset_file_selinux_context): Fix pointer
6717 signedness issues.
6718 (Fset_file_times, Finsert_file_contents, auto_save_error):
6719 Rename locals to avoid shadowing.
6720
6721 * minibuf.c (choose_minibuf_frame_1): Now static.
6722 (Ftry_completion, Fall_completions): Rename or remove locals
6723 to avoid shadowing.
6724
6725 * marker.c (bytepos_to_charpos): Remove; unused.
6726
6727 * lisp.h (verify_bytepos, count_markers): New decls,
6728 so that gcc does not warn that these functions aren't declared.
6729
6730 * insdel.c (check_markers, make_gap_larger, make_gap_smaller):
6731 (reset_var_on_error, Fcombine_after_change_execute_1): Now static.
6732 (CHECK_MARKERS): Redo to avoid gcc -Wempty-body diagnostic.
6733 (copy_text): Remove unused local var.
6734
6735 * filelock.c (within_one_second): Now static.
6736 (lock_file_1): Rename local to avoid shadowing.
6737
6738 * buffer.c (fix_overlays_before): Mark locals as initialized.
6739 (fix_start_end_in_overlays): Likewise. This function should be
6740 simplified by using pointers-to-pointers, but that's a different
6741 matter.
6742 (switch_to_buffer_1): Now static.
6743 (Fkill_buffer, record_buffer, Fbury_buffer, Fset_buffer_multibyte):
6744 (report_overlay_modification): Rename locals to avoid shadowing.
6745
6746 * sysdep.c (system_process_attributes): Rename vars to avoid shadowing.
6747 Fix pointer signedness issue.
6748 (sys_subshell): Mark local as volatile if checking for lint,
6749 to suppress a gcc -Wclobbered warning that does not seem to be right.
6750 (MAXPATHLEN): Define only if needed.
6751
6752 * process.c (serial_open, serial_configure): Move decls from here ...
6753 * systty.h: ... to here, so that they can be checked.
6754
6755 * fns.c (get_random, seed_random): Move extern decls from here ...
6756 * lisp.h: ... to here, so that they can be checked.
6757
6758 * sysdep.c (reset_io): Now static.
6759 (wait_for_termination_signal): Remove; unused.
6760
6761 * keymap.c (keymap_parent, keymap_memberp, map_keymap_internal):
6762 (copy_keymap_item, append_key, push_text_char_description):
6763 Now static.
6764 (Fwhere_is_internal): Don't test CONSP (sequences) unnecessarily.
6765 (DENSE_TABLE_SIZE): Remove; unused.
6766 (get_keymap, access_keymap, Fdefine_key, Fwhere_is_internal):
6767 (describe_map_tree):
6768 Rename locals to avoid shadowing.
6769
6770 * keyboard.c: Declare functions static if they are not used elsewhere.
6771 (echo_char, echo_dash, cmd_error, top_level_2):
6772 (poll_for_input, handle_async_input): Now static.
6773 (read_char, kbd_buffer_get_event, make_lispy_position):
6774 (make_lispy_event, make_lispy_movement, apply_modifiers):
6775 (decode_keyboard_code, tty_read_avail_input, menu_bar_items):
6776 (parse_tool_bar_item, read_key_sequence, Fread_key_sequence):
6777 (Fread_key_sequence_vector): Rename locals to avoid shadowing.
6778 (read_key_sequence, read_char): Mark locals as initialized.
6779 (Fexit_recursive_edit, Fabort_recursive_edit): Mark with NO_RETURN.
6780
6781 * keyboard.h (make_ctrl_char): New decl.
6782 (mark_kboards): Move decl here ...
6783 * alloc.c (mark_kboards): ... from here.
6784
6785 * lisp.h (force_auto_save_soon): New decl.
6786
6787 * emacs.c (init_cmdargs): Rename local to avoid shadowing.
6788 (DEFINE_DUMMY_FUNCTION): New macro.
6789 (__do_global_ctors, __do_global_ctors_aux, __do_global_dtors, __main):
6790 Use it.
6791 (main): Add casts to avoid warnings
6792 if GCC considers string literals to be constants.
6793
6794 * lisp.h (fatal_error_signal): Add decl, since it's exported.
6795
6796 * dbusbind.c: Pointer signedness fixes.
6797 (xd_signature, xd_append_arg, xd_initialize):
6798 (Fdbus_call_method, Fdbus_call_method_asynchronously):
6799 (Fdbus_method_return_internal, Fdbus_method_error_internal):
6800 (Fdbus_send_signal, xd_read_message_1, Fdbus_register_service):
6801 (Fdbus_register_signal): Use SSDATA when the context wants char *.
6802
6803 * dbusbind.c (Fdbus_init_bus): Add cast to avoid warning
6804 if GCC considers string literals to be constants.
6805 (Fdbus_register_service, Fdbus_register_method): Remove unused vars.
6806
6807 2011-03-16 Stefan Monnier <monnier@iro.umontreal.ca>
6808
6809 * print.c (PRINT_CIRCLE_CANDIDATE_P): New macro.
6810 (print_preprocess, print_object): New macro to fix last change.
6811
6812 * print.c (print_preprocess): Don't forget font objects.
6813
6814 2011-03-16 Juanma Barranquero <lekktu@gmail.com>
6815
6816 * emacs.c (USAGE3): Doc fixes.
6817
6818 2011-03-15 Andreas Schwab <schwab@linux-m68k.org>
6819
6820 * coding.c (detect_coding_iso_2022): Reorganize code to clarify
6821 structure.
6822
6823 2011-03-14 Juanma Barranquero <lekktu@gmail.com>
6824
6825 * lisp.h (VWindow_system, Qfile_name_history):
6826 * keyboard.h (lispy_function_keys) [WINDOWSNT]:
6827 * w32term.h (w32_system_caret_hwnd, w32_system_caret_height)
6828 (w32_system_caret_x, w32_system_caret_y): Declare extern.
6829
6830 * w32select.c: Don't #include "keyboard.h".
6831 (run_protected): Add extern declaration for waiting_for_input.
6832
6833 * w32.c (Qlocal, noninteractive1, inhibit_window_system):
6834 * w32console.c (detect_input_pending, read_input_pending)
6835 (encode_terminal_code):
6836 * w32fns.c (quit_char, lispy_function_keys, Qtooltip)
6837 (w32_system_caret_hwnd, w32_system_caret_height, w32_system_caret_x)
6838 (w32_system_caret_y, Qfile_name_history):
6839 * w32font.c (w32font_driver, QCantialias, QCotf, QClang):
6840 * w32inevt.c (reinvoke_input_signal, lispy_function_keys):
6841 * w32menu.c (Qmenu_bar, QCtoggle, QCradio, Qoverriding_local_map)
6842 (Qoverriding_terminal_local_map, Qmenu_bar_update_hook):
6843 * w32proc.c (Qlocal, report_file_error):
6844 * w32term.c (Vwindow_system, updating_frame):
6845 * w32uniscribe.c (initialized, uniscribe_font_driver):
6846 Remove unneeded extern declarations.
6847
6848 2011-03-14 Chong Yidong <cyd@stupidchicken.com>
6849
6850 * buffer.c (Fmake_indirect_buffer): Fix incorrect assertions.
6851
6852 2011-03-13 Chong Yidong <cyd@stupidchicken.com>
6853
6854 * buffer.h (BUF_BEGV, BUF_BEGV_BYTE, BUF_ZV, BUF_ZV_BYTE, BUF_PT)
6855 (BUF_PT_BYTE): Rewrite to handle indirect buffers (Bug#8219).
6856 These macros can no longer be used for assignment.
6857
6858 * buffer.c (Fget_buffer_create, Fmake_indirect_buffer):
6859 Assign struct members directly, instead of using BUF_BEGV etc.
6860 (record_buffer_markers, fetch_buffer_markers): New functions for
6861 recording and fetching special buffer markers.
6862 (set_buffer_internal_1, set_buffer_temp): Use them.
6863
6864 * lread.c (unreadchar): Use SET_BUF_PT_BOTH.
6865
6866 * insdel.c (adjust_point): Use SET_BUF_PT_BOTH.
6867
6868 * intervals.c (temp_set_point_both): Use SET_BUF_PT_BOTH.
6869 (get_local_map): Use SET_BUF_BEGV_BOTH and SET_BUF_ZV_BOTH.
6870
6871 * xdisp.c (hscroll_window_tree):
6872 (reconsider_clip_changes): Use PT instead of BUF_PT.
6873
6874 2011-03-13 Eli Zaretskii <eliz@gnu.org>
6875
6876 * makefile.w32-in ($(BLD)/editfns.$(O)): Depend on
6877 $(EMACS_ROOT)/lib/intprops.h.
6878
6879 2011-03-13 Paul Eggert <eggert@cs.ucla.edu>
6880
6881 Fix more problems found by GCC 4.5.2's static checks.
6882
6883 * gtkutil.c (xg_get_pixbuf_from_pixmap): Add cast from char *
6884 to unsigned char * to avoid compiler diagnostic.
6885 (xg_free_frame_widgets): Make it clear that a local variable is
6886 needed only if USE_GTK_TOOLTIP.
6887 (gdk_window_get_screen): Make it clear that this macro is needed
6888 only if USE_GTK_TOOLTIP.
6889 (int_gtk_range_get_value): New function, which avoids a diagnostic
6890 from gcc -Wbad-function-cast.
6891 (xg_set_toolkit_scroll_bar_thumb): Use it.
6892 (xg_tool_bar_callback, xg_tool_item_stale_p): Rewrite to avoid
6893 diagnostic from gcc -Wbad-function-cast.
6894 (get_utf8_string, xg_get_file_with_chooser):
6895 Rename locals to avoid shadowing.
6896 (create_dialog): Move locals to avoid shadowing.
6897
6898 * xgselect.c (xg_select): Remove unused var.
6899
6900 * image.c (four_corners_best): Mark locals as initialized.
6901 (gif_load): Initialize transparent_p to zero (Bug#8238).
6902 Mark another local as initialized.
6903 (my_png_error, my_error_exit): Mark with NO_RETURN.
6904
6905 * image.c (clear_image_cache): Now static.
6906 (DIM, HAVE_STDLIB_H_1): Remove unused macros.
6907 (xpm_load): Redo to avoid "discards qualifiers" gcc warning.
6908 (x_edge_detection): Remove unnecessary cast that
6909 gcc -Wbad-function-cast diagnoses.
6910 (gif_load): Fix pointer signedness.
6911 (clear_image_cache, xbm_read_bitmap_data, x_detect_edges):
6912 (jpeg_load, gif_load): Rename locals to avoid shadowing.
6913
6914 2011-03-12 Paul Eggert <eggert@cs.ucla.edu>
6915
6916 Improve quality of tests for time stamp overflow.
6917 For example, without this patch (encode-time 0 0 0 1 1
6918 1152921504606846976) returns the obviously-bogus value (-948597
6919 62170) on my RHEL 5.5 x86-64 host. With the patch, it correctly
6920 reports time overflow. See
6921 <http://lists.gnu.org/archive/html/emacs-devel/2011-03/msg00470.html>.
6922 * deps.mk (editfns.o): Depend on ../lib/intprops.h.
6923 * editfns.c: Include limits.h and intprops.h.
6924 (TIME_T_MIN, TIME_T_MAX): New macros.
6925 (time_overflow): Move earlier, to before first use.
6926 (hi_time, lo_time): New functions, for an accurate test for
6927 out-of-range times.
6928 (Fcurrent_time, Fget_internal_run_time, make_time): Use them.
6929 (Fget_internal_run_time): Don't assume time_t fits in int.
6930 (make_time): Use list2 instead of Fcons twice.
6931 (Fdecode_time): More accurate test for out-of-range times.
6932 (check_tm_member): New function.
6933 (Fencode_time): Use it, to test for out-of-range times.
6934 (lisp_time_argument): Don't rely on undefined left-shift and
6935 right-shift behavior when checking for time stamp overflow.
6936
6937 * editfns.c (time_overflow): New function, refactoring common code.
6938 (Fformat_time_string, Fdecode_time, Fencode_time):
6939 (Fcurrent_time_string): Use it.
6940
6941 Move 'make_time' to be next to its inverse 'lisp_time_argument'.
6942 * dired.c (make_time): Move to ...
6943 * editfns.c (make_time): ... here.
6944 * systime.h: Note the move.
6945
6946 2011-03-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
6947
6948 * fringe.c (update_window_fringes): Remove unused variables.
6949
6950 * unexmacosx.c (copy_data_segment): Also copy __got section.
6951 (Bug#8223)
6952
6953 2011-03-12 Eli Zaretskii <eliz@gnu.org>
6954
6955 * termcap.c [MSDOS]: Include "msdos.h".
6956 (find_capability, tgetnum, tgetflag, tgetstr, tputs, tgetent):
6957 Constify `char *' arguments and their references according to
6958 prototypes in tparam.h.
6959
6960 * deps.mk (termcap.o): Depend on tparam.h and msdos.h.
6961
6962 * msdos.c (XMenuAddPane): 3rd argument is `const char *' now.
6963 Adapt all references accordingly.
6964
6965 * msdos.h (XMenuAddPane): 3rd argument is `const char *' now.
6966
6967 2011-03-11 Tom Tromey <tromey@redhat.com>
6968
6969 * buffer.c (syms_of_buffer): Remove obsolete comment.
6970
6971 2011-03-11 Eli Zaretskii <eliz@gnu.org>
6972
6973 * termhooks.h (encode_terminal_code): Declare prototype.
6974
6975 * msdos.c (encode_terminal_code): Don't declare prototype.
6976
6977 * term.c (encode_terminal_code): Now external again, used by
6978 w32console.c and msdos.c.
6979
6980 * makefile.w32-in ($(BLD)/term.$(O), ($(BLD)/tparam.$(O)):
6981 Depend on $(SRC)/tparam.h, see 2011-03-11T07:24:21Z!eggert@cs.ucla.edu.
6982
6983 2011-03-11 Paul Eggert <eggert@cs.ucla.edu>
6984
6985 Fix some minor problems found by GCC 4.5.2's static checks.
6986
6987 * fringe.c (update_window_fringes): Mark locals as initialized
6988 (Bug#8227).
6989 (destroy_fringe_bitmap, init_fringe_bitmap): Now static.
6990
6991 * alloc.c (mark_fringe_data): Move decl from here ...
6992 * lisp.h (mark_fringe_data) [HAVE_WINDOW_SYSTEM]: ... to here,
6993 to check its interface.
6994 (init_fringe_once): Do not declare unless HAVE_WINDOW_SYSTEM.
6995
6996 * fontset.c (free_realized_fontset): Now static.
6997 (Fset_fontset_font): Rename local to avoid shadowing.
6998 (fontset_font): Mark local as initialized.
6999 (FONTSET_SPEC, FONTSET_REPERTORY, RFONT_DEF_REPERTORY): Remove; unused.
7000
7001 * xrdb.c: Include "xterm.h", to check x_load_resources's interface.
7002
7003 * xselect.c (x_disown_buffer_selections): Remove; not used.
7004 (TRACE3) [!defined TRACE_SELECTION]: Remove; not used.
7005 (x_own_selection, Fx_disown_selection_internal): Rename locals
7006 to avoid shadowing.
7007 (x_handle_dnd_message): Remove local to avoid shadowing.
7008
7009 * lisp.h (GCPRO1_VAR, UNGCPRO_VAR): New macros,
7010 so that the caller can use some name other than gcpro1.
7011 (GCPRO1, UNGCPRO): Reimplement in terms of the new macros.
7012 * xfns.c (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
7013 (Fx_backspace_delete_keys_p):
7014 Use them to avoid shadowing, and rename vars to avoid shadowing.
7015 (x_decode_color, x_set_name, x_window): Now static.
7016 (Fx_create_frame): Add braces to silence GCC warning.
7017 (Fx_file_dialog, Fx_select_font): Fix pointer signedness.
7018 (x_real_positions, xg_set_icon_from_xpm_data, x_create_tip_frame):
7019 Remove unused locals.
7020 (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
7021 (Fx_backspace_delete_keys_p): Rename locals to avoid shadowing.
7022 Some of these renamings use the new GCPRO1_VAR and UNGCPRO_VAR
7023 macros.
7024
7025 * xterm.h (x_mouse_leave): New decl.
7026
7027 * xterm.c (x_copy_dpy_color, x_focus_on_frame, x_unfocus_frame):
7028 Remove unused functions.
7029 (x_shift_glyphs_for_insert, XTflash, XTring_bell):
7030 (x_calc_absolute_position): Now static.
7031 (XTread_socket): Don't define label "out" unless it's used.
7032 Don't declare local "event" unless it's used.
7033 (x_iconify_frame, x_free_frame_resources): Don't declare locals
7034 unless they are used.
7035 (XEMBED_VERSION, xembed_set_info): Don't define unless needed.
7036 (x_fatal_error_signal): Remove; not used.
7037 (x_draw_image_foreground, redo_mouse_highlight, XTmouse_position):
7038 (x_scroll_bar_report_motion, handle_one_xevent, x_draw_bar_cursor):
7039 (x_error_catcher, x_connection_closed, x_error_handler):
7040 (x_error_quitter, xembed_send_message, x_iconify_frame):
7041 (my_log_handler): Rename locals to avoid shadowing.
7042 (x_delete_glyphs, x_ins_del_lines): Mark with NO_RETURN.
7043 (x_connection_closed): Tell GCC not to suggest NO_RETURN.
7044
7045 * xfaces.c (clear_face_cache, Fx_list_fonts, Fface_font):
7046 Rename or move locals to avoid shadowing.
7047 (tty_defined_color, merge_face_heights): Now static.
7048 (free_realized_faces_for_fontset): Remove; not used.
7049 (Fx_list_fonts): Mark variable that gcc -Wuninitialized
7050 does not deduce is never used uninitialized.
7051 (STRDUPA, LSTRDUPA, FONT_POINT_SIZE_QUANTUM): Remove; not used.
7052 (LFACEP): Define only if XASSERTS, as it's not needed otherwise.
7053
7054 * terminal.c (store_terminal_param): Now static.
7055
7056 * xmenu.c (menu_highlight_callback): Now static.
7057 (set_frame_menubar): Remove unused local.
7058 (xmenu_show): Rename parameter to avoid shadowing.
7059 (xmenu_show, xdialog_show, xmenu_show): Make local pointers "const"
7060 since they might point to immutable storage.
7061 (next_menubar_widget_id): Declare only if USE_X_TOOLKIT,
7062 since it's unused otherwise.
7063
7064 * xdisp.c (produce_glyphless_glyph): Initialize lower_xoff.
7065 Add a FIXME, since the code still doesn't look right. (Bug#8215)
7066 (Fcurrent_bidi_paragraph_direction): Simplify slightly; this
7067 avoids a gcc -Wuninitialized diagnostic.
7068 (display_line, BUILD_COMPOSITE_GLYPH_STRING, draw_glyphs):
7069 (note_mouse_highlight): Mark variables that gcc -Wuninitialized
7070 does not deduce are never used uninitialized.
7071
7072 * lisp.h (IF_LINT): New macro, copied from ../lib-src/emacsclient.c.
7073
7074 * xdisp.c (redisplay_window): Rename local to avoid shadowing.
7075 * window.c (window_loop, size_window):
7076 (run_window_configuration_change_hook, enlarge_window): Likewise.
7077
7078 * window.c (display_buffer): Now static.
7079 (size_window): Mark variables that gcc -Wuninitialized
7080 does not deduce are never used uninitialized.
7081 * window.h (check_all_windows): New decl, to forestall
7082 gcc -Wmissing-prototypes diagnostic.
7083 * dispextern.h (bidi_dump_cached_states): Likewise.
7084
7085 * charset.h (CHECK_CHARSET_GET_CHARSET): Rename locals to avoid
7086 shadowing.
7087 * charset.c (map_charset_for_dump, Fchar_charset): Likewise.
7088 Include <limits.h>.
7089 (Fsort_charsets): Redo min/max calculation to shorten the code a bit
7090 and to avoid gcc -Wuninitialized warning.
7091 (load_charset_map): Mark variables that gcc -Wuninitialized
7092 does not deduce are never used uninitialized.
7093 (load_charset): Abort instead of using uninitialized var (Bug#8229).
7094
7095 * coding.c (coding_set_source, coding_set_destination):
7096 Use "else { /* comment */ }" rather than "else /* comment */;"
7097 for clarity, and to avoid gcc -Wempty-body warning.
7098 (Fdefine_coding_system_internal): Don't redeclare 'i' inside
7099 a block, when the outer 'i' will do.
7100 (decode_coding_utf_8, decode_coding_utf_16, detect_coding_emacs_mule):
7101 (emacs_mule_char, decode_coding_emacs_mule, detect_coding_iso_2022):
7102 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5):
7103 (decode_coding_raw_text, decode_coding_charset, get_translation_table):
7104 (Fdecode_sjis_char, Fdefine_coding_system_internal):
7105 Rename locals to avoid shadowing.
7106 * character.h (FETCH_STRING_CHAR_ADVANCE): Likewise.
7107 * coding.c (emacs_mule_char, encode_invocation_designation):
7108 Now static, since they're not used elsewhere.
7109 (decode_coding_iso_2022): Add "default: abort ();" as a safety check.
7110 (decode_coding_object, encode_coding_object, detect_coding_system):
7111 (decode_coding_emacs_mule): Mark variables that gcc
7112 -Wuninitialized does not deduce are never used uninitialized.
7113 (detect_coding_iso_2022): Initialize a local variable that might
7114 be used uninitialized. Leave a FIXME because it's not clear that
7115 this initialization is needed. (Bug#8211)
7116 (ISO_CODE_LF, ISO_CODE_CR, CODING_ISO_FLAG_EUC_TW_SHIFT):
7117 (ONE_MORE_BYTE_NO_CHECK, UTF_BOM, UTF_16_INVALID_P):
7118 (SHIFT_OUT_OK, ENCODE_CONTROL_SEQUENCE_INTRODUCER):
7119 (ENCODE_DIRECTION_R2L, ENCODE_DIRECTION_L2R):
7120 Remove unused macros.
7121
7122 * category.c (hash_get_category_set): Remove unused local var.
7123 (copy_category_table): Now static, since it's not used elsewhere.
7124 * character.c (string_count_byte8): Likewise.
7125
7126 * ccl.c (CCL_WRITE_STRING, CCL_ENCODE_CHAR, Fccl_execute_on_string):
7127 (Fregister_code_conversion_map): Rename locals to avoid shadowing.
7128
7129 * chartab.c (copy_sub_char_table): Now static, since it's not used
7130 elsewhere.
7131 (sub_char_table_ref_and_range, char_table_ref_and_range):
7132 Rename locals to avoid shadowing.
7133 (ASET_RANGE, GET_SUB_CHAR_TABLE): Remove unused macros.
7134
7135 * bidi.c (bidi_check_type): Now static, since it's not used elsewhere.
7136 (BIDI_BOB): Remove unused macro.
7137
7138 * cm.c (cmgoto): Mark variables that gcc -Wuninitialized does not
7139 deduce are never used uninitialized.
7140 * term.c (encode_terminal_code): Likewise.
7141
7142 * term.c (encode_terminal_code): Now static. Remove unused local.
7143
7144 * tparam.h: New file.
7145 * term.c, tparam.h: Include it.
7146 * deps.mk (term.o, tparam.o): Depend on tparam.h.
7147 * term.c (tputs, tgetent, tgetflag, tgetnum, tparam, tgetstr):
7148 Move these decls to tparam.h, and make them agree with what
7149 is actually in tparam.c. The previous trick of using incompatible
7150 decls in different modules does not conform to the C standard.
7151 All callers of tparam changed to use tparam's actual API.
7152 * tparam.c (tparam1, tparam, tgoto):
7153 Use const pointers where appropriate.
7154
7155 * cm.c (calccost, cmgoto): Use const pointers where appropriate.
7156 * cm.h (struct cm): Likewise.
7157 * dispextern.h (do_line_insertion_deletion_costs): Likewise.
7158 * scroll.c (ins_del_costs, do_line_insertion_deletion_costs): Likewise.
7159 * term.c (tty_ins_del_lines, calculate_costs, struct fkey_table):
7160 (term_get_fkeys_1, append_glyphless_glyph, produce_glyphless_glyph):
7161 (turn_on_face, init_tty): Likewise.
7162 * termchar.h (struct tty_display_info): Likewise.
7163
7164 * term.c (term_mouse_position): Rename local to avoid shadowing.
7165
7166 * alloc.c (mark_ttys): Move decl from here ...
7167 * lisp.h (mark_ttys): ... to here, so that it's checked against defn.
7168
7169 2011-03-11 Andreas Schwab <schwab@linux-m68k.org>
7170
7171 * .gdbinit (pwinx, xbuffer): Fix access to buffer name.
7172
7173 2011-03-09 Juanma Barranquero <lekktu@gmail.com>
7174
7175 * search.c (compile_pattern_1): Remove argument regp, unused since
7176 revid:rms@gnu.org-19941211082627-3x1g1wyqkjmwloig.
7177 (compile_pattern): Don't pass it.
7178
7179 2011-03-08 Jan Djärv <jan.h.d@swipnet.se>
7180
7181 * xterm.h (DEFAULT_GDK_DISPLAY): New define.
7182 (GDK_WINDOW_XID, gtk_widget_get_preferred_size): New defines
7183 for ! HAVE_GTK3.
7184 (GTK_WIDGET_TO_X_WIN): Use GDK_WINDOW_XID.
7185
7186 * xmenu.c (menu_position_func): Call gtk_widget_get_preferred_size.
7187
7188 * gtkutil.c: Include gtkx.h if HAVE_GTK3. If ! HAVE_GTK3, define
7189 gdk_window_get_screen, gdk_window_get_geometry,
7190 gdk_x11_window_lookup_for_display and GDK_KEY_g.
7191 (xg_set_screen): Use DEFAULT_GDK_DISPLAY.
7192 (xg_get_pixbuf_from_pixmap): New function.
7193 (xg_get_pixbuf_from_pix_and_mask): Change parameters from GdkPixmap
7194 to Pixmap, take frame as parameter, remove GdkColormap parameter.
7195 Call xg_get_pixbuf_from_pixmap instead of
7196 gdk_pixbuf_get_from_drawable.
7197 (xg_get_image_for_pixmap): Do not make GdkPixmaps, call
7198 xg_get_pixbuf_from_pix_and_mask with Pixmap parameters instead.
7199 (xg_check_special_colors): Use GtkStyleContext and its functions
7200 for HAVE_GTK3.
7201 (xg_prepare_tooltip, xg_hide_tooltip): Call gdk_window_get_screen.
7202 (xg_prepare_tooltip, create_dialog, menubar_map_cb)
7203 (xg_update_frame_menubar, xg_tool_bar_detach_callback)
7204 (xg_tool_bar_attach_callback, xg_update_tool_bar_sizes):
7205 Call gtk_widget_get_preferred_size.
7206 (xg_frame_resized): gdk_window_get_geometry only takes 5
7207 parameters.
7208 (xg_win_to_widget, xg_event_is_for_menubar):
7209 Call gdk_x11_window_lookup_for_display.
7210 (xg_set_widget_bg): New function.
7211 (delete_cb): New function.
7212 (xg_create_frame_widgets): Connect delete-event to delete_cb.
7213 Call xg_set_widget_bg. Only set backgrund pixmap for ! HAVE_GTK3
7214 (xg_set_background_color): Call xg_set_widget_bg.
7215 (xg_set_frame_icon): Call xg_get_pixbuf_from_pix_and_mask.
7216 (xg_create_scroll_bar): vadj is a GtkAdjustment for HAVE_GTK3.
7217 Only call gtk_range_set_update_policy if ! HAVE_GTK3.
7218 (xg_make_tool_item): Only connect xg_tool_bar_item_expose_callback
7219 if ! HAVE_GTK3.
7220 (update_frame_tool_bar): Call gtk_widget_hide.
7221 (xg_initialize): Use GDK_KEY_g.
7222
7223 * xsmfns.c (gdk_set_sm_client_id): Define to gdk_set_sm_client_id
7224 if ! HAVE_GTK3
7225 (x_session_initialize): Call gdk_x11_set_sm_client_id.
7226
7227 * xterm.c (XFillRectangle): Use cairo routines for HAVE_GTK3.
7228 (x_term_init): Disable Xinput(2) with GDK_CORE_DEVICE_EVENTS.
7229 Load ~/emacs.d/gtkrc only for ! HAVE_GTK3.
7230
7231 2011-03-08 Juanma Barranquero <lekktu@gmail.com>
7232
7233 * w32xfns.c (select_palette): Check success of RealizePalette against
7234 GDI_ERROR, not zero.
7235
7236 See ChangeLog.11 for earlier changes.
7237
7238 ;; Local Variables:
7239 ;; coding: utf-8
7240 ;; End:
7241
7242 Copyright (C) 2011 Free Software Foundation, Inc.
7243
7244 This file is part of GNU Emacs.
7245
7246 GNU Emacs is free software: you can redistribute it and/or modify
7247 it under the terms of the GNU General Public License as published by
7248 the Free Software Foundation, either version 3 of the License, or
7249 (at your option) any later version.
7250
7251 GNU Emacs is distributed in the hope that it will be useful,
7252 but WITHOUT ANY WARRANTY; without even the implied warranty of
7253 MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
7254 GNU General Public License for more details.
7255
7256 You should have received a copy of the GNU General Public License
7257 along with GNU Emacs. If not, see <http://www.gnu.org/licenses/>.