1 2011-06-18 Paul Eggert <eggert@cs.ucla.edu>
3 * fns.c (Ffillarray): Don't assume bool vector size fits in 'int'.
4 Use much-faster test for byte-length change.
5 Don't assume string byte-length fits in 'int'.
6 Check that character arg fits in 'int'.
8 * alloc.c (Fmake_bool_vector): Avoid unnecessary multiplication.
10 * fns.c (concat): Catch string overflow earlier.
11 Do not rely on integer wraparound.
13 * dispextern.h (struct it.overlay_strings_charpos): EMACS_INT, not int.
15 2011-06-17 Paul Eggert <eggert@cs.ucla.edu>
17 * dispextern.h (struct it.selective): Now EMACS_INT, not int.
18 * xdisp.c (forward_to_next_line_start)
19 (back_to_previous_visible_line_start)
20 (reseat_at_next_visible_line_start, next_element_from_buffer):
21 Don't arbitrarily truncate the value of 'selective' to int.
23 * xdisp.c (init_iterator): Use XINT, not XFASTINT; it might be < 0.
25 * composite.c: Don't truncate sizes to 'int'.
26 (composition_gstring_p, composition_reseat_it)
27 (composition_adjust_point): Use EMACS_INT, not int.
28 (get_composition_id, composition_gstring_put_cache): Use EMACS_INT,
29 not EMACS_UINT, for indexes.
31 * category.h (CATEGORY_SET_P): Remove unnecessary cast to EMACS_INT.
33 * buffer.c: Include <verify.h>.
34 (struct sortvec.priority, struct sortstr.priority):
35 Now EMACS_INT, not int.
36 (compare_overlays, cmp_for_strings): Avoid subtraction overflow.
37 (struct sortstr.size, record_overlay_string)
38 (struct sortstrlist.size, struct sortlist.used):
39 Don't truncate size to int.
40 (record_overlay_string): Check for size-calculation overflow.
41 (init_buffer_once): Check at compile-time, not run-time.
43 2011-06-16 Paul Eggert <eggert@cs.ucla.edu>
45 * lisp.h: Include <limits.h>, for INT_MAX, LONG_MAX, LLONG_MAX.
46 Without this, prin1 mishandles Lisp_Misc_Save_Value printing on
47 hosts with pre-C99 libraries, because pD is wrongly defined to "t".
49 Improve buffer-overflow checking (Bug#8873).
50 * fileio.c (Finsert_file_contents):
51 * insdel.c (insert_from_buffer_1, replace_range, replace_range_2):
52 Remove the old (too-loose) buffer overflow checks.
53 They weren't needed, since make_gap checks for buffer overflow.
54 * insdel.c (make_gap_larger): Catch buffer overflows that were missed.
55 The old code merely checked for Emacs fixnum overflow, and relied
56 on undefined (wraparound) behavior. The new code avoids undefined
57 behavior, and also checks for ptrdiff_t and/or size_t overflow.
59 * editfns.c (Finsert_char): Don't dump core with very negative counts.
60 Tune. Don't use wider integers than needed. Don't use alloca.
61 Use a bigger 'string' buffer. Rewrite to avoid 'n > 0' test.
63 * insdel.c (replace_range): Fix buf overflow when insbytes < outgoing.
65 * insdel.c, lisp.h (buffer_overflow): New function.
66 (insert_from_buffer_1, replace_range, replace_range_2):
67 * insdel.c (make_gap_larger):
68 * editfns.c (Finsert_char):
69 * fileio.c (Finsert_file_contents): Use it, to normalize wording.
71 * buffer.h (BUF_BYTES_MAX): Cast to ptrdiff_t so that it's signed.
73 2011-06-15 Paul Eggert <eggert@cs.ucla.edu>
75 Integer overflow and signedness fixes (Bug#8873).
77 * ccl.c (ASCENDING_ORDER): New macro, to work around GCC bug 43772.
78 (GET_CCL_RANGE, IN_INT_RANGE): Use it.
80 * fileio.c: Don't assume EMACS_INT fits in off_t.
81 (emacs_lseek): New static function.
82 (Finsert_file_contents, Fwrite_region): Use it.
83 Use SEEK_SET, SEEK_CUR, SEEK_END as appropriate.
85 * fns.c (Fload_average): Don't assume 100 * load average fits in int.
87 * fns.c: Don't overflow int when computing a list length.
88 * fns.c (QUIT_COUNT_HEURISTIC): New constant.
89 (Flength, Fsafe_length): Use EMACS_INT, not int, to avoid unwanted
90 truncation on 64-bit hosts. Check for QUIT every
91 QUIT_COUNT_HEURISTIC entries rather than every other entry; that's
92 faster and is responsive enough.
93 (Flength): Report an error instead of overflowing an integer.
94 (Fsafe_length): Return a float if the value is not representable
95 as a fixnum. This shouldn't happen except in contrived situations.
96 (Fnthcdr, Fsort): Don't assume list length fits in int.
97 (Fcopy_sequence): Don't assume vector length fits in int.
99 * alloc.c: Check that resized vectors' lengths fit in fixnums.
100 (header_size, word_size): New constants.
101 (allocate_vectorlike): Don't check size overflow here.
102 (allocate_vector): Check it here instead, since this is the only
103 caller of allocate_vectorlike that could cause overflow.
104 Check that the new vector's length is representable as a fixnum.
106 * fns.c (next_almost_prime): Don't return a multiple of 3 or 5.
107 The previous code was bogus. For example, next_almost_prime (32)
108 returned 39, which is undesirable as it is a multiple of 3; and
109 next_almost_prime (24) returned 25, which is a multiple of 5 so
110 why was the code bothering to check for multiples of 7?
112 * bytecode.c (exec_byte_code): Use ptrdiff_t, not int, for vector length.
114 * eval.c, doprnt.c (SIZE_MAX): Remove; inttypes.h defines this now.
116 Variadic C functions now count arguments with ptrdiff_t.
117 This partly undoes my 2011-03-30 change, which replaced int with size_t.
118 Back then I didn't know that the Emacs coding style prefers signed int.
119 Also, in the meantime I found a few more instances where arguments
120 were being counted with int, which may truncate counts on 64-bit
121 machines, or EMACS_INT, which may be unnecessarily wide.
122 * lisp.h (struct Lisp_Subr.function.aMANY)
123 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call):
124 Arg counts are now ptrdiff_t, not size_t.
125 All variadic functions and their callers changed accordingly.
126 (struct gcpro.nvars): Now size_t, not size_t. All uses changed.
127 * bytecode.c (exec_byte_code): Check maxdepth for overflow,
128 to avoid potential buffer overrun. Don't assume arg counts fit in 'int'.
129 * callint.c (Fcall_interactively): Check arg count for overflow,
130 to avoid potential buffer overrun. Use signed char, not 'int',
131 for 'varies' array, so that we needn't bother to check its size
132 calculation for overflow.
133 * editfns.c (Fformat): Use ptrdiff_t, not EMACS_INT, to count args.
134 * eval.c (apply_lambda):
135 * fns.c (Fmapconcat): Use XFASTINT, not XINT, to get args length.
136 (struct textprop_rec.argnum): Now ptrdiff_t, not int. All uses changed.
137 (mapconcat): Use ptrdiff_t, not int and EMACS_INT, to count args.
139 * callint.c (Fcall_interactively): Don't use index var as event count.
141 * vm-limit.c (check_memory_limits): Fix incorrect extern function decls.
142 * mem-limits.h (SIZE): Remove; no longer used.
144 * xterm.c (x_alloc_nearest_color_1): Prefer int to long when int works.
146 Remove unnecessary casts.
147 * xterm.c (x_term_init):
148 * xfns.c (x_set_border_pixel):
149 * widget.c (create_frame_gcs): Remove casts to unsigned long etc.
150 These aren't needed now that we assume ANSI C.
152 * sound.c (Fplay_sound_internal): Remove cast to unsigned long.
153 It's more likely to cause problems (due to unsigned overflow)
156 * dired.c (Ffile_attributes): Don't use 32-bit hack on 64-bit hosts.
158 * unexelf.c (unexec): Don't assume BSS addr fits in unsigned.
160 * xterm.c (handle_one_xevent): Omit unnecessary casts to unsigned.
162 * keyboard.c (modify_event_symbol): Don't limit alist len to UINT_MAX.
164 * lisp.h (CHAR_TABLE_SET): Omit now-redundant test.
166 * lread.c (Fload): Don't compare a possibly-garbage time_t value.
168 GLYPH_CODE_FACE returns EMACS_INT, not int.
169 * dispextern.h (merge_faces):
170 * xfaces.c (merge_faces):
171 * xdisp.c (get_next_display_element, next_element_from_display_vector):
172 Don't assume EMACS_INT fits in int.
174 * character.h (CHAR_VALID_P): Remove unused parameter.
175 * fontset.c, lisp.h, xdisp.c: All uses changed.
177 * editfns.c (Ftranslate_region_internal): Omit redundant test.
179 * fns.c (concat): Minor tuning based on overflow analysis.
180 This doesn't fix any bugs. Use int to hold character, instead
181 of constantly refetching from Emacs object. Use XFASTINT, not
182 XINT, for value known to be a character. Don't bother comparing
183 a single byte to 0400, as it's always less.
185 * floatfns.c (Fexpt):
186 * fileio.c (make_temp_name): Omit unnecessary cast to unsigned.
188 * editfns.c (Ftranslate_region_internal): Use int, not EMACS_INT
191 * doc.c (get_doc_string): Omit (unsigned)c that mishandled negatives.
193 * data.c (Faset): If ARRAY is a string, check that NEWELT is a char.
194 Without this fix, on a 64-bit host (aset S 0 4294967386) would
195 incorrectly succeed when S was a string, because 4294967386 was
196 truncated before it was used.
198 * chartab.c (Fchar_table_range): Use CHARACTERP to check range.
199 Otherwise, an out-of-range integer could cause undefined behavior
202 * composite.c: Use int, not EMACS_INT, for characters.
203 (fill_gstring_body, composition_compute_stop_pos): Use int, not
204 EMACS_INT, for values that are known to be in character range.
205 This doesn't fix any bugs but is the usual style inside Emacs and
206 may generate better code on 32-bit machines.
208 Make sure a 64-bit char is never passed to ENCODE_CHAR.
209 This is for reasons similar to the recent CHAR_STRING fix.
210 * charset.c (Fencode_char): Check that character arg is actually
211 a character. Pass an int to ENCODE_CHAR.
212 * charset.h (ENCODE_CHAR): Verify that the character argument is no
213 wider than 'int', as a compile-time check to prevent future regressions
216 * character.c (char_string): Remove unnecessary casts.
218 Make sure a 64-bit char is never passed to CHAR_STRING.
219 Otherwise, CHAR_STRING would do the wrong thing on a 64-bit platform,
220 by silently ignoring the top 32 bits, allowing some values
221 that were far too large to be valid characters.
222 * character.h: Include <verify.h>.
223 (CHAR_STRING, CHAR_STRING_ADVANCE): Verify that the character
224 arguments are no wider than unsigned, as a compile-time check
225 to prevent future regressions in this area.
227 * editfns.c (Fchar_to_string, general_insert_function, Finsert_char)
228 (Fsubst_char_in_region):
230 * xdisp.c (decode_mode_spec_coding):
231 Adjust to CHAR_STRING's new requirement.
232 * editfns.c (Finsert_char, Fsubst_char_in_region):
233 * fns.c (concat): Check that character args are actually
234 characters. Without this test, these functions did the wrong
235 thing with wildly out-of-range values on 64-bit hosts.
237 Remove incorrect casts to 'unsigned' that lose info on 64-bit hosts.
238 These casts should not be needed on 32-bit hosts, either.
239 * keyboard.c (read_char):
240 * lread.c (Fload): Remove casts to unsigned.
242 * lisp.h (UNSIGNED_CMP): New macro.
243 This fixes comparison bugs on 64-bit hosts.
244 (ASCII_CHAR_P): Use it.
245 * casefiddle.c (casify_object):
246 * character.h (ASCII_BYTE_P, CHAR_VALID_P)
247 (SINGLE_BYTE_CHAR_P, CHAR_STRING):
248 * composite.h (COMPOSITION_ENCODE_RULE_VALID):
249 * dispextern.h (FACE_FROM_ID):
250 * keyboard.c (read_char): Use UNSIGNED_CMP.
252 * xmenu.c (dialog_selection_callback) [!USE_GTK]: Cast to intptr_t,
253 not to EMACS_INT, to avoid GCC warning.
255 * xfns.c (x_set_scroll_bar_default_width): Remove unused 'int' locals.
257 * buffer.h (PTR_BYTE_POS, BUF_PTR_BYTE_POS): Remove harmful cast.
258 The cast incorrectly truncated 64-bit byte offsets to 32 bits, and
259 isn't needed on 32-bit machines.
261 * buffer.c (Fgenerate_new_buffer_name):
262 Use EMACS_INT for count, not int.
263 (advance_to_char_boundary): Return EMACS_INT, not int.
265 * data.c (Qcompiled_function): Now static.
267 * window.c (window_body_lines): Now static.
269 * image.c (gif_load): Rename local to avoid shadowing.
271 * lisp.h (SAFE_ALLOCA_LISP): Check for integer overflow.
272 (struct Lisp_Save_Value): Use ptrdiff_t, not int, for 'integer' member.
273 * alloc.c (make_save_value): Integer argument is now of type
275 (mark_object): Use ptrdiff_t, not int.
276 * lisp.h (pD): New macro.
277 * print.c (print_object): Use it.
279 * alloc.c: Use EMACS_INT, not int, to count objects.
280 (total_conses, total_markers, total_symbols, total_vector_size)
281 (total_free_conses, total_free_markers, total_free_symbols)
282 (total_free_floats, total_floats, total_free_intervals)
283 (total_intervals, total_strings, total_free_strings):
284 Now EMACS_INT, not int. All uses changed.
285 (Fgarbage_collect): Compute overall total using a double, so that
286 integer overflow is less likely to be a problem. Check for overflow
287 when converting back to an integer.
288 (n_interval_blocks, n_string_blocks, n_float_blocks, n_cons_blocks)
289 (n_vectors, n_symbol_blocks, n_marker_blocks): Remove.
290 These were 'int' variables that could overflow on 64-bit hosts;
291 they were never used, so remove them instead of repairing them.
292 (nzombies, ngcs, max_live, max_zombies): Now EMACS_INT, not 'int'.
293 (inhibit_garbage_collection): Set gc_cons_threshold to max value.
294 Previously, this ceilinged at INT_MAX, but that doesn't work on
296 (allocate_pseudovector): Don't use EMACS_INT when int would do.
298 * alloc.c (Fmake_bool_vector): Don't assume vector size fits in int.
299 (allocate_vectorlike): Check for ptrdiff_t overflow.
300 (mark_vectorlike, mark_char_table, mark_object): Avoid EMACS_UINT
301 when a (possibly-narrower) signed value would do just as well.
302 We prefer using signed arithmetic, to avoid comparison confusion.
304 * alloc.c: Catch some string size overflows that we were missing.
305 (XMALLOC_OVERRUN_CHECK_SIZE) [!XMALLOC_OVERRUN_CHECK]: Define to 0,
306 for convenience in STRING_BYTES_MAX.
307 (STRING_BYTES_MAX): New macro, superseding the old one in lisp.h.
308 The definition here is exact; the one in lisp.h was approximate.
309 (allocate_string_data): Check for string overflow. This catches
310 some instances we weren't catching before. Also, it catches
311 size_t overflow on (unusual) hosts where SIZE_MAX <= min
312 (PTRDIFF_MAX, MOST_POSITIVE_FIXNUM), e.g., when size_t is 32 bits
313 and ptrdiff_t and EMACS_INT are both 64 bits.
315 * character.c, coding.c, doprnt.c, editfns.c, eval.c:
316 All uses of STRING_BYTES_MAX replaced by STRING_BYTES_BOUND.
317 * lisp.h (STRING_BYTES_BOUND): Renamed from STRING_BYTES_MAX.
319 * character.c (string_escape_byte8): Fix nbytes/nchars typo.
321 * alloc.c (Fmake_string): Check for out-of-range init.
323 2011-06-15 Stefan Monnier <monnier@iro.umontreal.ca>
325 * eval.c (Fdefvaralias): Also mark the target as variable-special-p.
327 2011-06-14 Jan Djärv <jan.h.d@swipnet.se>
329 * xfns.c (x_set_scroll_bar_default_width): Remove argument to
330 xg_get_default_scrollbar_width.
332 * gtkutil.c: Include emacsgtkfixed.h if HAVE_GTK3.
333 (int_gtk_range_get_value): Move to the scroll bar part of the file.
334 (style_changed_cb): Call update_theme_scrollbar_width and call
335 x_set_scroll_bar_default_width and xg_frame_set_char_size for
336 all frames (Bug#8505).
337 (xg_create_frame_widgets): Call emacs_fixed_new if HAVE_GTK3 (Bug#8505).
338 Call gtk_window_set_resizable if HAVE_GTK3.
339 (x_wm_set_size_hint): Call emacs_fixed_set_min_size with min width
340 and height if HAVE_GTK3 (Bug#8505).
341 (scroll_bar_width_for_theme): New variable.
342 (update_theme_scrollbar_width): New function.
343 (xg_get_default_scrollbar_width): Move code to
344 update_theme_scrollbar_width, just return scroll_bar_width_for_theme.
345 (xg_initialize): Call update_theme_scrollbar_width.
347 * gtkutil.h (xg_get_default_scrollbar_width): Remove argument.
349 * emacsgtkfixed.c, emacsgtkfixed.h: New files.
351 2011-06-12 Martin Rudalics <rudalics@gmx.at>
353 * frame.c (make_frame): Call other_buffer_safely instead of
356 * window.c (temp_output_buffer_show): Call display_buffer with
357 second argument Vtemp_buffer_show_specifiers and reset latter
358 immediately after the call.
359 (Vtemp_buffer_show_specifiers): New variable.
360 (auto_window_vscroll_p, next_screen_context_lines)
361 (Vscroll_preserve_screen_position): Remove leading asterisks from
364 2011-06-12 Paul Eggert <eggert@cs.ucla.edu>
366 Fix minor problems found by GCC 4.6.0 static checking.
367 * buffer.c (Qclone_number): Remove for now, as it's unused.
368 (record_buffer, Funrecord_buffer): Rename local to avoid shadowing.
369 (record_buffer): Remove unused local.
370 * frame.c (other_visible_frames, frame_buffer_list): Now static.
371 (set_frame_buffer_list): Remove; unused.
372 * frame.h (other_visible_frames): Remove decl.
373 * keyboard.h (menu_items_inuse): Declare only if USE_GTK || USE_MOTIF.
374 * lisp.h (frame_buffer_list, set_frame_buffer_list): Remove decls.
375 (add_gpm_wait_descriptor, delete_gpm_wait_descriptor): Declare only
377 * menu.c (menu_items_inuse): Now static unless USE_GTK || USE_MOTIF.
378 * process.c (add_gpm_wait_descriptor, delete_gpm_wait_descriptor):
379 Define only if HAVE_GPM.
380 * widget.c (EmacsFrameResize, emacsFrameClassRec): Now static.
381 (update_hints_inhibit): Remove; never set. All uses removed.
382 * widgetprv.h (emacsFrameClassRec): Remove decl.
383 * window.c (delete_deletable_window): Now returns void, since it
384 wasn't returning anything.
385 (compare_window_configurations): Remove unused locals.
386 * xfns.c (x_set_scroll_bar_default_width): Remove unused locals.
387 * xmenu.c (x_menu_set_in_use): Define only if USE_GTK || USE_MOTIF.
388 (dialog_selection_callback) [!USE_GTK]: Prefer intptr_t for integers
389 the same widths as pointers. This follows up on the 2011-05-06 patch.
390 * xterm.c (x_alloc_lighter_color_for_widget): Define only if USE_LUCID.
392 (x_menu_set_in_use): Declare only if USE_GTK || USE_MOTIF.
394 2011-06-12 Juanma Barranquero <lekktu@gmail.com>
396 * makefile.w32-in: Update dependencies.
397 (LISP_H): Add lib/intprops.h.
399 2011-06-11 Chong Yidong <cyd@stupidchicken.com>
401 * image.c (gif_load): Add animation frame delay to the metadata.
402 (syms_of_image): Use DEFSYM. New symbol `delay'.
404 2011-06-11 Martin Rudalics <rudalics@gmx.at>
406 * window.c (delete_deletable_window): Re-add.
407 (Fset_window_configuration): Rewrite to handle dead buffers and
408 consequently deletable windows.
409 (window_tree, Fwindow_tree): Remove. Supply functionality in
411 (compare_window_configurations): Simplify code.
413 2011-06-11 Andreas Schwab <schwab@linux-m68k.org>
415 * image.c (imagemagick_load_image): Fix type mismatch.
416 (Fimagemagick_types): Likewise.
418 * window.h (replace_buffer_in_windows): Declare.
420 2011-06-11 Martin Rudalics <rudalics@gmx.at>
422 * buffer.c: New Lisp objects Qbuffer_list_update_hook and
423 Qclone_number. Remove external declaration of Qdelete_window.
424 (Fbuffer_list): Rewrite doc-string. Minor restructuring of
426 (Fget_buffer_create, Fmake_indirect_buffer, Frename_buffer): Run
427 Qbuffer_list_update_hook if allowed.
428 (Fother_buffer): Rewrite doc-string. Major rewrite for new
429 buffer list implementation.
430 (other_buffer_safely): New function.
431 (Fkill_buffer): Replace call to replace_buffer_in_all_windows by
432 calls to replace_buffer_in_windows and
433 replace_buffer_in_windows_safely. Run Qbuffer_list_update_hook
435 (record_buffer): Inhibit quitting and rewrite using quittable
436 functions. Run Qbuffer_list_update_hook if allowed.
437 (Frecord_buffer, Funrecord_buffer): New functions.
438 (switch_to_buffer_1, Fswitch_to_buffer): Remove. Move
439 switch-to-buffer to window.el.
440 (bury-buffer): Move to window.el.
441 (Vbuffer_list_update_hook): New variable.
443 * lisp.h (other_buffer_safely): Add prototype in buffer.c
446 * window.h (resize_frame_windows): Move up in code.
447 (Fwindow_frame): Remove EXFUN.
448 (replace_buffer_in_all_windows): Remove prototype.
449 (replace_buffer_in_windows_safely): Add prototype.
451 * window.c: Declare Qdelete_window static again. Move down
452 declaration of select_count.
453 (Fnext_window, Fprevious_window): Rewrite doc-strings.
454 (Fother_window): Move to window.el.
455 (window_loop): Remove DELETE_BUFFER_WINDOWS and UNSHOW_BUFFER
456 cases. Add REPLACE_BUFFER_IN_WINDOWS_SAFELY case.
457 (Fdelete_windows_on, Freplace_buffer_in_windows): Move to
459 (replace_buffer_in_windows): Implement by calling
460 Qreplace_buffer_in_windows.
461 (replace_buffer_in_all_windows): Remove with some functionality
462 moved into replace_buffer_in_windows_safely.
463 (replace_buffer_in_windows_safely): New function.
464 (select_window_norecord, select_frame_norecord): Move in front
465 of run_window_configuration_change_hook. Remove now obsolete
467 (Fset_window_buffer): Rewrite doc-string. Call
468 Qrecord_window_buffer.
469 (keys_of_window): Move binding for other-window to window.el.
471 2011-06-11 Chong Yidong <cyd@stupidchicken.com>
473 * dispextern.h (struct image): Replace data member, whose int_val
474 and ptr_val fields were not used by anything, with a single
477 * image.c (Fimage_metadata, make_image, mark_image, tiff_load)
478 (gif_clear_image, gif_load, imagemagick_load_image)
479 (gs_clear_image, gs_load): Callers changed.
481 2011-06-10 Paul Eggert <eggert@cs.ucla.edu>
483 * buffer.h: Include <time.h>, for time_t.
484 Needed to build on FreeBSD 8.2. Problem reported by Herbert J. Skuhra.
486 Fix minor problems found by static checking.
488 * image.c (PixelGetMagickColor): Declare if ImageMagick headers don't.
490 Make identifiers static if they are not used in other modules.
491 * data.c (Qcompiled_function, Qframe, Qvector):
492 * image.c (QimageMagick, Qsvg):
493 * minibuf.c (Qmetadata):
494 * window.c (resize_window_check, resize_root_window): Now static.
495 * window.h (resize_window_check, resize_root_window): Remove decls.
497 * window.c (window_deletion_count, delete_deletable_window):
499 (window_body_lines): Now static.
500 (Fdelete_other_windows_internal): Mark vars as initialized.
501 Make sure 'resize_failed' is initialized.
502 (run_window_configuration_change_hook): Rename local to avoid shadowing.
503 (resize_window_apply): Remove unused local.
504 * window.h (delete_deletable_window): Remove decl.
506 * image.c (gif_load, svg_load_image): Rename locals to avoid shadowing.
507 (imagemagick_load_image): Fix pointer signedness problem by changing
508 last arg from unsigned char * to char *. All uses changed.
509 Also, fix a local for similar reasons.
510 Remove unused locals. Remove locals to avoid shadowing.
511 (fn_rsvg_handle_free): Remove; unused.
512 (svg_load, svg_load_image): Fix pointer signedness problem.
513 (imagemagick_load_image): Don't use garbage pointer image_wand.
515 * ftfont.c (ftfont_get_metrics, ftfont_drive_otf): Remove unused locals.
517 2011-06-10 Chong Yidong <cyd@stupidchicken.com>
519 * image.c (gif_load): Fix omitted cast error introduced by
522 2011-06-10 Martin Rudalics <rudalics@gmx.at>
524 * window.h (resize_proportionally, orig_total_lines)
525 (orig_top_line): Remove from window structure.
526 (set_window_height, set_window_width, change_window_heights)
527 (Fdelete_window): Remove prototypes.
528 (resize_frame_windows): Remove duplicate declaration.
530 2011-06-10 Eli Zaretskii <eliz@gnu.org>
532 * window.h (resize_frame_windows, resize_window_check)
533 (delete_deletable_window, resize_root_window)
534 (resize_frame_windows): Declare prototypes.
536 * window.c (resize_window_apply): Make definition be "static" to
539 2011-06-10 Martin Rudalics <rudalics@gmx.at>
541 * window.c: Remove declarations of Qwindow_size_fixed,
542 window_min_size_1, window_min_size_2, window_min_size,
543 size_window, window_fixed_size_p, enlarge_window, delete_window.
544 Remove static from declaration of Qdelete_window, it's
545 temporarily needed by Fbury_buffer.
546 (replace_window): Don't assign orig_top_line and
548 (Fdelete_window, delete_window): Remove. Window deletion is
549 handled by window.el.
550 (window_loop): Remove DELETE_OTHER_WINDOWS case. Replace
551 Fdelete_window calls with calls to Qdelete_window.
552 (Fdelete_other_windows): Remove. Deleting other windows is
553 handled by window.el.
554 (window_fixed_size_p): Remove. Fixed-sizeness of windows is
555 handled in window.el.
556 (window_min_size_2, window_min_size_1, window_min_size): Remove.
557 Window minimum sizes are handled in window.el.
558 (shrink_windows, size_window, set_window_height)
559 (set_window_width, change_window_heights, window_height)
560 (window_width, CURBEG, CURSIZE, enlarge_window)
561 (adjust_window_trailing_edge, Fadjust_window_trailing_edge)
562 (Fenlarge_window, Fshrink_window): Remove. Window resizing is
563 handled in window.el.
564 (make_dummy_parent): Rename to make_parent_window and give it a
565 second argument horflag.
566 (make_window): Don't set resize_proportionally any more.
567 (Fsplit_window): Remove. Windows are split in window.el.
568 (save_restore_action, save_restore_orig_size)
569 (shrink_window_lowest_first, save_restore_orig_size): Remove.
570 Resize mini windows in window.el.
571 (grow_mini_window, shrink_mini_window): Implement by calling
572 Qresize_root_window_vertically, resize_window_check and
574 (saved_window, Fset_window_configuration, save_window_save): Do
575 not handle orig_top_line, orig_total_lines, and
576 resize_proportionally.
577 (window_min_height, window_min_width): Move to window.el.
578 (keys_of_window): Move bindings for delete-other-windows,
579 split-window, delete-window and enlarge-window to window.el.
581 * buffer.c: Temporarily extern Qdelete_window.
582 (Fbury_buffer): Temporarily call Qdelete_window instead of
583 Fdelete_window (Fbury_buffer will move to window.el soon).
585 * frame.c (set_menu_bar_lines_1): Remove code handling
586 orig_top_line and orig_total_lines.
588 * dispnew.c (adjust_frame_glyphs_initially): Don't use
589 set_window_height but set heights directly.
590 (change_frame_size_1): Use resize_frame_windows.
592 * xdisp.c (init_xdisp): Don't use set_window_height but set
595 * xfns.c (x_set_menu_bar_lines, x_set_tool_bar_lines): Use
596 resize_frame_windows instead of change_window_heights and run
597 run_window_configuration_change_hook.
599 * w32fns.c (x_set_tool_bar_lines): Use resize_frame_windows
600 instead of change_window_heights and run
601 run_window_configuration_change_hook.
603 2011-06-09 Martin Rudalics <rudalics@gmx.at>
605 * window.c (replace_window): Rename second argument REPLACEMENT to
606 NEW. New third argument SETFLAG. Rewrite.
607 (delete_window, make_dummy_parent): Call replace_window with
609 (window_list_1): Move down in code.
610 (run_window_configuration_change_hook): Move set_buffer part
611 before select_frame_norecord part in order to unwind correctly.
612 Rename count1 to count.
613 (recombine_windows, delete_deletable_window, resize_root_window)
614 (Fdelete_other_windows_internal)
615 (Frun_window_configuration_change_hook, make_parent_window)
616 (resize_window_check, resize_window_apply, Fresize_window_apply)
617 (resize_frame_windows, Fsplit_window_internal)
618 (Fdelete_window_internal, Fresize_mini_window_internal): New
620 (syms_of_window): New variables Vwindow_splits and Vwindow_nest.
622 2011-06-08 Martin Rudalics <rudalics@gmx.at>
624 * window.h (window): Add some new members to window structure -
625 normal_lines, normal_cols, new_total, new_normal, clone_number,
626 splits, nest, prev_buffers, next_buffers.
627 (WINDOW_TOTAL_SIZE): Move here from window.c.
628 (MIN_SAFE_WINDOW_WIDTH, MIN_SAFE_WINDOW_HEIGHT): Define here.
630 * window.c (Fwindow_height, Fwindow_width, Fwindow_full_width_p):
632 (make_dummy_parent): Set new members of windows structure.
633 (make_window): Move down in code. Handle new members of window
635 (Fwindow_clone_number, Fwindow_splits, Fset_window_splits)
636 (Fwindow_nest, Fset_window_nest, Fwindow_new_total)
637 (Fwindow_normal_size, Fwindow_new_normal, Fwindow_prev_buffers)
638 (Fset_window_prev_buffers, Fwindow_next_buffers)
639 (Fset_window_next_buffers, Fset_window_clone_number): New
641 (Fwindow_hscroll, Fwindow_at, Fwindow_point, Fwindow_start)
642 (Fwindow_end, Fwindow_line_height, Fset_window_dedicated_p):
644 (Fwindow_parameters, Fwindow_parameter, Fset_window_parameter):
645 Argument WINDOW can be now internal window too.
646 (Fwindow_use_time): Move up in code.
647 (Fget_buffer_window): Rename argument FRAME to ALL-FRAMES.
649 (Fset_window_configuration, saved_window)
650 (Fcurrent_window_configuration, save_window_save): Handle new
651 members of window structure.
652 (WINDOW_TOTAL_SIZE, MIN_SAFE_WINDOW_WIDTH)
653 (MIN_SAFE_WINDOW_HEIGHT): Move to window.h.
654 (syms_of_window): New Lisp objects Qrecord_window_buffer,
655 Qwindow_deletable_p, Qdelete_window, Qreplace_buffer_in_windows,
656 Qget_mru_window, Qresize_root_window,
657 Qresize_root_window_vertically, Qsafe, Qabove, Qbelow,
658 Qauto_buffer_name; staticpro them.
660 2011-06-07 Martin Rudalics <rudalics@gmx.at>
662 * window.c (Fwindow_total_size, Fwindow_left_column)
663 (Fwindow_top_line, window_body_lines, Fwindow_body_size)
664 (Fwindow_list_1): New functions.
665 (window_box_text_cols): Replace with window_body_cols.
666 (Fwindow_width, Fscroll_left, Fscroll_right): Use
667 window_body_cols instead of window_box_text_cols.
668 (delete_window, Fset_window_configuration): Call
669 delete_all_subwindows with window as argument.
670 (delete_all_subwindows): Take a window as argument and not a
672 (window_loop): Remove handling of GET_LRU_WINDOW and
674 (Fget_lru_window, Fget_largest_window): Move to window.el.
676 * window.h: Extern window_body_cols instead of
677 window_box_text_cols. delete_all_subwindows now takes a
678 Lisp_Object as argument.
680 * indent.c (compute_motion, Fcompute_motion): Use
681 window_body_cols instead of window_box_text_cols.
683 * frame.c (delete_frame): Call delete_all_subwindows with root
686 2011-06-07 Daniel Colascione <dan.colascione@gmail.com>
688 * fns.c (Fputhash): Document return value.
690 2011-06-06 Chong Yidong <cyd@stupidchicken.com>
692 * image.c (gif_load): Implement gif89a spec "no disposal" method.
694 2011-06-06 Paul Eggert <eggert@cs.ucla.edu>
696 Cons<->int and similar integer overflow fixes (Bug#8794).
698 Check for overflow when converting integer to cons and back.
699 * charset.c (Fdefine_charset_internal, Fdecode_char):
700 Use cons_to_unsigned to catch overflow.
701 (Fencode_char): Use INTEGER_TO_CONS.
702 * composite.h (LGLYPH_CODE): Use cons_to_unsigned.
703 (LGLYPH_SET_CODE): Use INTEGER_TO_CONS.
704 * data.c (long_to_cons, cons_to_long): Remove.
705 (cons_to_unsigned, cons_to_signed): New functions.
706 These signal an error for invalid or out-of-range values.
707 * dired.c (Ffile_attributes): Use INTEGER_TO_CONS.
708 * fileio.c (Fset_visited_file_modtime): Use CONS_TO_INTEGER.
709 * font.c (Ffont_variation_glyphs):
710 * fontset.c (Finternal_char_font): Use INTEGER_TO_CONS.
711 * lisp.h: Include <intprops.h>.
712 (INTEGER_TO_CONS, CONS_TO_INTEGER): New macros.
713 (cons_to_signed, cons_to_unsigned): New decls.
714 (long_to_cons, cons_to_long): Remove decls.
715 * undo.c (record_first_change): Use INTEGER_TO_CONS.
716 (Fprimitive_undo): Use CONS_TO_INTEGER.
717 * xfns.c (Fx_window_property): Likewise.
718 * xselect.c: Include <limits.h>.
719 (x_own_selection, selection_data_to_lisp_data):
721 (x_handle_selection_request, x_handle_selection_clear)
722 (x_get_foreign_selection, Fx_disown_selection_internal)
723 (Fx_get_atom_name, x_send_client_event): Use CONS_TO_INTEGER.
724 (lisp_data_to_selection_data): Use cons_to_unsigned.
725 (x_fill_property_data): Use cons_to_signed.
726 Report values out of range.
728 Check for buffer and string overflow more precisely.
729 * buffer.h (BUF_BYTES_MAX): New macro.
730 * lisp.h (STRING_BYTES_MAX): New macro.
731 * alloc.c (Fmake_string):
732 * character.c (string_escape_byte8):
733 * coding.c (coding_alloc_by_realloc):
735 * editfns.c (Fformat):
737 Use STRING_BYTES_MAX, not MOST_POSITIVE_FIXNUM,
738 since they may not be the same number.
739 * editfns.c (Finsert_char):
740 * fileio.c (Finsert_file_contents):
741 Likewise for BUF_BYTES_MAX.
743 * image.c: Use ptrdiff_t, not int, for sizes.
744 (slurp_file): Switch from int to ptrdiff_t.
746 (slurp_file): Check that file size fits in both size_t (for
747 malloc) and ptrdiff_t (for sanity and safety).
749 * fileio.c (Fverify_visited_file_modtime): Avoid time overflow
750 if b->modtime has its maximal value.
752 * dired.c (Ffile_attributes): Don't assume EMACS_INT has >32 bits.
754 Don't assume time_t can fit into int.
755 * buffer.h (struct buffer.modtime): Now time_t, not int.
756 * fileio.c (Fvisited_file_modtime): No need for time_t cast now.
757 * undo.c (Fprimitive_undo): Use time_t, not int, for time_t value.
759 Minor fixes for signed vs unsigned integers.
760 * character.h (MAYBE_UNIFY_CHAR):
761 * charset.c (maybe_unify_char):
762 * keyboard.c (read_char, reorder_modifiers):
763 XINT -> XFASTINT, since the integer must be nonnegative.
764 * ftfont.c (ftfont_spec_pattern):
765 * keymap.c (access_keymap, silly_event_symbol_error):
766 XUINT -> XFASTINT, since the integer must be nonnegative.
767 (Fsingle_key_description, preferred_sequence_p): XUINT -> XINT,
768 since it makes no difference and we prefer signed.
769 * keyboard.c (record_char): Use XUINT when all the neighbors do.
770 (access_keymap): NATNUMP -> INTEGERP, since the integer must be
773 2011-06-06 Stefan Monnier <monnier@iro.umontreal.ca>
775 * window.h (Fwindow_frame): Declare.
777 2011-06-06 Paul Eggert <eggert@cs.ucla.edu>
779 * alloc.c: Simplify handling of large-request failures (Bug#8800).
780 (SPARE_MEMORY): Always define.
781 (LARGE_REQUEST): Remove.
782 (memory_full): Use SPARE_MEMORY rather than LARGE_REQUEST.
784 2011-06-06 Martin Rudalics <rudalics@gmx.at>
786 * lisp.h: Move EXFUNS for Fframe_root_window,
787 Fframe_first_window and Fset_frame_selected_window to window.h.
789 * window.h: Move EXFUNS for Fframe_root_window,
790 Fframe_first_window and Fset_frame_selected_window here from
793 * frame.c (Fwindow_frame, Fframe_first_window)
794 (Fframe_root_window, Fframe_selected_window)
795 (Fset_frame_selected_window): Move to window.c.
796 (Factive_minibuffer_window): Move to minibuf.c.
797 (Fother_visible_frames_p): New function.
799 * minibuf.c (Factive_minibuffer_window): Move here from frame.c.
801 * window.c (decode_window, decode_any_window): Move up in code.
802 (Fwindowp, Fwindow_live_p): Rewrite doc-strings.
803 (inhibit_frame_unsplittable): Remove unused variable.
804 (Fwindow_buffer): Move up and rewrite doc-string.
805 (Fwindow_parent, Fwindow_vchild, Fwindow_hchild, Fwindow_next)
806 (Fwindow_prev): New functions.
807 (Fwindow_frame): Move here from frame.c. Accept any window as
809 (Fframe_root_window, Fframe_first_window)
810 (Fframe_selected_window): Move here from frame.c. Accept frame
811 or arbitrary window as argument. Update doc-strings.
812 (Fminibuffer_window): Move up in code.
813 (Fwindow_minibuffer_p): Move up in code and simplify.
814 (Fset_frame_selected_window): Move here from frame.c.
816 (Fselected_window, select_window, Fselect_window): Move up in
817 code. Minor doc-string fixes.
819 2011-06-06 Paul Eggert <eggert@cs.ucla.edu>
821 * alloc.c (memory_full) [SYSTEM_MALLOC]: Port to MacOS (Bug#8800).
822 Do not assume that spare memory exists; that assumption is valid
823 only if SYSTEM_MALLOC.
824 (LARGE_REQUEST): New macro, so that the issue of large requests
825 is separated from the issue of spare memory.
827 2011-06-05 Andreas Schwab <schwab@linux-m68k.org>
829 * editfns.c (Fformat): Correctly handle zero flag with hexadecimal
832 * gtkutil.c (xg_get_default_scrollbar_width): Avoid warning.
834 * xfns.c (x_set_scroll_bar_default_width): Move declarations
837 2011-06-05 Jan Djärv <jan.h.d@swipnet.se>
839 * gtkutil.c (xg_get_default_scrollbar_width): New function.
841 * gtkutil.h: Declare xg_get_default_scrollbar_width.
843 * xfns.c (x_set_scroll_bar_default_width): If USE_GTK, get
844 min width by calling x_set_scroll_bar_default_width (Bug#8505).
846 2011-06-05 Juanma Barranquero <lekktu@gmail.com>
848 * xdisp.c (single_display_spec_intangible_p): Remove declaration.
850 2011-06-04 Chong Yidong <cyd@stupidchicken.com>
852 * xselect.c (x_clipboard_manager_save): Remove redundant arg.
853 (x_clipboard_manager_save): Add return value.
854 (x_clipboard_manager_error_1, x_clipboard_manager_error_2):
856 (x_clipboard_manager_save_frame, x_clipboard_manager_save_all):
857 Obey Vx_select_enable_clipboard_manager. Catch errors in
858 x_clipboard_manager_save (Bug#8779).
859 (Vx_select_enable_clipboard_manager): New variable.
860 (x_get_foreign_selection): Reduce scope of x_catch_errors (Bug#8790).
862 2011-06-04 Dan Nicolaescu <dann@ics.uci.edu>
864 * emacs.c (main): Warn when starting a GTK emacs in daemon mode.
866 2011-06-04 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
868 * fringe.c (update_window_fringes): Don't update overlay arrow bitmap
869 in the current matrix if keep_current_p is non-zero.
871 2011-06-04 Eli Zaretskii <eliz@gnu.org>
873 * bidi.c (bidi_level_of_next_char): Fix last change.
875 2011-06-03 Eli Zaretskii <eliz@gnu.org>
877 Support bidi reordering of text covered by display properties.
879 * bidi.c (bidi_copy_it): Use offsetof instead of emulating it.
880 (bidi_fetch_char, bidi_fetch_char_advance): New functions.
881 (bidi_cache_search, bidi_cache_iterator_state)
882 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak)
883 (bidi_level_of_next_char, bidi_move_to_visually_next):
884 Support character positions inside a run of characters covered by a
886 (bidi_paragraph_init, bidi_resolve_explicit_1)
887 (bidi_level_of_next_char): Call bidi_fetch_char and
888 bidi_fetch_char_advance instead of FETCH_CHAR and
890 (bidi_init_it): Initialize new members.
891 (LRE_CHAR, RLE_CHAR, PDF_CHAR, LRO_CHAR, RLO_CHAR): Remove macro
893 (bidi_explicit_dir_char): Lookup character type in bidi_type_table,
894 instead of using explicit *_CHAR codes.
895 (bidi_resolve_explicit, bidi_resolve_weak):
896 Use FETCH_MULTIBYTE_CHAR instead of FETCH_CHAR, as reordering of
897 bidirectional text is supported only in multibyte buffers.
898 (bidi_init_it): Accept additional argument FRAME_WINDOW_P and use
899 it to initialize the frame_window_p member of struct bidi_it.
900 (bidi_cache_iterator_state, bidi_resolve_explicit_1)
901 (bidi_resolve_explicit, bidi_resolve_weak)
902 (bidi_level_of_next_char, bidi_move_to_visually_next): Abort if
903 bidi_it->nchars is non-positive.
904 (bidi_level_of_next_char): Don't try to lookup the cache for the
905 next/previous character if nothing is cached there yet, or if we
906 were just reseat()'ed to a new position.
908 * xdisp.c (set_cursor_from_row): Set start and stop points
909 according to the row's direction when priming the loop that looks
910 for the glyph on which to display cursor.
911 (single_display_spec_intangible_p): Function deleted.
912 (display_prop_intangible_p): Reimplement to call
913 handle_display_spec instead of single_display_spec_intangible_p.
914 Accept 3 additional arguments needed by handle_display_spec.
915 This fixes incorrect cursor motion across display property with complex
916 values: lists, `(when COND...)' forms, etc.
917 (single_display_spec_string_p): Support property values that are
918 lists with the argument STRING its top-level element.
919 (display_prop_string_p): Fix the condition for processing a
920 property that is a list to be consistent with handle_display_spec.
921 (handle_display_spec): New function, refactored from the
922 last portion of handle_display_prop.
923 (compute_display_string_pos): Accept additional argument
924 FRAME_WINDOW_P. Call handle_display_spec to determine whether the
925 value of a `display' property is a "replacing spec".
926 (handle_single_display_spec): Accept 2 additional arguments BUFPOS
927 and FRAME_WINDOW_P. If IT is NULL, don't set up the iterator from
928 the display property, but just return a value indicating whether
929 the display property will replace the characters it covers.
930 (Fcurrent_bidi_paragraph_direction): Initialize the nchars and
931 frame_window_p members of struct bidi_it.
932 (compute_display_string_pos, compute_display_string_end):
934 (push_it): Accept second argument POSITION, where pop_it should
935 jump to continue iteration.
936 (reseat_1): Initialize bidi_it.disp_pos.
938 * keyboard.c (adjust_point_for_property): Adjust the call to
939 display_prop_intangible_p to its new signature.
941 * dispextern.h (struct bidi_it): New member frame_window_p.
942 (bidi_init_it): Update prototypes.
943 (display_prop_intangible_p): Update prototype.
944 (compute_display_string_pos, compute_display_string_end):
946 (struct bidi_it): New members nchars and disp_pos. ch_len is now
949 2011-06-02 Paul Eggert <eggert@cs.ucla.edu>
951 Malloc failure behavior now depends on size of allocation.
952 * alloc.c (buffer_memory_full, memory_full): New arg NBYTES.
953 * lisp.h: Change signatures accordingly.
954 * alloc.c, buffer.c, editfns.c, menu.c, minibuf.c, xterm.c:
955 All callers changed. (Bug#8762)
957 * gnutls.c: Use Emacs's memory allocators.
958 Without this change, the gnutls library would invoke malloc etc.
959 directly, which causes problems on non-SYNC_INPUT hosts, and which
960 runs afoul of improving memory_full behavior. (Bug#8761)
961 (fn_gnutls_global_set_mem_functions): New macro or function pointer.
962 (emacs_gnutls_global_init): Use it to specify xmalloc, xrealloc,
963 xfree instead of the default malloc, realloc, free.
964 (Fgnutls_boot): No need to check for memory allocation failure,
965 since xmalloc does that for us.
967 Remove arbitrary limit of 2**31 entries in hash tables. (Bug#8771)
968 * category.c (hash_get_category_set):
969 * ccl.c (ccl_driver):
970 * charset.c (Fdefine_charset_internal):
971 * charset.h (struct charset.hash_index):
972 * composite.c (get_composition_id, gstring_lookup_cache)
973 (composition_gstring_put_cache):
974 * composite.h (struct composition.hash_index):
975 * dispextern.h (struct image.hash):
976 * fns.c (next_almost_prime, larger_vector, cmpfn_eql)
977 (cmpfn_equal, cmpfn_user_defined, hashfn_eq, hashfn_eql)
978 (hashfn_equal, hashfn_user_defined, make_hash_table)
979 (maybe_resize_hash_table, hash_lookup, hash_put)
980 (hash_remove_from_table, hash_clear, sweep_weak_table, SXHASH_COMBINE)
981 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector)
982 (Fsxhash, Fgethash, Fputhash, Fmaphash):
983 * image.c (make_image, search_image_cache, lookup_image)
984 (xpm_put_color_table_h):
985 * lisp.h (struct Lisp_Hash_Table):
986 * minibuf.c (Ftry_completion, Fall_completions, Ftest_completion):
987 * print.c (print): Use 'EMACS_UINT' and 'EMACS_INT'
988 for hashes and hash indexes, instead of 'unsigned' and 'int'.
989 * alloc.c (allocate_vectorlike):
990 Check for overflow in vector size calculations.
991 * ccl.c (ccl_driver):
992 Check for overflow when converting EMACS_INT to int.
993 * fns.c, image.c: Remove unnecessary static decls that would otherwise
994 need to be updated by these changes.
995 * fns.c (make_hash_table, maybe_resize_hash_table):
996 Check for integer overflow with large hash tables.
997 (make_hash_table, maybe_resize_hash_table, Fmake_hash_table):
998 Prefer the faster XFLOAT_DATA to XFLOATINT where either will do.
999 (SXHASH_REDUCE): New macro.
1000 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector):
1001 Use it instead of discarding useful hash info with large hash values.
1002 (sxhash_float): New function.
1003 (sxhash): Use it. No more need for "& INTMASK" due to above changes.
1004 * lisp.h (FIXNUM_BITS): New macro, useful for SXHASH_REDUCE etc.
1005 (MOST_NEGATIVE_FIXNUM, MOST_POSITIVE_FIXNUM, INTMASK):
1006 Rewrite to use FIXNUM_BITS, as this simplifies things.
1007 (next_almost_prime, larger_vector, sxhash, hash_lookup, hash_put):
1008 Adjust signatures to match updated version of code.
1009 (consing_since_gc): Now EMACS_INT, since a single hash table can
1010 use more than INT_MAX bytes.
1012 2011-06-01 Dan Nicolaescu <dann@ics.uci.edu>
1014 Make it possible to build with GCC-4.6+ -O2 -flto.
1016 * emacs.c (__malloc_initialize_hook): Mark as EXTERNALLY_VISIBLE.
1018 2011-06-01 Stefan Monnier <monnier@iro.umontreal.ca>
1020 * minibuf.c (get_minibuffer, read_minibuf_unwind):
1021 Call minibuffer-inactive-mode.
1023 2011-05-31 Juanma Barranquero <lekktu@gmail.com>
1025 * makefile.w32-in ($(BLD)/data.$(O), $(BLD)/editfns.$(O)):
1026 Update dependencies.
1028 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
1030 * data.c (init_data): Remove code for UTS, this system is not
1033 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
1035 Don't force ./temacs to start in terminal mode.
1037 * frame.c (make_initial_frame): Initialize faces in all cases, not
1038 only when CANNOT_DUMP is defined.
1039 * dispnew.c (init_display): Remove CANNOT_DUMP condition.
1041 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
1043 * dispnew.c (add_window_display_history): Use const for the string
1044 pointer. Remove declaration, not needed.
1046 2011-05-31 Paul Eggert <eggert@cs.ucla.edu>
1048 Use 'inline', not 'INLINE'.
1049 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00914.html>
1050 * alloc.c, fontset.c (INLINE): Remove.
1051 * alloc.c, bidi.c, charset.c, coding.c, dispnew.c, fns.c, image.c:
1052 * intervals.c, keyboard.c, process.c, syntax.c, textprop.c, w32term.c:
1053 * xdisp.c, xfaces.c, xterm.c: Replace all uses of INLINE with inline.
1054 * gmalloc.c (register_heapinfo): Use inline unconditionally.
1055 * lisp.h (LISP_MAKE_RVALUE): Use inline, not __inline__.
1057 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
1059 Make it possible to run ./temacs.
1061 * callproc.c (set_initial_environment): Remove CANNOT_DUMP code,
1062 syms_of_callproc does the same thing. Remove test for
1063 "initialized", do it in the caller.
1064 * emacs.c (main): Avoid calling set_initial_environment when dumping.
1066 2011-05-31 Stefan Monnier <monnier@iro.umontreal.ca>
1068 * minibuf.c (Finternal_complete_buffer): Return `category' metadata.
1069 (read_minibuf): Use get_minibuffer.
1070 (syms_of_minibuf): Use DEFSYM.
1071 (Qmetadata): New var.
1072 * data.c (Qbuffer): Don't make it static.
1073 (syms_of_data): Use DEFSYM.
1075 2011-05-31 Paul Eggert <eggert@cs.ucla.edu>
1077 * ccl.c (CCL_CODE_RANGE): Allow negative numbers. (Bug#8751)
1078 (CCL_CODE_MIN): New macro.
1080 2011-05-30 Paul Eggert <eggert@cs.ucla.edu>
1082 * alloc.c (lisp_align_malloc): Omit unnecessary val==NULL tests.
1084 * eval.c (Qdebug): Now static.
1085 * lisp.h (Qdebug): Remove decl. This reverts a part of the
1086 2011-04-26T11:26:05Z!dan.colascione@gmail.com that inadvertently undid part of
1087 2011-04-14T06:48:41Z!eggert@cs.ucla.edu.
1089 2011-05-29 Chong Yidong <cyd@stupidchicken.com>
1091 * image.c: Various fixes to ImageMagick code comments.
1092 (Fimagemagick_types): Doc fix.
1094 2011-05-29 Paul Eggert <eggert@cs.ucla.edu>
1096 Minor fixes prompted by GCC 4.6.0 warnings.
1098 * xselect.c (converted_selections, conversion_fail_tag): Now static.
1100 * emacs.c [HAVE_X_WINDOWS]: Include "xterm.h".
1101 (x_clipboard_manager_save_all): Move extern decl to ...
1102 * xterm.h: ... here, so that it can be checked for consistency.
1104 2011-05-29 Chong Yidong <cyd@stupidchicken.com>
1106 * xselect.c (x_clipboard_manager_save_frame)
1107 (x_clipboard_manager_save_all): New functions.
1108 (Fx_clipboard_manager_save): Lisp function deleted.
1110 * emacs.c (Fkill_emacs): Call x_clipboard_manager_save_all.
1111 * frame.c (delete_frame): Call x_clipboard_manager_save_frame.
1113 * xterm.h: Update prototype.
1115 2011-05-28 William Xu <william.xwl@gmail.com>
1117 * nsterm.m (ns_term_shutdown): Synchronize user defaults before
1120 2011-05-28 Jim Meyering <meyering@redhat.com>
1122 Avoid a sign-extension bug in crypto_hash_function.
1123 * fns.c (to_uchar): Define.
1124 (crypto_hash_function): Use it to convert some newly-signed
1125 variables to unsigned, to avoid sign-extension bugs. For example,
1126 without this change, (md5 "truc") would evaluate to
1127 45723a2aff78ff4fff7fff1114760e62 rather than the expected
1128 45723a2af3788c4ff17f8d1114760e62. Reported by Antoine Levitt in
1129 https://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00883.html.
1131 2011-05-27 Paul Eggert <eggert@cs.ucla.edu>
1133 Integer overflow fixes.
1135 * dbusbind.c: Serial number integer overflow fixes.
1136 (CHECK_DBUS_SERIAL_GET_SERIAL): New macro.
1137 (Fdbus_call_method_asynchronously, xd_read_message_1): Use a float
1138 to hold a serial number that is too large for a fixnum.
1139 (Fdbus_method_return_internal, Fdbus_method_error_internal):
1140 Check for serial numbers out of range. Decode any serial number
1141 that was so large that it became a float. (Bug#8722)
1143 * dbusbind.c: Use XFASTINT rather than XUINT, and check for nonneg.
1144 (Fdbus_call_method, Fdbus_call_method_asynchronously):
1145 Use XFASTINT rather than XUINT when numbers are nonnegative.
1146 (xd_append_arg, Fdbus_method_return_internal):
1147 (Fdbus_method_error_internal): Likewise. Also, for unsigned
1148 arguments, check that Lisp number is nonnegative, rather than
1149 silently wrapping negative numbers around. (Bug#8722)
1150 (xd_read_message_1): Don't assume dbus_uint32_t can fit in int.
1153 * data.c (arith_driver, Flsh): Avoid unnecessary casts to EMACS_UINT.
1155 * ccl.c (ccl_driver): Redo slightly to avoid the need for 'unsigned'.
1157 ccl: add integer overflow checks
1158 * ccl.c (CCL_CODE_MAX, GET_CCL_RANGE, GET_CCL_CODE, GET_CCL_INT):
1159 (IN_INT_RANGE): New macros.
1160 (ccl_driver): Use them to check for integer overflow when
1161 decoding a CCL program. Many of the new checks are whether XINT (x)
1162 fits in int; it doesn't always, on 64-bit hosts. The new version
1163 doesn't catch all possible integer overflows, but it's an
1164 improvement. (Bug#8719)
1166 * alloc.c (make_event_array): Use XINT, not XUINT.
1167 There's no need for unsigned here.
1169 * mem-limits.h (EXCEEDS_LISP_PTR) [!USE_LSB_TAG]: EMACS_UINT -> uintptr_t
1170 This follows up to the 2011-05-06 change that substituted uintptr_t
1171 for EMACS_INT. This case wasn't caught back then.
1173 Rework Fformat to avoid integer overflow issues.
1174 * editfns.c: Include <float.h> unconditionally, as it's everywhere
1175 now (part of C89). Include <verify.h>.
1176 (MAX_10_EXP, CONVERTED_BYTE_SIZE): Remove; no longer needed.
1177 (pWIDE, pWIDElen, signed_wide, unsigned_wide): New defns.
1178 (Fformat): Avoid the prepass trying to compute sizes; it was only
1179 approximate and thus did not catch overflow reliably. Instead, walk
1180 through the format just once, formatting and computing sizes as we go,
1181 checking for integer overflow at every step, and allocating a larger
1182 buffer as needed. Keep track separately whether the format is
1183 multibyte. Keep only the most-recently calculated precision, rather
1184 than them all. Record whether each argument has been converted to
1185 string. Use EMACS_INT, not int, for byte and char and arg counts.
1186 Support field widths and precisions larger than INT_MAX. Avoid
1187 sprintf's undefined behavior with conversion specifications such as %#d
1188 and %.0c. Fix bug with strchr succeeding on '\0' when looking for
1189 flags. Fix bug with (format "%c" 256.0). Avoid integer overflow when
1190 formatting out-of-range floating point numbers with int
1193 * lisp.h (FIXNUM_OVERFLOW_P): Work even if arg is a NaN.
1195 * data.c: Avoid integer truncation in expressions involving floats.
1196 * data.c: Include <intprops.h>.
1197 (arith_driver): When there's an integer overflow in an expression
1198 involving floating point, convert the integers to floating point
1199 so that the resulting value does not suffer from catastrophic
1200 integer truncation. For example, on a 64-bit host (* 4
1201 most-negative-fixnum 0.5) should yield about -4.6e+18, not zero.
1202 Do not rely on undefined behavior after integer overflow.
1204 merge count_size_as_multibyte, parse_str_to_multibyte
1205 * character.c, character.h (count_size_as_multibyte):
1206 Rename from parse_str_to_multibyte; all uses changed.
1207 Check for integer overflow.
1208 * insdel.c, lisp.h (count_size_as_multibyte): Remove,
1209 since it's now a duplicate of the other. This is more of
1210 a character than a buffer op, so better that it's in character.c.
1211 * fns.c, print.c: Adjust to above changes.
1213 2011-05-27 Stefan Monnier <monnier@iro.umontreal.ca>
1215 * xselect.c (x_convert_selection): Yet another int/Lisp_Object mixup.
1217 2011-05-27 Paul Eggert <eggert@cs.ucla.edu>
1219 * xselect.c: Fix minor problems prompted by GCC 4.6.0 warnings.
1220 (x_handle_selection_request, frame_for_x_selection): Remove unused vars.
1221 (x_clipboard_manager_save): Now static.
1222 (Fx_clipboard_manager_save): Rename local to avoid shadowing.
1224 * fns.c: Fix minor problems prompted by GCC 4.6.0 warnings.
1225 (crypto_hash_function): Now static.
1226 Fix pointer signedness problems. Avoid unnecessary initializations.
1228 2011-05-27 Chong Yidong <cyd@stupidchicken.com>
1230 * termhooks.h (Vselection_alist): Make it terminal-local.
1232 * terminal.c (create_terminal): Initialize it.
1234 * xselect.c: Support for clipboard managers.
1235 (Vselection_alist): Move to termhooks.h as terminal-local var.
1236 (LOCAL_SELECTION): New macro.
1237 (x_atom_to_symbol): Handle x_display_info_for_display fail case.
1238 (symbol_to_x_atom): Remove gratuitous arg.
1239 (x_handle_selection_request, lisp_data_to_selection_data)
1240 (x_get_foreign_selection, Fx_register_dnd_atom): Callers changed.
1241 (x_own_selection, x_get_local_selection, x_convert_selection):
1242 New arg, specifying work frame. Use terminal-local Vselection_alist.
1243 (some_frame_on_display): Delete unused function.
1244 (Fx_own_selection_internal, Fx_get_selection_internal)
1245 (Fx_disown_selection_internal, Fx_selection_owner_p)
1246 (Fx_selection_exists_p): New optional frame arg.
1247 (frame_for_x_selection, Fx_clipboard_manager_save): New functions.
1248 (x_handle_selection_clear): Don't treat other terminals with the
1249 same keyboard specially. Use the terminal-local Vselection_alist.
1250 (x_clear_frame_selections): Use Frun_hook_with_args.
1252 * xterm.c (x_term_init): Intern ATOM and CLIPBOARD_MANAGER atoms.
1254 * xterm.h: Add support for those atoms.
1256 2011-05-26 Chong Yidong <cyd@stupidchicken.com>
1258 * xselect.c: ICCCM-compliant handling of MULTIPLE targets.
1259 (converted_selections, conversion_fail_tag): New global variables.
1260 (x_selection_request_lisp_error): Free the above.
1261 (x_get_local_selection): Remove unnecessary code.
1262 (x_reply_selection_request): Args changed; handle arbitrary array
1263 of converted selections stored in converted_selections.
1264 Separate the XChangeProperty and SelectionNotify steps.
1265 (x_handle_selection_request): Rewrite to handle MULTIPLE target.
1266 (x_convert_selection): New function.
1267 (x_handle_selection_event): Simplify.
1268 (x_get_foreign_selection): Don't ignore incoming requests while
1269 waiting for an answer; this will fail when we implement
1270 SAVE_TARGETS, and seems unnecessary anyway.
1271 (selection_data_to_lisp_data): Recognize ATOM_PAIR type.
1272 (Vx_sent_selection_functions): Doc fix.
1274 2011-05-26 Leo Liu <sdl.web@gmail.com>
1276 * editfns.c (Ftranspose_regions): Allow empty regions. (Bug#8699)
1278 2011-05-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
1280 * dispextern.h (struct glyph_row): New member fringe_bitmap_periodic_p.
1282 * dispnew.c (shift_glyph_matrix, scrolling_window): Mark scrolled row
1283 for fringe update if it has periodic bitmap.
1284 (row_equal_p): Also compare left_fringe_offset, right_fringe_offset,
1285 and fringe_bitmap_periodic_p.
1287 * fringe.c (get_fringe_bitmap_data): New function.
1288 (draw_fringe_bitmap_1, update_window_fringes): Use it.
1289 (update_window_fringes): Record periodicity of fringe bitmap in glyph
1290 row. Mark glyph row for fringe update if periodicity changed.
1292 * xdisp.c (try_window_reusing_current_matrix): Don't mark scrolled row
1293 for fringe update unless it has periodic bitmap.
1295 2011-05-25 Kenichi Handa <handa@m17n.org>
1297 * xdisp.c (get_next_display_element): Set correct it->face_id for
1298 a static composition.
1300 2011-05-24 Leo Liu <sdl.web@gmail.com>
1303 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha1.h.
1305 * fns.c (crypto_hash_function, Fsha1): New function.
1306 (Fmd5): Use crypto_hash_function.
1307 (syms_of_fns): Add Ssha1.
1309 2011-05-22 Paul Eggert <eggert@cs.ucla.edu>
1311 * gnutls.c: Remove unused macros.
1312 (fn_gnutls_transport_set_lowat, fn_gnutls_transport_set_pull_function):
1313 (fn_gnutls_transport_set_push_function) [!WINDOWSNT]:
1314 Remove macros that are defined and never used.
1315 Caught by gcc -Wunused-macros (GCC 4.6.0, Fedora 14).
1317 2011-05-22 Chong Yidong <cyd@stupidchicken.com>
1319 * xselect.c (syms_of_xselect): Remove unused symbol SAVE_TARGETS.
1320 (Fx_get_selection_internal): Minor cleanup.
1321 (Fx_own_selection_internal): Rename arguments for consistency with
1324 2011-05-22 Paul Eggert <eggert@cs.ucla.edu>
1326 * xselect.c (QSAVE_TARGETS): New static var, to fix build failure.
1328 2011-05-22 Chong Yidong <cyd@stupidchicken.com>
1330 * xselect.c (syms_of_xselect): Include character.h; use DEFSYM.
1332 2011-05-21 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
1334 * dispnew.c (scrolling_window): Don't exclude the case that the
1335 last enabled row in the desired matrix touches the bottom boundary.
1337 2011-05-21 Glenn Morris <rgm@gnu.org>
1339 * Makefile.in ($(etc)/DOC): Make second command line even shorter.
1340 (SOME_MACHINE_OBJECTS): Replace FONT_OBJ by its maximal expansion,
1341 and add some more files.
1343 2011-05-20 Eli Zaretskii <eliz@gnu.org>
1345 * callproc.c (Fcall_process) [MSDOS]: Fix arguments to
1346 report_file_error introduced by the change from 2011-05-07.
1348 2011-05-20 Paul Eggert <eggert@cs.ucla.edu>
1350 * systime.h (Time): Define only if emacs is defined.
1351 This is to allow ../lib-src/profile.c to be compiled on FreeBSD,
1352 where the include path doesn't have X11/X.h by default. See
1353 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00561.html>.
1355 2011-05-20 Kenichi Handa <handa@m17n.org>
1357 * composite.c (find_automatic_composition): Fix previous change.
1359 2011-05-20 Glenn Morris <rgm@gnu.org>
1361 * lisp.mk: New file, split from Makefile.in.
1362 * Makefile.in (lisp): Move to separate file, inserted by @lisp_frag@.
1363 (shortlisp): Remove.
1364 ($(etc)/DOC): Edit lisp.mk rather than using $shortlisp.
1366 2011-05-19 Glenn Morris <rgm@gnu.org>
1368 * Makefile.in (MSDOS_SUPPORT_REAL, MSDOS_SUPPORT, NS_SUPPORT)
1369 (REAL_MOUSE_SUPPORT, GPM_MOUSE_SUPPORT, MOUSE_SUPPORT, TOOLTIP_SUPPORT)
1370 (BASE_WINDOW_SUPPORT, X_WINDOW_SUPPORT, WINDOW_SUPPORT): Remove.
1371 (lisp): Set the order to that of loadup.el.
1372 (shortlisp): Make it a copy of $lisp.
1373 (SOME_MACHINE_LISP): Remove.
1374 ($(etc)/DOC): Depend just on $lisp, not $SOME_MACHINE_LISP too.
1375 Use just $shortlisp, not $SOME_MACHINE_LISP too.
1377 2011-05-18 Kenichi Handa <handa@m17n.org>
1379 * composite.c (CHAR_COMPOSABLE_P): Add more check for efficiency.
1380 (BACKWARD_CHAR): Wrap the arg STOP by parenthesis.
1381 (find_automatic_composition): Mostly rewrite for efficiency.
1383 2011-05-18 Juanma Barranquero <lekktu@gmail.com>
1385 * makefile.w32-in: Update dependencies.
1387 2011-05-18 Christoph Scholtes <cschol2112@googlemail.com>
1389 * menu.c: Include limits.h (fixes the MS-Windows build broken by
1390 2011-06-18T18:49:19Z!cyd@stupidchicken.com).
1392 2011-05-18 Paul Eggert <eggert@cs.ucla.edu>
1394 Fix some integer overflow issues, such as string length overflow.
1396 * insdel.c (count_size_as_multibyte): Check for string overflow.
1398 * character.c (lisp_string_width): Check for string overflow.
1399 Use EMACS_INT, not int, for string indexes and lengths; in
1400 particular, 2nd arg is now EMACS_INT, not int. Do not crash if
1401 the resulting string length overflows an EMACS_INT; instead,
1402 report a string overflow if no precision given. When checking for
1403 precision exhaustion, use a check that cannot possibly have
1404 integer overflow. (Bug#8675)
1405 * character.h (lisp_string_width): Adjust to new signature.
1407 * alloc.c (string_overflow): New function.
1408 (Fmake_string): Use it. This doesn't change behavior, but saves
1409 a few bytes and will simplify future changes.
1410 * character.c (string_escape_byte8): Likewise.
1411 * lisp.h (string_overflow): New decl.
1413 Fixups, following up to the user-interface timestamp change.
1414 * nsterm.m (last_mouse_movement_time, ns_mouse_position): Use Time
1415 for UI timestamps, instead of unsigned long.
1416 * msdos.c (mouse_get_pos): Likewise.
1417 * w32inevt.c (movement_time, w32_console_mouse_position): Likewise.
1418 * w32gui.h (Time): Define by including "systime.h" rather than by
1419 declaring it ourselves. (Bug#8664)
1421 * dispextern.h (struct image): Don't assume time_t <= unsigned long.
1422 * image.c (clear_image_cache): Likewise.
1424 * term.c (term_mouse_position): Don't assume time_t wraparound.
1426 Be more systematic about user-interface timestamps.
1427 Before, the code sometimes used 'Time', sometimes 'unsigned long',
1428 and sometimes 'EMACS_UINT', to represent these timestamps.
1429 This change causes it to use 'Time' uniformly, as that's what X uses.
1430 This makes the code easier to follow, and makes it easier to catch
1431 integer overflow bugs such as Bug#8664.
1432 * frame.c (Fmouse_position, Fmouse_pixel_position):
1433 Use Time, not unsigned long, for user-interface timestamps.
1434 * keyboard.c (last_event_timestamp, kbd_buffer_get_event): Likewise.
1435 (button_down_time, make_lispy_position, make_lispy_movement): Likewise.
1436 * keyboard.h (last_event_timestamp): Likewise.
1437 * menu.c (Fx_popup_menu) [!HAVE_X_WINDOWS]: Likewise.
1438 * menu.h (xmenu_show): Likewise.
1439 * term.c (term_mouse_position): Likewise.
1440 * termhooks.h (struct input_event.timestamp): Likewise.
1441 (struct terminal.mouse_position_hook): Likewise.
1442 * xmenu.c (create_and_show_popup_menu, xmenu_show): Likewise.
1443 * xterm.c (XTmouse_position, x_scroll_bar_report_motion): Likewise.
1444 * systime.h (Time): New decl. Pull it in from <X11/X.h> if
1445 HAVE_X_WINDOWS, otherwise define it as unsigned long, which is
1447 * menu.h, termhooks.h: Include "systime.h", for Time.
1449 * keyboard.c (make_lispy_event): Fix problem in integer overflow.
1450 Don't assume that the difference between two unsigned long values
1451 can fit into an integer. At this point, we know button_down_time
1452 <= event->timestamp, so the difference must be nonnegative, so
1453 there's no need to cast the result if double-click-time is
1454 nonnegative, as it should be; check that it's nonnegative, just in
1455 case. This bug is triggered when events are more than 2**31 ms
1456 apart (about 25 days). (Bug#8664)
1458 * xselect.c (last_event_timestamp): Remove duplicate decl.
1459 (x_own_selection): Remove needless cast to unsigned long.
1461 * xmenu.c (set_frame_menubar): Use int, not EMACS_UINT, for indexes
1462 that always fit in int. Use a sentinel instead of a counter, to
1463 avoid a temp and to allay GCC's concerns about possible int overflow.
1464 * frame.h (struct frame): Use int for menu_bar_items_used
1465 instead of EMACS_INT, since it always fits in int.
1467 * menu.c (grow_menu_items): Check for int overflow.
1469 * xmenu.c (set_frame_menubar): Don't mishandle vectors with no nils.
1471 * xterm.c: Use EMACS_INT for Emacs modifiers, and int for X modifiers.
1472 Before, the code was not consistent. These values cannot exceed
1473 2**31 - 1 so there's no need to make them unsigned.
1474 (x_x_to_emacs_modifiers): Accept int and return EMACS_INT.
1475 (x_emacs_to_x_modifiers): Accept EMACS_INT and return int.
1476 (x_x_to_emacs_modifiers, x_emacs_to_x_modifiers): Reject non-integers
1478 * xterm.h (x_x_to_emacs_modifiers): Adjust to signature change.
1480 * lisp.h (XINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_INT.
1481 (XUINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_UINT.
1482 Otherwise, GCC 4.6.0 warns about printf (pI, XINT (...)),
1483 presumably because the widths might not match.
1485 * window.c (size_window): Avoid needless test at loop start.
1487 2011-05-18 Courtney Bane <emacs-bugs-7626@cbane.org> (tiny change)
1489 * term.c (Fresume_tty): Restore hooks before reinitializing (bug#8687).
1491 2011-05-12 Drew Adams <drew.adams@oracle.com>
1493 * textprop.c (Fprevious_single_char_property_change): Doc fix (bug#8655).
1495 2011-05-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
1497 * w32term.c (w32_draw_fringe_bitmap): Rename local vars `left' and
1498 `width' to `bar_area_x' and `bar_area_width', respectively.
1499 (x_scroll_run): Take account of fringe background extension.
1501 * xterm.c (x_draw_fringe_bitmap) [USE_TOOLKIT_SCROLL_BARS]:
1502 Rename local vars `left' and `width' to `bar_area_x' and
1503 `bar_area_width', respectively.
1504 (x_scroll_run) [USE_TOOLKIT_SCROLL_BARS]: Take account of fringe
1505 background extension.
1507 2011-05-10 Jim Meyering <meyering@redhat.com>
1509 * xdisp.c (x_intersect_rectangles): Fix typo "the the -> the".
1511 2011-05-10 Juanma Barranquero <lekktu@gmail.com>
1513 * image.c (Finit_image_library): Return t for built-in image types,
1514 like pbm and xbm. (Bug#8640)
1516 2011-05-09 Andreas Schwab <schwab@linux-m68k.org>
1518 * w32menu.c (set_frame_menubar): Fix submenu allocation.
1520 2011-05-07 Eli Zaretskii <eliz@gnu.org>
1522 * w32console.c (Fset_screen_color): Doc fix.
1523 (Fget_screen_color): New function.
1524 (syms_of_ntterm): Defsubr it.
1526 * callproc.c (call_process_cleanup) [MSDOS]: Don't close and
1527 unlink the temporary file if Fcall_process didn't create it in the
1529 (Fcall_process) [MSDOS]: Don't create tempfile if stdout of the
1530 child process will be redirected to a file specified with `:file'.
1531 Don't try to re-open tempfile in that case, and set fd[0] to -1 as
1532 cue to call_process_cleanup not to close that handle.
1534 2011-05-07 Ben Key <bkey76@gmail.com>
1536 * makefile.w32-in: The bootstrap-temacs rule now makes use of
1537 one of two shell specific rules, either bootstrap-temacs-CMD or
1538 bootstrap-temacs-SH. The bootstrap-temacs-SH rule is identical
1539 to the previous implementation of the bootstrap-temacs rule.
1540 The bootstrap-temacs-CMD rule is similar to the previous
1541 implementation of the bootstrap-temacs rule except that it
1542 makes use of the ESC_CFLAGS variable instead of the CFLAGS
1545 These changes, along with some changes to nt/configure.bat,
1546 nt/gmake.defs, and nt/nmake.defs, are required to extend my
1547 earlier fix to add support for --cflags and --ldflags options
1548 that include quotes so that it works whether make uses cmd or
1551 2011-05-06 Michael Albinus <michael.albinus@gmx.de>
1553 * dbusbind.c (QCdbus_type_unix_fd): Declare static.
1554 (xd_remove_watch): Don't check QCdbus_type_unix_fd for SYMBOLP, it
1556 (Fdbus_init_bus, xd_read_queued_messages): Bus can be a symbol or
1557 a string. Handle both cases.
1558 (Fdbus_call_method_asynchronously, Fdbus_register_signal)
1559 (Fdbus_register_method): Use Qinvalid_function.
1561 2011-05-06 Juanma Barranquero <lekktu@gmail.com>
1563 * makefile.w32-in: Update dependencies.
1564 (LISP_H): Add inttypes.h and stdin.h.
1565 (PROCESS_H): Add unistd.h.
1567 2011-05-06 Eli Zaretskii <eliz@gnu.org>
1569 * lread.c: Include limits.h (fixes the MS-Windows build broken by
1570 2011-05-06T07:13:19Z!eggert@cs.ucla.edu).
1572 2011-05-06 Paul Eggert <eggert@cs.ucla.edu>
1574 * image.c (Finit_image_library) [!HAVE_NTGUI]: Omit unused local.
1576 * term.c (vfatal): Remove stray call to va_end.
1577 It's not needed and the C Standard doesn't allow it here anyway.
1579 Use C99's va_copy to avoid undefined behavior on x86-64 GNU/Linux.
1580 * eval.c (verror): doprnt a copy of ap, not the original. (Bug#8545)
1582 * eval.c (verror): OK to create a string of up to MOST_POSITIVE_FIXNUM
1585 * term.c: Don't include <stdarg.h>, as <lisp.h> does that.
1587 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
1589 * process.c (Fformat_network_address): Fix typo: args2 -> *args2.
1591 * xmenu.c (set_frame_menubar): Fix typo: int * -> int (3 times).
1593 * coding.c (detect_coding_charset): Fix typo: * 2 -> *4 (Bug#8601).
1595 * charset.h (struct charset.code_space): Now has 15 elements, not 16.
1596 * charset.c (Fdefine_charset_internal): Don't initialize
1597 charset.code_space[15]. The value was garbage, on hosts with
1598 32-bit int (Bug#8600).
1600 * lread.c (read_integer): Be more consistent with string-to-number.
1601 Use string_to_number to do the actual conversion; this avoids
1602 rounding errors and fixes some other screwups. Without this fix,
1603 for example, #x1fffffffffffffff was misread as -2305843009213693952.
1604 (digit_to_number): Move earlier, for benefit of read_integer.
1605 Return -1 if the digit is out of range for the base, -2 if it is
1606 not a digit in any supported base. (Bug#8602)
1608 * doprnt.c (doprnt): Support arbitrary pI values, such as "I64".
1610 * dispnew.c (scrolling_window): Return 1 if we scrolled,
1611 to match comment at start of function. This also removes a
1612 GCC warning about overflow in a 32+64-bit port.
1614 * lisp.h (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Simplify.
1616 * dbusbind.c: Do not use XPNTR on a value that may be an integer.
1617 Reported by Stefan Monnier in
1618 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00919.html>.
1619 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
1620 Use SYMBOLP-guarded XSYMBOL, not XPNTR.
1622 * lisp.h (EMACS_INTPTR): Remove. All uses changed to intptr_t.
1623 (EMACS_UINTPTR): Likewise, with uintptr_t.
1625 * lisp.h: Prefer 64-bit EMACS_INT if available.
1626 (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Define to 64-bit
1627 on 32-bit hosts that have 64-bit int, so that they can access
1629 However, temporarily disable this change unless the temporary
1630 symbol WIDE_EMACS_INT is defined.
1632 * lread.c, process.c: Do not include <inttypes.h>; lisp.h does it now.
1634 Prefer intptr_t/uintptr_t for integers the same widths as pointers.
1635 This removes an assumption that EMACS_INT and long are the same
1636 width as pointers. The assumption is true for Emacs porting targets
1637 now, but we want to make other targets possible.
1638 * lisp.h: Include <inttypes.h>, for INTPTR_MAX, UINTPTR_MAX.
1639 (EMACS_INTPTR, EMACS_UINTPTR): New macros.
1640 In the rest of the code, change types of integers that hold casted
1641 pointers to EMACS_INTPTR and EMACS_UINTPTR, systematically
1642 replacing EMACS_INT, long, EMACS_UINT, and unsigned long.
1643 (XTYPE): Don't cast arg to EMACS_UINT; normally is not needed.
1644 (XSET): Cast type of XTYPE arg to EMACS_INTPTR; it is needed here.
1645 No need to cast type when ORing.
1646 (XPNTR): Return a value of type EMACS_INTPTR or EMACS_UINTPTR.
1647 * alloc.c (lisp_align_malloc): Remove a no-longer-needed cast.
1648 * doc.c (store_function_docstring): Use EMACS_INTPTR, so as not to
1649 assume EMACS_INT is the same width as char *.
1650 * gtkutil.c (xg_gtk_scroll_destroy, xg_tool_bar_button_cb):
1651 (xg_tool_bar_callback, xg_tool_bar_help_callback, xg_make_tool_item):
1652 Remove no-longer-needed casts.
1653 (xg_create_scroll_bar, xg_tool_bar_button_cb, xg_tool_bar_callback):
1654 (xg_tool_bar_help_callback, xg_make_tool_item):
1655 Use EMACS_INTPTR to hold an integer
1656 that will be cast to void *; this can avoid a GCC warning
1657 if EMACS_INT is not the same width as void *.
1658 * menu.c (find_and_call_menu_selection): Remove no-longer-needed cast.
1659 * xdisp.c (display_echo_area_1, resize_mini_window_1):
1660 (current_message_1, set_message_1):
1661 Use a local to convert to proper width without a cast.
1662 * xmenu.c (dialog_selection_callback): Likewise.
1664 * sysdep.c (get_random): Don't assume EMACS_INT is no wider than long.
1665 Also, don't assume VALBITS / RAND_BITS is less than 5,
1666 and don't rely on undefined behavior when shifting a 1 left into
1668 * lisp.h (get_random): Change signature to match.
1670 * lread.c (hash_string): Use size_t, not int, for hash computation.
1671 Normally we prefer signed values; but hashing is special, because
1672 it's better to use unsigned division on hash table sizes so that
1673 the remainder is nonnegative. Also, size_t is the natural width
1674 for hashing into memory. The previous code used 'int', which doesn't
1675 retain enough info to hash well into very large tables.
1676 (oblookup, oblookup_last_bucket_number, Funintern): Likewise.
1678 * dbusbind.c: Don't possibly lose pointer info when converting.
1679 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
1680 Use XPNTR rather than XHASH, so that the high-order bits of
1681 the pointer aren't lost when converting through void *.
1683 * eval.c (Fautoload): Don't double-shift a pointer.
1685 * fns.c (Frandom): Let EMACS_UINT be wider than unsigned long.
1687 2011-05-06 Juanma Barranquero <lekktu@gmail.com>
1689 * gnutls.c (DEF_GNUTLS_FN):
1690 * image.c (DEF_IMGLIB_FN): Make function pointers static.
1692 2011-05-05 Andreas Schwab <schwab@linux-m68k.org>
1694 * lread.c (lisp_file_lexically_bound_p): Stop scanning at end
1697 2011-05-05 Eli Zaretskii <eliz@gnu.org>
1699 * w32heap.c (allocate_heap) [USE_LISP_UNION_TYPE || USE_LSB_TAG]:
1700 New version that can reserve upto 2GB of heap space.
1702 2011-05-05 Chong Yidong <cyd@stupidchicken.com>
1704 * nsfns.m (Fns_read_file_name): Doc fix (Bug#8534).
1706 2011-05-05 Teodor Zlatanov <tzz@lifelogs.com>
1708 * gnutls.c (fn_gnutls_certificate_set_x509_key_file): Add alias to
1709 `gnutls_certificate_set_x509_key_file'.
1711 2011-05-05 Juanma Barranquero <lekktu@gmail.com>
1713 * makefile.w32-in ($(BLD)/image.$(O), $(BLD)/process.$(O)):
1714 Update dependencies.
1716 2011-05-04 Juanma Barranquero <lekktu@gmail.com>
1718 * gnutls.h (emacs_gnutls_write, emacs_gnutls_read):
1719 * gnutls.c (emacs_gnutls_write, emacs_gnutls_read):
1720 Remove unused parameter `fildes'.
1721 * process.c (read_process_output, send_process): Don't pass it.
1723 2011-05-04 Juanma Barranquero <lekktu@gmail.com>
1725 Fix previous change: the library cache is defined in w32.c.
1726 * image.c (CACHE_IMAGE_TYPE) [!HAVE_NTGUI]: Define to noop.
1727 (Finit_image_library): Wrap Vlibrary_cache on "#ifdef HAVE_NTGUI".
1729 2011-05-04 Juanma Barranquero <lekktu@gmail.com>
1731 Implement dynamic loading of GnuTLS on Windows.
1733 * gnutls.h (GNUTLS_EMACS_ERROR_NOT_LOADED): New macro.
1734 (emacs_gnutls_write, emacs_gnutls_read): Mark as extern.
1735 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
1738 * gnutls.c (Qgnutls_dll): Define.
1739 (DEF_GNUTLS_FN, LOAD_GNUTLS_FN): New macros.
1740 (gnutls_*): Declare function pointers.
1741 (init_gnutls_functions): New function to initialize function pointers.
1742 (emacs_gnutls_handshake, Fgnutls_error_string, Fgnutls_deinit)
1743 (emacs_gnutls_global_init, Fgnutls_bye): Use function pointers.
1744 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
1745 Wrappers for gnutls_record_check_pending and gnutls_transport_set_errno.
1746 (emacs_gnutls_write, emacs_gnutls_read)
1747 (emacs_gnutls_handle_error, Fgnutls_error_fatalp)
1748 (Fgnutls_available_p): New function.
1749 (Fgnutls_boot): Call Fgnutls_available_p. Use function pointers.
1750 (syms_of_gnutls) <Qgnutls_dll>: Initialize and staticpro it.
1751 (syms_of_gnutls) <Sgnutls_available_p>: defsubr it.
1753 * image.c: Include w32.h.
1754 (Vimage_type_cache): Delete.
1755 (syms_of_image) <Vimage_type_cache>: Don't initialize and staticpro it.
1756 (CACHE_IMAGE_TYPE, Finit_image_library): Use Vlibrary_cache instead.
1757 (w32_delayed_load): Move to w32.c.
1759 * w32.h (VlibraryCache, QCloaded_from, w32_delayed_load): Declare.
1761 * w32.c (QCloaded_from, Vlibrary_cache): Define.
1762 (w32_delayed_load): Move from image.c. When loading a library, record
1763 its filename in the :loaded-from property of the library id.
1764 (globals_of_w32) <QCloaded_from, Vlibrary_cache>:
1765 Initialize and staticpro them.
1766 (emacs_gnutls_pull, emacs_gnutls_push): Call emacs_gnutls_* functions.
1768 * process.c: Include lisp.h before w32.h, not after.
1769 (wait_reading_process_output): Call emacs_gnutls_record_check_pending
1770 instead of gnutls_record_check_pending.
1772 * callproc.c, emacs.c: Include lisp.h before w32.h, not after.
1774 2011-05-04 Teodor Zlatanov <tzz@lifelogs.com>
1776 * gnutls.c (Fgnutls_boot): Support :keylist and :crlfiles options
1777 instead of :keyfiles. Give GnuTLS the keylist and the CRL lists
1780 2011-05-03 Jan Djärv <jan.h.d@swipnet.se>
1782 * xterm.c (x_set_frame_alpha): Do not set property on anything
1783 else than FRAME_X_OUTER_WINDOW (Bug#8608).
1785 2011-05-02 Juanma Barranquero <lekktu@gmail.com>
1787 * sysdep.c (get_tty_size) [WINDOWSNT]: Implement. (Bug#8596)
1789 2011-05-02 Juanma Barranquero <lekktu@gmail.com>
1791 * gnutls.c (Qgnutls_log_level, Qgnutls_code, Qgnutls_anon)
1792 (Qgnutls_x509pki, Qgnutls_e_interrupted, Qgnutls_e_again)
1793 (Qgnutls_e_invalid_session, Qgnutls_e_not_ready_for_handshake)
1794 (gnutls_global_initialized, Qgnutls_bootprop_priority)
1795 (Qgnutls_bootprop_trustfiles, Qgnutls_bootprop_keyfiles)
1796 (Qgnutls_bootprop_callbacks, Qgnutls_bootprop_loglevel)
1797 (Qgnutls_bootprop_hostname, Qgnutls_bootprop_verify_flags)
1798 (Qgnutls_bootprop_verify_error, Qgnutls_bootprop_verify_hostname_error)
1799 (Qgnutls_bootprop_callbacks_verify): Make static.
1801 2011-05-01 Andreas Schwab <schwab@linux-m68k.org>
1803 * callproc.c: Indentation fixup.
1805 * sysdep.c (wait_for_termination_1): Make static.
1806 (wait_for_termination, interruptible_wait_for_termination):
1807 Move after wait_for_termination_1.
1809 2011-05-01 Lars Magne Ingebrigtsen <larsi@gnus.org>
1811 * sysdep.c (interruptible_wait_for_termination): New function
1812 which is like wait_for_termination, but allows keyboard
1815 * callproc.c (Fcall_process): Add (:file "file") as an option for
1817 (Fcall_process_region): Ditto.
1819 2011-04-30 Eli Zaretskii <eliz@gnu.org>
1821 * dosfns.c (Fint86, Fdos_memget, Fdos_memput): Use `ASIZE (FOO)'
1822 rather than `XVECTOR (FOO)->size'.
1824 * process.c: Remove HAVE_INTTYPES_H condition from inclusion of
1825 inttypes.h, as a gnulib replacement is used if it not available in
1828 2011-04-21 Eli Zaretskii <eliz@gnu.org>
1830 Lift the MOST_POSITIVE_FIXNUM/4 limitation on visited files.
1831 * fileio.c (Finsert_file_contents): Don't limit file size to 1/4
1832 of MOST_POSITIVE_FIXNUM. (Bug#8528)
1834 * coding.c (coding_alloc_by_realloc): Error out if destination
1835 will grow beyond MOST_POSITIVE_FIXNUM.
1836 (decode_coding_emacs_mule): Abort if there isn't enough place in
1837 charbuf for the composition carryover bytes. Reserve an extra
1838 space for up to 2 characters produced in a loop.
1839 (decode_coding_iso_2022): Abort if there isn't enough place in
1840 charbuf for the composition carryover bytes.
1842 2011-04-21 Eli Zaretskii <eliz@gnu.org>
1844 * doprnt.c (doprnt) [!HAVE_LONG_LONG_INT]: Error out instead of
1845 aborting when %lld or %lll format is passed.
1846 [!HAVE_UNSIGNED_LONG_LONG_INT]: Error out instead of aborting when
1847 %llo or %llx format is passed. (Bug#8545)
1849 * window.c (window_scroll_line_based): Use a marker instead of
1850 simple variables to record original value of point. (Bug#7952)
1852 * doprnt.c (doprnt): Fix the case where a multibyte sequence
1853 produced by %s or %c overflows available buffer space. (Bug#8545)
1855 2011-04-28 Paul Eggert <eggert@cs.ucla.edu>
1857 * doprnt.c (doprnt): Omit useless test; int overflow check (Bug#8545).
1858 (SIZE_MAX): Move defn after all includes, as they might #define it.
1860 2011-04-28 Juanma Barranquero <lekktu@gmail.com>
1862 * w32.c (init_environment): Warn about defaulting HOME to C:\.
1864 2011-04-28 Juanma Barranquero <lekktu@gmail.com>
1866 * keyboard.c (Qdelayed_warnings_hook): Define.
1867 (command_loop_1): Run `delayed-warnings-hook'
1868 if Vdelayed_warnings_list is non-nil.
1869 (syms_of_keyboard) <delayed-warnings-hook>: DEFSYM it.
1870 (syms_of_keyboard) <delayed-warnings-list>: DEFVAR_LISP it.
1872 2011-04-28 Eli Zaretskii <eliz@gnu.org>
1874 * doprnt.c (doprnt): Don't return value smaller than the buffer
1875 size if the message was truncated. (Bug#8545).
1877 2011-04-28 Juanma Barranquero <lekktu@gmail.com>
1879 * w32fns.c (Fx_change_window_property, Fx_delete_window_property)
1880 (Fx_window_property): #if-0 the whole functions, not just the bodies.
1882 2011-04-27 Paul Eggert <eggert@cs.ucla.edu>
1884 * doprnt.c (doprnt): Support "ll" length modifier, for long long.
1886 2011-04-27 Juanma Barranquero <lekktu@gmail.com>
1888 * makefile.w32-in: Update dependencies.
1890 2011-04-27 Eli Zaretskii <eliz@gnu.org>
1892 Improve `doprnt' and its usage. (Bug#8545)
1893 * doprnt.c (doprnt): Make sure `format' is never accessed beyond
1894 `format_end'. Remove support for %l as a conversion specifier.
1895 Don't use xrealloc. Improve diagnostics when the %l size modifier
1896 is used. Update the commentary.
1898 * eval.c (verror): Simplify calculation of size_t.
1900 * coding.c (Ffind_operation_coding_system): Fix diagnostic error
1903 2011-04-27 Yoshiaki Kasahara <kasahara@nc.kyushu-u.ac.jp> (tiny change)
1905 * buffer.c (init_buffer) [USE_MMAP_FOR_BUFFERS]: Adjust to aliasing
1908 2011-04-27 Paul Eggert <eggert@cs.ucla.edu>
1910 * nsmenu.m: Replace all uses of XVECTOR with ASIZE and AREF.
1911 This makes this file independent of the recent pseudovector change.
1913 2011-04-26 Paul Eggert <eggert@cs.ucla.edu>
1915 * keyboard.c (handle_user_signal): Fix pointer signedness problem.
1917 * gnutls.c (emacs_gnutls_handle_error): Remove unused local.
1918 (Fgnutls_boot): gnutls_certificate_verify_peers2 wants unsigned *.
1919 Remove unused local.
1920 (emacs_gnutls_write): Don't use uninitialized rtnval if nbyte <= 0.
1922 * lisp.h: Fix a problem with aliasing and vector headers. (Bug#8546)
1923 GCC 4.6.0 optimizes based on type-based alias analysis.
1924 For example, if b is of type struct buffer * and v of type struct
1925 Lisp_Vector *, then gcc -O2 was incorrectly assuming that &b->size
1926 != &v->size, and therefore "v->size = 1; b->size = 2; return
1927 v->size;" must therefore return 1. This assumption is incorrect
1928 for Emacs, since it type-puns struct Lisp_Vector * with many other
1929 types. To fix this problem, this patch adds a new type struct
1930 vectorlike_header that documents the constraints on layout of vectors
1931 and pseudovectors, and helps optimizing compilers not get fooled
1932 by Emacs's type punning. It also adds the macros XSETTYPED_PVECTYPE
1933 XSETTYPED_PSEUDOVECTOR, TYPED_PSEUDOVECTORP, for similar reasons.
1934 * lisp.h (XSETTYPED_PVECTYPE): New macro, specifying the name of
1936 (XSETPVECTYPE): Rewrite in terms of new macro.
1937 (XSETPVECTYPESIZE): New macro, specifying both type and size.
1938 This is a bit clearer, and further avoids the possibility of
1939 undesirable aliasing.
1940 (XSETTYPED_PSEUDOVECTOR): New macro, specifying the size.
1941 (XSETPSEUDOVECTOR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR.
1942 (XSETSUBR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR and XSIZE,
1943 since Lisp_Subr is a special case (no "next" field).
1944 (ASIZE): Now uses header.size rather than size.
1945 All previous uses of XVECTOR (foo)->size replaced to use this macro,
1946 to avoid the hassle of writing XVECTOR (foo)->header.size.
1947 (struct vectorlike_header): New type.
1948 (TYPED_PSEUDOVECTORP): New macro, also specifying the C type of the
1949 object, to help avoid aliasing.
1950 (PSEUDOVECTORP): Rewrite in terms of TYPED_PSEUDOVECTORP.
1951 (SUBRP): Likewise, since Lisp_Subr is a special case.
1952 * lisp.h (struct Lisp_Vector, struct Lisp_Char_Table):
1953 (struct Lisp_Sub_Char_Table, struct Lisp_Bool_Vector):
1954 (struct Lisp_Hash_Table): Combine first two members into a single
1955 struct vectorlike_header member. All uses of "size" and "next" members
1956 changed to be "header.size" and "header.next".
1957 * buffer.h (struct buffer): Likewise.
1958 * font.h (struct font_spec, struct font_entity, struct font): Likewise.
1959 * frame.h (struct frame): Likewise.
1960 * process.h (struct Lisp_Process): Likewise.
1961 * termhooks.h (struct terminal): Likewise.
1962 * window.c (struct save_window_data, struct saved_window): Likewise.
1963 * window.h (struct window): Likewise.
1964 * alloc.c (allocate_buffer, Fmake_bool_vector, allocate_pseudovector):
1965 Use XSETPVECTYPESIZE, not XSETPVECTYPE, to avoid aliasing problems.
1966 * buffer.c (init_buffer_once): Likewise.
1967 * lread.c (defsubr): Use XSETTYPED_PVECTYPE, since Lisp_Subr is a
1969 * process.c (Fformat_network_address): Use local var for size,
1972 * bytecode.c (exec_byte_code): Don't use XVECTOR before CHECK_VECTOR.
1974 Make the Lisp reader and string-to-float more consistent (Bug#8525)
1975 * data.c (atof): Remove decl; no longer used or needed.
1976 (digit_to_number): Move to lread.c.
1977 (Fstring_to_number): Use new string_to_number function, to be
1978 consistent with how the Lisp reader treats infinities and NaNs.
1979 Do not assume that floating-point numbers represent EMACS_INT
1980 without losing information; this is not true on most 64-bit hosts.
1981 Avoid double-rounding errors, by insisting on integers when
1982 parsing non-base-10 numbers, as the documentation specifies.
1983 * lisp.h (string_to_number): New decl, replacing ...
1984 (isfloat_string): Remove.
1985 * lread.c: Include <inttypes.h>, for uintmax_t and strtoumax.
1986 (read1): Do not accept +. and -. as integers; this
1987 appears to have been a coding error. Similarly, do not accept
1988 strings like +-1e0 as floating point numbers. Do not report
1989 overflow for integer overflows unless the base is not 10 which
1990 means we have no simple and reliable way to continue.
1991 Break out the floating-point parsing into a new
1992 function string_to_number, so that Fstring_to_number parses
1993 floating point numbers consistently with the Lisp reader.
1994 (digit_to_number): Move here from data.c. Make it static inline.
1995 (E_CHAR, EXP_INT): Remove, replacing with ...
1996 (E_EXP): New macro, to solve the "1.0e+" problem mentioned below.
1997 (string_to_number): New function, replacing isfloat_string.
1998 This function checks for valid syntax and produces the resulting
1999 Lisp float number too. Rework it so that string-to-number
2000 no longer mishandles examples like "1.0e+". Use strtoumax,
2001 so that overflow for non-base-10 numbers is reported only when
2002 there's no portable and simple way to convert to floating point.
2004 * textprop.c (set_text_properties_1): Rewrite for clarity,
2005 and to avoid GCC warning about integer overflow.
2007 * intervals.h (struct interval): Use EMACS_INT for members
2008 where EMACS_UINT might cause problems. See
2009 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html>.
2010 (CHECK_TOTAL_LENGTH): Remove cast to EMACS_INT; no longer needed.
2011 * intervals.c (interval_deletion_adjustment): Now returns EMACS_INT.
2013 (offset_intervals): Tell GCC not to worry about length overflow
2014 when negating a negative length.
2016 * alloc.c (overrun_check_malloc, overrun_check_realloc): Now static.
2017 (overrun_check_free): Likewise.
2019 * alloc.c (SDATA_SIZE) [!GC_CHECK_STRING_BYTES]: Avoid runtime check
2020 in the common case where SDATA_DATA_OFFSET is a multiple of Emacs
2023 * gnutls.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
2024 (gnutls_make_error): Rename local to avoid shadowing.
2025 (gnutls_emacs_global_deinit): ifdef out; not used.
2026 (Fgnutls_boot): Use const for pointer to readonly storage.
2027 Comment out unused local. Fix pointer signedness problems.
2029 * lread.c (openp): Don't stuff size_t into an 'int'.
2030 Use <= on length, not < on length + 1, to avoid GCC 4.6.0 warning
2031 about possible signed overflow.
2033 * gtkutil.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
2034 (GDK_KEY_g): Don't define if already defined.
2035 (xg_prepare_tooltip): Avoid pointer signedness problem.
2036 (xg_set_toolkit_scroll_bar_thumb): Redo to avoid two casts.
2038 * process.c (Fnetwork_interface_info): Avoid left-shift undefined
2039 behavior with 1 << 31. GCC 4.6.0 warns about this on 32-bit hosts.
2041 * xfns.c (Fx_window_property): Simplify a bit,
2042 to make a bit faster and to avoid GCC 4.6.0 warning.
2043 * xselect.c (x_get_window_property, x_handle_dnd_message): Likewise.
2045 * fns.c (internal_equal): Don't assume size_t fits in int.
2047 * alloc.c (compact_small_strings): Tighten assertion a little.
2049 Replace pEd with more-general pI, and fix some printf arg casts.
2050 * lisp.h (pI): New macro, generalizing old pEd macro to other
2051 conversion specifiers. For example, use "...%"pI"d..." rather
2052 than "...%"pEd"...".
2053 (pEd): Remove. All uses replaced with similar uses of pI.
2054 * src/m/amdx86-64.h, src/m/ia64.h, src/m/ibms390x.h: Likewise.
2055 * alloc.c (check_pure_size): Don't overflow by converting size to int.
2056 * bidi.c (bidi_dump_cached_states): Use pI to avoid cast.
2057 * data.c (Fnumber_to_string): Use pI instead of if-then-else-abort.
2058 * dbusbind.c (xd_append_arg): Use pI to avoid cast.
2059 (Fdbus_method_return_internal, Fdbus_method_error_internal): Likewise.
2060 * font.c (font_unparse_xlfd): Avoid potential buffer overrun on
2062 (font_unparse_xlfd, font_unparse_fcname): Use pI to avoid casts.
2063 * keyboard.c (record_char, modify_event_symbol): Use pI to avoid casts.
2064 * print.c (safe_debug_print, print_object): Likewise.
2065 (print_object): Don't overflow by converting EMACS_INT or EMACS_UINT
2067 Use pI instead of if-then-else-abort. Use %p to avoid casts,
2068 avoiding the 0 flag, which is not portable.
2069 * process.c (Fmake_network_process): Use pI to avoid cast.
2070 * region-cache.c (pp_cache): Likewise.
2071 * xdisp.c (decode_mode_spec): Likewise.
2072 * xrdb.c (x_load_resources) [USE_MOTIF]: Use pI to avoid undefined
2073 behavior on 64-bit hosts with printf arg.
2074 * xselect.c (x_queue_event): Use %p to avoid casts, avoiding 0 flag.
2075 (x_stop_queuing_selection_requests): Likewise.
2076 (x_get_window_property): Don't truncate byte count to an 'int'
2079 * frame.c (frame_name_fnn_p): Get rid of strtol, which isn't right
2080 here, since it parses constructs like leading '-' and spaces,
2081 which are not wanted; and it overflows with large numbers.
2082 Instead, simply match F[0-9]+, which is what is wanted anyway.
2084 * alloc.c: Remove unportable assumptions about struct layout.
2085 (SDATA_SELECTOR, SDATA_DATA_OFFSET): New macros.
2086 (SDATA_OF_STRING, SDATA_SIZE, allocate_string_data):
2087 (allocate_vectorlike, make_pure_vector): Use the new macros,
2088 plus offsetof, to remove unportable assumptions about struct layout.
2089 These assumptions hold on all porting targets that I know of, but
2090 they are not guaranteed, they're easy to remove, and removing them
2091 makes further changes easier.
2093 * alloc.c (BLOCK BYTES): Fix typo by changing "ablock" to "ablocks".
2094 This doesn't fix a bug but makes the code clearer.
2095 (string_overrun_cookie): Now const. Use initializers that
2096 don't formally overflow signed char, to avoid warnings.
2097 (allocate_string_data) [GC_CHECK_STRING_OVERRUN]: Fix typo that
2098 can cause Emacs to crash when string overrun checking is enabled.
2099 (allocate_buffer): Don't assume sizeof (struct buffer) is a
2100 multiple of sizeof (EMACS_INT); it need not be, if
2101 alignof(EMACS_INT) < sizeof (EMACS_INT).
2102 (check_sblock, check_string_bytes, check_string_free_list): Protoize.
2104 2011-04-26 Juanma Barranquero <lekktu@gmail.com>
2106 * keyboard.c (QCrtl): Rename from Qrtl. All uses changed.
2108 2011-04-26 Teodor Zlatanov <tzz@lifelogs.com>
2110 * gnutls.c (emacs_gnutls_handshake): Return an error if we're not
2111 supposed to be handshaking. (Bug#8556)
2112 Reported by Paul Eggert <eggert@cs.ucla.edu>.
2114 2011-04-26 Daniel Colascione <dan.colascione@gmail.com>
2116 * lisp.h (Qdebug): List symbol.
2117 * eval.c (Qdebug): Restore global linkage.
2118 * keyboard.c (debug-on-event): New variable.
2119 (handle_user_signal): Break into debugger when debug-on-event
2120 matches the current signal symbol.
2122 2011-04-25 Dan Nicolaescu <dann@ics.uci.edu>
2124 * alloc.c (check_sblock, check_string_bytes)
2125 (check_string_free_list): Convert to standard C.
2127 2011-04-25 Teodor Zlatanov <tzz@lifelogs.com>
2129 * w32.c (emacs_gnutls_push): Fix typo.
2131 2011-04-25 Eli Zaretskii <eliz@gnu.org>
2133 * gnutls.c (emacs_gnutls_handshake): Avoid compiler warnings about
2134 "cast to pointer from integer of different size".
2136 Improve doprnt and its use in verror. (Bug#8545)
2137 * doprnt.c (doprnt): Document the set of format control sequences
2138 supported by the function. Use SAFE_ALLOCA instead of always
2141 * eval.c (verror): Don't limit the buffer size at size_max-1, that
2142 is one byte too soon. Don't use xrealloc; instead xfree and
2145 2011-04-24 Teodor Zlatanov <tzz@lifelogs.com>
2147 * gnutls.h: Add GNUTLS_STAGE_CALLBACKS enum to denote we're in the
2150 * gnutls.c: Renamed global_initialized to
2151 gnutls_global_initialized. Added internals for the
2152 :verify-hostname-error, :verify-error, and :verify-flags
2153 parameters of `gnutls-boot' and documented those parameters in the
2154 docstring. Start callback support.
2155 (emacs_gnutls_handshake): Add Woe32 support. Retry handshake
2156 unless a fatal error occured. Call gnutls_alert_send_appropriate
2157 on error. Return error code.
2158 (emacs_gnutls_write): Call emacs_gnutls_handle_error.
2159 (emacs_gnutls_read): Likewise.
2160 (Fgnutls_boot): Return handshake error code.
2161 (emacs_gnutls_handle_error): New function.
2162 (wsaerror_to_errno): Likewise.
2164 * w32.h (emacs_gnutls_pull): Add prototype.
2165 (emacs_gnutls_push): Likewise.
2167 * w32.c (emacs_gnutls_pull): New function for GnuTLS on Woe32.
2168 (emacs_gnutls_push): Likewise.
2170 2011-04-24 Claudio Bley <claudio.bley@gmail.com> (tiny change)
2172 * process.c (wait_reading_process_output): Check if GnuTLS
2173 buffered some data internally if no FDs are set for TLS
2176 * makefile.w32-in (OBJ2): Add gnutls.$(O).
2177 (LIBS): Link to USER_LIBS.
2178 ($(BLD)/gnutls.$(0)): New target.
2180 2011-04-24 Eli Zaretskii <eliz@gnu.org>
2182 * xdisp.c (handle_single_display_spec): Rename the
2183 display_replaced_before_p argument into display_replaced_p, to
2184 make it consistent with the commentary. Fix typos in the
2187 * textprop.c (syms_of_textprop): Remove dead code.
2188 (copy_text_properties): Delete obsolete commentary about an
2189 interface that was deleted long ago. Fix typos in the description
2192 * msdos.c (XMenuActivate, XMenuAddSelection): Adjust argument list
2193 to changes in oldXMenu/XMenu.h from 2011-04-16.
2194 <menu_help_message, prev_menu_help_message>: Constify.
2195 (IT_menu_make_room): menu->help_text is now `const char **';
2198 * msdos.h (XMenuActivate, XMenuAddSelection): Adjust prototypes
2199 to changes in oldXMenu/XMenu.h from 2011-04-16.
2200 (struct XMenu): Declare `help_text' `const char **'.
2202 * xfaces.c <Qunspecified>: Make extern again.
2204 * syntax.c: Include sys/types.h before including regex.h, as
2207 * doc.c (get_doc_string): Improve the format passed to `error'.
2209 * doprnt.c (doprnt): Improve commentary.
2211 * term.c (init_tty) [MSDOS]: Fix 1st argument to maybe_fatal.
2213 * Makefile.in (TAGS): Depend on $(M_FILE) and $(S_FILE), and scan
2216 * makefile.w32-in (globals.h): Add a dummy recipe, to make any
2217 changes in globals.h immediately force recompilation.
2218 (TAGS): Depend on $(CURDIR)/m/intel386.h and
2219 $(CURDIR)/s/ms-w32.h.
2220 (TAGS-gmake): Scan $(CURDIR)/m/intel386.h and $(CURDIR)/s/ms-w32.h.
2222 * character.c (Fchar_direction): Function deleted.
2223 (syms_of_character): Don't defsubr it.
2224 <char-direction-table>: Deleted.
2226 2011-04-23 Eli Zaretskii <eliz@gnu.org>
2228 Fix doprnt so it could be used again safely in `verror'. (Bug#8435)
2229 * doprnt.c: Include limits.h.
2230 (SIZE_MAX): New macro.
2231 (doprnt): Return a size_t value. 2nd arg is now size_t.
2232 Many local variables are now size_t instead of int or unsigned.
2233 Improve overflow protection. Support `l' modifier for integer
2234 conversions. Support %l conversion. Don't assume an EMACS_INT
2235 argument for integer conversions and for %c.
2237 * lisp.h (doprnt): Restore prototype.
2239 * makefile.w32-in ($(BLD)/callint.$(O)): Depend on
2242 * Makefile.in (base_obj): Add back doprnt.o.
2244 * deps.mk (doprnt.o): Add back prerequisites.
2245 (callint.o): Depend on character.h.
2247 * eval.c (internal_lisp_condition_case): Include the handler
2248 representation in the error message.
2249 (verror): Call doprnt instead of vsnprintf. Fix an off-by-one bug
2250 when breaking from the loop.
2252 * xdisp.c (vmessage): Call doprnt instead of vsnprintf.
2254 * callint.c (Fcall_interactively): When displaying error message
2255 about invalid control letter, pass the character's codepoint, not
2256 a pointer to its multibyte form. Improve display of the character
2257 in octal and display also its hex code.
2259 * character.c (char_string): Use %x to display the (unsigned)
2260 codepoint of an invalid character, to avoid displaying a bogus
2263 * font.c (check_otf_features): Pass SDATA of SYMBOL_NAME to
2264 `error', not SYMBOL_NAME itself.
2266 * coding.c (Fencode_sjis_char, Fencode_big5_char): Use %c for
2267 character arguments to `error'.
2269 * charset.c (check_iso_charset_parameter): Fix incorrect argument
2270 to `error' in error message about FINAL_CHAR argument. Make sure
2271 FINAL_CHAR is a character, and use %c when it is passed as
2272 argument to `error'.
2274 2011-04-23 Eli Zaretskii <eliz@gnu.org>
2276 * s/ms-w32.h (localtime): Redirect to sys_localtime.
2278 * w32.c: Include <time.h>.
2279 (sys_localtime): New function.
2281 2011-04-23 Chong Yidong <cyd@stupidchicken.com>
2283 * xdisp.c (init_xdisp): Initialize echo_area_window (Bug#6451).
2285 * buffer.c (syms_of_buffer): Doc fix (Bug#6902).
2287 2011-04-23 Samuel Thibault <sthibault@debian.org> (tiny change)
2289 * sysdep.c (wait_for_termination): On GNU Hurd, kill returns -1 on
2292 2011-04-19 Eli Zaretskii <eliz@gnu.org>
2294 * syntax.h (SETUP_SYNTAX_TABLE_FOR_OBJECT): Fix setting of
2295 gl_state.e_property when gl_state.object is Qt.
2297 * insdel.c (make_gap_larger): Remove limitation of buffer size
2300 2011-04-18 Chong Yidong <cyd@stupidchicken.com>
2302 * xdisp.c (lookup_glyphless_char_display)
2303 (produce_glyphless_glyph): Handle cons cell entry in
2304 glyphless-char-display.
2305 (Vglyphless_char_display): Document it.
2307 * term.c (produce_glyphless_glyph): Handle cons cell entry in
2308 glyphless-char-display.
2310 2011-04-17 Chong Yidong <cyd@stupidchicken.com>
2312 * xdisp.c (get_next_display_element): Remove unnecessary ifdefs.
2314 * termhooks.h (FRAME_WINDOW_P): Remove duplicated definitions.
2316 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): Add missing
2317 definition for no-X builds.
2319 2011-04-16 Paul Eggert <eggert@cs.ucla.edu>
2321 Static checks with GCC 4.6.0 and non-default toolkits.
2323 * s/sol2-6.h, s/unixware.h (PTY_TTY_NAME_SPRINTF): Protoize decl.
2325 * process.c (keyboard_bit_set): Define only if SIGIO.
2326 (send_process_trap): Mark it with NO_RETURN if it doesn't return.
2327 (send_process): Repair possible setjmp clobbering.
2329 * s/usg5-4-common.h (SETUP_SLAVE_PTY): Don't pass extra arg to 'fatal'.
2331 * eval.c: Include <stdio.h>, for vsnprintf on non-GNU/Linux hosts.
2333 * data.c (arith_error): Mark with NO_RETURN if it doesn't return.
2335 * alloc.c (bytes_used_when_full, SPARE_MEMORY, BYTES_USED):
2336 Define only if needed.
2338 * sysdep.c (_FILE_OFFSET_BITS): Make this hack even uglier
2339 by pacifying GCC about it. Maybe it's time to retire it?
2340 * xfaces.c (USG, __TIMEVAL__): Likewise.
2342 * dispextern.h (struct redisplay_interface): Rename param
2344 * termhooks.h (struct terminal): Likewise.
2345 * xterm.c (xembed_send_message): Likewise.
2347 * insdel.c (make_gap_smaller): Define only if
2348 USE_MMAP_FOR_BUFFERS || REL_ALLOC || DOUG_LEA_MALLOC.
2350 * keyboard.c (read_char): Make a var volatile so longjmp won't clobber
2353 * emacs.c (MAX_HEAP_BSS_DIFF, my_edata): Move to where they're used,
2354 so that we aren't warned about unused symbols.
2356 * xfns.c (Fx_file_dialog): Rename local to avoid shadowing.
2358 * xdisp.c (x_produce_glyphs): Mark var as initialized (Bug#8512).
2360 * xfns.c (x_real_positions): Mark locals as initialized.
2362 * xmenu.c (xmenu_show): Don't use uninitialized vars.
2364 * xterm.c: Fix problems found by static analysis with other toolkits.
2365 (toolkit_scroll_bar_interaction): Define and use only if USE_X_TOOLKIT.
2366 (x_dispatch_event): Declare static if USE_GTK, and
2367 define if USE_GTK || USE_X_TOOLKIT.
2368 (SET_SAVED_BUTTON_EVENT): Define only if USE_X_TOOLKIT || USE_GTK.
2369 * xterm.h (x_dispatch_event): Extern only if USE_X_TOOLKIT.
2370 * xterm.c, xterm.h (x_mouse_leave): Bring this function back, but only
2371 if defined HAVE_MENUS && !defined USE_X_TOOLKIT && !defined USE_GTK.
2373 * xmenu.c (menu_help_callback): Pointer type fixes.
2374 Use const pointers when pointing at readonly data. Avoid pointer
2376 (FALSE): Remove unused macro.
2377 (update_frame_menubar): Remove unused decl.
2379 * xfns.c (Fx_hide_tip): Move locals to avoid shadowing.
2381 * menu.c (push_submenu_start, push_submenu_end): Do not define unless
2382 USE_X_TOOLKIT || USE_GTK || HAVE_NS || defined HAVE_NTGUI.
2383 (single_menu_item): Rename local to avoid shadowing.
2385 * keyboard.c (make_lispy_event): Remove unused local var.
2387 * frame.c, frame.h (x_get_resource_string): Bring this back, but
2388 only if HAVE_X_WINDOWS && !USE_X_TOOLKIT.
2390 * bitmaps: Change bitmaps from unsigned char back to the X11
2391 compatible char. Avoid the old compiler warnings about
2392 out-of-range initializers by using, for example, '\xab' rather
2395 * xgselect.c (xgselect_initialize): Check vs interface
2396 even if ! (defined (USE_GTK) || defined (HAVE_GCONF)).
2398 * xmenu.c (xmenu_show): Rename parm to avoid shadowing.
2400 * xterm.c (x_create_toolkit_scroll_bar): Use const * for pointers
2401 to read-only memory.
2403 * fns.c (vector): Remove; this old hack is no longer needed.
2405 * xsmfns.c (create_client_leader_window): Rename shadowing arg.
2407 (gdk_x11_set_sm_client_id) [!USE_GTK]: Don't define.
2409 * xrdb.c (x_load_resources): Omit unused local.
2411 * xfns.c (free_frame_menubar, atof): Remove duplicate decls.
2412 (x_window): Rename locals to avoid shadowing.
2413 (USG): Use the kludged USG macro, to pacify gcc.
2415 * xterm.c (x_alloc_nearest_color_for_widget): Remove; unused.
2416 (x_term_init): Remove local to avoid shadowing.
2418 * xfns.c, xterm.c (_XEditResCheckMessages): Protoize decl.
2420 * xdisp.c, dispextern.h (set_vertical_scroll_bar): Now extern if
2421 USE_TOOLKIT_SCROLL_BARS && !USE_GTK, as xterm.c needs it then.
2423 2011-04-16 Eli Zaretskii <eliz@gnu.org>
2425 * gnutls.c (Fgnutls_boot): Don't pass Lisp_Object to `error'.
2427 Fix regex.c, syntax.c and friends for buffers > 2GB.
2428 * syntax.h (struct gl_state_s): Declare character position members
2431 * syntax.c (update_syntax_table): Declare 2nd argument EMACS_INT.
2433 * textprop.c (verify_interval_modification, interval_of):
2434 Declare arguments EMACS_INT.
2436 * intervals.c (adjust_intervals_for_insertion): Declare arguments
2439 * intervals.h (CHECK_TOTAL_LENGTH): Cast to EMACS_INT, not `int'.
2441 * indent.c (Fvertical_motion): Local variable it_start is now
2444 * regex.c (re_match, re_match_2, re_match_2_internal)
2445 (bcmp_translate, regcomp, regexec, print_double_string)
2446 (group_in_compile_stack, re_search, re_search_2, regex_compile)
2447 (re_compile_pattern, re_exec): Declare arguments and local
2448 variables `size_t' and `ssize_t' and return values `regoff_t', as
2450 (POP_FAILURE_REG_OR_COUNT) <pfreg>: Declare `long'.
2451 (CHECK_INFINITE_LOOP) <failure>: Declare `ssize_t'.
2452 <compile_stack_type>: `size' and `avail' are now `size_t'.
2454 * regex.h <regoff_t>: Use ssize_t, not int.
2455 (re_search, re_search_2, re_match, re_match_2): Arguments that
2456 specify buffer/string position and length are now ssize_t and
2457 size_t. Return type is regoff_t.
2459 2011-04-16 Ben Key <bkey76@gmail.com>
2461 * nsfont.m: Fixed bugs in ns_get_family and
2462 ns_descriptor_to_entity that were caused by using free to
2463 deallocate memory blocks that were allocated by xmalloc (via
2464 xstrdup). This caused Emacs to crash when compiled with
2465 XMALLOC_OVERRUN_CHECK defined (when Emacs was configured with
2466 --enable-checking=xmallocoverrun). xfree is now used to
2467 deallocate these memory blocks.
2469 2011-04-15 Paul Eggert <eggert@cs.ucla.edu>
2471 * sysdep.c (emacs_read): Remove unnecessary check vs MAX_RW_COUNT.
2473 emacs_write: Accept and return EMACS_INT for sizes.
2474 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html
2476 * gnutls.c, gnutls.h (emacs_gnutls_read, emacs_gnutls_write):
2477 Accept and return EMACS_INT.
2478 (emacs_gnutls_write): Return the number of bytes written on
2480 * sysdep.c, lisp.h (emacs_read, emacs_write): Likewise.
2481 (emacs_read, emacs_write): Remove check for negative size, as the
2482 Emacs source code has been audited now.
2483 * sysdep.c (MAX_RW_COUNT): New macro, to work around kernel bugs.
2484 (emacs_read, emacs_write): Use it.
2485 * process.c (send_process): Adjust to the new signatures of
2486 emacs_write and emacs_gnutls_write. Do not attempt to store
2487 a byte offset into an 'int'; it might overflow.
2488 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00483.html
2490 * sound.c: Don't assume sizes fit in 'int'.
2491 (struct sound_device.period_size, alsa_period_size):
2492 Return EMACS_INT, not int.
2493 (struct sound_device.write, vox_write, alsa_write):
2494 Accept EMACS_INT, not int.
2495 (wav_play, au_play): Use EMACS_INT to store sizes and to
2496 record read return values.
2498 2011-04-15 Ben Key <bkey76@gmail.com>
2500 * keyboard.c (Qundefined): Don't declare static since it is used
2502 * xfaces.c (Qbold, Qexpanded, Qitalic, Qcondensed): Don't declare
2503 static since they are used in nsfont.m.
2505 2011-04-15 Stefan Monnier <monnier@iro.umontreal.ca>
2507 * process.c (Qprocessp): Don't declare static.
2508 * lisp.h (Qprocessp): Declare again.
2510 2011-04-15 Juanma Barranquero <lekktu@gmail.com>
2512 * font.c (Qopentype): Don't make static (used from w32uniscribe.c).
2514 2011-04-14 Paul Eggert <eggert@cs.ucla.edu>
2516 Improve C-level modularity by making more things 'static'.
2518 Don't publish debugger-only interfaces to other modules.
2519 * lisp.h (safe_debug_print, debug_output_compilation_hack):
2520 (verify_bytepos, count_markers): Move decls to the only modules
2522 * region-cache.h (pp_cache): Likewise.
2523 * window.h (check_all_windows): Likewise.
2524 * marker.c, print.c, region-cache.c, window.c: Decls moved here.
2526 * sysdep.c (croak): Now static, if
2527 defined TIOCNOTTY || defined USG5 || defined CYGWIN.
2528 * syssignal.h (croak): Declare only if not static.
2530 * alloc.c (refill_memory_reserve): Now static if
2531 !defined REL_ALLOC || defined SYSTEM_MALLOC.
2532 * lisp.h (refill_memory_reserve): Declare only if not static.
2534 * xsettings.c, xsettings.h (xsettings_get_system_normal_font):
2535 Define only if USE_LUCID.
2537 * xrdb.c (x_customization_string, x_rm_string): Now static.
2539 * xmenu.c (x_menu_wait_for_event): Export only if USE_MOTIF.
2540 * xterm.h (x_menu_wait_for_event): Declare only if USE_MOTIF.
2542 * xdisp.c (draw_row_with_mouse_face): Now static.
2543 * dispextern.h (draw_row_with_mouse_fave): Remove decl.
2545 * window.h (check_all_windows): Mark externally visible.
2547 * window.c (window_deletion_count): Now static.
2549 * undo.c: Make symbols static if they're not exported.
2550 (last_undo_buffer, last_boundary_position, pending_boundary):
2553 * textprop.c (interval_insert_behind_hooks): Now static.
2554 (interval_insert_in_front_hooks): Likewise.
2556 * term.c: Make symbols static if they're not exported.
2557 (tty_turn_off_highlight, get_tty_terminal, max_frame_cols):
2558 (max_frame_lines, tty_set_terminal_modes):
2559 (tty_reset_terminal_modes, tty_turn_off_highlight):
2560 (get_tty_terminal): Now static.
2561 (term_mouse_moveto): Do not define if HAVE_WINDOW_SYSTEM.
2562 * termhooks.h (term_mouse_moveto): Do not declare if
2564 * dispextern.h (tty_set_terminal_modes, tty_reset_terminal_modes):
2565 (tty_turn_off_highlight, get_tty_terminal): Remove decls.
2567 * sysdep.c: Make symbols static if they're not exported.
2568 (emacs_get_tty, emacs_set_tty, old_fcntl_flags, old_fcntl_owner):
2570 (sigprocmask_set, full_mask): Remove; unused.
2571 (wait_debugging): Mark as visible.
2572 * syssignal.h (SIGFULLMASK, full_mask): Remove decls.
2573 * systty.h (emacs_get_tty, emacs_set_tty): Remove decls.
2575 * syntax.c (syntax_temp): Define only if !__GNUC__.
2577 * sound.c (current_sound_device, current_sound): Now static.
2579 * search.c (searchbufs, searchbuf_head): Now static.
2581 * scroll.c (scroll_cost): Remove; unused.
2582 * dispextern.h (scroll_cost): Remove decl.
2584 * region-cache.h (pp_cache): Mark as externally visible.
2586 * process.c: Make symbols static if they're not exported.
2587 (process_tick, update_tick, create_process, chan_process):
2588 (Vprocess_alist, proc_buffered_char, datagram_access):
2589 (fd_callback_data, send_process_frame, process_sent_to): Now static.
2590 (deactivate_process): Mark defn as static, as well as decl.
2591 * lisp.h (create_process): Remove decl.
2592 * process.h (chan_process, Vprocess_alist): Remove decls.
2594 * print.c: Make symbols static if they're not exported.
2595 (print_depth, new_backquote_output, being_printed, print_buffer):
2596 (print_buffer_size, print_buffer_pos, print_buffer_pos_byte):
2597 (print_interval, print_number_index, initial_stderr_stream):
2599 * lisp.h (Fprinc): Remove decl.
2600 (debug_output_compilation_hack): Mark as externally visible.
2602 * sysdep.c (croak): Move decl from here to syssignal.h.
2603 * syssignal.h (croak): Put it here, so the API can be checked when
2604 'croak' is called from dissociate_if_controlling_tty.
2606 * minibuf.c: Make symbols static if they're not exported.
2607 (minibuf_save_list, choose_minibuf_frame): Now static.
2608 * lisp.h (choose_minibuf_frame): Remove decl.
2610 * lisp.h (verify_bytepos, count_markers): Mark as externally visible.
2612 * lread.c: Make symbols static if they're not exported.
2613 (read_objects, initial_obarray, oblookup_last_bucket_number):
2615 (make_symbol): Remove; unused.
2616 * lisp.h (initial_obarray, make_symbol): Remove decls.
2618 * keyboard.c: Make symbols static if they're not exported.
2619 (single_kboard, recent_keys_index, total_keys, recent_keys):
2620 (this_command_key_count_reset, raw_keybuf, raw_keybuf_count):
2621 (this_single_command_key_start, echoing, last_auto_save):
2622 (read_key_sequence_cmd, dribble, recursive_edit_unwind):
2623 (command_loop, echo_now, keyboard_init_hook, help_char_p):
2624 (quit_throw_to_read_char, command_loop_2, top_level_1, poll_timer):
2625 (Vlispy_mouse_stem, double_click_count):
2627 (force_auto_save_soon): Define only if SIGDANGER.
2628 (ignore_mouse_drag_p): Now static if
2629 !defined HAVE_WINDOW_SYSTEM || defined USE_GTK || defined HAVE_NS.
2630 (print_help): Remove; unused.
2631 (stop_character, last_timer_event): Mark as externally visible.
2632 * keyboard.h (ignore_mouse_drag_p): Declare only if
2633 defined HAVE_WINDOW_SYSTEM && !defined USE_GTK && !defined HAVE_NS.
2634 (echo_now, help_char_p, quit_throw_to_read_char): Remove decls.
2635 * lisp.h (echoing): Remove decl.
2636 (force_auto_save_soon): Declare only if SIGDANGER.
2637 * xdisp.c (redisplay_window): Simplify code, to make it more
2638 obvious that ignore_mouse_drag_p is not accessed if !defined
2639 USE_GTK && !defined HAVE_NS.
2641 * intervals.c: Make symbols static if they're not exported.
2642 (merge_properties_sticky, merge_interval_right, delete_interval):
2644 * intervals.h (merge_interval_right, delete_interval): Remove decls.
2646 * insdel.c: Make symbols static if they're not exported.
2647 However, leave prepare_to_modify_buffer alone. It's never
2648 called from outside this function, but that appears to be a bug.
2649 (combine_after_change_list, combine_after_change_buffer):
2650 (adjust_after_replace, signal_before_change): Now static.
2651 (adjust_after_replace_noundo): Remove; unused.
2652 * lisp.h (adjust_after_replace, adjust_after_replace_noundo):
2653 (signal_before_change): Remove decls.
2655 * indent.c (val_compute_motion, val_vmotion): Now static.
2657 * image.c: Make symbols static if they're not exported.
2658 * dispextern.h (x_create_bitmap_from_xpm_data): Do not declare
2660 * image.c (x_create_bitmap_from_xpm_data): Do not define if USE_GTK.
2661 (xpm_color_cache, ct_table, ct_colors_allocated): Now static.
2663 * fringe.c (standard_bitmaps): Now static.
2664 (max_used_fringe_bitmap): Now static, unless HAVE_NS.
2666 * frame.c: Make symbols static if they're not exported.
2667 (x_report_frame_params, make_terminal_frame): Now static.
2668 (get_frame_param): Now static, unless HAVE_NS.
2669 (x_fullscreen_adjust): Define if WINDOWSNT, not if HAVE_WINDOW_SYSTEM.
2670 (x_get_resource_string): Remove; not used.
2671 * frame.h (make_terminal_frame, x_report_frame_params):
2672 (x_get_resource_string); Remove decls.
2673 (x_fullscreen_adjust): Declare only if WINDOWSNT.
2674 * lisp.h (get_frame_param): Declare only if HAVE_NS.
2676 * font.c, fontset.c: Make symbols static if they're not exported.
2677 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): New macro.
2678 (FACE_SUITABLE_FOR_CHAR_P): Use it.
2679 * font.c (font_close_object): Now static.
2680 * font.h (font_close_object): Remove.
2681 * fontset.c (FONTSET_OBJLIST): Remove.
2682 (free_realized_fontset) #if-0 the body, which does nothing.
2683 (face_suitable_for_char_p): #if-0, as it's never called.
2684 * fontset.h (face_suitable_for_char_p): Remove decl.
2685 * xfaces.c (face_at_string_position):
2686 Use FACE_SUITABLE_FOR_ASCII_CHAR_P, not FACE_SUITABLE_FOR_CHAR_P,
2687 since 0 is always ASCII.
2689 * fns.c (weak_hash_tables): Now static.
2691 * fileio.c: Make symbols static if they're not exported.
2692 (auto_saving, auto_save_mode_bits, auto_save_error_occurred):
2693 (Vwrite_region_annotation_buffers): Now static.
2695 * eval.c: Make symbols static if they're not exported.
2696 (backtrace_list, lisp_eval_depth, when_entered_debugger): Now static.
2697 * lisp.h (backtrace_list): Remove decl.
2699 * emacs.c: Make symbols static if they're not exported.
2700 (malloc_state_ptr, malloc_using_checking, syms_of_emacs):
2701 (fatal_error_code, fatal_error_signal_hook, standard_args):
2703 (fatal_error_signal): Now static, unless FLOAT_CATCH_SIGKILL.
2704 (DEFINE_DUMMY_FUNCTION): Mark function as externally visible.
2705 (__CTOR_LIST__, __DTOR_LIST__): Now externally visible.
2706 * lisp.h (fatal_error_signal_hook): Remove decl.
2707 (fatal_error_signal): Declare only if FLOAT_CATCH_SIGKILL.
2709 * editfns.c: Move a (normally-unused) function to its only use.
2710 * editfns.c, lisp.h (get_operating_system_release): Remove.
2711 * process.c (init_process) [DARWIN_OS]: Do it inline, as it is not
2712 worth the hassle of breaking this out.
2714 * xterm.c: Make symbols static if they're not exported.
2715 (x_raise_frame, x_lower_frame, x_wm_set_window_state):
2716 (x_wm_set_icon_pixmap, x_initialize, XTread_socket_fake_io_error):
2717 (x_destroy_window, x_delete_display):
2719 (x_dispatch_event): Now static if ! (USE_MOTIF || USE_X_TOOLKIT).
2720 (x_mouse_leave): Remove; unused.
2721 * xterm.h (x_display_info_for_name, x_raise_frame, x_lower_frame):
2722 (x_destroy_window, x_wm_set_window_state, x_wm_set_icon_pixmap):
2723 (x_delete_display, x_initialize, x_set_border_pixel, x_screen_planes):
2725 (x_mouse_leave): Declare only if WINDOWSNT.
2726 (x_dispatch_event): Declare only if USE_MOTIF or USE_X_TOOLKIT.
2727 (xic_create_fontsetname): Declare only if HAVE_X_WINDOWS &&
2730 * ftxfont.c: Make symbols static if they're not exported.
2731 (ftxfont_driver): Export only if !defined HAVE_XFT && def8ined
2733 * font.h (ftxfont_driver): Likewise.
2735 * xfns.c: Make symbols static if they're not exported.
2736 (x_last_font_name, x_display_info_for_name):
2737 (x_set_foreground_color, x_set_background_color, x_set_mouse_color):
2738 (x_set_cursor_color, x_set_border_pixel, x_set_border_color):
2739 (x_set_cursor_type, x_set_icon_type, x_set_icon_name):
2740 (x_set_scroll_bar_foreground, x_set_scroll_bar_background):
2741 (x_explicitly_set_name, x_set_title, xic_defaut_fontset, tip_timer):
2742 (last_show_tip_args): Now static.
2743 (xic_defaut_fontset, xic_create_fontsetname): Define only if
2744 defined HAVE_X_WINDOWS && defined USE_X_TOOLKIT
2745 (x_screen_planes): Remove; unused.
2746 * dispextern.h (x_screen_planes): Remove decl.
2748 * dispnew.c: Make symbols static if they're not exported.
2749 * dispextern.h (redraw_garbaged_frames, scrolling):
2750 (increment_row_positions): Remove.
2751 * dispnew.c (new_glyph_matrix, increment_row_positions, scrolling):
2752 (delayed_size_change, glyph_matrix_count, glyph_pool_count):
2754 (redraw_garbaged_frames): Remove; unused.
2756 * xfaces.c: Make symbols static if they're not exported.
2757 * dispextern.h (ascii_face_of_lisp_face, free_realized_face):
2759 * xterm.h (defined_color): Remove decls.
2760 (x_free_dpy_colors): Declare only if USE_X_TOOLKIT.
2761 * xfaces.c (tty_suppress_bold_inverse_default_colors_p):
2762 (menu_face_changed_default, defined_color, free_realized_face):
2763 (x_free_dpy_colors): Define only if USE_X_TOOLKIT.
2764 (ascii_face_of_lisp_face): Remove; unused.
2766 * xdisp.c: Make symbols static if they're not exported.
2767 * dispextern.h (scratch_glyph_row, window_box_edges):
2768 (glyph_to_pixel_coords, set_cursor_from_row):
2769 (get_next_display_element, set_iterator_to_next):
2770 (highlight_trailing_whitespace, frame_to_window_pixel_xy):
2771 (show_mouse_face): Remove decls
2772 * frame.h (message_buf_print): Likewise.
2773 * lisp.h (pop_message, set_message, check_point_in_composition):
2775 * xterm.h (set_vertical_scroll_bar): Likewise.
2776 * xdisp.c (list_of_error, Vmessage_stack, line_number_displayed):
2777 (message_buf_print, scratch_glyph_row, displayed_buffer):
2778 (set_iterator_to_next, pop_message, set_message, set_cursor_from_row):
2779 (get_next_display_element, show_mouse_face, window_box_edges):
2780 (frame_to_window_pixel_xy, check_point_in_composition):
2781 (set_vertical_scroll_bar, highlight_trailing_whitespace): Now static.
2782 (glyph_to_pixel_coords): Remove; unused.
2784 * dired.c (file_name_completion): Now static.
2786 * dbusbind.c (xd_in_read_queued_messages): Now static.
2788 * lisp.h (circular_list_error, FOREACH): Remove; unused.
2789 * data.c (circular_list_error): Remove.
2791 * commands.h (last_point_position, last_point_position_buffer):
2792 (last_point_position_window): Remove decls.
2793 * keyboard.c: Make these variables static.
2795 * coding.h (coding, code_convert_region, encode_coding_gap):
2797 * coding.c (Vsjis_coding_system, Vbig5_coding_system):
2798 (iso_code_class, detect_coding, code_convert_region): Now static.
2799 (encode_coding_gap): Remove; unused.
2801 * chartab.c (chartab_chars, chartab_bits): Now static.
2803 * charset.h (charset_iso_8859_1): Remove decl.
2804 * charset.c (charset_iso_8859_1, charset_emacs, map_charset_for_dump):
2807 * ccl.h (check_ccl_update, Vccl_program_table): Remove decls.
2808 * ccl.c (Vccl_program_table): Now static.
2809 (check_ccl_update): Remove; unused.
2811 * category.c (SET_CATEGORY_SET, set_category_set): Move here.
2812 * category.h: ... from here.
2813 * category.c (check_category_table, set_category_set): Now static.
2815 * casetab.c (Vascii_upcase_table, Vascii_eqv_table): Now static.
2816 * lisp.h: Remove these decls.
2818 * buffer.c (buffer_count): Remove unused var.
2820 * bidi.c (bidi_dump_cached_states): Mark as externally visible,
2821 so that it's not optimized away.
2822 (bidi_ignore_explicit_marks_for_paragraph_level): Likewise.
2823 * dispextern.h (bidi_dump_cached_states): Remove, since it's
2824 exported only to the debugger.
2826 * atimer.c (alarm_signal_handler, run_all_atimers): Now static.
2827 * atimer.h (run_all_atimers): Remove; not exported.
2829 font.c: Make copy_font_spec and merge_font_spec ordinary C functions.
2830 * font.c (copy_font_spec): Rename from Fcopy_font_spec, since it
2831 was inaccessible from Lisp.
2832 (merge_font_spec): Likewise, renaming from Fmerge_font_spec.
2833 * font.c, font.h, fontset.c, xfaces.c, xfont.c: Change all uses.
2835 alloc.c: Import and export fewer symbols, and remove unused items.
2836 * lisp.h (suppress_checking, die): Declare only if ENABLE_CHECKING
2838 (suppress_checking): Add EXTERNALLY_VISIBLE attribute, so that
2839 it's not optimized away by whole-program optimization.
2840 (message_enable_multibyte, free_misc): Remove.
2841 (catchlist, handlerlist, mark_backtrace):
2842 Declare only if BYTE_MARK_STACK.
2843 (mark_byte_stack): Likewise, fixing a ifdef-vs-if typo.
2844 * alloc.c (pure): Export only if VIRT_ADDR_VARIES is defined.
2845 (message_enable_multibyte): Remove decl.
2846 (free_misc, interval_free_list, float_block, float_block_index):
2847 (n_float_blocks, float_free_list, cons_block, cons_block_index):
2848 (cons_free_list, last_marked_index):
2850 (suppress_checking, die): Define only if ENABLE_CHECKING is defined.
2851 * eval.c (catchlist, handlerlist): Export only if BYTE_MARK_STACK.
2852 (mark_backtrace): Define only if BYTE_MARK_STACK.
2853 * xdisp.c (message_enable_multibyte): Now static.
2855 Declare Lisp_Object Q* variables to be 'static' if not exported.
2856 This makes it easier for human readers (and static analyzers)
2857 to see whether these variables are used from other modules.
2858 * alloc.c, buffer.c, bytecode.c, callint.c, casetab.c, category.c:
2859 * ccl.c, character.c, charset.c, cmds.c, coding.c, composite.c:
2860 * data.c, dbusbind.c, dired.c, editfns.c, eval.c, fileio.c, fns.c:
2861 * font.c, frame.c, fringe.c, ftfont.c, image.c, keyboard.c, keymap.c:
2862 * lread.c, macros.c, minibuf.c, print.c, process.c, search.c:
2863 * sound.c, syntax.c, textprop.c, window.c, xdisp.c, xfaces.c, xfns.c:
2864 * xmenu.c, xselect.c:
2865 Declare Q* vars static if they are not used in other modules.
2866 * ccl.h, character.h, charset.h, coding.h, composite.h, font.h:
2867 * frame.h, intervals.h, keyboard.h, lisp.h, process.h, syntax.h:
2868 Remove decls of unexported vars.
2869 * keyboard.h (EVENT_HEAD_UNMODIFIED): Remove now-unused macro.
2871 * lisp.h (DEFINE_FUNC): Make sname 'static'.
2873 Make Emacs functions such as Fatom 'static' by default.
2874 This makes it easier for human readers (and static analyzers)
2875 to see whether these functions can be called from other modules.
2876 DEFUN now defines a static function. To make the function external
2877 so that it can be used in other C modules, use the new macro DEFUE.
2878 * lisp.h (Funibyte_char_to_multibyte, Fsyntax_table_p):
2879 (Finit_image_library):
2880 (Feval_region, Fbacktrace, Ffetch_bytecode, Fswitch_to_buffer):
2881 (Ffile_executable_p, Fmake_symbolic_link, Fcommand_execute):
2882 (Fget_process, Fdocumentation_property, Fbyte_code, Ffile_attributes):
2883 Remove decls, since these functions are now static.
2884 (Funintern, Fget_internal_run_time): New decls, since these functions
2885 were already external.
2887 * alloc.c, buffer.c, callint.c, callproc.c, casefiddle.c, casetab.c:
2888 * ccl.c, character.c, chartab.c, cmds.c, coding.c, data.c, dispnew.c:
2889 * doc.c, editfns.c, emacs.c, eval.c, fileio.c, filelock.c, floatfns.c:
2890 * fns.c, font.c, fontset.c, frame.c, image.c, indent.c:
2891 * keyboard.c, keymap.c, lread.c:
2892 * macros.c, marker.c, menu.c, minibuf.c, print.c, process.c, search.c:
2893 * syntax.c, term.c, terminal.c, textprop.c, undo.c:
2894 * window.c, xdisp.c, xfaces.c, xfns.c, xmenu.c, xsettings.c:
2895 Mark functions with DEFUE instead of DEFUN,
2896 if they are used in other modules.
2897 * buffer.c (Fset_buffer_major_mode, Fdelete_overlay): New forward
2898 decls for now-static functions.
2899 * buffer.h (Fdelete_overlay): Remove decl.
2900 * callproc.c (Fgetenv_internal): Mark as internal.
2901 * composite.c (Fremove_list_of_text_properties): Remove decl.
2902 (Fcomposition_get_gstring): New forward static decl.
2903 * composite.h (Fcomposite_get_gstring): Remove decl.
2904 * dired.c (Ffile_attributes): New forward static decl.
2905 * doc.c (Fdocumntation_property): New forward static decl.
2906 * eval.c (Ffetch_bytecode): New forward static decl.
2907 (Funintern): Remove extern decl; now in .h file where it belongs.
2908 * fileio.c (Fmake_symbolic_link): New forward static decl.
2909 * image.c (Finit_image_library): New forward static decl.
2910 * insdel.c (Fcombine_after_change_execute): Make forward decl static.
2911 * intervals.h (Fprevious_property_change):
2912 (Fremove_list_of_text_properties): Remove decls.
2913 * keyboard.c (Fthis_command_keys): Remove decl.
2914 (Fcommand_execute): New forward static decl.
2915 * keymap.c (Flookup_key): New forward static decl.
2916 (Fcopy_keymap): Now static.
2917 * keymap.h (Flookup_key): Remove decl.
2918 * process.c (Fget_process): New forward static decl.
2919 (Fprocess_datagram_address): Mark as internal.
2920 * syntax.c (Fsyntax_table_p): New forward static decl.
2921 (skip_chars): Remove duplicate decl.
2922 * textprop.c (Fprevious_property_change): New forward static decl.
2923 * window.c (Fset_window_fringes, Fset_window_scroll_bars):
2925 (Fset_window_margins, Fset_window_vscroll): New forward static decls.
2926 * window.h (Fset_window_vscroll, Fset_window_margins): Remove decls.
2928 * editfns.c (Fformat): Remove unreachable code.
2930 2011-04-14 Andreas Schwab <schwab@linux-m68k.org>
2932 * fileio.c (Finsert_file_contents): Fix typo in 2005-05-13
2935 2011-04-13 Eli Zaretskii <eliz@gnu.org>
2937 * xdisp.c (handle_invisible_prop): Don't call bidi_paragraph_init
2938 when at ZV. (Bug#8487)
2940 2011-04-12 Andreas Schwab <schwab@linux-m68k.org>
2942 * charset.c (Fclear_charset_maps): Use xfree instead of free.
2944 * keyboard.c (parse_tool_bar_item): Likewise.
2945 * sound.c (sound_cleanup, alsa_close): Likewise.
2946 * termcap.c (tgetent): Likewise.
2947 * xfns.c (x_default_font_parameter): Likewise.
2948 * xsettings.c (read_and_apply_settings): Likewise.
2950 * alloc.c (overrun_check_malloc, overrun_check_realloc)
2951 (overrun_check_free): Protoize.
2953 2011-04-12 Paul Eggert <eggert@cs.ucla.edu>
2955 * sysdep.c (emacs_read, emacs_write): Check for negative sizes
2956 since callers should never pass a negative size.
2957 Change the signature to match that of plain 'read' and 'write'; see
2958 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00397.html>.
2959 * lisp.h: Update prototypes of emacs_write and emacs_read.
2961 2011-04-11 Eli Zaretskii <eliz@gnu.org>
2963 * xdisp.c (redisplay_window): Don't try to determine the character
2964 position of the scroll margin if the window start point w->startp
2965 is outside the buffer's accessible region. (Bug#8468)
2967 2011-04-10 Eli Zaretskii <eliz@gnu.org>
2969 Fix write-region and its subroutines for buffers > 2GB.
2970 * fileio.c (a_write, e_write): Modify declaration of arguments and
2971 local variables to support buffers larger than 2GB.
2972 (Fcopy_file): Use EMACS_INT for return value of emacs_read.
2974 * sysdep.c (emacs_write, emacs_read): Use ssize_t for last
2975 argument, local variables, and return value.
2977 * lisp.h: Update prototypes of emacs_write and emacs_read.
2979 * sound.c (vox_write): Use ssize_t for return value of emacs_write.
2981 2011-04-10 Paul Eggert <eggert@cs.ucla.edu>
2983 * xdisp.c (vmessage): Use memchr, not strnlen, which some hosts lack.
2985 Fix more problems found by GCC 4.6.0's static checks.
2987 * xdisp.c (vmessage): Use a better test for character truncation.
2989 * charset.c (load_charset_map): <, not <=, for optimization,
2990 and to avoid potential problems with integer overflow.
2991 * chartab.c (sub_char_table_set_range, char_table_set_range): Likewise.
2992 * casetab.c (set_identity, shuffle): Likewise.
2993 * editfns.c (Fformat): Likewise.
2994 * syntax.c (skip_chars): Likewise.
2996 * xmenu.c (set_frame_menubar): Allocate smaller local vectors.
2997 This also lets GCC 4.6.0 generate slightly better loop code.
2999 * callint.c (Fcall_interactively): <, not <=, for optimization.
3000 (Fcall_interactively): Count the number of arguments produced,
3001 not the number of arguments given. This is simpler and lets GCC
3002 4.6.0 generate slightly better code.
3004 * ftfont.c: Distingish more carefully between FcChar8 and char.
3005 The previous code passed unsigned char * to a functions like
3006 strlen and xstrcasecmp that expect char *, which does not
3007 conform to the C standard.
3008 (get_adstyle_property, ftfont_pattern_entity): Use FcChar8 for
3009 arguments to FcPatternGetString, and explicitly cast FcChar8 * to
3010 char * when the C standard requires it.
3012 * keyboard.c (read_char): Remove unused var.
3014 * eval.c: Port to Windows vsnprintf (Bug#8435).
3016 (SIZE_MAX): Define if the headers do not.
3017 (verror): Do not give up if vsnprintf returns a negative count.
3018 Instead, grow the buffer. This ports to Windows vsnprintf, which
3019 does not conform to C99. Problem reported by Eli Zaretskii.
3020 Also, simplify the allocation scheme, by avoiding the need for
3021 calling realloc, and removing the ALLOCATED variable.
3023 * eval.c (verror): Initial buffer size is 4000 (not 200) bytes.
3025 Remove invocations of doprnt, as Emacs now uses vsnprintf.
3026 But keep the doprint source code for now, as we might revamp it
3027 and use it again (Bug#8435).
3028 * lisp.h (doprnt): Remove.
3029 * Makefile.in (base_obj): Remove doprnt.o.
3030 * deps.mk (doprnt.o): Remove.
3032 error: Print 32- and 64-bit integers portably (Bug#8435).
3033 Without this change, on typical 64-bit hosts error ("...%d...", N)
3034 was used to print both 32- and 64-bit integers N, which relied on
3036 * lisp.h, src/m/amdx86-64.h, src/m/ia64.h, src/m/ibms390x.h (pEd):
3038 * lisp.h (error, verror): Mark as printf-like functions.
3039 * eval.c (verror): Use vsnprintf, not doprnt, to do the real work.
3040 Report overflow in size calculations when allocating printf buffer.
3041 Do not truncate output string at its first null byte.
3042 * xdisp.c (vmessage): Use vsnprintf, not doprnt, to do the real work.
3043 Truncate the output at a character boundary, since vsnprintf does not
3045 * charset.c (check_iso_charset_parameter): Convert internal
3046 character to string before calling 'error', since %c now has the
3048 * coding.c (Fdecode_sjis_char, Fdecode_big5_char): Avoid int
3049 overflow when computing char to be passed to 'error'. Do not
3050 pass Lisp_Object to 'error'; pass the integer instead.
3051 * nsfns.m (Fns_do_applescript): Use int, not long, since it's
3052 formatted with plain %d.
3054 * eval.c (internal_lisp_condition_case): Don't pass spurious arg.
3056 * keyboard.c (access_keymap_keyremap): Print func name, not garbage.
3058 * coding.c (Fdecode_sjis_char): Don't assume CODE fits in int.
3060 * xterm.c (x_catch_errors): Remove duplicate declaration.
3062 * term.c (maybe_fatal): Mark its 3rd arg as a printf format, too.
3064 * xdisp.c, lisp.h (message_nolog): Remove; unused.
3066 2011-04-10 Jim Meyering <meyering@redhat.com>
3068 use ssize_t and size_t for read- and write-like emacs_gnutls_* functions
3069 * gnutls.c (emacs_gnutls_read): Adjust signature to be more read-like:
3070 return ssize_t not "int", and use size_t as the buffer length.
3071 (emacs_gnutls_write): Likewise, and make the buffer pointer "const".
3072 * gnutls.h: Update declarations.
3073 * process.c (read_process_output): Use ssize_t, to match.
3074 (send_process): Likewise.
3076 2011-04-09 Chong Yidong <cyd@stupidchicken.com>
3078 * image.c (Fimagemagick_types): Doc fix, and comment cleanup.
3080 2011-04-09 Chong Yidong <cyd@stupidchicken.com>
3082 * ftfont.c (get_adstyle_property, ftfont_pattern_entity):
3083 Use unsigned char, to match FcChar8 type definition.
3085 * xterm.c (handle_one_xevent):
3086 * xmenu.c (create_and_show_popup_menu):
3087 * xselect.c (x_decline_selection_request)
3088 (x_reply_selection_request): Avoid type-punned deref of X events.
3090 2011-04-09 Eli Zaretskii <eliz@gnu.org>
3092 Fix some uses of `int' instead of EMACS_INT.
3093 * search.c (string_match_1, fast_string_match)
3094 (fast_c_string_match_ignore_case, fast_string_match_ignore_case)
3095 (scan_buffer, find_next_newline_no_quit)
3096 (find_before_next_newline, search_command, Freplace_match)
3097 (Fmatch_data): Make some `int' variables be EMACS_INT.
3099 * xdisp.c (display_count_lines): 3rd argument and return value now
3100 EMACS_INT. All callers changed.
3101 (pint2hrstr): Last argument is now EMACS_INT.
3103 * coding.c (detect_coding_utf_8, detect_coding_emacs_mule)
3104 (detect_coding_iso_2022, detect_coding_sjis, detect_coding_big5)
3105 (detect_coding_ccl, detect_coding_charset, decode_coding_utf_8)
3106 (decode_coding_utf_16, decode_coding_emacs_mule)
3107 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5)
3108 (decode_coding_ccl, decode_coding_charset)
3109 <consumed_chars, consumed_chars_base>: Declare EMACS_INT.
3110 (decode_coding_iso_2022, decode_coding_emacs_mule)
3111 (decode_coding_sjis, decode_coding_big5, decode_coding_charset)
3112 <char_offset, last_offset>: Declare EMACS_INT.
3113 (encode_coding_utf_8, encode_coding_utf_16)
3114 (encode_coding_emacs_mule, encode_invocation_designation)
3115 (encode_designation_at_bol, encode_coding_iso_2022)
3116 (encode_coding_sjis, encode_coding_big5, encode_coding_ccl)
3117 (encode_coding_raw_text, encode_coding_charset) <produced_chars>:
3119 (ASSURE_DESTINATION): Declare more_bytes EMACS_INT.
3120 (encode_invocation_designation): Last argument P_NCHARS is now
3122 (decode_eol): Declare pos_byte, pos, and pos_end EMACS_INT.
3123 (produce_chars): from_nchars and to_nchars are now EMACS_INT.
3125 * coding.h (struct coding_system) <head_ascii>: Declare EMACS_INT.
3128 * ccl.c (Fccl_execute_on_string): Declare some variables
3131 2011-04-08 Samuel Thibault <sthibault@debian.org> (tiny change)
3133 * term.c (init_tty): Fix incorrect ifdef placement (Bug#8450).
3135 2011-03-19 Christoph Scholtes <cschol2112@googlemail.com>
3137 * process.c (Fformat_network_address): Doc fix.
3139 2011-04-08 T.V. Raman <tv.raman.tv@gmail.com> (tiny change)
3141 * xml.c (parse_region): Avoid creating spurious whiespace nodes.
3143 2011-04-08 Chong Yidong <cyd@stupidchicken.com>
3145 * keyboard.c (read_char): Call Lisp function help-form-show,
3146 instead of using internal_with_output_to_temp_buffer.
3147 (Qhelp_form_show): New var.
3148 (syms_of_keyboard): Use DEFSYM macro.
3150 * print.c (internal_with_output_to_temp_buffer): Function deleted.
3152 * lisp.h (internal_with_output_to_temp_buffer): Remove prototype.
3154 2011-04-06 Chong Yidong <cyd@stupidchicken.com>
3156 * process.c (Flist_processes): Remove to Lisp.
3157 (list_processes_1): Delete.
3159 2011-04-06 Eli Zaretskii <eliz@gnu.org>
3161 * msdos.c (careadlinkat, careadlinkatcwd): MS-DOS replacements.
3163 * w32.c (careadlinkat, careadlinkatcwd): New always-fail stubs.
3165 2011-04-06 Paul Eggert <eggert@cs.ucla.edu>
3167 Fix more problems found by GCC 4.6.0's static checks.
3169 * xmenu.c (Fx_popup_dialog): Don't assume string is free of formats.
3171 * menu.c (Fx_popup_menu): Don't assume error_name lacks printf formats.
3173 * lisp.h (message, message_nolog, fatal): Mark as printf-like.
3175 * xdisp.c (vmessage): Mark as a printf-like function.
3177 * term.c (vfatal, maybe_fatal): Mark as printf-like functions.
3179 * sound.c (sound_warning): Don't crash if arg contains a printf format.
3181 * image.c (tiff_error_handler, tiff_warning_handler): Mark as
3182 printf-like functions.
3183 (tiff_load): Add casts to remove these marks before passing them
3184 to system-supplied API.
3186 * eval.c (Fsignal): Remove excess argument to 'fatal'.
3188 * coding.c (EMIT_ONE_BYTE, EMIT_TWO_BYTES): Use unsigned, not int.
3189 This avoids several warnings with gcc -Wstrict-overflow.
3190 (DECODE_COMPOSITION_RULE): If the rule is invalid, goto invalid_code
3191 directly, rather than having caller test rule sign. This avoids
3192 some unnecessary tests.
3193 * composite.h (COMPOSITION_ENCODE_RULE_VALID): New macro.
3194 (COMPOSITION_ENCODE_RULE): Arguments now must be valid. This
3195 affects only one use, in DECODE_COMPOSITION_RULE, which is changed.
3197 * xfont.c (xfont_text_extents): Remove var that was set but not used.
3198 (xfont_open): Avoid unnecessary tests.
3200 * composite.c (composition_gstring_put_cache): Use unsigned integer.
3202 * composite.h, composite.c (composition_gstring_put_cache):
3203 Use EMACS_INT, not int, for length.
3205 * composite.h (COMPOSITION_DECODE_REFS): New macro,
3206 breaking out part of COMPOSITION_DECODE_RULE.
3207 (COMPOSITION_DECODE_RULE): Use it.
3208 * composite.c (get_composition_id): Remove unused local vars,
3209 by using the new macro.
3211 * textprop.c (set_text_properties_1): Change while to do-while,
3212 since the condition is always true at first.
3214 * intervals.c (graft_intervals_into_buffer): Mark var as used.
3215 (interval_deletion_adjustment): Return unsigned value.
3218 * process.c (list_processes_1, create_pty, read_process_output):
3219 (exec_sentinel): Remove vars that were set but not used.
3220 (create_pty): Remove unnecessary "volatile"s.
3221 (Fnetwork_interface_info): Avoid possibility of int overflow.
3222 (read_process_output): Do adaptive read buffering even if carryover.
3223 (read_process_output): Simplify nbytes computation if buffered.
3225 * bytecode.c (exec_byte_code): Rename local to avoid shadowing.
3227 * syntax.c (scan_words): Remove var that was set but not used.
3228 (update_syntax_table): Use unsigned instead of int.
3230 * lread.c (lisp_file_lexically_bound_p): Use ints rather than endptrs.
3231 (lisp_file_lexically_bound_p, read1): Use unsigned instead of int.
3232 (safe_to_load_p): Make the end-of-loop test the inverse of the in-loop.
3234 * print.c (print_error_message): Avoid int overflow.
3236 * font.c (font_list_entities): Redo for clarity,
3237 so that reader need not know FONT_DPI_INDEX + 1 == FONT_SPACING_INDEX.
3239 * font.c (font_find_for_lface, Ffont_get_glyphs): Remove unused vars.
3240 (font_score): Avoid potential overflow in diff calculation.
3242 * fns.c (substring_both): Remove var that is set but not used.
3243 (sxhash): Redo loop for clarity and to avoid wraparound warning.
3245 * eval.c (funcall_lambda): Rename local to avoid shadowing.
3247 * alloc.c (mark_object_loop_halt, mark_object): Use size_t, not int.
3248 Otherwise, GCC 4.6.0 optimizes the loop check away since the check
3249 can always succeed if overflow has undefined behavior.
3251 * search.c (boyer_moore, wordify): Remove vars set but not used.
3252 (wordify): Omit three unnecessary tests.
3254 * indent.c (MULTIBYTE_BYTES_WIDTH): Don't compute wide_column.
3255 All callers changed. This avoids the need for an unused var.
3257 * casefiddle.c (casify_region): Remove var that is set but not used.
3259 * dired.c (file_name_completion): Remove var that is set but not used.
3261 * fileio.c (Finsert_file_contents): Make EOF condition clearer.
3263 * fileio.c (Finsert_file_contents): Avoid signed integer overflow.
3264 (Finsert_file_contents): Remove unnecessary code checking fd.
3266 * minibuf.c (read_minibuf_noninteractive): Use size_t for sizes.
3267 Check for integer overflow on size calculations.
3269 * buffer.c (Fprevious_overlay_change): Remove var that is set
3272 * keyboard.c (menu_bar_items, read_char_minibuf_menu_prompt):
3273 Remove vars that are set but not used.
3274 (timer_check_2): Don't assume timer-list and idle-timer-list are lists.
3275 (timer_check_2): Mark vars as initialized.
3277 * gtkutil.c (xg_get_file_with_chooser): Mark var as initialized.
3279 * image.c (lookup_image): Remove var that is set but not used.
3280 (xbm_load): Use parse_p, for gcc -Werror=unused-but-set-variable.
3282 * fontset.c (Finternal_char_font, Ffontset_info): Remove vars
3283 that are set but not used.
3285 * xfns.c (make_invisible_cursor): Don't return garbage
3286 if XCreateBitmapFromData fails (Bug#8410).
3288 * xselect.c (x_get_local_selection, x_handle_property_notify):
3289 Remove vars that are set but not used.
3291 * xfns.c (x_create_tip_frame): Remove var that is set but not used.
3292 (make_invisible_cursor): Initialize a possibly-uninitialized variable.
3294 * xterm.c (x_scroll_bar_to_input_event) [!USE_GTK]:
3295 Remove var that is set but not used.
3296 (scroll_bar_windows_size): Now size_t, not int.
3297 (x_send_scroll_bar_event): Use size_t, not int, for sizes.
3300 * xfaces.c (realize_named_face): Remove vars that are set but not used.
3301 (map_tty_color) [!defined MSDOS]: Likewise.
3303 * term.c (tty_write_glyphs): Use size_t; this avoids overflow warning.
3305 * coding.c: Remove vars that are set but not used.
3306 (DECODE_COMPOSITION_RULE): Remove 2nd arg, which is unused.
3307 All callers changed.
3308 (decode_coding_utf_8, decode_coding_utf_16 decode_coding_emacs_mule):
3309 (decode_coding_iso_2022, encode_coding_sjis, encode_coding_big5):
3310 (decode_coding_charset): Remove vars that are set but not used.
3312 * bytecode.c (Fbyte_code) [!defined BYTE_CODE_SAFE]: Remove var
3313 that is set but not used.
3315 * print.c (print_object): Remove var that is set but not used.
3317 Replace 2 copies of readlink code with 1 gnulib version (Bug#8401).
3318 The gnulib version avoids calling malloc in the usual case,
3319 and on 64-bit hosts doesn't have some arbitrary 32-bit limits.
3320 * fileio.c (Ffile_symlink_p): Use emacs_readlink.
3321 * filelock.c (current_lock_owner): Likewise.
3322 * lisp.h (READLINK_BUFSIZE, emacs_readlink): New function.
3323 * sysdep.c: Include allocator.h, careadlinkat.h.
3324 (emacs_no_realloc_allocator): New static constant.
3325 (emacs_readlink): New function.
3326 * deps.mk (sysdep.o): Depend on ../lib/allocator.h and on
3327 ../lib/careadlinkat.h.
3329 2011-04-04 Stefan Monnier <monnier@iro.umontreal.ca>
3331 * keyboard.c (safe_run_hook_funcall): Fix last change (don't stop at the
3332 first non-nil return value).
3334 2011-04-03 Jan Djärv <jan.h.d@swipnet.se>
3336 * nsterm.m (ns_update_auto_hide_menu_bar): Define MAC_OS_X_VERSION_10_6
3337 if not defined (Bug#8403).
3339 2011-04-02 Juanma Barranquero <lekktu@gmail.com>
3341 * xdisp.c (display_count_lines): Remove parameter `start',
3342 unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
3343 (get_char_face_and_encoding): Remove parameter `multibyte_p',
3344 unused since 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
3345 (fill_stretch_glyph_string): Remove parameters `row' and `area',
3346 unused at least since Kim's GUI unification at 2003-03-16T20:45:46Z!storm@cua.dk
3347 and thereabouts. All callers changed.
3348 (get_per_char_metric): Remove parameter `f', unused since
3349 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
3351 2011-04-02 Jim Meyering <meyering@redhat.com>
3353 do not dereference NULL upon failed strdup
3354 * nsfont.m (ns_descriptor_to_entity): Use xstrdup, not strdup.
3355 (ns_get_family): Likewise.
3357 2011-04-02 Juanma Barranquero <lekktu@gmail.com>
3359 * eval.c (unwind_to_catch) [DEBUG_GCPRO]: Remove redundant assignment.
3361 2011-04-02 Jan Djärv <jan.h.d@swipnet.se>
3363 * nsterm.m (ns_update_auto_hide_menu_bar): Only for OSX 10.6 or
3366 2011-04-01 Stefan Monnier <monnier@iro.umontreal.ca>
3368 Add lexical binding.
3370 * window.c (Ftemp_output_buffer_show): New fun.
3371 (Fsave_window_excursion):
3372 * print.c (Fwith_output_to_temp_buffer): Move to subr.el.
3374 * lread.c (lisp_file_lexically_bound_p): New function.
3375 (Fload): Bind Qlexical_binding.
3376 (readevalloop): Remove `evalfun' arg.
3377 Bind Qinternal_interpreter_environment.
3378 (Feval_buffer): Bind Qlexical_binding.
3379 (defvar_int, defvar_bool, defvar_lisp_nopro, defvar_kboard):
3381 (syms_of_lread): Declare `lexical-binding'.
3383 * lisp.h (struct Lisp_Symbol): New field `declared_special'.
3385 * keyboard.c (eval_dyn): New fun.
3386 (menu_item_eval_property): Use it.
3388 * image.c (parse_image_spec): Use Ffunctionp.
3390 * fns.c (concat, mapcar1): Accept byte-code-functions.
3392 * eval.c (Fsetq): Handle lexical vars.
3393 (Fdefun, Fdefmacro, Ffunction): Make closures when needed.
3394 (Fdefconst, Fdefvaralias, Fdefvar): Mark as dynamic.
3395 (FletX, Flet): Obey lexical binding.
3396 (Fcommandp): Handle closures.
3397 (Feval): New `lexical' arg.
3398 (eval_sub): New function extracted from Feval. Use it almost
3399 everywhere where Feval was used. Look up vars in lexical env.
3401 (Ffunctionp): Move from subr.el.
3402 (Ffuncall): Handle closures.
3403 (apply_lambda): Remove `eval_flags'.
3404 (funcall_lambda): Handle closures and new byte-code-functions.
3405 (Fspecial_variable_p): New function.
3406 (syms_of_eval): Initialize the Vinternal_interpreter_environment var,
3407 but without exporting it to Lisp.
3409 * doc.c (Fdocumentation, store_function_docstring):
3410 * data.c (Finteractive_form): Handle closures.
3412 * callint.c (Fcall_interactively): Preserve lexical-binding mode for
3415 * bytecode.c (Bstack_ref, Bstack_set, Bstack_set2, BdiscardN):
3417 (exec_byte_code): New function extracted from Fbyte_code to handle new
3418 calling convention for byte-code-functions. Add new byte-codes.
3420 * buffer.c (defvar_per_buffer): Set new `declared_special' field.
3422 * alloc.c (Fmake_symbol): Init new `declared_special' field.
3424 2011-03-31 Juanma Barranquero <lekktu@gmail.com>
3426 * xdisp.c (redisplay_internal): Fix prototype.
3428 2011-03-31 Eli Zaretskii <eliz@gnu.org>
3430 * xdisp.c (SCROLL_LIMIT): New macro.
3431 (try_scrolling): Use it when setting scroll_limit.
3432 Limit scrolling to 100 screen lines.
3433 (redisplay_window): Even when falling back on "recentering",
3434 position point in the window according to scroll-conservatively,
3435 scroll-margin, and scroll-*-aggressively variables. (Bug#6671)
3437 (try_scrolling): When point is above the window, allow searching
3438 as far as scroll_max, or one screenful, to compute vertical
3439 distance from PT to the scroll margin position. This prevents
3440 try_scrolling from unnecessarily failing when
3441 scroll-conservatively is set to a value slightly larger than the
3442 window height. Clean up the case of PT below the margin at bottom
3443 of window: scroll_max can no longer be INT_MAX. When aggressive
3444 scrolling is in use, don't let point enter the opposite scroll
3445 margin as result of the scroll.
3446 (syms_of_xdisp) <scroll-conservatively>: Document the
3447 threshold of 100 lines for never-recentering scrolling.
3449 2011-03-31 Juanma Barranquero <lekktu@gmail.com>
3451 * dispextern.h (move_it_by_lines):
3452 * xdisp.c (move_it_by_lines): Remove parameter `need_y_p', unused
3453 since 2000-12-29T14:24:09Z!gerd@gnu.org. All callers changed.
3454 (message_log_check_duplicate): Remove parameters `prev_bol' and
3455 `this_bol', unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
3456 (redisplay_internal): Remove parameter `preserve_echo_area',
3457 unused since 1999-07-21T21:43:52Z!gerd@gnu.org. All callers changed.
3459 * indent.c (Fvertical_motion):
3460 * window.c (window_scroll_pixel_based, Frecenter):
3461 Don't pass `need_y_p' to `move_it_by_lines'.
3463 2011-03-30 Stefan Monnier <monnier@iro.umontreal.ca>
3465 * eval.c (struct backtrace): Don't cheat with negative numbers, but do
3466 steal a few bits to be more compact.
3467 (interactive_p, Fbacktrace, Fbacktrace_frame, mark_backtrace):
3468 Remove unneeded casts.
3470 * bytecode.c (Fbyte_code): CAR and CDR can GC.
3472 2011-03-30 Zachary Kanfer <zkanfer@gmail.com> (tiny change)
3474 * keyboard.c (Fexecute_extended_command): Do log the "suggest key
3475 binding" message (bug#7967).
3477 2011-03-30 Paul Eggert <eggert@cs.ucla.edu>
3479 Fix more problems found by GCC 4.6.0's static checks.
3481 * unexelf.c (unexec) [! (defined _SYSTYPE_SYSV || defined __sgi)]:
3482 Remove unused local var.
3484 * editfns.c (Fmessage_box): Remove unused local var.
3486 * xdisp.c (try_window_reusing_current_matrix, x_produce_glyphs):
3487 (note_mode_line_or_margin_highlight, note_mouse_highlight):
3488 Omit unused local vars.
3489 * window.c (shrink_windows): Omit unused local var.
3490 * menu.c (digest_single_submenu): Omit unused local var.
3491 * dispnew.c (update_window) [PERIODIC_PREEMPTION_CHECKING]:
3492 Omit unused local var.
3494 * keyboard.c (parse_modifiers_uncached, parse_modifiers):
3495 Don't assume string length fits in int.
3496 (keyremap_step, read_key_sequence): Use size_t for sizes.
3497 (read_key_sequence): Don't check last_real_key_start redundantly.
3499 * callproc.c (Fcall_process, Fcall_process_region): Use SAFE_ALLOCA
3500 instead of alloca (Bug#8344).
3502 * eval.c (Fbacktrace): Don't assume nargs fits in int.
3503 (Fbacktrace_frame): Don't assume nframes fits in int.
3505 * syntax.c (scan_sexps_forward): Avoid pointer wraparound.
3507 * xterm.c (x_make_frame_visible, same_x_server): Redo to avoid overflow
3510 * term.c (produce_glyphless_glyph): Remove unnecessary test.
3512 * cm.c (calccost): Turn while-do into do-while, for clarity.
3514 * keyboard.c (syms_of_keyboard): Use the same style as later
3515 in this function when indexing through an array. This also
3516 works around GCC bug 48267.
3518 * image.c (tiff_load): Fix off-by-one image count (Bug#8336).
3520 * xselect.c (x_check_property_data): Return correct size (Bug#8335).
3522 * chartab.c (sub_char_table_ref_and_range): Redo for slight
3523 efficiency gain, and to bypass a gcc -Wstrict-overflow warning.
3525 * keyboard.c, keyboard.h (num_input_events): Now size_t.
3526 This avoids undefined behavior on integer overflow, and is a bit
3527 more convenient anyway since it is compared to a size_t variable.
3529 Variadic C functions now count arguments with size_t, not int.
3530 This avoids an unnecessary limitation on 64-bit machines, which
3531 caused (substring ...) to crash on large vectors (Bug#8344).
3532 * lisp.h (struct Lisp_Subr.function.aMANY): Now takes size_t, not int.
3533 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call): Likewise.
3534 All variadic functions and their callers changed accordingly.
3535 (struct gcpro.nvars): Now size_t, not int. All uses changed.
3536 * data.c (arith_driver, float_arith_driver): Likewise.
3537 * editfns.c (general_insert_function): Likewise.
3538 * eval.c (struct backtrace.nargs, interactive_p)
3539 (internal_condition_case_n, run_hook_with_args, apply_lambda)
3540 (funcall_lambda, mark_backtrace): Likewise.
3541 * fns.c (concat): Likewise.
3542 * frame.c (x_set_frame_parameters): Likewise.
3543 * fns.c (get_key_arg): Now accepts and returns size_t, and returns
3544 0 if not found, not -1. All callers changed.
3546 * alloc.c (garbage_collect): Don't assume stack size fits in int.
3547 (stack_copy_size): Now size_t, not int.
3548 (stack_copy, stack_copy_size): Define only if MAX_SAVE_STACK > 0.
3550 2011-03-28 Juanma Barranquero <lekktu@gmail.com>
3552 * coding.c (encode_designation_at_bol): Remove parameter `charbuf_end',
3553 unused since 2002-03-01T01:17:24Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
3554 All callers changed.
3556 * lisp.h (multibyte_char_to_unibyte):
3557 * character.c (multibyte_char_to_unibyte): Remove parameter `rev_tbl',
3558 unused since 2002-03-01T01:16:34Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
3559 * character.h (CHAR_TO_BYTE8):
3560 * cmds.c (internal_self_insert):
3561 * editfns.c (general_insert_function):
3562 * keymap.c (push_key_description):
3563 * search.c (Freplace_match):
3564 * xdisp.c (message_dolog, set_message_1): All callers changed.
3566 2011-03-28 Stefan Monnier <monnier@iro.umontreal.ca>
3568 * keyboard.c (safe_run_hook_funcall): New function.
3569 (safe_run_hooks_1, safe_run_hooks_error, safe_run_hooks): On error,
3570 don't set the hook to nil, but remove the offending function instead.
3571 (Qcommand_hook_internal): Remove, unused.
3572 (syms_of_keyboard): Don't initialize Qcommand_hook_internal nor define
3573 Vcommand_hook_internal.
3575 * eval.c (enum run_hooks_condition): Remove.
3576 (funcall_nil, funcall_not): New functions.
3577 (run_hook_with_args): Call each function through a `funcall' argument.
3578 Remove `cond' argument, now redundant.
3579 (Frun_hooks, Frun_hook_with_args, Frun_hook_with_args_until_success)
3580 (Frun_hook_with_args_until_failure): Adjust accordingly.
3581 (run_hook_wrapped_funcall, Frun_hook_wrapped): New functions.
3583 2011-03-28 Juanma Barranquero <lekktu@gmail.com>
3585 * dispextern.h (string_buffer_position): Remove declaration.
3587 * print.c (strout): Remove parameter `multibyte', unused since
3588 1999-08-21T19:30:21Z!gerd@gnu.org. All callers changed.
3590 * search.c (boyer_moore): Remove parameters `len', `pos' and `lim',
3591 never used since function introduction in 1998-02-08T21:33:56Z!rms@gnu.org.
3592 All callers changed.
3594 * w32.c (_wsa_errlist): Use braces for struct initializers.
3596 * xdisp.c (string_buffer_position_lim): Remove parameter `w',
3597 never used since function introduction in 2001-03-09T18:41:50Z!gerd@gnu.org.
3598 All callers changed.
3599 (string_buffer_position): Likewise. Also, make static (it's never
3600 used outside xdisp.c).
3601 (cursor_row_p): Remove parameter `w', unused since
3602 2000-10-17T16:08:57Z!gerd@gnu.org. All callers changed.
3603 (decode_mode_spec): Remove parameter `precision', introduced during
3604 Gerd Moellmann's rewrite at 1999-07-21T21:43:52Z!gerd@gnu.org, but never used.
3605 All callers changed.
3607 2011-03-27 Jan Djärv <jan.h.d@swipnet.se>
3609 * nsterm.m (syms_of_nsterm): Use doc: for ns-auto-hide-menu-bar.
3611 2011-03-27 Anders Lindgren <andlind@gmail.com>
3613 * nsterm.m (ns_menu_bar_is_hidden): New variable.
3614 (ns_constrain_all_frames, ns_menu_bar_should_be_hidden)
3615 (ns_update_auto_hide_menu_bar): New functions.
3616 (ns_update_begin): Call ns_update_auto_hide_menu_bar.
3617 (applicationDidBecomeActive): Call ns_update_auto_hide_menu_bar and
3618 ns_constrain_all_frames.
3619 (constrainFrameRect): Return at once if ns_menu_bar_should_be_hidden.
3620 (syms_of_nsterm): DEFVAR ns-auto-hide-menu-bar, init to Qnil.
3622 2011-03-27 Jan Djärv <jan.h.d@swipnet.se>
3624 * nsmenu.m (runDialogAt): Remove argument to timer_check.
3626 2011-03-27 Glenn Morris <rgm@gnu.org>
3628 * syssignal.h: Replace RETSIGTYPE with void.
3629 * atimer.c, data.c, dispnew.c, emacs.c, floatfns.c, keyboard.c:
3630 * keyboard.h, lisp.h, process.c, sysdep.c, xterm.c:
3631 Replace SIGTYPE with void everywhere.
3632 * s/usg5-4-common.h (SIGTYPE): Remove definition.
3633 * s/template.h (SIGTYPE): Remove commented out definition.
3635 2011-03-26 Eli Zaretskii <eliz@gnu.org>
3637 * xdisp.c (redisplay_window): Don't check buffer's clip_changed
3638 flag as a prerequisite for invoking try_scrolling. (Bug#6671)
3640 2011-03-26 Juanma Barranquero <lekktu@gmail.com>
3642 * w32.c (read_unc_volume): Use parameter `henum', instead of
3643 global variable `wget_enum_handle'.
3645 * keymap.c (describe_vector): Remove parameters `indices' and
3646 `char_table_depth', unused since 2002-03-01T01:43:26Z!handa@m17n.org.
3647 (describe_map, Fdescribe_vector): Adjust calls to `describe_vector'.
3649 * keyboard.h (timer_check, show_help_echo): Remove unused parameters.
3651 * keyboard.c (timer_check): Remove parameter `do_it_now',
3652 unused since 1996-04-12T06:01:29Z!rms@gnu.org.
3653 (show_help_echo): Remove parameter `ok_to_overwrite_keystroke_echo',
3654 unused since 2008-04-19T19:30:53Z!monnier@iro.umontreal.ca.
3656 * keyboard.c (read_char):
3657 * w32menu.c (w32_menu_display_help):
3658 * xmenu.c (show_help_event, menu_help_callback):
3659 Adjust calls to `show_help_echo'.
3661 * gtkutil.c (xg_maybe_add_timer):
3662 * keyboard.c (readable_events):
3663 * process.c (wait_reading_process_output):
3664 * xmenu.c (x_menu_wait_for_event): Adjust calls to `timer_check'.
3666 * insdel.c (adjust_markers_gap_motion):
3667 Remove; no-op since 1998-01-02T21:29:48Z!rms@gnu.org.
3668 (gap_left, gap_right): Don't call it.
3670 2011-03-25 Chong Yidong <cyd@stupidchicken.com>
3672 * xdisp.c (handle_fontified_prop): Discard changes to clip_changed
3673 incurred during fontification.
3675 2011-03-25 Juanma Barranquero <lekktu@gmail.com>
3677 * buffer.c (defvar_per_buffer): Remove unused parameter `doc'.
3678 (DEFVAR_PER_BUFFER): Don't pass it.
3680 * dispnew.c (row_equal_p, add_row_entry): Remove unused parameter `w'.
3681 (scrolling_window): Don't pass it.
3683 2011-03-25 Juanma Barranquero <lekktu@gmail.com>
3685 * dispextern.h (glyph_matric): Use #if GLYPH_DEBUG, not #ifdef.
3687 * fileio.c (check_executable) [DOS_NT]: Remove unused variables `len'
3689 (Fset_file_selinux_context) [HAVE_LIBSELINUX]: Move here declaration
3690 of variables specific to SELinux and computation of `encoded_absname'.
3692 * image.c (XPutPixel): Remove unused variable `height'.
3694 * keyboard.c (make_lispy_event): Remove unused variable `hpos'.
3696 * unexw32.c (get_section_info): Remove unused variable `section'.
3698 * w32.c (stat): Remove unused variables `drive_root' and `devtype'.
3699 (system_process_attributes): Remove unused variable `sess'.
3700 (sys_read): Remove unused variable `err'.
3702 * w32fns.c (top): Wrap variables with #if GLYPH_DEBUG, not #ifdef.
3703 (w32_wnd_proc): Remove unused variable `isdead'.
3704 (unwind_create_frame): Use #if GLYPH_DEBUG, not #ifdef.
3705 (Fx_server_max_request_size): Remove unused variable `dpyinfo'.
3706 (x_create_tip_frame): Remove unused variable `tem'.
3708 * w32inevt.c (w32_console_read_socket):
3709 Remove unused variable `no_events'.
3711 * w32term.c (x_draw_composite_glyph_string_foreground):
3712 Remove unused variable `width'.
3714 2011-03-24 Juanma Barranquero <lekktu@gmail.com>
3716 * w32term.c (x_set_glyph_string_clipping):
3717 Don't pass uninitialized region to CombineRgn.
3719 2011-03-23 Juanma Barranquero <lekktu@gmail.com>
3721 * w32fns.c (x_set_menu_bar_lines): Remove unused variable `olines'.
3722 (w32_wnd_proc): Pass NULL to Windows API, not uninitialized buffer.
3723 (Fx_close_connection): Remove unused variable `i'.
3725 * w32font.c (w32font_draw): Return number of glyphs.
3726 (w32font_open_internal): Remove unused variable `i'.
3727 (w32font_driver): Add missing initializer.
3729 * w32menu.c (utf8to16): Remove unused variable `utf16'.
3730 (fill_in_menu): Remove unused variable `items_added'.
3732 * w32term.c (last_mouse_press_frame): Remove static global variable.
3733 (w32_clip_to_row): Remove unused variable `f'.
3734 (x_delete_terminal): Remove unused variable `i'.
3736 * w32uniscribe.c (uniscribe_shape): Remove unused variable `nclusters'.
3737 (NOTHING): Remove unused static global variable.
3738 (uniscribe_check_otf): Remove unused variable `table'.
3739 (uniscribe_font_driver): Add missing initializers.
3741 2011-03-23 Julien Danjou <julien@danjou.info>
3743 * term.c (Fsuspend_tty, Fresume_tty):
3744 * minibuf.c (read_minibuf, run_exit_minibuf_hook):
3745 * window.c (temp_output_buffer_show):
3746 * insdel.c (signal_before_change):
3747 * frame.c (Fhandle_switch_frame):
3748 * fileio.c (Fdo_auto_save):
3749 * emacs.c (Fkill_emacs):
3750 * editfns.c (save_excursion_restore):
3751 * cmds.c (internal_self_insert):
3752 * callint.c (Fcall_interactively):
3753 * buffer.c (Fkill_all_local_variables):
3754 * keyboard.c (Fcommand_execute, Fsuspend_emacs, safe_run_hooks_1):
3756 (command_loop_1): Use Frun_hooks. Call safe_run_hooks
3757 unconditionnaly since it does the check itself.
3759 2011-03-23 Paul Eggert <eggert@cs.ucla.edu>
3761 Fix more problems found by GCC 4.5.2's static checks.
3763 * coding.c (encode_coding_raw_text): Avoid unnecessary test
3764 the first time through the loop, since we know p0 < p1 then.
3765 This also avoids a gcc -Wstrict-overflow warning.
3767 * lisp.h (SAFE_ALLOCA, SAFE_ALLOCA_LISP): Avoid 'int' overflow
3768 leading to a memory leak, possible in functions like
3769 load_charset_map_from_file that can allocate an unbounded number
3770 of objects (Bug#8318).
3772 * xmenu.c (set_frame_menubar): Use EMACS_UINT, not int, for indexes
3773 that could (at least in theory) be that large.
3775 * xdisp.c (message_log_check_duplicate): Return unsigned long, not int.
3776 This is less likely to overflow, and avoids undefined behavior if
3777 overflow does occur. All callers changed. Use strtoul to scan
3778 for the unsigned long integer.
3779 (pint2hrstr): Simplify and tune code slightly.
3780 This also avoids a (bogus) GCC warning with gcc -Wstrict-overflow.
3782 * scroll.c (do_scrolling): Work around GCC bug 48228.
3783 See <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=48228>.
3785 * frame.c (Fmodify_frame_parameters): Simplify loop counter.
3786 This also avoids a warning with gcc -Wstrict-overflow.
3787 (validate_x_resource_name): Simplify count usage.
3788 This also avoids a warning with gcc -Wstrict-overflow.
3790 * fileio.c (Fcopy_file): Report error if fchown or fchmod
3793 * emacs.c (Fdaemon_initialized): Do not ignore I/O errors (Bug#8303).
3795 * process.c (Fmake_network_process): Use socklen_t, not int,
3796 where POSIX says socklen_t is required in portable programs.
3797 This fixes a porting bug on hosts like 64-bit HP-UX, where
3798 socklen_t is wider than int (Bug#8277).
3799 (Fmake_network_process, server_accept_connection):
3800 (wait_reading_process_output, read_process_output):
3803 * process.c: Rename or move locals to avoid shadowing.
3804 (list_processes_1, Fmake_network_process):
3805 (read_process_output_error_handler, exec_sentinel_error_handler):
3806 Rename or move locals.
3807 (Fmake_network_process): Define label "retry_connect" only if needed.
3808 (Fnetwork_interface_info): Fix pointer signedness.
3809 (process_send_signal): Add cast to avoid pointer signedness problem.
3810 (FIRST_PROC_DESC, IF_NON_BLOCKING_CONNECT): Remove unused macros.
3811 (create_process): Use 'volatile' to avoid vfork clobbering (Bug#8298).
3813 Make tparam.h and terminfo.c consistent.
3814 * cm.c (tputs, tgoto, BC, UP): Remove extern decls.
3815 Include tparam.h instead, since it declares them.
3816 * cm.h (PC): Remove extern decl; tparam.h now does this.
3817 * deps.mk (cm.o, terminfo.o): Depend on tparam.h.
3818 * terminfo.c: Include tparam.h, to check interfaces.
3819 (tparm): Make 1st arg a const pointer in decl. Put it at top level.
3820 (tparam): Adjust signature to match interface in tparam.h;
3821 this removes some undefined behavior. Check that outstring and len
3822 are zero, which they always are with Emacs.
3823 * tparam.h (PC, BC, UP): New extern decls.
3825 * xftfont.c (xftfont_shape): Now static, and defined only if needed.
3826 (xftfont_open): Rename locals to avoid shadowing.
3828 * ftfont.c (ftfont_resolve_generic_family): Fix pointer signedness.
3829 (ftfont_otf_capability, ftfont_shape): Omit decls if not needed.
3830 (OTF_TAG_SYM): Omit macro if not needed.
3831 (ftfont_list): Remove unused local.
3832 (get_adstyle_property, ftfont_pattern_entity):
3833 (ftfont_lookup_cache, ftfont_open, ftfont_anchor_point):
3834 Rename locals to avoid shadowing.
3836 * xfont.c (xfont_list_family): Mark var as initialized.
3838 * xml.c (make_dom): Now static.
3840 * composite.c (composition_compute_stop_pos): Rename local to
3842 (composition_reseat_it): Remove unused locals.
3843 (find_automatic_composition, composition_adjust_point): Likewise.
3844 (composition_update_it): Mark var as initialized.
3845 (find_automatic_composition): Mark vars as initialized,
3846 with a FIXME (Bug#8290).
3848 character.h: Rename locals to avoid shadowing.
3849 * character.h (PREV_CHAR_BOUNDARY, FETCH_STRING_CHAR_ADVANCE):
3850 (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE, FETCH_CHAR_ADVANCE):
3851 (FETCH_CHAR_ADVANCE_NO_CHECK, INC_POS, DEC_POS, BUF_INC_POS):
3852 (BUF_DEC_POS): Be more systematic about renaming local temporaries
3855 * textprop.c (property_change_between_p): Remove; unused.
3857 * intervals.c (interval_start_pos): Now static.
3859 * intervals.h (CHECK_TOTAL_LENGTH): Avoid empty "else".
3861 * atimer.c (start_atimer, append_atimer_lists, set_alarm):
3862 Rename locals to avoid shadowing.
3864 * sound.c (wav_play, au_play, Fplay_sound_internal):
3865 Fix pointer signedness.
3866 (alsa_choose_format): Remove unused local var.
3867 (wav_play): Initialize a variable to 0, to prevent undefined
3868 behavior (Bug#8278).
3870 * region-cache.c (insert_cache_boundary): Redo var to avoid shadowing.
3872 * region-cache.h (pp_cache): New decl, for gcc -Wmissing-prototypes.
3874 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork
3875 clobbering (Bug#8298).
3876 * sysdep.c (sys_subshell): Likewise.
3877 Previously, the sys_subshell 'volatile' was incorrectly IF_LINTted out.
3879 * lisp.h (child_setup): Now NO_RETURN unless DOS_NT.
3880 This should get cleaned up, so that child_setup has the
3881 same signature on all platforms.
3883 * callproc.c (call_process_cleanup): Now static.
3884 (relocate_fd): Rename locals to avoid shadowing.
3886 2011-03-22 Chong Yidong <cyd@stupidchicken.com>
3888 * xterm.c (x_clear_frame): Remove XClearWindow call. This appears
3889 not to be necessary, and produces flickering.
3891 2011-03-20 Glenn Morris <rgm@gnu.org>
3893 * config.in: Remove file.
3895 2011-03-20 Juanma Barranquero <lekktu@gmail.com>
3897 * minibuf.c (Vcompleting_read_function): Don't declare, global variables
3898 are now in src/globals.h.
3899 (syms_of_minibuf): Remove spurious & from previous change.
3901 2011-03-20 Leo <sdl.web@gmail.com>
3903 * minibuf.c (completing-read-function): New variable.
3904 (completing-read-default): Rename from completing-read.
3905 (completing-read): Call completing-read-function.
3907 2011-03-19 Juanma Barranquero <lekktu@gmail.com>
3909 * xfaces.c (Fx_load_color_file):
3910 Read color file from absolute filename (bug#8250).
3912 2011-03-19 Juanma Barranquero <lekktu@gmail.com>
3914 * makefile.w32-in: Update dependencies.
3916 2011-03-17 Eli Zaretskii <eliz@gnu.org>
3918 * makefile.w32-in ($(BLD)/unexw32.$(O)): Depend on $(SRC)/unexec.h.
3920 2011-03-17 Paul Eggert <eggert@cs.ucla.edu>
3922 Fix more problems found by GCC 4.5.2's static checks.
3924 * process.c (make_serial_process_unwind, send_process_trap):
3925 (sigchld_handler): Now static.
3927 * process.c (allocate_pty): Let PTY_ITERATION declare iteration vars.
3928 That way, the code declares only the vars that it needs.
3929 * s/aix4-2.h (PTY_ITERATION): Declare iteration vars.
3930 * s/cygwin.h (PTY_ITERATION): Likewise.
3931 * s/darwin.h (PTY_ITERATION): Likewise.
3932 * s/gnu-linux.h (PTY_ITERATION): Likewise.
3934 * s/irix6-5.h (PTY_OPEN): Declare stb, to loosen coupling.
3935 * process.c (allocate_pty): Don't declare stb unless it's needed.
3937 * bytecode.c (MAYBE_GC): Rewrite so as not to use empty "else".
3938 (CONSTANTLIM): Remove; unused.
3939 (METER_CODE, Bscan_buffer, Bread_char, Bset_mark):
3940 Define only if needed.
3942 * unexelf.c (unexec): Name an expression,
3943 to avoid gcc -Wbad-function-cast warning.
3944 Use a different way to cause a compilation error if anyone uses
3945 n rather than nn, a way that does not involve shadowing.
3946 (ELF_BSS_SECTION_NAME, OLD_PROGRAM_H): Remove; unused.
3948 * deps.mk (unexalpha.o): Remove; unused.
3950 New file unexec.h, the (simple) interface for unexec (Bug#8267).
3951 * unexec.h: New file.
3952 * deps.mk (emacs.o, unexaix.o, unexcw.o, unexcoff.o, unexelf.o):
3953 (unexhp9k800.o, unexmacosx.o, unexsol.o, unexw32.o):
3955 * emacs.c [!defined CANNOT_DUMP]: Include unexec.h.
3956 * unexaix.c, unexcoff.c, unexcw.c, unexelf.c, unexhp9k800.c:
3957 * unexmacosx.c, unexsol.c, unexw32.c: Include unexec.h.
3958 Change as necessary to match prototype in unexec.h.
3960 * syntax.c (Fforward_comment, scan_lists): Rename locals to avoid
3962 (back_comment, skip_chars): Mark vars as initialized.
3964 * character.h (FETCH_STRING_CHAR_ADVANCE_NO_CHECK, BUF_INC_POS):
3965 Rename locals to avoid shadowing.
3967 * lread.c (read1): Rewrite so as not to use empty "else".
3968 (Fload, readevalloop, read1): Rename locals to avoid shadowing.
3970 * print.c (Fredirect_debugging_output): Fix pointer signedess.
3972 * lisp.h (debug_output_compilation_hack): Add decl here, to avoid
3973 warning when compiling print.c.
3975 * font.c (font_unparse_fcname): Abort in an "impossible" situation
3976 instead of using an uninitialized var.
3977 (font_sort_entities): Mark var as initialized.
3979 * character.h (FETCH_CHAR_ADVANCE): Rename locals to avoid shadowing.
3981 * font.c (font_unparse_xlfd): Don't mix pointers to variables with
3982 pointers to constants.
3983 (font_parse_fcname): Remove unused vars.
3984 (font_delete_unmatched): Now static.
3985 (font_get_spec): Remove; unused.
3986 (font_style_to_value, font_prop_validate_style, font_unparse_fcname):
3987 (font_update_drivers, Ffont_get_glyphs, font_add_log):
3988 Rename or move locals to avoid shadowing.
3990 * fns.c (require_nesting_list, require_unwind): Now static.
3991 (Ffillarray): Rename locals to avoid shadowing.
3993 * floatfns.c (domain_error2): Define only if needed.
3994 (Ffrexp, Fldexp): Rename locals to avoid shadowing.
3996 * alloc.c (mark_backtrace): Move decl from here ...
3997 * lisp.h: ... to here, so that it can be checked.
3999 * eval.c (call_debugger, do_debug_on_call, grow_specpdl): Now static.
4000 (Fdefvar): Rewrite so as not to use empty "else".
4001 (lisp_indirect_variable): Name an expression,
4002 to avoid gcc -Wbad-function-cast warning.
4003 (Fdefvar): Rename locals to avoid shadowing.
4005 * callint.c (quotify_arg, quotify_args): Now static.
4006 (Fcall_interactively): Rename locals to avoid shadowing.
4007 Use const pointer when appropriate.
4009 * lisp.h (get_system_name, get_operating_system_release):
4010 Move decls here, to check interfaces.
4011 * process.c (get_operating_system_release): Move decl to lisp.h.
4012 * xrdb.c (get_system_name): Likewise.
4013 * editfns.c (init_editfns, Fuser_login_name, Fuser_uid):
4014 (Fuser_real_uid, Fuser_full_name): Remove unnecessary casts,
4015 some of which prompt warnings from gcc -Wbad-function-cast.
4016 (Fformat_time_string, Fencode_time, Finsert_char):
4017 (Ftranslate_region_internal, Fformat):
4018 Rename or remove local vars to avoid shadowing.
4019 (Ftranslate_region_internal): Mark var as initialized.
4021 * doc.c (Fdocumentation, Fsnarf_documentation): Move locals to
4024 * lisp.h (eassert): Check that the argument compiles, even if
4025 ENABLE_CHECKING is not defined.
4027 * data.c (Findirect_variable): Name an expression, to avoid
4028 gcc -Wbad-function-cast warning.
4029 (default_value, arithcompare, arith_driver, arith_error): Now static.
4030 (store_symval_forwarding): Rename local to avoid shadowing.
4031 (Fmake_variable_buffer_local, Fmake_local_variable):
4032 Mark variables as initialized.
4033 (do_blv_forwarding, do_symval_forwarding): Remove; unused.
4035 * alloc.c (check_cons_list): Do not define unless GC_CHECK_CONS_LIST.
4036 (Fmake_vector, Fvector, Fmake_byte_code, Fgarbage_collect):
4037 Rename locals to avoid shadowing.
4038 (mark_stack): Move local variables into the #ifdef region where
4040 (BLOCK_INPUT_ALLOC, UNBLOCK_INPUT_ALLOC): Define only if
4041 ! defined SYSTEM_MALLOC && ! defined SYNC_INPUT, as they are not
4043 (CHECK_ALLOCATED): Define only if GC_CHECK_MARKED_OBJECTS.
4044 (GC_STRING_CHARS): Remove; not used.
4045 (Fmemory_limit): Cast sbrk's returned value to char *.
4047 * lisp.h (check_cons_list): Declare if GC_CHECK_CONS_LIST; this
4048 avoids undefined behavior in theory.
4050 * regex.c (IF_LINT): Add defn, for benefit of ../lib-src.
4052 Use functions, not macros, for up- and down-casing (Bug#8254).
4053 * buffer.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
4054 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Remove. All callers changed
4055 to use the following functions instead of these macros.
4056 (downcase): Adjust to lack of DOWNCASE_TABLE. Return int, not
4057 EMACS_INT, since callers assume the returned value fits in int.
4058 (upcase1): Likewise, for UPCASE_TABLE.
4059 (uppercasep, lowercasep, upcase): New static inline functions.
4060 * editfns.c (Fchar_equal): Remove no-longer-needed workaround for
4061 the race-condition problem in the old DOWNCASE.
4063 * regex.c (CHARSET_LOOKUP_RANGE_TABLE_RAW, POP_FAILURE_REG_OR_COUNT):
4064 Rename locals to avoid shadowing.
4065 (regex_compile, re_match_2_internal): Move locals to avoid shadowing.
4066 (regex_compile, re_search_2, re_match_2_internal):
4067 Remove unused local vars.
4068 (FREE_VAR): Rewrite so as not to use empty "else",
4069 which gcc can warn about.
4070 (regex_compile, re_match_2_internal): Mark locals as initialized.
4071 (RETALLOC_IF): Define only if needed.
4072 (WORDCHAR_P): Likewise. This one is never needed, but is used
4073 only in a comment talking about a compiler bug, so put inside
4074 the #if 0 of that comment.
4075 (CHARSET_LOOKUP_BITMAP, FAIL_STACK_FULL, RESET_FAIL_STACK):
4076 (PUSH_FAILURE_ELT, BUF_PUSH_3, STOP_ADDR_VSTRING):
4079 * search.c (boyer_moore): Rename locals to avoid shadowing.
4080 * character.h (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE):
4081 (PREV_CHAR_BOUNDARY): Likewise.
4083 * search.c (simple_search): Remove unused var.
4085 * dired.c (compile_pattern): Move decl from here ...
4086 * lisp.h: ... to here, so that it can be checked.
4087 (struct re_registers): New forward decl.
4089 * character.h (INC_POS, DEC_POS): Rename locals to avoid shadowing.
4091 * indent.c (MULTIBYTE_BYTES_WIDTH): New args bytes, width.
4093 (MULTIBYTE_BYTES_WIDTH, scan_for_column, compute_motion):
4094 Rename locals to avoid shadowing.
4095 (Fvertical_motion): Mark locals as initialized.
4097 * casefiddle.c (casify_object, casify_region): Now static.
4098 (casify_region): Mark local as initialized.
4100 * cmds.c (internal_self_insert): Rename local to avoid shadowing.
4102 * lisp.h (GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR, GCPRO5_VAR, GCPRO6_VAR):
4103 New macros, so that the caller can use some names other than
4104 gcpro1, gcpro2, etc.
4105 (GCPRO2, GCPRO3, GCPRO4, GCPRO5, GCPRO6): Reimplement in terms
4107 (GCPRO1_VAR, UNGCPRO_VAR): Change the meaning of the second
4108 argument, for consistency with GCPRO2_VAR, etc: it is now the
4109 prefix of the variable, not the variable itself. All uses
4111 * dired.c (directory_files_internal, file_name_completion):
4112 Rename locals to avoid shadowing.
4114 Fix a race condition diagnosed by gcc -Wsequence-point (Bug#8254).
4115 An expression of the form (DOWNCASE (x) == DOWNCASE (y)), found in
4116 dired.c's scmp function, had undefined behavior.
4117 * lisp.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
4118 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Move from here ...
4119 * buffer.h: ... to here, because these macros use current_buffer,
4120 and the new implementation with inline functions needs to have
4121 current_buffer in scope now, rather than later when the macros
4123 (downcase, upcase1): New static inline functions.
4124 (DOWNCASE, UPCASE1): Reimplement using these functions.
4125 This avoids undefined behavior in expressions like
4126 DOWNCASE (x) == DOWNCASE (y), which previously suffered
4127 from race conditions in accessing the global variables
4128 case_temp1 and case_temp2.
4129 * casetab.c (case_temp1, case_temp2): Remove; no longer needed.
4130 * lisp.h (case_temp1, case_temp2): Remove their decls.
4131 * character.h (ASCII_CHAR_P): Move from here ...
4132 * lisp.h: ... to here, so that the inline functions mentioned
4135 * dired.c (directory_files_internal_unwind): Now static.
4137 * fileio.c (file_name_as_directory, directory_file_name):
4138 (barf_or_query_if_file_exists, auto_save_error, auto_save_1):
4140 (file_name_as_directory): Use const pointers when appropriate.
4141 (Fexpand_file_name): Likewise. In particular, newdir might
4142 point at constant storage, so make it a const pointer.
4143 (Fmake_directory_internal, Fread_file_name): Remove unused vars.
4144 (Ffile_selinux_context, Fset_file_selinux_context): Fix pointer
4146 (Fset_file_times, Finsert_file_contents, auto_save_error):
4147 Rename locals to avoid shadowing.
4149 * minibuf.c (choose_minibuf_frame_1): Now static.
4150 (Ftry_completion, Fall_completions): Rename or remove locals
4153 * marker.c (bytepos_to_charpos): Remove; unused.
4155 * lisp.h (verify_bytepos, count_markers): New decls,
4156 so that gcc does not warn that these functions aren't declared.
4158 * insdel.c (check_markers, make_gap_larger, make_gap_smaller):
4159 (reset_var_on_error, Fcombine_after_change_execute_1): Now static.
4160 (CHECK_MARKERS): Redo to avoid gcc -Wempty-body diagnostic.
4161 (copy_text): Remove unused local var.
4163 * filelock.c (within_one_second): Now static.
4164 (lock_file_1): Rename local to avoid shadowing.
4166 * buffer.c (fix_overlays_before): Mark locals as initialized.
4167 (fix_start_end_in_overlays): Likewise. This function should be
4168 simplified by using pointers-to-pointers, but that's a different
4170 (switch_to_buffer_1): Now static.
4171 (Fkill_buffer, record_buffer, Fbury_buffer, Fset_buffer_multibyte):
4172 (report_overlay_modification): Rename locals to avoid shadowing.
4174 * sysdep.c (system_process_attributes): Rename vars to avoid shadowing.
4175 Fix pointer signedness issue.
4176 (sys_subshell): Mark local as volatile if checking for lint,
4177 to suppress a gcc -Wclobbered warning that does not seem to be right.
4178 (MAXPATHLEN): Define only if needed.
4180 * process.c (serial_open, serial_configure): Move decls from here ...
4181 * systty.h: ... to here, so that they can be checked.
4183 * fns.c (get_random, seed_random): Move extern decls from here ...
4184 * lisp.h: ... to here, so that they can be checked.
4186 * sysdep.c (reset_io): Now static.
4187 (wait_for_termination_signal): Remove; unused.
4189 * keymap.c (keymap_parent, keymap_memberp, map_keymap_internal):
4190 (copy_keymap_item, append_key, push_text_char_description):
4192 (Fwhere_is_internal): Don't test CONSP (sequences) unnecessarily.
4193 (DENSE_TABLE_SIZE): Remove; unused.
4194 (get_keymap, access_keymap, Fdefine_key, Fwhere_is_internal):
4195 (describe_map_tree):
4196 Rename locals to avoid shadowing.
4198 * keyboard.c: Declare functions static if they are not used elsewhere.
4199 (echo_char, echo_dash, cmd_error, top_level_2):
4200 (poll_for_input, handle_async_input): Now static.
4201 (read_char, kbd_buffer_get_event, make_lispy_position):
4202 (make_lispy_event, make_lispy_movement, apply_modifiers):
4203 (decode_keyboard_code, tty_read_avail_input, menu_bar_items):
4204 (parse_tool_bar_item, read_key_sequence, Fread_key_sequence):
4205 (Fread_key_sequence_vector): Rename locals to avoid shadowing.
4206 (read_key_sequence, read_char): Mark locals as initialized.
4207 (Fexit_recursive_edit, Fabort_recursive_edit): Mark with NO_RETURN.
4209 * keyboard.h (make_ctrl_char): New decl.
4210 (mark_kboards): Move decl here ...
4211 * alloc.c (mark_kboards): ... from here.
4213 * lisp.h (force_auto_save_soon): New decl.
4215 * emacs.c (init_cmdargs): Rename local to avoid shadowing.
4216 (DEFINE_DUMMY_FUNCTION): New macro.
4217 (__do_global_ctors, __do_global_ctors_aux, __do_global_dtors, __main):
4219 (main): Add casts to avoid warnings
4220 if GCC considers string literals to be constants.
4222 * lisp.h (fatal_error_signal): Add decl, since it's exported.
4224 * dbusbind.c: Pointer signedness fixes.
4225 (xd_signature, xd_append_arg, xd_initialize):
4226 (Fdbus_call_method, Fdbus_call_method_asynchronously):
4227 (Fdbus_method_return_internal, Fdbus_method_error_internal):
4228 (Fdbus_send_signal, xd_read_message_1, Fdbus_register_service):
4229 (Fdbus_register_signal): Use SSDATA when the context wants char *.
4231 * dbusbind.c (Fdbus_init_bus): Add cast to avoid warning
4232 if GCC considers string literals to be constants.
4233 (Fdbus_register_service, Fdbus_register_method): Remove unused vars.
4235 2011-03-16 Stefan Monnier <monnier@iro.umontreal.ca>
4237 * print.c (PRINT_CIRCLE_CANDIDATE_P): New macro.
4238 (print_preprocess, print_object): New macro to fix last change.
4240 * print.c (print_preprocess): Don't forget font objects.
4242 2011-03-16 Juanma Barranquero <lekktu@gmail.com>
4244 * emacs.c (USAGE3): Doc fixes.
4246 2011-03-15 Andreas Schwab <schwab@linux-m68k.org>
4248 * coding.c (detect_coding_iso_2022): Reorganize code to clarify
4251 2011-03-14 Juanma Barranquero <lekktu@gmail.com>
4253 * lisp.h (VWindow_system, Qfile_name_history):
4254 * keyboard.h (lispy_function_keys) [WINDOWSNT]:
4255 * w32term.h (w32_system_caret_hwnd, w32_system_caret_height)
4256 (w32_system_caret_x, w32_system_caret_y): Declare extern.
4258 * w32select.c: Don't #include "keyboard.h".
4259 (run_protected): Add extern declaration for waiting_for_input.
4261 * w32.c (Qlocal, noninteractive1, inhibit_window_system):
4262 * w32console.c (detect_input_pending, read_input_pending)
4263 (encode_terminal_code):
4264 * w32fns.c (quit_char, lispy_function_keys, Qtooltip)
4265 (w32_system_caret_hwnd, w32_system_caret_height, w32_system_caret_x)
4266 (w32_system_caret_y, Qfile_name_history):
4267 * w32font.c (w32font_driver, QCantialias, QCotf, QClang):
4268 * w32inevt.c (reinvoke_input_signal, lispy_function_keys):
4269 * w32menu.c (Qmenu_bar, QCtoggle, QCradio, Qoverriding_local_map)
4270 (Qoverriding_terminal_local_map, Qmenu_bar_update_hook):
4271 * w32proc.c (Qlocal, report_file_error):
4272 * w32term.c (Vwindow_system, updating_frame):
4273 * w32uniscribe.c (initialized, uniscribe_font_driver):
4274 Remove unneeded extern declarations.
4276 2011-03-14 Chong Yidong <cyd@stupidchicken.com>
4278 * buffer.c (Fmake_indirect_buffer): Fix incorrect assertions.
4280 2011-03-13 Chong Yidong <cyd@stupidchicken.com>
4282 * buffer.h (BUF_BEGV, BUF_BEGV_BYTE, BUF_ZV, BUF_ZV_BYTE, BUF_PT)
4283 (BUF_PT_BYTE): Rewrite to handle indirect buffers (Bug#8219).
4284 These macros can no longer be used for assignment.
4286 * buffer.c (Fget_buffer_create, Fmake_indirect_buffer):
4287 Assign struct members directly, instead of using BUF_BEGV etc.
4288 (record_buffer_markers, fetch_buffer_markers): New functions for
4289 recording and fetching special buffer markers.
4290 (set_buffer_internal_1, set_buffer_temp): Use them.
4292 * lread.c (unreadchar): Use SET_BUF_PT_BOTH.
4294 * insdel.c (adjust_point): Use SET_BUF_PT_BOTH.
4296 * intervals.c (temp_set_point_both): Use SET_BUF_PT_BOTH.
4297 (get_local_map): Use SET_BUF_BEGV_BOTH and SET_BUF_ZV_BOTH.
4299 * xdisp.c (hscroll_window_tree):
4300 (reconsider_clip_changes): Use PT instead of BUF_PT.
4302 2011-03-13 Eli Zaretskii <eliz@gnu.org>
4304 * makefile.w32-in ($(BLD)/editfns.$(O)): Depend on
4305 $(EMACS_ROOT)/lib/intprops.h.
4307 2011-03-13 Paul Eggert <eggert@cs.ucla.edu>
4309 Fix more problems found by GCC 4.5.2's static checks.
4311 * gtkutil.c (xg_get_pixbuf_from_pixmap): Add cast from char *
4312 to unsigned char * to avoid compiler diagnostic.
4313 (xg_free_frame_widgets): Make it clear that a local variable is
4314 needed only if USE_GTK_TOOLTIP.
4315 (gdk_window_get_screen): Make it clear that this macro is needed
4316 only if USE_GTK_TOOLTIP.
4317 (int_gtk_range_get_value): New function, which avoids a diagnostic
4318 from gcc -Wbad-function-cast.
4319 (xg_set_toolkit_scroll_bar_thumb): Use it.
4320 (xg_tool_bar_callback, xg_tool_item_stale_p): Rewrite to avoid
4321 diagnostic from gcc -Wbad-function-cast.
4322 (get_utf8_string, xg_get_file_with_chooser):
4323 Rename locals to avoid shadowing.
4324 (create_dialog): Move locals to avoid shadowing.
4326 * xgselect.c (xg_select): Remove unused var.
4328 * image.c (four_corners_best): Mark locals as initialized.
4329 (gif_load): Initialize transparent_p to zero (Bug#8238).
4330 Mark another local as initialized.
4331 (my_png_error, my_error_exit): Mark with NO_RETURN.
4333 * image.c (clear_image_cache): Now static.
4334 (DIM, HAVE_STDLIB_H_1): Remove unused macros.
4335 (xpm_load): Redo to avoid "discards qualifiers" gcc warning.
4336 (x_edge_detection): Remove unnecessary cast that
4337 gcc -Wbad-function-cast diagnoses.
4338 (gif_load): Fix pointer signedness.
4339 (clear_image_cache, xbm_read_bitmap_data, x_detect_edges):
4340 (jpeg_load, gif_load): Rename locals to avoid shadowing.
4342 2011-03-12 Paul Eggert <eggert@cs.ucla.edu>
4344 Improve quality of tests for time stamp overflow.
4345 For example, without this patch (encode-time 0 0 0 1 1
4346 1152921504606846976) returns the obviously-bogus value (-948597
4347 62170) on my RHEL 5.5 x86-64 host. With the patch, it correctly
4348 reports time overflow. See
4349 <http://lists.gnu.org/archive/html/emacs-devel/2011-03/msg00470.html>.
4350 * deps.mk (editfns.o): Depend on ../lib/intprops.h.
4351 * editfns.c: Include limits.h and intprops.h.
4352 (TIME_T_MIN, TIME_T_MAX): New macros.
4353 (time_overflow): Move earlier, to before first use.
4354 (hi_time, lo_time): New functions, for an accurate test for
4356 (Fcurrent_time, Fget_internal_run_time, make_time): Use them.
4357 (Fget_internal_run_time): Don't assume time_t fits in int.
4358 (make_time): Use list2 instead of Fcons twice.
4359 (Fdecode_time): More accurate test for out-of-range times.
4360 (check_tm_member): New function.
4361 (Fencode_time): Use it, to test for out-of-range times.
4362 (lisp_time_argument): Don't rely on undefined left-shift and
4363 right-shift behavior when checking for time stamp overflow.
4365 * editfns.c (time_overflow): New function, refactoring common code.
4366 (Fformat_time_string, Fdecode_time, Fencode_time):
4367 (Fcurrent_time_string): Use it.
4369 Move 'make_time' to be next to its inverse 'lisp_time_argument'.
4370 * dired.c (make_time): Move to ...
4371 * editfns.c (make_time): ... here.
4372 * systime.h: Note the move.
4374 2011-03-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
4376 * fringe.c (update_window_fringes): Remove unused variables.
4378 * unexmacosx.c (copy_data_segment): Also copy __got section.
4381 2011-03-12 Eli Zaretskii <eliz@gnu.org>
4383 * termcap.c [MSDOS]: Include "msdos.h".
4384 (find_capability, tgetnum, tgetflag, tgetstr, tputs, tgetent):
4385 Constify `char *' arguments and their references according to
4386 prototypes in tparam.h.
4388 * deps.mk (termcap.o): Depend on tparam.h and msdos.h.
4390 * msdos.c (XMenuAddPane): 3rd argument is `const char *' now.
4391 Adapt all references accordingly.
4393 * msdos.h (XMenuAddPane): 3rd argument is `const char *' now.
4395 2011-03-11 Tom Tromey <tromey@redhat.com>
4397 * buffer.c (syms_of_buffer): Remove obsolete comment.
4399 2011-03-11 Eli Zaretskii <eliz@gnu.org>
4401 * termhooks.h (encode_terminal_code): Declare prototype.
4403 * msdos.c (encode_terminal_code): Don't declare prototype.
4405 * term.c (encode_terminal_code): Now external again, used by
4406 w32console.c and msdos.c.
4408 * makefile.w32-in ($(BLD)/term.$(O), ($(BLD)/tparam.$(O)):
4409 Depend on $(SRC)/tparam.h, see 2011-03-11T07:24:21Z!eggert@cs.ucla.edu.
4411 2011-03-11 Paul Eggert <eggert@cs.ucla.edu>
4413 Fix some minor problems found by GCC 4.5.2's static checks.
4415 * fringe.c (update_window_fringes): Mark locals as initialized
4417 (destroy_fringe_bitmap, init_fringe_bitmap): Now static.
4419 * alloc.c (mark_fringe_data): Move decl from here ...
4420 * lisp.h (mark_fringe_data) [HAVE_WINDOW_SYSTEM]: ... to here,
4421 to check its interface.
4422 (init_fringe_once): Do not declare unless HAVE_WINDOW_SYSTEM.
4424 * fontset.c (free_realized_fontset): Now static.
4425 (Fset_fontset_font): Rename local to avoid shadowing.
4426 (fontset_font): Mark local as initialized.
4427 (FONTSET_SPEC, FONTSET_REPERTORY, RFONT_DEF_REPERTORY): Remove; unused.
4429 * xrdb.c: Include "xterm.h", to check x_load_resources's interface.
4431 * xselect.c (x_disown_buffer_selections): Remove; not used.
4432 (TRACE3) [!defined TRACE_SELECTION]: Remove; not used.
4433 (x_own_selection, Fx_disown_selection_internal): Rename locals
4435 (x_handle_dnd_message): Remove local to avoid shadowing.
4437 * lisp.h (GCPRO1_VAR, UNGCPRO_VAR): New macros,
4438 so that the caller can use some name other than gcpro1.
4439 (GCPRO1, UNGCPRO): Reimplement in terms of the new macros.
4440 * xfns.c (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
4441 (Fx_backspace_delete_keys_p):
4442 Use them to avoid shadowing, and rename vars to avoid shadowing.
4443 (x_decode_color, x_set_name, x_window): Now static.
4444 (Fx_create_frame): Add braces to silence GCC warning.
4445 (Fx_file_dialog, Fx_select_font): Fix pointer signedness.
4446 (x_real_positions, xg_set_icon_from_xpm_data, x_create_tip_frame):
4447 Remove unused locals.
4448 (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
4449 (Fx_backspace_delete_keys_p): Rename locals to avoid shadowing.
4450 Some of these renamings use the new GCPRO1_VAR and UNGCPRO_VAR
4453 * xterm.h (x_mouse_leave): New decl.
4455 * xterm.c (x_copy_dpy_color, x_focus_on_frame, x_unfocus_frame):
4456 Remove unused functions.
4457 (x_shift_glyphs_for_insert, XTflash, XTring_bell):
4458 (x_calc_absolute_position): Now static.
4459 (XTread_socket): Don't define label "out" unless it's used.
4460 Don't declare local "event" unless it's used.
4461 (x_iconify_frame, x_free_frame_resources): Don't declare locals
4462 unless they are used.
4463 (XEMBED_VERSION, xembed_set_info): Don't define unless needed.
4464 (x_fatal_error_signal): Remove; not used.
4465 (x_draw_image_foreground, redo_mouse_highlight, XTmouse_position):
4466 (x_scroll_bar_report_motion, handle_one_xevent, x_draw_bar_cursor):
4467 (x_error_catcher, x_connection_closed, x_error_handler):
4468 (x_error_quitter, xembed_send_message, x_iconify_frame):
4469 (my_log_handler): Rename locals to avoid shadowing.
4470 (x_delete_glyphs, x_ins_del_lines): Mark with NO_RETURN.
4471 (x_connection_closed): Tell GCC not to suggest NO_RETURN.
4473 * xfaces.c (clear_face_cache, Fx_list_fonts, Fface_font):
4474 Rename or move locals to avoid shadowing.
4475 (tty_defined_color, merge_face_heights): Now static.
4476 (free_realized_faces_for_fontset): Remove; not used.
4477 (Fx_list_fonts): Mark variable that gcc -Wuninitialized
4478 does not deduce is never used uninitialized.
4479 (STRDUPA, LSTRDUPA, FONT_POINT_SIZE_QUANTUM): Remove; not used.
4480 (LFACEP): Define only if XASSERTS, as it's not needed otherwise.
4482 * terminal.c (store_terminal_param): Now static.
4484 * xmenu.c (menu_highlight_callback): Now static.
4485 (set_frame_menubar): Remove unused local.
4486 (xmenu_show): Rename parameter to avoid shadowing.
4487 (xmenu_show, xdialog_show, xmenu_show): Make local pointers "const"
4488 since they might point to immutable storage.
4489 (next_menubar_widget_id): Declare only if USE_X_TOOLKIT,
4490 since it's unused otherwise.
4492 * xdisp.c (produce_glyphless_glyph): Initialize lower_xoff.
4493 Add a FIXME, since the code still doesn't look right. (Bug#8215)
4494 (Fcurrent_bidi_paragraph_direction): Simplify slightly; this
4495 avoids a gcc -Wuninitialized diagnostic.
4496 (display_line, BUILD_COMPOSITE_GLYPH_STRING, draw_glyphs):
4497 (note_mouse_highlight): Mark variables that gcc -Wuninitialized
4498 does not deduce are never used uninitialized.
4500 * lisp.h (IF_LINT): New macro, copied from ../lib-src/emacsclient.c.
4502 * xdisp.c (redisplay_window): Rename local to avoid shadowing.
4503 * window.c (window_loop, size_window):
4504 (run_window_configuration_change_hook, enlarge_window): Likewise.
4506 * window.c (display_buffer): Now static.
4507 (size_window): Mark variables that gcc -Wuninitialized
4508 does not deduce are never used uninitialized.
4509 * window.h (check_all_windows): New decl, to forestall
4510 gcc -Wmissing-prototypes diagnostic.
4511 * dispextern.h (bidi_dump_cached_states): Likewise.
4513 * charset.h (CHECK_CHARSET_GET_CHARSET): Rename locals to avoid
4515 * charset.c (map_charset_for_dump, Fchar_charset): Likewise.
4517 (Fsort_charsets): Redo min/max calculation to shorten the code a bit
4518 and to avoid gcc -Wuninitialized warning.
4519 (load_charset_map): Mark variables that gcc -Wuninitialized
4520 does not deduce are never used uninitialized.
4521 (load_charset): Abort instead of using uninitialized var (Bug#8229).
4523 * coding.c (coding_set_source, coding_set_destination):
4524 Use "else { /* comment */ }" rather than "else /* comment */;"
4525 for clarity, and to avoid gcc -Wempty-body warning.
4526 (Fdefine_coding_system_internal): Don't redeclare 'i' inside
4527 a block, when the outer 'i' will do.
4528 (decode_coding_utf_8, decode_coding_utf_16, detect_coding_emacs_mule):
4529 (emacs_mule_char, decode_coding_emacs_mule, detect_coding_iso_2022):
4530 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5):
4531 (decode_coding_raw_text, decode_coding_charset, get_translation_table):
4532 (Fdecode_sjis_char, Fdefine_coding_system_internal):
4533 Rename locals to avoid shadowing.
4534 * character.h (FETCH_STRING_CHAR_ADVANCE): Likewise.
4535 * coding.c (emacs_mule_char, encode_invocation_designation):
4536 Now static, since they're not used elsewhere.
4537 (decode_coding_iso_2022): Add "default: abort ();" as a safety check.
4538 (decode_coding_object, encode_coding_object, detect_coding_system):
4539 (decode_coding_emacs_mule): Mark variables that gcc
4540 -Wuninitialized does not deduce are never used uninitialized.
4541 (detect_coding_iso_2022): Initialize a local variable that might
4542 be used uninitialized. Leave a FIXME because it's not clear that
4543 this initialization is needed. (Bug#8211)
4544 (ISO_CODE_LF, ISO_CODE_CR, CODING_ISO_FLAG_EUC_TW_SHIFT):
4545 (ONE_MORE_BYTE_NO_CHECK, UTF_BOM, UTF_16_INVALID_P):
4546 (SHIFT_OUT_OK, ENCODE_CONTROL_SEQUENCE_INTRODUCER):
4547 (ENCODE_DIRECTION_R2L, ENCODE_DIRECTION_L2R):
4548 Remove unused macros.
4550 * category.c (hash_get_category_set): Remove unused local var.
4551 (copy_category_table): Now static, since it's not used elsewhere.
4552 * character.c (string_count_byte8): Likewise.
4554 * ccl.c (CCL_WRITE_STRING, CCL_ENCODE_CHAR, Fccl_execute_on_string):
4555 (Fregister_code_conversion_map): Rename locals to avoid shadowing.
4557 * chartab.c (copy_sub_char_table): Now static, since it's not used
4559 (sub_char_table_ref_and_range, char_table_ref_and_range):
4560 Rename locals to avoid shadowing.
4561 (ASET_RANGE, GET_SUB_CHAR_TABLE): Remove unused macros.
4563 * bidi.c (bidi_check_type): Now static, since it's not used elsewhere.
4564 (BIDI_BOB): Remove unused macro.
4566 * cm.c (cmgoto): Mark variables that gcc -Wuninitialized does not
4567 deduce are never used uninitialized.
4568 * term.c (encode_terminal_code): Likewise.
4570 * term.c (encode_terminal_code): Now static. Remove unused local.
4572 * tparam.h: New file.
4573 * term.c, tparam.h: Include it.
4574 * deps.mk (term.o, tparam.o): Depend on tparam.h.
4575 * term.c (tputs, tgetent, tgetflag, tgetnum, tparam, tgetstr):
4576 Move these decls to tparam.h, and make them agree with what
4577 is actually in tparam.c. The previous trick of using incompatible
4578 decls in different modules does not conform to the C standard.
4579 All callers of tparam changed to use tparam's actual API.
4580 * tparam.c (tparam1, tparam, tgoto):
4581 Use const pointers where appropriate.
4583 * cm.c (calccost, cmgoto): Use const pointers where appropriate.
4584 * cm.h (struct cm): Likewise.
4585 * dispextern.h (do_line_insertion_deletion_costs): Likewise.
4586 * scroll.c (ins_del_costs, do_line_insertion_deletion_costs): Likewise.
4587 * term.c (tty_ins_del_lines, calculate_costs, struct fkey_table):
4588 (term_get_fkeys_1, append_glyphless_glyph, produce_glyphless_glyph):
4589 (turn_on_face, init_tty): Likewise.
4590 * termchar.h (struct tty_display_info): Likewise.
4592 * term.c (term_mouse_position): Rename local to avoid shadowing.
4594 * alloc.c (mark_ttys): Move decl from here ...
4595 * lisp.h (mark_ttys): ... to here, so that it's checked against defn.
4597 2011-03-11 Andreas Schwab <schwab@linux-m68k.org>
4599 * .gdbinit (pwinx, xbuffer): Fix access to buffer name.
4601 2011-03-09 Juanma Barranquero <lekktu@gmail.com>
4603 * search.c (compile_pattern_1): Remove argument regp, unused since
4604 revid:rms@gnu.org-19941211082627-3x1g1wyqkjmwloig.
4605 (compile_pattern): Don't pass it.
4607 2011-03-08 Jan Djärv <jan.h.d@swipnet.se>
4609 * xterm.h (DEFAULT_GDK_DISPLAY): New define.
4610 (GDK_WINDOW_XID, gtk_widget_get_preferred_size): New defines
4612 (GTK_WIDGET_TO_X_WIN): Use GDK_WINDOW_XID.
4614 * xmenu.c (menu_position_func): Call gtk_widget_get_preferred_size.
4616 * gtkutil.c: Include gtkx.h if HAVE_GTK3. If ! HAVE_GTK3, define
4617 gdk_window_get_screen, gdk_window_get_geometry,
4618 gdk_x11_window_lookup_for_display and GDK_KEY_g.
4619 (xg_set_screen): Use DEFAULT_GDK_DISPLAY.
4620 (xg_get_pixbuf_from_pixmap): New function.
4621 (xg_get_pixbuf_from_pix_and_mask): Change parameters from GdkPixmap
4622 to Pixmap, take frame as parameter, remove GdkColormap parameter.
4623 Call xg_get_pixbuf_from_pixmap instead of
4624 gdk_pixbuf_get_from_drawable.
4625 (xg_get_image_for_pixmap): Do not make GdkPixmaps, call
4626 xg_get_pixbuf_from_pix_and_mask with Pixmap parameters instead.
4627 (xg_check_special_colors): Use GtkStyleContext and its functions
4629 (xg_prepare_tooltip, xg_hide_tooltip): Call gdk_window_get_screen.
4630 (xg_prepare_tooltip, create_dialog, menubar_map_cb)
4631 (xg_update_frame_menubar, xg_tool_bar_detach_callback)
4632 (xg_tool_bar_attach_callback, xg_update_tool_bar_sizes):
4633 Call gtk_widget_get_preferred_size.
4634 (xg_frame_resized): gdk_window_get_geometry only takes 5
4636 (xg_win_to_widget, xg_event_is_for_menubar):
4637 Call gdk_x11_window_lookup_for_display.
4638 (xg_set_widget_bg): New function.
4639 (delete_cb): New function.
4640 (xg_create_frame_widgets): Connect delete-event to delete_cb.
4641 Call xg_set_widget_bg. Only set backgrund pixmap for ! HAVE_GTK3
4642 (xg_set_background_color): Call xg_set_widget_bg.
4643 (xg_set_frame_icon): Call xg_get_pixbuf_from_pix_and_mask.
4644 (xg_create_scroll_bar): vadj is a GtkAdjustment for HAVE_GTK3.
4645 Only call gtk_range_set_update_policy if ! HAVE_GTK3.
4646 (xg_make_tool_item): Only connect xg_tool_bar_item_expose_callback
4648 (update_frame_tool_bar): Call gtk_widget_hide.
4649 (xg_initialize): Use GDK_KEY_g.
4651 * xsmfns.c (gdk_set_sm_client_id): Define to gdk_set_sm_client_id
4653 (x_session_initialize): Call gdk_x11_set_sm_client_id.
4655 * xterm.c (XFillRectangle): Use cairo routines for HAVE_GTK3.
4656 (x_term_init): Disable Xinput(2) with GDK_CORE_DEVICE_EVENTS.
4657 Load ~/emacs.d/gtkrc only for ! HAVE_GTK3.
4659 2011-03-08 Juanma Barranquero <lekktu@gmail.com>
4661 * w32xfns.c (select_palette): Check success of RealizePalette against
4662 GDI_ERROR, not zero.
4664 See ChangeLog.11 for earlier changes.
4670 Copyright (C) 2011 Free Software Foundation, Inc.
4672 This file is part of GNU Emacs.
4674 GNU Emacs is free software: you can redistribute it and/or modify
4675 it under the terms of the GNU General Public License as published by
4676 the Free Software Foundation, either version 3 of the License, or
4677 (at your option) any later version.
4679 GNU Emacs is distributed in the hope that it will be useful,
4680 but WITHOUT ANY WARRANTY; without even the implied warranty of
4681 MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
4682 GNU General Public License for more details.
4684 You should have received a copy of the GNU General Public License
4685 along with GNU Emacs. If not, see <http://www.gnu.org/licenses/>.