1 2011-11-11 Johan Bockgård <bojohan@gnu.org>
3 * xdisp.c (fill_composite_glyph_string): Always set s->face, to
4 avoid a crash (bug#9496).
6 2011-11-09 Chong Yidong <cyd@gnu.org>
8 * window.c (Fwindow_inside_edges, Fwindow_inside_pixel_edges)
9 (Fwindow_inside_absolute_pixel_edges): Only allow live windows.
11 2011-11-08 Paul Eggert <eggert@cs.ucla.edu>
13 * s/gnu.h (GC_MARK_STACK): Define to GC_MAKE_GCPROS_NOOPS (Bug#9926).
15 2011-11-08 Paul Eggert <eggert@cs.ucla.edu>
17 Avoid some portability problems by eschewing 'extern inline' functions.
18 The trivial performance wins aren't worth the portability hassles; see
19 <http://lists.gnu.org/archive/html/emacs-devel/2011-11/msg00084.html>
21 * dispextern.h (window_box, window_box_height, window_text_bottom_y)
22 (window_box_width, window_box_left, window_box_left_offset)
23 (window_box_right, window_box_right_offset): Undo previous change,
24 by removing the "extern"s.
25 * intervals.c (adjust_intervals_for_insertion)
26 (adjust_intervals_for_deletion): Undo previous change,
27 making these static again.
28 (offset_intervals, temp_set_point_both, temp_set_point)
29 (copy_intervals_to_string): No longer inline.
30 * xdisp.c (window_text_bottom_y, window_box_width)
31 (window_box_height, window_box_left_offset)
32 (window_box_right_offset, window_box_left, window_box_right)
33 (window_box): No longer inline.
35 2011-11-08 Chong Yidong <cyd@gnu.org>
37 * window.c (Fwindow_left_column, Fwindow_top_line): Doc fix.
38 (Fwindow_body_height, Fwindow_body_width): Move from Lisp. Signal
39 an error if not a live window.
40 (Fwindow_total_width, Fwindow_total_height): Move from Lisp.
41 (Fwindow_total_size, Fwindow_body_size): Move to Lisp.
43 2011-11-07 Juanma Barranquero <lekktu@gmail.com>
45 * lisp.h (syms_of_abbrev): Remove declaration.
46 Reported by CHENG Gao <chenggao@royau.me>.
48 2011-11-07 Eli Zaretskii <eliz@gnu.org>
50 * w32.c (check_windows_init_file): Don't look for term/w32-win.el
51 if Vpurify_flag is non-nil. Fixes a crash when running w32 build
52 of temacs in GUI mode.
54 2011-11-07 Martin Rudalics <rudalics@gmx.at>
56 * window.h: Declare delete_all_child_windows instead of
57 delete_all_subwindows.
58 * window.c (Fwindow_nest, Fset_window_nest)
59 (Fset_window_new_total, Fset_window_new_normal)
60 (Fwindow_resize_apply): Don't use term subwindow in doc-strings.
61 (delete_all_subwindows): Rename to delete_all_child_windows.
62 (Fdelete_other_windows_internal, Fset_window_configuration):
63 Call delete_all_child_windows instead of delete_all_subwindows.
64 * frame.c (delete_frame): Call delete_all_child_windows instead
65 of delete_all_subwindows.
67 2011-11-07 Paul Eggert <eggert@cs.ucla.edu>
69 * alloc.c (DEADP): New macro, for porting to GNU/Hurd (Bug#9926).
70 This is also needed for porting to any host where GC_MARK_STACK is
71 not GC_MAKE_GCPROS_NOOPS.
72 (which_symbols): Use it.
74 2011-11-07 Kenichi Handa <handa@m17n.org>
76 * coding.c (coding_set_destination): Check coding->src_pos only
77 when coding->src_object is a buffer (bug#9910).
79 * process.c (send_process): Set the member src_multibyte of coding
80 to 0 (bug#9911) when sending a unibyte text.
82 * callproc.c (Fcall_process): Set the member src_multibyte of
83 process_coding to 0 (bug#9912).
85 2011-11-06 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
87 * xmenu.c (cleanup_widget_value_tree): New function.
88 (xmenu_show, xdialog_show): Use it in record_unwind_protect instead of
89 calling free_menubar_widget_value_tree directly (Bug#9830).
91 2011-11-06 Paul Eggert <eggert@cs.ucla.edu>
93 Fix some portability problems with 'inline'.
94 * dispextern.h (window_box, window_box_height, window_text_bottom_y)
95 (window_box_width, window_box_left, window_box_left_offset)
96 (window_box_right, window_box_right_offset): Declare extern.
97 Otherwise, these inline functions do not conform to C99 and
98 are miscompiled by Microsoft compilers. Reported by Eli Zaretskii in
99 <http://lists.gnu.org/archive/html/emacs-devel/2011-11/msg00084.html>.
100 * intervals.c (adjust_intervals_for_insertion)
101 (adjust_intervals_for_deletion): Now extern, because otherwise the
102 extern inline functions 'offset_intervals' couldn't refer to it.
103 (static_offset_intervals): Remove.
104 (offset_intervals): Rewrite using the old contents of
105 static_offset_intervals. The old version didn't conform to C99
106 because an extern inline function contained a reference to an
107 identifier with static linkage.
109 2011-11-06 Andreas Schwab <schwab@linux-m68k.org>
111 * keyboard.c (interrupt_signal): Don't call kill-emacs while in
114 2011-11-06 Eli Zaretskii <eliz@gnu.org>
116 * xdisp.c (init_iterator, reseat_to_string): Don't set the
117 iterator's bidi_p flag if Vpurify_flag is non-nil. (Bug#9963)
118 (Fcurrent_bidi_paragraph_direction): If Vpurify_flag is non-nil,
119 return Qleft_to_right.
121 2011-11-06 Chong Yidong <cyd@gnu.org>
123 * window.c (Fwindow_live_p, Fwindow_frame, Fframe_root_window)
124 (Fminibuffer_window, Fwindow_buffer, Fwindow_splits)
125 (Fset_window_splits, Fwindow_nest, Fset_window_nest)
126 (Fwindow_use_time, Fwindow_total_size, Fwindow_normal_size)
127 (Fwindow_new_normal, Fwindow_left_column, Fwindow_top_line)
128 (Fwindow_margins, Fwindow_fringes, Fwindow_scroll_bars)
129 (Fwindow_vscroll): Doc fix.
130 (Fwindow_top_child, Fwindow_left_child): Eliminate a nil default
131 argument, since it makes no sense to pass a live window and for
132 consistency with window-child.
134 2011-11-05 Christoph Scholtes <cschol2112@googlemail.com>
136 * makefile.w32-in ($(TEMACS), (gl-stamp)): Use $(THISDIR) to
139 2011-11-05 Jason Rumney <jasonr@gnu.org>
141 * w32font.c (font_matches_spec): Filter out non-Japanese kana fonts.
142 (add_font_entity_to_list): Filter out non-Japanese Shift-JIS
144 (add_font_entity_to_list): Fix logic errors in mixed boolean and
145 bitwise arithmetic preventing use of unicode-sip and non-truetype
148 2011-11-05 Eli Zaretskii <eliz@gnu.org>
150 * s/ms-w32.h (fstat, stat, utime): Move redirections to
153 * w32fns.c (x_create_tip_frame, Fx_create_frame): Rearrange
154 initialization code to keep similarity to xfns.c after changes
157 2011-11-05 Jan Djärv <jan.h.d@swipnet.se>
159 * nsfns.m: Declare image_cache_refcount if GLYPH_DEBUG.
160 (unwind_create_frame): New function (Bug#9943).
161 (Fx_create_frame): Restructure code to be more similar to the one in
162 xfns.c. Call record_unwind_protect with unwind_create_frame (Bug#9943).
163 Initialize image_cache_refcount if GLYPH_DEBUG (Bug#9943).
164 Move terminal->reference_count++ just before making the frame official
167 * nsterm.m (x_free_frame_resources): New function.
168 (x_destroy_window): Move code to x_free_frame_resources.
170 * xfns.c (unwind_create_frame): Fix comment.
171 (Fx_create_frame, x_create_tip_frame): Move
172 terminal->reference_count++ just before making the frame
173 official. Move initialization of image_cache_refcount and
174 dpyinfo_refcount before calling init_frame_faces (Bug#9943).
176 2011-11-05 Eli Zaretskii <eliz@gnu.org>
178 Support MSVC build with newer versions of Visual Studio.
179 * makefile.w32-in (TAGS-gmake): Don't use $(patsubst ...), as
180 Nmake barfs on that. Use $(OBJ*_c) variables instead, defined on
183 * lisp.h (ENUM_BF): New macro, for enumerated types in bitfields,
184 which are not supported by MSVC.
185 (Lisp_Symbol, Lisp_Misc_Any, Lisp_Marker, Lisp_Misc_Overlay)
186 (Lisp_Save_Value, Lisp_Free): Use ENUM_BF for enumerated types in
188 (Lisp_Object) [USE_LISP_UNION_TYPE]: Use ENUM_BF for enumerated
190 (DEFUN) [_MSC_VER]: Define in a different way for MSVC.
192 * w32fns.c [_MSC_VER]: DECLARE_HANDLE for any MSVC version.
194 2011-11-05 Fabrice Popineau <fabrice.popineau@supelec.fr> (tiny change)
196 Support MSVC build with newer versions of Visual Studio.
197 * w32.c: Don't include w32api.h for MSVC.
198 (init_environment) [_MSC_VER]: Call sys_access, not _access.
200 * s/ms-w32.h <sigset_t, ssize_t> [_MSC_VER]: Typedefs for MSVC.
201 [_MSC_VER]: Include sys/timeb.h, sys/stat.h, and signal.h.
202 (fstat, stat, utime) [_MSC_VER]: Redirect to their sys_* cousins.
203 (malloc, free, realloc, calloc) [_MSC_VER]: Always redirect to the
205 (alloca) [_MSC_VER]: Define to _alloca.
207 * lisp.h (DECL_ALIGN) [_MSC_VER]: Define for MSVC.
209 * regex.c <re_char> [_MSC_VER]: A separate definition for MSVC.
211 2011-11-04 Eli Zaretskii <eliz@gnu.org>
213 * xdisp.c (note_mouse_highlight): If either of
214 previous/next-single-property-change returns nil, treat that as
215 the beginning or the end of the buffer. (Bug#9955)
217 2011-11-04 Jan Djärv <jan.h.d@swipnet.se>
219 * gtkutil.c (xg_make_tool_item): Add callbacks if one of wimage or
220 label is not null (Bug#9951).
221 (xg_tool_item_stale_p): Handle the fact that wimage and/or wlbl
224 2011-11-04 Eli Zaretskii <eliz@gnu.org>
226 * window.c (Fwindow_body_size): Mention in the doc string that the
227 return value is in frame's canonical units. (Bug#9949)
229 2011-11-03 Eli Zaretskii <eliz@gnu.org>
231 * xdisp.c (note_mouse_highlight): Initialize `area'. (Bug#9947)
233 * w32fns.c (unwind_create_frame): If needed, free the glyph
234 matrices of the partially constructed frame. (Bug#9943)
235 * xfns.c (unwind_create_frame): Likewise.
237 2011-11-01 Eli Zaretskii <eliz@gnu.org>
239 * xdisp.c (mouse_face_from_buffer_pos): Fix a typo in a comment.
240 Don't stop backward scan on the continuation glyph, even though
241 its CHARPOS is positive.
242 (mouse_face_from_buffer_pos, note_mouse_highlight): Rename
243 cover_string to disp_string.
245 2011-11-01 Martin Rudalics <rudalics@gmx.at>
247 * window.c (temp_output_buffer_show): Don't use
248 Vtemp_buffer_show_specifiers.
249 (Vtemp_buffer_show_specifiers): Remove unused variable.
251 2011-10-30 Eli Zaretskii <eliz@gnu.org>
253 * xdisp.c (try_cursor_movement): Make sure ROW isn't decremented
254 past the beginning of the current glyph matrix.
256 2011-10-30 Adam Sjøgren <asjo@koldfront.dk> (tiny change)
258 * xterm.c: Include X11/Xproto.h if HAVE_GTK3.
259 (x_error_handler): Ignore BadMatch for X_SetInputFocus for
260 HAVE_GTK3 (Bug#9869).
262 * gtkutil.c (xg_win_to_widget, xg_event_is_for_menubar): Initialize
263 type to GDK_NOTHING so valgrind does not complain (Bug#9901).
265 * xterm.h (x_display_info): Add Xatom_net_wm_state_hidden (Bug#9893).
267 * xterm.c: Declare x_handle_net_wm_state to return int.
268 (handle_one_xevent): Check if we are iconified but don't have
269 _NET_WM_STATE_HIDDEN. If do, treat as deiconify (Bug#9893).
270 (get_current_wm_state): Return non-zero if not hidden,
271 check for _NET_WM_STATE_HIDDEN (Bug#9893).
272 (do_ewmh_fullscreen): Ignore return value from get_current_wm_state.
273 (x_handle_net_wm_state): Return what get_current_wm_state returns.
274 (x_term_init): Initialize dpyinfo->Xatom_net_wm_state_hidden.
276 2011-10-29 Paul Eggert <eggert@cs.ucla.edu>
278 * alloc.c (which_symbols): Declare EXTERNALLY_VISIBLE,
279 so that this new function doesn't get optimized away by a
280 whole-program optimizer. Make the 2nd arg EMACS_INT, not int.
282 2011-10-29 Andreas Schwab <schwab@linux-m68k.org>
284 * frame.h (MOUSE_HL_INFO): Remove excess parens.
286 2011-10-29 Eli Zaretskii <eliz@gnu.org>
288 Fix the `xbytecode' command.
289 * .gdbinit (xprintbytestr): New command.
290 (xwhichsymbols): Renamed from `which'; all callers changed.
291 (xbytecode): Print the byte-code string as well.
293 2011-10-29 Kim Storm <storm@cua.dk>
295 * alloc.c (which_symbols): New function.
297 2011-10-29 Andreas Schwab <schwab@linux-m68k.org>
299 * minibuf.c (read_minibuf_noninteractive): Allow reading empty
302 2011-10-29 Glenn Morris <rgm@gnu.org>
304 * process.c (wait_reading_process_output): Revert 2009-08-30 change.
305 Not clear what it was for, and it causes various bugs. (Bug#9839)
307 2011-10-28 Eli Zaretskii <eliz@gnu.org>
309 * xdisp.c (note_mouse_highlight): Initialize `part', to avoid a
310 possible random value that matches one of those tested as
311 condition to clear the mouse face.
313 2011-10-28 Chong Yidong <cyd@gnu.org>
315 * xdisp.c (note_mouse_highlight): Fix use of uninitialized var.
317 2011-10-28 Dan Nicolaescu <dann@ics.uci.edu>
319 * window.c (make_window): Initialize phys_cursor_on_p.
321 2011-10-28 Stefan Monnier <monnier@iro.umontreal.ca>
323 * lisp.h (struct Lisp_Symbol): Update comments.
325 2011-10-28 Juanma Barranquero <lekktu@gmail.com>
327 * w32font.c (w32_load_unicows_or_gdi32): Add missing return.
329 2011-10-28 Eli Zaretskii <eliz@gnu.org>
331 Fix Emacs on Windows 9X (bug#8562). Thanks to oslsachem
332 <oslsachem@gmail.com> for helping to debug this.
334 * w32font.c (g_b_init_is_w9x, g_b_init_get_outline_metrics_w)
335 (g_b_init_get_text_metrics_w, g_b_init_get_glyph_outline_w)
336 (g_b_init_get_glyph_outline_w): New static variables.
337 (GetOutlineTextMetricsW_Proc, GetTextMetricsW_Proc)
338 (GetGlyphOutlineW_Proc): New typedefs.
339 (w32_load_unicows_or_gdi32, get_outline_metrics_w)
340 (get_text_metrics_w, get_glyph_outline_w, globals_of_w32font):
342 (w32font_open_internal, compute_metrics):
343 Call get_outline_metrics_w, get_text_metrics_w, and get_glyph_outline_w
344 instead of calling the "wide" APIs directly.
346 * emacs.c (main) [HAVE_NTGUI]: Call globals_of_w32font.
348 * w32.h (syms_of_w32font): Add prototype.
350 2011-10-27 Juanma Barranquero <lekktu@gmail.com>
352 * window.c (Fframe_root_window, Fframe_first_window, Fwindow_end)
353 (Fframe_selected_window, Ftemp_output_buffer_show, Fnext_window)
354 (Fdelete_window_internal, Fwindow_parameters): Fix typos in docstrings.
355 (Fmove_to_window_line): Doc fix.
357 2011-10-27 Chong Yidong <cyd@gnu.org>
359 * process.c (make_process): Set gnutls_state to NULL.
361 * gnutls.c (emacs_gnutls_deinit): Deinit the gnutls_state if it is
362 non-NULL, regardless of GNUTLS_INITSTAGE.
363 (Fgnutls_boot): Cleanups. Call emacs_gnutls_deinit if we signal
364 an error. Set process slots as soon as we allocate them.
366 * gnutls.h (GNUTLS_LOG, GNUTLS_LOG2): Fix macros.
368 2011-10-27 Chong Yidong <cyd@gnu.org>
370 * gnutls.c (emacs_gnutls_deinit): New function.
371 Deallocate credentials structures as well as calling gnutls_deinit.
372 (Fgnutls_deinit, Fgnutls_boot): Use it.
374 * process.c (make_process): Initialize GnuTLS credentials to NULL.
375 (deactivate_process): Call emacs_gnutls_deinit.
377 2011-10-27 Juanma Barranquero <lekktu@gmail.com>
379 * image.c (x_create_x_image_and_pixmap):
380 * w32.c (sys_rename, w32_delayed_load):
381 * w32font.c (fill_in_logfont):
382 * w32reg.c (x_get_string_resource): Silence compiler warnings.
384 2011-10-26 Juanma Barranquero <lekktu@gmail.com>
386 * w32fns.c (w32_default_color_map): New function,
387 extracted from Fw32_default_color_map.
388 (Fw32_default_color_map, Fx_open_connection): Use it. (Bug#9785)
390 2011-10-25 Paul Eggert <eggert@cs.ucla.edu>
392 * dispextern.h (Fcontrolling_tty_p): New decl (Bug#6649 part 2).
394 2011-10-25 Stefan Monnier <monnier@iro.umontreal.ca>
396 * keyboard.c (test_undefined): New function (bug#9751).
397 (read_key_sequence): Use it to detect when a key is bound to `undefined'.
399 2011-10-25 Enami Tsugutomo <tsugutomo.enami@jp.sony.com>
401 * sysdep.c (init_sys_modes): Fix the check for the controlling
404 2011-10-20 Eli Zaretskii <eliz@gnu.org>
406 * dispextern.h (struct bidi_it): New member next_en_type.
408 * bidi.c (bidi_line_init): Initialize the next_en_type member.
409 (bidi_resolve_explicit_1): When next_en_pos is valid for the
410 current character, check also for next_en_type being WEAK_EN.
411 (bidi_resolve_weak): Don't enter the expensive loop if the current
412 position is before next_en_pos. Record the bidi type of the first
413 non-ET, non-BN character we find, in addition to its position.
414 (bidi_level_of_next_char): Invalidate next_en_type when
415 next_en_pos is over-stepped.
417 2011-10-20 Paul Eggert <eggert@cs.ucla.edu>
419 Time zone name fixes for non-ASCII locales (Bug#641, Bug#9794)
420 * editfns.c: Rewrite current-time-zone so that it invokes
421 the equivalent of (format-time-string "%Z") to get the time zone name.
422 This fixes a bug when the time zone name contains characters that
423 need converting from the system time locale to Emacs internal format.
424 This fixes a shortcoming that I introduced in my 1999-10-19 patch:
425 that patch fixed format-time-string to do the conversion, but
426 I forgot to fix current-time-zone.
427 (format_time_string): New function, containing most of
428 what Fformat_time_string used to contain.
429 (Fformat_time_string): Rewrite in terms of format_time_string.
430 This doesn't change this function's behavior.
431 (current-time-zone): Rewrite to use format_time_string.
432 This fixes the bug reported by Michael Schierl in
433 <http://lists.gnu.org/archive/html/emacs-devel/2007-06/msg00334.html>.
434 Jason Rumney's 2007-06-07 change worked around this bug, but
436 * systime.h (tzname, timezone): Remove no-longer-used declarations.
438 2011-10-19 Eli Zaretskii <eliz@gnu.org>
440 * xdisp.c (start_display): If the character at POS is displayed
441 via a display vector, reset IT->current.dpvec_index to zero.
442 (try_window_reusing_current_matrix): If a line ends in a display
443 vector or the next line starts in a display vector, continue
444 redrawing the window even though the character position of
445 start_row was reached.
448 2011-10-18 Chong Yidong <cyd@gnu.org>
450 * xdisp.c (get_next_display_element): Handle U+2010 and U+2011
451 with nobreak-char-display too.
453 2011-10-18 Eli Zaretskii <eliz@gnu.org>
455 Fix part 3 of bug#9771.
456 * bidi.c (bidi_line_init): Initialize next_en_pos to zero, not -1.
457 (bidi_resolve_neutral): Don't enter the expensive loop looking for
458 non-neutral characters if the current character is a paragraph
459 separator (a.k.a. Newline). This avoids running the same
460 expensive loop twice, once when we consume the preceding newline
461 and the other time when the line actually needs to be displayed.
462 Avoid the loop when we see neutrals on the base embedding level
463 following a character whose directionality is the same as the
464 paragraph's. This avoids running the expensive loop when a line
465 ends in a long sequence of neutrals, like control characters.
466 Add assertion against STRONG_AL type. Slightly rearrange code
467 that determines the type of a neutral given the first non-neutral
469 (bidi_level_of_next_char): Set next_en_pos to zero when
470 invalidating its info.
472 2011-10-17 Eli Zaretskii <eliz@gnu.org>
474 * xdisp.c (push_display_prop): Determine whether to record string
475 or buffer position by IT->string, not by IT->method. Allow
476 GET_FROM_DISPLAY_VECTOR as IT->method on entry. (Bug#9771, part 4)
477 (move_it_vertically_backward): Don't look for character position
478 immediately after the newline when in a continuation line.
481 2011-10-15 Martin Rudalics <rudalics@gmx.at>
483 * window.c (coordinates_in_window): Rewrite and delabelize
484 vertical border check. (Bug#5357) (Bug#9618)
486 2011-10-14 Stefan Monnier <monnier@iro.umontreal.ca>
488 * xterm.c (frame_highlight, frame_unhighlight): Ignore unexplained
489 errors in XSetWindowBorder (bug#9310).
491 2011-10-13 Dmitry Antipov <dmantipov@yandex.ru>
493 * editfns.c (Fset_time_zone_rule): Replace free with xfree to
494 avoid crash when xmalloc overrun checking is enabled.
496 2011-10-13 Eli Zaretskii <eliz@gnu.org>
498 * xdisp.c (Fcurrent_bidi_paragraph_direction): Initialize
499 itb.paragraph_dir to NEUTRAL_DIR. Fixes an occasional incorrect
500 cursor motion with <left> and <right> arrow keys.
502 * bidi.c (bidi_init_it): Don't initialize paragraph_dir here, as
503 some callers set that themselves.
505 2011-10-12 Eli Zaretskii <eliz@gnu.org>
507 * xdisp.c (find_row_edges): Handle the case where ROW comes from a
508 display string and the previous row comes from the same string and
509 is empty. (Bug#9739) (Bug#9738)
511 2011-10-12 Stefan Monnier <monnier@iro.umontreal.ca>
513 * doc.c (get_doc_string): Encode file name (bug#9735).
515 2011-10-12 Eli Zaretskii <eliz@gnu.org>
517 * bidi.c (bidi_level_of_next_char):
518 * xdisp.c (get_visually_first_element): Remove old incorrect
519 comments regarding the Unicode Line Separator character.
521 * bidi.c (bidi_init_it): Initialize paragraph_dir to NEUTRAL_DIR.
523 2011-10-12 Dmitry Antipov <dmantipov@yandex.ru>
525 * alloc.c (Fgc_status): Do not access beyond zombies array
526 boundary if nzombies > MAX_ZOMBIES.
527 * alloc.c (dump_zombies): Add missing format specifier.
529 2011-10-12 Paul Eggert <eggert@cs.ucla.edu>
531 * xdisp.c (set_cursor_from_row): Simplify conditionals,
532 to pacify GCC 4.6.1 x86-64 with -O2 -Wstrict-overflow.
534 * lread.c (read_escape): Allow hex escapes as large as ?\xfffffff.
535 Some packages use them to denote characters with modifiers.
537 2011-10-11 Andreas Schwab <schwab@linux-m68k.org>
539 * lisp.h (GCPRO1_VAR, GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR)
540 (GCPRO5_VAR, GCPRO6_VAR, UNGCPRO_VAR): Add whitespace to avoid
541 matching a pp-number. Rename parameter var to var1.
543 2011-10-11 Stefan Monnier <monnier@iro.umontreal.ca>
545 * minibuf.c (Finternal_complete_buffer): Fix last change (bug#9709).
547 2011-10-08 Glenn Morris <rgm@gnu.org>
549 * callint.c (Fcall_interactively): Give a more explicit error for the
550 'c' case with a non-character input. (Bug#8479)
552 2011-10-08 Eli Zaretskii <eliz@gnu.org>
554 * xdisp.c (hscroll_window_tree): Support hscroll in right-to-left
556 (set_cursor_from_row): Fix cursor positioning in mixed L2R+R2L
557 lines that are hscrolled on the left.
559 * dispnew.c (buffer_posn_from_coords): Account for a possible
560 presence of header-line. (Bug#4426)
562 2011-10-07 Stefan Monnier <monnier@iro.umontreal.ca>
564 * buffer.c (syms_of_buffer) <enable-multibyte-characters>:
565 Don't advertise functionality which we discourage or doesn't work.
567 2011-10-07 Paul Eggert <eggert@cs.ucla.edu>
569 * alloc.c (GC_LISP_OBJECT_ALIGNMENT): Use offsetof, not __alignof__
570 or sizeof. __alignof__ gives the wrong answer on Fedora x86-64
571 with GCC 4.6.1 when configured with CC='gcc -m32' --with-wide-int;
572 this makes Emacs dump core during garbage collection on rare
573 occasions. sizeof is obviously inferior to offsetof here, so
575 (GC_POINTER_ALIGNMENT): New macro.
576 (mark_memory): Omit 3rd (offset) arg; caller changed.
577 Don't assume EMACS_INT alignment is the same as pointer alignment.
579 2011-10-03 Stefan Monnier <monnier@iro.umontreal.ca>
581 * keyboard.c (read_key_sequence_remapped): New var.
582 (read_key_sequence): Compute remapping in the right buffer.
583 (command_loop_1): Use read_key_sequence's remapping directly.
585 2011-10-02 Stefan Monnier <monnier@iro.umontreal.ca>
587 * dired.c (file_name_completion): Don't expand file name.
588 (Ffile_name_completion, Ffile_name_all_completions): Expand file name
589 before checking file name handler.
591 * minibuf.c (Finternal_complete_buffer): Only show internal buffers if
592 they've been requested explicitly (bug#9591).
594 2011-10-01 Andreas Schwab <schwab@linux-m68k.org>
596 * keymap.c (Fsingle_key_description): Use make_specified_string
597 instead of build_string to build string from push_key_description.
600 2011-09-30 Paul Eggert <eggert@cs.ucla.edu>
602 * buffer.h (struct buffer): Use time_t, not int, for a time stamp.
603 This fixes a Y2038 bug on 64-bit hosts.
604 * buffer.c (reset_buffer):
605 * fileio.c (Fdo_auto_save, Fset_buffer_auto_saved)
606 (Fclear_buffer_auto_save_failure):
607 Use 0, not -1, to represent an unset failure time, since time_t
610 Remove dependency on glibc malloc internals.
611 * alloc.c (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
612 Move back here from lisp.h, but with their new implementations.
613 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
614 (XMALLOC_OVERRUN_SIZE_SIZE): Move these new lisp.h macros here.
615 * charset.c (charset_table_init): New static var.
616 (syms_of_charset): Use it instead of xmalloc. This removes a
617 dependency on glibc malloc internals. See Eli Zaretskii's comment in
618 <http://lists.gnu.org/archive/html/emacs-devel/2011-09/msg00815.html>.
619 * lisp.h (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
620 Move back to alloc.c.
621 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
622 (XMALLOC_OVERRUN_SIZE_SIZE): Move to alloc.c.
624 2011-09-30 Jan Djärv <jan.h.d@swipnet.se>
626 * nsterm.m (windowDidResize): Call x_set_window_size only when
627 ns_in_resize is true. Otherwise set pixelwidth/height and
628 call change_frame_size (Bug#9628).
630 2011-09-30 Paul Eggert <eggert@cs.ucla.edu>
632 Port --enable-checking=all to Fedora 14 x86-64.
633 * charset.c (syms_of_charset): Also account for glibc malloc's
634 internal overhead when calculating the initial malloc maximum.
636 Port --enable-checking=all to Fedora 14 x86.
637 * alloc.c (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
639 (xmalloc_put_size, xmalloc_get_size, overrun_check_malloc)
640 (overrun_check_realloc, overrun_check_free):
641 Use XMALLOC_OVERRUN_SIZE_SIZE, not sizeof (size_t).
642 That way, xmalloc returns a properly-aligned pointer even if
643 XMALLOC_OVERRUN_CHECK is defined. The old debugging code happened
644 to align OK on typical 64-bit hosts, but not on Fedora 14 x86.
645 * charset.c (syms_of_charset): Take XMALLOC_OVERRUN_CHECK_OVERHEAD
646 into account when calculating the initial malloc maximum.
647 * lisp.h (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
648 Move here from alloc.c, so that charset.c can use it too.
649 Properly align; the old code wasn't right for common 32-bit hosts
650 when configured with --enable-checking=all.
651 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
652 (XMALLOC_OVERRUN_SIZE_SIZE): New macros.
654 2011-09-29 Eli Zaretskii <eliz@gnu.org>
656 * sysdep.c (snprintf) [!EOVERFLOW]: If EOVERFLOW is not defined,
659 2011-09-28 Eli Zaretskii <eliz@gnu.org>
661 * xdisp.c (compute_display_string_end): If there's no display
662 string at CHARPOS, return -1.
664 * bidi.c (bidi_fetch_char): When compute_display_string_end
665 returns a negative value, treat the character as a normal
666 character not covered by a display string. (Bug#9624)
668 2011-09-28 Juanma Barranquero <lekktu@gmail.com>
670 * lread.c (Fread_from_string): Fix typo in docstring.
672 2011-09-27 Eli Zaretskii <eliz@gnu.org>
674 * xdisp.c (handle_invisible_prop): If invisible text ends on a
675 newline, reseat the iterator instead of bidi-iterating there one
676 character at a time. (Bug#9610)
677 (BUFFER_POS_REACHED_P, move_it_in_display_line_to): Bail when past
678 TO_CHARPOS if the bidi iterator is at base embedding level.
680 2011-09-27 Andreas Schwab <schwab@linux-m68k.org>
682 * lread.c (readevalloop): Use correct code for NBSP.
683 (read1): Likewise. (Bug#9608)
685 2011-09-25 Michael Albinus <michael.albinus@gmx.de>
687 * dbusbind.c (Fdbus_register_signal): When service is not
688 registered, use nil in Vdbus_registered_objects_table. (Bug#9581)
690 2011-09-25 Glenn Morris <rgm@gnu.org>
692 * buffer.c (truncate-lines): Doc fix.
694 2011-09-24 Chong Yidong <cyd@stupidchicken.com>
696 * window.c (Fwindow_prev_buffers, Fset_window_prev_buffers)
697 (Fset_window_next_buffers): Doc fix.
699 2011-09-24 Glenn Morris <rgm@gnu.org>
701 * minibuf.c (read_minibuf): Disable line truncation. (Bug#5715)
703 2011-09-24 Paul Eggert <eggert@cs.ucla.edu>
705 Fix minor problems found by static checking.
706 * xdisp.c (string_from_display_spec): Don't assume vecsize fits in int.
707 * indent.c (Fvertical_motion): Fix == vs = typo.
709 2011-09-24 Eli Zaretskii <eliz@gnu.org>
711 * dispnew.c (syms_of_display) <redisplay-dont-pause>:
712 Default value is now t. Doc fix.
714 * indent.c (Fvertical_motion): Compute and apply the overshoot
715 logic when moving up, not only when moving down. Fix the
716 confusing name and values of the it_overshoot_expected variable;
717 logic changes accordingly. (Bug#9254) (Bug#9549)
719 * xdisp.c (pos_visible_p): Produce correct pixel coordinates when
720 CHARPOS is covered by a display string which includes newlines.
721 (move_it_vertically_backward): Avoid inflooping when START_CHARPOS
722 is covered by a display string with embedded newlines.
724 2011-09-24 Michael Albinus <michael.albinus@gmx.de>
726 * dbusbind.c (Fdbus_register_signal): Add match rule to
727 Vdbus_registered_objects_table. (Bug#9581)
728 (Fdbus_register_method, Vdbus_registered_objects_table):
731 2011-09-24 Jim Meyering <meyering@redhat.com>
733 do not ignore write error for any output size
734 The previous change was incomplete.
735 While it makes emacs --batch detect the vast majority of stdout
736 write failures, errors were still ignored whenever the output size is
737 k * (BUFSIZ+1) - 4. E.g., on a system with BUFSIZ of 4096,
738 $ emacs --batch --eval '(print (format "%4093d" 0))' > /dev/full \
739 && echo FAIL: ignored write error
740 FAIL: ignored write error
741 $ emacs --batch --eval '(print (format "%20481d" 0))' > /dev/full \
742 && echo FAIL: ignored write error
743 FAIL: ignored write error
744 * emacs.c (Fkill_emacs): Also test ferror. (Bug#9574)
746 2011-09-23 Andreas Schwab <schwab@linux-m68k.org>
748 * emacs.c (Fkill_emacs): In noninteractive mode exit
749 non-successfully if a write error occurred on stdout. (Bug#9574)
751 2011-09-21 Eli Zaretskii <eliz@gnu.org>
753 * xdisp.c (pop_it): Allow it->object that is a cons cell to pass
756 * dispextern.h (struct it): Update the comment documenting what
759 2011-09-20 Eli Zaretskii <eliz@gnu.org>
761 * xdisp.c (set_cursor_from_row): If the row ends in a newline from
762 a display string, extend search for cursor position to end of row.
763 (find_row_edges): If the row ends in a newline from a display
764 string, increment its MATRIX_ROW_END_CHARPOS by one. (Bug#9549)
765 Handle the case of a display string with multiple newlines.
766 (Fcurrent_bidi_paragraph_direction): Fix search for previous
767 non-empty line. Fixes confusing cursor motion with arrow keys at
768 the beginning of a line that starts with whitespace.
770 2011-09-19 Lars Magne Ingebrigtsen <larsi@gnus.org>
772 * lread.c (Fread_from_string): Document what FINAL-STRING-INDEX is
775 2011-09-18 Chong Yidong <cyd@stupidchicken.com>
777 * xfns.c (Fx_create_frame): Handle the bitmapIcon resource as
780 2011-09-18 Eli Zaretskii <eliz@gnu.org>
782 * xdisp.c (display_line): Record maximum and minimum buffer
783 positions even if no glyphs were produced (e.g., by a zero-width
784 stretch). Fixes bug#9530 on a TTY. Under word-wrap, don't record
785 buffer positions that will be removed from the glyph row because
787 (produce_stretch_glyph): Fix a bug in :align-to on a TTY when the
788 column is beyond frame width: don't subtract 1 "pixel" when
789 computing width of the stretch.
790 (reseat_at_next_visible_line_start): Undo the change made on
791 2011-09-17 that saved paragraph information and restored it after
792 the call to `reseat'. (Bug#9545)
794 2011-09-18 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
796 * xdisp.c (expose_window): Save original value of phys_cursor_on_p
797 and turn window cursor on if cleared (Bug#9415).
799 2011-09-18 Andreas Schwab <schwab@linux-m68k.org>
801 * search.c (boyer_moore): Take unibyte characters from pattern
802 literally. (Bug#9458)
804 2011-09-18 Eli Zaretskii <eliz@gnu.org>
806 * xdisp.c (reseat_at_next_visible_line_start): Fix last change.
808 2011-09-18 Paul Eggert <eggert@cs.ucla.edu>
810 Fix minor problem found by static checking.
811 * xdisp.c (reseat_at_next_visible_line_start): Mark locals as
812 initialized, to pacify gcc -Wuninitialized.
814 * fileio.c: Report proper errno when syscall falls.
815 (Finsert_file_contents): Save and restore errno,
816 so that report_file_error outputs the correct diagnostic.
817 (Fwrite_region) [CLASH_DETECTION]: Likewise.
819 2011-09-18 Eli Zaretskii <eliz@gnu.org>
821 * .gdbinit (pgx): Fix references to fields of `struct glyph'.
823 2011-09-17 Eli Zaretskii <eliz@gnu.org>
825 * xdisp.c (produce_stretch_glyph): Another fix for changes made on
826 2011-08-30T17:32:44Z!eliz@gnu.org. (Bug#9530)
828 2011-09-17 Eli Zaretskii <eliz@gnu.org>
830 * xdisp.c (reseat_at_next_visible_line_start): Keep information
831 about the current paragraph and restore it after the call to reseat.
833 * bidi.c (MAX_PARAGRAPH_SEARCH): New macro.
834 (bidi_find_paragraph_start): Search back for paragraph beginning
835 at most MAX_PARAGRAPH_SEARCH lines; if not found, return BEGV_BYTE.
836 (bidi_move_to_visually_next): Only trigger paragraph-related
837 computations when the last character is a newline or at EOB, not
838 just any NEUTRAL_B. (Bug#9470)
840 * xdisp.c (set_cursor_from_row): Don't invoke special treatment of
841 truncated lines if point is covered by a display string. (Bug#9524)
843 2011-09-16 Paul Eggert <eggert@cs.ucla.edu>
845 * xselect.c: Relax test for outgoing X longs (Bug#9498).
846 (cons_to_x_long): New function.
847 (lisp_data_to_selection_data): Use it. Correct the test for
848 short-versus-long data; it was negated. Break out of vector
849 loop, for efficiency, when a long datum is discovered.
851 2011-09-16 Stefan Monnier <monnier@iro.umontreal.ca>
853 * eval.c (Fquote): Document its non-consing behavior (bug#9482).
855 2011-09-16 Eli Zaretskii <eliz@gnu.org>
857 * image.c (tiff_handler): Work around a bug in MinGW GCC 3.x (see
858 GCC PR/17406) by declaring this function with external scope.
860 2011-09-15 Paul Eggert <eggert@cs.ucla.edu>
862 * editfns.c (Fformat): Fix bug in text-property fix (Bug#9514).
863 Don't mishandle (length (format "%%")) and (format "%4000s%%" "").
865 2011-09-15 Andreas Schwab <schwab@linux-m68k.org>
867 * editfns.c (Fformat): Correctly handle text properties on "%%".
869 2011-09-15 Eli Zaretskii <eliz@gnu.org>
871 * xterm.c (x_draw_composite_glyph_string_foreground):
872 * w32term.c (x_draw_composite_glyph_string_foreground):
873 * term.c (encode_terminal_code):
874 * composite.c (composition_update_it, get_composition_id):
875 * xdisp.c (get_next_display_element)
876 (fill_composite_glyph_string): Add comments about special meaning
877 of TAB characters in a composition.
879 2011-09-15 Paul Eggert <eggert@cs.ucla.edu>
881 * editfns.c (Fformat): Fix off-by-1 bug for "%%b" (Bug#9514).
882 This occurs when processing a multibyte format.
883 Problem reported by Wolfgang Jenker.
885 2011-09-15 Johan Bockgård <bojohan@gnu.org>
887 * xdisp.c (try_cursor_movement): Only check for exact match if
888 cursor hpos found by set_cursor_from_row is valid. (Bug#9495)
890 2011-09-14 Paul Eggert <eggert@cs.ucla.edu>
892 Remove unused external symbols.
893 * dispextern.h (calc_pixel_width_or_height): Remove decl.
894 * xdisp.c (calc_pixel_width_or_height): Now static.
895 * doprnt.c (exprintf) [! (HAVE_X_WINDOWS && USE_X_TOOLKIT)]: Remove.
896 * indent.c (check_display_width):
897 * w32term.c: Fix comment to match code.
898 * xterm.c, xterm.h (x_catching_errors): Remove.
900 2011-09-14 Paul Eggert <eggert@cs.ucla.edu>
902 * xselect.c: Use signed conversions more consistently (Bug#9498).
903 (selection_data_to_lisp_data): Assume incoming selection data are
904 signed integers, not unsigned. This is to be consistent with
905 outgoing selection data, which was modified to use signed integers
906 in as part of the fix to Bug#9196 in response to Jan D.'s comment
907 in <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9196#32> that X11
908 expects long, not unsigned long.
910 2011-09-14 Eli Zaretskii <eliz@gnu.org>
912 * xdisp.c (try_window_reusing_current_matrix): Fix incorrect
913 computation of loop end. Reported by Johan Bockgård
916 2011-09-13 Chong Yidong <cyd@stupidchicken.com>
918 * frame.c (Fother_visible_frames_p): Function deleted.
920 2011-09-12 Eli Zaretskii <eliz@gnu.org>
922 * indent.c (compute_motion): Process display vector front to back
923 rather than the other way around. (Bug#2496)
925 2011-09-12 Stefan Monnier <monnier@iro.umontreal.ca>
927 * fileio.c (Finsert_file_contents): Don't assume beg_offset is 0.
929 2011-09-11 Chong Yidong <cyd@stupidchicken.com>
931 * minibuf.c (Fread_from_minibuffer): Doc fix.
933 2011-09-11 Eli Zaretskii <eliz@gnu.org>
935 * xdisp.c (produce_stretch_glyph): Fix a typo made in changes from
936 2011-08-30T17:32:44Z!eliz@gnu.org. (Bug#9475)
938 2011-09-11 Lars Magne Ingebrigtsen <larsi@gnus.org>
940 * fileio.c (Fvisited_file_modtime): Document `(-1 65535)' as a
941 value for non-existent files.
943 2011-09-11 Eli Zaretskii <eliz@gnu.org>
945 * fileio.c (Finsert_file_contents): If the file cannot be opened,
946 set its "size" to -1. This will set the modtime_size field of
947 the corresponding buffer to -1, which is what
948 verify-visited-file-modtime expects for files that do not exist.
951 2011-09-11 Paul Eggert <eggert@cs.ucla.edu>
953 * keymap.h (KEY_DESCRIPTION_SIZE, push_key_description): Move decls
955 * lisp.h: ... from here. push_key_description is no longer
956 defined in keyboard.c, so its declaration should not be in
957 lisp.h's "Defined in keyboard.c" section, and KEY_DESCRIPTION_SIZE
958 logically belongs with push_key_description.
960 2011-09-10 Paul Eggert <eggert@cs.ucla.edu>
962 * buffer.h: Include <sys/types.h> instead of <time.h>.
963 Otherwise, off_t wasn't defined on FreeBSD 9.0-BETA2 i386.
964 Problem reported by Herbert J. Skuhra.
966 2011-09-10 Lars Magne Ingebrigtsen <larsi@gnus.org>
968 * xml.c (parse_region): Make the parsing work for
969 non-comment-starting XML files again (bug#9144).
971 2011-09-10 Andreas Schwab <schwab@linux-m68k.org>
973 * image.c (gif_load): Fix calculation of bottom and right corner.
976 2011-09-10 Eli Zaretskii <eliz@gnu.org>
978 * xdisp.c (MAX_DISP_SCAN): Decrease to 250. Prevents sluggish
979 redisplay in small windows.
981 2011-09-09 Eli Zaretskii <eliz@gnu.org>
983 * frame.c (x_report_frame_params): Cast to avoid compiler warnings.
985 2011-09-08 Martin Rudalics <rudalics@gmx.at>
987 * window.c (Fset_window_prev_buffers, Fset_window_next_buffers):
988 Operate on live windows only.
990 2011-09-08 Juanma Barranquero <lekktu@gmail.com>
992 * emacs.c (my_heap_start): #ifdef to avoid warnings when unused.
994 2011-09-07 Eli Zaretskii <eliz@gnu.org>
996 * xdisp.c (move_it_in_display_line_to): Call RESTORE_IT on ppos_it
997 only under bidi iteration.
999 2011-09-07 Jan Djärv <jan.h.d@swipnet.se>
1001 * gtkutil.c (xg_make_tool_item): Insert comment about eventbox.
1003 2011-09-06 Paul Eggert <eggert@cs.ucla.edu>
1005 isnan: Fix porting problem to Solaris 10 with bundled gcc.
1006 Without this fix, the command to link temacs failed due to an
1007 undefined symbol __builtin_isnan. This is because
1008 /usr/include/iso/math_c99.h #defines isnan(x) to
1009 __builtin_isnan(x), but the bundled gcc, which identifies itself
1010 as gcc 3.4.3 (csl-sol210-3_4-branch+sol_rpath), does not have
1012 * floatfns.c (isnan): #undef, and then #define to a clone of
1014 (Fisnan): Always define, since it's always available now.
1015 (syms_of_floatfns): Always define isnan at the Lisp level.
1017 2011-09-06 Paul Eggert <eggert@cs.ucla.edu>
1019 * Makefile.in (gl-stamp): move-if-change now in build-aux (Bug#9169).
1021 2011-09-06 Paul Eggert <eggert@cs.ucla.edu>
1023 * fileio.c: Fix bugs with large file offsets (Bug#9428).
1024 The previous code assumed that file offsets (off_t values) fit in
1025 EMACS_INT variables, which is not true on typical 32-bit hosts.
1026 The code messed up by falsely reporting buffer overflow in cases
1027 such as (insert-file-contents "big" nil 1 2) into an empty buffer
1028 when "big" contains more than 2**29 bytes, even though this
1029 inserts just one byte and does not overflow the buffer.
1030 (Finsert_file_contents): Store file offsets as off_t
1031 values, not as EMACS_INT values. Check for overflow when
1032 converting between EMACS_INT and off_t. When checking for
1033 buffer overflow or for overlap, take the offsets into account.
1034 Don't use EMACS_INT for small values where int suffices.
1035 When checking for overlap, fix a typo: ZV was used where
1036 ZV_BYTE was intended.
1037 (Fwrite_region): Don't assume off_t fits into 'long'.
1038 * buffer.h (struct buffer.modtime_size): Now off_t, not EMACS_INT.
1040 2011-09-05 Michael Albinus <michael.albinus@gmx.de>
1042 * dbusbind.c (xd_signature_cat): Rename from signature_cat.
1044 2011-09-04 Paul Eggert <eggert@cs.ucla.edu>
1046 sprintf-related integer and memory overflow issues (Bug#9412).
1048 * doprnt.c (doprnt): Support printing ptrdiff_t and intmax_t values.
1049 (esprintf, exprintf, evxprintf): New functions.
1050 * keyboard.c (command_loop_level): Now EMACS_INT, not int.
1051 (cmd_error): Kbd macro iterations count is now EMACS_INT, not int.
1052 (modify_event_symbol): Do not assume that the length of
1053 name_alist_or_stem is safe to alloca and fits in int.
1054 (Fexecute_extended_command): Likewise for function name and binding.
1055 (Frecursion_depth): Wrap around reliably on integer overflow.
1056 * keymap.c (push_key_description): First arg is now EMACS_INT, not int,
1057 since some callers pass EMACS_INT values.
1058 (Fsingle_key_description): Don't crash if symbol name contains more
1059 than MAX_ALLOCA bytes.
1060 * minibuf.c (minibuf_level): Now EMACS_INT, not int.
1061 (get_minibuffer): Arg is now EMACS_INT, not int.
1062 * lisp.h (get_minibuffer, push_key_description): Reflect API changes.
1063 (esprintf, exprintf, evxprintf): New decls.
1064 * window.h (command_loop_level, minibuf_level): Reflect API changes.
1066 * dbusbind.c (signature_cat): New function.
1067 (xd_signature, Fdbus_register_signal):
1068 Do not overrun buffer; instead, report string overflow.
1070 * dispnew.c (add_window_display_history): Don't overrun buffer.
1071 Truncate instead; this is OK since it's just a log.
1073 * editfns.c (Fcurrent_time_zone): Don't overrun buffer
1074 even if the time zone offset is outlandishly large.
1075 Don't mishandle offset == INT_MIN.
1077 * emacs.c (main) [NS_IMPL_COCOA]: Don't overrun buffer
1078 when creating daemon; the previous buffer-overflow check was incorrect.
1080 * eval.c (verror): Simplify by rewriting in terms of evxprintf,
1081 which has the guts of the old verror function.
1083 * filelock.c (lock_file_1, lock_file): Don't blindly alloca long name;
1084 use SAFE_ALLOCA instead. Use esprintf to avoid int-overflow issues.
1086 * font.c: Include <float.h>, for DBL_MAX_10_EXP.
1087 (font_unparse_xlfd): Don't blindly alloca long strings.
1088 Don't assume XINT result fits in int, or that XFLOAT_DATA * 10
1089 fits in int, when using sprintf. Use single snprintf to count
1090 length of string rather than counting it via multiple sprintfs;
1091 that's simpler and more reliable.
1092 (font_unparse_fcname): Use it to avoid sprintf buffer overrun.
1093 (generate_otf_features) [0 && HAVE_LIBOTF]: Use esprintf, not
1094 sprintf, in case result does not fit in int.
1096 * fontset.c (num_auto_fontsets): Now printmax_t, not int.
1097 (fontset_from_font): Print it.
1099 * frame.c (tty_frame_count): Now printmax_t, not int.
1100 (make_terminal_frame, set_term_frame_name): Print it.
1101 (x_report_frame_params): In X, window IDs are unsigned long,
1102 not signed long, so print them as unsigned.
1103 (validate_x_resource_name): Check for implausibly long names,
1104 and don't assume name length fits in 'int'.
1105 (x_get_resource_string): Don't blindly alloca invocation name;
1106 use SAFE_ALLOCA. Use esprintf, not sprintf, in case result does
1109 * gtkutil.c: Include <float.h>, for DBL_MAX_10_EXP.
1110 (xg_check_special_colors, xg_set_geometry):
1111 Make sprintf buffers a bit bigger, to avoid potential buffer overrun.
1113 * lread.c (dir_warning): Don't blindly alloca buffer; use SAFE_ALLOCA.
1114 Use esprintf, not sprintf, in case result does not fit in int.
1116 * macros.c (executing_kbd_macro_iterations): Now EMACS_INT, not int.
1117 (Fend_kbd_macro): Don't mishandle MOST_NEGATIVE_FIXNUM by treating
1118 it as a large positive number.
1119 (Fexecute_kbd_macro): Don't assume repeat count fits in int.
1120 * macros.h (executing_kbd_macro_iterations): Now EMACS_INT, not int.
1122 * nsterm.m ((NSSize)windowWillResize): Use esprintf, not sprintf,
1123 in case result does not fit in int.
1125 * print.c (float_to_string): Detect width overflow more reliably.
1126 (print_object): Make sprintf buffer a bit bigger, to avoid potential
1127 buffer overrun. Don't assume list length fits in 'int'. Treat
1128 print length of 0 as 0, not as infinity; to be consistent with other
1129 uses of print length in this function. Don't overflow print length
1130 index. Don't assume hash table size fits in 'long', or that
1131 vectorlike size fits in 'unsigned long'.
1133 * process.c (make_process): Use printmax_t, not int, to format
1134 process-name gensyms.
1136 * sysdep.c (snprintf) [! HAVE_SNPRINTF]: New function.
1138 * term.c (produce_glyphless_glyph): Make sprintf buffer a bit bigger
1139 to avoid potential buffer overrun.
1141 * xfaces.c (x_update_menu_appearance): Don't overrun buffer
1142 if X resource line is longer than 512 bytes.
1144 * xfns.c (x_window): Make sprintf buffer a bit bigger
1145 to avoid potential buffer overrun.
1147 * xterm.c (x_io_error_quitter): Don't overrun sprintf buffer.
1149 * xterm.h (x_check_errors): Add ATTRIBUTE_FORMAT_PRINTF.
1151 2011-09-04 Paul Eggert <eggert@cs.ucla.edu>
1153 Integer overflow fixes for scrolling, etc.
1154 Without these, Emacs silently mishandles large integers sometimes.
1155 For example, "C-u 4294967297 M-x recenter" was treated as if
1156 it were "C-u 1 M-x recenter" on a typical 64-bit host.
1158 * xdisp.c (try_window_id): Check Emacs fixnum range before
1159 converting to 'int'.
1161 * window.c (window_scroll_line_based, Frecenter):
1162 Check that an Emacs fixnum is in range before assigning it to 'int'.
1163 (Frecenter, Fmove_to_window_line): Use EMACS_INT, not int, for
1164 values converted from Emacs fixnums.
1165 (Frecenter): Don't wrap around a line count if it is out of 'int'
1166 range; instead, treat it as an extreme value.
1167 (Fset_window_configuration, compare_window_configurations):
1168 Use ptrdiff_t, not int, for index that might exceed 2 GiB.
1170 * search.c (Freplace_match): Use ptrdiff_t, not int, for indexes
1171 that can exceed INT_MAX. Check that EMACS_INT value is in range
1172 before assigning it to the (possibly-narrower) index.
1173 (match_limit): Don't assume that a fixnum can fit in 'int'.
1175 * print.c (print_object): Use ptrdiff_t, not int, for index that can
1178 * indent.c (position_indentation): Now takes ptrdiff_t, not int.
1179 (Fvertical_motion): Don't wrap around LINES values that don't fit
1180 in 'int'. Instead, treat them as extreme values. This is good
1181 enough for windows, which can't have more than INT_MAX lines anyway.
1183 2011-09-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
1185 * Require libxml/parser.h to avoid compilation warning.
1187 * emacs.c (shut_down_emacs): Call xmlCleanupParser on shutdown.
1189 * xml.c (parse_region): Don't call xmlCleanupParser after parsing,
1190 since this reportedly can destroy thread storage.
1192 2011-08-30 Chong Yidong <cyd@stupidchicken.com>
1194 * syntax.c (find_defun_start): Update all cache variables if
1195 exiting early (Bug#9401).
1197 2011-08-30 Eli Zaretskii <eliz@gnu.org>
1199 * image.c (x_bitmap_pixmap): Cast to int to avoid compiler warnings.
1201 * xdisp.c (produce_stretch_glyph): No longer static, compiled also
1202 when HAVE_WINDOW_SYSTEM is not defined. Support both GUI and TTY
1203 frames. Call tty_append_glyph in the TTY case. (Bug#9402)
1205 * term.c (tty_append_glyph): New function.
1206 (produce_stretch_glyph): Static function and its prototype deleted.
1208 * dispextern.h (produce_stretch_glyph, tty_append_glyph):
1211 2011-08-29 Paul Eggert <eggert@cs.ucla.edu>
1213 * image.c (parse_image_spec): Check for nonnegative, not for positive,
1214 when checking :margin (Bug#9390).
1215 (IMAGE_NON_NEGATIVE_INTEGER_VALUE_OR_PAIR):
1216 Rename from IMAGE_POSITIVE_INTEGER_VALUE_OR_PAIR,
1217 so that the name doesn't mislead. All uses changed.
1219 2011-08-28 Johan Bockgård <bojohan@gnu.org>
1221 * term.c (init_tty) [HAVE_GPM]: Move mouse settings after
1224 2011-08-27 Eli Zaretskii <eliz@gnu.org>
1226 * xdisp.c (move_it_to): Don't bail out early when reaching
1227 position beyond to_charpos, if we are scanning backwards.
1228 (move_it_vertically_backward): When DY == 0, make sure we get to
1229 the first character in the line after the newline.
1231 2011-08-27 Paul Eggert <eggert@cs.ucla.edu>
1233 * ccl.c: Improve and simplify overflow checking (Bug#9196).
1234 (ccl_driver): Do not generate an out-of-range pointer.
1235 (Fccl_execute_on_string): Remove unnecessary check for
1236 integer overflow, noted by Stefan Monnier in
1237 <http://lists.gnu.org/archive/html/emacs-devel/2011-08/msg00979.html>.
1238 Remove a FIXME that didn't need fixing.
1239 Simplify the newly-introduced buffer reallocation code.
1241 2011-08-27 Juanma Barranquero <lekktu@gmail.com>
1243 * makefile.w32-in ($(BLD)/alloc.$(O)): Depend on lib/verify.h.
1245 2011-08-26 Paul Eggert <eggert@cs.ucla.edu>
1247 Integer and memory overflow issues (Bug#9196).
1249 * doc.c (get_doc_string): Rework so that
1250 get_doc_string_buffer_size is the actual buffer size, rather than
1251 being 1 less than the actual buffer size; this makes xpalloc more
1254 * image.c (x_allocate_bitmap_record, cache_image):
1255 * xselect.c (Fx_register_dnd_atom):
1256 Simplify previous changes by using xpalloc.
1258 * buffer.c (overlay_str_len): Now ptrdiff_t, not EMACS_INT,
1259 since either will do and ptrdiff_t is convenient with xpalloc.
1261 * charset.c (charset_table_size)
1262 (struct charset_sort_data.priority): Now ptrdiff_t.
1263 (charset_compare): Don't overflow if priorities differ greatly.
1264 (Fsort_charsets): Don't assume list length fits in int.
1265 Check for size-calculation overflow when allocating sort data.
1266 (syms_of_charset): Allocate an initial charset table that is
1267 just under 64 KiB, to avoid problems with glibc malloc and mmap.
1269 * cmds.c (internal_self_insert): Check for size-calculation overflow.
1271 * composite.h (struct composition.glyph_len): Now int, not unsigned.
1272 The actual value is always <= INT_MAX, and leaving it unsigned made
1273 overflow checking harder.
1275 * dispextern.h (struct glyph_matrix.rows_allocated)
1276 (struct face_cache.size): Now ptrdiff_t, for convenience in use
1277 with xpalloc. The values are still always <= INT_MAX.
1279 * indent.c (compute_motion): Adjust to region_cache_forward sig change.
1281 * lisp.h (xnmalloc, xnrealloc, xpalloc): New decls.
1282 (SAFE_NALLOCA): New macro.
1284 * region-cache.c (struct boundary.pos, find_cache_boundary)
1285 (move_cache_gap, insert_cache_boundary, delete_cache_boundaries)
1286 (set_cache_region, invalidate_region_cache)
1287 (revalidate_region_cache, know_region_cache, region_cache_forward)
1288 (region_cache_backward, pp_cache):
1289 Use ptrdiff_t, not EMACS_INT, since either will do. This is needed
1290 so that ptrdiff_t * can be passed to xpalloc.
1291 (struct region_cache): Similarly, for gap_start, gap_len, cache_len,
1292 beg_unchanged, end_unchanged, buffer_beg, buffer_end members.
1293 (pp_cache): Don't assume cache_len fits in int.
1294 * region-cache.h: Adjust extern decls to match.
1296 * search.c (scan_buffer, Freplace_match): Use ptrdiff_t, not
1297 EMACS_INT, since either will do, for xpalloc.
1299 * alloc.c: Include verify.h, and check that int fits in ptrdiff_t.
1300 (xnmalloc, xnrealloc, xpalloc): New functions.
1302 * bidi.c (bidi_shelve_header_size): New constant.
1303 (bidi_cache_ensure_space, bidi_shelve_cache): Use it.
1304 (bidi_cache_ensure_space): Avoid integer overflow when allocating.
1306 * bidi.c (bidi_cache_shrink):
1307 * buffer.c (overlays_at, overlays_in, record_overlay_string)
1309 Don't update size of array until after memory allocation succeeds,
1310 because xmalloc/xrealloc may not return.
1311 (struct sortstrlist.bytes): Now ptrdiff_t, as EMACS_INT doesn't help
1312 now that we have proper integer overflow checking.
1313 (record_overlay_string, overlay_strings): Catch overflows when
1314 calculating size of overlay_str_buf.
1316 * callproc.c (Fcall_process): Check for size overflow when
1317 calculating size of args2.
1318 (child_setup): Avoid overflow by using size_t rather than ptrdiff_t.
1319 Normally we prefer signed values, but sticking with ptrdiff_t would
1320 require adding more-complicated checks.
1322 * ccl.c (Fccl_execute_on_string): Check for memory overflow.
1323 Use ptrdiff_t rather than EMACS_INT where ptrdiff_t will do.
1324 Redo buffer-overflow calculations to avoid integer overflow.
1325 Add a FIXME comment where memory seems to be over-allocated.
1327 * character.c (Fstring): Check for size-calculation overflow.
1329 * coding.c (produce_chars): Redo buffer-overflow calculations to avoid
1330 unnecessary integer overflow. Check for size overflow.
1331 (encode_coding_object): Don't update size until xmalloc succeeds.
1333 * composite.c (get_composition_id): Check for overflow in glyph
1334 length calculations.
1336 Integer and memory overflow fixes for display code.
1337 * dispextern.h (struct glyph_pool.nglyphs): Now ptrdiff_t, not int.
1338 * dispnew.c (adjust_glyph_matrix, realloc_glyph_pool)
1339 (scrolling_window): Check for overflow in size calculations.
1340 (line_draw_cost, realloc_glyph_pool, add_row_entry):
1341 Don't assume glyph table len fits in int.
1342 (struct row_entry.bucket, row_entry_pool_size, row_entry_idx)
1343 (row_table_size): Now ptrdiff_t, not int.
1344 (scrolling_window): Avoid overflow in size calculations.
1345 Don't update size until allocation succeeds.
1346 * fns.c (concat): Check for overflow in size calculations.
1347 (next_almost_prime): Verify NEXT_ALMOST_PRIME_LIMIT.
1348 * lisp.h (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): New macros.
1349 (NEXT_ALMOST_PRIME_LIMIT): New constant.
1351 * doc.c (get_doc_string_buffer_size): Now ptrdiff_t, not int.
1352 (get_doc_string): Check for size calculation overflow.
1353 Don't update size until allocation succeeds.
1354 (get_doc_string, Fsubstitute_command_keys): Use ptrdiff_t, not
1355 EMACS_INT, where ptrdiff_t will do.
1356 (Fsubstitute_command_keys): Check for string overflow.
1358 * editfns.c (set_time_zone_rule): Don't assume environment length
1360 (message_length): Now ptrdiff_t, not int.
1361 (Fmessage_box): Don't update size until allocation succeeds.
1362 Don't assume message length fits in int.
1363 (Fformat): Use ptrdiff_t, not EMACS_INT, where ptrdiff_t will do.
1365 * emacs.c (main): Do not reallocate argv, since there is a null at
1366 the end that can be overwritten, and this way there's no need to
1367 worry about size-calculation overflow.
1368 (sort_args): Check for size-calculation overflow.
1370 * eval.c (init_eval_once, grow_specpdl): Don't update size until
1372 (call_debugger, grow_specpdl): Redo calculations to avoid overflow.
1374 * frame.c (set_menu_bar_lines, x_set_frame_parameters)
1375 (x_set_scroll_bar_width, x_figure_window_size):
1376 Check for integer overflow.
1377 (x_set_alpha): Do not assume XINT fits in int.
1379 * frame.h (struct frame): Use int, not EMACS_INT, where int works.
1380 This is for the members text_lines, text_cols, total_lines, total_cols,
1381 where the system imposes an 'int' limit.
1383 * fringe.c (Fdefine_fringe_bitmap):
1384 Don't update size until alloc works.
1386 * ftfont.c (ftfont_get_open_type_spec, setup_otf_gstring)
1387 (ftfont_shape_by_flt): Check for integer overflow in size calculations.
1389 * gtkutil.c (get_utf8_string, xg_store_widget_in_map):
1390 Check for size-calculation overflow.
1391 (get_utf8_string): Use ptrdiff_t, not size_t, where either will
1392 do, as we prefer signed integers.
1393 (id_to_widget.max_size, id_to_widget.used)
1394 (xg_store_widget_in_map, xg_remove_widget_from_map)
1395 (xg_get_widget_from_map, xg_get_scroll_id_for_window)
1396 (xg_remove_scroll_bar, xg_update_scrollbar_pos):
1397 Use and return ptrdiff_t, not int.
1398 (xg_gtk_scroll_destroy): Don't assume ptrdiff_t fits in int.
1399 * gtkutil.h: Change prototypes to match the above.
1401 * image.c (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): Remove; these
1402 are duplicate now that they've been promoted to lisp.h.
1403 (x_allocate_bitmap_record, x_alloc_image_color)
1404 (make_image_cache, cache_image, xpm_load):
1405 Don't update size until alloc is done.
1406 (xpm_load, lookup_rgb_color, lookup_pixel_color, x_to_xcolors)
1408 Check for size calculation overflow.
1409 (ct_colors_allocated_max): New constant.
1410 (x_to_xcolors, x_detect_edges): Reorder multiplicands to avoid
1413 * keyboard.c (read_char, menu_bar_items, tool_bar_items)
1414 (read_char_x_menu_prompt, read_char_minibuf_menu_width)
1415 (read_char_minibuf_menu_prompt, follow_key, read_key_sequence):
1416 Use ptrdiff_t, not int, to count maps.
1417 (read_char_minibuf_menu_prompt): Check for overflow in size
1418 calculations. Don't update size until allocation succeeds.
1419 Redo calculations to avoid overflow.
1420 * keyboard.h: Change prototypes to match the above.
1422 * keymap.c (cmm_size, current_minor_maps): Use ptrdiff_t, not int,
1424 (current_minor_maps): Check for size calculation overflow.
1425 * keymap.h: Change prototypes to match the above.
1427 * lread.c (read1, init_obarray): Don't update size until alloc done.
1429 * macros.c (Fstart_kbd_macro): Don't update size until alloc done.
1430 (store_kbd_macro_char): Reorder multiplicands to avoid overflow.
1432 * nsterm.h (struct ns_color_table.size, struct ns_color_table.avail):
1433 Now ptrdiff_t, not int.
1434 * nsterm.m (ns_index_color): Use ptrdiff_t, not int, for table indexes.
1435 (ns_draw_fringe_bitmap): Rewrite to avoid overflow.
1437 * process.c (Fnetwork_interface_list): Check for overflow
1438 in size calculation.
1440 * region-cache.c (move_cache_gap): Check for size calculation overflow.
1442 * scroll.c (do_line_insertion_deletion_costs): Check for size calc
1443 overflow. Don't bother calling xmalloc when xrealloc will do.
1445 * search.c (Freplace_match): Check for size calculation overflow.
1446 (Fset_match_data): Don't assume list lengths fit in 'int'.
1448 * sysdep.c (system_process_attributes): Use ptrdiff_t, not int,
1449 for command line length. Do not attempt to address one before the
1450 beginning of an array, as that's not portable.
1452 * term.c (max_frame_lines): Remove; unused.
1453 (encode_terminal_src_size, encode_terminal_dst_size): Now ptrdiff_t,
1455 (encode_terminal_code, calculate_costs): Check for size
1456 calculation overflow.
1457 (encode_terminal_code): Use ptrdiff_t, not int, to record glyph
1458 table lengths and related sizes. Don't update size until alloc
1459 done. Redo calculations to avoid overflow.
1460 (calculate_costs): Don't bother calling xmalloc when xrealloc will do.
1462 * termcap.c (tgetent): Use ptrdiff_t, not int, to record results of
1463 subtracting pointers.
1464 (gobble_line): Check for overflow more carefully. Don't update size
1467 * tparam.c (tparam1): Use ptrdiff_t, not int, for sizes.
1468 Don't update size until alloc done.
1469 Redo size calculations to avoid overflow.
1470 Check for size calculation overflow.
1471 (main) [DEBUG]: Fix typo in invoking tparam1.
1473 * xdisp.c (store_mode_line_noprop_char, x_consider_frame_title):
1474 Use ptrdiff_t, not int, for sizes.
1475 (store_mode_line_noprop_char): Don't update size until alloc done.
1477 * xfaces.c (lface_id_to_name_size, Finternal_make_lisp_face):
1478 Use ptrdiff_t, not int, for sizes.
1479 (Finternal_make_lisp_face, cache_face):
1480 Check for size calculation overflow.
1481 (cache_face): Treat size calculation overflows as if they were
1482 memory exhaustion (the usual treatment), rather than aborting.
1484 * xfns.c (x_encode_text, x_set_name_internal)
1485 (Fx_change_window_property): Use ptrdiff_t, not int, to count
1486 sizes, since they can exceed INT_MAX in size. Check for size
1487 calculation overflow.
1489 * xgselect.c (gfds_size): Now ptrdiff_t, for convenience with xpalloc.
1490 (xg_select): Check for size calculation overflow.
1491 Don't update size until alloc done.
1493 * xrdb.c (get_environ_db): Don't assume path length fits in int,
1494 as sprintf is limited to int lengths.
1496 * xselect.c (X_LONG_SIZE, X_SHRT_MAX, X_SHRT_MIN, X_LONG_MAX)
1497 (X_LONG_MIN): New macros.
1498 Use them to make the following changes clearer.
1499 (MAX_SELECTION_QUANTUM): Make the other bounds on this value clearer.
1500 This change doesn't affect the value now, but it may help remind
1501 future maintainers not to raise the value too much later.
1502 (SELECTION_QUANTUM): Remove, replacing with ...
1503 (selection_quantum): ... new function, which avoids overflow.
1505 (struct selection_data.size): Now ptrdiff_t, not int, to avoid
1506 assumption that selection length fits in 'int'.
1507 (x_reply_selection_request, x_handle_selection_request)
1508 (x_get_window_property, receive_incremental_selection)
1509 (x_get_window_property_as_lisp_data, selection_data_to_lisp_data)
1510 (lisp_data_to_selection_data, clean_local_selection_data):
1511 Use ptrdiff_t, not int, to record length of selection.
1512 (x_reply_selection_request, x_get_window_property)
1513 (receive_incremental_selection, x_property_data_to_lisp):
1514 Redo calculations to avoid overflow.
1515 (x_reply_selection_request): When sending hint, ceiling it at
1516 X_LONG_MAX rather than relying on wraparound overflow to send
1518 (x_get_window_property, receive_incremental_selection)
1519 (lisp_data_to_selection_data, x_property_data_to_lisp):
1520 Check for size-calculation overflow.
1521 (x_get_window_property, receive_incremental_selection)
1522 (lisp_data_to_selection_data, Fx_register_dnd_atom):
1523 Don't store size until memory allocation succeeds.
1524 (x_get_window_property): Plug memory leak on memory exhaustion.
1525 Don't double-block input; malloc is safe here. Don't assume 2**34
1526 - 4 fits in unsigned long. Add an xassert to check
1527 XGetWindowProperty overflow. Be more careful about overflow
1528 calculations, and distinguish size from memory overflow better.
1529 (receive_incremental_selection): When tracing, don't assume
1530 unsigned int is less than INT_MAX.
1531 (x_selection_data_to_lisp_data): Remove unnecessary (and in theory
1532 harmful) conversions of unsigned short to int.
1533 (lisp_data_to_selection_data): Don't assume that integers
1534 in the range -65535 through -1 fit in an X unsigned short.
1535 Don't assume that ULONG_MAX == X_ULONG_MAX. Don't store into
1536 result parameters unless successful. Rely on cons_to_unsigned
1537 to report problems with elements; the old code wasn't right anyway.
1538 (x_check_property_data): Check for int overflow; we cannot use
1539 a wider type due to X limits.
1540 (x_handle_dnd_message): Use unsigned int, to avoid int overflow.
1542 * xsmfns.c (smc_save_yourself_CB): Check for size calc overflow.
1544 * xterm.c (x_color_cells, x_send_scrollbar_event, handle_one_xevent)
1545 (x_term_init): Check for size calculation overflow.
1546 (x_color_cells): Don't store size until memory allocation succeeds.
1547 (handle_one_xevent): Use ptrdiff_t, not int, for byte counts.
1548 Don't assume alloca size is less than MAX_ALLOCA.
1549 (x_term_init): Don't assume length fits in int (sprintf is limited
1552 Use ptrdiff_t for composition IDs.
1553 * character.c (lisp_string_width):
1554 * composite.c (composition_table_size, n_compositions)
1555 (get_composition_id, composition_gstring_from_id):
1556 * dispextern.h (struct glyph_string.cmp_id, struct composition_it.id):
1557 * xdisp.c (BUILD_COMPOSITE_GLYPH_STRING):
1558 * window.c (Frecenter):
1559 Use ptrdiff_t, not int, for composition IDs.
1560 * composite.c (get_composition_id): Check for integer overflow.
1561 * composite.h: Adjust prototypes to match the above changes.
1563 Use ptrdiff_t for hash table indexes.
1564 * category.c (hash_get_category_set):
1565 * ccl.c (ccl_driver):
1566 * charset.h (struct charset.hash_index, CHECK_CHARSET_GET_ID):
1567 * coding.c (coding_system_charset_list, detect_coding_system):
1568 * coding.h (struct coding_system.id):
1569 * composite.c (get_composition_id, gstring_lookup_cache):
1570 * fns.c (hash_lookup, hash_put, Fgethash, Fputhash):
1571 * image.c (xpm_get_color_table_h):
1572 * lisp.h (hash_lookup, hash_put):
1573 * minibuf.c (Ftest_completion):
1574 Use ptrdiff_t for hash table indexes, not int (which is too
1575 narrow, on 64-bit hosts) or EMACS_INT (which is too wide, on
1576 32-bit --with-wide-int hosts).
1578 * charset.c (Fdefine_charset_internal): Check for integer overflow.
1579 Add a FIXME comment about memory leaks.
1580 (syms_of_charset): Don't assume xmalloc returns.
1582 Don't assume that stated character widths fit in int.
1583 * character.c (Fchar_width, c_string_width, lisp_string_width):
1584 * character.h (CHAR_WIDTH):
1585 * indent.c (MULTIBYTE_BYTES_WIDTH):
1586 Use sanitize_char_width to avoid undefined and/or bad behavior
1587 with outlandish widths.
1588 * character.h (sanitize_tab_width): Rename from sanitize_width,
1589 now that we have two such functions. All uses changed.
1590 (sanitize_char_width): New inline function.
1592 Don't assume that tab-width fits in int.
1593 * character.h (sanitize_width): New inline function.
1594 (SANE_TAB_WIDTH): New macro.
1595 (ASCII_CHAR_WIDTH): Use it.
1596 * indent.c (sane_tab_width): Remove. All uses replaced by
1597 SANE_TAB_WIDTH (current_buffer).
1598 * xdisp.c (init_iterator): Use SANE_TAB_WIDTH.
1600 * fileio.c: Integer overflow issues with file modes.
1601 (Fset_file_modes, auto_save_1): Don't assume EMACS_INT fits in int.
1603 * charset.c (read_hex): New arg OVERFLOW. All uses changed.
1604 Remove unreachable code.
1605 (read_hex, load_charset_map_from_file): Check for integer overflow.
1607 * xterm.c: don't go over XClientMessageEvent limit
1608 (scroll_bar_windows_size): Now ptrdiff_t, as we prefer signed.
1609 (x_send_scroll_bar_event): Likewise. Check that the size does not
1610 exceed limits imposed by XClientMessageEvent, as well as the usual
1611 ptrdiff_t and size_t limits.
1613 * keyboard.c: Overflow, signedness and related fixes.
1614 (make_lispy_movement): Use same integer type in forward decl
1615 that is used in the definition.
1616 (read_key_sequence, keyremap_step):
1617 Change bufsize argument back to int, undoing my 2011-03-30 change.
1618 We prefer signed types, and int is wide enough here.
1619 (parse_tool_bar_item): Don't assume tool_bar_max_label_size is less
1620 than TYPE_MAXIMUM (EMACS_INT) / 2. Don't let the label size grow
1621 larger than STRING_BYTES_BOUND. Use ptrdiff_t for Emacs string
1622 length, not size_t. Use ptrdiff_t for index, not int.
1623 (keyremap_step, read_key_sequence): Redo bufsize check to avoid
1624 possibility of integer overflow.
1626 Overflow, signedness and related fixes for images.
1628 * dispextern.h (struct it.stack[0].u.image.image_id)
1629 (struct_it.image_id, struct image.id, struct image_cache.size)
1630 (struct image_cache.used, struct image_cache.ref_count):
1631 * gtkutil.c (update_frame_tool_bar):
1632 * image.c (x_reference_bitmap, Fimage_size, Fimage_mask_p)
1633 (Fimage_metadata, free_image_cache, clear_image_cache, lookup_image)
1634 (cache_image, mark_image_cache, x_kill_gs_process, Flookup_image):
1635 * nsmenu.m (update_frame_tool_bar):
1636 * xdisp.c (calc_pixel_width_or_height):
1637 * xfns.c (image_cache_refcount):
1638 Image IDs are now ptrdiff_t, not int, to avoid arbitrary limits
1639 on typical 64-bit hosts.
1641 * image.c (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): New macros.
1642 (x_bitmap_pixmap, x_create_x_image_and_pixmap):
1643 Omit unnecessary casts to int.
1644 (parse_image_spec): Check that integers fall into 'int' range
1645 when the callers expect that.
1646 (image_ascent): Redo ascent calculation to avoid int overflow.
1647 (clear_image_cache): Avoid overflow when sqrt (INT_MAX) < nimages.
1648 (lookup_image): Remove unnecessary tests.
1649 (xbm_image_p): Locals are now of int, not EMACS_INT,
1650 since parse_image_check makes sure they fit into int.
1651 (png_load, gif_load, svg_load_image):
1652 Prefer int to unsigned where either will do.
1653 (tiff_handler): New function, combining the cores of the
1654 old tiff_error_handler and tiff_warning_handler.
1655 This function is rewritten to use vsnprintf and thereby avoid
1656 stack buffer overflows. It uses only the features of vsnprintf
1657 that are common to both POSIX and native Microsoft.
1658 (tiff_error_handler, tiff_warning_handler): Use it.
1659 (tiff_load, gif_load, imagemagick_load_image):
1660 Don't assume :index value fits in 'int'.
1661 (gif_load): Omit unnecessary cast to double, and avoid double-rounding.
1662 (imagemagick_load_image): Check that crop parameters fit into
1663 the integer types that MagickCropImage accepts. Don't assume
1664 Vimagemagick_render_type has a nonnegative value. Don't assume
1665 size_t fits in 'long'.
1666 (gs_load): Use printmax_t to print the widest integers possible.
1667 Check for integer overflow when computing image height and width.
1669 2011-08-26 Eli Zaretskii <eliz@gnu.org>
1671 * xdisp.c (redisplay_window): Don't force window start if point
1672 will be invisible in the resulting window. (Bug#9324)
1674 2011-08-25 Eli Zaretskii <eliz@gnu.org>
1676 * xdisp.c (compute_display_string_pos): Return 2 in DISP_PROP when
1677 the display spec is of the form `(space ...)'.
1678 (handle_display_spec): Return the value returned by
1679 handle_single_display_spec, not just 1 or zero.
1680 (handle_single_display_spec): If the display spec is of the form
1681 `(space ...)', and specifies display in the text area, return 2
1683 (try_cursor_movement): Check for the need to scroll more
1684 accurately, and prefer exact match for point under bidi.
1685 Don't advance `row' beyond the last row of the window.
1687 * dispextern.h (struct bidi_it): Rename the disp_prop_p member
1688 into disp_prop; all users changed.
1690 * bidi.c (bidi_fetch_char): If compute_display_string_pos returns
1691 DISP_PROP = 2, substitute the u+2029 PARAGRAPH SEPARATOR character
1692 for the text covered by the display property.
1694 2011-08-25 Chong Yidong <cyd@stupidchicken.com>
1696 * buffer.c (Fbury_buffer_internal): Rename from Funrecord_buffer.
1697 Change return value to nil.
1698 (Frecord_buffer): Delete unused function.
1700 2011-08-24 Eli Zaretskii <eliz@gnu.org>
1702 * xdisp.c (Fcurrent_bidi_paragraph_direction): For unibyte
1703 buffers, return left-to-right.
1704 (set_cursor_from_row): Consider candidate row a win if its glyph
1705 represents a newline and point is on that newline. Fixes cursor
1706 positioning on the newline at EOL of R2L text within L2R
1707 paragraph, and vice versa.
1708 (try_cursor_movement): Check continued rows, in addition to
1709 continuation rows. Fixes unwarranted scroll when point enters a
1710 continued line of R2L text within an L2R paragraph, or vice versa.
1711 (cursor_row_p): Consider the case of point being equal to
1712 MATRIX_ROW_END_CHARPOS. Prevents cursor being stuck when moving
1713 from the end of a short line to the beginning of a continued line
1714 of R2L text within L2R paragraph.
1715 (RECORD_MAX_MIN_POS): For max_pos, use IT_CHARPOS even for
1716 composed characters.
1718 * bidi.c (bidi_check_type): Use xassert.
1719 (bidi_cache_iterator_state): Update the disp_pos and disp_prop_p
1722 2011-08-23 Eli Zaretskii <eliz@gnu.org>
1724 * bidi.c (bidi_get_type): Abort if we get zero as the bidi type of
1727 2011-08-23 Chong Yidong <cyd@stupidchicken.com>
1729 * nsfont.m (ns_otf_to_script): Fix typo.
1731 2011-08-22 Kenichi Handa <handa@m17n.org>
1733 * chartab.c (Fset_char_table_extra_slot): Do not inhibit setting a
1734 extra slot even if the purpose is char-code-property-table.
1736 2011-08-23 Eli Zaretskii <eliz@gnu.org>
1738 * xdisp.c (redisplay_window): When computing centering_position,
1739 account for the height of the header line. (Bug#8874)
1741 * dispnew.c (buffer_posn_from_coords): Use buf_charpos_to_bytepos
1742 instead of CHAR_TO_BYTE. Fixes a crash when a completion
1743 candidate is selected by the mouse, and that candidate has a
1744 composed character under the mouse.
1746 * xdisp.c (x_produce_glyphs): Set it->nglyphs to 1. Fixes pixel
1747 coordinates reported by pos-visible-in-window-p for a composed
1748 character in column zero.
1750 2011-08-23 Stefan Monnier <monnier@iro.umontreal.ca>
1752 * cmds.c (Fself_insert_command): Mention post-self-insert-hook.
1754 2011-08-22 Eli Zaretskii <eliz@gnu.org>
1756 * xdisp.c (BUFFER_POS_REACHED_P): If this is a composition,
1757 consider it a hit if to_charpos is anywhere in the range of the
1758 composed buffer positions.
1760 2011-08-22 Chong Yidong <cyd@stupidchicken.com>
1762 * image.c (gif_load): Don't assume that each subimage has the same
1763 dimensions as the base image. Handle disposal method that is
1764 "undefined" by the gif spec (Bug#9335).
1766 2011-08-20 Chong Yidong <cyd@stupidchicken.com>
1768 * eval.c (Fsignal): Handle `debug' symbol in error handler (Bug#9329).
1769 (Fcondition_case): Document `debug' symbol in error handler.
1771 2011-08-19 Eli Zaretskii <eliz@gnu.org>
1773 * xfaces.c (face_at_buffer_position): Avoid repeated evaluation of
1774 face ID by FACE_FROM_ID, and avoid a crash when mouse is moved
1775 from an Org mode buffer to a Speedbar frame.
1777 * xdisp.c (RECORD_MAX_MIN_POS): If the display element comes from
1778 a composition, take its buffer position from IT->cmp_it.charpos.
1779 Fixes cursor positioning at the beginning of a line that begins
1780 with a composed character.
1782 2011-08-18 Eli Zaretskii <eliz@gnu.org>
1784 * bidi.c (bidi_get_type): If bidi_type_table reports zero as the
1785 character bidirectional type, use STRONG_L instead. Fixes crashes
1786 in a buffer produced by `describe-categories'.
1788 * dispextern.h (struct bidi_it): Move disp_pos and disp_prop_p
1789 members before the level stack, so they would be saved and
1790 restored when copying iterator state. Fixes incorrect reordering
1791 around TABs covered by display properties.
1793 2011-08-18 Andreas Schwab <schwab@linux-m68k.org>
1795 * process.c (Fnetwork_interface_list): Correctly determine buffer size.
1797 2011-08-17 Chong Yidong <cyd@stupidchicken.com>
1799 * eval.c (internal_condition_case, internal_condition_case_1)
1800 (internal_condition_case_2, internal_condition_case_n):
1801 Remove unnecessary aborts (Bug#9081).
1803 2011-08-17 Eli Zaretskii <eliz@gnu.org>
1805 * lread.c (Fload) [DOS_NT]: If `openp' returns -2, but the file
1806 has no `load' handler, try opening the file locally. (Bug#9311)
1808 2011-08-16 Ken Brown <kbrown@cornell.edu>
1810 * gmalloc.c: Expand comment.
1812 2011-08-16 Eli Zaretskii <eliz@gnu.org>
1814 * xdisp.c (set_cursor_from_row): Don't accept a previous candidate
1815 if it fails the cursor_row_p test. Fixes cursor positioning at ZV.
1817 2011-08-16 Ken Brown <kbrown@cornell.edu>
1819 Fix memory allocation problems in Cygwin build (Bug#9273).
1821 * unexcw.c ( __malloc_initialized): Declare external variable.
1822 (fixup_executable): Force the dumped emacs to reinitialize malloc.
1824 * gmalloc.c [CYGWIN] (bss_sbrk_heapbase, bss_sbrk_heapinfo):
1826 (malloc_initialize_1) [CYGWIN]: Prepare for reinitializing the
1828 (_free_internal_nolock) [CYGWIN]: Ignore requests to free storage
1830 [CYGWIN] (special_realloc): New function.
1831 (_realloc_internal_nolock) [CYGWIN]: Use the new function on
1832 requests to realloc storage in the static heap.
1834 2011-08-15 Paul Eggert <eggert@cs.ucla.edu>
1836 * bidi.c (bidi_initialize): Remove unused local.
1838 2011-08-15 Eli Zaretskii <eliz@gnu.org>
1841 * biditype.h: Remove file.
1842 * makefile.w32-in ($(BLD)/bidi.$(O)):
1843 * deps.mk (bidi.o): Remove biditype.h and bidimirror.h.
1845 * dispextern.h: Fix a typo in the comment to bidi_type_t.
1847 * chartab.c: Improve commentary for the uniprop_table API.
1849 * bidi.c (bidi_paragraph_init): Support zero value of
1850 bidi_ignore_explicit_marks_for_paragraph_level.
1851 (bidi_initialize): Use uniprop_table instead of including
1852 biditype.h and bidimirror.h.
1854 * xdisp.c (move_it_in_display_line_to): Don't reset pixel
1855 coordinates of the iterator when restoring from ppos_it.
1858 2011-08-14 Kenichi Handa <handa@m17n.org>
1860 * process.c (create_process): Call setup_process_coding_systems
1861 after the pid of the process is set to -1 (Bug#8162).
1863 2011-08-14 Eli Zaretskii <eliz@gnu.org>
1865 * xdisp.c (move_it_in_display_line_to): Don't invoke
1866 IT_RESET_X_ASCENT_DESCENT when iterator position was restored from
1867 ppos_it. Fixes vertical cursor motion when line beginning is
1868 covered by an image. (Bug#9296)
1870 2011-08-14 Jan Djärv <jan.h.d@swipnet.se>
1872 * nsterm.h (ns_run_ascript): Declare.
1873 (NSAPP_DATA2_RUNASSCRIPT): Define.
1875 * nsfns.m (as_script, as_result, as_status): New static variables.
1876 (ns_run_ascript): New function.
1877 (Fns_do_applescript): Set variables as_*. Make an NSApplicationDefined
1878 event with data2 set to NSAPP_DATA2_RUNASSCRIPT, post it and then start
1879 the event loop. Get status from as_status (Bug#7276).
1881 * nsterm.m (sendEvent): If event is NSApplicationDefined and
1882 data2 is NSAPP_DATA2_RUNASSCRIPT, call ns_run_ascript and then exit
1883 the event loop (Bug#7276).
1885 2011-08-14 Andreas Schwab <schwab@linux-m68k.org>
1887 * gnutls.c (QCgnutls_bootprop_priority)
1888 (QCgnutls_bootprop_trustfiles, QCgnutls_bootprop_keylist)
1889 (QCgnutls_bootprop_crlfiles, QCgnutls_bootprop_callbacks)
1890 (QCgnutls_bootprop_loglevel, QCgnutls_bootprop_hostname)
1891 (QCgnutls_bootprop_min_prime_bits, QCgnutls_bootprop_verify_flags)
1892 (QCgnutls_bootprop_verify_hostname_error)
1893 (QCgnutls_bootprop_callbacks_verify): Rename from
1894 Qgnutls_bootprop_..., all uses changed.
1896 * xfaces.c (QCignore_defface): Rename from Qignore_defface, all
1899 2011-08-14 Paul Eggert <eggert@cs.ucla.edu>
1901 * xfaces.c (Qframe_set_background_mode): Now static.
1902 * dispextern.h (Qframe_set_background_mode): Remove decl.
1904 * process.c (Fnetwork_interface_info): Declare local only if needed.
1906 2011-08-13 Jan Djärv <jan.h.d@swipnet.se>
1908 * process.c: Include ifaddrs.h and net/if_dl.h if available (Bug#8477).
1909 (Fnetwork_interface_list): Allocate in increments of bytes instead
1910 of sizeof (struct ifreq). Iterate over ifconf.ifc_req by counting
1911 bytes (Bug#8477). Count bytes correctly when ifr_addr is a struct
1913 (struct ifflag_def): notrailers is smart on OSX.
1914 (Fnetwork_interface_info): Handle case when ifr_flags is negative.
1915 Get hardware address with getifaddrs if available.
1917 2011-08-12 Eli Zaretskii <eliz@gnu.org>
1919 * xdisp.c (iterate_out_of_display_property): xassert that
1920 IT->position is set to within IT->object's boundaries. Break from
1921 the loop as soon as EOB is reached; avoids infloops in redisplay
1922 when IT->position is set up wrongly due to some bug.
1923 Set IT->current to match the bidi iterator unconditionally.
1924 (push_display_prop): Allow GET_FROM_STRING as IT->method on
1925 entry. Force push_it to save on the stack the current
1926 buffer/string position, to be restored by pop_it. Fix flags in
1927 the iterator structure wrt the object coming from a display
1928 property, as `line-prefix' and `wrap-prefix' are not ``replacing''
1929 properties. (Bug#9284)
1931 2011-08-09 Andreas Schwab <schwab@linux-m68k.org>
1933 * fontset.c (fontset_get_font_group): Add proper type checks.
1936 2011-08-09 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
1938 * unexmacosx.c (print_load_command_name): Add cases LC_FUNCTION_STARTS
1939 and LC_VERSION_MIN_MACOSX.
1940 (copy_linkedit_data) [LC_FUNCTION_STARTS]: New function.
1941 (dump_it) [LC_FUNCTION_STARTS]: Use it.
1943 2011-08-08 Eli Zaretskii <eliz@gnu.org>
1945 * xdisp.c (forward_to_next_line_start): Allow to use the
1946 no-display-properties-and-no-overlays under bidi display.
1947 Set disp_pos in the bidi iterator to avoid searches for display
1948 properties and overlays.
1950 2011-08-08 Chong Yidong <cyd@stupidchicken.com>
1952 * editfns.c (Fset_time_zone_rule): Document relationship with the
1955 * ftfont.c (ftfont_pattern_entity): Copy the extras argument to
1956 the font entity extracted from the cache (Bug#8109).
1958 2011-08-07 Chong Yidong <cyd@stupidchicken.com>
1960 * composite.c (autocmp_chars): Don't reset point. That is done by
1961 restore_point_unwind (Bug#5984).
1963 2011-08-07 Juri Linkov <juri@jurta.org>
1965 * editfns.c (Fformat_time_string): Doc fix, add tag `usage:'
1966 to show the arg `TIME' instead of `TIMEVAL'.
1968 2011-08-06 Eli Zaretskii <eliz@gnu.org>
1970 * xdisp.c (set_cursor_from_row): Fix cursor positioning when a
1971 display property strides EOL and includes a newline, as in
1972 longlines-mode. (Bug#9254)
1973 (move_it_in_display_line_to): Fix vertical-motion in a buffer with
1974 word-wrap under bidirectional display. (Bug#9224)
1976 * bidi.c (bidi_unshelve_cache): Don't reset the cache if JUST_FREE
1977 is non-zero, even if the data buffer is NULL. Fixes a crash in
1978 vertical-motion with longlines-mode. (Bug#9254)
1980 2011-08-05 Eli Zaretskii <eliz@gnu.org>
1982 * bidi.c <bidi_cache_total_alloc>: Now static.
1983 (bidi_initialize): Initialize bidi_cache_total_alloc.
1985 * xdisp.c (display_line): Release buffer allocated for shelved bidi
1988 * bidi.c (bidi_shelve_cache, bidi_unshelve_cache): Track total
1989 amount allocated this far in `bidi_cache_total_alloc'.
1990 (bidi_unshelve_cache): Accept an additional argument JUST_FREE; if
1991 non-zero, only free the data buffer without restoring the cache
1992 contents. All callers changed.
1994 * dispextern.h (bidi_unshelve_cache): Update prototype.
1996 * xdisp.c (SAVE_IT, pos_visible_p, move_it_in_display_line_to)
1997 (move_it_in_display_line, move_it_to)
1998 (move_it_vertically_backward, move_it_by_lines): Replace the call
1999 to xfree to an equivalent call to bidi_unshelve_cache.
2000 (move_it_in_display_line_to): Fix logic of returning
2001 MOVE_POS_MATCH_OR_ZV in the bidi case. (Bug#9224)
2003 2011-08-05 Eli Zaretskii <eliz@gnu.org>
2005 * xdisp.c (set_cursor_from_row): Prefer the candidate glyph that
2006 came from a string character with a `cursor' property. (Bug#9229)
2008 2011-08-04 Jan Djärv <jan.h.d@swipnet.se>
2010 * Makefile.in (LIB_PTHREAD): New variable.
2011 (LIBES): Add LIB_PTHREAD (Bug#9216).
2013 * alloc.c, emacs.c, gmalloc.c, gtkutil.c, keyboard.c, syssignal.h:
2014 Rename HAVE_GTK_AND_PTHREAD to HAVE_PTHREAD (Bug#9216).
2016 2011-08-04 Andreas Schwab <schwab@linux-m68k.org>
2018 * regex.c (re_iswctype): Remove some redundant boolean conversions.
2020 2011-08-04 Jan Djärv <jan.h.d@swipnet.se>
2022 * xterm.c (x_find_topmost_parent): New function.
2023 (x_set_frame_alpha): Find topmost parent window with
2024 x_find_topmost_parent and set the property there also (bug#9181).
2025 (handle_one_xevent): Call x_set_frame_alpha on ReparentNotify.
2027 2011-08-04 Paul Eggert <eggert@cs.ucla.edu>
2029 * callproc.c (Fcall_process): Avoid vfork clobbering
2030 the local vars buffer, coding_systems, current_dir.
2032 2011-08-03 Stefan Monnier <monnier@iro.umontreal.ca>
2034 * keymap.c (Fmake_composed_keymap): Move to subr.el.
2036 2011-08-03 Paul Eggert <eggert@cs.ucla.edu>
2038 * fontset.c (dump_fontset) [FONTSET_DEBUG]: Declare EXTERNALLY_VISIBLE
2039 so that it is not optimized away.
2041 * xdisp.c (compute_display_string_pos): Remove unused local.
2043 2011-08-02 Eli Zaretskii <eliz@gnu.org>
2045 Fix slow cursor motion and scrolling in large buffers with
2046 selective display, like Org Mode buffers. (Bug#9218)
2048 * dispextern.h (struct bidi_it): New member disp_prop_p.
2050 * xdisp.c: Remove one-slot cache of display string positions.
2051 (compute_display_string_pos): Accept an additional argument
2052 DISP_PROP_P; callers changed. Scan at most 5K characters forward
2053 for a display string or property. If found, set DISP_PROP_P
2056 * bidi.c (bidi_fetch_char): Accept an additional argument
2057 DISP_PROP_P, and pass it to compute_display_string_pos.
2058 Only handle text covered by a display string if DISP_PROP_P is returned
2059 non-zero. All callers of bidi_fetch_char changed.
2061 2011-08-02 Stefan Monnier <monnier@iro.umontreal.ca>
2063 * keymap.c (Fdefine_key): Fix Lisp_Object/int mixup; apply some CSE.
2065 2010-12-03 Don March <don@ohspite.net>
2067 * keymap.c (Fdefine_key): Fix non-prefix key error message when
2068 last character M-[char] is translated to ESC [char] (bug#7541).
2070 2011-08-02 Kenichi Handa <handa@m17n.org>
2072 * lisp.h (uniprop_table): Extern it.
2074 * chartab.c (uniprop_table): Make it non-static.
2076 2011-08-01 Eli Zaretskii <eliz@gnu.org>
2078 * xdisp.c (forward_to_next_line_start): Accept additional argument
2079 BIDI_IT_PREV, and store into it the state of the bidi iterator had
2081 (reseat_at_next_visible_line_start): Use the bidi iterator state
2082 returned by forward_to_next_line_start to restore the state of
2083 it->bidi_it after backing up to previous newline. (Bug#9212)
2085 2011-07-30 Andreas Schwab <schwab@linux-m68k.org>
2087 * regex.c (re_comp): Protoize.
2088 (re_exec): Fix return type.
2089 (regexec): Fix type of `ret'. (Bug#9203)
2091 2011-07-28 Paul Eggert <eggert@cs.ucla.edu>
2093 * image.c (check_image_size): Use 1024x1024 if unknown frame (Bug#9189).
2094 This is needed if max-image-size is a floating-point number.
2096 2011-07-28 Andreas Schwab <schwab@linux-m68k.org>
2098 * print.c (print_object): Print empty symbol as ##.
2100 * lread.c (read1): Read ## as empty symbol.
2102 2011-07-28 Alp Aker <alp.tekin.aker@gmail.com>
2104 * nsfns.m (x_set_foreground_color): Set f->foreground_pixel when
2105 setting frame foreground color (Bug#9175).
2106 (x_set_background_color): Likewise.
2108 * nsmenu.m (-setText): Size tooltip dimensions precisely to
2109 contents (Bug#9176).
2110 (EmacsTooltip -init): Remove bezels and add shadows to
2113 * nsterm.m (ns_dumpglyphs_stretch): Avoid overwriting left fringe
2114 or scroll bar (Bug#8470).
2116 * nsfont.m (nsfont_open): Remove assignment to voffset and
2117 unnecessary vars hshink, expand, hd, full_height, min_height.
2118 (nsfont_draw): Use s->ybase as baseline for glyph drawing (Bug#8913).
2120 * nsterm.h (nsfont_info): Remove voffset field.
2122 2011-07-28 Alp Aker <alp.tekin.aker@gmail.com>
2124 Implement strike-through and overline on NextStep (Bug#8863).
2126 * nsfont.m (nsfont_open): Use underline position provided by font,
2127 instead of hard-coded value of 2.
2128 (nsfont_draw): Call ns_draw_text_decoration instead.
2130 * nsterm.h: Add declaration for ns_draw_text_decoration.
2132 * nsterm.m (ns_draw_text_decoration): New function for drawing
2133 underline, overline, and strike-through.
2134 (ns_dumpglyphs_image, ns_dumpglyphs_stretch): Add call to
2135 ns_draw_text_decoration. Change treatment of cursor drawing to
2136 accommodate underlining, etc.
2138 2011-07-28 Eli Zaretskii <eliz@gnu.org>
2140 * buffer.c (init_buffer_once): Set bidi-display-reordering to t by
2143 2011-07-28 Paul Eggert <eggert@cs.ucla.edu>
2145 * alloc.c (memory_full) [!SYNC_INPUT]: Fix signal-related race.
2146 Without this fix, if a signal arrives just after memory fills up,
2147 'malloc' might be invoked reentrantly.
2149 * image.c (x_check_image_size) [!HAVE_X_WINDOWS]: Return 1.
2150 In other words, assume that every image size is allowed, on non-X
2151 hosts. This assumption is probably wrong, but it lets Emacs compile.
2153 2011-07-28 Andreas Schwab <schwab@linux-m68k.org>
2155 * regex.c (re_iswctype): Convert return values to boolean.
2157 2011-07-28 Eli Zaretskii <eliz@fencepost.gnu.org>
2159 * xdisp.c (compute_display_string_pos): Don't use cached display
2160 string position if the buffer had its restriction changed.
2163 2011-07-28 Paul Eggert <eggert@cs.ucla.edu>
2165 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
2167 2011-07-28 Paul Eggert <eggert@cs.ucla.edu>
2169 Integer signedness and overflow and related fixes. (Bug#9079)
2171 * bidi.c: Integer size and overflow fixes.
2172 (bidi_cache_size, bidi_cache_idx, bidi_cache_last_idx)
2173 (bidi_cache_start, bidi_cache_fetch_state, bidi_cache_search)
2174 (bidi_cache_find_level_change, bidi_cache_ensure_space)
2175 (bidi_cache_iterator_state, bidi_cache_find, bidi_cache_start_stack)
2176 (bidi_find_other_level_edge):
2177 Use ptrdiff_t instead of EMACS_INT where either will do.
2178 This works better on 32-bit hosts configured --with-wide-int.
2179 (bidi_cache_ensure_space): Check for size-calculation overflow.
2180 Use % rather than repeated addition, for better worst-case speed.
2181 Don't set bidi_cache_size until after xrealloc returns, because it
2183 (bidi_dump_cached_states): Use ptrdiff_t, not int, to avoid overflow.
2184 (bidi_cache_ensure_space): Also check that the bidi cache size
2185 does not exceed that of the largest Lisp string or buffer. See Eli
2186 Zaretskii in <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9079#29>.
2188 * alloc.c (__malloc_size_t): Remove.
2189 All uses replaced by size_t. See Andreas Schwab's note
2190 <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9079#8>.
2192 * image.c: Improve checking for integer overflow.
2193 (check_image_size): Assume that f is nonnull, since
2194 it is always nonnull in practice. This is one less thing to
2195 worry about when checking for integer overflow later.
2196 (x_check_image_size): New function, which checks for integer
2197 overflow issues inside X.
2198 (x_create_x_image_and_pixmap, xbm_read_bitmap_data): Use it.
2199 This removes the need for a memory_full check.
2200 (xbm_image_p): Rewrite to avoid integer multiplication overflow.
2201 (Create_Pixmap_From_Bitmap_Data, xbm_load): Use x_check_image_size.
2202 (xbm_read_bitmap_data): Change locals back to 'int', since
2203 their values must fit in 'int'.
2204 (xpm_load_image, png_load, tiff_load):
2205 Invoke x_create_x_image_and_pixmap earlier,
2206 to avoid much needless work if the image is too large.
2207 (tiff_load): Treat overly large images as if
2208 x_create_x_image_and_pixmap failed, not as malloc failures.
2209 (gs_load): Use x_check_image_size.
2211 * gtkutil.c: Omit integer casts.
2212 (xg_get_pixbuf_from_pixmap): Remove unnecessary cast.
2213 (xg_set_toolkit_scroll_bar_thumb): Rewrite to avoid need for cast.
2215 * image.c (png_load): Don't assume height * row_bytes fits in 'int'.
2217 * xfaces.c (Fbitmap_spec_p): Fix integer overflow bug.
2218 Without this fix, (bitmap-spec-p '(34359738368 1 "x"))
2219 would wrongly return t on a 64-bit host.
2221 * dispnew.c (init_display): Use *_RANGE_OVERFLOW macros.
2222 The plain *_OVERFLOW macros run afoul of GCC bug 49705
2223 <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=49705>
2224 and therefore cause GCC to emit a bogus diagnostic in some cases.
2226 * image.c: Integer signedness and overflow and related fixes.
2227 This is not an exhaustive set of fixes, but it's time to
2228 record what I've got.
2229 (lookup_pixel_color, check_image_size): Remove redundant decls.
2230 (check_image_size): Don't assume that arbitrary EMACS_INT values
2231 fit in 'int', or that arbitrary 'double' values fit in 'int'.
2232 (x_alloc_image_color, x_create_x_image_and_pixmap, png_load)
2233 (tiff_load, imagemagick_load_image):
2234 Check for overflow in size calculations.
2235 (x_create_x_image_and_pixmap): Remove unnecessary test for
2236 xmalloc returning NULL; that can't happen.
2237 (xbm_read_bitmap_data): Don't assume sizes fit into 'int'.
2238 (xpm_color_bucket): Use better integer hashing function.
2239 (xpm_cache_color): Don't possibly over-allocate memory.
2240 (struct png_memory_storage, tiff_memory_source, tiff_seek_in_memory)
2241 (gif_memory_source):
2242 Use ptrdiff_t, not int or size_t, to record sizes.
2243 (png_load): Don't assume values greater than 2**31 fit in 'int'.
2244 (our_stdio_fill_input_buffer): Prefer ptrdiff_t to size_t when
2245 either works, as we prefer signed integers.
2246 (tiff_read_from_memory, tiff_write_from_memory):
2247 Return tsize_t, not size_t, since that's what the TIFF API wants.
2248 (tiff_read_from_memory): Don't fail simply because the read would
2249 go past EOF; instead, return a short read.
2250 (tiff_load): Omit no-longer-needed casts.
2251 (Fimagemagick_types): Don't assume size fits into 'int'.
2253 Improve hashing quality when configured --with-wide-int.
2254 * fns.c (hash_string): New function, taken from sxhash_string.
2255 Do not discard information about ASCII character case; this
2256 discarding is no longer needed.
2257 (sxhash-string): Use it. Change sig to match it. Caller changed.
2258 * lisp.h: Declare it.
2259 * lread.c (hash_string): Remove, since we now use fns.c's version.
2260 The fns.c version returns a wider integer if --with-wide-int is
2261 specified, so this should help the quality of the hashing a bit.
2263 * emacs.c: Integer overflow minor fix.
2264 (heap_bss_diff): Now uprintmax_t, not unsigned long. All used changed.
2265 Define only if GNU_LINUX.
2266 (main, Fdump_emacs): Set and use heap_bss_diff only if GNU_LINUX.
2268 * dispnew.c: Integer signedness and overflow fixes.
2269 Remove unnecessary forward decls, that were a maintenance hassle.
2270 (history_tick): Now uprintmax_t, so it's more likely to avoid overflow.
2272 (adjust_glyph_matrix, realloc_glyph_pool, adjust_frame_message_buffer)
2273 (scrolling_window): Use ptrdiff_t, not int, for byte count.
2274 (prepare_desired_row, line_draw_cost):
2275 Use int, not unsigned, where either works.
2276 (save_current_matrix, restore_current_matrix):
2277 Use ptrdiff_t, not size_t, where either works.
2278 (init_display): Check for overflow more accurately, and without
2279 relying on undefined behavior.
2281 * editfns.c (pWIDE, pWIDElen, signed_wide, unsigned_wide):
2282 Remove, replacing with the new symbols in lisp.h. All uses changed.
2283 * fileio.c (make_temp_name):
2284 * filelock.c (lock_file_1, lock_file):
2285 * xdisp.c (message_dolog):
2286 Don't assume PRIdMAX etc. works; this isn't portable to pre-C99 hosts.
2287 Use pMd etc. instead.
2288 * lisp.h (printmax_t, uprintmax_t, pMd, pMu): New types and macros,
2289 replacing the pWIDE etc. symbols removed from editfns.c.
2291 * keyboard.h (num_input_events): Now uintmax_t.
2292 This is (very slightly) less likely to mess up due to wraparound.
2295 * buffer.c: Integer signedness fixes.
2296 (alloc_buffer_text, enlarge_buffer_text):
2297 Use ptrdiff_t rather than size_t when either will do, as we prefer
2300 * alloc.c: Integer signedness and overflow fixes.
2301 Do not impose an arbitrary 32-bit limit on malloc sizes when debugging.
2302 (__malloc_size_t): Default to size_t, not to int.
2303 (pure_size, pure_bytes_used_before_overflow, stack_copy_size)
2304 (Fgarbage_collect, mark_object_loop_halt, mark_object):
2305 Prefer ptrdiff_t to size_t when either would do, as we prefer
2307 (XMALLOC_OVERRUN_CHECK_OVERHEAD): New macro.
2308 (xmalloc_overrun_check_header, xmalloc_overrun_check_trailer):
2309 Now const. Initialize with values that are in range even if char
2311 (XMALLOC_PUT_SIZE, XMALLOC_GET_SIZE): Remove, replacing with ...
2312 (xmalloc_put_size, xmalloc_get_size): New functions. All uses changed.
2313 These functions do the right thing with sizes > 2**32.
2314 (check_depth): Now ptrdiff_t, not int.
2315 (overrun_check_malloc, overrun_check_realloc, overrun_check_free):
2316 Adjust to new way of storing sizes. Check for size overflow bugs
2318 (STRING_BYTES_MAX): Adjust to new overheads. The old code was
2319 slightly wrong anyway, as it missed one instance of
2320 XMALLOC_OVERRUN_CHECK_OVERHEAD.
2321 (refill_memory_reserve): Omit needless cast to size_t.
2322 (mark_object_loop_halt): Mark as externally visible.
2324 * xselect.c: Integer signedness and overflow fixes.
2325 (Fx_register_dnd_atom, x_handle_dnd_message):
2326 Use ptrdiff_t, not size_t, since we prefer signed.
2327 (Fx_register_dnd_atom): Check for ptrdiff_t (and size_t) overflow.
2328 * xterm.h (struct x_display_info): Use ptrdiff_t, not size_t, for
2329 x_dnd_atoms_size and x_dnd_atoms_length.
2331 * doprnt.c: Prefer signed to unsigned when either works.
2333 * doprnt.c (doprnt):
2335 * xdisp.c (vmessage):
2336 Use ptrdiff_t, not size_t, when using or implementing doprnt,
2337 since the sizes cannot exceed ptrdiff_t bounds anyway, and we
2338 prefer signed arithmetic to avoid comparison confusion.
2339 * doprnt.c (doprnt): Avoid a "+ 1" that can't overflow,
2340 but is a bit tricky.
2342 Assume freestanding C89 headers, string.h, stdlib.h.
2343 * data.c, doprnt.c, floatfns.c, print.c:
2344 Include float.h unconditionally.
2345 * gmalloc.c: Assume C89-at-least behavior for preprocessor,
2346 limits.h, stddef.h, string.h. Use memset instead of 'flood'.
2347 * regex.c: Likewise for stddef.h, string.h.
2348 (ISASCII): Remove; can assume it returns 1 now. All uses removed.
2349 * s/aix4-2.h (HAVE_STRING_H): Remove obsolete undef.
2350 * s/ms-w32.h (HAVE_LIMITS_H, HAVE_STRING_H, HAVE_STDLIB_H)
2351 (STDC_HEADERS): Remove obsolete defines.
2352 * sysdep.c: Include limits.h unconditionally.
2354 Assume support for memcmp, memcpy, memmove, memset.
2355 * lisp.h, sysdep.c (memcmp, memcpy, memmove, memset):
2356 * regex.c (memcmp, memcpy):
2357 Remove; we assume C89 now.
2359 * gmalloc.c (memcpy, memset, memmove): Remove; we assume C89 now.
2360 (__malloc_safe_bcopy): Remove; no longer needed.
2362 * lisp.h (struct vectorlike_header, struct Lisp_Subr): Signed sizes.
2363 Use EMACS_INT, not EMACS_UINT, for sizes. The code works equally
2364 well either way, and we prefer signed to unsigned.
2366 2011-07-27 Lars Magne Ingebrigtsen <larsi@gnus.org>
2368 * gnutls.c (emacs_gnutls_read): Don't message anything if the peer
2369 closes the connection while we're reading (bug#9182).
2371 2011-07-25 Jan Djärv <jan.h.d@swipnet.se>
2373 * nsmenu.m (ns_popup_dialog): Add an "ok" button if no buttons
2374 are specified (Bug#9168).
2376 2011-07-25 Paul Eggert <eggert@cs.ucla.edu>
2378 * bidi.c (bidi_dump_cached_states): Fix printf format mismatch.
2379 Found by GCC static checking and --with-wide-int on a 32-bit host.
2381 2011-07-25 Eli Zaretskii <eliz@gnu.org>
2383 * xdisp.c (compute_display_string_pos): Fix logic of caching
2384 previous display string position. Initialize cached_prev_pos to
2385 -1. Fixes slow-down at the beginning of a buffer.
2387 2011-07-24 Eli Zaretskii <eliz@gnu.org>
2389 * xfaces.c (check_lface_attrs) [HAVE_WINDOW_SYSTEM]: Allow `nil'
2390 for attrs[LFACE_FONTSET_INDEX].
2392 2011-07-23 Paul Eggert <eggert@cs.ucla.edu>
2394 * xml.c (parse_region): Remove unused local
2395 that was recently introduced.
2397 2011-07-23 Eli Zaretskii <eliz@gnu.org>
2399 * xfns.c (unwind_create_frame) [GLYPH_DEBUG]: Adapt to changes in
2400 2008-02-22T17:42:09Z!monnier@iro.umontreal.ca.
2402 * xdisp.c (move_it_in_display_line_to): Record the best matching
2403 position for TO_CHARPOS while scanning the line, and restore it on
2404 exit if none of the characters scanned was an exact match.
2405 Fixes vertical-motion and pos-visible-in-window-p under bidi redisplay
2406 when exact match is impossible due to invisible text, and the
2407 lines are truncated.
2409 2011-07-23 Jan Djärv <jan.h.d@swipnet.se>
2411 * nsterm.m (initFrameFromEmacs): Set NSTitledWindowMask in styleMask
2414 2011-07-22 Eli Zaretskii <eliz@gnu.org>
2416 Fix a significant slow-down of cursor motion with C-n, C-p,
2417 C-f/C-b, and C-v/M-v that couldn't keep up with keyboard
2418 auto-repeat under bidi redisplay in fontified buffers.
2419 * xdisp.c (compute_stop_pos_backwards): New function.
2420 (next_element_from_buffer): Call compute_stop_pos_backwards to
2421 find a suitable prev_stop when we find ourselves before
2423 (reseat): Don't look for prev_stop, as that could mean a very long
2425 <cached_disp_pos, cached_disp_buffer, cached_disp_modiff>
2426 <cached_disp_overlay_modiff>: Cache for last found display string
2428 (compute_display_string_pos): Return the cached position if asked
2429 about the same buffer in the same area of character positions, and
2430 the buffer wasn't changed since the time the display string
2431 position was cached.
2433 2011-07-22 Eli Zaretskii <eliz@gnu.org>
2435 * xdisp.c (rows_from_pos_range): Don't ignore glyphs whose object
2436 is an integer, which is important for empty lines. (Bug#9149)
2438 2011-07-22 Chong Yidong <cyd@stupidchicken.com>
2440 * frame.c (Fmodify_frame_parameters): In tty case, update the
2441 default face if necessary (Bug#4238).
2443 2011-07-21 Chong Yidong <cyd@stupidchicken.com>
2445 * editfns.c (Fstring_to_char): No need to explain what a character
2446 is in the docstring (Bug#6576).
2448 2011-07-20 Lars Magne Ingebrigtsen <larsi@gnus.org>
2450 * xml.c (parse_region): Make sure we always return a tree.
2452 2011-07-20 HAMANO Kiyoto <khiker.mail@gmail.com>
2454 * xml.c (parse_region): If a document contains only comments,
2457 2011-07-20 Lars Magne Ingebrigtsen <larsi@gnus.org>
2459 * xml.c (make_dom): Return comments, too.
2461 2011-07-19 Paul Eggert <eggert@cs.ucla.edu>
2464 See http://lists.gnu.org/archive/html/emacs-devel/2011-07/msg00688.html
2465 and the surrounding thread.
2466 * minibuf.c (read_minibuf_noninteractive): Rewrite to use getchar
2467 rather than fgets, and retry after EINTR. Otherwise, 'emacs
2468 --batch -f byte-compile-file' fails on OpenBSD if an inactivity
2470 * s/openbsd.h (BROKEN_SIGIO): Define.
2471 * unexelf.c (unexec) [__OpenBSD__]:
2472 Don't update the .mdebug section of the Alpha COFF symbol table.
2474 2011-07-19 Lars Magne Ingebrigtsen <larsi@gnus.org>
2476 * lread.c (syms_of_lread): Clarify when `lexical-binding' is used
2479 2011-07-18 Paul Eggert <eggert@cs.ucla.edu>
2481 * fileio.c (Fcopy_file) [!MSDOS]: Tighten created file's mask.
2482 This fixes some race conditions on the permissions of any newly
2485 * alloc.c (valid_pointer_p): Use pipe, not open.
2486 This fixes some permissions issues when debugging.
2488 * fileio.c (Fcopy_file): Adjust mode if fchown fails. (Bug#9002)
2489 If fchown fails to set both uid and gid, try to set just gid,
2490 as that is sometimes allowed. Adjust the file's mode to eliminate
2491 setuid or setgid bits that are inappropriate if fchown fails.
2493 2011-07-18 Stefan Monnier <monnier@iro.umontreal.ca>
2495 * xdisp.c (next_element_from_string, next_element_from_buffer): Use EQ
2496 to compare Lisp_Objects.
2497 * gnutls.c (syms_of_gnutls): Rename Vgnutls_log_level to
2498 global_gnutls_log_level, don't mistake it for a Lisp_Object.
2499 (init_gnutls_functions, emacs_gnutls_handle_error): Fix up uses.
2501 2011-07-17 Andreas Schwab <schwab@linux-m68k.org>
2503 * lread.c (read_integer): Unread even EOF character.
2504 (read1): Likewise. Properly record start position of symbol.
2506 * lread.c (read1): Read `#:' as empty uninterned symbol if no
2507 symbol character follows.
2509 2011-07-17 Paul Eggert <eggert@cs.ucla.edu>
2511 * fileio.c (Fcopy_file): Pacify gcc re fchown. (Bug#9002)
2512 This works around a problem with the previous change to Fcopy_file.
2513 Recent glibc declares fchown with __attribute__((warn_unused_result)),
2514 and without this change, GCC might complain about discarding
2515 fchown's return value.
2517 2011-07-16 Juanma Barranquero <lekktu@gmail.com>
2519 * makefile.w32-in (GLOBAL_SOURCES): Add gnutls.c (followup to bug#9059).
2521 2011-07-16 Paul Eggert <eggert@cs.ucla.edu>
2523 * fileio.c (Fcopy_file): Don't diagnose fchown failures. (Bug#9002)
2525 2011-07-16 Lars Magne Ingebrigtsen <larsi@gnus.org>
2527 * gnutls.c (syms_of_gnutls): Define `gnutls-log-level' here, since
2528 it's used from the C level.
2530 * process.c: Use the same condition for POLL_FOR_INPUT in both
2531 keyboard.c and process.c (bug#1858).
2533 2011-07-09 Lawrence Mitchell <wence@gmx.li>
2535 * gnutls.c (Qgnutls_bootprop_min_prime_bits): New variable.
2536 (Fgnutls_boot): Use it.
2538 2011-07-15 Andreas Schwab <schwab@linux-m68k.org>
2540 * doc.c (Fsubstitute_command_keys): Revert last change.
2542 2011-07-15 Lars Magne Ingebrigtsen <larsi@gnus.org>
2544 * doc.c (Fsubstitute_command_keys): Clarify that \= really only
2545 quotes the next character, and doesn't affect other longer
2546 sequences (bug#8935).
2548 * lread.c (syms_of_lread): Clarify that is isn't only
2549 `eval-buffer' and `eval-defun' that's affected by
2550 `lexical-binding' (bug#8460).
2552 2011-07-15 Eli Zaretskii <eliz@gnu.org>
2554 * xdisp.c (move_it_in_display_line_to): Fix vertical motion with
2555 bidi redisplay when a line includes both an image and is truncated.
2557 2011-07-14 Paul Eggert <eggert@cs.ucla.edu>
2559 Fix minor problems found by static checking.
2560 * bidi.c (bidi_cache_size): Now EMACS_INT, not size_t.
2561 (elsz): Now a signed constant, not a size_t var. We prefer signed
2562 types to unsigned, to avoid integer comparison confusion. Without
2563 this change, GCC 4.6.1 with -Wunsafe-loop-optimizations complains
2564 "cannot optimize loop, the loop counter may overflow", a symptom
2566 * indent.c (Fvertical_motion): Mark locals as initialized.
2567 * xdisp.c (reseat_to_string): Fix pointer signedness issue.
2569 2011-07-14 Lars Magne Ingebrigtsen <larsi@gnus.org>
2571 * search.c (Fre_search_backward): Mention `case-fold-search' in
2572 all the re_search_* functions (bug#8138).
2574 * keyboard.c (Fopen_dribble_file): Document when the file is
2577 2011-07-14 Eli Zaretskii <eliz@gnu.org>
2579 * bidi.c (bidi_dump_cached_states): Fix format of displaying
2582 Support bidi reordering of display and overlay strings.
2583 * xdisp.c (compute_display_string_pos)
2584 (compute_display_string_end): Accept additional argument STRING.
2585 (init_iterator, reseat_1): Initialize bidi_it->string.s to NULL.
2586 (reseat_to_string): Initialize bidi_it->string.s and
2587 bidi_it->string.schars.
2588 (Fcurrent_bidi_paragraph_direction): Initialize itb.string.s to
2589 NULL (avoids a crash in bidi_paragraph_init).
2590 Initialize itb.string.lstring.
2591 (init_iterator): Call bidi_init_it only of a valid
2592 buffer position was specified. Initialize paragraph_embedding to
2594 (reseat_to_string): Initialize the bidi iterator.
2595 (display_string): If we need to ignore text properties of
2596 LISP_STRING, set IT->stop_charpos to IT->end_charpos. (The
2597 original value of -1 will not work with bidi.)
2598 (compute_display_string_pos): First arg is now struct
2599 `text_pos *'; all callers changed. Support display properties on
2601 (compute_display_string_end): Support display properties on Lisp
2603 (init_iterator, reseat_1, reseat_to_string): Initialize the
2604 string.bufpos member to 0 (zero, for compatibility with IT_CHARPOS
2605 when iterating on a string not from display properties).
2606 (compute_display_string_pos, compute_display_string_end):
2607 Fix calculation of the object to scan. Fixes an error when using
2609 (next_element_from_buffer): Don't abort when IT_CHARPOS is before
2610 base_level_stop; instead, set base_level_stop to BEGV.
2611 Fixes crashes in vertical-motion.
2612 (next_element_from_buffer): Improve commentary for when
2613 the iterator is before prev_stop.
2614 (init_iterator): Initialize bidi_p from the default value of
2615 bidi-display-reordering, not from buffer-local value. Use the
2616 buffer-local value only if initializing for buffer iteration.
2617 (handle_invisible_prop): Support invisible properties on strings
2618 that are being bidi-reordered.
2619 (set_iterator_to_next): Support bidi reordering of C strings and
2621 (next_element_from_string): Support bidi reordering of Lisp
2623 (handle_stop_backwards): Support Lisp strings as well.
2624 (display_string): Support display of R2L glyph rows.
2625 Use IT_STRING_CHARPOS when displaying from a Lisp string.
2626 (init_iterator): Don't initialize it->bidi_p for strings
2628 (reseat_to_string): Initialize it->bidi_p for strings here.
2629 (next_element_from_string, next_element_from_c_string)
2630 (next_element_from_buffer): Add xassert's for correspondence
2631 between IT's object being iterated and it->bidi_it.string
2633 (face_before_or_after_it_pos): Support bidi iteration.
2634 (next_element_from_c_string): Handle the case of the first string
2635 character that is not the first one in the visual order.
2636 (get_visually_first_element): New function, refactored from common
2637 parts of next_element_from_buffer, next_element_from_string, and
2638 next_element_from_c_string.
2639 (tool_bar_lines_needed, redisplay_tool_bar)
2640 (display_menu_bar): Force left-to-right direction. Add a FIXME
2641 comment for making that be controlled by a user option.
2642 (push_it, pop_it): Save and restore the state of the
2643 bidi iterator. Save and restore the bidi_p flag.
2644 (pop_it): Iterate out of display property for string iteration as
2646 (iterate_out_of_display_property): Support iteration over strings.
2647 (handle_single_display_spec): Set up it->bidi_it for iteration
2648 over a display string, and call bidi_init_it.
2649 (handle_single_display_spec, next_overlay_string)
2650 (get_overlay_strings_1, push_display_prop): Set up the bidi
2651 iterator for displaying display or overlay strings.
2652 (forward_to_next_line_start): Don't use the shortcut if
2654 (back_to_previous_visible_line_start): If handle_display_prop
2655 pushed the iterator stack, restore the internal state of the bidi
2656 iterator by calling bidi_pop_it same number of times.
2657 (reseat_at_next_visible_line_start): If ON_NEWLINE_P is non-zero,
2658 and we are bidi-iterating, don't decrement the iterator position;
2659 instead, set the first_elt flag in the bidi iterator, to produce
2661 (reseat_1): Remove redundant setting of string_from_display_prop_p.
2662 (push_display_prop): xassert that we are iterating a buffer.
2663 (push_it, pop_it): Save and restore paragraph_embedding member.
2664 (handle_single_display_spec, next_overlay_string)
2665 (get_overlay_strings_1, reseat_1, reseat_to_string)
2666 (push_display_prop): Set up the `unibyte' member of bidi_it.string
2667 correctly. Don't assume unibyte strings are not bidi-reordered.
2668 (compute_display_string_pos)
2669 (compute_display_string_end): Fix handling the case of C string.
2670 (push_it, pop_it): Save and restore from_disp_prop_p.
2671 (handle_single_display_spec, push_display_prop): Set the
2672 from_disp_prop_p flag.
2673 (get_overlay_strings_1): Reset the from_disp_prop_p flag.
2674 (pop_it): Call iterate_out_of_display_property only if we are
2675 popping after iteration over a string that came from a display
2676 property. Fix a typo in popping stretch info. Add an assertion
2677 for verifying that the iterator position is in sync with the bidi
2679 (handle_single_display_spec, get_overlay_strings_1)
2680 (push_display_prop): Fix initialization of paragraph direction for
2681 string when that of the parent object is not yet determined.
2682 (reseat_1): Call bidi_init_it to resync the bidi
2683 iterator with IT's position. (Bug#7616)
2684 (find_row_edges): If ROW->start.pos gives position
2685 smaller than min_pos, use it as ROW->minpos. (Bug#7616)
2686 (handle_stop, back_to_previous_visible_line_start, reseat_1):
2687 Reset the from_disp_prop_p flag.
2688 (SAVE_IT, RESTORE_IT): New macros.
2689 (pos_visible_p, face_before_or_after_it_pos)
2690 (back_to_previous_visible_line_start)
2691 (move_it_in_display_line_to, move_it_in_display_line)
2692 (move_it_to, move_it_vertically_backward, move_it_by_lines)
2693 (try_scrolling, redisplay_window, display_line): Use them when
2694 saving a temporary copy of the iterator and restoring it back.
2695 (back_to_previous_visible_line_start, reseat_1)
2696 (init_iterator): Empty the bidi cache "stack".
2697 (move_it_in_display_line_to): If iterator ended up at
2698 EOL, but we never saw any buffer positions smaller than
2699 to_charpos, return MOVE_POS_MATCH_OR_ZV. Fixes vertical cursor
2700 motion in bidi-reordered lines.
2701 (move_it_in_display_line_to): Record prev_method and prev_pos
2702 immediately before the call to set_iterator_to_next. Fixes cursor
2703 motion in bidi-reordered lines with stretch glyphs and strings
2704 displayed in margins. (Bug#8133) (Bug#8867)
2705 Return MOVE_POS_MATCH_OR_ZV only if iterator position is past
2707 (pos_visible_p): Support positions in bidi-reordered lines.
2708 Save and restore bidi cache.
2710 * bidi.c (bidi_level_of_next_char): clen should be EMACS_NT, not int.
2711 (bidi_paragraph_info): Delete unused struct.
2712 (bidi_cache_idx, bidi_cache_last_idx): Declare EMACS_INT.
2713 (bidi_cache_start): New variable.
2714 (bidi_cache_reset): Reset bidi_cache_idx to bidi_cache_start, not
2716 (bidi_cache_fetch_state, bidi_cache_search)
2717 (bidi_cache_find_level_change, bidi_cache_iterator_state)
2718 (bidi_cache_find, bidi_peek_at_next_level)
2719 (bidi_level_of_next_char, bidi_find_other_level_edge)
2720 (bidi_move_to_visually_next): Compare cache index with
2721 bidi_cache_start rather than with zero.
2722 (bidi_fetch_char): Accept new argument STRING; all callers
2723 changed. Support iteration over a string. Support strings with
2724 display properties. Support unibyte strings. Fix the type of
2725 `len' according to what STRING_CHAR_AND_LENGTH expects.
2726 (bidi_paragraph_init, bidi_resolve_explicit_1)
2727 (bidi_resolve_explicit, bidi_resolve_weak)
2728 (bidi_level_of_next_char, bidi_move_to_visually_next):
2729 Support iteration over a string.
2730 (bidi_set_sor_type, bidi_resolve_explicit_1)
2731 (bidi_resolve_explicit, bidi_type_of_next_char): ignore_bn_limit
2732 can now be zero (for strings); special values 0 and -1 were
2733 changed to -1 and -2, respectively.
2734 (bidi_char_at_pos): New function.
2735 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak):
2736 Call it instead of FETCH_MULTIBYTE_CHAR.
2737 (bidi_move_to_visually_next): Abort if charpos or bytepos were not
2738 initialized to valid values.
2739 (bidi_init_it): Don't initialize charpos and bytepos with invalid
2741 (bidi_level_of_next_char): Allow the sentinel "position" to pass
2742 the test for valid cached positions. Fix the logic for looking up
2743 the sentinel state in the cache. GCPRO the Lisp string we are
2745 (bidi_push_it, bidi_pop_it): New functions.
2746 (bidi_initialize): Initialize the bidi cache start stack pointer.
2747 (bidi_cache_ensure_space): New function, refactored from part of
2748 bidi_cache_iterator_state. Don't assume the required size is just
2749 one BIDI_CACHE_CHUNK away.
2750 (bidi_cache_start_stack, bidi_push_it): Use IT_STACK_SIZE.
2751 (bidi_count_bytes, bidi_char_at_pos): New functions.
2752 (bidi_cache_search): Don't assume bidi_cache_last_idx is
2753 always valid if bidi_cache_idx is valid.
2754 (bidi_cache_find_level_change): xassert that bidi_cache_last_idx
2755 is valid if it's going to be used.
2756 (bidi_shelve_cache, bidi_unshelve_cache): New functions.
2757 (bidi_cache_fetch_state, bidi_cache_search)
2758 (bidi_cache_find_level_change, bidi_cache_ensure_space)
2759 (bidi_cache_iterator_state, bidi_cache_find)
2760 (bidi_find_other_level_edge, bidi_cache_start_stack):
2761 All variables related to cache indices are now EMACS_INT.
2763 * dispextern.h (struct bidi_string_data): New structure.
2764 (struct bidi_it): New member `string'. Make flag members be 1-bit
2765 fields, and put them last in the struct.
2766 (compute_display_string_pos, compute_display_string_end):
2768 (bidi_push_it, bidi_pop_it): Add prototypes.
2769 (struct iterator_stack_entry): New members bidi_p,
2770 paragraph_embedding, and from_disp_prop_p.
2771 (struct it): Member bidi_p is now a bit field 1 bit wide.
2772 (bidi_shelve_cache, bidi_unshelve_cache):
2775 * .gdbinit (xvectype, xvector, xcompiled, xchartable, xboolvector)
2776 (xpr, xfont, xbacktrace): Use "header.size" when accessing vectors
2777 and vector-like objects.
2779 * dispnew.c (buffer_posn_from_coords): Save and restore the bidi
2780 cache around display iteration.
2782 * window.c (Fwindow_end, window_scroll_pixel_based)
2783 (displayed_window_lines, Frecenter): Save and restore the bidi
2784 cache around display iteration.
2786 2011-07-14 Lars Magne Ingebrigtsen <larsi@gnus.org>
2788 * editfns.c (Fdelete_region): Clarify the use of the named
2789 parameters (bug#6788).
2791 2011-07-14 Martin Rudalics <rudalics@gmx.at>
2793 * indent.c (Fvertical_motion): Set and restore w->pointm when
2794 saving and restoring the window's buffer (Bug#9006).
2796 2011-07-13 Lars Magne Ingebrigtsen <larsi@gnus.org>
2798 * editfns.c (Fstring_to_char): Clarify just what is returned
2799 (bug#6576). Text by Eli Zaretskii.
2801 2011-07-13 Juanma Barranquero <lekktu@gmail.com>
2803 * gnutls.c (init_gnutls_functions): Honor gnutls_log_level (bug#9059).
2805 2011-07-13 Eli Zaretskii <eliz@gnu.org>
2807 * buffer.c (mmap_find): Fix a typo.
2809 2011-07-13 Johan Bockgård <bojohan@gnu.org>
2811 Fix execution of x selection hooks.
2812 * xselect.c (Qx_lost_selection_functions)
2813 (Qx_sent_selection_functions): New vars.
2814 (syms_of_xselect): DEFSYM them.
2815 (x_handle_selection_request): Pass Qx_sent_selection_functions
2816 rather than Vx_sent_selection_functions to Frun_hook_with_args.
2817 (x_handle_selection_clear,x_clear_frame_selections):
2818 Pass Qx_lost_selection_functions rather than
2819 Vx_lost_selection_functions to Frun_hook_with_args.
2821 2011-07-13 Paul Eggert <eggert@cs.ucla.edu>
2823 * buffer.c (Fget_buffer_create): Initialize inhibit_shrinking.
2824 The old code sometimes used this field without initializing it.
2826 * alloc.c (gc_sweep): Don't read past end of array.
2827 In theory, the old code could also have corrupted Emacs internals,
2828 though it'd be very unlikely.
2830 2011-07-12 Andreas Schwab <schwab@linux-m68k.org>
2832 * character.c (Fcharacterp): Don't advertise optional ignored
2833 argument. (Bug#4026)
2835 2011-07-12 Lars Magne Ingebrigtsen <larsi@gnus.org>
2837 * keymap.c (syms_of_keymap): Clarify that "modifier" is "modifier
2840 * window.c (Fset_window_start): Doc fix (bug#4199).
2841 (Fset_window_hscroll): Ditto.
2843 2011-07-12 Paul Eggert <eggert@cs.ucla.edu>
2845 Fix minor new problems caught by GCC 4.6.1.
2846 * term.c (init_tty): Remove unused local.
2847 * xsettings.c (store_monospaced_changed): Define this function only
2848 if (defined HAVE_GSETTINGS || defined HAVE_GCONF), as it's
2851 2011-07-12 Chong Yidong <cyd@stupidchicken.com>
2853 * xdisp.c (Vresize_mini_windows): Minor doc fix (Bug#3300).
2855 2011-07-11 Lars Magne Ingebrigtsen <larsi@gnus.org>
2857 * xdisp.c (syms_of_xdisp): Make it explicit that the mini-windows
2858 are the mini-buffer and the echo area (bug#3320).
2860 * term.c (init_tty): Remove support for supdup, c10 and perq
2861 terminals, which are no longer supported (bug#1482).
2863 2011-07-10 Johan Bockgård <bojohan@gnu.org>
2865 * xdisp.c (Ftool_bar_lines_needed): Fix WINDOWP check.
2867 2011-07-10 Jan Djärv <jan.h.d@swipnet.se>
2869 * xmenu.c (menu_highlight_callback): Only pass frame to show_help_event
2870 for non-popups (Bug#3642).
2872 2011-07-10 Andreas Schwab <schwab@linux-m68k.org>
2874 * alloc.c (reset_malloc_hooks): Protoize.
2875 * buffer.c (mmap_init, mmap_find, mmap_free_1, mmap_enlarge)
2876 (mmap_set_vars, mmap_alloc, mmap_free, mmap_realloc): Likewise.
2877 * cm.c (losecursor): Likewise.
2878 * data.c (fmod): Likewise.
2879 * dispnew.c (swap_glyphs_in_rows): Likewise.
2880 * emacs.c (memory_warning_signal): Likewise.
2881 * floatfns.c (float_error): Likewise.
2882 * font.c (check_gstring, check_otf_features, otf_tag_symbol)
2883 (otf_open, font_otf_capability, generate_otf_features)
2884 (font_otf_DeviceTable, font_otf_ValueRecord, font_otf_Anchor):
2886 * image.c (pbm_read_file): Likewise.
2887 * indent.c (string_display_width): Likewise.
2888 * intervals.c (check_for_interval, search_for_interval)
2889 (inc_interval_count, count_intervals, root_interval)
2890 (adjust_intervals_for_insertion, make_new_interval): Likewise.
2891 * lread.c (defalias): Likewise.
2892 * ralloc.c (r_alloc_check): Likewise.
2893 * regex.c (set_image_of_range_1, set_image_of_range)
2894 (regex_grow_registers): Likewise.
2895 * sysdep.c (strerror): Likewise.
2896 * termcap.c (valid_filename_p, tprint, main): Likewise.
2897 * tparam.c (main): Likewise.
2898 * unexhp9k800.c (run_time_remap, save_data_space)
2899 (update_file_ptrs, read_header, write_header, calculate_checksum)
2900 (copy_file, copy_rest, display_header): Likewise.
2901 * widget.c (mark_shell_size_user_specified, create_frame_gcs):
2903 * xdisp.c (check_it): Likewise.
2904 * xfaces.c (register_color, unregister_color, unregister_colors):
2906 * xfns.c (print_fontset_result): Likewise.
2907 * xrdb.c (member, fatal, main): Likewise.
2909 2011-07-10 Paul Eggert <eggert@cs.ucla.edu>
2911 Fix minor problems found by static checking (Bug#9031).
2912 * chartab.c (char_table_set_range, map_sub_char_table):
2913 Remove unused locals.
2914 (uniprop_table): Now static.
2915 * composite.c (_work_char): Remove unused static var.
2917 2011-07-09 Juanma Barranquero <lekktu@gmail.com>
2919 * chartab.c (uniprop_table_uncompress): Remove unused local variable.
2921 2011-07-09 Jan Djärv <jan.h.d@swipnet.se>
2923 * gtkutil.c (qttip_cb): Remove code without function.
2925 2011-07-09 Eli Zaretskii <eliz@gnu.org>
2927 * w32.c (pthread_sigmask): New stub.
2929 2011-07-08 Paul Eggert <eggert@cs.ucla.edu>
2931 Use pthread_sigmask, not sigprocmask (Bug#9010).
2932 sigprocmask is portable only for single-threaded applications, and
2933 Emacs can be multi-threaded when it uses GTK.
2934 * Makefile.in (LIB_PTHREAD_SIGMASK): New macro.
2936 * callproc.c (Fcall_process):
2937 * process.c (create_process):
2938 * sysdep.c (sys_sigblock, sys_sigunblock, sys_sigsetmask):
2939 Use pthread_sigmask, not sigprocmask.
2941 2011-07-08 Jan Djärv <jan.h.d@swipnet.se>
2943 * gtkutil.c (qttip_cb): Set line wrap to FALSE for tooltip widget.
2944 (xg_prepare_tooltip): Revert text in x->ttip_lbl, margins was
2947 2011-07-08 Jan Djärv <jan.h.d@swipnet.se>
2949 * gtkutil.c (xg_prepare_tooltip): Fix indentation and comment.
2950 Put text in x->ttip_lbl instead of gtk_tooltip_set_text (Bug#8591).
2951 (xg_hide_tooltip): Fix comment.
2953 * nsterm.m (initFrameFromEmacs): Don't use ns_return_types
2954 in registerServicesMenuSendTypes.
2955 (validRequestorForSendType): Don't check ns_return_types.
2957 * nsfns.m (Fx_open_connection): Put NSStringPboardType into
2960 2011-07-08 Jason Rumney <jasonr@gnu.org>
2962 * w32term.c (x_make_frame_visible): Use SH_SHOWNORMAL rather than
2963 SH_SHOW for hidden windows (Bug#5482).
2965 * w32fns.c (w32_wnd_proc) [WM_TIMER, WM_SET_CURSOR]: Avoid using
2966 frame struct members of non-existent frames (Bug#6284).
2968 2011-07-08 Jan Djärv <jan.h.d@swipnet.se>
2970 * nsterm.m (keyDown): Call to wantsToDelayTextChangeNotifications and
2971 variable firstTime not needed on OSX >= 10.6.
2972 (setPosition): setFloatValue:knobProportion: is deprecated on OSX
2973 >= 10.5. Use setKnobProportion, setDoubleValue.
2975 * nsterm.h (MAC_OS_X_VERSION_10_3, MAC_OS_X_VERSION_10_4)
2976 (MAC_OS_X_VERSION_10_5): Define if not defined.
2977 (EmacsView, EmacsTooltip): Implements NSWindowDelegate on OSX >= 10.6.
2978 (EmacsMenu): Implements NSMenuDelegate on OSX >= 10.6.
2979 (EmacsToolbar): Implements NSToolbarDelegate on OSX >= 10.6.
2981 * nsselect.m (ns_string_from_pasteboard): Don't use deprecated methods
2982 cString and lossyCString on OSX >= 10.4
2984 * nsmenu.m (fillWithWidgetValue): Don't use depercated method
2985 sizeToFit on OSX >= 10.2.
2987 * nsimage.m (allocInitFromFile): Don't use deprecated method
2988 bestRepresentationForDevice on OSX >= 10.6.
2990 * nsfns.m (check_ns_display_info): Cast to long and use %ld in error
2993 * emacs.c: Declare unexec_init_emacs_zone.
2995 * nsgui.h: Fix compiler warning about gnulib redefining verify.
2997 * nsselect.m (ns_get_local_selection): Change to extern (Bug#8842).
2999 * nsmenu.m (ns_update_menubar): Remove useless setDelegate call
3000 on svcsMenu (Bug#8842).
3002 * nsfns.m (Fx_open_connection): Remove NSStringPboardType from
3004 (Fns_list_services): Just return Qnil on 10.6, code not working there.
3006 * nsterm.m (QUTF8_STRING): Declare.
3007 (initFrameFromEmacs): Call registerServicesMenuSendTypes.
3008 (validRequestorForSendType): Return type is (id).
3009 Change indexOfObjectIdenticalTo to indexOfObject.
3010 Check if we have local selection before returning self (Bug#8842).
3011 (writeSelectionToPasteboard): Put local selection into paste board
3012 if we have a local selection (Bug#8842).
3013 (syms_of_nsterm): DEFSYM QUTF8_STRING.
3015 * nsterm.h (MAC_OS_X_VERSION_10_6): Define here instead of nsterm.m.
3016 (ns_get_local_selection): Declare.
3018 2011-07-07 Lars Magne Ingebrigtsen <larsi@gnus.org>
3020 * keymap.c (describe_map_tree): Don't insert a double newline at
3021 the end of the buffer (bug#1169) and return whether we inserted
3024 * callint.c (Fcall_interactively): Change "reading args" to
3025 "providing args" to try to clarify what it does (bug#1010).
3027 2011-07-07 Kenichi Handa <handa@m17n.org>
3029 * composite.c (composition_compute_stop_pos): Ignore a static
3030 composition starting before CHARPOS (Bug#8915).
3032 * xdisp.c (handle_composition_prop): Likewise.
3034 2011-07-07 Eli Zaretskii <eliz@gnu.org>
3036 * term.c (produce_glyphs) <xassert>: Allow IT_GLYPHLESS in it->what.
3039 2011-07-07 Kenichi Handa <handa@m17n.org>
3041 * character.h (unicode_category_t): New enum type.
3043 * chartab.c (uniprop_decoder_t, uniprop_encoder_t): New types.
3044 (Qchar_code_property_table): New variable.
3045 (UNIPROP_TABLE_P, UNIPROP_GET_DECODER)
3046 (UNIPROP_COMPRESSED_FORM_P): New macros.
3047 (char_table_ascii): Uncompress the compressed values.
3048 (sub_char_table_ref): New arg is_uniprop. Callers changed.
3049 Uncompress the compressed values.
3050 (sub_char_table_ref_and_range): Likewise.
3051 (char_table_ref_and_range): Uncompress the compressed values.
3052 (sub_char_table_set): New arg is_uniprop. Callers changed.
3053 Uncompress the compressed values.
3054 (sub_char_table_set_range): Args changed. Callers changed.
3055 (char_table_set_range): Adjuted for the above change.
3056 (map_sub_char_table): Delete args default_val and parent. Add arg
3057 top. Give decoded values to a Lisp function.
3058 (map_char_table): Adjust for the above change. Give decoded
3059 values to a Lisp function. Gcpro more variables.
3060 (uniprop_table_uncompress)
3061 (uniprop_decode_value_run_length): New functions.
3062 (uniprop_decoder, uniprop_decoder_count): New variables.
3063 (uniprop_get_decoder, uniprop_encode_value_character)
3064 (uniprop_encode_value_run_length, uniprop_encode_value_numeric):
3066 (uniprop_encoder, uniprop_encoder_count): New variables.
3067 (uniprop_get_encoder, uniprop_table)
3068 (Funicode_property_table_internal, Fget_unicode_property_internal)
3069 (Fput_unicode_property_internal): New functions.
3070 (syms_of_chartab): DEFSYM Qchar_code_property_table, defsubr
3071 Sunicode_property_table_internal, Sget_unicode_property_internal,
3072 and Sput_unicode_property_internal. Defvar_lisp
3073 char-code-property-alist.
3075 * composite.c (CHAR_COMPOSABLE_P): Adjust for the change of
3076 Vunicode_category_table.
3078 * font.c (font_range): Adjust for the change of
3079 Vunicode_category_table.
3081 2011-07-07 Dan Nicolaescu <dann@ics.uci.edu>
3083 * m/iris4d.h: Remove file, move contents ...
3084 * s/irix6-5.h: ... here.
3086 2011-07-06 Paul Eggert <eggert@cs.ucla.edu>
3088 Remove unportable assumption about struct layout (Bug#8884).
3089 * alloc.c (mark_buffer):
3090 * buffer.c (reset_buffer_local_variables, Fbuffer_local_variables)
3091 (clone_per_buffer_values): Don't assume that
3092 sizeof (struct buffer) is a multiple of sizeof (Lisp_Object).
3093 This isn't true in general, and it's particularly not true
3094 if Emacs is configured with --with-wide-int.
3095 * buffer.h (FIRST_FIELD_PER_BUFFER, LAST_FIELD_PER_BUFFER):
3096 New macros, used in the buffer.c change.
3098 2011-07-05 Jan Djärv <jan.h.d@swipnet.se>
3100 * xsettings.c: Use both GConf and GSettings if both are available.
3101 (store_config_changed_event): Add comment.
3102 (dpyinfo_valid, store_font_name_changed, map_tool_bar_style)
3103 (store_tool_bar_style_changed): New functions.
3104 (store_monospaced_changed): Add comment. Call dpyinfo_valid.
3105 (struct xsettings): Move font inside HAVE_XFT.
3106 (GSETTINGS_TOOL_BAR_STYLE, GSETTINGS_FONT_NAME): New defines.
3107 (GSETTINGS_MONO_FONT): Rename from SYSTEM_MONO_FONT.
3108 Move inside HAVE_XFT.
3109 (something_changed_gsettingsCB): Rename from something_changedCB.
3110 Check for changes in GSETTINGS_TOOL_BAR_STYLE and GSETTINGS_FONT_NAME
3112 (GCONF_TOOL_BAR_STYLE, GCONF_FONT_NAME): New defines.
3113 (GCONF_MONO_FONT): Rename from SYSTEM_MONO_FONT. Move inside HAVE_XFT.
3114 (something_changed_gconfCB): Rename from something_changedCB.
3115 Check for changes in GCONF_TOOL_BAR_STYLE and GCONF_FONT_NAME also.
3116 (parse_settings): Move check for font inside HAVE_XFT.
3117 (read_settings, apply_xft_settings): Add comment.
3118 (read_and_apply_settings): Add comment. Call map_tool_bar_style and
3119 store_tool_bar_style_changed. Move check for font inside HAVE_XFT and
3120 call store_font_name_changed.
3121 (xft_settings_event): Add comment.
3122 (init_gsettings): Add comment. Get values for GSETTINGS_TOOL_BAR_STYLE
3123 and GSETTINGS_FONT_NAME. Move check for fonts within HAVE_XFT.
3124 (init_gconf): Add comment. Get values for GCONF_TOOL_BAR_STYLE
3125 and GCONF_FONT_NAME. Move check for fonts within HAVE_XFT.
3126 (xsettings_initialize): Call init_gsettings last.
3127 (xsettings_get_system_font, xsettings_get_system_normal_font):
3130 2011-07-05 Paul Eggert <eggert@cs.ucla.edu>
3132 Random fixes. E.g., (random) never returned negative values.
3133 * fns.c (Frandom): Use GET_EMACS_TIME for random seed, and add the
3134 subseconds part to the entropy, as that's a bit more random.
3135 Prefer signed to unsigned, since the signedness doesn't matter and
3136 in general we prefer signed. When given a limit, use a
3137 denominator equal to INTMASK + 1, not to VALMASK + 1, because the
3138 latter isn't right if USE_2_TAGS_FOR_INTS.
3139 * sysdep.c (get_random): Return a value in the range 0..INTMASK,
3140 not 0..VALMASK. Don't discard "excess" bits that random () returns.
3142 2011-07-04 Stefan Monnier <monnier@iro.umontreal.ca>
3144 * textprop.c (text_property_stickiness):
3145 Obey Vtext_property_default_nonsticky.
3146 (syms_of_textprop): Add `display' to Vtext_property_default_nonsticky.
3147 * w32fns.c (syms_of_w32fns):
3148 * xfns.c (syms_of_xfns): Don't Add `display' since it's there by default.
3150 2011-07-04 Paul Eggert <eggert@cs.ucla.edu>
3152 * fileio.c (barf_or_query_if_file_exists): Use S_ISDIR.
3153 This is more efficient than Ffile_directory_p and avoids a minor race.
3155 2011-07-04 Lars Magne Ingebrigtsen <larsi@gnus.org>
3157 * buffer.c (Foverlay_put): Say what the return value is
3160 * fileio.c (barf_or_query_if_file_exists): Check first if the file
3161 is a directory before asking whether to use the file name
3163 (barf_or_query_if_file_exists): Make the "File is a directory"
3164 error be more correct.
3166 * fns.c (Frequire): Remove the mention of the .gz files, since
3167 that's installation-specific, but keep the mention of
3168 `get-load-suffixes'.
3170 2011-07-04 Paul Eggert <eggert@cs.ucla.edu>
3172 * editfns.c (Fformat_time_string): Don't assume strlen fits in int.
3173 Report string overflow if the output is too long.
3175 2011-07-04 Juanma Barranquero <lekktu@gmail.com>
3177 * gnutls.c (Fgnutls_boot): Don't mention :verify-error.
3178 (syms_of_gnutls): Remove duplicate DEFSYM for
3179 Qgnutls_bootprop_verify_hostname_error, an error for
3180 Qgnutls_bootprop_verify_error (which is no longer used).
3182 * eval.c (find_handler_clause): Remove parameters `sig' and `data',
3183 unused since 2011-01-26T20:02:07Z!monnier@iro.umontreal.ca. All callers changed.
3184 Also (re)move comments that are misplaced or no longer relevant.
3186 2011-07-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
3188 * callint.c (Finteractive): Clarify the meaning of "@" (bug#8813).
3190 2011-07-03 Chong Yidong <cyd@stupidchicken.com>
3192 * xfaces.c (Finternal_merge_in_global_face): Modify the foreground
3193 and background color parameters if they have been changed.
3195 2011-07-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
3197 * editfns.c (Fformat): Clarify the - and 0 flags (bug#6659).
3199 2011-07-03 Paul Eggert <eggert@cs.ucla.edu>
3201 * xsettings.c (SYSTEM_FONT): Define only when used.
3202 No need to define when HAVE_GSETTINGS || !HAVE_XFT.
3204 * keymap.c (access_keymap_1): Now static.
3206 2011-07-02 Chong Yidong <cyd@stupidchicken.com>
3208 * keyboard.c (command_loop_1): If a down-mouse event is unbound,
3209 leave any prefix arg for the up event (Bug#1586).
3211 2011-07-02 Lars Magne Ingebrigtsen <larsi@gnus.org>
3213 * lread.c (syms_of_lread): Mention single symbols defined by
3214 `defvar' or `defconst' (bug#7154).
3216 * fns.c (Frequire): Mention .el.gz files (bug#7314).
3217 (Frequire): Mention get-load-suffixes.
3219 2011-07-02 Martin Rudalics <rudalics@gmx.at>
3221 * window.h (window): Remove clone_number slot.
3222 * window.c (Fwindow_clone_number, Fset_window_clone_number):
3224 (make_parent_window, make_window, saved_window)
3225 (Fset_window_configuration, save_window_save): Don't deal with
3227 * buffer.c (Qclone_number): Remove declaration.
3228 (sort_overlays, overlay_strings): Don't deal with clone numbers.
3230 2011-07-02 Stefan Monnier <monnier@iro.umontreal.ca>
3232 Add multiple inheritance to keymaps.
3233 * keymap.c (Fmake_composed_keymap): New function.
3234 (Fset_keymap_parent): Simplify.
3235 (fix_submap_inheritance): Remove.
3236 (access_keymap_1): New function extracted from access_keymap to handle
3237 embedded parents and handle lists of maps.
3238 (access_keymap): Use it.
3239 (Fkeymap_prompt, map_keymap_internal, map_keymap, store_in_keymap)
3240 (Fcopy_keymap): Handle embedded parents.
3241 (Fcommand_remapping, define_as_prefix): Simplify.
3242 (Fkey_binding): Simplify.
3243 (syms_of_keymap): Move minibuffer-local-completion-map,
3244 minibuffer-local-filename-completion-map,
3245 minibuffer-local-must-match-map, and
3246 minibuffer-local-filename-must-match-map to Elisp.
3247 (syms_of_keymap): Defsubr make-composed-keymap.
3248 * keyboard.c (menu_bar_items): Use map_keymap_canonical.
3249 (parse_menu_item): Trivial simplification.
3251 2011-07-01 Glenn Morris <rgm@gnu.org>
3253 * Makefile.in (SETTINGS_LIBS): Fix typo.
3255 2011-07-01 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny patch)
3257 * coding.c (Fencode_coding_string): Record the last coding system
3258 used, as the function doc string says (bug#8738).
3260 2011-07-01 Jan Djärv <jan.h.d@swipnet.se>
3262 * xsettings.c (store_monospaced_changed): Take new font as arg and
3263 check for change against current_mono_font.
3264 (EMACS_TYPE_SETTINGS): Remove this and related defines.
3265 (emacs_settings_constructor, emacs_settings_get_property)
3266 (emacs_settings_set_property, emacs_settings_class_init)
3267 (emacs_settings_init, gsettings_obj): Remove.
3268 (something_changedCB): New function for HAVE_GSETTINGS.
3269 (something_changedCB): HAVE_GCONF: Call store_monospaced_changed
3270 with value as argument.
3271 (init_gsettings): Check that GSETTINGS_SCHEMA exists before calling
3272 g_settings_new (Bug#8967). Do not create gsettings_obj.
3273 Remove calls to g_settings_bind. Connect something_changedCB to
3276 * xgselect.c: Add defined (HAVE_GSETTINGS).
3277 (xgselect_initialize): Ditto.
3279 * process.c: Add defined (HAVE_GSETTINGS) for xgselect.h
3280 (wait_reading_process_output): Add defined (HAVE_GSETTINGS) for
3283 2011-07-01 Paul Eggert <eggert@cs.ucla.edu>
3285 * eval.c (struct backtrace): Simplify and port the data structure.
3286 Do not assume that "int nargs : BITS_PER_INT - 2;" produces a
3287 signed bit field, as this assumption is not portable and it makes
3288 Emacs crash when compiled with Sun C 5.8 on sparc. Do not use
3289 "char debug_on_exit : 1" as this is not portable either; instead,
3290 use the portable "unsigned int debug_on_exit : 1". Remove unused
3291 member evalargs. Remove obsolete comments about cc bombing out.
3293 2011-06-30 Jan Djärv <jan.h.d@swipnet.se>
3295 * xsettings.c: Include glib-object.h, gio/gio.h if HAVE_GSETTINGS.
3296 Let HAVE_GSETTINGS override HAVE_GCONF.
3297 (store_monospaced_changed): New function.
3298 (EMACS_SETTINGS): A new type derived from GObject to handle
3299 GSettings notifications.
3300 (emacs_settings_constructor, emacs_settings_get_property)
3301 (emacs_settings_set_property, emacs_settings_class_init):
3303 (gsettings_client, gsettings_obj): New variables.
3304 (GSETTINGS_SCHEMA): New define.
3305 (something_changedCB): Call store_monospaced_changed.
3306 (init_gsettings): New function.
3307 (xsettings_initialize): Call init_gsettings.
3308 (syms_of_xsettings): Initialize gsettings_client, gsettings_obj
3311 * Makefile.in (SETTINGS_CFLAGS, SETTINGS_LIBS): Rename from
3314 2011-06-29 Martin Rudalics <rudalics@gmx.at>
3316 * window.c (resize_root_window, grow_mini_window)
3317 (shrink_mini_window): Rename Qresize_root_window to
3318 Qwindow_resize_root_window and Qresize_root_window_vertically to
3319 Qwindow_resize_root_window_vertically.
3321 2011-06-28 Paul Eggert <eggert@cs.ucla.edu>
3323 * gnutls.c (Qgnutls_bootprop_verify_error): Remove unused var.
3325 2011-06-27 Juanma Barranquero <lekktu@gmail.com>
3327 * makefile.w32-in: Redesign dependencies so they reflect more
3328 clearly which files are directly included by each source file,
3329 and not through other includes.
3331 2011-06-27 Martin Rudalics <rudalics@gmx.at>
3333 * buffer.c (Qclone_number): Declare static and DEFSYM it.
3334 (sort_overlays, overlay_strings): When an overlay's clone number
3335 matches the window's clone number process the overlay even if
3336 the overlay's window property doesn't match the current window.
3338 * window.c (Fwindow_vchild): Rename to Fwindow_top_child.
3339 (Fwindow_hchild): Rename to Fwindow_left_child.
3340 (Fwindow_next): Rename to Fwindow_next_sibling.
3341 (Fwindow_prev): Rename to Fwindow_prev_sibling.
3342 (resize_window_check): Rename to window_resize_check.
3343 (resize_window_apply): Rename to window_resize_apply.
3344 (Fresize_window_apply): Rename to Fwindow_resize_apply.
3345 (Fdelete_other_windows_internal, resize_frame_windows)
3346 (Fsplit_window_internal, Fdelete_window_internal)
3347 (grow_mini_window, shrink_mini_window)
3348 (Fresize_mini_window_internal): Fix callers accordingly.
3350 2011-06-26 Jan Djärv <jan.h.d@swipnet.se>
3352 * emacsgtkfixed.h: State that this is only used with Gtk+3.
3353 (emacs_fixed_set_min_size): Remove.
3354 (emacs_fixed_new): Take frame as argument.
3356 * emacsgtkfixed.c: State that this is only used with Gtk+3.
3357 (_EmacsFixedPrivate): Remove minwidth/height.
3358 Add struct frame *f.
3359 (emacs_fixed_init): Initialize priv->f.
3360 (get_parent_class, emacs_fixed_set_min_size): Remove.
3361 (emacs_fixed_new): Set priv->f to argument.
3362 (emacs_fixed_get_preferred_width)
3363 (emacs_fixed_get_preferred_height): Use min_width/height from
3364 frames size_hint to set minimum and natural (Bug#8919).
3365 (XSetWMSizeHints, XSetWMNormalHints): Override these functions
3366 and use min_width/height from frames size_hint to set
3367 min_width/height (Bug#8919).
3369 * gtkutil.c (xg_create_frame_widgets): Pass f to emacs_fixed_new.
3370 (x_wm_set_size_hint): Remove call to emacs_fixed_set_min_size.
3373 2011-06-26 Eli Zaretskii <eliz@gnu.org>
3375 * bidi.c (bidi_paragraph_init): Test for ZV_BYTE before calling
3376 bidi_at_paragraph_end, since fast_looking_at doesn't like to be
3379 2011-06-26 Chong Yidong <cyd@stupidchicken.com>
3381 * process.c (wait_reading_process_output): Bypass select if
3382 waiting for a cell while ignoring keyboard input, and input is
3383 pending. Suggested by Jan Djärv (Bug#8869).
3385 2011-06-25 Paul Eggert <eggert@cs.ucla.edu>
3387 Use gnulib's dup2 module instead of rolling our own.
3388 * sysdep.c (dup2) [!HAVE_DUP2]: Remove; gnulib now does this.
3390 2011-06-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
3392 * dispnew.c (scrolling_window): Before scrolling, turn off a
3393 mouse-highlight in the window being scrolled.
3395 2011-06-24 Juanma Barranquero <lekktu@gmail.com>
3397 Move DEFSYM to lisp.h and use everywhere.
3399 * character.h (DEFSYM): Move declaration...
3400 * lisp.h (DEFSYM): ...here.
3406 * w32select.c: Don't include character.h.
3408 * alloc.c (syms_of_alloc):
3409 * buffer.c (syms_of_buffer):
3410 * bytecode.c (syms_of_bytecode):
3411 * callint.c (syms_of_callint):
3412 * casefiddle.c (syms_of_casefiddle):
3413 * casetab.c (init_casetab_once):
3414 * category.c (init_category_once, syms_of_category):
3415 * ccl.c (syms_of_ccl):
3416 * cmds.c (syms_of_cmds):
3417 * composite.c (syms_of_composite):
3418 * dbusbind.c (syms_of_dbusbind):
3419 * dired.c (syms_of_dired):
3420 * dispnew.c (syms_of_display):
3421 * doc.c (syms_of_doc):
3422 * editfns.c (syms_of_editfns):
3423 * emacs.c (syms_of_emacs):
3424 * eval.c (syms_of_eval):
3425 * fileio.c (syms_of_fileio):
3426 * fns.c (syms_of_fns):
3427 * frame.c (syms_of_frame):
3428 * fringe.c (syms_of_fringe):
3429 * insdel.c (syms_of_insdel):
3430 * keymap.c (syms_of_keymap):
3431 * lread.c (init_obarray, syms_of_lread):
3432 * macros.c (syms_of_macros):
3433 * msdos.c (syms_of_msdos):
3434 * print.c (syms_of_print):
3435 * process.c (syms_of_process):
3436 * search.c (syms_of_search):
3437 * sound.c (syms_of_sound):
3438 * syntax.c (init_syntax_once, syms_of_syntax):
3439 * terminal.c (syms_of_terminal):
3440 * textprop.c (syms_of_textprop):
3441 * undo.c (syms_of_undo):
3442 * w32.c (globals_of_w32):
3443 * window.c (syms_of_window):
3444 * xdisp.c (syms_of_xdisp):
3445 * xfaces.c (syms_of_xfaces):
3446 * xfns.c (syms_of_xfns):
3447 * xmenu.c (syms_of_xmenu):
3448 * xsettings.c (syms_of_xsettings):
3449 * xterm.c (syms_of_xterm): Use DEFSYM.
3451 2011-06-24 Teodor Zlatanov <tzz@lifelogs.com>
3453 * gnutls.c (syms_of_gnutls): Use the DEFSYM macro from character.h.
3455 2011-06-23 Paul Eggert <eggert@cs.ucla.edu>
3457 Integer and buffer overflow fixes (Bug#8873).
3459 * print.c (printchar, strout): Check for string overflow.
3460 (PRINTPREPARE, printchar, strout):
3461 Don't set size unless allocation succeeds.
3463 * minibuf.c (read_minibuf_noninteractive): Use ptrdiff_t, not int,
3464 for sizes. Check for string overflow more accurately.
3465 Simplify newline removal at end; this suppresses a GCC 4.6.0 warning.
3467 * macros.c: Integer and buffer overflow fixes.
3468 * keyboard.h (struct keyboard.kbd_macro_bufsize):
3469 * macros.c (Fstart_kbd_macro, store_kbd_macro_char):
3470 Use ptrdiff_t, not int, for sizes.
3471 Don't increment bufsize until after realloc succeeds.
3472 Check for size-calculation overflow.
3473 (Fstart_kbd_macro): Use EMACS_INT, not int, for XINT result.
3475 * lisp.h (DEFVAR_KBOARD): Use offsetof instead of char * finagling.
3477 * lread.c: Integer overflow fixes.
3478 (read_integer): Radix is now EMACS_INT, not int,
3479 to improve quality of diagnostics for out-of-range radices.
3480 Calculate buffer size correctly for out-of-range radices.
3481 (read1): Check for integer overflow in radices, and in
3482 read-circle numbers.
3483 (read_escape): Avoid int overflow.
3484 (Fload, openp, read_buffer_size, read1)
3485 (substitute_object_recurse, read_vector, read_list, map_obarray):
3486 Use ptrdiff_t, not int, for sizes.
3487 (read1): Use EMACS_INT, not int, for sizes.
3488 Check for size overflow.
3490 * image.c (cache_image): Check for size arithmetic overflow.
3492 * lread.c: Integer overflow issues.
3493 (saved_doc_string_size, saved_doc_string_length)
3494 (prev_saved_doc_string_size, prev_saved_doc_string_length):
3495 Now ptrdiff_t, not int.
3496 (read1): Don't assume doc string length fits in int. Check for
3497 out-of-range doc string lengths.
3498 (read_list): Don't assume file position fits in int.
3499 (read_escape): Check for hex character overflow.
3501 2011-06-22 Leo Liu <sdl.web@gmail.com>
3503 * minibuf.c (Fcompleting_read_default, Vcompleting_read_function):
3504 Move to minibuffer.el.
3506 2011-06-22 Paul Eggert <eggert@cs.ucla.edu>
3508 Fixes for GLYPH_DEBUG found by GCC 4.6.0 static checking.
3509 The following patches are for when GLYPH_DEBUG && !XASSERT.
3510 * dispextern.h (trace_redisplay_p, dump_glyph_string):
3511 * dispnew.c (flush_stdout):
3512 * xdisp.c (dump_glyph_row, dump_glyph_matrix, dump_glyph):
3513 Mark as externally visible.
3514 * dispnew.c (check_window_matrix_pointers): Now static.
3515 * dispnew.c (window_to_frame_vpos):
3516 * xfns.c (unwind_create_frame):
3517 * xterm.c (x_check_font): Remove unused local.
3518 * scroll.c (CHECK_BOUNDS):
3519 * xfaces.c (cache_fache): Rename local to avoid shadowing.
3520 * xfns.c, w32fns.c (image_cache_refcount, dpyinfo_refcount): Now static.
3521 * xdisp.c (check_window_end): Now a no-op if !XASSERTS.
3522 (debug_first_unchanged_at_end_vpos, debug_last_unchanged_at_beg_vpos)
3523 (debug_dvpos, debug_dy, debug_delta, debug_delta_bytes, debug_end_vpos):
3525 (debug_method_add): Use va_list and vsprintf rather than relying
3526 on undefined behavior with wrong number of arguments.
3527 (dump_glyph, dump_glyph_row, Fdump_glyph_matrix):
3528 Don't assume ptrdiff_t and EMACS_INT are the same width as int.
3529 In this code, it's OK to assume C99 behavior for ptrdiff_t formats
3530 since we're not interested in debugging glyphs with old libraries.
3531 * xfaces.c (cache_face): Move debugging code earlier; this pacifies
3532 GCC 4.6.0's static checking.
3534 2011-06-22 Paul Eggert <eggert@cs.ucla.edu>
3536 Integer overflow and signedness fixes (Bug#8873).
3537 A few related buffer overrun fixes, too.
3539 * font.c (font_score): Use EMACS_INT, not int, to store XINT value.
3541 * dispextern.h (struct face.stipple):
3542 * image.c (x_bitmap_height, x_bitmap_width, x_bitmap_pixmap)
3543 (x_bitmap_mask, x_allocate_bitmap_record)
3544 (x_create_bitmap_from_data, x_create_bitmap_from_file)
3545 (x_destroy_bitmap, x_destroy_all_bitmaps, x_create_bitmap_mask)
3546 (x_create_bitmap_from_xpm_data):
3547 * nsterm.h (struct ns_display_info.bitmaps_size, .bitmaps_last):
3548 * w32term.h (struct w32_display_info.icon_bitmap_id, .bitmaps_size)
3550 * xfaces.c (load_pixmap):
3551 * xterm.c (x_bitmap_icon, x_wm_set_icon_pixmap):
3552 * xterm.h (struct x_display_info.icon_bitmap_id, .bitmaps_size)
3553 (.bitmaps_last, struct x_output.icon_bitmap):
3554 Use ptrdiff_t, not int, for bitmap indexes.
3555 (x_allocate_bitmap_record): Check for size overflow.
3556 * dispextern.h, lisp.h: Adjust to API changes elsewhere.
3558 Use ptrdiff_t, not int, for overlay counts.
3559 * buffer.h (overlays_at, sort_overlays, GET_OVERLAYS_AT):
3560 * editfns.c (overlays_around, get_pos_property):
3561 * textprop.c (get_char_property_and_overlay):
3562 * xdisp.c (next_overlay_change, note_mouse_highlight):
3563 * xfaces.c (face_at_buffer_position):
3564 * buffer.c (OVERLAY_COUNT_MAX): New macro.
3565 (overlays_at, overlays_in, sort_overlays, Foverlays_at)
3566 (Fnext_overlay_change, Fprevious_overlay_change)
3567 (mouse_face_overlay_overlaps, Foverlays_in):
3568 Use ptrdiff_t, not int, for sizes.
3569 (overlays_at, overlays_in): Check for size-calculation overflow.
3571 * xterm.c (xim_initialize, same_x_server): Strlen may not fit in int.
3573 * xsmfns.c (smc_save_yourself_CB, x_session_initialize): Avoid strlen.
3574 (x_session_initialize): Do not assume string length fits in int.
3576 * xsettings.c (apply_xft_settings): Fix potential buffer overrun.
3577 This is unlikely, but can occur if DPI is outlandish.
3579 * xsettings.c (Ffont_get_system_normal_font, Ffont_get_system_font):
3580 * xselect.c (Fx_get_atom_name): Avoid need for strlen.
3582 * xrdb.c: Don't assume strlen fits in int; avoid some strlens.
3583 * xrdb.c (magic_file_p, search_magic_path):
3584 Omit last arg SUFFIX; it was always 0. All callers changed.
3585 (magic_file_p): Use ptrdiff_t, not int. Check for size overflow.
3587 * xfont.c (xfont_match): Avoid need for strlen.
3589 * xfns.c: Don't assume strlen fits in int.
3590 (xic_create_fontsetname, x_window): Use ptrdiff_t, not int.
3592 * xdisp.c (message_log_check_duplicate): Return intmax_t,
3593 not unsigned long, as we prefer signed integers. All callers changed.
3594 Detect integer overflow in repeat count.
3595 (message_dolog): Don't assume print length fits in 39 bytes.
3596 (display_mode_element): Don't assume strlen fits in int.
3598 * termcap.c: Don't assume sizes fit in int and never overflow.
3599 (struct termcap_buffer, tgetent): Use ptrdiff_t, not int, for sizes.
3600 (gobble_line): Check for size-calculation overflow.
3602 * minibuf.c (Fread_buffer):
3603 * lread.c (intern, intern_c_string):
3604 * image.c (xpm_scan) [HAVE_NS && !HAVE_XPM]:
3605 Don't assume string length fits in int.
3607 * keyboard.c (parse_tool_bar_item):
3608 * gtkutil.c (style_changed_cb): Avoid need for strlen.
3610 * font.c: Don't assume string length fits in int.
3611 (font_parse_xlfd, font_parse_fcname, font_unparse_fcname):
3612 Use ptrdiff_t, not int.
3613 (font_intern_prop): Don't assume string length fits in int.
3614 Don't assume integer property fits in fixnum.
3615 * font.h (font_intern_prop): 2nd arg is now ptrdiff_t, not int.
3617 * filelock.c: Fix some buffer overrun and integer overflow issues.
3618 (get_boot_time): Don't assume gzip command string fits in 100 bytes.
3619 Reformulate so as not to need the command string.
3620 Invoke gzip -cd rather than gunzip, as it's more portable.
3621 (lock_info_type, lock_file_1, lock_file):
3622 Don't assume pid_t and time_t fit in unsigned long.
3623 (LOCK_PID_MAX): Remove; we now use more-reliable bounds.
3624 (current_lock_owner): Prefer signed type for sizes.
3625 Use memcpy, not strncpy, where memcpy is what is really wanted.
3626 Don't assume (via atoi) that time_t and pid_t fit in int.
3627 Check for time_t and/or pid_t out of range, e.g., via a network share.
3628 Don't alloca where an auto var works fine.
3630 * fileio.c: Fix some integer overflow issues.
3631 (file_name_as_directory, Fexpand_file_name, Fsubstitute_in_file_name):
3632 Don't assume string length fits in int.
3633 (directory_file_name): Don't assume string length fits in long.
3634 (make_temp_name): Don't assume pid fits in int, or that its print
3635 length is less than 20.
3637 * data.c (Fsubr_name): Rewrite to avoid a strlen call.
3639 * coding.c (make_subsidiaries): Don't assume string length fits in int.
3641 * callproc.c (child_setup): Rewrite to avoid two strlen calls.
3643 * process.c (Fformat_network_address): Use EMACS_INT, not EMACS_UINT.
3644 We prefer signed integers, even for size calculations.
3646 * emacs.c: Don't assume string length fits in 'int'.
3647 (DEFINE_DUMMY_FUNCTION, sort_args): Use ptrdiff_t, not int.
3648 (main): Don't invoke strlen when not needed.
3650 * dbusbind.c (XD_ERROR): Don't arbitrarily truncate string.
3651 (XD_DEBUG_MESSAGE): Don't waste a byte.
3653 * callproc.c (getenv_internal_1, getenv_internal)
3655 * buffer.c (init_buffer): Don't assume string length fits in 'int'.
3657 * lread.c (invalid_syntax): Omit length argument.
3658 All uses changed. This doesn't fix a bug, but it simplifies the
3659 code away from its former Hollerith-constant appearance, and it's
3660 one less 'int' to worry about when looking at integer-overflow issues.
3661 (string_to_number): Simplify 2011-04-26 change by invoking xsignal1.
3663 * lisp.h (DEFUN): Remove bogus use of sizeof (struct Lisp_Subr).
3664 This didn't break anything, but it didn't help either.
3665 It's confusing to put a bogus integer in a place where the actual
3666 value does not matter.
3667 (LIST_END_P): Remove unused macro and its bogus comment.
3668 (make_fixnum_or_float): Remove unnecessary cast to EMACS_INT.
3670 * lisp.h (union Lisp_Object.i): EMACS_INT, not EMACS_UINT.
3671 This is for consistency with the ordinary, non-USE_LISP_UNION_TYPE,
3673 (struct Lisp_Bool_Vector.size): EMACS_INT, not EMACS_UINT.
3674 We prefer signed types, and the value cannot exceed the EMACS_INT
3675 range anyway (because otherwise the length would not be representable).
3676 (XSET) [USE_LISP_UNION_TYPE]: Use uintptr_t and intptr_t,
3677 not EMACS_UINT and EMACS_INT, when converting pointer to integer.
3678 This avoids a GCC warning when WIDE_EMACS_INT.
3680 * indent.c (sane_tab_width): New function.
3681 (current_column, scan_for_column, Findent_to, position_indentation)
3682 (compute_motion): Use it. This is just for clarity.
3683 (Fcompute_motion): Don't assume hscroll and tab offset fit in int.
3685 * image.c (xbm_image_p): Don't assume stated width, height fit in int.
3687 * lisp.h (lint_assume): New macro.
3688 * composite.c (composition_gstring_put_cache):
3689 * ftfont.c (ftfont_shape_by_flt): Use it to pacify GCC 4.6.0.
3691 * editfns.c, insdel.c:
3692 Omit unnecessary forward decls, to simplify future changes.
3694 * ftfont.c (ftfont_shape_by_flt): Use signed integers for lengths.
3696 * font.c (Ffont_shape_gstring): Don't assume glyph len fits in 'int'.
3698 * fns.c (Ffillarray): Don't assume bool vector size fits in 'int'.
3699 Use much-faster test for byte-length change.
3700 Don't assume string byte-length fits in 'int'.
3701 Check that character arg fits in 'int'.
3702 (mapcar1): Declare byte as byte, for clarity.
3704 * alloc.c (Fmake_bool_vector): Avoid unnecessary multiplication.
3706 * fns.c (concat): Catch string overflow earlier.
3707 Do not rely on integer wraparound.
3709 * dispextern.h (struct it.overlay_strings_charpos)
3710 (struct it.selective): Now EMACS_INT, not int.
3711 * xdisp.c (forward_to_next_line_start)
3712 (back_to_previous_visible_line_start)
3713 (reseat_at_next_visible_line_start, next_element_from_buffer):
3714 Don't arbitrarily truncate the value of 'selective' to int.
3716 * xdisp.c (init_iterator): Use XINT, not XFASTINT; it might be < 0.
3718 * composite.c: Don't truncate sizes to 'int'.
3719 (composition_gstring_p, composition_reseat_it)
3720 (composition_adjust_point): Use EMACS_INT, not int.
3721 (get_composition_id, composition_gstring_put_cache): Use EMACS_INT,
3722 not EMACS_UINT, for indexes.
3724 * category.h (CATEGORY_SET_P): Remove unnecessary cast to EMACS_INT.
3726 * buffer.c: Include <verify.h>.
3727 (struct sortvec.priority, struct sortstr.priority):
3728 Now EMACS_INT, not int.
3729 (compare_overlays, cmp_for_strings): Avoid subtraction overflow.
3730 (struct sortstr.size, record_overlay_string)
3731 (struct sortstrlist.size, struct sortlist.used):
3732 Don't truncate size to int.
3733 (record_overlay_string): Check for size-calculation overflow.
3734 (init_buffer_once): Check at compile-time, not run-time.
3736 2011-06-22 Jim Meyering <meyering@redhat.com>
3738 Don't leak an XBM-image-sized buffer
3739 * image.c (xbm_load): Free the image buffer after using it.
3741 2011-06-21 Paul Eggert <eggert@cs.ucla.edu>
3744 * composite.c (find_automatic_composition): Omit needless 'return 0;'
3745 that Sun C diagnosed.
3746 * fns.c (secure_hash): Fix pointer signedness issue.
3747 * intervals.c (static_offset_intervals): New function.
3748 (offset_intervals): Use it.
3750 2011-06-21 Leo Liu <sdl.web@gmail.com>
3753 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha256.h and
3756 * fns.c (secure_hash): Rename from crypto_hash_function and change
3757 the first arg to accept symbols.
3758 (Fsecure_hash): New primitive.
3759 (syms_of_fns): New symbols.
3761 2011-06-20 Deniz Dogan <deniz@dogan.se>
3763 * process.c (Fset_process_buffer): Clarify return value in
3766 2011-06-18 Chong Yidong <cyd@stupidchicken.com>
3768 * dispnew.c (add_window_display_history): Use BVAR.
3770 * xdisp.c (debug_method_add): Use BVAR.
3771 (check_window_end, dump_glyph_matrix, dump_glyph)
3772 (dump_glyph_row, dump_glyph_string): Convert arglist to ANSI C.
3774 * xfaces.c (check_lface_attrs, check_lface, dump_realized_face):
3777 * xfns.c (Fx_create_frame, x_create_tip_frame): Delay image cache
3778 check till after the cache is created in init_frame_faces.
3780 2011-06-17 Stefan Monnier <monnier@iro.umontreal.ca>
3782 * fns.c (Fsafe_length): Yet another int/Lisp_Object mixup.
3784 2011-06-16 Paul Eggert <eggert@cs.ucla.edu>
3786 * lisp.h: Include <limits.h>, for INT_MAX, LONG_MAX, LLONG_MAX.
3787 Without this, prin1 mishandles Lisp_Misc_Save_Value printing on
3788 hosts with pre-C99 libraries, because pD is wrongly defined to "t".
3790 Improve buffer-overflow checking (Bug#8873).
3791 * fileio.c (Finsert_file_contents):
3792 * insdel.c (insert_from_buffer_1, replace_range, replace_range_2):
3793 Remove the old (too-loose) buffer overflow checks.
3794 They weren't needed, since make_gap checks for buffer overflow.
3795 * insdel.c (make_gap_larger): Catch buffer overflows that were missed.
3796 The old code merely checked for Emacs fixnum overflow, and relied
3797 on undefined (wraparound) behavior. The new code avoids undefined
3798 behavior, and also checks for ptrdiff_t and/or size_t overflow.
3800 * editfns.c (Finsert_char): Don't dump core with very negative counts.
3801 Tune. Don't use wider integers than needed. Don't use alloca.
3802 Use a bigger 'string' buffer. Rewrite to avoid 'n > 0' test.
3804 * insdel.c (replace_range): Fix buf overflow when insbytes < outgoing.
3806 * insdel.c, lisp.h (buffer_overflow): New function.
3807 (insert_from_buffer_1, replace_range, replace_range_2):
3808 * insdel.c (make_gap_larger):
3809 * editfns.c (Finsert_char):
3810 * fileio.c (Finsert_file_contents): Use it, to normalize wording.
3812 * buffer.h (BUF_BYTES_MAX): Cast to ptrdiff_t so that it's signed.
3814 2011-06-15 Paul Eggert <eggert@cs.ucla.edu>
3816 Integer overflow and signedness fixes (Bug#8873).
3818 * ccl.c (ASCENDING_ORDER): New macro, to work around GCC bug 43772.
3819 (GET_CCL_RANGE, IN_INT_RANGE): Use it.
3821 * fileio.c: Don't assume EMACS_INT fits in off_t.
3822 (emacs_lseek): New static function.
3823 (Finsert_file_contents, Fwrite_region): Use it.
3824 Use SEEK_SET, SEEK_CUR, SEEK_END as appropriate.
3826 * fns.c (Fload_average): Don't assume 100 * load average fits in int.
3828 * fns.c: Don't overflow int when computing a list length.
3829 * fns.c (QUIT_COUNT_HEURISTIC): New constant.
3830 (Flength, Fsafe_length): Use EMACS_INT, not int, to avoid unwanted
3831 truncation on 64-bit hosts. Check for QUIT every
3832 QUIT_COUNT_HEURISTIC entries rather than every other entry; that's
3833 faster and is responsive enough.
3834 (Flength): Report an error instead of overflowing an integer.
3835 (Fsafe_length): Return a float if the value is not representable
3836 as a fixnum. This shouldn't happen except in contrived situations.
3837 (Fnthcdr, Fsort): Don't assume list length fits in int.
3838 (Fcopy_sequence): Don't assume vector length fits in int.
3840 * alloc.c: Check that resized vectors' lengths fit in fixnums.
3841 (header_size, word_size): New constants.
3842 (allocate_vectorlike): Don't check size overflow here.
3843 (allocate_vector): Check it here instead, since this is the only
3844 caller of allocate_vectorlike that could cause overflow.
3845 Check that the new vector's length is representable as a fixnum.
3847 * fns.c (next_almost_prime): Don't return a multiple of 3 or 5.
3848 The previous code was bogus. For example, next_almost_prime (32)
3849 returned 39, which is undesirable as it is a multiple of 3; and
3850 next_almost_prime (24) returned 25, which is a multiple of 5 so
3851 why was the code bothering to check for multiples of 7?
3853 * bytecode.c (exec_byte_code): Use ptrdiff_t, not int, for vector length.
3855 * eval.c, doprnt.c (SIZE_MAX): Remove; inttypes.h defines this now.
3857 Variadic C functions now count arguments with ptrdiff_t.
3858 This partly undoes my 2011-03-30 change, which replaced int with size_t.
3859 Back then I didn't know that the Emacs coding style prefers signed int.
3860 Also, in the meantime I found a few more instances where arguments
3861 were being counted with int, which may truncate counts on 64-bit
3862 machines, or EMACS_INT, which may be unnecessarily wide.
3863 * lisp.h (struct Lisp_Subr.function.aMANY)
3864 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call):
3865 Arg counts are now ptrdiff_t, not size_t.
3866 All variadic functions and their callers changed accordingly.
3867 (struct gcpro.nvars): Now size_t, not size_t. All uses changed.
3868 * bytecode.c (exec_byte_code): Check maxdepth for overflow,
3869 to avoid potential buffer overrun. Don't assume arg counts fit in 'int'.
3870 * callint.c (Fcall_interactively): Check arg count for overflow,
3871 to avoid potential buffer overrun. Use signed char, not 'int',
3872 for 'varies' array, so that we needn't bother to check its size
3873 calculation for overflow.
3874 * editfns.c (Fformat): Use ptrdiff_t, not EMACS_INT, to count args.
3875 * eval.c (apply_lambda):
3876 * fns.c (Fmapconcat): Use XFASTINT, not XINT, to get args length.
3877 (struct textprop_rec.argnum): Now ptrdiff_t, not int. All uses changed.
3878 (mapconcat): Use ptrdiff_t, not int and EMACS_INT, to count args.
3880 * callint.c (Fcall_interactively): Don't use index var as event count.
3882 * vm-limit.c (check_memory_limits): Fix incorrect extern function decls.
3883 * mem-limits.h (SIZE): Remove; no longer used.
3885 * xterm.c (x_alloc_nearest_color_1): Prefer int to long when int works.
3887 Remove unnecessary casts.
3888 * xterm.c (x_term_init):
3889 * xfns.c (x_set_border_pixel):
3890 * widget.c (create_frame_gcs): Remove casts to unsigned long etc.
3891 These aren't needed now that we assume ANSI C.
3893 * sound.c (Fplay_sound_internal): Remove cast to unsigned long.
3894 It's more likely to cause problems (due to unsigned overflow)
3897 * dired.c (Ffile_attributes): Don't use 32-bit hack on 64-bit hosts.
3899 * unexelf.c (unexec): Don't assume BSS addr fits in unsigned.
3901 * xterm.c (handle_one_xevent): Omit unnecessary casts to unsigned.
3903 * keyboard.c (modify_event_symbol): Don't limit alist len to UINT_MAX.
3905 * lisp.h (CHAR_TABLE_SET): Omit now-redundant test.
3907 * lread.c (Fload): Don't compare a possibly-garbage time_t value.
3909 GLYPH_CODE_FACE returns EMACS_INT, not int.
3910 * dispextern.h (merge_faces):
3911 * xfaces.c (merge_faces):
3912 * xdisp.c (get_next_display_element, next_element_from_display_vector):
3913 Don't assume EMACS_INT fits in int.
3915 * character.h (CHAR_VALID_P): Remove unused parameter.
3916 * fontset.c, lisp.h, xdisp.c: All uses changed.
3918 * editfns.c (Ftranslate_region_internal): Omit redundant test.
3920 * fns.c (concat): Minor tuning based on overflow analysis.
3921 This doesn't fix any bugs. Use int to hold character, instead
3922 of constantly refetching from Emacs object. Use XFASTINT, not
3923 XINT, for value known to be a character. Don't bother comparing
3924 a single byte to 0400, as it's always less.
3926 * floatfns.c (Fexpt):
3927 * fileio.c (make_temp_name): Omit unnecessary cast to unsigned.
3929 * editfns.c (Ftranslate_region_internal): Use int, not EMACS_INT
3932 * doc.c (get_doc_string): Omit (unsigned)c that mishandled negatives.
3934 * data.c (Faset): If ARRAY is a string, check that NEWELT is a char.
3935 Without this fix, on a 64-bit host (aset S 0 4294967386) would
3936 incorrectly succeed when S was a string, because 4294967386 was
3937 truncated before it was used.
3939 * chartab.c (Fchar_table_range): Use CHARACTERP to check range.
3940 Otherwise, an out-of-range integer could cause undefined behavior
3943 * composite.c: Use int, not EMACS_INT, for characters.
3944 (fill_gstring_body, composition_compute_stop_pos): Use int, not
3945 EMACS_INT, for values that are known to be in character range.
3946 This doesn't fix any bugs but is the usual style inside Emacs and
3947 may generate better code on 32-bit machines.
3949 Make sure a 64-bit char is never passed to ENCODE_CHAR.
3950 This is for reasons similar to the recent CHAR_STRING fix.
3951 * charset.c (Fencode_char): Check that character arg is actually
3952 a character. Pass an int to ENCODE_CHAR.
3953 * charset.h (ENCODE_CHAR): Verify that the character argument is no
3954 wider than 'int', as a compile-time check to prevent future regressions
3957 * character.c (char_string): Remove unnecessary casts.
3959 Make sure a 64-bit char is never passed to CHAR_STRING.
3960 Otherwise, CHAR_STRING would do the wrong thing on a 64-bit platform,
3961 by silently ignoring the top 32 bits, allowing some values
3962 that were far too large to be valid characters.
3963 * character.h: Include <verify.h>.
3964 (CHAR_STRING, CHAR_STRING_ADVANCE): Verify that the character
3965 arguments are no wider than unsigned, as a compile-time check
3966 to prevent future regressions in this area.
3968 * editfns.c (Fchar_to_string, general_insert_function, Finsert_char)
3969 (Fsubst_char_in_region):
3971 * xdisp.c (decode_mode_spec_coding):
3972 Adjust to CHAR_STRING's new requirement.
3973 * editfns.c (Finsert_char, Fsubst_char_in_region):
3974 * fns.c (concat): Check that character args are actually
3975 characters. Without this test, these functions did the wrong
3976 thing with wildly out-of-range values on 64-bit hosts.
3978 Remove incorrect casts to 'unsigned' that lose info on 64-bit hosts.
3979 These casts should not be needed on 32-bit hosts, either.
3980 * keyboard.c (read_char):
3981 * lread.c (Fload): Remove casts to unsigned.
3983 * lisp.h (UNSIGNED_CMP): New macro.
3984 This fixes comparison bugs on 64-bit hosts.
3985 (ASCII_CHAR_P): Use it.
3986 * casefiddle.c (casify_object):
3987 * character.h (ASCII_BYTE_P, CHAR_VALID_P)
3988 (SINGLE_BYTE_CHAR_P, CHAR_STRING):
3989 * composite.h (COMPOSITION_ENCODE_RULE_VALID):
3990 * dispextern.h (FACE_FROM_ID):
3991 * keyboard.c (read_char): Use UNSIGNED_CMP.
3993 * xmenu.c (dialog_selection_callback) [!USE_GTK]: Cast to intptr_t,
3994 not to EMACS_INT, to avoid GCC warning.
3996 * xfns.c (x_set_scroll_bar_default_width): Remove unused 'int' locals.
3998 * buffer.h (PTR_BYTE_POS, BUF_PTR_BYTE_POS): Remove harmful cast.
3999 The cast incorrectly truncated 64-bit byte offsets to 32 bits, and
4000 isn't needed on 32-bit machines.
4002 * buffer.c (Fgenerate_new_buffer_name):
4003 Use EMACS_INT for count, not int.
4004 (advance_to_char_boundary): Return EMACS_INT, not int.
4006 * data.c (Qcompiled_function): Now static.
4008 * window.c (window_body_lines): Now static.
4010 * image.c (gif_load): Rename local to avoid shadowing.
4012 * lisp.h (SAFE_ALLOCA_LISP): Check for integer overflow.
4013 (struct Lisp_Save_Value): Use ptrdiff_t, not int, for 'integer' member.
4014 * alloc.c (make_save_value): Integer argument is now of type
4016 (mark_object): Use ptrdiff_t, not int.
4017 * lisp.h (pD): New macro.
4018 * print.c (print_object): Use it.
4020 * alloc.c: Use EMACS_INT, not int, to count objects.
4021 (total_conses, total_markers, total_symbols, total_vector_size)
4022 (total_free_conses, total_free_markers, total_free_symbols)
4023 (total_free_floats, total_floats, total_free_intervals)
4024 (total_intervals, total_strings, total_free_strings):
4025 Now EMACS_INT, not int. All uses changed.
4026 (Fgarbage_collect): Compute overall total using a double, so that
4027 integer overflow is less likely to be a problem. Check for overflow
4028 when converting back to an integer.
4029 (n_interval_blocks, n_string_blocks, n_float_blocks, n_cons_blocks)
4030 (n_vectors, n_symbol_blocks, n_marker_blocks): Remove.
4031 These were 'int' variables that could overflow on 64-bit hosts;
4032 they were never used, so remove them instead of repairing them.
4033 (nzombies, ngcs, max_live, max_zombies): Now EMACS_INT, not 'int'.
4034 (inhibit_garbage_collection): Set gc_cons_threshold to max value.
4035 Previously, this ceilinged at INT_MAX, but that doesn't work on
4037 (allocate_pseudovector): Don't use EMACS_INT when int would do.
4039 * alloc.c (Fmake_bool_vector): Don't assume vector size fits in int.
4040 (allocate_vectorlike): Check for ptrdiff_t overflow.
4041 (mark_vectorlike, mark_char_table, mark_object): Avoid EMACS_UINT
4042 when a (possibly-narrower) signed value would do just as well.
4043 We prefer using signed arithmetic, to avoid comparison confusion.
4045 * alloc.c: Catch some string size overflows that we were missing.
4046 (XMALLOC_OVERRUN_CHECK_SIZE) [!XMALLOC_OVERRUN_CHECK]: Define to 0,
4047 for convenience in STRING_BYTES_MAX.
4048 (STRING_BYTES_MAX): New macro, superseding the old one in lisp.h.
4049 The definition here is exact; the one in lisp.h was approximate.
4050 (allocate_string_data): Check for string overflow. This catches
4051 some instances we weren't catching before. Also, it catches
4052 size_t overflow on (unusual) hosts where SIZE_MAX <= min
4053 (PTRDIFF_MAX, MOST_POSITIVE_FIXNUM), e.g., when size_t is 32 bits
4054 and ptrdiff_t and EMACS_INT are both 64 bits.
4056 * character.c, coding.c, doprnt.c, editfns.c, eval.c:
4057 All uses of STRING_BYTES_MAX replaced by STRING_BYTES_BOUND.
4058 * lisp.h (STRING_BYTES_BOUND): Rename from STRING_BYTES_MAX.
4060 * character.c (string_escape_byte8): Fix nbytes/nchars typo.
4062 * alloc.c (Fmake_string): Check for out-of-range init.
4064 2011-06-15 Stefan Monnier <monnier@iro.umontreal.ca>
4066 * eval.c (Fdefvaralias): Also mark the target as variable-special-p.
4068 2011-06-14 Jan Djärv <jan.h.d@swipnet.se>
4070 * xfns.c (x_set_scroll_bar_default_width): Remove argument to
4071 xg_get_default_scrollbar_width.
4073 * gtkutil.c: Include emacsgtkfixed.h if HAVE_GTK3.
4074 (int_gtk_range_get_value): Move to the scroll bar part of the file.
4075 (style_changed_cb): Call update_theme_scrollbar_width and call
4076 x_set_scroll_bar_default_width and xg_frame_set_char_size for
4077 all frames (Bug#8505).
4078 (xg_create_frame_widgets): Call emacs_fixed_new if HAVE_GTK3 (Bug#8505).
4079 Call gtk_window_set_resizable if HAVE_GTK3.
4080 (x_wm_set_size_hint): Call emacs_fixed_set_min_size with min width
4081 and height if HAVE_GTK3 (Bug#8505).
4082 (scroll_bar_width_for_theme): New variable.
4083 (update_theme_scrollbar_width): New function.
4084 (xg_get_default_scrollbar_width): Move code to
4085 update_theme_scrollbar_width, just return scroll_bar_width_for_theme.
4086 (xg_initialize): Call update_theme_scrollbar_width.
4088 * gtkutil.h (xg_get_default_scrollbar_width): Remove argument.
4090 * emacsgtkfixed.c, emacsgtkfixed.h: New files.
4092 2011-06-12 Martin Rudalics <rudalics@gmx.at>
4094 * frame.c (make_frame): Call other_buffer_safely instead of
4097 * window.c (temp_output_buffer_show): Call display_buffer with
4098 second argument Vtemp_buffer_show_specifiers and reset latter
4099 immediately after the call.
4100 (Vtemp_buffer_show_specifiers): New variable.
4101 (auto_window_vscroll_p, next_screen_context_lines)
4102 (Vscroll_preserve_screen_position): Remove leading asterisks from
4105 2011-06-12 Paul Eggert <eggert@cs.ucla.edu>
4107 Fix minor problems found by GCC 4.6.0 static checking.
4108 * buffer.c (Qclone_number): Remove for now, as it's unused.
4109 (record_buffer, Funrecord_buffer): Rename local to avoid shadowing.
4110 (record_buffer): Remove unused local.
4111 * frame.c (other_visible_frames, frame_buffer_list): Now static.
4112 (set_frame_buffer_list): Remove; unused.
4113 * frame.h (other_visible_frames): Remove decl.
4114 * keyboard.h (menu_items_inuse): Declare only if USE_GTK || USE_MOTIF.
4115 * lisp.h (frame_buffer_list, set_frame_buffer_list): Remove decls.
4116 (add_gpm_wait_descriptor, delete_gpm_wait_descriptor): Declare only
4118 * menu.c (menu_items_inuse): Now static unless USE_GTK || USE_MOTIF.
4119 * process.c (add_gpm_wait_descriptor, delete_gpm_wait_descriptor):
4120 Define only if HAVE_GPM.
4121 * widget.c (EmacsFrameResize, emacsFrameClassRec): Now static.
4122 (update_hints_inhibit): Remove; never set. All uses removed.
4123 * widgetprv.h (emacsFrameClassRec): Remove decl.
4124 * window.c (delete_deletable_window): Now returns void, since it
4125 wasn't returning anything.
4126 (compare_window_configurations): Remove unused locals.
4127 * xfns.c (x_set_scroll_bar_default_width): Remove unused locals.
4128 * xmenu.c (x_menu_set_in_use): Define only if USE_GTK || USE_MOTIF.
4129 (dialog_selection_callback) [!USE_GTK]: Prefer intptr_t for integers
4130 the same widths as pointers. This follows up on the 2011-05-06 patch.
4131 * xterm.c (x_alloc_lighter_color_for_widget): Define only if USE_LUCID.
4132 * xterm.h: Likewise.
4133 (x_menu_set_in_use): Declare only if USE_GTK || USE_MOTIF.
4135 2011-06-12 Juanma Barranquero <lekktu@gmail.com>
4137 * makefile.w32-in: Update dependencies.
4138 (LISP_H): Add lib/intprops.h.
4140 2011-06-11 Chong Yidong <cyd@stupidchicken.com>
4142 * image.c (gif_load): Add animation frame delay to the metadata.
4143 (syms_of_image): Use DEFSYM. New symbol `delay'.
4145 2011-06-11 Martin Rudalics <rudalics@gmx.at>
4147 * window.c (delete_deletable_window): Re-add.
4148 (Fset_window_configuration): Rewrite to handle dead buffers and
4149 consequently deletable windows.
4150 (window_tree, Fwindow_tree): Remove. Supply functionality in
4152 (compare_window_configurations): Simplify code.
4154 2011-06-11 Andreas Schwab <schwab@linux-m68k.org>
4156 * image.c (imagemagick_load_image): Fix type mismatch.
4157 (Fimagemagick_types): Likewise.
4159 * window.h (replace_buffer_in_windows): Declare.
4161 2011-06-11 Martin Rudalics <rudalics@gmx.at>
4163 * buffer.c: New Lisp objects Qbuffer_list_update_hook and
4164 Qclone_number. Remove external declaration of Qdelete_window.
4165 (Fbuffer_list): Rewrite doc-string. Minor restructuring of
4167 (Fget_buffer_create, Fmake_indirect_buffer, Frename_buffer):
4168 Run Qbuffer_list_update_hook if allowed.
4169 (Fother_buffer): Rewrite doc-string. Major rewrite for new
4170 buffer list implementation.
4171 (other_buffer_safely): New function.
4172 (Fkill_buffer): Replace call to replace_buffer_in_all_windows by
4173 calls to replace_buffer_in_windows and
4174 replace_buffer_in_windows_safely. Run Qbuffer_list_update_hook
4176 (record_buffer): Inhibit quitting and rewrite using quittable
4177 functions. Run Qbuffer_list_update_hook if allowed.
4178 (Frecord_buffer, Funrecord_buffer): New functions.
4179 (switch_to_buffer_1, Fswitch_to_buffer): Remove.
4180 Move switch-to-buffer to window.el.
4181 (bury-buffer): Move to window.el.
4182 (Vbuffer_list_update_hook): New variable.
4184 * lisp.h (other_buffer_safely): Add prototype in buffer.c
4187 * window.h (resize_frame_windows): Move up in code.
4188 (Fwindow_frame): Remove EXFUN.
4189 (replace_buffer_in_all_windows): Remove prototype.
4190 (replace_buffer_in_windows_safely): Add prototype.
4192 * window.c: Declare Qdelete_window static again. Move down
4193 declaration of select_count.
4194 (Fnext_window, Fprevious_window): Rewrite doc-strings.
4195 (Fother_window): Move to window.el.
4196 (window_loop): Remove DELETE_BUFFER_WINDOWS and UNSHOW_BUFFER
4197 cases. Add REPLACE_BUFFER_IN_WINDOWS_SAFELY case.
4198 (Fdelete_windows_on, Freplace_buffer_in_windows): Move to
4200 (replace_buffer_in_windows): Implement by calling
4201 Qreplace_buffer_in_windows.
4202 (replace_buffer_in_all_windows): Remove with some functionality
4203 moved into replace_buffer_in_windows_safely.
4204 (replace_buffer_in_windows_safely): New function.
4205 (select_window_norecord, select_frame_norecord): Move in front
4206 of run_window_configuration_change_hook. Remove now obsolete
4208 (Fset_window_buffer): Rewrite doc-string.
4209 Call Qrecord_window_buffer.
4210 (keys_of_window): Move binding for other-window to window.el.
4212 2011-06-11 Chong Yidong <cyd@stupidchicken.com>
4214 * dispextern.h (struct image): Replace data member, whose int_val
4215 and ptr_val fields were not used by anything, with a single
4218 * image.c (Fimage_metadata, make_image, mark_image, tiff_load)
4219 (gif_clear_image, gif_load, imagemagick_load_image)
4220 (gs_clear_image, gs_load): Callers changed.
4222 2011-06-10 Paul Eggert <eggert@cs.ucla.edu>
4224 * buffer.h: Include <time.h>, for time_t.
4225 Needed to build on FreeBSD 8.2. Problem reported by Herbert J. Skuhra.
4227 Fix minor problems found by static checking.
4229 * image.c (PixelGetMagickColor): Declare if ImageMagick headers don't.
4231 Make identifiers static if they are not used in other modules.
4232 * data.c (Qcompiled_function, Qframe, Qvector):
4233 * image.c (QimageMagick, Qsvg):
4234 * minibuf.c (Qmetadata):
4235 * window.c (resize_window_check, resize_root_window): Now static.
4236 * window.h (resize_window_check, resize_root_window): Remove decls.
4238 * window.c (window_deletion_count, delete_deletable_window):
4240 (window_body_lines): Now static.
4241 (Fdelete_other_windows_internal): Mark vars as initialized.
4242 Make sure 'resize_failed' is initialized.
4243 (run_window_configuration_change_hook): Rename local to avoid shadowing.
4244 (resize_window_apply): Remove unused local.
4245 * window.h (delete_deletable_window): Remove decl.
4247 * image.c (gif_load, svg_load_image): Rename locals to avoid shadowing.
4248 (imagemagick_load_image): Fix pointer signedness problem by changing
4249 last arg from unsigned char * to char *. All uses changed.
4250 Also, fix a local for similar reasons.
4251 Remove unused locals. Remove locals to avoid shadowing.
4252 (fn_rsvg_handle_free): Remove; unused.
4253 (svg_load, svg_load_image): Fix pointer signedness problem.
4254 (imagemagick_load_image): Don't use garbage pointer image_wand.
4256 * ftfont.c (ftfont_get_metrics, ftfont_drive_otf): Remove unused locals.
4258 2011-06-10 Chong Yidong <cyd@stupidchicken.com>
4260 * image.c (gif_load): Fix omitted cast error introduced by
4263 2011-06-10 Martin Rudalics <rudalics@gmx.at>
4265 * window.h (resize_proportionally, orig_total_lines)
4266 (orig_top_line): Remove from window structure.
4267 (set_window_height, set_window_width, change_window_heights)
4268 (Fdelete_window): Remove prototypes.
4269 (resize_frame_windows): Remove duplicate declaration.
4271 2011-06-10 Eli Zaretskii <eliz@gnu.org>
4273 * window.h (resize_frame_windows, resize_window_check)
4274 (delete_deletable_window, resize_root_window)
4275 (resize_frame_windows): Declare prototypes.
4277 * window.c (resize_window_apply): Make definition be "static" to
4278 match the prototype.
4280 2011-06-10 Martin Rudalics <rudalics@gmx.at>
4282 * window.c: Remove declarations of Qwindow_size_fixed,
4283 window_min_size_1, window_min_size_2, window_min_size,
4284 size_window, window_fixed_size_p, enlarge_window, delete_window.
4285 Remove static from declaration of Qdelete_window, it's
4286 temporarily needed by Fbury_buffer.
4287 (replace_window): Don't assign orig_top_line and
4289 (Fdelete_window, delete_window): Remove. Window deletion is
4290 handled by window.el.
4291 (window_loop): Remove DELETE_OTHER_WINDOWS case.
4292 Replace Fdelete_window calls with calls to Qdelete_window.
4293 (Fdelete_other_windows): Remove. Deleting other windows is
4294 handled by window.el.
4295 (window_fixed_size_p): Remove. Fixed-sizeness of windows is
4296 handled in window.el.
4297 (window_min_size_2, window_min_size_1, window_min_size): Remove.
4298 Window minimum sizes are handled in window.el.
4299 (shrink_windows, size_window, set_window_height)
4300 (set_window_width, change_window_heights, window_height)
4301 (window_width, CURBEG, CURSIZE, enlarge_window)
4302 (adjust_window_trailing_edge, Fadjust_window_trailing_edge)
4303 (Fenlarge_window, Fshrink_window): Remove. Window resizing is
4304 handled in window.el.
4305 (make_dummy_parent): Rename to make_parent_window and give it a
4306 second argument horflag.
4307 (make_window): Don't set resize_proportionally any more.
4308 (Fsplit_window): Remove. Windows are split in window.el.
4309 (save_restore_action, save_restore_orig_size)
4310 (shrink_window_lowest_first, save_restore_orig_size): Remove.
4311 Resize mini windows in window.el.
4312 (grow_mini_window, shrink_mini_window): Implement by calling
4313 Qresize_root_window_vertically, resize_window_check and
4314 resize_window_apply.
4315 (saved_window, Fset_window_configuration, save_window_save):
4316 Do not handle orig_top_line, orig_total_lines, and
4317 resize_proportionally.
4318 (window_min_height, window_min_width): Move to window.el.
4319 (keys_of_window): Move bindings for delete-other-windows,
4320 split-window, delete-window and enlarge-window to window.el.
4322 * buffer.c: Temporarily extern Qdelete_window.
4323 (Fbury_buffer): Temporarily call Qdelete_window instead of
4324 Fdelete_window (Fbury_buffer will move to window.el soon).
4326 * frame.c (set_menu_bar_lines_1): Remove code handling
4327 orig_top_line and orig_total_lines.
4329 * dispnew.c (adjust_frame_glyphs_initially): Don't use
4330 set_window_height but set heights directly.
4331 (change_frame_size_1): Use resize_frame_windows.
4333 * xdisp.c (init_xdisp): Don't use set_window_height but set
4336 * xfns.c (x_set_menu_bar_lines, x_set_tool_bar_lines):
4337 Use resize_frame_windows instead of change_window_heights and run
4338 run_window_configuration_change_hook.
4340 * w32fns.c (x_set_tool_bar_lines): Use resize_frame_windows
4341 instead of change_window_heights and run
4342 run_window_configuration_change_hook.
4344 2011-06-09 Martin Rudalics <rudalics@gmx.at>
4346 * window.c (replace_window): Rename second argument REPLACEMENT to
4347 NEW. New third argument SETFLAG. Rewrite.
4348 (delete_window, make_dummy_parent): Call replace_window with
4350 (window_list_1): Move down in code.
4351 (run_window_configuration_change_hook): Move set_buffer part
4352 before select_frame_norecord part in order to unwind correctly.
4353 Rename count1 to count.
4354 (recombine_windows, delete_deletable_window, resize_root_window)
4355 (Fdelete_other_windows_internal)
4356 (Frun_window_configuration_change_hook, make_parent_window)
4357 (resize_window_check, resize_window_apply, Fresize_window_apply)
4358 (resize_frame_windows, Fsplit_window_internal)
4359 (Fdelete_window_internal, Fresize_mini_window_internal):
4361 (syms_of_window): New variables Vwindow_splits and Vwindow_nest.
4363 2011-06-08 Martin Rudalics <rudalics@gmx.at>
4365 * window.h (window): Add some new members to window structure -
4366 normal_lines, normal_cols, new_total, new_normal, clone_number,
4367 splits, nest, prev_buffers, next_buffers.
4368 (WINDOW_TOTAL_SIZE): Move here from window.c.
4369 (MIN_SAFE_WINDOW_WIDTH, MIN_SAFE_WINDOW_HEIGHT): Define here.
4371 * window.c (Fwindow_height, Fwindow_width, Fwindow_full_width_p):
4373 (make_dummy_parent): Set new members of windows structure.
4374 (make_window): Move down in code. Handle new members of window
4376 (Fwindow_clone_number, Fwindow_splits, Fset_window_splits)
4377 (Fwindow_nest, Fset_window_nest, Fwindow_new_total)
4378 (Fwindow_normal_size, Fwindow_new_normal, Fwindow_prev_buffers)
4379 (Fset_window_prev_buffers, Fwindow_next_buffers)
4380 (Fset_window_next_buffers, Fset_window_clone_number):
4382 (Fwindow_hscroll, Fwindow_at, Fwindow_point, Fwindow_start)
4383 (Fwindow_end, Fwindow_line_height, Fset_window_dedicated_p):
4385 (Fwindow_parameters, Fwindow_parameter, Fset_window_parameter):
4386 Argument WINDOW can be now internal window too.
4387 (Fwindow_use_time): Move up in code.
4388 (Fget_buffer_window): Rename argument FRAME to ALL-FRAMES.
4390 (Fset_window_configuration, saved_window)
4391 (Fcurrent_window_configuration, save_window_save): Handle new
4392 members of window structure.
4393 (WINDOW_TOTAL_SIZE, MIN_SAFE_WINDOW_WIDTH)
4394 (MIN_SAFE_WINDOW_HEIGHT): Move to window.h.
4395 (syms_of_window): New Lisp objects Qrecord_window_buffer,
4396 Qwindow_deletable_p, Qdelete_window, Qreplace_buffer_in_windows,
4397 Qget_mru_window, Qresize_root_window,
4398 Qresize_root_window_vertically, Qsafe, Qabove, Qbelow,
4399 Qauto_buffer_name; staticpro them.
4401 2011-06-07 Martin Rudalics <rudalics@gmx.at>
4403 * window.c (Fwindow_total_size, Fwindow_left_column)
4404 (Fwindow_top_line, window_body_lines, Fwindow_body_size)
4405 (Fwindow_list_1): New functions.
4406 (window_box_text_cols): Replace with window_body_cols.
4407 (Fwindow_width, Fscroll_left, Fscroll_right):
4408 Use window_body_cols instead of window_box_text_cols.
4409 (delete_window, Fset_window_configuration):
4410 Call delete_all_subwindows with window as argument.
4411 (delete_all_subwindows): Take a window as argument and not a
4413 (window_loop): Remove handling of GET_LRU_WINDOW and
4415 (Fget_lru_window, Fget_largest_window): Move to window.el.
4417 * window.h: Extern window_body_cols instead of
4418 window_box_text_cols. delete_all_subwindows now takes a
4419 Lisp_Object as argument.
4421 * indent.c (compute_motion, Fcompute_motion):
4422 Use window_body_cols instead of window_box_text_cols.
4424 * frame.c (delete_frame): Call delete_all_subwindows with root
4427 2011-06-07 Daniel Colascione <dan.colascione@gmail.com>
4429 * fns.c (Fputhash): Document return value.
4431 2011-06-06 Chong Yidong <cyd@stupidchicken.com>
4433 * image.c (gif_load): Implement gif89a spec "no disposal" method.
4435 2011-06-06 Paul Eggert <eggert@cs.ucla.edu>
4437 Cons<->int and similar integer overflow fixes (Bug#8794).
4439 Check for overflow when converting integer to cons and back.
4440 * charset.c (Fdefine_charset_internal, Fdecode_char):
4441 Use cons_to_unsigned to catch overflow.
4442 (Fencode_char): Use INTEGER_TO_CONS.
4443 * composite.h (LGLYPH_CODE): Use cons_to_unsigned.
4444 (LGLYPH_SET_CODE): Use INTEGER_TO_CONS.
4445 * data.c (long_to_cons, cons_to_long): Remove.
4446 (cons_to_unsigned, cons_to_signed): New functions.
4447 These signal an error for invalid or out-of-range values.
4448 * dired.c (Ffile_attributes): Use INTEGER_TO_CONS.
4449 * fileio.c (Fset_visited_file_modtime): Use CONS_TO_INTEGER.
4450 * font.c (Ffont_variation_glyphs):
4451 * fontset.c (Finternal_char_font): Use INTEGER_TO_CONS.
4452 * lisp.h: Include <intprops.h>.
4453 (INTEGER_TO_CONS, CONS_TO_INTEGER): New macros.
4454 (cons_to_signed, cons_to_unsigned): New decls.
4455 (long_to_cons, cons_to_long): Remove decls.
4456 * undo.c (record_first_change): Use INTEGER_TO_CONS.
4457 (Fprimitive_undo): Use CONS_TO_INTEGER.
4458 * xfns.c (Fx_window_property): Likewise.
4459 * xselect.c: Include <limits.h>.
4460 (x_own_selection, selection_data_to_lisp_data):
4461 Use INTEGER_TO_CONS.
4462 (x_handle_selection_request, x_handle_selection_clear)
4463 (x_get_foreign_selection, Fx_disown_selection_internal)
4464 (Fx_get_atom_name, x_send_client_event): Use CONS_TO_INTEGER.
4465 (lisp_data_to_selection_data): Use cons_to_unsigned.
4466 (x_fill_property_data): Use cons_to_signed.
4467 Report values out of range.
4469 Check for buffer and string overflow more precisely.
4470 * buffer.h (BUF_BYTES_MAX): New macro.
4471 * lisp.h (STRING_BYTES_MAX): New macro.
4472 * alloc.c (Fmake_string):
4473 * character.c (string_escape_byte8):
4474 * coding.c (coding_alloc_by_realloc):
4475 * doprnt.c (doprnt):
4476 * editfns.c (Fformat):
4478 Use STRING_BYTES_MAX, not MOST_POSITIVE_FIXNUM,
4479 since they may not be the same number.
4480 * editfns.c (Finsert_char):
4481 * fileio.c (Finsert_file_contents):
4482 Likewise for BUF_BYTES_MAX.
4484 * image.c: Use ptrdiff_t, not int, for sizes.
4485 (slurp_file): Switch from int to ptrdiff_t.
4487 (slurp_file): Check that file size fits in both size_t (for
4488 malloc) and ptrdiff_t (for sanity and safety).
4490 * fileio.c (Fverify_visited_file_modtime): Avoid time overflow
4491 if b->modtime has its maximal value.
4493 * dired.c (Ffile_attributes): Don't assume EMACS_INT has >32 bits.
4495 Don't assume time_t can fit into int.
4496 * buffer.h (struct buffer.modtime): Now time_t, not int.
4497 * fileio.c (Fvisited_file_modtime): No need for time_t cast now.
4498 * undo.c (Fprimitive_undo): Use time_t, not int, for time_t value.
4500 Minor fixes for signed vs unsigned integers.
4501 * character.h (MAYBE_UNIFY_CHAR):
4502 * charset.c (maybe_unify_char):
4503 * keyboard.c (read_char, reorder_modifiers):
4504 XINT -> XFASTINT, since the integer must be nonnegative.
4505 * ftfont.c (ftfont_spec_pattern):
4506 * keymap.c (access_keymap, silly_event_symbol_error):
4507 XUINT -> XFASTINT, since the integer must be nonnegative.
4508 (Fsingle_key_description, preferred_sequence_p): XUINT -> XINT,
4509 since it makes no difference and we prefer signed.
4510 * keyboard.c (record_char): Use XUINT when all the neighbors do.
4511 (access_keymap): NATNUMP -> INTEGERP, since the integer must be
4514 2011-06-06 Stefan Monnier <monnier@iro.umontreal.ca>
4516 * window.h (Fwindow_frame): Declare.
4518 2011-06-06 Paul Eggert <eggert@cs.ucla.edu>
4520 * alloc.c: Simplify handling of large-request failures (Bug#8800).
4521 (SPARE_MEMORY): Always define.
4522 (LARGE_REQUEST): Remove.
4523 (memory_full): Use SPARE_MEMORY rather than LARGE_REQUEST.
4525 2011-06-06 Martin Rudalics <rudalics@gmx.at>
4527 * lisp.h: Move EXFUNS for Fframe_root_window,
4528 Fframe_first_window and Fset_frame_selected_window to window.h.
4530 * window.h: Move EXFUNS for Fframe_root_window,
4531 Fframe_first_window and Fset_frame_selected_window here from
4534 * frame.c (Fwindow_frame, Fframe_first_window)
4535 (Fframe_root_window, Fframe_selected_window)
4536 (Fset_frame_selected_window): Move to window.c.
4537 (Factive_minibuffer_window): Move to minibuf.c.
4538 (Fother_visible_frames_p): New function.
4540 * minibuf.c (Factive_minibuffer_window): Move here from frame.c.
4542 * window.c (decode_window, decode_any_window): Move up in code.
4543 (Fwindowp, Fwindow_live_p): Rewrite doc-strings.
4544 (inhibit_frame_unsplittable): Remove unused variable.
4545 (Fwindow_buffer): Move up and rewrite doc-string.
4546 (Fwindow_parent, Fwindow_vchild, Fwindow_hchild, Fwindow_next)
4547 (Fwindow_prev): New functions.
4548 (Fwindow_frame): Move here from frame.c. Accept any window as
4550 (Fframe_root_window, Fframe_first_window)
4551 (Fframe_selected_window): Move here from frame.c. Accept frame
4552 or arbitrary window as argument. Update doc-strings.
4553 (Fminibuffer_window): Move up in code.
4554 (Fwindow_minibuffer_p): Move up in code and simplify.
4555 (Fset_frame_selected_window): Move here from frame.c.
4557 (Fselected_window, select_window, Fselect_window): Move up in
4558 code. Minor doc-string fixes.
4560 2011-06-06 Paul Eggert <eggert@cs.ucla.edu>
4562 * alloc.c (memory_full) [SYSTEM_MALLOC]: Port to MacOS (Bug#8800).
4563 Do not assume that spare memory exists; that assumption is valid
4564 only if SYSTEM_MALLOC.
4565 (LARGE_REQUEST): New macro, so that the issue of large requests
4566 is separated from the issue of spare memory.
4568 2011-06-05 Andreas Schwab <schwab@linux-m68k.org>
4570 * editfns.c (Fformat): Correctly handle zero flag with hexadecimal
4573 * gtkutil.c (xg_get_default_scrollbar_width): Avoid warning.
4575 * xfns.c (x_set_scroll_bar_default_width): Move declarations
4578 2011-06-05 Jan Djärv <jan.h.d@swipnet.se>
4580 * gtkutil.c (xg_get_default_scrollbar_width): New function.
4582 * gtkutil.h: Declare xg_get_default_scrollbar_width.
4584 * xfns.c (x_set_scroll_bar_default_width): If USE_GTK, get
4585 min width by calling x_set_scroll_bar_default_width (Bug#8505).
4587 2011-06-05 Juanma Barranquero <lekktu@gmail.com>
4589 * xdisp.c (single_display_spec_intangible_p): Remove declaration.
4591 2011-06-04 Chong Yidong <cyd@stupidchicken.com>
4593 * xselect.c (x_clipboard_manager_save): Remove redundant arg.
4594 (x_clipboard_manager_save): Add return value.
4595 (x_clipboard_manager_error_1, x_clipboard_manager_error_2):
4597 (x_clipboard_manager_save_frame, x_clipboard_manager_save_all):
4598 Obey Vx_select_enable_clipboard_manager. Catch errors in
4599 x_clipboard_manager_save (Bug#8779).
4600 (Vx_select_enable_clipboard_manager): New variable.
4601 (x_get_foreign_selection): Reduce scope of x_catch_errors (Bug#8790).
4603 2011-06-04 Dan Nicolaescu <dann@ics.uci.edu>
4605 * emacs.c (main): Warn when starting a GTK emacs in daemon mode.
4607 2011-06-04 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
4609 * fringe.c (update_window_fringes): Don't update overlay arrow bitmap
4610 in the current matrix if keep_current_p is non-zero.
4612 2011-06-04 Eli Zaretskii <eliz@gnu.org>
4614 * bidi.c (bidi_level_of_next_char): Fix last change.
4616 2011-06-03 Eli Zaretskii <eliz@gnu.org>
4618 Support bidi reordering of text covered by display properties.
4620 * bidi.c (bidi_copy_it): Use offsetof instead of emulating it.
4621 (bidi_fetch_char, bidi_fetch_char_advance): New functions.
4622 (bidi_cache_search, bidi_cache_iterator_state)
4623 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak)
4624 (bidi_level_of_next_char, bidi_move_to_visually_next):
4625 Support character positions inside a run of characters covered by a
4627 (bidi_paragraph_init, bidi_resolve_explicit_1)
4628 (bidi_level_of_next_char): Call bidi_fetch_char and
4629 bidi_fetch_char_advance instead of FETCH_CHAR and
4631 (bidi_init_it): Initialize new members.
4632 (LRE_CHAR, RLE_CHAR, PDF_CHAR, LRO_CHAR, RLO_CHAR): Remove macro
4634 (bidi_explicit_dir_char): Lookup character type in bidi_type_table,
4635 instead of using explicit *_CHAR codes.
4636 (bidi_resolve_explicit, bidi_resolve_weak):
4637 Use FETCH_MULTIBYTE_CHAR instead of FETCH_CHAR, as reordering of
4638 bidirectional text is supported only in multibyte buffers.
4639 (bidi_init_it): Accept additional argument FRAME_WINDOW_P and use
4640 it to initialize the frame_window_p member of struct bidi_it.
4641 (bidi_cache_iterator_state, bidi_resolve_explicit_1)
4642 (bidi_resolve_explicit, bidi_resolve_weak)
4643 (bidi_level_of_next_char, bidi_move_to_visually_next): Abort if
4644 bidi_it->nchars is non-positive.
4645 (bidi_level_of_next_char): Don't try to lookup the cache for the
4646 next/previous character if nothing is cached there yet, or if we
4647 were just reseat()'ed to a new position.
4649 * xdisp.c (set_cursor_from_row): Set start and stop points
4650 according to the row's direction when priming the loop that looks
4651 for the glyph on which to display cursor.
4652 (single_display_spec_intangible_p): Function deleted.
4653 (display_prop_intangible_p): Reimplement to call
4654 handle_display_spec instead of single_display_spec_intangible_p.
4655 Accept 3 additional arguments needed by handle_display_spec.
4656 This fixes incorrect cursor motion across display property with complex
4657 values: lists, `(when COND...)' forms, etc.
4658 (single_display_spec_string_p): Support property values that are
4659 lists with the argument STRING its top-level element.
4660 (display_prop_string_p): Fix the condition for processing a
4661 property that is a list to be consistent with handle_display_spec.
4662 (handle_display_spec): New function, refactored from the
4663 last portion of handle_display_prop.
4664 (compute_display_string_pos): Accept additional argument
4665 FRAME_WINDOW_P. Call handle_display_spec to determine whether the
4666 value of a `display' property is a "replacing spec".
4667 (handle_single_display_spec): Accept 2 additional arguments BUFPOS
4668 and FRAME_WINDOW_P. If IT is NULL, don't set up the iterator from
4669 the display property, but just return a value indicating whether
4670 the display property will replace the characters it covers.
4671 (Fcurrent_bidi_paragraph_direction): Initialize the nchars and
4672 frame_window_p members of struct bidi_it.
4673 (compute_display_string_pos, compute_display_string_end):
4675 (push_it): Accept second argument POSITION, where pop_it should
4676 jump to continue iteration.
4677 (reseat_1): Initialize bidi_it.disp_pos.
4679 * keyboard.c (adjust_point_for_property): Adjust the call to
4680 display_prop_intangible_p to its new signature.
4682 * dispextern.h (struct bidi_it): New member frame_window_p.
4683 (bidi_init_it): Update prototypes.
4684 (display_prop_intangible_p): Update prototype.
4685 (compute_display_string_pos, compute_display_string_end):
4687 (struct bidi_it): New members nchars and disp_pos. ch_len is now
4690 2011-06-02 Paul Eggert <eggert@cs.ucla.edu>
4692 Malloc failure behavior now depends on size of allocation.
4693 * alloc.c (buffer_memory_full, memory_full): New arg NBYTES.
4694 * lisp.h: Change signatures accordingly.
4695 * alloc.c, buffer.c, editfns.c, menu.c, minibuf.c, xterm.c:
4696 All callers changed. (Bug#8762)
4698 * gnutls.c: Use Emacs's memory allocators.
4699 Without this change, the gnutls library would invoke malloc etc.
4700 directly, which causes problems on non-SYNC_INPUT hosts, and which
4701 runs afoul of improving memory_full behavior. (Bug#8761)
4702 (fn_gnutls_global_set_mem_functions): New macro or function pointer.
4703 (emacs_gnutls_global_init): Use it to specify xmalloc, xrealloc,
4704 xfree instead of the default malloc, realloc, free.
4705 (Fgnutls_boot): No need to check for memory allocation failure,
4706 since xmalloc does that for us.
4708 Remove arbitrary limit of 2**31 entries in hash tables. (Bug#8771)
4709 * category.c (hash_get_category_set):
4710 * ccl.c (ccl_driver):
4711 * charset.c (Fdefine_charset_internal):
4712 * charset.h (struct charset.hash_index):
4713 * composite.c (get_composition_id, gstring_lookup_cache)
4714 (composition_gstring_put_cache):
4715 * composite.h (struct composition.hash_index):
4716 * dispextern.h (struct image.hash):
4717 * fns.c (next_almost_prime, larger_vector, cmpfn_eql)
4718 (cmpfn_equal, cmpfn_user_defined, hashfn_eq, hashfn_eql)
4719 (hashfn_equal, hashfn_user_defined, make_hash_table)
4720 (maybe_resize_hash_table, hash_lookup, hash_put)
4721 (hash_remove_from_table, hash_clear, sweep_weak_table, SXHASH_COMBINE)
4722 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector)
4723 (Fsxhash, Fgethash, Fputhash, Fmaphash):
4724 * image.c (make_image, search_image_cache, lookup_image)
4725 (xpm_put_color_table_h):
4726 * lisp.h (struct Lisp_Hash_Table):
4727 * minibuf.c (Ftry_completion, Fall_completions, Ftest_completion):
4728 * print.c (print): Use 'EMACS_UINT' and 'EMACS_INT'
4729 for hashes and hash indexes, instead of 'unsigned' and 'int'.
4730 * alloc.c (allocate_vectorlike):
4731 Check for overflow in vector size calculations.
4732 * ccl.c (ccl_driver):
4733 Check for overflow when converting EMACS_INT to int.
4734 * fns.c, image.c: Remove unnecessary static decls that would otherwise
4735 need to be updated by these changes.
4736 * fns.c (make_hash_table, maybe_resize_hash_table):
4737 Check for integer overflow with large hash tables.
4738 (make_hash_table, maybe_resize_hash_table, Fmake_hash_table):
4739 Prefer the faster XFLOAT_DATA to XFLOATINT where either will do.
4740 (SXHASH_REDUCE): New macro.
4741 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector):
4742 Use it instead of discarding useful hash info with large hash values.
4743 (sxhash_float): New function.
4744 (sxhash): Use it. No more need for "& INTMASK" due to above changes.
4745 * lisp.h (FIXNUM_BITS): New macro, useful for SXHASH_REDUCE etc.
4746 (MOST_NEGATIVE_FIXNUM, MOST_POSITIVE_FIXNUM, INTMASK):
4747 Rewrite to use FIXNUM_BITS, as this simplifies things.
4748 (next_almost_prime, larger_vector, sxhash, hash_lookup, hash_put):
4749 Adjust signatures to match updated version of code.
4750 (consing_since_gc): Now EMACS_INT, since a single hash table can
4751 use more than INT_MAX bytes.
4753 2011-06-01 Dan Nicolaescu <dann@ics.uci.edu>
4755 Make it possible to build with GCC-4.6+ -O2 -flto.
4757 * emacs.c (__malloc_initialize_hook): Mark as EXTERNALLY_VISIBLE.
4759 2011-06-01 Stefan Monnier <monnier@iro.umontreal.ca>
4761 * minibuf.c (get_minibuffer, read_minibuf_unwind):
4762 Call minibuffer-inactive-mode.
4764 2011-05-31 Juanma Barranquero <lekktu@gmail.com>
4766 * makefile.w32-in ($(BLD)/data.$(O), $(BLD)/editfns.$(O)):
4767 Update dependencies.
4769 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
4771 * data.c (init_data): Remove code for UTS, this system is not
4774 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
4776 Don't force ./temacs to start in terminal mode.
4778 * frame.c (make_initial_frame): Initialize faces in all cases, not
4779 only when CANNOT_DUMP is defined.
4780 * dispnew.c (init_display): Remove CANNOT_DUMP condition.
4782 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
4784 * dispnew.c (add_window_display_history): Use const for the string
4785 pointer. Remove declaration, not needed.
4787 2011-05-31 Paul Eggert <eggert@cs.ucla.edu>
4789 Use 'inline', not 'INLINE'.
4790 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00914.html>
4791 * alloc.c, fontset.c (INLINE): Remove.
4792 * alloc.c, bidi.c, charset.c, coding.c, dispnew.c, fns.c, image.c:
4793 * intervals.c, keyboard.c, process.c, syntax.c, textprop.c, w32term.c:
4794 * xdisp.c, xfaces.c, xterm.c: Replace all uses of INLINE with inline.
4795 * gmalloc.c (register_heapinfo): Use inline unconditionally.
4796 * lisp.h (LISP_MAKE_RVALUE): Use inline, not __inline__.
4798 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
4800 Make it possible to run ./temacs.
4802 * callproc.c (set_initial_environment): Remove CANNOT_DUMP code,
4803 syms_of_callproc does the same thing. Remove test for
4804 "initialized", do it in the caller.
4805 * emacs.c (main): Avoid calling set_initial_environment when dumping.
4807 2011-05-31 Stefan Monnier <monnier@iro.umontreal.ca>
4809 * minibuf.c (Finternal_complete_buffer): Return `category' metadata.
4810 (read_minibuf): Use get_minibuffer.
4811 (syms_of_minibuf): Use DEFSYM.
4812 (Qmetadata): New var.
4813 * data.c (Qbuffer): Don't make it static.
4814 (syms_of_data): Use DEFSYM.
4816 2011-05-31 Paul Eggert <eggert@cs.ucla.edu>
4818 * ccl.c (CCL_CODE_RANGE): Allow negative numbers. (Bug#8751)
4819 (CCL_CODE_MIN): New macro.
4821 2011-05-30 Paul Eggert <eggert@cs.ucla.edu>
4823 * alloc.c (lisp_align_malloc): Omit unnecessary val==NULL tests.
4825 * eval.c (Qdebug): Now static.
4826 * lisp.h (Qdebug): Remove decl. This reverts a part of the
4827 2011-04-26T11:26:05Z!dan.colascione@gmail.com that inadvertently undid part of
4828 2011-04-14T06:48:41Z!eggert@cs.ucla.edu.
4830 2011-05-29 Chong Yidong <cyd@stupidchicken.com>
4832 * image.c: Various fixes to ImageMagick code comments.
4833 (Fimagemagick_types): Doc fix.
4835 2011-05-29 Paul Eggert <eggert@cs.ucla.edu>
4837 Minor fixes prompted by GCC 4.6.0 warnings.
4839 * xselect.c (converted_selections, conversion_fail_tag): Now static.
4841 * emacs.c [HAVE_X_WINDOWS]: Include "xterm.h".
4842 (x_clipboard_manager_save_all): Move extern decl to ...
4843 * xterm.h: ... here, so that it can be checked for consistency.
4845 2011-05-29 Chong Yidong <cyd@stupidchicken.com>
4847 * xselect.c (x_clipboard_manager_save_frame)
4848 (x_clipboard_manager_save_all): New functions.
4849 (Fx_clipboard_manager_save): Lisp function deleted.
4851 * emacs.c (Fkill_emacs): Call x_clipboard_manager_save_all.
4852 * frame.c (delete_frame): Call x_clipboard_manager_save_frame.
4854 * xterm.h: Update prototype.
4856 2011-05-28 William Xu <william.xwl@gmail.com>
4858 * nsterm.m (ns_term_shutdown): Synchronize user defaults before
4861 2011-05-28 Jim Meyering <meyering@redhat.com>
4863 Avoid a sign-extension bug in crypto_hash_function.
4864 * fns.c (to_uchar): Define.
4865 (crypto_hash_function): Use it to convert some newly-signed
4866 variables to unsigned, to avoid sign-extension bugs. For example,
4867 without this change, (md5 "truc") would evaluate to
4868 45723a2aff78ff4fff7fff1114760e62 rather than the expected
4869 45723a2af3788c4ff17f8d1114760e62. Reported by Antoine Levitt in
4870 https://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00883.html.
4872 2011-05-27 Paul Eggert <eggert@cs.ucla.edu>
4874 Integer overflow fixes.
4876 * dbusbind.c: Serial number integer overflow fixes.
4877 (CHECK_DBUS_SERIAL_GET_SERIAL): New macro.
4878 (Fdbus_call_method_asynchronously, xd_read_message_1): Use a float
4879 to hold a serial number that is too large for a fixnum.
4880 (Fdbus_method_return_internal, Fdbus_method_error_internal):
4881 Check for serial numbers out of range. Decode any serial number
4882 that was so large that it became a float. (Bug#8722)
4884 * dbusbind.c: Use XFASTINT rather than XUINT, and check for nonneg.
4885 (Fdbus_call_method, Fdbus_call_method_asynchronously):
4886 Use XFASTINT rather than XUINT when numbers are nonnegative.
4887 (xd_append_arg, Fdbus_method_return_internal):
4888 (Fdbus_method_error_internal): Likewise. Also, for unsigned
4889 arguments, check that Lisp number is nonnegative, rather than
4890 silently wrapping negative numbers around. (Bug#8722)
4891 (xd_read_message_1): Don't assume dbus_uint32_t can fit in int.
4894 * data.c (arith_driver, Flsh): Avoid unnecessary casts to EMACS_UINT.
4896 * ccl.c (ccl_driver): Redo slightly to avoid the need for 'unsigned'.
4898 ccl: add integer overflow checks
4899 * ccl.c (CCL_CODE_MAX, GET_CCL_RANGE, GET_CCL_CODE, GET_CCL_INT):
4900 (IN_INT_RANGE): New macros.
4901 (ccl_driver): Use them to check for integer overflow when
4902 decoding a CCL program. Many of the new checks are whether XINT (x)
4903 fits in int; it doesn't always, on 64-bit hosts. The new version
4904 doesn't catch all possible integer overflows, but it's an
4905 improvement. (Bug#8719)
4907 * alloc.c (make_event_array): Use XINT, not XUINT.
4908 There's no need for unsigned here.
4910 * mem-limits.h (EXCEEDS_LISP_PTR) [!USE_LSB_TAG]: EMACS_UINT -> uintptr_t
4911 This follows up to the 2011-05-06 change that substituted uintptr_t
4912 for EMACS_INT. This case wasn't caught back then.
4914 Rework Fformat to avoid integer overflow issues.
4915 * editfns.c: Include <float.h> unconditionally, as it's everywhere
4916 now (part of C89). Include <verify.h>.
4917 (MAX_10_EXP, CONVERTED_BYTE_SIZE): Remove; no longer needed.
4918 (pWIDE, pWIDElen, signed_wide, unsigned_wide): New defns.
4919 (Fformat): Avoid the prepass trying to compute sizes; it was only
4920 approximate and thus did not catch overflow reliably. Instead, walk
4921 through the format just once, formatting and computing sizes as we go,
4922 checking for integer overflow at every step, and allocating a larger
4923 buffer as needed. Keep track separately whether the format is
4924 multibyte. Keep only the most-recently calculated precision, rather
4925 than them all. Record whether each argument has been converted to
4926 string. Use EMACS_INT, not int, for byte and char and arg counts.
4927 Support field widths and precisions larger than INT_MAX. Avoid
4928 sprintf's undefined behavior with conversion specifications such as %#d
4929 and %.0c. Fix bug with strchr succeeding on '\0' when looking for
4930 flags. Fix bug with (format "%c" 256.0). Avoid integer overflow when
4931 formatting out-of-range floating point numbers with int
4934 * lisp.h (FIXNUM_OVERFLOW_P): Work even if arg is a NaN.
4936 * data.c: Avoid integer truncation in expressions involving floats.
4937 * data.c: Include <intprops.h>.
4938 (arith_driver): When there's an integer overflow in an expression
4939 involving floating point, convert the integers to floating point
4940 so that the resulting value does not suffer from catastrophic
4941 integer truncation. For example, on a 64-bit host (* 4
4942 most-negative-fixnum 0.5) should yield about -4.6e+18, not zero.
4943 Do not rely on undefined behavior after integer overflow.
4945 merge count_size_as_multibyte, parse_str_to_multibyte
4946 * character.c, character.h (count_size_as_multibyte):
4947 Rename from parse_str_to_multibyte; all uses changed.
4948 Check for integer overflow.
4949 * insdel.c, lisp.h (count_size_as_multibyte): Remove,
4950 since it's now a duplicate of the other. This is more of
4951 a character than a buffer op, so better that it's in character.c.
4952 * fns.c, print.c: Adjust to above changes.
4954 2011-05-27 Stefan Monnier <monnier@iro.umontreal.ca>
4956 * xselect.c (x_convert_selection): Yet another int/Lisp_Object mixup.
4958 2011-05-27 Paul Eggert <eggert@cs.ucla.edu>
4960 * xselect.c: Fix minor problems prompted by GCC 4.6.0 warnings.
4961 (x_handle_selection_request, frame_for_x_selection): Remove unused vars.
4962 (x_clipboard_manager_save): Now static.
4963 (Fx_clipboard_manager_save): Rename local to avoid shadowing.
4965 * fns.c: Fix minor problems prompted by GCC 4.6.0 warnings.
4966 (crypto_hash_function): Now static.
4967 Fix pointer signedness problems. Avoid unnecessary initializations.
4969 2011-05-27 Chong Yidong <cyd@stupidchicken.com>
4971 * termhooks.h (Vselection_alist): Make it terminal-local.
4973 * terminal.c (create_terminal): Initialize it.
4975 * xselect.c: Support for clipboard managers.
4976 (Vselection_alist): Move to termhooks.h as terminal-local var.
4977 (LOCAL_SELECTION): New macro.
4978 (x_atom_to_symbol): Handle x_display_info_for_display fail case.
4979 (symbol_to_x_atom): Remove gratuitous arg.
4980 (x_handle_selection_request, lisp_data_to_selection_data)
4981 (x_get_foreign_selection, Fx_register_dnd_atom): Callers changed.
4982 (x_own_selection, x_get_local_selection, x_convert_selection):
4983 New arg, specifying work frame. Use terminal-local Vselection_alist.
4984 (some_frame_on_display): Delete unused function.
4985 (Fx_own_selection_internal, Fx_get_selection_internal)
4986 (Fx_disown_selection_internal, Fx_selection_owner_p)
4987 (Fx_selection_exists_p): New optional frame arg.
4988 (frame_for_x_selection, Fx_clipboard_manager_save): New functions.
4989 (x_handle_selection_clear): Don't treat other terminals with the
4990 same keyboard specially. Use the terminal-local Vselection_alist.
4991 (x_clear_frame_selections): Use Frun_hook_with_args.
4993 * xterm.c (x_term_init): Intern ATOM and CLIPBOARD_MANAGER atoms.
4995 * xterm.h: Add support for those atoms.
4997 2011-05-26 Chong Yidong <cyd@stupidchicken.com>
4999 * xselect.c: ICCCM-compliant handling of MULTIPLE targets.
5000 (converted_selections, conversion_fail_tag): New global variables.
5001 (x_selection_request_lisp_error): Free the above.
5002 (x_get_local_selection): Remove unnecessary code.
5003 (x_reply_selection_request): Args changed; handle arbitrary array
5004 of converted selections stored in converted_selections.
5005 Separate the XChangeProperty and SelectionNotify steps.
5006 (x_handle_selection_request): Rewrite to handle MULTIPLE target.
5007 (x_convert_selection): New function.
5008 (x_handle_selection_event): Simplify.
5009 (x_get_foreign_selection): Don't ignore incoming requests while
5010 waiting for an answer; this will fail when we implement
5011 SAVE_TARGETS, and seems unnecessary anyway.
5012 (selection_data_to_lisp_data): Recognize ATOM_PAIR type.
5013 (Vx_sent_selection_functions): Doc fix.
5015 2011-05-26 Leo Liu <sdl.web@gmail.com>
5017 * editfns.c (Ftranspose_regions): Allow empty regions. (Bug#8699)
5019 2011-05-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
5021 * dispextern.h (struct glyph_row): New member fringe_bitmap_periodic_p.
5023 * dispnew.c (shift_glyph_matrix, scrolling_window): Mark scrolled row
5024 for fringe update if it has periodic bitmap.
5025 (row_equal_p): Also compare left_fringe_offset, right_fringe_offset,
5026 and fringe_bitmap_periodic_p.
5028 * fringe.c (get_fringe_bitmap_data): New function.
5029 (draw_fringe_bitmap_1, update_window_fringes): Use it.
5030 (update_window_fringes): Record periodicity of fringe bitmap in glyph
5031 row. Mark glyph row for fringe update if periodicity changed.
5033 * xdisp.c (try_window_reusing_current_matrix): Don't mark scrolled row
5034 for fringe update unless it has periodic bitmap.
5036 2011-05-25 Kenichi Handa <handa@m17n.org>
5038 * xdisp.c (get_next_display_element): Set correct it->face_id for
5039 a static composition.
5041 2011-05-24 Leo Liu <sdl.web@gmail.com>
5044 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha1.h.
5046 * fns.c (crypto_hash_function, Fsha1): New function.
5047 (Fmd5): Use crypto_hash_function.
5048 (syms_of_fns): Add Ssha1.
5050 2011-05-22 Paul Eggert <eggert@cs.ucla.edu>
5052 * gnutls.c: Remove unused macros.
5053 (fn_gnutls_transport_set_lowat, fn_gnutls_transport_set_pull_function):
5054 (fn_gnutls_transport_set_push_function) [!WINDOWSNT]:
5055 Remove macros that are defined and never used.
5056 Caught by gcc -Wunused-macros (GCC 4.6.0, Fedora 14).
5058 2011-05-22 Chong Yidong <cyd@stupidchicken.com>
5060 * xselect.c (syms_of_xselect): Remove unused symbol SAVE_TARGETS.
5061 (Fx_get_selection_internal): Minor cleanup.
5062 (Fx_own_selection_internal): Rename arguments for consistency with
5065 2011-05-22 Paul Eggert <eggert@cs.ucla.edu>
5067 * xselect.c (QSAVE_TARGETS): New static var, to fix build failure.
5069 2011-05-22 Chong Yidong <cyd@stupidchicken.com>
5071 * xselect.c (syms_of_xselect): Include character.h; use DEFSYM.
5073 2011-05-21 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
5075 * dispnew.c (scrolling_window): Don't exclude the case that the
5076 last enabled row in the desired matrix touches the bottom boundary.
5078 2011-05-21 Glenn Morris <rgm@gnu.org>
5080 * Makefile.in ($(etc)/DOC): Make second command line even shorter.
5081 (SOME_MACHINE_OBJECTS): Replace FONT_OBJ by its maximal expansion,
5082 and add some more files.
5084 2011-05-20 Eli Zaretskii <eliz@gnu.org>
5086 * callproc.c (Fcall_process) [MSDOS]: Fix arguments to
5087 report_file_error introduced by the change from 2011-05-07.
5089 2011-05-20 Paul Eggert <eggert@cs.ucla.edu>
5091 * systime.h (Time): Define only if emacs is defined.
5092 This is to allow ../lib-src/profile.c to be compiled on FreeBSD,
5093 where the include path doesn't have X11/X.h by default. See
5094 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00561.html>.
5096 2011-05-20 Kenichi Handa <handa@m17n.org>
5098 * composite.c (find_automatic_composition): Fix previous change.
5100 2011-05-20 Glenn Morris <rgm@gnu.org>
5102 * lisp.mk: New file, split from Makefile.in.
5103 * Makefile.in (lisp): Move to separate file, inserted by @lisp_frag@.
5104 (shortlisp): Remove.
5105 ($(etc)/DOC): Edit lisp.mk rather than using $shortlisp.
5107 2011-05-19 Glenn Morris <rgm@gnu.org>
5109 * Makefile.in (MSDOS_SUPPORT_REAL, MSDOS_SUPPORT, NS_SUPPORT)
5110 (REAL_MOUSE_SUPPORT, GPM_MOUSE_SUPPORT, MOUSE_SUPPORT, TOOLTIP_SUPPORT)
5111 (BASE_WINDOW_SUPPORT, X_WINDOW_SUPPORT, WINDOW_SUPPORT): Remove.
5112 (lisp): Set the order to that of loadup.el.
5113 (shortlisp): Make it a copy of $lisp.
5114 (SOME_MACHINE_LISP): Remove.
5115 ($(etc)/DOC): Depend just on $lisp, not $SOME_MACHINE_LISP too.
5116 Use just $shortlisp, not $SOME_MACHINE_LISP too.
5118 2011-05-18 Kenichi Handa <handa@m17n.org>
5120 * composite.c (CHAR_COMPOSABLE_P): Add more check for efficiency.
5121 (BACKWARD_CHAR): Wrap the arg STOP by parenthesis.
5122 (find_automatic_composition): Mostly rewrite for efficiency.
5124 2011-05-18 Juanma Barranquero <lekktu@gmail.com>
5126 * makefile.w32-in: Update dependencies.
5128 2011-05-18 Christoph Scholtes <cschol2112@googlemail.com>
5130 * menu.c: Include limits.h (fixes the MS-Windows build broken by
5131 2011-06-18T18:49:19Z!cyd@stupidchicken.com).
5133 2011-05-18 Paul Eggert <eggert@cs.ucla.edu>
5135 Fix some integer overflow issues, such as string length overflow.
5137 * insdel.c (count_size_as_multibyte): Check for string overflow.
5139 * character.c (lisp_string_width): Check for string overflow.
5140 Use EMACS_INT, not int, for string indexes and lengths; in
5141 particular, 2nd arg is now EMACS_INT, not int. Do not crash if
5142 the resulting string length overflows an EMACS_INT; instead,
5143 report a string overflow if no precision given. When checking for
5144 precision exhaustion, use a check that cannot possibly have
5145 integer overflow. (Bug#8675)
5146 * character.h (lisp_string_width): Adjust to new signature.
5148 * alloc.c (string_overflow): New function.
5149 (Fmake_string): Use it. This doesn't change behavior, but saves
5150 a few bytes and will simplify future changes.
5151 * character.c (string_escape_byte8): Likewise.
5152 * lisp.h (string_overflow): New decl.
5154 Fixups, following up to the user-interface timestamp change.
5155 * nsterm.m (last_mouse_movement_time, ns_mouse_position): Use Time
5156 for UI timestamps, instead of unsigned long.
5157 * msdos.c (mouse_get_pos): Likewise.
5158 * w32inevt.c (movement_time, w32_console_mouse_position): Likewise.
5159 * w32gui.h (Time): Define by including "systime.h" rather than by
5160 declaring it ourselves. (Bug#8664)
5162 * dispextern.h (struct image): Don't assume time_t <= unsigned long.
5163 * image.c (clear_image_cache): Likewise.
5165 * term.c (term_mouse_position): Don't assume time_t wraparound.
5167 Be more systematic about user-interface timestamps.
5168 Before, the code sometimes used 'Time', sometimes 'unsigned long',
5169 and sometimes 'EMACS_UINT', to represent these timestamps.
5170 This change causes it to use 'Time' uniformly, as that's what X uses.
5171 This makes the code easier to follow, and makes it easier to catch
5172 integer overflow bugs such as Bug#8664.
5173 * frame.c (Fmouse_position, Fmouse_pixel_position):
5174 Use Time, not unsigned long, for user-interface timestamps.
5175 * keyboard.c (last_event_timestamp, kbd_buffer_get_event): Likewise.
5176 (button_down_time, make_lispy_position, make_lispy_movement): Likewise.
5177 * keyboard.h (last_event_timestamp): Likewise.
5178 * menu.c (Fx_popup_menu) [!HAVE_X_WINDOWS]: Likewise.
5179 * menu.h (xmenu_show): Likewise.
5180 * term.c (term_mouse_position): Likewise.
5181 * termhooks.h (struct input_event.timestamp): Likewise.
5182 (struct terminal.mouse_position_hook): Likewise.
5183 * xmenu.c (create_and_show_popup_menu, xmenu_show): Likewise.
5184 * xterm.c (XTmouse_position, x_scroll_bar_report_motion): Likewise.
5185 * systime.h (Time): New decl. Pull it in from <X11/X.h> if
5186 HAVE_X_WINDOWS, otherwise define it as unsigned long, which is
5188 * menu.h, termhooks.h: Include "systime.h", for Time.
5190 * keyboard.c (make_lispy_event): Fix problem in integer overflow.
5191 Don't assume that the difference between two unsigned long values
5192 can fit into an integer. At this point, we know button_down_time
5193 <= event->timestamp, so the difference must be nonnegative, so
5194 there's no need to cast the result if double-click-time is
5195 nonnegative, as it should be; check that it's nonnegative, just in
5196 case. This bug is triggered when events are more than 2**31 ms
5197 apart (about 25 days). (Bug#8664)
5199 * xselect.c (last_event_timestamp): Remove duplicate decl.
5200 (x_own_selection): Remove needless cast to unsigned long.
5202 * xmenu.c (set_frame_menubar): Use int, not EMACS_UINT, for indexes
5203 that always fit in int. Use a sentinel instead of a counter, to
5204 avoid a temp and to allay GCC's concerns about possible int overflow.
5205 * frame.h (struct frame): Use int for menu_bar_items_used
5206 instead of EMACS_INT, since it always fits in int.
5208 * menu.c (grow_menu_items): Check for int overflow.
5210 * xmenu.c (set_frame_menubar): Don't mishandle vectors with no nils.
5212 * xterm.c: Use EMACS_INT for Emacs modifiers, and int for X modifiers.
5213 Before, the code was not consistent. These values cannot exceed
5214 2**31 - 1 so there's no need to make them unsigned.
5215 (x_x_to_emacs_modifiers): Accept int and return EMACS_INT.
5216 (x_emacs_to_x_modifiers): Accept EMACS_INT and return int.
5217 (x_x_to_emacs_modifiers, x_emacs_to_x_modifiers): Reject non-integers
5219 * xterm.h (x_x_to_emacs_modifiers): Adjust to signature change.
5221 * lisp.h (XINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_INT.
5222 (XUINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_UINT.
5223 Otherwise, GCC 4.6.0 warns about printf (pI, XINT (...)),
5224 presumably because the widths might not match.
5226 * window.c (size_window): Avoid needless test at loop start.
5228 2011-05-18 Courtney Bane <emacs-bugs-7626@cbane.org> (tiny change)
5230 * term.c (Fresume_tty): Restore hooks before reinitializing (bug#8687).
5232 2011-05-12 Drew Adams <drew.adams@oracle.com>
5234 * textprop.c (Fprevious_single_char_property_change): Doc fix (bug#8655).
5236 2011-05-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
5238 * w32term.c (w32_draw_fringe_bitmap): Rename local vars `left' and
5239 `width' to `bar_area_x' and `bar_area_width', respectively.
5240 (x_scroll_run): Take account of fringe background extension.
5242 * xterm.c (x_draw_fringe_bitmap) [USE_TOOLKIT_SCROLL_BARS]:
5243 Rename local vars `left' and `width' to `bar_area_x' and
5244 `bar_area_width', respectively.
5245 (x_scroll_run) [USE_TOOLKIT_SCROLL_BARS]: Take account of fringe
5246 background extension.
5248 2011-05-10 Jim Meyering <meyering@redhat.com>
5250 * xdisp.c (x_intersect_rectangles): Fix typo "the the -> the".
5252 2011-05-10 Juanma Barranquero <lekktu@gmail.com>
5254 * image.c (Finit_image_library): Return t for built-in image types,
5255 like pbm and xbm. (Bug#8640)
5257 2011-05-09 Andreas Schwab <schwab@linux-m68k.org>
5259 * w32menu.c (set_frame_menubar): Fix submenu allocation.
5261 2011-05-07 Eli Zaretskii <eliz@gnu.org>
5263 * w32console.c (Fset_screen_color): Doc fix.
5264 (Fget_screen_color): New function.
5265 (syms_of_ntterm): Defsubr it.
5267 * callproc.c (call_process_cleanup) [MSDOS]: Don't close and
5268 unlink the temporary file if Fcall_process didn't create it in the
5270 (Fcall_process) [MSDOS]: Don't create tempfile if stdout of the
5271 child process will be redirected to a file specified with `:file'.
5272 Don't try to re-open tempfile in that case, and set fd[0] to -1 as
5273 cue to call_process_cleanup not to close that handle.
5275 2011-05-07 Ben Key <bkey76@gmail.com>
5277 * makefile.w32-in: The bootstrap-temacs rule now makes use of
5278 one of two shell specific rules, either bootstrap-temacs-CMD or
5279 bootstrap-temacs-SH. The bootstrap-temacs-SH rule is identical
5280 to the previous implementation of the bootstrap-temacs rule.
5281 The bootstrap-temacs-CMD rule is similar to the previous
5282 implementation of the bootstrap-temacs rule except that it
5283 makes use of the ESC_CFLAGS variable instead of the CFLAGS
5286 These changes, along with some changes to nt/configure.bat,
5287 nt/gmake.defs, and nt/nmake.defs, are required to extend my
5288 earlier fix to add support for --cflags and --ldflags options
5289 that include quotes so that it works whether make uses cmd or
5292 2011-05-06 Michael Albinus <michael.albinus@gmx.de>
5294 * dbusbind.c (QCdbus_type_unix_fd): Declare static.
5295 (xd_remove_watch): Don't check QCdbus_type_unix_fd for SYMBOLP, it
5297 (Fdbus_init_bus, xd_read_queued_messages): Bus can be a symbol or
5298 a string. Handle both cases.
5299 (Fdbus_call_method_asynchronously, Fdbus_register_signal)
5300 (Fdbus_register_method): Use Qinvalid_function.
5302 2011-05-06 Juanma Barranquero <lekktu@gmail.com>
5304 * makefile.w32-in: Update dependencies.
5305 (LISP_H): Add inttypes.h and stdin.h.
5306 (PROCESS_H): Add unistd.h.
5308 2011-05-06 Eli Zaretskii <eliz@gnu.org>
5310 * lread.c: Include limits.h (fixes the MS-Windows build broken by
5311 2011-05-06T07:13:19Z!eggert@cs.ucla.edu).
5313 2011-05-06 Paul Eggert <eggert@cs.ucla.edu>
5315 * image.c (Finit_image_library) [!HAVE_NTGUI]: Omit unused local.
5317 * term.c (vfatal): Remove stray call to va_end.
5318 It's not needed and the C Standard doesn't allow it here anyway.
5320 Use C99's va_copy to avoid undefined behavior on x86-64 GNU/Linux.
5321 * eval.c (verror): doprnt a copy of ap, not the original. (Bug#8545)
5323 * eval.c (verror): OK to create a string of up to MOST_POSITIVE_FIXNUM
5326 * term.c: Don't include <stdarg.h>, as <lisp.h> does that.
5328 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
5330 * process.c (Fformat_network_address): Fix typo: args2 -> *args2.
5332 * xmenu.c (set_frame_menubar): Fix typo: int * -> int (3 times).
5334 * coding.c (detect_coding_charset): Fix typo: * 2 -> *4 (Bug#8601).
5336 * charset.h (struct charset.code_space): Now has 15 elements, not 16.
5337 * charset.c (Fdefine_charset_internal): Don't initialize
5338 charset.code_space[15]. The value was garbage, on hosts with
5339 32-bit int (Bug#8600).
5341 * lread.c (read_integer): Be more consistent with string-to-number.
5342 Use string_to_number to do the actual conversion; this avoids
5343 rounding errors and fixes some other screwups. Without this fix,
5344 for example, #x1fffffffffffffff was misread as -2305843009213693952.
5345 (digit_to_number): Move earlier, for benefit of read_integer.
5346 Return -1 if the digit is out of range for the base, -2 if it is
5347 not a digit in any supported base. (Bug#8602)
5349 * doprnt.c (doprnt): Support arbitrary pI values, such as "I64".
5351 * dispnew.c (scrolling_window): Return 1 if we scrolled,
5352 to match comment at start of function. This also removes a
5353 GCC warning about overflow in a 32+64-bit port.
5355 * lisp.h (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Simplify.
5357 * dbusbind.c: Do not use XPNTR on a value that may be an integer.
5358 Reported by Stefan Monnier in
5359 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00919.html>.
5360 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
5361 Use SYMBOLP-guarded XSYMBOL, not XPNTR.
5363 * lisp.h (EMACS_INTPTR): Remove. All uses changed to intptr_t.
5364 (EMACS_UINTPTR): Likewise, with uintptr_t.
5366 * lisp.h: Prefer 64-bit EMACS_INT if available.
5367 (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Define to 64-bit
5368 on 32-bit hosts that have 64-bit int, so that they can access
5370 However, temporarily disable this change unless the temporary
5371 symbol WIDE_EMACS_INT is defined.
5373 * lread.c, process.c: Do not include <inttypes.h>; lisp.h does it now.
5375 Prefer intptr_t/uintptr_t for integers the same widths as pointers.
5376 This removes an assumption that EMACS_INT and long are the same
5377 width as pointers. The assumption is true for Emacs porting targets
5378 now, but we want to make other targets possible.
5379 * lisp.h: Include <inttypes.h>, for INTPTR_MAX, UINTPTR_MAX.
5380 (EMACS_INTPTR, EMACS_UINTPTR): New macros.
5381 In the rest of the code, change types of integers that hold casted
5382 pointers to EMACS_INTPTR and EMACS_UINTPTR, systematically
5383 replacing EMACS_INT, long, EMACS_UINT, and unsigned long.
5384 (XTYPE): Don't cast arg to EMACS_UINT; normally is not needed.
5385 (XSET): Cast type of XTYPE arg to EMACS_INTPTR; it is needed here.
5386 No need to cast type when ORing.
5387 (XPNTR): Return a value of type EMACS_INTPTR or EMACS_UINTPTR.
5388 * alloc.c (lisp_align_malloc): Remove a no-longer-needed cast.
5389 * doc.c (store_function_docstring): Use EMACS_INTPTR, so as not to
5390 assume EMACS_INT is the same width as char *.
5391 * gtkutil.c (xg_gtk_scroll_destroy, xg_tool_bar_button_cb):
5392 (xg_tool_bar_callback, xg_tool_bar_help_callback, xg_make_tool_item):
5393 Remove no-longer-needed casts.
5394 (xg_create_scroll_bar, xg_tool_bar_button_cb, xg_tool_bar_callback):
5395 (xg_tool_bar_help_callback, xg_make_tool_item):
5396 Use EMACS_INTPTR to hold an integer
5397 that will be cast to void *; this can avoid a GCC warning
5398 if EMACS_INT is not the same width as void *.
5399 * menu.c (find_and_call_menu_selection): Remove no-longer-needed cast.
5400 * xdisp.c (display_echo_area_1, resize_mini_window_1):
5401 (current_message_1, set_message_1):
5402 Use a local to convert to proper width without a cast.
5403 * xmenu.c (dialog_selection_callback): Likewise.
5405 * sysdep.c (get_random): Don't assume EMACS_INT is no wider than long.
5406 Also, don't assume VALBITS / RAND_BITS is less than 5,
5407 and don't rely on undefined behavior when shifting a 1 left into
5409 * lisp.h (get_random): Change signature to match.
5411 * lread.c (hash_string): Use size_t, not int, for hash computation.
5412 Normally we prefer signed values; but hashing is special, because
5413 it's better to use unsigned division on hash table sizes so that
5414 the remainder is nonnegative. Also, size_t is the natural width
5415 for hashing into memory. The previous code used 'int', which doesn't
5416 retain enough info to hash well into very large tables.
5417 (oblookup, oblookup_last_bucket_number, Funintern): Likewise.
5419 * dbusbind.c: Don't possibly lose pointer info when converting.
5420 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
5421 Use XPNTR rather than XHASH, so that the high-order bits of
5422 the pointer aren't lost when converting through void *.
5424 * eval.c (Fautoload): Don't double-shift a pointer.
5426 * fns.c (Frandom): Let EMACS_UINT be wider than unsigned long.
5428 2011-05-06 Juanma Barranquero <lekktu@gmail.com>
5430 * gnutls.c (DEF_GNUTLS_FN):
5431 * image.c (DEF_IMGLIB_FN): Make function pointers static.
5433 2011-05-05 Andreas Schwab <schwab@linux-m68k.org>
5435 * lread.c (lisp_file_lexically_bound_p): Stop scanning at end
5438 2011-05-05 Eli Zaretskii <eliz@gnu.org>
5440 * w32heap.c (allocate_heap) [USE_LISP_UNION_TYPE || USE_LSB_TAG]:
5441 New version that can reserve upto 2GB of heap space.
5443 2011-05-05 Chong Yidong <cyd@stupidchicken.com>
5445 * nsfns.m (Fns_read_file_name): Doc fix (Bug#8534).
5447 2011-05-05 Teodor Zlatanov <tzz@lifelogs.com>
5449 * gnutls.c (fn_gnutls_certificate_set_x509_key_file): Add alias to
5450 `gnutls_certificate_set_x509_key_file'.
5452 2011-05-05 Juanma Barranquero <lekktu@gmail.com>
5454 * makefile.w32-in ($(BLD)/image.$(O), $(BLD)/process.$(O)):
5455 Update dependencies.
5457 2011-05-04 Juanma Barranquero <lekktu@gmail.com>
5459 * gnutls.h (emacs_gnutls_write, emacs_gnutls_read):
5460 * gnutls.c (emacs_gnutls_write, emacs_gnutls_read):
5461 Remove unused parameter `fildes'.
5462 * process.c (read_process_output, send_process): Don't pass it.
5464 2011-05-04 Juanma Barranquero <lekktu@gmail.com>
5466 Fix previous change: the library cache is defined in w32.c.
5467 * image.c (CACHE_IMAGE_TYPE) [!HAVE_NTGUI]: Define to noop.
5468 (Finit_image_library): Wrap Vlibrary_cache on "#ifdef HAVE_NTGUI".
5470 2011-05-04 Juanma Barranquero <lekktu@gmail.com>
5472 Implement dynamic loading of GnuTLS on Windows.
5474 * gnutls.h (GNUTLS_EMACS_ERROR_NOT_LOADED): New macro.
5475 (emacs_gnutls_write, emacs_gnutls_read): Mark as extern.
5476 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
5479 * gnutls.c (Qgnutls_dll): Define.
5480 (DEF_GNUTLS_FN, LOAD_GNUTLS_FN): New macros.
5481 (gnutls_*): Declare function pointers.
5482 (init_gnutls_functions): New function to initialize function pointers.
5483 (emacs_gnutls_handshake, Fgnutls_error_string, Fgnutls_deinit)
5484 (emacs_gnutls_global_init, Fgnutls_bye): Use function pointers.
5485 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
5486 Wrappers for gnutls_record_check_pending and gnutls_transport_set_errno.
5487 (emacs_gnutls_write, emacs_gnutls_read)
5488 (emacs_gnutls_handle_error, Fgnutls_error_fatalp)
5489 (Fgnutls_available_p): New function.
5490 (Fgnutls_boot): Call Fgnutls_available_p. Use function pointers.
5491 (syms_of_gnutls) <Qgnutls_dll>: Initialize and staticpro it.
5492 (syms_of_gnutls) <Sgnutls_available_p>: defsubr it.
5494 * image.c: Include w32.h.
5495 (Vimage_type_cache): Delete.
5496 (syms_of_image) <Vimage_type_cache>: Don't initialize and staticpro it.
5497 (CACHE_IMAGE_TYPE, Finit_image_library): Use Vlibrary_cache instead.
5498 (w32_delayed_load): Move to w32.c.
5500 * w32.h (VlibraryCache, QCloaded_from, w32_delayed_load): Declare.
5502 * w32.c (QCloaded_from, Vlibrary_cache): Define.
5503 (w32_delayed_load): Move from image.c. When loading a library, record
5504 its filename in the :loaded-from property of the library id.
5505 (globals_of_w32) <QCloaded_from, Vlibrary_cache>:
5506 Initialize and staticpro them.
5507 (emacs_gnutls_pull, emacs_gnutls_push): Call emacs_gnutls_* functions.
5509 * process.c: Include lisp.h before w32.h, not after.
5510 (wait_reading_process_output): Call emacs_gnutls_record_check_pending
5511 instead of gnutls_record_check_pending.
5513 * callproc.c, emacs.c: Include lisp.h before w32.h, not after.
5515 2011-05-04 Teodor Zlatanov <tzz@lifelogs.com>
5517 * gnutls.c (Fgnutls_boot): Support :keylist and :crlfiles options
5518 instead of :keyfiles. Give GnuTLS the keylist and the CRL lists
5521 2011-05-03 Jan Djärv <jan.h.d@swipnet.se>
5523 * xterm.c (x_set_frame_alpha): Do not set property on anything
5524 else than FRAME_X_OUTER_WINDOW (Bug#8608).
5526 2011-05-02 Juanma Barranquero <lekktu@gmail.com>
5528 * sysdep.c (get_tty_size) [WINDOWSNT]: Implement. (Bug#8596)
5530 2011-05-02 Juanma Barranquero <lekktu@gmail.com>
5532 * gnutls.c (Qgnutls_log_level, Qgnutls_code, Qgnutls_anon)
5533 (Qgnutls_x509pki, Qgnutls_e_interrupted, Qgnutls_e_again)
5534 (Qgnutls_e_invalid_session, Qgnutls_e_not_ready_for_handshake)
5535 (gnutls_global_initialized, Qgnutls_bootprop_priority)
5536 (Qgnutls_bootprop_trustfiles, Qgnutls_bootprop_keyfiles)
5537 (Qgnutls_bootprop_callbacks, Qgnutls_bootprop_loglevel)
5538 (Qgnutls_bootprop_hostname, Qgnutls_bootprop_verify_flags)
5539 (Qgnutls_bootprop_verify_error, Qgnutls_bootprop_verify_hostname_error)
5540 (Qgnutls_bootprop_callbacks_verify): Make static.
5542 2011-05-01 Andreas Schwab <schwab@linux-m68k.org>
5544 * callproc.c: Indentation fixup.
5546 * sysdep.c (wait_for_termination_1): Make static.
5547 (wait_for_termination, interruptible_wait_for_termination):
5548 Move after wait_for_termination_1.
5550 2011-05-01 Lars Magne Ingebrigtsen <larsi@gnus.org>
5552 * sysdep.c (interruptible_wait_for_termination): New function
5553 which is like wait_for_termination, but allows keyboard
5556 * callproc.c (Fcall_process): Add (:file "file") as an option for
5558 (Fcall_process_region): Ditto.
5560 2011-04-30 Eli Zaretskii <eliz@gnu.org>
5562 * dosfns.c (Fint86, Fdos_memget, Fdos_memput): Use `ASIZE (FOO)'
5563 rather than `XVECTOR (FOO)->size'.
5565 * process.c: Remove HAVE_INTTYPES_H condition from inclusion of
5566 inttypes.h, as a gnulib replacement is used if it not available in
5569 2011-04-21 Eli Zaretskii <eliz@gnu.org>
5571 Lift the MOST_POSITIVE_FIXNUM/4 limitation on visited files.
5572 * fileio.c (Finsert_file_contents): Don't limit file size to 1/4
5573 of MOST_POSITIVE_FIXNUM. (Bug#8528)
5575 * coding.c (coding_alloc_by_realloc): Error out if destination
5576 will grow beyond MOST_POSITIVE_FIXNUM.
5577 (decode_coding_emacs_mule): Abort if there isn't enough place in
5578 charbuf for the composition carryover bytes. Reserve an extra
5579 space for up to 2 characters produced in a loop.
5580 (decode_coding_iso_2022): Abort if there isn't enough place in
5581 charbuf for the composition carryover bytes.
5583 2011-04-21 Eli Zaretskii <eliz@gnu.org>
5585 * doprnt.c (doprnt) [!HAVE_LONG_LONG_INT]: Error out instead of
5586 aborting when %lld or %lll format is passed.
5587 [!HAVE_UNSIGNED_LONG_LONG_INT]: Error out instead of aborting when
5588 %llo or %llx format is passed. (Bug#8545)
5590 * window.c (window_scroll_line_based): Use a marker instead of
5591 simple variables to record original value of point. (Bug#7952)
5593 * doprnt.c (doprnt): Fix the case where a multibyte sequence
5594 produced by %s or %c overflows available buffer space. (Bug#8545)
5596 2011-04-28 Paul Eggert <eggert@cs.ucla.edu>
5598 * doprnt.c (doprnt): Omit useless test; int overflow check (Bug#8545).
5599 (SIZE_MAX): Move defn after all includes, as they might #define it.
5601 2011-04-28 Juanma Barranquero <lekktu@gmail.com>
5603 * w32.c (init_environment): Warn about defaulting HOME to C:\.
5605 2011-04-28 Juanma Barranquero <lekktu@gmail.com>
5607 * keyboard.c (Qdelayed_warnings_hook): Define.
5608 (command_loop_1): Run `delayed-warnings-hook'
5609 if Vdelayed_warnings_list is non-nil.
5610 (syms_of_keyboard) <delayed-warnings-hook>: DEFSYM it.
5611 (syms_of_keyboard) <delayed-warnings-list>: DEFVAR_LISP it.
5613 2011-04-28 Eli Zaretskii <eliz@gnu.org>
5615 * doprnt.c (doprnt): Don't return value smaller than the buffer
5616 size if the message was truncated. (Bug#8545).
5618 2011-04-28 Juanma Barranquero <lekktu@gmail.com>
5620 * w32fns.c (Fx_change_window_property, Fx_delete_window_property)
5621 (Fx_window_property): #if-0 the whole functions, not just the bodies.
5623 2011-04-27 Paul Eggert <eggert@cs.ucla.edu>
5625 * doprnt.c (doprnt): Support "ll" length modifier, for long long.
5627 2011-04-27 Juanma Barranquero <lekktu@gmail.com>
5629 * makefile.w32-in: Update dependencies.
5631 2011-04-27 Eli Zaretskii <eliz@gnu.org>
5633 Improve `doprnt' and its usage. (Bug#8545)
5634 * doprnt.c (doprnt): Make sure `format' is never accessed beyond
5635 `format_end'. Remove support for %l as a conversion specifier.
5636 Don't use xrealloc. Improve diagnostics when the %l size modifier
5637 is used. Update the commentary.
5639 * eval.c (verror): Simplify calculation of size_t.
5641 * coding.c (Ffind_operation_coding_system): Fix diagnostic error
5644 2011-04-27 Yoshiaki Kasahara <kasahara@nc.kyushu-u.ac.jp> (tiny change)
5646 * buffer.c (init_buffer) [USE_MMAP_FOR_BUFFERS]: Adjust to aliasing
5649 2011-04-27 Paul Eggert <eggert@cs.ucla.edu>
5651 * nsmenu.m: Replace all uses of XVECTOR with ASIZE and AREF.
5652 This makes this file independent of the recent pseudovector change.
5654 2011-04-26 Paul Eggert <eggert@cs.ucla.edu>
5656 * keyboard.c (handle_user_signal): Fix pointer signedness problem.
5658 * gnutls.c (emacs_gnutls_handle_error): Remove unused local.
5659 (Fgnutls_boot): gnutls_certificate_verify_peers2 wants unsigned *.
5660 Remove unused local.
5661 (emacs_gnutls_write): Don't use uninitialized rtnval if nbyte <= 0.
5663 * lisp.h: Fix a problem with aliasing and vector headers. (Bug#8546)
5664 GCC 4.6.0 optimizes based on type-based alias analysis.
5665 For example, if b is of type struct buffer * and v of type struct
5666 Lisp_Vector *, then gcc -O2 was incorrectly assuming that &b->size
5667 != &v->size, and therefore "v->size = 1; b->size = 2; return
5668 v->size;" must therefore return 1. This assumption is incorrect
5669 for Emacs, since it type-puns struct Lisp_Vector * with many other
5670 types. To fix this problem, this patch adds a new type struct
5671 vectorlike_header that documents the constraints on layout of vectors
5672 and pseudovectors, and helps optimizing compilers not get fooled
5673 by Emacs's type punning. It also adds the macros XSETTYPED_PVECTYPE
5674 XSETTYPED_PSEUDOVECTOR, TYPED_PSEUDOVECTORP, for similar reasons.
5675 * lisp.h (XSETTYPED_PVECTYPE): New macro, specifying the name of
5677 (XSETPVECTYPE): Rewrite in terms of new macro.
5678 (XSETPVECTYPESIZE): New macro, specifying both type and size.
5679 This is a bit clearer, and further avoids the possibility of
5680 undesirable aliasing.
5681 (XSETTYPED_PSEUDOVECTOR): New macro, specifying the size.
5682 (XSETPSEUDOVECTOR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR.
5683 (XSETSUBR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR and XSIZE,
5684 since Lisp_Subr is a special case (no "next" field).
5685 (ASIZE): Now uses header.size rather than size.
5686 All previous uses of XVECTOR (foo)->size replaced to use this macro,
5687 to avoid the hassle of writing XVECTOR (foo)->header.size.
5688 (struct vectorlike_header): New type.
5689 (TYPED_PSEUDOVECTORP): New macro, also specifying the C type of the
5690 object, to help avoid aliasing.
5691 (PSEUDOVECTORP): Rewrite in terms of TYPED_PSEUDOVECTORP.
5692 (SUBRP): Likewise, since Lisp_Subr is a special case.
5693 * lisp.h (struct Lisp_Vector, struct Lisp_Char_Table):
5694 (struct Lisp_Sub_Char_Table, struct Lisp_Bool_Vector):
5695 (struct Lisp_Hash_Table): Combine first two members into a single
5696 struct vectorlike_header member. All uses of "size" and "next" members
5697 changed to be "header.size" and "header.next".
5698 * buffer.h (struct buffer): Likewise.
5699 * font.h (struct font_spec, struct font_entity, struct font): Likewise.
5700 * frame.h (struct frame): Likewise.
5701 * process.h (struct Lisp_Process): Likewise.
5702 * termhooks.h (struct terminal): Likewise.
5703 * window.c (struct save_window_data, struct saved_window): Likewise.
5704 * window.h (struct window): Likewise.
5705 * alloc.c (allocate_buffer, Fmake_bool_vector, allocate_pseudovector):
5706 Use XSETPVECTYPESIZE, not XSETPVECTYPE, to avoid aliasing problems.
5707 * buffer.c (init_buffer_once): Likewise.
5708 * lread.c (defsubr): Use XSETTYPED_PVECTYPE, since Lisp_Subr is a
5710 * process.c (Fformat_network_address): Use local var for size,
5713 * bytecode.c (exec_byte_code): Don't use XVECTOR before CHECK_VECTOR.
5715 Make the Lisp reader and string-to-float more consistent (Bug#8525)
5716 * data.c (atof): Remove decl; no longer used or needed.
5717 (digit_to_number): Move to lread.c.
5718 (Fstring_to_number): Use new string_to_number function, to be
5719 consistent with how the Lisp reader treats infinities and NaNs.
5720 Do not assume that floating-point numbers represent EMACS_INT
5721 without losing information; this is not true on most 64-bit hosts.
5722 Avoid double-rounding errors, by insisting on integers when
5723 parsing non-base-10 numbers, as the documentation specifies.
5724 * lisp.h (string_to_number): New decl, replacing ...
5725 (isfloat_string): Remove.
5726 * lread.c: Include <inttypes.h>, for uintmax_t and strtoumax.
5727 (read1): Do not accept +. and -. as integers; this
5728 appears to have been a coding error. Similarly, do not accept
5729 strings like +-1e0 as floating point numbers. Do not report
5730 overflow for integer overflows unless the base is not 10 which
5731 means we have no simple and reliable way to continue.
5732 Break out the floating-point parsing into a new
5733 function string_to_number, so that Fstring_to_number parses
5734 floating point numbers consistently with the Lisp reader.
5735 (digit_to_number): Move here from data.c. Make it static inline.
5736 (E_CHAR, EXP_INT): Remove, replacing with ...
5737 (E_EXP): New macro, to solve the "1.0e+" problem mentioned below.
5738 (string_to_number): New function, replacing isfloat_string.
5739 This function checks for valid syntax and produces the resulting
5740 Lisp float number too. Rework it so that string-to-number
5741 no longer mishandles examples like "1.0e+". Use strtoumax,
5742 so that overflow for non-base-10 numbers is reported only when
5743 there's no portable and simple way to convert to floating point.
5745 * textprop.c (set_text_properties_1): Rewrite for clarity,
5746 and to avoid GCC warning about integer overflow.
5748 * intervals.h (struct interval): Use EMACS_INT for members
5749 where EMACS_UINT might cause problems. See
5750 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html>.
5751 (CHECK_TOTAL_LENGTH): Remove cast to EMACS_INT; no longer needed.
5752 * intervals.c (interval_deletion_adjustment): Now returns EMACS_INT.
5754 (offset_intervals): Tell GCC not to worry about length overflow
5755 when negating a negative length.
5757 * alloc.c (overrun_check_malloc, overrun_check_realloc): Now static.
5758 (overrun_check_free): Likewise.
5760 * alloc.c (SDATA_SIZE) [!GC_CHECK_STRING_BYTES]: Avoid runtime check
5761 in the common case where SDATA_DATA_OFFSET is a multiple of Emacs
5764 * gnutls.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
5765 (gnutls_make_error): Rename local to avoid shadowing.
5766 (gnutls_emacs_global_deinit): ifdef out; not used.
5767 (Fgnutls_boot): Use const for pointer to readonly storage.
5768 Comment out unused local. Fix pointer signedness problems.
5770 * lread.c (openp): Don't stuff size_t into an 'int'.
5771 Use <= on length, not < on length + 1, to avoid GCC 4.6.0 warning
5772 about possible signed overflow.
5774 * gtkutil.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
5775 (GDK_KEY_g): Don't define if already defined.
5776 (xg_prepare_tooltip): Avoid pointer signedness problem.
5777 (xg_set_toolkit_scroll_bar_thumb): Redo to avoid two casts.
5779 * process.c (Fnetwork_interface_info): Avoid left-shift undefined
5780 behavior with 1 << 31. GCC 4.6.0 warns about this on 32-bit hosts.
5782 * xfns.c (Fx_window_property): Simplify a bit,
5783 to make a bit faster and to avoid GCC 4.6.0 warning.
5784 * xselect.c (x_get_window_property, x_handle_dnd_message): Likewise.
5786 * fns.c (internal_equal): Don't assume size_t fits in int.
5788 * alloc.c (compact_small_strings): Tighten assertion a little.
5790 Replace pEd with more-general pI, and fix some printf arg casts.
5791 * lisp.h (pI): New macro, generalizing old pEd macro to other
5792 conversion specifiers. For example, use "...%"pI"d..." rather
5793 than "...%"pEd"...".
5794 (pEd): Remove. All uses replaced with similar uses of pI.
5795 * src/m/amdx86-64.h, src/m/ia64.h, src/m/ibms390x.h: Likewise.
5796 * alloc.c (check_pure_size): Don't overflow by converting size to int.
5797 * bidi.c (bidi_dump_cached_states): Use pI to avoid cast.
5798 * data.c (Fnumber_to_string): Use pI instead of if-then-else-abort.
5799 * dbusbind.c (xd_append_arg): Use pI to avoid cast.
5800 (Fdbus_method_return_internal, Fdbus_method_error_internal): Likewise.
5801 * font.c (font_unparse_xlfd): Avoid potential buffer overrun on
5803 (font_unparse_xlfd, font_unparse_fcname): Use pI to avoid casts.
5804 * keyboard.c (record_char, modify_event_symbol): Use pI to avoid casts.
5805 * print.c (safe_debug_print, print_object): Likewise.
5806 (print_object): Don't overflow by converting EMACS_INT or EMACS_UINT
5808 Use pI instead of if-then-else-abort. Use %p to avoid casts,
5809 avoiding the 0 flag, which is not portable.
5810 * process.c (Fmake_network_process): Use pI to avoid cast.
5811 * region-cache.c (pp_cache): Likewise.
5812 * xdisp.c (decode_mode_spec): Likewise.
5813 * xrdb.c (x_load_resources) [USE_MOTIF]: Use pI to avoid undefined
5814 behavior on 64-bit hosts with printf arg.
5815 * xselect.c (x_queue_event): Use %p to avoid casts, avoiding 0 flag.
5816 (x_stop_queuing_selection_requests): Likewise.
5817 (x_get_window_property): Don't truncate byte count to an 'int'
5820 * frame.c (frame_name_fnn_p): Get rid of strtol, which isn't right
5821 here, since it parses constructs like leading '-' and spaces,
5822 which are not wanted; and it overflows with large numbers.
5823 Instead, simply match F[0-9]+, which is what is wanted anyway.
5825 * alloc.c: Remove unportable assumptions about struct layout.
5826 (SDATA_SELECTOR, SDATA_DATA_OFFSET): New macros.
5827 (SDATA_OF_STRING, SDATA_SIZE, allocate_string_data):
5828 (allocate_vectorlike, make_pure_vector): Use the new macros,
5829 plus offsetof, to remove unportable assumptions about struct layout.
5830 These assumptions hold on all porting targets that I know of, but
5831 they are not guaranteed, they're easy to remove, and removing them
5832 makes further changes easier.
5834 * alloc.c (BLOCK BYTES): Fix typo by changing "ablock" to "ablocks".
5835 This doesn't fix a bug but makes the code clearer.
5836 (string_overrun_cookie): Now const. Use initializers that
5837 don't formally overflow signed char, to avoid warnings.
5838 (allocate_string_data) [GC_CHECK_STRING_OVERRUN]: Fix typo that
5839 can cause Emacs to crash when string overrun checking is enabled.
5840 (allocate_buffer): Don't assume sizeof (struct buffer) is a
5841 multiple of sizeof (EMACS_INT); it need not be, if
5842 alignof(EMACS_INT) < sizeof (EMACS_INT).
5843 (check_sblock, check_string_bytes, check_string_free_list): Protoize.
5845 2011-04-26 Juanma Barranquero <lekktu@gmail.com>
5847 * keyboard.c (QCrtl): Rename from Qrtl. All uses changed.
5849 2011-04-26 Teodor Zlatanov <tzz@lifelogs.com>
5851 * gnutls.c (emacs_gnutls_handshake): Return an error if we're not
5852 supposed to be handshaking. (Bug#8556)
5853 Reported by Paul Eggert <eggert@cs.ucla.edu>.
5855 2011-04-26 Daniel Colascione <dan.colascione@gmail.com>
5857 * lisp.h (Qdebug): List symbol.
5858 * eval.c (Qdebug): Restore global linkage.
5859 * keyboard.c (debug-on-event): New variable.
5860 (handle_user_signal): Break into debugger when debug-on-event
5861 matches the current signal symbol.
5863 2011-04-25 Dan Nicolaescu <dann@ics.uci.edu>
5865 * alloc.c (check_sblock, check_string_bytes)
5866 (check_string_free_list): Convert to standard C.
5868 2011-04-25 Teodor Zlatanov <tzz@lifelogs.com>
5870 * w32.c (emacs_gnutls_push): Fix typo.
5872 2011-04-25 Eli Zaretskii <eliz@gnu.org>
5874 * gnutls.c (emacs_gnutls_handshake): Avoid compiler warnings about
5875 "cast to pointer from integer of different size".
5877 Improve doprnt and its use in verror. (Bug#8545)
5878 * doprnt.c (doprnt): Document the set of format control sequences
5879 supported by the function. Use SAFE_ALLOCA instead of always
5882 * eval.c (verror): Don't limit the buffer size at size_max-1, that
5883 is one byte too soon. Don't use xrealloc; instead xfree and
5886 2011-04-24 Teodor Zlatanov <tzz@lifelogs.com>
5888 * gnutls.h: Add GNUTLS_STAGE_CALLBACKS enum to denote we're in the
5891 * gnutls.c: Renamed global_initialized to
5892 gnutls_global_initialized. Added internals for the
5893 :verify-hostname-error, :verify-error, and :verify-flags
5894 parameters of `gnutls-boot' and documented those parameters in the
5895 docstring. Start callback support.
5896 (emacs_gnutls_handshake): Add Woe32 support. Retry handshake
5897 unless a fatal error occurred. Call gnutls_alert_send_appropriate
5898 on error. Return error code.
5899 (emacs_gnutls_write): Call emacs_gnutls_handle_error.
5900 (emacs_gnutls_read): Likewise.
5901 (Fgnutls_boot): Return handshake error code.
5902 (emacs_gnutls_handle_error): New function.
5903 (wsaerror_to_errno): Likewise.
5905 * w32.h (emacs_gnutls_pull): Add prototype.
5906 (emacs_gnutls_push): Likewise.
5908 * w32.c (emacs_gnutls_pull): New function for GnuTLS on Woe32.
5909 (emacs_gnutls_push): Likewise.
5911 2011-04-24 Claudio Bley <claudio.bley@gmail.com> (tiny change)
5913 * process.c (wait_reading_process_output): Check if GnuTLS
5914 buffered some data internally if no FDs are set for TLS
5917 * makefile.w32-in (OBJ2): Add gnutls.$(O).
5918 (LIBS): Link to USER_LIBS.
5919 ($(BLD)/gnutls.$(0)): New target.
5921 2011-04-24 Eli Zaretskii <eliz@gnu.org>
5923 * xdisp.c (handle_single_display_spec): Rename the
5924 display_replaced_before_p argument into display_replaced_p, to
5925 make it consistent with the commentary. Fix typos in the
5928 * textprop.c (syms_of_textprop): Remove dead code.
5929 (copy_text_properties): Delete obsolete commentary about an
5930 interface that was deleted long ago. Fix typos in the description
5933 * msdos.c (XMenuActivate, XMenuAddSelection): Adjust argument list
5934 to changes in oldXMenu/XMenu.h from 2011-04-16.
5935 <menu_help_message, prev_menu_help_message>: Constify.
5936 (IT_menu_make_room): menu->help_text is now `const char **';
5939 * msdos.h (XMenuActivate, XMenuAddSelection): Adjust prototypes
5940 to changes in oldXMenu/XMenu.h from 2011-04-16.
5941 (struct XMenu): Declare `help_text' `const char **'.
5943 * xfaces.c <Qunspecified>: Make extern again.
5945 * syntax.c: Include sys/types.h before including regex.h, as
5948 * doc.c (get_doc_string): Improve the format passed to `error'.
5950 * doprnt.c (doprnt): Improve commentary.
5952 * term.c (init_tty) [MSDOS]: Fix 1st argument to maybe_fatal.
5954 * Makefile.in (TAGS): Depend on $(M_FILE) and $(S_FILE), and scan
5957 * makefile.w32-in (globals.h): Add a dummy recipe, to make any
5958 changes in globals.h immediately force recompilation.
5959 (TAGS): Depend on $(CURDIR)/m/intel386.h and
5960 $(CURDIR)/s/ms-w32.h.
5961 (TAGS-gmake): Scan $(CURDIR)/m/intel386.h and $(CURDIR)/s/ms-w32.h.
5963 * character.c (Fchar_direction): Function deleted.
5964 (syms_of_character): Don't defsubr it.
5965 <char-direction-table>: Deleted.
5967 2011-04-23 Eli Zaretskii <eliz@gnu.org>
5969 Fix doprnt so it could be used again safely in `verror'. (Bug#8435)
5970 * doprnt.c: Include limits.h.
5971 (SIZE_MAX): New macro.
5972 (doprnt): Return a size_t value. 2nd arg is now size_t.
5973 Many local variables are now size_t instead of int or unsigned.
5974 Improve overflow protection. Support `l' modifier for integer
5975 conversions. Support %l conversion. Don't assume an EMACS_INT
5976 argument for integer conversions and for %c.
5978 * lisp.h (doprnt): Restore prototype.
5980 * makefile.w32-in ($(BLD)/callint.$(O)): Depend on
5983 * Makefile.in (base_obj): Add back doprnt.o.
5985 * deps.mk (doprnt.o): Add back prerequisites.
5986 (callint.o): Depend on character.h.
5988 * eval.c (internal_lisp_condition_case): Include the handler
5989 representation in the error message.
5990 (verror): Call doprnt instead of vsnprintf. Fix an off-by-one bug
5991 when breaking from the loop.
5993 * xdisp.c (vmessage): Call doprnt instead of vsnprintf.
5995 * callint.c (Fcall_interactively): When displaying error message
5996 about invalid control letter, pass the character's codepoint, not
5997 a pointer to its multibyte form. Improve display of the character
5998 in octal and display also its hex code.
6000 * character.c (char_string): Use %x to display the (unsigned)
6001 codepoint of an invalid character, to avoid displaying a bogus
6004 * font.c (check_otf_features): Pass SDATA of SYMBOL_NAME to
6005 `error', not SYMBOL_NAME itself.
6007 * coding.c (Fencode_sjis_char, Fencode_big5_char): Use %c for
6008 character arguments to `error'.
6010 * charset.c (check_iso_charset_parameter): Fix incorrect argument
6011 to `error' in error message about FINAL_CHAR argument. Make sure
6012 FINAL_CHAR is a character, and use %c when it is passed as
6013 argument to `error'.
6015 2011-04-23 Eli Zaretskii <eliz@gnu.org>
6017 * s/ms-w32.h (localtime): Redirect to sys_localtime.
6019 * w32.c: Include <time.h>.
6020 (sys_localtime): New function.
6022 2011-04-23 Chong Yidong <cyd@stupidchicken.com>
6024 * xdisp.c (init_xdisp): Initialize echo_area_window (Bug#6451).
6026 * buffer.c (syms_of_buffer): Doc fix (Bug#6902).
6028 2011-04-23 Samuel Thibault <sthibault@debian.org> (tiny change)
6030 * sysdep.c (wait_for_termination): On GNU Hurd, kill returns -1 on
6033 2011-04-19 Eli Zaretskii <eliz@gnu.org>
6035 * syntax.h (SETUP_SYNTAX_TABLE_FOR_OBJECT): Fix setting of
6036 gl_state.e_property when gl_state.object is Qt.
6038 * insdel.c (make_gap_larger): Remove limitation of buffer size
6041 2011-04-18 Chong Yidong <cyd@stupidchicken.com>
6043 * xdisp.c (lookup_glyphless_char_display)
6044 (produce_glyphless_glyph): Handle cons cell entry in
6045 glyphless-char-display.
6046 (Vglyphless_char_display): Document it.
6048 * term.c (produce_glyphless_glyph): Handle cons cell entry in
6049 glyphless-char-display.
6051 2011-04-17 Chong Yidong <cyd@stupidchicken.com>
6053 * xdisp.c (get_next_display_element): Remove unnecessary ifdefs.
6055 * termhooks.h (FRAME_WINDOW_P): Remove duplicated definitions.
6057 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): Add missing
6058 definition for no-X builds.
6060 2011-04-16 Paul Eggert <eggert@cs.ucla.edu>
6062 Static checks with GCC 4.6.0 and non-default toolkits.
6064 * s/sol2-6.h, s/unixware.h (PTY_TTY_NAME_SPRINTF): Protoize decl.
6066 * process.c (keyboard_bit_set): Define only if SIGIO.
6067 (send_process_trap): Mark it with NO_RETURN if it doesn't return.
6068 (send_process): Repair possible setjmp clobbering.
6070 * s/usg5-4-common.h (SETUP_SLAVE_PTY): Don't pass extra arg to 'fatal'.
6072 * eval.c: Include <stdio.h>, for vsnprintf on non-GNU/Linux hosts.
6074 * data.c (arith_error): Mark with NO_RETURN if it doesn't return.
6076 * alloc.c (bytes_used_when_full, SPARE_MEMORY, BYTES_USED):
6077 Define only if needed.
6079 * sysdep.c (_FILE_OFFSET_BITS): Make this hack even uglier
6080 by pacifying GCC about it. Maybe it's time to retire it?
6081 * xfaces.c (USG, __TIMEVAL__): Likewise.
6083 * dispextern.h (struct redisplay_interface): Rename param
6085 * termhooks.h (struct terminal): Likewise.
6086 * xterm.c (xembed_send_message): Likewise.
6088 * insdel.c (make_gap_smaller): Define only if
6089 USE_MMAP_FOR_BUFFERS || REL_ALLOC || DOUG_LEA_MALLOC.
6091 * keyboard.c (read_char): Make a var volatile so longjmp won't clobber
6094 * emacs.c (MAX_HEAP_BSS_DIFF, my_edata): Move to where they're used,
6095 so that we aren't warned about unused symbols.
6097 * xfns.c (Fx_file_dialog): Rename local to avoid shadowing.
6099 * xdisp.c (x_produce_glyphs): Mark var as initialized (Bug#8512).
6101 * xfns.c (x_real_positions): Mark locals as initialized.
6103 * xmenu.c (xmenu_show): Don't use uninitialized vars.
6105 * xterm.c: Fix problems found by static analysis with other toolkits.
6106 (toolkit_scroll_bar_interaction): Define and use only if USE_X_TOOLKIT.
6107 (x_dispatch_event): Declare static if USE_GTK, and
6108 define if USE_GTK || USE_X_TOOLKIT.
6109 (SET_SAVED_BUTTON_EVENT): Define only if USE_X_TOOLKIT || USE_GTK.
6110 * xterm.h (x_dispatch_event): Extern only if USE_X_TOOLKIT.
6111 * xterm.c, xterm.h (x_mouse_leave): Bring this function back, but only
6112 if defined HAVE_MENUS && !defined USE_X_TOOLKIT && !defined USE_GTK.
6114 * xmenu.c (menu_help_callback): Pointer type fixes.
6115 Use const pointers when pointing at readonly data. Avoid pointer
6117 (FALSE): Remove unused macro.
6118 (update_frame_menubar): Remove unused decl.
6120 * xfns.c (Fx_hide_tip): Move locals to avoid shadowing.
6122 * menu.c (push_submenu_start, push_submenu_end): Do not define unless
6123 USE_X_TOOLKIT || USE_GTK || HAVE_NS || defined HAVE_NTGUI.
6124 (single_menu_item): Rename local to avoid shadowing.
6126 * keyboard.c (make_lispy_event): Remove unused local var.
6128 * frame.c, frame.h (x_get_resource_string): Bring this back, but
6129 only if HAVE_X_WINDOWS && !USE_X_TOOLKIT.
6131 * bitmaps: Change bitmaps from unsigned char back to the X11
6132 compatible char. Avoid the old compiler warnings about
6133 out-of-range initializers by using, for example, '\xab' rather
6136 * xgselect.c (xgselect_initialize): Check vs interface
6137 even if ! (defined (USE_GTK) || defined (HAVE_GCONF)).
6139 * xmenu.c (xmenu_show): Rename parm to avoid shadowing.
6141 * xterm.c (x_create_toolkit_scroll_bar): Use const * for pointers
6142 to read-only memory.
6144 * fns.c (vector): Remove; this old hack is no longer needed.
6146 * xsmfns.c (create_client_leader_window): Rename shadowing arg.
6148 (gdk_x11_set_sm_client_id) [!USE_GTK]: Don't define.
6150 * xrdb.c (x_load_resources): Omit unused local.
6152 * xfns.c (free_frame_menubar, atof): Remove duplicate decls.
6153 (x_window): Rename locals to avoid shadowing.
6154 (USG): Use the kludged USG macro, to pacify gcc.
6156 * xterm.c (x_alloc_nearest_color_for_widget): Remove; unused.
6157 (x_term_init): Remove local to avoid shadowing.
6159 * xfns.c, xterm.c (_XEditResCheckMessages): Protoize decl.
6161 * xdisp.c, dispextern.h (set_vertical_scroll_bar): Now extern if
6162 USE_TOOLKIT_SCROLL_BARS && !USE_GTK, as xterm.c needs it then.
6164 2011-04-16 Eli Zaretskii <eliz@gnu.org>
6166 * gnutls.c (Fgnutls_boot): Don't pass Lisp_Object to `error'.
6168 Fix regex.c, syntax.c and friends for buffers > 2GB.
6169 * syntax.h (struct gl_state_s): Declare character position members
6172 * syntax.c (update_syntax_table): Declare 2nd argument EMACS_INT.
6174 * textprop.c (verify_interval_modification, interval_of):
6175 Declare arguments EMACS_INT.
6177 * intervals.c (adjust_intervals_for_insertion): Declare arguments
6180 * intervals.h (CHECK_TOTAL_LENGTH): Cast to EMACS_INT, not `int'.
6182 * indent.c (Fvertical_motion): Local variable it_start is now
6185 * regex.c (re_match, re_match_2, re_match_2_internal)
6186 (bcmp_translate, regcomp, regexec, print_double_string)
6187 (group_in_compile_stack, re_search, re_search_2, regex_compile)
6188 (re_compile_pattern, re_exec): Declare arguments and local
6189 variables `size_t' and `ssize_t' and return values `regoff_t', as
6191 (POP_FAILURE_REG_OR_COUNT) <pfreg>: Declare `long'.
6192 (CHECK_INFINITE_LOOP) <failure>: Declare `ssize_t'.
6193 <compile_stack_type>: `size' and `avail' are now `size_t'.
6195 * regex.h <regoff_t>: Use ssize_t, not int.
6196 (re_search, re_search_2, re_match, re_match_2): Arguments that
6197 specify buffer/string position and length are now ssize_t and
6198 size_t. Return type is regoff_t.
6200 2011-04-16 Ben Key <bkey76@gmail.com>
6202 * nsfont.m: Fixed bugs in ns_get_family and
6203 ns_descriptor_to_entity that were caused by using free to
6204 deallocate memory blocks that were allocated by xmalloc (via
6205 xstrdup). This caused Emacs to crash when compiled with
6206 XMALLOC_OVERRUN_CHECK defined (when Emacs was configured with
6207 --enable-checking=xmallocoverrun). xfree is now used to
6208 deallocate these memory blocks.
6210 2011-04-15 Paul Eggert <eggert@cs.ucla.edu>
6212 * sysdep.c (emacs_read): Remove unnecessary check vs MAX_RW_COUNT.
6214 emacs_write: Accept and return EMACS_INT for sizes.
6215 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html
6217 * gnutls.c, gnutls.h (emacs_gnutls_read, emacs_gnutls_write):
6218 Accept and return EMACS_INT.
6219 (emacs_gnutls_write): Return the number of bytes written on
6221 * sysdep.c, lisp.h (emacs_read, emacs_write): Likewise.
6222 (emacs_read, emacs_write): Remove check for negative size, as the
6223 Emacs source code has been audited now.
6224 * sysdep.c (MAX_RW_COUNT): New macro, to work around kernel bugs.
6225 (emacs_read, emacs_write): Use it.
6226 * process.c (send_process): Adjust to the new signatures of
6227 emacs_write and emacs_gnutls_write. Do not attempt to store
6228 a byte offset into an 'int'; it might overflow.
6229 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00483.html
6231 * sound.c: Don't assume sizes fit in 'int'.
6232 (struct sound_device.period_size, alsa_period_size):
6233 Return EMACS_INT, not int.
6234 (struct sound_device.write, vox_write, alsa_write):
6235 Accept EMACS_INT, not int.
6236 (wav_play, au_play): Use EMACS_INT to store sizes and to
6237 record read return values.
6239 2011-04-15 Ben Key <bkey76@gmail.com>
6241 * keyboard.c (Qundefined): Don't declare static since it is used
6243 * xfaces.c (Qbold, Qexpanded, Qitalic, Qcondensed): Don't declare
6244 static since they are used in nsfont.m.
6246 2011-04-15 Stefan Monnier <monnier@iro.umontreal.ca>
6248 * process.c (Qprocessp): Don't declare static.
6249 * lisp.h (Qprocessp): Declare again.
6251 2011-04-15 Juanma Barranquero <lekktu@gmail.com>
6253 * font.c (Qopentype): Don't make static (used from w32uniscribe.c).
6255 2011-04-14 Paul Eggert <eggert@cs.ucla.edu>
6257 Improve C-level modularity by making more things 'static'.
6259 Don't publish debugger-only interfaces to other modules.
6260 * lisp.h (safe_debug_print, debug_output_compilation_hack):
6261 (verify_bytepos, count_markers): Move decls to the only modules
6263 * region-cache.h (pp_cache): Likewise.
6264 * window.h (check_all_windows): Likewise.
6265 * marker.c, print.c, region-cache.c, window.c: Decls moved here.
6267 * sysdep.c (croak): Now static, if
6268 defined TIOCNOTTY || defined USG5 || defined CYGWIN.
6269 * syssignal.h (croak): Declare only if not static.
6271 * alloc.c (refill_memory_reserve): Now static if
6272 !defined REL_ALLOC || defined SYSTEM_MALLOC.
6273 * lisp.h (refill_memory_reserve): Declare only if not static.
6275 * xsettings.c, xsettings.h (xsettings_get_system_normal_font):
6276 Define only if USE_LUCID.
6278 * xrdb.c (x_customization_string, x_rm_string): Now static.
6280 * xmenu.c (x_menu_wait_for_event): Export only if USE_MOTIF.
6281 * xterm.h (x_menu_wait_for_event): Declare only if USE_MOTIF.
6283 * xdisp.c (draw_row_with_mouse_face): Now static.
6284 * dispextern.h (draw_row_with_mouse_fave): Remove decl.
6286 * window.h (check_all_windows): Mark externally visible.
6288 * window.c (window_deletion_count): Now static.
6290 * undo.c: Make symbols static if they're not exported.
6291 (last_undo_buffer, last_boundary_position, pending_boundary):
6294 * textprop.c (interval_insert_behind_hooks): Now static.
6295 (interval_insert_in_front_hooks): Likewise.
6297 * term.c: Make symbols static if they're not exported.
6298 (tty_turn_off_highlight, get_tty_terminal, max_frame_cols):
6299 (max_frame_lines, tty_set_terminal_modes):
6300 (tty_reset_terminal_modes, tty_turn_off_highlight):
6301 (get_tty_terminal): Now static.
6302 (term_mouse_moveto): Do not define if HAVE_WINDOW_SYSTEM.
6303 * termhooks.h (term_mouse_moveto): Do not declare if
6305 * dispextern.h (tty_set_terminal_modes, tty_reset_terminal_modes):
6306 (tty_turn_off_highlight, get_tty_terminal): Remove decls.
6308 * sysdep.c: Make symbols static if they're not exported.
6309 (emacs_get_tty, emacs_set_tty, old_fcntl_flags, old_fcntl_owner):
6311 (sigprocmask_set, full_mask): Remove; unused.
6312 (wait_debugging): Mark as visible.
6313 * syssignal.h (SIGFULLMASK, full_mask): Remove decls.
6314 * systty.h (emacs_get_tty, emacs_set_tty): Remove decls.
6316 * syntax.c (syntax_temp): Define only if !__GNUC__.
6318 * sound.c (current_sound_device, current_sound): Now static.
6320 * search.c (searchbufs, searchbuf_head): Now static.
6322 * scroll.c (scroll_cost): Remove; unused.
6323 * dispextern.h (scroll_cost): Remove decl.
6325 * region-cache.h (pp_cache): Mark as externally visible.
6327 * process.c: Make symbols static if they're not exported.
6328 (process_tick, update_tick, create_process, chan_process):
6329 (Vprocess_alist, proc_buffered_char, datagram_access):
6330 (fd_callback_data, send_process_frame, process_sent_to): Now static.
6331 (deactivate_process): Mark defn as static, as well as decl.
6332 * lisp.h (create_process): Remove decl.
6333 * process.h (chan_process, Vprocess_alist): Remove decls.
6335 * print.c: Make symbols static if they're not exported.
6336 (print_depth, new_backquote_output, being_printed, print_buffer):
6337 (print_buffer_size, print_buffer_pos, print_buffer_pos_byte):
6338 (print_interval, print_number_index, initial_stderr_stream):
6340 * lisp.h (Fprinc): Remove decl.
6341 (debug_output_compilation_hack): Mark as externally visible.
6343 * sysdep.c (croak): Move decl from here to syssignal.h.
6344 * syssignal.h (croak): Put it here, so the API can be checked when
6345 'croak' is called from dissociate_if_controlling_tty.
6347 * minibuf.c: Make symbols static if they're not exported.
6348 (minibuf_save_list, choose_minibuf_frame): Now static.
6349 * lisp.h (choose_minibuf_frame): Remove decl.
6351 * lisp.h (verify_bytepos, count_markers): Mark as externally visible.
6353 * lread.c: Make symbols static if they're not exported.
6354 (read_objects, initial_obarray, oblookup_last_bucket_number):
6356 (make_symbol): Remove; unused.
6357 * lisp.h (initial_obarray, make_symbol): Remove decls.
6359 * keyboard.c: Make symbols static if they're not exported.
6360 (single_kboard, recent_keys_index, total_keys, recent_keys):
6361 (this_command_key_count_reset, raw_keybuf, raw_keybuf_count):
6362 (this_single_command_key_start, echoing, last_auto_save):
6363 (read_key_sequence_cmd, dribble, recursive_edit_unwind):
6364 (command_loop, echo_now, keyboard_init_hook, help_char_p):
6365 (quit_throw_to_read_char, command_loop_2, top_level_1, poll_timer):
6366 (Vlispy_mouse_stem, double_click_count):
6368 (force_auto_save_soon): Define only if SIGDANGER.
6369 (ignore_mouse_drag_p): Now static if
6370 !defined HAVE_WINDOW_SYSTEM || defined USE_GTK || defined HAVE_NS.
6371 (print_help): Remove; unused.
6372 (stop_character, last_timer_event): Mark as externally visible.
6373 * keyboard.h (ignore_mouse_drag_p): Declare only if
6374 defined HAVE_WINDOW_SYSTEM && !defined USE_GTK && !defined HAVE_NS.
6375 (echo_now, help_char_p, quit_throw_to_read_char): Remove decls.
6376 * lisp.h (echoing): Remove decl.
6377 (force_auto_save_soon): Declare only if SIGDANGER.
6378 * xdisp.c (redisplay_window): Simplify code, to make it more
6379 obvious that ignore_mouse_drag_p is not accessed if !defined
6380 USE_GTK && !defined HAVE_NS.
6382 * intervals.c: Make symbols static if they're not exported.
6383 (merge_properties_sticky, merge_interval_right, delete_interval):
6385 * intervals.h (merge_interval_right, delete_interval): Remove decls.
6387 * insdel.c: Make symbols static if they're not exported.
6388 However, leave prepare_to_modify_buffer alone. It's never
6389 called from outside this function, but that appears to be a bug.
6390 (combine_after_change_list, combine_after_change_buffer):
6391 (adjust_after_replace, signal_before_change): Now static.
6392 (adjust_after_replace_noundo): Remove; unused.
6393 * lisp.h (adjust_after_replace, adjust_after_replace_noundo):
6394 (signal_before_change): Remove decls.
6396 * indent.c (val_compute_motion, val_vmotion): Now static.
6398 * image.c: Make symbols static if they're not exported.
6399 * dispextern.h (x_create_bitmap_from_xpm_data): Do not declare
6401 * image.c (x_create_bitmap_from_xpm_data): Do not define if USE_GTK.
6402 (xpm_color_cache, ct_table, ct_colors_allocated): Now static.
6404 * fringe.c (standard_bitmaps): Now static.
6405 (max_used_fringe_bitmap): Now static, unless HAVE_NS.
6407 * frame.c: Make symbols static if they're not exported.
6408 (x_report_frame_params, make_terminal_frame): Now static.
6409 (get_frame_param): Now static, unless HAVE_NS.
6410 (x_fullscreen_adjust): Define if WINDOWSNT, not if HAVE_WINDOW_SYSTEM.
6411 (x_get_resource_string): Remove; not used.
6412 * frame.h (make_terminal_frame, x_report_frame_params):
6413 (x_get_resource_string); Remove decls.
6414 (x_fullscreen_adjust): Declare only if WINDOWSNT.
6415 * lisp.h (get_frame_param): Declare only if HAVE_NS.
6417 * font.c, fontset.c: Make symbols static if they're not exported.
6418 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): New macro.
6419 (FACE_SUITABLE_FOR_CHAR_P): Use it.
6420 * font.c (font_close_object): Now static.
6421 * font.h (font_close_object): Remove.
6422 * fontset.c (FONTSET_OBJLIST): Remove.
6423 (free_realized_fontset) #if-0 the body, which does nothing.
6424 (face_suitable_for_char_p): #if-0, as it's never called.
6425 * fontset.h (face_suitable_for_char_p): Remove decl.
6426 * xfaces.c (face_at_string_position):
6427 Use FACE_SUITABLE_FOR_ASCII_CHAR_P, not FACE_SUITABLE_FOR_CHAR_P,
6428 since 0 is always ASCII.
6430 * fns.c (weak_hash_tables): Now static.
6432 * fileio.c: Make symbols static if they're not exported.
6433 (auto_saving, auto_save_mode_bits, auto_save_error_occurred):
6434 (Vwrite_region_annotation_buffers): Now static.
6436 * eval.c: Make symbols static if they're not exported.
6437 (backtrace_list, lisp_eval_depth, when_entered_debugger): Now static.
6438 * lisp.h (backtrace_list): Remove decl.
6440 * emacs.c: Make symbols static if they're not exported.
6441 (malloc_state_ptr, malloc_using_checking, syms_of_emacs):
6442 (fatal_error_code, fatal_error_signal_hook, standard_args):
6444 (fatal_error_signal): Now static, unless FLOAT_CATCH_SIGKILL.
6445 (DEFINE_DUMMY_FUNCTION): Mark function as externally visible.
6446 (__CTOR_LIST__, __DTOR_LIST__): Now externally visible.
6447 * lisp.h (fatal_error_signal_hook): Remove decl.
6448 (fatal_error_signal): Declare only if FLOAT_CATCH_SIGKILL.
6450 * editfns.c: Move a (normally-unused) function to its only use.
6451 * editfns.c, lisp.h (get_operating_system_release): Remove.
6452 * process.c (init_process) [DARWIN_OS]: Do it inline, as it is not
6453 worth the hassle of breaking this out.
6455 * xterm.c: Make symbols static if they're not exported.
6456 (x_raise_frame, x_lower_frame, x_wm_set_window_state):
6457 (x_wm_set_icon_pixmap, x_initialize, XTread_socket_fake_io_error):
6458 (x_destroy_window, x_delete_display):
6460 (x_dispatch_event): Now static if ! (USE_MOTIF || USE_X_TOOLKIT).
6461 (x_mouse_leave): Remove; unused.
6462 * xterm.h (x_display_info_for_name, x_raise_frame, x_lower_frame):
6463 (x_destroy_window, x_wm_set_window_state, x_wm_set_icon_pixmap):
6464 (x_delete_display, x_initialize, x_set_border_pixel, x_screen_planes):
6466 (x_mouse_leave): Declare only if WINDOWSNT.
6467 (x_dispatch_event): Declare only if USE_MOTIF or USE_X_TOOLKIT.
6468 (xic_create_fontsetname): Declare only if HAVE_X_WINDOWS &&
6471 * ftxfont.c: Make symbols static if they're not exported.
6472 (ftxfont_driver): Export only if !defined HAVE_XFT && def8ined
6474 * font.h (ftxfont_driver): Likewise.
6476 * xfns.c: Make symbols static if they're not exported.
6477 (x_last_font_name, x_display_info_for_name):
6478 (x_set_foreground_color, x_set_background_color, x_set_mouse_color):
6479 (x_set_cursor_color, x_set_border_pixel, x_set_border_color):
6480 (x_set_cursor_type, x_set_icon_type, x_set_icon_name):
6481 (x_set_scroll_bar_foreground, x_set_scroll_bar_background):
6482 (x_explicitly_set_name, x_set_title, xic_defaut_fontset, tip_timer):
6483 (last_show_tip_args): Now static.
6484 (xic_defaut_fontset, xic_create_fontsetname): Define only if
6485 defined HAVE_X_WINDOWS && defined USE_X_TOOLKIT
6486 (x_screen_planes): Remove; unused.
6487 * dispextern.h (x_screen_planes): Remove decl.
6489 * dispnew.c: Make symbols static if they're not exported.
6490 * dispextern.h (redraw_garbaged_frames, scrolling):
6491 (increment_row_positions): Remove.
6492 * dispnew.c (new_glyph_matrix, increment_row_positions, scrolling):
6493 (delayed_size_change, glyph_matrix_count, glyph_pool_count):
6495 (redraw_garbaged_frames): Remove; unused.
6497 * xfaces.c: Make symbols static if they're not exported.
6498 * dispextern.h (ascii_face_of_lisp_face, free_realized_face):
6500 * xterm.h (defined_color): Remove decls.
6501 (x_free_dpy_colors): Declare only if USE_X_TOOLKIT.
6502 * xfaces.c (tty_suppress_bold_inverse_default_colors_p):
6503 (menu_face_changed_default, defined_color, free_realized_face):
6504 (x_free_dpy_colors): Define only if USE_X_TOOLKIT.
6505 (ascii_face_of_lisp_face): Remove; unused.
6507 * xdisp.c: Make symbols static if they're not exported.
6508 * dispextern.h (scratch_glyph_row, window_box_edges):
6509 (glyph_to_pixel_coords, set_cursor_from_row):
6510 (get_next_display_element, set_iterator_to_next):
6511 (highlight_trailing_whitespace, frame_to_window_pixel_xy):
6512 (show_mouse_face): Remove decls
6513 * frame.h (message_buf_print): Likewise.
6514 * lisp.h (pop_message, set_message, check_point_in_composition):
6516 * xterm.h (set_vertical_scroll_bar): Likewise.
6517 * xdisp.c (list_of_error, Vmessage_stack, line_number_displayed):
6518 (message_buf_print, scratch_glyph_row, displayed_buffer):
6519 (set_iterator_to_next, pop_message, set_message, set_cursor_from_row):
6520 (get_next_display_element, show_mouse_face, window_box_edges):
6521 (frame_to_window_pixel_xy, check_point_in_composition):
6522 (set_vertical_scroll_bar, highlight_trailing_whitespace): Now static.
6523 (glyph_to_pixel_coords): Remove; unused.
6525 * dired.c (file_name_completion): Now static.
6527 * dbusbind.c (xd_in_read_queued_messages): Now static.
6529 * lisp.h (circular_list_error, FOREACH): Remove; unused.
6530 * data.c (circular_list_error): Remove.
6532 * commands.h (last_point_position, last_point_position_buffer):
6533 (last_point_position_window): Remove decls.
6534 * keyboard.c: Make these variables static.
6536 * coding.h (coding, code_convert_region, encode_coding_gap):
6538 * coding.c (Vsjis_coding_system, Vbig5_coding_system):
6539 (iso_code_class, detect_coding, code_convert_region): Now static.
6540 (encode_coding_gap): Remove; unused.
6542 * chartab.c (chartab_chars, chartab_bits): Now static.
6544 * charset.h (charset_iso_8859_1): Remove decl.
6545 * charset.c (charset_iso_8859_1, charset_emacs, map_charset_for_dump):
6548 * ccl.h (check_ccl_update, Vccl_program_table): Remove decls.
6549 * ccl.c (Vccl_program_table): Now static.
6550 (check_ccl_update): Remove; unused.
6552 * category.c (SET_CATEGORY_SET, set_category_set): Move here.
6553 * category.h: ... from here.
6554 * category.c (check_category_table, set_category_set): Now static.
6556 * casetab.c (Vascii_upcase_table, Vascii_eqv_table): Now static.
6557 * lisp.h: Remove these decls.
6559 * buffer.c (buffer_count): Remove unused var.
6561 * bidi.c (bidi_dump_cached_states): Mark as externally visible,
6562 so that it's not optimized away.
6563 (bidi_ignore_explicit_marks_for_paragraph_level): Likewise.
6564 * dispextern.h (bidi_dump_cached_states): Remove, since it's
6565 exported only to the debugger.
6567 * atimer.c (alarm_signal_handler, run_all_atimers): Now static.
6568 * atimer.h (run_all_atimers): Remove; not exported.
6570 font.c: Make copy_font_spec and merge_font_spec ordinary C functions.
6571 * font.c (copy_font_spec): Rename from Fcopy_font_spec, since it
6572 was inaccessible from Lisp.
6573 (merge_font_spec): Likewise, renaming from Fmerge_font_spec.
6574 * font.c, font.h, fontset.c, xfaces.c, xfont.c: Change all uses.
6576 alloc.c: Import and export fewer symbols, and remove unused items.
6577 * lisp.h (suppress_checking, die): Declare only if ENABLE_CHECKING
6579 (suppress_checking): Add EXTERNALLY_VISIBLE attribute, so that
6580 it's not optimized away by whole-program optimization.
6581 (message_enable_multibyte, free_misc): Remove.
6582 (catchlist, handlerlist, mark_backtrace):
6583 Declare only if BYTE_MARK_STACK.
6584 (mark_byte_stack): Likewise, fixing a ifdef-vs-if typo.
6585 * alloc.c (pure): Export only if VIRT_ADDR_VARIES is defined.
6586 (message_enable_multibyte): Remove decl.
6587 (free_misc, interval_free_list, float_block, float_block_index):
6588 (n_float_blocks, float_free_list, cons_block, cons_block_index):
6589 (cons_free_list, last_marked_index):
6591 (suppress_checking, die): Define only if ENABLE_CHECKING is defined.
6592 * eval.c (catchlist, handlerlist): Export only if BYTE_MARK_STACK.
6593 (mark_backtrace): Define only if BYTE_MARK_STACK.
6594 * xdisp.c (message_enable_multibyte): Now static.
6596 Declare Lisp_Object Q* variables to be 'static' if not exported.
6597 This makes it easier for human readers (and static analyzers)
6598 to see whether these variables are used from other modules.
6599 * alloc.c, buffer.c, bytecode.c, callint.c, casetab.c, category.c:
6600 * ccl.c, character.c, charset.c, cmds.c, coding.c, composite.c:
6601 * data.c, dbusbind.c, dired.c, editfns.c, eval.c, fileio.c, fns.c:
6602 * font.c, frame.c, fringe.c, ftfont.c, image.c, keyboard.c, keymap.c:
6603 * lread.c, macros.c, minibuf.c, print.c, process.c, search.c:
6604 * sound.c, syntax.c, textprop.c, window.c, xdisp.c, xfaces.c, xfns.c:
6605 * xmenu.c, xselect.c:
6606 Declare Q* vars static if they are not used in other modules.
6607 * ccl.h, character.h, charset.h, coding.h, composite.h, font.h:
6608 * frame.h, intervals.h, keyboard.h, lisp.h, process.h, syntax.h:
6609 Remove decls of unexported vars.
6610 * keyboard.h (EVENT_HEAD_UNMODIFIED): Remove now-unused macro.
6612 * lisp.h (DEFINE_FUNC): Make sname 'static'.
6614 Make Emacs functions such as Fatom 'static' by default.
6615 This makes it easier for human readers (and static analyzers)
6616 to see whether these functions can be called from other modules.
6617 DEFUN now defines a static function. To make the function external
6618 so that it can be used in other C modules, use the new macro DEFUE.
6619 * lisp.h (Funibyte_char_to_multibyte, Fsyntax_table_p):
6620 (Finit_image_library):
6621 (Feval_region, Fbacktrace, Ffetch_bytecode, Fswitch_to_buffer):
6622 (Ffile_executable_p, Fmake_symbolic_link, Fcommand_execute):
6623 (Fget_process, Fdocumentation_property, Fbyte_code, Ffile_attributes):
6624 Remove decls, since these functions are now static.
6625 (Funintern, Fget_internal_run_time): New decls, since these functions
6626 were already external.
6628 * alloc.c, buffer.c, callint.c, callproc.c, casefiddle.c, casetab.c:
6629 * ccl.c, character.c, chartab.c, cmds.c, coding.c, data.c, dispnew.c:
6630 * doc.c, editfns.c, emacs.c, eval.c, fileio.c, filelock.c, floatfns.c:
6631 * fns.c, font.c, fontset.c, frame.c, image.c, indent.c:
6632 * keyboard.c, keymap.c, lread.c:
6633 * macros.c, marker.c, menu.c, minibuf.c, print.c, process.c, search.c:
6634 * syntax.c, term.c, terminal.c, textprop.c, undo.c:
6635 * window.c, xdisp.c, xfaces.c, xfns.c, xmenu.c, xsettings.c:
6636 Mark functions with DEFUE instead of DEFUN,
6637 if they are used in other modules.
6638 * buffer.c (Fset_buffer_major_mode, Fdelete_overlay): New forward
6639 decls for now-static functions.
6640 * buffer.h (Fdelete_overlay): Remove decl.
6641 * callproc.c (Fgetenv_internal): Mark as internal.
6642 * composite.c (Fremove_list_of_text_properties): Remove decl.
6643 (Fcomposition_get_gstring): New forward static decl.
6644 * composite.h (Fcomposite_get_gstring): Remove decl.
6645 * dired.c (Ffile_attributes): New forward static decl.
6646 * doc.c (Fdocumntation_property): New forward static decl.
6647 * eval.c (Ffetch_bytecode): New forward static decl.
6648 (Funintern): Remove extern decl; now in .h file where it belongs.
6649 * fileio.c (Fmake_symbolic_link): New forward static decl.
6650 * image.c (Finit_image_library): New forward static decl.
6651 * insdel.c (Fcombine_after_change_execute): Make forward decl static.
6652 * intervals.h (Fprevious_property_change):
6653 (Fremove_list_of_text_properties): Remove decls.
6654 * keyboard.c (Fthis_command_keys): Remove decl.
6655 (Fcommand_execute): New forward static decl.
6656 * keymap.c (Flookup_key): New forward static decl.
6657 (Fcopy_keymap): Now static.
6658 * keymap.h (Flookup_key): Remove decl.
6659 * process.c (Fget_process): New forward static decl.
6660 (Fprocess_datagram_address): Mark as internal.
6661 * syntax.c (Fsyntax_table_p): New forward static decl.
6662 (skip_chars): Remove duplicate decl.
6663 * textprop.c (Fprevious_property_change): New forward static decl.
6664 * window.c (Fset_window_fringes, Fset_window_scroll_bars):
6666 (Fset_window_margins, Fset_window_vscroll): New forward static decls.
6667 * window.h (Fset_window_vscroll, Fset_window_margins): Remove decls.
6669 * editfns.c (Fformat): Remove unreachable code.
6671 2011-04-14 Andreas Schwab <schwab@linux-m68k.org>
6673 * fileio.c (Finsert_file_contents): Fix typo in 2005-05-13
6676 2011-04-13 Eli Zaretskii <eliz@gnu.org>
6678 * xdisp.c (handle_invisible_prop): Don't call bidi_paragraph_init
6679 when at ZV. (Bug#8487)
6681 2011-04-12 Andreas Schwab <schwab@linux-m68k.org>
6683 * charset.c (Fclear_charset_maps): Use xfree instead of free.
6685 * keyboard.c (parse_tool_bar_item): Likewise.
6686 * sound.c (sound_cleanup, alsa_close): Likewise.
6687 * termcap.c (tgetent): Likewise.
6688 * xfns.c (x_default_font_parameter): Likewise.
6689 * xsettings.c (read_and_apply_settings): Likewise.
6691 * alloc.c (overrun_check_malloc, overrun_check_realloc)
6692 (overrun_check_free): Protoize.
6694 2011-04-12 Paul Eggert <eggert@cs.ucla.edu>
6696 * sysdep.c (emacs_read, emacs_write): Check for negative sizes
6697 since callers should never pass a negative size.
6698 Change the signature to match that of plain 'read' and 'write'; see
6699 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00397.html>.
6700 * lisp.h: Update prototypes of emacs_write and emacs_read.
6702 2011-04-11 Eli Zaretskii <eliz@gnu.org>
6704 * xdisp.c (redisplay_window): Don't try to determine the character
6705 position of the scroll margin if the window start point w->startp
6706 is outside the buffer's accessible region. (Bug#8468)
6708 2011-04-10 Eli Zaretskii <eliz@gnu.org>
6710 Fix write-region and its subroutines for buffers > 2GB.
6711 * fileio.c (a_write, e_write): Modify declaration of arguments and
6712 local variables to support buffers larger than 2GB.
6713 (Fcopy_file): Use EMACS_INT for return value of emacs_read.
6715 * sysdep.c (emacs_write, emacs_read): Use ssize_t for last
6716 argument, local variables, and return value.
6718 * lisp.h: Update prototypes of emacs_write and emacs_read.
6720 * sound.c (vox_write): Use ssize_t for return value of emacs_write.
6722 2011-04-10 Paul Eggert <eggert@cs.ucla.edu>
6724 * xdisp.c (vmessage): Use memchr, not strnlen, which some hosts lack.
6726 Fix more problems found by GCC 4.6.0's static checks.
6728 * xdisp.c (vmessage): Use a better test for character truncation.
6730 * charset.c (load_charset_map): <, not <=, for optimization,
6731 and to avoid potential problems with integer overflow.
6732 * chartab.c (sub_char_table_set_range, char_table_set_range): Likewise.
6733 * casetab.c (set_identity, shuffle): Likewise.
6734 * editfns.c (Fformat): Likewise.
6735 * syntax.c (skip_chars): Likewise.
6737 * xmenu.c (set_frame_menubar): Allocate smaller local vectors.
6738 This also lets GCC 4.6.0 generate slightly better loop code.
6740 * callint.c (Fcall_interactively): <, not <=, for optimization.
6741 (Fcall_interactively): Count the number of arguments produced,
6742 not the number of arguments given. This is simpler and lets GCC
6743 4.6.0 generate slightly better code.
6745 * ftfont.c: Distingish more carefully between FcChar8 and char.
6746 The previous code passed unsigned char * to a functions like
6747 strlen and xstrcasecmp that expect char *, which does not
6748 conform to the C standard.
6749 (get_adstyle_property, ftfont_pattern_entity): Use FcChar8 for
6750 arguments to FcPatternGetString, and explicitly cast FcChar8 * to
6751 char * when the C standard requires it.
6753 * keyboard.c (read_char): Remove unused var.
6755 * eval.c: Port to Windows vsnprintf (Bug#8435).
6757 (SIZE_MAX): Define if the headers do not.
6758 (verror): Do not give up if vsnprintf returns a negative count.
6759 Instead, grow the buffer. This ports to Windows vsnprintf, which
6760 does not conform to C99. Problem reported by Eli Zaretskii.
6761 Also, simplify the allocation scheme, by avoiding the need for
6762 calling realloc, and removing the ALLOCATED variable.
6764 * eval.c (verror): Initial buffer size is 4000 (not 200) bytes.
6766 Remove invocations of doprnt, as Emacs now uses vsnprintf.
6767 But keep the doprint source code for now, as we might revamp it
6768 and use it again (Bug#8435).
6769 * lisp.h (doprnt): Remove.
6770 * Makefile.in (base_obj): Remove doprnt.o.
6771 * deps.mk (doprnt.o): Remove.
6773 error: Print 32- and 64-bit integers portably (Bug#8435).
6774 Without this change, on typical 64-bit hosts error ("...%d...", N)
6775 was used to print both 32- and 64-bit integers N, which relied on
6777 * lisp.h, src/m/amdx86-64.h, src/m/ia64.h, src/m/ibms390x.h (pEd):
6779 * lisp.h (error, verror): Mark as printf-like functions.
6780 * eval.c (verror): Use vsnprintf, not doprnt, to do the real work.
6781 Report overflow in size calculations when allocating printf buffer.
6782 Do not truncate output string at its first null byte.
6783 * xdisp.c (vmessage): Use vsnprintf, not doprnt, to do the real work.
6784 Truncate the output at a character boundary, since vsnprintf does not
6786 * charset.c (check_iso_charset_parameter): Convert internal
6787 character to string before calling 'error', since %c now has the
6789 * coding.c (Fdecode_sjis_char, Fdecode_big5_char): Avoid int
6790 overflow when computing char to be passed to 'error'. Do not
6791 pass Lisp_Object to 'error'; pass the integer instead.
6792 * nsfns.m (Fns_do_applescript): Use int, not long, since it's
6793 formatted with plain %d.
6795 * eval.c (internal_lisp_condition_case): Don't pass spurious arg.
6797 * keyboard.c (access_keymap_keyremap): Print func name, not garbage.
6799 * coding.c (Fdecode_sjis_char): Don't assume CODE fits in int.
6801 * xterm.c (x_catch_errors): Remove duplicate declaration.
6803 * term.c (maybe_fatal): Mark its 3rd arg as a printf format, too.
6805 * xdisp.c, lisp.h (message_nolog): Remove; unused.
6807 2011-04-10 Jim Meyering <meyering@redhat.com>
6809 use ssize_t and size_t for read- and write-like emacs_gnutls_* functions
6810 * gnutls.c (emacs_gnutls_read): Adjust signature to be more read-like:
6811 return ssize_t not "int", and use size_t as the buffer length.
6812 (emacs_gnutls_write): Likewise, and make the buffer pointer "const".
6813 * gnutls.h: Update declarations.
6814 * process.c (read_process_output): Use ssize_t, to match.
6815 (send_process): Likewise.
6817 2011-04-09 Chong Yidong <cyd@stupidchicken.com>
6819 * image.c (Fimagemagick_types): Doc fix, and comment cleanup.
6821 2011-04-09 Chong Yidong <cyd@stupidchicken.com>
6823 * ftfont.c (get_adstyle_property, ftfont_pattern_entity):
6824 Use unsigned char, to match FcChar8 type definition.
6826 * xterm.c (handle_one_xevent):
6827 * xmenu.c (create_and_show_popup_menu):
6828 * xselect.c (x_decline_selection_request)
6829 (x_reply_selection_request): Avoid type-punned deref of X events.
6831 2011-04-09 Eli Zaretskii <eliz@gnu.org>
6833 Fix some uses of `int' instead of EMACS_INT.
6834 * search.c (string_match_1, fast_string_match)
6835 (fast_c_string_match_ignore_case, fast_string_match_ignore_case)
6836 (scan_buffer, find_next_newline_no_quit)
6837 (find_before_next_newline, search_command, Freplace_match)
6838 (Fmatch_data): Make some `int' variables be EMACS_INT.
6840 * xdisp.c (display_count_lines): 3rd argument and return value now
6841 EMACS_INT. All callers changed.
6842 (pint2hrstr): Last argument is now EMACS_INT.
6844 * coding.c (detect_coding_utf_8, detect_coding_emacs_mule)
6845 (detect_coding_iso_2022, detect_coding_sjis, detect_coding_big5)
6846 (detect_coding_ccl, detect_coding_charset, decode_coding_utf_8)
6847 (decode_coding_utf_16, decode_coding_emacs_mule)
6848 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5)
6849 (decode_coding_ccl, decode_coding_charset)
6850 <consumed_chars, consumed_chars_base>: Declare EMACS_INT.
6851 (decode_coding_iso_2022, decode_coding_emacs_mule)
6852 (decode_coding_sjis, decode_coding_big5, decode_coding_charset)
6853 <char_offset, last_offset>: Declare EMACS_INT.
6854 (encode_coding_utf_8, encode_coding_utf_16)
6855 (encode_coding_emacs_mule, encode_invocation_designation)
6856 (encode_designation_at_bol, encode_coding_iso_2022)
6857 (encode_coding_sjis, encode_coding_big5, encode_coding_ccl)
6858 (encode_coding_raw_text, encode_coding_charset) <produced_chars>:
6860 (ASSURE_DESTINATION): Declare more_bytes EMACS_INT.
6861 (encode_invocation_designation): Last argument P_NCHARS is now
6863 (decode_eol): Declare pos_byte, pos, and pos_end EMACS_INT.
6864 (produce_chars): from_nchars and to_nchars are now EMACS_INT.
6866 * coding.h (struct coding_system) <head_ascii>: Declare EMACS_INT.
6869 * ccl.c (Fccl_execute_on_string): Declare some variables
6872 2011-04-08 Samuel Thibault <sthibault@debian.org> (tiny change)
6874 * term.c (init_tty): Fix incorrect ifdef placement (Bug#8450).
6876 2011-03-19 Christoph Scholtes <cschol2112@googlemail.com>
6878 * process.c (Fformat_network_address): Doc fix.
6880 2011-04-08 T.V. Raman <tv.raman.tv@gmail.com> (tiny change)
6882 * xml.c (parse_region): Avoid creating spurious whiespace nodes.
6884 2011-04-08 Chong Yidong <cyd@stupidchicken.com>
6886 * keyboard.c (read_char): Call Lisp function help-form-show,
6887 instead of using internal_with_output_to_temp_buffer.
6888 (Qhelp_form_show): New var.
6889 (syms_of_keyboard): Use DEFSYM macro.
6891 * print.c (internal_with_output_to_temp_buffer): Function deleted.
6893 * lisp.h (internal_with_output_to_temp_buffer): Remove prototype.
6895 2011-04-06 Chong Yidong <cyd@stupidchicken.com>
6897 * process.c (Flist_processes): Remove to Lisp.
6898 (list_processes_1): Delete.
6900 2011-04-06 Eli Zaretskii <eliz@gnu.org>
6902 * msdos.c (careadlinkat, careadlinkatcwd): MS-DOS replacements.
6904 * w32.c (careadlinkat, careadlinkatcwd): New always-fail stubs.
6906 2011-04-06 Paul Eggert <eggert@cs.ucla.edu>
6908 Fix more problems found by GCC 4.6.0's static checks.
6910 * xmenu.c (Fx_popup_dialog): Don't assume string is free of formats.
6912 * menu.c (Fx_popup_menu): Don't assume error_name lacks printf formats.
6914 * lisp.h (message, message_nolog, fatal): Mark as printf-like.
6916 * xdisp.c (vmessage): Mark as a printf-like function.
6918 * term.c (vfatal, maybe_fatal): Mark as printf-like functions.
6920 * sound.c (sound_warning): Don't crash if arg contains a printf format.
6922 * image.c (tiff_error_handler, tiff_warning_handler): Mark as
6923 printf-like functions.
6924 (tiff_load): Add casts to remove these marks before passing them
6925 to system-supplied API.
6927 * eval.c (Fsignal): Remove excess argument to 'fatal'.
6929 * coding.c (EMIT_ONE_BYTE, EMIT_TWO_BYTES): Use unsigned, not int.
6930 This avoids several warnings with gcc -Wstrict-overflow.
6931 (DECODE_COMPOSITION_RULE): If the rule is invalid, goto invalid_code
6932 directly, rather than having caller test rule sign. This avoids
6933 some unnecessary tests.
6934 * composite.h (COMPOSITION_ENCODE_RULE_VALID): New macro.
6935 (COMPOSITION_ENCODE_RULE): Arguments now must be valid. This
6936 affects only one use, in DECODE_COMPOSITION_RULE, which is changed.
6938 * xfont.c (xfont_text_extents): Remove var that was set but not used.
6939 (xfont_open): Avoid unnecessary tests.
6941 * composite.c (composition_gstring_put_cache): Use unsigned integer.
6943 * composite.h, composite.c (composition_gstring_put_cache):
6944 Use EMACS_INT, not int, for length.
6946 * composite.h (COMPOSITION_DECODE_REFS): New macro,
6947 breaking out part of COMPOSITION_DECODE_RULE.
6948 (COMPOSITION_DECODE_RULE): Use it.
6949 * composite.c (get_composition_id): Remove unused local vars,
6950 by using the new macro.
6952 * textprop.c (set_text_properties_1): Change while to do-while,
6953 since the condition is always true at first.
6955 * intervals.c (graft_intervals_into_buffer): Mark var as used.
6956 (interval_deletion_adjustment): Return unsigned value.
6959 * process.c (list_processes_1, create_pty, read_process_output):
6960 (exec_sentinel): Remove vars that were set but not used.
6961 (create_pty): Remove unnecessary "volatile"s.
6962 (Fnetwork_interface_info): Avoid possibility of int overflow.
6963 (read_process_output): Do adaptive read buffering even if carryover.
6964 (read_process_output): Simplify nbytes computation if buffered.
6966 * bytecode.c (exec_byte_code): Rename local to avoid shadowing.
6968 * syntax.c (scan_words): Remove var that was set but not used.
6969 (update_syntax_table): Use unsigned instead of int.
6971 * lread.c (lisp_file_lexically_bound_p): Use ints rather than endptrs.
6972 (lisp_file_lexically_bound_p, read1): Use unsigned instead of int.
6973 (safe_to_load_p): Make the end-of-loop test the inverse of the in-loop.
6975 * print.c (print_error_message): Avoid int overflow.
6977 * font.c (font_list_entities): Redo for clarity,
6978 so that reader need not know FONT_DPI_INDEX + 1 == FONT_SPACING_INDEX.
6980 * font.c (font_find_for_lface, Ffont_get_glyphs): Remove unused vars.
6981 (font_score): Avoid potential overflow in diff calculation.
6983 * fns.c (substring_both): Remove var that is set but not used.
6984 (sxhash): Redo loop for clarity and to avoid wraparound warning.
6986 * eval.c (funcall_lambda): Rename local to avoid shadowing.
6988 * alloc.c (mark_object_loop_halt, mark_object): Use size_t, not int.
6989 Otherwise, GCC 4.6.0 optimizes the loop check away since the check
6990 can always succeed if overflow has undefined behavior.
6992 * search.c (boyer_moore, wordify): Remove vars set but not used.
6993 (wordify): Omit three unnecessary tests.
6995 * indent.c (MULTIBYTE_BYTES_WIDTH): Don't compute wide_column.
6996 All callers changed. This avoids the need for an unused var.
6998 * casefiddle.c (casify_region): Remove var that is set but not used.
7000 * dired.c (file_name_completion): Remove var that is set but not used.
7002 * fileio.c (Finsert_file_contents): Make EOF condition clearer.
7004 * fileio.c (Finsert_file_contents): Avoid signed integer overflow.
7005 (Finsert_file_contents): Remove unnecessary code checking fd.
7007 * minibuf.c (read_minibuf_noninteractive): Use size_t for sizes.
7008 Check for integer overflow on size calculations.
7010 * buffer.c (Fprevious_overlay_change): Remove var that is set
7013 * keyboard.c (menu_bar_items, read_char_minibuf_menu_prompt):
7014 Remove vars that are set but not used.
7015 (timer_check_2): Don't assume timer-list and idle-timer-list are lists.
7016 (timer_check_2): Mark vars as initialized.
7018 * gtkutil.c (xg_get_file_with_chooser): Mark var as initialized.
7020 * image.c (lookup_image): Remove var that is set but not used.
7021 (xbm_load): Use parse_p, for gcc -Werror=unused-but-set-variable.
7023 * fontset.c (Finternal_char_font, Ffontset_info): Remove vars
7024 that are set but not used.
7026 * xfns.c (make_invisible_cursor): Don't return garbage
7027 if XCreateBitmapFromData fails (Bug#8410).
7029 * xselect.c (x_get_local_selection, x_handle_property_notify):
7030 Remove vars that are set but not used.
7032 * xfns.c (x_create_tip_frame): Remove var that is set but not used.
7033 (make_invisible_cursor): Initialize a possibly-uninitialized variable.
7035 * xterm.c (x_scroll_bar_to_input_event) [!USE_GTK]:
7036 Remove var that is set but not used.
7037 (scroll_bar_windows_size): Now size_t, not int.
7038 (x_send_scroll_bar_event): Use size_t, not int, for sizes.
7041 * xfaces.c (realize_named_face): Remove vars that are set but not used.
7042 (map_tty_color) [!defined MSDOS]: Likewise.
7044 * term.c (tty_write_glyphs): Use size_t; this avoids overflow warning.
7046 * coding.c: Remove vars that are set but not used.
7047 (DECODE_COMPOSITION_RULE): Remove 2nd arg, which is unused.
7048 All callers changed.
7049 (decode_coding_utf_8, decode_coding_utf_16 decode_coding_emacs_mule):
7050 (decode_coding_iso_2022, encode_coding_sjis, encode_coding_big5):
7051 (decode_coding_charset): Remove vars that are set but not used.
7053 * bytecode.c (Fbyte_code) [!defined BYTE_CODE_SAFE]: Remove var
7054 that is set but not used.
7056 * print.c (print_object): Remove var that is set but not used.
7058 Replace 2 copies of readlink code with 1 gnulib version (Bug#8401).
7059 The gnulib version avoids calling malloc in the usual case,
7060 and on 64-bit hosts doesn't have some arbitrary 32-bit limits.
7061 * fileio.c (Ffile_symlink_p): Use emacs_readlink.
7062 * filelock.c (current_lock_owner): Likewise.
7063 * lisp.h (READLINK_BUFSIZE, emacs_readlink): New function.
7064 * sysdep.c: Include allocator.h, careadlinkat.h.
7065 (emacs_no_realloc_allocator): New static constant.
7066 (emacs_readlink): New function.
7067 * deps.mk (sysdep.o): Depend on ../lib/allocator.h and on
7068 ../lib/careadlinkat.h.
7070 2011-04-04 Stefan Monnier <monnier@iro.umontreal.ca>
7072 * keyboard.c (safe_run_hook_funcall): Fix last change (don't stop at the
7073 first non-nil return value).
7075 2011-04-03 Jan Djärv <jan.h.d@swipnet.se>
7077 * nsterm.m (ns_update_auto_hide_menu_bar): Define MAC_OS_X_VERSION_10_6
7078 if not defined (Bug#8403).
7080 2011-04-02 Juanma Barranquero <lekktu@gmail.com>
7082 * xdisp.c (display_count_lines): Remove parameter `start',
7083 unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
7084 (get_char_face_and_encoding): Remove parameter `multibyte_p',
7085 unused since 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
7086 (fill_stretch_glyph_string): Remove parameters `row' and `area',
7087 unused at least since Kim's GUI unification at 2003-03-16T20:45:46Z!storm@cua.dk
7088 and thereabouts. All callers changed.
7089 (get_per_char_metric): Remove parameter `f', unused since
7090 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
7092 2011-04-02 Jim Meyering <meyering@redhat.com>
7094 do not dereference NULL upon failed strdup
7095 * nsfont.m (ns_descriptor_to_entity): Use xstrdup, not strdup.
7096 (ns_get_family): Likewise.
7098 2011-04-02 Juanma Barranquero <lekktu@gmail.com>
7100 * eval.c (unwind_to_catch) [DEBUG_GCPRO]: Remove redundant assignment.
7102 2011-04-02 Jan Djärv <jan.h.d@swipnet.se>
7104 * nsterm.m (ns_update_auto_hide_menu_bar): Only for OSX 10.6 or
7107 2011-04-01 Stefan Monnier <monnier@iro.umontreal.ca>
7109 Add lexical binding.
7111 * window.c (Ftemp_output_buffer_show): New fun.
7112 (Fsave_window_excursion):
7113 * print.c (Fwith_output_to_temp_buffer): Move to subr.el.
7115 * lread.c (lisp_file_lexically_bound_p): New function.
7116 (Fload): Bind Qlexical_binding.
7117 (readevalloop): Remove `evalfun' arg.
7118 Bind Qinternal_interpreter_environment.
7119 (Feval_buffer): Bind Qlexical_binding.
7120 (defvar_int, defvar_bool, defvar_lisp_nopro, defvar_kboard):
7122 (syms_of_lread): Declare `lexical-binding'.
7124 * lisp.h (struct Lisp_Symbol): New field `declared_special'.
7126 * keyboard.c (eval_dyn): New fun.
7127 (menu_item_eval_property): Use it.
7129 * image.c (parse_image_spec): Use Ffunctionp.
7131 * fns.c (concat, mapcar1): Accept byte-code-functions.
7133 * eval.c (Fsetq): Handle lexical vars.
7134 (Fdefun, Fdefmacro, Ffunction): Make closures when needed.
7135 (Fdefconst, Fdefvaralias, Fdefvar): Mark as dynamic.
7136 (FletX, Flet): Obey lexical binding.
7137 (Fcommandp): Handle closures.
7138 (Feval): New `lexical' arg.
7139 (eval_sub): New function extracted from Feval. Use it almost
7140 everywhere where Feval was used. Look up vars in lexical env.
7142 (Ffunctionp): Move from subr.el.
7143 (Ffuncall): Handle closures.
7144 (apply_lambda): Remove `eval_flags'.
7145 (funcall_lambda): Handle closures and new byte-code-functions.
7146 (Fspecial_variable_p): New function.
7147 (syms_of_eval): Initialize the Vinternal_interpreter_environment var,
7148 but without exporting it to Lisp.
7150 * doc.c (Fdocumentation, store_function_docstring):
7151 * data.c (Finteractive_form): Handle closures.
7153 * callint.c (Fcall_interactively): Preserve lexical-binding mode for
7156 * bytecode.c (Bstack_ref, Bstack_set, Bstack_set2, BdiscardN):
7158 (exec_byte_code): New function extracted from Fbyte_code to handle new
7159 calling convention for byte-code-functions. Add new byte-codes.
7161 * buffer.c (defvar_per_buffer): Set new `declared_special' field.
7163 * alloc.c (Fmake_symbol): Init new `declared_special' field.
7165 2011-03-31 Juanma Barranquero <lekktu@gmail.com>
7167 * xdisp.c (redisplay_internal): Fix prototype.
7169 2011-03-31 Eli Zaretskii <eliz@gnu.org>
7171 * xdisp.c (SCROLL_LIMIT): New macro.
7172 (try_scrolling): Use it when setting scroll_limit.
7173 Limit scrolling to 100 screen lines.
7174 (redisplay_window): Even when falling back on "recentering",
7175 position point in the window according to scroll-conservatively,
7176 scroll-margin, and scroll-*-aggressively variables. (Bug#6671)
7178 (try_scrolling): When point is above the window, allow searching
7179 as far as scroll_max, or one screenful, to compute vertical
7180 distance from PT to the scroll margin position. This prevents
7181 try_scrolling from unnecessarily failing when
7182 scroll-conservatively is set to a value slightly larger than the
7183 window height. Clean up the case of PT below the margin at bottom
7184 of window: scroll_max can no longer be INT_MAX. When aggressive
7185 scrolling is in use, don't let point enter the opposite scroll
7186 margin as result of the scroll.
7187 (syms_of_xdisp) <scroll-conservatively>: Document the
7188 threshold of 100 lines for never-recentering scrolling.
7190 2011-03-31 Juanma Barranquero <lekktu@gmail.com>
7192 * dispextern.h (move_it_by_lines):
7193 * xdisp.c (move_it_by_lines): Remove parameter `need_y_p', unused
7194 since 2000-12-29T14:24:09Z!gerd@gnu.org. All callers changed.
7195 (message_log_check_duplicate): Remove parameters `prev_bol' and
7196 `this_bol', unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
7197 (redisplay_internal): Remove parameter `preserve_echo_area',
7198 unused since 1999-07-21T21:43:52Z!gerd@gnu.org. All callers changed.
7200 * indent.c (Fvertical_motion):
7201 * window.c (window_scroll_pixel_based, Frecenter):
7202 Don't pass `need_y_p' to `move_it_by_lines'.
7204 2011-03-30 Stefan Monnier <monnier@iro.umontreal.ca>
7206 * eval.c (struct backtrace): Don't cheat with negative numbers, but do
7207 steal a few bits to be more compact.
7208 (interactive_p, Fbacktrace, Fbacktrace_frame, mark_backtrace):
7209 Remove unneeded casts.
7211 * bytecode.c (Fbyte_code): CAR and CDR can GC.
7213 2011-03-30 Zachary Kanfer <zkanfer@gmail.com> (tiny change)
7215 * keyboard.c (Fexecute_extended_command): Do log the "suggest key
7216 binding" message (bug#7967).
7218 2011-03-30 Paul Eggert <eggert@cs.ucla.edu>
7220 Fix more problems found by GCC 4.6.0's static checks.
7222 * unexelf.c (unexec) [! (defined _SYSTYPE_SYSV || defined __sgi)]:
7223 Remove unused local var.
7225 * editfns.c (Fmessage_box): Remove unused local var.
7227 * xdisp.c (try_window_reusing_current_matrix, x_produce_glyphs):
7228 (note_mode_line_or_margin_highlight, note_mouse_highlight):
7229 Omit unused local vars.
7230 * window.c (shrink_windows): Omit unused local var.
7231 * menu.c (digest_single_submenu): Omit unused local var.
7232 * dispnew.c (update_window) [PERIODIC_PREEMPTION_CHECKING]:
7233 Omit unused local var.
7235 * keyboard.c (parse_modifiers_uncached, parse_modifiers):
7236 Don't assume string length fits in int.
7237 (keyremap_step, read_key_sequence): Use size_t for sizes.
7238 (read_key_sequence): Don't check last_real_key_start redundantly.
7240 * callproc.c (Fcall_process, Fcall_process_region): Use SAFE_ALLOCA
7241 instead of alloca (Bug#8344).
7243 * eval.c (Fbacktrace): Don't assume nargs fits in int.
7244 (Fbacktrace_frame): Don't assume nframes fits in int.
7246 * syntax.c (scan_sexps_forward): Avoid pointer wraparound.
7248 * xterm.c (x_make_frame_visible, same_x_server): Redo to avoid overflow
7251 * term.c (produce_glyphless_glyph): Remove unnecessary test.
7253 * cm.c (calccost): Turn while-do into do-while, for clarity.
7255 * keyboard.c (syms_of_keyboard): Use the same style as later
7256 in this function when indexing through an array. This also
7257 works around GCC bug 48267.
7259 * image.c (tiff_load): Fix off-by-one image count (Bug#8336).
7261 * xselect.c (x_check_property_data): Return correct size (Bug#8335).
7263 * chartab.c (sub_char_table_ref_and_range): Redo for slight
7264 efficiency gain, and to bypass a gcc -Wstrict-overflow warning.
7266 * keyboard.c, keyboard.h (num_input_events): Now size_t.
7267 This avoids undefined behavior on integer overflow, and is a bit
7268 more convenient anyway since it is compared to a size_t variable.
7270 Variadic C functions now count arguments with size_t, not int.
7271 This avoids an unnecessary limitation on 64-bit machines, which
7272 caused (substring ...) to crash on large vectors (Bug#8344).
7273 * lisp.h (struct Lisp_Subr.function.aMANY): Now takes size_t, not int.
7274 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call): Likewise.
7275 All variadic functions and their callers changed accordingly.
7276 (struct gcpro.nvars): Now size_t, not int. All uses changed.
7277 * data.c (arith_driver, float_arith_driver): Likewise.
7278 * editfns.c (general_insert_function): Likewise.
7279 * eval.c (struct backtrace.nargs, interactive_p)
7280 (internal_condition_case_n, run_hook_with_args, apply_lambda)
7281 (funcall_lambda, mark_backtrace): Likewise.
7282 * fns.c (concat): Likewise.
7283 * frame.c (x_set_frame_parameters): Likewise.
7284 * fns.c (get_key_arg): Now accepts and returns size_t, and returns
7285 0 if not found, not -1. All callers changed.
7287 * alloc.c (garbage_collect): Don't assume stack size fits in int.
7288 (stack_copy_size): Now size_t, not int.
7289 (stack_copy, stack_copy_size): Define only if MAX_SAVE_STACK > 0.
7291 2011-03-28 Juanma Barranquero <lekktu@gmail.com>
7293 * coding.c (encode_designation_at_bol): Remove parameter `charbuf_end',
7294 unused since 2002-03-01T01:17:24Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
7295 All callers changed.
7297 * lisp.h (multibyte_char_to_unibyte):
7298 * character.c (multibyte_char_to_unibyte): Remove parameter `rev_tbl',
7299 unused since 2002-03-01T01:16:34Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
7300 * character.h (CHAR_TO_BYTE8):
7301 * cmds.c (internal_self_insert):
7302 * editfns.c (general_insert_function):
7303 * keymap.c (push_key_description):
7304 * search.c (Freplace_match):
7305 * xdisp.c (message_dolog, set_message_1): All callers changed.
7307 2011-03-28 Stefan Monnier <monnier@iro.umontreal.ca>
7309 * keyboard.c (safe_run_hook_funcall): New function.
7310 (safe_run_hooks_1, safe_run_hooks_error, safe_run_hooks): On error,
7311 don't set the hook to nil, but remove the offending function instead.
7312 (Qcommand_hook_internal): Remove, unused.
7313 (syms_of_keyboard): Don't initialize Qcommand_hook_internal nor define
7314 Vcommand_hook_internal.
7316 * eval.c (enum run_hooks_condition): Remove.
7317 (funcall_nil, funcall_not): New functions.
7318 (run_hook_with_args): Call each function through a `funcall' argument.
7319 Remove `cond' argument, now redundant.
7320 (Frun_hooks, Frun_hook_with_args, Frun_hook_with_args_until_success)
7321 (Frun_hook_with_args_until_failure): Adjust accordingly.
7322 (run_hook_wrapped_funcall, Frun_hook_wrapped): New functions.
7324 2011-03-28 Juanma Barranquero <lekktu@gmail.com>
7326 * dispextern.h (string_buffer_position): Remove declaration.
7328 * print.c (strout): Remove parameter `multibyte', unused since
7329 1999-08-21T19:30:21Z!gerd@gnu.org. All callers changed.
7331 * search.c (boyer_moore): Remove parameters `len', `pos' and `lim',
7332 never used since function introduction in 1998-02-08T21:33:56Z!rms@gnu.org.
7333 All callers changed.
7335 * w32.c (_wsa_errlist): Use braces for struct initializers.
7337 * xdisp.c (string_buffer_position_lim): Remove parameter `w',
7338 never used since function introduction in 2001-03-09T18:41:50Z!gerd@gnu.org.
7339 All callers changed.
7340 (string_buffer_position): Likewise. Also, make static (it's never
7341 used outside xdisp.c).
7342 (cursor_row_p): Remove parameter `w', unused since
7343 2000-10-17T16:08:57Z!gerd@gnu.org. All callers changed.
7344 (decode_mode_spec): Remove parameter `precision', introduced during
7345 Gerd Moellmann's rewrite at 1999-07-21T21:43:52Z!gerd@gnu.org, but never used.
7346 All callers changed.
7348 2011-03-27 Jan Djärv <jan.h.d@swipnet.se>
7350 * nsterm.m (syms_of_nsterm): Use doc: for ns-auto-hide-menu-bar.
7352 2011-03-27 Anders Lindgren <andlind@gmail.com>
7354 * nsterm.m (ns_menu_bar_is_hidden): New variable.
7355 (ns_constrain_all_frames, ns_menu_bar_should_be_hidden)
7356 (ns_update_auto_hide_menu_bar): New functions.
7357 (ns_update_begin): Call ns_update_auto_hide_menu_bar.
7358 (applicationDidBecomeActive): Call ns_update_auto_hide_menu_bar and
7359 ns_constrain_all_frames.
7360 (constrainFrameRect): Return at once if ns_menu_bar_should_be_hidden.
7361 (syms_of_nsterm): DEFVAR ns-auto-hide-menu-bar, init to Qnil.
7363 2011-03-27 Jan Djärv <jan.h.d@swipnet.se>
7365 * nsmenu.m (runDialogAt): Remove argument to timer_check.
7367 2011-03-27 Glenn Morris <rgm@gnu.org>
7369 * syssignal.h: Replace RETSIGTYPE with void.
7370 * atimer.c, data.c, dispnew.c, emacs.c, floatfns.c, keyboard.c:
7371 * keyboard.h, lisp.h, process.c, sysdep.c, xterm.c:
7372 Replace SIGTYPE with void everywhere.
7373 * s/usg5-4-common.h (SIGTYPE): Remove definition.
7374 * s/template.h (SIGTYPE): Remove commented out definition.
7376 2011-03-26 Eli Zaretskii <eliz@gnu.org>
7378 * xdisp.c (redisplay_window): Don't check buffer's clip_changed
7379 flag as a prerequisite for invoking try_scrolling. (Bug#6671)
7381 2011-03-26 Juanma Barranquero <lekktu@gmail.com>
7383 * w32.c (read_unc_volume): Use parameter `henum', instead of
7384 global variable `wget_enum_handle'.
7386 * keymap.c (describe_vector): Remove parameters `indices' and
7387 `char_table_depth', unused since 2002-03-01T01:43:26Z!handa@m17n.org.
7388 (describe_map, Fdescribe_vector): Adjust calls to `describe_vector'.
7390 * keyboard.h (timer_check, show_help_echo): Remove unused parameters.
7392 * keyboard.c (timer_check): Remove parameter `do_it_now',
7393 unused since 1996-04-12T06:01:29Z!rms@gnu.org.
7394 (show_help_echo): Remove parameter `ok_to_overwrite_keystroke_echo',
7395 unused since 2008-04-19T19:30:53Z!monnier@iro.umontreal.ca.
7397 * keyboard.c (read_char):
7398 * w32menu.c (w32_menu_display_help):
7399 * xmenu.c (show_help_event, menu_help_callback):
7400 Adjust calls to `show_help_echo'.
7402 * gtkutil.c (xg_maybe_add_timer):
7403 * keyboard.c (readable_events):
7404 * process.c (wait_reading_process_output):
7405 * xmenu.c (x_menu_wait_for_event): Adjust calls to `timer_check'.
7407 * insdel.c (adjust_markers_gap_motion):
7408 Remove; no-op since 1998-01-02T21:29:48Z!rms@gnu.org.
7409 (gap_left, gap_right): Don't call it.
7411 2011-03-25 Chong Yidong <cyd@stupidchicken.com>
7413 * xdisp.c (handle_fontified_prop): Discard changes to clip_changed
7414 incurred during fontification.
7416 2011-03-25 Juanma Barranquero <lekktu@gmail.com>
7418 * buffer.c (defvar_per_buffer): Remove unused parameter `doc'.
7419 (DEFVAR_PER_BUFFER): Don't pass it.
7421 * dispnew.c (row_equal_p, add_row_entry): Remove unused parameter `w'.
7422 (scrolling_window): Don't pass it.
7424 2011-03-25 Juanma Barranquero <lekktu@gmail.com>
7426 * dispextern.h (glyph_matric): Use #if GLYPH_DEBUG, not #ifdef.
7428 * fileio.c (check_executable) [DOS_NT]: Remove unused variables `len'
7430 (Fset_file_selinux_context) [HAVE_LIBSELINUX]: Move here declaration
7431 of variables specific to SELinux and computation of `encoded_absname'.
7433 * image.c (XPutPixel): Remove unused variable `height'.
7435 * keyboard.c (make_lispy_event): Remove unused variable `hpos'.
7437 * unexw32.c (get_section_info): Remove unused variable `section'.
7439 * w32.c (stat): Remove unused variables `drive_root' and `devtype'.
7440 (system_process_attributes): Remove unused variable `sess'.
7441 (sys_read): Remove unused variable `err'.
7443 * w32fns.c (top): Wrap variables with #if GLYPH_DEBUG, not #ifdef.
7444 (w32_wnd_proc): Remove unused variable `isdead'.
7445 (unwind_create_frame): Use #if GLYPH_DEBUG, not #ifdef.
7446 (Fx_server_max_request_size): Remove unused variable `dpyinfo'.
7447 (x_create_tip_frame): Remove unused variable `tem'.
7449 * w32inevt.c (w32_console_read_socket):
7450 Remove unused variable `no_events'.
7452 * w32term.c (x_draw_composite_glyph_string_foreground):
7453 Remove unused variable `width'.
7455 2011-03-24 Juanma Barranquero <lekktu@gmail.com>
7457 * w32term.c (x_set_glyph_string_clipping):
7458 Don't pass uninitialized region to CombineRgn.
7460 2011-03-23 Juanma Barranquero <lekktu@gmail.com>
7462 * w32fns.c (x_set_menu_bar_lines): Remove unused variable `olines'.
7463 (w32_wnd_proc): Pass NULL to Windows API, not uninitialized buffer.
7464 (Fx_close_connection): Remove unused variable `i'.
7466 * w32font.c (w32font_draw): Return number of glyphs.
7467 (w32font_open_internal): Remove unused variable `i'.
7468 (w32font_driver): Add missing initializer.
7470 * w32menu.c (utf8to16): Remove unused variable `utf16'.
7471 (fill_in_menu): Remove unused variable `items_added'.
7473 * w32term.c (last_mouse_press_frame): Remove static global variable.
7474 (w32_clip_to_row): Remove unused variable `f'.
7475 (x_delete_terminal): Remove unused variable `i'.
7477 * w32uniscribe.c (uniscribe_shape): Remove unused variable `nclusters'.
7478 (NOTHING): Remove unused static global variable.
7479 (uniscribe_check_otf): Remove unused variable `table'.
7480 (uniscribe_font_driver): Add missing initializers.
7482 2011-03-23 Julien Danjou <julien@danjou.info>
7484 * term.c (Fsuspend_tty, Fresume_tty):
7485 * minibuf.c (read_minibuf, run_exit_minibuf_hook):
7486 * window.c (temp_output_buffer_show):
7487 * insdel.c (signal_before_change):
7488 * frame.c (Fhandle_switch_frame):
7489 * fileio.c (Fdo_auto_save):
7490 * emacs.c (Fkill_emacs):
7491 * editfns.c (save_excursion_restore):
7492 * cmds.c (internal_self_insert):
7493 * callint.c (Fcall_interactively):
7494 * buffer.c (Fkill_all_local_variables):
7495 * keyboard.c (Fcommand_execute, Fsuspend_emacs, safe_run_hooks_1):
7497 (command_loop_1): Use Frun_hooks. Call safe_run_hooks
7498 unconditionnaly since it does the check itself.
7500 2011-03-23 Paul Eggert <eggert@cs.ucla.edu>
7502 Fix more problems found by GCC 4.5.2's static checks.
7504 * coding.c (encode_coding_raw_text): Avoid unnecessary test
7505 the first time through the loop, since we know p0 < p1 then.
7506 This also avoids a gcc -Wstrict-overflow warning.
7508 * lisp.h (SAFE_ALLOCA, SAFE_ALLOCA_LISP): Avoid 'int' overflow
7509 leading to a memory leak, possible in functions like
7510 load_charset_map_from_file that can allocate an unbounded number
7511 of objects (Bug#8318).
7513 * xmenu.c (set_frame_menubar): Use EMACS_UINT, not int, for indexes
7514 that could (at least in theory) be that large.
7516 * xdisp.c (message_log_check_duplicate): Return unsigned long, not int.
7517 This is less likely to overflow, and avoids undefined behavior if
7518 overflow does occur. All callers changed. Use strtoul to scan
7519 for the unsigned long integer.
7520 (pint2hrstr): Simplify and tune code slightly.
7521 This also avoids a (bogus) GCC warning with gcc -Wstrict-overflow.
7523 * scroll.c (do_scrolling): Work around GCC bug 48228.
7524 See <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=48228>.
7526 * frame.c (Fmodify_frame_parameters): Simplify loop counter.
7527 This also avoids a warning with gcc -Wstrict-overflow.
7528 (validate_x_resource_name): Simplify count usage.
7529 This also avoids a warning with gcc -Wstrict-overflow.
7531 * fileio.c (Fcopy_file): Report error if fchown or fchmod
7534 * emacs.c (Fdaemon_initialized): Do not ignore I/O errors (Bug#8303).
7536 * process.c (Fmake_network_process): Use socklen_t, not int,
7537 where POSIX says socklen_t is required in portable programs.
7538 This fixes a porting bug on hosts like 64-bit HP-UX, where
7539 socklen_t is wider than int (Bug#8277).
7540 (Fmake_network_process, server_accept_connection):
7541 (wait_reading_process_output, read_process_output):
7544 * process.c: Rename or move locals to avoid shadowing.
7545 (list_processes_1, Fmake_network_process):
7546 (read_process_output_error_handler, exec_sentinel_error_handler):
7547 Rename or move locals.
7548 (Fmake_network_process): Define label "retry_connect" only if needed.
7549 (Fnetwork_interface_info): Fix pointer signedness.
7550 (process_send_signal): Add cast to avoid pointer signedness problem.
7551 (FIRST_PROC_DESC, IF_NON_BLOCKING_CONNECT): Remove unused macros.
7552 (create_process): Use 'volatile' to avoid vfork clobbering (Bug#8298).
7554 Make tparam.h and terminfo.c consistent.
7555 * cm.c (tputs, tgoto, BC, UP): Remove extern decls.
7556 Include tparam.h instead, since it declares them.
7557 * cm.h (PC): Remove extern decl; tparam.h now does this.
7558 * deps.mk (cm.o, terminfo.o): Depend on tparam.h.
7559 * terminfo.c: Include tparam.h, to check interfaces.
7560 (tparm): Make 1st arg a const pointer in decl. Put it at top level.
7561 (tparam): Adjust signature to match interface in tparam.h;
7562 this removes some undefined behavior. Check that outstring and len
7563 are zero, which they always are with Emacs.
7564 * tparam.h (PC, BC, UP): New extern decls.
7566 * xftfont.c (xftfont_shape): Now static, and defined only if needed.
7567 (xftfont_open): Rename locals to avoid shadowing.
7569 * ftfont.c (ftfont_resolve_generic_family): Fix pointer signedness.
7570 (ftfont_otf_capability, ftfont_shape): Omit decls if not needed.
7571 (OTF_TAG_SYM): Omit macro if not needed.
7572 (ftfont_list): Remove unused local.
7573 (get_adstyle_property, ftfont_pattern_entity):
7574 (ftfont_lookup_cache, ftfont_open, ftfont_anchor_point):
7575 Rename locals to avoid shadowing.
7577 * xfont.c (xfont_list_family): Mark var as initialized.
7579 * xml.c (make_dom): Now static.
7581 * composite.c (composition_compute_stop_pos): Rename local to
7583 (composition_reseat_it): Remove unused locals.
7584 (find_automatic_composition, composition_adjust_point): Likewise.
7585 (composition_update_it): Mark var as initialized.
7586 (find_automatic_composition): Mark vars as initialized,
7587 with a FIXME (Bug#8290).
7589 character.h: Rename locals to avoid shadowing.
7590 * character.h (PREV_CHAR_BOUNDARY, FETCH_STRING_CHAR_ADVANCE):
7591 (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE, FETCH_CHAR_ADVANCE):
7592 (FETCH_CHAR_ADVANCE_NO_CHECK, INC_POS, DEC_POS, BUF_INC_POS):
7593 (BUF_DEC_POS): Be more systematic about renaming local temporaries
7596 * textprop.c (property_change_between_p): Remove; unused.
7598 * intervals.c (interval_start_pos): Now static.
7600 * intervals.h (CHECK_TOTAL_LENGTH): Avoid empty "else".
7602 * atimer.c (start_atimer, append_atimer_lists, set_alarm):
7603 Rename locals to avoid shadowing.
7605 * sound.c (wav_play, au_play, Fplay_sound_internal):
7606 Fix pointer signedness.
7607 (alsa_choose_format): Remove unused local var.
7608 (wav_play): Initialize a variable to 0, to prevent undefined
7609 behavior (Bug#8278).
7611 * region-cache.c (insert_cache_boundary): Redo var to avoid shadowing.
7613 * region-cache.h (pp_cache): New decl, for gcc -Wmissing-prototypes.
7615 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork
7616 clobbering (Bug#8298).
7617 * sysdep.c (sys_subshell): Likewise.
7618 Previously, the sys_subshell 'volatile' was incorrectly IF_LINTted out.
7620 * lisp.h (child_setup): Now NO_RETURN unless DOS_NT.
7621 This should get cleaned up, so that child_setup has the
7622 same signature on all platforms.
7624 * callproc.c (call_process_cleanup): Now static.
7625 (relocate_fd): Rename locals to avoid shadowing.
7627 2011-03-22 Chong Yidong <cyd@stupidchicken.com>
7629 * xterm.c (x_clear_frame): Remove XClearWindow call. This appears
7630 not to be necessary, and produces flickering.
7632 2011-03-20 Glenn Morris <rgm@gnu.org>
7634 * config.in: Remove file.
7636 2011-03-20 Juanma Barranquero <lekktu@gmail.com>
7638 * minibuf.c (Vcompleting_read_function): Don't declare, global variables
7639 are now in src/globals.h.
7640 (syms_of_minibuf): Remove spurious & from previous change.
7642 2011-03-20 Leo <sdl.web@gmail.com>
7644 * minibuf.c (completing-read-function): New variable.
7645 (completing-read-default): Rename from completing-read.
7646 (completing-read): Call completing-read-function.
7648 2011-03-19 Juanma Barranquero <lekktu@gmail.com>
7650 * xfaces.c (Fx_load_color_file):
7651 Read color file from absolute filename (bug#8250).
7653 2011-03-19 Juanma Barranquero <lekktu@gmail.com>
7655 * makefile.w32-in: Update dependencies.
7657 2011-03-17 Eli Zaretskii <eliz@gnu.org>
7659 * makefile.w32-in ($(BLD)/unexw32.$(O)): Depend on $(SRC)/unexec.h.
7661 2011-03-17 Paul Eggert <eggert@cs.ucla.edu>
7663 Fix more problems found by GCC 4.5.2's static checks.
7665 * process.c (make_serial_process_unwind, send_process_trap):
7666 (sigchld_handler): Now static.
7668 * process.c (allocate_pty): Let PTY_ITERATION declare iteration vars.
7669 That way, the code declares only the vars that it needs.
7670 * s/aix4-2.h (PTY_ITERATION): Declare iteration vars.
7671 * s/cygwin.h (PTY_ITERATION): Likewise.
7672 * s/darwin.h (PTY_ITERATION): Likewise.
7673 * s/gnu-linux.h (PTY_ITERATION): Likewise.
7675 * s/irix6-5.h (PTY_OPEN): Declare stb, to loosen coupling.
7676 * process.c (allocate_pty): Don't declare stb unless it's needed.
7678 * bytecode.c (MAYBE_GC): Rewrite so as not to use empty "else".
7679 (CONSTANTLIM): Remove; unused.
7680 (METER_CODE, Bscan_buffer, Bread_char, Bset_mark):
7681 Define only if needed.
7683 * unexelf.c (unexec): Name an expression,
7684 to avoid gcc -Wbad-function-cast warning.
7685 Use a different way to cause a compilation error if anyone uses
7686 n rather than nn, a way that does not involve shadowing.
7687 (ELF_BSS_SECTION_NAME, OLD_PROGRAM_H): Remove; unused.
7689 * deps.mk (unexalpha.o): Remove; unused.
7691 New file unexec.h, the (simple) interface for unexec (Bug#8267).
7692 * unexec.h: New file.
7693 * deps.mk (emacs.o, unexaix.o, unexcw.o, unexcoff.o, unexelf.o):
7694 (unexhp9k800.o, unexmacosx.o, unexsol.o, unexw32.o):
7696 * emacs.c [!defined CANNOT_DUMP]: Include unexec.h.
7697 * unexaix.c, unexcoff.c, unexcw.c, unexelf.c, unexhp9k800.c:
7698 * unexmacosx.c, unexsol.c, unexw32.c: Include unexec.h.
7699 Change as necessary to match prototype in unexec.h.
7701 * syntax.c (Fforward_comment, scan_lists): Rename locals to avoid
7703 (back_comment, skip_chars): Mark vars as initialized.
7705 * character.h (FETCH_STRING_CHAR_ADVANCE_NO_CHECK, BUF_INC_POS):
7706 Rename locals to avoid shadowing.
7708 * lread.c (read1): Rewrite so as not to use empty "else".
7709 (Fload, readevalloop, read1): Rename locals to avoid shadowing.
7711 * print.c (Fredirect_debugging_output): Fix pointer signedess.
7713 * lisp.h (debug_output_compilation_hack): Add decl here, to avoid
7714 warning when compiling print.c.
7716 * font.c (font_unparse_fcname): Abort in an "impossible" situation
7717 instead of using an uninitialized var.
7718 (font_sort_entities): Mark var as initialized.
7720 * character.h (FETCH_CHAR_ADVANCE): Rename locals to avoid shadowing.
7722 * font.c (font_unparse_xlfd): Don't mix pointers to variables with
7723 pointers to constants.
7724 (font_parse_fcname): Remove unused vars.
7725 (font_delete_unmatched): Now static.
7726 (font_get_spec): Remove; unused.
7727 (font_style_to_value, font_prop_validate_style, font_unparse_fcname):
7728 (font_update_drivers, Ffont_get_glyphs, font_add_log):
7729 Rename or move locals to avoid shadowing.
7731 * fns.c (require_nesting_list, require_unwind): Now static.
7732 (Ffillarray): Rename locals to avoid shadowing.
7734 * floatfns.c (domain_error2): Define only if needed.
7735 (Ffrexp, Fldexp): Rename locals to avoid shadowing.
7737 * alloc.c (mark_backtrace): Move decl from here ...
7738 * lisp.h: ... to here, so that it can be checked.
7740 * eval.c (call_debugger, do_debug_on_call, grow_specpdl): Now static.
7741 (Fdefvar): Rewrite so as not to use empty "else".
7742 (lisp_indirect_variable): Name an expression,
7743 to avoid gcc -Wbad-function-cast warning.
7744 (Fdefvar): Rename locals to avoid shadowing.
7746 * callint.c (quotify_arg, quotify_args): Now static.
7747 (Fcall_interactively): Rename locals to avoid shadowing.
7748 Use const pointer when appropriate.
7750 * lisp.h (get_system_name, get_operating_system_release):
7751 Move decls here, to check interfaces.
7752 * process.c (get_operating_system_release): Move decl to lisp.h.
7753 * xrdb.c (get_system_name): Likewise.
7754 * editfns.c (init_editfns, Fuser_login_name, Fuser_uid):
7755 (Fuser_real_uid, Fuser_full_name): Remove unnecessary casts,
7756 some of which prompt warnings from gcc -Wbad-function-cast.
7757 (Fformat_time_string, Fencode_time, Finsert_char):
7758 (Ftranslate_region_internal, Fformat):
7759 Rename or remove local vars to avoid shadowing.
7760 (Ftranslate_region_internal): Mark var as initialized.
7762 * doc.c (Fdocumentation, Fsnarf_documentation): Move locals to
7765 * lisp.h (eassert): Check that the argument compiles, even if
7766 ENABLE_CHECKING is not defined.
7768 * data.c (Findirect_variable): Name an expression, to avoid
7769 gcc -Wbad-function-cast warning.
7770 (default_value, arithcompare, arith_driver, arith_error): Now static.
7771 (store_symval_forwarding): Rename local to avoid shadowing.
7772 (Fmake_variable_buffer_local, Fmake_local_variable):
7773 Mark variables as initialized.
7774 (do_blv_forwarding, do_symval_forwarding): Remove; unused.
7776 * alloc.c (check_cons_list): Do not define unless GC_CHECK_CONS_LIST.
7777 (Fmake_vector, Fvector, Fmake_byte_code, Fgarbage_collect):
7778 Rename locals to avoid shadowing.
7779 (mark_stack): Move local variables into the #ifdef region where
7781 (BLOCK_INPUT_ALLOC, UNBLOCK_INPUT_ALLOC): Define only if
7782 ! defined SYSTEM_MALLOC && ! defined SYNC_INPUT, as they are not
7784 (CHECK_ALLOCATED): Define only if GC_CHECK_MARKED_OBJECTS.
7785 (GC_STRING_CHARS): Remove; not used.
7786 (Fmemory_limit): Cast sbrk's returned value to char *.
7788 * lisp.h (check_cons_list): Declare if GC_CHECK_CONS_LIST; this
7789 avoids undefined behavior in theory.
7791 * regex.c (IF_LINT): Add defn, for benefit of ../lib-src.
7793 Use functions, not macros, for up- and down-casing (Bug#8254).
7794 * buffer.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
7795 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Remove. All callers changed
7796 to use the following functions instead of these macros.
7797 (downcase): Adjust to lack of DOWNCASE_TABLE. Return int, not
7798 EMACS_INT, since callers assume the returned value fits in int.
7799 (upcase1): Likewise, for UPCASE_TABLE.
7800 (uppercasep, lowercasep, upcase): New static inline functions.
7801 * editfns.c (Fchar_equal): Remove no-longer-needed workaround for
7802 the race-condition problem in the old DOWNCASE.
7804 * regex.c (CHARSET_LOOKUP_RANGE_TABLE_RAW, POP_FAILURE_REG_OR_COUNT):
7805 Rename locals to avoid shadowing.
7806 (regex_compile, re_match_2_internal): Move locals to avoid shadowing.
7807 (regex_compile, re_search_2, re_match_2_internal):
7808 Remove unused local vars.
7809 (FREE_VAR): Rewrite so as not to use empty "else",
7810 which gcc can warn about.
7811 (regex_compile, re_match_2_internal): Mark locals as initialized.
7812 (RETALLOC_IF): Define only if needed.
7813 (WORDCHAR_P): Likewise. This one is never needed, but is used
7814 only in a comment talking about a compiler bug, so put inside
7815 the #if 0 of that comment.
7816 (CHARSET_LOOKUP_BITMAP, FAIL_STACK_FULL, RESET_FAIL_STACK):
7817 (PUSH_FAILURE_ELT, BUF_PUSH_3, STOP_ADDR_VSTRING):
7820 * search.c (boyer_moore): Rename locals to avoid shadowing.
7821 * character.h (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE):
7822 (PREV_CHAR_BOUNDARY): Likewise.
7824 * search.c (simple_search): Remove unused var.
7826 * dired.c (compile_pattern): Move decl from here ...
7827 * lisp.h: ... to here, so that it can be checked.
7828 (struct re_registers): New forward decl.
7830 * character.h (INC_POS, DEC_POS): Rename locals to avoid shadowing.
7832 * indent.c (MULTIBYTE_BYTES_WIDTH): New args bytes, width.
7834 (MULTIBYTE_BYTES_WIDTH, scan_for_column, compute_motion):
7835 Rename locals to avoid shadowing.
7836 (Fvertical_motion): Mark locals as initialized.
7838 * casefiddle.c (casify_object, casify_region): Now static.
7839 (casify_region): Mark local as initialized.
7841 * cmds.c (internal_self_insert): Rename local to avoid shadowing.
7843 * lisp.h (GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR, GCPRO5_VAR, GCPRO6_VAR):
7844 New macros, so that the caller can use some names other than
7845 gcpro1, gcpro2, etc.
7846 (GCPRO2, GCPRO3, GCPRO4, GCPRO5, GCPRO6): Reimplement in terms
7848 (GCPRO1_VAR, UNGCPRO_VAR): Change the meaning of the second
7849 argument, for consistency with GCPRO2_VAR, etc: it is now the
7850 prefix of the variable, not the variable itself. All uses
7852 * dired.c (directory_files_internal, file_name_completion):
7853 Rename locals to avoid shadowing.
7855 Fix a race condition diagnosed by gcc -Wsequence-point (Bug#8254).
7856 An expression of the form (DOWNCASE (x) == DOWNCASE (y)), found in
7857 dired.c's scmp function, had undefined behavior.
7858 * lisp.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
7859 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Move from here ...
7860 * buffer.h: ... to here, because these macros use current_buffer,
7861 and the new implementation with inline functions needs to have
7862 current_buffer in scope now, rather than later when the macros
7864 (downcase, upcase1): New static inline functions.
7865 (DOWNCASE, UPCASE1): Reimplement using these functions.
7866 This avoids undefined behavior in expressions like
7867 DOWNCASE (x) == DOWNCASE (y), which previously suffered
7868 from race conditions in accessing the global variables
7869 case_temp1 and case_temp2.
7870 * casetab.c (case_temp1, case_temp2): Remove; no longer needed.
7871 * lisp.h (case_temp1, case_temp2): Remove their decls.
7872 * character.h (ASCII_CHAR_P): Move from here ...
7873 * lisp.h: ... to here, so that the inline functions mentioned
7876 * dired.c (directory_files_internal_unwind): Now static.
7878 * fileio.c (file_name_as_directory, directory_file_name):
7879 (barf_or_query_if_file_exists, auto_save_error, auto_save_1):
7881 (file_name_as_directory): Use const pointers when appropriate.
7882 (Fexpand_file_name): Likewise. In particular, newdir might
7883 point at constant storage, so make it a const pointer.
7884 (Fmake_directory_internal, Fread_file_name): Remove unused vars.
7885 (Ffile_selinux_context, Fset_file_selinux_context): Fix pointer
7887 (Fset_file_times, Finsert_file_contents, auto_save_error):
7888 Rename locals to avoid shadowing.
7890 * minibuf.c (choose_minibuf_frame_1): Now static.
7891 (Ftry_completion, Fall_completions): Rename or remove locals
7894 * marker.c (bytepos_to_charpos): Remove; unused.
7896 * lisp.h (verify_bytepos, count_markers): New decls,
7897 so that gcc does not warn that these functions aren't declared.
7899 * insdel.c (check_markers, make_gap_larger, make_gap_smaller):
7900 (reset_var_on_error, Fcombine_after_change_execute_1): Now static.
7901 (CHECK_MARKERS): Redo to avoid gcc -Wempty-body diagnostic.
7902 (copy_text): Remove unused local var.
7904 * filelock.c (within_one_second): Now static.
7905 (lock_file_1): Rename local to avoid shadowing.
7907 * buffer.c (fix_overlays_before): Mark locals as initialized.
7908 (fix_start_end_in_overlays): Likewise. This function should be
7909 simplified by using pointers-to-pointers, but that's a different
7911 (switch_to_buffer_1): Now static.
7912 (Fkill_buffer, record_buffer, Fbury_buffer, Fset_buffer_multibyte):
7913 (report_overlay_modification): Rename locals to avoid shadowing.
7915 * sysdep.c (system_process_attributes): Rename vars to avoid shadowing.
7916 Fix pointer signedness issue.
7917 (sys_subshell): Mark local as volatile if checking for lint,
7918 to suppress a gcc -Wclobbered warning that does not seem to be right.
7919 (MAXPATHLEN): Define only if needed.
7921 * process.c (serial_open, serial_configure): Move decls from here ...
7922 * systty.h: ... to here, so that they can be checked.
7924 * fns.c (get_random, seed_random): Move extern decls from here ...
7925 * lisp.h: ... to here, so that they can be checked.
7927 * sysdep.c (reset_io): Now static.
7928 (wait_for_termination_signal): Remove; unused.
7930 * keymap.c (keymap_parent, keymap_memberp, map_keymap_internal):
7931 (copy_keymap_item, append_key, push_text_char_description):
7933 (Fwhere_is_internal): Don't test CONSP (sequences) unnecessarily.
7934 (DENSE_TABLE_SIZE): Remove; unused.
7935 (get_keymap, access_keymap, Fdefine_key, Fwhere_is_internal):
7936 (describe_map_tree):
7937 Rename locals to avoid shadowing.
7939 * keyboard.c: Declare functions static if they are not used elsewhere.
7940 (echo_char, echo_dash, cmd_error, top_level_2):
7941 (poll_for_input, handle_async_input): Now static.
7942 (read_char, kbd_buffer_get_event, make_lispy_position):
7943 (make_lispy_event, make_lispy_movement, apply_modifiers):
7944 (decode_keyboard_code, tty_read_avail_input, menu_bar_items):
7945 (parse_tool_bar_item, read_key_sequence, Fread_key_sequence):
7946 (Fread_key_sequence_vector): Rename locals to avoid shadowing.
7947 (read_key_sequence, read_char): Mark locals as initialized.
7948 (Fexit_recursive_edit, Fabort_recursive_edit): Mark with NO_RETURN.
7950 * keyboard.h (make_ctrl_char): New decl.
7951 (mark_kboards): Move decl here ...
7952 * alloc.c (mark_kboards): ... from here.
7954 * lisp.h (force_auto_save_soon): New decl.
7956 * emacs.c (init_cmdargs): Rename local to avoid shadowing.
7957 (DEFINE_DUMMY_FUNCTION): New macro.
7958 (__do_global_ctors, __do_global_ctors_aux, __do_global_dtors, __main):
7960 (main): Add casts to avoid warnings
7961 if GCC considers string literals to be constants.
7963 * lisp.h (fatal_error_signal): Add decl, since it's exported.
7965 * dbusbind.c: Pointer signedness fixes.
7966 (xd_signature, xd_append_arg, xd_initialize):
7967 (Fdbus_call_method, Fdbus_call_method_asynchronously):
7968 (Fdbus_method_return_internal, Fdbus_method_error_internal):
7969 (Fdbus_send_signal, xd_read_message_1, Fdbus_register_service):
7970 (Fdbus_register_signal): Use SSDATA when the context wants char *.
7972 * dbusbind.c (Fdbus_init_bus): Add cast to avoid warning
7973 if GCC considers string literals to be constants.
7974 (Fdbus_register_service, Fdbus_register_method): Remove unused vars.
7976 2011-03-16 Stefan Monnier <monnier@iro.umontreal.ca>
7978 * print.c (PRINT_CIRCLE_CANDIDATE_P): New macro.
7979 (print_preprocess, print_object): New macro to fix last change.
7981 * print.c (print_preprocess): Don't forget font objects.
7983 2011-03-16 Juanma Barranquero <lekktu@gmail.com>
7985 * emacs.c (USAGE3): Doc fixes.
7987 2011-03-15 Andreas Schwab <schwab@linux-m68k.org>
7989 * coding.c (detect_coding_iso_2022): Reorganize code to clarify
7992 2011-03-14 Juanma Barranquero <lekktu@gmail.com>
7994 * lisp.h (VWindow_system, Qfile_name_history):
7995 * keyboard.h (lispy_function_keys) [WINDOWSNT]:
7996 * w32term.h (w32_system_caret_hwnd, w32_system_caret_height)
7997 (w32_system_caret_x, w32_system_caret_y): Declare extern.
7999 * w32select.c: Don't #include "keyboard.h".
8000 (run_protected): Add extern declaration for waiting_for_input.
8002 * w32.c (Qlocal, noninteractive1, inhibit_window_system):
8003 * w32console.c (detect_input_pending, read_input_pending)
8004 (encode_terminal_code):
8005 * w32fns.c (quit_char, lispy_function_keys, Qtooltip)
8006 (w32_system_caret_hwnd, w32_system_caret_height, w32_system_caret_x)
8007 (w32_system_caret_y, Qfile_name_history):
8008 * w32font.c (w32font_driver, QCantialias, QCotf, QClang):
8009 * w32inevt.c (reinvoke_input_signal, lispy_function_keys):
8010 * w32menu.c (Qmenu_bar, QCtoggle, QCradio, Qoverriding_local_map)
8011 (Qoverriding_terminal_local_map, Qmenu_bar_update_hook):
8012 * w32proc.c (Qlocal, report_file_error):
8013 * w32term.c (Vwindow_system, updating_frame):
8014 * w32uniscribe.c (initialized, uniscribe_font_driver):
8015 Remove unneeded extern declarations.
8017 2011-03-14 Chong Yidong <cyd@stupidchicken.com>
8019 * buffer.c (Fmake_indirect_buffer): Fix incorrect assertions.
8021 2011-03-13 Chong Yidong <cyd@stupidchicken.com>
8023 * buffer.h (BUF_BEGV, BUF_BEGV_BYTE, BUF_ZV, BUF_ZV_BYTE, BUF_PT)
8024 (BUF_PT_BYTE): Rewrite to handle indirect buffers (Bug#8219).
8025 These macros can no longer be used for assignment.
8027 * buffer.c (Fget_buffer_create, Fmake_indirect_buffer):
8028 Assign struct members directly, instead of using BUF_BEGV etc.
8029 (record_buffer_markers, fetch_buffer_markers): New functions for
8030 recording and fetching special buffer markers.
8031 (set_buffer_internal_1, set_buffer_temp): Use them.
8033 * lread.c (unreadchar): Use SET_BUF_PT_BOTH.
8035 * insdel.c (adjust_point): Use SET_BUF_PT_BOTH.
8037 * intervals.c (temp_set_point_both): Use SET_BUF_PT_BOTH.
8038 (get_local_map): Use SET_BUF_BEGV_BOTH and SET_BUF_ZV_BOTH.
8040 * xdisp.c (hscroll_window_tree):
8041 (reconsider_clip_changes): Use PT instead of BUF_PT.
8043 2011-03-13 Eli Zaretskii <eliz@gnu.org>
8045 * makefile.w32-in ($(BLD)/editfns.$(O)): Depend on
8046 $(EMACS_ROOT)/lib/intprops.h.
8048 2011-03-13 Paul Eggert <eggert@cs.ucla.edu>
8050 Fix more problems found by GCC 4.5.2's static checks.
8052 * gtkutil.c (xg_get_pixbuf_from_pixmap): Add cast from char *
8053 to unsigned char * to avoid compiler diagnostic.
8054 (xg_free_frame_widgets): Make it clear that a local variable is
8055 needed only if USE_GTK_TOOLTIP.
8056 (gdk_window_get_screen): Make it clear that this macro is needed
8057 only if USE_GTK_TOOLTIP.
8058 (int_gtk_range_get_value): New function, which avoids a diagnostic
8059 from gcc -Wbad-function-cast.
8060 (xg_set_toolkit_scroll_bar_thumb): Use it.
8061 (xg_tool_bar_callback, xg_tool_item_stale_p): Rewrite to avoid
8062 diagnostic from gcc -Wbad-function-cast.
8063 (get_utf8_string, xg_get_file_with_chooser):
8064 Rename locals to avoid shadowing.
8065 (create_dialog): Move locals to avoid shadowing.
8067 * xgselect.c (xg_select): Remove unused var.
8069 * image.c (four_corners_best): Mark locals as initialized.
8070 (gif_load): Initialize transparent_p to zero (Bug#8238).
8071 Mark another local as initialized.
8072 (my_png_error, my_error_exit): Mark with NO_RETURN.
8074 * image.c (clear_image_cache): Now static.
8075 (DIM, HAVE_STDLIB_H_1): Remove unused macros.
8076 (xpm_load): Redo to avoid "discards qualifiers" gcc warning.
8077 (x_edge_detection): Remove unnecessary cast that
8078 gcc -Wbad-function-cast diagnoses.
8079 (gif_load): Fix pointer signedness.
8080 (clear_image_cache, xbm_read_bitmap_data, x_detect_edges):
8081 (jpeg_load, gif_load): Rename locals to avoid shadowing.
8083 2011-03-12 Paul Eggert <eggert@cs.ucla.edu>
8085 Improve quality of tests for time stamp overflow.
8086 For example, without this patch (encode-time 0 0 0 1 1
8087 1152921504606846976) returns the obviously-bogus value (-948597
8088 62170) on my RHEL 5.5 x86-64 host. With the patch, it correctly
8089 reports time overflow. See
8090 <http://lists.gnu.org/archive/html/emacs-devel/2011-03/msg00470.html>.
8091 * deps.mk (editfns.o): Depend on ../lib/intprops.h.
8092 * editfns.c: Include limits.h and intprops.h.
8093 (TIME_T_MIN, TIME_T_MAX): New macros.
8094 (time_overflow): Move earlier, to before first use.
8095 (hi_time, lo_time): New functions, for an accurate test for
8097 (Fcurrent_time, Fget_internal_run_time, make_time): Use them.
8098 (Fget_internal_run_time): Don't assume time_t fits in int.
8099 (make_time): Use list2 instead of Fcons twice.
8100 (Fdecode_time): More accurate test for out-of-range times.
8101 (check_tm_member): New function.
8102 (Fencode_time): Use it, to test for out-of-range times.
8103 (lisp_time_argument): Don't rely on undefined left-shift and
8104 right-shift behavior when checking for time stamp overflow.
8106 * editfns.c (time_overflow): New function, refactoring common code.
8107 (Fformat_time_string, Fdecode_time, Fencode_time):
8108 (Fcurrent_time_string): Use it.
8110 Move 'make_time' to be next to its inverse 'lisp_time_argument'.
8111 * dired.c (make_time): Move to ...
8112 * editfns.c (make_time): ... here.
8113 * systime.h: Note the move.
8115 2011-03-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
8117 * fringe.c (update_window_fringes): Remove unused variables.
8119 * unexmacosx.c (copy_data_segment): Also copy __got section.
8122 2011-03-12 Eli Zaretskii <eliz@gnu.org>
8124 * termcap.c [MSDOS]: Include "msdos.h".
8125 (find_capability, tgetnum, tgetflag, tgetstr, tputs, tgetent):
8126 Constify `char *' arguments and their references according to
8127 prototypes in tparam.h.
8129 * deps.mk (termcap.o): Depend on tparam.h and msdos.h.
8131 * msdos.c (XMenuAddPane): 3rd argument is `const char *' now.
8132 Adapt all references accordingly.
8134 * msdos.h (XMenuAddPane): 3rd argument is `const char *' now.
8136 2011-03-11 Tom Tromey <tromey@redhat.com>
8138 * buffer.c (syms_of_buffer): Remove obsolete comment.
8140 2011-03-11 Eli Zaretskii <eliz@gnu.org>
8142 * termhooks.h (encode_terminal_code): Declare prototype.
8144 * msdos.c (encode_terminal_code): Don't declare prototype.
8146 * term.c (encode_terminal_code): Now external again, used by
8147 w32console.c and msdos.c.
8149 * makefile.w32-in ($(BLD)/term.$(O), ($(BLD)/tparam.$(O)):
8150 Depend on $(SRC)/tparam.h, see 2011-03-11T07:24:21Z!eggert@cs.ucla.edu.
8152 2011-03-11 Paul Eggert <eggert@cs.ucla.edu>
8154 Fix some minor problems found by GCC 4.5.2's static checks.
8156 * fringe.c (update_window_fringes): Mark locals as initialized
8158 (destroy_fringe_bitmap, init_fringe_bitmap): Now static.
8160 * alloc.c (mark_fringe_data): Move decl from here ...
8161 * lisp.h (mark_fringe_data) [HAVE_WINDOW_SYSTEM]: ... to here,
8162 to check its interface.
8163 (init_fringe_once): Do not declare unless HAVE_WINDOW_SYSTEM.
8165 * fontset.c (free_realized_fontset): Now static.
8166 (Fset_fontset_font): Rename local to avoid shadowing.
8167 (fontset_font): Mark local as initialized.
8168 (FONTSET_SPEC, FONTSET_REPERTORY, RFONT_DEF_REPERTORY): Remove; unused.
8170 * xrdb.c: Include "xterm.h", to check x_load_resources's interface.
8172 * xselect.c (x_disown_buffer_selections): Remove; not used.
8173 (TRACE3) [!defined TRACE_SELECTION]: Remove; not used.
8174 (x_own_selection, Fx_disown_selection_internal): Rename locals
8176 (x_handle_dnd_message): Remove local to avoid shadowing.
8178 * lisp.h (GCPRO1_VAR, UNGCPRO_VAR): New macros,
8179 so that the caller can use some name other than gcpro1.
8180 (GCPRO1, UNGCPRO): Reimplement in terms of the new macros.
8181 * xfns.c (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
8182 (Fx_backspace_delete_keys_p):
8183 Use them to avoid shadowing, and rename vars to avoid shadowing.
8184 (x_decode_color, x_set_name, x_window): Now static.
8185 (Fx_create_frame): Add braces to silence GCC warning.
8186 (Fx_file_dialog, Fx_select_font): Fix pointer signedness.
8187 (x_real_positions, xg_set_icon_from_xpm_data, x_create_tip_frame):
8188 Remove unused locals.
8189 (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
8190 (Fx_backspace_delete_keys_p): Rename locals to avoid shadowing.
8191 Some of these renamings use the new GCPRO1_VAR and UNGCPRO_VAR
8194 * xterm.h (x_mouse_leave): New decl.
8196 * xterm.c (x_copy_dpy_color, x_focus_on_frame, x_unfocus_frame):
8197 Remove unused functions.
8198 (x_shift_glyphs_for_insert, XTflash, XTring_bell):
8199 (x_calc_absolute_position): Now static.
8200 (XTread_socket): Don't define label "out" unless it's used.
8201 Don't declare local "event" unless it's used.
8202 (x_iconify_frame, x_free_frame_resources): Don't declare locals
8203 unless they are used.
8204 (XEMBED_VERSION, xembed_set_info): Don't define unless needed.
8205 (x_fatal_error_signal): Remove; not used.
8206 (x_draw_image_foreground, redo_mouse_highlight, XTmouse_position):
8207 (x_scroll_bar_report_motion, handle_one_xevent, x_draw_bar_cursor):
8208 (x_error_catcher, x_connection_closed, x_error_handler):
8209 (x_error_quitter, xembed_send_message, x_iconify_frame):
8210 (my_log_handler): Rename locals to avoid shadowing.
8211 (x_delete_glyphs, x_ins_del_lines): Mark with NO_RETURN.
8212 (x_connection_closed): Tell GCC not to suggest NO_RETURN.
8214 * xfaces.c (clear_face_cache, Fx_list_fonts, Fface_font):
8215 Rename or move locals to avoid shadowing.
8216 (tty_defined_color, merge_face_heights): Now static.
8217 (free_realized_faces_for_fontset): Remove; not used.
8218 (Fx_list_fonts): Mark variable that gcc -Wuninitialized
8219 does not deduce is never used uninitialized.
8220 (STRDUPA, LSTRDUPA, FONT_POINT_SIZE_QUANTUM): Remove; not used.
8221 (LFACEP): Define only if XASSERTS, as it's not needed otherwise.
8223 * terminal.c (store_terminal_param): Now static.
8225 * xmenu.c (menu_highlight_callback): Now static.
8226 (set_frame_menubar): Remove unused local.
8227 (xmenu_show): Rename parameter to avoid shadowing.
8228 (xmenu_show, xdialog_show, xmenu_show): Make local pointers "const"
8229 since they might point to immutable storage.
8230 (next_menubar_widget_id): Declare only if USE_X_TOOLKIT,
8231 since it's unused otherwise.
8233 * xdisp.c (produce_glyphless_glyph): Initialize lower_xoff.
8234 Add a FIXME, since the code still doesn't look right. (Bug#8215)
8235 (Fcurrent_bidi_paragraph_direction): Simplify slightly; this
8236 avoids a gcc -Wuninitialized diagnostic.
8237 (display_line, BUILD_COMPOSITE_GLYPH_STRING, draw_glyphs):
8238 (note_mouse_highlight): Mark variables that gcc -Wuninitialized
8239 does not deduce are never used uninitialized.
8241 * lisp.h (IF_LINT): New macro, copied from ../lib-src/emacsclient.c.
8243 * xdisp.c (redisplay_window): Rename local to avoid shadowing.
8244 * window.c (window_loop, size_window):
8245 (run_window_configuration_change_hook, enlarge_window): Likewise.
8247 * window.c (display_buffer): Now static.
8248 (size_window): Mark variables that gcc -Wuninitialized
8249 does not deduce are never used uninitialized.
8250 * window.h (check_all_windows): New decl, to forestall
8251 gcc -Wmissing-prototypes diagnostic.
8252 * dispextern.h (bidi_dump_cached_states): Likewise.
8254 * charset.h (CHECK_CHARSET_GET_CHARSET): Rename locals to avoid
8256 * charset.c (map_charset_for_dump, Fchar_charset): Likewise.
8258 (Fsort_charsets): Redo min/max calculation to shorten the code a bit
8259 and to avoid gcc -Wuninitialized warning.
8260 (load_charset_map): Mark variables that gcc -Wuninitialized
8261 does not deduce are never used uninitialized.
8262 (load_charset): Abort instead of using uninitialized var (Bug#8229).
8264 * coding.c (coding_set_source, coding_set_destination):
8265 Use "else { /* comment */ }" rather than "else /* comment */;"
8266 for clarity, and to avoid gcc -Wempty-body warning.
8267 (Fdefine_coding_system_internal): Don't redeclare 'i' inside
8268 a block, when the outer 'i' will do.
8269 (decode_coding_utf_8, decode_coding_utf_16, detect_coding_emacs_mule):
8270 (emacs_mule_char, decode_coding_emacs_mule, detect_coding_iso_2022):
8271 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5):
8272 (decode_coding_raw_text, decode_coding_charset, get_translation_table):
8273 (Fdecode_sjis_char, Fdefine_coding_system_internal):
8274 Rename locals to avoid shadowing.
8275 * character.h (FETCH_STRING_CHAR_ADVANCE): Likewise.
8276 * coding.c (emacs_mule_char, encode_invocation_designation):
8277 Now static, since they're not used elsewhere.
8278 (decode_coding_iso_2022): Add "default: abort ();" as a safety check.
8279 (decode_coding_object, encode_coding_object, detect_coding_system):
8280 (decode_coding_emacs_mule): Mark variables that gcc
8281 -Wuninitialized does not deduce are never used uninitialized.
8282 (detect_coding_iso_2022): Initialize a local variable that might
8283 be used uninitialized. Leave a FIXME because it's not clear that
8284 this initialization is needed. (Bug#8211)
8285 (ISO_CODE_LF, ISO_CODE_CR, CODING_ISO_FLAG_EUC_TW_SHIFT):
8286 (ONE_MORE_BYTE_NO_CHECK, UTF_BOM, UTF_16_INVALID_P):
8287 (SHIFT_OUT_OK, ENCODE_CONTROL_SEQUENCE_INTRODUCER):
8288 (ENCODE_DIRECTION_R2L, ENCODE_DIRECTION_L2R):
8289 Remove unused macros.
8291 * category.c (hash_get_category_set): Remove unused local var.
8292 (copy_category_table): Now static, since it's not used elsewhere.
8293 * character.c (string_count_byte8): Likewise.
8295 * ccl.c (CCL_WRITE_STRING, CCL_ENCODE_CHAR, Fccl_execute_on_string):
8296 (Fregister_code_conversion_map): Rename locals to avoid shadowing.
8298 * chartab.c (copy_sub_char_table): Now static, since it's not used
8300 (sub_char_table_ref_and_range, char_table_ref_and_range):
8301 Rename locals to avoid shadowing.
8302 (ASET_RANGE, GET_SUB_CHAR_TABLE): Remove unused macros.
8304 * bidi.c (bidi_check_type): Now static, since it's not used elsewhere.
8305 (BIDI_BOB): Remove unused macro.
8307 * cm.c (cmgoto): Mark variables that gcc -Wuninitialized does not
8308 deduce are never used uninitialized.
8309 * term.c (encode_terminal_code): Likewise.
8311 * term.c (encode_terminal_code): Now static. Remove unused local.
8313 * tparam.h: New file.
8314 * term.c, tparam.h: Include it.
8315 * deps.mk (term.o, tparam.o): Depend on tparam.h.
8316 * term.c (tputs, tgetent, tgetflag, tgetnum, tparam, tgetstr):
8317 Move these decls to tparam.h, and make them agree with what
8318 is actually in tparam.c. The previous trick of using incompatible
8319 decls in different modules does not conform to the C standard.
8320 All callers of tparam changed to use tparam's actual API.
8321 * tparam.c (tparam1, tparam, tgoto):
8322 Use const pointers where appropriate.
8324 * cm.c (calccost, cmgoto): Use const pointers where appropriate.
8325 * cm.h (struct cm): Likewise.
8326 * dispextern.h (do_line_insertion_deletion_costs): Likewise.
8327 * scroll.c (ins_del_costs, do_line_insertion_deletion_costs): Likewise.
8328 * term.c (tty_ins_del_lines, calculate_costs, struct fkey_table):
8329 (term_get_fkeys_1, append_glyphless_glyph, produce_glyphless_glyph):
8330 (turn_on_face, init_tty): Likewise.
8331 * termchar.h (struct tty_display_info): Likewise.
8333 * term.c (term_mouse_position): Rename local to avoid shadowing.
8335 * alloc.c (mark_ttys): Move decl from here ...
8336 * lisp.h (mark_ttys): ... to here, so that it's checked against defn.
8338 2011-03-11 Andreas Schwab <schwab@linux-m68k.org>
8340 * .gdbinit (pwinx, xbuffer): Fix access to buffer name.
8342 2011-03-09 Juanma Barranquero <lekktu@gmail.com>
8344 * search.c (compile_pattern_1): Remove argument regp, unused since
8345 revid:rms@gnu.org-19941211082627-3x1g1wyqkjmwloig.
8346 (compile_pattern): Don't pass it.
8348 2011-03-08 Jan Djärv <jan.h.d@swipnet.se>
8350 * xterm.h (DEFAULT_GDK_DISPLAY): New define.
8351 (GDK_WINDOW_XID, gtk_widget_get_preferred_size): New defines
8353 (GTK_WIDGET_TO_X_WIN): Use GDK_WINDOW_XID.
8355 * xmenu.c (menu_position_func): Call gtk_widget_get_preferred_size.
8357 * gtkutil.c: Include gtkx.h if HAVE_GTK3. If ! HAVE_GTK3, define
8358 gdk_window_get_screen, gdk_window_get_geometry,
8359 gdk_x11_window_lookup_for_display and GDK_KEY_g.
8360 (xg_set_screen): Use DEFAULT_GDK_DISPLAY.
8361 (xg_get_pixbuf_from_pixmap): New function.
8362 (xg_get_pixbuf_from_pix_and_mask): Change parameters from GdkPixmap
8363 to Pixmap, take frame as parameter, remove GdkColormap parameter.
8364 Call xg_get_pixbuf_from_pixmap instead of
8365 gdk_pixbuf_get_from_drawable.
8366 (xg_get_image_for_pixmap): Do not make GdkPixmaps, call
8367 xg_get_pixbuf_from_pix_and_mask with Pixmap parameters instead.
8368 (xg_check_special_colors): Use GtkStyleContext and its functions
8370 (xg_prepare_tooltip, xg_hide_tooltip): Call gdk_window_get_screen.
8371 (xg_prepare_tooltip, create_dialog, menubar_map_cb)
8372 (xg_update_frame_menubar, xg_tool_bar_detach_callback)
8373 (xg_tool_bar_attach_callback, xg_update_tool_bar_sizes):
8374 Call gtk_widget_get_preferred_size.
8375 (xg_frame_resized): gdk_window_get_geometry only takes 5
8377 (xg_win_to_widget, xg_event_is_for_menubar):
8378 Call gdk_x11_window_lookup_for_display.
8379 (xg_set_widget_bg): New function.
8380 (delete_cb): New function.
8381 (xg_create_frame_widgets): Connect delete-event to delete_cb.
8382 Call xg_set_widget_bg. Only set backgrund pixmap for ! HAVE_GTK3
8383 (xg_set_background_color): Call xg_set_widget_bg.
8384 (xg_set_frame_icon): Call xg_get_pixbuf_from_pix_and_mask.
8385 (xg_create_scroll_bar): vadj is a GtkAdjustment for HAVE_GTK3.
8386 Only call gtk_range_set_update_policy if ! HAVE_GTK3.
8387 (xg_make_tool_item): Only connect xg_tool_bar_item_expose_callback
8389 (update_frame_tool_bar): Call gtk_widget_hide.
8390 (xg_initialize): Use GDK_KEY_g.
8392 * xsmfns.c (gdk_set_sm_client_id): Define to gdk_set_sm_client_id
8394 (x_session_initialize): Call gdk_x11_set_sm_client_id.
8396 * xterm.c (XFillRectangle): Use cairo routines for HAVE_GTK3.
8397 (x_term_init): Disable Xinput(2) with GDK_CORE_DEVICE_EVENTS.
8398 Load ~/emacs.d/gtkrc only for ! HAVE_GTK3.
8400 2011-03-08 Juanma Barranquero <lekktu@gmail.com>
8402 * w32xfns.c (select_palette): Check success of RealizePalette against
8403 GDI_ERROR, not zero.
8405 See ChangeLog.11 for earlier changes.
8411 Copyright (C) 2011 Free Software Foundation, Inc.
8413 This file is part of GNU Emacs.
8415 GNU Emacs is free software: you can redistribute it and/or modify
8416 it under the terms of the GNU General Public License as published by
8417 the Free Software Foundation, either version 3 of the License, or
8418 (at your option) any later version.
8420 GNU Emacs is distributed in the hope that it will be useful,
8421 but WITHOUT ANY WARRANTY; without even the implied warranty of
8422 MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
8423 GNU General Public License for more details.
8425 You should have received a copy of the GNU General Public License
8426 along with GNU Emacs. If not, see <http://www.gnu.org/licenses/>.