1 2012-05-14 Glenn Morris <rgm@gnu.org>
3 * nsterm.m (ns_init_paths): Fix typo ("libexec" not "lib-exec").
4 Put "libexec" before "bin", for the sake of init_callproc_1.
6 2012-05-14 Paul Eggert <eggert@cs.ucla.edu>
8 * keyboard.c (kbd_buffer_get_event) [!HAVE_DBUS]: Omit unused local.
10 * unexaix.c: Port to more-recent AIX compilers.
11 (report_error, report_error_1, make_hdr, copy_sym)
12 (mark_x, adjust_lnnoptrs, unrelocate_symbols):
13 Make arguments const char *, not char *, to avoid violations of C
14 standard and to fix some AIX warnings reported by Gilles Pion.
16 2012-05-14 Eli Zaretskii <eliz@gnu.org>
18 * xdisp.c (handle_stop): Don't call get_overlay_strings_1 if we
19 already have overlays loaded.
20 (handle_single_display_spec): Before returning without displaying
21 fringe bitmap, synchronize the bidi iterator with the main display
22 iterator, by calling iterate_out_of_display_property.
23 (iterate_out_of_display_property): Detect buffer iteration by
24 testing that it->string is a Lisp string.
25 (get_next_display_element): When the current object is exhausted,
26 and there's something on it->stack, call set_iterator_to_next to
27 proceed with what's on the stack, instead of returning zero.
28 (set_iterator_to_next): If called at the end of a Lisp string,
29 proceed to consider_string_end without incrementing string
30 position. Don't increment display vector index past the end of
31 the display vector. (Bug#11417)
32 (pos_visible_p): Don't report a position visible when move_it_to
33 stopped at the last line of window, which happens to be scanned
34 backwards by the bidi iteration. (Bug#11464)
36 2012-05-14 Eli Zaretskii <eliz@gnu.org>
38 * xdisp.c (handle_single_display_spec): Return 1 for left-margin
39 and right-margin display specs even if the spec is invalid or we
40 are on a TTY, and thus unable to display on the fringes. That's
41 because the text with the property will not be displayed anyway,
42 so we need to signal to the caller that this is a "replacing"
43 display spec. This fixes display when the spec is invalid or we
46 2012-05-14 Paul Eggert <eggert@cs.ucla.edu>
48 * unexaix.c (make_hdr): Fix typo in prototype.
49 This bug broke the build on AIX. Problem reported by Gilles Pion.
51 2012-05-14 Michael Albinus <michael.albinus@gmx.de>
53 * keyboard.c (kbd_buffer_get_event): Read special events also in
54 batch mode. (Bug#11415)
56 2012-05-12 Glenn Morris <rgm@gnu.org>
58 * ns.mk: Update for ns_appbindir no longer having trailing "/".
60 2012-05-12 Eli Zaretskii <eliz@gnu.org>
62 * lisp.mk (lisp): Add newcomment.elc.
64 2012-05-12 Glenn Morris <rgm@gnu.org>
66 * Makefile.in (MKDIR_P): New, set by configure.
67 * ns.mk (${ns_appdir}, ${ns_appbindir}Emacs): Use $MKDIR_P.
69 2012-05-11 Paul Eggert <eggert@cs.ucla.edu>
71 Remove unused function hourglass_started.
72 * dispextern.h (hourglass_started):
73 * w32fns.c (hourglass_started):
74 * xdisp.c (hourglass_started): Remove.
76 2012-05-10 Juanma Barranquero <lekktu@gmail.com>
78 * makefile.w32-in ($(BLD)/gmalloc.$(O), $(BLD)/w32menu.$(O)):
81 2012-05-10 Paul Eggert <eggert@cs.ucla.edu>
83 * xgselect.c (xg_select): Put maxfds+1 into a var.
84 This is slightly clearer, and pacifies Ubuntu 12.04 gcc.
86 * sound.c (DEFAULT_ALSA_SOUND_DEVICE): Define only if HAVE_ALSA.
88 2012-05-10 Dave Abrahams <dave@boostpro.com>
90 * filelock.c (syms_of_filelock): New boolean create-lockfiles.
91 (lock_file): If create_lockfiles is 0, do nothing. (Bug#11227)
93 2012-05-09 Michael Albinus <michael.albinus@gmx.de>
95 * dbusbind.c (xd_registered_buses): New internal Lisp object.
96 Rename all occurences of Vdbus_registered_buses to xd_registered_buses.
97 (syms_of_dbusbind): Remove declaration of Vdbus_registered_buses.
98 Initialize xd_registered_buses.
100 2012-05-09 Paul Eggert <eggert@cs.ucla.edu>
102 Untag more efficiently if USE_LSB_TAG.
103 This is based on a proposal by YAMAMOTO Mitsuharu in
104 <http://lists.gnu.org/archive/html/emacs-devel/2008-01/msg01876.html>.
105 For an admittedly artificial (nth 8000 longlist) benchmark on
106 Fedora 15 x86-64, this yields a 25% CPU speedup. Also, it shrinks
107 Emacs's overall text size by 1%.
108 * lisp.h (XUNTAG): New macro.
109 (XCONS, XVECTOR, XSTRING, XSYMBOL, XFLOAT, XMISC, XPROCESS, XWINDOW)
110 (XTERMINAL, XSUBR, XBUFFER, XCHAR_TABLE, XSUB_CHAR_TABLE, XBOOL_VECTOR)
111 (XSETTYPED_PSEUDOVECTOR, XHASH_TABLE, TYPED_PSEUDOVECTORP): Use it.
112 * eval.c (Fautoload):
113 * font.h (XFONT_SPEC, XFONT_ENTITY, XFONT_OBJECT):
114 * frame.h (XFRAME): Use XUNTAG.
116 Port recent dbusbind.c changes to 32-bit --with-wide-int.
117 * dbusbind.c (xd_append_arg, xd_retrieve_arg, Fdbus_message_internal):
118 Remove unportable assumptions about print widths of types like
120 (xd_get_connection_address, Fdbus_init_bus): Cast Emacs integer to
121 intptr_t when converting between pointer and integer, to avoid GCC
122 warnings about wrong width.
124 2012-05-09 Eli Zaretskii <eliz@gnu.org>
126 * w32proc.c (new_child): Force Windows to reserve only 64KB of
127 stack for each reader_thread, instead of defaulting to 8MB
128 determined by the linker. This avoids failures in creating
129 subprocesses on Windows 7, see the discussion in this thread:
130 http://lists.gnu.org/archive/html/emacs-devel/2012-03/msg00119.html.
132 2012-05-07 Jérémy Compostella <jeremy.compostella@gmail.com>
134 Fix up display of the *Minibuf-0* buffer in the mini window.
135 * keyboard.c (read_char): Don't clear the echo area if there's no
137 * xdisp.c (redisplay_internal): Redisplay the mini window (with the
138 contents of *Minibuf-0*) if there's no message displayed in its stead.
140 2012-05-07 Michael Albinus <michael.albinus@gmx.de>
142 * dbusbind.c (XD_DEBUG_MESSAGE): Don't print message twice in
145 2012-05-06 Chong Yidong <cyd@gnu.org>
147 * lisp.mk (lisp): Update.
149 2012-05-05 Jim Meyering <meyering@redhat.com>
151 * w32font.c (fill_in_logfont): NUL-terminate a string (Bug#11372).
153 2012-05-04 Stefan Monnier <monnier@iro.umontreal.ca>
155 * data.c (PUT_ERROR): New macro.
156 (syms_of_data): Use it. Add new error type `user-error'.
157 * undo.c (user_error): New function.
158 (Fprimitive_undo): Use it.
159 * print.c (print_error_message): Adjust print style for `user-error'.
160 * keyboard.c (user_error): New function.
161 (Fexit_recursive_edit, Fabort_recursive_edit): Use it.
163 2012-05-03 Paul Eggert <eggert@cs.ucla.edu>
165 Do not limit current-time-string to years 1000..9999.
166 * editfns.c (TM_YEAR_IN_ASCTIME_RANGE): Remove.
167 (Fcurrent_time_string): Support any year that is supported by the
168 underlying localtime representation. Don't use asctime, as it
169 has undefined behavior for years outside the range -999..9999.
171 2012-05-02 Paul Eggert <eggert@cs.ucla.edu>
173 Fix race conditions involving setenv, gmtime, localtime, asctime.
174 Without this fix, interrupts could mess up code that uses these
175 nonreentrant functions, since setting TZ invalidates existing
176 tm_zone or tzname values, and since most of these functions return
177 pointers to static storage.
178 * editfns.c (format_time_string, Fdecode_time, Fencode_time)
179 (Fcurrent_time_string, Fcurrent_time_zone, Fset_time_zone_rule):
180 Grow the critical sections to include not just invoking
181 localtime/gmtime, but also accessing these functions' results
182 including their tm_zone values if any, and any related TZ setting.
183 (format_time_string): Last arg is now struct tm *, not struct tm **,
184 so that the struct tm is saved in the critical section.
185 All callers changed. Simplify allocation of initial buffer, partly
186 motivated by the fact that memory allocation needs to be outside
187 the critical section.
189 2012-05-02 Dmitry Antipov <dmantipov@yandex.ru>
191 * intervals.c (adjust_intervals_for_insertion): Initialize `newi'
194 * buffer.c (Fget_buffer_create, Fmake_indirect_buffer):
195 Remove duplicated buffer name initialization.
197 2012-05-02 Jim Meyering <jim@meyering.net>
199 * xterm.c (x_term_init): Use memcpy instead of strncpy (Bug#11373).
201 * xfns.c (x_window): Use xstrdup (Bug#11375).
203 2012-05-02 Eli Zaretskii <eliz@gnu.org>
205 * xdisp.c (pos_visible_p): If already at a newline from the
206 display string before the 'while' loop, don't walk back the glyphs
207 from it3.glyph_row. Solves assertion violation when the display
208 string begins with a newline (egg.el). (Bug#11367)
210 2012-05-01 Stefan Monnier <monnier@iro.umontreal.ca>
212 * keyboard.c (Fexecute_extended_command, Vsuggest_key_bindings):
215 2012-05-01 Glenn Morris <rgm@gnu.org>
217 * syssignal.h: Remove reference to BROKEN_SIGINFO (last used in
218 s/ptx4.h), BROKEN_SIGTSTP (last used in m/ustation.h, m/dpx2.h),
219 and BROKEN_SIGURG (was in s/gnu-linux.h prior to 2008-02-10).
220 All were removed before 23.1.
222 * dispnew.c: Remove HAVE_LIBNCURSES test;
223 it is always true on relevant platforms.
225 * Makefile.in (LD_SWITCH_X_SITE_RPATH):
226 Rename from LD_SWITCH_X_SITE_AUX_RPATH.
228 * Makefile.in (LD_SWITCH_X_SITE_AUX): Remove; no longer used.
230 2012-04-30 Andreas Schwab <schwab@linux-m68k.org>
232 * .gdbinit (xpr): Remove checks for no longer existing misc types.
233 (xintfwd, xboolfwd, xobjfwd, xbufobjfwd, xkbobjfwd, xbuflocal):
236 2012-04-28 Paul Eggert <eggert@cs.ucla.edu>
238 Do not avoid creating empty evaporating overlays (Bug#9642).
239 * buffer.c (Fmove_overlay): Revert the change of 2012-04-23.
240 That is, do not delete an evaporating overlay if it becomes
241 empty after its bounds are adjusted to fit within its buffer.
242 This fix caused other problems, and I'm reverting it until we get
243 to the bottom of them.
245 2012-04-27 Chong Yidong <cyd@gnu.org>
247 * xselect.c (x_convert_selection): Initialize a pointer (Bug#11315).
249 2012-04-27 Eli Zaretskii <eliz@gnu.org>
251 * xdisp.c (pos_visible_p): If the window start position is beyond
252 ZV, start the display from buffer beginning. Prevents assertion
253 violation in init_iterator when the minibuffer window is scrolled
256 * window.c (window_scroll_pixel_based): Likewise.
258 2012-04-27 Chong Yidong <cyd@gnu.org>
260 * keymap.c (where_is_internal): Doc fix (Bug#10872).
262 2012-04-27 Glenn Morris <rgm@gnu.org>
264 * fileio.c (Fcopy_file, Fset_file_selinux_context):
265 Ignore ENOTSUP failures from setfilecon functions. (Bug#11245)
267 2012-04-27 Eli Zaretskii <eliz@gnu.org>
269 * dispnew.c (swap_glyph_pointers, copy_row_except_pointers):
270 Don't overrun array limits of glyph row's used[] array. (Bug#11288)
272 2012-04-26 Eli Zaretskii <eliz@gnu.org>
274 * xdisp.c (IT_DISPLAYING_WHITESPACE): In addition to the loaded
275 display element, check also the underlying string or buffer
276 character. (Bug#11341)
278 * w32menu.c: Include w32heap.h.
279 (add_menu_item): If the call to AppendMenuW (via
280 unicode_append_menu) fails, disable Unicode menus only if we are
281 running on Windows 9X/Me.
283 2012-04-24 Andreas Schwab <schwab@linux-m68k.org>
285 * .gdbinit (xpr): Handle USE_2_TAGS_FOR_INTS.
286 (xgetint): Add missing shift for LSB tags.
288 2012-04-24 Martin Rudalics <rudalics@gmx.at>
290 * keyboard.c (read_char): Don't wipe echo area for select window
291 events: These might get delayed via `mouse-autoselect-window'
294 2012-04-24 Juanma Barranquero <lekktu@gmail.com>
296 * gnutls.c (init_gnutls_functions): Protect against (unlikely)
297 manipulation of :loaded-from data.
299 2012-04-23 Juanma Barranquero <lekktu@gmail.com>
301 * gnutls.c (init_gnutls_functions): The value of :loaded-from is
302 now a cons (bug#11311).
304 2012-04-23 Paul Eggert <eggert@cs.ucla.edu>
306 Do not create empty overlays with the evaporate property (Bug#9642).
307 * buffer.c (Fmove_overlay): Delete an evaporating overlay
308 if it becomes empty after its bounds are adjusted to fit within
309 its buffer. Without this fix, in a nonempty buffer (let ((o
310 (make-overlay 1 2))) (overlay-put o 'evaporate t) (move-overlay o 0 1))
311 yields an empty overlay that has the evaporate property, which is
312 not supposed to happen.
314 Fix minor GTK3 problems found by static checking.
315 * emacsgtkfixed.c (EMACS_TYPE_FIXED, EMACS_FIXED, EmacsFixed)
316 (EmacsFixedPrivate, EmacsFixedClass, struct _EmacsFixed)
317 (struct _EmacsFixedClass, emacs_fixed_get_type):
318 Move decls here from emacsgtkfixed.h, since they needn't be public.
319 (emacs_fixed_get_type): Now static.
320 (emacs_fixed_class_init): Omit unused local.
321 (emacs_fixed_child_type): Remove; unused.
322 * emacsgtkfixed.h (EMACS_TYPE_FIXED, EMACS_FIXED, EmacsFixed)
323 (EmacsFixedPrivate, EmacsFixedClass, struct _EmacsFixed)
324 (struct _EmacsFixedClass): Move to emacsgtkfixed.c.
325 (EMACS_FIXED_CLASS, EMACS_IS_FIXED, EMACS_IS_FIXED_CLASS)
326 (EMACS_FIXED_GET_CLASS): Remove; unused.
327 * gtkutil.c (xg_create_frame_widgets) [!HAVE_GTK3]: Omit unused local.
329 * keyboard.c (handle_async_input): Define only if SYNC_INPUT || SIGIO.
330 Problem reported by Juanma Barranquero for Windows -Wunused-function.
332 2012-04-22 Paul Eggert <eggert@cs.ucla.edu>
334 Modernize and clean up gmalloc.c to assume C89 (Bug#9119).
335 * gmalloc.c: (_MALLOC_INTERNAL, _MALLOC_H, _PP, __ptr_t)
336 (__malloc_size_t, __malloc_ptrdiff_t):
337 Remove. All uses removed, replaced by the definiens if needed,
338 since we can assume C89 or better now.
339 Include <stdint.h>, for PTRDIFF_MAX, uintptr_t.
340 (protect_malloc_state, align, get_contiguous_space)
341 (malloc_atfork_handler_prepare, malloc_atfork_handler_parent)
342 (malloc_atfork_handler_child, malloc_enable_thread)
343 (malloc_initialize_1, __malloc_initialize, morecore_nolock)
344 (_malloc_internal_nolock, _malloc_internal, malloc, _malloc)
345 (_free, _realloc, _free_internal_nolock, _free_internal, free, cfree)
346 (special_realloc, _realloc_internal_nolock, _realloc_internal)
347 (realloc, calloc, __default_morecore, memalign, valloc, checkhdr)
348 (freehook, mallochook, reallochook, mabort, mcheck, mprobe):
349 Define using prototypes, not old style.
350 (align, _malloc_internal_nolock, _free_internal_nolock, memalign):
351 Don't assume ptrdiff_t and uintptr_t are no wider than unsigned long.
352 (align): Don't assume that signed integer overflow wraps around.
353 Omit unused local var.
354 (malloc_initialize_1, morecore_nolock, _malloc_internal_nolock)
355 (_free_internal_nolock, memalign, mallochook, reallochook):
356 Omit no-longer-needed casts.
357 (valloc): Use getpagesize, not __getpagesize.
358 (MAGICWORD, MAGICFREE): Now randomish size_t values, not 32-bit.
359 (struct hdr): The 'magic' member is now size_t, not unsigned long.
361 * dbusbind.c (XD_DBUS_VALIDATE_OBJECT): Define only if needed.
363 2012-04-22 Michael Albinus <michael.albinus@gmx.de>
365 Move functions from C to Lisp. Make non-blocking method calls
366 the default. Implement further D-Bus standard interfaces.
368 * dbusbind.c (DBUS_NUM_MESSAGE_TYPES): Declare.
369 (QCdbus_request_name_allow_replacement)
370 (QCdbus_request_name_replace_existing)
371 (QCdbus_request_name_do_not_queue)
372 (QCdbus_request_name_reply_primary_owner)
373 (QCdbus_request_name_reply_in_queue)
374 (QCdbus_request_name_reply_exists)
375 (QCdbus_request_name_reply_already_owner): Move to dbus.el.
376 (QCdbus_registered_serial, QCdbus_registered_method)
377 (QCdbus_registered_signal): New Lisp objects.
378 (XD_DEBUG_MESSAGE): Use sizeof.
379 (XD_MESSAGE_TYPE_TO_STRING, XD_OBJECT_TO_STRING)
380 (XD_DBUS_VALIDATE_BUS_ADDRESS, XD_DBUS_VALIDATE_OBJECT)
381 (XD_DBUS_VALIDATE_BUS_NAME, XD_DBUS_VALIDATE_PATH)
382 (XD_DBUS_VALIDATE_INTERFACE, XD_DBUS_VALIDATE_MEMBER): New macros.
383 (XD_CHECK_DBUS_SERIAL): Rename from CHECK_DBUS_SERIAL_GET_SERIAL.
384 (xd_signature, xd_append_arg): Allow float for integer types.
385 (xd_get_connection_references): New function.
386 (xd_get_connection_address): Rename from xd_initialize.
387 Return cached address.
388 (xd_remove_watch): Do not unset $DBUS_SESSION_BUS_ADDRESS.
389 (xd_close_bus): Rename from Fdbus_close_bus. Not needed on Lisp
391 (Fdbus_init_bus): New optional arg PRIVATE. Cache address.
392 Return number of refcounts.
393 (Fdbus_get_unique_name): Make stronger parameter check.
394 (Fdbus_message_internal): New defun.
395 (Fdbus_call_method, Fdbus_call_method_asynchronously)
396 (Fdbus_method_return_internal, Fdbus_method_error_internal)
397 (Fdbus_send_signal, Fdbus_register_service)
398 (Fdbus_register_signal, Fdbus_register_method): Move to dbus.el.
399 (xd_read_message_1): Obey new structure of Vdbus_registered_objects.
400 (xd_read_queued_messages): Obey new structure of Vdbus_registered_buses.
401 (Vdbus_compiled_version, Vdbus_runtime_version)
402 (Vdbus_message_type_invalid, Vdbus_message_type_method_call)
403 (Vdbus_message_type_method_return, Vdbus_message_type_error)
404 (Vdbus_message_type_signal): New defvars.
405 (Vdbus_registered_buses, Vdbus_registered_objects_table):
408 2012-04-22 Paul Eggert <eggert@cs.ucla.edu>
410 Fix GC_MALLOC_CHECK debugging output on 64-bit hosts.
411 * alloc.c (emacs_blocked_malloc) [GC_MALLOC_CHECK]:
412 Do not assume ptrdiff_t is the same width as 'int'.
414 * alloc.c: Handle unusual debugging option combinations.
415 (GC_CHECK_MARKED_OBJECTS): Undef if ! GC_MARK_STACK,
416 since the two debugging options are incompatible.
417 (GC_MALLOC_CHECK): Similarly, undef if GC_CHECK_MARKED_OBJECTS
419 (mem_init, mem_insert, mem_insert_fixup):
420 Define if GC_MARK_STACK || GC_MALLOC_CHECK.
421 (NEED_MEM_INSERT): Remove; no longer needed.
423 2012-04-22 Leo Liu <sdl.web@gmail.com>
425 * sysdep.c (list_system_processes): Support Darwin (Bug#5725).
427 2012-04-22 Paul Eggert <eggert@cs.ucla.edu>
429 * sysdep.c [__FreeBSD__]: Minor cleanups.
430 (list_system_processes, system_process_attributes) [__FreeBSD__]:
431 Use Emacs indenting style more consistently. Avoid some casts.
432 Use 'double' consistently rather than mixing 'float' and 'double'.
434 2012-04-21 Eduard Wiebe <usenet@pusto.de>
436 * sysdep.c (list_system_processes, system_process_attributes):
437 Add implementation for FreeBSD (Bug#5243).
439 2012-04-21 Andreas Schwab <schwab@linux-m68k.org>
441 * lisp.mk (lisp): Update.
443 2012-04-20 Paul Eggert <eggert@cs.ucla.edu>
445 * keyboard.c (process_pending_signals): Define only if SYNC_INPUT.
446 It is never used otherwise.
448 2012-04-20 Stefan Monnier <monnier@iro.umontreal.ca>
450 * print.c (print_preprocess): Only check print_depth if print-circle
452 (print_object): Check for cycles even when print-circle is nil and
453 print-gensym is t, but only check print_depth if print-circle is nil.
455 2012-04-20 Chong Yidong <cyd@gnu.org>
457 * process.c (wait_reading_process_output): If EIO occurs on a pty,
458 set the status to "failed" and ensure that sentinel is run.
460 2012-04-20 Glenn Morris <rgm@gnu.org>
462 * process.c (Fset_process_inherit_coding_system_flag)
463 (Fset_process_query_on_exit_flag): Doc fix (mention return value).
464 (Fmake_network_process, Fmake_serial_process): Doc fix.
466 2012-04-20 Eli Zaretskii <eliz@gnu.org>
468 * xdisp.c (string_buffer_position_lim): Limit starting position to
470 (set_cursor_from_row): If called for a mode-line or header-line
471 row, return zero immediately.
472 (try_cursor_movement): If inside continuation line, don't back up
473 farther than the first row after the header line, if any.
474 Don't consider the header-line row as "partially visible", even if
475 MATRIX_ROW_PARTIALLY_VISIBLE_P returns non-zero. (Bug#11261)
477 2012-04-20 Atsuo Ohki <ohki@gssm.otsuka.tsukuba.ac.jp> (tiny change)
479 * lread.c (lisp_file_lexically_bound_p): Fix hang at ";-*-\n"
482 2012-04-20 Teodor Zlatanov <tzz@lifelogs.com>
483 2012-04-18 Paul Eggert <eggert@cs.ucla.edu>
485 configure: new option --enable-gcc-warnings (Bug#11207)
486 * Makefile.in (C_WARNINGS_SWITCH): Remove.
487 (WARN_CFLAGS, WERROR_CFLAGS): New macros.
488 (ALL_CFLAGS): Use new macros rather than old.
489 * process.c: Ignore -Wstrict-overflow to work around GCC bug 52904.
490 * regex.c: Ignore -Wstrict-overflow. If !emacs, also ignore
491 -Wunused-but-set-variable, -Wunused-function, -Wunused-macros,
492 -Wunused-result, -Wunused-variable. This should go away once
493 the Emacs and Gnulib regex code is merged.
494 (xmalloc, xrealloc): Now static.
496 2012-04-17 Paul Eggert <eggert@cs.ucla.edu>
498 * dired.c (Fsystem_groups): Remove unused local.
500 2012-04-17 Glenn Morris <rgm@gnu.org>
502 * dired.c (Fsystem_users): Doc fix.
504 2012-04-17 Dmitry Antipov <dmantipov@yandex.ru>
506 * dired.c (Fsystem_users, Fsystem_groups): New functions. (Bug#7900)
507 (syms_of_dired): Add them.
509 2012-04-16 Paul Eggert <eggert@cs.ucla.edu>
511 Fix minor alloc.c problems found by static checking.
512 * alloc.c (_malloc_internal, _free_internal) [!DOUG_LEA_MALLOC]:
513 New extern decls, to avoid calling undeclared functions.
514 (dont_register_blocks): Define if ((!SYSTEM_MALLOC && !SYNC_INPUT)
515 && GC_MALLOC_CHECK), not if ((GC_MARK_STACK || defined
516 GC_MALLOC_CHECK) && GC_MALLOC_CHECK), to match when it's used.
517 (NEED_MEM_INSERT): New macro.
518 (mem_insert, mem_insert_fixup) [!NEED_MEM_INSERT]: Remove; unused.
519 Remove one incorrect comment and fix another.
521 Fix minor ralloc.c problems found by static checking.
522 See http://lists.gnu.org/archive/html/emacs-devel/2011-12/msg00720.html
523 * ralloc.c (ALIGNED, ROUND_TO_PAGE, HEAP_PTR_SIZE)
524 (r_alloc_size_in_use, r_alloc_freeze, r_alloc_thaw): Remove; unused.
525 (r_alloc_sbrk): Now static.
527 Improve ralloc.c interface checking.
528 See http://lists.gnu.org/archive/html/emacs-devel/2011-12/msg00720.html
529 * buffer.c (ralloc_reset_variable, r_alloc, r_re_alloc)
530 (r_alloc_free) [REL_ALLOC]: Move decls from here ...
531 * lisp.h (r_alloc, r_alloc_free, r_re_alloc, r_alloc_reset_variable)
532 [REL_ALLOC]: ... to here, to check interface.
533 * m/ia64.h (r_alloc, r_alloc_free) [REL_ALLOC && !_MALLOC_INTERNAL]:
534 Remove decls. This fixes an "It stinks!".
536 * alloc.c (which_symbols): Fix alignment issue / type clash.
538 2012-04-15 Andreas Schwab <schwab@linux-m68k.org>
540 * lisp.h (struct Lisp_Symbol): Remove explicit padding.
541 (struct Lisp_Misc_Any): Likewise.
542 (struct Lisp_Free): Likewise.
543 * alloc.c (union aligned_Lisp_Symbol): Define.
544 (SYMBOL_BLOCK_SIZE, struct symbol_block): Use union
545 aligned_Lisp_Symbol instead of struct Lisp_Symbol.
546 (union aligned_Lisp_Misc): Define.
547 (MARKER_BLOCK_SIZE, struct marker_block): Use union
548 aligned_Lisp_Misc instead of union Lisp_Misc.
549 (Fmake_symbol, allocate_misc, gc_sweep): Adjust.
551 2012-04-14 Paul Eggert <eggert@cs.ucla.edu>
553 Make GC_MAKE_GCPROS_NOOPS the default (Bug#9926).
554 * lisp.h (GC_MARK_STACK): Default to GC_MAKE_GCPROS_NOOPS.
555 * s/cygwin.h, s/darwin.h, s/freebsd.h, s/gnu.h, s/irix6-5.h, s/msdos.h:
556 * s/netbsd.h, s/sol2-6.h:
557 Remove definition of GC_MARK_STACK, since the default now works.
558 * s/aix4-2.h, s/hpux10-20.h, s/unixware.h:
559 Define GC_MARK_STACK to GC_USE_GCPROS_AS_BEFORE, since that's
560 no longer the default.
561 * s/gnu-linux.h (GC_MARK_STACK): Adjust to change in default.
563 2012-04-14 Atsuo Ohki <ohki@gssm.otsuka.tsukuba.ac.jp> (tiny change)
565 * lread.c (lisp_file_lexically_bound_p):
566 Fix hang at ";-*-\n" (bug#11238).
568 2012-04-14 Eli Zaretskii <eliz@gnu.org>
570 * xdisp.c (find_last_unchanged_at_beg_row): Don't consider a row
571 "unchanged" if its end.pos is beyond ZV. (Bug#11199)
573 2012-04-14 Jan Djärv <jan.h.d@swipnet.se>
575 * nsterm.m (constrainFrameRect): Always constrain when there is only
576 one screen (Bug#10962).
578 2012-04-13 Ken Brown <kbrown@cornell.edu>
580 * s/cygwin.h (PTY_OPEN): Don't try to close a bogus file descriptor.
582 2012-04-13 Reuben Thomas <rrt@sc3d.org>
584 * indent.c (Fmove_to_column): Change interactive spec (Bug#739).
586 2012-04-11 Daniel Colascione <dancol@dancol.org>
588 * s/cygwin.h: The vfork the #define in cygwin.h was protecting
589 against is gone. It's better to use vfork now so that when Cygwin
590 gains a new, working vfork, we use it automatically (bug#10398).
592 2012-04-11 Stefan Monnier <monnier@iro.umontreal.ca>
594 * window.c (save_window_save): Obey window-point-insertion-type.
596 2012-04-11 Glenn Morris <rgm@gnu.org>
598 * Makefile.in (GNUSTEP_CFLAGS): Rename from C_SWITCH_X_SYSTEM.
600 2012-04-11 Stefan Monnier <monnier@iro.umontreal.ca>
602 * alloc.c (lisp_align_malloc): Remove unneeded prototype.
604 2012-04-10 Jason S. Cornez <jcornez@ravenpack.com> (tiny change)
606 * keyboard.c: Override inhibit-quit after the third C-g (bug#6585).
607 (force_quit_count): New var.
608 (handle_interrupt): Use it.
610 2012-04-10 Juanma Barranquero <lekktu@gmail.com>
612 * w32.c (w32_delayed_load): Record the full path of the library
613 being loaded (bug#10424).
615 2012-04-09 Glenn Morris <rgm@gnu.org>
617 * doc.c (Fsnarf_documentation): Check variables, functions are bound,
618 not just in the obarray, before snarfing them. (Bug#11036)
620 * Makefile.in ($(leimdir)/leim-list.el):
621 Pass EMACS rather than BUILT_EMACS.
623 2012-04-09 Teodor Zlatanov <tzz@lifelogs.com>
625 * process.c (make_process):
626 * process.h: Add integer `gnutls_handshakes_tried' member to
629 * gnutls.h: Add `GNUTLS_EMACS_HANDSHAKES_LIMIT' upper limit.
630 Add convenience `GNUTLS_LOG2i' macro.
632 * gnutls.c (gnutls_log_function2i): Convenience log function.
633 (emacs_gnutls_read): Use new log functions,
634 `gnutls_handshakes_tried' process member, and
635 `GNUTLS_EMACS_HANDSHAKES_LIMIT' to limit the number of handshake
636 attempts per process (connection).
638 2012-04-09 Chong Yidong <cyd@gnu.org>
640 * eval.c (Fuser_variable_p, user_variable_p_eh)
641 (lisp_indirect_variable): Functions deleted.
642 (Fdefvar): Caller changed.
644 * callint.c (Finteractive, Fcall_interactively):
645 * minibuf.c (Fread_variable): Callers changed.
647 2012-04-09 Eli Zaretskii <eliz@gnu.org>
649 * xdisp.c (set_cursor_from_row): If the display string appears in
650 the buffer at position that is closer to point than the position
651 after the display string, display the cursor on the first glyph of
652 the display string. Fixes cursor display when a 'display' text
653 property immediately follows invisible text. (Bug#11094)
655 2012-04-09 Paul Eggert <eggert@cs.ucla.edu>
657 composite.c: use 'double' consistently
658 * composite.c (get_composition_id): Use 'double' consistently
659 instead of converting 'float' to 'double' and vice versa; this is
660 easier to understand and avoids a GCC warning.
662 2012-04-09 Glenn Morris <rgm@gnu.org>
664 * Makefile.in: Generate leim-list with bootstrap-emacs, in
665 preparation for dumping it with emacs. (Bug#4789)
666 (leimdir): New variable.
667 ($(leimdir)/leim-list.el): New rule.
668 (emacs$(EXEEXT)): Depend on leim-list.el.
670 * buffer.c (Qucs_set_table_for_input): Remove. (Bug#9821)
671 (Fget_buffer_create): Don't call Qucs_set_table_for_input.
672 (init_buffer_once, syms_of_buffer): Remove Qucs_set_table_for_input.
674 2012-04-08 Andreas Schwab <schwab@linux-m68k.org>
676 * lisp.h (struct Lisp_Symbol): Add explicit padding to ensure
679 2012-04-07 Juanma Barranquero <lekktu@gmail.com>
681 * xml.c (init_libxml2_functions) [WINDOWSNT]:
682 Remove unused local variable.
684 2012-04-07 Paul Eggert <eggert@cs.ucla.edu>
686 Avoid unnecessary pointer scanning in garbage collection (Bug#10780).
687 * alloc.c (POINTERS_MIGHT_HIDE_IN_OBJECTS): New macro.
688 (mark_memory): Mark Lisp_Objects only if pointers might hide in
689 objects, as mark_maybe_pointer will catch them otherwise.
690 (GC_LISP_OBJECT_ALIGNMENT): Remove; no longer needed.
691 * s/gnu-linux.h (GC_LISP_OBJECT_ALIGNMENT) [__mc68000__]: Likewise.
693 2012-04-07 Paul Eggert <eggert@cs.ucla.edu>
695 Fix typo that broke non-Windows builds.
696 * xml.c (libxml2_loaded_p) [!!WINDOWSNT]: 'inine' -> 'inline'.
698 2012-04-07 Eli Zaretskii <eliz@gnu.org>
700 Support building on MS-Windows with libxml2.
702 * makefile.w32-in (OBJ2): Add xml.$(O).
703 (GLOBAL_SOURCES): Add xml.c.
704 ($(BLD)/xml.$(O)): New dependency list.
706 * xml.c (DEF_XML2_FN, LOAD_XML2_FN) [WINDOWSNT]: New macros.
707 (fn_htmlReadMemory, fn_xmlReadMemory, fn_xmlDocGetRootElement)
708 (fn_xmlFreeDoc, fn_xmlCleanupParser, fn_xmlCheckVersion)
709 [!WINDOWSNT]: New macros.
710 (init_libxml2_functions, libxml2_loaded_p): New functions.
711 (parse_region): Call fn_xmlCheckVersion instead of using the macro
712 LIBXML_TEST_VERSION. Call libxml2 functions via the fn_* macros.
713 (xml_cleanup_parser): New function, export for fn_xmlCleanupParser.
714 Calls xmlCleanupParser only if libxml2 was loaded (or statically
716 (Flibxml_parse_html_region, Flibxml_parse_xml_region):
717 Call init_libxml2_functions before calling libxml2 functions.
718 (syms_of_xml) <Qlibxml2_dll>: DEFSYM it.
720 * emacs.c: Don't include libxml/parser.h.
721 (shut_down_emacs): Call xml_cleanup_parser, instead of calling
722 xmlCleanupParser directly.
724 * lisp.h [HAVE_LIBXML2]: Add prototype for xml_cleanup_parser.
726 2012-04-07 Eli Zaretskii <eliz@gnu.org>
728 * indent.c (Fvertical_motion): If there is a display string at
729 point, use it.vpos to compute how many lines to backtrack after
730 move_it_to point. (Bug#11133)
732 2012-04-06 Eli Zaretskii <eliz@gnu.org>
734 * buffer.h (FETCH_CHAR, FETCH_MULTIBYTE_CHAR):
735 * character.h (STRING_CHAR, STRING_CHAR_AND_LENGTH): Add comments
736 about subtle differences between FETCH_CHAR* and STRING_CHAR*
737 macros related to unification of CJK characters. For the details,
738 see the discussion following the message here:
739 http://debbugs.gnu.org/cgi/bugreport.cgi?bug=11073#14.
741 2012-04-04 Chong Yidong <cyd@gnu.org>
743 * keyboard.c (Vdelayed_warnings_list): Doc fix.
745 2012-04-01 Eli Zaretskii <eliz@gnu.org>
747 * w32menu.c (simple_dialog_show, add_menu_item): Use SAFE_ALLOCA
748 instead of alloca. (Bug#11138)
750 2012-04-01 Andreas Schwab <schwab@linux-m68k.org>
752 * w32menu.c (is_simple_dialog): Properly check lisp types.
755 2012-03-31 Eli Zaretskii <eliz@gnu.org>
757 * xdisp.c (move_it_by_lines): When DVPOS is positive, and the
758 position we get to after a call to move_it_to fails the
759 IS_POS_VALID_AFTER_MOVE_P test, move to the next buffer position
760 only if we wind up in a string from display property. (Bug#11063)
762 * window.c (Fdelete_other_windows_internal): Invalidate the row
763 and column information about mouse highlight, so that redisplay
764 restores it after reallocating the glyph matrices. (Bug#7464)
766 * xdisp.c (set_cursor_from_row): If `cursor' property on a display
767 string comes from a `display' text property, use the buffer
768 position of that property as if we actually saw that position in
770 (move_it_by_lines): Remove the assertion that
771 "it->current_x == 0 && it->hpos == 0" which can be legitimately
772 violated when there's a before-string at the beginning of a line.
775 2012-03-30 Eli Zaretskii <eliz@gnu.org>
777 * xdisp.c (append_space_for_newline): If the default face was
778 remapped, use the remapped face for the appended newline.
779 (extend_face_to_end_of_line): Use the remapped default face for
780 extending the face to the end of the line.
781 (display_line): Call extend_face_to_end_of_line when the default
782 face was remapped. (Bug#11068)
784 2012-03-29 Eli Zaretskii <eliz@gnu.org>
786 * s/ms-w32.h: Discourage from defining HAVE_GETCWD.
788 2012-03-28 Stefan Monnier <monnier@iro.umontreal.ca>
790 * keyboard.c (safe_run_hooks_error): Don't unquote strings.
792 2012-03-27 Glenn Morris <rgm@gnu.org>
794 * search.c (Fword_search_backward_lax, Fword_search_forward_lax):
797 2012-03-26 Kenichi Handa <handa@m17n.org>
799 * dispextern.h (struct glyph): Fix previous change. Change the
800 bit length of glyphless.ch to 25 (Bug#11082).
802 2012-03-26 Chong Yidong <cyd@gnu.org>
804 * keyboard.c (Vselection_inhibit_update_commands): New variable.
805 (command_loop_1): Use it; inhibit selection update for
806 handle-select-window too (Bug#8996).
808 2012-03-25 Fabrice Popineau <fabrice.popineau@supelec.fr>
810 * w32heap.c (_heap_init, _heap_term): Remove dead MSVC-specific code.
812 2012-03-25 Kenichi Handa <handa@m17n.org>
814 * dispextern.h (struct glyph): Change the bit length of
815 glyphless.ch to 22 to make the member glyphless fit in 32 bits.
817 2012-03-24 Eli Zaretskii <eliz@gnu.org>
819 * s/ms-w32.h (tzname): Include time.h before redirecting to
820 _tzname. Fixes the MSVC build. (Bug#9960)
822 2012-03-24 Andreas Schwab <schwab@linux-m68k.org>
824 * xdisp.c (produce_glyphless_glyph): Limit length of acronym to 6
827 * xterm.c (XTread_socket): Only modify handling_signal if
828 !SYNC_INPUT. (Bug#11080)
830 2012-03-23 Eli Zaretskii <eliz@gnu.org>
832 * bidi.c (bidi_fetch_char): Use STRING_CHAR_AND_LENGTH instead of
833 FETCH_MULTIBYTE_CHAR followed by CHAR_BYTES. Prevents crashes
834 when fetching a multibyte character consumes more bytes than
835 CHAR_BYTES returns, due to unification of CJK characters in
836 string_char. (Bug#11073)
838 2012-03-23 Troels Nielsen <bn.troels@gmail.com> (tiny change)
840 * process.c (wait_reading_process_output): Handle pty disconnect
841 by refraining from sending oneself a SIGCHLD (bug#10933).
843 2012-03-22 Chong Yidong <cyd@gnu.org>
845 * dispextern.h (struct it): New member string_from_prefix_prop_p.
847 * xdisp.c (push_prefix_prop): Rename from push_display_prop.
848 Mark string as coming from a prefix property.
849 (handle_face_prop): Use default face for prefix strings (Bug#4281).
850 (pop_it, reseat_1): Save and restore string_from_prefix_prop_p.
852 2012-03-21 Chong Yidong <cyd@gnu.org>
854 * xfaces.c (Vface_remapping_alist): Doc fix.
856 2012-03-20 Eli Zaretskii <eliz@gnu.org>
858 * w32proc.c (Fw32_set_console_codepage)
859 (Fw32_set_console_output_codepage, Fw32_get_codepage_charset):
862 2012-03-20 Chong Yidong <cyd@gnu.org>
864 * dispnew.c (Fredisplay, Vredisplay_preemption_period): Update doc
865 to reflect default non-nil value of redisplay-dont-pause.
867 2012-03-19 Kenichi Handa <handa@m17n.org>
869 * ftfont.c (ftfont_drive_otf): Mask bits of character code to make
870 it fit in a valid range (Bug#11003).
872 2012-03-18 Eli Zaretskii <eliz@gnu.org>
874 * xdisp.c (cursor_row_p): Even if the glyph row ends in a string
875 that is not from display property, accept the row as a "cursor
876 row" if one of the string's character has a non-nil `cursor'
877 property. Fixes cursor positioning when there are newlines in
878 overlay strings, e.g. in icomplete.el. (Bug#11035)
880 2012-03-12 Paul Eggert <eggert@cs.ucla.edu>
882 * buffer.c (compare_overlays): Don't assume args differ (Bug#6830).
884 2012-03-12 Chong Yidong <cyd@gnu.org>
886 * eval.c (inhibit_lisp_code): Rename from
887 inhibit_window_configuration_change_hook; move from window.c.
889 * xfns.c (unwind_create_frame_1, Fx_create_frame):
890 * window.c (run_window_configuration_change_hook)
891 (syms_of_window): Callers changed.
893 2012-03-11 Chong Yidong <cyd@gnu.org>
895 * keymap.c (Fkey_description): Doc fix (Bug#9700).
897 * editfns.c (Fconstrain_to_field): Doc fix (Bug#9452).
899 2012-03-10 Chong Yidong <cyd@gnu.org>
901 * frame.c (other_visible_frames): Don't assume the selected frame
902 is visible (Bug#10955).
904 2012-03-09 Stefan Monnier <monnier@iro.umontreal.ca>
906 * buffer.c (compare_overlays): Avoid qsort's instability (bug#6830).
908 2012-03-08 Jan Djärv <jan.h.d@swipnet.se>
910 * gtkutil.c (x_wm_set_size_hint): Use one row in call to
911 FRAME_TEXT_LINES_TO_PIXEL_HEIGHT so base_height is greater than
914 2012-03-03 Glenn Morris <rgm@gnu.org>
916 * alloc.c (Fgarbage_collect, misc-objects-consed): Doc fixes.
918 2012-03-02 Eli Zaretskii <eliz@gnu.org>
920 * xdisp.c (try_window_reusing_current_matrix): Don't move cursor
921 position past the first glyph_row that ends at ZV. (Bug#10902)
922 (redisplay_window, next_element_from_string): Fix typos in
924 (redisplay_window): Pass to move_it_vertically the margin in
925 pixels, not in screen lines.
927 2012-03-02 Glenn Morris <rgm@gnu.org>
929 * buffer.c (buffer-list-update-hook): Doc fix.
931 2012-02-29 Eli Zaretskii <eliz@gnu.org>
933 * xdisp.c (get_overlay_strings_1): Under bidi redisplay, call
934 push_it before setting up the iterator for the first overlay
935 string, even if we have an empty string loaded.
936 (next_overlay_string): If there's an empty string on the iterator
937 stack, pop the stack. (Bug#10903)
939 2012-02-25 Paul Eggert <eggert@cs.ucla.edu>
941 Generalize fix for crash due to non-contiguous EMACS_INT (Bug#10780).
942 Suggested by Stefan Monnier in
943 <http://lists.gnu.org/archive/html/emacs-devel/2012-02/msg00692.html>.
944 * alloc.c (widen_to_Lisp_Object): New static function.
945 (mark_memory): Also mark Lisp_Objects by fetching pointer words
946 and widening them to Lisp_Objects. This would work even if
947 USE_LSB_TAG is defined and wide integers are used, which might
948 happen in a future version of Emacs.
950 2012-02-25 Chong Yidong <cyd@gnu.org>
952 * fileio.c (Ffile_selinux_context, Fset_file_selinux_context):
955 * xselect.c (Fx_selection_exists_p): Doc fix.
956 (x_clipboard_manager_save_all): Print an informative message
957 before saving to clipboard manager.
959 2012-02-24 Chong Yidong <cyd@gnu.org>
961 * keyboard.c (process_special_events): Handle all X selection
962 requests in kbd_buffer, not just the next one (Bug#8869).
964 2012-02-23 Chong Yidong <cyd@gnu.org>
966 * xfns.c (Fx_create_frame): Avoid window-configuration-change-hook
967 call when setting menu-bar-lines and tool-bar-lines parameters.
968 (unwind_create_frame_1): New helper function.
970 * window.c (inhibit_window_configuration_change_hook): New var.
971 (run_window_configuration_change_hook): Obey it.
972 (syms_of_window): Initialize it.
974 2012-02-22 Chong Yidong <cyd@gnu.org>
976 * xterm.c (x_draw_image_relief): Add missing type check for
977 Vtool_bar_button_margin (Bug#10743).
979 2012-02-21 Chong Yidong <cyd@gnu.org>
981 * fileio.c (Vfile_name_handler_alist): Doc fix.
983 * buffer.c (Fget_file_buffer): Protect against invalid file
984 handler return value.
986 2012-02-20 Paul Eggert <eggert@cs.ucla.edu>
988 * .gdbinit (xreload): Don't assume EMACS_INT fits in 'long'
989 when computing $valmask.
991 Fix crash due to non-contiguous EMACS_INT (Bug#10780).
992 * lisp.h (VALBITS): Move definition up, so that USE_LSB_TAG can use it.
993 (USE_LSB_TAG): Do not define if UINTPTR_MAX >> VALBITS == 0.
994 It's useless in that case, and it can cause problems on hosts
995 that allocate halves of EMACS_INT values separately.
996 Reported by Dan Horák. Diagnosed by Andreas Schwab in
997 <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=10780#30>.
998 * mem-limits.h (EXCEEDS_LISP_PTR): Define to 0 on hosts where
999 UINTPTR_MAX >> VALBITS == 0. This is required by the above change;
1000 it avoids undefined behavior on hosts where shifting right by more
1001 than the word width has undefined behavior.
1003 2012-02-19 Chong Yidong <cyd@gnu.org>
1005 * fileio.c (Ffile_name_directory, Ffile_name_nondirectory)
1006 (Funhandled_file_name_directory, Ffile_name_as_directory)
1007 (Fdirectory_file_name, Fexpand_file_name)
1008 (Fsubstitute_in_file_name): Protect against invalid file handler
1009 return values (Bug#10845).
1011 2012-02-18 Eli Zaretskii <eliz@gnu.org>
1013 * .gdbinit (pitx): Fix incorrect references to fields of the
1016 2012-02-17 Chong Yidong <cyd@gnu.org>
1018 * syntax.c (Fscan_lists): Doc fix (Bug#10833).
1020 2012-02-15 Paul Eggert <eggert@cs.ucla.edu>
1022 * image.c (MAX_IMAGE_SIZE): Increase from 6.0 to 10.0; see
1023 <http://lists.gnu.org/archive/html/emacs-devel/2012-02/msg00540.html>.
1025 2012-02-15 Chong Yidong <cyd@gnu.org>
1027 * eval.c (Fdefvar, Fdefconst): Doc fix; note that the variable is
1028 marked as special. Also, starting docstrings with * is obsolete.
1030 2012-02-13 Andreas Schwab <schwab@linux-m68k.org>
1032 * gnutls.c (emacs_gnutls_write): Fix last change.
1034 2012-02-13 Lars Ingebrigtsen <larsi@gnus.org>
1036 * gnutls.c (emacs_gnutls_write): Set errno appropriately for
1039 2012-02-13 Stefan Monnier <monnier@iro.umontreal.ca>
1041 * keymap.c (Fsingle_key_description): Handle char ranges.
1043 2012-02-12 Chong Yidong <cyd@gnu.org>
1045 * xdisp.c (handle_stop): Avoid assigning -1 to it->face_id here,
1046 as that creates a dangerous corner case.
1048 * window.c (Fdelete_window_internal): Invalidate the mouse
1049 highlight (Bug#9904).
1051 2012-02-12 Glenn Morris <rgm@gnu.org>
1053 * xselect.c (Fx_own_selection_internal)
1054 (Fx_get_selection_internal, Fx_disown_selection_internal)
1055 (Fx_selection_owner_p, Fx_selection_exists_p): Doc fixes.
1056 * nsselect.m (Fx_own_selection_internal)
1057 (Fx_disown_selection_internal, Fx_selection_exists_p)
1058 (Fx_selection_owner_p, Fx_get_selection_internal):
1059 Sync docs and argument specs with the xselect.c versions.
1061 2012-02-11 Lars Ingebrigtsen <larsi@gnus.org>
1063 * gnutls.c (emacs_gnutls_write): Don't infloop if sendto fails.
1065 2012-02-11 Eli Zaretskii <eliz@gnu.org>
1067 * w32select.c (Fx_selection_exists_p): Sync doc string and
1068 argument list with xselect.c. (Bug#10783)
1070 * w16select.c (Fx_selection_exists_p): Sync doc string and
1071 argument list with xselect.c. (Bug#10783)
1073 2012-02-10 Glenn Morris <rgm@gnu.org>
1075 * fns.c (Fsecure_hash): Doc fix.
1077 2012-02-09 Kenichi Handa <handa@m17n.org>
1079 * coding.c (produce_chars): Fix updating of src_end (Bug#10701).
1081 2012-02-07 Chong Yidong <cyd@gnu.org>
1083 * buffer.c (Fbuffer_local_variables)
1084 (buffer_lisp_local_variables): Handle unbound vars correctly;
1085 don't let Qunbound leak into Lisp.
1087 2012-02-07 Glenn Morris <rgm@gnu.org>
1089 * image.c (Fimagemagick_types): Doc fix.
1091 * image.c (imagemagick-render-type): Change it from a lisp object
1092 to an integer. Move the doc here from the lisp manual.
1093 Treat all values not equal to 0 the same.
1095 2012-02-06 Chong Yidong <cyd@gnu.org>
1097 * doc.c (store_function_docstring): Avoid applying docstring of
1098 alias to base function (Bug#2603).
1100 2012-02-04 Andreas Schwab <schwab@linux-m68k.org>
1102 * .gdbinit (pp1, pv1): Remove redundant defines.
1105 2012-02-04 Chong Yidong <cyd@gnu.org>
1107 * nsterm.m: Declare a global (Bug#10694).
1109 2012-02-04 Eli Zaretskii <eliz@gnu.org>
1111 * w32.c (get_emacs_configuration_options):
1112 Include --enable-checking, if specified, in the return value.
1114 2012-02-04 Martin Rudalics <rudalics@gmx.at>
1116 * dispnew.c (change_frame_size_1): Calculate new_frame_total_cols
1117 after rounding frame sizes. (Bug#9723)
1119 2012-02-04 Eli Zaretskii <eliz@gnu.org>
1121 * keyboard.c (adjust_point_for_property): Don't position point
1122 before BEGV. (Bug#10696)
1124 2012-02-03 Paul Eggert <eggert@cs.ucla.edu>
1126 Handle overflow when computing char display width (Bug#9496).
1127 * character.c (char_width): Return EMACS_INT, not int.
1128 (char_width, c_string_width): Check for overflow when
1129 computing the width; this is possible now that individual
1130 characters can have unbounded width. Problem introduced
1131 by merge from Emacs 23 on 2012-01-19.
1133 2012-02-02 Michael Albinus <michael.albinus@gmx.de>
1135 * dbusbind.c (Fdbus_register_method): Mention the return value
1136 :ignore in the docstring.
1138 2012-02-02 Glenn Morris <rgm@gnu.org>
1140 * callproc.c (Fcall_process, Fcall_process_region): Doc fix.
1142 * nsterm.m (syms_of_nsterm) <x-toolkit-scroll-bars>:
1143 Unconditionally set to t. (Bug#10673)
1144 * nsterm.m (syms_of_nsterm) <x-toolkit-scroll-bars>:
1145 * w32term.c (syms_of_w32term) <x-toolkit-scroll-bars>:
1146 * xterm.c (syms_of_xterm) <x-toolkit-scroll-bars>: Doc fix.
1148 2012-02-02 Kenichi Handa <handa@m17n.org>
1150 (x_produce_glyphs): Cancel previous change. If cmp->glyph_len is
1151 0, do not call append_composite_glyph.
1153 2012-02-02 Kenichi Handa <handa@m17n.org>
1155 * xdisp.c (BUILD_COMPOSITE_GLYPH_STRING): Initialize first_s to
1157 (x_produce_glyphs): If the component of a composition is a null
1158 string, set it->pixel_width to 1 to avoid zero-width glyph.
1160 2012-02-01 Eli Zaretskii <eliz@gnu.org>
1162 * ralloc.c (resize_bloc, r_alloc_sbrk): Don't call memmove if its
1163 first 2 arguments are identical. This makes inserting large
1164 output from a subprocess an order of magnitude faster on
1165 MS-Windows, where all sbrk'ed memory is always contiguous.
1167 2012-01-31 Glenn Morris <rgm@gnu.org>
1169 * nsterm.m (syms_of_nsterm) <x-toolkit-scroll-bars>:
1170 * w32term.c (syms_of_w32term) <x-toolkit-scroll-bars>:
1171 * xterm.c (syms_of_xterm) <x-toolkit-scroll-bars>: Sync docs.
1173 2012-01-29 Glenn Morris <rgm@gnu.org>
1175 * gnutls.c (syms_of_gnutls): More doc (from etc/NEWS).
1177 2012-01-28 Samuel Thibault <sthibault@debian.org> (tiny change)
1179 * s/gnu.h: Define POSIX_SIGNALS (Bug#10552).
1181 2012-01-28 Chong Yidong <cyd@gnu.org>
1183 * minibuf.c (syms_of_minibuf): Doc fix (Bug#10550).
1185 2012-01-26 Chong Yidong <cyd@gnu.org>
1187 * keyboard.c (Vecho_keystrokes): Document zero value (Bug#10503).
1189 * search.c (Fsearch_forward, Fsearch_backward): Document negative
1190 repeat counts (Bug#10507).
1192 2012-01-26 Glenn Morris <rgm@gnu.org>
1194 * lread.c (syms_of_lread): Doc fix.
1196 2012-01-25 HIROSHI OOTA <nil@mad.dog.cx> (tiny change)
1198 * coding.c (encode_designation_at_bol): Change return value to
1201 2012-01-25 Chong Yidong <cyd@gnu.org>
1203 * eval.c (Fuser_variable_p): Doc fix; mention custom-variable-p.
1205 2012-01-21 Chong Yidong <cyd@gnu.org>
1207 * floatfns.c (Fcopysign): Make the second argument non-optional,
1208 since nil is not allowed anyway.
1210 2012-01-21 Andreas Schwab <schwab@linux-m68k.org>
1212 * process.c (read_process_output): Use p instead of XPROCESS (proc).
1213 (send_process): Likewise.
1215 2012-01-19 Martin Rudalics <rudalics@gmx.at>
1217 * window.c (save_window_save, Fcurrent_window_configuration)
1218 (Vwindow_persistent_parameters): Do not use Qstate.
1219 Rewrite doc-strings.
1221 2012-01-19 Kenichi Handa <handa@m17n.org>
1223 * character.c (char_width): New function.
1224 (Fchar_width, c_string_width, lisp_string_width):
1225 Use char_width (Bug#9496).
1227 2012-01-16 Martin Rudalics <rudalics@gmx.at>
1229 * window.c (Vwindow_persistent_parameters): New variable.
1230 (Fset_window_configuration, save_window_save): Handle persistent
1233 2012-01-14 Eli Zaretskii <eliz@gnu.org>
1235 * w32fns.c (signal_user_input): Don't do a QUIT, to avoid
1236 thrashing the stack of the thread. (Bug#9087)
1238 2012-01-12 Paul Eggert <eggert@cs.ucla.edu>
1240 * xdisp.c (rows_from_pos_range): Add parens as per gcc -Wparentheses.
1242 2012-01-11 Eli Zaretskii <eliz@gnu.org>
1244 * xdisp.c (rows_from_pos_range): Handle the case where the
1245 highlight ends on a newline. (Bug#10464)
1246 (mouse_face_from_buffer_pos): Fix off-by-one error in calculating
1247 he end column for display of highlight that ends on a newline
1250 2012-01-11 Glenn Morris <rgm@gnu.org>
1252 * lread.c (init_lread): If no-site-lisp, remove site-lisp dirs
1253 from load-path also when installation-directory is nil. (Bug#10208)
1255 2012-01-10 Glenn Morris <rgm@gnu.org>
1257 * emacs.c (syms_of_emacs) <installation-directory>: Doc fix.
1259 * epaths.in (PATH_LOADSEARCH, PATH_EXEC, PATH_DATA, PATH_DOC):
1260 Update template values to be closer to their typical values these days.
1262 2012-01-09 Eli Zaretskii <eliz@gnu.org>
1264 * xdisp.c (rows_from_pos_range): Accept additional argument
1265 DISP_STRING, and accept any glyph in a row whose object is that
1266 string as eligible for mouse highlight. Fixes mouse highlight of
1267 display strings from overlays. (Bug#10464)
1269 2012-01-07 Paul Eggert <eggert@cs.ucla.edu>
1271 emacs: fix an auto-save permissions race condition (Bug#10400)
1272 * fileio.c (auto_saving_dir_umask): New static var.
1273 (Fmake_directory_internal): Use it.
1274 (do_auto_save_make_dir): Set it, instead of invoking chmod after
1275 creating the directory. The old code temporarily assigns
1276 too-generous permissions to the directory.
1277 (do_auto_save_eh): Clear it.
1278 (Fdo_auto_save): Catch all errors, not just file errors, so
1279 that the var is always cleared.
1281 2012-01-07 Eli Zaretskii <eliz@gnu.org>
1283 * search.c (scan_buffer): Pass character positions to
1284 know_region_cache, not byte positions. (Bug#6540)
1286 2012-01-07 LynX <_LynX@bk.ru> (tiny change)
1288 * w32.c (sys_rename): Report EXDEV when rename of a directory
1289 fails because the target is on another logical disk. (Bug#10284)
1291 2012-01-07 David Benjamin <davidben@mit.edu> (tiny change)
1293 * xterm.c (x_embed_request_focus): New function.
1295 * xterm.h: Add prototype.
1297 * xfns.c (Fx_focus_frame): Use it for embedded frames (Bug#9977).
1299 2012-01-05 Glenn Morris <rgm@gnu.org>
1301 * emacs.c (emacs_copyright): Update short copyright year to 2012.
1303 2012-01-01 Eli Zaretskii <eliz@gnu.org>
1305 * gnutls.c (init_gnutls_functions): Load gnutls_check_version.
1306 Load gnutls_transport_set_lowat only if GnuTLS version is below
1308 (emacs_gnutls_handshake): Call gnutls_transport_set_lowat only for
1309 GnuTLS versions below 2.11.1.
1311 2011-12-31 Antoine Levitt <antoine.levitt@gmail.com>
1313 * xdisp.c (syms_of_xdisp) <window-scroll-functions>: Add warning
1314 to the doc string advising against its use for altering the way
1315 windows are scrolled.
1317 2011-12-28 Kenichi Handa <handa@m17n.org>
1319 * coding.c (Fdefine_coding_system_internal): Make an utf-8 base
1320 coding-system ASCII compatible only when it does not produce BOM
1321 on encoding (Bug#10383).
1323 2011-12-26 Jan Djärv <jan.h.d@swipnet.se>
1325 * xmenu.c (x_menu_wait_for_event): Use xg_select for Gtk3 so menus
1327 (create_and_show_popup_menu): Always use menu_position_func for
1330 2011-12-24 Andreas Schwab <schwab@linux-m68k.org>
1332 * callint.c (Fcall_interactively): Don't truncate prompt string.
1334 2011-12-23 Eli Zaretskii <eliz@gnu.org>
1336 * xdisp.c (handle_invisible_prop): Handle correctly an invisible
1337 property that ends at ZV, so that the bidi iteration could be
1338 resumed from there (after widening). (Bug#10360)
1340 2011-12-22 Jan Djärv <jan.h.d@swipnet.se>
1342 * nsfont.m (ns_spec_to_descriptor): Do not autorelease fdesc.
1344 2011-12-21 Jan Djärv <jan.h.d@swipnet.se>
1346 * nsterm.m (x_free_frame_resources):
1347 Release f->output_data.ns->miniimage.
1348 (ns_index_color): Fix indentation. Do not retain
1349 color_table->colors[i].
1351 * nsmenu.m (ns_update_menubar): Call free_menubar_widget_value_tree
1354 * nsfns.m (x_set_background_color): Assign return value from
1355 ns_index_color to face-background instead of NSColor*.
1356 (ns_implicitly_set_icon_type): Fix indentation.
1357 Change assignment in for loop to comparison.
1359 * emacs.c (ns_pool): New variable.
1360 (main): Assign ns_pool.
1361 (Fkill_emacs): Call ns_release_autorelease_pool.
1363 * nsfont.m (ns_spec_to_descriptor): Fix indentation,
1364 autorelease fdesc, release fdAttrs and tdict.
1365 (ns_get_covering_families): Release charset.
1366 (ns_findfonts): Release NSFontDescriptor created with new.
1367 (ns_uni_to_glyphs): Fix indentation.
1368 (setString): Release attrStr before assigning new value.
1370 2011-12-18 Jan Djärv <jan.h.d@swipnet.se>
1372 * nsmenu.m (NSMenuDidBeginTrackingNotification): Declare if OSX < 10.5
1374 (trackingNotification): Surround with ifdef NS_IMPL_COCOA.
1375 (syms_of_nsmenu): Set trackingMenu to 1 if not NS_IMPL_COCOA.
1377 2011-12-18 David Reitter <reitter@cmu.edu>
1379 * nsterm.m (ns_term_init): Subscribe for notifications
1380 NSMenuDidBeginTrackingNotification and NSMenuDidEndTrackingNotification
1381 to method trackingNotification in EmacsMenu.
1383 * nsmenu.m (trackingMenu): New variable.
1384 (trackingNotification): New method (from Aquamacs).
1385 (menuNeedsUpdate): Expand comment and return if trackingMenu is 0,
1386 from Aquamacs (Bug#7030).
1388 2011-12-18 Jan Djärv <jan.h.d@swipnet.se>
1390 * nsselect.m (CUT_BUFFER_SUPPORT): Remove define.
1391 (symbol_to_nsstring): Fix indentation.
1392 (ns_symbol_to_pb): New function.
1393 (Fns_get_selection_internal): Rename from Fns_get_cut_buffer_internal.
1394 (Fns_rotate_cut_buffers_internal): Remove.
1395 (Fns_store_selection_internal): Rename from
1396 Fns_store_cut_buffer_internal.
1397 (ns_get_foreign_selection, Fx_own_selection_internal)
1398 (Fx_disown_selection_internal, Fx_selection_exists_p)
1399 (Fns_get_selection_internal, Fns_store_selection_internal):
1400 Use ns_symbol_to_pb and check if return value is nil.
1401 (syms_of_nsselect): Remove ifdef CUT_BUFFER_SUPPORT. Remove defsubr
1402 Sns_rotate_cut_buffers_internal. Sns_get_cut_buffer_internal
1403 renamed to Sns_get_selection_internal, Sns_store_cut_buffer_internal
1404 renamed to Sns_store_selection_internal.
1405 (ns_handle_selection_request): Move code to Fx_own_selection_internal
1406 and remove this function.
1407 (ns_handle_selection_clear): Remove, never used.
1408 (Fx_own_selection_internal): Move code from ns_handle_selection_request
1411 2011-12-17 Ken Brown <kbrown@cornell.edu>
1413 * fileio.c (check_writable) [CYGWIN]: Return non-zero if UID or
1414 GID is unknown (Bug#10257).
1416 2011-12-17 Paul Eggert <eggert@cs.ucla.edu>
1418 * s/gnu-linux.h: Fix mark_memory typo (Bug#10286).
1419 (GC_MARK_SECONDARY_STACK): Omit removed 3rd arg to mark_memory,
1420 which caused a build failure on GNU/Linux IA-64. This problem was
1421 introduced by my 2011-10-07 patch.
1423 2011-12-15 Juri Linkov <juri@jurta.org>
1425 * image.c (imagemagick_error): New function. (Bug#10112)
1426 (imagemagick_load_image): Comment out `MagickSetResolution' call.
1427 Use `imagemagick_error' where ImageMagick functions return
1429 (Fimagemagick_types): Add `Fnreverse' to return the list in the
1432 2011-12-15 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
1434 * xftfont.c (xftfont_draw): Use the font metrics of s->font to
1435 fill background (Bug#8992).
1437 2011-12-13 Martin Rudalics <rudalics@gmx.at>
1439 * window.c (Vwindow_combination_resize)
1440 (Vwindow_combination_limit): Use t instead of non-nil in
1442 (Vrecenter_redisplay): Add first sentence of doc-string on
1444 (Frecenter): Fix doc-string typo.
1446 2011-12-11 Kenichi Handa <handa@m17n.org>
1448 * coding.c (Funencodable_char_position): Pay attention to the
1449 buffer text relocation (Bug#9389).
1451 2011-12-10 Jan Djärv <jan.h.d@swipnet.se>
1453 * xterm.c (x_term_init): Move call to gdk_window_add_filter before
1454 gtk_init (Bug#10100).
1456 2011-12-10 Eli Zaretskii <eliz@gnu.org>
1458 * xdisp.c (RECORD_MAX_MIN_POS): Use IT->cmp_it.charpos only if
1459 IT->string is nil. (Bug#10263)
1461 2011-12-10 Jan Djärv <jan.h.d@swipnet.se>
1463 * nsterm.h (x_free_frame_resources): Declare.
1465 * nsfns.m (ns_get_defaults_value): New function (Bug#10103).
1466 (Fns_get_resource, x_get_string_resource): Call ns_get_defaults_value.
1468 * nsterm.h (ns_get_defaults_value): Declare.
1470 * nsterm.m (ns_default): Call ns_get_defaults_value.
1472 2011-12-09 Eli Zaretskii <eliz@gnu.org>
1474 * xdisp.c (try_scrolling): Don't set scroll_down_p if dy is zero.
1477 2011-12-09 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
1479 * unexelf.c (unexec) [NS_IMPL_GNUSTEP]: Take account of the case
1480 that where the value of an _OBJC_* symbol points to is in the .bss
1481 section (Bug#10240).
1483 2011-12-08 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny change)
1485 * coding.c (encode_coding_ccl): Check (charbuf < charbuf_end)
1486 after the loop to call ccl_driver at least once (Bug#8619).
1488 2011-12-08 Kenichi Handa <handa@m17n.org>
1490 * ftfont.c (get_adstyle_property): Fix previous change
1493 2011-12-07 Juanma Barranquero <lekktu@gmail.com>
1495 * w32.c (init_environment): If no_site_lisp, remove site-lisp
1496 dirs from the default value of EMACSLOADPATH (bug#10208).
1498 2011-12-07 Glenn Morris <rgm@gnu.org>
1500 * lread.c (init_lread): If no_site_lisp, exclude site-lisp/ in
1501 installation and source directories as well. (Bug#10208)
1503 2011-12-06 Chong Yidong <cyd@gnu.org>
1505 * minibuf.c (Fread_from_minibuffer): Doc fix (Bug#10228).
1507 2011-12-06 Glenn Morris <rgm@gnu.org>
1509 * process.c (start_process_unwind): Treat any pid <= 0, except -2,
1510 as an error, not just -1. (Bug#10217)
1512 2011-12-05 Chong Yidong <cyd@gnu.org>
1514 * keyboard.c (process_special_events): New function.
1515 (swallow_events, Finput_pending_p): Use it (Bug#10195).
1517 2011-12-05 Paul Eggert <eggert@cs.ucla.edu>
1519 * coding.c (encode_designation_at_bol): Don't use uninitialized
1520 local variable (Bug#9318).
1522 2011-12-05 Kenichi Handa <handa@m17n.org>
1524 * ftfont.c (get_adstyle_property): If the font is not BDF nor PCF,
1525 return Qnil (Bug#8046, Bug#10193).
1527 2011-12-05 Kenichi Handa <handa@m17n.org>
1529 * coding.c (encode_designation_at_bol): New args charbuf_end and
1530 dst. Return the number of produced bytes. Callers changed.
1531 (coding_set_source): Return how many bytes coding->source was
1533 (coding_set_destination): Return how many bytes
1534 coding->destination was relocated.
1535 (CODING_DECODE_CHAR, CODING_ENCODE_CHAR, CODING_CHAR_CHARSET)
1536 (CODING_CHAR_CHARSET_P): Adjust for the avove changes.
1538 2011-12-05 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny change)
1540 * coding.c (CODING_CHAR_CHARSET_P): New macro.
1541 (encode_coding_emacs_mule, encode_coding_iso_2022): Use the above
1544 2011-12-05 Andreas Schwab <schwab@linux-m68k.org>
1546 The following changes are to fix Bug#9318.
1548 * coding.c (CODING_ENCODE_CHAR, CODING_CHAR_CHARSET): New macros.
1549 (encode_coding_emacs_mule, ENCODE_ISO_CHARACTER)
1550 (encode_coding_iso_2022, encode_coding_sjis)
1551 (encode_coding_big5, encode_coding_charset): Use the above macros.
1553 2011-12-05 Juanma Barranquero <lekktu@gmail.com>
1555 * lisp.h (process_quit_flag): Fix external declaration.
1557 2011-12-04 Stefan Monnier <monnier@iro.umontreal.ca>
1559 Don't macro-inline non-performance-critical code.
1560 * eval.c (process_quit_flag): New function.
1561 * lisp.h (QUIT): Use it.
1563 2011-12-04 Jan Djärv <jan.h.d@swipnet.se>
1565 * nsfns.m (get_geometry_from_preferences): New function.
1566 (Fx_create_frame): Call get_geometry_from_preferences (Bug#10103).
1568 2011-12-04 Andreas Schwab <schwab@linux-m68k.org>
1570 * emacs.c (Qkill_emacs): Define.
1571 (syms_of_emacs): Initialize it.
1572 * keyboard.c (interrupt_signal): Don't call Fkill_emacs here, set
1573 Qquit_flag to `kill-emacs' instead.
1574 (quit_throw_to_read_char): Add parameter `from_signal'.
1575 All callers changed. Call Fkill_emacs if requested and safe.
1576 * lisp.h (QUIT): Call Fkill_emacs if requested.
1578 2011-12-03 Jan Djärv <jan.h.d@swipnet.se>
1580 * widget.c (update_wm_hints): Return if wmshell is null.
1581 (widget_update_wm_size_hints): New function.
1583 * widget.h (widget_update_wm_size_hints): Declare.
1585 * xterm.c (x_wm_set_size_hint): If USE_X_TOOLKIT, call
1586 widget_update_wm_size_hints (Bug#10104).
1588 2011-12-03 Eli Zaretskii <eliz@gnu.org>
1590 * xdisp.c (handle_invisible_prop): If the invisible text ends just
1591 before a newline, prepare the bidi iterator for consuming the
1592 newline, and keep the current paragraph direction. (Bug#10183)
1593 (redisplay_window): Don't let `margin' become negative. (Bug#10192)
1595 2011-12-02 Juri Linkov <juri@jurta.org>
1597 * search.c (Fword_search_regexp): New Lisp function created from
1598 `wordify'. Change type of arg `lax' from `int' to `Lisp_Object'.
1599 (Fword_search_backward, Fword_search_forward)
1600 (Fword_search_backward_lax, Fword_search_forward_lax):
1601 Use `Fword_search_regexp' instead of `wordify'. Doc fix.
1602 (syms_of_search): Define `Sword_search_regexp'. (Bug#10145)
1604 2011-12-01 Stefan Monnier <monnier@iro.umontreal.ca>
1606 * fileio.c (Finsert_file_contents): Move after-change-function call
1607 to before the "handled:" label, since all "goto handled" appear in
1608 cases where the *-change-functions have already been properly called
1611 2011-12-01 Andreas Schwab <schwab@linux-m68k.org>
1613 * keyboard.c (interrupt_signal): Don't call kill-emacs when
1614 waiting for input. (Bug#10169)
1616 2011-11-30 Eli Zaretskii <eliz@gnu.org>
1618 * dispnew.c (adjust_glyph_matrix): Remove the assertion that
1619 verifies glyph row's hash code--we have just reallocated the
1620 glyphs, so their contents can be complete garbage. (Bug#10164)
1622 2011-11-30 Juanma Barranquero <lekktu@gmail.com>
1624 * dispnew.c (adjust_glyph_matrix) [XASSERTS]: Add missing check.
1626 2011-11-30 Eli Zaretskii <eliz@gnu.org>
1628 * dispnew.c (adjust_glyph_matrix) [XASSERTS]: Ensure ROW's
1629 attributes are tested _before_ calling verify_row_hash, to protect
1630 against GCC re-ordering of the tests. (Bug#10164)
1632 2011-11-29 Jan Djärv <jan.h.d@swipnet.se>
1634 * xterm.h (struct x_output): net_wm_state_hidden_seen is new.
1636 * xterm.c (handle_one_xevent): Only set async_visible and friends
1637 if net_wm_state_hidden_seen is non-zero (Bug#10002)
1638 (get_current_wm_state): Set net_wm_state_hidden_seen to 1 if
1639 _NET_WM_STATE_HIDDEN is in NET_WM_STATE.
1641 2011-11-28 Paul Eggert <eggert@cs.ucla.edu>
1643 Remove GCPRO-related macros that exist only to avoid shadowing locals.
1644 * lisp.h (GCPRO1_VAR, GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR, GCPRO5_VAR)
1645 (GCPRO6_VAR, UNGCPRO_VAR): Remove. See
1646 <http://lists.gnu.org/archive/html/emacs-diffs/2011-11/msg00265.html>.
1647 All uses changed to use GCPRO1 etc.
1648 (GCPRO1, GCPRO2, GCPRO3, GCPRO4, GCPRO5, GCPRO6, UNGCPRO):
1649 Revert to old implementation (i.e., before 2011-03-11).
1651 2011-11-28 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
1653 * dispnew.c (scrolling_window): Truncate overlaps in copy destination
1654 of scroll runs so as to avoid assigning disabled bogus rows and
1655 unnecessary graphics copy operations.
1657 2011-11-27 Eli Zaretskii <eliz@gnu.org>
1659 * s/ms-w32.h (utimbuf) [_MSC_VER]: Don't define.
1660 (snprintf) [_MSC_VER]: Redirect to _snprintf.
1661 (strtoll) [_MSC_VER]: Redirect to _strtoi64.
1662 (malloc, free, realloc, calloc): Redirect to e_* only when
1665 * lisp.h (GCTYPEBITS): Move before first use.
1666 (ALIGN_GCTYPEBITS) [_MSC_VER]: Define.
1667 (DECL_ALIGN) [_MSC_VER]: Use it, as MSVC doesn't like bit ops in
1668 this macro definition.
1670 * s/ms-w32.h (tzname): Redirect to _tzname for all values of
1673 2011-11-27 Jan Djärv <jan.h.d@swipnet.se>
1675 * gtkutil.c (xg_create_frame_widgets):
1676 Call gtk_window_set_has_resize_grip (FALSE) if that function is
1677 present with Gtk+ 2.0.
1679 2011-11-26 Paul Eggert <eggert@cs.ucla.edu>
1681 * fileio.c (Finsert_file_contents): Undo previous change; see
1682 <http://lists.gnu.org/archive/html/emacs-diffs/2011-11/msg00265.html>.
1684 2011-11-26 Paul Eggert <eggert@cs.ucla.edu>
1686 Rename locals to avoid shadowing.
1687 * fileio.c (Finsert_file_contents):
1688 Rename inner 'gcpro1' to 'inner_gcpro1' to avoid shadowing.
1689 * process.c (wait_reading_process_output):
1690 Rename inner 'proc' to 'p' to avoid shadowing.
1691 Indent for consistency with usual Emacs style.
1693 2011-11-25 Eli Zaretskii <eliz@gnu.org>
1695 * xdisp.c (redisplay_window): If cursor row is not fully visible
1696 after recentering, and scroll-conservatively is set to a large
1697 number, scroll window by a few more lines to make the cursor fully
1698 visible and out of scroll-margin. (Bug#10105)
1699 (start_display): Don't move to the next line if the display should
1700 start at a newline that is part of a display vector or an overlay
1703 2011-11-24 Juri Linkov <juri@jurta.org>
1705 * image.c (imagemagick_load_image): Move `MagickSetResolution' down
1706 after the `MagickPingImage' call. (Bug#10112)
1708 2011-11-23 Chong Yidong <cyd@gnu.org>
1710 * window.c (Fcoordinates_in_window_p): Accept only live windows.
1712 2011-11-23 Martin Rudalics <rudalics@gmx.at>
1714 * buffer.c (Fkill_buffer): Run replace_buffer_in_windows before
1715 making another buffer current. (Bug#10114)
1717 2011-11-23 Glenn Morris <rgm@gnu.org>
1719 * font.c (font_find_for_lface) [HAVE_NS]: Ignore case. (Bug#2526)
1721 2011-11-23 Chong Yidong <cyd@gnu.org>
1723 * xdisp.c (compute_stop_pos): Check validity of end_charpos before
1724 using it (Bug#5984).
1726 2011-11-22 Eli Zaretskii <eliz@gnu.org>
1728 * dispnew.c (adjust_glyph_matrix): Don't verify hash code of mode-
1729 and header-lines, as they don't have one computed for them.
1732 * .gdbinit (prow): Make displayed values more self-explaining.
1733 Add row's hash code.
1735 2011-11-21 Lars Magne Ingebrigtsen <larsi@gnus.org>
1737 * process.c (wait_reading_process_output): Fix asynchrounous
1738 GnuTLS socket handling on some versions of the GnuTLS library.
1739 (wait_reading_process_output): Add comment and URL.
1741 2011-11-21 Jan Djärv <jan.h.d@swipnet.se>
1743 * xterm.c (x_clear_frame): Reinstate the XClearWindow call.
1745 2011-11-21 Chong Yidong <cyd@gnu.org>
1747 * window.c (Fnext_window, Fprevious_window): Doc fix.
1749 2011-11-20 Stefan Monnier <monnier@iro.umontreal.ca>
1751 * window.c (get_phys_cursor_glyph): Fix Lisp_Object/int mixup.
1753 2011-11-20 Juanma Barranquero <lekktu@gmail.com>
1755 * nsfont.m (syms_of_nsfont) <ns-reg-to-script>: Fix typo.
1757 2011-11-20 Martin Rudalics <rudalics@gmx.at>
1759 * window.c (Fset_window_combination_limit): Rename argument
1761 (Vwindow_combination_limit): Remove "status" from doc-string.
1763 2011-11-20 Andreas Schwab <schwab@linux-m68k.org>
1765 * m/ibms390.h: Remove.
1766 * m/ibms390x.h: Don't include "ibms390.h".
1768 2011-11-20 Stefan Monnier <monnier@iro.umontreal.ca>
1770 * fileio.c (Finsert_file_contents): Add missing gcpro1 variable.
1771 Suggested by Dmitry Antipov <dmantipov@yandex.ru>.
1773 2011-11-20 Juanma Barranquero <lekktu@gmail.com>
1775 * casetab.c (Fset_case_table):
1776 * charset.c (Fcharset_after): Fix typos.
1778 2011-11-20 Paul Eggert <eggert@cs.ucla.edu>
1780 Standardize on VIRT_ADDR_VARIES behavior (Bug#10042).
1781 Otherwise, valgrind does not work on some platforms.
1782 Problem reported by Andreas Schwab in
1783 <http://lists.gnu.org/archive/html/emacs-devel/2011-11/msg00081.html>.
1784 * puresize.h (pure, PURE_P): Always behave as if VIRT_ADDR_VARIES
1785 is set, removing the need for VIRT_ADDRESS_VARIES.
1786 (PURE_P): Use a more-efficient implementation that needs just one
1787 comparison, not two: on x86-64 with GCC 4.6.2, this cut down the
1788 number of instructions from 6 (xorl, cmpq, jge, xorl, cmpq, setge)
1789 to 4 (xorl, subq, cmpq, setbe).
1790 * alloc.c (pure): Always extern now, since that's the
1791 VIRT_ADDR_VARIES behavior.
1792 (PURE_POINTER_P): Use a single comparison, not two, for
1793 consistency with the new puresize.h.
1794 * lisp.h (PNTR_COMPARISON_TYPE): Remove; no longer needed.
1795 * m/ibms390.h, m/intel386.h, m/template.h, s/cygwin.h, s/hpux10-20.h:
1796 Remove VIRT_ADDR_VARIES no longer needed.
1798 2011-11-19 Eli Zaretskii <eliz@gnu.org>
1800 * xdisp.c (x_write_glyphs, draw_phys_cursor_glyph)
1801 (erase_phys_cursor, update_window_cursor, show_mouse_face)
1802 (cursor_in_mouse_face_p): If the cursor position is out of bounds,
1803 behave as if the cursor position were at the window margin.
1805 * window.c (get_phys_cursor_glyph): If the window is hscrolled,
1806 and the cursor position is out of bounds, behave as if the cursor
1807 position were at the window margin. (Bug#10075)
1809 2011-11-18 Chong Yidong <cyd@gnu.org>
1811 * window.c (Fwindow_combination_limit): Make first argument
1812 non-optional, since it is meaningless for live windows like the
1815 2011-11-18 Dmitry Antipov <dmantipov@yandex.ru>
1817 * keymap.c (Fwhere_is_internal): Add missing RETURN_UNGCPROs.
1819 2011-11-18 Stefan Monnier <monnier@iro.umontreal.ca>
1821 * intervals.c: Fix grafting over the whole buffer (bug#10071).
1822 (graft_intervals_into_buffer): Simplify.
1824 2011-11-18 Eli Zaretskii <eliz@gnu.org>
1826 * dispnew.c (swap_glyph_pointers): Swap the used[] arrays and the
1827 hash values of the two rows.
1828 (copy_row_except_pointers): Preserve the used[] arrays and the
1829 hash values of the two rows. (Bug#10035)
1830 (add_row_entry): Add xassert to verify that ROW's hash code is valid.
1832 * xdisp.c (row_hash): New function, body extracted from
1833 compute_line_metrics.
1834 (compute_line_metrics): Call row_hash, instead of computing the
1837 * dispnew.c (verify_row_hash): Call row_hash for computing the
1838 hash code of a row, instead of duplicating code from xdisp.c.
1840 * dispextern.h (row_hash): Add prototype.
1842 2011-11-18 Tassilo Horn <tassilo@member.fsf.org>
1844 * frame.c (delete_frame): Don't delete the terminal when the last
1845 X frame is closed if emacs is built with GTK toolkit.
1847 2011-11-17 Juanma Barranquero <lekktu@gmail.com>
1849 * window.c (syms_of_window) <window-combination-resize>: Fix typo.
1851 2011-11-17 Martin Rudalics <rudalics@gmx.at>
1853 * window.c (Vwindow_splits): Rename to
1854 Vwindow_combination_resize. Suggested by Juri Linkov.
1855 (Fsplit_window_internal): Use Vwindow_combination_resize instead
1858 2011-11-16 Juanma Barranquero <lekktu@gmail.com>
1860 * nsfns.m (Fns_font_name):
1861 * window.c (syms_of_window) <window-combination-limit>: Fix typos.
1863 2011-11-16 Martin Rudalics <rudalics@gmx.at>
1865 * window.h (window): Rename slot "nest" to "combination_limit".
1866 * window.c (Fwindow_nest): Rename to Fwindow_combination_limit.
1867 (Fset_window_nest): Rename to Fset_window_combination_limit.
1868 (Vwindow_nest): Rename to Vwindow_combination_limit.
1869 (recombine_windows, make_parent_window, make_window)
1870 (Fsplit_window_internal, saved_window)
1871 (Fset_window_configuration, save_window_save): Rename all
1872 occurrences of window_nest to window_combination_limit.
1874 2011-11-15 Juanma Barranquero <lekktu@gmail.com>
1876 * image.c (imagemagick_load_image): Fix typo.
1878 2011-11-14 Eli Zaretskii <eliz@gnu.org>
1880 * xdisp.c (display_line): Move the call to
1881 highlight_trailing_whitespace before the call to
1882 compute_line_metrics, since the latter needs to see the final
1883 faces of all the glyphs to compute ROW's hash value.
1884 Fixes assertion violations in row_equal_p. (Bug#10035)
1886 2011-11-14 Juanma Barranquero <lekktu@gmail.com>
1888 * w32proc.c (reader_thread): Don't check pending input if cp->fd < 0,
1889 just return (bug#10044).
1891 2011-11-12 Eli Zaretskii <eliz@gnu.org>
1893 * makefile.w32-in (HEAPSIZE): New variable, allows to build temacs
1894 with user-defined heap size. Bump the default size of the temacs
1895 heap to 27MB, to avoid memory warning when running temacs.
1896 ($(TEMACS)): Use HEAPSIZE instead of a hardcoded value.
1898 * dispnew.c (scrolling_window): Fix incorrect indices in accessing
1899 current_matrix and desired_matrix. (Bug#9990)
1900 (verify_row_hash) [XASSERTS]: New function.
1901 (adjust_glyph_matrix, row_equal_p): Use it in xassert to verify
1902 that the hash value of glyph rows is correct.
1904 2011-11-12 Martin Rudalics <rudalics@gmx.at>
1906 * window.h (window): Remove splits slot.
1907 * window.c (Fwindow_splits, Fset_window_splits): Remove.
1908 (Fdelete_other_windows_internal, make_parent_window)
1909 (make_window, Fsplit_window_internal, Fdelete_window_internal)
1910 (Fset_window_configuration, save_window_save): Don't deal with
1911 split status of windows.
1912 (saved_window): Remove splits slot.
1913 (Vwindow_splits): Rewrite doc-string.
1915 2011-11-11 Jan Djärv <jan.h.d@swipnet.se>
1917 * xfns.c (unwind_create_frame):
1918 * nsfns.m (unwind_create_frame):
1919 * w32fns.c (unwind_create_frame): Use Fmemq to check if frame is in
1920 Vframe_list (Bug#9999).
1922 2011-11-11 Dmitry Antipov <dmantipov@yandex.ru>
1924 * xdisp.c (syms_of_xdisp): Remove duplicated definition of Qtext.
1926 2011-11-11 Kenichi Handa <handa@m17n.org>
1928 * callproc.c (Fcall_process): Set the member dst_multibyte of
1931 2011-11-11 Johan Bockgård <bojohan@gnu.org>
1933 * xdisp.c (fill_composite_glyph_string): Always set s->face, to
1934 avoid a crash (bug#9496).
1936 2011-11-09 Chong Yidong <cyd@gnu.org>
1938 * window.c (Fwindow_inside_edges, Fwindow_inside_pixel_edges)
1939 (Fwindow_inside_absolute_pixel_edges): Only allow live windows.
1941 2011-11-08 Paul Eggert <eggert@cs.ucla.edu>
1943 * s/gnu.h (GC_MARK_STACK): Define to GC_MAKE_GCPROS_NOOPS (Bug#9926).
1945 2011-11-08 Paul Eggert <eggert@cs.ucla.edu>
1947 Avoid some portability problems by eschewing 'extern inline' functions.
1948 The trivial performance wins aren't worth the portability hassles; see
1949 <http://lists.gnu.org/archive/html/emacs-devel/2011-11/msg00084.html>
1951 * dispextern.h (window_box, window_box_height, window_text_bottom_y)
1952 (window_box_width, window_box_left, window_box_left_offset)
1953 (window_box_right, window_box_right_offset): Undo previous change,
1954 by removing the "extern"s.
1955 * intervals.c (adjust_intervals_for_insertion)
1956 (adjust_intervals_for_deletion): Undo previous change,
1957 making these static again.
1958 (offset_intervals, temp_set_point_both, temp_set_point)
1959 (copy_intervals_to_string): No longer inline.
1960 * xdisp.c (window_text_bottom_y, window_box_width)
1961 (window_box_height, window_box_left_offset)
1962 (window_box_right_offset, window_box_left, window_box_right)
1963 (window_box): No longer inline.
1965 2011-11-08 Chong Yidong <cyd@gnu.org>
1967 * window.c (Fwindow_left_column, Fwindow_top_line): Doc fix.
1968 (Fwindow_body_height, Fwindow_body_width): Move from Lisp.
1969 Signal an error if not a live window.
1970 (Fwindow_total_width, Fwindow_total_height): Move from Lisp.
1971 (Fwindow_total_size, Fwindow_body_size): Move to Lisp.
1973 2011-11-07 Juanma Barranquero <lekktu@gmail.com>
1975 * lisp.h (syms_of_abbrev): Remove declaration.
1976 Reported by CHENG Gao <chenggao@royau.me>.
1978 2011-11-07 Eli Zaretskii <eliz@gnu.org>
1980 * w32.c (check_windows_init_file): Don't look for term/w32-win.el
1981 if Vpurify_flag is non-nil. Fixes a crash when running w32 build
1982 of temacs in GUI mode.
1984 2011-11-07 Martin Rudalics <rudalics@gmx.at>
1986 * window.h: Declare delete_all_child_windows instead of
1987 delete_all_subwindows.
1988 * window.c (Fwindow_nest, Fset_window_nest)
1989 (Fset_window_new_total, Fset_window_new_normal)
1990 (Fwindow_resize_apply): Don't use term subwindow in doc-strings.
1991 (delete_all_subwindows): Rename to delete_all_child_windows.
1992 (Fdelete_other_windows_internal, Fset_window_configuration):
1993 Call delete_all_child_windows instead of delete_all_subwindows.
1994 * frame.c (delete_frame): Call delete_all_child_windows instead
1995 of delete_all_subwindows.
1997 2011-11-07 Paul Eggert <eggert@cs.ucla.edu>
1999 * alloc.c (DEADP): New macro, for porting to GNU/Hurd (Bug#9926).
2000 This is also needed for porting to any host where GC_MARK_STACK is
2001 not GC_MAKE_GCPROS_NOOPS.
2002 (which_symbols): Use it.
2004 2011-11-07 Kenichi Handa <handa@m17n.org>
2006 * coding.c (coding_set_destination): Check coding->src_pos only
2007 when coding->src_object is a buffer (bug#9910).
2009 * process.c (send_process): Set the member src_multibyte of coding
2010 to 0 (bug#9911) when sending a unibyte text.
2012 * callproc.c (Fcall_process): Set the member src_multibyte of
2013 process_coding to 0 (bug#9912).
2015 2011-11-06 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
2017 * xmenu.c (cleanup_widget_value_tree): New function.
2018 (xmenu_show, xdialog_show): Use it in record_unwind_protect instead of
2019 calling free_menubar_widget_value_tree directly (Bug#9830).
2021 2011-11-06 Paul Eggert <eggert@cs.ucla.edu>
2023 Fix some portability problems with 'inline'.
2024 * dispextern.h (window_box, window_box_height, window_text_bottom_y)
2025 (window_box_width, window_box_left, window_box_left_offset)
2026 (window_box_right, window_box_right_offset): Declare extern.
2027 Otherwise, these inline functions do not conform to C99 and
2028 are miscompiled by Microsoft compilers. Reported by Eli Zaretskii in
2029 <http://lists.gnu.org/archive/html/emacs-devel/2011-11/msg00084.html>.
2030 * intervals.c (adjust_intervals_for_insertion)
2031 (adjust_intervals_for_deletion): Now extern, because otherwise the
2032 extern inline functions 'offset_intervals' couldn't refer to it.
2033 (static_offset_intervals): Remove.
2034 (offset_intervals): Rewrite using the old contents of
2035 static_offset_intervals. The old version didn't conform to C99
2036 because an extern inline function contained a reference to an
2037 identifier with static linkage.
2039 2011-11-06 Andreas Schwab <schwab@linux-m68k.org>
2041 * keyboard.c (interrupt_signal): Don't call kill-emacs while in
2044 2011-11-06 Eli Zaretskii <eliz@gnu.org>
2046 * xdisp.c (init_iterator, reseat_to_string): Don't set the
2047 iterator's bidi_p flag if Vpurify_flag is non-nil. (Bug#9963)
2048 (Fcurrent_bidi_paragraph_direction): If Vpurify_flag is non-nil,
2049 return Qleft_to_right.
2051 2011-11-06 Chong Yidong <cyd@gnu.org>
2053 * window.c (Fwindow_live_p, Fwindow_frame, Fframe_root_window)
2054 (Fminibuffer_window, Fwindow_buffer, Fwindow_splits)
2055 (Fset_window_splits, Fwindow_nest, Fset_window_nest)
2056 (Fwindow_use_time, Fwindow_total_size, Fwindow_normal_size)
2057 (Fwindow_new_normal, Fwindow_left_column, Fwindow_top_line)
2058 (Fwindow_margins, Fwindow_fringes, Fwindow_scroll_bars)
2059 (Fwindow_vscroll): Doc fix.
2060 (Fwindow_top_child, Fwindow_left_child): Eliminate a nil default
2061 argument, since it makes no sense to pass a live window and for
2062 consistency with window-child.
2064 2011-11-05 Christoph Scholtes <cschol2112@googlemail.com>
2066 * makefile.w32-in ($(TEMACS), (gl-stamp)): Use $(THISDIR) to
2069 2011-11-05 Jason Rumney <jasonr@gnu.org>
2071 * w32font.c (font_matches_spec): Filter out non-Japanese kana fonts.
2072 (add_font_entity_to_list): Filter out non-Japanese Shift-JIS
2074 (add_font_entity_to_list): Fix logic errors in mixed boolean and
2075 bitwise arithmetic preventing use of unicode-sip and non-truetype
2078 2011-11-05 Eli Zaretskii <eliz@gnu.org>
2080 * s/ms-w32.h (fstat, stat, utime): Move redirections to
2083 * w32fns.c (x_create_tip_frame, Fx_create_frame): Rearrange
2084 initialization code to keep similarity to xfns.c after changes
2087 2011-11-05 Jan Djärv <jan.h.d@swipnet.se>
2089 * nsfns.m: Declare image_cache_refcount if GLYPH_DEBUG.
2090 (unwind_create_frame): New function (Bug#9943).
2091 (Fx_create_frame): Restructure code to be more similar to the one in
2092 xfns.c. Call record_unwind_protect with unwind_create_frame (Bug#9943).
2093 Initialize image_cache_refcount if GLYPH_DEBUG (Bug#9943).
2094 Move terminal->reference_count++ just before making the frame official
2097 * nsterm.m (x_free_frame_resources): New function.
2098 (x_destroy_window): Move code to x_free_frame_resources.
2100 * xfns.c (unwind_create_frame): Fix comment.
2101 (Fx_create_frame, x_create_tip_frame):
2102 Move terminal->reference_count++ just before making the frame
2103 official. Move initialization of image_cache_refcount and
2104 dpyinfo_refcount before calling init_frame_faces (Bug#9943).
2106 2011-11-05 Eli Zaretskii <eliz@gnu.org>
2108 Support MSVC build with newer versions of Visual Studio.
2109 * makefile.w32-in (TAGS-gmake): Don't use $(patsubst ...), as
2110 Nmake barfs on that. Use $(OBJ*_c) variables instead, defined on
2113 * lisp.h (ENUM_BF): New macro, for enumerated types in bitfields,
2114 which are not supported by MSVC.
2115 (Lisp_Symbol, Lisp_Misc_Any, Lisp_Marker, Lisp_Misc_Overlay)
2116 (Lisp_Save_Value, Lisp_Free): Use ENUM_BF for enumerated types in
2118 (Lisp_Object) [USE_LISP_UNION_TYPE]: Use ENUM_BF for enumerated
2120 (DEFUN) [_MSC_VER]: Define in a different way for MSVC.
2122 * w32fns.c [_MSC_VER]: DECLARE_HANDLE for any MSVC version.
2124 2011-11-05 Fabrice Popineau <fabrice.popineau@supelec.fr> (tiny change)
2126 Support MSVC build with newer versions of Visual Studio.
2127 * w32.c: Don't include w32api.h for MSVC.
2128 (init_environment) [_MSC_VER]: Call sys_access, not _access.
2130 * s/ms-w32.h <sigset_t, ssize_t> [_MSC_VER]: Typedefs for MSVC.
2131 [_MSC_VER]: Include sys/timeb.h, sys/stat.h, and signal.h.
2132 (fstat, stat, utime) [_MSC_VER]: Redirect to their sys_* cousins.
2133 (malloc, free, realloc, calloc) [_MSC_VER]: Always redirect to the
2135 (alloca) [_MSC_VER]: Define to _alloca.
2137 * lisp.h (DECL_ALIGN) [_MSC_VER]: Define for MSVC.
2139 * regex.c <re_char> [_MSC_VER]: A separate definition for MSVC.
2141 2011-11-04 Eli Zaretskii <eliz@gnu.org>
2143 * xdisp.c (note_mouse_highlight): If either of
2144 previous/next-single-property-change returns nil, treat that as
2145 the beginning or the end of the buffer. (Bug#9955)
2147 2011-11-04 Jan Djärv <jan.h.d@swipnet.se>
2149 * gtkutil.c (xg_make_tool_item): Add callbacks if one of wimage or
2150 label is not null (Bug#9951).
2151 (xg_tool_item_stale_p): Handle the fact that wimage and/or wlbl
2154 2011-11-04 Eli Zaretskii <eliz@gnu.org>
2156 * window.c (Fwindow_body_size): Mention in the doc string that the
2157 return value is in frame's canonical units. (Bug#9949)
2159 2011-11-03 Eli Zaretskii <eliz@gnu.org>
2161 * xdisp.c (note_mouse_highlight): Initialize `area'. (Bug#9947)
2163 * w32fns.c (unwind_create_frame): If needed, free the glyph
2164 matrices of the partially constructed frame. (Bug#9943)
2165 * xfns.c (unwind_create_frame): Likewise.
2167 2011-11-01 Eli Zaretskii <eliz@gnu.org>
2169 * xdisp.c (mouse_face_from_buffer_pos): Fix a typo in a comment.
2170 Don't stop backward scan on the continuation glyph, even though
2171 its CHARPOS is positive.
2172 (mouse_face_from_buffer_pos, note_mouse_highlight):
2173 Rename cover_string to disp_string.
2175 2011-11-01 Martin Rudalics <rudalics@gmx.at>
2177 * window.c (temp_output_buffer_show): Don't use
2178 Vtemp_buffer_show_specifiers.
2179 (Vtemp_buffer_show_specifiers): Remove unused variable.
2181 2011-10-30 Eli Zaretskii <eliz@gnu.org>
2183 * xdisp.c (try_cursor_movement): Make sure ROW isn't decremented
2184 past the beginning of the current glyph matrix.
2186 2011-10-30 Adam Sjøgren <asjo@koldfront.dk> (tiny change)
2188 * xterm.c: Include X11/Xproto.h if HAVE_GTK3.
2189 (x_error_handler): Ignore BadMatch for X_SetInputFocus for
2190 HAVE_GTK3 (Bug#9869).
2192 * gtkutil.c (xg_win_to_widget, xg_event_is_for_menubar): Initialize
2193 type to GDK_NOTHING so valgrind does not complain (Bug#9901).
2195 * xterm.h (x_display_info): Add Xatom_net_wm_state_hidden (Bug#9893).
2197 * xterm.c: Declare x_handle_net_wm_state to return int.
2198 (handle_one_xevent): Check if we are iconified but don't have
2199 _NET_WM_STATE_HIDDEN. If do, treat as deiconify (Bug#9893).
2200 (get_current_wm_state): Return non-zero if not hidden,
2201 check for _NET_WM_STATE_HIDDEN (Bug#9893).
2202 (do_ewmh_fullscreen): Ignore return value from get_current_wm_state.
2203 (x_handle_net_wm_state): Return what get_current_wm_state returns.
2204 (x_term_init): Initialize dpyinfo->Xatom_net_wm_state_hidden.
2206 2011-10-29 Paul Eggert <eggert@cs.ucla.edu>
2208 * alloc.c (which_symbols): Declare EXTERNALLY_VISIBLE,
2209 so that this new function doesn't get optimized away by a
2210 whole-program optimizer. Make the 2nd arg EMACS_INT, not int.
2212 2011-10-29 Andreas Schwab <schwab@linux-m68k.org>
2214 * frame.h (MOUSE_HL_INFO): Remove excess parens.
2216 2011-10-29 Eli Zaretskii <eliz@gnu.org>
2218 Fix the `xbytecode' command.
2219 * .gdbinit (xprintbytestr): New command.
2220 (xwhichsymbols): Rename from `which'; all callers changed.
2221 (xbytecode): Print the byte-code string as well.
2223 2011-10-29 Kim Storm <storm@cua.dk>
2225 * alloc.c (which_symbols): New function.
2227 2011-10-29 Andreas Schwab <schwab@linux-m68k.org>
2229 * minibuf.c (read_minibuf_noninteractive): Allow reading empty
2232 2011-10-29 Glenn Morris <rgm@gnu.org>
2234 * process.c (wait_reading_process_output): Revert 2009-08-30 change.
2235 Not clear what it was for, and it causes various bugs. (Bug#9839)
2237 2011-10-28 Eli Zaretskii <eliz@gnu.org>
2239 * xdisp.c (note_mouse_highlight): Initialize `part', to avoid a
2240 possible random value that matches one of those tested as
2241 condition to clear the mouse face.
2243 2011-10-28 Chong Yidong <cyd@gnu.org>
2245 * xdisp.c (note_mouse_highlight): Fix use of uninitialized var.
2247 2011-10-28 Dan Nicolaescu <dann@ics.uci.edu>
2249 * window.c (make_window): Initialize phys_cursor_on_p.
2251 2011-10-28 Stefan Monnier <monnier@iro.umontreal.ca>
2253 * lisp.h (struct Lisp_Symbol): Update comments.
2255 2011-10-28 Juanma Barranquero <lekktu@gmail.com>
2257 * w32font.c (w32_load_unicows_or_gdi32): Add missing return.
2259 2011-10-28 Eli Zaretskii <eliz@gnu.org>
2261 Fix Emacs on Windows 9X (bug#8562). Thanks to oslsachem
2262 <oslsachem@gmail.com> for helping to debug this.
2264 * w32font.c (g_b_init_is_w9x, g_b_init_get_outline_metrics_w)
2265 (g_b_init_get_text_metrics_w, g_b_init_get_glyph_outline_w)
2266 (g_b_init_get_glyph_outline_w): New static variables.
2267 (GetOutlineTextMetricsW_Proc, GetTextMetricsW_Proc)
2268 (GetGlyphOutlineW_Proc): New typedefs.
2269 (w32_load_unicows_or_gdi32, get_outline_metrics_w)
2270 (get_text_metrics_w, get_glyph_outline_w, globals_of_w32font):
2272 (w32font_open_internal, compute_metrics):
2273 Call get_outline_metrics_w, get_text_metrics_w, and get_glyph_outline_w
2274 instead of calling the "wide" APIs directly.
2276 * emacs.c (main) [HAVE_NTGUI]: Call globals_of_w32font.
2278 * w32.h (syms_of_w32font): Add prototype.
2280 2011-10-27 Juanma Barranquero <lekktu@gmail.com>
2282 * window.c (Fframe_root_window, Fframe_first_window, Fwindow_end)
2283 (Fframe_selected_window, Ftemp_output_buffer_show, Fnext_window)
2284 (Fdelete_window_internal, Fwindow_parameters): Fix typos in docstrings.
2285 (Fmove_to_window_line): Doc fix.
2287 2011-10-27 Chong Yidong <cyd@gnu.org>
2289 * process.c (make_process): Set gnutls_state to NULL.
2291 * gnutls.c (emacs_gnutls_deinit): Deinit the gnutls_state if it is
2292 non-NULL, regardless of GNUTLS_INITSTAGE.
2293 (Fgnutls_boot): Cleanups. Call emacs_gnutls_deinit if we signal
2294 an error. Set process slots as soon as we allocate them.
2296 * gnutls.h (GNUTLS_LOG, GNUTLS_LOG2): Fix macros.
2298 2011-10-27 Chong Yidong <cyd@gnu.org>
2300 * gnutls.c (emacs_gnutls_deinit): New function.
2301 Deallocate credentials structures as well as calling gnutls_deinit.
2302 (Fgnutls_deinit, Fgnutls_boot): Use it.
2304 * process.c (make_process): Initialize GnuTLS credentials to NULL.
2305 (deactivate_process): Call emacs_gnutls_deinit.
2307 2011-10-27 Juanma Barranquero <lekktu@gmail.com>
2309 * image.c (x_create_x_image_and_pixmap):
2310 * w32.c (sys_rename, w32_delayed_load):
2311 * w32font.c (fill_in_logfont):
2312 * w32reg.c (x_get_string_resource): Silence compiler warnings.
2314 2011-10-26 Juanma Barranquero <lekktu@gmail.com>
2316 * w32fns.c (w32_default_color_map): New function,
2317 extracted from Fw32_default_color_map.
2318 (Fw32_default_color_map, Fx_open_connection): Use it. (Bug#9785)
2320 2011-10-25 Paul Eggert <eggert@cs.ucla.edu>
2322 * dispextern.h (Fcontrolling_tty_p): New decl (Bug#6649 part 2).
2324 2011-10-25 Stefan Monnier <monnier@iro.umontreal.ca>
2326 * keyboard.c (test_undefined): New function (bug#9751).
2327 (read_key_sequence): Use it to detect when a key is bound to `undefined'.
2329 2011-10-25 Enami Tsugutomo <tsugutomo.enami@jp.sony.com>
2331 * sysdep.c (init_sys_modes): Fix the check for the controlling
2332 terminal (Bug#6649).
2334 2011-10-20 Eli Zaretskii <eliz@gnu.org>
2336 * dispextern.h (struct bidi_it): New member next_en_type.
2338 * bidi.c (bidi_line_init): Initialize the next_en_type member.
2339 (bidi_resolve_explicit_1): When next_en_pos is valid for the
2340 current character, check also for next_en_type being WEAK_EN.
2341 (bidi_resolve_weak): Don't enter the expensive loop if the current
2342 position is before next_en_pos. Record the bidi type of the first
2343 non-ET, non-BN character we find, in addition to its position.
2344 (bidi_level_of_next_char): Invalidate next_en_type when
2345 next_en_pos is over-stepped.
2347 2011-10-20 Paul Eggert <eggert@cs.ucla.edu>
2349 Time zone name fixes for non-ASCII locales (Bug#641, Bug#9794)
2350 * editfns.c: Rewrite current-time-zone so that it invokes
2351 the equivalent of (format-time-string "%Z") to get the time zone name.
2352 This fixes a bug when the time zone name contains characters that
2353 need converting from the system time locale to Emacs internal format.
2354 This fixes a shortcoming that I introduced in my 1999-10-19 patch:
2355 that patch fixed format-time-string to do the conversion, but
2356 I forgot to fix current-time-zone.
2357 (format_time_string): New function, containing most of
2358 what Fformat_time_string used to contain.
2359 (Fformat_time_string): Rewrite in terms of format_time_string.
2360 This doesn't change this function's behavior.
2361 (current-time-zone): Rewrite to use format_time_string.
2362 This fixes the bug reported by Michael Schierl in
2363 <http://lists.gnu.org/archive/html/emacs-devel/2007-06/msg00334.html>.
2364 Jason Rumney's 2007-06-07 change worked around this bug, but
2366 * systime.h (tzname, timezone): Remove no-longer-used declarations.
2368 2011-10-19 Eli Zaretskii <eliz@gnu.org>
2370 * xdisp.c (start_display): If the character at POS is displayed
2371 via a display vector, reset IT->current.dpvec_index to zero.
2372 (try_window_reusing_current_matrix): If a line ends in a display
2373 vector or the next line starts in a display vector, continue
2374 redrawing the window even though the character position of
2375 start_row was reached.
2378 2011-10-18 Chong Yidong <cyd@gnu.org>
2380 * xdisp.c (get_next_display_element): Handle U+2010 and U+2011
2381 with nobreak-char-display too.
2383 2011-10-18 Eli Zaretskii <eliz@gnu.org>
2385 Fix part 3 of bug#9771.
2386 * bidi.c (bidi_line_init): Initialize next_en_pos to zero, not -1.
2387 (bidi_resolve_neutral): Don't enter the expensive loop looking for
2388 non-neutral characters if the current character is a paragraph
2389 separator (a.k.a. Newline). This avoids running the same
2390 expensive loop twice, once when we consume the preceding newline
2391 and the other time when the line actually needs to be displayed.
2392 Avoid the loop when we see neutrals on the base embedding level
2393 following a character whose directionality is the same as the
2394 paragraph's. This avoids running the expensive loop when a line
2395 ends in a long sequence of neutrals, like control characters.
2396 Add assertion against STRONG_AL type. Slightly rearrange code
2397 that determines the type of a neutral given the first non-neutral
2399 (bidi_level_of_next_char): Set next_en_pos to zero when
2400 invalidating its info.
2402 2011-10-17 Eli Zaretskii <eliz@gnu.org>
2404 * xdisp.c (push_display_prop): Determine whether to record string
2405 or buffer position by IT->string, not by IT->method. Allow
2406 GET_FROM_DISPLAY_VECTOR as IT->method on entry. (Bug#9771, part 4)
2407 (move_it_vertically_backward): Don't look for character position
2408 immediately after the newline when in a continuation line.
2411 2011-10-15 Martin Rudalics <rudalics@gmx.at>
2413 * window.c (coordinates_in_window): Rewrite and delabelize
2414 vertical border check. (Bug#5357) (Bug#9618)
2416 2011-10-14 Stefan Monnier <monnier@iro.umontreal.ca>
2418 * xterm.c (frame_highlight, frame_unhighlight): Ignore unexplained
2419 errors in XSetWindowBorder (bug#9310).
2421 2011-10-13 Dmitry Antipov <dmantipov@yandex.ru>
2423 * editfns.c (Fset_time_zone_rule): Replace free with xfree to
2424 avoid crash when xmalloc overrun checking is enabled.
2426 2011-10-13 Eli Zaretskii <eliz@gnu.org>
2428 * xdisp.c (Fcurrent_bidi_paragraph_direction): Initialize
2429 itb.paragraph_dir to NEUTRAL_DIR. Fixes an occasional incorrect
2430 cursor motion with <left> and <right> arrow keys.
2432 * bidi.c (bidi_init_it): Don't initialize paragraph_dir here, as
2433 some callers set that themselves.
2435 2011-10-12 Eli Zaretskii <eliz@gnu.org>
2437 * xdisp.c (find_row_edges): Handle the case where ROW comes from a
2438 display string and the previous row comes from the same string and
2439 is empty. (Bug#9739) (Bug#9738)
2441 2011-10-12 Stefan Monnier <monnier@iro.umontreal.ca>
2443 * doc.c (get_doc_string): Encode file name (bug#9735).
2445 2011-10-12 Eli Zaretskii <eliz@gnu.org>
2447 * bidi.c (bidi_level_of_next_char):
2448 * xdisp.c (get_visually_first_element): Remove old incorrect
2449 comments regarding the Unicode Line Separator character.
2451 * bidi.c (bidi_init_it): Initialize paragraph_dir to NEUTRAL_DIR.
2453 2011-10-12 Dmitry Antipov <dmantipov@yandex.ru>
2455 * alloc.c (Fgc_status): Do not access beyond zombies array
2456 boundary if nzombies > MAX_ZOMBIES.
2457 * alloc.c (dump_zombies): Add missing format specifier.
2459 2011-10-12 Paul Eggert <eggert@cs.ucla.edu>
2461 * xdisp.c (set_cursor_from_row): Simplify conditionals,
2462 to pacify GCC 4.6.1 x86-64 with -O2 -Wstrict-overflow.
2464 * lread.c (read_escape): Allow hex escapes as large as ?\xfffffff.
2465 Some packages use them to denote characters with modifiers.
2467 2011-10-11 Andreas Schwab <schwab@linux-m68k.org>
2469 * lisp.h (GCPRO1_VAR, GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR)
2470 (GCPRO5_VAR, GCPRO6_VAR, UNGCPRO_VAR): Add whitespace to avoid
2471 matching a pp-number. Rename parameter var to var1.
2473 2011-10-11 Stefan Monnier <monnier@iro.umontreal.ca>
2475 * minibuf.c (Finternal_complete_buffer): Fix last change (bug#9709).
2477 2011-10-08 Glenn Morris <rgm@gnu.org>
2479 * callint.c (Fcall_interactively): Give a more explicit error for the
2480 'c' case with a non-character input. (Bug#8479)
2482 2011-10-08 Eli Zaretskii <eliz@gnu.org>
2484 * xdisp.c (hscroll_window_tree): Support hscroll in right-to-left
2486 (set_cursor_from_row): Fix cursor positioning in mixed L2R+R2L
2487 lines that are hscrolled on the left.
2489 * dispnew.c (buffer_posn_from_coords): Account for a possible
2490 presence of header-line. (Bug#4426)
2492 2011-10-07 Stefan Monnier <monnier@iro.umontreal.ca>
2494 * buffer.c (syms_of_buffer) <enable-multibyte-characters>:
2495 Don't advertise functionality which we discourage or doesn't work.
2497 2011-10-07 Paul Eggert <eggert@cs.ucla.edu>
2499 * alloc.c (GC_LISP_OBJECT_ALIGNMENT): Use offsetof, not __alignof__
2500 or sizeof. __alignof__ gives the wrong answer on Fedora x86-64
2501 with GCC 4.6.1 when configured with CC='gcc -m32' --with-wide-int;
2502 this makes Emacs dump core during garbage collection on rare
2503 occasions. sizeof is obviously inferior to offsetof here, so
2504 stick with offsetof.
2505 (GC_POINTER_ALIGNMENT): New macro.
2506 (mark_memory): Omit 3rd (offset) arg; caller changed.
2507 Don't assume EMACS_INT alignment is the same as pointer alignment.
2509 2011-10-03 Stefan Monnier <monnier@iro.umontreal.ca>
2511 * keyboard.c (read_key_sequence_remapped): New var.
2512 (read_key_sequence): Compute remapping in the right buffer.
2513 (command_loop_1): Use read_key_sequence's remapping directly.
2515 2011-10-02 Stefan Monnier <monnier@iro.umontreal.ca>
2517 * dired.c (file_name_completion): Don't expand file name.
2518 (Ffile_name_completion, Ffile_name_all_completions): Expand file name
2519 before checking file name handler.
2521 * minibuf.c (Finternal_complete_buffer): Only show internal buffers if
2522 they've been requested explicitly (bug#9591).
2524 2011-10-01 Andreas Schwab <schwab@linux-m68k.org>
2526 * keymap.c (Fsingle_key_description): Use make_specified_string
2527 instead of build_string to build string from push_key_description.
2530 2011-09-30 Paul Eggert <eggert@cs.ucla.edu>
2532 * buffer.h (struct buffer): Use time_t, not int, for a time stamp.
2533 This fixes a Y2038 bug on 64-bit hosts.
2534 * buffer.c (reset_buffer):
2535 * fileio.c (Fdo_auto_save, Fset_buffer_auto_saved)
2536 (Fclear_buffer_auto_save_failure):
2537 Use 0, not -1, to represent an unset failure time, since time_t
2538 might not be signed.
2540 Remove dependency on glibc malloc internals.
2541 * alloc.c (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
2542 Move back here from lisp.h, but with their new implementations.
2543 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
2544 (XMALLOC_OVERRUN_SIZE_SIZE): Move these new lisp.h macros here.
2545 * charset.c (charset_table_init): New static var.
2546 (syms_of_charset): Use it instead of xmalloc. This removes a
2547 dependency on glibc malloc internals. See Eli Zaretskii's comment in
2548 <http://lists.gnu.org/archive/html/emacs-devel/2011-09/msg00815.html>.
2549 * lisp.h (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
2550 Move back to alloc.c.
2551 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
2552 (XMALLOC_OVERRUN_SIZE_SIZE): Move to alloc.c.
2554 2011-09-30 Jan Djärv <jan.h.d@swipnet.se>
2556 * nsterm.m (windowDidResize): Call x_set_window_size only when
2557 ns_in_resize is true. Otherwise set pixelwidth/height and
2558 call change_frame_size (Bug#9628).
2560 2011-09-30 Paul Eggert <eggert@cs.ucla.edu>
2562 Port --enable-checking=all to Fedora 14 x86-64.
2563 * charset.c (syms_of_charset): Also account for glibc malloc's
2564 internal overhead when calculating the initial malloc maximum.
2566 Port --enable-checking=all to Fedora 14 x86.
2567 * alloc.c (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
2569 (xmalloc_put_size, xmalloc_get_size, overrun_check_malloc)
2570 (overrun_check_realloc, overrun_check_free):
2571 Use XMALLOC_OVERRUN_SIZE_SIZE, not sizeof (size_t).
2572 That way, xmalloc returns a properly-aligned pointer even if
2573 XMALLOC_OVERRUN_CHECK is defined. The old debugging code happened
2574 to align OK on typical 64-bit hosts, but not on Fedora 14 x86.
2575 * charset.c (syms_of_charset): Take XMALLOC_OVERRUN_CHECK_OVERHEAD
2576 into account when calculating the initial malloc maximum.
2577 * lisp.h (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
2578 Move here from alloc.c, so that charset.c can use it too.
2579 Properly align; the old code wasn't right for common 32-bit hosts
2580 when configured with --enable-checking=all.
2581 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
2582 (XMALLOC_OVERRUN_SIZE_SIZE): New macros.
2584 2011-09-29 Eli Zaretskii <eliz@gnu.org>
2586 * sysdep.c (snprintf) [!EOVERFLOW]: If EOVERFLOW is not defined,
2589 2011-09-28 Eli Zaretskii <eliz@gnu.org>
2591 * xdisp.c (compute_display_string_end): If there's no display
2592 string at CHARPOS, return -1.
2594 * bidi.c (bidi_fetch_char): When compute_display_string_end
2595 returns a negative value, treat the character as a normal
2596 character not covered by a display string. (Bug#9624)
2598 2011-09-28 Juanma Barranquero <lekktu@gmail.com>
2600 * lread.c (Fread_from_string): Fix typo in docstring.
2602 2011-09-27 Eli Zaretskii <eliz@gnu.org>
2604 * xdisp.c (handle_invisible_prop): If invisible text ends on a
2605 newline, reseat the iterator instead of bidi-iterating there one
2606 character at a time. (Bug#9610)
2607 (BUFFER_POS_REACHED_P, move_it_in_display_line_to): Bail when past
2608 TO_CHARPOS if the bidi iterator is at base embedding level.
2610 2011-09-27 Andreas Schwab <schwab@linux-m68k.org>
2612 * lread.c (readevalloop): Use correct code for NBSP.
2613 (read1): Likewise. (Bug#9608)
2615 2011-09-25 Michael Albinus <michael.albinus@gmx.de>
2617 * dbusbind.c (Fdbus_register_signal): When service is not
2618 registered, use nil in Vdbus_registered_objects_table. (Bug#9581)
2620 2011-09-25 Glenn Morris <rgm@gnu.org>
2622 * buffer.c (truncate-lines): Doc fix.
2624 2011-09-24 Chong Yidong <cyd@stupidchicken.com>
2626 * window.c (Fwindow_prev_buffers, Fset_window_prev_buffers)
2627 (Fset_window_next_buffers): Doc fix.
2629 2011-09-24 Glenn Morris <rgm@gnu.org>
2631 * minibuf.c (read_minibuf): Disable line truncation. (Bug#5715)
2633 2011-09-24 Paul Eggert <eggert@cs.ucla.edu>
2635 Fix minor problems found by static checking.
2636 * xdisp.c (string_from_display_spec): Don't assume vecsize fits in int.
2637 * indent.c (Fvertical_motion): Fix == vs = typo.
2639 2011-09-24 Eli Zaretskii <eliz@gnu.org>
2641 * dispnew.c (syms_of_display) <redisplay-dont-pause>:
2642 Default value is now t. Doc fix.
2644 * indent.c (Fvertical_motion): Compute and apply the overshoot
2645 logic when moving up, not only when moving down. Fix the
2646 confusing name and values of the it_overshoot_expected variable;
2647 logic changes accordingly. (Bug#9254) (Bug#9549)
2649 * xdisp.c (pos_visible_p): Produce correct pixel coordinates when
2650 CHARPOS is covered by a display string which includes newlines.
2651 (move_it_vertically_backward): Avoid inflooping when START_CHARPOS
2652 is covered by a display string with embedded newlines.
2654 2011-09-24 Michael Albinus <michael.albinus@gmx.de>
2656 * dbusbind.c (Fdbus_register_signal): Add match rule to
2657 Vdbus_registered_objects_table. (Bug#9581)
2658 (Fdbus_register_method, Vdbus_registered_objects_table):
2661 2011-09-24 Jim Meyering <meyering@redhat.com>
2663 do not ignore write error for any output size
2664 The previous change was incomplete.
2665 While it makes emacs --batch detect the vast majority of stdout
2666 write failures, errors were still ignored whenever the output size is
2667 k * (BUFSIZ+1) - 4. E.g., on a system with BUFSIZ of 4096,
2668 $ emacs --batch --eval '(print (format "%4093d" 0))' > /dev/full \
2669 && echo FAIL: ignored write error
2670 FAIL: ignored write error
2671 $ emacs --batch --eval '(print (format "%20481d" 0))' > /dev/full \
2672 && echo FAIL: ignored write error
2673 FAIL: ignored write error
2674 * emacs.c (Fkill_emacs): Also test ferror. (Bug#9574)
2676 2011-09-23 Andreas Schwab <schwab@linux-m68k.org>
2678 * emacs.c (Fkill_emacs): In noninteractive mode exit
2679 non-successfully if a write error occurred on stdout. (Bug#9574)
2681 2011-09-21 Eli Zaretskii <eliz@gnu.org>
2683 * xdisp.c (pop_it): Allow it->object that is a cons cell to pass
2686 * dispextern.h (struct it): Update the comment documenting what
2689 2011-09-20 Eli Zaretskii <eliz@gnu.org>
2691 * xdisp.c (set_cursor_from_row): If the row ends in a newline from
2692 a display string, extend search for cursor position to end of row.
2693 (find_row_edges): If the row ends in a newline from a display
2694 string, increment its MATRIX_ROW_END_CHARPOS by one. (Bug#9549)
2695 Handle the case of a display string with multiple newlines.
2696 (Fcurrent_bidi_paragraph_direction): Fix search for previous
2697 non-empty line. Fixes confusing cursor motion with arrow keys at
2698 the beginning of a line that starts with whitespace.
2700 2011-09-19 Lars Magne Ingebrigtsen <larsi@gnus.org>
2702 * lread.c (Fread_from_string): Document what FINAL-STRING-INDEX is
2705 2011-09-18 Chong Yidong <cyd@stupidchicken.com>
2707 * xfns.c (Fx_create_frame): Handle the bitmapIcon resource as
2710 2011-09-18 Eli Zaretskii <eliz@gnu.org>
2712 * xdisp.c (display_line): Record maximum and minimum buffer
2713 positions even if no glyphs were produced (e.g., by a zero-width
2714 stretch). Fixes bug#9530 on a TTY. Under word-wrap, don't record
2715 buffer positions that will be removed from the glyph row because
2717 (produce_stretch_glyph): Fix a bug in :align-to on a TTY when the
2718 column is beyond frame width: don't subtract 1 "pixel" when
2719 computing width of the stretch.
2720 (reseat_at_next_visible_line_start): Undo the change made on
2721 2011-09-17 that saved paragraph information and restored it after
2722 the call to `reseat'. (Bug#9545)
2724 2011-09-18 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
2726 * xdisp.c (expose_window): Save original value of phys_cursor_on_p
2727 and turn window cursor on if cleared (Bug#9415).
2729 2011-09-18 Andreas Schwab <schwab@linux-m68k.org>
2731 * search.c (boyer_moore): Take unibyte characters from pattern
2732 literally. (Bug#9458)
2734 2011-09-18 Eli Zaretskii <eliz@gnu.org>
2736 * xdisp.c (reseat_at_next_visible_line_start): Fix last change.
2738 2011-09-18 Paul Eggert <eggert@cs.ucla.edu>
2740 Fix minor problem found by static checking.
2741 * xdisp.c (reseat_at_next_visible_line_start): Mark locals as
2742 initialized, to pacify gcc -Wuninitialized.
2744 * fileio.c: Report proper errno when syscall falls.
2745 (Finsert_file_contents): Save and restore errno,
2746 so that report_file_error outputs the correct diagnostic.
2747 (Fwrite_region) [CLASH_DETECTION]: Likewise.
2749 2011-09-18 Eli Zaretskii <eliz@gnu.org>
2751 * .gdbinit (pgx): Fix references to fields of `struct glyph'.
2753 2011-09-17 Eli Zaretskii <eliz@gnu.org>
2755 * xdisp.c (produce_stretch_glyph): Another fix for changes made on
2756 2011-08-30T17:32:44Z!eliz@gnu.org. (Bug#9530)
2758 2011-09-17 Eli Zaretskii <eliz@gnu.org>
2760 * xdisp.c (reseat_at_next_visible_line_start): Keep information
2761 about the current paragraph and restore it after the call to reseat.
2763 * bidi.c (MAX_PARAGRAPH_SEARCH): New macro.
2764 (bidi_find_paragraph_start): Search back for paragraph beginning
2765 at most MAX_PARAGRAPH_SEARCH lines; if not found, return BEGV_BYTE.
2766 (bidi_move_to_visually_next): Only trigger paragraph-related
2767 computations when the last character is a newline or at EOB, not
2768 just any NEUTRAL_B. (Bug#9470)
2770 * xdisp.c (set_cursor_from_row): Don't invoke special treatment of
2771 truncated lines if point is covered by a display string. (Bug#9524)
2773 2011-09-16 Paul Eggert <eggert@cs.ucla.edu>
2775 * xselect.c: Relax test for outgoing X longs (Bug#9498).
2776 (cons_to_x_long): New function.
2777 (lisp_data_to_selection_data): Use it. Correct the test for
2778 short-versus-long data; it was negated. Break out of vector
2779 loop, for efficiency, when a long datum is discovered.
2781 2011-09-16 Stefan Monnier <monnier@iro.umontreal.ca>
2783 * eval.c (Fquote): Document its non-consing behavior (bug#9482).
2785 2011-09-16 Eli Zaretskii <eliz@gnu.org>
2787 * image.c (tiff_handler): Work around a bug in MinGW GCC 3.x (see
2788 GCC PR/17406) by declaring this function with external scope.
2790 2011-09-15 Paul Eggert <eggert@cs.ucla.edu>
2792 * editfns.c (Fformat): Fix bug in text-property fix (Bug#9514).
2793 Don't mishandle (length (format "%%")) and (format "%4000s%%" "").
2795 2011-09-15 Andreas Schwab <schwab@linux-m68k.org>
2797 * editfns.c (Fformat): Correctly handle text properties on "%%".
2799 2011-09-15 Eli Zaretskii <eliz@gnu.org>
2801 * xterm.c (x_draw_composite_glyph_string_foreground):
2802 * w32term.c (x_draw_composite_glyph_string_foreground):
2803 * term.c (encode_terminal_code):
2804 * composite.c (composition_update_it, get_composition_id):
2805 * xdisp.c (get_next_display_element)
2806 (fill_composite_glyph_string): Add comments about special meaning
2807 of TAB characters in a composition.
2809 2011-09-15 Paul Eggert <eggert@cs.ucla.edu>
2811 * editfns.c (Fformat): Fix off-by-1 bug for "%%b" (Bug#9514).
2812 This occurs when processing a multibyte format.
2813 Problem reported by Wolfgang Jenker.
2815 2011-09-15 Johan Bockgård <bojohan@gnu.org>
2817 * xdisp.c (try_cursor_movement): Only check for exact match if
2818 cursor hpos found by set_cursor_from_row is valid. (Bug#9495)
2820 2011-09-14 Paul Eggert <eggert@cs.ucla.edu>
2822 Remove unused external symbols.
2823 * dispextern.h (calc_pixel_width_or_height): Remove decl.
2824 * xdisp.c (calc_pixel_width_or_height): Now static.
2825 * doprnt.c (exprintf) [! (HAVE_X_WINDOWS && USE_X_TOOLKIT)]: Remove.
2826 * indent.c (check_display_width):
2827 * w32term.c: Fix comment to match code.
2828 * xterm.c, xterm.h (x_catching_errors): Remove.
2830 2011-09-14 Paul Eggert <eggert@cs.ucla.edu>
2832 * xselect.c: Use signed conversions more consistently (Bug#9498).
2833 (selection_data_to_lisp_data): Assume incoming selection data are
2834 signed integers, not unsigned. This is to be consistent with
2835 outgoing selection data, which was modified to use signed integers
2836 in as part of the fix to Bug#9196 in response to Jan D.'s comment
2837 in <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9196#32> that X11
2838 expects long, not unsigned long.
2840 2011-09-14 Eli Zaretskii <eliz@gnu.org>
2842 * xdisp.c (try_window_reusing_current_matrix): Fix incorrect
2843 computation of loop end. Reported by Johan Bockgård
2846 2011-09-13 Chong Yidong <cyd@stupidchicken.com>
2848 * frame.c (Fother_visible_frames_p): Function deleted.
2850 2011-09-12 Eli Zaretskii <eliz@gnu.org>
2852 * indent.c (compute_motion): Process display vector front to back
2853 rather than the other way around. (Bug#2496)
2855 2011-09-12 Stefan Monnier <monnier@iro.umontreal.ca>
2857 * fileio.c (Finsert_file_contents): Don't assume beg_offset is 0.
2859 2011-09-11 Chong Yidong <cyd@stupidchicken.com>
2861 * minibuf.c (Fread_from_minibuffer): Doc fix.
2863 2011-09-11 Eli Zaretskii <eliz@gnu.org>
2865 * xdisp.c (produce_stretch_glyph): Fix a typo made in changes from
2866 2011-08-30T17:32:44Z!eliz@gnu.org. (Bug#9475)
2868 2011-09-11 Lars Magne Ingebrigtsen <larsi@gnus.org>
2870 * fileio.c (Fvisited_file_modtime): Document `(-1 65535)' as a
2871 value for non-existent files.
2873 2011-09-11 Eli Zaretskii <eliz@gnu.org>
2875 * fileio.c (Finsert_file_contents): If the file cannot be opened,
2876 set its "size" to -1. This will set the modtime_size field of
2877 the corresponding buffer to -1, which is what
2878 verify-visited-file-modtime expects for files that do not exist.
2881 2011-09-11 Paul Eggert <eggert@cs.ucla.edu>
2883 * keymap.h (KEY_DESCRIPTION_SIZE, push_key_description): Move decls
2885 * lisp.h: ... from here. push_key_description is no longer
2886 defined in keyboard.c, so its declaration should not be in
2887 lisp.h's "Defined in keyboard.c" section, and KEY_DESCRIPTION_SIZE
2888 logically belongs with push_key_description.
2890 2011-09-10 Paul Eggert <eggert@cs.ucla.edu>
2892 * buffer.h: Include <sys/types.h> instead of <time.h>.
2893 Otherwise, off_t wasn't defined on FreeBSD 9.0-BETA2 i386.
2894 Problem reported by Herbert J. Skuhra.
2896 2011-09-10 Lars Magne Ingebrigtsen <larsi@gnus.org>
2898 * xml.c (parse_region): Make the parsing work for
2899 non-comment-starting XML files again (bug#9144).
2901 2011-09-10 Andreas Schwab <schwab@linux-m68k.org>
2903 * image.c (gif_load): Fix calculation of bottom and right corner.
2906 2011-09-10 Eli Zaretskii <eliz@gnu.org>
2908 * xdisp.c (MAX_DISP_SCAN): Decrease to 250. Prevents sluggish
2909 redisplay in small windows.
2911 2011-09-09 Eli Zaretskii <eliz@gnu.org>
2913 * frame.c (x_report_frame_params): Cast to avoid compiler warnings.
2915 2011-09-08 Martin Rudalics <rudalics@gmx.at>
2917 * window.c (Fset_window_prev_buffers, Fset_window_next_buffers):
2918 Operate on live windows only.
2920 2011-09-08 Juanma Barranquero <lekktu@gmail.com>
2922 * emacs.c (my_heap_start): #ifdef to avoid warnings when unused.
2924 2011-09-07 Eli Zaretskii <eliz@gnu.org>
2926 * xdisp.c (move_it_in_display_line_to): Call RESTORE_IT on ppos_it
2927 only under bidi iteration.
2929 2011-09-07 Jan Djärv <jan.h.d@swipnet.se>
2931 * gtkutil.c (xg_make_tool_item): Insert comment about eventbox.
2933 2011-09-06 Paul Eggert <eggert@cs.ucla.edu>
2935 isnan: Fix porting problem to Solaris 10 with bundled gcc.
2936 Without this fix, the command to link temacs failed due to an
2937 undefined symbol __builtin_isnan. This is because
2938 /usr/include/iso/math_c99.h #defines isnan(x) to
2939 __builtin_isnan(x), but the bundled gcc, which identifies itself
2940 as gcc 3.4.3 (csl-sol210-3_4-branch+sol_rpath), does not have
2942 * floatfns.c (isnan): #undef, and then #define to a clone of
2944 (Fisnan): Always define, since it's always available now.
2945 (syms_of_floatfns): Always define isnan at the Lisp level.
2947 2011-09-06 Paul Eggert <eggert@cs.ucla.edu>
2949 * Makefile.in (gl-stamp): move-if-change now in build-aux (Bug#9169).
2951 2011-09-06 Paul Eggert <eggert@cs.ucla.edu>
2953 * fileio.c: Fix bugs with large file offsets (Bug#9428).
2954 The previous code assumed that file offsets (off_t values) fit in
2955 EMACS_INT variables, which is not true on typical 32-bit hosts.
2956 The code messed up by falsely reporting buffer overflow in cases
2957 such as (insert-file-contents "big" nil 1 2) into an empty buffer
2958 when "big" contains more than 2**29 bytes, even though this
2959 inserts just one byte and does not overflow the buffer.
2960 (Finsert_file_contents): Store file offsets as off_t
2961 values, not as EMACS_INT values. Check for overflow when
2962 converting between EMACS_INT and off_t. When checking for
2963 buffer overflow or for overlap, take the offsets into account.
2964 Don't use EMACS_INT for small values where int suffices.
2965 When checking for overlap, fix a typo: ZV was used where
2966 ZV_BYTE was intended.
2967 (Fwrite_region): Don't assume off_t fits into 'long'.
2968 * buffer.h (struct buffer.modtime_size): Now off_t, not EMACS_INT.
2970 2011-09-05 Michael Albinus <michael.albinus@gmx.de>
2972 * dbusbind.c (xd_signature_cat): Rename from signature_cat.
2974 2011-09-04 Paul Eggert <eggert@cs.ucla.edu>
2976 sprintf-related integer and memory overflow issues (Bug#9412).
2978 * doprnt.c (doprnt): Support printing ptrdiff_t and intmax_t values.
2979 (esprintf, exprintf, evxprintf): New functions.
2980 * keyboard.c (command_loop_level): Now EMACS_INT, not int.
2981 (cmd_error): Kbd macro iterations count is now EMACS_INT, not int.
2982 (modify_event_symbol): Do not assume that the length of
2983 name_alist_or_stem is safe to alloca and fits in int.
2984 (Fexecute_extended_command): Likewise for function name and binding.
2985 (Frecursion_depth): Wrap around reliably on integer overflow.
2986 * keymap.c (push_key_description): First arg is now EMACS_INT, not int,
2987 since some callers pass EMACS_INT values.
2988 (Fsingle_key_description): Don't crash if symbol name contains more
2989 than MAX_ALLOCA bytes.
2990 * minibuf.c (minibuf_level): Now EMACS_INT, not int.
2991 (get_minibuffer): Arg is now EMACS_INT, not int.
2992 * lisp.h (get_minibuffer, push_key_description): Reflect API changes.
2993 (esprintf, exprintf, evxprintf): New decls.
2994 * window.h (command_loop_level, minibuf_level): Reflect API changes.
2996 * dbusbind.c (signature_cat): New function.
2997 (xd_signature, Fdbus_register_signal):
2998 Do not overrun buffer; instead, report string overflow.
3000 * dispnew.c (add_window_display_history): Don't overrun buffer.
3001 Truncate instead; this is OK since it's just a log.
3003 * editfns.c (Fcurrent_time_zone): Don't overrun buffer
3004 even if the time zone offset is outlandishly large.
3005 Don't mishandle offset == INT_MIN.
3007 * emacs.c (main) [NS_IMPL_COCOA]: Don't overrun buffer
3008 when creating daemon; the previous buffer-overflow check was incorrect.
3010 * eval.c (verror): Simplify by rewriting in terms of evxprintf,
3011 which has the guts of the old verror function.
3013 * filelock.c (lock_file_1, lock_file): Don't blindly alloca long name;
3014 use SAFE_ALLOCA instead. Use esprintf to avoid int-overflow issues.
3016 * font.c: Include <float.h>, for DBL_MAX_10_EXP.
3017 (font_unparse_xlfd): Don't blindly alloca long strings.
3018 Don't assume XINT result fits in int, or that XFLOAT_DATA * 10
3019 fits in int, when using sprintf. Use single snprintf to count
3020 length of string rather than counting it via multiple sprintfs;
3021 that's simpler and more reliable.
3022 (font_unparse_fcname): Use it to avoid sprintf buffer overrun.
3023 (generate_otf_features) [0 && HAVE_LIBOTF]: Use esprintf, not
3024 sprintf, in case result does not fit in int.
3026 * fontset.c (num_auto_fontsets): Now printmax_t, not int.
3027 (fontset_from_font): Print it.
3029 * frame.c (tty_frame_count): Now printmax_t, not int.
3030 (make_terminal_frame, set_term_frame_name): Print it.
3031 (x_report_frame_params): In X, window IDs are unsigned long,
3032 not signed long, so print them as unsigned.
3033 (validate_x_resource_name): Check for implausibly long names,
3034 and don't assume name length fits in 'int'.
3035 (x_get_resource_string): Don't blindly alloca invocation name;
3036 use SAFE_ALLOCA. Use esprintf, not sprintf, in case result does
3039 * gtkutil.c: Include <float.h>, for DBL_MAX_10_EXP.
3040 (xg_check_special_colors, xg_set_geometry):
3041 Make sprintf buffers a bit bigger, to avoid potential buffer overrun.
3043 * lread.c (dir_warning): Don't blindly alloca buffer; use SAFE_ALLOCA.
3044 Use esprintf, not sprintf, in case result does not fit in int.
3046 * macros.c (executing_kbd_macro_iterations): Now EMACS_INT, not int.
3047 (Fend_kbd_macro): Don't mishandle MOST_NEGATIVE_FIXNUM by treating
3048 it as a large positive number.
3049 (Fexecute_kbd_macro): Don't assume repeat count fits in int.
3050 * macros.h (executing_kbd_macro_iterations): Now EMACS_INT, not int.
3052 * nsterm.m ((NSSize)windowWillResize): Use esprintf, not sprintf,
3053 in case result does not fit in int.
3055 * print.c (float_to_string): Detect width overflow more reliably.
3056 (print_object): Make sprintf buffer a bit bigger, to avoid potential
3057 buffer overrun. Don't assume list length fits in 'int'. Treat
3058 print length of 0 as 0, not as infinity; to be consistent with other
3059 uses of print length in this function. Don't overflow print length
3060 index. Don't assume hash table size fits in 'long', or that
3061 vectorlike size fits in 'unsigned long'.
3063 * process.c (make_process): Use printmax_t, not int, to format
3064 process-name gensyms.
3066 * sysdep.c (snprintf) [! HAVE_SNPRINTF]: New function.
3068 * term.c (produce_glyphless_glyph): Make sprintf buffer a bit bigger
3069 to avoid potential buffer overrun.
3071 * xfaces.c (x_update_menu_appearance): Don't overrun buffer
3072 if X resource line is longer than 512 bytes.
3074 * xfns.c (x_window): Make sprintf buffer a bit bigger
3075 to avoid potential buffer overrun.
3077 * xterm.c (x_io_error_quitter): Don't overrun sprintf buffer.
3079 * xterm.h (x_check_errors): Add ATTRIBUTE_FORMAT_PRINTF.
3081 2011-09-04 Paul Eggert <eggert@cs.ucla.edu>
3083 Integer overflow fixes for scrolling, etc.
3084 Without these, Emacs silently mishandles large integers sometimes.
3085 For example, "C-u 4294967297 M-x recenter" was treated as if
3086 it were "C-u 1 M-x recenter" on a typical 64-bit host.
3088 * xdisp.c (try_window_id): Check Emacs fixnum range before
3089 converting to 'int'.
3091 * window.c (window_scroll_line_based, Frecenter):
3092 Check that an Emacs fixnum is in range before assigning it to 'int'.
3093 (Frecenter, Fmove_to_window_line): Use EMACS_INT, not int, for
3094 values converted from Emacs fixnums.
3095 (Frecenter): Don't wrap around a line count if it is out of 'int'
3096 range; instead, treat it as an extreme value.
3097 (Fset_window_configuration, compare_window_configurations):
3098 Use ptrdiff_t, not int, for index that might exceed 2 GiB.
3100 * search.c (Freplace_match): Use ptrdiff_t, not int, for indexes
3101 that can exceed INT_MAX. Check that EMACS_INT value is in range
3102 before assigning it to the (possibly-narrower) index.
3103 (match_limit): Don't assume that a fixnum can fit in 'int'.
3105 * print.c (print_object): Use ptrdiff_t, not int, for index that can
3108 * indent.c (position_indentation): Now takes ptrdiff_t, not int.
3109 (Fvertical_motion): Don't wrap around LINES values that don't fit
3110 in 'int'. Instead, treat them as extreme values. This is good
3111 enough for windows, which can't have more than INT_MAX lines anyway.
3113 2011-09-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
3115 * Require libxml/parser.h to avoid compilation warning.
3117 * emacs.c (shut_down_emacs): Call xmlCleanupParser on shutdown.
3119 * xml.c (parse_region): Don't call xmlCleanupParser after parsing,
3120 since this reportedly can destroy thread storage.
3122 2011-08-30 Chong Yidong <cyd@stupidchicken.com>
3124 * syntax.c (find_defun_start): Update all cache variables if
3125 exiting early (Bug#9401).
3127 2011-08-30 Eli Zaretskii <eliz@gnu.org>
3129 * image.c (x_bitmap_pixmap): Cast to int to avoid compiler warnings.
3131 * xdisp.c (produce_stretch_glyph): No longer static, compiled also
3132 when HAVE_WINDOW_SYSTEM is not defined. Support both GUI and TTY
3133 frames. Call tty_append_glyph in the TTY case. (Bug#9402)
3135 * term.c (tty_append_glyph): New function.
3136 (produce_stretch_glyph): Static function and its prototype deleted.
3138 * dispextern.h (produce_stretch_glyph, tty_append_glyph):
3141 2011-08-29 Paul Eggert <eggert@cs.ucla.edu>
3143 * image.c (parse_image_spec): Check for nonnegative, not for positive,
3144 when checking :margin (Bug#9390).
3145 (IMAGE_NON_NEGATIVE_INTEGER_VALUE_OR_PAIR):
3146 Rename from IMAGE_POSITIVE_INTEGER_VALUE_OR_PAIR,
3147 so that the name doesn't mislead. All uses changed.
3149 2011-08-28 Johan Bockgård <bojohan@gnu.org>
3151 * term.c (init_tty) [HAVE_GPM]: Move mouse settings after
3154 2011-08-27 Eli Zaretskii <eliz@gnu.org>
3156 * xdisp.c (move_it_to): Don't bail out early when reaching
3157 position beyond to_charpos, if we are scanning backwards.
3158 (move_it_vertically_backward): When DY == 0, make sure we get to
3159 the first character in the line after the newline.
3161 2011-08-27 Paul Eggert <eggert@cs.ucla.edu>
3163 * ccl.c: Improve and simplify overflow checking (Bug#9196).
3164 (ccl_driver): Do not generate an out-of-range pointer.
3165 (Fccl_execute_on_string): Remove unnecessary check for
3166 integer overflow, noted by Stefan Monnier in
3167 <http://lists.gnu.org/archive/html/emacs-devel/2011-08/msg00979.html>.
3168 Remove a FIXME that didn't need fixing.
3169 Simplify the newly-introduced buffer reallocation code.
3171 2011-08-27 Juanma Barranquero <lekktu@gmail.com>
3173 * makefile.w32-in ($(BLD)/alloc.$(O)): Depend on lib/verify.h.
3175 2011-08-26 Paul Eggert <eggert@cs.ucla.edu>
3177 Integer and memory overflow issues (Bug#9196).
3179 * doc.c (get_doc_string): Rework so that
3180 get_doc_string_buffer_size is the actual buffer size, rather than
3181 being 1 less than the actual buffer size; this makes xpalloc more
3184 * image.c (x_allocate_bitmap_record, cache_image):
3185 * xselect.c (Fx_register_dnd_atom):
3186 Simplify previous changes by using xpalloc.
3188 * buffer.c (overlay_str_len): Now ptrdiff_t, not EMACS_INT,
3189 since either will do and ptrdiff_t is convenient with xpalloc.
3191 * charset.c (charset_table_size)
3192 (struct charset_sort_data.priority): Now ptrdiff_t.
3193 (charset_compare): Don't overflow if priorities differ greatly.
3194 (Fsort_charsets): Don't assume list length fits in int.
3195 Check for size-calculation overflow when allocating sort data.
3196 (syms_of_charset): Allocate an initial charset table that is
3197 just under 64 KiB, to avoid problems with glibc malloc and mmap.
3199 * cmds.c (internal_self_insert): Check for size-calculation overflow.
3201 * composite.h (struct composition.glyph_len): Now int, not unsigned.
3202 The actual value is always <= INT_MAX, and leaving it unsigned made
3203 overflow checking harder.
3205 * dispextern.h (struct glyph_matrix.rows_allocated)
3206 (struct face_cache.size): Now ptrdiff_t, for convenience in use
3207 with xpalloc. The values are still always <= INT_MAX.
3209 * indent.c (compute_motion): Adjust to region_cache_forward sig change.
3211 * lisp.h (xnmalloc, xnrealloc, xpalloc): New decls.
3212 (SAFE_NALLOCA): New macro.
3214 * region-cache.c (struct boundary.pos, find_cache_boundary)
3215 (move_cache_gap, insert_cache_boundary, delete_cache_boundaries)
3216 (set_cache_region, invalidate_region_cache)
3217 (revalidate_region_cache, know_region_cache, region_cache_forward)
3218 (region_cache_backward, pp_cache):
3219 Use ptrdiff_t, not EMACS_INT, since either will do. This is needed
3220 so that ptrdiff_t * can be passed to xpalloc.
3221 (struct region_cache): Similarly, for gap_start, gap_len, cache_len,
3222 beg_unchanged, end_unchanged, buffer_beg, buffer_end members.
3223 (pp_cache): Don't assume cache_len fits in int.
3224 * region-cache.h: Adjust extern decls to match.
3226 * search.c (scan_buffer, Freplace_match): Use ptrdiff_t, not
3227 EMACS_INT, since either will do, for xpalloc.
3229 * alloc.c: Include verify.h, and check that int fits in ptrdiff_t.
3230 (xnmalloc, xnrealloc, xpalloc): New functions.
3232 * bidi.c (bidi_shelve_header_size): New constant.
3233 (bidi_cache_ensure_space, bidi_shelve_cache): Use it.
3234 (bidi_cache_ensure_space): Avoid integer overflow when allocating.
3236 * bidi.c (bidi_cache_shrink):
3237 * buffer.c (overlays_at, overlays_in, record_overlay_string)
3239 Don't update size of array until after memory allocation succeeds,
3240 because xmalloc/xrealloc may not return.
3241 (struct sortstrlist.bytes): Now ptrdiff_t, as EMACS_INT doesn't help
3242 now that we have proper integer overflow checking.
3243 (record_overlay_string, overlay_strings): Catch overflows when
3244 calculating size of overlay_str_buf.
3246 * callproc.c (Fcall_process): Check for size overflow when
3247 calculating size of args2.
3248 (child_setup): Avoid overflow by using size_t rather than ptrdiff_t.
3249 Normally we prefer signed values, but sticking with ptrdiff_t would
3250 require adding more-complicated checks.
3252 * ccl.c (Fccl_execute_on_string): Check for memory overflow.
3253 Use ptrdiff_t rather than EMACS_INT where ptrdiff_t will do.
3254 Redo buffer-overflow calculations to avoid integer overflow.
3255 Add a FIXME comment where memory seems to be over-allocated.
3257 * character.c (Fstring): Check for size-calculation overflow.
3259 * coding.c (produce_chars): Redo buffer-overflow calculations to avoid
3260 unnecessary integer overflow. Check for size overflow.
3261 (encode_coding_object): Don't update size until xmalloc succeeds.
3263 * composite.c (get_composition_id): Check for overflow in glyph
3264 length calculations.
3266 Integer and memory overflow fixes for display code.
3267 * dispextern.h (struct glyph_pool.nglyphs): Now ptrdiff_t, not int.
3268 * dispnew.c (adjust_glyph_matrix, realloc_glyph_pool)
3269 (scrolling_window): Check for overflow in size calculations.
3270 (line_draw_cost, realloc_glyph_pool, add_row_entry):
3271 Don't assume glyph table len fits in int.
3272 (struct row_entry.bucket, row_entry_pool_size, row_entry_idx)
3273 (row_table_size): Now ptrdiff_t, not int.
3274 (scrolling_window): Avoid overflow in size calculations.
3275 Don't update size until allocation succeeds.
3276 * fns.c (concat): Check for overflow in size calculations.
3277 (next_almost_prime): Verify NEXT_ALMOST_PRIME_LIMIT.
3278 * lisp.h (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): New macros.
3279 (NEXT_ALMOST_PRIME_LIMIT): New constant.
3281 * doc.c (get_doc_string_buffer_size): Now ptrdiff_t, not int.
3282 (get_doc_string): Check for size calculation overflow.
3283 Don't update size until allocation succeeds.
3284 (get_doc_string, Fsubstitute_command_keys): Use ptrdiff_t, not
3285 EMACS_INT, where ptrdiff_t will do.
3286 (Fsubstitute_command_keys): Check for string overflow.
3288 * editfns.c (set_time_zone_rule): Don't assume environment length
3290 (message_length): Now ptrdiff_t, not int.
3291 (Fmessage_box): Don't update size until allocation succeeds.
3292 Don't assume message length fits in int.
3293 (Fformat): Use ptrdiff_t, not EMACS_INT, where ptrdiff_t will do.
3295 * emacs.c (main): Do not reallocate argv, since there is a null at
3296 the end that can be overwritten, and this way there's no need to
3297 worry about size-calculation overflow.
3298 (sort_args): Check for size-calculation overflow.
3300 * eval.c (init_eval_once, grow_specpdl): Don't update size until
3302 (call_debugger, grow_specpdl): Redo calculations to avoid overflow.
3304 * frame.c (set_menu_bar_lines, x_set_frame_parameters)
3305 (x_set_scroll_bar_width, x_figure_window_size):
3306 Check for integer overflow.
3307 (x_set_alpha): Do not assume XINT fits in int.
3309 * frame.h (struct frame): Use int, not EMACS_INT, where int works.
3310 This is for the members text_lines, text_cols, total_lines, total_cols,
3311 where the system imposes an 'int' limit.
3313 * fringe.c (Fdefine_fringe_bitmap):
3314 Don't update size until alloc works.
3316 * ftfont.c (ftfont_get_open_type_spec, setup_otf_gstring)
3317 (ftfont_shape_by_flt): Check for integer overflow in size calculations.
3319 * gtkutil.c (get_utf8_string, xg_store_widget_in_map):
3320 Check for size-calculation overflow.
3321 (get_utf8_string): Use ptrdiff_t, not size_t, where either will
3322 do, as we prefer signed integers.
3323 (id_to_widget.max_size, id_to_widget.used)
3324 (xg_store_widget_in_map, xg_remove_widget_from_map)
3325 (xg_get_widget_from_map, xg_get_scroll_id_for_window)
3326 (xg_remove_scroll_bar, xg_update_scrollbar_pos):
3327 Use and return ptrdiff_t, not int.
3328 (xg_gtk_scroll_destroy): Don't assume ptrdiff_t fits in int.
3329 * gtkutil.h: Change prototypes to match the above.
3331 * image.c (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): Remove; these
3332 are duplicate now that they've been promoted to lisp.h.
3333 (x_allocate_bitmap_record, x_alloc_image_color)
3334 (make_image_cache, cache_image, xpm_load):
3335 Don't update size until alloc is done.
3336 (xpm_load, lookup_rgb_color, lookup_pixel_color, x_to_xcolors)
3338 Check for size calculation overflow.
3339 (ct_colors_allocated_max): New constant.
3340 (x_to_xcolors, x_detect_edges): Reorder multiplicands to avoid
3343 * keyboard.c (read_char, menu_bar_items, tool_bar_items)
3344 (read_char_x_menu_prompt, read_char_minibuf_menu_width)
3345 (read_char_minibuf_menu_prompt, follow_key, read_key_sequence):
3346 Use ptrdiff_t, not int, to count maps.
3347 (read_char_minibuf_menu_prompt): Check for overflow in size
3348 calculations. Don't update size until allocation succeeds.
3349 Redo calculations to avoid overflow.
3350 * keyboard.h: Change prototypes to match the above.
3352 * keymap.c (cmm_size, current_minor_maps): Use ptrdiff_t, not int,
3354 (current_minor_maps): Check for size calculation overflow.
3355 * keymap.h: Change prototypes to match the above.
3357 * lread.c (read1, init_obarray): Don't update size until alloc done.
3359 * macros.c (Fstart_kbd_macro): Don't update size until alloc done.
3360 (store_kbd_macro_char): Reorder multiplicands to avoid overflow.
3362 * nsterm.h (struct ns_color_table.size, struct ns_color_table.avail):
3363 Now ptrdiff_t, not int.
3364 * nsterm.m (ns_index_color): Use ptrdiff_t, not int, for table indexes.
3365 (ns_draw_fringe_bitmap): Rewrite to avoid overflow.
3367 * process.c (Fnetwork_interface_list): Check for overflow
3368 in size calculation.
3370 * region-cache.c (move_cache_gap): Check for size calculation overflow.
3372 * scroll.c (do_line_insertion_deletion_costs): Check for size calc
3373 overflow. Don't bother calling xmalloc when xrealloc will do.
3375 * search.c (Freplace_match): Check for size calculation overflow.
3376 (Fset_match_data): Don't assume list lengths fit in 'int'.
3378 * sysdep.c (system_process_attributes): Use ptrdiff_t, not int,
3379 for command line length. Do not attempt to address one before the
3380 beginning of an array, as that's not portable.
3382 * term.c (max_frame_lines): Remove; unused.
3383 (encode_terminal_src_size, encode_terminal_dst_size): Now ptrdiff_t,
3385 (encode_terminal_code, calculate_costs): Check for size
3386 calculation overflow.
3387 (encode_terminal_code): Use ptrdiff_t, not int, to record glyph
3388 table lengths and related sizes. Don't update size until alloc
3389 done. Redo calculations to avoid overflow.
3390 (calculate_costs): Don't bother calling xmalloc when xrealloc will do.
3392 * termcap.c (tgetent): Use ptrdiff_t, not int, to record results of
3393 subtracting pointers.
3394 (gobble_line): Check for overflow more carefully. Don't update size
3397 * tparam.c (tparam1): Use ptrdiff_t, not int, for sizes.
3398 Don't update size until alloc done.
3399 Redo size calculations to avoid overflow.
3400 Check for size calculation overflow.
3401 (main) [DEBUG]: Fix typo in invoking tparam1.
3403 * xdisp.c (store_mode_line_noprop_char, x_consider_frame_title):
3404 Use ptrdiff_t, not int, for sizes.
3405 (store_mode_line_noprop_char): Don't update size until alloc done.
3407 * xfaces.c (lface_id_to_name_size, Finternal_make_lisp_face):
3408 Use ptrdiff_t, not int, for sizes.
3409 (Finternal_make_lisp_face, cache_face):
3410 Check for size calculation overflow.
3411 (cache_face): Treat size calculation overflows as if they were
3412 memory exhaustion (the usual treatment), rather than aborting.
3414 * xfns.c (x_encode_text, x_set_name_internal)
3415 (Fx_change_window_property): Use ptrdiff_t, not int, to count
3416 sizes, since they can exceed INT_MAX in size. Check for size
3417 calculation overflow.
3419 * xgselect.c (gfds_size): Now ptrdiff_t, for convenience with xpalloc.
3420 (xg_select): Check for size calculation overflow.
3421 Don't update size until alloc done.
3423 * xrdb.c (get_environ_db): Don't assume path length fits in int,
3424 as sprintf is limited to int lengths.
3426 * xselect.c (X_LONG_SIZE, X_SHRT_MAX, X_SHRT_MIN, X_LONG_MAX)
3427 (X_LONG_MIN): New macros.
3428 Use them to make the following changes clearer.
3429 (MAX_SELECTION_QUANTUM): Make the other bounds on this value clearer.
3430 This change doesn't affect the value now, but it may help remind
3431 future maintainers not to raise the value too much later.
3432 (SELECTION_QUANTUM): Remove, replacing with ...
3433 (selection_quantum): ... new function, which avoids overflow.
3435 (struct selection_data.size): Now ptrdiff_t, not int, to avoid
3436 assumption that selection length fits in 'int'.
3437 (x_reply_selection_request, x_handle_selection_request)
3438 (x_get_window_property, receive_incremental_selection)
3439 (x_get_window_property_as_lisp_data, selection_data_to_lisp_data)
3440 (lisp_data_to_selection_data, clean_local_selection_data):
3441 Use ptrdiff_t, not int, to record length of selection.
3442 (x_reply_selection_request, x_get_window_property)
3443 (receive_incremental_selection, x_property_data_to_lisp):
3444 Redo calculations to avoid overflow.
3445 (x_reply_selection_request): When sending hint, ceiling it at
3446 X_LONG_MAX rather than relying on wraparound overflow to send
3448 (x_get_window_property, receive_incremental_selection)
3449 (lisp_data_to_selection_data, x_property_data_to_lisp):
3450 Check for size-calculation overflow.
3451 (x_get_window_property, receive_incremental_selection)
3452 (lisp_data_to_selection_data, Fx_register_dnd_atom):
3453 Don't store size until memory allocation succeeds.
3454 (x_get_window_property): Plug memory leak on memory exhaustion.
3455 Don't double-block input; malloc is safe here. Don't assume 2**34
3456 - 4 fits in unsigned long. Add an xassert to check
3457 XGetWindowProperty overflow. Be more careful about overflow
3458 calculations, and distinguish size from memory overflow better.
3459 (receive_incremental_selection): When tracing, don't assume
3460 unsigned int is less than INT_MAX.
3461 (x_selection_data_to_lisp_data): Remove unnecessary (and in theory
3462 harmful) conversions of unsigned short to int.
3463 (lisp_data_to_selection_data): Don't assume that integers
3464 in the range -65535 through -1 fit in an X unsigned short.
3465 Don't assume that ULONG_MAX == X_ULONG_MAX. Don't store into
3466 result parameters unless successful. Rely on cons_to_unsigned
3467 to report problems with elements; the old code wasn't right anyway.
3468 (x_check_property_data): Check for int overflow; we cannot use
3469 a wider type due to X limits.
3470 (x_handle_dnd_message): Use unsigned int, to avoid int overflow.
3472 * xsmfns.c (smc_save_yourself_CB): Check for size calc overflow.
3474 * xterm.c (x_color_cells, x_send_scrollbar_event, handle_one_xevent)
3475 (x_term_init): Check for size calculation overflow.
3476 (x_color_cells): Don't store size until memory allocation succeeds.
3477 (handle_one_xevent): Use ptrdiff_t, not int, for byte counts.
3478 Don't assume alloca size is less than MAX_ALLOCA.
3479 (x_term_init): Don't assume length fits in int (sprintf is limited
3482 Use ptrdiff_t for composition IDs.
3483 * character.c (lisp_string_width):
3484 * composite.c (composition_table_size, n_compositions)
3485 (get_composition_id, composition_gstring_from_id):
3486 * dispextern.h (struct glyph_string.cmp_id, struct composition_it.id):
3487 * xdisp.c (BUILD_COMPOSITE_GLYPH_STRING):
3488 * window.c (Frecenter):
3489 Use ptrdiff_t, not int, for composition IDs.
3490 * composite.c (get_composition_id): Check for integer overflow.
3491 * composite.h: Adjust prototypes to match the above changes.
3493 Use ptrdiff_t for hash table indexes.
3494 * category.c (hash_get_category_set):
3495 * ccl.c (ccl_driver):
3496 * charset.h (struct charset.hash_index, CHECK_CHARSET_GET_ID):
3497 * coding.c (coding_system_charset_list, detect_coding_system):
3498 * coding.h (struct coding_system.id):
3499 * composite.c (get_composition_id, gstring_lookup_cache):
3500 * fns.c (hash_lookup, hash_put, Fgethash, Fputhash):
3501 * image.c (xpm_get_color_table_h):
3502 * lisp.h (hash_lookup, hash_put):
3503 * minibuf.c (Ftest_completion):
3504 Use ptrdiff_t for hash table indexes, not int (which is too
3505 narrow, on 64-bit hosts) or EMACS_INT (which is too wide, on
3506 32-bit --with-wide-int hosts).
3508 * charset.c (Fdefine_charset_internal): Check for integer overflow.
3509 Add a FIXME comment about memory leaks.
3510 (syms_of_charset): Don't assume xmalloc returns.
3512 Don't assume that stated character widths fit in int.
3513 * character.c (Fchar_width, c_string_width, lisp_string_width):
3514 * character.h (CHAR_WIDTH):
3515 * indent.c (MULTIBYTE_BYTES_WIDTH):
3516 Use sanitize_char_width to avoid undefined and/or bad behavior
3517 with outlandish widths.
3518 * character.h (sanitize_tab_width): Rename from sanitize_width,
3519 now that we have two such functions. All uses changed.
3520 (sanitize_char_width): New inline function.
3522 Don't assume that tab-width fits in int.
3523 * character.h (sanitize_width): New inline function.
3524 (SANE_TAB_WIDTH): New macro.
3525 (ASCII_CHAR_WIDTH): Use it.
3526 * indent.c (sane_tab_width): Remove. All uses replaced by
3527 SANE_TAB_WIDTH (current_buffer).
3528 * xdisp.c (init_iterator): Use SANE_TAB_WIDTH.
3530 * fileio.c: Integer overflow issues with file modes.
3531 (Fset_file_modes, auto_save_1): Don't assume EMACS_INT fits in int.
3533 * charset.c (read_hex): New arg OVERFLOW. All uses changed.
3534 Remove unreachable code.
3535 (read_hex, load_charset_map_from_file): Check for integer overflow.
3537 * xterm.c: Don't go over XClientMessageEvent limit.
3538 (scroll_bar_windows_size): Now ptrdiff_t, as we prefer signed.
3539 (x_send_scroll_bar_event): Likewise. Check that the size does not
3540 exceed limits imposed by XClientMessageEvent, as well as the usual
3541 ptrdiff_t and size_t limits.
3543 * keyboard.c: Overflow, signedness and related fixes.
3544 (make_lispy_movement): Use same integer type in forward decl
3545 that is used in the definition.
3546 (read_key_sequence, keyremap_step):
3547 Change bufsize argument back to int, undoing my 2011-03-30 change.
3548 We prefer signed types, and int is wide enough here.
3549 (parse_tool_bar_item): Don't assume tool_bar_max_label_size is less
3550 than TYPE_MAXIMUM (EMACS_INT) / 2. Don't let the label size grow
3551 larger than STRING_BYTES_BOUND. Use ptrdiff_t for Emacs string
3552 length, not size_t. Use ptrdiff_t for index, not int.
3553 (keyremap_step, read_key_sequence): Redo bufsize check to avoid
3554 possibility of integer overflow.
3556 Overflow, signedness and related fixes for images.
3558 * dispextern.h (struct it.stack[0].u.image.image_id)
3559 (struct_it.image_id, struct image.id, struct image_cache.size)
3560 (struct image_cache.used, struct image_cache.ref_count):
3561 * gtkutil.c (update_frame_tool_bar):
3562 * image.c (x_reference_bitmap, Fimage_size, Fimage_mask_p)
3563 (Fimage_metadata, free_image_cache, clear_image_cache, lookup_image)
3564 (cache_image, mark_image_cache, x_kill_gs_process, Flookup_image):
3565 * nsmenu.m (update_frame_tool_bar):
3566 * xdisp.c (calc_pixel_width_or_height):
3567 * xfns.c (image_cache_refcount):
3568 Image IDs are now ptrdiff_t, not int, to avoid arbitrary limits
3569 on typical 64-bit hosts.
3571 * image.c (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): New macros.
3572 (x_bitmap_pixmap, x_create_x_image_and_pixmap):
3573 Omit unnecessary casts to int.
3574 (parse_image_spec): Check that integers fall into 'int' range
3575 when the callers expect that.
3576 (image_ascent): Redo ascent calculation to avoid int overflow.
3577 (clear_image_cache): Avoid overflow when sqrt (INT_MAX) < nimages.
3578 (lookup_image): Remove unnecessary tests.
3579 (xbm_image_p): Locals are now of int, not EMACS_INT,
3580 since parse_image_check makes sure they fit into int.
3581 (png_load, gif_load, svg_load_image):
3582 Prefer int to unsigned where either will do.
3583 (tiff_handler): New function, combining the cores of the
3584 old tiff_error_handler and tiff_warning_handler.
3585 This function is rewritten to use vsnprintf and thereby avoid
3586 stack buffer overflows. It uses only the features of vsnprintf
3587 that are common to both POSIX and native Microsoft.
3588 (tiff_error_handler, tiff_warning_handler): Use it.
3589 (tiff_load, gif_load, imagemagick_load_image):
3590 Don't assume :index value fits in 'int'.
3591 (gif_load): Omit unnecessary cast to double, and avoid double-rounding.
3592 (imagemagick_load_image): Check that crop parameters fit into
3593 the integer types that MagickCropImage accepts. Don't assume
3594 Vimagemagick_render_type has a nonnegative value. Don't assume
3595 size_t fits in 'long'.
3596 (gs_load): Use printmax_t to print the widest integers possible.
3597 Check for integer overflow when computing image height and width.
3599 2011-08-26 Eli Zaretskii <eliz@gnu.org>
3601 * xdisp.c (redisplay_window): Don't force window start if point
3602 will be invisible in the resulting window. (Bug#9324)
3604 2011-08-25 Eli Zaretskii <eliz@gnu.org>
3606 * xdisp.c (compute_display_string_pos): Return 2 in DISP_PROP when
3607 the display spec is of the form `(space ...)'.
3608 (handle_display_spec): Return the value returned by
3609 handle_single_display_spec, not just 1 or zero.
3610 (handle_single_display_spec): If the display spec is of the form
3611 `(space ...)', and specifies display in the text area, return 2
3613 (try_cursor_movement): Check for the need to scroll more
3614 accurately, and prefer exact match for point under bidi.
3615 Don't advance `row' beyond the last row of the window.
3617 * dispextern.h (struct bidi_it): Rename the disp_prop_p member
3618 into disp_prop; all users changed.
3620 * bidi.c (bidi_fetch_char): If compute_display_string_pos returns
3621 DISP_PROP = 2, substitute the u+2029 PARAGRAPH SEPARATOR character
3622 for the text covered by the display property.
3624 2011-08-25 Chong Yidong <cyd@stupidchicken.com>
3626 * buffer.c (Fbury_buffer_internal): Rename from Funrecord_buffer.
3627 Change return value to nil.
3628 (Frecord_buffer): Delete unused function.
3630 2011-08-24 Eli Zaretskii <eliz@gnu.org>
3632 * xdisp.c (Fcurrent_bidi_paragraph_direction): For unibyte
3633 buffers, return left-to-right.
3634 (set_cursor_from_row): Consider candidate row a win if its glyph
3635 represents a newline and point is on that newline. Fixes cursor
3636 positioning on the newline at EOL of R2L text within L2R
3637 paragraph, and vice versa.
3638 (try_cursor_movement): Check continued rows, in addition to
3639 continuation rows. Fixes unwarranted scroll when point enters a
3640 continued line of R2L text within an L2R paragraph, or vice versa.
3641 (cursor_row_p): Consider the case of point being equal to
3642 MATRIX_ROW_END_CHARPOS. Prevents cursor being stuck when moving
3643 from the end of a short line to the beginning of a continued line
3644 of R2L text within L2R paragraph.
3645 (RECORD_MAX_MIN_POS): For max_pos, use IT_CHARPOS even for
3646 composed characters.
3648 * bidi.c (bidi_check_type): Use xassert.
3649 (bidi_cache_iterator_state): Update the disp_pos and disp_prop_p
3652 2011-08-23 Eli Zaretskii <eliz@gnu.org>
3654 * bidi.c (bidi_get_type): Abort if we get zero as the bidi type of
3657 2011-08-23 Chong Yidong <cyd@stupidchicken.com>
3659 * nsfont.m (ns_otf_to_script): Fix typo.
3661 2011-08-22 Kenichi Handa <handa@m17n.org>
3663 * chartab.c (Fset_char_table_extra_slot): Do not inhibit setting a
3664 extra slot even if the purpose is char-code-property-table.
3666 2011-08-23 Eli Zaretskii <eliz@gnu.org>
3668 * xdisp.c (redisplay_window): When computing centering_position,
3669 account for the height of the header line. (Bug#8874)
3671 * dispnew.c (buffer_posn_from_coords): Use buf_charpos_to_bytepos
3672 instead of CHAR_TO_BYTE. Fixes a crash when a completion
3673 candidate is selected by the mouse, and that candidate has a
3674 composed character under the mouse.
3676 * xdisp.c (x_produce_glyphs): Set it->nglyphs to 1. Fixes pixel
3677 coordinates reported by pos-visible-in-window-p for a composed
3678 character in column zero.
3680 2011-08-23 Stefan Monnier <monnier@iro.umontreal.ca>
3682 * cmds.c (Fself_insert_command): Mention post-self-insert-hook.
3684 2011-08-22 Eli Zaretskii <eliz@gnu.org>
3686 * xdisp.c (BUFFER_POS_REACHED_P): If this is a composition,
3687 consider it a hit if to_charpos is anywhere in the range of the
3688 composed buffer positions.
3690 2011-08-22 Chong Yidong <cyd@stupidchicken.com>
3692 * image.c (gif_load): Don't assume that each subimage has the same
3693 dimensions as the base image. Handle disposal method that is
3694 "undefined" by the gif spec (Bug#9335).
3696 2011-08-20 Chong Yidong <cyd@stupidchicken.com>
3698 * eval.c (Fsignal): Handle `debug' symbol in error handler (Bug#9329).
3699 (Fcondition_case): Document `debug' symbol in error handler.
3701 2011-08-19 Eli Zaretskii <eliz@gnu.org>
3703 * xfaces.c (face_at_buffer_position): Avoid repeated evaluation of
3704 face ID by FACE_FROM_ID, and avoid a crash when mouse is moved
3705 from an Org mode buffer to a Speedbar frame.
3707 * xdisp.c (RECORD_MAX_MIN_POS): If the display element comes from
3708 a composition, take its buffer position from IT->cmp_it.charpos.
3709 Fixes cursor positioning at the beginning of a line that begins
3710 with a composed character.
3712 2011-08-18 Eli Zaretskii <eliz@gnu.org>
3714 * bidi.c (bidi_get_type): If bidi_type_table reports zero as the
3715 character bidirectional type, use STRONG_L instead. Fixes crashes
3716 in a buffer produced by `describe-categories'.
3718 * dispextern.h (struct bidi_it): Move disp_pos and disp_prop_p
3719 members before the level stack, so they would be saved and
3720 restored when copying iterator state. Fixes incorrect reordering
3721 around TABs covered by display properties.
3723 2011-08-18 Andreas Schwab <schwab@linux-m68k.org>
3725 * process.c (Fnetwork_interface_list): Correctly determine buffer size.
3727 2011-08-17 Chong Yidong <cyd@stupidchicken.com>
3729 * eval.c (internal_condition_case, internal_condition_case_1)
3730 (internal_condition_case_2, internal_condition_case_n):
3731 Remove unnecessary aborts (Bug#9081).
3733 2011-08-17 Eli Zaretskii <eliz@gnu.org>
3735 * lread.c (Fload) [DOS_NT]: If `openp' returns -2, but the file
3736 has no `load' handler, try opening the file locally. (Bug#9311)
3738 2011-08-16 Ken Brown <kbrown@cornell.edu>
3740 * gmalloc.c: Expand comment.
3742 2011-08-16 Eli Zaretskii <eliz@gnu.org>
3744 * xdisp.c (set_cursor_from_row): Don't accept a previous candidate
3745 if it fails the cursor_row_p test. Fixes cursor positioning at ZV.
3747 2011-08-16 Ken Brown <kbrown@cornell.edu>
3749 Fix memory allocation problems in Cygwin build (Bug#9273).
3751 * unexcw.c ( __malloc_initialized): Declare external variable.
3752 (fixup_executable): Force the dumped emacs to reinitialize malloc.
3754 * gmalloc.c [CYGWIN] (bss_sbrk_heapbase, bss_sbrk_heapinfo):
3756 (malloc_initialize_1) [CYGWIN]: Prepare for reinitializing the
3758 (_free_internal_nolock) [CYGWIN]: Ignore requests to free storage
3760 [CYGWIN] (special_realloc): New function.
3761 (_realloc_internal_nolock) [CYGWIN]: Use the new function on
3762 requests to realloc storage in the static heap.
3764 2011-08-15 Paul Eggert <eggert@cs.ucla.edu>
3766 * bidi.c (bidi_initialize): Remove unused local.
3768 2011-08-15 Eli Zaretskii <eliz@gnu.org>
3771 * biditype.h: Remove file.
3772 * makefile.w32-in ($(BLD)/bidi.$(O)):
3773 * deps.mk (bidi.o): Remove biditype.h and bidimirror.h.
3775 * dispextern.h: Fix a typo in the comment to bidi_type_t.
3777 * chartab.c: Improve commentary for the uniprop_table API.
3779 * bidi.c (bidi_paragraph_init): Support zero value of
3780 bidi_ignore_explicit_marks_for_paragraph_level.
3781 (bidi_initialize): Use uniprop_table instead of including
3782 biditype.h and bidimirror.h.
3784 * xdisp.c (move_it_in_display_line_to): Don't reset pixel
3785 coordinates of the iterator when restoring from ppos_it.
3788 2011-08-14 Kenichi Handa <handa@m17n.org>
3790 * process.c (create_process): Call setup_process_coding_systems
3791 after the pid of the process is set to -1 (Bug#8162).
3793 2011-08-14 Eli Zaretskii <eliz@gnu.org>
3795 * xdisp.c (move_it_in_display_line_to): Don't invoke
3796 IT_RESET_X_ASCENT_DESCENT when iterator position was restored from
3797 ppos_it. Fixes vertical cursor motion when line beginning is
3798 covered by an image. (Bug#9296)
3800 2011-08-14 Jan Djärv <jan.h.d@swipnet.se>
3802 * nsterm.h (ns_run_ascript): Declare.
3803 (NSAPP_DATA2_RUNASSCRIPT): Define.
3805 * nsfns.m (as_script, as_result, as_status): New static variables.
3806 (ns_run_ascript): New function.
3807 (Fns_do_applescript): Set variables as_*. Make an NSApplicationDefined
3808 event with data2 set to NSAPP_DATA2_RUNASSCRIPT, post it and then start
3809 the event loop. Get status from as_status (Bug#7276).
3811 * nsterm.m (sendEvent): If event is NSApplicationDefined and
3812 data2 is NSAPP_DATA2_RUNASSCRIPT, call ns_run_ascript and then exit
3813 the event loop (Bug#7276).
3815 2011-08-14 Andreas Schwab <schwab@linux-m68k.org>
3817 * gnutls.c (QCgnutls_bootprop_priority)
3818 (QCgnutls_bootprop_trustfiles, QCgnutls_bootprop_keylist)
3819 (QCgnutls_bootprop_crlfiles, QCgnutls_bootprop_callbacks)
3820 (QCgnutls_bootprop_loglevel, QCgnutls_bootprop_hostname)
3821 (QCgnutls_bootprop_min_prime_bits, QCgnutls_bootprop_verify_flags)
3822 (QCgnutls_bootprop_verify_hostname_error)
3823 (QCgnutls_bootprop_callbacks_verify): Rename from
3824 Qgnutls_bootprop_..., all uses changed.
3826 * xfaces.c (QCignore_defface): Rename from Qignore_defface, all
3829 2011-08-14 Paul Eggert <eggert@cs.ucla.edu>
3831 * xfaces.c (Qframe_set_background_mode): Now static.
3832 * dispextern.h (Qframe_set_background_mode): Remove decl.
3834 * process.c (Fnetwork_interface_info): Declare local only if needed.
3836 2011-08-13 Jan Djärv <jan.h.d@swipnet.se>
3838 * process.c: Include ifaddrs.h and net/if_dl.h if available (Bug#8477).
3839 (Fnetwork_interface_list): Allocate in increments of bytes instead
3840 of sizeof (struct ifreq). Iterate over ifconf.ifc_req by counting
3841 bytes (Bug#8477). Count bytes correctly when ifr_addr is a struct
3843 (struct ifflag_def): notrailers is smart on OSX.
3844 (Fnetwork_interface_info): Handle case when ifr_flags is negative.
3845 Get hardware address with getifaddrs if available.
3847 2011-08-12 Eli Zaretskii <eliz@gnu.org>
3849 * xdisp.c (iterate_out_of_display_property): xassert that
3850 IT->position is set to within IT->object's boundaries. Break from
3851 the loop as soon as EOB is reached; avoids infloops in redisplay
3852 when IT->position is set up wrongly due to some bug.
3853 Set IT->current to match the bidi iterator unconditionally.
3854 (push_display_prop): Allow GET_FROM_STRING as IT->method on
3855 entry. Force push_it to save on the stack the current
3856 buffer/string position, to be restored by pop_it. Fix flags in
3857 the iterator structure wrt the object coming from a display
3858 property, as `line-prefix' and `wrap-prefix' are not ``replacing''
3859 properties. (Bug#9284)
3861 2011-08-09 Andreas Schwab <schwab@linux-m68k.org>
3863 * fontset.c (fontset_get_font_group): Add proper type checks.
3866 2011-08-09 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
3868 * unexmacosx.c (print_load_command_name): Add cases LC_FUNCTION_STARTS
3869 and LC_VERSION_MIN_MACOSX.
3870 (copy_linkedit_data) [LC_FUNCTION_STARTS]: New function.
3871 (dump_it) [LC_FUNCTION_STARTS]: Use it.
3873 2011-08-08 Eli Zaretskii <eliz@gnu.org>
3875 * xdisp.c (forward_to_next_line_start): Allow to use the
3876 no-display-properties-and-no-overlays under bidi display.
3877 Set disp_pos in the bidi iterator to avoid searches for display
3878 properties and overlays.
3880 2011-08-08 Chong Yidong <cyd@stupidchicken.com>
3882 * editfns.c (Fset_time_zone_rule): Document relationship with the
3885 * ftfont.c (ftfont_pattern_entity): Copy the extras argument to
3886 the font entity extracted from the cache (Bug#8109).
3888 2011-08-07 Chong Yidong <cyd@stupidchicken.com>
3890 * composite.c (autocmp_chars): Don't reset point. That is done by
3891 restore_point_unwind (Bug#5984).
3893 2011-08-07 Juri Linkov <juri@jurta.org>
3895 * editfns.c (Fformat_time_string): Doc fix, add tag `usage:'
3896 to show the arg `TIME' instead of `TIMEVAL'.
3898 2011-08-06 Eli Zaretskii <eliz@gnu.org>
3900 * xdisp.c (set_cursor_from_row): Fix cursor positioning when a
3901 display property strides EOL and includes a newline, as in
3902 longlines-mode. (Bug#9254)
3903 (move_it_in_display_line_to): Fix vertical-motion in a buffer with
3904 word-wrap under bidirectional display. (Bug#9224)
3906 * bidi.c (bidi_unshelve_cache): Don't reset the cache if JUST_FREE
3907 is non-zero, even if the data buffer is NULL. Fixes a crash in
3908 vertical-motion with longlines-mode. (Bug#9254)
3910 2011-08-05 Eli Zaretskii <eliz@gnu.org>
3912 * bidi.c <bidi_cache_total_alloc>: Now static.
3913 (bidi_initialize): Initialize bidi_cache_total_alloc.
3915 * xdisp.c (display_line): Release buffer allocated for shelved bidi
3918 * bidi.c (bidi_shelve_cache, bidi_unshelve_cache): Track total
3919 amount allocated this far in `bidi_cache_total_alloc'.
3920 (bidi_unshelve_cache): Accept an additional argument JUST_FREE; if
3921 non-zero, only free the data buffer without restoring the cache
3922 contents. All callers changed.
3924 * dispextern.h (bidi_unshelve_cache): Update prototype.
3926 * xdisp.c (SAVE_IT, pos_visible_p, move_it_in_display_line_to)
3927 (move_it_in_display_line, move_it_to)
3928 (move_it_vertically_backward, move_it_by_lines): Replace the call
3929 to xfree to an equivalent call to bidi_unshelve_cache.
3930 (move_it_in_display_line_to): Fix logic of returning
3931 MOVE_POS_MATCH_OR_ZV in the bidi case. (Bug#9224)
3933 2011-08-05 Eli Zaretskii <eliz@gnu.org>
3935 * xdisp.c (set_cursor_from_row): Prefer the candidate glyph that
3936 came from a string character with a `cursor' property. (Bug#9229)
3938 2011-08-04 Jan Djärv <jan.h.d@swipnet.se>
3940 * Makefile.in (LIB_PTHREAD): New variable.
3941 (LIBES): Add LIB_PTHREAD (Bug#9216).
3943 * alloc.c, emacs.c, gmalloc.c, gtkutil.c, keyboard.c, syssignal.h:
3944 Rename HAVE_GTK_AND_PTHREAD to HAVE_PTHREAD (Bug#9216).
3946 2011-08-04 Andreas Schwab <schwab@linux-m68k.org>
3948 * regex.c (re_iswctype): Remove some redundant boolean conversions.
3950 2011-08-04 Jan Djärv <jan.h.d@swipnet.se>
3952 * xterm.c (x_find_topmost_parent): New function.
3953 (x_set_frame_alpha): Find topmost parent window with
3954 x_find_topmost_parent and set the property there also (bug#9181).
3955 (handle_one_xevent): Call x_set_frame_alpha on ReparentNotify.
3957 2011-08-04 Paul Eggert <eggert@cs.ucla.edu>
3959 * callproc.c (Fcall_process): Avoid vfork clobbering
3960 the local vars buffer, coding_systems, current_dir.
3962 2011-08-03 Stefan Monnier <monnier@iro.umontreal.ca>
3964 * keymap.c (Fmake_composed_keymap): Move to subr.el.
3966 2011-08-03 Paul Eggert <eggert@cs.ucla.edu>
3968 * fontset.c (dump_fontset) [FONTSET_DEBUG]: Declare EXTERNALLY_VISIBLE
3969 so that it is not optimized away.
3971 * xdisp.c (compute_display_string_pos): Remove unused local.
3973 2011-08-02 Eli Zaretskii <eliz@gnu.org>
3975 Fix slow cursor motion and scrolling in large buffers with
3976 selective display, like Org Mode buffers. (Bug#9218)
3978 * dispextern.h (struct bidi_it): New member disp_prop_p.
3980 * xdisp.c: Remove one-slot cache of display string positions.
3981 (compute_display_string_pos): Accept an additional argument
3982 DISP_PROP_P; callers changed. Scan at most 5K characters forward
3983 for a display string or property. If found, set DISP_PROP_P
3986 * bidi.c (bidi_fetch_char): Accept an additional argument
3987 DISP_PROP_P, and pass it to compute_display_string_pos.
3988 Only handle text covered by a display string if DISP_PROP_P is returned
3989 non-zero. All callers of bidi_fetch_char changed.
3991 2011-08-02 Stefan Monnier <monnier@iro.umontreal.ca>
3993 * keymap.c (Fdefine_key): Fix Lisp_Object/int mixup; apply some CSE.
3995 2010-12-03 Don March <don@ohspite.net>
3997 * keymap.c (Fdefine_key): Fix non-prefix key error message when
3998 last character M-[char] is translated to ESC [char] (bug#7541).
4000 2011-08-02 Kenichi Handa <handa@m17n.org>
4002 * lisp.h (uniprop_table): Extern it.
4004 * chartab.c (uniprop_table): Make it non-static.
4006 2011-08-01 Eli Zaretskii <eliz@gnu.org>
4008 * xdisp.c (forward_to_next_line_start): Accept additional argument
4009 BIDI_IT_PREV, and store into it the state of the bidi iterator had
4011 (reseat_at_next_visible_line_start): Use the bidi iterator state
4012 returned by forward_to_next_line_start to restore the state of
4013 it->bidi_it after backing up to previous newline. (Bug#9212)
4015 2011-07-30 Andreas Schwab <schwab@linux-m68k.org>
4017 * regex.c (re_comp): Protoize.
4018 (re_exec): Fix return type.
4019 (regexec): Fix type of `ret'. (Bug#9203)
4021 2011-07-28 Paul Eggert <eggert@cs.ucla.edu>
4023 * image.c (check_image_size): Use 1024x1024 if unknown frame (Bug#9189).
4024 This is needed if max-image-size is a floating-point number.
4026 2011-07-28 Andreas Schwab <schwab@linux-m68k.org>
4028 * print.c (print_object): Print empty symbol as ##.
4030 * lread.c (read1): Read ## as empty symbol.
4032 2011-07-28 Alp Aker <alp.tekin.aker@gmail.com>
4034 * nsfns.m (x_set_foreground_color): Set f->foreground_pixel when
4035 setting frame foreground color (Bug#9175).
4036 (x_set_background_color): Likewise.
4038 * nsmenu.m (-setText): Size tooltip dimensions precisely to
4039 contents (Bug#9176).
4040 (EmacsTooltip -init): Remove bezels and add shadows to
4043 * nsterm.m (ns_dumpglyphs_stretch): Avoid overwriting left fringe
4044 or scroll bar (Bug#8470).
4046 * nsfont.m (nsfont_open): Remove assignment to voffset and
4047 unnecessary vars hshink, expand, hd, full_height, min_height.
4048 (nsfont_draw): Use s->ybase as baseline for glyph drawing (Bug#8913).
4050 * nsterm.h (nsfont_info): Remove voffset field.
4052 2011-07-28 Alp Aker <alp.tekin.aker@gmail.com>
4054 Implement strike-through and overline on NextStep (Bug#8863).
4056 * nsfont.m (nsfont_open): Use underline position provided by font,
4057 instead of hard-coded value of 2.
4058 (nsfont_draw): Call ns_draw_text_decoration instead.
4060 * nsterm.h: Add declaration for ns_draw_text_decoration.
4062 * nsterm.m (ns_draw_text_decoration): New function for drawing
4063 underline, overline, and strike-through.
4064 (ns_dumpglyphs_image, ns_dumpglyphs_stretch): Add call to
4065 ns_draw_text_decoration. Change treatment of cursor drawing to
4066 accommodate underlining, etc.
4068 2011-07-28 Eli Zaretskii <eliz@gnu.org>
4070 * buffer.c (init_buffer_once): Set bidi-display-reordering to t by
4073 2011-07-28 Paul Eggert <eggert@cs.ucla.edu>
4075 * alloc.c (memory_full) [!SYNC_INPUT]: Fix signal-related race.
4076 Without this fix, if a signal arrives just after memory fills up,
4077 'malloc' might be invoked reentrantly.
4079 * image.c (x_check_image_size) [!HAVE_X_WINDOWS]: Return 1.
4080 In other words, assume that every image size is allowed, on non-X
4081 hosts. This assumption is probably wrong, but it lets Emacs compile.
4083 2011-07-28 Andreas Schwab <schwab@linux-m68k.org>
4085 * regex.c (re_iswctype): Convert return values to boolean.
4087 2011-07-28 Eli Zaretskii <eliz@fencepost.gnu.org>
4089 * xdisp.c (compute_display_string_pos): Don't use cached display
4090 string position if the buffer had its restriction changed.
4093 2011-07-28 Paul Eggert <eggert@cs.ucla.edu>
4095 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
4097 2011-07-28 Paul Eggert <eggert@cs.ucla.edu>
4099 Integer signedness and overflow and related fixes. (Bug#9079)
4101 * bidi.c: Integer size and overflow fixes.
4102 (bidi_cache_size, bidi_cache_idx, bidi_cache_last_idx)
4103 (bidi_cache_start, bidi_cache_fetch_state, bidi_cache_search)
4104 (bidi_cache_find_level_change, bidi_cache_ensure_space)
4105 (bidi_cache_iterator_state, bidi_cache_find, bidi_cache_start_stack)
4106 (bidi_find_other_level_edge):
4107 Use ptrdiff_t instead of EMACS_INT where either will do.
4108 This works better on 32-bit hosts configured --with-wide-int.
4109 (bidi_cache_ensure_space): Check for size-calculation overflow.
4110 Use % rather than repeated addition, for better worst-case speed.
4111 Don't set bidi_cache_size until after xrealloc returns, because it
4113 (bidi_dump_cached_states): Use ptrdiff_t, not int, to avoid overflow.
4114 (bidi_cache_ensure_space): Also check that the bidi cache size
4115 does not exceed that of the largest Lisp string or buffer. See Eli
4116 Zaretskii in <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9079#29>.
4118 * alloc.c (__malloc_size_t): Remove.
4119 All uses replaced by size_t. See Andreas Schwab's note
4120 <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9079#8>.
4122 * image.c: Improve checking for integer overflow.
4123 (check_image_size): Assume that f is nonnull, since
4124 it is always nonnull in practice. This is one less thing to
4125 worry about when checking for integer overflow later.
4126 (x_check_image_size): New function, which checks for integer
4127 overflow issues inside X.
4128 (x_create_x_image_and_pixmap, xbm_read_bitmap_data): Use it.
4129 This removes the need for a memory_full check.
4130 (xbm_image_p): Rewrite to avoid integer multiplication overflow.
4131 (Create_Pixmap_From_Bitmap_Data, xbm_load): Use x_check_image_size.
4132 (xbm_read_bitmap_data): Change locals back to 'int', since
4133 their values must fit in 'int'.
4134 (xpm_load_image, png_load, tiff_load):
4135 Invoke x_create_x_image_and_pixmap earlier,
4136 to avoid much needless work if the image is too large.
4137 (tiff_load): Treat overly large images as if
4138 x_create_x_image_and_pixmap failed, not as malloc failures.
4139 (gs_load): Use x_check_image_size.
4141 * gtkutil.c: Omit integer casts.
4142 (xg_get_pixbuf_from_pixmap): Remove unnecessary cast.
4143 (xg_set_toolkit_scroll_bar_thumb): Rewrite to avoid need for cast.
4145 * image.c (png_load): Don't assume height * row_bytes fits in 'int'.
4147 * xfaces.c (Fbitmap_spec_p): Fix integer overflow bug.
4148 Without this fix, (bitmap-spec-p '(34359738368 1 "x"))
4149 would wrongly return t on a 64-bit host.
4151 * dispnew.c (init_display): Use *_RANGE_OVERFLOW macros.
4152 The plain *_OVERFLOW macros run afoul of GCC bug 49705
4153 <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=49705>
4154 and therefore cause GCC to emit a bogus diagnostic in some cases.
4156 * image.c: Integer signedness and overflow and related fixes.
4157 This is not an exhaustive set of fixes, but it's time to
4158 record what I've got.
4159 (lookup_pixel_color, check_image_size): Remove redundant decls.
4160 (check_image_size): Don't assume that arbitrary EMACS_INT values
4161 fit in 'int', or that arbitrary 'double' values fit in 'int'.
4162 (x_alloc_image_color, x_create_x_image_and_pixmap, png_load)
4163 (tiff_load, imagemagick_load_image):
4164 Check for overflow in size calculations.
4165 (x_create_x_image_and_pixmap): Remove unnecessary test for
4166 xmalloc returning NULL; that can't happen.
4167 (xbm_read_bitmap_data): Don't assume sizes fit into 'int'.
4168 (xpm_color_bucket): Use better integer hashing function.
4169 (xpm_cache_color): Don't possibly over-allocate memory.
4170 (struct png_memory_storage, tiff_memory_source, tiff_seek_in_memory)
4171 (gif_memory_source):
4172 Use ptrdiff_t, not int or size_t, to record sizes.
4173 (png_load): Don't assume values greater than 2**31 fit in 'int'.
4174 (our_stdio_fill_input_buffer): Prefer ptrdiff_t to size_t when
4175 either works, as we prefer signed integers.
4176 (tiff_read_from_memory, tiff_write_from_memory):
4177 Return tsize_t, not size_t, since that's what the TIFF API wants.
4178 (tiff_read_from_memory): Don't fail simply because the read would
4179 go past EOF; instead, return a short read.
4180 (tiff_load): Omit no-longer-needed casts.
4181 (Fimagemagick_types): Don't assume size fits into 'int'.
4183 Improve hashing quality when configured --with-wide-int.
4184 * fns.c (hash_string): New function, taken from sxhash_string.
4185 Do not discard information about ASCII character case; this
4186 discarding is no longer needed.
4187 (sxhash-string): Use it. Change sig to match it. Caller changed.
4188 * lisp.h: Declare it.
4189 * lread.c (hash_string): Remove, since we now use fns.c's version.
4190 The fns.c version returns a wider integer if --with-wide-int is
4191 specified, so this should help the quality of the hashing a bit.
4193 * emacs.c: Integer overflow minor fix.
4194 (heap_bss_diff): Now uprintmax_t, not unsigned long. All used changed.
4195 Define only if GNU_LINUX.
4196 (main, Fdump_emacs): Set and use heap_bss_diff only if GNU_LINUX.
4198 * dispnew.c: Integer signedness and overflow fixes.
4199 Remove unnecessary forward decls, that were a maintenance hassle.
4200 (history_tick): Now uprintmax_t, so it's more likely to avoid overflow.
4202 (adjust_glyph_matrix, realloc_glyph_pool, adjust_frame_message_buffer)
4203 (scrolling_window): Use ptrdiff_t, not int, for byte count.
4204 (prepare_desired_row, line_draw_cost):
4205 Use int, not unsigned, where either works.
4206 (save_current_matrix, restore_current_matrix):
4207 Use ptrdiff_t, not size_t, where either works.
4208 (init_display): Check for overflow more accurately, and without
4209 relying on undefined behavior.
4211 * editfns.c (pWIDE, pWIDElen, signed_wide, unsigned_wide):
4212 Remove, replacing with the new symbols in lisp.h. All uses changed.
4213 * fileio.c (make_temp_name):
4214 * filelock.c (lock_file_1, lock_file):
4215 * xdisp.c (message_dolog):
4216 Don't assume PRIdMAX etc. works; this isn't portable to pre-C99 hosts.
4217 Use pMd etc. instead.
4218 * lisp.h (printmax_t, uprintmax_t, pMd, pMu): New types and macros,
4219 replacing the pWIDE etc. symbols removed from editfns.c.
4221 * keyboard.h (num_input_events): Now uintmax_t.
4222 This is (very slightly) less likely to mess up due to wraparound.
4225 * buffer.c: Integer signedness fixes.
4226 (alloc_buffer_text, enlarge_buffer_text):
4227 Use ptrdiff_t rather than size_t when either will do, as we prefer
4230 * alloc.c: Integer signedness and overflow fixes.
4231 Do not impose an arbitrary 32-bit limit on malloc sizes when debugging.
4232 (__malloc_size_t): Default to size_t, not to int.
4233 (pure_size, pure_bytes_used_before_overflow, stack_copy_size)
4234 (Fgarbage_collect, mark_object_loop_halt, mark_object):
4235 Prefer ptrdiff_t to size_t when either would do, as we prefer
4237 (XMALLOC_OVERRUN_CHECK_OVERHEAD): New macro.
4238 (xmalloc_overrun_check_header, xmalloc_overrun_check_trailer):
4239 Now const. Initialize with values that are in range even if char
4241 (XMALLOC_PUT_SIZE, XMALLOC_GET_SIZE): Remove, replacing with ...
4242 (xmalloc_put_size, xmalloc_get_size): New functions. All uses changed.
4243 These functions do the right thing with sizes > 2**32.
4244 (check_depth): Now ptrdiff_t, not int.
4245 (overrun_check_malloc, overrun_check_realloc, overrun_check_free):
4246 Adjust to new way of storing sizes. Check for size overflow bugs
4248 (STRING_BYTES_MAX): Adjust to new overheads. The old code was
4249 slightly wrong anyway, as it missed one instance of
4250 XMALLOC_OVERRUN_CHECK_OVERHEAD.
4251 (refill_memory_reserve): Omit needless cast to size_t.
4252 (mark_object_loop_halt): Mark as externally visible.
4254 * xselect.c: Integer signedness and overflow fixes.
4255 (Fx_register_dnd_atom, x_handle_dnd_message):
4256 Use ptrdiff_t, not size_t, since we prefer signed.
4257 (Fx_register_dnd_atom): Check for ptrdiff_t (and size_t) overflow.
4258 * xterm.h (struct x_display_info): Use ptrdiff_t, not size_t, for
4259 x_dnd_atoms_size and x_dnd_atoms_length.
4261 * doprnt.c: Prefer signed to unsigned when either works.
4263 * doprnt.c (doprnt):
4265 * xdisp.c (vmessage):
4266 Use ptrdiff_t, not size_t, when using or implementing doprnt,
4267 since the sizes cannot exceed ptrdiff_t bounds anyway, and we
4268 prefer signed arithmetic to avoid comparison confusion.
4269 * doprnt.c (doprnt): Avoid a "+ 1" that can't overflow,
4270 but is a bit tricky.
4272 Assume freestanding C89 headers, string.h, stdlib.h.
4273 * data.c, doprnt.c, floatfns.c, print.c:
4274 Include float.h unconditionally.
4275 * gmalloc.c: Assume C89-at-least behavior for preprocessor,
4276 limits.h, stddef.h, string.h. Use memset instead of 'flood'.
4277 * regex.c: Likewise for stddef.h, string.h.
4278 (ISASCII): Remove; can assume it returns 1 now. All uses removed.
4279 * s/aix4-2.h (HAVE_STRING_H): Remove obsolete undef.
4280 * s/ms-w32.h (HAVE_LIMITS_H, HAVE_STRING_H, HAVE_STDLIB_H)
4281 (STDC_HEADERS): Remove obsolete defines.
4282 * sysdep.c: Include limits.h unconditionally.
4284 Assume support for memcmp, memcpy, memmove, memset.
4285 * lisp.h, sysdep.c (memcmp, memcpy, memmove, memset):
4286 * regex.c (memcmp, memcpy):
4287 Remove; we assume C89 now.
4289 * gmalloc.c (memcpy, memset, memmove): Remove; we assume C89 now.
4290 (__malloc_safe_bcopy): Remove; no longer needed.
4292 * lisp.h (struct vectorlike_header, struct Lisp_Subr): Signed sizes.
4293 Use EMACS_INT, not EMACS_UINT, for sizes. The code works equally
4294 well either way, and we prefer signed to unsigned.
4296 2011-07-27 Lars Magne Ingebrigtsen <larsi@gnus.org>
4298 * gnutls.c (emacs_gnutls_read): Don't message anything if the peer
4299 closes the connection while we're reading (bug#9182).
4301 2011-07-25 Jan Djärv <jan.h.d@swipnet.se>
4303 * nsmenu.m (ns_popup_dialog): Add an "ok" button if no buttons
4304 are specified (Bug#9168).
4306 2011-07-25 Paul Eggert <eggert@cs.ucla.edu>
4308 * bidi.c (bidi_dump_cached_states): Fix printf format mismatch.
4309 Found by GCC static checking and --with-wide-int on a 32-bit host.
4311 2011-07-25 Eli Zaretskii <eliz@gnu.org>
4313 * xdisp.c (compute_display_string_pos): Fix logic of caching
4314 previous display string position. Initialize cached_prev_pos to
4315 -1. Fixes slow-down at the beginning of a buffer.
4317 2011-07-24 Eli Zaretskii <eliz@gnu.org>
4319 * xfaces.c (check_lface_attrs) [HAVE_WINDOW_SYSTEM]: Allow `nil'
4320 for attrs[LFACE_FONTSET_INDEX].
4322 2011-07-23 Paul Eggert <eggert@cs.ucla.edu>
4324 * xml.c (parse_region): Remove unused local
4325 that was recently introduced.
4327 2011-07-23 Eli Zaretskii <eliz@gnu.org>
4329 * xfns.c (unwind_create_frame) [GLYPH_DEBUG]: Adapt to changes in
4330 2008-02-22T17:42:09Z!monnier@iro.umontreal.ca.
4332 * xdisp.c (move_it_in_display_line_to): Record the best matching
4333 position for TO_CHARPOS while scanning the line, and restore it on
4334 exit if none of the characters scanned was an exact match.
4335 Fixes vertical-motion and pos-visible-in-window-p under bidi redisplay
4336 when exact match is impossible due to invisible text, and the
4337 lines are truncated.
4339 2011-07-23 Jan Djärv <jan.h.d@swipnet.se>
4341 * nsterm.m (initFrameFromEmacs): Set NSTitledWindowMask in styleMask
4344 2011-07-22 Eli Zaretskii <eliz@gnu.org>
4346 Fix a significant slow-down of cursor motion with C-n, C-p,
4347 C-f/C-b, and C-v/M-v that couldn't keep up with keyboard
4348 auto-repeat under bidi redisplay in fontified buffers.
4349 * xdisp.c (compute_stop_pos_backwards): New function.
4350 (next_element_from_buffer): Call compute_stop_pos_backwards to
4351 find a suitable prev_stop when we find ourselves before
4353 (reseat): Don't look for prev_stop, as that could mean a very long
4355 <cached_disp_pos, cached_disp_buffer, cached_disp_modiff>
4356 <cached_disp_overlay_modiff>: Cache for last found display string
4358 (compute_display_string_pos): Return the cached position if asked
4359 about the same buffer in the same area of character positions, and
4360 the buffer wasn't changed since the time the display string
4361 position was cached.
4363 2011-07-22 Eli Zaretskii <eliz@gnu.org>
4365 * xdisp.c (rows_from_pos_range): Don't ignore glyphs whose object
4366 is an integer, which is important for empty lines. (Bug#9149)
4368 2011-07-22 Chong Yidong <cyd@stupidchicken.com>
4370 * frame.c (Fmodify_frame_parameters): In tty case, update the
4371 default face if necessary (Bug#4238).
4373 2011-07-21 Chong Yidong <cyd@stupidchicken.com>
4375 * editfns.c (Fstring_to_char): No need to explain what a character
4376 is in the docstring (Bug#6576).
4378 2011-07-20 Lars Magne Ingebrigtsen <larsi@gnus.org>
4380 * xml.c (parse_region): Make sure we always return a tree.
4382 2011-07-20 HAMANO Kiyoto <khiker.mail@gmail.com>
4384 * xml.c (parse_region): If a document contains only comments,
4387 2011-07-20 Lars Magne Ingebrigtsen <larsi@gnus.org>
4389 * xml.c (make_dom): Return comments, too.
4391 2011-07-19 Paul Eggert <eggert@cs.ucla.edu>
4394 See http://lists.gnu.org/archive/html/emacs-devel/2011-07/msg00688.html
4395 and the surrounding thread.
4396 * minibuf.c (read_minibuf_noninteractive): Rewrite to use getchar
4397 rather than fgets, and retry after EINTR. Otherwise, 'emacs
4398 --batch -f byte-compile-file' fails on OpenBSD if an inactivity
4400 * s/openbsd.h (BROKEN_SIGIO): Define.
4401 * unexelf.c (unexec) [__OpenBSD__]:
4402 Don't update the .mdebug section of the Alpha COFF symbol table.
4404 2011-07-19 Lars Magne Ingebrigtsen <larsi@gnus.org>
4406 * lread.c (syms_of_lread): Clarify when `lexical-binding' is used
4409 2011-07-18 Paul Eggert <eggert@cs.ucla.edu>
4411 * fileio.c (Fcopy_file) [!MSDOS]: Tighten created file's mask.
4412 This fixes some race conditions on the permissions of any newly
4415 * alloc.c (valid_pointer_p): Use pipe, not open.
4416 This fixes some permissions issues when debugging.
4418 * fileio.c (Fcopy_file): Adjust mode if fchown fails. (Bug#9002)
4419 If fchown fails to set both uid and gid, try to set just gid,
4420 as that is sometimes allowed. Adjust the file's mode to eliminate
4421 setuid or setgid bits that are inappropriate if fchown fails.
4423 2011-07-18 Stefan Monnier <monnier@iro.umontreal.ca>
4425 * xdisp.c (next_element_from_string, next_element_from_buffer): Use EQ
4426 to compare Lisp_Objects.
4427 * gnutls.c (syms_of_gnutls): Rename Vgnutls_log_level to
4428 global_gnutls_log_level, don't mistake it for a Lisp_Object.
4429 (init_gnutls_functions, emacs_gnutls_handle_error): Fix up uses.
4431 2011-07-17 Andreas Schwab <schwab@linux-m68k.org>
4433 * lread.c (read_integer): Unread even EOF character.
4434 (read1): Likewise. Properly record start position of symbol.
4436 * lread.c (read1): Read `#:' as empty uninterned symbol if no
4437 symbol character follows.
4439 2011-07-17 Paul Eggert <eggert@cs.ucla.edu>
4441 * fileio.c (Fcopy_file): Pacify gcc re fchown. (Bug#9002)
4442 This works around a problem with the previous change to Fcopy_file.
4443 Recent glibc declares fchown with __attribute__((warn_unused_result)),
4444 and without this change, GCC might complain about discarding
4445 fchown's return value.
4447 2011-07-16 Juanma Barranquero <lekktu@gmail.com>
4449 * makefile.w32-in (GLOBAL_SOURCES): Add gnutls.c (followup to bug#9059).
4451 2011-07-16 Paul Eggert <eggert@cs.ucla.edu>
4453 * fileio.c (Fcopy_file): Don't diagnose fchown failures. (Bug#9002)
4455 2011-07-16 Lars Magne Ingebrigtsen <larsi@gnus.org>
4457 * gnutls.c (syms_of_gnutls): Define `gnutls-log-level' here, since
4458 it's used from the C level.
4460 * process.c: Use the same condition for POLL_FOR_INPUT in both
4461 keyboard.c and process.c (bug#1858).
4463 2011-07-09 Lawrence Mitchell <wence@gmx.li>
4465 * gnutls.c (Qgnutls_bootprop_min_prime_bits): New variable.
4466 (Fgnutls_boot): Use it.
4468 2011-07-15 Andreas Schwab <schwab@linux-m68k.org>
4470 * doc.c (Fsubstitute_command_keys): Revert last change.
4472 2011-07-15 Lars Magne Ingebrigtsen <larsi@gnus.org>
4474 * doc.c (Fsubstitute_command_keys): Clarify that \= really only
4475 quotes the next character, and doesn't affect other longer
4476 sequences (bug#8935).
4478 * lread.c (syms_of_lread): Clarify that is isn't only
4479 `eval-buffer' and `eval-defun' that's affected by
4480 `lexical-binding' (bug#8460).
4482 2011-07-15 Eli Zaretskii <eliz@gnu.org>
4484 * xdisp.c (move_it_in_display_line_to): Fix vertical motion with
4485 bidi redisplay when a line includes both an image and is truncated.
4487 2011-07-14 Paul Eggert <eggert@cs.ucla.edu>
4489 Fix minor problems found by static checking.
4490 * bidi.c (bidi_cache_size): Now EMACS_INT, not size_t.
4491 (elsz): Now a signed constant, not a size_t var. We prefer signed
4492 types to unsigned, to avoid integer comparison confusion. Without
4493 this change, GCC 4.6.1 with -Wunsafe-loop-optimizations complains
4494 "cannot optimize loop, the loop counter may overflow", a symptom
4496 * indent.c (Fvertical_motion): Mark locals as initialized.
4497 * xdisp.c (reseat_to_string): Fix pointer signedness issue.
4499 2011-07-14 Lars Magne Ingebrigtsen <larsi@gnus.org>
4501 * search.c (Fre_search_backward): Mention `case-fold-search' in
4502 all the re_search_* functions (bug#8138).
4504 * keyboard.c (Fopen_dribble_file): Document when the file is
4507 2011-07-14 Eli Zaretskii <eliz@gnu.org>
4509 * bidi.c (bidi_dump_cached_states): Fix format of displaying
4512 Support bidi reordering of display and overlay strings.
4513 * xdisp.c (compute_display_string_pos)
4514 (compute_display_string_end): Accept additional argument STRING.
4515 (init_iterator, reseat_1): Initialize bidi_it->string.s to NULL.
4516 (reseat_to_string): Initialize bidi_it->string.s and
4517 bidi_it->string.schars.
4518 (Fcurrent_bidi_paragraph_direction): Initialize itb.string.s to
4519 NULL (avoids a crash in bidi_paragraph_init).
4520 Initialize itb.string.lstring.
4521 (init_iterator): Call bidi_init_it only of a valid
4522 buffer position was specified. Initialize paragraph_embedding to
4524 (reseat_to_string): Initialize the bidi iterator.
4525 (display_string): If we need to ignore text properties of
4526 LISP_STRING, set IT->stop_charpos to IT->end_charpos. (The
4527 original value of -1 will not work with bidi.)
4528 (compute_display_string_pos): First arg is now struct
4529 `text_pos *'; all callers changed. Support display properties on
4531 (compute_display_string_end): Support display properties on Lisp
4533 (init_iterator, reseat_1, reseat_to_string): Initialize the
4534 string.bufpos member to 0 (zero, for compatibility with IT_CHARPOS
4535 when iterating on a string not from display properties).
4536 (compute_display_string_pos, compute_display_string_end):
4537 Fix calculation of the object to scan. Fixes an error when using
4539 (next_element_from_buffer): Don't abort when IT_CHARPOS is before
4540 base_level_stop; instead, set base_level_stop to BEGV.
4541 Fixes crashes in vertical-motion.
4542 (next_element_from_buffer): Improve commentary for when
4543 the iterator is before prev_stop.
4544 (init_iterator): Initialize bidi_p from the default value of
4545 bidi-display-reordering, not from buffer-local value. Use the
4546 buffer-local value only if initializing for buffer iteration.
4547 (handle_invisible_prop): Support invisible properties on strings
4548 that are being bidi-reordered.
4549 (set_iterator_to_next): Support bidi reordering of C strings and
4551 (next_element_from_string): Support bidi reordering of Lisp
4553 (handle_stop_backwards): Support Lisp strings as well.
4554 (display_string): Support display of R2L glyph rows.
4555 Use IT_STRING_CHARPOS when displaying from a Lisp string.
4556 (init_iterator): Don't initialize it->bidi_p for strings
4558 (reseat_to_string): Initialize it->bidi_p for strings here.
4559 (next_element_from_string, next_element_from_c_string)
4560 (next_element_from_buffer): Add xassert's for correspondence
4561 between IT's object being iterated and it->bidi_it.string
4563 (face_before_or_after_it_pos): Support bidi iteration.
4564 (next_element_from_c_string): Handle the case of the first string
4565 character that is not the first one in the visual order.
4566 (get_visually_first_element): New function, refactored from common
4567 parts of next_element_from_buffer, next_element_from_string, and
4568 next_element_from_c_string.
4569 (tool_bar_lines_needed, redisplay_tool_bar)
4570 (display_menu_bar): Force left-to-right direction. Add a FIXME
4571 comment for making that be controlled by a user option.
4572 (push_it, pop_it): Save and restore the state of the
4573 bidi iterator. Save and restore the bidi_p flag.
4574 (pop_it): Iterate out of display property for string iteration as
4576 (iterate_out_of_display_property): Support iteration over strings.
4577 (handle_single_display_spec): Set up it->bidi_it for iteration
4578 over a display string, and call bidi_init_it.
4579 (handle_single_display_spec, next_overlay_string)
4580 (get_overlay_strings_1, push_display_prop): Set up the bidi
4581 iterator for displaying display or overlay strings.
4582 (forward_to_next_line_start): Don't use the shortcut if
4584 (back_to_previous_visible_line_start): If handle_display_prop
4585 pushed the iterator stack, restore the internal state of the bidi
4586 iterator by calling bidi_pop_it same number of times.
4587 (reseat_at_next_visible_line_start): If ON_NEWLINE_P is non-zero,
4588 and we are bidi-iterating, don't decrement the iterator position;
4589 instead, set the first_elt flag in the bidi iterator, to produce
4591 (reseat_1): Remove redundant setting of string_from_display_prop_p.
4592 (push_display_prop): xassert that we are iterating a buffer.
4593 (push_it, pop_it): Save and restore paragraph_embedding member.
4594 (handle_single_display_spec, next_overlay_string)
4595 (get_overlay_strings_1, reseat_1, reseat_to_string)
4596 (push_display_prop): Set up the `unibyte' member of bidi_it.string
4597 correctly. Don't assume unibyte strings are not bidi-reordered.
4598 (compute_display_string_pos)
4599 (compute_display_string_end): Fix handling the case of C string.
4600 (push_it, pop_it): Save and restore from_disp_prop_p.
4601 (handle_single_display_spec, push_display_prop): Set the
4602 from_disp_prop_p flag.
4603 (get_overlay_strings_1): Reset the from_disp_prop_p flag.
4604 (pop_it): Call iterate_out_of_display_property only if we are
4605 popping after iteration over a string that came from a display
4606 property. Fix a typo in popping stretch info. Add an assertion
4607 for verifying that the iterator position is in sync with the bidi
4609 (handle_single_display_spec, get_overlay_strings_1)
4610 (push_display_prop): Fix initialization of paragraph direction for
4611 string when that of the parent object is not yet determined.
4612 (reseat_1): Call bidi_init_it to resync the bidi
4613 iterator with IT's position. (Bug#7616)
4614 (find_row_edges): If ROW->start.pos gives position
4615 smaller than min_pos, use it as ROW->minpos. (Bug#7616)
4616 (handle_stop, back_to_previous_visible_line_start, reseat_1):
4617 Reset the from_disp_prop_p flag.
4618 (SAVE_IT, RESTORE_IT): New macros.
4619 (pos_visible_p, face_before_or_after_it_pos)
4620 (back_to_previous_visible_line_start)
4621 (move_it_in_display_line_to, move_it_in_display_line)
4622 (move_it_to, move_it_vertically_backward, move_it_by_lines)
4623 (try_scrolling, redisplay_window, display_line): Use them when
4624 saving a temporary copy of the iterator and restoring it back.
4625 (back_to_previous_visible_line_start, reseat_1)
4626 (init_iterator): Empty the bidi cache "stack".
4627 (move_it_in_display_line_to): If iterator ended up at
4628 EOL, but we never saw any buffer positions smaller than
4629 to_charpos, return MOVE_POS_MATCH_OR_ZV. Fixes vertical cursor
4630 motion in bidi-reordered lines.
4631 (move_it_in_display_line_to): Record prev_method and prev_pos
4632 immediately before the call to set_iterator_to_next. Fixes cursor
4633 motion in bidi-reordered lines with stretch glyphs and strings
4634 displayed in margins. (Bug#8133) (Bug#8867)
4635 Return MOVE_POS_MATCH_OR_ZV only if iterator position is past
4637 (pos_visible_p): Support positions in bidi-reordered lines.
4638 Save and restore bidi cache.
4640 * bidi.c (bidi_level_of_next_char): clen should be EMACS_NT, not int.
4641 (bidi_paragraph_info): Delete unused struct.
4642 (bidi_cache_idx, bidi_cache_last_idx): Declare EMACS_INT.
4643 (bidi_cache_start): New variable.
4644 (bidi_cache_reset): Reset bidi_cache_idx to bidi_cache_start, not
4646 (bidi_cache_fetch_state, bidi_cache_search)
4647 (bidi_cache_find_level_change, bidi_cache_iterator_state)
4648 (bidi_cache_find, bidi_peek_at_next_level)
4649 (bidi_level_of_next_char, bidi_find_other_level_edge)
4650 (bidi_move_to_visually_next): Compare cache index with
4651 bidi_cache_start rather than with zero.
4652 (bidi_fetch_char): Accept new argument STRING; all callers
4653 changed. Support iteration over a string. Support strings with
4654 display properties. Support unibyte strings. Fix the type of
4655 `len' according to what STRING_CHAR_AND_LENGTH expects.
4656 (bidi_paragraph_init, bidi_resolve_explicit_1)
4657 (bidi_resolve_explicit, bidi_resolve_weak)
4658 (bidi_level_of_next_char, bidi_move_to_visually_next):
4659 Support iteration over a string.
4660 (bidi_set_sor_type, bidi_resolve_explicit_1)
4661 (bidi_resolve_explicit, bidi_type_of_next_char): ignore_bn_limit
4662 can now be zero (for strings); special values 0 and -1 were
4663 changed to -1 and -2, respectively.
4664 (bidi_char_at_pos): New function.
4665 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak):
4666 Call it instead of FETCH_MULTIBYTE_CHAR.
4667 (bidi_move_to_visually_next): Abort if charpos or bytepos were not
4668 initialized to valid values.
4669 (bidi_init_it): Don't initialize charpos and bytepos with invalid
4671 (bidi_level_of_next_char): Allow the sentinel "position" to pass
4672 the test for valid cached positions. Fix the logic for looking up
4673 the sentinel state in the cache. GCPRO the Lisp string we are
4675 (bidi_push_it, bidi_pop_it): New functions.
4676 (bidi_initialize): Initialize the bidi cache start stack pointer.
4677 (bidi_cache_ensure_space): New function, refactored from part of
4678 bidi_cache_iterator_state. Don't assume the required size is just
4679 one BIDI_CACHE_CHUNK away.
4680 (bidi_cache_start_stack, bidi_push_it): Use IT_STACK_SIZE.
4681 (bidi_count_bytes, bidi_char_at_pos): New functions.
4682 (bidi_cache_search): Don't assume bidi_cache_last_idx is
4683 always valid if bidi_cache_idx is valid.
4684 (bidi_cache_find_level_change): xassert that bidi_cache_last_idx
4685 is valid if it's going to be used.
4686 (bidi_shelve_cache, bidi_unshelve_cache): New functions.
4687 (bidi_cache_fetch_state, bidi_cache_search)
4688 (bidi_cache_find_level_change, bidi_cache_ensure_space)
4689 (bidi_cache_iterator_state, bidi_cache_find)
4690 (bidi_find_other_level_edge, bidi_cache_start_stack):
4691 All variables related to cache indices are now EMACS_INT.
4693 * dispextern.h (struct bidi_string_data): New structure.
4694 (struct bidi_it): New member `string'. Make flag members be 1-bit
4695 fields, and put them last in the struct.
4696 (compute_display_string_pos, compute_display_string_end):
4698 (bidi_push_it, bidi_pop_it): Add prototypes.
4699 (struct iterator_stack_entry): New members bidi_p,
4700 paragraph_embedding, and from_disp_prop_p.
4701 (struct it): Member bidi_p is now a bit field 1 bit wide.
4702 (bidi_shelve_cache, bidi_unshelve_cache):
4705 * .gdbinit (xvectype, xvector, xcompiled, xchartable, xboolvector)
4706 (xpr, xfont, xbacktrace): Use "header.size" when accessing vectors
4707 and vector-like objects.
4709 * dispnew.c (buffer_posn_from_coords): Save and restore the bidi
4710 cache around display iteration.
4712 * window.c (Fwindow_end, window_scroll_pixel_based)
4713 (displayed_window_lines, Frecenter): Save and restore the bidi
4714 cache around display iteration.
4716 2011-07-14 Lars Magne Ingebrigtsen <larsi@gnus.org>
4718 * editfns.c (Fdelete_region): Clarify the use of the named
4719 parameters (bug#6788).
4721 2011-07-14 Martin Rudalics <rudalics@gmx.at>
4723 * indent.c (Fvertical_motion): Set and restore w->pointm when
4724 saving and restoring the window's buffer (Bug#9006).
4726 2011-07-13 Lars Magne Ingebrigtsen <larsi@gnus.org>
4728 * editfns.c (Fstring_to_char): Clarify just what is returned
4729 (bug#6576). Text by Eli Zaretskii.
4731 2011-07-13 Juanma Barranquero <lekktu@gmail.com>
4733 * gnutls.c (init_gnutls_functions): Honor gnutls_log_level (bug#9059).
4735 2011-07-13 Eli Zaretskii <eliz@gnu.org>
4737 * buffer.c (mmap_find): Fix a typo.
4739 2011-07-13 Johan Bockgård <bojohan@gnu.org>
4741 Fix execution of x selection hooks.
4742 * xselect.c (Qx_lost_selection_functions)
4743 (Qx_sent_selection_functions): New vars.
4744 (syms_of_xselect): DEFSYM them.
4745 (x_handle_selection_request): Pass Qx_sent_selection_functions
4746 rather than Vx_sent_selection_functions to Frun_hook_with_args.
4747 (x_handle_selection_clear,x_clear_frame_selections):
4748 Pass Qx_lost_selection_functions rather than
4749 Vx_lost_selection_functions to Frun_hook_with_args.
4751 2011-07-13 Paul Eggert <eggert@cs.ucla.edu>
4753 * buffer.c (Fget_buffer_create): Initialize inhibit_shrinking.
4754 The old code sometimes used this field without initializing it.
4756 * alloc.c (gc_sweep): Don't read past end of array.
4757 In theory, the old code could also have corrupted Emacs internals,
4758 though it'd be very unlikely.
4760 2011-07-12 Andreas Schwab <schwab@linux-m68k.org>
4762 * character.c (Fcharacterp): Don't advertise optional ignored
4763 argument. (Bug#4026)
4765 2011-07-12 Lars Magne Ingebrigtsen <larsi@gnus.org>
4767 * keymap.c (syms_of_keymap): Clarify that "modifier" is "modifier
4770 * window.c (Fset_window_start): Doc fix (bug#4199).
4771 (Fset_window_hscroll): Ditto.
4773 2011-07-12 Paul Eggert <eggert@cs.ucla.edu>
4775 Fix minor new problems caught by GCC 4.6.1.
4776 * term.c (init_tty): Remove unused local.
4777 * xsettings.c (store_monospaced_changed): Define this function only
4778 if (defined HAVE_GSETTINGS || defined HAVE_GCONF), as it's
4781 2011-07-12 Chong Yidong <cyd@stupidchicken.com>
4783 * xdisp.c (Vresize_mini_windows): Minor doc fix (Bug#3300).
4785 2011-07-11 Lars Magne Ingebrigtsen <larsi@gnus.org>
4787 * xdisp.c (syms_of_xdisp): Make it explicit that the mini-windows
4788 are the mini-buffer and the echo area (bug#3320).
4790 * term.c (init_tty): Remove support for supdup, c10 and perq
4791 terminals, which are no longer supported (bug#1482).
4793 2011-07-10 Johan Bockgård <bojohan@gnu.org>
4795 * xdisp.c (Ftool_bar_lines_needed): Fix WINDOWP check.
4797 2011-07-10 Jan Djärv <jan.h.d@swipnet.se>
4799 * xmenu.c (menu_highlight_callback): Only pass frame to show_help_event
4800 for non-popups (Bug#3642).
4802 2011-07-10 Andreas Schwab <schwab@linux-m68k.org>
4804 * alloc.c (reset_malloc_hooks): Protoize.
4805 * buffer.c (mmap_init, mmap_find, mmap_free_1, mmap_enlarge)
4806 (mmap_set_vars, mmap_alloc, mmap_free, mmap_realloc): Likewise.
4807 * cm.c (losecursor): Likewise.
4808 * data.c (fmod): Likewise.
4809 * dispnew.c (swap_glyphs_in_rows): Likewise.
4810 * emacs.c (memory_warning_signal): Likewise.
4811 * floatfns.c (float_error): Likewise.
4812 * font.c (check_gstring, check_otf_features, otf_tag_symbol)
4813 (otf_open, font_otf_capability, generate_otf_features)
4814 (font_otf_DeviceTable, font_otf_ValueRecord, font_otf_Anchor):
4816 * image.c (pbm_read_file): Likewise.
4817 * indent.c (string_display_width): Likewise.
4818 * intervals.c (check_for_interval, search_for_interval)
4819 (inc_interval_count, count_intervals, root_interval)
4820 (adjust_intervals_for_insertion, make_new_interval): Likewise.
4821 * lread.c (defalias): Likewise.
4822 * ralloc.c (r_alloc_check): Likewise.
4823 * regex.c (set_image_of_range_1, set_image_of_range)
4824 (regex_grow_registers): Likewise.
4825 * sysdep.c (strerror): Likewise.
4826 * termcap.c (valid_filename_p, tprint, main): Likewise.
4827 * tparam.c (main): Likewise.
4828 * unexhp9k800.c (run_time_remap, save_data_space)
4829 (update_file_ptrs, read_header, write_header, calculate_checksum)
4830 (copy_file, copy_rest, display_header): Likewise.
4831 * widget.c (mark_shell_size_user_specified, create_frame_gcs):
4833 * xdisp.c (check_it): Likewise.
4834 * xfaces.c (register_color, unregister_color, unregister_colors):
4836 * xfns.c (print_fontset_result): Likewise.
4837 * xrdb.c (member, fatal, main): Likewise.
4839 2011-07-10 Paul Eggert <eggert@cs.ucla.edu>
4841 Fix minor problems found by static checking (Bug#9031).
4842 * chartab.c (char_table_set_range, map_sub_char_table):
4843 Remove unused locals.
4844 (uniprop_table): Now static.
4845 * composite.c (_work_char): Remove unused static var.
4847 2011-07-09 Juanma Barranquero <lekktu@gmail.com>
4849 * chartab.c (uniprop_table_uncompress): Remove unused local variable.
4851 2011-07-09 Jan Djärv <jan.h.d@swipnet.se>
4853 * gtkutil.c (qttip_cb): Remove code without function.
4855 2011-07-09 Eli Zaretskii <eliz@gnu.org>
4857 * w32.c (pthread_sigmask): New stub.
4859 2011-07-08 Paul Eggert <eggert@cs.ucla.edu>
4861 Use pthread_sigmask, not sigprocmask (Bug#9010).
4862 sigprocmask is portable only for single-threaded applications, and
4863 Emacs can be multi-threaded when it uses GTK.
4864 * Makefile.in (LIB_PTHREAD_SIGMASK): New macro.
4866 * callproc.c (Fcall_process):
4867 * process.c (create_process):
4868 * sysdep.c (sys_sigblock, sys_sigunblock, sys_sigsetmask):
4869 Use pthread_sigmask, not sigprocmask.
4871 2011-07-08 Jan Djärv <jan.h.d@swipnet.se>
4873 * gtkutil.c (qttip_cb): Set line wrap to FALSE for tooltip widget.
4874 (xg_prepare_tooltip): Revert text in x->ttip_lbl, margins was
4877 2011-07-08 Jan Djärv <jan.h.d@swipnet.se>
4879 * gtkutil.c (xg_prepare_tooltip): Fix indentation and comment.
4880 Put text in x->ttip_lbl instead of gtk_tooltip_set_text (Bug#8591).
4881 (xg_hide_tooltip): Fix comment.
4883 * nsterm.m (initFrameFromEmacs): Don't use ns_return_types
4884 in registerServicesMenuSendTypes.
4885 (validRequestorForSendType): Don't check ns_return_types.
4887 * nsfns.m (Fx_open_connection): Put NSStringPboardType into
4890 2011-07-08 Jason Rumney <jasonr@gnu.org>
4892 * w32term.c (x_make_frame_visible): Use SH_SHOWNORMAL rather than
4893 SH_SHOW for hidden windows (Bug#5482).
4895 * w32fns.c (w32_wnd_proc) [WM_TIMER, WM_SET_CURSOR]: Avoid using
4896 frame struct members of non-existent frames (Bug#6284).
4898 2011-07-08 Jan Djärv <jan.h.d@swipnet.se>
4900 * nsterm.m (keyDown): Call to wantsToDelayTextChangeNotifications and
4901 variable firstTime not needed on OSX >= 10.6.
4902 (setPosition): setFloatValue:knobProportion: is deprecated on OSX
4903 >= 10.5. Use setKnobProportion, setDoubleValue.
4905 * nsterm.h (MAC_OS_X_VERSION_10_3, MAC_OS_X_VERSION_10_4)
4906 (MAC_OS_X_VERSION_10_5): Define if not defined.
4907 (EmacsView, EmacsTooltip): Implements NSWindowDelegate on OSX >= 10.6.
4908 (EmacsMenu): Implements NSMenuDelegate on OSX >= 10.6.
4909 (EmacsToolbar): Implements NSToolbarDelegate on OSX >= 10.6.
4911 * nsselect.m (ns_string_from_pasteboard): Don't use deprecated methods
4912 cString and lossyCString on OSX >= 10.4
4914 * nsmenu.m (fillWithWidgetValue): Don't use deprecated method
4915 sizeToFit on OSX >= 10.2.
4917 * nsimage.m (allocInitFromFile): Don't use deprecated method
4918 bestRepresentationForDevice on OSX >= 10.6.
4920 * nsfns.m (check_ns_display_info): Cast to long and use %ld in error
4923 * emacs.c: Declare unexec_init_emacs_zone.
4925 * nsgui.h: Fix compiler warning about gnulib redefining verify.
4927 * nsselect.m (ns_get_local_selection): Change to extern (Bug#8842).
4929 * nsmenu.m (ns_update_menubar): Remove useless setDelegate call
4930 on svcsMenu (Bug#8842).
4932 * nsfns.m (Fx_open_connection): Remove NSStringPboardType from
4934 (Fns_list_services): Just return Qnil on 10.6, code not working there.
4936 * nsterm.m (QUTF8_STRING): Declare.
4937 (initFrameFromEmacs): Call registerServicesMenuSendTypes.
4938 (validRequestorForSendType): Return type is (id).
4939 Change indexOfObjectIdenticalTo to indexOfObject.
4940 Check if we have local selection before returning self (Bug#8842).
4941 (writeSelectionToPasteboard): Put local selection into paste board
4942 if we have a local selection (Bug#8842).
4943 (syms_of_nsterm): DEFSYM QUTF8_STRING.
4945 * nsterm.h (MAC_OS_X_VERSION_10_6): Define here instead of nsterm.m.
4946 (ns_get_local_selection): Declare.
4948 2011-07-07 Lars Magne Ingebrigtsen <larsi@gnus.org>
4950 * keymap.c (describe_map_tree): Don't insert a double newline at
4951 the end of the buffer (bug#1169) and return whether we inserted
4954 * callint.c (Fcall_interactively): Change "reading args" to
4955 "providing args" to try to clarify what it does (bug#1010).
4957 2011-07-07 Kenichi Handa <handa@m17n.org>
4959 * composite.c (composition_compute_stop_pos): Ignore a static
4960 composition starting before CHARPOS (Bug#8915).
4962 * xdisp.c (handle_composition_prop): Likewise.
4964 2011-07-07 Eli Zaretskii <eliz@gnu.org>
4966 * term.c (produce_glyphs) <xassert>: Allow IT_GLYPHLESS in it->what.
4969 2011-07-07 Kenichi Handa <handa@m17n.org>
4971 * character.h (unicode_category_t): New enum type.
4973 * chartab.c (uniprop_decoder_t, uniprop_encoder_t): New types.
4974 (Qchar_code_property_table): New variable.
4975 (UNIPROP_TABLE_P, UNIPROP_GET_DECODER)
4976 (UNIPROP_COMPRESSED_FORM_P): New macros.
4977 (char_table_ascii): Uncompress the compressed values.
4978 (sub_char_table_ref): New arg is_uniprop. Callers changed.
4979 Uncompress the compressed values.
4980 (sub_char_table_ref_and_range): Likewise.
4981 (char_table_ref_and_range): Uncompress the compressed values.
4982 (sub_char_table_set): New arg is_uniprop. Callers changed.
4983 Uncompress the compressed values.
4984 (sub_char_table_set_range): Args changed. Callers changed.
4985 (char_table_set_range): Adjuted for the above change.
4986 (map_sub_char_table): Delete args default_val and parent. Add arg
4987 top. Give decoded values to a Lisp function.
4988 (map_char_table): Adjust for the above change. Give decoded
4989 values to a Lisp function. Gcpro more variables.
4990 (uniprop_table_uncompress)
4991 (uniprop_decode_value_run_length): New functions.
4992 (uniprop_decoder, uniprop_decoder_count): New variables.
4993 (uniprop_get_decoder, uniprop_encode_value_character)
4994 (uniprop_encode_value_run_length, uniprop_encode_value_numeric):
4996 (uniprop_encoder, uniprop_encoder_count): New variables.
4997 (uniprop_get_encoder, uniprop_table)
4998 (Funicode_property_table_internal, Fget_unicode_property_internal)
4999 (Fput_unicode_property_internal): New functions.
5000 (syms_of_chartab): DEFSYM Qchar_code_property_table, defsubr
5001 Sunicode_property_table_internal, Sget_unicode_property_internal,
5002 and Sput_unicode_property_internal. Defvar_lisp
5003 char-code-property-alist.
5005 * composite.c (CHAR_COMPOSABLE_P): Adjust for the change of
5006 Vunicode_category_table.
5008 * font.c (font_range): Adjust for the change of
5009 Vunicode_category_table.
5011 2011-07-07 Dan Nicolaescu <dann@ics.uci.edu>
5013 * m/iris4d.h: Remove file, move contents ...
5014 * s/irix6-5.h: ... here.
5016 2011-07-06 Paul Eggert <eggert@cs.ucla.edu>
5018 Remove unportable assumption about struct layout (Bug#8884).
5019 * alloc.c (mark_buffer):
5020 * buffer.c (reset_buffer_local_variables, Fbuffer_local_variables)
5021 (clone_per_buffer_values): Don't assume that
5022 sizeof (struct buffer) is a multiple of sizeof (Lisp_Object).
5023 This isn't true in general, and it's particularly not true
5024 if Emacs is configured with --with-wide-int.
5025 * buffer.h (FIRST_FIELD_PER_BUFFER, LAST_FIELD_PER_BUFFER):
5026 New macros, used in the buffer.c change.
5028 2011-07-05 Jan Djärv <jan.h.d@swipnet.se>
5030 * xsettings.c: Use both GConf and GSettings if both are available.
5031 (store_config_changed_event): Add comment.
5032 (dpyinfo_valid, store_font_name_changed, map_tool_bar_style)
5033 (store_tool_bar_style_changed): New functions.
5034 (store_monospaced_changed): Add comment. Call dpyinfo_valid.
5035 (struct xsettings): Move font inside HAVE_XFT.
5036 (GSETTINGS_TOOL_BAR_STYLE, GSETTINGS_FONT_NAME): New defines.
5037 (GSETTINGS_MONO_FONT): Rename from SYSTEM_MONO_FONT.
5038 Move inside HAVE_XFT.
5039 (something_changed_gsettingsCB): Rename from something_changedCB.
5040 Check for changes in GSETTINGS_TOOL_BAR_STYLE and GSETTINGS_FONT_NAME
5042 (GCONF_TOOL_BAR_STYLE, GCONF_FONT_NAME): New defines.
5043 (GCONF_MONO_FONT): Rename from SYSTEM_MONO_FONT. Move inside HAVE_XFT.
5044 (something_changed_gconfCB): Rename from something_changedCB.
5045 Check for changes in GCONF_TOOL_BAR_STYLE and GCONF_FONT_NAME also.
5046 (parse_settings): Move check for font inside HAVE_XFT.
5047 (read_settings, apply_xft_settings): Add comment.
5048 (read_and_apply_settings): Add comment. Call map_tool_bar_style and
5049 store_tool_bar_style_changed. Move check for font inside HAVE_XFT and
5050 call store_font_name_changed.
5051 (xft_settings_event): Add comment.
5052 (init_gsettings): Add comment. Get values for GSETTINGS_TOOL_BAR_STYLE
5053 and GSETTINGS_FONT_NAME. Move check for fonts within HAVE_XFT.
5054 (init_gconf): Add comment. Get values for GCONF_TOOL_BAR_STYLE
5055 and GCONF_FONT_NAME. Move check for fonts within HAVE_XFT.
5056 (xsettings_initialize): Call init_gsettings last.
5057 (xsettings_get_system_font, xsettings_get_system_normal_font):
5060 2011-07-05 Paul Eggert <eggert@cs.ucla.edu>
5062 Random fixes. E.g., (random) never returned negative values.
5063 * fns.c (Frandom): Use GET_EMACS_TIME for random seed, and add the
5064 subseconds part to the entropy, as that's a bit more random.
5065 Prefer signed to unsigned, since the signedness doesn't matter and
5066 in general we prefer signed. When given a limit, use a
5067 denominator equal to INTMASK + 1, not to VALMASK + 1, because the
5068 latter isn't right if USE_2_TAGS_FOR_INTS.
5069 * sysdep.c (get_random): Return a value in the range 0..INTMASK,
5070 not 0..VALMASK. Don't discard "excess" bits that random () returns.
5072 2011-07-04 Stefan Monnier <monnier@iro.umontreal.ca>
5074 * textprop.c (text_property_stickiness):
5075 Obey Vtext_property_default_nonsticky.
5076 (syms_of_textprop): Add `display' to Vtext_property_default_nonsticky.
5077 * w32fns.c (syms_of_w32fns):
5078 * xfns.c (syms_of_xfns): Don't Add `display' since it's there by default.
5080 2011-07-04 Paul Eggert <eggert@cs.ucla.edu>
5082 * fileio.c (barf_or_query_if_file_exists): Use S_ISDIR.
5083 This is more efficient than Ffile_directory_p and avoids a minor race.
5085 2011-07-04 Lars Magne Ingebrigtsen <larsi@gnus.org>
5087 * buffer.c (Foverlay_put): Say what the return value is
5090 * fileio.c (barf_or_query_if_file_exists): Check first if the file
5091 is a directory before asking whether to use the file name
5093 (barf_or_query_if_file_exists): Make the "File is a directory"
5094 error be more correct.
5096 * fns.c (Frequire): Remove the mention of the .gz files, since
5097 that's installation-specific, but keep the mention of
5098 `get-load-suffixes'.
5100 2011-07-04 Paul Eggert <eggert@cs.ucla.edu>
5102 * editfns.c (Fformat_time_string): Don't assume strlen fits in int.
5103 Report string overflow if the output is too long.
5105 2011-07-04 Juanma Barranquero <lekktu@gmail.com>
5107 * gnutls.c (Fgnutls_boot): Don't mention :verify-error.
5108 (syms_of_gnutls): Remove duplicate DEFSYM for
5109 Qgnutls_bootprop_verify_hostname_error, an error for
5110 Qgnutls_bootprop_verify_error (which is no longer used).
5112 * eval.c (find_handler_clause): Remove parameters `sig' and `data',
5113 unused since 2011-01-26T20:02:07Z!monnier@iro.umontreal.ca. All callers changed.
5114 Also (re)move comments that are misplaced or no longer relevant.
5116 2011-07-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
5118 * callint.c (Finteractive): Clarify the meaning of "@" (bug#8813).
5120 2011-07-03 Chong Yidong <cyd@stupidchicken.com>
5122 * xfaces.c (Finternal_merge_in_global_face): Modify the foreground
5123 and background color parameters if they have been changed.
5125 2011-07-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
5127 * editfns.c (Fformat): Clarify the - and 0 flags (bug#6659).
5129 2011-07-03 Paul Eggert <eggert@cs.ucla.edu>
5131 * xsettings.c (SYSTEM_FONT): Define only when used.
5132 No need to define when HAVE_GSETTINGS || !HAVE_XFT.
5134 * keymap.c (access_keymap_1): Now static.
5136 2011-07-02 Chong Yidong <cyd@stupidchicken.com>
5138 * keyboard.c (command_loop_1): If a down-mouse event is unbound,
5139 leave any prefix arg for the up event (Bug#1586).
5141 2011-07-02 Lars Magne Ingebrigtsen <larsi@gnus.org>
5143 * lread.c (syms_of_lread): Mention single symbols defined by
5144 `defvar' or `defconst' (bug#7154).
5146 * fns.c (Frequire): Mention .el.gz files (bug#7314).
5147 (Frequire): Mention get-load-suffixes.
5149 2011-07-02 Martin Rudalics <rudalics@gmx.at>
5151 * window.h (window): Remove clone_number slot.
5152 * window.c (Fwindow_clone_number, Fset_window_clone_number):
5154 (make_parent_window, make_window, saved_window)
5155 (Fset_window_configuration, save_window_save): Don't deal with
5157 * buffer.c (Qclone_number): Remove declaration.
5158 (sort_overlays, overlay_strings): Don't deal with clone numbers.
5160 2011-07-02 Stefan Monnier <monnier@iro.umontreal.ca>
5162 Add multiple inheritance to keymaps.
5163 * keymap.c (Fmake_composed_keymap): New function.
5164 (Fset_keymap_parent): Simplify.
5165 (fix_submap_inheritance): Remove.
5166 (access_keymap_1): New function extracted from access_keymap to handle
5167 embedded parents and handle lists of maps.
5168 (access_keymap): Use it.
5169 (Fkeymap_prompt, map_keymap_internal, map_keymap, store_in_keymap)
5170 (Fcopy_keymap): Handle embedded parents.
5171 (Fcommand_remapping, define_as_prefix): Simplify.
5172 (Fkey_binding): Simplify.
5173 (syms_of_keymap): Move minibuffer-local-completion-map,
5174 minibuffer-local-filename-completion-map,
5175 minibuffer-local-must-match-map, and
5176 minibuffer-local-filename-must-match-map to Elisp.
5177 (syms_of_keymap): Defsubr make-composed-keymap.
5178 * keyboard.c (menu_bar_items): Use map_keymap_canonical.
5179 (parse_menu_item): Trivial simplification.
5181 2011-07-01 Glenn Morris <rgm@gnu.org>
5183 * Makefile.in (SETTINGS_LIBS): Fix typo.
5185 2011-07-01 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny patch)
5187 * coding.c (Fencode_coding_string): Record the last coding system
5188 used, as the function doc string says (bug#8738).
5190 2011-07-01 Jan Djärv <jan.h.d@swipnet.se>
5192 * xsettings.c (store_monospaced_changed): Take new font as arg and
5193 check for change against current_mono_font.
5194 (EMACS_TYPE_SETTINGS): Remove this and related defines.
5195 (emacs_settings_constructor, emacs_settings_get_property)
5196 (emacs_settings_set_property, emacs_settings_class_init)
5197 (emacs_settings_init, gsettings_obj): Remove.
5198 (something_changedCB): New function for HAVE_GSETTINGS.
5199 (something_changedCB): HAVE_GCONF: Call store_monospaced_changed
5200 with value as argument.
5201 (init_gsettings): Check that GSETTINGS_SCHEMA exists before calling
5202 g_settings_new (Bug#8967). Do not create gsettings_obj.
5203 Remove calls to g_settings_bind. Connect something_changedCB to
5206 * xgselect.c: Add defined (HAVE_GSETTINGS).
5207 (xgselect_initialize): Ditto.
5209 * process.c: Add defined (HAVE_GSETTINGS) for xgselect.h
5210 (wait_reading_process_output): Add defined (HAVE_GSETTINGS) for
5213 2011-07-01 Paul Eggert <eggert@cs.ucla.edu>
5215 * eval.c (struct backtrace): Simplify and port the data structure.
5216 Do not assume that "int nargs : BITS_PER_INT - 2;" produces a
5217 signed bit field, as this assumption is not portable and it makes
5218 Emacs crash when compiled with Sun C 5.8 on sparc. Do not use
5219 "char debug_on_exit : 1" as this is not portable either; instead,
5220 use the portable "unsigned int debug_on_exit : 1". Remove unused
5221 member evalargs. Remove obsolete comments about cc bombing out.
5223 2011-06-30 Jan Djärv <jan.h.d@swipnet.se>
5225 * xsettings.c: Include glib-object.h, gio/gio.h if HAVE_GSETTINGS.
5226 Let HAVE_GSETTINGS override HAVE_GCONF.
5227 (store_monospaced_changed): New function.
5228 (EMACS_SETTINGS): A new type derived from GObject to handle
5229 GSettings notifications.
5230 (emacs_settings_constructor, emacs_settings_get_property)
5231 (emacs_settings_set_property, emacs_settings_class_init):
5233 (gsettings_client, gsettings_obj): New variables.
5234 (GSETTINGS_SCHEMA): New define.
5235 (something_changedCB): Call store_monospaced_changed.
5236 (init_gsettings): New function.
5237 (xsettings_initialize): Call init_gsettings.
5238 (syms_of_xsettings): Initialize gsettings_client, gsettings_obj
5241 * Makefile.in (SETTINGS_CFLAGS, SETTINGS_LIBS): Rename from
5244 2011-06-29 Martin Rudalics <rudalics@gmx.at>
5246 * window.c (resize_root_window, grow_mini_window)
5247 (shrink_mini_window): Rename Qresize_root_window to
5248 Qwindow_resize_root_window and Qresize_root_window_vertically to
5249 Qwindow_resize_root_window_vertically.
5251 2011-06-28 Paul Eggert <eggert@cs.ucla.edu>
5253 * gnutls.c (Qgnutls_bootprop_verify_error): Remove unused var.
5255 2011-06-27 Juanma Barranquero <lekktu@gmail.com>
5257 * makefile.w32-in: Redesign dependencies so they reflect more
5258 clearly which files are directly included by each source file,
5259 and not through other includes.
5261 2011-06-27 Martin Rudalics <rudalics@gmx.at>
5263 * buffer.c (Qclone_number): Declare static and DEFSYM it.
5264 (sort_overlays, overlay_strings): When an overlay's clone number
5265 matches the window's clone number process the overlay even if
5266 the overlay's window property doesn't match the current window.
5268 * window.c (Fwindow_vchild): Rename to Fwindow_top_child.
5269 (Fwindow_hchild): Rename to Fwindow_left_child.
5270 (Fwindow_next): Rename to Fwindow_next_sibling.
5271 (Fwindow_prev): Rename to Fwindow_prev_sibling.
5272 (resize_window_check): Rename to window_resize_check.
5273 (resize_window_apply): Rename to window_resize_apply.
5274 (Fresize_window_apply): Rename to Fwindow_resize_apply.
5275 (Fdelete_other_windows_internal, resize_frame_windows)
5276 (Fsplit_window_internal, Fdelete_window_internal)
5277 (grow_mini_window, shrink_mini_window)
5278 (Fresize_mini_window_internal): Fix callers accordingly.
5280 2011-06-26 Jan Djärv <jan.h.d@swipnet.se>
5282 * emacsgtkfixed.h: State that this is only used with Gtk+3.
5283 (emacs_fixed_set_min_size): Remove.
5284 (emacs_fixed_new): Take frame as argument.
5286 * emacsgtkfixed.c: State that this is only used with Gtk+3.
5287 (_EmacsFixedPrivate): Remove minwidth/height.
5288 Add struct frame *f.
5289 (emacs_fixed_init): Initialize priv->f.
5290 (get_parent_class, emacs_fixed_set_min_size): Remove.
5291 (emacs_fixed_new): Set priv->f to argument.
5292 (emacs_fixed_get_preferred_width)
5293 (emacs_fixed_get_preferred_height): Use min_width/height from
5294 frames size_hint to set minimum and natural (Bug#8919).
5295 (XSetWMSizeHints, XSetWMNormalHints): Override these functions
5296 and use min_width/height from frames size_hint to set
5297 min_width/height (Bug#8919).
5299 * gtkutil.c (xg_create_frame_widgets): Pass f to emacs_fixed_new.
5300 (x_wm_set_size_hint): Remove call to emacs_fixed_set_min_size.
5303 2011-06-26 Eli Zaretskii <eliz@gnu.org>
5305 * bidi.c (bidi_paragraph_init): Test for ZV_BYTE before calling
5306 bidi_at_paragraph_end, since fast_looking_at doesn't like to be
5309 2011-06-26 Chong Yidong <cyd@stupidchicken.com>
5311 * process.c (wait_reading_process_output): Bypass select if
5312 waiting for a cell while ignoring keyboard input, and input is
5313 pending. Suggested by Jan Djärv (Bug#8869).
5315 2011-06-25 Paul Eggert <eggert@cs.ucla.edu>
5317 Use gnulib's dup2 module instead of rolling our own.
5318 * sysdep.c (dup2) [!HAVE_DUP2]: Remove; gnulib now does this.
5320 2011-06-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
5322 * dispnew.c (scrolling_window): Before scrolling, turn off a
5323 mouse-highlight in the window being scrolled.
5325 2011-06-24 Juanma Barranquero <lekktu@gmail.com>
5327 Move DEFSYM to lisp.h and use everywhere.
5329 * character.h (DEFSYM): Move declaration...
5330 * lisp.h (DEFSYM): ...here.
5336 * w32select.c: Don't include character.h.
5338 * alloc.c (syms_of_alloc):
5339 * buffer.c (syms_of_buffer):
5340 * bytecode.c (syms_of_bytecode):
5341 * callint.c (syms_of_callint):
5342 * casefiddle.c (syms_of_casefiddle):
5343 * casetab.c (init_casetab_once):
5344 * category.c (init_category_once, syms_of_category):
5345 * ccl.c (syms_of_ccl):
5346 * cmds.c (syms_of_cmds):
5347 * composite.c (syms_of_composite):
5348 * dbusbind.c (syms_of_dbusbind):
5349 * dired.c (syms_of_dired):
5350 * dispnew.c (syms_of_display):
5351 * doc.c (syms_of_doc):
5352 * editfns.c (syms_of_editfns):
5353 * emacs.c (syms_of_emacs):
5354 * eval.c (syms_of_eval):
5355 * fileio.c (syms_of_fileio):
5356 * fns.c (syms_of_fns):
5357 * frame.c (syms_of_frame):
5358 * fringe.c (syms_of_fringe):
5359 * insdel.c (syms_of_insdel):
5360 * keymap.c (syms_of_keymap):
5361 * lread.c (init_obarray, syms_of_lread):
5362 * macros.c (syms_of_macros):
5363 * msdos.c (syms_of_msdos):
5364 * print.c (syms_of_print):
5365 * process.c (syms_of_process):
5366 * search.c (syms_of_search):
5367 * sound.c (syms_of_sound):
5368 * syntax.c (init_syntax_once, syms_of_syntax):
5369 * terminal.c (syms_of_terminal):
5370 * textprop.c (syms_of_textprop):
5371 * undo.c (syms_of_undo):
5372 * w32.c (globals_of_w32):
5373 * window.c (syms_of_window):
5374 * xdisp.c (syms_of_xdisp):
5375 * xfaces.c (syms_of_xfaces):
5376 * xfns.c (syms_of_xfns):
5377 * xmenu.c (syms_of_xmenu):
5378 * xsettings.c (syms_of_xsettings):
5379 * xterm.c (syms_of_xterm): Use DEFSYM.
5381 2011-06-24 Teodor Zlatanov <tzz@lifelogs.com>
5383 * gnutls.c (syms_of_gnutls): Use the DEFSYM macro from character.h.
5385 2011-06-23 Paul Eggert <eggert@cs.ucla.edu>
5387 Integer and buffer overflow fixes (Bug#8873).
5389 * print.c (printchar, strout): Check for string overflow.
5390 (PRINTPREPARE, printchar, strout):
5391 Don't set size unless allocation succeeds.
5393 * minibuf.c (read_minibuf_noninteractive): Use ptrdiff_t, not int,
5394 for sizes. Check for string overflow more accurately.
5395 Simplify newline removal at end; this suppresses a GCC 4.6.0 warning.
5397 * macros.c: Integer and buffer overflow fixes.
5398 * keyboard.h (struct keyboard.kbd_macro_bufsize):
5399 * macros.c (Fstart_kbd_macro, store_kbd_macro_char):
5400 Use ptrdiff_t, not int, for sizes.
5401 Don't increment bufsize until after realloc succeeds.
5402 Check for size-calculation overflow.
5403 (Fstart_kbd_macro): Use EMACS_INT, not int, for XINT result.
5405 * lisp.h (DEFVAR_KBOARD): Use offsetof instead of char * finagling.
5407 * lread.c: Integer overflow fixes.
5408 (read_integer): Radix is now EMACS_INT, not int,
5409 to improve quality of diagnostics for out-of-range radices.
5410 Calculate buffer size correctly for out-of-range radices.
5411 (read1): Check for integer overflow in radices, and in
5412 read-circle numbers.
5413 (read_escape): Avoid int overflow.
5414 (Fload, openp, read_buffer_size, read1)
5415 (substitute_object_recurse, read_vector, read_list, map_obarray):
5416 Use ptrdiff_t, not int, for sizes.
5417 (read1): Use EMACS_INT, not int, for sizes.
5418 Check for size overflow.
5420 * image.c (cache_image): Check for size arithmetic overflow.
5422 * lread.c: Integer overflow issues.
5423 (saved_doc_string_size, saved_doc_string_length)
5424 (prev_saved_doc_string_size, prev_saved_doc_string_length):
5425 Now ptrdiff_t, not int.
5426 (read1): Don't assume doc string length fits in int. Check for
5427 out-of-range doc string lengths.
5428 (read_list): Don't assume file position fits in int.
5429 (read_escape): Check for hex character overflow.
5431 2011-06-22 Leo Liu <sdl.web@gmail.com>
5433 * minibuf.c (Fcompleting_read_default, Vcompleting_read_function):
5434 Move to minibuffer.el.
5436 2011-06-22 Paul Eggert <eggert@cs.ucla.edu>
5438 Fixes for GLYPH_DEBUG found by GCC 4.6.0 static checking.
5439 The following patches are for when GLYPH_DEBUG && !XASSERT.
5440 * dispextern.h (trace_redisplay_p, dump_glyph_string):
5441 * dispnew.c (flush_stdout):
5442 * xdisp.c (dump_glyph_row, dump_glyph_matrix, dump_glyph):
5443 Mark as externally visible.
5444 * dispnew.c (check_window_matrix_pointers): Now static.
5445 * dispnew.c (window_to_frame_vpos):
5446 * xfns.c (unwind_create_frame):
5447 * xterm.c (x_check_font): Remove unused local.
5448 * scroll.c (CHECK_BOUNDS):
5449 * xfaces.c (cache_fache): Rename local to avoid shadowing.
5450 * xfns.c, w32fns.c (image_cache_refcount, dpyinfo_refcount): Now static.
5451 * xdisp.c (check_window_end): Now a no-op if !XASSERTS.
5452 (debug_first_unchanged_at_end_vpos, debug_last_unchanged_at_beg_vpos)
5453 (debug_dvpos, debug_dy, debug_delta, debug_delta_bytes, debug_end_vpos):
5455 (debug_method_add): Use va_list and vsprintf rather than relying
5456 on undefined behavior with wrong number of arguments.
5457 (dump_glyph, dump_glyph_row, Fdump_glyph_matrix):
5458 Don't assume ptrdiff_t and EMACS_INT are the same width as int.
5459 In this code, it's OK to assume C99 behavior for ptrdiff_t formats
5460 since we're not interested in debugging glyphs with old libraries.
5461 * xfaces.c (cache_face): Move debugging code earlier; this pacifies
5462 GCC 4.6.0's static checking.
5464 2011-06-22 Paul Eggert <eggert@cs.ucla.edu>
5466 Integer overflow and signedness fixes (Bug#8873).
5467 A few related buffer overrun fixes, too.
5469 * font.c (font_score): Use EMACS_INT, not int, to store XINT value.
5471 * dispextern.h (struct face.stipple):
5472 * image.c (x_bitmap_height, x_bitmap_width, x_bitmap_pixmap)
5473 (x_bitmap_mask, x_allocate_bitmap_record)
5474 (x_create_bitmap_from_data, x_create_bitmap_from_file)
5475 (x_destroy_bitmap, x_destroy_all_bitmaps, x_create_bitmap_mask)
5476 (x_create_bitmap_from_xpm_data):
5477 * nsterm.h (struct ns_display_info.bitmaps_size, .bitmaps_last):
5478 * w32term.h (struct w32_display_info.icon_bitmap_id, .bitmaps_size)
5480 * xfaces.c (load_pixmap):
5481 * xterm.c (x_bitmap_icon, x_wm_set_icon_pixmap):
5482 * xterm.h (struct x_display_info.icon_bitmap_id, .bitmaps_size)
5483 (.bitmaps_last, struct x_output.icon_bitmap):
5484 Use ptrdiff_t, not int, for bitmap indexes.
5485 (x_allocate_bitmap_record): Check for size overflow.
5486 * dispextern.h, lisp.h: Adjust to API changes elsewhere.
5488 Use ptrdiff_t, not int, for overlay counts.
5489 * buffer.h (overlays_at, sort_overlays, GET_OVERLAYS_AT):
5490 * editfns.c (overlays_around, get_pos_property):
5491 * textprop.c (get_char_property_and_overlay):
5492 * xdisp.c (next_overlay_change, note_mouse_highlight):
5493 * xfaces.c (face_at_buffer_position):
5494 * buffer.c (OVERLAY_COUNT_MAX): New macro.
5495 (overlays_at, overlays_in, sort_overlays, Foverlays_at)
5496 (Fnext_overlay_change, Fprevious_overlay_change)
5497 (mouse_face_overlay_overlaps, Foverlays_in):
5498 Use ptrdiff_t, not int, for sizes.
5499 (overlays_at, overlays_in): Check for size-calculation overflow.
5501 * xterm.c (xim_initialize, same_x_server): Strlen may not fit in int.
5503 * xsmfns.c (smc_save_yourself_CB, x_session_initialize): Avoid strlen.
5504 (x_session_initialize): Do not assume string length fits in int.
5506 * xsettings.c (apply_xft_settings): Fix potential buffer overrun.
5507 This is unlikely, but can occur if DPI is outlandish.
5509 * xsettings.c (Ffont_get_system_normal_font, Ffont_get_system_font):
5510 * xselect.c (Fx_get_atom_name): Avoid need for strlen.
5512 * xrdb.c: Don't assume strlen fits in int; avoid some strlens.
5513 * xrdb.c (magic_file_p, search_magic_path):
5514 Omit last arg SUFFIX; it was always 0. All callers changed.
5515 (magic_file_p): Use ptrdiff_t, not int. Check for size overflow.
5517 * xfont.c (xfont_match): Avoid need for strlen.
5519 * xfns.c: Don't assume strlen fits in int.
5520 (xic_create_fontsetname, x_window): Use ptrdiff_t, not int.
5522 * xdisp.c (message_log_check_duplicate): Return intmax_t,
5523 not unsigned long, as we prefer signed integers. All callers changed.
5524 Detect integer overflow in repeat count.
5525 (message_dolog): Don't assume print length fits in 39 bytes.
5526 (display_mode_element): Don't assume strlen fits in int.
5528 * termcap.c: Don't assume sizes fit in int and never overflow.
5529 (struct termcap_buffer, tgetent): Use ptrdiff_t, not int, for sizes.
5530 (gobble_line): Check for size-calculation overflow.
5532 * minibuf.c (Fread_buffer):
5533 * lread.c (intern, intern_c_string):
5534 * image.c (xpm_scan) [HAVE_NS && !HAVE_XPM]:
5535 Don't assume string length fits in int.
5537 * keyboard.c (parse_tool_bar_item):
5538 * gtkutil.c (style_changed_cb): Avoid need for strlen.
5540 * font.c: Don't assume string length fits in int.
5541 (font_parse_xlfd, font_parse_fcname, font_unparse_fcname):
5542 Use ptrdiff_t, not int.
5543 (font_intern_prop): Don't assume string length fits in int.
5544 Don't assume integer property fits in fixnum.
5545 * font.h (font_intern_prop): 2nd arg is now ptrdiff_t, not int.
5547 * filelock.c: Fix some buffer overrun and integer overflow issues.
5548 (get_boot_time): Don't assume gzip command string fits in 100 bytes.
5549 Reformulate so as not to need the command string.
5550 Invoke gzip -cd rather than gunzip, as it's more portable.
5551 (lock_info_type, lock_file_1, lock_file):
5552 Don't assume pid_t and time_t fit in unsigned long.
5553 (LOCK_PID_MAX): Remove; we now use more-reliable bounds.
5554 (current_lock_owner): Prefer signed type for sizes.
5555 Use memcpy, not strncpy, where memcpy is what is really wanted.
5556 Don't assume (via atoi) that time_t and pid_t fit in int.
5557 Check for time_t and/or pid_t out of range, e.g., via a network share.
5558 Don't alloca where an auto var works fine.
5560 * fileio.c: Fix some integer overflow issues.
5561 (file_name_as_directory, Fexpand_file_name, Fsubstitute_in_file_name):
5562 Don't assume string length fits in int.
5563 (directory_file_name): Don't assume string length fits in long.
5564 (make_temp_name): Don't assume pid fits in int, or that its print
5565 length is less than 20.
5567 * data.c (Fsubr_name): Rewrite to avoid a strlen call.
5569 * coding.c (make_subsidiaries): Don't assume string length fits in int.
5571 * callproc.c (child_setup): Rewrite to avoid two strlen calls.
5573 * process.c (Fformat_network_address): Use EMACS_INT, not EMACS_UINT.
5574 We prefer signed integers, even for size calculations.
5576 * emacs.c: Don't assume string length fits in 'int'.
5577 (DEFINE_DUMMY_FUNCTION, sort_args): Use ptrdiff_t, not int.
5578 (main): Don't invoke strlen when not needed.
5580 * dbusbind.c (XD_ERROR): Don't arbitrarily truncate string.
5581 (XD_DEBUG_MESSAGE): Don't waste a byte.
5583 * callproc.c (getenv_internal_1, getenv_internal)
5585 * buffer.c (init_buffer): Don't assume string length fits in 'int'.
5587 * lread.c (invalid_syntax): Omit length argument.
5588 All uses changed. This doesn't fix a bug, but it simplifies the
5589 code away from its former Hollerith-constant appearance, and it's
5590 one less 'int' to worry about when looking at integer-overflow issues.
5591 (string_to_number): Simplify 2011-04-26 change by invoking xsignal1.
5593 * lisp.h (DEFUN): Remove bogus use of sizeof (struct Lisp_Subr).
5594 This didn't break anything, but it didn't help either.
5595 It's confusing to put a bogus integer in a place where the actual
5596 value does not matter.
5597 (LIST_END_P): Remove unused macro and its bogus comment.
5598 (make_fixnum_or_float): Remove unnecessary cast to EMACS_INT.
5600 * lisp.h (union Lisp_Object.i): EMACS_INT, not EMACS_UINT.
5601 This is for consistency with the ordinary, non-USE_LISP_UNION_TYPE,
5603 (struct Lisp_Bool_Vector.size): EMACS_INT, not EMACS_UINT.
5604 We prefer signed types, and the value cannot exceed the EMACS_INT
5605 range anyway (because otherwise the length would not be representable).
5606 (XSET) [USE_LISP_UNION_TYPE]: Use uintptr_t and intptr_t,
5607 not EMACS_UINT and EMACS_INT, when converting pointer to integer.
5608 This avoids a GCC warning when WIDE_EMACS_INT.
5610 * indent.c (sane_tab_width): New function.
5611 (current_column, scan_for_column, Findent_to, position_indentation)
5612 (compute_motion): Use it. This is just for clarity.
5613 (Fcompute_motion): Don't assume hscroll and tab offset fit in int.
5615 * image.c (xbm_image_p): Don't assume stated width, height fit in int.
5617 * lisp.h (lint_assume): New macro.
5618 * composite.c (composition_gstring_put_cache):
5619 * ftfont.c (ftfont_shape_by_flt): Use it to pacify GCC 4.6.0.
5621 * editfns.c, insdel.c:
5622 Omit unnecessary forward decls, to simplify future changes.
5624 * ftfont.c (ftfont_shape_by_flt): Use signed integers for lengths.
5626 * font.c (Ffont_shape_gstring): Don't assume glyph len fits in 'int'.
5628 * fns.c (Ffillarray): Don't assume bool vector size fits in 'int'.
5629 Use much-faster test for byte-length change.
5630 Don't assume string byte-length fits in 'int'.
5631 Check that character arg fits in 'int'.
5632 (mapcar1): Declare byte as byte, for clarity.
5634 * alloc.c (Fmake_bool_vector): Avoid unnecessary multiplication.
5636 * fns.c (concat): Catch string overflow earlier.
5637 Do not rely on integer wraparound.
5639 * dispextern.h (struct it.overlay_strings_charpos)
5640 (struct it.selective): Now EMACS_INT, not int.
5641 * xdisp.c (forward_to_next_line_start)
5642 (back_to_previous_visible_line_start)
5643 (reseat_at_next_visible_line_start, next_element_from_buffer):
5644 Don't arbitrarily truncate the value of 'selective' to int.
5646 * xdisp.c (init_iterator): Use XINT, not XFASTINT; it might be < 0.
5648 * composite.c: Don't truncate sizes to 'int'.
5649 (composition_gstring_p, composition_reseat_it)
5650 (composition_adjust_point): Use EMACS_INT, not int.
5651 (get_composition_id, composition_gstring_put_cache): Use EMACS_INT,
5652 not EMACS_UINT, for indexes.
5654 * category.h (CATEGORY_SET_P): Remove unnecessary cast to EMACS_INT.
5656 * buffer.c: Include <verify.h>.
5657 (struct sortvec.priority, struct sortstr.priority):
5658 Now EMACS_INT, not int.
5659 (compare_overlays, cmp_for_strings): Avoid subtraction overflow.
5660 (struct sortstr.size, record_overlay_string)
5661 (struct sortstrlist.size, struct sortlist.used):
5662 Don't truncate size to int.
5663 (record_overlay_string): Check for size-calculation overflow.
5664 (init_buffer_once): Check at compile-time, not run-time.
5666 2011-06-22 Jim Meyering <meyering@redhat.com>
5668 Don't leak an XBM-image-sized buffer
5669 * image.c (xbm_load): Free the image buffer after using it.
5671 2011-06-21 Paul Eggert <eggert@cs.ucla.edu>
5674 * composite.c (find_automatic_composition): Omit needless 'return 0;'
5675 that Sun C diagnosed.
5676 * fns.c (secure_hash): Fix pointer signedness issue.
5677 * intervals.c (static_offset_intervals): New function.
5678 (offset_intervals): Use it.
5680 2011-06-21 Leo Liu <sdl.web@gmail.com>
5683 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha256.h and
5686 * fns.c (secure_hash): Rename from crypto_hash_function and change
5687 the first arg to accept symbols.
5688 (Fsecure_hash): New primitive.
5689 (syms_of_fns): New symbols.
5691 2011-06-20 Deniz Dogan <deniz@dogan.se>
5693 * process.c (Fset_process_buffer): Clarify return value in
5696 2011-06-18 Chong Yidong <cyd@stupidchicken.com>
5698 * dispnew.c (add_window_display_history): Use BVAR.
5700 * xdisp.c (debug_method_add): Use BVAR.
5701 (check_window_end, dump_glyph_matrix, dump_glyph)
5702 (dump_glyph_row, dump_glyph_string): Convert arglist to ANSI C.
5704 * xfaces.c (check_lface_attrs, check_lface, dump_realized_face):
5707 * xfns.c (Fx_create_frame, x_create_tip_frame): Delay image cache
5708 check till after the cache is created in init_frame_faces.
5710 2011-06-17 Stefan Monnier <monnier@iro.umontreal.ca>
5712 * fns.c (Fsafe_length): Yet another int/Lisp_Object mixup.
5714 2011-06-16 Paul Eggert <eggert@cs.ucla.edu>
5716 * lisp.h: Include <limits.h>, for INT_MAX, LONG_MAX, LLONG_MAX.
5717 Without this, prin1 mishandles Lisp_Misc_Save_Value printing on
5718 hosts with pre-C99 libraries, because pD is wrongly defined to "t".
5720 Improve buffer-overflow checking (Bug#8873).
5721 * fileio.c (Finsert_file_contents):
5722 * insdel.c (insert_from_buffer_1, replace_range, replace_range_2):
5723 Remove the old (too-loose) buffer overflow checks.
5724 They weren't needed, since make_gap checks for buffer overflow.
5725 * insdel.c (make_gap_larger): Catch buffer overflows that were missed.
5726 The old code merely checked for Emacs fixnum overflow, and relied
5727 on undefined (wraparound) behavior. The new code avoids undefined
5728 behavior, and also checks for ptrdiff_t and/or size_t overflow.
5730 * editfns.c (Finsert_char): Don't dump core with very negative counts.
5731 Tune. Don't use wider integers than needed. Don't use alloca.
5732 Use a bigger 'string' buffer. Rewrite to avoid 'n > 0' test.
5734 * insdel.c (replace_range): Fix buf overflow when insbytes < outgoing.
5736 * insdel.c, lisp.h (buffer_overflow): New function.
5737 (insert_from_buffer_1, replace_range, replace_range_2):
5738 * insdel.c (make_gap_larger):
5739 * editfns.c (Finsert_char):
5740 * fileio.c (Finsert_file_contents): Use it, to normalize wording.
5742 * buffer.h (BUF_BYTES_MAX): Cast to ptrdiff_t so that it's signed.
5744 2011-06-15 Paul Eggert <eggert@cs.ucla.edu>
5746 Integer overflow and signedness fixes (Bug#8873, Bug#8828).
5748 * ccl.c (ASCENDING_ORDER): New macro, to work around GCC bug 43772.
5749 (GET_CCL_RANGE, IN_INT_RANGE): Use it.
5751 * fileio.c: Don't assume EMACS_INT fits in off_t.
5752 (emacs_lseek): New static function.
5753 (Finsert_file_contents, Fwrite_region): Use it.
5754 Use SEEK_SET, SEEK_CUR, SEEK_END as appropriate.
5756 * fns.c (Fload_average): Don't assume 100 * load average fits in int.
5758 * fns.c: Don't overflow int when computing a list length.
5759 * fns.c (QUIT_COUNT_HEURISTIC): New constant.
5760 (Flength, Fsafe_length): Use EMACS_INT, not int, to avoid unwanted
5761 truncation on 64-bit hosts. Check for QUIT every
5762 QUIT_COUNT_HEURISTIC entries rather than every other entry; that's
5763 faster and is responsive enough.
5764 (Flength): Report an error instead of overflowing an integer.
5765 (Fsafe_length): Return a float if the value is not representable
5766 as a fixnum. This shouldn't happen except in contrived situations.
5767 (Fnthcdr, Fsort): Don't assume list length fits in int.
5768 (Fcopy_sequence): Don't assume vector length fits in int.
5770 * alloc.c: Check that resized vectors' lengths fit in fixnums.
5771 (header_size, word_size): New constants.
5772 (allocate_vectorlike): Don't check size overflow here.
5773 (allocate_vector): Check it here instead, since this is the only
5774 caller of allocate_vectorlike that could cause overflow.
5775 Check that the new vector's length is representable as a fixnum.
5777 * fns.c (next_almost_prime): Don't return a multiple of 3 or 5.
5778 The previous code was bogus. For example, next_almost_prime (32)
5779 returned 39, which is undesirable as it is a multiple of 3; and
5780 next_almost_prime (24) returned 25, which is a multiple of 5 so
5781 why was the code bothering to check for multiples of 7?
5783 * bytecode.c (exec_byte_code): Use ptrdiff_t, not int, for vector length.
5785 * eval.c, doprnt.c (SIZE_MAX): Remove; inttypes.h defines this now.
5787 Variadic C functions now count arguments with ptrdiff_t.
5788 This partly undoes my 2011-03-30 change, which replaced int with size_t.
5789 Back then I didn't know that the Emacs coding style prefers signed int.
5790 Also, in the meantime I found a few more instances where arguments
5791 were being counted with int, which may truncate counts on 64-bit
5792 machines, or EMACS_INT, which may be unnecessarily wide.
5793 * lisp.h (struct Lisp_Subr.function.aMANY)
5794 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call):
5795 Arg counts are now ptrdiff_t, not size_t.
5796 All variadic functions and their callers changed accordingly.
5797 (struct gcpro.nvars): Now size_t, not size_t. All uses changed.
5798 * bytecode.c (exec_byte_code): Check maxdepth for overflow,
5799 to avoid potential buffer overrun. Don't assume arg counts fit in 'int'.
5800 * callint.c (Fcall_interactively): Check arg count for overflow,
5801 to avoid potential buffer overrun. Use signed char, not 'int',
5802 for 'varies' array, so that we needn't bother to check its size
5803 calculation for overflow.
5804 * editfns.c (Fformat): Use ptrdiff_t, not EMACS_INT, to count args.
5805 * eval.c (apply_lambda):
5806 * fns.c (Fmapconcat): Use XFASTINT, not XINT, to get args length.
5807 (struct textprop_rec.argnum): Now ptrdiff_t, not int. All uses changed.
5808 (mapconcat): Use ptrdiff_t, not int and EMACS_INT, to count args.
5810 * callint.c (Fcall_interactively): Don't use index var as event count.
5812 * vm-limit.c (check_memory_limits): Fix incorrect extern function decls.
5813 * mem-limits.h (SIZE): Remove; no longer used.
5815 * xterm.c (x_alloc_nearest_color_1): Prefer int to long when int works.
5817 Remove unnecessary casts.
5818 * xterm.c (x_term_init):
5819 * xfns.c (x_set_border_pixel):
5820 * widget.c (create_frame_gcs): Remove casts to unsigned long etc.
5821 These aren't needed now that we assume ANSI C.
5823 * sound.c (Fplay_sound_internal): Remove cast to unsigned long.
5824 It's more likely to cause problems (due to unsigned overflow)
5827 * dired.c (Ffile_attributes): Don't use 32-bit hack on 64-bit hosts.
5829 * unexelf.c (unexec): Don't assume BSS addr fits in unsigned.
5831 * xterm.c (handle_one_xevent): Omit unnecessary casts to unsigned.
5833 * keyboard.c (modify_event_symbol): Don't limit alist len to UINT_MAX.
5835 * lisp.h (CHAR_TABLE_SET): Omit now-redundant test.
5837 * lread.c (Fload): Don't compare a possibly-garbage time_t value.
5839 GLYPH_CODE_FACE returns EMACS_INT, not int.
5840 * dispextern.h (merge_faces):
5841 * xfaces.c (merge_faces):
5842 * xdisp.c (get_next_display_element, next_element_from_display_vector):
5843 Don't assume EMACS_INT fits in int.
5845 * character.h (CHAR_VALID_P): Remove unused parameter.
5846 * fontset.c, lisp.h, xdisp.c: All uses changed.
5848 * editfns.c (Ftranslate_region_internal): Omit redundant test.
5850 * fns.c (concat): Minor tuning based on overflow analysis.
5851 This doesn't fix any bugs. Use int to hold character, instead
5852 of constantly refetching from Emacs object. Use XFASTINT, not
5853 XINT, for value known to be a character. Don't bother comparing
5854 a single byte to 0400, as it's always less.
5856 * floatfns.c (Fexpt):
5857 * fileio.c (make_temp_name): Omit unnecessary cast to unsigned.
5859 * editfns.c (Ftranslate_region_internal): Use int, not EMACS_INT
5862 * doc.c (get_doc_string): Omit (unsigned)c that mishandled negatives.
5864 * data.c (Faset): If ARRAY is a string, check that NEWELT is a char.
5865 Without this fix, on a 64-bit host (aset S 0 4294967386) would
5866 incorrectly succeed when S was a string, because 4294967386 was
5867 truncated before it was used.
5869 * chartab.c (Fchar_table_range): Use CHARACTERP to check range.
5870 Otherwise, an out-of-range integer could cause undefined behavior
5873 * composite.c: Use int, not EMACS_INT, for characters.
5874 (fill_gstring_body, composition_compute_stop_pos): Use int, not
5875 EMACS_INT, for values that are known to be in character range.
5876 This doesn't fix any bugs but is the usual style inside Emacs and
5877 may generate better code on 32-bit machines.
5879 Make sure a 64-bit char is never passed to ENCODE_CHAR.
5880 This is for reasons similar to the recent CHAR_STRING fix.
5881 * charset.c (Fencode_char): Check that character arg is actually
5882 a character. Pass an int to ENCODE_CHAR.
5883 * charset.h (ENCODE_CHAR): Verify that the character argument is no
5884 wider than 'int', as a compile-time check to prevent future regressions
5887 * character.c (char_string): Remove unnecessary casts.
5889 Make sure a 64-bit char is never passed to CHAR_STRING.
5890 Otherwise, CHAR_STRING would do the wrong thing on a 64-bit platform,
5891 by silently ignoring the top 32 bits, allowing some values
5892 that were far too large to be valid characters.
5893 * character.h: Include <verify.h>.
5894 (CHAR_STRING, CHAR_STRING_ADVANCE): Verify that the character
5895 arguments are no wider than unsigned, as a compile-time check
5896 to prevent future regressions in this area.
5898 * editfns.c (Fchar_to_string, general_insert_function, Finsert_char)
5899 (Fsubst_char_in_region):
5901 * xdisp.c (decode_mode_spec_coding):
5902 Adjust to CHAR_STRING's new requirement.
5903 * editfns.c (Finsert_char, Fsubst_char_in_region):
5904 * fns.c (concat): Check that character args are actually
5905 characters. Without this test, these functions did the wrong
5906 thing with wildly out-of-range values on 64-bit hosts.
5908 Remove incorrect casts to 'unsigned' that lose info on 64-bit hosts.
5909 These casts should not be needed on 32-bit hosts, either.
5910 * keyboard.c (read_char):
5911 * lread.c (Fload): Remove casts to unsigned.
5913 * lisp.h (UNSIGNED_CMP): New macro.
5914 This fixes comparison bugs on 64-bit hosts.
5915 (ASCII_CHAR_P): Use it.
5916 * casefiddle.c (casify_object):
5917 * character.h (ASCII_BYTE_P, CHAR_VALID_P)
5918 (SINGLE_BYTE_CHAR_P, CHAR_STRING):
5919 * composite.h (COMPOSITION_ENCODE_RULE_VALID):
5920 * dispextern.h (FACE_FROM_ID):
5921 * keyboard.c (read_char): Use UNSIGNED_CMP.
5923 * xmenu.c (dialog_selection_callback) [!USE_GTK]: Cast to intptr_t,
5924 not to EMACS_INT, to avoid GCC warning.
5926 * xfns.c (x_set_scroll_bar_default_width): Remove unused 'int' locals.
5928 * buffer.h (PTR_BYTE_POS, BUF_PTR_BYTE_POS): Remove harmful cast.
5929 The cast incorrectly truncated 64-bit byte offsets to 32 bits, and
5930 isn't needed on 32-bit machines.
5932 * buffer.c (Fgenerate_new_buffer_name):
5933 Use EMACS_INT for count, not int.
5934 (advance_to_char_boundary): Return EMACS_INT, not int.
5936 * data.c (Qcompiled_function): Now static.
5938 * window.c (window_body_lines): Now static.
5940 * image.c (gif_load): Rename local to avoid shadowing.
5942 * lisp.h (SAFE_ALLOCA_LISP): Check for integer overflow.
5943 (struct Lisp_Save_Value): Use ptrdiff_t, not int, for 'integer' member.
5944 * alloc.c (make_save_value): Integer argument is now of type
5946 (mark_object): Use ptrdiff_t, not int.
5947 * lisp.h (pD): New macro.
5948 * print.c (print_object): Use it.
5950 * alloc.c: Use EMACS_INT, not int, to count objects.
5951 (total_conses, total_markers, total_symbols, total_vector_size)
5952 (total_free_conses, total_free_markers, total_free_symbols)
5953 (total_free_floats, total_floats, total_free_intervals)
5954 (total_intervals, total_strings, total_free_strings):
5955 Now EMACS_INT, not int. All uses changed.
5956 (Fgarbage_collect): Compute overall total using a double, so that
5957 integer overflow is less likely to be a problem. Check for overflow
5958 when converting back to an integer.
5959 (n_interval_blocks, n_string_blocks, n_float_blocks, n_cons_blocks)
5960 (n_vectors, n_symbol_blocks, n_marker_blocks): Remove.
5961 These were 'int' variables that could overflow on 64-bit hosts;
5962 they were never used, so remove them instead of repairing them.
5963 (nzombies, ngcs, max_live, max_zombies): Now EMACS_INT, not 'int'.
5964 (inhibit_garbage_collection): Set gc_cons_threshold to max value.
5965 Previously, this ceilinged at INT_MAX, but that doesn't work on
5967 (allocate_pseudovector): Don't use EMACS_INT when int would do.
5969 * alloc.c (Fmake_bool_vector): Don't assume vector size fits in int.
5970 (allocate_vectorlike): Check for ptrdiff_t overflow.
5971 (mark_vectorlike, mark_char_table, mark_object): Avoid EMACS_UINT
5972 when a (possibly-narrower) signed value would do just as well.
5973 We prefer using signed arithmetic, to avoid comparison confusion.
5975 * alloc.c: Catch some string size overflows that we were missing.
5976 (XMALLOC_OVERRUN_CHECK_SIZE) [!XMALLOC_OVERRUN_CHECK]: Define to 0,
5977 for convenience in STRING_BYTES_MAX.
5978 (STRING_BYTES_MAX): New macro, superseding the old one in lisp.h.
5979 The definition here is exact; the one in lisp.h was approximate.
5980 (allocate_string_data): Check for string overflow. This catches
5981 some instances we weren't catching before. Also, it catches
5982 size_t overflow on (unusual) hosts where SIZE_MAX <= min
5983 (PTRDIFF_MAX, MOST_POSITIVE_FIXNUM), e.g., when size_t is 32 bits
5984 and ptrdiff_t and EMACS_INT are both 64 bits.
5986 * character.c, coding.c, doprnt.c, editfns.c, eval.c:
5987 All uses of STRING_BYTES_MAX replaced by STRING_BYTES_BOUND.
5988 * lisp.h (STRING_BYTES_BOUND): Rename from STRING_BYTES_MAX.
5990 * character.c (string_escape_byte8): Fix nbytes/nchars typo.
5992 * alloc.c (Fmake_string): Check for out-of-range init.
5994 2011-06-15 Stefan Monnier <monnier@iro.umontreal.ca>
5996 * eval.c (Fdefvaralias): Also mark the target as variable-special-p.
5998 2011-06-14 Jan Djärv <jan.h.d@swipnet.se>
6000 * xfns.c (x_set_scroll_bar_default_width): Remove argument to
6001 xg_get_default_scrollbar_width.
6003 * gtkutil.c: Include emacsgtkfixed.h if HAVE_GTK3.
6004 (int_gtk_range_get_value): Move to the scroll bar part of the file.
6005 (style_changed_cb): Call update_theme_scrollbar_width and call
6006 x_set_scroll_bar_default_width and xg_frame_set_char_size for
6007 all frames (Bug#8505).
6008 (xg_create_frame_widgets): Call emacs_fixed_new if HAVE_GTK3 (Bug#8505).
6009 Call gtk_window_set_resizable if HAVE_GTK3.
6010 (x_wm_set_size_hint): Call emacs_fixed_set_min_size with min width
6011 and height if HAVE_GTK3 (Bug#8505).
6012 (scroll_bar_width_for_theme): New variable.
6013 (update_theme_scrollbar_width): New function.
6014 (xg_get_default_scrollbar_width): Move code to
6015 update_theme_scrollbar_width, just return scroll_bar_width_for_theme.
6016 (xg_initialize): Call update_theme_scrollbar_width.
6018 * gtkutil.h (xg_get_default_scrollbar_width): Remove argument.
6020 * emacsgtkfixed.c, emacsgtkfixed.h: New files.
6022 2011-06-12 Martin Rudalics <rudalics@gmx.at>
6024 * frame.c (make_frame): Call other_buffer_safely instead of
6027 * window.c (temp_output_buffer_show): Call display_buffer with
6028 second argument Vtemp_buffer_show_specifiers and reset latter
6029 immediately after the call.
6030 (Vtemp_buffer_show_specifiers): New variable.
6031 (auto_window_vscroll_p, next_screen_context_lines)
6032 (Vscroll_preserve_screen_position): Remove leading asterisks from
6035 2011-06-12 Paul Eggert <eggert@cs.ucla.edu>
6037 Fix minor problems found by GCC 4.6.0 static checking.
6038 * buffer.c (Qclone_number): Remove for now, as it's unused.
6039 (record_buffer, Funrecord_buffer): Rename local to avoid shadowing.
6040 (record_buffer): Remove unused local.
6041 * frame.c (other_visible_frames, frame_buffer_list): Now static.
6042 (set_frame_buffer_list): Remove; unused.
6043 * frame.h (other_visible_frames): Remove decl.
6044 * keyboard.h (menu_items_inuse): Declare only if USE_GTK || USE_MOTIF.
6045 * lisp.h (frame_buffer_list, set_frame_buffer_list): Remove decls.
6046 (add_gpm_wait_descriptor, delete_gpm_wait_descriptor): Declare only
6048 * menu.c (menu_items_inuse): Now static unless USE_GTK || USE_MOTIF.
6049 * process.c (add_gpm_wait_descriptor, delete_gpm_wait_descriptor):
6050 Define only if HAVE_GPM.
6051 * widget.c (EmacsFrameResize, emacsFrameClassRec): Now static.
6052 (update_hints_inhibit): Remove; never set. All uses removed.
6053 * widgetprv.h (emacsFrameClassRec): Remove decl.
6054 * window.c (delete_deletable_window): Now returns void, since it
6055 wasn't returning anything.
6056 (compare_window_configurations): Remove unused locals.
6057 * xfns.c (x_set_scroll_bar_default_width): Remove unused locals.
6058 * xmenu.c (x_menu_set_in_use): Define only if USE_GTK || USE_MOTIF.
6059 (dialog_selection_callback) [!USE_GTK]: Prefer intptr_t for integers
6060 the same widths as pointers. This follows up on the 2011-05-06 patch.
6061 * xterm.c (x_alloc_lighter_color_for_widget): Define only if USE_LUCID.
6062 * xterm.h: Likewise.
6063 (x_menu_set_in_use): Declare only if USE_GTK || USE_MOTIF.
6065 2011-06-12 Juanma Barranquero <lekktu@gmail.com>
6067 * makefile.w32-in: Update dependencies.
6068 (LISP_H): Add lib/intprops.h.
6070 2011-06-11 Chong Yidong <cyd@stupidchicken.com>
6072 * image.c (gif_load): Add animation frame delay to the metadata.
6073 (syms_of_image): Use DEFSYM. New symbol `delay'.
6075 2011-06-11 Martin Rudalics <rudalics@gmx.at>
6077 * window.c (delete_deletable_window): Re-add.
6078 (Fset_window_configuration): Rewrite to handle dead buffers and
6079 consequently deletable windows.
6080 (window_tree, Fwindow_tree): Remove. Supply functionality in
6082 (compare_window_configurations): Simplify code.
6084 2011-06-11 Andreas Schwab <schwab@linux-m68k.org>
6086 * image.c (imagemagick_load_image): Fix type mismatch.
6087 (Fimagemagick_types): Likewise.
6089 * window.h (replace_buffer_in_windows): Declare.
6091 2011-06-11 Martin Rudalics <rudalics@gmx.at>
6093 * buffer.c: New Lisp objects Qbuffer_list_update_hook and
6094 Qclone_number. Remove external declaration of Qdelete_window.
6095 (Fbuffer_list): Rewrite doc-string. Minor restructuring of
6097 (Fget_buffer_create, Fmake_indirect_buffer, Frename_buffer):
6098 Run Qbuffer_list_update_hook if allowed.
6099 (Fother_buffer): Rewrite doc-string. Major rewrite for new
6100 buffer list implementation.
6101 (other_buffer_safely): New function.
6102 (Fkill_buffer): Replace call to replace_buffer_in_all_windows by
6103 calls to replace_buffer_in_windows and
6104 replace_buffer_in_windows_safely. Run Qbuffer_list_update_hook
6106 (record_buffer): Inhibit quitting and rewrite using quittable
6107 functions. Run Qbuffer_list_update_hook if allowed.
6108 (Frecord_buffer, Funrecord_buffer): New functions.
6109 (switch_to_buffer_1, Fswitch_to_buffer): Remove.
6110 Move switch-to-buffer to window.el.
6111 (bury-buffer): Move to window.el.
6112 (Vbuffer_list_update_hook): New variable.
6114 * lisp.h (other_buffer_safely): Add prototype in buffer.c
6117 * window.h (resize_frame_windows): Move up in code.
6118 (Fwindow_frame): Remove EXFUN.
6119 (replace_buffer_in_all_windows): Remove prototype.
6120 (replace_buffer_in_windows_safely): Add prototype.
6122 * window.c: Declare Qdelete_window static again. Move down
6123 declaration of select_count.
6124 (Fnext_window, Fprevious_window): Rewrite doc-strings.
6125 (Fother_window): Move to window.el.
6126 (window_loop): Remove DELETE_BUFFER_WINDOWS and UNSHOW_BUFFER
6127 cases. Add REPLACE_BUFFER_IN_WINDOWS_SAFELY case.
6128 (Fdelete_windows_on, Freplace_buffer_in_windows): Move to
6130 (replace_buffer_in_windows): Implement by calling
6131 Qreplace_buffer_in_windows.
6132 (replace_buffer_in_all_windows): Remove with some functionality
6133 moved into replace_buffer_in_windows_safely.
6134 (replace_buffer_in_windows_safely): New function.
6135 (select_window_norecord, select_frame_norecord): Move in front
6136 of run_window_configuration_change_hook. Remove now obsolete
6138 (Fset_window_buffer): Rewrite doc-string.
6139 Call Qrecord_window_buffer.
6140 (keys_of_window): Move binding for other-window to window.el.
6142 2011-06-11 Chong Yidong <cyd@stupidchicken.com>
6144 * dispextern.h (struct image): Replace data member, whose int_val
6145 and ptr_val fields were not used by anything, with a single
6148 * image.c (Fimage_metadata, make_image, mark_image, tiff_load)
6149 (gif_clear_image, gif_load, imagemagick_load_image)
6150 (gs_clear_image, gs_load): Callers changed.
6152 2011-06-10 Paul Eggert <eggert@cs.ucla.edu>
6154 * buffer.h: Include <time.h>, for time_t.
6155 Needed to build on FreeBSD 8.2. Problem reported by Herbert J. Skuhra.
6157 Fix minor problems found by static checking.
6159 * image.c (PixelGetMagickColor): Declare if ImageMagick headers don't.
6161 Make identifiers static if they are not used in other modules.
6162 * data.c (Qcompiled_function, Qframe, Qvector):
6163 * image.c (QimageMagick, Qsvg):
6164 * minibuf.c (Qmetadata):
6165 * window.c (resize_window_check, resize_root_window): Now static.
6166 * window.h (resize_window_check, resize_root_window): Remove decls.
6168 * window.c (window_deletion_count, delete_deletable_window):
6170 (window_body_lines): Now static.
6171 (Fdelete_other_windows_internal): Mark vars as initialized.
6172 Make sure 'resize_failed' is initialized.
6173 (run_window_configuration_change_hook): Rename local to avoid shadowing.
6174 (resize_window_apply): Remove unused local.
6175 * window.h (delete_deletable_window): Remove decl.
6177 * image.c (gif_load, svg_load_image): Rename locals to avoid shadowing.
6178 (imagemagick_load_image): Fix pointer signedness problem by changing
6179 last arg from unsigned char * to char *. All uses changed.
6180 Also, fix a local for similar reasons.
6181 Remove unused locals. Remove locals to avoid shadowing.
6182 (fn_rsvg_handle_free): Remove; unused.
6183 (svg_load, svg_load_image): Fix pointer signedness problem.
6184 (imagemagick_load_image): Don't use garbage pointer image_wand.
6186 * ftfont.c (ftfont_get_metrics, ftfont_drive_otf): Remove unused locals.
6188 2011-06-10 Chong Yidong <cyd@stupidchicken.com>
6190 * image.c (gif_load): Fix omitted cast error introduced by
6193 2011-06-10 Martin Rudalics <rudalics@gmx.at>
6195 * window.h (resize_proportionally, orig_total_lines)
6196 (orig_top_line): Remove from window structure.
6197 (set_window_height, set_window_width, change_window_heights)
6198 (Fdelete_window): Remove prototypes.
6199 (resize_frame_windows): Remove duplicate declaration.
6201 2011-06-10 Eli Zaretskii <eliz@gnu.org>
6203 * window.h (resize_frame_windows, resize_window_check)
6204 (delete_deletable_window, resize_root_window)
6205 (resize_frame_windows): Declare prototypes.
6207 * window.c (resize_window_apply): Make definition be "static" to
6208 match the prototype.
6210 2011-06-10 Martin Rudalics <rudalics@gmx.at>
6212 * window.c: Remove declarations of Qwindow_size_fixed,
6213 window_min_size_1, window_min_size_2, window_min_size,
6214 size_window, window_fixed_size_p, enlarge_window, delete_window.
6215 Remove static from declaration of Qdelete_window, it's
6216 temporarily needed by Fbury_buffer.
6217 (replace_window): Don't assign orig_top_line and
6219 (Fdelete_window, delete_window): Remove. Window deletion is
6220 handled by window.el.
6221 (window_loop): Remove DELETE_OTHER_WINDOWS case.
6222 Replace Fdelete_window calls with calls to Qdelete_window.
6223 (Fdelete_other_windows): Remove. Deleting other windows is
6224 handled by window.el.
6225 (window_fixed_size_p): Remove. Fixed-sizeness of windows is
6226 handled in window.el.
6227 (window_min_size_2, window_min_size_1, window_min_size): Remove.
6228 Window minimum sizes are handled in window.el.
6229 (shrink_windows, size_window, set_window_height)
6230 (set_window_width, change_window_heights, window_height)
6231 (window_width, CURBEG, CURSIZE, enlarge_window)
6232 (adjust_window_trailing_edge, Fadjust_window_trailing_edge)
6233 (Fenlarge_window, Fshrink_window): Remove. Window resizing is
6234 handled in window.el.
6235 (make_dummy_parent): Rename to make_parent_window and give it a
6236 second argument horflag.
6237 (make_window): Don't set resize_proportionally any more.
6238 (Fsplit_window): Remove. Windows are split in window.el.
6239 (save_restore_action, save_restore_orig_size)
6240 (shrink_window_lowest_first, save_restore_orig_size): Remove.
6241 Resize mini windows in window.el.
6242 (grow_mini_window, shrink_mini_window): Implement by calling
6243 Qresize_root_window_vertically, resize_window_check and
6244 resize_window_apply.
6245 (saved_window, Fset_window_configuration, save_window_save):
6246 Do not handle orig_top_line, orig_total_lines, and
6247 resize_proportionally.
6248 (window_min_height, window_min_width): Move to window.el.
6249 (keys_of_window): Move bindings for delete-other-windows,
6250 split-window, delete-window and enlarge-window to window.el.
6252 * buffer.c: Temporarily extern Qdelete_window.
6253 (Fbury_buffer): Temporarily call Qdelete_window instead of
6254 Fdelete_window (Fbury_buffer will move to window.el soon).
6256 * frame.c (set_menu_bar_lines_1): Remove code handling
6257 orig_top_line and orig_total_lines.
6259 * dispnew.c (adjust_frame_glyphs_initially): Don't use
6260 set_window_height but set heights directly.
6261 (change_frame_size_1): Use resize_frame_windows.
6263 * xdisp.c (init_xdisp): Don't use set_window_height but set
6266 * xfns.c (x_set_menu_bar_lines, x_set_tool_bar_lines):
6267 Use resize_frame_windows instead of change_window_heights and run
6268 run_window_configuration_change_hook.
6270 * w32fns.c (x_set_tool_bar_lines): Use resize_frame_windows
6271 instead of change_window_heights and run
6272 run_window_configuration_change_hook.
6274 2011-06-09 Martin Rudalics <rudalics@gmx.at>
6276 * window.c (replace_window): Rename second argument REPLACEMENT to
6277 NEW. New third argument SETFLAG. Rewrite.
6278 (delete_window, make_dummy_parent): Call replace_window with
6280 (window_list_1): Move down in code.
6281 (run_window_configuration_change_hook): Move set_buffer part
6282 before select_frame_norecord part in order to unwind correctly.
6283 Rename count1 to count.
6284 (recombine_windows, delete_deletable_window, resize_root_window)
6285 (Fdelete_other_windows_internal)
6286 (Frun_window_configuration_change_hook, make_parent_window)
6287 (resize_window_check, resize_window_apply, Fresize_window_apply)
6288 (resize_frame_windows, Fsplit_window_internal)
6289 (Fdelete_window_internal, Fresize_mini_window_internal):
6291 (syms_of_window): New variables Vwindow_splits and Vwindow_nest.
6293 2011-06-08 Martin Rudalics <rudalics@gmx.at>
6295 * window.h (window): Add some new members to window structure -
6296 normal_lines, normal_cols, new_total, new_normal, clone_number,
6297 splits, nest, prev_buffers, next_buffers.
6298 (WINDOW_TOTAL_SIZE): Move here from window.c.
6299 (MIN_SAFE_WINDOW_WIDTH, MIN_SAFE_WINDOW_HEIGHT): Define here.
6301 * window.c (Fwindow_height, Fwindow_width, Fwindow_full_width_p):
6303 (make_dummy_parent): Set new members of windows structure.
6304 (make_window): Move down in code. Handle new members of window
6306 (Fwindow_clone_number, Fwindow_splits, Fset_window_splits)
6307 (Fwindow_nest, Fset_window_nest, Fwindow_new_total)
6308 (Fwindow_normal_size, Fwindow_new_normal, Fwindow_prev_buffers)
6309 (Fset_window_prev_buffers, Fwindow_next_buffers)
6310 (Fset_window_next_buffers, Fset_window_clone_number):
6312 (Fwindow_hscroll, Fwindow_at, Fwindow_point, Fwindow_start)
6313 (Fwindow_end, Fwindow_line_height, Fset_window_dedicated_p):
6315 (Fwindow_parameters, Fwindow_parameter, Fset_window_parameter):
6316 Argument WINDOW can be now internal window too.
6317 (Fwindow_use_time): Move up in code.
6318 (Fget_buffer_window): Rename argument FRAME to ALL-FRAMES.
6320 (Fset_window_configuration, saved_window)
6321 (Fcurrent_window_configuration, save_window_save): Handle new
6322 members of window structure.
6323 (WINDOW_TOTAL_SIZE, MIN_SAFE_WINDOW_WIDTH)
6324 (MIN_SAFE_WINDOW_HEIGHT): Move to window.h.
6325 (syms_of_window): New Lisp objects Qrecord_window_buffer,
6326 Qwindow_deletable_p, Qdelete_window, Qreplace_buffer_in_windows,
6327 Qget_mru_window, Qresize_root_window,
6328 Qresize_root_window_vertically, Qsafe, Qabove, Qbelow,
6329 Qauto_buffer_name; staticpro them.
6331 2011-06-07 Martin Rudalics <rudalics@gmx.at>
6333 * window.c (Fwindow_total_size, Fwindow_left_column)
6334 (Fwindow_top_line, window_body_lines, Fwindow_body_size)
6335 (Fwindow_list_1): New functions.
6336 (window_box_text_cols): Replace with window_body_cols.
6337 (Fwindow_width, Fscroll_left, Fscroll_right):
6338 Use window_body_cols instead of window_box_text_cols.
6339 (delete_window, Fset_window_configuration):
6340 Call delete_all_subwindows with window as argument.
6341 (delete_all_subwindows): Take a window as argument and not a
6343 (window_loop): Remove handling of GET_LRU_WINDOW and
6345 (Fget_lru_window, Fget_largest_window): Move to window.el.
6347 * window.h: Extern window_body_cols instead of
6348 window_box_text_cols. delete_all_subwindows now takes a
6349 Lisp_Object as argument.
6351 * indent.c (compute_motion, Fcompute_motion):
6352 Use window_body_cols instead of window_box_text_cols.
6354 * frame.c (delete_frame): Call delete_all_subwindows with root
6357 2011-06-07 Daniel Colascione <dan.colascione@gmail.com>
6359 * fns.c (Fputhash): Document return value.
6361 2011-06-06 Chong Yidong <cyd@stupidchicken.com>
6363 * image.c (gif_load): Implement gif89a spec "no disposal" method.
6365 2011-06-06 Paul Eggert <eggert@cs.ucla.edu>
6367 Cons<->int and similar integer overflow fixes (Bug#8794).
6369 Check for overflow when converting integer to cons and back.
6370 * charset.c (Fdefine_charset_internal, Fdecode_char):
6371 Use cons_to_unsigned to catch overflow.
6372 (Fencode_char): Use INTEGER_TO_CONS.
6373 * composite.h (LGLYPH_CODE): Use cons_to_unsigned.
6374 (LGLYPH_SET_CODE): Use INTEGER_TO_CONS.
6375 * data.c (long_to_cons, cons_to_long): Remove.
6376 (cons_to_unsigned, cons_to_signed): New functions.
6377 These signal an error for invalid or out-of-range values.
6378 * dired.c (Ffile_attributes): Use INTEGER_TO_CONS.
6379 * fileio.c (Fset_visited_file_modtime): Use CONS_TO_INTEGER.
6380 * font.c (Ffont_variation_glyphs):
6381 * fontset.c (Finternal_char_font): Use INTEGER_TO_CONS.
6382 * lisp.h: Include <intprops.h>.
6383 (INTEGER_TO_CONS, CONS_TO_INTEGER): New macros.
6384 (cons_to_signed, cons_to_unsigned): New decls.
6385 (long_to_cons, cons_to_long): Remove decls.
6386 * undo.c (record_first_change): Use INTEGER_TO_CONS.
6387 (Fprimitive_undo): Use CONS_TO_INTEGER.
6388 * xfns.c (Fx_window_property): Likewise.
6389 * xselect.c: Include <limits.h>.
6390 (x_own_selection, selection_data_to_lisp_data):
6391 Use INTEGER_TO_CONS.
6392 (x_handle_selection_request, x_handle_selection_clear)
6393 (x_get_foreign_selection, Fx_disown_selection_internal)
6394 (Fx_get_atom_name, x_send_client_event): Use CONS_TO_INTEGER.
6395 (lisp_data_to_selection_data): Use cons_to_unsigned.
6396 (x_fill_property_data): Use cons_to_signed.
6397 Report values out of range.
6399 Check for buffer and string overflow more precisely.
6400 * buffer.h (BUF_BYTES_MAX): New macro.
6401 * lisp.h (STRING_BYTES_MAX): New macro.
6402 * alloc.c (Fmake_string):
6403 * character.c (string_escape_byte8):
6404 * coding.c (coding_alloc_by_realloc):
6405 * doprnt.c (doprnt):
6406 * editfns.c (Fformat):
6408 Use STRING_BYTES_MAX, not MOST_POSITIVE_FIXNUM,
6409 since they may not be the same number.
6410 * editfns.c (Finsert_char):
6411 * fileio.c (Finsert_file_contents):
6412 Likewise for BUF_BYTES_MAX.
6414 * image.c: Use ptrdiff_t, not int, for sizes.
6415 (slurp_file): Switch from int to ptrdiff_t.
6417 (slurp_file): Check that file size fits in both size_t (for
6418 malloc) and ptrdiff_t (for sanity and safety).
6420 * fileio.c (Fverify_visited_file_modtime): Avoid time overflow
6421 if b->modtime has its maximal value.
6423 * dired.c (Ffile_attributes): Don't assume EMACS_INT has >32 bits.
6425 Don't assume time_t can fit into int.
6426 * buffer.h (struct buffer.modtime): Now time_t, not int.
6427 * fileio.c (Fvisited_file_modtime): No need for time_t cast now.
6428 * undo.c (Fprimitive_undo): Use time_t, not int, for time_t value.
6430 Minor fixes for signed vs unsigned integers.
6431 * character.h (MAYBE_UNIFY_CHAR):
6432 * charset.c (maybe_unify_char):
6433 * keyboard.c (read_char, reorder_modifiers):
6434 XINT -> XFASTINT, since the integer must be nonnegative.
6435 * ftfont.c (ftfont_spec_pattern):
6436 * keymap.c (access_keymap, silly_event_symbol_error):
6437 XUINT -> XFASTINT, since the integer must be nonnegative.
6438 (Fsingle_key_description, preferred_sequence_p): XUINT -> XINT,
6439 since it makes no difference and we prefer signed.
6440 * keyboard.c (record_char): Use XUINT when all the neighbors do.
6441 (access_keymap): NATNUMP -> INTEGERP, since the integer must be
6444 2011-06-06 Stefan Monnier <monnier@iro.umontreal.ca>
6446 * window.h (Fwindow_frame): Declare.
6448 2011-06-06 Paul Eggert <eggert@cs.ucla.edu>
6450 * alloc.c: Simplify handling of large-request failures (Bug#8800).
6451 (SPARE_MEMORY): Always define.
6452 (LARGE_REQUEST): Remove.
6453 (memory_full): Use SPARE_MEMORY rather than LARGE_REQUEST.
6455 2011-06-06 Martin Rudalics <rudalics@gmx.at>
6457 * lisp.h: Move EXFUNS for Fframe_root_window,
6458 Fframe_first_window and Fset_frame_selected_window to window.h.
6460 * window.h: Move EXFUNS for Fframe_root_window,
6461 Fframe_first_window and Fset_frame_selected_window here from
6464 * frame.c (Fwindow_frame, Fframe_first_window)
6465 (Fframe_root_window, Fframe_selected_window)
6466 (Fset_frame_selected_window): Move to window.c.
6467 (Factive_minibuffer_window): Move to minibuf.c.
6468 (Fother_visible_frames_p): New function.
6470 * minibuf.c (Factive_minibuffer_window): Move here from frame.c.
6472 * window.c (decode_window, decode_any_window): Move up in code.
6473 (Fwindowp, Fwindow_live_p): Rewrite doc-strings.
6474 (inhibit_frame_unsplittable): Remove unused variable.
6475 (Fwindow_buffer): Move up and rewrite doc-string.
6476 (Fwindow_parent, Fwindow_vchild, Fwindow_hchild, Fwindow_next)
6477 (Fwindow_prev): New functions.
6478 (Fwindow_frame): Move here from frame.c. Accept any window as
6480 (Fframe_root_window, Fframe_first_window)
6481 (Fframe_selected_window): Move here from frame.c. Accept frame
6482 or arbitrary window as argument. Update doc-strings.
6483 (Fminibuffer_window): Move up in code.
6484 (Fwindow_minibuffer_p): Move up in code and simplify.
6485 (Fset_frame_selected_window): Move here from frame.c.
6487 (Fselected_window, select_window, Fselect_window): Move up in
6488 code. Minor doc-string fixes.
6490 2011-06-06 Paul Eggert <eggert@cs.ucla.edu>
6492 * alloc.c (memory_full) [SYSTEM_MALLOC]: Port to MacOS (Bug#8800).
6493 Do not assume that spare memory exists; that assumption is valid
6494 only if SYSTEM_MALLOC.
6495 (LARGE_REQUEST): New macro, so that the issue of large requests
6496 is separated from the issue of spare memory.
6498 2011-06-05 Andreas Schwab <schwab@linux-m68k.org>
6500 * editfns.c (Fformat): Correctly handle zero flag with hexadecimal
6503 * gtkutil.c (xg_get_default_scrollbar_width): Avoid warning.
6505 * xfns.c (x_set_scroll_bar_default_width): Move declarations
6508 2011-06-05 Jan Djärv <jan.h.d@swipnet.se>
6510 * gtkutil.c (xg_get_default_scrollbar_width): New function.
6512 * gtkutil.h: Declare xg_get_default_scrollbar_width.
6514 * xfns.c (x_set_scroll_bar_default_width): If USE_GTK, get
6515 min width by calling x_set_scroll_bar_default_width (Bug#8505).
6517 2011-06-05 Juanma Barranquero <lekktu@gmail.com>
6519 * xdisp.c (single_display_spec_intangible_p): Remove declaration.
6521 2011-06-04 Chong Yidong <cyd@stupidchicken.com>
6523 * xselect.c (x_clipboard_manager_save): Remove redundant arg.
6524 (x_clipboard_manager_save): Add return value.
6525 (x_clipboard_manager_error_1, x_clipboard_manager_error_2):
6527 (x_clipboard_manager_save_frame, x_clipboard_manager_save_all):
6528 Obey Vx_select_enable_clipboard_manager. Catch errors in
6529 x_clipboard_manager_save (Bug#8779).
6530 (Vx_select_enable_clipboard_manager): New variable.
6531 (x_get_foreign_selection): Reduce scope of x_catch_errors (Bug#8790).
6533 2011-06-04 Dan Nicolaescu <dann@ics.uci.edu>
6535 * emacs.c (main): Warn when starting a GTK emacs in daemon mode.
6537 2011-06-04 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
6539 * fringe.c (update_window_fringes): Don't update overlay arrow bitmap
6540 in the current matrix if keep_current_p is non-zero.
6542 2011-06-04 Eli Zaretskii <eliz@gnu.org>
6544 * bidi.c (bidi_level_of_next_char): Fix last change.
6546 2011-06-03 Eli Zaretskii <eliz@gnu.org>
6548 Support bidi reordering of text covered by display properties.
6550 * bidi.c (bidi_copy_it): Use offsetof instead of emulating it.
6551 (bidi_fetch_char, bidi_fetch_char_advance): New functions.
6552 (bidi_cache_search, bidi_cache_iterator_state)
6553 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak)
6554 (bidi_level_of_next_char, bidi_move_to_visually_next):
6555 Support character positions inside a run of characters covered by a
6557 (bidi_paragraph_init, bidi_resolve_explicit_1)
6558 (bidi_level_of_next_char): Call bidi_fetch_char and
6559 bidi_fetch_char_advance instead of FETCH_CHAR and
6561 (bidi_init_it): Initialize new members.
6562 (LRE_CHAR, RLE_CHAR, PDF_CHAR, LRO_CHAR, RLO_CHAR): Remove macro
6564 (bidi_explicit_dir_char): Lookup character type in bidi_type_table,
6565 instead of using explicit *_CHAR codes.
6566 (bidi_resolve_explicit, bidi_resolve_weak):
6567 Use FETCH_MULTIBYTE_CHAR instead of FETCH_CHAR, as reordering of
6568 bidirectional text is supported only in multibyte buffers.
6569 (bidi_init_it): Accept additional argument FRAME_WINDOW_P and use
6570 it to initialize the frame_window_p member of struct bidi_it.
6571 (bidi_cache_iterator_state, bidi_resolve_explicit_1)
6572 (bidi_resolve_explicit, bidi_resolve_weak)
6573 (bidi_level_of_next_char, bidi_move_to_visually_next): Abort if
6574 bidi_it->nchars is non-positive.
6575 (bidi_level_of_next_char): Don't try to lookup the cache for the
6576 next/previous character if nothing is cached there yet, or if we
6577 were just reseat()'ed to a new position.
6579 * xdisp.c (set_cursor_from_row): Set start and stop points
6580 according to the row's direction when priming the loop that looks
6581 for the glyph on which to display cursor.
6582 (single_display_spec_intangible_p): Function deleted.
6583 (display_prop_intangible_p): Reimplement to call
6584 handle_display_spec instead of single_display_spec_intangible_p.
6585 Accept 3 additional arguments needed by handle_display_spec.
6586 This fixes incorrect cursor motion across display property with complex
6587 values: lists, `(when COND...)' forms, etc.
6588 (single_display_spec_string_p): Support property values that are
6589 lists with the argument STRING its top-level element.
6590 (display_prop_string_p): Fix the condition for processing a
6591 property that is a list to be consistent with handle_display_spec.
6592 (handle_display_spec): New function, refactored from the
6593 last portion of handle_display_prop.
6594 (compute_display_string_pos): Accept additional argument
6595 FRAME_WINDOW_P. Call handle_display_spec to determine whether the
6596 value of a `display' property is a "replacing spec".
6597 (handle_single_display_spec): Accept 2 additional arguments BUFPOS
6598 and FRAME_WINDOW_P. If IT is NULL, don't set up the iterator from
6599 the display property, but just return a value indicating whether
6600 the display property will replace the characters it covers.
6601 (Fcurrent_bidi_paragraph_direction): Initialize the nchars and
6602 frame_window_p members of struct bidi_it.
6603 (compute_display_string_pos, compute_display_string_end):
6605 (push_it): Accept second argument POSITION, where pop_it should
6606 jump to continue iteration.
6607 (reseat_1): Initialize bidi_it.disp_pos.
6609 * keyboard.c (adjust_point_for_property): Adjust the call to
6610 display_prop_intangible_p to its new signature.
6612 * dispextern.h (struct bidi_it): New member frame_window_p.
6613 (bidi_init_it): Update prototypes.
6614 (display_prop_intangible_p): Update prototype.
6615 (compute_display_string_pos, compute_display_string_end):
6617 (struct bidi_it): New members nchars and disp_pos. ch_len is now
6620 2011-06-02 Paul Eggert <eggert@cs.ucla.edu>
6622 Malloc failure behavior now depends on size of allocation.
6623 * alloc.c (buffer_memory_full, memory_full): New arg NBYTES.
6624 * lisp.h: Change signatures accordingly.
6625 * alloc.c, buffer.c, editfns.c, menu.c, minibuf.c, xterm.c:
6626 All callers changed. (Bug#8762)
6628 * gnutls.c: Use Emacs's memory allocators.
6629 Without this change, the gnutls library would invoke malloc etc.
6630 directly, which causes problems on non-SYNC_INPUT hosts, and which
6631 runs afoul of improving memory_full behavior. (Bug#8761)
6632 (fn_gnutls_global_set_mem_functions): New macro or function pointer.
6633 (emacs_gnutls_global_init): Use it to specify xmalloc, xrealloc,
6634 xfree instead of the default malloc, realloc, free.
6635 (Fgnutls_boot): No need to check for memory allocation failure,
6636 since xmalloc does that for us.
6638 Remove arbitrary limit of 2**31 entries in hash tables. (Bug#8771)
6639 * category.c (hash_get_category_set):
6640 * ccl.c (ccl_driver):
6641 * charset.c (Fdefine_charset_internal):
6642 * charset.h (struct charset.hash_index):
6643 * composite.c (get_composition_id, gstring_lookup_cache)
6644 (composition_gstring_put_cache):
6645 * composite.h (struct composition.hash_index):
6646 * dispextern.h (struct image.hash):
6647 * fns.c (next_almost_prime, larger_vector, cmpfn_eql)
6648 (cmpfn_equal, cmpfn_user_defined, hashfn_eq, hashfn_eql)
6649 (hashfn_equal, hashfn_user_defined, make_hash_table)
6650 (maybe_resize_hash_table, hash_lookup, hash_put)
6651 (hash_remove_from_table, hash_clear, sweep_weak_table, SXHASH_COMBINE)
6652 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector)
6653 (Fsxhash, Fgethash, Fputhash, Fmaphash):
6654 * image.c (make_image, search_image_cache, lookup_image)
6655 (xpm_put_color_table_h):
6656 * lisp.h (struct Lisp_Hash_Table):
6657 * minibuf.c (Ftry_completion, Fall_completions, Ftest_completion):
6658 * print.c (print): Use 'EMACS_UINT' and 'EMACS_INT'
6659 for hashes and hash indexes, instead of 'unsigned' and 'int'.
6660 * alloc.c (allocate_vectorlike):
6661 Check for overflow in vector size calculations.
6662 * ccl.c (ccl_driver):
6663 Check for overflow when converting EMACS_INT to int.
6664 * fns.c, image.c: Remove unnecessary static decls that would otherwise
6665 need to be updated by these changes.
6666 * fns.c (make_hash_table, maybe_resize_hash_table):
6667 Check for integer overflow with large hash tables.
6668 (make_hash_table, maybe_resize_hash_table, Fmake_hash_table):
6669 Prefer the faster XFLOAT_DATA to XFLOATINT where either will do.
6670 (SXHASH_REDUCE): New macro.
6671 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector):
6672 Use it instead of discarding useful hash info with large hash values.
6673 (sxhash_float): New function.
6674 (sxhash): Use it. No more need for "& INTMASK" due to above changes.
6675 * lisp.h (FIXNUM_BITS): New macro, useful for SXHASH_REDUCE etc.
6676 (MOST_NEGATIVE_FIXNUM, MOST_POSITIVE_FIXNUM, INTMASK):
6677 Rewrite to use FIXNUM_BITS, as this simplifies things.
6678 (next_almost_prime, larger_vector, sxhash, hash_lookup, hash_put):
6679 Adjust signatures to match updated version of code.
6680 (consing_since_gc): Now EMACS_INT, since a single hash table can
6681 use more than INT_MAX bytes.
6683 2011-06-01 Dan Nicolaescu <dann@ics.uci.edu>
6685 Make it possible to build with GCC-4.6+ -O2 -flto.
6687 * emacs.c (__malloc_initialize_hook): Mark as EXTERNALLY_VISIBLE.
6689 2011-06-01 Stefan Monnier <monnier@iro.umontreal.ca>
6691 * minibuf.c (get_minibuffer, read_minibuf_unwind):
6692 Call minibuffer-inactive-mode.
6694 2011-05-31 Juanma Barranquero <lekktu@gmail.com>
6696 * makefile.w32-in ($(BLD)/data.$(O), $(BLD)/editfns.$(O)):
6697 Update dependencies.
6699 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
6701 * data.c (init_data): Remove code for UTS, this system is not
6704 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
6706 Don't force ./temacs to start in terminal mode.
6708 * frame.c (make_initial_frame): Initialize faces in all cases, not
6709 only when CANNOT_DUMP is defined.
6710 * dispnew.c (init_display): Remove CANNOT_DUMP condition.
6712 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
6714 * dispnew.c (add_window_display_history): Use const for the string
6715 pointer. Remove declaration, not needed.
6717 2011-05-31 Paul Eggert <eggert@cs.ucla.edu>
6719 Use 'inline', not 'INLINE'.
6720 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00914.html>
6721 * alloc.c, fontset.c (INLINE): Remove.
6722 * alloc.c, bidi.c, charset.c, coding.c, dispnew.c, fns.c, image.c:
6723 * intervals.c, keyboard.c, process.c, syntax.c, textprop.c, w32term.c:
6724 * xdisp.c, xfaces.c, xterm.c: Replace all uses of INLINE with inline.
6725 * gmalloc.c (register_heapinfo): Use inline unconditionally.
6726 * lisp.h (LISP_MAKE_RVALUE): Use inline, not __inline__.
6728 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
6730 Make it possible to run ./temacs.
6732 * callproc.c (set_initial_environment): Remove CANNOT_DUMP code,
6733 syms_of_callproc does the same thing. Remove test for
6734 "initialized", do it in the caller.
6735 * emacs.c (main): Avoid calling set_initial_environment when dumping.
6737 2011-05-31 Stefan Monnier <monnier@iro.umontreal.ca>
6739 * minibuf.c (Finternal_complete_buffer): Return `category' metadata.
6740 (read_minibuf): Use get_minibuffer.
6741 (syms_of_minibuf): Use DEFSYM.
6742 (Qmetadata): New var.
6743 * data.c (Qbuffer): Don't make it static.
6744 (syms_of_data): Use DEFSYM.
6746 2011-05-31 Paul Eggert <eggert@cs.ucla.edu>
6748 * ccl.c (CCL_CODE_RANGE): Allow negative numbers. (Bug#8751)
6749 (CCL_CODE_MIN): New macro.
6751 2011-05-30 Paul Eggert <eggert@cs.ucla.edu>
6753 * alloc.c (lisp_align_malloc): Omit unnecessary val==NULL tests.
6755 * eval.c (Qdebug): Now static.
6756 * lisp.h (Qdebug): Remove decl. This reverts a part of the
6757 2011-04-26T11:26:05Z!dan.colascione@gmail.com that inadvertently undid part of
6758 2011-04-14T06:48:41Z!eggert@cs.ucla.edu.
6760 2011-05-29 Chong Yidong <cyd@stupidchicken.com>
6762 * image.c: Various fixes to ImageMagick code comments.
6763 (Fimagemagick_types): Doc fix.
6765 2011-05-29 Paul Eggert <eggert@cs.ucla.edu>
6767 Minor fixes prompted by GCC 4.6.0 warnings.
6769 * xselect.c (converted_selections, conversion_fail_tag): Now static.
6771 * emacs.c [HAVE_X_WINDOWS]: Include "xterm.h".
6772 (x_clipboard_manager_save_all): Move extern decl to ...
6773 * xterm.h: ... here, so that it can be checked for consistency.
6775 2011-05-29 Chong Yidong <cyd@stupidchicken.com>
6777 * xselect.c (x_clipboard_manager_save_frame)
6778 (x_clipboard_manager_save_all): New functions.
6779 (Fx_clipboard_manager_save): Lisp function deleted.
6781 * emacs.c (Fkill_emacs): Call x_clipboard_manager_save_all.
6782 * frame.c (delete_frame): Call x_clipboard_manager_save_frame.
6784 * xterm.h: Update prototype.
6786 2011-05-28 William Xu <william.xwl@gmail.com>
6788 * nsterm.m (ns_term_shutdown): Synchronize user defaults before
6791 2011-05-28 Jim Meyering <meyering@redhat.com>
6793 Avoid a sign-extension bug in crypto_hash_function.
6794 * fns.c (to_uchar): Define.
6795 (crypto_hash_function): Use it to convert some newly-signed
6796 variables to unsigned, to avoid sign-extension bugs. For example,
6797 without this change, (md5 "truc") would evaluate to
6798 45723a2aff78ff4fff7fff1114760e62 rather than the expected
6799 45723a2af3788c4ff17f8d1114760e62. Reported by Antoine Levitt in
6800 https://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00883.html.
6802 2011-05-27 Paul Eggert <eggert@cs.ucla.edu>
6804 Integer overflow fixes.
6806 * dbusbind.c: Serial number integer overflow fixes.
6807 (CHECK_DBUS_SERIAL_GET_SERIAL): New macro.
6808 (Fdbus_call_method_asynchronously, xd_read_message_1): Use a float
6809 to hold a serial number that is too large for a fixnum.
6810 (Fdbus_method_return_internal, Fdbus_method_error_internal):
6811 Check for serial numbers out of range. Decode any serial number
6812 that was so large that it became a float. (Bug#8722)
6814 * dbusbind.c: Use XFASTINT rather than XUINT, and check for nonneg.
6815 (Fdbus_call_method, Fdbus_call_method_asynchronously):
6816 Use XFASTINT rather than XUINT when numbers are nonnegative.
6817 (xd_append_arg, Fdbus_method_return_internal):
6818 (Fdbus_method_error_internal): Likewise. Also, for unsigned
6819 arguments, check that Lisp number is nonnegative, rather than
6820 silently wrapping negative numbers around. (Bug#8722)
6821 (xd_read_message_1): Don't assume dbus_uint32_t can fit in int.
6824 * data.c (arith_driver, Flsh): Avoid unnecessary casts to EMACS_UINT.
6826 * ccl.c (ccl_driver): Redo slightly to avoid the need for 'unsigned'.
6828 ccl: Add integer overflow checks.
6829 * ccl.c (CCL_CODE_MAX, GET_CCL_RANGE, GET_CCL_CODE, GET_CCL_INT):
6830 (IN_INT_RANGE): New macros.
6831 (ccl_driver): Use them to check for integer overflow when
6832 decoding a CCL program. Many of the new checks are whether XINT (x)
6833 fits in int; it doesn't always, on 64-bit hosts. The new version
6834 doesn't catch all possible integer overflows, but it's an
6835 improvement. (Bug#8719)
6837 * alloc.c (make_event_array): Use XINT, not XUINT.
6838 There's no need for unsigned here.
6840 * mem-limits.h (EXCEEDS_LISP_PTR) [!USE_LSB_TAG]: EMACS_UINT -> uintptr_t
6841 This follows up to the 2011-05-06 change that substituted uintptr_t
6842 for EMACS_INT. This case wasn't caught back then.
6844 Rework Fformat to avoid integer overflow issues.
6845 * editfns.c: Include <float.h> unconditionally, as it's everywhere
6846 now (part of C89). Include <verify.h>.
6847 (MAX_10_EXP, CONVERTED_BYTE_SIZE): Remove; no longer needed.
6848 (pWIDE, pWIDElen, signed_wide, unsigned_wide): New defns.
6849 (Fformat): Avoid the prepass trying to compute sizes; it was only
6850 approximate and thus did not catch overflow reliably. Instead, walk
6851 through the format just once, formatting and computing sizes as we go,
6852 checking for integer overflow at every step, and allocating a larger
6853 buffer as needed. Keep track separately whether the format is
6854 multibyte. Keep only the most-recently calculated precision, rather
6855 than them all. Record whether each argument has been converted to
6856 string. Use EMACS_INT, not int, for byte and char and arg counts.
6857 Support field widths and precisions larger than INT_MAX. Avoid
6858 sprintf's undefined behavior with conversion specifications such as %#d
6859 and %.0c. Fix bug with strchr succeeding on '\0' when looking for
6860 flags. Fix bug with (format "%c" 256.0). Avoid integer overflow when
6861 formatting out-of-range floating point numbers with int
6864 * lisp.h (FIXNUM_OVERFLOW_P): Work even if arg is a NaN.
6866 * data.c: Avoid integer truncation in expressions involving floats.
6867 * data.c: Include <intprops.h>.
6868 (arith_driver): When there's an integer overflow in an expression
6869 involving floating point, convert the integers to floating point
6870 so that the resulting value does not suffer from catastrophic
6871 integer truncation. For example, on a 64-bit host (* 4
6872 most-negative-fixnum 0.5) should yield about -4.6e+18, not zero.
6873 Do not rely on undefined behavior after integer overflow.
6875 merge count_size_as_multibyte, parse_str_to_multibyte
6876 * character.c, character.h (count_size_as_multibyte):
6877 Rename from parse_str_to_multibyte; all uses changed.
6878 Check for integer overflow.
6879 * insdel.c, lisp.h (count_size_as_multibyte): Remove,
6880 since it's now a duplicate of the other. This is more of
6881 a character than a buffer op, so better that it's in character.c.
6882 * fns.c, print.c: Adjust to above changes.
6884 2011-05-27 Stefan Monnier <monnier@iro.umontreal.ca>
6886 * xselect.c (x_convert_selection): Yet another int/Lisp_Object mixup.
6888 2011-05-27 Paul Eggert <eggert@cs.ucla.edu>
6890 * xselect.c: Fix minor problems prompted by GCC 4.6.0 warnings.
6891 (x_handle_selection_request, frame_for_x_selection): Remove unused vars.
6892 (x_clipboard_manager_save): Now static.
6893 (Fx_clipboard_manager_save): Rename local to avoid shadowing.
6895 * fns.c: Fix minor problems prompted by GCC 4.6.0 warnings.
6896 (crypto_hash_function): Now static.
6897 Fix pointer signedness problems. Avoid unnecessary initializations.
6899 2011-05-27 Chong Yidong <cyd@stupidchicken.com>
6901 * termhooks.h (Vselection_alist): Make it terminal-local.
6903 * terminal.c (create_terminal): Initialize it.
6905 * xselect.c: Support for clipboard managers.
6906 (Vselection_alist): Move to termhooks.h as terminal-local var.
6907 (LOCAL_SELECTION): New macro.
6908 (x_atom_to_symbol): Handle x_display_info_for_display fail case.
6909 (symbol_to_x_atom): Remove gratuitous arg.
6910 (x_handle_selection_request, lisp_data_to_selection_data)
6911 (x_get_foreign_selection, Fx_register_dnd_atom): Callers changed.
6912 (x_own_selection, x_get_local_selection, x_convert_selection):
6913 New arg, specifying work frame. Use terminal-local Vselection_alist.
6914 (some_frame_on_display): Delete unused function.
6915 (Fx_own_selection_internal, Fx_get_selection_internal)
6916 (Fx_disown_selection_internal, Fx_selection_owner_p)
6917 (Fx_selection_exists_p): New optional frame arg.
6918 (frame_for_x_selection, Fx_clipboard_manager_save): New functions.
6919 (x_handle_selection_clear): Don't treat other terminals with the
6920 same keyboard specially. Use the terminal-local Vselection_alist.
6921 (x_clear_frame_selections): Use Frun_hook_with_args.
6923 * xterm.c (x_term_init): Intern ATOM and CLIPBOARD_MANAGER atoms.
6925 * xterm.h: Add support for those atoms.
6927 2011-05-26 Chong Yidong <cyd@stupidchicken.com>
6929 * xselect.c: ICCCM-compliant handling of MULTIPLE targets.
6930 (converted_selections, conversion_fail_tag): New global variables.
6931 (x_selection_request_lisp_error): Free the above.
6932 (x_get_local_selection): Remove unnecessary code.
6933 (x_reply_selection_request): Args changed; handle arbitrary array
6934 of converted selections stored in converted_selections.
6935 Separate the XChangeProperty and SelectionNotify steps.
6936 (x_handle_selection_request): Rewrite to handle MULTIPLE target.
6937 (x_convert_selection): New function.
6938 (x_handle_selection_event): Simplify.
6939 (x_get_foreign_selection): Don't ignore incoming requests while
6940 waiting for an answer; this will fail when we implement
6941 SAVE_TARGETS, and seems unnecessary anyway.
6942 (selection_data_to_lisp_data): Recognize ATOM_PAIR type.
6943 (Vx_sent_selection_functions): Doc fix.
6945 2011-05-26 Leo Liu <sdl.web@gmail.com>
6947 * editfns.c (Ftranspose_regions): Allow empty regions. (Bug#8699)
6949 2011-05-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
6951 * dispextern.h (struct glyph_row): New member fringe_bitmap_periodic_p.
6953 * dispnew.c (shift_glyph_matrix, scrolling_window): Mark scrolled row
6954 for fringe update if it has periodic bitmap.
6955 (row_equal_p): Also compare left_fringe_offset, right_fringe_offset,
6956 and fringe_bitmap_periodic_p.
6958 * fringe.c (get_fringe_bitmap_data): New function.
6959 (draw_fringe_bitmap_1, update_window_fringes): Use it.
6960 (update_window_fringes): Record periodicity of fringe bitmap in glyph
6961 row. Mark glyph row for fringe update if periodicity changed.
6963 * xdisp.c (try_window_reusing_current_matrix): Don't mark scrolled row
6964 for fringe update unless it has periodic bitmap.
6966 2011-05-25 Kenichi Handa <handa@m17n.org>
6968 * xdisp.c (get_next_display_element): Set correct it->face_id for
6969 a static composition.
6971 2011-05-24 Leo Liu <sdl.web@gmail.com>
6974 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha1.h.
6976 * fns.c (crypto_hash_function, Fsha1): New function.
6977 (Fmd5): Use crypto_hash_function.
6978 (syms_of_fns): Add Ssha1.
6980 2011-05-22 Paul Eggert <eggert@cs.ucla.edu>
6982 * gnutls.c: Remove unused macros.
6983 (fn_gnutls_transport_set_lowat, fn_gnutls_transport_set_pull_function):
6984 (fn_gnutls_transport_set_push_function) [!WINDOWSNT]:
6985 Remove macros that are defined and never used.
6986 Caught by gcc -Wunused-macros (GCC 4.6.0, Fedora 14).
6988 2011-05-22 Chong Yidong <cyd@stupidchicken.com>
6990 * xselect.c (syms_of_xselect): Remove unused symbol SAVE_TARGETS.
6991 (Fx_get_selection_internal): Minor cleanup.
6992 (Fx_own_selection_internal): Rename arguments for consistency with
6995 2011-05-22 Paul Eggert <eggert@cs.ucla.edu>
6997 * xselect.c (QSAVE_TARGETS): New static var, to fix build failure.
6999 2011-05-22 Chong Yidong <cyd@stupidchicken.com>
7001 * xselect.c (syms_of_xselect): Include character.h; use DEFSYM.
7003 2011-05-21 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
7005 * dispnew.c (scrolling_window): Don't exclude the case that the
7006 last enabled row in the desired matrix touches the bottom boundary.
7008 2011-05-21 Glenn Morris <rgm@gnu.org>
7010 * Makefile.in ($(etc)/DOC): Make second command line even shorter.
7011 (SOME_MACHINE_OBJECTS): Replace FONT_OBJ by its maximal expansion,
7012 and add some more files.
7014 2011-05-20 Eli Zaretskii <eliz@gnu.org>
7016 * callproc.c (Fcall_process) [MSDOS]: Fix arguments to
7017 report_file_error introduced by the change from 2011-05-07.
7019 2011-05-20 Paul Eggert <eggert@cs.ucla.edu>
7021 * systime.h (Time): Define only if emacs is defined.
7022 This is to allow ../lib-src/profile.c to be compiled on FreeBSD,
7023 where the include path doesn't have X11/X.h by default. See
7024 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00561.html>.
7026 2011-05-20 Kenichi Handa <handa@m17n.org>
7028 * composite.c (find_automatic_composition): Fix previous change.
7030 2011-05-20 Glenn Morris <rgm@gnu.org>
7032 * lisp.mk: New file, split from Makefile.in.
7033 * Makefile.in (lisp): Move to separate file, inserted by @lisp_frag@.
7034 (shortlisp): Remove.
7035 ($(etc)/DOC): Edit lisp.mk rather than using $shortlisp.
7037 2011-05-19 Glenn Morris <rgm@gnu.org>
7039 * Makefile.in (MSDOS_SUPPORT_REAL, MSDOS_SUPPORT, NS_SUPPORT)
7040 (REAL_MOUSE_SUPPORT, GPM_MOUSE_SUPPORT, MOUSE_SUPPORT, TOOLTIP_SUPPORT)
7041 (BASE_WINDOW_SUPPORT, X_WINDOW_SUPPORT, WINDOW_SUPPORT): Remove.
7042 (lisp): Set the order to that of loadup.el.
7043 (shortlisp): Make it a copy of $lisp.
7044 (SOME_MACHINE_LISP): Remove.
7045 ($(etc)/DOC): Depend just on $lisp, not $SOME_MACHINE_LISP too.
7046 Use just $shortlisp, not $SOME_MACHINE_LISP too.
7048 2011-05-18 Kenichi Handa <handa@m17n.org>
7050 * composite.c (CHAR_COMPOSABLE_P): Add more check for efficiency.
7051 (BACKWARD_CHAR): Wrap the arg STOP by parenthesis.
7052 (find_automatic_composition): Mostly rewrite for efficiency.
7054 2011-05-18 Juanma Barranquero <lekktu@gmail.com>
7056 * makefile.w32-in: Update dependencies.
7058 2011-05-18 Christoph Scholtes <cschol2112@googlemail.com>
7060 * menu.c: Include limits.h (fixes the MS-Windows build broken by
7061 2011-06-18T18:49:19Z!cyd@stupidchicken.com).
7063 2011-05-18 Paul Eggert <eggert@cs.ucla.edu>
7065 Fix some integer overflow issues, such as string length overflow.
7067 * insdel.c (count_size_as_multibyte): Check for string overflow.
7069 * character.c (lisp_string_width): Check for string overflow.
7070 Use EMACS_INT, not int, for string indexes and lengths; in
7071 particular, 2nd arg is now EMACS_INT, not int. Do not crash if
7072 the resulting string length overflows an EMACS_INT; instead,
7073 report a string overflow if no precision given. When checking for
7074 precision exhaustion, use a check that cannot possibly have
7075 integer overflow. (Bug#8675)
7076 * character.h (lisp_string_width): Adjust to new signature.
7078 * alloc.c (string_overflow): New function.
7079 (Fmake_string): Use it. This doesn't change behavior, but saves
7080 a few bytes and will simplify future changes.
7081 * character.c (string_escape_byte8): Likewise.
7082 * lisp.h (string_overflow): New decl.
7084 Fixups, following up to the user-interface timestamp change.
7085 * nsterm.m (last_mouse_movement_time, ns_mouse_position): Use Time
7086 for UI timestamps, instead of unsigned long.
7087 * msdos.c (mouse_get_pos): Likewise.
7088 * w32inevt.c (movement_time, w32_console_mouse_position): Likewise.
7089 * w32gui.h (Time): Define by including "systime.h" rather than by
7090 declaring it ourselves. (Bug#8664)
7092 * dispextern.h (struct image): Don't assume time_t <= unsigned long.
7093 * image.c (clear_image_cache): Likewise.
7095 * term.c (term_mouse_position): Don't assume time_t wraparound.
7097 Be more systematic about user-interface timestamps.
7098 Before, the code sometimes used 'Time', sometimes 'unsigned long',
7099 and sometimes 'EMACS_UINT', to represent these timestamps.
7100 This change causes it to use 'Time' uniformly, as that's what X uses.
7101 This makes the code easier to follow, and makes it easier to catch
7102 integer overflow bugs such as Bug#8664.
7103 * frame.c (Fmouse_position, Fmouse_pixel_position):
7104 Use Time, not unsigned long, for user-interface timestamps.
7105 * keyboard.c (last_event_timestamp, kbd_buffer_get_event): Likewise.
7106 (button_down_time, make_lispy_position, make_lispy_movement): Likewise.
7107 * keyboard.h (last_event_timestamp): Likewise.
7108 * menu.c (Fx_popup_menu) [!HAVE_X_WINDOWS]: Likewise.
7109 * menu.h (xmenu_show): Likewise.
7110 * term.c (term_mouse_position): Likewise.
7111 * termhooks.h (struct input_event.timestamp): Likewise.
7112 (struct terminal.mouse_position_hook): Likewise.
7113 * xmenu.c (create_and_show_popup_menu, xmenu_show): Likewise.
7114 * xterm.c (XTmouse_position, x_scroll_bar_report_motion): Likewise.
7115 * systime.h (Time): New decl. Pull it in from <X11/X.h> if
7116 HAVE_X_WINDOWS, otherwise define it as unsigned long, which is
7118 * menu.h, termhooks.h: Include "systime.h", for Time.
7120 * keyboard.c (make_lispy_event): Fix problem in integer overflow.
7121 Don't assume that the difference between two unsigned long values
7122 can fit into an integer. At this point, we know button_down_time
7123 <= event->timestamp, so the difference must be nonnegative, so
7124 there's no need to cast the result if double-click-time is
7125 nonnegative, as it should be; check that it's nonnegative, just in
7126 case. This bug is triggered when events are more than 2**31 ms
7127 apart (about 25 days). (Bug#8664)
7129 * xselect.c (last_event_timestamp): Remove duplicate decl.
7130 (x_own_selection): Remove needless cast to unsigned long.
7132 * xmenu.c (set_frame_menubar): Use int, not EMACS_UINT, for indexes
7133 that always fit in int. Use a sentinel instead of a counter, to
7134 avoid a temp and to allay GCC's concerns about possible int overflow.
7135 * frame.h (struct frame): Use int for menu_bar_items_used
7136 instead of EMACS_INT, since it always fits in int.
7138 * menu.c (grow_menu_items): Check for int overflow.
7140 * xmenu.c (set_frame_menubar): Don't mishandle vectors with no nils.
7142 * xterm.c: Use EMACS_INT for Emacs modifiers, and int for X modifiers.
7143 Before, the code was not consistent. These values cannot exceed
7144 2**31 - 1 so there's no need to make them unsigned.
7145 (x_x_to_emacs_modifiers): Accept int and return EMACS_INT.
7146 (x_emacs_to_x_modifiers): Accept EMACS_INT and return int.
7147 (x_x_to_emacs_modifiers, x_emacs_to_x_modifiers): Reject non-integers
7149 * xterm.h (x_x_to_emacs_modifiers): Adjust to signature change.
7151 * lisp.h (XINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_INT.
7152 (XUINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_UINT.
7153 Otherwise, GCC 4.6.0 warns about printf (pI, XINT (...)),
7154 presumably because the widths might not match.
7156 * window.c (size_window): Avoid needless test at loop start.
7158 2011-05-18 Courtney Bane <emacs-bugs-7626@cbane.org> (tiny change)
7160 * term.c (Fresume_tty): Restore hooks before reinitializing (bug#8687).
7162 2011-05-12 Drew Adams <drew.adams@oracle.com>
7164 * textprop.c (Fprevious_single_char_property_change): Doc fix (bug#8655).
7166 2011-05-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
7168 * w32term.c (w32_draw_fringe_bitmap): Rename local vars `left' and
7169 `width' to `bar_area_x' and `bar_area_width', respectively.
7170 (x_scroll_run): Take account of fringe background extension.
7172 * xterm.c (x_draw_fringe_bitmap) [USE_TOOLKIT_SCROLL_BARS]:
7173 Rename local vars `left' and `width' to `bar_area_x' and
7174 `bar_area_width', respectively.
7175 (x_scroll_run) [USE_TOOLKIT_SCROLL_BARS]: Take account of fringe
7176 background extension.
7178 2011-05-10 Jim Meyering <meyering@redhat.com>
7180 * xdisp.c (x_intersect_rectangles): Fix typo "the the -> the".
7182 2011-05-10 Juanma Barranquero <lekktu@gmail.com>
7184 * image.c (Finit_image_library): Return t for built-in image types,
7185 like pbm and xbm. (Bug#8640)
7187 2011-05-09 Andreas Schwab <schwab@linux-m68k.org>
7189 * w32menu.c (set_frame_menubar): Fix submenu allocation.
7191 2011-05-07 Eli Zaretskii <eliz@gnu.org>
7193 * w32console.c (Fset_screen_color): Doc fix.
7194 (Fget_screen_color): New function.
7195 (syms_of_ntterm): Defsubr it.
7197 * callproc.c (call_process_cleanup) [MSDOS]: Don't close and
7198 unlink the temporary file if Fcall_process didn't create it in the
7200 (Fcall_process) [MSDOS]: Don't create tempfile if stdout of the
7201 child process will be redirected to a file specified with `:file'.
7202 Don't try to re-open tempfile in that case, and set fd[0] to -1 as
7203 cue to call_process_cleanup not to close that handle.
7205 2011-05-07 Ben Key <bkey76@gmail.com>
7207 * makefile.w32-in: The bootstrap-temacs rule now makes use of
7208 one of two shell specific rules, either bootstrap-temacs-CMD or
7209 bootstrap-temacs-SH. The bootstrap-temacs-SH rule is identical
7210 to the previous implementation of the bootstrap-temacs rule.
7211 The bootstrap-temacs-CMD rule is similar to the previous
7212 implementation of the bootstrap-temacs rule except that it
7213 makes use of the ESC_CFLAGS variable instead of the CFLAGS
7216 These changes, along with some changes to nt/configure.bat,
7217 nt/gmake.defs, and nt/nmake.defs, are required to extend my
7218 earlier fix to add support for --cflags and --ldflags options
7219 that include quotes so that it works whether make uses cmd or
7222 2011-05-06 Michael Albinus <michael.albinus@gmx.de>
7224 * dbusbind.c (QCdbus_type_unix_fd): Declare static.
7225 (xd_remove_watch): Don't check QCdbus_type_unix_fd for SYMBOLP, it
7227 (Fdbus_init_bus, xd_read_queued_messages): Bus can be a symbol or
7228 a string. Handle both cases.
7229 (Fdbus_call_method_asynchronously, Fdbus_register_signal)
7230 (Fdbus_register_method): Use Qinvalid_function.
7232 2011-05-06 Juanma Barranquero <lekktu@gmail.com>
7234 * makefile.w32-in: Update dependencies.
7235 (LISP_H): Add inttypes.h and stdin.h.
7236 (PROCESS_H): Add unistd.h.
7238 2011-05-06 Eli Zaretskii <eliz@gnu.org>
7240 * lread.c: Include limits.h (fixes the MS-Windows build broken by
7241 2011-05-06T07:13:19Z!eggert@cs.ucla.edu).
7243 2011-05-06 Paul Eggert <eggert@cs.ucla.edu>
7245 * image.c (Finit_image_library) [!HAVE_NTGUI]: Omit unused local.
7247 * term.c (vfatal): Remove stray call to va_end.
7248 It's not needed and the C Standard doesn't allow it here anyway.
7250 Use C99's va_copy to avoid undefined behavior on x86-64 GNU/Linux.
7251 * eval.c (verror): doprnt a copy of ap, not the original. (Bug#8545)
7253 * eval.c (verror): OK to create a string of up to MOST_POSITIVE_FIXNUM
7256 * term.c: Don't include <stdarg.h>, as <lisp.h> does that.
7258 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
7260 * process.c (Fformat_network_address): Fix typo: args2 -> *args2.
7262 * xmenu.c (set_frame_menubar): Fix typo: int * -> int (3 times).
7264 * coding.c (detect_coding_charset): Fix typo: * 2 -> *4 (Bug#8601).
7266 * charset.h (struct charset.code_space): Now has 15 elements, not 16.
7267 * charset.c (Fdefine_charset_internal): Don't initialize
7268 charset.code_space[15]. The value was garbage, on hosts with
7269 32-bit int (Bug#8600).
7271 * lread.c (read_integer): Be more consistent with string-to-number.
7272 Use string_to_number to do the actual conversion; this avoids
7273 rounding errors and fixes some other screwups. Without this fix,
7274 for example, #x1fffffffffffffff was misread as -2305843009213693952.
7275 (digit_to_number): Move earlier, for benefit of read_integer.
7276 Return -1 if the digit is out of range for the base, -2 if it is
7277 not a digit in any supported base. (Bug#8602)
7279 * doprnt.c (doprnt): Support arbitrary pI values, such as "I64".
7281 * dispnew.c (scrolling_window): Return 1 if we scrolled,
7282 to match comment at start of function. This also removes a
7283 GCC warning about overflow in a 32+64-bit port.
7285 * lisp.h (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Simplify.
7287 * dbusbind.c: Do not use XPNTR on a value that may be an integer.
7288 Reported by Stefan Monnier in
7289 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00919.html>.
7290 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
7291 Use SYMBOLP-guarded XSYMBOL, not XPNTR.
7293 * lisp.h (EMACS_INTPTR): Remove. All uses changed to intptr_t.
7294 (EMACS_UINTPTR): Likewise, with uintptr_t.
7296 * lisp.h: Prefer 64-bit EMACS_INT if available.
7297 (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Define to 64-bit
7298 on 32-bit hosts that have 64-bit int, so that they can access
7300 However, temporarily disable this change unless the temporary
7301 symbol WIDE_EMACS_INT is defined.
7303 * lread.c, process.c: Do not include <inttypes.h>; lisp.h does it now.
7305 Prefer intptr_t/uintptr_t for integers the same widths as pointers.
7306 This removes an assumption that EMACS_INT and long are the same
7307 width as pointers. The assumption is true for Emacs porting targets
7308 now, but we want to make other targets possible.
7309 * lisp.h: Include <inttypes.h>, for INTPTR_MAX, UINTPTR_MAX.
7310 (EMACS_INTPTR, EMACS_UINTPTR): New macros.
7311 In the rest of the code, change types of integers that hold casted
7312 pointers to EMACS_INTPTR and EMACS_UINTPTR, systematically
7313 replacing EMACS_INT, long, EMACS_UINT, and unsigned long.
7314 (XTYPE): Don't cast arg to EMACS_UINT; normally is not needed.
7315 (XSET): Cast type of XTYPE arg to EMACS_INTPTR; it is needed here.
7316 No need to cast type when ORing.
7317 (XPNTR): Return a value of type EMACS_INTPTR or EMACS_UINTPTR.
7318 * alloc.c (lisp_align_malloc): Remove a no-longer-needed cast.
7319 * doc.c (store_function_docstring): Use EMACS_INTPTR, so as not to
7320 assume EMACS_INT is the same width as char *.
7321 * gtkutil.c (xg_gtk_scroll_destroy, xg_tool_bar_button_cb):
7322 (xg_tool_bar_callback, xg_tool_bar_help_callback, xg_make_tool_item):
7323 Remove no-longer-needed casts.
7324 (xg_create_scroll_bar, xg_tool_bar_button_cb, xg_tool_bar_callback):
7325 (xg_tool_bar_help_callback, xg_make_tool_item):
7326 Use EMACS_INTPTR to hold an integer
7327 that will be cast to void *; this can avoid a GCC warning
7328 if EMACS_INT is not the same width as void *.
7329 * menu.c (find_and_call_menu_selection): Remove no-longer-needed cast.
7330 * xdisp.c (display_echo_area_1, resize_mini_window_1):
7331 (current_message_1, set_message_1):
7332 Use a local to convert to proper width without a cast.
7333 * xmenu.c (dialog_selection_callback): Likewise.
7335 * sysdep.c (get_random): Don't assume EMACS_INT is no wider than long.
7336 Also, don't assume VALBITS / RAND_BITS is less than 5,
7337 and don't rely on undefined behavior when shifting a 1 left into
7339 * lisp.h (get_random): Change signature to match.
7341 * lread.c (hash_string): Use size_t, not int, for hash computation.
7342 Normally we prefer signed values; but hashing is special, because
7343 it's better to use unsigned division on hash table sizes so that
7344 the remainder is nonnegative. Also, size_t is the natural width
7345 for hashing into memory. The previous code used 'int', which doesn't
7346 retain enough info to hash well into very large tables.
7347 (oblookup, oblookup_last_bucket_number, Funintern): Likewise.
7349 * dbusbind.c: Don't possibly lose pointer info when converting.
7350 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
7351 Use XPNTR rather than XHASH, so that the high-order bits of
7352 the pointer aren't lost when converting through void *.
7354 * eval.c (Fautoload): Don't double-shift a pointer.
7356 * fns.c (Frandom): Let EMACS_UINT be wider than unsigned long.
7358 2011-05-06 Juanma Barranquero <lekktu@gmail.com>
7360 * gnutls.c (DEF_GNUTLS_FN):
7361 * image.c (DEF_IMGLIB_FN): Make function pointers static.
7363 2011-05-05 Andreas Schwab <schwab@linux-m68k.org>
7365 * lread.c (lisp_file_lexically_bound_p): Stop scanning at end
7368 2011-05-05 Eli Zaretskii <eliz@gnu.org>
7370 * w32heap.c (allocate_heap) [USE_LISP_UNION_TYPE || USE_LSB_TAG]:
7371 New version that can reserve upto 2GB of heap space.
7373 2011-05-05 Chong Yidong <cyd@stupidchicken.com>
7375 * nsfns.m (Fns_read_file_name): Doc fix (Bug#8534).
7377 2011-05-05 Teodor Zlatanov <tzz@lifelogs.com>
7379 * gnutls.c (fn_gnutls_certificate_set_x509_key_file): Add alias to
7380 `gnutls_certificate_set_x509_key_file'.
7382 2011-05-05 Juanma Barranquero <lekktu@gmail.com>
7384 * makefile.w32-in ($(BLD)/image.$(O), $(BLD)/process.$(O)):
7385 Update dependencies.
7387 2011-05-04 Juanma Barranquero <lekktu@gmail.com>
7389 * gnutls.h (emacs_gnutls_write, emacs_gnutls_read):
7390 * gnutls.c (emacs_gnutls_write, emacs_gnutls_read):
7391 Remove unused parameter `fildes'.
7392 * process.c (read_process_output, send_process): Don't pass it.
7394 2011-05-04 Juanma Barranquero <lekktu@gmail.com>
7396 Fix previous change: the library cache is defined in w32.c.
7397 * image.c (CACHE_IMAGE_TYPE) [!HAVE_NTGUI]: Define to noop.
7398 (Finit_image_library): Wrap Vlibrary_cache on "#ifdef HAVE_NTGUI".
7400 2011-05-04 Juanma Barranquero <lekktu@gmail.com>
7402 Implement dynamic loading of GnuTLS on Windows.
7404 * gnutls.h (GNUTLS_EMACS_ERROR_NOT_LOADED): New macro.
7405 (emacs_gnutls_write, emacs_gnutls_read): Mark as extern.
7406 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
7409 * gnutls.c (Qgnutls_dll): Define.
7410 (DEF_GNUTLS_FN, LOAD_GNUTLS_FN): New macros.
7411 (gnutls_*): Declare function pointers.
7412 (init_gnutls_functions): New function to initialize function pointers.
7413 (emacs_gnutls_handshake, Fgnutls_error_string, Fgnutls_deinit)
7414 (emacs_gnutls_global_init, Fgnutls_bye): Use function pointers.
7415 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
7416 Wrappers for gnutls_record_check_pending and gnutls_transport_set_errno.
7417 (emacs_gnutls_write, emacs_gnutls_read)
7418 (emacs_gnutls_handle_error, Fgnutls_error_fatalp)
7419 (Fgnutls_available_p): New function.
7420 (Fgnutls_boot): Call Fgnutls_available_p. Use function pointers.
7421 (syms_of_gnutls) <Qgnutls_dll>: Initialize and staticpro it.
7422 (syms_of_gnutls) <Sgnutls_available_p>: defsubr it.
7424 * image.c: Include w32.h.
7425 (Vimage_type_cache): Delete.
7426 (syms_of_image) <Vimage_type_cache>: Don't initialize and staticpro it.
7427 (CACHE_IMAGE_TYPE, Finit_image_library): Use Vlibrary_cache instead.
7428 (w32_delayed_load): Move to w32.c.
7430 * w32.h (VlibraryCache, QCloaded_from, w32_delayed_load): Declare.
7432 * w32.c (QCloaded_from, Vlibrary_cache): Define.
7433 (w32_delayed_load): Move from image.c. When loading a library, record
7434 its filename in the :loaded-from property of the library id.
7435 (globals_of_w32) <QCloaded_from, Vlibrary_cache>:
7436 Initialize and staticpro them.
7437 (emacs_gnutls_pull, emacs_gnutls_push): Call emacs_gnutls_* functions.
7439 * process.c: Include lisp.h before w32.h, not after.
7440 (wait_reading_process_output): Call emacs_gnutls_record_check_pending
7441 instead of gnutls_record_check_pending.
7443 * callproc.c, emacs.c: Include lisp.h before w32.h, not after.
7445 2011-05-04 Teodor Zlatanov <tzz@lifelogs.com>
7447 * gnutls.c (Fgnutls_boot): Support :keylist and :crlfiles options
7448 instead of :keyfiles. Give GnuTLS the keylist and the CRL lists
7451 2011-05-03 Jan Djärv <jan.h.d@swipnet.se>
7453 * xterm.c (x_set_frame_alpha): Do not set property on anything
7454 else than FRAME_X_OUTER_WINDOW (Bug#8608).
7456 2011-05-02 Juanma Barranquero <lekktu@gmail.com>
7458 * sysdep.c (get_tty_size) [WINDOWSNT]: Implement. (Bug#8596)
7460 2011-05-02 Juanma Barranquero <lekktu@gmail.com>
7462 * gnutls.c (Qgnutls_log_level, Qgnutls_code, Qgnutls_anon)
7463 (Qgnutls_x509pki, Qgnutls_e_interrupted, Qgnutls_e_again)
7464 (Qgnutls_e_invalid_session, Qgnutls_e_not_ready_for_handshake)
7465 (gnutls_global_initialized, Qgnutls_bootprop_priority)
7466 (Qgnutls_bootprop_trustfiles, Qgnutls_bootprop_keyfiles)
7467 (Qgnutls_bootprop_callbacks, Qgnutls_bootprop_loglevel)
7468 (Qgnutls_bootprop_hostname, Qgnutls_bootprop_verify_flags)
7469 (Qgnutls_bootprop_verify_error, Qgnutls_bootprop_verify_hostname_error)
7470 (Qgnutls_bootprop_callbacks_verify): Make static.
7472 2011-05-01 Andreas Schwab <schwab@linux-m68k.org>
7474 * callproc.c: Indentation fixup.
7476 * sysdep.c (wait_for_termination_1): Make static.
7477 (wait_for_termination, interruptible_wait_for_termination):
7478 Move after wait_for_termination_1.
7480 2011-05-01 Lars Magne Ingebrigtsen <larsi@gnus.org>
7482 * sysdep.c (interruptible_wait_for_termination): New function
7483 which is like wait_for_termination, but allows keyboard
7486 * callproc.c (Fcall_process): Add (:file "file") as an option for
7488 (Fcall_process_region): Ditto.
7490 2011-04-30 Eli Zaretskii <eliz@gnu.org>
7492 * dosfns.c (Fint86, Fdos_memget, Fdos_memput): Use `ASIZE (FOO)'
7493 rather than `XVECTOR (FOO)->size'.
7495 * process.c: Remove HAVE_INTTYPES_H condition from inclusion of
7496 inttypes.h, as a gnulib replacement is used if it not available in
7499 2011-04-21 Eli Zaretskii <eliz@gnu.org>
7501 Lift the MOST_POSITIVE_FIXNUM/4 limitation on visited files.
7502 * fileio.c (Finsert_file_contents): Don't limit file size to 1/4
7503 of MOST_POSITIVE_FIXNUM. (Bug#8528)
7505 * coding.c (coding_alloc_by_realloc): Error out if destination
7506 will grow beyond MOST_POSITIVE_FIXNUM.
7507 (decode_coding_emacs_mule): Abort if there isn't enough place in
7508 charbuf for the composition carryover bytes. Reserve an extra
7509 space for up to 2 characters produced in a loop.
7510 (decode_coding_iso_2022): Abort if there isn't enough place in
7511 charbuf for the composition carryover bytes.
7513 2011-04-21 Eli Zaretskii <eliz@gnu.org>
7515 * doprnt.c (doprnt) [!HAVE_LONG_LONG_INT]: Error out instead of
7516 aborting when %lld or %lll format is passed.
7517 [!HAVE_UNSIGNED_LONG_LONG_INT]: Error out instead of aborting when
7518 %llo or %llx format is passed. (Bug#8545)
7520 * window.c (window_scroll_line_based): Use a marker instead of
7521 simple variables to record original value of point. (Bug#7952)
7523 * doprnt.c (doprnt): Fix the case where a multibyte sequence
7524 produced by %s or %c overflows available buffer space. (Bug#8545)
7526 2011-04-28 Paul Eggert <eggert@cs.ucla.edu>
7528 * doprnt.c (doprnt): Omit useless test; int overflow check (Bug#8545).
7529 (SIZE_MAX): Move defn after all includes, as they might #define it.
7531 2011-04-28 Juanma Barranquero <lekktu@gmail.com>
7533 * w32.c (init_environment): Warn about defaulting HOME to C:\.
7535 2011-04-28 Juanma Barranquero <lekktu@gmail.com>
7537 * keyboard.c (Qdelayed_warnings_hook): Define.
7538 (command_loop_1): Run `delayed-warnings-hook'
7539 if Vdelayed_warnings_list is non-nil.
7540 (syms_of_keyboard) <delayed-warnings-hook>: DEFSYM it.
7541 (syms_of_keyboard) <delayed-warnings-list>: DEFVAR_LISP it.
7543 2011-04-28 Eli Zaretskii <eliz@gnu.org>
7545 * doprnt.c (doprnt): Don't return value smaller than the buffer
7546 size if the message was truncated. (Bug#8545).
7548 2011-04-28 Juanma Barranquero <lekktu@gmail.com>
7550 * w32fns.c (Fx_change_window_property, Fx_delete_window_property)
7551 (Fx_window_property): #if-0 the whole functions, not just the bodies.
7553 2011-04-27 Paul Eggert <eggert@cs.ucla.edu>
7555 * doprnt.c (doprnt): Support "ll" length modifier, for long long.
7557 2011-04-27 Juanma Barranquero <lekktu@gmail.com>
7559 * makefile.w32-in: Update dependencies.
7561 2011-04-27 Eli Zaretskii <eliz@gnu.org>
7563 Improve `doprnt' and its usage. (Bug#8545)
7564 * doprnt.c (doprnt): Make sure `format' is never accessed beyond
7565 `format_end'. Remove support for %l as a conversion specifier.
7566 Don't use xrealloc. Improve diagnostics when the %l size modifier
7567 is used. Update the commentary.
7569 * eval.c (verror): Simplify calculation of size_t.
7571 * coding.c (Ffind_operation_coding_system): Fix diagnostic error
7574 2011-04-27 Yoshiaki Kasahara <kasahara@nc.kyushu-u.ac.jp> (tiny change)
7576 * buffer.c (init_buffer) [USE_MMAP_FOR_BUFFERS]: Adjust to aliasing
7579 2011-04-27 Paul Eggert <eggert@cs.ucla.edu>
7581 * nsmenu.m: Replace all uses of XVECTOR with ASIZE and AREF.
7582 This makes this file independent of the recent pseudovector change.
7584 2011-04-26 Paul Eggert <eggert@cs.ucla.edu>
7586 * keyboard.c (handle_user_signal): Fix pointer signedness problem.
7588 * gnutls.c (emacs_gnutls_handle_error): Remove unused local.
7589 (Fgnutls_boot): gnutls_certificate_verify_peers2 wants unsigned *.
7590 Remove unused local.
7591 (emacs_gnutls_write): Don't use uninitialized rtnval if nbyte <= 0.
7593 * lisp.h: Fix a problem with aliasing and vector headers. (Bug#8546)
7594 GCC 4.6.0 optimizes based on type-based alias analysis.
7595 For example, if b is of type struct buffer * and v of type struct
7596 Lisp_Vector *, then gcc -O2 was incorrectly assuming that &b->size
7597 != &v->size, and therefore "v->size = 1; b->size = 2; return
7598 v->size;" must therefore return 1. This assumption is incorrect
7599 for Emacs, since it type-puns struct Lisp_Vector * with many other
7600 types. To fix this problem, this patch adds a new type struct
7601 vectorlike_header that documents the constraints on layout of vectors
7602 and pseudovectors, and helps optimizing compilers not get fooled
7603 by Emacs's type punning. It also adds the macros XSETTYPED_PVECTYPE
7604 XSETTYPED_PSEUDOVECTOR, TYPED_PSEUDOVECTORP, for similar reasons.
7605 * lisp.h (XSETTYPED_PVECTYPE): New macro, specifying the name of
7607 (XSETPVECTYPE): Rewrite in terms of new macro.
7608 (XSETPVECTYPESIZE): New macro, specifying both type and size.
7609 This is a bit clearer, and further avoids the possibility of
7610 undesirable aliasing.
7611 (XSETTYPED_PSEUDOVECTOR): New macro, specifying the size.
7612 (XSETPSEUDOVECTOR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR.
7613 (XSETSUBR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR and XSIZE,
7614 since Lisp_Subr is a special case (no "next" field).
7615 (ASIZE): Now uses header.size rather than size.
7616 All previous uses of XVECTOR (foo)->size replaced to use this macro,
7617 to avoid the hassle of writing XVECTOR (foo)->header.size.
7618 (struct vectorlike_header): New type.
7619 (TYPED_PSEUDOVECTORP): New macro, also specifying the C type of the
7620 object, to help avoid aliasing.
7621 (PSEUDOVECTORP): Rewrite in terms of TYPED_PSEUDOVECTORP.
7622 (SUBRP): Likewise, since Lisp_Subr is a special case.
7623 * lisp.h (struct Lisp_Vector, struct Lisp_Char_Table):
7624 (struct Lisp_Sub_Char_Table, struct Lisp_Bool_Vector):
7625 (struct Lisp_Hash_Table): Combine first two members into a single
7626 struct vectorlike_header member. All uses of "size" and "next" members
7627 changed to be "header.size" and "header.next".
7628 * buffer.h (struct buffer): Likewise.
7629 * font.h (struct font_spec, struct font_entity, struct font): Likewise.
7630 * frame.h (struct frame): Likewise.
7631 * process.h (struct Lisp_Process): Likewise.
7632 * termhooks.h (struct terminal): Likewise.
7633 * window.c (struct save_window_data, struct saved_window): Likewise.
7634 * window.h (struct window): Likewise.
7635 * alloc.c (allocate_buffer, Fmake_bool_vector, allocate_pseudovector):
7636 Use XSETPVECTYPESIZE, not XSETPVECTYPE, to avoid aliasing problems.
7637 * buffer.c (init_buffer_once): Likewise.
7638 * lread.c (defsubr): Use XSETTYPED_PVECTYPE, since Lisp_Subr is a
7640 * process.c (Fformat_network_address): Use local var for size,
7643 * bytecode.c (exec_byte_code): Don't use XVECTOR before CHECK_VECTOR.
7645 Make the Lisp reader and string-to-float more consistent (Bug#8525)
7646 * data.c (atof): Remove decl; no longer used or needed.
7647 (digit_to_number): Move to lread.c.
7648 (Fstring_to_number): Use new string_to_number function, to be
7649 consistent with how the Lisp reader treats infinities and NaNs.
7650 Do not assume that floating-point numbers represent EMACS_INT
7651 without losing information; this is not true on most 64-bit hosts.
7652 Avoid double-rounding errors, by insisting on integers when
7653 parsing non-base-10 numbers, as the documentation specifies.
7654 * lisp.h (string_to_number): New decl, replacing ...
7655 (isfloat_string): Remove.
7656 * lread.c: Include <inttypes.h>, for uintmax_t and strtoumax.
7657 (read1): Do not accept +. and -. as integers; this
7658 appears to have been a coding error. Similarly, do not accept
7659 strings like +-1e0 as floating point numbers. Do not report
7660 overflow for integer overflows unless the base is not 10 which
7661 means we have no simple and reliable way to continue.
7662 Break out the floating-point parsing into a new
7663 function string_to_number, so that Fstring_to_number parses
7664 floating point numbers consistently with the Lisp reader.
7665 (digit_to_number): Move here from data.c. Make it static inline.
7666 (E_CHAR, EXP_INT): Remove, replacing with ...
7667 (E_EXP): New macro, to solve the "1.0e+" problem mentioned below.
7668 (string_to_number): New function, replacing isfloat_string.
7669 This function checks for valid syntax and produces the resulting
7670 Lisp float number too. Rework it so that string-to-number
7671 no longer mishandles examples like "1.0e+". Use strtoumax,
7672 so that overflow for non-base-10 numbers is reported only when
7673 there's no portable and simple way to convert to floating point.
7675 * textprop.c (set_text_properties_1): Rewrite for clarity,
7676 and to avoid GCC warning about integer overflow.
7678 * intervals.h (struct interval): Use EMACS_INT for members
7679 where EMACS_UINT might cause problems. See
7680 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html>.
7681 (CHECK_TOTAL_LENGTH): Remove cast to EMACS_INT; no longer needed.
7682 * intervals.c (interval_deletion_adjustment): Now returns EMACS_INT.
7684 (offset_intervals): Tell GCC not to worry about length overflow
7685 when negating a negative length.
7687 * alloc.c (overrun_check_malloc, overrun_check_realloc): Now static.
7688 (overrun_check_free): Likewise.
7690 * alloc.c (SDATA_SIZE) [!GC_CHECK_STRING_BYTES]: Avoid runtime check
7691 in the common case where SDATA_DATA_OFFSET is a multiple of Emacs
7694 * gnutls.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
7695 (gnutls_make_error): Rename local to avoid shadowing.
7696 (gnutls_emacs_global_deinit): ifdef out; not used.
7697 (Fgnutls_boot): Use const for pointer to readonly storage.
7698 Comment out unused local. Fix pointer signedness problems.
7700 * lread.c (openp): Don't stuff size_t into an 'int'.
7701 Use <= on length, not < on length + 1, to avoid GCC 4.6.0 warning
7702 about possible signed overflow.
7704 * gtkutil.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
7705 (GDK_KEY_g): Don't define if already defined.
7706 (xg_prepare_tooltip): Avoid pointer signedness problem.
7707 (xg_set_toolkit_scroll_bar_thumb): Redo to avoid two casts.
7709 * process.c (Fnetwork_interface_info): Avoid left-shift undefined
7710 behavior with 1 << 31. GCC 4.6.0 warns about this on 32-bit hosts.
7712 * xfns.c (Fx_window_property): Simplify a bit,
7713 to make a bit faster and to avoid GCC 4.6.0 warning.
7714 * xselect.c (x_get_window_property, x_handle_dnd_message): Likewise.
7716 * fns.c (internal_equal): Don't assume size_t fits in int.
7718 * alloc.c (compact_small_strings): Tighten assertion a little.
7720 Replace pEd with more-general pI, and fix some printf arg casts.
7721 * lisp.h (pI): New macro, generalizing old pEd macro to other
7722 conversion specifiers. For example, use "...%"pI"d..." rather
7723 than "...%"pEd"...".
7724 (pEd): Remove. All uses replaced with similar uses of pI.
7725 * m/amdx86-64.h, m/ia64.h, m/ibms390x.h: Likewise.
7726 * alloc.c (check_pure_size): Don't overflow by converting size to int.
7727 * bidi.c (bidi_dump_cached_states): Use pI to avoid cast.
7728 * data.c (Fnumber_to_string): Use pI instead of if-then-else-abort.
7729 * dbusbind.c (xd_append_arg): Use pI to avoid cast.
7730 (Fdbus_method_return_internal, Fdbus_method_error_internal): Likewise.
7731 * font.c (font_unparse_xlfd): Avoid potential buffer overrun on
7733 (font_unparse_xlfd, font_unparse_fcname): Use pI to avoid casts.
7734 * keyboard.c (record_char, modify_event_symbol): Use pI to avoid casts.
7735 * print.c (safe_debug_print, print_object): Likewise.
7736 (print_object): Don't overflow by converting EMACS_INT or EMACS_UINT
7738 Use pI instead of if-then-else-abort. Use %p to avoid casts,
7739 avoiding the 0 flag, which is not portable.
7740 * process.c (Fmake_network_process): Use pI to avoid cast.
7741 * region-cache.c (pp_cache): Likewise.
7742 * xdisp.c (decode_mode_spec): Likewise.
7743 * xrdb.c (x_load_resources) [USE_MOTIF]: Use pI to avoid undefined
7744 behavior on 64-bit hosts with printf arg.
7745 * xselect.c (x_queue_event): Use %p to avoid casts, avoiding 0 flag.
7746 (x_stop_queuing_selection_requests): Likewise.
7747 (x_get_window_property): Don't truncate byte count to an 'int'
7750 * frame.c (frame_name_fnn_p): Get rid of strtol, which isn't right
7751 here, since it parses constructs like leading '-' and spaces,
7752 which are not wanted; and it overflows with large numbers.
7753 Instead, simply match F[0-9]+, which is what is wanted anyway.
7755 * alloc.c: Remove unportable assumptions about struct layout.
7756 (SDATA_SELECTOR, SDATA_DATA_OFFSET): New macros.
7757 (SDATA_OF_STRING, SDATA_SIZE, allocate_string_data):
7758 (allocate_vectorlike, make_pure_vector): Use the new macros,
7759 plus offsetof, to remove unportable assumptions about struct layout.
7760 These assumptions hold on all porting targets that I know of, but
7761 they are not guaranteed, they're easy to remove, and removing them
7762 makes further changes easier.
7764 * alloc.c (BLOCK BYTES): Fix typo by changing "ablock" to "ablocks".
7765 This doesn't fix a bug but makes the code clearer.
7766 (string_overrun_cookie): Now const. Use initializers that
7767 don't formally overflow signed char, to avoid warnings.
7768 (allocate_string_data) [GC_CHECK_STRING_OVERRUN]: Fix typo that
7769 can cause Emacs to crash when string overrun checking is enabled.
7770 (allocate_buffer): Don't assume sizeof (struct buffer) is a
7771 multiple of sizeof (EMACS_INT); it need not be, if
7772 alignof(EMACS_INT) < sizeof (EMACS_INT).
7773 (check_sblock, check_string_bytes, check_string_free_list): Protoize.
7775 2011-04-26 Juanma Barranquero <lekktu@gmail.com>
7777 * keyboard.c (QCrtl): Rename from Qrtl. All uses changed.
7779 2011-04-26 Teodor Zlatanov <tzz@lifelogs.com>
7781 * gnutls.c (emacs_gnutls_handshake): Return an error if we're not
7782 supposed to be handshaking. (Bug#8556)
7783 Reported by Paul Eggert <eggert@cs.ucla.edu>.
7785 2011-04-26 Daniel Colascione <dan.colascione@gmail.com>
7787 * lisp.h (Qdebug): List symbol.
7788 * eval.c (Qdebug): Restore global linkage.
7789 * keyboard.c (debug-on-event): New variable.
7790 (handle_user_signal): Break into debugger when debug-on-event
7791 matches the current signal symbol.
7793 2011-04-25 Dan Nicolaescu <dann@ics.uci.edu>
7795 * alloc.c (check_sblock, check_string_bytes)
7796 (check_string_free_list): Convert to standard C.
7798 2011-04-25 Teodor Zlatanov <tzz@lifelogs.com>
7800 * w32.c (emacs_gnutls_push): Fix typo.
7802 2011-04-25 Eli Zaretskii <eliz@gnu.org>
7804 * gnutls.c (emacs_gnutls_handshake): Avoid compiler warnings about
7805 "cast to pointer from integer of different size".
7807 Improve doprnt and its use in verror. (Bug#8545)
7808 * doprnt.c (doprnt): Document the set of format control sequences
7809 supported by the function. Use SAFE_ALLOCA instead of always
7812 * eval.c (verror): Don't limit the buffer size at size_max-1, that
7813 is one byte too soon. Don't use xrealloc; instead xfree and
7816 2011-04-24 Teodor Zlatanov <tzz@lifelogs.com>
7818 * gnutls.h: Add GNUTLS_STAGE_CALLBACKS enum to denote we're in the
7821 * gnutls.c: Renamed global_initialized to
7822 gnutls_global_initialized. Added internals for the
7823 :verify-hostname-error, :verify-error, and :verify-flags
7824 parameters of `gnutls-boot' and documented those parameters in the
7825 docstring. Start callback support.
7826 (emacs_gnutls_handshake): Add Woe32 support. Retry handshake
7827 unless a fatal error occurred. Call gnutls_alert_send_appropriate
7828 on error. Return error code.
7829 (emacs_gnutls_write): Call emacs_gnutls_handle_error.
7830 (emacs_gnutls_read): Likewise.
7831 (Fgnutls_boot): Return handshake error code.
7832 (emacs_gnutls_handle_error): New function.
7833 (wsaerror_to_errno): Likewise.
7835 * w32.h (emacs_gnutls_pull): Add prototype.
7836 (emacs_gnutls_push): Likewise.
7838 * w32.c (emacs_gnutls_pull): New function for GnuTLS on Woe32.
7839 (emacs_gnutls_push): Likewise.
7841 2011-04-24 Claudio Bley <claudio.bley@gmail.com> (tiny change)
7843 * process.c (wait_reading_process_output): Check if GnuTLS
7844 buffered some data internally if no FDs are set for TLS
7847 * makefile.w32-in (OBJ2): Add gnutls.$(O).
7848 (LIBS): Link to USER_LIBS.
7849 ($(BLD)/gnutls.$(0)): New target.
7851 2011-04-24 Eli Zaretskii <eliz@gnu.org>
7853 * xdisp.c (handle_single_display_spec): Rename the
7854 display_replaced_before_p argument into display_replaced_p, to
7855 make it consistent with the commentary. Fix typos in the
7858 * textprop.c (syms_of_textprop): Remove dead code.
7859 (copy_text_properties): Delete obsolete commentary about an
7860 interface that was deleted long ago. Fix typos in the description
7863 * msdos.c (XMenuActivate, XMenuAddSelection): Adjust argument list
7864 to changes in oldXMenu/XMenu.h from 2011-04-16.
7865 <menu_help_message, prev_menu_help_message>: Constify.
7866 (IT_menu_make_room): menu->help_text is now `const char **';
7869 * msdos.h (XMenuActivate, XMenuAddSelection): Adjust prototypes
7870 to changes in oldXMenu/XMenu.h from 2011-04-16.
7871 (struct XMenu): Declare `help_text' `const char **'.
7873 * xfaces.c <Qunspecified>: Make extern again.
7875 * syntax.c: Include sys/types.h before including regex.h, as
7878 * doc.c (get_doc_string): Improve the format passed to `error'.
7880 * doprnt.c (doprnt): Improve commentary.
7882 * term.c (init_tty) [MSDOS]: Fix 1st argument to maybe_fatal.
7884 * Makefile.in (TAGS): Depend on $(M_FILE) and $(S_FILE), and scan
7887 * makefile.w32-in (globals.h): Add a dummy recipe, to make any
7888 changes in globals.h immediately force recompilation.
7889 (TAGS): Depend on $(CURDIR)/m/intel386.h and
7890 $(CURDIR)/s/ms-w32.h.
7891 (TAGS-gmake): Scan $(CURDIR)/m/intel386.h and $(CURDIR)/s/ms-w32.h.
7893 * character.c (Fchar_direction): Function deleted.
7894 (syms_of_character): Don't defsubr it.
7895 <char-direction-table>: Deleted.
7897 2011-04-23 Eli Zaretskii <eliz@gnu.org>
7899 Fix doprnt so it could be used again safely in `verror'. (Bug#8435)
7900 * doprnt.c: Include limits.h.
7901 (SIZE_MAX): New macro.
7902 (doprnt): Return a size_t value. 2nd arg is now size_t.
7903 Many local variables are now size_t instead of int or unsigned.
7904 Improve overflow protection. Support `l' modifier for integer
7905 conversions. Support %l conversion. Don't assume an EMACS_INT
7906 argument for integer conversions and for %c.
7908 * lisp.h (doprnt): Restore prototype.
7910 * makefile.w32-in ($(BLD)/callint.$(O)): Depend on
7913 * Makefile.in (base_obj): Add back doprnt.o.
7915 * deps.mk (doprnt.o): Add back prerequisites.
7916 (callint.o): Depend on character.h.
7918 * eval.c (internal_lisp_condition_case): Include the handler
7919 representation in the error message.
7920 (verror): Call doprnt instead of vsnprintf. Fix an off-by-one bug
7921 when breaking from the loop.
7923 * xdisp.c (vmessage): Call doprnt instead of vsnprintf.
7925 * callint.c (Fcall_interactively): When displaying error message
7926 about invalid control letter, pass the character's codepoint, not
7927 a pointer to its multibyte form. Improve display of the character
7928 in octal and display also its hex code.
7930 * character.c (char_string): Use %x to display the (unsigned)
7931 codepoint of an invalid character, to avoid displaying a bogus
7934 * font.c (check_otf_features): Pass SDATA of SYMBOL_NAME to
7935 `error', not SYMBOL_NAME itself.
7937 * coding.c (Fencode_sjis_char, Fencode_big5_char): Use %c for
7938 character arguments to `error'.
7940 * charset.c (check_iso_charset_parameter): Fix incorrect argument
7941 to `error' in error message about FINAL_CHAR argument. Make sure
7942 FINAL_CHAR is a character, and use %c when it is passed as
7943 argument to `error'.
7945 2011-04-23 Eli Zaretskii <eliz@gnu.org>
7947 * s/ms-w32.h (localtime): Redirect to sys_localtime.
7949 * w32.c: Include <time.h>.
7950 (sys_localtime): New function.
7952 2011-04-23 Chong Yidong <cyd@stupidchicken.com>
7954 * xdisp.c (init_xdisp): Initialize echo_area_window (Bug#6451).
7956 * buffer.c (syms_of_buffer): Doc fix (Bug#6902).
7958 2011-04-23 Samuel Thibault <sthibault@debian.org> (tiny change)
7960 * sysdep.c (wait_for_termination): On GNU Hurd, kill returns -1 on
7963 2011-04-19 Eli Zaretskii <eliz@gnu.org>
7965 * syntax.h (SETUP_SYNTAX_TABLE_FOR_OBJECT): Fix setting of
7966 gl_state.e_property when gl_state.object is Qt.
7968 * insdel.c (make_gap_larger): Remove limitation of buffer size
7971 2011-04-18 Chong Yidong <cyd@stupidchicken.com>
7973 * xdisp.c (lookup_glyphless_char_display)
7974 (produce_glyphless_glyph): Handle cons cell entry in
7975 glyphless-char-display.
7976 (Vglyphless_char_display): Document it.
7978 * term.c (produce_glyphless_glyph): Handle cons cell entry in
7979 glyphless-char-display.
7981 2011-04-17 Chong Yidong <cyd@stupidchicken.com>
7983 * xdisp.c (get_next_display_element): Remove unnecessary ifdefs.
7985 * termhooks.h (FRAME_WINDOW_P): Remove duplicated definitions.
7987 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): Add missing
7988 definition for no-X builds.
7990 2011-04-16 Paul Eggert <eggert@cs.ucla.edu>
7992 Static checks with GCC 4.6.0 and non-default toolkits.
7994 * s/sol2-6.h, s/unixware.h (PTY_TTY_NAME_SPRINTF): Protoize decl.
7996 * process.c (keyboard_bit_set): Define only if SIGIO.
7997 (send_process_trap): Mark it with NO_RETURN if it doesn't return.
7998 (send_process): Repair possible setjmp clobbering.
8000 * s/usg5-4-common.h (SETUP_SLAVE_PTY): Don't pass extra arg to 'fatal'.
8002 * eval.c: Include <stdio.h>, for vsnprintf on non-GNU/Linux hosts.
8004 * data.c (arith_error): Mark with NO_RETURN if it doesn't return.
8006 * alloc.c (bytes_used_when_full, SPARE_MEMORY, BYTES_USED):
8007 Define only if needed.
8009 * sysdep.c (_FILE_OFFSET_BITS): Make this hack even uglier
8010 by pacifying GCC about it. Maybe it's time to retire it?
8011 * xfaces.c (USG, __TIMEVAL__): Likewise.
8013 * dispextern.h (struct redisplay_interface): Rename param
8015 * termhooks.h (struct terminal): Likewise.
8016 * xterm.c (xembed_send_message): Likewise.
8018 * insdel.c (make_gap_smaller): Define only if
8019 USE_MMAP_FOR_BUFFERS || REL_ALLOC || DOUG_LEA_MALLOC.
8021 * keyboard.c (read_char): Make a var volatile so longjmp won't clobber
8024 * emacs.c (MAX_HEAP_BSS_DIFF, my_edata): Move to where they're used,
8025 so that we aren't warned about unused symbols.
8027 * xfns.c (Fx_file_dialog): Rename local to avoid shadowing.
8029 * xdisp.c (x_produce_glyphs): Mark var as initialized (Bug#8512).
8031 * xfns.c (x_real_positions): Mark locals as initialized.
8033 * xmenu.c (xmenu_show): Don't use uninitialized vars.
8035 * xterm.c: Fix problems found by static analysis with other toolkits.
8036 (toolkit_scroll_bar_interaction): Define and use only if USE_X_TOOLKIT.
8037 (x_dispatch_event): Declare static if USE_GTK, and
8038 define if USE_GTK || USE_X_TOOLKIT.
8039 (SET_SAVED_BUTTON_EVENT): Define only if USE_X_TOOLKIT || USE_GTK.
8040 * xterm.h (x_dispatch_event): Extern only if USE_X_TOOLKIT.
8041 * xterm.c, xterm.h (x_mouse_leave): Bring this function back, but only
8042 if defined HAVE_MENUS && !defined USE_X_TOOLKIT && !defined USE_GTK.
8044 * xmenu.c (menu_help_callback): Pointer type fixes.
8045 Use const pointers when pointing at readonly data. Avoid pointer
8047 (FALSE): Remove unused macro.
8048 (update_frame_menubar): Remove unused decl.
8050 * xfns.c (Fx_hide_tip): Move locals to avoid shadowing.
8052 * menu.c (push_submenu_start, push_submenu_end): Do not define unless
8053 USE_X_TOOLKIT || USE_GTK || HAVE_NS || defined HAVE_NTGUI.
8054 (single_menu_item): Rename local to avoid shadowing.
8056 * keyboard.c (make_lispy_event): Remove unused local var.
8058 * frame.c, frame.h (x_get_resource_string): Bring this back, but
8059 only if HAVE_X_WINDOWS && !USE_X_TOOLKIT.
8061 * bitmaps: Change bitmaps from unsigned char back to the X11
8062 compatible char. Avoid the old compiler warnings about
8063 out-of-range initializers by using, for example, '\xab' rather
8066 * xgselect.c (xgselect_initialize): Check vs interface
8067 even if ! (defined (USE_GTK) || defined (HAVE_GCONF)).
8069 * xmenu.c (xmenu_show): Rename parm to avoid shadowing.
8071 * xterm.c (x_create_toolkit_scroll_bar): Use const * for pointers
8072 to read-only memory.
8074 * fns.c (vector): Remove; this old hack is no longer needed.
8076 * xsmfns.c (create_client_leader_window): Rename shadowing arg.
8078 (gdk_x11_set_sm_client_id) [!USE_GTK]: Don't define.
8080 * xrdb.c (x_load_resources): Omit unused local.
8082 * xfns.c (free_frame_menubar, atof): Remove duplicate decls.
8083 (x_window): Rename locals to avoid shadowing.
8084 (USG): Use the kludged USG macro, to pacify gcc.
8086 * xterm.c (x_alloc_nearest_color_for_widget): Remove; unused.
8087 (x_term_init): Remove local to avoid shadowing.
8089 * xfns.c, xterm.c (_XEditResCheckMessages): Protoize decl.
8091 * xdisp.c, dispextern.h (set_vertical_scroll_bar): Now extern if
8092 USE_TOOLKIT_SCROLL_BARS && !USE_GTK, as xterm.c needs it then.
8094 2011-04-16 Eli Zaretskii <eliz@gnu.org>
8096 * gnutls.c (Fgnutls_boot): Don't pass Lisp_Object to `error'.
8098 Fix regex.c, syntax.c and friends for buffers > 2GB.
8099 * syntax.h (struct gl_state_s): Declare character position members
8102 * syntax.c (update_syntax_table): Declare 2nd argument EMACS_INT.
8104 * textprop.c (verify_interval_modification, interval_of):
8105 Declare arguments EMACS_INT.
8107 * intervals.c (adjust_intervals_for_insertion): Declare arguments
8110 * intervals.h (CHECK_TOTAL_LENGTH): Cast to EMACS_INT, not `int'.
8112 * indent.c (Fvertical_motion): Local variable it_start is now
8115 * regex.c (re_match, re_match_2, re_match_2_internal)
8116 (bcmp_translate, regcomp, regexec, print_double_string)
8117 (group_in_compile_stack, re_search, re_search_2, regex_compile)
8118 (re_compile_pattern, re_exec): Declare arguments and local
8119 variables `size_t' and `ssize_t' and return values `regoff_t', as
8121 (POP_FAILURE_REG_OR_COUNT) <pfreg>: Declare `long'.
8122 (CHECK_INFINITE_LOOP) <failure>: Declare `ssize_t'.
8123 <compile_stack_type>: `size' and `avail' are now `size_t'.
8125 * regex.h <regoff_t>: Use ssize_t, not int.
8126 (re_search, re_search_2, re_match, re_match_2): Arguments that
8127 specify buffer/string position and length are now ssize_t and
8128 size_t. Return type is regoff_t.
8130 2011-04-16 Ben Key <bkey76@gmail.com>
8132 * nsfont.m: Fixed bugs in ns_get_family and
8133 ns_descriptor_to_entity that were caused by using free to
8134 deallocate memory blocks that were allocated by xmalloc (via
8135 xstrdup). This caused Emacs to crash when compiled with
8136 XMALLOC_OVERRUN_CHECK defined (when Emacs was configured with
8137 --enable-checking=xmallocoverrun). xfree is now used to
8138 deallocate these memory blocks.
8140 2011-04-15 Paul Eggert <eggert@cs.ucla.edu>
8142 * sysdep.c (emacs_read): Remove unnecessary check vs MAX_RW_COUNT.
8144 emacs_write: Accept and return EMACS_INT for sizes.
8145 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html
8147 * gnutls.c, gnutls.h (emacs_gnutls_read, emacs_gnutls_write):
8148 Accept and return EMACS_INT.
8149 (emacs_gnutls_write): Return the number of bytes written on
8151 * sysdep.c, lisp.h (emacs_read, emacs_write): Likewise.
8152 (emacs_read, emacs_write): Remove check for negative size, as the
8153 Emacs source code has been audited now.
8154 * sysdep.c (MAX_RW_COUNT): New macro, to work around kernel bugs.
8155 (emacs_read, emacs_write): Use it.
8156 * process.c (send_process): Adjust to the new signatures of
8157 emacs_write and emacs_gnutls_write. Do not attempt to store
8158 a byte offset into an 'int'; it might overflow.
8159 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00483.html
8161 * sound.c: Don't assume sizes fit in 'int'.
8162 (struct sound_device.period_size, alsa_period_size):
8163 Return EMACS_INT, not int.
8164 (struct sound_device.write, vox_write, alsa_write):
8165 Accept EMACS_INT, not int.
8166 (wav_play, au_play): Use EMACS_INT to store sizes and to
8167 record read return values.
8169 2011-04-15 Ben Key <bkey76@gmail.com>
8171 * keyboard.c (Qundefined): Don't declare static since it is used
8173 * xfaces.c (Qbold, Qexpanded, Qitalic, Qcondensed): Don't declare
8174 static since they are used in nsfont.m.
8176 2011-04-15 Stefan Monnier <monnier@iro.umontreal.ca>
8178 * process.c (Qprocessp): Don't declare static.
8179 * lisp.h (Qprocessp): Declare again.
8181 2011-04-15 Juanma Barranquero <lekktu@gmail.com>
8183 * font.c (Qopentype): Don't make static (used from w32uniscribe.c).
8185 2011-04-14 Paul Eggert <eggert@cs.ucla.edu>
8187 Improve C-level modularity by making more things 'static'.
8189 Don't publish debugger-only interfaces to other modules.
8190 * lisp.h (safe_debug_print, debug_output_compilation_hack):
8191 (verify_bytepos, count_markers): Move decls to the only modules
8193 * region-cache.h (pp_cache): Likewise.
8194 * window.h (check_all_windows): Likewise.
8195 * marker.c, print.c, region-cache.c, window.c: Decls moved here.
8197 * sysdep.c (croak): Now static, if
8198 defined TIOCNOTTY || defined USG5 || defined CYGWIN.
8199 * syssignal.h (croak): Declare only if not static.
8201 * alloc.c (refill_memory_reserve): Now static if
8202 !defined REL_ALLOC || defined SYSTEM_MALLOC.
8203 * lisp.h (refill_memory_reserve): Declare only if not static.
8205 * xsettings.c, xsettings.h (xsettings_get_system_normal_font):
8206 Define only if USE_LUCID.
8208 * xrdb.c (x_customization_string, x_rm_string): Now static.
8210 * xmenu.c (x_menu_wait_for_event): Export only if USE_MOTIF.
8211 * xterm.h (x_menu_wait_for_event): Declare only if USE_MOTIF.
8213 * xdisp.c (draw_row_with_mouse_face): Now static.
8214 * dispextern.h (draw_row_with_mouse_fave): Remove decl.
8216 * window.h (check_all_windows): Mark externally visible.
8218 * window.c (window_deletion_count): Now static.
8220 * undo.c: Make symbols static if they're not exported.
8221 (last_undo_buffer, last_boundary_position, pending_boundary):
8224 * textprop.c (interval_insert_behind_hooks): Now static.
8225 (interval_insert_in_front_hooks): Likewise.
8227 * term.c: Make symbols static if they're not exported.
8228 (tty_turn_off_highlight, get_tty_terminal, max_frame_cols):
8229 (max_frame_lines, tty_set_terminal_modes):
8230 (tty_reset_terminal_modes, tty_turn_off_highlight):
8231 (get_tty_terminal): Now static.
8232 (term_mouse_moveto): Do not define if HAVE_WINDOW_SYSTEM.
8233 * termhooks.h (term_mouse_moveto): Do not declare if
8235 * dispextern.h (tty_set_terminal_modes, tty_reset_terminal_modes):
8236 (tty_turn_off_highlight, get_tty_terminal): Remove decls.
8238 * sysdep.c: Make symbols static if they're not exported.
8239 (emacs_get_tty, emacs_set_tty, old_fcntl_flags, old_fcntl_owner):
8241 (sigprocmask_set, full_mask): Remove; unused.
8242 (wait_debugging): Mark as visible.
8243 * syssignal.h (SIGFULLMASK, full_mask): Remove decls.
8244 * systty.h (emacs_get_tty, emacs_set_tty): Remove decls.
8246 * syntax.c (syntax_temp): Define only if !__GNUC__.
8248 * sound.c (current_sound_device, current_sound): Now static.
8250 * search.c (searchbufs, searchbuf_head): Now static.
8252 * scroll.c (scroll_cost): Remove; unused.
8253 * dispextern.h (scroll_cost): Remove decl.
8255 * region-cache.h (pp_cache): Mark as externally visible.
8257 * process.c: Make symbols static if they're not exported.
8258 (process_tick, update_tick, create_process, chan_process):
8259 (Vprocess_alist, proc_buffered_char, datagram_access):
8260 (fd_callback_data, send_process_frame, process_sent_to): Now static.
8261 (deactivate_process): Mark defn as static, as well as decl.
8262 * lisp.h (create_process): Remove decl.
8263 * process.h (chan_process, Vprocess_alist): Remove decls.
8265 * print.c: Make symbols static if they're not exported.
8266 (print_depth, new_backquote_output, being_printed, print_buffer):
8267 (print_buffer_size, print_buffer_pos, print_buffer_pos_byte):
8268 (print_interval, print_number_index, initial_stderr_stream):
8270 * lisp.h (Fprinc): Remove decl.
8271 (debug_output_compilation_hack): Mark as externally visible.
8273 * sysdep.c (croak): Move decl from here to syssignal.h.
8274 * syssignal.h (croak): Put it here, so the API can be checked when
8275 'croak' is called from dissociate_if_controlling_tty.
8277 * minibuf.c: Make symbols static if they're not exported.
8278 (minibuf_save_list, choose_minibuf_frame): Now static.
8279 * lisp.h (choose_minibuf_frame): Remove decl.
8281 * lisp.h (verify_bytepos, count_markers): Mark as externally visible.
8283 * lread.c: Make symbols static if they're not exported.
8284 (read_objects, initial_obarray, oblookup_last_bucket_number):
8286 (make_symbol): Remove; unused.
8287 * lisp.h (initial_obarray, make_symbol): Remove decls.
8289 * keyboard.c: Make symbols static if they're not exported.
8290 (single_kboard, recent_keys_index, total_keys, recent_keys):
8291 (this_command_key_count_reset, raw_keybuf, raw_keybuf_count):
8292 (this_single_command_key_start, echoing, last_auto_save):
8293 (read_key_sequence_cmd, dribble, recursive_edit_unwind):
8294 (command_loop, echo_now, keyboard_init_hook, help_char_p):
8295 (quit_throw_to_read_char, command_loop_2, top_level_1, poll_timer):
8296 (Vlispy_mouse_stem, double_click_count):
8298 (force_auto_save_soon): Define only if SIGDANGER.
8299 (ignore_mouse_drag_p): Now static if
8300 !defined HAVE_WINDOW_SYSTEM || defined USE_GTK || defined HAVE_NS.
8301 (print_help): Remove; unused.
8302 (stop_character, last_timer_event): Mark as externally visible.
8303 * keyboard.h (ignore_mouse_drag_p): Declare only if
8304 defined HAVE_WINDOW_SYSTEM && !defined USE_GTK && !defined HAVE_NS.
8305 (echo_now, help_char_p, quit_throw_to_read_char): Remove decls.
8306 * lisp.h (echoing): Remove decl.
8307 (force_auto_save_soon): Declare only if SIGDANGER.
8308 * xdisp.c (redisplay_window): Simplify code, to make it more
8309 obvious that ignore_mouse_drag_p is not accessed if !defined
8310 USE_GTK && !defined HAVE_NS.
8312 * intervals.c: Make symbols static if they're not exported.
8313 (merge_properties_sticky, merge_interval_right, delete_interval):
8315 * intervals.h (merge_interval_right, delete_interval): Remove decls.
8317 * insdel.c: Make symbols static if they're not exported.
8318 However, leave prepare_to_modify_buffer alone. It's never
8319 called from outside this function, but that appears to be a bug.
8320 (combine_after_change_list, combine_after_change_buffer):
8321 (adjust_after_replace, signal_before_change): Now static.
8322 (adjust_after_replace_noundo): Remove; unused.
8323 * lisp.h (adjust_after_replace, adjust_after_replace_noundo):
8324 (signal_before_change): Remove decls.
8326 * indent.c (val_compute_motion, val_vmotion): Now static.
8328 * image.c: Make symbols static if they're not exported.
8329 * dispextern.h (x_create_bitmap_from_xpm_data): Do not declare
8331 * image.c (x_create_bitmap_from_xpm_data): Do not define if USE_GTK.
8332 (xpm_color_cache, ct_table, ct_colors_allocated): Now static.
8334 * fringe.c (standard_bitmaps): Now static.
8335 (max_used_fringe_bitmap): Now static, unless HAVE_NS.
8337 * frame.c: Make symbols static if they're not exported.
8338 (x_report_frame_params, make_terminal_frame): Now static.
8339 (get_frame_param): Now static, unless HAVE_NS.
8340 (x_fullscreen_adjust): Define if WINDOWSNT, not if HAVE_WINDOW_SYSTEM.
8341 (x_get_resource_string): Remove; not used.
8342 * frame.h (make_terminal_frame, x_report_frame_params):
8343 (x_get_resource_string); Remove decls.
8344 (x_fullscreen_adjust): Declare only if WINDOWSNT.
8345 * lisp.h (get_frame_param): Declare only if HAVE_NS.
8347 * font.c, fontset.c: Make symbols static if they're not exported.
8348 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): New macro.
8349 (FACE_SUITABLE_FOR_CHAR_P): Use it.
8350 * font.c (font_close_object): Now static.
8351 * font.h (font_close_object): Remove.
8352 * fontset.c (FONTSET_OBJLIST): Remove.
8353 (free_realized_fontset) #if-0 the body, which does nothing.
8354 (face_suitable_for_char_p): #if-0, as it's never called.
8355 * fontset.h (face_suitable_for_char_p): Remove decl.
8356 * xfaces.c (face_at_string_position):
8357 Use FACE_SUITABLE_FOR_ASCII_CHAR_P, not FACE_SUITABLE_FOR_CHAR_P,
8358 since 0 is always ASCII.
8360 * fns.c (weak_hash_tables): Now static.
8362 * fileio.c: Make symbols static if they're not exported.
8363 (auto_saving, auto_save_mode_bits, auto_save_error_occurred):
8364 (Vwrite_region_annotation_buffers): Now static.
8366 * eval.c: Make symbols static if they're not exported.
8367 (backtrace_list, lisp_eval_depth, when_entered_debugger): Now static.
8368 * lisp.h (backtrace_list): Remove decl.
8370 * emacs.c: Make symbols static if they're not exported.
8371 (malloc_state_ptr, malloc_using_checking, syms_of_emacs):
8372 (fatal_error_code, fatal_error_signal_hook, standard_args):
8374 (fatal_error_signal): Now static, unless FLOAT_CATCH_SIGKILL.
8375 (DEFINE_DUMMY_FUNCTION): Mark function as externally visible.
8376 (__CTOR_LIST__, __DTOR_LIST__): Now externally visible.
8377 * lisp.h (fatal_error_signal_hook): Remove decl.
8378 (fatal_error_signal): Declare only if FLOAT_CATCH_SIGKILL.
8380 * editfns.c: Move a (normally-unused) function to its only use.
8381 * editfns.c, lisp.h (get_operating_system_release): Remove.
8382 * process.c (init_process) [DARWIN_OS]: Do it inline, as it is not
8383 worth the hassle of breaking this out.
8385 * xterm.c: Make symbols static if they're not exported.
8386 (x_raise_frame, x_lower_frame, x_wm_set_window_state):
8387 (x_wm_set_icon_pixmap, x_initialize, XTread_socket_fake_io_error):
8388 (x_destroy_window, x_delete_display):
8390 (x_dispatch_event): Now static if ! (USE_MOTIF || USE_X_TOOLKIT).
8391 (x_mouse_leave): Remove; unused.
8392 * xterm.h (x_display_info_for_name, x_raise_frame, x_lower_frame):
8393 (x_destroy_window, x_wm_set_window_state, x_wm_set_icon_pixmap):
8394 (x_delete_display, x_initialize, x_set_border_pixel, x_screen_planes):
8396 (x_mouse_leave): Declare only if WINDOWSNT.
8397 (x_dispatch_event): Declare only if USE_MOTIF or USE_X_TOOLKIT.
8398 (xic_create_fontsetname): Declare only if HAVE_X_WINDOWS &&
8401 * ftxfont.c: Make symbols static if they're not exported.
8402 (ftxfont_driver): Export only if !defined HAVE_XFT && def8ined
8404 * font.h (ftxfont_driver): Likewise.
8406 * xfns.c: Make symbols static if they're not exported.
8407 (x_last_font_name, x_display_info_for_name):
8408 (x_set_foreground_color, x_set_background_color, x_set_mouse_color):
8409 (x_set_cursor_color, x_set_border_pixel, x_set_border_color):
8410 (x_set_cursor_type, x_set_icon_type, x_set_icon_name):
8411 (x_set_scroll_bar_foreground, x_set_scroll_bar_background):
8412 (x_explicitly_set_name, x_set_title, xic_defaut_fontset, tip_timer):
8413 (last_show_tip_args): Now static.
8414 (xic_defaut_fontset, xic_create_fontsetname): Define only if
8415 defined HAVE_X_WINDOWS && defined USE_X_TOOLKIT
8416 (x_screen_planes): Remove; unused.
8417 * dispextern.h (x_screen_planes): Remove decl.
8419 * dispnew.c: Make symbols static if they're not exported.
8420 * dispextern.h (redraw_garbaged_frames, scrolling):
8421 (increment_row_positions): Remove.
8422 * dispnew.c (new_glyph_matrix, increment_row_positions, scrolling):
8423 (delayed_size_change, glyph_matrix_count, glyph_pool_count):
8425 (redraw_garbaged_frames): Remove; unused.
8427 * xfaces.c: Make symbols static if they're not exported.
8428 * dispextern.h (ascii_face_of_lisp_face, free_realized_face):
8430 * xterm.h (defined_color): Remove decls.
8431 (x_free_dpy_colors): Declare only if USE_X_TOOLKIT.
8432 * xfaces.c (tty_suppress_bold_inverse_default_colors_p):
8433 (menu_face_changed_default, defined_color, free_realized_face):
8434 (x_free_dpy_colors): Define only if USE_X_TOOLKIT.
8435 (ascii_face_of_lisp_face): Remove; unused.
8437 * xdisp.c: Make symbols static if they're not exported.
8438 * dispextern.h (scratch_glyph_row, window_box_edges):
8439 (glyph_to_pixel_coords, set_cursor_from_row):
8440 (get_next_display_element, set_iterator_to_next):
8441 (highlight_trailing_whitespace, frame_to_window_pixel_xy):
8442 (show_mouse_face): Remove decls
8443 * frame.h (message_buf_print): Likewise.
8444 * lisp.h (pop_message, set_message, check_point_in_composition):
8446 * xterm.h (set_vertical_scroll_bar): Likewise.
8447 * xdisp.c (list_of_error, Vmessage_stack, line_number_displayed):
8448 (message_buf_print, scratch_glyph_row, displayed_buffer):
8449 (set_iterator_to_next, pop_message, set_message, set_cursor_from_row):
8450 (get_next_display_element, show_mouse_face, window_box_edges):
8451 (frame_to_window_pixel_xy, check_point_in_composition):
8452 (set_vertical_scroll_bar, highlight_trailing_whitespace): Now static.
8453 (glyph_to_pixel_coords): Remove; unused.
8455 * dired.c (file_name_completion): Now static.
8457 * dbusbind.c (xd_in_read_queued_messages): Now static.
8459 * lisp.h (circular_list_error, FOREACH): Remove; unused.
8460 * data.c (circular_list_error): Remove.
8462 * commands.h (last_point_position, last_point_position_buffer):
8463 (last_point_position_window): Remove decls.
8464 * keyboard.c: Make these variables static.
8466 * coding.h (coding, code_convert_region, encode_coding_gap):
8468 * coding.c (Vsjis_coding_system, Vbig5_coding_system):
8469 (iso_code_class, detect_coding, code_convert_region): Now static.
8470 (encode_coding_gap): Remove; unused.
8472 * chartab.c (chartab_chars, chartab_bits): Now static.
8474 * charset.h (charset_iso_8859_1): Remove decl.
8475 * charset.c (charset_iso_8859_1, charset_emacs, map_charset_for_dump):
8478 * ccl.h (check_ccl_update, Vccl_program_table): Remove decls.
8479 * ccl.c (Vccl_program_table): Now static.
8480 (check_ccl_update): Remove; unused.
8482 * category.c (SET_CATEGORY_SET, set_category_set): Move here.
8483 * category.h: ... from here.
8484 * category.c (check_category_table, set_category_set): Now static.
8486 * casetab.c (Vascii_upcase_table, Vascii_eqv_table): Now static.
8487 * lisp.h: Remove these decls.
8489 * buffer.c (buffer_count): Remove unused var.
8491 * bidi.c (bidi_dump_cached_states): Mark as externally visible,
8492 so that it's not optimized away.
8493 (bidi_ignore_explicit_marks_for_paragraph_level): Likewise.
8494 * dispextern.h (bidi_dump_cached_states): Remove, since it's
8495 exported only to the debugger.
8497 * atimer.c (alarm_signal_handler, run_all_atimers): Now static.
8498 * atimer.h (run_all_atimers): Remove; not exported.
8500 font.c: Make copy_font_spec and merge_font_spec ordinary C functions.
8501 * font.c (copy_font_spec): Rename from Fcopy_font_spec, since it
8502 was inaccessible from Lisp.
8503 (merge_font_spec): Likewise, renaming from Fmerge_font_spec.
8504 * font.c, font.h, fontset.c, xfaces.c, xfont.c: Change all uses.
8506 alloc.c: Import and export fewer symbols, and remove unused items.
8507 * lisp.h (suppress_checking, die): Declare only if ENABLE_CHECKING
8509 (suppress_checking): Add EXTERNALLY_VISIBLE attribute, so that
8510 it's not optimized away by whole-program optimization.
8511 (message_enable_multibyte, free_misc): Remove.
8512 (catchlist, handlerlist, mark_backtrace):
8513 Declare only if BYTE_MARK_STACK.
8514 (mark_byte_stack): Likewise, fixing a ifdef-vs-if typo.
8515 * alloc.c (pure): Export only if VIRT_ADDR_VARIES is defined.
8516 (message_enable_multibyte): Remove decl.
8517 (free_misc, interval_free_list, float_block, float_block_index):
8518 (n_float_blocks, float_free_list, cons_block, cons_block_index):
8519 (cons_free_list, last_marked_index):
8521 (suppress_checking, die): Define only if ENABLE_CHECKING is defined.
8522 * eval.c (catchlist, handlerlist): Export only if BYTE_MARK_STACK.
8523 (mark_backtrace): Define only if BYTE_MARK_STACK.
8524 * xdisp.c (message_enable_multibyte): Now static.
8526 Declare Lisp_Object Q* variables to be 'static' if not exported.
8527 This makes it easier for human readers (and static analyzers)
8528 to see whether these variables are used from other modules.
8529 * alloc.c, buffer.c, bytecode.c, callint.c, casetab.c, category.c:
8530 * ccl.c, character.c, charset.c, cmds.c, coding.c, composite.c:
8531 * data.c, dbusbind.c, dired.c, editfns.c, eval.c, fileio.c, fns.c:
8532 * font.c, frame.c, fringe.c, ftfont.c, image.c, keyboard.c, keymap.c:
8533 * lread.c, macros.c, minibuf.c, print.c, process.c, search.c:
8534 * sound.c, syntax.c, textprop.c, window.c, xdisp.c, xfaces.c, xfns.c:
8535 * xmenu.c, xselect.c:
8536 Declare Q* vars static if they are not used in other modules.
8537 * ccl.h, character.h, charset.h, coding.h, composite.h, font.h:
8538 * frame.h, intervals.h, keyboard.h, lisp.h, process.h, syntax.h:
8539 Remove decls of unexported vars.
8540 * keyboard.h (EVENT_HEAD_UNMODIFIED): Remove now-unused macro.
8542 * lisp.h (DEFINE_FUNC): Make sname 'static'.
8544 Make Emacs functions such as Fatom 'static' by default.
8545 This makes it easier for human readers (and static analyzers)
8546 to see whether these functions can be called from other modules.
8547 DEFUN now defines a static function. To make the function external
8548 so that it can be used in other C modules, use the new macro DEFUE.
8549 * lisp.h (Funibyte_char_to_multibyte, Fsyntax_table_p):
8550 (Finit_image_library):
8551 (Feval_region, Fbacktrace, Ffetch_bytecode, Fswitch_to_buffer):
8552 (Ffile_executable_p, Fmake_symbolic_link, Fcommand_execute):
8553 (Fget_process, Fdocumentation_property, Fbyte_code, Ffile_attributes):
8554 Remove decls, since these functions are now static.
8555 (Funintern, Fget_internal_run_time): New decls, since these functions
8556 were already external.
8558 * alloc.c, buffer.c, callint.c, callproc.c, casefiddle.c, casetab.c:
8559 * ccl.c, character.c, chartab.c, cmds.c, coding.c, data.c, dispnew.c:
8560 * doc.c, editfns.c, emacs.c, eval.c, fileio.c, filelock.c, floatfns.c:
8561 * fns.c, font.c, fontset.c, frame.c, image.c, indent.c:
8562 * keyboard.c, keymap.c, lread.c:
8563 * macros.c, marker.c, menu.c, minibuf.c, print.c, process.c, search.c:
8564 * syntax.c, term.c, terminal.c, textprop.c, undo.c:
8565 * window.c, xdisp.c, xfaces.c, xfns.c, xmenu.c, xsettings.c:
8566 Mark functions with DEFUE instead of DEFUN,
8567 if they are used in other modules.
8568 * buffer.c (Fset_buffer_major_mode, Fdelete_overlay): New forward
8569 decls for now-static functions.
8570 * buffer.h (Fdelete_overlay): Remove decl.
8571 * callproc.c (Fgetenv_internal): Mark as internal.
8572 * composite.c (Fremove_list_of_text_properties): Remove decl.
8573 (Fcomposition_get_gstring): New forward static decl.
8574 * composite.h (Fcomposite_get_gstring): Remove decl.
8575 * dired.c (Ffile_attributes): New forward static decl.
8576 * doc.c (Fdocumntation_property): New forward static decl.
8577 * eval.c (Ffetch_bytecode): New forward static decl.
8578 (Funintern): Remove extern decl; now in .h file where it belongs.
8579 * fileio.c (Fmake_symbolic_link): New forward static decl.
8580 * image.c (Finit_image_library): New forward static decl.
8581 * insdel.c (Fcombine_after_change_execute): Make forward decl static.
8582 * intervals.h (Fprevious_property_change):
8583 (Fremove_list_of_text_properties): Remove decls.
8584 * keyboard.c (Fthis_command_keys): Remove decl.
8585 (Fcommand_execute): New forward static decl.
8586 * keymap.c (Flookup_key): New forward static decl.
8587 (Fcopy_keymap): Now static.
8588 * keymap.h (Flookup_key): Remove decl.
8589 * process.c (Fget_process): New forward static decl.
8590 (Fprocess_datagram_address): Mark as internal.
8591 * syntax.c (Fsyntax_table_p): New forward static decl.
8592 (skip_chars): Remove duplicate decl.
8593 * textprop.c (Fprevious_property_change): New forward static decl.
8594 * window.c (Fset_window_fringes, Fset_window_scroll_bars):
8596 (Fset_window_margins, Fset_window_vscroll): New forward static decls.
8597 * window.h (Fset_window_vscroll, Fset_window_margins): Remove decls.
8599 * editfns.c (Fformat): Remove unreachable code.
8601 2011-04-14 Andreas Schwab <schwab@linux-m68k.org>
8603 * fileio.c (Finsert_file_contents): Fix typo in 2005-05-13
8606 2011-04-13 Eli Zaretskii <eliz@gnu.org>
8608 * xdisp.c (handle_invisible_prop): Don't call bidi_paragraph_init
8609 when at ZV. (Bug#8487)
8611 2011-04-12 Andreas Schwab <schwab@linux-m68k.org>
8613 * charset.c (Fclear_charset_maps): Use xfree instead of free.
8615 * keyboard.c (parse_tool_bar_item): Likewise.
8616 * sound.c (sound_cleanup, alsa_close): Likewise.
8617 * termcap.c (tgetent): Likewise.
8618 * xfns.c (x_default_font_parameter): Likewise.
8619 * xsettings.c (read_and_apply_settings): Likewise.
8621 * alloc.c (overrun_check_malloc, overrun_check_realloc)
8622 (overrun_check_free): Protoize.
8624 2011-04-12 Paul Eggert <eggert@cs.ucla.edu>
8626 * sysdep.c (emacs_read, emacs_write): Check for negative sizes
8627 since callers should never pass a negative size.
8628 Change the signature to match that of plain 'read' and 'write'; see
8629 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00397.html>.
8630 * lisp.h: Update prototypes of emacs_write and emacs_read.
8632 2011-04-11 Eli Zaretskii <eliz@gnu.org>
8634 * xdisp.c (redisplay_window): Don't try to determine the character
8635 position of the scroll margin if the window start point w->startp
8636 is outside the buffer's accessible region. (Bug#8468)
8638 2011-04-10 Eli Zaretskii <eliz@gnu.org>
8640 Fix write-region and its subroutines for buffers > 2GB.
8641 * fileio.c (a_write, e_write): Modify declaration of arguments and
8642 local variables to support buffers larger than 2GB.
8643 (Fcopy_file): Use EMACS_INT for return value of emacs_read.
8645 * sysdep.c (emacs_write, emacs_read): Use ssize_t for last
8646 argument, local variables, and return value.
8648 * lisp.h: Update prototypes of emacs_write and emacs_read.
8650 * sound.c (vox_write): Use ssize_t for return value of emacs_write.
8652 2011-04-10 Paul Eggert <eggert@cs.ucla.edu>
8654 * xdisp.c (vmessage): Use memchr, not strnlen, which some hosts lack.
8656 Fix more problems found by GCC 4.6.0's static checks.
8658 * xdisp.c (vmessage): Use a better test for character truncation.
8660 * charset.c (load_charset_map): <, not <=, for optimization,
8661 and to avoid potential problems with integer overflow.
8662 * chartab.c (sub_char_table_set_range, char_table_set_range): Likewise.
8663 * casetab.c (set_identity, shuffle): Likewise.
8664 * editfns.c (Fformat): Likewise.
8665 * syntax.c (skip_chars): Likewise.
8667 * xmenu.c (set_frame_menubar): Allocate smaller local vectors.
8668 This also lets GCC 4.6.0 generate slightly better loop code.
8670 * callint.c (Fcall_interactively): <, not <=, for optimization.
8671 (Fcall_interactively): Count the number of arguments produced,
8672 not the number of arguments given. This is simpler and lets GCC
8673 4.6.0 generate slightly better code.
8675 * ftfont.c: Distingish more carefully between FcChar8 and char.
8676 The previous code passed unsigned char * to a functions like
8677 strlen and xstrcasecmp that expect char *, which does not
8678 conform to the C standard.
8679 (get_adstyle_property, ftfont_pattern_entity): Use FcChar8 for
8680 arguments to FcPatternGetString, and explicitly cast FcChar8 * to
8681 char * when the C standard requires it.
8683 * keyboard.c (read_char): Remove unused var.
8685 * eval.c: Port to Windows vsnprintf (Bug#8435).
8687 (SIZE_MAX): Define if the headers do not.
8688 (verror): Do not give up if vsnprintf returns a negative count.
8689 Instead, grow the buffer. This ports to Windows vsnprintf, which
8690 does not conform to C99. Problem reported by Eli Zaretskii.
8691 Also, simplify the allocation scheme, by avoiding the need for
8692 calling realloc, and removing the ALLOCATED variable.
8694 * eval.c (verror): Initial buffer size is 4000 (not 200) bytes.
8696 Remove invocations of doprnt, as Emacs now uses vsnprintf.
8697 But keep the doprint source code for now, as we might revamp it
8698 and use it again (Bug#8435).
8699 * lisp.h (doprnt): Remove.
8700 * Makefile.in (base_obj): Remove doprnt.o.
8701 * deps.mk (doprnt.o): Remove.
8703 error: Print 32- and 64-bit integers portably (Bug#8435).
8704 Without this change, on typical 64-bit hosts error ("...%d...", N)
8705 was used to print both 32- and 64-bit integers N, which relied on
8707 * lisp.h, m/amdx86-64.h, m/ia64.h, m/ibms390x.h (pEd): New macro.
8708 * lisp.h (error, verror): Mark as printf-like functions.
8709 * eval.c (verror): Use vsnprintf, not doprnt, to do the real work.
8710 Report overflow in size calculations when allocating printf buffer.
8711 Do not truncate output string at its first null byte.
8712 * xdisp.c (vmessage): Use vsnprintf, not doprnt, to do the real work.
8713 Truncate the output at a character boundary, since vsnprintf does not
8715 * charset.c (check_iso_charset_parameter): Convert internal
8716 character to string before calling 'error', since %c now has the
8718 * coding.c (Fdecode_sjis_char, Fdecode_big5_char): Avoid int
8719 overflow when computing char to be passed to 'error'. Do not
8720 pass Lisp_Object to 'error'; pass the integer instead.
8721 * nsfns.m (Fns_do_applescript): Use int, not long, since it's
8722 formatted with plain %d.
8724 * eval.c (internal_lisp_condition_case): Don't pass spurious arg.
8726 * keyboard.c (access_keymap_keyremap): Print func name, not garbage.
8728 * coding.c (Fdecode_sjis_char): Don't assume CODE fits in int.
8730 * xterm.c (x_catch_errors): Remove duplicate declaration.
8732 * term.c (maybe_fatal): Mark its 3rd arg as a printf format, too.
8734 * xdisp.c, lisp.h (message_nolog): Remove; unused.
8736 2011-04-10 Jim Meyering <meyering@redhat.com>
8738 use ssize_t and size_t for read- and write-like emacs_gnutls_* functions
8739 * gnutls.c (emacs_gnutls_read): Adjust signature to be more read-like:
8740 return ssize_t not "int", and use size_t as the buffer length.
8741 (emacs_gnutls_write): Likewise, and make the buffer pointer "const".
8742 * gnutls.h: Update declarations.
8743 * process.c (read_process_output): Use ssize_t, to match.
8744 (send_process): Likewise.
8746 2011-04-09 Chong Yidong <cyd@stupidchicken.com>
8748 * image.c (Fimagemagick_types): Doc fix, and comment cleanup.
8750 2011-04-09 Chong Yidong <cyd@stupidchicken.com>
8752 * ftfont.c (get_adstyle_property, ftfont_pattern_entity):
8753 Use unsigned char, to match FcChar8 type definition.
8755 * xterm.c (handle_one_xevent):
8756 * xmenu.c (create_and_show_popup_menu):
8757 * xselect.c (x_decline_selection_request)
8758 (x_reply_selection_request): Avoid type-punned deref of X events.
8760 2011-04-09 Eli Zaretskii <eliz@gnu.org>
8762 Fix some uses of `int' instead of EMACS_INT.
8763 * search.c (string_match_1, fast_string_match)
8764 (fast_c_string_match_ignore_case, fast_string_match_ignore_case)
8765 (scan_buffer, find_next_newline_no_quit)
8766 (find_before_next_newline, search_command, Freplace_match)
8767 (Fmatch_data): Make some `int' variables be EMACS_INT.
8769 * xdisp.c (display_count_lines): 3rd argument and return value now
8770 EMACS_INT. All callers changed.
8771 (pint2hrstr): Last argument is now EMACS_INT.
8773 * coding.c (detect_coding_utf_8, detect_coding_emacs_mule)
8774 (detect_coding_iso_2022, detect_coding_sjis, detect_coding_big5)
8775 (detect_coding_ccl, detect_coding_charset, decode_coding_utf_8)
8776 (decode_coding_utf_16, decode_coding_emacs_mule)
8777 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5)
8778 (decode_coding_ccl, decode_coding_charset)
8779 <consumed_chars, consumed_chars_base>: Declare EMACS_INT.
8780 (decode_coding_iso_2022, decode_coding_emacs_mule)
8781 (decode_coding_sjis, decode_coding_big5, decode_coding_charset)
8782 <char_offset, last_offset>: Declare EMACS_INT.
8783 (encode_coding_utf_8, encode_coding_utf_16)
8784 (encode_coding_emacs_mule, encode_invocation_designation)
8785 (encode_designation_at_bol, encode_coding_iso_2022)
8786 (encode_coding_sjis, encode_coding_big5, encode_coding_ccl)
8787 (encode_coding_raw_text, encode_coding_charset) <produced_chars>:
8789 (ASSURE_DESTINATION): Declare more_bytes EMACS_INT.
8790 (encode_invocation_designation): Last argument P_NCHARS is now
8792 (decode_eol): Declare pos_byte, pos, and pos_end EMACS_INT.
8793 (produce_chars): from_nchars and to_nchars are now EMACS_INT.
8795 * coding.h (struct coding_system) <head_ascii>: Declare EMACS_INT.
8798 * ccl.c (Fccl_execute_on_string): Declare some variables
8801 2011-04-08 Samuel Thibault <sthibault@debian.org> (tiny change)
8803 * term.c (init_tty): Fix incorrect ifdef placement (Bug#8450).
8805 2011-03-19 Christoph Scholtes <cschol2112@googlemail.com>
8807 * process.c (Fformat_network_address): Doc fix.
8809 2011-04-08 T.V. Raman <tv.raman.tv@gmail.com> (tiny change)
8811 * xml.c (parse_region): Avoid creating spurious whitespace nodes.
8813 2011-04-08 Chong Yidong <cyd@stupidchicken.com>
8815 * keyboard.c (read_char): Call Lisp function help-form-show,
8816 instead of using internal_with_output_to_temp_buffer.
8817 (Qhelp_form_show): New var.
8818 (syms_of_keyboard): Use DEFSYM macro.
8820 * print.c (internal_with_output_to_temp_buffer): Function deleted.
8822 * lisp.h (internal_with_output_to_temp_buffer): Remove prototype.
8824 2011-04-06 Chong Yidong <cyd@stupidchicken.com>
8826 * process.c (Flist_processes): Remove to Lisp.
8827 (list_processes_1): Delete.
8829 2011-04-06 Eli Zaretskii <eliz@gnu.org>
8831 * msdos.c (careadlinkat, careadlinkatcwd): MS-DOS replacements.
8833 * w32.c (careadlinkat, careadlinkatcwd): New always-fail stubs.
8835 2011-04-06 Paul Eggert <eggert@cs.ucla.edu>
8837 Fix more problems found by GCC 4.6.0's static checks.
8839 * xmenu.c (Fx_popup_dialog): Don't assume string is free of formats.
8841 * menu.c (Fx_popup_menu): Don't assume error_name lacks printf formats.
8843 * lisp.h (message, message_nolog, fatal): Mark as printf-like.
8845 * xdisp.c (vmessage): Mark as a printf-like function.
8847 * term.c (vfatal, maybe_fatal): Mark as printf-like functions.
8849 * sound.c (sound_warning): Don't crash if arg contains a printf format.
8851 * image.c (tiff_error_handler, tiff_warning_handler): Mark as
8852 printf-like functions.
8853 (tiff_load): Add casts to remove these marks before passing them
8854 to system-supplied API.
8856 * eval.c (Fsignal): Remove excess argument to 'fatal'.
8858 * coding.c (EMIT_ONE_BYTE, EMIT_TWO_BYTES): Use unsigned, not int.
8859 This avoids several warnings with gcc -Wstrict-overflow.
8860 (DECODE_COMPOSITION_RULE): If the rule is invalid, goto invalid_code
8861 directly, rather than having caller test rule sign. This avoids
8862 some unnecessary tests.
8863 * composite.h (COMPOSITION_ENCODE_RULE_VALID): New macro.
8864 (COMPOSITION_ENCODE_RULE): Arguments now must be valid. This
8865 affects only one use, in DECODE_COMPOSITION_RULE, which is changed.
8867 * xfont.c (xfont_text_extents): Remove var that was set but not used.
8868 (xfont_open): Avoid unnecessary tests.
8870 * composite.c (composition_gstring_put_cache): Use unsigned integer.
8872 * composite.h, composite.c (composition_gstring_put_cache):
8873 Use EMACS_INT, not int, for length.
8875 * composite.h (COMPOSITION_DECODE_REFS): New macro,
8876 breaking out part of COMPOSITION_DECODE_RULE.
8877 (COMPOSITION_DECODE_RULE): Use it.
8878 * composite.c (get_composition_id): Remove unused local vars,
8879 by using the new macro.
8881 * textprop.c (set_text_properties_1): Change while to do-while,
8882 since the condition is always true at first.
8884 * intervals.c (graft_intervals_into_buffer): Mark var as used.
8885 (interval_deletion_adjustment): Return unsigned value.
8888 * process.c (list_processes_1, create_pty, read_process_output):
8889 (exec_sentinel): Remove vars that were set but not used.
8890 (create_pty): Remove unnecessary "volatile"s.
8891 (Fnetwork_interface_info): Avoid possibility of int overflow.
8892 (read_process_output): Do adaptive read buffering even if carryover.
8893 (read_process_output): Simplify nbytes computation if buffered.
8895 * bytecode.c (exec_byte_code): Rename local to avoid shadowing.
8897 * syntax.c (scan_words): Remove var that was set but not used.
8898 (update_syntax_table): Use unsigned instead of int.
8900 * lread.c (lisp_file_lexically_bound_p): Use ints rather than endptrs.
8901 (lisp_file_lexically_bound_p, read1): Use unsigned instead of int.
8902 (safe_to_load_p): Make the end-of-loop test the inverse of the in-loop.
8904 * print.c (print_error_message): Avoid int overflow.
8906 * font.c (font_list_entities): Redo for clarity,
8907 so that reader need not know FONT_DPI_INDEX + 1 == FONT_SPACING_INDEX.
8909 * font.c (font_find_for_lface, Ffont_get_glyphs): Remove unused vars.
8910 (font_score): Avoid potential overflow in diff calculation.
8912 * fns.c (substring_both): Remove var that is set but not used.
8913 (sxhash): Redo loop for clarity and to avoid wraparound warning.
8915 * eval.c (funcall_lambda): Rename local to avoid shadowing.
8917 * alloc.c (mark_object_loop_halt, mark_object): Use size_t, not int.
8918 Otherwise, GCC 4.6.0 optimizes the loop check away since the check
8919 can always succeed if overflow has undefined behavior.
8921 * search.c (boyer_moore, wordify): Remove vars set but not used.
8922 (wordify): Omit three unnecessary tests.
8924 * indent.c (MULTIBYTE_BYTES_WIDTH): Don't compute wide_column.
8925 All callers changed. This avoids the need for an unused var.
8927 * casefiddle.c (casify_region): Remove var that is set but not used.
8929 * dired.c (file_name_completion): Remove var that is set but not used.
8931 * fileio.c (Finsert_file_contents): Make EOF condition clearer.
8933 * fileio.c (Finsert_file_contents): Avoid signed integer overflow.
8934 (Finsert_file_contents): Remove unnecessary code checking fd.
8936 * minibuf.c (read_minibuf_noninteractive): Use size_t for sizes.
8937 Check for integer overflow on size calculations.
8939 * buffer.c (Fprevious_overlay_change): Remove var that is set
8942 * keyboard.c (menu_bar_items, read_char_minibuf_menu_prompt):
8943 Remove vars that are set but not used.
8944 (timer_check_2): Don't assume timer-list and idle-timer-list are lists.
8945 (timer_check_2): Mark vars as initialized.
8947 * gtkutil.c (xg_get_file_with_chooser): Mark var as initialized.
8949 * image.c (lookup_image): Remove var that is set but not used.
8950 (xbm_load): Use parse_p, for gcc -Werror=unused-but-set-variable.
8952 * fontset.c (Finternal_char_font, Ffontset_info): Remove vars
8953 that are set but not used.
8955 * xfns.c (make_invisible_cursor): Don't return garbage
8956 if XCreateBitmapFromData fails (Bug#8410).
8958 * xselect.c (x_get_local_selection, x_handle_property_notify):
8959 Remove vars that are set but not used.
8961 * xfns.c (x_create_tip_frame): Remove var that is set but not used.
8962 (make_invisible_cursor): Initialize a possibly-uninitialized variable.
8964 * xterm.c (x_scroll_bar_to_input_event) [!USE_GTK]:
8965 Remove var that is set but not used.
8966 (scroll_bar_windows_size): Now size_t, not int.
8967 (x_send_scroll_bar_event): Use size_t, not int, for sizes.
8970 * xfaces.c (realize_named_face): Remove vars that are set but not used.
8971 (map_tty_color) [!defined MSDOS]: Likewise.
8973 * term.c (tty_write_glyphs): Use size_t; this avoids overflow warning.
8975 * coding.c: Remove vars that are set but not used.
8976 (DECODE_COMPOSITION_RULE): Remove 2nd arg, which is unused.
8977 All callers changed.
8978 (decode_coding_utf_8, decode_coding_utf_16 decode_coding_emacs_mule):
8979 (decode_coding_iso_2022, encode_coding_sjis, encode_coding_big5):
8980 (decode_coding_charset): Remove vars that are set but not used.
8982 * bytecode.c (Fbyte_code) [!defined BYTE_CODE_SAFE]: Remove var
8983 that is set but not used.
8985 * print.c (print_object): Remove var that is set but not used.
8987 Replace 2 copies of readlink code with 1 gnulib version (Bug#8401).
8988 The gnulib version avoids calling malloc in the usual case,
8989 and on 64-bit hosts doesn't have some arbitrary 32-bit limits.
8990 * fileio.c (Ffile_symlink_p): Use emacs_readlink.
8991 * filelock.c (current_lock_owner): Likewise.
8992 * lisp.h (READLINK_BUFSIZE, emacs_readlink): New function.
8993 * sysdep.c: Include allocator.h, careadlinkat.h.
8994 (emacs_no_realloc_allocator): New static constant.
8995 (emacs_readlink): New function.
8996 * deps.mk (sysdep.o): Depend on ../lib/allocator.h and on
8997 ../lib/careadlinkat.h.
8999 2011-04-04 Stefan Monnier <monnier@iro.umontreal.ca>
9001 * keyboard.c (safe_run_hook_funcall): Fix last change (don't stop at the
9002 first non-nil return value).
9004 2011-04-03 Jan Djärv <jan.h.d@swipnet.se>
9006 * nsterm.m (ns_update_auto_hide_menu_bar): Define MAC_OS_X_VERSION_10_6
9007 if not defined (Bug#8403).
9009 2011-04-02 Juanma Barranquero <lekktu@gmail.com>
9011 * xdisp.c (display_count_lines): Remove parameter `start',
9012 unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
9013 (get_char_face_and_encoding): Remove parameter `multibyte_p',
9014 unused since 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
9015 (fill_stretch_glyph_string): Remove parameters `row' and `area',
9016 unused at least since Kim's GUI unification at 2003-03-16T20:45:46Z!storm@cua.dk
9017 and thereabouts. All callers changed.
9018 (get_per_char_metric): Remove parameter `f', unused since
9019 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
9021 2011-04-02 Jim Meyering <meyering@redhat.com>
9023 do not dereference NULL upon failed strdup
9024 * nsfont.m (ns_descriptor_to_entity): Use xstrdup, not strdup.
9025 (ns_get_family): Likewise.
9027 2011-04-02 Juanma Barranquero <lekktu@gmail.com>
9029 * eval.c (unwind_to_catch) [DEBUG_GCPRO]: Remove redundant assignment.
9031 2011-04-02 Jan Djärv <jan.h.d@swipnet.se>
9033 * nsterm.m (ns_update_auto_hide_menu_bar): Only for OSX 10.6 or
9036 2011-04-01 Stefan Monnier <monnier@iro.umontreal.ca>
9038 Add lexical binding.
9040 * window.c (Ftemp_output_buffer_show): New fun.
9041 (Fsave_window_excursion):
9042 * print.c (Fwith_output_to_temp_buffer): Move to subr.el.
9044 * lread.c (lisp_file_lexically_bound_p): New function.
9045 (Fload): Bind Qlexical_binding.
9046 (readevalloop): Remove `evalfun' arg.
9047 Bind Qinternal_interpreter_environment.
9048 (Feval_buffer): Bind Qlexical_binding.
9049 (defvar_int, defvar_bool, defvar_lisp_nopro, defvar_kboard):
9051 (syms_of_lread): Declare `lexical-binding'.
9053 * lisp.h (struct Lisp_Symbol): New field `declared_special'.
9055 * keyboard.c (eval_dyn): New fun.
9056 (menu_item_eval_property): Use it.
9058 * image.c (parse_image_spec): Use Ffunctionp.
9060 * fns.c (concat, mapcar1): Accept byte-code-functions.
9062 * eval.c (Fsetq): Handle lexical vars.
9063 (Fdefun, Fdefmacro, Ffunction): Make closures when needed.
9064 (Fdefconst, Fdefvaralias, Fdefvar): Mark as dynamic.
9065 (FletX, Flet): Obey lexical binding.
9066 (Fcommandp): Handle closures.
9067 (Feval): New `lexical' arg.
9068 (eval_sub): New function extracted from Feval. Use it almost
9069 everywhere where Feval was used. Look up vars in lexical env.
9071 (Ffunctionp): Move from subr.el.
9072 (Ffuncall): Handle closures.
9073 (apply_lambda): Remove `eval_flags'.
9074 (funcall_lambda): Handle closures and new byte-code-functions.
9075 (Fspecial_variable_p): New function.
9076 (syms_of_eval): Initialize the Vinternal_interpreter_environment var,
9077 but without exporting it to Lisp.
9079 * doc.c (Fdocumentation, store_function_docstring):
9080 * data.c (Finteractive_form): Handle closures.
9082 * callint.c (Fcall_interactively): Preserve lexical-binding mode for
9085 * bytecode.c (Bstack_ref, Bstack_set, Bstack_set2, BdiscardN):
9087 (exec_byte_code): New function extracted from Fbyte_code to handle new
9088 calling convention for byte-code-functions. Add new byte-codes.
9090 * buffer.c (defvar_per_buffer): Set new `declared_special' field.
9092 * alloc.c (Fmake_symbol): Init new `declared_special' field.
9094 2011-03-31 Juanma Barranquero <lekktu@gmail.com>
9096 * xdisp.c (redisplay_internal): Fix prototype.
9098 2011-03-31 Eli Zaretskii <eliz@gnu.org>
9100 * xdisp.c (SCROLL_LIMIT): New macro.
9101 (try_scrolling): Use it when setting scroll_limit.
9102 Limit scrolling to 100 screen lines.
9103 (redisplay_window): Even when falling back on "recentering",
9104 position point in the window according to scroll-conservatively,
9105 scroll-margin, and scroll-*-aggressively variables. (Bug#6671)
9107 (try_scrolling): When point is above the window, allow searching
9108 as far as scroll_max, or one screenful, to compute vertical
9109 distance from PT to the scroll margin position. This prevents
9110 try_scrolling from unnecessarily failing when
9111 scroll-conservatively is set to a value slightly larger than the
9112 window height. Clean up the case of PT below the margin at bottom
9113 of window: scroll_max can no longer be INT_MAX. When aggressive
9114 scrolling is in use, don't let point enter the opposite scroll
9115 margin as result of the scroll.
9116 (syms_of_xdisp) <scroll-conservatively>: Document the
9117 threshold of 100 lines for never-recentering scrolling.
9119 2011-03-31 Juanma Barranquero <lekktu@gmail.com>
9121 * dispextern.h (move_it_by_lines):
9122 * xdisp.c (move_it_by_lines): Remove parameter `need_y_p', unused
9123 since 2000-12-29T14:24:09Z!gerd@gnu.org. All callers changed.
9124 (message_log_check_duplicate): Remove parameters `prev_bol' and
9125 `this_bol', unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
9126 (redisplay_internal): Remove parameter `preserve_echo_area',
9127 unused since 1999-07-21T21:43:52Z!gerd@gnu.org. All callers changed.
9129 * indent.c (Fvertical_motion):
9130 * window.c (window_scroll_pixel_based, Frecenter):
9131 Don't pass `need_y_p' to `move_it_by_lines'.
9133 2011-03-30 Stefan Monnier <monnier@iro.umontreal.ca>
9135 * eval.c (struct backtrace): Don't cheat with negative numbers, but do
9136 steal a few bits to be more compact.
9137 (interactive_p, Fbacktrace, Fbacktrace_frame, mark_backtrace):
9138 Remove unneeded casts.
9140 * bytecode.c (Fbyte_code): CAR and CDR can GC.
9142 2011-03-30 Zachary Kanfer <zkanfer@gmail.com> (tiny change)
9144 * keyboard.c (Fexecute_extended_command): Do log the "suggest key
9145 binding" message (bug#7967).
9147 2011-03-30 Paul Eggert <eggert@cs.ucla.edu>
9149 Fix more problems found by GCC 4.6.0's static checks.
9151 * unexelf.c (unexec) [! (defined _SYSTYPE_SYSV || defined __sgi)]:
9152 Remove unused local var.
9154 * editfns.c (Fmessage_box): Remove unused local var.
9156 * xdisp.c (try_window_reusing_current_matrix, x_produce_glyphs):
9157 (note_mode_line_or_margin_highlight, note_mouse_highlight):
9158 Omit unused local vars.
9159 * window.c (shrink_windows): Omit unused local var.
9160 * menu.c (digest_single_submenu): Omit unused local var.
9161 * dispnew.c (update_window) [PERIODIC_PREEMPTION_CHECKING]:
9162 Omit unused local var.
9164 * keyboard.c (parse_modifiers_uncached, parse_modifiers):
9165 Don't assume string length fits in int.
9166 (keyremap_step, read_key_sequence): Use size_t for sizes.
9167 (read_key_sequence): Don't check last_real_key_start redundantly.
9169 * callproc.c (Fcall_process, Fcall_process_region): Use SAFE_ALLOCA
9170 instead of alloca (Bug#8344).
9172 * eval.c (Fbacktrace): Don't assume nargs fits in int.
9173 (Fbacktrace_frame): Don't assume nframes fits in int.
9175 * syntax.c (scan_sexps_forward): Avoid pointer wraparound.
9177 * xterm.c (x_make_frame_visible, same_x_server): Redo to avoid overflow
9180 * term.c (produce_glyphless_glyph): Remove unnecessary test.
9182 * cm.c (calccost): Turn while-do into do-while, for clarity.
9184 * keyboard.c (syms_of_keyboard): Use the same style as later
9185 in this function when indexing through an array. This also
9186 works around GCC bug 48267.
9188 * image.c (tiff_load): Fix off-by-one image count (Bug#8336).
9190 * xselect.c (x_check_property_data): Return correct size (Bug#8335).
9192 * chartab.c (sub_char_table_ref_and_range): Redo for slight
9193 efficiency gain, and to bypass a gcc -Wstrict-overflow warning.
9195 * keyboard.c, keyboard.h (num_input_events): Now size_t.
9196 This avoids undefined behavior on integer overflow, and is a bit
9197 more convenient anyway since it is compared to a size_t variable.
9199 Variadic C functions now count arguments with size_t, not int.
9200 This avoids an unnecessary limitation on 64-bit machines, which
9201 caused (substring ...) to crash on large vectors (Bug#8344).
9202 * lisp.h (struct Lisp_Subr.function.aMANY): Now takes size_t, not int.
9203 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call): Likewise.
9204 All variadic functions and their callers changed accordingly.
9205 (struct gcpro.nvars): Now size_t, not int. All uses changed.
9206 * data.c (arith_driver, float_arith_driver): Likewise.
9207 * editfns.c (general_insert_function): Likewise.
9208 * eval.c (struct backtrace.nargs, interactive_p)
9209 (internal_condition_case_n, run_hook_with_args, apply_lambda)
9210 (funcall_lambda, mark_backtrace): Likewise.
9211 * fns.c (concat): Likewise.
9212 * frame.c (x_set_frame_parameters): Likewise.
9213 * fns.c (get_key_arg): Now accepts and returns size_t, and returns
9214 0 if not found, not -1. All callers changed.
9216 * alloc.c (garbage_collect): Don't assume stack size fits in int.
9217 (stack_copy_size): Now size_t, not int.
9218 (stack_copy, stack_copy_size): Define only if MAX_SAVE_STACK > 0.
9220 2011-03-28 Juanma Barranquero <lekktu@gmail.com>
9222 * coding.c (encode_designation_at_bol): Remove parameter `charbuf_end',
9223 unused since 2002-03-01T01:17:24Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
9224 All callers changed.
9226 * lisp.h (multibyte_char_to_unibyte):
9227 * character.c (multibyte_char_to_unibyte): Remove parameter `rev_tbl',
9228 unused since 2002-03-01T01:16:34Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
9229 * character.h (CHAR_TO_BYTE8):
9230 * cmds.c (internal_self_insert):
9231 * editfns.c (general_insert_function):
9232 * keymap.c (push_key_description):
9233 * search.c (Freplace_match):
9234 * xdisp.c (message_dolog, set_message_1): All callers changed.
9236 2011-03-28 Stefan Monnier <monnier@iro.umontreal.ca>
9238 * keyboard.c (safe_run_hook_funcall): New function.
9239 (safe_run_hooks_1, safe_run_hooks_error, safe_run_hooks): On error,
9240 don't set the hook to nil, but remove the offending function instead.
9241 (Qcommand_hook_internal): Remove, unused.
9242 (syms_of_keyboard): Don't initialize Qcommand_hook_internal nor define
9243 Vcommand_hook_internal.
9245 * eval.c (enum run_hooks_condition): Remove.
9246 (funcall_nil, funcall_not): New functions.
9247 (run_hook_with_args): Call each function through a `funcall' argument.
9248 Remove `cond' argument, now redundant.
9249 (Frun_hooks, Frun_hook_with_args, Frun_hook_with_args_until_success)
9250 (Frun_hook_with_args_until_failure): Adjust accordingly.
9251 (run_hook_wrapped_funcall, Frun_hook_wrapped): New functions.
9253 2011-03-28 Juanma Barranquero <lekktu@gmail.com>
9255 * dispextern.h (string_buffer_position): Remove declaration.
9257 * print.c (strout): Remove parameter `multibyte', unused since
9258 1999-08-21T19:30:21Z!gerd@gnu.org. All callers changed.
9260 * search.c (boyer_moore): Remove parameters `len', `pos' and `lim',
9261 never used since function introduction in 1998-02-08T21:33:56Z!rms@gnu.org.
9262 All callers changed.
9264 * w32.c (_wsa_errlist): Use braces for struct initializers.
9266 * xdisp.c (string_buffer_position_lim): Remove parameter `w',
9267 never used since function introduction in 2001-03-09T18:41:50Z!gerd@gnu.org.
9268 All callers changed.
9269 (string_buffer_position): Likewise. Also, make static (it's never
9270 used outside xdisp.c).
9271 (cursor_row_p): Remove parameter `w', unused since
9272 2000-10-17T16:08:57Z!gerd@gnu.org. All callers changed.
9273 (decode_mode_spec): Remove parameter `precision', introduced during
9274 Gerd Moellmann's rewrite at 1999-07-21T21:43:52Z!gerd@gnu.org, but never used.
9275 All callers changed.
9277 2011-03-27 Jan Djärv <jan.h.d@swipnet.se>
9279 * nsterm.m (syms_of_nsterm): Use doc: for ns-auto-hide-menu-bar.
9281 2011-03-27 Anders Lindgren <andlind@gmail.com>
9283 * nsterm.m (ns_menu_bar_is_hidden): New variable.
9284 (ns_constrain_all_frames, ns_menu_bar_should_be_hidden)
9285 (ns_update_auto_hide_menu_bar): New functions.
9286 (ns_update_begin): Call ns_update_auto_hide_menu_bar.
9287 (applicationDidBecomeActive): Call ns_update_auto_hide_menu_bar and
9288 ns_constrain_all_frames.
9289 (constrainFrameRect): Return at once if ns_menu_bar_should_be_hidden.
9290 (syms_of_nsterm): DEFVAR ns-auto-hide-menu-bar, init to Qnil.
9292 2011-03-27 Jan Djärv <jan.h.d@swipnet.se>
9294 * nsmenu.m (runDialogAt): Remove argument to timer_check.
9296 2011-03-27 Glenn Morris <rgm@gnu.org>
9298 * syssignal.h: Replace RETSIGTYPE with void.
9299 * atimer.c, data.c, dispnew.c, emacs.c, floatfns.c, keyboard.c:
9300 * keyboard.h, lisp.h, process.c, sysdep.c, xterm.c:
9301 Replace SIGTYPE with void everywhere.
9302 * s/usg5-4-common.h (SIGTYPE): Remove definition.
9303 * s/template.h (SIGTYPE): Remove commented out definition.
9305 2011-03-26 Eli Zaretskii <eliz@gnu.org>
9307 * xdisp.c (redisplay_window): Don't check buffer's clip_changed
9308 flag as a prerequisite for invoking try_scrolling. (Bug#6671)
9310 2011-03-26 Juanma Barranquero <lekktu@gmail.com>
9312 * w32.c (read_unc_volume): Use parameter `henum', instead of
9313 global variable `wget_enum_handle'.
9315 * keymap.c (describe_vector): Remove parameters `indices' and
9316 `char_table_depth', unused since 2002-03-01T01:43:26Z!handa@m17n.org.
9317 (describe_map, Fdescribe_vector): Adjust calls to `describe_vector'.
9319 * keyboard.h (timer_check, show_help_echo): Remove unused parameters.
9321 * keyboard.c (timer_check): Remove parameter `do_it_now',
9322 unused since 1996-04-12T06:01:29Z!rms@gnu.org.
9323 (show_help_echo): Remove parameter `ok_to_overwrite_keystroke_echo',
9324 unused since 2008-04-19T19:30:53Z!monnier@iro.umontreal.ca.
9326 * keyboard.c (read_char):
9327 * w32menu.c (w32_menu_display_help):
9328 * xmenu.c (show_help_event, menu_help_callback):
9329 Adjust calls to `show_help_echo'.
9331 * gtkutil.c (xg_maybe_add_timer):
9332 * keyboard.c (readable_events):
9333 * process.c (wait_reading_process_output):
9334 * xmenu.c (x_menu_wait_for_event): Adjust calls to `timer_check'.
9336 * insdel.c (adjust_markers_gap_motion):
9337 Remove; no-op since 1998-01-02T21:29:48Z!rms@gnu.org.
9338 (gap_left, gap_right): Don't call it.
9340 2011-03-25 Chong Yidong <cyd@stupidchicken.com>
9342 * xdisp.c (handle_fontified_prop): Discard changes to clip_changed
9343 incurred during fontification.
9345 2011-03-25 Juanma Barranquero <lekktu@gmail.com>
9347 * buffer.c (defvar_per_buffer): Remove unused parameter `doc'.
9348 (DEFVAR_PER_BUFFER): Don't pass it.
9350 * dispnew.c (row_equal_p, add_row_entry): Remove unused parameter `w'.
9351 (scrolling_window): Don't pass it.
9353 2011-03-25 Juanma Barranquero <lekktu@gmail.com>
9355 * dispextern.h (glyph_matric): Use #if GLYPH_DEBUG, not #ifdef.
9357 * fileio.c (check_executable) [DOS_NT]: Remove unused variables `len'
9359 (Fset_file_selinux_context) [HAVE_LIBSELINUX]: Move here declaration
9360 of variables specific to SELinux and computation of `encoded_absname'.
9362 * image.c (XPutPixel): Remove unused variable `height'.
9364 * keyboard.c (make_lispy_event): Remove unused variable `hpos'.
9366 * unexw32.c (get_section_info): Remove unused variable `section'.
9368 * w32.c (stat): Remove unused variables `drive_root' and `devtype'.
9369 (system_process_attributes): Remove unused variable `sess'.
9370 (sys_read): Remove unused variable `err'.
9372 * w32fns.c (top): Wrap variables with #if GLYPH_DEBUG, not #ifdef.
9373 (w32_wnd_proc): Remove unused variable `isdead'.
9374 (unwind_create_frame): Use #if GLYPH_DEBUG, not #ifdef.
9375 (Fx_server_max_request_size): Remove unused variable `dpyinfo'.
9376 (x_create_tip_frame): Remove unused variable `tem'.
9378 * w32inevt.c (w32_console_read_socket):
9379 Remove unused variable `no_events'.
9381 * w32term.c (x_draw_composite_glyph_string_foreground):
9382 Remove unused variable `width'.
9384 2011-03-24 Juanma Barranquero <lekktu@gmail.com>
9386 * w32term.c (x_set_glyph_string_clipping):
9387 Don't pass uninitialized region to CombineRgn.
9389 2011-03-23 Juanma Barranquero <lekktu@gmail.com>
9391 * w32fns.c (x_set_menu_bar_lines): Remove unused variable `olines'.
9392 (w32_wnd_proc): Pass NULL to Windows API, not uninitialized buffer.
9393 (Fx_close_connection): Remove unused variable `i'.
9395 * w32font.c (w32font_draw): Return number of glyphs.
9396 (w32font_open_internal): Remove unused variable `i'.
9397 (w32font_driver): Add missing initializer.
9399 * w32menu.c (utf8to16): Remove unused variable `utf16'.
9400 (fill_in_menu): Remove unused variable `items_added'.
9402 * w32term.c (last_mouse_press_frame): Remove static global variable.
9403 (w32_clip_to_row): Remove unused variable `f'.
9404 (x_delete_terminal): Remove unused variable `i'.
9406 * w32uniscribe.c (uniscribe_shape): Remove unused variable `nclusters'.
9407 (NOTHING): Remove unused static global variable.
9408 (uniscribe_check_otf): Remove unused variable `table'.
9409 (uniscribe_font_driver): Add missing initializers.
9411 2011-03-23 Julien Danjou <julien@danjou.info>
9413 * term.c (Fsuspend_tty, Fresume_tty):
9414 * minibuf.c (read_minibuf, run_exit_minibuf_hook):
9415 * window.c (temp_output_buffer_show):
9416 * insdel.c (signal_before_change):
9417 * frame.c (Fhandle_switch_frame):
9418 * fileio.c (Fdo_auto_save):
9419 * emacs.c (Fkill_emacs):
9420 * editfns.c (save_excursion_restore):
9421 * cmds.c (internal_self_insert):
9422 * callint.c (Fcall_interactively):
9423 * buffer.c (Fkill_all_local_variables):
9424 * keyboard.c (Fcommand_execute, Fsuspend_emacs, safe_run_hooks_1):
9426 (command_loop_1): Use Frun_hooks. Call safe_run_hooks
9427 unconditionally since it does the check itself.
9429 2011-03-23 Paul Eggert <eggert@cs.ucla.edu>
9431 Fix more problems found by GCC 4.5.2's static checks.
9433 * coding.c (encode_coding_raw_text): Avoid unnecessary test
9434 the first time through the loop, since we know p0 < p1 then.
9435 This also avoids a gcc -Wstrict-overflow warning.
9437 * lisp.h (SAFE_ALLOCA, SAFE_ALLOCA_LISP): Avoid 'int' overflow
9438 leading to a memory leak, possible in functions like
9439 load_charset_map_from_file that can allocate an unbounded number
9440 of objects (Bug#8318).
9442 * xmenu.c (set_frame_menubar): Use EMACS_UINT, not int, for indexes
9443 that could (at least in theory) be that large.
9445 * xdisp.c (message_log_check_duplicate): Return unsigned long, not int.
9446 This is less likely to overflow, and avoids undefined behavior if
9447 overflow does occur. All callers changed. Use strtoul to scan
9448 for the unsigned long integer.
9449 (pint2hrstr): Simplify and tune code slightly.
9450 This also avoids a (bogus) GCC warning with gcc -Wstrict-overflow.
9452 * scroll.c (do_scrolling): Work around GCC bug 48228.
9453 See <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=48228>.
9455 * frame.c (Fmodify_frame_parameters): Simplify loop counter.
9456 This also avoids a warning with gcc -Wstrict-overflow.
9457 (validate_x_resource_name): Simplify count usage.
9458 This also avoids a warning with gcc -Wstrict-overflow.
9460 * fileio.c (Fcopy_file): Report error if fchown or fchmod
9463 * emacs.c (Fdaemon_initialized): Do not ignore I/O errors (Bug#8303).
9465 * process.c (Fmake_network_process): Use socklen_t, not int,
9466 where POSIX says socklen_t is required in portable programs.
9467 This fixes a porting bug on hosts like 64-bit HP-UX, where
9468 socklen_t is wider than int (Bug#8277).
9469 (Fmake_network_process, server_accept_connection):
9470 (wait_reading_process_output, read_process_output):
9473 * process.c: Rename or move locals to avoid shadowing.
9474 (list_processes_1, Fmake_network_process):
9475 (read_process_output_error_handler, exec_sentinel_error_handler):
9476 Rename or move locals.
9477 (Fmake_network_process): Define label "retry_connect" only if needed.
9478 (Fnetwork_interface_info): Fix pointer signedness.
9479 (process_send_signal): Add cast to avoid pointer signedness problem.
9480 (FIRST_PROC_DESC, IF_NON_BLOCKING_CONNECT): Remove unused macros.
9481 (create_process): Use 'volatile' to avoid vfork clobbering (Bug#8298).
9483 Make tparam.h and terminfo.c consistent.
9484 * cm.c (tputs, tgoto, BC, UP): Remove extern decls.
9485 Include tparam.h instead, since it declares them.
9486 * cm.h (PC): Remove extern decl; tparam.h now does this.
9487 * deps.mk (cm.o, terminfo.o): Depend on tparam.h.
9488 * terminfo.c: Include tparam.h, to check interfaces.
9489 (tparm): Make 1st arg a const pointer in decl. Put it at top level.
9490 (tparam): Adjust signature to match interface in tparam.h;
9491 this removes some undefined behavior. Check that outstring and len
9492 are zero, which they always are with Emacs.
9493 * tparam.h (PC, BC, UP): New extern decls.
9495 * xftfont.c (xftfont_shape): Now static, and defined only if needed.
9496 (xftfont_open): Rename locals to avoid shadowing.
9498 * ftfont.c (ftfont_resolve_generic_family): Fix pointer signedness.
9499 (ftfont_otf_capability, ftfont_shape): Omit decls if not needed.
9500 (OTF_TAG_SYM): Omit macro if not needed.
9501 (ftfont_list): Remove unused local.
9502 (get_adstyle_property, ftfont_pattern_entity):
9503 (ftfont_lookup_cache, ftfont_open, ftfont_anchor_point):
9504 Rename locals to avoid shadowing.
9506 * xfont.c (xfont_list_family): Mark var as initialized.
9508 * xml.c (make_dom): Now static.
9510 * composite.c (composition_compute_stop_pos): Rename local to
9512 (composition_reseat_it): Remove unused locals.
9513 (find_automatic_composition, composition_adjust_point): Likewise.
9514 (composition_update_it): Mark var as initialized.
9515 (find_automatic_composition): Mark vars as initialized,
9516 with a FIXME (Bug#8290).
9518 character.h: Rename locals to avoid shadowing.
9519 * character.h (PREV_CHAR_BOUNDARY, FETCH_STRING_CHAR_ADVANCE):
9520 (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE, FETCH_CHAR_ADVANCE):
9521 (FETCH_CHAR_ADVANCE_NO_CHECK, INC_POS, DEC_POS, BUF_INC_POS):
9522 (BUF_DEC_POS): Be more systematic about renaming local temporaries
9525 * textprop.c (property_change_between_p): Remove; unused.
9527 * intervals.c (interval_start_pos): Now static.
9529 * intervals.h (CHECK_TOTAL_LENGTH): Avoid empty "else".
9531 * atimer.c (start_atimer, append_atimer_lists, set_alarm):
9532 Rename locals to avoid shadowing.
9534 * sound.c (wav_play, au_play, Fplay_sound_internal):
9535 Fix pointer signedness.
9536 (alsa_choose_format): Remove unused local var.
9537 (wav_play): Initialize a variable to 0, to prevent undefined
9538 behavior (Bug#8278).
9540 * region-cache.c (insert_cache_boundary): Redo var to avoid shadowing.
9542 * region-cache.h (pp_cache): New decl, for gcc -Wmissing-prototypes.
9544 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork
9545 clobbering (Bug#8298).
9546 * sysdep.c (sys_subshell): Likewise.
9547 Previously, the sys_subshell 'volatile' was incorrectly IF_LINTted out.
9549 * lisp.h (child_setup): Now NO_RETURN unless DOS_NT.
9550 This should get cleaned up, so that child_setup has the
9551 same signature on all platforms.
9553 * callproc.c (call_process_cleanup): Now static.
9554 (relocate_fd): Rename locals to avoid shadowing.
9556 2011-03-22 Chong Yidong <cyd@stupidchicken.com>
9558 * xterm.c (x_clear_frame): Remove XClearWindow call. This appears
9559 not to be necessary, and produces flickering.
9561 2011-03-20 Glenn Morris <rgm@gnu.org>
9563 * config.in: Remove file.
9565 2011-03-20 Juanma Barranquero <lekktu@gmail.com>
9567 * minibuf.c (Vcompleting_read_function): Don't declare, global variables
9568 are now in src/globals.h.
9569 (syms_of_minibuf): Remove spurious & from previous change.
9571 2011-03-20 Leo Liu <sdl.web@gmail.com>
9573 * minibuf.c (completing-read-function): New variable.
9574 (completing-read-default): Rename from completing-read.
9575 (completing-read): Call completing-read-function.
9577 2011-03-19 Juanma Barranquero <lekktu@gmail.com>
9579 * xfaces.c (Fx_load_color_file):
9580 Read color file from absolute filename (bug#8250).
9582 2011-03-19 Juanma Barranquero <lekktu@gmail.com>
9584 * makefile.w32-in: Update dependencies.
9586 2011-03-17 Eli Zaretskii <eliz@gnu.org>
9588 * makefile.w32-in ($(BLD)/unexw32.$(O)): Depend on $(SRC)/unexec.h.
9590 2011-03-17 Paul Eggert <eggert@cs.ucla.edu>
9592 Fix more problems found by GCC 4.5.2's static checks.
9594 * process.c (make_serial_process_unwind, send_process_trap):
9595 (sigchld_handler): Now static.
9597 * process.c (allocate_pty): Let PTY_ITERATION declare iteration vars.
9598 That way, the code declares only the vars that it needs.
9599 * s/aix4-2.h (PTY_ITERATION): Declare iteration vars.
9600 * s/cygwin.h (PTY_ITERATION): Likewise.
9601 * s/darwin.h (PTY_ITERATION): Likewise.
9602 * s/gnu-linux.h (PTY_ITERATION): Likewise.
9604 * s/irix6-5.h (PTY_OPEN): Declare stb, to loosen coupling.
9605 * process.c (allocate_pty): Don't declare stb unless it's needed.
9607 * bytecode.c (MAYBE_GC): Rewrite so as not to use empty "else".
9608 (CONSTANTLIM): Remove; unused.
9609 (METER_CODE, Bscan_buffer, Bread_char, Bset_mark):
9610 Define only if needed.
9612 * unexelf.c (unexec): Name an expression,
9613 to avoid gcc -Wbad-function-cast warning.
9614 Use a different way to cause a compilation error if anyone uses
9615 n rather than nn, a way that does not involve shadowing.
9616 (ELF_BSS_SECTION_NAME, OLD_PROGRAM_H): Remove; unused.
9618 * deps.mk (unexalpha.o): Remove; unused.
9620 New file unexec.h, the (simple) interface for unexec (Bug#8267).
9621 * unexec.h: New file.
9622 * deps.mk (emacs.o, unexaix.o, unexcw.o, unexcoff.o, unexelf.o):
9623 (unexhp9k800.o, unexmacosx.o, unexsol.o, unexw32.o):
9625 * emacs.c [!defined CANNOT_DUMP]: Include unexec.h.
9626 * unexaix.c, unexcoff.c, unexcw.c, unexelf.c, unexhp9k800.c:
9627 * unexmacosx.c, unexsol.c, unexw32.c: Include unexec.h.
9628 Change as necessary to match prototype in unexec.h.
9630 * syntax.c (Fforward_comment, scan_lists): Rename locals to avoid
9632 (back_comment, skip_chars): Mark vars as initialized.
9634 * character.h (FETCH_STRING_CHAR_ADVANCE_NO_CHECK, BUF_INC_POS):
9635 Rename locals to avoid shadowing.
9637 * lread.c (read1): Rewrite so as not to use empty "else".
9638 (Fload, readevalloop, read1): Rename locals to avoid shadowing.
9640 * print.c (Fredirect_debugging_output): Fix pointer signedess.
9642 * lisp.h (debug_output_compilation_hack): Add decl here, to avoid
9643 warning when compiling print.c.
9645 * font.c (font_unparse_fcname): Abort in an "impossible" situation
9646 instead of using an uninitialized var.
9647 (font_sort_entities): Mark var as initialized.
9649 * character.h (FETCH_CHAR_ADVANCE): Rename locals to avoid shadowing.
9651 * font.c (font_unparse_xlfd): Don't mix pointers to variables with
9652 pointers to constants.
9653 (font_parse_fcname): Remove unused vars.
9654 (font_delete_unmatched): Now static.
9655 (font_get_spec): Remove; unused.
9656 (font_style_to_value, font_prop_validate_style, font_unparse_fcname):
9657 (font_update_drivers, Ffont_get_glyphs, font_add_log):
9658 Rename or move locals to avoid shadowing.
9660 * fns.c (require_nesting_list, require_unwind): Now static.
9661 (Ffillarray): Rename locals to avoid shadowing.
9663 * floatfns.c (domain_error2): Define only if needed.
9664 (Ffrexp, Fldexp): Rename locals to avoid shadowing.
9666 * alloc.c (mark_backtrace): Move decl from here ...
9667 * lisp.h: ... to here, so that it can be checked.
9669 * eval.c (call_debugger, do_debug_on_call, grow_specpdl): Now static.
9670 (Fdefvar): Rewrite so as not to use empty "else".
9671 (lisp_indirect_variable): Name an expression,
9672 to avoid gcc -Wbad-function-cast warning.
9673 (Fdefvar): Rename locals to avoid shadowing.
9675 * callint.c (quotify_arg, quotify_args): Now static.
9676 (Fcall_interactively): Rename locals to avoid shadowing.
9677 Use const pointer when appropriate.
9679 * lisp.h (get_system_name, get_operating_system_release):
9680 Move decls here, to check interfaces.
9681 * process.c (get_operating_system_release): Move decl to lisp.h.
9682 * xrdb.c (get_system_name): Likewise.
9683 * editfns.c (init_editfns, Fuser_login_name, Fuser_uid):
9684 (Fuser_real_uid, Fuser_full_name): Remove unnecessary casts,
9685 some of which prompt warnings from gcc -Wbad-function-cast.
9686 (Fformat_time_string, Fencode_time, Finsert_char):
9687 (Ftranslate_region_internal, Fformat):
9688 Rename or remove local vars to avoid shadowing.
9689 (Ftranslate_region_internal): Mark var as initialized.
9691 * doc.c (Fdocumentation, Fsnarf_documentation): Move locals to
9694 * lisp.h (eassert): Check that the argument compiles, even if
9695 ENABLE_CHECKING is not defined.
9697 * data.c (Findirect_variable): Name an expression, to avoid
9698 gcc -Wbad-function-cast warning.
9699 (default_value, arithcompare, arith_driver, arith_error): Now static.
9700 (store_symval_forwarding): Rename local to avoid shadowing.
9701 (Fmake_variable_buffer_local, Fmake_local_variable):
9702 Mark variables as initialized.
9703 (do_blv_forwarding, do_symval_forwarding): Remove; unused.
9705 * alloc.c (check_cons_list): Do not define unless GC_CHECK_CONS_LIST.
9706 (Fmake_vector, Fvector, Fmake_byte_code, Fgarbage_collect):
9707 Rename locals to avoid shadowing.
9708 (mark_stack): Move local variables into the #ifdef region where
9710 (BLOCK_INPUT_ALLOC, UNBLOCK_INPUT_ALLOC): Define only if
9711 ! defined SYSTEM_MALLOC && ! defined SYNC_INPUT, as they are not
9713 (CHECK_ALLOCATED): Define only if GC_CHECK_MARKED_OBJECTS.
9714 (GC_STRING_CHARS): Remove; not used.
9715 (Fmemory_limit): Cast sbrk's returned value to char *.
9717 * lisp.h (check_cons_list): Declare if GC_CHECK_CONS_LIST; this
9718 avoids undefined behavior in theory.
9720 * regex.c (IF_LINT): Add defn, for benefit of ../lib-src.
9722 Use functions, not macros, for up- and down-casing (Bug#8254).
9723 * buffer.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
9724 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Remove. All callers changed
9725 to use the following functions instead of these macros.
9726 (downcase): Adjust to lack of DOWNCASE_TABLE. Return int, not
9727 EMACS_INT, since callers assume the returned value fits in int.
9728 (upcase1): Likewise, for UPCASE_TABLE.
9729 (uppercasep, lowercasep, upcase): New static inline functions.
9730 * editfns.c (Fchar_equal): Remove no-longer-needed workaround for
9731 the race-condition problem in the old DOWNCASE.
9733 * regex.c (CHARSET_LOOKUP_RANGE_TABLE_RAW, POP_FAILURE_REG_OR_COUNT):
9734 Rename locals to avoid shadowing.
9735 (regex_compile, re_match_2_internal): Move locals to avoid shadowing.
9736 (regex_compile, re_search_2, re_match_2_internal):
9737 Remove unused local vars.
9738 (FREE_VAR): Rewrite so as not to use empty "else",
9739 which gcc can warn about.
9740 (regex_compile, re_match_2_internal): Mark locals as initialized.
9741 (RETALLOC_IF): Define only if needed.
9742 (WORDCHAR_P): Likewise. This one is never needed, but is used
9743 only in a comment talking about a compiler bug, so put inside
9744 the #if 0 of that comment.
9745 (CHARSET_LOOKUP_BITMAP, FAIL_STACK_FULL, RESET_FAIL_STACK):
9746 (PUSH_FAILURE_ELT, BUF_PUSH_3, STOP_ADDR_VSTRING):
9749 * search.c (boyer_moore): Rename locals to avoid shadowing.
9750 * character.h (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE):
9751 (PREV_CHAR_BOUNDARY): Likewise.
9753 * search.c (simple_search): Remove unused var.
9755 * dired.c (compile_pattern): Move decl from here ...
9756 * lisp.h: ... to here, so that it can be checked.
9757 (struct re_registers): New forward decl.
9759 * character.h (INC_POS, DEC_POS): Rename locals to avoid shadowing.
9761 * indent.c (MULTIBYTE_BYTES_WIDTH): New args bytes, width.
9763 (MULTIBYTE_BYTES_WIDTH, scan_for_column, compute_motion):
9764 Rename locals to avoid shadowing.
9765 (Fvertical_motion): Mark locals as initialized.
9767 * casefiddle.c (casify_object, casify_region): Now static.
9768 (casify_region): Mark local as initialized.
9770 * cmds.c (internal_self_insert): Rename local to avoid shadowing.
9772 * lisp.h (GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR, GCPRO5_VAR, GCPRO6_VAR):
9773 New macros, so that the caller can use some names other than
9774 gcpro1, gcpro2, etc.
9775 (GCPRO2, GCPRO3, GCPRO4, GCPRO5, GCPRO6): Reimplement in terms
9777 (GCPRO1_VAR, UNGCPRO_VAR): Change the meaning of the second
9778 argument, for consistency with GCPRO2_VAR, etc: it is now the
9779 prefix of the variable, not the variable itself. All uses
9781 * dired.c (directory_files_internal, file_name_completion):
9782 Rename locals to avoid shadowing.
9784 Fix a race condition diagnosed by gcc -Wsequence-point (Bug#8254).
9785 An expression of the form (DOWNCASE (x) == DOWNCASE (y)), found in
9786 dired.c's scmp function, had undefined behavior.
9787 * lisp.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
9788 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Move from here ...
9789 * buffer.h: ... to here, because these macros use current_buffer,
9790 and the new implementation with inline functions needs to have
9791 current_buffer in scope now, rather than later when the macros
9793 (downcase, upcase1): New static inline functions.
9794 (DOWNCASE, UPCASE1): Reimplement using these functions.
9795 This avoids undefined behavior in expressions like
9796 DOWNCASE (x) == DOWNCASE (y), which previously suffered
9797 from race conditions in accessing the global variables
9798 case_temp1 and case_temp2.
9799 * casetab.c (case_temp1, case_temp2): Remove; no longer needed.
9800 * lisp.h (case_temp1, case_temp2): Remove their decls.
9801 * character.h (ASCII_CHAR_P): Move from here ...
9802 * lisp.h: ... to here, so that the inline functions mentioned
9805 * dired.c (directory_files_internal_unwind): Now static.
9807 * fileio.c (file_name_as_directory, directory_file_name):
9808 (barf_or_query_if_file_exists, auto_save_error, auto_save_1):
9810 (file_name_as_directory): Use const pointers when appropriate.
9811 (Fexpand_file_name): Likewise. In particular, newdir might
9812 point at constant storage, so make it a const pointer.
9813 (Fmake_directory_internal, Fread_file_name): Remove unused vars.
9814 (Ffile_selinux_context, Fset_file_selinux_context): Fix pointer
9816 (Fset_file_times, Finsert_file_contents, auto_save_error):
9817 Rename locals to avoid shadowing.
9819 * minibuf.c (choose_minibuf_frame_1): Now static.
9820 (Ftry_completion, Fall_completions): Rename or remove locals
9823 * marker.c (bytepos_to_charpos): Remove; unused.
9825 * lisp.h (verify_bytepos, count_markers): New decls,
9826 so that gcc does not warn that these functions aren't declared.
9828 * insdel.c (check_markers, make_gap_larger, make_gap_smaller):
9829 (reset_var_on_error, Fcombine_after_change_execute_1): Now static.
9830 (CHECK_MARKERS): Redo to avoid gcc -Wempty-body diagnostic.
9831 (copy_text): Remove unused local var.
9833 * filelock.c (within_one_second): Now static.
9834 (lock_file_1): Rename local to avoid shadowing.
9836 * buffer.c (fix_overlays_before): Mark locals as initialized.
9837 (fix_start_end_in_overlays): Likewise. This function should be
9838 simplified by using pointers-to-pointers, but that's a different
9840 (switch_to_buffer_1): Now static.
9841 (Fkill_buffer, record_buffer, Fbury_buffer, Fset_buffer_multibyte):
9842 (report_overlay_modification): Rename locals to avoid shadowing.
9844 * sysdep.c (system_process_attributes): Rename vars to avoid shadowing.
9845 Fix pointer signedness issue.
9846 (sys_subshell): Mark local as volatile if checking for lint,
9847 to suppress a gcc -Wclobbered warning that does not seem to be right.
9848 (MAXPATHLEN): Define only if needed.
9850 * process.c (serial_open, serial_configure): Move decls from here ...
9851 * systty.h: ... to here, so that they can be checked.
9853 * fns.c (get_random, seed_random): Move extern decls from here ...
9854 * lisp.h: ... to here, so that they can be checked.
9856 * sysdep.c (reset_io): Now static.
9857 (wait_for_termination_signal): Remove; unused.
9859 * keymap.c (keymap_parent, keymap_memberp, map_keymap_internal):
9860 (copy_keymap_item, append_key, push_text_char_description):
9862 (Fwhere_is_internal): Don't test CONSP (sequences) unnecessarily.
9863 (DENSE_TABLE_SIZE): Remove; unused.
9864 (get_keymap, access_keymap, Fdefine_key, Fwhere_is_internal):
9865 (describe_map_tree):
9866 Rename locals to avoid shadowing.
9868 * keyboard.c: Declare functions static if they are not used elsewhere.
9869 (echo_char, echo_dash, cmd_error, top_level_2):
9870 (poll_for_input, handle_async_input): Now static.
9871 (read_char, kbd_buffer_get_event, make_lispy_position):
9872 (make_lispy_event, make_lispy_movement, apply_modifiers):
9873 (decode_keyboard_code, tty_read_avail_input, menu_bar_items):
9874 (parse_tool_bar_item, read_key_sequence, Fread_key_sequence):
9875 (Fread_key_sequence_vector): Rename locals to avoid shadowing.
9876 (read_key_sequence, read_char): Mark locals as initialized.
9877 (Fexit_recursive_edit, Fabort_recursive_edit): Mark with NO_RETURN.
9879 * keyboard.h (make_ctrl_char): New decl.
9880 (mark_kboards): Move decl here ...
9881 * alloc.c (mark_kboards): ... from here.
9883 * lisp.h (force_auto_save_soon): New decl.
9885 * emacs.c (init_cmdargs): Rename local to avoid shadowing.
9886 (DEFINE_DUMMY_FUNCTION): New macro.
9887 (__do_global_ctors, __do_global_ctors_aux, __do_global_dtors, __main):
9889 (main): Add casts to avoid warnings
9890 if GCC considers string literals to be constants.
9892 * lisp.h (fatal_error_signal): Add decl, since it's exported.
9894 * dbusbind.c: Pointer signedness fixes.
9895 (xd_signature, xd_append_arg, xd_initialize):
9896 (Fdbus_call_method, Fdbus_call_method_asynchronously):
9897 (Fdbus_method_return_internal, Fdbus_method_error_internal):
9898 (Fdbus_send_signal, xd_read_message_1, Fdbus_register_service):
9899 (Fdbus_register_signal): Use SSDATA when the context wants char *.
9901 * dbusbind.c (Fdbus_init_bus): Add cast to avoid warning
9902 if GCC considers string literals to be constants.
9903 (Fdbus_register_service, Fdbus_register_method): Remove unused vars.
9905 2011-03-16 Stefan Monnier <monnier@iro.umontreal.ca>
9907 * print.c (PRINT_CIRCLE_CANDIDATE_P): New macro.
9908 (print_preprocess, print_object): New macro to fix last change.
9910 * print.c (print_preprocess): Don't forget font objects.
9912 2011-03-16 Juanma Barranquero <lekktu@gmail.com>
9914 * emacs.c (USAGE3): Doc fixes.
9916 2011-03-15 Andreas Schwab <schwab@linux-m68k.org>
9918 * coding.c (detect_coding_iso_2022): Reorganize code to clarify
9921 2011-03-14 Juanma Barranquero <lekktu@gmail.com>
9923 * lisp.h (VWindow_system, Qfile_name_history):
9924 * keyboard.h (lispy_function_keys) [WINDOWSNT]:
9925 * w32term.h (w32_system_caret_hwnd, w32_system_caret_height)
9926 (w32_system_caret_x, w32_system_caret_y): Declare extern.
9928 * w32select.c: Don't #include "keyboard.h".
9929 (run_protected): Add extern declaration for waiting_for_input.
9931 * w32.c (Qlocal, noninteractive1, inhibit_window_system):
9932 * w32console.c (detect_input_pending, read_input_pending)
9933 (encode_terminal_code):
9934 * w32fns.c (quit_char, lispy_function_keys, Qtooltip)
9935 (w32_system_caret_hwnd, w32_system_caret_height, w32_system_caret_x)
9936 (w32_system_caret_y, Qfile_name_history):
9937 * w32font.c (w32font_driver, QCantialias, QCotf, QClang):
9938 * w32inevt.c (reinvoke_input_signal, lispy_function_keys):
9939 * w32menu.c (Qmenu_bar, QCtoggle, QCradio, Qoverriding_local_map)
9940 (Qoverriding_terminal_local_map, Qmenu_bar_update_hook):
9941 * w32proc.c (Qlocal, report_file_error):
9942 * w32term.c (Vwindow_system, updating_frame):
9943 * w32uniscribe.c (initialized, uniscribe_font_driver):
9944 Remove unneeded extern declarations.
9946 2011-03-14 Chong Yidong <cyd@stupidchicken.com>
9948 * buffer.c (Fmake_indirect_buffer): Fix incorrect assertions.
9950 2011-03-13 Chong Yidong <cyd@stupidchicken.com>
9952 * buffer.h (BUF_BEGV, BUF_BEGV_BYTE, BUF_ZV, BUF_ZV_BYTE, BUF_PT)
9953 (BUF_PT_BYTE): Rewrite to handle indirect buffers (Bug#8219).
9954 These macros can no longer be used for assignment.
9956 * buffer.c (Fget_buffer_create, Fmake_indirect_buffer):
9957 Assign struct members directly, instead of using BUF_BEGV etc.
9958 (record_buffer_markers, fetch_buffer_markers): New functions for
9959 recording and fetching special buffer markers.
9960 (set_buffer_internal_1, set_buffer_temp): Use them.
9962 * lread.c (unreadchar): Use SET_BUF_PT_BOTH.
9964 * insdel.c (adjust_point): Use SET_BUF_PT_BOTH.
9966 * intervals.c (temp_set_point_both): Use SET_BUF_PT_BOTH.
9967 (get_local_map): Use SET_BUF_BEGV_BOTH and SET_BUF_ZV_BOTH.
9969 * xdisp.c (hscroll_window_tree):
9970 (reconsider_clip_changes): Use PT instead of BUF_PT.
9972 2011-03-13 Eli Zaretskii <eliz@gnu.org>
9974 * makefile.w32-in ($(BLD)/editfns.$(O)): Depend on
9975 $(EMACS_ROOT)/lib/intprops.h.
9977 2011-03-13 Paul Eggert <eggert@cs.ucla.edu>
9979 Fix more problems found by GCC 4.5.2's static checks.
9981 * gtkutil.c (xg_get_pixbuf_from_pixmap): Add cast from char *
9982 to unsigned char * to avoid compiler diagnostic.
9983 (xg_free_frame_widgets): Make it clear that a local variable is
9984 needed only if USE_GTK_TOOLTIP.
9985 (gdk_window_get_screen): Make it clear that this macro is needed
9986 only if USE_GTK_TOOLTIP.
9987 (int_gtk_range_get_value): New function, which avoids a diagnostic
9988 from gcc -Wbad-function-cast.
9989 (xg_set_toolkit_scroll_bar_thumb): Use it.
9990 (xg_tool_bar_callback, xg_tool_item_stale_p): Rewrite to avoid
9991 diagnostic from gcc -Wbad-function-cast.
9992 (get_utf8_string, xg_get_file_with_chooser):
9993 Rename locals to avoid shadowing.
9994 (create_dialog): Move locals to avoid shadowing.
9996 * xgselect.c (xg_select): Remove unused var.
9998 * image.c (four_corners_best): Mark locals as initialized.
9999 (gif_load): Initialize transparent_p to zero (Bug#8238).
10000 Mark another local as initialized.
10001 (my_png_error, my_error_exit): Mark with NO_RETURN.
10003 * image.c (clear_image_cache): Now static.
10004 (DIM, HAVE_STDLIB_H_1): Remove unused macros.
10005 (xpm_load): Redo to avoid "discards qualifiers" gcc warning.
10006 (x_edge_detection): Remove unnecessary cast that
10007 gcc -Wbad-function-cast diagnoses.
10008 (gif_load): Fix pointer signedness.
10009 (clear_image_cache, xbm_read_bitmap_data, x_detect_edges):
10010 (jpeg_load, gif_load): Rename locals to avoid shadowing.
10012 2011-03-12 Paul Eggert <eggert@cs.ucla.edu>
10014 Improve quality of tests for time stamp overflow.
10015 For example, without this patch (encode-time 0 0 0 1 1
10016 1152921504606846976) returns the obviously-bogus value (-948597
10017 62170) on my RHEL 5.5 x86-64 host. With the patch, it correctly
10018 reports time overflow. See
10019 <http://lists.gnu.org/archive/html/emacs-devel/2011-03/msg00470.html>.
10020 * deps.mk (editfns.o): Depend on ../lib/intprops.h.
10021 * editfns.c: Include limits.h and intprops.h.
10022 (TIME_T_MIN, TIME_T_MAX): New macros.
10023 (time_overflow): Move earlier, to before first use.
10024 (hi_time, lo_time): New functions, for an accurate test for
10025 out-of-range times.
10026 (Fcurrent_time, Fget_internal_run_time, make_time): Use them.
10027 (Fget_internal_run_time): Don't assume time_t fits in int.
10028 (make_time): Use list2 instead of Fcons twice.
10029 (Fdecode_time): More accurate test for out-of-range times.
10030 (check_tm_member): New function.
10031 (Fencode_time): Use it, to test for out-of-range times.
10032 (lisp_time_argument): Don't rely on undefined left-shift and
10033 right-shift behavior when checking for time stamp overflow.
10035 * editfns.c (time_overflow): New function, refactoring common code.
10036 (Fformat_time_string, Fdecode_time, Fencode_time):
10037 (Fcurrent_time_string): Use it.
10039 Move 'make_time' to be next to its inverse 'lisp_time_argument'.
10040 * dired.c (make_time): Move to ...
10041 * editfns.c (make_time): ... here.
10042 * systime.h: Note the move.
10044 2011-03-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
10046 * fringe.c (update_window_fringes): Remove unused variables.
10048 * unexmacosx.c (copy_data_segment): Also copy __got section.
10051 2011-03-12 Eli Zaretskii <eliz@gnu.org>
10053 * termcap.c [MSDOS]: Include "msdos.h".
10054 (find_capability, tgetnum, tgetflag, tgetstr, tputs, tgetent):
10055 Constify `char *' arguments and their references according to
10056 prototypes in tparam.h.
10058 * deps.mk (termcap.o): Depend on tparam.h and msdos.h.
10060 * msdos.c (XMenuAddPane): 3rd argument is `const char *' now.
10061 Adapt all references accordingly.
10063 * msdos.h (XMenuAddPane): 3rd argument is `const char *' now.
10065 2011-03-11 Tom Tromey <tromey@redhat.com>
10067 * buffer.c (syms_of_buffer): Remove obsolete comment.
10069 2011-03-11 Eli Zaretskii <eliz@gnu.org>
10071 * termhooks.h (encode_terminal_code): Declare prototype.
10073 * msdos.c (encode_terminal_code): Don't declare prototype.
10075 * term.c (encode_terminal_code): Now external again, used by
10076 w32console.c and msdos.c.
10078 * makefile.w32-in ($(BLD)/term.$(O), ($(BLD)/tparam.$(O)):
10079 Depend on $(SRC)/tparam.h, see 2011-03-11T07:24:21Z!eggert@cs.ucla.edu.
10081 2011-03-11 Paul Eggert <eggert@cs.ucla.edu>
10083 Fix some minor problems found by GCC 4.5.2's static checks.
10085 * fringe.c (update_window_fringes): Mark locals as initialized
10087 (destroy_fringe_bitmap, init_fringe_bitmap): Now static.
10089 * alloc.c (mark_fringe_data): Move decl from here ...
10090 * lisp.h (mark_fringe_data) [HAVE_WINDOW_SYSTEM]: ... to here,
10091 to check its interface.
10092 (init_fringe_once): Do not declare unless HAVE_WINDOW_SYSTEM.
10094 * fontset.c (free_realized_fontset): Now static.
10095 (Fset_fontset_font): Rename local to avoid shadowing.
10096 (fontset_font): Mark local as initialized.
10097 (FONTSET_SPEC, FONTSET_REPERTORY, RFONT_DEF_REPERTORY): Remove; unused.
10099 * xrdb.c: Include "xterm.h", to check x_load_resources's interface.
10101 * xselect.c (x_disown_buffer_selections): Remove; not used.
10102 (TRACE3) [!defined TRACE_SELECTION]: Remove; not used.
10103 (x_own_selection, Fx_disown_selection_internal): Rename locals
10104 to avoid shadowing.
10105 (x_handle_dnd_message): Remove local to avoid shadowing.
10107 * lisp.h (GCPRO1_VAR, UNGCPRO_VAR): New macros,
10108 so that the caller can use some name other than gcpro1.
10109 (GCPRO1, UNGCPRO): Reimplement in terms of the new macros.
10110 * xfns.c (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
10111 (Fx_backspace_delete_keys_p):
10112 Use them to avoid shadowing, and rename vars to avoid shadowing.
10113 (x_decode_color, x_set_name, x_window): Now static.
10114 (Fx_create_frame): Add braces to silence GCC warning.
10115 (Fx_file_dialog, Fx_select_font): Fix pointer signedness.
10116 (x_real_positions, xg_set_icon_from_xpm_data, x_create_tip_frame):
10117 Remove unused locals.
10118 (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
10119 (Fx_backspace_delete_keys_p): Rename locals to avoid shadowing.
10120 Some of these renamings use the new GCPRO1_VAR and UNGCPRO_VAR
10123 * xterm.h (x_mouse_leave): New decl.
10125 * xterm.c (x_copy_dpy_color, x_focus_on_frame, x_unfocus_frame):
10126 Remove unused functions.
10127 (x_shift_glyphs_for_insert, XTflash, XTring_bell):
10128 (x_calc_absolute_position): Now static.
10129 (XTread_socket): Don't define label "out" unless it's used.
10130 Don't declare local "event" unless it's used.
10131 (x_iconify_frame, x_free_frame_resources): Don't declare locals
10132 unless they are used.
10133 (XEMBED_VERSION, xembed_set_info): Don't define unless needed.
10134 (x_fatal_error_signal): Remove; not used.
10135 (x_draw_image_foreground, redo_mouse_highlight, XTmouse_position):
10136 (x_scroll_bar_report_motion, handle_one_xevent, x_draw_bar_cursor):
10137 (x_error_catcher, x_connection_closed, x_error_handler):
10138 (x_error_quitter, xembed_send_message, x_iconify_frame):
10139 (my_log_handler): Rename locals to avoid shadowing.
10140 (x_delete_glyphs, x_ins_del_lines): Mark with NO_RETURN.
10141 (x_connection_closed): Tell GCC not to suggest NO_RETURN.
10143 * xfaces.c (clear_face_cache, Fx_list_fonts, Fface_font):
10144 Rename or move locals to avoid shadowing.
10145 (tty_defined_color, merge_face_heights): Now static.
10146 (free_realized_faces_for_fontset): Remove; not used.
10147 (Fx_list_fonts): Mark variable that gcc -Wuninitialized
10148 does not deduce is never used uninitialized.
10149 (STRDUPA, LSTRDUPA, FONT_POINT_SIZE_QUANTUM): Remove; not used.
10150 (LFACEP): Define only if XASSERTS, as it's not needed otherwise.
10152 * terminal.c (store_terminal_param): Now static.
10154 * xmenu.c (menu_highlight_callback): Now static.
10155 (set_frame_menubar): Remove unused local.
10156 (xmenu_show): Rename parameter to avoid shadowing.
10157 (xmenu_show, xdialog_show, xmenu_show): Make local pointers "const"
10158 since they might point to immutable storage.
10159 (next_menubar_widget_id): Declare only if USE_X_TOOLKIT,
10160 since it's unused otherwise.
10162 * xdisp.c (produce_glyphless_glyph): Initialize lower_xoff.
10163 Add a FIXME, since the code still doesn't look right. (Bug#8215)
10164 (Fcurrent_bidi_paragraph_direction): Simplify slightly; this
10165 avoids a gcc -Wuninitialized diagnostic.
10166 (display_line, BUILD_COMPOSITE_GLYPH_STRING, draw_glyphs):
10167 (note_mouse_highlight): Mark variables that gcc -Wuninitialized
10168 does not deduce are never used uninitialized.
10170 * lisp.h (IF_LINT): New macro, copied from ../lib-src/emacsclient.c.
10172 * xdisp.c (redisplay_window): Rename local to avoid shadowing.
10173 * window.c (window_loop, size_window):
10174 (run_window_configuration_change_hook, enlarge_window): Likewise.
10176 * window.c (display_buffer): Now static.
10177 (size_window): Mark variables that gcc -Wuninitialized
10178 does not deduce are never used uninitialized.
10179 * window.h (check_all_windows): New decl, to forestall
10180 gcc -Wmissing-prototypes diagnostic.
10181 * dispextern.h (bidi_dump_cached_states): Likewise.
10183 * charset.h (CHECK_CHARSET_GET_CHARSET): Rename locals to avoid
10185 * charset.c (map_charset_for_dump, Fchar_charset): Likewise.
10186 Include <limits.h>.
10187 (Fsort_charsets): Redo min/max calculation to shorten the code a bit
10188 and to avoid gcc -Wuninitialized warning.
10189 (load_charset_map): Mark variables that gcc -Wuninitialized
10190 does not deduce are never used uninitialized.
10191 (load_charset): Abort instead of using uninitialized var (Bug#8229).
10193 * coding.c (coding_set_source, coding_set_destination):
10194 Use "else { /* comment */ }" rather than "else /* comment */;"
10195 for clarity, and to avoid gcc -Wempty-body warning.
10196 (Fdefine_coding_system_internal): Don't redeclare 'i' inside
10197 a block, when the outer 'i' will do.
10198 (decode_coding_utf_8, decode_coding_utf_16, detect_coding_emacs_mule):
10199 (emacs_mule_char, decode_coding_emacs_mule, detect_coding_iso_2022):
10200 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5):
10201 (decode_coding_raw_text, decode_coding_charset, get_translation_table):
10202 (Fdecode_sjis_char, Fdefine_coding_system_internal):
10203 Rename locals to avoid shadowing.
10204 * character.h (FETCH_STRING_CHAR_ADVANCE): Likewise.
10205 * coding.c (emacs_mule_char, encode_invocation_designation):
10206 Now static, since they're not used elsewhere.
10207 (decode_coding_iso_2022): Add "default: abort ();" as a safety check.
10208 (decode_coding_object, encode_coding_object, detect_coding_system):
10209 (decode_coding_emacs_mule): Mark variables that gcc
10210 -Wuninitialized does not deduce are never used uninitialized.
10211 (detect_coding_iso_2022): Initialize a local variable that might
10212 be used uninitialized. Leave a FIXME because it's not clear that
10213 this initialization is needed. (Bug#8211)
10214 (ISO_CODE_LF, ISO_CODE_CR, CODING_ISO_FLAG_EUC_TW_SHIFT):
10215 (ONE_MORE_BYTE_NO_CHECK, UTF_BOM, UTF_16_INVALID_P):
10216 (SHIFT_OUT_OK, ENCODE_CONTROL_SEQUENCE_INTRODUCER):
10217 (ENCODE_DIRECTION_R2L, ENCODE_DIRECTION_L2R):
10218 Remove unused macros.
10220 * category.c (hash_get_category_set): Remove unused local var.
10221 (copy_category_table): Now static, since it's not used elsewhere.
10222 * character.c (string_count_byte8): Likewise.
10224 * ccl.c (CCL_WRITE_STRING, CCL_ENCODE_CHAR, Fccl_execute_on_string):
10225 (Fregister_code_conversion_map): Rename locals to avoid shadowing.
10227 * chartab.c (copy_sub_char_table): Now static, since it's not used
10229 (sub_char_table_ref_and_range, char_table_ref_and_range):
10230 Rename locals to avoid shadowing.
10231 (ASET_RANGE, GET_SUB_CHAR_TABLE): Remove unused macros.
10233 * bidi.c (bidi_check_type): Now static, since it's not used elsewhere.
10234 (BIDI_BOB): Remove unused macro.
10236 * cm.c (cmgoto): Mark variables that gcc -Wuninitialized does not
10237 deduce are never used uninitialized.
10238 * term.c (encode_terminal_code): Likewise.
10240 * term.c (encode_terminal_code): Now static. Remove unused local.
10242 * tparam.h: New file.
10243 * term.c, tparam.h: Include it.
10244 * deps.mk (term.o, tparam.o): Depend on tparam.h.
10245 * term.c (tputs, tgetent, tgetflag, tgetnum, tparam, tgetstr):
10246 Move these decls to tparam.h, and make them agree with what
10247 is actually in tparam.c. The previous trick of using incompatible
10248 decls in different modules does not conform to the C standard.
10249 All callers of tparam changed to use tparam's actual API.
10250 * tparam.c (tparam1, tparam, tgoto):
10251 Use const pointers where appropriate.
10253 * cm.c (calccost, cmgoto): Use const pointers where appropriate.
10254 * cm.h (struct cm): Likewise.
10255 * dispextern.h (do_line_insertion_deletion_costs): Likewise.
10256 * scroll.c (ins_del_costs, do_line_insertion_deletion_costs): Likewise.
10257 * term.c (tty_ins_del_lines, calculate_costs, struct fkey_table):
10258 (term_get_fkeys_1, append_glyphless_glyph, produce_glyphless_glyph):
10259 (turn_on_face, init_tty): Likewise.
10260 * termchar.h (struct tty_display_info): Likewise.
10262 * term.c (term_mouse_position): Rename local to avoid shadowing.
10264 * alloc.c (mark_ttys): Move decl from here ...
10265 * lisp.h (mark_ttys): ... to here, so that it's checked against defn.
10267 2011-03-11 Andreas Schwab <schwab@linux-m68k.org>
10269 * .gdbinit (pwinx, xbuffer): Fix access to buffer name.
10271 2011-03-09 Juanma Barranquero <lekktu@gmail.com>
10273 * search.c (compile_pattern_1): Remove argument regp, unused since
10274 revid:rms@gnu.org-19941211082627-3x1g1wyqkjmwloig.
10275 (compile_pattern): Don't pass it.
10277 2011-03-08 Jan Djärv <jan.h.d@swipnet.se>
10279 * xterm.h (DEFAULT_GDK_DISPLAY): New define.
10280 (GDK_WINDOW_XID, gtk_widget_get_preferred_size): New defines
10282 (GTK_WIDGET_TO_X_WIN): Use GDK_WINDOW_XID.
10284 * xmenu.c (menu_position_func): Call gtk_widget_get_preferred_size.
10286 * gtkutil.c: Include gtkx.h if HAVE_GTK3. If ! HAVE_GTK3, define
10287 gdk_window_get_screen, gdk_window_get_geometry,
10288 gdk_x11_window_lookup_for_display and GDK_KEY_g.
10289 (xg_set_screen): Use DEFAULT_GDK_DISPLAY.
10290 (xg_get_pixbuf_from_pixmap): New function.
10291 (xg_get_pixbuf_from_pix_and_mask): Change parameters from GdkPixmap
10292 to Pixmap, take frame as parameter, remove GdkColormap parameter.
10293 Call xg_get_pixbuf_from_pixmap instead of
10294 gdk_pixbuf_get_from_drawable.
10295 (xg_get_image_for_pixmap): Do not make GdkPixmaps, call
10296 xg_get_pixbuf_from_pix_and_mask with Pixmap parameters instead.
10297 (xg_check_special_colors): Use GtkStyleContext and its functions
10299 (xg_prepare_tooltip, xg_hide_tooltip): Call gdk_window_get_screen.
10300 (xg_prepare_tooltip, create_dialog, menubar_map_cb)
10301 (xg_update_frame_menubar, xg_tool_bar_detach_callback)
10302 (xg_tool_bar_attach_callback, xg_update_tool_bar_sizes):
10303 Call gtk_widget_get_preferred_size.
10304 (xg_frame_resized): gdk_window_get_geometry only takes 5
10306 (xg_win_to_widget, xg_event_is_for_menubar):
10307 Call gdk_x11_window_lookup_for_display.
10308 (xg_set_widget_bg): New function.
10309 (delete_cb): New function.
10310 (xg_create_frame_widgets): Connect delete-event to delete_cb.
10311 Call xg_set_widget_bg. Only set background pixmap for ! HAVE_GTK3
10312 (xg_set_background_color): Call xg_set_widget_bg.
10313 (xg_set_frame_icon): Call xg_get_pixbuf_from_pix_and_mask.
10314 (xg_create_scroll_bar): vadj is a GtkAdjustment for HAVE_GTK3.
10315 Only call gtk_range_set_update_policy if ! HAVE_GTK3.
10316 (xg_make_tool_item): Only connect xg_tool_bar_item_expose_callback
10318 (update_frame_tool_bar): Call gtk_widget_hide.
10319 (xg_initialize): Use GDK_KEY_g.
10321 * xsmfns.c (gdk_set_sm_client_id): Define to gdk_set_sm_client_id
10323 (x_session_initialize): Call gdk_x11_set_sm_client_id.
10325 * xterm.c (XFillRectangle): Use cairo routines for HAVE_GTK3.
10326 (x_term_init): Disable Xinput(2) with GDK_CORE_DEVICE_EVENTS.
10327 Load ~/emacs.d/gtkrc only for ! HAVE_GTK3.
10329 2011-03-08 Juanma Barranquero <lekktu@gmail.com>
10331 * w32xfns.c (select_palette): Check success of RealizePalette against
10332 GDI_ERROR, not zero.
10334 See ChangeLog.11 for earlier changes.
10336 ;; Local Variables:
10340 Copyright (C) 2011-2012 Free Software Foundation, Inc.
10342 This file is part of GNU Emacs.
10344 GNU Emacs is free software: you can redistribute it and/or modify
10345 it under the terms of the GNU General Public License as published by
10346 the Free Software Foundation, either version 3 of the License, or
10347 (at your option) any later version.
10349 GNU Emacs is distributed in the hope that it will be useful,
10350 but WITHOUT ANY WARRANTY; without even the implied warranty of
10351 MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
10352 GNU General Public License for more details.
10354 You should have received a copy of the GNU General Public License
10355 along with GNU Emacs. If not, see <http://www.gnu.org/licenses/>.