gnu: maven: Update to 3.8.5.

* gnu/packages/maven.scm (maven-pom): Update to 3.8.5.
(maven-model-builder)[arguments]: Build from the subdirectory to work
around a test issue.
(maven-3.0-model-builder)[arguments]: Fix accordingly.

gnu: Add maven-parent-pom-35.

* gnu/packages/maven-parent-pom.scm (maven-parent-pom-35): New variable.

gnu: Add apache-parent-pom-25.

* gnu/packages/maven-parent-pom.scm (apache-parent-pom-25): New
variable.

gnu: ocaml-ppx-tools: Update to 6.5.

* gnu/packages/ocaml.scm (ocaml-ppx-tools): Update to 6.5.

gnu: dune: Update to 3.0.3.

* gnu/packages/ocaml.scm (dune): Update to 3.0.3.
(dune-configurator)[arguments]: Remove vendored dependencies.
(ocaml4.09-dune-configurator)[arguments]: Extend from dune-configurator.

gnu: python-pgpy: Update dependencies.

* gnu/packages/python-crypto.scm (python-pgpy)[native-inputs]: Move
python-cryptography, python-pyasn1, python-singledispatch, python-six from
here ...
[propagated-inputs]: ... to here.

doc: Fix inappropriate escapes.

* doc/guix.texi (Shells Home Services): Change \" to ".

gnu: Add spike.

* gnu/packages/virtualization.scm (spike): New variable.

Signed-off-by: Efraim Flashner <efraim@flashner.co.il>

gnu: cl-find-port: Update to 0.1-2.811727f and use git-version.

* gnu/packages/lisp-xyz.scm (cl-find-port): Update to 0.1-2.811727f.
[version]: Use git-version.

Signed-off-by: Raghav Gururajan <rg@raghavgururajan.name>

gnu: janet: Update to 1.20.0.

* gnu/packages/lisp.scm (janet): Update to 1.20.0.

Signed-off-by: Raghav Gururajan <rg@raghavgururajan.name>

gnu: linux-libre 4.9: Update to 4.9.306.

* gnu/packages/linux.scm (linux-libre-4.9-version): Update to 4.9.306.
(linux-libre-4.9-pristine-source): Update hash.

gnu: linux-libre 4.14: Update to 4.14.271.

* gnu/packages/linux.scm (linux-libre-4.14-version): Update to 4.14.271.
(linux-libre-4.14-pristine-source): Update hash.

gnu: linux-libre 4.19: Update to 4.19.234.

* gnu/packages/linux.scm (linux-libre-4.19-version): Update to 4.19.234.
(linux-libre-4.19-pristine-source): Update hash.

gnu: linux-libre 5.4: Update to 5.4.184.

* gnu/packages/linux.scm (linux-libre-5.4-version): Update to 5.4.184.
(linux-libre-5.4-pristine-source): Update hash.

gnu: linux-libre 5.10: Update to 5.10.105.

* gnu/packages/linux.scm (linux-libre-5.10-version): Update to 5.10.105.
(linux-libre-5.10-pristine-source): Update hash.

gnu: linux-libre 5.15: Update to 5.15.28.

* gnu/packages/linux.scm (linux-libre-5.15-version): Update to 5.15.28.
(linux-libre-5.15-pristine-source): Update hash.

gnu: linux-libre: Update to 5.16.14.

* gnu/packages/linux.scm (linux-libre-5.16-version): Update to 5.16.14.
(linux-libre-5.16-pristine-source): Update hash.

gnu: denemo: Honor TESTS?.

* gnu/packages/music.scm (denemo)[arguments]<#:phases>: Honor TESTS? keyword.

gnu: denemo: Improve package style.

* gnu/packages/music.scm (denemo)[native-inputs]: Remove labels.
[arguments]: Use G-expressions.  Remove trailing #T from phases.

gnu: denemo: Update to 2.6.0.

* gnu/packages/music.scm (denemo): Update to 2.6.0.

gnu: lemonbar-xft: Fix build.

* gnu/packages/wm.scm (lemonbar-xft)[arguments]: Fix the make-flags keyword
that now inherits from the lemonbar gexp make-flags keyword.

gnu: guix-data-service: Update to 0.0.1-30.27c34a9.

* gnu/packages/web.scm (guix-data-service): Update to 0.0.1-30.27c34a9.
[inputs]: Add bash-minimal, move some inputs to ...
[propagated-inputs]: ... here.

gnu: ghc-bsb-http-chunked: Don't run tests when cross-compiling.

* gnu/packages/haskell-web.scm
  (ghc-bsb-http-chunked)[arguments]<#:tests?>: Set to #false when
  cross-compiling.

Signed-off-by: Maxim Cournoyer <maxim.cournoyer@gmail.com>

gnu: extra-cmake-modules: Don't run tests when cross-compiling.

* gnu/packages/kde-frameworks.scm
  (extra-cmake-modules)[arguments]<#:tests?>: Set to #false when
  cross-compiling.

Signed-off-by: Maxim Cournoyer <maxim.cournoyer@gmail.com>

gnu: tdlib: Run tests conditionally.

* gnu/packages/messaging.scm (tdlib)[arguments]: Remove #:tests?
  instead of unconditionally setting it to #t.

Signed-off-by: Maxim Cournoyer <maxim.cournoyer@gmail.com>

gnu: belcard: Run tests conditionally.

* gnu/packages/linphone.scm (belcard)[arguments]: Remove #:tests?
  instead of unconditionally setting it to #t.

Signed-off-by: Maxim Cournoyer <maxim.cournoyer@gmail.com>

gnu: lablgtk: Run tests conditionally.

* gnu/packages/ocaml.scm (lablgtk)[arguments]: Remove #:tests?
instead of unconditionally setting it to #t.
[inputs]: Use new style.

Signed-off-by: Maxim Cournoyer <maxim.cournoyer@gmail.com>
Modified-by: Maxim Cournoyer <maxim.cournoyer@gmail.com>

gnu: Remove python2-promise.

* gnu/packages/python-xyz.scm (python2-promise): Delete variable.
(python-promise)[properties]: Delete field.

gnu: Remove python2-empy.

* gnu/packages/python-xyz.scm (python2-empy): Delete variable.

gnu: libicns: Do not explicitly set TESTS? to #t.

* gnu/packages/image.scm (libicns)[tests?]: Remove argument.
[home-page]: Update.

Signed-off-by: Maxim Cournoyer <maxim.cournoyer@gmail.com>
Modified-by: Maxim Cournoyer <maxim.cournoyer@gmail.com>

gnu: perl-unicode-utf8: Run tests conditionally.

* gnu/packages/perl.scm (perl-unicode-utf8)[arguments]<#:tests?>:
  Set to #false when cross-compiling.

Signed-off-by: Maxim Cournoyer <maxim.cournoyer@gmail.com>

gnu: ecl: Run tests conditionally and please lint.

* gnu/packages/lisp.scm (ecl)[source]: Adjust origin URL.
[inputs]: Add bash-minimal.
[arguments]: Move the comment about failing tests above the deleted check
phase.
[tests?]: Do not explicitly set to #t.
[phases]: Delete trailing #t.
[home-page]: Update.

Co-authored-by: Maxim Cournoyer <maxim.cournoyer@gmail.com>
Signed-off-by: Maxim Cournoyer <maxim.cournoyer@gmail.com>

gnu: go-1.16: Do not run tests when cross-compiling.

* gnu/packages/golang.scm (go-1.16)[arguments]: Remove #:tests?.

Signed-off-by: Maxim Cournoyer <maxim.cournoyer@gmail.com>

gnu: ruby-ffi-rzmq: Honor TESTS?.

* gnu/packages/ruby.scm (ruby-ffi-rzmq)[TESTS?]: Remove argument.
[phases]{check}: Honor TESTS?.

Signed-off-by: Maxim Cournoyer <maxim.cournoyer@gmail.com>

gnu: ruby-yard-with-tests: Run tests conditionally.

* gnu/packages/ruby.scm (ruby-yard-with-tests)[arguments]:
Remove #:tests? instead of unconditionally setting it to #t.
[phases]: Delete trailing #t.
[native-inputs]: Use new style.

Modified-by: Maxim Cournoyer <maxim.cournoyer@gmail.com>
Signed-off-by: Maxim Cournoyer <maxim.cournoyer@gmail.com>

gnu: swi-prolog: Fix cross-compilation.

* gnu/package/prolog.scm (swi-prolog)
[inputs]: Add bash-minimal.  Move perl, pkg-config and texinfo to...
[native-inputs]: ... here.
[tests?]: Remove argument.
[configure-flags]: Set BSD_SIGNALS, PROG_SWIPL, QSORT_R_GNU and CMAKE_HOST_CC
when cross-compiling.
[phases]{fix-cross-references}: New phase.
{delete-failing-tests}: Strip trailing #t and simplify the deletion of the
"save" directory.

Modified-by: Maxim Cournoyer <maxim.cournoyer@gmail.com>
Signed-off-by: Maxim Cournoyer <maxim.cournoyer@gmail.com>

gnu: lean: Update to 3.41.0 and fixes toward cross-compilation.

* gnu/packages/lean.scm (lean): Update to 3.41.0.
[phases]: Remove trailing #t.
[tests?] Set to #false when cross-compiling.
[inputs]: Add bash-minimal.

Co-authored-by: Maxime Devos <maximedevos@telenet.be>

lint: check-tests-true: Allow #:tests? #t for some build systems.

emacs-build-system sets #:tests? #f by default, so the linter shouldn't warn
if #:tests? #t is set for packages using emacs-build-system.  Likewise for
texlive-build-system.

* guix/lint.scm (check-tests-true): Do not warn if the build system
  is emacs-build-system or texlive-build-system.
* tests/lint.scm
  ("tests-true: #:tests? #t acceptable for emacs packages")
  ("tests-true: #:tests? #t acceptable for texlive packages"): New tests.

Fixes: <https://issues.guix.gnu.org/50299>
Reported-by: Maxim Cournoyer <maxim.cournoyer@gmail.com>
Signed-off-by: Maxim Cournoyer <maxim.cournoyer@gmail.com>

gnu: eog-plugins: Symlink eog plugins into 'share/eog/plugins'.

Fixes <https://issues.guix.gnu.org/54283>.

* gnu/packages/gnome.scm (eog-plugins)[arguments]: Add 'fix-plugins-path' phase.

gnu: eog: Wrap with gsettings schemas.

* gnu/packages/gnome.scm (eog)[arguments]: Add #:glib-or-gtk? #t.

gnu: ucsim: Update to 0.7.1.

* gnu/packages/embedded.scm (ucsim): Update to 0.7.1.
[source]: Update URI.
[arguments]<#:configure-flags>: Remove as all stable ports are now built by
default.
<#:phases>: Remove obsolete "remove-empty-directory" phase.
[inputs]: Add ncurses, needed for the serialview utility.
[native-inputs]: Add sdcc when needed for tests.
[description]: Update to mention newly supported microcontroller families.

Signed-off-by: Ludovic Courtès <ludo@gnu.org>

gnu: ucsim: Don't explicitly return #t from phases.

* gnu/packages/embedded.scm (ucsim)[arguments]: Don't explicitly return #t
from phases.

Signed-off-by: Ludovic Courtès <ludo@gnu.org>

gnu: Add webp-pixbuf-loader.

* gnu/packages/gtk.scm (webp-pixbuf-loader): New variable.

Signed-off-by: Ludovic Courtès <ludo@gnu.org>

gnu: transfig: Fix "multiple definition" errors with GCC 10+.

* gnu/packages/patches/transfig-gcc10-fno-common.patch: New patch.
* gnu/local.mk (dist_patch_DATA): Add it.
* gnu/packages/xfig.scm (transfig)[source]<origin>: Use patch
"transfig-gcc10-fno-common.patch" to avoid "multiple definition" errors with
GCC 10+ and "-f-no-common".

Signed-off-by: Ludovic Courtès <ludo@gnu.org>

gnu: transfig: Avoid "ar" option incompatibility with binutils 2.36.

Fixes <https://issues.guix.gnu.org/53425>.

* gnu/packages/xfig.scm (transfig)[arguments]<#:phases>: Remove "l" option
from "ar" invocation in makefiles to avoid incompatible meaning in binutils
2.36 causing error "ar: libdeps specified more than once".

Signed-off-by: Ludovic Courtès <ludo@gnu.org>

gnu: icedove: Update to 91.7 [fixes CVE-2022-26386].

* gnu/packages/gnuzilla.scm (icedove): Update to 91.7.

gnu: giac: Use G-expressions.

* gnu/packages/algebra.scm (giac)[arguments]: Use G-expressions.

gnu: giac: Update to 1.7.0-51.

* gnu/packages/algebra.scm (giac): Update to 1.7.0-51.

gnu: xlockmore: Improve package style.

* gnu/packages/xdisorg.scm (xlockmore)[arguments]: Use G-expressions.
[inputs]: Remove labels.

gnu: xlockmore: Update to 5.68.

[1. text/patch]
From ac1f8cc2f6d3bcaa46ec6244e7b1995b8eb27be2 Mon Sep 17 00:00:00 2001
From: Jai Vetrivelan <jaivetrivelan@gmail.com>
Date: Sat, 5 Mar 2022 11:25:25 +0530
Subject: [PATCH] gnu: xlockmore: Update to 5.68.

* gnu/packages/xdisorg.scm (xlockmore): Update to 5.68.

Signed-off-by: Nicolas Goaziou <mail@nicolasgoaziou.fr>

gnu: dmenu: Update to 5.1.

[1. text/patch]
From be477cb5402da42ced667a06e4f503da5ba751f8 Mon Sep 17 00:00:00 2001
From: Jai Vetrivelan <jaivetrivelan@gmail.com>
Date: Sat, 5 Mar 2022 11:18:36 +0530
Subject: [PATCH] gnu: dmenu: Update to 5.1.

* gnu/packages/suckless.scm (dmenu): Update to 5.1.

Signed-off-by: Nicolas Goaziou <mail@nicolasgoaziou.fr>

gnu: lemonbar: Use G-expressions.

* gnu/packages/wm.scm (lemonbar)[arguments]: Use G-expressions.

gnu: lemonbar: Update to 1.4.

[1. text/patch]
From dedefb5d5f0389d1e6fb190c9d47a6f8ca398791 Mon Sep 17 00:00:00 2001
From: Jai Vetrivelan <jaivetrivelan@gmail.com>
Date: Sat, 5 Mar 2022 11:17:57 +0530
Subject: [PATCH] gnu: lemonbar: Update to 1.4.

* gnu/packages/wm.scm (lemonbar): Update to 1.4.

Signed-off-by: Nicolas Goaziou <mail@nicolasgoaziou.fr>

gnu: xbanish: Update to 1.8.

[1. text/patch]
From 0fa4c02dd23bbb4567e2ba4f606ad0a481354d8e Mon Sep 17 00:00:00 2001
From: Jai Vetrivelan <jaivetrivelan@gmail.com>
Date: Sat, 5 Mar 2022 11:17:09 +0530
Subject: [PATCH] gnu: xbanish: Update to 1.8.

* gnu/packages/xdisorg.scm (xbanish): Update to 1.8.

Signed-off-by: Nicolas Goaziou <mail@nicolasgoaziou.fr>

gnu: xdotool: Update to 3.20211022.1.

[1. text/patch]
From 1040dbabc8cb5af1c88262492cf74cb74c859caa Mon Sep 17 00:00:00 2001
From: Jai Vetrivelan <jaivetrivelan@gmail.com>
Date: Sat, 5 Mar 2022 11:16:25 +0530
Subject: [PATCH] gnu: xdotool: Update to 3.20211022.1.

* gnu/packages/xdisorg.scm (xdotool): Update to 3.20211022.1.

Signed-off-by: Nicolas Goaziou <mail@nicolasgoaziou.fr>

gnu: font-sarasa-gothic: Update to 0.36.0.

[1. text/patch]
From 6dd537e7d58ffb1eead78120b12bb896a9032631 Mon Sep 17 00:00:00 2001
From: Jai Vetrivelan <jaivetrivelan@gmail.com>
Date: Sat, 5 Mar 2022 11:14:46 +0530
Subject: [PATCH] gnu: font-sarasa-gothic: Update to 0.36.0.

* gnu/packages/fonts.scm (font-sarasa-gothic): Update to 0.36.0.

Signed-off-by: Nicolas Goaziou <mail@nicolasgoaziou.fr>

gnu: Add libxcrypt.

* gnu/packages/crypto.scm (libxcrypt): New variable.

Signed-off-by: Nicolas Goaziou <mail@nicolasgoaziou.fr>

gnu: tio: Update to 1.35.

* gnu/packages/terminals.scm (tio): Update to 1.35.
[build-system]: Switch to MESON-BUILD-SYSTEM.

Note: the build system changed to meson in the following commit:
https://github.com/tio/tio/commit/e9208d693ee21a062dc2b3f2dd16a9d6b8926b90
Signed-off-by: Nicolas Goaziou <mail@nicolasgoaziou.fr>

gnu: mblaze: Use G-expressions.

* gnu/packages/mail.scm (mblaze)[arguments]: Use G-expressions.

gnu: mblaze: Enable tests.

* gnu/packages/mail.scm (mblaze)[arguments]: Enable tests
and remove comment about broken tests since tests are not broken.

See <https://github.com/leahneukirchen/mblaze/issues/221>.

Signed-off-by: Nicolas Goaziou <mail@nicolasgoaziou.fr>

gnu: sdcc: Update to 4.2.0.

* gnu/packages/embedded.scm (sdcc): Update to 4.2.0.
[description]: Update to mention the newly supported MOS 6502.
* gnu/packages/patches/sdcc-disable-non-free-code.patch: Update to match new
version.

Signed-off-by: Nicolas Goaziou <mail@nicolasgoaziou.fr>

gnu: sdcc: Build debugger with readline support.

* gnu/packages/embedded.scm (sdcc)[inputs]: Add readline.

Signed-off-by: Nicolas Goaziou <mail@nicolasgoaziou.fr>

gnu: sdcc: Remove input labels.

* gnu/packages/embedded.scm (sdcc)[native-inputs]: Remove input labels.

Signed-off-by: Nicolas Goaziou <mail@nicolasgoaziou.fr>

services: openssh: Change 'authorized-keys' accessor name.

* gnu/services/ssh.scm (<openssh-configuration>)[authorized-keys]:
Rename accessor to 'openssh-configuration-authorized-keys'.
(openssh-activation, extend-openssh-authorized-keys): Adjust
accordingly.

services: startup: Add description.

* gnu/services.scm (hurd-startup-service-type)[description]: New field.

services: secret-service: Do not generate SSH and Guix key pairs.

The justification about the order of activation snippets given in the
comment had been obsolete since
39e3b4b7cee175a3c1f37329744c582528d55f5d.

Lately, running the activation snippets for "ssh-keygen -A" and "guix
archive --generate-key" would take a little bit too long, thereby
preventing the childhurd from starting on time.

* gnu/services/virtualization.scm (secret-service-operating-system):
Clear 'generate-host-keys?' and 'generate-substitute-key?'.

services: openssh: Add 'generate-host-keys?' field.

* gnu/services/ssh.scm (<openssh-configuration>)[generate-host-keys?]:
New field.
(openssh-activation): Honor it.
* doc/guix.texi (Networking Services): Document it.

services: guix: Add 'generate-substitute-key?' field.

* gnu/services/base.scm (<guix-configuration>)[generate-substitute-key?]:
New field.
(guix-activation): Honor it.
* doc/guix.texi (Base Services): Document it.

gnu: python-robotframework: Do not embed a timestamp in the user guide.

* gnu/packages/patches/python-robotframework-source-date-epoch.patch: Update
patch to cover for the user guide.

gnu: Add fcitx5-anthy.

* gnu/packages/fcitx5.scm (fcitx5-anthy): New variable.

Signed-off-by: Nicolas Goaziou <mail@nicolasgoaziou.fr>

gnu: nheko: Update to 0.9.2.

* gnu/packages/messaging.scm (nheko): Update to 0.9.2.
[native-inputs]: Add asciidoc.

gnu: mtxclient: Update to 0.7.0.

* gnu/packages/messaging.scm (mtxclient): Update to 0.7.0.

gnu: coeurl: Update to 0.2.0.

* gnu/packages/curl.scm (coeurl): Update to 0.2.0.

gnu: emacs-debbugs: Update to 0.31.

* gnu/packages/emacs-xyz.scm (emacs-debbugs): Update to 0.31.

gnu: linux-libre: Update to 5.16.13.

* gnu/packages/linux.scm (linux-libre-version, linux-libre-gnu-revision,
linux-libre-pristine-source, linux-libre-source, linux-libre,
linux-libre-with-bpf): Use 5.16.

gnu: cl-reexport: Several fixes.

* gnu/packages/lisp-xyz.scm (sbcl-cl-reexport)[source]: Hardcode URL.
  [inputs]: Use new style.
  [synopsis, description]: Fix them.

gnu: cl-assoc-utils: Fix tests.

* gnu/packages/lisp-xyz.scm (sbcl-assoc-utils)[arguments]: Add 'asd-systems'
  parameter. Enable tests.

Signed-off-by: Guillaume Le Vaillant <glv@posteo.net>

gnu: cl-locale: Fix tests.

* gnu/packages/lisp-xyz.scm (sbcl-cl-locale)[arguments]: Add 'asd-systems'
  parameter. Enable tests.

Signed-off-by: Guillaume Le Vaillant <glv@posteo.net>

gnu: cl-mito: Fix tests.

* gnu/packages/lisp-xyz.scm (sbcl-mito)[arguments]: Add 'asd-systems'
  parameter. Enable tests.

Signed-off-by: Guillaume Le Vaillant <glv@posteo.net>

gnu: cl-cookie: Fix tests.

* gnu/packages/lisp-xyz.scm (sbcl-cl-cookie)[arguments]: Add 'asd-systems'
  parameter. Enable tests.

Signed-off-by: Guillaume Le Vaillant <glv@posteo.net>

gnu: cl-http-body: Fix tests.

* gnu/packages/lisp-xyz.scm (sbcl-http-body)[native-inputs]: Add
  trivial-utf-8.
  [arguments]: Add 'asd-systems' parameter. Enable tests.

Signed-off-by: Guillaume Le Vaillant <glv@posteo.net>

gnu: cl-fast-http: Fix tests.

* gnu/packages/lisp-xyz.scm (sbcl-fast-http)[arguments]: Add 'asd-systems'
  parameter. Enable tests.

Signed-off-by: Guillaume Le Vaillant <glv@posteo.net>

gnu: cl-smart-buffer: Fix tests.

* gnu/packages/lisp-xyz.scm (sbcl-smart-buffer)[native-inputs]: Add babel.
  [arguments]: Add 'asd-systems' parameter. Enable tests.

Signed-off-by: Guillaume Le Vaillant <glv@posteo.net>

gnu: cl-xsubseq: Fix tests.

* gnu/packages/lisp-xyz.scm (sbcl-xsubseq)[arguments]: Add 'asd-systems'
  parameter. Enable tests.

Signed-off-by: Guillaume Le Vaillant <glv@posteo.net>

gnu: cl-myway: Fix tests.

* gnu/packages/lisp-xyz.scm (sbcl-myway)[arguments]: Add 'asd-systems'
  parameter. Enable tests.

Signed-off-by: Guillaume Le Vaillant <glv@posteo.net>

gnu: cl-proc-parse: Fix tests.

* gnu/packages/lisp-xyz.scm (sbcl-proc-parse)[arguments]: Add 'asd-systems'
  parameter. Enable tests.

Signed-off-by: Guillaume Le Vaillant <glv@posteo.net>

gnu: Add r-ensdb-hsapiens-v86.

* gnu/packages/bioconductor.scm (r-ensdb-hsapiens-v86): New variable.

gnu: Add r-ensdb-mmusculus-v79.

* gnu/packages/bioconductor.scm (r-ensdb-mmusculus-v79): New variable.

home: symlink-manager: Rename "path" to "file" where appropriate.

* gnu/home/services/symlink-manager.scm (update-symlinks-script):
[home-path]: Rename to...
[home-directory]: ... this.  Adjust users.
[backup-dir]: Rename to...
[backup-directory]: ... this.  Adjust user.
[get-target-path]: Rename to...
[target-file]: ... this.  Adjust users.
[get-backup-path]: Remove.
[backup-file]: Inline it.
[cleanup-symlinks](get-source-path): Rename to...
(source-file): ... this.  Adjust users.
Rename 'he-path' to 'home' and 'new-he-path' to 'pivot'.

home: symlink-manager: 'create-symlinks' uses 'file-system-fold'.

This removes the need for two intermediate representations of the file
tree.

* gnu/home/services/symlink-manager.scm (update-symlinks-script)
[simplify-file-tree, file-tree-traverse]: Remove.
[create-symlinks]: Rewrite in terms of 'file-system-fold'.

home: symlink-manager: 'cleanup-symlinks' uses 'file-system-fold'.

* gnu/home/services/symlink-manager.scm (update-symlinks-script)[cleanup-symlinks]:
Take a home generation and iterate over its config files directly with
'file-system-fold'.  Adjuster caller accordingly.  Remove 'old-tree'.

tests: Check 'guix home reconfigure' for a second generation.

* tests/guix-home.sh: Invoke "guix home reconfigure" a second time with
a modify config file and check the result.

tests: Simplify use of 'local-file' in 'tests/guix-home.sh'.

* tests/guix-home.sh: Remove 'current-filename' trickery since
'local-file' resolves file names relative to the containing file.

tests: Make sure 'guix home reconfigure' backs up files.

* tests/guix-home.sh: Create ~/.bashrc and ~/.config/test.conf prior to
'reconfigure' and check whether they were backed up.

home: symlink-manager: Avoid extra 'lstat' call.

* gnu/home/services/symlink-manager.scm (update-symlinks-script)[symlink-to-store?]:
Avoid extra 'lstat' call.

home: symlink-manager: Remove 'empty-directory?' and avoid TOCTTOU race.

This removes three 'stat' syscalls.

* gnu/home/services/symlink-manager.scm (update-symlinks-script)[empty-directory?]:
Remove.
[cleanup-symlinks]: Replace use of 'file-exists?', 'file-is-directory?',
and 'empty-directory?' by a single 'rmdir' call.

home: symlink-manager: Use 'file-is-directory?'.

* gnu/home/services/symlink-manager.scm (update-symlinks-script)[directory?]:
Remove.
Change callers to use 'file-is-directory?' instead.

home: symlink-manager: Use 'for-each' when used for effects.

* gnu/home/services/symlink-manager.scm (update-symlinks-script)[cleanup-symlinks]
[create-symlinks]: Use 'for-each' instead of 'map'.

home: symlink-manager: Move helper procedures as top-level defines.

* gnu/home/services/symlink-manager.scm (update-symlinks-script): Remove
'config-home', which is unused.  Move 'home-path', 'backup-dir',
'get-target-path', 'get-backup-path', 'directory?', 'empty-directory?',
'symlink-to-store?', and 'backup-file' to the top level.  Move
'create-symlinks' and 'cleanup-symlinks' to the top level as well, and
add parameters.  Adjust callers.

home: symlink-manager: Clarify module imports.

* gnu/home/services/symlink-manager.scm (update-symlinks-script): Wrap
body in 'with-imported-modules'.  Move (guix build utils) import to the
top.  Move #$%initialize-gettext after definitions.