guix package: 'transaction-upgrade-entry' swallows build requests.
authorLudovic Courtès <ludo@gnu.org>
Mon, 30 Mar 2020 20:11:54 +0000 (22:11 +0200)
committerLudovic Courtès <ludo@gnu.org>
Mon, 30 Mar 2020 22:06:36 +0000 (00:06 +0200)
commita187cc562890895ad41dfad00eb1d5c4a4b00936
treeff690f391b51cd4b6fd4c6389e3d913c4b6c73dc
parent190ddfe21e3d87719733d12fb9b5eb176125a49f
guix package: 'transaction-upgrade-entry' swallows build requests.

Fixes a regression introduced in
131f50cdc9dbb7183023f4dae759876a9e700bef whereby the install/upgrade
message would not be displayed:

  $ guix upgrade -n
  2.1 MB would be downloaded:
     /gnu/store/…-something-1.2
     /gnu/store/…-its-dependency-2.3

This is because we'd directly abort from 'transaction-upgrade-entry' to
the build handler of 'build-notifier'.

* guix/scripts/package.scm (transaction-upgrade-entry): Call 'string=?'
expression in 'with-build-handler'.
* tests/packages.scm ("transaction-upgrade-entry, grafts"): New test.
guix/scripts/package.scm
tests/packages.scm