daemon: Make 'profiles/per-user' non-world-writable.
authorLudovic Courtès <ludo@gnu.org>
Wed, 16 Oct 2019 09:51:42 +0000 (11:51 +0200)
committerLudovic Courtès <ludo@gnu.org>
Wed, 16 Oct 2019 20:53:40 +0000 (22:53 +0200)
commit81c580c8664bfeeb767e2c47ea343004e88223c7
tree682678e9f32fd6c38f78ccd5cd2ab58ee736e1be
parenta1aaca314ca94700ebe3449d6bd73522f2d243bc
daemon: Make 'profiles/per-user' non-world-writable.

Fixes <https://bugs.gnu.org/37744>.
Reported at <https://www.openwall.com/lists/oss-security/2019/10/09/4>.

Based on Nix commit 5a303093dcae1e5ce9212616ef18f2ca51020b0d
by Eelco Dolstra <edolstra@gmail.com>.

* nix/libstore/local-store.cc (LocalStore::LocalStore): Set 'perUserDir'
to #o755 instead of #o1777.
(LocalStore::createUser): New function.
* nix/libstore/local-store.hh (LocalStore): Add it.
* nix/libstore/store-api.hh (StoreAPI): Add it.
* nix/nix-daemon/nix-daemon.cc (performOp): In 'wopSetOptions', add
condition to handle "user-name" property and honor it.
(processConnection): Add 'userId' parameter.  Call 'store->createUser'
when userId is not -1.
* guix/profiles.scm (ensure-profile-directory): Note that this is now
handled by the daemon.
* guix/store.scm (current-user-name): New procedure.
(set-build-options): Add #:user-name parameter and pass it to the daemon.
* tests/guix-daemon.sh: Test the creation of 'profiles/per-user' when
listening on a TCP socket.
* tests/store.scm ("profiles/per-user exists and is not writable")
("profiles/per-user/$USER exists"): New tests.
guix/profiles.scm
guix/store.scm
nix/libstore/local-store.cc
nix/libstore/local-store.hh
nix/libstore/store-api.hh
nix/nix-daemon/nix-daemon.cc
tests/guix-daemon.sh
tests/store.scm