X-Git-Url: http://git.hcoop.net/hcoop/portal.git/blobdiff_plain/99061f2263e20bc8c2c41c529fb25bc45f80e5ae..64264243ac899669f55285e53a5ba511bbac9340:/sec.mlt

diff --git a/sec.mlt b/sec.mlt
index e6fe245..fd0c55e 100644
--- a/sec.mlt
+++ b/sec.mlt
@@ -2,7 +2,7 @@
 val yourname = Init.getUserName ();
 
 val nodeNum = case $"node" of
-		  "" => 2
+		  "" => 4
 		| node => Web.stoi node;
 val nodeName = Init.nodeName nodeNum;
 
@@ -185,9 +185,9 @@ elseif $"mod" <> "" then
 </select></td> </tr>
 <tr> <td>Node:</td> <td><select name="node">
 <% foreach node in Init.listNodes () do %>
-	<option value="<% #id node %>"<% if nodeNum = #node req then %> selected<% end %>><% Web.html (#name node) %> (<% Web.html (#descr node) %>)</option>
+	<option value="<% #id node %>"<% if #id node = #node req then %> selected<% end %>><% Web.html (#name node) %> (<% Web.html (#descr node) %>)</option>
 <% end %></select></td> </tr>
-<tr> <td>Request:</td> <td><input name="req" value="<% #data req %>"></td> </tr>
+<tr> <td>Request:</td> <td><input name="req" value="<% Web.html (#data req) %>"></td> </tr>
 <tr> <td>Message:</td> <td><textarea name="msg" rows="10" cols="80" wrap="soft"><% Web.html (#msg req) %></textarea></td> </tr>
 <tr> <td><input type="submit" value="Save"></td> </tr>
 </table>
@@ -201,10 +201,8 @@ elseif $"mod" <> "" then
 	val oldStatus = #status req;
 	val newStatus = Sec.Req.statusFromInt (Web.stoi ($"status"));
 	Sec.Req.modify {req with node = nodeNum, data = $"req", msg = $"msg", status = newStatus};
-	if oldStatus <> newStatus then
-		if not (Sec.Req.notifyMod {old = oldStatus, new = newStatus, changer = Init.getUserName(), req = id}) then
-			%><h3>Error sending e-mail notification</h3><%
-		end
+	if not (Sec.Req.notifyMod {old = oldStatus, new = newStatus, changer = Init.getUserName(), req = id}) then
+		%><h3>Error sending e-mail notification</h3><%
 	end
 	%><h3>Request modified</h3>
 	Back to: <a href="sec?cmd=open">open requests</a>, <a href="sec?cmd=list">all requests</a>
@@ -340,11 +338,9 @@ end%>
 
 <h3>Request a new firewall rule</h3>
 
-<p><b>This form isn't needed yet to allow you to use any port.  However, if you request a rule here, you can be sure it will be added when we first implement firewalls on our new servers.  Otherwise, your custom services may stop working.</b></p>
-
-<p>You can find a description of rule formats <a href="http://wiki.hcoop.net/wiki/FirewallRules">on our wiki</a>. Enter here the rule you want, without the initial <tt>user</tt> portion.</p>
+<p>You can find a description of rule formats <a href="http://wiki.hcoop.net/FirewallRules">on our wiki</a>. Enter here the rule you want, without the initial <tt>user</tt> portion.</p>
 
-<p>Please note that <b>your firewall rule will be useless</b> if you don't first request the corresponding socket privileges at the top of this page. Also, common ports like 80 (HTTP) are open to everyone with socket permissions. Verify that you can't access a port after socket permissions have been granted before requesting a special rule here.</p>
+<p>When requesting a <tt>Server</tt> or <tt>ProxiedServer</tt> rule, use a port above <tt>50000</tt> (there is a list of <a href="http://wiki.hcoop.net/wiki/AllocatedFirewallPorts">allocated ports</a>). We may grant <tt>Server</tt> requests for ports under <tt>50000</tt> if it can be justified, but never for a <tt>ProxiedServer</tt>.</p>
 
 <p>We very rarely grant requests for Client rules that don't include remote host whitelists. For example, important security concerns make it a bad idea for us to give anybody blanket IRC permissions. Instead, request specific servers. We will refuse such requests that include networks that are popularly considered fronts for illegal activity.</p>