Commit | Line | Data |
---|---|---|
df27a6a3 | 1 | /* |
cd011f58 AW |
2 | This file is part of Smoothie (http://smoothieware.org/). The motion control part is heavily based on Grbl (https://github.com/simen/grbl). |
3 | Smoothie is free software: you can redistribute it and/or modify it under the terms of the GNU General Public License as published by the Free Software Foundation, either version 3 of the License, or (at your option) any later version. | |
4 | Smoothie is distributed in the hope that it will be useful, but WITHOUT ANY WARRANTY; without even the implied warranty of MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU General Public License for more details. | |
df27a6a3 | 5 | You should have received a copy of the GNU General Public License along with Smoothie. If not, see <http://www.gnu.org/licenses/>. |
cd011f58 AW |
6 | */ |
7 | ||
7b49793d | 8 | // TODO : THIS FILE IS LAME, MUST BE MADE MUCH BETTER |
cd011f58 | 9 | |
ded56b35 AW |
10 | #include "libs/Module.h" |
11 | #include "libs/Kernel.h" | |
12 | #include <math.h> | |
13 | #include "TemperatureControl.h" | |
3c308aeb | 14 | #include "TemperatureControlPool.h" |
3c132bd0 | 15 | #include "libs/Pin.h" |
3c4f2dd8 | 16 | #include "modules/robot/Conveyor.h" |
8293d443 | 17 | #include "PublicDataRequest.h" |
2fa50ca0 | 18 | |
38b9f24a L |
19 | #include "PublicData.h" |
20 | #include "ToolManagerPublicAccess.h" | |
61134a65 JM |
21 | #include "StreamOutputPool.h" |
22 | #include "Config.h" | |
23 | #include "checksumm.h" | |
24 | #include "Gcode.h" | |
61134a65 JM |
25 | #include "SlowTicker.h" |
26 | #include "Pauser.h" | |
8d54c34c | 27 | #include "ConfigValue.h" |
66383b80 | 28 | #include "PID_Autotuner.h" |
ded56b35 | 29 | |
9d955060 | 30 | // Temp sensor implementations: |
31 | #include "Thermistor.h" | |
4710532a | 32 | #include "max31855.h" |
9d955060 | 33 | |
8f91e4e6 MM |
34 | #include "MRI_Hooks.h" |
35 | ||
85eabc50 JM |
36 | #define UNDEFINED -1 |
37 | ||
9d955060 | 38 | #define sensor_checksum CHECKSUM("sensor") |
39 | ||
85eabc50 JM |
40 | #define readings_per_second_checksum CHECKSUM("readings_per_second") |
41 | #define max_pwm_checksum CHECKSUM("max_pwm") | |
42 | #define pwm_frequency_checksum CHECKSUM("pwm_frequency") | |
989d0e94 JM |
43 | #define bang_bang_checksum CHECKSUM("bang_bang") |
44 | #define hysteresis_checksum CHECKSUM("hysteresis") | |
85eabc50 | 45 | #define heater_pin_checksum CHECKSUM("heater_pin") |
bb02929e | 46 | #define max_temp_checksum CHECKSUM("max_temp") |
85eabc50 JM |
47 | |
48 | #define get_m_code_checksum CHECKSUM("get_m_code") | |
49 | #define set_m_code_checksum CHECKSUM("set_m_code") | |
50 | #define set_and_wait_m_code_checksum CHECKSUM("set_and_wait_m_code") | |
51 | ||
52 | #define designator_checksum CHECKSUM("designator") | |
53 | ||
54 | #define p_factor_checksum CHECKSUM("p_factor") | |
55 | #define i_factor_checksum CHECKSUM("i_factor") | |
56 | #define d_factor_checksum CHECKSUM("d_factor") | |
57 | ||
58 | #define i_max_checksum CHECKSUM("i_max") | |
59 | ||
60 | #define preset1_checksum CHECKSUM("preset1") | |
61 | #define preset2_checksum CHECKSUM("preset2") | |
62 | ||
8e8b938e | 63 | TemperatureControl::TemperatureControl(uint16_t name, int index) |
d8baddd9 | 64 | { |
8e8b938e JM |
65 | name_checksum= name; |
66 | pool_index= index; | |
67 | waiting= false; | |
68 | min_temp_violated= false; | |
69 | sensor= nullptr; | |
71cc73eb | 70 | readonly= false; |
d8baddd9 | 71 | } |
ded56b35 | 72 | |
d8baddd9 | 73 | TemperatureControl::~TemperatureControl() |
74 | { | |
75 | delete sensor; | |
76 | } | |
4710532a JM |
77 | |
78 | void TemperatureControl::on_module_loaded() | |
79 | { | |
907d5e8a | 80 | |
81b547a1 | 81 | // We start not desiring any temp |
907d5e8a | 82 | this->target_temperature = UNDEFINED; |
ded56b35 AW |
83 | |
84 | // Settings | |
71cc73eb | 85 | this->load_config(); |
ded56b35 | 86 | |
ded56b35 | 87 | // Register for events |
b0be67b5 | 88 | this->register_for_event(ON_GCODE_RECEIVED); |
8293d443 | 89 | this->register_for_event(ON_GET_PUBLIC_DATA); |
71cc73eb JM |
90 | |
91 | if(!this->readonly) { | |
92 | this->register_for_event(ON_GCODE_EXECUTE); | |
93 | this->register_for_event(ON_SECOND_TICK); | |
94 | this->register_for_event(ON_MAIN_LOOP); | |
95 | this->register_for_event(ON_SET_PUBLIC_DATA); | |
96 | this->register_for_event(ON_HALT); | |
97 | } | |
3d1a4519 JM |
98 | } |
99 | ||
100 | void TemperatureControl::on_halt(void *arg) | |
101 | { | |
728477c4 JM |
102 | if(arg == nullptr) { |
103 | // turn off heater | |
104 | this->o = 0; | |
105 | this->heater_pin.set(0); | |
106 | this->target_temperature = UNDEFINED; | |
107 | } | |
ded56b35 AW |
108 | } |
109 | ||
4710532a JM |
110 | void TemperatureControl::on_main_loop(void *argument) |
111 | { | |
7e57bc2c | 112 | if (this->min_temp_violated) { |
9d955060 | 113 | THEKERNEL->streams->printf("Error: MINTEMP triggered. Check your temperature sensors!\n"); |
7e57bc2c | 114 | this->min_temp_violated = false; |
a7f12bed | 115 | } |
7e57bc2c | 116 | } |
7dd8133c AW |
117 | |
118 | // Get configuration from the config file | |
71cc73eb | 119 | void TemperatureControl::load_config() |
4710532a | 120 | { |
7dd8133c | 121 | |
1306ba99 | 122 | // General config |
314ab8f7 MM |
123 | this->set_m_code = THEKERNEL->config->value(temperature_control_checksum, this->name_checksum, set_m_code_checksum)->by_default(104)->as_number(); |
124 | this->set_and_wait_m_code = THEKERNEL->config->value(temperature_control_checksum, this->name_checksum, set_and_wait_m_code_checksum)->by_default(109)->as_number(); | |
125 | this->get_m_code = THEKERNEL->config->value(temperature_control_checksum, this->name_checksum, get_m_code_checksum)->by_default(105)->as_number(); | |
126 | this->readings_per_second = THEKERNEL->config->value(temperature_control_checksum, this->name_checksum, readings_per_second_checksum)->by_default(20)->as_number(); | |
7dee00e4 | 127 | |
314ab8f7 | 128 | this->designator = THEKERNEL->config->value(temperature_control_checksum, this->name_checksum, designator_checksum)->by_default(string("T"))->as_string(); |
b0be67b5 | 129 | |
7d4baeee AW |
130 | // Max temperature we are not allowed to get over |
131 | this->max_temp = THEKERNEL->config->value(temperature_control_checksum, this->name_checksum, max_temp_checksum)->by_default(1000)->as_number(); | |
132 | ||
71cc73eb JM |
133 | // Heater pin |
134 | this->heater_pin.from_string( THEKERNEL->config->value(temperature_control_checksum, this->name_checksum, heater_pin_checksum)->by_default("nc")->as_string()); | |
135 | if(this->heater_pin.connected()){ | |
136 | this->readonly= false; | |
137 | this->heater_pin.as_output(); | |
138 | ||
139 | } else { | |
140 | this->readonly= true; | |
141 | } | |
142 | ||
d8baddd9 | 143 | // For backward compatibility, default to a thermistor sensor. |
144 | std::string sensor_type = THEKERNEL->config->value(temperature_control_checksum, this->name_checksum, sensor_checksum)->by_default("thermistor")->as_string(); | |
145 | ||
146 | // Instantiate correct sensor (TBD: TempSensor factory?) | |
147 | delete sensor; | |
148 | sensor = nullptr; // In case we fail to create a new sensor. | |
4710532a | 149 | if(sensor_type.compare("thermistor") == 0) { |
d8baddd9 | 150 | sensor = new Thermistor(); |
4710532a | 151 | } else if(sensor_type.compare("max31855") == 0) { |
d8baddd9 | 152 | sensor = new Max31855(); |
4710532a | 153 | } else { |
d8baddd9 | 154 | sensor = new TempSensor(); // A dummy implementation |
155 | } | |
156 | sensor->UpdateConfig(temperature_control_checksum, this->name_checksum); | |
4710532a | 157 | |
71cc73eb JM |
158 | this->preset1 = THEKERNEL->config->value(temperature_control_checksum, this->name_checksum, preset1_checksum)->by_default(0)->as_number(); |
159 | this->preset2 = THEKERNEL->config->value(temperature_control_checksum, this->name_checksum, preset2_checksum)->by_default(0)->as_number(); | |
f4bd4fc3 | 160 | |
907d5e8a | 161 | |
c4f4cf73 | 162 | // sigma-delta output modulation |
b35ac71e | 163 | this->o = 0; |
3c132bd0 | 164 | |
71cc73eb JM |
165 | if(!this->readonly) { |
166 | // used to enable bang bang control of heater | |
167 | this->use_bangbang = THEKERNEL->config->value(temperature_control_checksum, this->name_checksum, bang_bang_checksum)->by_default(false)->as_bool(); | |
168 | this->hysteresis = THEKERNEL->config->value(temperature_control_checksum, this->name_checksum, hysteresis_checksum)->by_default(2)->as_number(); | |
169 | this->heater_pin.max_pwm( THEKERNEL->config->value(temperature_control_checksum, this->name_checksum, max_pwm_checksum)->by_default(255)->as_number() ); | |
170 | this->heater_pin.set(0); | |
171 | set_low_on_debug(heater_pin.port_number, heater_pin.pin); | |
172 | // activate SD-DAC timer | |
173 | THEKERNEL->slow_ticker->attach( THEKERNEL->config->value(temperature_control_checksum, this->name_checksum, pwm_frequency_checksum)->by_default(2000)->as_number(), &heater_pin, &Pwm::on_tick); | |
174 | } | |
8f91e4e6 | 175 | |
907d5e8a | 176 | |
f39da6fe | 177 | // reading tick |
314ab8f7 | 178 | THEKERNEL->slow_ticker->attach( this->readings_per_second, this, &TemperatureControl::thermistor_read_tick ); |
4710532a | 179 | this->PIDdt = 1.0 / this->readings_per_second; |
f39da6fe | 180 | |
907d5e8a | 181 | // PID |
314ab8f7 | 182 | setPIDp( THEKERNEL->config->value(temperature_control_checksum, this->name_checksum, p_factor_checksum)->by_default(10 )->as_number() ); |
1ad23cd3 | 183 | setPIDi( THEKERNEL->config->value(temperature_control_checksum, this->name_checksum, i_factor_checksum)->by_default(0.3f)->as_number() ); |
314ab8f7 | 184 | setPIDd( THEKERNEL->config->value(temperature_control_checksum, this->name_checksum, d_factor_checksum)->by_default(200)->as_number() ); |
71cc73eb JM |
185 | |
186 | if(!this->readonly) { | |
187 | // set to the same as max_pwm by default | |
188 | this->i_max = THEKERNEL->config->value(temperature_control_checksum, this->name_checksum, i_max_checksum )->by_default(this->heater_pin.max_pwm())->as_number(); | |
189 | } | |
190 | ||
10e66797 | 191 | this->iTerm = 0.0; |
4710532a | 192 | this->lastInput = -1.0; |
907d5e8a | 193 | this->last_reading = 0.0; |
7dd8133c AW |
194 | } |
195 | ||
4710532a JM |
196 | void TemperatureControl::on_gcode_received(void *argument) |
197 | { | |
198 | Gcode *gcode = static_cast<Gcode *>(argument); | |
8dfbc976 | 199 | if (gcode->has_m) { |
ee4711d1 | 200 | |
4710532a | 201 | if( gcode->m == this->get_m_code ) { |
93284f6f | 202 | char buf[32]; // should be big enough for any status |
4710532a | 203 | int n = snprintf(buf, sizeof(buf), "%s:%3.1f /%3.1f @%d ", this->designator.c_str(), this->get_temperature(), ((target_temperature == UNDEFINED) ? 0.0 : target_temperature), this->o); |
93284f6f | 204 | gcode->txt_after_ok.append(buf, n); |
a24ab0ac | 205 | gcode->mark_as_taken(); |
71cc73eb JM |
206 | return; |
207 | } | |
8dfbc976 | 208 | |
71cc73eb JM |
209 | // readonly sensors don't handle the rest |
210 | if(this->readonly) return; | |
211 | ||
212 | if (gcode->m == 301) { | |
74b6303c | 213 | gcode->mark_as_taken(); |
4710532a | 214 | if (gcode->has_letter('S') && (gcode->get_value('S') == this->pool_index)) { |
827a49ca | 215 | if (gcode->has_letter('P')) |
201e6dcf | 216 | setPIDp( gcode->get_value('P') ); |
827a49ca | 217 | if (gcode->has_letter('I')) |
201e6dcf | 218 | setPIDi( gcode->get_value('I') ); |
827a49ca | 219 | if (gcode->has_letter('D')) |
201e6dcf | 220 | setPIDd( gcode->get_value('D') ); |
827a49ca MM |
221 | if (gcode->has_letter('X')) |
222 | this->i_max = gcode->get_value('X'); | |
223 | } | |
10e66797 | 224 | //gcode->stream->printf("%s(S%d): Pf:%g If:%g Df:%g X(I_max):%g Pv:%g Iv:%g Dv:%g O:%d\n", this->designator.c_str(), this->pool_index, this->p_factor, this->i_factor/this->PIDdt, this->d_factor*this->PIDdt, this->i_max, this->p, this->i, this->d, o); |
4710532a | 225 | gcode->stream->printf("%s(S%d): Pf:%g If:%g Df:%g X(I_max):%g O:%d\n", this->designator.c_str(), this->pool_index, this->p_factor, this->i_factor / this->PIDdt, this->d_factor * this->PIDdt, this->i_max, o); |
8dfbc976 | 226 | |
4710532a JM |
227 | } else if (gcode->m == 500 || gcode->m == 503) { // M500 saves some volatile settings to config override file, M503 just prints the settings |
228 | gcode->stream->printf(";PID settings:\nM301 S%d P%1.4f I%1.4f D%1.4f\n", this->pool_index, this->p_factor, this->i_factor / this->PIDdt, this->d_factor * this->PIDdt); | |
33e4cc02 JM |
229 | gcode->mark_as_taken(); |
230 | ||
8e8b938e JM |
231 | } else if( ( gcode->m == this->set_m_code || gcode->m == this->set_and_wait_m_code ) && gcode->has_letter('S')) { |
232 | // this only gets handled if it is not controlle dby the tool manager or is active in the toolmanager | |
233 | this->active = true; | |
234 | ||
235 | // this is safe as old configs as well as single extruder configs the toolmanager will not be running so will return false | |
236 | // this will also ignore anything that the tool manager is not controlling and return false, otherwise it returns the active tool | |
237 | void *returned_data; | |
75e6428d | 238 | bool ok = PublicData::get_value( tool_manager_checksum, is_active_tool_checksum, this->name_checksum, &returned_data ); |
8e8b938e JM |
239 | if (ok) { |
240 | uint16_t active_tool_name = *static_cast<uint16_t *>(returned_data); | |
241 | this->active = (active_tool_name == this->name_checksum); | |
242 | } | |
243 | ||
244 | if(this->active) { | |
245 | // Attach gcodes to the last block for on_gcode_execute | |
246 | THEKERNEL->conveyor->append_gcode(gcode); | |
2134bcf2 | 247 | |
8e8b938e JM |
248 | // push an empty block if we have to wait, so the Planner can get things right, and we can prevent subsequent non-move gcodes from executing |
249 | if (gcode->m == this->set_and_wait_m_code) { | |
250 | // ensure that no subsequent gcodes get executed with our M109 or similar | |
251 | THEKERNEL->conveyor->queue_head_block(); | |
252 | } | |
253 | } | |
3c4f2dd8 | 254 | } |
b0be67b5 MM |
255 | } |
256 | } | |
db453125 | 257 | |
4710532a JM |
258 | void TemperatureControl::on_gcode_execute(void *argument) |
259 | { | |
260 | Gcode *gcode = static_cast<Gcode *>(argument); | |
261 | if( gcode->has_m) { | |
cf1a7632 | 262 | if (((gcode->m == this->set_m_code) || (gcode->m == this->set_and_wait_m_code)) |
4710532a | 263 | && gcode->has_letter('S') && this->active) { |
1ad23cd3 | 264 | float v = gcode->get_value('S'); |
f4bd4fc3 | 265 | |
4710532a | 266 | if (v == 0.0) { |
907d5e8a | 267 | this->target_temperature = UNDEFINED; |
4710532a JM |
268 | this->heater_pin.set((this->o = 0)); |
269 | } else { | |
f4bd4fc3 | 270 | this->set_desired_temperature(v); |
cf1a7632 | 271 | |
7dc903db | 272 | if( gcode->m == this->set_and_wait_m_code && !this->waiting) { |
314ab8f7 | 273 | THEKERNEL->pauser->take(); |
cf1a7632 MM |
274 | this->waiting = true; |
275 | } | |
907d5e8a | 276 | } |
df27a6a3 | 277 | } |
df27a6a3 | 278 | } |
ded56b35 AW |
279 | } |
280 | ||
4710532a JM |
281 | void TemperatureControl::on_get_public_data(void *argument) |
282 | { | |
283 | PublicDataRequest *pdr = static_cast<PublicDataRequest *>(argument); | |
201e6dcf | 284 | |
b19aa09d JM |
285 | if(!pdr->starts_with(temperature_control_checksum)) return; |
286 | ||
8e8b938e JM |
287 | if(pdr->second_element_is(pool_index_checksum)) { |
288 | // asking for our instance pointer if we have this pool_index | |
289 | if(pdr->third_element_is(this->pool_index)) { | |
290 | static void *return_data; | |
291 | return_data = this; | |
292 | pdr->set_data_ptr(&return_data); | |
293 | pdr->set_taken(); | |
294 | } | |
295 | return; | |
296 | ||
297 | }else if(!pdr->second_element_is(this->name_checksum)) return; | |
b19aa09d JM |
298 | |
299 | // ok this is targeted at us, so send back the requested data | |
300 | if(pdr->third_element_is(current_temperature_checksum)) { | |
2fa50ca0 JM |
301 | this->public_data_return.current_temperature = this->get_temperature(); |
302 | this->public_data_return.target_temperature = (target_temperature == UNDEFINED) ? 0 : this->target_temperature; | |
303 | this->public_data_return.pwm = this->o; | |
304 | this->public_data_return.designator= this->designator; | |
305 | pdr->set_data_ptr(&this->public_data_return); | |
b19aa09d JM |
306 | pdr->set_taken(); |
307 | } | |
8e8b938e | 308 | |
8293d443 | 309 | } |
db453125 | 310 | |
4710532a JM |
311 | void TemperatureControl::on_set_public_data(void *argument) |
312 | { | |
313 | PublicDataRequest *pdr = static_cast<PublicDataRequest *>(argument); | |
77047e76 | 314 | |
991d98cc | 315 | if(!pdr->starts_with(temperature_control_checksum)) return; |
77047e76 | 316 | |
8e8b938e | 317 | if(!pdr->second_element_is(this->name_checksum)) return; |
77047e76 | 318 | |
991d98cc | 319 | // ok this is targeted at us, so set the temp |
4710532a | 320 | float t = *static_cast<float *>(pdr->get_data_ptr()); |
991d98cc JM |
321 | this->set_desired_temperature(t); |
322 | pdr->set_taken(); | |
77047e76 JM |
323 | } |
324 | ||
1ad23cd3 | 325 | void TemperatureControl::set_desired_temperature(float desired_temperature) |
cf1a7632 | 326 | { |
7d4baeee AW |
327 | // Never go over the configured max temperature |
328 | if( desired_temperature > this->max_temp ){ | |
329 | desired_temperature = this->max_temp; | |
330 | } | |
331 | ||
cf1a7632 MM |
332 | if (desired_temperature == 1.0) |
333 | desired_temperature = preset1; | |
334 | else if (desired_temperature == 2.0) | |
335 | desired_temperature = preset2; | |
336 | ||
907d5e8a | 337 | target_temperature = desired_temperature; |
959dc7db | 338 | if (desired_temperature == 0.0) |
b35ac71e | 339 | heater_pin.set((this->o = 0)); |
ded56b35 AW |
340 | } |
341 | ||
4710532a JM |
342 | float TemperatureControl::get_temperature() |
343 | { | |
907d5e8a | 344 | return last_reading; |
ded56b35 AW |
345 | } |
346 | ||
4710532a JM |
347 | uint32_t TemperatureControl::thermistor_read_tick(uint32_t dummy) |
348 | { | |
9d955060 | 349 | float temperature = sensor->get_temperature(); |
71cc73eb JM |
350 | if(this->readonly) { |
351 | last_reading = temperature; | |
352 | return 0; | |
353 | } | |
907d5e8a | 354 | |
4710532a JM |
355 | if (target_temperature > 0) { |
356 | if (isinf(temperature)) { | |
7e57bc2c | 357 | this->min_temp_violated = true; |
907d5e8a | 358 | target_temperature = UNDEFINED; |
4710532a JM |
359 | heater_pin.set((this->o = 0)); |
360 | } else { | |
907d5e8a | 361 | pid_process(temperature); |
4710532a | 362 | if ((temperature > target_temperature) && waiting) { |
347854ff | 363 | THEKERNEL->pauser->release(); |
907d5e8a | 364 | waiting = false; |
81b547a1 | 365 | } |
ded56b35 | 366 | } |
4710532a | 367 | } else { |
b35ac71e | 368 | heater_pin.set((this->o = 0)); |
959dc7db | 369 | } |
907d5e8a | 370 | last_reading = temperature; |
281967e4 | 371 | return 0; |
ded56b35 AW |
372 | } |
373 | ||
10e66797 JM |
374 | /** |
375 | * Based on https://github.com/br3ttb/Arduino-PID-Library | |
376 | */ | |
1ad23cd3 | 377 | void TemperatureControl::pid_process(float temperature) |
907d5e8a | 378 | { |
989d0e94 | 379 | if(use_bangbang) { |
b35ac71e | 380 | // bang bang is very simple, if temp is < target - hysteresis turn on full else if temp is > target + hysteresis turn heater off |
989d0e94 | 381 | // good for relays |
4710532a | 382 | if(temperature > (target_temperature + hysteresis) && this->o > 0) { |
989d0e94 | 383 | heater_pin.set(false); |
4710532a | 384 | this->o = 0; // for display purposes only |
989d0e94 | 385 | |
4710532a | 386 | } else if(temperature < (target_temperature - hysteresis) && this->o <= 0) { |
989d0e94 JM |
387 | if(heater_pin.max_pwm() >= 255) { |
388 | // turn on full | |
389 | this->heater_pin.set(true); | |
4710532a JM |
390 | this->o = 255; // for display purposes only |
391 | } else { | |
989d0e94 JM |
392 | // only to whatever max pwm is configured |
393 | this->heater_pin.pwm(heater_pin.max_pwm()); | |
4710532a | 394 | this->o = heater_pin.max_pwm(); // for display purposes only |
989d0e94 | 395 | } |
989d0e94 JM |
396 | } |
397 | return; | |
398 | } | |
ded56b35 | 399 | |
989d0e94 JM |
400 | // regular PID control |
401 | float error = target_temperature - temperature; | |
10e66797 JM |
402 | this->iTerm += (error * this->i_factor); |
403 | if (this->iTerm > this->i_max) this->iTerm = this->i_max; | |
404 | else if (this->iTerm < 0.0) this->iTerm = 0.0; | |
ded56b35 | 405 | |
4710532a JM |
406 | if(this->lastInput < 0.0) this->lastInput = temperature; // set first time |
407 | float d = (temperature - this->lastInput); | |
ded56b35 | 408 | |
10e66797 JM |
409 | // calculate the PID output |
410 | // TODO does this need to be scaled by max_pwm/256? I think not as p_factor already does that | |
4710532a | 411 | this->o = (this->p_factor * error) + this->iTerm - (this->d_factor * d); |
8cdae54c | 412 | |
7dee00e4 | 413 | if (this->o >= heater_pin.max_pwm()) |
7dee00e4 | 414 | this->o = heater_pin.max_pwm(); |
27aecda6 | 415 | else if (this->o < 0) |
907d5e8a MM |
416 | this->o = 0; |
417 | ||
27aecda6 | 418 | this->heater_pin.pwm(this->o); |
4710532a | 419 | this->lastInput = temperature; |
907d5e8a | 420 | } |
ded56b35 | 421 | |
4710532a | 422 | void TemperatureControl::on_second_tick(void *argument) |
8ccab7cf MM |
423 | { |
424 | if (waiting) | |
4710532a | 425 | THEKERNEL->streams->printf("%s:%3.1f /%3.1f @%d\n", designator.c_str(), get_temperature(), ((target_temperature == UNDEFINED) ? 0.0 : target_temperature), o); |
8ccab7cf | 426 | } |
201e6dcf | 427 | |
4710532a JM |
428 | void TemperatureControl::setPIDp(float p) |
429 | { | |
430 | this->p_factor = p; | |
201e6dcf JM |
431 | } |
432 | ||
4710532a JM |
433 | void TemperatureControl::setPIDi(float i) |
434 | { | |
435 | this->i_factor = i * this->PIDdt; | |
201e6dcf JM |
436 | } |
437 | ||
4710532a JM |
438 | void TemperatureControl::setPIDd(float d) |
439 | { | |
440 | this->d_factor = d / this->PIDdt; | |
201e6dcf | 441 | } |