From fa6996bcd4d4c2acc4434e61bc266841c53e9d33 Mon Sep 17 00:00:00 2001 From: Eli Zaretskii Date: Sun, 24 Apr 2011 10:11:56 +0300 Subject: [PATCH] Delete char-direction-table and char-direction. See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00675.html for the reasons. src/character.c (Fchar_direction): Function deleted. (syms_of_character): Don't defsubr it. : Deleted. etc/NEWS: Document the removal. --- etc/NEWS | 9 ++++++++- src/ChangeLog | 6 ++++++ src/character.c | 18 ------------------ 3 files changed, 14 insertions(+), 19 deletions(-) diff --git a/etc/NEWS b/etc/NEWS index aed90764fa..09d54c41d6 100644 --- a/etc/NEWS +++ b/etc/NEWS @@ -134,7 +134,7 @@ image formats in Emacs. By default, Emacs links with the ImageMagick libraries if they are present at build time. This needs ImageMagick 6.2.8 or newer (versions newer than 6.0.7 _may_ work but have not been tested). To disable ImageMagick support, use the configure option -`--without-imagemagick'. +`--without-imagemagick'. The new function `imagemagick-types' returns a list of image file extensions that your installation of ImageMagick supports. The @@ -720,6 +720,13 @@ soap-inspect.el is an interactive inspector for SOAP WSDL structures. * Incompatible Lisp Changes in Emacs 24.1 +--- +** `char-direction-table' and the associated function `char-direction' +were deleted. They were buggy and inferior to the new support of +bidirectional editing introduced in Emacs 24. If you need the +bidirectional properties of a character, use `get-char-code-property' +with the last argument `bidi-class'. + ** `copy-directory' now copies the source directory as a subdirectory of the target directory, if the latter is an existing directory. The new optional arg COPY-CONTENTS, if non-nil, makes the function copy diff --git a/src/ChangeLog b/src/ChangeLog index 831fb6afcd..e939a575c6 100644 --- a/src/ChangeLog +++ b/src/ChangeLog @@ -1,3 +1,9 @@ +2011-04-24 Eli Zaretskii + + * character.c (Fchar_direction): Function deleted. + (syms_of_character): Don't defsubr it. + : Deleted. + 2011-04-23 Eli Zaretskii Fix doprnt so it could be used again safely in `verror'. (Bug#8435) diff --git a/src/character.c b/src/character.c index 6d27371c7e..8bab709480 100644 --- a/src/character.c +++ b/src/character.c @@ -493,19 +493,6 @@ usage: (string-width STRING) */) return val; } -DEFUN ("char-direction", Fchar_direction, Schar_direction, 1, 1, 0, - doc: /* Return the direction of CHAR. -The returned value is 0 for left-to-right and 1 for right-to-left. -usage: (char-direction CHAR) */) - (Lisp_Object ch) -{ - int c; - - CHECK_CHARACTER (ch); - c = XINT (ch); - return CHAR_TABLE_REF (Vchar_direction_table, c); -} - /* Return the number of characters in the NBYTES bytes at PTR. This works by looking at the contents and checking for multibyte sequences while assuming that there's no invalid sequence. @@ -1037,7 +1024,6 @@ syms_of_character (void) defsubr (&Smultibyte_char_to_unibyte); defsubr (&Schar_width); defsubr (&Sstring_width); - defsubr (&Schar_direction); defsubr (&Sstring); defsubr (&Sunibyte_string); defsubr (&Schar_resolve_modifiers); @@ -1066,10 +1052,6 @@ A char-table for width (columns) of each character. */); char_table_set_range (Vchar_width_table, MAX_5_BYTE_CHAR + 1, MAX_CHAR, make_number (4)); - DEFVAR_LISP ("char-direction-table", Vchar_direction_table, - doc: /* A char-table for direction of each character. */); - Vchar_direction_table = Fmake_char_table (Qnil, make_number (1)); - DEFVAR_LISP ("printable-chars", Vprintable_chars, doc: /* A char-table for each printable character. */); Vprintable_chars = Fmake_char_table (Qnil, Qnil); -- 2.20.1