From f42efeb5433369af567d67b304a1aab9e90a7127 Mon Sep 17 00:00:00 2001 From: Michael Albinus Date: Thu, 14 Apr 2011 20:58:45 +0200 Subject: [PATCH] * net/tramp-sh.el (tramp-sh-handle-file-attributes): Handle the case when the scripts fail. Use `tramp-do-file-attributes-with-ls' then. (tramp-do-copy-or-rename-file-out-of-band): Do not check any longer, whether`executable-find' is bound. * net/tramp-smb.el (tramp-smb-handle-copy-file): Fix docstring. --- lisp/ChangeLog | 10 ++++++++++ lisp/net/tramp-sh.el | 23 ++++++++++++----------- lisp/net/tramp-smb.el | 2 +- 3 files changed, 23 insertions(+), 12 deletions(-) diff --git a/lisp/ChangeLog b/lisp/ChangeLog index 0fd851c544..bde1f1174c 100644 --- a/lisp/ChangeLog +++ b/lisp/ChangeLog @@ -1,3 +1,13 @@ +2011-04-14 Michael Albinus + + * net/tramp-sh.el (tramp-sh-handle-file-attributes): Handle the + case when the scripts fail. Use `tramp-do-file-attributes-with-ls' + then. + (tramp-do-copy-or-rename-file-out-of-band): Do not check any + longer, whether`executable-find' is bound. + + * net/tramp-smb.el (tramp-smb-handle-copy-file): Fix docstring. + 2011-04-14 Stefan Monnier * minibuffer.el (completion-in-region-mode-predicate) diff --git a/lisp/net/tramp-sh.el b/lisp/net/tramp-sh.el index ec5c46b289..cb4aca12ed 100644 --- a/lisp/net/tramp-sh.el +++ b/lisp/net/tramp-sh.el @@ -1145,13 +1145,15 @@ target of the symlink differ." (save-excursion (tramp-convert-file-attributes v - (cond - ((tramp-get-remote-stat v) - (tramp-do-file-attributes-with-stat v localname id-format)) - ((tramp-get-remote-perl v) - (tramp-do-file-attributes-with-perl v localname id-format)) - (t - (tramp-do-file-attributes-with-ls v localname id-format))))))))) + (or + (cond + ((tramp-get-remote-stat v) + (tramp-do-file-attributes-with-stat v localname id-format)) + ((tramp-get-remote-perl v) + (tramp-do-file-attributes-with-perl v localname id-format)) + (t nil)) + ;; The scripts could fail, for example with huge file size. + (tramp-do-file-attributes-with-ls v localname id-format)))))))) (defun tramp-do-file-attributes-with-ls (vec localname &optional id-format) "Implement `file-attributes' for Tramp files using the ls(1) command." @@ -2296,10 +2298,9 @@ The method used must be an out-of-band method." (tramp-get-method-parameter method 'tramp-copy-env)))) ;; Check for program. - (when (and (fboundp 'executable-find) - (not (let ((default-directory - (tramp-compat-temporary-file-directory))) - (executable-find copy-program)))) + (unless (let ((default-directory + (tramp-compat-temporary-file-directory))) + (executable-find copy-program)) (tramp-error v 'file-error "Cannot find copy program: %s" copy-program)) diff --git a/lisp/net/tramp-smb.el b/lisp/net/tramp-smb.el index 7e1b0f5b8e..36477f7b43 100644 --- a/lisp/net/tramp-smb.el +++ b/lisp/net/tramp-smb.el @@ -339,7 +339,7 @@ pass to the OPERATION." preserve-uid-gid preserve-selinux-context) "Like `copy-file' for Tramp files. KEEP-DATE is not handled in case NEWNAME resides on an SMB server. -PRESERVE-UID-GID is completely ignored." +PRESERVE-UID-GID and PRESERVE-SELINUX-CONTEXT are completely ignored." (setq filename (expand-file-name filename) newname (expand-file-name newname)) (with-progress-reporter -- 2.20.1