From d36b182f570b08cb54ad484741379430fe874a70 Mon Sep 17 00:00:00 2001 From: Dave Love Date: Thu, 29 May 2003 18:36:16 +0000 Subject: [PATCH] Comment. --- src/alloc.c | 8 +++++++- src/buffer.c | 7 ++++--- 2 files changed, 11 insertions(+), 4 deletions(-) diff --git a/src/alloc.c b/src/alloc.c index 28400ff80e..391d63691c 100644 --- a/src/alloc.c +++ b/src/alloc.c @@ -1393,7 +1393,13 @@ allocate_string_data (s, nchars, nbytes) #ifdef DOUG_LEA_MALLOC /* Prevent mmap'ing the chunk. Lisp data may not be mmap'ed because mapped region contents are not preserved in - a dumped Emacs. */ + a dumped Emacs. + + In case you think of allowing it in a dumped Emacs at the + cost of not being able to re-dump, there's another reason: + mmap'ed data typically have an address towards the top of the + address space, which won't fit into an EMACS_INT (at least on + 32-bit systems with the current tagging scheme). --fx */ mallopt (M_MMAP_MAX, 0); #endif diff --git a/src/buffer.c b/src/buffer.c index 6ec06d84c3..09542fc43a 100644 --- a/src/buffer.c +++ b/src/buffer.c @@ -420,10 +420,11 @@ The value is never nil. */) XSETBUFFER (buf, b); Vbuffer_alist = nconc2 (Vbuffer_alist, Fcons (Fcons (name, buf), Qnil)); - /* Fixme: Protect against errors, which would trigger infinite - regress? */ + /* An error in calling the function here (should someone redfine it) + can lead to infinite regress until you run out of stack. rms + says that's not worth protecting against. */ if (!NILP (Ffboundp (Qucs_set_table_for_input))) - /* buff is on buffer-alist, so no gcpro */ + /* buf is on buffer-alist, so no gcpro. */ call1 (Qucs_set_table_for_input, buf); return buf; -- 2.20.1