Undo last change.

*** empty log message ***

(set-buffer-file-coding-system): Finish previous change.

* gtkutil.c (xg_get_file_name): Fix typo in
  HAVE_GTK_FILE_SELECTION_NEW.

* xmenu.c (x_menu_in_use): Removed.
(x_menu_set_in_use): Also set popup_activated_flag.

* xfns.c (Fx_file_dialog): Call popup_activated instead of
x_menu_in_use.  Call x_menu_set_in_use in Motif version also.

* xterm.h: (x_menu_in_use): Removed.

*** empty log message ***

(Coding Conventions): Separate defvar and require
methods to avoid warnings.  Use require only when there are many
functions and variables from that package.

(Minibuffer Completion): When ignoring case,
predicate must not be case-sensitive.

(Function Debugging, Explicit Debug): Clarified.
(Test Coverage): Don't talk about "splotches".  Clarified.

(iso-tex2iso-trans-tab): Discard spaces after \i according to TeX rules.

(set-buffer-file-coding-system): New arg NOMODIFY.
(after-insert-file-set-coding): Pass that new arg.
Prevent set-buffer-multibyte from trying to lock the file.

(list-buffers-noselect): New arg BUFFER-LIST.

(save-place): Doc fix.

(dabbrev-expand): When handling SPC M-/,
temporarily widen before finding the following word to copy.

(map-keymap): Definition deleted.
(cl-map-keymap): Definition deleted.

(map-keymap-internal): New function.

(Fmap_keymap): New arg SORT-FIRST.  Use
map-keymap-internal to implement that.

(Fvertical_motion): In batch mode, use vmotion directly.

Typo.

(Fdefine_fringe_bitmap): Always set 'h'. Simplify.

(get_glyph_string_clip_rect, init_glyph_string): Check it's
a window before using XWINDOW.

*** empty log message ***

Avoid side-effects inside XSETFASTINT's arguments.

(NILP): Use EQ rather than XFASTINT.

(flyspell-mouse-map): Pop the menu
when pressing rather than when releasing mouse-2.  Simplify.

(find-function-regexp): Optimize `define-minor-mode'.  Add `defun-cvs-mode'.
Add `deffoo'.  Add `f' to [^cgv] to exclude `defface'.
Remove invalid `\W' from [^cgv\W].  Doc fix.
(find-function-search-for-symbol): Replace "\\>" with "\\_>".

(Fvertical_motion): Fix last change.  Only reseat when
moving backwards.

*** empty log message ***

(Window Frame Parameters): Fix typo.

(compilation-setup): Don't set buffer-read-only.
(compilation-mode): Set it here instead.

Use make-symbol rather than gensym.
(loop, cl-parse-loop-clause, defsetf): Use backquote.

(pair-with-newsyms): Use make-symbol.

*** empty log message ***

Maintainer is now FSF.
(life-patterns, life-neighbor-deltas, life-window-start)
(life-current-generation, life-generation-string): Use defvar instead
of defconst.

Extern reseat_at_previous_visible_line_start.

Cleanups.

(display_mode_element): Fix previous change (calculate
end position of substring to display correctly).

(Fposn_at_point): Remove extra */ after doc string.
Reported by Andrew M. Scott.

*** empty log message ***

(compilation-move-to-column): New fun.
(compilation-internal-error-properties)
(compilation-next-error-function): Use it to make sure we don't go past
the end of line.

(auto-insert-alist): Insert the user's name in copyright notice,
rather than Free Software Foundation, for the Emacs Lisp header case
too.

Fix typos & pr-switches-string

(store_mode_line_string, produce_stretch_glyph):
Use Fsafe_plist_get.
(note_mode_line_or_margin_highlight, note_mouse_highlight):
Fix image map element parsing.  Use Fsafe_plist_get.

(Fsafe_plist_get): New defun.
(syms_of_fns): Defsubr it.

(Fsafe_plist_get): Add EXFUN.

*** empty log message ***

(Other Plists): Note that plist-get may signal error.
Add safe-plist-get.

*** empty log message ***

(get_next_display_element): Fix previous change.

(Font Lock Basics): Fix typo.

*** empty log message ***

(math-integrate-by-parts):  Removed unused variable var-thing.

(math-integ-depth, math-integ-level, math-integral-limit)
(math-enable-subst, math-any-substs, math-integ-msg)
(math-prev-parts-v, math-good-parts, math-max-integral-limit)
(math-int-threshold, math-int-factors, math-double-roots)
(math-solve-simplifying, var-IntegLimit, math-solve-sign)
(var-GenCount):  Declared these variables.
(calcFunc-integ):  Don't check if var-IntegLimit is bound.

(math-integral-cache, math-integral-cache-state):  Move declarations
to earlier in the file.

(math-deriv-var, math-deriv-total, math-deriv-symb):  New variables.
(math-derivative, calcFunc-deriv, calcFunc-tderiv):  Replace
variables deriv-var, deriv-total and deriv-symb by declared variables
math-deriv-var, math-deriv-total and math-deriv-symb.

(math-cur-record):  New variable.
(math-integral, math-replace-integral-parts, math-integrate-by-parts)
(calc-dump-integral-cache, math-try-integral):  Replace variable
cur-record by declared variable math-cur-record.

(math-has-rules):  New variable.
(math-try-integral, math-do-integral):  Use declared variable
math-has-rules instead of has-rules.

(math-t1, math-t2, math-t3):  New variables.
(math-do-integral, math-do-integral-methods, math-try-solve-for)
(math-try-solve-prod, math-solve-poly-funny-powers)
(math-solve-crunch-poly, math-decompose-poly)
(math-solve-find-root-term, math-find-root-in-prod):  Replace
variables t1, t2, t3 by declared variables math-t1, math-t2,
math-t3.

(math-so-far, math-integ-expr):  New variables.
(math-do-integral-methods, math-integ-try-linear-substitutions)
(math-integ-try-substitutions):  Replace variables so-far and expr by
declared variables math-so-far and math-integ-expr.

(math-expr-parts):  New variable.
(math-expr-rational-in, math-expr-rational-in-rec):  Replace variable
parts by declared variable math-expr-parts.

(calc-low, calc-high):  New variables.
(calcFunc-table, math-scan-for-limits):  Replaced variable low and
high with the declared variable calc-low and calc-high.

(math-solve-var, math-solve-full):  New variables.
(math-try-solve-for, math-try-solve-prod, math-solve-prod)
(math-decompose-poly, math-solve-quartic, math-poly-all-roots)
(math-solve-find-root-in-prod, math-solve-for, math-solve-system)
(math-solve-system-rec, math-solve-get-sign, math-solve-get-int):
Replace variables solve-var and solve-full with declared variables
math-solve-var and math-solve-full.

(math-solve-vars):  New variable.
(math-solve-system, math-solve-system-rec):  Replace variable
solve-vars with declared variable math-solve-vars.

(math-try-solve-sign):  New variable.
(math-try-solve-for, math-try-solve-prod):  Replace variable
sign by declared variable math-try-solve-sign.

(math-solve-b):  New variable.
(math-solve-poly-funny-powers, math-decompose-poly):  Replace variable
b by declared variable math-solve-b.

(math-solve-system-vv, math-solve-res):  New variables
(math-solve-system-rec, math-solve-system-subst):  Replaced variables
vv and res with declared variables math-solve-system-vv and
math-solve-system-res.

Revision: miles@gnu.org--gnu-2004/emacs--cvs-trunk--0--patch-696

Merge from gnus--rel--5.10

Patches applied:

 * miles@gnu.org--gnu-2004/gnus--rel--5.10--patch-72
   Update from CVS

(compilation-internal-error-properties):
Fix up a transposition-typo.  Check end-col before using it.

*** empty log message ***

(convert-standard-filename): Doc fix.

*** empty log message ***

(nnfolder-save-marks): Add missing format field in call to `error'.

(nnml-save-marks): Add missing format field in call to `error'.

(gnus-convert-old-newsrc): Assign
legacy-gnus-agent to 5.10.7.

(auto-mode-alist): handle .gtkrc, and under /etc passwd, group, shadow, default/* and pam.d/*.

adjust pr-menu-spec

* window.c (shrink_windows): Handle special case of one window left
when trying to shrink the final reminder.  Grow windows if
total_removed is less than total_shrink.

Removed fprintf

* xmenu.c (pop_down_menu): Remove global variable current_menu,
extract pointer from arg with XSAVE_VALUE.
(create_and_show_popup_menu, create_and_show_dialog,
xmenu_show): Construct arg to record_unwind_protect with
make_save_value.

* xfns.c (Fx_file_dialog): Call x_menu_in_use and x_menu_set_in_use.
Record unwind with clean_up_file_dialog.

(winner-active-region, winner-edges, winner-window-list): Define at toplevel.
(winner-mode-map): Move init inside declaration.

Reverse previous change.

*** empty log message ***

(byte-optimize-inline-handler): Simplify.
(byte-decompile-bytecode-1): Remove unused vars `tag' and `retcount'.

extern reseat_at_previous_visible_line_start.

(syms_of_minibuf) <completion-ignore-case>: Doc fix.

(reseat_at_previous_visible_line_start): No longer static.
(get_next_display_element): Fix latest change: applies only to \n.

(Fvertical_motion): Scan to PT from start of line to make iterator consistent.

interactive-p & file permission bits

(font-lock-fontify-syntactically-region): Fix last fix
so it doesn't forget to highlight the beginning of the region either.

* xfns.c (Fx_file_dialog): Call x_menu_in_use and x_menu_set_in_use.
Record unwind with clean_up_file_dialog.

* xterm.h: Declare x_menu_in_use, x_menu_set_in_use,
x_menu_wait_for_event.

* xmenu.c (x_menu_in_use, x_menu_set_in_use): New functions.

Add BLOCK_INPUT in pop_down_file_dialog.

* gtkutil.c (xg_file_sel_ok, xg_file_sel_cancel)
(xg_file_sel_destroy): Removed.
(xg_file_response_cb, pop_down_file_dialog,
xg_get_file_name_from_chooser, xg_get_file_name_from_selector):
New functions.
(xg_get_file_with_chooser, xg_get_file_with_selection): Take
new argument func, set it to xg_get_file_name_from_chooser/selector.
Move common code to xg_get_file_name.  Return widget created.
(xg_get_file_name): Set name, transient for, modal and destroy
with parent here.  Connect response signal to xg_file_response_cb,
connect delete-event to gtk_true.  Record pop_down_file_dialog
for unwind.  Do event loop and call x_menu_wait_for_event in loop.
(xg_create_widget): Make dialogs modal.

*** empty log message ***

(c-basic-common-initc-font-lock-init, c-font-lock-init): Eliminate obsolete make-local-hook.
(c-mode, c++-mode, objc-mode, java-mode, idl-mode, pike-mode, awk-mode): Use run-mode-hooks.

* xmenu.c (unuse_menu_items, pop_down_menu): Arg is of type
Lisp_Object.
(popup_get_selection): Move unwind protect ...
(create_and_show_popup_menu, create_and_show_dialog): ... to here.
Move destroy of widget to pop_down_menu.
(popup_widget_loop): Move unwind protect ...
(create_and_show_popup_menu, create_and_show_dialog): ... to here.
Move destroy of widget to pop_down_menu.
(pop_down_menu): BLOCK_INPUT and destroy widget/window.
(xmenu_show): record unwind pop_down_menu.  Move XMenuDestroy,
x_mouse_leave and grabbed = 0 to pop_down_menu.

Add bug:

** Partial highlighting of wrapped overlay

Fixed these problems:

** Clicking on partially visible lines fails

From: David Kastrup <dak@gnu.org>
Date: 27 Apr 2004 16:42:58 +0200

I had gnus display a mouse-highlighted line (a URL from browse-url)
partially at the bottom of its window.  If I click with middle mouse
key on it, the window gets recentered while I hold the mouse key
pressed.  If I release it, the window returns into its old position
(cursor in top row) and nothing happens, presumably because the click
was not registered on the line itself, but on the magically
recentered version.

That is a nuisance.  Recentering of even partially visible click
targets should only happen if window-point moves there, but not at
the time of the click.  From the moment I hold down a key until it
gets released, the displayed window portion should not change, with
the sole exception of scrolling when dragging at the edge of the
screen.

(progn
  (setq line-spacing 4)
  (dotimes (i (window-height))
    (insert "\n" (int-to-string i)))
  (forward-line -2)
  (recenter -1))

** Can't drag modeline when mouse-autoselect-window is set

From: Klaus Zeitler <kzeitler@lucent.com>
Date: Mon, 11 Oct 2004 11:14:49 +0200

1. start emacs -q --no-site-file
2. set variable mouse-autoselect-window to t
3. split-window-vertically

now I can drag the modeline only upwards but not downwards

(mouse-drag-copy-region): Add :version.
(mouse-drag-mode-line-1): Let bind mouse-autoselect-window to nil
while dragging mode line, so mode line can be dragged downwards.
(mouse-drag-region-1): Let bind make-cursor-line-fully-visible
while pressing mouse button so window doesn't scroll until we
release the mouse if clicking on partially visible line.

*** empty log message ***

(make_cursor_line_fully_visible_p): New variable.
(syms_of_xdisp): DEFVAR_BOOL it.
(make_cursor_line_fully_visible, try_cursor_movement)
(try_window_id): Use it.

*** empty log message ***

run-mode-hooks instead of run-hooks

(calc-dumb-map):  Declared it.
(calc-graph-show-dumb):  Check if calc-dumb-map is non-nil rather than
unbound.

(calc-graph-name):  Made `end' a local variable.

(calc-graph-lookup):  Made `varname' a local variable.

(var-DUMMY, var-DUMMY2, var-PlotRejects, calc-gnuplot-trail-mark):
Declared them.
(calc-graph-format-data):  Don't check if var-PlotRejects is bound.

(calc-graph-plot, calc-graph-compute-3d):  Removed references to the
unused variable y3vec.

(calc-graph-show-dumb):  Removed reference to unused variable found-pt.

(calc-graph-kill-hook, calc-graph-plot):  Removed reference to
calc-graph-prev-kill-hook.

(calc-graph-yvalue, calc-graph-yvec, calc-graph-numsteps,
calc-graph-numsteps3, calc-graph-xvalue, calc-graph-xvec,
calc-graph-xname, calc-graph-yname, calc-graph-xstep,
calc-graph-ycache, calc-graph-ycacheptr, calc-graph-refine,
calc-graph-keep-file, calc-graph-xval, calc-graph-xlow,
calc-graph-xhigh, calc-graph-yval, calc-graph-yp, calc-graph-xp,
calc-graph-zp, calc-graph-yvector, calc-graph-resolution,
calc-graph-y3value, calc-graph-y3name,
calc-graph-y3step, calc-graph-y3step, calc-graph-zval,
calc-graph-stepcount, calc-graph-is-splot, calc-graph-surprise-splot,
calc-graph-blank, calc-graph-non-blank, calc-graph-curve-num):  New
variables.
(calc-graph-plot, calc-graph-compute-2d, calc-graph-refine-2d)
(calc-graph-recompute-2d, calc-graph-compute-3d, calc-graph-format-data):
Replaced undeclared variables with the above declared variables.

ChangeLog

Add a test for DECL_ALIGN support, and add a trivial definition to
src/config.h if 8-byte alignment is not supported.

(rmail-get-new-mail): Use the renamed variables `rsf-beep' and
`rsf-sleep-after-message'.

(rmail-spam-filter): Only check white list if `message-sender' is non-nil.

(desktop-create-buffer, desktop-save): Avoid some consing by using mapc
instead of mapcar.

ChangeLog

Don't require djecho.exe for the v1.x build.

Fixed this bug:

** line-spacing and (recenter -1)

From: SAITO Takuya <tabmore@rivo.mediatti.net>
Date: Mon, 31 May 2004 02:07:57 +0900 (JST)

(recenter -1) does not show point at the bottom of the window
if line-spacing is set to positive integer.

Start emacs -Q, and evaluate below:

(progn
  (setq line-spacing 1)
  (dotimes (i (window-height))
    (insert "\n" (int-to-string i)))
  (recenter -1))

Then, point is displayed at the center of the window.
But point should be displayed at the bottom of the window like Emacs-21.3.

(init_iterator): Clear it.max_extra_line_spacing.
(move_it_vertically_backward): Don't recure to move further back.
(move_it_vertically): Remove superfluous condition.
(move_it_by_lines): Clear last_height when moved 0 lines.
(resize_mini_window): use it.max_extra_line_spacing.
(display_tool_bar_line): Clear row->extra_line_spacing.
(try_scrolling): Use move_it_vertically_backward directly.
(redisplay_window): Likewise.
(compute_line_metrics): Set row->extra_line_spacing.
(display_line, display_string): Likewise.
(x_produce_glyphs): Update it->max_extra_line_spacing.

(window_scroll_pixel_based, Frecenter): Use
move_it_vertically_backward directly.
(Frecenter): Fix calculation of new start pos for negative arg.
Before, the new start pos was sometimes chosen too far back, so
the last line became only partially visible, and thus would be
either only semi-visible or automatically scrolled to the middle
of the window by redisplay.