Juri Linkov [Thu, 28 Feb 2008 22:50:26 +0000 (22:50 +0000)]
Always add initial message to *scratch* buffer if
`initial-scratch-message' is non-nil regardless of the value of
`inhibit-startup-screen'.
(inhibit-startup-screen, initial-scratch-message): Doc fix.
(command-line-1): Move code that inserts `initial-scratch-message'
up before the if-form that checks for `inhibit-startup-screen'.
Suggested by Jonathan Rockway <jon@jrock.us>.
Juri Linkov [Thu, 28 Feb 2008 21:02:45 +0000 (21:02 +0000)]
(hs-minor-mode-menu): Compare `hs-isearch-open' with t instead of
`comment' in :selected for "Code and Comment blocks" menu item.
Juri Linkov [Thu, 28 Feb 2008 20:46:30 +0000 (20:46 +0000)]
(menu-bar-search-menu, menu-bar-replace-menu): Capitalize "Tagged Files".
(minibuffer-local-map): Add menu items for next/previous
history elements and isearch history forward/backward.
Juri Linkov [Thu, 28 Feb 2008 20:46:02 +0000 (20:46 +0000)]
(viper-emacs-state-mode-list): Rename `custom-mode' to `Custom-mode'.
Juri Linkov [Thu, 28 Feb 2008 20:45:51 +0000 (20:45 +0000)]
Rename `custom-mode' to `Custom-mode'.
Juri Linkov [Thu, 28 Feb 2008 20:45:37 +0000 (20:45 +0000)]
(custom-mode-map, custom-mode-link-map):
Rename `custom-mode' to `Custom-mode' in docstrings.
(custom-buffer-create-internal, customize-browse):
Rename `custom-mode' to `Custom-mode'.
(custom-mode-hook): Rename to `Custom-mode-hook'.
(Custom-mode-hook): Renamed from `custom-mode-hook'.
(custom-mode): Rename to `Custom-mode'.
(Custom-mode): Renamed from `custom-mode'. Doc fix.
(custom-mode): Add backward-compatible non-interactive variant of
`Custom-mode' that simply calls `Custom-mode'. Mark it obsoleted.
(custom-mode-hook): Mark it as obsolete alias of `Custom-mode-hook'.
Stefan Monnier [Thu, 28 Feb 2008 19:12:01 +0000 (19:12 +0000)]
Use with-current-buffer.
Teodor Zlatanov [Thu, 28 Feb 2008 17:41:40 +0000 (17:41 +0000)]
(url-get-normalized-date): Simplify
to use `format-time-string'. Always generate date in UTC, but
call it GMT for full compatibility with the RFCs.
Stefan Monnier [Thu, 28 Feb 2008 17:09:18 +0000 (17:09 +0000)]
(uniquify-buffer-base-name): Undo last change. Should be
done in desktop.el instead.
Dan Nicolaescu [Thu, 28 Feb 2008 15:43:21 +0000 (15:43 +0000)]
*** empty log message ***
Kenichi Handa [Thu, 28 Feb 2008 12:54:46 +0000 (12:54 +0000)]
(ftfont_match): Explicitly set pixelsize in pattern.
Juanma Barranquero [Thu, 28 Feb 2008 10:13:26 +0000 (10:13 +0000)]
*** empty log message ***
Kenichi Handa [Thu, 28 Feb 2008 05:46:27 +0000 (05:46 +0000)]
(handle_auto_composed_prop): Don't make composition if it->string
is a string.
Glenn Morris [Thu, 28 Feb 2008 03:49:35 +0000 (03:49 +0000)]
(Info-goto-node): Remove declaration.
(org-info): Use info rather than Info-goto-node.
Glenn Morris [Thu, 28 Feb 2008 03:47:59 +0000 (03:47 +0000)]
(make-obsolete): Doc fix.
Glenn Morris [Thu, 28 Feb 2008 03:47:24 +0000 (03:47 +0000)]
(Info-goto-node): Remove declaration.
(idlwave-convert-xml-system-routine-info): Don't require xml.
(idlwave-show-commentary, idlwave-shell-show-commentary): Don't require finder.
(idlwave-info): Don't require info. Use info rather than Info-goto-node.
Glenn Morris [Thu, 28 Feb 2008 03:45:53 +0000 (03:45 +0000)]
(reftex-show-commentary): Don't require finder.
(reftex-info): Don't require info. Use info rather than Info-goto-node.
Glenn Morris [Thu, 28 Feb 2008 03:44:36 +0000 (03:44 +0000)]
(auto-insert-alist): Update to FDL 1.2.
Glenn Morris [Thu, 28 Feb 2008 03:43:47 +0000 (03:43 +0000)]
Update commentary.
Remove leading `*' from defcustom doc-strings.
(Info-menu, Info-goto-node): Remove declarations.
(report-emacs-bug-info): Use info rather than Info-goto-node.
Dan Nicolaescu [Thu, 28 Feb 2008 03:37:40 +0000 (03:37 +0000)]
*** empty log message ***
Dan Nicolaescu [Thu, 28 Feb 2008 03:35:22 +0000 (03:35 +0000)]
* progmodes/hideshow.el (hs-minor-mode-menu): Add some options to
the menu.
* vc.el (vc-deduce-fileset, vc-next-action, vc-start-entry)
(vc-finish-logentry): Check for vc-status-mode, not only for
vc-dired-mode.
Kenichi Handa [Thu, 28 Feb 2008 02:57:50 +0000 (02:57 +0000)]
(display_mode_element): Cancel the previous change.
(decode_mode_spec): Likewise.
Kenichi Handa [Thu, 28 Feb 2008 01:58:07 +0000 (01:58 +0000)]
(isearch-printing-char): Don't check
keyboard-coding-system. Call
isearch-process-search-multibyte-characters only when
current-input-method is non-nil.
Kim F. Storm [Wed, 27 Feb 2008 22:53:11 +0000 (22:53 +0000)]
(make-glyph-code): Encode as cons if face id > 63.
(glyph-char, glyph-face): Handle cons encoding.
Kim F. Storm [Wed, 27 Feb 2008 22:52:56 +0000 (22:52 +0000)]
(get_next_display_element, next_element_from_display_vector):
Adapt to new glyph type and new glyph code encoding.
Kim F. Storm [Wed, 27 Feb 2008 22:49:29 +0000 (22:49 +0000)]
(encode_terminal_code, produce_special_glyphs): Likewise.
Kim F. Storm [Wed, 27 Feb 2008 22:49:21 +0000 (22:49 +0000)]
(IT_write_glyphs): Adapt to new glyph type.
Kim F. Storm [Wed, 27 Feb 2008 22:49:15 +0000 (22:49 +0000)]
(GLYPH): Change type from int to struct with separate char
and face_id members.
(GLYPH_MASK_FACE, GLYPH_MASK_CHAR): Delete macros.
(GLYPH_CHAR, GLYPH_FACE): Remove slow versions with frame arg.
(FAST_GLYPH_CHAR, FAST_GLYPH_FACE): Rename macros to ...
(GLYPH_CHAR, GLYPH_FACE): ... these. Change users.
(FAST_MAKE_GLYPH, MAKE_GLYPH): Remove. Rewrite users to use ...
(SET_GLYPH, SET_GLYPH_CHAR, SET_GLYPH_FACE): ... these macros instead.
(GLYPH_CODE_CHAR, GLYPH_CODE_FACE, GLYPH_CODE_P)
(GLYPH_CODE_CHAR_VALID_P, SET_GLYPH_FROM_GLYPH_CODE): New macros to
handle new Lisp glyph code encoding, either an integer or a cons.
Kim F. Storm [Wed, 27 Feb 2008 22:49:07 +0000 (22:49 +0000)]
(current_column, current_column_1, Fmove_to_column)
(compute_motion): Adapt to new glyph code encoding.
Kim F. Storm [Wed, 27 Feb 2008 22:48:58 +0000 (22:48 +0000)]
(GLYPH_SIMPLE_P): Rewrite.
(GLYPH_ALIAS): Delete.
(GLYPH_ALIAS_P, GLYPH_FOLLOW_ALIASES): Rewrite.
(GLYPH_LENGTH, GLYPH_STRING): Use GLYPH_CHAR.
(GLYPH_FROM_CHAR): Replace macro by ...
(SET_GLYPH_FROM_CHAR): ... this macro. Change users.
Kim F. Storm [Wed, 27 Feb 2008 22:48:52 +0000 (22:48 +0000)]
(line_draw_cost): Adapt to new glyph type.
(build_frame_matrix_from_leaf_window): Adapt to new glyph type and
new glyph code encoding.
(spec_glyph_lookup_face): No return value; update passed glyph instead.
(init_display): Use SET_CHAR_GLYPH to initialize space_glyph.
Kim F. Storm [Wed, 27 Feb 2008 22:48:44 +0000 (22:48 +0000)]
(CHAR_GLYPH_SPACE_P): Simplify.
(GLYPH_FROM_CHAR_GLYPH): Replace macro by ...
(SET_GLYPH_FROM_CHAR_GLYPH): ... this macro. Change users.
(GLYPH_INVALID_P): New macro.
(spec_glyph_lookup_face): Update prototype.
Kim F. Storm [Wed, 27 Feb 2008 22:47:49 +0000 (22:47 +0000)]
*** empty log message ***
Jan Djärv [Wed, 27 Feb 2008 18:32:27 +0000 (18:32 +0000)]
Updated.
Jan Djärv [Wed, 27 Feb 2008 18:32:13 +0000 (18:32 +0000)]
(HAVE_GTK): Print a warning if gtk version is < 2.10.
Bastien Guerry [Wed, 27 Feb 2008 18:20:25 +0000 (18:20 +0000)]
Re-added calc-menu.el to fix persmissions.
Bastien Guerry [Wed, 27 Feb 2008 18:18:33 +0000 (18:18 +0000)]
Removed calc-menu.el. Next commit will add it again and fix the permissions.
Juanma Barranquero [Wed, 27 Feb 2008 16:39:45 +0000 (16:39 +0000)]
(uniquify-buffer-base-name): If the base name is an empty
string, return nil to allow the caller to default to the
buffer name. Reported by Martin Fischer <parozusa@web.de>.
Chong Yidong [Wed, 27 Feb 2008 15:09:04 +0000 (15:09 +0000)]
(wait_reading_process_output): Check for window changes caused by timers.
Suggested by Johan Bockgård.
Chong Yidong [Wed, 27 Feb 2008 15:08:55 +0000 (15:08 +0000)]
* process.c (wait_reading_process_output): Check for window
changes caused by timers.
Suggested by Johan Bockgård.
Juanma Barranquero [Wed, 27 Feb 2008 10:25:55 +0000 (10:25 +0000)]
*** empty log message ***
Juanma Barranquero [Wed, 27 Feb 2008 10:20:26 +0000 (10:20 +0000)]
(sc-describe): Fix typos in obsolescence declaration.
Juanma Barranquero [Wed, 27 Feb 2008 10:17:06 +0000 (10:17 +0000)]
(tool-bar-setup): Doc fix.
Glenn Morris [Wed, 27 Feb 2008 09:19:28 +0000 (09:19 +0000)]
(nnmairix-request-group): Bind nnmairix-fast and nnmairix-group around
nnmairix-request-group-with-article-number-correction call.
(nnmairix-fast, nnmairix-group): New, less general names, for free
variables passed from nnmairix-request-group to
nnmairix-request-group-with-article-number-correction. Declare.
(nnmairix-request-group-with-article-number-correction):
Use nnmairix-fast, nnmairix-group rather than fast, group.
Glenn Morris [Wed, 27 Feb 2008 09:11:02 +0000 (09:11 +0000)]
(nnmairix-group-regexp, nnmairix-valid-backends): Convert from free
variables to defconsts. Convert comments to doc-strings.
(nnmairix-last-server, nnmairix-current-server): Convert from free
variables to defvars. Convert comments to doc-strings.
(gnus-registry-fetch-group): Autoload.
(nnmairix-replace-group-and-numbers): Use mapc rather than mapcar.
(nnmairix-widget-get-values, nnmairix-widget-make-query-from-widgets)
(nnmairix-widget-build-editable-fields): Use car cddr rather than caddr.
Glenn Morris [Wed, 27 Feb 2008 08:57:49 +0000 (08:57 +0000)]
Switch license to GPLv3+.
Standardize license text.
Change defcustom :version from 23.0 to 23.1.
Glenn Morris [Wed, 27 Feb 2008 08:55:44 +0000 (08:55 +0000)]
Standardize license text.
Miles Bader [Wed, 27 Feb 2008 06:22:10 +0000 (06:22 +0000)]
Merge from gnus--devo--0
Revision: emacs@sv.gnu.org/emacs--devo--0--patch-1086
Glenn Morris [Wed, 27 Feb 2008 05:03:06 +0000 (05:03 +0000)]
(auto-insert-alist): Change permission text to match FSF's GPLv3 form.
Glenn Morris [Wed, 27 Feb 2008 04:59:01 +0000 (04:59 +0000)]
(USAGE1): Add `--disable-font-backend'.
Glenn Morris [Wed, 27 Feb 2008 04:54:55 +0000 (04:54 +0000)]
Change copyright to FSF, per the author's statement:
http://lists.gnu.org/archive/html/emacs-devel/2008-02/msg02647.html
Update FSF address.
Glenn Morris [Wed, 27 Feb 2008 04:48:23 +0000 (04:48 +0000)]
Make the `whitespace.el' issue a little less confusing for people by
actually mentioning it.
Glenn Morris [Wed, 27 Feb 2008 04:43:48 +0000 (04:43 +0000)]
Mention --disable-font-backend option.
Glenn Morris [Wed, 27 Feb 2008 04:42:33 +0000 (04:42 +0000)]
Remove a lot of old and obsolete info.
(titlepage): Simplify.
(Emacs 19 MUAs, Emacs 18 MUAs, MH-E with any Emacsen)
(VM with any Emacsen, GNEWS with any Emacsen)
(Overloading for Non-conforming MUAs, Version 3 Changes)
(The Supercite Mailing List): Delete nodes.
(Introduction): Remove info about old packages.
(Getting Connected): Simplify. Remove info about old packages.
(Citing Commands): Delete Emacs 19 info.
(Hints to MUA Authors): Simplify.
(Thanks and History): Merge in some info from the deleted node
"Version 3 Changes".
Glenn Morris [Wed, 27 Feb 2008 04:34:05 +0000 (04:34 +0000)]
(sc-cite-original): Doc fix.
(sc-version): Make obsolete.
(sc-describe): Show the SC info page. Make obsolete.
Stefan Monnier [Wed, 27 Feb 2008 04:10:15 +0000 (04:10 +0000)]
(Finsert_file_contents): Don't reset undo_list if no change
is made to the buffer.
Stefan Monnier [Tue, 26 Feb 2008 21:35:04 +0000 (21:35 +0000)]
*** empty log message ***
Reiner Steib [Tue, 26 Feb 2008 21:08:38 +0000 (21:08 +0000)]
(Gnus): Mention problem with coding system `utf-8-emacs'
when using different Emacs versions.
Stefan Monnier [Tue, 26 Feb 2008 19:41:53 +0000 (19:41 +0000)]
(set-mark-command): Deactivate mark on second C-SPC C-SPC
when using transient-mark-mode.
Chong Yidong [Tue, 26 Feb 2008 18:48:00 +0000 (18:48 +0000)]
(Formatting Strings): Treat - and 0 as flag characters.
Chong Yidong [Tue, 26 Feb 2008 18:47:52 +0000 (18:47 +0000)]
* strings.texi (Formatting Strings): Treat - and 0 as flag
characters.
Stefan Monnier [Tue, 26 Feb 2008 18:18:05 +0000 (18:18 +0000)]
* dispextern.h (face_at_buffer_position, face_for_overlay_string)
(face_at_string_position):
* xfaces.c (face_at_buffer_position, face_for_overlay_string)
(face_at_string_position):
* xdisp.c (display_string, next_overlay_change):
* buffer.h (overlays_at):
* buffer.c (overlays_at): Use EMACS_INT for buffer positions.
Update callers.
Chong Yidong [Tue, 26 Feb 2008 16:36:52 +0000 (16:36 +0000)]
(Fformat): Doc fix.
Chong Yidong [Tue, 26 Feb 2008 16:36:46 +0000 (16:36 +0000)]
* editfns.c (Fformat): Doc fix.
Juanma Barranquero [Tue, 26 Feb 2008 16:25:25 +0000 (16:25 +0000)]
(Ffont_spec, Ffont_at): Fix typos in docstrings.
(Ffont_put, Flist_families, Ffont_fill_gstring, Ffont_drive_otf,
Ffont_otf_alternates, Fquery_font): Doc fixes.
Jan Djärv [Tue, 26 Feb 2008 14:41:25 +0000 (14:41 +0000)]
(compilation-mode-tool-bar-map): The same.
Jan Djärv [Tue, 26 Feb 2008 14:41:01 +0000 (14:41 +0000)]
(grep-mode-tool-bar-map): Change place on next
and previous.
Miles Bader [Tue, 26 Feb 2008 09:00:24 +0000 (09:00 +0000)]
Remove RCS keywords
Revision: emacs@sv.gnu.org/emacs--devo--0--patch-1083
Glenn Morris [Tue, 26 Feb 2008 04:31:30 +0000 (04:31 +0000)]
(top-level): Don't require comint when compiling.
(nslookup-font-lock-keywords): Don't require font-lock.
Use font-lock faces rather than variables.
(nslookup, ftp, smbclient, network-service-connection):
Don't require comint.
(comint-prompt-regexp, comint-input-autoexpand)
(comint-input-ring): Declare for compiler.
(comint-mode, ffap-string-at-point, comint-exec): Autoload.
(dns-lookup-host): Don't require ffap. Remove `with-no-warnings'.
Glenn Morris [Tue, 26 Feb 2008 04:28:18 +0000 (04:28 +0000)]
(ibuffer-do-toggle-read-only): Don't use `iff' in doc-string.
Glenn Morris [Tue, 26 Feb 2008 04:27:39 +0000 (04:27 +0000)]
Combine entries.
Stefan Monnier [Tue, 26 Feb 2008 02:06:33 +0000 (02:06 +0000)]
(doc-view-current-page): Add a `win' argument.
Stefan Monnier [Tue, 26 Feb 2008 01:43:54 +0000 (01:43 +0000)]
*** empty log message ***
Roland Winkler [Mon, 25 Feb 2008 20:07:28 +0000 (20:07 +0000)]
(ibuffer-do-toggle-read-only): New optional arg as in
toggle-read-only.
Stefan Monnier [Mon, 25 Feb 2008 20:04:59 +0000 (20:04 +0000)]
(doc-view-conversion-buffer): Give it an internal name.
Demote it to plain defvar.
(doc-view-conversion-refresh-interval): Reduce interval.
(doc-view-goto-page): Allow moving to pages not yet rendered.
(doc-view-goto-page): Construct a file name rather than extracting it
from doc-view-current-files.
(doc-view-kill-proc): Ignore errors from kill-process.
(doc-view-pdf/ps->png-sentinel): Die gracefully if the buffer is dead.
(doc-view-insert-image): Use appropriate text if the page hasn't been
rendered yet. Adjust scrolling so the text is displayed.
(doc-view-display): Detect not just that a page is available, but also
that it wasn't available before, to avoid refreshing all pages repeatedly.
(doc-view-mode): Make doc-view-cache-directory if needed.
Roland Winkler [Mon, 25 Feb 2008 19:57:38 +0000 (19:57 +0000)]
(bibtex-format-entry): Handle error message refering to a missing
required field with the OPT prefix. Make unwindform more robust.
Roland Winkler [Mon, 25 Feb 2008 19:49:23 +0000 (19:49 +0000)]
* textmodes/bibtex.el: Remove support for hideshow minor mode as
it duplicates the bibtex support in progmodes/hideshow.el.
* progmodes/hideshow.el (hs-special-modes-alist): Allow bibtex
entry that do not start at the beginning of a line.
Stefan Monnier [Mon, 25 Feb 2008 19:09:22 +0000 (19:09 +0000)]
(Fbuffer_swap_text): New function.
(syms_of_buffer): Defsubr it.
Chong Yidong [Mon, 25 Feb 2008 17:42:13 +0000 (17:42 +0000)]
(shell-quote-wildcard-pattern): Quote ' and " as well.
Chong Yidong [Mon, 25 Feb 2008 17:41:59 +0000 (17:41 +0000)]
* files.el (shell-quote-wildcard-pattern): Quote ' and " as well.
Robert J. Chassell [Mon, 25 Feb 2008 16:37:30 +0000 (16:37 +0000)]
*** empty log message ***
Robert J. Chassell [Mon, 25 Feb 2008 16:31:25 +0000 (16:31 +0000)]
(describe-variable): Add phrases about initialization file with and
without customization; use new button type help-info-variable.
Chong Yidong [Mon, 25 Feb 2008 16:06:08 +0000 (16:06 +0000)]
(command_loop_1): Revert 2006-10-09 change.
Chong Yidong [Mon, 25 Feb 2008 16:06:01 +0000 (16:06 +0000)]
* keyboard.c (command_loop_1): Revert 2006-10-09 change.
Juanma Barranquero [Mon, 25 Feb 2008 11:28:07 +0000 (11:28 +0000)]
Include malloc.h.
(add_registry): Cast return value of alloca.
Jan Djärv [Mon, 25 Feb 2008 10:52:57 +0000 (10:52 +0000)]
(grep-mode-tool-bar-map): New variable.
(grep-mode): Use grep-mode-tool-bar-map.
Jan Djärv [Mon, 25 Feb 2008 10:52:09 +0000 (10:52 +0000)]
(tool-bar): Rquire tool-bar.
(compilation-mode-tool-bar-map): New variable.
(compilation-mode): Use compilation-mode-tool-bar-map.
Jan Djärv [Mon, 25 Feb 2008 10:50:20 +0000 (10:50 +0000)]
(x-gtk-stock-map): Add cancel. Remove extensions.
Kenichi Handa [Mon, 25 Feb 2008 10:41:51 +0000 (10:41 +0000)]
(x_produce_glyphs): For a visible glyph, assure at least
1-pixel width.
Jason Rumney [Mon, 25 Feb 2008 09:08:52 +0000 (09:08 +0000)]
*** empty log message ***
Jason Rumney [Mon, 25 Feb 2008 08:35:40 +0000 (08:35 +0000)]
(w32font_draw): Draw one character at a time when padding.
Dan Nicolaescu [Mon, 25 Feb 2008 08:17:18 +0000 (08:17 +0000)]
* configure.in: Print an error for systems that we think are
obsolete and are proposed to be removed. Remove some more unused
systems.
* configure: Regenerate.
Glenn Morris [Mon, 25 Feb 2008 08:14:21 +0000 (08:14 +0000)]
(vc-sccs-diff): Fix setting of oldvers and newvers.
Stefan Monnier [Mon, 25 Feb 2008 03:54:54 +0000 (03:54 +0000)]
* diff-mode.el (diff-file-junk-re): New const.
(diff-beginning-of-file-and-junk): Use it.
(diff-file-kill): Make sure we were really inside a file diff.
* diff-mode.el: Make it more robust in the presence of empty context
lines in unified hunks.
(diff-valid-unified-empty-line): New var.
(diff-unified->context, diff-sanity-check-hunk): Obey it.
(diff-end-of-hunk): Obey it. New arg `donttrustheader'.
(diff-fixup-modifs, diff-post-command-hook): Use this new arg.
(diff-hunk-header-re-unified): New const.
(diff-font-lock-keywords, diff-hunk-header-re, diff-split-hunk)
(diff-fixup-modifs, diff-unified->context, diff-next-complex-hunk)
(diff-sanity-check-hunk): Use it.
* diff-mode.el (diff-beginning-of-file-and-junk): If we're on the
Index: line, don't search backward for the previous one.
Juanma Barranquero [Mon, 25 Feb 2008 02:36:22 +0000 (02:36 +0000)]
*** empty log message ***
Stefan Monnier [Mon, 25 Feb 2008 02:27:32 +0000 (02:27 +0000)]
(Fdelete_window, Fadjust_window_trailing_edge):
Handle a nil arg. Use run_window_configuration_change_hook.
(delete_window, adjust_window_trailing_edge): Don't handle nil any more.
(Fenlarge_window, Fshrink_window, Fset_window_configuration):
Use run_window_configuration_change_hook.
Kenichi Handa [Mon, 25 Feb 2008 01:52:35 +0000 (01:52 +0000)]
(struct glyph_string): New member padding_p.
Kenichi Handa [Mon, 25 Feb 2008 01:46:30 +0000 (01:46 +0000)]
(w32font_draw): Pay attention to s->padding_p.
Kenichi Handa [Mon, 25 Feb 2008 01:45:47 +0000 (01:45 +0000)]
(ftxfont_draw): Pay attention to s->padding_p.
Kenichi Handa [Mon, 25 Feb 2008 01:44:26 +0000 (01:44 +0000)]
(xfont_draw): Pay attention to s->padding_p.