Cleanup of window coordinate positioning code.
authorChong Yidong <cyd@stupidchicken.com>
Wed, 17 Nov 2010 02:37:45 +0000 (21:37 -0500)
committerChong Yidong <cyd@stupidchicken.com>
Wed, 17 Nov 2010 02:37:45 +0000 (21:37 -0500)
commit9173a8fbd77df7db68247a331df1c84f8ff074ec
tree551f2115d72059c703f73206bcc23a859a996b83
parent809fde057f0f7c2d04825c910e3f323e38a9d342
Cleanup of window coordinate positioning code.
Now, text area click input events measure Y from the top of the text
area, excluding the header line if any.

* src/dispnew.c (buffer_posn_from_coords): Assume that X counts from
the start of the text area.

* src/keyboard.c (make_lispy_position): For text area clicks, record Y
pixel position relative to the text area, excluding header line.
Also change X and Y to Lisp_Objects, not pointers; don't return
coordinate values via pointers.  Pass ON_TEXT_AREA coordinate to
buffer_posn_from_coords counting from the start of the text area.
(Fposn_at_x_y, make_lispy_event): Callers changed.

* src/w32term.c (w32_read_socket):
* src/msdos.c (dos_rawgetc):
* src/xterm.c (handle_one_xevent): Likewise.

* src/window.c (coordinates_in_window): Change X and Y to ints rather
than pointers; don't return coordinates via pointers.
(struct check_window_data): Change X and Y from pointers to ints.
(window_from_coordinates): Remove args WX and WY; don't return
coordinates via pointers.
(Fcoordinates_in_window_p, window_from_coordinates):
(check_window_containing, Fwindow_at): Callers changed.
(window_relative_x_coord): New function.

* src/window.h (window_from_coordinates, window_relative_x_coord):
Update prototypes.

* src/xdisp.c (remember_mouse_glyph): Change window_from_coordinates
call.  Use window_relative_x_coord.
(note_mouse_highlight): Change window_from_coordinates call.
etc/NEWS
src/ChangeLog
src/dispnew.c
src/keyboard.c
src/msdos.c
src/w32term.c
src/window.c
src/window.h
src/xdisp.c
src/xterm.c