Standardize on VIRT_ADDR_VARIES behavior; otherwise, valgrind
authorPaul Eggert <eggert@cs.ucla.edu>
Thu, 10 Nov 2011 08:14:27 +0000 (00:14 -0800)
committerPaul Eggert <eggert@cs.ucla.edu>
Thu, 10 Nov 2011 08:14:27 +0000 (00:14 -0800)
commit6a0bf43d7c5961297aa5024aec534e5bab73c8af
treeb823825dae7da76be667a0ddb157bff2bd029ac7
parent9a4de110224cc0ea32a9c680db3f4355484236a6
Standardize on VIRT_ADDR_VARIES behavior; otherwise, valgrind

does not work on some platforms.  Problem reported by Andreas Schwab in
<http://lists.gnu.org/archive/html/emacs-devel/2011-11/msg00081.html>.
* puresize.h (pure, PURE_P): Always behave as if VIRT_ADDR_VARIES
is set, removing the need for VIRT_ADDRESS_VARIES.
(PURE_P): Use a more-efficient implementation that needs just one
comparison, not two: on x86-64 with GCC 4.6.2, this cut down the
number of instructions from 6 (xorl, cmpq, jge, xorl, cmpq, setge)
to 4 (xorl, subq, cmpq, setbe).
* alloc.c (pure): Always extern now, since that's the
VIRT_ADDR_VARIES behavior.
(PURE_POINTER_P): Use a single comparison, not two, for
consistency with the new puresize.h.
* lisp.h (PNTR_COMPARISON_TYPE): Remove; no longer needed.
* m/ibms390.h, m/intel386.h, m/template.h, s/cygwin.h, s/hpux10-20.h:
Remove VIRT_ADDR_VARIES no longer needed.
src/ChangeLog
src/alloc.c
src/lisp.h
src/m/ibms390.h
src/m/intel386.h
src/m/template.h
src/puresize.h
src/s/cygwin.h
src/s/hpux10-20.h