Be more systematic about user-interface timestamps.
authorPaul Eggert <eggert@cs.ucla.edu>
Thu, 12 May 2011 20:23:33 +0000 (13:23 -0700)
committerPaul Eggert <eggert@cs.ucla.edu>
Thu, 12 May 2011 20:23:33 +0000 (13:23 -0700)
commit08dc5ae68e9c699410256ca9052bd09f336ac87f
tree6572186aea70cb9f3f736743271c4d0b500650b6
parent86db42d22397effbb6e9edc5ae11d806847f0d3e
Be more systematic about user-interface timestamps.

Before, the code sometimes used 'Time', sometimes 'unsigned long',
and sometimes 'EMACS_UINT', to represent these timestamps.  This
change causes it to use 'Time' uniformly, as that's what X uses.
This makes the code easier to follow, and makes it easier to catch
integer overflow bugs such as Bug#8664.
* frame.c (Fmouse_position, Fmouse_pixel_position):
Use Time, not unsigned long, for user-interface timestamps.
* keyboard.c (last_event_timestamp, kbd_buffer_get_event): Likewise.
(button_down_time, make_lispy_position, make_lispy_movement): Likewise.
* keyboard.h (last_event_timestamp): Likewise.
* menu.c (Fx_popup_menu) [!HAVE_X_WINDOWS]: Likewise.
* menu.h (xmenu_show): Likewise.
* term.c (term_mouse_position): Likewise.
* termhooks.h (struct input_event.timestamp): Likewise.
(struct terminal.mouse_position_hook): Likewise.
* xmenu.c (create_and_show_popup_menu, xmenu_show): Likewise.
* xterm.c (XTmouse_position, x_scroll_bar_report_motion): Likewise.
* systime.h (Time): New decl.  Pull it in from <X11/X.h> if
HAVE_X_WINDOWS, otherwise define it as unsigned long, which is
what it was before.
* menu.h, termhooks.h: Include "systime.h", for Time.
src/ChangeLog
src/frame.c
src/keyboard.c
src/keyboard.h
src/menu.c
src/menu.h
src/systime.h
src/term.c
src/termhooks.h
src/xmenu.c
src/xterm.c