1 2011-04-25 Paul Eggert <eggert@cs.ucla.edu>
3 * lisp.h: Say "vectorlike header" rather than "vector header.
4 (struct vectorlike_header): Rename from struct vector_header.
5 (XVECTORLIKE_HEADER_SIZE): Renamed from XVECTOR_HEADER_SIZE.
8 lisp.h: Fix a problem with aliasing and vector headers.
9 GCC 4.6.0 optimizes based on type-based alias analysis. For
10 example, if b is of type struct buffer * and v of type struct
11 Lisp_Vector *, then gcc -O2 was incorrectly assuming that &b->size
12 != &v->size, and therefore "v->size = 1; b->size = 2; return
13 v->size;" must therefore return 1. This assumption is incorrect
14 for Emacs, since it type-puns struct Lisp_Vector * with many other
15 types. To fix this problem, this patch adds a new type struct
16 vector_header that documents the constraints on layout of vectors
17 and pseudovectors, and helps optimizing compilers not get fooled
18 by Emacs's type punning. It also adds the macros XSETTYPED_PVECTYPE
19 XSETTYPED_PSEUDOVECTOR, TYPED_PSEUDOVECTORP, for similar reasons.
20 * lisp.h (XVECTOR_SIZE): New convenience macro. All previous uses of
21 XVECTOR (foo)->size replaced to use this macro, to avoid the hassle
22 of writing XVECTOR (foo)->header.size.
23 (XVECTOR_HEADER_SIZE): New macro, for use in XSETPSEUDOVECTOR.
24 (XSETTYPED_PVECTYPE): New macro, specifying the name of the size
26 (XSETPVECTYPE): Rewrite in terms of new macro.
27 (XSETPVECTYPESIZE): New macro, specifying both type and size.
28 This is a bit clearer, and further avoids the possibility of
30 (XSETTYPED_PSEUDOVECTOR): New macro, specifying the size.
31 (XSETPSEUDOVECTOR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR
32 and XVECTOR_HEADER_SIZE.
33 (XSETSUBR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR and XSIZE,
34 since Lisp_Subr is a special case (no "next" field).
35 (ASIZE): Rewrite in terms of XVECTOR_SIZE.
36 (struct vector_header): New type.
37 (TYPED_PSEUDOVECTORP): New macro, also specifying the C type of the
38 object, to help avoid aliasing.
39 (PSEUDOVECTORP): Rewrite in terms of TYPED_PSEUDOVECTORP.
40 (SUBRP): Likewise, since Lisp_Subr is a special case.
42 * lisp.h (struct Lisp_Vector, struct Lisp_Char_Table):
43 (struct Lisp_Sub_Char_Table, struct Lisp_Bool_Vector):
44 (struct Lisp_Hash_Table): Combine first two members into a single
45 struct vector_header member. All uses of "size" and "next" members
46 changed to be "header.size" and "header.next".
47 * buffer.h (struct buffer): Likewise.
48 * font.h (struct font_spec, struct font_entity, struct font): Likewise.
49 * frame.h (struct frame): Likewise.
50 * process.h (struct Lisp_Process): Likewise.
51 * termhooks.h (struct terminal): Likewise.
52 * window.c (struct save_window_data, struct saved_window): Likewise.
53 * window.h (struct window): Likewise.
54 * alloc.c (allocate_buffer, Fmake_bool_vector, allocate_pseudovector):
55 Use XSETPVECTYPESIZE, not XSETPVECTYPE, to avoid aliasing problems.
56 * buffer.c (init_buffer_once): Likewise.
57 * lread.c (defsubr): Use XSETTYPED_PVECTYPE, since Lisp_Subr is a
59 * process.c (Fformat_network_address): Use local var for size,
62 2011-04-24 Paul Eggert <eggert@cs.ucla.edu>
64 * bytecode.c (exec_byte_code): Don't use XVECTOR before CHECK_VECTOR.
66 2011-04-21 Paul Eggert <eggert@cs.ucla.edu>
68 Make the Lisp reader and string-to-float more consistent.
69 * data.c (atof): Remove decl; no longer used or needed.
70 (digit_to_number): Move to lread.c.
71 (Fstring_to_number): Use new string_to_number function, to be
72 consistent with how the Lisp reader treats infinities and NaNs.
73 Do not assume that floating-point numbers represent EMACS_INT
74 without losing information; this is not true on most 64-bit hosts.
75 Avoid double-rounding errors, by insisting on integers when
76 parsing non-base-10 numbers, as the documentation specifies.
77 * lisp.h (string_to_number): New decl, replacing ...
78 (isfloat_string): Remove.
79 * lread.c: Include <inttypes.h>, for uintmax_t and strtoumax.
80 (read1): Do not accept +. and -. as integers; this
81 appears to have been a coding error. Similarly, do not accept
82 strings like +-1e0 as floating point numbers. Do not report
83 overflow for integer overflows unless the base is not 10 which
84 means we have no simple and reliable way to continue.
85 Break out the floating-point parsing into a new
86 function string_to_number, so that Fstring_to_number parses
87 floating point numbers consistently with the Lisp reader.
88 (digit_to_number): Moved here from data.c. Make it static inline.
89 (E_CHAR, EXP_INT): Remove, replacing with ...
90 (E_EXP): New macro, to solve the "1.0e+" problem mentioned below.
91 (string_to_number): New function, replacing isfloat_string.
92 This function checks for valid syntax and produces the resulting
93 Lisp float number too. Rework it so that string-to-number
94 no longer mishandles examples like "1.0e+". Use strtoumax,
95 so that overflow for non-base-10 numbers is reported only when
96 there's no portable and simple way to convert to floating point.
98 2011-04-20 Paul Eggert <eggert@cs.ucla.edu>
100 * textprop.c (set_text_properties_1): Rewrite for clarity,
101 and to avoid GCC warning about integer overflow.
103 * intervals.h (struct interval): Use EMACS_INT for members
104 where EMACS_UINT might cause problems. See
105 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html>.
106 (CHECK_TOTAL_LENGTH): Remove cast to EMACS_INT; no longer needed.
107 * intervals.c (interval_deletion_adjustment): Now returns EMACS_INT.
109 (offset_intervals): Tell GCC not to worry about length overflow
110 when negating a negative length.
112 * alloc.c (overrun_check_malloc, overrun_check_realloc): Now static.
113 (overrun_check_free): Likewise.
115 * alloc.c (SDATA_SIZE) [!GC_CHECK_STRING_BYTES]: Avoid runtime check
116 in the common case where SDATA_DATA_OFFSET is a multiple of Emacs
119 * gnutls.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
120 (gnutls_make_error): Rename local to avoid shadowing.
121 (gnutls_emacs_global_deinit): ifdef out; not used.
122 (Fgnutls_boot): Use const for pointer to readonly storage.
123 Comment out unused local. Fix pointer signedness problems.
125 * lread.c (openp): Don't stuff size_t into an 'int'.
126 Use <= on length, not < on length + 1, to avoid GCC 4.6.0 warning
127 about possible signed overflow.
129 * gtkutil.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
130 (GDK_KEY_g): Don't define if already defined.
131 (xg_prepare_tooltip): Avoid pointer signedness problem.
132 (xg_set_toolkit_scroll_bar_thumb): Redo to avoid two casts.
134 * process.c (Fnetwork_interface_info): Avoid left-shift undefined
135 behavior with 1 << 31. GCC 4.6.0 warns about this on 32-bit hosts.
137 * xfns.c (Fx_window_property): Simplify a bit,
138 to make a bit faster and to avoid GCC 4.6.0 warning.
139 * xselect.c (x_get_window_property, x_handle_dnd_message): Likewise.
141 * fns.c (internal_equal): Don't assume size_t fits in int.
143 * alloc.c (compact_small_strings): Tighten assertion a little.
145 Replace pEd with more-general pI, and fix some printf arg casts.
146 * lisp.h (pI): New macro, generalizing old pEd macro to other
147 conversion specifiers. For example, use "...%"pI"d..." rather
149 (pEd): Remove. All uses replaced with similar uses of pI.
150 * src/m/amdx86-64.h, src/m/ia64.h, src/m/ibms390x.h: Likewise.
151 * alloc.c (check_pure_size): Don't overflow by converting size to int.
152 * bidi.c (bidi_dump_cached_states): Use pI to avoid cast.
153 * data.c (Fnumber_to_string): Use pI instead of if-then-else-abort.
154 * dbusbind.c (xd_append_arg): Use pI to avoid cast.
155 (Fdbus_method_return_internal, Fdbus_method_error_internal): Likewise.
156 * font.c (font_unparse_xlfd): Avoid potential buffer overrun on
158 (font_unparse_xlfd, font_unparse_fcname): Use pI to avoid casts.
159 * keyboard.c (record_char, modify_event_symbol): Use pI to avoid casts.
160 * print.c (safe_debug_print, print_object): Likewise.
161 (print_object): Don't overflow by converting EMACS_INT or EMACS_UINT
163 Use pI instead of if-then-else-abort. Use %p to avoid casts,
164 avoiding the 0 flag, which is not portable.
165 * process.c (Fmake_network_process): Use pI to avoid cast.
166 * region-cache.c (pp_cache): Likewise.
167 * xdisp.c (decode_mode_spec): Likewise.
168 * xrdb.c (x_load_resources) [USE_MOTIF]: Use pI to avoid undefined
169 behavior on 64-bit hosts with printf arg.
170 * xselect.c (x_queue_event): Use %p to avoid casts, avoiding 0 flag.
171 (x_stop_queuing_selection_requests): Likewise.
172 (x_get_window_property): Don't truncate byte count to an 'int'
175 * frame.c (frame_name_fnn_p): Get rid of strtol, which isn't right
176 here, since it parses constructs like leading '-' and spaces,
177 which are not wanted; and it overflows with large numbers.
178 Instead, simply match F[0-9]+, which is what is wanted anyway.
180 * alloc.c: Remove unportable assumptions about struct layout.
181 (SDATA_SELECTOR, SDATA_DATA_OFFSET): New macros.
182 (SDATA_OF_STRING, SDATA_SIZE, allocate_string_data):
183 (allocate_vectorlike, make_pure_vector): Use the new macros,
184 plus offsetof, to remove unportable assumptions about struct layout.
185 These assumptions hold on all porting targets that I know of, but
186 they are not guaranteed, they're easy to remove, and removing them
187 makes further changes easier.
189 * alloc.c (BLOCK BYTES): Fix typo by changing "ablock" to "ablocks".
190 This doesn't fix a bug but makes the code clearer.
191 (string_overrun_cookie): Now const. Use initializers that
192 don't formally overflow signed char, to avoid warnings.
193 (allocate_string_data) [GC_CHECK_STRING_OVERRUN]: Fix typo that
194 can cause Emacs to crash when string overrun checking is enabled.
195 (allocate_buffer): Don't assume sizeof (struct buffer) is a
196 multiple of sizeof (EMACS_INT); it need not be, if
197 alignof(EMACS_INT) < sizeof (EMACS_INT).
198 (check_sblock, check_string_bytes, check_string_free_list): Protoize.
200 2011-04-19 Eli Zaretskii <eliz@gnu.org>
202 * syntax.h (SETUP_SYNTAX_TABLE_FOR_OBJECT): Fix setting of
203 gl_state.e_property when gl_state.object is Qt.
205 * insdel.c (make_gap_larger): Remove limitation of buffer size
208 2011-04-18 Chong Yidong <cyd@stupidchicken.com>
210 * xdisp.c (lookup_glyphless_char_display)
211 (produce_glyphless_glyph): Handle cons cell entry in
212 glyphless-char-display.
213 (Vglyphless_char_display): Document it.
215 * term.c (produce_glyphless_glyph): Handle cons cell entry in
216 glyphless-char-display.
218 2011-04-17 Chong Yidong <cyd@stupidchicken.com>
220 * xdisp.c (get_next_display_element): Remove unnecessary ifdefs.
222 * termhooks.h (FRAME_WINDOW_P): Remove duplicated definitions.
224 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): Add missing
225 definition for no-X builds.
227 2011-04-16 Paul Eggert <eggert@cs.ucla.edu>
229 Static checks with GCC 4.6.0 and non-default toolkits.
231 * s/sol2-6.h, s/unixware.h (PTY_TTY_NAME_SPRINTF): Protoize decl.
233 * process.c (keyboard_bit_set): Define only if SIGIO.
234 (send_process_trap): Mark it with NO_RETURN if it doesn't return.
235 (send_process): Repair possible setjmp clobbering.
237 * s/usg5-4-common.h (SETUP_SLAVE_PTY): Don't pass extra arg to 'fatal'.
239 * eval.c: Include <stdio.h>, for vsnprintf on non-GNU/Linux hosts.
241 * data.c (arith_error): Mark with NO_RETURN if it doesn't return.
243 * alloc.c (bytes_used_when_full, SPARE_MEMORY, BYTES_USED):
244 Define only if needed.
246 * sysdep.c (_FILE_OFFSET_BITS): Make this hack even uglier
247 by pacifying GCC about it. Maybe it's time to retire it?
248 * xfaces.c (USG, __TIMEVAL__): Likewise.
250 * dispextern.h (struct redisplay_interface): Rename param
252 * termhooks.h (struct terminal): Likewise.
253 * xterm.c (xembed_send_message): Likewise.
255 * insdel.c (make_gap_smaller): Define only if
256 USE_MMAP_FOR_BUFFERS || REL_ALLOC || DOUG_LEA_MALLOC.
258 * keyboard.c (read_char): Make a var volatile so longjmp won't clobber
261 * emacs.c (MAX_HEAP_BSS_DIFF, my_edata): Move to where they're used,
262 so that we aren't warned about unused symbols.
264 * xfns.c (Fx_file_dialog): Rename local to avoid shadowing.
266 * xdisp.c (x_produce_glyphs): Mark var as initialized (Bug#8512).
268 * xfns.c (x_real_positions): Mark locals as initialized.
270 * xmenu.c (xmenu_show): Don't use uninitialized vars.
272 * xterm.c: Fix problems found by static analysis with other toolkits.
273 (toolkit_scroll_bar_interaction): Define and use only if USE_X_TOOLKIT.
274 (x_dispatch_event): Declare static if USE_GTK, and
275 define if USE_GTK || USE_X_TOOLKIT.
276 (SET_SAVED_BUTTON_EVENT): Define only if USE_X_TOOLKIT || USE_GTK.
277 * xterm.h (x_dispatch_event): Extern only if USE_X_TOOLKIT.
278 * xterm.c, xterm.h (x_mouse_leave): Bring this function back, but only if
279 defined HAVE_MENUS && !defined USE_X_TOOLKIT && !defined USE_GTK.
281 * xmenu.c (menu_help_callback): Pointer type fixes.
282 Use const pointers when pointing at readonly data. Avoid pointer
284 (FALSE): Remove unused macro.
285 (update_frame_menubar): Remove unused decl.
287 * xfns.c (Fx_hide_tip): Move locals to avoid shadowing.
289 * menu.c (push_submenu_start, push_submenu_end): Do not define unless
290 USE_X_TOOLKIT || USE_GTK || HAVE_NS || defined HAVE_NTGUI.
291 (single_menu_item): Rename local to avoid shadowing.
293 * keyboard.c (make_lispy_event): Remove unused local var.
295 * frame.c, frame.h (x_get_resource_string): Bring this back, but
296 only if HAVE_X_WINDOWS && !USE_X_TOOLKIT.
298 * bitmaps: Change bitmaps from unsigned char back to the X11
299 compatible char. Avoid the old compiler warnings about
300 out-of-range initializers by using, for example, '\xab' rather
303 * xgselect.c (xgselect_initialize): Check vs interface
304 even if ! (defined (USE_GTK) || defined (HAVE_GCONF)).
306 * xmenu.c (xmenu_show): Rename parm to avoid shadowing.
308 * xterm.c (x_create_toolkit_scroll_bar): Use const * for pointers
311 * fns.c (vector): Remove; this old hack is no longer needed.
313 * xsmfns.c (create_client_leader_window): Rename shadowing arg.
315 (gdk_x11_set_sm_client_id) [!USE_GTK]: Don't define.
317 * xrdb.c (x_load_resources): Omit unused local.
319 * xfns.c (free_frame_menubar, atof): Remove duplicate decls.
320 (x_window): Rename locals to avoid shadowing.
321 (USG): Use the kludged USG macro, to pacify gcc.
323 * xterm.c (x_alloc_nearest_color_for_widget): Remove; unused.
324 (x_term_init): Remove local to avoid shadowing.
326 * xfns.c, xterm.c (_XEditResCheckMessages): Protoize decl.
328 * xdisp.c, dispextern.h (set_vertical_scroll_bar): Now extern if
329 USE_TOOLKIT_SCROLL_BARS && !USE_GTK, as xterm.c needs it then.
331 2011-04-16 Eli Zaretskii <eliz@gnu.org>
333 * gnutls.c (Fgnutls_boot): Don't pass Lisp_Object to `error'.
335 Fix regex.c, syntax.c and friends for buffers > 2GB.
336 * syntax.h (struct gl_state_s): Declare character position members
339 * syntax.c (update_syntax_table): Declare 2nd argument EMACS_INT.
341 * textprop.c (verify_interval_modification, interval_of): Declare
344 * intervals.c (adjust_intervals_for_insertion): Declare arguments
347 * intervals.h (CHECK_TOTAL_LENGTH): Cast to EMACS_INT, not `int'.
349 * indent.c (Fvertical_motion): Local variable it_start is now
352 * regex.c (re_match, re_match_2, re_match_2_internal)
353 (bcmp_translate, regcomp, regexec, print_double_string)
354 (group_in_compile_stack, re_search, re_search_2, regex_compile)
355 (re_compile_pattern, re_exec): Declare arguments and local
356 variables `size_t' and `ssize_t' and return values `regoff_t', as
358 (POP_FAILURE_REG_OR_COUNT) <pfreg>: Declare `long'.
359 (CHECK_INFINITE_LOOP) <failure>: Declare `ssize_t'.
360 <compile_stack_type>: `size' and `avail' are now `size_t'.
362 * regex.h <regoff_t>: Use ssize_t, not int.
363 (re_search, re_search_2, re_match, re_match_2): Arguments that
364 specify buffer/string position and length are now ssize_t and
365 size_t. Return type is regoff_t.
367 2011-04-16 Ben Key <bkey76@gmail.com>
369 * nsfont.m: Fixed bugs in ns_get_family and
370 ns_descriptor_to_entity that were caused by using free to
371 deallocate memory blocks that were allocated by xmalloc (via
372 xstrdup). This caused Emacs to crash when compiled with
373 XMALLOC_OVERRUN_CHECK defined (when Emacs was configured with
374 --enable-checking=xmallocoverrun). xfree is now used to
375 deallocate these memory blocks.
377 2011-04-15 Paul Eggert <eggert@cs.ucla.edu>
379 * sysdep.c (emacs_read): Remove unnecessary check vs MAX_RW_COUNT.
381 emacs_write: Accept and return EMACS_INT for sizes.
382 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html
384 * gnutls.c, gnutls.h (emacs_gnutls_read, emacs_gnutls_write):
385 Accept and return EMACS_INT.
386 (emacs_gnutls_write): Return the number of bytes written on
388 * sysdep.c, lisp.h (emacs_read, emacs_write): Likewise.
389 (emacs_read, emacs_write): Remove check for negative size, as the
390 Emacs source code has been audited now.
391 * sysdep.c (MAX_RW_COUNT): New macro, to work around kernel bugs.
392 (emacs_read, emacs_write): Use it.
393 * process.c (send_process): Adjust to the new signatures of
394 emacs_write and emacs_gnutls_write. Do not attempt to store
395 a byte offset into an 'int'; it might overflow.
396 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00483.html
398 * sound.c: Don't assume sizes fit in 'int'.
399 (struct sound_device.period_size, alsa_period_size):
400 Return EMACS_INT, not int.
401 (struct sound_device.write, vox_write, alsa_write):
402 Accept EMACS_INT, not int.
403 (wav_play, au_play): Use EMACS_INT to store sizes and to
404 record read return values.
406 2011-04-15 Ben Key <bkey76@gmail.com>
408 * keyboard.c (Qundefined): Don't declare static since it is used
410 * xfaces.c (Qbold, Qexpanded, Qitalic, Qcondensed): Don't declare
411 static since they are used in nsfont.m.
413 2011-04-15 Stefan Monnier <monnier@iro.umontreal.ca>
415 * process.c (Qprocessp): Don't declare static.
416 * lisp.h (Qprocessp): Declare again.
418 2011-04-15 Juanma Barranquero <lekktu@gmail.com>
420 * font.c (Qopentype): Don't make static (used from w32uniscribe.c).
422 2011-04-14 Paul Eggert <eggert@cs.ucla.edu>
424 Improve C-level modularity by making more things 'static'.
426 Don't publish debugger-only interfaces to other modules.
427 * lisp.h (safe_debug_print, debug_output_compilation_hack):
428 (verify_bytepos, count_markers): Move decls to the only modules
430 * region-cache.h (pp_cache): Likewise.
431 * window.h (check_all_windows): Likewise.
432 * marker.c, print.c, region-cache.c, window.c: Decls moved here.
434 * sysdep.c (croak): Now static, if
435 defined TIOCNOTTY || defined USG5 || defined CYGWIN.
436 * syssignal.h (croak): Declare only if not static.
438 * alloc.c (refill_memory_reserve): Now static if
439 !defined REL_ALLOC || defined SYSTEM_MALLOC.
440 * lisp.h (refill_memory_reserve): Declare only if not static.
442 * xsettings.c, xsettings.h (xsettings_get_system_normal_font):
443 Define only if USE_LUCID.
445 * xrdb.c (x_customization_string, x_rm_string): Now static.
447 * xmenu.c (x_menu_wait_for_event): Export only if USE_MOTIF.
448 * xterm.h (x_menu_wait_for_event): Declare only if USE_MOTIF.
450 * xdisp.c (draw_row_with_mouse_face): Now static.
451 * dispextern.h (draw_row_with_mouse_fave): Remove decl.
453 * window.h (check_all_windows): Mark externally visible.
455 * window.c (window_deletion_count): Now static.
457 * undo.c: Make symbols static if they're not exported.
458 (last_undo_buffer, last_boundary_position, pending_boundary):
461 * textprop.c (interval_insert_behind_hooks): Now static.
462 (interval_insert_in_front_hooks): Likewise.
464 * term.c: Make symbols static if they're not exported.
465 (tty_turn_off_highlight, get_tty_terminal, max_frame_cols):
466 (max_frame_lines, tty_set_terminal_modes):
467 (tty_reset_terminal_modes, tty_turn_off_highlight):
468 (get_tty_terminal): Now static.
469 (term_mouse_moveto): Do not define if HAVE_WINDOW_SYSTEM.
470 * termhooks.h (term_mouse_moveto): Do not declare if
472 * dispextern.h (tty_set_terminal_modes, tty_reset_terminal_modes):
473 (tty_turn_off_highlight, get_tty_terminal): Remove decls.
475 * sysdep.c: Make symbols static if they're not exported.
476 (emacs_get_tty, emacs_set_tty, old_fcntl_flags, old_fcntl_owner):
478 (sigprocmask_set, full_mask): Remove; unused.
479 (wait_debugging): Mark as visible.
480 * syssignal.h (SIGFULLMASK, full_mask): Remove decls.
481 * systty.h (emacs_get_tty, emacs_set_tty): Remove decls.
483 * syntax.c (syntax_temp): Define only if !__GNUC__.
485 * sound.c (current_sound_device, current_sound): Now static.
487 * search.c (searchbufs, searchbuf_head): Now static.
489 * scroll.c (scroll_cost): Remove; unused.
490 * dispextern.h (scroll_cost): Remove decl.
492 * region-cache.h (pp_cache): Mark as externally visible.
494 * process.c: Make symbols static if they're not exported.
495 (process_tick, update_tick, create_process, chan_process):
496 (Vprocess_alist, proc_buffered_char, datagram_access):
497 (fd_callback_data, send_process_frame, process_sent_to): Now static.
498 (deactivate_process): Mark defn as static, as well as decl.
499 * lisp.h (create_process): Remove decl.
500 * process.h (chan_process, Vprocess_alist): Remove decls.
502 * print.c: Make symbols static if they're not exported.
503 (print_depth, new_backquote_output, being_printed, print_buffer):
504 (print_buffer_size, print_buffer_pos, print_buffer_pos_byte):
505 (print_interval, print_number_index, initial_stderr_stream):
507 * lisp.h (Fprinc): Remove decl.
508 (debug_output_compilation_hack): Mark as externally visible.
510 * sysdep.c (croak): Move decl from here to syssignal.h.
511 * syssignal.h (croak): Put it here, so the API can be checked when
512 'croak' is called from dissociate_if_controlling_tty.
514 * minibuf.c: Make symbols static if they're not exported.
515 (minibuf_save_list, choose_minibuf_frame): Now static.
516 * lisp.h (choose_minibuf_frame): Remove decl.
518 * lisp.h (verify_bytepos, count_markers): Mark as externally visible.
520 * lread.c: Make symbols static if they're not exported.
521 (read_objects, initial_obarray, oblookup_last_bucket_number):
523 (make_symbol): Remove; unused.
524 * lisp.h (initial_obarray, make_symbol): Remove decls.
526 * keyboard.c: Make symbols static if they're not exported.
527 (single_kboard, recent_keys_index, total_keys, recent_keys):
528 (this_command_key_count_reset, raw_keybuf, raw_keybuf_count):
529 (this_single_command_key_start, echoing, last_auto_save):
530 (read_key_sequence_cmd, dribble, recursive_edit_unwind):
531 (command_loop, echo_now, keyboard_init_hook, help_char_p):
532 (quit_throw_to_read_char, command_loop_2, top_level_1, poll_timer):
533 (Vlispy_mouse_stem, double_click_count):
535 (force_auto_save_soon): Define only if SIGDANGER.
536 (ignore_mouse_drag_p): Now static if
537 !defined HAVE_WINDOW_SYSTEM || defined USE_GTK || defined HAVE_NS.
538 (print_help): Remove; unused.
539 (stop_character, last_timer_event): Mark as externally visible.
540 * keyboard.h (ignore_mouse_drag_p): Declare only if
541 defined HAVE_WINDOW_SYSTEM && !defined USE_GTK && !defined HAVE_NS.
542 (echo_now, help_char_p, quit_throw_to_read_char): Remove decls.
543 * lisp.h (echoing): Remove decl.
544 (force_auto_save_soon): Declare only if SIGDANGER.
545 * xdisp.c (redisplay_window): Simplify code, to make it more
546 obvious that ignore_mouse_drag_p is not accessed if !defined
547 USE_GTK && !defined HAVE_NS.
549 * intervals.c: Make symbols static if they're not exported.
550 (merge_properties_sticky, merge_interval_right, delete_interval):
552 * intervals.h (merge_interval_right, delete_interval): Remove decls.
554 * insdel.c: Make symbols static if they're not exported.
555 However, leave prepare_to_modify_buffer alone. It's never
556 called from outside this function, but that appears to be a bug.
557 (combine_after_change_list, combine_after_change_buffer):
558 (adjust_after_replace, signal_before_change): Now static.
559 (adjust_after_replace_noundo): Remove; unused.
560 * lisp.h (adjust_after_replace, adjust_after_replace_noundo):
561 (signal_before_change): Remove decls.
563 * indent.c (val_compute_motion, val_vmotion): Now static.
565 * image.c: Make symbols static if they're not exported.
566 * dispextern.h (x_create_bitmap_from_xpm_data): Do not declare
568 * image.c (x_create_bitmap_from_xpm_data): Do not define if USE_GTK.
569 (xpm_color_cache, ct_table, ct_colors_allocated): Now static.
571 * fringe.c (standard_bitmaps): Now static.
572 (max_used_fringe_bitmap): Now static, unless HAVE_NS.
574 * frame.c: Make symbols static if they're not exported.
575 (x_report_frame_params, make_terminal_frame): Now static.
576 (get_frame_param): Now static, unless HAVE_NS.
577 (x_fullscreen_adjust): Define if WINDOWSNT, not if HAVE_WINDOW_SYSTEM.
578 (x_get_resource_string): Remove; not used.
579 * frame.h (make_terminal_frame, x_report_frame_params):
580 (x_get_resource_string); Remove decls.
581 (x_fullscreen_adjust): Declare only if WINDOWSNT.
582 * lisp.h (get_frame_param): Declare only if HAVE_NS.
584 * font.c, fontset.c: Make symbols static if they're not exported.
585 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): New macro.
586 (FACE_SUITABLE_FOR_CHAR_P): Use it.
587 * font.c (font_close_object): Now static.
588 * font.h (font_close_object): Remove.
589 * fontset.c (FONTSET_OBJLIST): Remove.
590 (free_realized_fontset) #if-0 the body, which does nothing.
591 (face_suitable_for_char_p): #if-0, as it's never called.
592 * fontset.h (face_suitable_for_char_p): Remove decl.
593 * xfaces.c (face_at_string_position): Use
594 FACE_SUITABLE_FOR_ASCII_CHAR_P, not FACE_SUITABLE_FOR_CHAR_P,
595 since 0 is always ASCII.
597 * fns.c (weak_hash_tables): Now static.
599 * fileio.c: Make symbols static if they're not exported.
600 (auto_saving, auto_save_mode_bits, auto_save_error_occurred):
601 (Vwrite_region_annotation_buffers): Now static.
603 * eval.c: Make symbols static if they're not exported.
604 (backtrace_list, lisp_eval_depth, when_entered_debugger): Now static.
605 * lisp.h (backtrace_list): Remove decl.
607 * emacs.c: Make symbols static if they're not exported.
608 (malloc_state_ptr, malloc_using_checking, syms_of_emacs):
609 (fatal_error_code, fatal_error_signal_hook, standard_args):
611 (fatal_error_signal): Now static, unless FLOAT_CATCH_SIGKILL.
612 (DEFINE_DUMMY_FUNCTION): Mark function as externally visible.
613 (__CTOR_LIST__, __DTOR_LIST__): Now externally visible.
614 * lisp.h (fatal_error_signal_hook): Remove decl.
615 (fatal_error_signal): Declare only if FLOAT_CATCH_SIGKILL.
617 * editfns.c: Move a (normally-unused) function to its only use.
618 * editfns.c, lisp.h (get_operating_system_release): Remove.
619 * process.c (init_process) [DARWIN_OS]: Do it inline, as it is not
620 worth the hassle of breaking this out.
622 * xterm.c: Make symbols static if they're not exported.
623 (x_raise_frame, x_lower_frame, x_wm_set_window_state):
624 (x_wm_set_icon_pixmap, x_initialize, XTread_socket_fake_io_error):
625 (x_destroy_window, x_delete_display):
627 (x_dispatch_event): Now static if ! (USE_MOTIF || USE_X_TOOLKIT).
628 (x_mouse_leave): Remove; unused.
629 * xterm.h (x_display_info_for_name, x_raise_frame, x_lower_frame):
630 (x_destroy_window, x_wm_set_window_state, x_wm_set_icon_pixmap):
631 (x_delete_display, x_initialize, x_set_border_pixel, x_screen_planes):
633 (x_mouse_leave): Declare only if WINDOWSNT.
634 (x_dispatch_event): Declare only if USE_MOTIF or USE_X_TOOLKIT.
635 (xic_create_fontsetname): Declare only if HAVE_X_WINDOWS &&
638 * ftxfont.c: Make symbols static if they're not exported.
639 (ftxfont_driver): Export only if !defined HAVE_XFT && def8ined
641 * font.h (ftxfont_driver): Likewise.
643 * xfns.c: Make symbols static if they're not exported.
644 (x_last_font_name, x_display_info_for_name):
645 (x_set_foreground_color, x_set_background_color, x_set_mouse_color):
646 (x_set_cursor_color, x_set_border_pixel, x_set_border_color):
647 (x_set_cursor_type, x_set_icon_type, x_set_icon_name):
648 (x_set_scroll_bar_foreground, x_set_scroll_bar_background):
649 (x_explicitly_set_name, x_set_title, xic_defaut_fontset, tip_timer):
650 (last_show_tip_args): Now static.
651 (xic_defaut_fontset, xic_create_fontsetname): Define only if
652 defined HAVE_X_WINDOWS && defined USE_X_TOOLKIT
653 (x_screen_planes): Remove; unused.
654 * dispextern.h (x_screen_planes): Remove decl.
656 * dispnew.c: Make symbols static if they're not exported.
657 * dispextern.h (redraw_garbaged_frames, scrolling):
658 (increment_row_positions): Remove.
659 * dispnew.c (new_glyph_matrix, increment_row_positions, scrolling):
660 (delayed_size_change, glyph_matrix_count, glyph_pool_count):
662 (redraw_garbaged_frames): Remove; unused.
664 * xfaces.c: Make symbols static if they're not exported.
665 * dispextern.h (ascii_face_of_lisp_face, free_realized_face):
667 * xterm.h (defined_color): Remove decls.
668 (x_free_dpy_colors): Declare only if USE_X_TOOLKIT.
669 * xfaces.c (tty_suppress_bold_inverse_default_colors_p):
670 (menu_face_changed_default, defined_color, free_realized_face):
671 (x_free_dpy_colors): Define only if USE_X_TOOLKIT.
672 (ascii_face_of_lisp_face): Remove; unused.
674 * xdisp.c: Make symbols static if they're not exported.
675 * dispextern.h (scratch_glyph_row, window_box_edges):
676 (glyph_to_pixel_coords, set_cursor_from_row):
677 (get_next_display_element, set_iterator_to_next):
678 (highlight_trailing_whitespace, frame_to_window_pixel_xy):
679 (show_mouse_face): Remove decls
680 * frame.h (message_buf_print): Likewise.
681 * lisp.h (pop_message, set_message, check_point_in_composition):
683 * xterm.h (set_vertical_scroll_bar): Likewise.
684 * xdisp.c (list_of_error, Vmessage_stack, line_number_displayed):
685 (message_buf_print, scratch_glyph_row, displayed_buffer):
686 (set_iterator_to_next, pop_message, set_message, set_cursor_from_row):
687 (get_next_display_element, show_mouse_face, window_box_edges):
688 (frame_to_window_pixel_xy, check_point_in_composition):
689 (set_vertical_scroll_bar, highlight_trailing_whitespace): Now static.
690 (glyph_to_pixel_coords): Remove; unused.
692 * dired.c (file_name_completion): Now static.
694 * dbusbind.c (xd_in_read_queued_messages): Now static.
696 * lisp.h (circular_list_error, FOREACH): Remove; unused.
697 * data.c (circular_list_error): Remove.
699 * commands.h (last_point_position, last_point_position_buffer):
700 (last_point_position_window): Remove decls.
701 * keyboard.c: Make these variables static.
703 * coding.h (coding, code_convert_region, encode_coding_gap): Remove
705 * coding.c (Vsjis_coding_system, Vbig5_coding_system):
706 (iso_code_class, detect_coding, code_convert_region): Now static.
707 (encode_coding_gap): Remove; unused.
709 * chartab.c (chartab_chars, chartab_bits): Now static.
711 * charset.h (charset_iso_8859_1): Remove decl.
712 * charset.c (charset_iso_8859_1, charset_emacs, map_charset_for_dump):
715 * ccl.h (check_ccl_update, Vccl_program_table): Remove decls.
716 * ccl.c (Vccl_program_table): Now static.
717 (check_ccl_update): Remove; unused.
719 * category.c (SET_CATEGORY_SET, set_category_set): Move here.
720 * category.h: ... from here.
721 * category.c (check_category_table, set_category_set): Now static.
723 * casetab.c (Vascii_upcase_table, Vascii_eqv_table): Now static.
724 * lisp.h: Remove these decls.
726 * buffer.c (buffer_count): Remove unused var.
728 * bidi.c (bidi_dump_cached_states): Mark as externally visible,
729 so that it's not optimized away.
730 (bidi_ignore_explicit_marks_for_paragraph_level): Likewise.
731 * dispextern.h (bidi_dump_cached_states): Remove, since it's
732 exported only to the debugger.
734 * atimer.c (alarm_signal_handler, run_all_atimers): Now static.
735 * atimer.h (run_all_atimers): Removed; not exported.
737 font.c: Make copy_font_spec and merge_font_spec ordinary C functions.
738 * font.c (copy_font_spec): Rename from Fcopy_font_spec, since it
739 was inaccessible from Lisp.
740 (merge_font_spec): Likewise, renaming from Fmerge_font_spec.
741 * font.c, font.h, fontset.c, xfaces.c, xfont.c: Change all uses.
743 alloc.c: Import and export fewer symbols, and remove unused items.
744 * lisp.h (suppress_checking, die): Declare only if ENABLE_CHECKING
746 (suppress_checking): Add EXTERNALLY_VISIBLE attribute, so that
747 it's not optimized away by whole-program optimization.
748 (message_enable_multibyte, free_misc): Remove.
749 (catchlist, handlerlist, mark_backtrace):
750 Declare only if BYTE_MARK_STACK.
751 (mark_byte_stack): Likewise, fixing a ifdef-vs-if typo.
752 * alloc.c (pure): Export only if VIRT_ADDR_VARIES is defined.
753 (message_enable_multibyte): Remove decl.
754 (free_misc, interval_free_list, float_block, float_block_index):
755 (n_float_blocks, float_free_list, cons_block, cons_block_index):
756 (cons_free_list, last_marked_index):
758 (suppress_checking, die): Define only if ENABLE_CHECKING is defined.
759 * eval.c (catchlist, handlerlist): Export only if BYTE_MARK_STACK.
760 (mark_backtrace): Define only if BYTE_MARK_STACK.
761 * xdisp.c (message_enable_multibyte): Now static.
763 Declare Lisp_Object Q* variables to be 'static' if not exported.
764 This makes it easier for human readers (and static analyzers)
765 to see whether these variables are used from other modules.
766 * alloc.c, buffer.c, bytecode.c, callint.c, casetab.c, category.c:
767 * ccl.c, character.c, charset.c, cmds.c, coding.c, composite.c:
768 * data.c, dbusbind.c, dired.c, editfns.c, eval.c, fileio.c, fns.c:
769 * font.c, frame.c, fringe.c, ftfont.c, image.c, keyboard.c, keymap.c:
770 * lread.c, macros.c, minibuf.c, print.c, process.c, search.c:
771 * sound.c, syntax.c, textprop.c, window.c, xdisp.c, xfaces.c, xfns.c:
772 * xmenu.c, xselect.c:
773 Declare Q* vars static if they are not used in other modules.
774 * ccl.h, character.h, charset.h, coding.h, composite.h, font.h:
775 * frame.h, intervals.h, keyboard.h, lisp.h, process.h, syntax.h:
776 Remove decls of unexported vars.
777 * keyboard.h (EVENT_HEAD_UNMODIFIED): Remove now-unused macro.
779 * lisp.h (DEFINE_FUNC): Make sname 'static'.
781 Make Emacs functions such as Fatom 'static' by default.
782 This makes it easier for human readers (and static analyzers)
783 to see whether these functions can be called from other modules.
784 DEFUN now defines a static function. To make the function external
785 so that it can be used in other C modules, use the new macro DEFUE.
786 * lisp.h (Funibyte_char_to_multibyte, Fsyntax_table_p):
787 (Finit_image_library):
788 (Feval_region, Fbacktrace, Ffetch_bytecode, Fswitch_to_buffer):
789 (Ffile_executable_p, Fmake_symbolic_link, Fcommand_execute):
790 (Fget_process, Fdocumentation_property, Fbyte_code, Ffile_attributes):
791 Remove decls, since these functions are now static.
792 (Funintern, Fget_internal_run_time): New decls, since these functions
793 were already external.
795 * alloc.c, buffer.c, callint.c, callproc.c, casefiddle.c, casetab.c:
796 * ccl.c, character.c, chartab.c, cmds.c, coding.c, data.c, dispnew.c:
797 * doc.c, editfns.c, emacs.c, eval.c, fileio.c, filelock.c, floatfns.c:
798 * fns.c, font.c, fontset.c, frame.c, image.c, indent.c:
799 * keyboard.c, keymap.c, lread.c:
800 * macros.c, marker.c, menu.c, minibuf.c, print.c, process.c, search.c:
801 * syntax.c, term.c, terminal.c, textprop.c, undo.c:
802 * window.c, xdisp.c, xfaces.c, xfns.c, xmenu.c, xsettings.c:
803 Mark functions with DEFUE instead of DEFUN,
804 if they are used in other modules.
805 * buffer.c (Fset_buffer_major_mode, Fdelete_overlay): New forward
806 decls for now-static functions.
807 * buffer.h (Fdelete_overlay): Remove decl.
808 * callproc.c (Fgetenv_internal): Mark as internal.
809 * composite.c (Fremove_list_of_text_properties): Remove decl.
810 (Fcomposition_get_gstring): New forward static decl.
811 * composite.h (Fcomposite_get_gstring): Remove decl.
812 * dired.c (Ffile_attributes): New forward static decl.
813 * doc.c (Fdocumntation_property): New forward static decl.
814 * eval.c (Ffetch_bytecode): New forward static decl.
815 (Funintern): Remove extern decl; now in .h file where it belongs.
816 * fileio.c (Fmake_symbolic_link): New forward static decl.
817 * image.c (Finit_image_library): New forward static decl.
818 * insdel.c (Fcombine_after_change_execute): Make forward decl static.
819 * intervals.h (Fprevious_property_change):
820 (Fremove_list_of_text_properties): Remove decls.
821 * keyboard.c (Fthis_command_keys): Remove decl.
822 (Fcommand_execute): New forward static decl.
823 * keymap.c (Flookup_key): New forward static decl.
824 (Fcopy_keymap): Now static.
825 * keymap.h (Flookup_key): Remove decl.
826 * process.c (Fget_process): New forward static decl.
827 (Fprocess_datagram_address): Mark as internal.
828 * syntax.c (Fsyntax_table_p): New forward static decl.
829 (skip_chars): Remove duplicate decl.
830 * textprop.c (Fprevious_property_change): New forward static decl.
831 * window.c (Fset_window_fringes, Fset_window_scroll_bars):
833 (Fset_window_margins, Fset_window_vscroll): New forward static decls.
834 * window.h (Fset_window_vscroll, Fset_window_margins): Remove decls.
836 * editfns.c (Fformat): Remove unreachable code.
838 2011-04-14 Andreas Schwab <schwab@linux-m68k.org>
840 * fileio.c (Finsert_file_contents): Fix typo in 2005-05-13
843 2011-04-13 Eli Zaretskii <eliz@gnu.org>
845 * xdisp.c (handle_invisible_prop): Don't call bidi_paragraph_init
846 when at ZV. (Bug#8487)
848 2011-04-12 Andreas Schwab <schwab@linux-m68k.org>
850 * charset.c (Fclear_charset_maps): Use xfree instead of free.
852 * keyboard.c (parse_tool_bar_item): Likewise.
853 * sound.c (sound_cleanup, alsa_close): Likewise.
854 * termcap.c (tgetent): Likewise.
855 * xfns.c (x_default_font_parameter): Likewise.
856 * xsettings.c (read_and_apply_settings): Likewise.
858 * alloc.c (overrun_check_malloc, overrun_check_realloc)
859 (overrun_check_free): Protoize.
861 2011-04-12 Paul Eggert <eggert@cs.ucla.edu>
863 * sysdep.c (emacs_read, emacs_write): Check for negative sizes
864 since callers should never pass a negative size.
865 Change the signature to match that of plain 'read' and 'write'; see
866 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00397.html>.
867 * lisp.h: Update prototypes of emacs_write and emacs_read.
869 2011-04-11 Eli Zaretskii <eliz@gnu.org>
871 * xdisp.c (redisplay_window): Don't try to determine the character
872 position of the scroll margin if the window start point w->startp
873 is outside the buffer's accessible region. (Bug#8468)
875 2011-04-10 Eli Zaretskii <eliz@gnu.org>
877 Fix write-region and its subroutines for buffers > 2GB.
878 * fileio.c (a_write, e_write): Modify declaration of arguments and
879 local variables to support buffers larger than 2GB.
880 (Fcopy_file): Use EMACS_INT for return value of emacs_read.
882 * sysdep.c (emacs_write, emacs_read): Use ssize_t for last
883 argument, local variables, and return value.
885 * lisp.h: Update prototypes of emacs_write and emacs_read.
887 * sound.c (vox_write): Use ssize_t for return value of emacs_write.
889 2011-04-10 Paul Eggert <eggert@cs.ucla.edu>
891 * xdisp.c (vmessage): Use memchr, not strnlen, which some hosts lack.
893 Fix more problems found by GCC 4.6.0's static checks.
895 * xdisp.c (vmessage): Use a better test for character truncation.
897 * charset.c (load_charset_map): <, not <=, for optimization,
898 and to avoid potential problems with integer overflow.
899 * chartab.c (sub_char_table_set_range, char_table_set_range): Likewise.
900 * casetab.c (set_identity, shuffle): Likewise.
901 * editfns.c (Fformat): Likewise.
902 * syntax.c (skip_chars): Likewise.
904 * xmenu.c (set_frame_menubar): Allocate smaller local vectors.
905 This also lets GCC 4.6.0 generate slightly better loop code.
907 * callint.c (Fcall_interactively): <, not <=, for optimization.
908 (Fcall_interactively): Count the number of arguments produced,
909 not the number of arguments given. This is simpler and lets GCC
910 4.6.0 generate slightly better code.
912 * ftfont.c: Distingish more carefully between FcChar8 and char.
913 The previous code passed unsigned char * to a functions like
914 strlen and xstrcasecmp that expect char *, which does not
915 conform to the C standard.
916 (get_adstyle_property, ftfont_pattern_entity): Use FcChar8 for
917 arguments to FcPatternGetString, and explicitly cast FcChar8 * to
918 char * when the C standard requires it.
920 * keyboard.c (read_char): Remove unused var.
922 * eval.c: Port to Windows vsnprintf (Bug#8435).
924 (SIZE_MAX): Define if the headers do not.
925 (verror): Do not give up if vsnprintf returns a negative count.
926 Instead, grow the buffer. This ports to Windows vsnprintf, which
927 does not conform to C99. Problem reported by Eli Zaretskii.
928 Also, simplify the allocation scheme, by avoiding the need for
929 calling realloc, and removing the ALLOCATED variable.
931 * eval.c (verror): Initial buffer size is 4000 (not 200) bytes.
933 Remove invocations of doprnt, as Emacs now uses vsnprintf.
934 But keep the doprint source code for now, as we might revamp it
935 and use it again (Bug#8435).
936 * lisp.h (doprnt): Remove.
937 * Makefile.in (base_obj): Remove doprnt.o.
938 * deps.mk (doprnt.o): Remove.
940 error: Print 32- and 64-bit integers portably (Bug#8435).
941 Without this change, on typical 64-bit hosts error ("...%d...", N)
942 was used to print both 32- and 64-bit integers N, which relied on
944 * lisp.h, src/m/amdx86-64.h, src/m/ia64.h, src/m/ibms390x.h (pEd):
946 * lisp.h (error, verror): Mark as printf-like functions.
947 * eval.c (verror): Use vsnprintf, not doprnt, to do the real work.
948 Report overflow in size calculations when allocating printf buffer.
949 Do not truncate output string at its first null byte.
950 * xdisp.c (vmessage): Use vsnprintf, not doprnt, to do the real work.
951 Truncate the output at a character boundary, since vsnprintf does not
953 * charset.c (check_iso_charset_parameter): Convert internal
954 character to string before calling 'error', since %c now has the
956 * coding.c (Fdecode_sjis_char, Fdecode_big5_char): Avoid int
957 overflow when computing char to be passed to 'error'. Do not
958 pass Lisp_Object to 'error'; pass the integer instead.
959 * nsfns.m (Fns_do_applescript): Use int, not long, since it's
960 formatted with plain %d.
962 * eval.c (internal_lisp_condition_case): Don't pass spurious arg.
964 * keyboard.c (access_keymap_keyremap): Print func name, not garbage.
966 * coding.c (Fdecode_sjis_char): Don't assume CODE fits in int.
968 * xterm.c (x_catch_errors): Remove duplicate declaration.
970 * term.c (maybe_fatal): Mark its 3rd arg as a printf format, too.
972 * xdisp.c, lisp.h (message_nolog): Remove; unused.
974 2011-04-10 Jim Meyering <meyering@redhat.com>
976 use ssize_t and size_t for read- and write-like emacs_gnutls_* functions
977 * gnutls.c (emacs_gnutls_read): Adjust signature to be more read-like:
978 return ssize_t not "int", and use size_t as the buffer length.
979 (emacs_gnutls_write): Likewise, and make the buffer pointer "const".
980 * gnutls.h: Update declarations.
981 * process.c (read_process_output): Use ssize_t, to match.
982 (send_process): Likewise.
984 2011-04-09 Chong Yidong <cyd@stupidchicken.com>
986 * image.c (Fimagemagick_types): Doc fix, and comment cleanup.
988 2011-04-09 Chong Yidong <cyd@stupidchicken.com>
990 * ftfont.c (get_adstyle_property, ftfont_pattern_entity): Use
991 unsigned char, to match FcChar8 type definition.
993 * xterm.c (handle_one_xevent):
994 * xmenu.c (create_and_show_popup_menu):
995 * xselect.c (x_decline_selection_request)
996 (x_reply_selection_request): Avoid type-punned deref of X events.
998 2011-04-09 Eli Zaretskii <eliz@gnu.org>
1000 Fix some uses of `int' instead of EMACS_INT.
1001 * search.c (string_match_1, fast_string_match)
1002 (fast_c_string_match_ignore_case, fast_string_match_ignore_case)
1003 (scan_buffer, find_next_newline_no_quit)
1004 (find_before_next_newline, search_command, Freplace_match)
1005 (Fmatch_data): Make some `int' variables be EMACS_INT.
1007 * xdisp.c (display_count_lines): 3rd argument and return value now
1008 EMACS_INT. All callers changed.
1009 (pint2hrstr): Last argument is now EMACS_INT.
1011 * coding.c (detect_coding_utf_8, detect_coding_emacs_mule)
1012 (detect_coding_iso_2022, detect_coding_sjis, detect_coding_big5)
1013 (detect_coding_ccl, detect_coding_charset, decode_coding_utf_8)
1014 (decode_coding_utf_16, decode_coding_emacs_mule)
1015 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5)
1016 (decode_coding_ccl, decode_coding_charset)
1017 <consumed_chars, consumed_chars_base>: Declare EMACS_INT.
1018 (decode_coding_iso_2022, decode_coding_emacs_mule)
1019 (decode_coding_sjis, decode_coding_big5, decode_coding_charset)
1020 <char_offset, last_offset>: Declare EMACS_INT.
1021 (encode_coding_utf_8, encode_coding_utf_16)
1022 (encode_coding_emacs_mule, encode_invocation_designation)
1023 (encode_designation_at_bol, encode_coding_iso_2022)
1024 (encode_coding_sjis, encode_coding_big5, encode_coding_ccl)
1025 (encode_coding_raw_text, encode_coding_charset) <produced_chars>:
1027 (ASSURE_DESTINATION): Declare more_bytes EMACS_INT.
1028 (encode_invocation_designation): Last argument P_NCHARS is now
1030 (decode_eol): Declare pos_byte, pos, and pos_end EMACS_INT.
1031 (produce_chars): from_nchars and to_nchars are now EMACS_INT.
1033 * coding.h (struct coding_system) <head_ascii>: Declare EMACS_INT.
1036 * ccl.c (Fccl_execute_on_string): Declare some variables
1039 2011-04-08 Samuel Thibault <sthibault@debian.org> (tiny change)
1041 * term.c (init_tty): Fix incorrect ifdef placement (Bug#8450).
1043 2011-03-19 Christoph Scholtes <cschol2112@googlemail.com>
1045 * process.c (Fformat_network_address): Doc fix.
1047 2011-04-08 T.V. Raman <tv.raman.tv@gmail.com> (tiny change)
1049 * xml.c (parse_region): Avoid creating spurious whiespace nodes.
1051 2011-04-08 Chong Yidong <cyd@stupidchicken.com>
1053 * keyboard.c (read_char): Call Lisp function help-form-show,
1054 instead of using internal_with_output_to_temp_buffer.
1055 (Qhelp_form_show): New var.
1056 (syms_of_keyboard): Use DEFSYM macro.
1058 * print.c (internal_with_output_to_temp_buffer): Function deleted.
1060 * lisp.h (internal_with_output_to_temp_buffer): Remove prototype.
1062 2011-04-06 Chong Yidong <cyd@stupidchicken.com>
1064 * process.c (Flist_processes): Removed to Lisp.
1065 (list_processes_1): Deleted.
1067 2011-04-06 Eli Zaretskii <eliz@gnu.org>
1069 * msdos.c (careadlinkat, careadlinkatcwd): MS-DOS replacements.
1071 * w32.c (careadlinkat, careadlinkatcwd): New always-fail stubs.
1073 2011-04-06 Paul Eggert <eggert@cs.ucla.edu>
1075 Fix more problems found by GCC 4.6.0's static checks.
1077 * xmenu.c (Fx_popup_dialog): Don't assume string is free of formats.
1079 * menu.c (Fx_popup_menu): Don't assume error_name lacks printf formats.
1081 * lisp.h (message, message_nolog, fatal): Mark as printf-like.
1083 * xdisp.c (vmessage): Mark as a printf-like function.
1085 * term.c (vfatal, maybe_fatal): Mark as printf-like functions.
1087 * sound.c (sound_warning): Don't crash if arg contains a printf format.
1089 * image.c (tiff_error_handler, tiff_warning_handler): Mark as
1090 printf-like functions.
1091 (tiff_load): Add casts to remove these marks before passing them
1092 to system-supplied API.
1094 * eval.c (Fsignal): Remove excess argument to 'fatal'.
1096 * coding.c (EMIT_ONE_BYTE, EMIT_TWO_BYTES): Use unsigned, not int.
1097 This avoids several warnings with gcc -Wstrict-overflow.
1098 (DECODE_COMPOSITION_RULE): If the rule is invalid, goto invalid_code
1099 directly, rather than having caller test rule sign. This avoids
1100 some unnecessary tests.
1101 * composite.h (COMPOSITION_ENCODE_RULE_VALID): New macro.
1102 (COMPOSITION_ENCODE_RULE): Arguments now must be valid. This
1103 affects only one use, in DECODE_COMPOSITION_RULE, which is changed.
1105 * xfont.c (xfont_text_extents): Remove var that was set but not used.
1106 (xfont_open): Avoid unnecessary tests.
1108 * composite.c (composition_gstring_put_cache): Use unsigned integer.
1110 * composite.h, composite.c (composition_gstring_put_cache):
1111 Use EMACS_INT, not int, for length.
1113 * composite.h (COMPOSITION_DECODE_REFS): New macro,
1114 breaking out part of COMPOSITION_DECODE_RULE.
1115 (COMPOSITION_DECODE_RULE): Use it.
1116 * composite.c (get_composition_id): Remove unused local vars,
1117 by using the new macro.
1119 * textprop.c (set_text_properties_1): Change while to do-while,
1120 since the condition is always true at first.
1122 * intervals.c (graft_intervals_into_buffer): Mark var as used.
1123 (interval_deletion_adjustment): Return unsigned value.
1126 * process.c (list_processes_1, create_pty, read_process_output):
1127 (exec_sentinel): Remove vars that were set but not used.
1128 (create_pty): Remove unnecessary "volatile"s.
1129 (Fnetwork_interface_info): Avoid possibility of int overflow.
1130 (read_process_output): Do adaptive read buffering even if carryover.
1131 (read_process_output): Simplify nbytes computation if buffered.
1133 * bytecode.c (exec_byte_code): Rename local to avoid shadowing.
1135 * syntax.c (scan_words): Remove var that was set but not used.
1136 (update_syntax_table): Use unsigned instead of int.
1138 * lread.c (lisp_file_lexically_bound_p): Use ints rather than endptrs.
1139 (lisp_file_lexically_bound_p, read1): Use unsigned instead of int.
1140 (safe_to_load_p): Make the end-of-loop test the inverse of the in-loop.
1142 * print.c (print_error_message): Avoid int overflow.
1144 * font.c (font_list_entities): Redo for clarity,
1145 so that reader need not know FONT_DPI_INDEX + 1 == FONT_SPACING_INDEX.
1147 * font.c (font_find_for_lface, Ffont_get_glyphs): Remove unused vars.
1148 (font_score): Avoid potential overflow in diff calculation.
1150 * fns.c (substring_both): Remove var that is set but not used.
1151 (sxhash): Redo loop for clarity and to avoid wraparound warning.
1153 * eval.c (funcall_lambda): Rename local to avoid shadowing.
1155 * alloc.c (mark_object_loop_halt, mark_object): Use size_t, not int.
1156 Otherwise, GCC 4.6.0 optimizes the loop check away since the check
1157 can always succeed if overflow has undefined behavior.
1159 * search.c (boyer_moore, wordify): Remove vars set but not used.
1160 (wordify): Omit three unnecessary tests.
1162 * indent.c (MULTIBYTE_BYTES_WIDTH): Don't compute wide_column.
1163 All callers changed. This avoids the need for an unused var.
1165 * casefiddle.c (casify_region): Remove var that is set but not used.
1167 * dired.c (file_name_completion): Remove var that is set but not used.
1169 * fileio.c (Finsert_file_contents): Make EOF condition clearer.
1171 * fileio.c (Finsert_file_contents): Avoid signed integer overflow.
1172 (Finsert_file_contents): Remove unnecessary code checking fd.
1174 * minibuf.c (read_minibuf_noninteractive): Use size_t for sizes.
1175 Check for integer overflow on size calculations.
1177 * buffer.c (Fprevious_overlay_change): Remove var that is set
1180 * keyboard.c (menu_bar_items, read_char_minibuf_menu_prompt):
1181 Remove vars that are set but not used.
1182 (timer_check_2): Don't assume timer-list and idle-timer-list are lists.
1183 (timer_check_2): Mark vars as initialized.
1185 * gtkutil.c (xg_get_file_with_chooser): Mark var as initialized.
1187 * image.c (lookup_image): Remove var that is set but not used.
1188 (xbm_load): Use parse_p, for gcc -Werror=unused-but-set-variable.
1190 * fontset.c (Finternal_char_font, Ffontset_info): Remove vars
1191 that are set but not used.
1193 * xfns.c (make_invisible_cursor): Don't return garbage
1194 if XCreateBitmapFromData fails (Bug#8410).
1196 * xselect.c (x_get_local_selection, x_handle_property_notify):
1197 Remove vars that are set but not used.
1199 * xfns.c (x_create_tip_frame): Remove var that is set but not used.
1200 (make_invisible_cursor): Initialize a possibly-uninitialized variable.
1202 * xterm.c (x_scroll_bar_to_input_event) [!USE_GTK]:
1203 Remove var that is set but not used.
1204 (scroll_bar_windows_size): Now size_t, not int.
1205 (x_send_scroll_bar_event): Use size_t, not int, for sizes.
1208 * xfaces.c (realize_named_face): Remove vars that are set but not used.
1209 (map_tty_color) [!defined MSDOS]: Likewise.
1211 * term.c (tty_write_glyphs): Use size_t; this avoids overflow warning.
1213 * coding.c: Remove vars that are set but not used.
1214 (DECODE_COMPOSITION_RULE): Remove 2nd arg, which is unused.
1215 All callers changed.
1216 (decode_coding_utf_8, decode_coding_utf_16 decode_coding_emacs_mule):
1217 (decode_coding_iso_2022, encode_coding_sjis, encode_coding_big5):
1218 (decode_coding_charset): Remove vars that are set but not used.
1220 * bytecode.c (Fbyte_code) [!defined BYTE_CODE_SAFE]: Remove var
1221 that is set but not used.
1223 * print.c (print_object): Remove var that is set but not used.
1225 Replace 2 copies of readlink code with 1 gnulib version (Bug#8401).
1226 The gnulib version avoids calling malloc in the usual case,
1227 and on 64-bit hosts doesn't have some arbitrary 32-bit limits.
1228 * fileio.c (Ffile_symlink_p): Use emacs_readlink.
1229 * filelock.c (current_lock_owner): Likewise.
1230 * lisp.h (READLINK_BUFSIZE, emacs_readlink): New function.
1231 * sysdep.c: Include allocator.h, careadlinkat.h.
1232 (emacs_no_realloc_allocator): New static constant.
1233 (emacs_readlink): New function.
1234 * deps.mk (sysdep.o): Depend on ../lib/allocator.h and on
1235 ../lib/careadlinkat.h.
1237 2011-04-04 Stefan Monnier <monnier@iro.umontreal.ca>
1239 * keyboard.c (safe_run_hook_funcall): Fix last change (don't stop at the
1240 first non-nil return value).
1242 2011-04-03 Jan Djärv <jan.h.d@swipnet.se>
1244 * nsterm.m (ns_update_auto_hide_menu_bar): Define MAC_OS_X_VERSION_10_6
1245 if not defined (Bug#8403).
1247 2011-04-02 Juanma Barranquero <lekktu@gmail.com>
1249 * xdisp.c (display_count_lines): Remove parameter `start',
1250 unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
1251 (get_char_face_and_encoding): Remove parameter `multibyte_p',
1252 unused since 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
1253 (fill_stretch_glyph_string): Remove parameters `row' and `area',
1254 unused at least since Kim's GUI unification at 2003-03-16T20:45:46Z!storm@cua.dk
1255 and thereabouts. All callers changed.
1256 (get_per_char_metric): Remove parameter `f', unused since
1257 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
1259 2011-04-02 Jim Meyering <meyering@redhat.com>
1261 do not dereference NULL upon failed strdup
1262 * nsfont.m (ns_descriptor_to_entity): Use xstrdup, not strdup.
1263 (ns_get_family): Likewise.
1265 2011-04-02 Juanma Barranquero <lekktu@gmail.com>
1267 * eval.c (unwind_to_catch) [DEBUG_GCPRO]: Remove redundant assignment.
1269 2011-04-02 Jan Djärv <jan.h.d@swipnet.se>
1271 * nsterm.m (ns_update_auto_hide_menu_bar): Only for OSX 10.6 or
1274 2011-04-01 Stefan Monnier <monnier@iro.umontreal.ca>
1276 Add lexical binding.
1278 * window.c (Ftemp_output_buffer_show): New fun.
1279 (Fsave_window_excursion):
1280 * print.c (Fwith_output_to_temp_buffer): Move to subr.el.
1282 * lread.c (lisp_file_lexically_bound_p): New function.
1283 (Fload): Bind Qlexical_binding.
1284 (readevalloop): Remove `evalfun' arg.
1285 Bind Qinternal_interpreter_environment.
1286 (Feval_buffer): Bind Qlexical_binding.
1287 (defvar_int, defvar_bool, defvar_lisp_nopro, defvar_kboard):
1289 (syms_of_lread): Declare `lexical-binding'.
1291 * lisp.h (struct Lisp_Symbol): New field `declared_special'.
1293 * keyboard.c (eval_dyn): New fun.
1294 (menu_item_eval_property): Use it.
1296 * image.c (parse_image_spec): Use Ffunctionp.
1298 * fns.c (concat, mapcar1): Accept byte-code-functions.
1300 * eval.c (Fsetq): Handle lexical vars.
1301 (Fdefun, Fdefmacro, Ffunction): Make closures when needed.
1302 (Fdefconst, Fdefvaralias, Fdefvar): Mark as dynamic.
1303 (FletX, Flet): Obey lexical binding.
1304 (Fcommandp): Handle closures.
1305 (Feval): New `lexical' arg.
1306 (eval_sub): New function extracted from Feval. Use it almost
1307 everywhere where Feval was used. Look up vars in lexical env.
1309 (Ffunctionp): Move from subr.el.
1310 (Ffuncall): Handle closures.
1311 (apply_lambda): Remove `eval_flags'.
1312 (funcall_lambda): Handle closures and new byte-code-functions.
1313 (Fspecial_variable_p): New function.
1314 (syms_of_eval): Initialize the Vinternal_interpreter_environment var,
1315 but without exporting it to Lisp.
1317 * doc.c (Fdocumentation, store_function_docstring):
1318 * data.c (Finteractive_form): Handle closures.
1320 * callint.c (Fcall_interactively): Preserve lexical-binding mode for
1323 * bytecode.c (Bstack_ref, Bstack_set, Bstack_set2, BdiscardN): New
1325 (exec_byte_code): New function extracted from Fbyte_code to handle new
1326 calling convention for byte-code-functions. Add new byte-codes.
1328 * buffer.c (defvar_per_buffer): Set new `declared_special' field.
1330 * alloc.c (Fmake_symbol): Init new `declared_special' field.
1332 2011-03-31 Juanma Barranquero <lekktu@gmail.com>
1334 * xdisp.c (redisplay_internal): Fix prototype.
1336 2011-03-31 Eli Zaretskii <eliz@gnu.org>
1338 * xdisp.c (SCROLL_LIMIT): New macro.
1339 (try_scrolling): Use it when setting scroll_limit. Limit
1340 scrolling to 100 screen lines.
1341 (redisplay_window): Even when falling back on "recentering",
1342 position point in the window according to scroll-conservatively,
1343 scroll-margin, and scroll-*-aggressively variables. (Bug#6671)
1345 (try_scrolling): When point is above the window, allow searching
1346 as far as scroll_max, or one screenful, to compute vertical
1347 distance from PT to the scroll margin position. This prevents
1348 try_scrolling from unnecessarily failing when
1349 scroll-conservatively is set to a value slightly larger than the
1350 window height. Clean up the case of PT below the margin at bottom
1351 of window: scroll_max can no longer be INT_MAX. When aggressive
1352 scrolling is in use, don't let point enter the opposite scroll
1353 margin as result of the scroll.
1354 (syms_of_xdisp) <scroll-conservatively>: Document the
1355 threshold of 100 lines for never-recentering scrolling.
1357 2011-03-31 Juanma Barranquero <lekktu@gmail.com>
1359 * dispextern.h (move_it_by_lines):
1360 * xdisp.c (move_it_by_lines): Remove parameter `need_y_p', unused
1361 since 2000-12-29T14:24:09Z!gerd@gnu.org. All callers changed.
1362 (message_log_check_duplicate): Remove parameters `prev_bol' and
1363 `this_bol', unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
1364 (redisplay_internal): Remove parameter `preserve_echo_area',
1365 unused since 1999-07-21T21:43:52Z!gerd@gnu.org. All callers changed.
1367 * indent.c (Fvertical_motion):
1368 * window.c (window_scroll_pixel_based, Frecenter):
1369 Don't pass `need_y_p' to `move_it_by_lines'.
1371 2011-03-30 Stefan Monnier <monnier@iro.umontreal.ca>
1373 * eval.c (struct backtrace): Don't cheat with negative numbers, but do
1374 steal a few bits to be more compact.
1375 (interactive_p, Fbacktrace, Fbacktrace_frame, mark_backtrace):
1376 Remove unneeded casts.
1378 * bytecode.c (Fbyte_code): CAR and CDR can GC.
1380 2011-03-30 Zachary Kanfer <zkanfer@gmail.com> (tiny change)
1382 * keyboard.c (Fexecute_extended_command): Do log the "suggest key
1383 binding" message (bug#7967).
1385 2011-03-30 Paul Eggert <eggert@cs.ucla.edu>
1387 Fix more problems found by GCC 4.6.0's static checks.
1389 * unexelf.c (unexec) [! (defined _SYSTYPE_SYSV || defined __sgi)]:
1390 Remove unused local var.
1392 * editfns.c (Fmessage_box): Remove unused local var.
1394 * xdisp.c (try_window_reusing_current_matrix, x_produce_glyphs):
1395 (note_mode_line_or_margin_highlight, note_mouse_highlight):
1396 Omit unused local vars.
1397 * window.c (shrink_windows): Omit unused local var.
1398 * menu.c (digest_single_submenu): Omit unused local var.
1399 * dispnew.c (update_window) [PERIODIC_PREEMPTION_CHECKING]:
1400 Omit unused local var.
1402 * keyboard.c (parse_modifiers_uncached, parse_modifiers):
1403 Don't assume string length fits in int.
1404 (keyremap_step, read_key_sequence): Use size_t for sizes.
1405 (read_key_sequence): Don't check last_real_key_start redundantly.
1407 * callproc.c (Fcall_process, Fcall_process_region): Use SAFE_ALLOCA
1408 instead of alloca (Bug#8344).
1410 * eval.c (Fbacktrace): Don't assume nargs fits in int.
1411 (Fbacktrace_frame): Don't assume nframes fits in int.
1413 * syntax.c (scan_sexps_forward): Avoid pointer wraparound.
1415 * xterm.c (x_make_frame_visible, same_x_server): Redo to avoid overflow
1418 * term.c (produce_glyphless_glyph): Remove unnecessary test.
1420 * cm.c (calccost): Turn while-do into do-while, for clarity.
1422 * keyboard.c (syms_of_keyboard): Use the same style as later
1423 in this function when indexing through an array. This also
1424 works around GCC bug 48267.
1426 * image.c (tiff_load): Fix off-by-one image count (Bug#8336).
1428 * xselect.c (x_check_property_data): Return correct size (Bug#8335).
1430 * chartab.c (sub_char_table_ref_and_range): Redo for slight
1431 efficiency gain, and to bypass a gcc -Wstrict-overflow warning.
1433 * keyboard.c, keyboard.h (num_input_events): Now size_t.
1434 This avoids undefined behavior on integer overflow, and is a bit
1435 more convenient anyway since it is compared to a size_t variable.
1437 Variadic C functions now count arguments with size_t, not int.
1438 This avoids an unnecessary limitation on 64-bit machines, which
1439 caused (substring ...) to crash on large vectors (Bug#8344).
1440 * lisp.h (struct Lisp_Subr.function.aMANY): Now takes size_t, not int.
1441 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call): Likewise.
1442 All variadic functions and their callers changed accordingly.
1443 (struct gcpro.nvars): Now size_t, not int. All uses changed.
1444 * data.c (arith_driver, float_arith_driver): Likewise.
1445 * editfns.c (general_insert_function): Likewise.
1446 * eval.c (struct backtrace.nargs, interactive_p)
1447 (internal_condition_case_n, run_hook_with_args, apply_lambda)
1448 (funcall_lambda, mark_backtrace): Likewise.
1449 * fns.c (concat): Likewise.
1450 * frame.c (x_set_frame_parameters): Likewise.
1451 * fns.c (get_key_arg): Now accepts and returns size_t, and returns
1452 0 if not found, not -1. All callers changed.
1454 * alloc.c (garbage_collect): Don't assume stack size fits in int.
1455 (stack_copy_size): Now size_t, not int.
1456 (stack_copy, stack_copy_size): Define only if MAX_SAVE_STACK > 0.
1458 2011-03-28 Juanma Barranquero <lekktu@gmail.com>
1460 * coding.c (encode_designation_at_bol): Remove parameter `charbuf_end',
1461 unused since 2002-03-01T01:17:24Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
1462 All callers changed.
1464 * lisp.h (multibyte_char_to_unibyte):
1465 * character.c (multibyte_char_to_unibyte): Remove parameter `rev_tbl',
1466 unused since 2002-03-01T01:16:34Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
1467 * character.h (CHAR_TO_BYTE8):
1468 * cmds.c (internal_self_insert):
1469 * editfns.c (general_insert_function):
1470 * keymap.c (push_key_description):
1471 * search.c (Freplace_match):
1472 * xdisp.c (message_dolog, set_message_1): All callers changed.
1474 2011-03-28 Stefan Monnier <monnier@iro.umontreal.ca>
1476 * keyboard.c (safe_run_hook_funcall): New function.
1477 (safe_run_hooks_1, safe_run_hooks_error, safe_run_hooks): On error,
1478 don't set the hook to nil, but remove the offending function instead.
1479 (Qcommand_hook_internal): Remove, unused.
1480 (syms_of_keyboard): Don't initialize Qcommand_hook_internal nor define
1481 Vcommand_hook_internal.
1483 * eval.c (enum run_hooks_condition): Remove.
1484 (funcall_nil, funcall_not): New functions.
1485 (run_hook_with_args): Call each function through a `funcall' argument.
1486 Remove `cond' argument, now redundant.
1487 (Frun_hooks, Frun_hook_with_args, Frun_hook_with_args_until_success)
1488 (Frun_hook_with_args_until_failure): Adjust accordingly.
1489 (run_hook_wrapped_funcall, Frun_hook_wrapped): New functions.
1491 2011-03-28 Juanma Barranquero <lekktu@gmail.com>
1493 * dispextern.h (string_buffer_position): Remove declaration.
1495 * print.c (strout): Remove parameter `multibyte', unused since
1496 1999-08-21T19:30:21Z!gerd@gnu.org. All callers changed.
1498 * search.c (boyer_moore): Remove parameters `len', `pos' and `lim',
1499 never used since function introduction in 1998-02-08T21:33:56Z!rms@gnu.org.
1500 All callers changed.
1502 * w32.c (_wsa_errlist): Use braces for struct initializers.
1504 * xdisp.c (string_buffer_position_lim): Remove parameter `w',
1505 never used since function introduction in 2001-03-09T18:41:50Z!gerd@gnu.org.
1506 All callers changed.
1507 (string_buffer_position): Likewise. Also, make static (it's never
1508 used outside xdisp.c).
1509 (cursor_row_p): Remove parameter `w', unused since
1510 2000-10-17T16:08:57Z!gerd@gnu.org. All callers changed.
1511 (decode_mode_spec): Remove parameter `precision', introduced during
1512 Gerd Moellmann's rewrite at 1999-07-21T21:43:52Z!gerd@gnu.org, but never used.
1513 All callers changed.
1515 2011-03-27 Jan Djärv <jan.h.d@swipnet.se>
1517 * nsterm.m (syms_of_nsterm): Use doc: for ns-auto-hide-menu-bar.
1519 2011-03-27 Anders Lindgren <andlind@gmail.com>
1521 * nsterm.m (ns_menu_bar_is_hidden): New variable.
1522 (ns_constrain_all_frames, ns_menu_bar_should_be_hidden)
1523 (ns_update_auto_hide_menu_bar): New functions.
1524 (ns_update_begin): Call ns_update_auto_hide_menu_bar.
1525 (applicationDidBecomeActive): Call ns_update_auto_hide_menu_bar and
1526 ns_constrain_all_frames.
1527 (constrainFrameRect): Return at once if ns_menu_bar_should_be_hidden.
1528 (syms_of_nsterm): DEFVAR ns-auto-hide-menu-bar, init to Qnil.
1530 2011-03-27 Jan Djärv <jan.h.d@swipnet.se>
1532 * nsmenu.m (runDialogAt): Remove argument to timer_check.
1534 2011-03-27 Glenn Morris <rgm@gnu.org>
1536 * syssignal.h: Replace RETSIGTYPE with void.
1537 * atimer.c, data.c, dispnew.c, emacs.c, floatfns.c, keyboard.c:
1538 * keyboard.h, lisp.h, process.c, sysdep.c, xterm.c:
1539 Replace SIGTYPE with void everywhere.
1540 * s/usg5-4-common.h (SIGTYPE): Remove definition.
1541 * s/template.h (SIGTYPE): Remove commented out definition.
1543 2011-03-26 Eli Zaretskii <eliz@gnu.org>
1545 * xdisp.c (redisplay_window): Don't check buffer's clip_changed
1546 flag as a prerequisite for invoking try_scrolling. (Bug#6671)
1548 2011-03-26 Juanma Barranquero <lekktu@gmail.com>
1550 * w32.c (read_unc_volume): Use parameter `henum', instead of
1551 global variable `wget_enum_handle'.
1553 * keymap.c (describe_vector): Remove parameters `indices' and
1554 `char_table_depth', unused since 2002-03-01T01:43:26Z!handa@m17n.org.
1555 (describe_map, Fdescribe_vector): Adjust calls to `describe_vector'.
1557 * keyboard.h (timer_check, show_help_echo): Remove unused parameters.
1559 * keyboard.c (timer_check): Remove parameter `do_it_now',
1560 unused since 1996-04-12T06:01:29Z!rms@gnu.org.
1561 (show_help_echo): Remove parameter `ok_to_overwrite_keystroke_echo',
1562 unused since 2008-04-19T19:30:53Z!monnier@iro.umontreal.ca.
1564 * keyboard.c (read_char):
1565 * w32menu.c (w32_menu_display_help):
1566 * xmenu.c (show_help_event, menu_help_callback):
1567 Adjust calls to `show_help_echo'.
1569 * gtkutil.c (xg_maybe_add_timer):
1570 * keyboard.c (readable_events):
1571 * process.c (wait_reading_process_output):
1572 * xmenu.c (x_menu_wait_for_event): Adjust calls to `timer_check'.
1574 * insdel.c (adjust_markers_gap_motion):
1575 Remove; no-op since 1998-01-02T21:29:48Z!rms@gnu.org.
1576 (gap_left, gap_right): Don't call it.
1578 2011-03-25 Chong Yidong <cyd@stupidchicken.com>
1580 * xdisp.c (handle_fontified_prop): Discard changes to clip_changed
1581 incurred during fontification.
1583 2011-03-25 Juanma Barranquero <lekktu@gmail.com>
1585 * buffer.c (defvar_per_buffer): Remove unused parameter `doc'.
1586 (DEFVAR_PER_BUFFER): Don't pass it.
1588 * dispnew.c (row_equal_p, add_row_entry): Remove unused parameter `w'.
1589 (scrolling_window): Don't pass it.
1591 2011-03-25 Juanma Barranquero <lekktu@gmail.com>
1593 * dispextern.h (glyph_matric): Use #if GLYPH_DEBUG, not #ifdef.
1595 * fileio.c (check_executable) [DOS_NT]: Remove unused variables `len'
1597 (Fset_file_selinux_context) [HAVE_LIBSELINUX]: Move here declaration
1598 of variables specific to SELinux and computation of `encoded_absname'.
1600 * image.c (XPutPixel): Remove unused variable `height'.
1602 * keyboard.c (make_lispy_event): Remove unused variable `hpos'.
1604 * unexw32.c (get_section_info): Remove unused variable `section'.
1606 * w32.c (stat): Remove unused variables `drive_root' and `devtype'.
1607 (system_process_attributes): Remove unused variable `sess'.
1608 (sys_read): Remove unused variable `err'.
1610 * w32fns.c (top): Wrap variables with #if GLYPH_DEBUG, not #ifdef.
1611 (w32_wnd_proc): Remove unused variable `isdead'.
1612 (unwind_create_frame): Use #if GLYPH_DEBUG, not #ifdef.
1613 (Fx_server_max_request_size): Remove unused variable `dpyinfo'.
1614 (x_create_tip_frame): Remove unused variable `tem'.
1616 * w32inevt.c (w32_console_read_socket):
1617 Remove unused variable `no_events'.
1619 * w32term.c (x_draw_composite_glyph_string_foreground):
1620 Remove unused variable `width'.
1622 2011-03-24 Juanma Barranquero <lekktu@gmail.com>
1624 * w32term.c (x_set_glyph_string_clipping):
1625 Don't pass uninitialized region to CombineRgn.
1627 2011-03-23 Juanma Barranquero <lekktu@gmail.com>
1629 * w32fns.c (x_set_menu_bar_lines): Remove unused variable `olines'.
1630 (w32_wnd_proc): Pass NULL to Windows API, not uninitialized buffer.
1631 (Fx_close_connection): Remove unused variable `i'.
1633 * w32font.c (w32font_draw): Return number of glyphs.
1634 (w32font_open_internal): Remove unused variable `i'.
1635 (w32font_driver): Add missing initializer.
1637 * w32menu.c (utf8to16): Remove unused variable `utf16'.
1638 (fill_in_menu): Remove unused variable `items_added'.
1640 * w32term.c (last_mouse_press_frame): Remove static global variable.
1641 (w32_clip_to_row): Remove unused variable `f'.
1642 (x_delete_terminal): Remove unused variable `i'.
1644 * w32uniscribe.c (uniscribe_shape): Remove unused variable `nclusters'.
1645 (NOTHING): Remove unused static global variable.
1646 (uniscribe_check_otf): Remove unused variable `table'.
1647 (uniscribe_font_driver): Add missing initializers.
1649 2011-03-23 Julien Danjou <julien@danjou.info>
1651 * term.c (Fsuspend_tty, Fresume_tty):
1652 * minibuf.c (read_minibuf, run_exit_minibuf_hook):
1653 * window.c (temp_output_buffer_show):
1654 * insdel.c (signal_before_change):
1655 * frame.c (Fhandle_switch_frame):
1656 * fileio.c (Fdo_auto_save):
1657 * emacs.c (Fkill_emacs):
1658 * editfns.c (save_excursion_restore):
1659 * cmds.c (internal_self_insert):
1660 * callint.c (Fcall_interactively):
1661 * buffer.c (Fkill_all_local_variables):
1662 * keyboard.c (Fcommand_execute, Fsuspend_emacs, safe_run_hooks_1):
1664 (command_loop_1): Use Frun_hooks. Call safe_run_hooks
1665 unconditionnaly since it does the check itself.
1667 2011-03-23 Paul Eggert <eggert@cs.ucla.edu>
1669 Fix more problems found by GCC 4.5.2's static checks.
1671 * coding.c (encode_coding_raw_text): Avoid unnecessary test
1672 the first time through the loop, since we know p0 < p1 then.
1673 This also avoids a gcc -Wstrict-overflow warning.
1675 * lisp.h (SAFE_ALLOCA, SAFE_ALLOCA_LISP): Avoid 'int' overflow
1676 leading to a memory leak, possible in functions like
1677 load_charset_map_from_file that can allocate an unbounded number
1678 of objects (Bug#8318).
1680 * xmenu.c (set_frame_menubar): Use EMACS_UINT, not int, for indexes
1681 that could (at least in theory) be that large.
1683 * xdisp.c (message_log_check_duplicate): Return unsigned long, not int.
1684 This is less likely to overflow, and avoids undefined behavior if
1685 overflow does occur. All callers changed. Use strtoul to scan
1686 for the unsigned long integer.
1687 (pint2hrstr): Simplify and tune code slightly.
1688 This also avoids a (bogus) GCC warning with gcc -Wstrict-overflow.
1690 * scroll.c (do_scrolling): Work around GCC bug 48228.
1691 See <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=48228>.
1693 * frame.c (Fmodify_frame_parameters): Simplify loop counter.
1694 This also avoids a warning with gcc -Wstrict-overflow.
1695 (validate_x_resource_name): Simplify count usage.
1696 This also avoids a warning with gcc -Wstrict-overflow.
1698 * fileio.c (Fcopy_file): Report error if fchown or fchmod
1701 * emacs.c (Fdaemon_initialized): Do not ignore I/O errors (Bug#8303).
1703 * process.c (Fmake_network_process): Use socklen_t, not int,
1704 where POSIX says socklen_t is required in portable programs.
1705 This fixes a porting bug on hosts like 64-bit HP-UX, where
1706 socklen_t is wider than int (Bug#8277).
1707 (Fmake_network_process, server_accept_connection):
1708 (wait_reading_process_output, read_process_output):
1711 * process.c: Rename or move locals to avoid shadowing.
1712 (list_processes_1, Fmake_network_process):
1713 (read_process_output_error_handler, exec_sentinel_error_handler):
1714 Rename or move locals.
1715 (Fmake_network_process): Define label "retry_connect" only if needed.
1716 (Fnetwork_interface_info): Fix pointer signedness.
1717 (process_send_signal): Add cast to avoid pointer signedness problem.
1718 (FIRST_PROC_DESC, IF_NON_BLOCKING_CONNECT): Remove unused macros.
1719 (create_process): Use 'volatile' to avoid vfork clobbering (Bug#8298).
1721 Make tparam.h and terminfo.c consistent.
1722 * cm.c (tputs, tgoto, BC, UP): Remove extern decls.
1723 Include tparam.h instead, since it declares them.
1724 * cm.h (PC): Remove extern decl; tparam.h now does this.
1725 * deps.mk (cm.o, terminfo.o): Depend on tparam.h.
1726 * terminfo.c: Include tparam.h, to check interfaces.
1727 (tparm): Make 1st arg a const pointer in decl. Put it at top level.
1728 (tparam): Adjust signature to match interface in tparam.h;
1729 this removes some undefined behavior. Check that outstring and len
1730 are zero, which they always are with Emacs.
1731 * tparam.h (PC, BC, UP): New extern decls.
1733 * xftfont.c (xftfont_shape): Now static, and defined only if needed.
1734 (xftfont_open): Rename locals to avoid shadowing.
1736 * ftfont.c (ftfont_resolve_generic_family): Fix pointer signedness.
1737 (ftfont_otf_capability, ftfont_shape): Omit decls if not needed.
1738 (OTF_TAG_SYM): Omit macro if not needed.
1739 (ftfont_list): Remove unused local.
1740 (get_adstyle_property, ftfont_pattern_entity):
1741 (ftfont_lookup_cache, ftfont_open, ftfont_anchor_point):
1742 Rename locals to avoid shadowing.
1744 * xfont.c (xfont_list_family): Mark var as initialized.
1746 * xml.c (make_dom): Now static.
1748 * composite.c (composition_compute_stop_pos): Rename local to
1750 (composition_reseat_it): Remove unused locals.
1751 (find_automatic_composition, composition_adjust_point): Likewise.
1752 (composition_update_it): Mark var as initialized.
1753 (find_automatic_composition): Mark vars as initialized,
1754 with a FIXME (Bug#8290).
1756 character.h: Rename locals to avoid shadowing.
1757 * character.h (PREV_CHAR_BOUNDARY, FETCH_STRING_CHAR_ADVANCE):
1758 (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE, FETCH_CHAR_ADVANCE):
1759 (FETCH_CHAR_ADVANCE_NO_CHECK, INC_POS, DEC_POS, BUF_INC_POS):
1760 (BUF_DEC_POS): Be more systematic about renaming local temporaries
1763 * textprop.c (property_change_between_p): Remove; unused.
1765 * intervals.c (interval_start_pos): Now static.
1767 * intervals.h (CHECK_TOTAL_LENGTH): Avoid empty "else".
1769 * atimer.c (start_atimer, append_atimer_lists, set_alarm):
1770 Rename locals to avoid shadowing.
1772 * sound.c (wav_play, au_play, Fplay_sound_internal):
1773 Fix pointer signedness.
1774 (alsa_choose_format): Remove unused local var.
1775 (wav_play): Initialize a variable to 0, to prevent undefined
1776 behavior (Bug#8278).
1778 * region-cache.c (insert_cache_boundary): Redo var to avoid shadowing.
1780 * region-cache.h (pp_cache): New decl, for gcc -Wmissing-prototypes.
1782 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork
1783 clobbering (Bug#8298).
1784 * sysdep.c (sys_subshell): Likewise.
1785 Previously, the sys_subshell 'volatile' was incorrectly IF_LINTted out.
1787 * lisp.h (child_setup): Now NO_RETURN unless DOS_NT.
1788 This should get cleaned up, so that child_setup has the
1789 same signature on all platforms.
1791 * callproc.c (call_process_cleanup): Now static.
1792 (relocate_fd): Rename locals to avoid shadowing.
1794 2011-03-22 Chong Yidong <cyd@stupidchicken.com>
1796 * xterm.c (x_clear_frame): Remove XClearWindow call. This appears
1797 not to be necessary, and produces flickering.
1799 2011-03-20 Glenn Morris <rgm@gnu.org>
1801 * config.in: Remove file.
1803 2011-03-20 Juanma Barranquero <lekktu@gmail.com>
1805 * minibuf.c (Vcompleting_read_function): Don't declare, global variables
1806 are now in src/globals.h.
1807 (syms_of_minibuf): Remove spurious & from previous change.
1809 2011-03-20 Leo <sdl.web@gmail.com>
1811 * minibuf.c (completing-read-function): New variable.
1812 (completing-read-default): Rename from completing-read.
1813 (completing-read): Call completing-read-function.
1815 2011-03-19 Juanma Barranquero <lekktu@gmail.com>
1817 * xfaces.c (Fx_load_color_file):
1818 Read color file from absolute filename (bug#8250).
1820 2011-03-19 Juanma Barranquero <lekktu@gmail.com>
1822 * makefile.w32-in: Update dependencies.
1824 2011-03-17 Eli Zaretskii <eliz@gnu.org>
1826 * makefile.w32-in ($(BLD)/unexw32.$(O)): Depend on $(SRC)/unexec.h.
1828 2011-03-17 Paul Eggert <eggert@cs.ucla.edu>
1830 Fix more problems found by GCC 4.5.2's static checks.
1832 * process.c (make_serial_process_unwind, send_process_trap):
1833 (sigchld_handler): Now static.
1835 * process.c (allocate_pty): Let PTY_ITERATION declare iteration vars.
1836 That way, the code declares only the vars that it needs.
1837 * s/aix4-2.h (PTY_ITERATION): Declare iteration vars.
1838 * s/cygwin.h (PTY_ITERATION): Likewise.
1839 * s/darwin.h (PTY_ITERATION): Likewise.
1840 * s/gnu-linux.h (PTY_ITERATION): Likewise.
1842 * s/irix6-5.h (PTY_OPEN): Declare stb, to loosen coupling.
1843 * process.c (allocate_pty): Don't declare stb unless it's needed.
1845 * bytecode.c (MAYBE_GC): Rewrite so as not to use empty "else".
1846 (CONSTANTLIM): Remove; unused.
1847 (METER_CODE, Bscan_buffer, Bread_char, Bset_mark):
1848 Define only if needed.
1850 * unexelf.c (unexec): Name an expression,
1851 to avoid gcc -Wbad-function-cast warning.
1852 Use a different way to cause a compilation error if anyone uses
1853 n rather than nn, a way that does not involve shadowing.
1854 (ELF_BSS_SECTION_NAME, OLD_PROGRAM_H): Remove; unused.
1856 * deps.mk (unexalpha.o): Remove; unused.
1858 New file unexec.h, the (simple) interface for unexec (Bug#8267).
1859 * unexec.h: New file.
1860 * deps.mk (emacs.o, unexaix.o, unexcw.o, unexcoff.o, unexelf.o):
1861 (unexhp9k800.o, unexmacosx.o, unexsol.o, unexw32.o):
1863 * emacs.c [!defined CANNOT_DUMP]: Include unexec.h.
1864 * unexaix.c, unexcoff.c, unexcw.c, unexelf.c, unexhp9k800.c:
1865 * unexmacosx.c, unexsol.c, unexw32.c: Include unexec.h.
1866 Change as necessary to match prototype in unexec.h.
1868 * syntax.c (Fforward_comment, scan_lists): Rename locals to avoid
1870 (back_comment, skip_chars): Mark vars as initialized.
1872 * character.h (FETCH_STRING_CHAR_ADVANCE_NO_CHECK, BUF_INC_POS):
1873 Rename locals to avoid shadowing.
1875 * lread.c (read1): Rewrite so as not to use empty "else".
1876 (Fload, readevalloop, read1): Rename locals to avoid shadowing.
1878 * print.c (Fredirect_debugging_output): Fix pointer signedess.
1880 * lisp.h (debug_output_compilation_hack): Add decl here, to avoid
1881 warning when compiling print.c.
1883 * font.c (font_unparse_fcname): Abort in an "impossible" situation
1884 instead of using an uninitialized var.
1885 (font_sort_entities): Mark var as initialized.
1887 * character.h (FETCH_CHAR_ADVANCE): Rename locals to avoid shadowing.
1889 * font.c (font_unparse_xlfd): Don't mix pointers to variables with
1890 pointers to constants.
1891 (font_parse_fcname): Remove unused vars.
1892 (font_delete_unmatched): Now static.
1893 (font_get_spec): Remove; unused.
1894 (font_style_to_value, font_prop_validate_style, font_unparse_fcname):
1895 (font_update_drivers, Ffont_get_glyphs, font_add_log):
1896 Rename or move locals to avoid shadowing.
1898 * fns.c (require_nesting_list, require_unwind): Now static.
1899 (Ffillarray): Rename locals to avoid shadowing.
1901 * floatfns.c (domain_error2): Define only if needed.
1902 (Ffrexp, Fldexp): Rename locals to avoid shadowing.
1904 * alloc.c (mark_backtrace): Move decl from here ...
1905 * lisp.h: ... to here, so that it can be checked.
1907 * eval.c (call_debugger, do_debug_on_call, grow_specpdl): Now static.
1908 (Fdefvar): Rewrite so as not to use empty "else".
1909 (lisp_indirect_variable): Name an expression,
1910 to avoid gcc -Wbad-function-cast warning.
1911 (Fdefvar): Rename locals to avoid shadowing.
1913 * callint.c (quotify_arg, quotify_args): Now static.
1914 (Fcall_interactively): Rename locals to avoid shadowing.
1915 Use const pointer when appropriate.
1917 * lisp.h (get_system_name, get_operating_system_release):
1918 Move decls here, to check interfaces.
1919 * process.c (get_operating_system_release): Move decl to lisp.h.
1920 * xrdb.c (get_system_name): Likewise.
1921 * editfns.c (init_editfns, Fuser_login_name, Fuser_uid):
1922 (Fuser_real_uid, Fuser_full_name): Remove unnecessary casts,
1923 some of which prompt warnings from gcc -Wbad-function-cast.
1924 (Fformat_time_string, Fencode_time, Finsert_char):
1925 (Ftranslate_region_internal, Fformat):
1926 Rename or remove local vars to avoid shadowing.
1927 (Ftranslate_region_internal): Mark var as initialized.
1929 * doc.c (Fdocumentation, Fsnarf_documentation): Move locals to
1932 * lisp.h (eassert): Check that the argument compiles, even if
1933 ENABLE_CHECKING is not defined.
1935 * data.c (Findirect_variable): Name an expression, to avoid
1936 gcc -Wbad-function-cast warning.
1937 (default_value, arithcompare, arith_driver, arith_error): Now static.
1938 (store_symval_forwarding): Rename local to avoid shadowing.
1939 (Fmake_variable_buffer_local, Fmake_local_variable):
1940 Mark variables as initialized.
1941 (do_blv_forwarding, do_symval_forwarding): Remove; unused.
1943 * alloc.c (check_cons_list): Do not define unless GC_CHECK_CONS_LIST.
1944 (Fmake_vector, Fvector, Fmake_byte_code, Fgarbage_collect):
1945 Rename locals to avoid shadowing.
1946 (mark_stack): Move local variables into the #ifdef region where
1948 (BLOCK_INPUT_ALLOC, UNBLOCK_INPUT_ALLOC): Define only if
1949 ! defined SYSTEM_MALLOC && ! defined SYNC_INPUT, as they are not
1951 (CHECK_ALLOCATED): Define only if GC_CHECK_MARKED_OBJECTS.
1952 (GC_STRING_CHARS): Remove; not used.
1953 (Fmemory_limit): Cast sbrk's returned value to char *.
1955 * lisp.h (check_cons_list): Declare if GC_CHECK_CONS_LIST; this
1956 avoids undefined behavior in theory.
1958 * regex.c (IF_LINT): Add defn, for benefit of ../lib-src.
1960 Use functions, not macros, for up- and down-casing (Bug#8254).
1961 * buffer.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
1962 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Remove. All callers changed
1963 to use the following functions instead of these macros.
1964 (downcase): Adjust to lack of DOWNCASE_TABLE. Return int, not
1965 EMACS_INT, since callers assume the returned value fits in int.
1966 (upcase1): Likewise, for UPCASE_TABLE.
1967 (uppercasep, lowercasep, upcase): New static inline functions.
1968 * editfns.c (Fchar_equal): Remove no-longer-needed workaround for
1969 the race-condition problem in the old DOWNCASE.
1971 * regex.c (CHARSET_LOOKUP_RANGE_TABLE_RAW, POP_FAILURE_REG_OR_COUNT):
1972 Rename locals to avoid shadowing.
1973 (regex_compile, re_match_2_internal): Move locals to avoid shadowing.
1974 (regex_compile, re_search_2, re_match_2_internal):
1975 Remove unused local vars.
1976 (FREE_VAR): Rewrite so as not to use empty "else",
1977 which gcc can warn about.
1978 (regex_compile, re_match_2_internal): Mark locals as initialized.
1979 (RETALLOC_IF): Define only if needed.
1980 (WORDCHAR_P): Likewise. This one is never needed, but is used
1981 only in a comment talking about a compiler bug, so put inside
1982 the #if 0 of that comment.
1983 (CHARSET_LOOKUP_BITMAP, FAIL_STACK_FULL, RESET_FAIL_STACK):
1984 (PUSH_FAILURE_ELT, BUF_PUSH_3, STOP_ADDR_VSTRING):
1987 * search.c (boyer_moore): Rename locals to avoid shadowing.
1988 * character.h (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE):
1989 (PREV_CHAR_BOUNDARY): Likewise.
1991 * search.c (simple_search): Remove unused var.
1993 * dired.c (compile_pattern): Move decl from here ...
1994 * lisp.h: ... to here, so that it can be checked.
1995 (struct re_registers): New forward decl.
1997 * character.h (INC_POS, DEC_POS): Rename locals to avoid shadowing.
1999 * indent.c (MULTIBYTE_BYTES_WIDTH): New args bytes, width.
2001 (MULTIBYTE_BYTES_WIDTH, scan_for_column, compute_motion):
2002 Rename locals to avoid shadowing.
2003 (Fvertical_motion): Mark locals as initialized.
2005 * casefiddle.c (casify_object, casify_region): Now static.
2006 (casify_region): Mark local as initialized.
2008 * cmds.c (internal_self_insert): Rename local to avoid shadowing.
2010 * lisp.h (GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR, GCPRO5_VAR, GCPRO6_VAR):
2011 New macros, so that the caller can use some names other than
2012 gcpro1, gcpro2, etc.
2013 (GCPRO2, GCPRO3, GCPRO4, GCPRO5, GCPRO6): Reimplement in terms
2015 (GCPRO1_VAR, UNGCPRO_VAR): Change the meaning of the second
2016 argument, for consistency with GCPRO2_VAR, etc: it is now the
2017 prefix of the variable, not the variable itself. All uses
2019 * dired.c (directory_files_internal, file_name_completion):
2020 Rename locals to avoid shadowing.
2022 Fix a race condition diagnosed by gcc -Wsequence-point (Bug#8254).
2023 An expression of the form (DOWNCASE (x) == DOWNCASE (y)), found in
2024 dired.c's scmp function, had undefined behavior.
2025 * lisp.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
2026 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Move from here ...
2027 * buffer.h: ... to here, because these macros use current_buffer,
2028 and the new implementation with inline functions needs to have
2029 current_buffer in scope now, rather than later when the macros
2031 (downcase, upcase1): New static inline functions.
2032 (DOWNCASE, UPCASE1): Reimplement using these functions.
2033 This avoids undefined behavior in expressions like
2034 DOWNCASE (x) == DOWNCASE (y), which previously suffered
2035 from race conditions in accessing the global variables
2036 case_temp1 and case_temp2.
2037 * casetab.c (case_temp1, case_temp2): Remove; no longer needed.
2038 * lisp.h (case_temp1, case_temp2): Remove their decls.
2039 * character.h (ASCII_CHAR_P): Move from here ...
2040 * lisp.h: ... to here, so that the inline functions mentioned
2043 * dired.c (directory_files_internal_unwind): Now static.
2045 * fileio.c (file_name_as_directory, directory_file_name):
2046 (barf_or_query_if_file_exists, auto_save_error, auto_save_1):
2048 (file_name_as_directory): Use const pointers when appropriate.
2049 (Fexpand_file_name): Likewise. In particular, newdir might
2050 point at constant storage, so make it a const pointer.
2051 (Fmake_directory_internal, Fread_file_name): Remove unused vars.
2052 (Ffile_selinux_context, Fset_file_selinux_context): Fix pointer
2054 (Fset_file_times, Finsert_file_contents, auto_save_error):
2055 Rename locals to avoid shadowing.
2057 * minibuf.c (choose_minibuf_frame_1): Now static.
2058 (Ftry_completion, Fall_completions): Rename or remove locals
2061 * marker.c (bytepos_to_charpos): Remove; unused.
2063 * lisp.h (verify_bytepos, count_markers): New decls,
2064 so that gcc does not warn that these functions aren't declared.
2066 * insdel.c (check_markers, make_gap_larger, make_gap_smaller):
2067 (reset_var_on_error, Fcombine_after_change_execute_1): Now static.
2068 (CHECK_MARKERS): Redo to avoid gcc -Wempty-body diagnostic.
2069 (copy_text): Remove unused local var.
2071 * filelock.c (within_one_second): Now static.
2072 (lock_file_1): Rename local to avoid shadowing.
2074 * buffer.c (fix_overlays_before): Mark locals as initialized.
2075 (fix_start_end_in_overlays): Likewise. This function should be
2076 simplified by using pointers-to-pointers, but that's a different
2078 (switch_to_buffer_1): Now static.
2079 (Fkill_buffer, record_buffer, Fbury_buffer, Fset_buffer_multibyte):
2080 (report_overlay_modification): Rename locals to avoid shadowing.
2082 * sysdep.c (system_process_attributes): Rename vars to avoid shadowing.
2083 Fix pointer signedness issue.
2084 (sys_subshell): Mark local as volatile if checking for lint,
2085 to suppress a gcc -Wclobbered warning that does not seem to be right.
2086 (MAXPATHLEN): Define only if needed.
2088 * process.c (serial_open, serial_configure): Move decls from here ...
2089 * systty.h: ... to here, so that they can be checked.
2091 * fns.c (get_random, seed_random): Move extern decls from here ...
2092 * lisp.h: ... to here, so that they can be checked.
2094 * sysdep.c (reset_io): Now static.
2095 (wait_for_termination_signal): Remove; unused.
2097 * keymap.c (keymap_parent, keymap_memberp, map_keymap_internal):
2098 (copy_keymap_item, append_key, push_text_char_description):
2100 (Fwhere_is_internal): Don't test CONSP (sequences) unnecessarily.
2101 (DENSE_TABLE_SIZE): Remove; unused.
2102 (get_keymap, access_keymap, Fdefine_key, Fwhere_is_internal):
2103 (describe_map_tree):
2104 Rename locals to avoid shadowing.
2106 * keyboard.c: Declare functions static if they are not used elsewhere.
2107 (echo_char, echo_dash, cmd_error, top_level_2):
2108 (poll_for_input, handle_async_input): Now static.
2109 (read_char, kbd_buffer_get_event, make_lispy_position):
2110 (make_lispy_event, make_lispy_movement, apply_modifiers):
2111 (decode_keyboard_code, tty_read_avail_input, menu_bar_items):
2112 (parse_tool_bar_item, read_key_sequence, Fread_key_sequence):
2113 (Fread_key_sequence_vector): Rename locals to avoid shadowing.
2114 (read_key_sequence, read_char): Mark locals as initialized.
2115 (Fexit_recursive_edit, Fabort_recursive_edit): Mark with NO_RETURN.
2117 * keyboard.h (make_ctrl_char): New decl.
2118 (mark_kboards): Move decl here ...
2119 * alloc.c (mark_kboards): ... from here.
2121 * lisp.h (force_auto_save_soon): New decl.
2123 * emacs.c (init_cmdargs): Rename local to avoid shadowing.
2124 (DEFINE_DUMMY_FUNCTION): New macro.
2125 (__do_global_ctors, __do_global_ctors_aux, __do_global_dtors, __main):
2127 (main): Add casts to avoid warnings
2128 if GCC considers string literals to be constants.
2130 * lisp.h (fatal_error_signal): Add decl, since it's exported.
2132 * dbusbind.c: Pointer signedness fixes.
2133 (xd_signature, xd_append_arg, xd_initialize):
2134 (Fdbus_call_method, Fdbus_call_method_asynchronously):
2135 (Fdbus_method_return_internal, Fdbus_method_error_internal):
2136 (Fdbus_send_signal, xd_read_message_1, Fdbus_register_service):
2137 (Fdbus_register_signal): Use SSDATA when the context wants char *.
2139 * dbusbind.c (Fdbus_init_bus): Add cast to avoid warning
2140 if GCC considers string literals to be constants.
2141 (Fdbus_register_service, Fdbus_register_method): Remove unused vars.
2143 2011-03-16 Stefan Monnier <monnier@iro.umontreal.ca>
2145 * print.c (PRINT_CIRCLE_CANDIDATE_P): New macro.
2146 (print_preprocess, print_object): New macro to fix last change.
2148 * print.c (print_preprocess): Don't forget font objects.
2150 2011-03-16 Juanma Barranquero <lekktu@gmail.com>
2152 * emacs.c (USAGE3): Doc fixes.
2154 2011-03-15 Andreas Schwab <schwab@linux-m68k.org>
2156 * coding.c (detect_coding_iso_2022): Reorganize code to clarify
2159 2011-03-14 Juanma Barranquero <lekktu@gmail.com>
2161 * lisp.h (VWindow_system, Qfile_name_history):
2162 * keyboard.h (lispy_function_keys) [WINDOWSNT]:
2163 * w32term.h (w32_system_caret_hwnd, w32_system_caret_height)
2164 (w32_system_caret_x, w32_system_caret_y): Declare extern.
2166 * w32select.c: Don't #include "keyboard.h".
2167 (run_protected): Add extern declaration for waiting_for_input.
2169 * w32.c (Qlocal, noninteractive1, inhibit_window_system):
2170 * w32console.c (detect_input_pending, read_input_pending)
2171 (encode_terminal_code):
2172 * w32fns.c (quit_char, lispy_function_keys, Qtooltip)
2173 (w32_system_caret_hwnd, w32_system_caret_height, w32_system_caret_x)
2174 (w32_system_caret_y, Qfile_name_history):
2175 * w32font.c (w32font_driver, QCantialias, QCotf, QClang):
2176 * w32inevt.c (reinvoke_input_signal, lispy_function_keys):
2177 * w32menu.c (Qmenu_bar, QCtoggle, QCradio, Qoverriding_local_map)
2178 (Qoverriding_terminal_local_map, Qmenu_bar_update_hook):
2179 * w32proc.c (Qlocal, report_file_error):
2180 * w32term.c (Vwindow_system, updating_frame):
2181 * w32uniscribe.c (initialized, uniscribe_font_driver):
2182 Remove unneeded extern declarations.
2184 2011-03-14 Chong Yidong <cyd@stupidchicken.com>
2186 * buffer.c (Fmake_indirect_buffer): Fix incorrect assertions.
2188 2011-03-13 Chong Yidong <cyd@stupidchicken.com>
2190 * buffer.h (BUF_BEGV, BUF_BEGV_BYTE, BUF_ZV, BUF_ZV_BYTE, BUF_PT)
2191 (BUF_PT_BYTE): Rewrite to handle indirect buffers (Bug#8219).
2192 These macros can no longer be used for assignment.
2194 * buffer.c (Fget_buffer_create, Fmake_indirect_buffer):
2195 Assign struct members directly, instead of using BUF_BEGV etc.
2196 (record_buffer_markers, fetch_buffer_markers): New functions for
2197 recording and fetching special buffer markers.
2198 (set_buffer_internal_1, set_buffer_temp): Use them.
2200 * lread.c (unreadchar): Use SET_BUF_PT_BOTH.
2202 * insdel.c (adjust_point): Use SET_BUF_PT_BOTH.
2204 * intervals.c (temp_set_point_both): Use SET_BUF_PT_BOTH.
2205 (get_local_map): Use SET_BUF_BEGV_BOTH and SET_BUF_ZV_BOTH.
2207 * xdisp.c (hscroll_window_tree):
2208 (reconsider_clip_changes): Use PT instead of BUF_PT.
2210 2011-03-13 Eli Zaretskii <eliz@gnu.org>
2212 * makefile.w32-in ($(BLD)/editfns.$(O)): Depend on
2213 $(EMACS_ROOT)/lib/intprops.h.
2215 2011-03-13 Paul Eggert <eggert@cs.ucla.edu>
2217 Fix more problems found by GCC 4.5.2's static checks.
2219 * gtkutil.c (xg_get_pixbuf_from_pixmap): Add cast from char *
2220 to unsigned char * to avoid compiler diagnostic.
2221 (xg_free_frame_widgets): Make it clear that a local variable is
2222 needed only if USE_GTK_TOOLTIP.
2223 (gdk_window_get_screen): Make it clear that this macro is needed
2224 only if USE_GTK_TOOLTIP.
2225 (int_gtk_range_get_value): New function, which avoids a diagnostic
2226 from gcc -Wbad-function-cast.
2227 (xg_set_toolkit_scroll_bar_thumb): Use it.
2228 (xg_tool_bar_callback, xg_tool_item_stale_p): Rewrite to avoid
2229 diagnostic from gcc -Wbad-function-cast.
2230 (get_utf8_string, xg_get_file_with_chooser):
2231 Rename locals to avoid shadowing.
2232 (create_dialog): Move locals to avoid shadowing.
2234 * xgselect.c (xg_select): Remove unused var.
2236 * image.c (four_corners_best): Mark locals as initialized.
2237 (gif_load): Initialize transparent_p to zero (Bug#8238).
2238 Mark another local as initialized.
2239 (my_png_error, my_error_exit): Mark with NO_RETURN.
2241 * image.c (clear_image_cache): Now static.
2242 (DIM, HAVE_STDLIB_H_1): Remove unused macros.
2243 (xpm_load): Redo to avoid "discards qualifiers" gcc warning.
2244 (x_edge_detection): Remove unnecessary cast that
2245 gcc -Wbad-function-cast diagnoses.
2246 (gif_load): Fix pointer signedness.
2247 (clear_image_cache, xbm_read_bitmap_data, x_detect_edges):
2248 (jpeg_load, gif_load): Rename locals to avoid shadowing.
2250 2011-03-12 Paul Eggert <eggert@cs.ucla.edu>
2252 Improve quality of tests for time stamp overflow.
2253 For example, without this patch (encode-time 0 0 0 1 1
2254 1152921504606846976) returns the obviously-bogus value (-948597
2255 62170) on my RHEL 5.5 x86-64 host. With the patch, it correctly
2256 reports time overflow. See
2257 <http://lists.gnu.org/archive/html/emacs-devel/2011-03/msg00470.html>.
2258 * deps.mk (editfns.o): Depend on ../lib/intprops.h.
2259 * editfns.c: Include limits.h and intprops.h.
2260 (TIME_T_MIN, TIME_T_MAX): New macros.
2261 (time_overflow): Move earlier, to before first use.
2262 (hi_time, lo_time): New functions, for an accurate test for
2264 (Fcurrent_time, Fget_internal_run_time, make_time): Use them.
2265 (Fget_internal_run_time): Don't assume time_t fits in int.
2266 (make_time): Use list2 instead of Fcons twice.
2267 (Fdecode_time): More accurate test for out-of-range times.
2268 (check_tm_member): New function.
2269 (Fencode_time): Use it, to test for out-of-range times.
2270 (lisp_time_argument): Don't rely on undefined left-shift and
2271 right-shift behavior when checking for time stamp overflow.
2273 * editfns.c (time_overflow): New function, refactoring common code.
2274 (Fformat_time_string, Fdecode_time, Fencode_time):
2275 (Fcurrent_time_string): Use it.
2277 Move 'make_time' to be next to its inverse 'lisp_time_argument'.
2278 * dired.c (make_time): Move to ...
2279 * editfns.c (make_time): ... here.
2280 * systime.h: Note the move.
2282 2011-03-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
2284 * fringe.c (update_window_fringes): Remove unused variables.
2286 * unexmacosx.c (copy_data_segment): Also copy __got section.
2289 2011-03-12 Eli Zaretskii <eliz@gnu.org>
2291 * termcap.c [MSDOS]: Include "msdos.h".
2292 (find_capability, tgetnum, tgetflag, tgetstr, tputs, tgetent):
2293 Constify `char *' arguments and their references according to
2294 prototypes in tparam.h.
2296 * deps.mk (termcap.o): Depend on tparam.h and msdos.h.
2298 * msdos.c (XMenuAddPane): 3rd argument is `const char *' now.
2299 Adapt all references accordingly.
2301 * msdos.h (XMenuAddPane): 3rd argument is `const char *' now.
2303 2011-03-11 Tom Tromey <tromey@redhat.com>
2305 * buffer.c (syms_of_buffer): Remove obsolete comment.
2307 2011-03-11 Eli Zaretskii <eliz@gnu.org>
2309 * termhooks.h (encode_terminal_code): Declare prototype.
2311 * msdos.c (encode_terminal_code): Don't declare prototype.
2313 * term.c (encode_terminal_code): Now external again, used by
2314 w32console.c and msdos.c.
2316 * makefile.w32-in ($(BLD)/term.$(O), ($(BLD)/tparam.$(O)):
2317 Depend on $(SRC)/tparam.h, see 2011-03-11T07:24:21Z!eggert@cs.ucla.edu.
2319 2011-03-11 Paul Eggert <eggert@cs.ucla.edu>
2321 Fix some minor problems found by GCC 4.5.2's static checks.
2323 * fringe.c (update_window_fringes): Mark locals as initialized
2325 (destroy_fringe_bitmap, init_fringe_bitmap): Now static.
2327 * alloc.c (mark_fringe_data): Move decl from here ...
2328 * lisp.h (mark_fringe_data) [HAVE_WINDOW_SYSTEM]: ... to here,
2329 to check its interface.
2330 (init_fringe_once): Do not declare unless HAVE_WINDOW_SYSTEM.
2332 * fontset.c (free_realized_fontset): Now static.
2333 (Fset_fontset_font): Rename local to avoid shadowing.
2334 (fontset_font): Mark local as initialized.
2335 (FONTSET_SPEC, FONTSET_REPERTORY, RFONT_DEF_REPERTORY): Remove; unused.
2337 * xrdb.c: Include "xterm.h", to check x_load_resources's interface.
2339 * xselect.c (x_disown_buffer_selections): Remove; not used.
2340 (TRACE3) [!defined TRACE_SELECTION]: Remove; not used.
2341 (x_own_selection, Fx_disown_selection_internal): Rename locals
2343 (x_handle_dnd_message): Remove local to avoid shadowing.
2345 * lisp.h (GCPRO1_VAR, UNGCPRO_VAR): New macros,
2346 so that the caller can use some name other than gcpro1.
2347 (GCPRO1, UNGCPRO): Reimplement in terms of the new macros.
2348 * xfns.c (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
2349 (Fx_backspace_delete_keys_p):
2350 Use them to avoid shadowing, and rename vars to avoid shadowing.
2351 (x_decode_color, x_set_name, x_window): Now static.
2352 (Fx_create_frame): Add braces to silence GCC warning.
2353 (Fx_file_dialog, Fx_select_font): Fix pointer signedness.
2354 (x_real_positions, xg_set_icon_from_xpm_data, x_create_tip_frame):
2355 Remove unused locals.
2356 (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
2357 (Fx_backspace_delete_keys_p): Rename locals to avoid shadowing.
2358 Some of these renamings use the new GCPRO1_VAR and UNGCPRO_VAR
2361 * xterm.h (x_mouse_leave): New decl.
2363 * xterm.c (x_copy_dpy_color, x_focus_on_frame, x_unfocus_frame):
2364 Remove unused functions.
2365 (x_shift_glyphs_for_insert, XTflash, XTring_bell):
2366 (x_calc_absolute_position): Now static.
2367 (XTread_socket): Don't define label "out" unless it's used.
2368 Don't declare local "event" unless it's used.
2369 (x_iconify_frame, x_free_frame_resources): Don't declare locals
2370 unless they are used.
2371 (XEMBED_VERSION, xembed_set_info): Don't define unless needed.
2372 (x_fatal_error_signal): Remove; not used.
2373 (x_draw_image_foreground, redo_mouse_highlight, XTmouse_position):
2374 (x_scroll_bar_report_motion, handle_one_xevent, x_draw_bar_cursor):
2375 (x_error_catcher, x_connection_closed, x_error_handler):
2376 (x_error_quitter, xembed_send_message, x_iconify_frame):
2377 (my_log_handler): Rename locals to avoid shadowing.
2378 (x_delete_glyphs, x_ins_del_lines): Mark with NO_RETURN.
2379 (x_connection_closed): Tell GCC not to suggest NO_RETURN.
2381 * xfaces.c (clear_face_cache, Fx_list_fonts, Fface_font):
2382 Rename or move locals to avoid shadowing.
2383 (tty_defined_color, merge_face_heights): Now static.
2384 (free_realized_faces_for_fontset): Remove; not used.
2385 (Fx_list_fonts): Mark variable that gcc -Wuninitialized
2386 does not deduce is never used uninitialized.
2387 (STRDUPA, LSTRDUPA, FONT_POINT_SIZE_QUANTUM): Remove; not used.
2388 (LFACEP): Define only if XASSERTS, as it's not needed otherwise.
2390 * terminal.c (store_terminal_param): Now static.
2392 * xmenu.c (menu_highlight_callback): Now static.
2393 (set_frame_menubar): Remove unused local.
2394 (xmenu_show): Rename parameter to avoid shadowing.
2395 (xmenu_show, xdialog_show, xmenu_show): Make local pointers "const"
2396 since they might point to immutable storage.
2397 (next_menubar_widget_id): Declare only if USE_X_TOOLKIT,
2398 since it's unused otherwise.
2400 * xdisp.c (produce_glyphless_glyph): Initialize lower_xoff.
2401 Add a FIXME, since the code still doesn't look right. (Bug#8215)
2402 (Fcurrent_bidi_paragraph_direction): Simplify slightly; this
2403 avoids a gcc -Wuninitialized diagnostic.
2404 (display_line, BUILD_COMPOSITE_GLYPH_STRING, draw_glyphs):
2405 (note_mouse_highlight): Mark variables that gcc -Wuninitialized
2406 does not deduce are never used uninitialized.
2408 * lisp.h (IF_LINT): New macro, copied from ../lib-src/emacsclient.c.
2410 * xdisp.c (redisplay_window): Rename local to avoid shadowing.
2411 * window.c (window_loop, size_window):
2412 (run_window_configuration_change_hook, enlarge_window): Likewise.
2414 * window.c (display_buffer): Now static.
2415 (size_window): Mark variables that gcc -Wuninitialized
2416 does not deduce are never used uninitialized.
2417 * window.h (check_all_windows): New decl, to forestall
2418 gcc -Wmissing-prototypes diagnostic.
2419 * dispextern.h (bidi_dump_cached_states): Likewise.
2421 * charset.h (CHECK_CHARSET_GET_CHARSET): Rename locals to avoid
2423 * charset.c (map_charset_for_dump, Fchar_charset): Likewise.
2425 (Fsort_charsets): Redo min/max calculation to shorten the code a bit
2426 and to avoid gcc -Wuninitialized warning.
2427 (load_charset_map): Mark variables that gcc -Wuninitialized
2428 does not deduce are never used uninitialized.
2429 (load_charset): Abort instead of using uninitialized var (Bug#8229).
2431 * coding.c (coding_set_source, coding_set_destination):
2432 Use "else { /* comment */ }" rather than "else /* comment */;"
2433 for clarity, and to avoid gcc -Wempty-body warning.
2434 (Fdefine_coding_system_internal): Don't redeclare 'i' inside
2435 a block, when the outer 'i' will do.
2436 (decode_coding_utf_8, decode_coding_utf_16, detect_coding_emacs_mule):
2437 (emacs_mule_char, decode_coding_emacs_mule, detect_coding_iso_2022):
2438 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5):
2439 (decode_coding_raw_text, decode_coding_charset, get_translation_table):
2440 (Fdecode_sjis_char, Fdefine_coding_system_internal):
2441 Rename locals to avoid shadowing.
2442 * character.h (FETCH_STRING_CHAR_ADVANCE): Likewise.
2443 * coding.c (emacs_mule_char, encode_invocation_designation):
2444 Now static, since they're not used elsewhere.
2445 (decode_coding_iso_2022): Add "default: abort ();" as a safety check.
2446 (decode_coding_object, encode_coding_object, detect_coding_system):
2447 (decode_coding_emacs_mule): Mark variables that gcc
2448 -Wuninitialized does not deduce are never used uninitialized.
2449 (detect_coding_iso_2022): Initialize a local variable that might
2450 be used uninitialized. Leave a FIXME because it's not clear that
2451 this initialization is needed. (Bug#8211)
2452 (ISO_CODE_LF, ISO_CODE_CR, CODING_ISO_FLAG_EUC_TW_SHIFT):
2453 (ONE_MORE_BYTE_NO_CHECK, UTF_BOM, UTF_16_INVALID_P):
2454 (SHIFT_OUT_OK, ENCODE_CONTROL_SEQUENCE_INTRODUCER):
2455 (ENCODE_DIRECTION_R2L, ENCODE_DIRECTION_L2R):
2456 Remove unused macros.
2458 * category.c (hash_get_category_set): Remove unused local var.
2459 (copy_category_table): Now static, since it's not used elsewhere.
2460 * character.c (string_count_byte8): Likewise.
2462 * ccl.c (CCL_WRITE_STRING, CCL_ENCODE_CHAR, Fccl_execute_on_string):
2463 (Fregister_code_conversion_map): Rename locals to avoid shadowing.
2465 * chartab.c (copy_sub_char_table): Now static, since it's not used
2467 (sub_char_table_ref_and_range, char_table_ref_and_range):
2468 Rename locals to avoid shadowing.
2469 (ASET_RANGE, GET_SUB_CHAR_TABLE): Remove unused macros.
2471 * bidi.c (bidi_check_type): Now static, since it's not used elsewhere.
2472 (BIDI_BOB): Remove unused macro.
2474 * cm.c (cmgoto): Mark variables that gcc -Wuninitialized does not
2475 deduce are never used uninitialized.
2476 * term.c (encode_terminal_code): Likewise.
2478 * term.c (encode_terminal_code): Now static. Remove unused local.
2480 * tparam.h: New file.
2481 * term.c, tparam.h: Include it.
2482 * deps.mk (term.o, tparam.o): Depend on tparam.h.
2483 * term.c (tputs, tgetent, tgetflag, tgetnum, tparam, tgetstr):
2484 Move these decls to tparam.h, and make them agree with what
2485 is actually in tparam.c. The previous trick of using incompatible
2486 decls in different modules does not conform to the C standard.
2487 All callers of tparam changed to use tparam's actual API.
2488 * tparam.c (tparam1, tparam, tgoto):
2489 Use const pointers where appropriate.
2491 * cm.c (calccost, cmgoto): Use const pointers where appropriate.
2492 * cm.h (struct cm): Likewise.
2493 * dispextern.h (do_line_insertion_deletion_costs): Likewise.
2494 * scroll.c (ins_del_costs, do_line_insertion_deletion_costs): Likewise.
2495 * term.c (tty_ins_del_lines, calculate_costs, struct fkey_table):
2496 (term_get_fkeys_1, append_glyphless_glyph, produce_glyphless_glyph):
2497 (turn_on_face, init_tty): Likewise.
2498 * termchar.h (struct tty_display_info): Likewise.
2500 * term.c (term_mouse_position): Rename local to avoid shadowing.
2502 * alloc.c (mark_ttys): Move decl from here ...
2503 * lisp.h (mark_ttys): ... to here, so that it's checked against defn.
2505 2011-03-11 Andreas Schwab <schwab@linux-m68k.org>
2507 * .gdbinit (pwinx, xbuffer): Fix access to buffer name.
2509 2011-03-09 Juanma Barranquero <lekktu@gmail.com>
2511 * search.c (compile_pattern_1): Remove argument regp, unused since
2512 revid:rms@gnu.org-19941211082627-3x1g1wyqkjmwloig.
2513 (compile_pattern): Don't pass it.
2515 2011-03-08 Jan Djärv <jan.h.d@swipnet.se>
2517 * xterm.h (DEFAULT_GDK_DISPLAY): New define.
2518 (GDK_WINDOW_XID, gtk_widget_get_preferred_size): New defines
2520 (GTK_WIDGET_TO_X_WIN): Use GDK_WINDOW_XID.
2522 * xmenu.c (menu_position_func): Call gtk_widget_get_preferred_size.
2524 * gtkutil.c: Include gtkx.h if HAVE_GTK3. If ! HAVE_GTK3, define
2525 gdk_window_get_screen, gdk_window_get_geometry,
2526 gdk_x11_window_lookup_for_display and GDK_KEY_g.
2527 (xg_set_screen): Use DEFAULT_GDK_DISPLAY.
2528 (xg_get_pixbuf_from_pixmap): New function.
2529 (xg_get_pixbuf_from_pix_and_mask): Change parameters from GdkPixmap
2530 to Pixmap, take frame as parameter, remove GdkColormap parameter.
2531 Call xg_get_pixbuf_from_pixmap instead of
2532 gdk_pixbuf_get_from_drawable.
2533 (xg_get_image_for_pixmap): Do not make GdkPixmaps, call
2534 xg_get_pixbuf_from_pix_and_mask with Pixmap parameters instead.
2535 (xg_check_special_colors): Use GtkStyleContext and its functions
2537 (xg_prepare_tooltip, xg_hide_tooltip): Call gdk_window_get_screen.
2538 (xg_prepare_tooltip, create_dialog, menubar_map_cb)
2539 (xg_update_frame_menubar, xg_tool_bar_detach_callback)
2540 (xg_tool_bar_attach_callback, xg_update_tool_bar_sizes):
2541 Call gtk_widget_get_preferred_size.
2542 (xg_frame_resized): gdk_window_get_geometry only takes 5
2544 (xg_win_to_widget, xg_event_is_for_menubar):
2545 Call gdk_x11_window_lookup_for_display.
2546 (xg_set_widget_bg): New function.
2547 (delete_cb): New function.
2548 (xg_create_frame_widgets): connect delete-event to delete_cb.
2549 Call xg_set_widget_bg. Only set backgrund pixmap for ! HAVE_GTK3
2550 (xg_set_background_color): Call xg_set_widget_bg.
2551 (xg_set_frame_icon): Call xg_get_pixbuf_from_pix_and_mask.
2552 (xg_create_scroll_bar): vadj is a GtkAdjustment for HAVE_GTK3.
2553 Only call gtk_range_set_update_policy if ! HAVE_GTK3.
2554 (xg_make_tool_item): Only connect xg_tool_bar_item_expose_callback
2556 (update_frame_tool_bar): Call gtk_widget_hide.
2557 (xg_initialize): Use GDK_KEY_g.
2559 * xsmfns.c (gdk_set_sm_client_id): Define to gdk_set_sm_client_id
2561 (x_session_initialize): Call gdk_x11_set_sm_client_id.
2563 * xterm.c (XFillRectangle): Use cairo routines for HAVE_GTK3.
2564 (x_term_init): Disable Xinput(2) with GDK_CORE_DEVICE_EVENTS.
2565 Load ~/emacs.d/gtkrc only for ! HAVE_GTK3.
2567 2011-03-08 Juanma Barranquero <lekktu@gmail.com>
2569 * w32xfns.c (select_palette): Check success of RealizePalette against
2570 GDI_ERROR, not zero.
2572 See ChangeLog.11 for earlier changes.
2578 Copyright (C) 2011 Free Software Foundation, Inc.
2580 This file is part of GNU Emacs.
2582 GNU Emacs is free software: you can redistribute it and/or modify
2583 it under the terms of the GNU General Public License as published by
2584 the Free Software Foundation, either version 3 of the License, or
2585 (at your option) any later version.
2587 GNU Emacs is distributed in the hope that it will be useful,
2588 but WITHOUT ANY WARRANTY; without even the implied warranty of
2589 MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
2590 GNU General Public License for more details.
2592 You should have received a copy of the GNU General Public License
2593 along with GNU Emacs. If not, see <http://www.gnu.org/licenses/>.