e22d6cb8cfbc6488a62969afa513e9ff4cedff22
[bpt/emacs.git] / src / ChangeLog
1 2011-12-05 Chong Yidong <cyd@gnu.org>
2
3 * keyboard.c (process_special_events): New function.
4 (swallow_events, Finput_pending_p): Use it (Bug#10195).
5
6 2011-12-05 Paul Eggert <eggert@cs.ucla.edu>
7
8 * coding.c (encode_designation_at_bol): Don't use uninitialized
9 local variable (Bug#9318).
10
11 2011-12-05 Kenichi Handa <handa@m17n.org>
12
13 * ftfont.c (get_adstyle_property): If the font is not BDF nor PCF,
14 return Qnil (Bug#8046, Bug#10193).
15
16 2011-12-05 Kenichi Handa <handa@m17n.org>
17
18 * coding.c (encode_designation_at_bol): New args charbuf_end and
19 dst. Return the number of produced bytes. Callers changed.
20 (coding_set_source): Return how many bytes coding->source was
21 relocated.
22 (coding_set_destination): Return how many bytes
23 coding->destination was relocated.
24 (CODING_DECODE_CHAR, CODING_ENCODE_CHAR, CODING_CHAR_CHARSET)
25 (CODING_CHAR_CHARSET_P): Adjusted for the avove changes.
26
27 2011-12-05 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny change)
28
29 * coding.c (CODING_CHAR_CHARSET_P): New macro.
30 (encode_coding_emacs_mule, encode_coding_iso_2022): Use the above
31 macro (Bug#9318).
32
33 2011-12-05 Andreas Schwab <schwab@linux-m68k.org>
34
35 The following changes are to fix Bug#9318.
36
37 * coding.c (CODING_ENCODE_CHAR, CODING_CHAR_CHARSET): New macros.
38 (encode_coding_emacs_mule, ENCODE_ISO_CHARACTER)
39 (encode_coding_iso_2022, encode_coding_sjis)
40 (encode_coding_big5, encode_coding_charset): Use the above macros.
41
42 2011-12-05 Juanma Barranquero <lekktu@gmail.com>
43
44 * lisp.h (process_quit_flag): Fix external declaration.
45
46 2011-12-04 Stefan Monnier <monnier@iro.umontreal.ca>
47
48 Don't macro-inline non-performance-critical code.
49 * eval.c (process_quit_flag): New function.
50 * lisp.h (QUIT): Use it.
51
52 2011-12-04 Jan Djärv <jan.h.d@swipnet.se>
53
54 * nsfns.m (get_geometry_from_preferences): New function.
55 (Fx_create_frame): Call get_geometry_from_preferences (Bug#10103).
56
57 2011-12-04 Andreas Schwab <schwab@linux-m68k.org>
58
59 * emacs.c (Qkill_emacs): Define.
60 (syms_of_emacs): Initialize it.
61 * keyboard.c (interrupt_signal): Don't call Fkill_emacs here, set
62 Qquit_flag to `kill-emacs' instead.
63 (quit_throw_to_read_char): Add parameter `from_signal'.
64 All callers changed. Call Fkill_emacs if requested and safe.
65 * lisp.h (QUIT): Call Fkill_emacs if requested.
66
67 2011-12-03 Jan Djärv <jan.h.d@swipnet.se>
68
69 * widget.c (update_wm_hints): Return if wmshell is null.
70 (widget_update_wm_size_hints): New function.
71
72 * widget.h (widget_update_wm_size_hints): Declare.
73
74 * xterm.c (x_wm_set_size_hint): If USE_X_TOOLKIT, call
75 widget_update_wm_size_hints (Bug#10104).
76
77 2011-12-03 Eli Zaretskii <eliz@gnu.org>
78
79 * xdisp.c (handle_invisible_prop): If the invisible text ends just
80 before a newline, prepare the bidi iterator for consuming the
81 newline, and keep the current paragraph direction. (Bug#10183)
82 (redisplay_window): Don't let `margin' become negative. (Bug#10192)
83
84 2011-12-02 Juri Linkov <juri@jurta.org>
85
86 * search.c (Fword_search_regexp): New Lisp function created from
87 `wordify'. Change type of arg `lax' from `int' to `Lisp_Object'.
88 (Fword_search_backward, Fword_search_forward)
89 (Fword_search_backward_lax, Fword_search_forward_lax):
90 Use `Fword_search_regexp' instead of `wordify'. Doc fix.
91 (syms_of_search): Define `Sword_search_regexp'. (Bug#10145)
92
93 2011-12-01 Stefan Monnier <monnier@iro.umontreal.ca>
94
95 * fileio.c (Finsert_file_contents): Move after-change-function call
96 to before the "handled:" label, since all "goto handled" appear in
97 cases where the *-change-functions have already been properly called
98 (bug#10117).
99
100 2011-12-01 Andreas Schwab <schwab@linux-m68k.org>
101
102 * keyboard.c (interrupt_signal): Don't call kill-emacs when
103 waiting for input. (Bug#10169)
104
105 2011-11-30 Eli Zaretskii <eliz@gnu.org>
106
107 * dispnew.c (adjust_glyph_matrix): Remove the assertion that
108 verifies glyph row's hash code--we have just reallocated the
109 glyphs, so their contents can be complete garbage. (Bug#10164)
110
111 2011-11-30 Juanma Barranquero <lekktu@gmail.com>
112
113 * dispnew.c (adjust_glyph_matrix) [XASSERTS]: Add missing check.
114
115 2011-11-30 Eli Zaretskii <eliz@gnu.org>
116
117 * dispnew.c (adjust_glyph_matrix) [XASSERTS]: Ensure ROW's
118 attributes are tested _before_ calling verify_row_hash, to protect
119 against GCC re-ordering of the tests. (Bug#10164)
120
121 2011-11-29 Jan Djärv <jan.h.d@swipnet.se>
122
123 * xterm.h (struct x_output): net_wm_state_hidden_seen is new.
124
125 * xterm.c (handle_one_xevent): Only set async_visible and friends
126 if net_wm_state_hidden_seen is non-zero (Bug#10002)
127 (get_current_wm_state): Set net_wm_state_hidden_seen to 1 if
128 _NET_WM_STATE_HIDDEN is in NET_WM_STATE.
129
130 2011-11-28 Paul Eggert <eggert@cs.ucla.edu>
131
132 Remove GCPRO-related macros that exist only to avoid shadowing locals.
133 * lisp.h (GCPRO1_VAR, GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR, GCPRO5_VAR)
134 (GCPRO6_VAR, UNGCPRO_VAR): Remove. See
135 <http://lists.gnu.org/archive/html/emacs-diffs/2011-11/msg00265.html>.
136 All uses changed to use GCPRO1 etc.
137 (GCPRO1, GCPRO2, GCPRO3, GCPRO4, GCPRO5, GCPRO6, UNGCPRO):
138 Revert to old implementation (i.e., before 2011-03-11).
139
140 2011-11-28 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
141
142 * dispnew.c (scrolling_window): Truncate overlaps in copy destination
143 of scroll runs so as to avoid assigning disabled bogus rows and
144 unnecessary graphics copy operations.
145
146 2011-11-27 Eli Zaretskii <eliz@gnu.org>
147
148 * s/ms-w32.h (utimbuf) [_MSC_VER]: Don't define.
149 (snprintf) [_MSC_VER]: Redirect to _snprintf.
150 (strtoll) [_MSC_VER]: Redirect to _strtoi64.
151 (malloc, free, realloc, calloc): Redirect to e_* only when
152 compiling Emacs.
153
154 * lisp.h (GCTYPEBITS): Move before first use.
155 (ALIGN_GCTYPEBITS) [_MSC_VER]: Define.
156 (DECL_ALIGN) [_MSC_VER]: Use it, as MSVC doesn't like bit ops in
157 this macro definition.
158
159 * s/ms-w32.h (tzname): Redirect to _tzname for all values of
160 _MSC_VER.
161
162 2011-11-27 Jan Djärv <jan.h.d@swipnet.se>
163
164 * gtkutil.c (xg_create_frame_widgets):
165 Call gtk_window_set_has_resize_grip (FALSE) if that function is
166 present with Gtk+ 2.0.
167
168 2011-11-26 Paul Eggert <eggert@cs.ucla.edu>
169
170 * fileio.c (Finsert_file_contents): Undo previous change; see
171 <http://lists.gnu.org/archive/html/emacs-diffs/2011-11/msg00265.html>.
172
173 2011-11-26 Paul Eggert <eggert@cs.ucla.edu>
174
175 Rename locals to avoid shadowing.
176 * fileio.c (Finsert_file_contents):
177 Rename inner 'gcpro1' to 'inner_gcpro1' to avoid shadowing.
178 * process.c (wait_reading_process_output):
179 Rename inner 'proc' to 'p' to avoid shadowing.
180 Indent for consistency with usual Emacs style.
181
182 2011-11-25 Eli Zaretskii <eliz@gnu.org>
183
184 * xdisp.c (redisplay_window): If cursor row is not fully visible
185 after recentering, and scroll-conservatively is set to a large
186 number, scroll window by a few more lines to make the cursor fully
187 visible and out of scroll-margin. (Bug#10105)
188 (start_display): Don't move to the next line if the display should
189 start at a newline that is part of a display vector or an overlay
190 string. (Bug#10119)
191
192 2011-11-24 Juri Linkov <juri@jurta.org>
193
194 * image.c (imagemagick_load_image): Move `MagickSetResolution' down
195 after the `MagickPingImage' call. (Bug#10112)
196
197 2011-11-23 Chong Yidong <cyd@gnu.org>
198
199 * window.c (Fcoordinates_in_window_p): Accept only live windows.
200
201 2011-11-23 Martin Rudalics <rudalics@gmx.at>
202
203 * buffer.c (Fkill_buffer): Run replace_buffer_in_windows before
204 making another buffer current. (Bug#10114)
205
206 2011-11-23 Glenn Morris <rgm@gnu.org>
207
208 * font.c (font_find_for_lface) [HAVE_NS]: Ignore case. (Bug#2526)
209
210 2011-11-23 Chong Yidong <cyd@gnu.org>
211
212 * xdisp.c (compute_stop_pos): Check validity of end_charpos before
213 using it (Bug#5984).
214
215 2011-11-22 Eli Zaretskii <eliz@gnu.org>
216
217 * dispnew.c (adjust_glyph_matrix): Don't verify hash code of mode-
218 and header-lines, as they don't have one computed for them.
219 (Bug#10098)
220
221 * .gdbinit (prow): Make displayed values more self-explaining.
222 Add row's hash code.
223
224 2011-11-21 Lars Magne Ingebrigtsen <larsi@gnus.org>
225
226 * process.c (wait_reading_process_output): Fix asynchrounous
227 GnuTLS socket handling on some versions of the GnuTLS library.
228 (wait_reading_process_output): Add comment and URL.
229
230 2011-11-21 Jan Djärv <jan.h.d@swipnet.se>
231
232 * xterm.c (x_clear_frame): Reinstate the XClearWindow call.
233
234 2011-11-21 Chong Yidong <cyd@gnu.org>
235
236 * window.c (Fnext_window, Fprevious_window): Doc fix.
237
238 2011-11-20 Stefan Monnier <monnier@iro.umontreal.ca>
239
240 * window.c (get_phys_cursor_glyph): Fix Lisp_Object/int mixup.
241
242 2011-11-20 Juanma Barranquero <lekktu@gmail.com>
243
244 * nsfont.m (syms_of_nsfont) <ns-reg-to-script>: Fix typo.
245
246 2011-11-20 Martin Rudalics <rudalics@gmx.at>
247
248 * window.c (Fset_window_combination_limit): Rename argument
249 STATUS to LIMIT.
250 (Vwindow_combination_limit): Remove "status" from doc-string.
251
252 2011-11-20 Andreas Schwab <schwab@linux-m68k.org>
253
254 * m/ibms390.h: Remove.
255 * m/ibms390x.h: Don't include "ibms390.h".
256
257 2011-11-20 Stefan Monnier <monnier@iro.umontreal.ca>
258
259 * fileio.c (Finsert_file_contents): Add missing gcpro1 variable.
260 Suggested by Dmitry Antipov <dmantipov@yandex.ru>.
261
262 2011-11-20 Juanma Barranquero <lekktu@gmail.com>
263
264 * casetab.c (Fset_case_table):
265 * charset.c (Fcharset_after): Fix typos.
266
267 2011-11-20 Paul Eggert <eggert@cs.ucla.edu>
268
269 Standardize on VIRT_ADDR_VARIES behavior (Bug#10042).
270 Otherwise, valgrind does not work on some platforms.
271 Problem reported by Andreas Schwab in
272 <http://lists.gnu.org/archive/html/emacs-devel/2011-11/msg00081.html>.
273 * puresize.h (pure, PURE_P): Always behave as if VIRT_ADDR_VARIES
274 is set, removing the need for VIRT_ADDRESS_VARIES.
275 (PURE_P): Use a more-efficient implementation that needs just one
276 comparison, not two: on x86-64 with GCC 4.6.2, this cut down the
277 number of instructions from 6 (xorl, cmpq, jge, xorl, cmpq, setge)
278 to 4 (xorl, subq, cmpq, setbe).
279 * alloc.c (pure): Always extern now, since that's the
280 VIRT_ADDR_VARIES behavior.
281 (PURE_POINTER_P): Use a single comparison, not two, for
282 consistency with the new puresize.h.
283 * lisp.h (PNTR_COMPARISON_TYPE): Remove; no longer needed.
284 * m/ibms390.h, m/intel386.h, m/template.h, s/cygwin.h, s/hpux10-20.h:
285 Remove VIRT_ADDR_VARIES no longer needed.
286
287 2011-11-19 Eli Zaretskii <eliz@gnu.org>
288
289 * xdisp.c (x_write_glyphs, draw_phys_cursor_glyph)
290 (erase_phys_cursor, update_window_cursor, show_mouse_face)
291 (cursor_in_mouse_face_p): If the cursor position is out of bounds,
292 behave as if the cursor position were at the window margin.
293
294 * window.c (get_phys_cursor_glyph): If the window is hscrolled,
295 and the cursor position is out of bounds, behave as if the cursor
296 position were at the window margin. (Bug#10075)
297
298 2011-11-18 Chong Yidong <cyd@gnu.org>
299
300 * window.c (Fwindow_combination_limit): Make first argument
301 non-optional, since it is meaningless for live windows like the
302 selected window.
303
304 2011-11-18 Dmitry Antipov <dmantipov@yandex.ru>
305
306 * keymap.c (Fwhere_is_internal): Add missing RETURN_UNGCPROs.
307
308 2011-11-18 Stefan Monnier <monnier@iro.umontreal.ca>
309
310 * intervals.c: Fix grafting over the whole buffer (bug#10071).
311 (graft_intervals_into_buffer): Simplify.
312
313 2011-11-18 Eli Zaretskii <eliz@gnu.org>
314
315 * dispnew.c (swap_glyph_pointers): Swap the used[] arrays and the
316 hash values of the two rows.
317 (copy_row_except_pointers): Preserve the used[] arrays and the
318 hash values of the two rows. (Bug#10035)
319 (add_row_entry): Add xassert to verify that ROW's hash code is valid.
320
321 * xdisp.c (row_hash): New function, body extracted from
322 compute_line_metrics.
323 (compute_line_metrics): Call row_hash, instead of computing the
324 hash code inline.
325
326 * dispnew.c (verify_row_hash): Call row_hash for computing the
327 hash code of a row, instead of duplicating code from xdisp.c.
328
329 * dispextern.h (row_hash): Add prototype.
330
331 2011-11-18 Tassilo Horn <tassilo@member.fsf.org>
332
333 * frame.c (delete_frame): Don't delete the terminal when the last
334 X frame is closed if emacs is built with GTK toolkit.
335
336 2011-11-17 Juanma Barranquero <lekktu@gmail.com>
337
338 * window.c (syms_of_window) <window-combination-resize>: Fix typo.
339
340 2011-11-17 Martin Rudalics <rudalics@gmx.at>
341
342 * window.c (Vwindow_splits): Rename to
343 Vwindow_combination_resize. Suggested by Juri Linkov.
344 (Fsplit_window_internal): Use Vwindow_combination_resize instead
345 of Vwindow_splits.
346
347 2011-11-16 Juanma Barranquero <lekktu@gmail.com>
348
349 * nsfns.m (Fns_font_name):
350 * window.c (syms_of_window) <window-combination-limit>: Fix typos.
351
352 2011-11-16 Martin Rudalics <rudalics@gmx.at>
353
354 * window.h (window): Rename slot "nest" to "combination_limit".
355 * window.c (Fwindow_nest): Rename to Fwindow_combination_limit.
356 (Fset_window_nest): Rename to Fset_window_combination_limit.
357 (Vwindow_nest): Rename to Vwindow_combination_limit.
358 (recombine_windows, make_parent_window, make_window)
359 (Fsplit_window_internal, saved_window)
360 (Fset_window_configuration, save_window_save): Rename all
361 occurrences of window_nest to window_combination_limit.
362
363 2011-11-15 Juanma Barranquero <lekktu@gmail.com>
364
365 * image.c (imagemagick_load_image): Fix typo.
366
367 2011-11-14 Eli Zaretskii <eliz@gnu.org>
368
369 * xdisp.c (display_line): Move the call to
370 highlight_trailing_whitespace before the call to
371 compute_line_metrics, since the latter needs to see the final
372 faces of all the glyphs to compute ROW's hash value.
373 Fixes assertion violations in row_equal_p. (Bug#10035)
374
375 2011-11-14 Juanma Barranquero <lekktu@gmail.com>
376
377 * w32proc.c (reader_thread): Don't check pending input if cp->fd < 0,
378 just return (bug#10044).
379
380 2011-11-12 Eli Zaretskii <eliz@gnu.org>
381
382 * makefile.w32-in (HEAPSIZE): New variable, allows to build temacs
383 with user-defined heap size. Bump the default size of the temacs
384 heap to 27MB, to avoid memory warning when running temacs.
385 ($(TEMACS)): Use HEAPSIZE instead of a hardcoded value.
386
387 * dispnew.c (scrolling_window): Fix incorrect indices in accessing
388 current_matrix and desired_matrix. (Bug#9990)
389 (verify_row_hash) [XASSERTS]: New function.
390 (adjust_glyph_matrix, row_equal_p): Use it in xassert to verify
391 that the hash value of glyph rows is correct.
392
393 2011-11-12 Martin Rudalics <rudalics@gmx.at>
394
395 * window.h (window): Remove splits slot.
396 * window.c (Fwindow_splits, Fset_window_splits): Remove.
397 (Fdelete_other_windows_internal, make_parent_window)
398 (make_window, Fsplit_window_internal, Fdelete_window_internal)
399 (Fset_window_configuration, save_window_save): Don't deal with
400 split status of windows.
401 (saved_window): Remove splits slot.
402 (Vwindow_splits): Rewrite doc-string.
403
404 2011-11-11 Jan Djärv <jan.h.d@swipnet.se>
405
406 * xfns.c (unwind_create_frame):
407 * nsfns.m (unwind_create_frame):
408 * w32fns.c (unwind_create_frame): Use Fmemq to check if frame is in
409 Vframe_list (Bug#9999).
410
411 2011-11-11 Dmitry Antipov <dmantipov@yandex.ru>
412
413 * xdisp.c (syms_of_xdisp): Remove duplicated definition of Qtext.
414
415 2011-11-11 Kenichi Handa <handa@m17n.org>
416
417 * callproc.c (Fcall_process): Set the member dst_multibyte of
418 process_coding.
419
420 2011-11-11 Johan Bockgård <bojohan@gnu.org>
421
422 * xdisp.c (fill_composite_glyph_string): Always set s->face, to
423 avoid a crash (bug#9496).
424
425 2011-11-09 Chong Yidong <cyd@gnu.org>
426
427 * window.c (Fwindow_inside_edges, Fwindow_inside_pixel_edges)
428 (Fwindow_inside_absolute_pixel_edges): Only allow live windows.
429
430 2011-11-08 Paul Eggert <eggert@cs.ucla.edu>
431
432 * s/gnu.h (GC_MARK_STACK): Define to GC_MAKE_GCPROS_NOOPS (Bug#9926).
433
434 2011-11-08 Paul Eggert <eggert@cs.ucla.edu>
435
436 Avoid some portability problems by eschewing 'extern inline' functions.
437 The trivial performance wins aren't worth the portability hassles; see
438 <http://lists.gnu.org/archive/html/emacs-devel/2011-11/msg00084.html>
439 et seq.
440 * dispextern.h (window_box, window_box_height, window_text_bottom_y)
441 (window_box_width, window_box_left, window_box_left_offset)
442 (window_box_right, window_box_right_offset): Undo previous change,
443 by removing the "extern"s.
444 * intervals.c (adjust_intervals_for_insertion)
445 (adjust_intervals_for_deletion): Undo previous change,
446 making these static again.
447 (offset_intervals, temp_set_point_both, temp_set_point)
448 (copy_intervals_to_string): No longer inline.
449 * xdisp.c (window_text_bottom_y, window_box_width)
450 (window_box_height, window_box_left_offset)
451 (window_box_right_offset, window_box_left, window_box_right)
452 (window_box): No longer inline.
453
454 2011-11-08 Chong Yidong <cyd@gnu.org>
455
456 * window.c (Fwindow_left_column, Fwindow_top_line): Doc fix.
457 (Fwindow_body_height, Fwindow_body_width): Move from Lisp.
458 Signal an error if not a live window.
459 (Fwindow_total_width, Fwindow_total_height): Move from Lisp.
460 (Fwindow_total_size, Fwindow_body_size): Move to Lisp.
461
462 2011-11-07 Juanma Barranquero <lekktu@gmail.com>
463
464 * lisp.h (syms_of_abbrev): Remove declaration.
465 Reported by CHENG Gao <chenggao@royau.me>.
466
467 2011-11-07 Eli Zaretskii <eliz@gnu.org>
468
469 * w32.c (check_windows_init_file): Don't look for term/w32-win.el
470 if Vpurify_flag is non-nil. Fixes a crash when running w32 build
471 of temacs in GUI mode.
472
473 2011-11-07 Martin Rudalics <rudalics@gmx.at>
474
475 * window.h: Declare delete_all_child_windows instead of
476 delete_all_subwindows.
477 * window.c (Fwindow_nest, Fset_window_nest)
478 (Fset_window_new_total, Fset_window_new_normal)
479 (Fwindow_resize_apply): Don't use term subwindow in doc-strings.
480 (delete_all_subwindows): Rename to delete_all_child_windows.
481 (Fdelete_other_windows_internal, Fset_window_configuration):
482 Call delete_all_child_windows instead of delete_all_subwindows.
483 * frame.c (delete_frame): Call delete_all_child_windows instead
484 of delete_all_subwindows.
485
486 2011-11-07 Paul Eggert <eggert@cs.ucla.edu>
487
488 * alloc.c (DEADP): New macro, for porting to GNU/Hurd (Bug#9926).
489 This is also needed for porting to any host where GC_MARK_STACK is
490 not GC_MAKE_GCPROS_NOOPS.
491 (which_symbols): Use it.
492
493 2011-11-07 Kenichi Handa <handa@m17n.org>
494
495 * coding.c (coding_set_destination): Check coding->src_pos only
496 when coding->src_object is a buffer (bug#9910).
497
498 * process.c (send_process): Set the member src_multibyte of coding
499 to 0 (bug#9911) when sending a unibyte text.
500
501 * callproc.c (Fcall_process): Set the member src_multibyte of
502 process_coding to 0 (bug#9912).
503
504 2011-11-06 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
505
506 * xmenu.c (cleanup_widget_value_tree): New function.
507 (xmenu_show, xdialog_show): Use it in record_unwind_protect instead of
508 calling free_menubar_widget_value_tree directly (Bug#9830).
509
510 2011-11-06 Paul Eggert <eggert@cs.ucla.edu>
511
512 Fix some portability problems with 'inline'.
513 * dispextern.h (window_box, window_box_height, window_text_bottom_y)
514 (window_box_width, window_box_left, window_box_left_offset)
515 (window_box_right, window_box_right_offset): Declare extern.
516 Otherwise, these inline functions do not conform to C99 and
517 are miscompiled by Microsoft compilers. Reported by Eli Zaretskii in
518 <http://lists.gnu.org/archive/html/emacs-devel/2011-11/msg00084.html>.
519 * intervals.c (adjust_intervals_for_insertion)
520 (adjust_intervals_for_deletion): Now extern, because otherwise the
521 extern inline functions 'offset_intervals' couldn't refer to it.
522 (static_offset_intervals): Remove.
523 (offset_intervals): Rewrite using the old contents of
524 static_offset_intervals. The old version didn't conform to C99
525 because an extern inline function contained a reference to an
526 identifier with static linkage.
527
528 2011-11-06 Andreas Schwab <schwab@linux-m68k.org>
529
530 * keyboard.c (interrupt_signal): Don't call kill-emacs while in
531 GC.
532
533 2011-11-06 Eli Zaretskii <eliz@gnu.org>
534
535 * xdisp.c (init_iterator, reseat_to_string): Don't set the
536 iterator's bidi_p flag if Vpurify_flag is non-nil. (Bug#9963)
537 (Fcurrent_bidi_paragraph_direction): If Vpurify_flag is non-nil,
538 return Qleft_to_right.
539
540 2011-11-06 Chong Yidong <cyd@gnu.org>
541
542 * window.c (Fwindow_live_p, Fwindow_frame, Fframe_root_window)
543 (Fminibuffer_window, Fwindow_buffer, Fwindow_splits)
544 (Fset_window_splits, Fwindow_nest, Fset_window_nest)
545 (Fwindow_use_time, Fwindow_total_size, Fwindow_normal_size)
546 (Fwindow_new_normal, Fwindow_left_column, Fwindow_top_line)
547 (Fwindow_margins, Fwindow_fringes, Fwindow_scroll_bars)
548 (Fwindow_vscroll): Doc fix.
549 (Fwindow_top_child, Fwindow_left_child): Eliminate a nil default
550 argument, since it makes no sense to pass a live window and for
551 consistency with window-child.
552
553 2011-11-05 Christoph Scholtes <cschol2112@googlemail.com>
554
555 * makefile.w32-in ($(TEMACS), (gl-stamp)): Use $(THISDIR) to
556 support MSVC.
557
558 2011-11-05 Jason Rumney <jasonr@gnu.org>
559
560 * w32font.c (font_matches_spec): Filter out non-Japanese kana fonts.
561 (add_font_entity_to_list): Filter out non-Japanese Shift-JIS
562 fonts (Bug#6029).
563 (add_font_entity_to_list): Fix logic errors in mixed boolean and
564 bitwise arithmetic preventing use of unicode-sip and non-truetype
565 opentype fonts.
566
567 2011-11-05 Eli Zaretskii <eliz@gnu.org>
568
569 * s/ms-w32.h (fstat, stat, utime): Move redirections to
570 "emacs"-only part.
571
572 * w32fns.c (x_create_tip_frame, Fx_create_frame): Rearrange
573 initialization code to keep similarity to xfns.c after changes
574 from 2011-11-05.
575
576 2011-11-05 Jan Djärv <jan.h.d@swipnet.se>
577
578 * nsfns.m: Declare image_cache_refcount if GLYPH_DEBUG.
579 (unwind_create_frame): New function (Bug#9943).
580 (Fx_create_frame): Restructure code to be more similar to the one in
581 xfns.c. Call record_unwind_protect with unwind_create_frame (Bug#9943).
582 Initialize image_cache_refcount if GLYPH_DEBUG (Bug#9943).
583 Move terminal->reference_count++ just before making the frame official
584 (Bug#9943).
585
586 * nsterm.m (x_free_frame_resources): New function.
587 (x_destroy_window): Move code to x_free_frame_resources.
588
589 * xfns.c (unwind_create_frame): Fix comment.
590 (Fx_create_frame, x_create_tip_frame):
591 Move terminal->reference_count++ just before making the frame
592 official. Move initialization of image_cache_refcount and
593 dpyinfo_refcount before calling init_frame_faces (Bug#9943).
594
595 2011-11-05 Eli Zaretskii <eliz@gnu.org>
596
597 Support MSVC build with newer versions of Visual Studio.
598 * makefile.w32-in (TAGS-gmake): Don't use $(patsubst ...), as
599 Nmake barfs on that. Use $(OBJ*_c) variables instead, defined on
600 nt/gmake.defs.
601
602 * lisp.h (ENUM_BF): New macro, for enumerated types in bitfields,
603 which are not supported by MSVC.
604 (Lisp_Symbol, Lisp_Misc_Any, Lisp_Marker, Lisp_Misc_Overlay)
605 (Lisp_Save_Value, Lisp_Free): Use ENUM_BF for enumerated types in
606 bitfields.
607 (Lisp_Object) [USE_LISP_UNION_TYPE]: Use ENUM_BF for enumerated
608 types in bitfields.
609 (DEFUN) [_MSC_VER]: Define in a different way for MSVC.
610
611 * w32fns.c [_MSC_VER]: DECLARE_HANDLE for any MSVC version.
612
613 2011-11-05 Fabrice Popineau <fabrice.popineau@supelec.fr> (tiny change)
614
615 Support MSVC build with newer versions of Visual Studio.
616 * w32.c: Don't include w32api.h for MSVC.
617 (init_environment) [_MSC_VER]: Call sys_access, not _access.
618
619 * s/ms-w32.h <sigset_t, ssize_t> [_MSC_VER]: Typedefs for MSVC.
620 [_MSC_VER]: Include sys/timeb.h, sys/stat.h, and signal.h.
621 (fstat, stat, utime) [_MSC_VER]: Redirect to their sys_* cousins.
622 (malloc, free, realloc, calloc) [_MSC_VER]: Always redirect to the
623 e_* cousins.
624 (alloca) [_MSC_VER]: Define to _alloca.
625
626 * lisp.h (DECL_ALIGN) [_MSC_VER]: Define for MSVC.
627
628 * regex.c <re_char> [_MSC_VER]: A separate definition for MSVC.
629
630 2011-11-04 Eli Zaretskii <eliz@gnu.org>
631
632 * xdisp.c (note_mouse_highlight): If either of
633 previous/next-single-property-change returns nil, treat that as
634 the beginning or the end of the buffer. (Bug#9955)
635
636 2011-11-04 Jan Djärv <jan.h.d@swipnet.se>
637
638 * gtkutil.c (xg_make_tool_item): Add callbacks if one of wimage or
639 label is not null (Bug#9951).
640 (xg_tool_item_stale_p): Handle the fact that wimage and/or wlbl
641 may be NULL.
642
643 2011-11-04 Eli Zaretskii <eliz@gnu.org>
644
645 * window.c (Fwindow_body_size): Mention in the doc string that the
646 return value is in frame's canonical units. (Bug#9949)
647
648 2011-11-03 Eli Zaretskii <eliz@gnu.org>
649
650 * xdisp.c (note_mouse_highlight): Initialize `area'. (Bug#9947)
651
652 * w32fns.c (unwind_create_frame): If needed, free the glyph
653 matrices of the partially constructed frame. (Bug#9943)
654 * xfns.c (unwind_create_frame): Likewise.
655
656 2011-11-01 Eli Zaretskii <eliz@gnu.org>
657
658 * xdisp.c (mouse_face_from_buffer_pos): Fix a typo in a comment.
659 Don't stop backward scan on the continuation glyph, even though
660 its CHARPOS is positive.
661 (mouse_face_from_buffer_pos, note_mouse_highlight):
662 Rename cover_string to disp_string.
663
664 2011-11-01 Martin Rudalics <rudalics@gmx.at>
665
666 * window.c (temp_output_buffer_show): Don't use
667 Vtemp_buffer_show_specifiers.
668 (Vtemp_buffer_show_specifiers): Remove unused variable.
669
670 2011-10-30 Eli Zaretskii <eliz@gnu.org>
671
672 * xdisp.c (try_cursor_movement): Make sure ROW isn't decremented
673 past the beginning of the current glyph matrix.
674
675 2011-10-30 Adam Sjøgren <asjo@koldfront.dk> (tiny change)
676
677 * xterm.c: Include X11/Xproto.h if HAVE_GTK3.
678 (x_error_handler): Ignore BadMatch for X_SetInputFocus for
679 HAVE_GTK3 (Bug#9869).
680
681 * gtkutil.c (xg_win_to_widget, xg_event_is_for_menubar): Initialize
682 type to GDK_NOTHING so valgrind does not complain (Bug#9901).
683
684 * xterm.h (x_display_info): Add Xatom_net_wm_state_hidden (Bug#9893).
685
686 * xterm.c: Declare x_handle_net_wm_state to return int.
687 (handle_one_xevent): Check if we are iconified but don't have
688 _NET_WM_STATE_HIDDEN. If do, treat as deiconify (Bug#9893).
689 (get_current_wm_state): Return non-zero if not hidden,
690 check for _NET_WM_STATE_HIDDEN (Bug#9893).
691 (do_ewmh_fullscreen): Ignore return value from get_current_wm_state.
692 (x_handle_net_wm_state): Return what get_current_wm_state returns.
693 (x_term_init): Initialize dpyinfo->Xatom_net_wm_state_hidden.
694
695 2011-10-29 Paul Eggert <eggert@cs.ucla.edu>
696
697 * alloc.c (which_symbols): Declare EXTERNALLY_VISIBLE,
698 so that this new function doesn't get optimized away by a
699 whole-program optimizer. Make the 2nd arg EMACS_INT, not int.
700
701 2011-10-29 Andreas Schwab <schwab@linux-m68k.org>
702
703 * frame.h (MOUSE_HL_INFO): Remove excess parens.
704
705 2011-10-29 Eli Zaretskii <eliz@gnu.org>
706
707 Fix the `xbytecode' command.
708 * .gdbinit (xprintbytestr): New command.
709 (xwhichsymbols): Rename from `which'; all callers changed.
710 (xbytecode): Print the byte-code string as well.
711
712 2011-10-29 Kim Storm <storm@cua.dk>
713
714 * alloc.c (which_symbols): New function.
715
716 2011-10-29 Andreas Schwab <schwab@linux-m68k.org>
717
718 * minibuf.c (read_minibuf_noninteractive): Allow reading empty
719 line. (Bug#9903)
720
721 2011-10-29 Glenn Morris <rgm@gnu.org>
722
723 * process.c (wait_reading_process_output): Revert 2009-08-30 change.
724 Not clear what it was for, and it causes various bugs. (Bug#9839)
725
726 2011-10-28 Eli Zaretskii <eliz@gnu.org>
727
728 * xdisp.c (note_mouse_highlight): Initialize `part', to avoid a
729 possible random value that matches one of those tested as
730 condition to clear the mouse face.
731
732 2011-10-28 Chong Yidong <cyd@gnu.org>
733
734 * xdisp.c (note_mouse_highlight): Fix use of uninitialized var.
735
736 2011-10-28 Dan Nicolaescu <dann@ics.uci.edu>
737
738 * window.c (make_window): Initialize phys_cursor_on_p.
739
740 2011-10-28 Stefan Monnier <monnier@iro.umontreal.ca>
741
742 * lisp.h (struct Lisp_Symbol): Update comments.
743
744 2011-10-28 Juanma Barranquero <lekktu@gmail.com>
745
746 * w32font.c (w32_load_unicows_or_gdi32): Add missing return.
747
748 2011-10-28 Eli Zaretskii <eliz@gnu.org>
749
750 Fix Emacs on Windows 9X (bug#8562). Thanks to oslsachem
751 <oslsachem@gmail.com> for helping to debug this.
752
753 * w32font.c (g_b_init_is_w9x, g_b_init_get_outline_metrics_w)
754 (g_b_init_get_text_metrics_w, g_b_init_get_glyph_outline_w)
755 (g_b_init_get_glyph_outline_w): New static variables.
756 (GetOutlineTextMetricsW_Proc, GetTextMetricsW_Proc)
757 (GetGlyphOutlineW_Proc): New typedefs.
758 (w32_load_unicows_or_gdi32, get_outline_metrics_w)
759 (get_text_metrics_w, get_glyph_outline_w, globals_of_w32font):
760 New functions.
761 (w32font_open_internal, compute_metrics):
762 Call get_outline_metrics_w, get_text_metrics_w, and get_glyph_outline_w
763 instead of calling the "wide" APIs directly.
764
765 * emacs.c (main) [HAVE_NTGUI]: Call globals_of_w32font.
766
767 * w32.h (syms_of_w32font): Add prototype.
768
769 2011-10-27 Juanma Barranquero <lekktu@gmail.com>
770
771 * window.c (Fframe_root_window, Fframe_first_window, Fwindow_end)
772 (Fframe_selected_window, Ftemp_output_buffer_show, Fnext_window)
773 (Fdelete_window_internal, Fwindow_parameters): Fix typos in docstrings.
774 (Fmove_to_window_line): Doc fix.
775
776 2011-10-27 Chong Yidong <cyd@gnu.org>
777
778 * process.c (make_process): Set gnutls_state to NULL.
779
780 * gnutls.c (emacs_gnutls_deinit): Deinit the gnutls_state if it is
781 non-NULL, regardless of GNUTLS_INITSTAGE.
782 (Fgnutls_boot): Cleanups. Call emacs_gnutls_deinit if we signal
783 an error. Set process slots as soon as we allocate them.
784
785 * gnutls.h (GNUTLS_LOG, GNUTLS_LOG2): Fix macros.
786
787 2011-10-27 Chong Yidong <cyd@gnu.org>
788
789 * gnutls.c (emacs_gnutls_deinit): New function.
790 Deallocate credentials structures as well as calling gnutls_deinit.
791 (Fgnutls_deinit, Fgnutls_boot): Use it.
792
793 * process.c (make_process): Initialize GnuTLS credentials to NULL.
794 (deactivate_process): Call emacs_gnutls_deinit.
795
796 2011-10-27 Juanma Barranquero <lekktu@gmail.com>
797
798 * image.c (x_create_x_image_and_pixmap):
799 * w32.c (sys_rename, w32_delayed_load):
800 * w32font.c (fill_in_logfont):
801 * w32reg.c (x_get_string_resource): Silence compiler warnings.
802
803 2011-10-26 Juanma Barranquero <lekktu@gmail.com>
804
805 * w32fns.c (w32_default_color_map): New function,
806 extracted from Fw32_default_color_map.
807 (Fw32_default_color_map, Fx_open_connection): Use it. (Bug#9785)
808
809 2011-10-25 Paul Eggert <eggert@cs.ucla.edu>
810
811 * dispextern.h (Fcontrolling_tty_p): New decl (Bug#6649 part 2).
812
813 2011-10-25 Stefan Monnier <monnier@iro.umontreal.ca>
814
815 * keyboard.c (test_undefined): New function (bug#9751).
816 (read_key_sequence): Use it to detect when a key is bound to `undefined'.
817
818 2011-10-25 Enami Tsugutomo <tsugutomo.enami@jp.sony.com>
819
820 * sysdep.c (init_sys_modes): Fix the check for the controlling
821 terminal (Bug#6649).
822
823 2011-10-20 Eli Zaretskii <eliz@gnu.org>
824
825 * dispextern.h (struct bidi_it): New member next_en_type.
826
827 * bidi.c (bidi_line_init): Initialize the next_en_type member.
828 (bidi_resolve_explicit_1): When next_en_pos is valid for the
829 current character, check also for next_en_type being WEAK_EN.
830 (bidi_resolve_weak): Don't enter the expensive loop if the current
831 position is before next_en_pos. Record the bidi type of the first
832 non-ET, non-BN character we find, in addition to its position.
833 (bidi_level_of_next_char): Invalidate next_en_type when
834 next_en_pos is over-stepped.
835
836 2011-10-20 Paul Eggert <eggert@cs.ucla.edu>
837
838 Time zone name fixes for non-ASCII locales (Bug#641, Bug#9794)
839 * editfns.c: Rewrite current-time-zone so that it invokes
840 the equivalent of (format-time-string "%Z") to get the time zone name.
841 This fixes a bug when the time zone name contains characters that
842 need converting from the system time locale to Emacs internal format.
843 This fixes a shortcoming that I introduced in my 1999-10-19 patch:
844 that patch fixed format-time-string to do the conversion, but
845 I forgot to fix current-time-zone.
846 (format_time_string): New function, containing most of
847 what Fformat_time_string used to contain.
848 (Fformat_time_string): Rewrite in terms of format_time_string.
849 This doesn't change this function's behavior.
850 (current-time-zone): Rewrite to use format_time_string.
851 This fixes the bug reported by Michael Schierl in
852 <http://lists.gnu.org/archive/html/emacs-devel/2007-06/msg00334.html>.
853 Jason Rumney's 2007-06-07 change worked around this bug, but
854 didn't fix it.
855 * systime.h (tzname, timezone): Remove no-longer-used declarations.
856
857 2011-10-19 Eli Zaretskii <eliz@gnu.org>
858
859 * xdisp.c (start_display): If the character at POS is displayed
860 via a display vector, reset IT->current.dpvec_index to zero.
861 (try_window_reusing_current_matrix): If a line ends in a display
862 vector or the next line starts in a display vector, continue
863 redrawing the window even though the character position of
864 start_row was reached.
865 (Bug#9771, part 2)
866
867 2011-10-18 Chong Yidong <cyd@gnu.org>
868
869 * xdisp.c (get_next_display_element): Handle U+2010 and U+2011
870 with nobreak-char-display too.
871
872 2011-10-18 Eli Zaretskii <eliz@gnu.org>
873
874 Fix part 3 of bug#9771.
875 * bidi.c (bidi_line_init): Initialize next_en_pos to zero, not -1.
876 (bidi_resolve_neutral): Don't enter the expensive loop looking for
877 non-neutral characters if the current character is a paragraph
878 separator (a.k.a. Newline). This avoids running the same
879 expensive loop twice, once when we consume the preceding newline
880 and the other time when the line actually needs to be displayed.
881 Avoid the loop when we see neutrals on the base embedding level
882 following a character whose directionality is the same as the
883 paragraph's. This avoids running the expensive loop when a line
884 ends in a long sequence of neutrals, like control characters.
885 Add assertion against STRONG_AL type. Slightly rearrange code
886 that determines the type of a neutral given the first non-neutral
887 that follows it.
888 (bidi_level_of_next_char): Set next_en_pos to zero when
889 invalidating its info.
890
891 2011-10-17 Eli Zaretskii <eliz@gnu.org>
892
893 * xdisp.c (push_display_prop): Determine whether to record string
894 or buffer position by IT->string, not by IT->method. Allow
895 GET_FROM_DISPLAY_VECTOR as IT->method on entry. (Bug#9771, part 4)
896 (move_it_vertically_backward): Don't look for character position
897 immediately after the newline when in a continuation line.
898 (Bug#9771, part 1)
899
900 2011-10-15 Martin Rudalics <rudalics@gmx.at>
901
902 * window.c (coordinates_in_window): Rewrite and delabelize
903 vertical border check. (Bug#5357) (Bug#9618)
904
905 2011-10-14 Stefan Monnier <monnier@iro.umontreal.ca>
906
907 * xterm.c (frame_highlight, frame_unhighlight): Ignore unexplained
908 errors in XSetWindowBorder (bug#9310).
909
910 2011-10-13 Dmitry Antipov <dmantipov@yandex.ru>
911
912 * editfns.c (Fset_time_zone_rule): Replace free with xfree to
913 avoid crash when xmalloc overrun checking is enabled.
914
915 2011-10-13 Eli Zaretskii <eliz@gnu.org>
916
917 * xdisp.c (Fcurrent_bidi_paragraph_direction): Initialize
918 itb.paragraph_dir to NEUTRAL_DIR. Fixes an occasional incorrect
919 cursor motion with <left> and <right> arrow keys.
920
921 * bidi.c (bidi_init_it): Don't initialize paragraph_dir here, as
922 some callers set that themselves.
923
924 2011-10-12 Eli Zaretskii <eliz@gnu.org>
925
926 * xdisp.c (find_row_edges): Handle the case where ROW comes from a
927 display string and the previous row comes from the same string and
928 is empty. (Bug#9739) (Bug#9738)
929
930 2011-10-12 Stefan Monnier <monnier@iro.umontreal.ca>
931
932 * doc.c (get_doc_string): Encode file name (bug#9735).
933
934 2011-10-12 Eli Zaretskii <eliz@gnu.org>
935
936 * bidi.c (bidi_level_of_next_char):
937 * xdisp.c (get_visually_first_element): Remove old incorrect
938 comments regarding the Unicode Line Separator character.
939
940 * bidi.c (bidi_init_it): Initialize paragraph_dir to NEUTRAL_DIR.
941
942 2011-10-12 Dmitry Antipov <dmantipov@yandex.ru>
943
944 * alloc.c (Fgc_status): Do not access beyond zombies array
945 boundary if nzombies > MAX_ZOMBIES.
946 * alloc.c (dump_zombies): Add missing format specifier.
947
948 2011-10-12 Paul Eggert <eggert@cs.ucla.edu>
949
950 * xdisp.c (set_cursor_from_row): Simplify conditionals,
951 to pacify GCC 4.6.1 x86-64 with -O2 -Wstrict-overflow.
952
953 * lread.c (read_escape): Allow hex escapes as large as ?\xfffffff.
954 Some packages use them to denote characters with modifiers.
955
956 2011-10-11 Andreas Schwab <schwab@linux-m68k.org>
957
958 * lisp.h (GCPRO1_VAR, GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR)
959 (GCPRO5_VAR, GCPRO6_VAR, UNGCPRO_VAR): Add whitespace to avoid
960 matching a pp-number. Rename parameter var to var1.
961
962 2011-10-11 Stefan Monnier <monnier@iro.umontreal.ca>
963
964 * minibuf.c (Finternal_complete_buffer): Fix last change (bug#9709).
965
966 2011-10-08 Glenn Morris <rgm@gnu.org>
967
968 * callint.c (Fcall_interactively): Give a more explicit error for the
969 'c' case with a non-character input. (Bug#8479)
970
971 2011-10-08 Eli Zaretskii <eliz@gnu.org>
972
973 * xdisp.c (hscroll_window_tree): Support hscroll in right-to-left
974 lines.
975 (set_cursor_from_row): Fix cursor positioning in mixed L2R+R2L
976 lines that are hscrolled on the left.
977
978 * dispnew.c (buffer_posn_from_coords): Account for a possible
979 presence of header-line. (Bug#4426)
980
981 2011-10-07 Stefan Monnier <monnier@iro.umontreal.ca>
982
983 * buffer.c (syms_of_buffer) <enable-multibyte-characters>:
984 Don't advertise functionality which we discourage or doesn't work.
985
986 2011-10-07 Paul Eggert <eggert@cs.ucla.edu>
987
988 * alloc.c (GC_LISP_OBJECT_ALIGNMENT): Use offsetof, not __alignof__
989 or sizeof. __alignof__ gives the wrong answer on Fedora x86-64
990 with GCC 4.6.1 when configured with CC='gcc -m32' --with-wide-int;
991 this makes Emacs dump core during garbage collection on rare
992 occasions. sizeof is obviously inferior to offsetof here, so
993 stick with offsetof.
994 (GC_POINTER_ALIGNMENT): New macro.
995 (mark_memory): Omit 3rd (offset) arg; caller changed.
996 Don't assume EMACS_INT alignment is the same as pointer alignment.
997
998 2011-10-03 Stefan Monnier <monnier@iro.umontreal.ca>
999
1000 * keyboard.c (read_key_sequence_remapped): New var.
1001 (read_key_sequence): Compute remapping in the right buffer.
1002 (command_loop_1): Use read_key_sequence's remapping directly.
1003
1004 2011-10-02 Stefan Monnier <monnier@iro.umontreal.ca>
1005
1006 * dired.c (file_name_completion): Don't expand file name.
1007 (Ffile_name_completion, Ffile_name_all_completions): Expand file name
1008 before checking file name handler.
1009
1010 * minibuf.c (Finternal_complete_buffer): Only show internal buffers if
1011 they've been requested explicitly (bug#9591).
1012
1013 2011-10-01 Andreas Schwab <schwab@linux-m68k.org>
1014
1015 * keymap.c (Fsingle_key_description): Use make_specified_string
1016 instead of build_string to build string from push_key_description.
1017 (Bug#5193)
1018
1019 2011-09-30 Paul Eggert <eggert@cs.ucla.edu>
1020
1021 * buffer.h (struct buffer): Use time_t, not int, for a time stamp.
1022 This fixes a Y2038 bug on 64-bit hosts.
1023 * buffer.c (reset_buffer):
1024 * fileio.c (Fdo_auto_save, Fset_buffer_auto_saved)
1025 (Fclear_buffer_auto_save_failure):
1026 Use 0, not -1, to represent an unset failure time, since time_t
1027 might not be signed.
1028
1029 Remove dependency on glibc malloc internals.
1030 * alloc.c (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
1031 Move back here from lisp.h, but with their new implementations.
1032 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
1033 (XMALLOC_OVERRUN_SIZE_SIZE): Move these new lisp.h macros here.
1034 * charset.c (charset_table_init): New static var.
1035 (syms_of_charset): Use it instead of xmalloc. This removes a
1036 dependency on glibc malloc internals. See Eli Zaretskii's comment in
1037 <http://lists.gnu.org/archive/html/emacs-devel/2011-09/msg00815.html>.
1038 * lisp.h (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
1039 Move back to alloc.c.
1040 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
1041 (XMALLOC_OVERRUN_SIZE_SIZE): Move to alloc.c.
1042
1043 2011-09-30 Jan Djärv <jan.h.d@swipnet.se>
1044
1045 * nsterm.m (windowDidResize): Call x_set_window_size only when
1046 ns_in_resize is true. Otherwise set pixelwidth/height and
1047 call change_frame_size (Bug#9628).
1048
1049 2011-09-30 Paul Eggert <eggert@cs.ucla.edu>
1050
1051 Port --enable-checking=all to Fedora 14 x86-64.
1052 * charset.c (syms_of_charset): Also account for glibc malloc's
1053 internal overhead when calculating the initial malloc maximum.
1054
1055 Port --enable-checking=all to Fedora 14 x86.
1056 * alloc.c (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
1057 Move to lisp.h.
1058 (xmalloc_put_size, xmalloc_get_size, overrun_check_malloc)
1059 (overrun_check_realloc, overrun_check_free):
1060 Use XMALLOC_OVERRUN_SIZE_SIZE, not sizeof (size_t).
1061 That way, xmalloc returns a properly-aligned pointer even if
1062 XMALLOC_OVERRUN_CHECK is defined. The old debugging code happened
1063 to align OK on typical 64-bit hosts, but not on Fedora 14 x86.
1064 * charset.c (syms_of_charset): Take XMALLOC_OVERRUN_CHECK_OVERHEAD
1065 into account when calculating the initial malloc maximum.
1066 * lisp.h (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
1067 Move here from alloc.c, so that charset.c can use it too.
1068 Properly align; the old code wasn't right for common 32-bit hosts
1069 when configured with --enable-checking=all.
1070 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
1071 (XMALLOC_OVERRUN_SIZE_SIZE): New macros.
1072
1073 2011-09-29 Eli Zaretskii <eliz@gnu.org>
1074
1075 * sysdep.c (snprintf) [!EOVERFLOW]: If EOVERFLOW is not defined,
1076 use EDOM.
1077
1078 2011-09-28 Eli Zaretskii <eliz@gnu.org>
1079
1080 * xdisp.c (compute_display_string_end): If there's no display
1081 string at CHARPOS, return -1.
1082
1083 * bidi.c (bidi_fetch_char): When compute_display_string_end
1084 returns a negative value, treat the character as a normal
1085 character not covered by a display string. (Bug#9624)
1086
1087 2011-09-28 Juanma Barranquero <lekktu@gmail.com>
1088
1089 * lread.c (Fread_from_string): Fix typo in docstring.
1090
1091 2011-09-27 Eli Zaretskii <eliz@gnu.org>
1092
1093 * xdisp.c (handle_invisible_prop): If invisible text ends on a
1094 newline, reseat the iterator instead of bidi-iterating there one
1095 character at a time. (Bug#9610)
1096 (BUFFER_POS_REACHED_P, move_it_in_display_line_to): Bail when past
1097 TO_CHARPOS if the bidi iterator is at base embedding level.
1098
1099 2011-09-27 Andreas Schwab <schwab@linux-m68k.org>
1100
1101 * lread.c (readevalloop): Use correct code for NBSP.
1102 (read1): Likewise. (Bug#9608)
1103
1104 2011-09-25 Michael Albinus <michael.albinus@gmx.de>
1105
1106 * dbusbind.c (Fdbus_register_signal): When service is not
1107 registered, use nil in Vdbus_registered_objects_table. (Bug#9581)
1108
1109 2011-09-25 Glenn Morris <rgm@gnu.org>
1110
1111 * buffer.c (truncate-lines): Doc fix.
1112
1113 2011-09-24 Chong Yidong <cyd@stupidchicken.com>
1114
1115 * window.c (Fwindow_prev_buffers, Fset_window_prev_buffers)
1116 (Fset_window_next_buffers): Doc fix.
1117
1118 2011-09-24 Glenn Morris <rgm@gnu.org>
1119
1120 * minibuf.c (read_minibuf): Disable line truncation. (Bug#5715)
1121
1122 2011-09-24 Paul Eggert <eggert@cs.ucla.edu>
1123
1124 Fix minor problems found by static checking.
1125 * xdisp.c (string_from_display_spec): Don't assume vecsize fits in int.
1126 * indent.c (Fvertical_motion): Fix == vs = typo.
1127
1128 2011-09-24 Eli Zaretskii <eliz@gnu.org>
1129
1130 * dispnew.c (syms_of_display) <redisplay-dont-pause>:
1131 Default value is now t. Doc fix.
1132
1133 * indent.c (Fvertical_motion): Compute and apply the overshoot
1134 logic when moving up, not only when moving down. Fix the
1135 confusing name and values of the it_overshoot_expected variable;
1136 logic changes accordingly. (Bug#9254) (Bug#9549)
1137
1138 * xdisp.c (pos_visible_p): Produce correct pixel coordinates when
1139 CHARPOS is covered by a display string which includes newlines.
1140 (move_it_vertically_backward): Avoid inflooping when START_CHARPOS
1141 is covered by a display string with embedded newlines.
1142
1143 2011-09-24 Michael Albinus <michael.albinus@gmx.de>
1144
1145 * dbusbind.c (Fdbus_register_signal): Add match rule to
1146 Vdbus_registered_objects_table. (Bug#9581)
1147 (Fdbus_register_method, Vdbus_registered_objects_table):
1148 Fix docstring.
1149
1150 2011-09-24 Jim Meyering <meyering@redhat.com>
1151
1152 do not ignore write error for any output size
1153 The previous change was incomplete.
1154 While it makes emacs --batch detect the vast majority of stdout
1155 write failures, errors were still ignored whenever the output size is
1156 k * (BUFSIZ+1) - 4. E.g., on a system with BUFSIZ of 4096,
1157 $ emacs --batch --eval '(print (format "%4093d" 0))' > /dev/full \
1158 && echo FAIL: ignored write error
1159 FAIL: ignored write error
1160 $ emacs --batch --eval '(print (format "%20481d" 0))' > /dev/full \
1161 && echo FAIL: ignored write error
1162 FAIL: ignored write error
1163 * emacs.c (Fkill_emacs): Also test ferror. (Bug#9574)
1164
1165 2011-09-23 Andreas Schwab <schwab@linux-m68k.org>
1166
1167 * emacs.c (Fkill_emacs): In noninteractive mode exit
1168 non-successfully if a write error occurred on stdout. (Bug#9574)
1169
1170 2011-09-21 Eli Zaretskii <eliz@gnu.org>
1171
1172 * xdisp.c (pop_it): Allow it->object that is a cons cell to pass
1173 the xassert test.
1174
1175 * dispextern.h (struct it): Update the comment documenting what
1176 can it->OBJECT be.
1177
1178 2011-09-20 Eli Zaretskii <eliz@gnu.org>
1179
1180 * xdisp.c (set_cursor_from_row): If the row ends in a newline from
1181 a display string, extend search for cursor position to end of row.
1182 (find_row_edges): If the row ends in a newline from a display
1183 string, increment its MATRIX_ROW_END_CHARPOS by one. (Bug#9549)
1184 Handle the case of a display string with multiple newlines.
1185 (Fcurrent_bidi_paragraph_direction): Fix search for previous
1186 non-empty line. Fixes confusing cursor motion with arrow keys at
1187 the beginning of a line that starts with whitespace.
1188
1189 2011-09-19 Lars Magne Ingebrigtsen <larsi@gnus.org>
1190
1191 * lread.c (Fread_from_string): Document what FINAL-STRING-INDEX is
1192 (bug#9493).
1193
1194 2011-09-18 Chong Yidong <cyd@stupidchicken.com>
1195
1196 * xfns.c (Fx_create_frame): Handle the bitmapIcon resource as
1197 boolean (Bug#9154).
1198
1199 2011-09-18 Eli Zaretskii <eliz@gnu.org>
1200
1201 * xdisp.c (display_line): Record maximum and minimum buffer
1202 positions even if no glyphs were produced (e.g., by a zero-width
1203 stretch). Fixes bug#9530 on a TTY. Under word-wrap, don't record
1204 buffer positions that will be removed from the glyph row because
1205 they don't fit.
1206 (produce_stretch_glyph): Fix a bug in :align-to on a TTY when the
1207 column is beyond frame width: don't subtract 1 "pixel" when
1208 computing width of the stretch.
1209 (reseat_at_next_visible_line_start): Undo the change made on
1210 2011-09-17 that saved paragraph information and restored it after
1211 the call to `reseat'. (Bug#9545)
1212
1213 2011-09-18 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
1214
1215 * xdisp.c (expose_window): Save original value of phys_cursor_on_p
1216 and turn window cursor on if cleared (Bug#9415).
1217
1218 2011-09-18 Andreas Schwab <schwab@linux-m68k.org>
1219
1220 * search.c (boyer_moore): Take unibyte characters from pattern
1221 literally. (Bug#9458)
1222
1223 2011-09-18 Eli Zaretskii <eliz@gnu.org>
1224
1225 * xdisp.c (reseat_at_next_visible_line_start): Fix last change.
1226
1227 2011-09-18 Paul Eggert <eggert@cs.ucla.edu>
1228
1229 Fix minor problem found by static checking.
1230 * xdisp.c (reseat_at_next_visible_line_start): Mark locals as
1231 initialized, to pacify gcc -Wuninitialized.
1232
1233 * fileio.c: Report proper errno when syscall falls.
1234 (Finsert_file_contents): Save and restore errno,
1235 so that report_file_error outputs the correct diagnostic.
1236 (Fwrite_region) [CLASH_DETECTION]: Likewise.
1237
1238 2011-09-18 Eli Zaretskii <eliz@gnu.org>
1239
1240 * .gdbinit (pgx): Fix references to fields of `struct glyph'.
1241
1242 2011-09-17 Eli Zaretskii <eliz@gnu.org>
1243
1244 * xdisp.c (produce_stretch_glyph): Another fix for changes made on
1245 2011-08-30T17:32:44Z!eliz@gnu.org. (Bug#9530)
1246
1247 2011-09-17 Eli Zaretskii <eliz@gnu.org>
1248
1249 * xdisp.c (reseat_at_next_visible_line_start): Keep information
1250 about the current paragraph and restore it after the call to reseat.
1251
1252 * bidi.c (MAX_PARAGRAPH_SEARCH): New macro.
1253 (bidi_find_paragraph_start): Search back for paragraph beginning
1254 at most MAX_PARAGRAPH_SEARCH lines; if not found, return BEGV_BYTE.
1255 (bidi_move_to_visually_next): Only trigger paragraph-related
1256 computations when the last character is a newline or at EOB, not
1257 just any NEUTRAL_B. (Bug#9470)
1258
1259 * xdisp.c (set_cursor_from_row): Don't invoke special treatment of
1260 truncated lines if point is covered by a display string. (Bug#9524)
1261
1262 2011-09-16 Paul Eggert <eggert@cs.ucla.edu>
1263
1264 * xselect.c: Relax test for outgoing X longs (Bug#9498).
1265 (cons_to_x_long): New function.
1266 (lisp_data_to_selection_data): Use it. Correct the test for
1267 short-versus-long data; it was negated. Break out of vector
1268 loop, for efficiency, when a long datum is discovered.
1269
1270 2011-09-16 Stefan Monnier <monnier@iro.umontreal.ca>
1271
1272 * eval.c (Fquote): Document its non-consing behavior (bug#9482).
1273
1274 2011-09-16 Eli Zaretskii <eliz@gnu.org>
1275
1276 * image.c (tiff_handler): Work around a bug in MinGW GCC 3.x (see
1277 GCC PR/17406) by declaring this function with external scope.
1278
1279 2011-09-15 Paul Eggert <eggert@cs.ucla.edu>
1280
1281 * editfns.c (Fformat): Fix bug in text-property fix (Bug#9514).
1282 Don't mishandle (length (format "%%")) and (format "%4000s%%" "").
1283
1284 2011-09-15 Andreas Schwab <schwab@linux-m68k.org>
1285
1286 * editfns.c (Fformat): Correctly handle text properties on "%%".
1287
1288 2011-09-15 Eli Zaretskii <eliz@gnu.org>
1289
1290 * xterm.c (x_draw_composite_glyph_string_foreground):
1291 * w32term.c (x_draw_composite_glyph_string_foreground):
1292 * term.c (encode_terminal_code):
1293 * composite.c (composition_update_it, get_composition_id):
1294 * xdisp.c (get_next_display_element)
1295 (fill_composite_glyph_string): Add comments about special meaning
1296 of TAB characters in a composition.
1297
1298 2011-09-15 Paul Eggert <eggert@cs.ucla.edu>
1299
1300 * editfns.c (Fformat): Fix off-by-1 bug for "%%b" (Bug#9514).
1301 This occurs when processing a multibyte format.
1302 Problem reported by Wolfgang Jenker.
1303
1304 2011-09-15 Johan Bockgård <bojohan@gnu.org>
1305
1306 * xdisp.c (try_cursor_movement): Only check for exact match if
1307 cursor hpos found by set_cursor_from_row is valid. (Bug#9495)
1308
1309 2011-09-14 Paul Eggert <eggert@cs.ucla.edu>
1310
1311 Remove unused external symbols.
1312 * dispextern.h (calc_pixel_width_or_height): Remove decl.
1313 * xdisp.c (calc_pixel_width_or_height): Now static.
1314 * doprnt.c (exprintf) [! (HAVE_X_WINDOWS && USE_X_TOOLKIT)]: Remove.
1315 * indent.c (check_display_width):
1316 * w32term.c: Fix comment to match code.
1317 * xterm.c, xterm.h (x_catching_errors): Remove.
1318
1319 2011-09-14 Paul Eggert <eggert@cs.ucla.edu>
1320
1321 * xselect.c: Use signed conversions more consistently (Bug#9498).
1322 (selection_data_to_lisp_data): Assume incoming selection data are
1323 signed integers, not unsigned. This is to be consistent with
1324 outgoing selection data, which was modified to use signed integers
1325 in as part of the fix to Bug#9196 in response to Jan D.'s comment
1326 in <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9196#32> that X11
1327 expects long, not unsigned long.
1328
1329 2011-09-14 Eli Zaretskii <eliz@gnu.org>
1330
1331 * xdisp.c (try_window_reusing_current_matrix): Fix incorrect
1332 computation of loop end. Reported by Johan Bockgård
1333 <bojohan@gnu.org>.
1334
1335 2011-09-13 Chong Yidong <cyd@stupidchicken.com>
1336
1337 * frame.c (Fother_visible_frames_p): Function deleted.
1338
1339 2011-09-12 Eli Zaretskii <eliz@gnu.org>
1340
1341 * indent.c (compute_motion): Process display vector front to back
1342 rather than the other way around. (Bug#2496)
1343
1344 2011-09-12 Stefan Monnier <monnier@iro.umontreal.ca>
1345
1346 * fileio.c (Finsert_file_contents): Don't assume beg_offset is 0.
1347
1348 2011-09-11 Chong Yidong <cyd@stupidchicken.com>
1349
1350 * minibuf.c (Fread_from_minibuffer): Doc fix.
1351
1352 2011-09-11 Eli Zaretskii <eliz@gnu.org>
1353
1354 * xdisp.c (produce_stretch_glyph): Fix a typo made in changes from
1355 2011-08-30T17:32:44Z!eliz@gnu.org. (Bug#9475)
1356
1357 2011-09-11 Lars Magne Ingebrigtsen <larsi@gnus.org>
1358
1359 * fileio.c (Fvisited_file_modtime): Document `(-1 65535)' as a
1360 value for non-existent files.
1361
1362 2011-09-11 Eli Zaretskii <eliz@gnu.org>
1363
1364 * fileio.c (Finsert_file_contents): If the file cannot be opened,
1365 set its "size" to -1. This will set the modtime_size field of
1366 the corresponding buffer to -1, which is what
1367 verify-visited-file-modtime expects for files that do not exist.
1368 (Bug#9139)
1369
1370 2011-09-11 Paul Eggert <eggert@cs.ucla.edu>
1371
1372 * keymap.h (KEY_DESCRIPTION_SIZE, push_key_description): Move decls
1373 here ...
1374 * lisp.h: ... from here. push_key_description is no longer
1375 defined in keyboard.c, so its declaration should not be in
1376 lisp.h's "Defined in keyboard.c" section, and KEY_DESCRIPTION_SIZE
1377 logically belongs with push_key_description.
1378
1379 2011-09-10 Paul Eggert <eggert@cs.ucla.edu>
1380
1381 * buffer.h: Include <sys/types.h> instead of <time.h>.
1382 Otherwise, off_t wasn't defined on FreeBSD 9.0-BETA2 i386.
1383 Problem reported by Herbert J. Skuhra.
1384
1385 2011-09-10 Lars Magne Ingebrigtsen <larsi@gnus.org>
1386
1387 * xml.c (parse_region): Make the parsing work for
1388 non-comment-starting XML files again (bug#9144).
1389
1390 2011-09-10 Andreas Schwab <schwab@linux-m68k.org>
1391
1392 * image.c (gif_load): Fix calculation of bottom and right corner.
1393 (Bug#9468)
1394
1395 2011-09-10 Eli Zaretskii <eliz@gnu.org>
1396
1397 * xdisp.c (MAX_DISP_SCAN): Decrease to 250. Prevents sluggish
1398 redisplay in small windows.
1399
1400 2011-09-09 Eli Zaretskii <eliz@gnu.org>
1401
1402 * frame.c (x_report_frame_params): Cast to avoid compiler warnings.
1403
1404 2011-09-08 Martin Rudalics <rudalics@gmx.at>
1405
1406 * window.c (Fset_window_prev_buffers, Fset_window_next_buffers):
1407 Operate on live windows only.
1408
1409 2011-09-08 Juanma Barranquero <lekktu@gmail.com>
1410
1411 * emacs.c (my_heap_start): #ifdef to avoid warnings when unused.
1412
1413 2011-09-07 Eli Zaretskii <eliz@gnu.org>
1414
1415 * xdisp.c (move_it_in_display_line_to): Call RESTORE_IT on ppos_it
1416 only under bidi iteration.
1417
1418 2011-09-07 Jan Djärv <jan.h.d@swipnet.se>
1419
1420 * gtkutil.c (xg_make_tool_item): Insert comment about eventbox.
1421
1422 2011-09-06 Paul Eggert <eggert@cs.ucla.edu>
1423
1424 isnan: Fix porting problem to Solaris 10 with bundled gcc.
1425 Without this fix, the command to link temacs failed due to an
1426 undefined symbol __builtin_isnan. This is because
1427 /usr/include/iso/math_c99.h #defines isnan(x) to
1428 __builtin_isnan(x), but the bundled gcc, which identifies itself
1429 as gcc 3.4.3 (csl-sol210-3_4-branch+sol_rpath), does not have
1430 a __builtin_isnan.
1431 * floatfns.c (isnan): #undef, and then #define to a clone of
1432 what's in data.c.
1433 (Fisnan): Always define, since it's always available now.
1434 (syms_of_floatfns): Always define isnan at the Lisp level.
1435
1436 2011-09-06 Paul Eggert <eggert@cs.ucla.edu>
1437
1438 * Makefile.in (gl-stamp): move-if-change now in build-aux (Bug#9169).
1439
1440 2011-09-06 Paul Eggert <eggert@cs.ucla.edu>
1441
1442 * fileio.c: Fix bugs with large file offsets (Bug#9428).
1443 The previous code assumed that file offsets (off_t values) fit in
1444 EMACS_INT variables, which is not true on typical 32-bit hosts.
1445 The code messed up by falsely reporting buffer overflow in cases
1446 such as (insert-file-contents "big" nil 1 2) into an empty buffer
1447 when "big" contains more than 2**29 bytes, even though this
1448 inserts just one byte and does not overflow the buffer.
1449 (Finsert_file_contents): Store file offsets as off_t
1450 values, not as EMACS_INT values. Check for overflow when
1451 converting between EMACS_INT and off_t. When checking for
1452 buffer overflow or for overlap, take the offsets into account.
1453 Don't use EMACS_INT for small values where int suffices.
1454 When checking for overlap, fix a typo: ZV was used where
1455 ZV_BYTE was intended.
1456 (Fwrite_region): Don't assume off_t fits into 'long'.
1457 * buffer.h (struct buffer.modtime_size): Now off_t, not EMACS_INT.
1458
1459 2011-09-05 Michael Albinus <michael.albinus@gmx.de>
1460
1461 * dbusbind.c (xd_signature_cat): Rename from signature_cat.
1462
1463 2011-09-04 Paul Eggert <eggert@cs.ucla.edu>
1464
1465 sprintf-related integer and memory overflow issues (Bug#9412).
1466
1467 * doprnt.c (doprnt): Support printing ptrdiff_t and intmax_t values.
1468 (esprintf, exprintf, evxprintf): New functions.
1469 * keyboard.c (command_loop_level): Now EMACS_INT, not int.
1470 (cmd_error): Kbd macro iterations count is now EMACS_INT, not int.
1471 (modify_event_symbol): Do not assume that the length of
1472 name_alist_or_stem is safe to alloca and fits in int.
1473 (Fexecute_extended_command): Likewise for function name and binding.
1474 (Frecursion_depth): Wrap around reliably on integer overflow.
1475 * keymap.c (push_key_description): First arg is now EMACS_INT, not int,
1476 since some callers pass EMACS_INT values.
1477 (Fsingle_key_description): Don't crash if symbol name contains more
1478 than MAX_ALLOCA bytes.
1479 * minibuf.c (minibuf_level): Now EMACS_INT, not int.
1480 (get_minibuffer): Arg is now EMACS_INT, not int.
1481 * lisp.h (get_minibuffer, push_key_description): Reflect API changes.
1482 (esprintf, exprintf, evxprintf): New decls.
1483 * window.h (command_loop_level, minibuf_level): Reflect API changes.
1484
1485 * dbusbind.c (signature_cat): New function.
1486 (xd_signature, Fdbus_register_signal):
1487 Do not overrun buffer; instead, report string overflow.
1488
1489 * dispnew.c (add_window_display_history): Don't overrun buffer.
1490 Truncate instead; this is OK since it's just a log.
1491
1492 * editfns.c (Fcurrent_time_zone): Don't overrun buffer
1493 even if the time zone offset is outlandishly large.
1494 Don't mishandle offset == INT_MIN.
1495
1496 * emacs.c (main) [NS_IMPL_COCOA]: Don't overrun buffer
1497 when creating daemon; the previous buffer-overflow check was incorrect.
1498
1499 * eval.c (verror): Simplify by rewriting in terms of evxprintf,
1500 which has the guts of the old verror function.
1501
1502 * filelock.c (lock_file_1, lock_file): Don't blindly alloca long name;
1503 use SAFE_ALLOCA instead. Use esprintf to avoid int-overflow issues.
1504
1505 * font.c: Include <float.h>, for DBL_MAX_10_EXP.
1506 (font_unparse_xlfd): Don't blindly alloca long strings.
1507 Don't assume XINT result fits in int, or that XFLOAT_DATA * 10
1508 fits in int, when using sprintf. Use single snprintf to count
1509 length of string rather than counting it via multiple sprintfs;
1510 that's simpler and more reliable.
1511 (font_unparse_fcname): Use it to avoid sprintf buffer overrun.
1512 (generate_otf_features) [0 && HAVE_LIBOTF]: Use esprintf, not
1513 sprintf, in case result does not fit in int.
1514
1515 * fontset.c (num_auto_fontsets): Now printmax_t, not int.
1516 (fontset_from_font): Print it.
1517
1518 * frame.c (tty_frame_count): Now printmax_t, not int.
1519 (make_terminal_frame, set_term_frame_name): Print it.
1520 (x_report_frame_params): In X, window IDs are unsigned long,
1521 not signed long, so print them as unsigned.
1522 (validate_x_resource_name): Check for implausibly long names,
1523 and don't assume name length fits in 'int'.
1524 (x_get_resource_string): Don't blindly alloca invocation name;
1525 use SAFE_ALLOCA. Use esprintf, not sprintf, in case result does
1526 not fit in int.
1527
1528 * gtkutil.c: Include <float.h>, for DBL_MAX_10_EXP.
1529 (xg_check_special_colors, xg_set_geometry):
1530 Make sprintf buffers a bit bigger, to avoid potential buffer overrun.
1531
1532 * lread.c (dir_warning): Don't blindly alloca buffer; use SAFE_ALLOCA.
1533 Use esprintf, not sprintf, in case result does not fit in int.
1534
1535 * macros.c (executing_kbd_macro_iterations): Now EMACS_INT, not int.
1536 (Fend_kbd_macro): Don't mishandle MOST_NEGATIVE_FIXNUM by treating
1537 it as a large positive number.
1538 (Fexecute_kbd_macro): Don't assume repeat count fits in int.
1539 * macros.h (executing_kbd_macro_iterations): Now EMACS_INT, not int.
1540
1541 * nsterm.m ((NSSize)windowWillResize): Use esprintf, not sprintf,
1542 in case result does not fit in int.
1543
1544 * print.c (float_to_string): Detect width overflow more reliably.
1545 (print_object): Make sprintf buffer a bit bigger, to avoid potential
1546 buffer overrun. Don't assume list length fits in 'int'. Treat
1547 print length of 0 as 0, not as infinity; to be consistent with other
1548 uses of print length in this function. Don't overflow print length
1549 index. Don't assume hash table size fits in 'long', or that
1550 vectorlike size fits in 'unsigned long'.
1551
1552 * process.c (make_process): Use printmax_t, not int, to format
1553 process-name gensyms.
1554
1555 * sysdep.c (snprintf) [! HAVE_SNPRINTF]: New function.
1556
1557 * term.c (produce_glyphless_glyph): Make sprintf buffer a bit bigger
1558 to avoid potential buffer overrun.
1559
1560 * xfaces.c (x_update_menu_appearance): Don't overrun buffer
1561 if X resource line is longer than 512 bytes.
1562
1563 * xfns.c (x_window): Make sprintf buffer a bit bigger
1564 to avoid potential buffer overrun.
1565
1566 * xterm.c (x_io_error_quitter): Don't overrun sprintf buffer.
1567
1568 * xterm.h (x_check_errors): Add ATTRIBUTE_FORMAT_PRINTF.
1569
1570 2011-09-04 Paul Eggert <eggert@cs.ucla.edu>
1571
1572 Integer overflow fixes for scrolling, etc.
1573 Without these, Emacs silently mishandles large integers sometimes.
1574 For example, "C-u 4294967297 M-x recenter" was treated as if
1575 it were "C-u 1 M-x recenter" on a typical 64-bit host.
1576
1577 * xdisp.c (try_window_id): Check Emacs fixnum range before
1578 converting to 'int'.
1579
1580 * window.c (window_scroll_line_based, Frecenter):
1581 Check that an Emacs fixnum is in range before assigning it to 'int'.
1582 (Frecenter, Fmove_to_window_line): Use EMACS_INT, not int, for
1583 values converted from Emacs fixnums.
1584 (Frecenter): Don't wrap around a line count if it is out of 'int'
1585 range; instead, treat it as an extreme value.
1586 (Fset_window_configuration, compare_window_configurations):
1587 Use ptrdiff_t, not int, for index that might exceed 2 GiB.
1588
1589 * search.c (Freplace_match): Use ptrdiff_t, not int, for indexes
1590 that can exceed INT_MAX. Check that EMACS_INT value is in range
1591 before assigning it to the (possibly-narrower) index.
1592 (match_limit): Don't assume that a fixnum can fit in 'int'.
1593
1594 * print.c (print_object): Use ptrdiff_t, not int, for index that can
1595 exceed INT_MAX.
1596
1597 * indent.c (position_indentation): Now takes ptrdiff_t, not int.
1598 (Fvertical_motion): Don't wrap around LINES values that don't fit
1599 in 'int'. Instead, treat them as extreme values. This is good
1600 enough for windows, which can't have more than INT_MAX lines anyway.
1601
1602 2011-09-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
1603
1604 * Require libxml/parser.h to avoid compilation warning.
1605
1606 * emacs.c (shut_down_emacs): Call xmlCleanupParser on shutdown.
1607
1608 * xml.c (parse_region): Don't call xmlCleanupParser after parsing,
1609 since this reportedly can destroy thread storage.
1610
1611 2011-08-30 Chong Yidong <cyd@stupidchicken.com>
1612
1613 * syntax.c (find_defun_start): Update all cache variables if
1614 exiting early (Bug#9401).
1615
1616 2011-08-30 Eli Zaretskii <eliz@gnu.org>
1617
1618 * image.c (x_bitmap_pixmap): Cast to int to avoid compiler warnings.
1619
1620 * xdisp.c (produce_stretch_glyph): No longer static, compiled also
1621 when HAVE_WINDOW_SYSTEM is not defined. Support both GUI and TTY
1622 frames. Call tty_append_glyph in the TTY case. (Bug#9402)
1623
1624 * term.c (tty_append_glyph): New function.
1625 (produce_stretch_glyph): Static function and its prototype deleted.
1626
1627 * dispextern.h (produce_stretch_glyph, tty_append_glyph):
1628 Add prototypes.
1629
1630 2011-08-29 Paul Eggert <eggert@cs.ucla.edu>
1631
1632 * image.c (parse_image_spec): Check for nonnegative, not for positive,
1633 when checking :margin (Bug#9390).
1634 (IMAGE_NON_NEGATIVE_INTEGER_VALUE_OR_PAIR):
1635 Rename from IMAGE_POSITIVE_INTEGER_VALUE_OR_PAIR,
1636 so that the name doesn't mislead. All uses changed.
1637
1638 2011-08-28 Johan Bockgård <bojohan@gnu.org>
1639
1640 * term.c (init_tty) [HAVE_GPM]: Move mouse settings after
1641 set_tty_hooks.
1642
1643 2011-08-27 Eli Zaretskii <eliz@gnu.org>
1644
1645 * xdisp.c (move_it_to): Don't bail out early when reaching
1646 position beyond to_charpos, if we are scanning backwards.
1647 (move_it_vertically_backward): When DY == 0, make sure we get to
1648 the first character in the line after the newline.
1649
1650 2011-08-27 Paul Eggert <eggert@cs.ucla.edu>
1651
1652 * ccl.c: Improve and simplify overflow checking (Bug#9196).
1653 (ccl_driver): Do not generate an out-of-range pointer.
1654 (Fccl_execute_on_string): Remove unnecessary check for
1655 integer overflow, noted by Stefan Monnier in
1656 <http://lists.gnu.org/archive/html/emacs-devel/2011-08/msg00979.html>.
1657 Remove a FIXME that didn't need fixing.
1658 Simplify the newly-introduced buffer reallocation code.
1659
1660 2011-08-27 Juanma Barranquero <lekktu@gmail.com>
1661
1662 * makefile.w32-in ($(BLD)/alloc.$(O)): Depend on lib/verify.h.
1663
1664 2011-08-26 Paul Eggert <eggert@cs.ucla.edu>
1665
1666 Integer and memory overflow issues (Bug#9196).
1667
1668 * doc.c (get_doc_string): Rework so that
1669 get_doc_string_buffer_size is the actual buffer size, rather than
1670 being 1 less than the actual buffer size; this makes xpalloc more
1671 convenient.
1672
1673 * image.c (x_allocate_bitmap_record, cache_image):
1674 * xselect.c (Fx_register_dnd_atom):
1675 Simplify previous changes by using xpalloc.
1676
1677 * buffer.c (overlay_str_len): Now ptrdiff_t, not EMACS_INT,
1678 since either will do and ptrdiff_t is convenient with xpalloc.
1679
1680 * charset.c (charset_table_size)
1681 (struct charset_sort_data.priority): Now ptrdiff_t.
1682 (charset_compare): Don't overflow if priorities differ greatly.
1683 (Fsort_charsets): Don't assume list length fits in int.
1684 Check for size-calculation overflow when allocating sort data.
1685 (syms_of_charset): Allocate an initial charset table that is
1686 just under 64 KiB, to avoid problems with glibc malloc and mmap.
1687
1688 * cmds.c (internal_self_insert): Check for size-calculation overflow.
1689
1690 * composite.h (struct composition.glyph_len): Now int, not unsigned.
1691 The actual value is always <= INT_MAX, and leaving it unsigned made
1692 overflow checking harder.
1693
1694 * dispextern.h (struct glyph_matrix.rows_allocated)
1695 (struct face_cache.size): Now ptrdiff_t, for convenience in use
1696 with xpalloc. The values are still always <= INT_MAX.
1697
1698 * indent.c (compute_motion): Adjust to region_cache_forward sig change.
1699
1700 * lisp.h (xnmalloc, xnrealloc, xpalloc): New decls.
1701 (SAFE_NALLOCA): New macro.
1702
1703 * region-cache.c (struct boundary.pos, find_cache_boundary)
1704 (move_cache_gap, insert_cache_boundary, delete_cache_boundaries)
1705 (set_cache_region, invalidate_region_cache)
1706 (revalidate_region_cache, know_region_cache, region_cache_forward)
1707 (region_cache_backward, pp_cache):
1708 Use ptrdiff_t, not EMACS_INT, since either will do. This is needed
1709 so that ptrdiff_t * can be passed to xpalloc.
1710 (struct region_cache): Similarly, for gap_start, gap_len, cache_len,
1711 beg_unchanged, end_unchanged, buffer_beg, buffer_end members.
1712 (pp_cache): Don't assume cache_len fits in int.
1713 * region-cache.h: Adjust extern decls to match.
1714
1715 * search.c (scan_buffer, Freplace_match): Use ptrdiff_t, not
1716 EMACS_INT, since either will do, for xpalloc.
1717
1718 * alloc.c: Include verify.h, and check that int fits in ptrdiff_t.
1719 (xnmalloc, xnrealloc, xpalloc): New functions.
1720
1721 * bidi.c (bidi_shelve_header_size): New constant.
1722 (bidi_cache_ensure_space, bidi_shelve_cache): Use it.
1723 (bidi_cache_ensure_space): Avoid integer overflow when allocating.
1724
1725 * bidi.c (bidi_cache_shrink):
1726 * buffer.c (overlays_at, overlays_in, record_overlay_string)
1727 (overlay_strings):
1728 Don't update size of array until after memory allocation succeeds,
1729 because xmalloc/xrealloc may not return.
1730 (struct sortstrlist.bytes): Now ptrdiff_t, as EMACS_INT doesn't help
1731 now that we have proper integer overflow checking.
1732 (record_overlay_string, overlay_strings): Catch overflows when
1733 calculating size of overlay_str_buf.
1734
1735 * callproc.c (Fcall_process): Check for size overflow when
1736 calculating size of args2.
1737 (child_setup): Avoid overflow by using size_t rather than ptrdiff_t.
1738 Normally we prefer signed values, but sticking with ptrdiff_t would
1739 require adding more-complicated checks.
1740
1741 * ccl.c (Fccl_execute_on_string): Check for memory overflow.
1742 Use ptrdiff_t rather than EMACS_INT where ptrdiff_t will do.
1743 Redo buffer-overflow calculations to avoid integer overflow.
1744 Add a FIXME comment where memory seems to be over-allocated.
1745
1746 * character.c (Fstring): Check for size-calculation overflow.
1747
1748 * coding.c (produce_chars): Redo buffer-overflow calculations to avoid
1749 unnecessary integer overflow. Check for size overflow.
1750 (encode_coding_object): Don't update size until xmalloc succeeds.
1751
1752 * composite.c (get_composition_id): Check for overflow in glyph
1753 length calculations.
1754
1755 Integer and memory overflow fixes for display code.
1756 * dispextern.h (struct glyph_pool.nglyphs): Now ptrdiff_t, not int.
1757 * dispnew.c (adjust_glyph_matrix, realloc_glyph_pool)
1758 (scrolling_window): Check for overflow in size calculations.
1759 (line_draw_cost, realloc_glyph_pool, add_row_entry):
1760 Don't assume glyph table len fits in int.
1761 (struct row_entry.bucket, row_entry_pool_size, row_entry_idx)
1762 (row_table_size): Now ptrdiff_t, not int.
1763 (scrolling_window): Avoid overflow in size calculations.
1764 Don't update size until allocation succeeds.
1765 * fns.c (concat): Check for overflow in size calculations.
1766 (next_almost_prime): Verify NEXT_ALMOST_PRIME_LIMIT.
1767 * lisp.h (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): New macros.
1768 (NEXT_ALMOST_PRIME_LIMIT): New constant.
1769
1770 * doc.c (get_doc_string_buffer_size): Now ptrdiff_t, not int.
1771 (get_doc_string): Check for size calculation overflow.
1772 Don't update size until allocation succeeds.
1773 (get_doc_string, Fsubstitute_command_keys): Use ptrdiff_t, not
1774 EMACS_INT, where ptrdiff_t will do.
1775 (Fsubstitute_command_keys): Check for string overflow.
1776
1777 * editfns.c (set_time_zone_rule): Don't assume environment length
1778 fits in int.
1779 (message_length): Now ptrdiff_t, not int.
1780 (Fmessage_box): Don't update size until allocation succeeds.
1781 Don't assume message length fits in int.
1782 (Fformat): Use ptrdiff_t, not EMACS_INT, where ptrdiff_t will do.
1783
1784 * emacs.c (main): Do not reallocate argv, since there is a null at
1785 the end that can be overwritten, and this way there's no need to
1786 worry about size-calculation overflow.
1787 (sort_args): Check for size-calculation overflow.
1788
1789 * eval.c (init_eval_once, grow_specpdl): Don't update size until
1790 alloc succeeds.
1791 (call_debugger, grow_specpdl): Redo calculations to avoid overflow.
1792
1793 * frame.c (set_menu_bar_lines, x_set_frame_parameters)
1794 (x_set_scroll_bar_width, x_figure_window_size):
1795 Check for integer overflow.
1796 (x_set_alpha): Do not assume XINT fits in int.
1797
1798 * frame.h (struct frame): Use int, not EMACS_INT, where int works.
1799 This is for the members text_lines, text_cols, total_lines, total_cols,
1800 where the system imposes an 'int' limit.
1801
1802 * fringe.c (Fdefine_fringe_bitmap):
1803 Don't update size until alloc works.
1804
1805 * ftfont.c (ftfont_get_open_type_spec, setup_otf_gstring)
1806 (ftfont_shape_by_flt): Check for integer overflow in size calculations.
1807
1808 * gtkutil.c (get_utf8_string, xg_store_widget_in_map):
1809 Check for size-calculation overflow.
1810 (get_utf8_string): Use ptrdiff_t, not size_t, where either will
1811 do, as we prefer signed integers.
1812 (id_to_widget.max_size, id_to_widget.used)
1813 (xg_store_widget_in_map, xg_remove_widget_from_map)
1814 (xg_get_widget_from_map, xg_get_scroll_id_for_window)
1815 (xg_remove_scroll_bar, xg_update_scrollbar_pos):
1816 Use and return ptrdiff_t, not int.
1817 (xg_gtk_scroll_destroy): Don't assume ptrdiff_t fits in int.
1818 * gtkutil.h: Change prototypes to match the above.
1819
1820 * image.c (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): Remove; these
1821 are duplicate now that they've been promoted to lisp.h.
1822 (x_allocate_bitmap_record, x_alloc_image_color)
1823 (make_image_cache, cache_image, xpm_load):
1824 Don't update size until alloc is done.
1825 (xpm_load, lookup_rgb_color, lookup_pixel_color, x_to_xcolors)
1826 (x_detect_edges):
1827 Check for size calculation overflow.
1828 (ct_colors_allocated_max): New constant.
1829 (x_to_xcolors, x_detect_edges): Reorder multiplicands to avoid
1830 overflow.
1831
1832 * keyboard.c (read_char, menu_bar_items, tool_bar_items)
1833 (read_char_x_menu_prompt, read_char_minibuf_menu_width)
1834 (read_char_minibuf_menu_prompt, follow_key, read_key_sequence):
1835 Use ptrdiff_t, not int, to count maps.
1836 (read_char_minibuf_menu_prompt): Check for overflow in size
1837 calculations. Don't update size until allocation succeeds.
1838 Redo calculations to avoid overflow.
1839 * keyboard.h: Change prototypes to match the above.
1840
1841 * keymap.c (cmm_size, current_minor_maps): Use ptrdiff_t, not int,
1842 to count maps.
1843 (current_minor_maps): Check for size calculation overflow.
1844 * keymap.h: Change prototypes to match the above.
1845
1846 * lread.c (read1, init_obarray): Don't update size until alloc done.
1847
1848 * macros.c (Fstart_kbd_macro): Don't update size until alloc done.
1849 (store_kbd_macro_char): Reorder multiplicands to avoid overflow.
1850
1851 * nsterm.h (struct ns_color_table.size, struct ns_color_table.avail):
1852 Now ptrdiff_t, not int.
1853 * nsterm.m (ns_index_color): Use ptrdiff_t, not int, for table indexes.
1854 (ns_draw_fringe_bitmap): Rewrite to avoid overflow.
1855
1856 * process.c (Fnetwork_interface_list): Check for overflow
1857 in size calculation.
1858
1859 * region-cache.c (move_cache_gap): Check for size calculation overflow.
1860
1861 * scroll.c (do_line_insertion_deletion_costs): Check for size calc
1862 overflow. Don't bother calling xmalloc when xrealloc will do.
1863
1864 * search.c (Freplace_match): Check for size calculation overflow.
1865 (Fset_match_data): Don't assume list lengths fit in 'int'.
1866
1867 * sysdep.c (system_process_attributes): Use ptrdiff_t, not int,
1868 for command line length. Do not attempt to address one before the
1869 beginning of an array, as that's not portable.
1870
1871 * term.c (max_frame_lines): Remove; unused.
1872 (encode_terminal_src_size, encode_terminal_dst_size): Now ptrdiff_t,
1873 not int.
1874 (encode_terminal_code, calculate_costs): Check for size
1875 calculation overflow.
1876 (encode_terminal_code): Use ptrdiff_t, not int, to record glyph
1877 table lengths and related sizes. Don't update size until alloc
1878 done. Redo calculations to avoid overflow.
1879 (calculate_costs): Don't bother calling xmalloc when xrealloc will do.
1880
1881 * termcap.c (tgetent): Use ptrdiff_t, not int, to record results of
1882 subtracting pointers.
1883 (gobble_line): Check for overflow more carefully. Don't update size
1884 until alloc done.
1885
1886 * tparam.c (tparam1): Use ptrdiff_t, not int, for sizes.
1887 Don't update size until alloc done.
1888 Redo size calculations to avoid overflow.
1889 Check for size calculation overflow.
1890 (main) [DEBUG]: Fix typo in invoking tparam1.
1891
1892 * xdisp.c (store_mode_line_noprop_char, x_consider_frame_title):
1893 Use ptrdiff_t, not int, for sizes.
1894 (store_mode_line_noprop_char): Don't update size until alloc done.
1895
1896 * xfaces.c (lface_id_to_name_size, Finternal_make_lisp_face):
1897 Use ptrdiff_t, not int, for sizes.
1898 (Finternal_make_lisp_face, cache_face):
1899 Check for size calculation overflow.
1900 (cache_face): Treat size calculation overflows as if they were
1901 memory exhaustion (the usual treatment), rather than aborting.
1902
1903 * xfns.c (x_encode_text, x_set_name_internal)
1904 (Fx_change_window_property): Use ptrdiff_t, not int, to count
1905 sizes, since they can exceed INT_MAX in size. Check for size
1906 calculation overflow.
1907
1908 * xgselect.c (gfds_size): Now ptrdiff_t, for convenience with xpalloc.
1909 (xg_select): Check for size calculation overflow.
1910 Don't update size until alloc done.
1911
1912 * xrdb.c (get_environ_db): Don't assume path length fits in int,
1913 as sprintf is limited to int lengths.
1914
1915 * xselect.c (X_LONG_SIZE, X_SHRT_MAX, X_SHRT_MIN, X_LONG_MAX)
1916 (X_LONG_MIN): New macros.
1917 Use them to make the following changes clearer.
1918 (MAX_SELECTION_QUANTUM): Make the other bounds on this value clearer.
1919 This change doesn't affect the value now, but it may help remind
1920 future maintainers not to raise the value too much later.
1921 (SELECTION_QUANTUM): Remove, replacing with ...
1922 (selection_quantum): ... new function, which avoids overflow.
1923 All uses changed.
1924 (struct selection_data.size): Now ptrdiff_t, not int, to avoid
1925 assumption that selection length fits in 'int'.
1926 (x_reply_selection_request, x_handle_selection_request)
1927 (x_get_window_property, receive_incremental_selection)
1928 (x_get_window_property_as_lisp_data, selection_data_to_lisp_data)
1929 (lisp_data_to_selection_data, clean_local_selection_data):
1930 Use ptrdiff_t, not int, to record length of selection.
1931 (x_reply_selection_request, x_get_window_property)
1932 (receive_incremental_selection, x_property_data_to_lisp):
1933 Redo calculations to avoid overflow.
1934 (x_reply_selection_request): When sending hint, ceiling it at
1935 X_LONG_MAX rather than relying on wraparound overflow to send
1936 something.
1937 (x_get_window_property, receive_incremental_selection)
1938 (lisp_data_to_selection_data, x_property_data_to_lisp):
1939 Check for size-calculation overflow.
1940 (x_get_window_property, receive_incremental_selection)
1941 (lisp_data_to_selection_data, Fx_register_dnd_atom):
1942 Don't store size until memory allocation succeeds.
1943 (x_get_window_property): Plug memory leak on memory exhaustion.
1944 Don't double-block input; malloc is safe here. Don't assume 2**34
1945 - 4 fits in unsigned long. Add an xassert to check
1946 XGetWindowProperty overflow. Be more careful about overflow
1947 calculations, and distinguish size from memory overflow better.
1948 (receive_incremental_selection): When tracing, don't assume
1949 unsigned int is less than INT_MAX.
1950 (x_selection_data_to_lisp_data): Remove unnecessary (and in theory
1951 harmful) conversions of unsigned short to int.
1952 (lisp_data_to_selection_data): Don't assume that integers
1953 in the range -65535 through -1 fit in an X unsigned short.
1954 Don't assume that ULONG_MAX == X_ULONG_MAX. Don't store into
1955 result parameters unless successful. Rely on cons_to_unsigned
1956 to report problems with elements; the old code wasn't right anyway.
1957 (x_check_property_data): Check for int overflow; we cannot use
1958 a wider type due to X limits.
1959 (x_handle_dnd_message): Use unsigned int, to avoid int overflow.
1960
1961 * xsmfns.c (smc_save_yourself_CB): Check for size calc overflow.
1962
1963 * xterm.c (x_color_cells, x_send_scrollbar_event, handle_one_xevent)
1964 (x_term_init): Check for size calculation overflow.
1965 (x_color_cells): Don't store size until memory allocation succeeds.
1966 (handle_one_xevent): Use ptrdiff_t, not int, for byte counts.
1967 Don't assume alloca size is less than MAX_ALLOCA.
1968 (x_term_init): Don't assume length fits in int (sprintf is limited
1969 to int size).
1970
1971 Use ptrdiff_t for composition IDs.
1972 * character.c (lisp_string_width):
1973 * composite.c (composition_table_size, n_compositions)
1974 (get_composition_id, composition_gstring_from_id):
1975 * dispextern.h (struct glyph_string.cmp_id, struct composition_it.id):
1976 * xdisp.c (BUILD_COMPOSITE_GLYPH_STRING):
1977 * window.c (Frecenter):
1978 Use ptrdiff_t, not int, for composition IDs.
1979 * composite.c (get_composition_id): Check for integer overflow.
1980 * composite.h: Adjust prototypes to match the above changes.
1981
1982 Use ptrdiff_t for hash table indexes.
1983 * category.c (hash_get_category_set):
1984 * ccl.c (ccl_driver):
1985 * charset.h (struct charset.hash_index, CHECK_CHARSET_GET_ID):
1986 * coding.c (coding_system_charset_list, detect_coding_system):
1987 * coding.h (struct coding_system.id):
1988 * composite.c (get_composition_id, gstring_lookup_cache):
1989 * fns.c (hash_lookup, hash_put, Fgethash, Fputhash):
1990 * image.c (xpm_get_color_table_h):
1991 * lisp.h (hash_lookup, hash_put):
1992 * minibuf.c (Ftest_completion):
1993 Use ptrdiff_t for hash table indexes, not int (which is too
1994 narrow, on 64-bit hosts) or EMACS_INT (which is too wide, on
1995 32-bit --with-wide-int hosts).
1996
1997 * charset.c (Fdefine_charset_internal): Check for integer overflow.
1998 Add a FIXME comment about memory leaks.
1999 (syms_of_charset): Don't assume xmalloc returns.
2000
2001 Don't assume that stated character widths fit in int.
2002 * character.c (Fchar_width, c_string_width, lisp_string_width):
2003 * character.h (CHAR_WIDTH):
2004 * indent.c (MULTIBYTE_BYTES_WIDTH):
2005 Use sanitize_char_width to avoid undefined and/or bad behavior
2006 with outlandish widths.
2007 * character.h (sanitize_tab_width): Rename from sanitize_width,
2008 now that we have two such functions. All uses changed.
2009 (sanitize_char_width): New inline function.
2010
2011 Don't assume that tab-width fits in int.
2012 * character.h (sanitize_width): New inline function.
2013 (SANE_TAB_WIDTH): New macro.
2014 (ASCII_CHAR_WIDTH): Use it.
2015 * indent.c (sane_tab_width): Remove. All uses replaced by
2016 SANE_TAB_WIDTH (current_buffer).
2017 * xdisp.c (init_iterator): Use SANE_TAB_WIDTH.
2018
2019 * fileio.c: Integer overflow issues with file modes.
2020 (Fset_file_modes, auto_save_1): Don't assume EMACS_INT fits in int.
2021
2022 * charset.c (read_hex): New arg OVERFLOW. All uses changed.
2023 Remove unreachable code.
2024 (read_hex, load_charset_map_from_file): Check for integer overflow.
2025
2026 * xterm.c: don't go over XClientMessageEvent limit
2027 (scroll_bar_windows_size): Now ptrdiff_t, as we prefer signed.
2028 (x_send_scroll_bar_event): Likewise. Check that the size does not
2029 exceed limits imposed by XClientMessageEvent, as well as the usual
2030 ptrdiff_t and size_t limits.
2031
2032 * keyboard.c: Overflow, signedness and related fixes.
2033 (make_lispy_movement): Use same integer type in forward decl
2034 that is used in the definition.
2035 (read_key_sequence, keyremap_step):
2036 Change bufsize argument back to int, undoing my 2011-03-30 change.
2037 We prefer signed types, and int is wide enough here.
2038 (parse_tool_bar_item): Don't assume tool_bar_max_label_size is less
2039 than TYPE_MAXIMUM (EMACS_INT) / 2. Don't let the label size grow
2040 larger than STRING_BYTES_BOUND. Use ptrdiff_t for Emacs string
2041 length, not size_t. Use ptrdiff_t for index, not int.
2042 (keyremap_step, read_key_sequence): Redo bufsize check to avoid
2043 possibility of integer overflow.
2044
2045 Overflow, signedness and related fixes for images.
2046
2047 * dispextern.h (struct it.stack[0].u.image.image_id)
2048 (struct_it.image_id, struct image.id, struct image_cache.size)
2049 (struct image_cache.used, struct image_cache.ref_count):
2050 * gtkutil.c (update_frame_tool_bar):
2051 * image.c (x_reference_bitmap, Fimage_size, Fimage_mask_p)
2052 (Fimage_metadata, free_image_cache, clear_image_cache, lookup_image)
2053 (cache_image, mark_image_cache, x_kill_gs_process, Flookup_image):
2054 * nsmenu.m (update_frame_tool_bar):
2055 * xdisp.c (calc_pixel_width_or_height):
2056 * xfns.c (image_cache_refcount):
2057 Image IDs are now ptrdiff_t, not int, to avoid arbitrary limits
2058 on typical 64-bit hosts.
2059
2060 * image.c (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): New macros.
2061 (x_bitmap_pixmap, x_create_x_image_and_pixmap):
2062 Omit unnecessary casts to int.
2063 (parse_image_spec): Check that integers fall into 'int' range
2064 when the callers expect that.
2065 (image_ascent): Redo ascent calculation to avoid int overflow.
2066 (clear_image_cache): Avoid overflow when sqrt (INT_MAX) < nimages.
2067 (lookup_image): Remove unnecessary tests.
2068 (xbm_image_p): Locals are now of int, not EMACS_INT,
2069 since parse_image_check makes sure they fit into int.
2070 (png_load, gif_load, svg_load_image):
2071 Prefer int to unsigned where either will do.
2072 (tiff_handler): New function, combining the cores of the
2073 old tiff_error_handler and tiff_warning_handler.
2074 This function is rewritten to use vsnprintf and thereby avoid
2075 stack buffer overflows. It uses only the features of vsnprintf
2076 that are common to both POSIX and native Microsoft.
2077 (tiff_error_handler, tiff_warning_handler): Use it.
2078 (tiff_load, gif_load, imagemagick_load_image):
2079 Don't assume :index value fits in 'int'.
2080 (gif_load): Omit unnecessary cast to double, and avoid double-rounding.
2081 (imagemagick_load_image): Check that crop parameters fit into
2082 the integer types that MagickCropImage accepts. Don't assume
2083 Vimagemagick_render_type has a nonnegative value. Don't assume
2084 size_t fits in 'long'.
2085 (gs_load): Use printmax_t to print the widest integers possible.
2086 Check for integer overflow when computing image height and width.
2087
2088 2011-08-26 Eli Zaretskii <eliz@gnu.org>
2089
2090 * xdisp.c (redisplay_window): Don't force window start if point
2091 will be invisible in the resulting window. (Bug#9324)
2092
2093 2011-08-25 Eli Zaretskii <eliz@gnu.org>
2094
2095 * xdisp.c (compute_display_string_pos): Return 2 in DISP_PROP when
2096 the display spec is of the form `(space ...)'.
2097 (handle_display_spec): Return the value returned by
2098 handle_single_display_spec, not just 1 or zero.
2099 (handle_single_display_spec): If the display spec is of the form
2100 `(space ...)', and specifies display in the text area, return 2
2101 rather than 1.
2102 (try_cursor_movement): Check for the need to scroll more
2103 accurately, and prefer exact match for point under bidi.
2104 Don't advance `row' beyond the last row of the window.
2105
2106 * dispextern.h (struct bidi_it): Rename the disp_prop_p member
2107 into disp_prop; all users changed.
2108
2109 * bidi.c (bidi_fetch_char): If compute_display_string_pos returns
2110 DISP_PROP = 2, substitute the u+2029 PARAGRAPH SEPARATOR character
2111 for the text covered by the display property.
2112
2113 2011-08-25 Chong Yidong <cyd@stupidchicken.com>
2114
2115 * buffer.c (Fbury_buffer_internal): Rename from Funrecord_buffer.
2116 Change return value to nil.
2117 (Frecord_buffer): Delete unused function.
2118
2119 2011-08-24 Eli Zaretskii <eliz@gnu.org>
2120
2121 * xdisp.c (Fcurrent_bidi_paragraph_direction): For unibyte
2122 buffers, return left-to-right.
2123 (set_cursor_from_row): Consider candidate row a win if its glyph
2124 represents a newline and point is on that newline. Fixes cursor
2125 positioning on the newline at EOL of R2L text within L2R
2126 paragraph, and vice versa.
2127 (try_cursor_movement): Check continued rows, in addition to
2128 continuation rows. Fixes unwarranted scroll when point enters a
2129 continued line of R2L text within an L2R paragraph, or vice versa.
2130 (cursor_row_p): Consider the case of point being equal to
2131 MATRIX_ROW_END_CHARPOS. Prevents cursor being stuck when moving
2132 from the end of a short line to the beginning of a continued line
2133 of R2L text within L2R paragraph.
2134 (RECORD_MAX_MIN_POS): For max_pos, use IT_CHARPOS even for
2135 composed characters.
2136
2137 * bidi.c (bidi_check_type): Use xassert.
2138 (bidi_cache_iterator_state): Update the disp_pos and disp_prop_p
2139 members.
2140
2141 2011-08-23 Eli Zaretskii <eliz@gnu.org>
2142
2143 * bidi.c (bidi_get_type): Abort if we get zero as the bidi type of
2144 a character.
2145
2146 2011-08-23 Chong Yidong <cyd@stupidchicken.com>
2147
2148 * nsfont.m (ns_otf_to_script): Fix typo.
2149
2150 2011-08-22 Kenichi Handa <handa@m17n.org>
2151
2152 * chartab.c (Fset_char_table_extra_slot): Do not inhibit setting a
2153 extra slot even if the purpose is char-code-property-table.
2154
2155 2011-08-23 Eli Zaretskii <eliz@gnu.org>
2156
2157 * xdisp.c (redisplay_window): When computing centering_position,
2158 account for the height of the header line. (Bug#8874)
2159
2160 * dispnew.c (buffer_posn_from_coords): Use buf_charpos_to_bytepos
2161 instead of CHAR_TO_BYTE. Fixes a crash when a completion
2162 candidate is selected by the mouse, and that candidate has a
2163 composed character under the mouse.
2164
2165 * xdisp.c (x_produce_glyphs): Set it->nglyphs to 1. Fixes pixel
2166 coordinates reported by pos-visible-in-window-p for a composed
2167 character in column zero.
2168
2169 2011-08-23 Stefan Monnier <monnier@iro.umontreal.ca>
2170
2171 * cmds.c (Fself_insert_command): Mention post-self-insert-hook.
2172
2173 2011-08-22 Eli Zaretskii <eliz@gnu.org>
2174
2175 * xdisp.c (BUFFER_POS_REACHED_P): If this is a composition,
2176 consider it a hit if to_charpos is anywhere in the range of the
2177 composed buffer positions.
2178
2179 2011-08-22 Chong Yidong <cyd@stupidchicken.com>
2180
2181 * image.c (gif_load): Don't assume that each subimage has the same
2182 dimensions as the base image. Handle disposal method that is
2183 "undefined" by the gif spec (Bug#9335).
2184
2185 2011-08-20 Chong Yidong <cyd@stupidchicken.com>
2186
2187 * eval.c (Fsignal): Handle `debug' symbol in error handler (Bug#9329).
2188 (Fcondition_case): Document `debug' symbol in error handler.
2189
2190 2011-08-19 Eli Zaretskii <eliz@gnu.org>
2191
2192 * xfaces.c (face_at_buffer_position): Avoid repeated evaluation of
2193 face ID by FACE_FROM_ID, and avoid a crash when mouse is moved
2194 from an Org mode buffer to a Speedbar frame.
2195
2196 * xdisp.c (RECORD_MAX_MIN_POS): If the display element comes from
2197 a composition, take its buffer position from IT->cmp_it.charpos.
2198 Fixes cursor positioning at the beginning of a line that begins
2199 with a composed character.
2200
2201 2011-08-18 Eli Zaretskii <eliz@gnu.org>
2202
2203 * bidi.c (bidi_get_type): If bidi_type_table reports zero as the
2204 character bidirectional type, use STRONG_L instead. Fixes crashes
2205 in a buffer produced by `describe-categories'.
2206
2207 * dispextern.h (struct bidi_it): Move disp_pos and disp_prop_p
2208 members before the level stack, so they would be saved and
2209 restored when copying iterator state. Fixes incorrect reordering
2210 around TABs covered by display properties.
2211
2212 2011-08-18 Andreas Schwab <schwab@linux-m68k.org>
2213
2214 * process.c (Fnetwork_interface_list): Correctly determine buffer size.
2215
2216 2011-08-17 Chong Yidong <cyd@stupidchicken.com>
2217
2218 * eval.c (internal_condition_case, internal_condition_case_1)
2219 (internal_condition_case_2, internal_condition_case_n):
2220 Remove unnecessary aborts (Bug#9081).
2221
2222 2011-08-17 Eli Zaretskii <eliz@gnu.org>
2223
2224 * lread.c (Fload) [DOS_NT]: If `openp' returns -2, but the file
2225 has no `load' handler, try opening the file locally. (Bug#9311)
2226
2227 2011-08-16 Ken Brown <kbrown@cornell.edu>
2228
2229 * gmalloc.c: Expand comment.
2230
2231 2011-08-16 Eli Zaretskii <eliz@gnu.org>
2232
2233 * xdisp.c (set_cursor_from_row): Don't accept a previous candidate
2234 if it fails the cursor_row_p test. Fixes cursor positioning at ZV.
2235
2236 2011-08-16 Ken Brown <kbrown@cornell.edu>
2237
2238 Fix memory allocation problems in Cygwin build (Bug#9273).
2239
2240 * unexcw.c ( __malloc_initialized): Declare external variable.
2241 (fixup_executable): Force the dumped emacs to reinitialize malloc.
2242
2243 * gmalloc.c [CYGWIN] (bss_sbrk_heapbase, bss_sbrk_heapinfo):
2244 New variables.
2245 (malloc_initialize_1) [CYGWIN]: Prepare for reinitializing the
2246 dumped emacs.
2247 (_free_internal_nolock) [CYGWIN]: Ignore requests to free storage
2248 in the static heap.
2249 [CYGWIN] (special_realloc): New function.
2250 (_realloc_internal_nolock) [CYGWIN]: Use the new function on
2251 requests to realloc storage in the static heap.
2252
2253 2011-08-15 Paul Eggert <eggert@cs.ucla.edu>
2254
2255 * bidi.c (bidi_initialize): Remove unused local.
2256
2257 2011-08-15 Eli Zaretskii <eliz@gnu.org>
2258
2259 * bidimirror.h:
2260 * biditype.h: Remove file.
2261 * makefile.w32-in ($(BLD)/bidi.$(O)):
2262 * deps.mk (bidi.o): Remove biditype.h and bidimirror.h.
2263
2264 * dispextern.h: Fix a typo in the comment to bidi_type_t.
2265
2266 * chartab.c: Improve commentary for the uniprop_table API.
2267
2268 * bidi.c (bidi_paragraph_init): Support zero value of
2269 bidi_ignore_explicit_marks_for_paragraph_level.
2270 (bidi_initialize): Use uniprop_table instead of including
2271 biditype.h and bidimirror.h.
2272
2273 * xdisp.c (move_it_in_display_line_to): Don't reset pixel
2274 coordinates of the iterator when restoring from ppos_it.
2275 (Bug#9296)
2276
2277 2011-08-14 Kenichi Handa <handa@m17n.org>
2278
2279 * process.c (create_process): Call setup_process_coding_systems
2280 after the pid of the process is set to -1 (Bug#8162).
2281
2282 2011-08-14 Eli Zaretskii <eliz@gnu.org>
2283
2284 * xdisp.c (move_it_in_display_line_to): Don't invoke
2285 IT_RESET_X_ASCENT_DESCENT when iterator position was restored from
2286 ppos_it. Fixes vertical cursor motion when line beginning is
2287 covered by an image. (Bug#9296)
2288
2289 2011-08-14 Jan Djärv <jan.h.d@swipnet.se>
2290
2291 * nsterm.h (ns_run_ascript): Declare.
2292 (NSAPP_DATA2_RUNASSCRIPT): Define.
2293
2294 * nsfns.m (as_script, as_result, as_status): New static variables.
2295 (ns_run_ascript): New function.
2296 (Fns_do_applescript): Set variables as_*. Make an NSApplicationDefined
2297 event with data2 set to NSAPP_DATA2_RUNASSCRIPT, post it and then start
2298 the event loop. Get status from as_status (Bug#7276).
2299
2300 * nsterm.m (sendEvent): If event is NSApplicationDefined and
2301 data2 is NSAPP_DATA2_RUNASSCRIPT, call ns_run_ascript and then exit
2302 the event loop (Bug#7276).
2303
2304 2011-08-14 Andreas Schwab <schwab@linux-m68k.org>
2305
2306 * gnutls.c (QCgnutls_bootprop_priority)
2307 (QCgnutls_bootprop_trustfiles, QCgnutls_bootprop_keylist)
2308 (QCgnutls_bootprop_crlfiles, QCgnutls_bootprop_callbacks)
2309 (QCgnutls_bootprop_loglevel, QCgnutls_bootprop_hostname)
2310 (QCgnutls_bootprop_min_prime_bits, QCgnutls_bootprop_verify_flags)
2311 (QCgnutls_bootprop_verify_hostname_error)
2312 (QCgnutls_bootprop_callbacks_verify): Rename from
2313 Qgnutls_bootprop_..., all uses changed.
2314
2315 * xfaces.c (QCignore_defface): Rename from Qignore_defface, all
2316 uses changed.
2317
2318 2011-08-14 Paul Eggert <eggert@cs.ucla.edu>
2319
2320 * xfaces.c (Qframe_set_background_mode): Now static.
2321 * dispextern.h (Qframe_set_background_mode): Remove decl.
2322
2323 * process.c (Fnetwork_interface_info): Declare local only if needed.
2324
2325 2011-08-13 Jan Djärv <jan.h.d@swipnet.se>
2326
2327 * process.c: Include ifaddrs.h and net/if_dl.h if available (Bug#8477).
2328 (Fnetwork_interface_list): Allocate in increments of bytes instead
2329 of sizeof (struct ifreq). Iterate over ifconf.ifc_req by counting
2330 bytes (Bug#8477). Count bytes correctly when ifr_addr is a struct
2331 sockaddr.
2332 (struct ifflag_def): notrailers is smart on OSX.
2333 (Fnetwork_interface_info): Handle case when ifr_flags is negative.
2334 Get hardware address with getifaddrs if available.
2335
2336 2011-08-12 Eli Zaretskii <eliz@gnu.org>
2337
2338 * xdisp.c (iterate_out_of_display_property): xassert that
2339 IT->position is set to within IT->object's boundaries. Break from
2340 the loop as soon as EOB is reached; avoids infloops in redisplay
2341 when IT->position is set up wrongly due to some bug.
2342 Set IT->current to match the bidi iterator unconditionally.
2343 (push_display_prop): Allow GET_FROM_STRING as IT->method on
2344 entry. Force push_it to save on the stack the current
2345 buffer/string position, to be restored by pop_it. Fix flags in
2346 the iterator structure wrt the object coming from a display
2347 property, as `line-prefix' and `wrap-prefix' are not ``replacing''
2348 properties. (Bug#9284)
2349
2350 2011-08-09 Andreas Schwab <schwab@linux-m68k.org>
2351
2352 * fontset.c (fontset_get_font_group): Add proper type checks.
2353 (Bug#9172)
2354
2355 2011-08-09 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
2356
2357 * unexmacosx.c (print_load_command_name): Add cases LC_FUNCTION_STARTS
2358 and LC_VERSION_MIN_MACOSX.
2359 (copy_linkedit_data) [LC_FUNCTION_STARTS]: New function.
2360 (dump_it) [LC_FUNCTION_STARTS]: Use it.
2361
2362 2011-08-08 Eli Zaretskii <eliz@gnu.org>
2363
2364 * xdisp.c (forward_to_next_line_start): Allow to use the
2365 no-display-properties-and-no-overlays under bidi display.
2366 Set disp_pos in the bidi iterator to avoid searches for display
2367 properties and overlays.
2368
2369 2011-08-08 Chong Yidong <cyd@stupidchicken.com>
2370
2371 * editfns.c (Fset_time_zone_rule): Document relationship with the
2372 setenv function.
2373
2374 * ftfont.c (ftfont_pattern_entity): Copy the extras argument to
2375 the font entity extracted from the cache (Bug#8109).
2376
2377 2011-08-07 Chong Yidong <cyd@stupidchicken.com>
2378
2379 * composite.c (autocmp_chars): Don't reset point. That is done by
2380 restore_point_unwind (Bug#5984).
2381
2382 2011-08-07 Juri Linkov <juri@jurta.org>
2383
2384 * editfns.c (Fformat_time_string): Doc fix, add tag `usage:'
2385 to show the arg `TIME' instead of `TIMEVAL'.
2386
2387 2011-08-06 Eli Zaretskii <eliz@gnu.org>
2388
2389 * xdisp.c (set_cursor_from_row): Fix cursor positioning when a
2390 display property strides EOL and includes a newline, as in
2391 longlines-mode. (Bug#9254)
2392 (move_it_in_display_line_to): Fix vertical-motion in a buffer with
2393 word-wrap under bidirectional display. (Bug#9224)
2394
2395 * bidi.c (bidi_unshelve_cache): Don't reset the cache if JUST_FREE
2396 is non-zero, even if the data buffer is NULL. Fixes a crash in
2397 vertical-motion with longlines-mode. (Bug#9254)
2398
2399 2011-08-05 Eli Zaretskii <eliz@gnu.org>
2400
2401 * bidi.c <bidi_cache_total_alloc>: Now static.
2402 (bidi_initialize): Initialize bidi_cache_total_alloc.
2403
2404 * xdisp.c (display_line): Release buffer allocated for shelved bidi
2405 cache. (Bug#9221)
2406
2407 * bidi.c (bidi_shelve_cache, bidi_unshelve_cache): Track total
2408 amount allocated this far in `bidi_cache_total_alloc'.
2409 (bidi_unshelve_cache): Accept an additional argument JUST_FREE; if
2410 non-zero, only free the data buffer without restoring the cache
2411 contents. All callers changed.
2412
2413 * dispextern.h (bidi_unshelve_cache): Update prototype.
2414
2415 * xdisp.c (SAVE_IT, pos_visible_p, move_it_in_display_line_to)
2416 (move_it_in_display_line, move_it_to)
2417 (move_it_vertically_backward, move_it_by_lines): Replace the call
2418 to xfree to an equivalent call to bidi_unshelve_cache.
2419 (move_it_in_display_line_to): Fix logic of returning
2420 MOVE_POS_MATCH_OR_ZV in the bidi case. (Bug#9224)
2421
2422 2011-08-05 Eli Zaretskii <eliz@gnu.org>
2423
2424 * xdisp.c (set_cursor_from_row): Prefer the candidate glyph that
2425 came from a string character with a `cursor' property. (Bug#9229)
2426
2427 2011-08-04 Jan Djärv <jan.h.d@swipnet.se>
2428
2429 * Makefile.in (LIB_PTHREAD): New variable.
2430 (LIBES): Add LIB_PTHREAD (Bug#9216).
2431
2432 * alloc.c, emacs.c, gmalloc.c, gtkutil.c, keyboard.c, syssignal.h:
2433 Rename HAVE_GTK_AND_PTHREAD to HAVE_PTHREAD (Bug#9216).
2434
2435 2011-08-04 Andreas Schwab <schwab@linux-m68k.org>
2436
2437 * regex.c (re_iswctype): Remove some redundant boolean conversions.
2438
2439 2011-08-04 Jan Djärv <jan.h.d@swipnet.se>
2440
2441 * xterm.c (x_find_topmost_parent): New function.
2442 (x_set_frame_alpha): Find topmost parent window with
2443 x_find_topmost_parent and set the property there also (bug#9181).
2444 (handle_one_xevent): Call x_set_frame_alpha on ReparentNotify.
2445
2446 2011-08-04 Paul Eggert <eggert@cs.ucla.edu>
2447
2448 * callproc.c (Fcall_process): Avoid vfork clobbering
2449 the local vars buffer, coding_systems, current_dir.
2450
2451 2011-08-03 Stefan Monnier <monnier@iro.umontreal.ca>
2452
2453 * keymap.c (Fmake_composed_keymap): Move to subr.el.
2454
2455 2011-08-03 Paul Eggert <eggert@cs.ucla.edu>
2456
2457 * fontset.c (dump_fontset) [FONTSET_DEBUG]: Declare EXTERNALLY_VISIBLE
2458 so that it is not optimized away.
2459
2460 * xdisp.c (compute_display_string_pos): Remove unused local.
2461
2462 2011-08-02 Eli Zaretskii <eliz@gnu.org>
2463
2464 Fix slow cursor motion and scrolling in large buffers with
2465 selective display, like Org Mode buffers. (Bug#9218)
2466
2467 * dispextern.h (struct bidi_it): New member disp_prop_p.
2468
2469 * xdisp.c: Remove one-slot cache of display string positions.
2470 (compute_display_string_pos): Accept an additional argument
2471 DISP_PROP_P; callers changed. Scan at most 5K characters forward
2472 for a display string or property. If found, set DISP_PROP_P
2473 non-zero.
2474
2475 * bidi.c (bidi_fetch_char): Accept an additional argument
2476 DISP_PROP_P, and pass it to compute_display_string_pos.
2477 Only handle text covered by a display string if DISP_PROP_P is returned
2478 non-zero. All callers of bidi_fetch_char changed.
2479
2480 2011-08-02 Stefan Monnier <monnier@iro.umontreal.ca>
2481
2482 * keymap.c (Fdefine_key): Fix Lisp_Object/int mixup; apply some CSE.
2483
2484 2010-12-03 Don March <don@ohspite.net>
2485
2486 * keymap.c (Fdefine_key): Fix non-prefix key error message when
2487 last character M-[char] is translated to ESC [char] (bug#7541).
2488
2489 2011-08-02 Kenichi Handa <handa@m17n.org>
2490
2491 * lisp.h (uniprop_table): Extern it.
2492
2493 * chartab.c (uniprop_table): Make it non-static.
2494
2495 2011-08-01 Eli Zaretskii <eliz@gnu.org>
2496
2497 * xdisp.c (forward_to_next_line_start): Accept additional argument
2498 BIDI_IT_PREV, and store into it the state of the bidi iterator had
2499 on the newline.
2500 (reseat_at_next_visible_line_start): Use the bidi iterator state
2501 returned by forward_to_next_line_start to restore the state of
2502 it->bidi_it after backing up to previous newline. (Bug#9212)
2503
2504 2011-07-30 Andreas Schwab <schwab@linux-m68k.org>
2505
2506 * regex.c (re_comp): Protoize.
2507 (re_exec): Fix return type.
2508 (regexec): Fix type of `ret'. (Bug#9203)
2509
2510 2011-07-28 Paul Eggert <eggert@cs.ucla.edu>
2511
2512 * image.c (check_image_size): Use 1024x1024 if unknown frame (Bug#9189).
2513 This is needed if max-image-size is a floating-point number.
2514
2515 2011-07-28 Andreas Schwab <schwab@linux-m68k.org>
2516
2517 * print.c (print_object): Print empty symbol as ##.
2518
2519 * lread.c (read1): Read ## as empty symbol.
2520
2521 2011-07-28 Alp Aker <alp.tekin.aker@gmail.com>
2522
2523 * nsfns.m (x_set_foreground_color): Set f->foreground_pixel when
2524 setting frame foreground color (Bug#9175).
2525 (x_set_background_color): Likewise.
2526
2527 * nsmenu.m (-setText): Size tooltip dimensions precisely to
2528 contents (Bug#9176).
2529 (EmacsTooltip -init): Remove bezels and add shadows to
2530 tooltip windows.
2531
2532 * nsterm.m (ns_dumpglyphs_stretch): Avoid overwriting left fringe
2533 or scroll bar (Bug#8470).
2534
2535 * nsfont.m (nsfont_open): Remove assignment to voffset and
2536 unnecessary vars hshink, expand, hd, full_height, min_height.
2537 (nsfont_draw): Use s->ybase as baseline for glyph drawing (Bug#8913).
2538
2539 * nsterm.h (nsfont_info): Remove voffset field.
2540
2541 2011-07-28 Alp Aker <alp.tekin.aker@gmail.com>
2542
2543 Implement strike-through and overline on NextStep (Bug#8863).
2544
2545 * nsfont.m (nsfont_open): Use underline position provided by font,
2546 instead of hard-coded value of 2.
2547 (nsfont_draw): Call ns_draw_text_decoration instead.
2548
2549 * nsterm.h: Add declaration for ns_draw_text_decoration.
2550
2551 * nsterm.m (ns_draw_text_decoration): New function for drawing
2552 underline, overline, and strike-through.
2553 (ns_dumpglyphs_image, ns_dumpglyphs_stretch): Add call to
2554 ns_draw_text_decoration. Change treatment of cursor drawing to
2555 accommodate underlining, etc.
2556
2557 2011-07-28 Eli Zaretskii <eliz@gnu.org>
2558
2559 * buffer.c (init_buffer_once): Set bidi-display-reordering to t by
2560 default.
2561
2562 2011-07-28 Paul Eggert <eggert@cs.ucla.edu>
2563
2564 * alloc.c (memory_full) [!SYNC_INPUT]: Fix signal-related race.
2565 Without this fix, if a signal arrives just after memory fills up,
2566 'malloc' might be invoked reentrantly.
2567
2568 * image.c (x_check_image_size) [!HAVE_X_WINDOWS]: Return 1.
2569 In other words, assume that every image size is allowed, on non-X
2570 hosts. This assumption is probably wrong, but it lets Emacs compile.
2571
2572 2011-07-28 Andreas Schwab <schwab@linux-m68k.org>
2573
2574 * regex.c (re_iswctype): Convert return values to boolean.
2575
2576 2011-07-28 Eli Zaretskii <eliz@fencepost.gnu.org>
2577
2578 * xdisp.c (compute_display_string_pos): Don't use cached display
2579 string position if the buffer had its restriction changed.
2580 (Bug#9184)
2581
2582 2011-07-28 Paul Eggert <eggert@cs.ucla.edu>
2583
2584 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
2585
2586 2011-07-28 Paul Eggert <eggert@cs.ucla.edu>
2587
2588 Integer signedness and overflow and related fixes. (Bug#9079)
2589
2590 * bidi.c: Integer size and overflow fixes.
2591 (bidi_cache_size, bidi_cache_idx, bidi_cache_last_idx)
2592 (bidi_cache_start, bidi_cache_fetch_state, bidi_cache_search)
2593 (bidi_cache_find_level_change, bidi_cache_ensure_space)
2594 (bidi_cache_iterator_state, bidi_cache_find, bidi_cache_start_stack)
2595 (bidi_find_other_level_edge):
2596 Use ptrdiff_t instead of EMACS_INT where either will do.
2597 This works better on 32-bit hosts configured --with-wide-int.
2598 (bidi_cache_ensure_space): Check for size-calculation overflow.
2599 Use % rather than repeated addition, for better worst-case speed.
2600 Don't set bidi_cache_size until after xrealloc returns, because it
2601 might not return.
2602 (bidi_dump_cached_states): Use ptrdiff_t, not int, to avoid overflow.
2603 (bidi_cache_ensure_space): Also check that the bidi cache size
2604 does not exceed that of the largest Lisp string or buffer. See Eli
2605 Zaretskii in <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9079#29>.
2606
2607 * alloc.c (__malloc_size_t): Remove.
2608 All uses replaced by size_t. See Andreas Schwab's note
2609 <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9079#8>.
2610
2611 * image.c: Improve checking for integer overflow.
2612 (check_image_size): Assume that f is nonnull, since
2613 it is always nonnull in practice. This is one less thing to
2614 worry about when checking for integer overflow later.
2615 (x_check_image_size): New function, which checks for integer
2616 overflow issues inside X.
2617 (x_create_x_image_and_pixmap, xbm_read_bitmap_data): Use it.
2618 This removes the need for a memory_full check.
2619 (xbm_image_p): Rewrite to avoid integer multiplication overflow.
2620 (Create_Pixmap_From_Bitmap_Data, xbm_load): Use x_check_image_size.
2621 (xbm_read_bitmap_data): Change locals back to 'int', since
2622 their values must fit in 'int'.
2623 (xpm_load_image, png_load, tiff_load):
2624 Invoke x_create_x_image_and_pixmap earlier,
2625 to avoid much needless work if the image is too large.
2626 (tiff_load): Treat overly large images as if
2627 x_create_x_image_and_pixmap failed, not as malloc failures.
2628 (gs_load): Use x_check_image_size.
2629
2630 * gtkutil.c: Omit integer casts.
2631 (xg_get_pixbuf_from_pixmap): Remove unnecessary cast.
2632 (xg_set_toolkit_scroll_bar_thumb): Rewrite to avoid need for cast.
2633
2634 * image.c (png_load): Don't assume height * row_bytes fits in 'int'.
2635
2636 * xfaces.c (Fbitmap_spec_p): Fix integer overflow bug.
2637 Without this fix, (bitmap-spec-p '(34359738368 1 "x"))
2638 would wrongly return t on a 64-bit host.
2639
2640 * dispnew.c (init_display): Use *_RANGE_OVERFLOW macros.
2641 The plain *_OVERFLOW macros run afoul of GCC bug 49705
2642 <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=49705>
2643 and therefore cause GCC to emit a bogus diagnostic in some cases.
2644
2645 * image.c: Integer signedness and overflow and related fixes.
2646 This is not an exhaustive set of fixes, but it's time to
2647 record what I've got.
2648 (lookup_pixel_color, check_image_size): Remove redundant decls.
2649 (check_image_size): Don't assume that arbitrary EMACS_INT values
2650 fit in 'int', or that arbitrary 'double' values fit in 'int'.
2651 (x_alloc_image_color, x_create_x_image_and_pixmap, png_load)
2652 (tiff_load, imagemagick_load_image):
2653 Check for overflow in size calculations.
2654 (x_create_x_image_and_pixmap): Remove unnecessary test for
2655 xmalloc returning NULL; that can't happen.
2656 (xbm_read_bitmap_data): Don't assume sizes fit into 'int'.
2657 (xpm_color_bucket): Use better integer hashing function.
2658 (xpm_cache_color): Don't possibly over-allocate memory.
2659 (struct png_memory_storage, tiff_memory_source, tiff_seek_in_memory)
2660 (gif_memory_source):
2661 Use ptrdiff_t, not int or size_t, to record sizes.
2662 (png_load): Don't assume values greater than 2**31 fit in 'int'.
2663 (our_stdio_fill_input_buffer): Prefer ptrdiff_t to size_t when
2664 either works, as we prefer signed integers.
2665 (tiff_read_from_memory, tiff_write_from_memory):
2666 Return tsize_t, not size_t, since that's what the TIFF API wants.
2667 (tiff_read_from_memory): Don't fail simply because the read would
2668 go past EOF; instead, return a short read.
2669 (tiff_load): Omit no-longer-needed casts.
2670 (Fimagemagick_types): Don't assume size fits into 'int'.
2671
2672 Improve hashing quality when configured --with-wide-int.
2673 * fns.c (hash_string): New function, taken from sxhash_string.
2674 Do not discard information about ASCII character case; this
2675 discarding is no longer needed.
2676 (sxhash-string): Use it. Change sig to match it. Caller changed.
2677 * lisp.h: Declare it.
2678 * lread.c (hash_string): Remove, since we now use fns.c's version.
2679 The fns.c version returns a wider integer if --with-wide-int is
2680 specified, so this should help the quality of the hashing a bit.
2681
2682 * emacs.c: Integer overflow minor fix.
2683 (heap_bss_diff): Now uprintmax_t, not unsigned long. All used changed.
2684 Define only if GNU_LINUX.
2685 (main, Fdump_emacs): Set and use heap_bss_diff only if GNU_LINUX.
2686
2687 * dispnew.c: Integer signedness and overflow fixes.
2688 Remove unnecessary forward decls, that were a maintenance hassle.
2689 (history_tick): Now uprintmax_t, so it's more likely to avoid overflow.
2690 All uses changed.
2691 (adjust_glyph_matrix, realloc_glyph_pool, adjust_frame_message_buffer)
2692 (scrolling_window): Use ptrdiff_t, not int, for byte count.
2693 (prepare_desired_row, line_draw_cost):
2694 Use int, not unsigned, where either works.
2695 (save_current_matrix, restore_current_matrix):
2696 Use ptrdiff_t, not size_t, where either works.
2697 (init_display): Check for overflow more accurately, and without
2698 relying on undefined behavior.
2699
2700 * editfns.c (pWIDE, pWIDElen, signed_wide, unsigned_wide):
2701 Remove, replacing with the new symbols in lisp.h. All uses changed.
2702 * fileio.c (make_temp_name):
2703 * filelock.c (lock_file_1, lock_file):
2704 * xdisp.c (message_dolog):
2705 Don't assume PRIdMAX etc. works; this isn't portable to pre-C99 hosts.
2706 Use pMd etc. instead.
2707 * lisp.h (printmax_t, uprintmax_t, pMd, pMu): New types and macros,
2708 replacing the pWIDE etc. symbols removed from editfns.c.
2709
2710 * keyboard.h (num_input_events): Now uintmax_t.
2711 This is (very slightly) less likely to mess up due to wraparound.
2712 All uses changed.
2713
2714 * buffer.c: Integer signedness fixes.
2715 (alloc_buffer_text, enlarge_buffer_text):
2716 Use ptrdiff_t rather than size_t when either will do, as we prefer
2717 signed integers.
2718
2719 * alloc.c: Integer signedness and overflow fixes.
2720 Do not impose an arbitrary 32-bit limit on malloc sizes when debugging.
2721 (__malloc_size_t): Default to size_t, not to int.
2722 (pure_size, pure_bytes_used_before_overflow, stack_copy_size)
2723 (Fgarbage_collect, mark_object_loop_halt, mark_object):
2724 Prefer ptrdiff_t to size_t when either would do, as we prefer
2725 signed integers.
2726 (XMALLOC_OVERRUN_CHECK_OVERHEAD): New macro.
2727 (xmalloc_overrun_check_header, xmalloc_overrun_check_trailer):
2728 Now const. Initialize with values that are in range even if char
2729 is signed.
2730 (XMALLOC_PUT_SIZE, XMALLOC_GET_SIZE): Remove, replacing with ...
2731 (xmalloc_put_size, xmalloc_get_size): New functions. All uses changed.
2732 These functions do the right thing with sizes > 2**32.
2733 (check_depth): Now ptrdiff_t, not int.
2734 (overrun_check_malloc, overrun_check_realloc, overrun_check_free):
2735 Adjust to new way of storing sizes. Check for size overflow bugs
2736 in rest of code.
2737 (STRING_BYTES_MAX): Adjust to new overheads. The old code was
2738 slightly wrong anyway, as it missed one instance of
2739 XMALLOC_OVERRUN_CHECK_OVERHEAD.
2740 (refill_memory_reserve): Omit needless cast to size_t.
2741 (mark_object_loop_halt): Mark as externally visible.
2742
2743 * xselect.c: Integer signedness and overflow fixes.
2744 (Fx_register_dnd_atom, x_handle_dnd_message):
2745 Use ptrdiff_t, not size_t, since we prefer signed.
2746 (Fx_register_dnd_atom): Check for ptrdiff_t (and size_t) overflow.
2747 * xterm.h (struct x_display_info): Use ptrdiff_t, not size_t, for
2748 x_dnd_atoms_size and x_dnd_atoms_length.
2749
2750 * doprnt.c: Prefer signed to unsigned when either works.
2751 * eval.c (verror):
2752 * doprnt.c (doprnt):
2753 * lisp.h (doprnt):
2754 * xdisp.c (vmessage):
2755 Use ptrdiff_t, not size_t, when using or implementing doprnt,
2756 since the sizes cannot exceed ptrdiff_t bounds anyway, and we
2757 prefer signed arithmetic to avoid comparison confusion.
2758 * doprnt.c (doprnt): Avoid a "+ 1" that can't overflow,
2759 but is a bit tricky.
2760
2761 Assume freestanding C89 headers, string.h, stdlib.h.
2762 * data.c, doprnt.c, floatfns.c, print.c:
2763 Include float.h unconditionally.
2764 * gmalloc.c: Assume C89-at-least behavior for preprocessor,
2765 limits.h, stddef.h, string.h. Use memset instead of 'flood'.
2766 * regex.c: Likewise for stddef.h, string.h.
2767 (ISASCII): Remove; can assume it returns 1 now. All uses removed.
2768 * s/aix4-2.h (HAVE_STRING_H): Remove obsolete undef.
2769 * s/ms-w32.h (HAVE_LIMITS_H, HAVE_STRING_H, HAVE_STDLIB_H)
2770 (STDC_HEADERS): Remove obsolete defines.
2771 * sysdep.c: Include limits.h unconditionally.
2772
2773 Assume support for memcmp, memcpy, memmove, memset.
2774 * lisp.h, sysdep.c (memcmp, memcpy, memmove, memset):
2775 * regex.c (memcmp, memcpy):
2776 Remove; we assume C89 now.
2777
2778 * gmalloc.c (memcpy, memset, memmove): Remove; we assume C89 now.
2779 (__malloc_safe_bcopy): Remove; no longer needed.
2780
2781 * lisp.h (struct vectorlike_header, struct Lisp_Subr): Signed sizes.
2782 Use EMACS_INT, not EMACS_UINT, for sizes. The code works equally
2783 well either way, and we prefer signed to unsigned.
2784
2785 2011-07-27 Lars Magne Ingebrigtsen <larsi@gnus.org>
2786
2787 * gnutls.c (emacs_gnutls_read): Don't message anything if the peer
2788 closes the connection while we're reading (bug#9182).
2789
2790 2011-07-25 Jan Djärv <jan.h.d@swipnet.se>
2791
2792 * nsmenu.m (ns_popup_dialog): Add an "ok" button if no buttons
2793 are specified (Bug#9168).
2794
2795 2011-07-25 Paul Eggert <eggert@cs.ucla.edu>
2796
2797 * bidi.c (bidi_dump_cached_states): Fix printf format mismatch.
2798 Found by GCC static checking and --with-wide-int on a 32-bit host.
2799
2800 2011-07-25 Eli Zaretskii <eliz@gnu.org>
2801
2802 * xdisp.c (compute_display_string_pos): Fix logic of caching
2803 previous display string position. Initialize cached_prev_pos to
2804 -1. Fixes slow-down at the beginning of a buffer.
2805
2806 2011-07-24 Eli Zaretskii <eliz@gnu.org>
2807
2808 * xfaces.c (check_lface_attrs) [HAVE_WINDOW_SYSTEM]: Allow `nil'
2809 for attrs[LFACE_FONTSET_INDEX].
2810
2811 2011-07-23 Paul Eggert <eggert@cs.ucla.edu>
2812
2813 * xml.c (parse_region): Remove unused local
2814 that was recently introduced.
2815
2816 2011-07-23 Eli Zaretskii <eliz@gnu.org>
2817
2818 * xfns.c (unwind_create_frame) [GLYPH_DEBUG]: Adapt to changes in
2819 2008-02-22T17:42:09Z!monnier@iro.umontreal.ca.
2820
2821 * xdisp.c (move_it_in_display_line_to): Record the best matching
2822 position for TO_CHARPOS while scanning the line, and restore it on
2823 exit if none of the characters scanned was an exact match.
2824 Fixes vertical-motion and pos-visible-in-window-p under bidi redisplay
2825 when exact match is impossible due to invisible text, and the
2826 lines are truncated.
2827
2828 2011-07-23 Jan Djärv <jan.h.d@swipnet.se>
2829
2830 * nsterm.m (initFrameFromEmacs): Set NSTitledWindowMask in styleMask
2831 for OSX >= 10.7.
2832
2833 2011-07-22 Eli Zaretskii <eliz@gnu.org>
2834
2835 Fix a significant slow-down of cursor motion with C-n, C-p,
2836 C-f/C-b, and C-v/M-v that couldn't keep up with keyboard
2837 auto-repeat under bidi redisplay in fontified buffers.
2838 * xdisp.c (compute_stop_pos_backwards): New function.
2839 (next_element_from_buffer): Call compute_stop_pos_backwards to
2840 find a suitable prev_stop when we find ourselves before
2841 base_level_stop.
2842 (reseat): Don't look for prev_stop, as that could mean a very long
2843 run.
2844 <cached_disp_pos, cached_disp_buffer, cached_disp_modiff>
2845 <cached_disp_overlay_modiff>: Cache for last found display string
2846 position.
2847 (compute_display_string_pos): Return the cached position if asked
2848 about the same buffer in the same area of character positions, and
2849 the buffer wasn't changed since the time the display string
2850 position was cached.
2851
2852 2011-07-22 Eli Zaretskii <eliz@gnu.org>
2853
2854 * xdisp.c (rows_from_pos_range): Don't ignore glyphs whose object
2855 is an integer, which is important for empty lines. (Bug#9149)
2856
2857 2011-07-22 Chong Yidong <cyd@stupidchicken.com>
2858
2859 * frame.c (Fmodify_frame_parameters): In tty case, update the
2860 default face if necessary (Bug#4238).
2861
2862 2011-07-21 Chong Yidong <cyd@stupidchicken.com>
2863
2864 * editfns.c (Fstring_to_char): No need to explain what a character
2865 is in the docstring (Bug#6576).
2866
2867 2011-07-20 Lars Magne Ingebrigtsen <larsi@gnus.org>
2868
2869 * xml.c (parse_region): Make sure we always return a tree.
2870
2871 2011-07-20 HAMANO Kiyoto <khiker.mail@gmail.com>
2872
2873 * xml.c (parse_region): If a document contains only comments,
2874 return that, too.
2875
2876 2011-07-20 Lars Magne Ingebrigtsen <larsi@gnus.org>
2877
2878 * xml.c (make_dom): Return comments, too.
2879
2880 2011-07-19 Paul Eggert <eggert@cs.ucla.edu>
2881
2882 Port to OpenBSD.
2883 See http://lists.gnu.org/archive/html/emacs-devel/2011-07/msg00688.html
2884 and the surrounding thread.
2885 * minibuf.c (read_minibuf_noninteractive): Rewrite to use getchar
2886 rather than fgets, and retry after EINTR. Otherwise, 'emacs
2887 --batch -f byte-compile-file' fails on OpenBSD if an inactivity
2888 timer goes off.
2889 * s/openbsd.h (BROKEN_SIGIO): Define.
2890 * unexelf.c (unexec) [__OpenBSD__]:
2891 Don't update the .mdebug section of the Alpha COFF symbol table.
2892
2893 2011-07-19 Lars Magne Ingebrigtsen <larsi@gnus.org>
2894
2895 * lread.c (syms_of_lread): Clarify when `lexical-binding' is used
2896 (bug#8460).
2897
2898 2011-07-18 Paul Eggert <eggert@cs.ucla.edu>
2899
2900 * fileio.c (Fcopy_file) [!MSDOS]: Tighten created file's mask.
2901 This fixes some race conditions on the permissions of any newly
2902 created file.
2903
2904 * alloc.c (valid_pointer_p): Use pipe, not open.
2905 This fixes some permissions issues when debugging.
2906
2907 * fileio.c (Fcopy_file): Adjust mode if fchown fails. (Bug#9002)
2908 If fchown fails to set both uid and gid, try to set just gid,
2909 as that is sometimes allowed. Adjust the file's mode to eliminate
2910 setuid or setgid bits that are inappropriate if fchown fails.
2911
2912 2011-07-18 Stefan Monnier <monnier@iro.umontreal.ca>
2913
2914 * xdisp.c (next_element_from_string, next_element_from_buffer): Use EQ
2915 to compare Lisp_Objects.
2916 * gnutls.c (syms_of_gnutls): Rename Vgnutls_log_level to
2917 global_gnutls_log_level, don't mistake it for a Lisp_Object.
2918 (init_gnutls_functions, emacs_gnutls_handle_error): Fix up uses.
2919
2920 2011-07-17 Andreas Schwab <schwab@linux-m68k.org>
2921
2922 * lread.c (read_integer): Unread even EOF character.
2923 (read1): Likewise. Properly record start position of symbol.
2924
2925 * lread.c (read1): Read `#:' as empty uninterned symbol if no
2926 symbol character follows.
2927
2928 2011-07-17 Paul Eggert <eggert@cs.ucla.edu>
2929
2930 * fileio.c (Fcopy_file): Pacify gcc re fchown. (Bug#9002)
2931 This works around a problem with the previous change to Fcopy_file.
2932 Recent glibc declares fchown with __attribute__((warn_unused_result)),
2933 and without this change, GCC might complain about discarding
2934 fchown's return value.
2935
2936 2011-07-16 Juanma Barranquero <lekktu@gmail.com>
2937
2938 * makefile.w32-in (GLOBAL_SOURCES): Add gnutls.c (followup to bug#9059).
2939
2940 2011-07-16 Paul Eggert <eggert@cs.ucla.edu>
2941
2942 * fileio.c (Fcopy_file): Don't diagnose fchown failures. (Bug#9002)
2943
2944 2011-07-16 Lars Magne Ingebrigtsen <larsi@gnus.org>
2945
2946 * gnutls.c (syms_of_gnutls): Define `gnutls-log-level' here, since
2947 it's used from the C level.
2948
2949 * process.c: Use the same condition for POLL_FOR_INPUT in both
2950 keyboard.c and process.c (bug#1858).
2951
2952 2011-07-09 Lawrence Mitchell <wence@gmx.li>
2953
2954 * gnutls.c (Qgnutls_bootprop_min_prime_bits): New variable.
2955 (Fgnutls_boot): Use it.
2956
2957 2011-07-15 Andreas Schwab <schwab@linux-m68k.org>
2958
2959 * doc.c (Fsubstitute_command_keys): Revert last change.
2960
2961 2011-07-15 Lars Magne Ingebrigtsen <larsi@gnus.org>
2962
2963 * doc.c (Fsubstitute_command_keys): Clarify that \= really only
2964 quotes the next character, and doesn't affect other longer
2965 sequences (bug#8935).
2966
2967 * lread.c (syms_of_lread): Clarify that is isn't only
2968 `eval-buffer' and `eval-defun' that's affected by
2969 `lexical-binding' (bug#8460).
2970
2971 2011-07-15 Eli Zaretskii <eliz@gnu.org>
2972
2973 * xdisp.c (move_it_in_display_line_to): Fix vertical motion with
2974 bidi redisplay when a line includes both an image and is truncated.
2975
2976 2011-07-14 Paul Eggert <eggert@cs.ucla.edu>
2977
2978 Fix minor problems found by static checking.
2979 * bidi.c (bidi_cache_size): Now EMACS_INT, not size_t.
2980 (elsz): Now a signed constant, not a size_t var. We prefer signed
2981 types to unsigned, to avoid integer comparison confusion. Without
2982 this change, GCC 4.6.1 with -Wunsafe-loop-optimizations complains
2983 "cannot optimize loop, the loop counter may overflow", a symptom
2984 of the confusion.
2985 * indent.c (Fvertical_motion): Mark locals as initialized.
2986 * xdisp.c (reseat_to_string): Fix pointer signedness issue.
2987
2988 2011-07-14 Lars Magne Ingebrigtsen <larsi@gnus.org>
2989
2990 * search.c (Fre_search_backward): Mention `case-fold-search' in
2991 all the re_search_* functions (bug#8138).
2992
2993 * keyboard.c (Fopen_dribble_file): Document when the file is
2994 closed (bug#8056).
2995
2996 2011-07-14 Eli Zaretskii <eliz@gnu.org>
2997
2998 * bidi.c (bidi_dump_cached_states): Fix format of displaying
2999 bidi_cache_idx.
3000
3001 Support bidi reordering of display and overlay strings.
3002 * xdisp.c (compute_display_string_pos)
3003 (compute_display_string_end): Accept additional argument STRING.
3004 (init_iterator, reseat_1): Initialize bidi_it->string.s to NULL.
3005 (reseat_to_string): Initialize bidi_it->string.s and
3006 bidi_it->string.schars.
3007 (Fcurrent_bidi_paragraph_direction): Initialize itb.string.s to
3008 NULL (avoids a crash in bidi_paragraph_init).
3009 Initialize itb.string.lstring.
3010 (init_iterator): Call bidi_init_it only of a valid
3011 buffer position was specified. Initialize paragraph_embedding to
3012 L2R.
3013 (reseat_to_string): Initialize the bidi iterator.
3014 (display_string): If we need to ignore text properties of
3015 LISP_STRING, set IT->stop_charpos to IT->end_charpos. (The
3016 original value of -1 will not work with bidi.)
3017 (compute_display_string_pos): First arg is now struct
3018 `text_pos *'; all callers changed. Support display properties on
3019 Lisp strings.
3020 (compute_display_string_end): Support display properties on Lisp
3021 strings.
3022 (init_iterator, reseat_1, reseat_to_string): Initialize the
3023 string.bufpos member to 0 (zero, for compatibility with IT_CHARPOS
3024 when iterating on a string not from display properties).
3025 (compute_display_string_pos, compute_display_string_end):
3026 Fix calculation of the object to scan. Fixes an error when using
3027 arrow keys.
3028 (next_element_from_buffer): Don't abort when IT_CHARPOS is before
3029 base_level_stop; instead, set base_level_stop to BEGV.
3030 Fixes crashes in vertical-motion.
3031 (next_element_from_buffer): Improve commentary for when
3032 the iterator is before prev_stop.
3033 (init_iterator): Initialize bidi_p from the default value of
3034 bidi-display-reordering, not from buffer-local value. Use the
3035 buffer-local value only if initializing for buffer iteration.
3036 (handle_invisible_prop): Support invisible properties on strings
3037 that are being bidi-reordered.
3038 (set_iterator_to_next): Support bidi reordering of C strings and
3039 Lisp strings.
3040 (next_element_from_string): Support bidi reordering of Lisp
3041 strings.
3042 (handle_stop_backwards): Support Lisp strings as well.
3043 (display_string): Support display of R2L glyph rows.
3044 Use IT_STRING_CHARPOS when displaying from a Lisp string.
3045 (init_iterator): Don't initialize it->bidi_p for strings
3046 here.
3047 (reseat_to_string): Initialize it->bidi_p for strings here.
3048 (next_element_from_string, next_element_from_c_string)
3049 (next_element_from_buffer): Add xassert's for correspondence
3050 between IT's object being iterated and it->bidi_it.string
3051 structure.
3052 (face_before_or_after_it_pos): Support bidi iteration.
3053 (next_element_from_c_string): Handle the case of the first string
3054 character that is not the first one in the visual order.
3055 (get_visually_first_element): New function, refactored from common
3056 parts of next_element_from_buffer, next_element_from_string, and
3057 next_element_from_c_string.
3058 (tool_bar_lines_needed, redisplay_tool_bar)
3059 (display_menu_bar): Force left-to-right direction. Add a FIXME
3060 comment for making that be controlled by a user option.
3061 (push_it, pop_it): Save and restore the state of the
3062 bidi iterator. Save and restore the bidi_p flag.
3063 (pop_it): Iterate out of display property for string iteration as
3064 well.
3065 (iterate_out_of_display_property): Support iteration over strings.
3066 (handle_single_display_spec): Set up it->bidi_it for iteration
3067 over a display string, and call bidi_init_it.
3068 (handle_single_display_spec, next_overlay_string)
3069 (get_overlay_strings_1, push_display_prop): Set up the bidi
3070 iterator for displaying display or overlay strings.
3071 (forward_to_next_line_start): Don't use the shortcut if
3072 bidi-iterating.
3073 (back_to_previous_visible_line_start): If handle_display_prop
3074 pushed the iterator stack, restore the internal state of the bidi
3075 iterator by calling bidi_pop_it same number of times.
3076 (reseat_at_next_visible_line_start): If ON_NEWLINE_P is non-zero,
3077 and we are bidi-iterating, don't decrement the iterator position;
3078 instead, set the first_elt flag in the bidi iterator, to produce
3079 the same effect.
3080 (reseat_1): Remove redundant setting of string_from_display_prop_p.
3081 (push_display_prop): xassert that we are iterating a buffer.
3082 (push_it, pop_it): Save and restore paragraph_embedding member.
3083 (handle_single_display_spec, next_overlay_string)
3084 (get_overlay_strings_1, reseat_1, reseat_to_string)
3085 (push_display_prop): Set up the `unibyte' member of bidi_it.string
3086 correctly. Don't assume unibyte strings are not bidi-reordered.
3087 (compute_display_string_pos)
3088 (compute_display_string_end): Fix handling the case of C string.
3089 (push_it, pop_it): Save and restore from_disp_prop_p.
3090 (handle_single_display_spec, push_display_prop): Set the
3091 from_disp_prop_p flag.
3092 (get_overlay_strings_1): Reset the from_disp_prop_p flag.
3093 (pop_it): Call iterate_out_of_display_property only if we are
3094 popping after iteration over a string that came from a display
3095 property. Fix a typo in popping stretch info. Add an assertion
3096 for verifying that the iterator position is in sync with the bidi
3097 iterator.
3098 (handle_single_display_spec, get_overlay_strings_1)
3099 (push_display_prop): Fix initialization of paragraph direction for
3100 string when that of the parent object is not yet determined.
3101 (reseat_1): Call bidi_init_it to resync the bidi
3102 iterator with IT's position. (Bug#7616)
3103 (find_row_edges): If ROW->start.pos gives position
3104 smaller than min_pos, use it as ROW->minpos. (Bug#7616)
3105 (handle_stop, back_to_previous_visible_line_start, reseat_1):
3106 Reset the from_disp_prop_p flag.
3107 (SAVE_IT, RESTORE_IT): New macros.
3108 (pos_visible_p, face_before_or_after_it_pos)
3109 (back_to_previous_visible_line_start)
3110 (move_it_in_display_line_to, move_it_in_display_line)
3111 (move_it_to, move_it_vertically_backward, move_it_by_lines)
3112 (try_scrolling, redisplay_window, display_line): Use them when
3113 saving a temporary copy of the iterator and restoring it back.
3114 (back_to_previous_visible_line_start, reseat_1)
3115 (init_iterator): Empty the bidi cache "stack".
3116 (move_it_in_display_line_to): If iterator ended up at
3117 EOL, but we never saw any buffer positions smaller than
3118 to_charpos, return MOVE_POS_MATCH_OR_ZV. Fixes vertical cursor
3119 motion in bidi-reordered lines.
3120 (move_it_in_display_line_to): Record prev_method and prev_pos
3121 immediately before the call to set_iterator_to_next. Fixes cursor
3122 motion in bidi-reordered lines with stretch glyphs and strings
3123 displayed in margins. (Bug#8133) (Bug#8867)
3124 Return MOVE_POS_MATCH_OR_ZV only if iterator position is past
3125 TO_CHARPOS.
3126 (pos_visible_p): Support positions in bidi-reordered lines.
3127 Save and restore bidi cache.
3128
3129 * bidi.c (bidi_level_of_next_char): clen should be EMACS_NT, not int.
3130 (bidi_paragraph_info): Delete unused struct.
3131 (bidi_cache_idx, bidi_cache_last_idx): Declare EMACS_INT.
3132 (bidi_cache_start): New variable.
3133 (bidi_cache_reset): Reset bidi_cache_idx to bidi_cache_start, not
3134 to zero.
3135 (bidi_cache_fetch_state, bidi_cache_search)
3136 (bidi_cache_find_level_change, bidi_cache_iterator_state)
3137 (bidi_cache_find, bidi_peek_at_next_level)
3138 (bidi_level_of_next_char, bidi_find_other_level_edge)
3139 (bidi_move_to_visually_next): Compare cache index with
3140 bidi_cache_start rather than with zero.
3141 (bidi_fetch_char): Accept new argument STRING; all callers
3142 changed. Support iteration over a string. Support strings with
3143 display properties. Support unibyte strings. Fix the type of
3144 `len' according to what STRING_CHAR_AND_LENGTH expects.
3145 (bidi_paragraph_init, bidi_resolve_explicit_1)
3146 (bidi_resolve_explicit, bidi_resolve_weak)
3147 (bidi_level_of_next_char, bidi_move_to_visually_next):
3148 Support iteration over a string.
3149 (bidi_set_sor_type, bidi_resolve_explicit_1)
3150 (bidi_resolve_explicit, bidi_type_of_next_char): ignore_bn_limit
3151 can now be zero (for strings); special values 0 and -1 were
3152 changed to -1 and -2, respectively.
3153 (bidi_char_at_pos): New function.
3154 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak):
3155 Call it instead of FETCH_MULTIBYTE_CHAR.
3156 (bidi_move_to_visually_next): Abort if charpos or bytepos were not
3157 initialized to valid values.
3158 (bidi_init_it): Don't initialize charpos and bytepos with invalid
3159 values.
3160 (bidi_level_of_next_char): Allow the sentinel "position" to pass
3161 the test for valid cached positions. Fix the logic for looking up
3162 the sentinel state in the cache. GCPRO the Lisp string we are
3163 iterating.
3164 (bidi_push_it, bidi_pop_it): New functions.
3165 (bidi_initialize): Initialize the bidi cache start stack pointer.
3166 (bidi_cache_ensure_space): New function, refactored from part of
3167 bidi_cache_iterator_state. Don't assume the required size is just
3168 one BIDI_CACHE_CHUNK away.
3169 (bidi_cache_start_stack, bidi_push_it): Use IT_STACK_SIZE.
3170 (bidi_count_bytes, bidi_char_at_pos): New functions.
3171 (bidi_cache_search): Don't assume bidi_cache_last_idx is
3172 always valid if bidi_cache_idx is valid.
3173 (bidi_cache_find_level_change): xassert that bidi_cache_last_idx
3174 is valid if it's going to be used.
3175 (bidi_shelve_cache, bidi_unshelve_cache): New functions.
3176 (bidi_cache_fetch_state, bidi_cache_search)
3177 (bidi_cache_find_level_change, bidi_cache_ensure_space)
3178 (bidi_cache_iterator_state, bidi_cache_find)
3179 (bidi_find_other_level_edge, bidi_cache_start_stack):
3180 All variables related to cache indices are now EMACS_INT.
3181
3182 * dispextern.h (struct bidi_string_data): New structure.
3183 (struct bidi_it): New member `string'. Make flag members be 1-bit
3184 fields, and put them last in the struct.
3185 (compute_display_string_pos, compute_display_string_end):
3186 Update prototypes.
3187 (bidi_push_it, bidi_pop_it): Add prototypes.
3188 (struct iterator_stack_entry): New members bidi_p,
3189 paragraph_embedding, and from_disp_prop_p.
3190 (struct it): Member bidi_p is now a bit field 1 bit wide.
3191 (bidi_shelve_cache, bidi_unshelve_cache):
3192 Declare prototypes.
3193
3194 * .gdbinit (xvectype, xvector, xcompiled, xchartable, xboolvector)
3195 (xpr, xfont, xbacktrace): Use "header.size" when accessing vectors
3196 and vector-like objects.
3197
3198 * dispnew.c (buffer_posn_from_coords): Save and restore the bidi
3199 cache around display iteration.
3200
3201 * window.c (Fwindow_end, window_scroll_pixel_based)
3202 (displayed_window_lines, Frecenter): Save and restore the bidi
3203 cache around display iteration.
3204
3205 2011-07-14 Lars Magne Ingebrigtsen <larsi@gnus.org>
3206
3207 * editfns.c (Fdelete_region): Clarify the use of the named
3208 parameters (bug#6788).
3209
3210 2011-07-14 Martin Rudalics <rudalics@gmx.at>
3211
3212 * indent.c (Fvertical_motion): Set and restore w->pointm when
3213 saving and restoring the window's buffer (Bug#9006).
3214
3215 2011-07-13 Lars Magne Ingebrigtsen <larsi@gnus.org>
3216
3217 * editfns.c (Fstring_to_char): Clarify just what is returned
3218 (bug#6576). Text by Eli Zaretskii.
3219
3220 2011-07-13 Juanma Barranquero <lekktu@gmail.com>
3221
3222 * gnutls.c (init_gnutls_functions): Honor gnutls_log_level (bug#9059).
3223
3224 2011-07-13 Eli Zaretskii <eliz@gnu.org>
3225
3226 * buffer.c (mmap_find): Fix a typo.
3227
3228 2011-07-13 Johan Bockgård <bojohan@gnu.org>
3229
3230 Fix execution of x selection hooks.
3231 * xselect.c (Qx_lost_selection_functions)
3232 (Qx_sent_selection_functions): New vars.
3233 (syms_of_xselect): DEFSYM them.
3234 (x_handle_selection_request): Pass Qx_sent_selection_functions
3235 rather than Vx_sent_selection_functions to Frun_hook_with_args.
3236 (x_handle_selection_clear,x_clear_frame_selections):
3237 Pass Qx_lost_selection_functions rather than
3238 Vx_lost_selection_functions to Frun_hook_with_args.
3239
3240 2011-07-13 Paul Eggert <eggert@cs.ucla.edu>
3241
3242 * buffer.c (Fget_buffer_create): Initialize inhibit_shrinking.
3243 The old code sometimes used this field without initializing it.
3244
3245 * alloc.c (gc_sweep): Don't read past end of array.
3246 In theory, the old code could also have corrupted Emacs internals,
3247 though it'd be very unlikely.
3248
3249 2011-07-12 Andreas Schwab <schwab@linux-m68k.org>
3250
3251 * character.c (Fcharacterp): Don't advertise optional ignored
3252 argument. (Bug#4026)
3253
3254 2011-07-12 Lars Magne Ingebrigtsen <larsi@gnus.org>
3255
3256 * keymap.c (syms_of_keymap): Clarify that "modifier" is "modifier
3257 key" (bug#4257).
3258
3259 * window.c (Fset_window_start): Doc fix (bug#4199).
3260 (Fset_window_hscroll): Ditto.
3261
3262 2011-07-12 Paul Eggert <eggert@cs.ucla.edu>
3263
3264 Fix minor new problems caught by GCC 4.6.1.
3265 * term.c (init_tty): Remove unused local.
3266 * xsettings.c (store_monospaced_changed): Define this function only
3267 if (defined HAVE_GSETTINGS || defined HAVE_GCONF), as it's
3268 not used otherwise.
3269
3270 2011-07-12 Chong Yidong <cyd@stupidchicken.com>
3271
3272 * xdisp.c (Vresize_mini_windows): Minor doc fix (Bug#3300).
3273
3274 2011-07-11 Lars Magne Ingebrigtsen <larsi@gnus.org>
3275
3276 * xdisp.c (syms_of_xdisp): Make it explicit that the mini-windows
3277 are the mini-buffer and the echo area (bug#3320).
3278
3279 * term.c (init_tty): Remove support for supdup, c10 and perq
3280 terminals, which are no longer supported (bug#1482).
3281
3282 2011-07-10 Johan Bockgård <bojohan@gnu.org>
3283
3284 * xdisp.c (Ftool_bar_lines_needed): Fix WINDOWP check.
3285
3286 2011-07-10 Jan Djärv <jan.h.d@swipnet.se>
3287
3288 * xmenu.c (menu_highlight_callback): Only pass frame to show_help_event
3289 for non-popups (Bug#3642).
3290
3291 2011-07-10 Andreas Schwab <schwab@linux-m68k.org>
3292
3293 * alloc.c (reset_malloc_hooks): Protoize.
3294 * buffer.c (mmap_init, mmap_find, mmap_free_1, mmap_enlarge)
3295 (mmap_set_vars, mmap_alloc, mmap_free, mmap_realloc): Likewise.
3296 * cm.c (losecursor): Likewise.
3297 * data.c (fmod): Likewise.
3298 * dispnew.c (swap_glyphs_in_rows): Likewise.
3299 * emacs.c (memory_warning_signal): Likewise.
3300 * floatfns.c (float_error): Likewise.
3301 * font.c (check_gstring, check_otf_features, otf_tag_symbol)
3302 (otf_open, font_otf_capability, generate_otf_features)
3303 (font_otf_DeviceTable, font_otf_ValueRecord, font_otf_Anchor):
3304 Likewise.
3305 * image.c (pbm_read_file): Likewise.
3306 * indent.c (string_display_width): Likewise.
3307 * intervals.c (check_for_interval, search_for_interval)
3308 (inc_interval_count, count_intervals, root_interval)
3309 (adjust_intervals_for_insertion, make_new_interval): Likewise.
3310 * lread.c (defalias): Likewise.
3311 * ralloc.c (r_alloc_check): Likewise.
3312 * regex.c (set_image_of_range_1, set_image_of_range)
3313 (regex_grow_registers): Likewise.
3314 * sysdep.c (strerror): Likewise.
3315 * termcap.c (valid_filename_p, tprint, main): Likewise.
3316 * tparam.c (main): Likewise.
3317 * unexhp9k800.c (run_time_remap, save_data_space)
3318 (update_file_ptrs, read_header, write_header, calculate_checksum)
3319 (copy_file, copy_rest, display_header): Likewise.
3320 * widget.c (mark_shell_size_user_specified, create_frame_gcs):
3321 Likewise.
3322 * xdisp.c (check_it): Likewise.
3323 * xfaces.c (register_color, unregister_color, unregister_colors):
3324 Likewise.
3325 * xfns.c (print_fontset_result): Likewise.
3326 * xrdb.c (member, fatal, main): Likewise.
3327
3328 2011-07-10 Paul Eggert <eggert@cs.ucla.edu>
3329
3330 Fix minor problems found by static checking (Bug#9031).
3331 * chartab.c (char_table_set_range, map_sub_char_table):
3332 Remove unused locals.
3333 (uniprop_table): Now static.
3334 * composite.c (_work_char): Remove unused static var.
3335
3336 2011-07-09 Juanma Barranquero <lekktu@gmail.com>
3337
3338 * chartab.c (uniprop_table_uncompress): Remove unused local variable.
3339
3340 2011-07-09 Jan Djärv <jan.h.d@swipnet.se>
3341
3342 * gtkutil.c (qttip_cb): Remove code without function.
3343
3344 2011-07-09 Eli Zaretskii <eliz@gnu.org>
3345
3346 * w32.c (pthread_sigmask): New stub.
3347
3348 2011-07-08 Paul Eggert <eggert@cs.ucla.edu>
3349
3350 Use pthread_sigmask, not sigprocmask (Bug#9010).
3351 sigprocmask is portable only for single-threaded applications, and
3352 Emacs can be multi-threaded when it uses GTK.
3353 * Makefile.in (LIB_PTHREAD_SIGMASK): New macro.
3354 (LIBES): Use it.
3355 * callproc.c (Fcall_process):
3356 * process.c (create_process):
3357 * sysdep.c (sys_sigblock, sys_sigunblock, sys_sigsetmask):
3358 Use pthread_sigmask, not sigprocmask.
3359
3360 2011-07-08 Jan Djärv <jan.h.d@swipnet.se>
3361
3362 * gtkutil.c (qttip_cb): Set line wrap to FALSE for tooltip widget.
3363 (xg_prepare_tooltip): Revert text in x->ttip_lbl, margins was
3364 wrong (Bug#8591).
3365
3366 2011-07-08 Jan Djärv <jan.h.d@swipnet.se>
3367
3368 * gtkutil.c (xg_prepare_tooltip): Fix indentation and comment.
3369 Put text in x->ttip_lbl instead of gtk_tooltip_set_text (Bug#8591).
3370 (xg_hide_tooltip): Fix comment.
3371
3372 * nsterm.m (initFrameFromEmacs): Don't use ns_return_types
3373 in registerServicesMenuSendTypes.
3374 (validRequestorForSendType): Don't check ns_return_types.
3375
3376 * nsfns.m (Fx_open_connection): Put NSStringPboardType into
3377 ns_return_type.
3378
3379 2011-07-08 Jason Rumney <jasonr@gnu.org>
3380
3381 * w32term.c (x_make_frame_visible): Use SH_SHOWNORMAL rather than
3382 SH_SHOW for hidden windows (Bug#5482).
3383
3384 * w32fns.c (w32_wnd_proc) [WM_TIMER, WM_SET_CURSOR]: Avoid using
3385 frame struct members of non-existent frames (Bug#6284).
3386
3387 2011-07-08 Jan Djärv <jan.h.d@swipnet.se>
3388
3389 * nsterm.m (keyDown): Call to wantsToDelayTextChangeNotifications and
3390 variable firstTime not needed on OSX >= 10.6.
3391 (setPosition): setFloatValue:knobProportion: is deprecated on OSX
3392 >= 10.5. Use setKnobProportion, setDoubleValue.
3393
3394 * nsterm.h (MAC_OS_X_VERSION_10_3, MAC_OS_X_VERSION_10_4)
3395 (MAC_OS_X_VERSION_10_5): Define if not defined.
3396 (EmacsView, EmacsTooltip): Implements NSWindowDelegate on OSX >= 10.6.
3397 (EmacsMenu): Implements NSMenuDelegate on OSX >= 10.6.
3398 (EmacsToolbar): Implements NSToolbarDelegate on OSX >= 10.6.
3399
3400 * nsselect.m (ns_string_from_pasteboard): Don't use deprecated methods
3401 cString and lossyCString on OSX >= 10.4
3402
3403 * nsmenu.m (fillWithWidgetValue): Don't use deprecated method
3404 sizeToFit on OSX >= 10.2.
3405
3406 * nsimage.m (allocInitFromFile): Don't use deprecated method
3407 bestRepresentationForDevice on OSX >= 10.6.
3408
3409 * nsfns.m (check_ns_display_info): Cast to long and use %ld in error
3410 to avoid warning.
3411
3412 * emacs.c: Declare unexec_init_emacs_zone.
3413
3414 * nsgui.h: Fix compiler warning about gnulib redefining verify.
3415
3416 * nsselect.m (ns_get_local_selection): Change to extern (Bug#8842).
3417
3418 * nsmenu.m (ns_update_menubar): Remove useless setDelegate call
3419 on svcsMenu (Bug#8842).
3420
3421 * nsfns.m (Fx_open_connection): Remove NSStringPboardType from
3422 ns_return_types.
3423 (Fns_list_services): Just return Qnil on 10.6, code not working there.
3424
3425 * nsterm.m (QUTF8_STRING): Declare.
3426 (initFrameFromEmacs): Call registerServicesMenuSendTypes.
3427 (validRequestorForSendType): Return type is (id).
3428 Change indexOfObjectIdenticalTo to indexOfObject.
3429 Check if we have local selection before returning self (Bug#8842).
3430 (writeSelectionToPasteboard): Put local selection into paste board
3431 if we have a local selection (Bug#8842).
3432 (syms_of_nsterm): DEFSYM QUTF8_STRING.
3433
3434 * nsterm.h (MAC_OS_X_VERSION_10_6): Define here instead of nsterm.m.
3435 (ns_get_local_selection): Declare.
3436
3437 2011-07-07 Lars Magne Ingebrigtsen <larsi@gnus.org>
3438
3439 * keymap.c (describe_map_tree): Don't insert a double newline at
3440 the end of the buffer (bug#1169) and return whether we inserted
3441 something.
3442
3443 * callint.c (Fcall_interactively): Change "reading args" to
3444 "providing args" to try to clarify what it does (bug#1010).
3445
3446 2011-07-07 Kenichi Handa <handa@m17n.org>
3447
3448 * composite.c (composition_compute_stop_pos): Ignore a static
3449 composition starting before CHARPOS (Bug#8915).
3450
3451 * xdisp.c (handle_composition_prop): Likewise.
3452
3453 2011-07-07 Eli Zaretskii <eliz@gnu.org>
3454
3455 * term.c (produce_glyphs) <xassert>: Allow IT_GLYPHLESS in it->what.
3456 (Bug#9015)
3457
3458 2011-07-07 Kenichi Handa <handa@m17n.org>
3459
3460 * character.h (unicode_category_t): New enum type.
3461
3462 * chartab.c (uniprop_decoder_t, uniprop_encoder_t): New types.
3463 (Qchar_code_property_table): New variable.
3464 (UNIPROP_TABLE_P, UNIPROP_GET_DECODER)
3465 (UNIPROP_COMPRESSED_FORM_P): New macros.
3466 (char_table_ascii): Uncompress the compressed values.
3467 (sub_char_table_ref): New arg is_uniprop. Callers changed.
3468 Uncompress the compressed values.
3469 (sub_char_table_ref_and_range): Likewise.
3470 (char_table_ref_and_range): Uncompress the compressed values.
3471 (sub_char_table_set): New arg is_uniprop. Callers changed.
3472 Uncompress the compressed values.
3473 (sub_char_table_set_range): Args changed. Callers changed.
3474 (char_table_set_range): Adjuted for the above change.
3475 (map_sub_char_table): Delete args default_val and parent. Add arg
3476 top. Give decoded values to a Lisp function.
3477 (map_char_table): Adjust for the above change. Give decoded
3478 values to a Lisp function. Gcpro more variables.
3479 (uniprop_table_uncompress)
3480 (uniprop_decode_value_run_length): New functions.
3481 (uniprop_decoder, uniprop_decoder_count): New variables.
3482 (uniprop_get_decoder, uniprop_encode_value_character)
3483 (uniprop_encode_value_run_length, uniprop_encode_value_numeric):
3484 New functions.
3485 (uniprop_encoder, uniprop_encoder_count): New variables.
3486 (uniprop_get_encoder, uniprop_table)
3487 (Funicode_property_table_internal, Fget_unicode_property_internal)
3488 (Fput_unicode_property_internal): New functions.
3489 (syms_of_chartab): DEFSYM Qchar_code_property_table, defsubr
3490 Sunicode_property_table_internal, Sget_unicode_property_internal,
3491 and Sput_unicode_property_internal. Defvar_lisp
3492 char-code-property-alist.
3493
3494 * composite.c (CHAR_COMPOSABLE_P): Adjust for the change of
3495 Vunicode_category_table.
3496
3497 * font.c (font_range): Adjust for the change of
3498 Vunicode_category_table.
3499
3500 2011-07-07 Dan Nicolaescu <dann@ics.uci.edu>
3501
3502 * m/iris4d.h: Remove file, move contents ...
3503 * s/irix6-5.h: ... here.
3504
3505 2011-07-06 Paul Eggert <eggert@cs.ucla.edu>
3506
3507 Remove unportable assumption about struct layout (Bug#8884).
3508 * alloc.c (mark_buffer):
3509 * buffer.c (reset_buffer_local_variables, Fbuffer_local_variables)
3510 (clone_per_buffer_values): Don't assume that
3511 sizeof (struct buffer) is a multiple of sizeof (Lisp_Object).
3512 This isn't true in general, and it's particularly not true
3513 if Emacs is configured with --with-wide-int.
3514 * buffer.h (FIRST_FIELD_PER_BUFFER, LAST_FIELD_PER_BUFFER):
3515 New macros, used in the buffer.c change.
3516
3517 2011-07-05 Jan Djärv <jan.h.d@swipnet.se>
3518
3519 * xsettings.c: Use both GConf and GSettings if both are available.
3520 (store_config_changed_event): Add comment.
3521 (dpyinfo_valid, store_font_name_changed, map_tool_bar_style)
3522 (store_tool_bar_style_changed): New functions.
3523 (store_monospaced_changed): Add comment. Call dpyinfo_valid.
3524 (struct xsettings): Move font inside HAVE_XFT.
3525 (GSETTINGS_TOOL_BAR_STYLE, GSETTINGS_FONT_NAME): New defines.
3526 (GSETTINGS_MONO_FONT): Rename from SYSTEM_MONO_FONT.
3527 Move inside HAVE_XFT.
3528 (something_changed_gsettingsCB): Rename from something_changedCB.
3529 Check for changes in GSETTINGS_TOOL_BAR_STYLE and GSETTINGS_FONT_NAME
3530 also.
3531 (GCONF_TOOL_BAR_STYLE, GCONF_FONT_NAME): New defines.
3532 (GCONF_MONO_FONT): Rename from SYSTEM_MONO_FONT. Move inside HAVE_XFT.
3533 (something_changed_gconfCB): Rename from something_changedCB.
3534 Check for changes in GCONF_TOOL_BAR_STYLE and GCONF_FONT_NAME also.
3535 (parse_settings): Move check for font inside HAVE_XFT.
3536 (read_settings, apply_xft_settings): Add comment.
3537 (read_and_apply_settings): Add comment. Call map_tool_bar_style and
3538 store_tool_bar_style_changed. Move check for font inside HAVE_XFT and
3539 call store_font_name_changed.
3540 (xft_settings_event): Add comment.
3541 (init_gsettings): Add comment. Get values for GSETTINGS_TOOL_BAR_STYLE
3542 and GSETTINGS_FONT_NAME. Move check for fonts within HAVE_XFT.
3543 (init_gconf): Add comment. Get values for GCONF_TOOL_BAR_STYLE
3544 and GCONF_FONT_NAME. Move check for fonts within HAVE_XFT.
3545 (xsettings_initialize): Call init_gsettings last.
3546 (xsettings_get_system_font, xsettings_get_system_normal_font):
3547 Add comment.
3548
3549 2011-07-05 Paul Eggert <eggert@cs.ucla.edu>
3550
3551 Random fixes. E.g., (random) never returned negative values.
3552 * fns.c (Frandom): Use GET_EMACS_TIME for random seed, and add the
3553 subseconds part to the entropy, as that's a bit more random.
3554 Prefer signed to unsigned, since the signedness doesn't matter and
3555 in general we prefer signed. When given a limit, use a
3556 denominator equal to INTMASK + 1, not to VALMASK + 1, because the
3557 latter isn't right if USE_2_TAGS_FOR_INTS.
3558 * sysdep.c (get_random): Return a value in the range 0..INTMASK,
3559 not 0..VALMASK. Don't discard "excess" bits that random () returns.
3560
3561 2011-07-04 Stefan Monnier <monnier@iro.umontreal.ca>
3562
3563 * textprop.c (text_property_stickiness):
3564 Obey Vtext_property_default_nonsticky.
3565 (syms_of_textprop): Add `display' to Vtext_property_default_nonsticky.
3566 * w32fns.c (syms_of_w32fns):
3567 * xfns.c (syms_of_xfns): Don't Add `display' since it's there by default.
3568
3569 2011-07-04 Paul Eggert <eggert@cs.ucla.edu>
3570
3571 * fileio.c (barf_or_query_if_file_exists): Use S_ISDIR.
3572 This is more efficient than Ffile_directory_p and avoids a minor race.
3573
3574 2011-07-04 Lars Magne Ingebrigtsen <larsi@gnus.org>
3575
3576 * buffer.c (Foverlay_put): Say what the return value is
3577 (bug#7835).
3578
3579 * fileio.c (barf_or_query_if_file_exists): Check first if the file
3580 is a directory before asking whether to use the file name
3581 (bug#7564).
3582 (barf_or_query_if_file_exists): Make the "File is a directory"
3583 error be more correct.
3584
3585 * fns.c (Frequire): Remove the mention of the .gz files, since
3586 that's installation-specific, but keep the mention of
3587 `get-load-suffixes'.
3588
3589 2011-07-04 Paul Eggert <eggert@cs.ucla.edu>
3590
3591 * editfns.c (Fformat_time_string): Don't assume strlen fits in int.
3592 Report string overflow if the output is too long.
3593
3594 2011-07-04 Juanma Barranquero <lekktu@gmail.com>
3595
3596 * gnutls.c (Fgnutls_boot): Don't mention :verify-error.
3597 (syms_of_gnutls): Remove duplicate DEFSYM for
3598 Qgnutls_bootprop_verify_hostname_error, an error for
3599 Qgnutls_bootprop_verify_error (which is no longer used).
3600
3601 * eval.c (find_handler_clause): Remove parameters `sig' and `data',
3602 unused since 2011-01-26T20:02:07Z!monnier@iro.umontreal.ca. All callers changed.
3603 Also (re)move comments that are misplaced or no longer relevant.
3604
3605 2011-07-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
3606
3607 * callint.c (Finteractive): Clarify the meaning of "@" (bug#8813).
3608
3609 2011-07-03 Chong Yidong <cyd@stupidchicken.com>
3610
3611 * xfaces.c (Finternal_merge_in_global_face): Modify the foreground
3612 and background color parameters if they have been changed.
3613
3614 2011-07-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
3615
3616 * editfns.c (Fformat): Clarify the - and 0 flags (bug#6659).
3617
3618 2011-07-03 Paul Eggert <eggert@cs.ucla.edu>
3619
3620 * xsettings.c (SYSTEM_FONT): Define only when used.
3621 No need to define when HAVE_GSETTINGS || !HAVE_XFT.
3622
3623 * keymap.c (access_keymap_1): Now static.
3624
3625 2011-07-02 Chong Yidong <cyd@stupidchicken.com>
3626
3627 * keyboard.c (command_loop_1): If a down-mouse event is unbound,
3628 leave any prefix arg for the up event (Bug#1586).
3629
3630 2011-07-02 Lars Magne Ingebrigtsen <larsi@gnus.org>
3631
3632 * lread.c (syms_of_lread): Mention single symbols defined by
3633 `defvar' or `defconst' (bug#7154).
3634
3635 * fns.c (Frequire): Mention .el.gz files (bug#7314).
3636 (Frequire): Mention get-load-suffixes.
3637
3638 2011-07-02 Martin Rudalics <rudalics@gmx.at>
3639
3640 * window.h (window): Remove clone_number slot.
3641 * window.c (Fwindow_clone_number, Fset_window_clone_number):
3642 Remove.
3643 (make_parent_window, make_window, saved_window)
3644 (Fset_window_configuration, save_window_save): Don't deal with
3645 clone numbers.
3646 * buffer.c (Qclone_number): Remove declaration.
3647 (sort_overlays, overlay_strings): Don't deal with clone numbers.
3648
3649 2011-07-02 Stefan Monnier <monnier@iro.umontreal.ca>
3650
3651 Add multiple inheritance to keymaps.
3652 * keymap.c (Fmake_composed_keymap): New function.
3653 (Fset_keymap_parent): Simplify.
3654 (fix_submap_inheritance): Remove.
3655 (access_keymap_1): New function extracted from access_keymap to handle
3656 embedded parents and handle lists of maps.
3657 (access_keymap): Use it.
3658 (Fkeymap_prompt, map_keymap_internal, map_keymap, store_in_keymap)
3659 (Fcopy_keymap): Handle embedded parents.
3660 (Fcommand_remapping, define_as_prefix): Simplify.
3661 (Fkey_binding): Simplify.
3662 (syms_of_keymap): Move minibuffer-local-completion-map,
3663 minibuffer-local-filename-completion-map,
3664 minibuffer-local-must-match-map, and
3665 minibuffer-local-filename-must-match-map to Elisp.
3666 (syms_of_keymap): Defsubr make-composed-keymap.
3667 * keyboard.c (menu_bar_items): Use map_keymap_canonical.
3668 (parse_menu_item): Trivial simplification.
3669
3670 2011-07-01 Glenn Morris <rgm@gnu.org>
3671
3672 * Makefile.in (SETTINGS_LIBS): Fix typo.
3673
3674 2011-07-01 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny patch)
3675
3676 * coding.c (Fencode_coding_string): Record the last coding system
3677 used, as the function doc string says (bug#8738).
3678
3679 2011-07-01 Jan Djärv <jan.h.d@swipnet.se>
3680
3681 * xsettings.c (store_monospaced_changed): Take new font as arg and
3682 check for change against current_mono_font.
3683 (EMACS_TYPE_SETTINGS): Remove this and related defines.
3684 (emacs_settings_constructor, emacs_settings_get_property)
3685 (emacs_settings_set_property, emacs_settings_class_init)
3686 (emacs_settings_init, gsettings_obj): Remove.
3687 (something_changedCB): New function for HAVE_GSETTINGS.
3688 (something_changedCB): HAVE_GCONF: Call store_monospaced_changed
3689 with value as argument.
3690 (init_gsettings): Check that GSETTINGS_SCHEMA exists before calling
3691 g_settings_new (Bug#8967). Do not create gsettings_obj.
3692 Remove calls to g_settings_bind. Connect something_changedCB to
3693 "changed".
3694
3695 * xgselect.c: Add defined (HAVE_GSETTINGS).
3696 (xgselect_initialize): Ditto.
3697
3698 * process.c: Add defined (HAVE_GSETTINGS) for xgselect.h
3699 (wait_reading_process_output): Add defined (HAVE_GSETTINGS) for
3700 xg_select.
3701
3702 2011-07-01 Paul Eggert <eggert@cs.ucla.edu>
3703
3704 * eval.c (struct backtrace): Simplify and port the data structure.
3705 Do not assume that "int nargs : BITS_PER_INT - 2;" produces a
3706 signed bit field, as this assumption is not portable and it makes
3707 Emacs crash when compiled with Sun C 5.8 on sparc. Do not use
3708 "char debug_on_exit : 1" as this is not portable either; instead,
3709 use the portable "unsigned int debug_on_exit : 1". Remove unused
3710 member evalargs. Remove obsolete comments about cc bombing out.
3711
3712 2011-06-30 Jan Djärv <jan.h.d@swipnet.se>
3713
3714 * xsettings.c: Include glib-object.h, gio/gio.h if HAVE_GSETTINGS.
3715 Let HAVE_GSETTINGS override HAVE_GCONF.
3716 (store_monospaced_changed): New function.
3717 (EMACS_SETTINGS): A new type derived from GObject to handle
3718 GSettings notifications.
3719 (emacs_settings_constructor, emacs_settings_get_property)
3720 (emacs_settings_set_property, emacs_settings_class_init):
3721 New functions.
3722 (gsettings_client, gsettings_obj): New variables.
3723 (GSETTINGS_SCHEMA): New define.
3724 (something_changedCB): Call store_monospaced_changed.
3725 (init_gsettings): New function.
3726 (xsettings_initialize): Call init_gsettings.
3727 (syms_of_xsettings): Initialize gsettings_client, gsettings_obj
3728 to NULL.
3729
3730 * Makefile.in (SETTINGS_CFLAGS, SETTINGS_LIBS): Rename from
3731 GCONF_CFLAGS/LIBS.
3732
3733 2011-06-29 Martin Rudalics <rudalics@gmx.at>
3734
3735 * window.c (resize_root_window, grow_mini_window)
3736 (shrink_mini_window): Rename Qresize_root_window to
3737 Qwindow_resize_root_window and Qresize_root_window_vertically to
3738 Qwindow_resize_root_window_vertically.
3739
3740 2011-06-28 Paul Eggert <eggert@cs.ucla.edu>
3741
3742 * gnutls.c (Qgnutls_bootprop_verify_error): Remove unused var.
3743
3744 2011-06-27 Juanma Barranquero <lekktu@gmail.com>
3745
3746 * makefile.w32-in: Redesign dependencies so they reflect more
3747 clearly which files are directly included by each source file,
3748 and not through other includes.
3749
3750 2011-06-27 Martin Rudalics <rudalics@gmx.at>
3751
3752 * buffer.c (Qclone_number): Declare static and DEFSYM it.
3753 (sort_overlays, overlay_strings): When an overlay's clone number
3754 matches the window's clone number process the overlay even if
3755 the overlay's window property doesn't match the current window.
3756
3757 * window.c (Fwindow_vchild): Rename to Fwindow_top_child.
3758 (Fwindow_hchild): Rename to Fwindow_left_child.
3759 (Fwindow_next): Rename to Fwindow_next_sibling.
3760 (Fwindow_prev): Rename to Fwindow_prev_sibling.
3761 (resize_window_check): Rename to window_resize_check.
3762 (resize_window_apply): Rename to window_resize_apply.
3763 (Fresize_window_apply): Rename to Fwindow_resize_apply.
3764 (Fdelete_other_windows_internal, resize_frame_windows)
3765 (Fsplit_window_internal, Fdelete_window_internal)
3766 (grow_mini_window, shrink_mini_window)
3767 (Fresize_mini_window_internal): Fix callers accordingly.
3768
3769 2011-06-26 Jan Djärv <jan.h.d@swipnet.se>
3770
3771 * emacsgtkfixed.h: State that this is only used with Gtk+3.
3772 (emacs_fixed_set_min_size): Remove.
3773 (emacs_fixed_new): Take frame as argument.
3774
3775 * emacsgtkfixed.c: State that this is only used with Gtk+3.
3776 (_EmacsFixedPrivate): Remove minwidth/height.
3777 Add struct frame *f.
3778 (emacs_fixed_init): Initialize priv->f.
3779 (get_parent_class, emacs_fixed_set_min_size): Remove.
3780 (emacs_fixed_new): Set priv->f to argument.
3781 (emacs_fixed_get_preferred_width)
3782 (emacs_fixed_get_preferred_height): Use min_width/height from
3783 frames size_hint to set minimum and natural (Bug#8919).
3784 (XSetWMSizeHints, XSetWMNormalHints): Override these functions
3785 and use min_width/height from frames size_hint to set
3786 min_width/height (Bug#8919).
3787
3788 * gtkutil.c (xg_create_frame_widgets): Pass f to emacs_fixed_new.
3789 (x_wm_set_size_hint): Remove call to emacs_fixed_set_min_size.
3790 Fix indentation.
3791
3792 2011-06-26 Eli Zaretskii <eliz@gnu.org>
3793
3794 * bidi.c (bidi_paragraph_init): Test for ZV_BYTE before calling
3795 bidi_at_paragraph_end, since fast_looking_at doesn't like to be
3796 called at ZV.
3797
3798 2011-06-26 Chong Yidong <cyd@stupidchicken.com>
3799
3800 * process.c (wait_reading_process_output): Bypass select if
3801 waiting for a cell while ignoring keyboard input, and input is
3802 pending. Suggested by Jan Djärv (Bug#8869).
3803
3804 2011-06-25 Paul Eggert <eggert@cs.ucla.edu>
3805
3806 Use gnulib's dup2 module instead of rolling our own.
3807 * sysdep.c (dup2) [!HAVE_DUP2]: Remove; gnulib now does this.
3808
3809 2011-06-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
3810
3811 * dispnew.c (scrolling_window): Before scrolling, turn off a
3812 mouse-highlight in the window being scrolled.
3813
3814 2011-06-24 Juanma Barranquero <lekktu@gmail.com>
3815
3816 Move DEFSYM to lisp.h and use everywhere.
3817
3818 * character.h (DEFSYM): Move declaration...
3819 * lisp.h (DEFSYM): ...here.
3820
3821 * gnutls.c:
3822 * minibuf.c:
3823 * w32menu.c:
3824 * w32proc.c:
3825 * w32select.c: Don't include character.h.
3826
3827 * alloc.c (syms_of_alloc):
3828 * buffer.c (syms_of_buffer):
3829 * bytecode.c (syms_of_bytecode):
3830 * callint.c (syms_of_callint):
3831 * casefiddle.c (syms_of_casefiddle):
3832 * casetab.c (init_casetab_once):
3833 * category.c (init_category_once, syms_of_category):
3834 * ccl.c (syms_of_ccl):
3835 * cmds.c (syms_of_cmds):
3836 * composite.c (syms_of_composite):
3837 * dbusbind.c (syms_of_dbusbind):
3838 * dired.c (syms_of_dired):
3839 * dispnew.c (syms_of_display):
3840 * doc.c (syms_of_doc):
3841 * editfns.c (syms_of_editfns):
3842 * emacs.c (syms_of_emacs):
3843 * eval.c (syms_of_eval):
3844 * fileio.c (syms_of_fileio):
3845 * fns.c (syms_of_fns):
3846 * frame.c (syms_of_frame):
3847 * fringe.c (syms_of_fringe):
3848 * insdel.c (syms_of_insdel):
3849 * keymap.c (syms_of_keymap):
3850 * lread.c (init_obarray, syms_of_lread):
3851 * macros.c (syms_of_macros):
3852 * msdos.c (syms_of_msdos):
3853 * print.c (syms_of_print):
3854 * process.c (syms_of_process):
3855 * search.c (syms_of_search):
3856 * sound.c (syms_of_sound):
3857 * syntax.c (init_syntax_once, syms_of_syntax):
3858 * terminal.c (syms_of_terminal):
3859 * textprop.c (syms_of_textprop):
3860 * undo.c (syms_of_undo):
3861 * w32.c (globals_of_w32):
3862 * window.c (syms_of_window):
3863 * xdisp.c (syms_of_xdisp):
3864 * xfaces.c (syms_of_xfaces):
3865 * xfns.c (syms_of_xfns):
3866 * xmenu.c (syms_of_xmenu):
3867 * xsettings.c (syms_of_xsettings):
3868 * xterm.c (syms_of_xterm): Use DEFSYM.
3869
3870 2011-06-24 Teodor Zlatanov <tzz@lifelogs.com>
3871
3872 * gnutls.c (syms_of_gnutls): Use the DEFSYM macro from character.h.
3873
3874 2011-06-23 Paul Eggert <eggert@cs.ucla.edu>
3875
3876 Integer and buffer overflow fixes (Bug#8873).
3877
3878 * print.c (printchar, strout): Check for string overflow.
3879 (PRINTPREPARE, printchar, strout):
3880 Don't set size unless allocation succeeds.
3881
3882 * minibuf.c (read_minibuf_noninteractive): Use ptrdiff_t, not int,
3883 for sizes. Check for string overflow more accurately.
3884 Simplify newline removal at end; this suppresses a GCC 4.6.0 warning.
3885
3886 * macros.c: Integer and buffer overflow fixes.
3887 * keyboard.h (struct keyboard.kbd_macro_bufsize):
3888 * macros.c (Fstart_kbd_macro, store_kbd_macro_char):
3889 Use ptrdiff_t, not int, for sizes.
3890 Don't increment bufsize until after realloc succeeds.
3891 Check for size-calculation overflow.
3892 (Fstart_kbd_macro): Use EMACS_INT, not int, for XINT result.
3893
3894 * lisp.h (DEFVAR_KBOARD): Use offsetof instead of char * finagling.
3895
3896 * lread.c: Integer overflow fixes.
3897 (read_integer): Radix is now EMACS_INT, not int,
3898 to improve quality of diagnostics for out-of-range radices.
3899 Calculate buffer size correctly for out-of-range radices.
3900 (read1): Check for integer overflow in radices, and in
3901 read-circle numbers.
3902 (read_escape): Avoid int overflow.
3903 (Fload, openp, read_buffer_size, read1)
3904 (substitute_object_recurse, read_vector, read_list, map_obarray):
3905 Use ptrdiff_t, not int, for sizes.
3906 (read1): Use EMACS_INT, not int, for sizes.
3907 Check for size overflow.
3908
3909 * image.c (cache_image): Check for size arithmetic overflow.
3910
3911 * lread.c: Integer overflow issues.
3912 (saved_doc_string_size, saved_doc_string_length)
3913 (prev_saved_doc_string_size, prev_saved_doc_string_length):
3914 Now ptrdiff_t, not int.
3915 (read1): Don't assume doc string length fits in int. Check for
3916 out-of-range doc string lengths.
3917 (read_list): Don't assume file position fits in int.
3918 (read_escape): Check for hex character overflow.
3919
3920 2011-06-22 Leo Liu <sdl.web@gmail.com>
3921
3922 * minibuf.c (Fcompleting_read_default, Vcompleting_read_function):
3923 Move to minibuffer.el.
3924
3925 2011-06-22 Paul Eggert <eggert@cs.ucla.edu>
3926
3927 Fixes for GLYPH_DEBUG found by GCC 4.6.0 static checking.
3928 The following patches are for when GLYPH_DEBUG && !XASSERT.
3929 * dispextern.h (trace_redisplay_p, dump_glyph_string):
3930 * dispnew.c (flush_stdout):
3931 * xdisp.c (dump_glyph_row, dump_glyph_matrix, dump_glyph):
3932 Mark as externally visible.
3933 * dispnew.c (check_window_matrix_pointers): Now static.
3934 * dispnew.c (window_to_frame_vpos):
3935 * xfns.c (unwind_create_frame):
3936 * xterm.c (x_check_font): Remove unused local.
3937 * scroll.c (CHECK_BOUNDS):
3938 * xfaces.c (cache_fache): Rename local to avoid shadowing.
3939 * xfns.c, w32fns.c (image_cache_refcount, dpyinfo_refcount): Now static.
3940 * xdisp.c (check_window_end): Now a no-op if !XASSERTS.
3941 (debug_first_unchanged_at_end_vpos, debug_last_unchanged_at_beg_vpos)
3942 (debug_dvpos, debug_dy, debug_delta, debug_delta_bytes, debug_end_vpos):
3943 Now static.
3944 (debug_method_add): Use va_list and vsprintf rather than relying
3945 on undefined behavior with wrong number of arguments.
3946 (dump_glyph, dump_glyph_row, Fdump_glyph_matrix):
3947 Don't assume ptrdiff_t and EMACS_INT are the same width as int.
3948 In this code, it's OK to assume C99 behavior for ptrdiff_t formats
3949 since we're not interested in debugging glyphs with old libraries.
3950 * xfaces.c (cache_face): Move debugging code earlier; this pacifies
3951 GCC 4.6.0's static checking.
3952
3953 2011-06-22 Paul Eggert <eggert@cs.ucla.edu>
3954
3955 Integer overflow and signedness fixes (Bug#8873).
3956 A few related buffer overrun fixes, too.
3957
3958 * font.c (font_score): Use EMACS_INT, not int, to store XINT value.
3959
3960 * dispextern.h (struct face.stipple):
3961 * image.c (x_bitmap_height, x_bitmap_width, x_bitmap_pixmap)
3962 (x_bitmap_mask, x_allocate_bitmap_record)
3963 (x_create_bitmap_from_data, x_create_bitmap_from_file)
3964 (x_destroy_bitmap, x_destroy_all_bitmaps, x_create_bitmap_mask)
3965 (x_create_bitmap_from_xpm_data):
3966 * nsterm.h (struct ns_display_info.bitmaps_size, .bitmaps_last):
3967 * w32term.h (struct w32_display_info.icon_bitmap_id, .bitmaps_size)
3968 (.bitmaps_last):
3969 * xfaces.c (load_pixmap):
3970 * xterm.c (x_bitmap_icon, x_wm_set_icon_pixmap):
3971 * xterm.h (struct x_display_info.icon_bitmap_id, .bitmaps_size)
3972 (.bitmaps_last, struct x_output.icon_bitmap):
3973 Use ptrdiff_t, not int, for bitmap indexes.
3974 (x_allocate_bitmap_record): Check for size overflow.
3975 * dispextern.h, lisp.h: Adjust to API changes elsewhere.
3976
3977 Use ptrdiff_t, not int, for overlay counts.
3978 * buffer.h (overlays_at, sort_overlays, GET_OVERLAYS_AT):
3979 * editfns.c (overlays_around, get_pos_property):
3980 * textprop.c (get_char_property_and_overlay):
3981 * xdisp.c (next_overlay_change, note_mouse_highlight):
3982 * xfaces.c (face_at_buffer_position):
3983 * buffer.c (OVERLAY_COUNT_MAX): New macro.
3984 (overlays_at, overlays_in, sort_overlays, Foverlays_at)
3985 (Fnext_overlay_change, Fprevious_overlay_change)
3986 (mouse_face_overlay_overlaps, Foverlays_in):
3987 Use ptrdiff_t, not int, for sizes.
3988 (overlays_at, overlays_in): Check for size-calculation overflow.
3989
3990 * xterm.c (xim_initialize, same_x_server): Strlen may not fit in int.
3991
3992 * xsmfns.c (smc_save_yourself_CB, x_session_initialize): Avoid strlen.
3993 (x_session_initialize): Do not assume string length fits in int.
3994
3995 * xsettings.c (apply_xft_settings): Fix potential buffer overrun.
3996 This is unlikely, but can occur if DPI is outlandish.
3997
3998 * xsettings.c (Ffont_get_system_normal_font, Ffont_get_system_font):
3999 * xselect.c (Fx_get_atom_name): Avoid need for strlen.
4000
4001 * xrdb.c: Don't assume strlen fits in int; avoid some strlens.
4002 * xrdb.c (magic_file_p, search_magic_path):
4003 Omit last arg SUFFIX; it was always 0. All callers changed.
4004 (magic_file_p): Use ptrdiff_t, not int. Check for size overflow.
4005
4006 * xfont.c (xfont_match): Avoid need for strlen.
4007
4008 * xfns.c: Don't assume strlen fits in int.
4009 (xic_create_fontsetname, x_window): Use ptrdiff_t, not int.
4010
4011 * xdisp.c (message_log_check_duplicate): Return intmax_t,
4012 not unsigned long, as we prefer signed integers. All callers changed.
4013 Detect integer overflow in repeat count.
4014 (message_dolog): Don't assume print length fits in 39 bytes.
4015 (display_mode_element): Don't assume strlen fits in int.
4016
4017 * termcap.c: Don't assume sizes fit in int and never overflow.
4018 (struct termcap_buffer, tgetent): Use ptrdiff_t, not int, for sizes.
4019 (gobble_line): Check for size-calculation overflow.
4020
4021 * minibuf.c (Fread_buffer):
4022 * lread.c (intern, intern_c_string):
4023 * image.c (xpm_scan) [HAVE_NS && !HAVE_XPM]:
4024 Don't assume string length fits in int.
4025
4026 * keyboard.c (parse_tool_bar_item):
4027 * gtkutil.c (style_changed_cb): Avoid need for strlen.
4028
4029 * font.c: Don't assume string length fits in int.
4030 (font_parse_xlfd, font_parse_fcname, font_unparse_fcname):
4031 Use ptrdiff_t, not int.
4032 (font_intern_prop): Don't assume string length fits in int.
4033 Don't assume integer property fits in fixnum.
4034 * font.h (font_intern_prop): 2nd arg is now ptrdiff_t, not int.
4035
4036 * filelock.c: Fix some buffer overrun and integer overflow issues.
4037 (get_boot_time): Don't assume gzip command string fits in 100 bytes.
4038 Reformulate so as not to need the command string.
4039 Invoke gzip -cd rather than gunzip, as it's more portable.
4040 (lock_info_type, lock_file_1, lock_file):
4041 Don't assume pid_t and time_t fit in unsigned long.
4042 (LOCK_PID_MAX): Remove; we now use more-reliable bounds.
4043 (current_lock_owner): Prefer signed type for sizes.
4044 Use memcpy, not strncpy, where memcpy is what is really wanted.
4045 Don't assume (via atoi) that time_t and pid_t fit in int.
4046 Check for time_t and/or pid_t out of range, e.g., via a network share.
4047 Don't alloca where an auto var works fine.
4048
4049 * fileio.c: Fix some integer overflow issues.
4050 (file_name_as_directory, Fexpand_file_name, Fsubstitute_in_file_name):
4051 Don't assume string length fits in int.
4052 (directory_file_name): Don't assume string length fits in long.
4053 (make_temp_name): Don't assume pid fits in int, or that its print
4054 length is less than 20.
4055
4056 * data.c (Fsubr_name): Rewrite to avoid a strlen call.
4057
4058 * coding.c (make_subsidiaries): Don't assume string length fits in int.
4059
4060 * callproc.c (child_setup): Rewrite to avoid two strlen calls.
4061
4062 * process.c (Fformat_network_address): Use EMACS_INT, not EMACS_UINT.
4063 We prefer signed integers, even for size calculations.
4064
4065 * emacs.c: Don't assume string length fits in 'int'.
4066 (DEFINE_DUMMY_FUNCTION, sort_args): Use ptrdiff_t, not int.
4067 (main): Don't invoke strlen when not needed.
4068
4069 * dbusbind.c (XD_ERROR): Don't arbitrarily truncate string.
4070 (XD_DEBUG_MESSAGE): Don't waste a byte.
4071
4072 * callproc.c (getenv_internal_1, getenv_internal)
4073 (Fgetenv_internal):
4074 * buffer.c (init_buffer): Don't assume string length fits in 'int'.
4075
4076 * lread.c (invalid_syntax): Omit length argument.
4077 All uses changed. This doesn't fix a bug, but it simplifies the
4078 code away from its former Hollerith-constant appearance, and it's
4079 one less 'int' to worry about when looking at integer-overflow issues.
4080 (string_to_number): Simplify 2011-04-26 change by invoking xsignal1.
4081
4082 * lisp.h (DEFUN): Remove bogus use of sizeof (struct Lisp_Subr).
4083 This didn't break anything, but it didn't help either.
4084 It's confusing to put a bogus integer in a place where the actual
4085 value does not matter.
4086 (LIST_END_P): Remove unused macro and its bogus comment.
4087 (make_fixnum_or_float): Remove unnecessary cast to EMACS_INT.
4088
4089 * lisp.h (union Lisp_Object.i): EMACS_INT, not EMACS_UINT.
4090 This is for consistency with the ordinary, non-USE_LISP_UNION_TYPE,
4091 implementation.
4092 (struct Lisp_Bool_Vector.size): EMACS_INT, not EMACS_UINT.
4093 We prefer signed types, and the value cannot exceed the EMACS_INT
4094 range anyway (because otherwise the length would not be representable).
4095 (XSET) [USE_LISP_UNION_TYPE]: Use uintptr_t and intptr_t,
4096 not EMACS_UINT and EMACS_INT, when converting pointer to integer.
4097 This avoids a GCC warning when WIDE_EMACS_INT.
4098
4099 * indent.c (sane_tab_width): New function.
4100 (current_column, scan_for_column, Findent_to, position_indentation)
4101 (compute_motion): Use it. This is just for clarity.
4102 (Fcompute_motion): Don't assume hscroll and tab offset fit in int.
4103
4104 * image.c (xbm_image_p): Don't assume stated width, height fit in int.
4105
4106 * lisp.h (lint_assume): New macro.
4107 * composite.c (composition_gstring_put_cache):
4108 * ftfont.c (ftfont_shape_by_flt): Use it to pacify GCC 4.6.0.
4109
4110 * editfns.c, insdel.c:
4111 Omit unnecessary forward decls, to simplify future changes.
4112
4113 * ftfont.c (ftfont_shape_by_flt): Use signed integers for lengths.
4114
4115 * font.c (Ffont_shape_gstring): Don't assume glyph len fits in 'int'.
4116
4117 * fns.c (Ffillarray): Don't assume bool vector size fits in 'int'.
4118 Use much-faster test for byte-length change.
4119 Don't assume string byte-length fits in 'int'.
4120 Check that character arg fits in 'int'.
4121 (mapcar1): Declare byte as byte, for clarity.
4122
4123 * alloc.c (Fmake_bool_vector): Avoid unnecessary multiplication.
4124
4125 * fns.c (concat): Catch string overflow earlier.
4126 Do not rely on integer wraparound.
4127
4128 * dispextern.h (struct it.overlay_strings_charpos)
4129 (struct it.selective): Now EMACS_INT, not int.
4130 * xdisp.c (forward_to_next_line_start)
4131 (back_to_previous_visible_line_start)
4132 (reseat_at_next_visible_line_start, next_element_from_buffer):
4133 Don't arbitrarily truncate the value of 'selective' to int.
4134
4135 * xdisp.c (init_iterator): Use XINT, not XFASTINT; it might be < 0.
4136
4137 * composite.c: Don't truncate sizes to 'int'.
4138 (composition_gstring_p, composition_reseat_it)
4139 (composition_adjust_point): Use EMACS_INT, not int.
4140 (get_composition_id, composition_gstring_put_cache): Use EMACS_INT,
4141 not EMACS_UINT, for indexes.
4142
4143 * category.h (CATEGORY_SET_P): Remove unnecessary cast to EMACS_INT.
4144
4145 * buffer.c: Include <verify.h>.
4146 (struct sortvec.priority, struct sortstr.priority):
4147 Now EMACS_INT, not int.
4148 (compare_overlays, cmp_for_strings): Avoid subtraction overflow.
4149 (struct sortstr.size, record_overlay_string)
4150 (struct sortstrlist.size, struct sortlist.used):
4151 Don't truncate size to int.
4152 (record_overlay_string): Check for size-calculation overflow.
4153 (init_buffer_once): Check at compile-time, not run-time.
4154
4155 2011-06-22 Jim Meyering <meyering@redhat.com>
4156
4157 Don't leak an XBM-image-sized buffer
4158 * image.c (xbm_load): Free the image buffer after using it.
4159
4160 2011-06-21 Paul Eggert <eggert@cs.ucla.edu>
4161
4162 Port to Sun C.
4163 * composite.c (find_automatic_composition): Omit needless 'return 0;'
4164 that Sun C diagnosed.
4165 * fns.c (secure_hash): Fix pointer signedness issue.
4166 * intervals.c (static_offset_intervals): New function.
4167 (offset_intervals): Use it.
4168
4169 2011-06-21 Leo Liu <sdl.web@gmail.com>
4170
4171 * deps.mk (fns.o):
4172 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha256.h and
4173 sha512.h.
4174
4175 * fns.c (secure_hash): Rename from crypto_hash_function and change
4176 the first arg to accept symbols.
4177 (Fsecure_hash): New primitive.
4178 (syms_of_fns): New symbols.
4179
4180 2011-06-20 Deniz Dogan <deniz@dogan.se>
4181
4182 * process.c (Fset_process_buffer): Clarify return value in
4183 docstring.
4184
4185 2011-06-18 Chong Yidong <cyd@stupidchicken.com>
4186
4187 * dispnew.c (add_window_display_history): Use BVAR.
4188
4189 * xdisp.c (debug_method_add): Use BVAR.
4190 (check_window_end, dump_glyph_matrix, dump_glyph)
4191 (dump_glyph_row, dump_glyph_string): Convert arglist to ANSI C.
4192
4193 * xfaces.c (check_lface_attrs, check_lface, dump_realized_face):
4194 Likewise.
4195
4196 * xfns.c (Fx_create_frame, x_create_tip_frame): Delay image cache
4197 check till after the cache is created in init_frame_faces.
4198
4199 2011-06-17 Stefan Monnier <monnier@iro.umontreal.ca>
4200
4201 * fns.c (Fsafe_length): Yet another int/Lisp_Object mixup.
4202
4203 2011-06-16 Paul Eggert <eggert@cs.ucla.edu>
4204
4205 * lisp.h: Include <limits.h>, for INT_MAX, LONG_MAX, LLONG_MAX.
4206 Without this, prin1 mishandles Lisp_Misc_Save_Value printing on
4207 hosts with pre-C99 libraries, because pD is wrongly defined to "t".
4208
4209 Improve buffer-overflow checking (Bug#8873).
4210 * fileio.c (Finsert_file_contents):
4211 * insdel.c (insert_from_buffer_1, replace_range, replace_range_2):
4212 Remove the old (too-loose) buffer overflow checks.
4213 They weren't needed, since make_gap checks for buffer overflow.
4214 * insdel.c (make_gap_larger): Catch buffer overflows that were missed.
4215 The old code merely checked for Emacs fixnum overflow, and relied
4216 on undefined (wraparound) behavior. The new code avoids undefined
4217 behavior, and also checks for ptrdiff_t and/or size_t overflow.
4218
4219 * editfns.c (Finsert_char): Don't dump core with very negative counts.
4220 Tune. Don't use wider integers than needed. Don't use alloca.
4221 Use a bigger 'string' buffer. Rewrite to avoid 'n > 0' test.
4222
4223 * insdel.c (replace_range): Fix buf overflow when insbytes < outgoing.
4224
4225 * insdel.c, lisp.h (buffer_overflow): New function.
4226 (insert_from_buffer_1, replace_range, replace_range_2):
4227 * insdel.c (make_gap_larger):
4228 * editfns.c (Finsert_char):
4229 * fileio.c (Finsert_file_contents): Use it, to normalize wording.
4230
4231 * buffer.h (BUF_BYTES_MAX): Cast to ptrdiff_t so that it's signed.
4232
4233 2011-06-15 Paul Eggert <eggert@cs.ucla.edu>
4234
4235 Integer overflow and signedness fixes (Bug#8873).
4236
4237 * ccl.c (ASCENDING_ORDER): New macro, to work around GCC bug 43772.
4238 (GET_CCL_RANGE, IN_INT_RANGE): Use it.
4239
4240 * fileio.c: Don't assume EMACS_INT fits in off_t.
4241 (emacs_lseek): New static function.
4242 (Finsert_file_contents, Fwrite_region): Use it.
4243 Use SEEK_SET, SEEK_CUR, SEEK_END as appropriate.
4244
4245 * fns.c (Fload_average): Don't assume 100 * load average fits in int.
4246
4247 * fns.c: Don't overflow int when computing a list length.
4248 * fns.c (QUIT_COUNT_HEURISTIC): New constant.
4249 (Flength, Fsafe_length): Use EMACS_INT, not int, to avoid unwanted
4250 truncation on 64-bit hosts. Check for QUIT every
4251 QUIT_COUNT_HEURISTIC entries rather than every other entry; that's
4252 faster and is responsive enough.
4253 (Flength): Report an error instead of overflowing an integer.
4254 (Fsafe_length): Return a float if the value is not representable
4255 as a fixnum. This shouldn't happen except in contrived situations.
4256 (Fnthcdr, Fsort): Don't assume list length fits in int.
4257 (Fcopy_sequence): Don't assume vector length fits in int.
4258
4259 * alloc.c: Check that resized vectors' lengths fit in fixnums.
4260 (header_size, word_size): New constants.
4261 (allocate_vectorlike): Don't check size overflow here.
4262 (allocate_vector): Check it here instead, since this is the only
4263 caller of allocate_vectorlike that could cause overflow.
4264 Check that the new vector's length is representable as a fixnum.
4265
4266 * fns.c (next_almost_prime): Don't return a multiple of 3 or 5.
4267 The previous code was bogus. For example, next_almost_prime (32)
4268 returned 39, which is undesirable as it is a multiple of 3; and
4269 next_almost_prime (24) returned 25, which is a multiple of 5 so
4270 why was the code bothering to check for multiples of 7?
4271
4272 * bytecode.c (exec_byte_code): Use ptrdiff_t, not int, for vector length.
4273
4274 * eval.c, doprnt.c (SIZE_MAX): Remove; inttypes.h defines this now.
4275
4276 Variadic C functions now count arguments with ptrdiff_t.
4277 This partly undoes my 2011-03-30 change, which replaced int with size_t.
4278 Back then I didn't know that the Emacs coding style prefers signed int.
4279 Also, in the meantime I found a few more instances where arguments
4280 were being counted with int, which may truncate counts on 64-bit
4281 machines, or EMACS_INT, which may be unnecessarily wide.
4282 * lisp.h (struct Lisp_Subr.function.aMANY)
4283 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call):
4284 Arg counts are now ptrdiff_t, not size_t.
4285 All variadic functions and their callers changed accordingly.
4286 (struct gcpro.nvars): Now size_t, not size_t. All uses changed.
4287 * bytecode.c (exec_byte_code): Check maxdepth for overflow,
4288 to avoid potential buffer overrun. Don't assume arg counts fit in 'int'.
4289 * callint.c (Fcall_interactively): Check arg count for overflow,
4290 to avoid potential buffer overrun. Use signed char, not 'int',
4291 for 'varies' array, so that we needn't bother to check its size
4292 calculation for overflow.
4293 * editfns.c (Fformat): Use ptrdiff_t, not EMACS_INT, to count args.
4294 * eval.c (apply_lambda):
4295 * fns.c (Fmapconcat): Use XFASTINT, not XINT, to get args length.
4296 (struct textprop_rec.argnum): Now ptrdiff_t, not int. All uses changed.
4297 (mapconcat): Use ptrdiff_t, not int and EMACS_INT, to count args.
4298
4299 * callint.c (Fcall_interactively): Don't use index var as event count.
4300
4301 * vm-limit.c (check_memory_limits): Fix incorrect extern function decls.
4302 * mem-limits.h (SIZE): Remove; no longer used.
4303
4304 * xterm.c (x_alloc_nearest_color_1): Prefer int to long when int works.
4305
4306 Remove unnecessary casts.
4307 * xterm.c (x_term_init):
4308 * xfns.c (x_set_border_pixel):
4309 * widget.c (create_frame_gcs): Remove casts to unsigned long etc.
4310 These aren't needed now that we assume ANSI C.
4311
4312 * sound.c (Fplay_sound_internal): Remove cast to unsigned long.
4313 It's more likely to cause problems (due to unsigned overflow)
4314 than to cure them.
4315
4316 * dired.c (Ffile_attributes): Don't use 32-bit hack on 64-bit hosts.
4317
4318 * unexelf.c (unexec): Don't assume BSS addr fits in unsigned.
4319
4320 * xterm.c (handle_one_xevent): Omit unnecessary casts to unsigned.
4321
4322 * keyboard.c (modify_event_symbol): Don't limit alist len to UINT_MAX.
4323
4324 * lisp.h (CHAR_TABLE_SET): Omit now-redundant test.
4325
4326 * lread.c (Fload): Don't compare a possibly-garbage time_t value.
4327
4328 GLYPH_CODE_FACE returns EMACS_INT, not int.
4329 * dispextern.h (merge_faces):
4330 * xfaces.c (merge_faces):
4331 * xdisp.c (get_next_display_element, next_element_from_display_vector):
4332 Don't assume EMACS_INT fits in int.
4333
4334 * character.h (CHAR_VALID_P): Remove unused parameter.
4335 * fontset.c, lisp.h, xdisp.c: All uses changed.
4336
4337 * editfns.c (Ftranslate_region_internal): Omit redundant test.
4338
4339 * fns.c (concat): Minor tuning based on overflow analysis.
4340 This doesn't fix any bugs. Use int to hold character, instead
4341 of constantly refetching from Emacs object. Use XFASTINT, not
4342 XINT, for value known to be a character. Don't bother comparing
4343 a single byte to 0400, as it's always less.
4344
4345 * floatfns.c (Fexpt):
4346 * fileio.c (make_temp_name): Omit unnecessary cast to unsigned.
4347
4348 * editfns.c (Ftranslate_region_internal): Use int, not EMACS_INT
4349 for characters.
4350
4351 * doc.c (get_doc_string): Omit (unsigned)c that mishandled negatives.
4352
4353 * data.c (Faset): If ARRAY is a string, check that NEWELT is a char.
4354 Without this fix, on a 64-bit host (aset S 0 4294967386) would
4355 incorrectly succeed when S was a string, because 4294967386 was
4356 truncated before it was used.
4357
4358 * chartab.c (Fchar_table_range): Use CHARACTERP to check range.
4359 Otherwise, an out-of-range integer could cause undefined behavior
4360 on a 64-bit host.
4361
4362 * composite.c: Use int, not EMACS_INT, for characters.
4363 (fill_gstring_body, composition_compute_stop_pos): Use int, not
4364 EMACS_INT, for values that are known to be in character range.
4365 This doesn't fix any bugs but is the usual style inside Emacs and
4366 may generate better code on 32-bit machines.
4367
4368 Make sure a 64-bit char is never passed to ENCODE_CHAR.
4369 This is for reasons similar to the recent CHAR_STRING fix.
4370 * charset.c (Fencode_char): Check that character arg is actually
4371 a character. Pass an int to ENCODE_CHAR.
4372 * charset.h (ENCODE_CHAR): Verify that the character argument is no
4373 wider than 'int', as a compile-time check to prevent future regressions
4374 in this area.
4375
4376 * character.c (char_string): Remove unnecessary casts.
4377
4378 Make sure a 64-bit char is never passed to CHAR_STRING.
4379 Otherwise, CHAR_STRING would do the wrong thing on a 64-bit platform,
4380 by silently ignoring the top 32 bits, allowing some values
4381 that were far too large to be valid characters.
4382 * character.h: Include <verify.h>.
4383 (CHAR_STRING, CHAR_STRING_ADVANCE): Verify that the character
4384 arguments are no wider than unsigned, as a compile-time check
4385 to prevent future regressions in this area.
4386 * data.c (Faset):
4387 * editfns.c (Fchar_to_string, general_insert_function, Finsert_char)
4388 (Fsubst_char_in_region):
4389 * fns.c (concat):
4390 * xdisp.c (decode_mode_spec_coding):
4391 Adjust to CHAR_STRING's new requirement.
4392 * editfns.c (Finsert_char, Fsubst_char_in_region):
4393 * fns.c (concat): Check that character args are actually
4394 characters. Without this test, these functions did the wrong
4395 thing with wildly out-of-range values on 64-bit hosts.
4396
4397 Remove incorrect casts to 'unsigned' that lose info on 64-bit hosts.
4398 These casts should not be needed on 32-bit hosts, either.
4399 * keyboard.c (read_char):
4400 * lread.c (Fload): Remove casts to unsigned.
4401
4402 * lisp.h (UNSIGNED_CMP): New macro.
4403 This fixes comparison bugs on 64-bit hosts.
4404 (ASCII_CHAR_P): Use it.
4405 * casefiddle.c (casify_object):
4406 * character.h (ASCII_BYTE_P, CHAR_VALID_P)
4407 (SINGLE_BYTE_CHAR_P, CHAR_STRING):
4408 * composite.h (COMPOSITION_ENCODE_RULE_VALID):
4409 * dispextern.h (FACE_FROM_ID):
4410 * keyboard.c (read_char): Use UNSIGNED_CMP.
4411
4412 * xmenu.c (dialog_selection_callback) [!USE_GTK]: Cast to intptr_t,
4413 not to EMACS_INT, to avoid GCC warning.
4414
4415 * xfns.c (x_set_scroll_bar_default_width): Remove unused 'int' locals.
4416
4417 * buffer.h (PTR_BYTE_POS, BUF_PTR_BYTE_POS): Remove harmful cast.
4418 The cast incorrectly truncated 64-bit byte offsets to 32 bits, and
4419 isn't needed on 32-bit machines.
4420
4421 * buffer.c (Fgenerate_new_buffer_name):
4422 Use EMACS_INT for count, not int.
4423 (advance_to_char_boundary): Return EMACS_INT, not int.
4424
4425 * data.c (Qcompiled_function): Now static.
4426
4427 * window.c (window_body_lines): Now static.
4428
4429 * image.c (gif_load): Rename local to avoid shadowing.
4430
4431 * lisp.h (SAFE_ALLOCA_LISP): Check for integer overflow.
4432 (struct Lisp_Save_Value): Use ptrdiff_t, not int, for 'integer' member.
4433 * alloc.c (make_save_value): Integer argument is now of type
4434 ptrdiff_t, not int.
4435 (mark_object): Use ptrdiff_t, not int.
4436 * lisp.h (pD): New macro.
4437 * print.c (print_object): Use it.
4438
4439 * alloc.c: Use EMACS_INT, not int, to count objects.
4440 (total_conses, total_markers, total_symbols, total_vector_size)
4441 (total_free_conses, total_free_markers, total_free_symbols)
4442 (total_free_floats, total_floats, total_free_intervals)
4443 (total_intervals, total_strings, total_free_strings):
4444 Now EMACS_INT, not int. All uses changed.
4445 (Fgarbage_collect): Compute overall total using a double, so that
4446 integer overflow is less likely to be a problem. Check for overflow
4447 when converting back to an integer.
4448 (n_interval_blocks, n_string_blocks, n_float_blocks, n_cons_blocks)
4449 (n_vectors, n_symbol_blocks, n_marker_blocks): Remove.
4450 These were 'int' variables that could overflow on 64-bit hosts;
4451 they were never used, so remove them instead of repairing them.
4452 (nzombies, ngcs, max_live, max_zombies): Now EMACS_INT, not 'int'.
4453 (inhibit_garbage_collection): Set gc_cons_threshold to max value.
4454 Previously, this ceilinged at INT_MAX, but that doesn't work on
4455 64-bit machines.
4456 (allocate_pseudovector): Don't use EMACS_INT when int would do.
4457
4458 * alloc.c (Fmake_bool_vector): Don't assume vector size fits in int.
4459 (allocate_vectorlike): Check for ptrdiff_t overflow.
4460 (mark_vectorlike, mark_char_table, mark_object): Avoid EMACS_UINT
4461 when a (possibly-narrower) signed value would do just as well.
4462 We prefer using signed arithmetic, to avoid comparison confusion.
4463
4464 * alloc.c: Catch some string size overflows that we were missing.
4465 (XMALLOC_OVERRUN_CHECK_SIZE) [!XMALLOC_OVERRUN_CHECK]: Define to 0,
4466 for convenience in STRING_BYTES_MAX.
4467 (STRING_BYTES_MAX): New macro, superseding the old one in lisp.h.
4468 The definition here is exact; the one in lisp.h was approximate.
4469 (allocate_string_data): Check for string overflow. This catches
4470 some instances we weren't catching before. Also, it catches
4471 size_t overflow on (unusual) hosts where SIZE_MAX <= min
4472 (PTRDIFF_MAX, MOST_POSITIVE_FIXNUM), e.g., when size_t is 32 bits
4473 and ptrdiff_t and EMACS_INT are both 64 bits.
4474
4475 * character.c, coding.c, doprnt.c, editfns.c, eval.c:
4476 All uses of STRING_BYTES_MAX replaced by STRING_BYTES_BOUND.
4477 * lisp.h (STRING_BYTES_BOUND): Rename from STRING_BYTES_MAX.
4478
4479 * character.c (string_escape_byte8): Fix nbytes/nchars typo.
4480
4481 * alloc.c (Fmake_string): Check for out-of-range init.
4482
4483 2011-06-15 Stefan Monnier <monnier@iro.umontreal.ca>
4484
4485 * eval.c (Fdefvaralias): Also mark the target as variable-special-p.
4486
4487 2011-06-14 Jan Djärv <jan.h.d@swipnet.se>
4488
4489 * xfns.c (x_set_scroll_bar_default_width): Remove argument to
4490 xg_get_default_scrollbar_width.
4491
4492 * gtkutil.c: Include emacsgtkfixed.h if HAVE_GTK3.
4493 (int_gtk_range_get_value): Move to the scroll bar part of the file.
4494 (style_changed_cb): Call update_theme_scrollbar_width and call
4495 x_set_scroll_bar_default_width and xg_frame_set_char_size for
4496 all frames (Bug#8505).
4497 (xg_create_frame_widgets): Call emacs_fixed_new if HAVE_GTK3 (Bug#8505).
4498 Call gtk_window_set_resizable if HAVE_GTK3.
4499 (x_wm_set_size_hint): Call emacs_fixed_set_min_size with min width
4500 and height if HAVE_GTK3 (Bug#8505).
4501 (scroll_bar_width_for_theme): New variable.
4502 (update_theme_scrollbar_width): New function.
4503 (xg_get_default_scrollbar_width): Move code to
4504 update_theme_scrollbar_width, just return scroll_bar_width_for_theme.
4505 (xg_initialize): Call update_theme_scrollbar_width.
4506
4507 * gtkutil.h (xg_get_default_scrollbar_width): Remove argument.
4508
4509 * emacsgtkfixed.c, emacsgtkfixed.h: New files.
4510
4511 2011-06-12 Martin Rudalics <rudalics@gmx.at>
4512
4513 * frame.c (make_frame): Call other_buffer_safely instead of
4514 other_buffer.
4515
4516 * window.c (temp_output_buffer_show): Call display_buffer with
4517 second argument Vtemp_buffer_show_specifiers and reset latter
4518 immediately after the call.
4519 (Vtemp_buffer_show_specifiers): New variable.
4520 (auto_window_vscroll_p, next_screen_context_lines)
4521 (Vscroll_preserve_screen_position): Remove leading asterisks from
4522 doc-strings.
4523
4524 2011-06-12 Paul Eggert <eggert@cs.ucla.edu>
4525
4526 Fix minor problems found by GCC 4.6.0 static checking.
4527 * buffer.c (Qclone_number): Remove for now, as it's unused.
4528 (record_buffer, Funrecord_buffer): Rename local to avoid shadowing.
4529 (record_buffer): Remove unused local.
4530 * frame.c (other_visible_frames, frame_buffer_list): Now static.
4531 (set_frame_buffer_list): Remove; unused.
4532 * frame.h (other_visible_frames): Remove decl.
4533 * keyboard.h (menu_items_inuse): Declare only if USE_GTK || USE_MOTIF.
4534 * lisp.h (frame_buffer_list, set_frame_buffer_list): Remove decls.
4535 (add_gpm_wait_descriptor, delete_gpm_wait_descriptor): Declare only
4536 if HAVE_GPM.
4537 * menu.c (menu_items_inuse): Now static unless USE_GTK || USE_MOTIF.
4538 * process.c (add_gpm_wait_descriptor, delete_gpm_wait_descriptor):
4539 Define only if HAVE_GPM.
4540 * widget.c (EmacsFrameResize, emacsFrameClassRec): Now static.
4541 (update_hints_inhibit): Remove; never set. All uses removed.
4542 * widgetprv.h (emacsFrameClassRec): Remove decl.
4543 * window.c (delete_deletable_window): Now returns void, since it
4544 wasn't returning anything.
4545 (compare_window_configurations): Remove unused locals.
4546 * xfns.c (x_set_scroll_bar_default_width): Remove unused locals.
4547 * xmenu.c (x_menu_set_in_use): Define only if USE_GTK || USE_MOTIF.
4548 (dialog_selection_callback) [!USE_GTK]: Prefer intptr_t for integers
4549 the same widths as pointers. This follows up on the 2011-05-06 patch.
4550 * xterm.c (x_alloc_lighter_color_for_widget): Define only if USE_LUCID.
4551 * xterm.h: Likewise.
4552 (x_menu_set_in_use): Declare only if USE_GTK || USE_MOTIF.
4553
4554 2011-06-12 Juanma Barranquero <lekktu@gmail.com>
4555
4556 * makefile.w32-in: Update dependencies.
4557 (LISP_H): Add lib/intprops.h.
4558
4559 2011-06-11 Chong Yidong <cyd@stupidchicken.com>
4560
4561 * image.c (gif_load): Add animation frame delay to the metadata.
4562 (syms_of_image): Use DEFSYM. New symbol `delay'.
4563
4564 2011-06-11 Martin Rudalics <rudalics@gmx.at>
4565
4566 * window.c (delete_deletable_window): Re-add.
4567 (Fset_window_configuration): Rewrite to handle dead buffers and
4568 consequently deletable windows.
4569 (window_tree, Fwindow_tree): Remove. Supply functionality in
4570 window.el.
4571 (compare_window_configurations): Simplify code.
4572
4573 2011-06-11 Andreas Schwab <schwab@linux-m68k.org>
4574
4575 * image.c (imagemagick_load_image): Fix type mismatch.
4576 (Fimagemagick_types): Likewise.
4577
4578 * window.h (replace_buffer_in_windows): Declare.
4579
4580 2011-06-11 Martin Rudalics <rudalics@gmx.at>
4581
4582 * buffer.c: New Lisp objects Qbuffer_list_update_hook and
4583 Qclone_number. Remove external declaration of Qdelete_window.
4584 (Fbuffer_list): Rewrite doc-string. Minor restructuring of
4585 code.
4586 (Fget_buffer_create, Fmake_indirect_buffer, Frename_buffer):
4587 Run Qbuffer_list_update_hook if allowed.
4588 (Fother_buffer): Rewrite doc-string. Major rewrite for new
4589 buffer list implementation.
4590 (other_buffer_safely): New function.
4591 (Fkill_buffer): Replace call to replace_buffer_in_all_windows by
4592 calls to replace_buffer_in_windows and
4593 replace_buffer_in_windows_safely. Run Qbuffer_list_update_hook
4594 if allowed.
4595 (record_buffer): Inhibit quitting and rewrite using quittable
4596 functions. Run Qbuffer_list_update_hook if allowed.
4597 (Frecord_buffer, Funrecord_buffer): New functions.
4598 (switch_to_buffer_1, Fswitch_to_buffer): Remove.
4599 Move switch-to-buffer to window.el.
4600 (bury-buffer): Move to window.el.
4601 (Vbuffer_list_update_hook): New variable.
4602
4603 * lisp.h (other_buffer_safely): Add prototype in buffer.c
4604 section.
4605
4606 * window.h (resize_frame_windows): Move up in code.
4607 (Fwindow_frame): Remove EXFUN.
4608 (replace_buffer_in_all_windows): Remove prototype.
4609 (replace_buffer_in_windows_safely): Add prototype.
4610
4611 * window.c: Declare Qdelete_window static again. Move down
4612 declaration of select_count.
4613 (Fnext_window, Fprevious_window): Rewrite doc-strings.
4614 (Fother_window): Move to window.el.
4615 (window_loop): Remove DELETE_BUFFER_WINDOWS and UNSHOW_BUFFER
4616 cases. Add REPLACE_BUFFER_IN_WINDOWS_SAFELY case.
4617 (Fdelete_windows_on, Freplace_buffer_in_windows): Move to
4618 window.el.
4619 (replace_buffer_in_windows): Implement by calling
4620 Qreplace_buffer_in_windows.
4621 (replace_buffer_in_all_windows): Remove with some functionality
4622 moved into replace_buffer_in_windows_safely.
4623 (replace_buffer_in_windows_safely): New function.
4624 (select_window_norecord, select_frame_norecord): Move in front
4625 of run_window_configuration_change_hook. Remove now obsolete
4626 declarations.
4627 (Fset_window_buffer): Rewrite doc-string.
4628 Call Qrecord_window_buffer.
4629 (keys_of_window): Move binding for other-window to window.el.
4630
4631 2011-06-11 Chong Yidong <cyd@stupidchicken.com>
4632
4633 * dispextern.h (struct image): Replace data member, whose int_val
4634 and ptr_val fields were not used by anything, with a single
4635 lisp_val object.
4636
4637 * image.c (Fimage_metadata, make_image, mark_image, tiff_load)
4638 (gif_clear_image, gif_load, imagemagick_load_image)
4639 (gs_clear_image, gs_load): Callers changed.
4640
4641 2011-06-10 Paul Eggert <eggert@cs.ucla.edu>
4642
4643 * buffer.h: Include <time.h>, for time_t.
4644 Needed to build on FreeBSD 8.2. Problem reported by Herbert J. Skuhra.
4645
4646 Fix minor problems found by static checking.
4647
4648 * image.c (PixelGetMagickColor): Declare if ImageMagick headers don't.
4649
4650 Make identifiers static if they are not used in other modules.
4651 * data.c (Qcompiled_function, Qframe, Qvector):
4652 * image.c (QimageMagick, Qsvg):
4653 * minibuf.c (Qmetadata):
4654 * window.c (resize_window_check, resize_root_window): Now static.
4655 * window.h (resize_window_check, resize_root_window): Remove decls.
4656
4657 * window.c (window_deletion_count, delete_deletable_window):
4658 Remove; unused.
4659 (window_body_lines): Now static.
4660 (Fdelete_other_windows_internal): Mark vars as initialized.
4661 Make sure 'resize_failed' is initialized.
4662 (run_window_configuration_change_hook): Rename local to avoid shadowing.
4663 (resize_window_apply): Remove unused local.
4664 * window.h (delete_deletable_window): Remove decl.
4665
4666 * image.c (gif_load, svg_load_image): Rename locals to avoid shadowing.
4667 (imagemagick_load_image): Fix pointer signedness problem by changing
4668 last arg from unsigned char * to char *. All uses changed.
4669 Also, fix a local for similar reasons.
4670 Remove unused locals. Remove locals to avoid shadowing.
4671 (fn_rsvg_handle_free): Remove; unused.
4672 (svg_load, svg_load_image): Fix pointer signedness problem.
4673 (imagemagick_load_image): Don't use garbage pointer image_wand.
4674
4675 * ftfont.c (ftfont_get_metrics, ftfont_drive_otf): Remove unused locals.
4676
4677 2011-06-10 Chong Yidong <cyd@stupidchicken.com>
4678
4679 * image.c (gif_load): Fix omitted cast error introduced by
4680 2011-06-06 change.
4681
4682 2011-06-10 Martin Rudalics <rudalics@gmx.at>
4683
4684 * window.h (resize_proportionally, orig_total_lines)
4685 (orig_top_line): Remove from window structure.
4686 (set_window_height, set_window_width, change_window_heights)
4687 (Fdelete_window): Remove prototypes.
4688 (resize_frame_windows): Remove duplicate declaration.
4689
4690 2011-06-10 Eli Zaretskii <eliz@gnu.org>
4691
4692 * window.h (resize_frame_windows, resize_window_check)
4693 (delete_deletable_window, resize_root_window)
4694 (resize_frame_windows): Declare prototypes.
4695
4696 * window.c (resize_window_apply): Make definition be "static" to
4697 match the prototype.
4698
4699 2011-06-10 Martin Rudalics <rudalics@gmx.at>
4700
4701 * window.c: Remove declarations of Qwindow_size_fixed,
4702 window_min_size_1, window_min_size_2, window_min_size,
4703 size_window, window_fixed_size_p, enlarge_window, delete_window.
4704 Remove static from declaration of Qdelete_window, it's
4705 temporarily needed by Fbury_buffer.
4706 (replace_window): Don't assign orig_top_line and
4707 orig_total_lines.
4708 (Fdelete_window, delete_window): Remove. Window deletion is
4709 handled by window.el.
4710 (window_loop): Remove DELETE_OTHER_WINDOWS case.
4711 Replace Fdelete_window calls with calls to Qdelete_window.
4712 (Fdelete_other_windows): Remove. Deleting other windows is
4713 handled by window.el.
4714 (window_fixed_size_p): Remove. Fixed-sizeness of windows is
4715 handled in window.el.
4716 (window_min_size_2, window_min_size_1, window_min_size): Remove.
4717 Window minimum sizes are handled in window.el.
4718 (shrink_windows, size_window, set_window_height)
4719 (set_window_width, change_window_heights, window_height)
4720 (window_width, CURBEG, CURSIZE, enlarge_window)
4721 (adjust_window_trailing_edge, Fadjust_window_trailing_edge)
4722 (Fenlarge_window, Fshrink_window): Remove. Window resizing is
4723 handled in window.el.
4724 (make_dummy_parent): Rename to make_parent_window and give it a
4725 second argument horflag.
4726 (make_window): Don't set resize_proportionally any more.
4727 (Fsplit_window): Remove. Windows are split in window.el.
4728 (save_restore_action, save_restore_orig_size)
4729 (shrink_window_lowest_first, save_restore_orig_size): Remove.
4730 Resize mini windows in window.el.
4731 (grow_mini_window, shrink_mini_window): Implement by calling
4732 Qresize_root_window_vertically, resize_window_check and
4733 resize_window_apply.
4734 (saved_window, Fset_window_configuration, save_window_save):
4735 Do not handle orig_top_line, orig_total_lines, and
4736 resize_proportionally.
4737 (window_min_height, window_min_width): Move to window.el.
4738 (keys_of_window): Move bindings for delete-other-windows,
4739 split-window, delete-window and enlarge-window to window.el.
4740
4741 * buffer.c: Temporarily extern Qdelete_window.
4742 (Fbury_buffer): Temporarily call Qdelete_window instead of
4743 Fdelete_window (Fbury_buffer will move to window.el soon).
4744
4745 * frame.c (set_menu_bar_lines_1): Remove code handling
4746 orig_top_line and orig_total_lines.
4747
4748 * dispnew.c (adjust_frame_glyphs_initially): Don't use
4749 set_window_height but set heights directly.
4750 (change_frame_size_1): Use resize_frame_windows.
4751
4752 * xdisp.c (init_xdisp): Don't use set_window_height but set
4753 heights directly.
4754
4755 * xfns.c (x_set_menu_bar_lines, x_set_tool_bar_lines):
4756 Use resize_frame_windows instead of change_window_heights and run
4757 run_window_configuration_change_hook.
4758
4759 * w32fns.c (x_set_tool_bar_lines): Use resize_frame_windows
4760 instead of change_window_heights and run
4761 run_window_configuration_change_hook.
4762
4763 2011-06-09 Martin Rudalics <rudalics@gmx.at>
4764
4765 * window.c (replace_window): Rename second argument REPLACEMENT to
4766 NEW. New third argument SETFLAG. Rewrite.
4767 (delete_window, make_dummy_parent): Call replace_window with
4768 third argument 1.
4769 (window_list_1): Move down in code.
4770 (run_window_configuration_change_hook): Move set_buffer part
4771 before select_frame_norecord part in order to unwind correctly.
4772 Rename count1 to count.
4773 (recombine_windows, delete_deletable_window, resize_root_window)
4774 (Fdelete_other_windows_internal)
4775 (Frun_window_configuration_change_hook, make_parent_window)
4776 (resize_window_check, resize_window_apply, Fresize_window_apply)
4777 (resize_frame_windows, Fsplit_window_internal)
4778 (Fdelete_window_internal, Fresize_mini_window_internal):
4779 New functions.
4780 (syms_of_window): New variables Vwindow_splits and Vwindow_nest.
4781
4782 2011-06-08 Martin Rudalics <rudalics@gmx.at>
4783
4784 * window.h (window): Add some new members to window structure -
4785 normal_lines, normal_cols, new_total, new_normal, clone_number,
4786 splits, nest, prev_buffers, next_buffers.
4787 (WINDOW_TOTAL_SIZE): Move here from window.c.
4788 (MIN_SAFE_WINDOW_WIDTH, MIN_SAFE_WINDOW_HEIGHT): Define here.
4789
4790 * window.c (Fwindow_height, Fwindow_width, Fwindow_full_width_p):
4791 Remove.
4792 (make_dummy_parent): Set new members of windows structure.
4793 (make_window): Move down in code. Handle new members of window
4794 structure.
4795 (Fwindow_clone_number, Fwindow_splits, Fset_window_splits)
4796 (Fwindow_nest, Fset_window_nest, Fwindow_new_total)
4797 (Fwindow_normal_size, Fwindow_new_normal, Fwindow_prev_buffers)
4798 (Fset_window_prev_buffers, Fwindow_next_buffers)
4799 (Fset_window_next_buffers, Fset_window_clone_number):
4800 New functions.
4801 (Fwindow_hscroll, Fwindow_at, Fwindow_point, Fwindow_start)
4802 (Fwindow_end, Fwindow_line_height, Fset_window_dedicated_p):
4803 Doc-string fixes.
4804 (Fwindow_parameters, Fwindow_parameter, Fset_window_parameter):
4805 Argument WINDOW can be now internal window too.
4806 (Fwindow_use_time): Move up in code.
4807 (Fget_buffer_window): Rename argument FRAME to ALL-FRAMES.
4808 Rewrite doc-string.
4809 (Fset_window_configuration, saved_window)
4810 (Fcurrent_window_configuration, save_window_save): Handle new
4811 members of window structure.
4812 (WINDOW_TOTAL_SIZE, MIN_SAFE_WINDOW_WIDTH)
4813 (MIN_SAFE_WINDOW_HEIGHT): Move to window.h.
4814 (syms_of_window): New Lisp objects Qrecord_window_buffer,
4815 Qwindow_deletable_p, Qdelete_window, Qreplace_buffer_in_windows,
4816 Qget_mru_window, Qresize_root_window,
4817 Qresize_root_window_vertically, Qsafe, Qabove, Qbelow,
4818 Qauto_buffer_name; staticpro them.
4819
4820 2011-06-07 Martin Rudalics <rudalics@gmx.at>
4821
4822 * window.c (Fwindow_total_size, Fwindow_left_column)
4823 (Fwindow_top_line, window_body_lines, Fwindow_body_size)
4824 (Fwindow_list_1): New functions.
4825 (window_box_text_cols): Replace with window_body_cols.
4826 (Fwindow_width, Fscroll_left, Fscroll_right):
4827 Use window_body_cols instead of window_box_text_cols.
4828 (delete_window, Fset_window_configuration):
4829 Call delete_all_subwindows with window as argument.
4830 (delete_all_subwindows): Take a window as argument and not a
4831 structure. Rewrite.
4832 (window_loop): Remove handling of GET_LRU_WINDOW and
4833 GET_LARGEST_WINDOW.
4834 (Fget_lru_window, Fget_largest_window): Move to window.el.
4835
4836 * window.h: Extern window_body_cols instead of
4837 window_box_text_cols. delete_all_subwindows now takes a
4838 Lisp_Object as argument.
4839
4840 * indent.c (compute_motion, Fcompute_motion):
4841 Use window_body_cols instead of window_box_text_cols.
4842
4843 * frame.c (delete_frame): Call delete_all_subwindows with root
4844 window as argument.
4845
4846 2011-06-07 Daniel Colascione <dan.colascione@gmail.com>
4847
4848 * fns.c (Fputhash): Document return value.
4849
4850 2011-06-06 Chong Yidong <cyd@stupidchicken.com>
4851
4852 * image.c (gif_load): Implement gif89a spec "no disposal" method.
4853
4854 2011-06-06 Paul Eggert <eggert@cs.ucla.edu>
4855
4856 Cons<->int and similar integer overflow fixes (Bug#8794).
4857
4858 Check for overflow when converting integer to cons and back.
4859 * charset.c (Fdefine_charset_internal, Fdecode_char):
4860 Use cons_to_unsigned to catch overflow.
4861 (Fencode_char): Use INTEGER_TO_CONS.
4862 * composite.h (LGLYPH_CODE): Use cons_to_unsigned.
4863 (LGLYPH_SET_CODE): Use INTEGER_TO_CONS.
4864 * data.c (long_to_cons, cons_to_long): Remove.
4865 (cons_to_unsigned, cons_to_signed): New functions.
4866 These signal an error for invalid or out-of-range values.
4867 * dired.c (Ffile_attributes): Use INTEGER_TO_CONS.
4868 * fileio.c (Fset_visited_file_modtime): Use CONS_TO_INTEGER.
4869 * font.c (Ffont_variation_glyphs):
4870 * fontset.c (Finternal_char_font): Use INTEGER_TO_CONS.
4871 * lisp.h: Include <intprops.h>.
4872 (INTEGER_TO_CONS, CONS_TO_INTEGER): New macros.
4873 (cons_to_signed, cons_to_unsigned): New decls.
4874 (long_to_cons, cons_to_long): Remove decls.
4875 * undo.c (record_first_change): Use INTEGER_TO_CONS.
4876 (Fprimitive_undo): Use CONS_TO_INTEGER.
4877 * xfns.c (Fx_window_property): Likewise.
4878 * xselect.c: Include <limits.h>.
4879 (x_own_selection, selection_data_to_lisp_data):
4880 Use INTEGER_TO_CONS.
4881 (x_handle_selection_request, x_handle_selection_clear)
4882 (x_get_foreign_selection, Fx_disown_selection_internal)
4883 (Fx_get_atom_name, x_send_client_event): Use CONS_TO_INTEGER.
4884 (lisp_data_to_selection_data): Use cons_to_unsigned.
4885 (x_fill_property_data): Use cons_to_signed.
4886 Report values out of range.
4887
4888 Check for buffer and string overflow more precisely.
4889 * buffer.h (BUF_BYTES_MAX): New macro.
4890 * lisp.h (STRING_BYTES_MAX): New macro.
4891 * alloc.c (Fmake_string):
4892 * character.c (string_escape_byte8):
4893 * coding.c (coding_alloc_by_realloc):
4894 * doprnt.c (doprnt):
4895 * editfns.c (Fformat):
4896 * eval.c (verror):
4897 Use STRING_BYTES_MAX, not MOST_POSITIVE_FIXNUM,
4898 since they may not be the same number.
4899 * editfns.c (Finsert_char):
4900 * fileio.c (Finsert_file_contents):
4901 Likewise for BUF_BYTES_MAX.
4902
4903 * image.c: Use ptrdiff_t, not int, for sizes.
4904 (slurp_file): Switch from int to ptrdiff_t.
4905 All uses changed.
4906 (slurp_file): Check that file size fits in both size_t (for
4907 malloc) and ptrdiff_t (for sanity and safety).
4908
4909 * fileio.c (Fverify_visited_file_modtime): Avoid time overflow
4910 if b->modtime has its maximal value.
4911
4912 * dired.c (Ffile_attributes): Don't assume EMACS_INT has >32 bits.
4913
4914 Don't assume time_t can fit into int.
4915 * buffer.h (struct buffer.modtime): Now time_t, not int.
4916 * fileio.c (Fvisited_file_modtime): No need for time_t cast now.
4917 * undo.c (Fprimitive_undo): Use time_t, not int, for time_t value.
4918
4919 Minor fixes for signed vs unsigned integers.
4920 * character.h (MAYBE_UNIFY_CHAR):
4921 * charset.c (maybe_unify_char):
4922 * keyboard.c (read_char, reorder_modifiers):
4923 XINT -> XFASTINT, since the integer must be nonnegative.
4924 * ftfont.c (ftfont_spec_pattern):
4925 * keymap.c (access_keymap, silly_event_symbol_error):
4926 XUINT -> XFASTINT, since the integer must be nonnegative.
4927 (Fsingle_key_description, preferred_sequence_p): XUINT -> XINT,
4928 since it makes no difference and we prefer signed.
4929 * keyboard.c (record_char): Use XUINT when all the neighbors do.
4930 (access_keymap): NATNUMP -> INTEGERP, since the integer must be
4931 nonnegative.
4932
4933 2011-06-06 Stefan Monnier <monnier@iro.umontreal.ca>
4934
4935 * window.h (Fwindow_frame): Declare.
4936
4937 2011-06-06 Paul Eggert <eggert@cs.ucla.edu>
4938
4939 * alloc.c: Simplify handling of large-request failures (Bug#8800).
4940 (SPARE_MEMORY): Always define.
4941 (LARGE_REQUEST): Remove.
4942 (memory_full): Use SPARE_MEMORY rather than LARGE_REQUEST.
4943
4944 2011-06-06 Martin Rudalics <rudalics@gmx.at>
4945
4946 * lisp.h: Move EXFUNS for Fframe_root_window,
4947 Fframe_first_window and Fset_frame_selected_window to window.h.
4948
4949 * window.h: Move EXFUNS for Fframe_root_window,
4950 Fframe_first_window and Fset_frame_selected_window here from
4951 lisp.h.
4952
4953 * frame.c (Fwindow_frame, Fframe_first_window)
4954 (Fframe_root_window, Fframe_selected_window)
4955 (Fset_frame_selected_window): Move to window.c.
4956 (Factive_minibuffer_window): Move to minibuf.c.
4957 (Fother_visible_frames_p): New function.
4958
4959 * minibuf.c (Factive_minibuffer_window): Move here from frame.c.
4960
4961 * window.c (decode_window, decode_any_window): Move up in code.
4962 (Fwindowp, Fwindow_live_p): Rewrite doc-strings.
4963 (inhibit_frame_unsplittable): Remove unused variable.
4964 (Fwindow_buffer): Move up and rewrite doc-string.
4965 (Fwindow_parent, Fwindow_vchild, Fwindow_hchild, Fwindow_next)
4966 (Fwindow_prev): New functions.
4967 (Fwindow_frame): Move here from frame.c. Accept any window as
4968 argument.
4969 (Fframe_root_window, Fframe_first_window)
4970 (Fframe_selected_window): Move here from frame.c. Accept frame
4971 or arbitrary window as argument. Update doc-strings.
4972 (Fminibuffer_window): Move up in code.
4973 (Fwindow_minibuffer_p): Move up in code and simplify.
4974 (Fset_frame_selected_window): Move here from frame.c.
4975 Marginal rewrite.
4976 (Fselected_window, select_window, Fselect_window): Move up in
4977 code. Minor doc-string fixes.
4978
4979 2011-06-06 Paul Eggert <eggert@cs.ucla.edu>
4980
4981 * alloc.c (memory_full) [SYSTEM_MALLOC]: Port to MacOS (Bug#8800).
4982 Do not assume that spare memory exists; that assumption is valid
4983 only if SYSTEM_MALLOC.
4984 (LARGE_REQUEST): New macro, so that the issue of large requests
4985 is separated from the issue of spare memory.
4986
4987 2011-06-05 Andreas Schwab <schwab@linux-m68k.org>
4988
4989 * editfns.c (Fformat): Correctly handle zero flag with hexadecimal
4990 format. (Bug#8806)
4991
4992 * gtkutil.c (xg_get_default_scrollbar_width): Avoid warning.
4993
4994 * xfns.c (x_set_scroll_bar_default_width): Move declarations
4995 before statements.
4996
4997 2011-06-05 Jan Djärv <jan.h.d@swipnet.se>
4998
4999 * gtkutil.c (xg_get_default_scrollbar_width): New function.
5000
5001 * gtkutil.h: Declare xg_get_default_scrollbar_width.
5002
5003 * xfns.c (x_set_scroll_bar_default_width): If USE_GTK, get
5004 min width by calling x_set_scroll_bar_default_width (Bug#8505).
5005
5006 2011-06-05 Juanma Barranquero <lekktu@gmail.com>
5007
5008 * xdisp.c (single_display_spec_intangible_p): Remove declaration.
5009
5010 2011-06-04 Chong Yidong <cyd@stupidchicken.com>
5011
5012 * xselect.c (x_clipboard_manager_save): Remove redundant arg.
5013 (x_clipboard_manager_save): Add return value.
5014 (x_clipboard_manager_error_1, x_clipboard_manager_error_2):
5015 New error handlers.
5016 (x_clipboard_manager_save_frame, x_clipboard_manager_save_all):
5017 Obey Vx_select_enable_clipboard_manager. Catch errors in
5018 x_clipboard_manager_save (Bug#8779).
5019 (Vx_select_enable_clipboard_manager): New variable.
5020 (x_get_foreign_selection): Reduce scope of x_catch_errors (Bug#8790).
5021
5022 2011-06-04 Dan Nicolaescu <dann@ics.uci.edu>
5023
5024 * emacs.c (main): Warn when starting a GTK emacs in daemon mode.
5025
5026 2011-06-04 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
5027
5028 * fringe.c (update_window_fringes): Don't update overlay arrow bitmap
5029 in the current matrix if keep_current_p is non-zero.
5030
5031 2011-06-04 Eli Zaretskii <eliz@gnu.org>
5032
5033 * bidi.c (bidi_level_of_next_char): Fix last change.
5034
5035 2011-06-03 Eli Zaretskii <eliz@gnu.org>
5036
5037 Support bidi reordering of text covered by display properties.
5038
5039 * bidi.c (bidi_copy_it): Use offsetof instead of emulating it.
5040 (bidi_fetch_char, bidi_fetch_char_advance): New functions.
5041 (bidi_cache_search, bidi_cache_iterator_state)
5042 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak)
5043 (bidi_level_of_next_char, bidi_move_to_visually_next):
5044 Support character positions inside a run of characters covered by a
5045 display string.
5046 (bidi_paragraph_init, bidi_resolve_explicit_1)
5047 (bidi_level_of_next_char): Call bidi_fetch_char and
5048 bidi_fetch_char_advance instead of FETCH_CHAR and
5049 FETCH_CHAR_ADVANCE.
5050 (bidi_init_it): Initialize new members.
5051 (LRE_CHAR, RLE_CHAR, PDF_CHAR, LRO_CHAR, RLO_CHAR): Remove macro
5052 definitions.
5053 (bidi_explicit_dir_char): Lookup character type in bidi_type_table,
5054 instead of using explicit *_CHAR codes.
5055 (bidi_resolve_explicit, bidi_resolve_weak):
5056 Use FETCH_MULTIBYTE_CHAR instead of FETCH_CHAR, as reordering of
5057 bidirectional text is supported only in multibyte buffers.
5058 (bidi_init_it): Accept additional argument FRAME_WINDOW_P and use
5059 it to initialize the frame_window_p member of struct bidi_it.
5060 (bidi_cache_iterator_state, bidi_resolve_explicit_1)
5061 (bidi_resolve_explicit, bidi_resolve_weak)
5062 (bidi_level_of_next_char, bidi_move_to_visually_next): Abort if
5063 bidi_it->nchars is non-positive.
5064 (bidi_level_of_next_char): Don't try to lookup the cache for the
5065 next/previous character if nothing is cached there yet, or if we
5066 were just reseat()'ed to a new position.
5067
5068 * xdisp.c (set_cursor_from_row): Set start and stop points
5069 according to the row's direction when priming the loop that looks
5070 for the glyph on which to display cursor.
5071 (single_display_spec_intangible_p): Function deleted.
5072 (display_prop_intangible_p): Reimplement to call
5073 handle_display_spec instead of single_display_spec_intangible_p.
5074 Accept 3 additional arguments needed by handle_display_spec.
5075 This fixes incorrect cursor motion across display property with complex
5076 values: lists, `(when COND...)' forms, etc.
5077 (single_display_spec_string_p): Support property values that are
5078 lists with the argument STRING its top-level element.
5079 (display_prop_string_p): Fix the condition for processing a
5080 property that is a list to be consistent with handle_display_spec.
5081 (handle_display_spec): New function, refactored from the
5082 last portion of handle_display_prop.
5083 (compute_display_string_pos): Accept additional argument
5084 FRAME_WINDOW_P. Call handle_display_spec to determine whether the
5085 value of a `display' property is a "replacing spec".
5086 (handle_single_display_spec): Accept 2 additional arguments BUFPOS
5087 and FRAME_WINDOW_P. If IT is NULL, don't set up the iterator from
5088 the display property, but just return a value indicating whether
5089 the display property will replace the characters it covers.
5090 (Fcurrent_bidi_paragraph_direction): Initialize the nchars and
5091 frame_window_p members of struct bidi_it.
5092 (compute_display_string_pos, compute_display_string_end):
5093 New functions.
5094 (push_it): Accept second argument POSITION, where pop_it should
5095 jump to continue iteration.
5096 (reseat_1): Initialize bidi_it.disp_pos.
5097
5098 * keyboard.c (adjust_point_for_property): Adjust the call to
5099 display_prop_intangible_p to its new signature.
5100
5101 * dispextern.h (struct bidi_it): New member frame_window_p.
5102 (bidi_init_it): Update prototypes.
5103 (display_prop_intangible_p): Update prototype.
5104 (compute_display_string_pos, compute_display_string_end):
5105 Declare prototypes.
5106 (struct bidi_it): New members nchars and disp_pos. ch_len is now
5107 EMACS_INT.
5108
5109 2011-06-02 Paul Eggert <eggert@cs.ucla.edu>
5110
5111 Malloc failure behavior now depends on size of allocation.
5112 * alloc.c (buffer_memory_full, memory_full): New arg NBYTES.
5113 * lisp.h: Change signatures accordingly.
5114 * alloc.c, buffer.c, editfns.c, menu.c, minibuf.c, xterm.c:
5115 All callers changed. (Bug#8762)
5116
5117 * gnutls.c: Use Emacs's memory allocators.
5118 Without this change, the gnutls library would invoke malloc etc.
5119 directly, which causes problems on non-SYNC_INPUT hosts, and which
5120 runs afoul of improving memory_full behavior. (Bug#8761)
5121 (fn_gnutls_global_set_mem_functions): New macro or function pointer.
5122 (emacs_gnutls_global_init): Use it to specify xmalloc, xrealloc,
5123 xfree instead of the default malloc, realloc, free.
5124 (Fgnutls_boot): No need to check for memory allocation failure,
5125 since xmalloc does that for us.
5126
5127 Remove arbitrary limit of 2**31 entries in hash tables. (Bug#8771)
5128 * category.c (hash_get_category_set):
5129 * ccl.c (ccl_driver):
5130 * charset.c (Fdefine_charset_internal):
5131 * charset.h (struct charset.hash_index):
5132 * composite.c (get_composition_id, gstring_lookup_cache)
5133 (composition_gstring_put_cache):
5134 * composite.h (struct composition.hash_index):
5135 * dispextern.h (struct image.hash):
5136 * fns.c (next_almost_prime, larger_vector, cmpfn_eql)
5137 (cmpfn_equal, cmpfn_user_defined, hashfn_eq, hashfn_eql)
5138 (hashfn_equal, hashfn_user_defined, make_hash_table)
5139 (maybe_resize_hash_table, hash_lookup, hash_put)
5140 (hash_remove_from_table, hash_clear, sweep_weak_table, SXHASH_COMBINE)
5141 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector)
5142 (Fsxhash, Fgethash, Fputhash, Fmaphash):
5143 * image.c (make_image, search_image_cache, lookup_image)
5144 (xpm_put_color_table_h):
5145 * lisp.h (struct Lisp_Hash_Table):
5146 * minibuf.c (Ftry_completion, Fall_completions, Ftest_completion):
5147 * print.c (print): Use 'EMACS_UINT' and 'EMACS_INT'
5148 for hashes and hash indexes, instead of 'unsigned' and 'int'.
5149 * alloc.c (allocate_vectorlike):
5150 Check for overflow in vector size calculations.
5151 * ccl.c (ccl_driver):
5152 Check for overflow when converting EMACS_INT to int.
5153 * fns.c, image.c: Remove unnecessary static decls that would otherwise
5154 need to be updated by these changes.
5155 * fns.c (make_hash_table, maybe_resize_hash_table):
5156 Check for integer overflow with large hash tables.
5157 (make_hash_table, maybe_resize_hash_table, Fmake_hash_table):
5158 Prefer the faster XFLOAT_DATA to XFLOATINT where either will do.
5159 (SXHASH_REDUCE): New macro.
5160 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector):
5161 Use it instead of discarding useful hash info with large hash values.
5162 (sxhash_float): New function.
5163 (sxhash): Use it. No more need for "& INTMASK" due to above changes.
5164 * lisp.h (FIXNUM_BITS): New macro, useful for SXHASH_REDUCE etc.
5165 (MOST_NEGATIVE_FIXNUM, MOST_POSITIVE_FIXNUM, INTMASK):
5166 Rewrite to use FIXNUM_BITS, as this simplifies things.
5167 (next_almost_prime, larger_vector, sxhash, hash_lookup, hash_put):
5168 Adjust signatures to match updated version of code.
5169 (consing_since_gc): Now EMACS_INT, since a single hash table can
5170 use more than INT_MAX bytes.
5171
5172 2011-06-01 Dan Nicolaescu <dann@ics.uci.edu>
5173
5174 Make it possible to build with GCC-4.6+ -O2 -flto.
5175
5176 * emacs.c (__malloc_initialize_hook): Mark as EXTERNALLY_VISIBLE.
5177
5178 2011-06-01 Stefan Monnier <monnier@iro.umontreal.ca>
5179
5180 * minibuf.c (get_minibuffer, read_minibuf_unwind):
5181 Call minibuffer-inactive-mode.
5182
5183 2011-05-31 Juanma Barranquero <lekktu@gmail.com>
5184
5185 * makefile.w32-in ($(BLD)/data.$(O), $(BLD)/editfns.$(O)):
5186 Update dependencies.
5187
5188 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
5189
5190 * data.c (init_data): Remove code for UTS, this system is not
5191 supported anymore.
5192
5193 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
5194
5195 Don't force ./temacs to start in terminal mode.
5196
5197 * frame.c (make_initial_frame): Initialize faces in all cases, not
5198 only when CANNOT_DUMP is defined.
5199 * dispnew.c (init_display): Remove CANNOT_DUMP condition.
5200
5201 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
5202
5203 * dispnew.c (add_window_display_history): Use const for the string
5204 pointer. Remove declaration, not needed.
5205
5206 2011-05-31 Paul Eggert <eggert@cs.ucla.edu>
5207
5208 Use 'inline', not 'INLINE'.
5209 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00914.html>
5210 * alloc.c, fontset.c (INLINE): Remove.
5211 * alloc.c, bidi.c, charset.c, coding.c, dispnew.c, fns.c, image.c:
5212 * intervals.c, keyboard.c, process.c, syntax.c, textprop.c, w32term.c:
5213 * xdisp.c, xfaces.c, xterm.c: Replace all uses of INLINE with inline.
5214 * gmalloc.c (register_heapinfo): Use inline unconditionally.
5215 * lisp.h (LISP_MAKE_RVALUE): Use inline, not __inline__.
5216
5217 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
5218
5219 Make it possible to run ./temacs.
5220
5221 * callproc.c (set_initial_environment): Remove CANNOT_DUMP code,
5222 syms_of_callproc does the same thing. Remove test for
5223 "initialized", do it in the caller.
5224 * emacs.c (main): Avoid calling set_initial_environment when dumping.
5225
5226 2011-05-31 Stefan Monnier <monnier@iro.umontreal.ca>
5227
5228 * minibuf.c (Finternal_complete_buffer): Return `category' metadata.
5229 (read_minibuf): Use get_minibuffer.
5230 (syms_of_minibuf): Use DEFSYM.
5231 (Qmetadata): New var.
5232 * data.c (Qbuffer): Don't make it static.
5233 (syms_of_data): Use DEFSYM.
5234
5235 2011-05-31 Paul Eggert <eggert@cs.ucla.edu>
5236
5237 * ccl.c (CCL_CODE_RANGE): Allow negative numbers. (Bug#8751)
5238 (CCL_CODE_MIN): New macro.
5239
5240 2011-05-30 Paul Eggert <eggert@cs.ucla.edu>
5241
5242 * alloc.c (lisp_align_malloc): Omit unnecessary val==NULL tests.
5243
5244 * eval.c (Qdebug): Now static.
5245 * lisp.h (Qdebug): Remove decl. This reverts a part of the
5246 2011-04-26T11:26:05Z!dan.colascione@gmail.com that inadvertently undid part of
5247 2011-04-14T06:48:41Z!eggert@cs.ucla.edu.
5248
5249 2011-05-29 Chong Yidong <cyd@stupidchicken.com>
5250
5251 * image.c: Various fixes to ImageMagick code comments.
5252 (Fimagemagick_types): Doc fix.
5253
5254 2011-05-29 Paul Eggert <eggert@cs.ucla.edu>
5255
5256 Minor fixes prompted by GCC 4.6.0 warnings.
5257
5258 * xselect.c (converted_selections, conversion_fail_tag): Now static.
5259
5260 * emacs.c [HAVE_X_WINDOWS]: Include "xterm.h".
5261 (x_clipboard_manager_save_all): Move extern decl to ...
5262 * xterm.h: ... here, so that it can be checked for consistency.
5263
5264 2011-05-29 Chong Yidong <cyd@stupidchicken.com>
5265
5266 * xselect.c (x_clipboard_manager_save_frame)
5267 (x_clipboard_manager_save_all): New functions.
5268 (Fx_clipboard_manager_save): Lisp function deleted.
5269
5270 * emacs.c (Fkill_emacs): Call x_clipboard_manager_save_all.
5271 * frame.c (delete_frame): Call x_clipboard_manager_save_frame.
5272
5273 * xterm.h: Update prototype.
5274
5275 2011-05-28 William Xu <william.xwl@gmail.com>
5276
5277 * nsterm.m (ns_term_shutdown): Synchronize user defaults before
5278 exiting (Bug#8239).
5279
5280 2011-05-28 Jim Meyering <meyering@redhat.com>
5281
5282 Avoid a sign-extension bug in crypto_hash_function.
5283 * fns.c (to_uchar): Define.
5284 (crypto_hash_function): Use it to convert some newly-signed
5285 variables to unsigned, to avoid sign-extension bugs. For example,
5286 without this change, (md5 "truc") would evaluate to
5287 45723a2aff78ff4fff7fff1114760e62 rather than the expected
5288 45723a2af3788c4ff17f8d1114760e62. Reported by Antoine Levitt in
5289 https://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00883.html.
5290
5291 2011-05-27 Paul Eggert <eggert@cs.ucla.edu>
5292
5293 Integer overflow fixes.
5294
5295 * dbusbind.c: Serial number integer overflow fixes.
5296 (CHECK_DBUS_SERIAL_GET_SERIAL): New macro.
5297 (Fdbus_call_method_asynchronously, xd_read_message_1): Use a float
5298 to hold a serial number that is too large for a fixnum.
5299 (Fdbus_method_return_internal, Fdbus_method_error_internal):
5300 Check for serial numbers out of range. Decode any serial number
5301 that was so large that it became a float. (Bug#8722)
5302
5303 * dbusbind.c: Use XFASTINT rather than XUINT, and check for nonneg.
5304 (Fdbus_call_method, Fdbus_call_method_asynchronously):
5305 Use XFASTINT rather than XUINT when numbers are nonnegative.
5306 (xd_append_arg, Fdbus_method_return_internal):
5307 (Fdbus_method_error_internal): Likewise. Also, for unsigned
5308 arguments, check that Lisp number is nonnegative, rather than
5309 silently wrapping negative numbers around. (Bug#8722)
5310 (xd_read_message_1): Don't assume dbus_uint32_t can fit in int.
5311 (Bug#8722)
5312
5313 * data.c (arith_driver, Flsh): Avoid unnecessary casts to EMACS_UINT.
5314
5315 * ccl.c (ccl_driver): Redo slightly to avoid the need for 'unsigned'.
5316
5317 ccl: add integer overflow checks
5318 * ccl.c (CCL_CODE_MAX, GET_CCL_RANGE, GET_CCL_CODE, GET_CCL_INT):
5319 (IN_INT_RANGE): New macros.
5320 (ccl_driver): Use them to check for integer overflow when
5321 decoding a CCL program. Many of the new checks are whether XINT (x)
5322 fits in int; it doesn't always, on 64-bit hosts. The new version
5323 doesn't catch all possible integer overflows, but it's an
5324 improvement. (Bug#8719)
5325
5326 * alloc.c (make_event_array): Use XINT, not XUINT.
5327 There's no need for unsigned here.
5328
5329 * mem-limits.h (EXCEEDS_LISP_PTR) [!USE_LSB_TAG]: EMACS_UINT -> uintptr_t
5330 This follows up to the 2011-05-06 change that substituted uintptr_t
5331 for EMACS_INT. This case wasn't caught back then.
5332
5333 Rework Fformat to avoid integer overflow issues.
5334 * editfns.c: Include <float.h> unconditionally, as it's everywhere
5335 now (part of C89). Include <verify.h>.
5336 (MAX_10_EXP, CONVERTED_BYTE_SIZE): Remove; no longer needed.
5337 (pWIDE, pWIDElen, signed_wide, unsigned_wide): New defns.
5338 (Fformat): Avoid the prepass trying to compute sizes; it was only
5339 approximate and thus did not catch overflow reliably. Instead, walk
5340 through the format just once, formatting and computing sizes as we go,
5341 checking for integer overflow at every step, and allocating a larger
5342 buffer as needed. Keep track separately whether the format is
5343 multibyte. Keep only the most-recently calculated precision, rather
5344 than them all. Record whether each argument has been converted to
5345 string. Use EMACS_INT, not int, for byte and char and arg counts.
5346 Support field widths and precisions larger than INT_MAX. Avoid
5347 sprintf's undefined behavior with conversion specifications such as %#d
5348 and %.0c. Fix bug with strchr succeeding on '\0' when looking for
5349 flags. Fix bug with (format "%c" 256.0). Avoid integer overflow when
5350 formatting out-of-range floating point numbers with int
5351 formats. (Bug#8668)
5352
5353 * lisp.h (FIXNUM_OVERFLOW_P): Work even if arg is a NaN.
5354
5355 * data.c: Avoid integer truncation in expressions involving floats.
5356 * data.c: Include <intprops.h>.
5357 (arith_driver): When there's an integer overflow in an expression
5358 involving floating point, convert the integers to floating point
5359 so that the resulting value does not suffer from catastrophic
5360 integer truncation. For example, on a 64-bit host (* 4
5361 most-negative-fixnum 0.5) should yield about -4.6e+18, not zero.
5362 Do not rely on undefined behavior after integer overflow.
5363
5364 merge count_size_as_multibyte, parse_str_to_multibyte
5365 * character.c, character.h (count_size_as_multibyte):
5366 Rename from parse_str_to_multibyte; all uses changed.
5367 Check for integer overflow.
5368 * insdel.c, lisp.h (count_size_as_multibyte): Remove,
5369 since it's now a duplicate of the other. This is more of
5370 a character than a buffer op, so better that it's in character.c.
5371 * fns.c, print.c: Adjust to above changes.
5372
5373 2011-05-27 Stefan Monnier <monnier@iro.umontreal.ca>
5374
5375 * xselect.c (x_convert_selection): Yet another int/Lisp_Object mixup.
5376
5377 2011-05-27 Paul Eggert <eggert@cs.ucla.edu>
5378
5379 * xselect.c: Fix minor problems prompted by GCC 4.6.0 warnings.
5380 (x_handle_selection_request, frame_for_x_selection): Remove unused vars.
5381 (x_clipboard_manager_save): Now static.
5382 (Fx_clipboard_manager_save): Rename local to avoid shadowing.
5383
5384 * fns.c: Fix minor problems prompted by GCC 4.6.0 warnings.
5385 (crypto_hash_function): Now static.
5386 Fix pointer signedness problems. Avoid unnecessary initializations.
5387
5388 2011-05-27 Chong Yidong <cyd@stupidchicken.com>
5389
5390 * termhooks.h (Vselection_alist): Make it terminal-local.
5391
5392 * terminal.c (create_terminal): Initialize it.
5393
5394 * xselect.c: Support for clipboard managers.
5395 (Vselection_alist): Move to termhooks.h as terminal-local var.
5396 (LOCAL_SELECTION): New macro.
5397 (x_atom_to_symbol): Handle x_display_info_for_display fail case.
5398 (symbol_to_x_atom): Remove gratuitous arg.
5399 (x_handle_selection_request, lisp_data_to_selection_data)
5400 (x_get_foreign_selection, Fx_register_dnd_atom): Callers changed.
5401 (x_own_selection, x_get_local_selection, x_convert_selection):
5402 New arg, specifying work frame. Use terminal-local Vselection_alist.
5403 (some_frame_on_display): Delete unused function.
5404 (Fx_own_selection_internal, Fx_get_selection_internal)
5405 (Fx_disown_selection_internal, Fx_selection_owner_p)
5406 (Fx_selection_exists_p): New optional frame arg.
5407 (frame_for_x_selection, Fx_clipboard_manager_save): New functions.
5408 (x_handle_selection_clear): Don't treat other terminals with the
5409 same keyboard specially. Use the terminal-local Vselection_alist.
5410 (x_clear_frame_selections): Use Frun_hook_with_args.
5411
5412 * xterm.c (x_term_init): Intern ATOM and CLIPBOARD_MANAGER atoms.
5413
5414 * xterm.h: Add support for those atoms.
5415
5416 2011-05-26 Chong Yidong <cyd@stupidchicken.com>
5417
5418 * xselect.c: ICCCM-compliant handling of MULTIPLE targets.
5419 (converted_selections, conversion_fail_tag): New global variables.
5420 (x_selection_request_lisp_error): Free the above.
5421 (x_get_local_selection): Remove unnecessary code.
5422 (x_reply_selection_request): Args changed; handle arbitrary array
5423 of converted selections stored in converted_selections.
5424 Separate the XChangeProperty and SelectionNotify steps.
5425 (x_handle_selection_request): Rewrite to handle MULTIPLE target.
5426 (x_convert_selection): New function.
5427 (x_handle_selection_event): Simplify.
5428 (x_get_foreign_selection): Don't ignore incoming requests while
5429 waiting for an answer; this will fail when we implement
5430 SAVE_TARGETS, and seems unnecessary anyway.
5431 (selection_data_to_lisp_data): Recognize ATOM_PAIR type.
5432 (Vx_sent_selection_functions): Doc fix.
5433
5434 2011-05-26 Leo Liu <sdl.web@gmail.com>
5435
5436 * editfns.c (Ftranspose_regions): Allow empty regions. (Bug#8699)
5437
5438 2011-05-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
5439
5440 * dispextern.h (struct glyph_row): New member fringe_bitmap_periodic_p.
5441
5442 * dispnew.c (shift_glyph_matrix, scrolling_window): Mark scrolled row
5443 for fringe update if it has periodic bitmap.
5444 (row_equal_p): Also compare left_fringe_offset, right_fringe_offset,
5445 and fringe_bitmap_periodic_p.
5446
5447 * fringe.c (get_fringe_bitmap_data): New function.
5448 (draw_fringe_bitmap_1, update_window_fringes): Use it.
5449 (update_window_fringes): Record periodicity of fringe bitmap in glyph
5450 row. Mark glyph row for fringe update if periodicity changed.
5451
5452 * xdisp.c (try_window_reusing_current_matrix): Don't mark scrolled row
5453 for fringe update unless it has periodic bitmap.
5454
5455 2011-05-25 Kenichi Handa <handa@m17n.org>
5456
5457 * xdisp.c (get_next_display_element): Set correct it->face_id for
5458 a static composition.
5459
5460 2011-05-24 Leo Liu <sdl.web@gmail.com>
5461
5462 * deps.mk (fns.o):
5463 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha1.h.
5464
5465 * fns.c (crypto_hash_function, Fsha1): New function.
5466 (Fmd5): Use crypto_hash_function.
5467 (syms_of_fns): Add Ssha1.
5468
5469 2011-05-22 Paul Eggert <eggert@cs.ucla.edu>
5470
5471 * gnutls.c: Remove unused macros.
5472 (fn_gnutls_transport_set_lowat, fn_gnutls_transport_set_pull_function):
5473 (fn_gnutls_transport_set_push_function) [!WINDOWSNT]:
5474 Remove macros that are defined and never used.
5475 Caught by gcc -Wunused-macros (GCC 4.6.0, Fedora 14).
5476
5477 2011-05-22 Chong Yidong <cyd@stupidchicken.com>
5478
5479 * xselect.c (syms_of_xselect): Remove unused symbol SAVE_TARGETS.
5480 (Fx_get_selection_internal): Minor cleanup.
5481 (Fx_own_selection_internal): Rename arguments for consistency with
5482 select.el.
5483
5484 2011-05-22 Paul Eggert <eggert@cs.ucla.edu>
5485
5486 * xselect.c (QSAVE_TARGETS): New static var, to fix build failure.
5487
5488 2011-05-22 Chong Yidong <cyd@stupidchicken.com>
5489
5490 * xselect.c (syms_of_xselect): Include character.h; use DEFSYM.
5491
5492 2011-05-21 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
5493
5494 * dispnew.c (scrolling_window): Don't exclude the case that the
5495 last enabled row in the desired matrix touches the bottom boundary.
5496
5497 2011-05-21 Glenn Morris <rgm@gnu.org>
5498
5499 * Makefile.in ($(etc)/DOC): Make second command line even shorter.
5500 (SOME_MACHINE_OBJECTS): Replace FONT_OBJ by its maximal expansion,
5501 and add some more files.
5502
5503 2011-05-20 Eli Zaretskii <eliz@gnu.org>
5504
5505 * callproc.c (Fcall_process) [MSDOS]: Fix arguments to
5506 report_file_error introduced by the change from 2011-05-07.
5507
5508 2011-05-20 Paul Eggert <eggert@cs.ucla.edu>
5509
5510 * systime.h (Time): Define only if emacs is defined.
5511 This is to allow ../lib-src/profile.c to be compiled on FreeBSD,
5512 where the include path doesn't have X11/X.h by default. See
5513 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00561.html>.
5514
5515 2011-05-20 Kenichi Handa <handa@m17n.org>
5516
5517 * composite.c (find_automatic_composition): Fix previous change.
5518
5519 2011-05-20 Glenn Morris <rgm@gnu.org>
5520
5521 * lisp.mk: New file, split from Makefile.in.
5522 * Makefile.in (lisp): Move to separate file, inserted by @lisp_frag@.
5523 (shortlisp): Remove.
5524 ($(etc)/DOC): Edit lisp.mk rather than using $shortlisp.
5525
5526 2011-05-19 Glenn Morris <rgm@gnu.org>
5527
5528 * Makefile.in (MSDOS_SUPPORT_REAL, MSDOS_SUPPORT, NS_SUPPORT)
5529 (REAL_MOUSE_SUPPORT, GPM_MOUSE_SUPPORT, MOUSE_SUPPORT, TOOLTIP_SUPPORT)
5530 (BASE_WINDOW_SUPPORT, X_WINDOW_SUPPORT, WINDOW_SUPPORT): Remove.
5531 (lisp): Set the order to that of loadup.el.
5532 (shortlisp): Make it a copy of $lisp.
5533 (SOME_MACHINE_LISP): Remove.
5534 ($(etc)/DOC): Depend just on $lisp, not $SOME_MACHINE_LISP too.
5535 Use just $shortlisp, not $SOME_MACHINE_LISP too.
5536
5537 2011-05-18 Kenichi Handa <handa@m17n.org>
5538
5539 * composite.c (CHAR_COMPOSABLE_P): Add more check for efficiency.
5540 (BACKWARD_CHAR): Wrap the arg STOP by parenthesis.
5541 (find_automatic_composition): Mostly rewrite for efficiency.
5542
5543 2011-05-18 Juanma Barranquero <lekktu@gmail.com>
5544
5545 * makefile.w32-in: Update dependencies.
5546
5547 2011-05-18 Christoph Scholtes <cschol2112@googlemail.com>
5548
5549 * menu.c: Include limits.h (fixes the MS-Windows build broken by
5550 2011-06-18T18:49:19Z!cyd@stupidchicken.com).
5551
5552 2011-05-18 Paul Eggert <eggert@cs.ucla.edu>
5553
5554 Fix some integer overflow issues, such as string length overflow.
5555
5556 * insdel.c (count_size_as_multibyte): Check for string overflow.
5557
5558 * character.c (lisp_string_width): Check for string overflow.
5559 Use EMACS_INT, not int, for string indexes and lengths; in
5560 particular, 2nd arg is now EMACS_INT, not int. Do not crash if
5561 the resulting string length overflows an EMACS_INT; instead,
5562 report a string overflow if no precision given. When checking for
5563 precision exhaustion, use a check that cannot possibly have
5564 integer overflow. (Bug#8675)
5565 * character.h (lisp_string_width): Adjust to new signature.
5566
5567 * alloc.c (string_overflow): New function.
5568 (Fmake_string): Use it. This doesn't change behavior, but saves
5569 a few bytes and will simplify future changes.
5570 * character.c (string_escape_byte8): Likewise.
5571 * lisp.h (string_overflow): New decl.
5572
5573 Fixups, following up to the user-interface timestamp change.
5574 * nsterm.m (last_mouse_movement_time, ns_mouse_position): Use Time
5575 for UI timestamps, instead of unsigned long.
5576 * msdos.c (mouse_get_pos): Likewise.
5577 * w32inevt.c (movement_time, w32_console_mouse_position): Likewise.
5578 * w32gui.h (Time): Define by including "systime.h" rather than by
5579 declaring it ourselves. (Bug#8664)
5580
5581 * dispextern.h (struct image): Don't assume time_t <= unsigned long.
5582 * image.c (clear_image_cache): Likewise.
5583
5584 * term.c (term_mouse_position): Don't assume time_t wraparound.
5585
5586 Be more systematic about user-interface timestamps.
5587 Before, the code sometimes used 'Time', sometimes 'unsigned long',
5588 and sometimes 'EMACS_UINT', to represent these timestamps.
5589 This change causes it to use 'Time' uniformly, as that's what X uses.
5590 This makes the code easier to follow, and makes it easier to catch
5591 integer overflow bugs such as Bug#8664.
5592 * frame.c (Fmouse_position, Fmouse_pixel_position):
5593 Use Time, not unsigned long, for user-interface timestamps.
5594 * keyboard.c (last_event_timestamp, kbd_buffer_get_event): Likewise.
5595 (button_down_time, make_lispy_position, make_lispy_movement): Likewise.
5596 * keyboard.h (last_event_timestamp): Likewise.
5597 * menu.c (Fx_popup_menu) [!HAVE_X_WINDOWS]: Likewise.
5598 * menu.h (xmenu_show): Likewise.
5599 * term.c (term_mouse_position): Likewise.
5600 * termhooks.h (struct input_event.timestamp): Likewise.
5601 (struct terminal.mouse_position_hook): Likewise.
5602 * xmenu.c (create_and_show_popup_menu, xmenu_show): Likewise.
5603 * xterm.c (XTmouse_position, x_scroll_bar_report_motion): Likewise.
5604 * systime.h (Time): New decl. Pull it in from <X11/X.h> if
5605 HAVE_X_WINDOWS, otherwise define it as unsigned long, which is
5606 what it was before.
5607 * menu.h, termhooks.h: Include "systime.h", for Time.
5608
5609 * keyboard.c (make_lispy_event): Fix problem in integer overflow.
5610 Don't assume that the difference between two unsigned long values
5611 can fit into an integer. At this point, we know button_down_time
5612 <= event->timestamp, so the difference must be nonnegative, so
5613 there's no need to cast the result if double-click-time is
5614 nonnegative, as it should be; check that it's nonnegative, just in
5615 case. This bug is triggered when events are more than 2**31 ms
5616 apart (about 25 days). (Bug#8664)
5617
5618 * xselect.c (last_event_timestamp): Remove duplicate decl.
5619 (x_own_selection): Remove needless cast to unsigned long.
5620
5621 * xmenu.c (set_frame_menubar): Use int, not EMACS_UINT, for indexes
5622 that always fit in int. Use a sentinel instead of a counter, to
5623 avoid a temp and to allay GCC's concerns about possible int overflow.
5624 * frame.h (struct frame): Use int for menu_bar_items_used
5625 instead of EMACS_INT, since it always fits in int.
5626
5627 * menu.c (grow_menu_items): Check for int overflow.
5628
5629 * xmenu.c (set_frame_menubar): Don't mishandle vectors with no nils.
5630
5631 * xterm.c: Use EMACS_INT for Emacs modifiers, and int for X modifiers.
5632 Before, the code was not consistent. These values cannot exceed
5633 2**31 - 1 so there's no need to make them unsigned.
5634 (x_x_to_emacs_modifiers): Accept int and return EMACS_INT.
5635 (x_emacs_to_x_modifiers): Accept EMACS_INT and return int.
5636 (x_x_to_emacs_modifiers, x_emacs_to_x_modifiers): Reject non-integers
5637 as modifiers.
5638 * xterm.h (x_x_to_emacs_modifiers): Adjust to signature change.
5639
5640 * lisp.h (XINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_INT.
5641 (XUINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_UINT.
5642 Otherwise, GCC 4.6.0 warns about printf (pI, XINT (...)),
5643 presumably because the widths might not match.
5644
5645 * window.c (size_window): Avoid needless test at loop start.
5646
5647 2011-05-18 Courtney Bane <emacs-bugs-7626@cbane.org> (tiny change)
5648
5649 * term.c (Fresume_tty): Restore hooks before reinitializing (bug#8687).
5650
5651 2011-05-12 Drew Adams <drew.adams@oracle.com>
5652
5653 * textprop.c (Fprevious_single_char_property_change): Doc fix (bug#8655).
5654
5655 2011-05-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
5656
5657 * w32term.c (w32_draw_fringe_bitmap): Rename local vars `left' and
5658 `width' to `bar_area_x' and `bar_area_width', respectively.
5659 (x_scroll_run): Take account of fringe background extension.
5660
5661 * xterm.c (x_draw_fringe_bitmap) [USE_TOOLKIT_SCROLL_BARS]:
5662 Rename local vars `left' and `width' to `bar_area_x' and
5663 `bar_area_width', respectively.
5664 (x_scroll_run) [USE_TOOLKIT_SCROLL_BARS]: Take account of fringe
5665 background extension.
5666
5667 2011-05-10 Jim Meyering <meyering@redhat.com>
5668
5669 * xdisp.c (x_intersect_rectangles): Fix typo "the the -> the".
5670
5671 2011-05-10 Juanma Barranquero <lekktu@gmail.com>
5672
5673 * image.c (Finit_image_library): Return t for built-in image types,
5674 like pbm and xbm. (Bug#8640)
5675
5676 2011-05-09 Andreas Schwab <schwab@linux-m68k.org>
5677
5678 * w32menu.c (set_frame_menubar): Fix submenu allocation.
5679
5680 2011-05-07 Eli Zaretskii <eliz@gnu.org>
5681
5682 * w32console.c (Fset_screen_color): Doc fix.
5683 (Fget_screen_color): New function.
5684 (syms_of_ntterm): Defsubr it.
5685
5686 * callproc.c (call_process_cleanup) [MSDOS]: Don't close and
5687 unlink the temporary file if Fcall_process didn't create it in the
5688 first place.
5689 (Fcall_process) [MSDOS]: Don't create tempfile if stdout of the
5690 child process will be redirected to a file specified with `:file'.
5691 Don't try to re-open tempfile in that case, and set fd[0] to -1 as
5692 cue to call_process_cleanup not to close that handle.
5693
5694 2011-05-07 Ben Key <bkey76@gmail.com>
5695
5696 * makefile.w32-in: The bootstrap-temacs rule now makes use of
5697 one of two shell specific rules, either bootstrap-temacs-CMD or
5698 bootstrap-temacs-SH. The bootstrap-temacs-SH rule is identical
5699 to the previous implementation of the bootstrap-temacs rule.
5700 The bootstrap-temacs-CMD rule is similar to the previous
5701 implementation of the bootstrap-temacs rule except that it
5702 makes use of the ESC_CFLAGS variable instead of the CFLAGS
5703 variable.
5704
5705 These changes, along with some changes to nt/configure.bat,
5706 nt/gmake.defs, and nt/nmake.defs, are required to extend my
5707 earlier fix to add support for --cflags and --ldflags options
5708 that include quotes so that it works whether make uses cmd or
5709 sh as the shell.
5710
5711 2011-05-06 Michael Albinus <michael.albinus@gmx.de>
5712
5713 * dbusbind.c (QCdbus_type_unix_fd): Declare static.
5714 (xd_remove_watch): Don't check QCdbus_type_unix_fd for SYMBOLP, it
5715 is a constant.
5716 (Fdbus_init_bus, xd_read_queued_messages): Bus can be a symbol or
5717 a string. Handle both cases.
5718 (Fdbus_call_method_asynchronously, Fdbus_register_signal)
5719 (Fdbus_register_method): Use Qinvalid_function.
5720
5721 2011-05-06 Juanma Barranquero <lekktu@gmail.com>
5722
5723 * makefile.w32-in: Update dependencies.
5724 (LISP_H): Add inttypes.h and stdin.h.
5725 (PROCESS_H): Add unistd.h.
5726
5727 2011-05-06 Eli Zaretskii <eliz@gnu.org>
5728
5729 * lread.c: Include limits.h (fixes the MS-Windows build broken by
5730 2011-05-06T07:13:19Z!eggert@cs.ucla.edu).
5731
5732 2011-05-06 Paul Eggert <eggert@cs.ucla.edu>
5733
5734 * image.c (Finit_image_library) [!HAVE_NTGUI]: Omit unused local.
5735
5736 * term.c (vfatal): Remove stray call to va_end.
5737 It's not needed and the C Standard doesn't allow it here anyway.
5738
5739 Use C99's va_copy to avoid undefined behavior on x86-64 GNU/Linux.
5740 * eval.c (verror): doprnt a copy of ap, not the original. (Bug#8545)
5741
5742 * eval.c (verror): OK to create a string of up to MOST_POSITIVE_FIXNUM
5743 bytes.
5744
5745 * term.c: Don't include <stdarg.h>, as <lisp.h> does that.
5746
5747 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
5748
5749 * process.c (Fformat_network_address): Fix typo: args2 -> *args2.
5750
5751 * xmenu.c (set_frame_menubar): Fix typo: int * -> int (3 times).
5752
5753 * coding.c (detect_coding_charset): Fix typo: * 2 -> *4 (Bug#8601).
5754
5755 * charset.h (struct charset.code_space): Now has 15 elements, not 16.
5756 * charset.c (Fdefine_charset_internal): Don't initialize
5757 charset.code_space[15]. The value was garbage, on hosts with
5758 32-bit int (Bug#8600).
5759
5760 * lread.c (read_integer): Be more consistent with string-to-number.
5761 Use string_to_number to do the actual conversion; this avoids
5762 rounding errors and fixes some other screwups. Without this fix,
5763 for example, #x1fffffffffffffff was misread as -2305843009213693952.
5764 (digit_to_number): Move earlier, for benefit of read_integer.
5765 Return -1 if the digit is out of range for the base, -2 if it is
5766 not a digit in any supported base. (Bug#8602)
5767
5768 * doprnt.c (doprnt): Support arbitrary pI values, such as "I64".
5769
5770 * dispnew.c (scrolling_window): Return 1 if we scrolled,
5771 to match comment at start of function. This also removes a
5772 GCC warning about overflow in a 32+64-bit port.
5773
5774 * lisp.h (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Simplify.
5775
5776 * dbusbind.c: Do not use XPNTR on a value that may be an integer.
5777 Reported by Stefan Monnier in
5778 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00919.html>.
5779 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
5780 Use SYMBOLP-guarded XSYMBOL, not XPNTR.
5781
5782 * lisp.h (EMACS_INTPTR): Remove. All uses changed to intptr_t.
5783 (EMACS_UINTPTR): Likewise, with uintptr_t.
5784
5785 * lisp.h: Prefer 64-bit EMACS_INT if available.
5786 (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Define to 64-bit
5787 on 32-bit hosts that have 64-bit int, so that they can access
5788 large files.
5789 However, temporarily disable this change unless the temporary
5790 symbol WIDE_EMACS_INT is defined.
5791
5792 * lread.c, process.c: Do not include <inttypes.h>; lisp.h does it now.
5793
5794 Prefer intptr_t/uintptr_t for integers the same widths as pointers.
5795 This removes an assumption that EMACS_INT and long are the same
5796 width as pointers. The assumption is true for Emacs porting targets
5797 now, but we want to make other targets possible.
5798 * lisp.h: Include <inttypes.h>, for INTPTR_MAX, UINTPTR_MAX.
5799 (EMACS_INTPTR, EMACS_UINTPTR): New macros.
5800 In the rest of the code, change types of integers that hold casted
5801 pointers to EMACS_INTPTR and EMACS_UINTPTR, systematically
5802 replacing EMACS_INT, long, EMACS_UINT, and unsigned long.
5803 (XTYPE): Don't cast arg to EMACS_UINT; normally is not needed.
5804 (XSET): Cast type of XTYPE arg to EMACS_INTPTR; it is needed here.
5805 No need to cast type when ORing.
5806 (XPNTR): Return a value of type EMACS_INTPTR or EMACS_UINTPTR.
5807 * alloc.c (lisp_align_malloc): Remove a no-longer-needed cast.
5808 * doc.c (store_function_docstring): Use EMACS_INTPTR, so as not to
5809 assume EMACS_INT is the same width as char *.
5810 * gtkutil.c (xg_gtk_scroll_destroy, xg_tool_bar_button_cb):
5811 (xg_tool_bar_callback, xg_tool_bar_help_callback, xg_make_tool_item):
5812 Remove no-longer-needed casts.
5813 (xg_create_scroll_bar, xg_tool_bar_button_cb, xg_tool_bar_callback):
5814 (xg_tool_bar_help_callback, xg_make_tool_item):
5815 Use EMACS_INTPTR to hold an integer
5816 that will be cast to void *; this can avoid a GCC warning
5817 if EMACS_INT is not the same width as void *.
5818 * menu.c (find_and_call_menu_selection): Remove no-longer-needed cast.
5819 * xdisp.c (display_echo_area_1, resize_mini_window_1):
5820 (current_message_1, set_message_1):
5821 Use a local to convert to proper width without a cast.
5822 * xmenu.c (dialog_selection_callback): Likewise.
5823
5824 * sysdep.c (get_random): Don't assume EMACS_INT is no wider than long.
5825 Also, don't assume VALBITS / RAND_BITS is less than 5,
5826 and don't rely on undefined behavior when shifting a 1 left into
5827 the sign bit.
5828 * lisp.h (get_random): Change signature to match.
5829
5830 * lread.c (hash_string): Use size_t, not int, for hash computation.
5831 Normally we prefer signed values; but hashing is special, because
5832 it's better to use unsigned division on hash table sizes so that
5833 the remainder is nonnegative. Also, size_t is the natural width
5834 for hashing into memory. The previous code used 'int', which doesn't
5835 retain enough info to hash well into very large tables.
5836 (oblookup, oblookup_last_bucket_number, Funintern): Likewise.
5837
5838 * dbusbind.c: Don't possibly lose pointer info when converting.
5839 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
5840 Use XPNTR rather than XHASH, so that the high-order bits of
5841 the pointer aren't lost when converting through void *.
5842
5843 * eval.c (Fautoload): Don't double-shift a pointer.
5844
5845 * fns.c (Frandom): Let EMACS_UINT be wider than unsigned long.
5846
5847 2011-05-06 Juanma Barranquero <lekktu@gmail.com>
5848
5849 * gnutls.c (DEF_GNUTLS_FN):
5850 * image.c (DEF_IMGLIB_FN): Make function pointers static.
5851
5852 2011-05-05 Andreas Schwab <schwab@linux-m68k.org>
5853
5854 * lread.c (lisp_file_lexically_bound_p): Stop scanning at end
5855 marker. (Bug#8610)
5856
5857 2011-05-05 Eli Zaretskii <eliz@gnu.org>
5858
5859 * w32heap.c (allocate_heap) [USE_LISP_UNION_TYPE || USE_LSB_TAG]:
5860 New version that can reserve upto 2GB of heap space.
5861
5862 2011-05-05 Chong Yidong <cyd@stupidchicken.com>
5863
5864 * nsfns.m (Fns_read_file_name): Doc fix (Bug#8534).
5865
5866 2011-05-05 Teodor Zlatanov <tzz@lifelogs.com>
5867
5868 * gnutls.c (fn_gnutls_certificate_set_x509_key_file): Add alias to
5869 `gnutls_certificate_set_x509_key_file'.
5870
5871 2011-05-05 Juanma Barranquero <lekktu@gmail.com>
5872
5873 * makefile.w32-in ($(BLD)/image.$(O), $(BLD)/process.$(O)):
5874 Update dependencies.
5875
5876 2011-05-04 Juanma Barranquero <lekktu@gmail.com>
5877
5878 * gnutls.h (emacs_gnutls_write, emacs_gnutls_read):
5879 * gnutls.c (emacs_gnutls_write, emacs_gnutls_read):
5880 Remove unused parameter `fildes'.
5881 * process.c (read_process_output, send_process): Don't pass it.
5882
5883 2011-05-04 Juanma Barranquero <lekktu@gmail.com>
5884
5885 Fix previous change: the library cache is defined in w32.c.
5886 * image.c (CACHE_IMAGE_TYPE) [!HAVE_NTGUI]: Define to noop.
5887 (Finit_image_library): Wrap Vlibrary_cache on "#ifdef HAVE_NTGUI".
5888
5889 2011-05-04 Juanma Barranquero <lekktu@gmail.com>
5890
5891 Implement dynamic loading of GnuTLS on Windows.
5892
5893 * gnutls.h (GNUTLS_EMACS_ERROR_NOT_LOADED): New macro.
5894 (emacs_gnutls_write, emacs_gnutls_read): Mark as extern.
5895 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
5896 Declare.
5897
5898 * gnutls.c (Qgnutls_dll): Define.
5899 (DEF_GNUTLS_FN, LOAD_GNUTLS_FN): New macros.
5900 (gnutls_*): Declare function pointers.
5901 (init_gnutls_functions): New function to initialize function pointers.
5902 (emacs_gnutls_handshake, Fgnutls_error_string, Fgnutls_deinit)
5903 (emacs_gnutls_global_init, Fgnutls_bye): Use function pointers.
5904 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
5905 Wrappers for gnutls_record_check_pending and gnutls_transport_set_errno.
5906 (emacs_gnutls_write, emacs_gnutls_read)
5907 (emacs_gnutls_handle_error, Fgnutls_error_fatalp)
5908 (Fgnutls_available_p): New function.
5909 (Fgnutls_boot): Call Fgnutls_available_p. Use function pointers.
5910 (syms_of_gnutls) <Qgnutls_dll>: Initialize and staticpro it.
5911 (syms_of_gnutls) <Sgnutls_available_p>: defsubr it.
5912
5913 * image.c: Include w32.h.
5914 (Vimage_type_cache): Delete.
5915 (syms_of_image) <Vimage_type_cache>: Don't initialize and staticpro it.
5916 (CACHE_IMAGE_TYPE, Finit_image_library): Use Vlibrary_cache instead.
5917 (w32_delayed_load): Move to w32.c.
5918
5919 * w32.h (VlibraryCache, QCloaded_from, w32_delayed_load): Declare.
5920
5921 * w32.c (QCloaded_from, Vlibrary_cache): Define.
5922 (w32_delayed_load): Move from image.c. When loading a library, record
5923 its filename in the :loaded-from property of the library id.
5924 (globals_of_w32) <QCloaded_from, Vlibrary_cache>:
5925 Initialize and staticpro them.
5926 (emacs_gnutls_pull, emacs_gnutls_push): Call emacs_gnutls_* functions.
5927
5928 * process.c: Include lisp.h before w32.h, not after.
5929 (wait_reading_process_output): Call emacs_gnutls_record_check_pending
5930 instead of gnutls_record_check_pending.
5931
5932 * callproc.c, emacs.c: Include lisp.h before w32.h, not after.
5933
5934 2011-05-04 Teodor Zlatanov <tzz@lifelogs.com>
5935
5936 * gnutls.c (Fgnutls_boot): Support :keylist and :crlfiles options
5937 instead of :keyfiles. Give GnuTLS the keylist and the CRL lists
5938 as passed in.
5939
5940 2011-05-03 Jan Djärv <jan.h.d@swipnet.se>
5941
5942 * xterm.c (x_set_frame_alpha): Do not set property on anything
5943 else than FRAME_X_OUTER_WINDOW (Bug#8608).
5944
5945 2011-05-02 Juanma Barranquero <lekktu@gmail.com>
5946
5947 * sysdep.c (get_tty_size) [WINDOWSNT]: Implement. (Bug#8596)
5948
5949 2011-05-02 Juanma Barranquero <lekktu@gmail.com>
5950
5951 * gnutls.c (Qgnutls_log_level, Qgnutls_code, Qgnutls_anon)
5952 (Qgnutls_x509pki, Qgnutls_e_interrupted, Qgnutls_e_again)
5953 (Qgnutls_e_invalid_session, Qgnutls_e_not_ready_for_handshake)
5954 (gnutls_global_initialized, Qgnutls_bootprop_priority)
5955 (Qgnutls_bootprop_trustfiles, Qgnutls_bootprop_keyfiles)
5956 (Qgnutls_bootprop_callbacks, Qgnutls_bootprop_loglevel)
5957 (Qgnutls_bootprop_hostname, Qgnutls_bootprop_verify_flags)
5958 (Qgnutls_bootprop_verify_error, Qgnutls_bootprop_verify_hostname_error)
5959 (Qgnutls_bootprop_callbacks_verify): Make static.
5960
5961 2011-05-01 Andreas Schwab <schwab@linux-m68k.org>
5962
5963 * callproc.c: Indentation fixup.
5964
5965 * sysdep.c (wait_for_termination_1): Make static.
5966 (wait_for_termination, interruptible_wait_for_termination):
5967 Move after wait_for_termination_1.
5968
5969 2011-05-01 Lars Magne Ingebrigtsen <larsi@gnus.org>
5970
5971 * sysdep.c (interruptible_wait_for_termination): New function
5972 which is like wait_for_termination, but allows keyboard
5973 interruptions.
5974
5975 * callproc.c (Fcall_process): Add (:file "file") as an option for
5976 the STDOUT buffer.
5977 (Fcall_process_region): Ditto.
5978
5979 2011-04-30 Eli Zaretskii <eliz@gnu.org>
5980
5981 * dosfns.c (Fint86, Fdos_memget, Fdos_memput): Use `ASIZE (FOO)'
5982 rather than `XVECTOR (FOO)->size'.
5983
5984 * process.c: Remove HAVE_INTTYPES_H condition from inclusion of
5985 inttypes.h, as a gnulib replacement is used if it not available in
5986 system headers.
5987
5988 2011-04-21 Eli Zaretskii <eliz@gnu.org>
5989
5990 Lift the MOST_POSITIVE_FIXNUM/4 limitation on visited files.
5991 * fileio.c (Finsert_file_contents): Don't limit file size to 1/4
5992 of MOST_POSITIVE_FIXNUM. (Bug#8528)
5993
5994 * coding.c (coding_alloc_by_realloc): Error out if destination
5995 will grow beyond MOST_POSITIVE_FIXNUM.
5996 (decode_coding_emacs_mule): Abort if there isn't enough place in
5997 charbuf for the composition carryover bytes. Reserve an extra
5998 space for up to 2 characters produced in a loop.
5999 (decode_coding_iso_2022): Abort if there isn't enough place in
6000 charbuf for the composition carryover bytes.
6001
6002 2011-04-21 Eli Zaretskii <eliz@gnu.org>
6003
6004 * doprnt.c (doprnt) [!HAVE_LONG_LONG_INT]: Error out instead of
6005 aborting when %lld or %lll format is passed.
6006 [!HAVE_UNSIGNED_LONG_LONG_INT]: Error out instead of aborting when
6007 %llo or %llx format is passed. (Bug#8545)
6008
6009 * window.c (window_scroll_line_based): Use a marker instead of
6010 simple variables to record original value of point. (Bug#7952)
6011
6012 * doprnt.c (doprnt): Fix the case where a multibyte sequence
6013 produced by %s or %c overflows available buffer space. (Bug#8545)
6014
6015 2011-04-28 Paul Eggert <eggert@cs.ucla.edu>
6016
6017 * doprnt.c (doprnt): Omit useless test; int overflow check (Bug#8545).
6018 (SIZE_MAX): Move defn after all includes, as they might #define it.
6019
6020 2011-04-28 Juanma Barranquero <lekktu@gmail.com>
6021
6022 * w32.c (init_environment): Warn about defaulting HOME to C:\.
6023
6024 2011-04-28 Juanma Barranquero <lekktu@gmail.com>
6025
6026 * keyboard.c (Qdelayed_warnings_hook): Define.
6027 (command_loop_1): Run `delayed-warnings-hook'
6028 if Vdelayed_warnings_list is non-nil.
6029 (syms_of_keyboard) <delayed-warnings-hook>: DEFSYM it.
6030 (syms_of_keyboard) <delayed-warnings-list>: DEFVAR_LISP it.
6031
6032 2011-04-28 Eli Zaretskii <eliz@gnu.org>
6033
6034 * doprnt.c (doprnt): Don't return value smaller than the buffer
6035 size if the message was truncated. (Bug#8545).
6036
6037 2011-04-28 Juanma Barranquero <lekktu@gmail.com>
6038
6039 * w32fns.c (Fx_change_window_property, Fx_delete_window_property)
6040 (Fx_window_property): #if-0 the whole functions, not just the bodies.
6041
6042 2011-04-27 Paul Eggert <eggert@cs.ucla.edu>
6043
6044 * doprnt.c (doprnt): Support "ll" length modifier, for long long.
6045
6046 2011-04-27 Juanma Barranquero <lekktu@gmail.com>
6047
6048 * makefile.w32-in: Update dependencies.
6049
6050 2011-04-27 Eli Zaretskii <eliz@gnu.org>
6051
6052 Improve `doprnt' and its usage. (Bug#8545)
6053 * doprnt.c (doprnt): Make sure `format' is never accessed beyond
6054 `format_end'. Remove support for %l as a conversion specifier.
6055 Don't use xrealloc. Improve diagnostics when the %l size modifier
6056 is used. Update the commentary.
6057
6058 * eval.c (verror): Simplify calculation of size_t.
6059
6060 * coding.c (Ffind_operation_coding_system): Fix diagnostic error
6061 messages.
6062
6063 2011-04-27 Yoshiaki Kasahara <kasahara@nc.kyushu-u.ac.jp> (tiny change)
6064
6065 * buffer.c (init_buffer) [USE_MMAP_FOR_BUFFERS]: Adjust to aliasing
6066 change.
6067
6068 2011-04-27 Paul Eggert <eggert@cs.ucla.edu>
6069
6070 * nsmenu.m: Replace all uses of XVECTOR with ASIZE and AREF.
6071 This makes this file independent of the recent pseudovector change.
6072
6073 2011-04-26 Paul Eggert <eggert@cs.ucla.edu>
6074
6075 * keyboard.c (handle_user_signal): Fix pointer signedness problem.
6076
6077 * gnutls.c (emacs_gnutls_handle_error): Remove unused local.
6078 (Fgnutls_boot): gnutls_certificate_verify_peers2 wants unsigned *.
6079 Remove unused local.
6080 (emacs_gnutls_write): Don't use uninitialized rtnval if nbyte <= 0.
6081
6082 * lisp.h: Fix a problem with aliasing and vector headers. (Bug#8546)
6083 GCC 4.6.0 optimizes based on type-based alias analysis.
6084 For example, if b is of type struct buffer * and v of type struct
6085 Lisp_Vector *, then gcc -O2 was incorrectly assuming that &b->size
6086 != &v->size, and therefore "v->size = 1; b->size = 2; return
6087 v->size;" must therefore return 1. This assumption is incorrect
6088 for Emacs, since it type-puns struct Lisp_Vector * with many other
6089 types. To fix this problem, this patch adds a new type struct
6090 vectorlike_header that documents the constraints on layout of vectors
6091 and pseudovectors, and helps optimizing compilers not get fooled
6092 by Emacs's type punning. It also adds the macros XSETTYPED_PVECTYPE
6093 XSETTYPED_PSEUDOVECTOR, TYPED_PSEUDOVECTORP, for similar reasons.
6094 * lisp.h (XSETTYPED_PVECTYPE): New macro, specifying the name of
6095 the size member.
6096 (XSETPVECTYPE): Rewrite in terms of new macro.
6097 (XSETPVECTYPESIZE): New macro, specifying both type and size.
6098 This is a bit clearer, and further avoids the possibility of
6099 undesirable aliasing.
6100 (XSETTYPED_PSEUDOVECTOR): New macro, specifying the size.
6101 (XSETPSEUDOVECTOR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR.
6102 (XSETSUBR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR and XSIZE,
6103 since Lisp_Subr is a special case (no "next" field).
6104 (ASIZE): Now uses header.size rather than size.
6105 All previous uses of XVECTOR (foo)->size replaced to use this macro,
6106 to avoid the hassle of writing XVECTOR (foo)->header.size.
6107 (struct vectorlike_header): New type.
6108 (TYPED_PSEUDOVECTORP): New macro, also specifying the C type of the
6109 object, to help avoid aliasing.
6110 (PSEUDOVECTORP): Rewrite in terms of TYPED_PSEUDOVECTORP.
6111 (SUBRP): Likewise, since Lisp_Subr is a special case.
6112 * lisp.h (struct Lisp_Vector, struct Lisp_Char_Table):
6113 (struct Lisp_Sub_Char_Table, struct Lisp_Bool_Vector):
6114 (struct Lisp_Hash_Table): Combine first two members into a single
6115 struct vectorlike_header member. All uses of "size" and "next" members
6116 changed to be "header.size" and "header.next".
6117 * buffer.h (struct buffer): Likewise.
6118 * font.h (struct font_spec, struct font_entity, struct font): Likewise.
6119 * frame.h (struct frame): Likewise.
6120 * process.h (struct Lisp_Process): Likewise.
6121 * termhooks.h (struct terminal): Likewise.
6122 * window.c (struct save_window_data, struct saved_window): Likewise.
6123 * window.h (struct window): Likewise.
6124 * alloc.c (allocate_buffer, Fmake_bool_vector, allocate_pseudovector):
6125 Use XSETPVECTYPESIZE, not XSETPVECTYPE, to avoid aliasing problems.
6126 * buffer.c (init_buffer_once): Likewise.
6127 * lread.c (defsubr): Use XSETTYPED_PVECTYPE, since Lisp_Subr is a
6128 special case.
6129 * process.c (Fformat_network_address): Use local var for size,
6130 for brevity.
6131
6132 * bytecode.c (exec_byte_code): Don't use XVECTOR before CHECK_VECTOR.
6133
6134 Make the Lisp reader and string-to-float more consistent (Bug#8525)
6135 * data.c (atof): Remove decl; no longer used or needed.
6136 (digit_to_number): Move to lread.c.
6137 (Fstring_to_number): Use new string_to_number function, to be
6138 consistent with how the Lisp reader treats infinities and NaNs.
6139 Do not assume that floating-point numbers represent EMACS_INT
6140 without losing information; this is not true on most 64-bit hosts.
6141 Avoid double-rounding errors, by insisting on integers when
6142 parsing non-base-10 numbers, as the documentation specifies.
6143 * lisp.h (string_to_number): New decl, replacing ...
6144 (isfloat_string): Remove.
6145 * lread.c: Include <inttypes.h>, for uintmax_t and strtoumax.
6146 (read1): Do not accept +. and -. as integers; this
6147 appears to have been a coding error. Similarly, do not accept
6148 strings like +-1e0 as floating point numbers. Do not report
6149 overflow for integer overflows unless the base is not 10 which
6150 means we have no simple and reliable way to continue.
6151 Break out the floating-point parsing into a new
6152 function string_to_number, so that Fstring_to_number parses
6153 floating point numbers consistently with the Lisp reader.
6154 (digit_to_number): Move here from data.c. Make it static inline.
6155 (E_CHAR, EXP_INT): Remove, replacing with ...
6156 (E_EXP): New macro, to solve the "1.0e+" problem mentioned below.
6157 (string_to_number): New function, replacing isfloat_string.
6158 This function checks for valid syntax and produces the resulting
6159 Lisp float number too. Rework it so that string-to-number
6160 no longer mishandles examples like "1.0e+". Use strtoumax,
6161 so that overflow for non-base-10 numbers is reported only when
6162 there's no portable and simple way to convert to floating point.
6163
6164 * textprop.c (set_text_properties_1): Rewrite for clarity,
6165 and to avoid GCC warning about integer overflow.
6166
6167 * intervals.h (struct interval): Use EMACS_INT for members
6168 where EMACS_UINT might cause problems. See
6169 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html>.
6170 (CHECK_TOTAL_LENGTH): Remove cast to EMACS_INT; no longer needed.
6171 * intervals.c (interval_deletion_adjustment): Now returns EMACS_INT.
6172 All uses changed.
6173 (offset_intervals): Tell GCC not to worry about length overflow
6174 when negating a negative length.
6175
6176 * alloc.c (overrun_check_malloc, overrun_check_realloc): Now static.
6177 (overrun_check_free): Likewise.
6178
6179 * alloc.c (SDATA_SIZE) [!GC_CHECK_STRING_BYTES]: Avoid runtime check
6180 in the common case where SDATA_DATA_OFFSET is a multiple of Emacs
6181 word size.
6182
6183 * gnutls.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
6184 (gnutls_make_error): Rename local to avoid shadowing.
6185 (gnutls_emacs_global_deinit): ifdef out; not used.
6186 (Fgnutls_boot): Use const for pointer to readonly storage.
6187 Comment out unused local. Fix pointer signedness problems.
6188
6189 * lread.c (openp): Don't stuff size_t into an 'int'.
6190 Use <= on length, not < on length + 1, to avoid GCC 4.6.0 warning
6191 about possible signed overflow.
6192
6193 * gtkutil.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
6194 (GDK_KEY_g): Don't define if already defined.
6195 (xg_prepare_tooltip): Avoid pointer signedness problem.
6196 (xg_set_toolkit_scroll_bar_thumb): Redo to avoid two casts.
6197
6198 * process.c (Fnetwork_interface_info): Avoid left-shift undefined
6199 behavior with 1 << 31. GCC 4.6.0 warns about this on 32-bit hosts.
6200
6201 * xfns.c (Fx_window_property): Simplify a bit,
6202 to make a bit faster and to avoid GCC 4.6.0 warning.
6203 * xselect.c (x_get_window_property, x_handle_dnd_message): Likewise.
6204
6205 * fns.c (internal_equal): Don't assume size_t fits in int.
6206
6207 * alloc.c (compact_small_strings): Tighten assertion a little.
6208
6209 Replace pEd with more-general pI, and fix some printf arg casts.
6210 * lisp.h (pI): New macro, generalizing old pEd macro to other
6211 conversion specifiers. For example, use "...%"pI"d..." rather
6212 than "...%"pEd"...".
6213 (pEd): Remove. All uses replaced with similar uses of pI.
6214 * src/m/amdx86-64.h, src/m/ia64.h, src/m/ibms390x.h: Likewise.
6215 * alloc.c (check_pure_size): Don't overflow by converting size to int.
6216 * bidi.c (bidi_dump_cached_states): Use pI to avoid cast.
6217 * data.c (Fnumber_to_string): Use pI instead of if-then-else-abort.
6218 * dbusbind.c (xd_append_arg): Use pI to avoid cast.
6219 (Fdbus_method_return_internal, Fdbus_method_error_internal): Likewise.
6220 * font.c (font_unparse_xlfd): Avoid potential buffer overrun on
6221 64-bit hosts.
6222 (font_unparse_xlfd, font_unparse_fcname): Use pI to avoid casts.
6223 * keyboard.c (record_char, modify_event_symbol): Use pI to avoid casts.
6224 * print.c (safe_debug_print, print_object): Likewise.
6225 (print_object): Don't overflow by converting EMACS_INT or EMACS_UINT
6226 to int.
6227 Use pI instead of if-then-else-abort. Use %p to avoid casts,
6228 avoiding the 0 flag, which is not portable.
6229 * process.c (Fmake_network_process): Use pI to avoid cast.
6230 * region-cache.c (pp_cache): Likewise.
6231 * xdisp.c (decode_mode_spec): Likewise.
6232 * xrdb.c (x_load_resources) [USE_MOTIF]: Use pI to avoid undefined
6233 behavior on 64-bit hosts with printf arg.
6234 * xselect.c (x_queue_event): Use %p to avoid casts, avoiding 0 flag.
6235 (x_stop_queuing_selection_requests): Likewise.
6236 (x_get_window_property): Don't truncate byte count to an 'int'
6237 when tracing.
6238
6239 * frame.c (frame_name_fnn_p): Get rid of strtol, which isn't right
6240 here, since it parses constructs like leading '-' and spaces,
6241 which are not wanted; and it overflows with large numbers.
6242 Instead, simply match F[0-9]+, which is what is wanted anyway.
6243
6244 * alloc.c: Remove unportable assumptions about struct layout.
6245 (SDATA_SELECTOR, SDATA_DATA_OFFSET): New macros.
6246 (SDATA_OF_STRING, SDATA_SIZE, allocate_string_data):
6247 (allocate_vectorlike, make_pure_vector): Use the new macros,
6248 plus offsetof, to remove unportable assumptions about struct layout.
6249 These assumptions hold on all porting targets that I know of, but
6250 they are not guaranteed, they're easy to remove, and removing them
6251 makes further changes easier.
6252
6253 * alloc.c (BLOCK BYTES): Fix typo by changing "ablock" to "ablocks".
6254 This doesn't fix a bug but makes the code clearer.
6255 (string_overrun_cookie): Now const. Use initializers that
6256 don't formally overflow signed char, to avoid warnings.
6257 (allocate_string_data) [GC_CHECK_STRING_OVERRUN]: Fix typo that
6258 can cause Emacs to crash when string overrun checking is enabled.
6259 (allocate_buffer): Don't assume sizeof (struct buffer) is a
6260 multiple of sizeof (EMACS_INT); it need not be, if
6261 alignof(EMACS_INT) < sizeof (EMACS_INT).
6262 (check_sblock, check_string_bytes, check_string_free_list): Protoize.
6263
6264 2011-04-26 Juanma Barranquero <lekktu@gmail.com>
6265
6266 * keyboard.c (QCrtl): Rename from Qrtl. All uses changed.
6267
6268 2011-04-26 Teodor Zlatanov <tzz@lifelogs.com>
6269
6270 * gnutls.c (emacs_gnutls_handshake): Return an error if we're not
6271 supposed to be handshaking. (Bug#8556)
6272 Reported by Paul Eggert <eggert@cs.ucla.edu>.
6273
6274 2011-04-26 Daniel Colascione <dan.colascione@gmail.com>
6275
6276 * lisp.h (Qdebug): List symbol.
6277 * eval.c (Qdebug): Restore global linkage.
6278 * keyboard.c (debug-on-event): New variable.
6279 (handle_user_signal): Break into debugger when debug-on-event
6280 matches the current signal symbol.
6281
6282 2011-04-25 Dan Nicolaescu <dann@ics.uci.edu>
6283
6284 * alloc.c (check_sblock, check_string_bytes)
6285 (check_string_free_list): Convert to standard C.
6286
6287 2011-04-25 Teodor Zlatanov <tzz@lifelogs.com>
6288
6289 * w32.c (emacs_gnutls_push): Fix typo.
6290
6291 2011-04-25 Eli Zaretskii <eliz@gnu.org>
6292
6293 * gnutls.c (emacs_gnutls_handshake): Avoid compiler warnings about
6294 "cast to pointer from integer of different size".
6295
6296 Improve doprnt and its use in verror. (Bug#8545)
6297 * doprnt.c (doprnt): Document the set of format control sequences
6298 supported by the function. Use SAFE_ALLOCA instead of always
6299 using `alloca'.
6300
6301 * eval.c (verror): Don't limit the buffer size at size_max-1, that
6302 is one byte too soon. Don't use xrealloc; instead xfree and
6303 xmalloc anew.
6304
6305 2011-04-24 Teodor Zlatanov <tzz@lifelogs.com>
6306
6307 * gnutls.h: Add GNUTLS_STAGE_CALLBACKS enum to denote we're in the
6308 callbacks stage.
6309
6310 * gnutls.c: Renamed global_initialized to
6311 gnutls_global_initialized. Added internals for the
6312 :verify-hostname-error, :verify-error, and :verify-flags
6313 parameters of `gnutls-boot' and documented those parameters in the
6314 docstring. Start callback support.
6315 (emacs_gnutls_handshake): Add Woe32 support. Retry handshake
6316 unless a fatal error occurred. Call gnutls_alert_send_appropriate
6317 on error. Return error code.
6318 (emacs_gnutls_write): Call emacs_gnutls_handle_error.
6319 (emacs_gnutls_read): Likewise.
6320 (Fgnutls_boot): Return handshake error code.
6321 (emacs_gnutls_handle_error): New function.
6322 (wsaerror_to_errno): Likewise.
6323
6324 * w32.h (emacs_gnutls_pull): Add prototype.
6325 (emacs_gnutls_push): Likewise.
6326
6327 * w32.c (emacs_gnutls_pull): New function for GnuTLS on Woe32.
6328 (emacs_gnutls_push): Likewise.
6329
6330 2011-04-24 Claudio Bley <claudio.bley@gmail.com> (tiny change)
6331
6332 * process.c (wait_reading_process_output): Check if GnuTLS
6333 buffered some data internally if no FDs are set for TLS
6334 connections.
6335
6336 * makefile.w32-in (OBJ2): Add gnutls.$(O).
6337 (LIBS): Link to USER_LIBS.
6338 ($(BLD)/gnutls.$(0)): New target.
6339
6340 2011-04-24 Eli Zaretskii <eliz@gnu.org>
6341
6342 * xdisp.c (handle_single_display_spec): Rename the
6343 display_replaced_before_p argument into display_replaced_p, to
6344 make it consistent with the commentary. Fix typos in the
6345 commentary.
6346
6347 * textprop.c (syms_of_textprop): Remove dead code.
6348 (copy_text_properties): Delete obsolete commentary about an
6349 interface that was deleted long ago. Fix typos in the description
6350 of arguments.
6351
6352 * msdos.c (XMenuActivate, XMenuAddSelection): Adjust argument list
6353 to changes in oldXMenu/XMenu.h from 2011-04-16.
6354 <menu_help_message, prev_menu_help_message>: Constify.
6355 (IT_menu_make_room): menu->help_text is now `const char **';
6356 adjust.
6357
6358 * msdos.h (XMenuActivate, XMenuAddSelection): Adjust prototypes
6359 to changes in oldXMenu/XMenu.h from 2011-04-16.
6360 (struct XMenu): Declare `help_text' `const char **'.
6361
6362 * xfaces.c <Qunspecified>: Make extern again.
6363
6364 * syntax.c: Include sys/types.h before including regex.h, as
6365 required by Posix.
6366
6367 * doc.c (get_doc_string): Improve the format passed to `error'.
6368
6369 * doprnt.c (doprnt): Improve commentary.
6370
6371 * term.c (init_tty) [MSDOS]: Fix 1st argument to maybe_fatal.
6372
6373 * Makefile.in (TAGS): Depend on $(M_FILE) and $(S_FILE), and scan
6374 them with etags.
6375
6376 * makefile.w32-in (globals.h): Add a dummy recipe, to make any
6377 changes in globals.h immediately force recompilation.
6378 (TAGS): Depend on $(CURDIR)/m/intel386.h and
6379 $(CURDIR)/s/ms-w32.h.
6380 (TAGS-gmake): Scan $(CURDIR)/m/intel386.h and $(CURDIR)/s/ms-w32.h.
6381
6382 * character.c (Fchar_direction): Function deleted.
6383 (syms_of_character): Don't defsubr it.
6384 <char-direction-table>: Deleted.
6385
6386 2011-04-23 Eli Zaretskii <eliz@gnu.org>
6387
6388 Fix doprnt so it could be used again safely in `verror'. (Bug#8435)
6389 * doprnt.c: Include limits.h.
6390 (SIZE_MAX): New macro.
6391 (doprnt): Return a size_t value. 2nd arg is now size_t.
6392 Many local variables are now size_t instead of int or unsigned.
6393 Improve overflow protection. Support `l' modifier for integer
6394 conversions. Support %l conversion. Don't assume an EMACS_INT
6395 argument for integer conversions and for %c.
6396
6397 * lisp.h (doprnt): Restore prototype.
6398
6399 * makefile.w32-in ($(BLD)/callint.$(O)): Depend on
6400 $(SRC)/character.h.
6401
6402 * Makefile.in (base_obj): Add back doprnt.o.
6403
6404 * deps.mk (doprnt.o): Add back prerequisites.
6405 (callint.o): Depend on character.h.
6406
6407 * eval.c (internal_lisp_condition_case): Include the handler
6408 representation in the error message.
6409 (verror): Call doprnt instead of vsnprintf. Fix an off-by-one bug
6410 when breaking from the loop.
6411
6412 * xdisp.c (vmessage): Call doprnt instead of vsnprintf.
6413
6414 * callint.c (Fcall_interactively): When displaying error message
6415 about invalid control letter, pass the character's codepoint, not
6416 a pointer to its multibyte form. Improve display of the character
6417 in octal and display also its hex code.
6418
6419 * character.c (char_string): Use %x to display the (unsigned)
6420 codepoint of an invalid character, to avoid displaying a bogus
6421 negative value.
6422
6423 * font.c (check_otf_features): Pass SDATA of SYMBOL_NAME to
6424 `error', not SYMBOL_NAME itself.
6425
6426 * coding.c (Fencode_sjis_char, Fencode_big5_char): Use %c for
6427 character arguments to `error'.
6428
6429 * charset.c (check_iso_charset_parameter): Fix incorrect argument
6430 to `error' in error message about FINAL_CHAR argument. Make sure
6431 FINAL_CHAR is a character, and use %c when it is passed as
6432 argument to `error'.
6433
6434 2011-04-23 Eli Zaretskii <eliz@gnu.org>
6435
6436 * s/ms-w32.h (localtime): Redirect to sys_localtime.
6437
6438 * w32.c: Include <time.h>.
6439 (sys_localtime): New function.
6440
6441 2011-04-23 Chong Yidong <cyd@stupidchicken.com>
6442
6443 * xdisp.c (init_xdisp): Initialize echo_area_window (Bug#6451).
6444
6445 * buffer.c (syms_of_buffer): Doc fix (Bug#6902).
6446
6447 2011-04-23 Samuel Thibault <sthibault@debian.org> (tiny change)
6448
6449 * sysdep.c (wait_for_termination): On GNU Hurd, kill returns -1 on
6450 zombies (Bug#8467).
6451
6452 2011-04-19 Eli Zaretskii <eliz@gnu.org>
6453
6454 * syntax.h (SETUP_SYNTAX_TABLE_FOR_OBJECT): Fix setting of
6455 gl_state.e_property when gl_state.object is Qt.
6456
6457 * insdel.c (make_gap_larger): Remove limitation of buffer size
6458 to <= INT_MAX.
6459
6460 2011-04-18 Chong Yidong <cyd@stupidchicken.com>
6461
6462 * xdisp.c (lookup_glyphless_char_display)
6463 (produce_glyphless_glyph): Handle cons cell entry in
6464 glyphless-char-display.
6465 (Vglyphless_char_display): Document it.
6466
6467 * term.c (produce_glyphless_glyph): Handle cons cell entry in
6468 glyphless-char-display.
6469
6470 2011-04-17 Chong Yidong <cyd@stupidchicken.com>
6471
6472 * xdisp.c (get_next_display_element): Remove unnecessary ifdefs.
6473
6474 * termhooks.h (FRAME_WINDOW_P): Remove duplicated definitions.
6475
6476 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): Add missing
6477 definition for no-X builds.
6478
6479 2011-04-16 Paul Eggert <eggert@cs.ucla.edu>
6480
6481 Static checks with GCC 4.6.0 and non-default toolkits.
6482
6483 * s/sol2-6.h, s/unixware.h (PTY_TTY_NAME_SPRINTF): Protoize decl.
6484
6485 * process.c (keyboard_bit_set): Define only if SIGIO.
6486 (send_process_trap): Mark it with NO_RETURN if it doesn't return.
6487 (send_process): Repair possible setjmp clobbering.
6488
6489 * s/usg5-4-common.h (SETUP_SLAVE_PTY): Don't pass extra arg to 'fatal'.
6490
6491 * eval.c: Include <stdio.h>, for vsnprintf on non-GNU/Linux hosts.
6492
6493 * data.c (arith_error): Mark with NO_RETURN if it doesn't return.
6494
6495 * alloc.c (bytes_used_when_full, SPARE_MEMORY, BYTES_USED):
6496 Define only if needed.
6497
6498 * sysdep.c (_FILE_OFFSET_BITS): Make this hack even uglier
6499 by pacifying GCC about it. Maybe it's time to retire it?
6500 * xfaces.c (USG, __TIMEVAL__): Likewise.
6501
6502 * dispextern.h (struct redisplay_interface): Rename param
6503 to avoid shadowing.
6504 * termhooks.h (struct terminal): Likewise.
6505 * xterm.c (xembed_send_message): Likewise.
6506
6507 * insdel.c (make_gap_smaller): Define only if
6508 USE_MMAP_FOR_BUFFERS || REL_ALLOC || DOUG_LEA_MALLOC.
6509
6510 * keyboard.c (read_char): Make a var volatile so longjmp won't clobber
6511 it.
6512
6513 * emacs.c (MAX_HEAP_BSS_DIFF, my_edata): Move to where they're used,
6514 so that we aren't warned about unused symbols.
6515
6516 * xfns.c (Fx_file_dialog): Rename local to avoid shadowing.
6517
6518 * xdisp.c (x_produce_glyphs): Mark var as initialized (Bug#8512).
6519
6520 * xfns.c (x_real_positions): Mark locals as initialized.
6521
6522 * xmenu.c (xmenu_show): Don't use uninitialized vars.
6523
6524 * xterm.c: Fix problems found by static analysis with other toolkits.
6525 (toolkit_scroll_bar_interaction): Define and use only if USE_X_TOOLKIT.
6526 (x_dispatch_event): Declare static if USE_GTK, and
6527 define if USE_GTK || USE_X_TOOLKIT.
6528 (SET_SAVED_BUTTON_EVENT): Define only if USE_X_TOOLKIT || USE_GTK.
6529 * xterm.h (x_dispatch_event): Extern only if USE_X_TOOLKIT.
6530 * xterm.c, xterm.h (x_mouse_leave): Bring this function back, but only
6531 if defined HAVE_MENUS && !defined USE_X_TOOLKIT && !defined USE_GTK.
6532
6533 * xmenu.c (menu_help_callback): Pointer type fixes.
6534 Use const pointers when pointing at readonly data. Avoid pointer
6535 signedness clashes.
6536 (FALSE): Remove unused macro.
6537 (update_frame_menubar): Remove unused decl.
6538
6539 * xfns.c (Fx_hide_tip): Move locals to avoid shadowing.
6540
6541 * menu.c (push_submenu_start, push_submenu_end): Do not define unless
6542 USE_X_TOOLKIT || USE_GTK || HAVE_NS || defined HAVE_NTGUI.
6543 (single_menu_item): Rename local to avoid shadowing.
6544
6545 * keyboard.c (make_lispy_event): Remove unused local var.
6546
6547 * frame.c, frame.h (x_get_resource_string): Bring this back, but
6548 only if HAVE_X_WINDOWS && !USE_X_TOOLKIT.
6549
6550 * bitmaps: Change bitmaps from unsigned char back to the X11
6551 compatible char. Avoid the old compiler warnings about
6552 out-of-range initializers by using, for example, '\xab' rather
6553 than 0xab.
6554
6555 * xgselect.c (xgselect_initialize): Check vs interface
6556 even if ! (defined (USE_GTK) || defined (HAVE_GCONF)).
6557
6558 * xmenu.c (xmenu_show): Rename parm to avoid shadowing.
6559
6560 * xterm.c (x_create_toolkit_scroll_bar): Use const * for pointers
6561 to read-only memory.
6562
6563 * fns.c (vector): Remove; this old hack is no longer needed.
6564
6565 * xsmfns.c (create_client_leader_window): Rename shadowing arg.
6566 Remove unused var.
6567 (gdk_x11_set_sm_client_id) [!USE_GTK]: Don't define.
6568
6569 * xrdb.c (x_load_resources): Omit unused local.
6570
6571 * xfns.c (free_frame_menubar, atof): Remove duplicate decls.
6572 (x_window): Rename locals to avoid shadowing.
6573 (USG): Use the kludged USG macro, to pacify gcc.
6574
6575 * xterm.c (x_alloc_nearest_color_for_widget): Remove; unused.
6576 (x_term_init): Remove local to avoid shadowing.
6577
6578 * xfns.c, xterm.c (_XEditResCheckMessages): Protoize decl.
6579
6580 * xdisp.c, dispextern.h (set_vertical_scroll_bar): Now extern if
6581 USE_TOOLKIT_SCROLL_BARS && !USE_GTK, as xterm.c needs it then.
6582
6583 2011-04-16 Eli Zaretskii <eliz@gnu.org>
6584
6585 * gnutls.c (Fgnutls_boot): Don't pass Lisp_Object to `error'.
6586
6587 Fix regex.c, syntax.c and friends for buffers > 2GB.
6588 * syntax.h (struct gl_state_s): Declare character position members
6589 EMACS_INT.
6590
6591 * syntax.c (update_syntax_table): Declare 2nd argument EMACS_INT.
6592
6593 * textprop.c (verify_interval_modification, interval_of):
6594 Declare arguments EMACS_INT.
6595
6596 * intervals.c (adjust_intervals_for_insertion): Declare arguments
6597 EMACS_INT.
6598
6599 * intervals.h (CHECK_TOTAL_LENGTH): Cast to EMACS_INT, not `int'.
6600
6601 * indent.c (Fvertical_motion): Local variable it_start is now
6602 EMACS_INT.
6603
6604 * regex.c (re_match, re_match_2, re_match_2_internal)
6605 (bcmp_translate, regcomp, regexec, print_double_string)
6606 (group_in_compile_stack, re_search, re_search_2, regex_compile)
6607 (re_compile_pattern, re_exec): Declare arguments and local
6608 variables `size_t' and `ssize_t' and return values `regoff_t', as
6609 appropriate.
6610 (POP_FAILURE_REG_OR_COUNT) <pfreg>: Declare `long'.
6611 (CHECK_INFINITE_LOOP) <failure>: Declare `ssize_t'.
6612 <compile_stack_type>: `size' and `avail' are now `size_t'.
6613
6614 * regex.h <regoff_t>: Use ssize_t, not int.
6615 (re_search, re_search_2, re_match, re_match_2): Arguments that
6616 specify buffer/string position and length are now ssize_t and
6617 size_t. Return type is regoff_t.
6618
6619 2011-04-16 Ben Key <bkey76@gmail.com>
6620
6621 * nsfont.m: Fixed bugs in ns_get_family and
6622 ns_descriptor_to_entity that were caused by using free to
6623 deallocate memory blocks that were allocated by xmalloc (via
6624 xstrdup). This caused Emacs to crash when compiled with
6625 XMALLOC_OVERRUN_CHECK defined (when Emacs was configured with
6626 --enable-checking=xmallocoverrun). xfree is now used to
6627 deallocate these memory blocks.
6628
6629 2011-04-15 Paul Eggert <eggert@cs.ucla.edu>
6630
6631 * sysdep.c (emacs_read): Remove unnecessary check vs MAX_RW_COUNT.
6632
6633 emacs_write: Accept and return EMACS_INT for sizes.
6634 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html
6635 et seq.
6636 * gnutls.c, gnutls.h (emacs_gnutls_read, emacs_gnutls_write):
6637 Accept and return EMACS_INT.
6638 (emacs_gnutls_write): Return the number of bytes written on
6639 partial writes.
6640 * sysdep.c, lisp.h (emacs_read, emacs_write): Likewise.
6641 (emacs_read, emacs_write): Remove check for negative size, as the
6642 Emacs source code has been audited now.
6643 * sysdep.c (MAX_RW_COUNT): New macro, to work around kernel bugs.
6644 (emacs_read, emacs_write): Use it.
6645 * process.c (send_process): Adjust to the new signatures of
6646 emacs_write and emacs_gnutls_write. Do not attempt to store
6647 a byte offset into an 'int'; it might overflow.
6648 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00483.html
6649
6650 * sound.c: Don't assume sizes fit in 'int'.
6651 (struct sound_device.period_size, alsa_period_size):
6652 Return EMACS_INT, not int.
6653 (struct sound_device.write, vox_write, alsa_write):
6654 Accept EMACS_INT, not int.
6655 (wav_play, au_play): Use EMACS_INT to store sizes and to
6656 record read return values.
6657
6658 2011-04-15 Ben Key <bkey76@gmail.com>
6659
6660 * keyboard.c (Qundefined): Don't declare static since it is used
6661 in nsfns.m.
6662 * xfaces.c (Qbold, Qexpanded, Qitalic, Qcondensed): Don't declare
6663 static since they are used in nsfont.m.
6664
6665 2011-04-15 Stefan Monnier <monnier@iro.umontreal.ca>
6666
6667 * process.c (Qprocessp): Don't declare static.
6668 * lisp.h (Qprocessp): Declare again.
6669
6670 2011-04-15 Juanma Barranquero <lekktu@gmail.com>
6671
6672 * font.c (Qopentype): Don't make static (used from w32uniscribe.c).
6673
6674 2011-04-14 Paul Eggert <eggert@cs.ucla.edu>
6675
6676 Improve C-level modularity by making more things 'static'.
6677
6678 Don't publish debugger-only interfaces to other modules.
6679 * lisp.h (safe_debug_print, debug_output_compilation_hack):
6680 (verify_bytepos, count_markers): Move decls to the only modules
6681 that need them.
6682 * region-cache.h (pp_cache): Likewise.
6683 * window.h (check_all_windows): Likewise.
6684 * marker.c, print.c, region-cache.c, window.c: Decls moved here.
6685
6686 * sysdep.c (croak): Now static, if
6687 defined TIOCNOTTY || defined USG5 || defined CYGWIN.
6688 * syssignal.h (croak): Declare only if not static.
6689
6690 * alloc.c (refill_memory_reserve): Now static if
6691 !defined REL_ALLOC || defined SYSTEM_MALLOC.
6692 * lisp.h (refill_memory_reserve): Declare only if not static.
6693
6694 * xsettings.c, xsettings.h (xsettings_get_system_normal_font):
6695 Define only if USE_LUCID.
6696
6697 * xrdb.c (x_customization_string, x_rm_string): Now static.
6698
6699 * xmenu.c (x_menu_wait_for_event): Export only if USE_MOTIF.
6700 * xterm.h (x_menu_wait_for_event): Declare only if USE_MOTIF.
6701
6702 * xdisp.c (draw_row_with_mouse_face): Now static.
6703 * dispextern.h (draw_row_with_mouse_fave): Remove decl.
6704
6705 * window.h (check_all_windows): Mark externally visible.
6706
6707 * window.c (window_deletion_count): Now static.
6708
6709 * undo.c: Make symbols static if they're not exported.
6710 (last_undo_buffer, last_boundary_position, pending_boundary):
6711 Now static.
6712
6713 * textprop.c (interval_insert_behind_hooks): Now static.
6714 (interval_insert_in_front_hooks): Likewise.
6715
6716 * term.c: Make symbols static if they're not exported.
6717 (tty_turn_off_highlight, get_tty_terminal, max_frame_cols):
6718 (max_frame_lines, tty_set_terminal_modes):
6719 (tty_reset_terminal_modes, tty_turn_off_highlight):
6720 (get_tty_terminal): Now static.
6721 (term_mouse_moveto): Do not define if HAVE_WINDOW_SYSTEM.
6722 * termhooks.h (term_mouse_moveto): Do not declare if
6723 HAVE_WINDOW_SYSTEM.
6724 * dispextern.h (tty_set_terminal_modes, tty_reset_terminal_modes):
6725 (tty_turn_off_highlight, get_tty_terminal): Remove decls.
6726
6727 * sysdep.c: Make symbols static if they're not exported.
6728 (emacs_get_tty, emacs_set_tty, old_fcntl_flags, old_fcntl_owner):
6729 Now static.
6730 (sigprocmask_set, full_mask): Remove; unused.
6731 (wait_debugging): Mark as visible.
6732 * syssignal.h (SIGFULLMASK, full_mask): Remove decls.
6733 * systty.h (emacs_get_tty, emacs_set_tty): Remove decls.
6734
6735 * syntax.c (syntax_temp): Define only if !__GNUC__.
6736
6737 * sound.c (current_sound_device, current_sound): Now static.
6738
6739 * search.c (searchbufs, searchbuf_head): Now static.
6740
6741 * scroll.c (scroll_cost): Remove; unused.
6742 * dispextern.h (scroll_cost): Remove decl.
6743
6744 * region-cache.h (pp_cache): Mark as externally visible.
6745
6746 * process.c: Make symbols static if they're not exported.
6747 (process_tick, update_tick, create_process, chan_process):
6748 (Vprocess_alist, proc_buffered_char, datagram_access):
6749 (fd_callback_data, send_process_frame, process_sent_to): Now static.
6750 (deactivate_process): Mark defn as static, as well as decl.
6751 * lisp.h (create_process): Remove decl.
6752 * process.h (chan_process, Vprocess_alist): Remove decls.
6753
6754 * print.c: Make symbols static if they're not exported.
6755 (print_depth, new_backquote_output, being_printed, print_buffer):
6756 (print_buffer_size, print_buffer_pos, print_buffer_pos_byte):
6757 (print_interval, print_number_index, initial_stderr_stream):
6758 Now static.
6759 * lisp.h (Fprinc): Remove decl.
6760 (debug_output_compilation_hack): Mark as externally visible.
6761
6762 * sysdep.c (croak): Move decl from here to syssignal.h.
6763 * syssignal.h (croak): Put it here, so the API can be checked when
6764 'croak' is called from dissociate_if_controlling_tty.
6765
6766 * minibuf.c: Make symbols static if they're not exported.
6767 (minibuf_save_list, choose_minibuf_frame): Now static.
6768 * lisp.h (choose_minibuf_frame): Remove decl.
6769
6770 * lisp.h (verify_bytepos, count_markers): Mark as externally visible.
6771
6772 * lread.c: Make symbols static if they're not exported.
6773 (read_objects, initial_obarray, oblookup_last_bucket_number):
6774 Now static.
6775 (make_symbol): Remove; unused.
6776 * lisp.h (initial_obarray, make_symbol): Remove decls.
6777
6778 * keyboard.c: Make symbols static if they're not exported.
6779 (single_kboard, recent_keys_index, total_keys, recent_keys):
6780 (this_command_key_count_reset, raw_keybuf, raw_keybuf_count):
6781 (this_single_command_key_start, echoing, last_auto_save):
6782 (read_key_sequence_cmd, dribble, recursive_edit_unwind):
6783 (command_loop, echo_now, keyboard_init_hook, help_char_p):
6784 (quit_throw_to_read_char, command_loop_2, top_level_1, poll_timer):
6785 (Vlispy_mouse_stem, double_click_count):
6786 Now static.
6787 (force_auto_save_soon): Define only if SIGDANGER.
6788 (ignore_mouse_drag_p): Now static if
6789 !defined HAVE_WINDOW_SYSTEM || defined USE_GTK || defined HAVE_NS.
6790 (print_help): Remove; unused.
6791 (stop_character, last_timer_event): Mark as externally visible.
6792 * keyboard.h (ignore_mouse_drag_p): Declare only if
6793 defined HAVE_WINDOW_SYSTEM && !defined USE_GTK && !defined HAVE_NS.
6794 (echo_now, help_char_p, quit_throw_to_read_char): Remove decls.
6795 * lisp.h (echoing): Remove decl.
6796 (force_auto_save_soon): Declare only if SIGDANGER.
6797 * xdisp.c (redisplay_window): Simplify code, to make it more
6798 obvious that ignore_mouse_drag_p is not accessed if !defined
6799 USE_GTK && !defined HAVE_NS.
6800
6801 * intervals.c: Make symbols static if they're not exported.
6802 (merge_properties_sticky, merge_interval_right, delete_interval):
6803 Now static.
6804 * intervals.h (merge_interval_right, delete_interval): Remove decls.
6805
6806 * insdel.c: Make symbols static if they're not exported.
6807 However, leave prepare_to_modify_buffer alone. It's never
6808 called from outside this function, but that appears to be a bug.
6809 (combine_after_change_list, combine_after_change_buffer):
6810 (adjust_after_replace, signal_before_change): Now static.
6811 (adjust_after_replace_noundo): Remove; unused.
6812 * lisp.h (adjust_after_replace, adjust_after_replace_noundo):
6813 (signal_before_change): Remove decls.
6814
6815 * indent.c (val_compute_motion, val_vmotion): Now static.
6816
6817 * image.c: Make symbols static if they're not exported.
6818 * dispextern.h (x_create_bitmap_from_xpm_data): Do not declare
6819 if USE_GTK.
6820 * image.c (x_create_bitmap_from_xpm_data): Do not define if USE_GTK.
6821 (xpm_color_cache, ct_table, ct_colors_allocated): Now static.
6822
6823 * fringe.c (standard_bitmaps): Now static.
6824 (max_used_fringe_bitmap): Now static, unless HAVE_NS.
6825
6826 * frame.c: Make symbols static if they're not exported.
6827 (x_report_frame_params, make_terminal_frame): Now static.
6828 (get_frame_param): Now static, unless HAVE_NS.
6829 (x_fullscreen_adjust): Define if WINDOWSNT, not if HAVE_WINDOW_SYSTEM.
6830 (x_get_resource_string): Remove; not used.
6831 * frame.h (make_terminal_frame, x_report_frame_params):
6832 (x_get_resource_string); Remove decls.
6833 (x_fullscreen_adjust): Declare only if WINDOWSNT.
6834 * lisp.h (get_frame_param): Declare only if HAVE_NS.
6835
6836 * font.c, fontset.c: Make symbols static if they're not exported.
6837 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): New macro.
6838 (FACE_SUITABLE_FOR_CHAR_P): Use it.
6839 * font.c (font_close_object): Now static.
6840 * font.h (font_close_object): Remove.
6841 * fontset.c (FONTSET_OBJLIST): Remove.
6842 (free_realized_fontset) #if-0 the body, which does nothing.
6843 (face_suitable_for_char_p): #if-0, as it's never called.
6844 * fontset.h (face_suitable_for_char_p): Remove decl.
6845 * xfaces.c (face_at_string_position):
6846 Use FACE_SUITABLE_FOR_ASCII_CHAR_P, not FACE_SUITABLE_FOR_CHAR_P,
6847 since 0 is always ASCII.
6848
6849 * fns.c (weak_hash_tables): Now static.
6850
6851 * fileio.c: Make symbols static if they're not exported.
6852 (auto_saving, auto_save_mode_bits, auto_save_error_occurred):
6853 (Vwrite_region_annotation_buffers): Now static.
6854
6855 * eval.c: Make symbols static if they're not exported.
6856 (backtrace_list, lisp_eval_depth, when_entered_debugger): Now static.
6857 * lisp.h (backtrace_list): Remove decl.
6858
6859 * emacs.c: Make symbols static if they're not exported.
6860 (malloc_state_ptr, malloc_using_checking, syms_of_emacs):
6861 (fatal_error_code, fatal_error_signal_hook, standard_args):
6862 Now static.
6863 (fatal_error_signal): Now static, unless FLOAT_CATCH_SIGKILL.
6864 (DEFINE_DUMMY_FUNCTION): Mark function as externally visible.
6865 (__CTOR_LIST__, __DTOR_LIST__): Now externally visible.
6866 * lisp.h (fatal_error_signal_hook): Remove decl.
6867 (fatal_error_signal): Declare only if FLOAT_CATCH_SIGKILL.
6868
6869 * editfns.c: Move a (normally-unused) function to its only use.
6870 * editfns.c, lisp.h (get_operating_system_release): Remove.
6871 * process.c (init_process) [DARWIN_OS]: Do it inline, as it is not
6872 worth the hassle of breaking this out.
6873
6874 * xterm.c: Make symbols static if they're not exported.
6875 (x_raise_frame, x_lower_frame, x_wm_set_window_state):
6876 (x_wm_set_icon_pixmap, x_initialize, XTread_socket_fake_io_error):
6877 (x_destroy_window, x_delete_display):
6878 Now static.
6879 (x_dispatch_event): Now static if ! (USE_MOTIF || USE_X_TOOLKIT).
6880 (x_mouse_leave): Remove; unused.
6881 * xterm.h (x_display_info_for_name, x_raise_frame, x_lower_frame):
6882 (x_destroy_window, x_wm_set_window_state, x_wm_set_icon_pixmap):
6883 (x_delete_display, x_initialize, x_set_border_pixel, x_screen_planes):
6884 Remove decls.
6885 (x_mouse_leave): Declare only if WINDOWSNT.
6886 (x_dispatch_event): Declare only if USE_MOTIF or USE_X_TOOLKIT.
6887 (xic_create_fontsetname): Declare only if HAVE_X_WINDOWS &&
6888 USE_X_TOOLKIT.
6889
6890 * ftxfont.c: Make symbols static if they're not exported.
6891 (ftxfont_driver): Export only if !defined HAVE_XFT && def8ined
6892 HAVE_FREETYPE.
6893 * font.h (ftxfont_driver): Likewise.
6894
6895 * xfns.c: Make symbols static if they're not exported.
6896 (x_last_font_name, x_display_info_for_name):
6897 (x_set_foreground_color, x_set_background_color, x_set_mouse_color):
6898 (x_set_cursor_color, x_set_border_pixel, x_set_border_color):
6899 (x_set_cursor_type, x_set_icon_type, x_set_icon_name):
6900 (x_set_scroll_bar_foreground, x_set_scroll_bar_background):
6901 (x_explicitly_set_name, x_set_title, xic_defaut_fontset, tip_timer):
6902 (last_show_tip_args): Now static.
6903 (xic_defaut_fontset, xic_create_fontsetname): Define only if
6904 defined HAVE_X_WINDOWS && defined USE_X_TOOLKIT
6905 (x_screen_planes): Remove; unused.
6906 * dispextern.h (x_screen_planes): Remove decl.
6907
6908 * dispnew.c: Make symbols static if they're not exported.
6909 * dispextern.h (redraw_garbaged_frames, scrolling):
6910 (increment_row_positions): Remove.
6911 * dispnew.c (new_glyph_matrix, increment_row_positions, scrolling):
6912 (delayed_size_change, glyph_matrix_count, glyph_pool_count):
6913 Now static.
6914 (redraw_garbaged_frames): Remove; unused.
6915
6916 * xfaces.c: Make symbols static if they're not exported.
6917 * dispextern.h (ascii_face_of_lisp_face, free_realized_face):
6918 Remove decls.
6919 * xterm.h (defined_color): Remove decls.
6920 (x_free_dpy_colors): Declare only if USE_X_TOOLKIT.
6921 * xfaces.c (tty_suppress_bold_inverse_default_colors_p):
6922 (menu_face_changed_default, defined_color, free_realized_face):
6923 (x_free_dpy_colors): Define only if USE_X_TOOLKIT.
6924 (ascii_face_of_lisp_face): Remove; unused.
6925
6926 * xdisp.c: Make symbols static if they're not exported.
6927 * dispextern.h (scratch_glyph_row, window_box_edges):
6928 (glyph_to_pixel_coords, set_cursor_from_row):
6929 (get_next_display_element, set_iterator_to_next):
6930 (highlight_trailing_whitespace, frame_to_window_pixel_xy):
6931 (show_mouse_face): Remove decls
6932 * frame.h (message_buf_print): Likewise.
6933 * lisp.h (pop_message, set_message, check_point_in_composition):
6934 Likewise.
6935 * xterm.h (set_vertical_scroll_bar): Likewise.
6936 * xdisp.c (list_of_error, Vmessage_stack, line_number_displayed):
6937 (message_buf_print, scratch_glyph_row, displayed_buffer):
6938 (set_iterator_to_next, pop_message, set_message, set_cursor_from_row):
6939 (get_next_display_element, show_mouse_face, window_box_edges):
6940 (frame_to_window_pixel_xy, check_point_in_composition):
6941 (set_vertical_scroll_bar, highlight_trailing_whitespace): Now static.
6942 (glyph_to_pixel_coords): Remove; unused.
6943
6944 * dired.c (file_name_completion): Now static.
6945
6946 * dbusbind.c (xd_in_read_queued_messages): Now static.
6947
6948 * lisp.h (circular_list_error, FOREACH): Remove; unused.
6949 * data.c (circular_list_error): Remove.
6950
6951 * commands.h (last_point_position, last_point_position_buffer):
6952 (last_point_position_window): Remove decls.
6953 * keyboard.c: Make these variables static.
6954
6955 * coding.h (coding, code_convert_region, encode_coding_gap):
6956 Remove decls.
6957 * coding.c (Vsjis_coding_system, Vbig5_coding_system):
6958 (iso_code_class, detect_coding, code_convert_region): Now static.
6959 (encode_coding_gap): Remove; unused.
6960
6961 * chartab.c (chartab_chars, chartab_bits): Now static.
6962
6963 * charset.h (charset_iso_8859_1): Remove decl.
6964 * charset.c (charset_iso_8859_1, charset_emacs, map_charset_for_dump):
6965 Now static.
6966
6967 * ccl.h (check_ccl_update, Vccl_program_table): Remove decls.
6968 * ccl.c (Vccl_program_table): Now static.
6969 (check_ccl_update): Remove; unused.
6970
6971 * category.c (SET_CATEGORY_SET, set_category_set): Move here.
6972 * category.h: ... from here.
6973 * category.c (check_category_table, set_category_set): Now static.
6974
6975 * casetab.c (Vascii_upcase_table, Vascii_eqv_table): Now static.
6976 * lisp.h: Remove these decls.
6977
6978 * buffer.c (buffer_count): Remove unused var.
6979
6980 * bidi.c (bidi_dump_cached_states): Mark as externally visible,
6981 so that it's not optimized away.
6982 (bidi_ignore_explicit_marks_for_paragraph_level): Likewise.
6983 * dispextern.h (bidi_dump_cached_states): Remove, since it's
6984 exported only to the debugger.
6985
6986 * atimer.c (alarm_signal_handler, run_all_atimers): Now static.
6987 * atimer.h (run_all_atimers): Remove; not exported.
6988
6989 font.c: Make copy_font_spec and merge_font_spec ordinary C functions.
6990 * font.c (copy_font_spec): Rename from Fcopy_font_spec, since it
6991 was inaccessible from Lisp.
6992 (merge_font_spec): Likewise, renaming from Fmerge_font_spec.
6993 * font.c, font.h, fontset.c, xfaces.c, xfont.c: Change all uses.
6994
6995 alloc.c: Import and export fewer symbols, and remove unused items.
6996 * lisp.h (suppress_checking, die): Declare only if ENABLE_CHECKING
6997 is defined.
6998 (suppress_checking): Add EXTERNALLY_VISIBLE attribute, so that
6999 it's not optimized away by whole-program optimization.
7000 (message_enable_multibyte, free_misc): Remove.
7001 (catchlist, handlerlist, mark_backtrace):
7002 Declare only if BYTE_MARK_STACK.
7003 (mark_byte_stack): Likewise, fixing a ifdef-vs-if typo.
7004 * alloc.c (pure): Export only if VIRT_ADDR_VARIES is defined.
7005 (message_enable_multibyte): Remove decl.
7006 (free_misc, interval_free_list, float_block, float_block_index):
7007 (n_float_blocks, float_free_list, cons_block, cons_block_index):
7008 (cons_free_list, last_marked_index):
7009 Now static.
7010 (suppress_checking, die): Define only if ENABLE_CHECKING is defined.
7011 * eval.c (catchlist, handlerlist): Export only if BYTE_MARK_STACK.
7012 (mark_backtrace): Define only if BYTE_MARK_STACK.
7013 * xdisp.c (message_enable_multibyte): Now static.
7014
7015 Declare Lisp_Object Q* variables to be 'static' if not exported.
7016 This makes it easier for human readers (and static analyzers)
7017 to see whether these variables are used from other modules.
7018 * alloc.c, buffer.c, bytecode.c, callint.c, casetab.c, category.c:
7019 * ccl.c, character.c, charset.c, cmds.c, coding.c, composite.c:
7020 * data.c, dbusbind.c, dired.c, editfns.c, eval.c, fileio.c, fns.c:
7021 * font.c, frame.c, fringe.c, ftfont.c, image.c, keyboard.c, keymap.c:
7022 * lread.c, macros.c, minibuf.c, print.c, process.c, search.c:
7023 * sound.c, syntax.c, textprop.c, window.c, xdisp.c, xfaces.c, xfns.c:
7024 * xmenu.c, xselect.c:
7025 Declare Q* vars static if they are not used in other modules.
7026 * ccl.h, character.h, charset.h, coding.h, composite.h, font.h:
7027 * frame.h, intervals.h, keyboard.h, lisp.h, process.h, syntax.h:
7028 Remove decls of unexported vars.
7029 * keyboard.h (EVENT_HEAD_UNMODIFIED): Remove now-unused macro.
7030
7031 * lisp.h (DEFINE_FUNC): Make sname 'static'.
7032
7033 Make Emacs functions such as Fatom 'static' by default.
7034 This makes it easier for human readers (and static analyzers)
7035 to see whether these functions can be called from other modules.
7036 DEFUN now defines a static function. To make the function external
7037 so that it can be used in other C modules, use the new macro DEFUE.
7038 * lisp.h (Funibyte_char_to_multibyte, Fsyntax_table_p):
7039 (Finit_image_library):
7040 (Feval_region, Fbacktrace, Ffetch_bytecode, Fswitch_to_buffer):
7041 (Ffile_executable_p, Fmake_symbolic_link, Fcommand_execute):
7042 (Fget_process, Fdocumentation_property, Fbyte_code, Ffile_attributes):
7043 Remove decls, since these functions are now static.
7044 (Funintern, Fget_internal_run_time): New decls, since these functions
7045 were already external.
7046
7047 * alloc.c, buffer.c, callint.c, callproc.c, casefiddle.c, casetab.c:
7048 * ccl.c, character.c, chartab.c, cmds.c, coding.c, data.c, dispnew.c:
7049 * doc.c, editfns.c, emacs.c, eval.c, fileio.c, filelock.c, floatfns.c:
7050 * fns.c, font.c, fontset.c, frame.c, image.c, indent.c:
7051 * keyboard.c, keymap.c, lread.c:
7052 * macros.c, marker.c, menu.c, minibuf.c, print.c, process.c, search.c:
7053 * syntax.c, term.c, terminal.c, textprop.c, undo.c:
7054 * window.c, xdisp.c, xfaces.c, xfns.c, xmenu.c, xsettings.c:
7055 Mark functions with DEFUE instead of DEFUN,
7056 if they are used in other modules.
7057 * buffer.c (Fset_buffer_major_mode, Fdelete_overlay): New forward
7058 decls for now-static functions.
7059 * buffer.h (Fdelete_overlay): Remove decl.
7060 * callproc.c (Fgetenv_internal): Mark as internal.
7061 * composite.c (Fremove_list_of_text_properties): Remove decl.
7062 (Fcomposition_get_gstring): New forward static decl.
7063 * composite.h (Fcomposite_get_gstring): Remove decl.
7064 * dired.c (Ffile_attributes): New forward static decl.
7065 * doc.c (Fdocumntation_property): New forward static decl.
7066 * eval.c (Ffetch_bytecode): New forward static decl.
7067 (Funintern): Remove extern decl; now in .h file where it belongs.
7068 * fileio.c (Fmake_symbolic_link): New forward static decl.
7069 * image.c (Finit_image_library): New forward static decl.
7070 * insdel.c (Fcombine_after_change_execute): Make forward decl static.
7071 * intervals.h (Fprevious_property_change):
7072 (Fremove_list_of_text_properties): Remove decls.
7073 * keyboard.c (Fthis_command_keys): Remove decl.
7074 (Fcommand_execute): New forward static decl.
7075 * keymap.c (Flookup_key): New forward static decl.
7076 (Fcopy_keymap): Now static.
7077 * keymap.h (Flookup_key): Remove decl.
7078 * process.c (Fget_process): New forward static decl.
7079 (Fprocess_datagram_address): Mark as internal.
7080 * syntax.c (Fsyntax_table_p): New forward static decl.
7081 (skip_chars): Remove duplicate decl.
7082 * textprop.c (Fprevious_property_change): New forward static decl.
7083 * window.c (Fset_window_fringes, Fset_window_scroll_bars):
7084 Now internal.
7085 (Fset_window_margins, Fset_window_vscroll): New forward static decls.
7086 * window.h (Fset_window_vscroll, Fset_window_margins): Remove decls.
7087
7088 * editfns.c (Fformat): Remove unreachable code.
7089
7090 2011-04-14 Andreas Schwab <schwab@linux-m68k.org>
7091
7092 * fileio.c (Finsert_file_contents): Fix typo in 2005-05-13
7093 change. (Bug#8496)
7094
7095 2011-04-13 Eli Zaretskii <eliz@gnu.org>
7096
7097 * xdisp.c (handle_invisible_prop): Don't call bidi_paragraph_init
7098 when at ZV. (Bug#8487)
7099
7100 2011-04-12 Andreas Schwab <schwab@linux-m68k.org>
7101
7102 * charset.c (Fclear_charset_maps): Use xfree instead of free.
7103 (Bug#8437)
7104 * keyboard.c (parse_tool_bar_item): Likewise.
7105 * sound.c (sound_cleanup, alsa_close): Likewise.
7106 * termcap.c (tgetent): Likewise.
7107 * xfns.c (x_default_font_parameter): Likewise.
7108 * xsettings.c (read_and_apply_settings): Likewise.
7109
7110 * alloc.c (overrun_check_malloc, overrun_check_realloc)
7111 (overrun_check_free): Protoize.
7112
7113 2011-04-12 Paul Eggert <eggert@cs.ucla.edu>
7114
7115 * sysdep.c (emacs_read, emacs_write): Check for negative sizes
7116 since callers should never pass a negative size.
7117 Change the signature to match that of plain 'read' and 'write'; see
7118 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00397.html>.
7119 * lisp.h: Update prototypes of emacs_write and emacs_read.
7120
7121 2011-04-11 Eli Zaretskii <eliz@gnu.org>
7122
7123 * xdisp.c (redisplay_window): Don't try to determine the character
7124 position of the scroll margin if the window start point w->startp
7125 is outside the buffer's accessible region. (Bug#8468)
7126
7127 2011-04-10 Eli Zaretskii <eliz@gnu.org>
7128
7129 Fix write-region and its subroutines for buffers > 2GB.
7130 * fileio.c (a_write, e_write): Modify declaration of arguments and
7131 local variables to support buffers larger than 2GB.
7132 (Fcopy_file): Use EMACS_INT for return value of emacs_read.
7133
7134 * sysdep.c (emacs_write, emacs_read): Use ssize_t for last
7135 argument, local variables, and return value.
7136
7137 * lisp.h: Update prototypes of emacs_write and emacs_read.
7138
7139 * sound.c (vox_write): Use ssize_t for return value of emacs_write.
7140
7141 2011-04-10 Paul Eggert <eggert@cs.ucla.edu>
7142
7143 * xdisp.c (vmessage): Use memchr, not strnlen, which some hosts lack.
7144
7145 Fix more problems found by GCC 4.6.0's static checks.
7146
7147 * xdisp.c (vmessage): Use a better test for character truncation.
7148
7149 * charset.c (load_charset_map): <, not <=, for optimization,
7150 and to avoid potential problems with integer overflow.
7151 * chartab.c (sub_char_table_set_range, char_table_set_range): Likewise.
7152 * casetab.c (set_identity, shuffle): Likewise.
7153 * editfns.c (Fformat): Likewise.
7154 * syntax.c (skip_chars): Likewise.
7155
7156 * xmenu.c (set_frame_menubar): Allocate smaller local vectors.
7157 This also lets GCC 4.6.0 generate slightly better loop code.
7158
7159 * callint.c (Fcall_interactively): <, not <=, for optimization.
7160 (Fcall_interactively): Count the number of arguments produced,
7161 not the number of arguments given. This is simpler and lets GCC
7162 4.6.0 generate slightly better code.
7163
7164 * ftfont.c: Distingish more carefully between FcChar8 and char.
7165 The previous code passed unsigned char * to a functions like
7166 strlen and xstrcasecmp that expect char *, which does not
7167 conform to the C standard.
7168 (get_adstyle_property, ftfont_pattern_entity): Use FcChar8 for
7169 arguments to FcPatternGetString, and explicitly cast FcChar8 * to
7170 char * when the C standard requires it.
7171
7172 * keyboard.c (read_char): Remove unused var.
7173
7174 * eval.c: Port to Windows vsnprintf (Bug#8435).
7175 Include <limits.h>.
7176 (SIZE_MAX): Define if the headers do not.
7177 (verror): Do not give up if vsnprintf returns a negative count.
7178 Instead, grow the buffer. This ports to Windows vsnprintf, which
7179 does not conform to C99. Problem reported by Eli Zaretskii.
7180 Also, simplify the allocation scheme, by avoiding the need for
7181 calling realloc, and removing the ALLOCATED variable.
7182
7183 * eval.c (verror): Initial buffer size is 4000 (not 200) bytes.
7184
7185 Remove invocations of doprnt, as Emacs now uses vsnprintf.
7186 But keep the doprint source code for now, as we might revamp it
7187 and use it again (Bug#8435).
7188 * lisp.h (doprnt): Remove.
7189 * Makefile.in (base_obj): Remove doprnt.o.
7190 * deps.mk (doprnt.o): Remove.
7191
7192 error: Print 32- and 64-bit integers portably (Bug#8435).
7193 Without this change, on typical 64-bit hosts error ("...%d...", N)
7194 was used to print both 32- and 64-bit integers N, which relied on
7195 undefined behavior.
7196 * lisp.h, src/m/amdx86-64.h, src/m/ia64.h, src/m/ibms390x.h (pEd):
7197 New macro.
7198 * lisp.h (error, verror): Mark as printf-like functions.
7199 * eval.c (verror): Use vsnprintf, not doprnt, to do the real work.
7200 Report overflow in size calculations when allocating printf buffer.
7201 Do not truncate output string at its first null byte.
7202 * xdisp.c (vmessage): Use vsnprintf, not doprnt, to do the real work.
7203 Truncate the output at a character boundary, since vsnprintf does not
7204 do that.
7205 * charset.c (check_iso_charset_parameter): Convert internal
7206 character to string before calling 'error', since %c now has the
7207 printf meaning.
7208 * coding.c (Fdecode_sjis_char, Fdecode_big5_char): Avoid int
7209 overflow when computing char to be passed to 'error'. Do not
7210 pass Lisp_Object to 'error'; pass the integer instead.
7211 * nsfns.m (Fns_do_applescript): Use int, not long, since it's
7212 formatted with plain %d.
7213
7214 * eval.c (internal_lisp_condition_case): Don't pass spurious arg.
7215
7216 * keyboard.c (access_keymap_keyremap): Print func name, not garbage.
7217
7218 * coding.c (Fdecode_sjis_char): Don't assume CODE fits in int.
7219
7220 * xterm.c (x_catch_errors): Remove duplicate declaration.
7221
7222 * term.c (maybe_fatal): Mark its 3rd arg as a printf format, too.
7223
7224 * xdisp.c, lisp.h (message_nolog): Remove; unused.
7225
7226 2011-04-10 Jim Meyering <meyering@redhat.com>
7227
7228 use ssize_t and size_t for read- and write-like emacs_gnutls_* functions
7229 * gnutls.c (emacs_gnutls_read): Adjust signature to be more read-like:
7230 return ssize_t not "int", and use size_t as the buffer length.
7231 (emacs_gnutls_write): Likewise, and make the buffer pointer "const".
7232 * gnutls.h: Update declarations.
7233 * process.c (read_process_output): Use ssize_t, to match.
7234 (send_process): Likewise.
7235
7236 2011-04-09 Chong Yidong <cyd@stupidchicken.com>
7237
7238 * image.c (Fimagemagick_types): Doc fix, and comment cleanup.
7239
7240 2011-04-09 Chong Yidong <cyd@stupidchicken.com>
7241
7242 * ftfont.c (get_adstyle_property, ftfont_pattern_entity):
7243 Use unsigned char, to match FcChar8 type definition.
7244
7245 * xterm.c (handle_one_xevent):
7246 * xmenu.c (create_and_show_popup_menu):
7247 * xselect.c (x_decline_selection_request)
7248 (x_reply_selection_request): Avoid type-punned deref of X events.
7249
7250 2011-04-09 Eli Zaretskii <eliz@gnu.org>
7251
7252 Fix some uses of `int' instead of EMACS_INT.
7253 * search.c (string_match_1, fast_string_match)
7254 (fast_c_string_match_ignore_case, fast_string_match_ignore_case)
7255 (scan_buffer, find_next_newline_no_quit)
7256 (find_before_next_newline, search_command, Freplace_match)
7257 (Fmatch_data): Make some `int' variables be EMACS_INT.
7258
7259 * xdisp.c (display_count_lines): 3rd argument and return value now
7260 EMACS_INT. All callers changed.
7261 (pint2hrstr): Last argument is now EMACS_INT.
7262
7263 * coding.c (detect_coding_utf_8, detect_coding_emacs_mule)
7264 (detect_coding_iso_2022, detect_coding_sjis, detect_coding_big5)
7265 (detect_coding_ccl, detect_coding_charset, decode_coding_utf_8)
7266 (decode_coding_utf_16, decode_coding_emacs_mule)
7267 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5)
7268 (decode_coding_ccl, decode_coding_charset)
7269 <consumed_chars, consumed_chars_base>: Declare EMACS_INT.
7270 (decode_coding_iso_2022, decode_coding_emacs_mule)
7271 (decode_coding_sjis, decode_coding_big5, decode_coding_charset)
7272 <char_offset, last_offset>: Declare EMACS_INT.
7273 (encode_coding_utf_8, encode_coding_utf_16)
7274 (encode_coding_emacs_mule, encode_invocation_designation)
7275 (encode_designation_at_bol, encode_coding_iso_2022)
7276 (encode_coding_sjis, encode_coding_big5, encode_coding_ccl)
7277 (encode_coding_raw_text, encode_coding_charset) <produced_chars>:
7278 Declare EMACS_INT.
7279 (ASSURE_DESTINATION): Declare more_bytes EMACS_INT.
7280 (encode_invocation_designation): Last argument P_NCHARS is now
7281 EMACS_INT.
7282 (decode_eol): Declare pos_byte, pos, and pos_end EMACS_INT.
7283 (produce_chars): from_nchars and to_nchars are now EMACS_INT.
7284
7285 * coding.h (struct coding_system) <head_ascii>: Declare EMACS_INT.
7286 All users changed.
7287
7288 * ccl.c (Fccl_execute_on_string): Declare some variables
7289 EMACS_INT.
7290
7291 2011-04-08 Samuel Thibault <sthibault@debian.org> (tiny change)
7292
7293 * term.c (init_tty): Fix incorrect ifdef placement (Bug#8450).
7294
7295 2011-03-19 Christoph Scholtes <cschol2112@googlemail.com>
7296
7297 * process.c (Fformat_network_address): Doc fix.
7298
7299 2011-04-08 T.V. Raman <tv.raman.tv@gmail.com> (tiny change)
7300
7301 * xml.c (parse_region): Avoid creating spurious whitespace nodes.
7302
7303 2011-04-08 Chong Yidong <cyd@stupidchicken.com>
7304
7305 * keyboard.c (read_char): Call Lisp function help-form-show,
7306 instead of using internal_with_output_to_temp_buffer.
7307 (Qhelp_form_show): New var.
7308 (syms_of_keyboard): Use DEFSYM macro.
7309
7310 * print.c (internal_with_output_to_temp_buffer): Function deleted.
7311
7312 * lisp.h (internal_with_output_to_temp_buffer): Remove prototype.
7313
7314 2011-04-06 Chong Yidong <cyd@stupidchicken.com>
7315
7316 * process.c (Flist_processes): Remove to Lisp.
7317 (list_processes_1): Delete.
7318
7319 2011-04-06 Eli Zaretskii <eliz@gnu.org>
7320
7321 * msdos.c (careadlinkat, careadlinkatcwd): MS-DOS replacements.
7322
7323 * w32.c (careadlinkat, careadlinkatcwd): New always-fail stubs.
7324
7325 2011-04-06 Paul Eggert <eggert@cs.ucla.edu>
7326
7327 Fix more problems found by GCC 4.6.0's static checks.
7328
7329 * xmenu.c (Fx_popup_dialog): Don't assume string is free of formats.
7330
7331 * menu.c (Fx_popup_menu): Don't assume error_name lacks printf formats.
7332
7333 * lisp.h (message, message_nolog, fatal): Mark as printf-like.
7334
7335 * xdisp.c (vmessage): Mark as a printf-like function.
7336
7337 * term.c (vfatal, maybe_fatal): Mark as printf-like functions.
7338
7339 * sound.c (sound_warning): Don't crash if arg contains a printf format.
7340
7341 * image.c (tiff_error_handler, tiff_warning_handler): Mark as
7342 printf-like functions.
7343 (tiff_load): Add casts to remove these marks before passing them
7344 to system-supplied API.
7345
7346 * eval.c (Fsignal): Remove excess argument to 'fatal'.
7347
7348 * coding.c (EMIT_ONE_BYTE, EMIT_TWO_BYTES): Use unsigned, not int.
7349 This avoids several warnings with gcc -Wstrict-overflow.
7350 (DECODE_COMPOSITION_RULE): If the rule is invalid, goto invalid_code
7351 directly, rather than having caller test rule sign. This avoids
7352 some unnecessary tests.
7353 * composite.h (COMPOSITION_ENCODE_RULE_VALID): New macro.
7354 (COMPOSITION_ENCODE_RULE): Arguments now must be valid. This
7355 affects only one use, in DECODE_COMPOSITION_RULE, which is changed.
7356
7357 * xfont.c (xfont_text_extents): Remove var that was set but not used.
7358 (xfont_open): Avoid unnecessary tests.
7359
7360 * composite.c (composition_gstring_put_cache): Use unsigned integer.
7361
7362 * composite.h, composite.c (composition_gstring_put_cache):
7363 Use EMACS_INT, not int, for length.
7364
7365 * composite.h (COMPOSITION_DECODE_REFS): New macro,
7366 breaking out part of COMPOSITION_DECODE_RULE.
7367 (COMPOSITION_DECODE_RULE): Use it.
7368 * composite.c (get_composition_id): Remove unused local vars,
7369 by using the new macro.
7370
7371 * textprop.c (set_text_properties_1): Change while to do-while,
7372 since the condition is always true at first.
7373
7374 * intervals.c (graft_intervals_into_buffer): Mark var as used.
7375 (interval_deletion_adjustment): Return unsigned value.
7376 All uses changed.
7377
7378 * process.c (list_processes_1, create_pty, read_process_output):
7379 (exec_sentinel): Remove vars that were set but not used.
7380 (create_pty): Remove unnecessary "volatile"s.
7381 (Fnetwork_interface_info): Avoid possibility of int overflow.
7382 (read_process_output): Do adaptive read buffering even if carryover.
7383 (read_process_output): Simplify nbytes computation if buffered.
7384
7385 * bytecode.c (exec_byte_code): Rename local to avoid shadowing.
7386
7387 * syntax.c (scan_words): Remove var that was set but not used.
7388 (update_syntax_table): Use unsigned instead of int.
7389
7390 * lread.c (lisp_file_lexically_bound_p): Use ints rather than endptrs.
7391 (lisp_file_lexically_bound_p, read1): Use unsigned instead of int.
7392 (safe_to_load_p): Make the end-of-loop test the inverse of the in-loop.
7393
7394 * print.c (print_error_message): Avoid int overflow.
7395
7396 * font.c (font_list_entities): Redo for clarity,
7397 so that reader need not know FONT_DPI_INDEX + 1 == FONT_SPACING_INDEX.
7398
7399 * font.c (font_find_for_lface, Ffont_get_glyphs): Remove unused vars.
7400 (font_score): Avoid potential overflow in diff calculation.
7401
7402 * fns.c (substring_both): Remove var that is set but not used.
7403 (sxhash): Redo loop for clarity and to avoid wraparound warning.
7404
7405 * eval.c (funcall_lambda): Rename local to avoid shadowing.
7406
7407 * alloc.c (mark_object_loop_halt, mark_object): Use size_t, not int.
7408 Otherwise, GCC 4.6.0 optimizes the loop check away since the check
7409 can always succeed if overflow has undefined behavior.
7410
7411 * search.c (boyer_moore, wordify): Remove vars set but not used.
7412 (wordify): Omit three unnecessary tests.
7413
7414 * indent.c (MULTIBYTE_BYTES_WIDTH): Don't compute wide_column.
7415 All callers changed. This avoids the need for an unused var.
7416
7417 * casefiddle.c (casify_region): Remove var that is set but not used.
7418
7419 * dired.c (file_name_completion): Remove var that is set but not used.
7420
7421 * fileio.c (Finsert_file_contents): Make EOF condition clearer.
7422
7423 * fileio.c (Finsert_file_contents): Avoid signed integer overflow.
7424 (Finsert_file_contents): Remove unnecessary code checking fd.
7425
7426 * minibuf.c (read_minibuf_noninteractive): Use size_t for sizes.
7427 Check for integer overflow on size calculations.
7428
7429 * buffer.c (Fprevious_overlay_change): Remove var that is set
7430 but not used.
7431
7432 * keyboard.c (menu_bar_items, read_char_minibuf_menu_prompt):
7433 Remove vars that are set but not used.
7434 (timer_check_2): Don't assume timer-list and idle-timer-list are lists.
7435 (timer_check_2): Mark vars as initialized.
7436
7437 * gtkutil.c (xg_get_file_with_chooser): Mark var as initialized.
7438
7439 * image.c (lookup_image): Remove var that is set but not used.
7440 (xbm_load): Use parse_p, for gcc -Werror=unused-but-set-variable.
7441
7442 * fontset.c (Finternal_char_font, Ffontset_info): Remove vars
7443 that are set but not used.
7444
7445 * xfns.c (make_invisible_cursor): Don't return garbage
7446 if XCreateBitmapFromData fails (Bug#8410).
7447
7448 * xselect.c (x_get_local_selection, x_handle_property_notify):
7449 Remove vars that are set but not used.
7450
7451 * xfns.c (x_create_tip_frame): Remove var that is set but not used.
7452 (make_invisible_cursor): Initialize a possibly-uninitialized variable.
7453
7454 * xterm.c (x_scroll_bar_to_input_event) [!USE_GTK]:
7455 Remove var that is set but not used.
7456 (scroll_bar_windows_size): Now size_t, not int.
7457 (x_send_scroll_bar_event): Use size_t, not int, for sizes.
7458 Check for overflow.
7459
7460 * xfaces.c (realize_named_face): Remove vars that are set but not used.
7461 (map_tty_color) [!defined MSDOS]: Likewise.
7462
7463 * term.c (tty_write_glyphs): Use size_t; this avoids overflow warning.
7464
7465 * coding.c: Remove vars that are set but not used.
7466 (DECODE_COMPOSITION_RULE): Remove 2nd arg, which is unused.
7467 All callers changed.
7468 (decode_coding_utf_8, decode_coding_utf_16 decode_coding_emacs_mule):
7469 (decode_coding_iso_2022, encode_coding_sjis, encode_coding_big5):
7470 (decode_coding_charset): Remove vars that are set but not used.
7471
7472 * bytecode.c (Fbyte_code) [!defined BYTE_CODE_SAFE]: Remove var
7473 that is set but not used.
7474
7475 * print.c (print_object): Remove var that is set but not used.
7476
7477 Replace 2 copies of readlink code with 1 gnulib version (Bug#8401).
7478 The gnulib version avoids calling malloc in the usual case,
7479 and on 64-bit hosts doesn't have some arbitrary 32-bit limits.
7480 * fileio.c (Ffile_symlink_p): Use emacs_readlink.
7481 * filelock.c (current_lock_owner): Likewise.
7482 * lisp.h (READLINK_BUFSIZE, emacs_readlink): New function.
7483 * sysdep.c: Include allocator.h, careadlinkat.h.
7484 (emacs_no_realloc_allocator): New static constant.
7485 (emacs_readlink): New function.
7486 * deps.mk (sysdep.o): Depend on ../lib/allocator.h and on
7487 ../lib/careadlinkat.h.
7488
7489 2011-04-04 Stefan Monnier <monnier@iro.umontreal.ca>
7490
7491 * keyboard.c (safe_run_hook_funcall): Fix last change (don't stop at the
7492 first non-nil return value).
7493
7494 2011-04-03 Jan Djärv <jan.h.d@swipnet.se>
7495
7496 * nsterm.m (ns_update_auto_hide_menu_bar): Define MAC_OS_X_VERSION_10_6
7497 if not defined (Bug#8403).
7498
7499 2011-04-02 Juanma Barranquero <lekktu@gmail.com>
7500
7501 * xdisp.c (display_count_lines): Remove parameter `start',
7502 unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
7503 (get_char_face_and_encoding): Remove parameter `multibyte_p',
7504 unused since 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
7505 (fill_stretch_glyph_string): Remove parameters `row' and `area',
7506 unused at least since Kim's GUI unification at 2003-03-16T20:45:46Z!storm@cua.dk
7507 and thereabouts. All callers changed.
7508 (get_per_char_metric): Remove parameter `f', unused since
7509 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
7510
7511 2011-04-02 Jim Meyering <meyering@redhat.com>
7512
7513 do not dereference NULL upon failed strdup
7514 * nsfont.m (ns_descriptor_to_entity): Use xstrdup, not strdup.
7515 (ns_get_family): Likewise.
7516
7517 2011-04-02 Juanma Barranquero <lekktu@gmail.com>
7518
7519 * eval.c (unwind_to_catch) [DEBUG_GCPRO]: Remove redundant assignment.
7520
7521 2011-04-02 Jan Djärv <jan.h.d@swipnet.se>
7522
7523 * nsterm.m (ns_update_auto_hide_menu_bar): Only for OSX 10.6 or
7524 later (Bug#8403).
7525
7526 2011-04-01 Stefan Monnier <monnier@iro.umontreal.ca>
7527
7528 Add lexical binding.
7529
7530 * window.c (Ftemp_output_buffer_show): New fun.
7531 (Fsave_window_excursion):
7532 * print.c (Fwith_output_to_temp_buffer): Move to subr.el.
7533
7534 * lread.c (lisp_file_lexically_bound_p): New function.
7535 (Fload): Bind Qlexical_binding.
7536 (readevalloop): Remove `evalfun' arg.
7537 Bind Qinternal_interpreter_environment.
7538 (Feval_buffer): Bind Qlexical_binding.
7539 (defvar_int, defvar_bool, defvar_lisp_nopro, defvar_kboard):
7540 Mark as dynamic.
7541 (syms_of_lread): Declare `lexical-binding'.
7542
7543 * lisp.h (struct Lisp_Symbol): New field `declared_special'.
7544
7545 * keyboard.c (eval_dyn): New fun.
7546 (menu_item_eval_property): Use it.
7547
7548 * image.c (parse_image_spec): Use Ffunctionp.
7549
7550 * fns.c (concat, mapcar1): Accept byte-code-functions.
7551
7552 * eval.c (Fsetq): Handle lexical vars.
7553 (Fdefun, Fdefmacro, Ffunction): Make closures when needed.
7554 (Fdefconst, Fdefvaralias, Fdefvar): Mark as dynamic.
7555 (FletX, Flet): Obey lexical binding.
7556 (Fcommandp): Handle closures.
7557 (Feval): New `lexical' arg.
7558 (eval_sub): New function extracted from Feval. Use it almost
7559 everywhere where Feval was used. Look up vars in lexical env.
7560 Handle closures.
7561 (Ffunctionp): Move from subr.el.
7562 (Ffuncall): Handle closures.
7563 (apply_lambda): Remove `eval_flags'.
7564 (funcall_lambda): Handle closures and new byte-code-functions.
7565 (Fspecial_variable_p): New function.
7566 (syms_of_eval): Initialize the Vinternal_interpreter_environment var,
7567 but without exporting it to Lisp.
7568
7569 * doc.c (Fdocumentation, store_function_docstring):
7570 * data.c (Finteractive_form): Handle closures.
7571
7572 * callint.c (Fcall_interactively): Preserve lexical-binding mode for
7573 interactive spec.
7574
7575 * bytecode.c (Bstack_ref, Bstack_set, Bstack_set2, BdiscardN):
7576 New byte-codes.
7577 (exec_byte_code): New function extracted from Fbyte_code to handle new
7578 calling convention for byte-code-functions. Add new byte-codes.
7579
7580 * buffer.c (defvar_per_buffer): Set new `declared_special' field.
7581
7582 * alloc.c (Fmake_symbol): Init new `declared_special' field.
7583
7584 2011-03-31 Juanma Barranquero <lekktu@gmail.com>
7585
7586 * xdisp.c (redisplay_internal): Fix prototype.
7587
7588 2011-03-31 Eli Zaretskii <eliz@gnu.org>
7589
7590 * xdisp.c (SCROLL_LIMIT): New macro.
7591 (try_scrolling): Use it when setting scroll_limit.
7592 Limit scrolling to 100 screen lines.
7593 (redisplay_window): Even when falling back on "recentering",
7594 position point in the window according to scroll-conservatively,
7595 scroll-margin, and scroll-*-aggressively variables. (Bug#6671)
7596
7597 (try_scrolling): When point is above the window, allow searching
7598 as far as scroll_max, or one screenful, to compute vertical
7599 distance from PT to the scroll margin position. This prevents
7600 try_scrolling from unnecessarily failing when
7601 scroll-conservatively is set to a value slightly larger than the
7602 window height. Clean up the case of PT below the margin at bottom
7603 of window: scroll_max can no longer be INT_MAX. When aggressive
7604 scrolling is in use, don't let point enter the opposite scroll
7605 margin as result of the scroll.
7606 (syms_of_xdisp) <scroll-conservatively>: Document the
7607 threshold of 100 lines for never-recentering scrolling.
7608
7609 2011-03-31 Juanma Barranquero <lekktu@gmail.com>
7610
7611 * dispextern.h (move_it_by_lines):
7612 * xdisp.c (move_it_by_lines): Remove parameter `need_y_p', unused
7613 since 2000-12-29T14:24:09Z!gerd@gnu.org. All callers changed.
7614 (message_log_check_duplicate): Remove parameters `prev_bol' and
7615 `this_bol', unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
7616 (redisplay_internal): Remove parameter `preserve_echo_area',
7617 unused since 1999-07-21T21:43:52Z!gerd@gnu.org. All callers changed.
7618
7619 * indent.c (Fvertical_motion):
7620 * window.c (window_scroll_pixel_based, Frecenter):
7621 Don't pass `need_y_p' to `move_it_by_lines'.
7622
7623 2011-03-30 Stefan Monnier <monnier@iro.umontreal.ca>
7624
7625 * eval.c (struct backtrace): Don't cheat with negative numbers, but do
7626 steal a few bits to be more compact.
7627 (interactive_p, Fbacktrace, Fbacktrace_frame, mark_backtrace):
7628 Remove unneeded casts.
7629
7630 * bytecode.c (Fbyte_code): CAR and CDR can GC.
7631
7632 2011-03-30 Zachary Kanfer <zkanfer@gmail.com> (tiny change)
7633
7634 * keyboard.c (Fexecute_extended_command): Do log the "suggest key
7635 binding" message (bug#7967).
7636
7637 2011-03-30 Paul Eggert <eggert@cs.ucla.edu>
7638
7639 Fix more problems found by GCC 4.6.0's static checks.
7640
7641 * unexelf.c (unexec) [! (defined _SYSTYPE_SYSV || defined __sgi)]:
7642 Remove unused local var.
7643
7644 * editfns.c (Fmessage_box): Remove unused local var.
7645
7646 * xdisp.c (try_window_reusing_current_matrix, x_produce_glyphs):
7647 (note_mode_line_or_margin_highlight, note_mouse_highlight):
7648 Omit unused local vars.
7649 * window.c (shrink_windows): Omit unused local var.
7650 * menu.c (digest_single_submenu): Omit unused local var.
7651 * dispnew.c (update_window) [PERIODIC_PREEMPTION_CHECKING]:
7652 Omit unused local var.
7653
7654 * keyboard.c (parse_modifiers_uncached, parse_modifiers):
7655 Don't assume string length fits in int.
7656 (keyremap_step, read_key_sequence): Use size_t for sizes.
7657 (read_key_sequence): Don't check last_real_key_start redundantly.
7658
7659 * callproc.c (Fcall_process, Fcall_process_region): Use SAFE_ALLOCA
7660 instead of alloca (Bug#8344).
7661
7662 * eval.c (Fbacktrace): Don't assume nargs fits in int.
7663 (Fbacktrace_frame): Don't assume nframes fits in int.
7664
7665 * syntax.c (scan_sexps_forward): Avoid pointer wraparound.
7666
7667 * xterm.c (x_make_frame_visible, same_x_server): Redo to avoid overflow
7668 concerns.
7669
7670 * term.c (produce_glyphless_glyph): Remove unnecessary test.
7671
7672 * cm.c (calccost): Turn while-do into do-while, for clarity.
7673
7674 * keyboard.c (syms_of_keyboard): Use the same style as later
7675 in this function when indexing through an array. This also
7676 works around GCC bug 48267.
7677
7678 * image.c (tiff_load): Fix off-by-one image count (Bug#8336).
7679
7680 * xselect.c (x_check_property_data): Return correct size (Bug#8335).
7681
7682 * chartab.c (sub_char_table_ref_and_range): Redo for slight
7683 efficiency gain, and to bypass a gcc -Wstrict-overflow warning.
7684
7685 * keyboard.c, keyboard.h (num_input_events): Now size_t.
7686 This avoids undefined behavior on integer overflow, and is a bit
7687 more convenient anyway since it is compared to a size_t variable.
7688
7689 Variadic C functions now count arguments with size_t, not int.
7690 This avoids an unnecessary limitation on 64-bit machines, which
7691 caused (substring ...) to crash on large vectors (Bug#8344).
7692 * lisp.h (struct Lisp_Subr.function.aMANY): Now takes size_t, not int.
7693 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call): Likewise.
7694 All variadic functions and their callers changed accordingly.
7695 (struct gcpro.nvars): Now size_t, not int. All uses changed.
7696 * data.c (arith_driver, float_arith_driver): Likewise.
7697 * editfns.c (general_insert_function): Likewise.
7698 * eval.c (struct backtrace.nargs, interactive_p)
7699 (internal_condition_case_n, run_hook_with_args, apply_lambda)
7700 (funcall_lambda, mark_backtrace): Likewise.
7701 * fns.c (concat): Likewise.
7702 * frame.c (x_set_frame_parameters): Likewise.
7703 * fns.c (get_key_arg): Now accepts and returns size_t, and returns
7704 0 if not found, not -1. All callers changed.
7705
7706 * alloc.c (garbage_collect): Don't assume stack size fits in int.
7707 (stack_copy_size): Now size_t, not int.
7708 (stack_copy, stack_copy_size): Define only if MAX_SAVE_STACK > 0.
7709
7710 2011-03-28 Juanma Barranquero <lekktu@gmail.com>
7711
7712 * coding.c (encode_designation_at_bol): Remove parameter `charbuf_end',
7713 unused since 2002-03-01T01:17:24Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
7714 All callers changed.
7715
7716 * lisp.h (multibyte_char_to_unibyte):
7717 * character.c (multibyte_char_to_unibyte): Remove parameter `rev_tbl',
7718 unused since 2002-03-01T01:16:34Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
7719 * character.h (CHAR_TO_BYTE8):
7720 * cmds.c (internal_self_insert):
7721 * editfns.c (general_insert_function):
7722 * keymap.c (push_key_description):
7723 * search.c (Freplace_match):
7724 * xdisp.c (message_dolog, set_message_1): All callers changed.
7725
7726 2011-03-28 Stefan Monnier <monnier@iro.umontreal.ca>
7727
7728 * keyboard.c (safe_run_hook_funcall): New function.
7729 (safe_run_hooks_1, safe_run_hooks_error, safe_run_hooks): On error,
7730 don't set the hook to nil, but remove the offending function instead.
7731 (Qcommand_hook_internal): Remove, unused.
7732 (syms_of_keyboard): Don't initialize Qcommand_hook_internal nor define
7733 Vcommand_hook_internal.
7734
7735 * eval.c (enum run_hooks_condition): Remove.
7736 (funcall_nil, funcall_not): New functions.
7737 (run_hook_with_args): Call each function through a `funcall' argument.
7738 Remove `cond' argument, now redundant.
7739 (Frun_hooks, Frun_hook_with_args, Frun_hook_with_args_until_success)
7740 (Frun_hook_with_args_until_failure): Adjust accordingly.
7741 (run_hook_wrapped_funcall, Frun_hook_wrapped): New functions.
7742
7743 2011-03-28 Juanma Barranquero <lekktu@gmail.com>
7744
7745 * dispextern.h (string_buffer_position): Remove declaration.
7746
7747 * print.c (strout): Remove parameter `multibyte', unused since
7748 1999-08-21T19:30:21Z!gerd@gnu.org. All callers changed.
7749
7750 * search.c (boyer_moore): Remove parameters `len', `pos' and `lim',
7751 never used since function introduction in 1998-02-08T21:33:56Z!rms@gnu.org.
7752 All callers changed.
7753
7754 * w32.c (_wsa_errlist): Use braces for struct initializers.
7755
7756 * xdisp.c (string_buffer_position_lim): Remove parameter `w',
7757 never used since function introduction in 2001-03-09T18:41:50Z!gerd@gnu.org.
7758 All callers changed.
7759 (string_buffer_position): Likewise. Also, make static (it's never
7760 used outside xdisp.c).
7761 (cursor_row_p): Remove parameter `w', unused since
7762 2000-10-17T16:08:57Z!gerd@gnu.org. All callers changed.
7763 (decode_mode_spec): Remove parameter `precision', introduced during
7764 Gerd Moellmann's rewrite at 1999-07-21T21:43:52Z!gerd@gnu.org, but never used.
7765 All callers changed.
7766
7767 2011-03-27 Jan Djärv <jan.h.d@swipnet.se>
7768
7769 * nsterm.m (syms_of_nsterm): Use doc: for ns-auto-hide-menu-bar.
7770
7771 2011-03-27 Anders Lindgren <andlind@gmail.com>
7772
7773 * nsterm.m (ns_menu_bar_is_hidden): New variable.
7774 (ns_constrain_all_frames, ns_menu_bar_should_be_hidden)
7775 (ns_update_auto_hide_menu_bar): New functions.
7776 (ns_update_begin): Call ns_update_auto_hide_menu_bar.
7777 (applicationDidBecomeActive): Call ns_update_auto_hide_menu_bar and
7778 ns_constrain_all_frames.
7779 (constrainFrameRect): Return at once if ns_menu_bar_should_be_hidden.
7780 (syms_of_nsterm): DEFVAR ns-auto-hide-menu-bar, init to Qnil.
7781
7782 2011-03-27 Jan Djärv <jan.h.d@swipnet.se>
7783
7784 * nsmenu.m (runDialogAt): Remove argument to timer_check.
7785
7786 2011-03-27 Glenn Morris <rgm@gnu.org>
7787
7788 * syssignal.h: Replace RETSIGTYPE with void.
7789 * atimer.c, data.c, dispnew.c, emacs.c, floatfns.c, keyboard.c:
7790 * keyboard.h, lisp.h, process.c, sysdep.c, xterm.c:
7791 Replace SIGTYPE with void everywhere.
7792 * s/usg5-4-common.h (SIGTYPE): Remove definition.
7793 * s/template.h (SIGTYPE): Remove commented out definition.
7794
7795 2011-03-26 Eli Zaretskii <eliz@gnu.org>
7796
7797 * xdisp.c (redisplay_window): Don't check buffer's clip_changed
7798 flag as a prerequisite for invoking try_scrolling. (Bug#6671)
7799
7800 2011-03-26 Juanma Barranquero <lekktu@gmail.com>
7801
7802 * w32.c (read_unc_volume): Use parameter `henum', instead of
7803 global variable `wget_enum_handle'.
7804
7805 * keymap.c (describe_vector): Remove parameters `indices' and
7806 `char_table_depth', unused since 2002-03-01T01:43:26Z!handa@m17n.org.
7807 (describe_map, Fdescribe_vector): Adjust calls to `describe_vector'.
7808
7809 * keyboard.h (timer_check, show_help_echo): Remove unused parameters.
7810
7811 * keyboard.c (timer_check): Remove parameter `do_it_now',
7812 unused since 1996-04-12T06:01:29Z!rms@gnu.org.
7813 (show_help_echo): Remove parameter `ok_to_overwrite_keystroke_echo',
7814 unused since 2008-04-19T19:30:53Z!monnier@iro.umontreal.ca.
7815
7816 * keyboard.c (read_char):
7817 * w32menu.c (w32_menu_display_help):
7818 * xmenu.c (show_help_event, menu_help_callback):
7819 Adjust calls to `show_help_echo'.
7820
7821 * gtkutil.c (xg_maybe_add_timer):
7822 * keyboard.c (readable_events):
7823 * process.c (wait_reading_process_output):
7824 * xmenu.c (x_menu_wait_for_event): Adjust calls to `timer_check'.
7825
7826 * insdel.c (adjust_markers_gap_motion):
7827 Remove; no-op since 1998-01-02T21:29:48Z!rms@gnu.org.
7828 (gap_left, gap_right): Don't call it.
7829
7830 2011-03-25 Chong Yidong <cyd@stupidchicken.com>
7831
7832 * xdisp.c (handle_fontified_prop): Discard changes to clip_changed
7833 incurred during fontification.
7834
7835 2011-03-25 Juanma Barranquero <lekktu@gmail.com>
7836
7837 * buffer.c (defvar_per_buffer): Remove unused parameter `doc'.
7838 (DEFVAR_PER_BUFFER): Don't pass it.
7839
7840 * dispnew.c (row_equal_p, add_row_entry): Remove unused parameter `w'.
7841 (scrolling_window): Don't pass it.
7842
7843 2011-03-25 Juanma Barranquero <lekktu@gmail.com>
7844
7845 * dispextern.h (glyph_matric): Use #if GLYPH_DEBUG, not #ifdef.
7846
7847 * fileio.c (check_executable) [DOS_NT]: Remove unused variables `len'
7848 and `suffix'.
7849 (Fset_file_selinux_context) [HAVE_LIBSELINUX]: Move here declaration
7850 of variables specific to SELinux and computation of `encoded_absname'.
7851
7852 * image.c (XPutPixel): Remove unused variable `height'.
7853
7854 * keyboard.c (make_lispy_event): Remove unused variable `hpos'.
7855
7856 * unexw32.c (get_section_info): Remove unused variable `section'.
7857
7858 * w32.c (stat): Remove unused variables `drive_root' and `devtype'.
7859 (system_process_attributes): Remove unused variable `sess'.
7860 (sys_read): Remove unused variable `err'.
7861
7862 * w32fns.c (top): Wrap variables with #if GLYPH_DEBUG, not #ifdef.
7863 (w32_wnd_proc): Remove unused variable `isdead'.
7864 (unwind_create_frame): Use #if GLYPH_DEBUG, not #ifdef.
7865 (Fx_server_max_request_size): Remove unused variable `dpyinfo'.
7866 (x_create_tip_frame): Remove unused variable `tem'.
7867
7868 * w32inevt.c (w32_console_read_socket):
7869 Remove unused variable `no_events'.
7870
7871 * w32term.c (x_draw_composite_glyph_string_foreground):
7872 Remove unused variable `width'.
7873
7874 2011-03-24 Juanma Barranquero <lekktu@gmail.com>
7875
7876 * w32term.c (x_set_glyph_string_clipping):
7877 Don't pass uninitialized region to CombineRgn.
7878
7879 2011-03-23 Juanma Barranquero <lekktu@gmail.com>
7880
7881 * w32fns.c (x_set_menu_bar_lines): Remove unused variable `olines'.
7882 (w32_wnd_proc): Pass NULL to Windows API, not uninitialized buffer.
7883 (Fx_close_connection): Remove unused variable `i'.
7884
7885 * w32font.c (w32font_draw): Return number of glyphs.
7886 (w32font_open_internal): Remove unused variable `i'.
7887 (w32font_driver): Add missing initializer.
7888
7889 * w32menu.c (utf8to16): Remove unused variable `utf16'.
7890 (fill_in_menu): Remove unused variable `items_added'.
7891
7892 * w32term.c (last_mouse_press_frame): Remove static global variable.
7893 (w32_clip_to_row): Remove unused variable `f'.
7894 (x_delete_terminal): Remove unused variable `i'.
7895
7896 * w32uniscribe.c (uniscribe_shape): Remove unused variable `nclusters'.
7897 (NOTHING): Remove unused static global variable.
7898 (uniscribe_check_otf): Remove unused variable `table'.
7899 (uniscribe_font_driver): Add missing initializers.
7900
7901 2011-03-23 Julien Danjou <julien@danjou.info>
7902
7903 * term.c (Fsuspend_tty, Fresume_tty):
7904 * minibuf.c (read_minibuf, run_exit_minibuf_hook):
7905 * window.c (temp_output_buffer_show):
7906 * insdel.c (signal_before_change):
7907 * frame.c (Fhandle_switch_frame):
7908 * fileio.c (Fdo_auto_save):
7909 * emacs.c (Fkill_emacs):
7910 * editfns.c (save_excursion_restore):
7911 * cmds.c (internal_self_insert):
7912 * callint.c (Fcall_interactively):
7913 * buffer.c (Fkill_all_local_variables):
7914 * keyboard.c (Fcommand_execute, Fsuspend_emacs, safe_run_hooks_1):
7915 Use Frun_hooks.
7916 (command_loop_1): Use Frun_hooks. Call safe_run_hooks
7917 unconditionally since it does the check itself.
7918
7919 2011-03-23 Paul Eggert <eggert@cs.ucla.edu>
7920
7921 Fix more problems found by GCC 4.5.2's static checks.
7922
7923 * coding.c (encode_coding_raw_text): Avoid unnecessary test
7924 the first time through the loop, since we know p0 < p1 then.
7925 This also avoids a gcc -Wstrict-overflow warning.
7926
7927 * lisp.h (SAFE_ALLOCA, SAFE_ALLOCA_LISP): Avoid 'int' overflow
7928 leading to a memory leak, possible in functions like
7929 load_charset_map_from_file that can allocate an unbounded number
7930 of objects (Bug#8318).
7931
7932 * xmenu.c (set_frame_menubar): Use EMACS_UINT, not int, for indexes
7933 that could (at least in theory) be that large.
7934
7935 * xdisp.c (message_log_check_duplicate): Return unsigned long, not int.
7936 This is less likely to overflow, and avoids undefined behavior if
7937 overflow does occur. All callers changed. Use strtoul to scan
7938 for the unsigned long integer.
7939 (pint2hrstr): Simplify and tune code slightly.
7940 This also avoids a (bogus) GCC warning with gcc -Wstrict-overflow.
7941
7942 * scroll.c (do_scrolling): Work around GCC bug 48228.
7943 See <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=48228>.
7944
7945 * frame.c (Fmodify_frame_parameters): Simplify loop counter.
7946 This also avoids a warning with gcc -Wstrict-overflow.
7947 (validate_x_resource_name): Simplify count usage.
7948 This also avoids a warning with gcc -Wstrict-overflow.
7949
7950 * fileio.c (Fcopy_file): Report error if fchown or fchmod
7951 fail (Bug#8306).
7952
7953 * emacs.c (Fdaemon_initialized): Do not ignore I/O errors (Bug#8303).
7954
7955 * process.c (Fmake_network_process): Use socklen_t, not int,
7956 where POSIX says socklen_t is required in portable programs.
7957 This fixes a porting bug on hosts like 64-bit HP-UX, where
7958 socklen_t is wider than int (Bug#8277).
7959 (Fmake_network_process, server_accept_connection):
7960 (wait_reading_process_output, read_process_output):
7961 Likewise.
7962
7963 * process.c: Rename or move locals to avoid shadowing.
7964 (list_processes_1, Fmake_network_process):
7965 (read_process_output_error_handler, exec_sentinel_error_handler):
7966 Rename or move locals.
7967 (Fmake_network_process): Define label "retry_connect" only if needed.
7968 (Fnetwork_interface_info): Fix pointer signedness.
7969 (process_send_signal): Add cast to avoid pointer signedness problem.
7970 (FIRST_PROC_DESC, IF_NON_BLOCKING_CONNECT): Remove unused macros.
7971 (create_process): Use 'volatile' to avoid vfork clobbering (Bug#8298).
7972
7973 Make tparam.h and terminfo.c consistent.
7974 * cm.c (tputs, tgoto, BC, UP): Remove extern decls.
7975 Include tparam.h instead, since it declares them.
7976 * cm.h (PC): Remove extern decl; tparam.h now does this.
7977 * deps.mk (cm.o, terminfo.o): Depend on tparam.h.
7978 * terminfo.c: Include tparam.h, to check interfaces.
7979 (tparm): Make 1st arg a const pointer in decl. Put it at top level.
7980 (tparam): Adjust signature to match interface in tparam.h;
7981 this removes some undefined behavior. Check that outstring and len
7982 are zero, which they always are with Emacs.
7983 * tparam.h (PC, BC, UP): New extern decls.
7984
7985 * xftfont.c (xftfont_shape): Now static, and defined only if needed.
7986 (xftfont_open): Rename locals to avoid shadowing.
7987
7988 * ftfont.c (ftfont_resolve_generic_family): Fix pointer signedness.
7989 (ftfont_otf_capability, ftfont_shape): Omit decls if not needed.
7990 (OTF_TAG_SYM): Omit macro if not needed.
7991 (ftfont_list): Remove unused local.
7992 (get_adstyle_property, ftfont_pattern_entity):
7993 (ftfont_lookup_cache, ftfont_open, ftfont_anchor_point):
7994 Rename locals to avoid shadowing.
7995
7996 * xfont.c (xfont_list_family): Mark var as initialized.
7997
7998 * xml.c (make_dom): Now static.
7999
8000 * composite.c (composition_compute_stop_pos): Rename local to
8001 avoid shadowing.
8002 (composition_reseat_it): Remove unused locals.
8003 (find_automatic_composition, composition_adjust_point): Likewise.
8004 (composition_update_it): Mark var as initialized.
8005 (find_automatic_composition): Mark vars as initialized,
8006 with a FIXME (Bug#8290).
8007
8008 character.h: Rename locals to avoid shadowing.
8009 * character.h (PREV_CHAR_BOUNDARY, FETCH_STRING_CHAR_ADVANCE):
8010 (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE, FETCH_CHAR_ADVANCE):
8011 (FETCH_CHAR_ADVANCE_NO_CHECK, INC_POS, DEC_POS, BUF_INC_POS):
8012 (BUF_DEC_POS): Be more systematic about renaming local temporaries
8013 to avoid shadowing.
8014
8015 * textprop.c (property_change_between_p): Remove; unused.
8016
8017 * intervals.c (interval_start_pos): Now static.
8018
8019 * intervals.h (CHECK_TOTAL_LENGTH): Avoid empty "else".
8020
8021 * atimer.c (start_atimer, append_atimer_lists, set_alarm):
8022 Rename locals to avoid shadowing.
8023
8024 * sound.c (wav_play, au_play, Fplay_sound_internal):
8025 Fix pointer signedness.
8026 (alsa_choose_format): Remove unused local var.
8027 (wav_play): Initialize a variable to 0, to prevent undefined
8028 behavior (Bug#8278).
8029
8030 * region-cache.c (insert_cache_boundary): Redo var to avoid shadowing.
8031
8032 * region-cache.h (pp_cache): New decl, for gcc -Wmissing-prototypes.
8033
8034 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork
8035 clobbering (Bug#8298).
8036 * sysdep.c (sys_subshell): Likewise.
8037 Previously, the sys_subshell 'volatile' was incorrectly IF_LINTted out.
8038
8039 * lisp.h (child_setup): Now NO_RETURN unless DOS_NT.
8040 This should get cleaned up, so that child_setup has the
8041 same signature on all platforms.
8042
8043 * callproc.c (call_process_cleanup): Now static.
8044 (relocate_fd): Rename locals to avoid shadowing.
8045
8046 2011-03-22 Chong Yidong <cyd@stupidchicken.com>
8047
8048 * xterm.c (x_clear_frame): Remove XClearWindow call. This appears
8049 not to be necessary, and produces flickering.
8050
8051 2011-03-20 Glenn Morris <rgm@gnu.org>
8052
8053 * config.in: Remove file.
8054
8055 2011-03-20 Juanma Barranquero <lekktu@gmail.com>
8056
8057 * minibuf.c (Vcompleting_read_function): Don't declare, global variables
8058 are now in src/globals.h.
8059 (syms_of_minibuf): Remove spurious & from previous change.
8060
8061 2011-03-20 Leo <sdl.web@gmail.com>
8062
8063 * minibuf.c (completing-read-function): New variable.
8064 (completing-read-default): Rename from completing-read.
8065 (completing-read): Call completing-read-function.
8066
8067 2011-03-19 Juanma Barranquero <lekktu@gmail.com>
8068
8069 * xfaces.c (Fx_load_color_file):
8070 Read color file from absolute filename (bug#8250).
8071
8072 2011-03-19 Juanma Barranquero <lekktu@gmail.com>
8073
8074 * makefile.w32-in: Update dependencies.
8075
8076 2011-03-17 Eli Zaretskii <eliz@gnu.org>
8077
8078 * makefile.w32-in ($(BLD)/unexw32.$(O)): Depend on $(SRC)/unexec.h.
8079
8080 2011-03-17 Paul Eggert <eggert@cs.ucla.edu>
8081
8082 Fix more problems found by GCC 4.5.2's static checks.
8083
8084 * process.c (make_serial_process_unwind, send_process_trap):
8085 (sigchld_handler): Now static.
8086
8087 * process.c (allocate_pty): Let PTY_ITERATION declare iteration vars.
8088 That way, the code declares only the vars that it needs.
8089 * s/aix4-2.h (PTY_ITERATION): Declare iteration vars.
8090 * s/cygwin.h (PTY_ITERATION): Likewise.
8091 * s/darwin.h (PTY_ITERATION): Likewise.
8092 * s/gnu-linux.h (PTY_ITERATION): Likewise.
8093
8094 * s/irix6-5.h (PTY_OPEN): Declare stb, to loosen coupling.
8095 * process.c (allocate_pty): Don't declare stb unless it's needed.
8096
8097 * bytecode.c (MAYBE_GC): Rewrite so as not to use empty "else".
8098 (CONSTANTLIM): Remove; unused.
8099 (METER_CODE, Bscan_buffer, Bread_char, Bset_mark):
8100 Define only if needed.
8101
8102 * unexelf.c (unexec): Name an expression,
8103 to avoid gcc -Wbad-function-cast warning.
8104 Use a different way to cause a compilation error if anyone uses
8105 n rather than nn, a way that does not involve shadowing.
8106 (ELF_BSS_SECTION_NAME, OLD_PROGRAM_H): Remove; unused.
8107
8108 * deps.mk (unexalpha.o): Remove; unused.
8109
8110 New file unexec.h, the (simple) interface for unexec (Bug#8267).
8111 * unexec.h: New file.
8112 * deps.mk (emacs.o, unexaix.o, unexcw.o, unexcoff.o, unexelf.o):
8113 (unexhp9k800.o, unexmacosx.o, unexsol.o, unexw32.o):
8114 Depend on unexec.h.
8115 * emacs.c [!defined CANNOT_DUMP]: Include unexec.h.
8116 * unexaix.c, unexcoff.c, unexcw.c, unexelf.c, unexhp9k800.c:
8117 * unexmacosx.c, unexsol.c, unexw32.c: Include unexec.h.
8118 Change as necessary to match prototype in unexec.h.
8119
8120 * syntax.c (Fforward_comment, scan_lists): Rename locals to avoid
8121 shadowing.
8122 (back_comment, skip_chars): Mark vars as initialized.
8123
8124 * character.h (FETCH_STRING_CHAR_ADVANCE_NO_CHECK, BUF_INC_POS):
8125 Rename locals to avoid shadowing.
8126
8127 * lread.c (read1): Rewrite so as not to use empty "else".
8128 (Fload, readevalloop, read1): Rename locals to avoid shadowing.
8129
8130 * print.c (Fredirect_debugging_output): Fix pointer signedess.
8131
8132 * lisp.h (debug_output_compilation_hack): Add decl here, to avoid
8133 warning when compiling print.c.
8134
8135 * font.c (font_unparse_fcname): Abort in an "impossible" situation
8136 instead of using an uninitialized var.
8137 (font_sort_entities): Mark var as initialized.
8138
8139 * character.h (FETCH_CHAR_ADVANCE): Rename locals to avoid shadowing.
8140
8141 * font.c (font_unparse_xlfd): Don't mix pointers to variables with
8142 pointers to constants.
8143 (font_parse_fcname): Remove unused vars.
8144 (font_delete_unmatched): Now static.
8145 (font_get_spec): Remove; unused.
8146 (font_style_to_value, font_prop_validate_style, font_unparse_fcname):
8147 (font_update_drivers, Ffont_get_glyphs, font_add_log):
8148 Rename or move locals to avoid shadowing.
8149
8150 * fns.c (require_nesting_list, require_unwind): Now static.
8151 (Ffillarray): Rename locals to avoid shadowing.
8152
8153 * floatfns.c (domain_error2): Define only if needed.
8154 (Ffrexp, Fldexp): Rename locals to avoid shadowing.
8155
8156 * alloc.c (mark_backtrace): Move decl from here ...
8157 * lisp.h: ... to here, so that it can be checked.
8158
8159 * eval.c (call_debugger, do_debug_on_call, grow_specpdl): Now static.
8160 (Fdefvar): Rewrite so as not to use empty "else".
8161 (lisp_indirect_variable): Name an expression,
8162 to avoid gcc -Wbad-function-cast warning.
8163 (Fdefvar): Rename locals to avoid shadowing.
8164
8165 * callint.c (quotify_arg, quotify_args): Now static.
8166 (Fcall_interactively): Rename locals to avoid shadowing.
8167 Use const pointer when appropriate.
8168
8169 * lisp.h (get_system_name, get_operating_system_release):
8170 Move decls here, to check interfaces.
8171 * process.c (get_operating_system_release): Move decl to lisp.h.
8172 * xrdb.c (get_system_name): Likewise.
8173 * editfns.c (init_editfns, Fuser_login_name, Fuser_uid):
8174 (Fuser_real_uid, Fuser_full_name): Remove unnecessary casts,
8175 some of which prompt warnings from gcc -Wbad-function-cast.
8176 (Fformat_time_string, Fencode_time, Finsert_char):
8177 (Ftranslate_region_internal, Fformat):
8178 Rename or remove local vars to avoid shadowing.
8179 (Ftranslate_region_internal): Mark var as initialized.
8180
8181 * doc.c (Fdocumentation, Fsnarf_documentation): Move locals to
8182 avoid shadowing.
8183
8184 * lisp.h (eassert): Check that the argument compiles, even if
8185 ENABLE_CHECKING is not defined.
8186
8187 * data.c (Findirect_variable): Name an expression, to avoid
8188 gcc -Wbad-function-cast warning.
8189 (default_value, arithcompare, arith_driver, arith_error): Now static.
8190 (store_symval_forwarding): Rename local to avoid shadowing.
8191 (Fmake_variable_buffer_local, Fmake_local_variable):
8192 Mark variables as initialized.
8193 (do_blv_forwarding, do_symval_forwarding): Remove; unused.
8194
8195 * alloc.c (check_cons_list): Do not define unless GC_CHECK_CONS_LIST.
8196 (Fmake_vector, Fvector, Fmake_byte_code, Fgarbage_collect):
8197 Rename locals to avoid shadowing.
8198 (mark_stack): Move local variables into the #ifdef region where
8199 they're used.
8200 (BLOCK_INPUT_ALLOC, UNBLOCK_INPUT_ALLOC): Define only if
8201 ! defined SYSTEM_MALLOC && ! defined SYNC_INPUT, as they are not
8202 needed otherwise.
8203 (CHECK_ALLOCATED): Define only if GC_CHECK_MARKED_OBJECTS.
8204 (GC_STRING_CHARS): Remove; not used.
8205 (Fmemory_limit): Cast sbrk's returned value to char *.
8206
8207 * lisp.h (check_cons_list): Declare if GC_CHECK_CONS_LIST; this
8208 avoids undefined behavior in theory.
8209
8210 * regex.c (IF_LINT): Add defn, for benefit of ../lib-src.
8211
8212 Use functions, not macros, for up- and down-casing (Bug#8254).
8213 * buffer.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
8214 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Remove. All callers changed
8215 to use the following functions instead of these macros.
8216 (downcase): Adjust to lack of DOWNCASE_TABLE. Return int, not
8217 EMACS_INT, since callers assume the returned value fits in int.
8218 (upcase1): Likewise, for UPCASE_TABLE.
8219 (uppercasep, lowercasep, upcase): New static inline functions.
8220 * editfns.c (Fchar_equal): Remove no-longer-needed workaround for
8221 the race-condition problem in the old DOWNCASE.
8222
8223 * regex.c (CHARSET_LOOKUP_RANGE_TABLE_RAW, POP_FAILURE_REG_OR_COUNT):
8224 Rename locals to avoid shadowing.
8225 (regex_compile, re_match_2_internal): Move locals to avoid shadowing.
8226 (regex_compile, re_search_2, re_match_2_internal):
8227 Remove unused local vars.
8228 (FREE_VAR): Rewrite so as not to use empty "else",
8229 which gcc can warn about.
8230 (regex_compile, re_match_2_internal): Mark locals as initialized.
8231 (RETALLOC_IF): Define only if needed.
8232 (WORDCHAR_P): Likewise. This one is never needed, but is used
8233 only in a comment talking about a compiler bug, so put inside
8234 the #if 0 of that comment.
8235 (CHARSET_LOOKUP_BITMAP, FAIL_STACK_FULL, RESET_FAIL_STACK):
8236 (PUSH_FAILURE_ELT, BUF_PUSH_3, STOP_ADDR_VSTRING):
8237 Remove; unused.
8238
8239 * search.c (boyer_moore): Rename locals to avoid shadowing.
8240 * character.h (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE):
8241 (PREV_CHAR_BOUNDARY): Likewise.
8242
8243 * search.c (simple_search): Remove unused var.
8244
8245 * dired.c (compile_pattern): Move decl from here ...
8246 * lisp.h: ... to here, so that it can be checked.
8247 (struct re_registers): New forward decl.
8248
8249 * character.h (INC_POS, DEC_POS): Rename locals to avoid shadowing.
8250
8251 * indent.c (MULTIBYTE_BYTES_WIDTH): New args bytes, width.
8252 All uses changed.
8253 (MULTIBYTE_BYTES_WIDTH, scan_for_column, compute_motion):
8254 Rename locals to avoid shadowing.
8255 (Fvertical_motion): Mark locals as initialized.
8256
8257 * casefiddle.c (casify_object, casify_region): Now static.
8258 (casify_region): Mark local as initialized.
8259
8260 * cmds.c (internal_self_insert): Rename local to avoid shadowing.
8261
8262 * lisp.h (GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR, GCPRO5_VAR, GCPRO6_VAR):
8263 New macros, so that the caller can use some names other than
8264 gcpro1, gcpro2, etc.
8265 (GCPRO2, GCPRO3, GCPRO4, GCPRO5, GCPRO6): Reimplement in terms
8266 of the new macros.
8267 (GCPRO1_VAR, UNGCPRO_VAR): Change the meaning of the second
8268 argument, for consistency with GCPRO2_VAR, etc: it is now the
8269 prefix of the variable, not the variable itself. All uses
8270 changed.
8271 * dired.c (directory_files_internal, file_name_completion):
8272 Rename locals to avoid shadowing.
8273
8274 Fix a race condition diagnosed by gcc -Wsequence-point (Bug#8254).
8275 An expression of the form (DOWNCASE (x) == DOWNCASE (y)), found in
8276 dired.c's scmp function, had undefined behavior.
8277 * lisp.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
8278 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Move from here ...
8279 * buffer.h: ... to here, because these macros use current_buffer,
8280 and the new implementation with inline functions needs to have
8281 current_buffer in scope now, rather than later when the macros
8282 are used.
8283 (downcase, upcase1): New static inline functions.
8284 (DOWNCASE, UPCASE1): Reimplement using these functions.
8285 This avoids undefined behavior in expressions like
8286 DOWNCASE (x) == DOWNCASE (y), which previously suffered
8287 from race conditions in accessing the global variables
8288 case_temp1 and case_temp2.
8289 * casetab.c (case_temp1, case_temp2): Remove; no longer needed.
8290 * lisp.h (case_temp1, case_temp2): Remove their decls.
8291 * character.h (ASCII_CHAR_P): Move from here ...
8292 * lisp.h: ... to here, so that the inline functions mentioned
8293 above can use them.
8294
8295 * dired.c (directory_files_internal_unwind): Now static.
8296
8297 * fileio.c (file_name_as_directory, directory_file_name):
8298 (barf_or_query_if_file_exists, auto_save_error, auto_save_1):
8299 Now static.
8300 (file_name_as_directory): Use const pointers when appropriate.
8301 (Fexpand_file_name): Likewise. In particular, newdir might
8302 point at constant storage, so make it a const pointer.
8303 (Fmake_directory_internal, Fread_file_name): Remove unused vars.
8304 (Ffile_selinux_context, Fset_file_selinux_context): Fix pointer
8305 signedness issues.
8306 (Fset_file_times, Finsert_file_contents, auto_save_error):
8307 Rename locals to avoid shadowing.
8308
8309 * minibuf.c (choose_minibuf_frame_1): Now static.
8310 (Ftry_completion, Fall_completions): Rename or remove locals
8311 to avoid shadowing.
8312
8313 * marker.c (bytepos_to_charpos): Remove; unused.
8314
8315 * lisp.h (verify_bytepos, count_markers): New decls,
8316 so that gcc does not warn that these functions aren't declared.
8317
8318 * insdel.c (check_markers, make_gap_larger, make_gap_smaller):
8319 (reset_var_on_error, Fcombine_after_change_execute_1): Now static.
8320 (CHECK_MARKERS): Redo to avoid gcc -Wempty-body diagnostic.
8321 (copy_text): Remove unused local var.
8322
8323 * filelock.c (within_one_second): Now static.
8324 (lock_file_1): Rename local to avoid shadowing.
8325
8326 * buffer.c (fix_overlays_before): Mark locals as initialized.
8327 (fix_start_end_in_overlays): Likewise. This function should be
8328 simplified by using pointers-to-pointers, but that's a different
8329 matter.
8330 (switch_to_buffer_1): Now static.
8331 (Fkill_buffer, record_buffer, Fbury_buffer, Fset_buffer_multibyte):
8332 (report_overlay_modification): Rename locals to avoid shadowing.
8333
8334 * sysdep.c (system_process_attributes): Rename vars to avoid shadowing.
8335 Fix pointer signedness issue.
8336 (sys_subshell): Mark local as volatile if checking for lint,
8337 to suppress a gcc -Wclobbered warning that does not seem to be right.
8338 (MAXPATHLEN): Define only if needed.
8339
8340 * process.c (serial_open, serial_configure): Move decls from here ...
8341 * systty.h: ... to here, so that they can be checked.
8342
8343 * fns.c (get_random, seed_random): Move extern decls from here ...
8344 * lisp.h: ... to here, so that they can be checked.
8345
8346 * sysdep.c (reset_io): Now static.
8347 (wait_for_termination_signal): Remove; unused.
8348
8349 * keymap.c (keymap_parent, keymap_memberp, map_keymap_internal):
8350 (copy_keymap_item, append_key, push_text_char_description):
8351 Now static.
8352 (Fwhere_is_internal): Don't test CONSP (sequences) unnecessarily.
8353 (DENSE_TABLE_SIZE): Remove; unused.
8354 (get_keymap, access_keymap, Fdefine_key, Fwhere_is_internal):
8355 (describe_map_tree):
8356 Rename locals to avoid shadowing.
8357
8358 * keyboard.c: Declare functions static if they are not used elsewhere.
8359 (echo_char, echo_dash, cmd_error, top_level_2):
8360 (poll_for_input, handle_async_input): Now static.
8361 (read_char, kbd_buffer_get_event, make_lispy_position):
8362 (make_lispy_event, make_lispy_movement, apply_modifiers):
8363 (decode_keyboard_code, tty_read_avail_input, menu_bar_items):
8364 (parse_tool_bar_item, read_key_sequence, Fread_key_sequence):
8365 (Fread_key_sequence_vector): Rename locals to avoid shadowing.
8366 (read_key_sequence, read_char): Mark locals as initialized.
8367 (Fexit_recursive_edit, Fabort_recursive_edit): Mark with NO_RETURN.
8368
8369 * keyboard.h (make_ctrl_char): New decl.
8370 (mark_kboards): Move decl here ...
8371 * alloc.c (mark_kboards): ... from here.
8372
8373 * lisp.h (force_auto_save_soon): New decl.
8374
8375 * emacs.c (init_cmdargs): Rename local to avoid shadowing.
8376 (DEFINE_DUMMY_FUNCTION): New macro.
8377 (__do_global_ctors, __do_global_ctors_aux, __do_global_dtors, __main):
8378 Use it.
8379 (main): Add casts to avoid warnings
8380 if GCC considers string literals to be constants.
8381
8382 * lisp.h (fatal_error_signal): Add decl, since it's exported.
8383
8384 * dbusbind.c: Pointer signedness fixes.
8385 (xd_signature, xd_append_arg, xd_initialize):
8386 (Fdbus_call_method, Fdbus_call_method_asynchronously):
8387 (Fdbus_method_return_internal, Fdbus_method_error_internal):
8388 (Fdbus_send_signal, xd_read_message_1, Fdbus_register_service):
8389 (Fdbus_register_signal): Use SSDATA when the context wants char *.
8390
8391 * dbusbind.c (Fdbus_init_bus): Add cast to avoid warning
8392 if GCC considers string literals to be constants.
8393 (Fdbus_register_service, Fdbus_register_method): Remove unused vars.
8394
8395 2011-03-16 Stefan Monnier <monnier@iro.umontreal.ca>
8396
8397 * print.c (PRINT_CIRCLE_CANDIDATE_P): New macro.
8398 (print_preprocess, print_object): New macro to fix last change.
8399
8400 * print.c (print_preprocess): Don't forget font objects.
8401
8402 2011-03-16 Juanma Barranquero <lekktu@gmail.com>
8403
8404 * emacs.c (USAGE3): Doc fixes.
8405
8406 2011-03-15 Andreas Schwab <schwab@linux-m68k.org>
8407
8408 * coding.c (detect_coding_iso_2022): Reorganize code to clarify
8409 structure.
8410
8411 2011-03-14 Juanma Barranquero <lekktu@gmail.com>
8412
8413 * lisp.h (VWindow_system, Qfile_name_history):
8414 * keyboard.h (lispy_function_keys) [WINDOWSNT]:
8415 * w32term.h (w32_system_caret_hwnd, w32_system_caret_height)
8416 (w32_system_caret_x, w32_system_caret_y): Declare extern.
8417
8418 * w32select.c: Don't #include "keyboard.h".
8419 (run_protected): Add extern declaration for waiting_for_input.
8420
8421 * w32.c (Qlocal, noninteractive1, inhibit_window_system):
8422 * w32console.c (detect_input_pending, read_input_pending)
8423 (encode_terminal_code):
8424 * w32fns.c (quit_char, lispy_function_keys, Qtooltip)
8425 (w32_system_caret_hwnd, w32_system_caret_height, w32_system_caret_x)
8426 (w32_system_caret_y, Qfile_name_history):
8427 * w32font.c (w32font_driver, QCantialias, QCotf, QClang):
8428 * w32inevt.c (reinvoke_input_signal, lispy_function_keys):
8429 * w32menu.c (Qmenu_bar, QCtoggle, QCradio, Qoverriding_local_map)
8430 (Qoverriding_terminal_local_map, Qmenu_bar_update_hook):
8431 * w32proc.c (Qlocal, report_file_error):
8432 * w32term.c (Vwindow_system, updating_frame):
8433 * w32uniscribe.c (initialized, uniscribe_font_driver):
8434 Remove unneeded extern declarations.
8435
8436 2011-03-14 Chong Yidong <cyd@stupidchicken.com>
8437
8438 * buffer.c (Fmake_indirect_buffer): Fix incorrect assertions.
8439
8440 2011-03-13 Chong Yidong <cyd@stupidchicken.com>
8441
8442 * buffer.h (BUF_BEGV, BUF_BEGV_BYTE, BUF_ZV, BUF_ZV_BYTE, BUF_PT)
8443 (BUF_PT_BYTE): Rewrite to handle indirect buffers (Bug#8219).
8444 These macros can no longer be used for assignment.
8445
8446 * buffer.c (Fget_buffer_create, Fmake_indirect_buffer):
8447 Assign struct members directly, instead of using BUF_BEGV etc.
8448 (record_buffer_markers, fetch_buffer_markers): New functions for
8449 recording and fetching special buffer markers.
8450 (set_buffer_internal_1, set_buffer_temp): Use them.
8451
8452 * lread.c (unreadchar): Use SET_BUF_PT_BOTH.
8453
8454 * insdel.c (adjust_point): Use SET_BUF_PT_BOTH.
8455
8456 * intervals.c (temp_set_point_both): Use SET_BUF_PT_BOTH.
8457 (get_local_map): Use SET_BUF_BEGV_BOTH and SET_BUF_ZV_BOTH.
8458
8459 * xdisp.c (hscroll_window_tree):
8460 (reconsider_clip_changes): Use PT instead of BUF_PT.
8461
8462 2011-03-13 Eli Zaretskii <eliz@gnu.org>
8463
8464 * makefile.w32-in ($(BLD)/editfns.$(O)): Depend on
8465 $(EMACS_ROOT)/lib/intprops.h.
8466
8467 2011-03-13 Paul Eggert <eggert@cs.ucla.edu>
8468
8469 Fix more problems found by GCC 4.5.2's static checks.
8470
8471 * gtkutil.c (xg_get_pixbuf_from_pixmap): Add cast from char *
8472 to unsigned char * to avoid compiler diagnostic.
8473 (xg_free_frame_widgets): Make it clear that a local variable is
8474 needed only if USE_GTK_TOOLTIP.
8475 (gdk_window_get_screen): Make it clear that this macro is needed
8476 only if USE_GTK_TOOLTIP.
8477 (int_gtk_range_get_value): New function, which avoids a diagnostic
8478 from gcc -Wbad-function-cast.
8479 (xg_set_toolkit_scroll_bar_thumb): Use it.
8480 (xg_tool_bar_callback, xg_tool_item_stale_p): Rewrite to avoid
8481 diagnostic from gcc -Wbad-function-cast.
8482 (get_utf8_string, xg_get_file_with_chooser):
8483 Rename locals to avoid shadowing.
8484 (create_dialog): Move locals to avoid shadowing.
8485
8486 * xgselect.c (xg_select): Remove unused var.
8487
8488 * image.c (four_corners_best): Mark locals as initialized.
8489 (gif_load): Initialize transparent_p to zero (Bug#8238).
8490 Mark another local as initialized.
8491 (my_png_error, my_error_exit): Mark with NO_RETURN.
8492
8493 * image.c (clear_image_cache): Now static.
8494 (DIM, HAVE_STDLIB_H_1): Remove unused macros.
8495 (xpm_load): Redo to avoid "discards qualifiers" gcc warning.
8496 (x_edge_detection): Remove unnecessary cast that
8497 gcc -Wbad-function-cast diagnoses.
8498 (gif_load): Fix pointer signedness.
8499 (clear_image_cache, xbm_read_bitmap_data, x_detect_edges):
8500 (jpeg_load, gif_load): Rename locals to avoid shadowing.
8501
8502 2011-03-12 Paul Eggert <eggert@cs.ucla.edu>
8503
8504 Improve quality of tests for time stamp overflow.
8505 For example, without this patch (encode-time 0 0 0 1 1
8506 1152921504606846976) returns the obviously-bogus value (-948597
8507 62170) on my RHEL 5.5 x86-64 host. With the patch, it correctly
8508 reports time overflow. See
8509 <http://lists.gnu.org/archive/html/emacs-devel/2011-03/msg00470.html>.
8510 * deps.mk (editfns.o): Depend on ../lib/intprops.h.
8511 * editfns.c: Include limits.h and intprops.h.
8512 (TIME_T_MIN, TIME_T_MAX): New macros.
8513 (time_overflow): Move earlier, to before first use.
8514 (hi_time, lo_time): New functions, for an accurate test for
8515 out-of-range times.
8516 (Fcurrent_time, Fget_internal_run_time, make_time): Use them.
8517 (Fget_internal_run_time): Don't assume time_t fits in int.
8518 (make_time): Use list2 instead of Fcons twice.
8519 (Fdecode_time): More accurate test for out-of-range times.
8520 (check_tm_member): New function.
8521 (Fencode_time): Use it, to test for out-of-range times.
8522 (lisp_time_argument): Don't rely on undefined left-shift and
8523 right-shift behavior when checking for time stamp overflow.
8524
8525 * editfns.c (time_overflow): New function, refactoring common code.
8526 (Fformat_time_string, Fdecode_time, Fencode_time):
8527 (Fcurrent_time_string): Use it.
8528
8529 Move 'make_time' to be next to its inverse 'lisp_time_argument'.
8530 * dired.c (make_time): Move to ...
8531 * editfns.c (make_time): ... here.
8532 * systime.h: Note the move.
8533
8534 2011-03-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
8535
8536 * fringe.c (update_window_fringes): Remove unused variables.
8537
8538 * unexmacosx.c (copy_data_segment): Also copy __got section.
8539 (Bug#8223)
8540
8541 2011-03-12 Eli Zaretskii <eliz@gnu.org>
8542
8543 * termcap.c [MSDOS]: Include "msdos.h".
8544 (find_capability, tgetnum, tgetflag, tgetstr, tputs, tgetent):
8545 Constify `char *' arguments and their references according to
8546 prototypes in tparam.h.
8547
8548 * deps.mk (termcap.o): Depend on tparam.h and msdos.h.
8549
8550 * msdos.c (XMenuAddPane): 3rd argument is `const char *' now.
8551 Adapt all references accordingly.
8552
8553 * msdos.h (XMenuAddPane): 3rd argument is `const char *' now.
8554
8555 2011-03-11 Tom Tromey <tromey@redhat.com>
8556
8557 * buffer.c (syms_of_buffer): Remove obsolete comment.
8558
8559 2011-03-11 Eli Zaretskii <eliz@gnu.org>
8560
8561 * termhooks.h (encode_terminal_code): Declare prototype.
8562
8563 * msdos.c (encode_terminal_code): Don't declare prototype.
8564
8565 * term.c (encode_terminal_code): Now external again, used by
8566 w32console.c and msdos.c.
8567
8568 * makefile.w32-in ($(BLD)/term.$(O), ($(BLD)/tparam.$(O)):
8569 Depend on $(SRC)/tparam.h, see 2011-03-11T07:24:21Z!eggert@cs.ucla.edu.
8570
8571 2011-03-11 Paul Eggert <eggert@cs.ucla.edu>
8572
8573 Fix some minor problems found by GCC 4.5.2's static checks.
8574
8575 * fringe.c (update_window_fringes): Mark locals as initialized
8576 (Bug#8227).
8577 (destroy_fringe_bitmap, init_fringe_bitmap): Now static.
8578
8579 * alloc.c (mark_fringe_data): Move decl from here ...
8580 * lisp.h (mark_fringe_data) [HAVE_WINDOW_SYSTEM]: ... to here,
8581 to check its interface.
8582 (init_fringe_once): Do not declare unless HAVE_WINDOW_SYSTEM.
8583
8584 * fontset.c (free_realized_fontset): Now static.
8585 (Fset_fontset_font): Rename local to avoid shadowing.
8586 (fontset_font): Mark local as initialized.
8587 (FONTSET_SPEC, FONTSET_REPERTORY, RFONT_DEF_REPERTORY): Remove; unused.
8588
8589 * xrdb.c: Include "xterm.h", to check x_load_resources's interface.
8590
8591 * xselect.c (x_disown_buffer_selections): Remove; not used.
8592 (TRACE3) [!defined TRACE_SELECTION]: Remove; not used.
8593 (x_own_selection, Fx_disown_selection_internal): Rename locals
8594 to avoid shadowing.
8595 (x_handle_dnd_message): Remove local to avoid shadowing.
8596
8597 * lisp.h (GCPRO1_VAR, UNGCPRO_VAR): New macros,
8598 so that the caller can use some name other than gcpro1.
8599 (GCPRO1, UNGCPRO): Reimplement in terms of the new macros.
8600 * xfns.c (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
8601 (Fx_backspace_delete_keys_p):
8602 Use them to avoid shadowing, and rename vars to avoid shadowing.
8603 (x_decode_color, x_set_name, x_window): Now static.
8604 (Fx_create_frame): Add braces to silence GCC warning.
8605 (Fx_file_dialog, Fx_select_font): Fix pointer signedness.
8606 (x_real_positions, xg_set_icon_from_xpm_data, x_create_tip_frame):
8607 Remove unused locals.
8608 (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
8609 (Fx_backspace_delete_keys_p): Rename locals to avoid shadowing.
8610 Some of these renamings use the new GCPRO1_VAR and UNGCPRO_VAR
8611 macros.
8612
8613 * xterm.h (x_mouse_leave): New decl.
8614
8615 * xterm.c (x_copy_dpy_color, x_focus_on_frame, x_unfocus_frame):
8616 Remove unused functions.
8617 (x_shift_glyphs_for_insert, XTflash, XTring_bell):
8618 (x_calc_absolute_position): Now static.
8619 (XTread_socket): Don't define label "out" unless it's used.
8620 Don't declare local "event" unless it's used.
8621 (x_iconify_frame, x_free_frame_resources): Don't declare locals
8622 unless they are used.
8623 (XEMBED_VERSION, xembed_set_info): Don't define unless needed.
8624 (x_fatal_error_signal): Remove; not used.
8625 (x_draw_image_foreground, redo_mouse_highlight, XTmouse_position):
8626 (x_scroll_bar_report_motion, handle_one_xevent, x_draw_bar_cursor):
8627 (x_error_catcher, x_connection_closed, x_error_handler):
8628 (x_error_quitter, xembed_send_message, x_iconify_frame):
8629 (my_log_handler): Rename locals to avoid shadowing.
8630 (x_delete_glyphs, x_ins_del_lines): Mark with NO_RETURN.
8631 (x_connection_closed): Tell GCC not to suggest NO_RETURN.
8632
8633 * xfaces.c (clear_face_cache, Fx_list_fonts, Fface_font):
8634 Rename or move locals to avoid shadowing.
8635 (tty_defined_color, merge_face_heights): Now static.
8636 (free_realized_faces_for_fontset): Remove; not used.
8637 (Fx_list_fonts): Mark variable that gcc -Wuninitialized
8638 does not deduce is never used uninitialized.
8639 (STRDUPA, LSTRDUPA, FONT_POINT_SIZE_QUANTUM): Remove; not used.
8640 (LFACEP): Define only if XASSERTS, as it's not needed otherwise.
8641
8642 * terminal.c (store_terminal_param): Now static.
8643
8644 * xmenu.c (menu_highlight_callback): Now static.
8645 (set_frame_menubar): Remove unused local.
8646 (xmenu_show): Rename parameter to avoid shadowing.
8647 (xmenu_show, xdialog_show, xmenu_show): Make local pointers "const"
8648 since they might point to immutable storage.
8649 (next_menubar_widget_id): Declare only if USE_X_TOOLKIT,
8650 since it's unused otherwise.
8651
8652 * xdisp.c (produce_glyphless_glyph): Initialize lower_xoff.
8653 Add a FIXME, since the code still doesn't look right. (Bug#8215)
8654 (Fcurrent_bidi_paragraph_direction): Simplify slightly; this
8655 avoids a gcc -Wuninitialized diagnostic.
8656 (display_line, BUILD_COMPOSITE_GLYPH_STRING, draw_glyphs):
8657 (note_mouse_highlight): Mark variables that gcc -Wuninitialized
8658 does not deduce are never used uninitialized.
8659
8660 * lisp.h (IF_LINT): New macro, copied from ../lib-src/emacsclient.c.
8661
8662 * xdisp.c (redisplay_window): Rename local to avoid shadowing.
8663 * window.c (window_loop, size_window):
8664 (run_window_configuration_change_hook, enlarge_window): Likewise.
8665
8666 * window.c (display_buffer): Now static.
8667 (size_window): Mark variables that gcc -Wuninitialized
8668 does not deduce are never used uninitialized.
8669 * window.h (check_all_windows): New decl, to forestall
8670 gcc -Wmissing-prototypes diagnostic.
8671 * dispextern.h (bidi_dump_cached_states): Likewise.
8672
8673 * charset.h (CHECK_CHARSET_GET_CHARSET): Rename locals to avoid
8674 shadowing.
8675 * charset.c (map_charset_for_dump, Fchar_charset): Likewise.
8676 Include <limits.h>.
8677 (Fsort_charsets): Redo min/max calculation to shorten the code a bit
8678 and to avoid gcc -Wuninitialized warning.
8679 (load_charset_map): Mark variables that gcc -Wuninitialized
8680 does not deduce are never used uninitialized.
8681 (load_charset): Abort instead of using uninitialized var (Bug#8229).
8682
8683 * coding.c (coding_set_source, coding_set_destination):
8684 Use "else { /* comment */ }" rather than "else /* comment */;"
8685 for clarity, and to avoid gcc -Wempty-body warning.
8686 (Fdefine_coding_system_internal): Don't redeclare 'i' inside
8687 a block, when the outer 'i' will do.
8688 (decode_coding_utf_8, decode_coding_utf_16, detect_coding_emacs_mule):
8689 (emacs_mule_char, decode_coding_emacs_mule, detect_coding_iso_2022):
8690 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5):
8691 (decode_coding_raw_text, decode_coding_charset, get_translation_table):
8692 (Fdecode_sjis_char, Fdefine_coding_system_internal):
8693 Rename locals to avoid shadowing.
8694 * character.h (FETCH_STRING_CHAR_ADVANCE): Likewise.
8695 * coding.c (emacs_mule_char, encode_invocation_designation):
8696 Now static, since they're not used elsewhere.
8697 (decode_coding_iso_2022): Add "default: abort ();" as a safety check.
8698 (decode_coding_object, encode_coding_object, detect_coding_system):
8699 (decode_coding_emacs_mule): Mark variables that gcc
8700 -Wuninitialized does not deduce are never used uninitialized.
8701 (detect_coding_iso_2022): Initialize a local variable that might
8702 be used uninitialized. Leave a FIXME because it's not clear that
8703 this initialization is needed. (Bug#8211)
8704 (ISO_CODE_LF, ISO_CODE_CR, CODING_ISO_FLAG_EUC_TW_SHIFT):
8705 (ONE_MORE_BYTE_NO_CHECK, UTF_BOM, UTF_16_INVALID_P):
8706 (SHIFT_OUT_OK, ENCODE_CONTROL_SEQUENCE_INTRODUCER):
8707 (ENCODE_DIRECTION_R2L, ENCODE_DIRECTION_L2R):
8708 Remove unused macros.
8709
8710 * category.c (hash_get_category_set): Remove unused local var.
8711 (copy_category_table): Now static, since it's not used elsewhere.
8712 * character.c (string_count_byte8): Likewise.
8713
8714 * ccl.c (CCL_WRITE_STRING, CCL_ENCODE_CHAR, Fccl_execute_on_string):
8715 (Fregister_code_conversion_map): Rename locals to avoid shadowing.
8716
8717 * chartab.c (copy_sub_char_table): Now static, since it's not used
8718 elsewhere.
8719 (sub_char_table_ref_and_range, char_table_ref_and_range):
8720 Rename locals to avoid shadowing.
8721 (ASET_RANGE, GET_SUB_CHAR_TABLE): Remove unused macros.
8722
8723 * bidi.c (bidi_check_type): Now static, since it's not used elsewhere.
8724 (BIDI_BOB): Remove unused macro.
8725
8726 * cm.c (cmgoto): Mark variables that gcc -Wuninitialized does not
8727 deduce are never used uninitialized.
8728 * term.c (encode_terminal_code): Likewise.
8729
8730 * term.c (encode_terminal_code): Now static. Remove unused local.
8731
8732 * tparam.h: New file.
8733 * term.c, tparam.h: Include it.
8734 * deps.mk (term.o, tparam.o): Depend on tparam.h.
8735 * term.c (tputs, tgetent, tgetflag, tgetnum, tparam, tgetstr):
8736 Move these decls to tparam.h, and make them agree with what
8737 is actually in tparam.c. The previous trick of using incompatible
8738 decls in different modules does not conform to the C standard.
8739 All callers of tparam changed to use tparam's actual API.
8740 * tparam.c (tparam1, tparam, tgoto):
8741 Use const pointers where appropriate.
8742
8743 * cm.c (calccost, cmgoto): Use const pointers where appropriate.
8744 * cm.h (struct cm): Likewise.
8745 * dispextern.h (do_line_insertion_deletion_costs): Likewise.
8746 * scroll.c (ins_del_costs, do_line_insertion_deletion_costs): Likewise.
8747 * term.c (tty_ins_del_lines, calculate_costs, struct fkey_table):
8748 (term_get_fkeys_1, append_glyphless_glyph, produce_glyphless_glyph):
8749 (turn_on_face, init_tty): Likewise.
8750 * termchar.h (struct tty_display_info): Likewise.
8751
8752 * term.c (term_mouse_position): Rename local to avoid shadowing.
8753
8754 * alloc.c (mark_ttys): Move decl from here ...
8755 * lisp.h (mark_ttys): ... to here, so that it's checked against defn.
8756
8757 2011-03-11 Andreas Schwab <schwab@linux-m68k.org>
8758
8759 * .gdbinit (pwinx, xbuffer): Fix access to buffer name.
8760
8761 2011-03-09 Juanma Barranquero <lekktu@gmail.com>
8762
8763 * search.c (compile_pattern_1): Remove argument regp, unused since
8764 revid:rms@gnu.org-19941211082627-3x1g1wyqkjmwloig.
8765 (compile_pattern): Don't pass it.
8766
8767 2011-03-08 Jan Djärv <jan.h.d@swipnet.se>
8768
8769 * xterm.h (DEFAULT_GDK_DISPLAY): New define.
8770 (GDK_WINDOW_XID, gtk_widget_get_preferred_size): New defines
8771 for ! HAVE_GTK3.
8772 (GTK_WIDGET_TO_X_WIN): Use GDK_WINDOW_XID.
8773
8774 * xmenu.c (menu_position_func): Call gtk_widget_get_preferred_size.
8775
8776 * gtkutil.c: Include gtkx.h if HAVE_GTK3. If ! HAVE_GTK3, define
8777 gdk_window_get_screen, gdk_window_get_geometry,
8778 gdk_x11_window_lookup_for_display and GDK_KEY_g.
8779 (xg_set_screen): Use DEFAULT_GDK_DISPLAY.
8780 (xg_get_pixbuf_from_pixmap): New function.
8781 (xg_get_pixbuf_from_pix_and_mask): Change parameters from GdkPixmap
8782 to Pixmap, take frame as parameter, remove GdkColormap parameter.
8783 Call xg_get_pixbuf_from_pixmap instead of
8784 gdk_pixbuf_get_from_drawable.
8785 (xg_get_image_for_pixmap): Do not make GdkPixmaps, call
8786 xg_get_pixbuf_from_pix_and_mask with Pixmap parameters instead.
8787 (xg_check_special_colors): Use GtkStyleContext and its functions
8788 for HAVE_GTK3.
8789 (xg_prepare_tooltip, xg_hide_tooltip): Call gdk_window_get_screen.
8790 (xg_prepare_tooltip, create_dialog, menubar_map_cb)
8791 (xg_update_frame_menubar, xg_tool_bar_detach_callback)
8792 (xg_tool_bar_attach_callback, xg_update_tool_bar_sizes):
8793 Call gtk_widget_get_preferred_size.
8794 (xg_frame_resized): gdk_window_get_geometry only takes 5
8795 parameters.
8796 (xg_win_to_widget, xg_event_is_for_menubar):
8797 Call gdk_x11_window_lookup_for_display.
8798 (xg_set_widget_bg): New function.
8799 (delete_cb): New function.
8800 (xg_create_frame_widgets): Connect delete-event to delete_cb.
8801 Call xg_set_widget_bg. Only set background pixmap for ! HAVE_GTK3
8802 (xg_set_background_color): Call xg_set_widget_bg.
8803 (xg_set_frame_icon): Call xg_get_pixbuf_from_pix_and_mask.
8804 (xg_create_scroll_bar): vadj is a GtkAdjustment for HAVE_GTK3.
8805 Only call gtk_range_set_update_policy if ! HAVE_GTK3.
8806 (xg_make_tool_item): Only connect xg_tool_bar_item_expose_callback
8807 if ! HAVE_GTK3.
8808 (update_frame_tool_bar): Call gtk_widget_hide.
8809 (xg_initialize): Use GDK_KEY_g.
8810
8811 * xsmfns.c (gdk_set_sm_client_id): Define to gdk_set_sm_client_id
8812 if ! HAVE_GTK3
8813 (x_session_initialize): Call gdk_x11_set_sm_client_id.
8814
8815 * xterm.c (XFillRectangle): Use cairo routines for HAVE_GTK3.
8816 (x_term_init): Disable Xinput(2) with GDK_CORE_DEVICE_EVENTS.
8817 Load ~/emacs.d/gtkrc only for ! HAVE_GTK3.
8818
8819 2011-03-08 Juanma Barranquero <lekktu@gmail.com>
8820
8821 * w32xfns.c (select_palette): Check success of RealizePalette against
8822 GDI_ERROR, not zero.
8823
8824 See ChangeLog.11 for earlier changes.
8825
8826 ;; Local Variables:
8827 ;; coding: utf-8
8828 ;; End:
8829
8830 Copyright (C) 2011 Free Software Foundation, Inc.
8831
8832 This file is part of GNU Emacs.
8833
8834 GNU Emacs is free software: you can redistribute it and/or modify
8835 it under the terms of the GNU General Public License as published by
8836 the Free Software Foundation, either version 3 of the License, or
8837 (at your option) any later version.
8838
8839 GNU Emacs is distributed in the hope that it will be useful,
8840 but WITHOUT ANY WARRANTY; without even the implied warranty of
8841 MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
8842 GNU General Public License for more details.
8843
8844 You should have received a copy of the GNU General Public License
8845 along with GNU Emacs. If not, see <http://www.gnu.org/licenses/>.