b05b3603c0db6b0a13c488ef6d49ab9004f94df2
[bpt/emacs.git] / src / ChangeLog
1 2011-06-07 Paul Eggert <eggert@cs.ucla.edu>
2
3 * character.c (string_escape_byte8): Fix nbytes/nchars typo.
4
5 * alloc.c (Fmake_string): Check for out-of-range init.
6
7 2011-06-07 Daniel Colascione <dan.colascione@gmail.com>
8
9 * fns.c (Fputhash): Document return value.
10
11 2011-06-06 Chong Yidong <cyd@stupidchicken.com>
12
13 * image.c (gif_load): Implement gif89a spec "no disposal" method.
14
15 2011-06-06 Paul Eggert <eggert@cs.ucla.edu>
16
17 Cons<->int and similar integer overflow fixes (Bug#8794).
18
19 Check for overflow when converting integer to cons and back.
20 * charset.c (Fdefine_charset_internal, Fdecode_char):
21 Use cons_to_unsigned to catch overflow.
22 (Fencode_char): Use INTEGER_TO_CONS.
23 * composite.h (LGLYPH_CODE): Use cons_to_unsigned.
24 (LGLYPH_SET_CODE): Use INTEGER_TO_CONS.
25 * data.c (long_to_cons, cons_to_long): Remove.
26 (cons_to_unsigned, cons_to_signed): New functions.
27 These signal an error for invalid or out-of-range values.
28 * dired.c (Ffile_attributes): Use INTEGER_TO_CONS.
29 * fileio.c (Fset_visited_file_modtime): Use CONS_TO_INTEGER.
30 * font.c (Ffont_variation_glyphs):
31 * fontset.c (Finternal_char_font): Use INTEGER_TO_CONS.
32 * lisp.h: Include <intprops.h>.
33 (INTEGER_TO_CONS, CONS_TO_INTEGER): New macros.
34 (cons_to_signed, cons_to_unsigned): New decls.
35 (long_to_cons, cons_to_long): Remove decls.
36 * undo.c (record_first_change): Use INTEGER_TO_CONS.
37 (Fprimitive_undo): Use CONS_TO_INTEGER.
38 * xfns.c (Fx_window_property): Likewise.
39 * xselect.c: Include <limits.h>.
40 (x_own_selection, selection_data_to_lisp_data):
41 Use INTEGER_TO_CONS.
42 (x_handle_selection_request, x_handle_selection_clear)
43 (x_get_foreign_selection, Fx_disown_selection_internal)
44 (Fx_get_atom_name, x_send_client_event): Use CONS_TO_INTEGER.
45 (lisp_data_to_selection_data): Use cons_to_unsigned.
46 (x_fill_property_data): Use cons_to_signed.
47 Report values out of range.
48
49 Check for buffer and string overflow more precisely.
50 * buffer.h (BUF_BYTES_MAX): New macro.
51 * lisp.h (STRING_BYTES_MAX): New macro.
52 * alloc.c (Fmake_string):
53 * character.c (string_escape_byte8):
54 * coding.c (coding_alloc_by_realloc):
55 * doprnt.c (doprnt):
56 * editfns.c (Fformat):
57 * eval.c (verror):
58 Use STRING_BYTES_MAX, not MOST_POSITIVE_FIXNUM,
59 since they may not be the same number.
60 * editfns.c (Finsert_char):
61 * fileio.c (Finsert_file_contents):
62 Likewise for BUF_BYTES_MAX.
63
64 * image.c: Use ptrdiff_t, not int, for sizes.
65 (slurp_file): Switch from int to ptrdiff_t.
66 All uses changed.
67 (slurp_file): Check that file size fits in both size_t (for
68 malloc) and ptrdiff_t (for sanity and safety).
69
70 * fileio.c (Fverify_visited_file_modtime): Avoid time overflow
71 if b->modtime has its maximal value.
72
73 * dired.c (Ffile_attributes): Don't assume EMACS_INT has >32 bits.
74
75 Don't assume time_t can fit into int.
76 * buffer.h (struct buffer.modtime): Now time_t, not int.
77 * fileio.c (Fvisited_file_modtime): No need for time_t cast now.
78 * undo.c (Fprimitive_undo): Use time_t, not int, for time_t value.
79
80 Minor fixes for signed vs unsigned integers.
81 * character.h (MAYBE_UNIFY_CHAR):
82 * charset.c (maybe_unify_char):
83 * keyboard.c (read_char, reorder_modifiers):
84 XINT -> XFASTINT, since the integer must be nonnegative.
85 * ftfont.c (ftfont_spec_pattern):
86 * keymap.c (access_keymap, silly_event_symbol_error):
87 XUINT -> XFASTINT, since the integer must be nonnegative.
88 (Fsingle_key_description, preferred_sequence_p): XUINT -> XINT,
89 since it makes no difference and we prefer signed.
90 * keyboard.c (record_char): Use XUINT when all the neighbors do.
91 (access_keymap): NATNUMP -> INTEGERP, since the integer must be
92 nonnegative.
93
94 2011-06-06 Stefan Monnier <monnier@iro.umontreal.ca>
95
96 * window.h (Fwindow_frame): Declare.
97
98 2011-06-06 Paul Eggert <eggert@cs.ucla.edu>
99
100 * alloc.c: Simplify handling of large-request failures (Bug#8800).
101 (SPARE_MEMORY): Always define.
102 (LARGE_REQUEST): Remove.
103 (memory_full): Use SPARE_MEMORY rather than LARGE_REQUEST.
104
105 2011-06-06 Martin Rudalics <rudalics@gmx.at>
106
107 * lisp.h: Move EXFUNS for Fframe_root_window,
108 Fframe_first_window and Fset_frame_selected_window to window.h.
109
110 * window.h: Move EXFUNS for Fframe_root_window,
111 Fframe_first_window and Fset_frame_selected_window here from
112 lisp.h.
113
114 * frame.c (Fwindow_frame, Fframe_first_window)
115 (Fframe_root_window, Fframe_selected_window)
116 (Fset_frame_selected_window): Move to window.c.
117 (Factive_minibuffer_window): Move to minibuf.c.
118 (Fother_visible_frames_p): New function.
119
120 * minibuf.c (Factive_minibuffer_window): Move here from frame.c.
121
122 * window.c (decode_window, decode_any_window): Move up in code.
123 (Fwindowp, Fwindow_live_p): Rewrite doc-strings.
124 (inhibit_frame_unsplittable): Remove unused variable.
125 (Fwindow_buffer): Move up and rewrite doc-string.
126 (Fwindow_parent, Fwindow_vchild, Fwindow_hchild, Fwindow_next)
127 (Fwindow_prev): New functions.
128 (Fwindow_frame): Move here from frame.c. Accept any window as
129 argument.
130 (Fframe_root_window, Fframe_first_window)
131 (Fframe_selected_window): Move here from frame.c. Accept frame
132 or arbitrary window as argument. Update doc-strings.
133 (Fminibuffer_window): Move up in code.
134 (Fwindow_minibuffer_p): Move up in code and simplify.
135 (Fset_frame_selected_window): Move here from frame.c.
136 Marginal rewrite.
137 (Fselected_window, select_window, Fselect_window): Move up in
138 code. Minor doc-string fixes.
139
140 2011-06-06 Paul Eggert <eggert@cs.ucla.edu>
141
142 * alloc.c (memory_full) [SYSTEM_MALLOC]: Port to MacOS (Bug#8800).
143 Do not assume that spare memory exists; that assumption is valid
144 only if SYSTEM_MALLOC.
145 (LARGE_REQUEST): New macro, so that the issue of large requests
146 is separated from the issue of spare memory.
147
148 2011-06-05 Andreas Schwab <schwab@linux-m68k.org>
149
150 * editfns.c (Fformat): Correctly handle zero flag with hexadecimal
151 format. (Bug#8806)
152
153 * gtkutil.c (xg_get_default_scrollbar_width): Avoid warning.
154
155 * xfns.c (x_set_scroll_bar_default_width): Move declarations
156 before statements.
157
158 2011-06-05 Jan Djärv <jan.h.d@swipnet.se>
159
160 * gtkutil.c (xg_get_default_scrollbar_width): New function.
161
162 * gtkutil.h: Declare xg_get_default_scrollbar_width.
163
164 * xfns.c (x_set_scroll_bar_default_width): If USE_GTK, get
165 min width by calling x_set_scroll_bar_default_width (Bug#8505).
166
167 2011-06-05 Juanma Barranquero <lekktu@gmail.com>
168
169 * xdisp.c (single_display_spec_intangible_p): Remove declaration.
170
171 2011-06-04 Chong Yidong <cyd@stupidchicken.com>
172
173 * xselect.c (x_clipboard_manager_save): Remove redundant arg.
174 (x_clipboard_manager_save): Add return value.
175 (x_clipboard_manager_error_1, x_clipboard_manager_error_2):
176 New error handlers.
177 (x_clipboard_manager_save_frame, x_clipboard_manager_save_all):
178 Obey Vx_select_enable_clipboard_manager. Catch errors in
179 x_clipboard_manager_save (Bug#8779).
180 (Vx_select_enable_clipboard_manager): New variable.
181 (x_get_foreign_selection): Reduce scope of x_catch_errors (Bug#8790).
182
183 2011-06-04 Dan Nicolaescu <dann@ics.uci.edu>
184
185 * emacs.c (main): Warn when starting a GTK emacs in daemon mode.
186
187 2011-06-04 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
188
189 * fringe.c (update_window_fringes): Don't update overlay arrow bitmap
190 in the current matrix if keep_current_p is non-zero.
191
192 2011-06-04 Eli Zaretskii <eliz@gnu.org>
193
194 * bidi.c (bidi_level_of_next_char): Fix last change.
195
196 2011-06-03 Eli Zaretskii <eliz@gnu.org>
197
198 Support bidi reordering of text covered by display properties.
199
200 * bidi.c (bidi_copy_it): Use offsetof instead of emulating it.
201 (bidi_fetch_char, bidi_fetch_char_advance): New functions.
202 (bidi_cache_search, bidi_cache_iterator_state)
203 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak)
204 (bidi_level_of_next_char, bidi_move_to_visually_next):
205 Support character positions inside a run of characters covered by a
206 display string.
207 (bidi_paragraph_init, bidi_resolve_explicit_1)
208 (bidi_level_of_next_char): Call bidi_fetch_char and
209 bidi_fetch_char_advance instead of FETCH_CHAR and
210 FETCH_CHAR_ADVANCE.
211 (bidi_init_it): Initialize new members.
212 (LRE_CHAR, RLE_CHAR, PDF_CHAR, LRO_CHAR, RLO_CHAR): Remove macro
213 definitions.
214 (bidi_explicit_dir_char): Lookup character type in bidi_type_table,
215 instead of using explicit *_CHAR codes.
216 (bidi_resolve_explicit, bidi_resolve_weak):
217 Use FETCH_MULTIBYTE_CHAR instead of FETCH_CHAR, as reordering of
218 bidirectional text is supported only in multibyte buffers.
219 (bidi_init_it): Accept additional argument FRAME_WINDOW_P and use
220 it to initialize the frame_window_p member of struct bidi_it.
221 (bidi_cache_iterator_state, bidi_resolve_explicit_1)
222 (bidi_resolve_explicit, bidi_resolve_weak)
223 (bidi_level_of_next_char, bidi_move_to_visually_next): Abort if
224 bidi_it->nchars is non-positive.
225 (bidi_level_of_next_char): Don't try to lookup the cache for the
226 next/previous character if nothing is cached there yet, or if we
227 were just reseat()'ed to a new position.
228
229 * xdisp.c (set_cursor_from_row): Set start and stop points
230 according to the row's direction when priming the loop that looks
231 for the glyph on which to display cursor.
232 (single_display_spec_intangible_p): Function deleted.
233 (display_prop_intangible_p): Reimplement to call
234 handle_display_spec instead of single_display_spec_intangible_p.
235 Accept 3 additional arguments needed by handle_display_spec.
236 This fixes incorrect cursor motion across display property with complex
237 values: lists, `(when COND...)' forms, etc.
238 (single_display_spec_string_p): Support property values that are
239 lists with the argument STRING its top-level element.
240 (display_prop_string_p): Fix the condition for processing a
241 property that is a list to be consistent with handle_display_spec.
242 (handle_display_spec): New function, refactored from the
243 last portion of handle_display_prop.
244 (compute_display_string_pos): Accept additional argument
245 FRAME_WINDOW_P. Call handle_display_spec to determine whether the
246 value of a `display' property is a "replacing spec".
247 (handle_single_display_spec): Accept 2 additional arguments BUFPOS
248 and FRAME_WINDOW_P. If IT is NULL, don't set up the iterator from
249 the display property, but just return a value indicating whether
250 the display property will replace the characters it covers.
251 (Fcurrent_bidi_paragraph_direction): Initialize the nchars and
252 frame_window_p members of struct bidi_it.
253 (compute_display_string_pos, compute_display_string_end):
254 New functions.
255 (push_it): Accept second argument POSITION, where pop_it should
256 jump to continue iteration.
257 (reseat_1): Initialize bidi_it.disp_pos.
258
259 * keyboard.c (adjust_point_for_property): Adjust the call to
260 display_prop_intangible_p to its new signature.
261
262 * dispextern.h (struct bidi_it): New member frame_window_p.
263 (bidi_init_it): Update prototypes.
264 (display_prop_intangible_p): Update prototype.
265 (compute_display_string_pos, compute_display_string_end):
266 Declare prototypes.
267 (struct bidi_it): New members nchars and disp_pos. ch_len is now
268 EMACS_INT.
269
270 2011-06-02 Paul Eggert <eggert@cs.ucla.edu>
271
272 Malloc failure behavior now depends on size of allocation.
273 * alloc.c (buffer_memory_full, memory_full): New arg NBYTES.
274 * lisp.h: Change signatures accordingly.
275 * alloc.c, buffer.c, editfns.c, menu.c, minibuf.c, xterm.c:
276 All callers changed. (Bug#8762)
277
278 * gnutls.c: Use Emacs's memory allocators.
279 Without this change, the gnutls library would invoke malloc etc.
280 directly, which causes problems on non-SYNC_INPUT hosts, and which
281 runs afoul of improving memory_full behavior. (Bug#8761)
282 (fn_gnutls_global_set_mem_functions): New macro or function pointer.
283 (emacs_gnutls_global_init): Use it to specify xmalloc, xrealloc,
284 xfree instead of the default malloc, realloc, free.
285 (Fgnutls_boot): No need to check for memory allocation failure,
286 since xmalloc does that for us.
287
288 Remove arbitrary limit of 2**31 entries in hash tables. (Bug#8771)
289 * category.c (hash_get_category_set):
290 * ccl.c (ccl_driver):
291 * charset.c (Fdefine_charset_internal):
292 * charset.h (struct charset.hash_index):
293 * composite.c (get_composition_id, gstring_lookup_cache)
294 (composition_gstring_put_cache):
295 * composite.h (struct composition.hash_index):
296 * dispextern.h (struct image.hash):
297 * fns.c (next_almost_prime, larger_vector, cmpfn_eql)
298 (cmpfn_equal, cmpfn_user_defined, hashfn_eq, hashfn_eql)
299 (hashfn_equal, hashfn_user_defined, make_hash_table)
300 (maybe_resize_hash_table, hash_lookup, hash_put)
301 (hash_remove_from_table, hash_clear, sweep_weak_table, SXHASH_COMBINE)
302 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector)
303 (Fsxhash, Fgethash, Fputhash, Fmaphash):
304 * image.c (make_image, search_image_cache, lookup_image)
305 (xpm_put_color_table_h):
306 * lisp.h (struct Lisp_Hash_Table):
307 * minibuf.c (Ftry_completion, Fall_completions, Ftest_completion):
308 * print.c (print): Use 'EMACS_UINT' and 'EMACS_INT'
309 for hashes and hash indexes, instead of 'unsigned' and 'int'.
310 * alloc.c (allocate_vectorlike):
311 Check for overflow in vector size calculations.
312 * ccl.c (ccl_driver):
313 Check for overflow when converting EMACS_INT to int.
314 * fns.c, image.c: Remove unnecessary static decls that would otherwise
315 need to be updated by these changes.
316 * fns.c (make_hash_table, maybe_resize_hash_table):
317 Check for integer overflow with large hash tables.
318 (make_hash_table, maybe_resize_hash_table, Fmake_hash_table):
319 Prefer the faster XFLOAT_DATA to XFLOATINT where either will do.
320 (SXHASH_REDUCE): New macro.
321 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector):
322 Use it instead of discarding useful hash info with large hash values.
323 (sxhash_float): New function.
324 (sxhash): Use it. No more need for "& INTMASK" due to above changes.
325 * lisp.h (FIXNUM_BITS): New macro, useful for SXHASH_REDUCE etc.
326 (MOST_NEGATIVE_FIXNUM, MOST_POSITIVE_FIXNUM, INTMASK):
327 Rewrite to use FIXNUM_BITS, as this simplifies things.
328 (next_almost_prime, larger_vector, sxhash, hash_lookup, hash_put):
329 Adjust signatures to match updated version of code.
330 (consing_since_gc): Now EMACS_INT, since a single hash table can
331 use more than INT_MAX bytes.
332
333 2011-06-01 Dan Nicolaescu <dann@ics.uci.edu>
334
335 Make it possible to build with GCC-4.6+ -O2 -flto.
336
337 * emacs.c (__malloc_initialize_hook): Mark as EXTERNALLY_VISIBLE.
338
339 2011-06-01 Stefan Monnier <monnier@iro.umontreal.ca>
340
341 * minibuf.c (get_minibuffer, read_minibuf_unwind):
342 Call minibuffer-inactive-mode.
343
344 2011-05-31 Juanma Barranquero <lekktu@gmail.com>
345
346 * makefile.w32-in ($(BLD)/data.$(O), $(BLD)/editfns.$(O)):
347 Update dependencies.
348
349 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
350
351 * data.c (init_data): Remove code for UTS, this system is not
352 supported anymore.
353
354 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
355
356 Don't force ./temacs to start in terminal mode.
357
358 * frame.c (make_initial_frame): Initialize faces in all cases, not
359 only when CANNOT_DUMP is defined.
360 * dispnew.c (init_display): Remove CANNOT_DUMP condition.
361
362 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
363
364 * dispnew.c (add_window_display_history): Use const for the string
365 pointer. Remove declaration, not needed.
366
367 2011-05-31 Paul Eggert <eggert@cs.ucla.edu>
368
369 Use 'inline', not 'INLINE'.
370 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00914.html>
371 * alloc.c, fontset.c (INLINE): Remove.
372 * alloc.c, bidi.c, charset.c, coding.c, dispnew.c, fns.c, image.c:
373 * intervals.c, keyboard.c, process.c, syntax.c, textprop.c, w32term.c:
374 * xdisp.c, xfaces.c, xterm.c: Replace all uses of INLINE with inline.
375 * gmalloc.c (register_heapinfo): Use inline unconditionally.
376 * lisp.h (LISP_MAKE_RVALUE): Use inline, not __inline__.
377
378 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
379
380 Make it possible to run ./temacs.
381
382 * callproc.c (set_initial_environment): Remove CANNOT_DUMP code,
383 syms_of_callproc does the same thing. Remove test for
384 "initialized", do it in the caller.
385 * emacs.c (main): Avoid calling set_initial_environment when dumping.
386
387 2011-05-31 Stefan Monnier <monnier@iro.umontreal.ca>
388
389 * minibuf.c (Finternal_complete_buffer): Return `category' metadata.
390 (read_minibuf): Use get_minibuffer.
391 (syms_of_minibuf): Use DEFSYM.
392 (Qmetadata): New var.
393 * data.c (Qbuffer): Don't make it static.
394 (syms_of_data): Use DEFSYM.
395
396 2011-05-31 Paul Eggert <eggert@cs.ucla.edu>
397
398 * ccl.c (CCL_CODE_RANGE): Allow negative numbers. (Bug#8751)
399 (CCL_CODE_MIN): New macro.
400
401 2011-05-30 Paul Eggert <eggert@cs.ucla.edu>
402
403 * alloc.c (lisp_align_malloc): Omit unnecessary val==NULL tests.
404
405 * eval.c (Qdebug): Now static.
406 * lisp.h (Qdebug): Remove decl. This reverts a part of the
407 2011-04-26T11:26:05Z!dan.colascione@gmail.com that inadvertently undid part of
408 2011-04-14T06:48:41Z!eggert@cs.ucla.edu.
409
410 2011-05-29 Chong Yidong <cyd@stupidchicken.com>
411
412 * image.c: Various fixes to ImageMagick code comments.
413 (Fimagemagick_types): Doc fix.
414
415 2011-05-29 Paul Eggert <eggert@cs.ucla.edu>
416
417 Minor fixes prompted by GCC 4.6.0 warnings.
418
419 * xselect.c (converted_selections, conversion_fail_tag): Now static.
420
421 * emacs.c [HAVE_X_WINDOWS]: Include "xterm.h".
422 (x_clipboard_manager_save_all): Move extern decl to ...
423 * xterm.h: ... here, so that it can be checked for consistency.
424
425 2011-05-29 Chong Yidong <cyd@stupidchicken.com>
426
427 * xselect.c (x_clipboard_manager_save_frame)
428 (x_clipboard_manager_save_all): New functions.
429 (Fx_clipboard_manager_save): Lisp function deleted.
430
431 * emacs.c (Fkill_emacs): Call x_clipboard_manager_save_all.
432 * frame.c (delete_frame): Call x_clipboard_manager_save_frame.
433
434 * xterm.h: Update prototype.
435
436 2011-05-28 William Xu <william.xwl@gmail.com>
437
438 * nsterm.m (ns_term_shutdown): Synchronize user defaults before
439 exiting (Bug#8239).
440
441 2011-05-28 Jim Meyering <meyering@redhat.com>
442
443 Avoid a sign-extension bug in crypto_hash_function.
444 * fns.c (to_uchar): Define.
445 (crypto_hash_function): Use it to convert some newly-signed
446 variables to unsigned, to avoid sign-extension bugs. For example,
447 without this change, (md5 "truc") would evaluate to
448 45723a2aff78ff4fff7fff1114760e62 rather than the expected
449 45723a2af3788c4ff17f8d1114760e62. Reported by Antoine Levitt in
450 https://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00883.html.
451
452 2011-05-27 Paul Eggert <eggert@cs.ucla.edu>
453
454 Integer overflow fixes.
455
456 * dbusbind.c: Serial number integer overflow fixes.
457 (CHECK_DBUS_SERIAL_GET_SERIAL): New macro.
458 (Fdbus_call_method_asynchronously, xd_read_message_1): Use a float
459 to hold a serial number that is too large for a fixnum.
460 (Fdbus_method_return_internal, Fdbus_method_error_internal):
461 Check for serial numbers out of range. Decode any serial number
462 that was so large that it became a float. (Bug#8722)
463
464 * dbusbind.c: Use XFASTINT rather than XUINT, and check for nonneg.
465 (Fdbus_call_method, Fdbus_call_method_asynchronously):
466 Use XFASTINT rather than XUINT when numbers are nonnegative.
467 (xd_append_arg, Fdbus_method_return_internal):
468 (Fdbus_method_error_internal): Likewise. Also, for unsigned
469 arguments, check that Lisp number is nonnegative, rather than
470 silently wrapping negative numbers around. (Bug#8722)
471 (xd_read_message_1): Don't assume dbus_uint32_t can fit in int.
472 (Bug#8722)
473
474 * data.c (arith_driver, Flsh): Avoid unnecessary casts to EMACS_UINT.
475
476 * ccl.c (ccl_driver): Redo slightly to avoid the need for 'unsigned'.
477
478 ccl: add integer overflow checks
479 * ccl.c (CCL_CODE_MAX, GET_CCL_RANGE, GET_CCL_CODE, GET_CCL_INT):
480 (IN_INT_RANGE): New macros.
481 (ccl_driver): Use them to check for integer overflow when
482 decoding a CCL program. Many of the new checks are whether XINT (x)
483 fits in int; it doesn't always, on 64-bit hosts. The new version
484 doesn't catch all possible integer overflows, but it's an
485 improvement. (Bug#8719)
486
487 * alloc.c (make_event_array): Use XINT, not XUINT.
488 There's no need for unsigned here.
489
490 * mem-limits.h (EXCEEDS_LISP_PTR) [!USE_LSB_TAG]: EMACS_UINT -> uintptr_t
491 This follows up to the 2011-05-06 change that substituted uintptr_t
492 for EMACS_INT. This case wasn't caught back then.
493
494 Rework Fformat to avoid integer overflow issues.
495 * editfns.c: Include <float.h> unconditionally, as it's everywhere
496 now (part of C89). Include <verify.h>.
497 (MAX_10_EXP, CONVERTED_BYTE_SIZE): Remove; no longer needed.
498 (pWIDE, pWIDElen, signed_wide, unsigned_wide): New defns.
499 (Fformat): Avoid the prepass trying to compute sizes; it was only
500 approximate and thus did not catch overflow reliably. Instead, walk
501 through the format just once, formatting and computing sizes as we go,
502 checking for integer overflow at every step, and allocating a larger
503 buffer as needed. Keep track separately whether the format is
504 multibyte. Keep only the most-recently calculated precision, rather
505 than them all. Record whether each argument has been converted to
506 string. Use EMACS_INT, not int, for byte and char and arg counts.
507 Support field widths and precisions larger than INT_MAX. Avoid
508 sprintf's undefined behavior with conversion specifications such as %#d
509 and %.0c. Fix bug with strchr succeeding on '\0' when looking for
510 flags. Fix bug with (format "%c" 256.0). Avoid integer overflow when
511 formatting out-of-range floating point numbers with int
512 formats. (Bug#8668)
513
514 * lisp.h (FIXNUM_OVERFLOW_P): Work even if arg is a NaN.
515
516 * data.c: Avoid integer truncation in expressions involving floats.
517 * data.c: Include <intprops.h>.
518 (arith_driver): When there's an integer overflow in an expression
519 involving floating point, convert the integers to floating point
520 so that the resulting value does not suffer from catastrophic
521 integer truncation. For example, on a 64-bit host (* 4
522 most-negative-fixnum 0.5) should yield about -4.6e+18, not zero.
523 Do not rely on undefined behavior after integer overflow.
524
525 merge count_size_as_multibyte, parse_str_to_multibyte
526 * character.c, character.h (count_size_as_multibyte):
527 Rename from parse_str_to_multibyte; all uses changed.
528 Check for integer overflow.
529 * insdel.c, lisp.h (count_size_as_multibyte): Remove,
530 since it's now a duplicate of the other. This is more of
531 a character than a buffer op, so better that it's in character.c.
532 * fns.c, print.c: Adjust to above changes.
533
534 2011-05-27 Stefan Monnier <monnier@iro.umontreal.ca>
535
536 * xselect.c (x_convert_selection): Yet another int/Lisp_Object mixup.
537
538 2011-05-27 Paul Eggert <eggert@cs.ucla.edu>
539
540 * xselect.c: Fix minor problems prompted by GCC 4.6.0 warnings.
541 (x_handle_selection_request, frame_for_x_selection): Remove unused vars.
542 (x_clipboard_manager_save): Now static.
543 (Fx_clipboard_manager_save): Rename local to avoid shadowing.
544
545 * fns.c: Fix minor problems prompted by GCC 4.6.0 warnings.
546 (crypto_hash_function): Now static.
547 Fix pointer signedness problems. Avoid unnecessary initializations.
548
549 2011-05-27 Chong Yidong <cyd@stupidchicken.com>
550
551 * termhooks.h (Vselection_alist): Make it terminal-local.
552
553 * terminal.c (create_terminal): Initialize it.
554
555 * xselect.c: Support for clipboard managers.
556 (Vselection_alist): Move to termhooks.h as terminal-local var.
557 (LOCAL_SELECTION): New macro.
558 (x_atom_to_symbol): Handle x_display_info_for_display fail case.
559 (symbol_to_x_atom): Remove gratuitous arg.
560 (x_handle_selection_request, lisp_data_to_selection_data)
561 (x_get_foreign_selection, Fx_register_dnd_atom): Callers changed.
562 (x_own_selection, x_get_local_selection, x_convert_selection):
563 New arg, specifying work frame. Use terminal-local Vselection_alist.
564 (some_frame_on_display): Delete unused function.
565 (Fx_own_selection_internal, Fx_get_selection_internal)
566 (Fx_disown_selection_internal, Fx_selection_owner_p)
567 (Fx_selection_exists_p): New optional frame arg.
568 (frame_for_x_selection, Fx_clipboard_manager_save): New functions.
569 (x_handle_selection_clear): Don't treat other terminals with the
570 same keyboard specially. Use the terminal-local Vselection_alist.
571 (x_clear_frame_selections): Use Frun_hook_with_args.
572
573 * xterm.c (x_term_init): Intern ATOM and CLIPBOARD_MANAGER atoms.
574
575 * xterm.h: Add support for those atoms.
576
577 2011-05-26 Chong Yidong <cyd@stupidchicken.com>
578
579 * xselect.c: ICCCM-compliant handling of MULTIPLE targets.
580 (converted_selections, conversion_fail_tag): New global variables.
581 (x_selection_request_lisp_error): Free the above.
582 (x_get_local_selection): Remove unnecessary code.
583 (x_reply_selection_request): Args changed; handle arbitrary array
584 of converted selections stored in converted_selections.
585 Separate the XChangeProperty and SelectionNotify steps.
586 (x_handle_selection_request): Rewrite to handle MULTIPLE target.
587 (x_convert_selection): New function.
588 (x_handle_selection_event): Simplify.
589 (x_get_foreign_selection): Don't ignore incoming requests while
590 waiting for an answer; this will fail when we implement
591 SAVE_TARGETS, and seems unnecessary anyway.
592 (selection_data_to_lisp_data): Recognize ATOM_PAIR type.
593 (Vx_sent_selection_functions): Doc fix.
594
595 2011-05-26 Leo Liu <sdl.web@gmail.com>
596
597 * editfns.c (Ftranspose_regions): Allow empty regions. (Bug#8699)
598
599 2011-05-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
600
601 * dispextern.h (struct glyph_row): New member fringe_bitmap_periodic_p.
602
603 * dispnew.c (shift_glyph_matrix, scrolling_window): Mark scrolled row
604 for fringe update if it has periodic bitmap.
605 (row_equal_p): Also compare left_fringe_offset, right_fringe_offset,
606 and fringe_bitmap_periodic_p.
607
608 * fringe.c (get_fringe_bitmap_data): New function.
609 (draw_fringe_bitmap_1, update_window_fringes): Use it.
610 (update_window_fringes): Record periodicity of fringe bitmap in glyph
611 row. Mark glyph row for fringe update if periodicity changed.
612
613 * xdisp.c (try_window_reusing_current_matrix): Don't mark scrolled row
614 for fringe update unless it has periodic bitmap.
615
616 2011-05-25 Kenichi Handa <handa@m17n.org>
617
618 * xdisp.c (get_next_display_element): Set correct it->face_id for
619 a static composition.
620
621 2011-05-24 Leo Liu <sdl.web@gmail.com>
622
623 * deps.mk (fns.o):
624 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha1.h.
625
626 * fns.c (crypto_hash_function, Fsha1): New function.
627 (Fmd5): Use crypto_hash_function.
628 (syms_of_fns): Add Ssha1.
629
630 2011-05-22 Paul Eggert <eggert@cs.ucla.edu>
631
632 * gnutls.c: Remove unused macros.
633 (fn_gnutls_transport_set_lowat, fn_gnutls_transport_set_pull_function):
634 (fn_gnutls_transport_set_push_function) [!WINDOWSNT]:
635 Remove macros that are defined and never used.
636 Caught by gcc -Wunused-macros (GCC 4.6.0, Fedora 14).
637
638 2011-05-22 Chong Yidong <cyd@stupidchicken.com>
639
640 * xselect.c (syms_of_xselect): Remove unused symbol SAVE_TARGETS.
641 (Fx_get_selection_internal): Minor cleanup.
642 (Fx_own_selection_internal): Rename arguments for consistency with
643 select.el.
644
645 2011-05-22 Paul Eggert <eggert@cs.ucla.edu>
646
647 * xselect.c (QSAVE_TARGETS): New static var, to fix build failure.
648
649 2011-05-22 Chong Yidong <cyd@stupidchicken.com>
650
651 * xselect.c (syms_of_xselect): Include character.h; use DEFSYM.
652
653 2011-05-21 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
654
655 * dispnew.c (scrolling_window): Don't exclude the case that the
656 last enabled row in the desired matrix touches the bottom boundary.
657
658 2011-05-21 Glenn Morris <rgm@gnu.org>
659
660 * Makefile.in ($(etc)/DOC): Make second command line even shorter.
661 (SOME_MACHINE_OBJECTS): Replace FONT_OBJ by its maximal expansion,
662 and add some more files.
663
664 2011-05-20 Eli Zaretskii <eliz@gnu.org>
665
666 * callproc.c (Fcall_process) [MSDOS]: Fix arguments to
667 report_file_error introduced by the change from 2011-05-07.
668
669 2011-05-20 Paul Eggert <eggert@cs.ucla.edu>
670
671 * systime.h (Time): Define only if emacs is defined.
672 This is to allow ../lib-src/profile.c to be compiled on FreeBSD,
673 where the include path doesn't have X11/X.h by default. See
674 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00561.html>.
675
676 2011-05-20 Kenichi Handa <handa@m17n.org>
677
678 * composite.c (find_automatic_composition): Fix previous change.
679
680 2011-05-20 Glenn Morris <rgm@gnu.org>
681
682 * lisp.mk: New file, split from Makefile.in.
683 * Makefile.in (lisp): Move to separate file, inserted by @lisp_frag@.
684 (shortlisp): Remove.
685 ($(etc)/DOC): Edit lisp.mk rather than using $shortlisp.
686
687 2011-05-19 Glenn Morris <rgm@gnu.org>
688
689 * Makefile.in (MSDOS_SUPPORT_REAL, MSDOS_SUPPORT, NS_SUPPORT)
690 (REAL_MOUSE_SUPPORT, GPM_MOUSE_SUPPORT, MOUSE_SUPPORT, TOOLTIP_SUPPORT)
691 (BASE_WINDOW_SUPPORT, X_WINDOW_SUPPORT, WINDOW_SUPPORT): Remove.
692 (lisp): Set the order to that of loadup.el.
693 (shortlisp): Make it a copy of $lisp.
694 (SOME_MACHINE_LISP): Remove.
695 ($(etc)/DOC): Depend just on $lisp, not $SOME_MACHINE_LISP too.
696 Use just $shortlisp, not $SOME_MACHINE_LISP too.
697
698 2011-05-18 Kenichi Handa <handa@m17n.org>
699
700 * composite.c (CHAR_COMPOSABLE_P): Add more check for efficiency.
701 (BACKWARD_CHAR): Wrap the arg STOP by parenthesis.
702 (find_automatic_composition): Mostly rewrite for efficiency.
703
704 2011-05-18 Juanma Barranquero <lekktu@gmail.com>
705
706 * makefile.w32-in: Update dependencies.
707
708 2011-05-18 Christoph Scholtes <cschol2112@googlemail.com>
709
710 * menu.c: Include limits.h (fixes the MS-Windows build broken by
711 revision 104625).
712
713 2011-05-18 Paul Eggert <eggert@cs.ucla.edu>
714
715 Fix some integer overflow issues, such as string length overflow.
716
717 * insdel.c (count_size_as_multibyte): Check for string overflow.
718
719 * character.c (lisp_string_width): Check for string overflow.
720 Use EMACS_INT, not int, for string indexes and lengths; in
721 particular, 2nd arg is now EMACS_INT, not int. Do not crash if
722 the resulting string length overflows an EMACS_INT; instead,
723 report a string overflow if no precision given. When checking for
724 precision exhaustion, use a check that cannot possibly have
725 integer overflow. (Bug#8675)
726 * character.h (lisp_string_width): Adjust to new signature.
727
728 * alloc.c (string_overflow): New function.
729 (Fmake_string): Use it. This doesn't change behavior, but saves
730 a few bytes and will simplify future changes.
731 * character.c (string_escape_byte8): Likewise.
732 * lisp.h (string_overflow): New decl.
733
734 Fixups, following up to the user-interface timestamp change.
735 * nsterm.m (last_mouse_movement_time, ns_mouse_position): Use Time
736 for UI timestamps, instead of unsigned long.
737 * msdos.c (mouse_get_pos): Likewise.
738 * w32inevt.c (movement_time, w32_console_mouse_position): Likewise.
739 * w32gui.h (Time): Define by including "systime.h" rather than by
740 declaring it ourselves. (Bug#8664)
741
742 * dispextern.h (struct image): Don't assume time_t <= unsigned long.
743 * image.c (clear_image_cache): Likewise.
744
745 * term.c (term_mouse_position): Don't assume time_t wraparound.
746
747 Be more systematic about user-interface timestamps.
748 Before, the code sometimes used 'Time', sometimes 'unsigned long',
749 and sometimes 'EMACS_UINT', to represent these timestamps.
750 This change causes it to use 'Time' uniformly, as that's what X uses.
751 This makes the code easier to follow, and makes it easier to catch
752 integer overflow bugs such as Bug#8664.
753 * frame.c (Fmouse_position, Fmouse_pixel_position):
754 Use Time, not unsigned long, for user-interface timestamps.
755 * keyboard.c (last_event_timestamp, kbd_buffer_get_event): Likewise.
756 (button_down_time, make_lispy_position, make_lispy_movement): Likewise.
757 * keyboard.h (last_event_timestamp): Likewise.
758 * menu.c (Fx_popup_menu) [!HAVE_X_WINDOWS]: Likewise.
759 * menu.h (xmenu_show): Likewise.
760 * term.c (term_mouse_position): Likewise.
761 * termhooks.h (struct input_event.timestamp): Likewise.
762 (struct terminal.mouse_position_hook): Likewise.
763 * xmenu.c (create_and_show_popup_menu, xmenu_show): Likewise.
764 * xterm.c (XTmouse_position, x_scroll_bar_report_motion): Likewise.
765 * systime.h (Time): New decl. Pull it in from <X11/X.h> if
766 HAVE_X_WINDOWS, otherwise define it as unsigned long, which is
767 what it was before.
768 * menu.h, termhooks.h: Include "systime.h", for Time.
769
770 * keyboard.c (make_lispy_event): Fix problem in integer overflow.
771 Don't assume that the difference between two unsigned long values
772 can fit into an integer. At this point, we know button_down_time
773 <= event->timestamp, so the difference must be nonnegative, so
774 there's no need to cast the result if double-click-time is
775 nonnegative, as it should be; check that it's nonnegative, just in
776 case. This bug is triggered when events are more than 2**31 ms
777 apart (about 25 days). (Bug#8664)
778
779 * xselect.c (last_event_timestamp): Remove duplicate decl.
780 (x_own_selection): Remove needless cast to unsigned long.
781
782 * xmenu.c (set_frame_menubar): Use int, not EMACS_UINT, for indexes
783 that always fit in int. Use a sentinel instead of a counter, to
784 avoid a temp and to allay GCC's concerns about possible int overflow.
785 * frame.h (struct frame): Use int for menu_bar_items_used
786 instead of EMACS_INT, since it always fits in int.
787
788 * menu.c (grow_menu_items): Check for int overflow.
789
790 * xmenu.c (set_frame_menubar): Don't mishandle vectors with no nils.
791
792 * xterm.c: Use EMACS_INT for Emacs modifiers, and int for X modifiers.
793 Before, the code was not consistent. These values cannot exceed
794 2**31 - 1 so there's no need to make them unsigned.
795 (x_x_to_emacs_modifiers): Accept int and return EMACS_INT.
796 (x_emacs_to_x_modifiers): Accept EMACS_INT and return int.
797 (x_x_to_emacs_modifiers, x_emacs_to_x_modifiers): Reject non-integers
798 as modifiers.
799 * xterm.h (x_x_to_emacs_modifiers): Adjust to signature change.
800
801 * lisp.h (XINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_INT.
802 (XUINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_UINT.
803 Otherwise, GCC 4.6.0 warns about printf (pI, XINT (...)),
804 presumably because the widths might not match.
805
806 * window.c (size_window): Avoid needless test at loop start.
807
808 2011-05-18 Courtney Bane <emacs-bugs-7626@cbane.org> (tiny change)
809
810 * term.c (Fresume_tty): Restore hooks before reinitializing (bug#8687).
811
812 2011-05-12 Drew Adams <drew.adams@oracle.com>
813
814 * textprop.c (Fprevious_single_char_property_change): Doc fix (bug#8655).
815
816 2011-05-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
817
818 * w32term.c (w32_draw_fringe_bitmap): Rename local vars `left' and
819 `width' to `bar_area_x' and `bar_area_width', respectively.
820 (x_scroll_run): Take account of fringe background extension.
821
822 * xterm.c (x_draw_fringe_bitmap) [USE_TOOLKIT_SCROLL_BARS]:
823 Rename local vars `left' and `width' to `bar_area_x' and
824 `bar_area_width', respectively.
825 (x_scroll_run) [USE_TOOLKIT_SCROLL_BARS]: Take account of fringe
826 background extension.
827
828 2011-05-10 Jim Meyering <meyering@redhat.com>
829
830 * xdisp.c (x_intersect_rectangles): Fix typo "the the -> the".
831
832 2011-05-10 Juanma Barranquero <lekktu@gmail.com>
833
834 * image.c (Finit_image_library): Return t for built-in image types,
835 like pbm and xbm. (Bug#8640)
836
837 2011-05-09 Andreas Schwab <schwab@linux-m68k.org>
838
839 * w32menu.c (set_frame_menubar): Fix submenu allocation.
840
841 2011-05-07 Eli Zaretskii <eliz@gnu.org>
842
843 * w32console.c (Fset_screen_color): Doc fix.
844 (Fget_screen_color): New function.
845 (syms_of_ntterm): Defsubr it.
846
847 * callproc.c (call_process_cleanup) [MSDOS]: Don't close and
848 unlink the temporary file if Fcall_process didn't create it in the
849 first place.
850 (Fcall_process) [MSDOS]: Don't create tempfile if stdout of the
851 child process will be redirected to a file specified with `:file'.
852 Don't try to re-open tempfile in that case, and set fd[0] to -1 as
853 cue to call_process_cleanup not to close that handle.
854
855 2011-05-07 Ben Key <bkey76@gmail.com>
856
857 * makefile.w32-in: The bootstrap-temacs rule now makes use of
858 one of two shell specific rules, either bootstrap-temacs-CMD or
859 bootstrap-temacs-SH. The bootstrap-temacs-SH rule is identical
860 to the previous implementation of the bootstrap-temacs rule.
861 The bootstrap-temacs-CMD rule is similar to the previous
862 implementation of the bootstrap-temacs rule except that it
863 makes use of the ESC_CFLAGS variable instead of the CFLAGS
864 variable.
865
866 These changes, along with some changes to nt/configure.bat,
867 nt/gmake.defs, and nt/nmake.defs, are required to extend my
868 earlier fix to add support for --cflags and --ldflags options
869 that include quotes so that it works whether make uses cmd or
870 sh as the shell.
871
872 2011-05-06 Michael Albinus <michael.albinus@gmx.de>
873
874 * dbusbind.c (QCdbus_type_unix_fd): Declare static.
875 (xd_remove_watch): Don't check QCdbus_type_unix_fd for SYMBOLP, it
876 is a constant.
877 (Fdbus_init_bus, xd_read_queued_messages): Bus can be a symbol or
878 a string. Handle both cases.
879 (Fdbus_call_method_asynchronously, Fdbus_register_signal)
880 (Fdbus_register_method): Use Qinvalid_function.
881
882 2011-05-06 Juanma Barranquero <lekktu@gmail.com>
883
884 * makefile.w32-in: Update dependencies.
885 (LISP_H): Add inttypes.h and stdin.h.
886 (PROCESS_H): Add unistd.h.
887
888 2011-05-06 Eli Zaretskii <eliz@gnu.org>
889
890 * lread.c: Include limits.h (fixes the MS-Windows build broken by
891 2011-05-06T07:13:19Z!eggert@cs.ucla.edu).
892
893 2011-05-06 Paul Eggert <eggert@cs.ucla.edu>
894
895 * image.c (Finit_image_library) [!HAVE_NTGUI]: Omit unused local.
896
897 * term.c (vfatal): Remove stray call to va_end.
898 It's not needed and the C Standard doesn't allow it here anyway.
899
900 Use C99's va_copy to avoid undefined behavior on x86-64 GNU/Linux.
901 * eval.c (verror): doprnt a copy of ap, not the original. (Bug#8545)
902
903 * eval.c (verror): OK to create a string of up to MOST_POSITIVE_FIXNUM
904 bytes.
905
906 * term.c: Don't include <stdarg.h>, as <lisp.h> does that.
907
908 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
909
910 * process.c (Fformat_network_address): Fix typo: args2 -> *args2.
911
912 * xmenu.c (set_frame_menubar): Fix typo: int * -> int (3 times).
913
914 * coding.c (detect_coding_charset): Fix typo: * 2 -> *4 (Bug#8601).
915
916 * charset.h (struct charset.code_space): Now has 15 elements, not 16.
917 * charset.c (Fdefine_charset_internal): Don't initialize
918 charset.code_space[15]. The value was garbage, on hosts with
919 32-bit int (Bug#8600).
920
921 * lread.c (read_integer): Be more consistent with string-to-number.
922 Use string_to_number to do the actual conversion; this avoids
923 rounding errors and fixes some other screwups. Without this fix,
924 for example, #x1fffffffffffffff was misread as -2305843009213693952.
925 (digit_to_number): Move earlier, for benefit of read_integer.
926 Return -1 if the digit is out of range for the base, -2 if it is
927 not a digit in any supported base. (Bug#8602)
928
929 * doprnt.c (doprnt): Support arbitrary pI values, such as "I64".
930
931 * dispnew.c (scrolling_window): Return 1 if we scrolled,
932 to match comment at start of function. This also removes a
933 GCC warning about overflow in a 32+64-bit port.
934
935 * lisp.h (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Simplify.
936
937 * dbusbind.c: Do not use XPNTR on a value that may be an integer.
938 Reported by Stefan Monnier in
939 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00919.html>.
940 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
941 Use SYMBOLP-guarded XSYMBOL, not XPNTR.
942
943 * lisp.h (EMACS_INTPTR): Remove. All uses changed to intptr_t.
944 (EMACS_UINTPTR): Likewise, with uintptr_t.
945
946 * lisp.h: Prefer 64-bit EMACS_INT if available.
947 (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Define to 64-bit
948 on 32-bit hosts that have 64-bit int, so that they can access
949 large files.
950 However, temporarily disable this change unless the temporary
951 symbol WIDE_EMACS_INT is defined.
952
953 * lread.c, process.c: Do not include <inttypes.h>; lisp.h does it now.
954
955 Prefer intptr_t/uintptr_t for integers the same widths as pointers.
956 This removes an assumption that EMACS_INT and long are the same
957 width as pointers. The assumption is true for Emacs porting targets
958 now, but we want to make other targets possible.
959 * lisp.h: Include <inttypes.h>, for INTPTR_MAX, UINTPTR_MAX.
960 (EMACS_INTPTR, EMACS_UINTPTR): New macros.
961 In the rest of the code, change types of integers that hold casted
962 pointers to EMACS_INTPTR and EMACS_UINTPTR, systematically
963 replacing EMACS_INT, long, EMACS_UINT, and unsigned long.
964 (XTYPE): Don't cast arg to EMACS_UINT; normally is not needed.
965 (XSET): Cast type of XTYPE arg to EMACS_INTPTR; it is needed here.
966 No need to cast type when ORing.
967 (XPNTR): Return a value of type EMACS_INTPTR or EMACS_UINTPTR.
968 * alloc.c (lisp_align_malloc): Remove a no-longer-needed cast.
969 * doc.c (store_function_docstring): Use EMACS_INTPTR, so as not to
970 assume EMACS_INT is the same width as char *.
971 * gtkutil.c (xg_gtk_scroll_destroy, xg_tool_bar_button_cb):
972 (xg_tool_bar_callback, xg_tool_bar_help_callback, xg_make_tool_item):
973 Remove no-longer-needed casts.
974 (xg_create_scroll_bar, xg_tool_bar_button_cb, xg_tool_bar_callback):
975 (xg_tool_bar_help_callback, xg_make_tool_item):
976 Use EMACS_INTPTR to hold an integer
977 that will be cast to void *; this can avoid a GCC warning
978 if EMACS_INT is not the same width as void *.
979 * menu.c (find_and_call_menu_selection): Remove no-longer-needed cast.
980 * xdisp.c (display_echo_area_1, resize_mini_window_1):
981 (current_message_1, set_message_1):
982 Use a local to convert to proper width without a cast.
983 * xmenu.c (dialog_selection_callback): Likewise.
984
985 * sysdep.c (get_random): Don't assume EMACS_INT is no wider than long.
986 Also, don't assume VALBITS / RAND_BITS is less than 5,
987 and don't rely on undefined behavior when shifting a 1 left into
988 the sign bit.
989 * lisp.h (get_random): Change signature to match.
990
991 * lread.c (hash_string): Use size_t, not int, for hash computation.
992 Normally we prefer signed values; but hashing is special, because
993 it's better to use unsigned division on hash table sizes so that
994 the remainder is nonnegative. Also, size_t is the natural width
995 for hashing into memory. The previous code used 'int', which doesn't
996 retain enough info to hash well into very large tables.
997 (oblookup, oblookup_last_bucket_number, Funintern): Likewise.
998
999 * dbusbind.c: Don't possibly lose pointer info when converting.
1000 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
1001 Use XPNTR rather than XHASH, so that the high-order bits of
1002 the pointer aren't lost when converting through void *.
1003
1004 * eval.c (Fautoload): Don't double-shift a pointer.
1005
1006 * fns.c (Frandom): Let EMACS_UINT be wider than unsigned long.
1007
1008 2011-05-06 Juanma Barranquero <lekktu@gmail.com>
1009
1010 * gnutls.c (DEF_GNUTLS_FN):
1011 * image.c (DEF_IMGLIB_FN): Make function pointers static.
1012
1013 2011-05-05 Andreas Schwab <schwab@linux-m68k.org>
1014
1015 * lread.c (lisp_file_lexically_bound_p): Stop scanning at end
1016 marker. (Bug#8610)
1017
1018 2011-05-05 Eli Zaretskii <eliz@gnu.org>
1019
1020 * w32heap.c (allocate_heap) [USE_LISP_UNION_TYPE || USE_LSB_TAG]:
1021 New version that can reserve upto 2GB of heap space.
1022
1023 2011-05-05 Chong Yidong <cyd@stupidchicken.com>
1024
1025 * nsfns.m (Fns_read_file_name): Doc fix (Bug#8534).
1026
1027 2011-05-05 Teodor Zlatanov <tzz@lifelogs.com>
1028
1029 * gnutls.c (fn_gnutls_certificate_set_x509_key_file): Add alias to
1030 `gnutls_certificate_set_x509_key_file'.
1031
1032 2011-05-05 Juanma Barranquero <lekktu@gmail.com>
1033
1034 * makefile.w32-in ($(BLD)/image.$(O), $(BLD)/process.$(O)):
1035 Update dependencies.
1036
1037 2011-05-04 Juanma Barranquero <lekktu@gmail.com>
1038
1039 * gnutls.h (emacs_gnutls_write, emacs_gnutls_read):
1040 * gnutls.c (emacs_gnutls_write, emacs_gnutls_read):
1041 Remove unused parameter `fildes'.
1042 * process.c (read_process_output, send_process): Don't pass it.
1043
1044 2011-05-04 Juanma Barranquero <lekktu@gmail.com>
1045
1046 Fix previous change: the library cache is defined in w32.c.
1047 * image.c (CACHE_IMAGE_TYPE) [!HAVE_NTGUI]: Define to noop.
1048 (Finit_image_library): Wrap Vlibrary_cache on "#ifdef HAVE_NTGUI".
1049
1050 2011-05-04 Juanma Barranquero <lekktu@gmail.com>
1051
1052 Implement dynamic loading of GnuTLS on Windows.
1053
1054 * gnutls.h (GNUTLS_EMACS_ERROR_NOT_LOADED): New macro.
1055 (emacs_gnutls_write, emacs_gnutls_read): Mark as extern.
1056 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
1057 Declare.
1058
1059 * gnutls.c (Qgnutls_dll): Define.
1060 (DEF_GNUTLS_FN, LOAD_GNUTLS_FN): New macros.
1061 (gnutls_*): Declare function pointers.
1062 (init_gnutls_functions): New function to initialize function pointers.
1063 (emacs_gnutls_handshake, Fgnutls_error_string, Fgnutls_deinit)
1064 (emacs_gnutls_global_init, Fgnutls_bye): Use function pointers.
1065 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
1066 Wrappers for gnutls_record_check_pending and gnutls_transport_set_errno.
1067 (emacs_gnutls_write, emacs_gnutls_read)
1068 (emacs_gnutls_handle_error, Fgnutls_error_fatalp)
1069 (Fgnutls_available_p): New function.
1070 (Fgnutls_boot): Call Fgnutls_available_p. Use function pointers.
1071 (syms_of_gnutls) <Qgnutls_dll>: Initialize and staticpro it.
1072 (syms_of_gnutls) <Sgnutls_available_p>: defsubr it.
1073
1074 * image.c: Include w32.h.
1075 (Vimage_type_cache): Delete.
1076 (syms_of_image) <Vimage_type_cache>: Don't initialize and staticpro it.
1077 (CACHE_IMAGE_TYPE, Finit_image_library): Use Vlibrary_cache instead.
1078 (w32_delayed_load): Move to w32.c.
1079
1080 * w32.h (VlibraryCache, QCloaded_from, w32_delayed_load): Declare.
1081
1082 * w32.c (QCloaded_from, Vlibrary_cache): Define.
1083 (w32_delayed_load): Move from image.c. When loading a library, record
1084 its filename in the :loaded-from property of the library id.
1085 (globals_of_w32) <QCloaded_from, Vlibrary_cache>:
1086 Initialize and staticpro them.
1087 (emacs_gnutls_pull, emacs_gnutls_push): Call emacs_gnutls_* functions.
1088
1089 * process.c: Include lisp.h before w32.h, not after.
1090 (wait_reading_process_output): Call emacs_gnutls_record_check_pending
1091 instead of gnutls_record_check_pending.
1092
1093 * callproc.c, emacs.c: Include lisp.h before w32.h, not after.
1094
1095 2011-05-04 Teodor Zlatanov <tzz@lifelogs.com>
1096
1097 * gnutls.c (Fgnutls_boot): Support :keylist and :crlfiles options
1098 instead of :keyfiles. Give GnuTLS the keylist and the CRL lists
1099 as passed in.
1100
1101 2011-05-03 Jan Djärv <jan.h.d@swipnet.se>
1102
1103 * xterm.c (x_set_frame_alpha): Do not set property on anything
1104 else than FRAME_X_OUTER_WINDOW (Bug#8608).
1105
1106 2011-05-02 Juanma Barranquero <lekktu@gmail.com>
1107
1108 * sysdep.c (get_tty_size) [WINDOWSNT]: Implement. (Bug#8596)
1109
1110 2011-05-02 Juanma Barranquero <lekktu@gmail.com>
1111
1112 * gnutls.c (Qgnutls_log_level, Qgnutls_code, Qgnutls_anon)
1113 (Qgnutls_x509pki, Qgnutls_e_interrupted, Qgnutls_e_again)
1114 (Qgnutls_e_invalid_session, Qgnutls_e_not_ready_for_handshake)
1115 (gnutls_global_initialized, Qgnutls_bootprop_priority)
1116 (Qgnutls_bootprop_trustfiles, Qgnutls_bootprop_keyfiles)
1117 (Qgnutls_bootprop_callbacks, Qgnutls_bootprop_loglevel)
1118 (Qgnutls_bootprop_hostname, Qgnutls_bootprop_verify_flags)
1119 (Qgnutls_bootprop_verify_error, Qgnutls_bootprop_verify_hostname_error)
1120 (Qgnutls_bootprop_callbacks_verify): Make static.
1121
1122 2011-05-01 Andreas Schwab <schwab@linux-m68k.org>
1123
1124 * callproc.c: Indentation fixup.
1125
1126 * sysdep.c (wait_for_termination_1): Make static.
1127 (wait_for_termination, interruptible_wait_for_termination):
1128 Move after wait_for_termination_1.
1129
1130 2011-05-01 Lars Magne Ingebrigtsen <larsi@gnus.org>
1131
1132 * sysdep.c (interruptible_wait_for_termination): New function
1133 which is like wait_for_termination, but allows keyboard
1134 interruptions.
1135
1136 * callproc.c (Fcall_process): Add (:file "file") as an option for
1137 the STDOUT buffer.
1138 (Fcall_process_region): Ditto.
1139
1140 2011-04-30 Eli Zaretskii <eliz@gnu.org>
1141
1142 * dosfns.c (Fint86, Fdos_memget, Fdos_memput): Use `ASIZE (FOO)'
1143 rather than `XVECTOR (FOO)->size'.
1144
1145 * process.c: Remove HAVE_INTTYPES_H condition from inclusion of
1146 inttypes.h, as a gnulib replacement is used if it not available in
1147 system headers.
1148
1149 2011-04-21 Eli Zaretskii <eliz@gnu.org>
1150
1151 Lift the MOST_POSITIVE_FIXNUM/4 limitation on visited files.
1152 * fileio.c (Finsert_file_contents): Don't limit file size to 1/4
1153 of MOST_POSITIVE_FIXNUM. (Bug#8528)
1154
1155 * coding.c (coding_alloc_by_realloc): Error out if destination
1156 will grow beyond MOST_POSITIVE_FIXNUM.
1157 (decode_coding_emacs_mule): Abort if there isn't enough place in
1158 charbuf for the composition carryover bytes. Reserve an extra
1159 space for up to 2 characters produced in a loop.
1160 (decode_coding_iso_2022): Abort if there isn't enough place in
1161 charbuf for the composition carryover bytes.
1162
1163 2011-04-21 Eli Zaretskii <eliz@gnu.org>
1164
1165 * doprnt.c (doprnt) [!HAVE_LONG_LONG_INT]: Error out instead of
1166 aborting when %lld or %lll format is passed.
1167 [!HAVE_UNSIGNED_LONG_LONG_INT]: Error out instead of aborting when
1168 %llo or %llx format is passed. (Bug#8545)
1169
1170 * window.c (window_scroll_line_based): Use a marker instead of
1171 simple variables to record original value of point. (Bug#7952)
1172
1173 * doprnt.c (doprnt): Fix the case where a multibyte sequence
1174 produced by %s or %c overflows available buffer space. (Bug#8545)
1175
1176 2011-04-28 Paul Eggert <eggert@cs.ucla.edu>
1177
1178 * doprnt.c (doprnt): Omit useless test; int overflow check (Bug#8545).
1179 (SIZE_MAX): Move defn after all includes, as they might #define it.
1180
1181 2011-04-28 Juanma Barranquero <lekktu@gmail.com>
1182
1183 * w32.c (init_environment): Warn about defaulting HOME to C:\.
1184
1185 2011-04-28 Juanma Barranquero <lekktu@gmail.com>
1186
1187 * keyboard.c (Qdelayed_warnings_hook): Define.
1188 (command_loop_1): Run `delayed-warnings-hook'
1189 if Vdelayed_warnings_list is non-nil.
1190 (syms_of_keyboard) <delayed-warnings-hook>: DEFSYM it.
1191 (syms_of_keyboard) <delayed-warnings-list>: DEFVAR_LISP it.
1192
1193 2011-04-28 Eli Zaretskii <eliz@gnu.org>
1194
1195 * doprnt.c (doprnt): Don't return value smaller than the buffer
1196 size if the message was truncated. (Bug#8545).
1197
1198 2011-04-28 Juanma Barranquero <lekktu@gmail.com>
1199
1200 * w32fns.c (Fx_change_window_property, Fx_delete_window_property)
1201 (Fx_window_property): #if-0 the whole functions, not just the bodies.
1202
1203 2011-04-27 Paul Eggert <eggert@cs.ucla.edu>
1204
1205 * doprnt.c (doprnt): Support "ll" length modifier, for long long.
1206
1207 2011-04-27 Juanma Barranquero <lekktu@gmail.com>
1208
1209 * makefile.w32-in: Update dependencies.
1210
1211 2011-04-27 Eli Zaretskii <eliz@gnu.org>
1212
1213 Improve `doprnt' and its usage. (Bug#8545)
1214 * doprnt.c (doprnt): Make sure `format' is never accessed beyond
1215 `format_end'. Remove support for %l as a conversion specifier.
1216 Don't use xrealloc. Improve diagnostics when the %l size modifier
1217 is used. Update the commentary.
1218
1219 * eval.c (verror): Simplify calculation of size_t.
1220
1221 * coding.c (Ffind_operation_coding_system): Fix diagnostic error
1222 messages.
1223
1224 2011-04-27 Yoshiaki Kasahara <kasahara@nc.kyushu-u.ac.jp> (tiny change)
1225
1226 * buffer.c (init_buffer) [USE_MMAP_FOR_BUFFERS]: Adjust to aliasing
1227 change.
1228
1229 2011-04-27 Paul Eggert <eggert@cs.ucla.edu>
1230
1231 * nsmenu.m: Replace all uses of XVECTOR with ASIZE and AREF.
1232 This makes this file independent of the recent pseudovector change.
1233
1234 2011-04-26 Paul Eggert <eggert@cs.ucla.edu>
1235
1236 * keyboard.c (handle_user_signal): Fix pointer signedness problem.
1237
1238 * gnutls.c (emacs_gnutls_handle_error): Remove unused local.
1239 (Fgnutls_boot): gnutls_certificate_verify_peers2 wants unsigned *.
1240 Remove unused local.
1241 (emacs_gnutls_write): Don't use uninitialized rtnval if nbyte <= 0.
1242
1243 * lisp.h: Fix a problem with aliasing and vector headers. (Bug#8546)
1244 GCC 4.6.0 optimizes based on type-based alias analysis.
1245 For example, if b is of type struct buffer * and v of type struct
1246 Lisp_Vector *, then gcc -O2 was incorrectly assuming that &b->size
1247 != &v->size, and therefore "v->size = 1; b->size = 2; return
1248 v->size;" must therefore return 1. This assumption is incorrect
1249 for Emacs, since it type-puns struct Lisp_Vector * with many other
1250 types. To fix this problem, this patch adds a new type struct
1251 vectorlike_header that documents the constraints on layout of vectors
1252 and pseudovectors, and helps optimizing compilers not get fooled
1253 by Emacs's type punning. It also adds the macros XSETTYPED_PVECTYPE
1254 XSETTYPED_PSEUDOVECTOR, TYPED_PSEUDOVECTORP, for similar reasons.
1255 * lisp.h (XSETTYPED_PVECTYPE): New macro, specifying the name of
1256 the size member.
1257 (XSETPVECTYPE): Rewrite in terms of new macro.
1258 (XSETPVECTYPESIZE): New macro, specifying both type and size.
1259 This is a bit clearer, and further avoids the possibility of
1260 undesirable aliasing.
1261 (XSETTYPED_PSEUDOVECTOR): New macro, specifying the size.
1262 (XSETPSEUDOVECTOR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR.
1263 (XSETSUBR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR and XSIZE,
1264 since Lisp_Subr is a special case (no "next" field).
1265 (ASIZE): Now uses header.size rather than size.
1266 All previous uses of XVECTOR (foo)->size replaced to use this macro,
1267 to avoid the hassle of writing XVECTOR (foo)->header.size.
1268 (struct vectorlike_header): New type.
1269 (TYPED_PSEUDOVECTORP): New macro, also specifying the C type of the
1270 object, to help avoid aliasing.
1271 (PSEUDOVECTORP): Rewrite in terms of TYPED_PSEUDOVECTORP.
1272 (SUBRP): Likewise, since Lisp_Subr is a special case.
1273 * lisp.h (struct Lisp_Vector, struct Lisp_Char_Table):
1274 (struct Lisp_Sub_Char_Table, struct Lisp_Bool_Vector):
1275 (struct Lisp_Hash_Table): Combine first two members into a single
1276 struct vectorlike_header member. All uses of "size" and "next" members
1277 changed to be "header.size" and "header.next".
1278 * buffer.h (struct buffer): Likewise.
1279 * font.h (struct font_spec, struct font_entity, struct font): Likewise.
1280 * frame.h (struct frame): Likewise.
1281 * process.h (struct Lisp_Process): Likewise.
1282 * termhooks.h (struct terminal): Likewise.
1283 * window.c (struct save_window_data, struct saved_window): Likewise.
1284 * window.h (struct window): Likewise.
1285 * alloc.c (allocate_buffer, Fmake_bool_vector, allocate_pseudovector):
1286 Use XSETPVECTYPESIZE, not XSETPVECTYPE, to avoid aliasing problems.
1287 * buffer.c (init_buffer_once): Likewise.
1288 * lread.c (defsubr): Use XSETTYPED_PVECTYPE, since Lisp_Subr is a
1289 special case.
1290 * process.c (Fformat_network_address): Use local var for size,
1291 for brevity.
1292
1293 * bytecode.c (exec_byte_code): Don't use XVECTOR before CHECK_VECTOR.
1294
1295 Make the Lisp reader and string-to-float more consistent (Bug#8525)
1296 * data.c (atof): Remove decl; no longer used or needed.
1297 (digit_to_number): Move to lread.c.
1298 (Fstring_to_number): Use new string_to_number function, to be
1299 consistent with how the Lisp reader treats infinities and NaNs.
1300 Do not assume that floating-point numbers represent EMACS_INT
1301 without losing information; this is not true on most 64-bit hosts.
1302 Avoid double-rounding errors, by insisting on integers when
1303 parsing non-base-10 numbers, as the documentation specifies.
1304 * lisp.h (string_to_number): New decl, replacing ...
1305 (isfloat_string): Remove.
1306 * lread.c: Include <inttypes.h>, for uintmax_t and strtoumax.
1307 (read1): Do not accept +. and -. as integers; this
1308 appears to have been a coding error. Similarly, do not accept
1309 strings like +-1e0 as floating point numbers. Do not report
1310 overflow for integer overflows unless the base is not 10 which
1311 means we have no simple and reliable way to continue.
1312 Break out the floating-point parsing into a new
1313 function string_to_number, so that Fstring_to_number parses
1314 floating point numbers consistently with the Lisp reader.
1315 (digit_to_number): Move here from data.c. Make it static inline.
1316 (E_CHAR, EXP_INT): Remove, replacing with ...
1317 (E_EXP): New macro, to solve the "1.0e+" problem mentioned below.
1318 (string_to_number): New function, replacing isfloat_string.
1319 This function checks for valid syntax and produces the resulting
1320 Lisp float number too. Rework it so that string-to-number
1321 no longer mishandles examples like "1.0e+". Use strtoumax,
1322 so that overflow for non-base-10 numbers is reported only when
1323 there's no portable and simple way to convert to floating point.
1324
1325 * textprop.c (set_text_properties_1): Rewrite for clarity,
1326 and to avoid GCC warning about integer overflow.
1327
1328 * intervals.h (struct interval): Use EMACS_INT for members
1329 where EMACS_UINT might cause problems. See
1330 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html>.
1331 (CHECK_TOTAL_LENGTH): Remove cast to EMACS_INT; no longer needed.
1332 * intervals.c (interval_deletion_adjustment): Now returns EMACS_INT.
1333 All uses changed.
1334 (offset_intervals): Tell GCC not to worry about length overflow
1335 when negating a negative length.
1336
1337 * alloc.c (overrun_check_malloc, overrun_check_realloc): Now static.
1338 (overrun_check_free): Likewise.
1339
1340 * alloc.c (SDATA_SIZE) [!GC_CHECK_STRING_BYTES]: Avoid runtime check
1341 in the common case where SDATA_DATA_OFFSET is a multiple of Emacs
1342 word size.
1343
1344 * gnutls.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
1345 (gnutls_make_error): Rename local to avoid shadowing.
1346 (gnutls_emacs_global_deinit): ifdef out; not used.
1347 (Fgnutls_boot): Use const for pointer to readonly storage.
1348 Comment out unused local. Fix pointer signedness problems.
1349
1350 * lread.c (openp): Don't stuff size_t into an 'int'.
1351 Use <= on length, not < on length + 1, to avoid GCC 4.6.0 warning
1352 about possible signed overflow.
1353
1354 * gtkutil.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
1355 (GDK_KEY_g): Don't define if already defined.
1356 (xg_prepare_tooltip): Avoid pointer signedness problem.
1357 (xg_set_toolkit_scroll_bar_thumb): Redo to avoid two casts.
1358
1359 * process.c (Fnetwork_interface_info): Avoid left-shift undefined
1360 behavior with 1 << 31. GCC 4.6.0 warns about this on 32-bit hosts.
1361
1362 * xfns.c (Fx_window_property): Simplify a bit,
1363 to make a bit faster and to avoid GCC 4.6.0 warning.
1364 * xselect.c (x_get_window_property, x_handle_dnd_message): Likewise.
1365
1366 * fns.c (internal_equal): Don't assume size_t fits in int.
1367
1368 * alloc.c (compact_small_strings): Tighten assertion a little.
1369
1370 Replace pEd with more-general pI, and fix some printf arg casts.
1371 * lisp.h (pI): New macro, generalizing old pEd macro to other
1372 conversion specifiers. For example, use "...%"pI"d..." rather
1373 than "...%"pEd"...".
1374 (pEd): Remove. All uses replaced with similar uses of pI.
1375 * src/m/amdx86-64.h, src/m/ia64.h, src/m/ibms390x.h: Likewise.
1376 * alloc.c (check_pure_size): Don't overflow by converting size to int.
1377 * bidi.c (bidi_dump_cached_states): Use pI to avoid cast.
1378 * data.c (Fnumber_to_string): Use pI instead of if-then-else-abort.
1379 * dbusbind.c (xd_append_arg): Use pI to avoid cast.
1380 (Fdbus_method_return_internal, Fdbus_method_error_internal): Likewise.
1381 * font.c (font_unparse_xlfd): Avoid potential buffer overrun on
1382 64-bit hosts.
1383 (font_unparse_xlfd, font_unparse_fcname): Use pI to avoid casts.
1384 * keyboard.c (record_char, modify_event_symbol): Use pI to avoid casts.
1385 * print.c (safe_debug_print, print_object): Likewise.
1386 (print_object): Don't overflow by converting EMACS_INT or EMACS_UINT
1387 to int.
1388 Use pI instead of if-then-else-abort. Use %p to avoid casts,
1389 avoiding the 0 flag, which is not portable.
1390 * process.c (Fmake_network_process): Use pI to avoid cast.
1391 * region-cache.c (pp_cache): Likewise.
1392 * xdisp.c (decode_mode_spec): Likewise.
1393 * xrdb.c (x_load_resources) [USE_MOTIF]: Use pI to avoid undefined
1394 behavior on 64-bit hosts with printf arg.
1395 * xselect.c (x_queue_event): Use %p to avoid casts, avoiding 0 flag.
1396 (x_stop_queuing_selection_requests): Likewise.
1397 (x_get_window_property): Don't truncate byte count to an 'int'
1398 when tracing.
1399
1400 * frame.c (frame_name_fnn_p): Get rid of strtol, which isn't right
1401 here, since it parses constructs like leading '-' and spaces,
1402 which are not wanted; and it overflows with large numbers.
1403 Instead, simply match F[0-9]+, which is what is wanted anyway.
1404
1405 * alloc.c: Remove unportable assumptions about struct layout.
1406 (SDATA_SELECTOR, SDATA_DATA_OFFSET): New macros.
1407 (SDATA_OF_STRING, SDATA_SIZE, allocate_string_data):
1408 (allocate_vectorlike, make_pure_vector): Use the new macros,
1409 plus offsetof, to remove unportable assumptions about struct layout.
1410 These assumptions hold on all porting targets that I know of, but
1411 they are not guaranteed, they're easy to remove, and removing them
1412 makes further changes easier.
1413
1414 * alloc.c (BLOCK BYTES): Fix typo by changing "ablock" to "ablocks".
1415 This doesn't fix a bug but makes the code clearer.
1416 (string_overrun_cookie): Now const. Use initializers that
1417 don't formally overflow signed char, to avoid warnings.
1418 (allocate_string_data) [GC_CHECK_STRING_OVERRUN]: Fix typo that
1419 can cause Emacs to crash when string overrun checking is enabled.
1420 (allocate_buffer): Don't assume sizeof (struct buffer) is a
1421 multiple of sizeof (EMACS_INT); it need not be, if
1422 alignof(EMACS_INT) < sizeof (EMACS_INT).
1423 (check_sblock, check_string_bytes, check_string_free_list): Protoize.
1424
1425 2011-04-26 Juanma Barranquero <lekktu@gmail.com>
1426
1427 * keyboard.c (QCrtl): Rename from Qrtl. All uses changed.
1428
1429 2011-04-26 Teodor Zlatanov <tzz@lifelogs.com>
1430
1431 * gnutls.c (emacs_gnutls_handshake): Return an error if we're not
1432 supposed to be handshaking. (Bug#8556)
1433 Reported by Paul Eggert <eggert@cs.ucla.edu>.
1434
1435 2011-04-26 Daniel Colascione <dan.colascione@gmail.com>
1436
1437 * lisp.h (Qdebug): List symbol.
1438 * eval.c (Qdebug): Restore global linkage.
1439 * keyboard.c (debug-on-event): New variable.
1440 (handle_user_signal): Break into debugger when debug-on-event
1441 matches the current signal symbol.
1442
1443 2011-04-25 Dan Nicolaescu <dann@ics.uci.edu>
1444
1445 * alloc.c (check_sblock, check_string_bytes)
1446 (check_string_free_list): Convert to standard C.
1447
1448 2011-04-25 Teodor Zlatanov <tzz@lifelogs.com>
1449
1450 * w32.c (emacs_gnutls_push): Fix typo.
1451
1452 2011-04-25 Eli Zaretskii <eliz@gnu.org>
1453
1454 * gnutls.c (emacs_gnutls_handshake): Avoid compiler warnings about
1455 "cast to pointer from integer of different size".
1456
1457 Improve doprnt and its use in verror. (Bug#8545)
1458 * doprnt.c (doprnt): Document the set of format control sequences
1459 supported by the function. Use SAFE_ALLOCA instead of always
1460 using `alloca'.
1461
1462 * eval.c (verror): Don't limit the buffer size at size_max-1, that
1463 is one byte too soon. Don't use xrealloc; instead xfree and
1464 xmalloc anew.
1465
1466 2011-04-24 Teodor Zlatanov <tzz@lifelogs.com>
1467
1468 * gnutls.h: Add GNUTLS_STAGE_CALLBACKS enum to denote we're in the
1469 callbacks stage.
1470
1471 * gnutls.c: Renamed global_initialized to
1472 gnutls_global_initialized. Added internals for the
1473 :verify-hostname-error, :verify-error, and :verify-flags
1474 parameters of `gnutls-boot' and documented those parameters in the
1475 docstring. Start callback support.
1476 (emacs_gnutls_handshake): Add Woe32 support. Retry handshake
1477 unless a fatal error occured. Call gnutls_alert_send_appropriate
1478 on error. Return error code.
1479 (emacs_gnutls_write): Call emacs_gnutls_handle_error.
1480 (emacs_gnutls_read): Likewise.
1481 (Fgnutls_boot): Return handshake error code.
1482 (emacs_gnutls_handle_error): New function.
1483 (wsaerror_to_errno): Likewise.
1484
1485 * w32.h (emacs_gnutls_pull): Add prototype.
1486 (emacs_gnutls_push): Likewise.
1487
1488 * w32.c (emacs_gnutls_pull): New function for GnuTLS on Woe32.
1489 (emacs_gnutls_push): Likewise.
1490
1491 2011-04-24 Claudio Bley <claudio.bley@gmail.com> (tiny change)
1492
1493 * process.c (wait_reading_process_output): Check if GnuTLS
1494 buffered some data internally if no FDs are set for TLS
1495 connections.
1496
1497 * makefile.w32-in (OBJ2): Add gnutls.$(O).
1498 (LIBS): Link to USER_LIBS.
1499 ($(BLD)/gnutls.$(0)): New target.
1500
1501 2011-04-24 Eli Zaretskii <eliz@gnu.org>
1502
1503 * xdisp.c (handle_single_display_spec): Rename the
1504 display_replaced_before_p argument into display_replaced_p, to
1505 make it consistent with the commentary. Fix typos in the
1506 commentary.
1507
1508 * textprop.c (syms_of_textprop): Remove dead code.
1509 (copy_text_properties): Delete obsolete commentary about an
1510 interface that was deleted long ago. Fix typos in the description
1511 of arguments.
1512
1513 * msdos.c (XMenuActivate, XMenuAddSelection): Adjust argument list
1514 to changes in oldXMenu/XMenu.h from 2011-04-16.
1515 <menu_help_message, prev_menu_help_message>: Constify.
1516 (IT_menu_make_room): menu->help_text is now `const char **';
1517 adjust.
1518
1519 * msdos.h (XMenuActivate, XMenuAddSelection): Adjust prototypes
1520 to changes in oldXMenu/XMenu.h from 2011-04-16.
1521 (struct XMenu): Declare `help_text' `const char **'.
1522
1523 * xfaces.c <Qunspecified>: Make extern again.
1524
1525 * syntax.c: Include sys/types.h before including regex.h, as
1526 required by Posix.
1527
1528 * doc.c (get_doc_string): Improve the format passed to `error'.
1529
1530 * doprnt.c (doprnt): Improve commentary.
1531
1532 * term.c (init_tty) [MSDOS]: Fix 1st argument to maybe_fatal.
1533
1534 * Makefile.in (TAGS): Depend on $(M_FILE) and $(S_FILE), and scan
1535 them with etags.
1536
1537 * makefile.w32-in (globals.h): Add a dummy recipe, to make any
1538 changes in globals.h immediately force recompilation.
1539 (TAGS): Depend on $(CURDIR)/m/intel386.h and
1540 $(CURDIR)/s/ms-w32.h.
1541 (TAGS-gmake): Scan $(CURDIR)/m/intel386.h and $(CURDIR)/s/ms-w32.h.
1542
1543 * character.c (Fchar_direction): Function deleted.
1544 (syms_of_character): Don't defsubr it.
1545 <char-direction-table>: Deleted.
1546
1547 2011-04-23 Eli Zaretskii <eliz@gnu.org>
1548
1549 Fix doprnt so it could be used again safely in `verror'. (Bug#8435)
1550 * doprnt.c: Include limits.h.
1551 (SIZE_MAX): New macro.
1552 (doprnt): Return a size_t value. 2nd arg is now size_t.
1553 Many local variables are now size_t instead of int or unsigned.
1554 Improve overflow protection. Support `l' modifier for integer
1555 conversions. Support %l conversion. Don't assume an EMACS_INT
1556 argument for integer conversions and for %c.
1557
1558 * lisp.h (doprnt): Restore prototype.
1559
1560 * makefile.w32-in ($(BLD)/callint.$(O)): Depend on
1561 $(SRC)/character.h.
1562
1563 * Makefile.in (base_obj): Add back doprnt.o.
1564
1565 * deps.mk (doprnt.o): Add back prerequisites.
1566 (callint.o): Depend on character.h.
1567
1568 * eval.c (internal_lisp_condition_case): Include the handler
1569 representation in the error message.
1570 (verror): Call doprnt instead of vsnprintf. Fix an off-by-one bug
1571 when breaking from the loop.
1572
1573 * xdisp.c (vmessage): Call doprnt instead of vsnprintf.
1574
1575 * callint.c (Fcall_interactively): When displaying error message
1576 about invalid control letter, pass the character's codepoint, not
1577 a pointer to its multibyte form. Improve display of the character
1578 in octal and display also its hex code.
1579
1580 * character.c (char_string): Use %x to display the (unsigned)
1581 codepoint of an invalid character, to avoid displaying a bogus
1582 negative value.
1583
1584 * font.c (check_otf_features): Pass SDATA of SYMBOL_NAME to
1585 `error', not SYMBOL_NAME itself.
1586
1587 * coding.c (Fencode_sjis_char, Fencode_big5_char): Use %c for
1588 character arguments to `error'.
1589
1590 * charset.c (check_iso_charset_parameter): Fix incorrect argument
1591 to `error' in error message about FINAL_CHAR argument. Make sure
1592 FINAL_CHAR is a character, and use %c when it is passed as
1593 argument to `error'.
1594
1595 2011-04-23 Eli Zaretskii <eliz@gnu.org>
1596
1597 * s/ms-w32.h (localtime): Redirect to sys_localtime.
1598
1599 * w32.c: Include <time.h>.
1600 (sys_localtime): New function.
1601
1602 2011-04-23 Chong Yidong <cyd@stupidchicken.com>
1603
1604 * xdisp.c (init_xdisp): Initialize echo_area_window (Bug#6451).
1605
1606 * buffer.c (syms_of_buffer): Doc fix (Bug#6902).
1607
1608 2011-04-23 Samuel Thibault <sthibault@debian.org> (tiny change)
1609
1610 * sysdep.c (wait_for_termination): On GNU Hurd, kill returns -1 on
1611 zombies (Bug#8467).
1612
1613 2011-04-19 Eli Zaretskii <eliz@gnu.org>
1614
1615 * syntax.h (SETUP_SYNTAX_TABLE_FOR_OBJECT): Fix setting of
1616 gl_state.e_property when gl_state.object is Qt.
1617
1618 * insdel.c (make_gap_larger): Remove limitation of buffer size
1619 to <= INT_MAX.
1620
1621 2011-04-18 Chong Yidong <cyd@stupidchicken.com>
1622
1623 * xdisp.c (lookup_glyphless_char_display)
1624 (produce_glyphless_glyph): Handle cons cell entry in
1625 glyphless-char-display.
1626 (Vglyphless_char_display): Document it.
1627
1628 * term.c (produce_glyphless_glyph): Handle cons cell entry in
1629 glyphless-char-display.
1630
1631 2011-04-17 Chong Yidong <cyd@stupidchicken.com>
1632
1633 * xdisp.c (get_next_display_element): Remove unnecessary ifdefs.
1634
1635 * termhooks.h (FRAME_WINDOW_P): Remove duplicated definitions.
1636
1637 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): Add missing
1638 definition for no-X builds.
1639
1640 2011-04-16 Paul Eggert <eggert@cs.ucla.edu>
1641
1642 Static checks with GCC 4.6.0 and non-default toolkits.
1643
1644 * s/sol2-6.h, s/unixware.h (PTY_TTY_NAME_SPRINTF): Protoize decl.
1645
1646 * process.c (keyboard_bit_set): Define only if SIGIO.
1647 (send_process_trap): Mark it with NO_RETURN if it doesn't return.
1648 (send_process): Repair possible setjmp clobbering.
1649
1650 * s/usg5-4-common.h (SETUP_SLAVE_PTY): Don't pass extra arg to 'fatal'.
1651
1652 * eval.c: Include <stdio.h>, for vsnprintf on non-GNU/Linux hosts.
1653
1654 * data.c (arith_error): Mark with NO_RETURN if it doesn't return.
1655
1656 * alloc.c (bytes_used_when_full, SPARE_MEMORY, BYTES_USED):
1657 Define only if needed.
1658
1659 * sysdep.c (_FILE_OFFSET_BITS): Make this hack even uglier
1660 by pacifying GCC about it. Maybe it's time to retire it?
1661 * xfaces.c (USG, __TIMEVAL__): Likewise.
1662
1663 * dispextern.h (struct redisplay_interface): Rename param
1664 to avoid shadowing.
1665 * termhooks.h (struct terminal): Likewise.
1666 * xterm.c (xembed_send_message): Likewise.
1667
1668 * insdel.c (make_gap_smaller): Define only if
1669 USE_MMAP_FOR_BUFFERS || REL_ALLOC || DOUG_LEA_MALLOC.
1670
1671 * keyboard.c (read_char): Make a var volatile so longjmp won't clobber
1672 it.
1673
1674 * emacs.c (MAX_HEAP_BSS_DIFF, my_edata): Move to where they're used,
1675 so that we aren't warned about unused symbols.
1676
1677 * xfns.c (Fx_file_dialog): Rename local to avoid shadowing.
1678
1679 * xdisp.c (x_produce_glyphs): Mark var as initialized (Bug#8512).
1680
1681 * xfns.c (x_real_positions): Mark locals as initialized.
1682
1683 * xmenu.c (xmenu_show): Don't use uninitialized vars.
1684
1685 * xterm.c: Fix problems found by static analysis with other toolkits.
1686 (toolkit_scroll_bar_interaction): Define and use only if USE_X_TOOLKIT.
1687 (x_dispatch_event): Declare static if USE_GTK, and
1688 define if USE_GTK || USE_X_TOOLKIT.
1689 (SET_SAVED_BUTTON_EVENT): Define only if USE_X_TOOLKIT || USE_GTK.
1690 * xterm.h (x_dispatch_event): Extern only if USE_X_TOOLKIT.
1691 * xterm.c, xterm.h (x_mouse_leave): Bring this function back, but only
1692 if defined HAVE_MENUS && !defined USE_X_TOOLKIT && !defined USE_GTK.
1693
1694 * xmenu.c (menu_help_callback): Pointer type fixes.
1695 Use const pointers when pointing at readonly data. Avoid pointer
1696 signedness clashes.
1697 (FALSE): Remove unused macro.
1698 (update_frame_menubar): Remove unused decl.
1699
1700 * xfns.c (Fx_hide_tip): Move locals to avoid shadowing.
1701
1702 * menu.c (push_submenu_start, push_submenu_end): Do not define unless
1703 USE_X_TOOLKIT || USE_GTK || HAVE_NS || defined HAVE_NTGUI.
1704 (single_menu_item): Rename local to avoid shadowing.
1705
1706 * keyboard.c (make_lispy_event): Remove unused local var.
1707
1708 * frame.c, frame.h (x_get_resource_string): Bring this back, but
1709 only if HAVE_X_WINDOWS && !USE_X_TOOLKIT.
1710
1711 * bitmaps: Change bitmaps from unsigned char back to the X11
1712 compatible char. Avoid the old compiler warnings about
1713 out-of-range initializers by using, for example, '\xab' rather
1714 than 0xab.
1715
1716 * xgselect.c (xgselect_initialize): Check vs interface
1717 even if ! (defined (USE_GTK) || defined (HAVE_GCONF)).
1718
1719 * xmenu.c (xmenu_show): Rename parm to avoid shadowing.
1720
1721 * xterm.c (x_create_toolkit_scroll_bar): Use const * for pointers
1722 to read-only memory.
1723
1724 * fns.c (vector): Remove; this old hack is no longer needed.
1725
1726 * xsmfns.c (create_client_leader_window): Rename shadowing arg.
1727 Remove unused var.
1728 (gdk_x11_set_sm_client_id) [!USE_GTK]: Don't define.
1729
1730 * xrdb.c (x_load_resources): Omit unused local.
1731
1732 * xfns.c (free_frame_menubar, atof): Remove duplicate decls.
1733 (x_window): Rename locals to avoid shadowing.
1734 (USG): Use the kludged USG macro, to pacify gcc.
1735
1736 * xterm.c (x_alloc_nearest_color_for_widget): Remove; unused.
1737 (x_term_init): Remove local to avoid shadowing.
1738
1739 * xfns.c, xterm.c (_XEditResCheckMessages): Protoize decl.
1740
1741 * xdisp.c, dispextern.h (set_vertical_scroll_bar): Now extern if
1742 USE_TOOLKIT_SCROLL_BARS && !USE_GTK, as xterm.c needs it then.
1743
1744 2011-04-16 Eli Zaretskii <eliz@gnu.org>
1745
1746 * gnutls.c (Fgnutls_boot): Don't pass Lisp_Object to `error'.
1747
1748 Fix regex.c, syntax.c and friends for buffers > 2GB.
1749 * syntax.h (struct gl_state_s): Declare character position members
1750 EMACS_INT.
1751
1752 * syntax.c (update_syntax_table): Declare 2nd argument EMACS_INT.
1753
1754 * textprop.c (verify_interval_modification, interval_of):
1755 Declare arguments EMACS_INT.
1756
1757 * intervals.c (adjust_intervals_for_insertion): Declare arguments
1758 EMACS_INT.
1759
1760 * intervals.h (CHECK_TOTAL_LENGTH): Cast to EMACS_INT, not `int'.
1761
1762 * indent.c (Fvertical_motion): Local variable it_start is now
1763 EMACS_INT.
1764
1765 * regex.c (re_match, re_match_2, re_match_2_internal)
1766 (bcmp_translate, regcomp, regexec, print_double_string)
1767 (group_in_compile_stack, re_search, re_search_2, regex_compile)
1768 (re_compile_pattern, re_exec): Declare arguments and local
1769 variables `size_t' and `ssize_t' and return values `regoff_t', as
1770 appropriate.
1771 (POP_FAILURE_REG_OR_COUNT) <pfreg>: Declare `long'.
1772 (CHECK_INFINITE_LOOP) <failure>: Declare `ssize_t'.
1773 <compile_stack_type>: `size' and `avail' are now `size_t'.
1774
1775 * regex.h <regoff_t>: Use ssize_t, not int.
1776 (re_search, re_search_2, re_match, re_match_2): Arguments that
1777 specify buffer/string position and length are now ssize_t and
1778 size_t. Return type is regoff_t.
1779
1780 2011-04-16 Ben Key <bkey76@gmail.com>
1781
1782 * nsfont.m: Fixed bugs in ns_get_family and
1783 ns_descriptor_to_entity that were caused by using free to
1784 deallocate memory blocks that were allocated by xmalloc (via
1785 xstrdup). This caused Emacs to crash when compiled with
1786 XMALLOC_OVERRUN_CHECK defined (when Emacs was configured with
1787 --enable-checking=xmallocoverrun). xfree is now used to
1788 deallocate these memory blocks.
1789
1790 2011-04-15 Paul Eggert <eggert@cs.ucla.edu>
1791
1792 * sysdep.c (emacs_read): Remove unnecessary check vs MAX_RW_COUNT.
1793
1794 emacs_write: Accept and return EMACS_INT for sizes.
1795 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html
1796 et seq.
1797 * gnutls.c, gnutls.h (emacs_gnutls_read, emacs_gnutls_write):
1798 Accept and return EMACS_INT.
1799 (emacs_gnutls_write): Return the number of bytes written on
1800 partial writes.
1801 * sysdep.c, lisp.h (emacs_read, emacs_write): Likewise.
1802 (emacs_read, emacs_write): Remove check for negative size, as the
1803 Emacs source code has been audited now.
1804 * sysdep.c (MAX_RW_COUNT): New macro, to work around kernel bugs.
1805 (emacs_read, emacs_write): Use it.
1806 * process.c (send_process): Adjust to the new signatures of
1807 emacs_write and emacs_gnutls_write. Do not attempt to store
1808 a byte offset into an 'int'; it might overflow.
1809 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00483.html
1810
1811 * sound.c: Don't assume sizes fit in 'int'.
1812 (struct sound_device.period_size, alsa_period_size):
1813 Return EMACS_INT, not int.
1814 (struct sound_device.write, vox_write, alsa_write):
1815 Accept EMACS_INT, not int.
1816 (wav_play, au_play): Use EMACS_INT to store sizes and to
1817 record read return values.
1818
1819 2011-04-15 Ben Key <bkey76@gmail.com>
1820
1821 * keyboard.c (Qundefined): Don't declare static since it is used
1822 in nsfns.m.
1823 * xfaces.c (Qbold, Qexpanded, Qitalic, Qcondensed): Don't declare
1824 static since they are used in nsfont.m.
1825
1826 2011-04-15 Stefan Monnier <monnier@iro.umontreal.ca>
1827
1828 * process.c (Qprocessp): Don't declare static.
1829 * lisp.h (Qprocessp): Declare again.
1830
1831 2011-04-15 Juanma Barranquero <lekktu@gmail.com>
1832
1833 * font.c (Qopentype): Don't make static (used from w32uniscribe.c).
1834
1835 2011-04-14 Paul Eggert <eggert@cs.ucla.edu>
1836
1837 Improve C-level modularity by making more things 'static'.
1838
1839 Don't publish debugger-only interfaces to other modules.
1840 * lisp.h (safe_debug_print, debug_output_compilation_hack):
1841 (verify_bytepos, count_markers): Move decls to the only modules
1842 that need them.
1843 * region-cache.h (pp_cache): Likewise.
1844 * window.h (check_all_windows): Likewise.
1845 * marker.c, print.c, region-cache.c, window.c: Decls moved here.
1846
1847 * sysdep.c (croak): Now static, if
1848 defined TIOCNOTTY || defined USG5 || defined CYGWIN.
1849 * syssignal.h (croak): Declare only if not static.
1850
1851 * alloc.c (refill_memory_reserve): Now static if
1852 !defined REL_ALLOC || defined SYSTEM_MALLOC.
1853 * lisp.h (refill_memory_reserve): Declare only if not static.
1854
1855 * xsettings.c, xsettings.h (xsettings_get_system_normal_font):
1856 Define only if USE_LUCID.
1857
1858 * xrdb.c (x_customization_string, x_rm_string): Now static.
1859
1860 * xmenu.c (x_menu_wait_for_event): Export only if USE_MOTIF.
1861 * xterm.h (x_menu_wait_for_event): Declare only if USE_MOTIF.
1862
1863 * xdisp.c (draw_row_with_mouse_face): Now static.
1864 * dispextern.h (draw_row_with_mouse_fave): Remove decl.
1865
1866 * window.h (check_all_windows): Mark externally visible.
1867
1868 * window.c (window_deletion_count): Now static.
1869
1870 * undo.c: Make symbols static if they're not exported.
1871 (last_undo_buffer, last_boundary_position, pending_boundary):
1872 Now static.
1873
1874 * textprop.c (interval_insert_behind_hooks): Now static.
1875 (interval_insert_in_front_hooks): Likewise.
1876
1877 * term.c: Make symbols static if they're not exported.
1878 (tty_turn_off_highlight, get_tty_terminal, max_frame_cols):
1879 (max_frame_lines, tty_set_terminal_modes):
1880 (tty_reset_terminal_modes, tty_turn_off_highlight):
1881 (get_tty_terminal): Now static.
1882 (term_mouse_moveto): Do not define if HAVE_WINDOW_SYSTEM.
1883 * termhooks.h (term_mouse_moveto): Do not declare if
1884 HAVE_WINDOW_SYSTEM.
1885 * dispextern.h (tty_set_terminal_modes, tty_reset_terminal_modes):
1886 (tty_turn_off_highlight, get_tty_terminal): Remove decls.
1887
1888 * sysdep.c: Make symbols static if they're not exported.
1889 (emacs_get_tty, emacs_set_tty, old_fcntl_flags, old_fcntl_owner):
1890 Now static.
1891 (sigprocmask_set, full_mask): Remove; unused.
1892 (wait_debugging): Mark as visible.
1893 * syssignal.h (SIGFULLMASK, full_mask): Remove decls.
1894 * systty.h (emacs_get_tty, emacs_set_tty): Remove decls.
1895
1896 * syntax.c (syntax_temp): Define only if !__GNUC__.
1897
1898 * sound.c (current_sound_device, current_sound): Now static.
1899
1900 * search.c (searchbufs, searchbuf_head): Now static.
1901
1902 * scroll.c (scroll_cost): Remove; unused.
1903 * dispextern.h (scroll_cost): Remove decl.
1904
1905 * region-cache.h (pp_cache): Mark as externally visible.
1906
1907 * process.c: Make symbols static if they're not exported.
1908 (process_tick, update_tick, create_process, chan_process):
1909 (Vprocess_alist, proc_buffered_char, datagram_access):
1910 (fd_callback_data, send_process_frame, process_sent_to): Now static.
1911 (deactivate_process): Mark defn as static, as well as decl.
1912 * lisp.h (create_process): Remove decl.
1913 * process.h (chan_process, Vprocess_alist): Remove decls.
1914
1915 * print.c: Make symbols static if they're not exported.
1916 (print_depth, new_backquote_output, being_printed, print_buffer):
1917 (print_buffer_size, print_buffer_pos, print_buffer_pos_byte):
1918 (print_interval, print_number_index, initial_stderr_stream):
1919 Now static.
1920 * lisp.h (Fprinc): Remove decl.
1921 (debug_output_compilation_hack): Mark as externally visible.
1922
1923 * sysdep.c (croak): Move decl from here to syssignal.h.
1924 * syssignal.h (croak): Put it here, so the API can be checked when
1925 'croak' is called from dissociate_if_controlling_tty.
1926
1927 * minibuf.c: Make symbols static if they're not exported.
1928 (minibuf_save_list, choose_minibuf_frame): Now static.
1929 * lisp.h (choose_minibuf_frame): Remove decl.
1930
1931 * lisp.h (verify_bytepos, count_markers): Mark as externally visible.
1932
1933 * lread.c: Make symbols static if they're not exported.
1934 (read_objects, initial_obarray, oblookup_last_bucket_number):
1935 Now static.
1936 (make_symbol): Remove; unused.
1937 * lisp.h (initial_obarray, make_symbol): Remove decls.
1938
1939 * keyboard.c: Make symbols static if they're not exported.
1940 (single_kboard, recent_keys_index, total_keys, recent_keys):
1941 (this_command_key_count_reset, raw_keybuf, raw_keybuf_count):
1942 (this_single_command_key_start, echoing, last_auto_save):
1943 (read_key_sequence_cmd, dribble, recursive_edit_unwind):
1944 (command_loop, echo_now, keyboard_init_hook, help_char_p):
1945 (quit_throw_to_read_char, command_loop_2, top_level_1, poll_timer):
1946 (Vlispy_mouse_stem, double_click_count):
1947 Now static.
1948 (force_auto_save_soon): Define only if SIGDANGER.
1949 (ignore_mouse_drag_p): Now static if
1950 !defined HAVE_WINDOW_SYSTEM || defined USE_GTK || defined HAVE_NS.
1951 (print_help): Remove; unused.
1952 (stop_character, last_timer_event): Mark as externally visible.
1953 * keyboard.h (ignore_mouse_drag_p): Declare only if
1954 defined HAVE_WINDOW_SYSTEM && !defined USE_GTK && !defined HAVE_NS.
1955 (echo_now, help_char_p, quit_throw_to_read_char): Remove decls.
1956 * lisp.h (echoing): Remove decl.
1957 (force_auto_save_soon): Declare only if SIGDANGER.
1958 * xdisp.c (redisplay_window): Simplify code, to make it more
1959 obvious that ignore_mouse_drag_p is not accessed if !defined
1960 USE_GTK && !defined HAVE_NS.
1961
1962 * intervals.c: Make symbols static if they're not exported.
1963 (merge_properties_sticky, merge_interval_right, delete_interval):
1964 Now static.
1965 * intervals.h (merge_interval_right, delete_interval): Remove decls.
1966
1967 * insdel.c: Make symbols static if they're not exported.
1968 However, leave prepare_to_modify_buffer alone. It's never
1969 called from outside this function, but that appears to be a bug.
1970 (combine_after_change_list, combine_after_change_buffer):
1971 (adjust_after_replace, signal_before_change): Now static.
1972 (adjust_after_replace_noundo): Remove; unused.
1973 * lisp.h (adjust_after_replace, adjust_after_replace_noundo):
1974 (signal_before_change): Remove decls.
1975
1976 * indent.c (val_compute_motion, val_vmotion): Now static.
1977
1978 * image.c: Make symbols static if they're not exported.
1979 * dispextern.h (x_create_bitmap_from_xpm_data): Do not declare
1980 if USE_GTK.
1981 * image.c (x_create_bitmap_from_xpm_data): Do not define if USE_GTK.
1982 (xpm_color_cache, ct_table, ct_colors_allocated): Now static.
1983
1984 * fringe.c (standard_bitmaps): Now static.
1985 (max_used_fringe_bitmap): Now static, unless HAVE_NS.
1986
1987 * frame.c: Make symbols static if they're not exported.
1988 (x_report_frame_params, make_terminal_frame): Now static.
1989 (get_frame_param): Now static, unless HAVE_NS.
1990 (x_fullscreen_adjust): Define if WINDOWSNT, not if HAVE_WINDOW_SYSTEM.
1991 (x_get_resource_string): Remove; not used.
1992 * frame.h (make_terminal_frame, x_report_frame_params):
1993 (x_get_resource_string); Remove decls.
1994 (x_fullscreen_adjust): Declare only if WINDOWSNT.
1995 * lisp.h (get_frame_param): Declare only if HAVE_NS.
1996
1997 * font.c, fontset.c: Make symbols static if they're not exported.
1998 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): New macro.
1999 (FACE_SUITABLE_FOR_CHAR_P): Use it.
2000 * font.c (font_close_object): Now static.
2001 * font.h (font_close_object): Remove.
2002 * fontset.c (FONTSET_OBJLIST): Remove.
2003 (free_realized_fontset) #if-0 the body, which does nothing.
2004 (face_suitable_for_char_p): #if-0, as it's never called.
2005 * fontset.h (face_suitable_for_char_p): Remove decl.
2006 * xfaces.c (face_at_string_position):
2007 Use FACE_SUITABLE_FOR_ASCII_CHAR_P, not FACE_SUITABLE_FOR_CHAR_P,
2008 since 0 is always ASCII.
2009
2010 * fns.c (weak_hash_tables): Now static.
2011
2012 * fileio.c: Make symbols static if they're not exported.
2013 (auto_saving, auto_save_mode_bits, auto_save_error_occurred):
2014 (Vwrite_region_annotation_buffers): Now static.
2015
2016 * eval.c: Make symbols static if they're not exported.
2017 (backtrace_list, lisp_eval_depth, when_entered_debugger): Now static.
2018 * lisp.h (backtrace_list): Remove decl.
2019
2020 * emacs.c: Make symbols static if they're not exported.
2021 (malloc_state_ptr, malloc_using_checking, syms_of_emacs):
2022 (fatal_error_code, fatal_error_signal_hook, standard_args):
2023 Now static.
2024 (fatal_error_signal): Now static, unless FLOAT_CATCH_SIGKILL.
2025 (DEFINE_DUMMY_FUNCTION): Mark function as externally visible.
2026 (__CTOR_LIST__, __DTOR_LIST__): Now externally visible.
2027 * lisp.h (fatal_error_signal_hook): Remove decl.
2028 (fatal_error_signal): Declare only if FLOAT_CATCH_SIGKILL.
2029
2030 * editfns.c: Move a (normally-unused) function to its only use.
2031 * editfns.c, lisp.h (get_operating_system_release): Remove.
2032 * process.c (init_process) [DARWIN_OS]: Do it inline, as it is not
2033 worth the hassle of breaking this out.
2034
2035 * xterm.c: Make symbols static if they're not exported.
2036 (x_raise_frame, x_lower_frame, x_wm_set_window_state):
2037 (x_wm_set_icon_pixmap, x_initialize, XTread_socket_fake_io_error):
2038 (x_destroy_window, x_delete_display):
2039 Now static.
2040 (x_dispatch_event): Now static if ! (USE_MOTIF || USE_X_TOOLKIT).
2041 (x_mouse_leave): Remove; unused.
2042 * xterm.h (x_display_info_for_name, x_raise_frame, x_lower_frame):
2043 (x_destroy_window, x_wm_set_window_state, x_wm_set_icon_pixmap):
2044 (x_delete_display, x_initialize, x_set_border_pixel, x_screen_planes):
2045 Remove decls.
2046 (x_mouse_leave): Declare only if WINDOWSNT.
2047 (x_dispatch_event): Declare only if USE_MOTIF or USE_X_TOOLKIT.
2048 (xic_create_fontsetname): Declare only if HAVE_X_WINDOWS &&
2049 USE_X_TOOLKIT.
2050
2051 * ftxfont.c: Make symbols static if they're not exported.
2052 (ftxfont_driver): Export only if !defined HAVE_XFT && def8ined
2053 HAVE_FREETYPE.
2054 * font.h (ftxfont_driver): Likewise.
2055
2056 * xfns.c: Make symbols static if they're not exported.
2057 (x_last_font_name, x_display_info_for_name):
2058 (x_set_foreground_color, x_set_background_color, x_set_mouse_color):
2059 (x_set_cursor_color, x_set_border_pixel, x_set_border_color):
2060 (x_set_cursor_type, x_set_icon_type, x_set_icon_name):
2061 (x_set_scroll_bar_foreground, x_set_scroll_bar_background):
2062 (x_explicitly_set_name, x_set_title, xic_defaut_fontset, tip_timer):
2063 (last_show_tip_args): Now static.
2064 (xic_defaut_fontset, xic_create_fontsetname): Define only if
2065 defined HAVE_X_WINDOWS && defined USE_X_TOOLKIT
2066 (x_screen_planes): Remove; unused.
2067 * dispextern.h (x_screen_planes): Remove decl.
2068
2069 * dispnew.c: Make symbols static if they're not exported.
2070 * dispextern.h (redraw_garbaged_frames, scrolling):
2071 (increment_row_positions): Remove.
2072 * dispnew.c (new_glyph_matrix, increment_row_positions, scrolling):
2073 (delayed_size_change, glyph_matrix_count, glyph_pool_count):
2074 Now static.
2075 (redraw_garbaged_frames): Remove; unused.
2076
2077 * xfaces.c: Make symbols static if they're not exported.
2078 * dispextern.h (ascii_face_of_lisp_face, free_realized_face):
2079 Remove decls.
2080 * xterm.h (defined_color): Remove decls.
2081 (x_free_dpy_colors): Declare only if USE_X_TOOLKIT.
2082 * xfaces.c (tty_suppress_bold_inverse_default_colors_p):
2083 (menu_face_changed_default, defined_color, free_realized_face):
2084 (x_free_dpy_colors): Define only if USE_X_TOOLKIT.
2085 (ascii_face_of_lisp_face): Remove; unused.
2086
2087 * xdisp.c: Make symbols static if they're not exported.
2088 * dispextern.h (scratch_glyph_row, window_box_edges):
2089 (glyph_to_pixel_coords, set_cursor_from_row):
2090 (get_next_display_element, set_iterator_to_next):
2091 (highlight_trailing_whitespace, frame_to_window_pixel_xy):
2092 (show_mouse_face): Remove decls
2093 * frame.h (message_buf_print): Likewise.
2094 * lisp.h (pop_message, set_message, check_point_in_composition):
2095 Likewise.
2096 * xterm.h (set_vertical_scroll_bar): Likewise.
2097 * xdisp.c (list_of_error, Vmessage_stack, line_number_displayed):
2098 (message_buf_print, scratch_glyph_row, displayed_buffer):
2099 (set_iterator_to_next, pop_message, set_message, set_cursor_from_row):
2100 (get_next_display_element, show_mouse_face, window_box_edges):
2101 (frame_to_window_pixel_xy, check_point_in_composition):
2102 (set_vertical_scroll_bar, highlight_trailing_whitespace): Now static.
2103 (glyph_to_pixel_coords): Remove; unused.
2104
2105 * dired.c (file_name_completion): Now static.
2106
2107 * dbusbind.c (xd_in_read_queued_messages): Now static.
2108
2109 * lisp.h (circular_list_error, FOREACH): Remove; unused.
2110 * data.c (circular_list_error): Remove.
2111
2112 * commands.h (last_point_position, last_point_position_buffer):
2113 (last_point_position_window): Remove decls.
2114 * keyboard.c: Make these variables static.
2115
2116 * coding.h (coding, code_convert_region, encode_coding_gap):
2117 Remove decls.
2118 * coding.c (Vsjis_coding_system, Vbig5_coding_system):
2119 (iso_code_class, detect_coding, code_convert_region): Now static.
2120 (encode_coding_gap): Remove; unused.
2121
2122 * chartab.c (chartab_chars, chartab_bits): Now static.
2123
2124 * charset.h (charset_iso_8859_1): Remove decl.
2125 * charset.c (charset_iso_8859_1, charset_emacs, map_charset_for_dump):
2126 Now static.
2127
2128 * ccl.h (check_ccl_update, Vccl_program_table): Remove decls.
2129 * ccl.c (Vccl_program_table): Now static.
2130 (check_ccl_update): Remove; unused.
2131
2132 * category.c (SET_CATEGORY_SET, set_category_set): Move here.
2133 * category.h: ... from here.
2134 * category.c (check_category_table, set_category_set): Now static.
2135
2136 * casetab.c (Vascii_upcase_table, Vascii_eqv_table): Now static.
2137 * lisp.h: Remove these decls.
2138
2139 * buffer.c (buffer_count): Remove unused var.
2140
2141 * bidi.c (bidi_dump_cached_states): Mark as externally visible,
2142 so that it's not optimized away.
2143 (bidi_ignore_explicit_marks_for_paragraph_level): Likewise.
2144 * dispextern.h (bidi_dump_cached_states): Remove, since it's
2145 exported only to the debugger.
2146
2147 * atimer.c (alarm_signal_handler, run_all_atimers): Now static.
2148 * atimer.h (run_all_atimers): Remove; not exported.
2149
2150 font.c: Make copy_font_spec and merge_font_spec ordinary C functions.
2151 * font.c (copy_font_spec): Rename from Fcopy_font_spec, since it
2152 was inaccessible from Lisp.
2153 (merge_font_spec): Likewise, renaming from Fmerge_font_spec.
2154 * font.c, font.h, fontset.c, xfaces.c, xfont.c: Change all uses.
2155
2156 alloc.c: Import and export fewer symbols, and remove unused items.
2157 * lisp.h (suppress_checking, die): Declare only if ENABLE_CHECKING
2158 is defined.
2159 (suppress_checking): Add EXTERNALLY_VISIBLE attribute, so that
2160 it's not optimized away by whole-program optimization.
2161 (message_enable_multibyte, free_misc): Remove.
2162 (catchlist, handlerlist, mark_backtrace):
2163 Declare only if BYTE_MARK_STACK.
2164 (mark_byte_stack): Likewise, fixing a ifdef-vs-if typo.
2165 * alloc.c (pure): Export only if VIRT_ADDR_VARIES is defined.
2166 (message_enable_multibyte): Remove decl.
2167 (free_misc, interval_free_list, float_block, float_block_index):
2168 (n_float_blocks, float_free_list, cons_block, cons_block_index):
2169 (cons_free_list, last_marked_index):
2170 Now static.
2171 (suppress_checking, die): Define only if ENABLE_CHECKING is defined.
2172 * eval.c (catchlist, handlerlist): Export only if BYTE_MARK_STACK.
2173 (mark_backtrace): Define only if BYTE_MARK_STACK.
2174 * xdisp.c (message_enable_multibyte): Now static.
2175
2176 Declare Lisp_Object Q* variables to be 'static' if not exported.
2177 This makes it easier for human readers (and static analyzers)
2178 to see whether these variables are used from other modules.
2179 * alloc.c, buffer.c, bytecode.c, callint.c, casetab.c, category.c:
2180 * ccl.c, character.c, charset.c, cmds.c, coding.c, composite.c:
2181 * data.c, dbusbind.c, dired.c, editfns.c, eval.c, fileio.c, fns.c:
2182 * font.c, frame.c, fringe.c, ftfont.c, image.c, keyboard.c, keymap.c:
2183 * lread.c, macros.c, minibuf.c, print.c, process.c, search.c:
2184 * sound.c, syntax.c, textprop.c, window.c, xdisp.c, xfaces.c, xfns.c:
2185 * xmenu.c, xselect.c:
2186 Declare Q* vars static if they are not used in other modules.
2187 * ccl.h, character.h, charset.h, coding.h, composite.h, font.h:
2188 * frame.h, intervals.h, keyboard.h, lisp.h, process.h, syntax.h:
2189 Remove decls of unexported vars.
2190 * keyboard.h (EVENT_HEAD_UNMODIFIED): Remove now-unused macro.
2191
2192 * lisp.h (DEFINE_FUNC): Make sname 'static'.
2193
2194 Make Emacs functions such as Fatom 'static' by default.
2195 This makes it easier for human readers (and static analyzers)
2196 to see whether these functions can be called from other modules.
2197 DEFUN now defines a static function. To make the function external
2198 so that it can be used in other C modules, use the new macro DEFUE.
2199 * lisp.h (Funibyte_char_to_multibyte, Fsyntax_table_p):
2200 (Finit_image_library):
2201 (Feval_region, Fbacktrace, Ffetch_bytecode, Fswitch_to_buffer):
2202 (Ffile_executable_p, Fmake_symbolic_link, Fcommand_execute):
2203 (Fget_process, Fdocumentation_property, Fbyte_code, Ffile_attributes):
2204 Remove decls, since these functions are now static.
2205 (Funintern, Fget_internal_run_time): New decls, since these functions
2206 were already external.
2207
2208 * alloc.c, buffer.c, callint.c, callproc.c, casefiddle.c, casetab.c:
2209 * ccl.c, character.c, chartab.c, cmds.c, coding.c, data.c, dispnew.c:
2210 * doc.c, editfns.c, emacs.c, eval.c, fileio.c, filelock.c, floatfns.c:
2211 * fns.c, font.c, fontset.c, frame.c, image.c, indent.c:
2212 * keyboard.c, keymap.c, lread.c:
2213 * macros.c, marker.c, menu.c, minibuf.c, print.c, process.c, search.c:
2214 * syntax.c, term.c, terminal.c, textprop.c, undo.c:
2215 * window.c, xdisp.c, xfaces.c, xfns.c, xmenu.c, xsettings.c:
2216 Mark functions with DEFUE instead of DEFUN,
2217 if they are used in other modules.
2218 * buffer.c (Fset_buffer_major_mode, Fdelete_overlay): New forward
2219 decls for now-static functions.
2220 * buffer.h (Fdelete_overlay): Remove decl.
2221 * callproc.c (Fgetenv_internal): Mark as internal.
2222 * composite.c (Fremove_list_of_text_properties): Remove decl.
2223 (Fcomposition_get_gstring): New forward static decl.
2224 * composite.h (Fcomposite_get_gstring): Remove decl.
2225 * dired.c (Ffile_attributes): New forward static decl.
2226 * doc.c (Fdocumntation_property): New forward static decl.
2227 * eval.c (Ffetch_bytecode): New forward static decl.
2228 (Funintern): Remove extern decl; now in .h file where it belongs.
2229 * fileio.c (Fmake_symbolic_link): New forward static decl.
2230 * image.c (Finit_image_library): New forward static decl.
2231 * insdel.c (Fcombine_after_change_execute): Make forward decl static.
2232 * intervals.h (Fprevious_property_change):
2233 (Fremove_list_of_text_properties): Remove decls.
2234 * keyboard.c (Fthis_command_keys): Remove decl.
2235 (Fcommand_execute): New forward static decl.
2236 * keymap.c (Flookup_key): New forward static decl.
2237 (Fcopy_keymap): Now static.
2238 * keymap.h (Flookup_key): Remove decl.
2239 * process.c (Fget_process): New forward static decl.
2240 (Fprocess_datagram_address): Mark as internal.
2241 * syntax.c (Fsyntax_table_p): New forward static decl.
2242 (skip_chars): Remove duplicate decl.
2243 * textprop.c (Fprevious_property_change): New forward static decl.
2244 * window.c (Fset_window_fringes, Fset_window_scroll_bars):
2245 Now internal.
2246 (Fset_window_margins, Fset_window_vscroll): New forward static decls.
2247 * window.h (Fset_window_vscroll, Fset_window_margins): Remove decls.
2248
2249 * editfns.c (Fformat): Remove unreachable code.
2250
2251 2011-04-14 Andreas Schwab <schwab@linux-m68k.org>
2252
2253 * fileio.c (Finsert_file_contents): Fix typo in 2005-05-13
2254 change. (Bug#8496)
2255
2256 2011-04-13 Eli Zaretskii <eliz@gnu.org>
2257
2258 * xdisp.c (handle_invisible_prop): Don't call bidi_paragraph_init
2259 when at ZV. (Bug#8487)
2260
2261 2011-04-12 Andreas Schwab <schwab@linux-m68k.org>
2262
2263 * charset.c (Fclear_charset_maps): Use xfree instead of free.
2264 (Bug#8437)
2265 * keyboard.c (parse_tool_bar_item): Likewise.
2266 * sound.c (sound_cleanup, alsa_close): Likewise.
2267 * termcap.c (tgetent): Likewise.
2268 * xfns.c (x_default_font_parameter): Likewise.
2269 * xsettings.c (read_and_apply_settings): Likewise.
2270
2271 * alloc.c (overrun_check_malloc, overrun_check_realloc)
2272 (overrun_check_free): Protoize.
2273
2274 2011-04-12 Paul Eggert <eggert@cs.ucla.edu>
2275
2276 * sysdep.c (emacs_read, emacs_write): Check for negative sizes
2277 since callers should never pass a negative size.
2278 Change the signature to match that of plain 'read' and 'write'; see
2279 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00397.html>.
2280 * lisp.h: Update prototypes of emacs_write and emacs_read.
2281
2282 2011-04-11 Eli Zaretskii <eliz@gnu.org>
2283
2284 * xdisp.c (redisplay_window): Don't try to determine the character
2285 position of the scroll margin if the window start point w->startp
2286 is outside the buffer's accessible region. (Bug#8468)
2287
2288 2011-04-10 Eli Zaretskii <eliz@gnu.org>
2289
2290 Fix write-region and its subroutines for buffers > 2GB.
2291 * fileio.c (a_write, e_write): Modify declaration of arguments and
2292 local variables to support buffers larger than 2GB.
2293 (Fcopy_file): Use EMACS_INT for return value of emacs_read.
2294
2295 * sysdep.c (emacs_write, emacs_read): Use ssize_t for last
2296 argument, local variables, and return value.
2297
2298 * lisp.h: Update prototypes of emacs_write and emacs_read.
2299
2300 * sound.c (vox_write): Use ssize_t for return value of emacs_write.
2301
2302 2011-04-10 Paul Eggert <eggert@cs.ucla.edu>
2303
2304 * xdisp.c (vmessage): Use memchr, not strnlen, which some hosts lack.
2305
2306 Fix more problems found by GCC 4.6.0's static checks.
2307
2308 * xdisp.c (vmessage): Use a better test for character truncation.
2309
2310 * charset.c (load_charset_map): <, not <=, for optimization,
2311 and to avoid potential problems with integer overflow.
2312 * chartab.c (sub_char_table_set_range, char_table_set_range): Likewise.
2313 * casetab.c (set_identity, shuffle): Likewise.
2314 * editfns.c (Fformat): Likewise.
2315 * syntax.c (skip_chars): Likewise.
2316
2317 * xmenu.c (set_frame_menubar): Allocate smaller local vectors.
2318 This also lets GCC 4.6.0 generate slightly better loop code.
2319
2320 * callint.c (Fcall_interactively): <, not <=, for optimization.
2321 (Fcall_interactively): Count the number of arguments produced,
2322 not the number of arguments given. This is simpler and lets GCC
2323 4.6.0 generate slightly better code.
2324
2325 * ftfont.c: Distingish more carefully between FcChar8 and char.
2326 The previous code passed unsigned char * to a functions like
2327 strlen and xstrcasecmp that expect char *, which does not
2328 conform to the C standard.
2329 (get_adstyle_property, ftfont_pattern_entity): Use FcChar8 for
2330 arguments to FcPatternGetString, and explicitly cast FcChar8 * to
2331 char * when the C standard requires it.
2332
2333 * keyboard.c (read_char): Remove unused var.
2334
2335 * eval.c: Port to Windows vsnprintf (Bug#8435).
2336 Include <limits.h>.
2337 (SIZE_MAX): Define if the headers do not.
2338 (verror): Do not give up if vsnprintf returns a negative count.
2339 Instead, grow the buffer. This ports to Windows vsnprintf, which
2340 does not conform to C99. Problem reported by Eli Zaretskii.
2341 Also, simplify the allocation scheme, by avoiding the need for
2342 calling realloc, and removing the ALLOCATED variable.
2343
2344 * eval.c (verror): Initial buffer size is 4000 (not 200) bytes.
2345
2346 Remove invocations of doprnt, as Emacs now uses vsnprintf.
2347 But keep the doprint source code for now, as we might revamp it
2348 and use it again (Bug#8435).
2349 * lisp.h (doprnt): Remove.
2350 * Makefile.in (base_obj): Remove doprnt.o.
2351 * deps.mk (doprnt.o): Remove.
2352
2353 error: Print 32- and 64-bit integers portably (Bug#8435).
2354 Without this change, on typical 64-bit hosts error ("...%d...", N)
2355 was used to print both 32- and 64-bit integers N, which relied on
2356 undefined behavior.
2357 * lisp.h, src/m/amdx86-64.h, src/m/ia64.h, src/m/ibms390x.h (pEd):
2358 New macro.
2359 * lisp.h (error, verror): Mark as printf-like functions.
2360 * eval.c (verror): Use vsnprintf, not doprnt, to do the real work.
2361 Report overflow in size calculations when allocating printf buffer.
2362 Do not truncate output string at its first null byte.
2363 * xdisp.c (vmessage): Use vsnprintf, not doprnt, to do the real work.
2364 Truncate the output at a character boundary, since vsnprintf does not
2365 do that.
2366 * charset.c (check_iso_charset_parameter): Convert internal
2367 character to string before calling 'error', since %c now has the
2368 printf meaning.
2369 * coding.c (Fdecode_sjis_char, Fdecode_big5_char): Avoid int
2370 overflow when computing char to be passed to 'error'. Do not
2371 pass Lisp_Object to 'error'; pass the integer instead.
2372 * nsfns.m (Fns_do_applescript): Use int, not long, since it's
2373 formatted with plain %d.
2374
2375 * eval.c (internal_lisp_condition_case): Don't pass spurious arg.
2376
2377 * keyboard.c (access_keymap_keyremap): Print func name, not garbage.
2378
2379 * coding.c (Fdecode_sjis_char): Don't assume CODE fits in int.
2380
2381 * xterm.c (x_catch_errors): Remove duplicate declaration.
2382
2383 * term.c (maybe_fatal): Mark its 3rd arg as a printf format, too.
2384
2385 * xdisp.c, lisp.h (message_nolog): Remove; unused.
2386
2387 2011-04-10 Jim Meyering <meyering@redhat.com>
2388
2389 use ssize_t and size_t for read- and write-like emacs_gnutls_* functions
2390 * gnutls.c (emacs_gnutls_read): Adjust signature to be more read-like:
2391 return ssize_t not "int", and use size_t as the buffer length.
2392 (emacs_gnutls_write): Likewise, and make the buffer pointer "const".
2393 * gnutls.h: Update declarations.
2394 * process.c (read_process_output): Use ssize_t, to match.
2395 (send_process): Likewise.
2396
2397 2011-04-09 Chong Yidong <cyd@stupidchicken.com>
2398
2399 * image.c (Fimagemagick_types): Doc fix, and comment cleanup.
2400
2401 2011-04-09 Chong Yidong <cyd@stupidchicken.com>
2402
2403 * ftfont.c (get_adstyle_property, ftfont_pattern_entity):
2404 Use unsigned char, to match FcChar8 type definition.
2405
2406 * xterm.c (handle_one_xevent):
2407 * xmenu.c (create_and_show_popup_menu):
2408 * xselect.c (x_decline_selection_request)
2409 (x_reply_selection_request): Avoid type-punned deref of X events.
2410
2411 2011-04-09 Eli Zaretskii <eliz@gnu.org>
2412
2413 Fix some uses of `int' instead of EMACS_INT.
2414 * search.c (string_match_1, fast_string_match)
2415 (fast_c_string_match_ignore_case, fast_string_match_ignore_case)
2416 (scan_buffer, find_next_newline_no_quit)
2417 (find_before_next_newline, search_command, Freplace_match)
2418 (Fmatch_data): Make some `int' variables be EMACS_INT.
2419
2420 * xdisp.c (display_count_lines): 3rd argument and return value now
2421 EMACS_INT. All callers changed.
2422 (pint2hrstr): Last argument is now EMACS_INT.
2423
2424 * coding.c (detect_coding_utf_8, detect_coding_emacs_mule)
2425 (detect_coding_iso_2022, detect_coding_sjis, detect_coding_big5)
2426 (detect_coding_ccl, detect_coding_charset, decode_coding_utf_8)
2427 (decode_coding_utf_16, decode_coding_emacs_mule)
2428 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5)
2429 (decode_coding_ccl, decode_coding_charset)
2430 <consumed_chars, consumed_chars_base>: Declare EMACS_INT.
2431 (decode_coding_iso_2022, decode_coding_emacs_mule)
2432 (decode_coding_sjis, decode_coding_big5, decode_coding_charset)
2433 <char_offset, last_offset>: Declare EMACS_INT.
2434 (encode_coding_utf_8, encode_coding_utf_16)
2435 (encode_coding_emacs_mule, encode_invocation_designation)
2436 (encode_designation_at_bol, encode_coding_iso_2022)
2437 (encode_coding_sjis, encode_coding_big5, encode_coding_ccl)
2438 (encode_coding_raw_text, encode_coding_charset) <produced_chars>:
2439 Declare EMACS_INT.
2440 (ASSURE_DESTINATION): Declare more_bytes EMACS_INT.
2441 (encode_invocation_designation): Last argument P_NCHARS is now
2442 EMACS_INT.
2443 (decode_eol): Declare pos_byte, pos, and pos_end EMACS_INT.
2444 (produce_chars): from_nchars and to_nchars are now EMACS_INT.
2445
2446 * coding.h (struct coding_system) <head_ascii>: Declare EMACS_INT.
2447 All users changed.
2448
2449 * ccl.c (Fccl_execute_on_string): Declare some variables
2450 EMACS_INT.
2451
2452 2011-04-08 Samuel Thibault <sthibault@debian.org> (tiny change)
2453
2454 * term.c (init_tty): Fix incorrect ifdef placement (Bug#8450).
2455
2456 2011-03-19 Christoph Scholtes <cschol2112@googlemail.com>
2457
2458 * process.c (Fformat_network_address): Doc fix.
2459
2460 2011-04-08 T.V. Raman <tv.raman.tv@gmail.com> (tiny change)
2461
2462 * xml.c (parse_region): Avoid creating spurious whiespace nodes.
2463
2464 2011-04-08 Chong Yidong <cyd@stupidchicken.com>
2465
2466 * keyboard.c (read_char): Call Lisp function help-form-show,
2467 instead of using internal_with_output_to_temp_buffer.
2468 (Qhelp_form_show): New var.
2469 (syms_of_keyboard): Use DEFSYM macro.
2470
2471 * print.c (internal_with_output_to_temp_buffer): Function deleted.
2472
2473 * lisp.h (internal_with_output_to_temp_buffer): Remove prototype.
2474
2475 2011-04-06 Chong Yidong <cyd@stupidchicken.com>
2476
2477 * process.c (Flist_processes): Remove to Lisp.
2478 (list_processes_1): Delete.
2479
2480 2011-04-06 Eli Zaretskii <eliz@gnu.org>
2481
2482 * msdos.c (careadlinkat, careadlinkatcwd): MS-DOS replacements.
2483
2484 * w32.c (careadlinkat, careadlinkatcwd): New always-fail stubs.
2485
2486 2011-04-06 Paul Eggert <eggert@cs.ucla.edu>
2487
2488 Fix more problems found by GCC 4.6.0's static checks.
2489
2490 * xmenu.c (Fx_popup_dialog): Don't assume string is free of formats.
2491
2492 * menu.c (Fx_popup_menu): Don't assume error_name lacks printf formats.
2493
2494 * lisp.h (message, message_nolog, fatal): Mark as printf-like.
2495
2496 * xdisp.c (vmessage): Mark as a printf-like function.
2497
2498 * term.c (vfatal, maybe_fatal): Mark as printf-like functions.
2499
2500 * sound.c (sound_warning): Don't crash if arg contains a printf format.
2501
2502 * image.c (tiff_error_handler, tiff_warning_handler): Mark as
2503 printf-like functions.
2504 (tiff_load): Add casts to remove these marks before passing them
2505 to system-supplied API.
2506
2507 * eval.c (Fsignal): Remove excess argument to 'fatal'.
2508
2509 * coding.c (EMIT_ONE_BYTE, EMIT_TWO_BYTES): Use unsigned, not int.
2510 This avoids several warnings with gcc -Wstrict-overflow.
2511 (DECODE_COMPOSITION_RULE): If the rule is invalid, goto invalid_code
2512 directly, rather than having caller test rule sign. This avoids
2513 some unnecessary tests.
2514 * composite.h (COMPOSITION_ENCODE_RULE_VALID): New macro.
2515 (COMPOSITION_ENCODE_RULE): Arguments now must be valid. This
2516 affects only one use, in DECODE_COMPOSITION_RULE, which is changed.
2517
2518 * xfont.c (xfont_text_extents): Remove var that was set but not used.
2519 (xfont_open): Avoid unnecessary tests.
2520
2521 * composite.c (composition_gstring_put_cache): Use unsigned integer.
2522
2523 * composite.h, composite.c (composition_gstring_put_cache):
2524 Use EMACS_INT, not int, for length.
2525
2526 * composite.h (COMPOSITION_DECODE_REFS): New macro,
2527 breaking out part of COMPOSITION_DECODE_RULE.
2528 (COMPOSITION_DECODE_RULE): Use it.
2529 * composite.c (get_composition_id): Remove unused local vars,
2530 by using the new macro.
2531
2532 * textprop.c (set_text_properties_1): Change while to do-while,
2533 since the condition is always true at first.
2534
2535 * intervals.c (graft_intervals_into_buffer): Mark var as used.
2536 (interval_deletion_adjustment): Return unsigned value.
2537 All uses changed.
2538
2539 * process.c (list_processes_1, create_pty, read_process_output):
2540 (exec_sentinel): Remove vars that were set but not used.
2541 (create_pty): Remove unnecessary "volatile"s.
2542 (Fnetwork_interface_info): Avoid possibility of int overflow.
2543 (read_process_output): Do adaptive read buffering even if carryover.
2544 (read_process_output): Simplify nbytes computation if buffered.
2545
2546 * bytecode.c (exec_byte_code): Rename local to avoid shadowing.
2547
2548 * syntax.c (scan_words): Remove var that was set but not used.
2549 (update_syntax_table): Use unsigned instead of int.
2550
2551 * lread.c (lisp_file_lexically_bound_p): Use ints rather than endptrs.
2552 (lisp_file_lexically_bound_p, read1): Use unsigned instead of int.
2553 (safe_to_load_p): Make the end-of-loop test the inverse of the in-loop.
2554
2555 * print.c (print_error_message): Avoid int overflow.
2556
2557 * font.c (font_list_entities): Redo for clarity,
2558 so that reader need not know FONT_DPI_INDEX + 1 == FONT_SPACING_INDEX.
2559
2560 * font.c (font_find_for_lface, Ffont_get_glyphs): Remove unused vars.
2561 (font_score): Avoid potential overflow in diff calculation.
2562
2563 * fns.c (substring_both): Remove var that is set but not used.
2564 (sxhash): Redo loop for clarity and to avoid wraparound warning.
2565
2566 * eval.c (funcall_lambda): Rename local to avoid shadowing.
2567
2568 * alloc.c (mark_object_loop_halt, mark_object): Use size_t, not int.
2569 Otherwise, GCC 4.6.0 optimizes the loop check away since the check
2570 can always succeed if overflow has undefined behavior.
2571
2572 * search.c (boyer_moore, wordify): Remove vars set but not used.
2573 (wordify): Omit three unnecessary tests.
2574
2575 * indent.c (MULTIBYTE_BYTES_WIDTH): Don't compute wide_column.
2576 All callers changed. This avoids the need for an unused var.
2577
2578 * casefiddle.c (casify_region): Remove var that is set but not used.
2579
2580 * dired.c (file_name_completion): Remove var that is set but not used.
2581
2582 * fileio.c (Finsert_file_contents): Make EOF condition clearer.
2583
2584 * fileio.c (Finsert_file_contents): Avoid signed integer overflow.
2585 (Finsert_file_contents): Remove unnecessary code checking fd.
2586
2587 * minibuf.c (read_minibuf_noninteractive): Use size_t for sizes.
2588 Check for integer overflow on size calculations.
2589
2590 * buffer.c (Fprevious_overlay_change): Remove var that is set
2591 but not used.
2592
2593 * keyboard.c (menu_bar_items, read_char_minibuf_menu_prompt):
2594 Remove vars that are set but not used.
2595 (timer_check_2): Don't assume timer-list and idle-timer-list are lists.
2596 (timer_check_2): Mark vars as initialized.
2597
2598 * gtkutil.c (xg_get_file_with_chooser): Mark var as initialized.
2599
2600 * image.c (lookup_image): Remove var that is set but not used.
2601 (xbm_load): Use parse_p, for gcc -Werror=unused-but-set-variable.
2602
2603 * fontset.c (Finternal_char_font, Ffontset_info): Remove vars
2604 that are set but not used.
2605
2606 * xfns.c (make_invisible_cursor): Don't return garbage
2607 if XCreateBitmapFromData fails (Bug#8410).
2608
2609 * xselect.c (x_get_local_selection, x_handle_property_notify):
2610 Remove vars that are set but not used.
2611
2612 * xfns.c (x_create_tip_frame): Remove var that is set but not used.
2613 (make_invisible_cursor): Initialize a possibly-uninitialized variable.
2614
2615 * xterm.c (x_scroll_bar_to_input_event) [!USE_GTK]:
2616 Remove var that is set but not used.
2617 (scroll_bar_windows_size): Now size_t, not int.
2618 (x_send_scroll_bar_event): Use size_t, not int, for sizes.
2619 Check for overflow.
2620
2621 * xfaces.c (realize_named_face): Remove vars that are set but not used.
2622 (map_tty_color) [!defined MSDOS]: Likewise.
2623
2624 * term.c (tty_write_glyphs): Use size_t; this avoids overflow warning.
2625
2626 * coding.c: Remove vars that are set but not used.
2627 (DECODE_COMPOSITION_RULE): Remove 2nd arg, which is unused.
2628 All callers changed.
2629 (decode_coding_utf_8, decode_coding_utf_16 decode_coding_emacs_mule):
2630 (decode_coding_iso_2022, encode_coding_sjis, encode_coding_big5):
2631 (decode_coding_charset): Remove vars that are set but not used.
2632
2633 * bytecode.c (Fbyte_code) [!defined BYTE_CODE_SAFE]: Remove var
2634 that is set but not used.
2635
2636 * print.c (print_object): Remove var that is set but not used.
2637
2638 Replace 2 copies of readlink code with 1 gnulib version (Bug#8401).
2639 The gnulib version avoids calling malloc in the usual case,
2640 and on 64-bit hosts doesn't have some arbitrary 32-bit limits.
2641 * fileio.c (Ffile_symlink_p): Use emacs_readlink.
2642 * filelock.c (current_lock_owner): Likewise.
2643 * lisp.h (READLINK_BUFSIZE, emacs_readlink): New function.
2644 * sysdep.c: Include allocator.h, careadlinkat.h.
2645 (emacs_no_realloc_allocator): New static constant.
2646 (emacs_readlink): New function.
2647 * deps.mk (sysdep.o): Depend on ../lib/allocator.h and on
2648 ../lib/careadlinkat.h.
2649
2650 2011-04-04 Stefan Monnier <monnier@iro.umontreal.ca>
2651
2652 * keyboard.c (safe_run_hook_funcall): Fix last change (don't stop at the
2653 first non-nil return value).
2654
2655 2011-04-03 Jan Djärv <jan.h.d@swipnet.se>
2656
2657 * nsterm.m (ns_update_auto_hide_menu_bar): Define MAC_OS_X_VERSION_10_6
2658 if not defined (Bug#8403).
2659
2660 2011-04-02 Juanma Barranquero <lekktu@gmail.com>
2661
2662 * xdisp.c (display_count_lines): Remove parameter `start',
2663 unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
2664 (get_char_face_and_encoding): Remove parameter `multibyte_p',
2665 unused since 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
2666 (fill_stretch_glyph_string): Remove parameters `row' and `area',
2667 unused at least since Kim's GUI unification at 2003-03-16T20:45:46Z!storm@cua.dk
2668 and thereabouts. All callers changed.
2669 (get_per_char_metric): Remove parameter `f', unused since
2670 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
2671
2672 2011-04-02 Jim Meyering <meyering@redhat.com>
2673
2674 do not dereference NULL upon failed strdup
2675 * nsfont.m (ns_descriptor_to_entity): Use xstrdup, not strdup.
2676 (ns_get_family): Likewise.
2677
2678 2011-04-02 Juanma Barranquero <lekktu@gmail.com>
2679
2680 * eval.c (unwind_to_catch) [DEBUG_GCPRO]: Remove redundant assignment.
2681
2682 2011-04-02 Jan Djärv <jan.h.d@swipnet.se>
2683
2684 * nsterm.m (ns_update_auto_hide_menu_bar): Only for OSX 10.6 or
2685 later (Bug#8403).
2686
2687 2011-04-01 Stefan Monnier <monnier@iro.umontreal.ca>
2688
2689 Add lexical binding.
2690
2691 * window.c (Ftemp_output_buffer_show): New fun.
2692 (Fsave_window_excursion):
2693 * print.c (Fwith_output_to_temp_buffer): Move to subr.el.
2694
2695 * lread.c (lisp_file_lexically_bound_p): New function.
2696 (Fload): Bind Qlexical_binding.
2697 (readevalloop): Remove `evalfun' arg.
2698 Bind Qinternal_interpreter_environment.
2699 (Feval_buffer): Bind Qlexical_binding.
2700 (defvar_int, defvar_bool, defvar_lisp_nopro, defvar_kboard):
2701 Mark as dynamic.
2702 (syms_of_lread): Declare `lexical-binding'.
2703
2704 * lisp.h (struct Lisp_Symbol): New field `declared_special'.
2705
2706 * keyboard.c (eval_dyn): New fun.
2707 (menu_item_eval_property): Use it.
2708
2709 * image.c (parse_image_spec): Use Ffunctionp.
2710
2711 * fns.c (concat, mapcar1): Accept byte-code-functions.
2712
2713 * eval.c (Fsetq): Handle lexical vars.
2714 (Fdefun, Fdefmacro, Ffunction): Make closures when needed.
2715 (Fdefconst, Fdefvaralias, Fdefvar): Mark as dynamic.
2716 (FletX, Flet): Obey lexical binding.
2717 (Fcommandp): Handle closures.
2718 (Feval): New `lexical' arg.
2719 (eval_sub): New function extracted from Feval. Use it almost
2720 everywhere where Feval was used. Look up vars in lexical env.
2721 Handle closures.
2722 (Ffunctionp): Move from subr.el.
2723 (Ffuncall): Handle closures.
2724 (apply_lambda): Remove `eval_flags'.
2725 (funcall_lambda): Handle closures and new byte-code-functions.
2726 (Fspecial_variable_p): New function.
2727 (syms_of_eval): Initialize the Vinternal_interpreter_environment var,
2728 but without exporting it to Lisp.
2729
2730 * doc.c (Fdocumentation, store_function_docstring):
2731 * data.c (Finteractive_form): Handle closures.
2732
2733 * callint.c (Fcall_interactively): Preserve lexical-binding mode for
2734 interactive spec.
2735
2736 * bytecode.c (Bstack_ref, Bstack_set, Bstack_set2, BdiscardN):
2737 New byte-codes.
2738 (exec_byte_code): New function extracted from Fbyte_code to handle new
2739 calling convention for byte-code-functions. Add new byte-codes.
2740
2741 * buffer.c (defvar_per_buffer): Set new `declared_special' field.
2742
2743 * alloc.c (Fmake_symbol): Init new `declared_special' field.
2744
2745 2011-03-31 Juanma Barranquero <lekktu@gmail.com>
2746
2747 * xdisp.c (redisplay_internal): Fix prototype.
2748
2749 2011-03-31 Eli Zaretskii <eliz@gnu.org>
2750
2751 * xdisp.c (SCROLL_LIMIT): New macro.
2752 (try_scrolling): Use it when setting scroll_limit.
2753 Limit scrolling to 100 screen lines.
2754 (redisplay_window): Even when falling back on "recentering",
2755 position point in the window according to scroll-conservatively,
2756 scroll-margin, and scroll-*-aggressively variables. (Bug#6671)
2757
2758 (try_scrolling): When point is above the window, allow searching
2759 as far as scroll_max, or one screenful, to compute vertical
2760 distance from PT to the scroll margin position. This prevents
2761 try_scrolling from unnecessarily failing when
2762 scroll-conservatively is set to a value slightly larger than the
2763 window height. Clean up the case of PT below the margin at bottom
2764 of window: scroll_max can no longer be INT_MAX. When aggressive
2765 scrolling is in use, don't let point enter the opposite scroll
2766 margin as result of the scroll.
2767 (syms_of_xdisp) <scroll-conservatively>: Document the
2768 threshold of 100 lines for never-recentering scrolling.
2769
2770 2011-03-31 Juanma Barranquero <lekktu@gmail.com>
2771
2772 * dispextern.h (move_it_by_lines):
2773 * xdisp.c (move_it_by_lines): Remove parameter `need_y_p', unused
2774 since 2000-12-29T14:24:09Z!gerd@gnu.org. All callers changed.
2775 (message_log_check_duplicate): Remove parameters `prev_bol' and
2776 `this_bol', unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
2777 (redisplay_internal): Remove parameter `preserve_echo_area',
2778 unused since 1999-07-21T21:43:52Z!gerd@gnu.org. All callers changed.
2779
2780 * indent.c (Fvertical_motion):
2781 * window.c (window_scroll_pixel_based, Frecenter):
2782 Don't pass `need_y_p' to `move_it_by_lines'.
2783
2784 2011-03-30 Stefan Monnier <monnier@iro.umontreal.ca>
2785
2786 * eval.c (struct backtrace): Don't cheat with negative numbers, but do
2787 steal a few bits to be more compact.
2788 (interactive_p, Fbacktrace, Fbacktrace_frame, mark_backtrace):
2789 Remove unneeded casts.
2790
2791 * bytecode.c (Fbyte_code): CAR and CDR can GC.
2792
2793 2011-03-30 Zachary Kanfer <zkanfer@gmail.com> (tiny change)
2794
2795 * keyboard.c (Fexecute_extended_command): Do log the "suggest key
2796 binding" message (bug#7967).
2797
2798 2011-03-30 Paul Eggert <eggert@cs.ucla.edu>
2799
2800 Fix more problems found by GCC 4.6.0's static checks.
2801
2802 * unexelf.c (unexec) [! (defined _SYSTYPE_SYSV || defined __sgi)]:
2803 Remove unused local var.
2804
2805 * editfns.c (Fmessage_box): Remove unused local var.
2806
2807 * xdisp.c (try_window_reusing_current_matrix, x_produce_glyphs):
2808 (note_mode_line_or_margin_highlight, note_mouse_highlight):
2809 Omit unused local vars.
2810 * window.c (shrink_windows): Omit unused local var.
2811 * menu.c (digest_single_submenu): Omit unused local var.
2812 * dispnew.c (update_window) [PERIODIC_PREEMPTION_CHECKING]:
2813 Omit unused local var.
2814
2815 * keyboard.c (parse_modifiers_uncached, parse_modifiers):
2816 Don't assume string length fits in int.
2817 (keyremap_step, read_key_sequence): Use size_t for sizes.
2818 (read_key_sequence): Don't check last_real_key_start redundantly.
2819
2820 * callproc.c (Fcall_process, Fcall_process_region): Use SAFE_ALLOCA
2821 instead of alloca (Bug#8344).
2822
2823 * eval.c (Fbacktrace): Don't assume nargs fits in int.
2824 (Fbacktrace_frame): Don't assume nframes fits in int.
2825
2826 * syntax.c (scan_sexps_forward): Avoid pointer wraparound.
2827
2828 * xterm.c (x_make_frame_visible, same_x_server): Redo to avoid overflow
2829 concerns.
2830
2831 * term.c (produce_glyphless_glyph): Remove unnecessary test.
2832
2833 * cm.c (calccost): Turn while-do into do-while, for clarity.
2834
2835 * keyboard.c (syms_of_keyboard): Use the same style as later
2836 in this function when indexing through an array. This also
2837 works around GCC bug 48267.
2838
2839 * image.c (tiff_load): Fix off-by-one image count (Bug#8336).
2840
2841 * xselect.c (x_check_property_data): Return correct size (Bug#8335).
2842
2843 * chartab.c (sub_char_table_ref_and_range): Redo for slight
2844 efficiency gain, and to bypass a gcc -Wstrict-overflow warning.
2845
2846 * keyboard.c, keyboard.h (num_input_events): Now size_t.
2847 This avoids undefined behavior on integer overflow, and is a bit
2848 more convenient anyway since it is compared to a size_t variable.
2849
2850 Variadic C functions now count arguments with size_t, not int.
2851 This avoids an unnecessary limitation on 64-bit machines, which
2852 caused (substring ...) to crash on large vectors (Bug#8344).
2853 * lisp.h (struct Lisp_Subr.function.aMANY): Now takes size_t, not int.
2854 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call): Likewise.
2855 All variadic functions and their callers changed accordingly.
2856 (struct gcpro.nvars): Now size_t, not int. All uses changed.
2857 * data.c (arith_driver, float_arith_driver): Likewise.
2858 * editfns.c (general_insert_function): Likewise.
2859 * eval.c (struct backtrace.nargs, interactive_p)
2860 (internal_condition_case_n, run_hook_with_args, apply_lambda)
2861 (funcall_lambda, mark_backtrace): Likewise.
2862 * fns.c (concat): Likewise.
2863 * frame.c (x_set_frame_parameters): Likewise.
2864 * fns.c (get_key_arg): Now accepts and returns size_t, and returns
2865 0 if not found, not -1. All callers changed.
2866
2867 * alloc.c (garbage_collect): Don't assume stack size fits in int.
2868 (stack_copy_size): Now size_t, not int.
2869 (stack_copy, stack_copy_size): Define only if MAX_SAVE_STACK > 0.
2870
2871 2011-03-28 Juanma Barranquero <lekktu@gmail.com>
2872
2873 * coding.c (encode_designation_at_bol): Remove parameter `charbuf_end',
2874 unused since 2002-03-01T01:17:24Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
2875 All callers changed.
2876
2877 * lisp.h (multibyte_char_to_unibyte):
2878 * character.c (multibyte_char_to_unibyte): Remove parameter `rev_tbl',
2879 unused since 2002-03-01T01:16:34Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
2880 * character.h (CHAR_TO_BYTE8):
2881 * cmds.c (internal_self_insert):
2882 * editfns.c (general_insert_function):
2883 * keymap.c (push_key_description):
2884 * search.c (Freplace_match):
2885 * xdisp.c (message_dolog, set_message_1): All callers changed.
2886
2887 2011-03-28 Stefan Monnier <monnier@iro.umontreal.ca>
2888
2889 * keyboard.c (safe_run_hook_funcall): New function.
2890 (safe_run_hooks_1, safe_run_hooks_error, safe_run_hooks): On error,
2891 don't set the hook to nil, but remove the offending function instead.
2892 (Qcommand_hook_internal): Remove, unused.
2893 (syms_of_keyboard): Don't initialize Qcommand_hook_internal nor define
2894 Vcommand_hook_internal.
2895
2896 * eval.c (enum run_hooks_condition): Remove.
2897 (funcall_nil, funcall_not): New functions.
2898 (run_hook_with_args): Call each function through a `funcall' argument.
2899 Remove `cond' argument, now redundant.
2900 (Frun_hooks, Frun_hook_with_args, Frun_hook_with_args_until_success)
2901 (Frun_hook_with_args_until_failure): Adjust accordingly.
2902 (run_hook_wrapped_funcall, Frun_hook_wrapped): New functions.
2903
2904 2011-03-28 Juanma Barranquero <lekktu@gmail.com>
2905
2906 * dispextern.h (string_buffer_position): Remove declaration.
2907
2908 * print.c (strout): Remove parameter `multibyte', unused since
2909 1999-08-21T19:30:21Z!gerd@gnu.org. All callers changed.
2910
2911 * search.c (boyer_moore): Remove parameters `len', `pos' and `lim',
2912 never used since function introduction in 1998-02-08T21:33:56Z!rms@gnu.org.
2913 All callers changed.
2914
2915 * w32.c (_wsa_errlist): Use braces for struct initializers.
2916
2917 * xdisp.c (string_buffer_position_lim): Remove parameter `w',
2918 never used since function introduction in 2001-03-09T18:41:50Z!gerd@gnu.org.
2919 All callers changed.
2920 (string_buffer_position): Likewise. Also, make static (it's never
2921 used outside xdisp.c).
2922 (cursor_row_p): Remove parameter `w', unused since
2923 2000-10-17T16:08:57Z!gerd@gnu.org. All callers changed.
2924 (decode_mode_spec): Remove parameter `precision', introduced during
2925 Gerd Moellmann's rewrite at 1999-07-21T21:43:52Z!gerd@gnu.org, but never used.
2926 All callers changed.
2927
2928 2011-03-27 Jan Djärv <jan.h.d@swipnet.se>
2929
2930 * nsterm.m (syms_of_nsterm): Use doc: for ns-auto-hide-menu-bar.
2931
2932 2011-03-27 Anders Lindgren <andlind@gmail.com>
2933
2934 * nsterm.m (ns_menu_bar_is_hidden): New variable.
2935 (ns_constrain_all_frames, ns_menu_bar_should_be_hidden)
2936 (ns_update_auto_hide_menu_bar): New functions.
2937 (ns_update_begin): Call ns_update_auto_hide_menu_bar.
2938 (applicationDidBecomeActive): Call ns_update_auto_hide_menu_bar and
2939 ns_constrain_all_frames.
2940 (constrainFrameRect): Return at once if ns_menu_bar_should_be_hidden.
2941 (syms_of_nsterm): DEFVAR ns-auto-hide-menu-bar, init to Qnil.
2942
2943 2011-03-27 Jan Djärv <jan.h.d@swipnet.se>
2944
2945 * nsmenu.m (runDialogAt): Remove argument to timer_check.
2946
2947 2011-03-27 Glenn Morris <rgm@gnu.org>
2948
2949 * syssignal.h: Replace RETSIGTYPE with void.
2950 * atimer.c, data.c, dispnew.c, emacs.c, floatfns.c, keyboard.c:
2951 * keyboard.h, lisp.h, process.c, sysdep.c, xterm.c:
2952 Replace SIGTYPE with void everywhere.
2953 * s/usg5-4-common.h (SIGTYPE): Remove definition.
2954 * s/template.h (SIGTYPE): Remove commented out definition.
2955
2956 2011-03-26 Eli Zaretskii <eliz@gnu.org>
2957
2958 * xdisp.c (redisplay_window): Don't check buffer's clip_changed
2959 flag as a prerequisite for invoking try_scrolling. (Bug#6671)
2960
2961 2011-03-26 Juanma Barranquero <lekktu@gmail.com>
2962
2963 * w32.c (read_unc_volume): Use parameter `henum', instead of
2964 global variable `wget_enum_handle'.
2965
2966 * keymap.c (describe_vector): Remove parameters `indices' and
2967 `char_table_depth', unused since 2002-03-01T01:43:26Z!handa@m17n.org.
2968 (describe_map, Fdescribe_vector): Adjust calls to `describe_vector'.
2969
2970 * keyboard.h (timer_check, show_help_echo): Remove unused parameters.
2971
2972 * keyboard.c (timer_check): Remove parameter `do_it_now',
2973 unused since 1996-04-12T06:01:29Z!rms@gnu.org.
2974 (show_help_echo): Remove parameter `ok_to_overwrite_keystroke_echo',
2975 unused since 2008-04-19T19:30:53Z!monnier@iro.umontreal.ca.
2976
2977 * keyboard.c (read_char):
2978 * w32menu.c (w32_menu_display_help):
2979 * xmenu.c (show_help_event, menu_help_callback):
2980 Adjust calls to `show_help_echo'.
2981
2982 * gtkutil.c (xg_maybe_add_timer):
2983 * keyboard.c (readable_events):
2984 * process.c (wait_reading_process_output):
2985 * xmenu.c (x_menu_wait_for_event): Adjust calls to `timer_check'.
2986
2987 * insdel.c (adjust_markers_gap_motion):
2988 Remove; no-op since 1998-01-02T21:29:48Z!rms@gnu.org.
2989 (gap_left, gap_right): Don't call it.
2990
2991 2011-03-25 Chong Yidong <cyd@stupidchicken.com>
2992
2993 * xdisp.c (handle_fontified_prop): Discard changes to clip_changed
2994 incurred during fontification.
2995
2996 2011-03-25 Juanma Barranquero <lekktu@gmail.com>
2997
2998 * buffer.c (defvar_per_buffer): Remove unused parameter `doc'.
2999 (DEFVAR_PER_BUFFER): Don't pass it.
3000
3001 * dispnew.c (row_equal_p, add_row_entry): Remove unused parameter `w'.
3002 (scrolling_window): Don't pass it.
3003
3004 2011-03-25 Juanma Barranquero <lekktu@gmail.com>
3005
3006 * dispextern.h (glyph_matric): Use #if GLYPH_DEBUG, not #ifdef.
3007
3008 * fileio.c (check_executable) [DOS_NT]: Remove unused variables `len'
3009 and `suffix'.
3010 (Fset_file_selinux_context) [HAVE_LIBSELINUX]: Move here declaration
3011 of variables specific to SELinux and computation of `encoded_absname'.
3012
3013 * image.c (XPutPixel): Remove unused variable `height'.
3014
3015 * keyboard.c (make_lispy_event): Remove unused variable `hpos'.
3016
3017 * unexw32.c (get_section_info): Remove unused variable `section'.
3018
3019 * w32.c (stat): Remove unused variables `drive_root' and `devtype'.
3020 (system_process_attributes): Remove unused variable `sess'.
3021 (sys_read): Remove unused variable `err'.
3022
3023 * w32fns.c (top): Wrap variables with #if GLYPH_DEBUG, not #ifdef.
3024 (w32_wnd_proc): Remove unused variable `isdead'.
3025 (unwind_create_frame): Use #if GLYPH_DEBUG, not #ifdef.
3026 (Fx_server_max_request_size): Remove unused variable `dpyinfo'.
3027 (x_create_tip_frame): Remove unused variable `tem'.
3028
3029 * w32inevt.c (w32_console_read_socket):
3030 Remove unused variable `no_events'.
3031
3032 * w32term.c (x_draw_composite_glyph_string_foreground):
3033 Remove unused variable `width'.
3034
3035 2011-03-24 Juanma Barranquero <lekktu@gmail.com>
3036
3037 * w32term.c (x_set_glyph_string_clipping):
3038 Don't pass uninitialized region to CombineRgn.
3039
3040 2011-03-23 Juanma Barranquero <lekktu@gmail.com>
3041
3042 * w32fns.c (x_set_menu_bar_lines): Remove unused variable `olines'.
3043 (w32_wnd_proc): Pass NULL to Windows API, not uninitialized buffer.
3044 (Fx_close_connection): Remove unused variable `i'.
3045
3046 * w32font.c (w32font_draw): Return number of glyphs.
3047 (w32font_open_internal): Remove unused variable `i'.
3048 (w32font_driver): Add missing initializer.
3049
3050 * w32menu.c (utf8to16): Remove unused variable `utf16'.
3051 (fill_in_menu): Remove unused variable `items_added'.
3052
3053 * w32term.c (last_mouse_press_frame): Remove static global variable.
3054 (w32_clip_to_row): Remove unused variable `f'.
3055 (x_delete_terminal): Remove unused variable `i'.
3056
3057 * w32uniscribe.c (uniscribe_shape): Remove unused variable `nclusters'.
3058 (NOTHING): Remove unused static global variable.
3059 (uniscribe_check_otf): Remove unused variable `table'.
3060 (uniscribe_font_driver): Add missing initializers.
3061
3062 2011-03-23 Julien Danjou <julien@danjou.info>
3063
3064 * term.c (Fsuspend_tty, Fresume_tty):
3065 * minibuf.c (read_minibuf, run_exit_minibuf_hook):
3066 * window.c (temp_output_buffer_show):
3067 * insdel.c (signal_before_change):
3068 * frame.c (Fhandle_switch_frame):
3069 * fileio.c (Fdo_auto_save):
3070 * emacs.c (Fkill_emacs):
3071 * editfns.c (save_excursion_restore):
3072 * cmds.c (internal_self_insert):
3073 * callint.c (Fcall_interactively):
3074 * buffer.c (Fkill_all_local_variables):
3075 * keyboard.c (Fcommand_execute, Fsuspend_emacs, safe_run_hooks_1):
3076 Use Frun_hooks.
3077 (command_loop_1): Use Frun_hooks. Call safe_run_hooks
3078 unconditionnaly since it does the check itself.
3079
3080 2011-03-23 Paul Eggert <eggert@cs.ucla.edu>
3081
3082 Fix more problems found by GCC 4.5.2's static checks.
3083
3084 * coding.c (encode_coding_raw_text): Avoid unnecessary test
3085 the first time through the loop, since we know p0 < p1 then.
3086 This also avoids a gcc -Wstrict-overflow warning.
3087
3088 * lisp.h (SAFE_ALLOCA, SAFE_ALLOCA_LISP): Avoid 'int' overflow
3089 leading to a memory leak, possible in functions like
3090 load_charset_map_from_file that can allocate an unbounded number
3091 of objects (Bug#8318).
3092
3093 * xmenu.c (set_frame_menubar): Use EMACS_UINT, not int, for indexes
3094 that could (at least in theory) be that large.
3095
3096 * xdisp.c (message_log_check_duplicate): Return unsigned long, not int.
3097 This is less likely to overflow, and avoids undefined behavior if
3098 overflow does occur. All callers changed. Use strtoul to scan
3099 for the unsigned long integer.
3100 (pint2hrstr): Simplify and tune code slightly.
3101 This also avoids a (bogus) GCC warning with gcc -Wstrict-overflow.
3102
3103 * scroll.c (do_scrolling): Work around GCC bug 48228.
3104 See <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=48228>.
3105
3106 * frame.c (Fmodify_frame_parameters): Simplify loop counter.
3107 This also avoids a warning with gcc -Wstrict-overflow.
3108 (validate_x_resource_name): Simplify count usage.
3109 This also avoids a warning with gcc -Wstrict-overflow.
3110
3111 * fileio.c (Fcopy_file): Report error if fchown or fchmod
3112 fail (Bug#8306).
3113
3114 * emacs.c (Fdaemon_initialized): Do not ignore I/O errors (Bug#8303).
3115
3116 * process.c (Fmake_network_process): Use socklen_t, not int,
3117 where POSIX says socklen_t is required in portable programs.
3118 This fixes a porting bug on hosts like 64-bit HP-UX, where
3119 socklen_t is wider than int (Bug#8277).
3120 (Fmake_network_process, server_accept_connection):
3121 (wait_reading_process_output, read_process_output):
3122 Likewise.
3123
3124 * process.c: Rename or move locals to avoid shadowing.
3125 (list_processes_1, Fmake_network_process):
3126 (read_process_output_error_handler, exec_sentinel_error_handler):
3127 Rename or move locals.
3128 (Fmake_network_process): Define label "retry_connect" only if needed.
3129 (Fnetwork_interface_info): Fix pointer signedness.
3130 (process_send_signal): Add cast to avoid pointer signedness problem.
3131 (FIRST_PROC_DESC, IF_NON_BLOCKING_CONNECT): Remove unused macros.
3132 (create_process): Use 'volatile' to avoid vfork clobbering (Bug#8298).
3133
3134 Make tparam.h and terminfo.c consistent.
3135 * cm.c (tputs, tgoto, BC, UP): Remove extern decls.
3136 Include tparam.h instead, since it declares them.
3137 * cm.h (PC): Remove extern decl; tparam.h now does this.
3138 * deps.mk (cm.o, terminfo.o): Depend on tparam.h.
3139 * terminfo.c: Include tparam.h, to check interfaces.
3140 (tparm): Make 1st arg a const pointer in decl. Put it at top level.
3141 (tparam): Adjust signature to match interface in tparam.h;
3142 this removes some undefined behavior. Check that outstring and len
3143 are zero, which they always are with Emacs.
3144 * tparam.h (PC, BC, UP): New extern decls.
3145
3146 * xftfont.c (xftfont_shape): Now static, and defined only if needed.
3147 (xftfont_open): Rename locals to avoid shadowing.
3148
3149 * ftfont.c (ftfont_resolve_generic_family): Fix pointer signedness.
3150 (ftfont_otf_capability, ftfont_shape): Omit decls if not needed.
3151 (OTF_TAG_SYM): Omit macro if not needed.
3152 (ftfont_list): Remove unused local.
3153 (get_adstyle_property, ftfont_pattern_entity):
3154 (ftfont_lookup_cache, ftfont_open, ftfont_anchor_point):
3155 Rename locals to avoid shadowing.
3156
3157 * xfont.c (xfont_list_family): Mark var as initialized.
3158
3159 * xml.c (make_dom): Now static.
3160
3161 * composite.c (composition_compute_stop_pos): Rename local to
3162 avoid shadowing.
3163 (composition_reseat_it): Remove unused locals.
3164 (find_automatic_composition, composition_adjust_point): Likewise.
3165 (composition_update_it): Mark var as initialized.
3166 (find_automatic_composition): Mark vars as initialized,
3167 with a FIXME (Bug#8290).
3168
3169 character.h: Rename locals to avoid shadowing.
3170 * character.h (PREV_CHAR_BOUNDARY, FETCH_STRING_CHAR_ADVANCE):
3171 (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE, FETCH_CHAR_ADVANCE):
3172 (FETCH_CHAR_ADVANCE_NO_CHECK, INC_POS, DEC_POS, BUF_INC_POS):
3173 (BUF_DEC_POS): Be more systematic about renaming local temporaries
3174 to avoid shadowing.
3175
3176 * textprop.c (property_change_between_p): Remove; unused.
3177
3178 * intervals.c (interval_start_pos): Now static.
3179
3180 * intervals.h (CHECK_TOTAL_LENGTH): Avoid empty "else".
3181
3182 * atimer.c (start_atimer, append_atimer_lists, set_alarm):
3183 Rename locals to avoid shadowing.
3184
3185 * sound.c (wav_play, au_play, Fplay_sound_internal):
3186 Fix pointer signedness.
3187 (alsa_choose_format): Remove unused local var.
3188 (wav_play): Initialize a variable to 0, to prevent undefined
3189 behavior (Bug#8278).
3190
3191 * region-cache.c (insert_cache_boundary): Redo var to avoid shadowing.
3192
3193 * region-cache.h (pp_cache): New decl, for gcc -Wmissing-prototypes.
3194
3195 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork
3196 clobbering (Bug#8298).
3197 * sysdep.c (sys_subshell): Likewise.
3198 Previously, the sys_subshell 'volatile' was incorrectly IF_LINTted out.
3199
3200 * lisp.h (child_setup): Now NO_RETURN unless DOS_NT.
3201 This should get cleaned up, so that child_setup has the
3202 same signature on all platforms.
3203
3204 * callproc.c (call_process_cleanup): Now static.
3205 (relocate_fd): Rename locals to avoid shadowing.
3206
3207 2011-03-22 Chong Yidong <cyd@stupidchicken.com>
3208
3209 * xterm.c (x_clear_frame): Remove XClearWindow call. This appears
3210 not to be necessary, and produces flickering.
3211
3212 2011-03-20 Glenn Morris <rgm@gnu.org>
3213
3214 * config.in: Remove file.
3215
3216 2011-03-20 Juanma Barranquero <lekktu@gmail.com>
3217
3218 * minibuf.c (Vcompleting_read_function): Don't declare, global variables
3219 are now in src/globals.h.
3220 (syms_of_minibuf): Remove spurious & from previous change.
3221
3222 2011-03-20 Leo <sdl.web@gmail.com>
3223
3224 * minibuf.c (completing-read-function): New variable.
3225 (completing-read-default): Rename from completing-read.
3226 (completing-read): Call completing-read-function.
3227
3228 2011-03-19 Juanma Barranquero <lekktu@gmail.com>
3229
3230 * xfaces.c (Fx_load_color_file):
3231 Read color file from absolute filename (bug#8250).
3232
3233 2011-03-19 Juanma Barranquero <lekktu@gmail.com>
3234
3235 * makefile.w32-in: Update dependencies.
3236
3237 2011-03-17 Eli Zaretskii <eliz@gnu.org>
3238
3239 * makefile.w32-in ($(BLD)/unexw32.$(O)): Depend on $(SRC)/unexec.h.
3240
3241 2011-03-17 Paul Eggert <eggert@cs.ucla.edu>
3242
3243 Fix more problems found by GCC 4.5.2's static checks.
3244
3245 * process.c (make_serial_process_unwind, send_process_trap):
3246 (sigchld_handler): Now static.
3247
3248 * process.c (allocate_pty): Let PTY_ITERATION declare iteration vars.
3249 That way, the code declares only the vars that it needs.
3250 * s/aix4-2.h (PTY_ITERATION): Declare iteration vars.
3251 * s/cygwin.h (PTY_ITERATION): Likewise.
3252 * s/darwin.h (PTY_ITERATION): Likewise.
3253 * s/gnu-linux.h (PTY_ITERATION): Likewise.
3254
3255 * s/irix6-5.h (PTY_OPEN): Declare stb, to loosen coupling.
3256 * process.c (allocate_pty): Don't declare stb unless it's needed.
3257
3258 * bytecode.c (MAYBE_GC): Rewrite so as not to use empty "else".
3259 (CONSTANTLIM): Remove; unused.
3260 (METER_CODE, Bscan_buffer, Bread_char, Bset_mark):
3261 Define only if needed.
3262
3263 * unexelf.c (unexec): Name an expression,
3264 to avoid gcc -Wbad-function-cast warning.
3265 Use a different way to cause a compilation error if anyone uses
3266 n rather than nn, a way that does not involve shadowing.
3267 (ELF_BSS_SECTION_NAME, OLD_PROGRAM_H): Remove; unused.
3268
3269 * deps.mk (unexalpha.o): Remove; unused.
3270
3271 New file unexec.h, the (simple) interface for unexec (Bug#8267).
3272 * unexec.h: New file.
3273 * deps.mk (emacs.o, unexaix.o, unexcw.o, unexcoff.o, unexelf.o):
3274 (unexhp9k800.o, unexmacosx.o, unexsol.o, unexw32.o):
3275 Depend on unexec.h.
3276 * emacs.c [!defined CANNOT_DUMP]: Include unexec.h.
3277 * unexaix.c, unexcoff.c, unexcw.c, unexelf.c, unexhp9k800.c:
3278 * unexmacosx.c, unexsol.c, unexw32.c: Include unexec.h.
3279 Change as necessary to match prototype in unexec.h.
3280
3281 * syntax.c (Fforward_comment, scan_lists): Rename locals to avoid
3282 shadowing.
3283 (back_comment, skip_chars): Mark vars as initialized.
3284
3285 * character.h (FETCH_STRING_CHAR_ADVANCE_NO_CHECK, BUF_INC_POS):
3286 Rename locals to avoid shadowing.
3287
3288 * lread.c (read1): Rewrite so as not to use empty "else".
3289 (Fload, readevalloop, read1): Rename locals to avoid shadowing.
3290
3291 * print.c (Fredirect_debugging_output): Fix pointer signedess.
3292
3293 * lisp.h (debug_output_compilation_hack): Add decl here, to avoid
3294 warning when compiling print.c.
3295
3296 * font.c (font_unparse_fcname): Abort in an "impossible" situation
3297 instead of using an uninitialized var.
3298 (font_sort_entities): Mark var as initialized.
3299
3300 * character.h (FETCH_CHAR_ADVANCE): Rename locals to avoid shadowing.
3301
3302 * font.c (font_unparse_xlfd): Don't mix pointers to variables with
3303 pointers to constants.
3304 (font_parse_fcname): Remove unused vars.
3305 (font_delete_unmatched): Now static.
3306 (font_get_spec): Remove; unused.
3307 (font_style_to_value, font_prop_validate_style, font_unparse_fcname):
3308 (font_update_drivers, Ffont_get_glyphs, font_add_log):
3309 Rename or move locals to avoid shadowing.
3310
3311 * fns.c (require_nesting_list, require_unwind): Now static.
3312 (Ffillarray): Rename locals to avoid shadowing.
3313
3314 * floatfns.c (domain_error2): Define only if needed.
3315 (Ffrexp, Fldexp): Rename locals to avoid shadowing.
3316
3317 * alloc.c (mark_backtrace): Move decl from here ...
3318 * lisp.h: ... to here, so that it can be checked.
3319
3320 * eval.c (call_debugger, do_debug_on_call, grow_specpdl): Now static.
3321 (Fdefvar): Rewrite so as not to use empty "else".
3322 (lisp_indirect_variable): Name an expression,
3323 to avoid gcc -Wbad-function-cast warning.
3324 (Fdefvar): Rename locals to avoid shadowing.
3325
3326 * callint.c (quotify_arg, quotify_args): Now static.
3327 (Fcall_interactively): Rename locals to avoid shadowing.
3328 Use const pointer when appropriate.
3329
3330 * lisp.h (get_system_name, get_operating_system_release):
3331 Move decls here, to check interfaces.
3332 * process.c (get_operating_system_release): Move decl to lisp.h.
3333 * xrdb.c (get_system_name): Likewise.
3334 * editfns.c (init_editfns, Fuser_login_name, Fuser_uid):
3335 (Fuser_real_uid, Fuser_full_name): Remove unnecessary casts,
3336 some of which prompt warnings from gcc -Wbad-function-cast.
3337 (Fformat_time_string, Fencode_time, Finsert_char):
3338 (Ftranslate_region_internal, Fformat):
3339 Rename or remove local vars to avoid shadowing.
3340 (Ftranslate_region_internal): Mark var as initialized.
3341
3342 * doc.c (Fdocumentation, Fsnarf_documentation): Move locals to
3343 avoid shadowing.
3344
3345 * lisp.h (eassert): Check that the argument compiles, even if
3346 ENABLE_CHECKING is not defined.
3347
3348 * data.c (Findirect_variable): Name an expression, to avoid
3349 gcc -Wbad-function-cast warning.
3350 (default_value, arithcompare, arith_driver, arith_error): Now static.
3351 (store_symval_forwarding): Rename local to avoid shadowing.
3352 (Fmake_variable_buffer_local, Fmake_local_variable):
3353 Mark variables as initialized.
3354 (do_blv_forwarding, do_symval_forwarding): Remove; unused.
3355
3356 * alloc.c (check_cons_list): Do not define unless GC_CHECK_CONS_LIST.
3357 (Fmake_vector, Fvector, Fmake_byte_code, Fgarbage_collect):
3358 Rename locals to avoid shadowing.
3359 (mark_stack): Move local variables into the #ifdef region where
3360 they're used.
3361 (BLOCK_INPUT_ALLOC, UNBLOCK_INPUT_ALLOC): Define only if
3362 ! defined SYSTEM_MALLOC && ! defined SYNC_INPUT, as they are not
3363 needed otherwise.
3364 (CHECK_ALLOCATED): Define only if GC_CHECK_MARKED_OBJECTS.
3365 (GC_STRING_CHARS): Remove; not used.
3366 (Fmemory_limit): Cast sbrk's returned value to char *.
3367
3368 * lisp.h (check_cons_list): Declare if GC_CHECK_CONS_LIST; this
3369 avoids undefined behavior in theory.
3370
3371 * regex.c (IF_LINT): Add defn, for benefit of ../lib-src.
3372
3373 Use functions, not macros, for up- and down-casing (Bug#8254).
3374 * buffer.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
3375 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Remove. All callers changed
3376 to use the following functions instead of these macros.
3377 (downcase): Adjust to lack of DOWNCASE_TABLE. Return int, not
3378 EMACS_INT, since callers assume the returned value fits in int.
3379 (upcase1): Likewise, for UPCASE_TABLE.
3380 (uppercasep, lowercasep, upcase): New static inline functions.
3381 * editfns.c (Fchar_equal): Remove no-longer-needed workaround for
3382 the race-condition problem in the old DOWNCASE.
3383
3384 * regex.c (CHARSET_LOOKUP_RANGE_TABLE_RAW, POP_FAILURE_REG_OR_COUNT):
3385 Rename locals to avoid shadowing.
3386 (regex_compile, re_match_2_internal): Move locals to avoid shadowing.
3387 (regex_compile, re_search_2, re_match_2_internal):
3388 Remove unused local vars.
3389 (FREE_VAR): Rewrite so as not to use empty "else",
3390 which gcc can warn about.
3391 (regex_compile, re_match_2_internal): Mark locals as initialized.
3392 (RETALLOC_IF): Define only if needed.
3393 (WORDCHAR_P): Likewise. This one is never needed, but is used
3394 only in a comment talking about a compiler bug, so put inside
3395 the #if 0 of that comment.
3396 (CHARSET_LOOKUP_BITMAP, FAIL_STACK_FULL, RESET_FAIL_STACK):
3397 (PUSH_FAILURE_ELT, BUF_PUSH_3, STOP_ADDR_VSTRING):
3398 Remove; unused.
3399
3400 * search.c (boyer_moore): Rename locals to avoid shadowing.
3401 * character.h (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE):
3402 (PREV_CHAR_BOUNDARY): Likewise.
3403
3404 * search.c (simple_search): Remove unused var.
3405
3406 * dired.c (compile_pattern): Move decl from here ...
3407 * lisp.h: ... to here, so that it can be checked.
3408 (struct re_registers): New forward decl.
3409
3410 * character.h (INC_POS, DEC_POS): Rename locals to avoid shadowing.
3411
3412 * indent.c (MULTIBYTE_BYTES_WIDTH): New args bytes, width.
3413 All uses changed.
3414 (MULTIBYTE_BYTES_WIDTH, scan_for_column, compute_motion):
3415 Rename locals to avoid shadowing.
3416 (Fvertical_motion): Mark locals as initialized.
3417
3418 * casefiddle.c (casify_object, casify_region): Now static.
3419 (casify_region): Mark local as initialized.
3420
3421 * cmds.c (internal_self_insert): Rename local to avoid shadowing.
3422
3423 * lisp.h (GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR, GCPRO5_VAR, GCPRO6_VAR):
3424 New macros, so that the caller can use some names other than
3425 gcpro1, gcpro2, etc.
3426 (GCPRO2, GCPRO3, GCPRO4, GCPRO5, GCPRO6): Reimplement in terms
3427 of the new macros.
3428 (GCPRO1_VAR, UNGCPRO_VAR): Change the meaning of the second
3429 argument, for consistency with GCPRO2_VAR, etc: it is now the
3430 prefix of the variable, not the variable itself. All uses
3431 changed.
3432 * dired.c (directory_files_internal, file_name_completion):
3433 Rename locals to avoid shadowing.
3434
3435 Fix a race condition diagnosed by gcc -Wsequence-point (Bug#8254).
3436 An expression of the form (DOWNCASE (x) == DOWNCASE (y)), found in
3437 dired.c's scmp function, had undefined behavior.
3438 * lisp.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
3439 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Move from here ...
3440 * buffer.h: ... to here, because these macros use current_buffer,
3441 and the new implementation with inline functions needs to have
3442 current_buffer in scope now, rather than later when the macros
3443 are used.
3444 (downcase, upcase1): New static inline functions.
3445 (DOWNCASE, UPCASE1): Reimplement using these functions.
3446 This avoids undefined behavior in expressions like
3447 DOWNCASE (x) == DOWNCASE (y), which previously suffered
3448 from race conditions in accessing the global variables
3449 case_temp1 and case_temp2.
3450 * casetab.c (case_temp1, case_temp2): Remove; no longer needed.
3451 * lisp.h (case_temp1, case_temp2): Remove their decls.
3452 * character.h (ASCII_CHAR_P): Move from here ...
3453 * lisp.h: ... to here, so that the inline functions mentioned
3454 above can use them.
3455
3456 * dired.c (directory_files_internal_unwind): Now static.
3457
3458 * fileio.c (file_name_as_directory, directory_file_name):
3459 (barf_or_query_if_file_exists, auto_save_error, auto_save_1):
3460 Now static.
3461 (file_name_as_directory): Use const pointers when appropriate.
3462 (Fexpand_file_name): Likewise. In particular, newdir might
3463 point at constant storage, so make it a const pointer.
3464 (Fmake_directory_internal, Fread_file_name): Remove unused vars.
3465 (Ffile_selinux_context, Fset_file_selinux_context): Fix pointer
3466 signedness issues.
3467 (Fset_file_times, Finsert_file_contents, auto_save_error):
3468 Rename locals to avoid shadowing.
3469
3470 * minibuf.c (choose_minibuf_frame_1): Now static.
3471 (Ftry_completion, Fall_completions): Rename or remove locals
3472 to avoid shadowing.
3473
3474 * marker.c (bytepos_to_charpos): Remove; unused.
3475
3476 * lisp.h (verify_bytepos, count_markers): New decls,
3477 so that gcc does not warn that these functions aren't declared.
3478
3479 * insdel.c (check_markers, make_gap_larger, make_gap_smaller):
3480 (reset_var_on_error, Fcombine_after_change_execute_1): Now static.
3481 (CHECK_MARKERS): Redo to avoid gcc -Wempty-body diagnostic.
3482 (copy_text): Remove unused local var.
3483
3484 * filelock.c (within_one_second): Now static.
3485 (lock_file_1): Rename local to avoid shadowing.
3486
3487 * buffer.c (fix_overlays_before): Mark locals as initialized.
3488 (fix_start_end_in_overlays): Likewise. This function should be
3489 simplified by using pointers-to-pointers, but that's a different
3490 matter.
3491 (switch_to_buffer_1): Now static.
3492 (Fkill_buffer, record_buffer, Fbury_buffer, Fset_buffer_multibyte):
3493 (report_overlay_modification): Rename locals to avoid shadowing.
3494
3495 * sysdep.c (system_process_attributes): Rename vars to avoid shadowing.
3496 Fix pointer signedness issue.
3497 (sys_subshell): Mark local as volatile if checking for lint,
3498 to suppress a gcc -Wclobbered warning that does not seem to be right.
3499 (MAXPATHLEN): Define only if needed.
3500
3501 * process.c (serial_open, serial_configure): Move decls from here ...
3502 * systty.h: ... to here, so that they can be checked.
3503
3504 * fns.c (get_random, seed_random): Move extern decls from here ...
3505 * lisp.h: ... to here, so that they can be checked.
3506
3507 * sysdep.c (reset_io): Now static.
3508 (wait_for_termination_signal): Remove; unused.
3509
3510 * keymap.c (keymap_parent, keymap_memberp, map_keymap_internal):
3511 (copy_keymap_item, append_key, push_text_char_description):
3512 Now static.
3513 (Fwhere_is_internal): Don't test CONSP (sequences) unnecessarily.
3514 (DENSE_TABLE_SIZE): Remove; unused.
3515 (get_keymap, access_keymap, Fdefine_key, Fwhere_is_internal):
3516 (describe_map_tree):
3517 Rename locals to avoid shadowing.
3518
3519 * keyboard.c: Declare functions static if they are not used elsewhere.
3520 (echo_char, echo_dash, cmd_error, top_level_2):
3521 (poll_for_input, handle_async_input): Now static.
3522 (read_char, kbd_buffer_get_event, make_lispy_position):
3523 (make_lispy_event, make_lispy_movement, apply_modifiers):
3524 (decode_keyboard_code, tty_read_avail_input, menu_bar_items):
3525 (parse_tool_bar_item, read_key_sequence, Fread_key_sequence):
3526 (Fread_key_sequence_vector): Rename locals to avoid shadowing.
3527 (read_key_sequence, read_char): Mark locals as initialized.
3528 (Fexit_recursive_edit, Fabort_recursive_edit): Mark with NO_RETURN.
3529
3530 * keyboard.h (make_ctrl_char): New decl.
3531 (mark_kboards): Move decl here ...
3532 * alloc.c (mark_kboards): ... from here.
3533
3534 * lisp.h (force_auto_save_soon): New decl.
3535
3536 * emacs.c (init_cmdargs): Rename local to avoid shadowing.
3537 (DEFINE_DUMMY_FUNCTION): New macro.
3538 (__do_global_ctors, __do_global_ctors_aux, __do_global_dtors, __main):
3539 Use it.
3540 (main): Add casts to avoid warnings
3541 if GCC considers string literals to be constants.
3542
3543 * lisp.h (fatal_error_signal): Add decl, since it's exported.
3544
3545 * dbusbind.c: Pointer signedness fixes.
3546 (xd_signature, xd_append_arg, xd_initialize):
3547 (Fdbus_call_method, Fdbus_call_method_asynchronously):
3548 (Fdbus_method_return_internal, Fdbus_method_error_internal):
3549 (Fdbus_send_signal, xd_read_message_1, Fdbus_register_service):
3550 (Fdbus_register_signal): Use SSDATA when the context wants char *.
3551
3552 * dbusbind.c (Fdbus_init_bus): Add cast to avoid warning
3553 if GCC considers string literals to be constants.
3554 (Fdbus_register_service, Fdbus_register_method): Remove unused vars.
3555
3556 2011-03-16 Stefan Monnier <monnier@iro.umontreal.ca>
3557
3558 * print.c (PRINT_CIRCLE_CANDIDATE_P): New macro.
3559 (print_preprocess, print_object): New macro to fix last change.
3560
3561 * print.c (print_preprocess): Don't forget font objects.
3562
3563 2011-03-16 Juanma Barranquero <lekktu@gmail.com>
3564
3565 * emacs.c (USAGE3): Doc fixes.
3566
3567 2011-03-15 Andreas Schwab <schwab@linux-m68k.org>
3568
3569 * coding.c (detect_coding_iso_2022): Reorganize code to clarify
3570 structure.
3571
3572 2011-03-14 Juanma Barranquero <lekktu@gmail.com>
3573
3574 * lisp.h (VWindow_system, Qfile_name_history):
3575 * keyboard.h (lispy_function_keys) [WINDOWSNT]:
3576 * w32term.h (w32_system_caret_hwnd, w32_system_caret_height)
3577 (w32_system_caret_x, w32_system_caret_y): Declare extern.
3578
3579 * w32select.c: Don't #include "keyboard.h".
3580 (run_protected): Add extern declaration for waiting_for_input.
3581
3582 * w32.c (Qlocal, noninteractive1, inhibit_window_system):
3583 * w32console.c (detect_input_pending, read_input_pending)
3584 (encode_terminal_code):
3585 * w32fns.c (quit_char, lispy_function_keys, Qtooltip)
3586 (w32_system_caret_hwnd, w32_system_caret_height, w32_system_caret_x)
3587 (w32_system_caret_y, Qfile_name_history):
3588 * w32font.c (w32font_driver, QCantialias, QCotf, QClang):
3589 * w32inevt.c (reinvoke_input_signal, lispy_function_keys):
3590 * w32menu.c (Qmenu_bar, QCtoggle, QCradio, Qoverriding_local_map)
3591 (Qoverriding_terminal_local_map, Qmenu_bar_update_hook):
3592 * w32proc.c (Qlocal, report_file_error):
3593 * w32term.c (Vwindow_system, updating_frame):
3594 * w32uniscribe.c (initialized, uniscribe_font_driver):
3595 Remove unneeded extern declarations.
3596
3597 2011-03-14 Chong Yidong <cyd@stupidchicken.com>
3598
3599 * buffer.c (Fmake_indirect_buffer): Fix incorrect assertions.
3600
3601 2011-03-13 Chong Yidong <cyd@stupidchicken.com>
3602
3603 * buffer.h (BUF_BEGV, BUF_BEGV_BYTE, BUF_ZV, BUF_ZV_BYTE, BUF_PT)
3604 (BUF_PT_BYTE): Rewrite to handle indirect buffers (Bug#8219).
3605 These macros can no longer be used for assignment.
3606
3607 * buffer.c (Fget_buffer_create, Fmake_indirect_buffer):
3608 Assign struct members directly, instead of using BUF_BEGV etc.
3609 (record_buffer_markers, fetch_buffer_markers): New functions for
3610 recording and fetching special buffer markers.
3611 (set_buffer_internal_1, set_buffer_temp): Use them.
3612
3613 * lread.c (unreadchar): Use SET_BUF_PT_BOTH.
3614
3615 * insdel.c (adjust_point): Use SET_BUF_PT_BOTH.
3616
3617 * intervals.c (temp_set_point_both): Use SET_BUF_PT_BOTH.
3618 (get_local_map): Use SET_BUF_BEGV_BOTH and SET_BUF_ZV_BOTH.
3619
3620 * xdisp.c (hscroll_window_tree):
3621 (reconsider_clip_changes): Use PT instead of BUF_PT.
3622
3623 2011-03-13 Eli Zaretskii <eliz@gnu.org>
3624
3625 * makefile.w32-in ($(BLD)/editfns.$(O)): Depend on
3626 $(EMACS_ROOT)/lib/intprops.h.
3627
3628 2011-03-13 Paul Eggert <eggert@cs.ucla.edu>
3629
3630 Fix more problems found by GCC 4.5.2's static checks.
3631
3632 * gtkutil.c (xg_get_pixbuf_from_pixmap): Add cast from char *
3633 to unsigned char * to avoid compiler diagnostic.
3634 (xg_free_frame_widgets): Make it clear that a local variable is
3635 needed only if USE_GTK_TOOLTIP.
3636 (gdk_window_get_screen): Make it clear that this macro is needed
3637 only if USE_GTK_TOOLTIP.
3638 (int_gtk_range_get_value): New function, which avoids a diagnostic
3639 from gcc -Wbad-function-cast.
3640 (xg_set_toolkit_scroll_bar_thumb): Use it.
3641 (xg_tool_bar_callback, xg_tool_item_stale_p): Rewrite to avoid
3642 diagnostic from gcc -Wbad-function-cast.
3643 (get_utf8_string, xg_get_file_with_chooser):
3644 Rename locals to avoid shadowing.
3645 (create_dialog): Move locals to avoid shadowing.
3646
3647 * xgselect.c (xg_select): Remove unused var.
3648
3649 * image.c (four_corners_best): Mark locals as initialized.
3650 (gif_load): Initialize transparent_p to zero (Bug#8238).
3651 Mark another local as initialized.
3652 (my_png_error, my_error_exit): Mark with NO_RETURN.
3653
3654 * image.c (clear_image_cache): Now static.
3655 (DIM, HAVE_STDLIB_H_1): Remove unused macros.
3656 (xpm_load): Redo to avoid "discards qualifiers" gcc warning.
3657 (x_edge_detection): Remove unnecessary cast that
3658 gcc -Wbad-function-cast diagnoses.
3659 (gif_load): Fix pointer signedness.
3660 (clear_image_cache, xbm_read_bitmap_data, x_detect_edges):
3661 (jpeg_load, gif_load): Rename locals to avoid shadowing.
3662
3663 2011-03-12 Paul Eggert <eggert@cs.ucla.edu>
3664
3665 Improve quality of tests for time stamp overflow.
3666 For example, without this patch (encode-time 0 0 0 1 1
3667 1152921504606846976) returns the obviously-bogus value (-948597
3668 62170) on my RHEL 5.5 x86-64 host. With the patch, it correctly
3669 reports time overflow. See
3670 <http://lists.gnu.org/archive/html/emacs-devel/2011-03/msg00470.html>.
3671 * deps.mk (editfns.o): Depend on ../lib/intprops.h.
3672 * editfns.c: Include limits.h and intprops.h.
3673 (TIME_T_MIN, TIME_T_MAX): New macros.
3674 (time_overflow): Move earlier, to before first use.
3675 (hi_time, lo_time): New functions, for an accurate test for
3676 out-of-range times.
3677 (Fcurrent_time, Fget_internal_run_time, make_time): Use them.
3678 (Fget_internal_run_time): Don't assume time_t fits in int.
3679 (make_time): Use list2 instead of Fcons twice.
3680 (Fdecode_time): More accurate test for out-of-range times.
3681 (check_tm_member): New function.
3682 (Fencode_time): Use it, to test for out-of-range times.
3683 (lisp_time_argument): Don't rely on undefined left-shift and
3684 right-shift behavior when checking for time stamp overflow.
3685
3686 * editfns.c (time_overflow): New function, refactoring common code.
3687 (Fformat_time_string, Fdecode_time, Fencode_time):
3688 (Fcurrent_time_string): Use it.
3689
3690 Move 'make_time' to be next to its inverse 'lisp_time_argument'.
3691 * dired.c (make_time): Move to ...
3692 * editfns.c (make_time): ... here.
3693 * systime.h: Note the move.
3694
3695 2011-03-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
3696
3697 * fringe.c (update_window_fringes): Remove unused variables.
3698
3699 * unexmacosx.c (copy_data_segment): Also copy __got section.
3700 (Bug#8223)
3701
3702 2011-03-12 Eli Zaretskii <eliz@gnu.org>
3703
3704 * termcap.c [MSDOS]: Include "msdos.h".
3705 (find_capability, tgetnum, tgetflag, tgetstr, tputs, tgetent):
3706 Constify `char *' arguments and their references according to
3707 prototypes in tparam.h.
3708
3709 * deps.mk (termcap.o): Depend on tparam.h and msdos.h.
3710
3711 * msdos.c (XMenuAddPane): 3rd argument is `const char *' now.
3712 Adapt all references accordingly.
3713
3714 * msdos.h (XMenuAddPane): 3rd argument is `const char *' now.
3715
3716 2011-03-11 Tom Tromey <tromey@redhat.com>
3717
3718 * buffer.c (syms_of_buffer): Remove obsolete comment.
3719
3720 2011-03-11 Eli Zaretskii <eliz@gnu.org>
3721
3722 * termhooks.h (encode_terminal_code): Declare prototype.
3723
3724 * msdos.c (encode_terminal_code): Don't declare prototype.
3725
3726 * term.c (encode_terminal_code): Now external again, used by
3727 w32console.c and msdos.c.
3728
3729 * makefile.w32-in ($(BLD)/term.$(O), ($(BLD)/tparam.$(O)):
3730 Depend on $(SRC)/tparam.h, see 2011-03-11T07:24:21Z!eggert@cs.ucla.edu.
3731
3732 2011-03-11 Paul Eggert <eggert@cs.ucla.edu>
3733
3734 Fix some minor problems found by GCC 4.5.2's static checks.
3735
3736 * fringe.c (update_window_fringes): Mark locals as initialized
3737 (Bug#8227).
3738 (destroy_fringe_bitmap, init_fringe_bitmap): Now static.
3739
3740 * alloc.c (mark_fringe_data): Move decl from here ...
3741 * lisp.h (mark_fringe_data) [HAVE_WINDOW_SYSTEM]: ... to here,
3742 to check its interface.
3743 (init_fringe_once): Do not declare unless HAVE_WINDOW_SYSTEM.
3744
3745 * fontset.c (free_realized_fontset): Now static.
3746 (Fset_fontset_font): Rename local to avoid shadowing.
3747 (fontset_font): Mark local as initialized.
3748 (FONTSET_SPEC, FONTSET_REPERTORY, RFONT_DEF_REPERTORY): Remove; unused.
3749
3750 * xrdb.c: Include "xterm.h", to check x_load_resources's interface.
3751
3752 * xselect.c (x_disown_buffer_selections): Remove; not used.
3753 (TRACE3) [!defined TRACE_SELECTION]: Remove; not used.
3754 (x_own_selection, Fx_disown_selection_internal): Rename locals
3755 to avoid shadowing.
3756 (x_handle_dnd_message): Remove local to avoid shadowing.
3757
3758 * lisp.h (GCPRO1_VAR, UNGCPRO_VAR): New macros,
3759 so that the caller can use some name other than gcpro1.
3760 (GCPRO1, UNGCPRO): Reimplement in terms of the new macros.
3761 * xfns.c (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
3762 (Fx_backspace_delete_keys_p):
3763 Use them to avoid shadowing, and rename vars to avoid shadowing.
3764 (x_decode_color, x_set_name, x_window): Now static.
3765 (Fx_create_frame): Add braces to silence GCC warning.
3766 (Fx_file_dialog, Fx_select_font): Fix pointer signedness.
3767 (x_real_positions, xg_set_icon_from_xpm_data, x_create_tip_frame):
3768 Remove unused locals.
3769 (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
3770 (Fx_backspace_delete_keys_p): Rename locals to avoid shadowing.
3771 Some of these renamings use the new GCPRO1_VAR and UNGCPRO_VAR
3772 macros.
3773
3774 * xterm.h (x_mouse_leave): New decl.
3775
3776 * xterm.c (x_copy_dpy_color, x_focus_on_frame, x_unfocus_frame):
3777 Remove unused functions.
3778 (x_shift_glyphs_for_insert, XTflash, XTring_bell):
3779 (x_calc_absolute_position): Now static.
3780 (XTread_socket): Don't define label "out" unless it's used.
3781 Don't declare local "event" unless it's used.
3782 (x_iconify_frame, x_free_frame_resources): Don't declare locals
3783 unless they are used.
3784 (XEMBED_VERSION, xembed_set_info): Don't define unless needed.
3785 (x_fatal_error_signal): Remove; not used.
3786 (x_draw_image_foreground, redo_mouse_highlight, XTmouse_position):
3787 (x_scroll_bar_report_motion, handle_one_xevent, x_draw_bar_cursor):
3788 (x_error_catcher, x_connection_closed, x_error_handler):
3789 (x_error_quitter, xembed_send_message, x_iconify_frame):
3790 (my_log_handler): Rename locals to avoid shadowing.
3791 (x_delete_glyphs, x_ins_del_lines): Mark with NO_RETURN.
3792 (x_connection_closed): Tell GCC not to suggest NO_RETURN.
3793
3794 * xfaces.c (clear_face_cache, Fx_list_fonts, Fface_font):
3795 Rename or move locals to avoid shadowing.
3796 (tty_defined_color, merge_face_heights): Now static.
3797 (free_realized_faces_for_fontset): Remove; not used.
3798 (Fx_list_fonts): Mark variable that gcc -Wuninitialized
3799 does not deduce is never used uninitialized.
3800 (STRDUPA, LSTRDUPA, FONT_POINT_SIZE_QUANTUM): Remove; not used.
3801 (LFACEP): Define only if XASSERTS, as it's not needed otherwise.
3802
3803 * terminal.c (store_terminal_param): Now static.
3804
3805 * xmenu.c (menu_highlight_callback): Now static.
3806 (set_frame_menubar): Remove unused local.
3807 (xmenu_show): Rename parameter to avoid shadowing.
3808 (xmenu_show, xdialog_show, xmenu_show): Make local pointers "const"
3809 since they might point to immutable storage.
3810 (next_menubar_widget_id): Declare only if USE_X_TOOLKIT,
3811 since it's unused otherwise.
3812
3813 * xdisp.c (produce_glyphless_glyph): Initialize lower_xoff.
3814 Add a FIXME, since the code still doesn't look right. (Bug#8215)
3815 (Fcurrent_bidi_paragraph_direction): Simplify slightly; this
3816 avoids a gcc -Wuninitialized diagnostic.
3817 (display_line, BUILD_COMPOSITE_GLYPH_STRING, draw_glyphs):
3818 (note_mouse_highlight): Mark variables that gcc -Wuninitialized
3819 does not deduce are never used uninitialized.
3820
3821 * lisp.h (IF_LINT): New macro, copied from ../lib-src/emacsclient.c.
3822
3823 * xdisp.c (redisplay_window): Rename local to avoid shadowing.
3824 * window.c (window_loop, size_window):
3825 (run_window_configuration_change_hook, enlarge_window): Likewise.
3826
3827 * window.c (display_buffer): Now static.
3828 (size_window): Mark variables that gcc -Wuninitialized
3829 does not deduce are never used uninitialized.
3830 * window.h (check_all_windows): New decl, to forestall
3831 gcc -Wmissing-prototypes diagnostic.
3832 * dispextern.h (bidi_dump_cached_states): Likewise.
3833
3834 * charset.h (CHECK_CHARSET_GET_CHARSET): Rename locals to avoid
3835 shadowing.
3836 * charset.c (map_charset_for_dump, Fchar_charset): Likewise.
3837 Include <limits.h>.
3838 (Fsort_charsets): Redo min/max calculation to shorten the code a bit
3839 and to avoid gcc -Wuninitialized warning.
3840 (load_charset_map): Mark variables that gcc -Wuninitialized
3841 does not deduce are never used uninitialized.
3842 (load_charset): Abort instead of using uninitialized var (Bug#8229).
3843
3844 * coding.c (coding_set_source, coding_set_destination):
3845 Use "else { /* comment */ }" rather than "else /* comment */;"
3846 for clarity, and to avoid gcc -Wempty-body warning.
3847 (Fdefine_coding_system_internal): Don't redeclare 'i' inside
3848 a block, when the outer 'i' will do.
3849 (decode_coding_utf_8, decode_coding_utf_16, detect_coding_emacs_mule):
3850 (emacs_mule_char, decode_coding_emacs_mule, detect_coding_iso_2022):
3851 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5):
3852 (decode_coding_raw_text, decode_coding_charset, get_translation_table):
3853 (Fdecode_sjis_char, Fdefine_coding_system_internal):
3854 Rename locals to avoid shadowing.
3855 * character.h (FETCH_STRING_CHAR_ADVANCE): Likewise.
3856 * coding.c (emacs_mule_char, encode_invocation_designation):
3857 Now static, since they're not used elsewhere.
3858 (decode_coding_iso_2022): Add "default: abort ();" as a safety check.
3859 (decode_coding_object, encode_coding_object, detect_coding_system):
3860 (decode_coding_emacs_mule): Mark variables that gcc
3861 -Wuninitialized does not deduce are never used uninitialized.
3862 (detect_coding_iso_2022): Initialize a local variable that might
3863 be used uninitialized. Leave a FIXME because it's not clear that
3864 this initialization is needed. (Bug#8211)
3865 (ISO_CODE_LF, ISO_CODE_CR, CODING_ISO_FLAG_EUC_TW_SHIFT):
3866 (ONE_MORE_BYTE_NO_CHECK, UTF_BOM, UTF_16_INVALID_P):
3867 (SHIFT_OUT_OK, ENCODE_CONTROL_SEQUENCE_INTRODUCER):
3868 (ENCODE_DIRECTION_R2L, ENCODE_DIRECTION_L2R):
3869 Remove unused macros.
3870
3871 * category.c (hash_get_category_set): Remove unused local var.
3872 (copy_category_table): Now static, since it's not used elsewhere.
3873 * character.c (string_count_byte8): Likewise.
3874
3875 * ccl.c (CCL_WRITE_STRING, CCL_ENCODE_CHAR, Fccl_execute_on_string):
3876 (Fregister_code_conversion_map): Rename locals to avoid shadowing.
3877
3878 * chartab.c (copy_sub_char_table): Now static, since it's not used
3879 elsewhere.
3880 (sub_char_table_ref_and_range, char_table_ref_and_range):
3881 Rename locals to avoid shadowing.
3882 (ASET_RANGE, GET_SUB_CHAR_TABLE): Remove unused macros.
3883
3884 * bidi.c (bidi_check_type): Now static, since it's not used elsewhere.
3885 (BIDI_BOB): Remove unused macro.
3886
3887 * cm.c (cmgoto): Mark variables that gcc -Wuninitialized does not
3888 deduce are never used uninitialized.
3889 * term.c (encode_terminal_code): Likewise.
3890
3891 * term.c (encode_terminal_code): Now static. Remove unused local.
3892
3893 * tparam.h: New file.
3894 * term.c, tparam.h: Include it.
3895 * deps.mk (term.o, tparam.o): Depend on tparam.h.
3896 * term.c (tputs, tgetent, tgetflag, tgetnum, tparam, tgetstr):
3897 Move these decls to tparam.h, and make them agree with what
3898 is actually in tparam.c. The previous trick of using incompatible
3899 decls in different modules does not conform to the C standard.
3900 All callers of tparam changed to use tparam's actual API.
3901 * tparam.c (tparam1, tparam, tgoto):
3902 Use const pointers where appropriate.
3903
3904 * cm.c (calccost, cmgoto): Use const pointers where appropriate.
3905 * cm.h (struct cm): Likewise.
3906 * dispextern.h (do_line_insertion_deletion_costs): Likewise.
3907 * scroll.c (ins_del_costs, do_line_insertion_deletion_costs): Likewise.
3908 * term.c (tty_ins_del_lines, calculate_costs, struct fkey_table):
3909 (term_get_fkeys_1, append_glyphless_glyph, produce_glyphless_glyph):
3910 (turn_on_face, init_tty): Likewise.
3911 * termchar.h (struct tty_display_info): Likewise.
3912
3913 * term.c (term_mouse_position): Rename local to avoid shadowing.
3914
3915 * alloc.c (mark_ttys): Move decl from here ...
3916 * lisp.h (mark_ttys): ... to here, so that it's checked against defn.
3917
3918 2011-03-11 Andreas Schwab <schwab@linux-m68k.org>
3919
3920 * .gdbinit (pwinx, xbuffer): Fix access to buffer name.
3921
3922 2011-03-09 Juanma Barranquero <lekktu@gmail.com>
3923
3924 * search.c (compile_pattern_1): Remove argument regp, unused since
3925 revid:rms@gnu.org-19941211082627-3x1g1wyqkjmwloig.
3926 (compile_pattern): Don't pass it.
3927
3928 2011-03-08 Jan Djärv <jan.h.d@swipnet.se>
3929
3930 * xterm.h (DEFAULT_GDK_DISPLAY): New define.
3931 (GDK_WINDOW_XID, gtk_widget_get_preferred_size): New defines
3932 for ! HAVE_GTK3.
3933 (GTK_WIDGET_TO_X_WIN): Use GDK_WINDOW_XID.
3934
3935 * xmenu.c (menu_position_func): Call gtk_widget_get_preferred_size.
3936
3937 * gtkutil.c: Include gtkx.h if HAVE_GTK3. If ! HAVE_GTK3, define
3938 gdk_window_get_screen, gdk_window_get_geometry,
3939 gdk_x11_window_lookup_for_display and GDK_KEY_g.
3940 (xg_set_screen): Use DEFAULT_GDK_DISPLAY.
3941 (xg_get_pixbuf_from_pixmap): New function.
3942 (xg_get_pixbuf_from_pix_and_mask): Change parameters from GdkPixmap
3943 to Pixmap, take frame as parameter, remove GdkColormap parameter.
3944 Call xg_get_pixbuf_from_pixmap instead of
3945 gdk_pixbuf_get_from_drawable.
3946 (xg_get_image_for_pixmap): Do not make GdkPixmaps, call
3947 xg_get_pixbuf_from_pix_and_mask with Pixmap parameters instead.
3948 (xg_check_special_colors): Use GtkStyleContext and its functions
3949 for HAVE_GTK3.
3950 (xg_prepare_tooltip, xg_hide_tooltip): Call gdk_window_get_screen.
3951 (xg_prepare_tooltip, create_dialog, menubar_map_cb)
3952 (xg_update_frame_menubar, xg_tool_bar_detach_callback)
3953 (xg_tool_bar_attach_callback, xg_update_tool_bar_sizes):
3954 Call gtk_widget_get_preferred_size.
3955 (xg_frame_resized): gdk_window_get_geometry only takes 5
3956 parameters.
3957 (xg_win_to_widget, xg_event_is_for_menubar):
3958 Call gdk_x11_window_lookup_for_display.
3959 (xg_set_widget_bg): New function.
3960 (delete_cb): New function.
3961 (xg_create_frame_widgets): Connect delete-event to delete_cb.
3962 Call xg_set_widget_bg. Only set backgrund pixmap for ! HAVE_GTK3
3963 (xg_set_background_color): Call xg_set_widget_bg.
3964 (xg_set_frame_icon): Call xg_get_pixbuf_from_pix_and_mask.
3965 (xg_create_scroll_bar): vadj is a GtkAdjustment for HAVE_GTK3.
3966 Only call gtk_range_set_update_policy if ! HAVE_GTK3.
3967 (xg_make_tool_item): Only connect xg_tool_bar_item_expose_callback
3968 if ! HAVE_GTK3.
3969 (update_frame_tool_bar): Call gtk_widget_hide.
3970 (xg_initialize): Use GDK_KEY_g.
3971
3972 * xsmfns.c (gdk_set_sm_client_id): Define to gdk_set_sm_client_id
3973 if ! HAVE_GTK3
3974 (x_session_initialize): Call gdk_x11_set_sm_client_id.
3975
3976 * xterm.c (XFillRectangle): Use cairo routines for HAVE_GTK3.
3977 (x_term_init): Disable Xinput(2) with GDK_CORE_DEVICE_EVENTS.
3978 Load ~/emacs.d/gtkrc only for ! HAVE_GTK3.
3979
3980 2011-03-08 Juanma Barranquero <lekktu@gmail.com>
3981
3982 * w32xfns.c (select_palette): Check success of RealizePalette against
3983 GDI_ERROR, not zero.
3984
3985 See ChangeLog.11 for earlier changes.
3986
3987 ;; Local Variables:
3988 ;; coding: utf-8
3989 ;; End:
3990
3991 Copyright (C) 2011 Free Software Foundation, Inc.
3992
3993 This file is part of GNU Emacs.
3994
3995 GNU Emacs is free software: you can redistribute it and/or modify
3996 it under the terms of the GNU General Public License as published by
3997 the Free Software Foundation, either version 3 of the License, or
3998 (at your option) any later version.
3999
4000 GNU Emacs is distributed in the hope that it will be useful,
4001 but WITHOUT ANY WARRANTY; without even the implied warranty of
4002 MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
4003 GNU General Public License for more details.
4004
4005 You should have received a copy of the GNU General Public License
4006 along with GNU Emacs. If not, see <http://www.gnu.org/licenses/>.