883f6505e20f171e5a581b548d0de8a9cd220236
[bpt/emacs.git] / src / ChangeLog
1 2011-05-29 Paul Eggert <eggert@cs.ucla.edu>
2
3 Minor fixes prompted by GCC 4.6.0 warnings.
4
5 * xselect.c (converted_selections, conversion_fail_tag): Now static.
6
7 * emacs.c [HAVE_X_WINDOWS]: Include "xterm.h".
8 (x_clipboard_manager_save_all): Move extern decl to ...
9 * xterm.h: ... here, so that it can be checked for consistency.
10
11 2011-05-29 Chong Yidong <cyd@stupidchicken.com>
12
13 * xselect.c (x_clipboard_manager_save_frame)
14 (x_clipboard_manager_save_all): New functions.
15 (Fx_clipboard_manager_save): Lisp function deleted.
16
17 * emacs.c (Fkill_emacs): Call x_clipboard_manager_save_all.
18 * frame.c (delete_frame): Call x_clipboard_manager_save_frame.
19
20 * xterm.h: Update prototype.
21
22 2011-05-28 William Xu <william.xwl@gmail.com>
23
24 * nsterm.m (ns_term_shutdown): Synchronize user defaults before
25 exiting (Bug#8239).
26
27 2011-05-28 Jim Meyering <meyering@redhat.com>
28
29 Avoid a sign-extension bug in crypto_hash_function.
30 * fns.c (to_uchar): Define.
31 (crypto_hash_function): Use it to convert some newly-signed
32 variables to unsigned, to avoid sign-extension bugs. For example,
33 without this change, (md5 "truc") would evaluate to
34 45723a2aff78ff4fff7fff1114760e62 rather than the expected
35 45723a2af3788c4ff17f8d1114760e62. Reported by Antoine Levitt in
36 https://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00883.html.
37
38 2011-05-27 Paul Eggert <eggert@cs.ucla.edu>
39
40 Integer overflow fixes.
41
42 * dbusbind.c: Serial number integer overflow fixes.
43 (CHECK_DBUS_SERIAL_GET_SERIAL): New macro.
44 (Fdbus_call_method_asynchronously, xd_read_message_1): Use a float
45 to hold a serial number that is too large for a fixnum.
46 (Fdbus_method_return_internal, Fdbus_method_error_internal):
47 Check for serial numbers out of range. Decode any serial number
48 that was so large that it became a float. (Bug#8722)
49
50 * dbusbind.c: Use XFASTINT rather than XUINT, and check for nonneg.
51 (Fdbus_call_method, Fdbus_call_method_asynchronously):
52 Use XFASTINT rather than XUINT when numbers are nonnegative.
53 (xd_append_arg, Fdbus_method_return_internal):
54 (Fdbus_method_error_internal): Likewise. Also, for unsigned
55 arguments, check that Lisp number is nonnegative, rather than
56 silently wrapping negative numbers around. (Bug#8722)
57 (xd_read_message_1): Don't assume dbus_uint32_t can fit in int.
58 (Bug#8722)
59
60 * data.c (arith_driver, Flsh): Avoid unnecessary casts to EMACS_UINT.
61
62 * ccl.c (ccl_driver): Redo slightly to avoid the need for 'unsigned'.
63
64 ccl: add integer overflow checks
65 * ccl.c (CCL_CODE_MAX, GET_CCL_RANGE, GET_CCL_CODE, GET_CCL_INT):
66 (IN_INT_RANGE): New macros.
67 (ccl_driver): Use them to check for integer overflow when
68 decoding a CCL program. Many of the new checks are whether XINT (x)
69 fits in int; it doesn't always, on 64-bit hosts. The new version
70 doesn't catch all possible integer overflows, but it's an
71 improvement. (Bug#8719)
72
73 * alloc.c (make_event_array): Use XINT, not XUINT.
74 There's no need for unsigned here.
75
76 * mem-limits.h (EXCEEDS_LISP_PTR) [!USE_LSB_TAG]: EMACS_UINT -> uintptr_t
77 This follows up to the 2011-05-06 change that substituted uintptr_t
78 for EMACS_INT. This case wasn't caught back then.
79
80 Rework Fformat to avoid integer overflow issues.
81 * editfns.c: Include <float.h> unconditionally, as it's everywhere
82 now (part of C89). Include <verify.h>.
83 (MAX_10_EXP, CONVERTED_BYTE_SIZE): Remove; no longer needed.
84 (pWIDE, pWIDElen, signed_wide, unsigned_wide): New defns.
85 (Fformat): Avoid the prepass trying to compute sizes; it was only
86 approximate and thus did not catch overflow reliably. Instead, walk
87 through the format just once, formatting and computing sizes as we go,
88 checking for integer overflow at every step, and allocating a larger
89 buffer as needed. Keep track separately whether the format is
90 multibyte. Keep only the most-recently calculated precision, rather
91 than them all. Record whether each argument has been converted to
92 string. Use EMACS_INT, not int, for byte and char and arg counts.
93 Support field widths and precisions larger than INT_MAX. Avoid
94 sprintf's undefined behavior with conversion specifications such as %#d
95 and %.0c. Fix bug with strchr succeeding on '\0' when looking for
96 flags. Fix bug with (format "%c" 256.0). Avoid integer overflow when
97 formatting out-of-range floating point numbers with int
98 formats. (Bug#8668)
99
100 * lisp.h (FIXNUM_OVERFLOW_P): Work even if arg is a NaN.
101
102 * data.c: Avoid integer truncation in expressions involving floats.
103 * data.c: Include <intprops.h>.
104 (arith_driver): When there's an integer overflow in an expression
105 involving floating point, convert the integers to floating point
106 so that the resulting value does not suffer from catastrophic
107 integer truncation. For example, on a 64-bit host (* 4
108 most-negative-fixnum 0.5) should yield about -4.6e+18, not zero.
109 Do not rely on undefined behavior after integer overflow.
110
111 merge count_size_as_multibyte, parse_str_to_multibyte
112 * character.c, character.h (count_size_as_multibyte):
113 Renamed from parse_str_to_multibyte; all uses changed.
114 Check for integer overflow.
115 * insdel.c, lisp.h (count_size_as_multibyte): Remove,
116 since it's now a duplicate of the other. This is more of
117 a character than a buffer op, so better that it's in character.c.
118 * fns.c, print.c: Adjust to above changes.
119
120 2011-05-27 Stefan Monnier <monnier@iro.umontreal.ca>
121
122 * xselect.c (x_convert_selection): Yet another int/Lisp_Object mixup.
123
124 2011-05-27 Paul Eggert <eggert@cs.ucla.edu>
125
126 * xselect.c: Fix minor problems prompted by GCC 4.6.0 warnings.
127 (x_handle_selection_request, frame_for_x_selection): Remove unused vars.
128 (x_clipboard_manager_save): Now static.
129 (Fx_clipboard_manager_save): Rename local to avoid shadowing.
130
131 * fns.c: Fix minor problems prompted by GCC 4.6.0 warnings.
132 (crypto_hash_function): Now static.
133 Fix pointer signedness problems. Avoid unnecessary initializations.
134
135 2011-05-27 Chong Yidong <cyd@stupidchicken.com>
136
137 * termhooks.h (Vselection_alist): Make it terminal-local.
138
139 * terminal.c (create_terminal): Initialize it.
140
141 * xselect.c: Support for clipboard managers.
142 (Vselection_alist): Move to termhooks.h as terminal-local var.
143 (LOCAL_SELECTION): New macro.
144 (x_atom_to_symbol): Handle x_display_info_for_display fail case.
145 (symbol_to_x_atom): Remove gratuitous arg.
146 (x_handle_selection_request, lisp_data_to_selection_data)
147 (x_get_foreign_selection, Fx_register_dnd_atom): Callers changed.
148 (x_own_selection, x_get_local_selection, x_convert_selection): New
149 arg, specifying work frame. Use terminal-local Vselection_alist.
150 (some_frame_on_display): Delete unused function.
151 (Fx_own_selection_internal, Fx_get_selection_internal)
152 (Fx_disown_selection_internal, Fx_selection_owner_p)
153 (Fx_selection_exists_p): New optional frame arg.
154 (frame_for_x_selection, Fx_clipboard_manager_save): New functions.
155 (x_handle_selection_clear): Don't treat other terminals with the
156 same keyboard specially. Use the terminal-local Vselection_alist.
157 (x_clear_frame_selections): Use Frun_hook_with_args.
158
159 * xterm.c (x_term_init): Intern ATOM and CLIPBOARD_MANAGER atoms.
160
161 * xterm.h: Add support for those atoms.
162
163 2011-05-26 Chong Yidong <cyd@stupidchicken.com>
164
165 * xselect.c: ICCCM-compliant handling of MULTIPLE targets.
166 (converted_selections, conversion_fail_tag): New global variables.
167 (x_selection_request_lisp_error): Free the above.
168 (x_get_local_selection): Remove unnecessary code.
169 (x_reply_selection_request): Args changed; handle arbitrary array
170 of converted selections stored in converted_selections. Separate
171 the XChangeProperty and SelectionNotify steps.
172 (x_handle_selection_request): Rewrite to handle MULTIPLE target.
173 (x_convert_selection): New function.
174 (x_handle_selection_event): Simplify.
175 (x_get_foreign_selection): Don't ignore incoming requests while
176 waiting for an answer; this will fail when we implement
177 SAVE_TARGETS, and seems unnecessary anyway.
178 (selection_data_to_lisp_data): Recognize ATOM_PAIR type.
179 (Vx_sent_selection_functions): Doc fix.
180
181 2011-05-26 Leo Liu <sdl.web@gmail.com>
182
183 * editfns.c (Ftranspose_regions): Allow empty regions. (Bug#8699)
184
185 2011-05-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
186
187 * dispextern.h (struct glyph_row): New member fringe_bitmap_periodic_p.
188
189 * dispnew.c (shift_glyph_matrix, scrolling_window): Mark scrolled row
190 for fringe update if it has periodic bitmap.
191 (row_equal_p): Also compare left_fringe_offset, right_fringe_offset,
192 and fringe_bitmap_periodic_p.
193
194 * fringe.c (get_fringe_bitmap_data): New function.
195 (draw_fringe_bitmap_1, update_window_fringes): Use it.
196 (update_window_fringes): Record periodicity of fringe bitmap in glyph
197 row. Mark glyph row for fringe update if periodicity changed.
198
199 * xdisp.c (try_window_reusing_current_matrix): Don't mark scrolled row
200 for fringe update unless it has periodic bitmap.
201
202 2011-05-25 Kenichi Handa <handa@m17n.org>
203
204 * xdisp.c (get_next_display_element): Set correct it->face_id for
205 a static composition.
206
207 2011-05-24 Leo Liu <sdl.web@gmail.com>
208
209 * deps.mk (fns.o):
210 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha1.h.
211
212 * fns.c (crypto_hash_function, Fsha1): New function.
213 (Fmd5): Use crypto_hash_function.
214 (syms_of_fns): Add Ssha1.
215
216 2011-05-22 Paul Eggert <eggert@cs.ucla.edu>
217
218 * gnutls.c: Remove unused macros.
219 (fn_gnutls_transport_set_lowat, fn_gnutls_transport_set_pull_function):
220 (fn_gnutls_transport_set_push_function) [!WINDOWSNT]:
221 Remove macros that are defined and never used.
222 Caught by gcc -Wunused-macros (GCC 4.6.0, Fedora 14).
223
224 2011-05-22 Chong Yidong <cyd@stupidchicken.com>
225
226 * xselect.c (syms_of_xselect): Remove unused symbol SAVE_TARGETS.
227 (Fx_get_selection_internal): Minor cleanup.
228 (Fx_own_selection_internal): Rename arguments for consistency with
229 select.el.
230
231 2011-05-22 Paul Eggert <eggert@cs.ucla.edu>
232
233 * xselect.c (QSAVE_TARGETS): New static var, to fix build failure.
234
235 2011-05-22 Chong Yidong <cyd@stupidchicken.com>
236
237 * xselect.c (syms_of_xselect): Include character.h; use DEFSYM.
238
239 2011-05-21 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
240
241 * dispnew.c (scrolling_window): Don't exclude the case that the
242 last enabled row in the desired matrix touches the bottom boundary.
243
244 2011-05-21 Glenn Morris <rgm@gnu.org>
245
246 * Makefile.in ($(etc)/DOC): Make second command line even shorter.
247 (SOME_MACHINE_OBJECTS): Replace FONT_OBJ by its maximal expansion,
248 and add some more files.
249
250 2011-05-20 Eli Zaretskii <eliz@gnu.org>
251
252 * callproc.c (Fcall_process) [MSDOS]: Fix arguments to
253 report_file_error introduced by the change from 2011-05-07.
254
255 2011-05-20 Paul Eggert <eggert@cs.ucla.edu>
256
257 * systime.h (Time): Define only if emacs is defined.
258 This is to allow ../lib-src/profile.c to be compiled on FreeBSD,
259 where the include path doesn't have X11/X.h by default. See
260 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00561.html>.
261
262 2011-05-20 Kenichi Handa <handa@m17n.org>
263
264 * composite.c (find_automatic_composition): Fix previous change.
265
266 2011-05-20 Glenn Morris <rgm@gnu.org>
267
268 * lisp.mk: New file, split from Makefile.in.
269 * Makefile.in (lisp): Move to separate file, inserted by @lisp_frag@.
270 (shortlisp): Remove.
271 ($(etc)/DOC): Edit lisp.mk rather than using $shortlisp.
272
273 2011-05-19 Glenn Morris <rgm@gnu.org>
274
275 * Makefile.in (MSDOS_SUPPORT_REAL, MSDOS_SUPPORT, NS_SUPPORT)
276 (REAL_MOUSE_SUPPORT, GPM_MOUSE_SUPPORT, MOUSE_SUPPORT, TOOLTIP_SUPPORT)
277 (BASE_WINDOW_SUPPORT, X_WINDOW_SUPPORT, WINDOW_SUPPORT): Remove.
278 (lisp): Set the order to that of loadup.el.
279 (shortlisp): Make it a copy of $lisp.
280 (SOME_MACHINE_LISP): Remove.
281 ($(etc)/DOC): Depend just on $lisp, not $SOME_MACHINE_LISP too.
282 Use just $shortlisp, not $SOME_MACHINE_LISP too.
283
284 2011-05-18 Kenichi Handa <handa@m17n.org>
285
286 * composite.c (CHAR_COMPOSABLE_P): Add more check for efficiency.
287 (BACKWARD_CHAR): Wrap the arg STOP by parenthesis.
288 (find_automatic_composition): Mostly rewrite for efficiency.
289
290 2011-05-18 Juanma Barranquero <lekktu@gmail.com>
291
292 * makefile.w32-in: Update dependencies.
293
294 2011-05-18 Christoph Scholtes <cschol2112@googlemail.com>
295
296 * menu.c: Include limits.h (fixes the MS-Windows build broken by
297 revision 104625).
298
299 2011-05-18 Paul Eggert <eggert@cs.ucla.edu>
300
301 Fix some integer overflow issues, such as string length overflow.
302
303 * insdel.c (count_size_as_multibyte): Check for string overflow.
304
305 * character.c (lisp_string_width): Check for string overflow.
306 Use EMACS_INT, not int, for string indexes and lengths; in
307 particular, 2nd arg is now EMACS_INT, not int. Do not crash if
308 the resulting string length overflows an EMACS_INT; instead,
309 report a string overflow if no precision given. When checking for
310 precision exhaustion, use a check that cannot possibly have
311 integer overflow. (Bug#8675)
312 * character.h (lisp_string_width): Adjust to new signature.
313
314 * alloc.c (string_overflow): New function.
315 (Fmake_string): Use it. This doesn't change behavior, but saves
316 a few bytes and will simplify future changes.
317 * character.c (string_escape_byte8): Likewise.
318 * lisp.h (string_overflow): New decl.
319
320 Fixups, following up to the user-interface timestamp change.
321 * nsterm.m (last_mouse_movement_time, ns_mouse_position): Use Time
322 for UI timestamps, instead of unsigned long.
323 * msdos.c (mouse_get_pos): Likewise.
324 * w32inevt.c (movement_time, w32_console_mouse_position): Likewise.
325 * w32gui.h (Time): Define by including "systime.h" rather than by
326 declaring it ourselves. (Bug#8664)
327
328 * dispextern.h (struct image): Don't assume time_t <= unsigned long.
329 * image.c (clear_image_cache): Likewise.
330
331 * term.c (term_mouse_position): Don't assume time_t wraparound.
332
333 Be more systematic about user-interface timestamps.
334 Before, the code sometimes used 'Time', sometimes 'unsigned long',
335 and sometimes 'EMACS_UINT', to represent these timestamps. This
336 change causes it to use 'Time' uniformly, as that's what X uses.
337 This makes the code easier to follow, and makes it easier to catch
338 integer overflow bugs such as Bug#8664.
339 * frame.c (Fmouse_position, Fmouse_pixel_position):
340 Use Time, not unsigned long, for user-interface timestamps.
341 * keyboard.c (last_event_timestamp, kbd_buffer_get_event): Likewise.
342 (button_down_time, make_lispy_position, make_lispy_movement): Likewise.
343 * keyboard.h (last_event_timestamp): Likewise.
344 * menu.c (Fx_popup_menu) [!HAVE_X_WINDOWS]: Likewise.
345 * menu.h (xmenu_show): Likewise.
346 * term.c (term_mouse_position): Likewise.
347 * termhooks.h (struct input_event.timestamp): Likewise.
348 (struct terminal.mouse_position_hook): Likewise.
349 * xmenu.c (create_and_show_popup_menu, xmenu_show): Likewise.
350 * xterm.c (XTmouse_position, x_scroll_bar_report_motion): Likewise.
351 * systime.h (Time): New decl. Pull it in from <X11/X.h> if
352 HAVE_X_WINDOWS, otherwise define it as unsigned long, which is
353 what it was before.
354 * menu.h, termhooks.h: Include "systime.h", for Time.
355
356 * keyboard.c (make_lispy_event): Fix problem in integer overflow.
357 Don't assume that the difference between two unsigned long values
358 can fit into an integer. At this point, we know button_down_time
359 <= event->timestamp, so the difference must be nonnegative, so
360 there's no need to cast the result if double-click-time is
361 nonnegative, as it should be; check that it's nonnegative, just in
362 case. This bug is triggered when events are more than 2**31 ms
363 apart (about 25 days). (Bug#8664)
364
365 * xselect.c (last_event_timestamp): Remove duplicate decl.
366 (x_own_selection): Remove needless cast to unsigned long.
367
368 * xmenu.c (set_frame_menubar): Use int, not EMACS_UINT, for indexes
369 that always fit in int. Use a sentinel instead of a counter, to
370 avoid a temp and to allay GCC's concerns about possible int overflow.
371 * frame.h (struct frame): Use int for menu_bar_items_used
372 instead of EMACS_INT, since it always fits in int.
373
374 * menu.c (grow_menu_items): Check for int overflow.
375
376 * xmenu.c (set_frame_menubar): Don't mishandle vectors with no nils.
377
378 * xterm.c: Use EMACS_INT for Emacs modifiers, and int for X modifiers.
379 Before, the code was not consistent. These values cannot exceed
380 2**31 - 1 so there's no need to make them unsigned.
381 (x_x_to_emacs_modifiers): Accept int and return EMACS_INT.
382 (x_emacs_to_x_modifiers): Accept EMACS_INT and return int.
383 (x_x_to_emacs_modifiers, x_emacs_to_x_modifiers): Reject non-integers
384 as modifiers.
385 * xterm.h (x_x_to_emacs_modifiers): Adjust to signature change.
386
387 * lisp.h (XINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_INT.
388 (XUINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_UINT.
389 Otherwise, GCC 4.6.0 warns about printf (pI, XINT (...)),
390 presumably because the widths might not match.
391
392 * window.c (size_window): Avoid needless test at loop start.
393
394 2011-05-18 Courtney Bane <emacs-bugs-7626@cbane.org> (tiny change)
395
396 * term.c (Fresume_tty): Restore hooks before reinitializing (bug#8687).
397
398 2011-05-12 Drew Adams <drew.adams@oracle.com>
399
400 * textprop.c (Fprevious_single_char_property_change): Doc fix (bug#8655).
401
402 2011-05-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
403
404 * w32term.c (w32_draw_fringe_bitmap): Rename local vars `left' and
405 `width' to `bar_area_x' and `bar_area_width', respectively.
406 (x_scroll_run): Take account of fringe background extension.
407
408 * xterm.c (x_draw_fringe_bitmap) [USE_TOOLKIT_SCROLL_BARS]:
409 Rename local vars `left' and `width' to `bar_area_x' and
410 `bar_area_width', respectively.
411 (x_scroll_run) [USE_TOOLKIT_SCROLL_BARS]: Take account of fringe
412 background extension.
413
414 2011-05-10 Jim Meyering <meyering@redhat.com>
415
416 * xdisp.c (x_intersect_rectangles): Fix typo "the the -> the".
417
418 2011-05-10 Juanma Barranquero <lekktu@gmail.com>
419
420 * image.c (Finit_image_library): Return t for built-in image types,
421 like pbm and xbm. (Bug#8640)
422
423 2011-05-09 Andreas Schwab <schwab@linux-m68k.org>
424
425 * w32menu.c (set_frame_menubar): Fix submenu allocation.
426
427 2011-05-07 Eli Zaretskii <eliz@gnu.org>
428
429 * w32console.c (Fset_screen_color): Doc fix.
430 (Fget_screen_color): New function.
431 (syms_of_ntterm): Defsubr it.
432
433 * callproc.c (call_process_cleanup) [MSDOS]: Don't close and
434 unlink the temporary file if Fcall_process didn't create it in the
435 first place.
436 (Fcall_process) [MSDOS]: Don't create tempfile if stdout of the
437 child process will be redirected to a file specified with `:file'.
438 Don't try to re-open tempfile in that case, and set fd[0] to -1 as
439 cue to call_process_cleanup not to close that handle.
440
441 2011-05-07 Ben Key <bkey76@gmail.com>
442
443 * makefile.w32-in: The bootstrap-temacs rule now makes use of
444 one of two shell specific rules, either bootstrap-temacs-CMD or
445 bootstrap-temacs-SH. The bootstrap-temacs-SH rule is identical
446 to the previous implementation of the bootstrap-temacs rule.
447 The bootstrap-temacs-CMD rule is similar to the previous
448 implementation of the bootstrap-temacs rule except that it
449 makes use of the ESC_CFLAGS variable instead of the CFLAGS
450 variable.
451
452 These changes, along with some changes to nt/configure.bat,
453 nt/gmake.defs, and nt/nmake.defs, are required to extend my
454 earlier fix to add support for --cflags and --ldflags options
455 that include quotes so that it works whether make uses cmd or
456 sh as the shell.
457
458 2011-05-06 Michael Albinus <michael.albinus@gmx.de>
459
460 * dbusbind.c (QCdbus_type_unix_fd): Declare static.
461 (xd_remove_watch): Don't check QCdbus_type_unix_fd for SYMBOLP, it
462 is a constant.
463 (Fdbus_init_bus, xd_read_queued_messages): Bus can be a symbol or
464 a string. Handle both cases.
465 (Fdbus_call_method_asynchronously, Fdbus_register_signal)
466 (Fdbus_register_method): Use Qinvalid_function.
467
468 2011-05-06 Juanma Barranquero <lekktu@gmail.com>
469
470 * makefile.w32-in: Update dependencies.
471 (LISP_H): Add inttypes.h and stdin.h.
472 (PROCESS_H): Add unistd.h.
473
474 2011-05-06 Eli Zaretskii <eliz@gnu.org>
475
476 * lread.c: Include limits.h (fixes the MS-Windows build broken by
477 2011-05-06T07:13:19Z!eggert@cs.ucla.edu).
478
479 2011-05-06 Paul Eggert <eggert@cs.ucla.edu>
480
481 * image.c (Finit_image_library) [!HAVE_NTGUI]: Omit unused local.
482
483 * term.c (vfatal): Remove stray call to va_end.
484 It's not needed and the C Standard doesn't allow it here anyway.
485
486 Use C99's va_copy to avoid undefined behavior on x86-64 GNU/Linux.
487 * eval.c (verror): doprnt a copy of ap, not the original. (Bug#8545)
488
489 * eval.c (verror): OK to create a string of up to MOST_POSITIVE_FIXNUM
490 bytes.
491
492 * term.c: Don't include <stdarg.h>, as <lisp.h> does that.
493
494 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
495
496 * process.c (Fformat_network_address): Fix typo: args2 -> *args2.
497
498 * xmenu.c (set_frame_menubar): Fix typo: int * -> int (3 times).
499
500 * coding.c (detect_coding_charset): Fix typo: * 2 -> *4 (Bug#8601).
501
502 * charset.h (struct charset.code_space): Now has 15 elements, not 16.
503 * charset.c (Fdefine_charset_internal): Don't initialize
504 charset.code_space[15]. The value was garbage, on hosts with
505 32-bit int (Bug#8600).
506
507 * lread.c (read_integer): Be more consistent with string-to-number.
508 Use string_to_number to do the actual conversion; this avoids
509 rounding errors and fixes some other screwups. Without this fix,
510 for example, #x1fffffffffffffff was misread as -2305843009213693952.
511 (digit_to_number): Move earlier, for benefit of read_integer.
512 Return -1 if the digit is out of range for the base, -2 if it is
513 not a digit in any supported base. (Bug#8602)
514
515 * doprnt.c (doprnt): Support arbitrary pI values, such as "I64".
516
517 * dispnew.c (scrolling_window): Return 1 if we scrolled,
518 to match comment at start of function. This also removes a
519 GCC warning about overflow in a 32+64-bit port.
520
521 * lisp.h (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Simplify.
522
523 * dbusbind.c: Do not use XPNTR on a value that may be an integer.
524 Reported by Stefan Monnier in
525 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00919.html>.
526 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
527 Use SYMBOLP-guarded XSYMBOL, not XPNTR.
528
529 * lisp.h (EMACS_INTPTR): Remove. All uses changed to intptr_t.
530 (EMACS_UINTPTR): Likewise, with uintptr_t.
531
532 * lisp.h: Prefer 64-bit EMACS_INT if available.
533 (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Define to 64-bit
534 on 32-bit hosts that have 64-bit int, so that they can access
535 large files.
536 However, temporarily disable this change unless the temporary
537 symbol WIDE_EMACS_INT is defined.
538
539 * lread.c, process.c: Do not include <inttypes.h>; lisp.h does it now.
540
541 Prefer intptr_t/uintptr_t for integers the same widths as pointers.
542 This removes an assumption that EMACS_INT and long are the same
543 width as pointers. The assumption is true for Emacs porting targets
544 now, but we want to make other targets possible.
545 * lisp.h: Include <inttypes.h>, for INTPTR_MAX, UINTPTR_MAX.
546 (EMACS_INTPTR, EMACS_UINTPTR): New macros.
547 In the rest of the code, change types of integers that hold casted
548 pointers to EMACS_INTPTR and EMACS_UINTPTR, systematically
549 replacing EMACS_INT, long, EMACS_UINT, and unsigned long.
550 (XTYPE): Don't cast arg to EMACS_UINT; normally is not needed.
551 (XSET): Cast type of XTYPE arg to EMACS_INTPTR; it is needed here.
552 No need to cast type when ORing.
553 (XPNTR): Return a value of type EMACS_INTPTR or EMACS_UINTPTR.
554 * alloc.c (lisp_align_malloc): Remove a no-longer-needed cast.
555 * doc.c (store_function_docstring): Use EMACS_INTPTR, so as not to
556 assume EMACS_INT is the same width as char *.
557 * gtkutil.c (xg_gtk_scroll_destroy, xg_tool_bar_button_cb):
558 (xg_tool_bar_callback, xg_tool_bar_help_callback, xg_make_tool_item):
559 Remove no-longer-needed casts.
560 (xg_create_scroll_bar, xg_tool_bar_button_cb, xg_tool_bar_callback):
561 (xg_tool_bar_help_callback, xg_make_tool_item):
562 Use EMACS_INTPTR to hold an integer
563 that will be cast to void *; this can avoid a GCC warning
564 if EMACS_INT is not the same width as void *.
565 * menu.c (find_and_call_menu_selection): Remove no-longer-needed cast.
566 * xdisp.c (display_echo_area_1, resize_mini_window_1):
567 (current_message_1, set_message_1):
568 Use a local to convert to proper width without a cast.
569 * xmenu.c (dialog_selection_callback): Likewise.
570
571 * sysdep.c (get_random): Don't assume EMACS_INT is no wider than long.
572 Also, don't assume VALBITS / RAND_BITS is less than 5,
573 and don't rely on undefined behavior when shifting a 1 left into
574 the sign bit.
575 * lisp.h (get_random): Change signature to match.
576
577 * lread.c (hash_string): Use size_t, not int, for hash computation.
578 Normally we prefer signed values; but hashing is special, because
579 it's better to use unsigned division on hash table sizes so that
580 the remainder is nonnegative. Also, size_t is the natural width
581 for hashing into memory. The previous code used 'int', which doesn't
582 retain enough info to hash well into very large tables.
583 (oblookup, oblookup_last_bucket_number, Funintern): Likewise.
584
585 * dbusbind.c: Don't possibly lose pointer info when converting.
586 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
587 Use XPNTR rather than XHASH, so that the high-order bits of
588 the pointer aren't lost when converting through void *.
589
590 * eval.c (Fautoload): Don't double-shift a pointer.
591
592 * fns.c (Frandom): Let EMACS_UINT be wider than unsigned long.
593
594 2011-05-06 Juanma Barranquero <lekktu@gmail.com>
595
596 * gnutls.c (DEF_GNUTLS_FN):
597 * image.c (DEF_IMGLIB_FN): Make function pointers static.
598
599 2011-05-05 Andreas Schwab <schwab@linux-m68k.org>
600
601 * lread.c (lisp_file_lexically_bound_p): Stop scanning at end
602 marker. (Bug#8610)
603
604 2011-05-05 Eli Zaretskii <eliz@gnu.org>
605
606 * w32heap.c (allocate_heap) [USE_LISP_UNION_TYPE || USE_LSB_TAG]:
607 New version that can reserve upto 2GB of heap space.
608
609 2011-05-05 Chong Yidong <cyd@stupidchicken.com>
610
611 * nsfns.m (Fns_read_file_name): Doc fix (Bug#8534).
612
613 2011-05-05 Teodor Zlatanov <tzz@lifelogs.com>
614
615 * gnutls.c (fn_gnutls_certificate_set_x509_key_file): Add alias to
616 `gnutls_certificate_set_x509_key_file'.
617
618 2011-05-05 Juanma Barranquero <lekktu@gmail.com>
619
620 * makefile.w32-in ($(BLD)/image.$(O), $(BLD)/process.$(O)):
621 Update dependencies.
622
623 2011-05-04 Juanma Barranquero <lekktu@gmail.com>
624
625 * gnutls.h (emacs_gnutls_write, emacs_gnutls_read):
626 * gnutls.c (emacs_gnutls_write, emacs_gnutls_read):
627 Remove unused parameter `fildes'.
628 * process.c (read_process_output, send_process): Don't pass it.
629
630 2011-05-04 Juanma Barranquero <lekktu@gmail.com>
631
632 Fix previous change: the library cache is defined in w32.c.
633 * image.c (CACHE_IMAGE_TYPE) [!HAVE_NTGUI]: Define to noop.
634 (Finit_image_library): Wrap Vlibrary_cache on "#ifdef HAVE_NTGUI".
635
636 2011-05-04 Juanma Barranquero <lekktu@gmail.com>
637
638 Implement dynamic loading of GnuTLS on Windows.
639
640 * gnutls.h (GNUTLS_EMACS_ERROR_NOT_LOADED): New macro.
641 (emacs_gnutls_write, emacs_gnutls_read): Mark as extern.
642 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
643 Declare.
644
645 * gnutls.c (Qgnutls_dll): Define.
646 (DEF_GNUTLS_FN, LOAD_GNUTLS_FN): New macros.
647 (gnutls_*): Declare function pointers.
648 (init_gnutls_functions): New function to initialize function pointers.
649 (emacs_gnutls_handshake, Fgnutls_error_string, Fgnutls_deinit)
650 (emacs_gnutls_global_init, Fgnutls_bye): Use function pointers.
651 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
652 Wrappers for gnutls_record_check_pending and gnutls_transport_set_errno.
653 (emacs_gnutls_write, emacs_gnutls_read)
654 (emacs_gnutls_handle_error, Fgnutls_error_fatalp)
655 (Fgnutls_available_p): New function.
656 (Fgnutls_boot): Call Fgnutls_available_p. Use function pointers.
657 (syms_of_gnutls) <Qgnutls_dll>: Initialize and staticpro it.
658 (syms_of_gnutls) <Sgnutls_available_p>: defsubr it.
659
660 * image.c: Include w32.h.
661 (Vimage_type_cache): Delete.
662 (syms_of_image) <Vimage_type_cache>: Don't initialize and staticpro it.
663 (CACHE_IMAGE_TYPE, Finit_image_library): Use Vlibrary_cache instead.
664 (w32_delayed_load): Move to w32.c.
665
666 * w32.h (VlibraryCache, QCloaded_from, w32_delayed_load): Declare.
667
668 * w32.c (QCloaded_from, Vlibrary_cache): Define.
669 (w32_delayed_load): Move from image.c. When loading a library, record
670 its filename in the :loaded-from property of the library id.
671 (globals_of_w32) <QCloaded_from, Vlibrary_cache>:
672 Initialize and staticpro them.
673 (emacs_gnutls_pull, emacs_gnutls_push): Call emacs_gnutls_* functions.
674
675 * process.c: Include lisp.h before w32.h, not after.
676 (wait_reading_process_output): Call emacs_gnutls_record_check_pending
677 instead of gnutls_record_check_pending.
678
679 * callproc.c, emacs.c: Include lisp.h before w32.h, not after.
680
681 2011-05-04 Teodor Zlatanov <tzz@lifelogs.com>
682
683 * gnutls.c (Fgnutls_boot): Support :keylist and :crlfiles options
684 instead of :keyfiles. Give GnuTLS the keylist and the CRL lists
685 as passed in.
686
687 2011-05-03 Jan Djärv <jan.h.d@swipnet.se>
688
689 * xterm.c (x_set_frame_alpha): Do not set property on anything
690 else than FRAME_X_OUTER_WINDOW (Bug#8608).
691
692 2011-05-02 Juanma Barranquero <lekktu@gmail.com>
693
694 * sysdep.c (get_tty_size) [WINDOWSNT]: Implement. (Bug#8596)
695
696 2011-05-02 Juanma Barranquero <lekktu@gmail.com>
697
698 * gnutls.c (Qgnutls_log_level, Qgnutls_code, Qgnutls_anon)
699 (Qgnutls_x509pki, Qgnutls_e_interrupted, Qgnutls_e_again)
700 (Qgnutls_e_invalid_session, Qgnutls_e_not_ready_for_handshake)
701 (gnutls_global_initialized, Qgnutls_bootprop_priority)
702 (Qgnutls_bootprop_trustfiles, Qgnutls_bootprop_keyfiles)
703 (Qgnutls_bootprop_callbacks, Qgnutls_bootprop_loglevel)
704 (Qgnutls_bootprop_hostname, Qgnutls_bootprop_verify_flags)
705 (Qgnutls_bootprop_verify_error, Qgnutls_bootprop_verify_hostname_error)
706 (Qgnutls_bootprop_callbacks_verify): Make static.
707
708 2011-05-01 Andreas Schwab <schwab@linux-m68k.org>
709
710 * callproc.c: Indentation fixup.
711
712 * sysdep.c (wait_for_termination_1): Make static.
713 (wait_for_termination, interruptible_wait_for_termination):
714 Move after wait_for_termination_1.
715
716 2011-05-01 Lars Magne Ingebrigtsen <larsi@gnus.org>
717
718 * sysdep.c (interruptible_wait_for_termination): New function
719 which is like wait_for_termination, but allows keyboard
720 interruptions.
721
722 * callproc.c (Fcall_process): Add (:file "file") as an option for
723 the STDOUT buffer.
724 (Fcall_process_region): Ditto.
725
726 2011-04-30 Eli Zaretskii <eliz@gnu.org>
727
728 * dosfns.c (Fint86, Fdos_memget, Fdos_memput): Use `ASIZE (FOO)'
729 rather than `XVECTOR (FOO)->size'.
730
731 * process.c: Remove HAVE_INTTYPES_H condition from inclusion of
732 inttypes.h, as a gnulib replacement is used if it not available in
733 system headers.
734
735 2011-04-21 Eli Zaretskii <eliz@gnu.org>
736
737 Lift the MOST_POSITIVE_FIXNUM/4 limitation on visited files.
738 * fileio.c (Finsert_file_contents): Don't limit file size to 1/4
739 of MOST_POSITIVE_FIXNUM. (Bug#8528)
740
741 * coding.c (coding_alloc_by_realloc): Error out if destination
742 will grow beyond MOST_POSITIVE_FIXNUM.
743 (decode_coding_emacs_mule): Abort if there isn't enough place in
744 charbuf for the composition carryover bytes. Reserve an extra
745 space for up to 2 characters produced in a loop.
746 (decode_coding_iso_2022): Abort if there isn't enough place in
747 charbuf for the composition carryover bytes.
748
749 2011-04-21 Eli Zaretskii <eliz@gnu.org>
750
751 * doprnt.c (doprnt) [!HAVE_LONG_LONG_INT]: Error out instead of
752 aborting when %lld or %lll format is passed.
753 [!HAVE_UNSIGNED_LONG_LONG_INT]: Error out instead of aborting when
754 %llo or %llx format is passed. (Bug#8545)
755
756 * window.c (window_scroll_line_based): Use a marker instead of
757 simple variables to record original value of point. (Bug#7952)
758
759 * doprnt.c (doprnt): Fix the case where a multibyte sequence
760 produced by %s or %c overflows available buffer space. (Bug#8545)
761
762 2011-04-28 Paul Eggert <eggert@cs.ucla.edu>
763
764 * doprnt.c (doprnt): Omit useless test; int overflow check (Bug#8545).
765 (SIZE_MAX): Move defn after all includes, as they might #define it.
766
767 2011-04-28 Juanma Barranquero <lekktu@gmail.com>
768
769 * w32.c (init_environment): Warn about defaulting HOME to C:\.
770
771 2011-04-28 Juanma Barranquero <lekktu@gmail.com>
772
773 * keyboard.c (Qdelayed_warnings_hook): Define.
774 (command_loop_1): Run `delayed-warnings-hook'
775 if Vdelayed_warnings_list is non-nil.
776 (syms_of_keyboard) <delayed-warnings-hook>: DEFSYM it.
777 (syms_of_keyboard) <delayed-warnings-list>: DEFVAR_LISP it.
778
779 2011-04-28 Eli Zaretskii <eliz@gnu.org>
780
781 * doprnt.c (doprnt): Don't return value smaller than the buffer
782 size if the message was truncated. (Bug#8545).
783
784 2011-04-28 Juanma Barranquero <lekktu@gmail.com>
785
786 * w32fns.c (Fx_change_window_property, Fx_delete_window_property)
787 (Fx_window_property): #if-0 the whole functions, not just the bodies.
788
789 2011-04-27 Paul Eggert <eggert@cs.ucla.edu>
790
791 * doprnt.c (doprnt): Support "ll" length modifier, for long long.
792
793 2011-04-27 Juanma Barranquero <lekktu@gmail.com>
794
795 * makefile.w32-in: Update dependencies.
796
797 2011-04-27 Eli Zaretskii <eliz@gnu.org>
798
799 Improve `doprnt' and its usage. (Bug#8545)
800 * doprnt.c (doprnt): Make sure `format' is never accessed beyond
801 `format_end'. Remove support for %l as a conversion specifier.
802 Don't use xrealloc. Improve diagnostics when the %l size modifier
803 is used. Update the commentary.
804
805 * eval.c (verror): Simplify calculation of size_t.
806
807 * coding.c (Ffind_operation_coding_system): Fix diagnostic error
808 messages.
809
810 2011-04-27 Yoshiaki Kasahara <kasahara@nc.kyushu-u.ac.jp> (tiny change)
811
812 * buffer.c (init_buffer) [USE_MMAP_FOR_BUFFERS]: Adjust to aliasing
813 change.
814
815 2011-04-27 Paul Eggert <eggert@cs.ucla.edu>
816
817 * nsmenu.m: Replace all uses of XVECTOR with ASIZE and AREF.
818 This makes this file independent of the recent pseudovector change.
819
820 2011-04-26 Paul Eggert <eggert@cs.ucla.edu>
821
822 * keyboard.c (handle_user_signal): Fix pointer signedness problem.
823
824 * gnutls.c (emacs_gnutls_handle_error): Remove unused local.
825 (Fgnutls_boot): gnutls_certificate_verify_peers2 wants unsigned *.
826 Remove unused local.
827 (emacs_gnutls_write): Don't use uninitialized rtnval if nbyte <= 0.
828
829 * lisp.h: Fix a problem with aliasing and vector headers. (Bug#8546)
830 GCC 4.6.0 optimizes based on type-based alias analysis.
831 For example, if b is of type struct buffer * and v of type struct
832 Lisp_Vector *, then gcc -O2 was incorrectly assuming that &b->size
833 != &v->size, and therefore "v->size = 1; b->size = 2; return
834 v->size;" must therefore return 1. This assumption is incorrect
835 for Emacs, since it type-puns struct Lisp_Vector * with many other
836 types. To fix this problem, this patch adds a new type struct
837 vectorlike_header that documents the constraints on layout of vectors
838 and pseudovectors, and helps optimizing compilers not get fooled
839 by Emacs's type punning. It also adds the macros XSETTYPED_PVECTYPE
840 XSETTYPED_PSEUDOVECTOR, TYPED_PSEUDOVECTORP, for similar reasons.
841 * lisp.h (XSETTYPED_PVECTYPE): New macro, specifying the name of
842 the size member.
843 (XSETPVECTYPE): Rewrite in terms of new macro.
844 (XSETPVECTYPESIZE): New macro, specifying both type and size.
845 This is a bit clearer, and further avoids the possibility of
846 undesirable aliasing.
847 (XSETTYPED_PSEUDOVECTOR): New macro, specifying the size.
848 (XSETPSEUDOVECTOR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR.
849 (XSETSUBR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR and XSIZE,
850 since Lisp_Subr is a special case (no "next" field).
851 (ASIZE): Now uses header.size rather than size.
852 All previous uses of XVECTOR (foo)->size replaced to use this macro,
853 to avoid the hassle of writing XVECTOR (foo)->header.size.
854 (struct vectorlike_header): New type.
855 (TYPED_PSEUDOVECTORP): New macro, also specifying the C type of the
856 object, to help avoid aliasing.
857 (PSEUDOVECTORP): Rewrite in terms of TYPED_PSEUDOVECTORP.
858 (SUBRP): Likewise, since Lisp_Subr is a special case.
859 * lisp.h (struct Lisp_Vector, struct Lisp_Char_Table):
860 (struct Lisp_Sub_Char_Table, struct Lisp_Bool_Vector):
861 (struct Lisp_Hash_Table): Combine first two members into a single
862 struct vectorlike_header member. All uses of "size" and "next" members
863 changed to be "header.size" and "header.next".
864 * buffer.h (struct buffer): Likewise.
865 * font.h (struct font_spec, struct font_entity, struct font): Likewise.
866 * frame.h (struct frame): Likewise.
867 * process.h (struct Lisp_Process): Likewise.
868 * termhooks.h (struct terminal): Likewise.
869 * window.c (struct save_window_data, struct saved_window): Likewise.
870 * window.h (struct window): Likewise.
871 * alloc.c (allocate_buffer, Fmake_bool_vector, allocate_pseudovector):
872 Use XSETPVECTYPESIZE, not XSETPVECTYPE, to avoid aliasing problems.
873 * buffer.c (init_buffer_once): Likewise.
874 * lread.c (defsubr): Use XSETTYPED_PVECTYPE, since Lisp_Subr is a
875 special case.
876 * process.c (Fformat_network_address): Use local var for size,
877 for brevity.
878
879 * bytecode.c (exec_byte_code): Don't use XVECTOR before CHECK_VECTOR.
880
881 Make the Lisp reader and string-to-float more consistent (Bug#8525)
882 * data.c (atof): Remove decl; no longer used or needed.
883 (digit_to_number): Move to lread.c.
884 (Fstring_to_number): Use new string_to_number function, to be
885 consistent with how the Lisp reader treats infinities and NaNs.
886 Do not assume that floating-point numbers represent EMACS_INT
887 without losing information; this is not true on most 64-bit hosts.
888 Avoid double-rounding errors, by insisting on integers when
889 parsing non-base-10 numbers, as the documentation specifies.
890 * lisp.h (string_to_number): New decl, replacing ...
891 (isfloat_string): Remove.
892 * lread.c: Include <inttypes.h>, for uintmax_t and strtoumax.
893 (read1): Do not accept +. and -. as integers; this
894 appears to have been a coding error. Similarly, do not accept
895 strings like +-1e0 as floating point numbers. Do not report
896 overflow for integer overflows unless the base is not 10 which
897 means we have no simple and reliable way to continue.
898 Break out the floating-point parsing into a new
899 function string_to_number, so that Fstring_to_number parses
900 floating point numbers consistently with the Lisp reader.
901 (digit_to_number): Move here from data.c. Make it static inline.
902 (E_CHAR, EXP_INT): Remove, replacing with ...
903 (E_EXP): New macro, to solve the "1.0e+" problem mentioned below.
904 (string_to_number): New function, replacing isfloat_string.
905 This function checks for valid syntax and produces the resulting
906 Lisp float number too. Rework it so that string-to-number
907 no longer mishandles examples like "1.0e+". Use strtoumax,
908 so that overflow for non-base-10 numbers is reported only when
909 there's no portable and simple way to convert to floating point.
910
911 * textprop.c (set_text_properties_1): Rewrite for clarity,
912 and to avoid GCC warning about integer overflow.
913
914 * intervals.h (struct interval): Use EMACS_INT for members
915 where EMACS_UINT might cause problems. See
916 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html>.
917 (CHECK_TOTAL_LENGTH): Remove cast to EMACS_INT; no longer needed.
918 * intervals.c (interval_deletion_adjustment): Now returns EMACS_INT.
919 All uses changed.
920 (offset_intervals): Tell GCC not to worry about length overflow
921 when negating a negative length.
922
923 * alloc.c (overrun_check_malloc, overrun_check_realloc): Now static.
924 (overrun_check_free): Likewise.
925
926 * alloc.c (SDATA_SIZE) [!GC_CHECK_STRING_BYTES]: Avoid runtime check
927 in the common case where SDATA_DATA_OFFSET is a multiple of Emacs
928 word size.
929
930 * gnutls.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
931 (gnutls_make_error): Rename local to avoid shadowing.
932 (gnutls_emacs_global_deinit): ifdef out; not used.
933 (Fgnutls_boot): Use const for pointer to readonly storage.
934 Comment out unused local. Fix pointer signedness problems.
935
936 * lread.c (openp): Don't stuff size_t into an 'int'.
937 Use <= on length, not < on length + 1, to avoid GCC 4.6.0 warning
938 about possible signed overflow.
939
940 * gtkutil.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
941 (GDK_KEY_g): Don't define if already defined.
942 (xg_prepare_tooltip): Avoid pointer signedness problem.
943 (xg_set_toolkit_scroll_bar_thumb): Redo to avoid two casts.
944
945 * process.c (Fnetwork_interface_info): Avoid left-shift undefined
946 behavior with 1 << 31. GCC 4.6.0 warns about this on 32-bit hosts.
947
948 * xfns.c (Fx_window_property): Simplify a bit,
949 to make a bit faster and to avoid GCC 4.6.0 warning.
950 * xselect.c (x_get_window_property, x_handle_dnd_message): Likewise.
951
952 * fns.c (internal_equal): Don't assume size_t fits in int.
953
954 * alloc.c (compact_small_strings): Tighten assertion a little.
955
956 Replace pEd with more-general pI, and fix some printf arg casts.
957 * lisp.h (pI): New macro, generalizing old pEd macro to other
958 conversion specifiers. For example, use "...%"pI"d..." rather
959 than "...%"pEd"...".
960 (pEd): Remove. All uses replaced with similar uses of pI.
961 * src/m/amdx86-64.h, src/m/ia64.h, src/m/ibms390x.h: Likewise.
962 * alloc.c (check_pure_size): Don't overflow by converting size to int.
963 * bidi.c (bidi_dump_cached_states): Use pI to avoid cast.
964 * data.c (Fnumber_to_string): Use pI instead of if-then-else-abort.
965 * dbusbind.c (xd_append_arg): Use pI to avoid cast.
966 (Fdbus_method_return_internal, Fdbus_method_error_internal): Likewise.
967 * font.c (font_unparse_xlfd): Avoid potential buffer overrun on
968 64-bit hosts.
969 (font_unparse_xlfd, font_unparse_fcname): Use pI to avoid casts.
970 * keyboard.c (record_char, modify_event_symbol): Use pI to avoid casts.
971 * print.c (safe_debug_print, print_object): Likewise.
972 (print_object): Don't overflow by converting EMACS_INT or EMACS_UINT
973 to int.
974 Use pI instead of if-then-else-abort. Use %p to avoid casts,
975 avoiding the 0 flag, which is not portable.
976 * process.c (Fmake_network_process): Use pI to avoid cast.
977 * region-cache.c (pp_cache): Likewise.
978 * xdisp.c (decode_mode_spec): Likewise.
979 * xrdb.c (x_load_resources) [USE_MOTIF]: Use pI to avoid undefined
980 behavior on 64-bit hosts with printf arg.
981 * xselect.c (x_queue_event): Use %p to avoid casts, avoiding 0 flag.
982 (x_stop_queuing_selection_requests): Likewise.
983 (x_get_window_property): Don't truncate byte count to an 'int'
984 when tracing.
985
986 * frame.c (frame_name_fnn_p): Get rid of strtol, which isn't right
987 here, since it parses constructs like leading '-' and spaces,
988 which are not wanted; and it overflows with large numbers.
989 Instead, simply match F[0-9]+, which is what is wanted anyway.
990
991 * alloc.c: Remove unportable assumptions about struct layout.
992 (SDATA_SELECTOR, SDATA_DATA_OFFSET): New macros.
993 (SDATA_OF_STRING, SDATA_SIZE, allocate_string_data):
994 (allocate_vectorlike, make_pure_vector): Use the new macros,
995 plus offsetof, to remove unportable assumptions about struct layout.
996 These assumptions hold on all porting targets that I know of, but
997 they are not guaranteed, they're easy to remove, and removing them
998 makes further changes easier.
999
1000 * alloc.c (BLOCK BYTES): Fix typo by changing "ablock" to "ablocks".
1001 This doesn't fix a bug but makes the code clearer.
1002 (string_overrun_cookie): Now const. Use initializers that
1003 don't formally overflow signed char, to avoid warnings.
1004 (allocate_string_data) [GC_CHECK_STRING_OVERRUN]: Fix typo that
1005 can cause Emacs to crash when string overrun checking is enabled.
1006 (allocate_buffer): Don't assume sizeof (struct buffer) is a
1007 multiple of sizeof (EMACS_INT); it need not be, if
1008 alignof(EMACS_INT) < sizeof (EMACS_INT).
1009 (check_sblock, check_string_bytes, check_string_free_list): Protoize.
1010
1011 2011-04-26 Juanma Barranquero <lekktu@gmail.com>
1012
1013 * keyboard.c (QCrtl): Rename from Qrtl. All uses changed.
1014
1015 2011-04-26 Teodor Zlatanov <tzz@lifelogs.com>
1016
1017 * gnutls.c (emacs_gnutls_handshake): Return an error if we're not
1018 supposed to be handshaking. (Bug#8556)
1019 Reported by Paul Eggert <eggert@cs.ucla.edu>.
1020
1021 2011-04-26 Daniel Colascione <dan.colascione@gmail.com>
1022
1023 * lisp.h (Qdebug): List symbol.
1024 * eval.c (Qdebug): Restore global linkage.
1025 * keyboard.c (debug-on-event): New variable.
1026 (handle_user_signal): Break into debugger when debug-on-event
1027 matches the current signal symbol.
1028
1029 2011-04-25 Dan Nicolaescu <dann@ics.uci.edu>
1030
1031 * alloc.c (check_sblock, check_string_bytes)
1032 (check_string_free_list): Convert to standard C.
1033
1034 2011-04-25 Teodor Zlatanov <tzz@lifelogs.com>
1035
1036 * w32.c (emacs_gnutls_push): Fix typo.
1037
1038 2011-04-25 Eli Zaretskii <eliz@gnu.org>
1039
1040 * gnutls.c (emacs_gnutls_handshake): Avoid compiler warnings about
1041 "cast to pointer from integer of different size".
1042
1043 Improve doprnt and its use in verror. (Bug#8545)
1044 * doprnt.c (doprnt): Document the set of format control sequences
1045 supported by the function. Use SAFE_ALLOCA instead of always
1046 using `alloca'.
1047
1048 * eval.c (verror): Don't limit the buffer size at size_max-1, that
1049 is one byte too soon. Don't use xrealloc; instead xfree and
1050 xmalloc anew.
1051
1052 2011-04-24 Teodor Zlatanov <tzz@lifelogs.com>
1053
1054 * gnutls.h: Add GNUTLS_STAGE_CALLBACKS enum to denote we're in the
1055 callbacks stage.
1056
1057 * gnutls.c: Renamed global_initialized to
1058 gnutls_global_initialized. Added internals for the
1059 :verify-hostname-error, :verify-error, and :verify-flags
1060 parameters of `gnutls-boot' and documented those parameters in the
1061 docstring. Start callback support.
1062 (emacs_gnutls_handshake): Add Woe32 support. Retry handshake
1063 unless a fatal error occured. Call gnutls_alert_send_appropriate
1064 on error. Return error code.
1065 (emacs_gnutls_write): Call emacs_gnutls_handle_error.
1066 (emacs_gnutls_read): Likewise.
1067 (Fgnutls_boot): Return handshake error code.
1068 (emacs_gnutls_handle_error): New function.
1069 (wsaerror_to_errno): Likewise.
1070
1071 * w32.h (emacs_gnutls_pull): Add prototype.
1072 (emacs_gnutls_push): Likewise.
1073
1074 * w32.c (emacs_gnutls_pull): New function for GnuTLS on Woe32.
1075 (emacs_gnutls_push): Likewise.
1076
1077 2011-04-24 Claudio Bley <claudio.bley@gmail.com> (tiny change)
1078
1079 * process.c (wait_reading_process_output): Check if GnuTLS
1080 buffered some data internally if no FDs are set for TLS
1081 connections.
1082
1083 * makefile.w32-in (OBJ2): Add gnutls.$(O).
1084 (LIBS): Link to USER_LIBS.
1085 ($(BLD)/gnutls.$(0)): New target.
1086
1087 2011-04-24 Eli Zaretskii <eliz@gnu.org>
1088
1089 * xdisp.c (handle_single_display_spec): Rename the
1090 display_replaced_before_p argument into display_replaced_p, to
1091 make it consistent with the commentary. Fix typos in the
1092 commentary.
1093
1094 * textprop.c (syms_of_textprop): Remove dead code.
1095 (copy_text_properties): Delete obsolete commentary about an
1096 interface that was deleted long ago. Fix typos in the description
1097 of arguments.
1098
1099 * msdos.c (XMenuActivate, XMenuAddSelection): Adjust argument list
1100 to changes in oldXMenu/XMenu.h from 2011-04-16.
1101 <menu_help_message, prev_menu_help_message>: Constify.
1102 (IT_menu_make_room): menu->help_text is now `const char **';
1103 adjust.
1104
1105 * msdos.h (XMenuActivate, XMenuAddSelection): Adjust prototypes
1106 to changes in oldXMenu/XMenu.h from 2011-04-16.
1107 (struct XMenu): Declare `help_text' `const char **'.
1108
1109 * xfaces.c <Qunspecified>: Make extern again.
1110
1111 * syntax.c: Include sys/types.h before including regex.h, as
1112 required by Posix.
1113
1114 * doc.c (get_doc_string): Improve the format passed to `error'.
1115
1116 * doprnt.c (doprnt): Improve commentary.
1117
1118 * term.c (init_tty) [MSDOS]: Fix 1st argument to maybe_fatal.
1119
1120 * Makefile.in (TAGS): Depend on $(M_FILE) and $(S_FILE), and scan
1121 them with etags.
1122
1123 * makefile.w32-in (globals.h): Add a dummy recipe, to make any
1124 changes in globals.h immediately force recompilation.
1125 (TAGS): Depend on $(CURDIR)/m/intel386.h and
1126 $(CURDIR)/s/ms-w32.h.
1127 (TAGS-gmake): Scan $(CURDIR)/m/intel386.h and $(CURDIR)/s/ms-w32.h.
1128
1129 * character.c (Fchar_direction): Function deleted.
1130 (syms_of_character): Don't defsubr it.
1131 <char-direction-table>: Deleted.
1132
1133 2011-04-23 Eli Zaretskii <eliz@gnu.org>
1134
1135 Fix doprnt so it could be used again safely in `verror'. (Bug#8435)
1136 * doprnt.c: Include limits.h.
1137 (SIZE_MAX): New macro.
1138 (doprnt): Return a size_t value. 2nd arg is now size_t.
1139 Many local variables are now size_t instead of int or unsigned.
1140 Improve overflow protection. Support `l' modifier for integer
1141 conversions. Support %l conversion. Don't assume an EMACS_INT
1142 argument for integer conversions and for %c.
1143
1144 * lisp.h (doprnt): Restore prototype.
1145
1146 * makefile.w32-in ($(BLD)/callint.$(O)): Depend on
1147 $(SRC)/character.h.
1148
1149 * Makefile.in (base_obj): Add back doprnt.o.
1150
1151 * deps.mk (doprnt.o): Add back prerequisites.
1152 (callint.o): Depend on character.h.
1153
1154 * eval.c (internal_lisp_condition_case): Include the handler
1155 representation in the error message.
1156 (verror): Call doprnt instead of vsnprintf. Fix an off-by-one bug
1157 when breaking from the loop.
1158
1159 * xdisp.c (vmessage): Call doprnt instead of vsnprintf.
1160
1161 * callint.c (Fcall_interactively): When displaying error message
1162 about invalid control letter, pass the character's codepoint, not
1163 a pointer to its multibyte form. Improve display of the character
1164 in octal and display also its hex code.
1165
1166 * character.c (char_string): Use %x to display the (unsigned)
1167 codepoint of an invalid character, to avoid displaying a bogus
1168 negative value.
1169
1170 * font.c (check_otf_features): Pass SDATA of SYMBOL_NAME to
1171 `error', not SYMBOL_NAME itself.
1172
1173 * coding.c (Fencode_sjis_char, Fencode_big5_char): Use %c for
1174 character arguments to `error'.
1175
1176 * charset.c (check_iso_charset_parameter): Fix incorrect argument
1177 to `error' in error message about FINAL_CHAR argument. Make sure
1178 FINAL_CHAR is a character, and use %c when it is passed as
1179 argument to `error'.
1180
1181 2011-04-23 Eli Zaretskii <eliz@gnu.org>
1182
1183 * s/ms-w32.h (localtime): Redirect to sys_localtime.
1184
1185 * w32.c: Include <time.h>.
1186 (sys_localtime): New function.
1187
1188 2011-04-23 Chong Yidong <cyd@stupidchicken.com>
1189
1190 * xdisp.c (init_xdisp): Initialize echo_area_window (Bug#6451).
1191
1192 * buffer.c (syms_of_buffer): Doc fix (Bug#6902).
1193
1194 2011-04-23 Samuel Thibault <sthibault@debian.org> (tiny change)
1195
1196 * sysdep.c (wait_for_termination): On GNU Hurd, kill returns -1 on
1197 zombies (Bug#8467).
1198
1199 2011-04-19 Eli Zaretskii <eliz@gnu.org>
1200
1201 * syntax.h (SETUP_SYNTAX_TABLE_FOR_OBJECT): Fix setting of
1202 gl_state.e_property when gl_state.object is Qt.
1203
1204 * insdel.c (make_gap_larger): Remove limitation of buffer size
1205 to <= INT_MAX.
1206
1207 2011-04-18 Chong Yidong <cyd@stupidchicken.com>
1208
1209 * xdisp.c (lookup_glyphless_char_display)
1210 (produce_glyphless_glyph): Handle cons cell entry in
1211 glyphless-char-display.
1212 (Vglyphless_char_display): Document it.
1213
1214 * term.c (produce_glyphless_glyph): Handle cons cell entry in
1215 glyphless-char-display.
1216
1217 2011-04-17 Chong Yidong <cyd@stupidchicken.com>
1218
1219 * xdisp.c (get_next_display_element): Remove unnecessary ifdefs.
1220
1221 * termhooks.h (FRAME_WINDOW_P): Remove duplicated definitions.
1222
1223 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): Add missing
1224 definition for no-X builds.
1225
1226 2011-04-16 Paul Eggert <eggert@cs.ucla.edu>
1227
1228 Static checks with GCC 4.6.0 and non-default toolkits.
1229
1230 * s/sol2-6.h, s/unixware.h (PTY_TTY_NAME_SPRINTF): Protoize decl.
1231
1232 * process.c (keyboard_bit_set): Define only if SIGIO.
1233 (send_process_trap): Mark it with NO_RETURN if it doesn't return.
1234 (send_process): Repair possible setjmp clobbering.
1235
1236 * s/usg5-4-common.h (SETUP_SLAVE_PTY): Don't pass extra arg to 'fatal'.
1237
1238 * eval.c: Include <stdio.h>, for vsnprintf on non-GNU/Linux hosts.
1239
1240 * data.c (arith_error): Mark with NO_RETURN if it doesn't return.
1241
1242 * alloc.c (bytes_used_when_full, SPARE_MEMORY, BYTES_USED):
1243 Define only if needed.
1244
1245 * sysdep.c (_FILE_OFFSET_BITS): Make this hack even uglier
1246 by pacifying GCC about it. Maybe it's time to retire it?
1247 * xfaces.c (USG, __TIMEVAL__): Likewise.
1248
1249 * dispextern.h (struct redisplay_interface): Rename param
1250 to avoid shadowing.
1251 * termhooks.h (struct terminal): Likewise.
1252 * xterm.c (xembed_send_message): Likewise.
1253
1254 * insdel.c (make_gap_smaller): Define only if
1255 USE_MMAP_FOR_BUFFERS || REL_ALLOC || DOUG_LEA_MALLOC.
1256
1257 * keyboard.c (read_char): Make a var volatile so longjmp won't clobber
1258 it.
1259
1260 * emacs.c (MAX_HEAP_BSS_DIFF, my_edata): Move to where they're used,
1261 so that we aren't warned about unused symbols.
1262
1263 * xfns.c (Fx_file_dialog): Rename local to avoid shadowing.
1264
1265 * xdisp.c (x_produce_glyphs): Mark var as initialized (Bug#8512).
1266
1267 * xfns.c (x_real_positions): Mark locals as initialized.
1268
1269 * xmenu.c (xmenu_show): Don't use uninitialized vars.
1270
1271 * xterm.c: Fix problems found by static analysis with other toolkits.
1272 (toolkit_scroll_bar_interaction): Define and use only if USE_X_TOOLKIT.
1273 (x_dispatch_event): Declare static if USE_GTK, and
1274 define if USE_GTK || USE_X_TOOLKIT.
1275 (SET_SAVED_BUTTON_EVENT): Define only if USE_X_TOOLKIT || USE_GTK.
1276 * xterm.h (x_dispatch_event): Extern only if USE_X_TOOLKIT.
1277 * xterm.c, xterm.h (x_mouse_leave): Bring this function back, but only
1278 if defined HAVE_MENUS && !defined USE_X_TOOLKIT && !defined USE_GTK.
1279
1280 * xmenu.c (menu_help_callback): Pointer type fixes.
1281 Use const pointers when pointing at readonly data. Avoid pointer
1282 signedness clashes.
1283 (FALSE): Remove unused macro.
1284 (update_frame_menubar): Remove unused decl.
1285
1286 * xfns.c (Fx_hide_tip): Move locals to avoid shadowing.
1287
1288 * menu.c (push_submenu_start, push_submenu_end): Do not define unless
1289 USE_X_TOOLKIT || USE_GTK || HAVE_NS || defined HAVE_NTGUI.
1290 (single_menu_item): Rename local to avoid shadowing.
1291
1292 * keyboard.c (make_lispy_event): Remove unused local var.
1293
1294 * frame.c, frame.h (x_get_resource_string): Bring this back, but
1295 only if HAVE_X_WINDOWS && !USE_X_TOOLKIT.
1296
1297 * bitmaps: Change bitmaps from unsigned char back to the X11
1298 compatible char. Avoid the old compiler warnings about
1299 out-of-range initializers by using, for example, '\xab' rather
1300 than 0xab.
1301
1302 * xgselect.c (xgselect_initialize): Check vs interface
1303 even if ! (defined (USE_GTK) || defined (HAVE_GCONF)).
1304
1305 * xmenu.c (xmenu_show): Rename parm to avoid shadowing.
1306
1307 * xterm.c (x_create_toolkit_scroll_bar): Use const * for pointers
1308 to read-only memory.
1309
1310 * fns.c (vector): Remove; this old hack is no longer needed.
1311
1312 * xsmfns.c (create_client_leader_window): Rename shadowing arg.
1313 Remove unused var.
1314 (gdk_x11_set_sm_client_id) [!USE_GTK]: Don't define.
1315
1316 * xrdb.c (x_load_resources): Omit unused local.
1317
1318 * xfns.c (free_frame_menubar, atof): Remove duplicate decls.
1319 (x_window): Rename locals to avoid shadowing.
1320 (USG): Use the kludged USG macro, to pacify gcc.
1321
1322 * xterm.c (x_alloc_nearest_color_for_widget): Remove; unused.
1323 (x_term_init): Remove local to avoid shadowing.
1324
1325 * xfns.c, xterm.c (_XEditResCheckMessages): Protoize decl.
1326
1327 * xdisp.c, dispextern.h (set_vertical_scroll_bar): Now extern if
1328 USE_TOOLKIT_SCROLL_BARS && !USE_GTK, as xterm.c needs it then.
1329
1330 2011-04-16 Eli Zaretskii <eliz@gnu.org>
1331
1332 * gnutls.c (Fgnutls_boot): Don't pass Lisp_Object to `error'.
1333
1334 Fix regex.c, syntax.c and friends for buffers > 2GB.
1335 * syntax.h (struct gl_state_s): Declare character position members
1336 EMACS_INT.
1337
1338 * syntax.c (update_syntax_table): Declare 2nd argument EMACS_INT.
1339
1340 * textprop.c (verify_interval_modification, interval_of):
1341 Declare arguments EMACS_INT.
1342
1343 * intervals.c (adjust_intervals_for_insertion): Declare arguments
1344 EMACS_INT.
1345
1346 * intervals.h (CHECK_TOTAL_LENGTH): Cast to EMACS_INT, not `int'.
1347
1348 * indent.c (Fvertical_motion): Local variable it_start is now
1349 EMACS_INT.
1350
1351 * regex.c (re_match, re_match_2, re_match_2_internal)
1352 (bcmp_translate, regcomp, regexec, print_double_string)
1353 (group_in_compile_stack, re_search, re_search_2, regex_compile)
1354 (re_compile_pattern, re_exec): Declare arguments and local
1355 variables `size_t' and `ssize_t' and return values `regoff_t', as
1356 appropriate.
1357 (POP_FAILURE_REG_OR_COUNT) <pfreg>: Declare `long'.
1358 (CHECK_INFINITE_LOOP) <failure>: Declare `ssize_t'.
1359 <compile_stack_type>: `size' and `avail' are now `size_t'.
1360
1361 * regex.h <regoff_t>: Use ssize_t, not int.
1362 (re_search, re_search_2, re_match, re_match_2): Arguments that
1363 specify buffer/string position and length are now ssize_t and
1364 size_t. Return type is regoff_t.
1365
1366 2011-04-16 Ben Key <bkey76@gmail.com>
1367
1368 * nsfont.m: Fixed bugs in ns_get_family and
1369 ns_descriptor_to_entity that were caused by using free to
1370 deallocate memory blocks that were allocated by xmalloc (via
1371 xstrdup). This caused Emacs to crash when compiled with
1372 XMALLOC_OVERRUN_CHECK defined (when Emacs was configured with
1373 --enable-checking=xmallocoverrun). xfree is now used to
1374 deallocate these memory blocks.
1375
1376 2011-04-15 Paul Eggert <eggert@cs.ucla.edu>
1377
1378 * sysdep.c (emacs_read): Remove unnecessary check vs MAX_RW_COUNT.
1379
1380 emacs_write: Accept and return EMACS_INT for sizes.
1381 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html
1382 et seq.
1383 * gnutls.c, gnutls.h (emacs_gnutls_read, emacs_gnutls_write):
1384 Accept and return EMACS_INT.
1385 (emacs_gnutls_write): Return the number of bytes written on
1386 partial writes.
1387 * sysdep.c, lisp.h (emacs_read, emacs_write): Likewise.
1388 (emacs_read, emacs_write): Remove check for negative size, as the
1389 Emacs source code has been audited now.
1390 * sysdep.c (MAX_RW_COUNT): New macro, to work around kernel bugs.
1391 (emacs_read, emacs_write): Use it.
1392 * process.c (send_process): Adjust to the new signatures of
1393 emacs_write and emacs_gnutls_write. Do not attempt to store
1394 a byte offset into an 'int'; it might overflow.
1395 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00483.html
1396
1397 * sound.c: Don't assume sizes fit in 'int'.
1398 (struct sound_device.period_size, alsa_period_size):
1399 Return EMACS_INT, not int.
1400 (struct sound_device.write, vox_write, alsa_write):
1401 Accept EMACS_INT, not int.
1402 (wav_play, au_play): Use EMACS_INT to store sizes and to
1403 record read return values.
1404
1405 2011-04-15 Ben Key <bkey76@gmail.com>
1406
1407 * keyboard.c (Qundefined): Don't declare static since it is used
1408 in nsfns.m.
1409 * xfaces.c (Qbold, Qexpanded, Qitalic, Qcondensed): Don't declare
1410 static since they are used in nsfont.m.
1411
1412 2011-04-15 Stefan Monnier <monnier@iro.umontreal.ca>
1413
1414 * process.c (Qprocessp): Don't declare static.
1415 * lisp.h (Qprocessp): Declare again.
1416
1417 2011-04-15 Juanma Barranquero <lekktu@gmail.com>
1418
1419 * font.c (Qopentype): Don't make static (used from w32uniscribe.c).
1420
1421 2011-04-14 Paul Eggert <eggert@cs.ucla.edu>
1422
1423 Improve C-level modularity by making more things 'static'.
1424
1425 Don't publish debugger-only interfaces to other modules.
1426 * lisp.h (safe_debug_print, debug_output_compilation_hack):
1427 (verify_bytepos, count_markers): Move decls to the only modules
1428 that need them.
1429 * region-cache.h (pp_cache): Likewise.
1430 * window.h (check_all_windows): Likewise.
1431 * marker.c, print.c, region-cache.c, window.c: Decls moved here.
1432
1433 * sysdep.c (croak): Now static, if
1434 defined TIOCNOTTY || defined USG5 || defined CYGWIN.
1435 * syssignal.h (croak): Declare only if not static.
1436
1437 * alloc.c (refill_memory_reserve): Now static if
1438 !defined REL_ALLOC || defined SYSTEM_MALLOC.
1439 * lisp.h (refill_memory_reserve): Declare only if not static.
1440
1441 * xsettings.c, xsettings.h (xsettings_get_system_normal_font):
1442 Define only if USE_LUCID.
1443
1444 * xrdb.c (x_customization_string, x_rm_string): Now static.
1445
1446 * xmenu.c (x_menu_wait_for_event): Export only if USE_MOTIF.
1447 * xterm.h (x_menu_wait_for_event): Declare only if USE_MOTIF.
1448
1449 * xdisp.c (draw_row_with_mouse_face): Now static.
1450 * dispextern.h (draw_row_with_mouse_fave): Remove decl.
1451
1452 * window.h (check_all_windows): Mark externally visible.
1453
1454 * window.c (window_deletion_count): Now static.
1455
1456 * undo.c: Make symbols static if they're not exported.
1457 (last_undo_buffer, last_boundary_position, pending_boundary):
1458 Now static.
1459
1460 * textprop.c (interval_insert_behind_hooks): Now static.
1461 (interval_insert_in_front_hooks): Likewise.
1462
1463 * term.c: Make symbols static if they're not exported.
1464 (tty_turn_off_highlight, get_tty_terminal, max_frame_cols):
1465 (max_frame_lines, tty_set_terminal_modes):
1466 (tty_reset_terminal_modes, tty_turn_off_highlight):
1467 (get_tty_terminal): Now static.
1468 (term_mouse_moveto): Do not define if HAVE_WINDOW_SYSTEM.
1469 * termhooks.h (term_mouse_moveto): Do not declare if
1470 HAVE_WINDOW_SYSTEM.
1471 * dispextern.h (tty_set_terminal_modes, tty_reset_terminal_modes):
1472 (tty_turn_off_highlight, get_tty_terminal): Remove decls.
1473
1474 * sysdep.c: Make symbols static if they're not exported.
1475 (emacs_get_tty, emacs_set_tty, old_fcntl_flags, old_fcntl_owner):
1476 Now static.
1477 (sigprocmask_set, full_mask): Remove; unused.
1478 (wait_debugging): Mark as visible.
1479 * syssignal.h (SIGFULLMASK, full_mask): Remove decls.
1480 * systty.h (emacs_get_tty, emacs_set_tty): Remove decls.
1481
1482 * syntax.c (syntax_temp): Define only if !__GNUC__.
1483
1484 * sound.c (current_sound_device, current_sound): Now static.
1485
1486 * search.c (searchbufs, searchbuf_head): Now static.
1487
1488 * scroll.c (scroll_cost): Remove; unused.
1489 * dispextern.h (scroll_cost): Remove decl.
1490
1491 * region-cache.h (pp_cache): Mark as externally visible.
1492
1493 * process.c: Make symbols static if they're not exported.
1494 (process_tick, update_tick, create_process, chan_process):
1495 (Vprocess_alist, proc_buffered_char, datagram_access):
1496 (fd_callback_data, send_process_frame, process_sent_to): Now static.
1497 (deactivate_process): Mark defn as static, as well as decl.
1498 * lisp.h (create_process): Remove decl.
1499 * process.h (chan_process, Vprocess_alist): Remove decls.
1500
1501 * print.c: Make symbols static if they're not exported.
1502 (print_depth, new_backquote_output, being_printed, print_buffer):
1503 (print_buffer_size, print_buffer_pos, print_buffer_pos_byte):
1504 (print_interval, print_number_index, initial_stderr_stream):
1505 Now static.
1506 * lisp.h (Fprinc): Remove decl.
1507 (debug_output_compilation_hack): Mark as externally visible.
1508
1509 * sysdep.c (croak): Move decl from here to syssignal.h.
1510 * syssignal.h (croak): Put it here, so the API can be checked when
1511 'croak' is called from dissociate_if_controlling_tty.
1512
1513 * minibuf.c: Make symbols static if they're not exported.
1514 (minibuf_save_list, choose_minibuf_frame): Now static.
1515 * lisp.h (choose_minibuf_frame): Remove decl.
1516
1517 * lisp.h (verify_bytepos, count_markers): Mark as externally visible.
1518
1519 * lread.c: Make symbols static if they're not exported.
1520 (read_objects, initial_obarray, oblookup_last_bucket_number):
1521 Now static.
1522 (make_symbol): Remove; unused.
1523 * lisp.h (initial_obarray, make_symbol): Remove decls.
1524
1525 * keyboard.c: Make symbols static if they're not exported.
1526 (single_kboard, recent_keys_index, total_keys, recent_keys):
1527 (this_command_key_count_reset, raw_keybuf, raw_keybuf_count):
1528 (this_single_command_key_start, echoing, last_auto_save):
1529 (read_key_sequence_cmd, dribble, recursive_edit_unwind):
1530 (command_loop, echo_now, keyboard_init_hook, help_char_p):
1531 (quit_throw_to_read_char, command_loop_2, top_level_1, poll_timer):
1532 (Vlispy_mouse_stem, double_click_count):
1533 Now static.
1534 (force_auto_save_soon): Define only if SIGDANGER.
1535 (ignore_mouse_drag_p): Now static if
1536 !defined HAVE_WINDOW_SYSTEM || defined USE_GTK || defined HAVE_NS.
1537 (print_help): Remove; unused.
1538 (stop_character, last_timer_event): Mark as externally visible.
1539 * keyboard.h (ignore_mouse_drag_p): Declare only if
1540 defined HAVE_WINDOW_SYSTEM && !defined USE_GTK && !defined HAVE_NS.
1541 (echo_now, help_char_p, quit_throw_to_read_char): Remove decls.
1542 * lisp.h (echoing): Remove decl.
1543 (force_auto_save_soon): Declare only if SIGDANGER.
1544 * xdisp.c (redisplay_window): Simplify code, to make it more
1545 obvious that ignore_mouse_drag_p is not accessed if !defined
1546 USE_GTK && !defined HAVE_NS.
1547
1548 * intervals.c: Make symbols static if they're not exported.
1549 (merge_properties_sticky, merge_interval_right, delete_interval):
1550 Now static.
1551 * intervals.h (merge_interval_right, delete_interval): Remove decls.
1552
1553 * insdel.c: Make symbols static if they're not exported.
1554 However, leave prepare_to_modify_buffer alone. It's never
1555 called from outside this function, but that appears to be a bug.
1556 (combine_after_change_list, combine_after_change_buffer):
1557 (adjust_after_replace, signal_before_change): Now static.
1558 (adjust_after_replace_noundo): Remove; unused.
1559 * lisp.h (adjust_after_replace, adjust_after_replace_noundo):
1560 (signal_before_change): Remove decls.
1561
1562 * indent.c (val_compute_motion, val_vmotion): Now static.
1563
1564 * image.c: Make symbols static if they're not exported.
1565 * dispextern.h (x_create_bitmap_from_xpm_data): Do not declare
1566 if USE_GTK.
1567 * image.c (x_create_bitmap_from_xpm_data): Do not define if USE_GTK.
1568 (xpm_color_cache, ct_table, ct_colors_allocated): Now static.
1569
1570 * fringe.c (standard_bitmaps): Now static.
1571 (max_used_fringe_bitmap): Now static, unless HAVE_NS.
1572
1573 * frame.c: Make symbols static if they're not exported.
1574 (x_report_frame_params, make_terminal_frame): Now static.
1575 (get_frame_param): Now static, unless HAVE_NS.
1576 (x_fullscreen_adjust): Define if WINDOWSNT, not if HAVE_WINDOW_SYSTEM.
1577 (x_get_resource_string): Remove; not used.
1578 * frame.h (make_terminal_frame, x_report_frame_params):
1579 (x_get_resource_string); Remove decls.
1580 (x_fullscreen_adjust): Declare only if WINDOWSNT.
1581 * lisp.h (get_frame_param): Declare only if HAVE_NS.
1582
1583 * font.c, fontset.c: Make symbols static if they're not exported.
1584 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): New macro.
1585 (FACE_SUITABLE_FOR_CHAR_P): Use it.
1586 * font.c (font_close_object): Now static.
1587 * font.h (font_close_object): Remove.
1588 * fontset.c (FONTSET_OBJLIST): Remove.
1589 (free_realized_fontset) #if-0 the body, which does nothing.
1590 (face_suitable_for_char_p): #if-0, as it's never called.
1591 * fontset.h (face_suitable_for_char_p): Remove decl.
1592 * xfaces.c (face_at_string_position):
1593 Use FACE_SUITABLE_FOR_ASCII_CHAR_P, not FACE_SUITABLE_FOR_CHAR_P,
1594 since 0 is always ASCII.
1595
1596 * fns.c (weak_hash_tables): Now static.
1597
1598 * fileio.c: Make symbols static if they're not exported.
1599 (auto_saving, auto_save_mode_bits, auto_save_error_occurred):
1600 (Vwrite_region_annotation_buffers): Now static.
1601
1602 * eval.c: Make symbols static if they're not exported.
1603 (backtrace_list, lisp_eval_depth, when_entered_debugger): Now static.
1604 * lisp.h (backtrace_list): Remove decl.
1605
1606 * emacs.c: Make symbols static if they're not exported.
1607 (malloc_state_ptr, malloc_using_checking, syms_of_emacs):
1608 (fatal_error_code, fatal_error_signal_hook, standard_args):
1609 Now static.
1610 (fatal_error_signal): Now static, unless FLOAT_CATCH_SIGKILL.
1611 (DEFINE_DUMMY_FUNCTION): Mark function as externally visible.
1612 (__CTOR_LIST__, __DTOR_LIST__): Now externally visible.
1613 * lisp.h (fatal_error_signal_hook): Remove decl.
1614 (fatal_error_signal): Declare only if FLOAT_CATCH_SIGKILL.
1615
1616 * editfns.c: Move a (normally-unused) function to its only use.
1617 * editfns.c, lisp.h (get_operating_system_release): Remove.
1618 * process.c (init_process) [DARWIN_OS]: Do it inline, as it is not
1619 worth the hassle of breaking this out.
1620
1621 * xterm.c: Make symbols static if they're not exported.
1622 (x_raise_frame, x_lower_frame, x_wm_set_window_state):
1623 (x_wm_set_icon_pixmap, x_initialize, XTread_socket_fake_io_error):
1624 (x_destroy_window, x_delete_display):
1625 Now static.
1626 (x_dispatch_event): Now static if ! (USE_MOTIF || USE_X_TOOLKIT).
1627 (x_mouse_leave): Remove; unused.
1628 * xterm.h (x_display_info_for_name, x_raise_frame, x_lower_frame):
1629 (x_destroy_window, x_wm_set_window_state, x_wm_set_icon_pixmap):
1630 (x_delete_display, x_initialize, x_set_border_pixel, x_screen_planes):
1631 Remove decls.
1632 (x_mouse_leave): Declare only if WINDOWSNT.
1633 (x_dispatch_event): Declare only if USE_MOTIF or USE_X_TOOLKIT.
1634 (xic_create_fontsetname): Declare only if HAVE_X_WINDOWS &&
1635 USE_X_TOOLKIT.
1636
1637 * ftxfont.c: Make symbols static if they're not exported.
1638 (ftxfont_driver): Export only if !defined HAVE_XFT && def8ined
1639 HAVE_FREETYPE.
1640 * font.h (ftxfont_driver): Likewise.
1641
1642 * xfns.c: Make symbols static if they're not exported.
1643 (x_last_font_name, x_display_info_for_name):
1644 (x_set_foreground_color, x_set_background_color, x_set_mouse_color):
1645 (x_set_cursor_color, x_set_border_pixel, x_set_border_color):
1646 (x_set_cursor_type, x_set_icon_type, x_set_icon_name):
1647 (x_set_scroll_bar_foreground, x_set_scroll_bar_background):
1648 (x_explicitly_set_name, x_set_title, xic_defaut_fontset, tip_timer):
1649 (last_show_tip_args): Now static.
1650 (xic_defaut_fontset, xic_create_fontsetname): Define only if
1651 defined HAVE_X_WINDOWS && defined USE_X_TOOLKIT
1652 (x_screen_planes): Remove; unused.
1653 * dispextern.h (x_screen_planes): Remove decl.
1654
1655 * dispnew.c: Make symbols static if they're not exported.
1656 * dispextern.h (redraw_garbaged_frames, scrolling):
1657 (increment_row_positions): Remove.
1658 * dispnew.c (new_glyph_matrix, increment_row_positions, scrolling):
1659 (delayed_size_change, glyph_matrix_count, glyph_pool_count):
1660 Now static.
1661 (redraw_garbaged_frames): Remove; unused.
1662
1663 * xfaces.c: Make symbols static if they're not exported.
1664 * dispextern.h (ascii_face_of_lisp_face, free_realized_face):
1665 Remove decls.
1666 * xterm.h (defined_color): Remove decls.
1667 (x_free_dpy_colors): Declare only if USE_X_TOOLKIT.
1668 * xfaces.c (tty_suppress_bold_inverse_default_colors_p):
1669 (menu_face_changed_default, defined_color, free_realized_face):
1670 (x_free_dpy_colors): Define only if USE_X_TOOLKIT.
1671 (ascii_face_of_lisp_face): Remove; unused.
1672
1673 * xdisp.c: Make symbols static if they're not exported.
1674 * dispextern.h (scratch_glyph_row, window_box_edges):
1675 (glyph_to_pixel_coords, set_cursor_from_row):
1676 (get_next_display_element, set_iterator_to_next):
1677 (highlight_trailing_whitespace, frame_to_window_pixel_xy):
1678 (show_mouse_face): Remove decls
1679 * frame.h (message_buf_print): Likewise.
1680 * lisp.h (pop_message, set_message, check_point_in_composition):
1681 Likewise.
1682 * xterm.h (set_vertical_scroll_bar): Likewise.
1683 * xdisp.c (list_of_error, Vmessage_stack, line_number_displayed):
1684 (message_buf_print, scratch_glyph_row, displayed_buffer):
1685 (set_iterator_to_next, pop_message, set_message, set_cursor_from_row):
1686 (get_next_display_element, show_mouse_face, window_box_edges):
1687 (frame_to_window_pixel_xy, check_point_in_composition):
1688 (set_vertical_scroll_bar, highlight_trailing_whitespace): Now static.
1689 (glyph_to_pixel_coords): Remove; unused.
1690
1691 * dired.c (file_name_completion): Now static.
1692
1693 * dbusbind.c (xd_in_read_queued_messages): Now static.
1694
1695 * lisp.h (circular_list_error, FOREACH): Remove; unused.
1696 * data.c (circular_list_error): Remove.
1697
1698 * commands.h (last_point_position, last_point_position_buffer):
1699 (last_point_position_window): Remove decls.
1700 * keyboard.c: Make these variables static.
1701
1702 * coding.h (coding, code_convert_region, encode_coding_gap):
1703 Remove decls.
1704 * coding.c (Vsjis_coding_system, Vbig5_coding_system):
1705 (iso_code_class, detect_coding, code_convert_region): Now static.
1706 (encode_coding_gap): Remove; unused.
1707
1708 * chartab.c (chartab_chars, chartab_bits): Now static.
1709
1710 * charset.h (charset_iso_8859_1): Remove decl.
1711 * charset.c (charset_iso_8859_1, charset_emacs, map_charset_for_dump):
1712 Now static.
1713
1714 * ccl.h (check_ccl_update, Vccl_program_table): Remove decls.
1715 * ccl.c (Vccl_program_table): Now static.
1716 (check_ccl_update): Remove; unused.
1717
1718 * category.c (SET_CATEGORY_SET, set_category_set): Move here.
1719 * category.h: ... from here.
1720 * category.c (check_category_table, set_category_set): Now static.
1721
1722 * casetab.c (Vascii_upcase_table, Vascii_eqv_table): Now static.
1723 * lisp.h: Remove these decls.
1724
1725 * buffer.c (buffer_count): Remove unused var.
1726
1727 * bidi.c (bidi_dump_cached_states): Mark as externally visible,
1728 so that it's not optimized away.
1729 (bidi_ignore_explicit_marks_for_paragraph_level): Likewise.
1730 * dispextern.h (bidi_dump_cached_states): Remove, since it's
1731 exported only to the debugger.
1732
1733 * atimer.c (alarm_signal_handler, run_all_atimers): Now static.
1734 * atimer.h (run_all_atimers): Remove; not exported.
1735
1736 font.c: Make copy_font_spec and merge_font_spec ordinary C functions.
1737 * font.c (copy_font_spec): Rename from Fcopy_font_spec, since it
1738 was inaccessible from Lisp.
1739 (merge_font_spec): Likewise, renaming from Fmerge_font_spec.
1740 * font.c, font.h, fontset.c, xfaces.c, xfont.c: Change all uses.
1741
1742 alloc.c: Import and export fewer symbols, and remove unused items.
1743 * lisp.h (suppress_checking, die): Declare only if ENABLE_CHECKING
1744 is defined.
1745 (suppress_checking): Add EXTERNALLY_VISIBLE attribute, so that
1746 it's not optimized away by whole-program optimization.
1747 (message_enable_multibyte, free_misc): Remove.
1748 (catchlist, handlerlist, mark_backtrace):
1749 Declare only if BYTE_MARK_STACK.
1750 (mark_byte_stack): Likewise, fixing a ifdef-vs-if typo.
1751 * alloc.c (pure): Export only if VIRT_ADDR_VARIES is defined.
1752 (message_enable_multibyte): Remove decl.
1753 (free_misc, interval_free_list, float_block, float_block_index):
1754 (n_float_blocks, float_free_list, cons_block, cons_block_index):
1755 (cons_free_list, last_marked_index):
1756 Now static.
1757 (suppress_checking, die): Define only if ENABLE_CHECKING is defined.
1758 * eval.c (catchlist, handlerlist): Export only if BYTE_MARK_STACK.
1759 (mark_backtrace): Define only if BYTE_MARK_STACK.
1760 * xdisp.c (message_enable_multibyte): Now static.
1761
1762 Declare Lisp_Object Q* variables to be 'static' if not exported.
1763 This makes it easier for human readers (and static analyzers)
1764 to see whether these variables are used from other modules.
1765 * alloc.c, buffer.c, bytecode.c, callint.c, casetab.c, category.c:
1766 * ccl.c, character.c, charset.c, cmds.c, coding.c, composite.c:
1767 * data.c, dbusbind.c, dired.c, editfns.c, eval.c, fileio.c, fns.c:
1768 * font.c, frame.c, fringe.c, ftfont.c, image.c, keyboard.c, keymap.c:
1769 * lread.c, macros.c, minibuf.c, print.c, process.c, search.c:
1770 * sound.c, syntax.c, textprop.c, window.c, xdisp.c, xfaces.c, xfns.c:
1771 * xmenu.c, xselect.c:
1772 Declare Q* vars static if they are not used in other modules.
1773 * ccl.h, character.h, charset.h, coding.h, composite.h, font.h:
1774 * frame.h, intervals.h, keyboard.h, lisp.h, process.h, syntax.h:
1775 Remove decls of unexported vars.
1776 * keyboard.h (EVENT_HEAD_UNMODIFIED): Remove now-unused macro.
1777
1778 * lisp.h (DEFINE_FUNC): Make sname 'static'.
1779
1780 Make Emacs functions such as Fatom 'static' by default.
1781 This makes it easier for human readers (and static analyzers)
1782 to see whether these functions can be called from other modules.
1783 DEFUN now defines a static function. To make the function external
1784 so that it can be used in other C modules, use the new macro DEFUE.
1785 * lisp.h (Funibyte_char_to_multibyte, Fsyntax_table_p):
1786 (Finit_image_library):
1787 (Feval_region, Fbacktrace, Ffetch_bytecode, Fswitch_to_buffer):
1788 (Ffile_executable_p, Fmake_symbolic_link, Fcommand_execute):
1789 (Fget_process, Fdocumentation_property, Fbyte_code, Ffile_attributes):
1790 Remove decls, since these functions are now static.
1791 (Funintern, Fget_internal_run_time): New decls, since these functions
1792 were already external.
1793
1794 * alloc.c, buffer.c, callint.c, callproc.c, casefiddle.c, casetab.c:
1795 * ccl.c, character.c, chartab.c, cmds.c, coding.c, data.c, dispnew.c:
1796 * doc.c, editfns.c, emacs.c, eval.c, fileio.c, filelock.c, floatfns.c:
1797 * fns.c, font.c, fontset.c, frame.c, image.c, indent.c:
1798 * keyboard.c, keymap.c, lread.c:
1799 * macros.c, marker.c, menu.c, minibuf.c, print.c, process.c, search.c:
1800 * syntax.c, term.c, terminal.c, textprop.c, undo.c:
1801 * window.c, xdisp.c, xfaces.c, xfns.c, xmenu.c, xsettings.c:
1802 Mark functions with DEFUE instead of DEFUN,
1803 if they are used in other modules.
1804 * buffer.c (Fset_buffer_major_mode, Fdelete_overlay): New forward
1805 decls for now-static functions.
1806 * buffer.h (Fdelete_overlay): Remove decl.
1807 * callproc.c (Fgetenv_internal): Mark as internal.
1808 * composite.c (Fremove_list_of_text_properties): Remove decl.
1809 (Fcomposition_get_gstring): New forward static decl.
1810 * composite.h (Fcomposite_get_gstring): Remove decl.
1811 * dired.c (Ffile_attributes): New forward static decl.
1812 * doc.c (Fdocumntation_property): New forward static decl.
1813 * eval.c (Ffetch_bytecode): New forward static decl.
1814 (Funintern): Remove extern decl; now in .h file where it belongs.
1815 * fileio.c (Fmake_symbolic_link): New forward static decl.
1816 * image.c (Finit_image_library): New forward static decl.
1817 * insdel.c (Fcombine_after_change_execute): Make forward decl static.
1818 * intervals.h (Fprevious_property_change):
1819 (Fremove_list_of_text_properties): Remove decls.
1820 * keyboard.c (Fthis_command_keys): Remove decl.
1821 (Fcommand_execute): New forward static decl.
1822 * keymap.c (Flookup_key): New forward static decl.
1823 (Fcopy_keymap): Now static.
1824 * keymap.h (Flookup_key): Remove decl.
1825 * process.c (Fget_process): New forward static decl.
1826 (Fprocess_datagram_address): Mark as internal.
1827 * syntax.c (Fsyntax_table_p): New forward static decl.
1828 (skip_chars): Remove duplicate decl.
1829 * textprop.c (Fprevious_property_change): New forward static decl.
1830 * window.c (Fset_window_fringes, Fset_window_scroll_bars):
1831 Now internal.
1832 (Fset_window_margins, Fset_window_vscroll): New forward static decls.
1833 * window.h (Fset_window_vscroll, Fset_window_margins): Remove decls.
1834
1835 * editfns.c (Fformat): Remove unreachable code.
1836
1837 2011-04-14 Andreas Schwab <schwab@linux-m68k.org>
1838
1839 * fileio.c (Finsert_file_contents): Fix typo in 2005-05-13
1840 change. (Bug#8496)
1841
1842 2011-04-13 Eli Zaretskii <eliz@gnu.org>
1843
1844 * xdisp.c (handle_invisible_prop): Don't call bidi_paragraph_init
1845 when at ZV. (Bug#8487)
1846
1847 2011-04-12 Andreas Schwab <schwab@linux-m68k.org>
1848
1849 * charset.c (Fclear_charset_maps): Use xfree instead of free.
1850 (Bug#8437)
1851 * keyboard.c (parse_tool_bar_item): Likewise.
1852 * sound.c (sound_cleanup, alsa_close): Likewise.
1853 * termcap.c (tgetent): Likewise.
1854 * xfns.c (x_default_font_parameter): Likewise.
1855 * xsettings.c (read_and_apply_settings): Likewise.
1856
1857 * alloc.c (overrun_check_malloc, overrun_check_realloc)
1858 (overrun_check_free): Protoize.
1859
1860 2011-04-12 Paul Eggert <eggert@cs.ucla.edu>
1861
1862 * sysdep.c (emacs_read, emacs_write): Check for negative sizes
1863 since callers should never pass a negative size.
1864 Change the signature to match that of plain 'read' and 'write'; see
1865 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00397.html>.
1866 * lisp.h: Update prototypes of emacs_write and emacs_read.
1867
1868 2011-04-11 Eli Zaretskii <eliz@gnu.org>
1869
1870 * xdisp.c (redisplay_window): Don't try to determine the character
1871 position of the scroll margin if the window start point w->startp
1872 is outside the buffer's accessible region. (Bug#8468)
1873
1874 2011-04-10 Eli Zaretskii <eliz@gnu.org>
1875
1876 Fix write-region and its subroutines for buffers > 2GB.
1877 * fileio.c (a_write, e_write): Modify declaration of arguments and
1878 local variables to support buffers larger than 2GB.
1879 (Fcopy_file): Use EMACS_INT for return value of emacs_read.
1880
1881 * sysdep.c (emacs_write, emacs_read): Use ssize_t for last
1882 argument, local variables, and return value.
1883
1884 * lisp.h: Update prototypes of emacs_write and emacs_read.
1885
1886 * sound.c (vox_write): Use ssize_t for return value of emacs_write.
1887
1888 2011-04-10 Paul Eggert <eggert@cs.ucla.edu>
1889
1890 * xdisp.c (vmessage): Use memchr, not strnlen, which some hosts lack.
1891
1892 Fix more problems found by GCC 4.6.0's static checks.
1893
1894 * xdisp.c (vmessage): Use a better test for character truncation.
1895
1896 * charset.c (load_charset_map): <, not <=, for optimization,
1897 and to avoid potential problems with integer overflow.
1898 * chartab.c (sub_char_table_set_range, char_table_set_range): Likewise.
1899 * casetab.c (set_identity, shuffle): Likewise.
1900 * editfns.c (Fformat): Likewise.
1901 * syntax.c (skip_chars): Likewise.
1902
1903 * xmenu.c (set_frame_menubar): Allocate smaller local vectors.
1904 This also lets GCC 4.6.0 generate slightly better loop code.
1905
1906 * callint.c (Fcall_interactively): <, not <=, for optimization.
1907 (Fcall_interactively): Count the number of arguments produced,
1908 not the number of arguments given. This is simpler and lets GCC
1909 4.6.0 generate slightly better code.
1910
1911 * ftfont.c: Distingish more carefully between FcChar8 and char.
1912 The previous code passed unsigned char * to a functions like
1913 strlen and xstrcasecmp that expect char *, which does not
1914 conform to the C standard.
1915 (get_adstyle_property, ftfont_pattern_entity): Use FcChar8 for
1916 arguments to FcPatternGetString, and explicitly cast FcChar8 * to
1917 char * when the C standard requires it.
1918
1919 * keyboard.c (read_char): Remove unused var.
1920
1921 * eval.c: Port to Windows vsnprintf (Bug#8435).
1922 Include <limits.h>.
1923 (SIZE_MAX): Define if the headers do not.
1924 (verror): Do not give up if vsnprintf returns a negative count.
1925 Instead, grow the buffer. This ports to Windows vsnprintf, which
1926 does not conform to C99. Problem reported by Eli Zaretskii.
1927 Also, simplify the allocation scheme, by avoiding the need for
1928 calling realloc, and removing the ALLOCATED variable.
1929
1930 * eval.c (verror): Initial buffer size is 4000 (not 200) bytes.
1931
1932 Remove invocations of doprnt, as Emacs now uses vsnprintf.
1933 But keep the doprint source code for now, as we might revamp it
1934 and use it again (Bug#8435).
1935 * lisp.h (doprnt): Remove.
1936 * Makefile.in (base_obj): Remove doprnt.o.
1937 * deps.mk (doprnt.o): Remove.
1938
1939 error: Print 32- and 64-bit integers portably (Bug#8435).
1940 Without this change, on typical 64-bit hosts error ("...%d...", N)
1941 was used to print both 32- and 64-bit integers N, which relied on
1942 undefined behavior.
1943 * lisp.h, src/m/amdx86-64.h, src/m/ia64.h, src/m/ibms390x.h (pEd):
1944 New macro.
1945 * lisp.h (error, verror): Mark as printf-like functions.
1946 * eval.c (verror): Use vsnprintf, not doprnt, to do the real work.
1947 Report overflow in size calculations when allocating printf buffer.
1948 Do not truncate output string at its first null byte.
1949 * xdisp.c (vmessage): Use vsnprintf, not doprnt, to do the real work.
1950 Truncate the output at a character boundary, since vsnprintf does not
1951 do that.
1952 * charset.c (check_iso_charset_parameter): Convert internal
1953 character to string before calling 'error', since %c now has the
1954 printf meaning.
1955 * coding.c (Fdecode_sjis_char, Fdecode_big5_char): Avoid int
1956 overflow when computing char to be passed to 'error'. Do not
1957 pass Lisp_Object to 'error'; pass the integer instead.
1958 * nsfns.m (Fns_do_applescript): Use int, not long, since it's
1959 formatted with plain %d.
1960
1961 * eval.c (internal_lisp_condition_case): Don't pass spurious arg.
1962
1963 * keyboard.c (access_keymap_keyremap): Print func name, not garbage.
1964
1965 * coding.c (Fdecode_sjis_char): Don't assume CODE fits in int.
1966
1967 * xterm.c (x_catch_errors): Remove duplicate declaration.
1968
1969 * term.c (maybe_fatal): Mark its 3rd arg as a printf format, too.
1970
1971 * xdisp.c, lisp.h (message_nolog): Remove; unused.
1972
1973 2011-04-10 Jim Meyering <meyering@redhat.com>
1974
1975 use ssize_t and size_t for read- and write-like emacs_gnutls_* functions
1976 * gnutls.c (emacs_gnutls_read): Adjust signature to be more read-like:
1977 return ssize_t not "int", and use size_t as the buffer length.
1978 (emacs_gnutls_write): Likewise, and make the buffer pointer "const".
1979 * gnutls.h: Update declarations.
1980 * process.c (read_process_output): Use ssize_t, to match.
1981 (send_process): Likewise.
1982
1983 2011-04-09 Chong Yidong <cyd@stupidchicken.com>
1984
1985 * image.c (Fimagemagick_types): Doc fix, and comment cleanup.
1986
1987 2011-04-09 Chong Yidong <cyd@stupidchicken.com>
1988
1989 * ftfont.c (get_adstyle_property, ftfont_pattern_entity):
1990 Use unsigned char, to match FcChar8 type definition.
1991
1992 * xterm.c (handle_one_xevent):
1993 * xmenu.c (create_and_show_popup_menu):
1994 * xselect.c (x_decline_selection_request)
1995 (x_reply_selection_request): Avoid type-punned deref of X events.
1996
1997 2011-04-09 Eli Zaretskii <eliz@gnu.org>
1998
1999 Fix some uses of `int' instead of EMACS_INT.
2000 * search.c (string_match_1, fast_string_match)
2001 (fast_c_string_match_ignore_case, fast_string_match_ignore_case)
2002 (scan_buffer, find_next_newline_no_quit)
2003 (find_before_next_newline, search_command, Freplace_match)
2004 (Fmatch_data): Make some `int' variables be EMACS_INT.
2005
2006 * xdisp.c (display_count_lines): 3rd argument and return value now
2007 EMACS_INT. All callers changed.
2008 (pint2hrstr): Last argument is now EMACS_INT.
2009
2010 * coding.c (detect_coding_utf_8, detect_coding_emacs_mule)
2011 (detect_coding_iso_2022, detect_coding_sjis, detect_coding_big5)
2012 (detect_coding_ccl, detect_coding_charset, decode_coding_utf_8)
2013 (decode_coding_utf_16, decode_coding_emacs_mule)
2014 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5)
2015 (decode_coding_ccl, decode_coding_charset)
2016 <consumed_chars, consumed_chars_base>: Declare EMACS_INT.
2017 (decode_coding_iso_2022, decode_coding_emacs_mule)
2018 (decode_coding_sjis, decode_coding_big5, decode_coding_charset)
2019 <char_offset, last_offset>: Declare EMACS_INT.
2020 (encode_coding_utf_8, encode_coding_utf_16)
2021 (encode_coding_emacs_mule, encode_invocation_designation)
2022 (encode_designation_at_bol, encode_coding_iso_2022)
2023 (encode_coding_sjis, encode_coding_big5, encode_coding_ccl)
2024 (encode_coding_raw_text, encode_coding_charset) <produced_chars>:
2025 Declare EMACS_INT.
2026 (ASSURE_DESTINATION): Declare more_bytes EMACS_INT.
2027 (encode_invocation_designation): Last argument P_NCHARS is now
2028 EMACS_INT.
2029 (decode_eol): Declare pos_byte, pos, and pos_end EMACS_INT.
2030 (produce_chars): from_nchars and to_nchars are now EMACS_INT.
2031
2032 * coding.h (struct coding_system) <head_ascii>: Declare EMACS_INT.
2033 All users changed.
2034
2035 * ccl.c (Fccl_execute_on_string): Declare some variables
2036 EMACS_INT.
2037
2038 2011-04-08 Samuel Thibault <sthibault@debian.org> (tiny change)
2039
2040 * term.c (init_tty): Fix incorrect ifdef placement (Bug#8450).
2041
2042 2011-03-19 Christoph Scholtes <cschol2112@googlemail.com>
2043
2044 * process.c (Fformat_network_address): Doc fix.
2045
2046 2011-04-08 T.V. Raman <tv.raman.tv@gmail.com> (tiny change)
2047
2048 * xml.c (parse_region): Avoid creating spurious whiespace nodes.
2049
2050 2011-04-08 Chong Yidong <cyd@stupidchicken.com>
2051
2052 * keyboard.c (read_char): Call Lisp function help-form-show,
2053 instead of using internal_with_output_to_temp_buffer.
2054 (Qhelp_form_show): New var.
2055 (syms_of_keyboard): Use DEFSYM macro.
2056
2057 * print.c (internal_with_output_to_temp_buffer): Function deleted.
2058
2059 * lisp.h (internal_with_output_to_temp_buffer): Remove prototype.
2060
2061 2011-04-06 Chong Yidong <cyd@stupidchicken.com>
2062
2063 * process.c (Flist_processes): Remove to Lisp.
2064 (list_processes_1): Delete.
2065
2066 2011-04-06 Eli Zaretskii <eliz@gnu.org>
2067
2068 * msdos.c (careadlinkat, careadlinkatcwd): MS-DOS replacements.
2069
2070 * w32.c (careadlinkat, careadlinkatcwd): New always-fail stubs.
2071
2072 2011-04-06 Paul Eggert <eggert@cs.ucla.edu>
2073
2074 Fix more problems found by GCC 4.6.0's static checks.
2075
2076 * xmenu.c (Fx_popup_dialog): Don't assume string is free of formats.
2077
2078 * menu.c (Fx_popup_menu): Don't assume error_name lacks printf formats.
2079
2080 * lisp.h (message, message_nolog, fatal): Mark as printf-like.
2081
2082 * xdisp.c (vmessage): Mark as a printf-like function.
2083
2084 * term.c (vfatal, maybe_fatal): Mark as printf-like functions.
2085
2086 * sound.c (sound_warning): Don't crash if arg contains a printf format.
2087
2088 * image.c (tiff_error_handler, tiff_warning_handler): Mark as
2089 printf-like functions.
2090 (tiff_load): Add casts to remove these marks before passing them
2091 to system-supplied API.
2092
2093 * eval.c (Fsignal): Remove excess argument to 'fatal'.
2094
2095 * coding.c (EMIT_ONE_BYTE, EMIT_TWO_BYTES): Use unsigned, not int.
2096 This avoids several warnings with gcc -Wstrict-overflow.
2097 (DECODE_COMPOSITION_RULE): If the rule is invalid, goto invalid_code
2098 directly, rather than having caller test rule sign. This avoids
2099 some unnecessary tests.
2100 * composite.h (COMPOSITION_ENCODE_RULE_VALID): New macro.
2101 (COMPOSITION_ENCODE_RULE): Arguments now must be valid. This
2102 affects only one use, in DECODE_COMPOSITION_RULE, which is changed.
2103
2104 * xfont.c (xfont_text_extents): Remove var that was set but not used.
2105 (xfont_open): Avoid unnecessary tests.
2106
2107 * composite.c (composition_gstring_put_cache): Use unsigned integer.
2108
2109 * composite.h, composite.c (composition_gstring_put_cache):
2110 Use EMACS_INT, not int, for length.
2111
2112 * composite.h (COMPOSITION_DECODE_REFS): New macro,
2113 breaking out part of COMPOSITION_DECODE_RULE.
2114 (COMPOSITION_DECODE_RULE): Use it.
2115 * composite.c (get_composition_id): Remove unused local vars,
2116 by using the new macro.
2117
2118 * textprop.c (set_text_properties_1): Change while to do-while,
2119 since the condition is always true at first.
2120
2121 * intervals.c (graft_intervals_into_buffer): Mark var as used.
2122 (interval_deletion_adjustment): Return unsigned value.
2123 All uses changed.
2124
2125 * process.c (list_processes_1, create_pty, read_process_output):
2126 (exec_sentinel): Remove vars that were set but not used.
2127 (create_pty): Remove unnecessary "volatile"s.
2128 (Fnetwork_interface_info): Avoid possibility of int overflow.
2129 (read_process_output): Do adaptive read buffering even if carryover.
2130 (read_process_output): Simplify nbytes computation if buffered.
2131
2132 * bytecode.c (exec_byte_code): Rename local to avoid shadowing.
2133
2134 * syntax.c (scan_words): Remove var that was set but not used.
2135 (update_syntax_table): Use unsigned instead of int.
2136
2137 * lread.c (lisp_file_lexically_bound_p): Use ints rather than endptrs.
2138 (lisp_file_lexically_bound_p, read1): Use unsigned instead of int.
2139 (safe_to_load_p): Make the end-of-loop test the inverse of the in-loop.
2140
2141 * print.c (print_error_message): Avoid int overflow.
2142
2143 * font.c (font_list_entities): Redo for clarity,
2144 so that reader need not know FONT_DPI_INDEX + 1 == FONT_SPACING_INDEX.
2145
2146 * font.c (font_find_for_lface, Ffont_get_glyphs): Remove unused vars.
2147 (font_score): Avoid potential overflow in diff calculation.
2148
2149 * fns.c (substring_both): Remove var that is set but not used.
2150 (sxhash): Redo loop for clarity and to avoid wraparound warning.
2151
2152 * eval.c (funcall_lambda): Rename local to avoid shadowing.
2153
2154 * alloc.c (mark_object_loop_halt, mark_object): Use size_t, not int.
2155 Otherwise, GCC 4.6.0 optimizes the loop check away since the check
2156 can always succeed if overflow has undefined behavior.
2157
2158 * search.c (boyer_moore, wordify): Remove vars set but not used.
2159 (wordify): Omit three unnecessary tests.
2160
2161 * indent.c (MULTIBYTE_BYTES_WIDTH): Don't compute wide_column.
2162 All callers changed. This avoids the need for an unused var.
2163
2164 * casefiddle.c (casify_region): Remove var that is set but not used.
2165
2166 * dired.c (file_name_completion): Remove var that is set but not used.
2167
2168 * fileio.c (Finsert_file_contents): Make EOF condition clearer.
2169
2170 * fileio.c (Finsert_file_contents): Avoid signed integer overflow.
2171 (Finsert_file_contents): Remove unnecessary code checking fd.
2172
2173 * minibuf.c (read_minibuf_noninteractive): Use size_t for sizes.
2174 Check for integer overflow on size calculations.
2175
2176 * buffer.c (Fprevious_overlay_change): Remove var that is set
2177 but not used.
2178
2179 * keyboard.c (menu_bar_items, read_char_minibuf_menu_prompt):
2180 Remove vars that are set but not used.
2181 (timer_check_2): Don't assume timer-list and idle-timer-list are lists.
2182 (timer_check_2): Mark vars as initialized.
2183
2184 * gtkutil.c (xg_get_file_with_chooser): Mark var as initialized.
2185
2186 * image.c (lookup_image): Remove var that is set but not used.
2187 (xbm_load): Use parse_p, for gcc -Werror=unused-but-set-variable.
2188
2189 * fontset.c (Finternal_char_font, Ffontset_info): Remove vars
2190 that are set but not used.
2191
2192 * xfns.c (make_invisible_cursor): Don't return garbage
2193 if XCreateBitmapFromData fails (Bug#8410).
2194
2195 * xselect.c (x_get_local_selection, x_handle_property_notify):
2196 Remove vars that are set but not used.
2197
2198 * xfns.c (x_create_tip_frame): Remove var that is set but not used.
2199 (make_invisible_cursor): Initialize a possibly-uninitialized variable.
2200
2201 * xterm.c (x_scroll_bar_to_input_event) [!USE_GTK]:
2202 Remove var that is set but not used.
2203 (scroll_bar_windows_size): Now size_t, not int.
2204 (x_send_scroll_bar_event): Use size_t, not int, for sizes.
2205 Check for overflow.
2206
2207 * xfaces.c (realize_named_face): Remove vars that are set but not used.
2208 (map_tty_color) [!defined MSDOS]: Likewise.
2209
2210 * term.c (tty_write_glyphs): Use size_t; this avoids overflow warning.
2211
2212 * coding.c: Remove vars that are set but not used.
2213 (DECODE_COMPOSITION_RULE): Remove 2nd arg, which is unused.
2214 All callers changed.
2215 (decode_coding_utf_8, decode_coding_utf_16 decode_coding_emacs_mule):
2216 (decode_coding_iso_2022, encode_coding_sjis, encode_coding_big5):
2217 (decode_coding_charset): Remove vars that are set but not used.
2218
2219 * bytecode.c (Fbyte_code) [!defined BYTE_CODE_SAFE]: Remove var
2220 that is set but not used.
2221
2222 * print.c (print_object): Remove var that is set but not used.
2223
2224 Replace 2 copies of readlink code with 1 gnulib version (Bug#8401).
2225 The gnulib version avoids calling malloc in the usual case,
2226 and on 64-bit hosts doesn't have some arbitrary 32-bit limits.
2227 * fileio.c (Ffile_symlink_p): Use emacs_readlink.
2228 * filelock.c (current_lock_owner): Likewise.
2229 * lisp.h (READLINK_BUFSIZE, emacs_readlink): New function.
2230 * sysdep.c: Include allocator.h, careadlinkat.h.
2231 (emacs_no_realloc_allocator): New static constant.
2232 (emacs_readlink): New function.
2233 * deps.mk (sysdep.o): Depend on ../lib/allocator.h and on
2234 ../lib/careadlinkat.h.
2235
2236 2011-04-04 Stefan Monnier <monnier@iro.umontreal.ca>
2237
2238 * keyboard.c (safe_run_hook_funcall): Fix last change (don't stop at the
2239 first non-nil return value).
2240
2241 2011-04-03 Jan Djärv <jan.h.d@swipnet.se>
2242
2243 * nsterm.m (ns_update_auto_hide_menu_bar): Define MAC_OS_X_VERSION_10_6
2244 if not defined (Bug#8403).
2245
2246 2011-04-02 Juanma Barranquero <lekktu@gmail.com>
2247
2248 * xdisp.c (display_count_lines): Remove parameter `start',
2249 unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
2250 (get_char_face_and_encoding): Remove parameter `multibyte_p',
2251 unused since 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
2252 (fill_stretch_glyph_string): Remove parameters `row' and `area',
2253 unused at least since Kim's GUI unification at 2003-03-16T20:45:46Z!storm@cua.dk
2254 and thereabouts. All callers changed.
2255 (get_per_char_metric): Remove parameter `f', unused since
2256 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
2257
2258 2011-04-02 Jim Meyering <meyering@redhat.com>
2259
2260 do not dereference NULL upon failed strdup
2261 * nsfont.m (ns_descriptor_to_entity): Use xstrdup, not strdup.
2262 (ns_get_family): Likewise.
2263
2264 2011-04-02 Juanma Barranquero <lekktu@gmail.com>
2265
2266 * eval.c (unwind_to_catch) [DEBUG_GCPRO]: Remove redundant assignment.
2267
2268 2011-04-02 Jan Djärv <jan.h.d@swipnet.se>
2269
2270 * nsterm.m (ns_update_auto_hide_menu_bar): Only for OSX 10.6 or
2271 later (Bug#8403).
2272
2273 2011-04-01 Stefan Monnier <monnier@iro.umontreal.ca>
2274
2275 Add lexical binding.
2276
2277 * window.c (Ftemp_output_buffer_show): New fun.
2278 (Fsave_window_excursion):
2279 * print.c (Fwith_output_to_temp_buffer): Move to subr.el.
2280
2281 * lread.c (lisp_file_lexically_bound_p): New function.
2282 (Fload): Bind Qlexical_binding.
2283 (readevalloop): Remove `evalfun' arg.
2284 Bind Qinternal_interpreter_environment.
2285 (Feval_buffer): Bind Qlexical_binding.
2286 (defvar_int, defvar_bool, defvar_lisp_nopro, defvar_kboard):
2287 Mark as dynamic.
2288 (syms_of_lread): Declare `lexical-binding'.
2289
2290 * lisp.h (struct Lisp_Symbol): New field `declared_special'.
2291
2292 * keyboard.c (eval_dyn): New fun.
2293 (menu_item_eval_property): Use it.
2294
2295 * image.c (parse_image_spec): Use Ffunctionp.
2296
2297 * fns.c (concat, mapcar1): Accept byte-code-functions.
2298
2299 * eval.c (Fsetq): Handle lexical vars.
2300 (Fdefun, Fdefmacro, Ffunction): Make closures when needed.
2301 (Fdefconst, Fdefvaralias, Fdefvar): Mark as dynamic.
2302 (FletX, Flet): Obey lexical binding.
2303 (Fcommandp): Handle closures.
2304 (Feval): New `lexical' arg.
2305 (eval_sub): New function extracted from Feval. Use it almost
2306 everywhere where Feval was used. Look up vars in lexical env.
2307 Handle closures.
2308 (Ffunctionp): Move from subr.el.
2309 (Ffuncall): Handle closures.
2310 (apply_lambda): Remove `eval_flags'.
2311 (funcall_lambda): Handle closures and new byte-code-functions.
2312 (Fspecial_variable_p): New function.
2313 (syms_of_eval): Initialize the Vinternal_interpreter_environment var,
2314 but without exporting it to Lisp.
2315
2316 * doc.c (Fdocumentation, store_function_docstring):
2317 * data.c (Finteractive_form): Handle closures.
2318
2319 * callint.c (Fcall_interactively): Preserve lexical-binding mode for
2320 interactive spec.
2321
2322 * bytecode.c (Bstack_ref, Bstack_set, Bstack_set2, BdiscardN):
2323 New byte-codes.
2324 (exec_byte_code): New function extracted from Fbyte_code to handle new
2325 calling convention for byte-code-functions. Add new byte-codes.
2326
2327 * buffer.c (defvar_per_buffer): Set new `declared_special' field.
2328
2329 * alloc.c (Fmake_symbol): Init new `declared_special' field.
2330
2331 2011-03-31 Juanma Barranquero <lekktu@gmail.com>
2332
2333 * xdisp.c (redisplay_internal): Fix prototype.
2334
2335 2011-03-31 Eli Zaretskii <eliz@gnu.org>
2336
2337 * xdisp.c (SCROLL_LIMIT): New macro.
2338 (try_scrolling): Use it when setting scroll_limit.
2339 Limit scrolling to 100 screen lines.
2340 (redisplay_window): Even when falling back on "recentering",
2341 position point in the window according to scroll-conservatively,
2342 scroll-margin, and scroll-*-aggressively variables. (Bug#6671)
2343
2344 (try_scrolling): When point is above the window, allow searching
2345 as far as scroll_max, or one screenful, to compute vertical
2346 distance from PT to the scroll margin position. This prevents
2347 try_scrolling from unnecessarily failing when
2348 scroll-conservatively is set to a value slightly larger than the
2349 window height. Clean up the case of PT below the margin at bottom
2350 of window: scroll_max can no longer be INT_MAX. When aggressive
2351 scrolling is in use, don't let point enter the opposite scroll
2352 margin as result of the scroll.
2353 (syms_of_xdisp) <scroll-conservatively>: Document the
2354 threshold of 100 lines for never-recentering scrolling.
2355
2356 2011-03-31 Juanma Barranquero <lekktu@gmail.com>
2357
2358 * dispextern.h (move_it_by_lines):
2359 * xdisp.c (move_it_by_lines): Remove parameter `need_y_p', unused
2360 since 2000-12-29T14:24:09Z!gerd@gnu.org. All callers changed.
2361 (message_log_check_duplicate): Remove parameters `prev_bol' and
2362 `this_bol', unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
2363 (redisplay_internal): Remove parameter `preserve_echo_area',
2364 unused since 1999-07-21T21:43:52Z!gerd@gnu.org. All callers changed.
2365
2366 * indent.c (Fvertical_motion):
2367 * window.c (window_scroll_pixel_based, Frecenter):
2368 Don't pass `need_y_p' to `move_it_by_lines'.
2369
2370 2011-03-30 Stefan Monnier <monnier@iro.umontreal.ca>
2371
2372 * eval.c (struct backtrace): Don't cheat with negative numbers, but do
2373 steal a few bits to be more compact.
2374 (interactive_p, Fbacktrace, Fbacktrace_frame, mark_backtrace):
2375 Remove unneeded casts.
2376
2377 * bytecode.c (Fbyte_code): CAR and CDR can GC.
2378
2379 2011-03-30 Zachary Kanfer <zkanfer@gmail.com> (tiny change)
2380
2381 * keyboard.c (Fexecute_extended_command): Do log the "suggest key
2382 binding" message (bug#7967).
2383
2384 2011-03-30 Paul Eggert <eggert@cs.ucla.edu>
2385
2386 Fix more problems found by GCC 4.6.0's static checks.
2387
2388 * unexelf.c (unexec) [! (defined _SYSTYPE_SYSV || defined __sgi)]:
2389 Remove unused local var.
2390
2391 * editfns.c (Fmessage_box): Remove unused local var.
2392
2393 * xdisp.c (try_window_reusing_current_matrix, x_produce_glyphs):
2394 (note_mode_line_or_margin_highlight, note_mouse_highlight):
2395 Omit unused local vars.
2396 * window.c (shrink_windows): Omit unused local var.
2397 * menu.c (digest_single_submenu): Omit unused local var.
2398 * dispnew.c (update_window) [PERIODIC_PREEMPTION_CHECKING]:
2399 Omit unused local var.
2400
2401 * keyboard.c (parse_modifiers_uncached, parse_modifiers):
2402 Don't assume string length fits in int.
2403 (keyremap_step, read_key_sequence): Use size_t for sizes.
2404 (read_key_sequence): Don't check last_real_key_start redundantly.
2405
2406 * callproc.c (Fcall_process, Fcall_process_region): Use SAFE_ALLOCA
2407 instead of alloca (Bug#8344).
2408
2409 * eval.c (Fbacktrace): Don't assume nargs fits in int.
2410 (Fbacktrace_frame): Don't assume nframes fits in int.
2411
2412 * syntax.c (scan_sexps_forward): Avoid pointer wraparound.
2413
2414 * xterm.c (x_make_frame_visible, same_x_server): Redo to avoid overflow
2415 concerns.
2416
2417 * term.c (produce_glyphless_glyph): Remove unnecessary test.
2418
2419 * cm.c (calccost): Turn while-do into do-while, for clarity.
2420
2421 * keyboard.c (syms_of_keyboard): Use the same style as later
2422 in this function when indexing through an array. This also
2423 works around GCC bug 48267.
2424
2425 * image.c (tiff_load): Fix off-by-one image count (Bug#8336).
2426
2427 * xselect.c (x_check_property_data): Return correct size (Bug#8335).
2428
2429 * chartab.c (sub_char_table_ref_and_range): Redo for slight
2430 efficiency gain, and to bypass a gcc -Wstrict-overflow warning.
2431
2432 * keyboard.c, keyboard.h (num_input_events): Now size_t.
2433 This avoids undefined behavior on integer overflow, and is a bit
2434 more convenient anyway since it is compared to a size_t variable.
2435
2436 Variadic C functions now count arguments with size_t, not int.
2437 This avoids an unnecessary limitation on 64-bit machines, which
2438 caused (substring ...) to crash on large vectors (Bug#8344).
2439 * lisp.h (struct Lisp_Subr.function.aMANY): Now takes size_t, not int.
2440 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call): Likewise.
2441 All variadic functions and their callers changed accordingly.
2442 (struct gcpro.nvars): Now size_t, not int. All uses changed.
2443 * data.c (arith_driver, float_arith_driver): Likewise.
2444 * editfns.c (general_insert_function): Likewise.
2445 * eval.c (struct backtrace.nargs, interactive_p)
2446 (internal_condition_case_n, run_hook_with_args, apply_lambda)
2447 (funcall_lambda, mark_backtrace): Likewise.
2448 * fns.c (concat): Likewise.
2449 * frame.c (x_set_frame_parameters): Likewise.
2450 * fns.c (get_key_arg): Now accepts and returns size_t, and returns
2451 0 if not found, not -1. All callers changed.
2452
2453 * alloc.c (garbage_collect): Don't assume stack size fits in int.
2454 (stack_copy_size): Now size_t, not int.
2455 (stack_copy, stack_copy_size): Define only if MAX_SAVE_STACK > 0.
2456
2457 2011-03-28 Juanma Barranquero <lekktu@gmail.com>
2458
2459 * coding.c (encode_designation_at_bol): Remove parameter `charbuf_end',
2460 unused since 2002-03-01T01:17:24Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
2461 All callers changed.
2462
2463 * lisp.h (multibyte_char_to_unibyte):
2464 * character.c (multibyte_char_to_unibyte): Remove parameter `rev_tbl',
2465 unused since 2002-03-01T01:16:34Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
2466 * character.h (CHAR_TO_BYTE8):
2467 * cmds.c (internal_self_insert):
2468 * editfns.c (general_insert_function):
2469 * keymap.c (push_key_description):
2470 * search.c (Freplace_match):
2471 * xdisp.c (message_dolog, set_message_1): All callers changed.
2472
2473 2011-03-28 Stefan Monnier <monnier@iro.umontreal.ca>
2474
2475 * keyboard.c (safe_run_hook_funcall): New function.
2476 (safe_run_hooks_1, safe_run_hooks_error, safe_run_hooks): On error,
2477 don't set the hook to nil, but remove the offending function instead.
2478 (Qcommand_hook_internal): Remove, unused.
2479 (syms_of_keyboard): Don't initialize Qcommand_hook_internal nor define
2480 Vcommand_hook_internal.
2481
2482 * eval.c (enum run_hooks_condition): Remove.
2483 (funcall_nil, funcall_not): New functions.
2484 (run_hook_with_args): Call each function through a `funcall' argument.
2485 Remove `cond' argument, now redundant.
2486 (Frun_hooks, Frun_hook_with_args, Frun_hook_with_args_until_success)
2487 (Frun_hook_with_args_until_failure): Adjust accordingly.
2488 (run_hook_wrapped_funcall, Frun_hook_wrapped): New functions.
2489
2490 2011-03-28 Juanma Barranquero <lekktu@gmail.com>
2491
2492 * dispextern.h (string_buffer_position): Remove declaration.
2493
2494 * print.c (strout): Remove parameter `multibyte', unused since
2495 1999-08-21T19:30:21Z!gerd@gnu.org. All callers changed.
2496
2497 * search.c (boyer_moore): Remove parameters `len', `pos' and `lim',
2498 never used since function introduction in 1998-02-08T21:33:56Z!rms@gnu.org.
2499 All callers changed.
2500
2501 * w32.c (_wsa_errlist): Use braces for struct initializers.
2502
2503 * xdisp.c (string_buffer_position_lim): Remove parameter `w',
2504 never used since function introduction in 2001-03-09T18:41:50Z!gerd@gnu.org.
2505 All callers changed.
2506 (string_buffer_position): Likewise. Also, make static (it's never
2507 used outside xdisp.c).
2508 (cursor_row_p): Remove parameter `w', unused since
2509 2000-10-17T16:08:57Z!gerd@gnu.org. All callers changed.
2510 (decode_mode_spec): Remove parameter `precision', introduced during
2511 Gerd Moellmann's rewrite at 1999-07-21T21:43:52Z!gerd@gnu.org, but never used.
2512 All callers changed.
2513
2514 2011-03-27 Jan Djärv <jan.h.d@swipnet.se>
2515
2516 * nsterm.m (syms_of_nsterm): Use doc: for ns-auto-hide-menu-bar.
2517
2518 2011-03-27 Anders Lindgren <andlind@gmail.com>
2519
2520 * nsterm.m (ns_menu_bar_is_hidden): New variable.
2521 (ns_constrain_all_frames, ns_menu_bar_should_be_hidden)
2522 (ns_update_auto_hide_menu_bar): New functions.
2523 (ns_update_begin): Call ns_update_auto_hide_menu_bar.
2524 (applicationDidBecomeActive): Call ns_update_auto_hide_menu_bar and
2525 ns_constrain_all_frames.
2526 (constrainFrameRect): Return at once if ns_menu_bar_should_be_hidden.
2527 (syms_of_nsterm): DEFVAR ns-auto-hide-menu-bar, init to Qnil.
2528
2529 2011-03-27 Jan Djärv <jan.h.d@swipnet.se>
2530
2531 * nsmenu.m (runDialogAt): Remove argument to timer_check.
2532
2533 2011-03-27 Glenn Morris <rgm@gnu.org>
2534
2535 * syssignal.h: Replace RETSIGTYPE with void.
2536 * atimer.c, data.c, dispnew.c, emacs.c, floatfns.c, keyboard.c:
2537 * keyboard.h, lisp.h, process.c, sysdep.c, xterm.c:
2538 Replace SIGTYPE with void everywhere.
2539 * s/usg5-4-common.h (SIGTYPE): Remove definition.
2540 * s/template.h (SIGTYPE): Remove commented out definition.
2541
2542 2011-03-26 Eli Zaretskii <eliz@gnu.org>
2543
2544 * xdisp.c (redisplay_window): Don't check buffer's clip_changed
2545 flag as a prerequisite for invoking try_scrolling. (Bug#6671)
2546
2547 2011-03-26 Juanma Barranquero <lekktu@gmail.com>
2548
2549 * w32.c (read_unc_volume): Use parameter `henum', instead of
2550 global variable `wget_enum_handle'.
2551
2552 * keymap.c (describe_vector): Remove parameters `indices' and
2553 `char_table_depth', unused since 2002-03-01T01:43:26Z!handa@m17n.org.
2554 (describe_map, Fdescribe_vector): Adjust calls to `describe_vector'.
2555
2556 * keyboard.h (timer_check, show_help_echo): Remove unused parameters.
2557
2558 * keyboard.c (timer_check): Remove parameter `do_it_now',
2559 unused since 1996-04-12T06:01:29Z!rms@gnu.org.
2560 (show_help_echo): Remove parameter `ok_to_overwrite_keystroke_echo',
2561 unused since 2008-04-19T19:30:53Z!monnier@iro.umontreal.ca.
2562
2563 * keyboard.c (read_char):
2564 * w32menu.c (w32_menu_display_help):
2565 * xmenu.c (show_help_event, menu_help_callback):
2566 Adjust calls to `show_help_echo'.
2567
2568 * gtkutil.c (xg_maybe_add_timer):
2569 * keyboard.c (readable_events):
2570 * process.c (wait_reading_process_output):
2571 * xmenu.c (x_menu_wait_for_event): Adjust calls to `timer_check'.
2572
2573 * insdel.c (adjust_markers_gap_motion):
2574 Remove; no-op since 1998-01-02T21:29:48Z!rms@gnu.org.
2575 (gap_left, gap_right): Don't call it.
2576
2577 2011-03-25 Chong Yidong <cyd@stupidchicken.com>
2578
2579 * xdisp.c (handle_fontified_prop): Discard changes to clip_changed
2580 incurred during fontification.
2581
2582 2011-03-25 Juanma Barranquero <lekktu@gmail.com>
2583
2584 * buffer.c (defvar_per_buffer): Remove unused parameter `doc'.
2585 (DEFVAR_PER_BUFFER): Don't pass it.
2586
2587 * dispnew.c (row_equal_p, add_row_entry): Remove unused parameter `w'.
2588 (scrolling_window): Don't pass it.
2589
2590 2011-03-25 Juanma Barranquero <lekktu@gmail.com>
2591
2592 * dispextern.h (glyph_matric): Use #if GLYPH_DEBUG, not #ifdef.
2593
2594 * fileio.c (check_executable) [DOS_NT]: Remove unused variables `len'
2595 and `suffix'.
2596 (Fset_file_selinux_context) [HAVE_LIBSELINUX]: Move here declaration
2597 of variables specific to SELinux and computation of `encoded_absname'.
2598
2599 * image.c (XPutPixel): Remove unused variable `height'.
2600
2601 * keyboard.c (make_lispy_event): Remove unused variable `hpos'.
2602
2603 * unexw32.c (get_section_info): Remove unused variable `section'.
2604
2605 * w32.c (stat): Remove unused variables `drive_root' and `devtype'.
2606 (system_process_attributes): Remove unused variable `sess'.
2607 (sys_read): Remove unused variable `err'.
2608
2609 * w32fns.c (top): Wrap variables with #if GLYPH_DEBUG, not #ifdef.
2610 (w32_wnd_proc): Remove unused variable `isdead'.
2611 (unwind_create_frame): Use #if GLYPH_DEBUG, not #ifdef.
2612 (Fx_server_max_request_size): Remove unused variable `dpyinfo'.
2613 (x_create_tip_frame): Remove unused variable `tem'.
2614
2615 * w32inevt.c (w32_console_read_socket):
2616 Remove unused variable `no_events'.
2617
2618 * w32term.c (x_draw_composite_glyph_string_foreground):
2619 Remove unused variable `width'.
2620
2621 2011-03-24 Juanma Barranquero <lekktu@gmail.com>
2622
2623 * w32term.c (x_set_glyph_string_clipping):
2624 Don't pass uninitialized region to CombineRgn.
2625
2626 2011-03-23 Juanma Barranquero <lekktu@gmail.com>
2627
2628 * w32fns.c (x_set_menu_bar_lines): Remove unused variable `olines'.
2629 (w32_wnd_proc): Pass NULL to Windows API, not uninitialized buffer.
2630 (Fx_close_connection): Remove unused variable `i'.
2631
2632 * w32font.c (w32font_draw): Return number of glyphs.
2633 (w32font_open_internal): Remove unused variable `i'.
2634 (w32font_driver): Add missing initializer.
2635
2636 * w32menu.c (utf8to16): Remove unused variable `utf16'.
2637 (fill_in_menu): Remove unused variable `items_added'.
2638
2639 * w32term.c (last_mouse_press_frame): Remove static global variable.
2640 (w32_clip_to_row): Remove unused variable `f'.
2641 (x_delete_terminal): Remove unused variable `i'.
2642
2643 * w32uniscribe.c (uniscribe_shape): Remove unused variable `nclusters'.
2644 (NOTHING): Remove unused static global variable.
2645 (uniscribe_check_otf): Remove unused variable `table'.
2646 (uniscribe_font_driver): Add missing initializers.
2647
2648 2011-03-23 Julien Danjou <julien@danjou.info>
2649
2650 * term.c (Fsuspend_tty, Fresume_tty):
2651 * minibuf.c (read_minibuf, run_exit_minibuf_hook):
2652 * window.c (temp_output_buffer_show):
2653 * insdel.c (signal_before_change):
2654 * frame.c (Fhandle_switch_frame):
2655 * fileio.c (Fdo_auto_save):
2656 * emacs.c (Fkill_emacs):
2657 * editfns.c (save_excursion_restore):
2658 * cmds.c (internal_self_insert):
2659 * callint.c (Fcall_interactively):
2660 * buffer.c (Fkill_all_local_variables):
2661 * keyboard.c (Fcommand_execute, Fsuspend_emacs, safe_run_hooks_1):
2662 Use Frun_hooks.
2663 (command_loop_1): Use Frun_hooks. Call safe_run_hooks
2664 unconditionnaly since it does the check itself.
2665
2666 2011-03-23 Paul Eggert <eggert@cs.ucla.edu>
2667
2668 Fix more problems found by GCC 4.5.2's static checks.
2669
2670 * coding.c (encode_coding_raw_text): Avoid unnecessary test
2671 the first time through the loop, since we know p0 < p1 then.
2672 This also avoids a gcc -Wstrict-overflow warning.
2673
2674 * lisp.h (SAFE_ALLOCA, SAFE_ALLOCA_LISP): Avoid 'int' overflow
2675 leading to a memory leak, possible in functions like
2676 load_charset_map_from_file that can allocate an unbounded number
2677 of objects (Bug#8318).
2678
2679 * xmenu.c (set_frame_menubar): Use EMACS_UINT, not int, for indexes
2680 that could (at least in theory) be that large.
2681
2682 * xdisp.c (message_log_check_duplicate): Return unsigned long, not int.
2683 This is less likely to overflow, and avoids undefined behavior if
2684 overflow does occur. All callers changed. Use strtoul to scan
2685 for the unsigned long integer.
2686 (pint2hrstr): Simplify and tune code slightly.
2687 This also avoids a (bogus) GCC warning with gcc -Wstrict-overflow.
2688
2689 * scroll.c (do_scrolling): Work around GCC bug 48228.
2690 See <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=48228>.
2691
2692 * frame.c (Fmodify_frame_parameters): Simplify loop counter.
2693 This also avoids a warning with gcc -Wstrict-overflow.
2694 (validate_x_resource_name): Simplify count usage.
2695 This also avoids a warning with gcc -Wstrict-overflow.
2696
2697 * fileio.c (Fcopy_file): Report error if fchown or fchmod
2698 fail (Bug#8306).
2699
2700 * emacs.c (Fdaemon_initialized): Do not ignore I/O errors (Bug#8303).
2701
2702 * process.c (Fmake_network_process): Use socklen_t, not int,
2703 where POSIX says socklen_t is required in portable programs.
2704 This fixes a porting bug on hosts like 64-bit HP-UX, where
2705 socklen_t is wider than int (Bug#8277).
2706 (Fmake_network_process, server_accept_connection):
2707 (wait_reading_process_output, read_process_output):
2708 Likewise.
2709
2710 * process.c: Rename or move locals to avoid shadowing.
2711 (list_processes_1, Fmake_network_process):
2712 (read_process_output_error_handler, exec_sentinel_error_handler):
2713 Rename or move locals.
2714 (Fmake_network_process): Define label "retry_connect" only if needed.
2715 (Fnetwork_interface_info): Fix pointer signedness.
2716 (process_send_signal): Add cast to avoid pointer signedness problem.
2717 (FIRST_PROC_DESC, IF_NON_BLOCKING_CONNECT): Remove unused macros.
2718 (create_process): Use 'volatile' to avoid vfork clobbering (Bug#8298).
2719
2720 Make tparam.h and terminfo.c consistent.
2721 * cm.c (tputs, tgoto, BC, UP): Remove extern decls.
2722 Include tparam.h instead, since it declares them.
2723 * cm.h (PC): Remove extern decl; tparam.h now does this.
2724 * deps.mk (cm.o, terminfo.o): Depend on tparam.h.
2725 * terminfo.c: Include tparam.h, to check interfaces.
2726 (tparm): Make 1st arg a const pointer in decl. Put it at top level.
2727 (tparam): Adjust signature to match interface in tparam.h;
2728 this removes some undefined behavior. Check that outstring and len
2729 are zero, which they always are with Emacs.
2730 * tparam.h (PC, BC, UP): New extern decls.
2731
2732 * xftfont.c (xftfont_shape): Now static, and defined only if needed.
2733 (xftfont_open): Rename locals to avoid shadowing.
2734
2735 * ftfont.c (ftfont_resolve_generic_family): Fix pointer signedness.
2736 (ftfont_otf_capability, ftfont_shape): Omit decls if not needed.
2737 (OTF_TAG_SYM): Omit macro if not needed.
2738 (ftfont_list): Remove unused local.
2739 (get_adstyle_property, ftfont_pattern_entity):
2740 (ftfont_lookup_cache, ftfont_open, ftfont_anchor_point):
2741 Rename locals to avoid shadowing.
2742
2743 * xfont.c (xfont_list_family): Mark var as initialized.
2744
2745 * xml.c (make_dom): Now static.
2746
2747 * composite.c (composition_compute_stop_pos): Rename local to
2748 avoid shadowing.
2749 (composition_reseat_it): Remove unused locals.
2750 (find_automatic_composition, composition_adjust_point): Likewise.
2751 (composition_update_it): Mark var as initialized.
2752 (find_automatic_composition): Mark vars as initialized,
2753 with a FIXME (Bug#8290).
2754
2755 character.h: Rename locals to avoid shadowing.
2756 * character.h (PREV_CHAR_BOUNDARY, FETCH_STRING_CHAR_ADVANCE):
2757 (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE, FETCH_CHAR_ADVANCE):
2758 (FETCH_CHAR_ADVANCE_NO_CHECK, INC_POS, DEC_POS, BUF_INC_POS):
2759 (BUF_DEC_POS): Be more systematic about renaming local temporaries
2760 to avoid shadowing.
2761
2762 * textprop.c (property_change_between_p): Remove; unused.
2763
2764 * intervals.c (interval_start_pos): Now static.
2765
2766 * intervals.h (CHECK_TOTAL_LENGTH): Avoid empty "else".
2767
2768 * atimer.c (start_atimer, append_atimer_lists, set_alarm):
2769 Rename locals to avoid shadowing.
2770
2771 * sound.c (wav_play, au_play, Fplay_sound_internal):
2772 Fix pointer signedness.
2773 (alsa_choose_format): Remove unused local var.
2774 (wav_play): Initialize a variable to 0, to prevent undefined
2775 behavior (Bug#8278).
2776
2777 * region-cache.c (insert_cache_boundary): Redo var to avoid shadowing.
2778
2779 * region-cache.h (pp_cache): New decl, for gcc -Wmissing-prototypes.
2780
2781 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork
2782 clobbering (Bug#8298).
2783 * sysdep.c (sys_subshell): Likewise.
2784 Previously, the sys_subshell 'volatile' was incorrectly IF_LINTted out.
2785
2786 * lisp.h (child_setup): Now NO_RETURN unless DOS_NT.
2787 This should get cleaned up, so that child_setup has the
2788 same signature on all platforms.
2789
2790 * callproc.c (call_process_cleanup): Now static.
2791 (relocate_fd): Rename locals to avoid shadowing.
2792
2793 2011-03-22 Chong Yidong <cyd@stupidchicken.com>
2794
2795 * xterm.c (x_clear_frame): Remove XClearWindow call. This appears
2796 not to be necessary, and produces flickering.
2797
2798 2011-03-20 Glenn Morris <rgm@gnu.org>
2799
2800 * config.in: Remove file.
2801
2802 2011-03-20 Juanma Barranquero <lekktu@gmail.com>
2803
2804 * minibuf.c (Vcompleting_read_function): Don't declare, global variables
2805 are now in src/globals.h.
2806 (syms_of_minibuf): Remove spurious & from previous change.
2807
2808 2011-03-20 Leo <sdl.web@gmail.com>
2809
2810 * minibuf.c (completing-read-function): New variable.
2811 (completing-read-default): Rename from completing-read.
2812 (completing-read): Call completing-read-function.
2813
2814 2011-03-19 Juanma Barranquero <lekktu@gmail.com>
2815
2816 * xfaces.c (Fx_load_color_file):
2817 Read color file from absolute filename (bug#8250).
2818
2819 2011-03-19 Juanma Barranquero <lekktu@gmail.com>
2820
2821 * makefile.w32-in: Update dependencies.
2822
2823 2011-03-17 Eli Zaretskii <eliz@gnu.org>
2824
2825 * makefile.w32-in ($(BLD)/unexw32.$(O)): Depend on $(SRC)/unexec.h.
2826
2827 2011-03-17 Paul Eggert <eggert@cs.ucla.edu>
2828
2829 Fix more problems found by GCC 4.5.2's static checks.
2830
2831 * process.c (make_serial_process_unwind, send_process_trap):
2832 (sigchld_handler): Now static.
2833
2834 * process.c (allocate_pty): Let PTY_ITERATION declare iteration vars.
2835 That way, the code declares only the vars that it needs.
2836 * s/aix4-2.h (PTY_ITERATION): Declare iteration vars.
2837 * s/cygwin.h (PTY_ITERATION): Likewise.
2838 * s/darwin.h (PTY_ITERATION): Likewise.
2839 * s/gnu-linux.h (PTY_ITERATION): Likewise.
2840
2841 * s/irix6-5.h (PTY_OPEN): Declare stb, to loosen coupling.
2842 * process.c (allocate_pty): Don't declare stb unless it's needed.
2843
2844 * bytecode.c (MAYBE_GC): Rewrite so as not to use empty "else".
2845 (CONSTANTLIM): Remove; unused.
2846 (METER_CODE, Bscan_buffer, Bread_char, Bset_mark):
2847 Define only if needed.
2848
2849 * unexelf.c (unexec): Name an expression,
2850 to avoid gcc -Wbad-function-cast warning.
2851 Use a different way to cause a compilation error if anyone uses
2852 n rather than nn, a way that does not involve shadowing.
2853 (ELF_BSS_SECTION_NAME, OLD_PROGRAM_H): Remove; unused.
2854
2855 * deps.mk (unexalpha.o): Remove; unused.
2856
2857 New file unexec.h, the (simple) interface for unexec (Bug#8267).
2858 * unexec.h: New file.
2859 * deps.mk (emacs.o, unexaix.o, unexcw.o, unexcoff.o, unexelf.o):
2860 (unexhp9k800.o, unexmacosx.o, unexsol.o, unexw32.o):
2861 Depend on unexec.h.
2862 * emacs.c [!defined CANNOT_DUMP]: Include unexec.h.
2863 * unexaix.c, unexcoff.c, unexcw.c, unexelf.c, unexhp9k800.c:
2864 * unexmacosx.c, unexsol.c, unexw32.c: Include unexec.h.
2865 Change as necessary to match prototype in unexec.h.
2866
2867 * syntax.c (Fforward_comment, scan_lists): Rename locals to avoid
2868 shadowing.
2869 (back_comment, skip_chars): Mark vars as initialized.
2870
2871 * character.h (FETCH_STRING_CHAR_ADVANCE_NO_CHECK, BUF_INC_POS):
2872 Rename locals to avoid shadowing.
2873
2874 * lread.c (read1): Rewrite so as not to use empty "else".
2875 (Fload, readevalloop, read1): Rename locals to avoid shadowing.
2876
2877 * print.c (Fredirect_debugging_output): Fix pointer signedess.
2878
2879 * lisp.h (debug_output_compilation_hack): Add decl here, to avoid
2880 warning when compiling print.c.
2881
2882 * font.c (font_unparse_fcname): Abort in an "impossible" situation
2883 instead of using an uninitialized var.
2884 (font_sort_entities): Mark var as initialized.
2885
2886 * character.h (FETCH_CHAR_ADVANCE): Rename locals to avoid shadowing.
2887
2888 * font.c (font_unparse_xlfd): Don't mix pointers to variables with
2889 pointers to constants.
2890 (font_parse_fcname): Remove unused vars.
2891 (font_delete_unmatched): Now static.
2892 (font_get_spec): Remove; unused.
2893 (font_style_to_value, font_prop_validate_style, font_unparse_fcname):
2894 (font_update_drivers, Ffont_get_glyphs, font_add_log):
2895 Rename or move locals to avoid shadowing.
2896
2897 * fns.c (require_nesting_list, require_unwind): Now static.
2898 (Ffillarray): Rename locals to avoid shadowing.
2899
2900 * floatfns.c (domain_error2): Define only if needed.
2901 (Ffrexp, Fldexp): Rename locals to avoid shadowing.
2902
2903 * alloc.c (mark_backtrace): Move decl from here ...
2904 * lisp.h: ... to here, so that it can be checked.
2905
2906 * eval.c (call_debugger, do_debug_on_call, grow_specpdl): Now static.
2907 (Fdefvar): Rewrite so as not to use empty "else".
2908 (lisp_indirect_variable): Name an expression,
2909 to avoid gcc -Wbad-function-cast warning.
2910 (Fdefvar): Rename locals to avoid shadowing.
2911
2912 * callint.c (quotify_arg, quotify_args): Now static.
2913 (Fcall_interactively): Rename locals to avoid shadowing.
2914 Use const pointer when appropriate.
2915
2916 * lisp.h (get_system_name, get_operating_system_release):
2917 Move decls here, to check interfaces.
2918 * process.c (get_operating_system_release): Move decl to lisp.h.
2919 * xrdb.c (get_system_name): Likewise.
2920 * editfns.c (init_editfns, Fuser_login_name, Fuser_uid):
2921 (Fuser_real_uid, Fuser_full_name): Remove unnecessary casts,
2922 some of which prompt warnings from gcc -Wbad-function-cast.
2923 (Fformat_time_string, Fencode_time, Finsert_char):
2924 (Ftranslate_region_internal, Fformat):
2925 Rename or remove local vars to avoid shadowing.
2926 (Ftranslate_region_internal): Mark var as initialized.
2927
2928 * doc.c (Fdocumentation, Fsnarf_documentation): Move locals to
2929 avoid shadowing.
2930
2931 * lisp.h (eassert): Check that the argument compiles, even if
2932 ENABLE_CHECKING is not defined.
2933
2934 * data.c (Findirect_variable): Name an expression, to avoid
2935 gcc -Wbad-function-cast warning.
2936 (default_value, arithcompare, arith_driver, arith_error): Now static.
2937 (store_symval_forwarding): Rename local to avoid shadowing.
2938 (Fmake_variable_buffer_local, Fmake_local_variable):
2939 Mark variables as initialized.
2940 (do_blv_forwarding, do_symval_forwarding): Remove; unused.
2941
2942 * alloc.c (check_cons_list): Do not define unless GC_CHECK_CONS_LIST.
2943 (Fmake_vector, Fvector, Fmake_byte_code, Fgarbage_collect):
2944 Rename locals to avoid shadowing.
2945 (mark_stack): Move local variables into the #ifdef region where
2946 they're used.
2947 (BLOCK_INPUT_ALLOC, UNBLOCK_INPUT_ALLOC): Define only if
2948 ! defined SYSTEM_MALLOC && ! defined SYNC_INPUT, as they are not
2949 needed otherwise.
2950 (CHECK_ALLOCATED): Define only if GC_CHECK_MARKED_OBJECTS.
2951 (GC_STRING_CHARS): Remove; not used.
2952 (Fmemory_limit): Cast sbrk's returned value to char *.
2953
2954 * lisp.h (check_cons_list): Declare if GC_CHECK_CONS_LIST; this
2955 avoids undefined behavior in theory.
2956
2957 * regex.c (IF_LINT): Add defn, for benefit of ../lib-src.
2958
2959 Use functions, not macros, for up- and down-casing (Bug#8254).
2960 * buffer.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
2961 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Remove. All callers changed
2962 to use the following functions instead of these macros.
2963 (downcase): Adjust to lack of DOWNCASE_TABLE. Return int, not
2964 EMACS_INT, since callers assume the returned value fits in int.
2965 (upcase1): Likewise, for UPCASE_TABLE.
2966 (uppercasep, lowercasep, upcase): New static inline functions.
2967 * editfns.c (Fchar_equal): Remove no-longer-needed workaround for
2968 the race-condition problem in the old DOWNCASE.
2969
2970 * regex.c (CHARSET_LOOKUP_RANGE_TABLE_RAW, POP_FAILURE_REG_OR_COUNT):
2971 Rename locals to avoid shadowing.
2972 (regex_compile, re_match_2_internal): Move locals to avoid shadowing.
2973 (regex_compile, re_search_2, re_match_2_internal):
2974 Remove unused local vars.
2975 (FREE_VAR): Rewrite so as not to use empty "else",
2976 which gcc can warn about.
2977 (regex_compile, re_match_2_internal): Mark locals as initialized.
2978 (RETALLOC_IF): Define only if needed.
2979 (WORDCHAR_P): Likewise. This one is never needed, but is used
2980 only in a comment talking about a compiler bug, so put inside
2981 the #if 0 of that comment.
2982 (CHARSET_LOOKUP_BITMAP, FAIL_STACK_FULL, RESET_FAIL_STACK):
2983 (PUSH_FAILURE_ELT, BUF_PUSH_3, STOP_ADDR_VSTRING):
2984 Remove; unused.
2985
2986 * search.c (boyer_moore): Rename locals to avoid shadowing.
2987 * character.h (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE):
2988 (PREV_CHAR_BOUNDARY): Likewise.
2989
2990 * search.c (simple_search): Remove unused var.
2991
2992 * dired.c (compile_pattern): Move decl from here ...
2993 * lisp.h: ... to here, so that it can be checked.
2994 (struct re_registers): New forward decl.
2995
2996 * character.h (INC_POS, DEC_POS): Rename locals to avoid shadowing.
2997
2998 * indent.c (MULTIBYTE_BYTES_WIDTH): New args bytes, width.
2999 All uses changed.
3000 (MULTIBYTE_BYTES_WIDTH, scan_for_column, compute_motion):
3001 Rename locals to avoid shadowing.
3002 (Fvertical_motion): Mark locals as initialized.
3003
3004 * casefiddle.c (casify_object, casify_region): Now static.
3005 (casify_region): Mark local as initialized.
3006
3007 * cmds.c (internal_self_insert): Rename local to avoid shadowing.
3008
3009 * lisp.h (GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR, GCPRO5_VAR, GCPRO6_VAR):
3010 New macros, so that the caller can use some names other than
3011 gcpro1, gcpro2, etc.
3012 (GCPRO2, GCPRO3, GCPRO4, GCPRO5, GCPRO6): Reimplement in terms
3013 of the new macros.
3014 (GCPRO1_VAR, UNGCPRO_VAR): Change the meaning of the second
3015 argument, for consistency with GCPRO2_VAR, etc: it is now the
3016 prefix of the variable, not the variable itself. All uses
3017 changed.
3018 * dired.c (directory_files_internal, file_name_completion):
3019 Rename locals to avoid shadowing.
3020
3021 Fix a race condition diagnosed by gcc -Wsequence-point (Bug#8254).
3022 An expression of the form (DOWNCASE (x) == DOWNCASE (y)), found in
3023 dired.c's scmp function, had undefined behavior.
3024 * lisp.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
3025 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Move from here ...
3026 * buffer.h: ... to here, because these macros use current_buffer,
3027 and the new implementation with inline functions needs to have
3028 current_buffer in scope now, rather than later when the macros
3029 are used.
3030 (downcase, upcase1): New static inline functions.
3031 (DOWNCASE, UPCASE1): Reimplement using these functions.
3032 This avoids undefined behavior in expressions like
3033 DOWNCASE (x) == DOWNCASE (y), which previously suffered
3034 from race conditions in accessing the global variables
3035 case_temp1 and case_temp2.
3036 * casetab.c (case_temp1, case_temp2): Remove; no longer needed.
3037 * lisp.h (case_temp1, case_temp2): Remove their decls.
3038 * character.h (ASCII_CHAR_P): Move from here ...
3039 * lisp.h: ... to here, so that the inline functions mentioned
3040 above can use them.
3041
3042 * dired.c (directory_files_internal_unwind): Now static.
3043
3044 * fileio.c (file_name_as_directory, directory_file_name):
3045 (barf_or_query_if_file_exists, auto_save_error, auto_save_1):
3046 Now static.
3047 (file_name_as_directory): Use const pointers when appropriate.
3048 (Fexpand_file_name): Likewise. In particular, newdir might
3049 point at constant storage, so make it a const pointer.
3050 (Fmake_directory_internal, Fread_file_name): Remove unused vars.
3051 (Ffile_selinux_context, Fset_file_selinux_context): Fix pointer
3052 signedness issues.
3053 (Fset_file_times, Finsert_file_contents, auto_save_error):
3054 Rename locals to avoid shadowing.
3055
3056 * minibuf.c (choose_minibuf_frame_1): Now static.
3057 (Ftry_completion, Fall_completions): Rename or remove locals
3058 to avoid shadowing.
3059
3060 * marker.c (bytepos_to_charpos): Remove; unused.
3061
3062 * lisp.h (verify_bytepos, count_markers): New decls,
3063 so that gcc does not warn that these functions aren't declared.
3064
3065 * insdel.c (check_markers, make_gap_larger, make_gap_smaller):
3066 (reset_var_on_error, Fcombine_after_change_execute_1): Now static.
3067 (CHECK_MARKERS): Redo to avoid gcc -Wempty-body diagnostic.
3068 (copy_text): Remove unused local var.
3069
3070 * filelock.c (within_one_second): Now static.
3071 (lock_file_1): Rename local to avoid shadowing.
3072
3073 * buffer.c (fix_overlays_before): Mark locals as initialized.
3074 (fix_start_end_in_overlays): Likewise. This function should be
3075 simplified by using pointers-to-pointers, but that's a different
3076 matter.
3077 (switch_to_buffer_1): Now static.
3078 (Fkill_buffer, record_buffer, Fbury_buffer, Fset_buffer_multibyte):
3079 (report_overlay_modification): Rename locals to avoid shadowing.
3080
3081 * sysdep.c (system_process_attributes): Rename vars to avoid shadowing.
3082 Fix pointer signedness issue.
3083 (sys_subshell): Mark local as volatile if checking for lint,
3084 to suppress a gcc -Wclobbered warning that does not seem to be right.
3085 (MAXPATHLEN): Define only if needed.
3086
3087 * process.c (serial_open, serial_configure): Move decls from here ...
3088 * systty.h: ... to here, so that they can be checked.
3089
3090 * fns.c (get_random, seed_random): Move extern decls from here ...
3091 * lisp.h: ... to here, so that they can be checked.
3092
3093 * sysdep.c (reset_io): Now static.
3094 (wait_for_termination_signal): Remove; unused.
3095
3096 * keymap.c (keymap_parent, keymap_memberp, map_keymap_internal):
3097 (copy_keymap_item, append_key, push_text_char_description):
3098 Now static.
3099 (Fwhere_is_internal): Don't test CONSP (sequences) unnecessarily.
3100 (DENSE_TABLE_SIZE): Remove; unused.
3101 (get_keymap, access_keymap, Fdefine_key, Fwhere_is_internal):
3102 (describe_map_tree):
3103 Rename locals to avoid shadowing.
3104
3105 * keyboard.c: Declare functions static if they are not used elsewhere.
3106 (echo_char, echo_dash, cmd_error, top_level_2):
3107 (poll_for_input, handle_async_input): Now static.
3108 (read_char, kbd_buffer_get_event, make_lispy_position):
3109 (make_lispy_event, make_lispy_movement, apply_modifiers):
3110 (decode_keyboard_code, tty_read_avail_input, menu_bar_items):
3111 (parse_tool_bar_item, read_key_sequence, Fread_key_sequence):
3112 (Fread_key_sequence_vector): Rename locals to avoid shadowing.
3113 (read_key_sequence, read_char): Mark locals as initialized.
3114 (Fexit_recursive_edit, Fabort_recursive_edit): Mark with NO_RETURN.
3115
3116 * keyboard.h (make_ctrl_char): New decl.
3117 (mark_kboards): Move decl here ...
3118 * alloc.c (mark_kboards): ... from here.
3119
3120 * lisp.h (force_auto_save_soon): New decl.
3121
3122 * emacs.c (init_cmdargs): Rename local to avoid shadowing.
3123 (DEFINE_DUMMY_FUNCTION): New macro.
3124 (__do_global_ctors, __do_global_ctors_aux, __do_global_dtors, __main):
3125 Use it.
3126 (main): Add casts to avoid warnings
3127 if GCC considers string literals to be constants.
3128
3129 * lisp.h (fatal_error_signal): Add decl, since it's exported.
3130
3131 * dbusbind.c: Pointer signedness fixes.
3132 (xd_signature, xd_append_arg, xd_initialize):
3133 (Fdbus_call_method, Fdbus_call_method_asynchronously):
3134 (Fdbus_method_return_internal, Fdbus_method_error_internal):
3135 (Fdbus_send_signal, xd_read_message_1, Fdbus_register_service):
3136 (Fdbus_register_signal): Use SSDATA when the context wants char *.
3137
3138 * dbusbind.c (Fdbus_init_bus): Add cast to avoid warning
3139 if GCC considers string literals to be constants.
3140 (Fdbus_register_service, Fdbus_register_method): Remove unused vars.
3141
3142 2011-03-16 Stefan Monnier <monnier@iro.umontreal.ca>
3143
3144 * print.c (PRINT_CIRCLE_CANDIDATE_P): New macro.
3145 (print_preprocess, print_object): New macro to fix last change.
3146
3147 * print.c (print_preprocess): Don't forget font objects.
3148
3149 2011-03-16 Juanma Barranquero <lekktu@gmail.com>
3150
3151 * emacs.c (USAGE3): Doc fixes.
3152
3153 2011-03-15 Andreas Schwab <schwab@linux-m68k.org>
3154
3155 * coding.c (detect_coding_iso_2022): Reorganize code to clarify
3156 structure.
3157
3158 2011-03-14 Juanma Barranquero <lekktu@gmail.com>
3159
3160 * lisp.h (VWindow_system, Qfile_name_history):
3161 * keyboard.h (lispy_function_keys) [WINDOWSNT]:
3162 * w32term.h (w32_system_caret_hwnd, w32_system_caret_height)
3163 (w32_system_caret_x, w32_system_caret_y): Declare extern.
3164
3165 * w32select.c: Don't #include "keyboard.h".
3166 (run_protected): Add extern declaration for waiting_for_input.
3167
3168 * w32.c (Qlocal, noninteractive1, inhibit_window_system):
3169 * w32console.c (detect_input_pending, read_input_pending)
3170 (encode_terminal_code):
3171 * w32fns.c (quit_char, lispy_function_keys, Qtooltip)
3172 (w32_system_caret_hwnd, w32_system_caret_height, w32_system_caret_x)
3173 (w32_system_caret_y, Qfile_name_history):
3174 * w32font.c (w32font_driver, QCantialias, QCotf, QClang):
3175 * w32inevt.c (reinvoke_input_signal, lispy_function_keys):
3176 * w32menu.c (Qmenu_bar, QCtoggle, QCradio, Qoverriding_local_map)
3177 (Qoverriding_terminal_local_map, Qmenu_bar_update_hook):
3178 * w32proc.c (Qlocal, report_file_error):
3179 * w32term.c (Vwindow_system, updating_frame):
3180 * w32uniscribe.c (initialized, uniscribe_font_driver):
3181 Remove unneeded extern declarations.
3182
3183 2011-03-14 Chong Yidong <cyd@stupidchicken.com>
3184
3185 * buffer.c (Fmake_indirect_buffer): Fix incorrect assertions.
3186
3187 2011-03-13 Chong Yidong <cyd@stupidchicken.com>
3188
3189 * buffer.h (BUF_BEGV, BUF_BEGV_BYTE, BUF_ZV, BUF_ZV_BYTE, BUF_PT)
3190 (BUF_PT_BYTE): Rewrite to handle indirect buffers (Bug#8219).
3191 These macros can no longer be used for assignment.
3192
3193 * buffer.c (Fget_buffer_create, Fmake_indirect_buffer):
3194 Assign struct members directly, instead of using BUF_BEGV etc.
3195 (record_buffer_markers, fetch_buffer_markers): New functions for
3196 recording and fetching special buffer markers.
3197 (set_buffer_internal_1, set_buffer_temp): Use them.
3198
3199 * lread.c (unreadchar): Use SET_BUF_PT_BOTH.
3200
3201 * insdel.c (adjust_point): Use SET_BUF_PT_BOTH.
3202
3203 * intervals.c (temp_set_point_both): Use SET_BUF_PT_BOTH.
3204 (get_local_map): Use SET_BUF_BEGV_BOTH and SET_BUF_ZV_BOTH.
3205
3206 * xdisp.c (hscroll_window_tree):
3207 (reconsider_clip_changes): Use PT instead of BUF_PT.
3208
3209 2011-03-13 Eli Zaretskii <eliz@gnu.org>
3210
3211 * makefile.w32-in ($(BLD)/editfns.$(O)): Depend on
3212 $(EMACS_ROOT)/lib/intprops.h.
3213
3214 2011-03-13 Paul Eggert <eggert@cs.ucla.edu>
3215
3216 Fix more problems found by GCC 4.5.2's static checks.
3217
3218 * gtkutil.c (xg_get_pixbuf_from_pixmap): Add cast from char *
3219 to unsigned char * to avoid compiler diagnostic.
3220 (xg_free_frame_widgets): Make it clear that a local variable is
3221 needed only if USE_GTK_TOOLTIP.
3222 (gdk_window_get_screen): Make it clear that this macro is needed
3223 only if USE_GTK_TOOLTIP.
3224 (int_gtk_range_get_value): New function, which avoids a diagnostic
3225 from gcc -Wbad-function-cast.
3226 (xg_set_toolkit_scroll_bar_thumb): Use it.
3227 (xg_tool_bar_callback, xg_tool_item_stale_p): Rewrite to avoid
3228 diagnostic from gcc -Wbad-function-cast.
3229 (get_utf8_string, xg_get_file_with_chooser):
3230 Rename locals to avoid shadowing.
3231 (create_dialog): Move locals to avoid shadowing.
3232
3233 * xgselect.c (xg_select): Remove unused var.
3234
3235 * image.c (four_corners_best): Mark locals as initialized.
3236 (gif_load): Initialize transparent_p to zero (Bug#8238).
3237 Mark another local as initialized.
3238 (my_png_error, my_error_exit): Mark with NO_RETURN.
3239
3240 * image.c (clear_image_cache): Now static.
3241 (DIM, HAVE_STDLIB_H_1): Remove unused macros.
3242 (xpm_load): Redo to avoid "discards qualifiers" gcc warning.
3243 (x_edge_detection): Remove unnecessary cast that
3244 gcc -Wbad-function-cast diagnoses.
3245 (gif_load): Fix pointer signedness.
3246 (clear_image_cache, xbm_read_bitmap_data, x_detect_edges):
3247 (jpeg_load, gif_load): Rename locals to avoid shadowing.
3248
3249 2011-03-12 Paul Eggert <eggert@cs.ucla.edu>
3250
3251 Improve quality of tests for time stamp overflow.
3252 For example, without this patch (encode-time 0 0 0 1 1
3253 1152921504606846976) returns the obviously-bogus value (-948597
3254 62170) on my RHEL 5.5 x86-64 host. With the patch, it correctly
3255 reports time overflow. See
3256 <http://lists.gnu.org/archive/html/emacs-devel/2011-03/msg00470.html>.
3257 * deps.mk (editfns.o): Depend on ../lib/intprops.h.
3258 * editfns.c: Include limits.h and intprops.h.
3259 (TIME_T_MIN, TIME_T_MAX): New macros.
3260 (time_overflow): Move earlier, to before first use.
3261 (hi_time, lo_time): New functions, for an accurate test for
3262 out-of-range times.
3263 (Fcurrent_time, Fget_internal_run_time, make_time): Use them.
3264 (Fget_internal_run_time): Don't assume time_t fits in int.
3265 (make_time): Use list2 instead of Fcons twice.
3266 (Fdecode_time): More accurate test for out-of-range times.
3267 (check_tm_member): New function.
3268 (Fencode_time): Use it, to test for out-of-range times.
3269 (lisp_time_argument): Don't rely on undefined left-shift and
3270 right-shift behavior when checking for time stamp overflow.
3271
3272 * editfns.c (time_overflow): New function, refactoring common code.
3273 (Fformat_time_string, Fdecode_time, Fencode_time):
3274 (Fcurrent_time_string): Use it.
3275
3276 Move 'make_time' to be next to its inverse 'lisp_time_argument'.
3277 * dired.c (make_time): Move to ...
3278 * editfns.c (make_time): ... here.
3279 * systime.h: Note the move.
3280
3281 2011-03-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
3282
3283 * fringe.c (update_window_fringes): Remove unused variables.
3284
3285 * unexmacosx.c (copy_data_segment): Also copy __got section.
3286 (Bug#8223)
3287
3288 2011-03-12 Eli Zaretskii <eliz@gnu.org>
3289
3290 * termcap.c [MSDOS]: Include "msdos.h".
3291 (find_capability, tgetnum, tgetflag, tgetstr, tputs, tgetent):
3292 Constify `char *' arguments and their references according to
3293 prototypes in tparam.h.
3294
3295 * deps.mk (termcap.o): Depend on tparam.h and msdos.h.
3296
3297 * msdos.c (XMenuAddPane): 3rd argument is `const char *' now.
3298 Adapt all references accordingly.
3299
3300 * msdos.h (XMenuAddPane): 3rd argument is `const char *' now.
3301
3302 2011-03-11 Tom Tromey <tromey@redhat.com>
3303
3304 * buffer.c (syms_of_buffer): Remove obsolete comment.
3305
3306 2011-03-11 Eli Zaretskii <eliz@gnu.org>
3307
3308 * termhooks.h (encode_terminal_code): Declare prototype.
3309
3310 * msdos.c (encode_terminal_code): Don't declare prototype.
3311
3312 * term.c (encode_terminal_code): Now external again, used by
3313 w32console.c and msdos.c.
3314
3315 * makefile.w32-in ($(BLD)/term.$(O), ($(BLD)/tparam.$(O)):
3316 Depend on $(SRC)/tparam.h, see 2011-03-11T07:24:21Z!eggert@cs.ucla.edu.
3317
3318 2011-03-11 Paul Eggert <eggert@cs.ucla.edu>
3319
3320 Fix some minor problems found by GCC 4.5.2's static checks.
3321
3322 * fringe.c (update_window_fringes): Mark locals as initialized
3323 (Bug#8227).
3324 (destroy_fringe_bitmap, init_fringe_bitmap): Now static.
3325
3326 * alloc.c (mark_fringe_data): Move decl from here ...
3327 * lisp.h (mark_fringe_data) [HAVE_WINDOW_SYSTEM]: ... to here,
3328 to check its interface.
3329 (init_fringe_once): Do not declare unless HAVE_WINDOW_SYSTEM.
3330
3331 * fontset.c (free_realized_fontset): Now static.
3332 (Fset_fontset_font): Rename local to avoid shadowing.
3333 (fontset_font): Mark local as initialized.
3334 (FONTSET_SPEC, FONTSET_REPERTORY, RFONT_DEF_REPERTORY): Remove; unused.
3335
3336 * xrdb.c: Include "xterm.h", to check x_load_resources's interface.
3337
3338 * xselect.c (x_disown_buffer_selections): Remove; not used.
3339 (TRACE3) [!defined TRACE_SELECTION]: Remove; not used.
3340 (x_own_selection, Fx_disown_selection_internal): Rename locals
3341 to avoid shadowing.
3342 (x_handle_dnd_message): Remove local to avoid shadowing.
3343
3344 * lisp.h (GCPRO1_VAR, UNGCPRO_VAR): New macros,
3345 so that the caller can use some name other than gcpro1.
3346 (GCPRO1, UNGCPRO): Reimplement in terms of the new macros.
3347 * xfns.c (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
3348 (Fx_backspace_delete_keys_p):
3349 Use them to avoid shadowing, and rename vars to avoid shadowing.
3350 (x_decode_color, x_set_name, x_window): Now static.
3351 (Fx_create_frame): Add braces to silence GCC warning.
3352 (Fx_file_dialog, Fx_select_font): Fix pointer signedness.
3353 (x_real_positions, xg_set_icon_from_xpm_data, x_create_tip_frame):
3354 Remove unused locals.
3355 (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
3356 (Fx_backspace_delete_keys_p): Rename locals to avoid shadowing.
3357 Some of these renamings use the new GCPRO1_VAR and UNGCPRO_VAR
3358 macros.
3359
3360 * xterm.h (x_mouse_leave): New decl.
3361
3362 * xterm.c (x_copy_dpy_color, x_focus_on_frame, x_unfocus_frame):
3363 Remove unused functions.
3364 (x_shift_glyphs_for_insert, XTflash, XTring_bell):
3365 (x_calc_absolute_position): Now static.
3366 (XTread_socket): Don't define label "out" unless it's used.
3367 Don't declare local "event" unless it's used.
3368 (x_iconify_frame, x_free_frame_resources): Don't declare locals
3369 unless they are used.
3370 (XEMBED_VERSION, xembed_set_info): Don't define unless needed.
3371 (x_fatal_error_signal): Remove; not used.
3372 (x_draw_image_foreground, redo_mouse_highlight, XTmouse_position):
3373 (x_scroll_bar_report_motion, handle_one_xevent, x_draw_bar_cursor):
3374 (x_error_catcher, x_connection_closed, x_error_handler):
3375 (x_error_quitter, xembed_send_message, x_iconify_frame):
3376 (my_log_handler): Rename locals to avoid shadowing.
3377 (x_delete_glyphs, x_ins_del_lines): Mark with NO_RETURN.
3378 (x_connection_closed): Tell GCC not to suggest NO_RETURN.
3379
3380 * xfaces.c (clear_face_cache, Fx_list_fonts, Fface_font):
3381 Rename or move locals to avoid shadowing.
3382 (tty_defined_color, merge_face_heights): Now static.
3383 (free_realized_faces_for_fontset): Remove; not used.
3384 (Fx_list_fonts): Mark variable that gcc -Wuninitialized
3385 does not deduce is never used uninitialized.
3386 (STRDUPA, LSTRDUPA, FONT_POINT_SIZE_QUANTUM): Remove; not used.
3387 (LFACEP): Define only if XASSERTS, as it's not needed otherwise.
3388
3389 * terminal.c (store_terminal_param): Now static.
3390
3391 * xmenu.c (menu_highlight_callback): Now static.
3392 (set_frame_menubar): Remove unused local.
3393 (xmenu_show): Rename parameter to avoid shadowing.
3394 (xmenu_show, xdialog_show, xmenu_show): Make local pointers "const"
3395 since they might point to immutable storage.
3396 (next_menubar_widget_id): Declare only if USE_X_TOOLKIT,
3397 since it's unused otherwise.
3398
3399 * xdisp.c (produce_glyphless_glyph): Initialize lower_xoff.
3400 Add a FIXME, since the code still doesn't look right. (Bug#8215)
3401 (Fcurrent_bidi_paragraph_direction): Simplify slightly; this
3402 avoids a gcc -Wuninitialized diagnostic.
3403 (display_line, BUILD_COMPOSITE_GLYPH_STRING, draw_glyphs):
3404 (note_mouse_highlight): Mark variables that gcc -Wuninitialized
3405 does not deduce are never used uninitialized.
3406
3407 * lisp.h (IF_LINT): New macro, copied from ../lib-src/emacsclient.c.
3408
3409 * xdisp.c (redisplay_window): Rename local to avoid shadowing.
3410 * window.c (window_loop, size_window):
3411 (run_window_configuration_change_hook, enlarge_window): Likewise.
3412
3413 * window.c (display_buffer): Now static.
3414 (size_window): Mark variables that gcc -Wuninitialized
3415 does not deduce are never used uninitialized.
3416 * window.h (check_all_windows): New decl, to forestall
3417 gcc -Wmissing-prototypes diagnostic.
3418 * dispextern.h (bidi_dump_cached_states): Likewise.
3419
3420 * charset.h (CHECK_CHARSET_GET_CHARSET): Rename locals to avoid
3421 shadowing.
3422 * charset.c (map_charset_for_dump, Fchar_charset): Likewise.
3423 Include <limits.h>.
3424 (Fsort_charsets): Redo min/max calculation to shorten the code a bit
3425 and to avoid gcc -Wuninitialized warning.
3426 (load_charset_map): Mark variables that gcc -Wuninitialized
3427 does not deduce are never used uninitialized.
3428 (load_charset): Abort instead of using uninitialized var (Bug#8229).
3429
3430 * coding.c (coding_set_source, coding_set_destination):
3431 Use "else { /* comment */ }" rather than "else /* comment */;"
3432 for clarity, and to avoid gcc -Wempty-body warning.
3433 (Fdefine_coding_system_internal): Don't redeclare 'i' inside
3434 a block, when the outer 'i' will do.
3435 (decode_coding_utf_8, decode_coding_utf_16, detect_coding_emacs_mule):
3436 (emacs_mule_char, decode_coding_emacs_mule, detect_coding_iso_2022):
3437 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5):
3438 (decode_coding_raw_text, decode_coding_charset, get_translation_table):
3439 (Fdecode_sjis_char, Fdefine_coding_system_internal):
3440 Rename locals to avoid shadowing.
3441 * character.h (FETCH_STRING_CHAR_ADVANCE): Likewise.
3442 * coding.c (emacs_mule_char, encode_invocation_designation):
3443 Now static, since they're not used elsewhere.
3444 (decode_coding_iso_2022): Add "default: abort ();" as a safety check.
3445 (decode_coding_object, encode_coding_object, detect_coding_system):
3446 (decode_coding_emacs_mule): Mark variables that gcc
3447 -Wuninitialized does not deduce are never used uninitialized.
3448 (detect_coding_iso_2022): Initialize a local variable that might
3449 be used uninitialized. Leave a FIXME because it's not clear that
3450 this initialization is needed. (Bug#8211)
3451 (ISO_CODE_LF, ISO_CODE_CR, CODING_ISO_FLAG_EUC_TW_SHIFT):
3452 (ONE_MORE_BYTE_NO_CHECK, UTF_BOM, UTF_16_INVALID_P):
3453 (SHIFT_OUT_OK, ENCODE_CONTROL_SEQUENCE_INTRODUCER):
3454 (ENCODE_DIRECTION_R2L, ENCODE_DIRECTION_L2R):
3455 Remove unused macros.
3456
3457 * category.c (hash_get_category_set): Remove unused local var.
3458 (copy_category_table): Now static, since it's not used elsewhere.
3459 * character.c (string_count_byte8): Likewise.
3460
3461 * ccl.c (CCL_WRITE_STRING, CCL_ENCODE_CHAR, Fccl_execute_on_string):
3462 (Fregister_code_conversion_map): Rename locals to avoid shadowing.
3463
3464 * chartab.c (copy_sub_char_table): Now static, since it's not used
3465 elsewhere.
3466 (sub_char_table_ref_and_range, char_table_ref_and_range):
3467 Rename locals to avoid shadowing.
3468 (ASET_RANGE, GET_SUB_CHAR_TABLE): Remove unused macros.
3469
3470 * bidi.c (bidi_check_type): Now static, since it's not used elsewhere.
3471 (BIDI_BOB): Remove unused macro.
3472
3473 * cm.c (cmgoto): Mark variables that gcc -Wuninitialized does not
3474 deduce are never used uninitialized.
3475 * term.c (encode_terminal_code): Likewise.
3476
3477 * term.c (encode_terminal_code): Now static. Remove unused local.
3478
3479 * tparam.h: New file.
3480 * term.c, tparam.h: Include it.
3481 * deps.mk (term.o, tparam.o): Depend on tparam.h.
3482 * term.c (tputs, tgetent, tgetflag, tgetnum, tparam, tgetstr):
3483 Move these decls to tparam.h, and make them agree with what
3484 is actually in tparam.c. The previous trick of using incompatible
3485 decls in different modules does not conform to the C standard.
3486 All callers of tparam changed to use tparam's actual API.
3487 * tparam.c (tparam1, tparam, tgoto):
3488 Use const pointers where appropriate.
3489
3490 * cm.c (calccost, cmgoto): Use const pointers where appropriate.
3491 * cm.h (struct cm): Likewise.
3492 * dispextern.h (do_line_insertion_deletion_costs): Likewise.
3493 * scroll.c (ins_del_costs, do_line_insertion_deletion_costs): Likewise.
3494 * term.c (tty_ins_del_lines, calculate_costs, struct fkey_table):
3495 (term_get_fkeys_1, append_glyphless_glyph, produce_glyphless_glyph):
3496 (turn_on_face, init_tty): Likewise.
3497 * termchar.h (struct tty_display_info): Likewise.
3498
3499 * term.c (term_mouse_position): Rename local to avoid shadowing.
3500
3501 * alloc.c (mark_ttys): Move decl from here ...
3502 * lisp.h (mark_ttys): ... to here, so that it's checked against defn.
3503
3504 2011-03-11 Andreas Schwab <schwab@linux-m68k.org>
3505
3506 * .gdbinit (pwinx, xbuffer): Fix access to buffer name.
3507
3508 2011-03-09 Juanma Barranquero <lekktu@gmail.com>
3509
3510 * search.c (compile_pattern_1): Remove argument regp, unused since
3511 revid:rms@gnu.org-19941211082627-3x1g1wyqkjmwloig.
3512 (compile_pattern): Don't pass it.
3513
3514 2011-03-08 Jan Djärv <jan.h.d@swipnet.se>
3515
3516 * xterm.h (DEFAULT_GDK_DISPLAY): New define.
3517 (GDK_WINDOW_XID, gtk_widget_get_preferred_size): New defines
3518 for ! HAVE_GTK3.
3519 (GTK_WIDGET_TO_X_WIN): Use GDK_WINDOW_XID.
3520
3521 * xmenu.c (menu_position_func): Call gtk_widget_get_preferred_size.
3522
3523 * gtkutil.c: Include gtkx.h if HAVE_GTK3. If ! HAVE_GTK3, define
3524 gdk_window_get_screen, gdk_window_get_geometry,
3525 gdk_x11_window_lookup_for_display and GDK_KEY_g.
3526 (xg_set_screen): Use DEFAULT_GDK_DISPLAY.
3527 (xg_get_pixbuf_from_pixmap): New function.
3528 (xg_get_pixbuf_from_pix_and_mask): Change parameters from GdkPixmap
3529 to Pixmap, take frame as parameter, remove GdkColormap parameter.
3530 Call xg_get_pixbuf_from_pixmap instead of
3531 gdk_pixbuf_get_from_drawable.
3532 (xg_get_image_for_pixmap): Do not make GdkPixmaps, call
3533 xg_get_pixbuf_from_pix_and_mask with Pixmap parameters instead.
3534 (xg_check_special_colors): Use GtkStyleContext and its functions
3535 for HAVE_GTK3.
3536 (xg_prepare_tooltip, xg_hide_tooltip): Call gdk_window_get_screen.
3537 (xg_prepare_tooltip, create_dialog, menubar_map_cb)
3538 (xg_update_frame_menubar, xg_tool_bar_detach_callback)
3539 (xg_tool_bar_attach_callback, xg_update_tool_bar_sizes):
3540 Call gtk_widget_get_preferred_size.
3541 (xg_frame_resized): gdk_window_get_geometry only takes 5
3542 parameters.
3543 (xg_win_to_widget, xg_event_is_for_menubar):
3544 Call gdk_x11_window_lookup_for_display.
3545 (xg_set_widget_bg): New function.
3546 (delete_cb): New function.
3547 (xg_create_frame_widgets): Connect delete-event to delete_cb.
3548 Call xg_set_widget_bg. Only set backgrund pixmap for ! HAVE_GTK3
3549 (xg_set_background_color): Call xg_set_widget_bg.
3550 (xg_set_frame_icon): Call xg_get_pixbuf_from_pix_and_mask.
3551 (xg_create_scroll_bar): vadj is a GtkAdjustment for HAVE_GTK3.
3552 Only call gtk_range_set_update_policy if ! HAVE_GTK3.
3553 (xg_make_tool_item): Only connect xg_tool_bar_item_expose_callback
3554 if ! HAVE_GTK3.
3555 (update_frame_tool_bar): Call gtk_widget_hide.
3556 (xg_initialize): Use GDK_KEY_g.
3557
3558 * xsmfns.c (gdk_set_sm_client_id): Define to gdk_set_sm_client_id
3559 if ! HAVE_GTK3
3560 (x_session_initialize): Call gdk_x11_set_sm_client_id.
3561
3562 * xterm.c (XFillRectangle): Use cairo routines for HAVE_GTK3.
3563 (x_term_init): Disable Xinput(2) with GDK_CORE_DEVICE_EVENTS.
3564 Load ~/emacs.d/gtkrc only for ! HAVE_GTK3.
3565
3566 2011-03-08 Juanma Barranquero <lekktu@gmail.com>
3567
3568 * w32xfns.c (select_palette): Check success of RealizePalette against
3569 GDI_ERROR, not zero.
3570
3571 See ChangeLog.11 for earlier changes.
3572
3573 ;; Local Variables:
3574 ;; coding: utf-8
3575 ;; End:
3576
3577 Copyright (C) 2011 Free Software Foundation, Inc.
3578
3579 This file is part of GNU Emacs.
3580
3581 GNU Emacs is free software: you can redistribute it and/or modify
3582 it under the terms of the GNU General Public License as published by
3583 the Free Software Foundation, either version 3 of the License, or
3584 (at your option) any later version.
3585
3586 GNU Emacs is distributed in the hope that it will be useful,
3587 but WITHOUT ANY WARRANTY; without even the implied warranty of
3588 MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
3589 GNU General Public License for more details.
3590
3591 You should have received a copy of the GNU General Public License
3592 along with GNU Emacs. If not, see <http://www.gnu.org/licenses/>.