1 2011-04-16 Paul Eggert <eggert@cs.ucla.edu>
3 * frame.c, frame.h (x_get_resource_string): Bring this back, but
4 only if HAVE_X_WINDOWS && !USE_X_TOOLKIT.
6 * bitmaps: Change bitmaps from unsigned char back to the X11
7 compatible char. Avoid the old compiler warnings about
8 out-of-range initializers by using, for example, '\xab' rather
11 * xgselect.c (xgselect_initialize): Check vs interface
12 even if ! (defined (USE_GTK) || defined (HAVE_GCONF)).
14 * xmenu.c (xmenu_show): Rename parm to avoid shadowing.
16 * xterm.c (x_create_toolkit_scroll_bar): Use const * for pointers
19 * fns.c (vector): Remove; this old hack is no longer needed.
21 * xsmfns.c (create_client_leader_window): Rename shadowing arg.
23 (gdk_x11_set_sm_client_id) [!USE_GTK]: Don't define.
25 * xrdb.c (x_load_resources): Omit unused local.
27 * xfns.c (free_frame_menubar, atof): Remove duplicate decls.
28 (x_window): Rename locals to avoid shadowing.
29 (USG): Use the kludged USG macro, to pacify gcc.
31 * xterm.c (x_alloc_nearest_color_for_widget): Remove; unused.
32 (x_term_init): Remove local to avoid shadowing.
34 * xfns.c, xterm.c (_XEditResCheckMessages): Protoize decl.
36 * xdisp.c, dispextern.h (set_vertical_scroll_bar): Now extern if
37 USE_TOOLKIT_SCROLL_BARS && !USE_GTK, as xterm.c needs it then.
39 2011-04-15 Paul Eggert <eggert@cs.ucla.edu>
41 * sysdep.c (emacs_read): Remove unnecessary check vs MAX_RW_COUNT.
43 emacs_write: Accept and return EMACS_INT for sizes.
44 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html
46 * gnutls.c, gnutls.h (emacs_gnutls_read, emacs_gnutls_write):
47 Accept and return EMACS_INT.
48 (emacs_gnutls_write): Return the number of bytes written on
50 * sysdep.c, lisp.h (emacs_read, emacs_write): Likewise.
51 (emacs_read, emacs_write): Remove check for negative size, as the
52 Emacs source code has been audited now.
53 * sysdep.c (MAX_RW_COUNT): New macro, to work around kernel bugs.
54 (emacs_read, emacs_write): Use it.
55 * process.c (send_process): Adjust to the new signatures of
56 emacs_write and emacs_gnutls_write. Do not attempt to store
57 a byte offset into an 'int'; it might overflow.
58 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00483.html
60 * sound.c: Don't assume sizes fit in 'int'.
61 (struct sound_device.period_size, alsa_period_size):
62 Return EMACS_INT, not int.
63 (struct sound_device.write, vox_write, alsa_write):
64 Accept EMACS_INT, not int.
65 (wav_play, au_play): Use EMACS_INT to store sizes and to
66 record read return values.
68 2011-04-15 Ben Key <bkey76@gmail.com>
70 * keyboard.c (Qundefined): Don't declare static since it is
72 * xfaces.c (Qbold, Qexpanded, Qitalic, Qcondensed): Don't
73 declare static since they are used in nsfont.m.
75 2011-04-15 Stefan Monnier <monnier@iro.umontreal.ca>
77 * process.c (Qprocessp): Don't declare static.
78 * lisp.h (Qprocessp): Declare again.
80 2011-04-15 Juanma Barranquero <lekktu@gmail.com>
82 * font.c (Qopentype): Don't make static (used from w32uniscribe.c).
84 2011-04-14 Paul Eggert <eggert@cs.ucla.edu>
86 Improve C-level modularity by making more things 'static'.
88 Don't publish debugger-only interfaces to other modules.
89 * lisp.h (safe_debug_print, debug_output_compilation_hack):
90 (verify_bytepos, count_markers): Move decls to the only modules
92 * region-cache.h (pp_cache): Likewise.
93 * window.h (check_all_windows): Likewise.
94 * marker.c, print.c, region-cache.c, window.c: Decls moved here.
96 * sysdep.c (croak): Now static, if
97 defined TIOCNOTTY || defined USG5 || defined CYGWIN.
98 * syssignal.h (croak): Declare only if not static.
100 * alloc.c (refill_memory_reserve): Now static if
101 !defined REL_ALLOC || defined SYSTEM_MALLOC.
102 * lisp.h (refill_memory_reserve): Declare only if not static.
104 * xsettings.c, xsettings.h (xsettings_get_system_normal_font):
105 Define only if USE_LUCID.
107 * xrdb.c (x_customization_string, x_rm_string): Now static.
109 * xmenu.c (x_menu_wait_for_event): Export only if USE_MOTIF.
110 * xterm.h (x_menu_wait_for_event): Declare only if USE_MOTIF.
112 * xdisp.c (draw_row_with_mouse_face): Now static.
113 * dispextern.h (draw_row_with_mouse_fave): Remove decl.
115 * window.h (check_all_windows): Mark externally visible.
117 * window.c (window_deletion_count): Now static.
119 * undo.c: Make symbols static if they're not exported.
120 (last_undo_buffer, last_boundary_position, pending_boundary):
123 * textprop.c (interval_insert_behind_hooks): Now static.
124 (interval_insert_in_front_hooks): Likewise.
126 * term.c: Make symbols static if they're not exported.
127 (tty_turn_off_highlight, get_tty_terminal, max_frame_cols):
128 (max_frame_lines, tty_set_terminal_modes):
129 (tty_reset_terminal_modes, tty_turn_off_highlight):
130 (get_tty_terminal): Now static.
131 (term_mouse_moveto): Do not define if HAVE_WINDOW_SYSTEM.
132 * termhooks.h (term_mouse_moveto): Do not declare if
134 * dispextern.h (tty_set_terminal_modes, tty_reset_terminal_modes):
135 (tty_turn_off_highlight, get_tty_terminal): Remove decls.
137 * sysdep.c: Make symbols static if they're not exported.
138 (emacs_get_tty, emacs_set_tty, old_fcntl_flags, old_fcntl_owner):
140 (sigprocmask_set, full_mask): Remove; unused.
141 (wait_debugging): Mark as visible.
142 * syssignal.h (SIGFULLMASK, full_mask): Remove decls.
143 * systty.h (emacs_get_tty, emacs_set_tty): Remove decls.
145 * syntax.c (syntax_temp): Define only if !__GNUC__.
147 * sound.c (current_sound_device, current_sound): Now static.
149 * search.c (searchbufs, searchbuf_head): Now static.
151 * scroll.c (scroll_cost): Remove; unused.
152 * dispextern.h (scroll_cost): Remove decl.
154 * region-cache.h (pp_cache): Mark as externally visible.
156 * process.c: Make symbols static if they're not exported.
157 (process_tick, update_tick, create_process, chan_process):
158 (Vprocess_alist, proc_buffered_char, datagram_access):
159 (fd_callback_data, send_process_frame, process_sent_to): Now static.
160 (deactivate_process): Mark defn as static, as well as decl.
161 * lisp.h (create_process): Remove decl.
162 * process.h (chan_process, Vprocess_alist): Remove decls.
164 * print.c: Make symbols static if they're not exported.
165 (print_depth, new_backquote_output, being_printed, print_buffer):
166 (print_buffer_size, print_buffer_pos, print_buffer_pos_byte):
167 (print_interval, print_number_index, initial_stderr_stream):
169 * lisp.h (Fprinc): Remove decl.
170 (debug_output_compilation_hack): Mark as externally visible.
172 * sysdep.c (croak): Move decl from here to syssignal.h.
173 * syssignal.h (croak): Put it here, so the API can be checked when
174 'croak' is called from dissociate_if_controlling_tty.
176 * minibuf.c: Make symbols static if they're not exported.
177 (minibuf_save_list, choose_minibuf_frame): Now static.
178 * lisp.h (choose_minibuf_frame): Remove decl.
180 * lisp.h (verify_bytepos, count_markers): Mark as externally visible.
182 * lread.c: Make symbols static if they're not exported.
183 (read_objects, initial_obarray, oblookup_last_bucket_number):
185 (make_symbol): Remove; unused.
186 * lisp.h (initial_obarray, make_symbol): Remove decls.
188 * keyboard.c: Make symbols static if they're not exported.
189 (single_kboard, recent_keys_index, total_keys, recent_keys):
190 (this_command_key_count_reset, raw_keybuf, raw_keybuf_count):
191 (this_single_command_key_start, echoing, last_auto_save):
192 (read_key_sequence_cmd, dribble, recursive_edit_unwind):
193 (command_loop, echo_now, keyboard_init_hook, help_char_p):
194 (quit_throw_to_read_char, command_loop_2, top_level_1, poll_timer):
195 (Vlispy_mouse_stem, double_click_count):
197 (force_auto_save_soon): Define only if SIGDANGER.
198 (ignore_mouse_drag_p): Now static if
199 !defined HAVE_WINDOW_SYSTEM || defined USE_GTK || defined HAVE_NS.
200 (print_help): Remove; unused.
201 (stop_character, last_timer_event): Mark as externally visible.
202 * keyboard.h (ignore_mouse_drag_p): Declare only if
203 defined HAVE_WINDOW_SYSTEM && !defined USE_GTK && !defined HAVE_NS.
204 (echo_now, help_char_p, quit_throw_to_read_char): Remove decls.
205 * lisp.h (echoing): Remove decl.
206 (force_auto_save_soon): Declare only if SIGDANGER.
207 * xdisp.c (redisplay_window): Simplify code, to make it more
208 obvious that ignore_mouse_drag_p is not accessed if !defined
209 USE_GTK && !defined HAVE_NS.
211 * intervals.c: Make symbols static if they're not exported.
212 (merge_properties_sticky, merge_interval_right, delete_interval):
214 * intervals.h (merge_interval_right, delete_interval): Remove decls.
216 * insdel.c: Make symbols static if they're not exported.
217 However, leave prepare_to_modify_buffer alone. It's never
218 called from outside this function, but that appears to be a bug.
219 (combine_after_change_list, combine_after_change_buffer):
220 (adjust_after_replace, signal_before_change): Now static.
221 (adjust_after_replace_noundo): Remove; unused.
222 * lisp.h (adjust_after_replace, adjust_after_replace_noundo):
223 (signal_before_change): Remove decls.
225 * indent.c (val_compute_motion, val_vmotion): Now static.
227 * image.c: Make symbols static if they're not exported.
228 * dispextern.h (x_create_bitmap_from_xpm_data): Do not declare
230 * image.c (x_create_bitmap_from_xpm_data): Do not define if USE_GTK.
231 (xpm_color_cache, ct_table, ct_colors_allocated): Now static.
233 * fringe.c (standard_bitmaps): Now static.
234 (max_used_fringe_bitmap): Now static, unless HAVE_NS.
236 * frame.c: Make symbols static if they're not exported.
237 (x_report_frame_params, make_terminal_frame): Now static.
238 (get_frame_param): Now static, unless HAVE_NS.
239 (x_fullscreen_adjust): Define if WINDOWSNT, not if HAVE_WINDOW_SYSTEM.
240 (x_get_resource_string): Remove; not used.
241 * frame.h (make_terminal_frame, x_report_frame_params):
242 (x_get_resource_string); Remove decls.
243 (x_fullscreen_adjust): Declare only if WINDOWSNT.
244 * lisp.h (get_frame_param): Declare only if HAVE_NS.
246 * font.c, fontset.c: Make symbols static if they're not exported.
247 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): New macro.
248 (FACE_SUITABLE_FOR_CHAR_P): Use it.
249 * font.c (font_close_object): Now static.
250 * font.h (font_close_object): Remove.
251 * fontset.c (FONTSET_OBJLIST): Remove.
252 (free_realized_fontset) #if-0 the body, which does nothing.
253 (face_suitable_for_char_p): #if-0, as it's never called.
254 * fontset.h (face_suitable_for_char_p): Remove decl.
255 * xfaces.c (face_at_string_position): Use
256 FACE_SUITABLE_FOR_ASCII_CHAR_P, not FACE_SUITABLE_FOR_CHAR_P,
257 since 0 is always ASCII.
259 * fns.c (weak_hash_tables): Now static.
261 * fileio.c: Make symbols static if they're not exported.
262 (auto_saving, auto_save_mode_bits, auto_save_error_occurred):
263 (Vwrite_region_annotation_buffers): Now static.
265 * eval.c: Make symbols static if they're not exported.
266 (backtrace_list, lisp_eval_depth, when_entered_debugger): Now static.
267 * lisp.h (backtrace_list): Remove decl.
269 * emacs.c: Make symbols static if they're not exported.
270 (malloc_state_ptr, malloc_using_checking, syms_of_emacs):
271 (fatal_error_code, fatal_error_signal_hook, standard_args):
273 (fatal_error_signal): Now static, unless FLOAT_CATCH_SIGKILL.
274 (DEFINE_DUMMY_FUNCTION): Mark function as externally visible.
275 (__CTOR_LIST__, __DTOR_LIST__): Now externally visible.
276 * lisp.h (fatal_error_signal_hook): Remove decl.
277 (fatal_error_signal): Declare only if FLOAT_CATCH_SIGKILL.
279 * editfns.c: Move a (normally-unused) function to its only use.
280 * editfns.c, lisp.h (get_operating_system_release): Remove.
281 * process.c (init_process) [DARWIN_OS]: Do it inline, as it is not
282 worth the hassle of breaking this out.
284 * xterm.c: Make symbols static if they're not exported.
285 (x_raise_frame, x_lower_frame, x_wm_set_window_state):
286 (x_wm_set_icon_pixmap, x_initialize, XTread_socket_fake_io_error):
287 (x_destroy_window, x_delete_display):
289 (x_dispatch_event): Now static if ! (USE_MOTIF || USE_X_TOOLKIT).
290 (x_mouse_leave): Remove; unused.
291 * xterm.h (x_display_info_for_name, x_raise_frame, x_lower_frame):
292 (x_destroy_window, x_wm_set_window_state, x_wm_set_icon_pixmap):
293 (x_delete_display, x_initialize, x_set_border_pixel, x_screen_planes):
295 (x_mouse_leave): Declare only if WINDOWSNT.
296 (x_dispatch_event): Declare only if USE_MOTIF or USE_X_TOOLKIT.
297 (xic_create_fontsetname): Declare only if HAVE_X_WINDOWS &&
300 * ftxfont.c: Make symbols static if they're not exported.
301 (ftxfont_driver): Export only if !defined HAVE_XFT && def8ined
303 * font.h (ftxfont_driver): Likewise.
305 * xfns.c: Make symbols static if they're not exported.
306 (x_last_font_name, x_display_info_for_name):
307 (x_set_foreground_color, x_set_background_color, x_set_mouse_color):
308 (x_set_cursor_color, x_set_border_pixel, x_set_border_color):
309 (x_set_cursor_type, x_set_icon_type, x_set_icon_name):
310 (x_set_scroll_bar_foreground, x_set_scroll_bar_background):
311 (x_explicitly_set_name, x_set_title, xic_defaut_fontset, tip_timer):
312 (last_show_tip_args): Now static.
313 (xic_defaut_fontset, xic_create_fontsetname): Define only if
314 defined HAVE_X_WINDOWS && defined USE_X_TOOLKIT
315 (x_screen_planes): Remove; unused.
316 * dispextern.h (x_screen_planes): Remove decl.
318 * dispnew.c: Make symbols static if they're not exported.
319 * dispextern.h (redraw_garbaged_frames, scrolling):
320 (increment_row_positions): Remove.
321 * dispnew.c (new_glyph_matrix, increment_row_positions, scrolling):
322 (delayed_size_change, glyph_matrix_count, glyph_pool_count):
324 (redraw_garbaged_frames): Remove; unused.
326 * xfaces.c: Make symbols static if they're not exported.
327 * dispextern.h (ascii_face_of_lisp_face, free_realized_face):
329 * xterm.h (defined_color): Remove decls.
330 (x_free_dpy_colors): Declare only if USE_X_TOOLKIT.
331 * xfaces.c (tty_suppress_bold_inverse_default_colors_p):
332 (menu_face_changed_default, defined_color, free_realized_face):
333 (x_free_dpy_colors): Define only if USE_X_TOOLKIT.
334 (ascii_face_of_lisp_face): Remove; unused.
336 * xdisp.c: Make symbols static if they're not exported.
337 * dispextern.h (scratch_glyph_row, window_box_edges):
338 (glyph_to_pixel_coords, set_cursor_from_row):
339 (get_next_display_element, set_iterator_to_next):
340 (highlight_trailing_whitespace, frame_to_window_pixel_xy):
341 (show_mouse_face): Remove decls
342 * frame.h (message_buf_print): Likewise.
343 * lisp.h (pop_message, set_message, check_point_in_composition):
345 * xterm.h (set_vertical_scroll_bar): Likewise.
346 * xdisp.c (list_of_error, Vmessage_stack, line_number_displayed):
347 (message_buf_print, scratch_glyph_row, displayed_buffer):
348 (set_iterator_to_next, pop_message, set_message, set_cursor_from_row):
349 (get_next_display_element, show_mouse_face, window_box_edges):
350 (frame_to_window_pixel_xy, check_point_in_composition):
351 (set_vertical_scroll_bar, highlight_trailing_whitespace): Now static.
352 (glyph_to_pixel_coords): Remove; unused.
354 * dired.c (file_name_completion): Now static.
356 * dbusbind.c (xd_in_read_queued_messages): Now static.
358 * lisp.h (circular_list_error, FOREACH): Remove; unused.
359 * data.c (circular_list_error): Remove.
361 * commands.h (last_point_position, last_point_position_buffer):
362 (last_point_position_window): Remove decls.
363 * keyboard.c: Make these variables static.
365 * coding.h (coding, code_convert_region, encode_coding_gap): Remove
367 * coding.c (Vsjis_coding_system, Vbig5_coding_system):
368 (iso_code_class, detect_coding, code_convert_region): Now static.
369 (encode_coding_gap): Remove; unused.
371 * chartab.c (chartab_chars, chartab_bits): Now static.
373 * charset.h (charset_iso_8859_1): Remove decl.
374 * charset.c (charset_iso_8859_1, charset_emacs, map_charset_for_dump):
377 * ccl.h (check_ccl_update, Vccl_program_table): Remove decls.
378 * ccl.c (Vccl_program_table): Now static.
379 (check_ccl_update): Remove; unused.
381 * category.c (SET_CATEGORY_SET, set_category_set): Move here.
382 * category.h: ... from here.
383 * category.c (check_category_table, set_category_set): Now static.
385 * casetab.c (Vascii_upcase_table, Vascii_eqv_table): Now static.
386 * lisp.h: Remove these decls.
388 * buffer.c (buffer_count): Remove unused var.
390 * bidi.c (bidi_dump_cached_states): Mark as externally visible,
391 so that it's not optimized away.
392 (bidi_ignore_explicit_marks_for_paragraph_level): Likewise.
393 * dispextern.h (bidi_dump_cached_states): Remove, since it's
394 exported only to the debugger.
396 * atimer.c (alarm_signal_handler, run_all_atimers): Now static.
397 * atimer.h (run_all_atimers): Removed; not exported.
399 font.c: Make copy_font_spec and merge_font_spec ordinary C functions.
400 * font.c (copy_font_spec): Rename from Fcopy_font_spec, since it
401 was inaccessible from Lisp.
402 (merge_font_spec): Likewise, renaming from Fmerge_font_spec.
403 * font.c, font.h, fontset.c, xfaces.c, xfont.c: Change all uses.
405 alloc.c: Import and export fewer symbols, and remove unused items.
406 * lisp.h (suppress_checking, die): Declare only if ENABLE_CHECKING
408 (suppress_checking): Add EXTERNALLY_VISIBLE attribute, so that
409 it's not optimized away by whole-program optimization.
410 (message_enable_multibyte, free_misc): Remove.
411 (catchlist, handlerlist, mark_backtrace):
412 Declare only if BYTE_MARK_STACK.
413 (mark_byte_stack): Likewise, fixing a ifdef-vs-if typo.
414 * alloc.c (pure): Export only if VIRT_ADDR_VARIES is defined.
415 (message_enable_multibyte): Remove decl.
416 (free_misc, interval_free_list, float_block, float_block_index):
417 (n_float_blocks, float_free_list, cons_block, cons_block_index):
418 (cons_free_list, last_marked_index):
420 (suppress_checking, die): Define only if ENABLE_CHECKING is defined.
421 * eval.c (catchlist, handlerlist): Export only if BYTE_MARK_STACK.
422 (mark_backtrace): Define only if BYTE_MARK_STACK.
423 * xdisp.c (message_enable_multibyte): Now static.
425 Declare Lisp_Object Q* variables to be 'static' if not exproted.
426 This makes it easier for human readers (and static analyzers)
427 to see whether these variables are used from other modules.
428 * alloc.c, buffer.c, bytecode.c, callint.c, casetab.c, category.c:
429 * ccl.c, character.c, charset.c, cmds.c, coding.c, composite.c:
430 * data.c, dbusbind.c, dired.c, editfns.c, eval.c, fileio.c, fns.c:
431 * font.c, frame.c, fringe.c, ftfont.c, image.c, keyboard.c, keymap.c:
432 * lread.c, macros.c, minibuf.c, print.c, process.c, search.c:
433 * sound.c, syntax.c, textprop.c, window.c, xdisp.c, xfaces.c, xfns.c:
434 * xmenu.c, xselect.c:
435 Declare Q* vars static if they are not used in other modules.
436 * ccl.h, character.h, charset.h, coding.h, composite.h, font.h:
437 * frame.h, intervals.h, keyboard.h, lisp.h, process.h, syntax.h:
438 Remove decls of unexported vars.
439 * keyboard.h (EVENT_HEAD_UNMODIFIED): Remove now-unused macro.
441 * lisp.h (DEFINE_FUNC): Make sname 'static'.
443 Make Emacs functions such as Fatom 'static' by default.
444 This makes it easier for human readers (and static analyzers)
445 to see whether these functions can be called from other modules.
446 DEFUN now defines a static function. To make the function external
447 so that it can be used in other C modules, use the new macro DEFUE.
448 * lisp.h (Funibyte_char_to_multibyte, Fsyntax_table_p):
449 (Finit_image_library):
450 (Feval_region, Fbacktrace, Ffetch_bytecode, Fswitch_to_buffer):
451 (Ffile_executable_p, Fmake_symbolic_link, Fcommand_execute):
452 (Fget_process, Fdocumentation_property, Fbyte_code, Ffile_attributes):
453 Remove decls, since these functions are now static.
454 (Funintern, Fget_internal_run_time): New decls, since these functions
455 were already external.
457 * alloc.c, buffer.c, callint.c, callproc.c, casefiddle.c, casetab.c:
458 * ccl.c, character.c, chartab.c, cmds.c, coding.c, data.c, dispnew.c:
459 * doc.c, editfns.c, emacs.c, eval.c, fileio.c, filelock.c, floatfns.c:
460 * fns.c, font.c, fontset.c, frame.c, image.c, indent.c:
461 * keyboard.c, keymap.c, lread.c:
462 * macros.c, marker.c, menu.c, minibuf.c, print.c, process.c, search.c:
463 * syntax.c, term.c, terminal.c, textprop.c, undo.c:
464 * window.c, xdisp.c, xfaces.c, xfns.c, xmenu.c, xsettings.c:
465 Mark functions with DEFUE instead of DEFUN,
466 if they are used in other modules.
467 * buffer.c (Fset_buffer_major_mode, Fdelete_overlay): New forward
468 decls for now-static functions.
469 * buffer.h (Fdelete_overlay): Remove decl.
470 * callproc.c (Fgetenv_internal): Mark as internal.
471 * composite.c (Fremove_list_of_text_properties): Remove decl.
472 (Fcomposition_get_gstring): New forward static decl.
473 * composite.h (Fcomposite_get_gstring): Remove decl.
474 * dired.c (Ffile_attributes): New forward static decl.
475 * doc.c (Fdocumntation_property): New forward static decl.
476 * eval.c (Ffetch_bytecode): New forward static decl.
477 (Funintern): Remove extern decl; now in .h file where it belongs.
478 * fileio.c (Fmake_symbolic_link): New forward static decl.
479 * image.c (Finit_image_library): New forward static decl.
480 * insdel.c (Fcombine_after_change_execute): Make forward decl static.
481 * intervals.h (Fprevious_property_change):
482 (Fremove_list_of_text_properties): Remove decls.
483 * keyboard.c (Fthis_command_keys): Remove decl.
484 (Fcommand_execute): New forward static decl.
485 * keymap.c (Flookup_key): New forward static decl.
486 (Fcopy_keymap): Now static.
487 * keymap.h (Flookup_key): Remove decl.
488 * process.c (Fget_process): New forward static decl.
489 (Fprocess_datagram_address): Mark as internal.
490 * syntax.c (Fsyntax_table_p): New forward static decl.
491 (skip_chars): Remove duplicate decl.
492 * textprop.c (Fprevious_property_change): New forward static decl.
493 * window.c (Fset_window_fringes, Fset_window_scroll_bars):
495 (Fset_window_margins, Fset_window_vscroll): New forward static decls.
496 * window.h (Fset_window_vscroll, Fset_window_margins): Remove decls.
498 * editfns.c (Fformat): Remove unreachable code.
500 2011-04-14 Andreas Schwab <schwab@linux-m68k.org>
502 * fileio.c (Finsert_file_contents): Fix typo in 2005-05-13
505 2011-04-13 Eli Zaretskii <eliz@gnu.org>
507 * xdisp.c (handle_invisible_prop): Don't call bidi_paragraph_init
508 when at ZV. (Bug#8487)
510 2011-04-12 Andreas Schwab <schwab@linux-m68k.org>
512 * charset.c (Fclear_charset_maps): Use xfree instead of free.
514 * keyboard.c (parse_tool_bar_item): Likewise.
515 * sound.c (sound_cleanup, alsa_close): Likewise.
516 * termcap.c (tgetent): Likewise.
517 * xfns.c (x_default_font_parameter): Likewise.
518 * xsettings.c (read_and_apply_settings): Likewise.
520 * alloc.c (overrun_check_malloc, overrun_check_realloc)
521 (overrun_check_free): Protoize.
523 2011-04-12 Paul Eggert <eggert@cs.ucla.edu>
525 * sysdep.c (emacs_read, emacs_write): Check for negative sizes
526 since callers should never pass a negative size.
527 Change the signature to match that of plain 'read' and 'write'; see
528 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00397.html>.
529 * lisp.h: Update prototypes of emacs_write and emacs_read.
531 2011-04-11 Eli Zaretskii <eliz@gnu.org>
533 * xdisp.c (redisplay_window): Don't try to determine the character
534 position of the scroll margin if the window start point w->startp
535 is outside the buffer's accessible region. (Bug#8468)
537 2011-04-10 Eli Zaretskii <eliz@gnu.org>
539 Fix write-region and its subroutines for buffers > 2GB.
540 * fileio.c (a_write, e_write): Modify declaration of arguments and
541 local variables to support buffers larger than 2GB.
542 (Fcopy_file): Use EMACS_INT for return value of emacs_read.
544 * sysdep.c (emacs_write, emacs_read): Use ssize_t for last
545 argument, local variables, and return value.
547 * lisp.h: Update prototypes of emacs_write and emacs_read.
549 * sound.c (vox_write): Use ssize_t for return value of emacs_write.
551 2011-04-10 Paul Eggert <eggert@cs.ucla.edu>
553 * xdisp.c (vmessage): Use memchr, not strnlen, which some hosts lack.
555 Fix more problems found by GCC 4.6.0's static checks.
557 * xdisp.c (vmessage): Use a better test for character truncation.
559 * charset.c (load_charset_map): <, not <=, for optimization,
560 and to avoid potential problems with integer overflow.
561 * chartab.c (sub_char_table_set_range, char_table_set_range): Likewise.
562 * casetab.c (set_identity, shuffle): Likewise.
563 * editfns.c (Fformat): Likewise.
564 * syntax.c (skip_chars): Likewise.
566 * xmenu.c (set_frame_menubar): Allocate smaller local vectors.
567 This also lets GCC 4.6.0 generate slightly better loop code.
569 * callint.c (Fcall_interactively): <, not <=, for optimization.
570 (Fcall_interactively): Count the number of arguments produced,
571 not the number of arguments given. This is simpler and lets GCC
572 4.6.0 generate slightly better code.
574 * ftfont.c: Distingish more carefully between FcChar8 and char.
575 The previous code passed unsigned char * to a functions like
576 strlen and xstrcasecmp that expect char *, which does not
577 conform to the C standard.
578 (get_adstyle_property, ftfont_pattern_entity): Use FcChar8 for
579 arguments to FcPatternGetString, and explicitly cast FcChar8 * to
580 char * when the C standard requires it.
582 * keyboard.c (read_char): Remove unused var.
584 * eval.c: Port to Windows vsnprintf (Bug#8435).
586 (SIZE_MAX): Define if the headers do not.
587 (verror): Do not give up if vsnprintf returns a negative count.
588 Instead, grow the buffer. This ports to Windows vsnprintf, which
589 does not conform to C99. Problem reported by Eli Zaretskii.
590 Also, simplify the allocation scheme, by avoiding the need for
591 calling realloc, and removing the ALLOCATED variable.
593 * eval.c (verror): Initial buffer size is 4000 (not 200) bytes.
595 Remove invocations of doprnt, as Emacs now uses vsnprintf.
596 But keep the doprint source code for now, as we might revamp it
597 and use it again (Bug#8435).
598 * lisp.h (doprnt): Remove.
599 * Makefile.in (base_obj): Remove doprnt.o.
600 * deps.mk (doprnt.o): Remove.
602 error: Print 32- and 64-bit integers portably (Bug#8435).
603 Without this change, on typical 64-bit hosts error ("...%d...", N)
604 was used to print both 32- and 64-bit integers N, which relied on
606 * lisp.h, src/m/amdx86-64.h, src/m/ia64.h, src/m/ibms390x.h (pEd):
608 * lisp.h (error, verror): Mark as printf-like functions.
609 * eval.c (verror): Use vsnprintf, not doprnt, to do the real work.
610 Report overflow in size calculations when allocating printf buffer.
611 Do not truncate output string at its first null byte.
612 * xdisp.c (vmessage): Use vsnprintf, not doprnt, to do the real work.
613 Truncate the output at a character boundary, since vsnprintf does not
615 * charset.c (check_iso_charset_parameter): Convert internal
616 character to string before calling 'error', since %c now has the
618 * coding.c (Fdecode_sjis_char, Fdecode_big5_char): Avoid int
619 overflow when computing char to be passed to 'error'. Do not
620 pass Lisp_Object to 'error'; pass the integer instead.
621 * nsfns.m (Fns_do_applescript): Use int, not long, since it's
622 formatted with plain %d.
624 * eval.c (internal_lisp_condition_case): Don't pass spurious arg.
626 * keyboard.c (access_keymap_keyremap): Print func name, not garbage.
628 * coding.c (Fdecode_sjis_char): Don't assume CODE fits in int.
630 * xterm.c (x_catch_errors): Remove duplicate declaration.
632 * term.c (maybe_fatal): Mark its 3rd arg as a printf format, too.
634 * xdisp.c, lisp.h (message_nolog): Remove; unused.
636 2011-04-10 Jim Meyering <meyering@redhat.com>
638 use ssize_t and size_t for read- and write-like emacs_gnutls_* functions
639 * gnutls.c (emacs_gnutls_read): Adjust signature to be more read-like:
640 return ssize_t not "int", and use size_t as the buffer length.
641 (emacs_gnutls_write): Likewise, and make the buffer pointer "const".
642 * gnutls.h: Update declarations.
643 * process.c (read_process_output): Use ssize_t, to match.
644 (send_process): Likewise.
646 2011-04-09 Chong Yidong <cyd@stupidchicken.com>
648 * image.c (Fimagemagick_types): Doc fix, and comment cleanup.
650 2011-04-09 Chong Yidong <cyd@stupidchicken.com>
652 * ftfont.c (get_adstyle_property, ftfont_pattern_entity): Use
653 unsigned char, to match FcChar8 type definition.
655 * xterm.c (handle_one_xevent):
656 * xmenu.c (create_and_show_popup_menu):
657 * xselect.c (x_decline_selection_request)
658 (x_reply_selection_request): Avoid type-punned deref of X events.
660 2011-04-09 Eli Zaretskii <eliz@gnu.org>
662 Fix some uses of `int' instead of EMACS_INT.
663 * search.c (string_match_1, fast_string_match)
664 (fast_c_string_match_ignore_case, fast_string_match_ignore_case)
665 (scan_buffer, find_next_newline_no_quit)
666 (find_before_next_newline, search_command, Freplace_match)
667 (Fmatch_data): Make some `int' variables be EMACS_INT.
669 * xdisp.c (display_count_lines): 3rd argument and return value now
670 EMACS_INT. All callers changed.
671 (pint2hrstr): Last argument is now EMACS_INT.
673 * coding.c (detect_coding_utf_8, detect_coding_emacs_mule)
674 (detect_coding_iso_2022, detect_coding_sjis, detect_coding_big5)
675 (detect_coding_ccl, detect_coding_charset, decode_coding_utf_8)
676 (decode_coding_utf_16, decode_coding_emacs_mule)
677 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5)
678 (decode_coding_ccl, decode_coding_charset)
679 <consumed_chars, consumed_chars_base>: Declare EMACS_INT.
680 (decode_coding_iso_2022, decode_coding_emacs_mule)
681 (decode_coding_sjis, decode_coding_big5, decode_coding_charset)
682 <char_offset, last_offset>: Declare EMACS_INT.
683 (encode_coding_utf_8, encode_coding_utf_16)
684 (encode_coding_emacs_mule, encode_invocation_designation)
685 (encode_designation_at_bol, encode_coding_iso_2022)
686 (encode_coding_sjis, encode_coding_big5, encode_coding_ccl)
687 (encode_coding_raw_text, encode_coding_charset) <produced_chars>:
689 (ASSURE_DESTINATION): Declare more_bytes EMACS_INT.
690 (encode_invocation_designation): Last argument P_NCHARS is now
692 (decode_eol): Declare pos_byte, pos, and pos_end EMACS_INT.
693 (produce_chars): from_nchars and to_nchars are now EMACS_INT.
695 * coding.h (struct coding_system) <head_ascii>: Declare EMACS_INT.
698 * ccl.c (Fccl_execute_on_string): Declare some variables
701 2011-04-08 Samuel Thibault <sthibault@debian.org> (tiny change)
703 * term.c (init_tty): Fix incorrect ifdef placement (Bug#8450).
705 2011-03-19 Christoph Scholtes <cschol2112@googlemail.com>
707 * process.c (Fformat_network_address): Doc fix.
709 2011-04-08 T.V. Raman <tv.raman.tv@gmail.com> (tiny change)
711 * xml.c (parse_region): Avoid creating spurious whiespace nodes.
713 2011-04-08 Chong Yidong <cyd@stupidchicken.com>
715 * keyboard.c (read_char): Call Lisp function help-form-show,
716 instead of using internal_with_output_to_temp_buffer.
717 (Qhelp_form_show): New var.
718 (syms_of_keyboard): Use DEFSYM macro.
720 * print.c (internal_with_output_to_temp_buffer): Function deleted.
722 * lisp.h (internal_with_output_to_temp_buffer): Remove prototype.
724 2011-04-06 Chong Yidong <cyd@stupidchicken.com>
726 * process.c (Flist_processes): Removed to Lisp.
727 (list_processes_1): Deleted.
729 2011-04-06 Eli Zaretskii <eliz@gnu.org>
731 * msdos.c (careadlinkat, careadlinkatcwd): MS-DOS replacements.
733 * w32.c (careadlinkat, careadlinkatcwd): New always-fail stubs.
735 2011-04-06 Paul Eggert <eggert@cs.ucla.edu>
737 Fix more problems found by GCC 4.6.0's static checks.
739 * xmenu.c (Fx_popup_dialog): Don't assume string is free of formats.
741 * menu.c (Fx_popup_menu): Don't assume error_name lacks printf formats.
743 * lisp.h (message, message_nolog, fatal): Mark as printf-like.
745 * xdisp.c (vmessage): Mark as a printf-like function.
747 * term.c (vfatal, maybe_fatal): Mark as printf-like functions.
749 * sound.c (sound_warning): Don't crash if arg contains a printf format.
751 * image.c (tiff_error_handler, tiff_warning_handler): Mark as
752 printf-like functions.
753 (tiff_load): Add casts to remove these marks before passing them
754 to system-supplied API.
756 * eval.c (Fsignal): Remove excess argument to 'fatal'.
758 * coding.c (EMIT_ONE_BYTE, EMIT_TWO_BYTES): Use unsigned, not int.
759 This avoids several warnings with gcc -Wstrict-overflow.
760 (DECODE_COMPOSITION_RULE): If the rule is invalid, goto invalid_code
761 directly, rather than having caller test rule sign. This avoids
762 some unnecessary tests.
763 * composite.h (COMPOSITION_ENCODE_RULE_VALID): New macro.
764 (COMPOSITION_ENCODE_RULE): Arguments now must be valid. This
765 affects only one use, in DECODE_COMPOSITION_RULE, which is changed.
767 * xfont.c (xfont_text_extents): Remove var that was set but not used.
768 (xfont_open): Avoid unnecessary tests.
770 * composite.c (composition_gstring_put_cache): Use unsigned integer.
772 * composite.h, composite.c (composition_gstring_put_cache):
773 Use EMACS_INT, not int, for length.
775 * composite.h (COMPOSITION_DECODE_REFS): New macro,
776 breaking out part of COMPOSITION_DECODE_RULE.
777 (COMPOSITION_DECODE_RULE): Use it.
778 * composite.c (get_composition_id): Remove unused local vars,
779 by using the new macro.
781 * textprop.c (set_text_properties_1): Change while to do-while,
782 since the condition is always true at first.
784 * intervals.c (graft_intervals_into_buffer): Mark var as used.
785 (interval_deletion_adjustment): Return unsigned value.
788 * process.c (list_processes_1, create_pty, read_process_output):
789 (exec_sentinel): Remove vars that were set but not used.
790 (create_pty): Remove unnecessary "volatile"s.
791 (Fnetwork_interface_info): Avoid possibility of int overflow.
792 (read_process_output): Do adaptive read buffering even if carryover.
793 (read_process_output): Simplify nbytes computation if buffered.
795 * bytecode.c (exec_byte_code): Rename local to avoid shadowing.
797 * syntax.c (scan_words): Remove var that was set but not used.
798 (update_syntax_table): Use unsigned instead of int.
800 * lread.c (lisp_file_lexically_bound_p): Use ints rather than endptrs.
801 (lisp_file_lexically_bound_p, read1): Use unsigned instead of int.
802 (safe_to_load_p): Make the end-of-loop test the inverse of the in-loop.
804 * print.c (print_error_message): Avoid int overflow.
806 * font.c (font_list_entities): Redo for clarity,
807 so that reader need not know FONT_DPI_INDEX + 1 == FONT_SPACING_INDEX.
809 * font.c (font_find_for_lface, Ffont_get_glyphs): Remove unused vars.
810 (font_score): Avoid potential overflow in diff calculation.
812 * fns.c (substring_both): Remove var that is set but not used.
813 (sxhash): Redo loop for clarity and to avoid wraparound warning.
815 * eval.c (funcall_lambda): Rename local to avoid shadowing.
817 * alloc.c (mark_object_loop_halt, mark_object): Use size_t, not int.
818 Otherwise, GCC 4.6.0 optimizes the loop check away since the check
819 can always succeed if overflow has undefined behavior.
821 * search.c (boyer_moore, wordify): Remove vars set but not used.
822 (wordify): Omit three unnecessary tests.
824 * indent.c (MULTIBYTE_BYTES_WIDTH): Don't compute wide_column.
825 All callers changed. This avoids the need for an unused var.
827 * casefiddle.c (casify_region): Remove var that is set but not used.
829 * dired.c (file_name_completion): Remove var that is set but not used.
831 * fileio.c (Finsert_file_contents): Make EOF condition clearer.
833 * fileio.c (Finsert_file_contents): Avoid signed integer overflow.
834 (Finsert_file_contents): Remove unnecessary code checking fd.
836 * minibuf.c (read_minibuf_noninteractive): Use size_t for sizes.
837 Check for integer overflow on size calculations.
839 * buffer.c (Fprevious_overlay_change): Remove var that is set
842 * keyboard.c (menu_bar_items, read_char_minibuf_menu_prompt):
843 Remove vars that are set but not used.
844 (timer_check_2): Don't assume timer-list and idle-timer-list are lists.
845 (timer_check_2): Mark vars as initialized.
847 * gtkutil.c (xg_get_file_with_chooser): Mark var as initialized.
849 * image.c (lookup_image): Remove var that is set but not used.
850 (xbm_load): Use parse_p, for gcc -Werror=unused-but-set-variable.
852 * fontset.c (Finternal_char_font, Ffontset_info): Remove vars
853 that are set but not used.
855 * xfns.c (make_invisible_cursor): Don't return garbage
856 if XCreateBitmapFromData fails (Bug#8410).
858 * xselect.c (x_get_local_selection, x_handle_property_notify):
859 Remove vars that are set but not used.
861 * xfns.c (x_create_tip_frame): Remove var that is set but not used.
862 (make_invisible_cursor): Initialize a possibly-uninitialized variable.
864 * xterm.c (x_scroll_bar_to_input_event) [!USE_GTK]:
865 Remove var that is set but not used.
866 (scroll_bar_windows_size): Now size_t, not int.
867 (x_send_scroll_bar_event): Use size_t, not int, for sizes.
870 * xfaces.c (realize_named_face): Remove vars that are set but not used.
871 (map_tty_color) [!defined MSDOS]: Likewise.
873 * term.c (tty_write_glyphs): Use size_t; this avoids overflow warning.
875 * coding.c: Remove vars that are set but not used.
876 (DECODE_COMPOSITION_RULE): Remove 2nd arg, which is unused.
878 (decode_coding_utf_8, decode_coding_utf_16 decode_coding_emacs_mule):
879 (decode_coding_iso_2022, encode_coding_sjis, encode_coding_big5):
880 (decode_coding_charset): Remove vars that are set but not used.
882 * bytecode.c (Fbyte_code) [!defined BYTE_CODE_SAFE]: Remove var
883 that is set but not used.
885 * print.c (print_object): Remove var that is set but not used.
887 Replace 2 copies of readlink code with 1 gnulib version (Bug#8401).
888 The gnulib version avoids calling malloc in the usual case,
889 and on 64-bit hosts doesn't have some arbitrary 32-bit limits.
890 * fileio.c (Ffile_symlink_p): Use emacs_readlink.
891 * filelock.c (current_lock_owner): Likewise.
892 * lisp.h (READLINK_BUFSIZE, emacs_readlink): New function.
893 * sysdep.c: Include allocator.h, careadlinkat.h.
894 (emacs_no_realloc_allocator): New static constant.
895 (emacs_readlink): New function.
896 * deps.mk (sysdep.o): Depend on ../lib/allocator.h and on
897 ../lib/careadlinkat.h.
899 2011-04-04 Stefan Monnier <monnier@iro.umontreal.ca>
901 * keyboard.c (safe_run_hook_funcall): Fix last change (don't stop at the
902 first non-nil return value).
904 2011-04-03 Jan Djärv <jan.h.d@swipnet.se>
906 * nsterm.m (ns_update_auto_hide_menu_bar): Define MAC_OS_X_VERSION_10_6
907 if not defined (Bug#8403).
909 2011-04-02 Juanma Barranquero <lekktu@gmail.com>
911 * xdisp.c (display_count_lines): Remove parameter `start',
912 unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
913 (get_char_face_and_encoding): Remove parameter `multibyte_p',
914 unused since 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
915 (fill_stretch_glyph_string): Remove parameters `row' and `area',
916 unused at least since Kim's GUI unification at 2003-03-16T20:45:46Z!storm@cua.dk
917 and thereabouts. All callers changed.
918 (get_per_char_metric): Remove parameter `f', unused since
919 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
921 2011-04-02 Jim Meyering <meyering@redhat.com>
923 do not dereference NULL upon failed strdup
924 * nsfont.m (ns_descriptor_to_entity): Use xstrdup, not strdup.
925 (ns_get_family): Likewise.
927 2011-04-02 Juanma Barranquero <lekktu@gmail.com>
929 * eval.c (unwind_to_catch) [DEBUG_GCPRO]: Remove redundant assignment.
931 2011-04-02 Jan Djärv <jan.h.d@swipnet.se>
933 * nsterm.m (ns_update_auto_hide_menu_bar): Only for OSX 10.6 or
936 2011-04-01 Stefan Monnier <monnier@iro.umontreal.ca>
940 * window.c (Ftemp_output_buffer_show): New fun.
941 (Fsave_window_excursion):
942 * print.c (Fwith_output_to_temp_buffer): Move to subr.el.
944 * lread.c (lisp_file_lexically_bound_p): New function.
945 (Fload): Bind Qlexical_binding.
946 (readevalloop): Remove `evalfun' arg.
947 Bind Qinternal_interpreter_environment.
948 (Feval_buffer): Bind Qlexical_binding.
949 (defvar_int, defvar_bool, defvar_lisp_nopro, defvar_kboard):
951 (syms_of_lread): Declare `lexical-binding'.
953 * lisp.h (struct Lisp_Symbol): New field `declared_special'.
955 * keyboard.c (eval_dyn): New fun.
956 (menu_item_eval_property): Use it.
958 * image.c (parse_image_spec): Use Ffunctionp.
960 * fns.c (concat, mapcar1): Accept byte-code-functions.
962 * eval.c (Fsetq): Handle lexical vars.
963 (Fdefun, Fdefmacro, Ffunction): Make closures when needed.
964 (Fdefconst, Fdefvaralias, Fdefvar): Mark as dynamic.
965 (FletX, Flet): Obey lexical binding.
966 (Fcommandp): Handle closures.
967 (Feval): New `lexical' arg.
968 (eval_sub): New function extracted from Feval. Use it almost
969 everywhere where Feval was used. Look up vars in lexical env.
971 (Ffunctionp): Move from subr.el.
972 (Ffuncall): Handle closures.
973 (apply_lambda): Remove `eval_flags'.
974 (funcall_lambda): Handle closures and new byte-code-functions.
975 (Fspecial_variable_p): New function.
976 (syms_of_eval): Initialize the Vinternal_interpreter_environment var,
977 but without exporting it to Lisp.
979 * doc.c (Fdocumentation, store_function_docstring):
980 * data.c (Finteractive_form): Handle closures.
982 * callint.c (Fcall_interactively): Preserve lexical-binding mode for
985 * bytecode.c (Bstack_ref, Bstack_set, Bstack_set2, BdiscardN): New
987 (exec_byte_code): New function extracted from Fbyte_code to handle new
988 calling convention for byte-code-functions. Add new byte-codes.
990 * buffer.c (defvar_per_buffer): Set new `declared_special' field.
992 * alloc.c (Fmake_symbol): Init new `declared_special' field.
994 2011-03-31 Juanma Barranquero <lekktu@gmail.com>
996 * xdisp.c (redisplay_internal): Fix prototype.
998 2011-03-31 Eli Zaretskii <eliz@gnu.org>
1000 * xdisp.c (SCROLL_LIMIT): New macro.
1001 (try_scrolling): Use it when setting scroll_limit. Limit
1002 scrolling to 100 screen lines.
1003 (redisplay_window): Even when falling back on "recentering",
1004 position point in the window according to scroll-conservatively,
1005 scroll-margin, and scroll-*-aggressively variables. (Bug#6671)
1007 (try_scrolling): When point is above the window, allow searching
1008 as far as scroll_max, or one screenful, to compute vertical
1009 distance from PT to the scroll margin position. This prevents
1010 try_scrolling from unnecessarily failing when
1011 scroll-conservatively is set to a value slightly larger than the
1012 window height. Clean up the case of PT below the margin at bottom
1013 of window: scroll_max can no longer be INT_MAX. When aggressive
1014 scrolling is in use, don't let point enter the opposite scroll
1015 margin as result of the scroll.
1016 (syms_of_xdisp) <scroll-conservatively>: Document the
1017 threshold of 100 lines for never-recentering scrolling.
1019 2011-03-31 Juanma Barranquero <lekktu@gmail.com>
1021 * dispextern.h (move_it_by_lines):
1022 * xdisp.c (move_it_by_lines): Remove parameter `need_y_p', unused
1023 since 2000-12-29T14:24:09Z!gerd@gnu.org. All callers changed.
1024 (message_log_check_duplicate): Remove parameters `prev_bol' and
1025 `this_bol', unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
1026 (redisplay_internal): Remove parameter `preserve_echo_area',
1027 unused since 1999-07-21T21:43:52Z!gerd@gnu.org. All callers changed.
1029 * indent.c (Fvertical_motion):
1030 * window.c (window_scroll_pixel_based, Frecenter):
1031 Don't pass `need_y_p' to `move_it_by_lines'.
1033 2011-03-30 Stefan Monnier <monnier@iro.umontreal.ca>
1035 * eval.c (struct backtrace): Don't cheat with negative numbers, but do
1036 steal a few bits to be more compact.
1037 (interactive_p, Fbacktrace, Fbacktrace_frame, mark_backtrace):
1038 Remove unneeded casts.
1040 * bytecode.c (Fbyte_code): CAR and CDR can GC.
1042 2011-03-30 Zachary Kanfer <zkanfer@gmail.com> (tiny change)
1044 * keyboard.c (Fexecute_extended_command): Do log the "suggest key
1045 binding" message (bug#7967).
1047 2011-03-30 Paul Eggert <eggert@cs.ucla.edu>
1049 Fix more problems found by GCC 4.6.0's static checks.
1051 * unexelf.c (unexec) [! (defined _SYSTYPE_SYSV || defined __sgi)]:
1052 Remove unused local var.
1054 * editfns.c (Fmessage_box): Remove unused local var.
1056 * xdisp.c (try_window_reusing_current_matrix, x_produce_glyphs):
1057 (note_mode_line_or_margin_highlight, note_mouse_highlight):
1058 Omit unused local vars.
1059 * window.c (shrink_windows): Omit unused local var.
1060 * menu.c (digest_single_submenu): Omit unused local var.
1061 * dispnew.c (update_window) [PERIODIC_PREEMPTION_CHECKING]:
1062 Omit unused local var.
1064 * keyboard.c (parse_modifiers_uncached, parse_modifiers):
1065 Don't assume string length fits in int.
1066 (keyremap_step, read_key_sequence): Use size_t for sizes.
1067 (read_key_sequence): Don't check last_real_key_start redundantly.
1069 * callproc.c (Fcall_process, Fcall_process_region): Use SAFE_ALLOCA
1070 instead of alloca (Bug#8344).
1072 * eval.c (Fbacktrace): Don't assume nargs fits in int.
1073 (Fbacktrace_frame): Don't assume nframes fits in int.
1075 * syntax.c (scan_sexps_forward): Avoid pointer wraparound.
1077 * xterm.c (x_make_frame_visible, same_x_server): Redo to avoid overflow
1080 * term.c (produce_glyphless_glyph): Remove unnecessary test.
1082 * cm.c (calccost): Turn while-do into do-while, for clarity.
1084 * keyboard.c (syms_of_keyboard): Use the same style as later
1085 in this function when indexing through an array. This also
1086 works around GCC bug 48267.
1088 * image.c (tiff_load): Fix off-by-one image count (Bug#8336).
1090 * xselect.c (x_check_property_data): Return correct size (Bug#8335).
1092 * chartab.c (sub_char_table_ref_and_range): Redo for slight
1093 efficiency gain, and to bypass a gcc -Wstrict-overflow warning.
1095 * keyboard.c, keyboard.h (num_input_events): Now size_t.
1096 This avoids undefined behavior on integer overflow, and is a bit
1097 more convenient anyway since it is compared to a size_t variable.
1099 Variadic C functions now count arguments with size_t, not int.
1100 This avoids an unnecessary limitation on 64-bit machines, which
1101 caused (substring ...) to crash on large vectors (Bug#8344).
1102 * lisp.h (struct Lisp_Subr.function.aMANY): Now takes size_t, not int.
1103 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call): Likewise.
1104 All variadic functions and their callers changed accordingly.
1105 (struct gcpro.nvars): Now size_t, not int. All uses changed.
1106 * data.c (arith_driver, float_arith_driver): Likewise.
1107 * editfns.c (general_insert_function): Likewise.
1108 * eval.c (struct backtrace.nargs, interactive_p)
1109 (internal_condition_case_n, run_hook_with_args, apply_lambda)
1110 (funcall_lambda, mark_backtrace): Likewise.
1111 * fns.c (concat): Likewise.
1112 * frame.c (x_set_frame_parameters): Likewise.
1113 * fns.c (get_key_arg): Now accepts and returns size_t, and returns
1114 0 if not found, not -1. All callers changed.
1116 * alloc.c (garbage_collect): Don't assume stack size fits in int.
1117 (stack_copy_size): Now size_t, not int.
1118 (stack_copy, stack_copy_size): Define only if MAX_SAVE_STACK > 0.
1120 2011-03-28 Juanma Barranquero <lekktu@gmail.com>
1122 * coding.c (encode_designation_at_bol): Remove parameter `charbuf_end',
1123 unused since 2002-03-01T01:17:24Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
1124 All callers changed.
1126 * lisp.h (multibyte_char_to_unibyte):
1127 * character.c (multibyte_char_to_unibyte): Remove parameter `rev_tbl',
1128 unused since 2002-03-01T01:16:34Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
1129 * character.h (CHAR_TO_BYTE8):
1130 * cmds.c (internal_self_insert):
1131 * editfns.c (general_insert_function):
1132 * keymap.c (push_key_description):
1133 * search.c (Freplace_match):
1134 * xdisp.c (message_dolog, set_message_1): All callers changed.
1136 2011-03-28 Stefan Monnier <monnier@iro.umontreal.ca>
1138 * keyboard.c (safe_run_hook_funcall): New function.
1139 (safe_run_hooks_1, safe_run_hooks_error, safe_run_hooks): On error,
1140 don't set the hook to nil, but remove the offending function instead.
1141 (Qcommand_hook_internal): Remove, unused.
1142 (syms_of_keyboard): Don't initialize Qcommand_hook_internal nor define
1143 Vcommand_hook_internal.
1145 * eval.c (enum run_hooks_condition): Remove.
1146 (funcall_nil, funcall_not): New functions.
1147 (run_hook_with_args): Call each function through a `funcall' argument.
1148 Remove `cond' argument, now redundant.
1149 (Frun_hooks, Frun_hook_with_args, Frun_hook_with_args_until_success)
1150 (Frun_hook_with_args_until_failure): Adjust accordingly.
1151 (run_hook_wrapped_funcall, Frun_hook_wrapped): New functions.
1153 2011-03-28 Juanma Barranquero <lekktu@gmail.com>
1155 * dispextern.h (string_buffer_position): Remove declaration.
1157 * print.c (strout): Remove parameter `multibyte', unused since
1158 1999-08-21T19:30:21Z!gerd@gnu.org. All callers changed.
1160 * search.c (boyer_moore): Remove parameters `len', `pos' and `lim',
1161 never used since function introduction in 1998-02-08T21:33:56Z!rms@gnu.org.
1162 All callers changed.
1164 * w32.c (_wsa_errlist): Use braces for struct initializers.
1166 * xdisp.c (string_buffer_position_lim): Remove parameter `w',
1167 never used since function introduction in 2001-03-09T18:41:50Z!gerd@gnu.org.
1168 All callers changed.
1169 (string_buffer_position): Likewise. Also, make static (it's never
1170 used outside xdisp.c).
1171 (cursor_row_p): Remove parameter `w', unused since
1172 2000-10-17T16:08:57Z!gerd@gnu.org. All callers changed.
1173 (decode_mode_spec): Remove parameter `precision', introduced during
1174 Gerd Moellmann's rewrite at 1999-07-21T21:43:52Z!gerd@gnu.org, but never used.
1175 All callers changed.
1177 2011-03-27 Jan Djärv <jan.h.d@swipnet.se>
1179 * nsterm.m (syms_of_nsterm): Use doc: for ns-auto-hide-menu-bar.
1181 2011-03-27 Anders Lindgren <andlind@gmail.com>
1183 * nsterm.m (ns_menu_bar_is_hidden): New variable.
1184 (ns_constrain_all_frames, ns_menu_bar_should_be_hidden)
1185 (ns_update_auto_hide_menu_bar): New functions.
1186 (ns_update_begin): Call ns_update_auto_hide_menu_bar.
1187 (applicationDidBecomeActive): Call ns_update_auto_hide_menu_bar and
1188 ns_constrain_all_frames.
1189 (constrainFrameRect): Return at once if ns_menu_bar_should_be_hidden.
1190 (syms_of_nsterm): DEFVAR ns-auto-hide-menu-bar, init to Qnil.
1192 2011-03-27 Jan Djärv <jan.h.d@swipnet.se>
1194 * nsmenu.m (runDialogAt): Remove argument to timer_check.
1196 2011-03-27 Glenn Morris <rgm@gnu.org>
1198 * syssignal.h: Replace RETSIGTYPE with void.
1199 * atimer.c, data.c, dispnew.c, emacs.c, floatfns.c, keyboard.c:
1200 * keyboard.h, lisp.h, process.c, sysdep.c, xterm.c:
1201 Replace SIGTYPE with void everywhere.
1202 * s/usg5-4-common.h (SIGTYPE): Remove definition.
1203 * s/template.h (SIGTYPE): Remove commented out definition.
1205 2011-03-26 Eli Zaretskii <eliz@gnu.org>
1207 * xdisp.c (redisplay_window): Don't check buffer's clip_changed
1208 flag as a prerequisite for invoking try_scrolling. (Bug#6671)
1210 2011-03-26 Juanma Barranquero <lekktu@gmail.com>
1212 * w32.c (read_unc_volume): Use parameter `henum', instead of
1213 global variable `wget_enum_handle'.
1215 * keymap.c (describe_vector): Remove parameters `indices' and
1216 `char_table_depth', unused since 2002-03-01T01:43:26Z!handa@m17n.org.
1217 (describe_map, Fdescribe_vector): Adjust calls to `describe_vector'.
1219 * keyboard.h (timer_check, show_help_echo): Remove unused parameters.
1221 * keyboard.c (timer_check): Remove parameter `do_it_now',
1222 unused since 1996-04-12T06:01:29Z!rms@gnu.org.
1223 (show_help_echo): Remove parameter `ok_to_overwrite_keystroke_echo',
1224 unused since 2008-04-19T19:30:53Z!monnier@iro.umontreal.ca.
1226 * keyboard.c (read_char):
1227 * w32menu.c (w32_menu_display_help):
1228 * xmenu.c (show_help_event, menu_help_callback):
1229 Adjust calls to `show_help_echo'.
1231 * gtkutil.c (xg_maybe_add_timer):
1232 * keyboard.c (readable_events):
1233 * process.c (wait_reading_process_output):
1234 * xmenu.c (x_menu_wait_for_event): Adjust calls to `timer_check'.
1236 * insdel.c (adjust_markers_gap_motion):
1237 Remove; no-op since 1998-01-02T21:29:48Z!rms@gnu.org.
1238 (gap_left, gap_right): Don't call it.
1240 2011-03-25 Chong Yidong <cyd@stupidchicken.com>
1242 * xdisp.c (handle_fontified_prop): Discard changes to clip_changed
1243 incurred during fontification.
1245 2011-03-25 Juanma Barranquero <lekktu@gmail.com>
1247 * buffer.c (defvar_per_buffer): Remove unused parameter `doc'.
1248 (DEFVAR_PER_BUFFER): Don't pass it.
1250 * dispnew.c (row_equal_p, add_row_entry): Remove unused parameter `w'.
1251 (scrolling_window): Don't pass it.
1253 2011-03-25 Juanma Barranquero <lekktu@gmail.com>
1255 * dispextern.h (glyph_matric): Use #if GLYPH_DEBUG, not #ifdef.
1257 * fileio.c (check_executable) [DOS_NT]: Remove unused variables `len'
1259 (Fset_file_selinux_context) [HAVE_LIBSELINUX]: Move here declaration
1260 of variables specific to SELinux and computation of `encoded_absname'.
1262 * image.c (XPutPixel): Remove unused variable `height'.
1264 * keyboard.c (make_lispy_event): Remove unused variable `hpos'.
1266 * unexw32.c (get_section_info): Remove unused variable `section'.
1268 * w32.c (stat): Remove unused variables `drive_root' and `devtype'.
1269 (system_process_attributes): Remove unused variable `sess'.
1270 (sys_read): Remove unused variable `err'.
1272 * w32fns.c (top): Wrap variables with #if GLYPH_DEBUG, not #ifdef.
1273 (w32_wnd_proc): Remove unused variable `isdead'.
1274 (unwind_create_frame): Use #if GLYPH_DEBUG, not #ifdef.
1275 (Fx_server_max_request_size): Remove unused variable `dpyinfo'.
1276 (x_create_tip_frame): Remove unused variable `tem'.
1278 * w32inevt.c (w32_console_read_socket):
1279 Remove unused variable `no_events'.
1281 * w32term.c (x_draw_composite_glyph_string_foreground):
1282 Remove unused variable `width'.
1284 2011-03-24 Juanma Barranquero <lekktu@gmail.com>
1286 * w32term.c (x_set_glyph_string_clipping):
1287 Don't pass uninitialized region to CombineRgn.
1289 2011-03-23 Juanma Barranquero <lekktu@gmail.com>
1291 * w32fns.c (x_set_menu_bar_lines): Remove unused variable `olines'.
1292 (w32_wnd_proc): Pass NULL to Windows API, not uninitialized buffer.
1293 (Fx_close_connection): Remove unused variable `i'.
1295 * w32font.c (w32font_draw): Return number of glyphs.
1296 (w32font_open_internal): Remove unused variable `i'.
1297 (w32font_driver): Add missing initializer.
1299 * w32menu.c (utf8to16): Remove unused variable `utf16'.
1300 (fill_in_menu): Remove unused variable `items_added'.
1302 * w32term.c (last_mouse_press_frame): Remove static global variable.
1303 (w32_clip_to_row): Remove unused variable `f'.
1304 (x_delete_terminal): Remove unused variable `i'.
1306 * w32uniscribe.c (uniscribe_shape): Remove unused variable `nclusters'.
1307 (NOTHING): Remove unused static global variable.
1308 (uniscribe_check_otf): Remove unused variable `table'.
1309 (uniscribe_font_driver): Add missing initializers.
1311 2011-03-23 Julien Danjou <julien@danjou.info>
1313 * term.c (Fsuspend_tty, Fresume_tty):
1314 * minibuf.c (read_minibuf, run_exit_minibuf_hook):
1315 * window.c (temp_output_buffer_show):
1316 * insdel.c (signal_before_change):
1317 * frame.c (Fhandle_switch_frame):
1318 * fileio.c (Fdo_auto_save):
1319 * emacs.c (Fkill_emacs):
1320 * editfns.c (save_excursion_restore):
1321 * cmds.c (internal_self_insert):
1322 * callint.c (Fcall_interactively):
1323 * buffer.c (Fkill_all_local_variables):
1324 * keyboard.c (Fcommand_execute, Fsuspend_emacs, safe_run_hooks_1):
1326 (command_loop_1): Use Frun_hooks. Call safe_run_hooks
1327 unconditionnaly since it does the check itself.
1329 2011-03-23 Paul Eggert <eggert@cs.ucla.edu>
1331 Fix more problems found by GCC 4.5.2's static checks.
1333 * coding.c (encode_coding_raw_text): Avoid unnecessary test
1334 the first time through the loop, since we know p0 < p1 then.
1335 This also avoids a gcc -Wstrict-overflow warning.
1337 * lisp.h (SAFE_ALLOCA, SAFE_ALLOCA_LISP): Avoid 'int' overflow
1338 leading to a memory leak, possible in functions like
1339 load_charset_map_from_file that can allocate an unbounded number
1340 of objects (Bug#8318).
1342 * xmenu.c (set_frame_menubar): Use EMACS_UINT, not int, for indexes
1343 that could (at least in theory) be that large.
1345 * xdisp.c (message_log_check_duplicate): Return unsigned long, not int.
1346 This is less likely to overflow, and avoids undefined behavior if
1347 overflow does occur. All callers changed. Use strtoul to scan
1348 for the unsigned long integer.
1349 (pint2hrstr): Simplify and tune code slightly.
1350 This also avoids a (bogus) GCC warning with gcc -Wstrict-overflow.
1352 * scroll.c (do_scrolling): Work around GCC bug 48228.
1353 See <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=48228>.
1355 * frame.c (Fmodify_frame_parameters): Simplify loop counter.
1356 This also avoids a warning with gcc -Wstrict-overflow.
1357 (validate_x_resource_name): Simplify count usage.
1358 This also avoids a warning with gcc -Wstrict-overflow.
1360 * fileio.c (Fcopy_file): Report error if fchown or fchmod
1363 * emacs.c (Fdaemon_initialized): Do not ignore I/O errors (Bug#8303).
1365 * process.c (Fmake_network_process): Use socklen_t, not int,
1366 where POSIX says socklen_t is required in portable programs.
1367 This fixes a porting bug on hosts like 64-bit HP-UX, where
1368 socklen_t is wider than int (Bug#8277).
1369 (Fmake_network_process, server_accept_connection):
1370 (wait_reading_process_output, read_process_output):
1373 * process.c: Rename or move locals to avoid shadowing.
1374 (list_processes_1, Fmake_network_process):
1375 (read_process_output_error_handler, exec_sentinel_error_handler):
1376 Rename or move locals.
1377 (Fmake_network_process): Define label "retry_connect" only if needed.
1378 (Fnetwork_interface_info): Fix pointer signedness.
1379 (process_send_signal): Add cast to avoid pointer signedness problem.
1380 (FIRST_PROC_DESC, IF_NON_BLOCKING_CONNECT): Remove unused macros.
1381 (create_process): Use 'volatile' to avoid vfork clobbering (Bug#8298).
1383 Make tparam.h and terminfo.c consistent.
1384 * cm.c (tputs, tgoto, BC, UP): Remove extern decls.
1385 Include tparam.h instead, since it declares them.
1386 * cm.h (PC): Remove extern decl; tparam.h now does this.
1387 * deps.mk (cm.o, terminfo.o): Depend on tparam.h.
1388 * terminfo.c: Include tparam.h, to check interfaces.
1389 (tparm): Make 1st arg a const pointer in decl. Put it at top level.
1390 (tparam): Adjust signature to match interface in tparam.h;
1391 this removes some undefined behavior. Check that outstring and len
1392 are zero, which they always are with Emacs.
1393 * tparam.h (PC, BC, UP): New extern decls.
1395 * xftfont.c (xftfont_shape): Now static, and defined only if needed.
1396 (xftfont_open): Rename locals to avoid shadowing.
1398 * ftfont.c (ftfont_resolve_generic_family): Fix pointer signedness.
1399 (ftfont_otf_capability, ftfont_shape): Omit decls if not needed.
1400 (OTF_TAG_SYM): Omit macro if not needed.
1401 (ftfont_list): Remove unused local.
1402 (get_adstyle_property, ftfont_pattern_entity):
1403 (ftfont_lookup_cache, ftfont_open, ftfont_anchor_point):
1404 Rename locals to avoid shadowing.
1406 * xfont.c (xfont_list_family): Mark var as initialized.
1408 * xml.c (make_dom): Now static.
1410 * composite.c (composition_compute_stop_pos): Rename local to
1412 (composition_reseat_it): Remove unused locals.
1413 (find_automatic_composition, composition_adjust_point): Likewise.
1414 (composition_update_it): Mark var as initialized.
1415 (find_automatic_composition): Mark vars as initialized,
1416 with a FIXME (Bug#8290).
1418 character.h: Rename locals to avoid shadowing.
1419 * character.h (PREV_CHAR_BOUNDARY, FETCH_STRING_CHAR_ADVANCE):
1420 (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE, FETCH_CHAR_ADVANCE):
1421 (FETCH_CHAR_ADVANCE_NO_CHECK, INC_POS, DEC_POS, BUF_INC_POS):
1422 (BUF_DEC_POS): Be more systematic about renaming local temporaries
1425 * textprop.c (property_change_between_p): Remove; unused.
1427 * intervals.c (interval_start_pos): Now static.
1429 * intervals.h (CHECK_TOTAL_LENGTH): Avoid empty "else".
1431 * atimer.c (start_atimer, append_atimer_lists, set_alarm):
1432 Rename locals to avoid shadowing.
1434 * sound.c (wav_play, au_play, Fplay_sound_internal):
1435 Fix pointer signedness.
1436 (alsa_choose_format): Remove unused local var.
1437 (wav_play): Initialize a variable to 0, to prevent undefined
1438 behavior (Bug#8278).
1440 * region-cache.c (insert_cache_boundary): Redo var to avoid shadowing.
1442 * region-cache.h (pp_cache): New decl, for gcc -Wmissing-prototypes.
1444 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork
1445 clobbering (Bug#8298).
1446 * sysdep.c (sys_subshell): Likewise.
1447 Previously, the sys_subshell 'volatile' was incorrectly IF_LINTted out.
1449 * lisp.h (child_setup): Now NO_RETURN unless DOS_NT.
1450 This should get cleaned up, so that child_setup has the
1451 same signature on all platforms.
1453 * callproc.c (call_process_cleanup): Now static.
1454 (relocate_fd): Rename locals to avoid shadowing.
1456 2011-03-22 Chong Yidong <cyd@stupidchicken.com>
1458 * xterm.c (x_clear_frame): Remove XClearWindow call. This appears
1459 not to be necessary, and produces flickering.
1461 2011-03-20 Glenn Morris <rgm@gnu.org>
1463 * config.in: Remove file.
1465 2011-03-20 Juanma Barranquero <lekktu@gmail.com>
1467 * minibuf.c (Vcompleting_read_function): Don't declare, global variables
1468 are now in src/globals.h.
1469 (syms_of_minibuf): Remove spurious & from previous change.
1471 2011-03-20 Leo <sdl.web@gmail.com>
1473 * minibuf.c (completing-read-function): New variable.
1474 (completing-read-default): Rename from completing-read.
1475 (completing-read): Call completing-read-function.
1477 2011-03-19 Juanma Barranquero <lekktu@gmail.com>
1479 * xfaces.c (Fx_load_color_file):
1480 Read color file from absolute filename (bug#8250).
1482 2011-03-19 Juanma Barranquero <lekktu@gmail.com>
1484 * makefile.w32-in: Update dependencies.
1486 2011-03-17 Eli Zaretskii <eliz@gnu.org>
1488 * makefile.w32-in ($(BLD)/unexw32.$(O)): Depend on $(SRC)/unexec.h.
1490 2011-03-17 Paul Eggert <eggert@cs.ucla.edu>
1492 Fix more problems found by GCC 4.5.2's static checks.
1494 * process.c (make_serial_process_unwind, send_process_trap):
1495 (sigchld_handler): Now static.
1497 * process.c (allocate_pty): Let PTY_ITERATION declare iteration vars.
1498 That way, the code declares only the vars that it needs.
1499 * s/aix4-2.h (PTY_ITERATION): Declare iteration vars.
1500 * s/cygwin.h (PTY_ITERATION): Likewise.
1501 * s/darwin.h (PTY_ITERATION): Likewise.
1502 * s/gnu-linux.h (PTY_ITERATION): Likewise.
1504 * s/irix6-5.h (PTY_OPEN): Declare stb, to loosen coupling.
1505 * process.c (allocate_pty): Don't declare stb unless it's needed.
1507 * bytecode.c (MAYBE_GC): Rewrite so as not to use empty "else".
1508 (CONSTANTLIM): Remove; unused.
1509 (METER_CODE, Bscan_buffer, Bread_char, Bset_mark):
1510 Define only if needed.
1512 * unexelf.c (unexec): Name an expression,
1513 to avoid gcc -Wbad-function-cast warning.
1514 Use a different way to cause a compilation error if anyone uses
1515 n rather than nn, a way that does not involve shadowing.
1516 (ELF_BSS_SECTION_NAME, OLD_PROGRAM_H): Remove; unused.
1518 * deps.mk (unexalpha.o): Remove; unused.
1520 New file unexec.h, the (simple) interface for unexec (Bug#8267).
1521 * unexec.h: New file.
1522 * deps.mk (emacs.o, unexaix.o, unexcw.o, unexcoff.o, unexelf.o):
1523 (unexhp9k800.o, unexmacosx.o, unexsol.o, unexw32.o):
1525 * emacs.c [!defined CANNOT_DUMP]: Include unexec.h.
1526 * unexaix.c, unexcoff.c, unexcw.c, unexelf.c, unexhp9k800.c:
1527 * unexmacosx.c, unexsol.c, unexw32.c: Include unexec.h.
1528 Change as necessary to match prototype in unexec.h.
1530 * syntax.c (Fforward_comment, scan_lists): Rename locals to avoid
1532 (back_comment, skip_chars): Mark vars as initialized.
1534 * character.h (FETCH_STRING_CHAR_ADVANCE_NO_CHECK, BUF_INC_POS):
1535 Rename locals to avoid shadowing.
1537 * lread.c (read1): Rewrite so as not to use empty "else".
1538 (Fload, readevalloop, read1): Rename locals to avoid shadowing.
1540 * print.c (Fredirect_debugging_output): Fix pointer signedess.
1542 * lisp.h (debug_output_compilation_hack): Add decl here, to avoid
1543 warning when compiling print.c.
1545 * font.c (font_unparse_fcname): Abort in an "impossible" situation
1546 instead of using an uninitialized var.
1547 (font_sort_entities): Mark var as initialized.
1549 * character.h (FETCH_CHAR_ADVANCE): Rename locals to avoid shadowing.
1551 * font.c (font_unparse_xlfd): Don't mix pointers to variables with
1552 pointers to constants.
1553 (font_parse_fcname): Remove unused vars.
1554 (font_delete_unmatched): Now static.
1555 (font_get_spec): Remove; unused.
1556 (font_style_to_value, font_prop_validate_style, font_unparse_fcname):
1557 (font_update_drivers, Ffont_get_glyphs, font_add_log):
1558 Rename or move locals to avoid shadowing.
1560 * fns.c (require_nesting_list, require_unwind): Now static.
1561 (Ffillarray): Rename locals to avoid shadowing.
1563 * floatfns.c (domain_error2): Define only if needed.
1564 (Ffrexp, Fldexp): Rename locals to avoid shadowing.
1566 * alloc.c (mark_backtrace): Move decl from here ...
1567 * lisp.h: ... to here, so that it can be checked.
1569 * eval.c (call_debugger, do_debug_on_call, grow_specpdl): Now static.
1570 (Fdefvar): Rewrite so as not to use empty "else".
1571 (lisp_indirect_variable): Name an expression,
1572 to avoid gcc -Wbad-function-cast warning.
1573 (Fdefvar): Rename locals to avoid shadowing.
1575 * callint.c (quotify_arg, quotify_args): Now static.
1576 (Fcall_interactively): Rename locals to avoid shadowing.
1577 Use const pointer when appropriate.
1579 * lisp.h (get_system_name, get_operating_system_release):
1580 Move decls here, to check interfaces.
1581 * process.c (get_operating_system_release): Move decl to lisp.h.
1582 * xrdb.c (get_system_name): Likewise.
1583 * editfns.c (init_editfns, Fuser_login_name, Fuser_uid):
1584 (Fuser_real_uid, Fuser_full_name): Remove unnecessary casts,
1585 some of which prompt warnings from gcc -Wbad-function-cast.
1586 (Fformat_time_string, Fencode_time, Finsert_char):
1587 (Ftranslate_region_internal, Fformat):
1588 Rename or remove local vars to avoid shadowing.
1589 (Ftranslate_region_internal): Mark var as initialized.
1591 * doc.c (Fdocumentation, Fsnarf_documentation): Move locals to
1594 * lisp.h (eassert): Check that the argument compiles, even if
1595 ENABLE_CHECKING is not defined.
1597 * data.c (Findirect_variable): Name an expression, to avoid
1598 gcc -Wbad-function-cast warning.
1599 (default_value, arithcompare, arith_driver, arith_error): Now static.
1600 (store_symval_forwarding): Rename local to avoid shadowing.
1601 (Fmake_variable_buffer_local, Fmake_local_variable):
1602 Mark variables as initialized.
1603 (do_blv_forwarding, do_symval_forwarding): Remove; unused.
1605 * alloc.c (check_cons_list): Do not define unless GC_CHECK_CONS_LIST.
1606 (Fmake_vector, Fvector, Fmake_byte_code, Fgarbage_collect):
1607 Rename locals to avoid shadowing.
1608 (mark_stack): Move local variables into the #ifdef region where
1610 (BLOCK_INPUT_ALLOC, UNBLOCK_INPUT_ALLOC): Define only if
1611 ! defined SYSTEM_MALLOC && ! defined SYNC_INPUT, as they are not
1613 (CHECK_ALLOCATED): Define only if GC_CHECK_MARKED_OBJECTS.
1614 (GC_STRING_CHARS): Remove; not used.
1615 (Fmemory_limit): Cast sbrk's returned value to char *.
1617 * lisp.h (check_cons_list): Declare if GC_CHECK_CONS_LIST; this
1618 avoids undefined behavior in theory.
1620 * regex.c (IF_LINT): Add defn, for benefit of ../lib-src.
1622 Use functions, not macros, for up- and down-casing (Bug#8254).
1623 * buffer.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
1624 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Remove. All callers changed
1625 to use the following functions instead of these macros.
1626 (downcase): Adjust to lack of DOWNCASE_TABLE. Return int, not
1627 EMACS_INT, since callers assume the returned value fits in int.
1628 (upcase1): Likewise, for UPCASE_TABLE.
1629 (uppercasep, lowercasep, upcase): New static inline functions.
1630 * editfns.c (Fchar_equal): Remove no-longer-needed workaround for
1631 the race-condition problem in the old DOWNCASE.
1633 * regex.c (CHARSET_LOOKUP_RANGE_TABLE_RAW, POP_FAILURE_REG_OR_COUNT):
1634 Rename locals to avoid shadowing.
1635 (regex_compile, re_match_2_internal): Move locals to avoid shadowing.
1636 (regex_compile, re_search_2, re_match_2_internal):
1637 Remove unused local vars.
1638 (FREE_VAR): Rewrite so as not to use empty "else",
1639 which gcc can warn about.
1640 (regex_compile, re_match_2_internal): Mark locals as initialized.
1641 (RETALLOC_IF): Define only if needed.
1642 (WORDCHAR_P): Likewise. This one is never needed, but is used
1643 only in a comment talking about a compiler bug, so put inside
1644 the #if 0 of that comment.
1645 (CHARSET_LOOKUP_BITMAP, FAIL_STACK_FULL, RESET_FAIL_STACK):
1646 (PUSH_FAILURE_ELT, BUF_PUSH_3, STOP_ADDR_VSTRING):
1649 * search.c (boyer_moore): Rename locals to avoid shadowing.
1650 * character.h (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE):
1651 (PREV_CHAR_BOUNDARY): Likewise.
1653 * search.c (simple_search): Remove unused var.
1655 * dired.c (compile_pattern): Move decl from here ...
1656 * lisp.h: ... to here, so that it can be checked.
1657 (struct re_registers): New forward decl.
1659 * character.h (INC_POS, DEC_POS): Rename locals to avoid shadowing.
1661 * indent.c (MULTIBYTE_BYTES_WIDTH): New args bytes, width.
1663 (MULTIBYTE_BYTES_WIDTH, scan_for_column, compute_motion):
1664 Rename locals to avoid shadowing.
1665 (Fvertical_motion): Mark locals as initialized.
1667 * casefiddle.c (casify_object, casify_region): Now static.
1668 (casify_region): Mark local as initialized.
1670 * cmds.c (internal_self_insert): Rename local to avoid shadowing.
1672 * lisp.h (GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR, GCPRO5_VAR, GCPRO6_VAR):
1673 New macros, so that the caller can use some names other than
1674 gcpro1, gcpro2, etc.
1675 (GCPRO2, GCPRO3, GCPRO4, GCPRO5, GCPRO6): Reimplement in terms
1677 (GCPRO1_VAR, UNGCPRO_VAR): Change the meaning of the second
1678 argument, for consistency with GCPRO2_VAR, etc: it is now the
1679 prefix of the variable, not the variable itself. All uses
1681 * dired.c (directory_files_internal, file_name_completion):
1682 Rename locals to avoid shadowing.
1684 Fix a race condition diagnosed by gcc -Wsequence-point (Bug#8254).
1685 An expression of the form (DOWNCASE (x) == DOWNCASE (y)), found in
1686 dired.c's scmp function, had undefined behavior.
1687 * lisp.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
1688 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Move from here ...
1689 * buffer.h: ... to here, because these macros use current_buffer,
1690 and the new implementation with inline functions needs to have
1691 current_buffer in scope now, rather than later when the macros
1693 (downcase, upcase1): New static inline functions.
1694 (DOWNCASE, UPCASE1): Reimplement using these functions.
1695 This avoids undefined behavior in expressions like
1696 DOWNCASE (x) == DOWNCASE (y), which previously suffered
1697 from race conditions in accessing the global variables
1698 case_temp1 and case_temp2.
1699 * casetab.c (case_temp1, case_temp2): Remove; no longer needed.
1700 * lisp.h (case_temp1, case_temp2): Remove their decls.
1701 * character.h (ASCII_CHAR_P): Move from here ...
1702 * lisp.h: ... to here, so that the inline functions mentioned
1705 * dired.c (directory_files_internal_unwind): Now static.
1707 * fileio.c (file_name_as_directory, directory_file_name):
1708 (barf_or_query_if_file_exists, auto_save_error, auto_save_1):
1710 (file_name_as_directory): Use const pointers when appropriate.
1711 (Fexpand_file_name): Likewise. In particular, newdir might
1712 point at constant storage, so make it a const pointer.
1713 (Fmake_directory_internal, Fread_file_name): Remove unused vars.
1714 (Ffile_selinux_context, Fset_file_selinux_context): Fix pointer
1716 (Fset_file_times, Finsert_file_contents, auto_save_error):
1717 Rename locals to avoid shadowing.
1719 * minibuf.c (choose_minibuf_frame_1): Now static.
1720 (Ftry_completion, Fall_completions): Rename or remove locals
1723 * marker.c (bytepos_to_charpos): Remove; unused.
1725 * lisp.h (verify_bytepos, count_markers): New decls,
1726 so that gcc does not warn that these functions aren't declared.
1728 * insdel.c (check_markers, make_gap_larger, make_gap_smaller):
1729 (reset_var_on_error, Fcombine_after_change_execute_1): Now static.
1730 (CHECK_MARKERS): Redo to avoid gcc -Wempty-body diagnostic.
1731 (copy_text): Remove unused local var.
1733 * filelock.c (within_one_second): Now static.
1734 (lock_file_1): Rename local to avoid shadowing.
1736 * buffer.c (fix_overlays_before): Mark locals as initialized.
1737 (fix_start_end_in_overlays): Likewise. This function should be
1738 simplified by using pointers-to-pointers, but that's a different
1740 (switch_to_buffer_1): Now static.
1741 (Fkill_buffer, record_buffer, Fbury_buffer, Fset_buffer_multibyte):
1742 (report_overlay_modification): Rename locals to avoid shadowing.
1744 * sysdep.c (system_process_attributes): Rename vars to avoid shadowing.
1745 Fix pointer signedness issue.
1746 (sys_subshell): Mark local as volatile if checking for lint,
1747 to suppress a gcc -Wclobbered warning that does not seem to be right.
1748 (MAXPATHLEN): Define only if needed.
1750 * process.c (serial_open, serial_configure): Move decls from here ...
1751 * systty.h: ... to here, so that they can be checked.
1753 * fns.c (get_random, seed_random): Move extern decls from here ...
1754 * lisp.h: ... to here, so that they can be checked.
1756 * sysdep.c (reset_io): Now static.
1757 (wait_for_termination_signal): Remove; unused.
1759 * keymap.c (keymap_parent, keymap_memberp, map_keymap_internal):
1760 (copy_keymap_item, append_key, push_text_char_description):
1762 (Fwhere_is_internal): Don't test CONSP (sequences) unnecessarily.
1763 (DENSE_TABLE_SIZE): Remove; unused.
1764 (get_keymap, access_keymap, Fdefine_key, Fwhere_is_internal):
1765 (describe_map_tree):
1766 Rename locals to avoid shadowing.
1768 * keyboard.c: Declare functions static if they are not used elsewhere.
1769 (echo_char, echo_dash, cmd_error, top_level_2):
1770 (poll_for_input, handle_async_input): Now static.
1771 (read_char, kbd_buffer_get_event, make_lispy_position):
1772 (make_lispy_event, make_lispy_movement, apply_modifiers):
1773 (decode_keyboard_code, tty_read_avail_input, menu_bar_items):
1774 (parse_tool_bar_item, read_key_sequence, Fread_key_sequence):
1775 (Fread_key_sequence_vector): Rename locals to avoid shadowing.
1776 (read_key_sequence, read_char): Mark locals as initialized.
1777 (Fexit_recursive_edit, Fabort_recursive_edit): Mark with NO_RETURN.
1779 * keyboard.h (make_ctrl_char): New decl.
1780 (mark_kboards): Move decl here ...
1781 * alloc.c (mark_kboards): ... from here.
1783 * lisp.h (force_auto_save_soon): New decl.
1785 * emacs.c (init_cmdargs): Rename local to avoid shadowing.
1786 (DEFINE_DUMMY_FUNCTION): New macro.
1787 (__do_global_ctors, __do_global_ctors_aux, __do_global_dtors, __main):
1789 (main): Add casts to avoid warnings
1790 if GCC considers string literals to be constants.
1792 * lisp.h (fatal_error_signal): Add decl, since it's exported.
1794 * dbusbind.c: Pointer signedness fixes.
1795 (xd_signature, xd_append_arg, xd_initialize):
1796 (Fdbus_call_method, Fdbus_call_method_asynchronously):
1797 (Fdbus_method_return_internal, Fdbus_method_error_internal):
1798 (Fdbus_send_signal, xd_read_message_1, Fdbus_register_service):
1799 (Fdbus_register_signal): Use SSDATA when the context wants char *.
1801 * dbusbind.c (Fdbus_init_bus): Add cast to avoid warning
1802 if GCC considers string literals to be constants.
1803 (Fdbus_register_service, Fdbus_register_method): Remove unused vars.
1805 2011-03-16 Stefan Monnier <monnier@iro.umontreal.ca>
1807 * print.c (PRINT_CIRCLE_CANDIDATE_P): New macro.
1808 (print_preprocess, print_object): New macro to fix last change.
1810 * print.c (print_preprocess): Don't forget font objects.
1812 2011-03-16 Juanma Barranquero <lekktu@gmail.com>
1814 * emacs.c (USAGE3): Doc fixes.
1816 2011-03-15 Andreas Schwab <schwab@linux-m68k.org>
1818 * coding.c (detect_coding_iso_2022): Reorganize code to clarify
1821 2011-03-14 Juanma Barranquero <lekktu@gmail.com>
1823 * lisp.h (VWindow_system, Qfile_name_history):
1824 * keyboard.h (lispy_function_keys) [WINDOWSNT]:
1825 * w32term.h (w32_system_caret_hwnd, w32_system_caret_height)
1826 (w32_system_caret_x, w32_system_caret_y): Declare extern.
1828 * w32select.c: Don't #include "keyboard.h".
1829 (run_protected): Add extern declaration for waiting_for_input.
1831 * w32.c (Qlocal, noninteractive1, inhibit_window_system):
1832 * w32console.c (detect_input_pending, read_input_pending)
1833 (encode_terminal_code):
1834 * w32fns.c (quit_char, lispy_function_keys, Qtooltip)
1835 (w32_system_caret_hwnd, w32_system_caret_height, w32_system_caret_x)
1836 (w32_system_caret_y, Qfile_name_history):
1837 * w32font.c (w32font_driver, QCantialias, QCotf, QClang):
1838 * w32inevt.c (reinvoke_input_signal, lispy_function_keys):
1839 * w32menu.c (Qmenu_bar, QCtoggle, QCradio, Qoverriding_local_map)
1840 (Qoverriding_terminal_local_map, Qmenu_bar_update_hook):
1841 * w32proc.c (Qlocal, report_file_error):
1842 * w32term.c (Vwindow_system, updating_frame):
1843 * w32uniscribe.c (initialized, uniscribe_font_driver):
1844 Remove unneeded extern declarations.
1846 2011-03-14 Chong Yidong <cyd@stupidchicken.com>
1848 * buffer.c (Fmake_indirect_buffer): Fix incorrect assertions.
1850 2011-03-13 Chong Yidong <cyd@stupidchicken.com>
1852 * buffer.h (BUF_BEGV, BUF_BEGV_BYTE, BUF_ZV, BUF_ZV_BYTE, BUF_PT)
1853 (BUF_PT_BYTE): Rewrite to handle indirect buffers (Bug#8219).
1854 These macros can no longer be used for assignment.
1856 * buffer.c (Fget_buffer_create, Fmake_indirect_buffer):
1857 Assign struct members directly, instead of using BUF_BEGV etc.
1858 (record_buffer_markers, fetch_buffer_markers): New functions for
1859 recording and fetching special buffer markers.
1860 (set_buffer_internal_1, set_buffer_temp): Use them.
1862 * lread.c (unreadchar): Use SET_BUF_PT_BOTH.
1864 * insdel.c (adjust_point): Use SET_BUF_PT_BOTH.
1866 * intervals.c (temp_set_point_both): Use SET_BUF_PT_BOTH.
1867 (get_local_map): Use SET_BUF_BEGV_BOTH and SET_BUF_ZV_BOTH.
1869 * xdisp.c (hscroll_window_tree):
1870 (reconsider_clip_changes): Use PT instead of BUF_PT.
1872 2011-03-13 Eli Zaretskii <eliz@gnu.org>
1874 * makefile.w32-in ($(BLD)/editfns.$(O)): Depend on
1875 $(EMACS_ROOT)/lib/intprops.h.
1877 2011-03-13 Paul Eggert <eggert@cs.ucla.edu>
1879 Fix more problems found by GCC 4.5.2's static checks.
1881 * gtkutil.c (xg_get_pixbuf_from_pixmap): Add cast from char *
1882 to unsigned char * to avoid compiler diagnostic.
1883 (xg_free_frame_widgets): Make it clear that a local variable is
1884 needed only if USE_GTK_TOOLTIP.
1885 (gdk_window_get_screen): Make it clear that this macro is needed
1886 only if USE_GTK_TOOLTIP.
1887 (int_gtk_range_get_value): New function, which avoids a diagnostic
1888 from gcc -Wbad-function-cast.
1889 (xg_set_toolkit_scroll_bar_thumb): Use it.
1890 (xg_tool_bar_callback, xg_tool_item_stale_p): Rewrite to avoid
1891 diagnostic from gcc -Wbad-function-cast.
1892 (get_utf8_string, xg_get_file_with_chooser):
1893 Rename locals to avoid shadowing.
1894 (create_dialog): Move locals to avoid shadowing.
1896 * xgselect.c (xg_select): Remove unused var.
1898 * image.c (four_corners_best): Mark locals as initialized.
1899 (gif_load): Initialize transparent_p to zero (Bug#8238).
1900 Mark another local as initialized.
1901 (my_png_error, my_error_exit): Mark with NO_RETURN.
1903 * image.c (clear_image_cache): Now static.
1904 (DIM, HAVE_STDLIB_H_1): Remove unused macros.
1905 (xpm_load): Redo to avoid "discards qualifiers" gcc warning.
1906 (x_edge_detection): Remove unnecessary cast that
1907 gcc -Wbad-function-cast diagnoses.
1908 (gif_load): Fix pointer signedness.
1909 (clear_image_cache, xbm_read_bitmap_data, x_detect_edges):
1910 (jpeg_load, gif_load): Rename locals to avoid shadowing.
1912 2011-03-12 Paul Eggert <eggert@cs.ucla.edu>
1914 Improve quality of tests for time stamp overflow.
1915 For example, without this patch (encode-time 0 0 0 1 1
1916 1152921504606846976) returns the obviously-bogus value (-948597
1917 62170) on my RHEL 5.5 x86-64 host. With the patch, it correctly
1918 reports time overflow. See
1919 <http://lists.gnu.org/archive/html/emacs-devel/2011-03/msg00470.html>.
1920 * deps.mk (editfns.o): Depend on ../lib/intprops.h.
1921 * editfns.c: Include limits.h and intprops.h.
1922 (TIME_T_MIN, TIME_T_MAX): New macros.
1923 (time_overflow): Move earlier, to before first use.
1924 (hi_time, lo_time): New functions, for an accurate test for
1926 (Fcurrent_time, Fget_internal_run_time, make_time): Use them.
1927 (Fget_internal_run_time): Don't assume time_t fits in int.
1928 (make_time): Use list2 instead of Fcons twice.
1929 (Fdecode_time): More accurate test for out-of-range times.
1930 (check_tm_member): New function.
1931 (Fencode_time): Use it, to test for out-of-range times.
1932 (lisp_time_argument): Don't rely on undefined left-shift and
1933 right-shift behavior when checking for time stamp overflow.
1935 * editfns.c (time_overflow): New function, refactoring common code.
1936 (Fformat_time_string, Fdecode_time, Fencode_time):
1937 (Fcurrent_time_string): Use it.
1939 Move 'make_time' to be next to its inverse 'lisp_time_argument'.
1940 * dired.c (make_time): Move to ...
1941 * editfns.c (make_time): ... here.
1942 * systime.h: Note the move.
1944 2011-03-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
1946 * fringe.c (update_window_fringes): Remove unused variables.
1948 * unexmacosx.c (copy_data_segment): Also copy __got section.
1951 2011-03-12 Eli Zaretskii <eliz@gnu.org>
1953 * termcap.c [MSDOS]: Include "msdos.h".
1954 (find_capability, tgetnum, tgetflag, tgetstr, tputs, tgetent):
1955 Constify `char *' arguments and their references according to
1956 prototypes in tparam.h.
1958 * deps.mk (termcap.o): Depend on tparam.h and msdos.h.
1960 * msdos.c (XMenuAddPane): 3rd argument is `const char *' now.
1961 Adapt all references accordingly.
1963 * msdos.h (XMenuAddPane): 3rd argument is `const char *' now.
1965 2011-03-11 Tom Tromey <tromey@redhat.com>
1967 * buffer.c (syms_of_buffer): Remove obsolete comment.
1969 2011-03-11 Eli Zaretskii <eliz@gnu.org>
1971 * termhooks.h (encode_terminal_code): Declare prototype.
1973 * msdos.c (encode_terminal_code): Don't declare prototype.
1975 * term.c (encode_terminal_code): Now external again, used by
1976 w32console.c and msdos.c.
1978 * makefile.w32-in ($(BLD)/term.$(O), ($(BLD)/tparam.$(O)):
1979 Depend on $(SRC)/tparam.h, see 2011-03-11T07:24:21Z!eggert@cs.ucla.edu.
1981 2011-03-11 Paul Eggert <eggert@cs.ucla.edu>
1983 Fix some minor problems found by GCC 4.5.2's static checks.
1985 * fringe.c (update_window_fringes): Mark locals as initialized
1987 (destroy_fringe_bitmap, init_fringe_bitmap): Now static.
1989 * alloc.c (mark_fringe_data): Move decl from here ...
1990 * lisp.h (mark_fringe_data) [HAVE_WINDOW_SYSTEM]: ... to here,
1991 to check its interface.
1992 (init_fringe_once): Do not declare unless HAVE_WINDOW_SYSTEM.
1994 * fontset.c (free_realized_fontset): Now static.
1995 (Fset_fontset_font): Rename local to avoid shadowing.
1996 (fontset_font): Mark local as initialized.
1997 (FONTSET_SPEC, FONTSET_REPERTORY, RFONT_DEF_REPERTORY): Remove; unused.
1999 * xrdb.c: Include "xterm.h", to check x_load_resources's interface.
2001 * xselect.c (x_disown_buffer_selections): Remove; not used.
2002 (TRACE3) [!defined TRACE_SELECTION]: Remove; not used.
2003 (x_own_selection, Fx_disown_selection_internal): Rename locals
2005 (x_handle_dnd_message): Remove local to avoid shadowing.
2007 * lisp.h (GCPRO1_VAR, UNGCPRO_VAR): New macros,
2008 so that the caller can use some name other than gcpro1.
2009 (GCPRO1, UNGCPRO): Reimplement in terms of the new macros.
2010 * xfns.c (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
2011 (Fx_backspace_delete_keys_p):
2012 Use them to avoid shadowing, and rename vars to avoid shadowing.
2013 (x_decode_color, x_set_name, x_window): Now static.
2014 (Fx_create_frame): Add braces to silence GCC warning.
2015 (Fx_file_dialog, Fx_select_font): Fix pointer signedness.
2016 (x_real_positions, xg_set_icon_from_xpm_data, x_create_tip_frame):
2017 Remove unused locals.
2018 (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
2019 (Fx_backspace_delete_keys_p): Rename locals to avoid shadowing.
2020 Some of these renamings use the new GCPRO1_VAR and UNGCPRO_VAR
2023 * xterm.h (x_mouse_leave): New decl.
2025 * xterm.c (x_copy_dpy_color, x_focus_on_frame, x_unfocus_frame):
2026 Remove unused functions.
2027 (x_shift_glyphs_for_insert, XTflash, XTring_bell):
2028 (x_calc_absolute_position): Now static.
2029 (XTread_socket): Don't define label "out" unless it's used.
2030 Don't declare local "event" unless it's used.
2031 (x_iconify_frame, x_free_frame_resources): Don't declare locals
2032 unless they are used.
2033 (XEMBED_VERSION, xembed_set_info): Don't define unless needed.
2034 (x_fatal_error_signal): Remove; not used.
2035 (x_draw_image_foreground, redo_mouse_highlight, XTmouse_position):
2036 (x_scroll_bar_report_motion, handle_one_xevent, x_draw_bar_cursor):
2037 (x_error_catcher, x_connection_closed, x_error_handler):
2038 (x_error_quitter, xembed_send_message, x_iconify_frame):
2039 (my_log_handler): Rename locals to avoid shadowing.
2040 (x_delete_glyphs, x_ins_del_lines): Mark with NO_RETURN.
2041 (x_connection_closed): Tell GCC not to suggest NO_RETURN.
2043 * xfaces.c (clear_face_cache, Fx_list_fonts, Fface_font):
2044 Rename or move locals to avoid shadowing.
2045 (tty_defined_color, merge_face_heights): Now static.
2046 (free_realized_faces_for_fontset): Remove; not used.
2047 (Fx_list_fonts): Mark variable that gcc -Wuninitialized
2048 does not deduce is never used uninitialized.
2049 (STRDUPA, LSTRDUPA, FONT_POINT_SIZE_QUANTUM): Remove; not used.
2050 (LFACEP): Define only if XASSERTS, as it's not needed otherwise.
2052 * terminal.c (store_terminal_param): Now static.
2054 * xmenu.c (menu_highlight_callback): Now static.
2055 (set_frame_menubar): Remove unused local.
2056 (xmenu_show): Rename parameter to avoid shadowing.
2057 (xmenu_show, xdialog_show, xmenu_show): Make local pointers "const"
2058 since they might point to immutable storage.
2059 (next_menubar_widget_id): Declare only if USE_X_TOOLKIT,
2060 since it's unused otherwise.
2062 * xdisp.c (produce_glyphless_glyph): Initialize lower_xoff.
2063 Add a FIXME, since the code still doesn't look right. (Bug#8215)
2064 (Fcurrent_bidi_paragraph_direction): Simplify slightly; this
2065 avoids a gcc -Wuninitialized diagnostic.
2066 (display_line, BUILD_COMPOSITE_GLYPH_STRING, draw_glyphs):
2067 (note_mouse_highlight): Mark variables that gcc -Wuninitialized
2068 does not deduce are never used uninitialized.
2070 * lisp.h (IF_LINT): New macro, copied from ../lib-src/emacsclient.c.
2072 * xdisp.c (redisplay_window): Rename local to avoid shadowing.
2073 * window.c (window_loop, size_window):
2074 (run_window_configuration_change_hook, enlarge_window): Likewise.
2076 * window.c (display_buffer): Now static.
2077 (size_window): Mark variables that gcc -Wuninitialized
2078 does not deduce are never used uninitialized.
2079 * window.h (check_all_windows): New decl, to forestall
2080 gcc -Wmissing-prototypes diagnostic.
2081 * dispextern.h (bidi_dump_cached_states): Likewise.
2083 * charset.h (CHECK_CHARSET_GET_CHARSET): Rename locals to avoid
2085 * charset.c (map_charset_for_dump, Fchar_charset): Likewise.
2087 (Fsort_charsets): Redo min/max calculation to shorten the code a bit
2088 and to avoid gcc -Wuninitialized warning.
2089 (load_charset_map): Mark variables that gcc -Wuninitialized
2090 does not deduce are never used uninitialized.
2091 (load_charset): Abort instead of using uninitialized var (Bug#8229).
2093 * coding.c (coding_set_source, coding_set_destination):
2094 Use "else { /* comment */ }" rather than "else /* comment */;"
2095 for clarity, and to avoid gcc -Wempty-body warning.
2096 (Fdefine_coding_system_internal): Don't redeclare 'i' inside
2097 a block, when the outer 'i' will do.
2098 (decode_coding_utf_8, decode_coding_utf_16, detect_coding_emacs_mule):
2099 (emacs_mule_char, decode_coding_emacs_mule, detect_coding_iso_2022):
2100 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5):
2101 (decode_coding_raw_text, decode_coding_charset, get_translation_table):
2102 (Fdecode_sjis_char, Fdefine_coding_system_internal):
2103 Rename locals to avoid shadowing.
2104 * character.h (FETCH_STRING_CHAR_ADVANCE): Likewise.
2105 * coding.c (emacs_mule_char, encode_invocation_designation):
2106 Now static, since they're not used elsewhere.
2107 (decode_coding_iso_2022): Add "default: abort ();" as a safety check.
2108 (decode_coding_object, encode_coding_object, detect_coding_system):
2109 (decode_coding_emacs_mule): Mark variables that gcc
2110 -Wuninitialized does not deduce are never used uninitialized.
2111 (detect_coding_iso_2022): Initialize a local variable that might
2112 be used uninitialized. Leave a FIXME because it's not clear that
2113 this initialization is needed. (Bug#8211)
2114 (ISO_CODE_LF, ISO_CODE_CR, CODING_ISO_FLAG_EUC_TW_SHIFT):
2115 (ONE_MORE_BYTE_NO_CHECK, UTF_BOM, UTF_16_INVALID_P):
2116 (SHIFT_OUT_OK, ENCODE_CONTROL_SEQUENCE_INTRODUCER):
2117 (ENCODE_DIRECTION_R2L, ENCODE_DIRECTION_L2R):
2118 Remove unused macros.
2120 * category.c (hash_get_category_set): Remove unused local var.
2121 (copy_category_table): Now static, since it's not used elsewhere.
2122 * character.c (string_count_byte8): Likewise.
2124 * ccl.c (CCL_WRITE_STRING, CCL_ENCODE_CHAR, Fccl_execute_on_string):
2125 (Fregister_code_conversion_map): Rename locals to avoid shadowing.
2127 * chartab.c (copy_sub_char_table): Now static, since it's not used
2129 (sub_char_table_ref_and_range, char_table_ref_and_range):
2130 Rename locals to avoid shadowing.
2131 (ASET_RANGE, GET_SUB_CHAR_TABLE): Remove unused macros.
2133 * bidi.c (bidi_check_type): Now static, since it's not used elsewhere.
2134 (BIDI_BOB): Remove unused macro.
2136 * cm.c (cmgoto): Mark variables that gcc -Wuninitialized does not
2137 deduce are never used uninitialized.
2138 * term.c (encode_terminal_code): Likewise.
2140 * term.c (encode_terminal_code): Now static. Remove unused local.
2142 * tparam.h: New file.
2143 * term.c, tparam.h: Include it.
2144 * deps.mk (term.o, tparam.o): Depend on tparam.h.
2145 * term.c (tputs, tgetent, tgetflag, tgetnum, tparam, tgetstr):
2146 Move these decls to tparam.h, and make them agree with what
2147 is actually in tparam.c. The previous trick of using incompatible
2148 decls in different modules does not conform to the C standard.
2149 All callers of tparam changed to use tparam's actual API.
2150 * tparam.c (tparam1, tparam, tgoto):
2151 Use const pointers where appropriate.
2153 * cm.c (calccost, cmgoto): Use const pointers where appropriate.
2154 * cm.h (struct cm): Likewise.
2155 * dispextern.h (do_line_insertion_deletion_costs): Likewise.
2156 * scroll.c (ins_del_costs, do_line_insertion_deletion_costs): Likewise.
2157 * term.c (tty_ins_del_lines, calculate_costs, struct fkey_table):
2158 (term_get_fkeys_1, append_glyphless_glyph, produce_glyphless_glyph):
2159 (turn_on_face, init_tty): Likewise.
2160 * termchar.h (struct tty_display_info): Likewise.
2162 * term.c (term_mouse_position): Rename local to avoid shadowing.
2164 * alloc.c (mark_ttys): Move decl from here ...
2165 * lisp.h (mark_ttys): ... to here, so that it's checked against defn.
2167 2011-03-11 Andreas Schwab <schwab@linux-m68k.org>
2169 * .gdbinit (pwinx, xbuffer): Fix access to buffer name.
2171 2011-03-09 Juanma Barranquero <lekktu@gmail.com>
2173 * search.c (compile_pattern_1): Remove argument regp, unused since
2174 revid:rms@gnu.org-19941211082627-3x1g1wyqkjmwloig.
2175 (compile_pattern): Don't pass it.
2177 2011-03-08 Jan Djärv <jan.h.d@swipnet.se>
2179 * xterm.h (DEFAULT_GDK_DISPLAY): New define.
2180 (GDK_WINDOW_XID, gtk_widget_get_preferred_size): New defines
2182 (GTK_WIDGET_TO_X_WIN): Use GDK_WINDOW_XID.
2184 * xmenu.c (menu_position_func): Call gtk_widget_get_preferred_size.
2186 * gtkutil.c: Include gtkx.h if HAVE_GTK3. If ! HAVE_GTK3, define
2187 gdk_window_get_screen, gdk_window_get_geometry,
2188 gdk_x11_window_lookup_for_display and GDK_KEY_g.
2189 (xg_set_screen): Use DEFAULT_GDK_DISPLAY.
2190 (xg_get_pixbuf_from_pixmap): New function.
2191 (xg_get_pixbuf_from_pix_and_mask): Change parameters from GdkPixmap
2192 to Pixmap, take frame as parameter, remove GdkColormap parameter.
2193 Call xg_get_pixbuf_from_pixmap instead of
2194 gdk_pixbuf_get_from_drawable.
2195 (xg_get_image_for_pixmap): Do not make GdkPixmaps, call
2196 xg_get_pixbuf_from_pix_and_mask with Pixmap parameters instead.
2197 (xg_check_special_colors): Use GtkStyleContext and its functions
2199 (xg_prepare_tooltip, xg_hide_tooltip): Call gdk_window_get_screen.
2200 (xg_prepare_tooltip, create_dialog, menubar_map_cb)
2201 (xg_update_frame_menubar, xg_tool_bar_detach_callback)
2202 (xg_tool_bar_attach_callback, xg_update_tool_bar_sizes):
2203 Call gtk_widget_get_preferred_size.
2204 (xg_frame_resized): gdk_window_get_geometry only takes 5
2206 (xg_win_to_widget, xg_event_is_for_menubar):
2207 Call gdk_x11_window_lookup_for_display.
2208 (xg_set_widget_bg): New function.
2209 (delete_cb): New function.
2210 (xg_create_frame_widgets): connect delete-event to delete_cb.
2211 Call xg_set_widget_bg. Only set backgrund pixmap for ! HAVE_GTK3
2212 (xg_set_background_color): Call xg_set_widget_bg.
2213 (xg_set_frame_icon): Call xg_get_pixbuf_from_pix_and_mask.
2214 (xg_create_scroll_bar): vadj is a GtkAdjustment for HAVE_GTK3.
2215 Only call gtk_range_set_update_policy if ! HAVE_GTK3.
2216 (xg_make_tool_item): Only connect xg_tool_bar_item_expose_callback
2218 (update_frame_tool_bar): Call gtk_widget_hide.
2219 (xg_initialize): Use GDK_KEY_g.
2221 * xsmfns.c (gdk_set_sm_client_id): Define to gdk_set_sm_client_id
2223 (x_session_initialize): Call gdk_x11_set_sm_client_id.
2225 * xterm.c (XFillRectangle): Use cairo routines for HAVE_GTK3.
2226 (x_term_init): Disable Xinput(2) with GDK_CORE_DEVICE_EVENTS.
2227 Load ~/emacs.d/gtkrc only for ! HAVE_GTK3.
2229 2011-03-08 Juanma Barranquero <lekktu@gmail.com>
2231 * w32xfns.c (select_palette): Check success of RealizePalette against
2232 GDI_ERROR, not zero.
2234 See ChangeLog.11 for earlier changes.
2240 Copyright (C) 2011 Free Software Foundation, Inc.
2242 This file is part of GNU Emacs.
2244 GNU Emacs is free software: you can redistribute it and/or modify
2245 it under the terms of the GNU General Public License as published by
2246 the Free Software Foundation, either version 3 of the License, or
2247 (at your option) any later version.
2249 GNU Emacs is distributed in the hope that it will be useful,
2250 but WITHOUT ANY WARRANTY; without even the implied warranty of
2251 MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
2252 GNU General Public License for more details.
2254 You should have received a copy of the GNU General Public License
2255 along with GNU Emacs. If not, see <http://www.gnu.org/licenses/>.