555fb9589f5f246e3c71c090cf4ecc6466b86db3
[bpt/emacs.git] / src / ChangeLog
1 2011-04-28 Juanma Barranquero <lekktu@gmail.com>
2
3 * w32.c (init_environment): Warn about defaulting HOME to C:\.
4
5 2011-04-28 Juanma Barranquero <lekktu@gmail.com>
6
7 * keyboard.c (Qdelayed_warnings_hook): Define.
8 (command_loop_1): Run `delayed-warnings-hook'
9 if Vdelayed_warnings_list is non-nil.
10 (syms_of_keyboard) <delayed-warnings-hook>: DEFSYM it.
11 (syms_of_keyboard) <delayed-warnings-list>: DEFVAR_LISP it.
12
13 2011-04-28 Eli Zaretskii <eliz@gnu.org>
14
15 * doprnt.c (doprnt): Don't return value smaller than the buffer
16 size if the message was truncated. (Bug#8545).
17
18 2011-04-28 Juanma Barranquero <lekktu@gmail.com>
19
20 * w32fns.c (Fx_change_window_property, Fx_delete_window_property)
21 (Fx_window_property): #if-0 the whole functions, not just the bodies.
22
23 2011-04-27 Paul Eggert <eggert@cs.ucla.edu>
24
25 * doprnt.c (doprnt): Support "ll" length modifier, for long long.
26
27 2011-04-27 Juanma Barranquero <lekktu@gmail.com>
28
29 * makefile.w32-in: Update dependencies.
30
31 2011-04-27 Eli Zaretskii <eliz@gnu.org>
32
33 Improve `doprnt' and its usage. (Bug#8545)
34 * doprnt.c (doprnt): Make sure `format' is never accessed beyond
35 `format_end'. Remove support for %l as a conversion specifier.
36 Don't use xrealloc. Improve diagnostics when the %l size modifier
37 is used. Update the commentary.
38
39 * eval.c (verror): Simplify calculation of size_t.
40
41 * coding.c (Ffind_operation_coding_system): Fix diagnostic error
42 messages.
43
44 2011-04-27 Yoshiaki Kasahara <kasahara@nc.kyushu-u.ac.jp> (tiny change)
45
46 * buffer.c (init_buffer) [USE_MMAP_FOR_BUFFERS]: Adjust to aliasing
47 change.
48
49 2011-04-27 Paul Eggert <eggert@cs.ucla.edu>
50
51 * nsmenu.m: Replace all uses of XVECTOR with ASIZE and AREF.
52 This makes this file independent of the recent pseudovector change.
53
54 2011-04-26 Paul Eggert <eggert@cs.ucla.edu>
55
56 * keyboard.c (handle_user_signal): Fix pointer signedness problem.
57
58 * gnutls.c (emacs_gnutls_handle_error): Remove unused local.
59 (Fgnutls_boot): gnutls_certificate_verify_peers2 wants unsigned *.
60 Remove unused local.
61 (emacs_gnutls_write): Don't use uninitialized rtnval if nbyte <= 0.
62
63 * lisp.h: Fix a problem with aliasing and vector headers. (Bug#8546)
64 GCC 4.6.0 optimizes based on type-based alias analysis. For
65 example, if b is of type struct buffer * and v of type struct
66 Lisp_Vector *, then gcc -O2 was incorrectly assuming that &b->size
67 != &v->size, and therefore "v->size = 1; b->size = 2; return
68 v->size;" must therefore return 1. This assumption is incorrect
69 for Emacs, since it type-puns struct Lisp_Vector * with many other
70 types. To fix this problem, this patch adds a new type struct
71 vectorlike_header that documents the constraints on layout of vectors
72 and pseudovectors, and helps optimizing compilers not get fooled
73 by Emacs's type punning. It also adds the macros XSETTYPED_PVECTYPE
74 XSETTYPED_PSEUDOVECTOR, TYPED_PSEUDOVECTORP, for similar reasons.
75 * lisp.h (XSETTYPED_PVECTYPE): New macro, specifying the name of
76 the size member.
77 (XSETPVECTYPE): Rewrite in terms of new macro.
78 (XSETPVECTYPESIZE): New macro, specifying both type and size.
79 This is a bit clearer, and further avoids the possibility of
80 undesirable aliasing.
81 (XSETTYPED_PSEUDOVECTOR): New macro, specifying the size.
82 (XSETPSEUDOVECTOR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR.
83 (XSETSUBR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR and XSIZE,
84 since Lisp_Subr is a special case (no "next" field).
85 (ASIZE): Now uses header.size rather than size. All
86 previous uses of XVECTOR (foo)->size replaced to use this macro,
87 to avoid the hassle of writing XVECTOR (foo)->header.size.
88 (struct vectorlike_header): New type.
89 (TYPED_PSEUDOVECTORP): New macro, also specifying the C type of the
90 object, to help avoid aliasing.
91 (PSEUDOVECTORP): Rewrite in terms of TYPED_PSEUDOVECTORP.
92 (SUBRP): Likewise, since Lisp_Subr is a special case.
93 * lisp.h (struct Lisp_Vector, struct Lisp_Char_Table):
94 (struct Lisp_Sub_Char_Table, struct Lisp_Bool_Vector):
95 (struct Lisp_Hash_Table): Combine first two members into a single
96 struct vectorlike_header member. All uses of "size" and "next" members
97 changed to be "header.size" and "header.next".
98 * buffer.h (struct buffer): Likewise.
99 * font.h (struct font_spec, struct font_entity, struct font): Likewise.
100 * frame.h (struct frame): Likewise.
101 * process.h (struct Lisp_Process): Likewise.
102 * termhooks.h (struct terminal): Likewise.
103 * window.c (struct save_window_data, struct saved_window): Likewise.
104 * window.h (struct window): Likewise.
105 * alloc.c (allocate_buffer, Fmake_bool_vector, allocate_pseudovector):
106 Use XSETPVECTYPESIZE, not XSETPVECTYPE, to avoid aliasing problems.
107 * buffer.c (init_buffer_once): Likewise.
108 * lread.c (defsubr): Use XSETTYPED_PVECTYPE, since Lisp_Subr is a
109 special case.
110 * process.c (Fformat_network_address): Use local var for size,
111 for brevity.
112
113 * bytecode.c (exec_byte_code): Don't use XVECTOR before CHECK_VECTOR.
114
115 Make the Lisp reader and string-to-float more consistent (Bug#8525)
116 * data.c (atof): Remove decl; no longer used or needed.
117 (digit_to_number): Move to lread.c.
118 (Fstring_to_number): Use new string_to_number function, to be
119 consistent with how the Lisp reader treats infinities and NaNs.
120 Do not assume that floating-point numbers represent EMACS_INT
121 without losing information; this is not true on most 64-bit hosts.
122 Avoid double-rounding errors, by insisting on integers when
123 parsing non-base-10 numbers, as the documentation specifies.
124 * lisp.h (string_to_number): New decl, replacing ...
125 (isfloat_string): Remove.
126 * lread.c: Include <inttypes.h>, for uintmax_t and strtoumax.
127 (read1): Do not accept +. and -. as integers; this
128 appears to have been a coding error. Similarly, do not accept
129 strings like +-1e0 as floating point numbers. Do not report
130 overflow for integer overflows unless the base is not 10 which
131 means we have no simple and reliable way to continue.
132 Break out the floating-point parsing into a new
133 function string_to_number, so that Fstring_to_number parses
134 floating point numbers consistently with the Lisp reader.
135 (digit_to_number): Moved here from data.c. Make it static inline.
136 (E_CHAR, EXP_INT): Remove, replacing with ...
137 (E_EXP): New macro, to solve the "1.0e+" problem mentioned below.
138 (string_to_number): New function, replacing isfloat_string.
139 This function checks for valid syntax and produces the resulting
140 Lisp float number too. Rework it so that string-to-number
141 no longer mishandles examples like "1.0e+". Use strtoumax,
142 so that overflow for non-base-10 numbers is reported only when
143 there's no portable and simple way to convert to floating point.
144
145 * textprop.c (set_text_properties_1): Rewrite for clarity,
146 and to avoid GCC warning about integer overflow.
147
148 * intervals.h (struct interval): Use EMACS_INT for members
149 where EMACS_UINT might cause problems. See
150 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html>.
151 (CHECK_TOTAL_LENGTH): Remove cast to EMACS_INT; no longer needed.
152 * intervals.c (interval_deletion_adjustment): Now returns EMACS_INT.
153 All uses changed.
154 (offset_intervals): Tell GCC not to worry about length overflow
155 when negating a negative length.
156
157 * alloc.c (overrun_check_malloc, overrun_check_realloc): Now static.
158 (overrun_check_free): Likewise.
159
160 * alloc.c (SDATA_SIZE) [!GC_CHECK_STRING_BYTES]: Avoid runtime check
161 in the common case where SDATA_DATA_OFFSET is a multiple of Emacs
162 word size.
163
164 * gnutls.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
165 (gnutls_make_error): Rename local to avoid shadowing.
166 (gnutls_emacs_global_deinit): ifdef out; not used.
167 (Fgnutls_boot): Use const for pointer to readonly storage.
168 Comment out unused local. Fix pointer signedness problems.
169
170 * lread.c (openp): Don't stuff size_t into an 'int'.
171 Use <= on length, not < on length + 1, to avoid GCC 4.6.0 warning
172 about possible signed overflow.
173
174 * gtkutil.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
175 (GDK_KEY_g): Don't define if already defined.
176 (xg_prepare_tooltip): Avoid pointer signedness problem.
177 (xg_set_toolkit_scroll_bar_thumb): Redo to avoid two casts.
178
179 * process.c (Fnetwork_interface_info): Avoid left-shift undefined
180 behavior with 1 << 31. GCC 4.6.0 warns about this on 32-bit hosts.
181
182 * xfns.c (Fx_window_property): Simplify a bit,
183 to make a bit faster and to avoid GCC 4.6.0 warning.
184 * xselect.c (x_get_window_property, x_handle_dnd_message): Likewise.
185
186 * fns.c (internal_equal): Don't assume size_t fits in int.
187
188 * alloc.c (compact_small_strings): Tighten assertion a little.
189
190 Replace pEd with more-general pI, and fix some printf arg casts.
191 * lisp.h (pI): New macro, generalizing old pEd macro to other
192 conversion specifiers. For example, use "...%"pI"d..." rather
193 than "...%"pEd"...".
194 (pEd): Remove. All uses replaced with similar uses of pI.
195 * src/m/amdx86-64.h, src/m/ia64.h, src/m/ibms390x.h: Likewise.
196 * alloc.c (check_pure_size): Don't overflow by converting size to int.
197 * bidi.c (bidi_dump_cached_states): Use pI to avoid cast.
198 * data.c (Fnumber_to_string): Use pI instead of if-then-else-abort.
199 * dbusbind.c (xd_append_arg): Use pI to avoid cast.
200 (Fdbus_method_return_internal, Fdbus_method_error_internal): Likewise.
201 * font.c (font_unparse_xlfd): Avoid potential buffer overrun on
202 64-bit hosts.
203 (font_unparse_xlfd, font_unparse_fcname): Use pI to avoid casts.
204 * keyboard.c (record_char, modify_event_symbol): Use pI to avoid casts.
205 * print.c (safe_debug_print, print_object): Likewise.
206 (print_object): Don't overflow by converting EMACS_INT or EMACS_UINT
207 to int.
208 Use pI instead of if-then-else-abort. Use %p to avoid casts,
209 avoiding the 0 flag, which is not portable.
210 * process.c (Fmake_network_process): Use pI to avoid cast.
211 * region-cache.c (pp_cache): Likewise.
212 * xdisp.c (decode_mode_spec): Likewise.
213 * xrdb.c (x_load_resources) [USE_MOTIF]: Use pI to avoid undefined
214 behavior on 64-bit hosts with printf arg.
215 * xselect.c (x_queue_event): Use %p to avoid casts, avoiding 0 flag.
216 (x_stop_queuing_selection_requests): Likewise.
217 (x_get_window_property): Don't truncate byte count to an 'int'
218 when tracing.
219
220 * frame.c (frame_name_fnn_p): Get rid of strtol, which isn't right
221 here, since it parses constructs like leading '-' and spaces,
222 which are not wanted; and it overflows with large numbers.
223 Instead, simply match F[0-9]+, which is what is wanted anyway.
224
225 * alloc.c: Remove unportable assumptions about struct layout.
226 (SDATA_SELECTOR, SDATA_DATA_OFFSET): New macros.
227 (SDATA_OF_STRING, SDATA_SIZE, allocate_string_data):
228 (allocate_vectorlike, make_pure_vector): Use the new macros,
229 plus offsetof, to remove unportable assumptions about struct layout.
230 These assumptions hold on all porting targets that I know of, but
231 they are not guaranteed, they're easy to remove, and removing them
232 makes further changes easier.
233
234 * alloc.c (BLOCK BYTES): Fix typo by changing "ablock" to "ablocks".
235 This doesn't fix a bug but makes the code clearer.
236 (string_overrun_cookie): Now const. Use initializers that
237 don't formally overflow signed char, to avoid warnings.
238 (allocate_string_data) [GC_CHECK_STRING_OVERRUN]: Fix typo that
239 can cause Emacs to crash when string overrun checking is enabled.
240 (allocate_buffer): Don't assume sizeof (struct buffer) is a
241 multiple of sizeof (EMACS_INT); it need not be, if
242 alignof(EMACS_INT) < sizeof (EMACS_INT).
243 (check_sblock, check_string_bytes, check_string_free_list): Protoize.
244
245 2011-04-26 Juanma Barranquero <lekktu@gmail.com>
246
247 * keyboard.c (QCrtl): Rename from Qrtl. All uses changed.
248
249 2011-04-26 Teodor Zlatanov <tzz@lifelogs.com>
250
251 * gnutls.c (emacs_gnutls_handshake): Return an error if we're not
252 supposed to be handshaking. (Bug#8556)
253 Reported by Paul Eggert <eggert@cs.ucla.edu>.
254
255 2011-04-26 Daniel Colascione <dan.colascione@gmail.com>
256
257 * lisp.h (Qdebug): List symbol.
258 * eval.c (Qdebug): Restore global linkage.
259 * keyboard.c (debug-on-event): New variable.
260 (handle_user_signal): Break into debugger when debug-on-event
261 matches the current signal symbol.
262
263 2011-04-25 Dan Nicolaescu <dann@ics.uci.edu>
264
265 * alloc.c (check_sblock, check_string_bytes)
266 (check_string_free_list): Convert to standard C.
267
268 2011-04-25 Teodor Zlatanov <tzz@lifelogs.com>
269
270 * w32.c (emacs_gnutls_push): Fix typo.
271
272 2011-04-25 Eli Zaretskii <eliz@gnu.org>
273
274 * gnutls.c (emacs_gnutls_handshake): Avoid compiler warnings about
275 "cast to pointer from integer of different size".
276
277 Improve doprnt and its use in verror. (Bug#8545)
278 * doprnt.c (doprnt): Document the set of format control sequences
279 supported by the function. Use SAFE_ALLOCA instead of always
280 using `alloca'.
281
282 * eval.c (verror): Don't limit the buffer size at size_max-1, that
283 is one byte too soon. Don't use xrealloc; instead xfree and
284 xmalloc anew.
285
286 2011-04-24 Teodor Zlatanov <tzz@lifelogs.com>
287
288 * gnutls.h: Add GNUTLS_STAGE_CALLBACKS enum to denote we're in the
289 callbacks stage.
290
291 * gnutls.c: Renamed global_initialized to
292 gnutls_global_initialized. Added internals for the
293 :verify-hostname-error, :verify-error, and :verify-flags
294 parameters of `gnutls-boot' and documented those parameters in the
295 docstring. Start callback support.
296 (emacs_gnutls_handshake): Add Woe32 support. Retry handshake
297 unless a fatal error occured. Call gnutls_alert_send_appropriate
298 on error. Return error code.
299 (emacs_gnutls_write): Call emacs_gnutls_handle_error.
300 (emacs_gnutls_read): Likewise.
301 (Fgnutls_boot): Return handshake error code.
302 (emacs_gnutls_handle_error): New function.
303 (wsaerror_to_errno): Likewise.
304
305 * w32.h (emacs_gnutls_pull): Add prototype.
306 (emacs_gnutls_push): Likewise.
307
308 * w32.c (emacs_gnutls_pull): New function for GnuTLS on Woe32.
309 (emacs_gnutls_push): Likewise.
310
311 2011-04-24 Claudio Bley <claudio.bley@gmail.com> (tiny change)
312
313 * process.c (wait_reading_process_output): Check if GnuTLS
314 buffered some data internally if no FDs are set for TLS
315 connections.
316
317 * makefile.w32-in (OBJ2): Add gnutls.$(O).
318 (LIBS): Link to USER_LIBS.
319 ($(BLD)/gnutls.$(0)): New target.
320
321 2011-04-24 Eli Zaretskii <eliz@gnu.org>
322
323 * xdisp.c (handle_single_display_spec): Rename the
324 display_replaced_before_p argument into display_replaced_p, to
325 make it consistent with the commentary. Fix typos in the
326 commentary.
327
328 * textprop.c (syms_of_textprop): Remove dead code.
329 (copy_text_properties): Delete obsolete commentary about an
330 interface that was deleted long ago. Fix typos in the description
331 of arguments.
332
333 * msdos.c (XMenuActivate, XMenuAddSelection): Adjust argument list
334 to changes in oldXMenu/XMenu.h from 2011-04-16.
335 <menu_help_message, prev_menu_help_message>: Constify.
336 (IT_menu_make_room): menu->help_text is now `const char **';
337 adjust.
338
339 * msdos.h (XMenuActivate, XMenuAddSelection): Adjust prototypes
340 to changes in oldXMenu/XMenu.h from 2011-04-16.
341 (struct XMenu): Declare `help_text' `const char **'.
342
343 * xfaces.c <Qunspecified>: Make extern again.
344
345 * syntax.c: Include sys/types.h before including regex.h, as
346 required by Posix.
347
348 * doc.c (get_doc_string): Improve the format passed to `error'.
349
350 * doprnt.c (doprnt): Improve commentary.
351
352 * term.c (init_tty) [MSDOS]: Fix 1st argument to maybe_fatal.
353
354 * Makefile.in (TAGS): Depend on $(M_FILE) and $(S_FILE), and scan
355 them with etags.
356
357 * makefile.w32-in (globals.h): Add a dummy recipe, to make any
358 changes in globals.h immediately force recompilation.
359 (TAGS): Depend on $(CURDIR)/m/intel386.h and
360 $(CURDIR)/s/ms-w32.h.
361 (TAGS-gmake): Scan $(CURDIR)/m/intel386.h and $(CURDIR)/s/ms-w32.h.
362
363 * character.c (Fchar_direction): Function deleted.
364 (syms_of_character): Don't defsubr it.
365 <char-direction-table>: Deleted.
366
367 2011-04-23 Eli Zaretskii <eliz@gnu.org>
368
369 Fix doprnt so it could be used again safely in `verror'. (Bug#8435)
370 * doprnt.c: Include limits.h.
371 (SIZE_MAX): New macro.
372 (doprnt): Return a size_t value. 2nd arg is now size_t. Many
373 local variables are now size_t instead of int or unsigned.
374 Improve overflow protection. Support `l' modifier for integer
375 conversions. Support %l conversion. Don't assume an EMACS_INT
376 argument for integer conversions and for %c.
377
378 * lisp.h (doprnt): Restore prototype.
379
380 * makefile.w32-in ($(BLD)/callint.$(O)): Depend on
381 $(SRC)/character.h.
382
383 * Makefile.in (base_obj): Add back doprnt.o.
384
385 * deps.mk (doprnt.o): Add back prerequisites.
386 (callint.o): Depend on character.h.
387
388 * eval.c (internal_lisp_condition_case): Include the handler
389 representation in the error message.
390 (verror): Call doprnt instead of vsnprintf. Fix an off-by-one bug
391 when breaking from the loop.
392
393 * xdisp.c (vmessage): Call doprnt instead of vsnprintf.
394
395 * callint.c (Fcall_interactively): When displaying error message
396 about invalid control letter, pass the character's codepoint, not
397 a pointer to its multibyte form. Improve display of the character
398 in octal and display also its hex code.
399
400 * character.c (char_string): Use %x to display the (unsigned)
401 codepoint of an invalid character, to avoid displaying a bogus
402 negative value.
403
404 * font.c (check_otf_features): Pass SDATA of SYMBOL_NAME to
405 `error', not SYMBOL_NAME itself.
406
407 * coding.c (Fencode_sjis_char, Fencode_big5_char): Use %c for
408 character arguments to `error'.
409
410 * charset.c (check_iso_charset_parameter): Fix incorrect argument
411 to `error' in error message about FINAL_CHAR argument. Make sure
412 FINAL_CHAR is a character, and use %c when it is passed as
413 argument to `error'.
414
415 2011-04-23 Eli Zaretskii <eliz@gnu.org>
416
417 * s/ms-w32.h (localtime): Redirect to sys_localtime.
418
419 * w32.c: Include <time.h>.
420 (sys_localtime): New function.
421
422 2011-04-23 Chong Yidong <cyd@stupidchicken.com>
423
424 * xdisp.c (init_xdisp): Initialize echo_area_window (Bug#6451).
425
426 * buffer.c (syms_of_buffer): Doc fix (Bug#6902).
427
428 2011-04-23 Samuel Thibault <sthibault@debian.org> (tiny change)
429
430 * sysdep.c (wait_for_termination): On GNU Hurd, kill returns -1 on
431 zombies (Bug#8467).
432
433 2011-04-19 Eli Zaretskii <eliz@gnu.org>
434
435 * syntax.h (SETUP_SYNTAX_TABLE_FOR_OBJECT): Fix setting of
436 gl_state.e_property when gl_state.object is Qt.
437
438 * insdel.c (make_gap_larger): Remove limitation of buffer size
439 to <= INT_MAX.
440
441 2011-04-18 Chong Yidong <cyd@stupidchicken.com>
442
443 * xdisp.c (lookup_glyphless_char_display)
444 (produce_glyphless_glyph): Handle cons cell entry in
445 glyphless-char-display.
446 (Vglyphless_char_display): Document it.
447
448 * term.c (produce_glyphless_glyph): Handle cons cell entry in
449 glyphless-char-display.
450
451 2011-04-17 Chong Yidong <cyd@stupidchicken.com>
452
453 * xdisp.c (get_next_display_element): Remove unnecessary ifdefs.
454
455 * termhooks.h (FRAME_WINDOW_P): Remove duplicated definitions.
456
457 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): Add missing
458 definition for no-X builds.
459
460 2011-04-16 Paul Eggert <eggert@cs.ucla.edu>
461
462 Static checks with GCC 4.6.0 and non-default toolkits.
463
464 * s/sol2-6.h, s/unixware.h (PTY_TTY_NAME_SPRINTF): Protoize decl.
465
466 * process.c (keyboard_bit_set): Define only if SIGIO.
467 (send_process_trap): Mark it with NO_RETURN if it doesn't return.
468 (send_process): Repair possible setjmp clobbering.
469
470 * s/usg5-4-common.h (SETUP_SLAVE_PTY): Don't pass extra arg to 'fatal'.
471
472 * eval.c: Include <stdio.h>, for vsnprintf on non-GNU/Linux hosts.
473
474 * data.c (arith_error): Mark with NO_RETURN if it doesn't return.
475
476 * alloc.c (bytes_used_when_full, SPARE_MEMORY, BYTES_USED):
477 Define only if needed.
478
479 * sysdep.c (_FILE_OFFSET_BITS): Make this hack even uglier
480 by pacifying GCC about it. Maybe it's time to retire it?
481 * xfaces.c (USG, __TIMEVAL__): Likewise.
482
483 * dispextern.h (struct redisplay_interface): Rename param
484 to avoid shadowing.
485 * termhooks.h (struct terminal): Likewise.
486 * xterm.c (xembed_send_message): Likewise.
487
488 * insdel.c (make_gap_smaller): Define only if
489 USE_MMAP_FOR_BUFFERS || REL_ALLOC || DOUG_LEA_MALLOC.
490
491 * keyboard.c (read_char): Make a var volatile so longjmp won't clobber
492 it.
493
494 * emacs.c (MAX_HEAP_BSS_DIFF, my_edata): Move to where they're used,
495 so that we aren't warned about unused symbols.
496
497 * xfns.c (Fx_file_dialog): Rename local to avoid shadowing.
498
499 * xdisp.c (x_produce_glyphs): Mark var as initialized (Bug#8512).
500
501 * xfns.c (x_real_positions): Mark locals as initialized.
502
503 * xmenu.c (xmenu_show): Don't use uninitialized vars.
504
505 * xterm.c: Fix problems found by static analysis with other toolkits.
506 (toolkit_scroll_bar_interaction): Define and use only if USE_X_TOOLKIT.
507 (x_dispatch_event): Declare static if USE_GTK, and
508 define if USE_GTK || USE_X_TOOLKIT.
509 (SET_SAVED_BUTTON_EVENT): Define only if USE_X_TOOLKIT || USE_GTK.
510 * xterm.h (x_dispatch_event): Extern only if USE_X_TOOLKIT.
511 * xterm.c, xterm.h (x_mouse_leave): Bring this function back, but only
512 if defined HAVE_MENUS && !defined USE_X_TOOLKIT && !defined USE_GTK.
513
514 * xmenu.c (menu_help_callback): Pointer type fixes.
515 Use const pointers when pointing at readonly data. Avoid pointer
516 signedness clashes.
517 (FALSE): Remove unused macro.
518 (update_frame_menubar): Remove unused decl.
519
520 * xfns.c (Fx_hide_tip): Move locals to avoid shadowing.
521
522 * menu.c (push_submenu_start, push_submenu_end): Do not define unless
523 USE_X_TOOLKIT || USE_GTK || HAVE_NS || defined HAVE_NTGUI.
524 (single_menu_item): Rename local to avoid shadowing.
525
526 * keyboard.c (make_lispy_event): Remove unused local var.
527
528 * frame.c, frame.h (x_get_resource_string): Bring this back, but
529 only if HAVE_X_WINDOWS && !USE_X_TOOLKIT.
530
531 * bitmaps: Change bitmaps from unsigned char back to the X11
532 compatible char. Avoid the old compiler warnings about
533 out-of-range initializers by using, for example, '\xab' rather
534 than 0xab.
535
536 * xgselect.c (xgselect_initialize): Check vs interface
537 even if ! (defined (USE_GTK) || defined (HAVE_GCONF)).
538
539 * xmenu.c (xmenu_show): Rename parm to avoid shadowing.
540
541 * xterm.c (x_create_toolkit_scroll_bar): Use const * for pointers
542 to read-only memory.
543
544 * fns.c (vector): Remove; this old hack is no longer needed.
545
546 * xsmfns.c (create_client_leader_window): Rename shadowing arg.
547 Remove unused var.
548 (gdk_x11_set_sm_client_id) [!USE_GTK]: Don't define.
549
550 * xrdb.c (x_load_resources): Omit unused local.
551
552 * xfns.c (free_frame_menubar, atof): Remove duplicate decls.
553 (x_window): Rename locals to avoid shadowing.
554 (USG): Use the kludged USG macro, to pacify gcc.
555
556 * xterm.c (x_alloc_nearest_color_for_widget): Remove; unused.
557 (x_term_init): Remove local to avoid shadowing.
558
559 * xfns.c, xterm.c (_XEditResCheckMessages): Protoize decl.
560
561 * xdisp.c, dispextern.h (set_vertical_scroll_bar): Now extern if
562 USE_TOOLKIT_SCROLL_BARS && !USE_GTK, as xterm.c needs it then.
563
564 2011-04-16 Eli Zaretskii <eliz@gnu.org>
565
566 * gnutls.c (Fgnutls_boot): Don't pass Lisp_Object to `error'.
567
568 Fix regex.c, syntax.c and friends for buffers > 2GB.
569 * syntax.h (struct gl_state_s): Declare character position members
570 EMACS_INT.
571
572 * syntax.c (update_syntax_table): Declare 2nd argument EMACS_INT.
573
574 * textprop.c (verify_interval_modification, interval_of): Declare
575 arguments EMACS_INT.
576
577 * intervals.c (adjust_intervals_for_insertion): Declare arguments
578 EMACS_INT.
579
580 * intervals.h (CHECK_TOTAL_LENGTH): Cast to EMACS_INT, not `int'.
581
582 * indent.c (Fvertical_motion): Local variable it_start is now
583 EMACS_INT.
584
585 * regex.c (re_match, re_match_2, re_match_2_internal)
586 (bcmp_translate, regcomp, regexec, print_double_string)
587 (group_in_compile_stack, re_search, re_search_2, regex_compile)
588 (re_compile_pattern, re_exec): Declare arguments and local
589 variables `size_t' and `ssize_t' and return values `regoff_t', as
590 appropriate.
591 (POP_FAILURE_REG_OR_COUNT) <pfreg>: Declare `long'.
592 (CHECK_INFINITE_LOOP) <failure>: Declare `ssize_t'.
593 <compile_stack_type>: `size' and `avail' are now `size_t'.
594
595 * regex.h <regoff_t>: Use ssize_t, not int.
596 (re_search, re_search_2, re_match, re_match_2): Arguments that
597 specify buffer/string position and length are now ssize_t and
598 size_t. Return type is regoff_t.
599
600 2011-04-16 Ben Key <bkey76@gmail.com>
601
602 * nsfont.m: Fixed bugs in ns_get_family and
603 ns_descriptor_to_entity that were caused by using free to
604 deallocate memory blocks that were allocated by xmalloc (via
605 xstrdup). This caused Emacs to crash when compiled with
606 XMALLOC_OVERRUN_CHECK defined (when Emacs was configured with
607 --enable-checking=xmallocoverrun). xfree is now used to
608 deallocate these memory blocks.
609
610 2011-04-15 Paul Eggert <eggert@cs.ucla.edu>
611
612 * sysdep.c (emacs_read): Remove unnecessary check vs MAX_RW_COUNT.
613
614 emacs_write: Accept and return EMACS_INT for sizes.
615 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html
616 et seq.
617 * gnutls.c, gnutls.h (emacs_gnutls_read, emacs_gnutls_write):
618 Accept and return EMACS_INT.
619 (emacs_gnutls_write): Return the number of bytes written on
620 partial writes.
621 * sysdep.c, lisp.h (emacs_read, emacs_write): Likewise.
622 (emacs_read, emacs_write): Remove check for negative size, as the
623 Emacs source code has been audited now.
624 * sysdep.c (MAX_RW_COUNT): New macro, to work around kernel bugs.
625 (emacs_read, emacs_write): Use it.
626 * process.c (send_process): Adjust to the new signatures of
627 emacs_write and emacs_gnutls_write. Do not attempt to store
628 a byte offset into an 'int'; it might overflow.
629 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00483.html
630
631 * sound.c: Don't assume sizes fit in 'int'.
632 (struct sound_device.period_size, alsa_period_size):
633 Return EMACS_INT, not int.
634 (struct sound_device.write, vox_write, alsa_write):
635 Accept EMACS_INT, not int.
636 (wav_play, au_play): Use EMACS_INT to store sizes and to
637 record read return values.
638
639 2011-04-15 Ben Key <bkey76@gmail.com>
640
641 * keyboard.c (Qundefined): Don't declare static since it is used
642 in nsfns.m.
643 * xfaces.c (Qbold, Qexpanded, Qitalic, Qcondensed): Don't declare
644 static since they are used in nsfont.m.
645
646 2011-04-15 Stefan Monnier <monnier@iro.umontreal.ca>
647
648 * process.c (Qprocessp): Don't declare static.
649 * lisp.h (Qprocessp): Declare again.
650
651 2011-04-15 Juanma Barranquero <lekktu@gmail.com>
652
653 * font.c (Qopentype): Don't make static (used from w32uniscribe.c).
654
655 2011-04-14 Paul Eggert <eggert@cs.ucla.edu>
656
657 Improve C-level modularity by making more things 'static'.
658
659 Don't publish debugger-only interfaces to other modules.
660 * lisp.h (safe_debug_print, debug_output_compilation_hack):
661 (verify_bytepos, count_markers): Move decls to the only modules
662 that need them.
663 * region-cache.h (pp_cache): Likewise.
664 * window.h (check_all_windows): Likewise.
665 * marker.c, print.c, region-cache.c, window.c: Decls moved here.
666
667 * sysdep.c (croak): Now static, if
668 defined TIOCNOTTY || defined USG5 || defined CYGWIN.
669 * syssignal.h (croak): Declare only if not static.
670
671 * alloc.c (refill_memory_reserve): Now static if
672 !defined REL_ALLOC || defined SYSTEM_MALLOC.
673 * lisp.h (refill_memory_reserve): Declare only if not static.
674
675 * xsettings.c, xsettings.h (xsettings_get_system_normal_font):
676 Define only if USE_LUCID.
677
678 * xrdb.c (x_customization_string, x_rm_string): Now static.
679
680 * xmenu.c (x_menu_wait_for_event): Export only if USE_MOTIF.
681 * xterm.h (x_menu_wait_for_event): Declare only if USE_MOTIF.
682
683 * xdisp.c (draw_row_with_mouse_face): Now static.
684 * dispextern.h (draw_row_with_mouse_fave): Remove decl.
685
686 * window.h (check_all_windows): Mark externally visible.
687
688 * window.c (window_deletion_count): Now static.
689
690 * undo.c: Make symbols static if they're not exported.
691 (last_undo_buffer, last_boundary_position, pending_boundary):
692 Now static.
693
694 * textprop.c (interval_insert_behind_hooks): Now static.
695 (interval_insert_in_front_hooks): Likewise.
696
697 * term.c: Make symbols static if they're not exported.
698 (tty_turn_off_highlight, get_tty_terminal, max_frame_cols):
699 (max_frame_lines, tty_set_terminal_modes):
700 (tty_reset_terminal_modes, tty_turn_off_highlight):
701 (get_tty_terminal): Now static.
702 (term_mouse_moveto): Do not define if HAVE_WINDOW_SYSTEM.
703 * termhooks.h (term_mouse_moveto): Do not declare if
704 HAVE_WINDOW_SYSTEM.
705 * dispextern.h (tty_set_terminal_modes, tty_reset_terminal_modes):
706 (tty_turn_off_highlight, get_tty_terminal): Remove decls.
707
708 * sysdep.c: Make symbols static if they're not exported.
709 (emacs_get_tty, emacs_set_tty, old_fcntl_flags, old_fcntl_owner):
710 Now static.
711 (sigprocmask_set, full_mask): Remove; unused.
712 (wait_debugging): Mark as visible.
713 * syssignal.h (SIGFULLMASK, full_mask): Remove decls.
714 * systty.h (emacs_get_tty, emacs_set_tty): Remove decls.
715
716 * syntax.c (syntax_temp): Define only if !__GNUC__.
717
718 * sound.c (current_sound_device, current_sound): Now static.
719
720 * search.c (searchbufs, searchbuf_head): Now static.
721
722 * scroll.c (scroll_cost): Remove; unused.
723 * dispextern.h (scroll_cost): Remove decl.
724
725 * region-cache.h (pp_cache): Mark as externally visible.
726
727 * process.c: Make symbols static if they're not exported.
728 (process_tick, update_tick, create_process, chan_process):
729 (Vprocess_alist, proc_buffered_char, datagram_access):
730 (fd_callback_data, send_process_frame, process_sent_to): Now static.
731 (deactivate_process): Mark defn as static, as well as decl.
732 * lisp.h (create_process): Remove decl.
733 * process.h (chan_process, Vprocess_alist): Remove decls.
734
735 * print.c: Make symbols static if they're not exported.
736 (print_depth, new_backquote_output, being_printed, print_buffer):
737 (print_buffer_size, print_buffer_pos, print_buffer_pos_byte):
738 (print_interval, print_number_index, initial_stderr_stream):
739 Now static.
740 * lisp.h (Fprinc): Remove decl.
741 (debug_output_compilation_hack): Mark as externally visible.
742
743 * sysdep.c (croak): Move decl from here to syssignal.h.
744 * syssignal.h (croak): Put it here, so the API can be checked when
745 'croak' is called from dissociate_if_controlling_tty.
746
747 * minibuf.c: Make symbols static if they're not exported.
748 (minibuf_save_list, choose_minibuf_frame): Now static.
749 * lisp.h (choose_minibuf_frame): Remove decl.
750
751 * lisp.h (verify_bytepos, count_markers): Mark as externally visible.
752
753 * lread.c: Make symbols static if they're not exported.
754 (read_objects, initial_obarray, oblookup_last_bucket_number):
755 Now static.
756 (make_symbol): Remove; unused.
757 * lisp.h (initial_obarray, make_symbol): Remove decls.
758
759 * keyboard.c: Make symbols static if they're not exported.
760 (single_kboard, recent_keys_index, total_keys, recent_keys):
761 (this_command_key_count_reset, raw_keybuf, raw_keybuf_count):
762 (this_single_command_key_start, echoing, last_auto_save):
763 (read_key_sequence_cmd, dribble, recursive_edit_unwind):
764 (command_loop, echo_now, keyboard_init_hook, help_char_p):
765 (quit_throw_to_read_char, command_loop_2, top_level_1, poll_timer):
766 (Vlispy_mouse_stem, double_click_count):
767 Now static.
768 (force_auto_save_soon): Define only if SIGDANGER.
769 (ignore_mouse_drag_p): Now static if
770 !defined HAVE_WINDOW_SYSTEM || defined USE_GTK || defined HAVE_NS.
771 (print_help): Remove; unused.
772 (stop_character, last_timer_event): Mark as externally visible.
773 * keyboard.h (ignore_mouse_drag_p): Declare only if
774 defined HAVE_WINDOW_SYSTEM && !defined USE_GTK && !defined HAVE_NS.
775 (echo_now, help_char_p, quit_throw_to_read_char): Remove decls.
776 * lisp.h (echoing): Remove decl.
777 (force_auto_save_soon): Declare only if SIGDANGER.
778 * xdisp.c (redisplay_window): Simplify code, to make it more
779 obvious that ignore_mouse_drag_p is not accessed if !defined
780 USE_GTK && !defined HAVE_NS.
781
782 * intervals.c: Make symbols static if they're not exported.
783 (merge_properties_sticky, merge_interval_right, delete_interval):
784 Now static.
785 * intervals.h (merge_interval_right, delete_interval): Remove decls.
786
787 * insdel.c: Make symbols static if they're not exported.
788 However, leave prepare_to_modify_buffer alone. It's never
789 called from outside this function, but that appears to be a bug.
790 (combine_after_change_list, combine_after_change_buffer):
791 (adjust_after_replace, signal_before_change): Now static.
792 (adjust_after_replace_noundo): Remove; unused.
793 * lisp.h (adjust_after_replace, adjust_after_replace_noundo):
794 (signal_before_change): Remove decls.
795
796 * indent.c (val_compute_motion, val_vmotion): Now static.
797
798 * image.c: Make symbols static if they're not exported.
799 * dispextern.h (x_create_bitmap_from_xpm_data): Do not declare
800 if USE_GTK.
801 * image.c (x_create_bitmap_from_xpm_data): Do not define if USE_GTK.
802 (xpm_color_cache, ct_table, ct_colors_allocated): Now static.
803
804 * fringe.c (standard_bitmaps): Now static.
805 (max_used_fringe_bitmap): Now static, unless HAVE_NS.
806
807 * frame.c: Make symbols static if they're not exported.
808 (x_report_frame_params, make_terminal_frame): Now static.
809 (get_frame_param): Now static, unless HAVE_NS.
810 (x_fullscreen_adjust): Define if WINDOWSNT, not if HAVE_WINDOW_SYSTEM.
811 (x_get_resource_string): Remove; not used.
812 * frame.h (make_terminal_frame, x_report_frame_params):
813 (x_get_resource_string); Remove decls.
814 (x_fullscreen_adjust): Declare only if WINDOWSNT.
815 * lisp.h (get_frame_param): Declare only if HAVE_NS.
816
817 * font.c, fontset.c: Make symbols static if they're not exported.
818 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): New macro.
819 (FACE_SUITABLE_FOR_CHAR_P): Use it.
820 * font.c (font_close_object): Now static.
821 * font.h (font_close_object): Remove.
822 * fontset.c (FONTSET_OBJLIST): Remove.
823 (free_realized_fontset) #if-0 the body, which does nothing.
824 (face_suitable_for_char_p): #if-0, as it's never called.
825 * fontset.h (face_suitable_for_char_p): Remove decl.
826 * xfaces.c (face_at_string_position): Use
827 FACE_SUITABLE_FOR_ASCII_CHAR_P, not FACE_SUITABLE_FOR_CHAR_P,
828 since 0 is always ASCII.
829
830 * fns.c (weak_hash_tables): Now static.
831
832 * fileio.c: Make symbols static if they're not exported.
833 (auto_saving, auto_save_mode_bits, auto_save_error_occurred):
834 (Vwrite_region_annotation_buffers): Now static.
835
836 * eval.c: Make symbols static if they're not exported.
837 (backtrace_list, lisp_eval_depth, when_entered_debugger): Now static.
838 * lisp.h (backtrace_list): Remove decl.
839
840 * emacs.c: Make symbols static if they're not exported.
841 (malloc_state_ptr, malloc_using_checking, syms_of_emacs):
842 (fatal_error_code, fatal_error_signal_hook, standard_args):
843 Now static.
844 (fatal_error_signal): Now static, unless FLOAT_CATCH_SIGKILL.
845 (DEFINE_DUMMY_FUNCTION): Mark function as externally visible.
846 (__CTOR_LIST__, __DTOR_LIST__): Now externally visible.
847 * lisp.h (fatal_error_signal_hook): Remove decl.
848 (fatal_error_signal): Declare only if FLOAT_CATCH_SIGKILL.
849
850 * editfns.c: Move a (normally-unused) function to its only use.
851 * editfns.c, lisp.h (get_operating_system_release): Remove.
852 * process.c (init_process) [DARWIN_OS]: Do it inline, as it is not
853 worth the hassle of breaking this out.
854
855 * xterm.c: Make symbols static if they're not exported.
856 (x_raise_frame, x_lower_frame, x_wm_set_window_state):
857 (x_wm_set_icon_pixmap, x_initialize, XTread_socket_fake_io_error):
858 (x_destroy_window, x_delete_display):
859 Now static.
860 (x_dispatch_event): Now static if ! (USE_MOTIF || USE_X_TOOLKIT).
861 (x_mouse_leave): Remove; unused.
862 * xterm.h (x_display_info_for_name, x_raise_frame, x_lower_frame):
863 (x_destroy_window, x_wm_set_window_state, x_wm_set_icon_pixmap):
864 (x_delete_display, x_initialize, x_set_border_pixel, x_screen_planes):
865 Remove decls.
866 (x_mouse_leave): Declare only if WINDOWSNT.
867 (x_dispatch_event): Declare only if USE_MOTIF or USE_X_TOOLKIT.
868 (xic_create_fontsetname): Declare only if HAVE_X_WINDOWS &&
869 USE_X_TOOLKIT.
870
871 * ftxfont.c: Make symbols static if they're not exported.
872 (ftxfont_driver): Export only if !defined HAVE_XFT && def8ined
873 HAVE_FREETYPE.
874 * font.h (ftxfont_driver): Likewise.
875
876 * xfns.c: Make symbols static if they're not exported.
877 (x_last_font_name, x_display_info_for_name):
878 (x_set_foreground_color, x_set_background_color, x_set_mouse_color):
879 (x_set_cursor_color, x_set_border_pixel, x_set_border_color):
880 (x_set_cursor_type, x_set_icon_type, x_set_icon_name):
881 (x_set_scroll_bar_foreground, x_set_scroll_bar_background):
882 (x_explicitly_set_name, x_set_title, xic_defaut_fontset, tip_timer):
883 (last_show_tip_args): Now static.
884 (xic_defaut_fontset, xic_create_fontsetname): Define only if
885 defined HAVE_X_WINDOWS && defined USE_X_TOOLKIT
886 (x_screen_planes): Remove; unused.
887 * dispextern.h (x_screen_planes): Remove decl.
888
889 * dispnew.c: Make symbols static if they're not exported.
890 * dispextern.h (redraw_garbaged_frames, scrolling):
891 (increment_row_positions): Remove.
892 * dispnew.c (new_glyph_matrix, increment_row_positions, scrolling):
893 (delayed_size_change, glyph_matrix_count, glyph_pool_count):
894 Now static.
895 (redraw_garbaged_frames): Remove; unused.
896
897 * xfaces.c: Make symbols static if they're not exported.
898 * dispextern.h (ascii_face_of_lisp_face, free_realized_face):
899 Remove decls.
900 * xterm.h (defined_color): Remove decls.
901 (x_free_dpy_colors): Declare only if USE_X_TOOLKIT.
902 * xfaces.c (tty_suppress_bold_inverse_default_colors_p):
903 (menu_face_changed_default, defined_color, free_realized_face):
904 (x_free_dpy_colors): Define only if USE_X_TOOLKIT.
905 (ascii_face_of_lisp_face): Remove; unused.
906
907 * xdisp.c: Make symbols static if they're not exported.
908 * dispextern.h (scratch_glyph_row, window_box_edges):
909 (glyph_to_pixel_coords, set_cursor_from_row):
910 (get_next_display_element, set_iterator_to_next):
911 (highlight_trailing_whitespace, frame_to_window_pixel_xy):
912 (show_mouse_face): Remove decls
913 * frame.h (message_buf_print): Likewise.
914 * lisp.h (pop_message, set_message, check_point_in_composition):
915 Likewise.
916 * xterm.h (set_vertical_scroll_bar): Likewise.
917 * xdisp.c (list_of_error, Vmessage_stack, line_number_displayed):
918 (message_buf_print, scratch_glyph_row, displayed_buffer):
919 (set_iterator_to_next, pop_message, set_message, set_cursor_from_row):
920 (get_next_display_element, show_mouse_face, window_box_edges):
921 (frame_to_window_pixel_xy, check_point_in_composition):
922 (set_vertical_scroll_bar, highlight_trailing_whitespace): Now static.
923 (glyph_to_pixel_coords): Remove; unused.
924
925 * dired.c (file_name_completion): Now static.
926
927 * dbusbind.c (xd_in_read_queued_messages): Now static.
928
929 * lisp.h (circular_list_error, FOREACH): Remove; unused.
930 * data.c (circular_list_error): Remove.
931
932 * commands.h (last_point_position, last_point_position_buffer):
933 (last_point_position_window): Remove decls.
934 * keyboard.c: Make these variables static.
935
936 * coding.h (coding, code_convert_region, encode_coding_gap): Remove
937 decls.
938 * coding.c (Vsjis_coding_system, Vbig5_coding_system):
939 (iso_code_class, detect_coding, code_convert_region): Now static.
940 (encode_coding_gap): Remove; unused.
941
942 * chartab.c (chartab_chars, chartab_bits): Now static.
943
944 * charset.h (charset_iso_8859_1): Remove decl.
945 * charset.c (charset_iso_8859_1, charset_emacs, map_charset_for_dump):
946 Now static.
947
948 * ccl.h (check_ccl_update, Vccl_program_table): Remove decls.
949 * ccl.c (Vccl_program_table): Now static.
950 (check_ccl_update): Remove; unused.
951
952 * category.c (SET_CATEGORY_SET, set_category_set): Move here.
953 * category.h: ... from here.
954 * category.c (check_category_table, set_category_set): Now static.
955
956 * casetab.c (Vascii_upcase_table, Vascii_eqv_table): Now static.
957 * lisp.h: Remove these decls.
958
959 * buffer.c (buffer_count): Remove unused var.
960
961 * bidi.c (bidi_dump_cached_states): Mark as externally visible,
962 so that it's not optimized away.
963 (bidi_ignore_explicit_marks_for_paragraph_level): Likewise.
964 * dispextern.h (bidi_dump_cached_states): Remove, since it's
965 exported only to the debugger.
966
967 * atimer.c (alarm_signal_handler, run_all_atimers): Now static.
968 * atimer.h (run_all_atimers): Removed; not exported.
969
970 font.c: Make copy_font_spec and merge_font_spec ordinary C functions.
971 * font.c (copy_font_spec): Rename from Fcopy_font_spec, since it
972 was inaccessible from Lisp.
973 (merge_font_spec): Likewise, renaming from Fmerge_font_spec.
974 * font.c, font.h, fontset.c, xfaces.c, xfont.c: Change all uses.
975
976 alloc.c: Import and export fewer symbols, and remove unused items.
977 * lisp.h (suppress_checking, die): Declare only if ENABLE_CHECKING
978 is defined.
979 (suppress_checking): Add EXTERNALLY_VISIBLE attribute, so that
980 it's not optimized away by whole-program optimization.
981 (message_enable_multibyte, free_misc): Remove.
982 (catchlist, handlerlist, mark_backtrace):
983 Declare only if BYTE_MARK_STACK.
984 (mark_byte_stack): Likewise, fixing a ifdef-vs-if typo.
985 * alloc.c (pure): Export only if VIRT_ADDR_VARIES is defined.
986 (message_enable_multibyte): Remove decl.
987 (free_misc, interval_free_list, float_block, float_block_index):
988 (n_float_blocks, float_free_list, cons_block, cons_block_index):
989 (cons_free_list, last_marked_index):
990 Now static.
991 (suppress_checking, die): Define only if ENABLE_CHECKING is defined.
992 * eval.c (catchlist, handlerlist): Export only if BYTE_MARK_STACK.
993 (mark_backtrace): Define only if BYTE_MARK_STACK.
994 * xdisp.c (message_enable_multibyte): Now static.
995
996 Declare Lisp_Object Q* variables to be 'static' if not exported.
997 This makes it easier for human readers (and static analyzers)
998 to see whether these variables are used from other modules.
999 * alloc.c, buffer.c, bytecode.c, callint.c, casetab.c, category.c:
1000 * ccl.c, character.c, charset.c, cmds.c, coding.c, composite.c:
1001 * data.c, dbusbind.c, dired.c, editfns.c, eval.c, fileio.c, fns.c:
1002 * font.c, frame.c, fringe.c, ftfont.c, image.c, keyboard.c, keymap.c:
1003 * lread.c, macros.c, minibuf.c, print.c, process.c, search.c:
1004 * sound.c, syntax.c, textprop.c, window.c, xdisp.c, xfaces.c, xfns.c:
1005 * xmenu.c, xselect.c:
1006 Declare Q* vars static if they are not used in other modules.
1007 * ccl.h, character.h, charset.h, coding.h, composite.h, font.h:
1008 * frame.h, intervals.h, keyboard.h, lisp.h, process.h, syntax.h:
1009 Remove decls of unexported vars.
1010 * keyboard.h (EVENT_HEAD_UNMODIFIED): Remove now-unused macro.
1011
1012 * lisp.h (DEFINE_FUNC): Make sname 'static'.
1013
1014 Make Emacs functions such as Fatom 'static' by default.
1015 This makes it easier for human readers (and static analyzers)
1016 to see whether these functions can be called from other modules.
1017 DEFUN now defines a static function. To make the function external
1018 so that it can be used in other C modules, use the new macro DEFUE.
1019 * lisp.h (Funibyte_char_to_multibyte, Fsyntax_table_p):
1020 (Finit_image_library):
1021 (Feval_region, Fbacktrace, Ffetch_bytecode, Fswitch_to_buffer):
1022 (Ffile_executable_p, Fmake_symbolic_link, Fcommand_execute):
1023 (Fget_process, Fdocumentation_property, Fbyte_code, Ffile_attributes):
1024 Remove decls, since these functions are now static.
1025 (Funintern, Fget_internal_run_time): New decls, since these functions
1026 were already external.
1027
1028 * alloc.c, buffer.c, callint.c, callproc.c, casefiddle.c, casetab.c:
1029 * ccl.c, character.c, chartab.c, cmds.c, coding.c, data.c, dispnew.c:
1030 * doc.c, editfns.c, emacs.c, eval.c, fileio.c, filelock.c, floatfns.c:
1031 * fns.c, font.c, fontset.c, frame.c, image.c, indent.c:
1032 * keyboard.c, keymap.c, lread.c:
1033 * macros.c, marker.c, menu.c, minibuf.c, print.c, process.c, search.c:
1034 * syntax.c, term.c, terminal.c, textprop.c, undo.c:
1035 * window.c, xdisp.c, xfaces.c, xfns.c, xmenu.c, xsettings.c:
1036 Mark functions with DEFUE instead of DEFUN,
1037 if they are used in other modules.
1038 * buffer.c (Fset_buffer_major_mode, Fdelete_overlay): New forward
1039 decls for now-static functions.
1040 * buffer.h (Fdelete_overlay): Remove decl.
1041 * callproc.c (Fgetenv_internal): Mark as internal.
1042 * composite.c (Fremove_list_of_text_properties): Remove decl.
1043 (Fcomposition_get_gstring): New forward static decl.
1044 * composite.h (Fcomposite_get_gstring): Remove decl.
1045 * dired.c (Ffile_attributes): New forward static decl.
1046 * doc.c (Fdocumntation_property): New forward static decl.
1047 * eval.c (Ffetch_bytecode): New forward static decl.
1048 (Funintern): Remove extern decl; now in .h file where it belongs.
1049 * fileio.c (Fmake_symbolic_link): New forward static decl.
1050 * image.c (Finit_image_library): New forward static decl.
1051 * insdel.c (Fcombine_after_change_execute): Make forward decl static.
1052 * intervals.h (Fprevious_property_change):
1053 (Fremove_list_of_text_properties): Remove decls.
1054 * keyboard.c (Fthis_command_keys): Remove decl.
1055 (Fcommand_execute): New forward static decl.
1056 * keymap.c (Flookup_key): New forward static decl.
1057 (Fcopy_keymap): Now static.
1058 * keymap.h (Flookup_key): Remove decl.
1059 * process.c (Fget_process): New forward static decl.
1060 (Fprocess_datagram_address): Mark as internal.
1061 * syntax.c (Fsyntax_table_p): New forward static decl.
1062 (skip_chars): Remove duplicate decl.
1063 * textprop.c (Fprevious_property_change): New forward static decl.
1064 * window.c (Fset_window_fringes, Fset_window_scroll_bars):
1065 Now internal.
1066 (Fset_window_margins, Fset_window_vscroll): New forward static decls.
1067 * window.h (Fset_window_vscroll, Fset_window_margins): Remove decls.
1068
1069 * editfns.c (Fformat): Remove unreachable code.
1070
1071 2011-04-14 Andreas Schwab <schwab@linux-m68k.org>
1072
1073 * fileio.c (Finsert_file_contents): Fix typo in 2005-05-13
1074 change. (Bug#8496)
1075
1076 2011-04-13 Eli Zaretskii <eliz@gnu.org>
1077
1078 * xdisp.c (handle_invisible_prop): Don't call bidi_paragraph_init
1079 when at ZV. (Bug#8487)
1080
1081 2011-04-12 Andreas Schwab <schwab@linux-m68k.org>
1082
1083 * charset.c (Fclear_charset_maps): Use xfree instead of free.
1084 (Bug#8437)
1085 * keyboard.c (parse_tool_bar_item): Likewise.
1086 * sound.c (sound_cleanup, alsa_close): Likewise.
1087 * termcap.c (tgetent): Likewise.
1088 * xfns.c (x_default_font_parameter): Likewise.
1089 * xsettings.c (read_and_apply_settings): Likewise.
1090
1091 * alloc.c (overrun_check_malloc, overrun_check_realloc)
1092 (overrun_check_free): Protoize.
1093
1094 2011-04-12 Paul Eggert <eggert@cs.ucla.edu>
1095
1096 * sysdep.c (emacs_read, emacs_write): Check for negative sizes
1097 since callers should never pass a negative size.
1098 Change the signature to match that of plain 'read' and 'write'; see
1099 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00397.html>.
1100 * lisp.h: Update prototypes of emacs_write and emacs_read.
1101
1102 2011-04-11 Eli Zaretskii <eliz@gnu.org>
1103
1104 * xdisp.c (redisplay_window): Don't try to determine the character
1105 position of the scroll margin if the window start point w->startp
1106 is outside the buffer's accessible region. (Bug#8468)
1107
1108 2011-04-10 Eli Zaretskii <eliz@gnu.org>
1109
1110 Fix write-region and its subroutines for buffers > 2GB.
1111 * fileio.c (a_write, e_write): Modify declaration of arguments and
1112 local variables to support buffers larger than 2GB.
1113 (Fcopy_file): Use EMACS_INT for return value of emacs_read.
1114
1115 * sysdep.c (emacs_write, emacs_read): Use ssize_t for last
1116 argument, local variables, and return value.
1117
1118 * lisp.h: Update prototypes of emacs_write and emacs_read.
1119
1120 * sound.c (vox_write): Use ssize_t for return value of emacs_write.
1121
1122 2011-04-10 Paul Eggert <eggert@cs.ucla.edu>
1123
1124 * xdisp.c (vmessage): Use memchr, not strnlen, which some hosts lack.
1125
1126 Fix more problems found by GCC 4.6.0's static checks.
1127
1128 * xdisp.c (vmessage): Use a better test for character truncation.
1129
1130 * charset.c (load_charset_map): <, not <=, for optimization,
1131 and to avoid potential problems with integer overflow.
1132 * chartab.c (sub_char_table_set_range, char_table_set_range): Likewise.
1133 * casetab.c (set_identity, shuffle): Likewise.
1134 * editfns.c (Fformat): Likewise.
1135 * syntax.c (skip_chars): Likewise.
1136
1137 * xmenu.c (set_frame_menubar): Allocate smaller local vectors.
1138 This also lets GCC 4.6.0 generate slightly better loop code.
1139
1140 * callint.c (Fcall_interactively): <, not <=, for optimization.
1141 (Fcall_interactively): Count the number of arguments produced,
1142 not the number of arguments given. This is simpler and lets GCC
1143 4.6.0 generate slightly better code.
1144
1145 * ftfont.c: Distingish more carefully between FcChar8 and char.
1146 The previous code passed unsigned char * to a functions like
1147 strlen and xstrcasecmp that expect char *, which does not
1148 conform to the C standard.
1149 (get_adstyle_property, ftfont_pattern_entity): Use FcChar8 for
1150 arguments to FcPatternGetString, and explicitly cast FcChar8 * to
1151 char * when the C standard requires it.
1152
1153 * keyboard.c (read_char): Remove unused var.
1154
1155 * eval.c: Port to Windows vsnprintf (Bug#8435).
1156 Include <limits.h>.
1157 (SIZE_MAX): Define if the headers do not.
1158 (verror): Do not give up if vsnprintf returns a negative count.
1159 Instead, grow the buffer. This ports to Windows vsnprintf, which
1160 does not conform to C99. Problem reported by Eli Zaretskii.
1161 Also, simplify the allocation scheme, by avoiding the need for
1162 calling realloc, and removing the ALLOCATED variable.
1163
1164 * eval.c (verror): Initial buffer size is 4000 (not 200) bytes.
1165
1166 Remove invocations of doprnt, as Emacs now uses vsnprintf.
1167 But keep the doprint source code for now, as we might revamp it
1168 and use it again (Bug#8435).
1169 * lisp.h (doprnt): Remove.
1170 * Makefile.in (base_obj): Remove doprnt.o.
1171 * deps.mk (doprnt.o): Remove.
1172
1173 error: Print 32- and 64-bit integers portably (Bug#8435).
1174 Without this change, on typical 64-bit hosts error ("...%d...", N)
1175 was used to print both 32- and 64-bit integers N, which relied on
1176 undefined behavior.
1177 * lisp.h, src/m/amdx86-64.h, src/m/ia64.h, src/m/ibms390x.h (pEd):
1178 New macro.
1179 * lisp.h (error, verror): Mark as printf-like functions.
1180 * eval.c (verror): Use vsnprintf, not doprnt, to do the real work.
1181 Report overflow in size calculations when allocating printf buffer.
1182 Do not truncate output string at its first null byte.
1183 * xdisp.c (vmessage): Use vsnprintf, not doprnt, to do the real work.
1184 Truncate the output at a character boundary, since vsnprintf does not
1185 do that.
1186 * charset.c (check_iso_charset_parameter): Convert internal
1187 character to string before calling 'error', since %c now has the
1188 printf meaning.
1189 * coding.c (Fdecode_sjis_char, Fdecode_big5_char): Avoid int
1190 overflow when computing char to be passed to 'error'. Do not
1191 pass Lisp_Object to 'error'; pass the integer instead.
1192 * nsfns.m (Fns_do_applescript): Use int, not long, since it's
1193 formatted with plain %d.
1194
1195 * eval.c (internal_lisp_condition_case): Don't pass spurious arg.
1196
1197 * keyboard.c (access_keymap_keyremap): Print func name, not garbage.
1198
1199 * coding.c (Fdecode_sjis_char): Don't assume CODE fits in int.
1200
1201 * xterm.c (x_catch_errors): Remove duplicate declaration.
1202
1203 * term.c (maybe_fatal): Mark its 3rd arg as a printf format, too.
1204
1205 * xdisp.c, lisp.h (message_nolog): Remove; unused.
1206
1207 2011-04-10 Jim Meyering <meyering@redhat.com>
1208
1209 use ssize_t and size_t for read- and write-like emacs_gnutls_* functions
1210 * gnutls.c (emacs_gnutls_read): Adjust signature to be more read-like:
1211 return ssize_t not "int", and use size_t as the buffer length.
1212 (emacs_gnutls_write): Likewise, and make the buffer pointer "const".
1213 * gnutls.h: Update declarations.
1214 * process.c (read_process_output): Use ssize_t, to match.
1215 (send_process): Likewise.
1216
1217 2011-04-09 Chong Yidong <cyd@stupidchicken.com>
1218
1219 * image.c (Fimagemagick_types): Doc fix, and comment cleanup.
1220
1221 2011-04-09 Chong Yidong <cyd@stupidchicken.com>
1222
1223 * ftfont.c (get_adstyle_property, ftfont_pattern_entity): Use
1224 unsigned char, to match FcChar8 type definition.
1225
1226 * xterm.c (handle_one_xevent):
1227 * xmenu.c (create_and_show_popup_menu):
1228 * xselect.c (x_decline_selection_request)
1229 (x_reply_selection_request): Avoid type-punned deref of X events.
1230
1231 2011-04-09 Eli Zaretskii <eliz@gnu.org>
1232
1233 Fix some uses of `int' instead of EMACS_INT.
1234 * search.c (string_match_1, fast_string_match)
1235 (fast_c_string_match_ignore_case, fast_string_match_ignore_case)
1236 (scan_buffer, find_next_newline_no_quit)
1237 (find_before_next_newline, search_command, Freplace_match)
1238 (Fmatch_data): Make some `int' variables be EMACS_INT.
1239
1240 * xdisp.c (display_count_lines): 3rd argument and return value now
1241 EMACS_INT. All callers changed.
1242 (pint2hrstr): Last argument is now EMACS_INT.
1243
1244 * coding.c (detect_coding_utf_8, detect_coding_emacs_mule)
1245 (detect_coding_iso_2022, detect_coding_sjis, detect_coding_big5)
1246 (detect_coding_ccl, detect_coding_charset, decode_coding_utf_8)
1247 (decode_coding_utf_16, decode_coding_emacs_mule)
1248 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5)
1249 (decode_coding_ccl, decode_coding_charset)
1250 <consumed_chars, consumed_chars_base>: Declare EMACS_INT.
1251 (decode_coding_iso_2022, decode_coding_emacs_mule)
1252 (decode_coding_sjis, decode_coding_big5, decode_coding_charset)
1253 <char_offset, last_offset>: Declare EMACS_INT.
1254 (encode_coding_utf_8, encode_coding_utf_16)
1255 (encode_coding_emacs_mule, encode_invocation_designation)
1256 (encode_designation_at_bol, encode_coding_iso_2022)
1257 (encode_coding_sjis, encode_coding_big5, encode_coding_ccl)
1258 (encode_coding_raw_text, encode_coding_charset) <produced_chars>:
1259 Declare EMACS_INT.
1260 (ASSURE_DESTINATION): Declare more_bytes EMACS_INT.
1261 (encode_invocation_designation): Last argument P_NCHARS is now
1262 EMACS_INT.
1263 (decode_eol): Declare pos_byte, pos, and pos_end EMACS_INT.
1264 (produce_chars): from_nchars and to_nchars are now EMACS_INT.
1265
1266 * coding.h (struct coding_system) <head_ascii>: Declare EMACS_INT.
1267 All users changed.
1268
1269 * ccl.c (Fccl_execute_on_string): Declare some variables
1270 EMACS_INT.
1271
1272 2011-04-08 Samuel Thibault <sthibault@debian.org> (tiny change)
1273
1274 * term.c (init_tty): Fix incorrect ifdef placement (Bug#8450).
1275
1276 2011-03-19 Christoph Scholtes <cschol2112@googlemail.com>
1277
1278 * process.c (Fformat_network_address): Doc fix.
1279
1280 2011-04-08 T.V. Raman <tv.raman.tv@gmail.com> (tiny change)
1281
1282 * xml.c (parse_region): Avoid creating spurious whiespace nodes.
1283
1284 2011-04-08 Chong Yidong <cyd@stupidchicken.com>
1285
1286 * keyboard.c (read_char): Call Lisp function help-form-show,
1287 instead of using internal_with_output_to_temp_buffer.
1288 (Qhelp_form_show): New var.
1289 (syms_of_keyboard): Use DEFSYM macro.
1290
1291 * print.c (internal_with_output_to_temp_buffer): Function deleted.
1292
1293 * lisp.h (internal_with_output_to_temp_buffer): Remove prototype.
1294
1295 2011-04-06 Chong Yidong <cyd@stupidchicken.com>
1296
1297 * process.c (Flist_processes): Removed to Lisp.
1298 (list_processes_1): Deleted.
1299
1300 2011-04-06 Eli Zaretskii <eliz@gnu.org>
1301
1302 * msdos.c (careadlinkat, careadlinkatcwd): MS-DOS replacements.
1303
1304 * w32.c (careadlinkat, careadlinkatcwd): New always-fail stubs.
1305
1306 2011-04-06 Paul Eggert <eggert@cs.ucla.edu>
1307
1308 Fix more problems found by GCC 4.6.0's static checks.
1309
1310 * xmenu.c (Fx_popup_dialog): Don't assume string is free of formats.
1311
1312 * menu.c (Fx_popup_menu): Don't assume error_name lacks printf formats.
1313
1314 * lisp.h (message, message_nolog, fatal): Mark as printf-like.
1315
1316 * xdisp.c (vmessage): Mark as a printf-like function.
1317
1318 * term.c (vfatal, maybe_fatal): Mark as printf-like functions.
1319
1320 * sound.c (sound_warning): Don't crash if arg contains a printf format.
1321
1322 * image.c (tiff_error_handler, tiff_warning_handler): Mark as
1323 printf-like functions.
1324 (tiff_load): Add casts to remove these marks before passing them
1325 to system-supplied API.
1326
1327 * eval.c (Fsignal): Remove excess argument to 'fatal'.
1328
1329 * coding.c (EMIT_ONE_BYTE, EMIT_TWO_BYTES): Use unsigned, not int.
1330 This avoids several warnings with gcc -Wstrict-overflow.
1331 (DECODE_COMPOSITION_RULE): If the rule is invalid, goto invalid_code
1332 directly, rather than having caller test rule sign. This avoids
1333 some unnecessary tests.
1334 * composite.h (COMPOSITION_ENCODE_RULE_VALID): New macro.
1335 (COMPOSITION_ENCODE_RULE): Arguments now must be valid. This
1336 affects only one use, in DECODE_COMPOSITION_RULE, which is changed.
1337
1338 * xfont.c (xfont_text_extents): Remove var that was set but not used.
1339 (xfont_open): Avoid unnecessary tests.
1340
1341 * composite.c (composition_gstring_put_cache): Use unsigned integer.
1342
1343 * composite.h, composite.c (composition_gstring_put_cache):
1344 Use EMACS_INT, not int, for length.
1345
1346 * composite.h (COMPOSITION_DECODE_REFS): New macro,
1347 breaking out part of COMPOSITION_DECODE_RULE.
1348 (COMPOSITION_DECODE_RULE): Use it.
1349 * composite.c (get_composition_id): Remove unused local vars,
1350 by using the new macro.
1351
1352 * textprop.c (set_text_properties_1): Change while to do-while,
1353 since the condition is always true at first.
1354
1355 * intervals.c (graft_intervals_into_buffer): Mark var as used.
1356 (interval_deletion_adjustment): Return unsigned value.
1357 All uses changed.
1358
1359 * process.c (list_processes_1, create_pty, read_process_output):
1360 (exec_sentinel): Remove vars that were set but not used.
1361 (create_pty): Remove unnecessary "volatile"s.
1362 (Fnetwork_interface_info): Avoid possibility of int overflow.
1363 (read_process_output): Do adaptive read buffering even if carryover.
1364 (read_process_output): Simplify nbytes computation if buffered.
1365
1366 * bytecode.c (exec_byte_code): Rename local to avoid shadowing.
1367
1368 * syntax.c (scan_words): Remove var that was set but not used.
1369 (update_syntax_table): Use unsigned instead of int.
1370
1371 * lread.c (lisp_file_lexically_bound_p): Use ints rather than endptrs.
1372 (lisp_file_lexically_bound_p, read1): Use unsigned instead of int.
1373 (safe_to_load_p): Make the end-of-loop test the inverse of the in-loop.
1374
1375 * print.c (print_error_message): Avoid int overflow.
1376
1377 * font.c (font_list_entities): Redo for clarity,
1378 so that reader need not know FONT_DPI_INDEX + 1 == FONT_SPACING_INDEX.
1379
1380 * font.c (font_find_for_lface, Ffont_get_glyphs): Remove unused vars.
1381 (font_score): Avoid potential overflow in diff calculation.
1382
1383 * fns.c (substring_both): Remove var that is set but not used.
1384 (sxhash): Redo loop for clarity and to avoid wraparound warning.
1385
1386 * eval.c (funcall_lambda): Rename local to avoid shadowing.
1387
1388 * alloc.c (mark_object_loop_halt, mark_object): Use size_t, not int.
1389 Otherwise, GCC 4.6.0 optimizes the loop check away since the check
1390 can always succeed if overflow has undefined behavior.
1391
1392 * search.c (boyer_moore, wordify): Remove vars set but not used.
1393 (wordify): Omit three unnecessary tests.
1394
1395 * indent.c (MULTIBYTE_BYTES_WIDTH): Don't compute wide_column.
1396 All callers changed. This avoids the need for an unused var.
1397
1398 * casefiddle.c (casify_region): Remove var that is set but not used.
1399
1400 * dired.c (file_name_completion): Remove var that is set but not used.
1401
1402 * fileio.c (Finsert_file_contents): Make EOF condition clearer.
1403
1404 * fileio.c (Finsert_file_contents): Avoid signed integer overflow.
1405 (Finsert_file_contents): Remove unnecessary code checking fd.
1406
1407 * minibuf.c (read_minibuf_noninteractive): Use size_t for sizes.
1408 Check for integer overflow on size calculations.
1409
1410 * buffer.c (Fprevious_overlay_change): Remove var that is set
1411 but not used.
1412
1413 * keyboard.c (menu_bar_items, read_char_minibuf_menu_prompt):
1414 Remove vars that are set but not used.
1415 (timer_check_2): Don't assume timer-list and idle-timer-list are lists.
1416 (timer_check_2): Mark vars as initialized.
1417
1418 * gtkutil.c (xg_get_file_with_chooser): Mark var as initialized.
1419
1420 * image.c (lookup_image): Remove var that is set but not used.
1421 (xbm_load): Use parse_p, for gcc -Werror=unused-but-set-variable.
1422
1423 * fontset.c (Finternal_char_font, Ffontset_info): Remove vars
1424 that are set but not used.
1425
1426 * xfns.c (make_invisible_cursor): Don't return garbage
1427 if XCreateBitmapFromData fails (Bug#8410).
1428
1429 * xselect.c (x_get_local_selection, x_handle_property_notify):
1430 Remove vars that are set but not used.
1431
1432 * xfns.c (x_create_tip_frame): Remove var that is set but not used.
1433 (make_invisible_cursor): Initialize a possibly-uninitialized variable.
1434
1435 * xterm.c (x_scroll_bar_to_input_event) [!USE_GTK]:
1436 Remove var that is set but not used.
1437 (scroll_bar_windows_size): Now size_t, not int.
1438 (x_send_scroll_bar_event): Use size_t, not int, for sizes.
1439 Check for overflow.
1440
1441 * xfaces.c (realize_named_face): Remove vars that are set but not used.
1442 (map_tty_color) [!defined MSDOS]: Likewise.
1443
1444 * term.c (tty_write_glyphs): Use size_t; this avoids overflow warning.
1445
1446 * coding.c: Remove vars that are set but not used.
1447 (DECODE_COMPOSITION_RULE): Remove 2nd arg, which is unused.
1448 All callers changed.
1449 (decode_coding_utf_8, decode_coding_utf_16 decode_coding_emacs_mule):
1450 (decode_coding_iso_2022, encode_coding_sjis, encode_coding_big5):
1451 (decode_coding_charset): Remove vars that are set but not used.
1452
1453 * bytecode.c (Fbyte_code) [!defined BYTE_CODE_SAFE]: Remove var
1454 that is set but not used.
1455
1456 * print.c (print_object): Remove var that is set but not used.
1457
1458 Replace 2 copies of readlink code with 1 gnulib version (Bug#8401).
1459 The gnulib version avoids calling malloc in the usual case,
1460 and on 64-bit hosts doesn't have some arbitrary 32-bit limits.
1461 * fileio.c (Ffile_symlink_p): Use emacs_readlink.
1462 * filelock.c (current_lock_owner): Likewise.
1463 * lisp.h (READLINK_BUFSIZE, emacs_readlink): New function.
1464 * sysdep.c: Include allocator.h, careadlinkat.h.
1465 (emacs_no_realloc_allocator): New static constant.
1466 (emacs_readlink): New function.
1467 * deps.mk (sysdep.o): Depend on ../lib/allocator.h and on
1468 ../lib/careadlinkat.h.
1469
1470 2011-04-04 Stefan Monnier <monnier@iro.umontreal.ca>
1471
1472 * keyboard.c (safe_run_hook_funcall): Fix last change (don't stop at the
1473 first non-nil return value).
1474
1475 2011-04-03 Jan Djärv <jan.h.d@swipnet.se>
1476
1477 * nsterm.m (ns_update_auto_hide_menu_bar): Define MAC_OS_X_VERSION_10_6
1478 if not defined (Bug#8403).
1479
1480 2011-04-02 Juanma Barranquero <lekktu@gmail.com>
1481
1482 * xdisp.c (display_count_lines): Remove parameter `start',
1483 unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
1484 (get_char_face_and_encoding): Remove parameter `multibyte_p',
1485 unused since 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
1486 (fill_stretch_glyph_string): Remove parameters `row' and `area',
1487 unused at least since Kim's GUI unification at 2003-03-16T20:45:46Z!storm@cua.dk
1488 and thereabouts. All callers changed.
1489 (get_per_char_metric): Remove parameter `f', unused since
1490 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
1491
1492 2011-04-02 Jim Meyering <meyering@redhat.com>
1493
1494 do not dereference NULL upon failed strdup
1495 * nsfont.m (ns_descriptor_to_entity): Use xstrdup, not strdup.
1496 (ns_get_family): Likewise.
1497
1498 2011-04-02 Juanma Barranquero <lekktu@gmail.com>
1499
1500 * eval.c (unwind_to_catch) [DEBUG_GCPRO]: Remove redundant assignment.
1501
1502 2011-04-02 Jan Djärv <jan.h.d@swipnet.se>
1503
1504 * nsterm.m (ns_update_auto_hide_menu_bar): Only for OSX 10.6 or
1505 later (Bug#8403).
1506
1507 2011-04-01 Stefan Monnier <monnier@iro.umontreal.ca>
1508
1509 Add lexical binding.
1510
1511 * window.c (Ftemp_output_buffer_show): New fun.
1512 (Fsave_window_excursion):
1513 * print.c (Fwith_output_to_temp_buffer): Move to subr.el.
1514
1515 * lread.c (lisp_file_lexically_bound_p): New function.
1516 (Fload): Bind Qlexical_binding.
1517 (readevalloop): Remove `evalfun' arg.
1518 Bind Qinternal_interpreter_environment.
1519 (Feval_buffer): Bind Qlexical_binding.
1520 (defvar_int, defvar_bool, defvar_lisp_nopro, defvar_kboard):
1521 Mark as dynamic.
1522 (syms_of_lread): Declare `lexical-binding'.
1523
1524 * lisp.h (struct Lisp_Symbol): New field `declared_special'.
1525
1526 * keyboard.c (eval_dyn): New fun.
1527 (menu_item_eval_property): Use it.
1528
1529 * image.c (parse_image_spec): Use Ffunctionp.
1530
1531 * fns.c (concat, mapcar1): Accept byte-code-functions.
1532
1533 * eval.c (Fsetq): Handle lexical vars.
1534 (Fdefun, Fdefmacro, Ffunction): Make closures when needed.
1535 (Fdefconst, Fdefvaralias, Fdefvar): Mark as dynamic.
1536 (FletX, Flet): Obey lexical binding.
1537 (Fcommandp): Handle closures.
1538 (Feval): New `lexical' arg.
1539 (eval_sub): New function extracted from Feval. Use it almost
1540 everywhere where Feval was used. Look up vars in lexical env.
1541 Handle closures.
1542 (Ffunctionp): Move from subr.el.
1543 (Ffuncall): Handle closures.
1544 (apply_lambda): Remove `eval_flags'.
1545 (funcall_lambda): Handle closures and new byte-code-functions.
1546 (Fspecial_variable_p): New function.
1547 (syms_of_eval): Initialize the Vinternal_interpreter_environment var,
1548 but without exporting it to Lisp.
1549
1550 * doc.c (Fdocumentation, store_function_docstring):
1551 * data.c (Finteractive_form): Handle closures.
1552
1553 * callint.c (Fcall_interactively): Preserve lexical-binding mode for
1554 interactive spec.
1555
1556 * bytecode.c (Bstack_ref, Bstack_set, Bstack_set2, BdiscardN): New
1557 byte-codes.
1558 (exec_byte_code): New function extracted from Fbyte_code to handle new
1559 calling convention for byte-code-functions. Add new byte-codes.
1560
1561 * buffer.c (defvar_per_buffer): Set new `declared_special' field.
1562
1563 * alloc.c (Fmake_symbol): Init new `declared_special' field.
1564
1565 2011-03-31 Juanma Barranquero <lekktu@gmail.com>
1566
1567 * xdisp.c (redisplay_internal): Fix prototype.
1568
1569 2011-03-31 Eli Zaretskii <eliz@gnu.org>
1570
1571 * xdisp.c (SCROLL_LIMIT): New macro.
1572 (try_scrolling): Use it when setting scroll_limit. Limit
1573 scrolling to 100 screen lines.
1574 (redisplay_window): Even when falling back on "recentering",
1575 position point in the window according to scroll-conservatively,
1576 scroll-margin, and scroll-*-aggressively variables. (Bug#6671)
1577
1578 (try_scrolling): When point is above the window, allow searching
1579 as far as scroll_max, or one screenful, to compute vertical
1580 distance from PT to the scroll margin position. This prevents
1581 try_scrolling from unnecessarily failing when
1582 scroll-conservatively is set to a value slightly larger than the
1583 window height. Clean up the case of PT below the margin at bottom
1584 of window: scroll_max can no longer be INT_MAX. When aggressive
1585 scrolling is in use, don't let point enter the opposite scroll
1586 margin as result of the scroll.
1587 (syms_of_xdisp) <scroll-conservatively>: Document the
1588 threshold of 100 lines for never-recentering scrolling.
1589
1590 2011-03-31 Juanma Barranquero <lekktu@gmail.com>
1591
1592 * dispextern.h (move_it_by_lines):
1593 * xdisp.c (move_it_by_lines): Remove parameter `need_y_p', unused
1594 since 2000-12-29T14:24:09Z!gerd@gnu.org. All callers changed.
1595 (message_log_check_duplicate): Remove parameters `prev_bol' and
1596 `this_bol', unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
1597 (redisplay_internal): Remove parameter `preserve_echo_area',
1598 unused since 1999-07-21T21:43:52Z!gerd@gnu.org. All callers changed.
1599
1600 * indent.c (Fvertical_motion):
1601 * window.c (window_scroll_pixel_based, Frecenter):
1602 Don't pass `need_y_p' to `move_it_by_lines'.
1603
1604 2011-03-30 Stefan Monnier <monnier@iro.umontreal.ca>
1605
1606 * eval.c (struct backtrace): Don't cheat with negative numbers, but do
1607 steal a few bits to be more compact.
1608 (interactive_p, Fbacktrace, Fbacktrace_frame, mark_backtrace):
1609 Remove unneeded casts.
1610
1611 * bytecode.c (Fbyte_code): CAR and CDR can GC.
1612
1613 2011-03-30 Zachary Kanfer <zkanfer@gmail.com> (tiny change)
1614
1615 * keyboard.c (Fexecute_extended_command): Do log the "suggest key
1616 binding" message (bug#7967).
1617
1618 2011-03-30 Paul Eggert <eggert@cs.ucla.edu>
1619
1620 Fix more problems found by GCC 4.6.0's static checks.
1621
1622 * unexelf.c (unexec) [! (defined _SYSTYPE_SYSV || defined __sgi)]:
1623 Remove unused local var.
1624
1625 * editfns.c (Fmessage_box): Remove unused local var.
1626
1627 * xdisp.c (try_window_reusing_current_matrix, x_produce_glyphs):
1628 (note_mode_line_or_margin_highlight, note_mouse_highlight):
1629 Omit unused local vars.
1630 * window.c (shrink_windows): Omit unused local var.
1631 * menu.c (digest_single_submenu): Omit unused local var.
1632 * dispnew.c (update_window) [PERIODIC_PREEMPTION_CHECKING]:
1633 Omit unused local var.
1634
1635 * keyboard.c (parse_modifiers_uncached, parse_modifiers):
1636 Don't assume string length fits in int.
1637 (keyremap_step, read_key_sequence): Use size_t for sizes.
1638 (read_key_sequence): Don't check last_real_key_start redundantly.
1639
1640 * callproc.c (Fcall_process, Fcall_process_region): Use SAFE_ALLOCA
1641 instead of alloca (Bug#8344).
1642
1643 * eval.c (Fbacktrace): Don't assume nargs fits in int.
1644 (Fbacktrace_frame): Don't assume nframes fits in int.
1645
1646 * syntax.c (scan_sexps_forward): Avoid pointer wraparound.
1647
1648 * xterm.c (x_make_frame_visible, same_x_server): Redo to avoid overflow
1649 concerns.
1650
1651 * term.c (produce_glyphless_glyph): Remove unnecessary test.
1652
1653 * cm.c (calccost): Turn while-do into do-while, for clarity.
1654
1655 * keyboard.c (syms_of_keyboard): Use the same style as later
1656 in this function when indexing through an array. This also
1657 works around GCC bug 48267.
1658
1659 * image.c (tiff_load): Fix off-by-one image count (Bug#8336).
1660
1661 * xselect.c (x_check_property_data): Return correct size (Bug#8335).
1662
1663 * chartab.c (sub_char_table_ref_and_range): Redo for slight
1664 efficiency gain, and to bypass a gcc -Wstrict-overflow warning.
1665
1666 * keyboard.c, keyboard.h (num_input_events): Now size_t.
1667 This avoids undefined behavior on integer overflow, and is a bit
1668 more convenient anyway since it is compared to a size_t variable.
1669
1670 Variadic C functions now count arguments with size_t, not int.
1671 This avoids an unnecessary limitation on 64-bit machines, which
1672 caused (substring ...) to crash on large vectors (Bug#8344).
1673 * lisp.h (struct Lisp_Subr.function.aMANY): Now takes size_t, not int.
1674 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call): Likewise.
1675 All variadic functions and their callers changed accordingly.
1676 (struct gcpro.nvars): Now size_t, not int. All uses changed.
1677 * data.c (arith_driver, float_arith_driver): Likewise.
1678 * editfns.c (general_insert_function): Likewise.
1679 * eval.c (struct backtrace.nargs, interactive_p)
1680 (internal_condition_case_n, run_hook_with_args, apply_lambda)
1681 (funcall_lambda, mark_backtrace): Likewise.
1682 * fns.c (concat): Likewise.
1683 * frame.c (x_set_frame_parameters): Likewise.
1684 * fns.c (get_key_arg): Now accepts and returns size_t, and returns
1685 0 if not found, not -1. All callers changed.
1686
1687 * alloc.c (garbage_collect): Don't assume stack size fits in int.
1688 (stack_copy_size): Now size_t, not int.
1689 (stack_copy, stack_copy_size): Define only if MAX_SAVE_STACK > 0.
1690
1691 2011-03-28 Juanma Barranquero <lekktu@gmail.com>
1692
1693 * coding.c (encode_designation_at_bol): Remove parameter `charbuf_end',
1694 unused since 2002-03-01T01:17:24Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
1695 All callers changed.
1696
1697 * lisp.h (multibyte_char_to_unibyte):
1698 * character.c (multibyte_char_to_unibyte): Remove parameter `rev_tbl',
1699 unused since 2002-03-01T01:16:34Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
1700 * character.h (CHAR_TO_BYTE8):
1701 * cmds.c (internal_self_insert):
1702 * editfns.c (general_insert_function):
1703 * keymap.c (push_key_description):
1704 * search.c (Freplace_match):
1705 * xdisp.c (message_dolog, set_message_1): All callers changed.
1706
1707 2011-03-28 Stefan Monnier <monnier@iro.umontreal.ca>
1708
1709 * keyboard.c (safe_run_hook_funcall): New function.
1710 (safe_run_hooks_1, safe_run_hooks_error, safe_run_hooks): On error,
1711 don't set the hook to nil, but remove the offending function instead.
1712 (Qcommand_hook_internal): Remove, unused.
1713 (syms_of_keyboard): Don't initialize Qcommand_hook_internal nor define
1714 Vcommand_hook_internal.
1715
1716 * eval.c (enum run_hooks_condition): Remove.
1717 (funcall_nil, funcall_not): New functions.
1718 (run_hook_with_args): Call each function through a `funcall' argument.
1719 Remove `cond' argument, now redundant.
1720 (Frun_hooks, Frun_hook_with_args, Frun_hook_with_args_until_success)
1721 (Frun_hook_with_args_until_failure): Adjust accordingly.
1722 (run_hook_wrapped_funcall, Frun_hook_wrapped): New functions.
1723
1724 2011-03-28 Juanma Barranquero <lekktu@gmail.com>
1725
1726 * dispextern.h (string_buffer_position): Remove declaration.
1727
1728 * print.c (strout): Remove parameter `multibyte', unused since
1729 1999-08-21T19:30:21Z!gerd@gnu.org. All callers changed.
1730
1731 * search.c (boyer_moore): Remove parameters `len', `pos' and `lim',
1732 never used since function introduction in 1998-02-08T21:33:56Z!rms@gnu.org.
1733 All callers changed.
1734
1735 * w32.c (_wsa_errlist): Use braces for struct initializers.
1736
1737 * xdisp.c (string_buffer_position_lim): Remove parameter `w',
1738 never used since function introduction in 2001-03-09T18:41:50Z!gerd@gnu.org.
1739 All callers changed.
1740 (string_buffer_position): Likewise. Also, make static (it's never
1741 used outside xdisp.c).
1742 (cursor_row_p): Remove parameter `w', unused since
1743 2000-10-17T16:08:57Z!gerd@gnu.org. All callers changed.
1744 (decode_mode_spec): Remove parameter `precision', introduced during
1745 Gerd Moellmann's rewrite at 1999-07-21T21:43:52Z!gerd@gnu.org, but never used.
1746 All callers changed.
1747
1748 2011-03-27 Jan Djärv <jan.h.d@swipnet.se>
1749
1750 * nsterm.m (syms_of_nsterm): Use doc: for ns-auto-hide-menu-bar.
1751
1752 2011-03-27 Anders Lindgren <andlind@gmail.com>
1753
1754 * nsterm.m (ns_menu_bar_is_hidden): New variable.
1755 (ns_constrain_all_frames, ns_menu_bar_should_be_hidden)
1756 (ns_update_auto_hide_menu_bar): New functions.
1757 (ns_update_begin): Call ns_update_auto_hide_menu_bar.
1758 (applicationDidBecomeActive): Call ns_update_auto_hide_menu_bar and
1759 ns_constrain_all_frames.
1760 (constrainFrameRect): Return at once if ns_menu_bar_should_be_hidden.
1761 (syms_of_nsterm): DEFVAR ns-auto-hide-menu-bar, init to Qnil.
1762
1763 2011-03-27 Jan Djärv <jan.h.d@swipnet.se>
1764
1765 * nsmenu.m (runDialogAt): Remove argument to timer_check.
1766
1767 2011-03-27 Glenn Morris <rgm@gnu.org>
1768
1769 * syssignal.h: Replace RETSIGTYPE with void.
1770 * atimer.c, data.c, dispnew.c, emacs.c, floatfns.c, keyboard.c:
1771 * keyboard.h, lisp.h, process.c, sysdep.c, xterm.c:
1772 Replace SIGTYPE with void everywhere.
1773 * s/usg5-4-common.h (SIGTYPE): Remove definition.
1774 * s/template.h (SIGTYPE): Remove commented out definition.
1775
1776 2011-03-26 Eli Zaretskii <eliz@gnu.org>
1777
1778 * xdisp.c (redisplay_window): Don't check buffer's clip_changed
1779 flag as a prerequisite for invoking try_scrolling. (Bug#6671)
1780
1781 2011-03-26 Juanma Barranquero <lekktu@gmail.com>
1782
1783 * w32.c (read_unc_volume): Use parameter `henum', instead of
1784 global variable `wget_enum_handle'.
1785
1786 * keymap.c (describe_vector): Remove parameters `indices' and
1787 `char_table_depth', unused since 2002-03-01T01:43:26Z!handa@m17n.org.
1788 (describe_map, Fdescribe_vector): Adjust calls to `describe_vector'.
1789
1790 * keyboard.h (timer_check, show_help_echo): Remove unused parameters.
1791
1792 * keyboard.c (timer_check): Remove parameter `do_it_now',
1793 unused since 1996-04-12T06:01:29Z!rms@gnu.org.
1794 (show_help_echo): Remove parameter `ok_to_overwrite_keystroke_echo',
1795 unused since 2008-04-19T19:30:53Z!monnier@iro.umontreal.ca.
1796
1797 * keyboard.c (read_char):
1798 * w32menu.c (w32_menu_display_help):
1799 * xmenu.c (show_help_event, menu_help_callback):
1800 Adjust calls to `show_help_echo'.
1801
1802 * gtkutil.c (xg_maybe_add_timer):
1803 * keyboard.c (readable_events):
1804 * process.c (wait_reading_process_output):
1805 * xmenu.c (x_menu_wait_for_event): Adjust calls to `timer_check'.
1806
1807 * insdel.c (adjust_markers_gap_motion):
1808 Remove; no-op since 1998-01-02T21:29:48Z!rms@gnu.org.
1809 (gap_left, gap_right): Don't call it.
1810
1811 2011-03-25 Chong Yidong <cyd@stupidchicken.com>
1812
1813 * xdisp.c (handle_fontified_prop): Discard changes to clip_changed
1814 incurred during fontification.
1815
1816 2011-03-25 Juanma Barranquero <lekktu@gmail.com>
1817
1818 * buffer.c (defvar_per_buffer): Remove unused parameter `doc'.
1819 (DEFVAR_PER_BUFFER): Don't pass it.
1820
1821 * dispnew.c (row_equal_p, add_row_entry): Remove unused parameter `w'.
1822 (scrolling_window): Don't pass it.
1823
1824 2011-03-25 Juanma Barranquero <lekktu@gmail.com>
1825
1826 * dispextern.h (glyph_matric): Use #if GLYPH_DEBUG, not #ifdef.
1827
1828 * fileio.c (check_executable) [DOS_NT]: Remove unused variables `len'
1829 and `suffix'.
1830 (Fset_file_selinux_context) [HAVE_LIBSELINUX]: Move here declaration
1831 of variables specific to SELinux and computation of `encoded_absname'.
1832
1833 * image.c (XPutPixel): Remove unused variable `height'.
1834
1835 * keyboard.c (make_lispy_event): Remove unused variable `hpos'.
1836
1837 * unexw32.c (get_section_info): Remove unused variable `section'.
1838
1839 * w32.c (stat): Remove unused variables `drive_root' and `devtype'.
1840 (system_process_attributes): Remove unused variable `sess'.
1841 (sys_read): Remove unused variable `err'.
1842
1843 * w32fns.c (top): Wrap variables with #if GLYPH_DEBUG, not #ifdef.
1844 (w32_wnd_proc): Remove unused variable `isdead'.
1845 (unwind_create_frame): Use #if GLYPH_DEBUG, not #ifdef.
1846 (Fx_server_max_request_size): Remove unused variable `dpyinfo'.
1847 (x_create_tip_frame): Remove unused variable `tem'.
1848
1849 * w32inevt.c (w32_console_read_socket):
1850 Remove unused variable `no_events'.
1851
1852 * w32term.c (x_draw_composite_glyph_string_foreground):
1853 Remove unused variable `width'.
1854
1855 2011-03-24 Juanma Barranquero <lekktu@gmail.com>
1856
1857 * w32term.c (x_set_glyph_string_clipping):
1858 Don't pass uninitialized region to CombineRgn.
1859
1860 2011-03-23 Juanma Barranquero <lekktu@gmail.com>
1861
1862 * w32fns.c (x_set_menu_bar_lines): Remove unused variable `olines'.
1863 (w32_wnd_proc): Pass NULL to Windows API, not uninitialized buffer.
1864 (Fx_close_connection): Remove unused variable `i'.
1865
1866 * w32font.c (w32font_draw): Return number of glyphs.
1867 (w32font_open_internal): Remove unused variable `i'.
1868 (w32font_driver): Add missing initializer.
1869
1870 * w32menu.c (utf8to16): Remove unused variable `utf16'.
1871 (fill_in_menu): Remove unused variable `items_added'.
1872
1873 * w32term.c (last_mouse_press_frame): Remove static global variable.
1874 (w32_clip_to_row): Remove unused variable `f'.
1875 (x_delete_terminal): Remove unused variable `i'.
1876
1877 * w32uniscribe.c (uniscribe_shape): Remove unused variable `nclusters'.
1878 (NOTHING): Remove unused static global variable.
1879 (uniscribe_check_otf): Remove unused variable `table'.
1880 (uniscribe_font_driver): Add missing initializers.
1881
1882 2011-03-23 Julien Danjou <julien@danjou.info>
1883
1884 * term.c (Fsuspend_tty, Fresume_tty):
1885 * minibuf.c (read_minibuf, run_exit_minibuf_hook):
1886 * window.c (temp_output_buffer_show):
1887 * insdel.c (signal_before_change):
1888 * frame.c (Fhandle_switch_frame):
1889 * fileio.c (Fdo_auto_save):
1890 * emacs.c (Fkill_emacs):
1891 * editfns.c (save_excursion_restore):
1892 * cmds.c (internal_self_insert):
1893 * callint.c (Fcall_interactively):
1894 * buffer.c (Fkill_all_local_variables):
1895 * keyboard.c (Fcommand_execute, Fsuspend_emacs, safe_run_hooks_1):
1896 Use Frun_hooks.
1897 (command_loop_1): Use Frun_hooks. Call safe_run_hooks
1898 unconditionnaly since it does the check itself.
1899
1900 2011-03-23 Paul Eggert <eggert@cs.ucla.edu>
1901
1902 Fix more problems found by GCC 4.5.2's static checks.
1903
1904 * coding.c (encode_coding_raw_text): Avoid unnecessary test
1905 the first time through the loop, since we know p0 < p1 then.
1906 This also avoids a gcc -Wstrict-overflow warning.
1907
1908 * lisp.h (SAFE_ALLOCA, SAFE_ALLOCA_LISP): Avoid 'int' overflow
1909 leading to a memory leak, possible in functions like
1910 load_charset_map_from_file that can allocate an unbounded number
1911 of objects (Bug#8318).
1912
1913 * xmenu.c (set_frame_menubar): Use EMACS_UINT, not int, for indexes
1914 that could (at least in theory) be that large.
1915
1916 * xdisp.c (message_log_check_duplicate): Return unsigned long, not int.
1917 This is less likely to overflow, and avoids undefined behavior if
1918 overflow does occur. All callers changed. Use strtoul to scan
1919 for the unsigned long integer.
1920 (pint2hrstr): Simplify and tune code slightly.
1921 This also avoids a (bogus) GCC warning with gcc -Wstrict-overflow.
1922
1923 * scroll.c (do_scrolling): Work around GCC bug 48228.
1924 See <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=48228>.
1925
1926 * frame.c (Fmodify_frame_parameters): Simplify loop counter.
1927 This also avoids a warning with gcc -Wstrict-overflow.
1928 (validate_x_resource_name): Simplify count usage.
1929 This also avoids a warning with gcc -Wstrict-overflow.
1930
1931 * fileio.c (Fcopy_file): Report error if fchown or fchmod
1932 fail (Bug#8306).
1933
1934 * emacs.c (Fdaemon_initialized): Do not ignore I/O errors (Bug#8303).
1935
1936 * process.c (Fmake_network_process): Use socklen_t, not int,
1937 where POSIX says socklen_t is required in portable programs.
1938 This fixes a porting bug on hosts like 64-bit HP-UX, where
1939 socklen_t is wider than int (Bug#8277).
1940 (Fmake_network_process, server_accept_connection):
1941 (wait_reading_process_output, read_process_output):
1942 Likewise.
1943
1944 * process.c: Rename or move locals to avoid shadowing.
1945 (list_processes_1, Fmake_network_process):
1946 (read_process_output_error_handler, exec_sentinel_error_handler):
1947 Rename or move locals.
1948 (Fmake_network_process): Define label "retry_connect" only if needed.
1949 (Fnetwork_interface_info): Fix pointer signedness.
1950 (process_send_signal): Add cast to avoid pointer signedness problem.
1951 (FIRST_PROC_DESC, IF_NON_BLOCKING_CONNECT): Remove unused macros.
1952 (create_process): Use 'volatile' to avoid vfork clobbering (Bug#8298).
1953
1954 Make tparam.h and terminfo.c consistent.
1955 * cm.c (tputs, tgoto, BC, UP): Remove extern decls.
1956 Include tparam.h instead, since it declares them.
1957 * cm.h (PC): Remove extern decl; tparam.h now does this.
1958 * deps.mk (cm.o, terminfo.o): Depend on tparam.h.
1959 * terminfo.c: Include tparam.h, to check interfaces.
1960 (tparm): Make 1st arg a const pointer in decl. Put it at top level.
1961 (tparam): Adjust signature to match interface in tparam.h;
1962 this removes some undefined behavior. Check that outstring and len
1963 are zero, which they always are with Emacs.
1964 * tparam.h (PC, BC, UP): New extern decls.
1965
1966 * xftfont.c (xftfont_shape): Now static, and defined only if needed.
1967 (xftfont_open): Rename locals to avoid shadowing.
1968
1969 * ftfont.c (ftfont_resolve_generic_family): Fix pointer signedness.
1970 (ftfont_otf_capability, ftfont_shape): Omit decls if not needed.
1971 (OTF_TAG_SYM): Omit macro if not needed.
1972 (ftfont_list): Remove unused local.
1973 (get_adstyle_property, ftfont_pattern_entity):
1974 (ftfont_lookup_cache, ftfont_open, ftfont_anchor_point):
1975 Rename locals to avoid shadowing.
1976
1977 * xfont.c (xfont_list_family): Mark var as initialized.
1978
1979 * xml.c (make_dom): Now static.
1980
1981 * composite.c (composition_compute_stop_pos): Rename local to
1982 avoid shadowing.
1983 (composition_reseat_it): Remove unused locals.
1984 (find_automatic_composition, composition_adjust_point): Likewise.
1985 (composition_update_it): Mark var as initialized.
1986 (find_automatic_composition): Mark vars as initialized,
1987 with a FIXME (Bug#8290).
1988
1989 character.h: Rename locals to avoid shadowing.
1990 * character.h (PREV_CHAR_BOUNDARY, FETCH_STRING_CHAR_ADVANCE):
1991 (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE, FETCH_CHAR_ADVANCE):
1992 (FETCH_CHAR_ADVANCE_NO_CHECK, INC_POS, DEC_POS, BUF_INC_POS):
1993 (BUF_DEC_POS): Be more systematic about renaming local temporaries
1994 to avoid shadowing.
1995
1996 * textprop.c (property_change_between_p): Remove; unused.
1997
1998 * intervals.c (interval_start_pos): Now static.
1999
2000 * intervals.h (CHECK_TOTAL_LENGTH): Avoid empty "else".
2001
2002 * atimer.c (start_atimer, append_atimer_lists, set_alarm):
2003 Rename locals to avoid shadowing.
2004
2005 * sound.c (wav_play, au_play, Fplay_sound_internal):
2006 Fix pointer signedness.
2007 (alsa_choose_format): Remove unused local var.
2008 (wav_play): Initialize a variable to 0, to prevent undefined
2009 behavior (Bug#8278).
2010
2011 * region-cache.c (insert_cache_boundary): Redo var to avoid shadowing.
2012
2013 * region-cache.h (pp_cache): New decl, for gcc -Wmissing-prototypes.
2014
2015 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork
2016 clobbering (Bug#8298).
2017 * sysdep.c (sys_subshell): Likewise.
2018 Previously, the sys_subshell 'volatile' was incorrectly IF_LINTted out.
2019
2020 * lisp.h (child_setup): Now NO_RETURN unless DOS_NT.
2021 This should get cleaned up, so that child_setup has the
2022 same signature on all platforms.
2023
2024 * callproc.c (call_process_cleanup): Now static.
2025 (relocate_fd): Rename locals to avoid shadowing.
2026
2027 2011-03-22 Chong Yidong <cyd@stupidchicken.com>
2028
2029 * xterm.c (x_clear_frame): Remove XClearWindow call. This appears
2030 not to be necessary, and produces flickering.
2031
2032 2011-03-20 Glenn Morris <rgm@gnu.org>
2033
2034 * config.in: Remove file.
2035
2036 2011-03-20 Juanma Barranquero <lekktu@gmail.com>
2037
2038 * minibuf.c (Vcompleting_read_function): Don't declare, global variables
2039 are now in src/globals.h.
2040 (syms_of_minibuf): Remove spurious & from previous change.
2041
2042 2011-03-20 Leo <sdl.web@gmail.com>
2043
2044 * minibuf.c (completing-read-function): New variable.
2045 (completing-read-default): Rename from completing-read.
2046 (completing-read): Call completing-read-function.
2047
2048 2011-03-19 Juanma Barranquero <lekktu@gmail.com>
2049
2050 * xfaces.c (Fx_load_color_file):
2051 Read color file from absolute filename (bug#8250).
2052
2053 2011-03-19 Juanma Barranquero <lekktu@gmail.com>
2054
2055 * makefile.w32-in: Update dependencies.
2056
2057 2011-03-17 Eli Zaretskii <eliz@gnu.org>
2058
2059 * makefile.w32-in ($(BLD)/unexw32.$(O)): Depend on $(SRC)/unexec.h.
2060
2061 2011-03-17 Paul Eggert <eggert@cs.ucla.edu>
2062
2063 Fix more problems found by GCC 4.5.2's static checks.
2064
2065 * process.c (make_serial_process_unwind, send_process_trap):
2066 (sigchld_handler): Now static.
2067
2068 * process.c (allocate_pty): Let PTY_ITERATION declare iteration vars.
2069 That way, the code declares only the vars that it needs.
2070 * s/aix4-2.h (PTY_ITERATION): Declare iteration vars.
2071 * s/cygwin.h (PTY_ITERATION): Likewise.
2072 * s/darwin.h (PTY_ITERATION): Likewise.
2073 * s/gnu-linux.h (PTY_ITERATION): Likewise.
2074
2075 * s/irix6-5.h (PTY_OPEN): Declare stb, to loosen coupling.
2076 * process.c (allocate_pty): Don't declare stb unless it's needed.
2077
2078 * bytecode.c (MAYBE_GC): Rewrite so as not to use empty "else".
2079 (CONSTANTLIM): Remove; unused.
2080 (METER_CODE, Bscan_buffer, Bread_char, Bset_mark):
2081 Define only if needed.
2082
2083 * unexelf.c (unexec): Name an expression,
2084 to avoid gcc -Wbad-function-cast warning.
2085 Use a different way to cause a compilation error if anyone uses
2086 n rather than nn, a way that does not involve shadowing.
2087 (ELF_BSS_SECTION_NAME, OLD_PROGRAM_H): Remove; unused.
2088
2089 * deps.mk (unexalpha.o): Remove; unused.
2090
2091 New file unexec.h, the (simple) interface for unexec (Bug#8267).
2092 * unexec.h: New file.
2093 * deps.mk (emacs.o, unexaix.o, unexcw.o, unexcoff.o, unexelf.o):
2094 (unexhp9k800.o, unexmacosx.o, unexsol.o, unexw32.o):
2095 Depend on unexec.h.
2096 * emacs.c [!defined CANNOT_DUMP]: Include unexec.h.
2097 * unexaix.c, unexcoff.c, unexcw.c, unexelf.c, unexhp9k800.c:
2098 * unexmacosx.c, unexsol.c, unexw32.c: Include unexec.h.
2099 Change as necessary to match prototype in unexec.h.
2100
2101 * syntax.c (Fforward_comment, scan_lists): Rename locals to avoid
2102 shadowing.
2103 (back_comment, skip_chars): Mark vars as initialized.
2104
2105 * character.h (FETCH_STRING_CHAR_ADVANCE_NO_CHECK, BUF_INC_POS):
2106 Rename locals to avoid shadowing.
2107
2108 * lread.c (read1): Rewrite so as not to use empty "else".
2109 (Fload, readevalloop, read1): Rename locals to avoid shadowing.
2110
2111 * print.c (Fredirect_debugging_output): Fix pointer signedess.
2112
2113 * lisp.h (debug_output_compilation_hack): Add decl here, to avoid
2114 warning when compiling print.c.
2115
2116 * font.c (font_unparse_fcname): Abort in an "impossible" situation
2117 instead of using an uninitialized var.
2118 (font_sort_entities): Mark var as initialized.
2119
2120 * character.h (FETCH_CHAR_ADVANCE): Rename locals to avoid shadowing.
2121
2122 * font.c (font_unparse_xlfd): Don't mix pointers to variables with
2123 pointers to constants.
2124 (font_parse_fcname): Remove unused vars.
2125 (font_delete_unmatched): Now static.
2126 (font_get_spec): Remove; unused.
2127 (font_style_to_value, font_prop_validate_style, font_unparse_fcname):
2128 (font_update_drivers, Ffont_get_glyphs, font_add_log):
2129 Rename or move locals to avoid shadowing.
2130
2131 * fns.c (require_nesting_list, require_unwind): Now static.
2132 (Ffillarray): Rename locals to avoid shadowing.
2133
2134 * floatfns.c (domain_error2): Define only if needed.
2135 (Ffrexp, Fldexp): Rename locals to avoid shadowing.
2136
2137 * alloc.c (mark_backtrace): Move decl from here ...
2138 * lisp.h: ... to here, so that it can be checked.
2139
2140 * eval.c (call_debugger, do_debug_on_call, grow_specpdl): Now static.
2141 (Fdefvar): Rewrite so as not to use empty "else".
2142 (lisp_indirect_variable): Name an expression,
2143 to avoid gcc -Wbad-function-cast warning.
2144 (Fdefvar): Rename locals to avoid shadowing.
2145
2146 * callint.c (quotify_arg, quotify_args): Now static.
2147 (Fcall_interactively): Rename locals to avoid shadowing.
2148 Use const pointer when appropriate.
2149
2150 * lisp.h (get_system_name, get_operating_system_release):
2151 Move decls here, to check interfaces.
2152 * process.c (get_operating_system_release): Move decl to lisp.h.
2153 * xrdb.c (get_system_name): Likewise.
2154 * editfns.c (init_editfns, Fuser_login_name, Fuser_uid):
2155 (Fuser_real_uid, Fuser_full_name): Remove unnecessary casts,
2156 some of which prompt warnings from gcc -Wbad-function-cast.
2157 (Fformat_time_string, Fencode_time, Finsert_char):
2158 (Ftranslate_region_internal, Fformat):
2159 Rename or remove local vars to avoid shadowing.
2160 (Ftranslate_region_internal): Mark var as initialized.
2161
2162 * doc.c (Fdocumentation, Fsnarf_documentation): Move locals to
2163 avoid shadowing.
2164
2165 * lisp.h (eassert): Check that the argument compiles, even if
2166 ENABLE_CHECKING is not defined.
2167
2168 * data.c (Findirect_variable): Name an expression, to avoid
2169 gcc -Wbad-function-cast warning.
2170 (default_value, arithcompare, arith_driver, arith_error): Now static.
2171 (store_symval_forwarding): Rename local to avoid shadowing.
2172 (Fmake_variable_buffer_local, Fmake_local_variable):
2173 Mark variables as initialized.
2174 (do_blv_forwarding, do_symval_forwarding): Remove; unused.
2175
2176 * alloc.c (check_cons_list): Do not define unless GC_CHECK_CONS_LIST.
2177 (Fmake_vector, Fvector, Fmake_byte_code, Fgarbage_collect):
2178 Rename locals to avoid shadowing.
2179 (mark_stack): Move local variables into the #ifdef region where
2180 they're used.
2181 (BLOCK_INPUT_ALLOC, UNBLOCK_INPUT_ALLOC): Define only if
2182 ! defined SYSTEM_MALLOC && ! defined SYNC_INPUT, as they are not
2183 needed otherwise.
2184 (CHECK_ALLOCATED): Define only if GC_CHECK_MARKED_OBJECTS.
2185 (GC_STRING_CHARS): Remove; not used.
2186 (Fmemory_limit): Cast sbrk's returned value to char *.
2187
2188 * lisp.h (check_cons_list): Declare if GC_CHECK_CONS_LIST; this
2189 avoids undefined behavior in theory.
2190
2191 * regex.c (IF_LINT): Add defn, for benefit of ../lib-src.
2192
2193 Use functions, not macros, for up- and down-casing (Bug#8254).
2194 * buffer.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
2195 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Remove. All callers changed
2196 to use the following functions instead of these macros.
2197 (downcase): Adjust to lack of DOWNCASE_TABLE. Return int, not
2198 EMACS_INT, since callers assume the returned value fits in int.
2199 (upcase1): Likewise, for UPCASE_TABLE.
2200 (uppercasep, lowercasep, upcase): New static inline functions.
2201 * editfns.c (Fchar_equal): Remove no-longer-needed workaround for
2202 the race-condition problem in the old DOWNCASE.
2203
2204 * regex.c (CHARSET_LOOKUP_RANGE_TABLE_RAW, POP_FAILURE_REG_OR_COUNT):
2205 Rename locals to avoid shadowing.
2206 (regex_compile, re_match_2_internal): Move locals to avoid shadowing.
2207 (regex_compile, re_search_2, re_match_2_internal):
2208 Remove unused local vars.
2209 (FREE_VAR): Rewrite so as not to use empty "else",
2210 which gcc can warn about.
2211 (regex_compile, re_match_2_internal): Mark locals as initialized.
2212 (RETALLOC_IF): Define only if needed.
2213 (WORDCHAR_P): Likewise. This one is never needed, but is used
2214 only in a comment talking about a compiler bug, so put inside
2215 the #if 0 of that comment.
2216 (CHARSET_LOOKUP_BITMAP, FAIL_STACK_FULL, RESET_FAIL_STACK):
2217 (PUSH_FAILURE_ELT, BUF_PUSH_3, STOP_ADDR_VSTRING):
2218 Remove; unused.
2219
2220 * search.c (boyer_moore): Rename locals to avoid shadowing.
2221 * character.h (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE):
2222 (PREV_CHAR_BOUNDARY): Likewise.
2223
2224 * search.c (simple_search): Remove unused var.
2225
2226 * dired.c (compile_pattern): Move decl from here ...
2227 * lisp.h: ... to here, so that it can be checked.
2228 (struct re_registers): New forward decl.
2229
2230 * character.h (INC_POS, DEC_POS): Rename locals to avoid shadowing.
2231
2232 * indent.c (MULTIBYTE_BYTES_WIDTH): New args bytes, width.
2233 All uses changed.
2234 (MULTIBYTE_BYTES_WIDTH, scan_for_column, compute_motion):
2235 Rename locals to avoid shadowing.
2236 (Fvertical_motion): Mark locals as initialized.
2237
2238 * casefiddle.c (casify_object, casify_region): Now static.
2239 (casify_region): Mark local as initialized.
2240
2241 * cmds.c (internal_self_insert): Rename local to avoid shadowing.
2242
2243 * lisp.h (GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR, GCPRO5_VAR, GCPRO6_VAR):
2244 New macros, so that the caller can use some names other than
2245 gcpro1, gcpro2, etc.
2246 (GCPRO2, GCPRO3, GCPRO4, GCPRO5, GCPRO6): Reimplement in terms
2247 of the new macros.
2248 (GCPRO1_VAR, UNGCPRO_VAR): Change the meaning of the second
2249 argument, for consistency with GCPRO2_VAR, etc: it is now the
2250 prefix of the variable, not the variable itself. All uses
2251 changed.
2252 * dired.c (directory_files_internal, file_name_completion):
2253 Rename locals to avoid shadowing.
2254
2255 Fix a race condition diagnosed by gcc -Wsequence-point (Bug#8254).
2256 An expression of the form (DOWNCASE (x) == DOWNCASE (y)), found in
2257 dired.c's scmp function, had undefined behavior.
2258 * lisp.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
2259 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Move from here ...
2260 * buffer.h: ... to here, because these macros use current_buffer,
2261 and the new implementation with inline functions needs to have
2262 current_buffer in scope now, rather than later when the macros
2263 are used.
2264 (downcase, upcase1): New static inline functions.
2265 (DOWNCASE, UPCASE1): Reimplement using these functions.
2266 This avoids undefined behavior in expressions like
2267 DOWNCASE (x) == DOWNCASE (y), which previously suffered
2268 from race conditions in accessing the global variables
2269 case_temp1 and case_temp2.
2270 * casetab.c (case_temp1, case_temp2): Remove; no longer needed.
2271 * lisp.h (case_temp1, case_temp2): Remove their decls.
2272 * character.h (ASCII_CHAR_P): Move from here ...
2273 * lisp.h: ... to here, so that the inline functions mentioned
2274 above can use them.
2275
2276 * dired.c (directory_files_internal_unwind): Now static.
2277
2278 * fileio.c (file_name_as_directory, directory_file_name):
2279 (barf_or_query_if_file_exists, auto_save_error, auto_save_1):
2280 Now static.
2281 (file_name_as_directory): Use const pointers when appropriate.
2282 (Fexpand_file_name): Likewise. In particular, newdir might
2283 point at constant storage, so make it a const pointer.
2284 (Fmake_directory_internal, Fread_file_name): Remove unused vars.
2285 (Ffile_selinux_context, Fset_file_selinux_context): Fix pointer
2286 signedness issues.
2287 (Fset_file_times, Finsert_file_contents, auto_save_error):
2288 Rename locals to avoid shadowing.
2289
2290 * minibuf.c (choose_minibuf_frame_1): Now static.
2291 (Ftry_completion, Fall_completions): Rename or remove locals
2292 to avoid shadowing.
2293
2294 * marker.c (bytepos_to_charpos): Remove; unused.
2295
2296 * lisp.h (verify_bytepos, count_markers): New decls,
2297 so that gcc does not warn that these functions aren't declared.
2298
2299 * insdel.c (check_markers, make_gap_larger, make_gap_smaller):
2300 (reset_var_on_error, Fcombine_after_change_execute_1): Now static.
2301 (CHECK_MARKERS): Redo to avoid gcc -Wempty-body diagnostic.
2302 (copy_text): Remove unused local var.
2303
2304 * filelock.c (within_one_second): Now static.
2305 (lock_file_1): Rename local to avoid shadowing.
2306
2307 * buffer.c (fix_overlays_before): Mark locals as initialized.
2308 (fix_start_end_in_overlays): Likewise. This function should be
2309 simplified by using pointers-to-pointers, but that's a different
2310 matter.
2311 (switch_to_buffer_1): Now static.
2312 (Fkill_buffer, record_buffer, Fbury_buffer, Fset_buffer_multibyte):
2313 (report_overlay_modification): Rename locals to avoid shadowing.
2314
2315 * sysdep.c (system_process_attributes): Rename vars to avoid shadowing.
2316 Fix pointer signedness issue.
2317 (sys_subshell): Mark local as volatile if checking for lint,
2318 to suppress a gcc -Wclobbered warning that does not seem to be right.
2319 (MAXPATHLEN): Define only if needed.
2320
2321 * process.c (serial_open, serial_configure): Move decls from here ...
2322 * systty.h: ... to here, so that they can be checked.
2323
2324 * fns.c (get_random, seed_random): Move extern decls from here ...
2325 * lisp.h: ... to here, so that they can be checked.
2326
2327 * sysdep.c (reset_io): Now static.
2328 (wait_for_termination_signal): Remove; unused.
2329
2330 * keymap.c (keymap_parent, keymap_memberp, map_keymap_internal):
2331 (copy_keymap_item, append_key, push_text_char_description):
2332 Now static.
2333 (Fwhere_is_internal): Don't test CONSP (sequences) unnecessarily.
2334 (DENSE_TABLE_SIZE): Remove; unused.
2335 (get_keymap, access_keymap, Fdefine_key, Fwhere_is_internal):
2336 (describe_map_tree):
2337 Rename locals to avoid shadowing.
2338
2339 * keyboard.c: Declare functions static if they are not used elsewhere.
2340 (echo_char, echo_dash, cmd_error, top_level_2):
2341 (poll_for_input, handle_async_input): Now static.
2342 (read_char, kbd_buffer_get_event, make_lispy_position):
2343 (make_lispy_event, make_lispy_movement, apply_modifiers):
2344 (decode_keyboard_code, tty_read_avail_input, menu_bar_items):
2345 (parse_tool_bar_item, read_key_sequence, Fread_key_sequence):
2346 (Fread_key_sequence_vector): Rename locals to avoid shadowing.
2347 (read_key_sequence, read_char): Mark locals as initialized.
2348 (Fexit_recursive_edit, Fabort_recursive_edit): Mark with NO_RETURN.
2349
2350 * keyboard.h (make_ctrl_char): New decl.
2351 (mark_kboards): Move decl here ...
2352 * alloc.c (mark_kboards): ... from here.
2353
2354 * lisp.h (force_auto_save_soon): New decl.
2355
2356 * emacs.c (init_cmdargs): Rename local to avoid shadowing.
2357 (DEFINE_DUMMY_FUNCTION): New macro.
2358 (__do_global_ctors, __do_global_ctors_aux, __do_global_dtors, __main):
2359 Use it.
2360 (main): Add casts to avoid warnings
2361 if GCC considers string literals to be constants.
2362
2363 * lisp.h (fatal_error_signal): Add decl, since it's exported.
2364
2365 * dbusbind.c: Pointer signedness fixes.
2366 (xd_signature, xd_append_arg, xd_initialize):
2367 (Fdbus_call_method, Fdbus_call_method_asynchronously):
2368 (Fdbus_method_return_internal, Fdbus_method_error_internal):
2369 (Fdbus_send_signal, xd_read_message_1, Fdbus_register_service):
2370 (Fdbus_register_signal): Use SSDATA when the context wants char *.
2371
2372 * dbusbind.c (Fdbus_init_bus): Add cast to avoid warning
2373 if GCC considers string literals to be constants.
2374 (Fdbus_register_service, Fdbus_register_method): Remove unused vars.
2375
2376 2011-03-16 Stefan Monnier <monnier@iro.umontreal.ca>
2377
2378 * print.c (PRINT_CIRCLE_CANDIDATE_P): New macro.
2379 (print_preprocess, print_object): New macro to fix last change.
2380
2381 * print.c (print_preprocess): Don't forget font objects.
2382
2383 2011-03-16 Juanma Barranquero <lekktu@gmail.com>
2384
2385 * emacs.c (USAGE3): Doc fixes.
2386
2387 2011-03-15 Andreas Schwab <schwab@linux-m68k.org>
2388
2389 * coding.c (detect_coding_iso_2022): Reorganize code to clarify
2390 structure.
2391
2392 2011-03-14 Juanma Barranquero <lekktu@gmail.com>
2393
2394 * lisp.h (VWindow_system, Qfile_name_history):
2395 * keyboard.h (lispy_function_keys) [WINDOWSNT]:
2396 * w32term.h (w32_system_caret_hwnd, w32_system_caret_height)
2397 (w32_system_caret_x, w32_system_caret_y): Declare extern.
2398
2399 * w32select.c: Don't #include "keyboard.h".
2400 (run_protected): Add extern declaration for waiting_for_input.
2401
2402 * w32.c (Qlocal, noninteractive1, inhibit_window_system):
2403 * w32console.c (detect_input_pending, read_input_pending)
2404 (encode_terminal_code):
2405 * w32fns.c (quit_char, lispy_function_keys, Qtooltip)
2406 (w32_system_caret_hwnd, w32_system_caret_height, w32_system_caret_x)
2407 (w32_system_caret_y, Qfile_name_history):
2408 * w32font.c (w32font_driver, QCantialias, QCotf, QClang):
2409 * w32inevt.c (reinvoke_input_signal, lispy_function_keys):
2410 * w32menu.c (Qmenu_bar, QCtoggle, QCradio, Qoverriding_local_map)
2411 (Qoverriding_terminal_local_map, Qmenu_bar_update_hook):
2412 * w32proc.c (Qlocal, report_file_error):
2413 * w32term.c (Vwindow_system, updating_frame):
2414 * w32uniscribe.c (initialized, uniscribe_font_driver):
2415 Remove unneeded extern declarations.
2416
2417 2011-03-14 Chong Yidong <cyd@stupidchicken.com>
2418
2419 * buffer.c (Fmake_indirect_buffer): Fix incorrect assertions.
2420
2421 2011-03-13 Chong Yidong <cyd@stupidchicken.com>
2422
2423 * buffer.h (BUF_BEGV, BUF_BEGV_BYTE, BUF_ZV, BUF_ZV_BYTE, BUF_PT)
2424 (BUF_PT_BYTE): Rewrite to handle indirect buffers (Bug#8219).
2425 These macros can no longer be used for assignment.
2426
2427 * buffer.c (Fget_buffer_create, Fmake_indirect_buffer):
2428 Assign struct members directly, instead of using BUF_BEGV etc.
2429 (record_buffer_markers, fetch_buffer_markers): New functions for
2430 recording and fetching special buffer markers.
2431 (set_buffer_internal_1, set_buffer_temp): Use them.
2432
2433 * lread.c (unreadchar): Use SET_BUF_PT_BOTH.
2434
2435 * insdel.c (adjust_point): Use SET_BUF_PT_BOTH.
2436
2437 * intervals.c (temp_set_point_both): Use SET_BUF_PT_BOTH.
2438 (get_local_map): Use SET_BUF_BEGV_BOTH and SET_BUF_ZV_BOTH.
2439
2440 * xdisp.c (hscroll_window_tree):
2441 (reconsider_clip_changes): Use PT instead of BUF_PT.
2442
2443 2011-03-13 Eli Zaretskii <eliz@gnu.org>
2444
2445 * makefile.w32-in ($(BLD)/editfns.$(O)): Depend on
2446 $(EMACS_ROOT)/lib/intprops.h.
2447
2448 2011-03-13 Paul Eggert <eggert@cs.ucla.edu>
2449
2450 Fix more problems found by GCC 4.5.2's static checks.
2451
2452 * gtkutil.c (xg_get_pixbuf_from_pixmap): Add cast from char *
2453 to unsigned char * to avoid compiler diagnostic.
2454 (xg_free_frame_widgets): Make it clear that a local variable is
2455 needed only if USE_GTK_TOOLTIP.
2456 (gdk_window_get_screen): Make it clear that this macro is needed
2457 only if USE_GTK_TOOLTIP.
2458 (int_gtk_range_get_value): New function, which avoids a diagnostic
2459 from gcc -Wbad-function-cast.
2460 (xg_set_toolkit_scroll_bar_thumb): Use it.
2461 (xg_tool_bar_callback, xg_tool_item_stale_p): Rewrite to avoid
2462 diagnostic from gcc -Wbad-function-cast.
2463 (get_utf8_string, xg_get_file_with_chooser):
2464 Rename locals to avoid shadowing.
2465 (create_dialog): Move locals to avoid shadowing.
2466
2467 * xgselect.c (xg_select): Remove unused var.
2468
2469 * image.c (four_corners_best): Mark locals as initialized.
2470 (gif_load): Initialize transparent_p to zero (Bug#8238).
2471 Mark another local as initialized.
2472 (my_png_error, my_error_exit): Mark with NO_RETURN.
2473
2474 * image.c (clear_image_cache): Now static.
2475 (DIM, HAVE_STDLIB_H_1): Remove unused macros.
2476 (xpm_load): Redo to avoid "discards qualifiers" gcc warning.
2477 (x_edge_detection): Remove unnecessary cast that
2478 gcc -Wbad-function-cast diagnoses.
2479 (gif_load): Fix pointer signedness.
2480 (clear_image_cache, xbm_read_bitmap_data, x_detect_edges):
2481 (jpeg_load, gif_load): Rename locals to avoid shadowing.
2482
2483 2011-03-12 Paul Eggert <eggert@cs.ucla.edu>
2484
2485 Improve quality of tests for time stamp overflow.
2486 For example, without this patch (encode-time 0 0 0 1 1
2487 1152921504606846976) returns the obviously-bogus value (-948597
2488 62170) on my RHEL 5.5 x86-64 host. With the patch, it correctly
2489 reports time overflow. See
2490 <http://lists.gnu.org/archive/html/emacs-devel/2011-03/msg00470.html>.
2491 * deps.mk (editfns.o): Depend on ../lib/intprops.h.
2492 * editfns.c: Include limits.h and intprops.h.
2493 (TIME_T_MIN, TIME_T_MAX): New macros.
2494 (time_overflow): Move earlier, to before first use.
2495 (hi_time, lo_time): New functions, for an accurate test for
2496 out-of-range times.
2497 (Fcurrent_time, Fget_internal_run_time, make_time): Use them.
2498 (Fget_internal_run_time): Don't assume time_t fits in int.
2499 (make_time): Use list2 instead of Fcons twice.
2500 (Fdecode_time): More accurate test for out-of-range times.
2501 (check_tm_member): New function.
2502 (Fencode_time): Use it, to test for out-of-range times.
2503 (lisp_time_argument): Don't rely on undefined left-shift and
2504 right-shift behavior when checking for time stamp overflow.
2505
2506 * editfns.c (time_overflow): New function, refactoring common code.
2507 (Fformat_time_string, Fdecode_time, Fencode_time):
2508 (Fcurrent_time_string): Use it.
2509
2510 Move 'make_time' to be next to its inverse 'lisp_time_argument'.
2511 * dired.c (make_time): Move to ...
2512 * editfns.c (make_time): ... here.
2513 * systime.h: Note the move.
2514
2515 2011-03-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
2516
2517 * fringe.c (update_window_fringes): Remove unused variables.
2518
2519 * unexmacosx.c (copy_data_segment): Also copy __got section.
2520 (Bug#8223)
2521
2522 2011-03-12 Eli Zaretskii <eliz@gnu.org>
2523
2524 * termcap.c [MSDOS]: Include "msdos.h".
2525 (find_capability, tgetnum, tgetflag, tgetstr, tputs, tgetent):
2526 Constify `char *' arguments and their references according to
2527 prototypes in tparam.h.
2528
2529 * deps.mk (termcap.o): Depend on tparam.h and msdos.h.
2530
2531 * msdos.c (XMenuAddPane): 3rd argument is `const char *' now.
2532 Adapt all references accordingly.
2533
2534 * msdos.h (XMenuAddPane): 3rd argument is `const char *' now.
2535
2536 2011-03-11 Tom Tromey <tromey@redhat.com>
2537
2538 * buffer.c (syms_of_buffer): Remove obsolete comment.
2539
2540 2011-03-11 Eli Zaretskii <eliz@gnu.org>
2541
2542 * termhooks.h (encode_terminal_code): Declare prototype.
2543
2544 * msdos.c (encode_terminal_code): Don't declare prototype.
2545
2546 * term.c (encode_terminal_code): Now external again, used by
2547 w32console.c and msdos.c.
2548
2549 * makefile.w32-in ($(BLD)/term.$(O), ($(BLD)/tparam.$(O)):
2550 Depend on $(SRC)/tparam.h, see 2011-03-11T07:24:21Z!eggert@cs.ucla.edu.
2551
2552 2011-03-11 Paul Eggert <eggert@cs.ucla.edu>
2553
2554 Fix some minor problems found by GCC 4.5.2's static checks.
2555
2556 * fringe.c (update_window_fringes): Mark locals as initialized
2557 (Bug#8227).
2558 (destroy_fringe_bitmap, init_fringe_bitmap): Now static.
2559
2560 * alloc.c (mark_fringe_data): Move decl from here ...
2561 * lisp.h (mark_fringe_data) [HAVE_WINDOW_SYSTEM]: ... to here,
2562 to check its interface.
2563 (init_fringe_once): Do not declare unless HAVE_WINDOW_SYSTEM.
2564
2565 * fontset.c (free_realized_fontset): Now static.
2566 (Fset_fontset_font): Rename local to avoid shadowing.
2567 (fontset_font): Mark local as initialized.
2568 (FONTSET_SPEC, FONTSET_REPERTORY, RFONT_DEF_REPERTORY): Remove; unused.
2569
2570 * xrdb.c: Include "xterm.h", to check x_load_resources's interface.
2571
2572 * xselect.c (x_disown_buffer_selections): Remove; not used.
2573 (TRACE3) [!defined TRACE_SELECTION]: Remove; not used.
2574 (x_own_selection, Fx_disown_selection_internal): Rename locals
2575 to avoid shadowing.
2576 (x_handle_dnd_message): Remove local to avoid shadowing.
2577
2578 * lisp.h (GCPRO1_VAR, UNGCPRO_VAR): New macros,
2579 so that the caller can use some name other than gcpro1.
2580 (GCPRO1, UNGCPRO): Reimplement in terms of the new macros.
2581 * xfns.c (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
2582 (Fx_backspace_delete_keys_p):
2583 Use them to avoid shadowing, and rename vars to avoid shadowing.
2584 (x_decode_color, x_set_name, x_window): Now static.
2585 (Fx_create_frame): Add braces to silence GCC warning.
2586 (Fx_file_dialog, Fx_select_font): Fix pointer signedness.
2587 (x_real_positions, xg_set_icon_from_xpm_data, x_create_tip_frame):
2588 Remove unused locals.
2589 (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
2590 (Fx_backspace_delete_keys_p): Rename locals to avoid shadowing.
2591 Some of these renamings use the new GCPRO1_VAR and UNGCPRO_VAR
2592 macros.
2593
2594 * xterm.h (x_mouse_leave): New decl.
2595
2596 * xterm.c (x_copy_dpy_color, x_focus_on_frame, x_unfocus_frame):
2597 Remove unused functions.
2598 (x_shift_glyphs_for_insert, XTflash, XTring_bell):
2599 (x_calc_absolute_position): Now static.
2600 (XTread_socket): Don't define label "out" unless it's used.
2601 Don't declare local "event" unless it's used.
2602 (x_iconify_frame, x_free_frame_resources): Don't declare locals
2603 unless they are used.
2604 (XEMBED_VERSION, xembed_set_info): Don't define unless needed.
2605 (x_fatal_error_signal): Remove; not used.
2606 (x_draw_image_foreground, redo_mouse_highlight, XTmouse_position):
2607 (x_scroll_bar_report_motion, handle_one_xevent, x_draw_bar_cursor):
2608 (x_error_catcher, x_connection_closed, x_error_handler):
2609 (x_error_quitter, xembed_send_message, x_iconify_frame):
2610 (my_log_handler): Rename locals to avoid shadowing.
2611 (x_delete_glyphs, x_ins_del_lines): Mark with NO_RETURN.
2612 (x_connection_closed): Tell GCC not to suggest NO_RETURN.
2613
2614 * xfaces.c (clear_face_cache, Fx_list_fonts, Fface_font):
2615 Rename or move locals to avoid shadowing.
2616 (tty_defined_color, merge_face_heights): Now static.
2617 (free_realized_faces_for_fontset): Remove; not used.
2618 (Fx_list_fonts): Mark variable that gcc -Wuninitialized
2619 does not deduce is never used uninitialized.
2620 (STRDUPA, LSTRDUPA, FONT_POINT_SIZE_QUANTUM): Remove; not used.
2621 (LFACEP): Define only if XASSERTS, as it's not needed otherwise.
2622
2623 * terminal.c (store_terminal_param): Now static.
2624
2625 * xmenu.c (menu_highlight_callback): Now static.
2626 (set_frame_menubar): Remove unused local.
2627 (xmenu_show): Rename parameter to avoid shadowing.
2628 (xmenu_show, xdialog_show, xmenu_show): Make local pointers "const"
2629 since they might point to immutable storage.
2630 (next_menubar_widget_id): Declare only if USE_X_TOOLKIT,
2631 since it's unused otherwise.
2632
2633 * xdisp.c (produce_glyphless_glyph): Initialize lower_xoff.
2634 Add a FIXME, since the code still doesn't look right. (Bug#8215)
2635 (Fcurrent_bidi_paragraph_direction): Simplify slightly; this
2636 avoids a gcc -Wuninitialized diagnostic.
2637 (display_line, BUILD_COMPOSITE_GLYPH_STRING, draw_glyphs):
2638 (note_mouse_highlight): Mark variables that gcc -Wuninitialized
2639 does not deduce are never used uninitialized.
2640
2641 * lisp.h (IF_LINT): New macro, copied from ../lib-src/emacsclient.c.
2642
2643 * xdisp.c (redisplay_window): Rename local to avoid shadowing.
2644 * window.c (window_loop, size_window):
2645 (run_window_configuration_change_hook, enlarge_window): Likewise.
2646
2647 * window.c (display_buffer): Now static.
2648 (size_window): Mark variables that gcc -Wuninitialized
2649 does not deduce are never used uninitialized.
2650 * window.h (check_all_windows): New decl, to forestall
2651 gcc -Wmissing-prototypes diagnostic.
2652 * dispextern.h (bidi_dump_cached_states): Likewise.
2653
2654 * charset.h (CHECK_CHARSET_GET_CHARSET): Rename locals to avoid
2655 shadowing.
2656 * charset.c (map_charset_for_dump, Fchar_charset): Likewise.
2657 Include <limits.h>.
2658 (Fsort_charsets): Redo min/max calculation to shorten the code a bit
2659 and to avoid gcc -Wuninitialized warning.
2660 (load_charset_map): Mark variables that gcc -Wuninitialized
2661 does not deduce are never used uninitialized.
2662 (load_charset): Abort instead of using uninitialized var (Bug#8229).
2663
2664 * coding.c (coding_set_source, coding_set_destination):
2665 Use "else { /* comment */ }" rather than "else /* comment */;"
2666 for clarity, and to avoid gcc -Wempty-body warning.
2667 (Fdefine_coding_system_internal): Don't redeclare 'i' inside
2668 a block, when the outer 'i' will do.
2669 (decode_coding_utf_8, decode_coding_utf_16, detect_coding_emacs_mule):
2670 (emacs_mule_char, decode_coding_emacs_mule, detect_coding_iso_2022):
2671 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5):
2672 (decode_coding_raw_text, decode_coding_charset, get_translation_table):
2673 (Fdecode_sjis_char, Fdefine_coding_system_internal):
2674 Rename locals to avoid shadowing.
2675 * character.h (FETCH_STRING_CHAR_ADVANCE): Likewise.
2676 * coding.c (emacs_mule_char, encode_invocation_designation):
2677 Now static, since they're not used elsewhere.
2678 (decode_coding_iso_2022): Add "default: abort ();" as a safety check.
2679 (decode_coding_object, encode_coding_object, detect_coding_system):
2680 (decode_coding_emacs_mule): Mark variables that gcc
2681 -Wuninitialized does not deduce are never used uninitialized.
2682 (detect_coding_iso_2022): Initialize a local variable that might
2683 be used uninitialized. Leave a FIXME because it's not clear that
2684 this initialization is needed. (Bug#8211)
2685 (ISO_CODE_LF, ISO_CODE_CR, CODING_ISO_FLAG_EUC_TW_SHIFT):
2686 (ONE_MORE_BYTE_NO_CHECK, UTF_BOM, UTF_16_INVALID_P):
2687 (SHIFT_OUT_OK, ENCODE_CONTROL_SEQUENCE_INTRODUCER):
2688 (ENCODE_DIRECTION_R2L, ENCODE_DIRECTION_L2R):
2689 Remove unused macros.
2690
2691 * category.c (hash_get_category_set): Remove unused local var.
2692 (copy_category_table): Now static, since it's not used elsewhere.
2693 * character.c (string_count_byte8): Likewise.
2694
2695 * ccl.c (CCL_WRITE_STRING, CCL_ENCODE_CHAR, Fccl_execute_on_string):
2696 (Fregister_code_conversion_map): Rename locals to avoid shadowing.
2697
2698 * chartab.c (copy_sub_char_table): Now static, since it's not used
2699 elsewhere.
2700 (sub_char_table_ref_and_range, char_table_ref_and_range):
2701 Rename locals to avoid shadowing.
2702 (ASET_RANGE, GET_SUB_CHAR_TABLE): Remove unused macros.
2703
2704 * bidi.c (bidi_check_type): Now static, since it's not used elsewhere.
2705 (BIDI_BOB): Remove unused macro.
2706
2707 * cm.c (cmgoto): Mark variables that gcc -Wuninitialized does not
2708 deduce are never used uninitialized.
2709 * term.c (encode_terminal_code): Likewise.
2710
2711 * term.c (encode_terminal_code): Now static. Remove unused local.
2712
2713 * tparam.h: New file.
2714 * term.c, tparam.h: Include it.
2715 * deps.mk (term.o, tparam.o): Depend on tparam.h.
2716 * term.c (tputs, tgetent, tgetflag, tgetnum, tparam, tgetstr):
2717 Move these decls to tparam.h, and make them agree with what
2718 is actually in tparam.c. The previous trick of using incompatible
2719 decls in different modules does not conform to the C standard.
2720 All callers of tparam changed to use tparam's actual API.
2721 * tparam.c (tparam1, tparam, tgoto):
2722 Use const pointers where appropriate.
2723
2724 * cm.c (calccost, cmgoto): Use const pointers where appropriate.
2725 * cm.h (struct cm): Likewise.
2726 * dispextern.h (do_line_insertion_deletion_costs): Likewise.
2727 * scroll.c (ins_del_costs, do_line_insertion_deletion_costs): Likewise.
2728 * term.c (tty_ins_del_lines, calculate_costs, struct fkey_table):
2729 (term_get_fkeys_1, append_glyphless_glyph, produce_glyphless_glyph):
2730 (turn_on_face, init_tty): Likewise.
2731 * termchar.h (struct tty_display_info): Likewise.
2732
2733 * term.c (term_mouse_position): Rename local to avoid shadowing.
2734
2735 * alloc.c (mark_ttys): Move decl from here ...
2736 * lisp.h (mark_ttys): ... to here, so that it's checked against defn.
2737
2738 2011-03-11 Andreas Schwab <schwab@linux-m68k.org>
2739
2740 * .gdbinit (pwinx, xbuffer): Fix access to buffer name.
2741
2742 2011-03-09 Juanma Barranquero <lekktu@gmail.com>
2743
2744 * search.c (compile_pattern_1): Remove argument regp, unused since
2745 revid:rms@gnu.org-19941211082627-3x1g1wyqkjmwloig.
2746 (compile_pattern): Don't pass it.
2747
2748 2011-03-08 Jan Djärv <jan.h.d@swipnet.se>
2749
2750 * xterm.h (DEFAULT_GDK_DISPLAY): New define.
2751 (GDK_WINDOW_XID, gtk_widget_get_preferred_size): New defines
2752 for ! HAVE_GTK3.
2753 (GTK_WIDGET_TO_X_WIN): Use GDK_WINDOW_XID.
2754
2755 * xmenu.c (menu_position_func): Call gtk_widget_get_preferred_size.
2756
2757 * gtkutil.c: Include gtkx.h if HAVE_GTK3. If ! HAVE_GTK3, define
2758 gdk_window_get_screen, gdk_window_get_geometry,
2759 gdk_x11_window_lookup_for_display and GDK_KEY_g.
2760 (xg_set_screen): Use DEFAULT_GDK_DISPLAY.
2761 (xg_get_pixbuf_from_pixmap): New function.
2762 (xg_get_pixbuf_from_pix_and_mask): Change parameters from GdkPixmap
2763 to Pixmap, take frame as parameter, remove GdkColormap parameter.
2764 Call xg_get_pixbuf_from_pixmap instead of
2765 gdk_pixbuf_get_from_drawable.
2766 (xg_get_image_for_pixmap): Do not make GdkPixmaps, call
2767 xg_get_pixbuf_from_pix_and_mask with Pixmap parameters instead.
2768 (xg_check_special_colors): Use GtkStyleContext and its functions
2769 for HAVE_GTK3.
2770 (xg_prepare_tooltip, xg_hide_tooltip): Call gdk_window_get_screen.
2771 (xg_prepare_tooltip, create_dialog, menubar_map_cb)
2772 (xg_update_frame_menubar, xg_tool_bar_detach_callback)
2773 (xg_tool_bar_attach_callback, xg_update_tool_bar_sizes):
2774 Call gtk_widget_get_preferred_size.
2775 (xg_frame_resized): gdk_window_get_geometry only takes 5
2776 parameters.
2777 (xg_win_to_widget, xg_event_is_for_menubar):
2778 Call gdk_x11_window_lookup_for_display.
2779 (xg_set_widget_bg): New function.
2780 (delete_cb): New function.
2781 (xg_create_frame_widgets): Connect delete-event to delete_cb.
2782 Call xg_set_widget_bg. Only set backgrund pixmap for ! HAVE_GTK3
2783 (xg_set_background_color): Call xg_set_widget_bg.
2784 (xg_set_frame_icon): Call xg_get_pixbuf_from_pix_and_mask.
2785 (xg_create_scroll_bar): vadj is a GtkAdjustment for HAVE_GTK3.
2786 Only call gtk_range_set_update_policy if ! HAVE_GTK3.
2787 (xg_make_tool_item): Only connect xg_tool_bar_item_expose_callback
2788 if ! HAVE_GTK3.
2789 (update_frame_tool_bar): Call gtk_widget_hide.
2790 (xg_initialize): Use GDK_KEY_g.
2791
2792 * xsmfns.c (gdk_set_sm_client_id): Define to gdk_set_sm_client_id
2793 if ! HAVE_GTK3
2794 (x_session_initialize): Call gdk_x11_set_sm_client_id.
2795
2796 * xterm.c (XFillRectangle): Use cairo routines for HAVE_GTK3.
2797 (x_term_init): Disable Xinput(2) with GDK_CORE_DEVICE_EVENTS.
2798 Load ~/emacs.d/gtkrc only for ! HAVE_GTK3.
2799
2800 2011-03-08 Juanma Barranquero <lekktu@gmail.com>
2801
2802 * w32xfns.c (select_palette): Check success of RealizePalette against
2803 GDI_ERROR, not zero.
2804
2805 See ChangeLog.11 for earlier changes.
2806
2807 ;; Local Variables:
2808 ;; coding: utf-8
2809 ;; End:
2810
2811 Copyright (C) 2011 Free Software Foundation, Inc.
2812
2813 This file is part of GNU Emacs.
2814
2815 GNU Emacs is free software: you can redistribute it and/or modify
2816 it under the terms of the GNU General Public License as published by
2817 the Free Software Foundation, either version 3 of the License, or
2818 (at your option) any later version.
2819
2820 GNU Emacs is distributed in the hope that it will be useful,
2821 but WITHOUT ANY WARRANTY; without even the implied warranty of
2822 MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
2823 GNU General Public License for more details.
2824
2825 You should have received a copy of the GNU General Public License
2826 along with GNU Emacs. If not, see <http://www.gnu.org/licenses/>.