1 2012-08-04 Eli Zaretskii <eliz@gnu.org>
3 * xfns.c (x_set_menu_bar_lines): Fix compilation error in
4 --with-x-toolkit=no builds.
5 Reported by Carsten Mattner <carstenmattner@gmail.com>.
7 2012-08-04 Chong Yidong <cyd@gnu.org>
9 * syntax.c (Fmodify_syntax_entry): Doc fix.
11 2012-08-04 Eli Zaretskii <eliz@gnu.org>
13 Fix startup warnings about ../site-lisp on MS-Windows. (Bug#11959)
14 * w32.c (init_environment): Change the default values of many
15 environment variables in dflt_envvars[] to NULL, to avoid pushing
16 them into environment when they were not already defined. Remove
17 the code that deletes site-lisp subdirectories from the default
18 value of EMACSLOADPATH, as it is no longer needed.
19 (check_windows_init_file): Now external, not static. Use
20 Vload_path as is, without adding anything, as this function is now
21 called when Vload_path is already set up.
23 * w32.h (check_windows_init_file): Add prototype.
25 * emacs.c (init_cmdargs) [WINDOWSNT]: When running from the build
26 directory, ignore the /*/i386/ tail in Vinvocation_directory, for
27 compatibility with Posix platforms.
28 (main): Move the call to check_windows_init_file to here from
30 (decode_env_path) [WINDOWSNT]: Expand the %emacs_dir%/ prefix, if
31 any, in the DEFALT argument into the root of the Emacs build or
32 installation tree, as appropriate.
34 * callproc.c (init_callproc_1): Call decode_env_path instead of
35 doing its equivalent by hand.
36 (init_callproc): Replace DOS_NT condition with MSDOS, thus letting
37 the code that sets Vexec_path run on MS-Windows.
39 * lread.c (init_lread): Add comments to #ifdef's.
41 * msdos.c (dos_set_window_size, IT_update_begin)
42 (IT_frame_up_to_date, IT_set_frame_parameters): Use FVAR and WVAR
43 instead of direct references.
45 2012-08-04 Paul Eggert <eggert@cs.ucla.edu>
47 Export DEFAULT_REHASH_* to GDB.
48 * lisp.h (DEFAULT_REHASH_THRESHOLD, DEFAULT_REHASH_SIZE):
49 Now constants, not macros.
51 2012-08-03 Paul Eggert <eggert@cs.ucla.edu>
53 Remove unnecessary casts involving pointers.
54 These casts are no longer needed now that we assume C89 or later,
55 since they involve casting to or from void *.
56 * alloc.c (make_pure_string, make_pure_c_string, pure_cons)
57 (make_pure_float, make_pure_vector):
58 * lisp.h (SAFE_ALLOCA, SAFE_ALLOCA_LISP):
59 * macros.c (Fstart_kbd_macro):
60 * menu.c (find_and_return_menu_selection):
61 * minibuf.c (read_minibuf_noninteractive):
62 * sysdep.c (closedir):
63 * xdisp.c (x_produce_glyphs):
64 * xfaces.c (compare_fonts_by_sort_order):
65 * xfns.c (x_real_positions, select_visual):
66 * xselect.c (x_stop_queuing_selection_requests)
67 (x_get_window_property, x_get_window_property_as_lisp_data):
68 * xterm.c (x_set_frame_alpha, x_find_modifier_meanings):
69 Remove unnecessary pointer casts.
70 * alloc.c (record_xmalloc): New function.
71 * lisp.h (record_xmalloc): New decl.
72 (SAFE_ALLOCA): Now takes just one arg -- the size -- and acts
73 more like a function. This is because the pointer cast is not
74 needed. All uses changed.
75 * print.c (print_string, print_error_message): Avoid length recalc.
77 Improve fix for macroexp crash with debugging (Bug#12118).
78 * lisp.h (ASET) [ENABLE_CHECKING]: Pay attention to
79 ARRAY_MARK_FLAG when checking subscripts, because ASET is
80 not supposed to be invoked from the garbage collector.
81 See Andreas Schwab in <http://bugs.gnu.org/12118#25>.
82 (gc_aset): New function, which is like ASET but can be
83 used in the garbage collector.
84 (set_hash_key, set_hash_value, set_hash_next, set_hash_hash)
85 (set_hash_index): Use it instead of ASET.
87 2012-08-03 Eli Zaretskii <eliz@gnu.org>
89 Support symlinks on latest versions of MS-Windows.
90 * w32.c: Include winioctl.h and aclapi.h.
91 (is_symlink, chase_symlinks, enable_privilege, restore_privilege)
92 (revert_to_self): Forward declarations of static functions.
93 <static BOOL g_b_init_get_security_info>:
94 <g_b_init_create_symbolic_link>: New static flags.
95 (globals_of_w32): Initialize them to zero.
96 (GetSecurityInfo_Proc, CreateSymbolicLink_Proc): New typedefs.
97 (map_w32_filename): Improve commentary. Simplify switch.
98 (SYMBOLIC_LINK_FLAG_DIRECTORY): Define if not defined in system
99 headers (most versions of MinGW w32api don't).
100 (get_security_info, create_symbolic_link)
101 (get_file_security_desc_by_handle, is_symlink, chase_symlinks):
103 (sys_access, sys_chmod): Call 'chase_symlinks' to resolve symlinks
104 in the argument file name.
105 (sys_access): Call unc_volume_file_attributes only if
106 GetFileAttributes fails with network-related error codes.
107 (sys_rename): Diagnose renaming of a symlink when the user doesn't
108 have the required privileges.
109 (get_file_security_desc_by_name): Renamed from
110 get_file_security_desc.
111 (stat_worker): New function, with most of the guts of 'stat', and
112 with addition of handling of symlinks and support for 'lstat'. If
113 possible, get file's attributes and security information by
114 handle, not by name. Produce S_IFLNK bit for symlinks, when
116 (stat, lstat): New functions, call 'stat_worker'.
117 (symlink, readlink, careadlinkat): Rewritten to create and resolve
118 symlinks when the underlying filesystem supports them.
120 2012-08-02 Paul Eggert <eggert@cs.ucla.edu>
122 Fix macroexp crash on Windows with debugging (Bug#12118).
123 * lisp.h (ASET) [ENABLE_CHECKING]: Ignore ARRAY_MARK_FLAG when
124 checking subscripts; problem introduced with the recent
125 "ASET (a, i, v)" rather than "AREF (a, i) = v" patch.
126 (ARRAY_MARK_FLAG): Now a macro as well as a constant,
127 since it's used in non-static inline functions now.
129 * xfaces.c (face_at_buffer_position, face_for_overlay_string):
130 Don't assume buffer size fits in 'int'. Remove unused local.
132 Use C99-style 'extern inline' if available.
133 * buffer.h (BUFFER_INLINE):
134 * category.h (CATEGORY_INLINE):
135 * character.h (CHARACTER_INLINE):
136 * charset.h (CHARSET_INLINE):
137 * composite.h (COMPOSITE_INLINE):
138 * dispextern.h (DISPEXTERN_INLINE):
139 * lisp.h (LISP_INLINE):
140 * systime.h (SYSTIME_INLINE):
141 New macro, replacing 'static inline' in this header.
142 * buffer.h, category.h, character.h, charset.h, composite.h:
143 * dispextern.h, lisp.h, systime.h:
144 Use INLINE_HEADER_BEGIN, INLINE_HEADER_END.
145 * alloc.c (LISP_INLINE):
146 * buffer.c (BUFFER_INLINE):
147 * category.c (CATEGORY_INLINE):
148 * character.c (CHARACTER_INLINE):
149 * charset.c (CHARSET_INLINE):
150 * composite.c (COMPOSITE_INLINE):
151 * dispnew.c (DISPEXTERN_INLINE):
152 * sysdep.c (SYSTIME_INLINE):
153 Define to EXTERN_INLINE, so that the corresponding functions
154 are compiled into code.
155 * conf_post.h (INLINE, EXTERN_INLINE, INLINE_HEADER_BEGIN)
156 (INLINE_HEADER_END): New macros.
157 * lisp.h (PSEUDOVECTOR_FLAG): Now a macro as well as a constant,
158 since it's used in non-static inline functions now.
159 (VALMASK) [!USE_LSB_TAG]: Likewise.
161 2012-08-02 Glenn Morris <rgm@gnu.org>
163 * s/: Remove empty directory.
165 * s/ms-w32.h: Move to ../nt/inc.
166 * makefile.w32-in (TAGS, TAGS-gmake, MS_W32_H):
167 Update for new ms-w32.h location.
169 2012-08-02 Paul Eggert <eggert@cs.ucla.edu>
172 * syswait.h (WRETCODE): Remove, consistently with ../configure.ac.
174 2012-08-02 Glenn Morris <rgm@gnu.org>
176 * nsterm.m (ns_exec_path, ns_load_path): Use SEPCHAR rather than
177 hard-coding the path separator.
179 2012-08-01 Paul Eggert <eggert@cs.ucla.edu>
181 Use "ASET (a, i, v)" rather than "AREF (a, i) = v".
182 This how ASET and AREF are supposed to work, and makes
183 it easier to think about future improvements. See
184 <http://lists.gnu.org/archive/html/emacs-devel/2012-08/msg00026.html>.
185 * charset.h (set_charset_attr): New function.
186 All lvalue-style uses of CHARSET_DECODER etc. changed to use it.
187 * lisp.h (ASET): Rewrite so as not to use AREF in an lvalue style.
188 (aref_addr): New function. All uses of &AREF(...) changed.
189 (set_hash_key, set_hash_value, set_hash_next, set_hash_hash)
190 (set_hash_index): New functions. All lvalue-style uses of
191 HASH_KEY etc. changed.
192 * keyboard.c (set_prop): New function. All lvalue-style uses
195 2012-08-01 Alp Aker <alp.tekin.aker@gmail.com>
197 * nsterm.m (ns_set_vertical_scroll_bar, ns_redeem_scroll_bar)
198 (EmacsWindow-accessibilityAttributeValue, EmacsScroller-initFrame:)
199 (EmacsScroller-dealloc): Adjust to use WVAR. (Bug#12114)
200 * nsfns.m (ns_set_name_as_filename): Likewise.
201 * nsmenu.m (ns_update_menubar): Likewise.
202 * nsselect.m (symbol_to_nsstring): Adjust to use SVAR.
204 2012-08-01 Eli Zaretskii <eliz@gnu.org>
206 * .gdbinit (xcar, xcdr, xlist, xwindow, nextcons, xprintsym):
207 Adapt to latest changes in field names of the corresponding Lisp
210 * xdisp.c (try_window_id): Use WVAR in IF_DEBUG code.
212 2012-08-01 Glenn Morris <rgm@gnu.org>
214 * s/msdos.h: Remove file.
215 * conf_post.h [MSDOS]: New section, moved from s/msdos.h.
216 * Makefile.in (S_FILE): Remove.
217 (config_h): Remove S_FILE.
219 2012-08-01 Juanma Barranquero <lekktu@gmail.com>
221 * s/ms-w32.h (DEVICE_SEP, IS_DIRECTORY_SEP, IS_ANY_SEP):
222 Remove; moved to nt/config.nt.
224 2012-08-01 Dmitry Antipov <dmantipov@yandex.ru>
226 Use INTERNAL_FIELD for conses and overlays.
227 * lisp.h (struct Lisp_Cons): Use INTERNAL_FIELD.
228 Remove obsolete comment.
230 (struct Lisp_Overlay): Use INTERNAL_FIELD.
231 * alloc.c, buffer.c, buffer.h, fns.c: Adjust users.
233 2012-08-01 Dmitry Antipov <dmantipov@yandex.ru>
235 Use INTERNAL_FIELD for symbols.
236 * lisp.h (SVAR): New macro. Adjust users.
237 * alloc.c, bytecode.c, cmds.c, data.c, doc.c, eval.c:
238 * fns.c, keyboard.c, lread.c, xterm.c: Users changed.
240 2012-08-01 Dmitry Antipov <dmantipov@yandex.ru>
242 Use INTERNAL_FIELD for processes.
243 * process.h (PVAR): New macro. Adjust style.
244 (struct Lisp_Process): Change Lisp_Object members to INTERNAL_FIELD.
245 * print.c, process.c, sysdep.c, w32.c, xdisp.c: Users changed.
247 2012-08-01 Dmitry Antipov <dmantipov@yandex.ru>
249 Use INTERNAL_FIELD for windows.
250 * window.h (WVAR): New macro.
251 (struct window): Change Lisp_Object members to INTERNAL_FIELD.
252 * alloc.c, buffer.c, composite.c, dispextern.h, dispnew.c, editfns.c:
253 * fileio.c, font.c, fontset.c, frame.c, frame.h, fringe.c, indent.c:
254 * insdel.c, keyboard.c, keymap.c, lisp.h, minibuf.c, nsterm.m, print.c:
255 * textprop.c, w32fns.c, w32menu.c, w32term.c, window.c, xdisp.c:
256 * xfaces.c, xfns.c, xmenu.c, xterm.c: Users changed.
258 2012-08-01 Paul Eggert <eggert@cs.ucla.edu>
260 * coding.h (CODING_ATTR_FLUSHING): Remove; unused and wouldn't work.
262 2012-08-01 Glenn Morris <rgm@gnu.org>
264 * lisp.h (IS_DIRECTORY_SEP, IS_DEVICE_SEP, IS_ANY_SEP):
265 Move to configure.ac.
267 2012-08-01 Juanma Barranquero <lekktu@gmail.com>
269 * makefile.w32-in (CONFIG_H): Update dependencies.
270 (CONF_POST_H): New macro.
272 * s/ms-w32.h (SEPCHAR, NULL_DEVICE): Remove; moved to nt/config.nt.
274 2012-07-31 Glenn Morris <rgm@gnu.org>
276 * Makefile.in (S_FILE): No longer set by configure.
278 * conf_post.h (config_opsysfile): Move earlier, so that WINDOWSNT
280 (alloca.h) [WINDOWSNT]: Don't include it on MS Windows.
282 * process.h (NULL_DEVICE):
284 * editfns.c (USER_FULL_NAME): Let configure set them.
286 * s/README, s/template.h: Remove files.
288 * conf_post.h [HPUX]: Undefine HAVE_RANDOM and HAVE_RINT.
290 * conf_post.h (AMPERSAND_FULL_NAME, subprocesses):
291 Move to configure.ac.
293 2012-07-31 Eli Zaretskii <eliz@gnu.org>
295 * .gdbinit (xframe): Adapt to introduction of FVAR and the
296 resulting renaming of 'struct frame' members.
298 * w32menu.c (w32_menu_show): Revert bogus introduction of FVAR.
300 * fontset.c (dump_fontset): Fix compilation with ENABLE_CHECKING
301 after introduction of FVAR.
303 2012-07-31 Jan Djärv <jan.h.d@swipnet.se>
305 * nsmenu.m (update_frame_tool_bar): Change key from NSObject* to id.
307 * nsterm.m (ns_draw_fringe_bitmap, ns_dumpglyphs_image): Use drawInRect
308 instead of compositeToPoint.
309 (applicationShouldTerminate): Pass NS String literal to NSRunAlertPanel.
311 * nsfns.m, nsmenu.m, nsterm.m: Adopt to struct frame/FVAR changes.
313 2012-07-31 Dmitry Antipov <dmantipov@yandex.ru>
315 Generalize INTERNAL_FIELD between buffers, keyboards and frames.
316 * lisp.h (INTERNAL_FIELD): New macro.
317 * buffer.h (BUFFER_INTERNAL_FIELD): Removed.
318 (BVAR): Change to use INTERNAL_FIELD.
319 * keyboard.h (KBOARD_INTERNAL_FIELD): Likewise.
320 (KVAR): Change to use INTERNAL_FIELD.
321 * frame.h (FVAR): New macro.
322 (struct frame): Use INTERNAL_FIELD for all Lisp_Object fields.
323 * alloc.c, buffer.c, data.c, dispnew.c, dosfns.c, eval.c, frame.c:
324 * fringe.c, gtkutil.c, minibuf.c, nsfns.m, nsterm.m, print.c:
325 * term.c, w32fns.c, w32menu.c, w32term.c, window.c, window.h:
326 * xdisp.c, xfaces.c, xfns.c, xmenu.c, xterm.c: Users changed.
328 2012-07-31 Dmitry Antipov <dmantipov@yandex.ru>
330 Miscellaneous fixes for non-default X toolkits.
331 * xfns.c (Fx_file_dialog): Change to SSDATA to avoid warnings.
332 * xterm.c (x_frame_of_widget): Remove redundant prototype.
333 Move under #ifdef USE_LUCID.
334 (x_create_toolkit_scroll_bar): Adjust scroll_bar_name
335 definition and usage to avoid warnings.
337 2012-07-31 Jan Djärv <jan.h.d@swipnet.se>
339 * nsterm.m (openFiles): Fix previous checkin.
341 2012-07-31 Paul Eggert <eggert@cs.ucla.edu>
343 * indent.c (compute_motion): Remove unused local.
345 2012-07-31 Glenn Morris <rgm@gnu.org>
347 * s/usg5-4-common.h (wait3, WRETCODE): Let configure set them.
349 * conf_post.h [USG5_4]:
350 Move remaining contents of s/usg5-4-common.h here.
351 * s/usg5-4-common.h: Remove file.
353 * conf_post.h [IRIX6_5]: Move remaining contents of s/irix6-5.h here.
354 * s/irix6-5.h: Remove file.
356 * conf_post.h [DARWIN_OS]: Move remaining contents of s/darwin.h here.
357 * s/darwin.h: Remove file.
359 * conf_post.h [HPUX]: Move random, srandom here from s/hpux10-20.h.
360 * s/hpux10-20.h: Remove file, which is now empty.
362 2012-07-30 Glenn Morris <rgm@gnu.org>
364 * conf_post.h: New, split from configure.ac's AH_BOTTOM.
365 * Makefile.in (config_h): Add conf_post.h.
366 * makefile.w32-in (CONFIG_H): Add conf_post.h.
368 2012-07-30 Jan Djärv <jan.h.d@swipnet.se>
370 * nsterm.m (ns_do_open_file): New variable.
371 (ns_term_init): Set ns_do_open_file to YES after run returns.
372 (openFile, openTempFile, openFileWithoutUI, openFiles): Open
373 files only if ns_do_open_file.
375 2012-07-30 Paul Eggert <eggert@cs.ucla.edu>
377 * lisp.h (SWITCH_ENUM_CAST): Remove. All uses removed.
378 This no-op macro hasn't been needed for many years.
379 * src/regex.c (SWITCH_ENUM_CAST) [!emacs]: Likewise.
381 Export DIRECTORY_SEP, TYPEMASK, VALMASK to GDB.
382 * alloc.c (gdb_make_enums_visible) [USE_LSB_TAG]: Add lsb_bits.
383 * lisp.h (enum lsb_bits) [USE_LSB_TAG]: New enum, for
384 gdb_make_enums_visible.
385 (TYPEMASK, VALMASK) [USE_LSB_TAGS]: Now enum constants, not macros.
386 (DIRECTORY_SEP): Now a constant, not a macro.
388 2012-07-30 Eli Zaretskii <eliz@gnu.org>
390 * w32fns.c (w32_wnd_proc): Pass w32_keyboard_codepage to
391 w32_kbd_patch_key as the 2nd arg. (Bug#12082)
393 * w32term.c <w32_keyboard_codepage>: Renamed from
394 keyboard_codepage and now external. All users changed.
396 * w32term.h: Add declaration of w32_keyboard_codepage.
398 * w32inevt.c (w32_kbd_patch_key): Accept an additional argument --
399 the codepage to translate keys to Unicode. If this argument is
400 -1, use the value returned by GetConsoleCP. All callers changed.
402 2012-07-30 Paul Eggert <eggert@cs.ucla.edu>
404 Update .PHONY listings in makefiles.
405 * Makefile.in (.PHONY): Add all, mostlyclean, clean,
406 bootstrap-clean, distclean, maintainer-clean, versioclean,
409 * lisp.h (STRING_BYTES_BOUND): Cast entire result to ptrdiff_t.
410 This is a bit clearer. Fix some commentary typos.
412 2012-07-30 Glenn Morris <rgm@gnu.org>
414 * s/netbsd.h: Let configure include signal.h if needed.
415 Remove file, which is now empty.
417 * s/usg5-4-common.h (_longjmp, _setjmp, TIOCSIGSEND):
418 Let configure set them.
419 * s/irix6-5.h (_longjmp, _setjmp, TIOCSIGSEND):
420 No more need to undefine.
422 2012-07-30 Andreas Schwab <schwab@linux-m68k.org>
424 * keymap.c (Fkey_description): Don't remove 0x80 bit from
425 non-single-byte char when adding meta modifier. (Bug#12090)
427 2012-07-30 Dmitry Antipov <dmantipov@yandex.ru>
429 Convert safe_call to use variable number of arguments.
430 * xdisp.c (safe_call): Convert to use varargs. Adjust users.
431 (safe_call2): Fix comment.
432 * lisp.h (safe_call): Adjust prototype.
433 * coding.c (encode_coding_object): Change to use safe_call2.
434 * xfaces.c (merge_face_heights): Change to use safe_call1.
436 2012-07-30 Glenn Morris <rgm@gnu.org>
438 * s/aix4-2.h (sigmask): No need to undefine it, since syssignal.h
439 does that unconditionally. Remove file, which is now empty.
441 * s/freebsd.h, s/gnu-linux.h, s/sol2-6.h, s/unixware.h:
444 2012-07-30 Paul Eggert <eggert@cs.ucla.edu>
446 Export to GDB most of lisp.h's remaining object-like macros.
447 * lisp.h (min, max): Move earlier, because they're used earlier now.
448 (INTMASK, ARRAY_MARK_FLAG, PSEUDOVECTOR_FLAG, VALMASK)
449 (CHAR_TABLE_STANDARD_SLOTS, CHARTAB_SIZE_BITS_0)
450 (CHARTAB_SIZE_BITS_1, CHARTAB_SIZE_BITS_2, CHARTAB_SIZE_BITS_3)
451 (DEFAULT_HASH_SIZE, COMPILED_ARGLIST, COMPILED_BYTECODE)
452 (COMPILED_CONSTANTS, COMPILED_STACK_DEPTH, COMPILED_DOC_STRING)
453 (COMPILED_INTERACTIVE, CHAR_ALT, CHAR_SUPER, CHAR_HYPER, CHAR_SHIFT)
454 (CHAR_CTL, CHAR_META, CHAR_MODIFIER_MASK, CHARACTERBITS)
455 (MANY, UNEVALLED, FLOAT_TO_STRING_BUFSIZE, MAX_ALLOCA):
456 Now constants, for GDB. They need not be macros.
457 (MOST_POSITIVE_FIXNUM, MOST_NEGATIVE_FIXNUM, STRING_BYTES_BOUND):
458 Now constants, for GDB, as well as macros, for static initializers.
459 (CHAR_TABLE_STANDARD_SLOTS, CHAR_TABLE_EXTRA_SLOTS):
460 Move to after the definition of struct Lisp_Char_Table,
461 since the former now needs that type defined.
462 (enum CHARTAB_SIZE_BITS, enum CHAR_TABLE_STANDARD_SLOTS)
463 (enum DEFAULT_HASH_SIZE, enum Lisp_Compiled, enum char_bits)
464 (enum maxargs, enum FLOAT_TO_STRING_BUFSIZE, enum MAX_ALLOCA):
465 New enums, for gdb_make_enums_visible.
466 (GLYPH_MODE_LINE_FACE): Remove; unused.
467 * alloc.c (STRING_BYTES_MAX): Now a constant, not a macro.
468 (gdb_make_enums_visible): Add enum CHARTAB_SIZE_BITS, enum
469 CHAR_TABLE_STANDARD_SLOTS, enum char_bits, enum DEFAULT_HASH_SIZE,
470 enum FLOAT_TO_STRING_BUFSIZE, enum Lisp_Bits, enum Lisp_Compiled,
471 enum maxargs, enum MAX_ALLOCA.
472 (ARRAY_MARK_FLAG_VAL, PSEUDOVECTOR_FLAG_VAL, VALMASK_VAL): Remove.
473 (ARRAY_MARK_FLAG, PSEUDOVECTOR_FLAG, VALMASK): Remove;
474 no longer needed, now that they are done in lisp.h.
476 2012-07-30 Dmitry Antipov <dmantipov@yandex.ru>
478 Cleanup string bytes checking.
479 * alloc.c (GC_STRING_BYTES, CHECK_STRING_BYTES): Remove. Convert
480 all users to STRING_BYTES or string_bytes if GC_CHECK_STRING_BYTES.
481 (check_string_bytes): Define to empty if not GC_CHECK_STRING_BYTES.
482 (check_sblock, compact_small_strings): Simplify.
484 2012-07-29 Paul Eggert <eggert@cs.ucla.edu>
486 * lisp.h (LISP_INT_TAG, LISP_INT1_TAG, LISP_STRING_TAG): Remove.
487 These macros are confusing and no longer need to be defined, as
488 the enum values now suffice. All uses replaced with definiens.
489 (Lisp_Int1, Lisp_String): Define directly; this is clearer.
491 2012-07-29 Juanma Barranquero <lekktu@gmail.com>
493 * makefile.w32-in (LISP_H, $(BLD)/emacs.$(O), $(BLD)/w32inevt.$(O))
494 ($(BLD)/w32console.$(O)): Update dependencies.
496 2012-07-29 Dmitry Antipov <dmantipov@yandex.ru>
498 Remove HIDE_LISP_IMPLEMENTATION and cleanup cons free list check.
499 * lisp.h (HIDE_LISP_IMPLEMENTATION): Remove as useless for a long
501 (CHECK_CONS_LIST): Remove. Convert all users to check_cons_list.
503 2012-07-29 Jan Djärv <jan.h.d@swipnet.se>
505 * lread.c (init_lread): Remove if-statement in ifdef HAVE_NS before
506 setting sitelisp (Bug#12010).
508 2012-07-29 Eli Zaretskii <eliz@gnu.org>
510 * w32heap.h (OS_9X): Renamed from OS_WINDOWS_95.
512 * w32heap.c (cache_system_info):
513 * w32.c (sys_rename):
514 * w32proc.c (find_child_console, sys_kill): All users changed.
516 2012-07-29 Paul Eggert <eggert@cs.ucla.edu>
518 * alloc.c (Fgarbage_collect): Indent as per usual Emacs style.
520 2012-07-29 Eli Zaretskii <eliz@gnu.org>
522 * makefile.w32-in (LISP_H): Add $(NT_INC)/stdalign.h.
524 2012-07-29 Dmitry Antipov <dmantipov@yandex.ru>
526 Cleanup statistics calculation in Fgarbage_collect.
527 * alloc.c (Fgarbage_collect): Rename t1 to meaningful start. Fix
528 zombies percentage calculation. Simplify elapsed time calculation.
530 2012-07-29 Dmitry Antipov <dmantipov@yandex.ru>
532 Generalize marker debugging code under MARKER_DEBUG and use eassert.
533 * insdel.c (CHECK_MARKERS, check_markers_debug_flag): Remove.
534 (gap_left, gap_right, adjust_markers_for_delete, insert_1_both)
535 (insert_from_string_1, insert_from_gap, insert_from_buffer_1)
536 (replace_range, replace_range_2, del_range_2): Change to eassert.
537 * marker.c (byte_char_debug_check): Adjust style.
539 2012-07-29 Paul Eggert <eggert@cs.ucla.edu>
541 Don't use the abbreviation "win" to refer to Windows (Bug#10421).
542 * regex.c (MAX_BUF_SIZE): Remove some incorrect and
543 long-ago-commented-out code that talks about "WIN32".
544 * w32heap.h (OS_WINDOWS_95): Rename from OS_WIN95.
547 2012-07-28 Paul Eggert <eggert@cs.ucla.edu>
549 Use Gnulib stdalign module (Bug#9772, Bug#9960).
550 * alloc.c (XMALLOC_BASE_ALIGNMENT, GC_POINTER_ALIGNMENT, pure_alloc):
551 Simplify by using alignof.
552 (pure_alloc) [! USE_LSB_TAG]: Don't over-align EMACS_INT values.
553 * lisp.h: Include <stdalign.h>.
554 (GCALIGNMENT): New macro and constant.
555 (DECL_ALIGN): Remove. All uses replaced by alignas (GCALIGNMENT).
556 (USE_LSB_TAG): ifdef on alignas, not on DECL_ALIGN.
557 (stdalign): New macro, if not already defined.
559 2012-07-28 Eli Zaretskii <eliz@gnu.org>
561 Fix non-ASCII input in non-GUI frames on MS-Windows. (Bug#12055)
562 * w32inevt.c: Include w32inevt.h.
563 (w32_read_console_input): New inline function, calls either
564 ReadConsoleInputA or ReadConsoleInputW, depending on the value of
565 w32_console_unicode_input.
566 (fill_queue): Call w32_read_console_input instead of ReadConsoleInput.
567 (w32_kbd_patch_key, key_event): Use the codepage returned by
568 GetConsoleCP, rather than the ANSI codepage returned by GetLocaleInfo.
569 (key_event): use uChar.UnicodeChar only if
570 w32_console_unicode_input is non-zero.
572 * w32console.c: Include w32heap.h.
573 <w32_console_unicode_input>: New global variable.
574 (initialize_w32_display): Set w32_console_unicode_input to 1 on NT
575 family of Windows, zero otherwise.
577 * w32inevt.h: Declare w32_console_unicode_input.
579 * xdisp.c (init_iterator): Don't reference tip_frame in a build
580 --without-x. (Bug#11742)
582 2012-07-27 Paul Eggert <eggert@cs.ucla.edu>
584 Adjust GDB to reflect pvec_type changes (Bug#12036).
585 * .gdbinit (xvectype, xpr, xbacktrace): Adjust to reflect the
586 2012-07-04 changes to pseudovector representation. Problem
587 reported by Eli Zaretskii in <http://bugs.gnu.org/12036#30>.
589 2012-07-27 Michael Albinus <michael.albinus@gmx.de>
591 * dbusbind.c (XD_DBUS_VALIDATE_BUS_ADDRESS): Canonicalize session
593 (xd_close_bus, Fdbus_init_bus): Handle reference counter properly.
595 2012-07-27 Eli Zaretskii <eliz@gnu.org>
597 * alloc.c (listn): Fix the order the arguments are consed onto the
600 * lisp.h (enum constype): Use CONSTYPE_HEAP and CONSTYPE_PURE for
601 enumeration constants, as PURE and HEAP are too general, and clash
602 with other headers and sources, such as gmalloc.c and the
603 MS-Windows system headers. All users changed.
605 2012-07-27 Dmitry Antipov <dmantipov@yandex.ru>
607 Revert last save_excursion_save and save_excursion_restore changes.
608 * alloc.c, editfns.c, marker.c, lisp.h: Revert.
609 Lots of crashes reported by Chong Yidong <cyd@gnu.org>.
611 2012-07-27 Dmitry Antipov <dmantipov@yandex.ru>
613 Fix recently-introduced typos in Windows port.
614 Reported by Martin Rudalics <rudalics@gmx.at>.
615 * w32.c (init_environment): Replace comma with semicolon.
616 * w32fns.c (syms_of_w32fns): Add missing parenthesis.
618 2012-07-27 Paul Eggert <eggert@cs.ucla.edu>
620 Improve GDB symbol export (Bug#12036).
621 * .gdbinit (xgetptr, xgetint, xgettype): Set $bugfix in different
622 arms of an 'if', not using conditional expressions; otherwise GDB
623 complains about the types in the unevaluated arm when the argument
624 is an integer literal.
625 (xgetint): Simplify expression.
626 * alloc.c (gdb_make_enums_visible): New constant. This ports to
627 GCC 3.4.2 the export of symbols to GDB. Problem reported by Eli
628 Zaretskii in <http://bugs.gnu.org/12036#13>.
629 * lisp.h (PUBLISH_TO_GDB): Remove. All uses removed. No longer
630 needed now that we have gdb_make_enums_visible.
631 (enum CHECK_LISP_OBJECT_TYPE, enum Lisp_Bits, enum More_Lisp_Bits)
632 (enum enum_USE_LSB_TAG):
633 New enum types, packaging up enums that need to be exported to GDB.
635 2012-07-27 Dmitry Antipov <dmantipov@yandex.ru>
637 Utility function to make a list from specified amount of objects.
638 * lisp.h (enum constype): New datatype.
639 (listn): New prototype.
640 * alloc.c (listn): New function.
641 (Fmemory_use_count, syms_of_alloc): Use it.
642 * buffer.c (syms_of_buffer): Likewise.
643 * callint.c (syms_of_callint): Likewise.
644 * charset.c (define_charset_internal): Likewise.
645 * coding.c (syms_of_coding): Likewise.
646 * keymap.c (syms_of_keymap): Likewise.
647 * search.c (syms_of_search): Likewise.
648 * syntax.c (syms_of_syntax): Likewise.
649 * w32.c (init_environment): Likewise.
650 * w32fns.c (Fw32_battery_status, syms_of_w32fns): Likewise.
651 * xdisp.c (syms_of_xdisp): Likewise.
652 * xfns.c (syms_of_xfns): Likewise.
654 2012-07-27 Dmitry Antipov <dmantipov@yandex.ru>
656 Fast save_excursion_save and save_excursion_restore.
657 * lisp.h (struct Lisp_Excursion): New data type.
658 (PVEC_EXCURSION): New pseudovector type.
659 (XEXCURSION, XSETEXCURSION, EXCURSIONP): Convenient macros
660 to deal with it. Adjust comments.
661 (init_marker, attach_marker): New prototype.
662 (unchain_marker): Adjust prototype.
663 * marker.c (attach_marker): Change to global.
664 (init_marker): New function.
665 * alloc.c (Fmake_marker, build_marker): Use it.
666 (build_marker): More easserts.
667 (mark_object): Handle struct Lisp_Excursion.
668 * editfns.c (save_excursion_save, save_excursion_restore):
669 Reimplement to use struct Lisp_Excursion. Add comments.
671 2012-07-26 Paul Eggert <eggert@cs.ucla.edu>
673 Fix export of symbols to GDB (Bug#12036).
674 * alloc.c (ARRAY_MARK_FLAG_VAL, PSEUDOVECTOR_FLAG_VAL, VALMASK_VAL)
675 (ARRAY_MARK_FLAG, PSEUDOVECTOR_FLAG, VALMASK): Move these here from
676 emacs.c, as this is a more-suitable home. Had this been done earlier
677 the fix for 12036 would have avoided some of the problems noted in
678 <http://bugs.gnu.org/12036#13> by Eli Zaretskii, as the scope problems
679 would have been more obvious.
680 * emacs.c: Do not include <verify.h>; no longer needed.
681 (gdb_CHECK_LISP_OBJECT_TYPE, gdb_DATA_SEG_BITS)
682 (gdb_GCTYPEBITS, gdb_USE_LSB_TAG)
683 (CHECK_LISP_OBJECT_TYPE, DATA_SEG_BITS, GCTYPEBITS, USE_LSB_TAG):
684 Remove; now done in lisp.h.
685 * lisp.h (PUBLISH_TO_GDB): New macro.
686 (GCTYPEBITS, USE_LSB_TAG, CHECK_LISP_OBJECT_TYPE, enum pvec_type)
687 (DATA_SEG_BITS): Use it.
688 (GCTYPEBITS, USE_LSB_TAG): Now also an enum, for GDB.
689 (CHECK_LISP_OBJECT_TYPE, DATA_SEG_BITS): Now just an enum, for GDB.
690 * mem-limits.h (EXCEEDS_LISP_PTR): Redo so that DATA_SEG_BITS need
691 not be usable in #if. This simplifies things.
693 2012-07-26 Juanma Barranquero <lekktu@gmail.com>
695 * makefile.w32-in ($(BLD)/emacs.$(O)): Update dependencies.
697 2012-07-26 Paul Eggert <eggert@cs.ucla.edu>
699 Simplify export of symbols to GDB (Bug#12036).
700 * .gdbinit (xgetptr, xgetint, xgettype): Don't use "set $bugfix =
701 $bugfix.i", as this doesn't work (with GDB 7.4.1, anyway).
702 (xgetptr, xgetint, xgettype, xcoding, xcharset, xprintbytestr):
703 Adjust to changes in lisp.h and emacs.c, by using
704 CHECK_LISP_OBJECT_TYPE rather than gdb_use_struct, VALMASK instead
705 of $valmask, DATA_SEG_BITS instead of gdb_data_seg_bits,
706 INTTYPEBITS instead of gdb_gctypebits - 1, USE_LSB_TAG instead of
707 gdb_use_lsb, (1 << GCTYPEBITS) - 1 instead of $tagmask, VALBITS
708 instead of gdb_valbits.
709 (xvectype, xvector, xpr, xprintstr, xbacktrace): Similarly, use
710 PSEUDOVECTOR_FLAG instead of PVEC_FLAG, and ARRAY_MARK_FLAG
711 instead of gdb_array_mark_flag.
712 (xboolvector): Get size from $->size, not $->header.size.
713 Use BOOL_VECTOR_BITS_PER_CHAR rather than mystery constants.
714 (xreload, hook-run, hookpost-run): Remove.
715 * emacs.c: Include <verify.h>.
716 (gdb_use_lsb, gdb_use_struct, gdb_valbits, gdb_gctypebits)
717 (gdb_data_seg_bits, PVEC_FLAG, gdb_array_mark_flag, gdb_pvec_type):
719 (gdb_CHECK_LISP_OBJECT_TYPE, gdb_DATA_SEG_BITS, gdb_GCTYPEBITS)
720 (gdb_USE_LSB_TAG): New enum constants.
721 (CHECK_LISP_OBJECT_TYPE, DATA_SEG_BITS, GCTYPEBITS, USE_LSB_TAG):
722 Also define these as enum constants, so they're visible to GDB.
723 (ARRAY_MARK_FLAG_VAL, PSEUDOVECTOR_FLAG_VAL, VALMASK_VAL): New macros.
724 (ARRAY_MARK_FLAG, PSEUDOVECTOR_FLAG, VALMASK): Also define these
725 as constants, so they're visible to GDB.
726 * lisp.h (VALBITS, INTTYPEBITS, FIXNUM_BITS, PSEUDOVECTOR_SIZE_BITS)
727 (PSEUDOVECTOR_SIZE_MASK, PVEC_TYPE_MASK, BOOL_VECTOR_BITS_PER_CHAR):
728 Now enum constants, not macros, so they're visible to GDB.
729 (CHECK_LISP_OBJECT_TYPE, DATA_SEG_BITS): Default to 0, as this is
730 more convenient now. All uses changed.
731 (VALMASK) [USE_LSB_TAG]: Also define in this case.
732 * mem-limits.h (EXCEEDS_LISP_PTR): Adjust to DATA_SEG_BITS change.
734 2012-07-26 Dmitry Antipov <dmantipov@yandex.ru>
736 Explicitly free restriction data that are not needed anymore.
737 * editfns.c (save_restriction_restore): Free restriction data.
739 2012-07-26 Stefan Monnier <monnier@iro.umontreal.ca>
741 * eval.c (Fautoload_do_load): Rename from do_autoload, export to Lisp,
742 add argument, tune behavior, and adjust all callers.
744 2012-07-25 Paul Eggert <eggert@cs.ucla.edu>
746 Use typedef for EMACS_INT, EMACS_UINT.
747 * lisp.h, s/ms-w32.h (EMACS_INT, EMACS_UINT): Use typedefs rather
748 than macros. This simplifies debugging in the usual case, since
749 it lets GDB show addresses as 'EMACS_INT *' rather than 'long int *'
750 and it allows expressions involving EMACS_INT casts.
751 * .gdbinit (xreload): Simplify by using EMACS_INT cast.
753 2012-07-25 Jan Djärv <jan.h.d@swipnet.se>
755 * nsterm.m (ns_read_socket): Return early if there is a modal
758 2012-07-25 Martin Rudalics <rudalics@gmx.at>
760 * frame.c (Fredirect_frame_focus): In doc-string don't mention
761 that FOCUS-FRAME can be omitted.
763 2012-07-25 Dmitry Antipov <dmantipov@yandex.ru>
765 Adjust buffer text indirection counters at the end of Fkill_buffer.
766 * buffer.c (Fkill_buffer): Adjust indirection counters when the
767 buffer is definitely dead. This should really fix an issue reported
768 by Christoph Scholtes again. (Bug#12007).
769 (init_buffer_once): Initialize indirection counters of
770 buffer_defaults and buffer_local_symbols (for sanity and safety).
772 2012-07-24 Eli Zaretskii <eliz@gnu.org>
774 * xdisp.c (init_iterator): Don't compute dimensions of truncation
775 and continuation glyphs on tooltip frames, leave them at zero.
776 Avoids continued lines in tooltips. (Bug#11832)
778 2012-07-24 Dmitry Antipov <dmantipov@yandex.ru>
780 Simplify copy_overlay.
781 * buffer.c (copy_overlay): Simplify. Use build_marker.
782 * lisp.h (struct Lisp_Overlay): Restore comment with minor tweaks.
784 2012-07-23 Eli Zaretskii <eliz@gnu.org>
786 * print.c (print_object): Don't crash when a frame's name is nil
787 or invalid. (Bug#12025)
789 * window.c (decode_any_window): Disable CHECK_LIVE_FRAME test, as
790 it signals an error when a tooltip frame is being created.
792 2012-07-23 Dmitry Antipov <dmantipov@yandex.ru>
794 Cleanup miscellaneous objects allocation and initialization.
795 * alloc.c (allocate_misc): Change to static. Add argument to
796 specify the subtype. Adjust comment and users.
797 (build_overlay): New function.
798 * buffer.c (copy_overlays, Fmake_overlay): Use it.
799 * lisp.h (struct Lisp_Overlay): Remove obsolete comment.
800 (allocate_misc): Remove prototype.
801 (build_overlay): Add prototype.
803 2012-07-23 Dmitry Antipov <dmantipov@yandex.ru>
805 Swap buffer text indirection counters in Fbuffer_swap_text.
806 * buffer.c (Fbuffer_swap_text): Swap indirections too.
807 This avoids crash reported by Christoph Scholtes at
808 http://lists.gnu.org/archive/html/bug-gnu-emacs/2012-07/msg00785.html.
810 2012-07-22 Jan Djärv <jan.h.d@swipnet.se>
812 * nsmenu.m (Popdown_data): New struct.
813 (pop_down_menu): p->pointer is Popdown_data. Release the pool and
815 (ns_popup_dialog): Use NSAutoreleasePool and pass it to pop_down_menu.
816 (initWithContentRect): Make imgView and contentView non-static
817 and autorelease them. Also autorelease img and matrix (Bug#12005).
818 (dealloc): Remove (Bug#12005).
820 2012-07-22 Dmitry Antipov <dmantipov@yandex.ru>
822 Adjust consing_since_gc when objects are explicitly freed.
823 * alloc.c (GC_DEFAULT_THRESHOLD): New macro.
824 (Fgarbage_collect): Use it. Change minimum to 1/10 of default.
825 (free_cons, free_misc): Subtract object size from consing_since_gc.
827 2012-07-22 Dmitry Antipov <dmantipov@yandex.ru>
829 Simplify and cleanup markers positioning code.
830 * marker.c (attach_marker): More useful eassert.
831 (live_buffer, set_marker_internal): New function.
832 (Fset_marker, set_marker_restricted): Use set_marker_internal.
833 (set_marker_both, set_marker_restricted_both): Use live_buffer.
835 2012-07-22 Paul Eggert <eggert@cs.ucla.edu>
837 * buffer.h (struct buffer.indirections): Now ptrdiff_t, not int,
838 as it's limited by the amount of memory, not by INT_MAX.
840 2012-07-21 Eli Zaretskii <eliz@gnu.org>
842 * keyboard.c (keys_of_keyboard): Bind language-change to 'ignore'
843 in special-event-map. See the discussion at
844 http://lists.gnu.org/archive/html/emacs-devel/2012-06/msg00417.html
847 * w32menu.c (add_menu_item): Cast to ULONG_PTR when assigning
848 info.dwItemData. Fixes crashes on 64-bit Windows. Suggested by
849 Fabrice Popineau <fabrice.popineau@supelec.fr>.
851 2012-07-21 Jan Djärv <jan.h.d@swipnet.se>
853 * nsterm.m (accessibilityAttributeValue): New function. (Bug#11134).
854 (conversationIdentifier): Return value is NSInteger.
855 * nsterm.m (accessibilityAttributeValue): Surround with NS_IMPL_COCOA.
857 2012-07-21 Chong Yidong <cyd@gnu.org>
859 * window.c (decode_any_window): Signal an error if the window is
860 on a dead frame (Bug#11984).
862 2012-07-20 Dmitry Antipov <dmantipov@yandex.ru>
864 Add indirection counting to speed up Fkill_buffer.
865 * buffer.h (struct buffer): New member.
866 * buffer.c (Fget_buffer_create): Set indirection counter to 0.
867 (Fmake_indirect_buffer): Set indirection counter to -1, increment
868 base buffer indirection counter.
869 (compact_buffer): If ENABLE_CHECKING, verify indirection counters.
870 (Fkill_buffer): Adjust indirection counters as needed, don't walk
871 through buffer list if indirection counter is 0.
873 2012-07-20 Dmitry Antipov <dmantipov@yandex.ru>
875 Extend the value returned by Fgarbage_collect with heap statistics.
876 * alloc.c (Qheap): New symbol.
877 (syms_of_alloc): DEFSYM it.
878 (Fgarbage_collect): If DOUG_LEA_MALLOC, add mallinfo data.
879 (Fmemory_free): Remove.
880 (syms_of_alloc): Don't defsubr it.
881 * buffer.c (Fcompact_buffer): Remove.
882 (syms_of_buffer): Don't defsubr it.
884 2012-07-20 Dmitry Antipov <dmantipov@yandex.ru>
886 Make maybe_gc inline.
887 Verify that inlining is always possible (GCC 4.7.1, -O3 -Winline).
888 * lisp.h (consing_since_gc, gc_relative_threshold)
889 (memory_full_cons_threshold): Revert declaration.
890 (maybe_gc): Remove prototype, define as inline.
891 * alloc.c: Remove old commented-out code.
892 (consing_since_gc, gc_relative_threshold)
893 (memory_full_cons_threshold): Revert to global.
896 2012-07-20 Dmitry Antipov <dmantipov@yandex.ru>
898 Simple wrapper for make_unibyte_string, adjust font_open_by_name.
899 * lisp.h (build_unibyte_string): New function.
900 * dosfns.c, fileio.c, fns.c, ftfont.c, process.c:
901 * sysdep.c, w32fns.c, xfns.c: Use it.
902 * font.c (font_open_by_name): Change 2nd and 3rd args to the only arg
903 of type Lisp_Object to avoid redundant calls to make_unibyte_string.
904 Adjust users accordingly.
905 * font.h (font_open_by_name): Adjust prototype.
907 2012-07-20 Dmitry Antipov <dmantipov@yandex.ru>
909 Cleanup calls to Fgarbage_collect.
910 * lisp.h (maybe_gc): New prototype.
911 (consing_since_gc, gc_relative_threshold, memory_full_cons_threshold):
913 * alloc.c (maybe_gc): New function.
914 (consing_since_gc, gc_relative_threshold, memory_full_cons_threshold):
916 * bytecode.c (MAYBE_GC): Use maybe_gc.
917 * eval.c (eval_sub, Ffuncall): Likewise.
918 * keyboard.c (read_char): Likewise. Adjust call to maybe_gc
919 to avoid dependency from auto-save feature.
921 2012-07-19 Paul Eggert <eggert@cs.ucla.edu>
923 * buffer.h (FOR_EACH_BUFFER): Rename from 'for_each_buffer'.
924 (FOR_EACH_PER_BUFFER_OBJECT_AT): Rename from
925 'for_each_per_buffer_object_at'.
926 All uses changed. It's better to use upper-case for macros that
927 cannot be implemented as functions, to give the reader a clue
928 that they're special.
930 2012-07-19 Stefan Monnier <monnier@iro.umontreal.ca>
932 * alloc.c (Fgarbage_collect): Tweak docstring.
934 2012-07-19 Dmitry Antipov <dmantipov@yandex.ru>
936 Tweak the value returned from Fgarbage_collect again.
937 * alloc.c (Fgarbage_collect): New return value, as confirmed in
938 http://lists.gnu.org/archive/html/emacs-devel/2012-07/msg00418.html.
939 Adjust documentation.
940 (total_vector_bytes): Rename to total_vector_slots, adjust
942 (total_free_vector_bytes): Rename to total_free_vector_slots,
944 (Qstring_bytes, Qvector_slots): New symbols.
945 (syms_of_alloc): DEFSYM them.
947 2012-07-19 Dmitry Antipov <dmantipov@yandex.ru>
949 Buffer compaction primitive which may be used from Lisp.
950 * buffer.c (compact_buffer, Fcompact_buffer): New function.
951 (syms_of_buffer): Register Fcompact_buffer.
952 * alloc.c (Fgarbage_collect): Use compact_buffer.
953 * buffer.h (compact_buffer): New prototype.
954 (struct buffer_text): New member.
956 2012-07-19 Dmitry Antipov <dmantipov@yandex.ru>
958 New macro to iterate over all buffers, miscellaneous cleanups.
959 * lisp.h (all_buffers): Remove declaration.
960 * buffer.h (all_buffers): Add declaration, with comment.
961 (for_each_buffer): New macro.
962 * alloc.c (Fgarbage_collect, mark_object): Use it.
963 * buffer.c (Fkill_buffer, Fbuffer_swap_text, Fset_buffer_multibyte)
964 (init_buffer): Likewise.
965 * data.c (Fset_default): Likewise.
966 * coding.c (code_conversion_restore): Remove redundant check
968 * buffer.c (Fkill_buffer): Likewise. Remove obsolete comment.
970 2012-07-18 Andreas Schwab <schwab@linux-m68k.org>
972 Fix bug that created negative-length intervals.
973 * intervals.c (merge_interval_right, merge_interval_left):
974 Do not zero out this interval if it is absorbed by its children,
975 as this interval's total length doesn't change in that case. See
976 <http://lists.gnu.org/archive/html/emacs-devel/2012-07/msg00403.html>.
978 2012-07-18 Paul Eggert <eggert@cs.ucla.edu>
980 * alloc.c (Fmake_bool_vector): Fix off-by-8 bug
981 when invoking (make-bool-vector N t) and N is a positive
982 multiple of 8 -- the last 8 bits were mistakenly cleared.
984 Remove some struct layout assumptions in bool vectors.
985 * alloc.c (bool_header_size): New constant.
986 (header_size, word_size): Move earlier, as they're now used earlier.
987 Use 'word_size' in a few more places, where it's appropriate.
988 (Fmake_bool_vector, sweep_vectors): Don't assume that there is no
989 padding before the data member of a bool vector.
990 (sweep_vectors): Use PSEUDOVECTOR_TYPEP, in an eassert, rather
991 than doing the check by hand with an abort ().
993 2012-07-18 Stefan Monnier <monnier@iro.umontreal.ca>
995 * eval.c (Fdefvar): Don't check constants since we only set the var if
996 it's not yet defined anyway (bug#11904).
998 * lisp.h (last_undo_boundary): Declare new var.
999 * keyboard.c (command_loop_1): Set it.
1000 * cmds.c (Fself_insert_command): Use it to only remove boundaries that
1001 were auto-added by the command loop (bug#11774).
1003 2012-07-18 Andreas Schwab <schwab@linux-m68k.org>
1005 * w32font.c (Qsymbol): Remove local definition.
1006 (syms_of_w32font): Don't DEFSYM it.
1008 2012-07-18 Dmitry Antipov <dmantipov@yandex.ru>
1010 Fix sweep_vectors to handle large bool vectors correctly.
1011 * alloc.c (sweep_vectors): Account total_vector_bytes for
1012 bool vectors larger than VBLOCK_BYTES_MAX.
1014 2012-07-18 Chong Yidong <cyd@gnu.org>
1016 * frame.c (x_set_frame_parameters): Revert bogus change introduced
1017 in 2012-05-25 commit by Paul Eggert (Bug#11738).
1019 2012-07-18 Dmitry Antipov <dmantipov@yandex.ru>
1021 Return more descriptive data from Fgarbage_collect.
1022 Suggested by Stefan Monnier in
1023 http://lists.gnu.org/archive/html/emacs-devel/2012-07/msg00369.html.
1024 * alloc.c (bounded_number): New function.
1025 (total_buffers, total_vectors): New variable.
1026 (total_string_size): Rename to total_string_bytes, adjust users.
1027 (total_vector_size): Rename to total_vector_bytes, adjust users.
1028 (sweep_vectors): Account total_vectors and total_vector_bytes.
1029 (Fgarbage_collect): New return value. Adjust documentation.
1030 (gc_sweep): Account total_buffers.
1031 (Fmemory_free, Fmemory_use_counts): Use bounded_number.
1032 (VECTOR_SIZE): Remove.
1033 * data.c (Qfloat, Qvector, Qsymbol, Qstring, Qcons): Make global.
1034 (Qinterval, Qmisc): New symbols.
1035 (syms_of_data): Initialize them.
1036 * lisp.h (Qinterval, Qsymbol, Qstring, Qmisc, Qvector, Qfloat)
1037 (Qcons, Qbuffer): New declarations.
1039 2012-07-17 Paul Eggert <eggert@cs.ucla.edu>
1041 * alloc.c (Fmemory_free): Account for memory-free's own storage.
1042 Round up, not down. Improve doc.
1044 2012-07-17 Dmitry Antipov <dmantipov@yandex.ru>
1046 Restore old code in allocate_string_data to avoid Faset breakage.
1047 Reported by Julien Danjou <julien@danjou.info> in
1048 http://lists.gnu.org/archive/html/emacs-devel/2012-07/msg00371.html.
1049 * alloc.c (allocate_string_data): Restore old code with minor
1050 adjustments, fix comment to explain this subtle issue.
1052 2012-07-17 Eli Zaretskii <eliz@gnu.org>
1054 Remove FILE_SYSTEM_CASE.
1055 * s/msdos.h (FILE_SYSTEM_CASE): Don't define.
1057 * fileio.c (FILE_SYSTEM_CASE): Don't define.
1058 (Ffile_name_directory, Fexpand_file_name): Don't use FILE_SYSTEM_CASE.
1059 Fixes problems on MS-DOS with Vtemp_file_name_pattern when
1060 call-process-region passes it through expand-file-name.
1062 * dired.c (file_name_completion): Don't use FILE_SYSTEM_CASE.
1064 2012-07-17 Andreas Schwab <schwab@linux-m68k.org>
1066 Fix crash when creating indirect buffer (Bug#11917)
1067 * buffer.c (buffer_lisp_local_variables): Add argument CLONE.
1068 Don't handle unbound variables specially if non-zero.
1069 (Fbuffer_local_variables): Pass zero.
1070 (clone_per_buffer_values): Pass non-zero.
1072 2012-07-17 Andreas Schwab <schwab@linux-m68k.org>
1074 * gnutls.c (emacs_gnutls_handshake): Revert last change. Add QUIT
1075 to make the loop interruptible.
1077 2012-07-17 Andreas Schwab <schwab@linux-m68k.org>
1079 * gnutls.c (emacs_gnutls_handshake): Only retry if
1080 GNUTLS_E_INTERRUPTED.
1082 2012-07-17 Dmitry Antipov <dmantipov@yandex.ru>
1084 Cleanup and convert miscellaneous checks to eassert.
1085 * alloc.c (mark_interval): Fix comment, partially rephrase
1086 old comment from intervals.h (see below).
1087 * intervals.c (find_interval, adjust_intervals_for_insertion)
1088 (delete_interval, adjust_intervals_for_deletion)
1089 (graft_intervals_into_buffer, temp_set_point_both, copy_intervals):
1091 (adjust_intervals_for_insertion, make_new_interval):
1092 Remove obsolete and unused code.
1093 * intervals.h (struct interval): Remove obsolete comment.
1094 * textprotp.c (erase_properties): Remove unused code.
1095 (Fadd_text_properties, set_text_properties_1, Fremove_text_properties)
1096 (Fremove_list_of_text_properties): Convert to eassert.
1098 2012-07-17 Chong Yidong <cyd@gnu.org>
1100 * editfns.c (Finsert_char): Doc fix.
1102 2012-07-17 Dmitry Antipov <dmantipov@yandex.ru>
1104 Fix previous change to make Fmemory_free always accurate.
1105 * alloc.c (make_interval): Update total_free_intervals.
1106 (make_float): Likewise for total_free_floats.
1107 (free_cons, Fcons): Likewise for total_free_conses.
1108 (SETUP_ON_FREE_LIST, allocate_vector_from_block):
1109 Likewise for total_free_vector_bytes.
1110 (Fmake_symbol): Likewise for total_free_symbols.
1111 (bytes_free): Remove.
1113 2012-07-17 Dmitry Antipov <dmantipov@yandex.ru>
1115 Simple free memory accounting feature.
1116 * alloc.c (bytes_free, total_free_vector_bytes): New variable.
1117 (sweep_vectors): Accumulate size of free vectors.
1118 (Fgarbage_collect): Setup bytes_free.
1119 (Fmemory_free): New function.
1120 (syms_of_alloc): Register it.
1122 2012-07-17 Dmitry Antipov <dmantipov@yandex.ru>
1124 Cleanup overlays checking.
1125 * buffer.h (OVERLAY_VALID): Remove as useless synonym of OVERLAYP.
1126 * buffer.c (overlay_touches_p, recenter_overlay_lists): Change to
1127 eassert and OVERLAYP.
1128 (sort_overlays): Change to use OVERLAYP.
1130 2012-07-16 René Kyllingstad <Rene@Kyllingstad.com> (tiny change)
1132 * editfns.c (Finsert_char): Make it interactive, and make the
1133 second arg optional. Copy interactive spec and docstring from
1136 2012-07-17 Paul Eggert <eggert@cs.ucla.edu>
1138 * floatfns.c (Fabs): Do not wrap fabs inside IN_FLOAT (Bug#11913).
1139 Unlike the other wrapped functions, fabs has an unspecified
1142 2012-07-16 Jan Djärv <jan.h.d@swipnet.se>
1144 * nsterm.m (keyDown): Interpret flags without left/right bits
1145 as the left key (Bug#11670).
1147 2012-07-16 Dmitry Antipov <dmantipov@yandex.ru>
1149 Remove empty and useless init functions.
1150 * lisp.h (init_character_once, init_fns, init_image)
1151 (init_filelock, init_sound): Remove prototype.
1152 * character.c (init_character_once): Remove.
1153 * filelock.c (init_filelock): Likewise.
1154 * fns.c (init_fns): Likewise.
1155 * image.c (init_image): Likewise.
1156 * sound.c (init_sound): Likewise.
1157 * emacs.c (main): Adjust accordingly.
1159 2012-07-16 Dmitry Antipov <dmantipov@yandex.ru>
1161 * gtkutil.h: Tiny cleanups.
1162 (use_old_gtk_file_dialog): Remove useless declaration.
1163 (xg_uses_old_file_dialog): Add suggested const attribute.
1165 2012-07-15 Eli Zaretskii <eliz@gnu.org>
1167 * bidi.c (MAX_STRONG_CHAR_SEARCH): New macro.
1168 (bidi_paragraph_init): Use it to limit search forward for a strong
1169 directional character in abnormally large paragraphs full of
1170 neutral or weak characters. (Bug#11943)
1172 2012-07-15 Stefano Facchini <stefano.facchini@gmail.com> (tiny change)
1174 * gtkutil.c (xg_create_tool_bar): Apply "primary-toolbar" style to
1175 the toolbar (Bug#9451).
1176 (xg_make_tool_item): Give the widget event box a transparent
1179 2012-07-15 Dmitry Antipov <dmantipov@yandex.ru>
1181 Cleanup basic allocation variables and functions.
1182 * alloc.c (ignore_warnings, init_intervals, init_float)
1183 (init_cons, init_symbol, init_marker): Remove.
1184 (interval_block_index): Initialize to INTERVAL_BLOCK_SIZE.
1185 (float_block_index): Initialize to FLOAT_BLOCK_SIZE.
1186 (cons_block_index): Initialize to CONS_BLOCK_SIZE.
1187 (symbol_block_size): Initialize to SYMBOL_BLOCK_SIZE.
1188 (marker_block_index): Initialize to MARKER_BLOCK_SIZE.
1189 (staticidx, init_alloc_once, init_strings, free_ablock):
1190 Remove redundant initialization.
1191 * fns.c (init_weak_hash_tables): Remove.
1192 * lisp.h (init_weak_hash_tables): Remove prototype.
1194 2012-07-15 Dmitry Antipov <dmantipov@yandex.ru>
1196 Use zero_vector where appropriate.
1197 * alloc.c (zero_vector): Define as Lisp_Object. Adjust users
1199 * lisp.h (zero_vector): New declaration.
1200 * font.c (null_vector): Remove.
1201 (syms_of_font): Remove initialization and staticpro.
1202 (font_list_entities, font_find_for_lface): Change to use zero_vector.
1203 * keymap.c (Faccessible_keymaps): Likewise.
1205 2012-07-15 Leo Liu <sdl.web@gmail.com>
1207 * fringe.c: Fix typo in comments.
1209 2012-07-14 Leo Liu <sdl.web@gmail.com>
1211 * fringe.c: Add a new bitmap exclamation-mark.
1213 2012-07-14 Eli Zaretskii <eliz@gnu.org>
1215 * gmalloc.c (GMALLOC_INHIBIT_VALLOC): Don't reference.
1217 * s/msdos.h (BSD_SYSTEM, DATA_START, GC_SETJMP_WORKS, HAVE_MOUSE)
1218 (HAVE_MENUS): Don't define, defined by editing config.in with
1220 (GMALLOC_INHIBIT_VALLOC): Don't define.
1221 (MODE_LINE_BINARY_TEXT): Remove, not used anymore.
1223 2012-07-14 Juanma Barranquero <lekktu@gmail.com>
1225 * s/ms-w32.h (GC_SETJMP_WORKS, GC_MARK_STACK): Set in nt/config.nt.
1227 2012-07-14 Glenn Morris <rgm@gnu.org>
1229 * s/aix4-2.h, s/freebsd.h, s/gnu-linux.h, s/hpux10-20.h:
1230 * s/irix6-5.h, s/netbsd.h, s/sol2-6.h, s/unixware.h:
1231 Let configure set GC_SETJMP_WORKS, GC_MARK_STACK.
1233 2012-07-13 Glenn Morris <rgm@gnu.org>
1235 * s/gnu-linux.h (GC_MARK_SECONDARY_STACK): Let configure set it.
1237 * s/usg5-4-common.h (SETUP_SLAVE_PTY): Let configure set it.
1238 * s/irix6-5.h (SETUP_SLAVE_PTY): No more need to unset it.
1240 2012-07-13 Jan Djärv <jan.h.d@swipnet.se>
1242 * nsterm.m (uRect): Only define if NS_IMPL_GNUSTEP.
1243 (x_free_frame_resources): Pass x_free_frame_resources to NSTRACE.
1244 (ns_lisp_to_color, ns_string_to_lispmod, ns_term_init)
1245 (ns_term_shutdown, requestService, initFrameFromEmacs): Use SSDATA
1247 (ns_exec_path, ns_load_path, changeFont): Put () around assignment used
1248 as boolean expression.
1249 (x_set_window_size): Remove unused variable toolbar.
1250 (ns_get_color_default, ns_mod_to_lisp): Remove.
1251 (ns_mouse_position): Remove unused variables xchar and ychar.
1252 (ns_compute_glyph_string_overhangs): Remove unused variable face.
1253 (ns_set_vertical_scroll_bar): Remove unused variable count.
1254 (ns_delete_terminal): Remove unused variable i.
1255 (ns_term_init): Remove unused variables r, g and b.
1256 (mouseDown): Remove unused variable window.
1257 (windowDidResize): Move definition of theWindow inside NS_IMPL_GNUSTEP.
1258 (initFrameFromEmacs): Remove unused variable vbextra.
1259 (mouseEntered): Remove unused variables p and dpyinfo.
1260 (mouseExited): Remove unused variables p and r.
1261 (ns_define_frame_cursor, ns_clear_frame_area)
1262 (ns_draw_window_cursor, ns_initialize_display_info): Make static.
1263 (menuDown): Assign [sender tag] to variable and cast the variable.
1265 * nsterm.h (menuDown): Add id as type to argument sender.
1266 (ns_display_info_for_name): Add Lisp_Object argument.
1267 (ns_term_init): Add Lisp_Object argument.
1268 (ns_map_event_to_object): Add void argument.
1269 (ns_string_from_pasteboard, ns_string_to_pasteboard): Add correct
1270 prototype with arguments and only declare if __OBJC__.
1271 (nxatoms_of_nsselect): Add void argument.
1272 (ns_lisp_to_cursor_type): Add Lisp_Object argument.
1273 (ns_alloc_autorelease_pool): Add void argument.
1274 (ns_release_autorelease_pool): Add void* argument.
1275 (ns_get_defaults_value): Add const char* argument.
1277 * nsmenu.m (ns_update_menubar, ns_menu_show, process_dialog)
1278 (initFromContents): Use SSDATA where appropriate.
1279 (ns_update_menubar): Add braces to ambigous if-else.
1280 (initWithTitle): Put () around assignment in if statement.
1281 (ns_menu_show): Remove unused variables window and keymap.
1282 (update_frame_tool_bar): Remove unused variable selected_p.
1283 (initWithContentRect): Remove unused variable this_cmd_name.
1285 * nsimage.m (ns_load_image, allocInitFromFile): Use SSDATA where
1287 (setXBMColor): Remove unused variable len.
1288 (setPixmapData): Put () around assignment in loop statement.
1290 * nsfont.m (ns_get_family, ns_lang_to_script, ns_otf_to_script)
1291 (ns_registry_to_script, ns_get_req_script, nsfont_open): Use SSDATA
1293 (ns_get_covering_families, ns_findfonts, nsfont_list_family): Put ()
1294 around assignment in loop statement.
1295 (nsfont_open): Remove unused variable i.
1296 (nsfont_open): Remove unused variable len.
1297 (nsfont_draw): Remove unused variable cs.
1299 * nsfns.m (x_set_icon_name, ns_set_name_internal)
1300 (ns_set_name_as_filename, ns_implicitly_set_icon_type)
1301 (x_set_icon_type, ns_lisp_to_cursor_type, Fns_read_file_name)
1302 (Fns_get_resource, Fns_set_resource, Fx_open_connection)
1303 (Fns_font_name, Fns_perform_service)
1304 (Fns_convert_utf8_nfd_to_nfc, ns_do_applescript)
1305 (Fns_do_applescript, Fx_show_tip): Use SSDATA where appropriate.
1306 (ns_set_name): Remove unused variable view.
1307 (x_set_menu_bar_lines): Remove unused variable olines.
1308 (x_set_tool_bar_lines): Remove unused variable root_window.
1309 (Fns_list_colors): Put () around assignment in while statement.
1310 (Fns_perform_service): Remove unused variable len.
1311 (Fns_display_usable_bounds): Remove unused variable top.
1312 (syms_of_nsfns): Remove unused variable i.
1314 * nsmenu.m (ns_update_menubar): Exchange place of argument 2 and 3 to
1317 2012-07-13 Kalle Kankare <kalle.kankare@iki.fi> (tiny change)
1319 * image.c (Fimagemagick_types): Initialize ex with GetExceptionInfo
1320 and free it with DestroyExceptionInfo (Bug#11558).
1322 2012-07-13 Juanma Barranquero <lekktu@gmail.com>
1324 * s/ms-w32.h (FIRST_PTY_LETTER, HAVE_SOCKETS): Move to nt/config.nt.
1325 (HAVE_ATTRIBUTE_ALIGNED, HAVE_C99_STRTOLD, HAVE___BUILTIN_UNWIND_INIT):
1326 Set here, not in nt/config.nt.
1328 2012-07-13 Eli Zaretskii <eliz@gnu.org>
1330 * xdisp.c (move_it_in_display_line_to): On GUI terminals, allow
1331 cursor overflow into the last glyph on display line when the right
1332 fringe is off. (Bug#11832)
1334 2012-07-13 Paul Eggert <eggert@cs.ucla.edu>
1336 * xdisp.c (produce_special_glyphs): Now static.
1337 * dispextern.h (produce_special_glyphs): Remove decl.
1339 2012-07-13 Glenn Morris <rgm@gnu.org>
1341 * s/bsd-common.h, s/cygwin.h: Remove empty files.
1342 * s/freebsd.h, s/netbsd.h: Do not include bsd-common.h.
1344 * s/usg5-4-common.h (USG, USG5):
1345 * s/template.h (USG5, USG, HPUX, BSD4_2, BSD_SYSTEM):
1346 * s/sol2-6.h (SOLARIS2):
1347 * s/irix6-5.h (IRIX6_5):
1348 * s/hpux10-20.h (USG, USG5, HPUX):
1349 * s/gnu-linux.h (USG, GNU_LINUX):
1350 * s/freebsd.h (BSD_SYSTEM):
1351 * s/darwin.h (BSD4_2, BSD_SYSTEM, DARWIN_OS):
1352 * s/cygwin.h (CYGWIN):
1353 * s/bsd-common.h (BSD_SYSTEM, BSD4_2):
1354 * s/aix4-2.h (USG, USG5, _AIX): Move "system type" macros to configure.
1356 2012-07-13 BT Templeton <bpt@hcoop.net> (tiny change)
1358 * nsfont.m (ns_charset_covers): Don't abort if no bitmap (Bug#11853).
1360 2012-07-13 Glenn Morris <rgm@gnu.org>
1362 * s/usg5-4-common.h (NSIG_MINIMUM): Let configure set it.
1364 * s/gnu-linux.h, s/irix6-5.h: Let configure set ULIMIT_BREAK_VALUE.
1366 * process.c (init_process_emacs): Replace MIN_PTY_KERNEL_VERSION.
1367 * s/darwin.h (MIN_PTY_KERNEL_VERSION): Remove single-use macro.
1369 2012-07-12 Glenn Morris <rgm@gnu.org>
1371 * s/darwin.h (SYSTEM_PURESIZE_EXTRA): Move to configure.
1373 * process.c (init_process_emacs): Rename from init_process.
1374 The old name is also the name of a Mach system call.
1375 * lisp.h, emacs.c: Update for this name change.
1376 * nsgui.h, sysselect.h, s/darwin.h: Remove workaround that is no
1379 2012-07-12 Eli Zaretskii <eliz@gnu.org>
1381 * xdisp.c (insert_left_trunc_glyphs): Fix incorrect size in
1382 memmove call that removes glyphs covered by the left truncation
1383 glyph. Improve commentary.
1384 (display_line): Fix display of continuation glyphs on GUI frames
1385 when the right fringe is turned off and variable-size fonts are
1386 used in the window. Move the code that appends a stretch glyph to
1387 produce_special_glyphs, so that it could be used for truncation
1388 and continuation glyphs alike.
1389 (produce_special_glyphs) [HAVE_WINDOW_SYSTEM]: Produce a stretch
1390 glyph of a suitably computed width, to align the special glyphs at
1391 the window margin. Code moved from display_line. (Bug#11832)
1393 2012-07-12 Glenn Morris <rgm@gnu.org>
1395 * s/aix4-2.h, s/hpux10-20.h: Let configure set NO_EDITRES.
1397 * s/gnu-linux.h, s/hpux10-20.h:
1398 Do not unconditionally define HAVE_XRMSETDATABASE.
1400 * s/gnu-linux.h (UNIX98_PTYS): Let configure set it.
1402 2012-07-12 Paul Eggert <eggert@cs.ucla.edu>
1404 Fix typos that broke OS X build.
1405 Reported by Randal L. Schwartz in
1406 <http://lists.gnu.org/archive/html/emacs-devel/2012-07/msg00225.html>.
1407 * nsterm.m (ns_timeout): Add missing local decl.
1408 (ns_get_color): snprintf -> sprintf, to fix typo.
1410 2012-07-12 Glenn Morris <rgm@gnu.org>
1412 * src/s/aix4-2.h, src/s/cygwin.h, src/s/darwin.h:
1413 * src/s/gnu-linux.h, src/s/hpux10-20.h, src/s/irix6-5.h:
1414 * src/s/sol2-6.h, src/s/unixware.h, src/s/usg5-4-common.h:
1415 Move PTY_NAME_SPRINTF, PTY_TTY_NAME_SPRINTF to configure.
1417 * s/cygwin.h, s/darwin.h, s/gnu-linux.h, s/irix6-5.h:
1418 Move PTY_OPEN to configure.
1420 * s/aix4-2.h, s/bsd-common.h, s/cygwin.h, s/darwin.h:
1421 * s/gnu-linux.h, s/hpux10-20.h, s/irix6-5.h, s/template.h:
1422 * s/usg5-4-common.h: Move FIRST_PTY_LETTER, PTY_ITERATION to configure.
1424 2012-07-12 Dmitry Antipov <dmantipov@yandex.ru>
1426 Use empty_unibyte_string where applicable.
1427 * keyboard.c (parse_tool_bar_item): Use empty_unibyte_string.
1428 * lread.c (read1): Likewise.
1429 * xsettings.c (syms_of_xsettings): Likewise.
1431 2012-07-12 Glenn Morris <rgm@gnu.org>
1433 * s/cygwin.h (G_SLICE_ALWAYS_MALLOC):
1434 * s/freebsd.h (BROKEN_PTY_READ_AFTER_EAGAIN):
1435 * s/irix6-5.h (SETPGRP_RELEASES_CTTY, PREFER_VSUSP):
1436 * s/hpux10-20.h (RUN_TIME_REMAP):
1437 * s/bsd-common.h (TABDLY): Move to configure.
1439 * s/hpux10-20.h, s/sol2-6.h: Move XOS_NEEDS_TIME_H to configure.
1441 * s/bsd-common.h, s/darwin.h: Move TAB3 to configure.
1443 * s/aix4-2.h (BROKEN_FIONREAD, BROKEN_SIGAIO, BROKEN_SIGPTY)
1444 (BROKEN_SIGPOLL, BROKEN_GET_CURRENT_DIR_NAME): Let configure set them.
1446 * s/darwin.h (NO_ABORT, NO_MATHERR): Let configure set them.
1448 * s/bsd-common.h, s/cygwin.h, s/gnu-linux.h, s/irix6-5.h:
1449 * s/template.h: Move NARROWPROTO to configure.
1451 2012-07-11 Glenn Morris <rgm@gnu.org>
1453 * s/gnu-linux.h, s/sol2-6.h: No longer define POSIX,
1454 unused since 2011-01-17 change to systty.h.
1456 * s/aix4-2.h, s/bsd-common.h, s/cygwin.h, s/darwin.h, s/gnu-linux.h:
1457 * s/hpux10-20.h, s/template.h, s/usg5-4-common.h:
1458 Move HAVE_PTYS and HAVE_SOCKETS to configure.
1460 2012-07-11 Paul Eggert <eggert@cs.ucla.edu>
1462 * s/sol2-6.h (HAVE_LIBKSTAT): Remove. (Bug#11914)
1464 2012-07-11 Glenn Morris <rgm@gnu.org>
1466 * s/darwin.h, s/gnu-linux.h, s/template.h:
1467 Move INTERRUPT_INPUT to configure.
1469 2012-07-11 Dmitry Antipov <dmantipov@yandex.ru>
1471 Minor adjustments to interning code.
1472 * lisp.h (intern, intern_c_string): Redefine as static inline
1473 wrappers for intern_1 and intern_c_string_1, respectively.
1474 (intern_1, intern_c_string_1): Rename prototypes.
1475 * lread.c (intern_1, intern_c_string_1, oblookup): Simplify
1477 * font.c (font_intern_prop): Likewise. Adjust comment.
1478 * w32font.c (intern_font_name): Likewise.
1480 2012-07-11 Andreas Schwab <schwab@linux-m68k.org>
1482 * gnutls.c (Fgnutls_boot): Properly parse :keylist argument.
1484 * coding.c (Fdefine_coding_system_internal): Use XCAR/XCDR instead
1485 of Fcar/Fcdr if possible.
1486 * font.c (check_otf_features): Likewise.
1487 * fontset.c (Fnew_fontset): Likewise.
1488 * gnutls.c (Fgnutls_boot): Likewise.
1489 * minibuf.c (read_minibuf): Likewise.
1490 * msdos.c (IT_set_frame_parameters): Likewise.
1491 * xmenu.c (Fx_popup_dialog): Likewise.
1492 * w32menu.c (Fx_popup_dialog): Likewise.
1494 2012-07-11 Glenn Morris <rgm@gnu.org>
1496 * s/bsd-common.h, s/cygwin.h: No need to undefine INTERRUPT_INPUT,
1497 since nothing has defined it on these platforms.
1499 * s/aix4-2.h, s/bsd-common.h, s/cygwin.h, s/gnu-linux.h:
1500 * s/irix6-5.h: Move SIGNALS_VIA_CHARACTERS to configure.
1502 * s/aix4-2.h, s/bsd-common.h, s/cygwin.h, s/darwin.h:
1503 * s/gnu-linux.h, s/hpux10-20.h, s/template.h, s/usg5-4-common.h:
1504 Move CLASH_DETECTION to configure.
1506 * s/gnu.h: Remove file, which is now empty.
1508 * s/gnu.h, s/gnu-linux.h:
1509 Move GNU_LIBRARY_PENDING_OUTPUT_COUNT to configure.
1511 2012-07-11 John Wiegley <johnw@newartisans.com>
1513 * alloc.c (mark_memory): Guard the "no_address_safety_analysis"
1514 function attribute, so we only use it if it exists in the
1517 2012-07-11 Dmitry Antipov <dmantipov@yandex.ru>
1519 Avoid call to strlen in fast_c_string_match_ignore_case.
1520 * search.c (fast_c_string_match_ignore_case): Change to use
1521 length argument. Adjust users accordingly.
1522 * lisp.h (fast_c_string_match_ignore_case): Adjust prototype.
1524 2012-07-11 Paul Eggert <eggert@cs.ucla.edu>
1526 Assume mkdir, rmdir.
1527 * sysdep.c (mkdir) [!HAVE_MKDIR]: Remove.
1528 * sysdep.c (rmdir) [!HAVE_RMDIR]: Remove.
1531 * sysdep.c (rename) [!HAVE_RENAME]: Remove.
1534 * s/hpux10-20.h (HAVE_PERROR): Remove.
1535 * sysdep.c (perror) [HPUX && !HAVE_PERROR]:
1536 Remove dummy definition, as this problem was obsolete long ago.
1539 * sysdep.c (strerror) [!HAVE_STRERROR && !WINDOWSNT]: Remove.
1541 2012-07-11 Dmitry Antipov <dmantipov@yandex.ru>
1543 Avoid calls to strlen in font processing functions.
1544 * font.c (font_parse_name, font_parse_xlfd, font_parse_fcname)
1545 (font_open_by_name): Change to use length argument. Adjust
1547 * font.h (font_open_by_name, font_parse_xlfd, font_unparse_xlfd):
1549 * xfont.c (xfont_decode_coding_xlfd, font_unparse_xlfd):
1550 Change to return ptrdiff_t.
1551 (xfont_list_pattern, xfont_match): Use length returned by
1552 xfont_decode_coding_xlfd.
1553 * xfns.c (x_default_font_parameter): Omit useless xstrdup.
1555 2012-07-11 Glenn Morris <rgm@gnu.org>
1557 * s/darwin.h, s/freebsd.h, s/netbsd.h:
1558 Move DONT_REOPEN_PTY to configure.
1560 * sound.c (DEFAULT_SOUND_DEVICE) [!WINDOWSNT]:
1561 * s/netbsd.h (DEFAULT_SOUND_DEVICE): Let configure set it.
1563 2012-07-10 Paul Eggert <eggert@cs.ucla.edu>
1565 Remove "#define unix" that is no longer needed (Bug#11905).
1566 * s/aix4-2.h (unix): Remove; no longer needed.
1568 EMACS_TIME simplification (Bug#11875).
1569 This replaces macros (which typically do not work in GDB)
1570 with functions, typedefs and enums, making the code easier to debug.
1571 The functional style also makes code easier to read and maintain.
1572 * systime.h: Include <sys/time.h> on all hosts, not just if
1573 WINDOWSNT, since 'struct timeval' is needed in general.
1574 (EMACS_TIME): Now a typedef, not a macro.
1575 (EMACS_TIME_RESOLUTION, LOG10_EMACS_TIME_RESOLUTION): Now constants,
1577 (EMACS_SECS, EMACS_NSECS, EMACS_TIME_SIGN, EMACS_TIME_VALID_P)
1578 (EMACS_TIME_FROM_DOUBLE, EMACS_TIME_TO_DOUBLE, EMACS_TIME_EQ)
1579 (EMACS_TIME_NE, EMACS_TIME_GT, EMACS_TIME_GE, EMACS_TIME_LT)
1580 (EMACS_TIME_LE): Now functions, not macros.
1581 (EMACS_SET_SECS, EMACS_SET_NSECS, EMACS_SET_SECS_NSECS)
1582 (EMACS_SET_USECS, EMACS_SET_SECS_USECS): Remove these macros,
1583 which are not functions. All uses rewritten to use:
1584 (make_emacs_time): New function.
1585 (EMACS_SECS_ADDR, EMACS_SET_INVALID_TIME, EMACS_GET_TIME)
1586 (EMACS_ADD_TIME, EMACS_SUB_TIME): Remove these macros, which are
1587 not functions. All uses rewritten to use the following, respectively:
1588 (emacs_secs_addr, invalid_emacs_time, get_emacs_time)
1589 (add_emacs_time, sub_emacs_time): New functions.
1590 * atimer.c: Don't include <sys/time.h>, as "systime.h" does this.
1591 * fileio.c (Fcopy_file):
1592 * xterm.c (XTflash): Get the current time closer to when it's used.
1593 * makefile.w32-in ($(BLD)/atimer.$(O)): Update dependencies.
1595 * bytecode.c (targets): Suppress -Woverride-init warnings.
1597 Simplify by avoiding confusing use of strncpy etc.
1598 * doc.c (Fsnarf_documentation):
1599 * fileio.c (Ffile_name_directory, Fsubstitute_in_file_name):
1600 * frame.c (Fmake_terminal_frame):
1601 * gtkutil.c (get_utf8_string):
1603 * nsmenu.m (ns_update_menubar):
1604 * regex.c (regerror):
1605 Prefer memcpy to strncpy and strncat when either will do.
1606 * fileio.c (Fsubstitute_in_file_name):
1607 * keyboard.c (MULTI_LETTER_MOD, parse_modifiers_uncached)
1608 (menu_separator_name_p):
1609 * nsmenu.m (ns_update_menubar):
1610 Prefer memcmp to strncmp when either will do.
1611 * nsterm.m: Include <ftoastr.h>.
1613 * s/gnu-linux.h, s/sol2-6.h, s/unixware.h (PTY_TTY_NAME_SPRINTF):
1614 Prefer snprintf to strncpy.
1615 * nsterm.m (ns_term_init):
1616 * widget.c (set_frame_size) [0]: Prefer xstrdup to xmalloc + strncpy.
1617 * nsterm.m (ns_term_init):
1618 Avoid the need for strncpy, by using build_string or
1619 make_unibyte_string directly. Use dtoastr, not snprintf.
1620 * process.c (Fmake_network_process): Diagnose service names that
1621 are too long, rather than silently truncating them or creating
1622 non-null-terminated names.
1623 (Fnetwork_interface_info): Likewise, for interface names.
1624 * sysdep.c (system_process_attributes) [GNU_LINUX]:
1625 Prefer sprintf to strncat.
1626 * xdisp.c (debug_method_add) [GLYPH_DEBUG]:
1627 Prefer vsnprintf to vsprintf + strncpy.
1629 2012-07-10 Glenn Morris <rgm@gnu.org>
1631 * dispnew.c (PENDING_OUTPUT_COUNT) [!__GNU_LIBRARY__]:
1632 Clarify fallback case.
1634 2012-07-10 Dmitry Antipov <dmantipov@yandex.ru>
1636 Use XCAR and XCDR instead of Fcar and Fcdr where possible.
1637 * callint.c, coding.c, doc.c, editfns.c, eval.c, font.c, fontset.c,
1638 * frame.c, gnutls.c, minibuf.c, msdos.c, textprop.c, w32fns.c,
1639 * w32menu.c, window.c, xmenu.c: Change to use XCAR and XCDR
1640 where argument type is known to be a Lisp_Cons.
1642 2012-07-10 Tom Tromey <tromey@redhat.com>
1644 * bytecode.c (BYTE_CODE_THREADED): New macro.
1645 (BYTE_CODES): New macro. Replaces all old byte-code defines.
1646 (enum byte_code_op): New type.
1647 (CASE, NEXT, FIRST, CASE_DEFAULT, CASE_ABORT): New macros.
1648 (exec_byte_code): Use them. Use token threading when applicable.
1650 2012-07-10 Dmitry Antipov <dmantipov@yandex.ru>
1652 Optimize pure C strings initialization.
1653 * lisp.h (make_pure_string): Fix prototype.
1654 (build_pure_c_string): New function, defined as static inline. This
1655 provides a better opportunity to optimize away calls to strlen when
1656 the function is called with compile-time constant argument.
1657 * alloc.c (make_pure_c_string): Fix comment. Change to add nchars
1658 argument, adjust users accordingly. Use build_pure_c_string where
1660 * buffer.c, coding.c, data.c, dbusbind.c, fileio.c, fontset.c, frame.c,
1661 * keyboard.c, keymap.c, lread.c, search.c, syntax.c, w32fns.c, xdisp.c,
1662 * xfaces.c, xfns.c, xterm.c: Use build_pure_c_string where appropriate.
1664 2012-07-10 Dmitry Antipov <dmantipov@yandex.ru>
1666 Avoid calls to strlen in miscellaneous functions.
1667 * buffer.c (init_buffer): Use precalculated len, adjust if needed.
1668 * font.c (Ffont_xlfd_name): Likewise. Change to call make_string.
1669 * lread.c (openp): Likewise.
1671 2012-07-10 Dmitry Antipov <dmantipov@yandex.ru>
1673 Avoid calls to strlen in path processing functions.
1674 * fileio.c (file_name_as_directory): Add comment. Change to add
1675 srclen argument and return the length of result. Adjust users
1677 (directory_file_name): Fix comment. Change to add srclen argument,
1678 swap 1st and 2nd arguments to obey the common convention. Adjust
1680 * filelock.c (fill_in_lock_file_name): Avoid calls to strlen.
1682 2012-07-10 Glenn Morris <rgm@gnu.org>
1684 * s/cygwin.h, s/darwin.h, s/freebsd.h, s/netbsd.h, s/unixware.h:
1685 Move PENDING_OUTPUT_COUNT definition to configure.
1687 * s/irix6-5.h (DATA_START, DATA_SEG_BITS):
1688 * s/hpux10-20.h (DATA_SEG_BITS, DATA_START):
1689 * s/gnu.h (DATA_START): Move definitions to configure.
1691 * s/irix6-5.h (SETUP_SLAVE_PTY, PTY_NAME_SPRINTF): Drop ifdef guards.
1692 We include usg5-4-common.h, which defines them both.
1694 * s/gnu.h: Don't include fcntl.h (every file in Emacs that uses
1695 O_RDONLY already includes it).
1697 Stop ns builds setting the EMACSLOADPATH environment variable.
1698 * nsterm.m (ns_load_path): Rename from ns_init_paths.
1699 Now it does not set EMACSLOADPATH, just returns the load-path string.
1700 * nsterm.h: Update accordingly.
1701 * lread.c [HAVE_NS]: Include nsterm.h.
1702 (init_lread) [HAVE_NS]: Use ns_load_path.
1703 * emacs.c (main) [HAVE_NS]: No longer call ns_init_paths.
1705 2012-07-09 Glenn Morris <rgm@gnu.org>
1707 * s/gnu.h (SIGNALS_VIA_CHARACTERS): No need to define it here,
1708 since the included bsd-common.h does so.
1710 Stop ns builds setting the EMACSPATH environment variable.
1711 * nsterm.m (ns_exec_path): New function, split from ns_init_paths.
1712 (ns_init_paths): Do not set EMACSPATH.
1713 * nsterm.h (ns_exec_path): Add it.
1714 * callproc.c (init_callproc_1, init_callproc) [HAVE_NS]:
1717 * nsterm.m, nsterm.h (ns_etc_directory): Fix type, empty return.
1719 2012-07-09 Paul Eggert <eggert@cs.ucla.edu>
1721 * process.c (wait_reading_process_output): 'waitchannels' was unset
1722 when read_kbd || !NILP (wait_for_cell); fix this.
1724 Add GCC-style 'const' attribute to functions that can use it.
1725 * character.h (char_resolve_modifier_mask):
1726 * keyboard.h (make_ctrl_char):
1727 * lisp.h (multibyte_char_to_unibyte, multibyte_char_to_unibyte_safe)
1728 (init_character_once, next_almost_prime, init_fns, init_image)
1729 (flush_pending_output, init_sound):
1730 * mem-limits.h (start_of_data):
1731 * menu.h (finish_menu_items):
1732 Add ATTRIBUTE_CONST.
1733 * emacs.c (DEFINE_DUMMY_FUNCTION):
1734 Declare the dummy function with ATTRIBUTE_CONST.
1735 * lisp.h (Fbyteorder, Fmax_char, Fidentity):
1736 Add decls with ATTRIBUTE_CONST.
1738 Minor improvements to make_formatted_string.
1739 * alloc.c (make_formatted_string): Prefer int to ptrdiff_t
1740 where int is good enough, as vsprintf returns an int.
1741 * lisp.h (make_formatted_string): Add ATTRIBUTE_FORMAT_PRINTF.
1743 2012-07-09 Dmitry Antipov <dmantipov@yandex.ru>
1745 Use make_formatted_string to avoid double length calculation.
1746 * lisp.h (make_formatted_string): New prototype.
1747 * alloc.c (make_formatted_string): New function.
1748 * buffer.c (Fgenerate_new_buffer_name): Use it.
1749 * dbus.c (syms_of_dbusbind): Likewise.
1750 * editfns.c (Fcurrent_time_zone): Likewise.
1751 * filelock.c (get_boot_time): Likewise.
1752 * frame.c (make_terminal_frame, set_term_frame_name)
1753 (x_report_frame_params): Likewise.
1754 * image.c (gs_load): Likewise.
1755 * minibuf.c (get_minibuffer): Likewise.
1756 * msdos.c (dos_set_window_size): Likewise.
1757 * process.c (make_process): Likewise.
1758 * xdisp.c (ensure_echo_area_buffers): Likewise.
1759 * xsettings.c (apply_xft_settings): Likewise.
1761 2012-07-09 Glenn Morris <rgm@gnu.org>
1763 Stop ns builds polluting the environment with EMACSDATA, EMACSDOC.
1764 * nsterm.m (ns_etc_directory): New function, split from ns_init_paths.
1765 (ns_init_paths): Do not set EMACSDATA, EMACSDOC.
1766 * nsterm.h (ns_etc_directory): Add it.
1767 * callproc.c [HAVE_NS]: Include nsterm.h.
1768 (init_callproc_1, init_callproc) [HAVE_NS]: Use ns_etc_directory.
1770 2012-07-09 Dmitry Antipov <dmantipov@yandex.ru>
1772 Move marker debugging code under MARKER_DEBUG.
1773 * marker.c (MARKER_DEBUG): Move marker debugging code under
1774 #ifdef MARKER_DEBUG because byte_char_debug_check is too slow
1775 for bootstrap with --enable-checking (~3x slowdown reported
1776 by Juanma Barranquero <lekktu@gmail.com>).
1777 (verify_bytepos): Move under #ifdef MARKER_DEBUG.
1779 2012-07-08 Paul Eggert <eggert@cs.ucla.edu>
1781 * systime.h (EMACS_SUB_TIME): Clarify behavior with unsigned time_t.
1782 See <http://bugs.gnu.org/11825#29>.
1784 2012-07-08 Eli Zaretskii <eliz@gnu.org>
1786 * xdisp.c (fill_glyphless_glyph_string): If the face of the glyph
1787 has no font, use the frame's font. (Bug#11813)
1788 (display_line): Add commentary about displaying truncation glyphs
1790 (produce_special_glyphs): Move here from term.c.
1792 * term.c (produce_special_glyphs): Move to xdisp.c.
1794 * dispextern.h (produce_special_glyphs): Move prototype to xdisp.c
1797 2012-07-07 Andreas Schwab <schwab@linux-m68k.org>
1799 * xdisp.c (display_line): Avoid warning about implicit declaration
1802 * frame.c (get_frame_param): Define only if HAVE_WINDOW_SYSTEM.
1804 * lisp.h: Remove empty conditional.
1806 2012-07-07 Paul Eggert <eggert@cs.ucla.edu>
1808 * lread.c (load_path_check): Now static.
1810 Fix some minor --with-ns problems found by static checking.
1811 * frame.c (Ftool_bar_pixel_width) [!FRAME_TOOLBAR_WIDTH]:
1812 (x_set_font) [!HAVE_X_WINDOWS]:
1813 * image.c (xpm_load_image) [HAVE_NS]:
1814 (x_to_xcolors) [!HAVE_X_WINDOWS && !HAVE_NTGUI]:
1815 (x_disable_image) [!HAVE_NS && !HAVE_NTGUI]:
1816 Remove unused local.
1817 (Fx_parse_geometry) [HAVE_NS]: Don't return garbage.
1818 (xpm_load_image) [HAVE_NS && !HAVE_XPM]: Remove unused label.
1819 * image.c (x_create_bitmap_from_file) [HAVE_NS]:
1820 (xpm_load_image, xpm_load) [HAVE_NS && !HAVE_XPM]:
1821 * nsselect.m (symbol_to_nsstring, ns_string_to_pasteboard_internal):
1822 * xfaces.c (Fx_load_color_file) [!HAVE_X_WINDOWS]:
1823 Fix pointer signedness problem.
1824 * xfaces.c (FRAME_X_FONT_TABLE):
1825 * xterm.h (FRAME_X_FONT_TABLE): Remove unused, incompatible macros.
1827 2012-07-07 Glenn Morris <rgm@gnu.org>
1829 * lread.c (load_path_check): New function, split from init_lread.
1830 (init_lread): Reorganize. Motivation:
1831 If EMACSLOADPATH is set, check/warn about that rather than the
1832 defaults, which we are not going to use. Hence we can remove
1833 the turn_off_warning and WINDOWSNT || HAVE_NS tests.
1834 Don't warn if site-lisp directories are missing.
1835 If not installed, start from a blank load-path, since
1836 PATH_LOADSEARCH refers to the eventual installation directories.
1838 2012-07-07 Eli Zaretskii <eliz@gnu.org>
1840 Support truncation and continuation glyphs on GUI frames, when
1841 fringes are disabled. (Bug#11832)
1842 * xdisp.c (init_iterator): Get dimensions of truncation and
1843 continuation glyphs even if on GUI frames. Adjust
1844 it->last_visible_x on GUI frames when the left or right fringes,
1845 or both, are absent.
1846 (start_display, move_it_in_display_line_to): Handle the case of a
1847 GUI frame without a fringe to display continuation or truncation
1849 (insert_left_trunc_glyphs): Support GUI frames: make sure
1850 truncation glyphs overwrite enough glyphs from the current line to
1851 have sufficient space in pixels.
1852 (display_line): Support truncation and continuation glyphs on GUI
1853 frames. If some spare pixels are left on the line after inserting
1854 the truncation glyphs, fill that space with a stretch glyph of a
1855 suitably computed width.
1857 * term.c (produce_special_glyphs): Call PRODUCE_GLYPHS, not
1858 produce_glyphs, to support GUI sessions.
1860 2012-07-07 Paul Eggert <eggert@cs.ucla.edu>
1862 * sysdep.c (ULLONG_MAX): Define if not already defined (Bug#11781).
1864 * sysdep.c (list_system_processes): Port to NetBSD-current (Bug#11797).
1866 Do not require float-time's arg to fit in time_t (Bug#11825).
1867 This works better on hosts where time_t is unsigned, and where
1868 float-time is applied to the (negative) difference between two times.
1869 * editfns.c (decode_time_components): Last arg is now double *,
1870 not int *, and means to store all the result as a double, without
1871 worrying about whether the seconds part fits in time_t.
1872 All callers changed.
1873 (lisp_time_argument): Remove last int * arg, as it's no longer needed.
1874 All callers changed.
1875 (Ffloat_time): Do not fail merely because the specified time falls
1876 outside of time_t range.
1878 2012-07-07 Glenn Morris <rgm@gnu.org>
1880 * s/darwin.h (HAVE_RES_INIT, HAVE_LIBRESOLV):
1881 * s/hpux10-20.h (HAVE_RINT, HAVE_RANDOM):
1882 * s/unixware.h (HAVE_GETWD): Move undefs to configure (effectively).
1884 2012-07-07 Juanma Barranquero <lekktu@gmail.com>
1886 * makefile.w32-in (DISPEXTERN_H, $(BLD)/regex.$(O)):
1887 Update dependencies.
1889 * s/ms-w32.h [_MSC_VER]: Remove strcasecmp, strncasecmp.
1891 2012-07-06 Paul Eggert <eggert@cs.ucla.edu>
1893 Use c_strcasecmp for ASCII case-insensitive comparison (Bug#11786).
1894 * dispextern.h, nsfns.m, nsterm.m: Include <c-strcase.h>.
1895 * dispextern.h (xstrcasecmp): Rewrite using c_strcasecmp.
1896 * nsfns.m (x_get_string_resource): Use c_strncasecmp, not strncasecmp.
1897 * nsterm.m (ns_default): Use c_strcasecmp, not strcasecmp.
1898 * xfaces.c (xstrcasecmp) [!HAVE_STRCASECMP]: Remove.
1900 * xfont.c (compare_font_names): Redo to omit the need for casts.
1902 2012-07-06 Andreas Schwab <schwab@linux-m68k.org>
1904 * xfns.c (Fx_change_window_property): Doc fix.
1905 * w32fns.c (Fx_change_window_property): Doc fix.
1907 * w32fns.c (Fx_window_property): Accept the same arguments as the
1908 X Windows version. Doc fix.
1909 * xfns.c (Fx_window_property): Doc fix. (Bug#11870)
1911 2012-07-06 Juanma Barranquero <lekktu@gmail.com>
1912 Eli Zaretskii <eliz@gnu.org>
1914 * s/ms-w32.h: Settings not specific to Windows moved to nt/config.nt.
1915 Windows-specific code from nt/config.nt moved here.
1916 Obsolete settings removed.
1918 2012-07-06 Paul Eggert <eggert@cs.ucla.edu>
1920 * process.c: Avoid unnecessary calls to gettime.
1921 (wait_reading_process_output): Don't get the time of day
1922 when gobbling data immediately and not waiting, as there's no need
1923 for it in that case. This removes a FIXME.
1925 2012-07-06 Jan Djärv <jan.h.d@swipnet.se>
1927 * gtkutil.c (xg_event_is_for_scrollbar): Assign gwin when HAVE_GTK3
1928 is defined (Bug#11768).
1930 2012-07-06 Dmitry Antipov <dmantipov@yandex.ru>
1932 Fix marker debugging code.
1933 * marker.c (byte_char_debug_check): Do not perform the check
1934 if buffer is not multibyte.
1935 (buf_charpos_to_bytepos, buf_bytepos_to_charpos):
1936 Call byte_char_debug_check with correct arguments.
1938 2012-07-06 Dmitry Antipov <dmantipov@yandex.ru>
1940 Compile marker debugging code only if ENABLE_CHECKING is defined.
1941 * marker.c (byte_char_debug_check, count_markers):
1942 Use only if ENABLE_CHECKING is defined.
1943 (byte_debug_flag): Remove.
1944 (CONSIDER, buf_charpos_to_bytepos, buf_bytepos_to_charpos):
1945 Always call byte_char_debug_check if ENABLE_CHECKING is defined.
1947 2012-07-06 Dmitry Antipov <dmantipov@yandex.ru>
1949 Avoid code repetition in marker-related functions.
1950 * marker.c (attach_marker): New function.
1951 (Fset_marker, set_marker_restricted, set_marker_both)
1952 (set_marker_restricted_both): Use it.
1953 (Fset_marker, set_marker_restricted, Fbuffer_has_markers_at):
1954 Consistently rename charno to charpos.
1955 (marker_position): Add eassert.
1956 (marker_byte_position): Convert to eassert.
1958 2012-07-06 Dmitry Antipov <dmantipov@yandex.ru>
1960 Simplify list operations in unchain_overlay and unchain_marker.
1961 * buffer.c (unchain_overlay): Simplify. Add comment.
1962 * marker.c (unchain_marker): Simplify. Fix comments.
1964 2012-07-06 Dmitry Antipov <dmantipov@yandex.ru>
1966 Introduce fast path for the widely used marker operation.
1967 * alloc.c (build_marker): New function.
1968 * lisp.h (build_marker): New prototype.
1969 * buffer.c (clone_per_buffer_values, Fmake_indirect_buffer): Use it.
1970 * composite.c (autocmp_chars): Likewise.
1971 * editfns.c (buildmark): Remove.
1972 (Fpoint_marker, Fpoint_min_marker, Fpoint_max_marker)
1973 (save_restriction_save): Use build_marker.
1974 * marker.c (buf_charpos_to_bytepos, buf_bytepos_to_charpos): Likewise.
1975 * window.c (save_window_save): Likewise.
1977 2012-07-06 Dmitry Antipov <dmantipov@yandex.ru>
1979 Do not use Fdelete_overlay in delete_all_overlays
1980 to avoid redundant calls to unchain_overlay.
1981 * buffer.c (drop_overlay): New function.
1982 (delete_all_overlays, Fdelete_overlay): Use it.
1983 * minibuf.c (get_minibuffer): Fix comment.
1985 2012-07-06 Paul Eggert <eggert@cs.ucla.edu>
1987 Port to OpenBSD 5.1 amd64.
1988 * sysdep.c [BSD_SYSTEM]: Include <sys/param.h> before <sys/sysctl.h>.
1989 This is needed for OpenBSD, and should be harmless on all BSD systems.
1990 Also, include <sys/sysctl.h>, as it should be available on all
1991 BSD_SYSTEM hosts given that we're already calling sysctl in that case.
1992 (list_system_processes) [__OpenBSD__]: Use DARWIN_OS style mib, but
1993 use p_pid member, not kp_proc.pid.
1995 2012-07-06 Glenn Morris <rgm@gnu.org>
1997 * Makefile.in (emacs$(EXEEXT)): Don't check for load-path shadows.
1999 2012-07-05 Paul Eggert <eggert@cs.ucla.edu>
2001 More xmalloc and related cleanup.
2002 * alloc.c, bidi.c, buffer.c, buffer.h, bytecode.c, callint.c:
2003 * callproc.c, charset.c, coding.c, composite.c, data.c, dispnew.c:
2004 * doc.c, editfns.c, emacs.c, eval.c, fileio.c, filelock.c, fns.c:
2005 * font.c, fontset.c, frame.c, fringe.c, ftfont.c, ftxfont.c, gmalloc.c:
2006 * gtkutil.c, image.c, keyboard.c, keymap.c, lread.c, macros.c, menu.c:
2007 * nsfns.m, nsfont.m, nsmenu.m, nsterm.m, print.c, process.c, ralloc.c:
2008 * regex.c, region-cache.c, scroll.c, search.c, sound.c, syntax.c:
2009 * sysdep.c, term.c, termcap.c, unexmacosx.c, window.c, xdisp.c:
2010 * xfaces.c, xfns.c, xftfont.c, xgselect.c, xmenu.c, xrdb.c, xselect.c:
2012 Omit needless casts involving void * pointers and allocation.
2013 Prefer "P = xmalloc (sizeof *P)" to "P = xmalloc (sizeof (TYPE_OF_P))",
2014 as the former is more robust if P's type is changed.
2015 Prefer xzalloc to xmalloc + memset 0.
2016 Simplify malloc-or-realloc to realloc.
2017 Don't worry about xmalloc returning a null pointer.
2018 Prefer xstrdup to xmalloc + strcpy.
2019 * editfns.c (Fmessage_box): Grow message_text by at least 80 when
2021 * keyboard.c (apply_modifiers_uncached): Prefer local array to
2022 alloca of a constant.
2024 2012-07-05 Eli Zaretskii <eliz@gnu.org>
2026 * xdisp.c (display_line): Fix horizontal pixel coordinates when
2027 hscroll is larger than the line width. Fixes long and futile
2028 looping inside extend_face_to_end_of_line (on a TTY) producing
2029 glyphs that are not needed and thrown away.
2031 2012-07-05 Dmitry Antipov <dmantipov@yandex.ru>
2033 * marker.c (set_marker_restricted_both): Simplify by using
2036 2012-07-05 Paul Eggert <eggert@cs.ucla.edu>
2038 * editfns.c (region_limit): Simplify by using clip_to_bounds.
2040 2012-07-05 Jan Djärv <jan.h.d@swipnet.se>
2042 * gtkutil.c (gtk_scrollbar_new, gtk_box_new): Define when HAVE_GTK3 is
2043 not defined (Bug#11768).
2044 (xg_create_frame_widgets): Use gtk_plug_new_for_display (Bug#11768).
2045 (xg_create_frame_widgets, create_dialog, xg_get_file_with_chooser)
2046 (make_widget_for_menu_item, xg_make_tool_item): Use gtk_box_new
2047 followed by gtk_box_set_homogeneous (Bug#11768).
2048 (xg_update_menu_item): Use GTK_IS_BOX (Bug#11768).
2049 (update_theme_scrollbar_width, xg_create_scroll_bar):
2050 Use gtk_scrollbar_new (Bug#11768).
2051 (xg_event_is_for_scrollbar): Use Gdk Device functions for HAVE_GTK3.
2052 (is_box_type): New function (Bug#11768).
2053 (xg_tool_item_stale_p): Call is_box_type.
2054 (xg_initialize): Get settings by calling gtk_settings_get_for_screen
2055 with default display (Bug#11768).
2057 2012-07-05 Eli Zaretskii <eliz@gnu.org>
2059 * xdisp.c (window_hscroll_limited): New function.
2060 (pos_visible_p, init_iterator): Use it to avoid overflow of pixel
2061 coordinates when window's hscroll is set to insanely large
2064 2012-07-05 Juanma Barranquero <lekktu@gmail.com>
2066 * makefile.w32-in ($(BLD)/dired.$(O), $(BLD)/fileio.$(O)): Fix typo.
2067 ($(BLD)/terminal.$(O), $(BLD)/syntax.$(O)): Update dependencies.
2069 2012-07-05 Dmitry Antipov <dmantipov@yandex.ru>
2072 * lisp.h (xzalloc): New prototype. Omit needless casts.
2073 * alloc.c (xzalloc): New function. Omit needless casts.
2074 * charset.c: Omit needless casts. Convert all calls to
2075 xmalloc with following memset to xzalloc.
2076 * dispnew.c: Likewise.
2077 * fringe.c: Likewise.
2078 * image.c: Likewise.
2079 * sound.c: Likewise.
2081 * w32fns.c: Likewise.
2082 * w32font.c: Likewise.
2083 * w32term.c: Likewise.
2084 * xfaces.c: Likewise.
2086 * xterm.c: Likewise.
2087 * atimer.c: Omit needless casts.
2088 * buffer.c: Likewise.
2089 * callproc.c: Likewise.
2091 * coding.c: Likewise.
2092 * composite.c: Likewise.
2094 * doprnt.c: Likewise.
2095 * editfns.c: Likewise.
2096 * emacs.c: Likewise.
2098 * filelock.c: Likewise.
2100 * gtkutil.c: Likewise.
2101 * keyboard.c: Likewise.
2103 * lread.c: Likewise.
2104 * minibuf.c: Likewise.
2105 * msdos.c: Likewise.
2106 * print.c: Likewise.
2107 * process.c: Likewise.
2108 * region-cache.c: Likewise.
2109 * search.c: Likewise.
2110 * sysdep.c: Likewise.
2111 * termcap.c: Likewise.
2112 * terminal.c: Likewise.
2113 * tparam.c: Likewise.
2114 * w16select.c: Likewise.
2116 * w32reg.c: Likewise.
2117 * w32select.c: Likewise.
2118 * w32uniscribe.c: Likewise.
2119 * widget.c: Likewise.
2120 * xdisp.c: Likewise.
2121 * xmenu.c: Likewise.
2123 * xselect.c: Likewise.
2125 2012-07-05 Paul Eggert <eggert@cs.ucla.edu>
2127 * fileio.c (time_error_value): Check the right error number.
2128 Problem reported by Troels Nielsen in
2129 <http://lists.gnu.org/archive/html/emacs-devel/2012-07/msg00095.html>.
2131 2012-07-04 Paul Eggert <eggert@cs.ucla.edu>
2133 * window.c (set_window_hscroll): Revert the 100000 hscroll limit.
2134 This should be fixed in a better way; see Eli Zaretskii in
2135 <http://lists.gnu.org/archive/html/emacs-devel/2012-07/msg00088.html>.
2136 (HSCROLL_MAX): Remove; this is now internal to set_window_hscroll.
2138 * fileio.c (time_error_value): Rename from special_mtime.
2139 The old name's problems were noted by Eli Zaretskii in
2140 <http://lists.gnu.org/archive/html/emacs-devel/2012-07/msg00087.html>.
2142 * emacs.c (gdb_pvec_type): Change it back to enum pvec_type.
2143 This variable's comment says Emacs needs at least one GDB-visible
2144 symbol of type enum pvec_type, to work around GDB problems.
2145 The symbol's value doesn't matter.
2147 * alloc.c (PSEUDOVECTOR_NBYTES): Remove stray ';'
2148 that causes compilation to fail on pre-C99 compilers.
2150 2012-07-04 Juanma Barranquero <lekktu@gmail.com>
2152 * s/ms-w32.h (LISP_FLOAT_TYPE, HAVE_MEMCMP, HAVE_MEMCPY)
2153 (HAVE_MEMMOVE, HAVE_MEMSET): Don't set, obsolete.
2155 2012-07-04 Dmitry Antipov <dmantipov@yandex.ru>
2157 * buffer.c (init_buffer_once): Fix initialization of
2158 headers for buffer_defaults and buffer_local_symbols.
2159 Reported by Juanma Barranquero <lekktu@gmail.com>.
2161 2012-07-04 Stefan Monnier <monnier@iro.umontreal.ca>
2163 Turn VECTOR_FREE_LIST_FLAG into PVEC_FREE.
2164 * lisp.h (enum pvec_type): Use fewer bits.
2165 (PSEUDOVECTOR_SIZE_BITS): New constant.
2166 (PSEUDOVECTOR_SIZE_MASK, PVEC_TYPE_MASK): Use it.
2167 (XSETPVECTYPESIZE, XSETTYPED_PSEUDOVECTOR, DEFUN): Adapt code to
2168 change in pvec_type.
2169 (PSEUDOVECTOR_TYPEP): New macro.
2170 (TYPED_PSEUDOVECTORP): Use it.
2171 * fns.c (internal_equal): Adapt code to extract pvectype.
2172 * emacs.c (gdb_pvec_type): Update type.
2173 * alloc.c (PSEUDOVECTOR_NBYTES): New macro.
2174 (VECTOR_FREE_LIST_SIZE_MASK): Remove (=> PSEUDOVECTOR_SIZE_MASK).
2175 (VECTOR_FREE_LIST_FLAG): Remove (=> PVEC_FREE).
2176 (SETUP_ON_FREE_LIST): Use XSETPVECTYPESIZE.
2177 (sweep_vectors): Use it. Use local var `total_bytes' instead of
2178 abusing vector->header.next.nbytes.
2179 (live_vector_p): Use PVEC_TYPE.
2180 (mark_object): Adapt code to extract pvectype. Use switch.
2182 2012-07-04 Paul Eggert <eggert@cs.ucla.edu>
2184 * doprnt.c (doprnt): Don't assume string length fits in 'int'.
2185 Tighten new eassert a bit.
2187 2012-07-04 Dmitry Antipov <dmantipov@yandex.ru>
2189 Fix compilation with --enable-gcc-warnings and -O1
2191 * doprnt.c (doprnt): Change type of tem to int, initialize
2192 to avoid compiler warning. Add eassert.
2193 * search.c (simple_search): Initialize match_byte to avoid
2194 compiler warning. Add eassert.
2196 2012-07-04 Paul Eggert <eggert@cs.ucla.edu>
2198 Avoid weird behavior with large horizontal scrolls.
2199 Without this change, for example, large hscroll values would
2200 mess up Emacs's display on Fedora 15 x86, presumably due to
2201 overflows in int calculations in the display code.
2202 Also, if buffers had long lines, Emacs would freeze.
2203 * window.c (HSCROLL_MAX): Reduce to 100000, and make it visible to GDB.
2204 (set_window_hscroll): New function, containing the old guts of
2205 Fset_window_hscroll. Return the clipped value.
2206 (Fset_window_hscroll, Fscroll_left, Fscroll_right): Use it.
2207 This avoids the need to check against PTRDIFF_MAX.
2209 * buffer.c (Fgenerate_new_buffer_name): Fix sprintf format mismatch.
2211 2012-07-04 Dmitry Antipov <dmantipov@yandex.ru>
2213 * buffer.c (Fgenerate_new_buffer_name): Fix type mismatch.
2215 2012-07-04 Paul Eggert <eggert@cs.ucla.edu>
2217 * regex.c: Suppress GCC warning on RHEL 6. (Bug#11207)
2218 Conditionalize the pragmas on GCC 4.5 or later, not GCC 4.3 or later,
2219 since GCC 4.4.6 issues a bogus warning for them.
2221 Fix bugs in file timestamp newness comparisons.
2222 * fileio.c (Ffile_newer_than_file_p):
2223 * lread.c (Fload): Use full timestamp resolution of files,
2224 not just the 1-second resolution, so that files that are only
2225 slightly newer still count as newer.
2226 * fileio.c (Ffile_newer_than_file_p): Don't assume file
2227 timestamps fit in 'int'; this fixes a Y2038 bug on most hosts.
2229 2012-07-03 Paul Eggert <eggert@cs.ucla.edu>
2231 * fileio.c: Improve handling of file time marker. (Bug#11852)
2232 (special_mtime): New function.
2233 (Finsert_file_contents, Fverify_visited_file_modtime):
2234 Use it to set special mtime values consistently.
2236 2012-07-03 Andreas Schwab <schwab@linux-m68k.org>
2238 * fileio.c (Finsert_file_contents): Properly handle st_mtime
2239 marker for non-existing file. (Bug#11852)
2241 2012-07-03 Glenn Morris <rgm@gnu.org>
2243 * lisp.h (Fread_file_name): Restore EXFUN (it's not a normal DEFUN
2244 and did not make it into globals.h).
2246 2012-07-03 Tom Tromey <tromey@redhat.com>
2248 * window.c (Fset_window_margins, Fset_window_fringes)
2249 (Fset_window_scroll_bars, Fset_window_vscroll): No longer static.
2250 * textprop.c (Fprevious_property_change): No longer static.
2251 * syntax.c (Fsyntax_table_p): No longer static.
2252 * process.c (Fget_process, Fprocess_datagram_address): No longer
2254 * keymap.c (Flookup_key, Fcopy_keymap): No longer static.
2255 * keyboard.c (Fcommand_execute): No longer static.
2257 * insdel.c (Fcombine_after_change_execute): No longer static.
2258 * image.c (Finit_image_library): No longer static.
2259 * fileio.c (Fmake_symbolic_link): No longer static.
2260 * eval.c (Ffetch_bytecode): No longer static.
2261 * editfns.c (Fuser_full_name): No longer static.
2262 * doc.c (Fdocumentation_property, Fsnarf_documentation):
2264 * buffer.c (Fset_buffer_major_mode, Fdelete_overlay): No longer
2266 * dired.c (Ffile_attributes): No longer static.
2267 * composite.c (Fcomposition_get_gstring): No longer static.
2268 * callproc.c (Fgetenv_internal): No longer static.
2270 * ccl.h: Remove EXFUNs.
2271 * buffer.h: Remove EXFUNs.
2272 * dispextern.h: Remove EXFUNs.
2273 * intervals.h: Remove EXFUNs.
2274 * fontset.h: Remove EXFUN.
2275 * font.h: Remove EXFUNs.
2276 * dosfns.c (system_process_attributes): Remove EXFUN.
2277 * keymap.h: Remove EXFUNs.
2278 * lisp.h: Remove EXFUNs.
2279 * w32term.h: Remove EXFUNs.
2280 * window.h: Remove EXFUNs.
2281 * xsettings.h: Remove EXFUN.
2282 * xterm.h: Remove EXFUN.
2284 2012-07-03 Glenn Morris <rgm@gnu.org>
2286 * lisp.h (Frandom): Make it visible to C.
2287 * buffer.c (Fgenerate_new_buffer_name): Speed up finding a new
2288 buffer for invisible buffers. (Bug#1229)
2290 2012-07-03 Dmitry Antipov <dmantipov@yandex.ru>
2292 Fix block vector allocation code to allow VECTOR_BLOCK_SIZE
2293 values which aren't power of 2.
2294 * alloc.c (VECTOR_FREE_LIST_SIZE_MASK): New macro. Verify
2295 it's value and the value of VECTOR_BLOCK_SIZE. Adjust users
2298 2012-07-03 Stefan Monnier <monnier@iro.umontreal.ca>
2300 * lisp.h (Lisp_Misc, Lisp_Fwd): Move around to group better.
2302 * alloc.c (mark_object): Revert part of last patch to use `switch'.
2304 2012-07-03 Dmitry Antipov <dmantipov@yandex.ru>
2306 * alloc.c (allocate_vector_block): Remove redundant
2307 calls to mallopt if DOUG_LEA_MALLOC is defined.
2308 (allocate_vectorlike): If DOUG_LEA_MALLOC is defined,
2309 avoid calls to mallopt if zero_vector is returned.
2311 2012-07-03 Dmitry Antipov <dmantipov@yandex.ru>
2313 * alloc.c (check_string_bytes): If GC_CHECK_STRING_BYTES
2314 is enabled, avoid dereferencing NULL current_sblock if
2317 2012-07-03 Dmitry Antipov <dmantipov@yandex.ru>
2319 Cleanup basic buffer management.
2320 * buffer.h (struct buffer): Change layout to use generic vector
2321 marking code. Fix some comments. Change type of 'clip_changed'
2322 to bitfield. Remove unused #ifndef old.
2323 (FIRST_FIELD_PER_BUFFER, LAST_FIELD_PER_BUFFER): Remove.
2324 (GET_OVERLAYS_AT): Fix indentation.
2325 (for_each_per_buffer_object_at): New macro.
2326 * buffer.c (clone_per_buffer_values, reset_buffer_local_variables)
2327 (Fbuffer_local_variables): Use it.
2328 (init_buffer_once, syms_of_buffer): Remove unused #ifndef old.
2329 * alloc.c (allocate_buffer): Adjust to match new layout of
2330 struct buffer. Fix comment.
2331 (mark_overlay): New function.
2332 (mark_buffer): Use it. Use mark_vectorlike to mark normal
2333 Lisp area of struct buffer.
2334 (mark_object): Use it. Adjust marking of misc objects
2335 and related comments.
2337 2012-07-02 Paul Eggert <eggert@cs.ucla.edu>
2339 * alloc.c (mark_object): Remove "#ifdef GC_CHECK_MARKED_OBJECTS"
2340 wrapper that is not needed because the wrapped code is a no-op (zero
2341 machine instructions) when GC_CHECK_MARKED_OBJECTS is not defined.
2342 This avoids a -Wunused-macros diagnostic with GCC 4.7.1 x86-64.
2344 2012-07-02 Dmitry Antipov <dmantipov@yandex.ru>
2346 * alloc.c (mark_buffer): Simplify. Remove prototype.
2347 (mark_object): Add comment. Reorganize marking of vector-like
2348 objects. Use CHECK_LIVE for all vector-like objects except buffers
2349 and subroutines when GC_CHECK_MARKED_OBJECTS is defined. Avoid
2350 redundant calls to mark_vectorlike for bool vectors.
2352 2012-06-30 Glenn Morris <rgm@gnu.org>
2354 * nsterm.m (ns_init_paths): Ignore site-lisp if --no-site-lisp.
2356 * epaths.in (PATH_SITELOADSEARCH): New.
2357 * lread.c (init_lread): Use PATH_SITELOADSEARCH.
2358 This is rather than relying on --enable-locallisppath elements
2359 having "site-lisp" in their names. (Bug#10208#25, 11658)
2361 2012-06-30 Eli Zaretskii <eliz@gnu.org>
2363 * w32proc.c (sys_select): Accept and ignore one more argument.
2365 * w32.c (emacs_gnutls_pull): Call select with one more argument.
2367 * sysselect.h [DOS_NT]: Don't include sys/select.h.
2368 (pselect) [!MS_DOS]: Redirect to sys_select.
2370 * sysdep.c: Don't include dos.h and dosfns.h.
2372 * process.c (sys_select):
2373 * msdos.c (sys_select): Accept one more argument and ignore it.
2375 * msdos.c (event_timestamp, sys_select): Use gnulib's gettime;
2376 adapt data types and code to that.
2379 * msdos.c (gettime, settime): Define away the prototypes in dos.h,
2380 which clashes with the gnulib function of the same name.
2382 2012-06-30 Andreas Schwab <schwab@linux-m68k.org>
2384 * font.c (font_style_to_value, font_style_symbolic)
2385 (font_prop_validate_style): Add type checks for values in
2388 * lisp.h (CHECK_RANGED_INTEGER): Make value to check the first
2390 * character.c, charset.c, menu.c, process.c, window.c: Adjust all
2393 2012-06-29 Eli Zaretskii <eliz@gnu.org>
2395 * xdisp.c (try_window_id): Undo last change.
2397 * w32.c (getwd): Adjust commentary about startup_dir.
2398 (init_environment): Always call sys_access, even in non-MSVC
2399 builds. Don't chdir to the directory of the Emacs executable.
2400 This undoes code from 1997 which was justified by the need to
2401 "avoid conflicts when removing and renaming directories". But its
2402 downside was that every relative file name was being interpreted
2403 relative to the directory of the Emacs executable, which can never
2404 be TRT. In particular, it broke sys_access when called with
2405 relative file names.
2406 (sys_access): Map GetLastError to errno.
2408 2012-06-29 Dmitry Antipov <dmantipov@yandex.ru>
2410 * window.h (struct window): Change type of 'fringes_outside_margins'
2411 to bitfield. Fix comment. Adjust users accordingly.
2412 (struct window): Change type of 'window_end_bytepos' to ptrdiff_t.
2414 * xdisp.c (try_window_id): Change type of 'first_vpos' and 'vpos'
2417 2012-06-29 Andreas Schwab <schwab@linux-m68k.org>
2419 * gnutls.c (emacs_gnutls_handshake):
2420 Add QUIT to make the loop interruptible.
2422 2012-06-29 Glenn Morris <rgm@gnu.org>
2424 * charset.c (init_charset): Make lack of etc/charsets fatal.
2426 2012-06-29 Dmitry Antipov <dmantipov@yandex.ru>
2428 * editfns.c (region_limit): Fix type mismatch.
2430 2012-06-29 Dmitry Antipov <dmantipov@yandex.ru>
2432 * nsfns.m: Fix GLYPH_DEBUG usage assuming that it may be
2433 undefined. Convert from xassert to eassert.
2434 * nsmenu.m: Convert from xassert to eassert.
2435 * nsterm.m: Likewise.
2437 2012-06-28 Stefan Monnier <monnier@iro.umontreal.ca>
2439 * editfns.c (region_limit): Clip to narrowing (bug#11770).
2441 2012-06-28 Paul Eggert <eggert@cs.ucla.edu>
2443 Avoid integer overflow on scroll-left and scroll-right.
2444 * window.c (HSCROLL_MAX): New macro.
2445 (Fscroll_left, Fscroll_right): Avoid undefined behavior on integer
2446 overflow when requested scroll falls outside ptrdiff_t range.
2448 2012-06-28 Dmitry Antipov <dmantipov@yandex.ru>
2450 * window.h (struct window): Change type of 'hscroll',
2451 'min_hscroll' and 'last_point' from Lisp_Object to ptrdiff_t,
2452 'last_modified' and 'last_overlay_modified' to EMACS_INT.
2453 Adjust users accordingly.
2454 * xdisp.c (try_cursor_movement): Replace type check with eassert.
2455 * window.c (Fscroll_left, Fscroll_right): Change type of 'hscroll'
2456 from EMACS_INT to ptrdiff_t.
2457 (make_window): Omit redundant initialization.
2459 2012-06-28 Juanma Barranquero <lekktu@gmail.com>
2461 * makefile.w32-in ($(BLD)/regex.$(O)): Update dependencies.
2463 2012-06-28 Dmitry Antipov <dmantipov@yandex.ru>
2465 * window.h (struct window): Change type of 'use_time' and
2466 'sequence_number' from Lisp_Object to int.
2467 * frame.c (make_frame): Adjust users accordingly.
2468 * print.c (print_object): Likewise.
2469 * window.c (select_window, Fwindow_use_time, make_parent_window)
2470 (make_window): Likewise.
2472 2012-06-28 Dmitry Antipov <dmantipov@yandex.ru>
2474 * dispextern.h (GLYPH_DEBUG): Now defined in config.h if
2475 enabled with --enable-checking=[all,glyphs] configure option.
2476 Fix GLYPH_DEBUG usage assuming that it may be undefined,
2477 adjust comments accordingly.
2478 * dispnew.c: Fix GLYPH_DEBUG usage assuming that it may be
2479 undefined, adjust comments accordingly.
2480 * image.c: Likewise.
2481 * scroll.c: Likewise.
2482 * w32fns.c: Likewise.
2483 * w32term.c: Likewise.
2484 * xdisp.c: Likewise.
2485 * xfaces.c: Likewise.
2487 * xterm.c: Likewise.
2489 2012-06-28 Dmitry Antipov <dmantipov@yandex.ru>
2491 Generalize run-time debugging checks.
2492 * dispextern.h (XASSERTS): Remove.
2493 * fontset.c (xassert): Remove.
2494 Convert from xassert to eassert.
2495 * alloc.c: Convert from xassert to eassert.
2497 * dispnew.c: Likewise.
2499 * fringe.c: Likewise.
2500 * ftfont.c: Likewise.
2501 * gtkutil.c: Likewise.
2502 * image.c: Likewise.
2503 * keyboard.c: Likewise.
2505 * process.c: Likewise.
2506 * scroll.c: Likewise.
2507 * sound.c: Likewise.
2509 * w32console.c: Likewise.
2510 * w32fns.c: Likewise.
2511 * w32term.c: Likewise.
2512 * window.c: Likewise.
2513 * xdisp.c: Likewise.
2514 * xfaces.c: Likewise.
2516 * xselect.c: Likewise.
2517 * xterm.c: Likewise.
2519 2012-06-27 Stefan Monnier <monnier@iro.umontreal.ca>
2521 * fns.c (maybe_resize_hash_table): Output message when growing the
2524 2012-06-27 Dmitry Antipov <dmantipov@yandex.ru>
2526 * alloc.c (allocate_string_data): Remove dead code.
2527 * xsettings.c (XSETTINGS_FONT_NAME): Move under HAVE_XFT to
2528 avoid GCC warning about unused macro.
2530 2012-06-27 Dmitry Antipov <dmantipov@yandex.ru>
2532 * alloc.c (allocate_string): Omit intervals initialization.
2533 * alloc.c (make_uninit_multibyte_string): Initialize intervals
2534 as in make_pure_string and make_pure_c_string.
2536 2012-06-27 Dmitry Antipov <dmantipov@yandex.ru>
2538 * alloc.c (allocate_string): Fix last change.
2540 2012-06-27 Dmitry Antipov <dmantipov@yandex.ru>
2542 * alloc.c (allocate_string): Remove two redundant calls
2543 to memset, add explicit initialization where appropriate.
2545 2012-06-27 Glenn Morris <rgm@gnu.org>
2547 * lisp.mk (lisp): Remove paths.elc.
2549 2012-06-27 Chong Yidong <cyd@gnu.org>
2551 * doc.c (Fsubstitute_command_keys): Fix punctuation.
2553 2012-06-26 John Wiegley <johnw@newartisans.com>
2555 * unexmacosx.c (copy_data_segment): Add two section names used
2556 on Mac OS X Lion: __mod_init_func and __mod_term_func.
2558 * alloc.c (mark_memory): Do not check with -faddress-sanitizer
2559 when building with Clang.
2561 2012-06-26 Stefan Monnier <monnier@iro.umontreal.ca>
2563 * eval.c (Fapply): Allow calling it with a single argument.
2565 2012-06-26 Eli Zaretskii <eliz@gnu.org>
2567 * s/ms-w32.h (strcasecmp, strncasecmp) [_MSC_VER]: Redirect to
2568 _stricmp and _strnicmp.
2569 (HAVE_STRCASECMP, HAVE_STRNCASECMP): Define to 1.
2571 2012-06-26 Dmitry Antipov <dmantipov@yandex.ru>
2573 * alloc.c (allocate_window): Zero out non-Lisp part of newly
2575 (allocate_process): Likewise for new process.
2576 (allocate_terminal): Change to use offsetof.
2577 (allocate_frame): Likewise.
2578 * frame.c (make_frame): Omit redundant initialization.
2579 * window.c (make_parent_window): Use memset.
2580 (make_window): Omit redundant initialization.
2581 * process.c (make_process): Omit redundant initialization.
2582 * terminal.c (create_terminal): Likewise.
2584 2012-06-26 Dmitry Antipov <dmantipov@yandex.ru>
2586 * term.c (delete_tty): Remove redundant call to memset.
2588 2012-06-26 Dmitry Antipov <dmantipov@yandex.ru>
2590 * alloc.c: Remove build_string.
2591 * lisp.h: Define build_string as static inline. This provides
2592 a better opportunity to optimize away calls to strlen when the
2593 function is called with compile-time constant argument.
2594 * image.c (imagemagick_error): Convert to build_string.
2595 * w32proc.c (sys_spawnve): Likewise.
2596 * xterm.c (x_term_init): Likewise.
2598 2012-06-26 Paul Eggert <eggert@cs.ucla.edu>
2600 Use sprintf return value instead of invoking strlen on result.
2601 In the old days this wasn't portable, since some sprintf
2602 implementations returned char *. But they died out years ago and
2603 Emacs already assumes sprintf returns int.
2604 Similarly for float_to_string.
2605 This patch speeds up (number-to-string 1000) by 3% on Fedora 15 x86-64.
2606 * ccl.c (ccl_driver):
2607 * character.c (string_escape_byte8):
2608 * data.c (Fnumber_to_string):
2609 * doprnt.c (doprnt):
2610 * print.c (print_object):
2611 * xdisp.c (message_dolog):
2612 * xfns.c (syms_of_xfns):
2613 Use sprintf or float_to_string result to avoid need to call strlen.
2614 * data.c (Fnumber_to_string):
2615 Use make_unibyte_string, since the string must be ASCII.
2616 * lisp.h, print.c (float_to_string): Now returns int length.
2617 * term.c (produce_glyphless_glyph):
2618 Use sprintf result rather than recomputing it.
2620 Clean out last vestiges of the old HAVE_CONFIG_H stuff.
2621 * Makefile.in (ALL_CFLAGS):
2622 * makefile.w32-in (LOCAL_FLAGS): Remove -DHAVE_CONFIG_H.
2623 * gmalloc.c, regex.c: Include <config.h> unconditionally.
2625 2012-06-25 Dmitry Antipov <dmantipov@yandex.ru>
2627 * dispextern.h (xstrcasecmp): Define to library function
2628 strcasecmp if available.
2629 * xfaces.c: Do not use xstrcasecmp if strcasecmp is available.
2631 2012-06-25 Andreas Schwab <schwab@linux-m68k.org>
2633 * keyboard.c (menu_bar_items, menu_bar_item, read_key_sequence):
2634 Avoid comma operator.
2635 * menu.c (push_submenu_start, push_submenu_end)
2636 (push_left_right_boundary, push_menu_pane): Likewise.
2637 * msdos.c (dos_rawgetc): Likewise.
2639 2012-06-25 Dmitry Antipov <dmantipov@yandex.ru>
2641 * xfns.c (xic_create_fontsetname): Remove redundant calls
2644 2012-06-25 Paul Eggert <eggert@cs.ucla.edu>
2646 * gtkutil.c (get_utf8_string): Remove redundant assignment.
2647 sprintf already null-terminates its output.
2649 * xfns.c (x_window): Remove redundant cast.
2651 2012-06-25 Dmitry Antipov <dmantipov@yandex.ru>
2653 * xmenu.c (xmenu_show, xdialog_show): Explicit cast from
2654 `const char *' to `char *' to avoid compiler warning.
2656 2012-06-24 Paul Eggert <eggert@cs.ucla.edu>
2658 * xterm.c (x_term_init): Build proper-sized _XSETTINGS_Snnn string
2659 instead of truncating it to 63 (admittedly a generous limit).
2661 * process.c: Fix spelling and caps in comments.
2663 2012-06-24 Dan Nicolaescu <dann@ics.uci.edu>
2665 * emacs.c (setpgrp): Remove definition, unused.
2666 * sysdep.c (setpgrp): Remove definition, not used in this file.
2668 2012-06-24 Juanma Barranquero <lekktu@gmail.com>
2670 * makefile.w32-in: Update dependencies.
2672 2012-06-24 Eli Zaretskii <eliz@gnu.org>
2674 * makefile.w32-in (TIMESPEC_H): Remove nt/inc/sys/time.h.
2675 (SYSTIME_H): Add nt/inc/sys/time.h.
2677 * systime.h [WINDOWSNT]: Include sys/time.h.
2679 * s/ms-w32.h (struct timespec): Definition moved from
2680 nt/inc/sys/time.h. Suggested by Paul Eggert <eggert@cs.ucla.edu>.
2682 2012-06-24 Paul Eggert <eggert@cs.ucla.edu>
2684 Switch from NO_RETURN to C11's _Noreturn (Bug#11750).
2685 * buffer.h (buffer_slot_type_mismatch):
2686 * data.c (arith_error) [!FORWARD_SIGNAL_TO_MAIN_THREAD]:
2687 * eval.c (unwind_to_catch):
2688 * image.c (my_png_error, my_error_exit):
2689 * keyboard.c (quit_throw_to_read_char, user_error)
2690 (Fexit_recursive_edit, Fabort_recursive_edit):
2691 * lisp.h (die, args_out_of_range, args_out_of_range_3)
2692 (wrong_type_argument, buffer_overflow, __executable_start)
2693 (memory_full, buffer_memory_full, string_overflow, Fthrow)
2694 (xsignal, xsignal0, xsignal1, xsignal2, xsignal3, signal_error)
2695 (error, verror, nsberror, report_file_error, Ftop_level, Fkill_emacs)
2697 (child_setup) [!DOS_NT]:
2698 * lread.c (end_of_file_error, invalid_syntax):
2699 * process.c (send_process_trap) [!FORWARD_SIGNAL_TO_MAIN_THREAD]:
2700 * puresize.h (pure_write_error):
2701 * search.c (matcher_overflow):
2702 * sound.c (sound_perror, alsa_sound_perror):
2703 * sysdep.c, syssignal.h (croak):
2704 * term.c (maybe_fatal, vfatal):
2705 * textprop.c (text_read_only):
2706 * undo.c (user_error):
2707 * unexmacosx.c (unexec_error):
2708 * xterm.c (x_ins_del_lines, x_delete_glyphs):
2709 Use _Noreturn rather than NO_RETURN.
2710 No need for separate decl merely because of _Noreturn.
2711 * sound.c (sound_warning, parse_sound):
2712 Remove unnecessary forward decls.
2714 2012-06-24 Paul Eggert <eggert@cs.ucla.edu>
2716 Fix bug when time_t is unsigned and as wide as intmax_t (Bug#9000).
2717 * lisp.h (WAIT_READING_MAX): New macro.
2718 * dispnew.c (Fsleep_for, sit_for):
2719 * keyboard.c (kbd_buffer_get_event):
2720 * process.c (Faccept_process_output):
2721 Use it to avoid bogus compiler warnings with obsolescent GCC versions.
2722 This improves on the previous patch, which introduced a bug
2723 when time_t is unsigned and as wide as intmax_t.
2724 See <http://bugs.gnu.org/9000#51>.
2726 2012-06-23 Eli Zaretskii <eliz@gnu.org>
2728 * dispnew.c (sit_for, Fsleep_for):
2729 * keyboard.c (kbd_buffer_get_event):
2730 * process.c (Faccept_process_output): Avoid compiler warnings when
2731 comparing a 32-bit time_t with a 64-bit INTMAX_MAX.
2733 2012-06-23 Juanma Barranquero <lekktu@gmail.com>
2735 * makefile.w32-in: Update dependencies.
2737 * w32.c (ltime): Add return type and declare static.
2738 (w32_get_internal_run_time): Remove usused variable `time_100ns'.
2740 2012-06-23 Paul Eggert <eggert@cs.ucla.edu>
2742 * sysdep.c [__FreeBSD__]: Fix more recently-introduced typos.
2743 Privately reported by Herbert J. Skuhra.
2744 (make_lisp_timeval) [__FreeBSD__]: Rename from TIMELIST.
2746 (system_process_attributes) [__FreeBSD__]: Invoke make_lisp_time,
2747 not make_lisp_timeval, when the argument is of type EMACS_TIME.
2749 2012-06-23 Eli Zaretskii <eliz@gnu.org>
2751 * w32proc.c (Fw32_get_locale_info): Fix an off-by-one error in
2752 last argument of make_unibyte_string.
2754 * keyboard.c (kbd_buffer_get_event): Include the codepage and the
2755 language ID in the event parameters.
2757 * w32term.c (w32_read_socket): Put the new keyboard codepage into
2758 event.code, not the obscure "character set ID".
2760 2012-06-23 Chong Yidong <cyd@gnu.org>
2762 * xmenu.c (x_menu_wait_for_event): Adapt GTK3 to new xg_select.
2764 2012-06-23 Eli Zaretskii <eliz@gnu.org>
2766 Fix the MS-Windows build broken by 2012-06-22T21:17:42Z!eggert@cs.ucla.edu.
2767 * w32.c (fdutimens): New function.
2769 * w32proc.c (sys_select): Adapt to change in the EMACS_TIME type.
2771 * s/ms-w32.h (pselect): Redirect to sys_select.
2773 * sysselect.h [WINDOWSNT]: Don't include sys/select.h.
2775 * ralloc.c (r_alloc_inhibit_buffer_relocation): Fix stupid thinko
2776 in the logic of incrementing and decrementing the value of
2777 use_relocatable_buffers.
2779 2012-06-23 Paul Eggert <eggert@cs.ucla.edu>
2781 * sysdep.c [__FreeBSD__]: Fix recently-introduced typos.
2782 Privately reported by Herbert J. Skuhra.
2783 [__FreeBSD__]: Remove "*/" typo after "#include".
2784 (timeval_to_EMACS_TIME) [__FreeBSD__]: New static function.
2785 (TIMEVAL) [__FreeBSD__]: Now a static function rather than a macro.
2786 (TIMEVAL, system_process_attributes) [__FreeBSD__]:
2787 Don't assume EMACS_TIME and struct timeval are the same type.
2789 2012-06-22 Paul Eggert <eggert@cs.ucla.edu>
2791 Support higher-resolution time stamps (Bug#9000).
2792 The time stamps are only nanosecond-resolution at the C level,
2793 since that's the best that any real-world system supports now.
2794 But they are picosecond-resolution at the Lisp level, as that's
2795 easy, and leaves room for future OS improvements.
2797 * Makefile.in (LIB_CLOCK_GETTIME): New macro.
2800 * alloc.c (Fgarbage_collect): Port to higher-res time stamps.
2801 Don't get current time unless it's needed.
2803 * atimer.c: Include <sys/time.h> unconditionally, since gnulib
2804 now provides it if it's absent.
2805 (start_atimer): Port to higher-res time stamps.
2806 Check for time stamp overflow. Don't get current time more
2807 often than is needed.
2809 * buffer.h (struct buffer): Buffer modtime now has high resolution.
2810 Include systime.h, not time.h.
2811 (NONEXISTENT_MODTIME_NSECS, UNKNOWN_MODTIME_NSECS): New macros.
2813 * dired.c: Include stat-time.h.
2814 (Ffile-attributes): File times now have higher resolution.
2816 * dispextern.h [HAVE_WINDOW_SYSTEM]: Include systime.h.
2817 (struct image): Timestamp now has higher resolution.
2819 * dispnew.c (PERIODIC_PREEMPTION_CHECKING): Remove, as Emacs always
2820 has at least microseconds now. All uses removed.
2821 (update_frame, update_single_window, update_window, update_frame_1)
2822 (Fsleep_for, sit_for): Port to higher-resolution time stamps.
2824 * editfns.c (time_overflow): Now extern.
2825 (Fcurrent_time, Fget_internal_run_time, make_time, lisp_time_argument)
2826 (float-time, Fformat_time_string, Fcurrent_time_string)
2827 (Fcurrent_time_zone): Accept and generate higher-resolution
2829 (make_time_tail, make_lisp_time, dissassemble_lisp_time)
2830 (decode_time_components, lisp_seconds_argument): New functions.
2831 (make_time): Now static.
2832 (lisp_time_argument): Now returns EMACS_TIME. New arg ppsec.
2833 Report an error if the time is invalid, rather than having the caller
2836 * fileio.c: Include <stat-time.h>
2837 (Fcopy_file): Copy higher-resolution time stamps.
2838 Prefer to set the time stamp via a file descriptor if that works.
2839 (Fset_file_times, Finsert_file_contents, Fwrite_region)
2840 (Fverify_visited_file_modtime, Fclear_visited_file_modtime)
2841 (Fvisited_file_modtime, Fset_visited_file_modtime):
2842 Support higher-resolution time stamps.
2844 * fns.c (Frandom): Use nanoseconds, not microseconds, for seed.
2846 * gtkutil.c (xg_maybe_add_timer): Port to higher-res time stamps.
2848 * image.c (prepare_image_for_display, clear_image_cache)
2849 (lookup_image): Port to higer-resolution time stamps.
2851 * keyboard.c (start_polling, bind_polling_period):
2852 Check for time stamp overflow.
2853 (read_char, kbd_buffer_get_event, timer_start_idle)
2854 (timer_stop_idle, timer_resume_idle, timer_check_2, timer_check)
2855 (Fcurrent_idle_time, init_keyboard, set_waiting_for_input):
2856 Port to higher-resolution time stamps. Do not assume time_t is signed.
2857 (decode_timer): New function. Timers are now vectors of length 9,
2858 not 8, to accommodate the picosecond component.
2859 (timer_check_2): Use it.
2861 * nsterm.m (select_timeout, timeval_subtract): Remove.
2862 (ns_timeout): Use Emacs's facilities for time stamp arithmetic,
2863 as they're a bit more accurate and handle overflow better.
2864 (ns_select): Change prototype to be compatible with pselect.
2865 (ns_select, ns_term_shutdown): Port to ns-resolution time stamps.
2866 * nsterm.h (ns_select): Adjust prototype.
2868 * msdos.c (EMACS_TIME_ZERO_OR_NEG_P): Remove, as it assumes
2869 us-resolution time stamps.
2870 (sys_select): Use the new EMACS_TIME_SIGN macro instead.
2872 * lread.c (read_filtered_event): Port to ns-resolution time stamps.
2874 * lisp.h (time_overflow): New decl.
2875 (wait_reading_process_output): First arg is now intmax_t, not int,
2876 to accommodate larger waits.
2878 * process.h (struct Lisp_Process.read_output_delay):
2879 Now counts nanoseconds, not microseconds.
2880 * process.c (ADAPTIVE_READ_BUFFERING): Don't worry about
2882 (READ_OUTPUT_DELAY_INCREMENT, Faccept_process_output)
2883 (wait_reading_process_output):
2884 Port to ns-resolution time stamps.
2885 (Faccept_process_output, wait_reading_process_output):
2886 Check for time stamp overflow. Do not assume time_t is signed.
2887 (select_wrapper): Remove; we now use pselect.
2888 (Fprocess_attributes): Now generates ns-resolution time stamps.
2890 * sysdep.c: Include utimens.h. Don't include utime.h
2891 or worry about struct utimbuf; gnulib does that for us now.
2892 (gettimeofday): Remove; gnulib provides a substitute.
2893 (make_timeval): New function.
2894 (set_file_times): Now sets ns-resolution time stamps.
2895 New arg FD; all uses changed.
2896 (time_from_jiffies, ltime_from_jiffies, get_up_time)
2897 (system_process_attributes):
2898 Now returns ns-resolution time stamp. All uses changed.
2899 Check for time stamp overflow.
2901 * sysselect.h: Don't depend on HAVE_SYS_SELECT_H; gnulib
2902 provides a substitute now.
2904 * systime.h: Include timespec.h rather than sys/time.h and time.h,
2905 since it guarantees struct timespec.
2906 (EMACS_TIME): Now struct timespec, so that we can support
2907 ns-resolution time stamps.
2908 (EMACS_TIME_RESOLUTION, LOG10_EMACS_TIME_RESOLUTION): New macros.
2909 (EMACS_HAS_USECS): Remove; Emacs always has sub-second time stamps now.
2910 (EMACS_USECS): Remove.
2911 (EMACS_SET_USECS): The underlying time stamp now has ns resolution,
2912 so multiply the arg by 1000 before storing it.
2913 (EMACS_NSECS, EMACS_SECS_ADDR, EMACS_SET_NSECS, EMACS_SET_SECS_NSECS):
2915 (EMACS_GET_TIME, EMACS_ADD_TIME, EMACS_SUB_TIME):
2916 Port to ns-resolution time stamps.
2917 (EMACS_TIME_NEG_P): Remove; replaced by....
2918 (EMACS_TIME_SIGN): New macro.
2919 (EMACS_SET_INVALID_TIME, EMACS_TIME_VALID_P)
2920 (EMACS_TIME_FROM_DOUBLE, EMACS_TIME_TO_DOUBLE): New macros.
2921 (set_file_times, make_time, lisp_time_argument): Adjust signature.
2922 (make_timeval, make_lisp_time, decode_time_components): New decls.
2923 (EMACS_TIME_CMP): Remove; no longer used. Plus, it was buggy, in
2924 that it mishandled time_t overflow. You can't compare by subtracting!
2925 (EMACS_TIME_EQ, EMACS_TIME_NE, EMACS_TIME_GT, EMACS_TIME_GE)
2926 (EMACS_TIME_LT, EMACS_TIME_LE): Rewrite in terms of timespec_cmp.
2928 * term.c: Include <sys/time.h>.
2929 (timeval_to_Time): New function, for proper overflow wraparound.
2930 (term_mouse_position, term_mouse_click): Use it.
2932 * undo.c (record_first_change): Support higher-resolution time stamps
2934 (Fprimitive_undo): Use them when restoring time stamps.
2936 * w32.c (ltime, U64_TO_LISP_TIME, process_times, emacs_gnutls_pull)
2937 (w32_get_internal_run_time):
2938 Port to higher-resolution Emacs time stamps.
2939 (ltime): Now accepts single 64-bit integer, as that's more convenient
2942 * xdisp.c (start_hourglass): Port to ns-resolution time stamps.
2944 * xgselect.c, xgselect.h (xg_select): Add sigmask argument,
2945 for compatibility with pselect. Support ns-resolution time stamps.
2947 * xmenu.c (x_menu_wait_for_event): Support ns-resolution time stamps.
2949 * xselect.c (wait_for_property_change, x_get_foreign_selection):
2950 Check for time stamp overflow, and support ns-resolution time stamps.
2952 * xterm.c: Don't include sys/time.h; gnulib does that for us now.
2953 Don't worry about whether HAVE_TIMEVAL and HAVE_SELECT are set.
2954 (timeval_subtract): Remove; no longer needed.
2955 (XTflash, XTring_bell, x_wait_for_event):
2956 Port to ns-resolution time stamps. Don't assume time_t is signed.
2958 2012-06-22 Chong Yidong <cyd@gnu.org>
2960 * xdisp.c (x_consider_frame_title): Revert last change.
2962 2012-06-22 Eli Zaretskii <eliz@gnu.org>
2964 * alloc.c (NSTATICS): Enlarge to 0x650. Otherwise, Emacs compiled
2965 with -DENABLE_CHECKING -DXASSERTS -DGLYPH_DEBUG=1 -DBYTE_CODE_METER
2966 aborts in staticpro during startup. (Without -DBYTE_CODE_METER,
2967 staticidx goes up to 1597 out of 1600 = 0x640.)
2969 2012-06-20 Paul Eggert <eggert@cs.ucla.edu>
2971 * fileio.c (Fdefault_file_modes): Block input while fiddling with umask.
2972 Otherwise, the umask might be mistakenly 0 while handling input signals.
2974 2012-06-19 Stefan Monnier <monnier@iro.umontreal.ca>
2976 * minibuf.c (Fread_string): Bind minibuffer-completion-table.
2978 2012-06-19 Dmitry Antipov <dmantipov@yandex.ru>
2980 * alloc.c, bytecode.c, ccl.c, coding.c, composite.c, data.c, dosfns.c:
2981 * font.c, image.c, keyboard.c, lread.c, menu.c, minibuf.c, msdos.c:
2982 * print.c, syntax.c, window.c, xmenu.c, xselect.c: Replace direct
2983 access to `contents' member of Lisp_Vector objects with AREF and ASET
2986 2012-06-19 Chong Yidong <cyd@gnu.org>
2988 * frame.c (delete_frame): When selecting a frame on a different
2989 text terminal, do not alter the terminal's top-frame.
2991 * xdisp.c (format_mode_line_unwind_data): Record the target
2992 frame's selected window and its terminal's top-frame.
2993 (unwind_format_mode_line): Restore them.
2994 (x_consider_frame_title, display_mode_line, Fformat_mode_line):
2996 (x_consider_frame_title): Do not condition on HAVE_WINDOW_SYSTEM,
2997 since tty frames can be explicitly named.
2998 (prepare_menu_bars): Likewise.
3000 * term.c (Ftty_top_frame): New function.
3002 2012-06-18 Paul Eggert <eggert@cs.ucla.edu>
3004 Port byte-code-meter to modern targets.
3005 * bytecode.c (METER_CODE) [BYTE_CODE_METER]: Don't assume
3006 !CHECK_LISP_OBJECT_TYPE && !USE_LSB_TAG. Problem with
3007 CHECK_LISP_OBJECT_TYPE reported by Dmitry Antipov in
3008 <http://lists.gnu.org/archive/html/emacs-devel/2012-06/msg00282.html>.
3009 (METER_1, METER_2): Simplify.
3011 2012-06-18 Stefan Monnier <monnier@iro.umontreal.ca>
3013 * data.c (Fdefalias): Return `symbol' (bug#11686).
3015 2012-06-18 Martin Rudalics <rudalics@gmx.at>
3017 * buffer.c (Fkill_buffer): Don't throw an error when the buffer
3018 gets killed during executing of this function (Bug#11665).
3019 Try to always return Qt when the buffer has been actually killed.
3020 (Vkill_buffer_query_functions): In doc-string say that functions
3021 run by this hook should not change the current buffer.
3023 2012-06-18 Paul Eggert <eggert@cs.ucla.edu>
3025 Fix recently-introduced process.c problems found by static checking.
3026 * process.c (write_queue_push, write_queue_pop, send_process):
3027 Use ptrdiff_t, not int or EMACS_INT, for buffer lengths and offsets.
3028 (write_queue_pop): Fix pointer signedness problem.
3029 (send_process): Remove unused local.
3031 2012-06-17 Chong Yidong <cyd@gnu.org>
3033 * xdisp.c (redisplay_internal): No need to redisplay terminal
3034 frames that are not on top.
3036 2012-06-17 Troels Nielsen <bn.troels@gmail.com>
3038 * process.c (make_process): Initialize write_queue.
3039 (write_queue_push, write_queue_pop): New functions.
3040 (send_process): Use them to maintain correct ordering of process
3043 2012-06-17 Paul Eggert <eggert@cs.ucla.edu>
3045 * lisp.h (eassert): Assume C89 or later.
3046 This removes the need for CHECK.
3047 (CHECK): Remove. Its comments about always evaluating its
3048 argument were confusing, as 'eassert' typically does not evaluate
3051 * coding.c (produce_chars): Use ptrdiff_t, not int.
3053 * xterm.c (x_draw_underwave): Check for integer overflow.
3054 This pacifies gcc 4.7.0 -Wunsafe-loop-optimizations on x86-64.
3056 2012-06-17 Jan Djärv <jan.h.d@swipnet.se>
3058 * nsterm.m (x_free_frame_resources): Move xfree so freed memory isn't
3059 referenced (Bug#11583).
3061 2012-06-16 Aurelien Aptel <aurelien.aptel@gmail.com>
3063 Implement wave-style variant of underlining.
3064 * dispextern.h (face_underline_type): New enum.
3065 (face): Add field for underline type.
3066 * nsterm.m (ns_draw_underwave): New function.
3067 (ns_draw_text_decoration): Use it.
3068 * w32term.c (w32_restore_glyph_string_clip, w32_draw_underwave):
3070 (x_draw_glyph_string): Use them.
3071 * xfaces.c (Qline, Qwave): New Lisp objects.
3072 (check_lface_attrs, merge_face_ref)
3073 (Finternal_set_lisp_face_attribute, realize_x_face):
3074 Handle wave-style underline face attributes.
3075 * xterm.c (x_draw_underwave): New function.
3076 (x_draw_glyph_string): Use it.
3078 2012-06-16 Juanma Barranquero <lekktu@gmail.com>
3080 * makefile.w32-in ($(BLD)/emacs.$(O), $(BLD)/fringe.$(O))
3081 ($(BLD)/xml.$(O), $(BLD)/intervals.$(O), $(BLD)/macros.$(O))
3082 ($(BLD)/minibuf.$(O), $(BLD)/regex.$(O), $(BLD)/region-cache.$(O))
3083 ($(BLD)/textprop.$(O), $(BLD)/undo.$(O), $(BLD)/window.$(O))
3084 ($(BLD)/w32select.$(O)): Update dependencies.
3086 2012-06-16 Andreas Schwab <schwab@linux-m68k.org>
3088 * buffer.h (FETCH_MULTIBYTE_CHAR): Define as inline.
3089 (BUF_FETCH_MULTIBYTE_CHAR): Likewise.
3090 * character.c (_fetch_multibyte_char_p): Remove.
3091 * alloc.c: Include "character.h" before "buffer.h".
3093 * buffer.c: Likewise.
3094 * bytecode.c: Likewise.
3095 * callint.c: Likewise.
3096 * callproc.c: Likewise.
3097 * casefiddle.c: Likewise.
3098 * casetab.c: Likewise.
3099 * category.c: Likewise.
3101 * coding.c: Likewise.
3102 * composite.c: Likewise.
3103 * dired.c: Likewise.
3104 * dispnew.c: Likewise.
3106 * dosfns.c: Likewise.
3107 * editfns.c: Likewise.
3108 * emacs.c: Likewise.
3109 * fileio.c: Likewise.
3110 * filelock.c: Likewise.
3112 * fontset.c: Likewise.
3113 * fringe.c: Likewise.
3114 * indent.c: Likewise.
3115 * insdel.c: Likewise.
3116 * intervals.c: Likewise.
3117 * keyboard.c: Likewise.
3118 * keymap.c: Likewise.
3119 * lread.c: Likewise.
3120 * macros.c: Likewise.
3121 * marker.c: Likewise.
3122 * minibuf.c: Likewise.
3123 * nsfns.m: Likewise.
3124 * nsmenu.m: Likewise.
3125 * print.c: Likewise.
3126 * process.c: Likewise.
3127 * regex.c: Likewise.
3128 * region-cache.c: Likewise.
3129 * search.c: Likewise.
3130 * syntax.c: Likewise.
3132 * textprop.c: Likewise.
3134 * unexsol.c: Likewise.
3135 * w16select.c: Likewise.
3136 * w32fns.c: Likewise.
3137 * w32menu.c: Likewise.
3138 * window.c: Likewise.
3139 * xdisp.c: Likewise.
3141 * xmenu.c: Likewise.
3143 * xselect.c: Likewise.
3145 2012-06-16 Eli Zaretskii <eliz@gnu.org>
3147 * xdisp.c (set_cursor_from_row): Don't dereference glyphs_end.
3148 If all the glyphs of the glyph row came from strings, and we have no
3149 cursor positioning clues, put the cursor on the first glyph of the
3151 (handle_face_prop): Use chunk-relative overlay string index when
3152 indexing into it->string_overlays array. (Bug#11653)
3153 (set_cursor_from_row): Use the leftmost glyph as GLYPH_BEFORE, not
3154 the rightmost. (Bug#11720)
3156 2012-06-16 Andreas Schwab <schwab@linux-m68k.org>
3158 * category.h (CHAR_HAS_CATEGORY): Define as inline.
3159 (CATEGORY_MEMBER): Enforce 1/0 value.
3160 * category.c (_temp_category_set): Remove.
3162 2012-06-16 Eli Zaretskii <eliz@gnu.org>
3164 * window.c (Fdelete_other_windows_internal)
3165 (Fdelete_window_internal): Don't access frame's mouse highlight
3166 info of the initial frame. (Bug#11677)
3168 2012-06-14 Paul Eggert <eggert@cs.ucla.edu>
3170 * .gdbinit (xgetint): Fix recently-introduced paren typo.
3171 Assume USE_2_TAGS_FOR_INTS.
3172 (xreload): Adjust $tagmask width to match recent lisp.h change.
3174 Simplify lisp.h in minor ways that should not affect code.
3175 * lisp.h (USE_2_TAGS_FOR_INTS): Remove, as it was always defined.
3176 (LISP_INT_TAG, case_Lisp_Int, LISP_STRING_TAG, LISP_INT_TAG_P)
3177 (LISP_INT1_TAG, enum Lisp_Type, XINT, XUINT, make_number):
3178 Simplify under the assumption that USE_2_TAGS_FOR_INTS is defined.
3179 (INTTYPEBITS): New macro, for clarity.
3180 (INTMASK, MOST_POSITIVE_FIXNUM): Use it.
3181 (LISP_INT1_TAG, LISP_STRING_TAG, LISP_INT_TAG_P):
3182 Simplify now that USE_LSB_TAG is always defined.
3183 (TYPEMASK, XINT) [USE_LSB_TAG]: Remove unnecessary cast.
3184 (make_number) [!USE_LSB_TAG]: Use INTMASK; that's simpler.
3186 2012-06-13 Juanma Barranquero <lekktu@gmail.com>
3188 * makefile.w32-in ($(BLD)/data.$(O)): Update dependencies.
3190 2012-06-13 Glenn Morris <rgm@gnu.org>
3192 * s/bsd-common.h (BSD4_3):
3193 * s/usg5-4-common.h (USG5_4): No longer define; unused.
3195 2012-06-13 Andreas Schwab <schwab@linux-m68k.org>
3197 * lisp.h (Lisp_Object) [CHECK_LISP_OBJECT_TYPE]: Define as struct
3200 (XHASH, XTYPE, XINT, XUINT, make_number, XSET, XPNTR, XUNTAG):
3202 * emacs.c (gdb_use_struct): Rename from gdb_use_union.
3203 * .gdbinit: Check gdb_use_struct instead of gdb_use_union.
3204 * alloc.c (widen_to_Lisp_Object): Remove.
3205 (mark_memory): Use XIL instead of widen_to_Lisp_Object.
3206 * frame.c (delete_frame): Remove outdated comment.
3207 * w32fns.c (Fw32_register_hot_key): Use XLI instead of checking
3208 USE_LISP_UNION_TYPE.
3209 (Fw32_unregister_hot_key): Likewise.
3210 (Fw32_toggle_lock_key): Likewise.
3211 * w32menu.c (add_menu_item): Likewise.
3212 (w32_menu_display_help): Use XIL instead of checking
3213 USE_LISP_UNION_TYPE.
3214 * w32heap.c (allocate_heap): Don't check USE_LISP_UNION_TYPE.
3215 (init_heap): Likewise.
3216 * w32term.c (w32_read_socket): Update comment.
3218 2012-06-13 Glenn Morris <rgm@gnu.org>
3220 * s/usg5-4-common.h, src/s/unixware.h:
3221 Remove define/undef of HAVE_SYSV_SIGPAUSE (not used since 2010-05-04).
3223 * s/gnu.h (POSIX_SIGNALS): Remove (not used since 2010-05-04).
3225 2012-06-13 Paul Eggert <eggert@cs.ucla.edu>
3227 USE_LISP_UNION_TYPE + USE_LSB_TAG cleanup (Bug#11604)
3228 * alloc.c (make_number) [!defined make_number]:
3229 Remove, as lisp.h always defines this now.
3230 (mark_maybe_pointer): Simplify since USE_LSB_TAG is always defined now.
3231 (roundup_size): Verify that it is a power of 2.
3232 * data.c (Fmake_variable_buffer_local, Fmake_local_variable):
3233 * ftfont.c (ftfont_driver): Use LISP_INITIALLY_ZERO.
3234 * lisp.h (USE_LSB_TAG): Allow the builder to compile with
3235 -DUSE_LSB_TAG=0, to override the automatically-selected default.
3236 USE_LSB_TAG now is always defined to be either 0 or 1.
3238 (union Lisp_Object): Don't worry about WORDS_BIGENDIAN; the
3239 code works fine either way, and efficiency is not a concern here,
3240 as the union type is for debugging, not for production.
3241 (LISP_MAKE_RVALUE, make_number) [USE_LISP_UNION_TYPE]:
3242 Use an inline function on all platforms when using the union type,
3243 since this is simpler and 'static inline' can be used portably
3245 (LISP_INITIALLY_ZERO): New macro.
3246 (XFASTINT, XSETFASTINT) [USE_LISP_UNION_TYPE]: Remove.
3247 (XSET) [USE_LISP_UNION_TYPE]: Don't overparenthesize.
3249 2012-06-12 Glenn Morris <rgm@gnu.org>
3251 * s/gnu-kfreebsd.h, s/hpux11.h, s/openbsd.h, s/sol2-10.h: Remove files.
3253 * s/gnu-linux.h (HAVE_PROCFS): Move to configure.
3255 * s/hpux10-20.h, s/openbsd.h, s/usg5-4-common.h:
3256 Move BROKEN_SIGIO to configure.
3258 * s/bsd-common.h, s/darwin.h, s/gnu-kfreebsd.h, s/hpux10-20.h:
3259 Move NO_TERMIO to configure.
3261 2012-06-12 Chong Yidong <cyd@gnu.org>
3263 * image.c (imagemagick_load_image): Use MagickFlattenImage if
3264 MagickMergeImageLayers is undefined. Use pixel pusher loop if
3265 MagickExportImagePixels is undefined.
3267 2012-06-12 Paul Eggert <eggert@cs.ucla.edu>
3269 * image.c (imagemagick_load_image): Remove unused label.
3271 2012-06-11 Glenn Morris <rgm@gnu.org>
3273 * s/aix4-2.h, s/bsd-common.h, s/cygwin.h, s/darwin.h:
3274 * s/gnu-kfreebsd.h, s/gnu-linux.h, s/gnu.h, s/hpux10-20.h:
3275 * s/irix6-5.h, s/ms-w32.h, s/msdos.h, s/template.h:
3276 * s/usg5-4-common.h: Move SYSTEM_TYPE to configure.
3278 2012-06-11 Stefan Monnier <monnier@iro.umontreal.ca>
3280 * alloc.c (make_byte_code): New function.
3281 (Fmake_byte_code): Use it. Don't purify here.
3282 * lread.c (read1): Use it as well to avoid extra allocation.
3284 2012-06-11 Chong Yidong <cyd@gnu.org>
3286 * image.c (imagemagick_load_image): Implement transparency.
3288 2012-06-10 Andreas Schwab <schwab@linux-m68k.org>
3290 * regex.c (at_begline_loc_p): Also recognize `(?N:' and correctly
3291 account for preceding backslashes. (Bug#11663)
3293 2012-06-09 Chong Yidong <cyd@gnu.org>
3295 * term.c: Support italics in capable terminals (Bug#9652).
3296 (no_color_bit): Replace unused NC_BLINK with NC_ITALIC.
3297 (turn_on_face): Output using TS_enter_italic_mode if available.
3298 Don't handle unused blinking and alt-charset cases.
3299 (turn_off_face): Handle italic case; discard unused tty_blinking_p
3300 and tty_alt_charset_p cases.
3301 (tty_capable_p, init_tty): Support italics.
3303 * termchar.h (struct tty_display_info): Add field for italics.
3304 Remove unused blink field.
3306 * xfaces.c (tty_supports_face_attributes_p, realize_tty_face):
3309 * dispextern.h: Replace unused TTY_CAP_BLINK with TTY_CAP_ITALIC.
3310 (struct face): Remove unused fields tty_dim_p, tty_blinking_p, and
3311 tty_alt_charset_p. Add tty_italic_p.
3313 2012-06-09 Michael Albinus <michael.albinus@gmx.de>
3315 * dbusbind.c (XD_BASIC_DBUS_TYPE): Use dbus_type_is_valid and
3316 dbus_type_is_basic if available.
3317 (xd_extract_signed, xd_extract_unsigned): Rename from
3318 extract_signed and extract_unsigned, respectively. Adapt callers.
3320 2012-06-09 Chong Yidong <cyd@gnu.org>
3322 * xfaces.c (face_for_overlay_string): Handle face remapping (Bug#2066).
3324 * fringe.c (Fset_fringe_bitmap_face): Handle the noninteractive
3327 2012-06-08 Paul Eggert <eggert@cs.ucla.edu>
3329 * xdisp.c (vmessage): Treat frame message as multibyte.
3330 Without this change, (let ((§ 1)) (make-variable-buffer-local '§))
3331 would generate the diagnostic "Making \302\247 buffer-local while
3334 2012-06-08 Eli Zaretskii <eliz@gnu.org>
3336 * dispnew.c (showing_window_margins_p): Undo last change, which
3337 was done due to an inadvertent commit.
3338 (adjust_frame_glyphs_for_frame_redisplay): Do call
3339 showing_window_margins_p.
3341 2012-06-08 Stefan Monnier <monnier@iro.umontreal.ca>
3343 * eval.c (Fmake_var_non_special): New primitive.
3344 (syms_of_eval): Defsubr it.
3345 * lread.c (syms_of_lread): Mark `values' as lexically scoped.
3347 2012-06-08 Juanma Barranquero <lekktu@gmail.com>
3349 * dispnew.c (showing_window_margins_p): Wrap in #if 0 to prevent unused
3350 function warning (the only call is inside #if 0 since 2012-06-08T08:44:45Z!eliz@gnu.org).
3352 2012-06-08 Eli Zaretskii <eliz@gnu.org>
3354 * alloc.c (allocate_vectorlike): Fix last change.
3356 2012-06-08 Dmitry Antipov <dmantipov@yandex.ru>
3358 Block-based vector allocation of small vectors.
3359 * lisp.h (struct vectorlike_header): New field `nbytes',
3360 adjust comment accordingly.
3361 * alloc.c (enum mem_type): New type `MEM_TYPE_VECTOR_BLOCK'
3362 to denote vector blocks. Adjust users (live_vector_p,
3363 mark_maybe_pointer, valid_lisp_object_p) accordingly.
3364 (COMMON_MULTIPLE): Move outside #if USE_LSB_TAG.
3365 (VECTOR_BLOCK_SIZE, vroundup, VECTOR_BLOCK_BYTES),
3366 (VBLOCK_BYTES_MIN, VBLOCK_BYTES_MAX, VECTOR_MAX_FREE_LIST_INDEX),
3367 (VECTOR_FREE_LIST_FLAG, ADVANCE, VINDEX, SETUP_ON_FREE_LIST),
3368 (VECTOR_SIZE, VECTOR_IN_BLOCK): New macros.
3369 (roundup_size): New constant.
3370 (struct vector_block): New data type.
3371 (vector_blocks, vector_free_lists, zero_vector): New variables.
3372 (all_vectors): Rename to `large_vectors'.
3373 (allocate_vector_from_block, init_vectors, allocate_vector_from_block)
3374 (sweep_vectors): New functions.
3375 (allocate_vectorlike): Return `zero_vector' as the only vector of
3376 0 items. Allocate new vector from block if vector size is less than
3377 or equal to VBLOCK_BYTES_MAX.
3378 (Fgarbage_collect): Move all vector sweeping code to sweep_vectors.
3379 (init_alloc_once): Add call to init_vectors.
3381 2012-06-08 Stefan Monnier <monnier@iro.umontreal.ca>
3383 * eval.c (Fmacroexpand): Stop if the macro returns the same form.
3385 2012-06-07 Paul Eggert <eggert@cs.ucla.edu>
3387 * doprnt.c (doprnt): Truncate multibyte char correctly.
3388 Without this change, doprnt (buf, 2, "%s", FORMAT_END, AP)
3389 would mishandle a string argument "Xc" if X was a multibyte
3390 character of length 2: it would truncate after X's first byte
3391 rather than including all of X.
3393 2012-06-06 Chong Yidong <cyd@gnu.org>
3395 * buffer.c (word_wrap): Doc fix.
3397 2012-06-04 Paul Eggert <eggert@cs.ucla.edu>
3399 * xdisp.c (note_mode_line_or_margin_highlight): Pacify gcc -Wall.
3401 2012-06-03 Glenn Morris <rgm@gnu.org>
3403 * xdisp.c (tool-bar-style): Doc fix.
3405 2012-06-03 Ulrich Müller <ulm@gentoo.org>
3407 * Makefile.in (PAXCTL): Define.
3408 (temacs$(EXEEXT)): Disable memory randomization for the temacs
3409 binary via PaX flags if the paxctl utility is available.
3410 (emacs$(EXEEXT), bootstrap-emacs$(EXEEXT)):
3411 Restore PaX flags to their default. (Bug#11398)
3413 2012-06-03 Chong Yidong <cyd@gnu.org>
3415 * xdisp.c (decode_mode_spec_coding): Display a space for a unibyte
3418 2012-06-03 Chong Yidong <cyd@gnu.org>
3420 * xdisp.c (calc_pixel_width_or_height): Use Fbuffer_local_value.
3421 (note_mode_line_or_margin_highlight): If there is no help echo,
3422 use mode-line-default-help-echo. Handle the case where the mouse
3423 position is past the end of the mode line string.
3425 * buffer.c (buffer_local_value_1): New function, split from
3426 Fbuffer_local_value; can return Qunbound.
3427 (Fbuffer_local_value): Use it.
3428 (Vmode_line_format): Docstring tweaks.
3430 2012-06-02 Paul Eggert <eggert@cs.ucla.edu>
3432 * sysdep.c (system_process_attributes): Improve comment.
3434 2012-06-02 Stefan Monnier <monnier@iro.umontreal.ca>
3436 * keyboard.c: Export real-this-command to Elisp.
3437 (syms_of_keyboard): Rename real_this_command to Vreal_this_command
3438 and DEFVAR it. Update all users.
3440 2012-06-02 Paul Eggert <eggert@cs.ucla.edu>
3442 * minibuf.c (Fassoc_string): Remove duplicate declaration.
3444 * sysdep.c (system_process_attributes) [SOLARIS2 && HAVE_PROCFS]:
3445 Convert pctcpu and pctmem to Lisp float properly.
3446 Let the compiler fold better, as 100.0/0x8000 is exact.
3448 2012-06-02 Andreas Schwab <schwab@linux-m68k.org>
3450 * alloc.c (CONS_BLOCK_SIZE): Account for padding at the end of
3453 2012-06-01 Paul Eggert <eggert@cs.ucla.edu>
3455 * xfns.c (x_set_tool_bar_lines) [USE_GTK]: Adjust to bitfield change.
3457 2012-06-01 Dmitry Antipov <dmantipov@yandex.ru>
3459 For a 'struct window', replace some Lisp_Object fields to
3460 bitfields where appropriate, remove unused fields.
3461 * window.h (struct window): Remove unused 'last_mark_x' and
3462 'last_mark_y' fields. Rename 'mini_p' field to 'mini',
3463 change it's type from Lisp_Object to bitfield.
3464 Change type of 'force_start', 'optional_new_start',
3465 'last_had_star', 'update_mode_line' and 'start_at_line_beg'
3466 fields from Lisp_Object to bitfield. Adjust users accordingly.
3468 2012-05-31 Paul Eggert <eggert@cs.ucla.edu>
3470 Pacify gcc -Wdouble-precision when using Xaw.
3471 * xterm.c (xaw_jump_callback, x_set_toolkit_scroll_bar_thumb)
3472 [HAVE_X_WINDOWS && USE_TOOLKIT_SCROLL_BARS && !USE_MOTIF && !USE_GTK]:
3473 Use 'float' consistently, rather than 'float' in most places
3474 and 'double' in a couple of places.
3476 2012-05-31 Eli Zaretskii <eliz@gnu.org>
3478 * xdisp.c (handle_stop): Detect whether we have overlay strings
3479 loaded by testing it->current.overlay_string_index to be
3480 non-negative, instead of checking whether n_overlay_strings is
3481 positive. (Bug#11587)
3483 2012-05-31 Chong Yidong <cyd@gnu.org>
3485 * keymap.c (describe_map_tree): Revert 2011-07-07 change (Bug#1169).
3487 * doc.c (Fsubstitute_command_keys): Doc fix.
3489 2012-05-31 Eli Zaretskii <eliz@gnu.org>
3491 * search.c (search_buffer): Remove calls to
3492 r_alloc_inhibit_buffer_relocation, as it is now called by
3493 maybe_unify_char, which was the cause of relocation of buffer text
3496 2012-05-31 Eli Zaretskii <eliz@gnu.org>
3498 * charset.c (maybe_unify_char): Inhibit relocation of buffer text
3499 for the duration of call to load_charset, to avoid problems with
3500 callers of maybe_unify_char that access buffer text through C
3503 * ralloc.c (r_alloc_inhibit_buffer_relocation): Increment and
3504 decrement the inhibition flag, instead of just setting or
3507 2012-05-31 Paul Eggert <eggert@cs.ucla.edu>
3509 Remove obsolete '#define static' cruft.
3510 * s/hpux10-20.h (_FILE_OFFSET_BITS): Don't #undef.
3511 This #undef was "temporary" in 2000; it is no longer needed
3512 now that '#define static' has gone away.
3513 * xfns.c, xterm.h (gray_bitmap_width, gray_bitmap_height)
3514 (gray_bitmap_bits): Remove; no longer needed.
3515 All uses replaced with definiens.
3516 * xterm.c: Include "bitmaps/gray.xbm".
3518 2012-05-30 Paul Eggert <eggert@cs.ucla.edu>
3520 Clean up __executable_start, monstartup when --enable-profiling.
3521 The following changes affect the code only when profiling.
3522 * dispnew.c (__executable_start): Rename from safe_bcopy.
3523 Define only on platforms that need it.
3524 * emacs.c: Include <sys/gmon.h> when profiling.
3525 (_mcleanup): Remove decl, since <sys/gmon.h> does it now.
3526 (__executable_start): Remove decl, since lisp.h does it now.
3527 (safe_bcopy): Remove decl; no longer has that name.
3528 (main): Coalesce #if into single bit of code, for simplicity.
3529 Cast pointers to uintptr_t, since standard libraries want integers
3531 * lisp.h (__executable_start): New decl.
3533 2012-05-31 Glenn Morris <rgm@gnu.org>
3535 * image.c (Fimagemagick_types): Doc fix.
3537 2012-05-30 Jim Meyering <meyering@redhat.com>
3539 * callproc.c (Fcall_process_region): Include directory component
3540 in mkstemp error message (Bug#11586).
3542 2012-05-30 Paul Eggert <eggert@cs.ucla.edu>
3544 * alloc.c, lisp.h (make_pure_vector): Now static.
3546 2012-05-30 Stefan Monnier <monnier@iro.umontreal.ca>
3548 * eval.c (Fdefun, Fdefmacro, Vmacro_declaration_function):
3549 Move to byte-run.el.
3550 (Fautoload): Do the hash-doc more carefully.
3551 * data.c (Fdefalias): Purify definition, except for keymaps.
3552 (Qdefun): Move from eval.c.
3553 * lisp.h (Qdefun): Remove.
3554 * lread.c (read1): Tiny simplification.
3556 2012-05-29 Troels Nielsen <bn.troels@gmail.com>
3558 Do not create empty overlays with the evaporate property (Bug#9642).
3559 * buffer.c (Fmove_overlay): Reinstate the earlier fix for
3560 Bug#9642, but explicitly check that the buffer the overlay would
3561 be moved to is live and rearrange lines to make sure that errors
3562 will not put the overlay in an inconsistent state.
3563 (Fdelete_overlay): Cosmetics.
3565 2012-05-28 Eli Zaretskii <eliz@gnu.org>
3567 * w32term.c (my_bring_window_to_top): New function.
3568 (x_raise_frame): Use handle returned by DeferWindowPos, which
3569 could be different from the original one.
3570 Call my_bring_window_to_top instead of my_set_foreground_window.
3573 * w32fns.c (w32_wnd_proc): Accept and process WM_EMACS_BRINGTOTOP
3574 by calling BringWindowToTop.
3576 * w32term.h (WM_EMACS_BRINGTOTOP): New message.
3577 (WM_EMACS_END): Increase by one.
3579 2012-05-28 Paul Eggert <eggert@cs.ucla.edu>
3581 * bidi.c (bidi_mirror_char): Put eassert before conversion to int.
3582 This avoids undefined behavior that might cause the eassert
3583 to not catch an out-of-range value.
3585 2012-05-28 Juanma Barranquero <lekktu@gmail.com>
3587 * makefile.w32-in ($(BLD)/w32inevt.$(O), $(BLD)/w32console.$(O)):
3588 Update dependencies.
3590 2012-05-27 Eli Zaretskii <eliz@gnu.org>
3592 * bidi.c (bidi_mirror_char): Fix last change.
3594 2012-05-27 Andreas Schwab <schwab@linux-m68k.org>
3596 * unexmacosx.c (copy_data_segment): Truncate after 16 characters
3597 when referring to sectname field in printf format.
3599 2012-05-27 Paul Eggert <eggert@cs.ucla.edu>
3601 * lisp.h [REL_ALLOC]: Omit duplicate prototypes.
3602 Only r_alloc_inhibit_buffer_relocation needed to be added;
3603 the others were already declared.
3605 * bidi.c (bidi_mirror_char): Don't possibly truncate the integer
3606 before checking whether it's out of range. Put the check inside
3608 <http://lists.gnu.org/archive/html/emacs-devel/2012-05/msg00485.html>.
3610 2012-05-27 Ken Brown <kbrown@cornell.edu>
3612 * callproc.c (Fcall_process): Restore a line that was accidentally
3613 commented out in the 2011-02-13 change (bug#11547).
3615 2012-05-27 Eli Zaretskii <eliz@gnu.org>
3617 * lisp.h [REL_ALLOC]: Add prototypes for external functions
3618 defined on ralloc.c.
3620 * buffer.c [REL_ALLOC]: Remove prototypes of
3621 r_alloc_reset_variable, r_alloc, r_re_alloc, and r_alloc_free,
3622 they are now on lisp.h.
3624 * ralloc.c (r_alloc_inhibit_buffer_relocation): New function.
3626 * search.c (search_buffer): Use it to inhibit relocation of buffer
3627 text while re_search_2 is doing its job, because re_search_2 is
3628 passed C pointers to buffer text. (Bug#11519)
3630 * msdos.c (internal_terminal_init) <Vwindow_system_version>:
3633 * xdisp.c (move_it_to): Under MOVE_TO_Y, when restoring iterator
3634 state after an additional call to move_it_in_display_line_to, keep
3635 the values of it->max_ascent and it->max_descent found for the
3637 (pos_visible_p): Revert the comparison against bottom_y to what it
3638 was in revid eliz@gnu.org-20120513182235-4p6386j761ld0nwb.
3641 2012-05-26 Paul Eggert <eggert@cs.ucla.edu>
3643 Fix coding-related core dumps with gcc -ftrapv.
3644 The code was computing A - B, where A and B are pointers, and B is
3645 random garbage. This can lead to core dumps on platforms that
3646 have special pointer registers, and it also leads to core dumps on
3647 x86-64 when compiled with gcc -ftrapv. The fix is to compute
3648 A - B only when B is initialized properly.
3649 * coding.c (coding_set_source, coding_set_destination): Return void.
3650 (coding_change_source, coding_change_destinations): New functions,
3651 with the old behaviors of coding_set_source and coding_set_destination.
3652 All callers that need an offset changed to use these new functions.
3654 2012-05-26 Glenn Morris <rgm@gnu.org>
3656 * nsterm.m (ns_init_paths): Don't mess with INFOPATH. (Bug#2791)
3658 2012-05-26 Eli Zaretskii <eliz@gnu.org>
3660 Extend mouse support on W32 text-mode console.
3661 * xdisp.c (draw_row_with_mouse_face):
3662 Call tty_draw_row_with_mouse_face for WINDOWSNT as well.
3664 * w32console.c: Include window.h.
3665 (w32con_write_glyphs_with_face, tty_draw_row_with_mouse_face):
3667 (initialize_w32_display): Initialize mouse-highlight data.
3669 * w32inevt.c: Include termchar.h and window.h.
3670 (do_mouse_event): Support mouse-autoselect-window. When the mouse
3671 moves, call note_mouse_highlight. If help_echo changed, call
3672 gen_help_event to produce help-echo message in the echo area.
3673 Call clear_mouse_face if mouse_face_hidden is set in the mouse
3676 2012-05-26 Paul Eggert <eggert@cs.ucla.edu>
3678 * lread.c (read1): Simplify slightly to avoid an overflow warning
3679 with GCC 4.7.0 on x86-64.
3681 2012-05-26 Eli Zaretskii <eliz@gnu.org>
3683 * bidi.c (bidi_mirror_char): Revert last change: an int is
3684 definitely wide enough here.
3686 2012-05-25 Paul Eggert <eggert@cs.ucla.edu>
3688 Fix integer width and related bugs (Bug#9874).
3689 * alloc.c (pure_bytes_used_lisp, pure_bytes_used_non_lisp):
3690 (allocate_vectorlike, buffer_memory_full, struct sdata, SDATA_SIZE)
3691 (string_bytes, check_sblock, allocate_string_data):
3692 (compact_small_strings, Fmake_bool_vector, make_string)
3693 (make_unibyte_string, make_multibyte_string)
3694 (make_string_from_bytes, make_specified_string)
3695 (allocate_vectorlike, Fmake_vector, find_string_data_in_pure)
3696 (make_pure_string, make_pure_c_string, make_pure_vector, Fpurecopy)
3698 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3699 (allocate_pseudovector):
3700 Use int, not EMACS_INT, where int is wide enough.
3701 (inhibit_garbage_collection, Fgarbage_collect):
3702 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3703 * bidi.c (bidi_mirror_char): Use EMACS_INT, not int, where
3704 int might not be wide enough.
3705 (bidi_cache_search, bidi_cache_find, bidi_init_it)
3706 (bidi_count_bytes, bidi_char_at_pos, bidi_fetch_char)
3707 (bidi_at_paragraph_end, bidi_find_paragraph_start)
3708 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak)
3709 (bidi_level_of_next_char, bidi_move_to_visually_next):
3710 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3711 * buffer.c (copy_overlays, Fgenerate_new_buffer_name)
3712 (Fkill_buffer, Fset_buffer_major_mode)
3713 (advance_to_char_boundary, Fbuffer_swap_text)
3714 (Fset_buffer_multibyte, overlays_at, overlays_in)
3715 (overlay_touches_p, struct sortvec, record_overlay_string)
3716 (overlay_strings, recenter_overlay_lists)
3717 (adjust_overlays_for_insert, adjust_overlays_for_delete)
3718 (fix_start_end_in_overlays, fix_overlays_before, modify_overlay)
3719 (Fmove_overlay, Fnext_overlay_change, Fprevious_overlay_change)
3720 (Foverlay_recenter, last_overlay_modification_hooks_used)
3721 (report_overlay_modification, evaporate_overlays, enlarge_buffer_text):
3722 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3723 (validate_region): Omit unnecessary test for b <= e,
3724 since that's guaranteed by the previous test.
3725 (adjust_overlays_for_delete): Avoid pos + length overflow.
3726 (Fmove_overlay, Fdelete_overlay, add_overlay_mod_hooklist)
3727 (report_overlay_modification):
3728 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3729 (Foverlays_at, Fnext_overlay_change, Fprevious_overlay_change):
3730 Omit pointer cast, which isn't needed anyway, and doesn't work
3731 after the EMACS_INT -> ptrdiff_t change.
3732 (Fmove_overlay): Clip BEG and END to ptrdiff_t to avoid overflow.
3733 * buffer.h: Adjust decls to match defn changes elsewhere.
3734 (struct buffer_text, struct buffer):
3735 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3736 Use EMACS_INT, not int, where int might not be wide enough.
3737 * bytecode.c (unmark_byte_stack, exec_byte_code): Use ptrdiff_t,
3738 not int, to avoid needless 32-bit limit on 64-bit hosts.
3739 (exec_byte_code): Use tighter memory-full test, one that checks
3740 for alloca overflow. Don't compute the address of the object just
3741 before an array, as that's not portable. Use EMACS_INT, not
3742 ptrdiff_t or int, where ptrdiff_t or int might not be wide enough.
3743 * callint.c (Fcall_interactively):
3744 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3745 * callproc.c (call_process_kill, Fcall_process):
3746 Don't assume pid_t fits into an Emacs fixnum.
3747 (call_process_cleanup, Fcall_process, child_setup):
3748 Don't assume pid_t fits into int.
3749 (call_process_cleanup, Fcall_process, delete_temp_file)
3750 (Fcall_process_region):
3751 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3752 (Fcall_process): Simplify handling of volatile integers.
3753 Use int, not EMACS_INT, where int will do.
3754 * casefiddle.c (casify_object, casify_region, operate_on_word)
3755 (Fupcase_word, Fdowncase_word, Fcapitalize_word):
3756 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3757 (casify_object): Avoid integer overflow when overallocating buffer.
3758 * casetab.c (set_identity, shuffle): Prefer int to unsigned when
3759 either works. Use lint_assume to convince GCC 4.6.1 that it's OK.
3760 * category.c (Fchar_category_set): Don't assume fixnum fits in int.
3761 * category.h (CATEGORYP): Don't assume arg is nonnegative.
3762 * ccl.c (GET_CCL_INT): Remove; no longer needed, since the
3763 integers are now checked earlier. All uses replaced with XINT.
3765 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3766 For CCL_MapSingle, check that content and value are in int range.
3767 (ccl_driver, Fregister_code_conversion_map):
3768 Check that Vcode_version_map_vector is a vector.
3769 (resolve_symbol_ccl_program): Check that vector header is in range.
3770 Always copy the vector, so that we can check its contents reliably
3771 now rather than having to recheck each instruction as it's being
3772 executed. Check that vector words fit in 'int'.
3773 (ccl_get_compiled_code, Fregister_ccl_program)
3774 (Fregister_code_conversion_map): Use ptrdiff_t, not int, for
3775 program indexes, to avoid needless 32-bit limit on 64-bit hosts.
3776 (Fccl_execute, Fccl_execute_on_string): Check that initial reg
3777 contents are in range.
3778 (Fccl_execute_on_string): Check that status is in range.
3779 * ccl.h (struct ccl_program.idx): Now ptrdiff_t, not int.
3780 * character.c (char_resolve_modifier_mask, Fchar_resolve_modifiers):
3781 Accept and return EMACS_INT, not int, because callers can pass values
3783 (c_string_width, strwidth, lisp_string_width, chars_in_text)
3784 (multibyte_chars_in_text, parse_str_as_multibyte)
3785 (str_as_multibyte, count_size_as_multibyte, str_to_multibyte)
3786 (str_as_unibyte, str_to_unibyte, string_count_byte8)
3787 (string_escape_byte8, Fget_byte):
3788 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3789 (Funibyte_string): Use CHECK_RANGED_INTEGER, not CHECK_NATNUM, to
3790 avoid mishandling large integers.
3791 * character.h: Adjust decls to match defn changes elsewhere.
3792 * charset.c (load_charset_map_from_file, find_charsets_in_text)
3793 (Ffind_charset_region):
3794 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3795 (load_charset_map_from_file): Redo idx calculation to avoid overflow.
3796 (load_charset_map_from_vector, Fdefine_charset_internal):
3797 Don't assume fixnum fits in int.
3798 (load_charset_map_from_vector, Fmap_charset_chars):
3799 Remove now-unnecessary CHECK_NATNUMs.
3800 (Fdefine_charset_internal): Check ranges here, more carefully.
3801 Don't rely on undefined behavior with signed left shift overflow.
3802 Don't assume unsigned int fits into fixnum, or that fixnum fits
3803 into unsigned int. Don't require max_code to be a valid fixnum;
3804 that's not true for gb10830 4-byte on a 32-bit host. Allow
3805 invalid_code to be a cons, for the same reason. Require code_offset
3806 to be a character. Avoid int overflow if max_char is close
3808 (CODE_POINT_TO_INDEX): On 32-bit hosts, return int, not unsigned;
3809 this is intended anyway and avoids some undefined behavior.
3810 (load_charset_map): Pass unsigned, not int, as 2nd arg of
3811 INDEX_TO_CODE_POINT, as that's what it expects.
3812 (Funify_charset, encode_char): Don't stuff unsigned vals into int vars.
3813 * charset.h (DECODE_CHAR): Return int, not unsigned;
3814 this is what was intended anyway, and it avoids undefined behavior.
3815 (CHARSET_OFFSET): Remove unused macro, instead of fixing its
3816 integer-overflow issues.
3817 (ENCODE_CHAR): Return unsigned on all hosts, not just on 32-bit hosts.
3818 Formerly, it returned EMACS_INT on 64-bit hosts in the common case
3819 where the argument is EMACS_INT, and this behavior is not intended.
3820 * chartab.c (Fmake_char_table, Fset_char_table_range)
3821 (uniprop_get_decoder, uniprop_get_encoder):
3822 Don't assume fixnum fits in int.
3823 * cmds.c (move_point): New function, that does the gist of
3824 Fforward_char and Fbackward_char, but does so while checking
3825 for integer overflow more accurately.
3826 (Fforward_char, Fbackward_char): Use it.
3827 (Fforward_line, Fend_of_line, internal_self_insert)
3828 (internal_self_insert):
3829 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3830 Fix a FIXME, by checking for integer overflow when calculating
3831 target_clm and actual_clm.
3832 * coding.c (detect_coding_XXX, encode_coding_XXX, CODING_DECODE_CHAR)
3833 (CODING_ENCODE_CHAR, CODING_CHAR_CHARSET, CODING_CHAR_CHARSET_P)
3834 (ASSURE_DESTINATION, coding_alloc_by_realloc)
3835 (coding_alloc_by_making_gap, alloc_destination)
3836 (detect_coding_utf_8, encode_coding_utf_8, decode_coding_utf_16)
3837 (encode_coding_utf_16, detect_coding_emacs_mule)
3838 (decode_coding_emacs_mule, encode_coding_emacs_mule)
3839 (detect_coding_iso_2022, decode_coding_iso_2022)
3840 (encode_invocation_designation, encode_designation_at_bol)
3841 (encode_coding_iso_2022, detect_coding_sjis, detect_coding_big5)
3842 (decode_coding_sjis, decode_coding_big5, encode_coding_sjis)
3843 (encode_coding_big5, detect_coding_ccl, decode_coding_ccl)
3844 (encode_coding_ccl, encode_coding_raw_text)
3845 (detect_coding_charset, decode_coding_charset)
3846 (encode_coding_charset, detect_eol, decode_eol, produce_chars)
3847 (produce_composition, produce_charset, produce_annotation)
3848 (decode_coding, handle_composition_annotation)
3849 (handle_charset_annotation, consume_chars, decode_coding_gap)
3850 (decode_coding_object, encode_coding_object, detect_coding_system)
3851 (Ffind_coding_systems_region_internal, Fcheck_coding_systems_region)
3852 (code_convert_region, code_convert_string)
3853 (Fdefine_coding_system_internal)
3854 (coding_set_source, coding_set_destination):
3855 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3856 (setup_iso_safe_charsets, consume_chars, Funencodable_char_position)
3857 (Fdefine_coding_system_internal):
3858 Don't assume fixnums fit in int.
3859 (decode_coding_gap, decode_coding_object, encode_coding_object)
3860 (Fread_coding_system, Fdetect_coding_region)
3861 (Funencodable_char_position, Fcheck_coding_systems_region)
3862 (get_translation, handle_composition_annotation, consume_chars):
3863 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3864 (consume_chars): Rewrite to not calculate an address outside buffer.
3865 (Ffind_operation_coding_system): NATNUMP can eval its arg twice.
3866 Don't access memory outside of the args array.
3867 (Fdefine_coding_system_internal): Check for charset-id overflow.
3868 (ENCODE_ISO_CHARACTER): Use unsigned, not int, to store the unsigned
3869 result of ENCODE_CHAR.
3870 * coding.h: Adjust decls to match defn changes elsewhere.
3871 (struct coding_system):
3872 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3873 * composite.c (get_composition_id, find_composition)
3874 (run_composition_function, update_compositions)
3875 (compose_text, composition_gstring_put_cache)
3876 (composition_gstring_p, composition_gstring_width)
3877 (fill_gstring_header, fill_gstring_body, autocmp_chars)
3878 (composition_compute_stop_pos, composition_reseat_it)
3879 (composition_update_it, struct position_record)
3880 (find_automatic_composition, composition_adjust_point)
3881 (Fcomposition_get_gstring, Ffind_composition_internal):
3882 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3883 (update_compositions):
3884 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3885 * composite.h: Adjust decls to match defn changes elsewhere.
3886 (struct composition):
3887 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3888 * data.c (let_shadows_buffer_binding_p, let_shadows_global_binding_p):
3889 Do not attempt to compute the address of the object just before a
3890 buffer; this is not portable.
3892 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3893 (Faset): Use int, not EMACS_INT, where int is wide enough.
3894 (Fstring_to_number): Don't assume fixnums fit in int.
3895 (Frem): Don't assume arg is nonnegative.
3896 * dbusbind.c (xd_append_arg): Check for integers out of range.
3897 (Fdbus_call_method): Don't overflow the timeout int.
3898 (extract_signed, extract_unsigned): New functions.
3899 (XD_CHECK_DBUS_SERIAL): Remove; superseded by extract_unsigned.
3900 (xd_get_connection_references): Return ptrdiff_t, not int.
3902 (xd_signature, xd_append_arg, xd_retrieve_arg, Fdbus_message_internal)
3903 (xd_read_message_1):
3904 Use int, not unsigned, where the dbus API uses int.
3905 (Fdbus_message_internal): Don't overflow mtype.
3906 (syms_of_dbusbind): Allocate right-sized buffer for integers.
3907 * dired.c (directory_files_internal, file_name_completion, scmp)
3908 (file_name_completion_stat):
3909 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3910 (file_name_completion): Don't overflow matchcount.
3911 (file_name_completion_stat): Use SAFE_ALLOCA, not alloca.
3912 * dispextern.h: Adjust decls to match defn changes elsewhere.
3913 (struct text_pos, struct glyph, struct bidi_saved_info)
3914 (struct bidi_string_data, struct bidi_it, struct composition_it)
3916 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3917 (struct display_pos, struct composition_it, struct it):
3918 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3919 * dispnew.c (increment_matrix_positions)
3920 (increment_row_positions, mode_line_string)
3921 (marginal_area_string):
3922 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3923 (change_frame_size_1, Fredisplay, Fframe_or_buffer_changed_p):
3924 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3925 (duration_to_sec_usec): New function, to check for overflow better.
3926 (Fsleep_for, sit_for): Use it.
3927 * doc.c (get_doc_string, store_function_docstring):
3928 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3929 (get_doc_string, Fsnarf_documentation):
3930 Use int, not EMACS_INT, where int is wide enough.
3932 Use SAFE_ALLOCA, not alloca.
3933 Check for overflow when converting EMACS_INT to off_t.
3934 * doprnt.c (doprnt):
3935 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3936 * editfns.c (init_editfns, Fuser_uid, Fuser_real_uid):
3937 Don't assume uid_t fits into fixnum.
3938 (buildmark, Fgoto_char, overlays_around, find_field, Fdelete_field)
3939 (Ffield_string, Ffield_string_no_properties, Ffield_beginning)
3940 (Ffield_end, Fconstrain_to_field, Fline_beginning_position)
3941 (Fline_end_position, Fprevious_char, Fchar_after, Fchar_before)
3942 (general_insert_function)
3943 (Finsert_char, make_buffer_string, make_buffer_string_both)
3944 (update_buffer_properties, Fbuffer_substring)
3945 (Fbuffer_substring_no_properties, Fcompare_buffer_substrings)
3946 (Fsubst_char_in_region, check_translation)
3947 (Ftranslate_region_internal, save_restriction_restore, Fformat)
3948 (transpose_markers, Ftranspose_regions):
3949 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3950 (clip_to_bounds): Move to lisp.h as an inline function).
3951 (Fconstrain_to_field): Don't assume integers are nonnegative.
3952 (Fline_beginning_position, Fsave_excursion, Fsave_current_buffer):
3953 (Fsubst_char_in_region, Fsave_restriction):
3954 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3955 (Femacs_pid): Don't assume pid_t fits into fixnum.
3956 (lo_time): Use int, not EMACS_INT, when int suffices.
3957 (lisp_time_argument): Check for usec out of range.
3958 (Fencode_time): Don't assume fixnum fits in int.
3959 (Fuser_login_name, Fuser_full_name): Signal an error
3960 if a uid argument is out of range, rather than relying on
3962 (Fformat_time_string): Remove now-unnecessary check.
3963 lisp_time_argument checks for out-of-range usec now.
3964 Use ptrdiff_t, not size_t, where ptrdiff_t will do.
3965 * emacs.c (gdb_valbits, gdb_gctypebits): Now int, not EMACS_INT.
3966 (gdb_data_seg_bits): Now uintptr_t, not EMACS_INT.
3967 (PVEC_FLAG, gdb_array_mark_flag): Now ptrdiff_t, not EMACS_INT.
3968 (init_cmdargs, Fdump_emacs):
3969 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3970 (Fkill_emacs): Don't assume fixnum fits in int; instead, take just
3971 the bottom (typically) 32 bits of the fixnum.
3972 * eval.c (specpdl_size, call_debugger):
3973 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3974 (when_entered_debugger, Fbacktrace_debug):
3975 Don't assume fixnum can fit in int.
3976 (Fdefvaralias, Fdefvar): Do not attempt to compute the address of
3977 the object just before a buffer; this is not portable.
3978 (FletX, Flet, Funwind_protect, do_autoload, Feval, funcall_lambda)
3979 (grow_specpdl, unbind_to):
3980 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3981 (Fapply, apply_lambda): Don't assume ptrdiff_t can hold fixnum.
3982 (grow_specpdl): Simplify allocation by using xpalloc.
3983 (Fprog1, Fprog2): Don't assume list length fits in int. Simplify.
3984 * fileio.c (Ffind_file_name_handler, Fcopy_file, Frename_file)
3985 (Finsert_file_contents, Fwrite_region, Fdo_auto_save):
3986 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3987 (Ffind_file_name_handler, non_regular_inserted, Finsert_file_contents)
3989 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3990 (Fcopy_file, non_regular_nbytes, read_non_regular)
3991 (Finsert_file_contents):
3992 Use int, not EMACS_INT, where int is wide enough.
3993 (READ_BUF_SIZE): Verify that it fits in int.
3994 (Finsert_file_contents): Check that counts are in proper range,
3995 rather than assuming fixnums fit into ptrdiff_t etc.
3996 Don't assume fixnums fit into int.
3997 * floatfns.c (Fexpt): Avoid undefined signed * signed overflow.
3998 * fns.c (Fcompare_strings, Fstring_lessp, struct textprop_rec, concat)
3999 (string_char_byte_cache_charpos, string_char_byte_cache_bytepos)
4000 (string_char_to_byte, string_byte_to_char)
4001 (string_make_multibyte, string_to_multibyte)
4002 (string_make_unibyte, Fstring_as_unibyte, Fstring_as_multibyte)
4003 (Fstring_to_unibyte, Fsubstring, Fsubstring_no_properties)
4004 (substring_both, Fdelete, internal_equal, Ffillarray)
4005 (Fclear_string, mapcar1)
4006 (Fbase64_encode_region, Fbase64_encode_string, base64_encode_1)
4007 (Fbase64_decode_region, Fbase64_decode_string, base64_decode_1)
4008 (larger_vector, make_hash_table, maybe_resize_hash_table)
4009 (hash_lookup, hash_remove_from_table, hash_clear, sweep_weak_table)
4010 (Fmaphash, secure_hash):
4011 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
4012 (concat): Check for string index and length overflow.
4013 (Fmapconcat): Don't assume fixnums fit into ptrdiff_t.
4015 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
4016 (larger_vector): New API (vec, incr_min, size_max) replaces old
4017 one (vec, new_size, init). This catches size overflow.
4018 INIT was removed because it was always Qnil.
4019 All callers changed.
4020 (INDEX_SIZE_BOUND): New macro, which calculates more precisely
4021 the upper bound on a hash table index size.
4022 (make_hash_table, maybe_resize_hash_table): Use it.
4023 (secure_hash): Computer start_byte and end_byte only after
4024 they're known to be in ptrdiff_t range.
4025 * font.c (font_intern_prop, font_at, font_range, Ffont_shape_gstring)
4026 (Ffont_get_glyphs, Ffont_at):
4027 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
4028 (font_style_to_value, font_prop_validate_style, font_expand_wildcards)
4029 (Flist_fonts, Fopen_font):
4030 Don't assume fixnum can fit in int.
4031 (check_gstring): Don't assume index can fit in int.
4032 (font_match_p): Check that fixnum is a character, not a nonnegative
4033 fixnum, since the later code needs to stuff it into an int.
4034 (font_find_for_lface): Use SAFE_ALLOCA_LISP, not alloca.
4035 (font_fill_lglyph_metrics): Use unsigned, not EMACS_INT, to avoid
4036 conversion overflow issues.
4037 (Fopen_font): Check for integer out of range.
4038 (Ffont_get_glyphs): Don't assume index can fit in int.
4039 * font.h: Adjust decls to match defn changes elsewhere.
4040 * fontset.c (reorder_font_vector): Redo score calculation to avoid
4042 (num_auto_fontsets, fontset_from_font): Use ptrdiff_t, not
4043 printmax_t, where ptrdiff_t is wide enough.
4044 (Finternal_char_font):
4045 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
4046 * frame.c (Fset_mouse_position, Fset_mouse_pixel_position)
4047 (Fset_frame_height, Fset_frame_width, Fset_frame_size)
4048 (Fset_frame_position, x_set_frame_parameters)
4049 (x_set_line_spacing, x_set_border_width)
4050 (x_set_internal_border_width, x_set_alpha, x_figure_window_size):
4051 Check that fixnums are in proper range for system types.
4052 (frame_name_fnn_p, Fframe_parameter, Fmodify_frame_parameters):
4053 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
4054 (Fmodify_frame_parameters): Don't assume fixnum fits in int.
4055 Use SAFE_ALLOCA_LISP, not alloca.
4056 * frame.h (struct frame): Use intptr_t, not EMACS_INT, where
4057 intptr_t is wide enough.
4058 * fringe.c (lookup_fringe_bitmap, get_logical_fringe_bitmap)
4059 (Fdefine_fringe_bitmap): Don't assume fixnum fits in int.
4060 (Ffringe_bitmaps_at_pos): Don't assume index fits in int.
4061 Check for fixnum out of range.
4062 * ftfont.c (ftfont_list): Don't assume index fits in int.
4063 Check that fixnums are in proper range for system types.
4064 (ftfont_shape_by_flt):
4065 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
4066 * gnutls.c (emacs_gnutls_write, emacs_gnutls_read):
4067 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
4068 (Fgnutls_error_fatalp, Fgnutls_error_string, Fgnutls_boot):
4069 Check that fixnums are in proper range for system types.
4070 * gnutls.h: Adjust decls to match defn changes elsewhere.
4071 * gtkutil.c (xg_dialog_run):
4072 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
4073 (update_frame_tool_bar):
4074 Check that fixnums are in proper range for system types.
4075 * image.c (parse_image_spec): Redo count calculation to avoid overflow.
4076 (lookup_image): Check that fixnums are in range for system types.
4077 * indent.c (last_known_column, last_known_column_point):
4078 (current_column_bol_cache):
4079 (skip_invisible, current_column, check_display_width):
4080 (check_display_width, scan_for_column, current_column_1)
4081 (Findent_to, Fcurrent_indentation, position_indentation)
4082 (indented_beyond_p, Fmove_to_column, compute_motion):
4083 (Fcompute_motion, Fvertical_motion):
4084 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
4085 (last_known_column_modified): Use EMACS_INT, not int.
4086 (check_display_width):
4088 Check that fixnums and floats are in proper range for system types.
4089 (compute_motion): Don't assume index or fixnum fits in int.
4090 (compute_motion, Fcompute_motion):
4091 Use int, not EMACS_INT, when it is wide enough.
4092 (vmotion): Omit local var start_hpos that is always 0; that way
4093 we don't need to worry about overflow in expressions involving it.
4094 * indent.h: Adjust decls to match defn changes elsewhere.
4096 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
4097 Use int, not EMACS_INT, where int is wide enough.
4098 Remove unused members ovstring_chars_done and tab_offset;
4100 * insdel.c (move_gap, move_gap_both, gap_left, gap_right)
4101 (adjust_markers_for_delete, adjust_markers_for_insert, adjust_point)
4102 (adjust_markers_for_replace, make_gap_larger, make_gap_smaller)
4103 (make_gap, copy_text, insert, insert_and_inherit)
4104 (insert_before_markers, insert_before_markers_and_inherit)
4105 (insert_1, count_combining_before, count_combining_after)
4106 (insert_1_both, insert_from_string)
4107 (insert_from_string_before_markers, insert_from_string_1)
4108 (insert_from_gap, insert_from_buffer, insert_from_buffer_1)
4109 (adjust_after_replace, adjust_after_insert, replace_range)
4110 (replace_range_2, del_range, del_range_1, del_range_byte)
4111 (del_range_both, del_range_2, modify_region)
4112 (prepare_to_modify_buffer, signal_before_change)
4113 (signal_after_change, Fcombine_after_change_execute):
4114 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
4115 * intervals.c (traverse_intervals, rotate_right, rotate_left)
4116 (balance_an_interval, split_interval_right, split_interval_left)
4117 (find_interval, next_interval, update_interval)
4118 (adjust_intervals_for_insertion, delete_node, delete_interval)
4119 (interval_deletion_adjustment, adjust_intervals_for_deletion)
4120 (static_offset_intervals, offset_intervals)
4121 (merge_interval_right, merge_interval_left, make_new_interval)
4122 (graft_intervals_into_buffer, temp_set_point_both)
4123 (temp_set_point, set_point, adjust_for_invis_intang)
4124 (set_point_both, move_if_not_intangible, get_property_and_range)
4125 (get_local_map, copy_intervals, copy_intervals_to_string)
4126 (compare_string_intervals, set_intervals_multibyte_1):
4127 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
4128 * intervals.h: Adjust decls to match defn changes elsewhere.
4130 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
4131 * keyboard.c (this_command_key_count, this_single_command_key_start)
4132 (before_command_key_count, before_command_echo_length, echo_now)
4133 (echo_length, recursive_edit_1, Frecursive_edit, Ftrack_mouse)
4134 (command_loop_1, safe_run_hooks, read_char, timer_check_2)
4135 (menu_item_eval_property, read_key_sequence, Fread_key_sequence)
4136 (Fread_key_sequence_vector, Fexecute_extended_command, Fsuspend_emacs):
4137 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
4138 (last_non_minibuf_size, last_point_position, echo_truncate)
4139 (command_loop_1, adjust_point_for_property, read_char, gen_help_event)
4140 (make_lispy_position, make_lispy_event, parse_modifiers_uncached)
4141 (parse_modifiers, modify_event_symbol, Fexecute_extended_command)
4142 (stuff_buffered_input):
4143 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
4144 (last_auto_save, command_loop_1, read_char):
4145 Use EMACS_INT, not int, to avoid integer overflow.
4146 (record_char): Avoid overflow in total_keys computation.
4147 (parse_modifiers_uncached): Redo index calculation to avoid overflow.
4148 * keyboard.h: Adjust decls to match defn changes elsewhere.
4149 * keymap.c (Fdefine_key, Fcurrent_active_maps, accessible_keymaps_1)
4150 (Fkey_description, Fdescribe_vector, Flookup_key):
4151 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
4152 (click_position): New function, to check that positions are in range.
4153 (Fcurrent_active_maps):
4155 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
4156 (Faccessible_keymaps, Fkey_description):
4157 (preferred_sequence_p):
4158 Don't assume fixnum can fit into int.
4159 (Fkey_description): Use SAFE_ALLOCA_LISP, not alloca.
4160 Check for integer overflow in size calculations.
4161 (Ftext_char_description): Use CHECK_CHARACTER, not CHECK_NUMBER, to
4162 avoid mishandling large integers.
4163 * lisp.h: Adjust decls to match defn changes elsewhere.
4164 (ARRAY_MARK_FLAG, PSEUDOVECTOR_FLAG, struct Lisp_String)
4165 (struct vectorlike_header, struct Lisp_Subr, struct Lisp_Hash_Table)
4166 (struct Lisp_Marker):
4167 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
4168 (clip_to_bounds): Now an inline function, moved here from editfns.c.
4169 (GLYPH_CODE_P): Check for overflow in system types, subsuming the
4170 need for GLYPH_CODE_CHAR_VALID_P and doing proper checking ourselves.
4171 All callers changed.
4172 (GLYPH_CODE_CHAR, GLYPH_CODE_FACE):
4173 Assume the arg has valid form, since it always does.
4174 (TYPE_RANGED_INTEGERP): Avoid bug when checking against a wide
4175 unsigned integer system type.
4176 (CHECK_RANGED_INTEGER, CHECK_TYPE_RANGED_INTEGER): New macros.
4177 (struct catchtag, specpdl_size, SPECPDL_INDEX, USE_SAFE_ALLOCA):
4178 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
4179 (struct catchtag): Use EMACS_INT, not int, since it may be a fixnum.
4180 (duration_to_sec_usec): New decl.
4181 * lread.c (read_from_string_index, read_from_string_index_byte)
4182 (read_from_string_limit, readchar, unreadchar, openp)
4183 (read_internal_start, read1, oblookup):
4184 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
4185 (Fload, readevalloop, Feval_buffer, Feval_region):
4186 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
4187 (openp): Check for out-of-range argument to 'access'.
4188 (read1): Use int, not EMACS_INT, where int is wide enough.
4189 Don't assume fixnum fits into int.
4190 Fix off-by-one error that can read outside a buffer.
4191 (read_filtered_event): Use duration_to_sec_usec
4192 to do proper overflow checking on durations.
4193 * macros.c (Fstart_kbd_macro): Use xpalloc to check for overflow
4194 in size calculation.
4195 (Fexecute_kbd_macro):
4196 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
4197 * marker.c (cached_charpos, cached_bytepos, CONSIDER)
4198 (byte_char_debug_check, buf_charpos_to_bytepos, verify_bytepos)
4199 (buf_bytepos_to_charpos, Fset_marker, set_marker_restricted)
4200 (set_marker_both, set_marker_restricted_both, marker_position)
4201 (marker_byte_position, Fbuffer_has_markers_at):
4202 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
4203 (Fset_marker, set_marker_restricted): Don't assume fixnum fits in int.
4204 * menu.c (ensure_menu_items): Rename from grow_menu_items.
4205 It now merely ensures that the menu is large enough, without
4206 necessarily growing it, as this avoids some integer overflow issues.
4207 All callers changed.
4208 (keymap_panes, parse_single_submenu, Fx_popup_menu):
4209 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
4210 (parse_single_submenu, Fx_popup_menu): Don't assume fixnum fits in int.
4211 Use SAFE_ALLOCA_LISP, not alloca.
4212 (find_and_return_menu_selection): Avoid unnecessary casts of pointers
4213 to EMACS_INT. Check that fixnums are in proper range for system types.
4214 * minibuf.c (minibuf_prompt_width, string_to_object)
4215 (Fminibuffer_contents, Fminibuffer_contents_no_properties)
4216 (Fminibuffer_completion_contents, Ftry_completion, Fall_completions):
4217 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
4218 (get_minibuffer, read_minibuf_unwind):
4219 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
4220 (read_minibuf): Omit unnecessary arg BACKUP_N, which is always nil;
4221 this simplifies overflow checking. All callers changed.
4222 (read_minibuf, Fread_buffer, Ftry_completion, Fall_completions)
4224 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
4225 * nsfns.m (check_ns_display_info): Don't assume fixnum fits in long.
4226 (x_set_menu_bar_lines, x_set_tool_bar_lines, Fx_create_frame):
4227 Check that fixnums are in proper range for system types.
4228 (Fx_create_frame, Fx_show_tip):
4229 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
4230 * nsfont.m (ns_findfonts, nsfont_list_family):
4231 Don't assume fixnum fits in long.
4232 * nsmenu.m (ns_update_menubar, ns_menu_show, ns_popup_dialog):
4233 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
4234 (ns_update_menubar): Use intptr_t, not EMACS_INT, when intptr_t is
4236 * nsselect.m (ns_get_local_selection, clean_local_selection_data):
4237 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
4238 * print.c (print_buffer_size, print_buffer_pos, print_buffer_pos_byte)
4239 (PRINTDECLARE, PRINTPREPARE):
4240 (strout, print_string):
4241 (print, print_preprocess, print_check_string_charset_prop)
4243 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
4245 (temp_output_buffer_setup, Fprin1_to_string, print_object):
4246 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
4247 (PRINTPREPARE): Use int, not ptrdiff_t, where int is wide enough.
4248 (printchar, strout): Use xpalloc to catch size calculation overflow.
4249 (Fexternal_debugging_output): Don't overflow EMACS_INT->int conversion.
4250 (print_error_message): Use SAFE_ALLOCA, not alloca.
4251 (print_object): Use int, not EMACS_INT, where int is wide enough.
4252 (print_depth, new_backquote_output, print_number_index):
4253 Use ptrdiff_t, not int, where int might not be wide enough.
4254 * process.c (Fdelete_process): Don't assume pid fits into EMACS_INT.
4255 (Fset_process_window_size, Fformat_network_address)
4256 (get_lisp_to_sockaddr_size, set_socket_option, Fmake_network_process)
4258 Check that fixnums are in proper range for system types.
4259 (Fsignal_process): Simplify by avoiding a goto.
4260 Check for process-ids out of pid_t range rather than relying on
4262 (process_tick, update_tick): Use EMACS_INT, not int.
4263 (Fformat_network_address, read_process_output, send_process)
4264 (Fprocess_send_region, status_notify):
4265 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
4266 (Fformat_network_address, Fmake_serial_process, Fmake_network_process)
4267 (wait_reading_process_output, read_process_output, exec_sentinel):
4268 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
4269 (conv_lisp_to_sockaddr): Don't assume fixnums fit into int.
4270 (Faccept_process_output): Use duration_to_sec_usec to do proper
4271 overflow checking on durations.
4272 (emacs_get_tty_pgrp, Fprocess_running_child_p, process_send_signal):
4273 Don't assume pid_t fits in int.
4274 * process.h (struct Lisp_Process): Members tick and update_tick
4275 are now of type EMACS_INT, not int.
4276 * puresize.h (PURESIZE_RATIO): Shrink this to 8/6 on 32-bit hosts
4277 configured --with-wide-int.
4278 * scroll.c (calculate_scrolling, calculate_direct_scrolling)
4279 (line_ins_del): Use int, not EMACS_INT, where int is wide enough.
4280 * search.c (looking_at_1, string_match_1):
4281 (fast_string_match, fast_c_string_match_ignore_case)
4282 (fast_string_match_ignore_case, fast_looking_at, scan_buffer)
4283 (scan_newline, find_before_next_newline, search_command)
4284 (trivial_regexp_p, search_buffer, simple_search, boyer_moore)
4285 (set_search_regs, wordify):
4288 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
4289 (string_match_1, search_buffer, set_search_regs):
4291 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
4292 (wordify): Check for overflow in size calculation.
4293 (Freplace_match): Avoid potential buffer overflow in search_regs.start.
4294 (Fset_match_data): Don't assume fixnum fits in ptrdiff_t.
4295 Check that fixnums are in proper range for system types.
4296 * sound.c (struct sound_device)
4297 (wav_play, au_play, vox_write, alsa_period_size, alsa_write):
4298 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
4299 (Fplay_sound_internal):
4300 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
4301 * syntax.c (struct lisp_parse_state, find_start_modiff)
4302 (Finternal_describe_syntax_value, scan_lists, scan_sexps_forward):
4303 (Fparse_partial_sexp):
4304 Don't assume fixnums can fit in int.
4305 (struct lisp_parse_state, find_start_pos, find_start_value)
4306 (find_start_value_byte, find_start_begv)
4307 (update_syntax_table, char_quoted, dec_bytepos)
4308 (find_defun_start, prev_char_comend_first, back_comment):
4309 (scan_words, skip_chars, skip_syntaxes, forw_comment, Fforward_comment)
4310 (scan_lists, Fbackward_prefix_chars, scan_sexps_forward):
4311 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
4312 (Finternal_describe_syntax_value): Check that match_lisp is a
4313 character, not an integer, since the code stuffs it into int.
4314 (scan_words, scan_sexps_forward):
4315 Check that fixnums are in proper range for system types.
4317 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
4318 (scan_sexps_forward):
4319 Use CHARACTERP, not INTEGERP, since the value must fit into int.
4320 (Fparse_partial_sexp): Fix doc; element 8 is not ignored.
4321 * syntax.h: Adjust decls to match defn changes elsewhere.
4322 (struct gl_state_s):
4323 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
4324 (SETUP_SYNTAX_TABLE_FOR_OBJECT): Use PTRDIFF_MAX, not
4325 MOST_POSITIVE_FIXNUM.
4326 * sysdep.c (wait_for_termination_1, wait_for_termination)
4327 (interruptible_wait_for_termination, mkdir):
4328 Don't assume pid_t fits in int; on 64-bit AIX pid_t is 64-bit.
4329 (emacs_read, emacs_write):
4330 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
4331 (system_process_attributes): Don't assume uid_t, gid_t, EMACS_INT,
4332 and double all fit in int.
4333 * term.c (set_tty_color_mode):
4334 Check that fixnums are in proper range for system types.
4335 * termhooks.h (struct input_event):
4336 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
4337 * textprop.c (validate_interval_range, interval_of)
4338 (Fadd_text_properties, set_text_properties_1)
4339 (Fremove_text_properties, Fremove_list_of_text_properties)
4340 (Ftext_property_any, Ftext_property_not_all)
4341 (copy_text_properties, text_property_list, extend_property_ranges)
4342 (verify_interval_modification):
4343 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
4344 (Fnext_single_char_property_change)
4345 (Fprevious_single_char_property_change):
4346 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
4347 (copy_text_properties):
4348 Check for integer overflow in index calculation.
4349 * undo.c (last_boundary_position, record_point, record_insert)
4350 (record_delete, record_marker_adjustment, record_change)
4351 (record_property_change):
4352 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
4353 (truncate_undo_list, Fprimitive_undo): Don't assume fixnum fits in int.
4354 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
4355 * w32fns.c (Fx_create_frame, x_create_tip_frame, Fx_show_tip)
4356 (Fx_hide_tip, Fx_file_dialog):
4357 * w32menu.c (set_frame_menubar):
4358 Use ptrdiff_t, not int, for consistency with rest of code.
4359 * window.c (window_scroll_preserve_hpos, window_scroll_preserve_vpos)
4360 (select_window, Fdelete_other_windows_internal)
4361 (window_scroll_pixel_based, window_scroll_line_based)
4362 (Frecenter, Fset_window_configuration):
4363 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
4364 (Fset_window_hscroll, run_window_configuration_change_hook)
4365 (set_window_buffer, temp_output_buffer_show, scroll_command)
4366 (Fscroll_other_window, Frecenter):
4367 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
4368 (Fwindow_line_height, window_scroll, Fscroll_left, Fscroll_right):
4369 Don't assume fixnum fits in int.
4370 (Fset_window_scroll_bars):
4371 Check that fixnums are in proper range for system types.
4372 * xdisp.c (help_echo_pos, pos_visible_p, string_pos_nchars_ahead)
4373 (string_pos, c_string_pos, number_of_chars, init_iterator)
4374 (in_ellipses_for_invisible_text_p, init_from_display_pos)
4375 (compute_stop_pos, next_overlay_change, compute_display_string_pos)
4376 (compute_display_string_end, handle_face_prop)
4377 (face_before_or_after_it_pos, handle_invisible_prop)
4378 (handle_display_prop, handle_display_spec, handle_single_display_spec)
4379 (display_prop_intangible_p, string_buffer_position_lim)
4380 (string_buffer_position, handle_composition_prop, load_overlay_strings)
4381 (get_overlay_strings_1, get_overlay_strings)
4382 (iterate_out_of_display_property, forward_to_next_line_start)
4383 (back_to_previous_visible_line_start, reseat, reseat_to_string)
4384 (get_next_display_element, set_iterator_to_next)
4385 (get_visually_first_element, compute_stop_pos_backwards)
4386 (handle_stop_backwards, next_element_from_buffer)
4387 (move_it_in_display_line_to, move_it_in_display_line)
4388 (move_it_to, move_it_vertically_backward, move_it_by_lines)
4389 (add_to_log, message_dolog, message_log_check_duplicate)
4390 (message2, message2_nolog, message3, message3_nolog
4391 (with_echo_area_buffer, display_echo_area_1, resize_mini_window_1)
4392 (current_message_1, truncate_echo_area, truncate_message_1)
4393 (set_message, set_message_1, store_mode_line_noprop)
4394 (hscroll_window_tree, debug_delta, debug_delta_bytes, debug_end_vpos)
4395 (text_outside_line_unchanged_p, check_point_in_composition)
4396 (reconsider_clip_changes)
4397 (redisplay_internal, set_cursor_from_row, try_scrolling)
4398 (try_cursor_movement, set_vertical_scroll_bar, redisplay_window)
4399 (redisplay_window, find_last_unchanged_at_beg_row)
4400 (find_first_unchanged_at_end_row, row_containing_pos, try_window_id)
4401 (trailing_whitespace_p, find_row_edges, display_line)
4402 (RECORD_MAX_MIN_POS, Fcurrent_bidi_paragraph_direction)
4403 (display_mode_element, store_mode_line_string)
4404 (pint2str, pint2hrstr, decode_mode_spec)
4405 (display_count_lines, display_string, draw_glyphs)
4406 (x_produce_glyphs, x_insert_glyphs)
4407 (rows_from_pos_range, mouse_face_from_buffer_pos)
4408 (fast_find_string_pos, mouse_face_from_string_pos)
4409 (note_mode_line_or_margin_highlight, note_mouse_highlight):
4410 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
4411 (safe_call, init_from_display_pos, handle_fontified_prop)
4412 (handle_single_display_spec, load_overlay_strings)
4413 (with_echo_area_buffer, setup_echo_area_for_printing)
4414 (display_echo_area, echo_area_display)
4415 (x_consider_frame_title, prepare_menu_bars, update_menu_bar)
4416 (update_tool_bar, hscroll_window_tree, redisplay_internal)
4417 (redisplay_window, dump_glyph_row, display_mode_line)
4418 (Fformat_mode_line, decode_mode_spec, on_hot_spot_p):
4419 (handle_display_spec, display_prop_string_p):
4420 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
4421 (handle_single_display_spec, build_desired_tool_bar_string)
4422 (redisplay_tool_bar, scroll_window_tree, Fdump_glyph_matrix)
4423 (get_specified_cursor_type):
4424 Check that fixnums are in proper range for system types.
4425 (struct overlay_entry, resize_mini_window, Fdump_glyph_row)
4426 (Flookup_image_map):
4427 Don't assume fixnums fit in int.
4428 (compare_overlay_entries):
4429 Avoid mishandling comparisons due to subtraction overflow.
4430 (load_overlay_strings): Use SAFE_NALLOCA, not alloca.
4431 (last_escape_glyph_face_id, last_glyphless_glyph_face_id):
4432 (handle_tool_bar_click):
4433 Use int, not unsigned, since we prefer signed and the signedness
4434 doesn't matter here.
4435 (get_next_display_element, next_element_from_display_vector):
4436 Use int, not EMACS_INT, when int is wide enough.
4437 (start_hourglass): Use duration_to_sec_usec to do proper
4438 overflow checking on durations.
4439 * xfaces.c (Fbitmap_spec_p):
4440 Check that fixnums are in proper range for system types.
4441 (compare_fonts_by_sort_order):
4442 Avoid mishandling comparisons due to subtraction overflow.
4443 (Fx_family_fonts, realize_basic_faces):
4444 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
4446 Don't assume fixnum fits in int.
4447 Use SAFE_ALLOCA_LISP, not alloca.
4448 (merge_face_heights): Remove unnecessary cast to EMACS_INT.
4449 (Finternal_make_lisp_face): Don't allocate more than MAX_FACE_ID.
4450 (face_at_buffer_position, face_for_overlay_string)
4451 (face_at_string_position):
4452 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
4453 (merge_faces): Use int, not EMACS_INT, where int is wide enough.
4454 * xfns.c (x_set_menu_bar_lines, x_set_tool_bar_lines, x_icon_verify)
4456 Check that fixnums are in proper range for system types.
4457 (Fx_create_frame, x_create_tip_frame, Fx_show_tip)
4458 (Fx_hide_tip, Fx_file_dialog, Fx_select_font):
4459 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
4460 (Fx_change_window_property): Don't assume fixnums fit in int.
4461 * xfont.c (xfont_chars_supported):
4462 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
4463 * xmenu.c (Fx_popup_dialog, set_frame_menubar)
4464 (create_and_show_popup_menu, create_and_show_dialog, xmenu_show):
4465 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
4466 * xml.c (parse_region):
4467 * xrdb.c (magic_file_p):
4468 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
4469 * xselect.c (TRACE1): Don't assume pid_t promotes to int.
4470 (x_get_local_selection, x_reply_selection_request)
4471 (x_handle_selection_request, wait_for_property_change):
4472 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
4473 (selection_data_to_lisp_data): Use short, not EMACS_INT, where
4474 short is wide enough.
4475 (x_send_client_event): Don't assume fixnum fits in int.
4476 * xterm.c (x_x_to_emacs_modifiers):
4477 Don't assume EMACS_INT overflows nicely into int.
4478 (x_emacs_to_x_modifiers): Use EMACS_INT, not int, because values
4480 (handle_one_xevent): NATNUMP can eval its arg twice.
4481 (x_connection_closed):
4482 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
4483 * xterm.h: Adjust decls to match defn changes elsewhere.
4484 (struct scroll_bar): Use struct vectorlike_header
4485 rather than rolling our own approximation.
4486 (SCROLL_BAR_VEC_SIZE): Remove; not used.
4488 2012-05-25 Glenn Morris <rgm@gnu.org>
4490 * lisp.mk (lisp): Update for more files being compiled now.
4492 2012-05-25 Stefan Monnier <monnier@iro.umontreal.ca>
4494 * lread.c: Remove `read_pure' which makes no difference.
4495 (read_pure): Remove var.
4496 (unreadpure): Remove function.
4497 (readevalloop): Don't call read_list with -1 flag.
4498 (read1, read_vector): Don't test read_pure any more.
4499 (read_list): Simplify.
4501 * fileio.c, character.h: Minor style tweaks.
4503 2012-05-24 Dmitry Antipov <dmantipov@yandex.ru>
4505 * window.h (clip_changed): Remove useless declaration.
4507 2012-05-22 Juanma Barranquero <lekktu@gmail.com>
4509 * makefile.w32-in: Follow-up to 2012-05-22T16:20:27Z!eggert@cs.ucla.edu.
4510 (TAGS, TAGS-gmake, CONFIG_H): Remove further references to m/intel386.h.
4512 2012-05-22 Paul Eggert <eggert@cs.ucla.edu>
4515 This directory predates autoconf and is no longer needed nowadays.
4516 Move its few remaining bits of functionality to where they're needed.
4517 * m/README, m/alpha.h, m/amdx86-64.h, m/ia64.h, m/ibmrs6000.h:
4518 * m/ibms390x.h, m/intel386.h, m/m68k.h, m/macppc.h, m/sparc.h:
4519 * m/template.h: Remove.
4520 * Makefile.in (M_FILE): Remove. All uses removed.
4521 * alloc.c (POINTERS_MIGHT_HIDE_IN_OBJECTS):
4522 * lisp.h (USE_LSB_TAG):
4523 * mem-limits.h (EXCEEDS_LISP_PTR):
4524 Use VAL_MAX, not VALBITS, in #if.
4525 * lisp.h (EMACS_INT_MAX): New macro, useful in #if.
4526 (EMACS_UINT): Define unconditionally now.
4527 (BITS_PER_CHAR, BITS_PER_SHORT, BITS_PER_INT, BITS_PER_LONG)
4528 (BITS_PER_EMACS_INT): New constants, replacing
4529 what used to be in config.h, but not useful in #if.
4530 (GCTYPEBITS, VALBITS): Define unconditionally, since m/* files don't
4531 define them any more.
4532 (VAL_MAX): New macro.
4534 * puresize.h (PURESIZE_RATIO): Use EMACS_INT_MAX, not
4535 BITS_PER_EMACS_INT, in #if.
4536 * s/aix4-2.h (BROKEN_FIONREAD, BROKEN_SIGAIO, BROKEN_SIGPTY)
4537 (BROKEN_SIGPOLL): Move here from m/ibmrs6000.h, which was removed.
4538 * s/gnu-linux.h (ULIMIT_BREAK_VALUE) [__i386__]:
4539 * s/ms-w32.h (DATA_START):
4540 Move here from removed file m/intel386.h.
4541 * s/gnu.h (NLIST_STRUCT): Remove undef; 'configure' does this.
4542 * s/irix6-5.h (_LP64): Remove; lisp.h no longer needs this.
4544 2012-05-21 Paul Eggert <eggert@cs.ucla.edu>
4546 Assume C89 or later.
4547 * alloc.c, buffer.c, lisp.h: Replace POINTER_TYPE with void.
4548 * alloc.c (overrun_check_malloc, overrun_check_realloc, xmalloc)
4550 * buffer.c (mmap_free_1, mmap_enlarge): Omit needless casts.
4551 * editfns.c, fns.c, gmalloc.c, insdel.c, sysdep.c, termcap.c (NULL):
4552 * textprop.c, tparam.c (NULL): Remove.
4553 * ralloc.c, vm-limit.c (POINTER): Assume void * works.
4554 * regex.c (SIGN_EXTEND_CHAR): Assume signed char works.
4555 * regex.h (_RE_ARGS): Remove. All uses rewritten to use prototypes.
4556 * unexelf.c (ElfBitsW): Assume c89 preprocessor or better.
4557 * xterm.c (input_signal_count): Assume volatile works.
4559 2012-05-21 Ken Brown <kbrown@cornell.edu>
4561 * xgselect.c (xg_select): Fix first argument in call to 'select'
4564 2012-05-20 Ken Brown <kbrown@cornell.edu>
4566 * gmalloc.c (_free_internal_nolock, _realloc_internal_nolock)
4567 [CYGWIN]: Cast ptr to (char *) before comparing to _heapbase.
4569 2012-05-19 Ken Brown <kbrown@cornell.edu>
4571 * xfns.c (x_in_use): Remove `static' qualifier.
4572 * xterm.h (x_in_use): Declare.
4573 * xgselect.c: Include xterm.h.
4574 (xg_select): Test `x_in_use' instead of `inhibit_window_system'
4575 and `display_arg' (bug#9754).
4577 2012-05-19 Paul Eggert <eggert@cs.ucla.edu>
4579 * s/ms-w32.h (HAVE_GETDOMAINNAME): Remove; not needed.
4581 * m/vax.h: Remove; no longer needed since HAVE_FTIME is being removed.
4582 * s/ms-w32.h (HAVE_FTIME): Remove; not needed.
4584 2012-05-18 Eli Zaretskii <eliz@gnu.org>
4586 Fix compilation with -DGLYPH_DEBUG=1 on MS-Windows.
4588 * w32term.c [GLYPH_DEBUG]: Add prototype for x_check_font.
4589 (x_check_font) [GLYPH_DEBUG]: New function, copied from xterm.c.
4591 * w32fns.c (unwind_create_frame) [GLYPH_DEBUG]: Fix broken
4592 reference to image_cache->refcount.
4593 (x_create_tip_frame): Fix broken use of FRAME_IMAGE_CACHE.
4595 2012-05-17 Juri Linkov <juri@jurta.org>
4597 * search.c (Fword_search_regexp, Fword_search_backward)
4598 (Fword_search_forward, Fword_search_backward_lax)
4599 (Fword_search_forward_lax): Move functions to isearch.el
4600 (bug#10145, bug#11381).
4602 2012-05-16 Paul Eggert <eggert@cs.ucla.edu>
4604 * xgselect.c (xg_select): Just invoke 'select' if -nw (Bug#9754).
4606 2012-05-15 Stefan Monnier <monnier@iro.umontreal.ca>
4608 * lread.c (init_obarray): Declare Qt and Qnil as special.
4610 2012-05-14 Glenn Morris <rgm@gnu.org>
4612 * nsterm.m (ns_init_paths): Fix typo ("libexec" not "lib-exec").
4613 Put "libexec" before "bin", for the sake of init_callproc_1.
4615 2012-05-14 Paul Eggert <eggert@cs.ucla.edu>
4617 * keyboard.c (kbd_buffer_get_event) [!HAVE_DBUS]: Omit unused local.
4619 * unexaix.c: Port to more-recent AIX compilers.
4620 (report_error, report_error_1, make_hdr, copy_sym)
4621 (mark_x, adjust_lnnoptrs, unrelocate_symbols):
4622 Make arguments const char *, not char *, to avoid violations of C
4623 standard and to fix some AIX warnings reported by Gilles Pion.
4625 2012-05-14 Eli Zaretskii <eliz@gnu.org>
4627 * xdisp.c (handle_stop): Don't call get_overlay_strings_1 if we
4628 already have overlays loaded.
4629 (handle_single_display_spec): Before returning without displaying
4630 fringe bitmap, synchronize the bidi iterator with the main display
4631 iterator, by calling iterate_out_of_display_property.
4632 (iterate_out_of_display_property): Detect buffer iteration by
4633 testing that it->string is a Lisp string.
4634 (get_next_display_element): When the current object is exhausted,
4635 and there's something on it->stack, call set_iterator_to_next to
4636 proceed with what's on the stack, instead of returning zero.
4637 (set_iterator_to_next): If called at the end of a Lisp string,
4638 proceed to consider_string_end without incrementing string
4639 position. Don't increment display vector index past the end of
4640 the display vector. (Bug#11417)
4641 (pos_visible_p): Don't report a position visible when move_it_to
4642 stopped at the last line of window, which happens to be scanned
4643 backwards by the bidi iteration. (Bug#11464)
4645 2012-05-14 Eli Zaretskii <eliz@gnu.org>
4647 * xdisp.c (handle_single_display_spec): Return 1 for left-margin
4648 and right-margin display specs even if the spec is invalid or we
4649 are on a TTY, and thus unable to display on the fringes.
4650 That's because the text with the property will not be displayed anyway,
4651 so we need to signal to the caller that this is a "replacing"
4652 display spec. This fixes display when the spec is invalid or we
4655 2012-05-14 Paul Eggert <eggert@cs.ucla.edu>
4657 * unexaix.c (make_hdr): Fix typo in prototype.
4658 This bug broke the build on AIX. Problem reported by Gilles Pion.
4660 2012-05-14 Michael Albinus <michael.albinus@gmx.de>
4662 * keyboard.c (kbd_buffer_get_event): Read special events also in
4663 batch mode. (Bug#11415)
4665 2012-05-12 Glenn Morris <rgm@gnu.org>
4667 * ns.mk: Update for ns_appbindir no longer having trailing "/".
4669 2012-05-12 Eli Zaretskii <eliz@gnu.org>
4671 * lisp.mk (lisp): Add newcomment.elc.
4673 2012-05-12 Glenn Morris <rgm@gnu.org>
4675 * Makefile.in (MKDIR_P): New, set by configure.
4676 * ns.mk (${ns_appdir}, ${ns_appbindir}Emacs): Use $MKDIR_P.
4678 2012-05-11 Paul Eggert <eggert@cs.ucla.edu>
4680 Remove unused function hourglass_started.
4681 * dispextern.h (hourglass_started):
4682 * w32fns.c (hourglass_started):
4683 * xdisp.c (hourglass_started): Remove.
4685 2012-05-10 Juanma Barranquero <lekktu@gmail.com>
4687 * makefile.w32-in ($(BLD)/gmalloc.$(O), $(BLD)/w32menu.$(O)):
4688 Update dependencies.
4690 2012-05-10 Paul Eggert <eggert@cs.ucla.edu>
4692 * xgselect.c (xg_select): Put maxfds+1 into a var.
4693 This is slightly clearer, and pacifies Ubuntu 12.04 gcc.
4695 * sound.c (DEFAULT_ALSA_SOUND_DEVICE): Define only if HAVE_ALSA.
4697 2012-05-10 Dave Abrahams <dave@boostpro.com>
4699 * filelock.c (syms_of_filelock): New boolean create-lockfiles.
4700 (lock_file): If create_lockfiles is 0, do nothing. (Bug#11227)
4702 2012-05-09 Michael Albinus <michael.albinus@gmx.de>
4704 * dbusbind.c (xd_registered_buses): New internal Lisp object.
4705 Rename all occurences of Vdbus_registered_buses to xd_registered_buses.
4706 (syms_of_dbusbind): Remove declaration of Vdbus_registered_buses.
4707 Initialize xd_registered_buses.
4709 2012-05-09 Paul Eggert <eggert@cs.ucla.edu>
4711 Untag more efficiently if USE_LSB_TAG.
4712 This is based on a proposal by YAMAMOTO Mitsuharu in
4713 <http://lists.gnu.org/archive/html/emacs-devel/2008-01/msg01876.html>.
4714 For an admittedly artificial (nth 8000 longlist) benchmark on
4715 Fedora 15 x86-64, this yields a 25% CPU speedup. Also, it shrinks
4716 Emacs's overall text size by 1%.
4717 * lisp.h (XUNTAG): New macro.
4718 (XCONS, XVECTOR, XSTRING, XSYMBOL, XFLOAT, XMISC, XPROCESS, XWINDOW)
4719 (XTERMINAL, XSUBR, XBUFFER, XCHAR_TABLE, XSUB_CHAR_TABLE, XBOOL_VECTOR)
4720 (XSETTYPED_PSEUDOVECTOR, XHASH_TABLE, TYPED_PSEUDOVECTORP): Use it.
4721 * eval.c (Fautoload):
4722 * font.h (XFONT_SPEC, XFONT_ENTITY, XFONT_OBJECT):
4723 * frame.h (XFRAME): Use XUNTAG.
4725 Port recent dbusbind.c changes to 32-bit --with-wide-int.
4726 * dbusbind.c (xd_append_arg, xd_retrieve_arg, Fdbus_message_internal):
4727 Remove unportable assumptions about print widths of types like
4729 (xd_get_connection_address, Fdbus_init_bus): Cast Emacs integer to
4730 intptr_t when converting between pointer and integer, to avoid GCC
4731 warnings about wrong width.
4733 2012-05-09 Eli Zaretskii <eliz@gnu.org>
4735 * w32proc.c (new_child): Force Windows to reserve only 64KB of
4736 stack for each reader_thread, instead of defaulting to 8MB
4737 determined by the linker. This avoids failures in creating
4738 subprocesses on Windows 7, see the discussion in this thread:
4739 http://lists.gnu.org/archive/html/emacs-devel/2012-03/msg00119.html.
4741 2012-05-07 Jérémy Compostella <jeremy.compostella@gmail.com>
4743 Fix up display of the *Minibuf-0* buffer in the mini window.
4744 * keyboard.c (read_char): Don't clear the echo area if there's no
4746 * xdisp.c (redisplay_internal): Redisplay the mini window (with the
4747 contents of *Minibuf-0*) if there's no message displayed in its stead.
4749 2012-05-07 Michael Albinus <michael.albinus@gmx.de>
4751 * dbusbind.c (XD_DEBUG_MESSAGE): Don't print message twice in
4754 2012-05-06 Chong Yidong <cyd@gnu.org>
4756 * lisp.mk (lisp): Update.
4758 2012-05-05 Jim Meyering <meyering@redhat.com>
4760 * w32font.c (fill_in_logfont): NUL-terminate a string (Bug#11372).
4762 2012-05-04 Stefan Monnier <monnier@iro.umontreal.ca>
4764 * data.c (PUT_ERROR): New macro.
4765 (syms_of_data): Use it. Add new error type `user-error'.
4766 * undo.c (user_error): New function.
4767 (Fprimitive_undo): Use it.
4768 * print.c (print_error_message): Adjust print style for `user-error'.
4769 * keyboard.c (user_error): New function.
4770 (Fexit_recursive_edit, Fabort_recursive_edit): Use it.
4772 2012-05-03 Paul Eggert <eggert@cs.ucla.edu>
4774 Do not limit current-time-string to years 1000..9999.
4775 * editfns.c (TM_YEAR_IN_ASCTIME_RANGE): Remove.
4776 (Fcurrent_time_string): Support any year that is supported by the
4777 underlying localtime representation. Don't use asctime, as it
4778 has undefined behavior for years outside the range -999..9999.
4780 2012-05-02 Paul Eggert <eggert@cs.ucla.edu>
4782 Fix race conditions involving setenv, gmtime, localtime, asctime.
4783 Without this fix, interrupts could mess up code that uses these
4784 nonreentrant functions, since setting TZ invalidates existing
4785 tm_zone or tzname values, and since most of these functions return
4786 pointers to static storage.
4787 * editfns.c (format_time_string, Fdecode_time, Fencode_time)
4788 (Fcurrent_time_string, Fcurrent_time_zone, Fset_time_zone_rule):
4789 Grow the critical sections to include not just invoking
4790 localtime/gmtime, but also accessing these functions' results
4791 including their tm_zone values if any, and any related TZ setting.
4792 (format_time_string): Last arg is now struct tm *, not struct tm **,
4793 so that the struct tm is saved in the critical section.
4794 All callers changed. Simplify allocation of initial buffer, partly
4795 motivated by the fact that memory allocation needs to be outside
4796 the critical section.
4798 2012-05-02 Dmitry Antipov <dmantipov@yandex.ru>
4800 * intervals.c (adjust_intervals_for_insertion): Initialize `newi'
4801 with RESET_INTERVAL.
4803 * buffer.c (Fget_buffer_create, Fmake_indirect_buffer):
4804 Remove duplicated buffer name initialization.
4806 2012-05-02 Jim Meyering <jim@meyering.net>
4808 * xterm.c (x_term_init): Use memcpy instead of strncpy (Bug#11373).
4810 * xfns.c (x_window): Use xstrdup (Bug#11375).
4812 2012-05-02 Eli Zaretskii <eliz@gnu.org>
4814 * xdisp.c (pos_visible_p): If already at a newline from the
4815 display string before the 'while' loop, don't walk back the glyphs
4816 from it3.glyph_row. Solves assertion violation when the display
4817 string begins with a newline (egg.el). (Bug#11367)
4819 2012-05-01 Stefan Monnier <monnier@iro.umontreal.ca>
4821 * keyboard.c (Fexecute_extended_command, Vsuggest_key_bindings):
4824 2012-05-01 Glenn Morris <rgm@gnu.org>
4826 * syssignal.h: Remove reference to BROKEN_SIGINFO (last used in
4827 s/ptx4.h), BROKEN_SIGTSTP (last used in m/ustation.h, m/dpx2.h),
4828 and BROKEN_SIGURG (was in s/gnu-linux.h prior to 2008-02-10).
4829 All were removed before 23.1.
4831 * dispnew.c: Remove HAVE_LIBNCURSES test;
4832 it is always true on relevant platforms.
4834 * Makefile.in (LD_SWITCH_X_SITE_RPATH):
4835 Rename from LD_SWITCH_X_SITE_AUX_RPATH.
4837 * Makefile.in (LD_SWITCH_X_SITE_AUX): Remove; no longer used.
4839 2012-04-30 Andreas Schwab <schwab@linux-m68k.org>
4841 * .gdbinit (xpr): Remove checks for no longer existing misc types.
4842 (xintfwd, xboolfwd, xobjfwd, xbufobjfwd, xkbobjfwd, xbuflocal):
4845 2012-04-28 Paul Eggert <eggert@cs.ucla.edu>
4847 Do not avoid creating empty evaporating overlays (Bug#9642).
4848 * buffer.c (Fmove_overlay): Revert the change of 2012-04-23.
4849 That is, do not delete an evaporating overlay if it becomes
4850 empty after its bounds are adjusted to fit within its buffer.
4851 This fix caused other problems, and I'm reverting it until we get
4852 to the bottom of them.
4854 2012-04-27 Chong Yidong <cyd@gnu.org>
4856 * xselect.c (x_convert_selection): Initialize a pointer (Bug#11315).
4858 2012-04-27 Eli Zaretskii <eliz@gnu.org>
4860 * xdisp.c (pos_visible_p): If the window start position is beyond
4861 ZV, start the display from buffer beginning. Prevents assertion
4862 violation in init_iterator when the minibuffer window is scrolled
4865 * window.c (window_scroll_pixel_based): Likewise.
4867 2012-04-27 Chong Yidong <cyd@gnu.org>
4869 * keymap.c (where_is_internal): Doc fix (Bug#10872).
4871 2012-04-27 Glenn Morris <rgm@gnu.org>
4873 * fileio.c (Fcopy_file, Fset_file_selinux_context):
4874 Ignore ENOTSUP failures from setfilecon functions. (Bug#11245)
4876 2012-04-27 Eli Zaretskii <eliz@gnu.org>
4878 * dispnew.c (swap_glyph_pointers, copy_row_except_pointers):
4879 Don't overrun array limits of glyph row's used[] array. (Bug#11288)
4881 2012-04-26 Eli Zaretskii <eliz@gnu.org>
4883 * xdisp.c (IT_DISPLAYING_WHITESPACE): In addition to the loaded
4884 display element, check also the underlying string or buffer
4885 character. (Bug#11341)
4887 * w32menu.c: Include w32heap.h.
4888 (add_menu_item): If the call to AppendMenuW (via
4889 unicode_append_menu) fails, disable Unicode menus only if we are
4890 running on Windows 9X/Me.
4892 2012-04-24 Andreas Schwab <schwab@linux-m68k.org>
4894 * .gdbinit (xpr): Handle USE_2_TAGS_FOR_INTS.
4895 (xgetint): Add missing shift for LSB tags.
4897 2012-04-24 Martin Rudalics <rudalics@gmx.at>
4899 * keyboard.c (read_char): Don't wipe echo area for select window
4900 events: These might get delayed via `mouse-autoselect-window'
4903 2012-04-24 Juanma Barranquero <lekktu@gmail.com>
4905 * gnutls.c (init_gnutls_functions): Protect against (unlikely)
4906 manipulation of :loaded-from data.
4908 2012-04-23 Juanma Barranquero <lekktu@gmail.com>
4910 * gnutls.c (init_gnutls_functions): The value of :loaded-from is
4911 now a cons (bug#11311).
4913 2012-04-23 Paul Eggert <eggert@cs.ucla.edu>
4915 Do not create empty overlays with the evaporate property (Bug#9642).
4916 * buffer.c (Fmove_overlay): Delete an evaporating overlay
4917 if it becomes empty after its bounds are adjusted to fit within
4918 its buffer. Without this fix, in a nonempty buffer (let ((o
4919 (make-overlay 1 2))) (overlay-put o 'evaporate t) (move-overlay o 0 1))
4920 yields an empty overlay that has the evaporate property, which is
4921 not supposed to happen.
4923 Fix minor GTK3 problems found by static checking.
4924 * emacsgtkfixed.c (EMACS_TYPE_FIXED, EMACS_FIXED, EmacsFixed)
4925 (EmacsFixedPrivate, EmacsFixedClass, struct _EmacsFixed)
4926 (struct _EmacsFixedClass, emacs_fixed_get_type):
4927 Move decls here from emacsgtkfixed.h, since they needn't be public.
4928 (emacs_fixed_get_type): Now static.
4929 (emacs_fixed_class_init): Omit unused local.
4930 (emacs_fixed_child_type): Remove; unused.
4931 * emacsgtkfixed.h (EMACS_TYPE_FIXED, EMACS_FIXED, EmacsFixed)
4932 (EmacsFixedPrivate, EmacsFixedClass, struct _EmacsFixed)
4933 (struct _EmacsFixedClass): Move to emacsgtkfixed.c.
4934 (EMACS_FIXED_CLASS, EMACS_IS_FIXED, EMACS_IS_FIXED_CLASS)
4935 (EMACS_FIXED_GET_CLASS): Remove; unused.
4936 * gtkutil.c (xg_create_frame_widgets) [!HAVE_GTK3]: Omit unused local.
4938 * keyboard.c (handle_async_input): Define only if SYNC_INPUT || SIGIO.
4939 Problem reported by Juanma Barranquero for Windows -Wunused-function.
4941 2012-04-22 Paul Eggert <eggert@cs.ucla.edu>
4943 Modernize and clean up gmalloc.c to assume C89 (Bug#9119).
4944 * gmalloc.c (_MALLOC_INTERNAL, _MALLOC_H, _PP, __ptr_t)
4945 (__malloc_size_t, __malloc_ptrdiff_t):
4946 Remove. All uses removed, replaced by the definiens if needed,
4947 since we can assume C89 or better now.
4948 Include <stdint.h>, for PTRDIFF_MAX, uintptr_t.
4949 (protect_malloc_state, align, get_contiguous_space)
4950 (malloc_atfork_handler_prepare, malloc_atfork_handler_parent)
4951 (malloc_atfork_handler_child, malloc_enable_thread)
4952 (malloc_initialize_1, __malloc_initialize, morecore_nolock)
4953 (_malloc_internal_nolock, _malloc_internal, malloc, _malloc)
4954 (_free, _realloc, _free_internal_nolock, _free_internal, free, cfree)
4955 (special_realloc, _realloc_internal_nolock, _realloc_internal)
4956 (realloc, calloc, __default_morecore, memalign, valloc, checkhdr)
4957 (freehook, mallochook, reallochook, mabort, mcheck, mprobe):
4958 Define using prototypes, not old style.
4959 (align, _malloc_internal_nolock, _free_internal_nolock, memalign):
4960 Don't assume ptrdiff_t and uintptr_t are no wider than unsigned long.
4961 (align): Don't assume that signed integer overflow wraps around.
4962 Omit unused local var.
4963 (malloc_initialize_1, morecore_nolock, _malloc_internal_nolock)
4964 (_free_internal_nolock, memalign, mallochook, reallochook):
4965 Omit no-longer-needed casts.
4966 (valloc): Use getpagesize, not __getpagesize.
4967 (MAGICWORD, MAGICFREE): Now randomish size_t values, not 32-bit.
4968 (struct hdr): The 'magic' member is now size_t, not unsigned long.
4970 * dbusbind.c (XD_DBUS_VALIDATE_OBJECT): Define only if needed.
4972 2012-04-22 Michael Albinus <michael.albinus@gmx.de>
4974 Move functions from C to Lisp. Make non-blocking method calls
4975 the default. Implement further D-Bus standard interfaces.
4977 * dbusbind.c (DBUS_NUM_MESSAGE_TYPES): Declare.
4978 (QCdbus_request_name_allow_replacement)
4979 (QCdbus_request_name_replace_existing)
4980 (QCdbus_request_name_do_not_queue)
4981 (QCdbus_request_name_reply_primary_owner)
4982 (QCdbus_request_name_reply_in_queue)
4983 (QCdbus_request_name_reply_exists)
4984 (QCdbus_request_name_reply_already_owner): Move to dbus.el.
4985 (QCdbus_registered_serial, QCdbus_registered_method)
4986 (QCdbus_registered_signal): New Lisp objects.
4987 (XD_DEBUG_MESSAGE): Use sizeof.
4988 (XD_MESSAGE_TYPE_TO_STRING, XD_OBJECT_TO_STRING)
4989 (XD_DBUS_VALIDATE_BUS_ADDRESS, XD_DBUS_VALIDATE_OBJECT)
4990 (XD_DBUS_VALIDATE_BUS_NAME, XD_DBUS_VALIDATE_PATH)
4991 (XD_DBUS_VALIDATE_INTERFACE, XD_DBUS_VALIDATE_MEMBER): New macros.
4992 (XD_CHECK_DBUS_SERIAL): Rename from CHECK_DBUS_SERIAL_GET_SERIAL.
4993 (xd_signature, xd_append_arg): Allow float for integer types.
4994 (xd_get_connection_references): New function.
4995 (xd_get_connection_address): Rename from xd_initialize.
4996 Return cached address.
4997 (xd_remove_watch): Do not unset $DBUS_SESSION_BUS_ADDRESS.
4998 (xd_close_bus): Rename from Fdbus_close_bus. Not needed on Lisp
5000 (Fdbus_init_bus): New optional arg PRIVATE. Cache address.
5001 Return number of refcounts.
5002 (Fdbus_get_unique_name): Make stronger parameter check.
5003 (Fdbus_message_internal): New defun.
5004 (Fdbus_call_method, Fdbus_call_method_asynchronously)
5005 (Fdbus_method_return_internal, Fdbus_method_error_internal)
5006 (Fdbus_send_signal, Fdbus_register_service)
5007 (Fdbus_register_signal, Fdbus_register_method): Move to dbus.el.
5008 (xd_read_message_1): Obey new structure of Vdbus_registered_objects.
5009 (xd_read_queued_messages): Obey new structure of Vdbus_registered_buses.
5010 (Vdbus_compiled_version, Vdbus_runtime_version)
5011 (Vdbus_message_type_invalid, Vdbus_message_type_method_call)
5012 (Vdbus_message_type_method_return, Vdbus_message_type_error)
5013 (Vdbus_message_type_signal): New defvars.
5014 (Vdbus_registered_buses, Vdbus_registered_objects_table):
5017 2012-04-22 Paul Eggert <eggert@cs.ucla.edu>
5019 Fix GC_MALLOC_CHECK debugging output on 64-bit hosts.
5020 * alloc.c (emacs_blocked_malloc) [GC_MALLOC_CHECK]:
5021 Do not assume ptrdiff_t is the same width as 'int'.
5023 * alloc.c: Handle unusual debugging option combinations.
5024 (GC_CHECK_MARKED_OBJECTS): Undef if ! GC_MARK_STACK,
5025 since the two debugging options are incompatible.
5026 (GC_MALLOC_CHECK): Similarly, undef if GC_CHECK_MARKED_OBJECTS
5028 (mem_init, mem_insert, mem_insert_fixup):
5029 Define if GC_MARK_STACK || GC_MALLOC_CHECK.
5030 (NEED_MEM_INSERT): Remove; no longer needed.
5032 2012-04-22 Leo Liu <sdl.web@gmail.com>
5034 * sysdep.c (list_system_processes): Support Darwin (Bug#5725).
5036 2012-04-22 Paul Eggert <eggert@cs.ucla.edu>
5038 * sysdep.c [__FreeBSD__]: Minor cleanups.
5039 (list_system_processes, system_process_attributes) [__FreeBSD__]:
5040 Use Emacs indenting style more consistently. Avoid some casts.
5041 Use 'double' consistently rather than mixing 'float' and 'double'.
5043 2012-04-21 Eduard Wiebe <usenet@pusto.de>
5045 * sysdep.c (list_system_processes, system_process_attributes):
5046 Add implementation for FreeBSD (Bug#5243).
5048 2012-04-21 Andreas Schwab <schwab@linux-m68k.org>
5050 * lisp.mk (lisp): Update.
5052 2012-04-20 Paul Eggert <eggert@cs.ucla.edu>
5054 * keyboard.c (process_pending_signals): Define only if SYNC_INPUT.
5055 It is never used otherwise.
5057 2012-04-20 Stefan Monnier <monnier@iro.umontreal.ca>
5059 * print.c (print_preprocess): Only check print_depth if print-circle
5061 (print_object): Check for cycles even when print-circle is nil and
5062 print-gensym is t, but only check print_depth if print-circle is nil.
5064 2012-04-20 Chong Yidong <cyd@gnu.org>
5066 * process.c (wait_reading_process_output): If EIO occurs on a pty,
5067 set the status to "failed" and ensure that sentinel is run.
5069 2012-04-20 Glenn Morris <rgm@gnu.org>
5071 * process.c (Fset_process_inherit_coding_system_flag)
5072 (Fset_process_query_on_exit_flag): Doc fix (mention return value).
5073 (Fmake_network_process, Fmake_serial_process): Doc fix.
5075 2012-04-20 Eli Zaretskii <eliz@gnu.org>
5077 * xdisp.c (string_buffer_position_lim): Limit starting position to
5079 (set_cursor_from_row): If called for a mode-line or header-line
5080 row, return zero immediately.
5081 (try_cursor_movement): If inside continuation line, don't back up
5082 farther than the first row after the header line, if any.
5083 Don't consider the header-line row as "partially visible", even if
5084 MATRIX_ROW_PARTIALLY_VISIBLE_P returns non-zero. (Bug#11261)
5086 2012-04-20 Atsuo Ohki <ohki@gssm.otsuka.tsukuba.ac.jp> (tiny change)
5088 * lread.c (lisp_file_lexically_bound_p): Fix hang at ";-*-\n"
5091 2012-04-20 Teodor Zlatanov <tzz@lifelogs.com>
5092 2012-04-18 Paul Eggert <eggert@cs.ucla.edu>
5094 configure: new option --enable-gcc-warnings (Bug#11207)
5095 * Makefile.in (C_WARNINGS_SWITCH): Remove.
5096 (WARN_CFLAGS, WERROR_CFLAGS): New macros.
5097 (ALL_CFLAGS): Use new macros rather than old.
5098 * process.c: Ignore -Wstrict-overflow to work around GCC bug 52904.
5099 * regex.c: Ignore -Wstrict-overflow. If !emacs, also ignore
5100 -Wunused-but-set-variable, -Wunused-function, -Wunused-macros,
5101 -Wunused-result, -Wunused-variable. This should go away once
5102 the Emacs and Gnulib regex code is merged.
5103 (xmalloc, xrealloc): Now static.
5105 2012-04-17 Paul Eggert <eggert@cs.ucla.edu>
5107 * dired.c (Fsystem_groups): Remove unused local.
5109 2012-04-17 Glenn Morris <rgm@gnu.org>
5111 * dired.c (Fsystem_users): Doc fix.
5113 2012-04-17 Dmitry Antipov <dmantipov@yandex.ru>
5115 * dired.c (Fsystem_users, Fsystem_groups): New functions. (Bug#7900)
5116 (syms_of_dired): Add them.
5118 2012-04-16 Paul Eggert <eggert@cs.ucla.edu>
5120 Fix minor alloc.c problems found by static checking.
5121 * alloc.c (_malloc_internal, _free_internal) [!DOUG_LEA_MALLOC]:
5122 New extern decls, to avoid calling undeclared functions.
5123 (dont_register_blocks): Define if ((!SYSTEM_MALLOC && !SYNC_INPUT)
5124 && GC_MALLOC_CHECK), not if ((GC_MARK_STACK || defined
5125 GC_MALLOC_CHECK) && GC_MALLOC_CHECK), to match when it's used.
5126 (NEED_MEM_INSERT): New macro.
5127 (mem_insert, mem_insert_fixup) [!NEED_MEM_INSERT]: Remove; unused.
5128 Remove one incorrect comment and fix another.
5130 Fix minor ralloc.c problems found by static checking.
5131 See http://lists.gnu.org/archive/html/emacs-devel/2011-12/msg00720.html
5132 * ralloc.c (ALIGNED, ROUND_TO_PAGE, HEAP_PTR_SIZE)
5133 (r_alloc_size_in_use, r_alloc_freeze, r_alloc_thaw): Remove; unused.
5134 (r_alloc_sbrk): Now static.
5136 Improve ralloc.c interface checking.
5137 See http://lists.gnu.org/archive/html/emacs-devel/2011-12/msg00720.html
5138 * buffer.c (ralloc_reset_variable, r_alloc, r_re_alloc)
5139 (r_alloc_free) [REL_ALLOC]: Move decls from here ...
5140 * lisp.h (r_alloc, r_alloc_free, r_re_alloc, r_alloc_reset_variable)
5141 [REL_ALLOC]: ... to here, to check interface.
5142 * m/ia64.h (r_alloc, r_alloc_free) [REL_ALLOC && !_MALLOC_INTERNAL]:
5143 Remove decls. This fixes an "It stinks!".
5145 * alloc.c (which_symbols): Fix alignment issue / type clash.
5147 2012-04-15 Andreas Schwab <schwab@linux-m68k.org>
5149 * lisp.h (struct Lisp_Symbol): Remove explicit padding.
5150 (struct Lisp_Misc_Any): Likewise.
5151 (struct Lisp_Free): Likewise.
5152 * alloc.c (union aligned_Lisp_Symbol): Define.
5153 (SYMBOL_BLOCK_SIZE, struct symbol_block): Use union
5154 aligned_Lisp_Symbol instead of struct Lisp_Symbol.
5155 (union aligned_Lisp_Misc): Define.
5156 (MARKER_BLOCK_SIZE, struct marker_block): Use union
5157 aligned_Lisp_Misc instead of union Lisp_Misc.
5158 (Fmake_symbol, allocate_misc, gc_sweep): Adjust.
5160 2012-04-14 Paul Eggert <eggert@cs.ucla.edu>
5162 Make GC_MAKE_GCPROS_NOOPS the default (Bug#9926).
5163 * lisp.h (GC_MARK_STACK): Default to GC_MAKE_GCPROS_NOOPS.
5164 * s/cygwin.h, s/darwin.h, s/freebsd.h, s/gnu.h, s/irix6-5.h, s/msdos.h:
5165 * s/netbsd.h, s/sol2-6.h:
5166 Remove definition of GC_MARK_STACK, since the default now works.
5167 * s/aix4-2.h, s/hpux10-20.h, s/unixware.h:
5168 Define GC_MARK_STACK to GC_USE_GCPROS_AS_BEFORE, since that's
5169 no longer the default.
5170 * s/gnu-linux.h (GC_MARK_STACK): Adjust to change in default.
5172 2012-04-14 Atsuo Ohki <ohki@gssm.otsuka.tsukuba.ac.jp> (tiny change)
5174 * lread.c (lisp_file_lexically_bound_p):
5175 Fix hang at ";-*-\n" (bug#11238).
5177 2012-04-14 Eli Zaretskii <eliz@gnu.org>
5179 * xdisp.c (find_last_unchanged_at_beg_row): Don't consider a row
5180 "unchanged" if its end.pos is beyond ZV. (Bug#11199)
5182 2012-04-14 Jan Djärv <jan.h.d@swipnet.se>
5184 * nsterm.m (constrainFrameRect): Always constrain when there is only
5185 one screen (Bug#10962).
5187 2012-04-13 Ken Brown <kbrown@cornell.edu>
5189 * s/cygwin.h (PTY_OPEN): Don't try to close a bogus file descriptor.
5191 2012-04-13 Reuben Thomas <rrt@sc3d.org>
5193 * indent.c (Fmove_to_column): Change interactive spec (Bug#739).
5195 2012-04-11 Daniel Colascione <dancol@dancol.org>
5197 * s/cygwin.h: The vfork the #define in cygwin.h was protecting
5198 against is gone. It's better to use vfork now so that when Cygwin
5199 gains a new, working vfork, we use it automatically (bug#10398).
5201 2012-04-11 Stefan Monnier <monnier@iro.umontreal.ca>
5203 * window.c (save_window_save): Obey window-point-insertion-type.
5205 2012-04-11 Glenn Morris <rgm@gnu.org>
5207 * Makefile.in (GNUSTEP_CFLAGS): Rename from C_SWITCH_X_SYSTEM.
5209 2012-04-11 Stefan Monnier <monnier@iro.umontreal.ca>
5211 * alloc.c (lisp_align_malloc): Remove unneeded prototype.
5213 2012-04-10 Jason S. Cornez <jcornez@ravenpack.com> (tiny change)
5215 * keyboard.c: Override inhibit-quit after the third C-g (bug#6585).
5216 (force_quit_count): New var.
5217 (handle_interrupt): Use it.
5219 2012-04-10 Juanma Barranquero <lekktu@gmail.com>
5221 * w32.c (w32_delayed_load): Record the full path of the library
5222 being loaded (bug#10424).
5224 2012-04-09 Glenn Morris <rgm@gnu.org>
5226 * doc.c (Fsnarf_documentation): Check variables, functions are bound,
5227 not just in the obarray, before snarfing them. (Bug#11036)
5229 * Makefile.in ($(leimdir)/leim-list.el):
5230 Pass EMACS rather than BUILT_EMACS.
5232 2012-04-09 Teodor Zlatanov <tzz@lifelogs.com>
5234 * process.c (make_process):
5235 * process.h: Add integer `gnutls_handshakes_tried' member to
5238 * gnutls.h: Add `GNUTLS_EMACS_HANDSHAKES_LIMIT' upper limit.
5239 Add convenience `GNUTLS_LOG2i' macro.
5241 * gnutls.c (gnutls_log_function2i): Convenience log function.
5242 (emacs_gnutls_read): Use new log functions,
5243 `gnutls_handshakes_tried' process member, and
5244 `GNUTLS_EMACS_HANDSHAKES_LIMIT' to limit the number of handshake
5245 attempts per process (connection).
5247 2012-04-09 Chong Yidong <cyd@gnu.org>
5249 * eval.c (Fuser_variable_p, user_variable_p_eh)
5250 (lisp_indirect_variable): Functions deleted.
5251 (Fdefvar): Caller changed.
5253 * callint.c (Finteractive, Fcall_interactively):
5254 * minibuf.c (Fread_variable): Callers changed.
5256 2012-04-09 Eli Zaretskii <eliz@gnu.org>
5258 * xdisp.c (set_cursor_from_row): If the display string appears in
5259 the buffer at position that is closer to point than the position
5260 after the display string, display the cursor on the first glyph of
5261 the display string. Fixes cursor display when a 'display' text
5262 property immediately follows invisible text. (Bug#11094)
5264 2012-04-09 Paul Eggert <eggert@cs.ucla.edu>
5266 composite.c: use 'double' consistently
5267 * composite.c (get_composition_id): Use 'double' consistently
5268 instead of converting 'float' to 'double' and vice versa; this is
5269 easier to understand and avoids a GCC warning.
5271 2012-04-09 Glenn Morris <rgm@gnu.org>
5273 * Makefile.in: Generate leim-list with bootstrap-emacs, in
5274 preparation for dumping it with emacs. (Bug#4789)
5275 (leimdir): New variable.
5276 ($(leimdir)/leim-list.el): New rule.
5277 (emacs$(EXEEXT)): Depend on leim-list.el.
5279 * buffer.c (Qucs_set_table_for_input): Remove. (Bug#9821)
5280 (Fget_buffer_create): Don't call Qucs_set_table_for_input.
5281 (init_buffer_once, syms_of_buffer): Remove Qucs_set_table_for_input.
5283 2012-04-08 Andreas Schwab <schwab@linux-m68k.org>
5285 * lisp.h (struct Lisp_Symbol): Add explicit padding to ensure
5288 2012-04-07 Juanma Barranquero <lekktu@gmail.com>
5290 * xml.c (init_libxml2_functions) [WINDOWSNT]:
5291 Remove unused local variable.
5293 2012-04-07 Paul Eggert <eggert@cs.ucla.edu>
5295 Avoid unnecessary pointer scanning in garbage collection (Bug#10780).
5296 * alloc.c (POINTERS_MIGHT_HIDE_IN_OBJECTS): New macro.
5297 (mark_memory): Mark Lisp_Objects only if pointers might hide in
5298 objects, as mark_maybe_pointer will catch them otherwise.
5299 (GC_LISP_OBJECT_ALIGNMENT): Remove; no longer needed.
5300 * s/gnu-linux.h (GC_LISP_OBJECT_ALIGNMENT) [__mc68000__]: Likewise.
5302 2012-04-07 Paul Eggert <eggert@cs.ucla.edu>
5304 Fix typo that broke non-Windows builds.
5305 * xml.c (libxml2_loaded_p) [!!WINDOWSNT]: 'inine' -> 'inline'.
5307 2012-04-07 Eli Zaretskii <eliz@gnu.org>
5309 Support building on MS-Windows with libxml2.
5311 * makefile.w32-in (OBJ2): Add xml.$(O).
5312 (GLOBAL_SOURCES): Add xml.c.
5313 ($(BLD)/xml.$(O)): New dependency list.
5315 * xml.c (DEF_XML2_FN, LOAD_XML2_FN) [WINDOWSNT]: New macros.
5316 (fn_htmlReadMemory, fn_xmlReadMemory, fn_xmlDocGetRootElement)
5317 (fn_xmlFreeDoc, fn_xmlCleanupParser, fn_xmlCheckVersion)
5318 [!WINDOWSNT]: New macros.
5319 (init_libxml2_functions, libxml2_loaded_p): New functions.
5320 (parse_region): Call fn_xmlCheckVersion instead of using the macro
5321 LIBXML_TEST_VERSION. Call libxml2 functions via the fn_* macros.
5322 (xml_cleanup_parser): New function, export for fn_xmlCleanupParser.
5323 Calls xmlCleanupParser only if libxml2 was loaded (or statically
5325 (Flibxml_parse_html_region, Flibxml_parse_xml_region):
5326 Call init_libxml2_functions before calling libxml2 functions.
5327 (syms_of_xml) <Qlibxml2_dll>: DEFSYM it.
5329 * emacs.c: Don't include libxml/parser.h.
5330 (shut_down_emacs): Call xml_cleanup_parser, instead of calling
5331 xmlCleanupParser directly.
5333 * lisp.h [HAVE_LIBXML2]: Add prototype for xml_cleanup_parser.
5335 2012-04-07 Eli Zaretskii <eliz@gnu.org>
5337 * indent.c (Fvertical_motion): If there is a display string at
5338 point, use it.vpos to compute how many lines to backtrack after
5339 move_it_to point. (Bug#11133)
5341 2012-04-06 Eli Zaretskii <eliz@gnu.org>
5343 * buffer.h (FETCH_CHAR, FETCH_MULTIBYTE_CHAR):
5344 * character.h (STRING_CHAR, STRING_CHAR_AND_LENGTH): Add comments
5345 about subtle differences between FETCH_CHAR* and STRING_CHAR*
5346 macros related to unification of CJK characters. For the details,
5347 see the discussion following the message here:
5348 http://debbugs.gnu.org/cgi/bugreport.cgi?bug=11073#14.
5350 2012-04-04 Chong Yidong <cyd@gnu.org>
5352 * keyboard.c (Vdelayed_warnings_list): Doc fix.
5354 2012-04-01 Eli Zaretskii <eliz@gnu.org>
5356 * w32menu.c (simple_dialog_show, add_menu_item): Use SAFE_ALLOCA
5357 instead of alloca. (Bug#11138)
5359 2012-04-01 Andreas Schwab <schwab@linux-m68k.org>
5361 * w32menu.c (is_simple_dialog): Properly check lisp types.
5364 2012-03-31 Eli Zaretskii <eliz@gnu.org>
5366 * xdisp.c (move_it_by_lines): When DVPOS is positive, and the
5367 position we get to after a call to move_it_to fails the
5368 IS_POS_VALID_AFTER_MOVE_P test, move to the next buffer position
5369 only if we wind up in a string from display property. (Bug#11063)
5371 * window.c (Fdelete_other_windows_internal): Invalidate the row
5372 and column information about mouse highlight, so that redisplay
5373 restores it after reallocating the glyph matrices. (Bug#7464)
5375 * xdisp.c (set_cursor_from_row): If `cursor' property on a display
5376 string comes from a `display' text property, use the buffer
5377 position of that property as if we actually saw that position in
5379 (move_it_by_lines): Remove the assertion that
5380 "it->current_x == 0 && it->hpos == 0" which can be legitimately
5381 violated when there's a before-string at the beginning of a line.
5384 2012-03-30 Eli Zaretskii <eliz@gnu.org>
5386 * xdisp.c (append_space_for_newline): If the default face was
5387 remapped, use the remapped face for the appended newline.
5388 (extend_face_to_end_of_line): Use the remapped default face for
5389 extending the face to the end of the line.
5390 (display_line): Call extend_face_to_end_of_line when the default
5391 face was remapped. (Bug#11068)
5393 2012-03-29 Eli Zaretskii <eliz@gnu.org>
5395 * s/ms-w32.h: Discourage from defining HAVE_GETCWD.
5397 2012-03-28 Stefan Monnier <monnier@iro.umontreal.ca>
5399 * keyboard.c (safe_run_hooks_error): Don't unquote strings.
5401 2012-03-27 Glenn Morris <rgm@gnu.org>
5403 * search.c (Fword_search_backward_lax, Fword_search_forward_lax):
5406 2012-03-26 Kenichi Handa <handa@m17n.org>
5408 * dispextern.h (struct glyph): Fix previous change. Change the
5409 bit length of glyphless.ch to 25 (Bug#11082).
5411 2012-03-26 Chong Yidong <cyd@gnu.org>
5413 * keyboard.c (Vselection_inhibit_update_commands): New variable.
5414 (command_loop_1): Use it; inhibit selection update for
5415 handle-select-window too (Bug#8996).
5417 2012-03-25 Fabrice Popineau <fabrice.popineau@supelec.fr>
5419 * w32heap.c (_heap_init, _heap_term): Remove dead MSVC-specific code.
5421 2012-03-25 Kenichi Handa <handa@m17n.org>
5423 * dispextern.h (struct glyph): Change the bit length of
5424 glyphless.ch to 22 to make the member glyphless fit in 32 bits.
5426 2012-03-24 Eli Zaretskii <eliz@gnu.org>
5428 * s/ms-w32.h (tzname): Include time.h before redirecting to
5429 _tzname. Fixes the MSVC build. (Bug#9960)
5431 2012-03-24 Andreas Schwab <schwab@linux-m68k.org>
5433 * xdisp.c (produce_glyphless_glyph): Limit length of acronym to 6
5436 * xterm.c (XTread_socket): Only modify handling_signal if
5437 !SYNC_INPUT. (Bug#11080)
5439 2012-03-23 Eli Zaretskii <eliz@gnu.org>
5441 * bidi.c (bidi_fetch_char): Use STRING_CHAR_AND_LENGTH instead of
5442 FETCH_MULTIBYTE_CHAR followed by CHAR_BYTES. Prevents crashes
5443 when fetching a multibyte character consumes more bytes than
5444 CHAR_BYTES returns, due to unification of CJK characters in
5445 string_char. (Bug#11073)
5447 2012-03-23 Troels Nielsen <bn.troels@gmail.com> (tiny change)
5449 * process.c (wait_reading_process_output): Handle pty disconnect
5450 by refraining from sending oneself a SIGCHLD (bug#10933).
5452 2012-03-22 Chong Yidong <cyd@gnu.org>
5454 * dispextern.h (struct it): New member string_from_prefix_prop_p.
5456 * xdisp.c (push_prefix_prop): Rename from push_display_prop.
5457 Mark string as coming from a prefix property.
5458 (handle_face_prop): Use default face for prefix strings (Bug#4281).
5459 (pop_it, reseat_1): Save and restore string_from_prefix_prop_p.
5461 2012-03-21 Chong Yidong <cyd@gnu.org>
5463 * xfaces.c (Vface_remapping_alist): Doc fix.
5465 2012-03-20 Eli Zaretskii <eliz@gnu.org>
5467 * w32proc.c (Fw32_set_console_codepage)
5468 (Fw32_set_console_output_codepage, Fw32_get_codepage_charset):
5471 2012-03-20 Chong Yidong <cyd@gnu.org>
5473 * dispnew.c (Fredisplay, Vredisplay_preemption_period): Update doc
5474 to reflect default non-nil value of redisplay-dont-pause.
5476 2012-03-19 Kenichi Handa <handa@m17n.org>
5478 * ftfont.c (ftfont_drive_otf): Mask bits of character code to make
5479 it fit in a valid range (Bug#11003).
5481 2012-03-18 Eli Zaretskii <eliz@gnu.org>
5483 * xdisp.c (cursor_row_p): Even if the glyph row ends in a string
5484 that is not from display property, accept the row as a "cursor
5485 row" if one of the string's character has a non-nil `cursor'
5486 property. Fixes cursor positioning when there are newlines in
5487 overlay strings, e.g. in icomplete.el. (Bug#11035)
5489 2012-03-12 Paul Eggert <eggert@cs.ucla.edu>
5491 * buffer.c (compare_overlays): Don't assume args differ (Bug#6830).
5493 2012-03-12 Chong Yidong <cyd@gnu.org>
5495 * eval.c (inhibit_lisp_code): Rename from
5496 inhibit_window_configuration_change_hook; move from window.c.
5498 * xfns.c (unwind_create_frame_1, Fx_create_frame):
5499 * window.c (run_window_configuration_change_hook)
5500 (syms_of_window): Callers changed.
5502 2012-03-11 Chong Yidong <cyd@gnu.org>
5504 * keymap.c (Fkey_description): Doc fix (Bug#9700).
5506 * editfns.c (Fconstrain_to_field): Doc fix (Bug#9452).
5508 2012-03-10 Chong Yidong <cyd@gnu.org>
5510 * frame.c (other_visible_frames): Don't assume the selected frame
5511 is visible (Bug#10955).
5513 2012-03-09 Stefan Monnier <monnier@iro.umontreal.ca>
5515 * buffer.c (compare_overlays): Avoid qsort's instability (bug#6830).
5517 2012-03-08 Jan Djärv <jan.h.d@swipnet.se>
5519 * gtkutil.c (x_wm_set_size_hint): Use one row in call to
5520 FRAME_TEXT_LINES_TO_PIXEL_HEIGHT so base_height is greater than
5523 2012-03-03 Glenn Morris <rgm@gnu.org>
5525 * alloc.c (Fgarbage_collect, misc-objects-consed): Doc fixes.
5527 2012-03-02 Eli Zaretskii <eliz@gnu.org>
5529 * xdisp.c (try_window_reusing_current_matrix): Don't move cursor
5530 position past the first glyph_row that ends at ZV. (Bug#10902)
5531 (redisplay_window, next_element_from_string): Fix typos in
5533 (redisplay_window): Pass to move_it_vertically the margin in
5534 pixels, not in screen lines.
5536 2012-03-02 Glenn Morris <rgm@gnu.org>
5538 * buffer.c (buffer-list-update-hook): Doc fix.
5540 2012-02-29 Eli Zaretskii <eliz@gnu.org>
5542 * xdisp.c (get_overlay_strings_1): Under bidi redisplay, call
5543 push_it before setting up the iterator for the first overlay
5544 string, even if we have an empty string loaded.
5545 (next_overlay_string): If there's an empty string on the iterator
5546 stack, pop the stack. (Bug#10903)
5548 2012-02-25 Paul Eggert <eggert@cs.ucla.edu>
5550 Generalize fix for crash due to non-contiguous EMACS_INT (Bug#10780).
5551 Suggested by Stefan Monnier in
5552 <http://lists.gnu.org/archive/html/emacs-devel/2012-02/msg00692.html>.
5553 * alloc.c (widen_to_Lisp_Object): New static function.
5554 (mark_memory): Also mark Lisp_Objects by fetching pointer words
5555 and widening them to Lisp_Objects. This would work even if
5556 USE_LSB_TAG is defined and wide integers are used, which might
5557 happen in a future version of Emacs.
5559 2012-02-25 Chong Yidong <cyd@gnu.org>
5561 * fileio.c (Ffile_selinux_context, Fset_file_selinux_context):
5564 * xselect.c (Fx_selection_exists_p): Doc fix.
5565 (x_clipboard_manager_save_all): Print an informative message
5566 before saving to clipboard manager.
5568 2012-02-24 Chong Yidong <cyd@gnu.org>
5570 * keyboard.c (process_special_events): Handle all X selection
5571 requests in kbd_buffer, not just the next one (Bug#8869).
5573 2012-02-23 Chong Yidong <cyd@gnu.org>
5575 * xfns.c (Fx_create_frame): Avoid window-configuration-change-hook
5576 call when setting menu-bar-lines and tool-bar-lines parameters.
5577 (unwind_create_frame_1): New helper function.
5579 * window.c (inhibit_window_configuration_change_hook): New var.
5580 (run_window_configuration_change_hook): Obey it.
5581 (syms_of_window): Initialize it.
5583 2012-02-22 Chong Yidong <cyd@gnu.org>
5585 * xterm.c (x_draw_image_relief): Add missing type check for
5586 Vtool_bar_button_margin (Bug#10743).
5588 2012-02-21 Chong Yidong <cyd@gnu.org>
5590 * fileio.c (Vfile_name_handler_alist): Doc fix.
5592 * buffer.c (Fget_file_buffer): Protect against invalid file
5593 handler return value.
5595 2012-02-20 Paul Eggert <eggert@cs.ucla.edu>
5597 * .gdbinit (xreload): Don't assume EMACS_INT fits in 'long'
5598 when computing $valmask.
5600 Fix crash due to non-contiguous EMACS_INT (Bug#10780).
5601 * lisp.h (VALBITS): Move definition up, so that USE_LSB_TAG can use it.
5602 (USE_LSB_TAG): Do not define if UINTPTR_MAX >> VALBITS == 0.
5603 It's useless in that case, and it can cause problems on hosts
5604 that allocate halves of EMACS_INT values separately.
5605 Reported by Dan Horák. Diagnosed by Andreas Schwab in
5606 <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=10780#30>.
5607 * mem-limits.h (EXCEEDS_LISP_PTR): Define to 0 on hosts where
5608 UINTPTR_MAX >> VALBITS == 0. This is required by the above change;
5609 it avoids undefined behavior on hosts where shifting right by more
5610 than the word width has undefined behavior.
5612 2012-02-19 Chong Yidong <cyd@gnu.org>
5614 * fileio.c (Ffile_name_directory, Ffile_name_nondirectory)
5615 (Funhandled_file_name_directory, Ffile_name_as_directory)
5616 (Fdirectory_file_name, Fexpand_file_name)
5617 (Fsubstitute_in_file_name): Protect against invalid file handler
5618 return values (Bug#10845).
5620 2012-02-18 Eli Zaretskii <eliz@gnu.org>
5622 * .gdbinit (pitx): Fix incorrect references to fields of the
5625 2012-02-17 Chong Yidong <cyd@gnu.org>
5627 * syntax.c (Fscan_lists): Doc fix (Bug#10833).
5629 2012-02-15 Paul Eggert <eggert@cs.ucla.edu>
5631 * image.c (MAX_IMAGE_SIZE): Increase from 6.0 to 10.0; see
5632 <http://lists.gnu.org/archive/html/emacs-devel/2012-02/msg00540.html>.
5634 2012-02-15 Chong Yidong <cyd@gnu.org>
5636 * eval.c (Fdefvar, Fdefconst): Doc fix; note that the variable is
5637 marked as special. Also, starting docstrings with * is obsolete.
5639 2012-02-13 Andreas Schwab <schwab@linux-m68k.org>
5641 * gnutls.c (emacs_gnutls_write): Fix last change.
5643 2012-02-13 Lars Ingebrigtsen <larsi@gnus.org>
5645 * gnutls.c (emacs_gnutls_write): Set errno appropriately for
5648 2012-02-13 Stefan Monnier <monnier@iro.umontreal.ca>
5650 * keymap.c (Fsingle_key_description): Handle char ranges.
5652 2012-02-12 Chong Yidong <cyd@gnu.org>
5654 * xdisp.c (handle_stop): Avoid assigning -1 to it->face_id here,
5655 as that creates a dangerous corner case.
5657 * window.c (Fdelete_window_internal): Invalidate the mouse
5658 highlight (Bug#9904).
5660 2012-02-12 Glenn Morris <rgm@gnu.org>
5662 * xselect.c (Fx_own_selection_internal)
5663 (Fx_get_selection_internal, Fx_disown_selection_internal)
5664 (Fx_selection_owner_p, Fx_selection_exists_p): Doc fixes.
5665 * nsselect.m (Fx_own_selection_internal)
5666 (Fx_disown_selection_internal, Fx_selection_exists_p)
5667 (Fx_selection_owner_p, Fx_get_selection_internal):
5668 Sync docs and argument specs with the xselect.c versions.
5670 2012-02-11 Lars Ingebrigtsen <larsi@gnus.org>
5672 * gnutls.c (emacs_gnutls_write): Don't infloop if sendto fails.
5674 2012-02-11 Eli Zaretskii <eliz@gnu.org>
5676 * w32select.c (Fx_selection_exists_p): Sync doc string and
5677 argument list with xselect.c. (Bug#10783)
5679 * w16select.c (Fx_selection_exists_p): Sync doc string and
5680 argument list with xselect.c. (Bug#10783)
5682 2012-02-10 Glenn Morris <rgm@gnu.org>
5684 * fns.c (Fsecure_hash): Doc fix.
5686 2012-02-09 Kenichi Handa <handa@m17n.org>
5688 * coding.c (produce_chars): Fix updating of src_end (Bug#10701).
5690 2012-02-07 Chong Yidong <cyd@gnu.org>
5692 * buffer.c (Fbuffer_local_variables)
5693 (buffer_lisp_local_variables): Handle unbound vars correctly;
5694 don't let Qunbound leak into Lisp.
5696 2012-02-07 Glenn Morris <rgm@gnu.org>
5698 * image.c (Fimagemagick_types): Doc fix.
5700 * image.c (imagemagick-render-type): Change it from a lisp object
5701 to an integer. Move the doc here from the lisp manual.
5702 Treat all values not equal to 0 the same.
5704 2012-02-06 Chong Yidong <cyd@gnu.org>
5706 * doc.c (store_function_docstring): Avoid applying docstring of
5707 alias to base function (Bug#2603).
5709 2012-02-04 Andreas Schwab <schwab@linux-m68k.org>
5711 * .gdbinit (pp1, pv1): Remove redundant defines.
5714 2012-02-04 Chong Yidong <cyd@gnu.org>
5716 * nsterm.m: Declare a global (Bug#10694).
5718 2012-02-04 Eli Zaretskii <eliz@gnu.org>
5720 * w32.c (get_emacs_configuration_options):
5721 Include --enable-checking, if specified, in the return value.
5723 2012-02-04 Martin Rudalics <rudalics@gmx.at>
5725 * dispnew.c (change_frame_size_1): Calculate new_frame_total_cols
5726 after rounding frame sizes. (Bug#9723)
5728 2012-02-04 Eli Zaretskii <eliz@gnu.org>
5730 * keyboard.c (adjust_point_for_property): Don't position point
5731 before BEGV. (Bug#10696)
5733 2012-02-03 Paul Eggert <eggert@cs.ucla.edu>
5735 Handle overflow when computing char display width (Bug#9496).
5736 * character.c (char_width): Return EMACS_INT, not int.
5737 (char_width, c_string_width): Check for overflow when
5738 computing the width; this is possible now that individual
5739 characters can have unbounded width. Problem introduced
5740 by merge from Emacs 23 on 2012-01-19.
5742 2012-02-02 Michael Albinus <michael.albinus@gmx.de>
5744 * dbusbind.c (Fdbus_register_method): Mention the return value
5745 :ignore in the docstring.
5747 2012-02-02 Glenn Morris <rgm@gnu.org>
5749 * callproc.c (Fcall_process, Fcall_process_region): Doc fix.
5751 * nsterm.m (syms_of_nsterm) <x-toolkit-scroll-bars>:
5752 Unconditionally set to t. (Bug#10673)
5753 * nsterm.m (syms_of_nsterm) <x-toolkit-scroll-bars>:
5754 * w32term.c (syms_of_w32term) <x-toolkit-scroll-bars>:
5755 * xterm.c (syms_of_xterm) <x-toolkit-scroll-bars>: Doc fix.
5757 2012-02-02 Kenichi Handa <handa@m17n.org>
5759 (x_produce_glyphs): Cancel previous change. If cmp->glyph_len is
5760 0, do not call append_composite_glyph.
5762 2012-02-02 Kenichi Handa <handa@m17n.org>
5764 * xdisp.c (BUILD_COMPOSITE_GLYPH_STRING): Initialize first_s to
5766 (x_produce_glyphs): If the component of a composition is a null
5767 string, set it->pixel_width to 1 to avoid zero-width glyph.
5769 2012-02-01 Eli Zaretskii <eliz@gnu.org>
5771 * ralloc.c (resize_bloc, r_alloc_sbrk): Don't call memmove if its
5772 first 2 arguments are identical. This makes inserting large
5773 output from a subprocess an order of magnitude faster on
5774 MS-Windows, where all sbrk'ed memory is always contiguous.
5776 2012-01-31 Glenn Morris <rgm@gnu.org>
5778 * nsterm.m (syms_of_nsterm) <x-toolkit-scroll-bars>:
5779 * w32term.c (syms_of_w32term) <x-toolkit-scroll-bars>:
5780 * xterm.c (syms_of_xterm) <x-toolkit-scroll-bars>: Sync docs.
5782 2012-01-29 Glenn Morris <rgm@gnu.org>
5784 * gnutls.c (syms_of_gnutls): More doc (from etc/NEWS).
5786 2012-01-28 Samuel Thibault <sthibault@debian.org> (tiny change)
5788 * s/gnu.h: Define POSIX_SIGNALS (Bug#10552).
5790 2012-01-28 Chong Yidong <cyd@gnu.org>
5792 * minibuf.c (syms_of_minibuf): Doc fix (Bug#10550).
5794 2012-01-26 Chong Yidong <cyd@gnu.org>
5796 * keyboard.c (Vecho_keystrokes): Document zero value (Bug#10503).
5798 * search.c (Fsearch_forward, Fsearch_backward): Document negative
5799 repeat counts (Bug#10507).
5801 2012-01-26 Glenn Morris <rgm@gnu.org>
5803 * lread.c (syms_of_lread): Doc fix.
5805 2012-01-25 HIROSHI OOTA <nil@mad.dog.cx> (tiny change)
5807 * coding.c (encode_designation_at_bol): Change return value to
5810 2012-01-25 Chong Yidong <cyd@gnu.org>
5812 * eval.c (Fuser_variable_p): Doc fix; mention custom-variable-p.
5814 2012-01-21 Chong Yidong <cyd@gnu.org>
5816 * floatfns.c (Fcopysign): Make the second argument non-optional,
5817 since nil is not allowed anyway.
5819 2012-01-21 Andreas Schwab <schwab@linux-m68k.org>
5821 * process.c (read_process_output): Use p instead of XPROCESS (proc).
5822 (send_process): Likewise.
5824 2012-01-19 Martin Rudalics <rudalics@gmx.at>
5826 * window.c (save_window_save, Fcurrent_window_configuration)
5827 (Vwindow_persistent_parameters): Do not use Qstate.
5828 Rewrite doc-strings.
5830 2012-01-19 Kenichi Handa <handa@m17n.org>
5832 * character.c (char_width): New function.
5833 (Fchar_width, c_string_width, lisp_string_width):
5834 Use char_width (Bug#9496).
5836 2012-01-16 Martin Rudalics <rudalics@gmx.at>
5838 * window.c (Vwindow_persistent_parameters): New variable.
5839 (Fset_window_configuration, save_window_save): Handle persistent
5842 2012-01-14 Eli Zaretskii <eliz@gnu.org>
5844 * w32fns.c (signal_user_input): Don't do a QUIT, to avoid
5845 thrashing the stack of the thread. (Bug#9087)
5847 2012-01-12 Paul Eggert <eggert@cs.ucla.edu>
5849 * xdisp.c (rows_from_pos_range): Add parens as per gcc -Wparentheses.
5851 2012-01-11 Eli Zaretskii <eliz@gnu.org>
5853 * xdisp.c (rows_from_pos_range): Handle the case where the
5854 highlight ends on a newline. (Bug#10464)
5855 (mouse_face_from_buffer_pos): Fix off-by-one error in calculating
5856 he end column for display of highlight that ends on a newline
5859 2012-01-11 Glenn Morris <rgm@gnu.org>
5861 * lread.c (init_lread): If no-site-lisp, remove site-lisp dirs
5862 from load-path also when installation-directory is nil. (Bug#10208)
5864 2012-01-10 Glenn Morris <rgm@gnu.org>
5866 * emacs.c (syms_of_emacs) <installation-directory>: Doc fix.
5868 * epaths.in (PATH_LOADSEARCH, PATH_EXEC, PATH_DATA, PATH_DOC):
5869 Update template values to be closer to their typical values these days.
5871 2012-01-09 Eli Zaretskii <eliz@gnu.org>
5873 * xdisp.c (rows_from_pos_range): Accept additional argument
5874 DISP_STRING, and accept any glyph in a row whose object is that
5875 string as eligible for mouse highlight. Fixes mouse highlight of
5876 display strings from overlays. (Bug#10464)
5878 2012-01-07 Paul Eggert <eggert@cs.ucla.edu>
5880 emacs: fix an auto-save permissions race condition (Bug#10400)
5881 * fileio.c (auto_saving_dir_umask): New static var.
5882 (Fmake_directory_internal): Use it.
5883 (do_auto_save_make_dir): Set it, instead of invoking chmod after
5884 creating the directory. The old code temporarily assigns
5885 too-generous permissions to the directory.
5886 (do_auto_save_eh): Clear it.
5887 (Fdo_auto_save): Catch all errors, not just file errors, so
5888 that the var is always cleared.
5890 2012-01-07 Eli Zaretskii <eliz@gnu.org>
5892 * search.c (scan_buffer): Pass character positions to
5893 know_region_cache, not byte positions. (Bug#6540)
5895 2012-01-07 LynX <_LynX@bk.ru> (tiny change)
5897 * w32.c (sys_rename): Report EXDEV when rename of a directory
5898 fails because the target is on another logical disk. (Bug#10284)
5900 2012-01-07 David Benjamin <davidben@mit.edu> (tiny change)
5902 * xterm.c (x_embed_request_focus): New function.
5904 * xterm.h: Add prototype.
5906 * xfns.c (Fx_focus_frame): Use it for embedded frames (Bug#9977).
5908 2012-01-05 Glenn Morris <rgm@gnu.org>
5910 * emacs.c (emacs_copyright): Update short copyright year to 2012.
5912 2012-01-01 Eli Zaretskii <eliz@gnu.org>
5914 * gnutls.c (init_gnutls_functions): Load gnutls_check_version.
5915 Load gnutls_transport_set_lowat only if GnuTLS version is below
5917 (emacs_gnutls_handshake): Call gnutls_transport_set_lowat only for
5918 GnuTLS versions below 2.11.1.
5920 2011-12-31 Antoine Levitt <antoine.levitt@gmail.com>
5922 * xdisp.c (syms_of_xdisp) <window-scroll-functions>: Add warning
5923 to the doc string advising against its use for altering the way
5924 windows are scrolled.
5926 2011-12-28 Kenichi Handa <handa@m17n.org>
5928 * coding.c (Fdefine_coding_system_internal): Make an utf-8 base
5929 coding-system ASCII compatible only when it does not produce BOM
5930 on encoding (Bug#10383).
5932 2011-12-26 Jan Djärv <jan.h.d@swipnet.se>
5934 * xmenu.c (x_menu_wait_for_event): Use xg_select for Gtk3 so menus
5936 (create_and_show_popup_menu): Always use menu_position_func for
5939 2011-12-24 Andreas Schwab <schwab@linux-m68k.org>
5941 * callint.c (Fcall_interactively): Don't truncate prompt string.
5943 2011-12-23 Eli Zaretskii <eliz@gnu.org>
5945 * xdisp.c (handle_invisible_prop): Handle correctly an invisible
5946 property that ends at ZV, so that the bidi iteration could be
5947 resumed from there (after widening). (Bug#10360)
5949 2011-12-22 Jan Djärv <jan.h.d@swipnet.se>
5951 * nsfont.m (ns_spec_to_descriptor): Do not autorelease fdesc.
5953 2011-12-21 Jan Djärv <jan.h.d@swipnet.se>
5955 * nsterm.m (x_free_frame_resources):
5956 Release f->output_data.ns->miniimage.
5957 (ns_index_color): Fix indentation. Do not retain
5958 color_table->colors[i].
5960 * nsmenu.m (ns_update_menubar): Call free_menubar_widget_value_tree
5963 * nsfns.m (x_set_background_color): Assign return value from
5964 ns_index_color to face-background instead of NSColor*.
5965 (ns_implicitly_set_icon_type): Fix indentation.
5966 Change assignment in for loop to comparison.
5968 * emacs.c (ns_pool): New variable.
5969 (main): Assign ns_pool.
5970 (Fkill_emacs): Call ns_release_autorelease_pool.
5972 * nsfont.m (ns_spec_to_descriptor): Fix indentation,
5973 autorelease fdesc, release fdAttrs and tdict.
5974 (ns_get_covering_families): Release charset.
5975 (ns_findfonts): Release NSFontDescriptor created with new.
5976 (ns_uni_to_glyphs): Fix indentation.
5977 (setString): Release attrStr before assigning new value.
5979 2011-12-18 Jan Djärv <jan.h.d@swipnet.se>
5981 * nsmenu.m (NSMenuDidBeginTrackingNotification): Declare if OSX < 10.5
5983 (trackingNotification): Surround with ifdef NS_IMPL_COCOA.
5984 (syms_of_nsmenu): Set trackingMenu to 1 if not NS_IMPL_COCOA.
5986 2011-12-18 David Reitter <reitter@cmu.edu>
5988 * nsterm.m (ns_term_init): Subscribe for notifications
5989 NSMenuDidBeginTrackingNotification and NSMenuDidEndTrackingNotification
5990 to method trackingNotification in EmacsMenu.
5992 * nsmenu.m (trackingMenu): New variable.
5993 (trackingNotification): New method (from Aquamacs).
5994 (menuNeedsUpdate): Expand comment and return if trackingMenu is 0,
5995 from Aquamacs (Bug#7030).
5997 2011-12-18 Jan Djärv <jan.h.d@swipnet.se>
5999 * nsselect.m (CUT_BUFFER_SUPPORT): Remove define.
6000 (symbol_to_nsstring): Fix indentation.
6001 (ns_symbol_to_pb): New function.
6002 (Fns_get_selection_internal): Rename from Fns_get_cut_buffer_internal.
6003 (Fns_rotate_cut_buffers_internal): Remove.
6004 (Fns_store_selection_internal): Rename from
6005 Fns_store_cut_buffer_internal.
6006 (ns_get_foreign_selection, Fx_own_selection_internal)
6007 (Fx_disown_selection_internal, Fx_selection_exists_p)
6008 (Fns_get_selection_internal, Fns_store_selection_internal):
6009 Use ns_symbol_to_pb and check if return value is nil.
6010 (syms_of_nsselect): Remove ifdef CUT_BUFFER_SUPPORT. Remove defsubr
6011 Sns_rotate_cut_buffers_internal. Sns_get_cut_buffer_internal
6012 renamed to Sns_get_selection_internal, Sns_store_cut_buffer_internal
6013 renamed to Sns_store_selection_internal.
6014 (ns_handle_selection_request): Move code to Fx_own_selection_internal
6015 and remove this function.
6016 (ns_handle_selection_clear): Remove, never used.
6017 (Fx_own_selection_internal): Move code from ns_handle_selection_request
6020 2011-12-17 Ken Brown <kbrown@cornell.edu>
6022 * fileio.c (check_writable) [CYGWIN]: Return non-zero if UID or
6023 GID is unknown (Bug#10257).
6025 2011-12-17 Paul Eggert <eggert@cs.ucla.edu>
6027 * s/gnu-linux.h: Fix mark_memory typo (Bug#10286).
6028 (GC_MARK_SECONDARY_STACK): Omit removed 3rd arg to mark_memory,
6029 which caused a build failure on GNU/Linux IA-64. This problem was
6030 introduced by my 2011-10-07 patch.
6032 2011-12-15 Juri Linkov <juri@jurta.org>
6034 * image.c (imagemagick_error): New function. (Bug#10112)
6035 (imagemagick_load_image): Comment out `MagickSetResolution' call.
6036 Use `imagemagick_error' where ImageMagick functions return
6038 (Fimagemagick_types): Add `Fnreverse' to return the list in the
6041 2011-12-15 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
6043 * xftfont.c (xftfont_draw): Use the font metrics of s->font to
6044 fill background (Bug#8992).
6046 2011-12-13 Martin Rudalics <rudalics@gmx.at>
6048 * window.c (Vwindow_combination_resize)
6049 (Vwindow_combination_limit): Use t instead of non-nil in
6051 (Vrecenter_redisplay): Add first sentence of doc-string on
6053 (Frecenter): Fix doc-string typo.
6055 2011-12-11 Kenichi Handa <handa@m17n.org>
6057 * coding.c (Funencodable_char_position): Pay attention to the
6058 buffer text relocation (Bug#9389).
6060 2011-12-10 Jan Djärv <jan.h.d@swipnet.se>
6062 * xterm.c (x_term_init): Move call to gdk_window_add_filter before
6063 gtk_init (Bug#10100).
6065 2011-12-10 Eli Zaretskii <eliz@gnu.org>
6067 * xdisp.c (RECORD_MAX_MIN_POS): Use IT->cmp_it.charpos only if
6068 IT->string is nil. (Bug#10263)
6070 2011-12-10 Jan Djärv <jan.h.d@swipnet.se>
6072 * nsterm.h (x_free_frame_resources): Declare.
6074 * nsfns.m (ns_get_defaults_value): New function (Bug#10103).
6075 (Fns_get_resource, x_get_string_resource): Call ns_get_defaults_value.
6077 * nsterm.h (ns_get_defaults_value): Declare.
6079 * nsterm.m (ns_default): Call ns_get_defaults_value.
6081 2011-12-09 Eli Zaretskii <eliz@gnu.org>
6083 * xdisp.c (try_scrolling): Don't set scroll_down_p if dy is zero.
6086 2011-12-09 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
6088 * unexelf.c (unexec) [NS_IMPL_GNUSTEP]: Take account of the case
6089 that where the value of an _OBJC_* symbol points to is in the .bss
6090 section (Bug#10240).
6092 2011-12-08 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny change)
6094 * coding.c (encode_coding_ccl): Check (charbuf < charbuf_end)
6095 after the loop to call ccl_driver at least once (Bug#8619).
6097 2011-12-08 Kenichi Handa <handa@m17n.org>
6099 * ftfont.c (get_adstyle_property): Fix previous change
6102 2011-12-07 Juanma Barranquero <lekktu@gmail.com>
6104 * w32.c (init_environment): If no_site_lisp, remove site-lisp
6105 dirs from the default value of EMACSLOADPATH (bug#10208).
6107 2011-12-07 Glenn Morris <rgm@gnu.org>
6109 * lread.c (init_lread): If no_site_lisp, exclude site-lisp/ in
6110 installation and source directories as well. (Bug#10208)
6112 2011-12-06 Chong Yidong <cyd@gnu.org>
6114 * minibuf.c (Fread_from_minibuffer): Doc fix (Bug#10228).
6116 2011-12-06 Glenn Morris <rgm@gnu.org>
6118 * process.c (start_process_unwind): Treat any pid <= 0, except -2,
6119 as an error, not just -1. (Bug#10217)
6121 2011-12-05 Chong Yidong <cyd@gnu.org>
6123 * keyboard.c (process_special_events): New function.
6124 (swallow_events, Finput_pending_p): Use it (Bug#10195).
6126 2011-12-05 Paul Eggert <eggert@cs.ucla.edu>
6128 * coding.c (encode_designation_at_bol): Don't use uninitialized
6129 local variable (Bug#9318).
6131 2011-12-05 Kenichi Handa <handa@m17n.org>
6133 * ftfont.c (get_adstyle_property): If the font is not BDF nor PCF,
6134 return Qnil (Bug#8046, Bug#10193).
6136 2011-12-05 Kenichi Handa <handa@m17n.org>
6138 * coding.c (encode_designation_at_bol): New args charbuf_end and
6139 dst. Return the number of produced bytes. Callers changed.
6140 (coding_set_source): Return how many bytes coding->source was
6142 (coding_set_destination): Return how many bytes
6143 coding->destination was relocated.
6144 (CODING_DECODE_CHAR, CODING_ENCODE_CHAR, CODING_CHAR_CHARSET)
6145 (CODING_CHAR_CHARSET_P): Adjust for the avove changes.
6147 2011-12-05 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny change)
6149 * coding.c (CODING_CHAR_CHARSET_P): New macro.
6150 (encode_coding_emacs_mule, encode_coding_iso_2022): Use the above
6153 2011-12-05 Andreas Schwab <schwab@linux-m68k.org>
6155 The following changes are to fix Bug#9318.
6157 * coding.c (CODING_ENCODE_CHAR, CODING_CHAR_CHARSET): New macros.
6158 (encode_coding_emacs_mule, ENCODE_ISO_CHARACTER)
6159 (encode_coding_iso_2022, encode_coding_sjis)
6160 (encode_coding_big5, encode_coding_charset): Use the above macros.
6162 2011-12-05 Juanma Barranquero <lekktu@gmail.com>
6164 * lisp.h (process_quit_flag): Fix external declaration.
6166 2011-12-04 Stefan Monnier <monnier@iro.umontreal.ca>
6168 Don't macro-inline non-performance-critical code.
6169 * eval.c (process_quit_flag): New function.
6170 * lisp.h (QUIT): Use it.
6172 2011-12-04 Jan Djärv <jan.h.d@swipnet.se>
6174 * nsfns.m (get_geometry_from_preferences): New function.
6175 (Fx_create_frame): Call get_geometry_from_preferences (Bug#10103).
6177 2011-12-04 Andreas Schwab <schwab@linux-m68k.org>
6179 * emacs.c (Qkill_emacs): Define.
6180 (syms_of_emacs): Initialize it.
6181 * keyboard.c (interrupt_signal): Don't call Fkill_emacs here, set
6182 Qquit_flag to `kill-emacs' instead.
6183 (quit_throw_to_read_char): Add parameter `from_signal'.
6184 All callers changed. Call Fkill_emacs if requested and safe.
6185 * lisp.h (QUIT): Call Fkill_emacs if requested.
6187 2011-12-03 Jan Djärv <jan.h.d@swipnet.se>
6189 * widget.c (update_wm_hints): Return if wmshell is null.
6190 (widget_update_wm_size_hints): New function.
6192 * widget.h (widget_update_wm_size_hints): Declare.
6194 * xterm.c (x_wm_set_size_hint): If USE_X_TOOLKIT, call
6195 widget_update_wm_size_hints (Bug#10104).
6197 2011-12-03 Eli Zaretskii <eliz@gnu.org>
6199 * xdisp.c (handle_invisible_prop): If the invisible text ends just
6200 before a newline, prepare the bidi iterator for consuming the
6201 newline, and keep the current paragraph direction. (Bug#10183)
6202 (redisplay_window): Don't let `margin' become negative. (Bug#10192)
6204 2011-12-02 Juri Linkov <juri@jurta.org>
6206 * search.c (Fword_search_regexp): New Lisp function created from
6207 `wordify'. Change type of arg `lax' from `int' to `Lisp_Object'.
6208 (Fword_search_backward, Fword_search_forward)
6209 (Fword_search_backward_lax, Fword_search_forward_lax):
6210 Use `Fword_search_regexp' instead of `wordify'. Doc fix.
6211 (syms_of_search): Define `Sword_search_regexp'. (Bug#10145)
6213 2011-12-01 Stefan Monnier <monnier@iro.umontreal.ca>
6215 * fileio.c (Finsert_file_contents): Move after-change-function call
6216 to before the "handled:" label, since all "goto handled" appear in
6217 cases where the *-change-functions have already been properly called
6220 2011-12-01 Andreas Schwab <schwab@linux-m68k.org>
6222 * keyboard.c (interrupt_signal): Don't call kill-emacs when
6223 waiting for input. (Bug#10169)
6225 2011-11-30 Eli Zaretskii <eliz@gnu.org>
6227 * dispnew.c (adjust_glyph_matrix): Remove the assertion that
6228 verifies glyph row's hash code--we have just reallocated the
6229 glyphs, so their contents can be complete garbage. (Bug#10164)
6231 2011-11-30 Juanma Barranquero <lekktu@gmail.com>
6233 * dispnew.c (adjust_glyph_matrix) [XASSERTS]: Add missing check.
6235 2011-11-30 Eli Zaretskii <eliz@gnu.org>
6237 * dispnew.c (adjust_glyph_matrix) [XASSERTS]: Ensure ROW's
6238 attributes are tested _before_ calling verify_row_hash, to protect
6239 against GCC re-ordering of the tests. (Bug#10164)
6241 2011-11-29 Jan Djärv <jan.h.d@swipnet.se>
6243 * xterm.h (struct x_output): net_wm_state_hidden_seen is new.
6245 * xterm.c (handle_one_xevent): Only set async_visible and friends
6246 if net_wm_state_hidden_seen is non-zero (Bug#10002)
6247 (get_current_wm_state): Set net_wm_state_hidden_seen to 1 if
6248 _NET_WM_STATE_HIDDEN is in NET_WM_STATE.
6250 2011-11-28 Paul Eggert <eggert@cs.ucla.edu>
6252 Remove GCPRO-related macros that exist only to avoid shadowing locals.
6253 * lisp.h (GCPRO1_VAR, GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR, GCPRO5_VAR)
6254 (GCPRO6_VAR, UNGCPRO_VAR): Remove. See
6255 <http://lists.gnu.org/archive/html/emacs-diffs/2011-11/msg00265.html>.
6256 All uses changed to use GCPRO1 etc.
6257 (GCPRO1, GCPRO2, GCPRO3, GCPRO4, GCPRO5, GCPRO6, UNGCPRO):
6258 Revert to old implementation (i.e., before 2011-03-11).
6260 2011-11-28 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
6262 * dispnew.c (scrolling_window): Truncate overlaps in copy destination
6263 of scroll runs so as to avoid assigning disabled bogus rows and
6264 unnecessary graphics copy operations.
6266 2011-11-27 Eli Zaretskii <eliz@gnu.org>
6268 * s/ms-w32.h (utimbuf) [_MSC_VER]: Don't define.
6269 (snprintf) [_MSC_VER]: Redirect to _snprintf.
6270 (strtoll) [_MSC_VER]: Redirect to _strtoi64.
6271 (malloc, free, realloc, calloc): Redirect to e_* only when
6274 * lisp.h (GCTYPEBITS): Move before first use.
6275 (ALIGN_GCTYPEBITS) [_MSC_VER]: Define.
6276 (DECL_ALIGN) [_MSC_VER]: Use it, as MSVC doesn't like bit ops in
6277 this macro definition.
6279 * s/ms-w32.h (tzname): Redirect to _tzname for all values of
6282 2011-11-27 Jan Djärv <jan.h.d@swipnet.se>
6284 * gtkutil.c (xg_create_frame_widgets):
6285 Call gtk_window_set_has_resize_grip (FALSE) if that function is
6286 present with Gtk+ 2.0.
6288 2011-11-26 Paul Eggert <eggert@cs.ucla.edu>
6290 * fileio.c (Finsert_file_contents): Undo previous change; see
6291 <http://lists.gnu.org/archive/html/emacs-diffs/2011-11/msg00265.html>.
6293 2011-11-26 Paul Eggert <eggert@cs.ucla.edu>
6295 Rename locals to avoid shadowing.
6296 * fileio.c (Finsert_file_contents):
6297 Rename inner 'gcpro1' to 'inner_gcpro1' to avoid shadowing.
6298 * process.c (wait_reading_process_output):
6299 Rename inner 'proc' to 'p' to avoid shadowing.
6300 Indent for consistency with usual Emacs style.
6302 2011-11-25 Eli Zaretskii <eliz@gnu.org>
6304 * xdisp.c (redisplay_window): If cursor row is not fully visible
6305 after recentering, and scroll-conservatively is set to a large
6306 number, scroll window by a few more lines to make the cursor fully
6307 visible and out of scroll-margin. (Bug#10105)
6308 (start_display): Don't move to the next line if the display should
6309 start at a newline that is part of a display vector or an overlay
6312 2011-11-24 Juri Linkov <juri@jurta.org>
6314 * image.c (imagemagick_load_image): Move `MagickSetResolution' down
6315 after the `MagickPingImage' call. (Bug#10112)
6317 2011-11-23 Chong Yidong <cyd@gnu.org>
6319 * window.c (Fcoordinates_in_window_p): Accept only live windows.
6321 2011-11-23 Martin Rudalics <rudalics@gmx.at>
6323 * buffer.c (Fkill_buffer): Run replace_buffer_in_windows before
6324 making another buffer current. (Bug#10114)
6326 2011-11-23 Glenn Morris <rgm@gnu.org>
6328 * font.c (font_find_for_lface) [HAVE_NS]: Ignore case. (Bug#2526)
6330 2011-11-23 Chong Yidong <cyd@gnu.org>
6332 * xdisp.c (compute_stop_pos): Check validity of end_charpos before
6333 using it (Bug#5984).
6335 2011-11-22 Eli Zaretskii <eliz@gnu.org>
6337 * dispnew.c (adjust_glyph_matrix): Don't verify hash code of mode-
6338 and header-lines, as they don't have one computed for them.
6341 * .gdbinit (prow): Make displayed values more self-explaining.
6342 Add row's hash code.
6344 2011-11-21 Lars Magne Ingebrigtsen <larsi@gnus.org>
6346 * process.c (wait_reading_process_output): Fix asynchrounous
6347 GnuTLS socket handling on some versions of the GnuTLS library.
6348 (wait_reading_process_output): Add comment and URL.
6350 2011-11-21 Jan Djärv <jan.h.d@swipnet.se>
6352 * xterm.c (x_clear_frame): Reinstate the XClearWindow call.
6354 2011-11-21 Chong Yidong <cyd@gnu.org>
6356 * window.c (Fnext_window, Fprevious_window): Doc fix.
6358 2011-11-20 Stefan Monnier <monnier@iro.umontreal.ca>
6360 * window.c (get_phys_cursor_glyph): Fix Lisp_Object/int mixup.
6362 2011-11-20 Juanma Barranquero <lekktu@gmail.com>
6364 * nsfont.m (syms_of_nsfont) <ns-reg-to-script>: Fix typo.
6366 2011-11-20 Martin Rudalics <rudalics@gmx.at>
6368 * window.c (Fset_window_combination_limit): Rename argument
6370 (Vwindow_combination_limit): Remove "status" from doc-string.
6372 2011-11-20 Andreas Schwab <schwab@linux-m68k.org>
6374 * m/ibms390.h: Remove.
6375 * m/ibms390x.h: Don't include "ibms390.h".
6377 2011-11-20 Stefan Monnier <monnier@iro.umontreal.ca>
6379 * fileio.c (Finsert_file_contents): Add missing gcpro1 variable.
6380 Suggested by Dmitry Antipov <dmantipov@yandex.ru>.
6382 2011-11-20 Juanma Barranquero <lekktu@gmail.com>
6384 * casetab.c (Fset_case_table):
6385 * charset.c (Fcharset_after): Fix typos.
6387 2011-11-20 Paul Eggert <eggert@cs.ucla.edu>
6389 Standardize on VIRT_ADDR_VARIES behavior (Bug#10042).
6390 Otherwise, valgrind does not work on some platforms.
6391 Problem reported by Andreas Schwab in
6392 <http://lists.gnu.org/archive/html/emacs-devel/2011-11/msg00081.html>.
6393 * puresize.h (pure, PURE_P): Always behave as if VIRT_ADDR_VARIES
6394 is set, removing the need for VIRT_ADDRESS_VARIES.
6395 (PURE_P): Use a more-efficient implementation that needs just one
6396 comparison, not two: on x86-64 with GCC 4.6.2, this cut down the
6397 number of instructions from 6 (xorl, cmpq, jge, xorl, cmpq, setge)
6398 to 4 (xorl, subq, cmpq, setbe).
6399 * alloc.c (pure): Always extern now, since that's the
6400 VIRT_ADDR_VARIES behavior.
6401 (PURE_POINTER_P): Use a single comparison, not two, for
6402 consistency with the new puresize.h.
6403 * lisp.h (PNTR_COMPARISON_TYPE): Remove; no longer needed.
6404 * m/ibms390.h, m/intel386.h, m/template.h, s/cygwin.h, s/hpux10-20.h:
6405 Remove VIRT_ADDR_VARIES no longer needed.
6407 2011-11-19 Eli Zaretskii <eliz@gnu.org>
6409 * xdisp.c (x_write_glyphs, draw_phys_cursor_glyph)
6410 (erase_phys_cursor, update_window_cursor, show_mouse_face)
6411 (cursor_in_mouse_face_p): If the cursor position is out of bounds,
6412 behave as if the cursor position were at the window margin.
6414 * window.c (get_phys_cursor_glyph): If the window is hscrolled,
6415 and the cursor position is out of bounds, behave as if the cursor
6416 position were at the window margin. (Bug#10075)
6418 2011-11-18 Chong Yidong <cyd@gnu.org>
6420 * window.c (Fwindow_combination_limit): Make first argument
6421 non-optional, since it is meaningless for live windows like the
6424 2011-11-18 Dmitry Antipov <dmantipov@yandex.ru>
6426 * keymap.c (Fwhere_is_internal): Add missing RETURN_UNGCPROs.
6428 2011-11-18 Stefan Monnier <monnier@iro.umontreal.ca>
6430 * intervals.c: Fix grafting over the whole buffer (bug#10071).
6431 (graft_intervals_into_buffer): Simplify.
6433 2011-11-18 Eli Zaretskii <eliz@gnu.org>
6435 * dispnew.c (swap_glyph_pointers): Swap the used[] arrays and the
6436 hash values of the two rows.
6437 (copy_row_except_pointers): Preserve the used[] arrays and the
6438 hash values of the two rows. (Bug#10035)
6439 (add_row_entry): Add xassert to verify that ROW's hash code is valid.
6441 * xdisp.c (row_hash): New function, body extracted from
6442 compute_line_metrics.
6443 (compute_line_metrics): Call row_hash, instead of computing the
6446 * dispnew.c (verify_row_hash): Call row_hash for computing the
6447 hash code of a row, instead of duplicating code from xdisp.c.
6449 * dispextern.h (row_hash): Add prototype.
6451 2011-11-18 Tassilo Horn <tassilo@member.fsf.org>
6453 * frame.c (delete_frame): Don't delete the terminal when the last
6454 X frame is closed if emacs is built with GTK toolkit.
6456 2011-11-17 Juanma Barranquero <lekktu@gmail.com>
6458 * window.c (syms_of_window) <window-combination-resize>: Fix typo.
6460 2011-11-17 Martin Rudalics <rudalics@gmx.at>
6462 * window.c (Vwindow_splits): Rename to
6463 Vwindow_combination_resize. Suggested by Juri Linkov.
6464 (Fsplit_window_internal): Use Vwindow_combination_resize instead
6467 2011-11-16 Juanma Barranquero <lekktu@gmail.com>
6469 * nsfns.m (Fns_font_name):
6470 * window.c (syms_of_window) <window-combination-limit>: Fix typos.
6472 2011-11-16 Martin Rudalics <rudalics@gmx.at>
6474 * window.h (window): Rename slot "nest" to "combination_limit".
6475 * window.c (Fwindow_nest): Rename to Fwindow_combination_limit.
6476 (Fset_window_nest): Rename to Fset_window_combination_limit.
6477 (Vwindow_nest): Rename to Vwindow_combination_limit.
6478 (recombine_windows, make_parent_window, make_window)
6479 (Fsplit_window_internal, saved_window)
6480 (Fset_window_configuration, save_window_save): Rename all
6481 occurrences of window_nest to window_combination_limit.
6483 2011-11-15 Juanma Barranquero <lekktu@gmail.com>
6485 * image.c (imagemagick_load_image): Fix typo.
6487 2011-11-14 Eli Zaretskii <eliz@gnu.org>
6489 * xdisp.c (display_line): Move the call to
6490 highlight_trailing_whitespace before the call to
6491 compute_line_metrics, since the latter needs to see the final
6492 faces of all the glyphs to compute ROW's hash value.
6493 Fixes assertion violations in row_equal_p. (Bug#10035)
6495 2011-11-14 Juanma Barranquero <lekktu@gmail.com>
6497 * w32proc.c (reader_thread): Don't check pending input if cp->fd < 0,
6498 just return (bug#10044).
6500 2011-11-12 Eli Zaretskii <eliz@gnu.org>
6502 * makefile.w32-in (HEAPSIZE): New variable, allows to build temacs
6503 with user-defined heap size. Bump the default size of the temacs
6504 heap to 27MB, to avoid memory warning when running temacs.
6505 ($(TEMACS)): Use HEAPSIZE instead of a hardcoded value.
6507 * dispnew.c (scrolling_window): Fix incorrect indices in accessing
6508 current_matrix and desired_matrix. (Bug#9990)
6509 (verify_row_hash) [XASSERTS]: New function.
6510 (adjust_glyph_matrix, row_equal_p): Use it in xassert to verify
6511 that the hash value of glyph rows is correct.
6513 2011-11-12 Martin Rudalics <rudalics@gmx.at>
6515 * window.h (window): Remove splits slot.
6516 * window.c (Fwindow_splits, Fset_window_splits): Remove.
6517 (Fdelete_other_windows_internal, make_parent_window)
6518 (make_window, Fsplit_window_internal, Fdelete_window_internal)
6519 (Fset_window_configuration, save_window_save): Don't deal with
6520 split status of windows.
6521 (saved_window): Remove splits slot.
6522 (Vwindow_splits): Rewrite doc-string.
6524 2011-11-11 Jan Djärv <jan.h.d@swipnet.se>
6526 * xfns.c (unwind_create_frame):
6527 * nsfns.m (unwind_create_frame):
6528 * w32fns.c (unwind_create_frame): Use Fmemq to check if frame is in
6529 Vframe_list (Bug#9999).
6531 2011-11-11 Dmitry Antipov <dmantipov@yandex.ru>
6533 * xdisp.c (syms_of_xdisp): Remove duplicated definition of Qtext.
6535 2011-11-11 Kenichi Handa <handa@m17n.org>
6537 * callproc.c (Fcall_process): Set the member dst_multibyte of
6540 2011-11-11 Johan Bockgård <bojohan@gnu.org>
6542 * xdisp.c (fill_composite_glyph_string): Always set s->face, to
6543 avoid a crash (bug#9496).
6545 2011-11-09 Chong Yidong <cyd@gnu.org>
6547 * window.c (Fwindow_inside_edges, Fwindow_inside_pixel_edges)
6548 (Fwindow_inside_absolute_pixel_edges): Only allow live windows.
6550 2011-11-08 Paul Eggert <eggert@cs.ucla.edu>
6552 * s/gnu.h (GC_MARK_STACK): Define to GC_MAKE_GCPROS_NOOPS (Bug#9926).
6554 2011-11-08 Paul Eggert <eggert@cs.ucla.edu>
6556 Avoid some portability problems by eschewing 'extern inline' functions.
6557 The trivial performance wins aren't worth the portability hassles; see
6558 <http://lists.gnu.org/archive/html/emacs-devel/2011-11/msg00084.html>
6560 * dispextern.h (window_box, window_box_height, window_text_bottom_y)
6561 (window_box_width, window_box_left, window_box_left_offset)
6562 (window_box_right, window_box_right_offset): Undo previous change,
6563 by removing the "extern"s.
6564 * intervals.c (adjust_intervals_for_insertion)
6565 (adjust_intervals_for_deletion): Undo previous change,
6566 making these static again.
6567 (offset_intervals, temp_set_point_both, temp_set_point)
6568 (copy_intervals_to_string): No longer inline.
6569 * xdisp.c (window_text_bottom_y, window_box_width)
6570 (window_box_height, window_box_left_offset)
6571 (window_box_right_offset, window_box_left, window_box_right)
6572 (window_box): No longer inline.
6574 2011-11-08 Chong Yidong <cyd@gnu.org>
6576 * window.c (Fwindow_left_column, Fwindow_top_line): Doc fix.
6577 (Fwindow_body_height, Fwindow_body_width): Move from Lisp.
6578 Signal an error if not a live window.
6579 (Fwindow_total_width, Fwindow_total_height): Move from Lisp.
6580 (Fwindow_total_size, Fwindow_body_size): Move to Lisp.
6582 2011-11-07 Juanma Barranquero <lekktu@gmail.com>
6584 * lisp.h (syms_of_abbrev): Remove declaration.
6585 Reported by CHENG Gao <chenggao@royau.me>.
6587 2011-11-07 Eli Zaretskii <eliz@gnu.org>
6589 * w32.c (check_windows_init_file): Don't look for term/w32-win.el
6590 if Vpurify_flag is non-nil. Fixes a crash when running w32 build
6591 of temacs in GUI mode.
6593 2011-11-07 Martin Rudalics <rudalics@gmx.at>
6595 * window.h: Declare delete_all_child_windows instead of
6596 delete_all_subwindows.
6597 * window.c (Fwindow_nest, Fset_window_nest)
6598 (Fset_window_new_total, Fset_window_new_normal)
6599 (Fwindow_resize_apply): Don't use term subwindow in doc-strings.
6600 (delete_all_subwindows): Rename to delete_all_child_windows.
6601 (Fdelete_other_windows_internal, Fset_window_configuration):
6602 Call delete_all_child_windows instead of delete_all_subwindows.
6603 * frame.c (delete_frame): Call delete_all_child_windows instead
6604 of delete_all_subwindows.
6606 2011-11-07 Paul Eggert <eggert@cs.ucla.edu>
6608 * alloc.c (DEADP): New macro, for porting to GNU/Hurd (Bug#9926).
6609 This is also needed for porting to any host where GC_MARK_STACK is
6610 not GC_MAKE_GCPROS_NOOPS.
6611 (which_symbols): Use it.
6613 2011-11-07 Kenichi Handa <handa@m17n.org>
6615 * coding.c (coding_set_destination): Check coding->src_pos only
6616 when coding->src_object is a buffer (bug#9910).
6618 * process.c (send_process): Set the member src_multibyte of coding
6619 to 0 (bug#9911) when sending a unibyte text.
6621 * callproc.c (Fcall_process): Set the member src_multibyte of
6622 process_coding to 0 (bug#9912).
6624 2011-11-06 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
6626 * xmenu.c (cleanup_widget_value_tree): New function.
6627 (xmenu_show, xdialog_show): Use it in record_unwind_protect instead of
6628 calling free_menubar_widget_value_tree directly (Bug#9830).
6630 2011-11-06 Paul Eggert <eggert@cs.ucla.edu>
6632 Fix some portability problems with 'inline'.
6633 * dispextern.h (window_box, window_box_height, window_text_bottom_y)
6634 (window_box_width, window_box_left, window_box_left_offset)
6635 (window_box_right, window_box_right_offset): Declare extern.
6636 Otherwise, these inline functions do not conform to C99 and
6637 are miscompiled by Microsoft compilers. Reported by Eli Zaretskii in
6638 <http://lists.gnu.org/archive/html/emacs-devel/2011-11/msg00084.html>.
6639 * intervals.c (adjust_intervals_for_insertion)
6640 (adjust_intervals_for_deletion): Now extern, because otherwise the
6641 extern inline functions 'offset_intervals' couldn't refer to it.
6642 (static_offset_intervals): Remove.
6643 (offset_intervals): Rewrite using the old contents of
6644 static_offset_intervals. The old version didn't conform to C99
6645 because an extern inline function contained a reference to an
6646 identifier with static linkage.
6648 2011-11-06 Andreas Schwab <schwab@linux-m68k.org>
6650 * keyboard.c (interrupt_signal): Don't call kill-emacs while in
6653 2011-11-06 Eli Zaretskii <eliz@gnu.org>
6655 * xdisp.c (init_iterator, reseat_to_string): Don't set the
6656 iterator's bidi_p flag if Vpurify_flag is non-nil. (Bug#9963)
6657 (Fcurrent_bidi_paragraph_direction): If Vpurify_flag is non-nil,
6658 return Qleft_to_right.
6660 2011-11-06 Chong Yidong <cyd@gnu.org>
6662 * window.c (Fwindow_live_p, Fwindow_frame, Fframe_root_window)
6663 (Fminibuffer_window, Fwindow_buffer, Fwindow_splits)
6664 (Fset_window_splits, Fwindow_nest, Fset_window_nest)
6665 (Fwindow_use_time, Fwindow_total_size, Fwindow_normal_size)
6666 (Fwindow_new_normal, Fwindow_left_column, Fwindow_top_line)
6667 (Fwindow_margins, Fwindow_fringes, Fwindow_scroll_bars)
6668 (Fwindow_vscroll): Doc fix.
6669 (Fwindow_top_child, Fwindow_left_child): Eliminate a nil default
6670 argument, since it makes no sense to pass a live window and for
6671 consistency with window-child.
6673 2011-11-05 Christoph Scholtes <cschol2112@googlemail.com>
6675 * makefile.w32-in ($(TEMACS), (gl-stamp)): Use $(THISDIR) to
6678 2011-11-05 Jason Rumney <jasonr@gnu.org>
6680 * w32font.c (font_matches_spec): Filter out non-Japanese kana fonts.
6681 (add_font_entity_to_list): Filter out non-Japanese Shift-JIS
6683 (add_font_entity_to_list): Fix logic errors in mixed boolean and
6684 bitwise arithmetic preventing use of unicode-sip and non-truetype
6687 2011-11-05 Eli Zaretskii <eliz@gnu.org>
6689 * s/ms-w32.h (fstat, stat, utime): Move redirections to
6692 * w32fns.c (x_create_tip_frame, Fx_create_frame): Rearrange
6693 initialization code to keep similarity to xfns.c after changes
6696 2011-11-05 Jan Djärv <jan.h.d@swipnet.se>
6698 * nsfns.m: Declare image_cache_refcount if GLYPH_DEBUG.
6699 (unwind_create_frame): New function (Bug#9943).
6700 (Fx_create_frame): Restructure code to be more similar to the one in
6701 xfns.c. Call record_unwind_protect with unwind_create_frame (Bug#9943).
6702 Initialize image_cache_refcount if GLYPH_DEBUG (Bug#9943).
6703 Move terminal->reference_count++ just before making the frame official
6706 * nsterm.m (x_free_frame_resources): New function.
6707 (x_destroy_window): Move code to x_free_frame_resources.
6709 * xfns.c (unwind_create_frame): Fix comment.
6710 (Fx_create_frame, x_create_tip_frame):
6711 Move terminal->reference_count++ just before making the frame
6712 official. Move initialization of image_cache_refcount and
6713 dpyinfo_refcount before calling init_frame_faces (Bug#9943).
6715 2011-11-05 Eli Zaretskii <eliz@gnu.org>
6717 Support MSVC build with newer versions of Visual Studio.
6718 * makefile.w32-in (TAGS-gmake): Don't use $(patsubst ...), as
6719 Nmake barfs on that. Use $(OBJ*_c) variables instead, defined on
6722 * lisp.h (ENUM_BF): New macro, for enumerated types in bitfields,
6723 which are not supported by MSVC.
6724 (Lisp_Symbol, Lisp_Misc_Any, Lisp_Marker, Lisp_Misc_Overlay)
6725 (Lisp_Save_Value, Lisp_Free): Use ENUM_BF for enumerated types in
6727 (Lisp_Object) [USE_LISP_UNION_TYPE]: Use ENUM_BF for enumerated
6729 (DEFUN) [_MSC_VER]: Define in a different way for MSVC.
6731 * w32fns.c [_MSC_VER]: DECLARE_HANDLE for any MSVC version.
6733 2011-11-05 Fabrice Popineau <fabrice.popineau@supelec.fr> (tiny change)
6735 Support MSVC build with newer versions of Visual Studio.
6736 * w32.c: Don't include w32api.h for MSVC.
6737 (init_environment) [_MSC_VER]: Call sys_access, not _access.
6739 * s/ms-w32.h <sigset_t, ssize_t> [_MSC_VER]: Typedefs for MSVC.
6740 [_MSC_VER]: Include sys/timeb.h, sys/stat.h, and signal.h.
6741 (fstat, stat, utime) [_MSC_VER]: Redirect to their sys_* cousins.
6742 (malloc, free, realloc, calloc) [_MSC_VER]: Always redirect to the
6744 (alloca) [_MSC_VER]: Define to _alloca.
6746 * lisp.h (DECL_ALIGN) [_MSC_VER]: Define for MSVC.
6748 * regex.c <re_char> [_MSC_VER]: A separate definition for MSVC.
6750 2011-11-04 Eli Zaretskii <eliz@gnu.org>
6752 * xdisp.c (note_mouse_highlight): If either of
6753 previous/next-single-property-change returns nil, treat that as
6754 the beginning or the end of the buffer. (Bug#9955)
6756 2011-11-04 Jan Djärv <jan.h.d@swipnet.se>
6758 * gtkutil.c (xg_make_tool_item): Add callbacks if one of wimage or
6759 label is not null (Bug#9951).
6760 (xg_tool_item_stale_p): Handle the fact that wimage and/or wlbl
6763 2011-11-04 Eli Zaretskii <eliz@gnu.org>
6765 * window.c (Fwindow_body_size): Mention in the doc string that the
6766 return value is in frame's canonical units. (Bug#9949)
6768 2011-11-03 Eli Zaretskii <eliz@gnu.org>
6770 * xdisp.c (note_mouse_highlight): Initialize `area'. (Bug#9947)
6772 * w32fns.c (unwind_create_frame): If needed, free the glyph
6773 matrices of the partially constructed frame. (Bug#9943)
6774 * xfns.c (unwind_create_frame): Likewise.
6776 2011-11-01 Eli Zaretskii <eliz@gnu.org>
6778 * xdisp.c (mouse_face_from_buffer_pos): Fix a typo in a comment.
6779 Don't stop backward scan on the continuation glyph, even though
6780 its CHARPOS is positive.
6781 (mouse_face_from_buffer_pos, note_mouse_highlight):
6782 Rename cover_string to disp_string.
6784 2011-11-01 Martin Rudalics <rudalics@gmx.at>
6786 * window.c (temp_output_buffer_show): Don't use
6787 Vtemp_buffer_show_specifiers.
6788 (Vtemp_buffer_show_specifiers): Remove unused variable.
6790 2011-10-30 Eli Zaretskii <eliz@gnu.org>
6792 * xdisp.c (try_cursor_movement): Make sure ROW isn't decremented
6793 past the beginning of the current glyph matrix.
6795 2011-10-30 Adam Sjøgren <asjo@koldfront.dk> (tiny change)
6797 * xterm.c: Include X11/Xproto.h if HAVE_GTK3.
6798 (x_error_handler): Ignore BadMatch for X_SetInputFocus for
6799 HAVE_GTK3 (Bug#9869).
6801 * gtkutil.c (xg_win_to_widget, xg_event_is_for_menubar): Initialize
6802 type to GDK_NOTHING so valgrind does not complain (Bug#9901).
6804 * xterm.h (x_display_info): Add Xatom_net_wm_state_hidden (Bug#9893).
6806 * xterm.c: Declare x_handle_net_wm_state to return int.
6807 (handle_one_xevent): Check if we are iconified but don't have
6808 _NET_WM_STATE_HIDDEN. If do, treat as deiconify (Bug#9893).
6809 (get_current_wm_state): Return non-zero if not hidden,
6810 check for _NET_WM_STATE_HIDDEN (Bug#9893).
6811 (do_ewmh_fullscreen): Ignore return value from get_current_wm_state.
6812 (x_handle_net_wm_state): Return what get_current_wm_state returns.
6813 (x_term_init): Initialize dpyinfo->Xatom_net_wm_state_hidden.
6815 2011-10-29 Paul Eggert <eggert@cs.ucla.edu>
6817 * alloc.c (which_symbols): Declare EXTERNALLY_VISIBLE,
6818 so that this new function doesn't get optimized away by a
6819 whole-program optimizer. Make the 2nd arg EMACS_INT, not int.
6821 2011-10-29 Andreas Schwab <schwab@linux-m68k.org>
6823 * frame.h (MOUSE_HL_INFO): Remove excess parens.
6825 2011-10-29 Eli Zaretskii <eliz@gnu.org>
6827 Fix the `xbytecode' command.
6828 * .gdbinit (xprintbytestr): New command.
6829 (xwhichsymbols): Rename from `which'; all callers changed.
6830 (xbytecode): Print the byte-code string as well.
6832 2011-10-29 Kim Storm <storm@cua.dk>
6834 * alloc.c (which_symbols): New function.
6836 2011-10-29 Andreas Schwab <schwab@linux-m68k.org>
6838 * minibuf.c (read_minibuf_noninteractive): Allow reading empty
6841 2011-10-29 Glenn Morris <rgm@gnu.org>
6843 * process.c (wait_reading_process_output): Revert 2009-08-30 change.
6844 Not clear what it was for, and it causes various bugs. (Bug#9839)
6846 2011-10-28 Eli Zaretskii <eliz@gnu.org>
6848 * xdisp.c (note_mouse_highlight): Initialize `part', to avoid a
6849 possible random value that matches one of those tested as
6850 condition to clear the mouse face.
6852 2011-10-28 Chong Yidong <cyd@gnu.org>
6854 * xdisp.c (note_mouse_highlight): Fix use of uninitialized var.
6856 2011-10-28 Dan Nicolaescu <dann@ics.uci.edu>
6858 * window.c (make_window): Initialize phys_cursor_on_p.
6860 2011-10-28 Stefan Monnier <monnier@iro.umontreal.ca>
6862 * lisp.h (struct Lisp_Symbol): Update comments.
6864 2011-10-28 Juanma Barranquero <lekktu@gmail.com>
6866 * w32font.c (w32_load_unicows_or_gdi32): Add missing return.
6868 2011-10-28 Eli Zaretskii <eliz@gnu.org>
6870 Fix Emacs on Windows 9X (bug#8562). Thanks to oslsachem
6871 <oslsachem@gmail.com> for helping to debug this.
6873 * w32font.c (g_b_init_is_w9x, g_b_init_get_outline_metrics_w)
6874 (g_b_init_get_text_metrics_w, g_b_init_get_glyph_outline_w)
6875 (g_b_init_get_glyph_outline_w): New static variables.
6876 (GetOutlineTextMetricsW_Proc, GetTextMetricsW_Proc)
6877 (GetGlyphOutlineW_Proc): New typedefs.
6878 (w32_load_unicows_or_gdi32, get_outline_metrics_w)
6879 (get_text_metrics_w, get_glyph_outline_w, globals_of_w32font):
6881 (w32font_open_internal, compute_metrics):
6882 Call get_outline_metrics_w, get_text_metrics_w, and get_glyph_outline_w
6883 instead of calling the "wide" APIs directly.
6885 * emacs.c (main) [HAVE_NTGUI]: Call globals_of_w32font.
6887 * w32.h (syms_of_w32font): Add prototype.
6889 2011-10-27 Juanma Barranquero <lekktu@gmail.com>
6891 * window.c (Fframe_root_window, Fframe_first_window, Fwindow_end)
6892 (Fframe_selected_window, Ftemp_output_buffer_show, Fnext_window)
6893 (Fdelete_window_internal, Fwindow_parameters): Fix typos in docstrings.
6894 (Fmove_to_window_line): Doc fix.
6896 2011-10-27 Chong Yidong <cyd@gnu.org>
6898 * process.c (make_process): Set gnutls_state to NULL.
6900 * gnutls.c (emacs_gnutls_deinit): Deinit the gnutls_state if it is
6901 non-NULL, regardless of GNUTLS_INITSTAGE.
6902 (Fgnutls_boot): Cleanups. Call emacs_gnutls_deinit if we signal
6903 an error. Set process slots as soon as we allocate them.
6905 * gnutls.h (GNUTLS_LOG, GNUTLS_LOG2): Fix macros.
6907 2011-10-27 Chong Yidong <cyd@gnu.org>
6909 * gnutls.c (emacs_gnutls_deinit): New function.
6910 Deallocate credentials structures as well as calling gnutls_deinit.
6911 (Fgnutls_deinit, Fgnutls_boot): Use it.
6913 * process.c (make_process): Initialize GnuTLS credentials to NULL.
6914 (deactivate_process): Call emacs_gnutls_deinit.
6916 2011-10-27 Juanma Barranquero <lekktu@gmail.com>
6918 * image.c (x_create_x_image_and_pixmap):
6919 * w32.c (sys_rename, w32_delayed_load):
6920 * w32font.c (fill_in_logfont):
6921 * w32reg.c (x_get_string_resource): Silence compiler warnings.
6923 2011-10-26 Juanma Barranquero <lekktu@gmail.com>
6925 * w32fns.c (w32_default_color_map): New function,
6926 extracted from Fw32_default_color_map.
6927 (Fw32_default_color_map, Fx_open_connection): Use it. (Bug#9785)
6929 2011-10-25 Paul Eggert <eggert@cs.ucla.edu>
6931 * dispextern.h (Fcontrolling_tty_p): New decl (Bug#6649 part 2).
6933 2011-10-25 Stefan Monnier <monnier@iro.umontreal.ca>
6935 * keyboard.c (test_undefined): New function (bug#9751).
6936 (read_key_sequence): Use it to detect when a key is bound to `undefined'.
6938 2011-10-25 Enami Tsugutomo <tsugutomo.enami@jp.sony.com>
6940 * sysdep.c (init_sys_modes): Fix the check for the controlling
6941 terminal (Bug#6649).
6943 2011-10-20 Eli Zaretskii <eliz@gnu.org>
6945 * dispextern.h (struct bidi_it): New member next_en_type.
6947 * bidi.c (bidi_line_init): Initialize the next_en_type member.
6948 (bidi_resolve_explicit_1): When next_en_pos is valid for the
6949 current character, check also for next_en_type being WEAK_EN.
6950 (bidi_resolve_weak): Don't enter the expensive loop if the current
6951 position is before next_en_pos. Record the bidi type of the first
6952 non-ET, non-BN character we find, in addition to its position.
6953 (bidi_level_of_next_char): Invalidate next_en_type when
6954 next_en_pos is over-stepped.
6956 2011-10-20 Paul Eggert <eggert@cs.ucla.edu>
6958 Time zone name fixes for non-ASCII locales (Bug#641, Bug#9794)
6959 * editfns.c: Rewrite current-time-zone so that it invokes
6960 the equivalent of (format-time-string "%Z") to get the time zone name.
6961 This fixes a bug when the time zone name contains characters that
6962 need converting from the system time locale to Emacs internal format.
6963 This fixes a shortcoming that I introduced in my 1999-10-19 patch:
6964 that patch fixed format-time-string to do the conversion, but
6965 I forgot to fix current-time-zone.
6966 (format_time_string): New function, containing most of
6967 what Fformat_time_string used to contain.
6968 (Fformat_time_string): Rewrite in terms of format_time_string.
6969 This doesn't change this function's behavior.
6970 (current-time-zone): Rewrite to use format_time_string.
6971 This fixes the bug reported by Michael Schierl in
6972 <http://lists.gnu.org/archive/html/emacs-devel/2007-06/msg00334.html>.
6973 Jason Rumney's 2007-06-07 change worked around this bug, but
6975 * systime.h (tzname, timezone): Remove no-longer-used declarations.
6977 2011-10-19 Eli Zaretskii <eliz@gnu.org>
6979 * xdisp.c (start_display): If the character at POS is displayed
6980 via a display vector, reset IT->current.dpvec_index to zero.
6981 (try_window_reusing_current_matrix): If a line ends in a display
6982 vector or the next line starts in a display vector, continue
6983 redrawing the window even though the character position of
6984 start_row was reached.
6987 2011-10-18 Chong Yidong <cyd@gnu.org>
6989 * xdisp.c (get_next_display_element): Handle U+2010 and U+2011
6990 with nobreak-char-display too.
6992 2011-10-18 Eli Zaretskii <eliz@gnu.org>
6994 Fix part 3 of bug#9771.
6995 * bidi.c (bidi_line_init): Initialize next_en_pos to zero, not -1.
6996 (bidi_resolve_neutral): Don't enter the expensive loop looking for
6997 non-neutral characters if the current character is a paragraph
6998 separator (a.k.a. Newline). This avoids running the same
6999 expensive loop twice, once when we consume the preceding newline
7000 and the other time when the line actually needs to be displayed.
7001 Avoid the loop when we see neutrals on the base embedding level
7002 following a character whose directionality is the same as the
7003 paragraph's. This avoids running the expensive loop when a line
7004 ends in a long sequence of neutrals, like control characters.
7005 Add assertion against STRONG_AL type. Slightly rearrange code
7006 that determines the type of a neutral given the first non-neutral
7008 (bidi_level_of_next_char): Set next_en_pos to zero when
7009 invalidating its info.
7011 2011-10-17 Eli Zaretskii <eliz@gnu.org>
7013 * xdisp.c (push_display_prop): Determine whether to record string
7014 or buffer position by IT->string, not by IT->method. Allow
7015 GET_FROM_DISPLAY_VECTOR as IT->method on entry. (Bug#9771, part 4)
7016 (move_it_vertically_backward): Don't look for character position
7017 immediately after the newline when in a continuation line.
7020 2011-10-15 Martin Rudalics <rudalics@gmx.at>
7022 * window.c (coordinates_in_window): Rewrite and delabelize
7023 vertical border check. (Bug#5357) (Bug#9618)
7025 2011-10-14 Stefan Monnier <monnier@iro.umontreal.ca>
7027 * xterm.c (frame_highlight, frame_unhighlight): Ignore unexplained
7028 errors in XSetWindowBorder (bug#9310).
7030 2011-10-13 Dmitry Antipov <dmantipov@yandex.ru>
7032 * editfns.c (Fset_time_zone_rule): Replace free with xfree to
7033 avoid crash when xmalloc overrun checking is enabled.
7035 2011-10-13 Eli Zaretskii <eliz@gnu.org>
7037 * xdisp.c (Fcurrent_bidi_paragraph_direction): Initialize
7038 itb.paragraph_dir to NEUTRAL_DIR. Fixes an occasional incorrect
7039 cursor motion with <left> and <right> arrow keys.
7041 * bidi.c (bidi_init_it): Don't initialize paragraph_dir here, as
7042 some callers set that themselves.
7044 2011-10-12 Eli Zaretskii <eliz@gnu.org>
7046 * xdisp.c (find_row_edges): Handle the case where ROW comes from a
7047 display string and the previous row comes from the same string and
7048 is empty. (Bug#9739) (Bug#9738)
7050 2011-10-12 Stefan Monnier <monnier@iro.umontreal.ca>
7052 * doc.c (get_doc_string): Encode file name (bug#9735).
7054 2011-10-12 Eli Zaretskii <eliz@gnu.org>
7056 * bidi.c (bidi_level_of_next_char):
7057 * xdisp.c (get_visually_first_element): Remove old incorrect
7058 comments regarding the Unicode Line Separator character.
7060 * bidi.c (bidi_init_it): Initialize paragraph_dir to NEUTRAL_DIR.
7062 2011-10-12 Dmitry Antipov <dmantipov@yandex.ru>
7064 * alloc.c (Fgc_status): Do not access beyond zombies array
7065 boundary if nzombies > MAX_ZOMBIES.
7066 * alloc.c (dump_zombies): Add missing format specifier.
7068 2011-10-12 Paul Eggert <eggert@cs.ucla.edu>
7070 * xdisp.c (set_cursor_from_row): Simplify conditionals,
7071 to pacify GCC 4.6.1 x86-64 with -O2 -Wstrict-overflow.
7073 * lread.c (read_escape): Allow hex escapes as large as ?\xfffffff.
7074 Some packages use them to denote characters with modifiers.
7076 2011-10-11 Andreas Schwab <schwab@linux-m68k.org>
7078 * lisp.h (GCPRO1_VAR, GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR)
7079 (GCPRO5_VAR, GCPRO6_VAR, UNGCPRO_VAR): Add whitespace to avoid
7080 matching a pp-number. Rename parameter var to var1.
7082 2011-10-11 Stefan Monnier <monnier@iro.umontreal.ca>
7084 * minibuf.c (Finternal_complete_buffer): Fix last change (bug#9709).
7086 2011-10-08 Glenn Morris <rgm@gnu.org>
7088 * callint.c (Fcall_interactively): Give a more explicit error for the
7089 'c' case with a non-character input. (Bug#8479)
7091 2011-10-08 Eli Zaretskii <eliz@gnu.org>
7093 * xdisp.c (hscroll_window_tree): Support hscroll in right-to-left
7095 (set_cursor_from_row): Fix cursor positioning in mixed L2R+R2L
7096 lines that are hscrolled on the left.
7098 * dispnew.c (buffer_posn_from_coords): Account for a possible
7099 presence of header-line. (Bug#4426)
7101 2011-10-07 Stefan Monnier <monnier@iro.umontreal.ca>
7103 * buffer.c (syms_of_buffer) <enable-multibyte-characters>:
7104 Don't advertise functionality which we discourage or doesn't work.
7106 2011-10-07 Paul Eggert <eggert@cs.ucla.edu>
7108 * alloc.c (GC_LISP_OBJECT_ALIGNMENT): Use offsetof, not __alignof__
7109 or sizeof. __alignof__ gives the wrong answer on Fedora x86-64
7110 with GCC 4.6.1 when configured with CC='gcc -m32' --with-wide-int;
7111 this makes Emacs dump core during garbage collection on rare
7112 occasions. sizeof is obviously inferior to offsetof here, so
7113 stick with offsetof.
7114 (GC_POINTER_ALIGNMENT): New macro.
7115 (mark_memory): Omit 3rd (offset) arg; caller changed.
7116 Don't assume EMACS_INT alignment is the same as pointer alignment.
7118 2011-10-03 Stefan Monnier <monnier@iro.umontreal.ca>
7120 * keyboard.c (read_key_sequence_remapped): New var.
7121 (read_key_sequence): Compute remapping in the right buffer.
7122 (command_loop_1): Use read_key_sequence's remapping directly.
7124 2011-10-02 Stefan Monnier <monnier@iro.umontreal.ca>
7126 * dired.c (file_name_completion): Don't expand file name.
7127 (Ffile_name_completion, Ffile_name_all_completions): Expand file name
7128 before checking file name handler.
7130 * minibuf.c (Finternal_complete_buffer): Only show internal buffers if
7131 they've been requested explicitly (bug#9591).
7133 2011-10-01 Andreas Schwab <schwab@linux-m68k.org>
7135 * keymap.c (Fsingle_key_description): Use make_specified_string
7136 instead of build_string to build string from push_key_description.
7139 2011-09-30 Paul Eggert <eggert@cs.ucla.edu>
7141 * buffer.h (struct buffer): Use time_t, not int, for a time stamp.
7142 This fixes a Y2038 bug on 64-bit hosts.
7143 * buffer.c (reset_buffer):
7144 * fileio.c (Fdo_auto_save, Fset_buffer_auto_saved)
7145 (Fclear_buffer_auto_save_failure):
7146 Use 0, not -1, to represent an unset failure time, since time_t
7147 might not be signed.
7149 Remove dependency on glibc malloc internals.
7150 * alloc.c (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
7151 Move back here from lisp.h, but with their new implementations.
7152 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
7153 (XMALLOC_OVERRUN_SIZE_SIZE): Move these new lisp.h macros here.
7154 * charset.c (charset_table_init): New static var.
7155 (syms_of_charset): Use it instead of xmalloc. This removes a
7156 dependency on glibc malloc internals. See Eli Zaretskii's comment in
7157 <http://lists.gnu.org/archive/html/emacs-devel/2011-09/msg00815.html>.
7158 * lisp.h (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
7159 Move back to alloc.c.
7160 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
7161 (XMALLOC_OVERRUN_SIZE_SIZE): Move to alloc.c.
7163 2011-09-30 Jan Djärv <jan.h.d@swipnet.se>
7165 * nsterm.m (windowDidResize): Call x_set_window_size only when
7166 ns_in_resize is true. Otherwise set pixelwidth/height and
7167 call change_frame_size (Bug#9628).
7169 2011-09-30 Paul Eggert <eggert@cs.ucla.edu>
7171 Port --enable-checking=all to Fedora 14 x86-64.
7172 * charset.c (syms_of_charset): Also account for glibc malloc's
7173 internal overhead when calculating the initial malloc maximum.
7175 Port --enable-checking=all to Fedora 14 x86.
7176 * alloc.c (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
7178 (xmalloc_put_size, xmalloc_get_size, overrun_check_malloc)
7179 (overrun_check_realloc, overrun_check_free):
7180 Use XMALLOC_OVERRUN_SIZE_SIZE, not sizeof (size_t).
7181 That way, xmalloc returns a properly-aligned pointer even if
7182 XMALLOC_OVERRUN_CHECK is defined. The old debugging code happened
7183 to align OK on typical 64-bit hosts, but not on Fedora 14 x86.
7184 * charset.c (syms_of_charset): Take XMALLOC_OVERRUN_CHECK_OVERHEAD
7185 into account when calculating the initial malloc maximum.
7186 * lisp.h (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
7187 Move here from alloc.c, so that charset.c can use it too.
7188 Properly align; the old code wasn't right for common 32-bit hosts
7189 when configured with --enable-checking=all.
7190 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
7191 (XMALLOC_OVERRUN_SIZE_SIZE): New macros.
7193 2011-09-29 Eli Zaretskii <eliz@gnu.org>
7195 * sysdep.c (snprintf) [!EOVERFLOW]: If EOVERFLOW is not defined,
7198 2011-09-28 Eli Zaretskii <eliz@gnu.org>
7200 * xdisp.c (compute_display_string_end): If there's no display
7201 string at CHARPOS, return -1.
7203 * bidi.c (bidi_fetch_char): When compute_display_string_end
7204 returns a negative value, treat the character as a normal
7205 character not covered by a display string. (Bug#9624)
7207 2011-09-28 Juanma Barranquero <lekktu@gmail.com>
7209 * lread.c (Fread_from_string): Fix typo in docstring.
7211 2011-09-27 Eli Zaretskii <eliz@gnu.org>
7213 * xdisp.c (handle_invisible_prop): If invisible text ends on a
7214 newline, reseat the iterator instead of bidi-iterating there one
7215 character at a time. (Bug#9610)
7216 (BUFFER_POS_REACHED_P, move_it_in_display_line_to): Bail when past
7217 TO_CHARPOS if the bidi iterator is at base embedding level.
7219 2011-09-27 Andreas Schwab <schwab@linux-m68k.org>
7221 * lread.c (readevalloop): Use correct code for NBSP.
7222 (read1): Likewise. (Bug#9608)
7224 2011-09-25 Michael Albinus <michael.albinus@gmx.de>
7226 * dbusbind.c (Fdbus_register_signal): When service is not
7227 registered, use nil in Vdbus_registered_objects_table. (Bug#9581)
7229 2011-09-25 Glenn Morris <rgm@gnu.org>
7231 * buffer.c (truncate-lines): Doc fix.
7233 2011-09-24 Chong Yidong <cyd@stupidchicken.com>
7235 * window.c (Fwindow_prev_buffers, Fset_window_prev_buffers)
7236 (Fset_window_next_buffers): Doc fix.
7238 2011-09-24 Glenn Morris <rgm@gnu.org>
7240 * minibuf.c (read_minibuf): Disable line truncation. (Bug#5715)
7242 2011-09-24 Paul Eggert <eggert@cs.ucla.edu>
7244 Fix minor problems found by static checking.
7245 * xdisp.c (string_from_display_spec): Don't assume vecsize fits in int.
7246 * indent.c (Fvertical_motion): Fix == vs = typo.
7248 2011-09-24 Eli Zaretskii <eliz@gnu.org>
7250 * dispnew.c (syms_of_display) <redisplay-dont-pause>:
7251 Default value is now t. Doc fix.
7253 * indent.c (Fvertical_motion): Compute and apply the overshoot
7254 logic when moving up, not only when moving down. Fix the
7255 confusing name and values of the it_overshoot_expected variable;
7256 logic changes accordingly. (Bug#9254) (Bug#9549)
7258 * xdisp.c (pos_visible_p): Produce correct pixel coordinates when
7259 CHARPOS is covered by a display string which includes newlines.
7260 (move_it_vertically_backward): Avoid inflooping when START_CHARPOS
7261 is covered by a display string with embedded newlines.
7263 2011-09-24 Michael Albinus <michael.albinus@gmx.de>
7265 * dbusbind.c (Fdbus_register_signal): Add match rule to
7266 Vdbus_registered_objects_table. (Bug#9581)
7267 (Fdbus_register_method, Vdbus_registered_objects_table):
7270 2011-09-24 Jim Meyering <meyering@redhat.com>
7272 do not ignore write error for any output size
7273 The previous change was incomplete.
7274 While it makes emacs --batch detect the vast majority of stdout
7275 write failures, errors were still ignored whenever the output size is
7276 k * (BUFSIZ+1) - 4. E.g., on a system with BUFSIZ of 4096,
7277 $ emacs --batch --eval '(print (format "%4093d" 0))' > /dev/full \
7278 && echo FAIL: ignored write error
7279 FAIL: ignored write error
7280 $ emacs --batch --eval '(print (format "%20481d" 0))' > /dev/full \
7281 && echo FAIL: ignored write error
7282 FAIL: ignored write error
7283 * emacs.c (Fkill_emacs): Also test ferror. (Bug#9574)
7285 2011-09-23 Andreas Schwab <schwab@linux-m68k.org>
7287 * emacs.c (Fkill_emacs): In noninteractive mode exit
7288 non-successfully if a write error occurred on stdout. (Bug#9574)
7290 2011-09-21 Eli Zaretskii <eliz@gnu.org>
7292 * xdisp.c (pop_it): Allow it->object that is a cons cell to pass
7295 * dispextern.h (struct it): Update the comment documenting what
7298 2011-09-20 Eli Zaretskii <eliz@gnu.org>
7300 * xdisp.c (set_cursor_from_row): If the row ends in a newline from
7301 a display string, extend search for cursor position to end of row.
7302 (find_row_edges): If the row ends in a newline from a display
7303 string, increment its MATRIX_ROW_END_CHARPOS by one. (Bug#9549)
7304 Handle the case of a display string with multiple newlines.
7305 (Fcurrent_bidi_paragraph_direction): Fix search for previous
7306 non-empty line. Fixes confusing cursor motion with arrow keys at
7307 the beginning of a line that starts with whitespace.
7309 2011-09-19 Lars Magne Ingebrigtsen <larsi@gnus.org>
7311 * lread.c (Fread_from_string): Document what FINAL-STRING-INDEX is
7314 2011-09-18 Chong Yidong <cyd@stupidchicken.com>
7316 * xfns.c (Fx_create_frame): Handle the bitmapIcon resource as
7319 2011-09-18 Eli Zaretskii <eliz@gnu.org>
7321 * xdisp.c (display_line): Record maximum and minimum buffer
7322 positions even if no glyphs were produced (e.g., by a zero-width
7323 stretch). Fixes bug#9530 on a TTY. Under word-wrap, don't record
7324 buffer positions that will be removed from the glyph row because
7326 (produce_stretch_glyph): Fix a bug in :align-to on a TTY when the
7327 column is beyond frame width: don't subtract 1 "pixel" when
7328 computing width of the stretch.
7329 (reseat_at_next_visible_line_start): Undo the change made on
7330 2011-09-17 that saved paragraph information and restored it after
7331 the call to `reseat'. (Bug#9545)
7333 2011-09-18 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
7335 * xdisp.c (expose_window): Save original value of phys_cursor_on_p
7336 and turn window cursor on if cleared (Bug#9415).
7338 2011-09-18 Andreas Schwab <schwab@linux-m68k.org>
7340 * search.c (boyer_moore): Take unibyte characters from pattern
7341 literally. (Bug#9458)
7343 2011-09-18 Eli Zaretskii <eliz@gnu.org>
7345 * xdisp.c (reseat_at_next_visible_line_start): Fix last change.
7347 2011-09-18 Paul Eggert <eggert@cs.ucla.edu>
7349 Fix minor problem found by static checking.
7350 * xdisp.c (reseat_at_next_visible_line_start): Mark locals as
7351 initialized, to pacify gcc -Wuninitialized.
7353 * fileio.c: Report proper errno when syscall falls.
7354 (Finsert_file_contents): Save and restore errno,
7355 so that report_file_error outputs the correct diagnostic.
7356 (Fwrite_region) [CLASH_DETECTION]: Likewise.
7358 2011-09-18 Eli Zaretskii <eliz@gnu.org>
7360 * .gdbinit (pgx): Fix references to fields of `struct glyph'.
7362 2011-09-17 Eli Zaretskii <eliz@gnu.org>
7364 * xdisp.c (produce_stretch_glyph): Another fix for changes made on
7365 2011-08-30T17:32:44Z!eliz@gnu.org. (Bug#9530)
7367 2011-09-17 Eli Zaretskii <eliz@gnu.org>
7369 * xdisp.c (reseat_at_next_visible_line_start): Keep information
7370 about the current paragraph and restore it after the call to reseat.
7372 * bidi.c (MAX_PARAGRAPH_SEARCH): New macro.
7373 (bidi_find_paragraph_start): Search back for paragraph beginning
7374 at most MAX_PARAGRAPH_SEARCH lines; if not found, return BEGV_BYTE.
7375 (bidi_move_to_visually_next): Only trigger paragraph-related
7376 computations when the last character is a newline or at EOB, not
7377 just any NEUTRAL_B. (Bug#9470)
7379 * xdisp.c (set_cursor_from_row): Don't invoke special treatment of
7380 truncated lines if point is covered by a display string. (Bug#9524)
7382 2011-09-16 Paul Eggert <eggert@cs.ucla.edu>
7384 * xselect.c: Relax test for outgoing X longs (Bug#9498).
7385 (cons_to_x_long): New function.
7386 (lisp_data_to_selection_data): Use it. Correct the test for
7387 short-versus-long data; it was negated. Break out of vector
7388 loop, for efficiency, when a long datum is discovered.
7390 2011-09-16 Stefan Monnier <monnier@iro.umontreal.ca>
7392 * eval.c (Fquote): Document its non-consing behavior (bug#9482).
7394 2011-09-16 Eli Zaretskii <eliz@gnu.org>
7396 * image.c (tiff_handler): Work around a bug in MinGW GCC 3.x (see
7397 GCC PR/17406) by declaring this function with external scope.
7399 2011-09-15 Paul Eggert <eggert@cs.ucla.edu>
7401 * editfns.c (Fformat): Fix bug in text-property fix (Bug#9514).
7402 Don't mishandle (length (format "%%")) and (format "%4000s%%" "").
7404 2011-09-15 Andreas Schwab <schwab@linux-m68k.org>
7406 * editfns.c (Fformat): Correctly handle text properties on "%%".
7408 2011-09-15 Eli Zaretskii <eliz@gnu.org>
7410 * xterm.c (x_draw_composite_glyph_string_foreground):
7411 * w32term.c (x_draw_composite_glyph_string_foreground):
7412 * term.c (encode_terminal_code):
7413 * composite.c (composition_update_it, get_composition_id):
7414 * xdisp.c (get_next_display_element)
7415 (fill_composite_glyph_string): Add comments about special meaning
7416 of TAB characters in a composition.
7418 2011-09-15 Paul Eggert <eggert@cs.ucla.edu>
7420 * editfns.c (Fformat): Fix off-by-1 bug for "%%b" (Bug#9514).
7421 This occurs when processing a multibyte format.
7422 Problem reported by Wolfgang Jenker.
7424 2011-09-15 Johan Bockgård <bojohan@gnu.org>
7426 * xdisp.c (try_cursor_movement): Only check for exact match if
7427 cursor hpos found by set_cursor_from_row is valid. (Bug#9495)
7429 2011-09-14 Paul Eggert <eggert@cs.ucla.edu>
7431 Remove unused external symbols.
7432 * dispextern.h (calc_pixel_width_or_height): Remove decl.
7433 * xdisp.c (calc_pixel_width_or_height): Now static.
7434 * doprnt.c (exprintf) [! (HAVE_X_WINDOWS && USE_X_TOOLKIT)]: Remove.
7435 * indent.c (check_display_width):
7436 * w32term.c: Fix comment to match code.
7437 * xterm.c, xterm.h (x_catching_errors): Remove.
7439 2011-09-14 Paul Eggert <eggert@cs.ucla.edu>
7441 * xselect.c: Use signed conversions more consistently (Bug#9498).
7442 (selection_data_to_lisp_data): Assume incoming selection data are
7443 signed integers, not unsigned. This is to be consistent with
7444 outgoing selection data, which was modified to use signed integers
7445 in as part of the fix to Bug#9196 in response to Jan D.'s comment
7446 in <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9196#32> that X11
7447 expects long, not unsigned long.
7449 2011-09-14 Eli Zaretskii <eliz@gnu.org>
7451 * xdisp.c (try_window_reusing_current_matrix): Fix incorrect
7452 computation of loop end. Reported by Johan Bockgård
7455 2011-09-13 Chong Yidong <cyd@stupidchicken.com>
7457 * frame.c (Fother_visible_frames_p): Function deleted.
7459 2011-09-12 Eli Zaretskii <eliz@gnu.org>
7461 * indent.c (compute_motion): Process display vector front to back
7462 rather than the other way around. (Bug#2496)
7464 2011-09-12 Stefan Monnier <monnier@iro.umontreal.ca>
7466 * fileio.c (Finsert_file_contents): Don't assume beg_offset is 0.
7468 2011-09-11 Chong Yidong <cyd@stupidchicken.com>
7470 * minibuf.c (Fread_from_minibuffer): Doc fix.
7472 2011-09-11 Eli Zaretskii <eliz@gnu.org>
7474 * xdisp.c (produce_stretch_glyph): Fix a typo made in changes from
7475 2011-08-30T17:32:44Z!eliz@gnu.org. (Bug#9475)
7477 2011-09-11 Lars Magne Ingebrigtsen <larsi@gnus.org>
7479 * fileio.c (Fvisited_file_modtime): Document `(-1 65535)' as a
7480 value for non-existent files.
7482 2011-09-11 Eli Zaretskii <eliz@gnu.org>
7484 * fileio.c (Finsert_file_contents): If the file cannot be opened,
7485 set its "size" to -1. This will set the modtime_size field of
7486 the corresponding buffer to -1, which is what
7487 verify-visited-file-modtime expects for files that do not exist.
7490 2011-09-11 Paul Eggert <eggert@cs.ucla.edu>
7492 * keymap.h (KEY_DESCRIPTION_SIZE, push_key_description): Move decls
7494 * lisp.h: ... from here. push_key_description is no longer
7495 defined in keyboard.c, so its declaration should not be in
7496 lisp.h's "Defined in keyboard.c" section, and KEY_DESCRIPTION_SIZE
7497 logically belongs with push_key_description.
7499 2011-09-10 Paul Eggert <eggert@cs.ucla.edu>
7501 * buffer.h: Include <sys/types.h> instead of <time.h>.
7502 Otherwise, off_t wasn't defined on FreeBSD 9.0-BETA2 i386.
7503 Problem reported by Herbert J. Skuhra.
7505 2011-09-10 Lars Magne Ingebrigtsen <larsi@gnus.org>
7507 * xml.c (parse_region): Make the parsing work for
7508 non-comment-starting XML files again (bug#9144).
7510 2011-09-10 Andreas Schwab <schwab@linux-m68k.org>
7512 * image.c (gif_load): Fix calculation of bottom and right corner.
7515 2011-09-10 Eli Zaretskii <eliz@gnu.org>
7517 * xdisp.c (MAX_DISP_SCAN): Decrease to 250. Prevents sluggish
7518 redisplay in small windows.
7520 2011-09-09 Eli Zaretskii <eliz@gnu.org>
7522 * frame.c (x_report_frame_params): Cast to avoid compiler warnings.
7524 2011-09-08 Martin Rudalics <rudalics@gmx.at>
7526 * window.c (Fset_window_prev_buffers, Fset_window_next_buffers):
7527 Operate on live windows only.
7529 2011-09-08 Juanma Barranquero <lekktu@gmail.com>
7531 * emacs.c (my_heap_start): #ifdef to avoid warnings when unused.
7533 2011-09-07 Eli Zaretskii <eliz@gnu.org>
7535 * xdisp.c (move_it_in_display_line_to): Call RESTORE_IT on ppos_it
7536 only under bidi iteration.
7538 2011-09-07 Jan Djärv <jan.h.d@swipnet.se>
7540 * gtkutil.c (xg_make_tool_item): Insert comment about eventbox.
7542 2011-09-06 Paul Eggert <eggert@cs.ucla.edu>
7544 isnan: Fix porting problem to Solaris 10 with bundled gcc.
7545 Without this fix, the command to link temacs failed due to an
7546 undefined symbol __builtin_isnan. This is because
7547 /usr/include/iso/math_c99.h #defines isnan(x) to
7548 __builtin_isnan(x), but the bundled gcc, which identifies itself
7549 as gcc 3.4.3 (csl-sol210-3_4-branch+sol_rpath), does not have
7551 * floatfns.c (isnan): #undef, and then #define to a clone of
7553 (Fisnan): Always define, since it's always available now.
7554 (syms_of_floatfns): Always define isnan at the Lisp level.
7556 2011-09-06 Paul Eggert <eggert@cs.ucla.edu>
7558 * Makefile.in (gl-stamp): move-if-change now in build-aux (Bug#9169).
7560 2011-09-06 Paul Eggert <eggert@cs.ucla.edu>
7562 * fileio.c: Fix bugs with large file offsets (Bug#9428).
7563 The previous code assumed that file offsets (off_t values) fit in
7564 EMACS_INT variables, which is not true on typical 32-bit hosts.
7565 The code messed up by falsely reporting buffer overflow in cases
7566 such as (insert-file-contents "big" nil 1 2) into an empty buffer
7567 when "big" contains more than 2**29 bytes, even though this
7568 inserts just one byte and does not overflow the buffer.
7569 (Finsert_file_contents): Store file offsets as off_t
7570 values, not as EMACS_INT values. Check for overflow when
7571 converting between EMACS_INT and off_t. When checking for
7572 buffer overflow or for overlap, take the offsets into account.
7573 Don't use EMACS_INT for small values where int suffices.
7574 When checking for overlap, fix a typo: ZV was used where
7575 ZV_BYTE was intended.
7576 (Fwrite_region): Don't assume off_t fits into 'long'.
7577 * buffer.h (struct buffer.modtime_size): Now off_t, not EMACS_INT.
7579 2011-09-05 Michael Albinus <michael.albinus@gmx.de>
7581 * dbusbind.c (xd_signature_cat): Rename from signature_cat.
7583 2011-09-04 Paul Eggert <eggert@cs.ucla.edu>
7585 sprintf-related integer and memory overflow issues (Bug#9412).
7587 * doprnt.c (doprnt): Support printing ptrdiff_t and intmax_t values.
7588 (esprintf, exprintf, evxprintf): New functions.
7589 * keyboard.c (command_loop_level): Now EMACS_INT, not int.
7590 (cmd_error): Kbd macro iterations count is now EMACS_INT, not int.
7591 (modify_event_symbol): Do not assume that the length of
7592 name_alist_or_stem is safe to alloca and fits in int.
7593 (Fexecute_extended_command): Likewise for function name and binding.
7594 (Frecursion_depth): Wrap around reliably on integer overflow.
7595 * keymap.c (push_key_description): First arg is now EMACS_INT, not int,
7596 since some callers pass EMACS_INT values.
7597 (Fsingle_key_description): Don't crash if symbol name contains more
7598 than MAX_ALLOCA bytes.
7599 * minibuf.c (minibuf_level): Now EMACS_INT, not int.
7600 (get_minibuffer): Arg is now EMACS_INT, not int.
7601 * lisp.h (get_minibuffer, push_key_description): Reflect API changes.
7602 (esprintf, exprintf, evxprintf): New decls.
7603 * window.h (command_loop_level, minibuf_level): Reflect API changes.
7605 * dbusbind.c (signature_cat): New function.
7606 (xd_signature, Fdbus_register_signal):
7607 Do not overrun buffer; instead, report string overflow.
7609 * dispnew.c (add_window_display_history): Don't overrun buffer.
7610 Truncate instead; this is OK since it's just a log.
7612 * editfns.c (Fcurrent_time_zone): Don't overrun buffer
7613 even if the time zone offset is outlandishly large.
7614 Don't mishandle offset == INT_MIN.
7616 * emacs.c (main) [NS_IMPL_COCOA]: Don't overrun buffer
7617 when creating daemon; the previous buffer-overflow check was incorrect.
7619 * eval.c (verror): Simplify by rewriting in terms of evxprintf,
7620 which has the guts of the old verror function.
7622 * filelock.c (lock_file_1, lock_file): Don't blindly alloca long name;
7623 use SAFE_ALLOCA instead. Use esprintf to avoid int-overflow issues.
7625 * font.c: Include <float.h>, for DBL_MAX_10_EXP.
7626 (font_unparse_xlfd): Don't blindly alloca long strings.
7627 Don't assume XINT result fits in int, or that XFLOAT_DATA * 10
7628 fits in int, when using sprintf. Use single snprintf to count
7629 length of string rather than counting it via multiple sprintfs;
7630 that's simpler and more reliable.
7631 (font_unparse_fcname): Use it to avoid sprintf buffer overrun.
7632 (generate_otf_features) [0 && HAVE_LIBOTF]: Use esprintf, not
7633 sprintf, in case result does not fit in int.
7635 * fontset.c (num_auto_fontsets): Now printmax_t, not int.
7636 (fontset_from_font): Print it.
7638 * frame.c (tty_frame_count): Now printmax_t, not int.
7639 (make_terminal_frame, set_term_frame_name): Print it.
7640 (x_report_frame_params): In X, window IDs are unsigned long,
7641 not signed long, so print them as unsigned.
7642 (validate_x_resource_name): Check for implausibly long names,
7643 and don't assume name length fits in 'int'.
7644 (x_get_resource_string): Don't blindly alloca invocation name;
7645 use SAFE_ALLOCA. Use esprintf, not sprintf, in case result does
7648 * gtkutil.c: Include <float.h>, for DBL_MAX_10_EXP.
7649 (xg_check_special_colors, xg_set_geometry):
7650 Make sprintf buffers a bit bigger, to avoid potential buffer overrun.
7652 * lread.c (dir_warning): Don't blindly alloca buffer; use SAFE_ALLOCA.
7653 Use esprintf, not sprintf, in case result does not fit in int.
7655 * macros.c (executing_kbd_macro_iterations): Now EMACS_INT, not int.
7656 (Fend_kbd_macro): Don't mishandle MOST_NEGATIVE_FIXNUM by treating
7657 it as a large positive number.
7658 (Fexecute_kbd_macro): Don't assume repeat count fits in int.
7659 * macros.h (executing_kbd_macro_iterations): Now EMACS_INT, not int.
7661 * nsterm.m ((NSSize)windowWillResize): Use esprintf, not sprintf,
7662 in case result does not fit in int.
7664 * print.c (float_to_string): Detect width overflow more reliably.
7665 (print_object): Make sprintf buffer a bit bigger, to avoid potential
7666 buffer overrun. Don't assume list length fits in 'int'. Treat
7667 print length of 0 as 0, not as infinity; to be consistent with other
7668 uses of print length in this function. Don't overflow print length
7669 index. Don't assume hash table size fits in 'long', or that
7670 vectorlike size fits in 'unsigned long'.
7672 * process.c (make_process): Use printmax_t, not int, to format
7673 process-name gensyms.
7675 * sysdep.c (snprintf) [! HAVE_SNPRINTF]: New function.
7677 * term.c (produce_glyphless_glyph): Make sprintf buffer a bit bigger
7678 to avoid potential buffer overrun.
7680 * xfaces.c (x_update_menu_appearance): Don't overrun buffer
7681 if X resource line is longer than 512 bytes.
7683 * xfns.c (x_window): Make sprintf buffer a bit bigger
7684 to avoid potential buffer overrun.
7686 * xterm.c (x_io_error_quitter): Don't overrun sprintf buffer.
7688 * xterm.h (x_check_errors): Add ATTRIBUTE_FORMAT_PRINTF.
7690 2011-09-04 Paul Eggert <eggert@cs.ucla.edu>
7692 Integer overflow fixes for scrolling, etc.
7693 Without these, Emacs silently mishandles large integers sometimes.
7694 For example, "C-u 4294967297 M-x recenter" was treated as if
7695 it were "C-u 1 M-x recenter" on a typical 64-bit host.
7697 * xdisp.c (try_window_id): Check Emacs fixnum range before
7698 converting to 'int'.
7700 * window.c (window_scroll_line_based, Frecenter):
7701 Check that an Emacs fixnum is in range before assigning it to 'int'.
7702 (Frecenter, Fmove_to_window_line): Use EMACS_INT, not int, for
7703 values converted from Emacs fixnums.
7704 (Frecenter): Don't wrap around a line count if it is out of 'int'
7705 range; instead, treat it as an extreme value.
7706 (Fset_window_configuration, compare_window_configurations):
7707 Use ptrdiff_t, not int, for index that might exceed 2 GiB.
7709 * search.c (Freplace_match): Use ptrdiff_t, not int, for indexes
7710 that can exceed INT_MAX. Check that EMACS_INT value is in range
7711 before assigning it to the (possibly-narrower) index.
7712 (match_limit): Don't assume that a fixnum can fit in 'int'.
7714 * print.c (print_object): Use ptrdiff_t, not int, for index that can
7717 * indent.c (position_indentation): Now takes ptrdiff_t, not int.
7718 (Fvertical_motion): Don't wrap around LINES values that don't fit
7719 in 'int'. Instead, treat them as extreme values. This is good
7720 enough for windows, which can't have more than INT_MAX lines anyway.
7722 2011-09-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
7724 * Require libxml/parser.h to avoid compilation warning.
7726 * emacs.c (shut_down_emacs): Call xmlCleanupParser on shutdown.
7728 * xml.c (parse_region): Don't call xmlCleanupParser after parsing,
7729 since this reportedly can destroy thread storage.
7731 2011-08-30 Chong Yidong <cyd@stupidchicken.com>
7733 * syntax.c (find_defun_start): Update all cache variables if
7734 exiting early (Bug#9401).
7736 2011-08-30 Eli Zaretskii <eliz@gnu.org>
7738 * image.c (x_bitmap_pixmap): Cast to int to avoid compiler warnings.
7740 * xdisp.c (produce_stretch_glyph): No longer static, compiled also
7741 when HAVE_WINDOW_SYSTEM is not defined. Support both GUI and TTY
7742 frames. Call tty_append_glyph in the TTY case. (Bug#9402)
7744 * term.c (tty_append_glyph): New function.
7745 (produce_stretch_glyph): Static function and its prototype deleted.
7747 * dispextern.h (produce_stretch_glyph, tty_append_glyph):
7750 2011-08-29 Paul Eggert <eggert@cs.ucla.edu>
7752 * image.c (parse_image_spec): Check for nonnegative, not for positive,
7753 when checking :margin (Bug#9390).
7754 (IMAGE_NON_NEGATIVE_INTEGER_VALUE_OR_PAIR):
7755 Rename from IMAGE_POSITIVE_INTEGER_VALUE_OR_PAIR,
7756 so that the name doesn't mislead. All uses changed.
7758 2011-08-28 Johan Bockgård <bojohan@gnu.org>
7760 * term.c (init_tty) [HAVE_GPM]: Move mouse settings after
7763 2011-08-27 Eli Zaretskii <eliz@gnu.org>
7765 * xdisp.c (move_it_to): Don't bail out early when reaching
7766 position beyond to_charpos, if we are scanning backwards.
7767 (move_it_vertically_backward): When DY == 0, make sure we get to
7768 the first character in the line after the newline.
7770 2011-08-27 Paul Eggert <eggert@cs.ucla.edu>
7772 * ccl.c: Improve and simplify overflow checking (Bug#9196).
7773 (ccl_driver): Do not generate an out-of-range pointer.
7774 (Fccl_execute_on_string): Remove unnecessary check for
7775 integer overflow, noted by Stefan Monnier in
7776 <http://lists.gnu.org/archive/html/emacs-devel/2011-08/msg00979.html>.
7777 Remove a FIXME that didn't need fixing.
7778 Simplify the newly-introduced buffer reallocation code.
7780 2011-08-27 Juanma Barranquero <lekktu@gmail.com>
7782 * makefile.w32-in ($(BLD)/alloc.$(O)): Depend on lib/verify.h.
7784 2011-08-26 Paul Eggert <eggert@cs.ucla.edu>
7786 Integer and memory overflow issues (Bug#9196).
7788 * doc.c (get_doc_string): Rework so that
7789 get_doc_string_buffer_size is the actual buffer size, rather than
7790 being 1 less than the actual buffer size; this makes xpalloc more
7793 * image.c (x_allocate_bitmap_record, cache_image):
7794 * xselect.c (Fx_register_dnd_atom):
7795 Simplify previous changes by using xpalloc.
7797 * buffer.c (overlay_str_len): Now ptrdiff_t, not EMACS_INT,
7798 since either will do and ptrdiff_t is convenient with xpalloc.
7800 * charset.c (charset_table_size)
7801 (struct charset_sort_data.priority): Now ptrdiff_t.
7802 (charset_compare): Don't overflow if priorities differ greatly.
7803 (Fsort_charsets): Don't assume list length fits in int.
7804 Check for size-calculation overflow when allocating sort data.
7805 (syms_of_charset): Allocate an initial charset table that is
7806 just under 64 KiB, to avoid problems with glibc malloc and mmap.
7808 * cmds.c (internal_self_insert): Check for size-calculation overflow.
7810 * composite.h (struct composition.glyph_len): Now int, not unsigned.
7811 The actual value is always <= INT_MAX, and leaving it unsigned made
7812 overflow checking harder.
7814 * dispextern.h (struct glyph_matrix.rows_allocated)
7815 (struct face_cache.size): Now ptrdiff_t, for convenience in use
7816 with xpalloc. The values are still always <= INT_MAX.
7818 * indent.c (compute_motion): Adjust to region_cache_forward sig change.
7820 * lisp.h (xnmalloc, xnrealloc, xpalloc): New decls.
7821 (SAFE_NALLOCA): New macro.
7823 * region-cache.c (struct boundary.pos, find_cache_boundary)
7824 (move_cache_gap, insert_cache_boundary, delete_cache_boundaries)
7825 (set_cache_region, invalidate_region_cache)
7826 (revalidate_region_cache, know_region_cache, region_cache_forward)
7827 (region_cache_backward, pp_cache):
7828 Use ptrdiff_t, not EMACS_INT, since either will do. This is needed
7829 so that ptrdiff_t * can be passed to xpalloc.
7830 (struct region_cache): Similarly, for gap_start, gap_len, cache_len,
7831 beg_unchanged, end_unchanged, buffer_beg, buffer_end members.
7832 (pp_cache): Don't assume cache_len fits in int.
7833 * region-cache.h: Adjust extern decls to match.
7835 * search.c (scan_buffer, Freplace_match): Use ptrdiff_t, not
7836 EMACS_INT, since either will do, for xpalloc.
7838 * alloc.c: Include verify.h, and check that int fits in ptrdiff_t.
7839 (xnmalloc, xnrealloc, xpalloc): New functions.
7841 * bidi.c (bidi_shelve_header_size): New constant.
7842 (bidi_cache_ensure_space, bidi_shelve_cache): Use it.
7843 (bidi_cache_ensure_space): Avoid integer overflow when allocating.
7845 * bidi.c (bidi_cache_shrink):
7846 * buffer.c (overlays_at, overlays_in, record_overlay_string)
7848 Don't update size of array until after memory allocation succeeds,
7849 because xmalloc/xrealloc may not return.
7850 (struct sortstrlist.bytes): Now ptrdiff_t, as EMACS_INT doesn't help
7851 now that we have proper integer overflow checking.
7852 (record_overlay_string, overlay_strings): Catch overflows when
7853 calculating size of overlay_str_buf.
7855 * callproc.c (Fcall_process): Check for size overflow when
7856 calculating size of args2.
7857 (child_setup): Avoid overflow by using size_t rather than ptrdiff_t.
7858 Normally we prefer signed values, but sticking with ptrdiff_t would
7859 require adding more-complicated checks.
7861 * ccl.c (Fccl_execute_on_string): Check for memory overflow.
7862 Use ptrdiff_t rather than EMACS_INT where ptrdiff_t will do.
7863 Redo buffer-overflow calculations to avoid integer overflow.
7864 Add a FIXME comment where memory seems to be over-allocated.
7866 * character.c (Fstring): Check for size-calculation overflow.
7868 * coding.c (produce_chars): Redo buffer-overflow calculations to avoid
7869 unnecessary integer overflow. Check for size overflow.
7870 (encode_coding_object): Don't update size until xmalloc succeeds.
7872 * composite.c (get_composition_id): Check for overflow in glyph
7873 length calculations.
7875 Integer and memory overflow fixes for display code.
7876 * dispextern.h (struct glyph_pool.nglyphs): Now ptrdiff_t, not int.
7877 * dispnew.c (adjust_glyph_matrix, realloc_glyph_pool)
7878 (scrolling_window): Check for overflow in size calculations.
7879 (line_draw_cost, realloc_glyph_pool, add_row_entry):
7880 Don't assume glyph table len fits in int.
7881 (struct row_entry.bucket, row_entry_pool_size, row_entry_idx)
7882 (row_table_size): Now ptrdiff_t, not int.
7883 (scrolling_window): Avoid overflow in size calculations.
7884 Don't update size until allocation succeeds.
7885 * fns.c (concat): Check for overflow in size calculations.
7886 (next_almost_prime): Verify NEXT_ALMOST_PRIME_LIMIT.
7887 * lisp.h (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): New macros.
7888 (NEXT_ALMOST_PRIME_LIMIT): New constant.
7890 * doc.c (get_doc_string_buffer_size): Now ptrdiff_t, not int.
7891 (get_doc_string): Check for size calculation overflow.
7892 Don't update size until allocation succeeds.
7893 (get_doc_string, Fsubstitute_command_keys): Use ptrdiff_t, not
7894 EMACS_INT, where ptrdiff_t will do.
7895 (Fsubstitute_command_keys): Check for string overflow.
7897 * editfns.c (set_time_zone_rule): Don't assume environment length
7899 (message_length): Now ptrdiff_t, not int.
7900 (Fmessage_box): Don't update size until allocation succeeds.
7901 Don't assume message length fits in int.
7902 (Fformat): Use ptrdiff_t, not EMACS_INT, where ptrdiff_t will do.
7904 * emacs.c (main): Do not reallocate argv, since there is a null at
7905 the end that can be overwritten, and this way there's no need to
7906 worry about size-calculation overflow.
7907 (sort_args): Check for size-calculation overflow.
7909 * eval.c (init_eval_once, grow_specpdl): Don't update size until
7911 (call_debugger, grow_specpdl): Redo calculations to avoid overflow.
7913 * frame.c (set_menu_bar_lines, x_set_frame_parameters)
7914 (x_set_scroll_bar_width, x_figure_window_size):
7915 Check for integer overflow.
7916 (x_set_alpha): Do not assume XINT fits in int.
7918 * frame.h (struct frame): Use int, not EMACS_INT, where int works.
7919 This is for the members text_lines, text_cols, total_lines, total_cols,
7920 where the system imposes an 'int' limit.
7922 * fringe.c (Fdefine_fringe_bitmap):
7923 Don't update size until alloc works.
7925 * ftfont.c (ftfont_get_open_type_spec, setup_otf_gstring)
7926 (ftfont_shape_by_flt): Check for integer overflow in size calculations.
7928 * gtkutil.c (get_utf8_string, xg_store_widget_in_map):
7929 Check for size-calculation overflow.
7930 (get_utf8_string): Use ptrdiff_t, not size_t, where either will
7931 do, as we prefer signed integers.
7932 (id_to_widget.max_size, id_to_widget.used)
7933 (xg_store_widget_in_map, xg_remove_widget_from_map)
7934 (xg_get_widget_from_map, xg_get_scroll_id_for_window)
7935 (xg_remove_scroll_bar, xg_update_scrollbar_pos):
7936 Use and return ptrdiff_t, not int.
7937 (xg_gtk_scroll_destroy): Don't assume ptrdiff_t fits in int.
7938 * gtkutil.h: Change prototypes to match the above.
7940 * image.c (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): Remove; these
7941 are duplicate now that they've been promoted to lisp.h.
7942 (x_allocate_bitmap_record, x_alloc_image_color)
7943 (make_image_cache, cache_image, xpm_load):
7944 Don't update size until alloc is done.
7945 (xpm_load, lookup_rgb_color, lookup_pixel_color, x_to_xcolors)
7947 Check for size calculation overflow.
7948 (ct_colors_allocated_max): New constant.
7949 (x_to_xcolors, x_detect_edges): Reorder multiplicands to avoid
7952 * keyboard.c (read_char, menu_bar_items, tool_bar_items)
7953 (read_char_x_menu_prompt, read_char_minibuf_menu_width)
7954 (read_char_minibuf_menu_prompt, follow_key, read_key_sequence):
7955 Use ptrdiff_t, not int, to count maps.
7956 (read_char_minibuf_menu_prompt): Check for overflow in size
7957 calculations. Don't update size until allocation succeeds.
7958 Redo calculations to avoid overflow.
7959 * keyboard.h: Change prototypes to match the above.
7961 * keymap.c (cmm_size, current_minor_maps): Use ptrdiff_t, not int,
7963 (current_minor_maps): Check for size calculation overflow.
7964 * keymap.h: Change prototypes to match the above.
7966 * lread.c (read1, init_obarray): Don't update size until alloc done.
7968 * macros.c (Fstart_kbd_macro): Don't update size until alloc done.
7969 (store_kbd_macro_char): Reorder multiplicands to avoid overflow.
7971 * nsterm.h (struct ns_color_table.size, struct ns_color_table.avail):
7972 Now ptrdiff_t, not int.
7973 * nsterm.m (ns_index_color): Use ptrdiff_t, not int, for table indexes.
7974 (ns_draw_fringe_bitmap): Rewrite to avoid overflow.
7976 * process.c (Fnetwork_interface_list): Check for overflow
7977 in size calculation.
7979 * region-cache.c (move_cache_gap): Check for size calculation overflow.
7981 * scroll.c (do_line_insertion_deletion_costs): Check for size calc
7982 overflow. Don't bother calling xmalloc when xrealloc will do.
7984 * search.c (Freplace_match): Check for size calculation overflow.
7985 (Fset_match_data): Don't assume list lengths fit in 'int'.
7987 * sysdep.c (system_process_attributes): Use ptrdiff_t, not int,
7988 for command line length. Do not attempt to address one before the
7989 beginning of an array, as that's not portable.
7991 * term.c (max_frame_lines): Remove; unused.
7992 (encode_terminal_src_size, encode_terminal_dst_size): Now ptrdiff_t,
7994 (encode_terminal_code, calculate_costs): Check for size
7995 calculation overflow.
7996 (encode_terminal_code): Use ptrdiff_t, not int, to record glyph
7997 table lengths and related sizes. Don't update size until alloc
7998 done. Redo calculations to avoid overflow.
7999 (calculate_costs): Don't bother calling xmalloc when xrealloc will do.
8001 * termcap.c (tgetent): Use ptrdiff_t, not int, to record results of
8002 subtracting pointers.
8003 (gobble_line): Check for overflow more carefully. Don't update size
8006 * tparam.c (tparam1): Use ptrdiff_t, not int, for sizes.
8007 Don't update size until alloc done.
8008 Redo size calculations to avoid overflow.
8009 Check for size calculation overflow.
8010 (main) [DEBUG]: Fix typo in invoking tparam1.
8012 * xdisp.c (store_mode_line_noprop_char, x_consider_frame_title):
8013 Use ptrdiff_t, not int, for sizes.
8014 (store_mode_line_noprop_char): Don't update size until alloc done.
8016 * xfaces.c (lface_id_to_name_size, Finternal_make_lisp_face):
8017 Use ptrdiff_t, not int, for sizes.
8018 (Finternal_make_lisp_face, cache_face):
8019 Check for size calculation overflow.
8020 (cache_face): Treat size calculation overflows as if they were
8021 memory exhaustion (the usual treatment), rather than aborting.
8023 * xfns.c (x_encode_text, x_set_name_internal)
8024 (Fx_change_window_property): Use ptrdiff_t, not int, to count
8025 sizes, since they can exceed INT_MAX in size. Check for size
8026 calculation overflow.
8028 * xgselect.c (gfds_size): Now ptrdiff_t, for convenience with xpalloc.
8029 (xg_select): Check for size calculation overflow.
8030 Don't update size until alloc done.
8032 * xrdb.c (get_environ_db): Don't assume path length fits in int,
8033 as sprintf is limited to int lengths.
8035 * xselect.c (X_LONG_SIZE, X_SHRT_MAX, X_SHRT_MIN, X_LONG_MAX)
8036 (X_LONG_MIN): New macros.
8037 Use them to make the following changes clearer.
8038 (MAX_SELECTION_QUANTUM): Make the other bounds on this value clearer.
8039 This change doesn't affect the value now, but it may help remind
8040 future maintainers not to raise the value too much later.
8041 (SELECTION_QUANTUM): Remove, replacing with ...
8042 (selection_quantum): ... new function, which avoids overflow.
8044 (struct selection_data.size): Now ptrdiff_t, not int, to avoid
8045 assumption that selection length fits in 'int'.
8046 (x_reply_selection_request, x_handle_selection_request)
8047 (x_get_window_property, receive_incremental_selection)
8048 (x_get_window_property_as_lisp_data, selection_data_to_lisp_data)
8049 (lisp_data_to_selection_data, clean_local_selection_data):
8050 Use ptrdiff_t, not int, to record length of selection.
8051 (x_reply_selection_request, x_get_window_property)
8052 (receive_incremental_selection, x_property_data_to_lisp):
8053 Redo calculations to avoid overflow.
8054 (x_reply_selection_request): When sending hint, ceiling it at
8055 X_LONG_MAX rather than relying on wraparound overflow to send
8057 (x_get_window_property, receive_incremental_selection)
8058 (lisp_data_to_selection_data, x_property_data_to_lisp):
8059 Check for size-calculation overflow.
8060 (x_get_window_property, receive_incremental_selection)
8061 (lisp_data_to_selection_data, Fx_register_dnd_atom):
8062 Don't store size until memory allocation succeeds.
8063 (x_get_window_property): Plug memory leak on memory exhaustion.
8064 Don't double-block input; malloc is safe here. Don't assume 2**34
8065 - 4 fits in unsigned long. Add an xassert to check
8066 XGetWindowProperty overflow. Be more careful about overflow
8067 calculations, and distinguish size from memory overflow better.
8068 (receive_incremental_selection): When tracing, don't assume
8069 unsigned int is less than INT_MAX.
8070 (x_selection_data_to_lisp_data): Remove unnecessary (and in theory
8071 harmful) conversions of unsigned short to int.
8072 (lisp_data_to_selection_data): Don't assume that integers
8073 in the range -65535 through -1 fit in an X unsigned short.
8074 Don't assume that ULONG_MAX == X_ULONG_MAX. Don't store into
8075 result parameters unless successful. Rely on cons_to_unsigned
8076 to report problems with elements; the old code wasn't right anyway.
8077 (x_check_property_data): Check for int overflow; we cannot use
8078 a wider type due to X limits.
8079 (x_handle_dnd_message): Use unsigned int, to avoid int overflow.
8081 * xsmfns.c (smc_save_yourself_CB): Check for size calc overflow.
8083 * xterm.c (x_color_cells, x_send_scrollbar_event, handle_one_xevent)
8084 (x_term_init): Check for size calculation overflow.
8085 (x_color_cells): Don't store size until memory allocation succeeds.
8086 (handle_one_xevent): Use ptrdiff_t, not int, for byte counts.
8087 Don't assume alloca size is less than MAX_ALLOCA.
8088 (x_term_init): Don't assume length fits in int (sprintf is limited
8091 Use ptrdiff_t for composition IDs.
8092 * character.c (lisp_string_width):
8093 * composite.c (composition_table_size, n_compositions)
8094 (get_composition_id, composition_gstring_from_id):
8095 * dispextern.h (struct glyph_string.cmp_id, struct composition_it.id):
8096 * xdisp.c (BUILD_COMPOSITE_GLYPH_STRING):
8097 * window.c (Frecenter):
8098 Use ptrdiff_t, not int, for composition IDs.
8099 * composite.c (get_composition_id): Check for integer overflow.
8100 * composite.h: Adjust prototypes to match the above changes.
8102 Use ptrdiff_t for hash table indexes.
8103 * category.c (hash_get_category_set):
8104 * ccl.c (ccl_driver):
8105 * charset.h (struct charset.hash_index, CHECK_CHARSET_GET_ID):
8106 * coding.c (coding_system_charset_list, detect_coding_system):
8107 * coding.h (struct coding_system.id):
8108 * composite.c (get_composition_id, gstring_lookup_cache):
8109 * fns.c (hash_lookup, hash_put, Fgethash, Fputhash):
8110 * image.c (xpm_get_color_table_h):
8111 * lisp.h (hash_lookup, hash_put):
8112 * minibuf.c (Ftest_completion):
8113 Use ptrdiff_t for hash table indexes, not int (which is too
8114 narrow, on 64-bit hosts) or EMACS_INT (which is too wide, on
8115 32-bit --with-wide-int hosts).
8117 * charset.c (Fdefine_charset_internal): Check for integer overflow.
8118 Add a FIXME comment about memory leaks.
8119 (syms_of_charset): Don't assume xmalloc returns.
8121 Don't assume that stated character widths fit in int.
8122 * character.c (Fchar_width, c_string_width, lisp_string_width):
8123 * character.h (CHAR_WIDTH):
8124 * indent.c (MULTIBYTE_BYTES_WIDTH):
8125 Use sanitize_char_width to avoid undefined and/or bad behavior
8126 with outlandish widths.
8127 * character.h (sanitize_tab_width): Rename from sanitize_width,
8128 now that we have two such functions. All uses changed.
8129 (sanitize_char_width): New inline function.
8131 Don't assume that tab-width fits in int.
8132 * character.h (sanitize_width): New inline function.
8133 (SANE_TAB_WIDTH): New macro.
8134 (ASCII_CHAR_WIDTH): Use it.
8135 * indent.c (sane_tab_width): Remove. All uses replaced by
8136 SANE_TAB_WIDTH (current_buffer).
8137 * xdisp.c (init_iterator): Use SANE_TAB_WIDTH.
8139 * fileio.c: Integer overflow issues with file modes.
8140 (Fset_file_modes, auto_save_1): Don't assume EMACS_INT fits in int.
8142 * charset.c (read_hex): New arg OVERFLOW. All uses changed.
8143 Remove unreachable code.
8144 (read_hex, load_charset_map_from_file): Check for integer overflow.
8146 * xterm.c: Don't go over XClientMessageEvent limit.
8147 (scroll_bar_windows_size): Now ptrdiff_t, as we prefer signed.
8148 (x_send_scroll_bar_event): Likewise. Check that the size does not
8149 exceed limits imposed by XClientMessageEvent, as well as the usual
8150 ptrdiff_t and size_t limits.
8152 * keyboard.c: Overflow, signedness and related fixes.
8153 (make_lispy_movement): Use same integer type in forward decl
8154 that is used in the definition.
8155 (read_key_sequence, keyremap_step):
8156 Change bufsize argument back to int, undoing my 2011-03-30 change.
8157 We prefer signed types, and int is wide enough here.
8158 (parse_tool_bar_item): Don't assume tool_bar_max_label_size is less
8159 than TYPE_MAXIMUM (EMACS_INT) / 2. Don't let the label size grow
8160 larger than STRING_BYTES_BOUND. Use ptrdiff_t for Emacs string
8161 length, not size_t. Use ptrdiff_t for index, not int.
8162 (keyremap_step, read_key_sequence): Redo bufsize check to avoid
8163 possibility of integer overflow.
8165 Overflow, signedness and related fixes for images.
8167 * dispextern.h (struct it.stack[0].u.image.image_id)
8168 (struct_it.image_id, struct image.id, struct image_cache.size)
8169 (struct image_cache.used, struct image_cache.ref_count):
8170 * gtkutil.c (update_frame_tool_bar):
8171 * image.c (x_reference_bitmap, Fimage_size, Fimage_mask_p)
8172 (Fimage_metadata, free_image_cache, clear_image_cache, lookup_image)
8173 (cache_image, mark_image_cache, x_kill_gs_process, Flookup_image):
8174 * nsmenu.m (update_frame_tool_bar):
8175 * xdisp.c (calc_pixel_width_or_height):
8176 * xfns.c (image_cache_refcount):
8177 Image IDs are now ptrdiff_t, not int, to avoid arbitrary limits
8178 on typical 64-bit hosts.
8180 * image.c (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): New macros.
8181 (x_bitmap_pixmap, x_create_x_image_and_pixmap):
8182 Omit unnecessary casts to int.
8183 (parse_image_spec): Check that integers fall into 'int' range
8184 when the callers expect that.
8185 (image_ascent): Redo ascent calculation to avoid int overflow.
8186 (clear_image_cache): Avoid overflow when sqrt (INT_MAX) < nimages.
8187 (lookup_image): Remove unnecessary tests.
8188 (xbm_image_p): Locals are now of int, not EMACS_INT,
8189 since parse_image_check makes sure they fit into int.
8190 (png_load, gif_load, svg_load_image):
8191 Prefer int to unsigned where either will do.
8192 (tiff_handler): New function, combining the cores of the
8193 old tiff_error_handler and tiff_warning_handler.
8194 This function is rewritten to use vsnprintf and thereby avoid
8195 stack buffer overflows. It uses only the features of vsnprintf
8196 that are common to both POSIX and native Microsoft.
8197 (tiff_error_handler, tiff_warning_handler): Use it.
8198 (tiff_load, gif_load, imagemagick_load_image):
8199 Don't assume :index value fits in 'int'.
8200 (gif_load): Omit unnecessary cast to double, and avoid double-rounding.
8201 (imagemagick_load_image): Check that crop parameters fit into
8202 the integer types that MagickCropImage accepts. Don't assume
8203 Vimagemagick_render_type has a nonnegative value. Don't assume
8204 size_t fits in 'long'.
8205 (gs_load): Use printmax_t to print the widest integers possible.
8206 Check for integer overflow when computing image height and width.
8208 2011-08-26 Eli Zaretskii <eliz@gnu.org>
8210 * xdisp.c (redisplay_window): Don't force window start if point
8211 will be invisible in the resulting window. (Bug#9324)
8213 2011-08-25 Eli Zaretskii <eliz@gnu.org>
8215 * xdisp.c (compute_display_string_pos): Return 2 in DISP_PROP when
8216 the display spec is of the form `(space ...)'.
8217 (handle_display_spec): Return the value returned by
8218 handle_single_display_spec, not just 1 or zero.
8219 (handle_single_display_spec): If the display spec is of the form
8220 `(space ...)', and specifies display in the text area, return 2
8222 (try_cursor_movement): Check for the need to scroll more
8223 accurately, and prefer exact match for point under bidi.
8224 Don't advance `row' beyond the last row of the window.
8226 * dispextern.h (struct bidi_it): Rename the disp_prop_p member
8227 into disp_prop; all users changed.
8229 * bidi.c (bidi_fetch_char): If compute_display_string_pos returns
8230 DISP_PROP = 2, substitute the u+2029 PARAGRAPH SEPARATOR character
8231 for the text covered by the display property.
8233 2011-08-25 Chong Yidong <cyd@stupidchicken.com>
8235 * buffer.c (Fbury_buffer_internal): Rename from Funrecord_buffer.
8236 Change return value to nil.
8237 (Frecord_buffer): Delete unused function.
8239 2011-08-24 Eli Zaretskii <eliz@gnu.org>
8241 * xdisp.c (Fcurrent_bidi_paragraph_direction): For unibyte
8242 buffers, return left-to-right.
8243 (set_cursor_from_row): Consider candidate row a win if its glyph
8244 represents a newline and point is on that newline. Fixes cursor
8245 positioning on the newline at EOL of R2L text within L2R
8246 paragraph, and vice versa.
8247 (try_cursor_movement): Check continued rows, in addition to
8248 continuation rows. Fixes unwarranted scroll when point enters a
8249 continued line of R2L text within an L2R paragraph, or vice versa.
8250 (cursor_row_p): Consider the case of point being equal to
8251 MATRIX_ROW_END_CHARPOS. Prevents cursor being stuck when moving
8252 from the end of a short line to the beginning of a continued line
8253 of R2L text within L2R paragraph.
8254 (RECORD_MAX_MIN_POS): For max_pos, use IT_CHARPOS even for
8255 composed characters.
8257 * bidi.c (bidi_check_type): Use xassert.
8258 (bidi_cache_iterator_state): Update the disp_pos and disp_prop_p
8261 2011-08-23 Eli Zaretskii <eliz@gnu.org>
8263 * bidi.c (bidi_get_type): Abort if we get zero as the bidi type of
8266 2011-08-23 Chong Yidong <cyd@stupidchicken.com>
8268 * nsfont.m (ns_otf_to_script): Fix typo.
8270 2011-08-22 Kenichi Handa <handa@m17n.org>
8272 * chartab.c (Fset_char_table_extra_slot): Do not inhibit setting a
8273 extra slot even if the purpose is char-code-property-table.
8275 2011-08-23 Eli Zaretskii <eliz@gnu.org>
8277 * xdisp.c (redisplay_window): When computing centering_position,
8278 account for the height of the header line. (Bug#8874)
8280 * dispnew.c (buffer_posn_from_coords): Use buf_charpos_to_bytepos
8281 instead of CHAR_TO_BYTE. Fixes a crash when a completion
8282 candidate is selected by the mouse, and that candidate has a
8283 composed character under the mouse.
8285 * xdisp.c (x_produce_glyphs): Set it->nglyphs to 1. Fixes pixel
8286 coordinates reported by pos-visible-in-window-p for a composed
8287 character in column zero.
8289 2011-08-23 Stefan Monnier <monnier@iro.umontreal.ca>
8291 * cmds.c (Fself_insert_command): Mention post-self-insert-hook.
8293 2011-08-22 Eli Zaretskii <eliz@gnu.org>
8295 * xdisp.c (BUFFER_POS_REACHED_P): If this is a composition,
8296 consider it a hit if to_charpos is anywhere in the range of the
8297 composed buffer positions.
8299 2011-08-22 Chong Yidong <cyd@stupidchicken.com>
8301 * image.c (gif_load): Don't assume that each subimage has the same
8302 dimensions as the base image. Handle disposal method that is
8303 "undefined" by the gif spec (Bug#9335).
8305 2011-08-20 Chong Yidong <cyd@stupidchicken.com>
8307 * eval.c (Fsignal): Handle `debug' symbol in error handler (Bug#9329).
8308 (Fcondition_case): Document `debug' symbol in error handler.
8310 2011-08-19 Eli Zaretskii <eliz@gnu.org>
8312 * xfaces.c (face_at_buffer_position): Avoid repeated evaluation of
8313 face ID by FACE_FROM_ID, and avoid a crash when mouse is moved
8314 from an Org mode buffer to a Speedbar frame.
8316 * xdisp.c (RECORD_MAX_MIN_POS): If the display element comes from
8317 a composition, take its buffer position from IT->cmp_it.charpos.
8318 Fixes cursor positioning at the beginning of a line that begins
8319 with a composed character.
8321 2011-08-18 Eli Zaretskii <eliz@gnu.org>
8323 * bidi.c (bidi_get_type): If bidi_type_table reports zero as the
8324 character bidirectional type, use STRONG_L instead. Fixes crashes
8325 in a buffer produced by `describe-categories'.
8327 * dispextern.h (struct bidi_it): Move disp_pos and disp_prop_p
8328 members before the level stack, so they would be saved and
8329 restored when copying iterator state. Fixes incorrect reordering
8330 around TABs covered by display properties.
8332 2011-08-18 Andreas Schwab <schwab@linux-m68k.org>
8334 * process.c (Fnetwork_interface_list): Correctly determine buffer size.
8336 2011-08-17 Chong Yidong <cyd@stupidchicken.com>
8338 * eval.c (internal_condition_case, internal_condition_case_1)
8339 (internal_condition_case_2, internal_condition_case_n):
8340 Remove unnecessary aborts (Bug#9081).
8342 2011-08-17 Eli Zaretskii <eliz@gnu.org>
8344 * lread.c (Fload) [DOS_NT]: If `openp' returns -2, but the file
8345 has no `load' handler, try opening the file locally. (Bug#9311)
8347 2011-08-16 Ken Brown <kbrown@cornell.edu>
8349 * gmalloc.c: Expand comment.
8351 2011-08-16 Eli Zaretskii <eliz@gnu.org>
8353 * xdisp.c (set_cursor_from_row): Don't accept a previous candidate
8354 if it fails the cursor_row_p test. Fixes cursor positioning at ZV.
8356 2011-08-16 Ken Brown <kbrown@cornell.edu>
8358 Fix memory allocation problems in Cygwin build (Bug#9273).
8360 * unexcw.c ( __malloc_initialized): Declare external variable.
8361 (fixup_executable): Force the dumped emacs to reinitialize malloc.
8363 * gmalloc.c [CYGWIN] (bss_sbrk_heapbase, bss_sbrk_heapinfo):
8365 (malloc_initialize_1) [CYGWIN]: Prepare for reinitializing the
8367 (_free_internal_nolock) [CYGWIN]: Ignore requests to free storage
8369 [CYGWIN] (special_realloc): New function.
8370 (_realloc_internal_nolock) [CYGWIN]: Use the new function on
8371 requests to realloc storage in the static heap.
8373 2011-08-15 Paul Eggert <eggert@cs.ucla.edu>
8375 * bidi.c (bidi_initialize): Remove unused local.
8377 2011-08-15 Eli Zaretskii <eliz@gnu.org>
8380 * biditype.h: Remove file.
8381 * makefile.w32-in ($(BLD)/bidi.$(O)):
8382 * deps.mk (bidi.o): Remove biditype.h and bidimirror.h.
8384 * dispextern.h: Fix a typo in the comment to bidi_type_t.
8386 * chartab.c: Improve commentary for the uniprop_table API.
8388 * bidi.c (bidi_paragraph_init): Support zero value of
8389 bidi_ignore_explicit_marks_for_paragraph_level.
8390 (bidi_initialize): Use uniprop_table instead of including
8391 biditype.h and bidimirror.h.
8393 * xdisp.c (move_it_in_display_line_to): Don't reset pixel
8394 coordinates of the iterator when restoring from ppos_it.
8397 2011-08-14 Kenichi Handa <handa@m17n.org>
8399 * process.c (create_process): Call setup_process_coding_systems
8400 after the pid of the process is set to -1 (Bug#8162).
8402 2011-08-14 Eli Zaretskii <eliz@gnu.org>
8404 * xdisp.c (move_it_in_display_line_to): Don't invoke
8405 IT_RESET_X_ASCENT_DESCENT when iterator position was restored from
8406 ppos_it. Fixes vertical cursor motion when line beginning is
8407 covered by an image. (Bug#9296)
8409 2011-08-14 Jan Djärv <jan.h.d@swipnet.se>
8411 * nsterm.h (ns_run_ascript): Declare.
8412 (NSAPP_DATA2_RUNASSCRIPT): Define.
8414 * nsfns.m (as_script, as_result, as_status): New static variables.
8415 (ns_run_ascript): New function.
8416 (Fns_do_applescript): Set variables as_*. Make an NSApplicationDefined
8417 event with data2 set to NSAPP_DATA2_RUNASSCRIPT, post it and then start
8418 the event loop. Get status from as_status (Bug#7276).
8420 * nsterm.m (sendEvent): If event is NSApplicationDefined and
8421 data2 is NSAPP_DATA2_RUNASSCRIPT, call ns_run_ascript and then exit
8422 the event loop (Bug#7276).
8424 2011-08-14 Andreas Schwab <schwab@linux-m68k.org>
8426 * gnutls.c (QCgnutls_bootprop_priority)
8427 (QCgnutls_bootprop_trustfiles, QCgnutls_bootprop_keylist)
8428 (QCgnutls_bootprop_crlfiles, QCgnutls_bootprop_callbacks)
8429 (QCgnutls_bootprop_loglevel, QCgnutls_bootprop_hostname)
8430 (QCgnutls_bootprop_min_prime_bits, QCgnutls_bootprop_verify_flags)
8431 (QCgnutls_bootprop_verify_hostname_error)
8432 (QCgnutls_bootprop_callbacks_verify): Rename from
8433 Qgnutls_bootprop_..., all uses changed.
8435 * xfaces.c (QCignore_defface): Rename from Qignore_defface, all
8438 2011-08-14 Paul Eggert <eggert@cs.ucla.edu>
8440 * xfaces.c (Qframe_set_background_mode): Now static.
8441 * dispextern.h (Qframe_set_background_mode): Remove decl.
8443 * process.c (Fnetwork_interface_info): Declare local only if needed.
8445 2011-08-13 Jan Djärv <jan.h.d@swipnet.se>
8447 * process.c: Include ifaddrs.h and net/if_dl.h if available (Bug#8477).
8448 (Fnetwork_interface_list): Allocate in increments of bytes instead
8449 of sizeof (struct ifreq). Iterate over ifconf.ifc_req by counting
8450 bytes (Bug#8477). Count bytes correctly when ifr_addr is a struct
8452 (struct ifflag_def): notrailers is smart on OSX.
8453 (Fnetwork_interface_info): Handle case when ifr_flags is negative.
8454 Get hardware address with getifaddrs if available.
8456 2011-08-12 Eli Zaretskii <eliz@gnu.org>
8458 * xdisp.c (iterate_out_of_display_property): xassert that
8459 IT->position is set to within IT->object's boundaries. Break from
8460 the loop as soon as EOB is reached; avoids infloops in redisplay
8461 when IT->position is set up wrongly due to some bug.
8462 Set IT->current to match the bidi iterator unconditionally.
8463 (push_display_prop): Allow GET_FROM_STRING as IT->method on
8464 entry. Force push_it to save on the stack the current
8465 buffer/string position, to be restored by pop_it. Fix flags in
8466 the iterator structure wrt the object coming from a display
8467 property, as `line-prefix' and `wrap-prefix' are not ``replacing''
8468 properties. (Bug#9284)
8470 2011-08-09 Andreas Schwab <schwab@linux-m68k.org>
8472 * fontset.c (fontset_get_font_group): Add proper type checks.
8475 2011-08-09 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
8477 * unexmacosx.c (print_load_command_name): Add cases LC_FUNCTION_STARTS
8478 and LC_VERSION_MIN_MACOSX.
8479 (copy_linkedit_data) [LC_FUNCTION_STARTS]: New function.
8480 (dump_it) [LC_FUNCTION_STARTS]: Use it.
8482 2011-08-08 Eli Zaretskii <eliz@gnu.org>
8484 * xdisp.c (forward_to_next_line_start): Allow to use the
8485 no-display-properties-and-no-overlays under bidi display.
8486 Set disp_pos in the bidi iterator to avoid searches for display
8487 properties and overlays.
8489 2011-08-08 Chong Yidong <cyd@stupidchicken.com>
8491 * editfns.c (Fset_time_zone_rule): Document relationship with the
8494 * ftfont.c (ftfont_pattern_entity): Copy the extras argument to
8495 the font entity extracted from the cache (Bug#8109).
8497 2011-08-07 Chong Yidong <cyd@stupidchicken.com>
8499 * composite.c (autocmp_chars): Don't reset point. That is done by
8500 restore_point_unwind (Bug#5984).
8502 2011-08-07 Juri Linkov <juri@jurta.org>
8504 * editfns.c (Fformat_time_string): Doc fix, add tag `usage:'
8505 to show the arg `TIME' instead of `TIMEVAL'.
8507 2011-08-06 Eli Zaretskii <eliz@gnu.org>
8509 * xdisp.c (set_cursor_from_row): Fix cursor positioning when a
8510 display property strides EOL and includes a newline, as in
8511 longlines-mode. (Bug#9254)
8512 (move_it_in_display_line_to): Fix vertical-motion in a buffer with
8513 word-wrap under bidirectional display. (Bug#9224)
8515 * bidi.c (bidi_unshelve_cache): Don't reset the cache if JUST_FREE
8516 is non-zero, even if the data buffer is NULL. Fixes a crash in
8517 vertical-motion with longlines-mode. (Bug#9254)
8519 2011-08-05 Eli Zaretskii <eliz@gnu.org>
8521 * bidi.c <bidi_cache_total_alloc>: Now static.
8522 (bidi_initialize): Initialize bidi_cache_total_alloc.
8524 * xdisp.c (display_line): Release buffer allocated for shelved bidi
8527 * bidi.c (bidi_shelve_cache, bidi_unshelve_cache): Track total
8528 amount allocated this far in `bidi_cache_total_alloc'.
8529 (bidi_unshelve_cache): Accept an additional argument JUST_FREE; if
8530 non-zero, only free the data buffer without restoring the cache
8531 contents. All callers changed.
8533 * dispextern.h (bidi_unshelve_cache): Update prototype.
8535 * xdisp.c (SAVE_IT, pos_visible_p, move_it_in_display_line_to)
8536 (move_it_in_display_line, move_it_to)
8537 (move_it_vertically_backward, move_it_by_lines): Replace the call
8538 to xfree to an equivalent call to bidi_unshelve_cache.
8539 (move_it_in_display_line_to): Fix logic of returning
8540 MOVE_POS_MATCH_OR_ZV in the bidi case. (Bug#9224)
8542 2011-08-05 Eli Zaretskii <eliz@gnu.org>
8544 * xdisp.c (set_cursor_from_row): Prefer the candidate glyph that
8545 came from a string character with a `cursor' property. (Bug#9229)
8547 2011-08-04 Jan Djärv <jan.h.d@swipnet.se>
8549 * Makefile.in (LIB_PTHREAD): New variable.
8550 (LIBES): Add LIB_PTHREAD (Bug#9216).
8552 * alloc.c, emacs.c, gmalloc.c, gtkutil.c, keyboard.c, syssignal.h:
8553 Rename HAVE_GTK_AND_PTHREAD to HAVE_PTHREAD (Bug#9216).
8555 2011-08-04 Andreas Schwab <schwab@linux-m68k.org>
8557 * regex.c (re_iswctype): Remove some redundant boolean conversions.
8559 2011-08-04 Jan Djärv <jan.h.d@swipnet.se>
8561 * xterm.c (x_find_topmost_parent): New function.
8562 (x_set_frame_alpha): Find topmost parent window with
8563 x_find_topmost_parent and set the property there also (bug#9181).
8564 (handle_one_xevent): Call x_set_frame_alpha on ReparentNotify.
8566 2011-08-04 Paul Eggert <eggert@cs.ucla.edu>
8568 * callproc.c (Fcall_process): Avoid vfork clobbering
8569 the local vars buffer, coding_systems, current_dir.
8571 2011-08-03 Stefan Monnier <monnier@iro.umontreal.ca>
8573 * keymap.c (Fmake_composed_keymap): Move to subr.el.
8575 2011-08-03 Paul Eggert <eggert@cs.ucla.edu>
8577 * fontset.c (dump_fontset) [FONTSET_DEBUG]: Declare EXTERNALLY_VISIBLE
8578 so that it is not optimized away.
8580 * xdisp.c (compute_display_string_pos): Remove unused local.
8582 2011-08-02 Eli Zaretskii <eliz@gnu.org>
8584 Fix slow cursor motion and scrolling in large buffers with
8585 selective display, like Org Mode buffers. (Bug#9218)
8587 * dispextern.h (struct bidi_it): New member disp_prop_p.
8589 * xdisp.c: Remove one-slot cache of display string positions.
8590 (compute_display_string_pos): Accept an additional argument
8591 DISP_PROP_P; callers changed. Scan at most 5K characters forward
8592 for a display string or property. If found, set DISP_PROP_P
8595 * bidi.c (bidi_fetch_char): Accept an additional argument
8596 DISP_PROP_P, and pass it to compute_display_string_pos.
8597 Only handle text covered by a display string if DISP_PROP_P is returned
8598 non-zero. All callers of bidi_fetch_char changed.
8600 2011-08-02 Stefan Monnier <monnier@iro.umontreal.ca>
8602 * keymap.c (Fdefine_key): Fix Lisp_Object/int mixup; apply some CSE.
8604 2010-12-03 Don March <don@ohspite.net>
8606 * keymap.c (Fdefine_key): Fix non-prefix key error message when
8607 last character M-[char] is translated to ESC [char] (bug#7541).
8609 2011-08-02 Kenichi Handa <handa@m17n.org>
8611 * lisp.h (uniprop_table): Extern it.
8613 * chartab.c (uniprop_table): Make it non-static.
8615 2011-08-01 Eli Zaretskii <eliz@gnu.org>
8617 * xdisp.c (forward_to_next_line_start): Accept additional argument
8618 BIDI_IT_PREV, and store into it the state of the bidi iterator had
8620 (reseat_at_next_visible_line_start): Use the bidi iterator state
8621 returned by forward_to_next_line_start to restore the state of
8622 it->bidi_it after backing up to previous newline. (Bug#9212)
8624 2011-07-30 Andreas Schwab <schwab@linux-m68k.org>
8626 * regex.c (re_comp): Protoize.
8627 (re_exec): Fix return type.
8628 (regexec): Fix type of `ret'. (Bug#9203)
8630 2011-07-28 Paul Eggert <eggert@cs.ucla.edu>
8632 * image.c (check_image_size): Use 1024x1024 if unknown frame (Bug#9189).
8633 This is needed if max-image-size is a floating-point number.
8635 2011-07-28 Andreas Schwab <schwab@linux-m68k.org>
8637 * print.c (print_object): Print empty symbol as ##.
8639 * lread.c (read1): Read ## as empty symbol.
8641 2011-07-28 Alp Aker <alp.tekin.aker@gmail.com>
8643 * nsfns.m (x_set_foreground_color): Set f->foreground_pixel when
8644 setting frame foreground color (Bug#9175).
8645 (x_set_background_color): Likewise.
8647 * nsmenu.m (-setText): Size tooltip dimensions precisely to
8648 contents (Bug#9176).
8649 (EmacsTooltip -init): Remove bezels and add shadows to
8652 * nsterm.m (ns_dumpglyphs_stretch): Avoid overwriting left fringe
8653 or scroll bar (Bug#8470).
8655 * nsfont.m (nsfont_open): Remove assignment to voffset and
8656 unnecessary vars hshink, expand, hd, full_height, min_height.
8657 (nsfont_draw): Use s->ybase as baseline for glyph drawing (Bug#8913).
8659 * nsterm.h (nsfont_info): Remove voffset field.
8661 2011-07-28 Alp Aker <alp.tekin.aker@gmail.com>
8663 Implement strike-through and overline on NextStep (Bug#8863).
8665 * nsfont.m (nsfont_open): Use underline position provided by font,
8666 instead of hard-coded value of 2.
8667 (nsfont_draw): Call ns_draw_text_decoration instead.
8669 * nsterm.h: Add declaration for ns_draw_text_decoration.
8671 * nsterm.m (ns_draw_text_decoration): New function for drawing
8672 underline, overline, and strike-through.
8673 (ns_dumpglyphs_image, ns_dumpglyphs_stretch): Add call to
8674 ns_draw_text_decoration. Change treatment of cursor drawing to
8675 accommodate underlining, etc.
8677 2011-07-28 Eli Zaretskii <eliz@gnu.org>
8679 * buffer.c (init_buffer_once): Set bidi-display-reordering to t by
8682 2011-07-28 Paul Eggert <eggert@cs.ucla.edu>
8684 * alloc.c (memory_full) [!SYNC_INPUT]: Fix signal-related race.
8685 Without this fix, if a signal arrives just after memory fills up,
8686 'malloc' might be invoked reentrantly.
8688 * image.c (x_check_image_size) [!HAVE_X_WINDOWS]: Return 1.
8689 In other words, assume that every image size is allowed, on non-X
8690 hosts. This assumption is probably wrong, but it lets Emacs compile.
8692 2011-07-28 Andreas Schwab <schwab@linux-m68k.org>
8694 * regex.c (re_iswctype): Convert return values to boolean.
8696 2011-07-28 Eli Zaretskii <eliz@fencepost.gnu.org>
8698 * xdisp.c (compute_display_string_pos): Don't use cached display
8699 string position if the buffer had its restriction changed.
8702 2011-07-28 Paul Eggert <eggert@cs.ucla.edu>
8704 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
8706 2011-07-28 Paul Eggert <eggert@cs.ucla.edu>
8708 Integer signedness and overflow and related fixes. (Bug#9079)
8710 * bidi.c: Integer size and overflow fixes.
8711 (bidi_cache_size, bidi_cache_idx, bidi_cache_last_idx)
8712 (bidi_cache_start, bidi_cache_fetch_state, bidi_cache_search)
8713 (bidi_cache_find_level_change, bidi_cache_ensure_space)
8714 (bidi_cache_iterator_state, bidi_cache_find, bidi_cache_start_stack)
8715 (bidi_find_other_level_edge):
8716 Use ptrdiff_t instead of EMACS_INT where either will do.
8717 This works better on 32-bit hosts configured --with-wide-int.
8718 (bidi_cache_ensure_space): Check for size-calculation overflow.
8719 Use % rather than repeated addition, for better worst-case speed.
8720 Don't set bidi_cache_size until after xrealloc returns, because it
8722 (bidi_dump_cached_states): Use ptrdiff_t, not int, to avoid overflow.
8723 (bidi_cache_ensure_space): Also check that the bidi cache size
8724 does not exceed that of the largest Lisp string or buffer. See Eli
8725 Zaretskii in <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9079#29>.
8727 * alloc.c (__malloc_size_t): Remove.
8728 All uses replaced by size_t. See Andreas Schwab's note
8729 <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9079#8>.
8731 * image.c: Improve checking for integer overflow.
8732 (check_image_size): Assume that f is nonnull, since
8733 it is always nonnull in practice. This is one less thing to
8734 worry about when checking for integer overflow later.
8735 (x_check_image_size): New function, which checks for integer
8736 overflow issues inside X.
8737 (x_create_x_image_and_pixmap, xbm_read_bitmap_data): Use it.
8738 This removes the need for a memory_full check.
8739 (xbm_image_p): Rewrite to avoid integer multiplication overflow.
8740 (Create_Pixmap_From_Bitmap_Data, xbm_load): Use x_check_image_size.
8741 (xbm_read_bitmap_data): Change locals back to 'int', since
8742 their values must fit in 'int'.
8743 (xpm_load_image, png_load, tiff_load):
8744 Invoke x_create_x_image_and_pixmap earlier,
8745 to avoid much needless work if the image is too large.
8746 (tiff_load): Treat overly large images as if
8747 x_create_x_image_and_pixmap failed, not as malloc failures.
8748 (gs_load): Use x_check_image_size.
8750 * gtkutil.c: Omit integer casts.
8751 (xg_get_pixbuf_from_pixmap): Remove unnecessary cast.
8752 (xg_set_toolkit_scroll_bar_thumb): Rewrite to avoid need for cast.
8754 * image.c (png_load): Don't assume height * row_bytes fits in 'int'.
8756 * xfaces.c (Fbitmap_spec_p): Fix integer overflow bug.
8757 Without this fix, (bitmap-spec-p '(34359738368 1 "x"))
8758 would wrongly return t on a 64-bit host.
8760 * dispnew.c (init_display): Use *_RANGE_OVERFLOW macros.
8761 The plain *_OVERFLOW macros run afoul of GCC bug 49705
8762 <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=49705>
8763 and therefore cause GCC to emit a bogus diagnostic in some cases.
8765 * image.c: Integer signedness and overflow and related fixes.
8766 This is not an exhaustive set of fixes, but it's time to
8767 record what I've got.
8768 (lookup_pixel_color, check_image_size): Remove redundant decls.
8769 (check_image_size): Don't assume that arbitrary EMACS_INT values
8770 fit in 'int', or that arbitrary 'double' values fit in 'int'.
8771 (x_alloc_image_color, x_create_x_image_and_pixmap, png_load)
8772 (tiff_load, imagemagick_load_image):
8773 Check for overflow in size calculations.
8774 (x_create_x_image_and_pixmap): Remove unnecessary test for
8775 xmalloc returning NULL; that can't happen.
8776 (xbm_read_bitmap_data): Don't assume sizes fit into 'int'.
8777 (xpm_color_bucket): Use better integer hashing function.
8778 (xpm_cache_color): Don't possibly over-allocate memory.
8779 (struct png_memory_storage, tiff_memory_source, tiff_seek_in_memory)
8780 (gif_memory_source):
8781 Use ptrdiff_t, not int or size_t, to record sizes.
8782 (png_load): Don't assume values greater than 2**31 fit in 'int'.
8783 (our_stdio_fill_input_buffer): Prefer ptrdiff_t to size_t when
8784 either works, as we prefer signed integers.
8785 (tiff_read_from_memory, tiff_write_from_memory):
8786 Return tsize_t, not size_t, since that's what the TIFF API wants.
8787 (tiff_read_from_memory): Don't fail simply because the read would
8788 go past EOF; instead, return a short read.
8789 (tiff_load): Omit no-longer-needed casts.
8790 (Fimagemagick_types): Don't assume size fits into 'int'.
8792 Improve hashing quality when configured --with-wide-int.
8793 * fns.c (hash_string): New function, taken from sxhash_string.
8794 Do not discard information about ASCII character case; this
8795 discarding is no longer needed.
8796 (sxhash-string): Use it. Change sig to match it. Caller changed.
8797 * lisp.h: Declare it.
8798 * lread.c (hash_string): Remove, since we now use fns.c's version.
8799 The fns.c version returns a wider integer if --with-wide-int is
8800 specified, so this should help the quality of the hashing a bit.
8802 * emacs.c: Integer overflow minor fix.
8803 (heap_bss_diff): Now uprintmax_t, not unsigned long. All used changed.
8804 Define only if GNU_LINUX.
8805 (main, Fdump_emacs): Set and use heap_bss_diff only if GNU_LINUX.
8807 * dispnew.c: Integer signedness and overflow fixes.
8808 Remove unnecessary forward decls, that were a maintenance hassle.
8809 (history_tick): Now uprintmax_t, so it's more likely to avoid overflow.
8811 (adjust_glyph_matrix, realloc_glyph_pool, adjust_frame_message_buffer)
8812 (scrolling_window): Use ptrdiff_t, not int, for byte count.
8813 (prepare_desired_row, line_draw_cost):
8814 Use int, not unsigned, where either works.
8815 (save_current_matrix, restore_current_matrix):
8816 Use ptrdiff_t, not size_t, where either works.
8817 (init_display): Check for overflow more accurately, and without
8818 relying on undefined behavior.
8820 * editfns.c (pWIDE, pWIDElen, signed_wide, unsigned_wide):
8821 Remove, replacing with the new symbols in lisp.h. All uses changed.
8822 * fileio.c (make_temp_name):
8823 * filelock.c (lock_file_1, lock_file):
8824 * xdisp.c (message_dolog):
8825 Don't assume PRIdMAX etc. works; this isn't portable to pre-C99 hosts.
8826 Use pMd etc. instead.
8827 * lisp.h (printmax_t, uprintmax_t, pMd, pMu): New types and macros,
8828 replacing the pWIDE etc. symbols removed from editfns.c.
8830 * keyboard.h (num_input_events): Now uintmax_t.
8831 This is (very slightly) less likely to mess up due to wraparound.
8834 * buffer.c: Integer signedness fixes.
8835 (alloc_buffer_text, enlarge_buffer_text):
8836 Use ptrdiff_t rather than size_t when either will do, as we prefer
8839 * alloc.c: Integer signedness and overflow fixes.
8840 Do not impose an arbitrary 32-bit limit on malloc sizes when debugging.
8841 (__malloc_size_t): Default to size_t, not to int.
8842 (pure_size, pure_bytes_used_before_overflow, stack_copy_size)
8843 (Fgarbage_collect, mark_object_loop_halt, mark_object):
8844 Prefer ptrdiff_t to size_t when either would do, as we prefer
8846 (XMALLOC_OVERRUN_CHECK_OVERHEAD): New macro.
8847 (xmalloc_overrun_check_header, xmalloc_overrun_check_trailer):
8848 Now const. Initialize with values that are in range even if char
8850 (XMALLOC_PUT_SIZE, XMALLOC_GET_SIZE): Remove, replacing with ...
8851 (xmalloc_put_size, xmalloc_get_size): New functions. All uses changed.
8852 These functions do the right thing with sizes > 2**32.
8853 (check_depth): Now ptrdiff_t, not int.
8854 (overrun_check_malloc, overrun_check_realloc, overrun_check_free):
8855 Adjust to new way of storing sizes. Check for size overflow bugs
8857 (STRING_BYTES_MAX): Adjust to new overheads. The old code was
8858 slightly wrong anyway, as it missed one instance of
8859 XMALLOC_OVERRUN_CHECK_OVERHEAD.
8860 (refill_memory_reserve): Omit needless cast to size_t.
8861 (mark_object_loop_halt): Mark as externally visible.
8863 * xselect.c: Integer signedness and overflow fixes.
8864 (Fx_register_dnd_atom, x_handle_dnd_message):
8865 Use ptrdiff_t, not size_t, since we prefer signed.
8866 (Fx_register_dnd_atom): Check for ptrdiff_t (and size_t) overflow.
8867 * xterm.h (struct x_display_info): Use ptrdiff_t, not size_t, for
8868 x_dnd_atoms_size and x_dnd_atoms_length.
8870 * doprnt.c: Prefer signed to unsigned when either works.
8872 * doprnt.c (doprnt):
8874 * xdisp.c (vmessage):
8875 Use ptrdiff_t, not size_t, when using or implementing doprnt,
8876 since the sizes cannot exceed ptrdiff_t bounds anyway, and we
8877 prefer signed arithmetic to avoid comparison confusion.
8878 * doprnt.c (doprnt): Avoid a "+ 1" that can't overflow,
8879 but is a bit tricky.
8881 Assume freestanding C89 headers, string.h, stdlib.h.
8882 * data.c, doprnt.c, floatfns.c, print.c:
8883 Include float.h unconditionally.
8884 * gmalloc.c: Assume C89-at-least behavior for preprocessor,
8885 limits.h, stddef.h, string.h. Use memset instead of 'flood'.
8886 * regex.c: Likewise for stddef.h, string.h.
8887 (ISASCII): Remove; can assume it returns 1 now. All uses removed.
8888 * s/aix4-2.h (HAVE_STRING_H): Remove obsolete undef.
8889 * s/ms-w32.h (HAVE_LIMITS_H, HAVE_STRING_H, HAVE_STDLIB_H)
8890 (STDC_HEADERS): Remove obsolete defines.
8891 * sysdep.c: Include limits.h unconditionally.
8893 Assume support for memcmp, memcpy, memmove, memset.
8894 * lisp.h, sysdep.c (memcmp, memcpy, memmove, memset):
8895 * regex.c (memcmp, memcpy):
8896 Remove; we assume C89 now.
8898 * gmalloc.c (memcpy, memset, memmove): Remove; we assume C89 now.
8899 (__malloc_safe_bcopy): Remove; no longer needed.
8901 * lisp.h (struct vectorlike_header, struct Lisp_Subr): Signed sizes.
8902 Use EMACS_INT, not EMACS_UINT, for sizes. The code works equally
8903 well either way, and we prefer signed to unsigned.
8905 2011-07-27 Lars Magne Ingebrigtsen <larsi@gnus.org>
8907 * gnutls.c (emacs_gnutls_read): Don't message anything if the peer
8908 closes the connection while we're reading (bug#9182).
8910 2011-07-25 Jan Djärv <jan.h.d@swipnet.se>
8912 * nsmenu.m (ns_popup_dialog): Add an "ok" button if no buttons
8913 are specified (Bug#9168).
8915 2011-07-25 Paul Eggert <eggert@cs.ucla.edu>
8917 * bidi.c (bidi_dump_cached_states): Fix printf format mismatch.
8918 Found by GCC static checking and --with-wide-int on a 32-bit host.
8920 2011-07-25 Eli Zaretskii <eliz@gnu.org>
8922 * xdisp.c (compute_display_string_pos): Fix logic of caching
8923 previous display string position. Initialize cached_prev_pos to
8924 -1. Fixes slow-down at the beginning of a buffer.
8926 2011-07-24 Eli Zaretskii <eliz@gnu.org>
8928 * xfaces.c (check_lface_attrs) [HAVE_WINDOW_SYSTEM]: Allow `nil'
8929 for attrs[LFACE_FONTSET_INDEX].
8931 2011-07-23 Paul Eggert <eggert@cs.ucla.edu>
8933 * xml.c (parse_region): Remove unused local
8934 that was recently introduced.
8936 2011-07-23 Eli Zaretskii <eliz@gnu.org>
8938 * xfns.c (unwind_create_frame) [GLYPH_DEBUG]: Adapt to changes in
8939 2008-02-22T17:42:09Z!monnier@iro.umontreal.ca.
8941 * xdisp.c (move_it_in_display_line_to): Record the best matching
8942 position for TO_CHARPOS while scanning the line, and restore it on
8943 exit if none of the characters scanned was an exact match.
8944 Fixes vertical-motion and pos-visible-in-window-p under bidi redisplay
8945 when exact match is impossible due to invisible text, and the
8946 lines are truncated.
8948 2011-07-23 Jan Djärv <jan.h.d@swipnet.se>
8950 * nsterm.m (initFrameFromEmacs): Set NSTitledWindowMask in styleMask
8953 2011-07-22 Eli Zaretskii <eliz@gnu.org>
8955 Fix a significant slow-down of cursor motion with C-n, C-p,
8956 C-f/C-b, and C-v/M-v that couldn't keep up with keyboard
8957 auto-repeat under bidi redisplay in fontified buffers.
8958 * xdisp.c (compute_stop_pos_backwards): New function.
8959 (next_element_from_buffer): Call compute_stop_pos_backwards to
8960 find a suitable prev_stop when we find ourselves before
8962 (reseat): Don't look for prev_stop, as that could mean a very long
8964 <cached_disp_pos, cached_disp_buffer, cached_disp_modiff>
8965 <cached_disp_overlay_modiff>: Cache for last found display string
8967 (compute_display_string_pos): Return the cached position if asked
8968 about the same buffer in the same area of character positions, and
8969 the buffer wasn't changed since the time the display string
8970 position was cached.
8972 2011-07-22 Eli Zaretskii <eliz@gnu.org>
8974 * xdisp.c (rows_from_pos_range): Don't ignore glyphs whose object
8975 is an integer, which is important for empty lines. (Bug#9149)
8977 2011-07-22 Chong Yidong <cyd@stupidchicken.com>
8979 * frame.c (Fmodify_frame_parameters): In tty case, update the
8980 default face if necessary (Bug#4238).
8982 2011-07-21 Chong Yidong <cyd@stupidchicken.com>
8984 * editfns.c (Fstring_to_char): No need to explain what a character
8985 is in the docstring (Bug#6576).
8987 2011-07-20 Lars Magne Ingebrigtsen <larsi@gnus.org>
8989 * xml.c (parse_region): Make sure we always return a tree.
8991 2011-07-20 HAMANO Kiyoto <khiker.mail@gmail.com>
8993 * xml.c (parse_region): If a document contains only comments,
8996 2011-07-20 Lars Magne Ingebrigtsen <larsi@gnus.org>
8998 * xml.c (make_dom): Return comments, too.
9000 2011-07-19 Paul Eggert <eggert@cs.ucla.edu>
9003 See http://lists.gnu.org/archive/html/emacs-devel/2011-07/msg00688.html
9004 and the surrounding thread.
9005 * minibuf.c (read_minibuf_noninteractive): Rewrite to use getchar
9006 rather than fgets, and retry after EINTR. Otherwise, 'emacs
9007 --batch -f byte-compile-file' fails on OpenBSD if an inactivity
9009 * s/openbsd.h (BROKEN_SIGIO): Define.
9010 * unexelf.c (unexec) [__OpenBSD__]:
9011 Don't update the .mdebug section of the Alpha COFF symbol table.
9013 2011-07-19 Lars Magne Ingebrigtsen <larsi@gnus.org>
9015 * lread.c (syms_of_lread): Clarify when `lexical-binding' is used
9018 2011-07-18 Paul Eggert <eggert@cs.ucla.edu>
9020 * fileio.c (Fcopy_file) [!MSDOS]: Tighten created file's mask.
9021 This fixes some race conditions on the permissions of any newly
9024 * alloc.c (valid_pointer_p): Use pipe, not open.
9025 This fixes some permissions issues when debugging.
9027 * fileio.c (Fcopy_file): Adjust mode if fchown fails. (Bug#9002)
9028 If fchown fails to set both uid and gid, try to set just gid,
9029 as that is sometimes allowed. Adjust the file's mode to eliminate
9030 setuid or setgid bits that are inappropriate if fchown fails.
9032 2011-07-18 Stefan Monnier <monnier@iro.umontreal.ca>
9034 * xdisp.c (next_element_from_string, next_element_from_buffer): Use EQ
9035 to compare Lisp_Objects.
9036 * gnutls.c (syms_of_gnutls): Rename Vgnutls_log_level to
9037 global_gnutls_log_level, don't mistake it for a Lisp_Object.
9038 (init_gnutls_functions, emacs_gnutls_handle_error): Fix up uses.
9040 2011-07-17 Andreas Schwab <schwab@linux-m68k.org>
9042 * lread.c (read_integer): Unread even EOF character.
9043 (read1): Likewise. Properly record start position of symbol.
9045 * lread.c (read1): Read `#:' as empty uninterned symbol if no
9046 symbol character follows.
9048 2011-07-17 Paul Eggert <eggert@cs.ucla.edu>
9050 * fileio.c (Fcopy_file): Pacify gcc re fchown. (Bug#9002)
9051 This works around a problem with the previous change to Fcopy_file.
9052 Recent glibc declares fchown with __attribute__((warn_unused_result)),
9053 and without this change, GCC might complain about discarding
9054 fchown's return value.
9056 2011-07-16 Juanma Barranquero <lekktu@gmail.com>
9058 * makefile.w32-in (GLOBAL_SOURCES): Add gnutls.c (followup to bug#9059).
9060 2011-07-16 Paul Eggert <eggert@cs.ucla.edu>
9062 * fileio.c (Fcopy_file): Don't diagnose fchown failures. (Bug#9002)
9064 2011-07-16 Lars Magne Ingebrigtsen <larsi@gnus.org>
9066 * gnutls.c (syms_of_gnutls): Define `gnutls-log-level' here, since
9067 it's used from the C level.
9069 * process.c: Use the same condition for POLL_FOR_INPUT in both
9070 keyboard.c and process.c (bug#1858).
9072 2011-07-09 Lawrence Mitchell <wence@gmx.li>
9074 * gnutls.c (Qgnutls_bootprop_min_prime_bits): New variable.
9075 (Fgnutls_boot): Use it.
9077 2011-07-15 Andreas Schwab <schwab@linux-m68k.org>
9079 * doc.c (Fsubstitute_command_keys): Revert last change.
9081 2011-07-15 Lars Magne Ingebrigtsen <larsi@gnus.org>
9083 * doc.c (Fsubstitute_command_keys): Clarify that \= really only
9084 quotes the next character, and doesn't affect other longer
9085 sequences (bug#8935).
9087 * lread.c (syms_of_lread): Clarify that is isn't only
9088 `eval-buffer' and `eval-defun' that's affected by
9089 `lexical-binding' (bug#8460).
9091 2011-07-15 Eli Zaretskii <eliz@gnu.org>
9093 * xdisp.c (move_it_in_display_line_to): Fix vertical motion with
9094 bidi redisplay when a line includes both an image and is truncated.
9096 2011-07-14 Paul Eggert <eggert@cs.ucla.edu>
9098 Fix minor problems found by static checking.
9099 * bidi.c (bidi_cache_size): Now EMACS_INT, not size_t.
9100 (elsz): Now a signed constant, not a size_t var. We prefer signed
9101 types to unsigned, to avoid integer comparison confusion. Without
9102 this change, GCC 4.6.1 with -Wunsafe-loop-optimizations complains
9103 "cannot optimize loop, the loop counter may overflow", a symptom
9105 * indent.c (Fvertical_motion): Mark locals as initialized.
9106 * xdisp.c (reseat_to_string): Fix pointer signedness issue.
9108 2011-07-14 Lars Magne Ingebrigtsen <larsi@gnus.org>
9110 * search.c (Fre_search_backward): Mention `case-fold-search' in
9111 all the re_search_* functions (bug#8138).
9113 * keyboard.c (Fopen_dribble_file): Document when the file is
9116 2011-07-14 Eli Zaretskii <eliz@gnu.org>
9118 * bidi.c (bidi_dump_cached_states): Fix format of displaying
9121 Support bidi reordering of display and overlay strings.
9122 * xdisp.c (compute_display_string_pos)
9123 (compute_display_string_end): Accept additional argument STRING.
9124 (init_iterator, reseat_1): Initialize bidi_it->string.s to NULL.
9125 (reseat_to_string): Initialize bidi_it->string.s and
9126 bidi_it->string.schars.
9127 (Fcurrent_bidi_paragraph_direction): Initialize itb.string.s to
9128 NULL (avoids a crash in bidi_paragraph_init).
9129 Initialize itb.string.lstring.
9130 (init_iterator): Call bidi_init_it only of a valid
9131 buffer position was specified. Initialize paragraph_embedding to
9133 (reseat_to_string): Initialize the bidi iterator.
9134 (display_string): If we need to ignore text properties of
9135 LISP_STRING, set IT->stop_charpos to IT->end_charpos. (The
9136 original value of -1 will not work with bidi.)
9137 (compute_display_string_pos): First arg is now struct
9138 `text_pos *'; all callers changed. Support display properties on
9140 (compute_display_string_end): Support display properties on Lisp
9142 (init_iterator, reseat_1, reseat_to_string): Initialize the
9143 string.bufpos member to 0 (zero, for compatibility with IT_CHARPOS
9144 when iterating on a string not from display properties).
9145 (compute_display_string_pos, compute_display_string_end):
9146 Fix calculation of the object to scan. Fixes an error when using
9148 (next_element_from_buffer): Don't abort when IT_CHARPOS is before
9149 base_level_stop; instead, set base_level_stop to BEGV.
9150 Fixes crashes in vertical-motion.
9151 (next_element_from_buffer): Improve commentary for when
9152 the iterator is before prev_stop.
9153 (init_iterator): Initialize bidi_p from the default value of
9154 bidi-display-reordering, not from buffer-local value. Use the
9155 buffer-local value only if initializing for buffer iteration.
9156 (handle_invisible_prop): Support invisible properties on strings
9157 that are being bidi-reordered.
9158 (set_iterator_to_next): Support bidi reordering of C strings and
9160 (next_element_from_string): Support bidi reordering of Lisp
9162 (handle_stop_backwards): Support Lisp strings as well.
9163 (display_string): Support display of R2L glyph rows.
9164 Use IT_STRING_CHARPOS when displaying from a Lisp string.
9165 (init_iterator): Don't initialize it->bidi_p for strings
9167 (reseat_to_string): Initialize it->bidi_p for strings here.
9168 (next_element_from_string, next_element_from_c_string)
9169 (next_element_from_buffer): Add xassert's for correspondence
9170 between IT's object being iterated and it->bidi_it.string
9172 (face_before_or_after_it_pos): Support bidi iteration.
9173 (next_element_from_c_string): Handle the case of the first string
9174 character that is not the first one in the visual order.
9175 (get_visually_first_element): New function, refactored from common
9176 parts of next_element_from_buffer, next_element_from_string, and
9177 next_element_from_c_string.
9178 (tool_bar_lines_needed, redisplay_tool_bar)
9179 (display_menu_bar): Force left-to-right direction. Add a FIXME
9180 comment for making that be controlled by a user option.
9181 (push_it, pop_it): Save and restore the state of the
9182 bidi iterator. Save and restore the bidi_p flag.
9183 (pop_it): Iterate out of display property for string iteration as
9185 (iterate_out_of_display_property): Support iteration over strings.
9186 (handle_single_display_spec): Set up it->bidi_it for iteration
9187 over a display string, and call bidi_init_it.
9188 (handle_single_display_spec, next_overlay_string)
9189 (get_overlay_strings_1, push_display_prop): Set up the bidi
9190 iterator for displaying display or overlay strings.
9191 (forward_to_next_line_start): Don't use the shortcut if
9193 (back_to_previous_visible_line_start): If handle_display_prop
9194 pushed the iterator stack, restore the internal state of the bidi
9195 iterator by calling bidi_pop_it same number of times.
9196 (reseat_at_next_visible_line_start): If ON_NEWLINE_P is non-zero,
9197 and we are bidi-iterating, don't decrement the iterator position;
9198 instead, set the first_elt flag in the bidi iterator, to produce
9200 (reseat_1): Remove redundant setting of string_from_display_prop_p.
9201 (push_display_prop): xassert that we are iterating a buffer.
9202 (push_it, pop_it): Save and restore paragraph_embedding member.
9203 (handle_single_display_spec, next_overlay_string)
9204 (get_overlay_strings_1, reseat_1, reseat_to_string)
9205 (push_display_prop): Set up the `unibyte' member of bidi_it.string
9206 correctly. Don't assume unibyte strings are not bidi-reordered.
9207 (compute_display_string_pos)
9208 (compute_display_string_end): Fix handling the case of C string.
9209 (push_it, pop_it): Save and restore from_disp_prop_p.
9210 (handle_single_display_spec, push_display_prop): Set the
9211 from_disp_prop_p flag.
9212 (get_overlay_strings_1): Reset the from_disp_prop_p flag.
9213 (pop_it): Call iterate_out_of_display_property only if we are
9214 popping after iteration over a string that came from a display
9215 property. Fix a typo in popping stretch info. Add an assertion
9216 for verifying that the iterator position is in sync with the bidi
9218 (handle_single_display_spec, get_overlay_strings_1)
9219 (push_display_prop): Fix initialization of paragraph direction for
9220 string when that of the parent object is not yet determined.
9221 (reseat_1): Call bidi_init_it to resync the bidi
9222 iterator with IT's position. (Bug#7616)
9223 (find_row_edges): If ROW->start.pos gives position
9224 smaller than min_pos, use it as ROW->minpos. (Bug#7616)
9225 (handle_stop, back_to_previous_visible_line_start, reseat_1):
9226 Reset the from_disp_prop_p flag.
9227 (SAVE_IT, RESTORE_IT): New macros.
9228 (pos_visible_p, face_before_or_after_it_pos)
9229 (back_to_previous_visible_line_start)
9230 (move_it_in_display_line_to, move_it_in_display_line)
9231 (move_it_to, move_it_vertically_backward, move_it_by_lines)
9232 (try_scrolling, redisplay_window, display_line): Use them when
9233 saving a temporary copy of the iterator and restoring it back.
9234 (back_to_previous_visible_line_start, reseat_1)
9235 (init_iterator): Empty the bidi cache "stack".
9236 (move_it_in_display_line_to): If iterator ended up at
9237 EOL, but we never saw any buffer positions smaller than
9238 to_charpos, return MOVE_POS_MATCH_OR_ZV. Fixes vertical cursor
9239 motion in bidi-reordered lines.
9240 (move_it_in_display_line_to): Record prev_method and prev_pos
9241 immediately before the call to set_iterator_to_next. Fixes cursor
9242 motion in bidi-reordered lines with stretch glyphs and strings
9243 displayed in margins. (Bug#8133) (Bug#8867)
9244 Return MOVE_POS_MATCH_OR_ZV only if iterator position is past
9246 (pos_visible_p): Support positions in bidi-reordered lines.
9247 Save and restore bidi cache.
9249 * bidi.c (bidi_level_of_next_char): clen should be EMACS_NT, not int.
9250 (bidi_paragraph_info): Delete unused struct.
9251 (bidi_cache_idx, bidi_cache_last_idx): Declare EMACS_INT.
9252 (bidi_cache_start): New variable.
9253 (bidi_cache_reset): Reset bidi_cache_idx to bidi_cache_start, not
9255 (bidi_cache_fetch_state, bidi_cache_search)
9256 (bidi_cache_find_level_change, bidi_cache_iterator_state)
9257 (bidi_cache_find, bidi_peek_at_next_level)
9258 (bidi_level_of_next_char, bidi_find_other_level_edge)
9259 (bidi_move_to_visually_next): Compare cache index with
9260 bidi_cache_start rather than with zero.
9261 (bidi_fetch_char): Accept new argument STRING; all callers
9262 changed. Support iteration over a string. Support strings with
9263 display properties. Support unibyte strings. Fix the type of
9264 `len' according to what STRING_CHAR_AND_LENGTH expects.
9265 (bidi_paragraph_init, bidi_resolve_explicit_1)
9266 (bidi_resolve_explicit, bidi_resolve_weak)
9267 (bidi_level_of_next_char, bidi_move_to_visually_next):
9268 Support iteration over a string.
9269 (bidi_set_sor_type, bidi_resolve_explicit_1)
9270 (bidi_resolve_explicit, bidi_type_of_next_char): ignore_bn_limit
9271 can now be zero (for strings); special values 0 and -1 were
9272 changed to -1 and -2, respectively.
9273 (bidi_char_at_pos): New function.
9274 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak):
9275 Call it instead of FETCH_MULTIBYTE_CHAR.
9276 (bidi_move_to_visually_next): Abort if charpos or bytepos were not
9277 initialized to valid values.
9278 (bidi_init_it): Don't initialize charpos and bytepos with invalid
9280 (bidi_level_of_next_char): Allow the sentinel "position" to pass
9281 the test for valid cached positions. Fix the logic for looking up
9282 the sentinel state in the cache. GCPRO the Lisp string we are
9284 (bidi_push_it, bidi_pop_it): New functions.
9285 (bidi_initialize): Initialize the bidi cache start stack pointer.
9286 (bidi_cache_ensure_space): New function, refactored from part of
9287 bidi_cache_iterator_state. Don't assume the required size is just
9288 one BIDI_CACHE_CHUNK away.
9289 (bidi_cache_start_stack, bidi_push_it): Use IT_STACK_SIZE.
9290 (bidi_count_bytes, bidi_char_at_pos): New functions.
9291 (bidi_cache_search): Don't assume bidi_cache_last_idx is
9292 always valid if bidi_cache_idx is valid.
9293 (bidi_cache_find_level_change): xassert that bidi_cache_last_idx
9294 is valid if it's going to be used.
9295 (bidi_shelve_cache, bidi_unshelve_cache): New functions.
9296 (bidi_cache_fetch_state, bidi_cache_search)
9297 (bidi_cache_find_level_change, bidi_cache_ensure_space)
9298 (bidi_cache_iterator_state, bidi_cache_find)
9299 (bidi_find_other_level_edge, bidi_cache_start_stack):
9300 All variables related to cache indices are now EMACS_INT.
9302 * dispextern.h (struct bidi_string_data): New structure.
9303 (struct bidi_it): New member `string'. Make flag members be 1-bit
9304 fields, and put them last in the struct.
9305 (compute_display_string_pos, compute_display_string_end):
9307 (bidi_push_it, bidi_pop_it): Add prototypes.
9308 (struct iterator_stack_entry): New members bidi_p,
9309 paragraph_embedding, and from_disp_prop_p.
9310 (struct it): Member bidi_p is now a bit field 1 bit wide.
9311 (bidi_shelve_cache, bidi_unshelve_cache):
9314 * .gdbinit (xvectype, xvector, xcompiled, xchartable, xboolvector)
9315 (xpr, xfont, xbacktrace): Use "header.size" when accessing vectors
9316 and vector-like objects.
9318 * dispnew.c (buffer_posn_from_coords): Save and restore the bidi
9319 cache around display iteration.
9321 * window.c (Fwindow_end, window_scroll_pixel_based)
9322 (displayed_window_lines, Frecenter): Save and restore the bidi
9323 cache around display iteration.
9325 2011-07-14 Lars Magne Ingebrigtsen <larsi@gnus.org>
9327 * editfns.c (Fdelete_region): Clarify the use of the named
9328 parameters (bug#6788).
9330 2011-07-14 Martin Rudalics <rudalics@gmx.at>
9332 * indent.c (Fvertical_motion): Set and restore w->pointm when
9333 saving and restoring the window's buffer (Bug#9006).
9335 2011-07-13 Lars Magne Ingebrigtsen <larsi@gnus.org>
9337 * editfns.c (Fstring_to_char): Clarify just what is returned
9338 (bug#6576). Text by Eli Zaretskii.
9340 2011-07-13 Juanma Barranquero <lekktu@gmail.com>
9342 * gnutls.c (init_gnutls_functions): Honor gnutls_log_level (bug#9059).
9344 2011-07-13 Eli Zaretskii <eliz@gnu.org>
9346 * buffer.c (mmap_find): Fix a typo.
9348 2011-07-13 Johan Bockgård <bojohan@gnu.org>
9350 Fix execution of x selection hooks.
9351 * xselect.c (Qx_lost_selection_functions)
9352 (Qx_sent_selection_functions): New vars.
9353 (syms_of_xselect): DEFSYM them.
9354 (x_handle_selection_request): Pass Qx_sent_selection_functions
9355 rather than Vx_sent_selection_functions to Frun_hook_with_args.
9356 (x_handle_selection_clear,x_clear_frame_selections):
9357 Pass Qx_lost_selection_functions rather than
9358 Vx_lost_selection_functions to Frun_hook_with_args.
9360 2011-07-13 Paul Eggert <eggert@cs.ucla.edu>
9362 * buffer.c (Fget_buffer_create): Initialize inhibit_shrinking.
9363 The old code sometimes used this field without initializing it.
9365 * alloc.c (gc_sweep): Don't read past end of array.
9366 In theory, the old code could also have corrupted Emacs internals,
9367 though it'd be very unlikely.
9369 2011-07-12 Andreas Schwab <schwab@linux-m68k.org>
9371 * character.c (Fcharacterp): Don't advertise optional ignored
9372 argument. (Bug#4026)
9374 2011-07-12 Lars Magne Ingebrigtsen <larsi@gnus.org>
9376 * keymap.c (syms_of_keymap): Clarify that "modifier" is "modifier
9379 * window.c (Fset_window_start): Doc fix (bug#4199).
9380 (Fset_window_hscroll): Ditto.
9382 2011-07-12 Paul Eggert <eggert@cs.ucla.edu>
9384 Fix minor new problems caught by GCC 4.6.1.
9385 * term.c (init_tty): Remove unused local.
9386 * xsettings.c (store_monospaced_changed): Define this function only
9387 if (defined HAVE_GSETTINGS || defined HAVE_GCONF), as it's
9390 2011-07-12 Chong Yidong <cyd@stupidchicken.com>
9392 * xdisp.c (Vresize_mini_windows): Minor doc fix (Bug#3300).
9394 2011-07-11 Lars Magne Ingebrigtsen <larsi@gnus.org>
9396 * xdisp.c (syms_of_xdisp): Make it explicit that the mini-windows
9397 are the mini-buffer and the echo area (bug#3320).
9399 * term.c (init_tty): Remove support for supdup, c10 and perq
9400 terminals, which are no longer supported (bug#1482).
9402 2011-07-10 Johan Bockgård <bojohan@gnu.org>
9404 * xdisp.c (Ftool_bar_lines_needed): Fix WINDOWP check.
9406 2011-07-10 Jan Djärv <jan.h.d@swipnet.se>
9408 * xmenu.c (menu_highlight_callback): Only pass frame to show_help_event
9409 for non-popups (Bug#3642).
9411 2011-07-10 Andreas Schwab <schwab@linux-m68k.org>
9413 * alloc.c (reset_malloc_hooks): Protoize.
9414 * buffer.c (mmap_init, mmap_find, mmap_free_1, mmap_enlarge)
9415 (mmap_set_vars, mmap_alloc, mmap_free, mmap_realloc): Likewise.
9416 * cm.c (losecursor): Likewise.
9417 * data.c (fmod): Likewise.
9418 * dispnew.c (swap_glyphs_in_rows): Likewise.
9419 * emacs.c (memory_warning_signal): Likewise.
9420 * floatfns.c (float_error): Likewise.
9421 * font.c (check_gstring, check_otf_features, otf_tag_symbol)
9422 (otf_open, font_otf_capability, generate_otf_features)
9423 (font_otf_DeviceTable, font_otf_ValueRecord, font_otf_Anchor):
9425 * image.c (pbm_read_file): Likewise.
9426 * indent.c (string_display_width): Likewise.
9427 * intervals.c (check_for_interval, search_for_interval)
9428 (inc_interval_count, count_intervals, root_interval)
9429 (adjust_intervals_for_insertion, make_new_interval): Likewise.
9430 * lread.c (defalias): Likewise.
9431 * ralloc.c (r_alloc_check): Likewise.
9432 * regex.c (set_image_of_range_1, set_image_of_range)
9433 (regex_grow_registers): Likewise.
9434 * sysdep.c (strerror): Likewise.
9435 * termcap.c (valid_filename_p, tprint, main): Likewise.
9436 * tparam.c (main): Likewise.
9437 * unexhp9k800.c (run_time_remap, save_data_space)
9438 (update_file_ptrs, read_header, write_header, calculate_checksum)
9439 (copy_file, copy_rest, display_header): Likewise.
9440 * widget.c (mark_shell_size_user_specified, create_frame_gcs):
9442 * xdisp.c (check_it): Likewise.
9443 * xfaces.c (register_color, unregister_color, unregister_colors):
9445 * xfns.c (print_fontset_result): Likewise.
9446 * xrdb.c (member, fatal, main): Likewise.
9448 2011-07-10 Paul Eggert <eggert@cs.ucla.edu>
9450 Fix minor problems found by static checking (Bug#9031).
9451 * chartab.c (char_table_set_range, map_sub_char_table):
9452 Remove unused locals.
9453 (uniprop_table): Now static.
9454 * composite.c (_work_char): Remove unused static var.
9456 2011-07-09 Juanma Barranquero <lekktu@gmail.com>
9458 * chartab.c (uniprop_table_uncompress): Remove unused local variable.
9460 2011-07-09 Jan Djärv <jan.h.d@swipnet.se>
9462 * gtkutil.c (qttip_cb): Remove code without function.
9464 2011-07-09 Eli Zaretskii <eliz@gnu.org>
9466 * w32.c (pthread_sigmask): New stub.
9468 2011-07-08 Paul Eggert <eggert@cs.ucla.edu>
9470 Use pthread_sigmask, not sigprocmask (Bug#9010).
9471 sigprocmask is portable only for single-threaded applications, and
9472 Emacs can be multi-threaded when it uses GTK.
9473 * Makefile.in (LIB_PTHREAD_SIGMASK): New macro.
9475 * callproc.c (Fcall_process):
9476 * process.c (create_process):
9477 * sysdep.c (sys_sigblock, sys_sigunblock, sys_sigsetmask):
9478 Use pthread_sigmask, not sigprocmask.
9480 2011-07-08 Jan Djärv <jan.h.d@swipnet.se>
9482 * gtkutil.c (qttip_cb): Set line wrap to FALSE for tooltip widget.
9483 (xg_prepare_tooltip): Revert text in x->ttip_lbl, margins was
9486 2011-07-08 Jan Djärv <jan.h.d@swipnet.se>
9488 * gtkutil.c (xg_prepare_tooltip): Fix indentation and comment.
9489 Put text in x->ttip_lbl instead of gtk_tooltip_set_text (Bug#8591).
9490 (xg_hide_tooltip): Fix comment.
9492 * nsterm.m (initFrameFromEmacs): Don't use ns_return_types
9493 in registerServicesMenuSendTypes.
9494 (validRequestorForSendType): Don't check ns_return_types.
9496 * nsfns.m (Fx_open_connection): Put NSStringPboardType into
9499 2011-07-08 Jason Rumney <jasonr@gnu.org>
9501 * w32term.c (x_make_frame_visible): Use SH_SHOWNORMAL rather than
9502 SH_SHOW for hidden windows (Bug#5482).
9504 * w32fns.c (w32_wnd_proc) [WM_TIMER, WM_SET_CURSOR]: Avoid using
9505 frame struct members of non-existent frames (Bug#6284).
9507 2011-07-08 Jan Djärv <jan.h.d@swipnet.se>
9509 * nsterm.m (keyDown): Call to wantsToDelayTextChangeNotifications and
9510 variable firstTime not needed on OSX >= 10.6.
9511 (setPosition): setFloatValue:knobProportion: is deprecated on OSX
9512 >= 10.5. Use setKnobProportion, setDoubleValue.
9514 * nsterm.h (MAC_OS_X_VERSION_10_3, MAC_OS_X_VERSION_10_4)
9515 (MAC_OS_X_VERSION_10_5): Define if not defined.
9516 (EmacsView, EmacsTooltip): Implements NSWindowDelegate on OSX >= 10.6.
9517 (EmacsMenu): Implements NSMenuDelegate on OSX >= 10.6.
9518 (EmacsToolbar): Implements NSToolbarDelegate on OSX >= 10.6.
9520 * nsselect.m (ns_string_from_pasteboard): Don't use deprecated methods
9521 cString and lossyCString on OSX >= 10.4.
9523 * nsmenu.m (fillWithWidgetValue): Don't use deprecated method
9524 sizeToFit on OSX >= 10.2.
9526 * nsimage.m (allocInitFromFile): Don't use deprecated method
9527 bestRepresentationForDevice on OSX >= 10.6.
9529 * nsfns.m (check_ns_display_info): Cast to long and use %ld in error
9532 * emacs.c: Declare unexec_init_emacs_zone.
9534 * nsgui.h: Fix compiler warning about gnulib redefining verify.
9536 * nsselect.m (ns_get_local_selection): Change to extern (Bug#8842).
9538 * nsmenu.m (ns_update_menubar): Remove useless setDelegate call
9539 on svcsMenu (Bug#8842).
9541 * nsfns.m (Fx_open_connection): Remove NSStringPboardType from
9543 (Fns_list_services): Just return Qnil on 10.6, code not working there.
9545 * nsterm.m (QUTF8_STRING): Declare.
9546 (initFrameFromEmacs): Call registerServicesMenuSendTypes.
9547 (validRequestorForSendType): Return type is (id).
9548 Change indexOfObjectIdenticalTo to indexOfObject.
9549 Check if we have local selection before returning self (Bug#8842).
9550 (writeSelectionToPasteboard): Put local selection into paste board
9551 if we have a local selection (Bug#8842).
9552 (syms_of_nsterm): DEFSYM QUTF8_STRING.
9554 * nsterm.h (MAC_OS_X_VERSION_10_6): Define here instead of nsterm.m.
9555 (ns_get_local_selection): Declare.
9557 2011-07-07 Lars Magne Ingebrigtsen <larsi@gnus.org>
9559 * keymap.c (describe_map_tree): Don't insert a double newline at
9560 the end of the buffer (bug#1169) and return whether we inserted
9563 * callint.c (Fcall_interactively): Change "reading args" to
9564 "providing args" to try to clarify what it does (bug#1010).
9566 2011-07-07 Kenichi Handa <handa@m17n.org>
9568 * composite.c (composition_compute_stop_pos): Ignore a static
9569 composition starting before CHARPOS (Bug#8915).
9571 * xdisp.c (handle_composition_prop): Likewise.
9573 2011-07-07 Eli Zaretskii <eliz@gnu.org>
9575 * term.c (produce_glyphs) <xassert>: Allow IT_GLYPHLESS in it->what.
9578 2011-07-07 Kenichi Handa <handa@m17n.org>
9580 * character.h (unicode_category_t): New enum type.
9582 * chartab.c (uniprop_decoder_t, uniprop_encoder_t): New types.
9583 (Qchar_code_property_table): New variable.
9584 (UNIPROP_TABLE_P, UNIPROP_GET_DECODER)
9585 (UNIPROP_COMPRESSED_FORM_P): New macros.
9586 (char_table_ascii): Uncompress the compressed values.
9587 (sub_char_table_ref): New arg is_uniprop. Callers changed.
9588 Uncompress the compressed values.
9589 (sub_char_table_ref_and_range): Likewise.
9590 (char_table_ref_and_range): Uncompress the compressed values.
9591 (sub_char_table_set): New arg is_uniprop. Callers changed.
9592 Uncompress the compressed values.
9593 (sub_char_table_set_range): Args changed. Callers changed.
9594 (char_table_set_range): Adjuted for the above change.
9595 (map_sub_char_table): Delete args default_val and parent. Add arg
9596 top. Give decoded values to a Lisp function.
9597 (map_char_table): Adjust for the above change. Give decoded
9598 values to a Lisp function. Gcpro more variables.
9599 (uniprop_table_uncompress)
9600 (uniprop_decode_value_run_length): New functions.
9601 (uniprop_decoder, uniprop_decoder_count): New variables.
9602 (uniprop_get_decoder, uniprop_encode_value_character)
9603 (uniprop_encode_value_run_length, uniprop_encode_value_numeric):
9605 (uniprop_encoder, uniprop_encoder_count): New variables.
9606 (uniprop_get_encoder, uniprop_table)
9607 (Funicode_property_table_internal, Fget_unicode_property_internal)
9608 (Fput_unicode_property_internal): New functions.
9609 (syms_of_chartab): DEFSYM Qchar_code_property_table, defsubr
9610 Sunicode_property_table_internal, Sget_unicode_property_internal,
9611 and Sput_unicode_property_internal. Defvar_lisp
9612 char-code-property-alist.
9614 * composite.c (CHAR_COMPOSABLE_P): Adjust for the change of
9615 Vunicode_category_table.
9617 * font.c (font_range): Adjust for the change of
9618 Vunicode_category_table.
9620 2011-07-07 Dan Nicolaescu <dann@ics.uci.edu>
9622 * m/iris4d.h: Remove file, move contents ...
9623 * s/irix6-5.h: ... here.
9625 2011-07-06 Paul Eggert <eggert@cs.ucla.edu>
9627 Remove unportable assumption about struct layout (Bug#8884).
9628 * alloc.c (mark_buffer):
9629 * buffer.c (reset_buffer_local_variables, Fbuffer_local_variables)
9630 (clone_per_buffer_values): Don't assume that
9631 sizeof (struct buffer) is a multiple of sizeof (Lisp_Object).
9632 This isn't true in general, and it's particularly not true
9633 if Emacs is configured with --with-wide-int.
9634 * buffer.h (FIRST_FIELD_PER_BUFFER, LAST_FIELD_PER_BUFFER):
9635 New macros, used in the buffer.c change.
9637 2011-07-05 Jan Djärv <jan.h.d@swipnet.se>
9639 * xsettings.c: Use both GConf and GSettings if both are available.
9640 (store_config_changed_event): Add comment.
9641 (dpyinfo_valid, store_font_name_changed, map_tool_bar_style)
9642 (store_tool_bar_style_changed): New functions.
9643 (store_monospaced_changed): Add comment. Call dpyinfo_valid.
9644 (struct xsettings): Move font inside HAVE_XFT.
9645 (GSETTINGS_TOOL_BAR_STYLE, GSETTINGS_FONT_NAME): New defines.
9646 (GSETTINGS_MONO_FONT): Rename from SYSTEM_MONO_FONT.
9647 Move inside HAVE_XFT.
9648 (something_changed_gsettingsCB): Rename from something_changedCB.
9649 Check for changes in GSETTINGS_TOOL_BAR_STYLE and GSETTINGS_FONT_NAME
9651 (GCONF_TOOL_BAR_STYLE, GCONF_FONT_NAME): New defines.
9652 (GCONF_MONO_FONT): Rename from SYSTEM_MONO_FONT. Move inside HAVE_XFT.
9653 (something_changed_gconfCB): Rename from something_changedCB.
9654 Check for changes in GCONF_TOOL_BAR_STYLE and GCONF_FONT_NAME also.
9655 (parse_settings): Move check for font inside HAVE_XFT.
9656 (read_settings, apply_xft_settings): Add comment.
9657 (read_and_apply_settings): Add comment. Call map_tool_bar_style and
9658 store_tool_bar_style_changed. Move check for font inside HAVE_XFT and
9659 call store_font_name_changed.
9660 (xft_settings_event): Add comment.
9661 (init_gsettings): Add comment. Get values for GSETTINGS_TOOL_BAR_STYLE
9662 and GSETTINGS_FONT_NAME. Move check for fonts within HAVE_XFT.
9663 (init_gconf): Add comment. Get values for GCONF_TOOL_BAR_STYLE
9664 and GCONF_FONT_NAME. Move check for fonts within HAVE_XFT.
9665 (xsettings_initialize): Call init_gsettings last.
9666 (xsettings_get_system_font, xsettings_get_system_normal_font):
9669 2011-07-05 Paul Eggert <eggert@cs.ucla.edu>
9671 Random fixes. E.g., (random) never returned negative values.
9672 * fns.c (Frandom): Use GET_EMACS_TIME for random seed, and add the
9673 subseconds part to the entropy, as that's a bit more random.
9674 Prefer signed to unsigned, since the signedness doesn't matter and
9675 in general we prefer signed. When given a limit, use a
9676 denominator equal to INTMASK + 1, not to VALMASK + 1, because the
9677 latter isn't right if USE_2_TAGS_FOR_INTS.
9678 * sysdep.c (get_random): Return a value in the range 0..INTMASK,
9679 not 0..VALMASK. Don't discard "excess" bits that random () returns.
9681 2011-07-04 Stefan Monnier <monnier@iro.umontreal.ca>
9683 * textprop.c (text_property_stickiness):
9684 Obey Vtext_property_default_nonsticky.
9685 (syms_of_textprop): Add `display' to Vtext_property_default_nonsticky.
9686 * w32fns.c (syms_of_w32fns):
9687 * xfns.c (syms_of_xfns): Don't Add `display' since it's there by default.
9689 2011-07-04 Paul Eggert <eggert@cs.ucla.edu>
9691 * fileio.c (barf_or_query_if_file_exists): Use S_ISDIR.
9692 This is more efficient than Ffile_directory_p and avoids a minor race.
9694 2011-07-04 Lars Magne Ingebrigtsen <larsi@gnus.org>
9696 * buffer.c (Foverlay_put): Say what the return value is
9699 * fileio.c (barf_or_query_if_file_exists): Check first if the file
9700 is a directory before asking whether to use the file name
9702 (barf_or_query_if_file_exists): Make the "File is a directory"
9703 error be more correct.
9705 * fns.c (Frequire): Remove the mention of the .gz files, since
9706 that's installation-specific, but keep the mention of
9707 `get-load-suffixes'.
9709 2011-07-04 Paul Eggert <eggert@cs.ucla.edu>
9711 * editfns.c (Fformat_time_string): Don't assume strlen fits in int.
9712 Report string overflow if the output is too long.
9714 2011-07-04 Juanma Barranquero <lekktu@gmail.com>
9716 * gnutls.c (Fgnutls_boot): Don't mention :verify-error.
9717 (syms_of_gnutls): Remove duplicate DEFSYM for
9718 Qgnutls_bootprop_verify_hostname_error, an error for
9719 Qgnutls_bootprop_verify_error (which is no longer used).
9721 * eval.c (find_handler_clause): Remove parameters `sig' and `data',
9722 unused since 2011-01-26T20:02:07Z!monnier@iro.umontreal.ca. All callers changed.
9723 Also (re)move comments that are misplaced or no longer relevant.
9725 2011-07-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
9727 * callint.c (Finteractive): Clarify the meaning of "@" (bug#8813).
9729 2011-07-03 Chong Yidong <cyd@stupidchicken.com>
9731 * xfaces.c (Finternal_merge_in_global_face): Modify the foreground
9732 and background color parameters if they have been changed.
9734 2011-07-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
9736 * editfns.c (Fformat): Clarify the - and 0 flags (bug#6659).
9738 2011-07-03 Paul Eggert <eggert@cs.ucla.edu>
9740 * xsettings.c (SYSTEM_FONT): Define only when used.
9741 No need to define when HAVE_GSETTINGS || !HAVE_XFT.
9743 * keymap.c (access_keymap_1): Now static.
9745 2011-07-02 Chong Yidong <cyd@stupidchicken.com>
9747 * keyboard.c (command_loop_1): If a down-mouse event is unbound,
9748 leave any prefix arg for the up event (Bug#1586).
9750 2011-07-02 Lars Magne Ingebrigtsen <larsi@gnus.org>
9752 * lread.c (syms_of_lread): Mention single symbols defined by
9753 `defvar' or `defconst' (bug#7154).
9755 * fns.c (Frequire): Mention .el.gz files (bug#7314).
9756 (Frequire): Mention get-load-suffixes.
9758 2011-07-02 Martin Rudalics <rudalics@gmx.at>
9760 * window.h (window): Remove clone_number slot.
9761 * window.c (Fwindow_clone_number, Fset_window_clone_number):
9763 (make_parent_window, make_window, saved_window)
9764 (Fset_window_configuration, save_window_save): Don't deal with
9766 * buffer.c (Qclone_number): Remove declaration.
9767 (sort_overlays, overlay_strings): Don't deal with clone numbers.
9769 2011-07-02 Stefan Monnier <monnier@iro.umontreal.ca>
9771 Add multiple inheritance to keymaps.
9772 * keymap.c (Fmake_composed_keymap): New function.
9773 (Fset_keymap_parent): Simplify.
9774 (fix_submap_inheritance): Remove.
9775 (access_keymap_1): New function extracted from access_keymap to handle
9776 embedded parents and handle lists of maps.
9777 (access_keymap): Use it.
9778 (Fkeymap_prompt, map_keymap_internal, map_keymap, store_in_keymap)
9779 (Fcopy_keymap): Handle embedded parents.
9780 (Fcommand_remapping, define_as_prefix): Simplify.
9781 (Fkey_binding): Simplify.
9782 (syms_of_keymap): Move minibuffer-local-completion-map,
9783 minibuffer-local-filename-completion-map,
9784 minibuffer-local-must-match-map, and
9785 minibuffer-local-filename-must-match-map to Elisp.
9786 (syms_of_keymap): Defsubr make-composed-keymap.
9787 * keyboard.c (menu_bar_items): Use map_keymap_canonical.
9788 (parse_menu_item): Trivial simplification.
9790 2011-07-01 Glenn Morris <rgm@gnu.org>
9792 * Makefile.in (SETTINGS_LIBS): Fix typo.
9794 2011-07-01 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny patch)
9796 * coding.c (Fencode_coding_string): Record the last coding system
9797 used, as the function doc string says (bug#8738).
9799 2011-07-01 Jan Djärv <jan.h.d@swipnet.se>
9801 * xsettings.c (store_monospaced_changed): Take new font as arg and
9802 check for change against current_mono_font.
9803 (EMACS_TYPE_SETTINGS): Remove this and related defines.
9804 (emacs_settings_constructor, emacs_settings_get_property)
9805 (emacs_settings_set_property, emacs_settings_class_init)
9806 (emacs_settings_init, gsettings_obj): Remove.
9807 (something_changedCB): New function for HAVE_GSETTINGS.
9808 (something_changedCB): HAVE_GCONF: Call store_monospaced_changed
9809 with value as argument.
9810 (init_gsettings): Check that GSETTINGS_SCHEMA exists before calling
9811 g_settings_new (Bug#8967). Do not create gsettings_obj.
9812 Remove calls to g_settings_bind. Connect something_changedCB to
9815 * xgselect.c: Add defined (HAVE_GSETTINGS).
9816 (xgselect_initialize): Ditto.
9818 * process.c: Add defined (HAVE_GSETTINGS) for xgselect.h
9819 (wait_reading_process_output): Add defined (HAVE_GSETTINGS) for
9822 2011-07-01 Paul Eggert <eggert@cs.ucla.edu>
9824 * eval.c (struct backtrace): Simplify and port the data structure.
9825 Do not assume that "int nargs : BITS_PER_INT - 2;" produces a
9826 signed bit field, as this assumption is not portable and it makes
9827 Emacs crash when compiled with Sun C 5.8 on sparc. Do not use
9828 "char debug_on_exit : 1" as this is not portable either; instead,
9829 use the portable "unsigned int debug_on_exit : 1". Remove unused
9830 member evalargs. Remove obsolete comments about cc bombing out.
9832 2011-06-30 Jan Djärv <jan.h.d@swipnet.se>
9834 * xsettings.c: Include glib-object.h, gio/gio.h if HAVE_GSETTINGS.
9835 Let HAVE_GSETTINGS override HAVE_GCONF.
9836 (store_monospaced_changed): New function.
9837 (EMACS_SETTINGS): A new type derived from GObject to handle
9838 GSettings notifications.
9839 (emacs_settings_constructor, emacs_settings_get_property)
9840 (emacs_settings_set_property, emacs_settings_class_init):
9842 (gsettings_client, gsettings_obj): New variables.
9843 (GSETTINGS_SCHEMA): New define.
9844 (something_changedCB): Call store_monospaced_changed.
9845 (init_gsettings): New function.
9846 (xsettings_initialize): Call init_gsettings.
9847 (syms_of_xsettings): Initialize gsettings_client, gsettings_obj
9850 * Makefile.in (SETTINGS_CFLAGS, SETTINGS_LIBS): Rename from
9853 2011-06-29 Martin Rudalics <rudalics@gmx.at>
9855 * window.c (resize_root_window, grow_mini_window)
9856 (shrink_mini_window): Rename Qresize_root_window to
9857 Qwindow_resize_root_window and Qresize_root_window_vertically to
9858 Qwindow_resize_root_window_vertically.
9860 2011-06-28 Paul Eggert <eggert@cs.ucla.edu>
9862 * gnutls.c (Qgnutls_bootprop_verify_error): Remove unused var.
9864 2011-06-27 Juanma Barranquero <lekktu@gmail.com>
9866 * makefile.w32-in: Redesign dependencies so they reflect more
9867 clearly which files are directly included by each source file,
9868 and not through other includes.
9870 2011-06-27 Martin Rudalics <rudalics@gmx.at>
9872 * buffer.c (Qclone_number): Declare static and DEFSYM it.
9873 (sort_overlays, overlay_strings): When an overlay's clone number
9874 matches the window's clone number process the overlay even if
9875 the overlay's window property doesn't match the current window.
9877 * window.c (Fwindow_vchild): Rename to Fwindow_top_child.
9878 (Fwindow_hchild): Rename to Fwindow_left_child.
9879 (Fwindow_next): Rename to Fwindow_next_sibling.
9880 (Fwindow_prev): Rename to Fwindow_prev_sibling.
9881 (resize_window_check): Rename to window_resize_check.
9882 (resize_window_apply): Rename to window_resize_apply.
9883 (Fresize_window_apply): Rename to Fwindow_resize_apply.
9884 (Fdelete_other_windows_internal, resize_frame_windows)
9885 (Fsplit_window_internal, Fdelete_window_internal)
9886 (grow_mini_window, shrink_mini_window)
9887 (Fresize_mini_window_internal): Fix callers accordingly.
9889 2011-06-26 Jan Djärv <jan.h.d@swipnet.se>
9891 * emacsgtkfixed.h: State that this is only used with Gtk+3.
9892 (emacs_fixed_set_min_size): Remove.
9893 (emacs_fixed_new): Take frame as argument.
9895 * emacsgtkfixed.c: State that this is only used with Gtk+3.
9896 (_EmacsFixedPrivate): Remove minwidth/height.
9897 Add struct frame *f.
9898 (emacs_fixed_init): Initialize priv->f.
9899 (get_parent_class, emacs_fixed_set_min_size): Remove.
9900 (emacs_fixed_new): Set priv->f to argument.
9901 (emacs_fixed_get_preferred_width)
9902 (emacs_fixed_get_preferred_height): Use min_width/height from
9903 frames size_hint to set minimum and natural (Bug#8919).
9904 (XSetWMSizeHints, XSetWMNormalHints): Override these functions
9905 and use min_width/height from frames size_hint to set
9906 min_width/height (Bug#8919).
9908 * gtkutil.c (xg_create_frame_widgets): Pass f to emacs_fixed_new.
9909 (x_wm_set_size_hint): Remove call to emacs_fixed_set_min_size.
9912 2011-06-26 Eli Zaretskii <eliz@gnu.org>
9914 * bidi.c (bidi_paragraph_init): Test for ZV_BYTE before calling
9915 bidi_at_paragraph_end, since fast_looking_at doesn't like to be
9918 2011-06-26 Chong Yidong <cyd@stupidchicken.com>
9920 * process.c (wait_reading_process_output): Bypass select if
9921 waiting for a cell while ignoring keyboard input, and input is
9922 pending. Suggested by Jan Djärv (Bug#8869).
9924 2011-06-25 Paul Eggert <eggert@cs.ucla.edu>
9926 Use gnulib's dup2 module instead of rolling our own.
9927 * sysdep.c (dup2) [!HAVE_DUP2]: Remove; gnulib now does this.
9929 2011-06-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
9931 * dispnew.c (scrolling_window): Before scrolling, turn off a
9932 mouse-highlight in the window being scrolled.
9934 2011-06-24 Juanma Barranquero <lekktu@gmail.com>
9936 Move DEFSYM to lisp.h and use everywhere.
9938 * character.h (DEFSYM): Move declaration...
9939 * lisp.h (DEFSYM): ...here.
9945 * w32select.c: Don't include character.h.
9947 * alloc.c (syms_of_alloc):
9948 * buffer.c (syms_of_buffer):
9949 * bytecode.c (syms_of_bytecode):
9950 * callint.c (syms_of_callint):
9951 * casefiddle.c (syms_of_casefiddle):
9952 * casetab.c (init_casetab_once):
9953 * category.c (init_category_once, syms_of_category):
9954 * ccl.c (syms_of_ccl):
9955 * cmds.c (syms_of_cmds):
9956 * composite.c (syms_of_composite):
9957 * dbusbind.c (syms_of_dbusbind):
9958 * dired.c (syms_of_dired):
9959 * dispnew.c (syms_of_display):
9960 * doc.c (syms_of_doc):
9961 * editfns.c (syms_of_editfns):
9962 * emacs.c (syms_of_emacs):
9963 * eval.c (syms_of_eval):
9964 * fileio.c (syms_of_fileio):
9965 * fns.c (syms_of_fns):
9966 * frame.c (syms_of_frame):
9967 * fringe.c (syms_of_fringe):
9968 * insdel.c (syms_of_insdel):
9969 * keymap.c (syms_of_keymap):
9970 * lread.c (init_obarray, syms_of_lread):
9971 * macros.c (syms_of_macros):
9972 * msdos.c (syms_of_msdos):
9973 * print.c (syms_of_print):
9974 * process.c (syms_of_process):
9975 * search.c (syms_of_search):
9976 * sound.c (syms_of_sound):
9977 * syntax.c (init_syntax_once, syms_of_syntax):
9978 * terminal.c (syms_of_terminal):
9979 * textprop.c (syms_of_textprop):
9980 * undo.c (syms_of_undo):
9981 * w32.c (globals_of_w32):
9982 * window.c (syms_of_window):
9983 * xdisp.c (syms_of_xdisp):
9984 * xfaces.c (syms_of_xfaces):
9985 * xfns.c (syms_of_xfns):
9986 * xmenu.c (syms_of_xmenu):
9987 * xsettings.c (syms_of_xsettings):
9988 * xterm.c (syms_of_xterm): Use DEFSYM.
9990 2011-06-24 Teodor Zlatanov <tzz@lifelogs.com>
9992 * gnutls.c (syms_of_gnutls): Use the DEFSYM macro from character.h.
9994 2011-06-23 Paul Eggert <eggert@cs.ucla.edu>
9996 Integer and buffer overflow fixes (Bug#8873).
9998 * print.c (printchar, strout): Check for string overflow.
9999 (PRINTPREPARE, printchar, strout):
10000 Don't set size unless allocation succeeds.
10002 * minibuf.c (read_minibuf_noninteractive): Use ptrdiff_t, not int,
10003 for sizes. Check for string overflow more accurately.
10004 Simplify newline removal at end; this suppresses a GCC 4.6.0 warning.
10006 * macros.c: Integer and buffer overflow fixes.
10007 * keyboard.h (struct keyboard.kbd_macro_bufsize):
10008 * macros.c (Fstart_kbd_macro, store_kbd_macro_char):
10009 Use ptrdiff_t, not int, for sizes.
10010 Don't increment bufsize until after realloc succeeds.
10011 Check for size-calculation overflow.
10012 (Fstart_kbd_macro): Use EMACS_INT, not int, for XINT result.
10014 * lisp.h (DEFVAR_KBOARD): Use offsetof instead of char * finagling.
10016 * lread.c: Integer overflow fixes.
10017 (read_integer): Radix is now EMACS_INT, not int,
10018 to improve quality of diagnostics for out-of-range radices.
10019 Calculate buffer size correctly for out-of-range radices.
10020 (read1): Check for integer overflow in radices, and in
10021 read-circle numbers.
10022 (read_escape): Avoid int overflow.
10023 (Fload, openp, read_buffer_size, read1)
10024 (substitute_object_recurse, read_vector, read_list, map_obarray):
10025 Use ptrdiff_t, not int, for sizes.
10026 (read1): Use EMACS_INT, not int, for sizes.
10027 Check for size overflow.
10029 * image.c (cache_image): Check for size arithmetic overflow.
10031 * lread.c: Integer overflow issues.
10032 (saved_doc_string_size, saved_doc_string_length)
10033 (prev_saved_doc_string_size, prev_saved_doc_string_length):
10034 Now ptrdiff_t, not int.
10035 (read1): Don't assume doc string length fits in int. Check for
10036 out-of-range doc string lengths.
10037 (read_list): Don't assume file position fits in int.
10038 (read_escape): Check for hex character overflow.
10040 2011-06-22 Leo Liu <sdl.web@gmail.com>
10042 * minibuf.c (Fcompleting_read_default, Vcompleting_read_function):
10043 Move to minibuffer.el.
10045 2011-06-22 Paul Eggert <eggert@cs.ucla.edu>
10047 Fixes for GLYPH_DEBUG found by GCC 4.6.0 static checking.
10048 The following patches are for when GLYPH_DEBUG && !XASSERT.
10049 * dispextern.h (trace_redisplay_p, dump_glyph_string):
10050 * dispnew.c (flush_stdout):
10051 * xdisp.c (dump_glyph_row, dump_glyph_matrix, dump_glyph):
10052 Mark as externally visible.
10053 * dispnew.c (check_window_matrix_pointers): Now static.
10054 * dispnew.c (window_to_frame_vpos):
10055 * xfns.c (unwind_create_frame):
10056 * xterm.c (x_check_font): Remove unused local.
10057 * scroll.c (CHECK_BOUNDS):
10058 * xfaces.c (cache_fache): Rename local to avoid shadowing.
10059 * xfns.c, w32fns.c (image_cache_refcount, dpyinfo_refcount): Now static.
10060 * xdisp.c (check_window_end): Now a no-op if !XASSERTS.
10061 (debug_first_unchanged_at_end_vpos, debug_last_unchanged_at_beg_vpos)
10062 (debug_dvpos, debug_dy, debug_delta, debug_delta_bytes, debug_end_vpos):
10064 (debug_method_add): Use va_list and vsprintf rather than relying
10065 on undefined behavior with wrong number of arguments.
10066 (dump_glyph, dump_glyph_row, Fdump_glyph_matrix):
10067 Don't assume ptrdiff_t and EMACS_INT are the same width as int.
10068 In this code, it's OK to assume C99 behavior for ptrdiff_t formats
10069 since we're not interested in debugging glyphs with old libraries.
10070 * xfaces.c (cache_face): Move debugging code earlier; this pacifies
10071 GCC 4.6.0's static checking.
10073 2011-06-22 Paul Eggert <eggert@cs.ucla.edu>
10075 Integer overflow and signedness fixes (Bug#8873).
10076 A few related buffer overrun fixes, too.
10078 * font.c (font_score): Use EMACS_INT, not int, to store XINT value.
10080 * dispextern.h (struct face.stipple):
10081 * image.c (x_bitmap_height, x_bitmap_width, x_bitmap_pixmap)
10082 (x_bitmap_mask, x_allocate_bitmap_record)
10083 (x_create_bitmap_from_data, x_create_bitmap_from_file)
10084 (x_destroy_bitmap, x_destroy_all_bitmaps, x_create_bitmap_mask)
10085 (x_create_bitmap_from_xpm_data):
10086 * nsterm.h (struct ns_display_info.bitmaps_size, .bitmaps_last):
10087 * w32term.h (struct w32_display_info.icon_bitmap_id, .bitmaps_size)
10089 * xfaces.c (load_pixmap):
10090 * xterm.c (x_bitmap_icon, x_wm_set_icon_pixmap):
10091 * xterm.h (struct x_display_info.icon_bitmap_id, .bitmaps_size)
10092 (.bitmaps_last, struct x_output.icon_bitmap):
10093 Use ptrdiff_t, not int, for bitmap indexes.
10094 (x_allocate_bitmap_record): Check for size overflow.
10095 * dispextern.h, lisp.h: Adjust to API changes elsewhere.
10097 Use ptrdiff_t, not int, for overlay counts.
10098 * buffer.h (overlays_at, sort_overlays, GET_OVERLAYS_AT):
10099 * editfns.c (overlays_around, get_pos_property):
10100 * textprop.c (get_char_property_and_overlay):
10101 * xdisp.c (next_overlay_change, note_mouse_highlight):
10102 * xfaces.c (face_at_buffer_position):
10103 * buffer.c (OVERLAY_COUNT_MAX): New macro.
10104 (overlays_at, overlays_in, sort_overlays, Foverlays_at)
10105 (Fnext_overlay_change, Fprevious_overlay_change)
10106 (mouse_face_overlay_overlaps, Foverlays_in):
10107 Use ptrdiff_t, not int, for sizes.
10108 (overlays_at, overlays_in): Check for size-calculation overflow.
10110 * xterm.c (xim_initialize, same_x_server): Strlen may not fit in int.
10112 * xsmfns.c (smc_save_yourself_CB, x_session_initialize): Avoid strlen.
10113 (x_session_initialize): Do not assume string length fits in int.
10115 * xsettings.c (apply_xft_settings): Fix potential buffer overrun.
10116 This is unlikely, but can occur if DPI is outlandish.
10118 * xsettings.c (Ffont_get_system_normal_font, Ffont_get_system_font):
10119 * xselect.c (Fx_get_atom_name): Avoid need for strlen.
10121 * xrdb.c: Don't assume strlen fits in int; avoid some strlens.
10122 * xrdb.c (magic_file_p, search_magic_path):
10123 Omit last arg SUFFIX; it was always 0. All callers changed.
10124 (magic_file_p): Use ptrdiff_t, not int. Check for size overflow.
10126 * xfont.c (xfont_match): Avoid need for strlen.
10128 * xfns.c: Don't assume strlen fits in int.
10129 (xic_create_fontsetname, x_window): Use ptrdiff_t, not int.
10131 * xdisp.c (message_log_check_duplicate): Return intmax_t,
10132 not unsigned long, as we prefer signed integers. All callers changed.
10133 Detect integer overflow in repeat count.
10134 (message_dolog): Don't assume print length fits in 39 bytes.
10135 (display_mode_element): Don't assume strlen fits in int.
10137 * termcap.c: Don't assume sizes fit in int and never overflow.
10138 (struct termcap_buffer, tgetent): Use ptrdiff_t, not int, for sizes.
10139 (gobble_line): Check for size-calculation overflow.
10141 * minibuf.c (Fread_buffer):
10142 * lread.c (intern, intern_c_string):
10143 * image.c (xpm_scan) [HAVE_NS && !HAVE_XPM]:
10144 Don't assume string length fits in int.
10146 * keyboard.c (parse_tool_bar_item):
10147 * gtkutil.c (style_changed_cb): Avoid need for strlen.
10149 * font.c: Don't assume string length fits in int.
10150 (font_parse_xlfd, font_parse_fcname, font_unparse_fcname):
10151 Use ptrdiff_t, not int.
10152 (font_intern_prop): Don't assume string length fits in int.
10153 Don't assume integer property fits in fixnum.
10154 * font.h (font_intern_prop): 2nd arg is now ptrdiff_t, not int.
10156 * filelock.c: Fix some buffer overrun and integer overflow issues.
10157 (get_boot_time): Don't assume gzip command string fits in 100 bytes.
10158 Reformulate so as not to need the command string.
10159 Invoke gzip -cd rather than gunzip, as it's more portable.
10160 (lock_info_type, lock_file_1, lock_file):
10161 Don't assume pid_t and time_t fit in unsigned long.
10162 (LOCK_PID_MAX): Remove; we now use more-reliable bounds.
10163 (current_lock_owner): Prefer signed type for sizes.
10164 Use memcpy, not strncpy, where memcpy is what is really wanted.
10165 Don't assume (via atoi) that time_t and pid_t fit in int.
10166 Check for time_t and/or pid_t out of range, e.g., via a network share.
10167 Don't alloca where an auto var works fine.
10169 * fileio.c: Fix some integer overflow issues.
10170 (file_name_as_directory, Fexpand_file_name, Fsubstitute_in_file_name):
10171 Don't assume string length fits in int.
10172 (directory_file_name): Don't assume string length fits in long.
10173 (make_temp_name): Don't assume pid fits in int, or that its print
10174 length is less than 20.
10176 * data.c (Fsubr_name): Rewrite to avoid a strlen call.
10178 * coding.c (make_subsidiaries): Don't assume string length fits in int.
10180 * callproc.c (child_setup): Rewrite to avoid two strlen calls.
10182 * process.c (Fformat_network_address): Use EMACS_INT, not EMACS_UINT.
10183 We prefer signed integers, even for size calculations.
10185 * emacs.c: Don't assume string length fits in 'int'.
10186 (DEFINE_DUMMY_FUNCTION, sort_args): Use ptrdiff_t, not int.
10187 (main): Don't invoke strlen when not needed.
10189 * dbusbind.c (XD_ERROR): Don't arbitrarily truncate string.
10190 (XD_DEBUG_MESSAGE): Don't waste a byte.
10192 * callproc.c (getenv_internal_1, getenv_internal)
10193 (Fgetenv_internal):
10194 * buffer.c (init_buffer): Don't assume string length fits in 'int'.
10196 * lread.c (invalid_syntax): Omit length argument.
10197 All uses changed. This doesn't fix a bug, but it simplifies the
10198 code away from its former Hollerith-constant appearance, and it's
10199 one less 'int' to worry about when looking at integer-overflow issues.
10200 (string_to_number): Simplify 2011-04-26 change by invoking xsignal1.
10202 * lisp.h (DEFUN): Remove bogus use of sizeof (struct Lisp_Subr).
10203 This didn't break anything, but it didn't help either.
10204 It's confusing to put a bogus integer in a place where the actual
10205 value does not matter.
10206 (LIST_END_P): Remove unused macro and its bogus comment.
10207 (make_fixnum_or_float): Remove unnecessary cast to EMACS_INT.
10209 * lisp.h (union Lisp_Object.i): EMACS_INT, not EMACS_UINT.
10210 This is for consistency with the ordinary, non-USE_LISP_UNION_TYPE,
10212 (struct Lisp_Bool_Vector.size): EMACS_INT, not EMACS_UINT.
10213 We prefer signed types, and the value cannot exceed the EMACS_INT
10214 range anyway (because otherwise the length would not be representable).
10215 (XSET) [USE_LISP_UNION_TYPE]: Use uintptr_t and intptr_t,
10216 not EMACS_UINT and EMACS_INT, when converting pointer to integer.
10217 This avoids a GCC warning when WIDE_EMACS_INT.
10219 * indent.c (sane_tab_width): New function.
10220 (current_column, scan_for_column, Findent_to, position_indentation)
10221 (compute_motion): Use it. This is just for clarity.
10222 (Fcompute_motion): Don't assume hscroll and tab offset fit in int.
10224 * image.c (xbm_image_p): Don't assume stated width, height fit in int.
10226 * lisp.h (lint_assume): New macro.
10227 * composite.c (composition_gstring_put_cache):
10228 * ftfont.c (ftfont_shape_by_flt): Use it to pacify GCC 4.6.0.
10230 * editfns.c, insdel.c:
10231 Omit unnecessary forward decls, to simplify future changes.
10233 * ftfont.c (ftfont_shape_by_flt): Use signed integers for lengths.
10235 * font.c (Ffont_shape_gstring): Don't assume glyph len fits in 'int'.
10237 * fns.c (Ffillarray): Don't assume bool vector size fits in 'int'.
10238 Use much-faster test for byte-length change.
10239 Don't assume string byte-length fits in 'int'.
10240 Check that character arg fits in 'int'.
10241 (mapcar1): Declare byte as byte, for clarity.
10243 * alloc.c (Fmake_bool_vector): Avoid unnecessary multiplication.
10245 * fns.c (concat): Catch string overflow earlier.
10246 Do not rely on integer wraparound.
10248 * dispextern.h (struct it.overlay_strings_charpos)
10249 (struct it.selective): Now EMACS_INT, not int.
10250 * xdisp.c (forward_to_next_line_start)
10251 (back_to_previous_visible_line_start)
10252 (reseat_at_next_visible_line_start, next_element_from_buffer):
10253 Don't arbitrarily truncate the value of 'selective' to int.
10255 * xdisp.c (init_iterator): Use XINT, not XFASTINT; it might be < 0.
10257 * composite.c: Don't truncate sizes to 'int'.
10258 (composition_gstring_p, composition_reseat_it)
10259 (composition_adjust_point): Use EMACS_INT, not int.
10260 (get_composition_id, composition_gstring_put_cache): Use EMACS_INT,
10261 not EMACS_UINT, for indexes.
10263 * category.h (CATEGORY_SET_P): Remove unnecessary cast to EMACS_INT.
10265 * buffer.c: Include <verify.h>.
10266 (struct sortvec.priority, struct sortstr.priority):
10267 Now EMACS_INT, not int.
10268 (compare_overlays, cmp_for_strings): Avoid subtraction overflow.
10269 (struct sortstr.size, record_overlay_string)
10270 (struct sortstrlist.size, struct sortlist.used):
10271 Don't truncate size to int.
10272 (record_overlay_string): Check for size-calculation overflow.
10273 (init_buffer_once): Check at compile-time, not run-time.
10275 2011-06-22 Jim Meyering <meyering@redhat.com>
10277 Don't leak an XBM-image-sized buffer
10278 * image.c (xbm_load): Free the image buffer after using it.
10280 2011-06-21 Paul Eggert <eggert@cs.ucla.edu>
10283 * composite.c (find_automatic_composition): Omit needless 'return 0;'
10284 that Sun C diagnosed.
10285 * fns.c (secure_hash): Fix pointer signedness issue.
10286 * intervals.c (static_offset_intervals): New function.
10287 (offset_intervals): Use it.
10289 2011-06-21 Leo Liu <sdl.web@gmail.com>
10292 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha256.h and
10295 * fns.c (secure_hash): Rename from crypto_hash_function and change
10296 the first arg to accept symbols.
10297 (Fsecure_hash): New primitive.
10298 (syms_of_fns): New symbols.
10300 2011-06-20 Deniz Dogan <deniz@dogan.se>
10302 * process.c (Fset_process_buffer): Clarify return value in
10305 2011-06-18 Chong Yidong <cyd@stupidchicken.com>
10307 * dispnew.c (add_window_display_history): Use BVAR.
10309 * xdisp.c (debug_method_add): Use BVAR.
10310 (check_window_end, dump_glyph_matrix, dump_glyph)
10311 (dump_glyph_row, dump_glyph_string): Convert arglist to ANSI C.
10313 * xfaces.c (check_lface_attrs, check_lface, dump_realized_face):
10316 * xfns.c (Fx_create_frame, x_create_tip_frame): Delay image cache
10317 check till after the cache is created in init_frame_faces.
10319 2011-06-17 Stefan Monnier <monnier@iro.umontreal.ca>
10321 * fns.c (Fsafe_length): Yet another int/Lisp_Object mixup.
10323 2011-06-16 Paul Eggert <eggert@cs.ucla.edu>
10325 * lisp.h: Include <limits.h>, for INT_MAX, LONG_MAX, LLONG_MAX.
10326 Without this, prin1 mishandles Lisp_Misc_Save_Value printing on
10327 hosts with pre-C99 libraries, because pD is wrongly defined to "t".
10329 Improve buffer-overflow checking (Bug#8873).
10330 * fileio.c (Finsert_file_contents):
10331 * insdel.c (insert_from_buffer_1, replace_range, replace_range_2):
10332 Remove the old (too-loose) buffer overflow checks.
10333 They weren't needed, since make_gap checks for buffer overflow.
10334 * insdel.c (make_gap_larger): Catch buffer overflows that were missed.
10335 The old code merely checked for Emacs fixnum overflow, and relied
10336 on undefined (wraparound) behavior. The new code avoids undefined
10337 behavior, and also checks for ptrdiff_t and/or size_t overflow.
10339 * editfns.c (Finsert_char): Don't dump core with very negative counts.
10340 Tune. Don't use wider integers than needed. Don't use alloca.
10341 Use a bigger 'string' buffer. Rewrite to avoid 'n > 0' test.
10343 * insdel.c (replace_range): Fix buf overflow when insbytes < outgoing.
10345 * insdel.c, lisp.h (buffer_overflow): New function.
10346 (insert_from_buffer_1, replace_range, replace_range_2):
10347 * insdel.c (make_gap_larger):
10348 * editfns.c (Finsert_char):
10349 * fileio.c (Finsert_file_contents): Use it, to normalize wording.
10351 * buffer.h (BUF_BYTES_MAX): Cast to ptrdiff_t so that it's signed.
10353 2011-06-15 Paul Eggert <eggert@cs.ucla.edu>
10355 Integer overflow and signedness fixes (Bug#8873, Bug#8828).
10357 * ccl.c (ASCENDING_ORDER): New macro, to work around GCC bug 43772.
10358 (GET_CCL_RANGE, IN_INT_RANGE): Use it.
10360 * fileio.c: Don't assume EMACS_INT fits in off_t.
10361 (emacs_lseek): New static function.
10362 (Finsert_file_contents, Fwrite_region): Use it.
10363 Use SEEK_SET, SEEK_CUR, SEEK_END as appropriate.
10365 * fns.c (Fload_average): Don't assume 100 * load average fits in int.
10367 * fns.c: Don't overflow int when computing a list length.
10368 * fns.c (QUIT_COUNT_HEURISTIC): New constant.
10369 (Flength, Fsafe_length): Use EMACS_INT, not int, to avoid unwanted
10370 truncation on 64-bit hosts. Check for QUIT every
10371 QUIT_COUNT_HEURISTIC entries rather than every other entry; that's
10372 faster and is responsive enough.
10373 (Flength): Report an error instead of overflowing an integer.
10374 (Fsafe_length): Return a float if the value is not representable
10375 as a fixnum. This shouldn't happen except in contrived situations.
10376 (Fnthcdr, Fsort): Don't assume list length fits in int.
10377 (Fcopy_sequence): Don't assume vector length fits in int.
10379 * alloc.c: Check that resized vectors' lengths fit in fixnums.
10380 (header_size, word_size): New constants.
10381 (allocate_vectorlike): Don't check size overflow here.
10382 (allocate_vector): Check it here instead, since this is the only
10383 caller of allocate_vectorlike that could cause overflow.
10384 Check that the new vector's length is representable as a fixnum.
10386 * fns.c (next_almost_prime): Don't return a multiple of 3 or 5.
10387 The previous code was bogus. For example, next_almost_prime (32)
10388 returned 39, which is undesirable as it is a multiple of 3; and
10389 next_almost_prime (24) returned 25, which is a multiple of 5 so
10390 why was the code bothering to check for multiples of 7?
10392 * bytecode.c (exec_byte_code): Use ptrdiff_t, not int, for vector length.
10394 * eval.c, doprnt.c (SIZE_MAX): Remove; inttypes.h defines this now.
10396 Variadic C functions now count arguments with ptrdiff_t.
10397 This partly undoes my 2011-03-30 change, which replaced int with size_t.
10398 Back then I didn't know that the Emacs coding style prefers signed int.
10399 Also, in the meantime I found a few more instances where arguments
10400 were being counted with int, which may truncate counts on 64-bit
10401 machines, or EMACS_INT, which may be unnecessarily wide.
10402 * lisp.h (struct Lisp_Subr.function.aMANY)
10403 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call):
10404 Arg counts are now ptrdiff_t, not size_t.
10405 All variadic functions and their callers changed accordingly.
10406 (struct gcpro.nvars): Now size_t, not size_t. All uses changed.
10407 * bytecode.c (exec_byte_code): Check maxdepth for overflow,
10408 to avoid potential buffer overrun. Don't assume arg counts fit in 'int'.
10409 * callint.c (Fcall_interactively): Check arg count for overflow,
10410 to avoid potential buffer overrun. Use signed char, not 'int',
10411 for 'varies' array, so that we needn't bother to check its size
10412 calculation for overflow.
10413 * editfns.c (Fformat): Use ptrdiff_t, not EMACS_INT, to count args.
10414 * eval.c (apply_lambda):
10415 * fns.c (Fmapconcat): Use XFASTINT, not XINT, to get args length.
10416 (struct textprop_rec.argnum): Now ptrdiff_t, not int. All uses changed.
10417 (mapconcat): Use ptrdiff_t, not int and EMACS_INT, to count args.
10419 * callint.c (Fcall_interactively): Don't use index var as event count.
10421 * vm-limit.c (check_memory_limits): Fix incorrect extern function decls.
10422 * mem-limits.h (SIZE): Remove; no longer used.
10424 * xterm.c (x_alloc_nearest_color_1): Prefer int to long when int works.
10426 Remove unnecessary casts.
10427 * xterm.c (x_term_init):
10428 * xfns.c (x_set_border_pixel):
10429 * widget.c (create_frame_gcs): Remove casts to unsigned long etc.
10430 These aren't needed now that we assume ANSI C.
10432 * sound.c (Fplay_sound_internal): Remove cast to unsigned long.
10433 It's more likely to cause problems (due to unsigned overflow)
10436 * dired.c (Ffile_attributes): Don't use 32-bit hack on 64-bit hosts.
10438 * unexelf.c (unexec): Don't assume BSS addr fits in unsigned.
10440 * xterm.c (handle_one_xevent): Omit unnecessary casts to unsigned.
10442 * keyboard.c (modify_event_symbol): Don't limit alist len to UINT_MAX.
10444 * lisp.h (CHAR_TABLE_SET): Omit now-redundant test.
10446 * lread.c (Fload): Don't compare a possibly-garbage time_t value.
10448 GLYPH_CODE_FACE returns EMACS_INT, not int.
10449 * dispextern.h (merge_faces):
10450 * xfaces.c (merge_faces):
10451 * xdisp.c (get_next_display_element, next_element_from_display_vector):
10452 Don't assume EMACS_INT fits in int.
10454 * character.h (CHAR_VALID_P): Remove unused parameter.
10455 * fontset.c, lisp.h, xdisp.c: All uses changed.
10457 * editfns.c (Ftranslate_region_internal): Omit redundant test.
10459 * fns.c (concat): Minor tuning based on overflow analysis.
10460 This doesn't fix any bugs. Use int to hold character, instead
10461 of constantly refetching from Emacs object. Use XFASTINT, not
10462 XINT, for value known to be a character. Don't bother comparing
10463 a single byte to 0400, as it's always less.
10465 * floatfns.c (Fexpt):
10466 * fileio.c (make_temp_name): Omit unnecessary cast to unsigned.
10468 * editfns.c (Ftranslate_region_internal): Use int, not EMACS_INT
10471 * doc.c (get_doc_string): Omit (unsigned)c that mishandled negatives.
10473 * data.c (Faset): If ARRAY is a string, check that NEWELT is a char.
10474 Without this fix, on a 64-bit host (aset S 0 4294967386) would
10475 incorrectly succeed when S was a string, because 4294967386 was
10476 truncated before it was used.
10478 * chartab.c (Fchar_table_range): Use CHARACTERP to check range.
10479 Otherwise, an out-of-range integer could cause undefined behavior
10482 * composite.c: Use int, not EMACS_INT, for characters.
10483 (fill_gstring_body, composition_compute_stop_pos): Use int, not
10484 EMACS_INT, for values that are known to be in character range.
10485 This doesn't fix any bugs but is the usual style inside Emacs and
10486 may generate better code on 32-bit machines.
10488 Make sure a 64-bit char is never passed to ENCODE_CHAR.
10489 This is for reasons similar to the recent CHAR_STRING fix.
10490 * charset.c (Fencode_char): Check that character arg is actually
10491 a character. Pass an int to ENCODE_CHAR.
10492 * charset.h (ENCODE_CHAR): Verify that the character argument is no
10493 wider than 'int', as a compile-time check to prevent future regressions
10496 * character.c (char_string): Remove unnecessary casts.
10498 Make sure a 64-bit char is never passed to CHAR_STRING.
10499 Otherwise, CHAR_STRING would do the wrong thing on a 64-bit platform,
10500 by silently ignoring the top 32 bits, allowing some values
10501 that were far too large to be valid characters.
10502 * character.h: Include <verify.h>.
10503 (CHAR_STRING, CHAR_STRING_ADVANCE): Verify that the character
10504 arguments are no wider than unsigned, as a compile-time check
10505 to prevent future regressions in this area.
10507 * editfns.c (Fchar_to_string, general_insert_function, Finsert_char)
10508 (Fsubst_char_in_region):
10510 * xdisp.c (decode_mode_spec_coding):
10511 Adjust to CHAR_STRING's new requirement.
10512 * editfns.c (Finsert_char, Fsubst_char_in_region):
10513 * fns.c (concat): Check that character args are actually
10514 characters. Without this test, these functions did the wrong
10515 thing with wildly out-of-range values on 64-bit hosts.
10517 Remove incorrect casts to 'unsigned' that lose info on 64-bit hosts.
10518 These casts should not be needed on 32-bit hosts, either.
10519 * keyboard.c (read_char):
10520 * lread.c (Fload): Remove casts to unsigned.
10522 * lisp.h (UNSIGNED_CMP): New macro.
10523 This fixes comparison bugs on 64-bit hosts.
10524 (ASCII_CHAR_P): Use it.
10525 * casefiddle.c (casify_object):
10526 * character.h (ASCII_BYTE_P, CHAR_VALID_P)
10527 (SINGLE_BYTE_CHAR_P, CHAR_STRING):
10528 * composite.h (COMPOSITION_ENCODE_RULE_VALID):
10529 * dispextern.h (FACE_FROM_ID):
10530 * keyboard.c (read_char): Use UNSIGNED_CMP.
10532 * xmenu.c (dialog_selection_callback) [!USE_GTK]: Cast to intptr_t,
10533 not to EMACS_INT, to avoid GCC warning.
10535 * xfns.c (x_set_scroll_bar_default_width): Remove unused 'int' locals.
10537 * buffer.h (PTR_BYTE_POS, BUF_PTR_BYTE_POS): Remove harmful cast.
10538 The cast incorrectly truncated 64-bit byte offsets to 32 bits, and
10539 isn't needed on 32-bit machines.
10541 * buffer.c (Fgenerate_new_buffer_name):
10542 Use EMACS_INT for count, not int.
10543 (advance_to_char_boundary): Return EMACS_INT, not int.
10545 * data.c (Qcompiled_function): Now static.
10547 * window.c (window_body_lines): Now static.
10549 * image.c (gif_load): Rename local to avoid shadowing.
10551 * lisp.h (SAFE_ALLOCA_LISP): Check for integer overflow.
10552 (struct Lisp_Save_Value): Use ptrdiff_t, not int, for 'integer' member.
10553 * alloc.c (make_save_value): Integer argument is now of type
10554 ptrdiff_t, not int.
10555 (mark_object): Use ptrdiff_t, not int.
10556 * lisp.h (pD): New macro.
10557 * print.c (print_object): Use it.
10559 * alloc.c: Use EMACS_INT, not int, to count objects.
10560 (total_conses, total_markers, total_symbols, total_vector_size)
10561 (total_free_conses, total_free_markers, total_free_symbols)
10562 (total_free_floats, total_floats, total_free_intervals)
10563 (total_intervals, total_strings, total_free_strings):
10564 Now EMACS_INT, not int. All uses changed.
10565 (Fgarbage_collect): Compute overall total using a double, so that
10566 integer overflow is less likely to be a problem. Check for overflow
10567 when converting back to an integer.
10568 (n_interval_blocks, n_string_blocks, n_float_blocks, n_cons_blocks)
10569 (n_vectors, n_symbol_blocks, n_marker_blocks): Remove.
10570 These were 'int' variables that could overflow on 64-bit hosts;
10571 they were never used, so remove them instead of repairing them.
10572 (nzombies, ngcs, max_live, max_zombies): Now EMACS_INT, not 'int'.
10573 (inhibit_garbage_collection): Set gc_cons_threshold to max value.
10574 Previously, this ceilinged at INT_MAX, but that doesn't work on
10576 (allocate_pseudovector): Don't use EMACS_INT when int would do.
10578 * alloc.c (Fmake_bool_vector): Don't assume vector size fits in int.
10579 (allocate_vectorlike): Check for ptrdiff_t overflow.
10580 (mark_vectorlike, mark_char_table, mark_object): Avoid EMACS_UINT
10581 when a (possibly-narrower) signed value would do just as well.
10582 We prefer using signed arithmetic, to avoid comparison confusion.
10584 * alloc.c: Catch some string size overflows that we were missing.
10585 (XMALLOC_OVERRUN_CHECK_SIZE) [!XMALLOC_OVERRUN_CHECK]: Define to 0,
10586 for convenience in STRING_BYTES_MAX.
10587 (STRING_BYTES_MAX): New macro, superseding the old one in lisp.h.
10588 The definition here is exact; the one in lisp.h was approximate.
10589 (allocate_string_data): Check for string overflow. This catches
10590 some instances we weren't catching before. Also, it catches
10591 size_t overflow on (unusual) hosts where SIZE_MAX <= min
10592 (PTRDIFF_MAX, MOST_POSITIVE_FIXNUM), e.g., when size_t is 32 bits
10593 and ptrdiff_t and EMACS_INT are both 64 bits.
10595 * character.c, coding.c, doprnt.c, editfns.c, eval.c:
10596 All uses of STRING_BYTES_MAX replaced by STRING_BYTES_BOUND.
10597 * lisp.h (STRING_BYTES_BOUND): Rename from STRING_BYTES_MAX.
10599 * character.c (string_escape_byte8): Fix nbytes/nchars typo.
10601 * alloc.c (Fmake_string): Check for out-of-range init.
10603 2011-06-15 Stefan Monnier <monnier@iro.umontreal.ca>
10605 * eval.c (Fdefvaralias): Also mark the target as variable-special-p.
10607 2011-06-14 Jan Djärv <jan.h.d@swipnet.se>
10609 * xfns.c (x_set_scroll_bar_default_width): Remove argument to
10610 xg_get_default_scrollbar_width.
10612 * gtkutil.c: Include emacsgtkfixed.h if HAVE_GTK3.
10613 (int_gtk_range_get_value): Move to the scroll bar part of the file.
10614 (style_changed_cb): Call update_theme_scrollbar_width and call
10615 x_set_scroll_bar_default_width and xg_frame_set_char_size for
10616 all frames (Bug#8505).
10617 (xg_create_frame_widgets): Call emacs_fixed_new if HAVE_GTK3 (Bug#8505).
10618 Call gtk_window_set_resizable if HAVE_GTK3.
10619 (x_wm_set_size_hint): Call emacs_fixed_set_min_size with min width
10620 and height if HAVE_GTK3 (Bug#8505).
10621 (scroll_bar_width_for_theme): New variable.
10622 (update_theme_scrollbar_width): New function.
10623 (xg_get_default_scrollbar_width): Move code to
10624 update_theme_scrollbar_width, just return scroll_bar_width_for_theme.
10625 (xg_initialize): Call update_theme_scrollbar_width.
10627 * gtkutil.h (xg_get_default_scrollbar_width): Remove argument.
10629 * emacsgtkfixed.c, emacsgtkfixed.h: New files.
10631 2011-06-12 Martin Rudalics <rudalics@gmx.at>
10633 * frame.c (make_frame): Call other_buffer_safely instead of
10636 * window.c (temp_output_buffer_show): Call display_buffer with
10637 second argument Vtemp_buffer_show_specifiers and reset latter
10638 immediately after the call.
10639 (Vtemp_buffer_show_specifiers): New variable.
10640 (auto_window_vscroll_p, next_screen_context_lines)
10641 (Vscroll_preserve_screen_position): Remove leading asterisks from
10644 2011-06-12 Paul Eggert <eggert@cs.ucla.edu>
10646 Fix minor problems found by GCC 4.6.0 static checking.
10647 * buffer.c (Qclone_number): Remove for now, as it's unused.
10648 (record_buffer, Funrecord_buffer): Rename local to avoid shadowing.
10649 (record_buffer): Remove unused local.
10650 * frame.c (other_visible_frames, frame_buffer_list): Now static.
10651 (set_frame_buffer_list): Remove; unused.
10652 * frame.h (other_visible_frames): Remove decl.
10653 * keyboard.h (menu_items_inuse): Declare only if USE_GTK || USE_MOTIF.
10654 * lisp.h (frame_buffer_list, set_frame_buffer_list): Remove decls.
10655 (add_gpm_wait_descriptor, delete_gpm_wait_descriptor): Declare only
10657 * menu.c (menu_items_inuse): Now static unless USE_GTK || USE_MOTIF.
10658 * process.c (add_gpm_wait_descriptor, delete_gpm_wait_descriptor):
10659 Define only if HAVE_GPM.
10660 * widget.c (EmacsFrameResize, emacsFrameClassRec): Now static.
10661 (update_hints_inhibit): Remove; never set. All uses removed.
10662 * widgetprv.h (emacsFrameClassRec): Remove decl.
10663 * window.c (delete_deletable_window): Now returns void, since it
10664 wasn't returning anything.
10665 (compare_window_configurations): Remove unused locals.
10666 * xfns.c (x_set_scroll_bar_default_width): Remove unused locals.
10667 * xmenu.c (x_menu_set_in_use): Define only if USE_GTK || USE_MOTIF.
10668 (dialog_selection_callback) [!USE_GTK]: Prefer intptr_t for integers
10669 the same widths as pointers. This follows up on the 2011-05-06 patch.
10670 * xterm.c (x_alloc_lighter_color_for_widget): Define only if USE_LUCID.
10671 * xterm.h: Likewise.
10672 (x_menu_set_in_use): Declare only if USE_GTK || USE_MOTIF.
10674 2011-06-12 Juanma Barranquero <lekktu@gmail.com>
10676 * makefile.w32-in: Update dependencies.
10677 (LISP_H): Add lib/intprops.h.
10679 2011-06-11 Chong Yidong <cyd@stupidchicken.com>
10681 * image.c (gif_load): Add animation frame delay to the metadata.
10682 (syms_of_image): Use DEFSYM. New symbol `delay'.
10684 2011-06-11 Martin Rudalics <rudalics@gmx.at>
10686 * window.c (delete_deletable_window): Re-add.
10687 (Fset_window_configuration): Rewrite to handle dead buffers and
10688 consequently deletable windows.
10689 (window_tree, Fwindow_tree): Remove. Supply functionality in
10691 (compare_window_configurations): Simplify code.
10693 2011-06-11 Andreas Schwab <schwab@linux-m68k.org>
10695 * image.c (imagemagick_load_image): Fix type mismatch.
10696 (Fimagemagick_types): Likewise.
10698 * window.h (replace_buffer_in_windows): Declare.
10700 2011-06-11 Martin Rudalics <rudalics@gmx.at>
10702 * buffer.c: New Lisp objects Qbuffer_list_update_hook and
10703 Qclone_number. Remove external declaration of Qdelete_window.
10704 (Fbuffer_list): Rewrite doc-string. Minor restructuring of
10706 (Fget_buffer_create, Fmake_indirect_buffer, Frename_buffer):
10707 Run Qbuffer_list_update_hook if allowed.
10708 (Fother_buffer): Rewrite doc-string. Major rewrite for new
10709 buffer list implementation.
10710 (other_buffer_safely): New function.
10711 (Fkill_buffer): Replace call to replace_buffer_in_all_windows by
10712 calls to replace_buffer_in_windows and
10713 replace_buffer_in_windows_safely. Run Qbuffer_list_update_hook
10715 (record_buffer): Inhibit quitting and rewrite using quittable
10716 functions. Run Qbuffer_list_update_hook if allowed.
10717 (Frecord_buffer, Funrecord_buffer): New functions.
10718 (switch_to_buffer_1, Fswitch_to_buffer): Remove.
10719 Move switch-to-buffer to window.el.
10720 (bury-buffer): Move to window.el.
10721 (Vbuffer_list_update_hook): New variable.
10723 * lisp.h (other_buffer_safely): Add prototype in buffer.c
10726 * window.h (resize_frame_windows): Move up in code.
10727 (Fwindow_frame): Remove EXFUN.
10728 (replace_buffer_in_all_windows): Remove prototype.
10729 (replace_buffer_in_windows_safely): Add prototype.
10731 * window.c: Declare Qdelete_window static again. Move down
10732 declaration of select_count.
10733 (Fnext_window, Fprevious_window): Rewrite doc-strings.
10734 (Fother_window): Move to window.el.
10735 (window_loop): Remove DELETE_BUFFER_WINDOWS and UNSHOW_BUFFER
10736 cases. Add REPLACE_BUFFER_IN_WINDOWS_SAFELY case.
10737 (Fdelete_windows_on, Freplace_buffer_in_windows): Move to
10739 (replace_buffer_in_windows): Implement by calling
10740 Qreplace_buffer_in_windows.
10741 (replace_buffer_in_all_windows): Remove with some functionality
10742 moved into replace_buffer_in_windows_safely.
10743 (replace_buffer_in_windows_safely): New function.
10744 (select_window_norecord, select_frame_norecord): Move in front
10745 of run_window_configuration_change_hook. Remove now obsolete
10747 (Fset_window_buffer): Rewrite doc-string.
10748 Call Qrecord_window_buffer.
10749 (keys_of_window): Move binding for other-window to window.el.
10751 2011-06-11 Chong Yidong <cyd@stupidchicken.com>
10753 * dispextern.h (struct image): Replace data member, whose int_val
10754 and ptr_val fields were not used by anything, with a single
10757 * image.c (Fimage_metadata, make_image, mark_image, tiff_load)
10758 (gif_clear_image, gif_load, imagemagick_load_image)
10759 (gs_clear_image, gs_load): Callers changed.
10761 2011-06-10 Paul Eggert <eggert@cs.ucla.edu>
10763 * buffer.h: Include <time.h>, for time_t.
10764 Needed to build on FreeBSD 8.2. Problem reported by Herbert J. Skuhra.
10766 Fix minor problems found by static checking.
10768 * image.c (PixelGetMagickColor): Declare if ImageMagick headers don't.
10770 Make identifiers static if they are not used in other modules.
10771 * data.c (Qcompiled_function, Qframe, Qvector):
10772 * image.c (QimageMagick, Qsvg):
10773 * minibuf.c (Qmetadata):
10774 * window.c (resize_window_check, resize_root_window): Now static.
10775 * window.h (resize_window_check, resize_root_window): Remove decls.
10777 * window.c (window_deletion_count, delete_deletable_window):
10779 (window_body_lines): Now static.
10780 (Fdelete_other_windows_internal): Mark vars as initialized.
10781 Make sure 'resize_failed' is initialized.
10782 (run_window_configuration_change_hook): Rename local to avoid shadowing.
10783 (resize_window_apply): Remove unused local.
10784 * window.h (delete_deletable_window): Remove decl.
10786 * image.c (gif_load, svg_load_image): Rename locals to avoid shadowing.
10787 (imagemagick_load_image): Fix pointer signedness problem by changing
10788 last arg from unsigned char * to char *. All uses changed.
10789 Also, fix a local for similar reasons.
10790 Remove unused locals. Remove locals to avoid shadowing.
10791 (fn_rsvg_handle_free): Remove; unused.
10792 (svg_load, svg_load_image): Fix pointer signedness problem.
10793 (imagemagick_load_image): Don't use garbage pointer image_wand.
10795 * ftfont.c (ftfont_get_metrics, ftfont_drive_otf): Remove unused locals.
10797 2011-06-10 Chong Yidong <cyd@stupidchicken.com>
10799 * image.c (gif_load): Fix omitted cast error introduced by
10802 2011-06-10 Martin Rudalics <rudalics@gmx.at>
10804 * window.h (resize_proportionally, orig_total_lines)
10805 (orig_top_line): Remove from window structure.
10806 (set_window_height, set_window_width, change_window_heights)
10807 (Fdelete_window): Remove prototypes.
10808 (resize_frame_windows): Remove duplicate declaration.
10810 2011-06-10 Eli Zaretskii <eliz@gnu.org>
10812 * window.h (resize_frame_windows, resize_window_check)
10813 (delete_deletable_window, resize_root_window)
10814 (resize_frame_windows): Declare prototypes.
10816 * window.c (resize_window_apply): Make definition be "static" to
10817 match the prototype.
10819 2011-06-10 Martin Rudalics <rudalics@gmx.at>
10821 * window.c: Remove declarations of Qwindow_size_fixed,
10822 window_min_size_1, window_min_size_2, window_min_size,
10823 size_window, window_fixed_size_p, enlarge_window, delete_window.
10824 Remove static from declaration of Qdelete_window, it's
10825 temporarily needed by Fbury_buffer.
10826 (replace_window): Don't assign orig_top_line and
10828 (Fdelete_window, delete_window): Remove. Window deletion is
10829 handled by window.el.
10830 (window_loop): Remove DELETE_OTHER_WINDOWS case.
10831 Replace Fdelete_window calls with calls to Qdelete_window.
10832 (Fdelete_other_windows): Remove. Deleting other windows is
10833 handled by window.el.
10834 (window_fixed_size_p): Remove. Fixed-sizeness of windows is
10835 handled in window.el.
10836 (window_min_size_2, window_min_size_1, window_min_size): Remove.
10837 Window minimum sizes are handled in window.el.
10838 (shrink_windows, size_window, set_window_height)
10839 (set_window_width, change_window_heights, window_height)
10840 (window_width, CURBEG, CURSIZE, enlarge_window)
10841 (adjust_window_trailing_edge, Fadjust_window_trailing_edge)
10842 (Fenlarge_window, Fshrink_window): Remove. Window resizing is
10843 handled in window.el.
10844 (make_dummy_parent): Rename to make_parent_window and give it a
10845 second argument horflag.
10846 (make_window): Don't set resize_proportionally any more.
10847 (Fsplit_window): Remove. Windows are split in window.el.
10848 (save_restore_action, save_restore_orig_size)
10849 (shrink_window_lowest_first, save_restore_orig_size): Remove.
10850 Resize mini windows in window.el.
10851 (grow_mini_window, shrink_mini_window): Implement by calling
10852 Qresize_root_window_vertically, resize_window_check and
10853 resize_window_apply.
10854 (saved_window, Fset_window_configuration, save_window_save):
10855 Do not handle orig_top_line, orig_total_lines, and
10856 resize_proportionally.
10857 (window_min_height, window_min_width): Move to window.el.
10858 (keys_of_window): Move bindings for delete-other-windows,
10859 split-window, delete-window and enlarge-window to window.el.
10861 * buffer.c: Temporarily extern Qdelete_window.
10862 (Fbury_buffer): Temporarily call Qdelete_window instead of
10863 Fdelete_window (Fbury_buffer will move to window.el soon).
10865 * frame.c (set_menu_bar_lines_1): Remove code handling
10866 orig_top_line and orig_total_lines.
10868 * dispnew.c (adjust_frame_glyphs_initially): Don't use
10869 set_window_height but set heights directly.
10870 (change_frame_size_1): Use resize_frame_windows.
10872 * xdisp.c (init_xdisp): Don't use set_window_height but set
10875 * xfns.c (x_set_menu_bar_lines, x_set_tool_bar_lines):
10876 Use resize_frame_windows instead of change_window_heights and run
10877 run_window_configuration_change_hook.
10879 * w32fns.c (x_set_tool_bar_lines): Use resize_frame_windows
10880 instead of change_window_heights and run
10881 run_window_configuration_change_hook.
10883 2011-06-09 Martin Rudalics <rudalics@gmx.at>
10885 * window.c (replace_window): Rename second argument REPLACEMENT to
10886 NEW. New third argument SETFLAG. Rewrite.
10887 (delete_window, make_dummy_parent): Call replace_window with
10889 (window_list_1): Move down in code.
10890 (run_window_configuration_change_hook): Move set_buffer part
10891 before select_frame_norecord part in order to unwind correctly.
10892 Rename count1 to count.
10893 (recombine_windows, delete_deletable_window, resize_root_window)
10894 (Fdelete_other_windows_internal)
10895 (Frun_window_configuration_change_hook, make_parent_window)
10896 (resize_window_check, resize_window_apply, Fresize_window_apply)
10897 (resize_frame_windows, Fsplit_window_internal)
10898 (Fdelete_window_internal, Fresize_mini_window_internal):
10900 (syms_of_window): New variables Vwindow_splits and Vwindow_nest.
10902 2011-06-08 Martin Rudalics <rudalics@gmx.at>
10904 * window.h (window): Add some new members to window structure -
10905 normal_lines, normal_cols, new_total, new_normal, clone_number,
10906 splits, nest, prev_buffers, next_buffers.
10907 (WINDOW_TOTAL_SIZE): Move here from window.c.
10908 (MIN_SAFE_WINDOW_WIDTH, MIN_SAFE_WINDOW_HEIGHT): Define here.
10910 * window.c (Fwindow_height, Fwindow_width, Fwindow_full_width_p):
10912 (make_dummy_parent): Set new members of windows structure.
10913 (make_window): Move down in code. Handle new members of window
10915 (Fwindow_clone_number, Fwindow_splits, Fset_window_splits)
10916 (Fwindow_nest, Fset_window_nest, Fwindow_new_total)
10917 (Fwindow_normal_size, Fwindow_new_normal, Fwindow_prev_buffers)
10918 (Fset_window_prev_buffers, Fwindow_next_buffers)
10919 (Fset_window_next_buffers, Fset_window_clone_number):
10921 (Fwindow_hscroll, Fwindow_at, Fwindow_point, Fwindow_start)
10922 (Fwindow_end, Fwindow_line_height, Fset_window_dedicated_p):
10924 (Fwindow_parameters, Fwindow_parameter, Fset_window_parameter):
10925 Argument WINDOW can be now internal window too.
10926 (Fwindow_use_time): Move up in code.
10927 (Fget_buffer_window): Rename argument FRAME to ALL-FRAMES.
10928 Rewrite doc-string.
10929 (Fset_window_configuration, saved_window)
10930 (Fcurrent_window_configuration, save_window_save): Handle new
10931 members of window structure.
10932 (WINDOW_TOTAL_SIZE, MIN_SAFE_WINDOW_WIDTH)
10933 (MIN_SAFE_WINDOW_HEIGHT): Move to window.h.
10934 (syms_of_window): New Lisp objects Qrecord_window_buffer,
10935 Qwindow_deletable_p, Qdelete_window, Qreplace_buffer_in_windows,
10936 Qget_mru_window, Qresize_root_window,
10937 Qresize_root_window_vertically, Qsafe, Qabove, Qbelow,
10938 Qauto_buffer_name; staticpro them.
10940 2011-06-07 Martin Rudalics <rudalics@gmx.at>
10942 * window.c (Fwindow_total_size, Fwindow_left_column)
10943 (Fwindow_top_line, window_body_lines, Fwindow_body_size)
10944 (Fwindow_list_1): New functions.
10945 (window_box_text_cols): Replace with window_body_cols.
10946 (Fwindow_width, Fscroll_left, Fscroll_right):
10947 Use window_body_cols instead of window_box_text_cols.
10948 (delete_window, Fset_window_configuration):
10949 Call delete_all_subwindows with window as argument.
10950 (delete_all_subwindows): Take a window as argument and not a
10951 structure. Rewrite.
10952 (window_loop): Remove handling of GET_LRU_WINDOW and
10953 GET_LARGEST_WINDOW.
10954 (Fget_lru_window, Fget_largest_window): Move to window.el.
10956 * window.h: Extern window_body_cols instead of
10957 window_box_text_cols. delete_all_subwindows now takes a
10958 Lisp_Object as argument.
10960 * indent.c (compute_motion, Fcompute_motion):
10961 Use window_body_cols instead of window_box_text_cols.
10963 * frame.c (delete_frame): Call delete_all_subwindows with root
10964 window as argument.
10966 2011-06-07 Daniel Colascione <dan.colascione@gmail.com>
10968 * fns.c (Fputhash): Document return value.
10970 2011-06-06 Chong Yidong <cyd@stupidchicken.com>
10972 * image.c (gif_load): Implement gif89a spec "no disposal" method.
10974 2011-06-06 Paul Eggert <eggert@cs.ucla.edu>
10976 Cons<->int and similar integer overflow fixes (Bug#8794).
10978 Check for overflow when converting integer to cons and back.
10979 * charset.c (Fdefine_charset_internal, Fdecode_char):
10980 Use cons_to_unsigned to catch overflow.
10981 (Fencode_char): Use INTEGER_TO_CONS.
10982 * composite.h (LGLYPH_CODE): Use cons_to_unsigned.
10983 (LGLYPH_SET_CODE): Use INTEGER_TO_CONS.
10984 * data.c (long_to_cons, cons_to_long): Remove.
10985 (cons_to_unsigned, cons_to_signed): New functions.
10986 These signal an error for invalid or out-of-range values.
10987 * dired.c (Ffile_attributes): Use INTEGER_TO_CONS.
10988 * fileio.c (Fset_visited_file_modtime): Use CONS_TO_INTEGER.
10989 * font.c (Ffont_variation_glyphs):
10990 * fontset.c (Finternal_char_font): Use INTEGER_TO_CONS.
10991 * lisp.h: Include <intprops.h>.
10992 (INTEGER_TO_CONS, CONS_TO_INTEGER): New macros.
10993 (cons_to_signed, cons_to_unsigned): New decls.
10994 (long_to_cons, cons_to_long): Remove decls.
10995 * undo.c (record_first_change): Use INTEGER_TO_CONS.
10996 (Fprimitive_undo): Use CONS_TO_INTEGER.
10997 * xfns.c (Fx_window_property): Likewise.
10998 * xselect.c: Include <limits.h>.
10999 (x_own_selection, selection_data_to_lisp_data):
11000 Use INTEGER_TO_CONS.
11001 (x_handle_selection_request, x_handle_selection_clear)
11002 (x_get_foreign_selection, Fx_disown_selection_internal)
11003 (Fx_get_atom_name, x_send_client_event): Use CONS_TO_INTEGER.
11004 (lisp_data_to_selection_data): Use cons_to_unsigned.
11005 (x_fill_property_data): Use cons_to_signed.
11006 Report values out of range.
11008 Check for buffer and string overflow more precisely.
11009 * buffer.h (BUF_BYTES_MAX): New macro.
11010 * lisp.h (STRING_BYTES_MAX): New macro.
11011 * alloc.c (Fmake_string):
11012 * character.c (string_escape_byte8):
11013 * coding.c (coding_alloc_by_realloc):
11014 * doprnt.c (doprnt):
11015 * editfns.c (Fformat):
11017 Use STRING_BYTES_MAX, not MOST_POSITIVE_FIXNUM,
11018 since they may not be the same number.
11019 * editfns.c (Finsert_char):
11020 * fileio.c (Finsert_file_contents):
11021 Likewise for BUF_BYTES_MAX.
11023 * image.c: Use ptrdiff_t, not int, for sizes.
11024 (slurp_file): Switch from int to ptrdiff_t.
11026 (slurp_file): Check that file size fits in both size_t (for
11027 malloc) and ptrdiff_t (for sanity and safety).
11029 * fileio.c (Fverify_visited_file_modtime): Avoid time overflow
11030 if b->modtime has its maximal value.
11032 * dired.c (Ffile_attributes): Don't assume EMACS_INT has >32 bits.
11034 Don't assume time_t can fit into int.
11035 * buffer.h (struct buffer.modtime): Now time_t, not int.
11036 * fileio.c (Fvisited_file_modtime): No need for time_t cast now.
11037 * undo.c (Fprimitive_undo): Use time_t, not int, for time_t value.
11039 Minor fixes for signed vs unsigned integers.
11040 * character.h (MAYBE_UNIFY_CHAR):
11041 * charset.c (maybe_unify_char):
11042 * keyboard.c (read_char, reorder_modifiers):
11043 XINT -> XFASTINT, since the integer must be nonnegative.
11044 * ftfont.c (ftfont_spec_pattern):
11045 * keymap.c (access_keymap, silly_event_symbol_error):
11046 XUINT -> XFASTINT, since the integer must be nonnegative.
11047 (Fsingle_key_description, preferred_sequence_p): XUINT -> XINT,
11048 since it makes no difference and we prefer signed.
11049 * keyboard.c (record_char): Use XUINT when all the neighbors do.
11050 (access_keymap): NATNUMP -> INTEGERP, since the integer must be
11053 2011-06-06 Stefan Monnier <monnier@iro.umontreal.ca>
11055 * window.h (Fwindow_frame): Declare.
11057 2011-06-06 Paul Eggert <eggert@cs.ucla.edu>
11059 * alloc.c: Simplify handling of large-request failures (Bug#8800).
11060 (SPARE_MEMORY): Always define.
11061 (LARGE_REQUEST): Remove.
11062 (memory_full): Use SPARE_MEMORY rather than LARGE_REQUEST.
11064 2011-06-06 Martin Rudalics <rudalics@gmx.at>
11066 * lisp.h: Move EXFUNS for Fframe_root_window,
11067 Fframe_first_window and Fset_frame_selected_window to window.h.
11069 * window.h: Move EXFUNS for Fframe_root_window,
11070 Fframe_first_window and Fset_frame_selected_window here from
11073 * frame.c (Fwindow_frame, Fframe_first_window)
11074 (Fframe_root_window, Fframe_selected_window)
11075 (Fset_frame_selected_window): Move to window.c.
11076 (Factive_minibuffer_window): Move to minibuf.c.
11077 (Fother_visible_frames_p): New function.
11079 * minibuf.c (Factive_minibuffer_window): Move here from frame.c.
11081 * window.c (decode_window, decode_any_window): Move up in code.
11082 (Fwindowp, Fwindow_live_p): Rewrite doc-strings.
11083 (inhibit_frame_unsplittable): Remove unused variable.
11084 (Fwindow_buffer): Move up and rewrite doc-string.
11085 (Fwindow_parent, Fwindow_vchild, Fwindow_hchild, Fwindow_next)
11086 (Fwindow_prev): New functions.
11087 (Fwindow_frame): Move here from frame.c. Accept any window as
11089 (Fframe_root_window, Fframe_first_window)
11090 (Fframe_selected_window): Move here from frame.c. Accept frame
11091 or arbitrary window as argument. Update doc-strings.
11092 (Fminibuffer_window): Move up in code.
11093 (Fwindow_minibuffer_p): Move up in code and simplify.
11094 (Fset_frame_selected_window): Move here from frame.c.
11096 (Fselected_window, select_window, Fselect_window): Move up in
11097 code. Minor doc-string fixes.
11099 2011-06-06 Paul Eggert <eggert@cs.ucla.edu>
11101 * alloc.c (memory_full) [SYSTEM_MALLOC]: Port to MacOS (Bug#8800).
11102 Do not assume that spare memory exists; that assumption is valid
11103 only if SYSTEM_MALLOC.
11104 (LARGE_REQUEST): New macro, so that the issue of large requests
11105 is separated from the issue of spare memory.
11107 2011-06-05 Andreas Schwab <schwab@linux-m68k.org>
11109 * editfns.c (Fformat): Correctly handle zero flag with hexadecimal
11112 * gtkutil.c (xg_get_default_scrollbar_width): Avoid warning.
11114 * xfns.c (x_set_scroll_bar_default_width): Move declarations
11117 2011-06-05 Jan Djärv <jan.h.d@swipnet.se>
11119 * gtkutil.c (xg_get_default_scrollbar_width): New function.
11121 * gtkutil.h: Declare xg_get_default_scrollbar_width.
11123 * xfns.c (x_set_scroll_bar_default_width): If USE_GTK, get
11124 min width by calling x_set_scroll_bar_default_width (Bug#8505).
11126 2011-06-05 Juanma Barranquero <lekktu@gmail.com>
11128 * xdisp.c (single_display_spec_intangible_p): Remove declaration.
11130 2011-06-04 Chong Yidong <cyd@stupidchicken.com>
11132 * xselect.c (x_clipboard_manager_save): Remove redundant arg.
11133 (x_clipboard_manager_save): Add return value.
11134 (x_clipboard_manager_error_1, x_clipboard_manager_error_2):
11135 New error handlers.
11136 (x_clipboard_manager_save_frame, x_clipboard_manager_save_all):
11137 Obey Vx_select_enable_clipboard_manager. Catch errors in
11138 x_clipboard_manager_save (Bug#8779).
11139 (Vx_select_enable_clipboard_manager): New variable.
11140 (x_get_foreign_selection): Reduce scope of x_catch_errors (Bug#8790).
11142 2011-06-04 Dan Nicolaescu <dann@ics.uci.edu>
11144 * emacs.c (main): Warn when starting a GTK emacs in daemon mode.
11146 2011-06-04 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
11148 * fringe.c (update_window_fringes): Don't update overlay arrow bitmap
11149 in the current matrix if keep_current_p is non-zero.
11151 2011-06-04 Eli Zaretskii <eliz@gnu.org>
11153 * bidi.c (bidi_level_of_next_char): Fix last change.
11155 2011-06-03 Eli Zaretskii <eliz@gnu.org>
11157 Support bidi reordering of text covered by display properties.
11159 * bidi.c (bidi_copy_it): Use offsetof instead of emulating it.
11160 (bidi_fetch_char, bidi_fetch_char_advance): New functions.
11161 (bidi_cache_search, bidi_cache_iterator_state)
11162 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak)
11163 (bidi_level_of_next_char, bidi_move_to_visually_next):
11164 Support character positions inside a run of characters covered by a
11166 (bidi_paragraph_init, bidi_resolve_explicit_1)
11167 (bidi_level_of_next_char): Call bidi_fetch_char and
11168 bidi_fetch_char_advance instead of FETCH_CHAR and
11169 FETCH_CHAR_ADVANCE.
11170 (bidi_init_it): Initialize new members.
11171 (LRE_CHAR, RLE_CHAR, PDF_CHAR, LRO_CHAR, RLO_CHAR): Remove macro
11173 (bidi_explicit_dir_char): Lookup character type in bidi_type_table,
11174 instead of using explicit *_CHAR codes.
11175 (bidi_resolve_explicit, bidi_resolve_weak):
11176 Use FETCH_MULTIBYTE_CHAR instead of FETCH_CHAR, as reordering of
11177 bidirectional text is supported only in multibyte buffers.
11178 (bidi_init_it): Accept additional argument FRAME_WINDOW_P and use
11179 it to initialize the frame_window_p member of struct bidi_it.
11180 (bidi_cache_iterator_state, bidi_resolve_explicit_1)
11181 (bidi_resolve_explicit, bidi_resolve_weak)
11182 (bidi_level_of_next_char, bidi_move_to_visually_next): Abort if
11183 bidi_it->nchars is non-positive.
11184 (bidi_level_of_next_char): Don't try to lookup the cache for the
11185 next/previous character if nothing is cached there yet, or if we
11186 were just reseat()'ed to a new position.
11188 * xdisp.c (set_cursor_from_row): Set start and stop points
11189 according to the row's direction when priming the loop that looks
11190 for the glyph on which to display cursor.
11191 (single_display_spec_intangible_p): Function deleted.
11192 (display_prop_intangible_p): Reimplement to call
11193 handle_display_spec instead of single_display_spec_intangible_p.
11194 Accept 3 additional arguments needed by handle_display_spec.
11195 This fixes incorrect cursor motion across display property with complex
11196 values: lists, `(when COND...)' forms, etc.
11197 (single_display_spec_string_p): Support property values that are
11198 lists with the argument STRING its top-level element.
11199 (display_prop_string_p): Fix the condition for processing a
11200 property that is a list to be consistent with handle_display_spec.
11201 (handle_display_spec): New function, refactored from the
11202 last portion of handle_display_prop.
11203 (compute_display_string_pos): Accept additional argument
11204 FRAME_WINDOW_P. Call handle_display_spec to determine whether the
11205 value of a `display' property is a "replacing spec".
11206 (handle_single_display_spec): Accept 2 additional arguments BUFPOS
11207 and FRAME_WINDOW_P. If IT is NULL, don't set up the iterator from
11208 the display property, but just return a value indicating whether
11209 the display property will replace the characters it covers.
11210 (Fcurrent_bidi_paragraph_direction): Initialize the nchars and
11211 frame_window_p members of struct bidi_it.
11212 (compute_display_string_pos, compute_display_string_end):
11214 (push_it): Accept second argument POSITION, where pop_it should
11215 jump to continue iteration.
11216 (reseat_1): Initialize bidi_it.disp_pos.
11218 * keyboard.c (adjust_point_for_property): Adjust the call to
11219 display_prop_intangible_p to its new signature.
11221 * dispextern.h (struct bidi_it): New member frame_window_p.
11222 (bidi_init_it): Update prototypes.
11223 (display_prop_intangible_p): Update prototype.
11224 (compute_display_string_pos, compute_display_string_end):
11225 Declare prototypes.
11226 (struct bidi_it): New members nchars and disp_pos. ch_len is now
11229 2011-06-02 Paul Eggert <eggert@cs.ucla.edu>
11231 Malloc failure behavior now depends on size of allocation.
11232 * alloc.c (buffer_memory_full, memory_full): New arg NBYTES.
11233 * lisp.h: Change signatures accordingly.
11234 * alloc.c, buffer.c, editfns.c, menu.c, minibuf.c, xterm.c:
11235 All callers changed. (Bug#8762)
11237 * gnutls.c: Use Emacs's memory allocators.
11238 Without this change, the gnutls library would invoke malloc etc.
11239 directly, which causes problems on non-SYNC_INPUT hosts, and which
11240 runs afoul of improving memory_full behavior. (Bug#8761)
11241 (fn_gnutls_global_set_mem_functions): New macro or function pointer.
11242 (emacs_gnutls_global_init): Use it to specify xmalloc, xrealloc,
11243 xfree instead of the default malloc, realloc, free.
11244 (Fgnutls_boot): No need to check for memory allocation failure,
11245 since xmalloc does that for us.
11247 Remove arbitrary limit of 2**31 entries in hash tables. (Bug#8771)
11248 * category.c (hash_get_category_set):
11249 * ccl.c (ccl_driver):
11250 * charset.c (Fdefine_charset_internal):
11251 * charset.h (struct charset.hash_index):
11252 * composite.c (get_composition_id, gstring_lookup_cache)
11253 (composition_gstring_put_cache):
11254 * composite.h (struct composition.hash_index):
11255 * dispextern.h (struct image.hash):
11256 * fns.c (next_almost_prime, larger_vector, cmpfn_eql)
11257 (cmpfn_equal, cmpfn_user_defined, hashfn_eq, hashfn_eql)
11258 (hashfn_equal, hashfn_user_defined, make_hash_table)
11259 (maybe_resize_hash_table, hash_lookup, hash_put)
11260 (hash_remove_from_table, hash_clear, sweep_weak_table, SXHASH_COMBINE)
11261 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector)
11262 (Fsxhash, Fgethash, Fputhash, Fmaphash):
11263 * image.c (make_image, search_image_cache, lookup_image)
11264 (xpm_put_color_table_h):
11265 * lisp.h (struct Lisp_Hash_Table):
11266 * minibuf.c (Ftry_completion, Fall_completions, Ftest_completion):
11267 * print.c (print): Use 'EMACS_UINT' and 'EMACS_INT'
11268 for hashes and hash indexes, instead of 'unsigned' and 'int'.
11269 * alloc.c (allocate_vectorlike):
11270 Check for overflow in vector size calculations.
11271 * ccl.c (ccl_driver):
11272 Check for overflow when converting EMACS_INT to int.
11273 * fns.c, image.c: Remove unnecessary static decls that would otherwise
11274 need to be updated by these changes.
11275 * fns.c (make_hash_table, maybe_resize_hash_table):
11276 Check for integer overflow with large hash tables.
11277 (make_hash_table, maybe_resize_hash_table, Fmake_hash_table):
11278 Prefer the faster XFLOAT_DATA to XFLOATINT where either will do.
11279 (SXHASH_REDUCE): New macro.
11280 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector):
11281 Use it instead of discarding useful hash info with large hash values.
11282 (sxhash_float): New function.
11283 (sxhash): Use it. No more need for "& INTMASK" due to above changes.
11284 * lisp.h (FIXNUM_BITS): New macro, useful for SXHASH_REDUCE etc.
11285 (MOST_NEGATIVE_FIXNUM, MOST_POSITIVE_FIXNUM, INTMASK):
11286 Rewrite to use FIXNUM_BITS, as this simplifies things.
11287 (next_almost_prime, larger_vector, sxhash, hash_lookup, hash_put):
11288 Adjust signatures to match updated version of code.
11289 (consing_since_gc): Now EMACS_INT, since a single hash table can
11290 use more than INT_MAX bytes.
11292 2011-06-01 Dan Nicolaescu <dann@ics.uci.edu>
11294 Make it possible to build with GCC-4.6+ -O2 -flto.
11296 * emacs.c (__malloc_initialize_hook): Mark as EXTERNALLY_VISIBLE.
11298 2011-06-01 Stefan Monnier <monnier@iro.umontreal.ca>
11300 * minibuf.c (get_minibuffer, read_minibuf_unwind):
11301 Call minibuffer-inactive-mode.
11303 2011-05-31 Juanma Barranquero <lekktu@gmail.com>
11305 * makefile.w32-in ($(BLD)/data.$(O), $(BLD)/editfns.$(O)):
11306 Update dependencies.
11308 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
11310 * data.c (init_data): Remove code for UTS, this system is not
11313 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
11315 Don't force ./temacs to start in terminal mode.
11317 * frame.c (make_initial_frame): Initialize faces in all cases, not
11318 only when CANNOT_DUMP is defined.
11319 * dispnew.c (init_display): Remove CANNOT_DUMP condition.
11321 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
11323 * dispnew.c (add_window_display_history): Use const for the string
11324 pointer. Remove declaration, not needed.
11326 2011-05-31 Paul Eggert <eggert@cs.ucla.edu>
11328 Use 'inline', not 'INLINE'.
11329 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00914.html>
11330 * alloc.c, fontset.c (INLINE): Remove.
11331 * alloc.c, bidi.c, charset.c, coding.c, dispnew.c, fns.c, image.c:
11332 * intervals.c, keyboard.c, process.c, syntax.c, textprop.c, w32term.c:
11333 * xdisp.c, xfaces.c, xterm.c: Replace all uses of INLINE with inline.
11334 * gmalloc.c (register_heapinfo): Use inline unconditionally.
11335 * lisp.h (LISP_MAKE_RVALUE): Use inline, not __inline__.
11337 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
11339 Make it possible to run ./temacs.
11341 * callproc.c (set_initial_environment): Remove CANNOT_DUMP code,
11342 syms_of_callproc does the same thing. Remove test for
11343 "initialized", do it in the caller.
11344 * emacs.c (main): Avoid calling set_initial_environment when dumping.
11346 2011-05-31 Stefan Monnier <monnier@iro.umontreal.ca>
11348 * minibuf.c (Finternal_complete_buffer): Return `category' metadata.
11349 (read_minibuf): Use get_minibuffer.
11350 (syms_of_minibuf): Use DEFSYM.
11351 (Qmetadata): New var.
11352 * data.c (Qbuffer): Don't make it static.
11353 (syms_of_data): Use DEFSYM.
11355 2011-05-31 Paul Eggert <eggert@cs.ucla.edu>
11357 * ccl.c (CCL_CODE_RANGE): Allow negative numbers. (Bug#8751)
11358 (CCL_CODE_MIN): New macro.
11360 2011-05-30 Paul Eggert <eggert@cs.ucla.edu>
11362 * alloc.c (lisp_align_malloc): Omit unnecessary val==NULL tests.
11364 * eval.c (Qdebug): Now static.
11365 * lisp.h (Qdebug): Remove decl. This reverts a part of the
11366 2011-04-26T11:26:05Z!dan.colascione@gmail.com that inadvertently undid part of
11367 2011-04-14T06:48:41Z!eggert@cs.ucla.edu.
11369 2011-05-29 Chong Yidong <cyd@stupidchicken.com>
11371 * image.c: Various fixes to ImageMagick code comments.
11372 (Fimagemagick_types): Doc fix.
11374 2011-05-29 Paul Eggert <eggert@cs.ucla.edu>
11376 Minor fixes prompted by GCC 4.6.0 warnings.
11378 * xselect.c (converted_selections, conversion_fail_tag): Now static.
11380 * emacs.c [HAVE_X_WINDOWS]: Include "xterm.h".
11381 (x_clipboard_manager_save_all): Move extern decl to ...
11382 * xterm.h: ... here, so that it can be checked for consistency.
11384 2011-05-29 Chong Yidong <cyd@stupidchicken.com>
11386 * xselect.c (x_clipboard_manager_save_frame)
11387 (x_clipboard_manager_save_all): New functions.
11388 (Fx_clipboard_manager_save): Lisp function deleted.
11390 * emacs.c (Fkill_emacs): Call x_clipboard_manager_save_all.
11391 * frame.c (delete_frame): Call x_clipboard_manager_save_frame.
11393 * xterm.h: Update prototype.
11395 2011-05-28 William Xu <william.xwl@gmail.com>
11397 * nsterm.m (ns_term_shutdown): Synchronize user defaults before
11398 exiting (Bug#8239).
11400 2011-05-28 Jim Meyering <meyering@redhat.com>
11402 Avoid a sign-extension bug in crypto_hash_function.
11403 * fns.c (to_uchar): Define.
11404 (crypto_hash_function): Use it to convert some newly-signed
11405 variables to unsigned, to avoid sign-extension bugs. For example,
11406 without this change, (md5 "truc") would evaluate to
11407 45723a2aff78ff4fff7fff1114760e62 rather than the expected
11408 45723a2af3788c4ff17f8d1114760e62. Reported by Antoine Levitt in
11409 https://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00883.html.
11411 2011-05-27 Paul Eggert <eggert@cs.ucla.edu>
11413 Integer overflow fixes.
11415 * dbusbind.c: Serial number integer overflow fixes.
11416 (CHECK_DBUS_SERIAL_GET_SERIAL): New macro.
11417 (Fdbus_call_method_asynchronously, xd_read_message_1): Use a float
11418 to hold a serial number that is too large for a fixnum.
11419 (Fdbus_method_return_internal, Fdbus_method_error_internal):
11420 Check for serial numbers out of range. Decode any serial number
11421 that was so large that it became a float. (Bug#8722)
11423 * dbusbind.c: Use XFASTINT rather than XUINT, and check for nonneg.
11424 (Fdbus_call_method, Fdbus_call_method_asynchronously):
11425 Use XFASTINT rather than XUINT when numbers are nonnegative.
11426 (xd_append_arg, Fdbus_method_return_internal):
11427 (Fdbus_method_error_internal): Likewise. Also, for unsigned
11428 arguments, check that Lisp number is nonnegative, rather than
11429 silently wrapping negative numbers around. (Bug#8722)
11430 (xd_read_message_1): Don't assume dbus_uint32_t can fit in int.
11433 * data.c (arith_driver, Flsh): Avoid unnecessary casts to EMACS_UINT.
11435 * ccl.c (ccl_driver): Redo slightly to avoid the need for 'unsigned'.
11437 ccl: Add integer overflow checks.
11438 * ccl.c (CCL_CODE_MAX, GET_CCL_RANGE, GET_CCL_CODE, GET_CCL_INT):
11439 (IN_INT_RANGE): New macros.
11440 (ccl_driver): Use them to check for integer overflow when
11441 decoding a CCL program. Many of the new checks are whether XINT (x)
11442 fits in int; it doesn't always, on 64-bit hosts. The new version
11443 doesn't catch all possible integer overflows, but it's an
11444 improvement. (Bug#8719)
11446 * alloc.c (make_event_array): Use XINT, not XUINT.
11447 There's no need for unsigned here.
11449 * mem-limits.h (EXCEEDS_LISP_PTR) [!USE_LSB_TAG]: EMACS_UINT -> uintptr_t
11450 This follows up to the 2011-05-06 change that substituted uintptr_t
11451 for EMACS_INT. This case wasn't caught back then.
11453 Rework Fformat to avoid integer overflow issues.
11454 * editfns.c: Include <float.h> unconditionally, as it's everywhere
11455 now (part of C89). Include <verify.h>.
11456 (MAX_10_EXP, CONVERTED_BYTE_SIZE): Remove; no longer needed.
11457 (pWIDE, pWIDElen, signed_wide, unsigned_wide): New defns.
11458 (Fformat): Avoid the prepass trying to compute sizes; it was only
11459 approximate and thus did not catch overflow reliably. Instead, walk
11460 through the format just once, formatting and computing sizes as we go,
11461 checking for integer overflow at every step, and allocating a larger
11462 buffer as needed. Keep track separately whether the format is
11463 multibyte. Keep only the most-recently calculated precision, rather
11464 than them all. Record whether each argument has been converted to
11465 string. Use EMACS_INT, not int, for byte and char and arg counts.
11466 Support field widths and precisions larger than INT_MAX. Avoid
11467 sprintf's undefined behavior with conversion specifications such as %#d
11468 and %.0c. Fix bug with strchr succeeding on '\0' when looking for
11469 flags. Fix bug with (format "%c" 256.0). Avoid integer overflow when
11470 formatting out-of-range floating point numbers with int
11471 formats. (Bug#8668)
11473 * lisp.h (FIXNUM_OVERFLOW_P): Work even if arg is a NaN.
11475 * data.c: Avoid integer truncation in expressions involving floats.
11476 * data.c: Include <intprops.h>.
11477 (arith_driver): When there's an integer overflow in an expression
11478 involving floating point, convert the integers to floating point
11479 so that the resulting value does not suffer from catastrophic
11480 integer truncation. For example, on a 64-bit host (* 4
11481 most-negative-fixnum 0.5) should yield about -4.6e+18, not zero.
11482 Do not rely on undefined behavior after integer overflow.
11484 merge count_size_as_multibyte, parse_str_to_multibyte
11485 * character.c, character.h (count_size_as_multibyte):
11486 Rename from parse_str_to_multibyte; all uses changed.
11487 Check for integer overflow.
11488 * insdel.c, lisp.h (count_size_as_multibyte): Remove,
11489 since it's now a duplicate of the other. This is more of
11490 a character than a buffer op, so better that it's in character.c.
11491 * fns.c, print.c: Adjust to above changes.
11493 2011-05-27 Stefan Monnier <monnier@iro.umontreal.ca>
11495 * xselect.c (x_convert_selection): Yet another int/Lisp_Object mixup.
11497 2011-05-27 Paul Eggert <eggert@cs.ucla.edu>
11499 * xselect.c: Fix minor problems prompted by GCC 4.6.0 warnings.
11500 (x_handle_selection_request, frame_for_x_selection): Remove unused vars.
11501 (x_clipboard_manager_save): Now static.
11502 (Fx_clipboard_manager_save): Rename local to avoid shadowing.
11504 * fns.c: Fix minor problems prompted by GCC 4.6.0 warnings.
11505 (crypto_hash_function): Now static.
11506 Fix pointer signedness problems. Avoid unnecessary initializations.
11508 2011-05-27 Chong Yidong <cyd@stupidchicken.com>
11510 * termhooks.h (Vselection_alist): Make it terminal-local.
11512 * terminal.c (create_terminal): Initialize it.
11514 * xselect.c: Support for clipboard managers.
11515 (Vselection_alist): Move to termhooks.h as terminal-local var.
11516 (LOCAL_SELECTION): New macro.
11517 (x_atom_to_symbol): Handle x_display_info_for_display fail case.
11518 (symbol_to_x_atom): Remove gratuitous arg.
11519 (x_handle_selection_request, lisp_data_to_selection_data)
11520 (x_get_foreign_selection, Fx_register_dnd_atom): Callers changed.
11521 (x_own_selection, x_get_local_selection, x_convert_selection):
11522 New arg, specifying work frame. Use terminal-local Vselection_alist.
11523 (some_frame_on_display): Delete unused function.
11524 (Fx_own_selection_internal, Fx_get_selection_internal)
11525 (Fx_disown_selection_internal, Fx_selection_owner_p)
11526 (Fx_selection_exists_p): New optional frame arg.
11527 (frame_for_x_selection, Fx_clipboard_manager_save): New functions.
11528 (x_handle_selection_clear): Don't treat other terminals with the
11529 same keyboard specially. Use the terminal-local Vselection_alist.
11530 (x_clear_frame_selections): Use Frun_hook_with_args.
11532 * xterm.c (x_term_init): Intern ATOM and CLIPBOARD_MANAGER atoms.
11534 * xterm.h: Add support for those atoms.
11536 2011-05-26 Chong Yidong <cyd@stupidchicken.com>
11538 * xselect.c: ICCCM-compliant handling of MULTIPLE targets.
11539 (converted_selections, conversion_fail_tag): New global variables.
11540 (x_selection_request_lisp_error): Free the above.
11541 (x_get_local_selection): Remove unnecessary code.
11542 (x_reply_selection_request): Args changed; handle arbitrary array
11543 of converted selections stored in converted_selections.
11544 Separate the XChangeProperty and SelectionNotify steps.
11545 (x_handle_selection_request): Rewrite to handle MULTIPLE target.
11546 (x_convert_selection): New function.
11547 (x_handle_selection_event): Simplify.
11548 (x_get_foreign_selection): Don't ignore incoming requests while
11549 waiting for an answer; this will fail when we implement
11550 SAVE_TARGETS, and seems unnecessary anyway.
11551 (selection_data_to_lisp_data): Recognize ATOM_PAIR type.
11552 (Vx_sent_selection_functions): Doc fix.
11554 2011-05-26 Leo Liu <sdl.web@gmail.com>
11556 * editfns.c (Ftranspose_regions): Allow empty regions. (Bug#8699)
11558 2011-05-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
11560 * dispextern.h (struct glyph_row): New member fringe_bitmap_periodic_p.
11562 * dispnew.c (shift_glyph_matrix, scrolling_window): Mark scrolled row
11563 for fringe update if it has periodic bitmap.
11564 (row_equal_p): Also compare left_fringe_offset, right_fringe_offset,
11565 and fringe_bitmap_periodic_p.
11567 * fringe.c (get_fringe_bitmap_data): New function.
11568 (draw_fringe_bitmap_1, update_window_fringes): Use it.
11569 (update_window_fringes): Record periodicity of fringe bitmap in glyph
11570 row. Mark glyph row for fringe update if periodicity changed.
11572 * xdisp.c (try_window_reusing_current_matrix): Don't mark scrolled row
11573 for fringe update unless it has periodic bitmap.
11575 2011-05-25 Kenichi Handa <handa@m17n.org>
11577 * xdisp.c (get_next_display_element): Set correct it->face_id for
11578 a static composition.
11580 2011-05-24 Leo Liu <sdl.web@gmail.com>
11583 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha1.h.
11585 * fns.c (crypto_hash_function, Fsha1): New function.
11586 (Fmd5): Use crypto_hash_function.
11587 (syms_of_fns): Add Ssha1.
11589 2011-05-22 Paul Eggert <eggert@cs.ucla.edu>
11591 * gnutls.c: Remove unused macros.
11592 (fn_gnutls_transport_set_lowat, fn_gnutls_transport_set_pull_function):
11593 (fn_gnutls_transport_set_push_function) [!WINDOWSNT]:
11594 Remove macros that are defined and never used.
11595 Caught by gcc -Wunused-macros (GCC 4.6.0, Fedora 14).
11597 2011-05-22 Chong Yidong <cyd@stupidchicken.com>
11599 * xselect.c (syms_of_xselect): Remove unused symbol SAVE_TARGETS.
11600 (Fx_get_selection_internal): Minor cleanup.
11601 (Fx_own_selection_internal): Rename arguments for consistency with
11604 2011-05-22 Paul Eggert <eggert@cs.ucla.edu>
11606 * xselect.c (QSAVE_TARGETS): New static var, to fix build failure.
11608 2011-05-22 Chong Yidong <cyd@stupidchicken.com>
11610 * xselect.c (syms_of_xselect): Include character.h; use DEFSYM.
11612 2011-05-21 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
11614 * dispnew.c (scrolling_window): Don't exclude the case that the
11615 last enabled row in the desired matrix touches the bottom boundary.
11617 2011-05-21 Glenn Morris <rgm@gnu.org>
11619 * Makefile.in ($(etc)/DOC): Make second command line even shorter.
11620 (SOME_MACHINE_OBJECTS): Replace FONT_OBJ by its maximal expansion,
11621 and add some more files.
11623 2011-05-20 Eli Zaretskii <eliz@gnu.org>
11625 * callproc.c (Fcall_process) [MSDOS]: Fix arguments to
11626 report_file_error introduced by the change from 2011-05-07.
11628 2011-05-20 Paul Eggert <eggert@cs.ucla.edu>
11630 * systime.h (Time): Define only if emacs is defined.
11631 This is to allow ../lib-src/profile.c to be compiled on FreeBSD,
11632 where the include path doesn't have X11/X.h by default. See
11633 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00561.html>.
11635 2011-05-20 Kenichi Handa <handa@m17n.org>
11637 * composite.c (find_automatic_composition): Fix previous change.
11639 2011-05-20 Glenn Morris <rgm@gnu.org>
11641 * lisp.mk: New file, split from Makefile.in.
11642 * Makefile.in (lisp): Move to separate file, inserted by @lisp_frag@.
11643 (shortlisp): Remove.
11644 ($(etc)/DOC): Edit lisp.mk rather than using $shortlisp.
11646 2011-05-19 Glenn Morris <rgm@gnu.org>
11648 * Makefile.in (MSDOS_SUPPORT_REAL, MSDOS_SUPPORT, NS_SUPPORT)
11649 (REAL_MOUSE_SUPPORT, GPM_MOUSE_SUPPORT, MOUSE_SUPPORT, TOOLTIP_SUPPORT)
11650 (BASE_WINDOW_SUPPORT, X_WINDOW_SUPPORT, WINDOW_SUPPORT): Remove.
11651 (lisp): Set the order to that of loadup.el.
11652 (shortlisp): Make it a copy of $lisp.
11653 (SOME_MACHINE_LISP): Remove.
11654 ($(etc)/DOC): Depend just on $lisp, not $SOME_MACHINE_LISP too.
11655 Use just $shortlisp, not $SOME_MACHINE_LISP too.
11657 2011-05-18 Kenichi Handa <handa@m17n.org>
11659 * composite.c (CHAR_COMPOSABLE_P): Add more check for efficiency.
11660 (BACKWARD_CHAR): Wrap the arg STOP by parenthesis.
11661 (find_automatic_composition): Mostly rewrite for efficiency.
11663 2011-05-18 Juanma Barranquero <lekktu@gmail.com>
11665 * makefile.w32-in: Update dependencies.
11667 2011-05-18 Christoph Scholtes <cschol2112@googlemail.com>
11669 * menu.c: Include limits.h (fixes the MS-Windows build broken by
11670 2011-06-18T18:49:19Z!cyd@stupidchicken.com).
11672 2011-05-18 Paul Eggert <eggert@cs.ucla.edu>
11674 Fix some integer overflow issues, such as string length overflow.
11676 * insdel.c (count_size_as_multibyte): Check for string overflow.
11678 * character.c (lisp_string_width): Check for string overflow.
11679 Use EMACS_INT, not int, for string indexes and lengths; in
11680 particular, 2nd arg is now EMACS_INT, not int. Do not crash if
11681 the resulting string length overflows an EMACS_INT; instead,
11682 report a string overflow if no precision given. When checking for
11683 precision exhaustion, use a check that cannot possibly have
11684 integer overflow. (Bug#8675)
11685 * character.h (lisp_string_width): Adjust to new signature.
11687 * alloc.c (string_overflow): New function.
11688 (Fmake_string): Use it. This doesn't change behavior, but saves
11689 a few bytes and will simplify future changes.
11690 * character.c (string_escape_byte8): Likewise.
11691 * lisp.h (string_overflow): New decl.
11693 Fixups, following up to the user-interface timestamp change.
11694 * nsterm.m (last_mouse_movement_time, ns_mouse_position): Use Time
11695 for UI timestamps, instead of unsigned long.
11696 * msdos.c (mouse_get_pos): Likewise.
11697 * w32inevt.c (movement_time, w32_console_mouse_position): Likewise.
11698 * w32gui.h (Time): Define by including "systime.h" rather than by
11699 declaring it ourselves. (Bug#8664)
11701 * dispextern.h (struct image): Don't assume time_t <= unsigned long.
11702 * image.c (clear_image_cache): Likewise.
11704 * term.c (term_mouse_position): Don't assume time_t wraparound.
11706 Be more systematic about user-interface timestamps.
11707 Before, the code sometimes used 'Time', sometimes 'unsigned long',
11708 and sometimes 'EMACS_UINT', to represent these timestamps.
11709 This change causes it to use 'Time' uniformly, as that's what X uses.
11710 This makes the code easier to follow, and makes it easier to catch
11711 integer overflow bugs such as Bug#8664.
11712 * frame.c (Fmouse_position, Fmouse_pixel_position):
11713 Use Time, not unsigned long, for user-interface timestamps.
11714 * keyboard.c (last_event_timestamp, kbd_buffer_get_event): Likewise.
11715 (button_down_time, make_lispy_position, make_lispy_movement): Likewise.
11716 * keyboard.h (last_event_timestamp): Likewise.
11717 * menu.c (Fx_popup_menu) [!HAVE_X_WINDOWS]: Likewise.
11718 * menu.h (xmenu_show): Likewise.
11719 * term.c (term_mouse_position): Likewise.
11720 * termhooks.h (struct input_event.timestamp): Likewise.
11721 (struct terminal.mouse_position_hook): Likewise.
11722 * xmenu.c (create_and_show_popup_menu, xmenu_show): Likewise.
11723 * xterm.c (XTmouse_position, x_scroll_bar_report_motion): Likewise.
11724 * systime.h (Time): New decl. Pull it in from <X11/X.h> if
11725 HAVE_X_WINDOWS, otherwise define it as unsigned long, which is
11726 what it was before.
11727 * menu.h, termhooks.h: Include "systime.h", for Time.
11729 * keyboard.c (make_lispy_event): Fix problem in integer overflow.
11730 Don't assume that the difference between two unsigned long values
11731 can fit into an integer. At this point, we know button_down_time
11732 <= event->timestamp, so the difference must be nonnegative, so
11733 there's no need to cast the result if double-click-time is
11734 nonnegative, as it should be; check that it's nonnegative, just in
11735 case. This bug is triggered when events are more than 2**31 ms
11736 apart (about 25 days). (Bug#8664)
11738 * xselect.c (last_event_timestamp): Remove duplicate decl.
11739 (x_own_selection): Remove needless cast to unsigned long.
11741 * xmenu.c (set_frame_menubar): Use int, not EMACS_UINT, for indexes
11742 that always fit in int. Use a sentinel instead of a counter, to
11743 avoid a temp and to allay GCC's concerns about possible int overflow.
11744 * frame.h (struct frame): Use int for menu_bar_items_used
11745 instead of EMACS_INT, since it always fits in int.
11747 * menu.c (grow_menu_items): Check for int overflow.
11749 * xmenu.c (set_frame_menubar): Don't mishandle vectors with no nils.
11751 * xterm.c: Use EMACS_INT for Emacs modifiers, and int for X modifiers.
11752 Before, the code was not consistent. These values cannot exceed
11753 2**31 - 1 so there's no need to make them unsigned.
11754 (x_x_to_emacs_modifiers): Accept int and return EMACS_INT.
11755 (x_emacs_to_x_modifiers): Accept EMACS_INT and return int.
11756 (x_x_to_emacs_modifiers, x_emacs_to_x_modifiers): Reject non-integers
11758 * xterm.h (x_x_to_emacs_modifiers): Adjust to signature change.
11760 * lisp.h (XINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_INT.
11761 (XUINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_UINT.
11762 Otherwise, GCC 4.6.0 warns about printf (pI, XINT (...)),
11763 presumably because the widths might not match.
11765 * window.c (size_window): Avoid needless test at loop start.
11767 2011-05-18 Courtney Bane <emacs-bugs-7626@cbane.org> (tiny change)
11769 * term.c (Fresume_tty): Restore hooks before reinitializing (bug#8687).
11771 2011-05-12 Drew Adams <drew.adams@oracle.com>
11773 * textprop.c (Fprevious_single_char_property_change): Doc fix (bug#8655).
11775 2011-05-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
11777 * w32term.c (w32_draw_fringe_bitmap): Rename local vars `left' and
11778 `width' to `bar_area_x' and `bar_area_width', respectively.
11779 (x_scroll_run): Take account of fringe background extension.
11781 * xterm.c (x_draw_fringe_bitmap) [USE_TOOLKIT_SCROLL_BARS]:
11782 Rename local vars `left' and `width' to `bar_area_x' and
11783 `bar_area_width', respectively.
11784 (x_scroll_run) [USE_TOOLKIT_SCROLL_BARS]: Take account of fringe
11785 background extension.
11787 2011-05-10 Jim Meyering <meyering@redhat.com>
11789 * xdisp.c (x_intersect_rectangles): Fix typo "the the -> the".
11791 2011-05-10 Juanma Barranquero <lekktu@gmail.com>
11793 * image.c (Finit_image_library): Return t for built-in image types,
11794 like pbm and xbm. (Bug#8640)
11796 2011-05-09 Andreas Schwab <schwab@linux-m68k.org>
11798 * w32menu.c (set_frame_menubar): Fix submenu allocation.
11800 2011-05-07 Eli Zaretskii <eliz@gnu.org>
11802 * w32console.c (Fset_screen_color): Doc fix.
11803 (Fget_screen_color): New function.
11804 (syms_of_ntterm): Defsubr it.
11806 * callproc.c (call_process_cleanup) [MSDOS]: Don't close and
11807 unlink the temporary file if Fcall_process didn't create it in the
11809 (Fcall_process) [MSDOS]: Don't create tempfile if stdout of the
11810 child process will be redirected to a file specified with `:file'.
11811 Don't try to re-open tempfile in that case, and set fd[0] to -1 as
11812 cue to call_process_cleanup not to close that handle.
11814 2011-05-07 Ben Key <bkey76@gmail.com>
11816 * makefile.w32-in: The bootstrap-temacs rule now makes use of
11817 one of two shell specific rules, either bootstrap-temacs-CMD or
11818 bootstrap-temacs-SH. The bootstrap-temacs-SH rule is identical
11819 to the previous implementation of the bootstrap-temacs rule.
11820 The bootstrap-temacs-CMD rule is similar to the previous
11821 implementation of the bootstrap-temacs rule except that it
11822 makes use of the ESC_CFLAGS variable instead of the CFLAGS
11825 These changes, along with some changes to nt/configure.bat,
11826 nt/gmake.defs, and nt/nmake.defs, are required to extend my
11827 earlier fix to add support for --cflags and --ldflags options
11828 that include quotes so that it works whether make uses cmd or
11831 2011-05-06 Michael Albinus <michael.albinus@gmx.de>
11833 * dbusbind.c (QCdbus_type_unix_fd): Declare static.
11834 (xd_remove_watch): Don't check QCdbus_type_unix_fd for SYMBOLP, it
11836 (Fdbus_init_bus, xd_read_queued_messages): Bus can be a symbol or
11837 a string. Handle both cases.
11838 (Fdbus_call_method_asynchronously, Fdbus_register_signal)
11839 (Fdbus_register_method): Use Qinvalid_function.
11841 2011-05-06 Juanma Barranquero <lekktu@gmail.com>
11843 * makefile.w32-in: Update dependencies.
11844 (LISP_H): Add inttypes.h and stdin.h.
11845 (PROCESS_H): Add unistd.h.
11847 2011-05-06 Eli Zaretskii <eliz@gnu.org>
11849 * lread.c: Include limits.h (fixes the MS-Windows build broken by
11850 2011-05-06T07:13:19Z!eggert@cs.ucla.edu).
11852 2011-05-06 Paul Eggert <eggert@cs.ucla.edu>
11854 * image.c (Finit_image_library) [!HAVE_NTGUI]: Omit unused local.
11856 * term.c (vfatal): Remove stray call to va_end.
11857 It's not needed and the C Standard doesn't allow it here anyway.
11859 Use C99's va_copy to avoid undefined behavior on x86-64 GNU/Linux.
11860 * eval.c (verror): doprnt a copy of ap, not the original. (Bug#8545)
11862 * eval.c (verror): OK to create a string of up to MOST_POSITIVE_FIXNUM
11865 * term.c: Don't include <stdarg.h>, as <lisp.h> does that.
11867 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
11869 * process.c (Fformat_network_address): Fix typo: args2 -> *args2.
11871 * xmenu.c (set_frame_menubar): Fix typo: int * -> int (3 times).
11873 * coding.c (detect_coding_charset): Fix typo: * 2 -> *4 (Bug#8601).
11875 * charset.h (struct charset.code_space): Now has 15 elements, not 16.
11876 * charset.c (Fdefine_charset_internal): Don't initialize
11877 charset.code_space[15]. The value was garbage, on hosts with
11878 32-bit int (Bug#8600).
11880 * lread.c (read_integer): Be more consistent with string-to-number.
11881 Use string_to_number to do the actual conversion; this avoids
11882 rounding errors and fixes some other screwups. Without this fix,
11883 for example, #x1fffffffffffffff was misread as -2305843009213693952.
11884 (digit_to_number): Move earlier, for benefit of read_integer.
11885 Return -1 if the digit is out of range for the base, -2 if it is
11886 not a digit in any supported base. (Bug#8602)
11888 * doprnt.c (doprnt): Support arbitrary pI values, such as "I64".
11890 * dispnew.c (scrolling_window): Return 1 if we scrolled,
11891 to match comment at start of function. This also removes a
11892 GCC warning about overflow in a 32+64-bit port.
11894 * lisp.h (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Simplify.
11896 * dbusbind.c: Do not use XPNTR on a value that may be an integer.
11897 Reported by Stefan Monnier in
11898 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00919.html>.
11899 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
11900 Use SYMBOLP-guarded XSYMBOL, not XPNTR.
11902 * lisp.h (EMACS_INTPTR): Remove. All uses changed to intptr_t.
11903 (EMACS_UINTPTR): Likewise, with uintptr_t.
11905 * lisp.h: Prefer 64-bit EMACS_INT if available.
11906 (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Define to 64-bit
11907 on 32-bit hosts that have 64-bit int, so that they can access
11909 However, temporarily disable this change unless the temporary
11910 symbol WIDE_EMACS_INT is defined.
11912 * lread.c, process.c: Do not include <inttypes.h>; lisp.h does it now.
11914 Prefer intptr_t/uintptr_t for integers the same widths as pointers.
11915 This removes an assumption that EMACS_INT and long are the same
11916 width as pointers. The assumption is true for Emacs porting targets
11917 now, but we want to make other targets possible.
11918 * lisp.h: Include <inttypes.h>, for INTPTR_MAX, UINTPTR_MAX.
11919 (EMACS_INTPTR, EMACS_UINTPTR): New macros.
11920 In the rest of the code, change types of integers that hold casted
11921 pointers to EMACS_INTPTR and EMACS_UINTPTR, systematically
11922 replacing EMACS_INT, long, EMACS_UINT, and unsigned long.
11923 (XTYPE): Don't cast arg to EMACS_UINT; normally is not needed.
11924 (XSET): Cast type of XTYPE arg to EMACS_INTPTR; it is needed here.
11925 No need to cast type when ORing.
11926 (XPNTR): Return a value of type EMACS_INTPTR or EMACS_UINTPTR.
11927 * alloc.c (lisp_align_malloc): Remove a no-longer-needed cast.
11928 * doc.c (store_function_docstring): Use EMACS_INTPTR, so as not to
11929 assume EMACS_INT is the same width as char *.
11930 * gtkutil.c (xg_gtk_scroll_destroy, xg_tool_bar_button_cb):
11931 (xg_tool_bar_callback, xg_tool_bar_help_callback, xg_make_tool_item):
11932 Remove no-longer-needed casts.
11933 (xg_create_scroll_bar, xg_tool_bar_button_cb, xg_tool_bar_callback):
11934 (xg_tool_bar_help_callback, xg_make_tool_item):
11935 Use EMACS_INTPTR to hold an integer
11936 that will be cast to void *; this can avoid a GCC warning
11937 if EMACS_INT is not the same width as void *.
11938 * menu.c (find_and_call_menu_selection): Remove no-longer-needed cast.
11939 * xdisp.c (display_echo_area_1, resize_mini_window_1):
11940 (current_message_1, set_message_1):
11941 Use a local to convert to proper width without a cast.
11942 * xmenu.c (dialog_selection_callback): Likewise.
11944 * sysdep.c (get_random): Don't assume EMACS_INT is no wider than long.
11945 Also, don't assume VALBITS / RAND_BITS is less than 5,
11946 and don't rely on undefined behavior when shifting a 1 left into
11948 * lisp.h (get_random): Change signature to match.
11950 * lread.c (hash_string): Use size_t, not int, for hash computation.
11951 Normally we prefer signed values; but hashing is special, because
11952 it's better to use unsigned division on hash table sizes so that
11953 the remainder is nonnegative. Also, size_t is the natural width
11954 for hashing into memory. The previous code used 'int', which doesn't
11955 retain enough info to hash well into very large tables.
11956 (oblookup, oblookup_last_bucket_number, Funintern): Likewise.
11958 * dbusbind.c: Don't possibly lose pointer info when converting.
11959 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
11960 Use XPNTR rather than XHASH, so that the high-order bits of
11961 the pointer aren't lost when converting through void *.
11963 * eval.c (Fautoload): Don't double-shift a pointer.
11965 * fns.c (Frandom): Let EMACS_UINT be wider than unsigned long.
11967 2011-05-06 Juanma Barranquero <lekktu@gmail.com>
11969 * gnutls.c (DEF_GNUTLS_FN):
11970 * image.c (DEF_IMGLIB_FN): Make function pointers static.
11972 2011-05-05 Andreas Schwab <schwab@linux-m68k.org>
11974 * lread.c (lisp_file_lexically_bound_p): Stop scanning at end
11977 2011-05-05 Eli Zaretskii <eliz@gnu.org>
11979 * w32heap.c (allocate_heap) [USE_LISP_UNION_TYPE || USE_LSB_TAG]:
11980 New version that can reserve upto 2GB of heap space.
11982 2011-05-05 Chong Yidong <cyd@stupidchicken.com>
11984 * nsfns.m (Fns_read_file_name): Doc fix (Bug#8534).
11986 2011-05-05 Teodor Zlatanov <tzz@lifelogs.com>
11988 * gnutls.c (fn_gnutls_certificate_set_x509_key_file): Add alias to
11989 `gnutls_certificate_set_x509_key_file'.
11991 2011-05-05 Juanma Barranquero <lekktu@gmail.com>
11993 * makefile.w32-in ($(BLD)/image.$(O), $(BLD)/process.$(O)):
11994 Update dependencies.
11996 2011-05-04 Juanma Barranquero <lekktu@gmail.com>
11998 * gnutls.h (emacs_gnutls_write, emacs_gnutls_read):
11999 * gnutls.c (emacs_gnutls_write, emacs_gnutls_read):
12000 Remove unused parameter `fildes'.
12001 * process.c (read_process_output, send_process): Don't pass it.
12003 2011-05-04 Juanma Barranquero <lekktu@gmail.com>
12005 Fix previous change: the library cache is defined in w32.c.
12006 * image.c (CACHE_IMAGE_TYPE) [!HAVE_NTGUI]: Define to noop.
12007 (Finit_image_library): Wrap Vlibrary_cache on "#ifdef HAVE_NTGUI".
12009 2011-05-04 Juanma Barranquero <lekktu@gmail.com>
12011 Implement dynamic loading of GnuTLS on Windows.
12013 * gnutls.h (GNUTLS_EMACS_ERROR_NOT_LOADED): New macro.
12014 (emacs_gnutls_write, emacs_gnutls_read): Mark as extern.
12015 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
12018 * gnutls.c (Qgnutls_dll): Define.
12019 (DEF_GNUTLS_FN, LOAD_GNUTLS_FN): New macros.
12020 (gnutls_*): Declare function pointers.
12021 (init_gnutls_functions): New function to initialize function pointers.
12022 (emacs_gnutls_handshake, Fgnutls_error_string, Fgnutls_deinit)
12023 (emacs_gnutls_global_init, Fgnutls_bye): Use function pointers.
12024 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
12025 Wrappers for gnutls_record_check_pending and gnutls_transport_set_errno.
12026 (emacs_gnutls_write, emacs_gnutls_read)
12027 (emacs_gnutls_handle_error, Fgnutls_error_fatalp)
12028 (Fgnutls_available_p): New function.
12029 (Fgnutls_boot): Call Fgnutls_available_p. Use function pointers.
12030 (syms_of_gnutls) <Qgnutls_dll>: Initialize and staticpro it.
12031 (syms_of_gnutls) <Sgnutls_available_p>: defsubr it.
12033 * image.c: Include w32.h.
12034 (Vimage_type_cache): Delete.
12035 (syms_of_image) <Vimage_type_cache>: Don't initialize and staticpro it.
12036 (CACHE_IMAGE_TYPE, Finit_image_library): Use Vlibrary_cache instead.
12037 (w32_delayed_load): Move to w32.c.
12039 * w32.h (VlibraryCache, QCloaded_from, w32_delayed_load): Declare.
12041 * w32.c (QCloaded_from, Vlibrary_cache): Define.
12042 (w32_delayed_load): Move from image.c. When loading a library, record
12043 its filename in the :loaded-from property of the library id.
12044 (globals_of_w32) <QCloaded_from, Vlibrary_cache>:
12045 Initialize and staticpro them.
12046 (emacs_gnutls_pull, emacs_gnutls_push): Call emacs_gnutls_* functions.
12048 * process.c: Include lisp.h before w32.h, not after.
12049 (wait_reading_process_output): Call emacs_gnutls_record_check_pending
12050 instead of gnutls_record_check_pending.
12052 * callproc.c, emacs.c: Include lisp.h before w32.h, not after.
12054 2011-05-04 Teodor Zlatanov <tzz@lifelogs.com>
12056 * gnutls.c (Fgnutls_boot): Support :keylist and :crlfiles options
12057 instead of :keyfiles. Give GnuTLS the keylist and the CRL lists
12060 2011-05-03 Jan Djärv <jan.h.d@swipnet.se>
12062 * xterm.c (x_set_frame_alpha): Do not set property on anything
12063 else than FRAME_X_OUTER_WINDOW (Bug#8608).
12065 2011-05-02 Juanma Barranquero <lekktu@gmail.com>
12067 * sysdep.c (get_tty_size) [WINDOWSNT]: Implement. (Bug#8596)
12069 2011-05-02 Juanma Barranquero <lekktu@gmail.com>
12071 * gnutls.c (Qgnutls_log_level, Qgnutls_code, Qgnutls_anon)
12072 (Qgnutls_x509pki, Qgnutls_e_interrupted, Qgnutls_e_again)
12073 (Qgnutls_e_invalid_session, Qgnutls_e_not_ready_for_handshake)
12074 (gnutls_global_initialized, Qgnutls_bootprop_priority)
12075 (Qgnutls_bootprop_trustfiles, Qgnutls_bootprop_keyfiles)
12076 (Qgnutls_bootprop_callbacks, Qgnutls_bootprop_loglevel)
12077 (Qgnutls_bootprop_hostname, Qgnutls_bootprop_verify_flags)
12078 (Qgnutls_bootprop_verify_error, Qgnutls_bootprop_verify_hostname_error)
12079 (Qgnutls_bootprop_callbacks_verify): Make static.
12081 2011-05-01 Andreas Schwab <schwab@linux-m68k.org>
12083 * callproc.c: Indentation fixup.
12085 * sysdep.c (wait_for_termination_1): Make static.
12086 (wait_for_termination, interruptible_wait_for_termination):
12087 Move after wait_for_termination_1.
12089 2011-05-01 Lars Magne Ingebrigtsen <larsi@gnus.org>
12091 * sysdep.c (interruptible_wait_for_termination): New function
12092 which is like wait_for_termination, but allows keyboard
12095 * callproc.c (Fcall_process): Add (:file "file") as an option for
12097 (Fcall_process_region): Ditto.
12099 2011-04-30 Eli Zaretskii <eliz@gnu.org>
12101 * dosfns.c (Fint86, Fdos_memget, Fdos_memput): Use `ASIZE (FOO)'
12102 rather than `XVECTOR (FOO)->size'.
12104 * process.c: Remove HAVE_INTTYPES_H condition from inclusion of
12105 inttypes.h, as a gnulib replacement is used if it not available in
12108 2011-04-21 Eli Zaretskii <eliz@gnu.org>
12110 Lift the MOST_POSITIVE_FIXNUM/4 limitation on visited files.
12111 * fileio.c (Finsert_file_contents): Don't limit file size to 1/4
12112 of MOST_POSITIVE_FIXNUM. (Bug#8528)
12114 * coding.c (coding_alloc_by_realloc): Error out if destination
12115 will grow beyond MOST_POSITIVE_FIXNUM.
12116 (decode_coding_emacs_mule): Abort if there isn't enough place in
12117 charbuf for the composition carryover bytes. Reserve an extra
12118 space for up to 2 characters produced in a loop.
12119 (decode_coding_iso_2022): Abort if there isn't enough place in
12120 charbuf for the composition carryover bytes.
12122 2011-04-21 Eli Zaretskii <eliz@gnu.org>
12124 * doprnt.c (doprnt) [!HAVE_LONG_LONG_INT]: Error out instead of
12125 aborting when %lld or %lll format is passed.
12126 [!HAVE_UNSIGNED_LONG_LONG_INT]: Error out instead of aborting when
12127 %llo or %llx format is passed. (Bug#8545)
12129 * window.c (window_scroll_line_based): Use a marker instead of
12130 simple variables to record original value of point. (Bug#7952)
12132 * doprnt.c (doprnt): Fix the case where a multibyte sequence
12133 produced by %s or %c overflows available buffer space. (Bug#8545)
12135 2011-04-28 Paul Eggert <eggert@cs.ucla.edu>
12137 * doprnt.c (doprnt): Omit useless test; int overflow check (Bug#8545).
12138 (SIZE_MAX): Move defn after all includes, as they might #define it.
12140 2011-04-28 Juanma Barranquero <lekktu@gmail.com>
12142 * w32.c (init_environment): Warn about defaulting HOME to C:\.
12144 2011-04-28 Juanma Barranquero <lekktu@gmail.com>
12146 * keyboard.c (Qdelayed_warnings_hook): Define.
12147 (command_loop_1): Run `delayed-warnings-hook'
12148 if Vdelayed_warnings_list is non-nil.
12149 (syms_of_keyboard) <delayed-warnings-hook>: DEFSYM it.
12150 (syms_of_keyboard) <delayed-warnings-list>: DEFVAR_LISP it.
12152 2011-04-28 Eli Zaretskii <eliz@gnu.org>
12154 * doprnt.c (doprnt): Don't return value smaller than the buffer
12155 size if the message was truncated. (Bug#8545).
12157 2011-04-28 Juanma Barranquero <lekktu@gmail.com>
12159 * w32fns.c (Fx_change_window_property, Fx_delete_window_property)
12160 (Fx_window_property): #if-0 the whole functions, not just the bodies.
12162 2011-04-27 Paul Eggert <eggert@cs.ucla.edu>
12164 * doprnt.c (doprnt): Support "ll" length modifier, for long long.
12166 2011-04-27 Juanma Barranquero <lekktu@gmail.com>
12168 * makefile.w32-in: Update dependencies.
12170 2011-04-27 Eli Zaretskii <eliz@gnu.org>
12172 Improve `doprnt' and its usage. (Bug#8545)
12173 * doprnt.c (doprnt): Make sure `format' is never accessed beyond
12174 `format_end'. Remove support for %l as a conversion specifier.
12175 Don't use xrealloc. Improve diagnostics when the %l size modifier
12176 is used. Update the commentary.
12178 * eval.c (verror): Simplify calculation of size_t.
12180 * coding.c (Ffind_operation_coding_system): Fix diagnostic error
12183 2011-04-27 Yoshiaki Kasahara <kasahara@nc.kyushu-u.ac.jp> (tiny change)
12185 * buffer.c (init_buffer) [USE_MMAP_FOR_BUFFERS]: Adjust to aliasing
12188 2011-04-27 Paul Eggert <eggert@cs.ucla.edu>
12190 * nsmenu.m: Replace all uses of XVECTOR with ASIZE and AREF.
12191 This makes this file independent of the recent pseudovector change.
12193 2011-04-26 Paul Eggert <eggert@cs.ucla.edu>
12195 * keyboard.c (handle_user_signal): Fix pointer signedness problem.
12197 * gnutls.c (emacs_gnutls_handle_error): Remove unused local.
12198 (Fgnutls_boot): gnutls_certificate_verify_peers2 wants unsigned *.
12199 Remove unused local.
12200 (emacs_gnutls_write): Don't use uninitialized rtnval if nbyte <= 0.
12202 * lisp.h: Fix a problem with aliasing and vector headers. (Bug#8546)
12203 GCC 4.6.0 optimizes based on type-based alias analysis.
12204 For example, if b is of type struct buffer * and v of type struct
12205 Lisp_Vector *, then gcc -O2 was incorrectly assuming that &b->size
12206 != &v->size, and therefore "v->size = 1; b->size = 2; return
12207 v->size;" must therefore return 1. This assumption is incorrect
12208 for Emacs, since it type-puns struct Lisp_Vector * with many other
12209 types. To fix this problem, this patch adds a new type struct
12210 vectorlike_header that documents the constraints on layout of vectors
12211 and pseudovectors, and helps optimizing compilers not get fooled
12212 by Emacs's type punning. It also adds the macros XSETTYPED_PVECTYPE
12213 XSETTYPED_PSEUDOVECTOR, TYPED_PSEUDOVECTORP, for similar reasons.
12214 * lisp.h (XSETTYPED_PVECTYPE): New macro, specifying the name of
12216 (XSETPVECTYPE): Rewrite in terms of new macro.
12217 (XSETPVECTYPESIZE): New macro, specifying both type and size.
12218 This is a bit clearer, and further avoids the possibility of
12219 undesirable aliasing.
12220 (XSETTYPED_PSEUDOVECTOR): New macro, specifying the size.
12221 (XSETPSEUDOVECTOR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR.
12222 (XSETSUBR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR and XSIZE,
12223 since Lisp_Subr is a special case (no "next" field).
12224 (ASIZE): Now uses header.size rather than size.
12225 All previous uses of XVECTOR (foo)->size replaced to use this macro,
12226 to avoid the hassle of writing XVECTOR (foo)->header.size.
12227 (struct vectorlike_header): New type.
12228 (TYPED_PSEUDOVECTORP): New macro, also specifying the C type of the
12229 object, to help avoid aliasing.
12230 (PSEUDOVECTORP): Rewrite in terms of TYPED_PSEUDOVECTORP.
12231 (SUBRP): Likewise, since Lisp_Subr is a special case.
12232 * lisp.h (struct Lisp_Vector, struct Lisp_Char_Table):
12233 (struct Lisp_Sub_Char_Table, struct Lisp_Bool_Vector):
12234 (struct Lisp_Hash_Table): Combine first two members into a single
12235 struct vectorlike_header member. All uses of "size" and "next" members
12236 changed to be "header.size" and "header.next".
12237 * buffer.h (struct buffer): Likewise.
12238 * font.h (struct font_spec, struct font_entity, struct font): Likewise.
12239 * frame.h (struct frame): Likewise.
12240 * process.h (struct Lisp_Process): Likewise.
12241 * termhooks.h (struct terminal): Likewise.
12242 * window.c (struct save_window_data, struct saved_window): Likewise.
12243 * window.h (struct window): Likewise.
12244 * alloc.c (allocate_buffer, Fmake_bool_vector, allocate_pseudovector):
12245 Use XSETPVECTYPESIZE, not XSETPVECTYPE, to avoid aliasing problems.
12246 * buffer.c (init_buffer_once): Likewise.
12247 * lread.c (defsubr): Use XSETTYPED_PVECTYPE, since Lisp_Subr is a
12249 * process.c (Fformat_network_address): Use local var for size,
12252 * bytecode.c (exec_byte_code): Don't use XVECTOR before CHECK_VECTOR.
12254 Make the Lisp reader and string-to-float more consistent (Bug#8525)
12255 * data.c (atof): Remove decl; no longer used or needed.
12256 (digit_to_number): Move to lread.c.
12257 (Fstring_to_number): Use new string_to_number function, to be
12258 consistent with how the Lisp reader treats infinities and NaNs.
12259 Do not assume that floating-point numbers represent EMACS_INT
12260 without losing information; this is not true on most 64-bit hosts.
12261 Avoid double-rounding errors, by insisting on integers when
12262 parsing non-base-10 numbers, as the documentation specifies.
12263 * lisp.h (string_to_number): New decl, replacing ...
12264 (isfloat_string): Remove.
12265 * lread.c: Include <inttypes.h>, for uintmax_t and strtoumax.
12266 (read1): Do not accept +. and -. as integers; this
12267 appears to have been a coding error. Similarly, do not accept
12268 strings like +-1e0 as floating point numbers. Do not report
12269 overflow for integer overflows unless the base is not 10 which
12270 means we have no simple and reliable way to continue.
12271 Break out the floating-point parsing into a new
12272 function string_to_number, so that Fstring_to_number parses
12273 floating point numbers consistently with the Lisp reader.
12274 (digit_to_number): Move here from data.c. Make it static inline.
12275 (E_CHAR, EXP_INT): Remove, replacing with ...
12276 (E_EXP): New macro, to solve the "1.0e+" problem mentioned below.
12277 (string_to_number): New function, replacing isfloat_string.
12278 This function checks for valid syntax and produces the resulting
12279 Lisp float number too. Rework it so that string-to-number
12280 no longer mishandles examples like "1.0e+". Use strtoumax,
12281 so that overflow for non-base-10 numbers is reported only when
12282 there's no portable and simple way to convert to floating point.
12284 * textprop.c (set_text_properties_1): Rewrite for clarity,
12285 and to avoid GCC warning about integer overflow.
12287 * intervals.h (struct interval): Use EMACS_INT for members
12288 where EMACS_UINT might cause problems. See
12289 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html>.
12290 (CHECK_TOTAL_LENGTH): Remove cast to EMACS_INT; no longer needed.
12291 * intervals.c (interval_deletion_adjustment): Now returns EMACS_INT.
12293 (offset_intervals): Tell GCC not to worry about length overflow
12294 when negating a negative length.
12296 * alloc.c (overrun_check_malloc, overrun_check_realloc): Now static.
12297 (overrun_check_free): Likewise.
12299 * alloc.c (SDATA_SIZE) [!GC_CHECK_STRING_BYTES]: Avoid runtime check
12300 in the common case where SDATA_DATA_OFFSET is a multiple of Emacs
12303 * gnutls.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
12304 (gnutls_make_error): Rename local to avoid shadowing.
12305 (gnutls_emacs_global_deinit): ifdef out; not used.
12306 (Fgnutls_boot): Use const for pointer to readonly storage.
12307 Comment out unused local. Fix pointer signedness problems.
12309 * lread.c (openp): Don't stuff size_t into an 'int'.
12310 Use <= on length, not < on length + 1, to avoid GCC 4.6.0 warning
12311 about possible signed overflow.
12313 * gtkutil.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
12314 (GDK_KEY_g): Don't define if already defined.
12315 (xg_prepare_tooltip): Avoid pointer signedness problem.
12316 (xg_set_toolkit_scroll_bar_thumb): Redo to avoid two casts.
12318 * process.c (Fnetwork_interface_info): Avoid left-shift undefined
12319 behavior with 1 << 31. GCC 4.6.0 warns about this on 32-bit hosts.
12321 * xfns.c (Fx_window_property): Simplify a bit,
12322 to make a bit faster and to avoid GCC 4.6.0 warning.
12323 * xselect.c (x_get_window_property, x_handle_dnd_message): Likewise.
12325 * fns.c (internal_equal): Don't assume size_t fits in int.
12327 * alloc.c (compact_small_strings): Tighten assertion a little.
12329 Replace pEd with more-general pI, and fix some printf arg casts.
12330 * lisp.h (pI): New macro, generalizing old pEd macro to other
12331 conversion specifiers. For example, use "...%"pI"d..." rather
12332 than "...%"pEd"...".
12333 (pEd): Remove. All uses replaced with similar uses of pI.
12334 * m/amdx86-64.h, m/ia64.h, m/ibms390x.h: Likewise.
12335 * alloc.c (check_pure_size): Don't overflow by converting size to int.
12336 * bidi.c (bidi_dump_cached_states): Use pI to avoid cast.
12337 * data.c (Fnumber_to_string): Use pI instead of if-then-else-abort.
12338 * dbusbind.c (xd_append_arg): Use pI to avoid cast.
12339 (Fdbus_method_return_internal, Fdbus_method_error_internal): Likewise.
12340 * font.c (font_unparse_xlfd): Avoid potential buffer overrun on
12342 (font_unparse_xlfd, font_unparse_fcname): Use pI to avoid casts.
12343 * keyboard.c (record_char, modify_event_symbol): Use pI to avoid casts.
12344 * print.c (safe_debug_print, print_object): Likewise.
12345 (print_object): Don't overflow by converting EMACS_INT or EMACS_UINT
12347 Use pI instead of if-then-else-abort. Use %p to avoid casts,
12348 avoiding the 0 flag, which is not portable.
12349 * process.c (Fmake_network_process): Use pI to avoid cast.
12350 * region-cache.c (pp_cache): Likewise.
12351 * xdisp.c (decode_mode_spec): Likewise.
12352 * xrdb.c (x_load_resources) [USE_MOTIF]: Use pI to avoid undefined
12353 behavior on 64-bit hosts with printf arg.
12354 * xselect.c (x_queue_event): Use %p to avoid casts, avoiding 0 flag.
12355 (x_stop_queuing_selection_requests): Likewise.
12356 (x_get_window_property): Don't truncate byte count to an 'int'
12359 * frame.c (frame_name_fnn_p): Get rid of strtol, which isn't right
12360 here, since it parses constructs like leading '-' and spaces,
12361 which are not wanted; and it overflows with large numbers.
12362 Instead, simply match F[0-9]+, which is what is wanted anyway.
12364 * alloc.c: Remove unportable assumptions about struct layout.
12365 (SDATA_SELECTOR, SDATA_DATA_OFFSET): New macros.
12366 (SDATA_OF_STRING, SDATA_SIZE, allocate_string_data):
12367 (allocate_vectorlike, make_pure_vector): Use the new macros,
12368 plus offsetof, to remove unportable assumptions about struct layout.
12369 These assumptions hold on all porting targets that I know of, but
12370 they are not guaranteed, they're easy to remove, and removing them
12371 makes further changes easier.
12373 * alloc.c (BLOCK BYTES): Fix typo by changing "ablock" to "ablocks".
12374 This doesn't fix a bug but makes the code clearer.
12375 (string_overrun_cookie): Now const. Use initializers that
12376 don't formally overflow signed char, to avoid warnings.
12377 (allocate_string_data) [GC_CHECK_STRING_OVERRUN]: Fix typo that
12378 can cause Emacs to crash when string overrun checking is enabled.
12379 (allocate_buffer): Don't assume sizeof (struct buffer) is a
12380 multiple of sizeof (EMACS_INT); it need not be, if
12381 alignof(EMACS_INT) < sizeof (EMACS_INT).
12382 (check_sblock, check_string_bytes, check_string_free_list): Protoize.
12384 2011-04-26 Juanma Barranquero <lekktu@gmail.com>
12386 * keyboard.c (QCrtl): Rename from Qrtl. All uses changed.
12388 2011-04-26 Teodor Zlatanov <tzz@lifelogs.com>
12390 * gnutls.c (emacs_gnutls_handshake): Return an error if we're not
12391 supposed to be handshaking. (Bug#8556)
12392 Reported by Paul Eggert <eggert@cs.ucla.edu>.
12394 2011-04-26 Daniel Colascione <dan.colascione@gmail.com>
12396 * lisp.h (Qdebug): List symbol.
12397 * eval.c (Qdebug): Restore global linkage.
12398 * keyboard.c (debug-on-event): New variable.
12399 (handle_user_signal): Break into debugger when debug-on-event
12400 matches the current signal symbol.
12402 2011-04-25 Dan Nicolaescu <dann@ics.uci.edu>
12404 * alloc.c (check_sblock, check_string_bytes)
12405 (check_string_free_list): Convert to standard C.
12407 2011-04-25 Teodor Zlatanov <tzz@lifelogs.com>
12409 * w32.c (emacs_gnutls_push): Fix typo.
12411 2011-04-25 Eli Zaretskii <eliz@gnu.org>
12413 * gnutls.c (emacs_gnutls_handshake): Avoid compiler warnings about
12414 "cast to pointer from integer of different size".
12416 Improve doprnt and its use in verror. (Bug#8545)
12417 * doprnt.c (doprnt): Document the set of format control sequences
12418 supported by the function. Use SAFE_ALLOCA instead of always
12421 * eval.c (verror): Don't limit the buffer size at size_max-1, that
12422 is one byte too soon. Don't use xrealloc; instead xfree and
12425 2011-04-24 Teodor Zlatanov <tzz@lifelogs.com>
12427 * gnutls.h: Add GNUTLS_STAGE_CALLBACKS enum to denote we're in the
12430 * gnutls.c: Renamed global_initialized to
12431 gnutls_global_initialized. Added internals for the
12432 :verify-hostname-error, :verify-error, and :verify-flags
12433 parameters of `gnutls-boot' and documented those parameters in the
12434 docstring. Start callback support.
12435 (emacs_gnutls_handshake): Add Woe32 support. Retry handshake
12436 unless a fatal error occurred. Call gnutls_alert_send_appropriate
12437 on error. Return error code.
12438 (emacs_gnutls_write): Call emacs_gnutls_handle_error.
12439 (emacs_gnutls_read): Likewise.
12440 (Fgnutls_boot): Return handshake error code.
12441 (emacs_gnutls_handle_error): New function.
12442 (wsaerror_to_errno): Likewise.
12444 * w32.h (emacs_gnutls_pull): Add prototype.
12445 (emacs_gnutls_push): Likewise.
12447 * w32.c (emacs_gnutls_pull): New function for GnuTLS on Woe32.
12448 (emacs_gnutls_push): Likewise.
12450 2011-04-24 Claudio Bley <claudio.bley@gmail.com> (tiny change)
12452 * process.c (wait_reading_process_output): Check if GnuTLS
12453 buffered some data internally if no FDs are set for TLS
12456 * makefile.w32-in (OBJ2): Add gnutls.$(O).
12457 (LIBS): Link to USER_LIBS.
12458 ($(BLD)/gnutls.$(0)): New target.
12460 2011-04-24 Eli Zaretskii <eliz@gnu.org>
12462 * xdisp.c (handle_single_display_spec): Rename the
12463 display_replaced_before_p argument into display_replaced_p, to
12464 make it consistent with the commentary. Fix typos in the
12467 * textprop.c (syms_of_textprop): Remove dead code.
12468 (copy_text_properties): Delete obsolete commentary about an
12469 interface that was deleted long ago. Fix typos in the description
12472 * msdos.c (XMenuActivate, XMenuAddSelection): Adjust argument list
12473 to changes in oldXMenu/XMenu.h from 2011-04-16.
12474 <menu_help_message, prev_menu_help_message>: Constify.
12475 (IT_menu_make_room): menu->help_text is now `const char **';
12478 * msdos.h (XMenuActivate, XMenuAddSelection): Adjust prototypes
12479 to changes in oldXMenu/XMenu.h from 2011-04-16.
12480 (struct XMenu): Declare `help_text' `const char **'.
12482 * xfaces.c <Qunspecified>: Make extern again.
12484 * syntax.c: Include sys/types.h before including regex.h, as
12487 * doc.c (get_doc_string): Improve the format passed to `error'.
12489 * doprnt.c (doprnt): Improve commentary.
12491 * term.c (init_tty) [MSDOS]: Fix 1st argument to maybe_fatal.
12493 * Makefile.in (TAGS): Depend on $(M_FILE) and $(S_FILE), and scan
12496 * makefile.w32-in (globals.h): Add a dummy recipe, to make any
12497 changes in globals.h immediately force recompilation.
12498 (TAGS): Depend on $(CURDIR)/m/intel386.h and
12499 $(CURDIR)/s/ms-w32.h.
12500 (TAGS-gmake): Scan $(CURDIR)/m/intel386.h and $(CURDIR)/s/ms-w32.h.
12502 * character.c (Fchar_direction): Function deleted.
12503 (syms_of_character): Don't defsubr it.
12504 <char-direction-table>: Deleted.
12506 2011-04-23 Eli Zaretskii <eliz@gnu.org>
12508 Fix doprnt so it could be used again safely in `verror'. (Bug#8435)
12509 * doprnt.c: Include limits.h.
12510 (SIZE_MAX): New macro.
12511 (doprnt): Return a size_t value. 2nd arg is now size_t.
12512 Many local variables are now size_t instead of int or unsigned.
12513 Improve overflow protection. Support `l' modifier for integer
12514 conversions. Support %l conversion. Don't assume an EMACS_INT
12515 argument for integer conversions and for %c.
12517 * lisp.h (doprnt): Restore prototype.
12519 * makefile.w32-in ($(BLD)/callint.$(O)): Depend on
12520 $(SRC)/character.h.
12522 * Makefile.in (base_obj): Add back doprnt.o.
12524 * deps.mk (doprnt.o): Add back prerequisites.
12525 (callint.o): Depend on character.h.
12527 * eval.c (internal_lisp_condition_case): Include the handler
12528 representation in the error message.
12529 (verror): Call doprnt instead of vsnprintf. Fix an off-by-one bug
12530 when breaking from the loop.
12532 * xdisp.c (vmessage): Call doprnt instead of vsnprintf.
12534 * callint.c (Fcall_interactively): When displaying error message
12535 about invalid control letter, pass the character's codepoint, not
12536 a pointer to its multibyte form. Improve display of the character
12537 in octal and display also its hex code.
12539 * character.c (char_string): Use %x to display the (unsigned)
12540 codepoint of an invalid character, to avoid displaying a bogus
12543 * font.c (check_otf_features): Pass SDATA of SYMBOL_NAME to
12544 `error', not SYMBOL_NAME itself.
12546 * coding.c (Fencode_sjis_char, Fencode_big5_char): Use %c for
12547 character arguments to `error'.
12549 * charset.c (check_iso_charset_parameter): Fix incorrect argument
12550 to `error' in error message about FINAL_CHAR argument. Make sure
12551 FINAL_CHAR is a character, and use %c when it is passed as
12552 argument to `error'.
12554 2011-04-23 Eli Zaretskii <eliz@gnu.org>
12556 * s/ms-w32.h (localtime): Redirect to sys_localtime.
12558 * w32.c: Include <time.h>.
12559 (sys_localtime): New function.
12561 2011-04-23 Chong Yidong <cyd@stupidchicken.com>
12563 * xdisp.c (init_xdisp): Initialize echo_area_window (Bug#6451).
12565 * buffer.c (syms_of_buffer): Doc fix (Bug#6902).
12567 2011-04-23 Samuel Thibault <sthibault@debian.org> (tiny change)
12569 * sysdep.c (wait_for_termination): On GNU Hurd, kill returns -1 on
12570 zombies (Bug#8467).
12572 2011-04-19 Eli Zaretskii <eliz@gnu.org>
12574 * syntax.h (SETUP_SYNTAX_TABLE_FOR_OBJECT): Fix setting of
12575 gl_state.e_property when gl_state.object is Qt.
12577 * insdel.c (make_gap_larger): Remove limitation of buffer size
12580 2011-04-18 Chong Yidong <cyd@stupidchicken.com>
12582 * xdisp.c (lookup_glyphless_char_display)
12583 (produce_glyphless_glyph): Handle cons cell entry in
12584 glyphless-char-display.
12585 (Vglyphless_char_display): Document it.
12587 * term.c (produce_glyphless_glyph): Handle cons cell entry in
12588 glyphless-char-display.
12590 2011-04-17 Chong Yidong <cyd@stupidchicken.com>
12592 * xdisp.c (get_next_display_element): Remove unnecessary ifdefs.
12594 * termhooks.h (FRAME_WINDOW_P): Remove duplicated definitions.
12596 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): Add missing
12597 definition for no-X builds.
12599 2011-04-16 Paul Eggert <eggert@cs.ucla.edu>
12601 Static checks with GCC 4.6.0 and non-default toolkits.
12603 * s/sol2-6.h, s/unixware.h (PTY_TTY_NAME_SPRINTF): Protoize decl.
12605 * process.c (keyboard_bit_set): Define only if SIGIO.
12606 (send_process_trap): Mark it with NO_RETURN if it doesn't return.
12607 (send_process): Repair possible setjmp clobbering.
12609 * s/usg5-4-common.h (SETUP_SLAVE_PTY): Don't pass extra arg to 'fatal'.
12611 * eval.c: Include <stdio.h>, for vsnprintf on non-GNU/Linux hosts.
12613 * data.c (arith_error): Mark with NO_RETURN if it doesn't return.
12615 * alloc.c (bytes_used_when_full, SPARE_MEMORY, BYTES_USED):
12616 Define only if needed.
12618 * sysdep.c (_FILE_OFFSET_BITS): Make this hack even uglier
12619 by pacifying GCC about it. Maybe it's time to retire it?
12620 * xfaces.c (USG, __TIMEVAL__): Likewise.
12622 * dispextern.h (struct redisplay_interface): Rename param
12623 to avoid shadowing.
12624 * termhooks.h (struct terminal): Likewise.
12625 * xterm.c (xembed_send_message): Likewise.
12627 * insdel.c (make_gap_smaller): Define only if
12628 USE_MMAP_FOR_BUFFERS || REL_ALLOC || DOUG_LEA_MALLOC.
12630 * keyboard.c (read_char): Make a var volatile so longjmp won't clobber
12633 * emacs.c (MAX_HEAP_BSS_DIFF, my_edata): Move to where they're used,
12634 so that we aren't warned about unused symbols.
12636 * xfns.c (Fx_file_dialog): Rename local to avoid shadowing.
12638 * xdisp.c (x_produce_glyphs): Mark var as initialized (Bug#8512).
12640 * xfns.c (x_real_positions): Mark locals as initialized.
12642 * xmenu.c (xmenu_show): Don't use uninitialized vars.
12644 * xterm.c: Fix problems found by static analysis with other toolkits.
12645 (toolkit_scroll_bar_interaction): Define and use only if USE_X_TOOLKIT.
12646 (x_dispatch_event): Declare static if USE_GTK, and
12647 define if USE_GTK || USE_X_TOOLKIT.
12648 (SET_SAVED_BUTTON_EVENT): Define only if USE_X_TOOLKIT || USE_GTK.
12649 * xterm.h (x_dispatch_event): Extern only if USE_X_TOOLKIT.
12650 * xterm.c, xterm.h (x_mouse_leave): Bring this function back, but only
12651 if defined HAVE_MENUS && !defined USE_X_TOOLKIT && !defined USE_GTK.
12653 * xmenu.c (menu_help_callback): Pointer type fixes.
12654 Use const pointers when pointing at readonly data. Avoid pointer
12655 signedness clashes.
12656 (FALSE): Remove unused macro.
12657 (update_frame_menubar): Remove unused decl.
12659 * xfns.c (Fx_hide_tip): Move locals to avoid shadowing.
12661 * menu.c (push_submenu_start, push_submenu_end): Do not define unless
12662 USE_X_TOOLKIT || USE_GTK || HAVE_NS || defined HAVE_NTGUI.
12663 (single_menu_item): Rename local to avoid shadowing.
12665 * keyboard.c (make_lispy_event): Remove unused local var.
12667 * frame.c, frame.h (x_get_resource_string): Bring this back, but
12668 only if HAVE_X_WINDOWS && !USE_X_TOOLKIT.
12670 * bitmaps: Change bitmaps from unsigned char back to the X11
12671 compatible char. Avoid the old compiler warnings about
12672 out-of-range initializers by using, for example, '\xab' rather
12675 * xgselect.c (xgselect_initialize): Check vs interface
12676 even if ! (defined (USE_GTK) || defined (HAVE_GCONF)).
12678 * xmenu.c (xmenu_show): Rename parm to avoid shadowing.
12680 * xterm.c (x_create_toolkit_scroll_bar): Use const * for pointers
12681 to read-only memory.
12683 * fns.c (vector): Remove; this old hack is no longer needed.
12685 * xsmfns.c (create_client_leader_window): Rename shadowing arg.
12687 (gdk_x11_set_sm_client_id) [!USE_GTK]: Don't define.
12689 * xrdb.c (x_load_resources): Omit unused local.
12691 * xfns.c (free_frame_menubar, atof): Remove duplicate decls.
12692 (x_window): Rename locals to avoid shadowing.
12693 (USG): Use the kludged USG macro, to pacify gcc.
12695 * xterm.c (x_alloc_nearest_color_for_widget): Remove; unused.
12696 (x_term_init): Remove local to avoid shadowing.
12698 * xfns.c, xterm.c (_XEditResCheckMessages): Protoize decl.
12700 * xdisp.c, dispextern.h (set_vertical_scroll_bar): Now extern if
12701 USE_TOOLKIT_SCROLL_BARS && !USE_GTK, as xterm.c needs it then.
12703 2011-04-16 Eli Zaretskii <eliz@gnu.org>
12705 * gnutls.c (Fgnutls_boot): Don't pass Lisp_Object to `error'.
12707 Fix regex.c, syntax.c and friends for buffers > 2GB.
12708 * syntax.h (struct gl_state_s): Declare character position members
12711 * syntax.c (update_syntax_table): Declare 2nd argument EMACS_INT.
12713 * textprop.c (verify_interval_modification, interval_of):
12714 Declare arguments EMACS_INT.
12716 * intervals.c (adjust_intervals_for_insertion): Declare arguments
12719 * intervals.h (CHECK_TOTAL_LENGTH): Cast to EMACS_INT, not `int'.
12721 * indent.c (Fvertical_motion): Local variable it_start is now
12724 * regex.c (re_match, re_match_2, re_match_2_internal)
12725 (bcmp_translate, regcomp, regexec, print_double_string)
12726 (group_in_compile_stack, re_search, re_search_2, regex_compile)
12727 (re_compile_pattern, re_exec): Declare arguments and local
12728 variables `size_t' and `ssize_t' and return values `regoff_t', as
12730 (POP_FAILURE_REG_OR_COUNT) <pfreg>: Declare `long'.
12731 (CHECK_INFINITE_LOOP) <failure>: Declare `ssize_t'.
12732 <compile_stack_type>: `size' and `avail' are now `size_t'.
12734 * regex.h <regoff_t>: Use ssize_t, not int.
12735 (re_search, re_search_2, re_match, re_match_2): Arguments that
12736 specify buffer/string position and length are now ssize_t and
12737 size_t. Return type is regoff_t.
12739 2011-04-16 Ben Key <bkey76@gmail.com>
12741 * nsfont.m: Fixed bugs in ns_get_family and
12742 ns_descriptor_to_entity that were caused by using free to
12743 deallocate memory blocks that were allocated by xmalloc (via
12744 xstrdup). This caused Emacs to crash when compiled with
12745 XMALLOC_OVERRUN_CHECK defined (when Emacs was configured with
12746 --enable-checking=xmallocoverrun). xfree is now used to
12747 deallocate these memory blocks.
12749 2011-04-15 Paul Eggert <eggert@cs.ucla.edu>
12751 * sysdep.c (emacs_read): Remove unnecessary check vs MAX_RW_COUNT.
12753 emacs_write: Accept and return EMACS_INT for sizes.
12754 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html
12756 * gnutls.c, gnutls.h (emacs_gnutls_read, emacs_gnutls_write):
12757 Accept and return EMACS_INT.
12758 (emacs_gnutls_write): Return the number of bytes written on
12760 * sysdep.c, lisp.h (emacs_read, emacs_write): Likewise.
12761 (emacs_read, emacs_write): Remove check for negative size, as the
12762 Emacs source code has been audited now.
12763 * sysdep.c (MAX_RW_COUNT): New macro, to work around kernel bugs.
12764 (emacs_read, emacs_write): Use it.
12765 * process.c (send_process): Adjust to the new signatures of
12766 emacs_write and emacs_gnutls_write. Do not attempt to store
12767 a byte offset into an 'int'; it might overflow.
12768 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00483.html
12770 * sound.c: Don't assume sizes fit in 'int'.
12771 (struct sound_device.period_size, alsa_period_size):
12772 Return EMACS_INT, not int.
12773 (struct sound_device.write, vox_write, alsa_write):
12774 Accept EMACS_INT, not int.
12775 (wav_play, au_play): Use EMACS_INT to store sizes and to
12776 record read return values.
12778 2011-04-15 Ben Key <bkey76@gmail.com>
12780 * keyboard.c (Qundefined): Don't declare static since it is used
12782 * xfaces.c (Qbold, Qexpanded, Qitalic, Qcondensed): Don't declare
12783 static since they are used in nsfont.m.
12785 2011-04-15 Stefan Monnier <monnier@iro.umontreal.ca>
12787 * process.c (Qprocessp): Don't declare static.
12788 * lisp.h (Qprocessp): Declare again.
12790 2011-04-15 Juanma Barranquero <lekktu@gmail.com>
12792 * font.c (Qopentype): Don't make static (used from w32uniscribe.c).
12794 2011-04-14 Paul Eggert <eggert@cs.ucla.edu>
12796 Improve C-level modularity by making more things 'static'.
12798 Don't publish debugger-only interfaces to other modules.
12799 * lisp.h (safe_debug_print, debug_output_compilation_hack):
12800 (verify_bytepos, count_markers): Move decls to the only modules
12802 * region-cache.h (pp_cache): Likewise.
12803 * window.h (check_all_windows): Likewise.
12804 * marker.c, print.c, region-cache.c, window.c: Decls moved here.
12806 * sysdep.c (croak): Now static, if
12807 defined TIOCNOTTY || defined USG5 || defined CYGWIN.
12808 * syssignal.h (croak): Declare only if not static.
12810 * alloc.c (refill_memory_reserve): Now static if
12811 !defined REL_ALLOC || defined SYSTEM_MALLOC.
12812 * lisp.h (refill_memory_reserve): Declare only if not static.
12814 * xsettings.c, xsettings.h (xsettings_get_system_normal_font):
12815 Define only if USE_LUCID.
12817 * xrdb.c (x_customization_string, x_rm_string): Now static.
12819 * xmenu.c (x_menu_wait_for_event): Export only if USE_MOTIF.
12820 * xterm.h (x_menu_wait_for_event): Declare only if USE_MOTIF.
12822 * xdisp.c (draw_row_with_mouse_face): Now static.
12823 * dispextern.h (draw_row_with_mouse_fave): Remove decl.
12825 * window.h (check_all_windows): Mark externally visible.
12827 * window.c (window_deletion_count): Now static.
12829 * undo.c: Make symbols static if they're not exported.
12830 (last_undo_buffer, last_boundary_position, pending_boundary):
12833 * textprop.c (interval_insert_behind_hooks): Now static.
12834 (interval_insert_in_front_hooks): Likewise.
12836 * term.c: Make symbols static if they're not exported.
12837 (tty_turn_off_highlight, get_tty_terminal, max_frame_cols):
12838 (max_frame_lines, tty_set_terminal_modes):
12839 (tty_reset_terminal_modes, tty_turn_off_highlight):
12840 (get_tty_terminal): Now static.
12841 (term_mouse_moveto): Do not define if HAVE_WINDOW_SYSTEM.
12842 * termhooks.h (term_mouse_moveto): Do not declare if
12843 HAVE_WINDOW_SYSTEM.
12844 * dispextern.h (tty_set_terminal_modes, tty_reset_terminal_modes):
12845 (tty_turn_off_highlight, get_tty_terminal): Remove decls.
12847 * sysdep.c: Make symbols static if they're not exported.
12848 (emacs_get_tty, emacs_set_tty, old_fcntl_flags, old_fcntl_owner):
12850 (sigprocmask_set, full_mask): Remove; unused.
12851 (wait_debugging): Mark as visible.
12852 * syssignal.h (SIGFULLMASK, full_mask): Remove decls.
12853 * systty.h (emacs_get_tty, emacs_set_tty): Remove decls.
12855 * syntax.c (syntax_temp): Define only if !__GNUC__.
12857 * sound.c (current_sound_device, current_sound): Now static.
12859 * search.c (searchbufs, searchbuf_head): Now static.
12861 * scroll.c (scroll_cost): Remove; unused.
12862 * dispextern.h (scroll_cost): Remove decl.
12864 * region-cache.h (pp_cache): Mark as externally visible.
12866 * process.c: Make symbols static if they're not exported.
12867 (process_tick, update_tick, create_process, chan_process):
12868 (Vprocess_alist, proc_buffered_char, datagram_access):
12869 (fd_callback_data, send_process_frame, process_sent_to): Now static.
12870 (deactivate_process): Mark defn as static, as well as decl.
12871 * lisp.h (create_process): Remove decl.
12872 * process.h (chan_process, Vprocess_alist): Remove decls.
12874 * print.c: Make symbols static if they're not exported.
12875 (print_depth, new_backquote_output, being_printed, print_buffer):
12876 (print_buffer_size, print_buffer_pos, print_buffer_pos_byte):
12877 (print_interval, print_number_index, initial_stderr_stream):
12879 * lisp.h (Fprinc): Remove decl.
12880 (debug_output_compilation_hack): Mark as externally visible.
12882 * sysdep.c (croak): Move decl from here to syssignal.h.
12883 * syssignal.h (croak): Put it here, so the API can be checked when
12884 'croak' is called from dissociate_if_controlling_tty.
12886 * minibuf.c: Make symbols static if they're not exported.
12887 (minibuf_save_list, choose_minibuf_frame): Now static.
12888 * lisp.h (choose_minibuf_frame): Remove decl.
12890 * lisp.h (verify_bytepos, count_markers): Mark as externally visible.
12892 * lread.c: Make symbols static if they're not exported.
12893 (read_objects, initial_obarray, oblookup_last_bucket_number):
12895 (make_symbol): Remove; unused.
12896 * lisp.h (initial_obarray, make_symbol): Remove decls.
12898 * keyboard.c: Make symbols static if they're not exported.
12899 (single_kboard, recent_keys_index, total_keys, recent_keys):
12900 (this_command_key_count_reset, raw_keybuf, raw_keybuf_count):
12901 (this_single_command_key_start, echoing, last_auto_save):
12902 (read_key_sequence_cmd, dribble, recursive_edit_unwind):
12903 (command_loop, echo_now, keyboard_init_hook, help_char_p):
12904 (quit_throw_to_read_char, command_loop_2, top_level_1, poll_timer):
12905 (Vlispy_mouse_stem, double_click_count):
12907 (force_auto_save_soon): Define only if SIGDANGER.
12908 (ignore_mouse_drag_p): Now static if
12909 !defined HAVE_WINDOW_SYSTEM || defined USE_GTK || defined HAVE_NS.
12910 (print_help): Remove; unused.
12911 (stop_character, last_timer_event): Mark as externally visible.
12912 * keyboard.h (ignore_mouse_drag_p): Declare only if
12913 defined HAVE_WINDOW_SYSTEM && !defined USE_GTK && !defined HAVE_NS.
12914 (echo_now, help_char_p, quit_throw_to_read_char): Remove decls.
12915 * lisp.h (echoing): Remove decl.
12916 (force_auto_save_soon): Declare only if SIGDANGER.
12917 * xdisp.c (redisplay_window): Simplify code, to make it more
12918 obvious that ignore_mouse_drag_p is not accessed if !defined
12919 USE_GTK && !defined HAVE_NS.
12921 * intervals.c: Make symbols static if they're not exported.
12922 (merge_properties_sticky, merge_interval_right, delete_interval):
12924 * intervals.h (merge_interval_right, delete_interval): Remove decls.
12926 * insdel.c: Make symbols static if they're not exported.
12927 However, leave prepare_to_modify_buffer alone. It's never
12928 called from outside this function, but that appears to be a bug.
12929 (combine_after_change_list, combine_after_change_buffer):
12930 (adjust_after_replace, signal_before_change): Now static.
12931 (adjust_after_replace_noundo): Remove; unused.
12932 * lisp.h (adjust_after_replace, adjust_after_replace_noundo):
12933 (signal_before_change): Remove decls.
12935 * indent.c (val_compute_motion, val_vmotion): Now static.
12937 * image.c: Make symbols static if they're not exported.
12938 * dispextern.h (x_create_bitmap_from_xpm_data): Do not declare
12940 * image.c (x_create_bitmap_from_xpm_data): Do not define if USE_GTK.
12941 (xpm_color_cache, ct_table, ct_colors_allocated): Now static.
12943 * fringe.c (standard_bitmaps): Now static.
12944 (max_used_fringe_bitmap): Now static, unless HAVE_NS.
12946 * frame.c: Make symbols static if they're not exported.
12947 (x_report_frame_params, make_terminal_frame): Now static.
12948 (get_frame_param): Now static, unless HAVE_NS.
12949 (x_fullscreen_adjust): Define if WINDOWSNT, not if HAVE_WINDOW_SYSTEM.
12950 (x_get_resource_string): Remove; not used.
12951 * frame.h (make_terminal_frame, x_report_frame_params):
12952 (x_get_resource_string); Remove decls.
12953 (x_fullscreen_adjust): Declare only if WINDOWSNT.
12954 * lisp.h (get_frame_param): Declare only if HAVE_NS.
12956 * font.c, fontset.c: Make symbols static if they're not exported.
12957 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): New macro.
12958 (FACE_SUITABLE_FOR_CHAR_P): Use it.
12959 * font.c (font_close_object): Now static.
12960 * font.h (font_close_object): Remove.
12961 * fontset.c (FONTSET_OBJLIST): Remove.
12962 (free_realized_fontset) #if-0 the body, which does nothing.
12963 (face_suitable_for_char_p): #if-0, as it's never called.
12964 * fontset.h (face_suitable_for_char_p): Remove decl.
12965 * xfaces.c (face_at_string_position):
12966 Use FACE_SUITABLE_FOR_ASCII_CHAR_P, not FACE_SUITABLE_FOR_CHAR_P,
12967 since 0 is always ASCII.
12969 * fns.c (weak_hash_tables): Now static.
12971 * fileio.c: Make symbols static if they're not exported.
12972 (auto_saving, auto_save_mode_bits, auto_save_error_occurred):
12973 (Vwrite_region_annotation_buffers): Now static.
12975 * eval.c: Make symbols static if they're not exported.
12976 (backtrace_list, lisp_eval_depth, when_entered_debugger): Now static.
12977 * lisp.h (backtrace_list): Remove decl.
12979 * emacs.c: Make symbols static if they're not exported.
12980 (malloc_state_ptr, malloc_using_checking, syms_of_emacs):
12981 (fatal_error_code, fatal_error_signal_hook, standard_args):
12983 (fatal_error_signal): Now static, unless FLOAT_CATCH_SIGKILL.
12984 (DEFINE_DUMMY_FUNCTION): Mark function as externally visible.
12985 (__CTOR_LIST__, __DTOR_LIST__): Now externally visible.
12986 * lisp.h (fatal_error_signal_hook): Remove decl.
12987 (fatal_error_signal): Declare only if FLOAT_CATCH_SIGKILL.
12989 * editfns.c: Move a (normally-unused) function to its only use.
12990 * editfns.c, lisp.h (get_operating_system_release): Remove.
12991 * process.c (init_process) [DARWIN_OS]: Do it inline, as it is not
12992 worth the hassle of breaking this out.
12994 * xterm.c: Make symbols static if they're not exported.
12995 (x_raise_frame, x_lower_frame, x_wm_set_window_state):
12996 (x_wm_set_icon_pixmap, x_initialize, XTread_socket_fake_io_error):
12997 (x_destroy_window, x_delete_display):
12999 (x_dispatch_event): Now static if ! (USE_MOTIF || USE_X_TOOLKIT).
13000 (x_mouse_leave): Remove; unused.
13001 * xterm.h (x_display_info_for_name, x_raise_frame, x_lower_frame):
13002 (x_destroy_window, x_wm_set_window_state, x_wm_set_icon_pixmap):
13003 (x_delete_display, x_initialize, x_set_border_pixel, x_screen_planes):
13005 (x_mouse_leave): Declare only if WINDOWSNT.
13006 (x_dispatch_event): Declare only if USE_MOTIF or USE_X_TOOLKIT.
13007 (xic_create_fontsetname): Declare only if HAVE_X_WINDOWS &&
13010 * ftxfont.c: Make symbols static if they're not exported.
13011 (ftxfont_driver): Export only if !defined HAVE_XFT && def8ined
13013 * font.h (ftxfont_driver): Likewise.
13015 * xfns.c: Make symbols static if they're not exported.
13016 (x_last_font_name, x_display_info_for_name):
13017 (x_set_foreground_color, x_set_background_color, x_set_mouse_color):
13018 (x_set_cursor_color, x_set_border_pixel, x_set_border_color):
13019 (x_set_cursor_type, x_set_icon_type, x_set_icon_name):
13020 (x_set_scroll_bar_foreground, x_set_scroll_bar_background):
13021 (x_explicitly_set_name, x_set_title, xic_defaut_fontset, tip_timer):
13022 (last_show_tip_args): Now static.
13023 (xic_defaut_fontset, xic_create_fontsetname): Define only if
13024 defined HAVE_X_WINDOWS && defined USE_X_TOOLKIT
13025 (x_screen_planes): Remove; unused.
13026 * dispextern.h (x_screen_planes): Remove decl.
13028 * dispnew.c: Make symbols static if they're not exported.
13029 * dispextern.h (redraw_garbaged_frames, scrolling):
13030 (increment_row_positions): Remove.
13031 * dispnew.c (new_glyph_matrix, increment_row_positions, scrolling):
13032 (delayed_size_change, glyph_matrix_count, glyph_pool_count):
13034 (redraw_garbaged_frames): Remove; unused.
13036 * xfaces.c: Make symbols static if they're not exported.
13037 * dispextern.h (ascii_face_of_lisp_face, free_realized_face):
13039 * xterm.h (defined_color): Remove decls.
13040 (x_free_dpy_colors): Declare only if USE_X_TOOLKIT.
13041 * xfaces.c (tty_suppress_bold_inverse_default_colors_p):
13042 (menu_face_changed_default, defined_color, free_realized_face):
13043 (x_free_dpy_colors): Define only if USE_X_TOOLKIT.
13044 (ascii_face_of_lisp_face): Remove; unused.
13046 * xdisp.c: Make symbols static if they're not exported.
13047 * dispextern.h (scratch_glyph_row, window_box_edges):
13048 (glyph_to_pixel_coords, set_cursor_from_row):
13049 (get_next_display_element, set_iterator_to_next):
13050 (highlight_trailing_whitespace, frame_to_window_pixel_xy):
13051 (show_mouse_face): Remove decls
13052 * frame.h (message_buf_print): Likewise.
13053 * lisp.h (pop_message, set_message, check_point_in_composition):
13055 * xterm.h (set_vertical_scroll_bar): Likewise.
13056 * xdisp.c (list_of_error, Vmessage_stack, line_number_displayed):
13057 (message_buf_print, scratch_glyph_row, displayed_buffer):
13058 (set_iterator_to_next, pop_message, set_message, set_cursor_from_row):
13059 (get_next_display_element, show_mouse_face, window_box_edges):
13060 (frame_to_window_pixel_xy, check_point_in_composition):
13061 (set_vertical_scroll_bar, highlight_trailing_whitespace): Now static.
13062 (glyph_to_pixel_coords): Remove; unused.
13064 * dired.c (file_name_completion): Now static.
13066 * dbusbind.c (xd_in_read_queued_messages): Now static.
13068 * lisp.h (circular_list_error, FOREACH): Remove; unused.
13069 * data.c (circular_list_error): Remove.
13071 * commands.h (last_point_position, last_point_position_buffer):
13072 (last_point_position_window): Remove decls.
13073 * keyboard.c: Make these variables static.
13075 * coding.h (coding, code_convert_region, encode_coding_gap):
13077 * coding.c (Vsjis_coding_system, Vbig5_coding_system):
13078 (iso_code_class, detect_coding, code_convert_region): Now static.
13079 (encode_coding_gap): Remove; unused.
13081 * chartab.c (chartab_chars, chartab_bits): Now static.
13083 * charset.h (charset_iso_8859_1): Remove decl.
13084 * charset.c (charset_iso_8859_1, charset_emacs, map_charset_for_dump):
13087 * ccl.h (check_ccl_update, Vccl_program_table): Remove decls.
13088 * ccl.c (Vccl_program_table): Now static.
13089 (check_ccl_update): Remove; unused.
13091 * category.c (SET_CATEGORY_SET, set_category_set): Move here.
13092 * category.h: ... from here.
13093 * category.c (check_category_table, set_category_set): Now static.
13095 * casetab.c (Vascii_upcase_table, Vascii_eqv_table): Now static.
13096 * lisp.h: Remove these decls.
13098 * buffer.c (buffer_count): Remove unused var.
13100 * bidi.c (bidi_dump_cached_states): Mark as externally visible,
13101 so that it's not optimized away.
13102 (bidi_ignore_explicit_marks_for_paragraph_level): Likewise.
13103 * dispextern.h (bidi_dump_cached_states): Remove, since it's
13104 exported only to the debugger.
13106 * atimer.c (alarm_signal_handler, run_all_atimers): Now static.
13107 * atimer.h (run_all_atimers): Remove; not exported.
13109 font.c: Make copy_font_spec and merge_font_spec ordinary C functions.
13110 * font.c (copy_font_spec): Rename from Fcopy_font_spec, since it
13111 was inaccessible from Lisp.
13112 (merge_font_spec): Likewise, renaming from Fmerge_font_spec.
13113 * font.c, font.h, fontset.c, xfaces.c, xfont.c: Change all uses.
13115 alloc.c: Import and export fewer symbols, and remove unused items.
13116 * lisp.h (suppress_checking, die): Declare only if ENABLE_CHECKING
13118 (suppress_checking): Add EXTERNALLY_VISIBLE attribute, so that
13119 it's not optimized away by whole-program optimization.
13120 (message_enable_multibyte, free_misc): Remove.
13121 (catchlist, handlerlist, mark_backtrace):
13122 Declare only if BYTE_MARK_STACK.
13123 (mark_byte_stack): Likewise, fixing a ifdef-vs-if typo.
13124 * alloc.c (pure): Export only if VIRT_ADDR_VARIES is defined.
13125 (message_enable_multibyte): Remove decl.
13126 (free_misc, interval_free_list, float_block, float_block_index):
13127 (n_float_blocks, float_free_list, cons_block, cons_block_index):
13128 (cons_free_list, last_marked_index):
13130 (suppress_checking, die): Define only if ENABLE_CHECKING is defined.
13131 * eval.c (catchlist, handlerlist): Export only if BYTE_MARK_STACK.
13132 (mark_backtrace): Define only if BYTE_MARK_STACK.
13133 * xdisp.c (message_enable_multibyte): Now static.
13135 Declare Lisp_Object Q* variables to be 'static' if not exported.
13136 This makes it easier for human readers (and static analyzers)
13137 to see whether these variables are used from other modules.
13138 * alloc.c, buffer.c, bytecode.c, callint.c, casetab.c, category.c:
13139 * ccl.c, character.c, charset.c, cmds.c, coding.c, composite.c:
13140 * data.c, dbusbind.c, dired.c, editfns.c, eval.c, fileio.c, fns.c:
13141 * font.c, frame.c, fringe.c, ftfont.c, image.c, keyboard.c, keymap.c:
13142 * lread.c, macros.c, minibuf.c, print.c, process.c, search.c:
13143 * sound.c, syntax.c, textprop.c, window.c, xdisp.c, xfaces.c, xfns.c:
13144 * xmenu.c, xselect.c:
13145 Declare Q* vars static if they are not used in other modules.
13146 * ccl.h, character.h, charset.h, coding.h, composite.h, font.h:
13147 * frame.h, intervals.h, keyboard.h, lisp.h, process.h, syntax.h:
13148 Remove decls of unexported vars.
13149 * keyboard.h (EVENT_HEAD_UNMODIFIED): Remove now-unused macro.
13151 * lisp.h (DEFINE_FUNC): Make sname 'static'.
13153 Make Emacs functions such as Fatom 'static' by default.
13154 This makes it easier for human readers (and static analyzers)
13155 to see whether these functions can be called from other modules.
13156 DEFUN now defines a static function. To make the function external
13157 so that it can be used in other C modules, use the new macro DEFUE.
13158 * lisp.h (Funibyte_char_to_multibyte, Fsyntax_table_p):
13159 (Finit_image_library):
13160 (Feval_region, Fbacktrace, Ffetch_bytecode, Fswitch_to_buffer):
13161 (Ffile_executable_p, Fmake_symbolic_link, Fcommand_execute):
13162 (Fget_process, Fdocumentation_property, Fbyte_code, Ffile_attributes):
13163 Remove decls, since these functions are now static.
13164 (Funintern, Fget_internal_run_time): New decls, since these functions
13165 were already external.
13167 * alloc.c, buffer.c, callint.c, callproc.c, casefiddle.c, casetab.c:
13168 * ccl.c, character.c, chartab.c, cmds.c, coding.c, data.c, dispnew.c:
13169 * doc.c, editfns.c, emacs.c, eval.c, fileio.c, filelock.c, floatfns.c:
13170 * fns.c, font.c, fontset.c, frame.c, image.c, indent.c:
13171 * keyboard.c, keymap.c, lread.c:
13172 * macros.c, marker.c, menu.c, minibuf.c, print.c, process.c, search.c:
13173 * syntax.c, term.c, terminal.c, textprop.c, undo.c:
13174 * window.c, xdisp.c, xfaces.c, xfns.c, xmenu.c, xsettings.c:
13175 Mark functions with DEFUE instead of DEFUN,
13176 if they are used in other modules.
13177 * buffer.c (Fset_buffer_major_mode, Fdelete_overlay): New forward
13178 decls for now-static functions.
13179 * buffer.h (Fdelete_overlay): Remove decl.
13180 * callproc.c (Fgetenv_internal): Mark as internal.
13181 * composite.c (Fremove_list_of_text_properties): Remove decl.
13182 (Fcomposition_get_gstring): New forward static decl.
13183 * composite.h (Fcomposite_get_gstring): Remove decl.
13184 * dired.c (Ffile_attributes): New forward static decl.
13185 * doc.c (Fdocumntation_property): New forward static decl.
13186 * eval.c (Ffetch_bytecode): New forward static decl.
13187 (Funintern): Remove extern decl; now in .h file where it belongs.
13188 * fileio.c (Fmake_symbolic_link): New forward static decl.
13189 * image.c (Finit_image_library): New forward static decl.
13190 * insdel.c (Fcombine_after_change_execute): Make forward decl static.
13191 * intervals.h (Fprevious_property_change):
13192 (Fremove_list_of_text_properties): Remove decls.
13193 * keyboard.c (Fthis_command_keys): Remove decl.
13194 (Fcommand_execute): New forward static decl.
13195 * keymap.c (Flookup_key): New forward static decl.
13196 (Fcopy_keymap): Now static.
13197 * keymap.h (Flookup_key): Remove decl.
13198 * process.c (Fget_process): New forward static decl.
13199 (Fprocess_datagram_address): Mark as internal.
13200 * syntax.c (Fsyntax_table_p): New forward static decl.
13201 (skip_chars): Remove duplicate decl.
13202 * textprop.c (Fprevious_property_change): New forward static decl.
13203 * window.c (Fset_window_fringes, Fset_window_scroll_bars):
13205 (Fset_window_margins, Fset_window_vscroll): New forward static decls.
13206 * window.h (Fset_window_vscroll, Fset_window_margins): Remove decls.
13208 * editfns.c (Fformat): Remove unreachable code.
13210 2011-04-14 Andreas Schwab <schwab@linux-m68k.org>
13212 * fileio.c (Finsert_file_contents): Fix typo in 2005-05-13
13215 2011-04-13 Eli Zaretskii <eliz@gnu.org>
13217 * xdisp.c (handle_invisible_prop): Don't call bidi_paragraph_init
13218 when at ZV. (Bug#8487)
13220 2011-04-12 Andreas Schwab <schwab@linux-m68k.org>
13222 * charset.c (Fclear_charset_maps): Use xfree instead of free.
13224 * keyboard.c (parse_tool_bar_item): Likewise.
13225 * sound.c (sound_cleanup, alsa_close): Likewise.
13226 * termcap.c (tgetent): Likewise.
13227 * xfns.c (x_default_font_parameter): Likewise.
13228 * xsettings.c (read_and_apply_settings): Likewise.
13230 * alloc.c (overrun_check_malloc, overrun_check_realloc)
13231 (overrun_check_free): Protoize.
13233 2011-04-12 Paul Eggert <eggert@cs.ucla.edu>
13235 * sysdep.c (emacs_read, emacs_write): Check for negative sizes
13236 since callers should never pass a negative size.
13237 Change the signature to match that of plain 'read' and 'write'; see
13238 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00397.html>.
13239 * lisp.h: Update prototypes of emacs_write and emacs_read.
13241 2011-04-11 Eli Zaretskii <eliz@gnu.org>
13243 * xdisp.c (redisplay_window): Don't try to determine the character
13244 position of the scroll margin if the window start point w->startp
13245 is outside the buffer's accessible region. (Bug#8468)
13247 2011-04-10 Eli Zaretskii <eliz@gnu.org>
13249 Fix write-region and its subroutines for buffers > 2GB.
13250 * fileio.c (a_write, e_write): Modify declaration of arguments and
13251 local variables to support buffers larger than 2GB.
13252 (Fcopy_file): Use EMACS_INT for return value of emacs_read.
13254 * sysdep.c (emacs_write, emacs_read): Use ssize_t for last
13255 argument, local variables, and return value.
13257 * lisp.h: Update prototypes of emacs_write and emacs_read.
13259 * sound.c (vox_write): Use ssize_t for return value of emacs_write.
13261 2011-04-10 Paul Eggert <eggert@cs.ucla.edu>
13263 * xdisp.c (vmessage): Use memchr, not strnlen, which some hosts lack.
13265 Fix more problems found by GCC 4.6.0's static checks.
13267 * xdisp.c (vmessage): Use a better test for character truncation.
13269 * charset.c (load_charset_map): <, not <=, for optimization,
13270 and to avoid potential problems with integer overflow.
13271 * chartab.c (sub_char_table_set_range, char_table_set_range): Likewise.
13272 * casetab.c (set_identity, shuffle): Likewise.
13273 * editfns.c (Fformat): Likewise.
13274 * syntax.c (skip_chars): Likewise.
13276 * xmenu.c (set_frame_menubar): Allocate smaller local vectors.
13277 This also lets GCC 4.6.0 generate slightly better loop code.
13279 * callint.c (Fcall_interactively): <, not <=, for optimization.
13280 (Fcall_interactively): Count the number of arguments produced,
13281 not the number of arguments given. This is simpler and lets GCC
13282 4.6.0 generate slightly better code.
13284 * ftfont.c: Distingish more carefully between FcChar8 and char.
13285 The previous code passed unsigned char * to a functions like
13286 strlen and xstrcasecmp that expect char *, which does not
13287 conform to the C standard.
13288 (get_adstyle_property, ftfont_pattern_entity): Use FcChar8 for
13289 arguments to FcPatternGetString, and explicitly cast FcChar8 * to
13290 char * when the C standard requires it.
13292 * keyboard.c (read_char): Remove unused var.
13294 * eval.c: Port to Windows vsnprintf (Bug#8435).
13295 Include <limits.h>.
13296 (SIZE_MAX): Define if the headers do not.
13297 (verror): Do not give up if vsnprintf returns a negative count.
13298 Instead, grow the buffer. This ports to Windows vsnprintf, which
13299 does not conform to C99. Problem reported by Eli Zaretskii.
13300 Also, simplify the allocation scheme, by avoiding the need for
13301 calling realloc, and removing the ALLOCATED variable.
13303 * eval.c (verror): Initial buffer size is 4000 (not 200) bytes.
13305 Remove invocations of doprnt, as Emacs now uses vsnprintf.
13306 But keep the doprint source code for now, as we might revamp it
13307 and use it again (Bug#8435).
13308 * lisp.h (doprnt): Remove.
13309 * Makefile.in (base_obj): Remove doprnt.o.
13310 * deps.mk (doprnt.o): Remove.
13312 error: Print 32- and 64-bit integers portably (Bug#8435).
13313 Without this change, on typical 64-bit hosts error ("...%d...", N)
13314 was used to print both 32- and 64-bit integers N, which relied on
13315 undefined behavior.
13316 * lisp.h, m/amdx86-64.h, m/ia64.h, m/ibms390x.h (pEd): New macro.
13317 * lisp.h (error, verror): Mark as printf-like functions.
13318 * eval.c (verror): Use vsnprintf, not doprnt, to do the real work.
13319 Report overflow in size calculations when allocating printf buffer.
13320 Do not truncate output string at its first null byte.
13321 * xdisp.c (vmessage): Use vsnprintf, not doprnt, to do the real work.
13322 Truncate the output at a character boundary, since vsnprintf does not
13324 * charset.c (check_iso_charset_parameter): Convert internal
13325 character to string before calling 'error', since %c now has the
13327 * coding.c (Fdecode_sjis_char, Fdecode_big5_char): Avoid int
13328 overflow when computing char to be passed to 'error'. Do not
13329 pass Lisp_Object to 'error'; pass the integer instead.
13330 * nsfns.m (Fns_do_applescript): Use int, not long, since it's
13331 formatted with plain %d.
13333 * eval.c (internal_lisp_condition_case): Don't pass spurious arg.
13335 * keyboard.c (access_keymap_keyremap): Print func name, not garbage.
13337 * coding.c (Fdecode_sjis_char): Don't assume CODE fits in int.
13339 * xterm.c (x_catch_errors): Remove duplicate declaration.
13341 * term.c (maybe_fatal): Mark its 3rd arg as a printf format, too.
13343 * xdisp.c, lisp.h (message_nolog): Remove; unused.
13345 2011-04-10 Jim Meyering <meyering@redhat.com>
13347 use ssize_t and size_t for read- and write-like emacs_gnutls_* functions
13348 * gnutls.c (emacs_gnutls_read): Adjust signature to be more read-like:
13349 return ssize_t not "int", and use size_t as the buffer length.
13350 (emacs_gnutls_write): Likewise, and make the buffer pointer "const".
13351 * gnutls.h: Update declarations.
13352 * process.c (read_process_output): Use ssize_t, to match.
13353 (send_process): Likewise.
13355 2011-04-09 Chong Yidong <cyd@stupidchicken.com>
13357 * image.c (Fimagemagick_types): Doc fix, and comment cleanup.
13359 2011-04-09 Chong Yidong <cyd@stupidchicken.com>
13361 * ftfont.c (get_adstyle_property, ftfont_pattern_entity):
13362 Use unsigned char, to match FcChar8 type definition.
13364 * xterm.c (handle_one_xevent):
13365 * xmenu.c (create_and_show_popup_menu):
13366 * xselect.c (x_decline_selection_request)
13367 (x_reply_selection_request): Avoid type-punned deref of X events.
13369 2011-04-09 Eli Zaretskii <eliz@gnu.org>
13371 Fix some uses of `int' instead of EMACS_INT.
13372 * search.c (string_match_1, fast_string_match)
13373 (fast_c_string_match_ignore_case, fast_string_match_ignore_case)
13374 (scan_buffer, find_next_newline_no_quit)
13375 (find_before_next_newline, search_command, Freplace_match)
13376 (Fmatch_data): Make some `int' variables be EMACS_INT.
13378 * xdisp.c (display_count_lines): 3rd argument and return value now
13379 EMACS_INT. All callers changed.
13380 (pint2hrstr): Last argument is now EMACS_INT.
13382 * coding.c (detect_coding_utf_8, detect_coding_emacs_mule)
13383 (detect_coding_iso_2022, detect_coding_sjis, detect_coding_big5)
13384 (detect_coding_ccl, detect_coding_charset, decode_coding_utf_8)
13385 (decode_coding_utf_16, decode_coding_emacs_mule)
13386 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5)
13387 (decode_coding_ccl, decode_coding_charset)
13388 <consumed_chars, consumed_chars_base>: Declare EMACS_INT.
13389 (decode_coding_iso_2022, decode_coding_emacs_mule)
13390 (decode_coding_sjis, decode_coding_big5, decode_coding_charset)
13391 <char_offset, last_offset>: Declare EMACS_INT.
13392 (encode_coding_utf_8, encode_coding_utf_16)
13393 (encode_coding_emacs_mule, encode_invocation_designation)
13394 (encode_designation_at_bol, encode_coding_iso_2022)
13395 (encode_coding_sjis, encode_coding_big5, encode_coding_ccl)
13396 (encode_coding_raw_text, encode_coding_charset) <produced_chars>:
13398 (ASSURE_DESTINATION): Declare more_bytes EMACS_INT.
13399 (encode_invocation_designation): Last argument P_NCHARS is now
13401 (decode_eol): Declare pos_byte, pos, and pos_end EMACS_INT.
13402 (produce_chars): from_nchars and to_nchars are now EMACS_INT.
13404 * coding.h (struct coding_system) <head_ascii>: Declare EMACS_INT.
13407 * ccl.c (Fccl_execute_on_string): Declare some variables
13410 2011-04-08 Samuel Thibault <sthibault@debian.org> (tiny change)
13412 * term.c (init_tty): Fix incorrect ifdef placement (Bug#8450).
13414 2011-03-19 Christoph Scholtes <cschol2112@googlemail.com>
13416 * process.c (Fformat_network_address): Doc fix.
13418 2011-04-08 T.V. Raman <tv.raman.tv@gmail.com> (tiny change)
13420 * xml.c (parse_region): Avoid creating spurious whitespace nodes.
13422 2011-04-08 Chong Yidong <cyd@stupidchicken.com>
13424 * keyboard.c (read_char): Call Lisp function help-form-show,
13425 instead of using internal_with_output_to_temp_buffer.
13426 (Qhelp_form_show): New var.
13427 (syms_of_keyboard): Use DEFSYM macro.
13429 * print.c (internal_with_output_to_temp_buffer): Function deleted.
13431 * lisp.h (internal_with_output_to_temp_buffer): Remove prototype.
13433 2011-04-06 Chong Yidong <cyd@stupidchicken.com>
13435 * process.c (Flist_processes): Remove to Lisp.
13436 (list_processes_1): Delete.
13438 2011-04-06 Eli Zaretskii <eliz@gnu.org>
13440 * msdos.c (careadlinkat, careadlinkatcwd): MS-DOS replacements.
13442 * w32.c (careadlinkat, careadlinkatcwd): New always-fail stubs.
13444 2011-04-06 Paul Eggert <eggert@cs.ucla.edu>
13446 Fix more problems found by GCC 4.6.0's static checks.
13448 * xmenu.c (Fx_popup_dialog): Don't assume string is free of formats.
13450 * menu.c (Fx_popup_menu): Don't assume error_name lacks printf formats.
13452 * lisp.h (message, message_nolog, fatal): Mark as printf-like.
13454 * xdisp.c (vmessage): Mark as a printf-like function.
13456 * term.c (vfatal, maybe_fatal): Mark as printf-like functions.
13458 * sound.c (sound_warning): Don't crash if arg contains a printf format.
13460 * image.c (tiff_error_handler, tiff_warning_handler): Mark as
13461 printf-like functions.
13462 (tiff_load): Add casts to remove these marks before passing them
13463 to system-supplied API.
13465 * eval.c (Fsignal): Remove excess argument to 'fatal'.
13467 * coding.c (EMIT_ONE_BYTE, EMIT_TWO_BYTES): Use unsigned, not int.
13468 This avoids several warnings with gcc -Wstrict-overflow.
13469 (DECODE_COMPOSITION_RULE): If the rule is invalid, goto invalid_code
13470 directly, rather than having caller test rule sign. This avoids
13471 some unnecessary tests.
13472 * composite.h (COMPOSITION_ENCODE_RULE_VALID): New macro.
13473 (COMPOSITION_ENCODE_RULE): Arguments now must be valid. This
13474 affects only one use, in DECODE_COMPOSITION_RULE, which is changed.
13476 * xfont.c (xfont_text_extents): Remove var that was set but not used.
13477 (xfont_open): Avoid unnecessary tests.
13479 * composite.c (composition_gstring_put_cache): Use unsigned integer.
13481 * composite.h, composite.c (composition_gstring_put_cache):
13482 Use EMACS_INT, not int, for length.
13484 * composite.h (COMPOSITION_DECODE_REFS): New macro,
13485 breaking out part of COMPOSITION_DECODE_RULE.
13486 (COMPOSITION_DECODE_RULE): Use it.
13487 * composite.c (get_composition_id): Remove unused local vars,
13488 by using the new macro.
13490 * textprop.c (set_text_properties_1): Change while to do-while,
13491 since the condition is always true at first.
13493 * intervals.c (graft_intervals_into_buffer): Mark var as used.
13494 (interval_deletion_adjustment): Return unsigned value.
13497 * process.c (list_processes_1, create_pty, read_process_output):
13498 (exec_sentinel): Remove vars that were set but not used.
13499 (create_pty): Remove unnecessary "volatile"s.
13500 (Fnetwork_interface_info): Avoid possibility of int overflow.
13501 (read_process_output): Do adaptive read buffering even if carryover.
13502 (read_process_output): Simplify nbytes computation if buffered.
13504 * bytecode.c (exec_byte_code): Rename local to avoid shadowing.
13506 * syntax.c (scan_words): Remove var that was set but not used.
13507 (update_syntax_table): Use unsigned instead of int.
13509 * lread.c (lisp_file_lexically_bound_p): Use ints rather than endptrs.
13510 (lisp_file_lexically_bound_p, read1): Use unsigned instead of int.
13511 (safe_to_load_p): Make the end-of-loop test the inverse of the in-loop.
13513 * print.c (print_error_message): Avoid int overflow.
13515 * font.c (font_list_entities): Redo for clarity,
13516 so that reader need not know FONT_DPI_INDEX + 1 == FONT_SPACING_INDEX.
13518 * font.c (font_find_for_lface, Ffont_get_glyphs): Remove unused vars.
13519 (font_score): Avoid potential overflow in diff calculation.
13521 * fns.c (substring_both): Remove var that is set but not used.
13522 (sxhash): Redo loop for clarity and to avoid wraparound warning.
13524 * eval.c (funcall_lambda): Rename local to avoid shadowing.
13526 * alloc.c (mark_object_loop_halt, mark_object): Use size_t, not int.
13527 Otherwise, GCC 4.6.0 optimizes the loop check away since the check
13528 can always succeed if overflow has undefined behavior.
13530 * search.c (boyer_moore, wordify): Remove vars set but not used.
13531 (wordify): Omit three unnecessary tests.
13533 * indent.c (MULTIBYTE_BYTES_WIDTH): Don't compute wide_column.
13534 All callers changed. This avoids the need for an unused var.
13536 * casefiddle.c (casify_region): Remove var that is set but not used.
13538 * dired.c (file_name_completion): Remove var that is set but not used.
13540 * fileio.c (Finsert_file_contents): Make EOF condition clearer.
13542 * fileio.c (Finsert_file_contents): Avoid signed integer overflow.
13543 (Finsert_file_contents): Remove unnecessary code checking fd.
13545 * minibuf.c (read_minibuf_noninteractive): Use size_t for sizes.
13546 Check for integer overflow on size calculations.
13548 * buffer.c (Fprevious_overlay_change): Remove var that is set
13551 * keyboard.c (menu_bar_items, read_char_minibuf_menu_prompt):
13552 Remove vars that are set but not used.
13553 (timer_check_2): Don't assume timer-list and idle-timer-list are lists.
13554 (timer_check_2): Mark vars as initialized.
13556 * gtkutil.c (xg_get_file_with_chooser): Mark var as initialized.
13558 * image.c (lookup_image): Remove var that is set but not used.
13559 (xbm_load): Use parse_p, for gcc -Werror=unused-but-set-variable.
13561 * fontset.c (Finternal_char_font, Ffontset_info): Remove vars
13562 that are set but not used.
13564 * xfns.c (make_invisible_cursor): Don't return garbage
13565 if XCreateBitmapFromData fails (Bug#8410).
13567 * xselect.c (x_get_local_selection, x_handle_property_notify):
13568 Remove vars that are set but not used.
13570 * xfns.c (x_create_tip_frame): Remove var that is set but not used.
13571 (make_invisible_cursor): Initialize a possibly-uninitialized variable.
13573 * xterm.c (x_scroll_bar_to_input_event) [!USE_GTK]:
13574 Remove var that is set but not used.
13575 (scroll_bar_windows_size): Now size_t, not int.
13576 (x_send_scroll_bar_event): Use size_t, not int, for sizes.
13577 Check for overflow.
13579 * xfaces.c (realize_named_face): Remove vars that are set but not used.
13580 (map_tty_color) [!defined MSDOS]: Likewise.
13582 * term.c (tty_write_glyphs): Use size_t; this avoids overflow warning.
13584 * coding.c: Remove vars that are set but not used.
13585 (DECODE_COMPOSITION_RULE): Remove 2nd arg, which is unused.
13586 All callers changed.
13587 (decode_coding_utf_8, decode_coding_utf_16 decode_coding_emacs_mule):
13588 (decode_coding_iso_2022, encode_coding_sjis, encode_coding_big5):
13589 (decode_coding_charset): Remove vars that are set but not used.
13591 * bytecode.c (Fbyte_code) [!defined BYTE_CODE_SAFE]: Remove var
13592 that is set but not used.
13594 * print.c (print_object): Remove var that is set but not used.
13596 Replace 2 copies of readlink code with 1 gnulib version (Bug#8401).
13597 The gnulib version avoids calling malloc in the usual case,
13598 and on 64-bit hosts doesn't have some arbitrary 32-bit limits.
13599 * fileio.c (Ffile_symlink_p): Use emacs_readlink.
13600 * filelock.c (current_lock_owner): Likewise.
13601 * lisp.h (READLINK_BUFSIZE, emacs_readlink): New function.
13602 * sysdep.c: Include allocator.h, careadlinkat.h.
13603 (emacs_no_realloc_allocator): New static constant.
13604 (emacs_readlink): New function.
13605 * deps.mk (sysdep.o): Depend on ../lib/allocator.h and on
13606 ../lib/careadlinkat.h.
13608 2011-04-04 Stefan Monnier <monnier@iro.umontreal.ca>
13610 * keyboard.c (safe_run_hook_funcall): Fix last change (don't stop at the
13611 first non-nil return value).
13613 2011-04-03 Jan Djärv <jan.h.d@swipnet.se>
13615 * nsterm.m (ns_update_auto_hide_menu_bar): Define MAC_OS_X_VERSION_10_6
13616 if not defined (Bug#8403).
13618 2011-04-02 Juanma Barranquero <lekktu@gmail.com>
13620 * xdisp.c (display_count_lines): Remove parameter `start',
13621 unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
13622 (get_char_face_and_encoding): Remove parameter `multibyte_p',
13623 unused since 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
13624 (fill_stretch_glyph_string): Remove parameters `row' and `area',
13625 unused at least since Kim's GUI unification at 2003-03-16T20:45:46Z!storm@cua.dk
13626 and thereabouts. All callers changed.
13627 (get_per_char_metric): Remove parameter `f', unused since
13628 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
13630 2011-04-02 Jim Meyering <meyering@redhat.com>
13632 do not dereference NULL upon failed strdup
13633 * nsfont.m (ns_descriptor_to_entity): Use xstrdup, not strdup.
13634 (ns_get_family): Likewise.
13636 2011-04-02 Juanma Barranquero <lekktu@gmail.com>
13638 * eval.c (unwind_to_catch) [DEBUG_GCPRO]: Remove redundant assignment.
13640 2011-04-02 Jan Djärv <jan.h.d@swipnet.se>
13642 * nsterm.m (ns_update_auto_hide_menu_bar): Only for OSX 10.6 or
13645 2011-04-01 Stefan Monnier <monnier@iro.umontreal.ca>
13647 Add lexical binding.
13649 * window.c (Ftemp_output_buffer_show): New fun.
13650 (Fsave_window_excursion):
13651 * print.c (Fwith_output_to_temp_buffer): Move to subr.el.
13653 * lread.c (lisp_file_lexically_bound_p): New function.
13654 (Fload): Bind Qlexical_binding.
13655 (readevalloop): Remove `evalfun' arg.
13656 Bind Qinternal_interpreter_environment.
13657 (Feval_buffer): Bind Qlexical_binding.
13658 (defvar_int, defvar_bool, defvar_lisp_nopro, defvar_kboard):
13660 (syms_of_lread): Declare `lexical-binding'.
13662 * lisp.h (struct Lisp_Symbol): New field `declared_special'.
13664 * keyboard.c (eval_dyn): New fun.
13665 (menu_item_eval_property): Use it.
13667 * image.c (parse_image_spec): Use Ffunctionp.
13669 * fns.c (concat, mapcar1): Accept byte-code-functions.
13671 * eval.c (Fsetq): Handle lexical vars.
13672 (Fdefun, Fdefmacro, Ffunction): Make closures when needed.
13673 (Fdefconst, Fdefvaralias, Fdefvar): Mark as dynamic.
13674 (FletX, Flet): Obey lexical binding.
13675 (Fcommandp): Handle closures.
13676 (Feval): New `lexical' arg.
13677 (eval_sub): New function extracted from Feval. Use it almost
13678 everywhere where Feval was used. Look up vars in lexical env.
13680 (Ffunctionp): Move from subr.el.
13681 (Ffuncall): Handle closures.
13682 (apply_lambda): Remove `eval_flags'.
13683 (funcall_lambda): Handle closures and new byte-code-functions.
13684 (Fspecial_variable_p): New function.
13685 (syms_of_eval): Initialize the Vinternal_interpreter_environment var,
13686 but without exporting it to Lisp.
13688 * doc.c (Fdocumentation, store_function_docstring):
13689 * data.c (Finteractive_form): Handle closures.
13691 * callint.c (Fcall_interactively): Preserve lexical-binding mode for
13694 * bytecode.c (Bstack_ref, Bstack_set, Bstack_set2, BdiscardN):
13696 (exec_byte_code): New function extracted from Fbyte_code to handle new
13697 calling convention for byte-code-functions. Add new byte-codes.
13699 * buffer.c (defvar_per_buffer): Set new `declared_special' field.
13701 * alloc.c (Fmake_symbol): Init new `declared_special' field.
13703 2011-03-31 Juanma Barranquero <lekktu@gmail.com>
13705 * xdisp.c (redisplay_internal): Fix prototype.
13707 2011-03-31 Eli Zaretskii <eliz@gnu.org>
13709 * xdisp.c (SCROLL_LIMIT): New macro.
13710 (try_scrolling): Use it when setting scroll_limit.
13711 Limit scrolling to 100 screen lines.
13712 (redisplay_window): Even when falling back on "recentering",
13713 position point in the window according to scroll-conservatively,
13714 scroll-margin, and scroll-*-aggressively variables. (Bug#6671)
13716 (try_scrolling): When point is above the window, allow searching
13717 as far as scroll_max, or one screenful, to compute vertical
13718 distance from PT to the scroll margin position. This prevents
13719 try_scrolling from unnecessarily failing when
13720 scroll-conservatively is set to a value slightly larger than the
13721 window height. Clean up the case of PT below the margin at bottom
13722 of window: scroll_max can no longer be INT_MAX. When aggressive
13723 scrolling is in use, don't let point enter the opposite scroll
13724 margin as result of the scroll.
13725 (syms_of_xdisp) <scroll-conservatively>: Document the
13726 threshold of 100 lines for never-recentering scrolling.
13728 2011-03-31 Juanma Barranquero <lekktu@gmail.com>
13730 * dispextern.h (move_it_by_lines):
13731 * xdisp.c (move_it_by_lines): Remove parameter `need_y_p', unused
13732 since 2000-12-29T14:24:09Z!gerd@gnu.org. All callers changed.
13733 (message_log_check_duplicate): Remove parameters `prev_bol' and
13734 `this_bol', unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
13735 (redisplay_internal): Remove parameter `preserve_echo_area',
13736 unused since 1999-07-21T21:43:52Z!gerd@gnu.org. All callers changed.
13738 * indent.c (Fvertical_motion):
13739 * window.c (window_scroll_pixel_based, Frecenter):
13740 Don't pass `need_y_p' to `move_it_by_lines'.
13742 2011-03-30 Stefan Monnier <monnier@iro.umontreal.ca>
13744 * eval.c (struct backtrace): Don't cheat with negative numbers, but do
13745 steal a few bits to be more compact.
13746 (interactive_p, Fbacktrace, Fbacktrace_frame, mark_backtrace):
13747 Remove unneeded casts.
13749 * bytecode.c (Fbyte_code): CAR and CDR can GC.
13751 2011-03-30 Zachary Kanfer <zkanfer@gmail.com> (tiny change)
13753 * keyboard.c (Fexecute_extended_command): Do log the "suggest key
13754 binding" message (bug#7967).
13756 2011-03-30 Paul Eggert <eggert@cs.ucla.edu>
13758 Fix more problems found by GCC 4.6.0's static checks.
13760 * unexelf.c (unexec) [! (defined _SYSTYPE_SYSV || defined __sgi)]:
13761 Remove unused local var.
13763 * editfns.c (Fmessage_box): Remove unused local var.
13765 * xdisp.c (try_window_reusing_current_matrix, x_produce_glyphs):
13766 (note_mode_line_or_margin_highlight, note_mouse_highlight):
13767 Omit unused local vars.
13768 * window.c (shrink_windows): Omit unused local var.
13769 * menu.c (digest_single_submenu): Omit unused local var.
13770 * dispnew.c (update_window) [PERIODIC_PREEMPTION_CHECKING]:
13771 Omit unused local var.
13773 * keyboard.c (parse_modifiers_uncached, parse_modifiers):
13774 Don't assume string length fits in int.
13775 (keyremap_step, read_key_sequence): Use size_t for sizes.
13776 (read_key_sequence): Don't check last_real_key_start redundantly.
13778 * callproc.c (Fcall_process, Fcall_process_region): Use SAFE_ALLOCA
13779 instead of alloca (Bug#8344).
13781 * eval.c (Fbacktrace): Don't assume nargs fits in int.
13782 (Fbacktrace_frame): Don't assume nframes fits in int.
13784 * syntax.c (scan_sexps_forward): Avoid pointer wraparound.
13786 * xterm.c (x_make_frame_visible, same_x_server): Redo to avoid overflow
13789 * term.c (produce_glyphless_glyph): Remove unnecessary test.
13791 * cm.c (calccost): Turn while-do into do-while, for clarity.
13793 * keyboard.c (syms_of_keyboard): Use the same style as later
13794 in this function when indexing through an array. This also
13795 works around GCC bug 48267.
13797 * image.c (tiff_load): Fix off-by-one image count (Bug#8336).
13799 * xselect.c (x_check_property_data): Return correct size (Bug#8335).
13801 * chartab.c (sub_char_table_ref_and_range): Redo for slight
13802 efficiency gain, and to bypass a gcc -Wstrict-overflow warning.
13804 * keyboard.c, keyboard.h (num_input_events): Now size_t.
13805 This avoids undefined behavior on integer overflow, and is a bit
13806 more convenient anyway since it is compared to a size_t variable.
13808 Variadic C functions now count arguments with size_t, not int.
13809 This avoids an unnecessary limitation on 64-bit machines, which
13810 caused (substring ...) to crash on large vectors (Bug#8344).
13811 * lisp.h (struct Lisp_Subr.function.aMANY): Now takes size_t, not int.
13812 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call): Likewise.
13813 All variadic functions and their callers changed accordingly.
13814 (struct gcpro.nvars): Now size_t, not int. All uses changed.
13815 * data.c (arith_driver, float_arith_driver): Likewise.
13816 * editfns.c (general_insert_function): Likewise.
13817 * eval.c (struct backtrace.nargs, interactive_p)
13818 (internal_condition_case_n, run_hook_with_args, apply_lambda)
13819 (funcall_lambda, mark_backtrace): Likewise.
13820 * fns.c (concat): Likewise.
13821 * frame.c (x_set_frame_parameters): Likewise.
13822 * fns.c (get_key_arg): Now accepts and returns size_t, and returns
13823 0 if not found, not -1. All callers changed.
13825 * alloc.c (garbage_collect): Don't assume stack size fits in int.
13826 (stack_copy_size): Now size_t, not int.
13827 (stack_copy, stack_copy_size): Define only if MAX_SAVE_STACK > 0.
13829 2011-03-28 Juanma Barranquero <lekktu@gmail.com>
13831 * coding.c (encode_designation_at_bol): Remove parameter `charbuf_end',
13832 unused since 2002-03-01T01:17:24Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
13833 All callers changed.
13835 * lisp.h (multibyte_char_to_unibyte):
13836 * character.c (multibyte_char_to_unibyte): Remove parameter `rev_tbl',
13837 unused since 2002-03-01T01:16:34Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
13838 * character.h (CHAR_TO_BYTE8):
13839 * cmds.c (internal_self_insert):
13840 * editfns.c (general_insert_function):
13841 * keymap.c (push_key_description):
13842 * search.c (Freplace_match):
13843 * xdisp.c (message_dolog, set_message_1): All callers changed.
13845 2011-03-28 Stefan Monnier <monnier@iro.umontreal.ca>
13847 * keyboard.c (safe_run_hook_funcall): New function.
13848 (safe_run_hooks_1, safe_run_hooks_error, safe_run_hooks): On error,
13849 don't set the hook to nil, but remove the offending function instead.
13850 (Qcommand_hook_internal): Remove, unused.
13851 (syms_of_keyboard): Don't initialize Qcommand_hook_internal nor define
13852 Vcommand_hook_internal.
13854 * eval.c (enum run_hooks_condition): Remove.
13855 (funcall_nil, funcall_not): New functions.
13856 (run_hook_with_args): Call each function through a `funcall' argument.
13857 Remove `cond' argument, now redundant.
13858 (Frun_hooks, Frun_hook_with_args, Frun_hook_with_args_until_success)
13859 (Frun_hook_with_args_until_failure): Adjust accordingly.
13860 (run_hook_wrapped_funcall, Frun_hook_wrapped): New functions.
13862 2011-03-28 Juanma Barranquero <lekktu@gmail.com>
13864 * dispextern.h (string_buffer_position): Remove declaration.
13866 * print.c (strout): Remove parameter `multibyte', unused since
13867 1999-08-21T19:30:21Z!gerd@gnu.org. All callers changed.
13869 * search.c (boyer_moore): Remove parameters `len', `pos' and `lim',
13870 never used since function introduction in 1998-02-08T21:33:56Z!rms@gnu.org.
13871 All callers changed.
13873 * w32.c (_wsa_errlist): Use braces for struct initializers.
13875 * xdisp.c (string_buffer_position_lim): Remove parameter `w',
13876 never used since function introduction in 2001-03-09T18:41:50Z!gerd@gnu.org.
13877 All callers changed.
13878 (string_buffer_position): Likewise. Also, make static (it's never
13879 used outside xdisp.c).
13880 (cursor_row_p): Remove parameter `w', unused since
13881 2000-10-17T16:08:57Z!gerd@gnu.org. All callers changed.
13882 (decode_mode_spec): Remove parameter `precision', introduced during
13883 Gerd Moellmann's rewrite at 1999-07-21T21:43:52Z!gerd@gnu.org, but never used.
13884 All callers changed.
13886 2011-03-27 Jan Djärv <jan.h.d@swipnet.se>
13888 * nsterm.m (syms_of_nsterm): Use doc: for ns-auto-hide-menu-bar.
13890 2011-03-27 Anders Lindgren <andlind@gmail.com>
13892 * nsterm.m (ns_menu_bar_is_hidden): New variable.
13893 (ns_constrain_all_frames, ns_menu_bar_should_be_hidden)
13894 (ns_update_auto_hide_menu_bar): New functions.
13895 (ns_update_begin): Call ns_update_auto_hide_menu_bar.
13896 (applicationDidBecomeActive): Call ns_update_auto_hide_menu_bar and
13897 ns_constrain_all_frames.
13898 (constrainFrameRect): Return at once if ns_menu_bar_should_be_hidden.
13899 (syms_of_nsterm): DEFVAR ns-auto-hide-menu-bar, init to Qnil.
13901 2011-03-27 Jan Djärv <jan.h.d@swipnet.se>
13903 * nsmenu.m (runDialogAt): Remove argument to timer_check.
13905 2011-03-27 Glenn Morris <rgm@gnu.org>
13907 * syssignal.h: Replace RETSIGTYPE with void.
13908 * atimer.c, data.c, dispnew.c, emacs.c, floatfns.c, keyboard.c:
13909 * keyboard.h, lisp.h, process.c, sysdep.c, xterm.c:
13910 Replace SIGTYPE with void everywhere.
13911 * s/usg5-4-common.h (SIGTYPE): Remove definition.
13912 * s/template.h (SIGTYPE): Remove commented out definition.
13914 2011-03-26 Eli Zaretskii <eliz@gnu.org>
13916 * xdisp.c (redisplay_window): Don't check buffer's clip_changed
13917 flag as a prerequisite for invoking try_scrolling. (Bug#6671)
13919 2011-03-26 Juanma Barranquero <lekktu@gmail.com>
13921 * w32.c (read_unc_volume): Use parameter `henum', instead of
13922 global variable `wget_enum_handle'.
13924 * keymap.c (describe_vector): Remove parameters `indices' and
13925 `char_table_depth', unused since 2002-03-01T01:43:26Z!handa@m17n.org.
13926 (describe_map, Fdescribe_vector): Adjust calls to `describe_vector'.
13928 * keyboard.h (timer_check, show_help_echo): Remove unused parameters.
13930 * keyboard.c (timer_check): Remove parameter `do_it_now',
13931 unused since 1996-04-12T06:01:29Z!rms@gnu.org.
13932 (show_help_echo): Remove parameter `ok_to_overwrite_keystroke_echo',
13933 unused since 2008-04-19T19:30:53Z!monnier@iro.umontreal.ca.
13935 * keyboard.c (read_char):
13936 * w32menu.c (w32_menu_display_help):
13937 * xmenu.c (show_help_event, menu_help_callback):
13938 Adjust calls to `show_help_echo'.
13940 * gtkutil.c (xg_maybe_add_timer):
13941 * keyboard.c (readable_events):
13942 * process.c (wait_reading_process_output):
13943 * xmenu.c (x_menu_wait_for_event): Adjust calls to `timer_check'.
13945 * insdel.c (adjust_markers_gap_motion):
13946 Remove; no-op since 1998-01-02T21:29:48Z!rms@gnu.org.
13947 (gap_left, gap_right): Don't call it.
13949 2011-03-25 Chong Yidong <cyd@stupidchicken.com>
13951 * xdisp.c (handle_fontified_prop): Discard changes to clip_changed
13952 incurred during fontification.
13954 2011-03-25 Juanma Barranquero <lekktu@gmail.com>
13956 * buffer.c (defvar_per_buffer): Remove unused parameter `doc'.
13957 (DEFVAR_PER_BUFFER): Don't pass it.
13959 * dispnew.c (row_equal_p, add_row_entry): Remove unused parameter `w'.
13960 (scrolling_window): Don't pass it.
13962 2011-03-25 Juanma Barranquero <lekktu@gmail.com>
13964 * dispextern.h (glyph_matric): Use #if GLYPH_DEBUG, not #ifdef.
13966 * fileio.c (check_executable) [DOS_NT]: Remove unused variables `len'
13968 (Fset_file_selinux_context) [HAVE_LIBSELINUX]: Move here declaration
13969 of variables specific to SELinux and computation of `encoded_absname'.
13971 * image.c (XPutPixel): Remove unused variable `height'.
13973 * keyboard.c (make_lispy_event): Remove unused variable `hpos'.
13975 * unexw32.c (get_section_info): Remove unused variable `section'.
13977 * w32.c (stat): Remove unused variables `drive_root' and `devtype'.
13978 (system_process_attributes): Remove unused variable `sess'.
13979 (sys_read): Remove unused variable `err'.
13981 * w32fns.c (top): Wrap variables with #if GLYPH_DEBUG, not #ifdef.
13982 (w32_wnd_proc): Remove unused variable `isdead'.
13983 (unwind_create_frame): Use #if GLYPH_DEBUG, not #ifdef.
13984 (Fx_server_max_request_size): Remove unused variable `dpyinfo'.
13985 (x_create_tip_frame): Remove unused variable `tem'.
13987 * w32inevt.c (w32_console_read_socket):
13988 Remove unused variable `no_events'.
13990 * w32term.c (x_draw_composite_glyph_string_foreground):
13991 Remove unused variable `width'.
13993 2011-03-24 Juanma Barranquero <lekktu@gmail.com>
13995 * w32term.c (x_set_glyph_string_clipping):
13996 Don't pass uninitialized region to CombineRgn.
13998 2011-03-23 Juanma Barranquero <lekktu@gmail.com>
14000 * w32fns.c (x_set_menu_bar_lines): Remove unused variable `olines'.
14001 (w32_wnd_proc): Pass NULL to Windows API, not uninitialized buffer.
14002 (Fx_close_connection): Remove unused variable `i'.
14004 * w32font.c (w32font_draw): Return number of glyphs.
14005 (w32font_open_internal): Remove unused variable `i'.
14006 (w32font_driver): Add missing initializer.
14008 * w32menu.c (utf8to16): Remove unused variable `utf16'.
14009 (fill_in_menu): Remove unused variable `items_added'.
14011 * w32term.c (last_mouse_press_frame): Remove static global variable.
14012 (w32_clip_to_row): Remove unused variable `f'.
14013 (x_delete_terminal): Remove unused variable `i'.
14015 * w32uniscribe.c (uniscribe_shape): Remove unused variable `nclusters'.
14016 (NOTHING): Remove unused static global variable.
14017 (uniscribe_check_otf): Remove unused variable `table'.
14018 (uniscribe_font_driver): Add missing initializers.
14020 2011-03-23 Julien Danjou <julien@danjou.info>
14022 * term.c (Fsuspend_tty, Fresume_tty):
14023 * minibuf.c (read_minibuf, run_exit_minibuf_hook):
14024 * window.c (temp_output_buffer_show):
14025 * insdel.c (signal_before_change):
14026 * frame.c (Fhandle_switch_frame):
14027 * fileio.c (Fdo_auto_save):
14028 * emacs.c (Fkill_emacs):
14029 * editfns.c (save_excursion_restore):
14030 * cmds.c (internal_self_insert):
14031 * callint.c (Fcall_interactively):
14032 * buffer.c (Fkill_all_local_variables):
14033 * keyboard.c (Fcommand_execute, Fsuspend_emacs, safe_run_hooks_1):
14035 (command_loop_1): Use Frun_hooks. Call safe_run_hooks
14036 unconditionally since it does the check itself.
14038 2011-03-23 Paul Eggert <eggert@cs.ucla.edu>
14040 Fix more problems found by GCC 4.5.2's static checks.
14042 * coding.c (encode_coding_raw_text): Avoid unnecessary test
14043 the first time through the loop, since we know p0 < p1 then.
14044 This also avoids a gcc -Wstrict-overflow warning.
14046 * lisp.h (SAFE_ALLOCA, SAFE_ALLOCA_LISP): Avoid 'int' overflow
14047 leading to a memory leak, possible in functions like
14048 load_charset_map_from_file that can allocate an unbounded number
14049 of objects (Bug#8318).
14051 * xmenu.c (set_frame_menubar): Use EMACS_UINT, not int, for indexes
14052 that could (at least in theory) be that large.
14054 * xdisp.c (message_log_check_duplicate): Return unsigned long, not int.
14055 This is less likely to overflow, and avoids undefined behavior if
14056 overflow does occur. All callers changed. Use strtoul to scan
14057 for the unsigned long integer.
14058 (pint2hrstr): Simplify and tune code slightly.
14059 This also avoids a (bogus) GCC warning with gcc -Wstrict-overflow.
14061 * scroll.c (do_scrolling): Work around GCC bug 48228.
14062 See <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=48228>.
14064 * frame.c (Fmodify_frame_parameters): Simplify loop counter.
14065 This also avoids a warning with gcc -Wstrict-overflow.
14066 (validate_x_resource_name): Simplify count usage.
14067 This also avoids a warning with gcc -Wstrict-overflow.
14069 * fileio.c (Fcopy_file): Report error if fchown or fchmod
14072 * emacs.c (Fdaemon_initialized): Do not ignore I/O errors (Bug#8303).
14074 * process.c (Fmake_network_process): Use socklen_t, not int,
14075 where POSIX says socklen_t is required in portable programs.
14076 This fixes a porting bug on hosts like 64-bit HP-UX, where
14077 socklen_t is wider than int (Bug#8277).
14078 (Fmake_network_process, server_accept_connection):
14079 (wait_reading_process_output, read_process_output):
14082 * process.c: Rename or move locals to avoid shadowing.
14083 (list_processes_1, Fmake_network_process):
14084 (read_process_output_error_handler, exec_sentinel_error_handler):
14085 Rename or move locals.
14086 (Fmake_network_process): Define label "retry_connect" only if needed.
14087 (Fnetwork_interface_info): Fix pointer signedness.
14088 (process_send_signal): Add cast to avoid pointer signedness problem.
14089 (FIRST_PROC_DESC, IF_NON_BLOCKING_CONNECT): Remove unused macros.
14090 (create_process): Use 'volatile' to avoid vfork clobbering (Bug#8298).
14092 Make tparam.h and terminfo.c consistent.
14093 * cm.c (tputs, tgoto, BC, UP): Remove extern decls.
14094 Include tparam.h instead, since it declares them.
14095 * cm.h (PC): Remove extern decl; tparam.h now does this.
14096 * deps.mk (cm.o, terminfo.o): Depend on tparam.h.
14097 * terminfo.c: Include tparam.h, to check interfaces.
14098 (tparm): Make 1st arg a const pointer in decl. Put it at top level.
14099 (tparam): Adjust signature to match interface in tparam.h;
14100 this removes some undefined behavior. Check that outstring and len
14101 are zero, which they always are with Emacs.
14102 * tparam.h (PC, BC, UP): New extern decls.
14104 * xftfont.c (xftfont_shape): Now static, and defined only if needed.
14105 (xftfont_open): Rename locals to avoid shadowing.
14107 * ftfont.c (ftfont_resolve_generic_family): Fix pointer signedness.
14108 (ftfont_otf_capability, ftfont_shape): Omit decls if not needed.
14109 (OTF_TAG_SYM): Omit macro if not needed.
14110 (ftfont_list): Remove unused local.
14111 (get_adstyle_property, ftfont_pattern_entity):
14112 (ftfont_lookup_cache, ftfont_open, ftfont_anchor_point):
14113 Rename locals to avoid shadowing.
14115 * xfont.c (xfont_list_family): Mark var as initialized.
14117 * xml.c (make_dom): Now static.
14119 * composite.c (composition_compute_stop_pos): Rename local to
14121 (composition_reseat_it): Remove unused locals.
14122 (find_automatic_composition, composition_adjust_point): Likewise.
14123 (composition_update_it): Mark var as initialized.
14124 (find_automatic_composition): Mark vars as initialized,
14125 with a FIXME (Bug#8290).
14127 character.h: Rename locals to avoid shadowing.
14128 * character.h (PREV_CHAR_BOUNDARY, FETCH_STRING_CHAR_ADVANCE):
14129 (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE, FETCH_CHAR_ADVANCE):
14130 (FETCH_CHAR_ADVANCE_NO_CHECK, INC_POS, DEC_POS, BUF_INC_POS):
14131 (BUF_DEC_POS): Be more systematic about renaming local temporaries
14132 to avoid shadowing.
14134 * textprop.c (property_change_between_p): Remove; unused.
14136 * intervals.c (interval_start_pos): Now static.
14138 * intervals.h (CHECK_TOTAL_LENGTH): Avoid empty "else".
14140 * atimer.c (start_atimer, append_atimer_lists, set_alarm):
14141 Rename locals to avoid shadowing.
14143 * sound.c (wav_play, au_play, Fplay_sound_internal):
14144 Fix pointer signedness.
14145 (alsa_choose_format): Remove unused local var.
14146 (wav_play): Initialize a variable to 0, to prevent undefined
14147 behavior (Bug#8278).
14149 * region-cache.c (insert_cache_boundary): Redo var to avoid shadowing.
14151 * region-cache.h (pp_cache): New decl, for gcc -Wmissing-prototypes.
14153 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork
14154 clobbering (Bug#8298).
14155 * sysdep.c (sys_subshell): Likewise.
14156 Previously, the sys_subshell 'volatile' was incorrectly IF_LINTted out.
14158 * lisp.h (child_setup): Now NO_RETURN unless DOS_NT.
14159 This should get cleaned up, so that child_setup has the
14160 same signature on all platforms.
14162 * callproc.c (call_process_cleanup): Now static.
14163 (relocate_fd): Rename locals to avoid shadowing.
14165 2011-03-22 Chong Yidong <cyd@stupidchicken.com>
14167 * xterm.c (x_clear_frame): Remove XClearWindow call. This appears
14168 not to be necessary, and produces flickering.
14170 2011-03-20 Glenn Morris <rgm@gnu.org>
14172 * config.in: Remove file.
14174 2011-03-20 Juanma Barranquero <lekktu@gmail.com>
14176 * minibuf.c (Vcompleting_read_function): Don't declare, global variables
14177 are now in src/globals.h.
14178 (syms_of_minibuf): Remove spurious & from previous change.
14180 2011-03-20 Leo Liu <sdl.web@gmail.com>
14182 * minibuf.c (completing-read-function): New variable.
14183 (completing-read-default): Rename from completing-read.
14184 (completing-read): Call completing-read-function.
14186 2011-03-19 Juanma Barranquero <lekktu@gmail.com>
14188 * xfaces.c (Fx_load_color_file):
14189 Read color file from absolute filename (bug#8250).
14191 2011-03-19 Juanma Barranquero <lekktu@gmail.com>
14193 * makefile.w32-in: Update dependencies.
14195 2011-03-17 Eli Zaretskii <eliz@gnu.org>
14197 * makefile.w32-in ($(BLD)/unexw32.$(O)): Depend on $(SRC)/unexec.h.
14199 2011-03-17 Paul Eggert <eggert@cs.ucla.edu>
14201 Fix more problems found by GCC 4.5.2's static checks.
14203 * process.c (make_serial_process_unwind, send_process_trap):
14204 (sigchld_handler): Now static.
14206 * process.c (allocate_pty): Let PTY_ITERATION declare iteration vars.
14207 That way, the code declares only the vars that it needs.
14208 * s/aix4-2.h (PTY_ITERATION): Declare iteration vars.
14209 * s/cygwin.h (PTY_ITERATION): Likewise.
14210 * s/darwin.h (PTY_ITERATION): Likewise.
14211 * s/gnu-linux.h (PTY_ITERATION): Likewise.
14213 * s/irix6-5.h (PTY_OPEN): Declare stb, to loosen coupling.
14214 * process.c (allocate_pty): Don't declare stb unless it's needed.
14216 * bytecode.c (MAYBE_GC): Rewrite so as not to use empty "else".
14217 (CONSTANTLIM): Remove; unused.
14218 (METER_CODE, Bscan_buffer, Bread_char, Bset_mark):
14219 Define only if needed.
14221 * unexelf.c (unexec): Name an expression,
14222 to avoid gcc -Wbad-function-cast warning.
14223 Use a different way to cause a compilation error if anyone uses
14224 n rather than nn, a way that does not involve shadowing.
14225 (ELF_BSS_SECTION_NAME, OLD_PROGRAM_H): Remove; unused.
14227 * deps.mk (unexalpha.o): Remove; unused.
14229 New file unexec.h, the (simple) interface for unexec (Bug#8267).
14230 * unexec.h: New file.
14231 * deps.mk (emacs.o, unexaix.o, unexcw.o, unexcoff.o, unexelf.o):
14232 (unexhp9k800.o, unexmacosx.o, unexsol.o, unexw32.o):
14233 Depend on unexec.h.
14234 * emacs.c [!defined CANNOT_DUMP]: Include unexec.h.
14235 * unexaix.c, unexcoff.c, unexcw.c, unexelf.c, unexhp9k800.c:
14236 * unexmacosx.c, unexsol.c, unexw32.c: Include unexec.h.
14237 Change as necessary to match prototype in unexec.h.
14239 * syntax.c (Fforward_comment, scan_lists): Rename locals to avoid
14241 (back_comment, skip_chars): Mark vars as initialized.
14243 * character.h (FETCH_STRING_CHAR_ADVANCE_NO_CHECK, BUF_INC_POS):
14244 Rename locals to avoid shadowing.
14246 * lread.c (read1): Rewrite so as not to use empty "else".
14247 (Fload, readevalloop, read1): Rename locals to avoid shadowing.
14249 * print.c (Fredirect_debugging_output): Fix pointer signedess.
14251 * lisp.h (debug_output_compilation_hack): Add decl here, to avoid
14252 warning when compiling print.c.
14254 * font.c (font_unparse_fcname): Abort in an "impossible" situation
14255 instead of using an uninitialized var.
14256 (font_sort_entities): Mark var as initialized.
14258 * character.h (FETCH_CHAR_ADVANCE): Rename locals to avoid shadowing.
14260 * font.c (font_unparse_xlfd): Don't mix pointers to variables with
14261 pointers to constants.
14262 (font_parse_fcname): Remove unused vars.
14263 (font_delete_unmatched): Now static.
14264 (font_get_spec): Remove; unused.
14265 (font_style_to_value, font_prop_validate_style, font_unparse_fcname):
14266 (font_update_drivers, Ffont_get_glyphs, font_add_log):
14267 Rename or move locals to avoid shadowing.
14269 * fns.c (require_nesting_list, require_unwind): Now static.
14270 (Ffillarray): Rename locals to avoid shadowing.
14272 * floatfns.c (domain_error2): Define only if needed.
14273 (Ffrexp, Fldexp): Rename locals to avoid shadowing.
14275 * alloc.c (mark_backtrace): Move decl from here ...
14276 * lisp.h: ... to here, so that it can be checked.
14278 * eval.c (call_debugger, do_debug_on_call, grow_specpdl): Now static.
14279 (Fdefvar): Rewrite so as not to use empty "else".
14280 (lisp_indirect_variable): Name an expression,
14281 to avoid gcc -Wbad-function-cast warning.
14282 (Fdefvar): Rename locals to avoid shadowing.
14284 * callint.c (quotify_arg, quotify_args): Now static.
14285 (Fcall_interactively): Rename locals to avoid shadowing.
14286 Use const pointer when appropriate.
14288 * lisp.h (get_system_name, get_operating_system_release):
14289 Move decls here, to check interfaces.
14290 * process.c (get_operating_system_release): Move decl to lisp.h.
14291 * xrdb.c (get_system_name): Likewise.
14292 * editfns.c (init_editfns, Fuser_login_name, Fuser_uid):
14293 (Fuser_real_uid, Fuser_full_name): Remove unnecessary casts,
14294 some of which prompt warnings from gcc -Wbad-function-cast.
14295 (Fformat_time_string, Fencode_time, Finsert_char):
14296 (Ftranslate_region_internal, Fformat):
14297 Rename or remove local vars to avoid shadowing.
14298 (Ftranslate_region_internal): Mark var as initialized.
14300 * doc.c (Fdocumentation, Fsnarf_documentation): Move locals to
14303 * lisp.h (eassert): Check that the argument compiles, even if
14304 ENABLE_CHECKING is not defined.
14306 * data.c (Findirect_variable): Name an expression, to avoid
14307 gcc -Wbad-function-cast warning.
14308 (default_value, arithcompare, arith_driver, arith_error): Now static.
14309 (store_symval_forwarding): Rename local to avoid shadowing.
14310 (Fmake_variable_buffer_local, Fmake_local_variable):
14311 Mark variables as initialized.
14312 (do_blv_forwarding, do_symval_forwarding): Remove; unused.
14314 * alloc.c (check_cons_list): Do not define unless GC_CHECK_CONS_LIST.
14315 (Fmake_vector, Fvector, Fmake_byte_code, Fgarbage_collect):
14316 Rename locals to avoid shadowing.
14317 (mark_stack): Move local variables into the #ifdef region where
14319 (BLOCK_INPUT_ALLOC, UNBLOCK_INPUT_ALLOC): Define only if
14320 ! defined SYSTEM_MALLOC && ! defined SYNC_INPUT, as they are not
14322 (CHECK_ALLOCATED): Define only if GC_CHECK_MARKED_OBJECTS.
14323 (GC_STRING_CHARS): Remove; not used.
14324 (Fmemory_limit): Cast sbrk's returned value to char *.
14326 * lisp.h (check_cons_list): Declare if GC_CHECK_CONS_LIST; this
14327 avoids undefined behavior in theory.
14329 * regex.c (IF_LINT): Add defn, for benefit of ../lib-src.
14331 Use functions, not macros, for up- and down-casing (Bug#8254).
14332 * buffer.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
14333 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Remove. All callers changed
14334 to use the following functions instead of these macros.
14335 (downcase): Adjust to lack of DOWNCASE_TABLE. Return int, not
14336 EMACS_INT, since callers assume the returned value fits in int.
14337 (upcase1): Likewise, for UPCASE_TABLE.
14338 (uppercasep, lowercasep, upcase): New static inline functions.
14339 * editfns.c (Fchar_equal): Remove no-longer-needed workaround for
14340 the race-condition problem in the old DOWNCASE.
14342 * regex.c (CHARSET_LOOKUP_RANGE_TABLE_RAW, POP_FAILURE_REG_OR_COUNT):
14343 Rename locals to avoid shadowing.
14344 (regex_compile, re_match_2_internal): Move locals to avoid shadowing.
14345 (regex_compile, re_search_2, re_match_2_internal):
14346 Remove unused local vars.
14347 (FREE_VAR): Rewrite so as not to use empty "else",
14348 which gcc can warn about.
14349 (regex_compile, re_match_2_internal): Mark locals as initialized.
14350 (RETALLOC_IF): Define only if needed.
14351 (WORDCHAR_P): Likewise. This one is never needed, but is used
14352 only in a comment talking about a compiler bug, so put inside
14353 the #if 0 of that comment.
14354 (CHARSET_LOOKUP_BITMAP, FAIL_STACK_FULL, RESET_FAIL_STACK):
14355 (PUSH_FAILURE_ELT, BUF_PUSH_3, STOP_ADDR_VSTRING):
14358 * search.c (boyer_moore): Rename locals to avoid shadowing.
14359 * character.h (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE):
14360 (PREV_CHAR_BOUNDARY): Likewise.
14362 * search.c (simple_search): Remove unused var.
14364 * dired.c (compile_pattern): Move decl from here ...
14365 * lisp.h: ... to here, so that it can be checked.
14366 (struct re_registers): New forward decl.
14368 * character.h (INC_POS, DEC_POS): Rename locals to avoid shadowing.
14370 * indent.c (MULTIBYTE_BYTES_WIDTH): New args bytes, width.
14372 (MULTIBYTE_BYTES_WIDTH, scan_for_column, compute_motion):
14373 Rename locals to avoid shadowing.
14374 (Fvertical_motion): Mark locals as initialized.
14376 * casefiddle.c (casify_object, casify_region): Now static.
14377 (casify_region): Mark local as initialized.
14379 * cmds.c (internal_self_insert): Rename local to avoid shadowing.
14381 * lisp.h (GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR, GCPRO5_VAR, GCPRO6_VAR):
14382 New macros, so that the caller can use some names other than
14383 gcpro1, gcpro2, etc.
14384 (GCPRO2, GCPRO3, GCPRO4, GCPRO5, GCPRO6): Reimplement in terms
14386 (GCPRO1_VAR, UNGCPRO_VAR): Change the meaning of the second
14387 argument, for consistency with GCPRO2_VAR, etc: it is now the
14388 prefix of the variable, not the variable itself. All uses
14390 * dired.c (directory_files_internal, file_name_completion):
14391 Rename locals to avoid shadowing.
14393 Fix a race condition diagnosed by gcc -Wsequence-point (Bug#8254).
14394 An expression of the form (DOWNCASE (x) == DOWNCASE (y)), found in
14395 dired.c's scmp function, had undefined behavior.
14396 * lisp.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
14397 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Move from here ...
14398 * buffer.h: ... to here, because these macros use current_buffer,
14399 and the new implementation with inline functions needs to have
14400 current_buffer in scope now, rather than later when the macros
14402 (downcase, upcase1): New static inline functions.
14403 (DOWNCASE, UPCASE1): Reimplement using these functions.
14404 This avoids undefined behavior in expressions like
14405 DOWNCASE (x) == DOWNCASE (y), which previously suffered
14406 from race conditions in accessing the global variables
14407 case_temp1 and case_temp2.
14408 * casetab.c (case_temp1, case_temp2): Remove; no longer needed.
14409 * lisp.h (case_temp1, case_temp2): Remove their decls.
14410 * character.h (ASCII_CHAR_P): Move from here ...
14411 * lisp.h: ... to here, so that the inline functions mentioned
14412 above can use them.
14414 * dired.c (directory_files_internal_unwind): Now static.
14416 * fileio.c (file_name_as_directory, directory_file_name):
14417 (barf_or_query_if_file_exists, auto_save_error, auto_save_1):
14419 (file_name_as_directory): Use const pointers when appropriate.
14420 (Fexpand_file_name): Likewise. In particular, newdir might
14421 point at constant storage, so make it a const pointer.
14422 (Fmake_directory_internal, Fread_file_name): Remove unused vars.
14423 (Ffile_selinux_context, Fset_file_selinux_context): Fix pointer
14425 (Fset_file_times, Finsert_file_contents, auto_save_error):
14426 Rename locals to avoid shadowing.
14428 * minibuf.c (choose_minibuf_frame_1): Now static.
14429 (Ftry_completion, Fall_completions): Rename or remove locals
14430 to avoid shadowing.
14432 * marker.c (bytepos_to_charpos): Remove; unused.
14434 * lisp.h (verify_bytepos, count_markers): New decls,
14435 so that gcc does not warn that these functions aren't declared.
14437 * insdel.c (check_markers, make_gap_larger, make_gap_smaller):
14438 (reset_var_on_error, Fcombine_after_change_execute_1): Now static.
14439 (CHECK_MARKERS): Redo to avoid gcc -Wempty-body diagnostic.
14440 (copy_text): Remove unused local var.
14442 * filelock.c (within_one_second): Now static.
14443 (lock_file_1): Rename local to avoid shadowing.
14445 * buffer.c (fix_overlays_before): Mark locals as initialized.
14446 (fix_start_end_in_overlays): Likewise. This function should be
14447 simplified by using pointers-to-pointers, but that's a different
14449 (switch_to_buffer_1): Now static.
14450 (Fkill_buffer, record_buffer, Fbury_buffer, Fset_buffer_multibyte):
14451 (report_overlay_modification): Rename locals to avoid shadowing.
14453 * sysdep.c (system_process_attributes): Rename vars to avoid shadowing.
14454 Fix pointer signedness issue.
14455 (sys_subshell): Mark local as volatile if checking for lint,
14456 to suppress a gcc -Wclobbered warning that does not seem to be right.
14457 (MAXPATHLEN): Define only if needed.
14459 * process.c (serial_open, serial_configure): Move decls from here ...
14460 * systty.h: ... to here, so that they can be checked.
14462 * fns.c (get_random, seed_random): Move extern decls from here ...
14463 * lisp.h: ... to here, so that they can be checked.
14465 * sysdep.c (reset_io): Now static.
14466 (wait_for_termination_signal): Remove; unused.
14468 * keymap.c (keymap_parent, keymap_memberp, map_keymap_internal):
14469 (copy_keymap_item, append_key, push_text_char_description):
14471 (Fwhere_is_internal): Don't test CONSP (sequences) unnecessarily.
14472 (DENSE_TABLE_SIZE): Remove; unused.
14473 (get_keymap, access_keymap, Fdefine_key, Fwhere_is_internal):
14474 (describe_map_tree):
14475 Rename locals to avoid shadowing.
14477 * keyboard.c: Declare functions static if they are not used elsewhere.
14478 (echo_char, echo_dash, cmd_error, top_level_2):
14479 (poll_for_input, handle_async_input): Now static.
14480 (read_char, kbd_buffer_get_event, make_lispy_position):
14481 (make_lispy_event, make_lispy_movement, apply_modifiers):
14482 (decode_keyboard_code, tty_read_avail_input, menu_bar_items):
14483 (parse_tool_bar_item, read_key_sequence, Fread_key_sequence):
14484 (Fread_key_sequence_vector): Rename locals to avoid shadowing.
14485 (read_key_sequence, read_char): Mark locals as initialized.
14486 (Fexit_recursive_edit, Fabort_recursive_edit): Mark with NO_RETURN.
14488 * keyboard.h (make_ctrl_char): New decl.
14489 (mark_kboards): Move decl here ...
14490 * alloc.c (mark_kboards): ... from here.
14492 * lisp.h (force_auto_save_soon): New decl.
14494 * emacs.c (init_cmdargs): Rename local to avoid shadowing.
14495 (DEFINE_DUMMY_FUNCTION): New macro.
14496 (__do_global_ctors, __do_global_ctors_aux, __do_global_dtors, __main):
14498 (main): Add casts to avoid warnings
14499 if GCC considers string literals to be constants.
14501 * lisp.h (fatal_error_signal): Add decl, since it's exported.
14503 * dbusbind.c: Pointer signedness fixes.
14504 (xd_signature, xd_append_arg, xd_initialize):
14505 (Fdbus_call_method, Fdbus_call_method_asynchronously):
14506 (Fdbus_method_return_internal, Fdbus_method_error_internal):
14507 (Fdbus_send_signal, xd_read_message_1, Fdbus_register_service):
14508 (Fdbus_register_signal): Use SSDATA when the context wants char *.
14510 * dbusbind.c (Fdbus_init_bus): Add cast to avoid warning
14511 if GCC considers string literals to be constants.
14512 (Fdbus_register_service, Fdbus_register_method): Remove unused vars.
14514 2011-03-16 Stefan Monnier <monnier@iro.umontreal.ca>
14516 * print.c (PRINT_CIRCLE_CANDIDATE_P): New macro.
14517 (print_preprocess, print_object): New macro to fix last change.
14519 * print.c (print_preprocess): Don't forget font objects.
14521 2011-03-16 Juanma Barranquero <lekktu@gmail.com>
14523 * emacs.c (USAGE3): Doc fixes.
14525 2011-03-15 Andreas Schwab <schwab@linux-m68k.org>
14527 * coding.c (detect_coding_iso_2022): Reorganize code to clarify
14530 2011-03-14 Juanma Barranquero <lekktu@gmail.com>
14532 * lisp.h (VWindow_system, Qfile_name_history):
14533 * keyboard.h (lispy_function_keys) [WINDOWSNT]:
14534 * w32term.h (w32_system_caret_hwnd, w32_system_caret_height)
14535 (w32_system_caret_x, w32_system_caret_y): Declare extern.
14537 * w32select.c: Don't #include "keyboard.h".
14538 (run_protected): Add extern declaration for waiting_for_input.
14540 * w32.c (Qlocal, noninteractive1, inhibit_window_system):
14541 * w32console.c (detect_input_pending, read_input_pending)
14542 (encode_terminal_code):
14543 * w32fns.c (quit_char, lispy_function_keys, Qtooltip)
14544 (w32_system_caret_hwnd, w32_system_caret_height, w32_system_caret_x)
14545 (w32_system_caret_y, Qfile_name_history):
14546 * w32font.c (w32font_driver, QCantialias, QCotf, QClang):
14547 * w32inevt.c (reinvoke_input_signal, lispy_function_keys):
14548 * w32menu.c (Qmenu_bar, QCtoggle, QCradio, Qoverriding_local_map)
14549 (Qoverriding_terminal_local_map, Qmenu_bar_update_hook):
14550 * w32proc.c (Qlocal, report_file_error):
14551 * w32term.c (Vwindow_system, updating_frame):
14552 * w32uniscribe.c (initialized, uniscribe_font_driver):
14553 Remove unneeded extern declarations.
14555 2011-03-14 Chong Yidong <cyd@stupidchicken.com>
14557 * buffer.c (Fmake_indirect_buffer): Fix incorrect assertions.
14559 2011-03-13 Chong Yidong <cyd@stupidchicken.com>
14561 * buffer.h (BUF_BEGV, BUF_BEGV_BYTE, BUF_ZV, BUF_ZV_BYTE, BUF_PT)
14562 (BUF_PT_BYTE): Rewrite to handle indirect buffers (Bug#8219).
14563 These macros can no longer be used for assignment.
14565 * buffer.c (Fget_buffer_create, Fmake_indirect_buffer):
14566 Assign struct members directly, instead of using BUF_BEGV etc.
14567 (record_buffer_markers, fetch_buffer_markers): New functions for
14568 recording and fetching special buffer markers.
14569 (set_buffer_internal_1, set_buffer_temp): Use them.
14571 * lread.c (unreadchar): Use SET_BUF_PT_BOTH.
14573 * insdel.c (adjust_point): Use SET_BUF_PT_BOTH.
14575 * intervals.c (temp_set_point_both): Use SET_BUF_PT_BOTH.
14576 (get_local_map): Use SET_BUF_BEGV_BOTH and SET_BUF_ZV_BOTH.
14578 * xdisp.c (hscroll_window_tree):
14579 (reconsider_clip_changes): Use PT instead of BUF_PT.
14581 2011-03-13 Eli Zaretskii <eliz@gnu.org>
14583 * makefile.w32-in ($(BLD)/editfns.$(O)): Depend on
14584 $(EMACS_ROOT)/lib/intprops.h.
14586 2011-03-13 Paul Eggert <eggert@cs.ucla.edu>
14588 Fix more problems found by GCC 4.5.2's static checks.
14590 * gtkutil.c (xg_get_pixbuf_from_pixmap): Add cast from char *
14591 to unsigned char * to avoid compiler diagnostic.
14592 (xg_free_frame_widgets): Make it clear that a local variable is
14593 needed only if USE_GTK_TOOLTIP.
14594 (gdk_window_get_screen): Make it clear that this macro is needed
14595 only if USE_GTK_TOOLTIP.
14596 (int_gtk_range_get_value): New function, which avoids a diagnostic
14597 from gcc -Wbad-function-cast.
14598 (xg_set_toolkit_scroll_bar_thumb): Use it.
14599 (xg_tool_bar_callback, xg_tool_item_stale_p): Rewrite to avoid
14600 diagnostic from gcc -Wbad-function-cast.
14601 (get_utf8_string, xg_get_file_with_chooser):
14602 Rename locals to avoid shadowing.
14603 (create_dialog): Move locals to avoid shadowing.
14605 * xgselect.c (xg_select): Remove unused var.
14607 * image.c (four_corners_best): Mark locals as initialized.
14608 (gif_load): Initialize transparent_p to zero (Bug#8238).
14609 Mark another local as initialized.
14610 (my_png_error, my_error_exit): Mark with NO_RETURN.
14612 * image.c (clear_image_cache): Now static.
14613 (DIM, HAVE_STDLIB_H_1): Remove unused macros.
14614 (xpm_load): Redo to avoid "discards qualifiers" gcc warning.
14615 (x_edge_detection): Remove unnecessary cast that
14616 gcc -Wbad-function-cast diagnoses.
14617 (gif_load): Fix pointer signedness.
14618 (clear_image_cache, xbm_read_bitmap_data, x_detect_edges):
14619 (jpeg_load, gif_load): Rename locals to avoid shadowing.
14621 2011-03-12 Paul Eggert <eggert@cs.ucla.edu>
14623 Improve quality of tests for time stamp overflow.
14624 For example, without this patch (encode-time 0 0 0 1 1
14625 1152921504606846976) returns the obviously-bogus value (-948597
14626 62170) on my RHEL 5.5 x86-64 host. With the patch, it correctly
14627 reports time overflow. See
14628 <http://lists.gnu.org/archive/html/emacs-devel/2011-03/msg00470.html>.
14629 * deps.mk (editfns.o): Depend on ../lib/intprops.h.
14630 * editfns.c: Include limits.h and intprops.h.
14631 (TIME_T_MIN, TIME_T_MAX): New macros.
14632 (time_overflow): Move earlier, to before first use.
14633 (hi_time, lo_time): New functions, for an accurate test for
14634 out-of-range times.
14635 (Fcurrent_time, Fget_internal_run_time, make_time): Use them.
14636 (Fget_internal_run_time): Don't assume time_t fits in int.
14637 (make_time): Use list2 instead of Fcons twice.
14638 (Fdecode_time): More accurate test for out-of-range times.
14639 (check_tm_member): New function.
14640 (Fencode_time): Use it, to test for out-of-range times.
14641 (lisp_time_argument): Don't rely on undefined left-shift and
14642 right-shift behavior when checking for time stamp overflow.
14644 * editfns.c (time_overflow): New function, refactoring common code.
14645 (Fformat_time_string, Fdecode_time, Fencode_time):
14646 (Fcurrent_time_string): Use it.
14648 Move 'make_time' to be next to its inverse 'lisp_time_argument'.
14649 * dired.c (make_time): Move to ...
14650 * editfns.c (make_time): ... here.
14651 * systime.h: Note the move.
14653 2011-03-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
14655 * fringe.c (update_window_fringes): Remove unused variables.
14657 * unexmacosx.c (copy_data_segment): Also copy __got section.
14660 2011-03-12 Eli Zaretskii <eliz@gnu.org>
14662 * termcap.c [MSDOS]: Include "msdos.h".
14663 (find_capability, tgetnum, tgetflag, tgetstr, tputs, tgetent):
14664 Constify `char *' arguments and their references according to
14665 prototypes in tparam.h.
14667 * deps.mk (termcap.o): Depend on tparam.h and msdos.h.
14669 * msdos.c (XMenuAddPane): 3rd argument is `const char *' now.
14670 Adapt all references accordingly.
14672 * msdos.h (XMenuAddPane): 3rd argument is `const char *' now.
14674 2011-03-11 Tom Tromey <tromey@redhat.com>
14676 * buffer.c (syms_of_buffer): Remove obsolete comment.
14678 2011-03-11 Eli Zaretskii <eliz@gnu.org>
14680 * termhooks.h (encode_terminal_code): Declare prototype.
14682 * msdos.c (encode_terminal_code): Don't declare prototype.
14684 * term.c (encode_terminal_code): Now external again, used by
14685 w32console.c and msdos.c.
14687 * makefile.w32-in ($(BLD)/term.$(O), ($(BLD)/tparam.$(O)):
14688 Depend on $(SRC)/tparam.h, see 2011-03-11T07:24:21Z!eggert@cs.ucla.edu.
14690 2011-03-11 Paul Eggert <eggert@cs.ucla.edu>
14692 Fix some minor problems found by GCC 4.5.2's static checks.
14694 * fringe.c (update_window_fringes): Mark locals as initialized
14696 (destroy_fringe_bitmap, init_fringe_bitmap): Now static.
14698 * alloc.c (mark_fringe_data): Move decl from here ...
14699 * lisp.h (mark_fringe_data) [HAVE_WINDOW_SYSTEM]: ... to here,
14700 to check its interface.
14701 (init_fringe_once): Do not declare unless HAVE_WINDOW_SYSTEM.
14703 * fontset.c (free_realized_fontset): Now static.
14704 (Fset_fontset_font): Rename local to avoid shadowing.
14705 (fontset_font): Mark local as initialized.
14706 (FONTSET_SPEC, FONTSET_REPERTORY, RFONT_DEF_REPERTORY): Remove; unused.
14708 * xrdb.c: Include "xterm.h", to check x_load_resources's interface.
14710 * xselect.c (x_disown_buffer_selections): Remove; not used.
14711 (TRACE3) [!defined TRACE_SELECTION]: Remove; not used.
14712 (x_own_selection, Fx_disown_selection_internal): Rename locals
14713 to avoid shadowing.
14714 (x_handle_dnd_message): Remove local to avoid shadowing.
14716 * lisp.h (GCPRO1_VAR, UNGCPRO_VAR): New macros,
14717 so that the caller can use some name other than gcpro1.
14718 (GCPRO1, UNGCPRO): Reimplement in terms of the new macros.
14719 * xfns.c (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
14720 (Fx_backspace_delete_keys_p):
14721 Use them to avoid shadowing, and rename vars to avoid shadowing.
14722 (x_decode_color, x_set_name, x_window): Now static.
14723 (Fx_create_frame): Add braces to silence GCC warning.
14724 (Fx_file_dialog, Fx_select_font): Fix pointer signedness.
14725 (x_real_positions, xg_set_icon_from_xpm_data, x_create_tip_frame):
14726 Remove unused locals.
14727 (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
14728 (Fx_backspace_delete_keys_p): Rename locals to avoid shadowing.
14729 Some of these renamings use the new GCPRO1_VAR and UNGCPRO_VAR
14732 * xterm.h (x_mouse_leave): New decl.
14734 * xterm.c (x_copy_dpy_color, x_focus_on_frame, x_unfocus_frame):
14735 Remove unused functions.
14736 (x_shift_glyphs_for_insert, XTflash, XTring_bell):
14737 (x_calc_absolute_position): Now static.
14738 (XTread_socket): Don't define label "out" unless it's used.
14739 Don't declare local "event" unless it's used.
14740 (x_iconify_frame, x_free_frame_resources): Don't declare locals
14741 unless they are used.
14742 (XEMBED_VERSION, xembed_set_info): Don't define unless needed.
14743 (x_fatal_error_signal): Remove; not used.
14744 (x_draw_image_foreground, redo_mouse_highlight, XTmouse_position):
14745 (x_scroll_bar_report_motion, handle_one_xevent, x_draw_bar_cursor):
14746 (x_error_catcher, x_connection_closed, x_error_handler):
14747 (x_error_quitter, xembed_send_message, x_iconify_frame):
14748 (my_log_handler): Rename locals to avoid shadowing.
14749 (x_delete_glyphs, x_ins_del_lines): Mark with NO_RETURN.
14750 (x_connection_closed): Tell GCC not to suggest NO_RETURN.
14752 * xfaces.c (clear_face_cache, Fx_list_fonts, Fface_font):
14753 Rename or move locals to avoid shadowing.
14754 (tty_defined_color, merge_face_heights): Now static.
14755 (free_realized_faces_for_fontset): Remove; not used.
14756 (Fx_list_fonts): Mark variable that gcc -Wuninitialized
14757 does not deduce is never used uninitialized.
14758 (STRDUPA, LSTRDUPA, FONT_POINT_SIZE_QUANTUM): Remove; not used.
14759 (LFACEP): Define only if XASSERTS, as it's not needed otherwise.
14761 * terminal.c (store_terminal_param): Now static.
14763 * xmenu.c (menu_highlight_callback): Now static.
14764 (set_frame_menubar): Remove unused local.
14765 (xmenu_show): Rename parameter to avoid shadowing.
14766 (xmenu_show, xdialog_show, xmenu_show): Make local pointers "const"
14767 since they might point to immutable storage.
14768 (next_menubar_widget_id): Declare only if USE_X_TOOLKIT,
14769 since it's unused otherwise.
14771 * xdisp.c (produce_glyphless_glyph): Initialize lower_xoff.
14772 Add a FIXME, since the code still doesn't look right. (Bug#8215)
14773 (Fcurrent_bidi_paragraph_direction): Simplify slightly; this
14774 avoids a gcc -Wuninitialized diagnostic.
14775 (display_line, BUILD_COMPOSITE_GLYPH_STRING, draw_glyphs):
14776 (note_mouse_highlight): Mark variables that gcc -Wuninitialized
14777 does not deduce are never used uninitialized.
14779 * lisp.h (IF_LINT): New macro, copied from ../lib-src/emacsclient.c.
14781 * xdisp.c (redisplay_window): Rename local to avoid shadowing.
14782 * window.c (window_loop, size_window):
14783 (run_window_configuration_change_hook, enlarge_window): Likewise.
14785 * window.c (display_buffer): Now static.
14786 (size_window): Mark variables that gcc -Wuninitialized
14787 does not deduce are never used uninitialized.
14788 * window.h (check_all_windows): New decl, to forestall
14789 gcc -Wmissing-prototypes diagnostic.
14790 * dispextern.h (bidi_dump_cached_states): Likewise.
14792 * charset.h (CHECK_CHARSET_GET_CHARSET): Rename locals to avoid
14794 * charset.c (map_charset_for_dump, Fchar_charset): Likewise.
14795 Include <limits.h>.
14796 (Fsort_charsets): Redo min/max calculation to shorten the code a bit
14797 and to avoid gcc -Wuninitialized warning.
14798 (load_charset_map): Mark variables that gcc -Wuninitialized
14799 does not deduce are never used uninitialized.
14800 (load_charset): Abort instead of using uninitialized var (Bug#8229).
14802 * coding.c (coding_set_source, coding_set_destination):
14803 Use "else { /* comment */ }" rather than "else /* comment */;"
14804 for clarity, and to avoid gcc -Wempty-body warning.
14805 (Fdefine_coding_system_internal): Don't redeclare 'i' inside
14806 a block, when the outer 'i' will do.
14807 (decode_coding_utf_8, decode_coding_utf_16, detect_coding_emacs_mule):
14808 (emacs_mule_char, decode_coding_emacs_mule, detect_coding_iso_2022):
14809 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5):
14810 (decode_coding_raw_text, decode_coding_charset, get_translation_table):
14811 (Fdecode_sjis_char, Fdefine_coding_system_internal):
14812 Rename locals to avoid shadowing.
14813 * character.h (FETCH_STRING_CHAR_ADVANCE): Likewise.
14814 * coding.c (emacs_mule_char, encode_invocation_designation):
14815 Now static, since they're not used elsewhere.
14816 (decode_coding_iso_2022): Add "default: abort ();" as a safety check.
14817 (decode_coding_object, encode_coding_object, detect_coding_system):
14818 (decode_coding_emacs_mule): Mark variables that gcc
14819 -Wuninitialized does not deduce are never used uninitialized.
14820 (detect_coding_iso_2022): Initialize a local variable that might
14821 be used uninitialized. Leave a FIXME because it's not clear that
14822 this initialization is needed. (Bug#8211)
14823 (ISO_CODE_LF, ISO_CODE_CR, CODING_ISO_FLAG_EUC_TW_SHIFT):
14824 (ONE_MORE_BYTE_NO_CHECK, UTF_BOM, UTF_16_INVALID_P):
14825 (SHIFT_OUT_OK, ENCODE_CONTROL_SEQUENCE_INTRODUCER):
14826 (ENCODE_DIRECTION_R2L, ENCODE_DIRECTION_L2R):
14827 Remove unused macros.
14829 * category.c (hash_get_category_set): Remove unused local var.
14830 (copy_category_table): Now static, since it's not used elsewhere.
14831 * character.c (string_count_byte8): Likewise.
14833 * ccl.c (CCL_WRITE_STRING, CCL_ENCODE_CHAR, Fccl_execute_on_string):
14834 (Fregister_code_conversion_map): Rename locals to avoid shadowing.
14836 * chartab.c (copy_sub_char_table): Now static, since it's not used
14838 (sub_char_table_ref_and_range, char_table_ref_and_range):
14839 Rename locals to avoid shadowing.
14840 (ASET_RANGE, GET_SUB_CHAR_TABLE): Remove unused macros.
14842 * bidi.c (bidi_check_type): Now static, since it's not used elsewhere.
14843 (BIDI_BOB): Remove unused macro.
14845 * cm.c (cmgoto): Mark variables that gcc -Wuninitialized does not
14846 deduce are never used uninitialized.
14847 * term.c (encode_terminal_code): Likewise.
14849 * term.c (encode_terminal_code): Now static. Remove unused local.
14851 * tparam.h: New file.
14852 * term.c, tparam.h: Include it.
14853 * deps.mk (term.o, tparam.o): Depend on tparam.h.
14854 * term.c (tputs, tgetent, tgetflag, tgetnum, tparam, tgetstr):
14855 Move these decls to tparam.h, and make them agree with what
14856 is actually in tparam.c. The previous trick of using incompatible
14857 decls in different modules does not conform to the C standard.
14858 All callers of tparam changed to use tparam's actual API.
14859 * tparam.c (tparam1, tparam, tgoto):
14860 Use const pointers where appropriate.
14862 * cm.c (calccost, cmgoto): Use const pointers where appropriate.
14863 * cm.h (struct cm): Likewise.
14864 * dispextern.h (do_line_insertion_deletion_costs): Likewise.
14865 * scroll.c (ins_del_costs, do_line_insertion_deletion_costs): Likewise.
14866 * term.c (tty_ins_del_lines, calculate_costs, struct fkey_table):
14867 (term_get_fkeys_1, append_glyphless_glyph, produce_glyphless_glyph):
14868 (turn_on_face, init_tty): Likewise.
14869 * termchar.h (struct tty_display_info): Likewise.
14871 * term.c (term_mouse_position): Rename local to avoid shadowing.
14873 * alloc.c (mark_ttys): Move decl from here ...
14874 * lisp.h (mark_ttys): ... to here, so that it's checked against defn.
14876 2011-03-11 Andreas Schwab <schwab@linux-m68k.org>
14878 * .gdbinit (pwinx, xbuffer): Fix access to buffer name.
14880 2011-03-09 Juanma Barranquero <lekktu@gmail.com>
14882 * search.c (compile_pattern_1): Remove argument regp, unused since
14883 revid:rms@gnu.org-19941211082627-3x1g1wyqkjmwloig.
14884 (compile_pattern): Don't pass it.
14886 2011-03-08 Jan Djärv <jan.h.d@swipnet.se>
14888 * xterm.h (DEFAULT_GDK_DISPLAY): New define.
14889 (GDK_WINDOW_XID, gtk_widget_get_preferred_size): New defines
14891 (GTK_WIDGET_TO_X_WIN): Use GDK_WINDOW_XID.
14893 * xmenu.c (menu_position_func): Call gtk_widget_get_preferred_size.
14895 * gtkutil.c: Include gtkx.h if HAVE_GTK3. If ! HAVE_GTK3, define
14896 gdk_window_get_screen, gdk_window_get_geometry,
14897 gdk_x11_window_lookup_for_display and GDK_KEY_g.
14898 (xg_set_screen): Use DEFAULT_GDK_DISPLAY.
14899 (xg_get_pixbuf_from_pixmap): New function.
14900 (xg_get_pixbuf_from_pix_and_mask): Change parameters from GdkPixmap
14901 to Pixmap, take frame as parameter, remove GdkColormap parameter.
14902 Call xg_get_pixbuf_from_pixmap instead of
14903 gdk_pixbuf_get_from_drawable.
14904 (xg_get_image_for_pixmap): Do not make GdkPixmaps, call
14905 xg_get_pixbuf_from_pix_and_mask with Pixmap parameters instead.
14906 (xg_check_special_colors): Use GtkStyleContext and its functions
14908 (xg_prepare_tooltip, xg_hide_tooltip): Call gdk_window_get_screen.
14909 (xg_prepare_tooltip, create_dialog, menubar_map_cb)
14910 (xg_update_frame_menubar, xg_tool_bar_detach_callback)
14911 (xg_tool_bar_attach_callback, xg_update_tool_bar_sizes):
14912 Call gtk_widget_get_preferred_size.
14913 (xg_frame_resized): gdk_window_get_geometry only takes 5
14915 (xg_win_to_widget, xg_event_is_for_menubar):
14916 Call gdk_x11_window_lookup_for_display.
14917 (xg_set_widget_bg): New function.
14918 (delete_cb): New function.
14919 (xg_create_frame_widgets): Connect delete-event to delete_cb.
14920 Call xg_set_widget_bg. Only set background pixmap for ! HAVE_GTK3
14921 (xg_set_background_color): Call xg_set_widget_bg.
14922 (xg_set_frame_icon): Call xg_get_pixbuf_from_pix_and_mask.
14923 (xg_create_scroll_bar): vadj is a GtkAdjustment for HAVE_GTK3.
14924 Only call gtk_range_set_update_policy if ! HAVE_GTK3.
14925 (xg_make_tool_item): Only connect xg_tool_bar_item_expose_callback
14927 (update_frame_tool_bar): Call gtk_widget_hide.
14928 (xg_initialize): Use GDK_KEY_g.
14930 * xsmfns.c (gdk_set_sm_client_id): Define to gdk_set_sm_client_id
14932 (x_session_initialize): Call gdk_x11_set_sm_client_id.
14934 * xterm.c (XFillRectangle): Use cairo routines for HAVE_GTK3.
14935 (x_term_init): Disable Xinput(2) with GDK_CORE_DEVICE_EVENTS.
14936 Load ~/emacs.d/gtkrc only for ! HAVE_GTK3.
14938 2011-03-08 Juanma Barranquero <lekktu@gmail.com>
14940 * w32xfns.c (select_palette): Check success of RealizePalette against
14941 GDI_ERROR, not zero.
14943 See ChangeLog.11 for earlier changes.
14945 ;; Local Variables:
14949 Copyright (C) 2011-2012 Free Software Foundation, Inc.
14951 This file is part of GNU Emacs.
14953 GNU Emacs is free software: you can redistribute it and/or modify
14954 it under the terms of the GNU General Public License as published by
14955 the Free Software Foundation, either version 3 of the License, or
14956 (at your option) any later version.
14958 GNU Emacs is distributed in the hope that it will be useful,
14959 but WITHOUT ANY WARRANTY; without even the implied warranty of
14960 MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
14961 GNU General Public License for more details.
14963 You should have received a copy of the GNU General Public License
14964 along with GNU Emacs. If not, see <http://www.gnu.org/licenses/>.