1 2012-07-06 Paul Eggert <eggert@cs.ucla.edu>
3 Use c_strcasecmp for ASCII case-insensitive comparison (Bug#11786).
4 * dispextern.h, nsfns.m, nsterm.m: Include <c-strcase.h>.
5 * dispextern.h (xstrcasecmp): Rewrite using c_strcasecmp.
6 * nsfns.m (x_get_string_resource): Use c_strncasecmp, not strncasecmp.
7 * nsterm.m (ns_default): Use c_strcasecmp, not strcasecmp.
8 * xfaces.c (xstrcasecmp) [!HAVE_STRCASECMP]: Remove.
10 * xfont.c (compare_font_names): Redo to omit the need for casts.
12 2012-07-06 Andreas Schwab <schwab@linux-m68k.org>
14 * xfns.c (Fx_change_window_property): Doc fix.
15 * w32fns.c (Fx_change_window_property): Doc fix.
17 * w32fns.c (Fx_window_property): Accept the same arguments as the
18 X Windows version. Doc fix.
19 * xfns.c (Fx_window_property): Doc fix. (Bug#11870)
21 2012-07-06 Juanma Barranquero <lekktu@gmail.com>
22 Eli Zaretskii <eliz@gnu.org>
24 * s/ms-w32.h: Settings not specific to Windows moved to nt/config.nt.
25 Windows-specific code from nt/config.nt moved here.
26 Obsolete settings removed.
28 2012-07-06 Paul Eggert <eggert@cs.ucla.edu>
30 * process.c: Avoid unnecessary calls to gettime.
31 (wait_reading_process_output): Don't get the time of day
32 when gobbling data immediately and not waiting, as there's no need
33 for it in that case. This removes a FIXME.
35 2012-07-06 Jan Djärv <jan.h.d@swipnet.se>
37 * gtkutil.c (xg_event_is_for_scrollbar): Assign gwin when HAVE_GTK3
38 is defined (Bug#11768).
40 2012-07-06 Dmitry Antipov <dmantipov@yandex.ru>
42 Fix marker debugging code.
43 * marker.c (byte_char_debug_check): Do not perform the check
44 if buffer is not multibyte.
45 (buf_charpos_to_bytepos, buf_bytepos_to_charpos): Call
46 byte_char_debug_check with correct arguments.
48 2012-07-06 Dmitry Antipov <dmantipov@yandex.ru>
50 Compile marker debugging code only if ENABLE_CHECKING is defined.
51 * marker.c (byte_char_debug_check, count_markers): Use
52 only if ENABLE_CHECKING is defined.
53 (byte_debug_flag): Remove.
54 (CONSIDER, buf_charpos_to_bytepos, buf_bytepos_to_charpos):
55 Always call byte_char_debug_check if ENABLE_CHECKING is defined.
57 2012-07-06 Dmitry Antipov <dmantipov@yandex.ru>
59 Avoid code repetition in marker-related functions.
60 * marker.c (attach_marker): New function.
61 (Fset_marker, set_marker_restricted, set_marker_both)
62 (set_marker_restricted_both): Use it.
63 (Fset_marker, set_marker_restricted, Fbuffer_has_markers_at):
64 Consistently rename charno to charpos.
65 (marker_position): Add eassert.
66 (marker_byte_position): Convert to eassert.
68 2012-07-06 Dmitry Antipov <dmantipov@yandex.ru>
70 Simplify list operations in unchain_overlay and unchain_marker.
71 * buffer.c (unchain_overlay): Simplify. Add comment.
72 * marker.c (unchain_marker): Simplify. Fix comments.
74 2012-07-06 Dmitry Antipov <dmantipov@yandex.ru>
76 Introduce fast path for the widely used marker operation.
77 * alloc.c (build_marker): New function.
78 * lisp.h (build_marker): New prototype.
79 * buffer.c (clone_per_buffer_values, Fmake_indirect_buffer): Use it.
80 * composite.c (autocmp_chars): Likewise.
81 * editfns.c (buildmark): Remove.
82 (Fpoint_marker, Fpoint_min_marker, Fpoint_max_marker)
83 (save_restriction_save): Use build_marker.
84 * marker.c (buf_charpos_to_bytepos, buf_bytepos_to_charpos): Likewise.
85 * window.c (save_window_save): Likewise.
87 2012-07-06 Dmitry Antipov <dmantipov@yandex.ru>
89 Do not use Fdelete_overlay in delete_all_overlays
90 to avoid redundant calls to unchain_overlay.
91 * buffer.c (drop_overlay): New function.
92 (delete_all_overlays, Fdelete_overlay): Use it.
93 * minibuf.c (get_minibuffer): Fix comment.
95 2012-07-06 Paul Eggert <eggert@cs.ucla.edu>
97 Port to OpenBSD 5.1 amd64.
98 * sysdep.c [BSD_SYSTEM]: Include <sys/param.h> before <sys/sysctl.h>.
99 This is needed for OpenBSD, and should be harmless on all BSD systems.
100 Also, include <sys/sysctl.h>, as it should be available on all
101 BSD_SYSTEM hosts given that we're already calling sysctl in that case.
102 (list_system_processes) [__OpenBSD__]: Use DARWIN_OS style mib, but
103 use p_pid member, not kp_proc.pid.
105 2012-07-06 Glenn Morris <rgm@gnu.org>
107 * Makefile.in (emacs$(EXEEXT)): Don't check for load-path shadows.
109 2012-07-05 Paul Eggert <eggert@cs.ucla.edu>
111 More xmalloc and related cleanup.
112 * alloc.c, bidi.c, buffer.c, buffer.h, bytecode.c, callint.c:
113 * callproc.c, charset.c, coding.c, composite.c, data.c, dispnew.c:
114 * doc.c, editfns.c, emacs.c, eval.c, fileio.c, filelock.c, fns.c:
115 * font.c, fontset.c, frame.c, fringe.c, ftfont.c, ftxfont.c, gmalloc.c:
116 * gtkutil.c, image.c, keyboard.c, keymap.c, lread.c, macros.c, menu.c:
117 * nsfns.m, nsfont.m, nsmenu.m, nsterm.m, print.c, process.c, ralloc.c:
118 * regex.c, region-cache.c, scroll.c, search.c, sound.c, syntax.c:
119 * sysdep.c, term.c, termcap.c, unexmacosx.c, window.c, xdisp.c:
120 * xfaces.c, xfns.c, xftfont.c, xgselect.c, xmenu.c, xrdb.c, xselect.c:
122 Omit needless casts involving void * pointers and allocation.
123 Prefer "P = xmalloc (sizeof *P)" to "P = xmalloc (sizeof (TYPE_OF_P))",
124 as the former is more robust if P's type is changed.
125 Prefer xzalloc to xmalloc + memset 0.
126 Simplify malloc-or-realloc to realloc.
127 Don't worry about xmalloc returning a null pointer.
128 Prefer xstrdup to xmalloc + strcpy.
129 * editfns.c (Fmessage_box): Grow message_text by at least 80 when
131 * keyboard.c (apply_modifiers_uncached): Prefer local array to
132 alloca of a constant.
134 2012-07-05 Eli Zaretskii <eliz@gnu.org>
136 * xdisp.c (display_line): Fix horizontal pixel coordinates when
137 hscroll is larger than the line width. Fixes long and futile
138 looping inside extend_face_to_end_of_line (on a TTY) producing
139 glyphs that are not needed and thrown away.
141 2012-07-05 Dmitry Antipov <dmantipov@yandex.ru>
143 * marker.c (set_marker_restricted_both): Simplify by using
146 2012-07-05 Paul Eggert <eggert@cs.ucla.edu>
148 * editfns.c (region_limit): Simplify by using clip_to_bounds.
150 2012-07-05 Jan Djärv <jan.h.d@swipnet.se>
152 * gtkutil.c (gtk_scrollbar_new, gtk_box_new): Define when HAVE_GTK3 is
153 not defined (Bug#11768).
154 (xg_create_frame_widgets): Use gtk_plug_new_for_display (Bug#11768).
155 (xg_create_frame_widgets, create_dialog, xg_get_file_with_chooser)
156 (make_widget_for_menu_item, xg_make_tool_item): Use gtk_box_new
157 followed by gtk_box_set_homogeneous (Bug#11768).
158 (xg_update_menu_item): Use GTK_IS_BOX (Bug#11768).
159 (update_theme_scrollbar_width, xg_create_scroll_bar): Use
160 gtk_scrollbar_new (Bug#11768).
161 (xg_event_is_for_scrollbar): Use Gdk Device functions for HAVE_GTK3.
162 (is_box_type): New function (Bug#11768).
163 (xg_tool_item_stale_p): Call is_box_type.
164 (xg_initialize): Get settings by calling gtk_settings_get_for_screen
165 with default display (Bug#11768).
167 2012-07-05 Eli Zaretskii <eliz@gnu.org>
169 * xdisp.c (window_hscroll_limited): New function.
170 (pos_visible_p, init_iterator): Use it to avoid overflow of pixel
171 coordinates when window's hscroll is set to insanely large
174 2012-07-05 Juanma Barranquero <lekktu@gmail.com>
176 * makefile.w32-in ($(BLD)/dired.$(O), $(BLD)/fileio.$(O)): Fix typo.
177 ($(BLD)/terminal.$(O), $(BLD)/syntax.$(O)): Update dependencies.
179 2012-07-05 Dmitry Antipov <dmantipov@yandex.ru>
182 * lisp.h (xzalloc): New prototype. Omit needless casts.
183 * alloc.c (xzalloc): New function. Omit needless casts.
184 * charset.c: Omit needless casts. Convert all calls to
185 xmalloc with following memset to xzalloc.
186 * dispnew.c: Likewise.
187 * fringe.c: Likewise.
191 * w32fns.c: Likewise.
192 * w32font.c: Likewise.
193 * w32term.c: Likewise.
194 * xfaces.c: Likewise.
197 * atimer.c: Omit needless casts.
198 * buffer.c: Likewise.
199 * callproc.c: Likewise.
201 * coding.c: Likewise.
202 * composite.c: Likewise.
204 * doprnt.c: Likewise.
205 * editfns.c: Likewise.
208 * filelock.c: Likewise.
210 * gtkutil.c: Likewise.
211 * keyboard.c: Likewise.
214 * minibuf.c: Likewise.
217 * process.c: Likewise.
218 * region-cache.c: Likewise.
219 * search.c: Likewise.
220 * sysdep.c: Likewise.
221 * termcap.c: Likewise.
222 * terminal.c: Likewise.
223 * tparam.c: Likewise.
224 * w16select.c: Likewise.
226 * w32reg.c: Likewise.
227 * w32select.c: Likewise.
228 * w32uniscribe.c: Likewise.
229 * widget.c: Likewise.
233 * xselect.c: Likewise.
235 2012-07-05 Paul Eggert <eggert@cs.ucla.edu>
237 * fileio.c (time_error_value): Check the right error number.
238 Problem reported by Troels Nielsen in
239 <http://lists.gnu.org/archive/html/emacs-devel/2012-07/msg00095.html>.
241 2012-07-04 Paul Eggert <eggert@cs.ucla.edu>
243 * window.c (set_window_hscroll): Revert the 100000 hscroll limit.
244 This should be fixed in a better way; see Eli Zaretskii in
245 <http://lists.gnu.org/archive/html/emacs-devel/2012-07/msg00088.html>.
246 (HSCROLL_MAX): Remove; this is now internal to set_window_hscroll.
248 * fileio.c (time_error_value): Rename from special_mtime.
249 The old name's problems were noted by Eli Zaretskii in
250 <http://lists.gnu.org/archive/html/emacs-devel/2012-07/msg00087.html>.
252 * emacs.c (gdb_pvec_type): Change it back to enum pvec_type.
253 This variable's comment says Emacs needs at least one GDB-visible
254 symbol of type enum pvec_type, to work around GDB problems.
255 The symbol's value doesn't matter.
257 * alloc.c (PSEUDOVECTOR_NBYTES): Remove stray ';'
258 that causes compilation to fail on pre-C99 compilers.
260 2012-07-04 Juanma Barranquero <lekktu@gmail.com>
262 * s/ms-w32.h (LISP_FLOAT_TYPE, HAVE_MEMCMP, HAVE_MEMCPY)
263 (HAVE_MEMMOVE, HAVE_MEMSET): Don't set, obsolete.
265 2012-07-04 Dmitry Antipov <dmantipov@yandex.ru>
267 * buffer.c (init_buffer_once): Fix initialization of
268 headers for buffer_defaults and buffer_local_symbols.
269 Reported by Juanma Barranquero <lekktu@gmail.com>.
271 2012-07-04 Stefan Monnier <monnier@iro.umontreal.ca>
273 Turn VECTOR_FREE_LIST_FLAG into PVEC_FREE.
274 * lisp.h (enum pvec_type): Use fewer bits.
275 (PSEUDOVECTOR_SIZE_BITS): New constant.
276 (PSEUDOVECTOR_SIZE_MASK, PVEC_TYPE_MASK): Use it.
277 (XSETPVECTYPESIZE, XSETTYPED_PSEUDOVECTOR, DEFUN): Adapt code to
279 (PSEUDOVECTOR_TYPEP): New macro.
280 (TYPED_PSEUDOVECTORP): Use it.
281 * fns.c (internal_equal): Adapt code to extract pvectype.
282 * emacs.c (gdb_pvec_type): Update type.
283 * alloc.c (PSEUDOVECTOR_NBYTES): New macro.
284 (VECTOR_FREE_LIST_SIZE_MASK): Remove (=> PSEUDOVECTOR_SIZE_MASK).
285 (VECTOR_FREE_LIST_FLAG): Remove (=> PVEC_FREE).
286 (SETUP_ON_FREE_LIST): Use XSETPVECTYPESIZE.
287 (sweep_vectors): Use it. Use local var `total_bytes' instead of
288 abusing vector->header.next.nbytes.
289 (live_vector_p): Use PVEC_TYPE.
290 (mark_object): Adapt code to extract pvectype. Use switch.
292 2012-07-04 Paul Eggert <eggert@cs.ucla.edu>
294 * doprnt.c (doprnt): Don't assume string length fits in 'int'.
295 Tighten new eassert a bit.
297 2012-07-04 Dmitry Antipov <dmantipov@yandex.ru>
299 Fix compilation with --enable-gcc-warnings and -O1
301 * doprnt.c (doprnt): Change type of tem to int, initialize
302 to avoid compiler warning. Add eassert.
303 * search.c (simple_search): Initialize match_byte to avoid
304 compiler warning. Add eassert.
306 2012-07-04 Paul Eggert <eggert@cs.ucla.edu>
308 Avoid weird behavior with large horizontal scrolls.
309 Without this change, for example, large hscroll values would
310 mess up Emacs's display on Fedora 15 x86, presumably due to
311 overflows in int calculations in the display code.
312 Also, if buffers had long lines, Emacs would freeze.
313 * window.c (HSCROLL_MAX): Reduce to 100000, and make it visible to GDB.
314 (set_window_hscroll): New function, containing the old guts of
315 Fset_window_hscroll. Return the clipped value.
316 (Fset_window_hscroll, Fscroll_left, Fscroll_right): Use it.
317 This avoids the need to check against PTRDIFF_MAX.
319 * buffer.c (Fgenerate_new_buffer_name): Fix sprintf format mismatch.
321 2012-07-04 Dmitry Antipov <dmantipov@yandex.ru>
323 * buffer.c (Fgenerate_new_buffer_name): Fix type mismatch.
325 2012-07-04 Paul Eggert <eggert@cs.ucla.edu>
327 * regex.c: Suppress GCC warning on RHEL 6. (Bug#11207)
328 Conditionalize the pragmas on GCC 4.5 or later, not GCC 4.3 or later,
329 since GCC 4.4.6 issues a bogus warning for them.
331 Fix bugs in file timestamp newness comparisons.
332 * fileio.c (Ffile_newer_than_file_p):
333 * lread.c (Fload): Use full timestamp resolution of files,
334 not just the 1-second resolution, so that files that are only
335 slightly newer still count as newer.
336 * fileio.c (Ffile_newer_than_file_p): Don't assume file
337 timestamps fit in 'int'; this fixes a Y2038 bug on most hosts.
339 2012-07-03 Paul Eggert <eggert@cs.ucla.edu>
341 * fileio.c: Improve handling of file time marker. (Bug#11852)
342 (special_mtime): New function.
343 (Finsert_file_contents, Fverify_visited_file_modtime):
344 Use it to set special mtime values consistently.
346 2012-07-03 Andreas Schwab <schwab@linux-m68k.org>
348 * fileio.c (Finsert_file_contents): Properly handle st_mtime
349 marker for non-existing file. (Bug#11852)
351 2012-07-03 Glenn Morris <rgm@gnu.org>
353 * lisp.h (Fread_file_name): Restore EXFUN (it's not a normal DEFUN
354 and did not make it into globals.h).
356 2012-07-03 Tom Tromey <tromey@redhat.com>
358 * window.c (Fset_window_margins, Fset_window_fringes)
359 (Fset_window_scroll_bars, Fset_window_vscroll): No longer static.
360 * textprop.c (Fprevious_property_change): No longer static.
361 * syntax.c (Fsyntax_table_p): No longer static.
362 * process.c (Fget_process, Fprocess_datagram_address): No longer
364 * keymap.c (Flookup_key, Fcopy_keymap): No longer static.
365 * keyboard.c (Fcommand_execute): No longer static.
367 * insdel.c (Fcombine_after_change_execute): No longer static.
368 * image.c (Finit_image_library): No longer static.
369 * fileio.c (Fmake_symbolic_link): No longer static.
370 * eval.c (Ffetch_bytecode): No longer static.
371 * editfns.c (Fuser_full_name): No longer static.
372 * doc.c (Fdocumentation_property, Fsnarf_documentation):
374 * buffer.c (Fset_buffer_major_mode, Fdelete_overlay): No longer
376 * dired.c (Ffile_attributes): No longer static.
377 * composite.c (Fcomposition_get_gstring): No longer static.
378 * callproc.c (Fgetenv_internal): No longer static.
380 * ccl.h: Remove EXFUNs.
381 * buffer.h: Remove EXFUNs.
382 * dispextern.h: Remove EXFUNs.
383 * intervals.h: Remove EXFUNs.
384 * fontset.h: Remove EXFUN.
385 * font.h: Remove EXFUNs.
386 * dosfns.c (system_process_attributes): Remove EXFUN.
387 * keymap.h: Remove EXFUNs.
388 * lisp.h: Remove EXFUNs.
389 * w32term.h: Remove EXFUNs.
390 * window.h: Remove EXFUNs.
391 * xsettings.h: Remove EXFUN.
392 * xterm.h: Remove EXFUN.
394 2012-07-03 Glenn Morris <rgm@gnu.org>
396 * lisp.h (Frandom): Make it visible to C.
397 * buffer.c (Fgenerate_new_buffer_name): Speed up finding a new
398 buffer for invisible buffers. (Bug#1229)
400 2012-07-03 Dmitry Antipov <dmantipov@yandex.ru>
402 Fix block vector allocation code to allow VECTOR_BLOCK_SIZE
403 values which aren't power of 2.
404 * alloc.c (VECTOR_FREE_LIST_SIZE_MASK): New macro. Verify
405 it's value and the value of VECTOR_BLOCK_SIZE. Adjust users
408 2012-07-03 Stefan Monnier <monnier@iro.umontreal.ca>
410 * lisp.h (Lisp_Misc, Lisp_Fwd): Move around to group better.
412 * alloc.c (mark_object): Revert part of last patch to use `switch'.
414 2012-07-03 Dmitry Antipov <dmantipov@yandex.ru>
416 * alloc.c (allocate_vector_block): Remove redundant
417 calls to mallopt if DOUG_LEA_MALLOC is defined.
418 (allocate_vectorlike): If DOUG_LEA_MALLOC is defined,
419 avoid calls to mallopt if zero_vector is returned.
421 2012-07-03 Dmitry Antipov <dmantipov@yandex.ru>
423 * alloc.c (check_string_bytes): If GC_CHECK_STRING_BYTES
424 is enabled, avoid dereferencing NULL current_sblock if
427 2012-07-03 Dmitry Antipov <dmantipov@yandex.ru>
429 Cleanup basic buffer management.
430 * buffer.h (struct buffer): Change layout to use generic vector
431 marking code. Fix some comments. Change type of 'clip_changed'
432 to bitfield. Remove unused #ifndef old.
433 (FIRST_FIELD_PER_BUFFER, LAST_FIELD_PER_BUFFER): Remove.
434 (GET_OVERLAYS_AT): Fix indentation.
435 (for_each_per_buffer_object_at): New macro.
436 * buffer.c (clone_per_buffer_values, reset_buffer_local_variables)
437 (Fbuffer_local_variables): Use it.
438 (init_buffer_once, syms_of_buffer): Remove unused #ifndef old.
439 * alloc.c (allocate_buffer): Adjust to match new layout of
440 struct buffer. Fix comment.
441 (mark_overlay): New function.
442 (mark_buffer): Use it. Use mark_vectorlike to mark normal
443 Lisp area of struct buffer.
444 (mark_object): Use it. Adjust marking of misc objects
445 and related comments.
447 2012-07-02 Paul Eggert <eggert@cs.ucla.edu>
449 * alloc.c (mark_object): Remove "#ifdef GC_CHECK_MARKED_OBJECTS"
450 wrapper that is not needed because the wrapped code is a no-op (zero
451 machine instructions) when GC_CHECK_MARKED_OBJECTS is not defined.
452 This avoids a -Wunused-macros diagnostic with GCC 4.7.1 x86-64.
454 2012-07-02 Dmitry Antipov <dmantipov@yandex.ru>
456 * alloc.c (mark_buffer): Simplify. Remove prototype.
457 (mark_object): Add comment. Reorganize marking of vector-like
458 objects. Use CHECK_LIVE for all vector-like objects except buffers
459 and subroutines when GC_CHECK_MARKED_OBJECTS is defined. Avoid
460 redundant calls to mark_vectorlike for bool vectors.
462 2012-06-30 Glenn Morris <rgm@gnu.org>
464 * nsterm.m (ns_init_paths): Ignore site-lisp if --no-site-lisp.
466 * epaths.in (PATH_SITELOADSEARCH): New.
467 * lread.c (init_lread): Use PATH_SITELOADSEARCH.
468 This is rather than relying on --enable-locallisppath elements
469 having "site-lisp" in their names. (Bug#10208#25, 11658)
471 2012-06-30 Eli Zaretskii <eliz@gnu.org>
473 * w32proc.c (sys_select): Accept and ignore one more argument.
475 * w32.c (emacs_gnutls_pull): Call select with one more argument.
477 * sysselect.h [DOS_NT]: Don't include sys/select.h.
478 (pselect) [!MS_DOS]: Redirect to sys_select.
480 * sysdep.c: Don't include dos.h and dosfns.h.
482 * process.c (sys_select):
483 * msdos.c (sys_select): Accept one more argument and ignore it.
485 * msdos.c (event_timestamp, sys_select): Use gnulib's gettime;
486 adapt data types and code to that.
489 * msdos.c (gettime, settime): Define away the prototypes in dos.h,
490 which clashes with the gnulib function of the same name.
492 2012-06-30 Andreas Schwab <schwab@linux-m68k.org>
494 * font.c (font_style_to_value, font_style_symbolic)
495 (font_prop_validate_style): Add type checks for values in
498 * lisp.h (CHECK_RANGED_INTEGER): Make value to check the first
500 * character.c, charset.c, menu.c, process.c, window.c: Adjust all
503 2012-06-29 Eli Zaretskii <eliz@gnu.org>
505 * xdisp.c (try_window_id): Undo last change.
507 * w32.c (getwd): Adjust commentary about startup_dir.
508 (init_environment): Always call sys_access, even in non-MSVC
509 builds. Don't chdir to the directory of the Emacs executable.
510 This undoes code from 1997 which was justified by the need to
511 "avoid conflicts when removing and renaming directories". But its
512 downside was that every relative file name was being interpreted
513 relative to the directory of the Emacs executable, which can never
514 be TRT. In particular, it broke sys_access when called with
516 (sys_access): Map GetLastError to errno.
518 2012-06-29 Dmitry Antipov <dmantipov@yandex.ru>
520 * window.h (struct window): Change type of 'fringes_outside_margins'
521 to bitfield. Fix comment. Adjust users accordingly.
522 (struct window): Change type of 'window_end_bytepos' to ptrdiff_t.
524 * xdisp.c (try_window_id): Change type of 'first_vpos' and 'vpos'
527 2012-06-29 Andreas Schwab <schwab@linux-m68k.org>
529 * gnutls.c (emacs_gnutls_handshake):
530 Add QUIT to make the loop interruptible.
532 2012-06-29 Glenn Morris <rgm@gnu.org>
534 * charset.c (init_charset): Make lack of etc/charsets fatal.
536 2012-06-29 Dmitry Antipov <dmantipov@yandex.ru>
538 * editfns.c (region_limit): Fix type mismatch.
540 2012-06-29 Dmitry Antipov <dmantipov@yandex.ru>
542 * nsfns.m: Fix GLYPH_DEBUG usage assuming that it may be
543 undefined. Convert from xassert to eassert.
544 * nsmenu.m: Convert from xassert to eassert.
545 * nsterm.m: Likewise.
547 2012-06-28 Stefan Monnier <monnier@iro.umontreal.ca>
549 * editfns.c (region_limit): Clip to narrowing (bug#11770).
551 2012-06-28 Paul Eggert <eggert@cs.ucla.edu>
553 Avoid integer overflow on scroll-left and scroll-right.
554 * window.c (HSCROLL_MAX): New macro.
555 (Fscroll_left, Fscroll_right): Avoid undefined behavior on integer
556 overflow when requested scroll falls outside ptrdiff_t range.
558 2012-06-28 Dmitry Antipov <dmantipov@yandex.ru>
560 * window.h (struct window): Change type of 'hscroll',
561 'min_hscroll' and 'last_point' from Lisp_Object to ptrdiff_t,
562 'last_modified' and 'last_overlay_modified' to EMACS_INT.
563 Adjust users accordingly.
564 * xdisp.c (try_cursor_movement): Replace type check with eassert.
565 * window.c (Fscroll_left, Fscroll_right): Change type of 'hscroll'
566 from EMACS_INT to ptrdiff_t.
567 (make_window): Omit redundant initialization.
569 2012-06-28 Juanma Barranquero <lekktu@gmail.com>
571 * makefile.w32-in ($(BLD)/regex.$(O)): Update dependencies.
573 2012-06-28 Dmitry Antipov <dmantipov@yandex.ru>
575 * window.h (struct window): Change type of 'use_time' and
576 'sequence_number' from Lisp_Object to int.
577 * frame.c (make_frame): Adjust users accordingly.
578 * print.c (print_object): Likewise.
579 * window.c (select_window, Fwindow_use_time, make_parent_window)
580 (make_window): Likewise.
582 2012-06-28 Dmitry Antipov <dmantipov@yandex.ru>
584 * dispextern.h (GLYPH_DEBUG): Now defined in config.h if
585 enabled with --enable-checking=[all,glyphs] configure option.
586 Fix GLYPH_DEBUG usage assuming that it may be undefined,
587 adjust comments accordingly.
588 * dispnew.c: Fix GLYPH_DEBUG usage assuming that it may be
589 undefined, adjust comments accordingly.
591 * scroll.c: Likewise.
592 * w32fns.c: Likewise.
593 * w32term.c: Likewise.
595 * xfaces.c: Likewise.
599 2012-06-28 Dmitry Antipov <dmantipov@yandex.ru>
601 Generalize run-time debugging checks.
602 * dispextern.h (XASSERTS): Remove.
603 * fontset.c (xassert): Remove.
604 Convert from xassert to eassert.
605 * alloc.c: Convert from xassert to eassert.
607 * dispnew.c: Likewise.
609 * fringe.c: Likewise.
610 * ftfont.c: Likewise.
611 * gtkutil.c: Likewise.
613 * keyboard.c: Likewise.
615 * process.c: Likewise.
616 * scroll.c: Likewise.
619 * w32console.c: Likewise.
620 * w32fns.c: Likewise.
621 * w32term.c: Likewise.
622 * window.c: Likewise.
624 * xfaces.c: Likewise.
626 * xselect.c: Likewise.
629 2012-06-27 Stefan Monnier <monnier@iro.umontreal.ca>
631 * fns.c (maybe_resize_hash_table): Output message when growing the
634 2012-06-27 Dmitry Antipov <dmantipov@yandex.ru>
636 * alloc.c (allocate_string_data): Remove dead code.
637 * xsettings.c (XSETTINGS_FONT_NAME): Move under HAVE_XFT to
638 avoid GCC warning about unused macro.
640 2012-06-27 Dmitry Antipov <dmantipov@yandex.ru>
642 * alloc.c (allocate_string): Omit intervals initialization.
643 * alloc.c (make_uninit_multibyte_string): Initialize intervals
644 as in make_pure_string and make_pure_c_string.
646 2012-06-27 Dmitry Antipov <dmantipov@yandex.ru>
648 * alloc.c (allocate_string): Fix last change.
650 2012-06-27 Dmitry Antipov <dmantipov@yandex.ru>
652 * alloc.c (allocate_string): Remove two redundant calls
653 to memset, add explicit initialization where appropriate.
655 2012-06-27 Glenn Morris <rgm@gnu.org>
657 * lisp.mk (lisp): Remove paths.elc.
659 2012-06-27 Chong Yidong <cyd@gnu.org>
661 * doc.c (Fsubstitute_command_keys): Fix punctuation.
663 2012-06-26 John Wiegley <johnw@newartisans.com>
665 * unexmacosx.c (copy_data_segment): Add two section names used
666 on Mac OS X Lion: __mod_init_func and __mod_term_func.
668 * alloc.c (mark_memory): Do not check with -faddress-sanitizer
669 when building with Clang.
671 2012-06-26 Stefan Monnier <monnier@iro.umontreal.ca>
673 * eval.c (Fapply): Allow calling it with a single argument.
675 2012-06-26 Eli Zaretskii <eliz@gnu.org>
677 * s/ms-w32.h (strcasecmp, strncasecmp) [_MSC_VER]: Redirect to
678 _stricmp and _strnicmp.
679 (HAVE_STRCASECMP, HAVE_STRNCASECMP): Define to 1.
681 2012-06-26 Dmitry Antipov <dmantipov@yandex.ru>
683 * alloc.c (allocate_window): Zero out non-Lisp part of newly
685 (allocate_process): Likewise for new process.
686 (allocate_terminal): Change to use offsetof.
687 (allocate_frame): Likewise.
688 * frame.c (make_frame): Omit redundant initialization.
689 * window.c (make_parent_window): Use memset.
690 (make_window): Omit redundant initialization.
691 * process.c (make_process): Omit redundant initialization.
692 * terminal.c (create_terminal): Likewise.
694 2012-06-26 Dmitry Antipov <dmantipov@yandex.ru>
696 * term.c (delete_tty): Remove redundant call to memset.
698 2012-06-26 Dmitry Antipov <dmantipov@yandex.ru>
700 * alloc.c: Remove build_string.
701 * lisp.h: Define build_string as static inline. This provides
702 a better opportunity to optimize away calls to strlen when the
703 function is called with compile-time constant argument.
704 * image.c (imagemagick_error): Convert to build_string.
705 * w32proc.c (sys_spawnve): Likewise.
706 * xterm.c (x_term_init): Likewise.
708 2012-06-26 Paul Eggert <eggert@cs.ucla.edu>
710 Use sprintf return value instead of invoking strlen on result.
711 In the old days this wasn't portable, since some sprintf
712 implementations returned char *. But they died out years ago and
713 Emacs already assumes sprintf returns int.
714 Similarly for float_to_string.
715 This patch speeds up (number-to-string 1000) by 3% on Fedora 15 x86-64.
716 * ccl.c (ccl_driver):
717 * character.c (string_escape_byte8):
718 * data.c (Fnumber_to_string):
720 * print.c (print_object):
721 * xdisp.c (message_dolog):
722 * xfns.c (syms_of_xfns):
723 Use sprintf or float_to_string result to avoid need to call strlen.
724 * data.c (Fnumber_to_string):
725 Use make_unibyte_string, since the string must be ASCII.
726 * lisp.h, print.c (float_to_string): Now returns int length.
727 * term.c (produce_glyphless_glyph):
728 Use sprintf result rather than recomputing it.
730 Clean out last vestiges of the old HAVE_CONFIG_H stuff.
731 * Makefile.in (ALL_CFLAGS):
732 * makefile.w32-in (LOCAL_FLAGS): Remove -DHAVE_CONFIG_H.
733 * gmalloc.c, regex.c: Include <config.h> unconditionally.
735 2012-06-25 Dmitry Antipov <dmantipov@yandex.ru>
737 * dispextern.h (xstrcasecmp): Define to library function
738 strcasecmp if available.
739 * xfaces.c: Do not use xstrcasecmp if strcasecmp is available.
741 2012-06-25 Andreas Schwab <schwab@linux-m68k.org>
743 * keyboard.c (menu_bar_items, menu_bar_item, read_key_sequence):
744 Avoid comma operator.
745 * menu.c (push_submenu_start, push_submenu_end)
746 (push_left_right_boundary, push_menu_pane): Likewise.
747 * msdos.c (dos_rawgetc): Likewise.
749 2012-06-25 Dmitry Antipov <dmantipov@yandex.ru>
751 * xfns.c (xic_create_fontsetname): Remove redundant calls
754 2012-06-25 Paul Eggert <eggert@cs.ucla.edu>
756 * gtkutil.c (get_utf8_string): Remove redundant assignment.
757 sprintf already null-terminates its output.
759 * xfns.c (x_window): Remove redundant cast.
761 2012-06-25 Dmitry Antipov <dmantipov@yandex.ru>
763 * xmenu.c (xmenu_show, xdialog_show): Explicit cast from
764 `const char *' to `char *' to avoid compiler warning.
766 2012-06-24 Paul Eggert <eggert@cs.ucla.edu>
768 * xterm.c (x_term_init): Build proper-sized _XSETTINGS_Snnn string
769 instead of truncating it to 63 (admittedly a generous limit).
771 * process.c: Fix spelling and caps in comments.
773 2012-06-24 Dan Nicolaescu <dann@ics.uci.edu>
775 * emacs.c (setpgrp): Remove definition, unused.
776 * sysdep.c (setpgrp): Remove definition, not used in this file.
778 2012-06-24 Juanma Barranquero <lekktu@gmail.com>
780 * makefile.w32-in: Update dependencies.
782 2012-06-24 Eli Zaretskii <eliz@gnu.org>
784 * makefile.w32-in (TIMESPEC_H): Remove nt/inc/sys/time.h.
785 (SYSTIME_H): Add nt/inc/sys/time.h.
787 * systime.h [WINDOWSNT]: Include sys/time.h.
789 * s/ms-w32.h (struct timespec): Definition moved from
790 nt/inc/sys/time.h. Suggested by Paul Eggert <eggert@cs.ucla.edu>.
792 2012-06-24 Paul Eggert <eggert@cs.ucla.edu>
794 Switch from NO_RETURN to C11's _Noreturn (Bug#11750).
795 * buffer.h (buffer_slot_type_mismatch):
796 * data.c (arith_error) [!FORWARD_SIGNAL_TO_MAIN_THREAD]:
797 * eval.c (unwind_to_catch):
798 * image.c (my_png_error, my_error_exit):
799 * keyboard.c (quit_throw_to_read_char, user_error)
800 (Fexit_recursive_edit, Fabort_recursive_edit):
801 * lisp.h (die, args_out_of_range, args_out_of_range_3)
802 (wrong_type_argument, buffer_overflow, __executable_start)
803 (memory_full, buffer_memory_full, string_overflow, Fthrow)
804 (xsignal, xsignal0, xsignal1, xsignal2, xsignal3, signal_error)
805 (error, verror, nsberror, report_file_error, Ftop_level, Fkill_emacs)
807 (child_setup) [!DOS_NT]:
808 * lread.c (end_of_file_error, invalid_syntax):
809 * process.c (send_process_trap) [!FORWARD_SIGNAL_TO_MAIN_THREAD]:
810 * puresize.h (pure_write_error):
811 * search.c (matcher_overflow):
812 * sound.c (sound_perror, alsa_sound_perror):
813 * sysdep.c, syssignal.h (croak):
814 * term.c (maybe_fatal, vfatal):
815 * textprop.c (text_read_only):
816 * undo.c (user_error):
817 * unexmacosx.c (unexec_error):
818 * xterm.c (x_ins_del_lines, x_delete_glyphs):
819 Use _Noreturn rather than NO_RETURN.
820 No need for separate decl merely because of _Noreturn.
821 * sound.c (sound_warning, parse_sound):
822 Remove unnecessary forward decls.
824 2012-06-24 Paul Eggert <eggert@cs.ucla.edu>
826 Fix bug when time_t is unsigned and as wide as intmax_t (Bug#9000).
827 * lisp.h (WAIT_READING_MAX): New macro.
828 * dispnew.c (Fsleep_for, sit_for):
829 * keyboard.c (kbd_buffer_get_event):
830 * process.c (Faccept_process_output):
831 Use it to avoid bogus compiler warnings with obsolescent GCC versions.
832 This improves on the previous patch, which introduced a bug
833 when time_t is unsigned and as wide as intmax_t.
834 See <http://bugs.gnu.org/9000#51>.
836 2012-06-23 Eli Zaretskii <eliz@gnu.org>
838 * dispnew.c (sit_for, Fsleep_for):
839 * keyboard.c (kbd_buffer_get_event):
840 * process.c (Faccept_process_output): Avoid compiler warnings when
841 comparing a 32-bit time_t with a 64-bit INTMAX_MAX.
843 2012-06-23 Juanma Barranquero <lekktu@gmail.com>
845 * makefile.w32-in: Update dependencies.
847 * w32.c (ltime): Add return type and declare static.
848 (w32_get_internal_run_time): Remove usused variable `time_100ns'.
850 2012-06-23 Paul Eggert <eggert@cs.ucla.edu>
852 * sysdep.c [__FreeBSD__]: Fix more recently-introduced typos.
853 Privately reported by Herbert J. Skuhra.
854 (make_lisp_timeval) [__FreeBSD__]: Rename from TIMELIST.
856 (system_process_attributes) [__FreeBSD__]: Invoke make_lisp_time,
857 not make_lisp_timeval, when the argument is of type EMACS_TIME.
859 2012-06-23 Eli Zaretskii <eliz@gnu.org>
861 * w32proc.c (Fw32_get_locale_info): Fix an off-by-one error in
862 last argument of make_unibyte_string.
864 * keyboard.c (kbd_buffer_get_event): Include the codepage and the
865 language ID in the event parameters.
867 * w32term.c (w32_read_socket): Put the new keyboard codepage into
868 event.code, not the obscure "character set ID".
870 2012-06-23 Chong Yidong <cyd@gnu.org>
872 * xmenu.c (x_menu_wait_for_event): Adapt GTK3 to new xg_select.
874 2012-06-23 Eli Zaretskii <eliz@gnu.org>
876 Fix the MS-Windows build broken by 2012-06-22T21:17:42Z!eggert@cs.ucla.edu.
877 * w32.c (fdutimens): New function.
879 * w32proc.c (sys_select): Adapt to change in the EMACS_TIME type.
881 * s/ms-w32.h (pselect): Redirect to sys_select.
883 * sysselect.h [WINDOWSNT]: Don't include sys/select.h.
885 * ralloc.c (r_alloc_inhibit_buffer_relocation): Fix stupid thinko
886 in the logic of incrementing and decrementing the value of
887 use_relocatable_buffers.
889 2012-06-23 Paul Eggert <eggert@cs.ucla.edu>
891 * sysdep.c [__FreeBSD__]: Fix recently-introduced typos.
892 Privately reported by Herbert J. Skuhra.
893 [__FreeBSD__]: Remove "*/" typo after "#include".
894 (timeval_to_EMACS_TIME) [__FreeBSD__]: New static function.
895 (TIMEVAL) [__FreeBSD__]: Now a static function rather than a macro.
896 (TIMEVAL, system_process_attributes) [__FreeBSD__]:
897 Don't assume EMACS_TIME and struct timeval are the same type.
899 2012-06-22 Paul Eggert <eggert@cs.ucla.edu>
901 Support higher-resolution time stamps (Bug#9000).
902 The time stamps are only nanosecond-resolution at the C level,
903 since that's the best that any real-world system supports now.
904 But they are picosecond-resolution at the Lisp level, as that's
905 easy, and leaves room for future OS improvements.
907 * Makefile.in (LIB_CLOCK_GETTIME): New macro.
910 * alloc.c (Fgarbage_collect): Port to higher-res time stamps.
911 Don't get current time unless it's needed.
913 * atimer.c: Include <sys/time.h> unconditionally, since gnulib
914 now provides it if it's absent.
915 (start_atimer): Port to higher-res time stamps.
916 Check for time stamp overflow. Don't get current time more
917 often than is needed.
919 * buffer.h (struct buffer): Buffer modtime now has high resolution.
920 Include systime.h, not time.h.
921 (NONEXISTENT_MODTIME_NSECS, UNKNOWN_MODTIME_NSECS): New macros.
923 * dired.c: Include stat-time.h.
924 (Ffile-attributes): File times now have higher resolution.
926 * dispextern.h [HAVE_WINDOW_SYSTEM]: Include systime.h.
927 (struct image): Timestamp now has higher resolution.
929 * dispnew.c (PERIODIC_PREEMPTION_CHECKING): Remove, as Emacs always
930 has at least microseconds now. All uses removed.
931 (update_frame, update_single_window, update_window, update_frame_1)
932 (Fsleep_for, sit_for): Port to higher-resolution time stamps.
934 * editfns.c (time_overflow): Now extern.
935 (Fcurrent_time, Fget_internal_run_time, make_time, lisp_time_argument)
936 (float-time, Fformat_time_string, Fcurrent_time_string)
937 (Fcurrent_time_zone): Accept and generate higher-resolution
939 (make_time_tail, make_lisp_time, dissassemble_lisp_time)
940 (decode_time_components, lisp_seconds_argument): New functions.
941 (make_time): Now static.
942 (lisp_time_argument): Now returns EMACS_TIME. New arg ppsec.
943 Report an error if the time is invalid, rather than having the caller
946 * fileio.c: Include <stat-time.h>
947 (Fcopy_file): Copy higher-resolution time stamps.
948 Prefer to set the time stamp via a file descriptor if that works.
949 (Fset_file_times, Finsert_file_contents, Fwrite_region)
950 (Fverify_visited_file_modtime, Fclear_visited_file_modtime)
951 (Fvisited_file_modtime, Fset_visited_file_modtime):
952 Support higher-resolution time stamps.
954 * fns.c (Frandom): Use nanoseconds, not microseconds, for seed.
956 * gtkutil.c (xg_maybe_add_timer): Port to higher-res time stamps.
958 * image.c (prepare_image_for_display, clear_image_cache)
959 (lookup_image): Port to higer-resolution time stamps.
961 * keyboard.c (start_polling, bind_polling_period):
962 Check for time stamp overflow.
963 (read_char, kbd_buffer_get_event, timer_start_idle)
964 (timer_stop_idle, timer_resume_idle, timer_check_2, timer_check)
965 (Fcurrent_idle_time, init_keyboard, set_waiting_for_input):
966 Port to higher-resolution time stamps. Do not assume time_t is signed.
967 (decode_timer): New function. Timers are now vectors of length 9,
968 not 8, to accommodate the picosecond component.
969 (timer_check_2): Use it.
971 * nsterm.m (select_timeout, timeval_subtract): Remove.
972 (ns_timeout): Use Emacs's facilities for time stamp arithmetic,
973 as they're a bit more accurate and handle overflow better.
974 (ns_select): Change prototype to be compatible with pselect.
975 (ns_select, ns_term_shutdown): Port to ns-resolution time stamps.
976 * nsterm.h (ns_select): Adjust prototype.
978 * msdos.c (EMACS_TIME_ZERO_OR_NEG_P): Remove, as it assumes
979 us-resolution time stamps.
980 (sys_select): Use the new EMACS_TIME_SIGN macro instead.
982 * lread.c (read_filtered_event): Port to ns-resolution time stamps.
984 * lisp.h (time_overflow): New decl.
985 (wait_reading_process_output): First arg is now intmax_t, not int,
986 to accommodate larger waits.
988 * process.h (struct Lisp_Process.read_output_delay):
989 Now counts nanoseconds, not microseconds.
990 * process.c (ADAPTIVE_READ_BUFFERING): Don't worry about
992 (READ_OUTPUT_DELAY_INCREMENT, Faccept_process_output)
993 (wait_reading_process_output):
994 Port to ns-resolution time stamps.
995 (Faccept_process_output, wait_reading_process_output):
996 Check for time stamp overflow. Do not assume time_t is signed.
997 (select_wrapper): Remove; we now use pselect.
998 (Fprocess_attributes): Now generates ns-resolution time stamps.
1000 * sysdep.c: Include utimens.h. Don't include utime.h
1001 or worry about struct utimbuf; gnulib does that for us now.
1002 (gettimeofday): Remove; gnulib provides a substitute.
1003 (make_timeval): New function.
1004 (set_file_times): Now sets ns-resolution time stamps.
1005 New arg FD; all uses changed.
1006 (time_from_jiffies, ltime_from_jiffies, get_up_time)
1007 (system_process_attributes):
1008 Now returns ns-resolution time stamp. All uses changed.
1009 Check for time stamp overflow.
1011 * sysselect.h: Don't depend on HAVE_SYS_SELECT_H; gnulib
1012 provides a substitute now.
1014 * systime.h: Include timespec.h rather than sys/time.h and time.h,
1015 since it guarantees struct timespec.
1016 (EMACS_TIME): Now struct timespec, so that we can support
1017 ns-resolution time stamps.
1018 (EMACS_TIME_RESOLUTION, LOG10_EMACS_TIME_RESOLUTION): New macros.
1019 (EMACS_HAS_USECS): Remove; Emacs always has sub-second time stamps now.
1020 (EMACS_USECS): Remove.
1021 (EMACS_SET_USECS): The underlying time stamp now has ns resolution,
1022 so multiply the arg by 1000 before storing it.
1023 (EMACS_NSECS, EMACS_SECS_ADDR, EMACS_SET_NSECS, EMACS_SET_SECS_NSECS):
1025 (EMACS_GET_TIME, EMACS_ADD_TIME, EMACS_SUB_TIME):
1026 Port to ns-resolution time stamps.
1027 (EMACS_TIME_NEG_P): Remove; replaced by....
1028 (EMACS_TIME_SIGN): New macro.
1029 (EMACS_SET_INVALID_TIME, EMACS_TIME_VALID_P)
1030 (EMACS_TIME_FROM_DOUBLE, EMACS_TIME_TO_DOUBLE): New macros.
1031 (set_file_times, make_time, lisp_time_argument): Adjust signature.
1032 (make_timeval, make_lisp_time, decode_time_components): New decls.
1033 (EMACS_TIME_CMP): Remove; no longer used. Plus, it was buggy, in
1034 that it mishandled time_t overflow. You can't compare by subtracting!
1035 (EMACS_TIME_EQ, EMACS_TIME_NE, EMACS_TIME_GT, EMACS_TIME_GE)
1036 (EMACS_TIME_LT, EMACS_TIME_LE): Rewrite in terms of timespec_cmp.
1038 * term.c: Include <sys/time.h>.
1039 (timeval_to_Time): New function, for proper overflow wraparound.
1040 (term_mouse_position, term_mouse_click): Use it.
1042 * undo.c (record_first_change): Support higher-resolution time stamps
1044 (Fprimitive_undo): Use them when restoring time stamps.
1046 * w32.c (ltime, U64_TO_LISP_TIME, process_times, emacs_gnutls_pull)
1047 (w32_get_internal_run_time):
1048 Port to higher-resolution Emacs time stamps.
1049 (ltime): Now accepts single 64-bit integer, as that's more convenient
1052 * xdisp.c (start_hourglass): Port to ns-resolution time stamps.
1054 * xgselect.c, xgselect.h (xg_select): Add sigmask argument,
1055 for compatibility with pselect. Support ns-resolution time stamps.
1057 * xmenu.c (x_menu_wait_for_event): Support ns-resolution time stamps.
1059 * xselect.c (wait_for_property_change, x_get_foreign_selection):
1060 Check for time stamp overflow, and support ns-resolution time stamps.
1062 * xterm.c: Don't include sys/time.h; gnulib does that for us now.
1063 Don't worry about whether HAVE_TIMEVAL and HAVE_SELECT are set.
1064 (timeval_subtract): Remove; no longer needed.
1065 (XTflash, XTring_bell, x_wait_for_event):
1066 Port to ns-resolution time stamps. Don't assume time_t is signed.
1068 2012-06-22 Chong Yidong <cyd@gnu.org>
1070 * xdisp.c (x_consider_frame_title): Revert last change.
1072 2012-06-22 Eli Zaretskii <eliz@gnu.org>
1074 * alloc.c (NSTATICS): Enlarge to 0x650. Otherwise, Emacs compiled
1075 with -DENABLE_CHECKING -DXASSERTS -DGLYPH_DEBUG=1 -DBYTE_CODE_METER
1076 aborts in staticpro during startup. (Without -DBYTE_CODE_METER,
1077 staticidx goes up to 1597 out of 1600 = 0x640.)
1079 2012-06-20 Paul Eggert <eggert@cs.ucla.edu>
1081 * fileio.c (Fdefault_file_modes): Block input while fiddling with umask.
1082 Otherwise, the umask might be mistakenly 0 while handling input signals.
1084 2012-06-19 Stefan Monnier <monnier@iro.umontreal.ca>
1086 * minibuf.c (Fread_string): Bind minibuffer-completion-table.
1088 2012-06-19 Dmitry Antipov <dmantipov@yandex.ru>
1090 * alloc.c, bytecode.c, ccl.c, coding.c, composite.c, data.c, dosfns.c:
1091 * font.c, image.c, keyboard.c, lread.c, menu.c, minibuf.c, msdos.c:
1092 * print.c, syntax.c, window.c, xmenu.c, xselect.c: Replace direct
1093 access to `contents' member of Lisp_Vector objects with AREF and ASET
1096 2012-06-19 Chong Yidong <cyd@gnu.org>
1098 * frame.c (delete_frame): When selecting a frame on a different
1099 text terminal, do not alter the terminal's top-frame.
1101 * xdisp.c (format_mode_line_unwind_data): Record the target
1102 frame's selected window and its terminal's top-frame.
1103 (unwind_format_mode_line): Restore them.
1104 (x_consider_frame_title, display_mode_line, Fformat_mode_line):
1106 (x_consider_frame_title): Do not condition on HAVE_WINDOW_SYSTEM,
1107 since tty frames can be explicitly named.
1108 (prepare_menu_bars): Likewise.
1110 * term.c (Ftty_top_frame): New function.
1112 2012-06-18 Paul Eggert <eggert@cs.ucla.edu>
1114 Port byte-code-meter to modern targets.
1115 * bytecode.c (METER_CODE) [BYTE_CODE_METER]: Don't assume
1116 !CHECK_LISP_OBJECT_TYPE && !USE_LSB_TAG. Problem with
1117 CHECK_LISP_OBJECT_TYPE reported by Dmitry Antipov in
1118 <http://lists.gnu.org/archive/html/emacs-devel/2012-06/msg00282.html>.
1119 (METER_1, METER_2): Simplify.
1121 2012-06-18 Stefan Monnier <monnier@iro.umontreal.ca>
1123 * data.c (Fdefalias): Return `symbol' (bug#11686).
1125 2012-06-18 Martin Rudalics <rudalics@gmx.at>
1127 * buffer.c (Fkill_buffer): Don't throw an error when the buffer
1128 gets killed during executing of this function (Bug#11665).
1129 Try to always return Qt when the buffer has been actually killed.
1130 (Vkill_buffer_query_functions): In doc-string say that functions
1131 run by this hook should not change the current buffer.
1133 2012-06-18 Paul Eggert <eggert@cs.ucla.edu>
1135 Fix recently-introduced process.c problems found by static checking.
1136 * process.c (write_queue_push, write_queue_pop, send_process):
1137 Use ptrdiff_t, not int or EMACS_INT, for buffer lengths and offsets.
1138 (write_queue_pop): Fix pointer signedness problem.
1139 (send_process): Remove unused local.
1141 2012-06-17 Chong Yidong <cyd@gnu.org>
1143 * xdisp.c (redisplay_internal): No need to redisplay terminal
1144 frames that are not on top.
1146 2012-06-17 Troels Nielsen <bn.troels@gmail.com>
1148 * process.c (make_process): Initialize write_queue.
1149 (write_queue_push, write_queue_pop): New functions.
1150 (send_process): Use them to maintain correct ordering of process
1153 2012-06-17 Paul Eggert <eggert@cs.ucla.edu>
1155 * lisp.h (eassert): Assume C89 or later.
1156 This removes the need for CHECK.
1157 (CHECK): Remove. Its comments about always evaluating its
1158 argument were confusing, as 'eassert' typically does not evaluate
1161 * coding.c (produce_chars): Use ptrdiff_t, not int.
1163 * xterm.c (x_draw_underwave): Check for integer overflow.
1164 This pacifies gcc 4.7.0 -Wunsafe-loop-optimizations on x86-64.
1166 2012-06-17 Jan Djärv <jan.h.d@swipnet.se>
1168 * nsterm.m (x_free_frame_resources): Move xfree so freed memory isn't
1169 referenced (Bug#11583).
1171 2012-06-16 Aurelien Aptel <aurelien.aptel@gmail.com>
1173 Implement wave-style variant of underlining.
1174 * dispextern.h (face_underline_type): New enum.
1175 (face): Add field for underline type.
1176 * nsterm.m (ns_draw_underwave): New function.
1177 (ns_draw_text_decoration): Use it.
1178 * w32term.c (w32_restore_glyph_string_clip, w32_draw_underwave):
1180 (x_draw_glyph_string): Use them.
1181 * xfaces.c (Qline, Qwave): New Lisp objects.
1182 (check_lface_attrs, merge_face_ref)
1183 (Finternal_set_lisp_face_attribute, realize_x_face):
1184 Handle wave-style underline face attributes.
1185 * xterm.c (x_draw_underwave): New function.
1186 (x_draw_glyph_string): Use it.
1188 2012-06-16 Juanma Barranquero <lekktu@gmail.com>
1190 * makefile.w32-in ($(BLD)/emacs.$(O), $(BLD)/fringe.$(O))
1191 ($(BLD)/xml.$(O), $(BLD)/intervals.$(O), $(BLD)/macros.$(O))
1192 ($(BLD)/minibuf.$(O), $(BLD)/regex.$(O), $(BLD)/region-cache.$(O))
1193 ($(BLD)/textprop.$(O), $(BLD)/undo.$(O), $(BLD)/window.$(O))
1194 ($(BLD)/w32select.$(O)): Update dependencies.
1196 2012-06-16 Andreas Schwab <schwab@linux-m68k.org>
1198 * buffer.h (FETCH_MULTIBYTE_CHAR): Define as inline.
1199 (BUF_FETCH_MULTIBYTE_CHAR): Likewise.
1200 * character.c (_fetch_multibyte_char_p): Remove.
1201 * alloc.c: Include "character.h" before "buffer.h".
1203 * buffer.c: Likewise.
1204 * bytecode.c: Likewise.
1205 * callint.c: Likewise.
1206 * callproc.c: Likewise.
1207 * casefiddle.c: Likewise.
1208 * casetab.c: Likewise.
1209 * category.c: Likewise.
1211 * coding.c: Likewise.
1212 * composite.c: Likewise.
1213 * dired.c: Likewise.
1214 * dispnew.c: Likewise.
1216 * dosfns.c: Likewise.
1217 * editfns.c: Likewise.
1218 * emacs.c: Likewise.
1219 * fileio.c: Likewise.
1220 * filelock.c: Likewise.
1222 * fontset.c: Likewise.
1223 * fringe.c: Likewise.
1224 * indent.c: Likewise.
1225 * insdel.c: Likewise.
1226 * intervals.c: Likewise.
1227 * keyboard.c: Likewise.
1228 * keymap.c: Likewise.
1229 * lread.c: Likewise.
1230 * macros.c: Likewise.
1231 * marker.c: Likewise.
1232 * minibuf.c: Likewise.
1233 * nsfns.m: Likewise.
1234 * nsmenu.m: Likewise.
1235 * print.c: Likewise.
1236 * process.c: Likewise.
1237 * regex.c: Likewise.
1238 * region-cache.c: Likewise.
1239 * search.c: Likewise.
1240 * syntax.c: Likewise.
1242 * textprop.c: Likewise.
1244 * unexsol.c: Likewise.
1245 * w16select.c: Likewise.
1246 * w32fns.c: Likewise.
1247 * w32menu.c: Likewise.
1248 * window.c: Likewise.
1249 * xdisp.c: Likewise.
1251 * xmenu.c: Likewise.
1253 * xselect.c: Likewise.
1255 2012-06-16 Eli Zaretskii <eliz@gnu.org>
1257 * xdisp.c (set_cursor_from_row): Don't dereference glyphs_end.
1258 If all the glyphs of the glyph row came from strings, and we have no
1259 cursor positioning clues, put the cursor on the first glyph of the
1261 (handle_face_prop): Use chunk-relative overlay string index when
1262 indexing into it->string_overlays array. (Bug#11653)
1263 (set_cursor_from_row): Use the leftmost glyph as GLYPH_BEFORE, not
1264 the rightmost. (Bug#11720)
1266 2012-06-16 Andreas Schwab <schwab@linux-m68k.org>
1268 * category.h (CHAR_HAS_CATEGORY): Define as inline.
1269 (CATEGORY_MEMBER): Enforce 1/0 value.
1270 * category.c (_temp_category_set): Remove.
1272 2012-06-16 Eli Zaretskii <eliz@gnu.org>
1274 * window.c (Fdelete_other_windows_internal)
1275 (Fdelete_window_internal): Don't access frame's mouse highlight
1276 info of the initial frame. (Bug#11677)
1278 2012-06-14 Paul Eggert <eggert@cs.ucla.edu>
1280 * .gdbinit (xgetint): Fix recently-introduced paren typo.
1281 Assume USE_2_TAGS_FOR_INTS.
1282 (xreload): Adjust $tagmask width to match recent lisp.h change.
1284 Simplify lisp.h in minor ways that should not affect code.
1285 * lisp.h (USE_2_TAGS_FOR_INTS): Remove, as it was always defined.
1286 (LISP_INT_TAG, case_Lisp_Int, LISP_STRING_TAG, LISP_INT_TAG_P)
1287 (LISP_INT1_TAG, enum Lisp_Type, XINT, XUINT, make_number):
1288 Simplify under the assumption that USE_2_TAGS_FOR_INTS is defined.
1289 (INTTYPEBITS): New macro, for clarity.
1290 (INTMASK, MOST_POSITIVE_FIXNUM): Use it.
1291 (LISP_INT1_TAG, LISP_STRING_TAG, LISP_INT_TAG_P):
1292 Simplify now that USE_LSB_TAG is always defined.
1293 (TYPEMASK, XINT) [USE_LSB_TAG]: Remove unnecessary cast.
1294 (make_number) [!USE_LSB_TAG]: Use INTMASK; that's simpler.
1296 2012-06-13 Juanma Barranquero <lekktu@gmail.com>
1298 * makefile.w32-in ($(BLD)/data.$(O)): Update dependencies.
1300 2012-06-13 Glenn Morris <rgm@gnu.org>
1302 * s/bsd-common.h (BSD4_3):
1303 * s/usg5-4-common.h (USG5_4): No longer define; unused.
1305 2012-06-13 Andreas Schwab <schwab@linux-m68k.org>
1307 * lisp.h (Lisp_Object) [CHECK_LISP_OBJECT_TYPE]: Define as struct
1310 (XHASH, XTYPE, XINT, XUINT, make_number, XSET, XPNTR, XUNTAG):
1312 * emacs.c (gdb_use_struct): Rename from gdb_use_union.
1313 * .gdbinit: Check gdb_use_struct instead of gdb_use_union.
1314 * alloc.c (widen_to_Lisp_Object): Remove.
1315 (mark_memory): Use XIL instead of widen_to_Lisp_Object.
1316 * frame.c (delete_frame): Remove outdated comment.
1317 * w32fns.c (Fw32_register_hot_key): Use XLI instead of checking
1318 USE_LISP_UNION_TYPE.
1319 (Fw32_unregister_hot_key): Likewise.
1320 (Fw32_toggle_lock_key): Likewise.
1321 * w32menu.c (add_menu_item): Likewise.
1322 (w32_menu_display_help): Use XIL instead of checking
1323 USE_LISP_UNION_TYPE.
1324 * w32heap.c (allocate_heap): Don't check USE_LISP_UNION_TYPE.
1325 (init_heap): Likewise.
1326 * w32term.c (w32_read_socket): Update comment.
1328 2012-06-13 Glenn Morris <rgm@gnu.org>
1330 * s/usg5-4-common.h, src/s/unixware.h:
1331 Remove define/undef of HAVE_SYSV_SIGPAUSE (not used since 2010-05-04).
1333 * s/gnu.h (POSIX_SIGNALS): Remove (not used since 2010-05-04).
1335 2012-06-13 Paul Eggert <eggert@cs.ucla.edu>
1337 USE_LISP_UNION_TYPE + USE_LSB_TAG cleanup (Bug#11604)
1338 * alloc.c (make_number) [!defined make_number]:
1339 Remove, as lisp.h always defines this now.
1340 (mark_maybe_pointer): Simplify since USE_LSB_TAG is always defined now.
1341 (roundup_size): Verify that it is a power of 2.
1342 * data.c (Fmake_variable_buffer_local, Fmake_local_variable):
1343 * ftfont.c (ftfont_driver): Use LISP_INITIALLY_ZERO.
1344 * lisp.h (USE_LSB_TAG): Allow the builder to compile with
1345 -DUSE_LSB_TAG=0, to override the automatically-selected default.
1346 USE_LSB_TAG now is always defined to be either 0 or 1.
1348 (union Lisp_Object): Don't worry about WORDS_BIGENDIAN; the
1349 code works fine either way, and efficiency is not a concern here,
1350 as the union type is for debugging, not for production.
1351 (LISP_MAKE_RVALUE, make_number) [USE_LISP_UNION_TYPE]:
1352 Use an inline function on all platforms when using the union type,
1353 since this is simpler and 'static inline' can be used portably
1355 (LISP_INITIALLY_ZERO): New macro.
1356 (XFASTINT, XSETFASTINT) [USE_LISP_UNION_TYPE]: Remove.
1357 (XSET) [USE_LISP_UNION_TYPE]: Don't overparenthesize.
1359 2012-06-12 Glenn Morris <rgm@gnu.org>
1361 * s/gnu-kfreebsd.h, s/hpux11.h, s/openbsd.h, s/sol2-10.h: Remove files.
1363 * s/gnu-linux.h (HAVE_PROCFS): Move to configure.
1365 * s/hpux10-20.h, s/openbsd.h, s/usg5-4-common.h:
1366 Move BROKEN_SIGIO to configure.
1368 * s/bsd-common.h, s/darwin.h, s/gnu-kfreebsd.h, s/hpux10-20.h:
1369 Move NO_TERMIO to configure.
1371 2012-06-12 Chong Yidong <cyd@gnu.org>
1373 * image.c (imagemagick_load_image): Use MagickFlattenImage if
1374 MagickMergeImageLayers is undefined. Use pixel pusher loop if
1375 MagickExportImagePixels is undefined.
1377 2012-06-12 Paul Eggert <eggert@cs.ucla.edu>
1379 * image.c (imagemagick_load_image): Remove unused label.
1381 2012-06-11 Glenn Morris <rgm@gnu.org>
1383 * s/aix4-2.h, s/bsd-common.h, s/cygwin.h, s/darwin.h:
1384 * s/gnu-kfreebsd.h, s/gnu-linux.h, s/gnu.h, s/hpux10-20.h:
1385 * s/irix6-5.h, s/ms-w32.h, s/msdos.h, s/template.h:
1386 * s/usg5-4-common.h: Move SYSTEM_TYPE to configure.
1388 2012-06-11 Stefan Monnier <monnier@iro.umontreal.ca>
1390 * alloc.c (make_byte_code): New function.
1391 (Fmake_byte_code): Use it. Don't purify here.
1392 * lread.c (read1): Use it as well to avoid extra allocation.
1394 2012-06-11 Chong Yidong <cyd@gnu.org>
1396 * image.c (imagemagick_load_image): Implement transparency.
1398 2012-06-10 Andreas Schwab <schwab@linux-m68k.org>
1400 * regex.c (at_begline_loc_p): Also recognize `(?N:' and correctly
1401 account for preceding backslashes. (Bug#11663)
1403 2012-06-09 Chong Yidong <cyd@gnu.org>
1405 * term.c: Support italics in capable terminals (Bug#9652).
1406 (no_color_bit): Replace unused NC_BLINK with NC_ITALIC.
1407 (turn_on_face): Output using TS_enter_italic_mode if available.
1408 Don't handle unused blinking and alt-charset cases.
1409 (turn_off_face): Handle italic case; discard unused tty_blinking_p
1410 and tty_alt_charset_p cases.
1411 (tty_capable_p, init_tty): Support italics.
1413 * termchar.h (struct tty_display_info): Add field for italics.
1414 Remove unused blink field.
1416 * xfaces.c (tty_supports_face_attributes_p, realize_tty_face):
1419 * dispextern.h: Replace unused TTY_CAP_BLINK with TTY_CAP_ITALIC.
1420 (struct face): Remove unused fields tty_dim_p, tty_blinking_p, and
1421 tty_alt_charset_p. Add tty_italic_p.
1423 2012-06-09 Michael Albinus <michael.albinus@gmx.de>
1425 * dbusbind.c (XD_BASIC_DBUS_TYPE): Use dbus_type_is_valid and
1426 dbus_type_is_basic if available.
1427 (xd_extract_signed, xd_extract_unsigned): Rename from
1428 extract_signed and extract_unsigned, respectively. Adapt callers.
1430 2012-06-09 Chong Yidong <cyd@gnu.org>
1432 * xfaces.c (face_for_overlay_string): Handle face remapping (Bug#2066).
1434 * fringe.c (Fset_fringe_bitmap_face): Handle the noninteractive
1437 2012-06-08 Paul Eggert <eggert@cs.ucla.edu>
1439 * xdisp.c (vmessage): Treat frame message as multibyte.
1440 Without this change, (let ((§ 1)) (make-variable-buffer-local '§))
1441 would generate the diagnostic "Making \302\247 buffer-local while
1444 2012-06-08 Eli Zaretskii <eliz@gnu.org>
1446 * dispnew.c (showing_window_margins_p): Undo last change, which
1447 was done due to an inadvertent commit.
1448 (adjust_frame_glyphs_for_frame_redisplay): Do call
1449 showing_window_margins_p.
1451 2012-06-08 Stefan Monnier <monnier@iro.umontreal.ca>
1453 * eval.c (Fmake_var_non_special): New primitive.
1454 (syms_of_eval): Defsubr it.
1455 * lread.c (syms_of_lread): Mark `values' as lexically scoped.
1457 2012-06-08 Juanma Barranquero <lekktu@gmail.com>
1459 * dispnew.c (showing_window_margins_p): Wrap in #if 0 to prevent unused
1460 function warning (the only call is inside #if 0 since 2012-06-08T08:44:45Z!eliz@gnu.org).
1462 2012-06-08 Eli Zaretskii <eliz@gnu.org>
1464 * alloc.c (allocate_vectorlike): Fix last change.
1466 2012-06-08 Dmitry Antipov <dmantipov@yandex.ru>
1468 Block-based vector allocation of small vectors.
1469 * lisp.h (struct vectorlike_header): New field `nbytes',
1470 adjust comment accordingly.
1471 * alloc.c (enum mem_type): New type `MEM_TYPE_VECTOR_BLOCK'
1472 to denote vector blocks. Adjust users (live_vector_p,
1473 mark_maybe_pointer, valid_lisp_object_p) accordingly.
1474 (COMMON_MULTIPLE): Move outside #if USE_LSB_TAG.
1475 (VECTOR_BLOCK_SIZE, vroundup, VECTOR_BLOCK_BYTES),
1476 (VBLOCK_BYTES_MIN, VBLOCK_BYTES_MAX, VECTOR_MAX_FREE_LIST_INDEX),
1477 (VECTOR_FREE_LIST_FLAG, ADVANCE, VINDEX, SETUP_ON_FREE_LIST),
1478 (VECTOR_SIZE, VECTOR_IN_BLOCK): New macros.
1479 (roundup_size): New constant.
1480 (struct vector_block): New data type.
1481 (vector_blocks, vector_free_lists, zero_vector): New variables.
1482 (all_vectors): Rename to `large_vectors'.
1483 (allocate_vector_from_block, init_vectors, allocate_vector_from_block)
1484 (sweep_vectors): New functions.
1485 (allocate_vectorlike): Return `zero_vector' as the only vector of
1486 0 items. Allocate new vector from block if vector size is less than
1487 or equal to VBLOCK_BYTES_MAX.
1488 (Fgarbage_collect): Move all vector sweeping code to sweep_vectors.
1489 (init_alloc_once): Add call to init_vectors.
1491 2012-06-08 Stefan Monnier <monnier@iro.umontreal.ca>
1493 * eval.c (Fmacroexpand): Stop if the macro returns the same form.
1495 2012-06-07 Paul Eggert <eggert@cs.ucla.edu>
1497 * doprnt.c (doprnt): Truncate multibyte char correctly.
1498 Without this change, doprnt (buf, 2, "%s", FORMAT_END, AP)
1499 would mishandle a string argument "Xc" if X was a multibyte
1500 character of length 2: it would truncate after X's first byte
1501 rather than including all of X.
1503 2012-06-06 Chong Yidong <cyd@gnu.org>
1505 * buffer.c (word_wrap): Doc fix.
1507 2012-06-04 Paul Eggert <eggert@cs.ucla.edu>
1509 * xdisp.c (note_mode_line_or_margin_highlight): Pacify gcc -Wall.
1511 2012-06-03 Glenn Morris <rgm@gnu.org>
1513 * xdisp.c (tool-bar-style): Doc fix.
1515 2012-06-03 Ulrich Müller <ulm@gentoo.org>
1517 * Makefile.in (PAXCTL): Define.
1518 (temacs$(EXEEXT)): Disable memory randomization for the temacs
1519 binary via PaX flags if the paxctl utility is available.
1520 (emacs$(EXEEXT), bootstrap-emacs$(EXEEXT)):
1521 Restore PaX flags to their default. (Bug#11398)
1523 2012-06-03 Chong Yidong <cyd@gnu.org>
1525 * xdisp.c (decode_mode_spec_coding): Display a space for a unibyte
1528 2012-06-03 Chong Yidong <cyd@gnu.org>
1530 * xdisp.c (calc_pixel_width_or_height): Use Fbuffer_local_value.
1531 (note_mode_line_or_margin_highlight): If there is no help echo,
1532 use mode-line-default-help-echo. Handle the case where the mouse
1533 position is past the end of the mode line string.
1535 * buffer.c (buffer_local_value_1): New function, split from
1536 Fbuffer_local_value; can return Qunbound.
1537 (Fbuffer_local_value): Use it.
1538 (Vmode_line_format): Docstring tweaks.
1540 2012-06-02 Paul Eggert <eggert@cs.ucla.edu>
1542 * sysdep.c (system_process_attributes): Improve comment.
1544 2012-06-02 Stefan Monnier <monnier@iro.umontreal.ca>
1546 * keyboard.c: Export real-this-command to Elisp.
1547 (syms_of_keyboard): Rename real_this_command to Vreal_this_command
1548 and DEFVAR it. Update all users.
1550 2012-06-02 Paul Eggert <eggert@cs.ucla.edu>
1552 * minibuf.c (Fassoc_string): Remove duplicate declaration.
1554 * sysdep.c (system_process_attributes) [SOLARIS2 && HAVE_PROCFS]:
1555 Convert pctcpu and pctmem to Lisp float properly.
1556 Let the compiler fold better, as 100.0/0x8000 is exact.
1558 2012-06-02 Andreas Schwab <schwab@linux-m68k.org>
1560 * alloc.c (CONS_BLOCK_SIZE): Account for padding at the end of
1563 2012-06-01 Paul Eggert <eggert@cs.ucla.edu>
1565 * xfns.c (x_set_tool_bar_lines) [USE_GTK]: Adjust to bitfield change.
1567 2012-06-01 Dmitry Antipov <dmantipov@yandex.ru>
1569 For a 'struct window', replace some Lisp_Object fields to
1570 bitfields where appropriate, remove unused fields.
1571 * window.h (struct window): Remove unused 'last_mark_x' and
1572 'last_mark_y' fields. Rename 'mini_p' field to 'mini',
1573 change it's type from Lisp_Object to bitfield.
1574 Change type of 'force_start', 'optional_new_start',
1575 'last_had_star', 'update_mode_line' and 'start_at_line_beg'
1576 fields from Lisp_Object to bitfield. Adjust users accordingly.
1578 2012-05-31 Paul Eggert <eggert@cs.ucla.edu>
1580 Pacify gcc -Wdouble-precision when using Xaw.
1581 * xterm.c (xaw_jump_callback, x_set_toolkit_scroll_bar_thumb)
1582 [HAVE_X_WINDOWS && USE_TOOLKIT_SCROLL_BARS && !USE_MOTIF && !USE_GTK]:
1583 Use 'float' consistently, rather than 'float' in most places
1584 and 'double' in a couple of places.
1586 2012-05-31 Eli Zaretskii <eliz@gnu.org>
1588 * xdisp.c (handle_stop): Detect whether we have overlay strings
1589 loaded by testing it->current.overlay_string_index to be
1590 non-negative, instead of checking whether n_overlay_strings is
1591 positive. (Bug#11587)
1593 2012-05-31 Chong Yidong <cyd@gnu.org>
1595 * keymap.c (describe_map_tree): Revert 2011-07-07 change (Bug#1169).
1597 * doc.c (Fsubstitute_command_keys): Doc fix.
1599 2012-05-31 Eli Zaretskii <eliz@gnu.org>
1601 * search.c (search_buffer): Remove calls to
1602 r_alloc_inhibit_buffer_relocation, as it is now called by
1603 maybe_unify_char, which was the cause of relocation of buffer text
1606 2012-05-31 Eli Zaretskii <eliz@gnu.org>
1608 * charset.c (maybe_unify_char): Inhibit relocation of buffer text
1609 for the duration of call to load_charset, to avoid problems with
1610 callers of maybe_unify_char that access buffer text through C
1613 * ralloc.c (r_alloc_inhibit_buffer_relocation): Increment and
1614 decrement the inhibition flag, instead of just setting or
1617 2012-05-31 Paul Eggert <eggert@cs.ucla.edu>
1619 Remove obsolete '#define static' cruft.
1620 * s/hpux10-20.h (_FILE_OFFSET_BITS): Don't #undef.
1621 This #undef was "temporary" in 2000; it is no longer needed
1622 now that '#define static' has gone away.
1623 * xfns.c, xterm.h (gray_bitmap_width, gray_bitmap_height)
1624 (gray_bitmap_bits): Remove; no longer needed.
1625 All uses replaced with definiens.
1626 * xterm.c: Include "bitmaps/gray.xbm".
1628 2012-05-30 Paul Eggert <eggert@cs.ucla.edu>
1630 Clean up __executable_start, monstartup when --enable-profiling.
1631 The following changes affect the code only when profiling.
1632 * dispnew.c (__executable_start): Rename from safe_bcopy.
1633 Define only on platforms that need it.
1634 * emacs.c: Include <sys/gmon.h> when profiling.
1635 (_mcleanup): Remove decl, since <sys/gmon.h> does it now.
1636 (__executable_start): Remove decl, since lisp.h does it now.
1637 (safe_bcopy): Remove decl; no longer has that name.
1638 (main): Coalesce #if into single bit of code, for simplicity.
1639 Cast pointers to uintptr_t, since standard libraries want integers
1641 * lisp.h (__executable_start): New decl.
1643 2012-05-31 Glenn Morris <rgm@gnu.org>
1645 * image.c (Fimagemagick_types): Doc fix.
1647 2012-05-30 Jim Meyering <meyering@redhat.com>
1649 * callproc.c (Fcall_process_region): Include directory component
1650 in mkstemp error message (Bug#11586).
1652 2012-05-30 Paul Eggert <eggert@cs.ucla.edu>
1654 * alloc.c, lisp.h (make_pure_vector): Now static.
1656 2012-05-30 Stefan Monnier <monnier@iro.umontreal.ca>
1658 * eval.c (Fdefun, Fdefmacro, Vmacro_declaration_function):
1659 Move to byte-run.el.
1660 (Fautoload): Do the hash-doc more carefully.
1661 * data.c (Fdefalias): Purify definition, except for keymaps.
1662 (Qdefun): Move from eval.c.
1663 * lisp.h (Qdefun): Remove.
1664 * lread.c (read1): Tiny simplification.
1666 2012-05-29 Troels Nielsen <bn.troels@gmail.com>
1668 Do not create empty overlays with the evaporate property (Bug#9642).
1669 * buffer.c (Fmove_overlay): Reinstate the earlier fix for
1670 Bug#9642, but explicitly check that the buffer the overlay would
1671 be moved to is live and rearrange lines to make sure that errors
1672 will not put the overlay in an inconsistent state.
1673 (Fdelete_overlay): Cosmetics.
1675 2012-05-28 Eli Zaretskii <eliz@gnu.org>
1677 * w32term.c (my_bring_window_to_top): New function.
1678 (x_raise_frame): Use handle returned by DeferWindowPos, which
1679 could be different from the original one.
1680 Call my_bring_window_to_top instead of my_set_foreground_window.
1683 * w32fns.c (w32_wnd_proc): Accept and process WM_EMACS_BRINGTOTOP
1684 by calling BringWindowToTop.
1686 * w32term.h (WM_EMACS_BRINGTOTOP): New message.
1687 (WM_EMACS_END): Increase by one.
1689 2012-05-28 Paul Eggert <eggert@cs.ucla.edu>
1691 * bidi.c (bidi_mirror_char): Put eassert before conversion to int.
1692 This avoids undefined behavior that might cause the eassert
1693 to not catch an out-of-range value.
1695 2012-05-28 Juanma Barranquero <lekktu@gmail.com>
1697 * makefile.w32-in ($(BLD)/w32inevt.$(O), $(BLD)/w32console.$(O)):
1698 Update dependencies.
1700 2012-05-27 Eli Zaretskii <eliz@gnu.org>
1702 * bidi.c (bidi_mirror_char): Fix last change.
1704 2012-05-27 Andreas Schwab <schwab@linux-m68k.org>
1706 * unexmacosx.c (copy_data_segment): Truncate after 16 characters
1707 when referring to sectname field in printf format.
1709 2012-05-27 Paul Eggert <eggert@cs.ucla.edu>
1711 * lisp.h [REL_ALLOC]: Omit duplicate prototypes.
1712 Only r_alloc_inhibit_buffer_relocation needed to be added;
1713 the others were already declared.
1715 * bidi.c (bidi_mirror_char): Don't possibly truncate the integer
1716 before checking whether it's out of range. Put the check inside
1718 <http://lists.gnu.org/archive/html/emacs-devel/2012-05/msg00485.html>.
1720 2012-05-27 Ken Brown <kbrown@cornell.edu>
1722 * callproc.c (Fcall_process): Restore a line that was accidentally
1723 commented out in the 2011-02-13 change (bug#11547).
1725 2012-05-27 Eli Zaretskii <eliz@gnu.org>
1727 * lisp.h [REL_ALLOC]: Add prototypes for external functions
1728 defined on ralloc.c.
1730 * buffer.c [REL_ALLOC]: Remove prototypes of
1731 r_alloc_reset_variable, r_alloc, r_re_alloc, and r_alloc_free,
1732 they are now on lisp.h.
1734 * ralloc.c (r_alloc_inhibit_buffer_relocation): New function.
1736 * search.c (search_buffer): Use it to inhibit relocation of buffer
1737 text while re_search_2 is doing its job, because re_search_2 is
1738 passed C pointers to buffer text. (Bug#11519)
1740 * msdos.c (internal_terminal_init) <Vwindow_system_version>:
1743 * xdisp.c (move_it_to): Under MOVE_TO_Y, when restoring iterator
1744 state after an additional call to move_it_in_display_line_to, keep
1745 the values of it->max_ascent and it->max_descent found for the
1747 (pos_visible_p): Revert the comparison against bottom_y to what it
1748 was in revid eliz@gnu.org-20120513182235-4p6386j761ld0nwb.
1751 2012-05-26 Paul Eggert <eggert@cs.ucla.edu>
1753 Fix coding-related core dumps with gcc -ftrapv.
1754 The code was computing A - B, where A and B are pointers, and B is
1755 random garbage. This can lead to core dumps on platforms that
1756 have special pointer registers, and it also leads to core dumps on
1757 x86-64 when compiled with gcc -ftrapv. The fix is to compute
1758 A - B only when B is initialized properly.
1759 * coding.c (coding_set_source, coding_set_destination): Return void.
1760 (coding_change_source, coding_change_destinations): New functions,
1761 with the old behaviors of coding_set_source and coding_set_destination.
1762 All callers that need an offset changed to use these new functions.
1764 2012-05-26 Glenn Morris <rgm@gnu.org>
1766 * nsterm.m (ns_init_paths): Don't mess with INFOPATH. (Bug#2791)
1768 2012-05-26 Eli Zaretskii <eliz@gnu.org>
1770 Extend mouse support on W32 text-mode console.
1771 * xdisp.c (draw_row_with_mouse_face):
1772 Call tty_draw_row_with_mouse_face for WINDOWSNT as well.
1774 * w32console.c: Include window.h.
1775 (w32con_write_glyphs_with_face, tty_draw_row_with_mouse_face):
1777 (initialize_w32_display): Initialize mouse-highlight data.
1779 * w32inevt.c: Include termchar.h and window.h.
1780 (do_mouse_event): Support mouse-autoselect-window. When the mouse
1781 moves, call note_mouse_highlight. If help_echo changed, call
1782 gen_help_event to produce help-echo message in the echo area.
1783 Call clear_mouse_face if mouse_face_hidden is set in the mouse
1786 2012-05-26 Paul Eggert <eggert@cs.ucla.edu>
1788 * lread.c (read1): Simplify slightly to avoid an overflow warning
1789 with GCC 4.7.0 on x86-64.
1791 2012-05-26 Eli Zaretskii <eliz@gnu.org>
1793 * bidi.c (bidi_mirror_char): Revert last change: an int is
1794 definitely wide enough here.
1796 2012-05-25 Paul Eggert <eggert@cs.ucla.edu>
1798 Fix integer width and related bugs (Bug#9874).
1799 * alloc.c (pure_bytes_used_lisp, pure_bytes_used_non_lisp):
1800 (allocate_vectorlike, buffer_memory_full, struct sdata, SDATA_SIZE)
1801 (string_bytes, check_sblock, allocate_string_data):
1802 (compact_small_strings, Fmake_bool_vector, make_string)
1803 (make_unibyte_string, make_multibyte_string)
1804 (make_string_from_bytes, make_specified_string)
1805 (allocate_vectorlike, Fmake_vector, find_string_data_in_pure)
1806 (make_pure_string, make_pure_c_string, make_pure_vector, Fpurecopy)
1808 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1809 (allocate_pseudovector):
1810 Use int, not EMACS_INT, where int is wide enough.
1811 (inhibit_garbage_collection, Fgarbage_collect):
1812 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1813 * bidi.c (bidi_mirror_char): Use EMACS_INT, not int, where
1814 int might not be wide enough.
1815 (bidi_cache_search, bidi_cache_find, bidi_init_it)
1816 (bidi_count_bytes, bidi_char_at_pos, bidi_fetch_char)
1817 (bidi_at_paragraph_end, bidi_find_paragraph_start)
1818 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak)
1819 (bidi_level_of_next_char, bidi_move_to_visually_next):
1820 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1821 * buffer.c (copy_overlays, Fgenerate_new_buffer_name)
1822 (Fkill_buffer, Fset_buffer_major_mode)
1823 (advance_to_char_boundary, Fbuffer_swap_text)
1824 (Fset_buffer_multibyte, overlays_at, overlays_in)
1825 (overlay_touches_p, struct sortvec, record_overlay_string)
1826 (overlay_strings, recenter_overlay_lists)
1827 (adjust_overlays_for_insert, adjust_overlays_for_delete)
1828 (fix_start_end_in_overlays, fix_overlays_before, modify_overlay)
1829 (Fmove_overlay, Fnext_overlay_change, Fprevious_overlay_change)
1830 (Foverlay_recenter, last_overlay_modification_hooks_used)
1831 (report_overlay_modification, evaporate_overlays, enlarge_buffer_text):
1832 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1833 (validate_region): Omit unnecessary test for b <= e,
1834 since that's guaranteed by the previous test.
1835 (adjust_overlays_for_delete): Avoid pos + length overflow.
1836 (Fmove_overlay, Fdelete_overlay, add_overlay_mod_hooklist)
1837 (report_overlay_modification):
1838 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1839 (Foverlays_at, Fnext_overlay_change, Fprevious_overlay_change):
1840 Omit pointer cast, which isn't needed anyway, and doesn't work
1841 after the EMACS_INT -> ptrdiff_t change.
1842 (Fmove_overlay): Clip BEG and END to ptrdiff_t to avoid overflow.
1843 * buffer.h: Adjust decls to match defn changes elsewhere.
1844 (struct buffer_text, struct buffer):
1845 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1846 Use EMACS_INT, not int, where int might not be wide enough.
1847 * bytecode.c (unmark_byte_stack, exec_byte_code): Use ptrdiff_t,
1848 not int, to avoid needless 32-bit limit on 64-bit hosts.
1849 (exec_byte_code): Use tighter memory-full test, one that checks
1850 for alloca overflow. Don't compute the address of the object just
1851 before an array, as that's not portable. Use EMACS_INT, not
1852 ptrdiff_t or int, where ptrdiff_t or int might not be wide enough.
1853 * callint.c (Fcall_interactively):
1854 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1855 * callproc.c (call_process_kill, Fcall_process):
1856 Don't assume pid_t fits into an Emacs fixnum.
1857 (call_process_cleanup, Fcall_process, child_setup):
1858 Don't assume pid_t fits into int.
1859 (call_process_cleanup, Fcall_process, delete_temp_file)
1860 (Fcall_process_region):
1861 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1862 (Fcall_process): Simplify handling of volatile integers.
1863 Use int, not EMACS_INT, where int will do.
1864 * casefiddle.c (casify_object, casify_region, operate_on_word)
1865 (Fupcase_word, Fdowncase_word, Fcapitalize_word):
1866 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1867 (casify_object): Avoid integer overflow when overallocating buffer.
1868 * casetab.c (set_identity, shuffle): Prefer int to unsigned when
1869 either works. Use lint_assume to convince GCC 4.6.1 that it's OK.
1870 * category.c (Fchar_category_set): Don't assume fixnum fits in int.
1871 * category.h (CATEGORYP): Don't assume arg is nonnegative.
1872 * ccl.c (GET_CCL_INT): Remove; no longer needed, since the
1873 integers are now checked earlier. All uses replaced with XINT.
1875 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1876 For CCL_MapSingle, check that content and value are in int range.
1877 (ccl_driver, Fregister_code_conversion_map):
1878 Check that Vcode_version_map_vector is a vector.
1879 (resolve_symbol_ccl_program): Check that vector header is in range.
1880 Always copy the vector, so that we can check its contents reliably
1881 now rather than having to recheck each instruction as it's being
1882 executed. Check that vector words fit in 'int'.
1883 (ccl_get_compiled_code, Fregister_ccl_program)
1884 (Fregister_code_conversion_map): Use ptrdiff_t, not int, for
1885 program indexes, to avoid needless 32-bit limit on 64-bit hosts.
1886 (Fccl_execute, Fccl_execute_on_string): Check that initial reg
1887 contents are in range.
1888 (Fccl_execute_on_string): Check that status is in range.
1889 * ccl.h (struct ccl_program.idx): Now ptrdiff_t, not int.
1890 * character.c (char_resolve_modifier_mask, Fchar_resolve_modifiers):
1891 Accept and return EMACS_INT, not int, because callers can pass values
1893 (c_string_width, strwidth, lisp_string_width, chars_in_text)
1894 (multibyte_chars_in_text, parse_str_as_multibyte)
1895 (str_as_multibyte, count_size_as_multibyte, str_to_multibyte)
1896 (str_as_unibyte, str_to_unibyte, string_count_byte8)
1897 (string_escape_byte8, Fget_byte):
1898 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1899 (Funibyte_string): Use CHECK_RANGED_INTEGER, not CHECK_NATNUM, to
1900 avoid mishandling large integers.
1901 * character.h: Adjust decls to match defn changes elsewhere.
1902 * charset.c (load_charset_map_from_file, find_charsets_in_text)
1903 (Ffind_charset_region):
1904 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1905 (load_charset_map_from_file): Redo idx calculation to avoid overflow.
1906 (load_charset_map_from_vector, Fdefine_charset_internal):
1907 Don't assume fixnum fits in int.
1908 (load_charset_map_from_vector, Fmap_charset_chars):
1909 Remove now-unnecessary CHECK_NATNUMs.
1910 (Fdefine_charset_internal): Check ranges here, more carefully.
1911 Don't rely on undefined behavior with signed left shift overflow.
1912 Don't assume unsigned int fits into fixnum, or that fixnum fits
1913 into unsigned int. Don't require max_code to be a valid fixnum;
1914 that's not true for gb10830 4-byte on a 32-bit host. Allow
1915 invalid_code to be a cons, for the same reason. Require code_offset
1916 to be a character. Avoid int overflow if max_char is close
1918 (CODE_POINT_TO_INDEX): On 32-bit hosts, return int, not unsigned;
1919 this is intended anyway and avoids some undefined behavior.
1920 (load_charset_map): Pass unsigned, not int, as 2nd arg of
1921 INDEX_TO_CODE_POINT, as that's what it expects.
1922 (Funify_charset, encode_char): Don't stuff unsigned vals into int vars.
1923 * charset.h (DECODE_CHAR): Return int, not unsigned;
1924 this is what was intended anyway, and it avoids undefined behavior.
1925 (CHARSET_OFFSET): Remove unused macro, instead of fixing its
1926 integer-overflow issues.
1927 (ENCODE_CHAR): Return unsigned on all hosts, not just on 32-bit hosts.
1928 Formerly, it returned EMACS_INT on 64-bit hosts in the common case
1929 where the argument is EMACS_INT, and this behavior is not intended.
1930 * chartab.c (Fmake_char_table, Fset_char_table_range)
1931 (uniprop_get_decoder, uniprop_get_encoder):
1932 Don't assume fixnum fits in int.
1933 * cmds.c (move_point): New function, that does the gist of
1934 Fforward_char and Fbackward_char, but does so while checking
1935 for integer overflow more accurately.
1936 (Fforward_char, Fbackward_char): Use it.
1937 (Fforward_line, Fend_of_line, internal_self_insert)
1938 (internal_self_insert):
1939 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1940 Fix a FIXME, by checking for integer overflow when calculating
1941 target_clm and actual_clm.
1942 * coding.c (detect_coding_XXX, encode_coding_XXX, CODING_DECODE_CHAR)
1943 (CODING_ENCODE_CHAR, CODING_CHAR_CHARSET, CODING_CHAR_CHARSET_P)
1944 (ASSURE_DESTINATION, coding_alloc_by_realloc)
1945 (coding_alloc_by_making_gap, alloc_destination)
1946 (detect_coding_utf_8, encode_coding_utf_8, decode_coding_utf_16)
1947 (encode_coding_utf_16, detect_coding_emacs_mule)
1948 (decode_coding_emacs_mule, encode_coding_emacs_mule)
1949 (detect_coding_iso_2022, decode_coding_iso_2022)
1950 (encode_invocation_designation, encode_designation_at_bol)
1951 (encode_coding_iso_2022, detect_coding_sjis, detect_coding_big5)
1952 (decode_coding_sjis, decode_coding_big5, encode_coding_sjis)
1953 (encode_coding_big5, detect_coding_ccl, decode_coding_ccl)
1954 (encode_coding_ccl, encode_coding_raw_text)
1955 (detect_coding_charset, decode_coding_charset)
1956 (encode_coding_charset, detect_eol, decode_eol, produce_chars)
1957 (produce_composition, produce_charset, produce_annotation)
1958 (decode_coding, handle_composition_annotation)
1959 (handle_charset_annotation, consume_chars, decode_coding_gap)
1960 (decode_coding_object, encode_coding_object, detect_coding_system)
1961 (Ffind_coding_systems_region_internal, Fcheck_coding_systems_region)
1962 (code_convert_region, code_convert_string)
1963 (Fdefine_coding_system_internal)
1964 (coding_set_source, coding_set_destination):
1965 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1966 (setup_iso_safe_charsets, consume_chars, Funencodable_char_position)
1967 (Fdefine_coding_system_internal):
1968 Don't assume fixnums fit in int.
1969 (decode_coding_gap, decode_coding_object, encode_coding_object)
1970 (Fread_coding_system, Fdetect_coding_region)
1971 (Funencodable_char_position, Fcheck_coding_systems_region)
1972 (get_translation, handle_composition_annotation, consume_chars):
1973 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1974 (consume_chars): Rewrite to not calculate an address outside buffer.
1975 (Ffind_operation_coding_system): NATNUMP can eval its arg twice.
1976 Don't access memory outside of the args array.
1977 (Fdefine_coding_system_internal): Check for charset-id overflow.
1978 (ENCODE_ISO_CHARACTER): Use unsigned, not int, to store the unsigned
1979 result of ENCODE_CHAR.
1980 * coding.h: Adjust decls to match defn changes elsewhere.
1981 (struct coding_system):
1982 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1983 * composite.c (get_composition_id, find_composition)
1984 (run_composition_function, update_compositions)
1985 (compose_text, composition_gstring_put_cache)
1986 (composition_gstring_p, composition_gstring_width)
1987 (fill_gstring_header, fill_gstring_body, autocmp_chars)
1988 (composition_compute_stop_pos, composition_reseat_it)
1989 (composition_update_it, struct position_record)
1990 (find_automatic_composition, composition_adjust_point)
1991 (Fcomposition_get_gstring, Ffind_composition_internal):
1992 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1993 (update_compositions):
1994 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1995 * composite.h: Adjust decls to match defn changes elsewhere.
1996 (struct composition):
1997 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1998 * data.c (let_shadows_buffer_binding_p, let_shadows_global_binding_p):
1999 Do not attempt to compute the address of the object just before a
2000 buffer; this is not portable.
2002 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2003 (Faset): Use int, not EMACS_INT, where int is wide enough.
2004 (Fstring_to_number): Don't assume fixnums fit in int.
2005 (Frem): Don't assume arg is nonnegative.
2006 * dbusbind.c (xd_append_arg): Check for integers out of range.
2007 (Fdbus_call_method): Don't overflow the timeout int.
2008 (extract_signed, extract_unsigned): New functions.
2009 (XD_CHECK_DBUS_SERIAL): Remove; superseded by extract_unsigned.
2010 (xd_get_connection_references): Return ptrdiff_t, not int.
2012 (xd_signature, xd_append_arg, xd_retrieve_arg, Fdbus_message_internal)
2013 (xd_read_message_1):
2014 Use int, not unsigned, where the dbus API uses int.
2015 (Fdbus_message_internal): Don't overflow mtype.
2016 (syms_of_dbusbind): Allocate right-sized buffer for integers.
2017 * dired.c (directory_files_internal, file_name_completion, scmp)
2018 (file_name_completion_stat):
2019 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2020 (file_name_completion): Don't overflow matchcount.
2021 (file_name_completion_stat): Use SAFE_ALLOCA, not alloca.
2022 * dispextern.h: Adjust decls to match defn changes elsewhere.
2023 (struct text_pos, struct glyph, struct bidi_saved_info)
2024 (struct bidi_string_data, struct bidi_it, struct composition_it)
2026 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2027 (struct display_pos, struct composition_it, struct it):
2028 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2029 * dispnew.c (increment_matrix_positions)
2030 (increment_row_positions, mode_line_string)
2031 (marginal_area_string):
2032 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2033 (change_frame_size_1, Fredisplay, Fframe_or_buffer_changed_p):
2034 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2035 (duration_to_sec_usec): New function, to check for overflow better.
2036 (Fsleep_for, sit_for): Use it.
2037 * doc.c (get_doc_string, store_function_docstring):
2038 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2039 (get_doc_string, Fsnarf_documentation):
2040 Use int, not EMACS_INT, where int is wide enough.
2042 Use SAFE_ALLOCA, not alloca.
2043 Check for overflow when converting EMACS_INT to off_t.
2044 * doprnt.c (doprnt):
2045 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2046 * editfns.c (init_editfns, Fuser_uid, Fuser_real_uid):
2047 Don't assume uid_t fits into fixnum.
2048 (buildmark, Fgoto_char, overlays_around, find_field, Fdelete_field)
2049 (Ffield_string, Ffield_string_no_properties, Ffield_beginning)
2050 (Ffield_end, Fconstrain_to_field, Fline_beginning_position)
2051 (Fline_end_position, Fprevious_char, Fchar_after, Fchar_before)
2052 (general_insert_function)
2053 (Finsert_char, make_buffer_string, make_buffer_string_both)
2054 (update_buffer_properties, Fbuffer_substring)
2055 (Fbuffer_substring_no_properties, Fcompare_buffer_substrings)
2056 (Fsubst_char_in_region, check_translation)
2057 (Ftranslate_region_internal, save_restriction_restore, Fformat)
2058 (transpose_markers, Ftranspose_regions):
2059 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2060 (clip_to_bounds): Move to lisp.h as an inline function).
2061 (Fconstrain_to_field): Don't assume integers are nonnegative.
2062 (Fline_beginning_position, Fsave_excursion, Fsave_current_buffer):
2063 (Fsubst_char_in_region, Fsave_restriction):
2064 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2065 (Femacs_pid): Don't assume pid_t fits into fixnum.
2066 (lo_time): Use int, not EMACS_INT, when int suffices.
2067 (lisp_time_argument): Check for usec out of range.
2068 (Fencode_time): Don't assume fixnum fits in int.
2069 (Fuser_login_name, Fuser_full_name): Signal an error
2070 if a uid argument is out of range, rather than relying on
2072 (Fformat_time_string): Remove now-unnecessary check.
2073 lisp_time_argument checks for out-of-range usec now.
2074 Use ptrdiff_t, not size_t, where ptrdiff_t will do.
2075 * emacs.c (gdb_valbits, gdb_gctypebits): Now int, not EMACS_INT.
2076 (gdb_data_seg_bits): Now uintptr_t, not EMACS_INT.
2077 (PVEC_FLAG, gdb_array_mark_flag): Now ptrdiff_t, not EMACS_INT.
2078 (init_cmdargs, Fdump_emacs):
2079 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2080 (Fkill_emacs): Don't assume fixnum fits in int; instead, take just
2081 the bottom (typically) 32 bits of the fixnum.
2082 * eval.c (specpdl_size, call_debugger):
2083 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2084 (when_entered_debugger, Fbacktrace_debug):
2085 Don't assume fixnum can fit in int.
2086 (Fdefvaralias, Fdefvar): Do not attempt to compute the address of
2087 the object just before a buffer; this is not portable.
2088 (FletX, Flet, Funwind_protect, do_autoload, Feval, funcall_lambda)
2089 (grow_specpdl, unbind_to):
2090 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2091 (Fapply, apply_lambda): Don't assume ptrdiff_t can hold fixnum.
2092 (grow_specpdl): Simplify allocation by using xpalloc.
2093 (Fprog1, Fprog2): Don't assume list length fits in int. Simplify.
2094 * fileio.c (Ffind_file_name_handler, Fcopy_file, Frename_file)
2095 (Finsert_file_contents, Fwrite_region, Fdo_auto_save):
2096 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2097 (Ffind_file_name_handler, non_regular_inserted, Finsert_file_contents)
2099 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2100 (Fcopy_file, non_regular_nbytes, read_non_regular)
2101 (Finsert_file_contents):
2102 Use int, not EMACS_INT, where int is wide enough.
2103 (READ_BUF_SIZE): Verify that it fits in int.
2104 (Finsert_file_contents): Check that counts are in proper range,
2105 rather than assuming fixnums fit into ptrdiff_t etc.
2106 Don't assume fixnums fit into int.
2107 * floatfns.c (Fexpt): Avoid undefined signed * signed overflow.
2108 * fns.c (Fcompare_strings, Fstring_lessp, struct textprop_rec, concat)
2109 (string_char_byte_cache_charpos, string_char_byte_cache_bytepos)
2110 (string_char_to_byte, string_byte_to_char)
2111 (string_make_multibyte, string_to_multibyte)
2112 (string_make_unibyte, Fstring_as_unibyte, Fstring_as_multibyte)
2113 (Fstring_to_unibyte, Fsubstring, Fsubstring_no_properties)
2114 (substring_both, Fdelete, internal_equal, Ffillarray)
2115 (Fclear_string, mapcar1)
2116 (Fbase64_encode_region, Fbase64_encode_string, base64_encode_1)
2117 (Fbase64_decode_region, Fbase64_decode_string, base64_decode_1)
2118 (larger_vector, make_hash_table, maybe_resize_hash_table)
2119 (hash_lookup, hash_remove_from_table, hash_clear, sweep_weak_table)
2120 (Fmaphash, secure_hash):
2121 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2122 (concat): Check for string index and length overflow.
2123 (Fmapconcat): Don't assume fixnums fit into ptrdiff_t.
2125 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2126 (larger_vector): New API (vec, incr_min, size_max) replaces old
2127 one (vec, new_size, init). This catches size overflow.
2128 INIT was removed because it was always Qnil.
2129 All callers changed.
2130 (INDEX_SIZE_BOUND): New macro, which calculates more precisely
2131 the upper bound on a hash table index size.
2132 (make_hash_table, maybe_resize_hash_table): Use it.
2133 (secure_hash): Computer start_byte and end_byte only after
2134 they're known to be in ptrdiff_t range.
2135 * font.c (font_intern_prop, font_at, font_range, Ffont_shape_gstring)
2136 (Ffont_get_glyphs, Ffont_at):
2137 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2138 (font_style_to_value, font_prop_validate_style, font_expand_wildcards)
2139 (Flist_fonts, Fopen_font):
2140 Don't assume fixnum can fit in int.
2141 (check_gstring): Don't assume index can fit in int.
2142 (font_match_p): Check that fixnum is a character, not a nonnegative
2143 fixnum, since the later code needs to stuff it into an int.
2144 (font_find_for_lface): Use SAFE_ALLOCA_LISP, not alloca.
2145 (font_fill_lglyph_metrics): Use unsigned, not EMACS_INT, to avoid
2146 conversion overflow issues.
2147 (Fopen_font): Check for integer out of range.
2148 (Ffont_get_glyphs): Don't assume index can fit in int.
2149 * font.h: Adjust decls to match defn changes elsewhere.
2150 * fontset.c (reorder_font_vector): Redo score calculation to avoid
2152 (num_auto_fontsets, fontset_from_font): Use ptrdiff_t, not
2153 printmax_t, where ptrdiff_t is wide enough.
2154 (Finternal_char_font):
2155 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2156 * frame.c (Fset_mouse_position, Fset_mouse_pixel_position)
2157 (Fset_frame_height, Fset_frame_width, Fset_frame_size)
2158 (Fset_frame_position, x_set_frame_parameters)
2159 (x_set_line_spacing, x_set_border_width)
2160 (x_set_internal_border_width, x_set_alpha, x_figure_window_size):
2161 Check that fixnums are in proper range for system types.
2162 (frame_name_fnn_p, Fframe_parameter, Fmodify_frame_parameters):
2163 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2164 (Fmodify_frame_parameters): Don't assume fixnum fits in int.
2165 Use SAFE_ALLOCA_LISP, not alloca.
2166 * frame.h (struct frame): Use intptr_t, not EMACS_INT, where
2167 intptr_t is wide enough.
2168 * fringe.c (lookup_fringe_bitmap, get_logical_fringe_bitmap)
2169 (Fdefine_fringe_bitmap): Don't assume fixnum fits in int.
2170 (Ffringe_bitmaps_at_pos): Don't assume index fits in int.
2171 Check for fixnum out of range.
2172 * ftfont.c (ftfont_list): Don't assume index fits in int.
2173 Check that fixnums are in proper range for system types.
2174 (ftfont_shape_by_flt):
2175 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2176 * gnutls.c (emacs_gnutls_write, emacs_gnutls_read):
2177 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2178 (Fgnutls_error_fatalp, Fgnutls_error_string, Fgnutls_boot):
2179 Check that fixnums are in proper range for system types.
2180 * gnutls.h: Adjust decls to match defn changes elsewhere.
2181 * gtkutil.c (xg_dialog_run):
2182 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2183 (update_frame_tool_bar):
2184 Check that fixnums are in proper range for system types.
2185 * image.c (parse_image_spec): Redo count calculation to avoid overflow.
2186 (lookup_image): Check that fixnums are in range for system types.
2187 * indent.c (last_known_column, last_known_column_point):
2188 (current_column_bol_cache):
2189 (skip_invisible, current_column, check_display_width):
2190 (check_display_width, scan_for_column, current_column_1)
2191 (Findent_to, Fcurrent_indentation, position_indentation)
2192 (indented_beyond_p, Fmove_to_column, compute_motion):
2193 (Fcompute_motion, Fvertical_motion):
2194 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2195 (last_known_column_modified): Use EMACS_INT, not int.
2196 (check_display_width):
2198 Check that fixnums and floats are in proper range for system types.
2199 (compute_motion): Don't assume index or fixnum fits in int.
2200 (compute_motion, Fcompute_motion):
2201 Use int, not EMACS_INT, when it is wide enough.
2202 (vmotion): Omit local var start_hpos that is always 0; that way
2203 we don't need to worry about overflow in expressions involving it.
2204 * indent.h: Adjust decls to match defn changes elsewhere.
2206 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2207 Use int, not EMACS_INT, where int is wide enough.
2208 Remove unused members ovstring_chars_done and tab_offset;
2210 * insdel.c (move_gap, move_gap_both, gap_left, gap_right)
2211 (adjust_markers_for_delete, adjust_markers_for_insert, adjust_point)
2212 (adjust_markers_for_replace, make_gap_larger, make_gap_smaller)
2213 (make_gap, copy_text, insert, insert_and_inherit)
2214 (insert_before_markers, insert_before_markers_and_inherit)
2215 (insert_1, count_combining_before, count_combining_after)
2216 (insert_1_both, insert_from_string)
2217 (insert_from_string_before_markers, insert_from_string_1)
2218 (insert_from_gap, insert_from_buffer, insert_from_buffer_1)
2219 (adjust_after_replace, adjust_after_insert, replace_range)
2220 (replace_range_2, del_range, del_range_1, del_range_byte)
2221 (del_range_both, del_range_2, modify_region)
2222 (prepare_to_modify_buffer, signal_before_change)
2223 (signal_after_change, Fcombine_after_change_execute):
2224 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2225 * intervals.c (traverse_intervals, rotate_right, rotate_left)
2226 (balance_an_interval, split_interval_right, split_interval_left)
2227 (find_interval, next_interval, update_interval)
2228 (adjust_intervals_for_insertion, delete_node, delete_interval)
2229 (interval_deletion_adjustment, adjust_intervals_for_deletion)
2230 (static_offset_intervals, offset_intervals)
2231 (merge_interval_right, merge_interval_left, make_new_interval)
2232 (graft_intervals_into_buffer, temp_set_point_both)
2233 (temp_set_point, set_point, adjust_for_invis_intang)
2234 (set_point_both, move_if_not_intangible, get_property_and_range)
2235 (get_local_map, copy_intervals, copy_intervals_to_string)
2236 (compare_string_intervals, set_intervals_multibyte_1):
2237 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2238 * intervals.h: Adjust decls to match defn changes elsewhere.
2240 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2241 * keyboard.c (this_command_key_count, this_single_command_key_start)
2242 (before_command_key_count, before_command_echo_length, echo_now)
2243 (echo_length, recursive_edit_1, Frecursive_edit, Ftrack_mouse)
2244 (command_loop_1, safe_run_hooks, read_char, timer_check_2)
2245 (menu_item_eval_property, read_key_sequence, Fread_key_sequence)
2246 (Fread_key_sequence_vector, Fexecute_extended_command, Fsuspend_emacs):
2247 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2248 (last_non_minibuf_size, last_point_position, echo_truncate)
2249 (command_loop_1, adjust_point_for_property, read_char, gen_help_event)
2250 (make_lispy_position, make_lispy_event, parse_modifiers_uncached)
2251 (parse_modifiers, modify_event_symbol, Fexecute_extended_command)
2252 (stuff_buffered_input):
2253 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2254 (last_auto_save, command_loop_1, read_char):
2255 Use EMACS_INT, not int, to avoid integer overflow.
2256 (record_char): Avoid overflow in total_keys computation.
2257 (parse_modifiers_uncached): Redo index calculation to avoid overflow.
2258 * keyboard.h: Adjust decls to match defn changes elsewhere.
2259 * keymap.c (Fdefine_key, Fcurrent_active_maps, accessible_keymaps_1)
2260 (Fkey_description, Fdescribe_vector, Flookup_key):
2261 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2262 (click_position): New function, to check that positions are in range.
2263 (Fcurrent_active_maps):
2265 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2266 (Faccessible_keymaps, Fkey_description):
2267 (preferred_sequence_p):
2268 Don't assume fixnum can fit into int.
2269 (Fkey_description): Use SAFE_ALLOCA_LISP, not alloca.
2270 Check for integer overflow in size calculations.
2271 (Ftext_char_description): Use CHECK_CHARACTER, not CHECK_NUMBER, to
2272 avoid mishandling large integers.
2273 * lisp.h: Adjust decls to match defn changes elsewhere.
2274 (ARRAY_MARK_FLAG, PSEUDOVECTOR_FLAG, struct Lisp_String)
2275 (struct vectorlike_header, struct Lisp_Subr, struct Lisp_Hash_Table)
2276 (struct Lisp_Marker):
2277 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2278 (clip_to_bounds): Now an inline function, moved here from editfns.c.
2279 (GLYPH_CODE_P): Check for overflow in system types, subsuming the
2280 need for GLYPH_CODE_CHAR_VALID_P and doing proper checking ourselves.
2281 All callers changed.
2282 (GLYPH_CODE_CHAR, GLYPH_CODE_FACE):
2283 Assume the arg has valid form, since it always does.
2284 (TYPE_RANGED_INTEGERP): Avoid bug when checking against a wide
2285 unsigned integer system type.
2286 (CHECK_RANGED_INTEGER, CHECK_TYPE_RANGED_INTEGER): New macros.
2287 (struct catchtag, specpdl_size, SPECPDL_INDEX, USE_SAFE_ALLOCA):
2288 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2289 (struct catchtag): Use EMACS_INT, not int, since it may be a fixnum.
2290 (duration_to_sec_usec): New decl.
2291 * lread.c (read_from_string_index, read_from_string_index_byte)
2292 (read_from_string_limit, readchar, unreadchar, openp)
2293 (read_internal_start, read1, oblookup):
2294 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2295 (Fload, readevalloop, Feval_buffer, Feval_region):
2296 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2297 (openp): Check for out-of-range argument to 'access'.
2298 (read1): Use int, not EMACS_INT, where int is wide enough.
2299 Don't assume fixnum fits into int.
2300 Fix off-by-one error that can read outside a buffer.
2301 (read_filtered_event): Use duration_to_sec_usec
2302 to do proper overflow checking on durations.
2303 * macros.c (Fstart_kbd_macro): Use xpalloc to check for overflow
2304 in size calculation.
2305 (Fexecute_kbd_macro):
2306 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2307 * marker.c (cached_charpos, cached_bytepos, CONSIDER)
2308 (byte_char_debug_check, buf_charpos_to_bytepos, verify_bytepos)
2309 (buf_bytepos_to_charpos, Fset_marker, set_marker_restricted)
2310 (set_marker_both, set_marker_restricted_both, marker_position)
2311 (marker_byte_position, Fbuffer_has_markers_at):
2312 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2313 (Fset_marker, set_marker_restricted): Don't assume fixnum fits in int.
2314 * menu.c (ensure_menu_items): Rename from grow_menu_items.
2315 It now merely ensures that the menu is large enough, without
2316 necessarily growing it, as this avoids some integer overflow issues.
2317 All callers changed.
2318 (keymap_panes, parse_single_submenu, Fx_popup_menu):
2319 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2320 (parse_single_submenu, Fx_popup_menu): Don't assume fixnum fits in int.
2321 Use SAFE_ALLOCA_LISP, not alloca.
2322 (find_and_return_menu_selection): Avoid unnecessary casts of pointers
2323 to EMACS_INT. Check that fixnums are in proper range for system types.
2324 * minibuf.c (minibuf_prompt_width, string_to_object)
2325 (Fminibuffer_contents, Fminibuffer_contents_no_properties)
2326 (Fminibuffer_completion_contents, Ftry_completion, Fall_completions):
2327 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2328 (get_minibuffer, read_minibuf_unwind):
2329 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2330 (read_minibuf): Omit unnecessary arg BACKUP_N, which is always nil;
2331 this simplifies overflow checking. All callers changed.
2332 (read_minibuf, Fread_buffer, Ftry_completion, Fall_completions)
2334 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2335 * nsfns.m (check_ns_display_info): Don't assume fixnum fits in long.
2336 (x_set_menu_bar_lines, x_set_tool_bar_lines, Fx_create_frame):
2337 Check that fixnums are in proper range for system types.
2338 (Fx_create_frame, Fx_show_tip):
2339 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2340 * nsfont.m (ns_findfonts, nsfont_list_family):
2341 Don't assume fixnum fits in long.
2342 * nsmenu.m (ns_update_menubar, ns_menu_show, ns_popup_dialog):
2343 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2344 (ns_update_menubar): Use intptr_t, not EMACS_INT, when intptr_t is
2346 * nsselect.m (ns_get_local_selection, clean_local_selection_data):
2347 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2348 * print.c (print_buffer_size, print_buffer_pos, print_buffer_pos_byte)
2349 (PRINTDECLARE, PRINTPREPARE):
2350 (strout, print_string):
2351 (print, print_preprocess, print_check_string_charset_prop)
2353 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2355 (temp_output_buffer_setup, Fprin1_to_string, print_object):
2356 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2357 (PRINTPREPARE): Use int, not ptrdiff_t, where int is wide enough.
2358 (printchar, strout): Use xpalloc to catch size calculation overflow.
2359 (Fexternal_debugging_output): Don't overflow EMACS_INT->int conversion.
2360 (print_error_message): Use SAFE_ALLOCA, not alloca.
2361 (print_object): Use int, not EMACS_INT, where int is wide enough.
2362 (print_depth, new_backquote_output, print_number_index):
2363 Use ptrdiff_t, not int, where int might not be wide enough.
2364 * process.c (Fdelete_process): Don't assume pid fits into EMACS_INT.
2365 (Fset_process_window_size, Fformat_network_address)
2366 (get_lisp_to_sockaddr_size, set_socket_option, Fmake_network_process)
2368 Check that fixnums are in proper range for system types.
2369 (Fsignal_process): Simplify by avoiding a goto.
2370 Check for process-ids out of pid_t range rather than relying on
2372 (process_tick, update_tick): Use EMACS_INT, not int.
2373 (Fformat_network_address, read_process_output, send_process)
2374 (Fprocess_send_region, status_notify):
2375 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2376 (Fformat_network_address, Fmake_serial_process, Fmake_network_process)
2377 (wait_reading_process_output, read_process_output, exec_sentinel):
2378 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2379 (conv_lisp_to_sockaddr): Don't assume fixnums fit into int.
2380 (Faccept_process_output): Use duration_to_sec_usec to do proper
2381 overflow checking on durations.
2382 (emacs_get_tty_pgrp, Fprocess_running_child_p, process_send_signal):
2383 Don't assume pid_t fits in int.
2384 * process.h (struct Lisp_Process): Members tick and update_tick
2385 are now of type EMACS_INT, not int.
2386 * puresize.h (PURESIZE_RATIO): Shrink this to 8/6 on 32-bit hosts
2387 configured --with-wide-int.
2388 * scroll.c (calculate_scrolling, calculate_direct_scrolling)
2389 (line_ins_del): Use int, not EMACS_INT, where int is wide enough.
2390 * search.c (looking_at_1, string_match_1):
2391 (fast_string_match, fast_c_string_match_ignore_case)
2392 (fast_string_match_ignore_case, fast_looking_at, scan_buffer)
2393 (scan_newline, find_before_next_newline, search_command)
2394 (trivial_regexp_p, search_buffer, simple_search, boyer_moore)
2395 (set_search_regs, wordify):
2398 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2399 (string_match_1, search_buffer, set_search_regs):
2401 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2402 (wordify): Check for overflow in size calculation.
2403 (Freplace_match): Avoid potential buffer overflow in search_regs.start.
2404 (Fset_match_data): Don't assume fixnum fits in ptrdiff_t.
2405 Check that fixnums are in proper range for system types.
2406 * sound.c (struct sound_device)
2407 (wav_play, au_play, vox_write, alsa_period_size, alsa_write):
2408 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2409 (Fplay_sound_internal):
2410 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2411 * syntax.c (struct lisp_parse_state, find_start_modiff)
2412 (Finternal_describe_syntax_value, scan_lists, scan_sexps_forward):
2413 (Fparse_partial_sexp):
2414 Don't assume fixnums can fit in int.
2415 (struct lisp_parse_state, find_start_pos, find_start_value)
2416 (find_start_value_byte, find_start_begv)
2417 (update_syntax_table, char_quoted, dec_bytepos)
2418 (find_defun_start, prev_char_comend_first, back_comment):
2419 (scan_words, skip_chars, skip_syntaxes, forw_comment, Fforward_comment)
2420 (scan_lists, Fbackward_prefix_chars, scan_sexps_forward):
2421 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2422 (Finternal_describe_syntax_value): Check that match_lisp is a
2423 character, not an integer, since the code stuffs it into int.
2424 (scan_words, scan_sexps_forward):
2425 Check that fixnums are in proper range for system types.
2427 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2428 (scan_sexps_forward):
2429 Use CHARACTERP, not INTEGERP, since the value must fit into int.
2430 (Fparse_partial_sexp): Fix doc; element 8 is not ignored.
2431 * syntax.h: Adjust decls to match defn changes elsewhere.
2432 (struct gl_state_s):
2433 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2434 (SETUP_SYNTAX_TABLE_FOR_OBJECT): Use PTRDIFF_MAX, not
2435 MOST_POSITIVE_FIXNUM.
2436 * sysdep.c (wait_for_termination_1, wait_for_termination)
2437 (interruptible_wait_for_termination, mkdir):
2438 Don't assume pid_t fits in int; on 64-bit AIX pid_t is 64-bit.
2439 (emacs_read, emacs_write):
2440 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2441 (system_process_attributes): Don't assume uid_t, gid_t, EMACS_INT,
2442 and double all fit in int.
2443 * term.c (set_tty_color_mode):
2444 Check that fixnums are in proper range for system types.
2445 * termhooks.h (struct input_event):
2446 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2447 * textprop.c (validate_interval_range, interval_of)
2448 (Fadd_text_properties, set_text_properties_1)
2449 (Fremove_text_properties, Fremove_list_of_text_properties)
2450 (Ftext_property_any, Ftext_property_not_all)
2451 (copy_text_properties, text_property_list, extend_property_ranges)
2452 (verify_interval_modification):
2453 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2454 (Fnext_single_char_property_change)
2455 (Fprevious_single_char_property_change):
2456 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2457 (copy_text_properties):
2458 Check for integer overflow in index calculation.
2459 * undo.c (last_boundary_position, record_point, record_insert)
2460 (record_delete, record_marker_adjustment, record_change)
2461 (record_property_change):
2462 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2463 (truncate_undo_list, Fprimitive_undo): Don't assume fixnum fits in int.
2464 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2465 * w32fns.c (Fx_create_frame, x_create_tip_frame, Fx_show_tip)
2466 (Fx_hide_tip, Fx_file_dialog):
2467 * w32menu.c (set_frame_menubar):
2468 Use ptrdiff_t, not int, for consistency with rest of code.
2469 * window.c (window_scroll_preserve_hpos, window_scroll_preserve_vpos)
2470 (select_window, Fdelete_other_windows_internal)
2471 (window_scroll_pixel_based, window_scroll_line_based)
2472 (Frecenter, Fset_window_configuration):
2473 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2474 (Fset_window_hscroll, run_window_configuration_change_hook)
2475 (set_window_buffer, temp_output_buffer_show, scroll_command)
2476 (Fscroll_other_window, Frecenter):
2477 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2478 (Fwindow_line_height, window_scroll, Fscroll_left, Fscroll_right):
2479 Don't assume fixnum fits in int.
2480 (Fset_window_scroll_bars):
2481 Check that fixnums are in proper range for system types.
2482 * xdisp.c (help_echo_pos, pos_visible_p, string_pos_nchars_ahead)
2483 (string_pos, c_string_pos, number_of_chars, init_iterator)
2484 (in_ellipses_for_invisible_text_p, init_from_display_pos)
2485 (compute_stop_pos, next_overlay_change, compute_display_string_pos)
2486 (compute_display_string_end, handle_face_prop)
2487 (face_before_or_after_it_pos, handle_invisible_prop)
2488 (handle_display_prop, handle_display_spec, handle_single_display_spec)
2489 (display_prop_intangible_p, string_buffer_position_lim)
2490 (string_buffer_position, handle_composition_prop, load_overlay_strings)
2491 (get_overlay_strings_1, get_overlay_strings)
2492 (iterate_out_of_display_property, forward_to_next_line_start)
2493 (back_to_previous_visible_line_start, reseat, reseat_to_string)
2494 (get_next_display_element, set_iterator_to_next)
2495 (get_visually_first_element, compute_stop_pos_backwards)
2496 (handle_stop_backwards, next_element_from_buffer)
2497 (move_it_in_display_line_to, move_it_in_display_line)
2498 (move_it_to, move_it_vertically_backward, move_it_by_lines)
2499 (add_to_log, message_dolog, message_log_check_duplicate)
2500 (message2, message2_nolog, message3, message3_nolog
2501 (with_echo_area_buffer, display_echo_area_1, resize_mini_window_1)
2502 (current_message_1, truncate_echo_area, truncate_message_1)
2503 (set_message, set_message_1, store_mode_line_noprop)
2504 (hscroll_window_tree, debug_delta, debug_delta_bytes, debug_end_vpos)
2505 (text_outside_line_unchanged_p, check_point_in_composition)
2506 (reconsider_clip_changes)
2507 (redisplay_internal, set_cursor_from_row, try_scrolling)
2508 (try_cursor_movement, set_vertical_scroll_bar, redisplay_window)
2509 (redisplay_window, find_last_unchanged_at_beg_row)
2510 (find_first_unchanged_at_end_row, row_containing_pos, try_window_id)
2511 (trailing_whitespace_p, find_row_edges, display_line)
2512 (RECORD_MAX_MIN_POS, Fcurrent_bidi_paragraph_direction)
2513 (display_mode_element, store_mode_line_string)
2514 (pint2str, pint2hrstr, decode_mode_spec)
2515 (display_count_lines, display_string, draw_glyphs)
2516 (x_produce_glyphs, x_insert_glyphs)
2517 (rows_from_pos_range, mouse_face_from_buffer_pos)
2518 (fast_find_string_pos, mouse_face_from_string_pos)
2519 (note_mode_line_or_margin_highlight, note_mouse_highlight):
2520 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2521 (safe_call, init_from_display_pos, handle_fontified_prop)
2522 (handle_single_display_spec, load_overlay_strings)
2523 (with_echo_area_buffer, setup_echo_area_for_printing)
2524 (display_echo_area, echo_area_display)
2525 (x_consider_frame_title, prepare_menu_bars, update_menu_bar)
2526 (update_tool_bar, hscroll_window_tree, redisplay_internal)
2527 (redisplay_window, dump_glyph_row, display_mode_line)
2528 (Fformat_mode_line, decode_mode_spec, on_hot_spot_p):
2529 (handle_display_spec, display_prop_string_p):
2530 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2531 (handle_single_display_spec, build_desired_tool_bar_string)
2532 (redisplay_tool_bar, scroll_window_tree, Fdump_glyph_matrix)
2533 (get_specified_cursor_type):
2534 Check that fixnums are in proper range for system types.
2535 (struct overlay_entry, resize_mini_window, Fdump_glyph_row)
2536 (Flookup_image_map):
2537 Don't assume fixnums fit in int.
2538 (compare_overlay_entries):
2539 Avoid mishandling comparisons due to subtraction overflow.
2540 (load_overlay_strings): Use SAFE_NALLOCA, not alloca.
2541 (last_escape_glyph_face_id, last_glyphless_glyph_face_id):
2542 (handle_tool_bar_click):
2543 Use int, not unsigned, since we prefer signed and the signedness
2544 doesn't matter here.
2545 (get_next_display_element, next_element_from_display_vector):
2546 Use int, not EMACS_INT, when int is wide enough.
2547 (start_hourglass): Use duration_to_sec_usec to do proper
2548 overflow checking on durations.
2549 * xfaces.c (Fbitmap_spec_p):
2550 Check that fixnums are in proper range for system types.
2551 (compare_fonts_by_sort_order):
2552 Avoid mishandling comparisons due to subtraction overflow.
2553 (Fx_family_fonts, realize_basic_faces):
2554 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2556 Don't assume fixnum fits in int.
2557 Use SAFE_ALLOCA_LISP, not alloca.
2558 (merge_face_heights): Remove unnecessary cast to EMACS_INT.
2559 (Finternal_make_lisp_face): Don't allocate more than MAX_FACE_ID.
2560 (face_at_buffer_position, face_for_overlay_string)
2561 (face_at_string_position):
2562 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2563 (merge_faces): Use int, not EMACS_INT, where int is wide enough.
2564 * xfns.c (x_set_menu_bar_lines, x_set_tool_bar_lines, x_icon_verify)
2566 Check that fixnums are in proper range for system types.
2567 (Fx_create_frame, x_create_tip_frame, Fx_show_tip)
2568 (Fx_hide_tip, Fx_file_dialog, Fx_select_font):
2569 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2570 (Fx_change_window_property): Don't assume fixnums fit in int.
2571 * xfont.c (xfont_chars_supported):
2572 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2573 * xmenu.c (Fx_popup_dialog, set_frame_menubar)
2574 (create_and_show_popup_menu, create_and_show_dialog, xmenu_show):
2575 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2576 * xml.c (parse_region):
2577 * xrdb.c (magic_file_p):
2578 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2579 * xselect.c (TRACE1): Don't assume pid_t promotes to int.
2580 (x_get_local_selection, x_reply_selection_request)
2581 (x_handle_selection_request, wait_for_property_change):
2582 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2583 (selection_data_to_lisp_data): Use short, not EMACS_INT, where
2584 short is wide enough.
2585 (x_send_client_event): Don't assume fixnum fits in int.
2586 * xterm.c (x_x_to_emacs_modifiers):
2587 Don't assume EMACS_INT overflows nicely into int.
2588 (x_emacs_to_x_modifiers): Use EMACS_INT, not int, because values
2590 (handle_one_xevent): NATNUMP can eval its arg twice.
2591 (x_connection_closed):
2592 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2593 * xterm.h: Adjust decls to match defn changes elsewhere.
2594 (struct scroll_bar): Use struct vectorlike_header
2595 rather than rolling our own approximation.
2596 (SCROLL_BAR_VEC_SIZE): Remove; not used.
2598 2012-05-25 Glenn Morris <rgm@gnu.org>
2600 * lisp.mk (lisp): Update for more files being compiled now.
2602 2012-05-25 Stefan Monnier <monnier@iro.umontreal.ca>
2604 * lread.c: Remove `read_pure' which makes no difference.
2605 (read_pure): Remove var.
2606 (unreadpure): Remove function.
2607 (readevalloop): Don't call read_list with -1 flag.
2608 (read1, read_vector): Don't test read_pure any more.
2609 (read_list): Simplify.
2611 * fileio.c, character.h: Minor style tweaks.
2613 2012-05-24 Dmitry Antipov <dmantipov@yandex.ru>
2615 * window.h (clip_changed): Remove useless declaration.
2617 2012-05-22 Juanma Barranquero <lekktu@gmail.com>
2619 * makefile.w32-in: Follow-up to 2012-05-22T16:20:27Z!eggert@cs.ucla.edu.
2620 (TAGS, TAGS-gmake, CONFIG_H): Remove further references to m/intel386.h.
2622 2012-05-22 Paul Eggert <eggert@cs.ucla.edu>
2625 This directory predates autoconf and is no longer needed nowadays.
2626 Move its few remaining bits of functionality to where they're needed.
2627 * m/README, m/alpha.h, m/amdx86-64.h, m/ia64.h, m/ibmrs6000.h:
2628 * m/ibms390x.h, m/intel386.h, m/m68k.h, m/macppc.h, m/sparc.h:
2629 * m/template.h: Remove.
2630 * Makefile.in (M_FILE): Remove. All uses removed.
2631 * alloc.c (POINTERS_MIGHT_HIDE_IN_OBJECTS):
2632 * lisp.h (USE_LSB_TAG):
2633 * mem-limits.h (EXCEEDS_LISP_PTR):
2634 Use VAL_MAX, not VALBITS, in #if.
2635 * lisp.h (EMACS_INT_MAX): New macro, useful in #if.
2636 (EMACS_UINT): Define unconditionally now.
2637 (BITS_PER_CHAR, BITS_PER_SHORT, BITS_PER_INT, BITS_PER_LONG)
2638 (BITS_PER_EMACS_INT): New constants, replacing
2639 what used to be in config.h, but not useful in #if.
2640 (GCTYPEBITS, VALBITS): Define unconditionally, since m/* files don't
2641 define them any more.
2642 (VAL_MAX): New macro.
2644 * puresize.h (PURESIZE_RATIO): Use EMACS_INT_MAX, not
2645 BITS_PER_EMACS_INT, in #if.
2646 * s/aix4-2.h (BROKEN_FIONREAD, BROKEN_SIGAIO, BROKEN_SIGPTY)
2647 (BROKEN_SIGPOLL): Move here from m/ibmrs6000.h, which was removed.
2648 * s/gnu-linux.h (ULIMIT_BREAK_VALUE) [__i386__]:
2649 * s/ms-w32.h (DATA_START):
2650 Move here from removed file m/intel386.h.
2651 * s/gnu.h (NLIST_STRUCT): Remove undef; 'configure' does this.
2652 * s/irix6-5.h (_LP64): Remove; lisp.h no longer needs this.
2654 2012-05-21 Paul Eggert <eggert@cs.ucla.edu>
2656 Assume C89 or later.
2657 * alloc.c, buffer.c, lisp.h: Replace POINTER_TYPE with void.
2658 * alloc.c (overrun_check_malloc, overrun_check_realloc, xmalloc)
2660 * buffer.c (mmap_free_1, mmap_enlarge): Omit needless casts.
2661 * editfns.c, fns.c, gmalloc.c, insdel.c, sysdep.c, termcap.c (NULL):
2662 * textprop.c, tparam.c (NULL): Remove.
2663 * ralloc.c, vm-limit.c (POINTER): Assume void * works.
2664 * regex.c (SIGN_EXTEND_CHAR): Assume signed char works.
2665 * regex.h (_RE_ARGS): Remove. All uses rewritten to use prototypes.
2666 * unexelf.c (ElfBitsW): Assume c89 preprocessor or better.
2667 * xterm.c (input_signal_count): Assume volatile works.
2669 2012-05-21 Ken Brown <kbrown@cornell.edu>
2671 * xgselect.c (xg_select): Fix first argument in call to 'select'
2674 2012-05-20 Ken Brown <kbrown@cornell.edu>
2676 * gmalloc.c (_free_internal_nolock, _realloc_internal_nolock)
2677 [CYGWIN]: Cast ptr to (char *) before comparing to _heapbase.
2679 2012-05-19 Ken Brown <kbrown@cornell.edu>
2681 * xfns.c (x_in_use): Remove `static' qualifier.
2682 * xterm.h (x_in_use): Declare.
2683 * xgselect.c: Include xterm.h.
2684 (xg_select): Test `x_in_use' instead of `inhibit_window_system'
2685 and `display_arg' (bug#9754).
2687 2012-05-19 Paul Eggert <eggert@cs.ucla.edu>
2689 * s/ms-w32.h (HAVE_GETDOMAINNAME): Remove; not needed.
2691 * m/vax.h: Remove; no longer needed since HAVE_FTIME is being removed.
2692 * s/ms-w32.h (HAVE_FTIME): Remove; not needed.
2694 2012-05-18 Eli Zaretskii <eliz@gnu.org>
2696 Fix compilation with -DGLYPH_DEBUG=1 on MS-Windows.
2698 * w32term.c [GLYPH_DEBUG]: Add prototype for x_check_font.
2699 (x_check_font) [GLYPH_DEBUG]: New function, copied from xterm.c
2701 * w32fns.c (unwind_create_frame) [GLYPH_DEBUG]: Fix broken
2702 reference to image_cache->refcount.
2703 (x_create_tip_frame): Fix broken use of FRAME_IMAGE_CACHE.
2705 2012-05-17 Juri Linkov <juri@jurta.org>
2707 * search.c (Fword_search_regexp, Fword_search_backward)
2708 (Fword_search_forward, Fword_search_backward_lax)
2709 (Fword_search_forward_lax): Move functions to isearch.el
2710 (bug#10145, bug#11381).
2712 2012-05-16 Paul Eggert <eggert@cs.ucla.edu>
2714 * xgselect.c (xg_select): Just invoke 'select' if -nw (Bug#9754).
2716 2012-05-15 Stefan Monnier <monnier@iro.umontreal.ca>
2718 * lread.c (init_obarray): Declare Qt and Qnil as special.
2720 2012-05-14 Glenn Morris <rgm@gnu.org>
2722 * nsterm.m (ns_init_paths): Fix typo ("libexec" not "lib-exec").
2723 Put "libexec" before "bin", for the sake of init_callproc_1.
2725 2012-05-14 Paul Eggert <eggert@cs.ucla.edu>
2727 * keyboard.c (kbd_buffer_get_event) [!HAVE_DBUS]: Omit unused local.
2729 * unexaix.c: Port to more-recent AIX compilers.
2730 (report_error, report_error_1, make_hdr, copy_sym)
2731 (mark_x, adjust_lnnoptrs, unrelocate_symbols):
2732 Make arguments const char *, not char *, to avoid violations of C
2733 standard and to fix some AIX warnings reported by Gilles Pion.
2735 2012-05-14 Eli Zaretskii <eliz@gnu.org>
2737 * xdisp.c (handle_stop): Don't call get_overlay_strings_1 if we
2738 already have overlays loaded.
2739 (handle_single_display_spec): Before returning without displaying
2740 fringe bitmap, synchronize the bidi iterator with the main display
2741 iterator, by calling iterate_out_of_display_property.
2742 (iterate_out_of_display_property): Detect buffer iteration by
2743 testing that it->string is a Lisp string.
2744 (get_next_display_element): When the current object is exhausted,
2745 and there's something on it->stack, call set_iterator_to_next to
2746 proceed with what's on the stack, instead of returning zero.
2747 (set_iterator_to_next): If called at the end of a Lisp string,
2748 proceed to consider_string_end without incrementing string
2749 position. Don't increment display vector index past the end of
2750 the display vector. (Bug#11417)
2751 (pos_visible_p): Don't report a position visible when move_it_to
2752 stopped at the last line of window, which happens to be scanned
2753 backwards by the bidi iteration. (Bug#11464)
2755 2012-05-14 Eli Zaretskii <eliz@gnu.org>
2757 * xdisp.c (handle_single_display_spec): Return 1 for left-margin
2758 and right-margin display specs even if the spec is invalid or we
2759 are on a TTY, and thus unable to display on the fringes.
2760 That's because the text with the property will not be displayed anyway,
2761 so we need to signal to the caller that this is a "replacing"
2762 display spec. This fixes display when the spec is invalid or we
2765 2012-05-14 Paul Eggert <eggert@cs.ucla.edu>
2767 * unexaix.c (make_hdr): Fix typo in prototype.
2768 This bug broke the build on AIX. Problem reported by Gilles Pion.
2770 2012-05-14 Michael Albinus <michael.albinus@gmx.de>
2772 * keyboard.c (kbd_buffer_get_event): Read special events also in
2773 batch mode. (Bug#11415)
2775 2012-05-12 Glenn Morris <rgm@gnu.org>
2777 * ns.mk: Update for ns_appbindir no longer having trailing "/".
2779 2012-05-12 Eli Zaretskii <eliz@gnu.org>
2781 * lisp.mk (lisp): Add newcomment.elc.
2783 2012-05-12 Glenn Morris <rgm@gnu.org>
2785 * Makefile.in (MKDIR_P): New, set by configure.
2786 * ns.mk (${ns_appdir}, ${ns_appbindir}Emacs): Use $MKDIR_P.
2788 2012-05-11 Paul Eggert <eggert@cs.ucla.edu>
2790 Remove unused function hourglass_started.
2791 * dispextern.h (hourglass_started):
2792 * w32fns.c (hourglass_started):
2793 * xdisp.c (hourglass_started): Remove.
2795 2012-05-10 Juanma Barranquero <lekktu@gmail.com>
2797 * makefile.w32-in ($(BLD)/gmalloc.$(O), $(BLD)/w32menu.$(O)):
2798 Update dependencies.
2800 2012-05-10 Paul Eggert <eggert@cs.ucla.edu>
2802 * xgselect.c (xg_select): Put maxfds+1 into a var.
2803 This is slightly clearer, and pacifies Ubuntu 12.04 gcc.
2805 * sound.c (DEFAULT_ALSA_SOUND_DEVICE): Define only if HAVE_ALSA.
2807 2012-05-10 Dave Abrahams <dave@boostpro.com>
2809 * filelock.c (syms_of_filelock): New boolean create-lockfiles.
2810 (lock_file): If create_lockfiles is 0, do nothing. (Bug#11227)
2812 2012-05-09 Michael Albinus <michael.albinus@gmx.de>
2814 * dbusbind.c (xd_registered_buses): New internal Lisp object.
2815 Rename all occurences of Vdbus_registered_buses to xd_registered_buses.
2816 (syms_of_dbusbind): Remove declaration of Vdbus_registered_buses.
2817 Initialize xd_registered_buses.
2819 2012-05-09 Paul Eggert <eggert@cs.ucla.edu>
2821 Untag more efficiently if USE_LSB_TAG.
2822 This is based on a proposal by YAMAMOTO Mitsuharu in
2823 <http://lists.gnu.org/archive/html/emacs-devel/2008-01/msg01876.html>.
2824 For an admittedly artificial (nth 8000 longlist) benchmark on
2825 Fedora 15 x86-64, this yields a 25% CPU speedup. Also, it shrinks
2826 Emacs's overall text size by 1%.
2827 * lisp.h (XUNTAG): New macro.
2828 (XCONS, XVECTOR, XSTRING, XSYMBOL, XFLOAT, XMISC, XPROCESS, XWINDOW)
2829 (XTERMINAL, XSUBR, XBUFFER, XCHAR_TABLE, XSUB_CHAR_TABLE, XBOOL_VECTOR)
2830 (XSETTYPED_PSEUDOVECTOR, XHASH_TABLE, TYPED_PSEUDOVECTORP): Use it.
2831 * eval.c (Fautoload):
2832 * font.h (XFONT_SPEC, XFONT_ENTITY, XFONT_OBJECT):
2833 * frame.h (XFRAME): Use XUNTAG.
2835 Port recent dbusbind.c changes to 32-bit --with-wide-int.
2836 * dbusbind.c (xd_append_arg, xd_retrieve_arg, Fdbus_message_internal):
2837 Remove unportable assumptions about print widths of types like
2839 (xd_get_connection_address, Fdbus_init_bus): Cast Emacs integer to
2840 intptr_t when converting between pointer and integer, to avoid GCC
2841 warnings about wrong width.
2843 2012-05-09 Eli Zaretskii <eliz@gnu.org>
2845 * w32proc.c (new_child): Force Windows to reserve only 64KB of
2846 stack for each reader_thread, instead of defaulting to 8MB
2847 determined by the linker. This avoids failures in creating
2848 subprocesses on Windows 7, see the discussion in this thread:
2849 http://lists.gnu.org/archive/html/emacs-devel/2012-03/msg00119.html.
2851 2012-05-07 Jérémy Compostella <jeremy.compostella@gmail.com>
2853 Fix up display of the *Minibuf-0* buffer in the mini window.
2854 * keyboard.c (read_char): Don't clear the echo area if there's no
2856 * xdisp.c (redisplay_internal): Redisplay the mini window (with the
2857 contents of *Minibuf-0*) if there's no message displayed in its stead.
2859 2012-05-07 Michael Albinus <michael.albinus@gmx.de>
2861 * dbusbind.c (XD_DEBUG_MESSAGE): Don't print message twice in
2864 2012-05-06 Chong Yidong <cyd@gnu.org>
2866 * lisp.mk (lisp): Update.
2868 2012-05-05 Jim Meyering <meyering@redhat.com>
2870 * w32font.c (fill_in_logfont): NUL-terminate a string (Bug#11372).
2872 2012-05-04 Stefan Monnier <monnier@iro.umontreal.ca>
2874 * data.c (PUT_ERROR): New macro.
2875 (syms_of_data): Use it. Add new error type `user-error'.
2876 * undo.c (user_error): New function.
2877 (Fprimitive_undo): Use it.
2878 * print.c (print_error_message): Adjust print style for `user-error'.
2879 * keyboard.c (user_error): New function.
2880 (Fexit_recursive_edit, Fabort_recursive_edit): Use it.
2882 2012-05-03 Paul Eggert <eggert@cs.ucla.edu>
2884 Do not limit current-time-string to years 1000..9999.
2885 * editfns.c (TM_YEAR_IN_ASCTIME_RANGE): Remove.
2886 (Fcurrent_time_string): Support any year that is supported by the
2887 underlying localtime representation. Don't use asctime, as it
2888 has undefined behavior for years outside the range -999..9999.
2890 2012-05-02 Paul Eggert <eggert@cs.ucla.edu>
2892 Fix race conditions involving setenv, gmtime, localtime, asctime.
2893 Without this fix, interrupts could mess up code that uses these
2894 nonreentrant functions, since setting TZ invalidates existing
2895 tm_zone or tzname values, and since most of these functions return
2896 pointers to static storage.
2897 * editfns.c (format_time_string, Fdecode_time, Fencode_time)
2898 (Fcurrent_time_string, Fcurrent_time_zone, Fset_time_zone_rule):
2899 Grow the critical sections to include not just invoking
2900 localtime/gmtime, but also accessing these functions' results
2901 including their tm_zone values if any, and any related TZ setting.
2902 (format_time_string): Last arg is now struct tm *, not struct tm **,
2903 so that the struct tm is saved in the critical section.
2904 All callers changed. Simplify allocation of initial buffer, partly
2905 motivated by the fact that memory allocation needs to be outside
2906 the critical section.
2908 2012-05-02 Dmitry Antipov <dmantipov@yandex.ru>
2910 * intervals.c (adjust_intervals_for_insertion): Initialize `newi'
2911 with RESET_INTERVAL.
2913 * buffer.c (Fget_buffer_create, Fmake_indirect_buffer):
2914 Remove duplicated buffer name initialization.
2916 2012-05-02 Jim Meyering <jim@meyering.net>
2918 * xterm.c (x_term_init): Use memcpy instead of strncpy (Bug#11373).
2920 * xfns.c (x_window): Use xstrdup (Bug#11375).
2922 2012-05-02 Eli Zaretskii <eliz@gnu.org>
2924 * xdisp.c (pos_visible_p): If already at a newline from the
2925 display string before the 'while' loop, don't walk back the glyphs
2926 from it3.glyph_row. Solves assertion violation when the display
2927 string begins with a newline (egg.el). (Bug#11367)
2929 2012-05-01 Stefan Monnier <monnier@iro.umontreal.ca>
2931 * keyboard.c (Fexecute_extended_command, Vsuggest_key_bindings):
2934 2012-05-01 Glenn Morris <rgm@gnu.org>
2936 * syssignal.h: Remove reference to BROKEN_SIGINFO (last used in
2937 s/ptx4.h), BROKEN_SIGTSTP (last used in m/ustation.h, m/dpx2.h),
2938 and BROKEN_SIGURG (was in s/gnu-linux.h prior to 2008-02-10).
2939 All were removed before 23.1.
2941 * dispnew.c: Remove HAVE_LIBNCURSES test;
2942 it is always true on relevant platforms.
2944 * Makefile.in (LD_SWITCH_X_SITE_RPATH):
2945 Rename from LD_SWITCH_X_SITE_AUX_RPATH.
2947 * Makefile.in (LD_SWITCH_X_SITE_AUX): Remove; no longer used.
2949 2012-04-30 Andreas Schwab <schwab@linux-m68k.org>
2951 * .gdbinit (xpr): Remove checks for no longer existing misc types.
2952 (xintfwd, xboolfwd, xobjfwd, xbufobjfwd, xkbobjfwd, xbuflocal):
2955 2012-04-28 Paul Eggert <eggert@cs.ucla.edu>
2957 Do not avoid creating empty evaporating overlays (Bug#9642).
2958 * buffer.c (Fmove_overlay): Revert the change of 2012-04-23.
2959 That is, do not delete an evaporating overlay if it becomes
2960 empty after its bounds are adjusted to fit within its buffer.
2961 This fix caused other problems, and I'm reverting it until we get
2962 to the bottom of them.
2964 2012-04-27 Chong Yidong <cyd@gnu.org>
2966 * xselect.c (x_convert_selection): Initialize a pointer (Bug#11315).
2968 2012-04-27 Eli Zaretskii <eliz@gnu.org>
2970 * xdisp.c (pos_visible_p): If the window start position is beyond
2971 ZV, start the display from buffer beginning. Prevents assertion
2972 violation in init_iterator when the minibuffer window is scrolled
2975 * window.c (window_scroll_pixel_based): Likewise.
2977 2012-04-27 Chong Yidong <cyd@gnu.org>
2979 * keymap.c (where_is_internal): Doc fix (Bug#10872).
2981 2012-04-27 Glenn Morris <rgm@gnu.org>
2983 * fileio.c (Fcopy_file, Fset_file_selinux_context):
2984 Ignore ENOTSUP failures from setfilecon functions. (Bug#11245)
2986 2012-04-27 Eli Zaretskii <eliz@gnu.org>
2988 * dispnew.c (swap_glyph_pointers, copy_row_except_pointers):
2989 Don't overrun array limits of glyph row's used[] array. (Bug#11288)
2991 2012-04-26 Eli Zaretskii <eliz@gnu.org>
2993 * xdisp.c (IT_DISPLAYING_WHITESPACE): In addition to the loaded
2994 display element, check also the underlying string or buffer
2995 character. (Bug#11341)
2997 * w32menu.c: Include w32heap.h.
2998 (add_menu_item): If the call to AppendMenuW (via
2999 unicode_append_menu) fails, disable Unicode menus only if we are
3000 running on Windows 9X/Me.
3002 2012-04-24 Andreas Schwab <schwab@linux-m68k.org>
3004 * .gdbinit (xpr): Handle USE_2_TAGS_FOR_INTS.
3005 (xgetint): Add missing shift for LSB tags.
3007 2012-04-24 Martin Rudalics <rudalics@gmx.at>
3009 * keyboard.c (read_char): Don't wipe echo area for select window
3010 events: These might get delayed via `mouse-autoselect-window'
3013 2012-04-24 Juanma Barranquero <lekktu@gmail.com>
3015 * gnutls.c (init_gnutls_functions): Protect against (unlikely)
3016 manipulation of :loaded-from data.
3018 2012-04-23 Juanma Barranquero <lekktu@gmail.com>
3020 * gnutls.c (init_gnutls_functions): The value of :loaded-from is
3021 now a cons (bug#11311).
3023 2012-04-23 Paul Eggert <eggert@cs.ucla.edu>
3025 Do not create empty overlays with the evaporate property (Bug#9642).
3026 * buffer.c (Fmove_overlay): Delete an evaporating overlay
3027 if it becomes empty after its bounds are adjusted to fit within
3028 its buffer. Without this fix, in a nonempty buffer (let ((o
3029 (make-overlay 1 2))) (overlay-put o 'evaporate t) (move-overlay o 0 1))
3030 yields an empty overlay that has the evaporate property, which is
3031 not supposed to happen.
3033 Fix minor GTK3 problems found by static checking.
3034 * emacsgtkfixed.c (EMACS_TYPE_FIXED, EMACS_FIXED, EmacsFixed)
3035 (EmacsFixedPrivate, EmacsFixedClass, struct _EmacsFixed)
3036 (struct _EmacsFixedClass, emacs_fixed_get_type):
3037 Move decls here from emacsgtkfixed.h, since they needn't be public.
3038 (emacs_fixed_get_type): Now static.
3039 (emacs_fixed_class_init): Omit unused local.
3040 (emacs_fixed_child_type): Remove; unused.
3041 * emacsgtkfixed.h (EMACS_TYPE_FIXED, EMACS_FIXED, EmacsFixed)
3042 (EmacsFixedPrivate, EmacsFixedClass, struct _EmacsFixed)
3043 (struct _EmacsFixedClass): Move to emacsgtkfixed.c.
3044 (EMACS_FIXED_CLASS, EMACS_IS_FIXED, EMACS_IS_FIXED_CLASS)
3045 (EMACS_FIXED_GET_CLASS): Remove; unused.
3046 * gtkutil.c (xg_create_frame_widgets) [!HAVE_GTK3]: Omit unused local.
3048 * keyboard.c (handle_async_input): Define only if SYNC_INPUT || SIGIO.
3049 Problem reported by Juanma Barranquero for Windows -Wunused-function.
3051 2012-04-22 Paul Eggert <eggert@cs.ucla.edu>
3053 Modernize and clean up gmalloc.c to assume C89 (Bug#9119).
3054 * gmalloc.c (_MALLOC_INTERNAL, _MALLOC_H, _PP, __ptr_t)
3055 (__malloc_size_t, __malloc_ptrdiff_t):
3056 Remove. All uses removed, replaced by the definiens if needed,
3057 since we can assume C89 or better now.
3058 Include <stdint.h>, for PTRDIFF_MAX, uintptr_t.
3059 (protect_malloc_state, align, get_contiguous_space)
3060 (malloc_atfork_handler_prepare, malloc_atfork_handler_parent)
3061 (malloc_atfork_handler_child, malloc_enable_thread)
3062 (malloc_initialize_1, __malloc_initialize, morecore_nolock)
3063 (_malloc_internal_nolock, _malloc_internal, malloc, _malloc)
3064 (_free, _realloc, _free_internal_nolock, _free_internal, free, cfree)
3065 (special_realloc, _realloc_internal_nolock, _realloc_internal)
3066 (realloc, calloc, __default_morecore, memalign, valloc, checkhdr)
3067 (freehook, mallochook, reallochook, mabort, mcheck, mprobe):
3068 Define using prototypes, not old style.
3069 (align, _malloc_internal_nolock, _free_internal_nolock, memalign):
3070 Don't assume ptrdiff_t and uintptr_t are no wider than unsigned long.
3071 (align): Don't assume that signed integer overflow wraps around.
3072 Omit unused local var.
3073 (malloc_initialize_1, morecore_nolock, _malloc_internal_nolock)
3074 (_free_internal_nolock, memalign, mallochook, reallochook):
3075 Omit no-longer-needed casts.
3076 (valloc): Use getpagesize, not __getpagesize.
3077 (MAGICWORD, MAGICFREE): Now randomish size_t values, not 32-bit.
3078 (struct hdr): The 'magic' member is now size_t, not unsigned long.
3080 * dbusbind.c (XD_DBUS_VALIDATE_OBJECT): Define only if needed.
3082 2012-04-22 Michael Albinus <michael.albinus@gmx.de>
3084 Move functions from C to Lisp. Make non-blocking method calls
3085 the default. Implement further D-Bus standard interfaces.
3087 * dbusbind.c (DBUS_NUM_MESSAGE_TYPES): Declare.
3088 (QCdbus_request_name_allow_replacement)
3089 (QCdbus_request_name_replace_existing)
3090 (QCdbus_request_name_do_not_queue)
3091 (QCdbus_request_name_reply_primary_owner)
3092 (QCdbus_request_name_reply_in_queue)
3093 (QCdbus_request_name_reply_exists)
3094 (QCdbus_request_name_reply_already_owner): Move to dbus.el.
3095 (QCdbus_registered_serial, QCdbus_registered_method)
3096 (QCdbus_registered_signal): New Lisp objects.
3097 (XD_DEBUG_MESSAGE): Use sizeof.
3098 (XD_MESSAGE_TYPE_TO_STRING, XD_OBJECT_TO_STRING)
3099 (XD_DBUS_VALIDATE_BUS_ADDRESS, XD_DBUS_VALIDATE_OBJECT)
3100 (XD_DBUS_VALIDATE_BUS_NAME, XD_DBUS_VALIDATE_PATH)
3101 (XD_DBUS_VALIDATE_INTERFACE, XD_DBUS_VALIDATE_MEMBER): New macros.
3102 (XD_CHECK_DBUS_SERIAL): Rename from CHECK_DBUS_SERIAL_GET_SERIAL.
3103 (xd_signature, xd_append_arg): Allow float for integer types.
3104 (xd_get_connection_references): New function.
3105 (xd_get_connection_address): Rename from xd_initialize.
3106 Return cached address.
3107 (xd_remove_watch): Do not unset $DBUS_SESSION_BUS_ADDRESS.
3108 (xd_close_bus): Rename from Fdbus_close_bus. Not needed on Lisp
3110 (Fdbus_init_bus): New optional arg PRIVATE. Cache address.
3111 Return number of refcounts.
3112 (Fdbus_get_unique_name): Make stronger parameter check.
3113 (Fdbus_message_internal): New defun.
3114 (Fdbus_call_method, Fdbus_call_method_asynchronously)
3115 (Fdbus_method_return_internal, Fdbus_method_error_internal)
3116 (Fdbus_send_signal, Fdbus_register_service)
3117 (Fdbus_register_signal, Fdbus_register_method): Move to dbus.el.
3118 (xd_read_message_1): Obey new structure of Vdbus_registered_objects.
3119 (xd_read_queued_messages): Obey new structure of Vdbus_registered_buses.
3120 (Vdbus_compiled_version, Vdbus_runtime_version)
3121 (Vdbus_message_type_invalid, Vdbus_message_type_method_call)
3122 (Vdbus_message_type_method_return, Vdbus_message_type_error)
3123 (Vdbus_message_type_signal): New defvars.
3124 (Vdbus_registered_buses, Vdbus_registered_objects_table):
3127 2012-04-22 Paul Eggert <eggert@cs.ucla.edu>
3129 Fix GC_MALLOC_CHECK debugging output on 64-bit hosts.
3130 * alloc.c (emacs_blocked_malloc) [GC_MALLOC_CHECK]:
3131 Do not assume ptrdiff_t is the same width as 'int'.
3133 * alloc.c: Handle unusual debugging option combinations.
3134 (GC_CHECK_MARKED_OBJECTS): Undef if ! GC_MARK_STACK,
3135 since the two debugging options are incompatible.
3136 (GC_MALLOC_CHECK): Similarly, undef if GC_CHECK_MARKED_OBJECTS
3138 (mem_init, mem_insert, mem_insert_fixup):
3139 Define if GC_MARK_STACK || GC_MALLOC_CHECK.
3140 (NEED_MEM_INSERT): Remove; no longer needed.
3142 2012-04-22 Leo Liu <sdl.web@gmail.com>
3144 * sysdep.c (list_system_processes): Support Darwin (Bug#5725).
3146 2012-04-22 Paul Eggert <eggert@cs.ucla.edu>
3148 * sysdep.c [__FreeBSD__]: Minor cleanups.
3149 (list_system_processes, system_process_attributes) [__FreeBSD__]:
3150 Use Emacs indenting style more consistently. Avoid some casts.
3151 Use 'double' consistently rather than mixing 'float' and 'double'.
3153 2012-04-21 Eduard Wiebe <usenet@pusto.de>
3155 * sysdep.c (list_system_processes, system_process_attributes):
3156 Add implementation for FreeBSD (Bug#5243).
3158 2012-04-21 Andreas Schwab <schwab@linux-m68k.org>
3160 * lisp.mk (lisp): Update.
3162 2012-04-20 Paul Eggert <eggert@cs.ucla.edu>
3164 * keyboard.c (process_pending_signals): Define only if SYNC_INPUT.
3165 It is never used otherwise.
3167 2012-04-20 Stefan Monnier <monnier@iro.umontreal.ca>
3169 * print.c (print_preprocess): Only check print_depth if print-circle
3171 (print_object): Check for cycles even when print-circle is nil and
3172 print-gensym is t, but only check print_depth if print-circle is nil.
3174 2012-04-20 Chong Yidong <cyd@gnu.org>
3176 * process.c (wait_reading_process_output): If EIO occurs on a pty,
3177 set the status to "failed" and ensure that sentinel is run.
3179 2012-04-20 Glenn Morris <rgm@gnu.org>
3181 * process.c (Fset_process_inherit_coding_system_flag)
3182 (Fset_process_query_on_exit_flag): Doc fix (mention return value).
3183 (Fmake_network_process, Fmake_serial_process): Doc fix.
3185 2012-04-20 Eli Zaretskii <eliz@gnu.org>
3187 * xdisp.c (string_buffer_position_lim): Limit starting position to
3189 (set_cursor_from_row): If called for a mode-line or header-line
3190 row, return zero immediately.
3191 (try_cursor_movement): If inside continuation line, don't back up
3192 farther than the first row after the header line, if any.
3193 Don't consider the header-line row as "partially visible", even if
3194 MATRIX_ROW_PARTIALLY_VISIBLE_P returns non-zero. (Bug#11261)
3196 2012-04-20 Atsuo Ohki <ohki@gssm.otsuka.tsukuba.ac.jp> (tiny change)
3198 * lread.c (lisp_file_lexically_bound_p): Fix hang at ";-*-\n"
3201 2012-04-20 Teodor Zlatanov <tzz@lifelogs.com>
3202 2012-04-18 Paul Eggert <eggert@cs.ucla.edu>
3204 configure: new option --enable-gcc-warnings (Bug#11207)
3205 * Makefile.in (C_WARNINGS_SWITCH): Remove.
3206 (WARN_CFLAGS, WERROR_CFLAGS): New macros.
3207 (ALL_CFLAGS): Use new macros rather than old.
3208 * process.c: Ignore -Wstrict-overflow to work around GCC bug 52904.
3209 * regex.c: Ignore -Wstrict-overflow. If !emacs, also ignore
3210 -Wunused-but-set-variable, -Wunused-function, -Wunused-macros,
3211 -Wunused-result, -Wunused-variable. This should go away once
3212 the Emacs and Gnulib regex code is merged.
3213 (xmalloc, xrealloc): Now static.
3215 2012-04-17 Paul Eggert <eggert@cs.ucla.edu>
3217 * dired.c (Fsystem_groups): Remove unused local.
3219 2012-04-17 Glenn Morris <rgm@gnu.org>
3221 * dired.c (Fsystem_users): Doc fix.
3223 2012-04-17 Dmitry Antipov <dmantipov@yandex.ru>
3225 * dired.c (Fsystem_users, Fsystem_groups): New functions. (Bug#7900)
3226 (syms_of_dired): Add them.
3228 2012-04-16 Paul Eggert <eggert@cs.ucla.edu>
3230 Fix minor alloc.c problems found by static checking.
3231 * alloc.c (_malloc_internal, _free_internal) [!DOUG_LEA_MALLOC]:
3232 New extern decls, to avoid calling undeclared functions.
3233 (dont_register_blocks): Define if ((!SYSTEM_MALLOC && !SYNC_INPUT)
3234 && GC_MALLOC_CHECK), not if ((GC_MARK_STACK || defined
3235 GC_MALLOC_CHECK) && GC_MALLOC_CHECK), to match when it's used.
3236 (NEED_MEM_INSERT): New macro.
3237 (mem_insert, mem_insert_fixup) [!NEED_MEM_INSERT]: Remove; unused.
3238 Remove one incorrect comment and fix another.
3240 Fix minor ralloc.c problems found by static checking.
3241 See http://lists.gnu.org/archive/html/emacs-devel/2011-12/msg00720.html
3242 * ralloc.c (ALIGNED, ROUND_TO_PAGE, HEAP_PTR_SIZE)
3243 (r_alloc_size_in_use, r_alloc_freeze, r_alloc_thaw): Remove; unused.
3244 (r_alloc_sbrk): Now static.
3246 Improve ralloc.c interface checking.
3247 See http://lists.gnu.org/archive/html/emacs-devel/2011-12/msg00720.html
3248 * buffer.c (ralloc_reset_variable, r_alloc, r_re_alloc)
3249 (r_alloc_free) [REL_ALLOC]: Move decls from here ...
3250 * lisp.h (r_alloc, r_alloc_free, r_re_alloc, r_alloc_reset_variable)
3251 [REL_ALLOC]: ... to here, to check interface.
3252 * m/ia64.h (r_alloc, r_alloc_free) [REL_ALLOC && !_MALLOC_INTERNAL]:
3253 Remove decls. This fixes an "It stinks!".
3255 * alloc.c (which_symbols): Fix alignment issue / type clash.
3257 2012-04-15 Andreas Schwab <schwab@linux-m68k.org>
3259 * lisp.h (struct Lisp_Symbol): Remove explicit padding.
3260 (struct Lisp_Misc_Any): Likewise.
3261 (struct Lisp_Free): Likewise.
3262 * alloc.c (union aligned_Lisp_Symbol): Define.
3263 (SYMBOL_BLOCK_SIZE, struct symbol_block): Use union
3264 aligned_Lisp_Symbol instead of struct Lisp_Symbol.
3265 (union aligned_Lisp_Misc): Define.
3266 (MARKER_BLOCK_SIZE, struct marker_block): Use union
3267 aligned_Lisp_Misc instead of union Lisp_Misc.
3268 (Fmake_symbol, allocate_misc, gc_sweep): Adjust.
3270 2012-04-14 Paul Eggert <eggert@cs.ucla.edu>
3272 Make GC_MAKE_GCPROS_NOOPS the default (Bug#9926).
3273 * lisp.h (GC_MARK_STACK): Default to GC_MAKE_GCPROS_NOOPS.
3274 * s/cygwin.h, s/darwin.h, s/freebsd.h, s/gnu.h, s/irix6-5.h, s/msdos.h:
3275 * s/netbsd.h, s/sol2-6.h:
3276 Remove definition of GC_MARK_STACK, since the default now works.
3277 * s/aix4-2.h, s/hpux10-20.h, s/unixware.h:
3278 Define GC_MARK_STACK to GC_USE_GCPROS_AS_BEFORE, since that's
3279 no longer the default.
3280 * s/gnu-linux.h (GC_MARK_STACK): Adjust to change in default.
3282 2012-04-14 Atsuo Ohki <ohki@gssm.otsuka.tsukuba.ac.jp> (tiny change)
3284 * lread.c (lisp_file_lexically_bound_p):
3285 Fix hang at ";-*-\n" (bug#11238).
3287 2012-04-14 Eli Zaretskii <eliz@gnu.org>
3289 * xdisp.c (find_last_unchanged_at_beg_row): Don't consider a row
3290 "unchanged" if its end.pos is beyond ZV. (Bug#11199)
3292 2012-04-14 Jan Djärv <jan.h.d@swipnet.se>
3294 * nsterm.m (constrainFrameRect): Always constrain when there is only
3295 one screen (Bug#10962).
3297 2012-04-13 Ken Brown <kbrown@cornell.edu>
3299 * s/cygwin.h (PTY_OPEN): Don't try to close a bogus file descriptor.
3301 2012-04-13 Reuben Thomas <rrt@sc3d.org>
3303 * indent.c (Fmove_to_column): Change interactive spec (Bug#739).
3305 2012-04-11 Daniel Colascione <dancol@dancol.org>
3307 * s/cygwin.h: The vfork the #define in cygwin.h was protecting
3308 against is gone. It's better to use vfork now so that when Cygwin
3309 gains a new, working vfork, we use it automatically (bug#10398).
3311 2012-04-11 Stefan Monnier <monnier@iro.umontreal.ca>
3313 * window.c (save_window_save): Obey window-point-insertion-type.
3315 2012-04-11 Glenn Morris <rgm@gnu.org>
3317 * Makefile.in (GNUSTEP_CFLAGS): Rename from C_SWITCH_X_SYSTEM.
3319 2012-04-11 Stefan Monnier <monnier@iro.umontreal.ca>
3321 * alloc.c (lisp_align_malloc): Remove unneeded prototype.
3323 2012-04-10 Jason S. Cornez <jcornez@ravenpack.com> (tiny change)
3325 * keyboard.c: Override inhibit-quit after the third C-g (bug#6585).
3326 (force_quit_count): New var.
3327 (handle_interrupt): Use it.
3329 2012-04-10 Juanma Barranquero <lekktu@gmail.com>
3331 * w32.c (w32_delayed_load): Record the full path of the library
3332 being loaded (bug#10424).
3334 2012-04-09 Glenn Morris <rgm@gnu.org>
3336 * doc.c (Fsnarf_documentation): Check variables, functions are bound,
3337 not just in the obarray, before snarfing them. (Bug#11036)
3339 * Makefile.in ($(leimdir)/leim-list.el):
3340 Pass EMACS rather than BUILT_EMACS.
3342 2012-04-09 Teodor Zlatanov <tzz@lifelogs.com>
3344 * process.c (make_process):
3345 * process.h: Add integer `gnutls_handshakes_tried' member to
3348 * gnutls.h: Add `GNUTLS_EMACS_HANDSHAKES_LIMIT' upper limit.
3349 Add convenience `GNUTLS_LOG2i' macro.
3351 * gnutls.c (gnutls_log_function2i): Convenience log function.
3352 (emacs_gnutls_read): Use new log functions,
3353 `gnutls_handshakes_tried' process member, and
3354 `GNUTLS_EMACS_HANDSHAKES_LIMIT' to limit the number of handshake
3355 attempts per process (connection).
3357 2012-04-09 Chong Yidong <cyd@gnu.org>
3359 * eval.c (Fuser_variable_p, user_variable_p_eh)
3360 (lisp_indirect_variable): Functions deleted.
3361 (Fdefvar): Caller changed.
3363 * callint.c (Finteractive, Fcall_interactively):
3364 * minibuf.c (Fread_variable): Callers changed.
3366 2012-04-09 Eli Zaretskii <eliz@gnu.org>
3368 * xdisp.c (set_cursor_from_row): If the display string appears in
3369 the buffer at position that is closer to point than the position
3370 after the display string, display the cursor on the first glyph of
3371 the display string. Fixes cursor display when a 'display' text
3372 property immediately follows invisible text. (Bug#11094)
3374 2012-04-09 Paul Eggert <eggert@cs.ucla.edu>
3376 composite.c: use 'double' consistently
3377 * composite.c (get_composition_id): Use 'double' consistently
3378 instead of converting 'float' to 'double' and vice versa; this is
3379 easier to understand and avoids a GCC warning.
3381 2012-04-09 Glenn Morris <rgm@gnu.org>
3383 * Makefile.in: Generate leim-list with bootstrap-emacs, in
3384 preparation for dumping it with emacs. (Bug#4789)
3385 (leimdir): New variable.
3386 ($(leimdir)/leim-list.el): New rule.
3387 (emacs$(EXEEXT)): Depend on leim-list.el.
3389 * buffer.c (Qucs_set_table_for_input): Remove. (Bug#9821)
3390 (Fget_buffer_create): Don't call Qucs_set_table_for_input.
3391 (init_buffer_once, syms_of_buffer): Remove Qucs_set_table_for_input.
3393 2012-04-08 Andreas Schwab <schwab@linux-m68k.org>
3395 * lisp.h (struct Lisp_Symbol): Add explicit padding to ensure
3398 2012-04-07 Juanma Barranquero <lekktu@gmail.com>
3400 * xml.c (init_libxml2_functions) [WINDOWSNT]:
3401 Remove unused local variable.
3403 2012-04-07 Paul Eggert <eggert@cs.ucla.edu>
3405 Avoid unnecessary pointer scanning in garbage collection (Bug#10780).
3406 * alloc.c (POINTERS_MIGHT_HIDE_IN_OBJECTS): New macro.
3407 (mark_memory): Mark Lisp_Objects only if pointers might hide in
3408 objects, as mark_maybe_pointer will catch them otherwise.
3409 (GC_LISP_OBJECT_ALIGNMENT): Remove; no longer needed.
3410 * s/gnu-linux.h (GC_LISP_OBJECT_ALIGNMENT) [__mc68000__]: Likewise.
3412 2012-04-07 Paul Eggert <eggert@cs.ucla.edu>
3414 Fix typo that broke non-Windows builds.
3415 * xml.c (libxml2_loaded_p) [!!WINDOWSNT]: 'inine' -> 'inline'.
3417 2012-04-07 Eli Zaretskii <eliz@gnu.org>
3419 Support building on MS-Windows with libxml2.
3421 * makefile.w32-in (OBJ2): Add xml.$(O).
3422 (GLOBAL_SOURCES): Add xml.c.
3423 ($(BLD)/xml.$(O)): New dependency list.
3425 * xml.c (DEF_XML2_FN, LOAD_XML2_FN) [WINDOWSNT]: New macros.
3426 (fn_htmlReadMemory, fn_xmlReadMemory, fn_xmlDocGetRootElement)
3427 (fn_xmlFreeDoc, fn_xmlCleanupParser, fn_xmlCheckVersion)
3428 [!WINDOWSNT]: New macros.
3429 (init_libxml2_functions, libxml2_loaded_p): New functions.
3430 (parse_region): Call fn_xmlCheckVersion instead of using the macro
3431 LIBXML_TEST_VERSION. Call libxml2 functions via the fn_* macros.
3432 (xml_cleanup_parser): New function, export for fn_xmlCleanupParser.
3433 Calls xmlCleanupParser only if libxml2 was loaded (or statically
3435 (Flibxml_parse_html_region, Flibxml_parse_xml_region):
3436 Call init_libxml2_functions before calling libxml2 functions.
3437 (syms_of_xml) <Qlibxml2_dll>: DEFSYM it.
3439 * emacs.c: Don't include libxml/parser.h.
3440 (shut_down_emacs): Call xml_cleanup_parser, instead of calling
3441 xmlCleanupParser directly.
3443 * lisp.h [HAVE_LIBXML2]: Add prototype for xml_cleanup_parser.
3445 2012-04-07 Eli Zaretskii <eliz@gnu.org>
3447 * indent.c (Fvertical_motion): If there is a display string at
3448 point, use it.vpos to compute how many lines to backtrack after
3449 move_it_to point. (Bug#11133)
3451 2012-04-06 Eli Zaretskii <eliz@gnu.org>
3453 * buffer.h (FETCH_CHAR, FETCH_MULTIBYTE_CHAR):
3454 * character.h (STRING_CHAR, STRING_CHAR_AND_LENGTH): Add comments
3455 about subtle differences between FETCH_CHAR* and STRING_CHAR*
3456 macros related to unification of CJK characters. For the details,
3457 see the discussion following the message here:
3458 http://debbugs.gnu.org/cgi/bugreport.cgi?bug=11073#14.
3460 2012-04-04 Chong Yidong <cyd@gnu.org>
3462 * keyboard.c (Vdelayed_warnings_list): Doc fix.
3464 2012-04-01 Eli Zaretskii <eliz@gnu.org>
3466 * w32menu.c (simple_dialog_show, add_menu_item): Use SAFE_ALLOCA
3467 instead of alloca. (Bug#11138)
3469 2012-04-01 Andreas Schwab <schwab@linux-m68k.org>
3471 * w32menu.c (is_simple_dialog): Properly check lisp types.
3474 2012-03-31 Eli Zaretskii <eliz@gnu.org>
3476 * xdisp.c (move_it_by_lines): When DVPOS is positive, and the
3477 position we get to after a call to move_it_to fails the
3478 IS_POS_VALID_AFTER_MOVE_P test, move to the next buffer position
3479 only if we wind up in a string from display property. (Bug#11063)
3481 * window.c (Fdelete_other_windows_internal): Invalidate the row
3482 and column information about mouse highlight, so that redisplay
3483 restores it after reallocating the glyph matrices. (Bug#7464)
3485 * xdisp.c (set_cursor_from_row): If `cursor' property on a display
3486 string comes from a `display' text property, use the buffer
3487 position of that property as if we actually saw that position in
3489 (move_it_by_lines): Remove the assertion that
3490 "it->current_x == 0 && it->hpos == 0" which can be legitimately
3491 violated when there's a before-string at the beginning of a line.
3494 2012-03-30 Eli Zaretskii <eliz@gnu.org>
3496 * xdisp.c (append_space_for_newline): If the default face was
3497 remapped, use the remapped face for the appended newline.
3498 (extend_face_to_end_of_line): Use the remapped default face for
3499 extending the face to the end of the line.
3500 (display_line): Call extend_face_to_end_of_line when the default
3501 face was remapped. (Bug#11068)
3503 2012-03-29 Eli Zaretskii <eliz@gnu.org>
3505 * s/ms-w32.h: Discourage from defining HAVE_GETCWD.
3507 2012-03-28 Stefan Monnier <monnier@iro.umontreal.ca>
3509 * keyboard.c (safe_run_hooks_error): Don't unquote strings.
3511 2012-03-27 Glenn Morris <rgm@gnu.org>
3513 * search.c (Fword_search_backward_lax, Fword_search_forward_lax):
3516 2012-03-26 Kenichi Handa <handa@m17n.org>
3518 * dispextern.h (struct glyph): Fix previous change. Change the
3519 bit length of glyphless.ch to 25 (Bug#11082).
3521 2012-03-26 Chong Yidong <cyd@gnu.org>
3523 * keyboard.c (Vselection_inhibit_update_commands): New variable.
3524 (command_loop_1): Use it; inhibit selection update for
3525 handle-select-window too (Bug#8996).
3527 2012-03-25 Fabrice Popineau <fabrice.popineau@supelec.fr>
3529 * w32heap.c (_heap_init, _heap_term): Remove dead MSVC-specific code.
3531 2012-03-25 Kenichi Handa <handa@m17n.org>
3533 * dispextern.h (struct glyph): Change the bit length of
3534 glyphless.ch to 22 to make the member glyphless fit in 32 bits.
3536 2012-03-24 Eli Zaretskii <eliz@gnu.org>
3538 * s/ms-w32.h (tzname): Include time.h before redirecting to
3539 _tzname. Fixes the MSVC build. (Bug#9960)
3541 2012-03-24 Andreas Schwab <schwab@linux-m68k.org>
3543 * xdisp.c (produce_glyphless_glyph): Limit length of acronym to 6
3546 * xterm.c (XTread_socket): Only modify handling_signal if
3547 !SYNC_INPUT. (Bug#11080)
3549 2012-03-23 Eli Zaretskii <eliz@gnu.org>
3551 * bidi.c (bidi_fetch_char): Use STRING_CHAR_AND_LENGTH instead of
3552 FETCH_MULTIBYTE_CHAR followed by CHAR_BYTES. Prevents crashes
3553 when fetching a multibyte character consumes more bytes than
3554 CHAR_BYTES returns, due to unification of CJK characters in
3555 string_char. (Bug#11073)
3557 2012-03-23 Troels Nielsen <bn.troels@gmail.com> (tiny change)
3559 * process.c (wait_reading_process_output): Handle pty disconnect
3560 by refraining from sending oneself a SIGCHLD (bug#10933).
3562 2012-03-22 Chong Yidong <cyd@gnu.org>
3564 * dispextern.h (struct it): New member string_from_prefix_prop_p.
3566 * xdisp.c (push_prefix_prop): Rename from push_display_prop.
3567 Mark string as coming from a prefix property.
3568 (handle_face_prop): Use default face for prefix strings (Bug#4281).
3569 (pop_it, reseat_1): Save and restore string_from_prefix_prop_p.
3571 2012-03-21 Chong Yidong <cyd@gnu.org>
3573 * xfaces.c (Vface_remapping_alist): Doc fix.
3575 2012-03-20 Eli Zaretskii <eliz@gnu.org>
3577 * w32proc.c (Fw32_set_console_codepage)
3578 (Fw32_set_console_output_codepage, Fw32_get_codepage_charset):
3581 2012-03-20 Chong Yidong <cyd@gnu.org>
3583 * dispnew.c (Fredisplay, Vredisplay_preemption_period): Update doc
3584 to reflect default non-nil value of redisplay-dont-pause.
3586 2012-03-19 Kenichi Handa <handa@m17n.org>
3588 * ftfont.c (ftfont_drive_otf): Mask bits of character code to make
3589 it fit in a valid range (Bug#11003).
3591 2012-03-18 Eli Zaretskii <eliz@gnu.org>
3593 * xdisp.c (cursor_row_p): Even if the glyph row ends in a string
3594 that is not from display property, accept the row as a "cursor
3595 row" if one of the string's character has a non-nil `cursor'
3596 property. Fixes cursor positioning when there are newlines in
3597 overlay strings, e.g. in icomplete.el. (Bug#11035)
3599 2012-03-12 Paul Eggert <eggert@cs.ucla.edu>
3601 * buffer.c (compare_overlays): Don't assume args differ (Bug#6830).
3603 2012-03-12 Chong Yidong <cyd@gnu.org>
3605 * eval.c (inhibit_lisp_code): Rename from
3606 inhibit_window_configuration_change_hook; move from window.c.
3608 * xfns.c (unwind_create_frame_1, Fx_create_frame):
3609 * window.c (run_window_configuration_change_hook)
3610 (syms_of_window): Callers changed.
3612 2012-03-11 Chong Yidong <cyd@gnu.org>
3614 * keymap.c (Fkey_description): Doc fix (Bug#9700).
3616 * editfns.c (Fconstrain_to_field): Doc fix (Bug#9452).
3618 2012-03-10 Chong Yidong <cyd@gnu.org>
3620 * frame.c (other_visible_frames): Don't assume the selected frame
3621 is visible (Bug#10955).
3623 2012-03-09 Stefan Monnier <monnier@iro.umontreal.ca>
3625 * buffer.c (compare_overlays): Avoid qsort's instability (bug#6830).
3627 2012-03-08 Jan Djärv <jan.h.d@swipnet.se>
3629 * gtkutil.c (x_wm_set_size_hint): Use one row in call to
3630 FRAME_TEXT_LINES_TO_PIXEL_HEIGHT so base_height is greater than
3633 2012-03-03 Glenn Morris <rgm@gnu.org>
3635 * alloc.c (Fgarbage_collect, misc-objects-consed): Doc fixes.
3637 2012-03-02 Eli Zaretskii <eliz@gnu.org>
3639 * xdisp.c (try_window_reusing_current_matrix): Don't move cursor
3640 position past the first glyph_row that ends at ZV. (Bug#10902)
3641 (redisplay_window, next_element_from_string): Fix typos in
3643 (redisplay_window): Pass to move_it_vertically the margin in
3644 pixels, not in screen lines.
3646 2012-03-02 Glenn Morris <rgm@gnu.org>
3648 * buffer.c (buffer-list-update-hook): Doc fix.
3650 2012-02-29 Eli Zaretskii <eliz@gnu.org>
3652 * xdisp.c (get_overlay_strings_1): Under bidi redisplay, call
3653 push_it before setting up the iterator for the first overlay
3654 string, even if we have an empty string loaded.
3655 (next_overlay_string): If there's an empty string on the iterator
3656 stack, pop the stack. (Bug#10903)
3658 2012-02-25 Paul Eggert <eggert@cs.ucla.edu>
3660 Generalize fix for crash due to non-contiguous EMACS_INT (Bug#10780).
3661 Suggested by Stefan Monnier in
3662 <http://lists.gnu.org/archive/html/emacs-devel/2012-02/msg00692.html>.
3663 * alloc.c (widen_to_Lisp_Object): New static function.
3664 (mark_memory): Also mark Lisp_Objects by fetching pointer words
3665 and widening them to Lisp_Objects. This would work even if
3666 USE_LSB_TAG is defined and wide integers are used, which might
3667 happen in a future version of Emacs.
3669 2012-02-25 Chong Yidong <cyd@gnu.org>
3671 * fileio.c (Ffile_selinux_context, Fset_file_selinux_context):
3674 * xselect.c (Fx_selection_exists_p): Doc fix.
3675 (x_clipboard_manager_save_all): Print an informative message
3676 before saving to clipboard manager.
3678 2012-02-24 Chong Yidong <cyd@gnu.org>
3680 * keyboard.c (process_special_events): Handle all X selection
3681 requests in kbd_buffer, not just the next one (Bug#8869).
3683 2012-02-23 Chong Yidong <cyd@gnu.org>
3685 * xfns.c (Fx_create_frame): Avoid window-configuration-change-hook
3686 call when setting menu-bar-lines and tool-bar-lines parameters.
3687 (unwind_create_frame_1): New helper function.
3689 * window.c (inhibit_window_configuration_change_hook): New var.
3690 (run_window_configuration_change_hook): Obey it.
3691 (syms_of_window): Initialize it.
3693 2012-02-22 Chong Yidong <cyd@gnu.org>
3695 * xterm.c (x_draw_image_relief): Add missing type check for
3696 Vtool_bar_button_margin (Bug#10743).
3698 2012-02-21 Chong Yidong <cyd@gnu.org>
3700 * fileio.c (Vfile_name_handler_alist): Doc fix.
3702 * buffer.c (Fget_file_buffer): Protect against invalid file
3703 handler return value.
3705 2012-02-20 Paul Eggert <eggert@cs.ucla.edu>
3707 * .gdbinit (xreload): Don't assume EMACS_INT fits in 'long'
3708 when computing $valmask.
3710 Fix crash due to non-contiguous EMACS_INT (Bug#10780).
3711 * lisp.h (VALBITS): Move definition up, so that USE_LSB_TAG can use it.
3712 (USE_LSB_TAG): Do not define if UINTPTR_MAX >> VALBITS == 0.
3713 It's useless in that case, and it can cause problems on hosts
3714 that allocate halves of EMACS_INT values separately.
3715 Reported by Dan Horák. Diagnosed by Andreas Schwab in
3716 <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=10780#30>.
3717 * mem-limits.h (EXCEEDS_LISP_PTR): Define to 0 on hosts where
3718 UINTPTR_MAX >> VALBITS == 0. This is required by the above change;
3719 it avoids undefined behavior on hosts where shifting right by more
3720 than the word width has undefined behavior.
3722 2012-02-19 Chong Yidong <cyd@gnu.org>
3724 * fileio.c (Ffile_name_directory, Ffile_name_nondirectory)
3725 (Funhandled_file_name_directory, Ffile_name_as_directory)
3726 (Fdirectory_file_name, Fexpand_file_name)
3727 (Fsubstitute_in_file_name): Protect against invalid file handler
3728 return values (Bug#10845).
3730 2012-02-18 Eli Zaretskii <eliz@gnu.org>
3732 * .gdbinit (pitx): Fix incorrect references to fields of the
3735 2012-02-17 Chong Yidong <cyd@gnu.org>
3737 * syntax.c (Fscan_lists): Doc fix (Bug#10833).
3739 2012-02-15 Paul Eggert <eggert@cs.ucla.edu>
3741 * image.c (MAX_IMAGE_SIZE): Increase from 6.0 to 10.0; see
3742 <http://lists.gnu.org/archive/html/emacs-devel/2012-02/msg00540.html>.
3744 2012-02-15 Chong Yidong <cyd@gnu.org>
3746 * eval.c (Fdefvar, Fdefconst): Doc fix; note that the variable is
3747 marked as special. Also, starting docstrings with * is obsolete.
3749 2012-02-13 Andreas Schwab <schwab@linux-m68k.org>
3751 * gnutls.c (emacs_gnutls_write): Fix last change.
3753 2012-02-13 Lars Ingebrigtsen <larsi@gnus.org>
3755 * gnutls.c (emacs_gnutls_write): Set errno appropriately for
3758 2012-02-13 Stefan Monnier <monnier@iro.umontreal.ca>
3760 * keymap.c (Fsingle_key_description): Handle char ranges.
3762 2012-02-12 Chong Yidong <cyd@gnu.org>
3764 * xdisp.c (handle_stop): Avoid assigning -1 to it->face_id here,
3765 as that creates a dangerous corner case.
3767 * window.c (Fdelete_window_internal): Invalidate the mouse
3768 highlight (Bug#9904).
3770 2012-02-12 Glenn Morris <rgm@gnu.org>
3772 * xselect.c (Fx_own_selection_internal)
3773 (Fx_get_selection_internal, Fx_disown_selection_internal)
3774 (Fx_selection_owner_p, Fx_selection_exists_p): Doc fixes.
3775 * nsselect.m (Fx_own_selection_internal)
3776 (Fx_disown_selection_internal, Fx_selection_exists_p)
3777 (Fx_selection_owner_p, Fx_get_selection_internal):
3778 Sync docs and argument specs with the xselect.c versions.
3780 2012-02-11 Lars Ingebrigtsen <larsi@gnus.org>
3782 * gnutls.c (emacs_gnutls_write): Don't infloop if sendto fails.
3784 2012-02-11 Eli Zaretskii <eliz@gnu.org>
3786 * w32select.c (Fx_selection_exists_p): Sync doc string and
3787 argument list with xselect.c. (Bug#10783)
3789 * w16select.c (Fx_selection_exists_p): Sync doc string and
3790 argument list with xselect.c. (Bug#10783)
3792 2012-02-10 Glenn Morris <rgm@gnu.org>
3794 * fns.c (Fsecure_hash): Doc fix.
3796 2012-02-09 Kenichi Handa <handa@m17n.org>
3798 * coding.c (produce_chars): Fix updating of src_end (Bug#10701).
3800 2012-02-07 Chong Yidong <cyd@gnu.org>
3802 * buffer.c (Fbuffer_local_variables)
3803 (buffer_lisp_local_variables): Handle unbound vars correctly;
3804 don't let Qunbound leak into Lisp.
3806 2012-02-07 Glenn Morris <rgm@gnu.org>
3808 * image.c (Fimagemagick_types): Doc fix.
3810 * image.c (imagemagick-render-type): Change it from a lisp object
3811 to an integer. Move the doc here from the lisp manual.
3812 Treat all values not equal to 0 the same.
3814 2012-02-06 Chong Yidong <cyd@gnu.org>
3816 * doc.c (store_function_docstring): Avoid applying docstring of
3817 alias to base function (Bug#2603).
3819 2012-02-04 Andreas Schwab <schwab@linux-m68k.org>
3821 * .gdbinit (pp1, pv1): Remove redundant defines.
3824 2012-02-04 Chong Yidong <cyd@gnu.org>
3826 * nsterm.m: Declare a global (Bug#10694).
3828 2012-02-04 Eli Zaretskii <eliz@gnu.org>
3830 * w32.c (get_emacs_configuration_options):
3831 Include --enable-checking, if specified, in the return value.
3833 2012-02-04 Martin Rudalics <rudalics@gmx.at>
3835 * dispnew.c (change_frame_size_1): Calculate new_frame_total_cols
3836 after rounding frame sizes. (Bug#9723)
3838 2012-02-04 Eli Zaretskii <eliz@gnu.org>
3840 * keyboard.c (adjust_point_for_property): Don't position point
3841 before BEGV. (Bug#10696)
3843 2012-02-03 Paul Eggert <eggert@cs.ucla.edu>
3845 Handle overflow when computing char display width (Bug#9496).
3846 * character.c (char_width): Return EMACS_INT, not int.
3847 (char_width, c_string_width): Check for overflow when
3848 computing the width; this is possible now that individual
3849 characters can have unbounded width. Problem introduced
3850 by merge from Emacs 23 on 2012-01-19.
3852 2012-02-02 Michael Albinus <michael.albinus@gmx.de>
3854 * dbusbind.c (Fdbus_register_method): Mention the return value
3855 :ignore in the docstring.
3857 2012-02-02 Glenn Morris <rgm@gnu.org>
3859 * callproc.c (Fcall_process, Fcall_process_region): Doc fix.
3861 * nsterm.m (syms_of_nsterm) <x-toolkit-scroll-bars>:
3862 Unconditionally set to t. (Bug#10673)
3863 * nsterm.m (syms_of_nsterm) <x-toolkit-scroll-bars>:
3864 * w32term.c (syms_of_w32term) <x-toolkit-scroll-bars>:
3865 * xterm.c (syms_of_xterm) <x-toolkit-scroll-bars>: Doc fix.
3867 2012-02-02 Kenichi Handa <handa@m17n.org>
3869 (x_produce_glyphs): Cancel previous change. If cmp->glyph_len is
3870 0, do not call append_composite_glyph.
3872 2012-02-02 Kenichi Handa <handa@m17n.org>
3874 * xdisp.c (BUILD_COMPOSITE_GLYPH_STRING): Initialize first_s to
3876 (x_produce_glyphs): If the component of a composition is a null
3877 string, set it->pixel_width to 1 to avoid zero-width glyph.
3879 2012-02-01 Eli Zaretskii <eliz@gnu.org>
3881 * ralloc.c (resize_bloc, r_alloc_sbrk): Don't call memmove if its
3882 first 2 arguments are identical. This makes inserting large
3883 output from a subprocess an order of magnitude faster on
3884 MS-Windows, where all sbrk'ed memory is always contiguous.
3886 2012-01-31 Glenn Morris <rgm@gnu.org>
3888 * nsterm.m (syms_of_nsterm) <x-toolkit-scroll-bars>:
3889 * w32term.c (syms_of_w32term) <x-toolkit-scroll-bars>:
3890 * xterm.c (syms_of_xterm) <x-toolkit-scroll-bars>: Sync docs.
3892 2012-01-29 Glenn Morris <rgm@gnu.org>
3894 * gnutls.c (syms_of_gnutls): More doc (from etc/NEWS).
3896 2012-01-28 Samuel Thibault <sthibault@debian.org> (tiny change)
3898 * s/gnu.h: Define POSIX_SIGNALS (Bug#10552).
3900 2012-01-28 Chong Yidong <cyd@gnu.org>
3902 * minibuf.c (syms_of_minibuf): Doc fix (Bug#10550).
3904 2012-01-26 Chong Yidong <cyd@gnu.org>
3906 * keyboard.c (Vecho_keystrokes): Document zero value (Bug#10503).
3908 * search.c (Fsearch_forward, Fsearch_backward): Document negative
3909 repeat counts (Bug#10507).
3911 2012-01-26 Glenn Morris <rgm@gnu.org>
3913 * lread.c (syms_of_lread): Doc fix.
3915 2012-01-25 HIROSHI OOTA <nil@mad.dog.cx> (tiny change)
3917 * coding.c (encode_designation_at_bol): Change return value to
3920 2012-01-25 Chong Yidong <cyd@gnu.org>
3922 * eval.c (Fuser_variable_p): Doc fix; mention custom-variable-p.
3924 2012-01-21 Chong Yidong <cyd@gnu.org>
3926 * floatfns.c (Fcopysign): Make the second argument non-optional,
3927 since nil is not allowed anyway.
3929 2012-01-21 Andreas Schwab <schwab@linux-m68k.org>
3931 * process.c (read_process_output): Use p instead of XPROCESS (proc).
3932 (send_process): Likewise.
3934 2012-01-19 Martin Rudalics <rudalics@gmx.at>
3936 * window.c (save_window_save, Fcurrent_window_configuration)
3937 (Vwindow_persistent_parameters): Do not use Qstate.
3938 Rewrite doc-strings.
3940 2012-01-19 Kenichi Handa <handa@m17n.org>
3942 * character.c (char_width): New function.
3943 (Fchar_width, c_string_width, lisp_string_width):
3944 Use char_width (Bug#9496).
3946 2012-01-16 Martin Rudalics <rudalics@gmx.at>
3948 * window.c (Vwindow_persistent_parameters): New variable.
3949 (Fset_window_configuration, save_window_save): Handle persistent
3952 2012-01-14 Eli Zaretskii <eliz@gnu.org>
3954 * w32fns.c (signal_user_input): Don't do a QUIT, to avoid
3955 thrashing the stack of the thread. (Bug#9087)
3957 2012-01-12 Paul Eggert <eggert@cs.ucla.edu>
3959 * xdisp.c (rows_from_pos_range): Add parens as per gcc -Wparentheses.
3961 2012-01-11 Eli Zaretskii <eliz@gnu.org>
3963 * xdisp.c (rows_from_pos_range): Handle the case where the
3964 highlight ends on a newline. (Bug#10464)
3965 (mouse_face_from_buffer_pos): Fix off-by-one error in calculating
3966 he end column for display of highlight that ends on a newline
3969 2012-01-11 Glenn Morris <rgm@gnu.org>
3971 * lread.c (init_lread): If no-site-lisp, remove site-lisp dirs
3972 from load-path also when installation-directory is nil. (Bug#10208)
3974 2012-01-10 Glenn Morris <rgm@gnu.org>
3976 * emacs.c (syms_of_emacs) <installation-directory>: Doc fix.
3978 * epaths.in (PATH_LOADSEARCH, PATH_EXEC, PATH_DATA, PATH_DOC):
3979 Update template values to be closer to their typical values these days.
3981 2012-01-09 Eli Zaretskii <eliz@gnu.org>
3983 * xdisp.c (rows_from_pos_range): Accept additional argument
3984 DISP_STRING, and accept any glyph in a row whose object is that
3985 string as eligible for mouse highlight. Fixes mouse highlight of
3986 display strings from overlays. (Bug#10464)
3988 2012-01-07 Paul Eggert <eggert@cs.ucla.edu>
3990 emacs: fix an auto-save permissions race condition (Bug#10400)
3991 * fileio.c (auto_saving_dir_umask): New static var.
3992 (Fmake_directory_internal): Use it.
3993 (do_auto_save_make_dir): Set it, instead of invoking chmod after
3994 creating the directory. The old code temporarily assigns
3995 too-generous permissions to the directory.
3996 (do_auto_save_eh): Clear it.
3997 (Fdo_auto_save): Catch all errors, not just file errors, so
3998 that the var is always cleared.
4000 2012-01-07 Eli Zaretskii <eliz@gnu.org>
4002 * search.c (scan_buffer): Pass character positions to
4003 know_region_cache, not byte positions. (Bug#6540)
4005 2012-01-07 LynX <_LynX@bk.ru> (tiny change)
4007 * w32.c (sys_rename): Report EXDEV when rename of a directory
4008 fails because the target is on another logical disk. (Bug#10284)
4010 2012-01-07 David Benjamin <davidben@mit.edu> (tiny change)
4012 * xterm.c (x_embed_request_focus): New function.
4014 * xterm.h: Add prototype.
4016 * xfns.c (Fx_focus_frame): Use it for embedded frames (Bug#9977).
4018 2012-01-05 Glenn Morris <rgm@gnu.org>
4020 * emacs.c (emacs_copyright): Update short copyright year to 2012.
4022 2012-01-01 Eli Zaretskii <eliz@gnu.org>
4024 * gnutls.c (init_gnutls_functions): Load gnutls_check_version.
4025 Load gnutls_transport_set_lowat only if GnuTLS version is below
4027 (emacs_gnutls_handshake): Call gnutls_transport_set_lowat only for
4028 GnuTLS versions below 2.11.1.
4030 2011-12-31 Antoine Levitt <antoine.levitt@gmail.com>
4032 * xdisp.c (syms_of_xdisp) <window-scroll-functions>: Add warning
4033 to the doc string advising against its use for altering the way
4034 windows are scrolled.
4036 2011-12-28 Kenichi Handa <handa@m17n.org>
4038 * coding.c (Fdefine_coding_system_internal): Make an utf-8 base
4039 coding-system ASCII compatible only when it does not produce BOM
4040 on encoding (Bug#10383).
4042 2011-12-26 Jan Djärv <jan.h.d@swipnet.se>
4044 * xmenu.c (x_menu_wait_for_event): Use xg_select for Gtk3 so menus
4046 (create_and_show_popup_menu): Always use menu_position_func for
4049 2011-12-24 Andreas Schwab <schwab@linux-m68k.org>
4051 * callint.c (Fcall_interactively): Don't truncate prompt string.
4053 2011-12-23 Eli Zaretskii <eliz@gnu.org>
4055 * xdisp.c (handle_invisible_prop): Handle correctly an invisible
4056 property that ends at ZV, so that the bidi iteration could be
4057 resumed from there (after widening). (Bug#10360)
4059 2011-12-22 Jan Djärv <jan.h.d@swipnet.se>
4061 * nsfont.m (ns_spec_to_descriptor): Do not autorelease fdesc.
4063 2011-12-21 Jan Djärv <jan.h.d@swipnet.se>
4065 * nsterm.m (x_free_frame_resources):
4066 Release f->output_data.ns->miniimage.
4067 (ns_index_color): Fix indentation. Do not retain
4068 color_table->colors[i].
4070 * nsmenu.m (ns_update_menubar): Call free_menubar_widget_value_tree
4073 * nsfns.m (x_set_background_color): Assign return value from
4074 ns_index_color to face-background instead of NSColor*.
4075 (ns_implicitly_set_icon_type): Fix indentation.
4076 Change assignment in for loop to comparison.
4078 * emacs.c (ns_pool): New variable.
4079 (main): Assign ns_pool.
4080 (Fkill_emacs): Call ns_release_autorelease_pool.
4082 * nsfont.m (ns_spec_to_descriptor): Fix indentation,
4083 autorelease fdesc, release fdAttrs and tdict.
4084 (ns_get_covering_families): Release charset.
4085 (ns_findfonts): Release NSFontDescriptor created with new.
4086 (ns_uni_to_glyphs): Fix indentation.
4087 (setString): Release attrStr before assigning new value.
4089 2011-12-18 Jan Djärv <jan.h.d@swipnet.se>
4091 * nsmenu.m (NSMenuDidBeginTrackingNotification): Declare if OSX < 10.5
4093 (trackingNotification): Surround with ifdef NS_IMPL_COCOA.
4094 (syms_of_nsmenu): Set trackingMenu to 1 if not NS_IMPL_COCOA.
4096 2011-12-18 David Reitter <reitter@cmu.edu>
4098 * nsterm.m (ns_term_init): Subscribe for notifications
4099 NSMenuDidBeginTrackingNotification and NSMenuDidEndTrackingNotification
4100 to method trackingNotification in EmacsMenu.
4102 * nsmenu.m (trackingMenu): New variable.
4103 (trackingNotification): New method (from Aquamacs).
4104 (menuNeedsUpdate): Expand comment and return if trackingMenu is 0,
4105 from Aquamacs (Bug#7030).
4107 2011-12-18 Jan Djärv <jan.h.d@swipnet.se>
4109 * nsselect.m (CUT_BUFFER_SUPPORT): Remove define.
4110 (symbol_to_nsstring): Fix indentation.
4111 (ns_symbol_to_pb): New function.
4112 (Fns_get_selection_internal): Rename from Fns_get_cut_buffer_internal.
4113 (Fns_rotate_cut_buffers_internal): Remove.
4114 (Fns_store_selection_internal): Rename from
4115 Fns_store_cut_buffer_internal.
4116 (ns_get_foreign_selection, Fx_own_selection_internal)
4117 (Fx_disown_selection_internal, Fx_selection_exists_p)
4118 (Fns_get_selection_internal, Fns_store_selection_internal):
4119 Use ns_symbol_to_pb and check if return value is nil.
4120 (syms_of_nsselect): Remove ifdef CUT_BUFFER_SUPPORT. Remove defsubr
4121 Sns_rotate_cut_buffers_internal. Sns_get_cut_buffer_internal
4122 renamed to Sns_get_selection_internal, Sns_store_cut_buffer_internal
4123 renamed to Sns_store_selection_internal.
4124 (ns_handle_selection_request): Move code to Fx_own_selection_internal
4125 and remove this function.
4126 (ns_handle_selection_clear): Remove, never used.
4127 (Fx_own_selection_internal): Move code from ns_handle_selection_request
4130 2011-12-17 Ken Brown <kbrown@cornell.edu>
4132 * fileio.c (check_writable) [CYGWIN]: Return non-zero if UID or
4133 GID is unknown (Bug#10257).
4135 2011-12-17 Paul Eggert <eggert@cs.ucla.edu>
4137 * s/gnu-linux.h: Fix mark_memory typo (Bug#10286).
4138 (GC_MARK_SECONDARY_STACK): Omit removed 3rd arg to mark_memory,
4139 which caused a build failure on GNU/Linux IA-64. This problem was
4140 introduced by my 2011-10-07 patch.
4142 2011-12-15 Juri Linkov <juri@jurta.org>
4144 * image.c (imagemagick_error): New function. (Bug#10112)
4145 (imagemagick_load_image): Comment out `MagickSetResolution' call.
4146 Use `imagemagick_error' where ImageMagick functions return
4148 (Fimagemagick_types): Add `Fnreverse' to return the list in the
4151 2011-12-15 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
4153 * xftfont.c (xftfont_draw): Use the font metrics of s->font to
4154 fill background (Bug#8992).
4156 2011-12-13 Martin Rudalics <rudalics@gmx.at>
4158 * window.c (Vwindow_combination_resize)
4159 (Vwindow_combination_limit): Use t instead of non-nil in
4161 (Vrecenter_redisplay): Add first sentence of doc-string on
4163 (Frecenter): Fix doc-string typo.
4165 2011-12-11 Kenichi Handa <handa@m17n.org>
4167 * coding.c (Funencodable_char_position): Pay attention to the
4168 buffer text relocation (Bug#9389).
4170 2011-12-10 Jan Djärv <jan.h.d@swipnet.se>
4172 * xterm.c (x_term_init): Move call to gdk_window_add_filter before
4173 gtk_init (Bug#10100).
4175 2011-12-10 Eli Zaretskii <eliz@gnu.org>
4177 * xdisp.c (RECORD_MAX_MIN_POS): Use IT->cmp_it.charpos only if
4178 IT->string is nil. (Bug#10263)
4180 2011-12-10 Jan Djärv <jan.h.d@swipnet.se>
4182 * nsterm.h (x_free_frame_resources): Declare.
4184 * nsfns.m (ns_get_defaults_value): New function (Bug#10103).
4185 (Fns_get_resource, x_get_string_resource): Call ns_get_defaults_value.
4187 * nsterm.h (ns_get_defaults_value): Declare.
4189 * nsterm.m (ns_default): Call ns_get_defaults_value.
4191 2011-12-09 Eli Zaretskii <eliz@gnu.org>
4193 * xdisp.c (try_scrolling): Don't set scroll_down_p if dy is zero.
4196 2011-12-09 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
4198 * unexelf.c (unexec) [NS_IMPL_GNUSTEP]: Take account of the case
4199 that where the value of an _OBJC_* symbol points to is in the .bss
4200 section (Bug#10240).
4202 2011-12-08 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny change)
4204 * coding.c (encode_coding_ccl): Check (charbuf < charbuf_end)
4205 after the loop to call ccl_driver at least once (Bug#8619).
4207 2011-12-08 Kenichi Handa <handa@m17n.org>
4209 * ftfont.c (get_adstyle_property): Fix previous change
4212 2011-12-07 Juanma Barranquero <lekktu@gmail.com>
4214 * w32.c (init_environment): If no_site_lisp, remove site-lisp
4215 dirs from the default value of EMACSLOADPATH (bug#10208).
4217 2011-12-07 Glenn Morris <rgm@gnu.org>
4219 * lread.c (init_lread): If no_site_lisp, exclude site-lisp/ in
4220 installation and source directories as well. (Bug#10208)
4222 2011-12-06 Chong Yidong <cyd@gnu.org>
4224 * minibuf.c (Fread_from_minibuffer): Doc fix (Bug#10228).
4226 2011-12-06 Glenn Morris <rgm@gnu.org>
4228 * process.c (start_process_unwind): Treat any pid <= 0, except -2,
4229 as an error, not just -1. (Bug#10217)
4231 2011-12-05 Chong Yidong <cyd@gnu.org>
4233 * keyboard.c (process_special_events): New function.
4234 (swallow_events, Finput_pending_p): Use it (Bug#10195).
4236 2011-12-05 Paul Eggert <eggert@cs.ucla.edu>
4238 * coding.c (encode_designation_at_bol): Don't use uninitialized
4239 local variable (Bug#9318).
4241 2011-12-05 Kenichi Handa <handa@m17n.org>
4243 * ftfont.c (get_adstyle_property): If the font is not BDF nor PCF,
4244 return Qnil (Bug#8046, Bug#10193).
4246 2011-12-05 Kenichi Handa <handa@m17n.org>
4248 * coding.c (encode_designation_at_bol): New args charbuf_end and
4249 dst. Return the number of produced bytes. Callers changed.
4250 (coding_set_source): Return how many bytes coding->source was
4252 (coding_set_destination): Return how many bytes
4253 coding->destination was relocated.
4254 (CODING_DECODE_CHAR, CODING_ENCODE_CHAR, CODING_CHAR_CHARSET)
4255 (CODING_CHAR_CHARSET_P): Adjust for the avove changes.
4257 2011-12-05 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny change)
4259 * coding.c (CODING_CHAR_CHARSET_P): New macro.
4260 (encode_coding_emacs_mule, encode_coding_iso_2022): Use the above
4263 2011-12-05 Andreas Schwab <schwab@linux-m68k.org>
4265 The following changes are to fix Bug#9318.
4267 * coding.c (CODING_ENCODE_CHAR, CODING_CHAR_CHARSET): New macros.
4268 (encode_coding_emacs_mule, ENCODE_ISO_CHARACTER)
4269 (encode_coding_iso_2022, encode_coding_sjis)
4270 (encode_coding_big5, encode_coding_charset): Use the above macros.
4272 2011-12-05 Juanma Barranquero <lekktu@gmail.com>
4274 * lisp.h (process_quit_flag): Fix external declaration.
4276 2011-12-04 Stefan Monnier <monnier@iro.umontreal.ca>
4278 Don't macro-inline non-performance-critical code.
4279 * eval.c (process_quit_flag): New function.
4280 * lisp.h (QUIT): Use it.
4282 2011-12-04 Jan Djärv <jan.h.d@swipnet.se>
4284 * nsfns.m (get_geometry_from_preferences): New function.
4285 (Fx_create_frame): Call get_geometry_from_preferences (Bug#10103).
4287 2011-12-04 Andreas Schwab <schwab@linux-m68k.org>
4289 * emacs.c (Qkill_emacs): Define.
4290 (syms_of_emacs): Initialize it.
4291 * keyboard.c (interrupt_signal): Don't call Fkill_emacs here, set
4292 Qquit_flag to `kill-emacs' instead.
4293 (quit_throw_to_read_char): Add parameter `from_signal'.
4294 All callers changed. Call Fkill_emacs if requested and safe.
4295 * lisp.h (QUIT): Call Fkill_emacs if requested.
4297 2011-12-03 Jan Djärv <jan.h.d@swipnet.se>
4299 * widget.c (update_wm_hints): Return if wmshell is null.
4300 (widget_update_wm_size_hints): New function.
4302 * widget.h (widget_update_wm_size_hints): Declare.
4304 * xterm.c (x_wm_set_size_hint): If USE_X_TOOLKIT, call
4305 widget_update_wm_size_hints (Bug#10104).
4307 2011-12-03 Eli Zaretskii <eliz@gnu.org>
4309 * xdisp.c (handle_invisible_prop): If the invisible text ends just
4310 before a newline, prepare the bidi iterator for consuming the
4311 newline, and keep the current paragraph direction. (Bug#10183)
4312 (redisplay_window): Don't let `margin' become negative. (Bug#10192)
4314 2011-12-02 Juri Linkov <juri@jurta.org>
4316 * search.c (Fword_search_regexp): New Lisp function created from
4317 `wordify'. Change type of arg `lax' from `int' to `Lisp_Object'.
4318 (Fword_search_backward, Fword_search_forward)
4319 (Fword_search_backward_lax, Fword_search_forward_lax):
4320 Use `Fword_search_regexp' instead of `wordify'. Doc fix.
4321 (syms_of_search): Define `Sword_search_regexp'. (Bug#10145)
4323 2011-12-01 Stefan Monnier <monnier@iro.umontreal.ca>
4325 * fileio.c (Finsert_file_contents): Move after-change-function call
4326 to before the "handled:" label, since all "goto handled" appear in
4327 cases where the *-change-functions have already been properly called
4330 2011-12-01 Andreas Schwab <schwab@linux-m68k.org>
4332 * keyboard.c (interrupt_signal): Don't call kill-emacs when
4333 waiting for input. (Bug#10169)
4335 2011-11-30 Eli Zaretskii <eliz@gnu.org>
4337 * dispnew.c (adjust_glyph_matrix): Remove the assertion that
4338 verifies glyph row's hash code--we have just reallocated the
4339 glyphs, so their contents can be complete garbage. (Bug#10164)
4341 2011-11-30 Juanma Barranquero <lekktu@gmail.com>
4343 * dispnew.c (adjust_glyph_matrix) [XASSERTS]: Add missing check.
4345 2011-11-30 Eli Zaretskii <eliz@gnu.org>
4347 * dispnew.c (adjust_glyph_matrix) [XASSERTS]: Ensure ROW's
4348 attributes are tested _before_ calling verify_row_hash, to protect
4349 against GCC re-ordering of the tests. (Bug#10164)
4351 2011-11-29 Jan Djärv <jan.h.d@swipnet.se>
4353 * xterm.h (struct x_output): net_wm_state_hidden_seen is new.
4355 * xterm.c (handle_one_xevent): Only set async_visible and friends
4356 if net_wm_state_hidden_seen is non-zero (Bug#10002)
4357 (get_current_wm_state): Set net_wm_state_hidden_seen to 1 if
4358 _NET_WM_STATE_HIDDEN is in NET_WM_STATE.
4360 2011-11-28 Paul Eggert <eggert@cs.ucla.edu>
4362 Remove GCPRO-related macros that exist only to avoid shadowing locals.
4363 * lisp.h (GCPRO1_VAR, GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR, GCPRO5_VAR)
4364 (GCPRO6_VAR, UNGCPRO_VAR): Remove. See
4365 <http://lists.gnu.org/archive/html/emacs-diffs/2011-11/msg00265.html>.
4366 All uses changed to use GCPRO1 etc.
4367 (GCPRO1, GCPRO2, GCPRO3, GCPRO4, GCPRO5, GCPRO6, UNGCPRO):
4368 Revert to old implementation (i.e., before 2011-03-11).
4370 2011-11-28 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
4372 * dispnew.c (scrolling_window): Truncate overlaps in copy destination
4373 of scroll runs so as to avoid assigning disabled bogus rows and
4374 unnecessary graphics copy operations.
4376 2011-11-27 Eli Zaretskii <eliz@gnu.org>
4378 * s/ms-w32.h (utimbuf) [_MSC_VER]: Don't define.
4379 (snprintf) [_MSC_VER]: Redirect to _snprintf.
4380 (strtoll) [_MSC_VER]: Redirect to _strtoi64.
4381 (malloc, free, realloc, calloc): Redirect to e_* only when
4384 * lisp.h (GCTYPEBITS): Move before first use.
4385 (ALIGN_GCTYPEBITS) [_MSC_VER]: Define.
4386 (DECL_ALIGN) [_MSC_VER]: Use it, as MSVC doesn't like bit ops in
4387 this macro definition.
4389 * s/ms-w32.h (tzname): Redirect to _tzname for all values of
4392 2011-11-27 Jan Djärv <jan.h.d@swipnet.se>
4394 * gtkutil.c (xg_create_frame_widgets):
4395 Call gtk_window_set_has_resize_grip (FALSE) if that function is
4396 present with Gtk+ 2.0.
4398 2011-11-26 Paul Eggert <eggert@cs.ucla.edu>
4400 * fileio.c (Finsert_file_contents): Undo previous change; see
4401 <http://lists.gnu.org/archive/html/emacs-diffs/2011-11/msg00265.html>.
4403 2011-11-26 Paul Eggert <eggert@cs.ucla.edu>
4405 Rename locals to avoid shadowing.
4406 * fileio.c (Finsert_file_contents):
4407 Rename inner 'gcpro1' to 'inner_gcpro1' to avoid shadowing.
4408 * process.c (wait_reading_process_output):
4409 Rename inner 'proc' to 'p' to avoid shadowing.
4410 Indent for consistency with usual Emacs style.
4412 2011-11-25 Eli Zaretskii <eliz@gnu.org>
4414 * xdisp.c (redisplay_window): If cursor row is not fully visible
4415 after recentering, and scroll-conservatively is set to a large
4416 number, scroll window by a few more lines to make the cursor fully
4417 visible and out of scroll-margin. (Bug#10105)
4418 (start_display): Don't move to the next line if the display should
4419 start at a newline that is part of a display vector or an overlay
4422 2011-11-24 Juri Linkov <juri@jurta.org>
4424 * image.c (imagemagick_load_image): Move `MagickSetResolution' down
4425 after the `MagickPingImage' call. (Bug#10112)
4427 2011-11-23 Chong Yidong <cyd@gnu.org>
4429 * window.c (Fcoordinates_in_window_p): Accept only live windows.
4431 2011-11-23 Martin Rudalics <rudalics@gmx.at>
4433 * buffer.c (Fkill_buffer): Run replace_buffer_in_windows before
4434 making another buffer current. (Bug#10114)
4436 2011-11-23 Glenn Morris <rgm@gnu.org>
4438 * font.c (font_find_for_lface) [HAVE_NS]: Ignore case. (Bug#2526)
4440 2011-11-23 Chong Yidong <cyd@gnu.org>
4442 * xdisp.c (compute_stop_pos): Check validity of end_charpos before
4443 using it (Bug#5984).
4445 2011-11-22 Eli Zaretskii <eliz@gnu.org>
4447 * dispnew.c (adjust_glyph_matrix): Don't verify hash code of mode-
4448 and header-lines, as they don't have one computed for them.
4451 * .gdbinit (prow): Make displayed values more self-explaining.
4452 Add row's hash code.
4454 2011-11-21 Lars Magne Ingebrigtsen <larsi@gnus.org>
4456 * process.c (wait_reading_process_output): Fix asynchrounous
4457 GnuTLS socket handling on some versions of the GnuTLS library.
4458 (wait_reading_process_output): Add comment and URL.
4460 2011-11-21 Jan Djärv <jan.h.d@swipnet.se>
4462 * xterm.c (x_clear_frame): Reinstate the XClearWindow call.
4464 2011-11-21 Chong Yidong <cyd@gnu.org>
4466 * window.c (Fnext_window, Fprevious_window): Doc fix.
4468 2011-11-20 Stefan Monnier <monnier@iro.umontreal.ca>
4470 * window.c (get_phys_cursor_glyph): Fix Lisp_Object/int mixup.
4472 2011-11-20 Juanma Barranquero <lekktu@gmail.com>
4474 * nsfont.m (syms_of_nsfont) <ns-reg-to-script>: Fix typo.
4476 2011-11-20 Martin Rudalics <rudalics@gmx.at>
4478 * window.c (Fset_window_combination_limit): Rename argument
4480 (Vwindow_combination_limit): Remove "status" from doc-string.
4482 2011-11-20 Andreas Schwab <schwab@linux-m68k.org>
4484 * m/ibms390.h: Remove.
4485 * m/ibms390x.h: Don't include "ibms390.h".
4487 2011-11-20 Stefan Monnier <monnier@iro.umontreal.ca>
4489 * fileio.c (Finsert_file_contents): Add missing gcpro1 variable.
4490 Suggested by Dmitry Antipov <dmantipov@yandex.ru>.
4492 2011-11-20 Juanma Barranquero <lekktu@gmail.com>
4494 * casetab.c (Fset_case_table):
4495 * charset.c (Fcharset_after): Fix typos.
4497 2011-11-20 Paul Eggert <eggert@cs.ucla.edu>
4499 Standardize on VIRT_ADDR_VARIES behavior (Bug#10042).
4500 Otherwise, valgrind does not work on some platforms.
4501 Problem reported by Andreas Schwab in
4502 <http://lists.gnu.org/archive/html/emacs-devel/2011-11/msg00081.html>.
4503 * puresize.h (pure, PURE_P): Always behave as if VIRT_ADDR_VARIES
4504 is set, removing the need for VIRT_ADDRESS_VARIES.
4505 (PURE_P): Use a more-efficient implementation that needs just one
4506 comparison, not two: on x86-64 with GCC 4.6.2, this cut down the
4507 number of instructions from 6 (xorl, cmpq, jge, xorl, cmpq, setge)
4508 to 4 (xorl, subq, cmpq, setbe).
4509 * alloc.c (pure): Always extern now, since that's the
4510 VIRT_ADDR_VARIES behavior.
4511 (PURE_POINTER_P): Use a single comparison, not two, for
4512 consistency with the new puresize.h.
4513 * lisp.h (PNTR_COMPARISON_TYPE): Remove; no longer needed.
4514 * m/ibms390.h, m/intel386.h, m/template.h, s/cygwin.h, s/hpux10-20.h:
4515 Remove VIRT_ADDR_VARIES no longer needed.
4517 2011-11-19 Eli Zaretskii <eliz@gnu.org>
4519 * xdisp.c (x_write_glyphs, draw_phys_cursor_glyph)
4520 (erase_phys_cursor, update_window_cursor, show_mouse_face)
4521 (cursor_in_mouse_face_p): If the cursor position is out of bounds,
4522 behave as if the cursor position were at the window margin.
4524 * window.c (get_phys_cursor_glyph): If the window is hscrolled,
4525 and the cursor position is out of bounds, behave as if the cursor
4526 position were at the window margin. (Bug#10075)
4528 2011-11-18 Chong Yidong <cyd@gnu.org>
4530 * window.c (Fwindow_combination_limit): Make first argument
4531 non-optional, since it is meaningless for live windows like the
4534 2011-11-18 Dmitry Antipov <dmantipov@yandex.ru>
4536 * keymap.c (Fwhere_is_internal): Add missing RETURN_UNGCPROs.
4538 2011-11-18 Stefan Monnier <monnier@iro.umontreal.ca>
4540 * intervals.c: Fix grafting over the whole buffer (bug#10071).
4541 (graft_intervals_into_buffer): Simplify.
4543 2011-11-18 Eli Zaretskii <eliz@gnu.org>
4545 * dispnew.c (swap_glyph_pointers): Swap the used[] arrays and the
4546 hash values of the two rows.
4547 (copy_row_except_pointers): Preserve the used[] arrays and the
4548 hash values of the two rows. (Bug#10035)
4549 (add_row_entry): Add xassert to verify that ROW's hash code is valid.
4551 * xdisp.c (row_hash): New function, body extracted from
4552 compute_line_metrics.
4553 (compute_line_metrics): Call row_hash, instead of computing the
4556 * dispnew.c (verify_row_hash): Call row_hash for computing the
4557 hash code of a row, instead of duplicating code from xdisp.c.
4559 * dispextern.h (row_hash): Add prototype.
4561 2011-11-18 Tassilo Horn <tassilo@member.fsf.org>
4563 * frame.c (delete_frame): Don't delete the terminal when the last
4564 X frame is closed if emacs is built with GTK toolkit.
4566 2011-11-17 Juanma Barranquero <lekktu@gmail.com>
4568 * window.c (syms_of_window) <window-combination-resize>: Fix typo.
4570 2011-11-17 Martin Rudalics <rudalics@gmx.at>
4572 * window.c (Vwindow_splits): Rename to
4573 Vwindow_combination_resize. Suggested by Juri Linkov.
4574 (Fsplit_window_internal): Use Vwindow_combination_resize instead
4577 2011-11-16 Juanma Barranquero <lekktu@gmail.com>
4579 * nsfns.m (Fns_font_name):
4580 * window.c (syms_of_window) <window-combination-limit>: Fix typos.
4582 2011-11-16 Martin Rudalics <rudalics@gmx.at>
4584 * window.h (window): Rename slot "nest" to "combination_limit".
4585 * window.c (Fwindow_nest): Rename to Fwindow_combination_limit.
4586 (Fset_window_nest): Rename to Fset_window_combination_limit.
4587 (Vwindow_nest): Rename to Vwindow_combination_limit.
4588 (recombine_windows, make_parent_window, make_window)
4589 (Fsplit_window_internal, saved_window)
4590 (Fset_window_configuration, save_window_save): Rename all
4591 occurrences of window_nest to window_combination_limit.
4593 2011-11-15 Juanma Barranquero <lekktu@gmail.com>
4595 * image.c (imagemagick_load_image): Fix typo.
4597 2011-11-14 Eli Zaretskii <eliz@gnu.org>
4599 * xdisp.c (display_line): Move the call to
4600 highlight_trailing_whitespace before the call to
4601 compute_line_metrics, since the latter needs to see the final
4602 faces of all the glyphs to compute ROW's hash value.
4603 Fixes assertion violations in row_equal_p. (Bug#10035)
4605 2011-11-14 Juanma Barranquero <lekktu@gmail.com>
4607 * w32proc.c (reader_thread): Don't check pending input if cp->fd < 0,
4608 just return (bug#10044).
4610 2011-11-12 Eli Zaretskii <eliz@gnu.org>
4612 * makefile.w32-in (HEAPSIZE): New variable, allows to build temacs
4613 with user-defined heap size. Bump the default size of the temacs
4614 heap to 27MB, to avoid memory warning when running temacs.
4615 ($(TEMACS)): Use HEAPSIZE instead of a hardcoded value.
4617 * dispnew.c (scrolling_window): Fix incorrect indices in accessing
4618 current_matrix and desired_matrix. (Bug#9990)
4619 (verify_row_hash) [XASSERTS]: New function.
4620 (adjust_glyph_matrix, row_equal_p): Use it in xassert to verify
4621 that the hash value of glyph rows is correct.
4623 2011-11-12 Martin Rudalics <rudalics@gmx.at>
4625 * window.h (window): Remove splits slot.
4626 * window.c (Fwindow_splits, Fset_window_splits): Remove.
4627 (Fdelete_other_windows_internal, make_parent_window)
4628 (make_window, Fsplit_window_internal, Fdelete_window_internal)
4629 (Fset_window_configuration, save_window_save): Don't deal with
4630 split status of windows.
4631 (saved_window): Remove splits slot.
4632 (Vwindow_splits): Rewrite doc-string.
4634 2011-11-11 Jan Djärv <jan.h.d@swipnet.se>
4636 * xfns.c (unwind_create_frame):
4637 * nsfns.m (unwind_create_frame):
4638 * w32fns.c (unwind_create_frame): Use Fmemq to check if frame is in
4639 Vframe_list (Bug#9999).
4641 2011-11-11 Dmitry Antipov <dmantipov@yandex.ru>
4643 * xdisp.c (syms_of_xdisp): Remove duplicated definition of Qtext.
4645 2011-11-11 Kenichi Handa <handa@m17n.org>
4647 * callproc.c (Fcall_process): Set the member dst_multibyte of
4650 2011-11-11 Johan Bockgård <bojohan@gnu.org>
4652 * xdisp.c (fill_composite_glyph_string): Always set s->face, to
4653 avoid a crash (bug#9496).
4655 2011-11-09 Chong Yidong <cyd@gnu.org>
4657 * window.c (Fwindow_inside_edges, Fwindow_inside_pixel_edges)
4658 (Fwindow_inside_absolute_pixel_edges): Only allow live windows.
4660 2011-11-08 Paul Eggert <eggert@cs.ucla.edu>
4662 * s/gnu.h (GC_MARK_STACK): Define to GC_MAKE_GCPROS_NOOPS (Bug#9926).
4664 2011-11-08 Paul Eggert <eggert@cs.ucla.edu>
4666 Avoid some portability problems by eschewing 'extern inline' functions.
4667 The trivial performance wins aren't worth the portability hassles; see
4668 <http://lists.gnu.org/archive/html/emacs-devel/2011-11/msg00084.html>
4670 * dispextern.h (window_box, window_box_height, window_text_bottom_y)
4671 (window_box_width, window_box_left, window_box_left_offset)
4672 (window_box_right, window_box_right_offset): Undo previous change,
4673 by removing the "extern"s.
4674 * intervals.c (adjust_intervals_for_insertion)
4675 (adjust_intervals_for_deletion): Undo previous change,
4676 making these static again.
4677 (offset_intervals, temp_set_point_both, temp_set_point)
4678 (copy_intervals_to_string): No longer inline.
4679 * xdisp.c (window_text_bottom_y, window_box_width)
4680 (window_box_height, window_box_left_offset)
4681 (window_box_right_offset, window_box_left, window_box_right)
4682 (window_box): No longer inline.
4684 2011-11-08 Chong Yidong <cyd@gnu.org>
4686 * window.c (Fwindow_left_column, Fwindow_top_line): Doc fix.
4687 (Fwindow_body_height, Fwindow_body_width): Move from Lisp.
4688 Signal an error if not a live window.
4689 (Fwindow_total_width, Fwindow_total_height): Move from Lisp.
4690 (Fwindow_total_size, Fwindow_body_size): Move to Lisp.
4692 2011-11-07 Juanma Barranquero <lekktu@gmail.com>
4694 * lisp.h (syms_of_abbrev): Remove declaration.
4695 Reported by CHENG Gao <chenggao@royau.me>.
4697 2011-11-07 Eli Zaretskii <eliz@gnu.org>
4699 * w32.c (check_windows_init_file): Don't look for term/w32-win.el
4700 if Vpurify_flag is non-nil. Fixes a crash when running w32 build
4701 of temacs in GUI mode.
4703 2011-11-07 Martin Rudalics <rudalics@gmx.at>
4705 * window.h: Declare delete_all_child_windows instead of
4706 delete_all_subwindows.
4707 * window.c (Fwindow_nest, Fset_window_nest)
4708 (Fset_window_new_total, Fset_window_new_normal)
4709 (Fwindow_resize_apply): Don't use term subwindow in doc-strings.
4710 (delete_all_subwindows): Rename to delete_all_child_windows.
4711 (Fdelete_other_windows_internal, Fset_window_configuration):
4712 Call delete_all_child_windows instead of delete_all_subwindows.
4713 * frame.c (delete_frame): Call delete_all_child_windows instead
4714 of delete_all_subwindows.
4716 2011-11-07 Paul Eggert <eggert@cs.ucla.edu>
4718 * alloc.c (DEADP): New macro, for porting to GNU/Hurd (Bug#9926).
4719 This is also needed for porting to any host where GC_MARK_STACK is
4720 not GC_MAKE_GCPROS_NOOPS.
4721 (which_symbols): Use it.
4723 2011-11-07 Kenichi Handa <handa@m17n.org>
4725 * coding.c (coding_set_destination): Check coding->src_pos only
4726 when coding->src_object is a buffer (bug#9910).
4728 * process.c (send_process): Set the member src_multibyte of coding
4729 to 0 (bug#9911) when sending a unibyte text.
4731 * callproc.c (Fcall_process): Set the member src_multibyte of
4732 process_coding to 0 (bug#9912).
4734 2011-11-06 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
4736 * xmenu.c (cleanup_widget_value_tree): New function.
4737 (xmenu_show, xdialog_show): Use it in record_unwind_protect instead of
4738 calling free_menubar_widget_value_tree directly (Bug#9830).
4740 2011-11-06 Paul Eggert <eggert@cs.ucla.edu>
4742 Fix some portability problems with 'inline'.
4743 * dispextern.h (window_box, window_box_height, window_text_bottom_y)
4744 (window_box_width, window_box_left, window_box_left_offset)
4745 (window_box_right, window_box_right_offset): Declare extern.
4746 Otherwise, these inline functions do not conform to C99 and
4747 are miscompiled by Microsoft compilers. Reported by Eli Zaretskii in
4748 <http://lists.gnu.org/archive/html/emacs-devel/2011-11/msg00084.html>.
4749 * intervals.c (adjust_intervals_for_insertion)
4750 (adjust_intervals_for_deletion): Now extern, because otherwise the
4751 extern inline functions 'offset_intervals' couldn't refer to it.
4752 (static_offset_intervals): Remove.
4753 (offset_intervals): Rewrite using the old contents of
4754 static_offset_intervals. The old version didn't conform to C99
4755 because an extern inline function contained a reference to an
4756 identifier with static linkage.
4758 2011-11-06 Andreas Schwab <schwab@linux-m68k.org>
4760 * keyboard.c (interrupt_signal): Don't call kill-emacs while in
4763 2011-11-06 Eli Zaretskii <eliz@gnu.org>
4765 * xdisp.c (init_iterator, reseat_to_string): Don't set the
4766 iterator's bidi_p flag if Vpurify_flag is non-nil. (Bug#9963)
4767 (Fcurrent_bidi_paragraph_direction): If Vpurify_flag is non-nil,
4768 return Qleft_to_right.
4770 2011-11-06 Chong Yidong <cyd@gnu.org>
4772 * window.c (Fwindow_live_p, Fwindow_frame, Fframe_root_window)
4773 (Fminibuffer_window, Fwindow_buffer, Fwindow_splits)
4774 (Fset_window_splits, Fwindow_nest, Fset_window_nest)
4775 (Fwindow_use_time, Fwindow_total_size, Fwindow_normal_size)
4776 (Fwindow_new_normal, Fwindow_left_column, Fwindow_top_line)
4777 (Fwindow_margins, Fwindow_fringes, Fwindow_scroll_bars)
4778 (Fwindow_vscroll): Doc fix.
4779 (Fwindow_top_child, Fwindow_left_child): Eliminate a nil default
4780 argument, since it makes no sense to pass a live window and for
4781 consistency with window-child.
4783 2011-11-05 Christoph Scholtes <cschol2112@googlemail.com>
4785 * makefile.w32-in ($(TEMACS), (gl-stamp)): Use $(THISDIR) to
4788 2011-11-05 Jason Rumney <jasonr@gnu.org>
4790 * w32font.c (font_matches_spec): Filter out non-Japanese kana fonts.
4791 (add_font_entity_to_list): Filter out non-Japanese Shift-JIS
4793 (add_font_entity_to_list): Fix logic errors in mixed boolean and
4794 bitwise arithmetic preventing use of unicode-sip and non-truetype
4797 2011-11-05 Eli Zaretskii <eliz@gnu.org>
4799 * s/ms-w32.h (fstat, stat, utime): Move redirections to
4802 * w32fns.c (x_create_tip_frame, Fx_create_frame): Rearrange
4803 initialization code to keep similarity to xfns.c after changes
4806 2011-11-05 Jan Djärv <jan.h.d@swipnet.se>
4808 * nsfns.m: Declare image_cache_refcount if GLYPH_DEBUG.
4809 (unwind_create_frame): New function (Bug#9943).
4810 (Fx_create_frame): Restructure code to be more similar to the one in
4811 xfns.c. Call record_unwind_protect with unwind_create_frame (Bug#9943).
4812 Initialize image_cache_refcount if GLYPH_DEBUG (Bug#9943).
4813 Move terminal->reference_count++ just before making the frame official
4816 * nsterm.m (x_free_frame_resources): New function.
4817 (x_destroy_window): Move code to x_free_frame_resources.
4819 * xfns.c (unwind_create_frame): Fix comment.
4820 (Fx_create_frame, x_create_tip_frame):
4821 Move terminal->reference_count++ just before making the frame
4822 official. Move initialization of image_cache_refcount and
4823 dpyinfo_refcount before calling init_frame_faces (Bug#9943).
4825 2011-11-05 Eli Zaretskii <eliz@gnu.org>
4827 Support MSVC build with newer versions of Visual Studio.
4828 * makefile.w32-in (TAGS-gmake): Don't use $(patsubst ...), as
4829 Nmake barfs on that. Use $(OBJ*_c) variables instead, defined on
4832 * lisp.h (ENUM_BF): New macro, for enumerated types in bitfields,
4833 which are not supported by MSVC.
4834 (Lisp_Symbol, Lisp_Misc_Any, Lisp_Marker, Lisp_Misc_Overlay)
4835 (Lisp_Save_Value, Lisp_Free): Use ENUM_BF for enumerated types in
4837 (Lisp_Object) [USE_LISP_UNION_TYPE]: Use ENUM_BF for enumerated
4839 (DEFUN) [_MSC_VER]: Define in a different way for MSVC.
4841 * w32fns.c [_MSC_VER]: DECLARE_HANDLE for any MSVC version.
4843 2011-11-05 Fabrice Popineau <fabrice.popineau@supelec.fr> (tiny change)
4845 Support MSVC build with newer versions of Visual Studio.
4846 * w32.c: Don't include w32api.h for MSVC.
4847 (init_environment) [_MSC_VER]: Call sys_access, not _access.
4849 * s/ms-w32.h <sigset_t, ssize_t> [_MSC_VER]: Typedefs for MSVC.
4850 [_MSC_VER]: Include sys/timeb.h, sys/stat.h, and signal.h.
4851 (fstat, stat, utime) [_MSC_VER]: Redirect to their sys_* cousins.
4852 (malloc, free, realloc, calloc) [_MSC_VER]: Always redirect to the
4854 (alloca) [_MSC_VER]: Define to _alloca.
4856 * lisp.h (DECL_ALIGN) [_MSC_VER]: Define for MSVC.
4858 * regex.c <re_char> [_MSC_VER]: A separate definition for MSVC.
4860 2011-11-04 Eli Zaretskii <eliz@gnu.org>
4862 * xdisp.c (note_mouse_highlight): If either of
4863 previous/next-single-property-change returns nil, treat that as
4864 the beginning or the end of the buffer. (Bug#9955)
4866 2011-11-04 Jan Djärv <jan.h.d@swipnet.se>
4868 * gtkutil.c (xg_make_tool_item): Add callbacks if one of wimage or
4869 label is not null (Bug#9951).
4870 (xg_tool_item_stale_p): Handle the fact that wimage and/or wlbl
4873 2011-11-04 Eli Zaretskii <eliz@gnu.org>
4875 * window.c (Fwindow_body_size): Mention in the doc string that the
4876 return value is in frame's canonical units. (Bug#9949)
4878 2011-11-03 Eli Zaretskii <eliz@gnu.org>
4880 * xdisp.c (note_mouse_highlight): Initialize `area'. (Bug#9947)
4882 * w32fns.c (unwind_create_frame): If needed, free the glyph
4883 matrices of the partially constructed frame. (Bug#9943)
4884 * xfns.c (unwind_create_frame): Likewise.
4886 2011-11-01 Eli Zaretskii <eliz@gnu.org>
4888 * xdisp.c (mouse_face_from_buffer_pos): Fix a typo in a comment.
4889 Don't stop backward scan on the continuation glyph, even though
4890 its CHARPOS is positive.
4891 (mouse_face_from_buffer_pos, note_mouse_highlight):
4892 Rename cover_string to disp_string.
4894 2011-11-01 Martin Rudalics <rudalics@gmx.at>
4896 * window.c (temp_output_buffer_show): Don't use
4897 Vtemp_buffer_show_specifiers.
4898 (Vtemp_buffer_show_specifiers): Remove unused variable.
4900 2011-10-30 Eli Zaretskii <eliz@gnu.org>
4902 * xdisp.c (try_cursor_movement): Make sure ROW isn't decremented
4903 past the beginning of the current glyph matrix.
4905 2011-10-30 Adam Sjøgren <asjo@koldfront.dk> (tiny change)
4907 * xterm.c: Include X11/Xproto.h if HAVE_GTK3.
4908 (x_error_handler): Ignore BadMatch for X_SetInputFocus for
4909 HAVE_GTK3 (Bug#9869).
4911 * gtkutil.c (xg_win_to_widget, xg_event_is_for_menubar): Initialize
4912 type to GDK_NOTHING so valgrind does not complain (Bug#9901).
4914 * xterm.h (x_display_info): Add Xatom_net_wm_state_hidden (Bug#9893).
4916 * xterm.c: Declare x_handle_net_wm_state to return int.
4917 (handle_one_xevent): Check if we are iconified but don't have
4918 _NET_WM_STATE_HIDDEN. If do, treat as deiconify (Bug#9893).
4919 (get_current_wm_state): Return non-zero if not hidden,
4920 check for _NET_WM_STATE_HIDDEN (Bug#9893).
4921 (do_ewmh_fullscreen): Ignore return value from get_current_wm_state.
4922 (x_handle_net_wm_state): Return what get_current_wm_state returns.
4923 (x_term_init): Initialize dpyinfo->Xatom_net_wm_state_hidden.
4925 2011-10-29 Paul Eggert <eggert@cs.ucla.edu>
4927 * alloc.c (which_symbols): Declare EXTERNALLY_VISIBLE,
4928 so that this new function doesn't get optimized away by a
4929 whole-program optimizer. Make the 2nd arg EMACS_INT, not int.
4931 2011-10-29 Andreas Schwab <schwab@linux-m68k.org>
4933 * frame.h (MOUSE_HL_INFO): Remove excess parens.
4935 2011-10-29 Eli Zaretskii <eliz@gnu.org>
4937 Fix the `xbytecode' command.
4938 * .gdbinit (xprintbytestr): New command.
4939 (xwhichsymbols): Rename from `which'; all callers changed.
4940 (xbytecode): Print the byte-code string as well.
4942 2011-10-29 Kim Storm <storm@cua.dk>
4944 * alloc.c (which_symbols): New function.
4946 2011-10-29 Andreas Schwab <schwab@linux-m68k.org>
4948 * minibuf.c (read_minibuf_noninteractive): Allow reading empty
4951 2011-10-29 Glenn Morris <rgm@gnu.org>
4953 * process.c (wait_reading_process_output): Revert 2009-08-30 change.
4954 Not clear what it was for, and it causes various bugs. (Bug#9839)
4956 2011-10-28 Eli Zaretskii <eliz@gnu.org>
4958 * xdisp.c (note_mouse_highlight): Initialize `part', to avoid a
4959 possible random value that matches one of those tested as
4960 condition to clear the mouse face.
4962 2011-10-28 Chong Yidong <cyd@gnu.org>
4964 * xdisp.c (note_mouse_highlight): Fix use of uninitialized var.
4966 2011-10-28 Dan Nicolaescu <dann@ics.uci.edu>
4968 * window.c (make_window): Initialize phys_cursor_on_p.
4970 2011-10-28 Stefan Monnier <monnier@iro.umontreal.ca>
4972 * lisp.h (struct Lisp_Symbol): Update comments.
4974 2011-10-28 Juanma Barranquero <lekktu@gmail.com>
4976 * w32font.c (w32_load_unicows_or_gdi32): Add missing return.
4978 2011-10-28 Eli Zaretskii <eliz@gnu.org>
4980 Fix Emacs on Windows 9X (bug#8562). Thanks to oslsachem
4981 <oslsachem@gmail.com> for helping to debug this.
4983 * w32font.c (g_b_init_is_w9x, g_b_init_get_outline_metrics_w)
4984 (g_b_init_get_text_metrics_w, g_b_init_get_glyph_outline_w)
4985 (g_b_init_get_glyph_outline_w): New static variables.
4986 (GetOutlineTextMetricsW_Proc, GetTextMetricsW_Proc)
4987 (GetGlyphOutlineW_Proc): New typedefs.
4988 (w32_load_unicows_or_gdi32, get_outline_metrics_w)
4989 (get_text_metrics_w, get_glyph_outline_w, globals_of_w32font):
4991 (w32font_open_internal, compute_metrics):
4992 Call get_outline_metrics_w, get_text_metrics_w, and get_glyph_outline_w
4993 instead of calling the "wide" APIs directly.
4995 * emacs.c (main) [HAVE_NTGUI]: Call globals_of_w32font.
4997 * w32.h (syms_of_w32font): Add prototype.
4999 2011-10-27 Juanma Barranquero <lekktu@gmail.com>
5001 * window.c (Fframe_root_window, Fframe_first_window, Fwindow_end)
5002 (Fframe_selected_window, Ftemp_output_buffer_show, Fnext_window)
5003 (Fdelete_window_internal, Fwindow_parameters): Fix typos in docstrings.
5004 (Fmove_to_window_line): Doc fix.
5006 2011-10-27 Chong Yidong <cyd@gnu.org>
5008 * process.c (make_process): Set gnutls_state to NULL.
5010 * gnutls.c (emacs_gnutls_deinit): Deinit the gnutls_state if it is
5011 non-NULL, regardless of GNUTLS_INITSTAGE.
5012 (Fgnutls_boot): Cleanups. Call emacs_gnutls_deinit if we signal
5013 an error. Set process slots as soon as we allocate them.
5015 * gnutls.h (GNUTLS_LOG, GNUTLS_LOG2): Fix macros.
5017 2011-10-27 Chong Yidong <cyd@gnu.org>
5019 * gnutls.c (emacs_gnutls_deinit): New function.
5020 Deallocate credentials structures as well as calling gnutls_deinit.
5021 (Fgnutls_deinit, Fgnutls_boot): Use it.
5023 * process.c (make_process): Initialize GnuTLS credentials to NULL.
5024 (deactivate_process): Call emacs_gnutls_deinit.
5026 2011-10-27 Juanma Barranquero <lekktu@gmail.com>
5028 * image.c (x_create_x_image_and_pixmap):
5029 * w32.c (sys_rename, w32_delayed_load):
5030 * w32font.c (fill_in_logfont):
5031 * w32reg.c (x_get_string_resource): Silence compiler warnings.
5033 2011-10-26 Juanma Barranquero <lekktu@gmail.com>
5035 * w32fns.c (w32_default_color_map): New function,
5036 extracted from Fw32_default_color_map.
5037 (Fw32_default_color_map, Fx_open_connection): Use it. (Bug#9785)
5039 2011-10-25 Paul Eggert <eggert@cs.ucla.edu>
5041 * dispextern.h (Fcontrolling_tty_p): New decl (Bug#6649 part 2).
5043 2011-10-25 Stefan Monnier <monnier@iro.umontreal.ca>
5045 * keyboard.c (test_undefined): New function (bug#9751).
5046 (read_key_sequence): Use it to detect when a key is bound to `undefined'.
5048 2011-10-25 Enami Tsugutomo <tsugutomo.enami@jp.sony.com>
5050 * sysdep.c (init_sys_modes): Fix the check for the controlling
5051 terminal (Bug#6649).
5053 2011-10-20 Eli Zaretskii <eliz@gnu.org>
5055 * dispextern.h (struct bidi_it): New member next_en_type.
5057 * bidi.c (bidi_line_init): Initialize the next_en_type member.
5058 (bidi_resolve_explicit_1): When next_en_pos is valid for the
5059 current character, check also for next_en_type being WEAK_EN.
5060 (bidi_resolve_weak): Don't enter the expensive loop if the current
5061 position is before next_en_pos. Record the bidi type of the first
5062 non-ET, non-BN character we find, in addition to its position.
5063 (bidi_level_of_next_char): Invalidate next_en_type when
5064 next_en_pos is over-stepped.
5066 2011-10-20 Paul Eggert <eggert@cs.ucla.edu>
5068 Time zone name fixes for non-ASCII locales (Bug#641, Bug#9794)
5069 * editfns.c: Rewrite current-time-zone so that it invokes
5070 the equivalent of (format-time-string "%Z") to get the time zone name.
5071 This fixes a bug when the time zone name contains characters that
5072 need converting from the system time locale to Emacs internal format.
5073 This fixes a shortcoming that I introduced in my 1999-10-19 patch:
5074 that patch fixed format-time-string to do the conversion, but
5075 I forgot to fix current-time-zone.
5076 (format_time_string): New function, containing most of
5077 what Fformat_time_string used to contain.
5078 (Fformat_time_string): Rewrite in terms of format_time_string.
5079 This doesn't change this function's behavior.
5080 (current-time-zone): Rewrite to use format_time_string.
5081 This fixes the bug reported by Michael Schierl in
5082 <http://lists.gnu.org/archive/html/emacs-devel/2007-06/msg00334.html>.
5083 Jason Rumney's 2007-06-07 change worked around this bug, but
5085 * systime.h (tzname, timezone): Remove no-longer-used declarations.
5087 2011-10-19 Eli Zaretskii <eliz@gnu.org>
5089 * xdisp.c (start_display): If the character at POS is displayed
5090 via a display vector, reset IT->current.dpvec_index to zero.
5091 (try_window_reusing_current_matrix): If a line ends in a display
5092 vector or the next line starts in a display vector, continue
5093 redrawing the window even though the character position of
5094 start_row was reached.
5097 2011-10-18 Chong Yidong <cyd@gnu.org>
5099 * xdisp.c (get_next_display_element): Handle U+2010 and U+2011
5100 with nobreak-char-display too.
5102 2011-10-18 Eli Zaretskii <eliz@gnu.org>
5104 Fix part 3 of bug#9771.
5105 * bidi.c (bidi_line_init): Initialize next_en_pos to zero, not -1.
5106 (bidi_resolve_neutral): Don't enter the expensive loop looking for
5107 non-neutral characters if the current character is a paragraph
5108 separator (a.k.a. Newline). This avoids running the same
5109 expensive loop twice, once when we consume the preceding newline
5110 and the other time when the line actually needs to be displayed.
5111 Avoid the loop when we see neutrals on the base embedding level
5112 following a character whose directionality is the same as the
5113 paragraph's. This avoids running the expensive loop when a line
5114 ends in a long sequence of neutrals, like control characters.
5115 Add assertion against STRONG_AL type. Slightly rearrange code
5116 that determines the type of a neutral given the first non-neutral
5118 (bidi_level_of_next_char): Set next_en_pos to zero when
5119 invalidating its info.
5121 2011-10-17 Eli Zaretskii <eliz@gnu.org>
5123 * xdisp.c (push_display_prop): Determine whether to record string
5124 or buffer position by IT->string, not by IT->method. Allow
5125 GET_FROM_DISPLAY_VECTOR as IT->method on entry. (Bug#9771, part 4)
5126 (move_it_vertically_backward): Don't look for character position
5127 immediately after the newline when in a continuation line.
5130 2011-10-15 Martin Rudalics <rudalics@gmx.at>
5132 * window.c (coordinates_in_window): Rewrite and delabelize
5133 vertical border check. (Bug#5357) (Bug#9618)
5135 2011-10-14 Stefan Monnier <monnier@iro.umontreal.ca>
5137 * xterm.c (frame_highlight, frame_unhighlight): Ignore unexplained
5138 errors in XSetWindowBorder (bug#9310).
5140 2011-10-13 Dmitry Antipov <dmantipov@yandex.ru>
5142 * editfns.c (Fset_time_zone_rule): Replace free with xfree to
5143 avoid crash when xmalloc overrun checking is enabled.
5145 2011-10-13 Eli Zaretskii <eliz@gnu.org>
5147 * xdisp.c (Fcurrent_bidi_paragraph_direction): Initialize
5148 itb.paragraph_dir to NEUTRAL_DIR. Fixes an occasional incorrect
5149 cursor motion with <left> and <right> arrow keys.
5151 * bidi.c (bidi_init_it): Don't initialize paragraph_dir here, as
5152 some callers set that themselves.
5154 2011-10-12 Eli Zaretskii <eliz@gnu.org>
5156 * xdisp.c (find_row_edges): Handle the case where ROW comes from a
5157 display string and the previous row comes from the same string and
5158 is empty. (Bug#9739) (Bug#9738)
5160 2011-10-12 Stefan Monnier <monnier@iro.umontreal.ca>
5162 * doc.c (get_doc_string): Encode file name (bug#9735).
5164 2011-10-12 Eli Zaretskii <eliz@gnu.org>
5166 * bidi.c (bidi_level_of_next_char):
5167 * xdisp.c (get_visually_first_element): Remove old incorrect
5168 comments regarding the Unicode Line Separator character.
5170 * bidi.c (bidi_init_it): Initialize paragraph_dir to NEUTRAL_DIR.
5172 2011-10-12 Dmitry Antipov <dmantipov@yandex.ru>
5174 * alloc.c (Fgc_status): Do not access beyond zombies array
5175 boundary if nzombies > MAX_ZOMBIES.
5176 * alloc.c (dump_zombies): Add missing format specifier.
5178 2011-10-12 Paul Eggert <eggert@cs.ucla.edu>
5180 * xdisp.c (set_cursor_from_row): Simplify conditionals,
5181 to pacify GCC 4.6.1 x86-64 with -O2 -Wstrict-overflow.
5183 * lread.c (read_escape): Allow hex escapes as large as ?\xfffffff.
5184 Some packages use them to denote characters with modifiers.
5186 2011-10-11 Andreas Schwab <schwab@linux-m68k.org>
5188 * lisp.h (GCPRO1_VAR, GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR)
5189 (GCPRO5_VAR, GCPRO6_VAR, UNGCPRO_VAR): Add whitespace to avoid
5190 matching a pp-number. Rename parameter var to var1.
5192 2011-10-11 Stefan Monnier <monnier@iro.umontreal.ca>
5194 * minibuf.c (Finternal_complete_buffer): Fix last change (bug#9709).
5196 2011-10-08 Glenn Morris <rgm@gnu.org>
5198 * callint.c (Fcall_interactively): Give a more explicit error for the
5199 'c' case with a non-character input. (Bug#8479)
5201 2011-10-08 Eli Zaretskii <eliz@gnu.org>
5203 * xdisp.c (hscroll_window_tree): Support hscroll in right-to-left
5205 (set_cursor_from_row): Fix cursor positioning in mixed L2R+R2L
5206 lines that are hscrolled on the left.
5208 * dispnew.c (buffer_posn_from_coords): Account for a possible
5209 presence of header-line. (Bug#4426)
5211 2011-10-07 Stefan Monnier <monnier@iro.umontreal.ca>
5213 * buffer.c (syms_of_buffer) <enable-multibyte-characters>:
5214 Don't advertise functionality which we discourage or doesn't work.
5216 2011-10-07 Paul Eggert <eggert@cs.ucla.edu>
5218 * alloc.c (GC_LISP_OBJECT_ALIGNMENT): Use offsetof, not __alignof__
5219 or sizeof. __alignof__ gives the wrong answer on Fedora x86-64
5220 with GCC 4.6.1 when configured with CC='gcc -m32' --with-wide-int;
5221 this makes Emacs dump core during garbage collection on rare
5222 occasions. sizeof is obviously inferior to offsetof here, so
5223 stick with offsetof.
5224 (GC_POINTER_ALIGNMENT): New macro.
5225 (mark_memory): Omit 3rd (offset) arg; caller changed.
5226 Don't assume EMACS_INT alignment is the same as pointer alignment.
5228 2011-10-03 Stefan Monnier <monnier@iro.umontreal.ca>
5230 * keyboard.c (read_key_sequence_remapped): New var.
5231 (read_key_sequence): Compute remapping in the right buffer.
5232 (command_loop_1): Use read_key_sequence's remapping directly.
5234 2011-10-02 Stefan Monnier <monnier@iro.umontreal.ca>
5236 * dired.c (file_name_completion): Don't expand file name.
5237 (Ffile_name_completion, Ffile_name_all_completions): Expand file name
5238 before checking file name handler.
5240 * minibuf.c (Finternal_complete_buffer): Only show internal buffers if
5241 they've been requested explicitly (bug#9591).
5243 2011-10-01 Andreas Schwab <schwab@linux-m68k.org>
5245 * keymap.c (Fsingle_key_description): Use make_specified_string
5246 instead of build_string to build string from push_key_description.
5249 2011-09-30 Paul Eggert <eggert@cs.ucla.edu>
5251 * buffer.h (struct buffer): Use time_t, not int, for a time stamp.
5252 This fixes a Y2038 bug on 64-bit hosts.
5253 * buffer.c (reset_buffer):
5254 * fileio.c (Fdo_auto_save, Fset_buffer_auto_saved)
5255 (Fclear_buffer_auto_save_failure):
5256 Use 0, not -1, to represent an unset failure time, since time_t
5257 might not be signed.
5259 Remove dependency on glibc malloc internals.
5260 * alloc.c (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
5261 Move back here from lisp.h, but with their new implementations.
5262 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
5263 (XMALLOC_OVERRUN_SIZE_SIZE): Move these new lisp.h macros here.
5264 * charset.c (charset_table_init): New static var.
5265 (syms_of_charset): Use it instead of xmalloc. This removes a
5266 dependency on glibc malloc internals. See Eli Zaretskii's comment in
5267 <http://lists.gnu.org/archive/html/emacs-devel/2011-09/msg00815.html>.
5268 * lisp.h (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
5269 Move back to alloc.c.
5270 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
5271 (XMALLOC_OVERRUN_SIZE_SIZE): Move to alloc.c.
5273 2011-09-30 Jan Djärv <jan.h.d@swipnet.se>
5275 * nsterm.m (windowDidResize): Call x_set_window_size only when
5276 ns_in_resize is true. Otherwise set pixelwidth/height and
5277 call change_frame_size (Bug#9628).
5279 2011-09-30 Paul Eggert <eggert@cs.ucla.edu>
5281 Port --enable-checking=all to Fedora 14 x86-64.
5282 * charset.c (syms_of_charset): Also account for glibc malloc's
5283 internal overhead when calculating the initial malloc maximum.
5285 Port --enable-checking=all to Fedora 14 x86.
5286 * alloc.c (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
5288 (xmalloc_put_size, xmalloc_get_size, overrun_check_malloc)
5289 (overrun_check_realloc, overrun_check_free):
5290 Use XMALLOC_OVERRUN_SIZE_SIZE, not sizeof (size_t).
5291 That way, xmalloc returns a properly-aligned pointer even if
5292 XMALLOC_OVERRUN_CHECK is defined. The old debugging code happened
5293 to align OK on typical 64-bit hosts, but not on Fedora 14 x86.
5294 * charset.c (syms_of_charset): Take XMALLOC_OVERRUN_CHECK_OVERHEAD
5295 into account when calculating the initial malloc maximum.
5296 * lisp.h (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
5297 Move here from alloc.c, so that charset.c can use it too.
5298 Properly align; the old code wasn't right for common 32-bit hosts
5299 when configured with --enable-checking=all.
5300 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
5301 (XMALLOC_OVERRUN_SIZE_SIZE): New macros.
5303 2011-09-29 Eli Zaretskii <eliz@gnu.org>
5305 * sysdep.c (snprintf) [!EOVERFLOW]: If EOVERFLOW is not defined,
5308 2011-09-28 Eli Zaretskii <eliz@gnu.org>
5310 * xdisp.c (compute_display_string_end): If there's no display
5311 string at CHARPOS, return -1.
5313 * bidi.c (bidi_fetch_char): When compute_display_string_end
5314 returns a negative value, treat the character as a normal
5315 character not covered by a display string. (Bug#9624)
5317 2011-09-28 Juanma Barranquero <lekktu@gmail.com>
5319 * lread.c (Fread_from_string): Fix typo in docstring.
5321 2011-09-27 Eli Zaretskii <eliz@gnu.org>
5323 * xdisp.c (handle_invisible_prop): If invisible text ends on a
5324 newline, reseat the iterator instead of bidi-iterating there one
5325 character at a time. (Bug#9610)
5326 (BUFFER_POS_REACHED_P, move_it_in_display_line_to): Bail when past
5327 TO_CHARPOS if the bidi iterator is at base embedding level.
5329 2011-09-27 Andreas Schwab <schwab@linux-m68k.org>
5331 * lread.c (readevalloop): Use correct code for NBSP.
5332 (read1): Likewise. (Bug#9608)
5334 2011-09-25 Michael Albinus <michael.albinus@gmx.de>
5336 * dbusbind.c (Fdbus_register_signal): When service is not
5337 registered, use nil in Vdbus_registered_objects_table. (Bug#9581)
5339 2011-09-25 Glenn Morris <rgm@gnu.org>
5341 * buffer.c (truncate-lines): Doc fix.
5343 2011-09-24 Chong Yidong <cyd@stupidchicken.com>
5345 * window.c (Fwindow_prev_buffers, Fset_window_prev_buffers)
5346 (Fset_window_next_buffers): Doc fix.
5348 2011-09-24 Glenn Morris <rgm@gnu.org>
5350 * minibuf.c (read_minibuf): Disable line truncation. (Bug#5715)
5352 2011-09-24 Paul Eggert <eggert@cs.ucla.edu>
5354 Fix minor problems found by static checking.
5355 * xdisp.c (string_from_display_spec): Don't assume vecsize fits in int.
5356 * indent.c (Fvertical_motion): Fix == vs = typo.
5358 2011-09-24 Eli Zaretskii <eliz@gnu.org>
5360 * dispnew.c (syms_of_display) <redisplay-dont-pause>:
5361 Default value is now t. Doc fix.
5363 * indent.c (Fvertical_motion): Compute and apply the overshoot
5364 logic when moving up, not only when moving down. Fix the
5365 confusing name and values of the it_overshoot_expected variable;
5366 logic changes accordingly. (Bug#9254) (Bug#9549)
5368 * xdisp.c (pos_visible_p): Produce correct pixel coordinates when
5369 CHARPOS is covered by a display string which includes newlines.
5370 (move_it_vertically_backward): Avoid inflooping when START_CHARPOS
5371 is covered by a display string with embedded newlines.
5373 2011-09-24 Michael Albinus <michael.albinus@gmx.de>
5375 * dbusbind.c (Fdbus_register_signal): Add match rule to
5376 Vdbus_registered_objects_table. (Bug#9581)
5377 (Fdbus_register_method, Vdbus_registered_objects_table):
5380 2011-09-24 Jim Meyering <meyering@redhat.com>
5382 do not ignore write error for any output size
5383 The previous change was incomplete.
5384 While it makes emacs --batch detect the vast majority of stdout
5385 write failures, errors were still ignored whenever the output size is
5386 k * (BUFSIZ+1) - 4. E.g., on a system with BUFSIZ of 4096,
5387 $ emacs --batch --eval '(print (format "%4093d" 0))' > /dev/full \
5388 && echo FAIL: ignored write error
5389 FAIL: ignored write error
5390 $ emacs --batch --eval '(print (format "%20481d" 0))' > /dev/full \
5391 && echo FAIL: ignored write error
5392 FAIL: ignored write error
5393 * emacs.c (Fkill_emacs): Also test ferror. (Bug#9574)
5395 2011-09-23 Andreas Schwab <schwab@linux-m68k.org>
5397 * emacs.c (Fkill_emacs): In noninteractive mode exit
5398 non-successfully if a write error occurred on stdout. (Bug#9574)
5400 2011-09-21 Eli Zaretskii <eliz@gnu.org>
5402 * xdisp.c (pop_it): Allow it->object that is a cons cell to pass
5405 * dispextern.h (struct it): Update the comment documenting what
5408 2011-09-20 Eli Zaretskii <eliz@gnu.org>
5410 * xdisp.c (set_cursor_from_row): If the row ends in a newline from
5411 a display string, extend search for cursor position to end of row.
5412 (find_row_edges): If the row ends in a newline from a display
5413 string, increment its MATRIX_ROW_END_CHARPOS by one. (Bug#9549)
5414 Handle the case of a display string with multiple newlines.
5415 (Fcurrent_bidi_paragraph_direction): Fix search for previous
5416 non-empty line. Fixes confusing cursor motion with arrow keys at
5417 the beginning of a line that starts with whitespace.
5419 2011-09-19 Lars Magne Ingebrigtsen <larsi@gnus.org>
5421 * lread.c (Fread_from_string): Document what FINAL-STRING-INDEX is
5424 2011-09-18 Chong Yidong <cyd@stupidchicken.com>
5426 * xfns.c (Fx_create_frame): Handle the bitmapIcon resource as
5429 2011-09-18 Eli Zaretskii <eliz@gnu.org>
5431 * xdisp.c (display_line): Record maximum and minimum buffer
5432 positions even if no glyphs were produced (e.g., by a zero-width
5433 stretch). Fixes bug#9530 on a TTY. Under word-wrap, don't record
5434 buffer positions that will be removed from the glyph row because
5436 (produce_stretch_glyph): Fix a bug in :align-to on a TTY when the
5437 column is beyond frame width: don't subtract 1 "pixel" when
5438 computing width of the stretch.
5439 (reseat_at_next_visible_line_start): Undo the change made on
5440 2011-09-17 that saved paragraph information and restored it after
5441 the call to `reseat'. (Bug#9545)
5443 2011-09-18 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
5445 * xdisp.c (expose_window): Save original value of phys_cursor_on_p
5446 and turn window cursor on if cleared (Bug#9415).
5448 2011-09-18 Andreas Schwab <schwab@linux-m68k.org>
5450 * search.c (boyer_moore): Take unibyte characters from pattern
5451 literally. (Bug#9458)
5453 2011-09-18 Eli Zaretskii <eliz@gnu.org>
5455 * xdisp.c (reseat_at_next_visible_line_start): Fix last change.
5457 2011-09-18 Paul Eggert <eggert@cs.ucla.edu>
5459 Fix minor problem found by static checking.
5460 * xdisp.c (reseat_at_next_visible_line_start): Mark locals as
5461 initialized, to pacify gcc -Wuninitialized.
5463 * fileio.c: Report proper errno when syscall falls.
5464 (Finsert_file_contents): Save and restore errno,
5465 so that report_file_error outputs the correct diagnostic.
5466 (Fwrite_region) [CLASH_DETECTION]: Likewise.
5468 2011-09-18 Eli Zaretskii <eliz@gnu.org>
5470 * .gdbinit (pgx): Fix references to fields of `struct glyph'.
5472 2011-09-17 Eli Zaretskii <eliz@gnu.org>
5474 * xdisp.c (produce_stretch_glyph): Another fix for changes made on
5475 2011-08-30T17:32:44Z!eliz@gnu.org. (Bug#9530)
5477 2011-09-17 Eli Zaretskii <eliz@gnu.org>
5479 * xdisp.c (reseat_at_next_visible_line_start): Keep information
5480 about the current paragraph and restore it after the call to reseat.
5482 * bidi.c (MAX_PARAGRAPH_SEARCH): New macro.
5483 (bidi_find_paragraph_start): Search back for paragraph beginning
5484 at most MAX_PARAGRAPH_SEARCH lines; if not found, return BEGV_BYTE.
5485 (bidi_move_to_visually_next): Only trigger paragraph-related
5486 computations when the last character is a newline or at EOB, not
5487 just any NEUTRAL_B. (Bug#9470)
5489 * xdisp.c (set_cursor_from_row): Don't invoke special treatment of
5490 truncated lines if point is covered by a display string. (Bug#9524)
5492 2011-09-16 Paul Eggert <eggert@cs.ucla.edu>
5494 * xselect.c: Relax test for outgoing X longs (Bug#9498).
5495 (cons_to_x_long): New function.
5496 (lisp_data_to_selection_data): Use it. Correct the test for
5497 short-versus-long data; it was negated. Break out of vector
5498 loop, for efficiency, when a long datum is discovered.
5500 2011-09-16 Stefan Monnier <monnier@iro.umontreal.ca>
5502 * eval.c (Fquote): Document its non-consing behavior (bug#9482).
5504 2011-09-16 Eli Zaretskii <eliz@gnu.org>
5506 * image.c (tiff_handler): Work around a bug in MinGW GCC 3.x (see
5507 GCC PR/17406) by declaring this function with external scope.
5509 2011-09-15 Paul Eggert <eggert@cs.ucla.edu>
5511 * editfns.c (Fformat): Fix bug in text-property fix (Bug#9514).
5512 Don't mishandle (length (format "%%")) and (format "%4000s%%" "").
5514 2011-09-15 Andreas Schwab <schwab@linux-m68k.org>
5516 * editfns.c (Fformat): Correctly handle text properties on "%%".
5518 2011-09-15 Eli Zaretskii <eliz@gnu.org>
5520 * xterm.c (x_draw_composite_glyph_string_foreground):
5521 * w32term.c (x_draw_composite_glyph_string_foreground):
5522 * term.c (encode_terminal_code):
5523 * composite.c (composition_update_it, get_composition_id):
5524 * xdisp.c (get_next_display_element)
5525 (fill_composite_glyph_string): Add comments about special meaning
5526 of TAB characters in a composition.
5528 2011-09-15 Paul Eggert <eggert@cs.ucla.edu>
5530 * editfns.c (Fformat): Fix off-by-1 bug for "%%b" (Bug#9514).
5531 This occurs when processing a multibyte format.
5532 Problem reported by Wolfgang Jenker.
5534 2011-09-15 Johan Bockgård <bojohan@gnu.org>
5536 * xdisp.c (try_cursor_movement): Only check for exact match if
5537 cursor hpos found by set_cursor_from_row is valid. (Bug#9495)
5539 2011-09-14 Paul Eggert <eggert@cs.ucla.edu>
5541 Remove unused external symbols.
5542 * dispextern.h (calc_pixel_width_or_height): Remove decl.
5543 * xdisp.c (calc_pixel_width_or_height): Now static.
5544 * doprnt.c (exprintf) [! (HAVE_X_WINDOWS && USE_X_TOOLKIT)]: Remove.
5545 * indent.c (check_display_width):
5546 * w32term.c: Fix comment to match code.
5547 * xterm.c, xterm.h (x_catching_errors): Remove.
5549 2011-09-14 Paul Eggert <eggert@cs.ucla.edu>
5551 * xselect.c: Use signed conversions more consistently (Bug#9498).
5552 (selection_data_to_lisp_data): Assume incoming selection data are
5553 signed integers, not unsigned. This is to be consistent with
5554 outgoing selection data, which was modified to use signed integers
5555 in as part of the fix to Bug#9196 in response to Jan D.'s comment
5556 in <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9196#32> that X11
5557 expects long, not unsigned long.
5559 2011-09-14 Eli Zaretskii <eliz@gnu.org>
5561 * xdisp.c (try_window_reusing_current_matrix): Fix incorrect
5562 computation of loop end. Reported by Johan Bockgård
5565 2011-09-13 Chong Yidong <cyd@stupidchicken.com>
5567 * frame.c (Fother_visible_frames_p): Function deleted.
5569 2011-09-12 Eli Zaretskii <eliz@gnu.org>
5571 * indent.c (compute_motion): Process display vector front to back
5572 rather than the other way around. (Bug#2496)
5574 2011-09-12 Stefan Monnier <monnier@iro.umontreal.ca>
5576 * fileio.c (Finsert_file_contents): Don't assume beg_offset is 0.
5578 2011-09-11 Chong Yidong <cyd@stupidchicken.com>
5580 * minibuf.c (Fread_from_minibuffer): Doc fix.
5582 2011-09-11 Eli Zaretskii <eliz@gnu.org>
5584 * xdisp.c (produce_stretch_glyph): Fix a typo made in changes from
5585 2011-08-30T17:32:44Z!eliz@gnu.org. (Bug#9475)
5587 2011-09-11 Lars Magne Ingebrigtsen <larsi@gnus.org>
5589 * fileio.c (Fvisited_file_modtime): Document `(-1 65535)' as a
5590 value for non-existent files.
5592 2011-09-11 Eli Zaretskii <eliz@gnu.org>
5594 * fileio.c (Finsert_file_contents): If the file cannot be opened,
5595 set its "size" to -1. This will set the modtime_size field of
5596 the corresponding buffer to -1, which is what
5597 verify-visited-file-modtime expects for files that do not exist.
5600 2011-09-11 Paul Eggert <eggert@cs.ucla.edu>
5602 * keymap.h (KEY_DESCRIPTION_SIZE, push_key_description): Move decls
5604 * lisp.h: ... from here. push_key_description is no longer
5605 defined in keyboard.c, so its declaration should not be in
5606 lisp.h's "Defined in keyboard.c" section, and KEY_DESCRIPTION_SIZE
5607 logically belongs with push_key_description.
5609 2011-09-10 Paul Eggert <eggert@cs.ucla.edu>
5611 * buffer.h: Include <sys/types.h> instead of <time.h>.
5612 Otherwise, off_t wasn't defined on FreeBSD 9.0-BETA2 i386.
5613 Problem reported by Herbert J. Skuhra.
5615 2011-09-10 Lars Magne Ingebrigtsen <larsi@gnus.org>
5617 * xml.c (parse_region): Make the parsing work for
5618 non-comment-starting XML files again (bug#9144).
5620 2011-09-10 Andreas Schwab <schwab@linux-m68k.org>
5622 * image.c (gif_load): Fix calculation of bottom and right corner.
5625 2011-09-10 Eli Zaretskii <eliz@gnu.org>
5627 * xdisp.c (MAX_DISP_SCAN): Decrease to 250. Prevents sluggish
5628 redisplay in small windows.
5630 2011-09-09 Eli Zaretskii <eliz@gnu.org>
5632 * frame.c (x_report_frame_params): Cast to avoid compiler warnings.
5634 2011-09-08 Martin Rudalics <rudalics@gmx.at>
5636 * window.c (Fset_window_prev_buffers, Fset_window_next_buffers):
5637 Operate on live windows only.
5639 2011-09-08 Juanma Barranquero <lekktu@gmail.com>
5641 * emacs.c (my_heap_start): #ifdef to avoid warnings when unused.
5643 2011-09-07 Eli Zaretskii <eliz@gnu.org>
5645 * xdisp.c (move_it_in_display_line_to): Call RESTORE_IT on ppos_it
5646 only under bidi iteration.
5648 2011-09-07 Jan Djärv <jan.h.d@swipnet.se>
5650 * gtkutil.c (xg_make_tool_item): Insert comment about eventbox.
5652 2011-09-06 Paul Eggert <eggert@cs.ucla.edu>
5654 isnan: Fix porting problem to Solaris 10 with bundled gcc.
5655 Without this fix, the command to link temacs failed due to an
5656 undefined symbol __builtin_isnan. This is because
5657 /usr/include/iso/math_c99.h #defines isnan(x) to
5658 __builtin_isnan(x), but the bundled gcc, which identifies itself
5659 as gcc 3.4.3 (csl-sol210-3_4-branch+sol_rpath), does not have
5661 * floatfns.c (isnan): #undef, and then #define to a clone of
5663 (Fisnan): Always define, since it's always available now.
5664 (syms_of_floatfns): Always define isnan at the Lisp level.
5666 2011-09-06 Paul Eggert <eggert@cs.ucla.edu>
5668 * Makefile.in (gl-stamp): move-if-change now in build-aux (Bug#9169).
5670 2011-09-06 Paul Eggert <eggert@cs.ucla.edu>
5672 * fileio.c: Fix bugs with large file offsets (Bug#9428).
5673 The previous code assumed that file offsets (off_t values) fit in
5674 EMACS_INT variables, which is not true on typical 32-bit hosts.
5675 The code messed up by falsely reporting buffer overflow in cases
5676 such as (insert-file-contents "big" nil 1 2) into an empty buffer
5677 when "big" contains more than 2**29 bytes, even though this
5678 inserts just one byte and does not overflow the buffer.
5679 (Finsert_file_contents): Store file offsets as off_t
5680 values, not as EMACS_INT values. Check for overflow when
5681 converting between EMACS_INT and off_t. When checking for
5682 buffer overflow or for overlap, take the offsets into account.
5683 Don't use EMACS_INT for small values where int suffices.
5684 When checking for overlap, fix a typo: ZV was used where
5685 ZV_BYTE was intended.
5686 (Fwrite_region): Don't assume off_t fits into 'long'.
5687 * buffer.h (struct buffer.modtime_size): Now off_t, not EMACS_INT.
5689 2011-09-05 Michael Albinus <michael.albinus@gmx.de>
5691 * dbusbind.c (xd_signature_cat): Rename from signature_cat.
5693 2011-09-04 Paul Eggert <eggert@cs.ucla.edu>
5695 sprintf-related integer and memory overflow issues (Bug#9412).
5697 * doprnt.c (doprnt): Support printing ptrdiff_t and intmax_t values.
5698 (esprintf, exprintf, evxprintf): New functions.
5699 * keyboard.c (command_loop_level): Now EMACS_INT, not int.
5700 (cmd_error): Kbd macro iterations count is now EMACS_INT, not int.
5701 (modify_event_symbol): Do not assume that the length of
5702 name_alist_or_stem is safe to alloca and fits in int.
5703 (Fexecute_extended_command): Likewise for function name and binding.
5704 (Frecursion_depth): Wrap around reliably on integer overflow.
5705 * keymap.c (push_key_description): First arg is now EMACS_INT, not int,
5706 since some callers pass EMACS_INT values.
5707 (Fsingle_key_description): Don't crash if symbol name contains more
5708 than MAX_ALLOCA bytes.
5709 * minibuf.c (minibuf_level): Now EMACS_INT, not int.
5710 (get_minibuffer): Arg is now EMACS_INT, not int.
5711 * lisp.h (get_minibuffer, push_key_description): Reflect API changes.
5712 (esprintf, exprintf, evxprintf): New decls.
5713 * window.h (command_loop_level, minibuf_level): Reflect API changes.
5715 * dbusbind.c (signature_cat): New function.
5716 (xd_signature, Fdbus_register_signal):
5717 Do not overrun buffer; instead, report string overflow.
5719 * dispnew.c (add_window_display_history): Don't overrun buffer.
5720 Truncate instead; this is OK since it's just a log.
5722 * editfns.c (Fcurrent_time_zone): Don't overrun buffer
5723 even if the time zone offset is outlandishly large.
5724 Don't mishandle offset == INT_MIN.
5726 * emacs.c (main) [NS_IMPL_COCOA]: Don't overrun buffer
5727 when creating daemon; the previous buffer-overflow check was incorrect.
5729 * eval.c (verror): Simplify by rewriting in terms of evxprintf,
5730 which has the guts of the old verror function.
5732 * filelock.c (lock_file_1, lock_file): Don't blindly alloca long name;
5733 use SAFE_ALLOCA instead. Use esprintf to avoid int-overflow issues.
5735 * font.c: Include <float.h>, for DBL_MAX_10_EXP.
5736 (font_unparse_xlfd): Don't blindly alloca long strings.
5737 Don't assume XINT result fits in int, or that XFLOAT_DATA * 10
5738 fits in int, when using sprintf. Use single snprintf to count
5739 length of string rather than counting it via multiple sprintfs;
5740 that's simpler and more reliable.
5741 (font_unparse_fcname): Use it to avoid sprintf buffer overrun.
5742 (generate_otf_features) [0 && HAVE_LIBOTF]: Use esprintf, not
5743 sprintf, in case result does not fit in int.
5745 * fontset.c (num_auto_fontsets): Now printmax_t, not int.
5746 (fontset_from_font): Print it.
5748 * frame.c (tty_frame_count): Now printmax_t, not int.
5749 (make_terminal_frame, set_term_frame_name): Print it.
5750 (x_report_frame_params): In X, window IDs are unsigned long,
5751 not signed long, so print them as unsigned.
5752 (validate_x_resource_name): Check for implausibly long names,
5753 and don't assume name length fits in 'int'.
5754 (x_get_resource_string): Don't blindly alloca invocation name;
5755 use SAFE_ALLOCA. Use esprintf, not sprintf, in case result does
5758 * gtkutil.c: Include <float.h>, for DBL_MAX_10_EXP.
5759 (xg_check_special_colors, xg_set_geometry):
5760 Make sprintf buffers a bit bigger, to avoid potential buffer overrun.
5762 * lread.c (dir_warning): Don't blindly alloca buffer; use SAFE_ALLOCA.
5763 Use esprintf, not sprintf, in case result does not fit in int.
5765 * macros.c (executing_kbd_macro_iterations): Now EMACS_INT, not int.
5766 (Fend_kbd_macro): Don't mishandle MOST_NEGATIVE_FIXNUM by treating
5767 it as a large positive number.
5768 (Fexecute_kbd_macro): Don't assume repeat count fits in int.
5769 * macros.h (executing_kbd_macro_iterations): Now EMACS_INT, not int.
5771 * nsterm.m ((NSSize)windowWillResize): Use esprintf, not sprintf,
5772 in case result does not fit in int.
5774 * print.c (float_to_string): Detect width overflow more reliably.
5775 (print_object): Make sprintf buffer a bit bigger, to avoid potential
5776 buffer overrun. Don't assume list length fits in 'int'. Treat
5777 print length of 0 as 0, not as infinity; to be consistent with other
5778 uses of print length in this function. Don't overflow print length
5779 index. Don't assume hash table size fits in 'long', or that
5780 vectorlike size fits in 'unsigned long'.
5782 * process.c (make_process): Use printmax_t, not int, to format
5783 process-name gensyms.
5785 * sysdep.c (snprintf) [! HAVE_SNPRINTF]: New function.
5787 * term.c (produce_glyphless_glyph): Make sprintf buffer a bit bigger
5788 to avoid potential buffer overrun.
5790 * xfaces.c (x_update_menu_appearance): Don't overrun buffer
5791 if X resource line is longer than 512 bytes.
5793 * xfns.c (x_window): Make sprintf buffer a bit bigger
5794 to avoid potential buffer overrun.
5796 * xterm.c (x_io_error_quitter): Don't overrun sprintf buffer.
5798 * xterm.h (x_check_errors): Add ATTRIBUTE_FORMAT_PRINTF.
5800 2011-09-04 Paul Eggert <eggert@cs.ucla.edu>
5802 Integer overflow fixes for scrolling, etc.
5803 Without these, Emacs silently mishandles large integers sometimes.
5804 For example, "C-u 4294967297 M-x recenter" was treated as if
5805 it were "C-u 1 M-x recenter" on a typical 64-bit host.
5807 * xdisp.c (try_window_id): Check Emacs fixnum range before
5808 converting to 'int'.
5810 * window.c (window_scroll_line_based, Frecenter):
5811 Check that an Emacs fixnum is in range before assigning it to 'int'.
5812 (Frecenter, Fmove_to_window_line): Use EMACS_INT, not int, for
5813 values converted from Emacs fixnums.
5814 (Frecenter): Don't wrap around a line count if it is out of 'int'
5815 range; instead, treat it as an extreme value.
5816 (Fset_window_configuration, compare_window_configurations):
5817 Use ptrdiff_t, not int, for index that might exceed 2 GiB.
5819 * search.c (Freplace_match): Use ptrdiff_t, not int, for indexes
5820 that can exceed INT_MAX. Check that EMACS_INT value is in range
5821 before assigning it to the (possibly-narrower) index.
5822 (match_limit): Don't assume that a fixnum can fit in 'int'.
5824 * print.c (print_object): Use ptrdiff_t, not int, for index that can
5827 * indent.c (position_indentation): Now takes ptrdiff_t, not int.
5828 (Fvertical_motion): Don't wrap around LINES values that don't fit
5829 in 'int'. Instead, treat them as extreme values. This is good
5830 enough for windows, which can't have more than INT_MAX lines anyway.
5832 2011-09-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
5834 * Require libxml/parser.h to avoid compilation warning.
5836 * emacs.c (shut_down_emacs): Call xmlCleanupParser on shutdown.
5838 * xml.c (parse_region): Don't call xmlCleanupParser after parsing,
5839 since this reportedly can destroy thread storage.
5841 2011-08-30 Chong Yidong <cyd@stupidchicken.com>
5843 * syntax.c (find_defun_start): Update all cache variables if
5844 exiting early (Bug#9401).
5846 2011-08-30 Eli Zaretskii <eliz@gnu.org>
5848 * image.c (x_bitmap_pixmap): Cast to int to avoid compiler warnings.
5850 * xdisp.c (produce_stretch_glyph): No longer static, compiled also
5851 when HAVE_WINDOW_SYSTEM is not defined. Support both GUI and TTY
5852 frames. Call tty_append_glyph in the TTY case. (Bug#9402)
5854 * term.c (tty_append_glyph): New function.
5855 (produce_stretch_glyph): Static function and its prototype deleted.
5857 * dispextern.h (produce_stretch_glyph, tty_append_glyph):
5860 2011-08-29 Paul Eggert <eggert@cs.ucla.edu>
5862 * image.c (parse_image_spec): Check for nonnegative, not for positive,
5863 when checking :margin (Bug#9390).
5864 (IMAGE_NON_NEGATIVE_INTEGER_VALUE_OR_PAIR):
5865 Rename from IMAGE_POSITIVE_INTEGER_VALUE_OR_PAIR,
5866 so that the name doesn't mislead. All uses changed.
5868 2011-08-28 Johan Bockgård <bojohan@gnu.org>
5870 * term.c (init_tty) [HAVE_GPM]: Move mouse settings after
5873 2011-08-27 Eli Zaretskii <eliz@gnu.org>
5875 * xdisp.c (move_it_to): Don't bail out early when reaching
5876 position beyond to_charpos, if we are scanning backwards.
5877 (move_it_vertically_backward): When DY == 0, make sure we get to
5878 the first character in the line after the newline.
5880 2011-08-27 Paul Eggert <eggert@cs.ucla.edu>
5882 * ccl.c: Improve and simplify overflow checking (Bug#9196).
5883 (ccl_driver): Do not generate an out-of-range pointer.
5884 (Fccl_execute_on_string): Remove unnecessary check for
5885 integer overflow, noted by Stefan Monnier in
5886 <http://lists.gnu.org/archive/html/emacs-devel/2011-08/msg00979.html>.
5887 Remove a FIXME that didn't need fixing.
5888 Simplify the newly-introduced buffer reallocation code.
5890 2011-08-27 Juanma Barranquero <lekktu@gmail.com>
5892 * makefile.w32-in ($(BLD)/alloc.$(O)): Depend on lib/verify.h.
5894 2011-08-26 Paul Eggert <eggert@cs.ucla.edu>
5896 Integer and memory overflow issues (Bug#9196).
5898 * doc.c (get_doc_string): Rework so that
5899 get_doc_string_buffer_size is the actual buffer size, rather than
5900 being 1 less than the actual buffer size; this makes xpalloc more
5903 * image.c (x_allocate_bitmap_record, cache_image):
5904 * xselect.c (Fx_register_dnd_atom):
5905 Simplify previous changes by using xpalloc.
5907 * buffer.c (overlay_str_len): Now ptrdiff_t, not EMACS_INT,
5908 since either will do and ptrdiff_t is convenient with xpalloc.
5910 * charset.c (charset_table_size)
5911 (struct charset_sort_data.priority): Now ptrdiff_t.
5912 (charset_compare): Don't overflow if priorities differ greatly.
5913 (Fsort_charsets): Don't assume list length fits in int.
5914 Check for size-calculation overflow when allocating sort data.
5915 (syms_of_charset): Allocate an initial charset table that is
5916 just under 64 KiB, to avoid problems with glibc malloc and mmap.
5918 * cmds.c (internal_self_insert): Check for size-calculation overflow.
5920 * composite.h (struct composition.glyph_len): Now int, not unsigned.
5921 The actual value is always <= INT_MAX, and leaving it unsigned made
5922 overflow checking harder.
5924 * dispextern.h (struct glyph_matrix.rows_allocated)
5925 (struct face_cache.size): Now ptrdiff_t, for convenience in use
5926 with xpalloc. The values are still always <= INT_MAX.
5928 * indent.c (compute_motion): Adjust to region_cache_forward sig change.
5930 * lisp.h (xnmalloc, xnrealloc, xpalloc): New decls.
5931 (SAFE_NALLOCA): New macro.
5933 * region-cache.c (struct boundary.pos, find_cache_boundary)
5934 (move_cache_gap, insert_cache_boundary, delete_cache_boundaries)
5935 (set_cache_region, invalidate_region_cache)
5936 (revalidate_region_cache, know_region_cache, region_cache_forward)
5937 (region_cache_backward, pp_cache):
5938 Use ptrdiff_t, not EMACS_INT, since either will do. This is needed
5939 so that ptrdiff_t * can be passed to xpalloc.
5940 (struct region_cache): Similarly, for gap_start, gap_len, cache_len,
5941 beg_unchanged, end_unchanged, buffer_beg, buffer_end members.
5942 (pp_cache): Don't assume cache_len fits in int.
5943 * region-cache.h: Adjust extern decls to match.
5945 * search.c (scan_buffer, Freplace_match): Use ptrdiff_t, not
5946 EMACS_INT, since either will do, for xpalloc.
5948 * alloc.c: Include verify.h, and check that int fits in ptrdiff_t.
5949 (xnmalloc, xnrealloc, xpalloc): New functions.
5951 * bidi.c (bidi_shelve_header_size): New constant.
5952 (bidi_cache_ensure_space, bidi_shelve_cache): Use it.
5953 (bidi_cache_ensure_space): Avoid integer overflow when allocating.
5955 * bidi.c (bidi_cache_shrink):
5956 * buffer.c (overlays_at, overlays_in, record_overlay_string)
5958 Don't update size of array until after memory allocation succeeds,
5959 because xmalloc/xrealloc may not return.
5960 (struct sortstrlist.bytes): Now ptrdiff_t, as EMACS_INT doesn't help
5961 now that we have proper integer overflow checking.
5962 (record_overlay_string, overlay_strings): Catch overflows when
5963 calculating size of overlay_str_buf.
5965 * callproc.c (Fcall_process): Check for size overflow when
5966 calculating size of args2.
5967 (child_setup): Avoid overflow by using size_t rather than ptrdiff_t.
5968 Normally we prefer signed values, but sticking with ptrdiff_t would
5969 require adding more-complicated checks.
5971 * ccl.c (Fccl_execute_on_string): Check for memory overflow.
5972 Use ptrdiff_t rather than EMACS_INT where ptrdiff_t will do.
5973 Redo buffer-overflow calculations to avoid integer overflow.
5974 Add a FIXME comment where memory seems to be over-allocated.
5976 * character.c (Fstring): Check for size-calculation overflow.
5978 * coding.c (produce_chars): Redo buffer-overflow calculations to avoid
5979 unnecessary integer overflow. Check for size overflow.
5980 (encode_coding_object): Don't update size until xmalloc succeeds.
5982 * composite.c (get_composition_id): Check for overflow in glyph
5983 length calculations.
5985 Integer and memory overflow fixes for display code.
5986 * dispextern.h (struct glyph_pool.nglyphs): Now ptrdiff_t, not int.
5987 * dispnew.c (adjust_glyph_matrix, realloc_glyph_pool)
5988 (scrolling_window): Check for overflow in size calculations.
5989 (line_draw_cost, realloc_glyph_pool, add_row_entry):
5990 Don't assume glyph table len fits in int.
5991 (struct row_entry.bucket, row_entry_pool_size, row_entry_idx)
5992 (row_table_size): Now ptrdiff_t, not int.
5993 (scrolling_window): Avoid overflow in size calculations.
5994 Don't update size until allocation succeeds.
5995 * fns.c (concat): Check for overflow in size calculations.
5996 (next_almost_prime): Verify NEXT_ALMOST_PRIME_LIMIT.
5997 * lisp.h (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): New macros.
5998 (NEXT_ALMOST_PRIME_LIMIT): New constant.
6000 * doc.c (get_doc_string_buffer_size): Now ptrdiff_t, not int.
6001 (get_doc_string): Check for size calculation overflow.
6002 Don't update size until allocation succeeds.
6003 (get_doc_string, Fsubstitute_command_keys): Use ptrdiff_t, not
6004 EMACS_INT, where ptrdiff_t will do.
6005 (Fsubstitute_command_keys): Check for string overflow.
6007 * editfns.c (set_time_zone_rule): Don't assume environment length
6009 (message_length): Now ptrdiff_t, not int.
6010 (Fmessage_box): Don't update size until allocation succeeds.
6011 Don't assume message length fits in int.
6012 (Fformat): Use ptrdiff_t, not EMACS_INT, where ptrdiff_t will do.
6014 * emacs.c (main): Do not reallocate argv, since there is a null at
6015 the end that can be overwritten, and this way there's no need to
6016 worry about size-calculation overflow.
6017 (sort_args): Check for size-calculation overflow.
6019 * eval.c (init_eval_once, grow_specpdl): Don't update size until
6021 (call_debugger, grow_specpdl): Redo calculations to avoid overflow.
6023 * frame.c (set_menu_bar_lines, x_set_frame_parameters)
6024 (x_set_scroll_bar_width, x_figure_window_size):
6025 Check for integer overflow.
6026 (x_set_alpha): Do not assume XINT fits in int.
6028 * frame.h (struct frame): Use int, not EMACS_INT, where int works.
6029 This is for the members text_lines, text_cols, total_lines, total_cols,
6030 where the system imposes an 'int' limit.
6032 * fringe.c (Fdefine_fringe_bitmap):
6033 Don't update size until alloc works.
6035 * ftfont.c (ftfont_get_open_type_spec, setup_otf_gstring)
6036 (ftfont_shape_by_flt): Check for integer overflow in size calculations.
6038 * gtkutil.c (get_utf8_string, xg_store_widget_in_map):
6039 Check for size-calculation overflow.
6040 (get_utf8_string): Use ptrdiff_t, not size_t, where either will
6041 do, as we prefer signed integers.
6042 (id_to_widget.max_size, id_to_widget.used)
6043 (xg_store_widget_in_map, xg_remove_widget_from_map)
6044 (xg_get_widget_from_map, xg_get_scroll_id_for_window)
6045 (xg_remove_scroll_bar, xg_update_scrollbar_pos):
6046 Use and return ptrdiff_t, not int.
6047 (xg_gtk_scroll_destroy): Don't assume ptrdiff_t fits in int.
6048 * gtkutil.h: Change prototypes to match the above.
6050 * image.c (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): Remove; these
6051 are duplicate now that they've been promoted to lisp.h.
6052 (x_allocate_bitmap_record, x_alloc_image_color)
6053 (make_image_cache, cache_image, xpm_load):
6054 Don't update size until alloc is done.
6055 (xpm_load, lookup_rgb_color, lookup_pixel_color, x_to_xcolors)
6057 Check for size calculation overflow.
6058 (ct_colors_allocated_max): New constant.
6059 (x_to_xcolors, x_detect_edges): Reorder multiplicands to avoid
6062 * keyboard.c (read_char, menu_bar_items, tool_bar_items)
6063 (read_char_x_menu_prompt, read_char_minibuf_menu_width)
6064 (read_char_minibuf_menu_prompt, follow_key, read_key_sequence):
6065 Use ptrdiff_t, not int, to count maps.
6066 (read_char_minibuf_menu_prompt): Check for overflow in size
6067 calculations. Don't update size until allocation succeeds.
6068 Redo calculations to avoid overflow.
6069 * keyboard.h: Change prototypes to match the above.
6071 * keymap.c (cmm_size, current_minor_maps): Use ptrdiff_t, not int,
6073 (current_minor_maps): Check for size calculation overflow.
6074 * keymap.h: Change prototypes to match the above.
6076 * lread.c (read1, init_obarray): Don't update size until alloc done.
6078 * macros.c (Fstart_kbd_macro): Don't update size until alloc done.
6079 (store_kbd_macro_char): Reorder multiplicands to avoid overflow.
6081 * nsterm.h (struct ns_color_table.size, struct ns_color_table.avail):
6082 Now ptrdiff_t, not int.
6083 * nsterm.m (ns_index_color): Use ptrdiff_t, not int, for table indexes.
6084 (ns_draw_fringe_bitmap): Rewrite to avoid overflow.
6086 * process.c (Fnetwork_interface_list): Check for overflow
6087 in size calculation.
6089 * region-cache.c (move_cache_gap): Check for size calculation overflow.
6091 * scroll.c (do_line_insertion_deletion_costs): Check for size calc
6092 overflow. Don't bother calling xmalloc when xrealloc will do.
6094 * search.c (Freplace_match): Check for size calculation overflow.
6095 (Fset_match_data): Don't assume list lengths fit in 'int'.
6097 * sysdep.c (system_process_attributes): Use ptrdiff_t, not int,
6098 for command line length. Do not attempt to address one before the
6099 beginning of an array, as that's not portable.
6101 * term.c (max_frame_lines): Remove; unused.
6102 (encode_terminal_src_size, encode_terminal_dst_size): Now ptrdiff_t,
6104 (encode_terminal_code, calculate_costs): Check for size
6105 calculation overflow.
6106 (encode_terminal_code): Use ptrdiff_t, not int, to record glyph
6107 table lengths and related sizes. Don't update size until alloc
6108 done. Redo calculations to avoid overflow.
6109 (calculate_costs): Don't bother calling xmalloc when xrealloc will do.
6111 * termcap.c (tgetent): Use ptrdiff_t, not int, to record results of
6112 subtracting pointers.
6113 (gobble_line): Check for overflow more carefully. Don't update size
6116 * tparam.c (tparam1): Use ptrdiff_t, not int, for sizes.
6117 Don't update size until alloc done.
6118 Redo size calculations to avoid overflow.
6119 Check for size calculation overflow.
6120 (main) [DEBUG]: Fix typo in invoking tparam1.
6122 * xdisp.c (store_mode_line_noprop_char, x_consider_frame_title):
6123 Use ptrdiff_t, not int, for sizes.
6124 (store_mode_line_noprop_char): Don't update size until alloc done.
6126 * xfaces.c (lface_id_to_name_size, Finternal_make_lisp_face):
6127 Use ptrdiff_t, not int, for sizes.
6128 (Finternal_make_lisp_face, cache_face):
6129 Check for size calculation overflow.
6130 (cache_face): Treat size calculation overflows as if they were
6131 memory exhaustion (the usual treatment), rather than aborting.
6133 * xfns.c (x_encode_text, x_set_name_internal)
6134 (Fx_change_window_property): Use ptrdiff_t, not int, to count
6135 sizes, since they can exceed INT_MAX in size. Check for size
6136 calculation overflow.
6138 * xgselect.c (gfds_size): Now ptrdiff_t, for convenience with xpalloc.
6139 (xg_select): Check for size calculation overflow.
6140 Don't update size until alloc done.
6142 * xrdb.c (get_environ_db): Don't assume path length fits in int,
6143 as sprintf is limited to int lengths.
6145 * xselect.c (X_LONG_SIZE, X_SHRT_MAX, X_SHRT_MIN, X_LONG_MAX)
6146 (X_LONG_MIN): New macros.
6147 Use them to make the following changes clearer.
6148 (MAX_SELECTION_QUANTUM): Make the other bounds on this value clearer.
6149 This change doesn't affect the value now, but it may help remind
6150 future maintainers not to raise the value too much later.
6151 (SELECTION_QUANTUM): Remove, replacing with ...
6152 (selection_quantum): ... new function, which avoids overflow.
6154 (struct selection_data.size): Now ptrdiff_t, not int, to avoid
6155 assumption that selection length fits in 'int'.
6156 (x_reply_selection_request, x_handle_selection_request)
6157 (x_get_window_property, receive_incremental_selection)
6158 (x_get_window_property_as_lisp_data, selection_data_to_lisp_data)
6159 (lisp_data_to_selection_data, clean_local_selection_data):
6160 Use ptrdiff_t, not int, to record length of selection.
6161 (x_reply_selection_request, x_get_window_property)
6162 (receive_incremental_selection, x_property_data_to_lisp):
6163 Redo calculations to avoid overflow.
6164 (x_reply_selection_request): When sending hint, ceiling it at
6165 X_LONG_MAX rather than relying on wraparound overflow to send
6167 (x_get_window_property, receive_incremental_selection)
6168 (lisp_data_to_selection_data, x_property_data_to_lisp):
6169 Check for size-calculation overflow.
6170 (x_get_window_property, receive_incremental_selection)
6171 (lisp_data_to_selection_data, Fx_register_dnd_atom):
6172 Don't store size until memory allocation succeeds.
6173 (x_get_window_property): Plug memory leak on memory exhaustion.
6174 Don't double-block input; malloc is safe here. Don't assume 2**34
6175 - 4 fits in unsigned long. Add an xassert to check
6176 XGetWindowProperty overflow. Be more careful about overflow
6177 calculations, and distinguish size from memory overflow better.
6178 (receive_incremental_selection): When tracing, don't assume
6179 unsigned int is less than INT_MAX.
6180 (x_selection_data_to_lisp_data): Remove unnecessary (and in theory
6181 harmful) conversions of unsigned short to int.
6182 (lisp_data_to_selection_data): Don't assume that integers
6183 in the range -65535 through -1 fit in an X unsigned short.
6184 Don't assume that ULONG_MAX == X_ULONG_MAX. Don't store into
6185 result parameters unless successful. Rely on cons_to_unsigned
6186 to report problems with elements; the old code wasn't right anyway.
6187 (x_check_property_data): Check for int overflow; we cannot use
6188 a wider type due to X limits.
6189 (x_handle_dnd_message): Use unsigned int, to avoid int overflow.
6191 * xsmfns.c (smc_save_yourself_CB): Check for size calc overflow.
6193 * xterm.c (x_color_cells, x_send_scrollbar_event, handle_one_xevent)
6194 (x_term_init): Check for size calculation overflow.
6195 (x_color_cells): Don't store size until memory allocation succeeds.
6196 (handle_one_xevent): Use ptrdiff_t, not int, for byte counts.
6197 Don't assume alloca size is less than MAX_ALLOCA.
6198 (x_term_init): Don't assume length fits in int (sprintf is limited
6201 Use ptrdiff_t for composition IDs.
6202 * character.c (lisp_string_width):
6203 * composite.c (composition_table_size, n_compositions)
6204 (get_composition_id, composition_gstring_from_id):
6205 * dispextern.h (struct glyph_string.cmp_id, struct composition_it.id):
6206 * xdisp.c (BUILD_COMPOSITE_GLYPH_STRING):
6207 * window.c (Frecenter):
6208 Use ptrdiff_t, not int, for composition IDs.
6209 * composite.c (get_composition_id): Check for integer overflow.
6210 * composite.h: Adjust prototypes to match the above changes.
6212 Use ptrdiff_t for hash table indexes.
6213 * category.c (hash_get_category_set):
6214 * ccl.c (ccl_driver):
6215 * charset.h (struct charset.hash_index, CHECK_CHARSET_GET_ID):
6216 * coding.c (coding_system_charset_list, detect_coding_system):
6217 * coding.h (struct coding_system.id):
6218 * composite.c (get_composition_id, gstring_lookup_cache):
6219 * fns.c (hash_lookup, hash_put, Fgethash, Fputhash):
6220 * image.c (xpm_get_color_table_h):
6221 * lisp.h (hash_lookup, hash_put):
6222 * minibuf.c (Ftest_completion):
6223 Use ptrdiff_t for hash table indexes, not int (which is too
6224 narrow, on 64-bit hosts) or EMACS_INT (which is too wide, on
6225 32-bit --with-wide-int hosts).
6227 * charset.c (Fdefine_charset_internal): Check for integer overflow.
6228 Add a FIXME comment about memory leaks.
6229 (syms_of_charset): Don't assume xmalloc returns.
6231 Don't assume that stated character widths fit in int.
6232 * character.c (Fchar_width, c_string_width, lisp_string_width):
6233 * character.h (CHAR_WIDTH):
6234 * indent.c (MULTIBYTE_BYTES_WIDTH):
6235 Use sanitize_char_width to avoid undefined and/or bad behavior
6236 with outlandish widths.
6237 * character.h (sanitize_tab_width): Rename from sanitize_width,
6238 now that we have two such functions. All uses changed.
6239 (sanitize_char_width): New inline function.
6241 Don't assume that tab-width fits in int.
6242 * character.h (sanitize_width): New inline function.
6243 (SANE_TAB_WIDTH): New macro.
6244 (ASCII_CHAR_WIDTH): Use it.
6245 * indent.c (sane_tab_width): Remove. All uses replaced by
6246 SANE_TAB_WIDTH (current_buffer).
6247 * xdisp.c (init_iterator): Use SANE_TAB_WIDTH.
6249 * fileio.c: Integer overflow issues with file modes.
6250 (Fset_file_modes, auto_save_1): Don't assume EMACS_INT fits in int.
6252 * charset.c (read_hex): New arg OVERFLOW. All uses changed.
6253 Remove unreachable code.
6254 (read_hex, load_charset_map_from_file): Check for integer overflow.
6256 * xterm.c: Don't go over XClientMessageEvent limit.
6257 (scroll_bar_windows_size): Now ptrdiff_t, as we prefer signed.
6258 (x_send_scroll_bar_event): Likewise. Check that the size does not
6259 exceed limits imposed by XClientMessageEvent, as well as the usual
6260 ptrdiff_t and size_t limits.
6262 * keyboard.c: Overflow, signedness and related fixes.
6263 (make_lispy_movement): Use same integer type in forward decl
6264 that is used in the definition.
6265 (read_key_sequence, keyremap_step):
6266 Change bufsize argument back to int, undoing my 2011-03-30 change.
6267 We prefer signed types, and int is wide enough here.
6268 (parse_tool_bar_item): Don't assume tool_bar_max_label_size is less
6269 than TYPE_MAXIMUM (EMACS_INT) / 2. Don't let the label size grow
6270 larger than STRING_BYTES_BOUND. Use ptrdiff_t for Emacs string
6271 length, not size_t. Use ptrdiff_t for index, not int.
6272 (keyremap_step, read_key_sequence): Redo bufsize check to avoid
6273 possibility of integer overflow.
6275 Overflow, signedness and related fixes for images.
6277 * dispextern.h (struct it.stack[0].u.image.image_id)
6278 (struct_it.image_id, struct image.id, struct image_cache.size)
6279 (struct image_cache.used, struct image_cache.ref_count):
6280 * gtkutil.c (update_frame_tool_bar):
6281 * image.c (x_reference_bitmap, Fimage_size, Fimage_mask_p)
6282 (Fimage_metadata, free_image_cache, clear_image_cache, lookup_image)
6283 (cache_image, mark_image_cache, x_kill_gs_process, Flookup_image):
6284 * nsmenu.m (update_frame_tool_bar):
6285 * xdisp.c (calc_pixel_width_or_height):
6286 * xfns.c (image_cache_refcount):
6287 Image IDs are now ptrdiff_t, not int, to avoid arbitrary limits
6288 on typical 64-bit hosts.
6290 * image.c (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): New macros.
6291 (x_bitmap_pixmap, x_create_x_image_and_pixmap):
6292 Omit unnecessary casts to int.
6293 (parse_image_spec): Check that integers fall into 'int' range
6294 when the callers expect that.
6295 (image_ascent): Redo ascent calculation to avoid int overflow.
6296 (clear_image_cache): Avoid overflow when sqrt (INT_MAX) < nimages.
6297 (lookup_image): Remove unnecessary tests.
6298 (xbm_image_p): Locals are now of int, not EMACS_INT,
6299 since parse_image_check makes sure they fit into int.
6300 (png_load, gif_load, svg_load_image):
6301 Prefer int to unsigned where either will do.
6302 (tiff_handler): New function, combining the cores of the
6303 old tiff_error_handler and tiff_warning_handler.
6304 This function is rewritten to use vsnprintf and thereby avoid
6305 stack buffer overflows. It uses only the features of vsnprintf
6306 that are common to both POSIX and native Microsoft.
6307 (tiff_error_handler, tiff_warning_handler): Use it.
6308 (tiff_load, gif_load, imagemagick_load_image):
6309 Don't assume :index value fits in 'int'.
6310 (gif_load): Omit unnecessary cast to double, and avoid double-rounding.
6311 (imagemagick_load_image): Check that crop parameters fit into
6312 the integer types that MagickCropImage accepts. Don't assume
6313 Vimagemagick_render_type has a nonnegative value. Don't assume
6314 size_t fits in 'long'.
6315 (gs_load): Use printmax_t to print the widest integers possible.
6316 Check for integer overflow when computing image height and width.
6318 2011-08-26 Eli Zaretskii <eliz@gnu.org>
6320 * xdisp.c (redisplay_window): Don't force window start if point
6321 will be invisible in the resulting window. (Bug#9324)
6323 2011-08-25 Eli Zaretskii <eliz@gnu.org>
6325 * xdisp.c (compute_display_string_pos): Return 2 in DISP_PROP when
6326 the display spec is of the form `(space ...)'.
6327 (handle_display_spec): Return the value returned by
6328 handle_single_display_spec, not just 1 or zero.
6329 (handle_single_display_spec): If the display spec is of the form
6330 `(space ...)', and specifies display in the text area, return 2
6332 (try_cursor_movement): Check for the need to scroll more
6333 accurately, and prefer exact match for point under bidi.
6334 Don't advance `row' beyond the last row of the window.
6336 * dispextern.h (struct bidi_it): Rename the disp_prop_p member
6337 into disp_prop; all users changed.
6339 * bidi.c (bidi_fetch_char): If compute_display_string_pos returns
6340 DISP_PROP = 2, substitute the u+2029 PARAGRAPH SEPARATOR character
6341 for the text covered by the display property.
6343 2011-08-25 Chong Yidong <cyd@stupidchicken.com>
6345 * buffer.c (Fbury_buffer_internal): Rename from Funrecord_buffer.
6346 Change return value to nil.
6347 (Frecord_buffer): Delete unused function.
6349 2011-08-24 Eli Zaretskii <eliz@gnu.org>
6351 * xdisp.c (Fcurrent_bidi_paragraph_direction): For unibyte
6352 buffers, return left-to-right.
6353 (set_cursor_from_row): Consider candidate row a win if its glyph
6354 represents a newline and point is on that newline. Fixes cursor
6355 positioning on the newline at EOL of R2L text within L2R
6356 paragraph, and vice versa.
6357 (try_cursor_movement): Check continued rows, in addition to
6358 continuation rows. Fixes unwarranted scroll when point enters a
6359 continued line of R2L text within an L2R paragraph, or vice versa.
6360 (cursor_row_p): Consider the case of point being equal to
6361 MATRIX_ROW_END_CHARPOS. Prevents cursor being stuck when moving
6362 from the end of a short line to the beginning of a continued line
6363 of R2L text within L2R paragraph.
6364 (RECORD_MAX_MIN_POS): For max_pos, use IT_CHARPOS even for
6365 composed characters.
6367 * bidi.c (bidi_check_type): Use xassert.
6368 (bidi_cache_iterator_state): Update the disp_pos and disp_prop_p
6371 2011-08-23 Eli Zaretskii <eliz@gnu.org>
6373 * bidi.c (bidi_get_type): Abort if we get zero as the bidi type of
6376 2011-08-23 Chong Yidong <cyd@stupidchicken.com>
6378 * nsfont.m (ns_otf_to_script): Fix typo.
6380 2011-08-22 Kenichi Handa <handa@m17n.org>
6382 * chartab.c (Fset_char_table_extra_slot): Do not inhibit setting a
6383 extra slot even if the purpose is char-code-property-table.
6385 2011-08-23 Eli Zaretskii <eliz@gnu.org>
6387 * xdisp.c (redisplay_window): When computing centering_position,
6388 account for the height of the header line. (Bug#8874)
6390 * dispnew.c (buffer_posn_from_coords): Use buf_charpos_to_bytepos
6391 instead of CHAR_TO_BYTE. Fixes a crash when a completion
6392 candidate is selected by the mouse, and that candidate has a
6393 composed character under the mouse.
6395 * xdisp.c (x_produce_glyphs): Set it->nglyphs to 1. Fixes pixel
6396 coordinates reported by pos-visible-in-window-p for a composed
6397 character in column zero.
6399 2011-08-23 Stefan Monnier <monnier@iro.umontreal.ca>
6401 * cmds.c (Fself_insert_command): Mention post-self-insert-hook.
6403 2011-08-22 Eli Zaretskii <eliz@gnu.org>
6405 * xdisp.c (BUFFER_POS_REACHED_P): If this is a composition,
6406 consider it a hit if to_charpos is anywhere in the range of the
6407 composed buffer positions.
6409 2011-08-22 Chong Yidong <cyd@stupidchicken.com>
6411 * image.c (gif_load): Don't assume that each subimage has the same
6412 dimensions as the base image. Handle disposal method that is
6413 "undefined" by the gif spec (Bug#9335).
6415 2011-08-20 Chong Yidong <cyd@stupidchicken.com>
6417 * eval.c (Fsignal): Handle `debug' symbol in error handler (Bug#9329).
6418 (Fcondition_case): Document `debug' symbol in error handler.
6420 2011-08-19 Eli Zaretskii <eliz@gnu.org>
6422 * xfaces.c (face_at_buffer_position): Avoid repeated evaluation of
6423 face ID by FACE_FROM_ID, and avoid a crash when mouse is moved
6424 from an Org mode buffer to a Speedbar frame.
6426 * xdisp.c (RECORD_MAX_MIN_POS): If the display element comes from
6427 a composition, take its buffer position from IT->cmp_it.charpos.
6428 Fixes cursor positioning at the beginning of a line that begins
6429 with a composed character.
6431 2011-08-18 Eli Zaretskii <eliz@gnu.org>
6433 * bidi.c (bidi_get_type): If bidi_type_table reports zero as the
6434 character bidirectional type, use STRONG_L instead. Fixes crashes
6435 in a buffer produced by `describe-categories'.
6437 * dispextern.h (struct bidi_it): Move disp_pos and disp_prop_p
6438 members before the level stack, so they would be saved and
6439 restored when copying iterator state. Fixes incorrect reordering
6440 around TABs covered by display properties.
6442 2011-08-18 Andreas Schwab <schwab@linux-m68k.org>
6444 * process.c (Fnetwork_interface_list): Correctly determine buffer size.
6446 2011-08-17 Chong Yidong <cyd@stupidchicken.com>
6448 * eval.c (internal_condition_case, internal_condition_case_1)
6449 (internal_condition_case_2, internal_condition_case_n):
6450 Remove unnecessary aborts (Bug#9081).
6452 2011-08-17 Eli Zaretskii <eliz@gnu.org>
6454 * lread.c (Fload) [DOS_NT]: If `openp' returns -2, but the file
6455 has no `load' handler, try opening the file locally. (Bug#9311)
6457 2011-08-16 Ken Brown <kbrown@cornell.edu>
6459 * gmalloc.c: Expand comment.
6461 2011-08-16 Eli Zaretskii <eliz@gnu.org>
6463 * xdisp.c (set_cursor_from_row): Don't accept a previous candidate
6464 if it fails the cursor_row_p test. Fixes cursor positioning at ZV.
6466 2011-08-16 Ken Brown <kbrown@cornell.edu>
6468 Fix memory allocation problems in Cygwin build (Bug#9273).
6470 * unexcw.c ( __malloc_initialized): Declare external variable.
6471 (fixup_executable): Force the dumped emacs to reinitialize malloc.
6473 * gmalloc.c [CYGWIN] (bss_sbrk_heapbase, bss_sbrk_heapinfo):
6475 (malloc_initialize_1) [CYGWIN]: Prepare for reinitializing the
6477 (_free_internal_nolock) [CYGWIN]: Ignore requests to free storage
6479 [CYGWIN] (special_realloc): New function.
6480 (_realloc_internal_nolock) [CYGWIN]: Use the new function on
6481 requests to realloc storage in the static heap.
6483 2011-08-15 Paul Eggert <eggert@cs.ucla.edu>
6485 * bidi.c (bidi_initialize): Remove unused local.
6487 2011-08-15 Eli Zaretskii <eliz@gnu.org>
6490 * biditype.h: Remove file.
6491 * makefile.w32-in ($(BLD)/bidi.$(O)):
6492 * deps.mk (bidi.o): Remove biditype.h and bidimirror.h.
6494 * dispextern.h: Fix a typo in the comment to bidi_type_t.
6496 * chartab.c: Improve commentary for the uniprop_table API.
6498 * bidi.c (bidi_paragraph_init): Support zero value of
6499 bidi_ignore_explicit_marks_for_paragraph_level.
6500 (bidi_initialize): Use uniprop_table instead of including
6501 biditype.h and bidimirror.h.
6503 * xdisp.c (move_it_in_display_line_to): Don't reset pixel
6504 coordinates of the iterator when restoring from ppos_it.
6507 2011-08-14 Kenichi Handa <handa@m17n.org>
6509 * process.c (create_process): Call setup_process_coding_systems
6510 after the pid of the process is set to -1 (Bug#8162).
6512 2011-08-14 Eli Zaretskii <eliz@gnu.org>
6514 * xdisp.c (move_it_in_display_line_to): Don't invoke
6515 IT_RESET_X_ASCENT_DESCENT when iterator position was restored from
6516 ppos_it. Fixes vertical cursor motion when line beginning is
6517 covered by an image. (Bug#9296)
6519 2011-08-14 Jan Djärv <jan.h.d@swipnet.se>
6521 * nsterm.h (ns_run_ascript): Declare.
6522 (NSAPP_DATA2_RUNASSCRIPT): Define.
6524 * nsfns.m (as_script, as_result, as_status): New static variables.
6525 (ns_run_ascript): New function.
6526 (Fns_do_applescript): Set variables as_*. Make an NSApplicationDefined
6527 event with data2 set to NSAPP_DATA2_RUNASSCRIPT, post it and then start
6528 the event loop. Get status from as_status (Bug#7276).
6530 * nsterm.m (sendEvent): If event is NSApplicationDefined and
6531 data2 is NSAPP_DATA2_RUNASSCRIPT, call ns_run_ascript and then exit
6532 the event loop (Bug#7276).
6534 2011-08-14 Andreas Schwab <schwab@linux-m68k.org>
6536 * gnutls.c (QCgnutls_bootprop_priority)
6537 (QCgnutls_bootprop_trustfiles, QCgnutls_bootprop_keylist)
6538 (QCgnutls_bootprop_crlfiles, QCgnutls_bootprop_callbacks)
6539 (QCgnutls_bootprop_loglevel, QCgnutls_bootprop_hostname)
6540 (QCgnutls_bootprop_min_prime_bits, QCgnutls_bootprop_verify_flags)
6541 (QCgnutls_bootprop_verify_hostname_error)
6542 (QCgnutls_bootprop_callbacks_verify): Rename from
6543 Qgnutls_bootprop_..., all uses changed.
6545 * xfaces.c (QCignore_defface): Rename from Qignore_defface, all
6548 2011-08-14 Paul Eggert <eggert@cs.ucla.edu>
6550 * xfaces.c (Qframe_set_background_mode): Now static.
6551 * dispextern.h (Qframe_set_background_mode): Remove decl.
6553 * process.c (Fnetwork_interface_info): Declare local only if needed.
6555 2011-08-13 Jan Djärv <jan.h.d@swipnet.se>
6557 * process.c: Include ifaddrs.h and net/if_dl.h if available (Bug#8477).
6558 (Fnetwork_interface_list): Allocate in increments of bytes instead
6559 of sizeof (struct ifreq). Iterate over ifconf.ifc_req by counting
6560 bytes (Bug#8477). Count bytes correctly when ifr_addr is a struct
6562 (struct ifflag_def): notrailers is smart on OSX.
6563 (Fnetwork_interface_info): Handle case when ifr_flags is negative.
6564 Get hardware address with getifaddrs if available.
6566 2011-08-12 Eli Zaretskii <eliz@gnu.org>
6568 * xdisp.c (iterate_out_of_display_property): xassert that
6569 IT->position is set to within IT->object's boundaries. Break from
6570 the loop as soon as EOB is reached; avoids infloops in redisplay
6571 when IT->position is set up wrongly due to some bug.
6572 Set IT->current to match the bidi iterator unconditionally.
6573 (push_display_prop): Allow GET_FROM_STRING as IT->method on
6574 entry. Force push_it to save on the stack the current
6575 buffer/string position, to be restored by pop_it. Fix flags in
6576 the iterator structure wrt the object coming from a display
6577 property, as `line-prefix' and `wrap-prefix' are not ``replacing''
6578 properties. (Bug#9284)
6580 2011-08-09 Andreas Schwab <schwab@linux-m68k.org>
6582 * fontset.c (fontset_get_font_group): Add proper type checks.
6585 2011-08-09 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
6587 * unexmacosx.c (print_load_command_name): Add cases LC_FUNCTION_STARTS
6588 and LC_VERSION_MIN_MACOSX.
6589 (copy_linkedit_data) [LC_FUNCTION_STARTS]: New function.
6590 (dump_it) [LC_FUNCTION_STARTS]: Use it.
6592 2011-08-08 Eli Zaretskii <eliz@gnu.org>
6594 * xdisp.c (forward_to_next_line_start): Allow to use the
6595 no-display-properties-and-no-overlays under bidi display.
6596 Set disp_pos in the bidi iterator to avoid searches for display
6597 properties and overlays.
6599 2011-08-08 Chong Yidong <cyd@stupidchicken.com>
6601 * editfns.c (Fset_time_zone_rule): Document relationship with the
6604 * ftfont.c (ftfont_pattern_entity): Copy the extras argument to
6605 the font entity extracted from the cache (Bug#8109).
6607 2011-08-07 Chong Yidong <cyd@stupidchicken.com>
6609 * composite.c (autocmp_chars): Don't reset point. That is done by
6610 restore_point_unwind (Bug#5984).
6612 2011-08-07 Juri Linkov <juri@jurta.org>
6614 * editfns.c (Fformat_time_string): Doc fix, add tag `usage:'
6615 to show the arg `TIME' instead of `TIMEVAL'.
6617 2011-08-06 Eli Zaretskii <eliz@gnu.org>
6619 * xdisp.c (set_cursor_from_row): Fix cursor positioning when a
6620 display property strides EOL and includes a newline, as in
6621 longlines-mode. (Bug#9254)
6622 (move_it_in_display_line_to): Fix vertical-motion in a buffer with
6623 word-wrap under bidirectional display. (Bug#9224)
6625 * bidi.c (bidi_unshelve_cache): Don't reset the cache if JUST_FREE
6626 is non-zero, even if the data buffer is NULL. Fixes a crash in
6627 vertical-motion with longlines-mode. (Bug#9254)
6629 2011-08-05 Eli Zaretskii <eliz@gnu.org>
6631 * bidi.c <bidi_cache_total_alloc>: Now static.
6632 (bidi_initialize): Initialize bidi_cache_total_alloc.
6634 * xdisp.c (display_line): Release buffer allocated for shelved bidi
6637 * bidi.c (bidi_shelve_cache, bidi_unshelve_cache): Track total
6638 amount allocated this far in `bidi_cache_total_alloc'.
6639 (bidi_unshelve_cache): Accept an additional argument JUST_FREE; if
6640 non-zero, only free the data buffer without restoring the cache
6641 contents. All callers changed.
6643 * dispextern.h (bidi_unshelve_cache): Update prototype.
6645 * xdisp.c (SAVE_IT, pos_visible_p, move_it_in_display_line_to)
6646 (move_it_in_display_line, move_it_to)
6647 (move_it_vertically_backward, move_it_by_lines): Replace the call
6648 to xfree to an equivalent call to bidi_unshelve_cache.
6649 (move_it_in_display_line_to): Fix logic of returning
6650 MOVE_POS_MATCH_OR_ZV in the bidi case. (Bug#9224)
6652 2011-08-05 Eli Zaretskii <eliz@gnu.org>
6654 * xdisp.c (set_cursor_from_row): Prefer the candidate glyph that
6655 came from a string character with a `cursor' property. (Bug#9229)
6657 2011-08-04 Jan Djärv <jan.h.d@swipnet.se>
6659 * Makefile.in (LIB_PTHREAD): New variable.
6660 (LIBES): Add LIB_PTHREAD (Bug#9216).
6662 * alloc.c, emacs.c, gmalloc.c, gtkutil.c, keyboard.c, syssignal.h:
6663 Rename HAVE_GTK_AND_PTHREAD to HAVE_PTHREAD (Bug#9216).
6665 2011-08-04 Andreas Schwab <schwab@linux-m68k.org>
6667 * regex.c (re_iswctype): Remove some redundant boolean conversions.
6669 2011-08-04 Jan Djärv <jan.h.d@swipnet.se>
6671 * xterm.c (x_find_topmost_parent): New function.
6672 (x_set_frame_alpha): Find topmost parent window with
6673 x_find_topmost_parent and set the property there also (bug#9181).
6674 (handle_one_xevent): Call x_set_frame_alpha on ReparentNotify.
6676 2011-08-04 Paul Eggert <eggert@cs.ucla.edu>
6678 * callproc.c (Fcall_process): Avoid vfork clobbering
6679 the local vars buffer, coding_systems, current_dir.
6681 2011-08-03 Stefan Monnier <monnier@iro.umontreal.ca>
6683 * keymap.c (Fmake_composed_keymap): Move to subr.el.
6685 2011-08-03 Paul Eggert <eggert@cs.ucla.edu>
6687 * fontset.c (dump_fontset) [FONTSET_DEBUG]: Declare EXTERNALLY_VISIBLE
6688 so that it is not optimized away.
6690 * xdisp.c (compute_display_string_pos): Remove unused local.
6692 2011-08-02 Eli Zaretskii <eliz@gnu.org>
6694 Fix slow cursor motion and scrolling in large buffers with
6695 selective display, like Org Mode buffers. (Bug#9218)
6697 * dispextern.h (struct bidi_it): New member disp_prop_p.
6699 * xdisp.c: Remove one-slot cache of display string positions.
6700 (compute_display_string_pos): Accept an additional argument
6701 DISP_PROP_P; callers changed. Scan at most 5K characters forward
6702 for a display string or property. If found, set DISP_PROP_P
6705 * bidi.c (bidi_fetch_char): Accept an additional argument
6706 DISP_PROP_P, and pass it to compute_display_string_pos.
6707 Only handle text covered by a display string if DISP_PROP_P is returned
6708 non-zero. All callers of bidi_fetch_char changed.
6710 2011-08-02 Stefan Monnier <monnier@iro.umontreal.ca>
6712 * keymap.c (Fdefine_key): Fix Lisp_Object/int mixup; apply some CSE.
6714 2010-12-03 Don March <don@ohspite.net>
6716 * keymap.c (Fdefine_key): Fix non-prefix key error message when
6717 last character M-[char] is translated to ESC [char] (bug#7541).
6719 2011-08-02 Kenichi Handa <handa@m17n.org>
6721 * lisp.h (uniprop_table): Extern it.
6723 * chartab.c (uniprop_table): Make it non-static.
6725 2011-08-01 Eli Zaretskii <eliz@gnu.org>
6727 * xdisp.c (forward_to_next_line_start): Accept additional argument
6728 BIDI_IT_PREV, and store into it the state of the bidi iterator had
6730 (reseat_at_next_visible_line_start): Use the bidi iterator state
6731 returned by forward_to_next_line_start to restore the state of
6732 it->bidi_it after backing up to previous newline. (Bug#9212)
6734 2011-07-30 Andreas Schwab <schwab@linux-m68k.org>
6736 * regex.c (re_comp): Protoize.
6737 (re_exec): Fix return type.
6738 (regexec): Fix type of `ret'. (Bug#9203)
6740 2011-07-28 Paul Eggert <eggert@cs.ucla.edu>
6742 * image.c (check_image_size): Use 1024x1024 if unknown frame (Bug#9189).
6743 This is needed if max-image-size is a floating-point number.
6745 2011-07-28 Andreas Schwab <schwab@linux-m68k.org>
6747 * print.c (print_object): Print empty symbol as ##.
6749 * lread.c (read1): Read ## as empty symbol.
6751 2011-07-28 Alp Aker <alp.tekin.aker@gmail.com>
6753 * nsfns.m (x_set_foreground_color): Set f->foreground_pixel when
6754 setting frame foreground color (Bug#9175).
6755 (x_set_background_color): Likewise.
6757 * nsmenu.m (-setText): Size tooltip dimensions precisely to
6758 contents (Bug#9176).
6759 (EmacsTooltip -init): Remove bezels and add shadows to
6762 * nsterm.m (ns_dumpglyphs_stretch): Avoid overwriting left fringe
6763 or scroll bar (Bug#8470).
6765 * nsfont.m (nsfont_open): Remove assignment to voffset and
6766 unnecessary vars hshink, expand, hd, full_height, min_height.
6767 (nsfont_draw): Use s->ybase as baseline for glyph drawing (Bug#8913).
6769 * nsterm.h (nsfont_info): Remove voffset field.
6771 2011-07-28 Alp Aker <alp.tekin.aker@gmail.com>
6773 Implement strike-through and overline on NextStep (Bug#8863).
6775 * nsfont.m (nsfont_open): Use underline position provided by font,
6776 instead of hard-coded value of 2.
6777 (nsfont_draw): Call ns_draw_text_decoration instead.
6779 * nsterm.h: Add declaration for ns_draw_text_decoration.
6781 * nsterm.m (ns_draw_text_decoration): New function for drawing
6782 underline, overline, and strike-through.
6783 (ns_dumpglyphs_image, ns_dumpglyphs_stretch): Add call to
6784 ns_draw_text_decoration. Change treatment of cursor drawing to
6785 accommodate underlining, etc.
6787 2011-07-28 Eli Zaretskii <eliz@gnu.org>
6789 * buffer.c (init_buffer_once): Set bidi-display-reordering to t by
6792 2011-07-28 Paul Eggert <eggert@cs.ucla.edu>
6794 * alloc.c (memory_full) [!SYNC_INPUT]: Fix signal-related race.
6795 Without this fix, if a signal arrives just after memory fills up,
6796 'malloc' might be invoked reentrantly.
6798 * image.c (x_check_image_size) [!HAVE_X_WINDOWS]: Return 1.
6799 In other words, assume that every image size is allowed, on non-X
6800 hosts. This assumption is probably wrong, but it lets Emacs compile.
6802 2011-07-28 Andreas Schwab <schwab@linux-m68k.org>
6804 * regex.c (re_iswctype): Convert return values to boolean.
6806 2011-07-28 Eli Zaretskii <eliz@fencepost.gnu.org>
6808 * xdisp.c (compute_display_string_pos): Don't use cached display
6809 string position if the buffer had its restriction changed.
6812 2011-07-28 Paul Eggert <eggert@cs.ucla.edu>
6814 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
6816 2011-07-28 Paul Eggert <eggert@cs.ucla.edu>
6818 Integer signedness and overflow and related fixes. (Bug#9079)
6820 * bidi.c: Integer size and overflow fixes.
6821 (bidi_cache_size, bidi_cache_idx, bidi_cache_last_idx)
6822 (bidi_cache_start, bidi_cache_fetch_state, bidi_cache_search)
6823 (bidi_cache_find_level_change, bidi_cache_ensure_space)
6824 (bidi_cache_iterator_state, bidi_cache_find, bidi_cache_start_stack)
6825 (bidi_find_other_level_edge):
6826 Use ptrdiff_t instead of EMACS_INT where either will do.
6827 This works better on 32-bit hosts configured --with-wide-int.
6828 (bidi_cache_ensure_space): Check for size-calculation overflow.
6829 Use % rather than repeated addition, for better worst-case speed.
6830 Don't set bidi_cache_size until after xrealloc returns, because it
6832 (bidi_dump_cached_states): Use ptrdiff_t, not int, to avoid overflow.
6833 (bidi_cache_ensure_space): Also check that the bidi cache size
6834 does not exceed that of the largest Lisp string or buffer. See Eli
6835 Zaretskii in <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9079#29>.
6837 * alloc.c (__malloc_size_t): Remove.
6838 All uses replaced by size_t. See Andreas Schwab's note
6839 <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9079#8>.
6841 * image.c: Improve checking for integer overflow.
6842 (check_image_size): Assume that f is nonnull, since
6843 it is always nonnull in practice. This is one less thing to
6844 worry about when checking for integer overflow later.
6845 (x_check_image_size): New function, which checks for integer
6846 overflow issues inside X.
6847 (x_create_x_image_and_pixmap, xbm_read_bitmap_data): Use it.
6848 This removes the need for a memory_full check.
6849 (xbm_image_p): Rewrite to avoid integer multiplication overflow.
6850 (Create_Pixmap_From_Bitmap_Data, xbm_load): Use x_check_image_size.
6851 (xbm_read_bitmap_data): Change locals back to 'int', since
6852 their values must fit in 'int'.
6853 (xpm_load_image, png_load, tiff_load):
6854 Invoke x_create_x_image_and_pixmap earlier,
6855 to avoid much needless work if the image is too large.
6856 (tiff_load): Treat overly large images as if
6857 x_create_x_image_and_pixmap failed, not as malloc failures.
6858 (gs_load): Use x_check_image_size.
6860 * gtkutil.c: Omit integer casts.
6861 (xg_get_pixbuf_from_pixmap): Remove unnecessary cast.
6862 (xg_set_toolkit_scroll_bar_thumb): Rewrite to avoid need for cast.
6864 * image.c (png_load): Don't assume height * row_bytes fits in 'int'.
6866 * xfaces.c (Fbitmap_spec_p): Fix integer overflow bug.
6867 Without this fix, (bitmap-spec-p '(34359738368 1 "x"))
6868 would wrongly return t on a 64-bit host.
6870 * dispnew.c (init_display): Use *_RANGE_OVERFLOW macros.
6871 The plain *_OVERFLOW macros run afoul of GCC bug 49705
6872 <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=49705>
6873 and therefore cause GCC to emit a bogus diagnostic in some cases.
6875 * image.c: Integer signedness and overflow and related fixes.
6876 This is not an exhaustive set of fixes, but it's time to
6877 record what I've got.
6878 (lookup_pixel_color, check_image_size): Remove redundant decls.
6879 (check_image_size): Don't assume that arbitrary EMACS_INT values
6880 fit in 'int', or that arbitrary 'double' values fit in 'int'.
6881 (x_alloc_image_color, x_create_x_image_and_pixmap, png_load)
6882 (tiff_load, imagemagick_load_image):
6883 Check for overflow in size calculations.
6884 (x_create_x_image_and_pixmap): Remove unnecessary test for
6885 xmalloc returning NULL; that can't happen.
6886 (xbm_read_bitmap_data): Don't assume sizes fit into 'int'.
6887 (xpm_color_bucket): Use better integer hashing function.
6888 (xpm_cache_color): Don't possibly over-allocate memory.
6889 (struct png_memory_storage, tiff_memory_source, tiff_seek_in_memory)
6890 (gif_memory_source):
6891 Use ptrdiff_t, not int or size_t, to record sizes.
6892 (png_load): Don't assume values greater than 2**31 fit in 'int'.
6893 (our_stdio_fill_input_buffer): Prefer ptrdiff_t to size_t when
6894 either works, as we prefer signed integers.
6895 (tiff_read_from_memory, tiff_write_from_memory):
6896 Return tsize_t, not size_t, since that's what the TIFF API wants.
6897 (tiff_read_from_memory): Don't fail simply because the read would
6898 go past EOF; instead, return a short read.
6899 (tiff_load): Omit no-longer-needed casts.
6900 (Fimagemagick_types): Don't assume size fits into 'int'.
6902 Improve hashing quality when configured --with-wide-int.
6903 * fns.c (hash_string): New function, taken from sxhash_string.
6904 Do not discard information about ASCII character case; this
6905 discarding is no longer needed.
6906 (sxhash-string): Use it. Change sig to match it. Caller changed.
6907 * lisp.h: Declare it.
6908 * lread.c (hash_string): Remove, since we now use fns.c's version.
6909 The fns.c version returns a wider integer if --with-wide-int is
6910 specified, so this should help the quality of the hashing a bit.
6912 * emacs.c: Integer overflow minor fix.
6913 (heap_bss_diff): Now uprintmax_t, not unsigned long. All used changed.
6914 Define only if GNU_LINUX.
6915 (main, Fdump_emacs): Set and use heap_bss_diff only if GNU_LINUX.
6917 * dispnew.c: Integer signedness and overflow fixes.
6918 Remove unnecessary forward decls, that were a maintenance hassle.
6919 (history_tick): Now uprintmax_t, so it's more likely to avoid overflow.
6921 (adjust_glyph_matrix, realloc_glyph_pool, adjust_frame_message_buffer)
6922 (scrolling_window): Use ptrdiff_t, not int, for byte count.
6923 (prepare_desired_row, line_draw_cost):
6924 Use int, not unsigned, where either works.
6925 (save_current_matrix, restore_current_matrix):
6926 Use ptrdiff_t, not size_t, where either works.
6927 (init_display): Check for overflow more accurately, and without
6928 relying on undefined behavior.
6930 * editfns.c (pWIDE, pWIDElen, signed_wide, unsigned_wide):
6931 Remove, replacing with the new symbols in lisp.h. All uses changed.
6932 * fileio.c (make_temp_name):
6933 * filelock.c (lock_file_1, lock_file):
6934 * xdisp.c (message_dolog):
6935 Don't assume PRIdMAX etc. works; this isn't portable to pre-C99 hosts.
6936 Use pMd etc. instead.
6937 * lisp.h (printmax_t, uprintmax_t, pMd, pMu): New types and macros,
6938 replacing the pWIDE etc. symbols removed from editfns.c.
6940 * keyboard.h (num_input_events): Now uintmax_t.
6941 This is (very slightly) less likely to mess up due to wraparound.
6944 * buffer.c: Integer signedness fixes.
6945 (alloc_buffer_text, enlarge_buffer_text):
6946 Use ptrdiff_t rather than size_t when either will do, as we prefer
6949 * alloc.c: Integer signedness and overflow fixes.
6950 Do not impose an arbitrary 32-bit limit on malloc sizes when debugging.
6951 (__malloc_size_t): Default to size_t, not to int.
6952 (pure_size, pure_bytes_used_before_overflow, stack_copy_size)
6953 (Fgarbage_collect, mark_object_loop_halt, mark_object):
6954 Prefer ptrdiff_t to size_t when either would do, as we prefer
6956 (XMALLOC_OVERRUN_CHECK_OVERHEAD): New macro.
6957 (xmalloc_overrun_check_header, xmalloc_overrun_check_trailer):
6958 Now const. Initialize with values that are in range even if char
6960 (XMALLOC_PUT_SIZE, XMALLOC_GET_SIZE): Remove, replacing with ...
6961 (xmalloc_put_size, xmalloc_get_size): New functions. All uses changed.
6962 These functions do the right thing with sizes > 2**32.
6963 (check_depth): Now ptrdiff_t, not int.
6964 (overrun_check_malloc, overrun_check_realloc, overrun_check_free):
6965 Adjust to new way of storing sizes. Check for size overflow bugs
6967 (STRING_BYTES_MAX): Adjust to new overheads. The old code was
6968 slightly wrong anyway, as it missed one instance of
6969 XMALLOC_OVERRUN_CHECK_OVERHEAD.
6970 (refill_memory_reserve): Omit needless cast to size_t.
6971 (mark_object_loop_halt): Mark as externally visible.
6973 * xselect.c: Integer signedness and overflow fixes.
6974 (Fx_register_dnd_atom, x_handle_dnd_message):
6975 Use ptrdiff_t, not size_t, since we prefer signed.
6976 (Fx_register_dnd_atom): Check for ptrdiff_t (and size_t) overflow.
6977 * xterm.h (struct x_display_info): Use ptrdiff_t, not size_t, for
6978 x_dnd_atoms_size and x_dnd_atoms_length.
6980 * doprnt.c: Prefer signed to unsigned when either works.
6982 * doprnt.c (doprnt):
6984 * xdisp.c (vmessage):
6985 Use ptrdiff_t, not size_t, when using or implementing doprnt,
6986 since the sizes cannot exceed ptrdiff_t bounds anyway, and we
6987 prefer signed arithmetic to avoid comparison confusion.
6988 * doprnt.c (doprnt): Avoid a "+ 1" that can't overflow,
6989 but is a bit tricky.
6991 Assume freestanding C89 headers, string.h, stdlib.h.
6992 * data.c, doprnt.c, floatfns.c, print.c:
6993 Include float.h unconditionally.
6994 * gmalloc.c: Assume C89-at-least behavior for preprocessor,
6995 limits.h, stddef.h, string.h. Use memset instead of 'flood'.
6996 * regex.c: Likewise for stddef.h, string.h.
6997 (ISASCII): Remove; can assume it returns 1 now. All uses removed.
6998 * s/aix4-2.h (HAVE_STRING_H): Remove obsolete undef.
6999 * s/ms-w32.h (HAVE_LIMITS_H, HAVE_STRING_H, HAVE_STDLIB_H)
7000 (STDC_HEADERS): Remove obsolete defines.
7001 * sysdep.c: Include limits.h unconditionally.
7003 Assume support for memcmp, memcpy, memmove, memset.
7004 * lisp.h, sysdep.c (memcmp, memcpy, memmove, memset):
7005 * regex.c (memcmp, memcpy):
7006 Remove; we assume C89 now.
7008 * gmalloc.c (memcpy, memset, memmove): Remove; we assume C89 now.
7009 (__malloc_safe_bcopy): Remove; no longer needed.
7011 * lisp.h (struct vectorlike_header, struct Lisp_Subr): Signed sizes.
7012 Use EMACS_INT, not EMACS_UINT, for sizes. The code works equally
7013 well either way, and we prefer signed to unsigned.
7015 2011-07-27 Lars Magne Ingebrigtsen <larsi@gnus.org>
7017 * gnutls.c (emacs_gnutls_read): Don't message anything if the peer
7018 closes the connection while we're reading (bug#9182).
7020 2011-07-25 Jan Djärv <jan.h.d@swipnet.se>
7022 * nsmenu.m (ns_popup_dialog): Add an "ok" button if no buttons
7023 are specified (Bug#9168).
7025 2011-07-25 Paul Eggert <eggert@cs.ucla.edu>
7027 * bidi.c (bidi_dump_cached_states): Fix printf format mismatch.
7028 Found by GCC static checking and --with-wide-int on a 32-bit host.
7030 2011-07-25 Eli Zaretskii <eliz@gnu.org>
7032 * xdisp.c (compute_display_string_pos): Fix logic of caching
7033 previous display string position. Initialize cached_prev_pos to
7034 -1. Fixes slow-down at the beginning of a buffer.
7036 2011-07-24 Eli Zaretskii <eliz@gnu.org>
7038 * xfaces.c (check_lface_attrs) [HAVE_WINDOW_SYSTEM]: Allow `nil'
7039 for attrs[LFACE_FONTSET_INDEX].
7041 2011-07-23 Paul Eggert <eggert@cs.ucla.edu>
7043 * xml.c (parse_region): Remove unused local
7044 that was recently introduced.
7046 2011-07-23 Eli Zaretskii <eliz@gnu.org>
7048 * xfns.c (unwind_create_frame) [GLYPH_DEBUG]: Adapt to changes in
7049 2008-02-22T17:42:09Z!monnier@iro.umontreal.ca.
7051 * xdisp.c (move_it_in_display_line_to): Record the best matching
7052 position for TO_CHARPOS while scanning the line, and restore it on
7053 exit if none of the characters scanned was an exact match.
7054 Fixes vertical-motion and pos-visible-in-window-p under bidi redisplay
7055 when exact match is impossible due to invisible text, and the
7056 lines are truncated.
7058 2011-07-23 Jan Djärv <jan.h.d@swipnet.se>
7060 * nsterm.m (initFrameFromEmacs): Set NSTitledWindowMask in styleMask
7063 2011-07-22 Eli Zaretskii <eliz@gnu.org>
7065 Fix a significant slow-down of cursor motion with C-n, C-p,
7066 C-f/C-b, and C-v/M-v that couldn't keep up with keyboard
7067 auto-repeat under bidi redisplay in fontified buffers.
7068 * xdisp.c (compute_stop_pos_backwards): New function.
7069 (next_element_from_buffer): Call compute_stop_pos_backwards to
7070 find a suitable prev_stop when we find ourselves before
7072 (reseat): Don't look for prev_stop, as that could mean a very long
7074 <cached_disp_pos, cached_disp_buffer, cached_disp_modiff>
7075 <cached_disp_overlay_modiff>: Cache for last found display string
7077 (compute_display_string_pos): Return the cached position if asked
7078 about the same buffer in the same area of character positions, and
7079 the buffer wasn't changed since the time the display string
7080 position was cached.
7082 2011-07-22 Eli Zaretskii <eliz@gnu.org>
7084 * xdisp.c (rows_from_pos_range): Don't ignore glyphs whose object
7085 is an integer, which is important for empty lines. (Bug#9149)
7087 2011-07-22 Chong Yidong <cyd@stupidchicken.com>
7089 * frame.c (Fmodify_frame_parameters): In tty case, update the
7090 default face if necessary (Bug#4238).
7092 2011-07-21 Chong Yidong <cyd@stupidchicken.com>
7094 * editfns.c (Fstring_to_char): No need to explain what a character
7095 is in the docstring (Bug#6576).
7097 2011-07-20 Lars Magne Ingebrigtsen <larsi@gnus.org>
7099 * xml.c (parse_region): Make sure we always return a tree.
7101 2011-07-20 HAMANO Kiyoto <khiker.mail@gmail.com>
7103 * xml.c (parse_region): If a document contains only comments,
7106 2011-07-20 Lars Magne Ingebrigtsen <larsi@gnus.org>
7108 * xml.c (make_dom): Return comments, too.
7110 2011-07-19 Paul Eggert <eggert@cs.ucla.edu>
7113 See http://lists.gnu.org/archive/html/emacs-devel/2011-07/msg00688.html
7114 and the surrounding thread.
7115 * minibuf.c (read_minibuf_noninteractive): Rewrite to use getchar
7116 rather than fgets, and retry after EINTR. Otherwise, 'emacs
7117 --batch -f byte-compile-file' fails on OpenBSD if an inactivity
7119 * s/openbsd.h (BROKEN_SIGIO): Define.
7120 * unexelf.c (unexec) [__OpenBSD__]:
7121 Don't update the .mdebug section of the Alpha COFF symbol table.
7123 2011-07-19 Lars Magne Ingebrigtsen <larsi@gnus.org>
7125 * lread.c (syms_of_lread): Clarify when `lexical-binding' is used
7128 2011-07-18 Paul Eggert <eggert@cs.ucla.edu>
7130 * fileio.c (Fcopy_file) [!MSDOS]: Tighten created file's mask.
7131 This fixes some race conditions on the permissions of any newly
7134 * alloc.c (valid_pointer_p): Use pipe, not open.
7135 This fixes some permissions issues when debugging.
7137 * fileio.c (Fcopy_file): Adjust mode if fchown fails. (Bug#9002)
7138 If fchown fails to set both uid and gid, try to set just gid,
7139 as that is sometimes allowed. Adjust the file's mode to eliminate
7140 setuid or setgid bits that are inappropriate if fchown fails.
7142 2011-07-18 Stefan Monnier <monnier@iro.umontreal.ca>
7144 * xdisp.c (next_element_from_string, next_element_from_buffer): Use EQ
7145 to compare Lisp_Objects.
7146 * gnutls.c (syms_of_gnutls): Rename Vgnutls_log_level to
7147 global_gnutls_log_level, don't mistake it for a Lisp_Object.
7148 (init_gnutls_functions, emacs_gnutls_handle_error): Fix up uses.
7150 2011-07-17 Andreas Schwab <schwab@linux-m68k.org>
7152 * lread.c (read_integer): Unread even EOF character.
7153 (read1): Likewise. Properly record start position of symbol.
7155 * lread.c (read1): Read `#:' as empty uninterned symbol if no
7156 symbol character follows.
7158 2011-07-17 Paul Eggert <eggert@cs.ucla.edu>
7160 * fileio.c (Fcopy_file): Pacify gcc re fchown. (Bug#9002)
7161 This works around a problem with the previous change to Fcopy_file.
7162 Recent glibc declares fchown with __attribute__((warn_unused_result)),
7163 and without this change, GCC might complain about discarding
7164 fchown's return value.
7166 2011-07-16 Juanma Barranquero <lekktu@gmail.com>
7168 * makefile.w32-in (GLOBAL_SOURCES): Add gnutls.c (followup to bug#9059).
7170 2011-07-16 Paul Eggert <eggert@cs.ucla.edu>
7172 * fileio.c (Fcopy_file): Don't diagnose fchown failures. (Bug#9002)
7174 2011-07-16 Lars Magne Ingebrigtsen <larsi@gnus.org>
7176 * gnutls.c (syms_of_gnutls): Define `gnutls-log-level' here, since
7177 it's used from the C level.
7179 * process.c: Use the same condition for POLL_FOR_INPUT in both
7180 keyboard.c and process.c (bug#1858).
7182 2011-07-09 Lawrence Mitchell <wence@gmx.li>
7184 * gnutls.c (Qgnutls_bootprop_min_prime_bits): New variable.
7185 (Fgnutls_boot): Use it.
7187 2011-07-15 Andreas Schwab <schwab@linux-m68k.org>
7189 * doc.c (Fsubstitute_command_keys): Revert last change.
7191 2011-07-15 Lars Magne Ingebrigtsen <larsi@gnus.org>
7193 * doc.c (Fsubstitute_command_keys): Clarify that \= really only
7194 quotes the next character, and doesn't affect other longer
7195 sequences (bug#8935).
7197 * lread.c (syms_of_lread): Clarify that is isn't only
7198 `eval-buffer' and `eval-defun' that's affected by
7199 `lexical-binding' (bug#8460).
7201 2011-07-15 Eli Zaretskii <eliz@gnu.org>
7203 * xdisp.c (move_it_in_display_line_to): Fix vertical motion with
7204 bidi redisplay when a line includes both an image and is truncated.
7206 2011-07-14 Paul Eggert <eggert@cs.ucla.edu>
7208 Fix minor problems found by static checking.
7209 * bidi.c (bidi_cache_size): Now EMACS_INT, not size_t.
7210 (elsz): Now a signed constant, not a size_t var. We prefer signed
7211 types to unsigned, to avoid integer comparison confusion. Without
7212 this change, GCC 4.6.1 with -Wunsafe-loop-optimizations complains
7213 "cannot optimize loop, the loop counter may overflow", a symptom
7215 * indent.c (Fvertical_motion): Mark locals as initialized.
7216 * xdisp.c (reseat_to_string): Fix pointer signedness issue.
7218 2011-07-14 Lars Magne Ingebrigtsen <larsi@gnus.org>
7220 * search.c (Fre_search_backward): Mention `case-fold-search' in
7221 all the re_search_* functions (bug#8138).
7223 * keyboard.c (Fopen_dribble_file): Document when the file is
7226 2011-07-14 Eli Zaretskii <eliz@gnu.org>
7228 * bidi.c (bidi_dump_cached_states): Fix format of displaying
7231 Support bidi reordering of display and overlay strings.
7232 * xdisp.c (compute_display_string_pos)
7233 (compute_display_string_end): Accept additional argument STRING.
7234 (init_iterator, reseat_1): Initialize bidi_it->string.s to NULL.
7235 (reseat_to_string): Initialize bidi_it->string.s and
7236 bidi_it->string.schars.
7237 (Fcurrent_bidi_paragraph_direction): Initialize itb.string.s to
7238 NULL (avoids a crash in bidi_paragraph_init).
7239 Initialize itb.string.lstring.
7240 (init_iterator): Call bidi_init_it only of a valid
7241 buffer position was specified. Initialize paragraph_embedding to
7243 (reseat_to_string): Initialize the bidi iterator.
7244 (display_string): If we need to ignore text properties of
7245 LISP_STRING, set IT->stop_charpos to IT->end_charpos. (The
7246 original value of -1 will not work with bidi.)
7247 (compute_display_string_pos): First arg is now struct
7248 `text_pos *'; all callers changed. Support display properties on
7250 (compute_display_string_end): Support display properties on Lisp
7252 (init_iterator, reseat_1, reseat_to_string): Initialize the
7253 string.bufpos member to 0 (zero, for compatibility with IT_CHARPOS
7254 when iterating on a string not from display properties).
7255 (compute_display_string_pos, compute_display_string_end):
7256 Fix calculation of the object to scan. Fixes an error when using
7258 (next_element_from_buffer): Don't abort when IT_CHARPOS is before
7259 base_level_stop; instead, set base_level_stop to BEGV.
7260 Fixes crashes in vertical-motion.
7261 (next_element_from_buffer): Improve commentary for when
7262 the iterator is before prev_stop.
7263 (init_iterator): Initialize bidi_p from the default value of
7264 bidi-display-reordering, not from buffer-local value. Use the
7265 buffer-local value only if initializing for buffer iteration.
7266 (handle_invisible_prop): Support invisible properties on strings
7267 that are being bidi-reordered.
7268 (set_iterator_to_next): Support bidi reordering of C strings and
7270 (next_element_from_string): Support bidi reordering of Lisp
7272 (handle_stop_backwards): Support Lisp strings as well.
7273 (display_string): Support display of R2L glyph rows.
7274 Use IT_STRING_CHARPOS when displaying from a Lisp string.
7275 (init_iterator): Don't initialize it->bidi_p for strings
7277 (reseat_to_string): Initialize it->bidi_p for strings here.
7278 (next_element_from_string, next_element_from_c_string)
7279 (next_element_from_buffer): Add xassert's for correspondence
7280 between IT's object being iterated and it->bidi_it.string
7282 (face_before_or_after_it_pos): Support bidi iteration.
7283 (next_element_from_c_string): Handle the case of the first string
7284 character that is not the first one in the visual order.
7285 (get_visually_first_element): New function, refactored from common
7286 parts of next_element_from_buffer, next_element_from_string, and
7287 next_element_from_c_string.
7288 (tool_bar_lines_needed, redisplay_tool_bar)
7289 (display_menu_bar): Force left-to-right direction. Add a FIXME
7290 comment for making that be controlled by a user option.
7291 (push_it, pop_it): Save and restore the state of the
7292 bidi iterator. Save and restore the bidi_p flag.
7293 (pop_it): Iterate out of display property for string iteration as
7295 (iterate_out_of_display_property): Support iteration over strings.
7296 (handle_single_display_spec): Set up it->bidi_it for iteration
7297 over a display string, and call bidi_init_it.
7298 (handle_single_display_spec, next_overlay_string)
7299 (get_overlay_strings_1, push_display_prop): Set up the bidi
7300 iterator for displaying display or overlay strings.
7301 (forward_to_next_line_start): Don't use the shortcut if
7303 (back_to_previous_visible_line_start): If handle_display_prop
7304 pushed the iterator stack, restore the internal state of the bidi
7305 iterator by calling bidi_pop_it same number of times.
7306 (reseat_at_next_visible_line_start): If ON_NEWLINE_P is non-zero,
7307 and we are bidi-iterating, don't decrement the iterator position;
7308 instead, set the first_elt flag in the bidi iterator, to produce
7310 (reseat_1): Remove redundant setting of string_from_display_prop_p.
7311 (push_display_prop): xassert that we are iterating a buffer.
7312 (push_it, pop_it): Save and restore paragraph_embedding member.
7313 (handle_single_display_spec, next_overlay_string)
7314 (get_overlay_strings_1, reseat_1, reseat_to_string)
7315 (push_display_prop): Set up the `unibyte' member of bidi_it.string
7316 correctly. Don't assume unibyte strings are not bidi-reordered.
7317 (compute_display_string_pos)
7318 (compute_display_string_end): Fix handling the case of C string.
7319 (push_it, pop_it): Save and restore from_disp_prop_p.
7320 (handle_single_display_spec, push_display_prop): Set the
7321 from_disp_prop_p flag.
7322 (get_overlay_strings_1): Reset the from_disp_prop_p flag.
7323 (pop_it): Call iterate_out_of_display_property only if we are
7324 popping after iteration over a string that came from a display
7325 property. Fix a typo in popping stretch info. Add an assertion
7326 for verifying that the iterator position is in sync with the bidi
7328 (handle_single_display_spec, get_overlay_strings_1)
7329 (push_display_prop): Fix initialization of paragraph direction for
7330 string when that of the parent object is not yet determined.
7331 (reseat_1): Call bidi_init_it to resync the bidi
7332 iterator with IT's position. (Bug#7616)
7333 (find_row_edges): If ROW->start.pos gives position
7334 smaller than min_pos, use it as ROW->minpos. (Bug#7616)
7335 (handle_stop, back_to_previous_visible_line_start, reseat_1):
7336 Reset the from_disp_prop_p flag.
7337 (SAVE_IT, RESTORE_IT): New macros.
7338 (pos_visible_p, face_before_or_after_it_pos)
7339 (back_to_previous_visible_line_start)
7340 (move_it_in_display_line_to, move_it_in_display_line)
7341 (move_it_to, move_it_vertically_backward, move_it_by_lines)
7342 (try_scrolling, redisplay_window, display_line): Use them when
7343 saving a temporary copy of the iterator and restoring it back.
7344 (back_to_previous_visible_line_start, reseat_1)
7345 (init_iterator): Empty the bidi cache "stack".
7346 (move_it_in_display_line_to): If iterator ended up at
7347 EOL, but we never saw any buffer positions smaller than
7348 to_charpos, return MOVE_POS_MATCH_OR_ZV. Fixes vertical cursor
7349 motion in bidi-reordered lines.
7350 (move_it_in_display_line_to): Record prev_method and prev_pos
7351 immediately before the call to set_iterator_to_next. Fixes cursor
7352 motion in bidi-reordered lines with stretch glyphs and strings
7353 displayed in margins. (Bug#8133) (Bug#8867)
7354 Return MOVE_POS_MATCH_OR_ZV only if iterator position is past
7356 (pos_visible_p): Support positions in bidi-reordered lines.
7357 Save and restore bidi cache.
7359 * bidi.c (bidi_level_of_next_char): clen should be EMACS_NT, not int.
7360 (bidi_paragraph_info): Delete unused struct.
7361 (bidi_cache_idx, bidi_cache_last_idx): Declare EMACS_INT.
7362 (bidi_cache_start): New variable.
7363 (bidi_cache_reset): Reset bidi_cache_idx to bidi_cache_start, not
7365 (bidi_cache_fetch_state, bidi_cache_search)
7366 (bidi_cache_find_level_change, bidi_cache_iterator_state)
7367 (bidi_cache_find, bidi_peek_at_next_level)
7368 (bidi_level_of_next_char, bidi_find_other_level_edge)
7369 (bidi_move_to_visually_next): Compare cache index with
7370 bidi_cache_start rather than with zero.
7371 (bidi_fetch_char): Accept new argument STRING; all callers
7372 changed. Support iteration over a string. Support strings with
7373 display properties. Support unibyte strings. Fix the type of
7374 `len' according to what STRING_CHAR_AND_LENGTH expects.
7375 (bidi_paragraph_init, bidi_resolve_explicit_1)
7376 (bidi_resolve_explicit, bidi_resolve_weak)
7377 (bidi_level_of_next_char, bidi_move_to_visually_next):
7378 Support iteration over a string.
7379 (bidi_set_sor_type, bidi_resolve_explicit_1)
7380 (bidi_resolve_explicit, bidi_type_of_next_char): ignore_bn_limit
7381 can now be zero (for strings); special values 0 and -1 were
7382 changed to -1 and -2, respectively.
7383 (bidi_char_at_pos): New function.
7384 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak):
7385 Call it instead of FETCH_MULTIBYTE_CHAR.
7386 (bidi_move_to_visually_next): Abort if charpos or bytepos were not
7387 initialized to valid values.
7388 (bidi_init_it): Don't initialize charpos and bytepos with invalid
7390 (bidi_level_of_next_char): Allow the sentinel "position" to pass
7391 the test for valid cached positions. Fix the logic for looking up
7392 the sentinel state in the cache. GCPRO the Lisp string we are
7394 (bidi_push_it, bidi_pop_it): New functions.
7395 (bidi_initialize): Initialize the bidi cache start stack pointer.
7396 (bidi_cache_ensure_space): New function, refactored from part of
7397 bidi_cache_iterator_state. Don't assume the required size is just
7398 one BIDI_CACHE_CHUNK away.
7399 (bidi_cache_start_stack, bidi_push_it): Use IT_STACK_SIZE.
7400 (bidi_count_bytes, bidi_char_at_pos): New functions.
7401 (bidi_cache_search): Don't assume bidi_cache_last_idx is
7402 always valid if bidi_cache_idx is valid.
7403 (bidi_cache_find_level_change): xassert that bidi_cache_last_idx
7404 is valid if it's going to be used.
7405 (bidi_shelve_cache, bidi_unshelve_cache): New functions.
7406 (bidi_cache_fetch_state, bidi_cache_search)
7407 (bidi_cache_find_level_change, bidi_cache_ensure_space)
7408 (bidi_cache_iterator_state, bidi_cache_find)
7409 (bidi_find_other_level_edge, bidi_cache_start_stack):
7410 All variables related to cache indices are now EMACS_INT.
7412 * dispextern.h (struct bidi_string_data): New structure.
7413 (struct bidi_it): New member `string'. Make flag members be 1-bit
7414 fields, and put them last in the struct.
7415 (compute_display_string_pos, compute_display_string_end):
7417 (bidi_push_it, bidi_pop_it): Add prototypes.
7418 (struct iterator_stack_entry): New members bidi_p,
7419 paragraph_embedding, and from_disp_prop_p.
7420 (struct it): Member bidi_p is now a bit field 1 bit wide.
7421 (bidi_shelve_cache, bidi_unshelve_cache):
7424 * .gdbinit (xvectype, xvector, xcompiled, xchartable, xboolvector)
7425 (xpr, xfont, xbacktrace): Use "header.size" when accessing vectors
7426 and vector-like objects.
7428 * dispnew.c (buffer_posn_from_coords): Save and restore the bidi
7429 cache around display iteration.
7431 * window.c (Fwindow_end, window_scroll_pixel_based)
7432 (displayed_window_lines, Frecenter): Save and restore the bidi
7433 cache around display iteration.
7435 2011-07-14 Lars Magne Ingebrigtsen <larsi@gnus.org>
7437 * editfns.c (Fdelete_region): Clarify the use of the named
7438 parameters (bug#6788).
7440 2011-07-14 Martin Rudalics <rudalics@gmx.at>
7442 * indent.c (Fvertical_motion): Set and restore w->pointm when
7443 saving and restoring the window's buffer (Bug#9006).
7445 2011-07-13 Lars Magne Ingebrigtsen <larsi@gnus.org>
7447 * editfns.c (Fstring_to_char): Clarify just what is returned
7448 (bug#6576). Text by Eli Zaretskii.
7450 2011-07-13 Juanma Barranquero <lekktu@gmail.com>
7452 * gnutls.c (init_gnutls_functions): Honor gnutls_log_level (bug#9059).
7454 2011-07-13 Eli Zaretskii <eliz@gnu.org>
7456 * buffer.c (mmap_find): Fix a typo.
7458 2011-07-13 Johan Bockgård <bojohan@gnu.org>
7460 Fix execution of x selection hooks.
7461 * xselect.c (Qx_lost_selection_functions)
7462 (Qx_sent_selection_functions): New vars.
7463 (syms_of_xselect): DEFSYM them.
7464 (x_handle_selection_request): Pass Qx_sent_selection_functions
7465 rather than Vx_sent_selection_functions to Frun_hook_with_args.
7466 (x_handle_selection_clear,x_clear_frame_selections):
7467 Pass Qx_lost_selection_functions rather than
7468 Vx_lost_selection_functions to Frun_hook_with_args.
7470 2011-07-13 Paul Eggert <eggert@cs.ucla.edu>
7472 * buffer.c (Fget_buffer_create): Initialize inhibit_shrinking.
7473 The old code sometimes used this field without initializing it.
7475 * alloc.c (gc_sweep): Don't read past end of array.
7476 In theory, the old code could also have corrupted Emacs internals,
7477 though it'd be very unlikely.
7479 2011-07-12 Andreas Schwab <schwab@linux-m68k.org>
7481 * character.c (Fcharacterp): Don't advertise optional ignored
7482 argument. (Bug#4026)
7484 2011-07-12 Lars Magne Ingebrigtsen <larsi@gnus.org>
7486 * keymap.c (syms_of_keymap): Clarify that "modifier" is "modifier
7489 * window.c (Fset_window_start): Doc fix (bug#4199).
7490 (Fset_window_hscroll): Ditto.
7492 2011-07-12 Paul Eggert <eggert@cs.ucla.edu>
7494 Fix minor new problems caught by GCC 4.6.1.
7495 * term.c (init_tty): Remove unused local.
7496 * xsettings.c (store_monospaced_changed): Define this function only
7497 if (defined HAVE_GSETTINGS || defined HAVE_GCONF), as it's
7500 2011-07-12 Chong Yidong <cyd@stupidchicken.com>
7502 * xdisp.c (Vresize_mini_windows): Minor doc fix (Bug#3300).
7504 2011-07-11 Lars Magne Ingebrigtsen <larsi@gnus.org>
7506 * xdisp.c (syms_of_xdisp): Make it explicit that the mini-windows
7507 are the mini-buffer and the echo area (bug#3320).
7509 * term.c (init_tty): Remove support for supdup, c10 and perq
7510 terminals, which are no longer supported (bug#1482).
7512 2011-07-10 Johan Bockgård <bojohan@gnu.org>
7514 * xdisp.c (Ftool_bar_lines_needed): Fix WINDOWP check.
7516 2011-07-10 Jan Djärv <jan.h.d@swipnet.se>
7518 * xmenu.c (menu_highlight_callback): Only pass frame to show_help_event
7519 for non-popups (Bug#3642).
7521 2011-07-10 Andreas Schwab <schwab@linux-m68k.org>
7523 * alloc.c (reset_malloc_hooks): Protoize.
7524 * buffer.c (mmap_init, mmap_find, mmap_free_1, mmap_enlarge)
7525 (mmap_set_vars, mmap_alloc, mmap_free, mmap_realloc): Likewise.
7526 * cm.c (losecursor): Likewise.
7527 * data.c (fmod): Likewise.
7528 * dispnew.c (swap_glyphs_in_rows): Likewise.
7529 * emacs.c (memory_warning_signal): Likewise.
7530 * floatfns.c (float_error): Likewise.
7531 * font.c (check_gstring, check_otf_features, otf_tag_symbol)
7532 (otf_open, font_otf_capability, generate_otf_features)
7533 (font_otf_DeviceTable, font_otf_ValueRecord, font_otf_Anchor):
7535 * image.c (pbm_read_file): Likewise.
7536 * indent.c (string_display_width): Likewise.
7537 * intervals.c (check_for_interval, search_for_interval)
7538 (inc_interval_count, count_intervals, root_interval)
7539 (adjust_intervals_for_insertion, make_new_interval): Likewise.
7540 * lread.c (defalias): Likewise.
7541 * ralloc.c (r_alloc_check): Likewise.
7542 * regex.c (set_image_of_range_1, set_image_of_range)
7543 (regex_grow_registers): Likewise.
7544 * sysdep.c (strerror): Likewise.
7545 * termcap.c (valid_filename_p, tprint, main): Likewise.
7546 * tparam.c (main): Likewise.
7547 * unexhp9k800.c (run_time_remap, save_data_space)
7548 (update_file_ptrs, read_header, write_header, calculate_checksum)
7549 (copy_file, copy_rest, display_header): Likewise.
7550 * widget.c (mark_shell_size_user_specified, create_frame_gcs):
7552 * xdisp.c (check_it): Likewise.
7553 * xfaces.c (register_color, unregister_color, unregister_colors):
7555 * xfns.c (print_fontset_result): Likewise.
7556 * xrdb.c (member, fatal, main): Likewise.
7558 2011-07-10 Paul Eggert <eggert@cs.ucla.edu>
7560 Fix minor problems found by static checking (Bug#9031).
7561 * chartab.c (char_table_set_range, map_sub_char_table):
7562 Remove unused locals.
7563 (uniprop_table): Now static.
7564 * composite.c (_work_char): Remove unused static var.
7566 2011-07-09 Juanma Barranquero <lekktu@gmail.com>
7568 * chartab.c (uniprop_table_uncompress): Remove unused local variable.
7570 2011-07-09 Jan Djärv <jan.h.d@swipnet.se>
7572 * gtkutil.c (qttip_cb): Remove code without function.
7574 2011-07-09 Eli Zaretskii <eliz@gnu.org>
7576 * w32.c (pthread_sigmask): New stub.
7578 2011-07-08 Paul Eggert <eggert@cs.ucla.edu>
7580 Use pthread_sigmask, not sigprocmask (Bug#9010).
7581 sigprocmask is portable only for single-threaded applications, and
7582 Emacs can be multi-threaded when it uses GTK.
7583 * Makefile.in (LIB_PTHREAD_SIGMASK): New macro.
7585 * callproc.c (Fcall_process):
7586 * process.c (create_process):
7587 * sysdep.c (sys_sigblock, sys_sigunblock, sys_sigsetmask):
7588 Use pthread_sigmask, not sigprocmask.
7590 2011-07-08 Jan Djärv <jan.h.d@swipnet.se>
7592 * gtkutil.c (qttip_cb): Set line wrap to FALSE for tooltip widget.
7593 (xg_prepare_tooltip): Revert text in x->ttip_lbl, margins was
7596 2011-07-08 Jan Djärv <jan.h.d@swipnet.se>
7598 * gtkutil.c (xg_prepare_tooltip): Fix indentation and comment.
7599 Put text in x->ttip_lbl instead of gtk_tooltip_set_text (Bug#8591).
7600 (xg_hide_tooltip): Fix comment.
7602 * nsterm.m (initFrameFromEmacs): Don't use ns_return_types
7603 in registerServicesMenuSendTypes.
7604 (validRequestorForSendType): Don't check ns_return_types.
7606 * nsfns.m (Fx_open_connection): Put NSStringPboardType into
7609 2011-07-08 Jason Rumney <jasonr@gnu.org>
7611 * w32term.c (x_make_frame_visible): Use SH_SHOWNORMAL rather than
7612 SH_SHOW for hidden windows (Bug#5482).
7614 * w32fns.c (w32_wnd_proc) [WM_TIMER, WM_SET_CURSOR]: Avoid using
7615 frame struct members of non-existent frames (Bug#6284).
7617 2011-07-08 Jan Djärv <jan.h.d@swipnet.se>
7619 * nsterm.m (keyDown): Call to wantsToDelayTextChangeNotifications and
7620 variable firstTime not needed on OSX >= 10.6.
7621 (setPosition): setFloatValue:knobProportion: is deprecated on OSX
7622 >= 10.5. Use setKnobProportion, setDoubleValue.
7624 * nsterm.h (MAC_OS_X_VERSION_10_3, MAC_OS_X_VERSION_10_4)
7625 (MAC_OS_X_VERSION_10_5): Define if not defined.
7626 (EmacsView, EmacsTooltip): Implements NSWindowDelegate on OSX >= 10.6.
7627 (EmacsMenu): Implements NSMenuDelegate on OSX >= 10.6.
7628 (EmacsToolbar): Implements NSToolbarDelegate on OSX >= 10.6.
7630 * nsselect.m (ns_string_from_pasteboard): Don't use deprecated methods
7631 cString and lossyCString on OSX >= 10.4
7633 * nsmenu.m (fillWithWidgetValue): Don't use deprecated method
7634 sizeToFit on OSX >= 10.2.
7636 * nsimage.m (allocInitFromFile): Don't use deprecated method
7637 bestRepresentationForDevice on OSX >= 10.6.
7639 * nsfns.m (check_ns_display_info): Cast to long and use %ld in error
7642 * emacs.c: Declare unexec_init_emacs_zone.
7644 * nsgui.h: Fix compiler warning about gnulib redefining verify.
7646 * nsselect.m (ns_get_local_selection): Change to extern (Bug#8842).
7648 * nsmenu.m (ns_update_menubar): Remove useless setDelegate call
7649 on svcsMenu (Bug#8842).
7651 * nsfns.m (Fx_open_connection): Remove NSStringPboardType from
7653 (Fns_list_services): Just return Qnil on 10.6, code not working there.
7655 * nsterm.m (QUTF8_STRING): Declare.
7656 (initFrameFromEmacs): Call registerServicesMenuSendTypes.
7657 (validRequestorForSendType): Return type is (id).
7658 Change indexOfObjectIdenticalTo to indexOfObject.
7659 Check if we have local selection before returning self (Bug#8842).
7660 (writeSelectionToPasteboard): Put local selection into paste board
7661 if we have a local selection (Bug#8842).
7662 (syms_of_nsterm): DEFSYM QUTF8_STRING.
7664 * nsterm.h (MAC_OS_X_VERSION_10_6): Define here instead of nsterm.m.
7665 (ns_get_local_selection): Declare.
7667 2011-07-07 Lars Magne Ingebrigtsen <larsi@gnus.org>
7669 * keymap.c (describe_map_tree): Don't insert a double newline at
7670 the end of the buffer (bug#1169) and return whether we inserted
7673 * callint.c (Fcall_interactively): Change "reading args" to
7674 "providing args" to try to clarify what it does (bug#1010).
7676 2011-07-07 Kenichi Handa <handa@m17n.org>
7678 * composite.c (composition_compute_stop_pos): Ignore a static
7679 composition starting before CHARPOS (Bug#8915).
7681 * xdisp.c (handle_composition_prop): Likewise.
7683 2011-07-07 Eli Zaretskii <eliz@gnu.org>
7685 * term.c (produce_glyphs) <xassert>: Allow IT_GLYPHLESS in it->what.
7688 2011-07-07 Kenichi Handa <handa@m17n.org>
7690 * character.h (unicode_category_t): New enum type.
7692 * chartab.c (uniprop_decoder_t, uniprop_encoder_t): New types.
7693 (Qchar_code_property_table): New variable.
7694 (UNIPROP_TABLE_P, UNIPROP_GET_DECODER)
7695 (UNIPROP_COMPRESSED_FORM_P): New macros.
7696 (char_table_ascii): Uncompress the compressed values.
7697 (sub_char_table_ref): New arg is_uniprop. Callers changed.
7698 Uncompress the compressed values.
7699 (sub_char_table_ref_and_range): Likewise.
7700 (char_table_ref_and_range): Uncompress the compressed values.
7701 (sub_char_table_set): New arg is_uniprop. Callers changed.
7702 Uncompress the compressed values.
7703 (sub_char_table_set_range): Args changed. Callers changed.
7704 (char_table_set_range): Adjuted for the above change.
7705 (map_sub_char_table): Delete args default_val and parent. Add arg
7706 top. Give decoded values to a Lisp function.
7707 (map_char_table): Adjust for the above change. Give decoded
7708 values to a Lisp function. Gcpro more variables.
7709 (uniprop_table_uncompress)
7710 (uniprop_decode_value_run_length): New functions.
7711 (uniprop_decoder, uniprop_decoder_count): New variables.
7712 (uniprop_get_decoder, uniprop_encode_value_character)
7713 (uniprop_encode_value_run_length, uniprop_encode_value_numeric):
7715 (uniprop_encoder, uniprop_encoder_count): New variables.
7716 (uniprop_get_encoder, uniprop_table)
7717 (Funicode_property_table_internal, Fget_unicode_property_internal)
7718 (Fput_unicode_property_internal): New functions.
7719 (syms_of_chartab): DEFSYM Qchar_code_property_table, defsubr
7720 Sunicode_property_table_internal, Sget_unicode_property_internal,
7721 and Sput_unicode_property_internal. Defvar_lisp
7722 char-code-property-alist.
7724 * composite.c (CHAR_COMPOSABLE_P): Adjust for the change of
7725 Vunicode_category_table.
7727 * font.c (font_range): Adjust for the change of
7728 Vunicode_category_table.
7730 2011-07-07 Dan Nicolaescu <dann@ics.uci.edu>
7732 * m/iris4d.h: Remove file, move contents ...
7733 * s/irix6-5.h: ... here.
7735 2011-07-06 Paul Eggert <eggert@cs.ucla.edu>
7737 Remove unportable assumption about struct layout (Bug#8884).
7738 * alloc.c (mark_buffer):
7739 * buffer.c (reset_buffer_local_variables, Fbuffer_local_variables)
7740 (clone_per_buffer_values): Don't assume that
7741 sizeof (struct buffer) is a multiple of sizeof (Lisp_Object).
7742 This isn't true in general, and it's particularly not true
7743 if Emacs is configured with --with-wide-int.
7744 * buffer.h (FIRST_FIELD_PER_BUFFER, LAST_FIELD_PER_BUFFER):
7745 New macros, used in the buffer.c change.
7747 2011-07-05 Jan Djärv <jan.h.d@swipnet.se>
7749 * xsettings.c: Use both GConf and GSettings if both are available.
7750 (store_config_changed_event): Add comment.
7751 (dpyinfo_valid, store_font_name_changed, map_tool_bar_style)
7752 (store_tool_bar_style_changed): New functions.
7753 (store_monospaced_changed): Add comment. Call dpyinfo_valid.
7754 (struct xsettings): Move font inside HAVE_XFT.
7755 (GSETTINGS_TOOL_BAR_STYLE, GSETTINGS_FONT_NAME): New defines.
7756 (GSETTINGS_MONO_FONT): Rename from SYSTEM_MONO_FONT.
7757 Move inside HAVE_XFT.
7758 (something_changed_gsettingsCB): Rename from something_changedCB.
7759 Check for changes in GSETTINGS_TOOL_BAR_STYLE and GSETTINGS_FONT_NAME
7761 (GCONF_TOOL_BAR_STYLE, GCONF_FONT_NAME): New defines.
7762 (GCONF_MONO_FONT): Rename from SYSTEM_MONO_FONT. Move inside HAVE_XFT.
7763 (something_changed_gconfCB): Rename from something_changedCB.
7764 Check for changes in GCONF_TOOL_BAR_STYLE and GCONF_FONT_NAME also.
7765 (parse_settings): Move check for font inside HAVE_XFT.
7766 (read_settings, apply_xft_settings): Add comment.
7767 (read_and_apply_settings): Add comment. Call map_tool_bar_style and
7768 store_tool_bar_style_changed. Move check for font inside HAVE_XFT and
7769 call store_font_name_changed.
7770 (xft_settings_event): Add comment.
7771 (init_gsettings): Add comment. Get values for GSETTINGS_TOOL_BAR_STYLE
7772 and GSETTINGS_FONT_NAME. Move check for fonts within HAVE_XFT.
7773 (init_gconf): Add comment. Get values for GCONF_TOOL_BAR_STYLE
7774 and GCONF_FONT_NAME. Move check for fonts within HAVE_XFT.
7775 (xsettings_initialize): Call init_gsettings last.
7776 (xsettings_get_system_font, xsettings_get_system_normal_font):
7779 2011-07-05 Paul Eggert <eggert@cs.ucla.edu>
7781 Random fixes. E.g., (random) never returned negative values.
7782 * fns.c (Frandom): Use GET_EMACS_TIME for random seed, and add the
7783 subseconds part to the entropy, as that's a bit more random.
7784 Prefer signed to unsigned, since the signedness doesn't matter and
7785 in general we prefer signed. When given a limit, use a
7786 denominator equal to INTMASK + 1, not to VALMASK + 1, because the
7787 latter isn't right if USE_2_TAGS_FOR_INTS.
7788 * sysdep.c (get_random): Return a value in the range 0..INTMASK,
7789 not 0..VALMASK. Don't discard "excess" bits that random () returns.
7791 2011-07-04 Stefan Monnier <monnier@iro.umontreal.ca>
7793 * textprop.c (text_property_stickiness):
7794 Obey Vtext_property_default_nonsticky.
7795 (syms_of_textprop): Add `display' to Vtext_property_default_nonsticky.
7796 * w32fns.c (syms_of_w32fns):
7797 * xfns.c (syms_of_xfns): Don't Add `display' since it's there by default.
7799 2011-07-04 Paul Eggert <eggert@cs.ucla.edu>
7801 * fileio.c (barf_or_query_if_file_exists): Use S_ISDIR.
7802 This is more efficient than Ffile_directory_p and avoids a minor race.
7804 2011-07-04 Lars Magne Ingebrigtsen <larsi@gnus.org>
7806 * buffer.c (Foverlay_put): Say what the return value is
7809 * fileio.c (barf_or_query_if_file_exists): Check first if the file
7810 is a directory before asking whether to use the file name
7812 (barf_or_query_if_file_exists): Make the "File is a directory"
7813 error be more correct.
7815 * fns.c (Frequire): Remove the mention of the .gz files, since
7816 that's installation-specific, but keep the mention of
7817 `get-load-suffixes'.
7819 2011-07-04 Paul Eggert <eggert@cs.ucla.edu>
7821 * editfns.c (Fformat_time_string): Don't assume strlen fits in int.
7822 Report string overflow if the output is too long.
7824 2011-07-04 Juanma Barranquero <lekktu@gmail.com>
7826 * gnutls.c (Fgnutls_boot): Don't mention :verify-error.
7827 (syms_of_gnutls): Remove duplicate DEFSYM for
7828 Qgnutls_bootprop_verify_hostname_error, an error for
7829 Qgnutls_bootprop_verify_error (which is no longer used).
7831 * eval.c (find_handler_clause): Remove parameters `sig' and `data',
7832 unused since 2011-01-26T20:02:07Z!monnier@iro.umontreal.ca. All callers changed.
7833 Also (re)move comments that are misplaced or no longer relevant.
7835 2011-07-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
7837 * callint.c (Finteractive): Clarify the meaning of "@" (bug#8813).
7839 2011-07-03 Chong Yidong <cyd@stupidchicken.com>
7841 * xfaces.c (Finternal_merge_in_global_face): Modify the foreground
7842 and background color parameters if they have been changed.
7844 2011-07-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
7846 * editfns.c (Fformat): Clarify the - and 0 flags (bug#6659).
7848 2011-07-03 Paul Eggert <eggert@cs.ucla.edu>
7850 * xsettings.c (SYSTEM_FONT): Define only when used.
7851 No need to define when HAVE_GSETTINGS || !HAVE_XFT.
7853 * keymap.c (access_keymap_1): Now static.
7855 2011-07-02 Chong Yidong <cyd@stupidchicken.com>
7857 * keyboard.c (command_loop_1): If a down-mouse event is unbound,
7858 leave any prefix arg for the up event (Bug#1586).
7860 2011-07-02 Lars Magne Ingebrigtsen <larsi@gnus.org>
7862 * lread.c (syms_of_lread): Mention single symbols defined by
7863 `defvar' or `defconst' (bug#7154).
7865 * fns.c (Frequire): Mention .el.gz files (bug#7314).
7866 (Frequire): Mention get-load-suffixes.
7868 2011-07-02 Martin Rudalics <rudalics@gmx.at>
7870 * window.h (window): Remove clone_number slot.
7871 * window.c (Fwindow_clone_number, Fset_window_clone_number):
7873 (make_parent_window, make_window, saved_window)
7874 (Fset_window_configuration, save_window_save): Don't deal with
7876 * buffer.c (Qclone_number): Remove declaration.
7877 (sort_overlays, overlay_strings): Don't deal with clone numbers.
7879 2011-07-02 Stefan Monnier <monnier@iro.umontreal.ca>
7881 Add multiple inheritance to keymaps.
7882 * keymap.c (Fmake_composed_keymap): New function.
7883 (Fset_keymap_parent): Simplify.
7884 (fix_submap_inheritance): Remove.
7885 (access_keymap_1): New function extracted from access_keymap to handle
7886 embedded parents and handle lists of maps.
7887 (access_keymap): Use it.
7888 (Fkeymap_prompt, map_keymap_internal, map_keymap, store_in_keymap)
7889 (Fcopy_keymap): Handle embedded parents.
7890 (Fcommand_remapping, define_as_prefix): Simplify.
7891 (Fkey_binding): Simplify.
7892 (syms_of_keymap): Move minibuffer-local-completion-map,
7893 minibuffer-local-filename-completion-map,
7894 minibuffer-local-must-match-map, and
7895 minibuffer-local-filename-must-match-map to Elisp.
7896 (syms_of_keymap): Defsubr make-composed-keymap.
7897 * keyboard.c (menu_bar_items): Use map_keymap_canonical.
7898 (parse_menu_item): Trivial simplification.
7900 2011-07-01 Glenn Morris <rgm@gnu.org>
7902 * Makefile.in (SETTINGS_LIBS): Fix typo.
7904 2011-07-01 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny patch)
7906 * coding.c (Fencode_coding_string): Record the last coding system
7907 used, as the function doc string says (bug#8738).
7909 2011-07-01 Jan Djärv <jan.h.d@swipnet.se>
7911 * xsettings.c (store_monospaced_changed): Take new font as arg and
7912 check for change against current_mono_font.
7913 (EMACS_TYPE_SETTINGS): Remove this and related defines.
7914 (emacs_settings_constructor, emacs_settings_get_property)
7915 (emacs_settings_set_property, emacs_settings_class_init)
7916 (emacs_settings_init, gsettings_obj): Remove.
7917 (something_changedCB): New function for HAVE_GSETTINGS.
7918 (something_changedCB): HAVE_GCONF: Call store_monospaced_changed
7919 with value as argument.
7920 (init_gsettings): Check that GSETTINGS_SCHEMA exists before calling
7921 g_settings_new (Bug#8967). Do not create gsettings_obj.
7922 Remove calls to g_settings_bind. Connect something_changedCB to
7925 * xgselect.c: Add defined (HAVE_GSETTINGS).
7926 (xgselect_initialize): Ditto.
7928 * process.c: Add defined (HAVE_GSETTINGS) for xgselect.h
7929 (wait_reading_process_output): Add defined (HAVE_GSETTINGS) for
7932 2011-07-01 Paul Eggert <eggert@cs.ucla.edu>
7934 * eval.c (struct backtrace): Simplify and port the data structure.
7935 Do not assume that "int nargs : BITS_PER_INT - 2;" produces a
7936 signed bit field, as this assumption is not portable and it makes
7937 Emacs crash when compiled with Sun C 5.8 on sparc. Do not use
7938 "char debug_on_exit : 1" as this is not portable either; instead,
7939 use the portable "unsigned int debug_on_exit : 1". Remove unused
7940 member evalargs. Remove obsolete comments about cc bombing out.
7942 2011-06-30 Jan Djärv <jan.h.d@swipnet.se>
7944 * xsettings.c: Include glib-object.h, gio/gio.h if HAVE_GSETTINGS.
7945 Let HAVE_GSETTINGS override HAVE_GCONF.
7946 (store_monospaced_changed): New function.
7947 (EMACS_SETTINGS): A new type derived from GObject to handle
7948 GSettings notifications.
7949 (emacs_settings_constructor, emacs_settings_get_property)
7950 (emacs_settings_set_property, emacs_settings_class_init):
7952 (gsettings_client, gsettings_obj): New variables.
7953 (GSETTINGS_SCHEMA): New define.
7954 (something_changedCB): Call store_monospaced_changed.
7955 (init_gsettings): New function.
7956 (xsettings_initialize): Call init_gsettings.
7957 (syms_of_xsettings): Initialize gsettings_client, gsettings_obj
7960 * Makefile.in (SETTINGS_CFLAGS, SETTINGS_LIBS): Rename from
7963 2011-06-29 Martin Rudalics <rudalics@gmx.at>
7965 * window.c (resize_root_window, grow_mini_window)
7966 (shrink_mini_window): Rename Qresize_root_window to
7967 Qwindow_resize_root_window and Qresize_root_window_vertically to
7968 Qwindow_resize_root_window_vertically.
7970 2011-06-28 Paul Eggert <eggert@cs.ucla.edu>
7972 * gnutls.c (Qgnutls_bootprop_verify_error): Remove unused var.
7974 2011-06-27 Juanma Barranquero <lekktu@gmail.com>
7976 * makefile.w32-in: Redesign dependencies so they reflect more
7977 clearly which files are directly included by each source file,
7978 and not through other includes.
7980 2011-06-27 Martin Rudalics <rudalics@gmx.at>
7982 * buffer.c (Qclone_number): Declare static and DEFSYM it.
7983 (sort_overlays, overlay_strings): When an overlay's clone number
7984 matches the window's clone number process the overlay even if
7985 the overlay's window property doesn't match the current window.
7987 * window.c (Fwindow_vchild): Rename to Fwindow_top_child.
7988 (Fwindow_hchild): Rename to Fwindow_left_child.
7989 (Fwindow_next): Rename to Fwindow_next_sibling.
7990 (Fwindow_prev): Rename to Fwindow_prev_sibling.
7991 (resize_window_check): Rename to window_resize_check.
7992 (resize_window_apply): Rename to window_resize_apply.
7993 (Fresize_window_apply): Rename to Fwindow_resize_apply.
7994 (Fdelete_other_windows_internal, resize_frame_windows)
7995 (Fsplit_window_internal, Fdelete_window_internal)
7996 (grow_mini_window, shrink_mini_window)
7997 (Fresize_mini_window_internal): Fix callers accordingly.
7999 2011-06-26 Jan Djärv <jan.h.d@swipnet.se>
8001 * emacsgtkfixed.h: State that this is only used with Gtk+3.
8002 (emacs_fixed_set_min_size): Remove.
8003 (emacs_fixed_new): Take frame as argument.
8005 * emacsgtkfixed.c: State that this is only used with Gtk+3.
8006 (_EmacsFixedPrivate): Remove minwidth/height.
8007 Add struct frame *f.
8008 (emacs_fixed_init): Initialize priv->f.
8009 (get_parent_class, emacs_fixed_set_min_size): Remove.
8010 (emacs_fixed_new): Set priv->f to argument.
8011 (emacs_fixed_get_preferred_width)
8012 (emacs_fixed_get_preferred_height): Use min_width/height from
8013 frames size_hint to set minimum and natural (Bug#8919).
8014 (XSetWMSizeHints, XSetWMNormalHints): Override these functions
8015 and use min_width/height from frames size_hint to set
8016 min_width/height (Bug#8919).
8018 * gtkutil.c (xg_create_frame_widgets): Pass f to emacs_fixed_new.
8019 (x_wm_set_size_hint): Remove call to emacs_fixed_set_min_size.
8022 2011-06-26 Eli Zaretskii <eliz@gnu.org>
8024 * bidi.c (bidi_paragraph_init): Test for ZV_BYTE before calling
8025 bidi_at_paragraph_end, since fast_looking_at doesn't like to be
8028 2011-06-26 Chong Yidong <cyd@stupidchicken.com>
8030 * process.c (wait_reading_process_output): Bypass select if
8031 waiting for a cell while ignoring keyboard input, and input is
8032 pending. Suggested by Jan Djärv (Bug#8869).
8034 2011-06-25 Paul Eggert <eggert@cs.ucla.edu>
8036 Use gnulib's dup2 module instead of rolling our own.
8037 * sysdep.c (dup2) [!HAVE_DUP2]: Remove; gnulib now does this.
8039 2011-06-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
8041 * dispnew.c (scrolling_window): Before scrolling, turn off a
8042 mouse-highlight in the window being scrolled.
8044 2011-06-24 Juanma Barranquero <lekktu@gmail.com>
8046 Move DEFSYM to lisp.h and use everywhere.
8048 * character.h (DEFSYM): Move declaration...
8049 * lisp.h (DEFSYM): ...here.
8055 * w32select.c: Don't include character.h.
8057 * alloc.c (syms_of_alloc):
8058 * buffer.c (syms_of_buffer):
8059 * bytecode.c (syms_of_bytecode):
8060 * callint.c (syms_of_callint):
8061 * casefiddle.c (syms_of_casefiddle):
8062 * casetab.c (init_casetab_once):
8063 * category.c (init_category_once, syms_of_category):
8064 * ccl.c (syms_of_ccl):
8065 * cmds.c (syms_of_cmds):
8066 * composite.c (syms_of_composite):
8067 * dbusbind.c (syms_of_dbusbind):
8068 * dired.c (syms_of_dired):
8069 * dispnew.c (syms_of_display):
8070 * doc.c (syms_of_doc):
8071 * editfns.c (syms_of_editfns):
8072 * emacs.c (syms_of_emacs):
8073 * eval.c (syms_of_eval):
8074 * fileio.c (syms_of_fileio):
8075 * fns.c (syms_of_fns):
8076 * frame.c (syms_of_frame):
8077 * fringe.c (syms_of_fringe):
8078 * insdel.c (syms_of_insdel):
8079 * keymap.c (syms_of_keymap):
8080 * lread.c (init_obarray, syms_of_lread):
8081 * macros.c (syms_of_macros):
8082 * msdos.c (syms_of_msdos):
8083 * print.c (syms_of_print):
8084 * process.c (syms_of_process):
8085 * search.c (syms_of_search):
8086 * sound.c (syms_of_sound):
8087 * syntax.c (init_syntax_once, syms_of_syntax):
8088 * terminal.c (syms_of_terminal):
8089 * textprop.c (syms_of_textprop):
8090 * undo.c (syms_of_undo):
8091 * w32.c (globals_of_w32):
8092 * window.c (syms_of_window):
8093 * xdisp.c (syms_of_xdisp):
8094 * xfaces.c (syms_of_xfaces):
8095 * xfns.c (syms_of_xfns):
8096 * xmenu.c (syms_of_xmenu):
8097 * xsettings.c (syms_of_xsettings):
8098 * xterm.c (syms_of_xterm): Use DEFSYM.
8100 2011-06-24 Teodor Zlatanov <tzz@lifelogs.com>
8102 * gnutls.c (syms_of_gnutls): Use the DEFSYM macro from character.h.
8104 2011-06-23 Paul Eggert <eggert@cs.ucla.edu>
8106 Integer and buffer overflow fixes (Bug#8873).
8108 * print.c (printchar, strout): Check for string overflow.
8109 (PRINTPREPARE, printchar, strout):
8110 Don't set size unless allocation succeeds.
8112 * minibuf.c (read_minibuf_noninteractive): Use ptrdiff_t, not int,
8113 for sizes. Check for string overflow more accurately.
8114 Simplify newline removal at end; this suppresses a GCC 4.6.0 warning.
8116 * macros.c: Integer and buffer overflow fixes.
8117 * keyboard.h (struct keyboard.kbd_macro_bufsize):
8118 * macros.c (Fstart_kbd_macro, store_kbd_macro_char):
8119 Use ptrdiff_t, not int, for sizes.
8120 Don't increment bufsize until after realloc succeeds.
8121 Check for size-calculation overflow.
8122 (Fstart_kbd_macro): Use EMACS_INT, not int, for XINT result.
8124 * lisp.h (DEFVAR_KBOARD): Use offsetof instead of char * finagling.
8126 * lread.c: Integer overflow fixes.
8127 (read_integer): Radix is now EMACS_INT, not int,
8128 to improve quality of diagnostics for out-of-range radices.
8129 Calculate buffer size correctly for out-of-range radices.
8130 (read1): Check for integer overflow in radices, and in
8131 read-circle numbers.
8132 (read_escape): Avoid int overflow.
8133 (Fload, openp, read_buffer_size, read1)
8134 (substitute_object_recurse, read_vector, read_list, map_obarray):
8135 Use ptrdiff_t, not int, for sizes.
8136 (read1): Use EMACS_INT, not int, for sizes.
8137 Check for size overflow.
8139 * image.c (cache_image): Check for size arithmetic overflow.
8141 * lread.c: Integer overflow issues.
8142 (saved_doc_string_size, saved_doc_string_length)
8143 (prev_saved_doc_string_size, prev_saved_doc_string_length):
8144 Now ptrdiff_t, not int.
8145 (read1): Don't assume doc string length fits in int. Check for
8146 out-of-range doc string lengths.
8147 (read_list): Don't assume file position fits in int.
8148 (read_escape): Check for hex character overflow.
8150 2011-06-22 Leo Liu <sdl.web@gmail.com>
8152 * minibuf.c (Fcompleting_read_default, Vcompleting_read_function):
8153 Move to minibuffer.el.
8155 2011-06-22 Paul Eggert <eggert@cs.ucla.edu>
8157 Fixes for GLYPH_DEBUG found by GCC 4.6.0 static checking.
8158 The following patches are for when GLYPH_DEBUG && !XASSERT.
8159 * dispextern.h (trace_redisplay_p, dump_glyph_string):
8160 * dispnew.c (flush_stdout):
8161 * xdisp.c (dump_glyph_row, dump_glyph_matrix, dump_glyph):
8162 Mark as externally visible.
8163 * dispnew.c (check_window_matrix_pointers): Now static.
8164 * dispnew.c (window_to_frame_vpos):
8165 * xfns.c (unwind_create_frame):
8166 * xterm.c (x_check_font): Remove unused local.
8167 * scroll.c (CHECK_BOUNDS):
8168 * xfaces.c (cache_fache): Rename local to avoid shadowing.
8169 * xfns.c, w32fns.c (image_cache_refcount, dpyinfo_refcount): Now static.
8170 * xdisp.c (check_window_end): Now a no-op if !XASSERTS.
8171 (debug_first_unchanged_at_end_vpos, debug_last_unchanged_at_beg_vpos)
8172 (debug_dvpos, debug_dy, debug_delta, debug_delta_bytes, debug_end_vpos):
8174 (debug_method_add): Use va_list and vsprintf rather than relying
8175 on undefined behavior with wrong number of arguments.
8176 (dump_glyph, dump_glyph_row, Fdump_glyph_matrix):
8177 Don't assume ptrdiff_t and EMACS_INT are the same width as int.
8178 In this code, it's OK to assume C99 behavior for ptrdiff_t formats
8179 since we're not interested in debugging glyphs with old libraries.
8180 * xfaces.c (cache_face): Move debugging code earlier; this pacifies
8181 GCC 4.6.0's static checking.
8183 2011-06-22 Paul Eggert <eggert@cs.ucla.edu>
8185 Integer overflow and signedness fixes (Bug#8873).
8186 A few related buffer overrun fixes, too.
8188 * font.c (font_score): Use EMACS_INT, not int, to store XINT value.
8190 * dispextern.h (struct face.stipple):
8191 * image.c (x_bitmap_height, x_bitmap_width, x_bitmap_pixmap)
8192 (x_bitmap_mask, x_allocate_bitmap_record)
8193 (x_create_bitmap_from_data, x_create_bitmap_from_file)
8194 (x_destroy_bitmap, x_destroy_all_bitmaps, x_create_bitmap_mask)
8195 (x_create_bitmap_from_xpm_data):
8196 * nsterm.h (struct ns_display_info.bitmaps_size, .bitmaps_last):
8197 * w32term.h (struct w32_display_info.icon_bitmap_id, .bitmaps_size)
8199 * xfaces.c (load_pixmap):
8200 * xterm.c (x_bitmap_icon, x_wm_set_icon_pixmap):
8201 * xterm.h (struct x_display_info.icon_bitmap_id, .bitmaps_size)
8202 (.bitmaps_last, struct x_output.icon_bitmap):
8203 Use ptrdiff_t, not int, for bitmap indexes.
8204 (x_allocate_bitmap_record): Check for size overflow.
8205 * dispextern.h, lisp.h: Adjust to API changes elsewhere.
8207 Use ptrdiff_t, not int, for overlay counts.
8208 * buffer.h (overlays_at, sort_overlays, GET_OVERLAYS_AT):
8209 * editfns.c (overlays_around, get_pos_property):
8210 * textprop.c (get_char_property_and_overlay):
8211 * xdisp.c (next_overlay_change, note_mouse_highlight):
8212 * xfaces.c (face_at_buffer_position):
8213 * buffer.c (OVERLAY_COUNT_MAX): New macro.
8214 (overlays_at, overlays_in, sort_overlays, Foverlays_at)
8215 (Fnext_overlay_change, Fprevious_overlay_change)
8216 (mouse_face_overlay_overlaps, Foverlays_in):
8217 Use ptrdiff_t, not int, for sizes.
8218 (overlays_at, overlays_in): Check for size-calculation overflow.
8220 * xterm.c (xim_initialize, same_x_server): Strlen may not fit in int.
8222 * xsmfns.c (smc_save_yourself_CB, x_session_initialize): Avoid strlen.
8223 (x_session_initialize): Do not assume string length fits in int.
8225 * xsettings.c (apply_xft_settings): Fix potential buffer overrun.
8226 This is unlikely, but can occur if DPI is outlandish.
8228 * xsettings.c (Ffont_get_system_normal_font, Ffont_get_system_font):
8229 * xselect.c (Fx_get_atom_name): Avoid need for strlen.
8231 * xrdb.c: Don't assume strlen fits in int; avoid some strlens.
8232 * xrdb.c (magic_file_p, search_magic_path):
8233 Omit last arg SUFFIX; it was always 0. All callers changed.
8234 (magic_file_p): Use ptrdiff_t, not int. Check for size overflow.
8236 * xfont.c (xfont_match): Avoid need for strlen.
8238 * xfns.c: Don't assume strlen fits in int.
8239 (xic_create_fontsetname, x_window): Use ptrdiff_t, not int.
8241 * xdisp.c (message_log_check_duplicate): Return intmax_t,
8242 not unsigned long, as we prefer signed integers. All callers changed.
8243 Detect integer overflow in repeat count.
8244 (message_dolog): Don't assume print length fits in 39 bytes.
8245 (display_mode_element): Don't assume strlen fits in int.
8247 * termcap.c: Don't assume sizes fit in int and never overflow.
8248 (struct termcap_buffer, tgetent): Use ptrdiff_t, not int, for sizes.
8249 (gobble_line): Check for size-calculation overflow.
8251 * minibuf.c (Fread_buffer):
8252 * lread.c (intern, intern_c_string):
8253 * image.c (xpm_scan) [HAVE_NS && !HAVE_XPM]:
8254 Don't assume string length fits in int.
8256 * keyboard.c (parse_tool_bar_item):
8257 * gtkutil.c (style_changed_cb): Avoid need for strlen.
8259 * font.c: Don't assume string length fits in int.
8260 (font_parse_xlfd, font_parse_fcname, font_unparse_fcname):
8261 Use ptrdiff_t, not int.
8262 (font_intern_prop): Don't assume string length fits in int.
8263 Don't assume integer property fits in fixnum.
8264 * font.h (font_intern_prop): 2nd arg is now ptrdiff_t, not int.
8266 * filelock.c: Fix some buffer overrun and integer overflow issues.
8267 (get_boot_time): Don't assume gzip command string fits in 100 bytes.
8268 Reformulate so as not to need the command string.
8269 Invoke gzip -cd rather than gunzip, as it's more portable.
8270 (lock_info_type, lock_file_1, lock_file):
8271 Don't assume pid_t and time_t fit in unsigned long.
8272 (LOCK_PID_MAX): Remove; we now use more-reliable bounds.
8273 (current_lock_owner): Prefer signed type for sizes.
8274 Use memcpy, not strncpy, where memcpy is what is really wanted.
8275 Don't assume (via atoi) that time_t and pid_t fit in int.
8276 Check for time_t and/or pid_t out of range, e.g., via a network share.
8277 Don't alloca where an auto var works fine.
8279 * fileio.c: Fix some integer overflow issues.
8280 (file_name_as_directory, Fexpand_file_name, Fsubstitute_in_file_name):
8281 Don't assume string length fits in int.
8282 (directory_file_name): Don't assume string length fits in long.
8283 (make_temp_name): Don't assume pid fits in int, or that its print
8284 length is less than 20.
8286 * data.c (Fsubr_name): Rewrite to avoid a strlen call.
8288 * coding.c (make_subsidiaries): Don't assume string length fits in int.
8290 * callproc.c (child_setup): Rewrite to avoid two strlen calls.
8292 * process.c (Fformat_network_address): Use EMACS_INT, not EMACS_UINT.
8293 We prefer signed integers, even for size calculations.
8295 * emacs.c: Don't assume string length fits in 'int'.
8296 (DEFINE_DUMMY_FUNCTION, sort_args): Use ptrdiff_t, not int.
8297 (main): Don't invoke strlen when not needed.
8299 * dbusbind.c (XD_ERROR): Don't arbitrarily truncate string.
8300 (XD_DEBUG_MESSAGE): Don't waste a byte.
8302 * callproc.c (getenv_internal_1, getenv_internal)
8304 * buffer.c (init_buffer): Don't assume string length fits in 'int'.
8306 * lread.c (invalid_syntax): Omit length argument.
8307 All uses changed. This doesn't fix a bug, but it simplifies the
8308 code away from its former Hollerith-constant appearance, and it's
8309 one less 'int' to worry about when looking at integer-overflow issues.
8310 (string_to_number): Simplify 2011-04-26 change by invoking xsignal1.
8312 * lisp.h (DEFUN): Remove bogus use of sizeof (struct Lisp_Subr).
8313 This didn't break anything, but it didn't help either.
8314 It's confusing to put a bogus integer in a place where the actual
8315 value does not matter.
8316 (LIST_END_P): Remove unused macro and its bogus comment.
8317 (make_fixnum_or_float): Remove unnecessary cast to EMACS_INT.
8319 * lisp.h (union Lisp_Object.i): EMACS_INT, not EMACS_UINT.
8320 This is for consistency with the ordinary, non-USE_LISP_UNION_TYPE,
8322 (struct Lisp_Bool_Vector.size): EMACS_INT, not EMACS_UINT.
8323 We prefer signed types, and the value cannot exceed the EMACS_INT
8324 range anyway (because otherwise the length would not be representable).
8325 (XSET) [USE_LISP_UNION_TYPE]: Use uintptr_t and intptr_t,
8326 not EMACS_UINT and EMACS_INT, when converting pointer to integer.
8327 This avoids a GCC warning when WIDE_EMACS_INT.
8329 * indent.c (sane_tab_width): New function.
8330 (current_column, scan_for_column, Findent_to, position_indentation)
8331 (compute_motion): Use it. This is just for clarity.
8332 (Fcompute_motion): Don't assume hscroll and tab offset fit in int.
8334 * image.c (xbm_image_p): Don't assume stated width, height fit in int.
8336 * lisp.h (lint_assume): New macro.
8337 * composite.c (composition_gstring_put_cache):
8338 * ftfont.c (ftfont_shape_by_flt): Use it to pacify GCC 4.6.0.
8340 * editfns.c, insdel.c:
8341 Omit unnecessary forward decls, to simplify future changes.
8343 * ftfont.c (ftfont_shape_by_flt): Use signed integers for lengths.
8345 * font.c (Ffont_shape_gstring): Don't assume glyph len fits in 'int'.
8347 * fns.c (Ffillarray): Don't assume bool vector size fits in 'int'.
8348 Use much-faster test for byte-length change.
8349 Don't assume string byte-length fits in 'int'.
8350 Check that character arg fits in 'int'.
8351 (mapcar1): Declare byte as byte, for clarity.
8353 * alloc.c (Fmake_bool_vector): Avoid unnecessary multiplication.
8355 * fns.c (concat): Catch string overflow earlier.
8356 Do not rely on integer wraparound.
8358 * dispextern.h (struct it.overlay_strings_charpos)
8359 (struct it.selective): Now EMACS_INT, not int.
8360 * xdisp.c (forward_to_next_line_start)
8361 (back_to_previous_visible_line_start)
8362 (reseat_at_next_visible_line_start, next_element_from_buffer):
8363 Don't arbitrarily truncate the value of 'selective' to int.
8365 * xdisp.c (init_iterator): Use XINT, not XFASTINT; it might be < 0.
8367 * composite.c: Don't truncate sizes to 'int'.
8368 (composition_gstring_p, composition_reseat_it)
8369 (composition_adjust_point): Use EMACS_INT, not int.
8370 (get_composition_id, composition_gstring_put_cache): Use EMACS_INT,
8371 not EMACS_UINT, for indexes.
8373 * category.h (CATEGORY_SET_P): Remove unnecessary cast to EMACS_INT.
8375 * buffer.c: Include <verify.h>.
8376 (struct sortvec.priority, struct sortstr.priority):
8377 Now EMACS_INT, not int.
8378 (compare_overlays, cmp_for_strings): Avoid subtraction overflow.
8379 (struct sortstr.size, record_overlay_string)
8380 (struct sortstrlist.size, struct sortlist.used):
8381 Don't truncate size to int.
8382 (record_overlay_string): Check for size-calculation overflow.
8383 (init_buffer_once): Check at compile-time, not run-time.
8385 2011-06-22 Jim Meyering <meyering@redhat.com>
8387 Don't leak an XBM-image-sized buffer
8388 * image.c (xbm_load): Free the image buffer after using it.
8390 2011-06-21 Paul Eggert <eggert@cs.ucla.edu>
8393 * composite.c (find_automatic_composition): Omit needless 'return 0;'
8394 that Sun C diagnosed.
8395 * fns.c (secure_hash): Fix pointer signedness issue.
8396 * intervals.c (static_offset_intervals): New function.
8397 (offset_intervals): Use it.
8399 2011-06-21 Leo Liu <sdl.web@gmail.com>
8402 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha256.h and
8405 * fns.c (secure_hash): Rename from crypto_hash_function and change
8406 the first arg to accept symbols.
8407 (Fsecure_hash): New primitive.
8408 (syms_of_fns): New symbols.
8410 2011-06-20 Deniz Dogan <deniz@dogan.se>
8412 * process.c (Fset_process_buffer): Clarify return value in
8415 2011-06-18 Chong Yidong <cyd@stupidchicken.com>
8417 * dispnew.c (add_window_display_history): Use BVAR.
8419 * xdisp.c (debug_method_add): Use BVAR.
8420 (check_window_end, dump_glyph_matrix, dump_glyph)
8421 (dump_glyph_row, dump_glyph_string): Convert arglist to ANSI C.
8423 * xfaces.c (check_lface_attrs, check_lface, dump_realized_face):
8426 * xfns.c (Fx_create_frame, x_create_tip_frame): Delay image cache
8427 check till after the cache is created in init_frame_faces.
8429 2011-06-17 Stefan Monnier <monnier@iro.umontreal.ca>
8431 * fns.c (Fsafe_length): Yet another int/Lisp_Object mixup.
8433 2011-06-16 Paul Eggert <eggert@cs.ucla.edu>
8435 * lisp.h: Include <limits.h>, for INT_MAX, LONG_MAX, LLONG_MAX.
8436 Without this, prin1 mishandles Lisp_Misc_Save_Value printing on
8437 hosts with pre-C99 libraries, because pD is wrongly defined to "t".
8439 Improve buffer-overflow checking (Bug#8873).
8440 * fileio.c (Finsert_file_contents):
8441 * insdel.c (insert_from_buffer_1, replace_range, replace_range_2):
8442 Remove the old (too-loose) buffer overflow checks.
8443 They weren't needed, since make_gap checks for buffer overflow.
8444 * insdel.c (make_gap_larger): Catch buffer overflows that were missed.
8445 The old code merely checked for Emacs fixnum overflow, and relied
8446 on undefined (wraparound) behavior. The new code avoids undefined
8447 behavior, and also checks for ptrdiff_t and/or size_t overflow.
8449 * editfns.c (Finsert_char): Don't dump core with very negative counts.
8450 Tune. Don't use wider integers than needed. Don't use alloca.
8451 Use a bigger 'string' buffer. Rewrite to avoid 'n > 0' test.
8453 * insdel.c (replace_range): Fix buf overflow when insbytes < outgoing.
8455 * insdel.c, lisp.h (buffer_overflow): New function.
8456 (insert_from_buffer_1, replace_range, replace_range_2):
8457 * insdel.c (make_gap_larger):
8458 * editfns.c (Finsert_char):
8459 * fileio.c (Finsert_file_contents): Use it, to normalize wording.
8461 * buffer.h (BUF_BYTES_MAX): Cast to ptrdiff_t so that it's signed.
8463 2011-06-15 Paul Eggert <eggert@cs.ucla.edu>
8465 Integer overflow and signedness fixes (Bug#8873, Bug#8828).
8467 * ccl.c (ASCENDING_ORDER): New macro, to work around GCC bug 43772.
8468 (GET_CCL_RANGE, IN_INT_RANGE): Use it.
8470 * fileio.c: Don't assume EMACS_INT fits in off_t.
8471 (emacs_lseek): New static function.
8472 (Finsert_file_contents, Fwrite_region): Use it.
8473 Use SEEK_SET, SEEK_CUR, SEEK_END as appropriate.
8475 * fns.c (Fload_average): Don't assume 100 * load average fits in int.
8477 * fns.c: Don't overflow int when computing a list length.
8478 * fns.c (QUIT_COUNT_HEURISTIC): New constant.
8479 (Flength, Fsafe_length): Use EMACS_INT, not int, to avoid unwanted
8480 truncation on 64-bit hosts. Check for QUIT every
8481 QUIT_COUNT_HEURISTIC entries rather than every other entry; that's
8482 faster and is responsive enough.
8483 (Flength): Report an error instead of overflowing an integer.
8484 (Fsafe_length): Return a float if the value is not representable
8485 as a fixnum. This shouldn't happen except in contrived situations.
8486 (Fnthcdr, Fsort): Don't assume list length fits in int.
8487 (Fcopy_sequence): Don't assume vector length fits in int.
8489 * alloc.c: Check that resized vectors' lengths fit in fixnums.
8490 (header_size, word_size): New constants.
8491 (allocate_vectorlike): Don't check size overflow here.
8492 (allocate_vector): Check it here instead, since this is the only
8493 caller of allocate_vectorlike that could cause overflow.
8494 Check that the new vector's length is representable as a fixnum.
8496 * fns.c (next_almost_prime): Don't return a multiple of 3 or 5.
8497 The previous code was bogus. For example, next_almost_prime (32)
8498 returned 39, which is undesirable as it is a multiple of 3; and
8499 next_almost_prime (24) returned 25, which is a multiple of 5 so
8500 why was the code bothering to check for multiples of 7?
8502 * bytecode.c (exec_byte_code): Use ptrdiff_t, not int, for vector length.
8504 * eval.c, doprnt.c (SIZE_MAX): Remove; inttypes.h defines this now.
8506 Variadic C functions now count arguments with ptrdiff_t.
8507 This partly undoes my 2011-03-30 change, which replaced int with size_t.
8508 Back then I didn't know that the Emacs coding style prefers signed int.
8509 Also, in the meantime I found a few more instances where arguments
8510 were being counted with int, which may truncate counts on 64-bit
8511 machines, or EMACS_INT, which may be unnecessarily wide.
8512 * lisp.h (struct Lisp_Subr.function.aMANY)
8513 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call):
8514 Arg counts are now ptrdiff_t, not size_t.
8515 All variadic functions and their callers changed accordingly.
8516 (struct gcpro.nvars): Now size_t, not size_t. All uses changed.
8517 * bytecode.c (exec_byte_code): Check maxdepth for overflow,
8518 to avoid potential buffer overrun. Don't assume arg counts fit in 'int'.
8519 * callint.c (Fcall_interactively): Check arg count for overflow,
8520 to avoid potential buffer overrun. Use signed char, not 'int',
8521 for 'varies' array, so that we needn't bother to check its size
8522 calculation for overflow.
8523 * editfns.c (Fformat): Use ptrdiff_t, not EMACS_INT, to count args.
8524 * eval.c (apply_lambda):
8525 * fns.c (Fmapconcat): Use XFASTINT, not XINT, to get args length.
8526 (struct textprop_rec.argnum): Now ptrdiff_t, not int. All uses changed.
8527 (mapconcat): Use ptrdiff_t, not int and EMACS_INT, to count args.
8529 * callint.c (Fcall_interactively): Don't use index var as event count.
8531 * vm-limit.c (check_memory_limits): Fix incorrect extern function decls.
8532 * mem-limits.h (SIZE): Remove; no longer used.
8534 * xterm.c (x_alloc_nearest_color_1): Prefer int to long when int works.
8536 Remove unnecessary casts.
8537 * xterm.c (x_term_init):
8538 * xfns.c (x_set_border_pixel):
8539 * widget.c (create_frame_gcs): Remove casts to unsigned long etc.
8540 These aren't needed now that we assume ANSI C.
8542 * sound.c (Fplay_sound_internal): Remove cast to unsigned long.
8543 It's more likely to cause problems (due to unsigned overflow)
8546 * dired.c (Ffile_attributes): Don't use 32-bit hack on 64-bit hosts.
8548 * unexelf.c (unexec): Don't assume BSS addr fits in unsigned.
8550 * xterm.c (handle_one_xevent): Omit unnecessary casts to unsigned.
8552 * keyboard.c (modify_event_symbol): Don't limit alist len to UINT_MAX.
8554 * lisp.h (CHAR_TABLE_SET): Omit now-redundant test.
8556 * lread.c (Fload): Don't compare a possibly-garbage time_t value.
8558 GLYPH_CODE_FACE returns EMACS_INT, not int.
8559 * dispextern.h (merge_faces):
8560 * xfaces.c (merge_faces):
8561 * xdisp.c (get_next_display_element, next_element_from_display_vector):
8562 Don't assume EMACS_INT fits in int.
8564 * character.h (CHAR_VALID_P): Remove unused parameter.
8565 * fontset.c, lisp.h, xdisp.c: All uses changed.
8567 * editfns.c (Ftranslate_region_internal): Omit redundant test.
8569 * fns.c (concat): Minor tuning based on overflow analysis.
8570 This doesn't fix any bugs. Use int to hold character, instead
8571 of constantly refetching from Emacs object. Use XFASTINT, not
8572 XINT, for value known to be a character. Don't bother comparing
8573 a single byte to 0400, as it's always less.
8575 * floatfns.c (Fexpt):
8576 * fileio.c (make_temp_name): Omit unnecessary cast to unsigned.
8578 * editfns.c (Ftranslate_region_internal): Use int, not EMACS_INT
8581 * doc.c (get_doc_string): Omit (unsigned)c that mishandled negatives.
8583 * data.c (Faset): If ARRAY is a string, check that NEWELT is a char.
8584 Without this fix, on a 64-bit host (aset S 0 4294967386) would
8585 incorrectly succeed when S was a string, because 4294967386 was
8586 truncated before it was used.
8588 * chartab.c (Fchar_table_range): Use CHARACTERP to check range.
8589 Otherwise, an out-of-range integer could cause undefined behavior
8592 * composite.c: Use int, not EMACS_INT, for characters.
8593 (fill_gstring_body, composition_compute_stop_pos): Use int, not
8594 EMACS_INT, for values that are known to be in character range.
8595 This doesn't fix any bugs but is the usual style inside Emacs and
8596 may generate better code on 32-bit machines.
8598 Make sure a 64-bit char is never passed to ENCODE_CHAR.
8599 This is for reasons similar to the recent CHAR_STRING fix.
8600 * charset.c (Fencode_char): Check that character arg is actually
8601 a character. Pass an int to ENCODE_CHAR.
8602 * charset.h (ENCODE_CHAR): Verify that the character argument is no
8603 wider than 'int', as a compile-time check to prevent future regressions
8606 * character.c (char_string): Remove unnecessary casts.
8608 Make sure a 64-bit char is never passed to CHAR_STRING.
8609 Otherwise, CHAR_STRING would do the wrong thing on a 64-bit platform,
8610 by silently ignoring the top 32 bits, allowing some values
8611 that were far too large to be valid characters.
8612 * character.h: Include <verify.h>.
8613 (CHAR_STRING, CHAR_STRING_ADVANCE): Verify that the character
8614 arguments are no wider than unsigned, as a compile-time check
8615 to prevent future regressions in this area.
8617 * editfns.c (Fchar_to_string, general_insert_function, Finsert_char)
8618 (Fsubst_char_in_region):
8620 * xdisp.c (decode_mode_spec_coding):
8621 Adjust to CHAR_STRING's new requirement.
8622 * editfns.c (Finsert_char, Fsubst_char_in_region):
8623 * fns.c (concat): Check that character args are actually
8624 characters. Without this test, these functions did the wrong
8625 thing with wildly out-of-range values on 64-bit hosts.
8627 Remove incorrect casts to 'unsigned' that lose info on 64-bit hosts.
8628 These casts should not be needed on 32-bit hosts, either.
8629 * keyboard.c (read_char):
8630 * lread.c (Fload): Remove casts to unsigned.
8632 * lisp.h (UNSIGNED_CMP): New macro.
8633 This fixes comparison bugs on 64-bit hosts.
8634 (ASCII_CHAR_P): Use it.
8635 * casefiddle.c (casify_object):
8636 * character.h (ASCII_BYTE_P, CHAR_VALID_P)
8637 (SINGLE_BYTE_CHAR_P, CHAR_STRING):
8638 * composite.h (COMPOSITION_ENCODE_RULE_VALID):
8639 * dispextern.h (FACE_FROM_ID):
8640 * keyboard.c (read_char): Use UNSIGNED_CMP.
8642 * xmenu.c (dialog_selection_callback) [!USE_GTK]: Cast to intptr_t,
8643 not to EMACS_INT, to avoid GCC warning.
8645 * xfns.c (x_set_scroll_bar_default_width): Remove unused 'int' locals.
8647 * buffer.h (PTR_BYTE_POS, BUF_PTR_BYTE_POS): Remove harmful cast.
8648 The cast incorrectly truncated 64-bit byte offsets to 32 bits, and
8649 isn't needed on 32-bit machines.
8651 * buffer.c (Fgenerate_new_buffer_name):
8652 Use EMACS_INT for count, not int.
8653 (advance_to_char_boundary): Return EMACS_INT, not int.
8655 * data.c (Qcompiled_function): Now static.
8657 * window.c (window_body_lines): Now static.
8659 * image.c (gif_load): Rename local to avoid shadowing.
8661 * lisp.h (SAFE_ALLOCA_LISP): Check for integer overflow.
8662 (struct Lisp_Save_Value): Use ptrdiff_t, not int, for 'integer' member.
8663 * alloc.c (make_save_value): Integer argument is now of type
8665 (mark_object): Use ptrdiff_t, not int.
8666 * lisp.h (pD): New macro.
8667 * print.c (print_object): Use it.
8669 * alloc.c: Use EMACS_INT, not int, to count objects.
8670 (total_conses, total_markers, total_symbols, total_vector_size)
8671 (total_free_conses, total_free_markers, total_free_symbols)
8672 (total_free_floats, total_floats, total_free_intervals)
8673 (total_intervals, total_strings, total_free_strings):
8674 Now EMACS_INT, not int. All uses changed.
8675 (Fgarbage_collect): Compute overall total using a double, so that
8676 integer overflow is less likely to be a problem. Check for overflow
8677 when converting back to an integer.
8678 (n_interval_blocks, n_string_blocks, n_float_blocks, n_cons_blocks)
8679 (n_vectors, n_symbol_blocks, n_marker_blocks): Remove.
8680 These were 'int' variables that could overflow on 64-bit hosts;
8681 they were never used, so remove them instead of repairing them.
8682 (nzombies, ngcs, max_live, max_zombies): Now EMACS_INT, not 'int'.
8683 (inhibit_garbage_collection): Set gc_cons_threshold to max value.
8684 Previously, this ceilinged at INT_MAX, but that doesn't work on
8686 (allocate_pseudovector): Don't use EMACS_INT when int would do.
8688 * alloc.c (Fmake_bool_vector): Don't assume vector size fits in int.
8689 (allocate_vectorlike): Check for ptrdiff_t overflow.
8690 (mark_vectorlike, mark_char_table, mark_object): Avoid EMACS_UINT
8691 when a (possibly-narrower) signed value would do just as well.
8692 We prefer using signed arithmetic, to avoid comparison confusion.
8694 * alloc.c: Catch some string size overflows that we were missing.
8695 (XMALLOC_OVERRUN_CHECK_SIZE) [!XMALLOC_OVERRUN_CHECK]: Define to 0,
8696 for convenience in STRING_BYTES_MAX.
8697 (STRING_BYTES_MAX): New macro, superseding the old one in lisp.h.
8698 The definition here is exact; the one in lisp.h was approximate.
8699 (allocate_string_data): Check for string overflow. This catches
8700 some instances we weren't catching before. Also, it catches
8701 size_t overflow on (unusual) hosts where SIZE_MAX <= min
8702 (PTRDIFF_MAX, MOST_POSITIVE_FIXNUM), e.g., when size_t is 32 bits
8703 and ptrdiff_t and EMACS_INT are both 64 bits.
8705 * character.c, coding.c, doprnt.c, editfns.c, eval.c:
8706 All uses of STRING_BYTES_MAX replaced by STRING_BYTES_BOUND.
8707 * lisp.h (STRING_BYTES_BOUND): Rename from STRING_BYTES_MAX.
8709 * character.c (string_escape_byte8): Fix nbytes/nchars typo.
8711 * alloc.c (Fmake_string): Check for out-of-range init.
8713 2011-06-15 Stefan Monnier <monnier@iro.umontreal.ca>
8715 * eval.c (Fdefvaralias): Also mark the target as variable-special-p.
8717 2011-06-14 Jan Djärv <jan.h.d@swipnet.se>
8719 * xfns.c (x_set_scroll_bar_default_width): Remove argument to
8720 xg_get_default_scrollbar_width.
8722 * gtkutil.c: Include emacsgtkfixed.h if HAVE_GTK3.
8723 (int_gtk_range_get_value): Move to the scroll bar part of the file.
8724 (style_changed_cb): Call update_theme_scrollbar_width and call
8725 x_set_scroll_bar_default_width and xg_frame_set_char_size for
8726 all frames (Bug#8505).
8727 (xg_create_frame_widgets): Call emacs_fixed_new if HAVE_GTK3 (Bug#8505).
8728 Call gtk_window_set_resizable if HAVE_GTK3.
8729 (x_wm_set_size_hint): Call emacs_fixed_set_min_size with min width
8730 and height if HAVE_GTK3 (Bug#8505).
8731 (scroll_bar_width_for_theme): New variable.
8732 (update_theme_scrollbar_width): New function.
8733 (xg_get_default_scrollbar_width): Move code to
8734 update_theme_scrollbar_width, just return scroll_bar_width_for_theme.
8735 (xg_initialize): Call update_theme_scrollbar_width.
8737 * gtkutil.h (xg_get_default_scrollbar_width): Remove argument.
8739 * emacsgtkfixed.c, emacsgtkfixed.h: New files.
8741 2011-06-12 Martin Rudalics <rudalics@gmx.at>
8743 * frame.c (make_frame): Call other_buffer_safely instead of
8746 * window.c (temp_output_buffer_show): Call display_buffer with
8747 second argument Vtemp_buffer_show_specifiers and reset latter
8748 immediately after the call.
8749 (Vtemp_buffer_show_specifiers): New variable.
8750 (auto_window_vscroll_p, next_screen_context_lines)
8751 (Vscroll_preserve_screen_position): Remove leading asterisks from
8754 2011-06-12 Paul Eggert <eggert@cs.ucla.edu>
8756 Fix minor problems found by GCC 4.6.0 static checking.
8757 * buffer.c (Qclone_number): Remove for now, as it's unused.
8758 (record_buffer, Funrecord_buffer): Rename local to avoid shadowing.
8759 (record_buffer): Remove unused local.
8760 * frame.c (other_visible_frames, frame_buffer_list): Now static.
8761 (set_frame_buffer_list): Remove; unused.
8762 * frame.h (other_visible_frames): Remove decl.
8763 * keyboard.h (menu_items_inuse): Declare only if USE_GTK || USE_MOTIF.
8764 * lisp.h (frame_buffer_list, set_frame_buffer_list): Remove decls.
8765 (add_gpm_wait_descriptor, delete_gpm_wait_descriptor): Declare only
8767 * menu.c (menu_items_inuse): Now static unless USE_GTK || USE_MOTIF.
8768 * process.c (add_gpm_wait_descriptor, delete_gpm_wait_descriptor):
8769 Define only if HAVE_GPM.
8770 * widget.c (EmacsFrameResize, emacsFrameClassRec): Now static.
8771 (update_hints_inhibit): Remove; never set. All uses removed.
8772 * widgetprv.h (emacsFrameClassRec): Remove decl.
8773 * window.c (delete_deletable_window): Now returns void, since it
8774 wasn't returning anything.
8775 (compare_window_configurations): Remove unused locals.
8776 * xfns.c (x_set_scroll_bar_default_width): Remove unused locals.
8777 * xmenu.c (x_menu_set_in_use): Define only if USE_GTK || USE_MOTIF.
8778 (dialog_selection_callback) [!USE_GTK]: Prefer intptr_t for integers
8779 the same widths as pointers. This follows up on the 2011-05-06 patch.
8780 * xterm.c (x_alloc_lighter_color_for_widget): Define only if USE_LUCID.
8781 * xterm.h: Likewise.
8782 (x_menu_set_in_use): Declare only if USE_GTK || USE_MOTIF.
8784 2011-06-12 Juanma Barranquero <lekktu@gmail.com>
8786 * makefile.w32-in: Update dependencies.
8787 (LISP_H): Add lib/intprops.h.
8789 2011-06-11 Chong Yidong <cyd@stupidchicken.com>
8791 * image.c (gif_load): Add animation frame delay to the metadata.
8792 (syms_of_image): Use DEFSYM. New symbol `delay'.
8794 2011-06-11 Martin Rudalics <rudalics@gmx.at>
8796 * window.c (delete_deletable_window): Re-add.
8797 (Fset_window_configuration): Rewrite to handle dead buffers and
8798 consequently deletable windows.
8799 (window_tree, Fwindow_tree): Remove. Supply functionality in
8801 (compare_window_configurations): Simplify code.
8803 2011-06-11 Andreas Schwab <schwab@linux-m68k.org>
8805 * image.c (imagemagick_load_image): Fix type mismatch.
8806 (Fimagemagick_types): Likewise.
8808 * window.h (replace_buffer_in_windows): Declare.
8810 2011-06-11 Martin Rudalics <rudalics@gmx.at>
8812 * buffer.c: New Lisp objects Qbuffer_list_update_hook and
8813 Qclone_number. Remove external declaration of Qdelete_window.
8814 (Fbuffer_list): Rewrite doc-string. Minor restructuring of
8816 (Fget_buffer_create, Fmake_indirect_buffer, Frename_buffer):
8817 Run Qbuffer_list_update_hook if allowed.
8818 (Fother_buffer): Rewrite doc-string. Major rewrite for new
8819 buffer list implementation.
8820 (other_buffer_safely): New function.
8821 (Fkill_buffer): Replace call to replace_buffer_in_all_windows by
8822 calls to replace_buffer_in_windows and
8823 replace_buffer_in_windows_safely. Run Qbuffer_list_update_hook
8825 (record_buffer): Inhibit quitting and rewrite using quittable
8826 functions. Run Qbuffer_list_update_hook if allowed.
8827 (Frecord_buffer, Funrecord_buffer): New functions.
8828 (switch_to_buffer_1, Fswitch_to_buffer): Remove.
8829 Move switch-to-buffer to window.el.
8830 (bury-buffer): Move to window.el.
8831 (Vbuffer_list_update_hook): New variable.
8833 * lisp.h (other_buffer_safely): Add prototype in buffer.c
8836 * window.h (resize_frame_windows): Move up in code.
8837 (Fwindow_frame): Remove EXFUN.
8838 (replace_buffer_in_all_windows): Remove prototype.
8839 (replace_buffer_in_windows_safely): Add prototype.
8841 * window.c: Declare Qdelete_window static again. Move down
8842 declaration of select_count.
8843 (Fnext_window, Fprevious_window): Rewrite doc-strings.
8844 (Fother_window): Move to window.el.
8845 (window_loop): Remove DELETE_BUFFER_WINDOWS and UNSHOW_BUFFER
8846 cases. Add REPLACE_BUFFER_IN_WINDOWS_SAFELY case.
8847 (Fdelete_windows_on, Freplace_buffer_in_windows): Move to
8849 (replace_buffer_in_windows): Implement by calling
8850 Qreplace_buffer_in_windows.
8851 (replace_buffer_in_all_windows): Remove with some functionality
8852 moved into replace_buffer_in_windows_safely.
8853 (replace_buffer_in_windows_safely): New function.
8854 (select_window_norecord, select_frame_norecord): Move in front
8855 of run_window_configuration_change_hook. Remove now obsolete
8857 (Fset_window_buffer): Rewrite doc-string.
8858 Call Qrecord_window_buffer.
8859 (keys_of_window): Move binding for other-window to window.el.
8861 2011-06-11 Chong Yidong <cyd@stupidchicken.com>
8863 * dispextern.h (struct image): Replace data member, whose int_val
8864 and ptr_val fields were not used by anything, with a single
8867 * image.c (Fimage_metadata, make_image, mark_image, tiff_load)
8868 (gif_clear_image, gif_load, imagemagick_load_image)
8869 (gs_clear_image, gs_load): Callers changed.
8871 2011-06-10 Paul Eggert <eggert@cs.ucla.edu>
8873 * buffer.h: Include <time.h>, for time_t.
8874 Needed to build on FreeBSD 8.2. Problem reported by Herbert J. Skuhra.
8876 Fix minor problems found by static checking.
8878 * image.c (PixelGetMagickColor): Declare if ImageMagick headers don't.
8880 Make identifiers static if they are not used in other modules.
8881 * data.c (Qcompiled_function, Qframe, Qvector):
8882 * image.c (QimageMagick, Qsvg):
8883 * minibuf.c (Qmetadata):
8884 * window.c (resize_window_check, resize_root_window): Now static.
8885 * window.h (resize_window_check, resize_root_window): Remove decls.
8887 * window.c (window_deletion_count, delete_deletable_window):
8889 (window_body_lines): Now static.
8890 (Fdelete_other_windows_internal): Mark vars as initialized.
8891 Make sure 'resize_failed' is initialized.
8892 (run_window_configuration_change_hook): Rename local to avoid shadowing.
8893 (resize_window_apply): Remove unused local.
8894 * window.h (delete_deletable_window): Remove decl.
8896 * image.c (gif_load, svg_load_image): Rename locals to avoid shadowing.
8897 (imagemagick_load_image): Fix pointer signedness problem by changing
8898 last arg from unsigned char * to char *. All uses changed.
8899 Also, fix a local for similar reasons.
8900 Remove unused locals. Remove locals to avoid shadowing.
8901 (fn_rsvg_handle_free): Remove; unused.
8902 (svg_load, svg_load_image): Fix pointer signedness problem.
8903 (imagemagick_load_image): Don't use garbage pointer image_wand.
8905 * ftfont.c (ftfont_get_metrics, ftfont_drive_otf): Remove unused locals.
8907 2011-06-10 Chong Yidong <cyd@stupidchicken.com>
8909 * image.c (gif_load): Fix omitted cast error introduced by
8912 2011-06-10 Martin Rudalics <rudalics@gmx.at>
8914 * window.h (resize_proportionally, orig_total_lines)
8915 (orig_top_line): Remove from window structure.
8916 (set_window_height, set_window_width, change_window_heights)
8917 (Fdelete_window): Remove prototypes.
8918 (resize_frame_windows): Remove duplicate declaration.
8920 2011-06-10 Eli Zaretskii <eliz@gnu.org>
8922 * window.h (resize_frame_windows, resize_window_check)
8923 (delete_deletable_window, resize_root_window)
8924 (resize_frame_windows): Declare prototypes.
8926 * window.c (resize_window_apply): Make definition be "static" to
8927 match the prototype.
8929 2011-06-10 Martin Rudalics <rudalics@gmx.at>
8931 * window.c: Remove declarations of Qwindow_size_fixed,
8932 window_min_size_1, window_min_size_2, window_min_size,
8933 size_window, window_fixed_size_p, enlarge_window, delete_window.
8934 Remove static from declaration of Qdelete_window, it's
8935 temporarily needed by Fbury_buffer.
8936 (replace_window): Don't assign orig_top_line and
8938 (Fdelete_window, delete_window): Remove. Window deletion is
8939 handled by window.el.
8940 (window_loop): Remove DELETE_OTHER_WINDOWS case.
8941 Replace Fdelete_window calls with calls to Qdelete_window.
8942 (Fdelete_other_windows): Remove. Deleting other windows is
8943 handled by window.el.
8944 (window_fixed_size_p): Remove. Fixed-sizeness of windows is
8945 handled in window.el.
8946 (window_min_size_2, window_min_size_1, window_min_size): Remove.
8947 Window minimum sizes are handled in window.el.
8948 (shrink_windows, size_window, set_window_height)
8949 (set_window_width, change_window_heights, window_height)
8950 (window_width, CURBEG, CURSIZE, enlarge_window)
8951 (adjust_window_trailing_edge, Fadjust_window_trailing_edge)
8952 (Fenlarge_window, Fshrink_window): Remove. Window resizing is
8953 handled in window.el.
8954 (make_dummy_parent): Rename to make_parent_window and give it a
8955 second argument horflag.
8956 (make_window): Don't set resize_proportionally any more.
8957 (Fsplit_window): Remove. Windows are split in window.el.
8958 (save_restore_action, save_restore_orig_size)
8959 (shrink_window_lowest_first, save_restore_orig_size): Remove.
8960 Resize mini windows in window.el.
8961 (grow_mini_window, shrink_mini_window): Implement by calling
8962 Qresize_root_window_vertically, resize_window_check and
8963 resize_window_apply.
8964 (saved_window, Fset_window_configuration, save_window_save):
8965 Do not handle orig_top_line, orig_total_lines, and
8966 resize_proportionally.
8967 (window_min_height, window_min_width): Move to window.el.
8968 (keys_of_window): Move bindings for delete-other-windows,
8969 split-window, delete-window and enlarge-window to window.el.
8971 * buffer.c: Temporarily extern Qdelete_window.
8972 (Fbury_buffer): Temporarily call Qdelete_window instead of
8973 Fdelete_window (Fbury_buffer will move to window.el soon).
8975 * frame.c (set_menu_bar_lines_1): Remove code handling
8976 orig_top_line and orig_total_lines.
8978 * dispnew.c (adjust_frame_glyphs_initially): Don't use
8979 set_window_height but set heights directly.
8980 (change_frame_size_1): Use resize_frame_windows.
8982 * xdisp.c (init_xdisp): Don't use set_window_height but set
8985 * xfns.c (x_set_menu_bar_lines, x_set_tool_bar_lines):
8986 Use resize_frame_windows instead of change_window_heights and run
8987 run_window_configuration_change_hook.
8989 * w32fns.c (x_set_tool_bar_lines): Use resize_frame_windows
8990 instead of change_window_heights and run
8991 run_window_configuration_change_hook.
8993 2011-06-09 Martin Rudalics <rudalics@gmx.at>
8995 * window.c (replace_window): Rename second argument REPLACEMENT to
8996 NEW. New third argument SETFLAG. Rewrite.
8997 (delete_window, make_dummy_parent): Call replace_window with
8999 (window_list_1): Move down in code.
9000 (run_window_configuration_change_hook): Move set_buffer part
9001 before select_frame_norecord part in order to unwind correctly.
9002 Rename count1 to count.
9003 (recombine_windows, delete_deletable_window, resize_root_window)
9004 (Fdelete_other_windows_internal)
9005 (Frun_window_configuration_change_hook, make_parent_window)
9006 (resize_window_check, resize_window_apply, Fresize_window_apply)
9007 (resize_frame_windows, Fsplit_window_internal)
9008 (Fdelete_window_internal, Fresize_mini_window_internal):
9010 (syms_of_window): New variables Vwindow_splits and Vwindow_nest.
9012 2011-06-08 Martin Rudalics <rudalics@gmx.at>
9014 * window.h (window): Add some new members to window structure -
9015 normal_lines, normal_cols, new_total, new_normal, clone_number,
9016 splits, nest, prev_buffers, next_buffers.
9017 (WINDOW_TOTAL_SIZE): Move here from window.c.
9018 (MIN_SAFE_WINDOW_WIDTH, MIN_SAFE_WINDOW_HEIGHT): Define here.
9020 * window.c (Fwindow_height, Fwindow_width, Fwindow_full_width_p):
9022 (make_dummy_parent): Set new members of windows structure.
9023 (make_window): Move down in code. Handle new members of window
9025 (Fwindow_clone_number, Fwindow_splits, Fset_window_splits)
9026 (Fwindow_nest, Fset_window_nest, Fwindow_new_total)
9027 (Fwindow_normal_size, Fwindow_new_normal, Fwindow_prev_buffers)
9028 (Fset_window_prev_buffers, Fwindow_next_buffers)
9029 (Fset_window_next_buffers, Fset_window_clone_number):
9031 (Fwindow_hscroll, Fwindow_at, Fwindow_point, Fwindow_start)
9032 (Fwindow_end, Fwindow_line_height, Fset_window_dedicated_p):
9034 (Fwindow_parameters, Fwindow_parameter, Fset_window_parameter):
9035 Argument WINDOW can be now internal window too.
9036 (Fwindow_use_time): Move up in code.
9037 (Fget_buffer_window): Rename argument FRAME to ALL-FRAMES.
9039 (Fset_window_configuration, saved_window)
9040 (Fcurrent_window_configuration, save_window_save): Handle new
9041 members of window structure.
9042 (WINDOW_TOTAL_SIZE, MIN_SAFE_WINDOW_WIDTH)
9043 (MIN_SAFE_WINDOW_HEIGHT): Move to window.h.
9044 (syms_of_window): New Lisp objects Qrecord_window_buffer,
9045 Qwindow_deletable_p, Qdelete_window, Qreplace_buffer_in_windows,
9046 Qget_mru_window, Qresize_root_window,
9047 Qresize_root_window_vertically, Qsafe, Qabove, Qbelow,
9048 Qauto_buffer_name; staticpro them.
9050 2011-06-07 Martin Rudalics <rudalics@gmx.at>
9052 * window.c (Fwindow_total_size, Fwindow_left_column)
9053 (Fwindow_top_line, window_body_lines, Fwindow_body_size)
9054 (Fwindow_list_1): New functions.
9055 (window_box_text_cols): Replace with window_body_cols.
9056 (Fwindow_width, Fscroll_left, Fscroll_right):
9057 Use window_body_cols instead of window_box_text_cols.
9058 (delete_window, Fset_window_configuration):
9059 Call delete_all_subwindows with window as argument.
9060 (delete_all_subwindows): Take a window as argument and not a
9062 (window_loop): Remove handling of GET_LRU_WINDOW and
9064 (Fget_lru_window, Fget_largest_window): Move to window.el.
9066 * window.h: Extern window_body_cols instead of
9067 window_box_text_cols. delete_all_subwindows now takes a
9068 Lisp_Object as argument.
9070 * indent.c (compute_motion, Fcompute_motion):
9071 Use window_body_cols instead of window_box_text_cols.
9073 * frame.c (delete_frame): Call delete_all_subwindows with root
9076 2011-06-07 Daniel Colascione <dan.colascione@gmail.com>
9078 * fns.c (Fputhash): Document return value.
9080 2011-06-06 Chong Yidong <cyd@stupidchicken.com>
9082 * image.c (gif_load): Implement gif89a spec "no disposal" method.
9084 2011-06-06 Paul Eggert <eggert@cs.ucla.edu>
9086 Cons<->int and similar integer overflow fixes (Bug#8794).
9088 Check for overflow when converting integer to cons and back.
9089 * charset.c (Fdefine_charset_internal, Fdecode_char):
9090 Use cons_to_unsigned to catch overflow.
9091 (Fencode_char): Use INTEGER_TO_CONS.
9092 * composite.h (LGLYPH_CODE): Use cons_to_unsigned.
9093 (LGLYPH_SET_CODE): Use INTEGER_TO_CONS.
9094 * data.c (long_to_cons, cons_to_long): Remove.
9095 (cons_to_unsigned, cons_to_signed): New functions.
9096 These signal an error for invalid or out-of-range values.
9097 * dired.c (Ffile_attributes): Use INTEGER_TO_CONS.
9098 * fileio.c (Fset_visited_file_modtime): Use CONS_TO_INTEGER.
9099 * font.c (Ffont_variation_glyphs):
9100 * fontset.c (Finternal_char_font): Use INTEGER_TO_CONS.
9101 * lisp.h: Include <intprops.h>.
9102 (INTEGER_TO_CONS, CONS_TO_INTEGER): New macros.
9103 (cons_to_signed, cons_to_unsigned): New decls.
9104 (long_to_cons, cons_to_long): Remove decls.
9105 * undo.c (record_first_change): Use INTEGER_TO_CONS.
9106 (Fprimitive_undo): Use CONS_TO_INTEGER.
9107 * xfns.c (Fx_window_property): Likewise.
9108 * xselect.c: Include <limits.h>.
9109 (x_own_selection, selection_data_to_lisp_data):
9110 Use INTEGER_TO_CONS.
9111 (x_handle_selection_request, x_handle_selection_clear)
9112 (x_get_foreign_selection, Fx_disown_selection_internal)
9113 (Fx_get_atom_name, x_send_client_event): Use CONS_TO_INTEGER.
9114 (lisp_data_to_selection_data): Use cons_to_unsigned.
9115 (x_fill_property_data): Use cons_to_signed.
9116 Report values out of range.
9118 Check for buffer and string overflow more precisely.
9119 * buffer.h (BUF_BYTES_MAX): New macro.
9120 * lisp.h (STRING_BYTES_MAX): New macro.
9121 * alloc.c (Fmake_string):
9122 * character.c (string_escape_byte8):
9123 * coding.c (coding_alloc_by_realloc):
9124 * doprnt.c (doprnt):
9125 * editfns.c (Fformat):
9127 Use STRING_BYTES_MAX, not MOST_POSITIVE_FIXNUM,
9128 since they may not be the same number.
9129 * editfns.c (Finsert_char):
9130 * fileio.c (Finsert_file_contents):
9131 Likewise for BUF_BYTES_MAX.
9133 * image.c: Use ptrdiff_t, not int, for sizes.
9134 (slurp_file): Switch from int to ptrdiff_t.
9136 (slurp_file): Check that file size fits in both size_t (for
9137 malloc) and ptrdiff_t (for sanity and safety).
9139 * fileio.c (Fverify_visited_file_modtime): Avoid time overflow
9140 if b->modtime has its maximal value.
9142 * dired.c (Ffile_attributes): Don't assume EMACS_INT has >32 bits.
9144 Don't assume time_t can fit into int.
9145 * buffer.h (struct buffer.modtime): Now time_t, not int.
9146 * fileio.c (Fvisited_file_modtime): No need for time_t cast now.
9147 * undo.c (Fprimitive_undo): Use time_t, not int, for time_t value.
9149 Minor fixes for signed vs unsigned integers.
9150 * character.h (MAYBE_UNIFY_CHAR):
9151 * charset.c (maybe_unify_char):
9152 * keyboard.c (read_char, reorder_modifiers):
9153 XINT -> XFASTINT, since the integer must be nonnegative.
9154 * ftfont.c (ftfont_spec_pattern):
9155 * keymap.c (access_keymap, silly_event_symbol_error):
9156 XUINT -> XFASTINT, since the integer must be nonnegative.
9157 (Fsingle_key_description, preferred_sequence_p): XUINT -> XINT,
9158 since it makes no difference and we prefer signed.
9159 * keyboard.c (record_char): Use XUINT when all the neighbors do.
9160 (access_keymap): NATNUMP -> INTEGERP, since the integer must be
9163 2011-06-06 Stefan Monnier <monnier@iro.umontreal.ca>
9165 * window.h (Fwindow_frame): Declare.
9167 2011-06-06 Paul Eggert <eggert@cs.ucla.edu>
9169 * alloc.c: Simplify handling of large-request failures (Bug#8800).
9170 (SPARE_MEMORY): Always define.
9171 (LARGE_REQUEST): Remove.
9172 (memory_full): Use SPARE_MEMORY rather than LARGE_REQUEST.
9174 2011-06-06 Martin Rudalics <rudalics@gmx.at>
9176 * lisp.h: Move EXFUNS for Fframe_root_window,
9177 Fframe_first_window and Fset_frame_selected_window to window.h.
9179 * window.h: Move EXFUNS for Fframe_root_window,
9180 Fframe_first_window and Fset_frame_selected_window here from
9183 * frame.c (Fwindow_frame, Fframe_first_window)
9184 (Fframe_root_window, Fframe_selected_window)
9185 (Fset_frame_selected_window): Move to window.c.
9186 (Factive_minibuffer_window): Move to minibuf.c.
9187 (Fother_visible_frames_p): New function.
9189 * minibuf.c (Factive_minibuffer_window): Move here from frame.c.
9191 * window.c (decode_window, decode_any_window): Move up in code.
9192 (Fwindowp, Fwindow_live_p): Rewrite doc-strings.
9193 (inhibit_frame_unsplittable): Remove unused variable.
9194 (Fwindow_buffer): Move up and rewrite doc-string.
9195 (Fwindow_parent, Fwindow_vchild, Fwindow_hchild, Fwindow_next)
9196 (Fwindow_prev): New functions.
9197 (Fwindow_frame): Move here from frame.c. Accept any window as
9199 (Fframe_root_window, Fframe_first_window)
9200 (Fframe_selected_window): Move here from frame.c. Accept frame
9201 or arbitrary window as argument. Update doc-strings.
9202 (Fminibuffer_window): Move up in code.
9203 (Fwindow_minibuffer_p): Move up in code and simplify.
9204 (Fset_frame_selected_window): Move here from frame.c.
9206 (Fselected_window, select_window, Fselect_window): Move up in
9207 code. Minor doc-string fixes.
9209 2011-06-06 Paul Eggert <eggert@cs.ucla.edu>
9211 * alloc.c (memory_full) [SYSTEM_MALLOC]: Port to MacOS (Bug#8800).
9212 Do not assume that spare memory exists; that assumption is valid
9213 only if SYSTEM_MALLOC.
9214 (LARGE_REQUEST): New macro, so that the issue of large requests
9215 is separated from the issue of spare memory.
9217 2011-06-05 Andreas Schwab <schwab@linux-m68k.org>
9219 * editfns.c (Fformat): Correctly handle zero flag with hexadecimal
9222 * gtkutil.c (xg_get_default_scrollbar_width): Avoid warning.
9224 * xfns.c (x_set_scroll_bar_default_width): Move declarations
9227 2011-06-05 Jan Djärv <jan.h.d@swipnet.se>
9229 * gtkutil.c (xg_get_default_scrollbar_width): New function.
9231 * gtkutil.h: Declare xg_get_default_scrollbar_width.
9233 * xfns.c (x_set_scroll_bar_default_width): If USE_GTK, get
9234 min width by calling x_set_scroll_bar_default_width (Bug#8505).
9236 2011-06-05 Juanma Barranquero <lekktu@gmail.com>
9238 * xdisp.c (single_display_spec_intangible_p): Remove declaration.
9240 2011-06-04 Chong Yidong <cyd@stupidchicken.com>
9242 * xselect.c (x_clipboard_manager_save): Remove redundant arg.
9243 (x_clipboard_manager_save): Add return value.
9244 (x_clipboard_manager_error_1, x_clipboard_manager_error_2):
9246 (x_clipboard_manager_save_frame, x_clipboard_manager_save_all):
9247 Obey Vx_select_enable_clipboard_manager. Catch errors in
9248 x_clipboard_manager_save (Bug#8779).
9249 (Vx_select_enable_clipboard_manager): New variable.
9250 (x_get_foreign_selection): Reduce scope of x_catch_errors (Bug#8790).
9252 2011-06-04 Dan Nicolaescu <dann@ics.uci.edu>
9254 * emacs.c (main): Warn when starting a GTK emacs in daemon mode.
9256 2011-06-04 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
9258 * fringe.c (update_window_fringes): Don't update overlay arrow bitmap
9259 in the current matrix if keep_current_p is non-zero.
9261 2011-06-04 Eli Zaretskii <eliz@gnu.org>
9263 * bidi.c (bidi_level_of_next_char): Fix last change.
9265 2011-06-03 Eli Zaretskii <eliz@gnu.org>
9267 Support bidi reordering of text covered by display properties.
9269 * bidi.c (bidi_copy_it): Use offsetof instead of emulating it.
9270 (bidi_fetch_char, bidi_fetch_char_advance): New functions.
9271 (bidi_cache_search, bidi_cache_iterator_state)
9272 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak)
9273 (bidi_level_of_next_char, bidi_move_to_visually_next):
9274 Support character positions inside a run of characters covered by a
9276 (bidi_paragraph_init, bidi_resolve_explicit_1)
9277 (bidi_level_of_next_char): Call bidi_fetch_char and
9278 bidi_fetch_char_advance instead of FETCH_CHAR and
9280 (bidi_init_it): Initialize new members.
9281 (LRE_CHAR, RLE_CHAR, PDF_CHAR, LRO_CHAR, RLO_CHAR): Remove macro
9283 (bidi_explicit_dir_char): Lookup character type in bidi_type_table,
9284 instead of using explicit *_CHAR codes.
9285 (bidi_resolve_explicit, bidi_resolve_weak):
9286 Use FETCH_MULTIBYTE_CHAR instead of FETCH_CHAR, as reordering of
9287 bidirectional text is supported only in multibyte buffers.
9288 (bidi_init_it): Accept additional argument FRAME_WINDOW_P and use
9289 it to initialize the frame_window_p member of struct bidi_it.
9290 (bidi_cache_iterator_state, bidi_resolve_explicit_1)
9291 (bidi_resolve_explicit, bidi_resolve_weak)
9292 (bidi_level_of_next_char, bidi_move_to_visually_next): Abort if
9293 bidi_it->nchars is non-positive.
9294 (bidi_level_of_next_char): Don't try to lookup the cache for the
9295 next/previous character if nothing is cached there yet, or if we
9296 were just reseat()'ed to a new position.
9298 * xdisp.c (set_cursor_from_row): Set start and stop points
9299 according to the row's direction when priming the loop that looks
9300 for the glyph on which to display cursor.
9301 (single_display_spec_intangible_p): Function deleted.
9302 (display_prop_intangible_p): Reimplement to call
9303 handle_display_spec instead of single_display_spec_intangible_p.
9304 Accept 3 additional arguments needed by handle_display_spec.
9305 This fixes incorrect cursor motion across display property with complex
9306 values: lists, `(when COND...)' forms, etc.
9307 (single_display_spec_string_p): Support property values that are
9308 lists with the argument STRING its top-level element.
9309 (display_prop_string_p): Fix the condition for processing a
9310 property that is a list to be consistent with handle_display_spec.
9311 (handle_display_spec): New function, refactored from the
9312 last portion of handle_display_prop.
9313 (compute_display_string_pos): Accept additional argument
9314 FRAME_WINDOW_P. Call handle_display_spec to determine whether the
9315 value of a `display' property is a "replacing spec".
9316 (handle_single_display_spec): Accept 2 additional arguments BUFPOS
9317 and FRAME_WINDOW_P. If IT is NULL, don't set up the iterator from
9318 the display property, but just return a value indicating whether
9319 the display property will replace the characters it covers.
9320 (Fcurrent_bidi_paragraph_direction): Initialize the nchars and
9321 frame_window_p members of struct bidi_it.
9322 (compute_display_string_pos, compute_display_string_end):
9324 (push_it): Accept second argument POSITION, where pop_it should
9325 jump to continue iteration.
9326 (reseat_1): Initialize bidi_it.disp_pos.
9328 * keyboard.c (adjust_point_for_property): Adjust the call to
9329 display_prop_intangible_p to its new signature.
9331 * dispextern.h (struct bidi_it): New member frame_window_p.
9332 (bidi_init_it): Update prototypes.
9333 (display_prop_intangible_p): Update prototype.
9334 (compute_display_string_pos, compute_display_string_end):
9336 (struct bidi_it): New members nchars and disp_pos. ch_len is now
9339 2011-06-02 Paul Eggert <eggert@cs.ucla.edu>
9341 Malloc failure behavior now depends on size of allocation.
9342 * alloc.c (buffer_memory_full, memory_full): New arg NBYTES.
9343 * lisp.h: Change signatures accordingly.
9344 * alloc.c, buffer.c, editfns.c, menu.c, minibuf.c, xterm.c:
9345 All callers changed. (Bug#8762)
9347 * gnutls.c: Use Emacs's memory allocators.
9348 Without this change, the gnutls library would invoke malloc etc.
9349 directly, which causes problems on non-SYNC_INPUT hosts, and which
9350 runs afoul of improving memory_full behavior. (Bug#8761)
9351 (fn_gnutls_global_set_mem_functions): New macro or function pointer.
9352 (emacs_gnutls_global_init): Use it to specify xmalloc, xrealloc,
9353 xfree instead of the default malloc, realloc, free.
9354 (Fgnutls_boot): No need to check for memory allocation failure,
9355 since xmalloc does that for us.
9357 Remove arbitrary limit of 2**31 entries in hash tables. (Bug#8771)
9358 * category.c (hash_get_category_set):
9359 * ccl.c (ccl_driver):
9360 * charset.c (Fdefine_charset_internal):
9361 * charset.h (struct charset.hash_index):
9362 * composite.c (get_composition_id, gstring_lookup_cache)
9363 (composition_gstring_put_cache):
9364 * composite.h (struct composition.hash_index):
9365 * dispextern.h (struct image.hash):
9366 * fns.c (next_almost_prime, larger_vector, cmpfn_eql)
9367 (cmpfn_equal, cmpfn_user_defined, hashfn_eq, hashfn_eql)
9368 (hashfn_equal, hashfn_user_defined, make_hash_table)
9369 (maybe_resize_hash_table, hash_lookup, hash_put)
9370 (hash_remove_from_table, hash_clear, sweep_weak_table, SXHASH_COMBINE)
9371 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector)
9372 (Fsxhash, Fgethash, Fputhash, Fmaphash):
9373 * image.c (make_image, search_image_cache, lookup_image)
9374 (xpm_put_color_table_h):
9375 * lisp.h (struct Lisp_Hash_Table):
9376 * minibuf.c (Ftry_completion, Fall_completions, Ftest_completion):
9377 * print.c (print): Use 'EMACS_UINT' and 'EMACS_INT'
9378 for hashes and hash indexes, instead of 'unsigned' and 'int'.
9379 * alloc.c (allocate_vectorlike):
9380 Check for overflow in vector size calculations.
9381 * ccl.c (ccl_driver):
9382 Check for overflow when converting EMACS_INT to int.
9383 * fns.c, image.c: Remove unnecessary static decls that would otherwise
9384 need to be updated by these changes.
9385 * fns.c (make_hash_table, maybe_resize_hash_table):
9386 Check for integer overflow with large hash tables.
9387 (make_hash_table, maybe_resize_hash_table, Fmake_hash_table):
9388 Prefer the faster XFLOAT_DATA to XFLOATINT where either will do.
9389 (SXHASH_REDUCE): New macro.
9390 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector):
9391 Use it instead of discarding useful hash info with large hash values.
9392 (sxhash_float): New function.
9393 (sxhash): Use it. No more need for "& INTMASK" due to above changes.
9394 * lisp.h (FIXNUM_BITS): New macro, useful for SXHASH_REDUCE etc.
9395 (MOST_NEGATIVE_FIXNUM, MOST_POSITIVE_FIXNUM, INTMASK):
9396 Rewrite to use FIXNUM_BITS, as this simplifies things.
9397 (next_almost_prime, larger_vector, sxhash, hash_lookup, hash_put):
9398 Adjust signatures to match updated version of code.
9399 (consing_since_gc): Now EMACS_INT, since a single hash table can
9400 use more than INT_MAX bytes.
9402 2011-06-01 Dan Nicolaescu <dann@ics.uci.edu>
9404 Make it possible to build with GCC-4.6+ -O2 -flto.
9406 * emacs.c (__malloc_initialize_hook): Mark as EXTERNALLY_VISIBLE.
9408 2011-06-01 Stefan Monnier <monnier@iro.umontreal.ca>
9410 * minibuf.c (get_minibuffer, read_minibuf_unwind):
9411 Call minibuffer-inactive-mode.
9413 2011-05-31 Juanma Barranquero <lekktu@gmail.com>
9415 * makefile.w32-in ($(BLD)/data.$(O), $(BLD)/editfns.$(O)):
9416 Update dependencies.
9418 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
9420 * data.c (init_data): Remove code for UTS, this system is not
9423 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
9425 Don't force ./temacs to start in terminal mode.
9427 * frame.c (make_initial_frame): Initialize faces in all cases, not
9428 only when CANNOT_DUMP is defined.
9429 * dispnew.c (init_display): Remove CANNOT_DUMP condition.
9431 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
9433 * dispnew.c (add_window_display_history): Use const for the string
9434 pointer. Remove declaration, not needed.
9436 2011-05-31 Paul Eggert <eggert@cs.ucla.edu>
9438 Use 'inline', not 'INLINE'.
9439 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00914.html>
9440 * alloc.c, fontset.c (INLINE): Remove.
9441 * alloc.c, bidi.c, charset.c, coding.c, dispnew.c, fns.c, image.c:
9442 * intervals.c, keyboard.c, process.c, syntax.c, textprop.c, w32term.c:
9443 * xdisp.c, xfaces.c, xterm.c: Replace all uses of INLINE with inline.
9444 * gmalloc.c (register_heapinfo): Use inline unconditionally.
9445 * lisp.h (LISP_MAKE_RVALUE): Use inline, not __inline__.
9447 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
9449 Make it possible to run ./temacs.
9451 * callproc.c (set_initial_environment): Remove CANNOT_DUMP code,
9452 syms_of_callproc does the same thing. Remove test for
9453 "initialized", do it in the caller.
9454 * emacs.c (main): Avoid calling set_initial_environment when dumping.
9456 2011-05-31 Stefan Monnier <monnier@iro.umontreal.ca>
9458 * minibuf.c (Finternal_complete_buffer): Return `category' metadata.
9459 (read_minibuf): Use get_minibuffer.
9460 (syms_of_minibuf): Use DEFSYM.
9461 (Qmetadata): New var.
9462 * data.c (Qbuffer): Don't make it static.
9463 (syms_of_data): Use DEFSYM.
9465 2011-05-31 Paul Eggert <eggert@cs.ucla.edu>
9467 * ccl.c (CCL_CODE_RANGE): Allow negative numbers. (Bug#8751)
9468 (CCL_CODE_MIN): New macro.
9470 2011-05-30 Paul Eggert <eggert@cs.ucla.edu>
9472 * alloc.c (lisp_align_malloc): Omit unnecessary val==NULL tests.
9474 * eval.c (Qdebug): Now static.
9475 * lisp.h (Qdebug): Remove decl. This reverts a part of the
9476 2011-04-26T11:26:05Z!dan.colascione@gmail.com that inadvertently undid part of
9477 2011-04-14T06:48:41Z!eggert@cs.ucla.edu.
9479 2011-05-29 Chong Yidong <cyd@stupidchicken.com>
9481 * image.c: Various fixes to ImageMagick code comments.
9482 (Fimagemagick_types): Doc fix.
9484 2011-05-29 Paul Eggert <eggert@cs.ucla.edu>
9486 Minor fixes prompted by GCC 4.6.0 warnings.
9488 * xselect.c (converted_selections, conversion_fail_tag): Now static.
9490 * emacs.c [HAVE_X_WINDOWS]: Include "xterm.h".
9491 (x_clipboard_manager_save_all): Move extern decl to ...
9492 * xterm.h: ... here, so that it can be checked for consistency.
9494 2011-05-29 Chong Yidong <cyd@stupidchicken.com>
9496 * xselect.c (x_clipboard_manager_save_frame)
9497 (x_clipboard_manager_save_all): New functions.
9498 (Fx_clipboard_manager_save): Lisp function deleted.
9500 * emacs.c (Fkill_emacs): Call x_clipboard_manager_save_all.
9501 * frame.c (delete_frame): Call x_clipboard_manager_save_frame.
9503 * xterm.h: Update prototype.
9505 2011-05-28 William Xu <william.xwl@gmail.com>
9507 * nsterm.m (ns_term_shutdown): Synchronize user defaults before
9510 2011-05-28 Jim Meyering <meyering@redhat.com>
9512 Avoid a sign-extension bug in crypto_hash_function.
9513 * fns.c (to_uchar): Define.
9514 (crypto_hash_function): Use it to convert some newly-signed
9515 variables to unsigned, to avoid sign-extension bugs. For example,
9516 without this change, (md5 "truc") would evaluate to
9517 45723a2aff78ff4fff7fff1114760e62 rather than the expected
9518 45723a2af3788c4ff17f8d1114760e62. Reported by Antoine Levitt in
9519 https://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00883.html.
9521 2011-05-27 Paul Eggert <eggert@cs.ucla.edu>
9523 Integer overflow fixes.
9525 * dbusbind.c: Serial number integer overflow fixes.
9526 (CHECK_DBUS_SERIAL_GET_SERIAL): New macro.
9527 (Fdbus_call_method_asynchronously, xd_read_message_1): Use a float
9528 to hold a serial number that is too large for a fixnum.
9529 (Fdbus_method_return_internal, Fdbus_method_error_internal):
9530 Check for serial numbers out of range. Decode any serial number
9531 that was so large that it became a float. (Bug#8722)
9533 * dbusbind.c: Use XFASTINT rather than XUINT, and check for nonneg.
9534 (Fdbus_call_method, Fdbus_call_method_asynchronously):
9535 Use XFASTINT rather than XUINT when numbers are nonnegative.
9536 (xd_append_arg, Fdbus_method_return_internal):
9537 (Fdbus_method_error_internal): Likewise. Also, for unsigned
9538 arguments, check that Lisp number is nonnegative, rather than
9539 silently wrapping negative numbers around. (Bug#8722)
9540 (xd_read_message_1): Don't assume dbus_uint32_t can fit in int.
9543 * data.c (arith_driver, Flsh): Avoid unnecessary casts to EMACS_UINT.
9545 * ccl.c (ccl_driver): Redo slightly to avoid the need for 'unsigned'.
9547 ccl: Add integer overflow checks.
9548 * ccl.c (CCL_CODE_MAX, GET_CCL_RANGE, GET_CCL_CODE, GET_CCL_INT):
9549 (IN_INT_RANGE): New macros.
9550 (ccl_driver): Use them to check for integer overflow when
9551 decoding a CCL program. Many of the new checks are whether XINT (x)
9552 fits in int; it doesn't always, on 64-bit hosts. The new version
9553 doesn't catch all possible integer overflows, but it's an
9554 improvement. (Bug#8719)
9556 * alloc.c (make_event_array): Use XINT, not XUINT.
9557 There's no need for unsigned here.
9559 * mem-limits.h (EXCEEDS_LISP_PTR) [!USE_LSB_TAG]: EMACS_UINT -> uintptr_t
9560 This follows up to the 2011-05-06 change that substituted uintptr_t
9561 for EMACS_INT. This case wasn't caught back then.
9563 Rework Fformat to avoid integer overflow issues.
9564 * editfns.c: Include <float.h> unconditionally, as it's everywhere
9565 now (part of C89). Include <verify.h>.
9566 (MAX_10_EXP, CONVERTED_BYTE_SIZE): Remove; no longer needed.
9567 (pWIDE, pWIDElen, signed_wide, unsigned_wide): New defns.
9568 (Fformat): Avoid the prepass trying to compute sizes; it was only
9569 approximate and thus did not catch overflow reliably. Instead, walk
9570 through the format just once, formatting and computing sizes as we go,
9571 checking for integer overflow at every step, and allocating a larger
9572 buffer as needed. Keep track separately whether the format is
9573 multibyte. Keep only the most-recently calculated precision, rather
9574 than them all. Record whether each argument has been converted to
9575 string. Use EMACS_INT, not int, for byte and char and arg counts.
9576 Support field widths and precisions larger than INT_MAX. Avoid
9577 sprintf's undefined behavior with conversion specifications such as %#d
9578 and %.0c. Fix bug with strchr succeeding on '\0' when looking for
9579 flags. Fix bug with (format "%c" 256.0). Avoid integer overflow when
9580 formatting out-of-range floating point numbers with int
9583 * lisp.h (FIXNUM_OVERFLOW_P): Work even if arg is a NaN.
9585 * data.c: Avoid integer truncation in expressions involving floats.
9586 * data.c: Include <intprops.h>.
9587 (arith_driver): When there's an integer overflow in an expression
9588 involving floating point, convert the integers to floating point
9589 so that the resulting value does not suffer from catastrophic
9590 integer truncation. For example, on a 64-bit host (* 4
9591 most-negative-fixnum 0.5) should yield about -4.6e+18, not zero.
9592 Do not rely on undefined behavior after integer overflow.
9594 merge count_size_as_multibyte, parse_str_to_multibyte
9595 * character.c, character.h (count_size_as_multibyte):
9596 Rename from parse_str_to_multibyte; all uses changed.
9597 Check for integer overflow.
9598 * insdel.c, lisp.h (count_size_as_multibyte): Remove,
9599 since it's now a duplicate of the other. This is more of
9600 a character than a buffer op, so better that it's in character.c.
9601 * fns.c, print.c: Adjust to above changes.
9603 2011-05-27 Stefan Monnier <monnier@iro.umontreal.ca>
9605 * xselect.c (x_convert_selection): Yet another int/Lisp_Object mixup.
9607 2011-05-27 Paul Eggert <eggert@cs.ucla.edu>
9609 * xselect.c: Fix minor problems prompted by GCC 4.6.0 warnings.
9610 (x_handle_selection_request, frame_for_x_selection): Remove unused vars.
9611 (x_clipboard_manager_save): Now static.
9612 (Fx_clipboard_manager_save): Rename local to avoid shadowing.
9614 * fns.c: Fix minor problems prompted by GCC 4.6.0 warnings.
9615 (crypto_hash_function): Now static.
9616 Fix pointer signedness problems. Avoid unnecessary initializations.
9618 2011-05-27 Chong Yidong <cyd@stupidchicken.com>
9620 * termhooks.h (Vselection_alist): Make it terminal-local.
9622 * terminal.c (create_terminal): Initialize it.
9624 * xselect.c: Support for clipboard managers.
9625 (Vselection_alist): Move to termhooks.h as terminal-local var.
9626 (LOCAL_SELECTION): New macro.
9627 (x_atom_to_symbol): Handle x_display_info_for_display fail case.
9628 (symbol_to_x_atom): Remove gratuitous arg.
9629 (x_handle_selection_request, lisp_data_to_selection_data)
9630 (x_get_foreign_selection, Fx_register_dnd_atom): Callers changed.
9631 (x_own_selection, x_get_local_selection, x_convert_selection):
9632 New arg, specifying work frame. Use terminal-local Vselection_alist.
9633 (some_frame_on_display): Delete unused function.
9634 (Fx_own_selection_internal, Fx_get_selection_internal)
9635 (Fx_disown_selection_internal, Fx_selection_owner_p)
9636 (Fx_selection_exists_p): New optional frame arg.
9637 (frame_for_x_selection, Fx_clipboard_manager_save): New functions.
9638 (x_handle_selection_clear): Don't treat other terminals with the
9639 same keyboard specially. Use the terminal-local Vselection_alist.
9640 (x_clear_frame_selections): Use Frun_hook_with_args.
9642 * xterm.c (x_term_init): Intern ATOM and CLIPBOARD_MANAGER atoms.
9644 * xterm.h: Add support for those atoms.
9646 2011-05-26 Chong Yidong <cyd@stupidchicken.com>
9648 * xselect.c: ICCCM-compliant handling of MULTIPLE targets.
9649 (converted_selections, conversion_fail_tag): New global variables.
9650 (x_selection_request_lisp_error): Free the above.
9651 (x_get_local_selection): Remove unnecessary code.
9652 (x_reply_selection_request): Args changed; handle arbitrary array
9653 of converted selections stored in converted_selections.
9654 Separate the XChangeProperty and SelectionNotify steps.
9655 (x_handle_selection_request): Rewrite to handle MULTIPLE target.
9656 (x_convert_selection): New function.
9657 (x_handle_selection_event): Simplify.
9658 (x_get_foreign_selection): Don't ignore incoming requests while
9659 waiting for an answer; this will fail when we implement
9660 SAVE_TARGETS, and seems unnecessary anyway.
9661 (selection_data_to_lisp_data): Recognize ATOM_PAIR type.
9662 (Vx_sent_selection_functions): Doc fix.
9664 2011-05-26 Leo Liu <sdl.web@gmail.com>
9666 * editfns.c (Ftranspose_regions): Allow empty regions. (Bug#8699)
9668 2011-05-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
9670 * dispextern.h (struct glyph_row): New member fringe_bitmap_periodic_p.
9672 * dispnew.c (shift_glyph_matrix, scrolling_window): Mark scrolled row
9673 for fringe update if it has periodic bitmap.
9674 (row_equal_p): Also compare left_fringe_offset, right_fringe_offset,
9675 and fringe_bitmap_periodic_p.
9677 * fringe.c (get_fringe_bitmap_data): New function.
9678 (draw_fringe_bitmap_1, update_window_fringes): Use it.
9679 (update_window_fringes): Record periodicity of fringe bitmap in glyph
9680 row. Mark glyph row for fringe update if periodicity changed.
9682 * xdisp.c (try_window_reusing_current_matrix): Don't mark scrolled row
9683 for fringe update unless it has periodic bitmap.
9685 2011-05-25 Kenichi Handa <handa@m17n.org>
9687 * xdisp.c (get_next_display_element): Set correct it->face_id for
9688 a static composition.
9690 2011-05-24 Leo Liu <sdl.web@gmail.com>
9693 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha1.h.
9695 * fns.c (crypto_hash_function, Fsha1): New function.
9696 (Fmd5): Use crypto_hash_function.
9697 (syms_of_fns): Add Ssha1.
9699 2011-05-22 Paul Eggert <eggert@cs.ucla.edu>
9701 * gnutls.c: Remove unused macros.
9702 (fn_gnutls_transport_set_lowat, fn_gnutls_transport_set_pull_function):
9703 (fn_gnutls_transport_set_push_function) [!WINDOWSNT]:
9704 Remove macros that are defined and never used.
9705 Caught by gcc -Wunused-macros (GCC 4.6.0, Fedora 14).
9707 2011-05-22 Chong Yidong <cyd@stupidchicken.com>
9709 * xselect.c (syms_of_xselect): Remove unused symbol SAVE_TARGETS.
9710 (Fx_get_selection_internal): Minor cleanup.
9711 (Fx_own_selection_internal): Rename arguments for consistency with
9714 2011-05-22 Paul Eggert <eggert@cs.ucla.edu>
9716 * xselect.c (QSAVE_TARGETS): New static var, to fix build failure.
9718 2011-05-22 Chong Yidong <cyd@stupidchicken.com>
9720 * xselect.c (syms_of_xselect): Include character.h; use DEFSYM.
9722 2011-05-21 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
9724 * dispnew.c (scrolling_window): Don't exclude the case that the
9725 last enabled row in the desired matrix touches the bottom boundary.
9727 2011-05-21 Glenn Morris <rgm@gnu.org>
9729 * Makefile.in ($(etc)/DOC): Make second command line even shorter.
9730 (SOME_MACHINE_OBJECTS): Replace FONT_OBJ by its maximal expansion,
9731 and add some more files.
9733 2011-05-20 Eli Zaretskii <eliz@gnu.org>
9735 * callproc.c (Fcall_process) [MSDOS]: Fix arguments to
9736 report_file_error introduced by the change from 2011-05-07.
9738 2011-05-20 Paul Eggert <eggert@cs.ucla.edu>
9740 * systime.h (Time): Define only if emacs is defined.
9741 This is to allow ../lib-src/profile.c to be compiled on FreeBSD,
9742 where the include path doesn't have X11/X.h by default. See
9743 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00561.html>.
9745 2011-05-20 Kenichi Handa <handa@m17n.org>
9747 * composite.c (find_automatic_composition): Fix previous change.
9749 2011-05-20 Glenn Morris <rgm@gnu.org>
9751 * lisp.mk: New file, split from Makefile.in.
9752 * Makefile.in (lisp): Move to separate file, inserted by @lisp_frag@.
9753 (shortlisp): Remove.
9754 ($(etc)/DOC): Edit lisp.mk rather than using $shortlisp.
9756 2011-05-19 Glenn Morris <rgm@gnu.org>
9758 * Makefile.in (MSDOS_SUPPORT_REAL, MSDOS_SUPPORT, NS_SUPPORT)
9759 (REAL_MOUSE_SUPPORT, GPM_MOUSE_SUPPORT, MOUSE_SUPPORT, TOOLTIP_SUPPORT)
9760 (BASE_WINDOW_SUPPORT, X_WINDOW_SUPPORT, WINDOW_SUPPORT): Remove.
9761 (lisp): Set the order to that of loadup.el.
9762 (shortlisp): Make it a copy of $lisp.
9763 (SOME_MACHINE_LISP): Remove.
9764 ($(etc)/DOC): Depend just on $lisp, not $SOME_MACHINE_LISP too.
9765 Use just $shortlisp, not $SOME_MACHINE_LISP too.
9767 2011-05-18 Kenichi Handa <handa@m17n.org>
9769 * composite.c (CHAR_COMPOSABLE_P): Add more check for efficiency.
9770 (BACKWARD_CHAR): Wrap the arg STOP by parenthesis.
9771 (find_automatic_composition): Mostly rewrite for efficiency.
9773 2011-05-18 Juanma Barranquero <lekktu@gmail.com>
9775 * makefile.w32-in: Update dependencies.
9777 2011-05-18 Christoph Scholtes <cschol2112@googlemail.com>
9779 * menu.c: Include limits.h (fixes the MS-Windows build broken by
9780 2011-06-18T18:49:19Z!cyd@stupidchicken.com).
9782 2011-05-18 Paul Eggert <eggert@cs.ucla.edu>
9784 Fix some integer overflow issues, such as string length overflow.
9786 * insdel.c (count_size_as_multibyte): Check for string overflow.
9788 * character.c (lisp_string_width): Check for string overflow.
9789 Use EMACS_INT, not int, for string indexes and lengths; in
9790 particular, 2nd arg is now EMACS_INT, not int. Do not crash if
9791 the resulting string length overflows an EMACS_INT; instead,
9792 report a string overflow if no precision given. When checking for
9793 precision exhaustion, use a check that cannot possibly have
9794 integer overflow. (Bug#8675)
9795 * character.h (lisp_string_width): Adjust to new signature.
9797 * alloc.c (string_overflow): New function.
9798 (Fmake_string): Use it. This doesn't change behavior, but saves
9799 a few bytes and will simplify future changes.
9800 * character.c (string_escape_byte8): Likewise.
9801 * lisp.h (string_overflow): New decl.
9803 Fixups, following up to the user-interface timestamp change.
9804 * nsterm.m (last_mouse_movement_time, ns_mouse_position): Use Time
9805 for UI timestamps, instead of unsigned long.
9806 * msdos.c (mouse_get_pos): Likewise.
9807 * w32inevt.c (movement_time, w32_console_mouse_position): Likewise.
9808 * w32gui.h (Time): Define by including "systime.h" rather than by
9809 declaring it ourselves. (Bug#8664)
9811 * dispextern.h (struct image): Don't assume time_t <= unsigned long.
9812 * image.c (clear_image_cache): Likewise.
9814 * term.c (term_mouse_position): Don't assume time_t wraparound.
9816 Be more systematic about user-interface timestamps.
9817 Before, the code sometimes used 'Time', sometimes 'unsigned long',
9818 and sometimes 'EMACS_UINT', to represent these timestamps.
9819 This change causes it to use 'Time' uniformly, as that's what X uses.
9820 This makes the code easier to follow, and makes it easier to catch
9821 integer overflow bugs such as Bug#8664.
9822 * frame.c (Fmouse_position, Fmouse_pixel_position):
9823 Use Time, not unsigned long, for user-interface timestamps.
9824 * keyboard.c (last_event_timestamp, kbd_buffer_get_event): Likewise.
9825 (button_down_time, make_lispy_position, make_lispy_movement): Likewise.
9826 * keyboard.h (last_event_timestamp): Likewise.
9827 * menu.c (Fx_popup_menu) [!HAVE_X_WINDOWS]: Likewise.
9828 * menu.h (xmenu_show): Likewise.
9829 * term.c (term_mouse_position): Likewise.
9830 * termhooks.h (struct input_event.timestamp): Likewise.
9831 (struct terminal.mouse_position_hook): Likewise.
9832 * xmenu.c (create_and_show_popup_menu, xmenu_show): Likewise.
9833 * xterm.c (XTmouse_position, x_scroll_bar_report_motion): Likewise.
9834 * systime.h (Time): New decl. Pull it in from <X11/X.h> if
9835 HAVE_X_WINDOWS, otherwise define it as unsigned long, which is
9837 * menu.h, termhooks.h: Include "systime.h", for Time.
9839 * keyboard.c (make_lispy_event): Fix problem in integer overflow.
9840 Don't assume that the difference between two unsigned long values
9841 can fit into an integer. At this point, we know button_down_time
9842 <= event->timestamp, so the difference must be nonnegative, so
9843 there's no need to cast the result if double-click-time is
9844 nonnegative, as it should be; check that it's nonnegative, just in
9845 case. This bug is triggered when events are more than 2**31 ms
9846 apart (about 25 days). (Bug#8664)
9848 * xselect.c (last_event_timestamp): Remove duplicate decl.
9849 (x_own_selection): Remove needless cast to unsigned long.
9851 * xmenu.c (set_frame_menubar): Use int, not EMACS_UINT, for indexes
9852 that always fit in int. Use a sentinel instead of a counter, to
9853 avoid a temp and to allay GCC's concerns about possible int overflow.
9854 * frame.h (struct frame): Use int for menu_bar_items_used
9855 instead of EMACS_INT, since it always fits in int.
9857 * menu.c (grow_menu_items): Check for int overflow.
9859 * xmenu.c (set_frame_menubar): Don't mishandle vectors with no nils.
9861 * xterm.c: Use EMACS_INT for Emacs modifiers, and int for X modifiers.
9862 Before, the code was not consistent. These values cannot exceed
9863 2**31 - 1 so there's no need to make them unsigned.
9864 (x_x_to_emacs_modifiers): Accept int and return EMACS_INT.
9865 (x_emacs_to_x_modifiers): Accept EMACS_INT and return int.
9866 (x_x_to_emacs_modifiers, x_emacs_to_x_modifiers): Reject non-integers
9868 * xterm.h (x_x_to_emacs_modifiers): Adjust to signature change.
9870 * lisp.h (XINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_INT.
9871 (XUINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_UINT.
9872 Otherwise, GCC 4.6.0 warns about printf (pI, XINT (...)),
9873 presumably because the widths might not match.
9875 * window.c (size_window): Avoid needless test at loop start.
9877 2011-05-18 Courtney Bane <emacs-bugs-7626@cbane.org> (tiny change)
9879 * term.c (Fresume_tty): Restore hooks before reinitializing (bug#8687).
9881 2011-05-12 Drew Adams <drew.adams@oracle.com>
9883 * textprop.c (Fprevious_single_char_property_change): Doc fix (bug#8655).
9885 2011-05-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
9887 * w32term.c (w32_draw_fringe_bitmap): Rename local vars `left' and
9888 `width' to `bar_area_x' and `bar_area_width', respectively.
9889 (x_scroll_run): Take account of fringe background extension.
9891 * xterm.c (x_draw_fringe_bitmap) [USE_TOOLKIT_SCROLL_BARS]:
9892 Rename local vars `left' and `width' to `bar_area_x' and
9893 `bar_area_width', respectively.
9894 (x_scroll_run) [USE_TOOLKIT_SCROLL_BARS]: Take account of fringe
9895 background extension.
9897 2011-05-10 Jim Meyering <meyering@redhat.com>
9899 * xdisp.c (x_intersect_rectangles): Fix typo "the the -> the".
9901 2011-05-10 Juanma Barranquero <lekktu@gmail.com>
9903 * image.c (Finit_image_library): Return t for built-in image types,
9904 like pbm and xbm. (Bug#8640)
9906 2011-05-09 Andreas Schwab <schwab@linux-m68k.org>
9908 * w32menu.c (set_frame_menubar): Fix submenu allocation.
9910 2011-05-07 Eli Zaretskii <eliz@gnu.org>
9912 * w32console.c (Fset_screen_color): Doc fix.
9913 (Fget_screen_color): New function.
9914 (syms_of_ntterm): Defsubr it.
9916 * callproc.c (call_process_cleanup) [MSDOS]: Don't close and
9917 unlink the temporary file if Fcall_process didn't create it in the
9919 (Fcall_process) [MSDOS]: Don't create tempfile if stdout of the
9920 child process will be redirected to a file specified with `:file'.
9921 Don't try to re-open tempfile in that case, and set fd[0] to -1 as
9922 cue to call_process_cleanup not to close that handle.
9924 2011-05-07 Ben Key <bkey76@gmail.com>
9926 * makefile.w32-in: The bootstrap-temacs rule now makes use of
9927 one of two shell specific rules, either bootstrap-temacs-CMD or
9928 bootstrap-temacs-SH. The bootstrap-temacs-SH rule is identical
9929 to the previous implementation of the bootstrap-temacs rule.
9930 The bootstrap-temacs-CMD rule is similar to the previous
9931 implementation of the bootstrap-temacs rule except that it
9932 makes use of the ESC_CFLAGS variable instead of the CFLAGS
9935 These changes, along with some changes to nt/configure.bat,
9936 nt/gmake.defs, and nt/nmake.defs, are required to extend my
9937 earlier fix to add support for --cflags and --ldflags options
9938 that include quotes so that it works whether make uses cmd or
9941 2011-05-06 Michael Albinus <michael.albinus@gmx.de>
9943 * dbusbind.c (QCdbus_type_unix_fd): Declare static.
9944 (xd_remove_watch): Don't check QCdbus_type_unix_fd for SYMBOLP, it
9946 (Fdbus_init_bus, xd_read_queued_messages): Bus can be a symbol or
9947 a string. Handle both cases.
9948 (Fdbus_call_method_asynchronously, Fdbus_register_signal)
9949 (Fdbus_register_method): Use Qinvalid_function.
9951 2011-05-06 Juanma Barranquero <lekktu@gmail.com>
9953 * makefile.w32-in: Update dependencies.
9954 (LISP_H): Add inttypes.h and stdin.h.
9955 (PROCESS_H): Add unistd.h.
9957 2011-05-06 Eli Zaretskii <eliz@gnu.org>
9959 * lread.c: Include limits.h (fixes the MS-Windows build broken by
9960 2011-05-06T07:13:19Z!eggert@cs.ucla.edu).
9962 2011-05-06 Paul Eggert <eggert@cs.ucla.edu>
9964 * image.c (Finit_image_library) [!HAVE_NTGUI]: Omit unused local.
9966 * term.c (vfatal): Remove stray call to va_end.
9967 It's not needed and the C Standard doesn't allow it here anyway.
9969 Use C99's va_copy to avoid undefined behavior on x86-64 GNU/Linux.
9970 * eval.c (verror): doprnt a copy of ap, not the original. (Bug#8545)
9972 * eval.c (verror): OK to create a string of up to MOST_POSITIVE_FIXNUM
9975 * term.c: Don't include <stdarg.h>, as <lisp.h> does that.
9977 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
9979 * process.c (Fformat_network_address): Fix typo: args2 -> *args2.
9981 * xmenu.c (set_frame_menubar): Fix typo: int * -> int (3 times).
9983 * coding.c (detect_coding_charset): Fix typo: * 2 -> *4 (Bug#8601).
9985 * charset.h (struct charset.code_space): Now has 15 elements, not 16.
9986 * charset.c (Fdefine_charset_internal): Don't initialize
9987 charset.code_space[15]. The value was garbage, on hosts with
9988 32-bit int (Bug#8600).
9990 * lread.c (read_integer): Be more consistent with string-to-number.
9991 Use string_to_number to do the actual conversion; this avoids
9992 rounding errors and fixes some other screwups. Without this fix,
9993 for example, #x1fffffffffffffff was misread as -2305843009213693952.
9994 (digit_to_number): Move earlier, for benefit of read_integer.
9995 Return -1 if the digit is out of range for the base, -2 if it is
9996 not a digit in any supported base. (Bug#8602)
9998 * doprnt.c (doprnt): Support arbitrary pI values, such as "I64".
10000 * dispnew.c (scrolling_window): Return 1 if we scrolled,
10001 to match comment at start of function. This also removes a
10002 GCC warning about overflow in a 32+64-bit port.
10004 * lisp.h (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Simplify.
10006 * dbusbind.c: Do not use XPNTR on a value that may be an integer.
10007 Reported by Stefan Monnier in
10008 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00919.html>.
10009 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
10010 Use SYMBOLP-guarded XSYMBOL, not XPNTR.
10012 * lisp.h (EMACS_INTPTR): Remove. All uses changed to intptr_t.
10013 (EMACS_UINTPTR): Likewise, with uintptr_t.
10015 * lisp.h: Prefer 64-bit EMACS_INT if available.
10016 (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Define to 64-bit
10017 on 32-bit hosts that have 64-bit int, so that they can access
10019 However, temporarily disable this change unless the temporary
10020 symbol WIDE_EMACS_INT is defined.
10022 * lread.c, process.c: Do not include <inttypes.h>; lisp.h does it now.
10024 Prefer intptr_t/uintptr_t for integers the same widths as pointers.
10025 This removes an assumption that EMACS_INT and long are the same
10026 width as pointers. The assumption is true for Emacs porting targets
10027 now, but we want to make other targets possible.
10028 * lisp.h: Include <inttypes.h>, for INTPTR_MAX, UINTPTR_MAX.
10029 (EMACS_INTPTR, EMACS_UINTPTR): New macros.
10030 In the rest of the code, change types of integers that hold casted
10031 pointers to EMACS_INTPTR and EMACS_UINTPTR, systematically
10032 replacing EMACS_INT, long, EMACS_UINT, and unsigned long.
10033 (XTYPE): Don't cast arg to EMACS_UINT; normally is not needed.
10034 (XSET): Cast type of XTYPE arg to EMACS_INTPTR; it is needed here.
10035 No need to cast type when ORing.
10036 (XPNTR): Return a value of type EMACS_INTPTR or EMACS_UINTPTR.
10037 * alloc.c (lisp_align_malloc): Remove a no-longer-needed cast.
10038 * doc.c (store_function_docstring): Use EMACS_INTPTR, so as not to
10039 assume EMACS_INT is the same width as char *.
10040 * gtkutil.c (xg_gtk_scroll_destroy, xg_tool_bar_button_cb):
10041 (xg_tool_bar_callback, xg_tool_bar_help_callback, xg_make_tool_item):
10042 Remove no-longer-needed casts.
10043 (xg_create_scroll_bar, xg_tool_bar_button_cb, xg_tool_bar_callback):
10044 (xg_tool_bar_help_callback, xg_make_tool_item):
10045 Use EMACS_INTPTR to hold an integer
10046 that will be cast to void *; this can avoid a GCC warning
10047 if EMACS_INT is not the same width as void *.
10048 * menu.c (find_and_call_menu_selection): Remove no-longer-needed cast.
10049 * xdisp.c (display_echo_area_1, resize_mini_window_1):
10050 (current_message_1, set_message_1):
10051 Use a local to convert to proper width without a cast.
10052 * xmenu.c (dialog_selection_callback): Likewise.
10054 * sysdep.c (get_random): Don't assume EMACS_INT is no wider than long.
10055 Also, don't assume VALBITS / RAND_BITS is less than 5,
10056 and don't rely on undefined behavior when shifting a 1 left into
10058 * lisp.h (get_random): Change signature to match.
10060 * lread.c (hash_string): Use size_t, not int, for hash computation.
10061 Normally we prefer signed values; but hashing is special, because
10062 it's better to use unsigned division on hash table sizes so that
10063 the remainder is nonnegative. Also, size_t is the natural width
10064 for hashing into memory. The previous code used 'int', which doesn't
10065 retain enough info to hash well into very large tables.
10066 (oblookup, oblookup_last_bucket_number, Funintern): Likewise.
10068 * dbusbind.c: Don't possibly lose pointer info when converting.
10069 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
10070 Use XPNTR rather than XHASH, so that the high-order bits of
10071 the pointer aren't lost when converting through void *.
10073 * eval.c (Fautoload): Don't double-shift a pointer.
10075 * fns.c (Frandom): Let EMACS_UINT be wider than unsigned long.
10077 2011-05-06 Juanma Barranquero <lekktu@gmail.com>
10079 * gnutls.c (DEF_GNUTLS_FN):
10080 * image.c (DEF_IMGLIB_FN): Make function pointers static.
10082 2011-05-05 Andreas Schwab <schwab@linux-m68k.org>
10084 * lread.c (lisp_file_lexically_bound_p): Stop scanning at end
10087 2011-05-05 Eli Zaretskii <eliz@gnu.org>
10089 * w32heap.c (allocate_heap) [USE_LISP_UNION_TYPE || USE_LSB_TAG]:
10090 New version that can reserve upto 2GB of heap space.
10092 2011-05-05 Chong Yidong <cyd@stupidchicken.com>
10094 * nsfns.m (Fns_read_file_name): Doc fix (Bug#8534).
10096 2011-05-05 Teodor Zlatanov <tzz@lifelogs.com>
10098 * gnutls.c (fn_gnutls_certificate_set_x509_key_file): Add alias to
10099 `gnutls_certificate_set_x509_key_file'.
10101 2011-05-05 Juanma Barranquero <lekktu@gmail.com>
10103 * makefile.w32-in ($(BLD)/image.$(O), $(BLD)/process.$(O)):
10104 Update dependencies.
10106 2011-05-04 Juanma Barranquero <lekktu@gmail.com>
10108 * gnutls.h (emacs_gnutls_write, emacs_gnutls_read):
10109 * gnutls.c (emacs_gnutls_write, emacs_gnutls_read):
10110 Remove unused parameter `fildes'.
10111 * process.c (read_process_output, send_process): Don't pass it.
10113 2011-05-04 Juanma Barranquero <lekktu@gmail.com>
10115 Fix previous change: the library cache is defined in w32.c.
10116 * image.c (CACHE_IMAGE_TYPE) [!HAVE_NTGUI]: Define to noop.
10117 (Finit_image_library): Wrap Vlibrary_cache on "#ifdef HAVE_NTGUI".
10119 2011-05-04 Juanma Barranquero <lekktu@gmail.com>
10121 Implement dynamic loading of GnuTLS on Windows.
10123 * gnutls.h (GNUTLS_EMACS_ERROR_NOT_LOADED): New macro.
10124 (emacs_gnutls_write, emacs_gnutls_read): Mark as extern.
10125 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
10128 * gnutls.c (Qgnutls_dll): Define.
10129 (DEF_GNUTLS_FN, LOAD_GNUTLS_FN): New macros.
10130 (gnutls_*): Declare function pointers.
10131 (init_gnutls_functions): New function to initialize function pointers.
10132 (emacs_gnutls_handshake, Fgnutls_error_string, Fgnutls_deinit)
10133 (emacs_gnutls_global_init, Fgnutls_bye): Use function pointers.
10134 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
10135 Wrappers for gnutls_record_check_pending and gnutls_transport_set_errno.
10136 (emacs_gnutls_write, emacs_gnutls_read)
10137 (emacs_gnutls_handle_error, Fgnutls_error_fatalp)
10138 (Fgnutls_available_p): New function.
10139 (Fgnutls_boot): Call Fgnutls_available_p. Use function pointers.
10140 (syms_of_gnutls) <Qgnutls_dll>: Initialize and staticpro it.
10141 (syms_of_gnutls) <Sgnutls_available_p>: defsubr it.
10143 * image.c: Include w32.h.
10144 (Vimage_type_cache): Delete.
10145 (syms_of_image) <Vimage_type_cache>: Don't initialize and staticpro it.
10146 (CACHE_IMAGE_TYPE, Finit_image_library): Use Vlibrary_cache instead.
10147 (w32_delayed_load): Move to w32.c.
10149 * w32.h (VlibraryCache, QCloaded_from, w32_delayed_load): Declare.
10151 * w32.c (QCloaded_from, Vlibrary_cache): Define.
10152 (w32_delayed_load): Move from image.c. When loading a library, record
10153 its filename in the :loaded-from property of the library id.
10154 (globals_of_w32) <QCloaded_from, Vlibrary_cache>:
10155 Initialize and staticpro them.
10156 (emacs_gnutls_pull, emacs_gnutls_push): Call emacs_gnutls_* functions.
10158 * process.c: Include lisp.h before w32.h, not after.
10159 (wait_reading_process_output): Call emacs_gnutls_record_check_pending
10160 instead of gnutls_record_check_pending.
10162 * callproc.c, emacs.c: Include lisp.h before w32.h, not after.
10164 2011-05-04 Teodor Zlatanov <tzz@lifelogs.com>
10166 * gnutls.c (Fgnutls_boot): Support :keylist and :crlfiles options
10167 instead of :keyfiles. Give GnuTLS the keylist and the CRL lists
10170 2011-05-03 Jan Djärv <jan.h.d@swipnet.se>
10172 * xterm.c (x_set_frame_alpha): Do not set property on anything
10173 else than FRAME_X_OUTER_WINDOW (Bug#8608).
10175 2011-05-02 Juanma Barranquero <lekktu@gmail.com>
10177 * sysdep.c (get_tty_size) [WINDOWSNT]: Implement. (Bug#8596)
10179 2011-05-02 Juanma Barranquero <lekktu@gmail.com>
10181 * gnutls.c (Qgnutls_log_level, Qgnutls_code, Qgnutls_anon)
10182 (Qgnutls_x509pki, Qgnutls_e_interrupted, Qgnutls_e_again)
10183 (Qgnutls_e_invalid_session, Qgnutls_e_not_ready_for_handshake)
10184 (gnutls_global_initialized, Qgnutls_bootprop_priority)
10185 (Qgnutls_bootprop_trustfiles, Qgnutls_bootprop_keyfiles)
10186 (Qgnutls_bootprop_callbacks, Qgnutls_bootprop_loglevel)
10187 (Qgnutls_bootprop_hostname, Qgnutls_bootprop_verify_flags)
10188 (Qgnutls_bootprop_verify_error, Qgnutls_bootprop_verify_hostname_error)
10189 (Qgnutls_bootprop_callbacks_verify): Make static.
10191 2011-05-01 Andreas Schwab <schwab@linux-m68k.org>
10193 * callproc.c: Indentation fixup.
10195 * sysdep.c (wait_for_termination_1): Make static.
10196 (wait_for_termination, interruptible_wait_for_termination):
10197 Move after wait_for_termination_1.
10199 2011-05-01 Lars Magne Ingebrigtsen <larsi@gnus.org>
10201 * sysdep.c (interruptible_wait_for_termination): New function
10202 which is like wait_for_termination, but allows keyboard
10205 * callproc.c (Fcall_process): Add (:file "file") as an option for
10207 (Fcall_process_region): Ditto.
10209 2011-04-30 Eli Zaretskii <eliz@gnu.org>
10211 * dosfns.c (Fint86, Fdos_memget, Fdos_memput): Use `ASIZE (FOO)'
10212 rather than `XVECTOR (FOO)->size'.
10214 * process.c: Remove HAVE_INTTYPES_H condition from inclusion of
10215 inttypes.h, as a gnulib replacement is used if it not available in
10218 2011-04-21 Eli Zaretskii <eliz@gnu.org>
10220 Lift the MOST_POSITIVE_FIXNUM/4 limitation on visited files.
10221 * fileio.c (Finsert_file_contents): Don't limit file size to 1/4
10222 of MOST_POSITIVE_FIXNUM. (Bug#8528)
10224 * coding.c (coding_alloc_by_realloc): Error out if destination
10225 will grow beyond MOST_POSITIVE_FIXNUM.
10226 (decode_coding_emacs_mule): Abort if there isn't enough place in
10227 charbuf for the composition carryover bytes. Reserve an extra
10228 space for up to 2 characters produced in a loop.
10229 (decode_coding_iso_2022): Abort if there isn't enough place in
10230 charbuf for the composition carryover bytes.
10232 2011-04-21 Eli Zaretskii <eliz@gnu.org>
10234 * doprnt.c (doprnt) [!HAVE_LONG_LONG_INT]: Error out instead of
10235 aborting when %lld or %lll format is passed.
10236 [!HAVE_UNSIGNED_LONG_LONG_INT]: Error out instead of aborting when
10237 %llo or %llx format is passed. (Bug#8545)
10239 * window.c (window_scroll_line_based): Use a marker instead of
10240 simple variables to record original value of point. (Bug#7952)
10242 * doprnt.c (doprnt): Fix the case where a multibyte sequence
10243 produced by %s or %c overflows available buffer space. (Bug#8545)
10245 2011-04-28 Paul Eggert <eggert@cs.ucla.edu>
10247 * doprnt.c (doprnt): Omit useless test; int overflow check (Bug#8545).
10248 (SIZE_MAX): Move defn after all includes, as they might #define it.
10250 2011-04-28 Juanma Barranquero <lekktu@gmail.com>
10252 * w32.c (init_environment): Warn about defaulting HOME to C:\.
10254 2011-04-28 Juanma Barranquero <lekktu@gmail.com>
10256 * keyboard.c (Qdelayed_warnings_hook): Define.
10257 (command_loop_1): Run `delayed-warnings-hook'
10258 if Vdelayed_warnings_list is non-nil.
10259 (syms_of_keyboard) <delayed-warnings-hook>: DEFSYM it.
10260 (syms_of_keyboard) <delayed-warnings-list>: DEFVAR_LISP it.
10262 2011-04-28 Eli Zaretskii <eliz@gnu.org>
10264 * doprnt.c (doprnt): Don't return value smaller than the buffer
10265 size if the message was truncated. (Bug#8545).
10267 2011-04-28 Juanma Barranquero <lekktu@gmail.com>
10269 * w32fns.c (Fx_change_window_property, Fx_delete_window_property)
10270 (Fx_window_property): #if-0 the whole functions, not just the bodies.
10272 2011-04-27 Paul Eggert <eggert@cs.ucla.edu>
10274 * doprnt.c (doprnt): Support "ll" length modifier, for long long.
10276 2011-04-27 Juanma Barranquero <lekktu@gmail.com>
10278 * makefile.w32-in: Update dependencies.
10280 2011-04-27 Eli Zaretskii <eliz@gnu.org>
10282 Improve `doprnt' and its usage. (Bug#8545)
10283 * doprnt.c (doprnt): Make sure `format' is never accessed beyond
10284 `format_end'. Remove support for %l as a conversion specifier.
10285 Don't use xrealloc. Improve diagnostics when the %l size modifier
10286 is used. Update the commentary.
10288 * eval.c (verror): Simplify calculation of size_t.
10290 * coding.c (Ffind_operation_coding_system): Fix diagnostic error
10293 2011-04-27 Yoshiaki Kasahara <kasahara@nc.kyushu-u.ac.jp> (tiny change)
10295 * buffer.c (init_buffer) [USE_MMAP_FOR_BUFFERS]: Adjust to aliasing
10298 2011-04-27 Paul Eggert <eggert@cs.ucla.edu>
10300 * nsmenu.m: Replace all uses of XVECTOR with ASIZE and AREF.
10301 This makes this file independent of the recent pseudovector change.
10303 2011-04-26 Paul Eggert <eggert@cs.ucla.edu>
10305 * keyboard.c (handle_user_signal): Fix pointer signedness problem.
10307 * gnutls.c (emacs_gnutls_handle_error): Remove unused local.
10308 (Fgnutls_boot): gnutls_certificate_verify_peers2 wants unsigned *.
10309 Remove unused local.
10310 (emacs_gnutls_write): Don't use uninitialized rtnval if nbyte <= 0.
10312 * lisp.h: Fix a problem with aliasing and vector headers. (Bug#8546)
10313 GCC 4.6.0 optimizes based on type-based alias analysis.
10314 For example, if b is of type struct buffer * and v of type struct
10315 Lisp_Vector *, then gcc -O2 was incorrectly assuming that &b->size
10316 != &v->size, and therefore "v->size = 1; b->size = 2; return
10317 v->size;" must therefore return 1. This assumption is incorrect
10318 for Emacs, since it type-puns struct Lisp_Vector * with many other
10319 types. To fix this problem, this patch adds a new type struct
10320 vectorlike_header that documents the constraints on layout of vectors
10321 and pseudovectors, and helps optimizing compilers not get fooled
10322 by Emacs's type punning. It also adds the macros XSETTYPED_PVECTYPE
10323 XSETTYPED_PSEUDOVECTOR, TYPED_PSEUDOVECTORP, for similar reasons.
10324 * lisp.h (XSETTYPED_PVECTYPE): New macro, specifying the name of
10326 (XSETPVECTYPE): Rewrite in terms of new macro.
10327 (XSETPVECTYPESIZE): New macro, specifying both type and size.
10328 This is a bit clearer, and further avoids the possibility of
10329 undesirable aliasing.
10330 (XSETTYPED_PSEUDOVECTOR): New macro, specifying the size.
10331 (XSETPSEUDOVECTOR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR.
10332 (XSETSUBR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR and XSIZE,
10333 since Lisp_Subr is a special case (no "next" field).
10334 (ASIZE): Now uses header.size rather than size.
10335 All previous uses of XVECTOR (foo)->size replaced to use this macro,
10336 to avoid the hassle of writing XVECTOR (foo)->header.size.
10337 (struct vectorlike_header): New type.
10338 (TYPED_PSEUDOVECTORP): New macro, also specifying the C type of the
10339 object, to help avoid aliasing.
10340 (PSEUDOVECTORP): Rewrite in terms of TYPED_PSEUDOVECTORP.
10341 (SUBRP): Likewise, since Lisp_Subr is a special case.
10342 * lisp.h (struct Lisp_Vector, struct Lisp_Char_Table):
10343 (struct Lisp_Sub_Char_Table, struct Lisp_Bool_Vector):
10344 (struct Lisp_Hash_Table): Combine first two members into a single
10345 struct vectorlike_header member. All uses of "size" and "next" members
10346 changed to be "header.size" and "header.next".
10347 * buffer.h (struct buffer): Likewise.
10348 * font.h (struct font_spec, struct font_entity, struct font): Likewise.
10349 * frame.h (struct frame): Likewise.
10350 * process.h (struct Lisp_Process): Likewise.
10351 * termhooks.h (struct terminal): Likewise.
10352 * window.c (struct save_window_data, struct saved_window): Likewise.
10353 * window.h (struct window): Likewise.
10354 * alloc.c (allocate_buffer, Fmake_bool_vector, allocate_pseudovector):
10355 Use XSETPVECTYPESIZE, not XSETPVECTYPE, to avoid aliasing problems.
10356 * buffer.c (init_buffer_once): Likewise.
10357 * lread.c (defsubr): Use XSETTYPED_PVECTYPE, since Lisp_Subr is a
10359 * process.c (Fformat_network_address): Use local var for size,
10362 * bytecode.c (exec_byte_code): Don't use XVECTOR before CHECK_VECTOR.
10364 Make the Lisp reader and string-to-float more consistent (Bug#8525)
10365 * data.c (atof): Remove decl; no longer used or needed.
10366 (digit_to_number): Move to lread.c.
10367 (Fstring_to_number): Use new string_to_number function, to be
10368 consistent with how the Lisp reader treats infinities and NaNs.
10369 Do not assume that floating-point numbers represent EMACS_INT
10370 without losing information; this is not true on most 64-bit hosts.
10371 Avoid double-rounding errors, by insisting on integers when
10372 parsing non-base-10 numbers, as the documentation specifies.
10373 * lisp.h (string_to_number): New decl, replacing ...
10374 (isfloat_string): Remove.
10375 * lread.c: Include <inttypes.h>, for uintmax_t and strtoumax.
10376 (read1): Do not accept +. and -. as integers; this
10377 appears to have been a coding error. Similarly, do not accept
10378 strings like +-1e0 as floating point numbers. Do not report
10379 overflow for integer overflows unless the base is not 10 which
10380 means we have no simple and reliable way to continue.
10381 Break out the floating-point parsing into a new
10382 function string_to_number, so that Fstring_to_number parses
10383 floating point numbers consistently with the Lisp reader.
10384 (digit_to_number): Move here from data.c. Make it static inline.
10385 (E_CHAR, EXP_INT): Remove, replacing with ...
10386 (E_EXP): New macro, to solve the "1.0e+" problem mentioned below.
10387 (string_to_number): New function, replacing isfloat_string.
10388 This function checks for valid syntax and produces the resulting
10389 Lisp float number too. Rework it so that string-to-number
10390 no longer mishandles examples like "1.0e+". Use strtoumax,
10391 so that overflow for non-base-10 numbers is reported only when
10392 there's no portable and simple way to convert to floating point.
10394 * textprop.c (set_text_properties_1): Rewrite for clarity,
10395 and to avoid GCC warning about integer overflow.
10397 * intervals.h (struct interval): Use EMACS_INT for members
10398 where EMACS_UINT might cause problems. See
10399 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html>.
10400 (CHECK_TOTAL_LENGTH): Remove cast to EMACS_INT; no longer needed.
10401 * intervals.c (interval_deletion_adjustment): Now returns EMACS_INT.
10403 (offset_intervals): Tell GCC not to worry about length overflow
10404 when negating a negative length.
10406 * alloc.c (overrun_check_malloc, overrun_check_realloc): Now static.
10407 (overrun_check_free): Likewise.
10409 * alloc.c (SDATA_SIZE) [!GC_CHECK_STRING_BYTES]: Avoid runtime check
10410 in the common case where SDATA_DATA_OFFSET is a multiple of Emacs
10413 * gnutls.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
10414 (gnutls_make_error): Rename local to avoid shadowing.
10415 (gnutls_emacs_global_deinit): ifdef out; not used.
10416 (Fgnutls_boot): Use const for pointer to readonly storage.
10417 Comment out unused local. Fix pointer signedness problems.
10419 * lread.c (openp): Don't stuff size_t into an 'int'.
10420 Use <= on length, not < on length + 1, to avoid GCC 4.6.0 warning
10421 about possible signed overflow.
10423 * gtkutil.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
10424 (GDK_KEY_g): Don't define if already defined.
10425 (xg_prepare_tooltip): Avoid pointer signedness problem.
10426 (xg_set_toolkit_scroll_bar_thumb): Redo to avoid two casts.
10428 * process.c (Fnetwork_interface_info): Avoid left-shift undefined
10429 behavior with 1 << 31. GCC 4.6.0 warns about this on 32-bit hosts.
10431 * xfns.c (Fx_window_property): Simplify a bit,
10432 to make a bit faster and to avoid GCC 4.6.0 warning.
10433 * xselect.c (x_get_window_property, x_handle_dnd_message): Likewise.
10435 * fns.c (internal_equal): Don't assume size_t fits in int.
10437 * alloc.c (compact_small_strings): Tighten assertion a little.
10439 Replace pEd with more-general pI, and fix some printf arg casts.
10440 * lisp.h (pI): New macro, generalizing old pEd macro to other
10441 conversion specifiers. For example, use "...%"pI"d..." rather
10442 than "...%"pEd"...".
10443 (pEd): Remove. All uses replaced with similar uses of pI.
10444 * m/amdx86-64.h, m/ia64.h, m/ibms390x.h: Likewise.
10445 * alloc.c (check_pure_size): Don't overflow by converting size to int.
10446 * bidi.c (bidi_dump_cached_states): Use pI to avoid cast.
10447 * data.c (Fnumber_to_string): Use pI instead of if-then-else-abort.
10448 * dbusbind.c (xd_append_arg): Use pI to avoid cast.
10449 (Fdbus_method_return_internal, Fdbus_method_error_internal): Likewise.
10450 * font.c (font_unparse_xlfd): Avoid potential buffer overrun on
10452 (font_unparse_xlfd, font_unparse_fcname): Use pI to avoid casts.
10453 * keyboard.c (record_char, modify_event_symbol): Use pI to avoid casts.
10454 * print.c (safe_debug_print, print_object): Likewise.
10455 (print_object): Don't overflow by converting EMACS_INT or EMACS_UINT
10457 Use pI instead of if-then-else-abort. Use %p to avoid casts,
10458 avoiding the 0 flag, which is not portable.
10459 * process.c (Fmake_network_process): Use pI to avoid cast.
10460 * region-cache.c (pp_cache): Likewise.
10461 * xdisp.c (decode_mode_spec): Likewise.
10462 * xrdb.c (x_load_resources) [USE_MOTIF]: Use pI to avoid undefined
10463 behavior on 64-bit hosts with printf arg.
10464 * xselect.c (x_queue_event): Use %p to avoid casts, avoiding 0 flag.
10465 (x_stop_queuing_selection_requests): Likewise.
10466 (x_get_window_property): Don't truncate byte count to an 'int'
10469 * frame.c (frame_name_fnn_p): Get rid of strtol, which isn't right
10470 here, since it parses constructs like leading '-' and spaces,
10471 which are not wanted; and it overflows with large numbers.
10472 Instead, simply match F[0-9]+, which is what is wanted anyway.
10474 * alloc.c: Remove unportable assumptions about struct layout.
10475 (SDATA_SELECTOR, SDATA_DATA_OFFSET): New macros.
10476 (SDATA_OF_STRING, SDATA_SIZE, allocate_string_data):
10477 (allocate_vectorlike, make_pure_vector): Use the new macros,
10478 plus offsetof, to remove unportable assumptions about struct layout.
10479 These assumptions hold on all porting targets that I know of, but
10480 they are not guaranteed, they're easy to remove, and removing them
10481 makes further changes easier.
10483 * alloc.c (BLOCK BYTES): Fix typo by changing "ablock" to "ablocks".
10484 This doesn't fix a bug but makes the code clearer.
10485 (string_overrun_cookie): Now const. Use initializers that
10486 don't formally overflow signed char, to avoid warnings.
10487 (allocate_string_data) [GC_CHECK_STRING_OVERRUN]: Fix typo that
10488 can cause Emacs to crash when string overrun checking is enabled.
10489 (allocate_buffer): Don't assume sizeof (struct buffer) is a
10490 multiple of sizeof (EMACS_INT); it need not be, if
10491 alignof(EMACS_INT) < sizeof (EMACS_INT).
10492 (check_sblock, check_string_bytes, check_string_free_list): Protoize.
10494 2011-04-26 Juanma Barranquero <lekktu@gmail.com>
10496 * keyboard.c (QCrtl): Rename from Qrtl. All uses changed.
10498 2011-04-26 Teodor Zlatanov <tzz@lifelogs.com>
10500 * gnutls.c (emacs_gnutls_handshake): Return an error if we're not
10501 supposed to be handshaking. (Bug#8556)
10502 Reported by Paul Eggert <eggert@cs.ucla.edu>.
10504 2011-04-26 Daniel Colascione <dan.colascione@gmail.com>
10506 * lisp.h (Qdebug): List symbol.
10507 * eval.c (Qdebug): Restore global linkage.
10508 * keyboard.c (debug-on-event): New variable.
10509 (handle_user_signal): Break into debugger when debug-on-event
10510 matches the current signal symbol.
10512 2011-04-25 Dan Nicolaescu <dann@ics.uci.edu>
10514 * alloc.c (check_sblock, check_string_bytes)
10515 (check_string_free_list): Convert to standard C.
10517 2011-04-25 Teodor Zlatanov <tzz@lifelogs.com>
10519 * w32.c (emacs_gnutls_push): Fix typo.
10521 2011-04-25 Eli Zaretskii <eliz@gnu.org>
10523 * gnutls.c (emacs_gnutls_handshake): Avoid compiler warnings about
10524 "cast to pointer from integer of different size".
10526 Improve doprnt and its use in verror. (Bug#8545)
10527 * doprnt.c (doprnt): Document the set of format control sequences
10528 supported by the function. Use SAFE_ALLOCA instead of always
10531 * eval.c (verror): Don't limit the buffer size at size_max-1, that
10532 is one byte too soon. Don't use xrealloc; instead xfree and
10535 2011-04-24 Teodor Zlatanov <tzz@lifelogs.com>
10537 * gnutls.h: Add GNUTLS_STAGE_CALLBACKS enum to denote we're in the
10540 * gnutls.c: Renamed global_initialized to
10541 gnutls_global_initialized. Added internals for the
10542 :verify-hostname-error, :verify-error, and :verify-flags
10543 parameters of `gnutls-boot' and documented those parameters in the
10544 docstring. Start callback support.
10545 (emacs_gnutls_handshake): Add Woe32 support. Retry handshake
10546 unless a fatal error occurred. Call gnutls_alert_send_appropriate
10547 on error. Return error code.
10548 (emacs_gnutls_write): Call emacs_gnutls_handle_error.
10549 (emacs_gnutls_read): Likewise.
10550 (Fgnutls_boot): Return handshake error code.
10551 (emacs_gnutls_handle_error): New function.
10552 (wsaerror_to_errno): Likewise.
10554 * w32.h (emacs_gnutls_pull): Add prototype.
10555 (emacs_gnutls_push): Likewise.
10557 * w32.c (emacs_gnutls_pull): New function for GnuTLS on Woe32.
10558 (emacs_gnutls_push): Likewise.
10560 2011-04-24 Claudio Bley <claudio.bley@gmail.com> (tiny change)
10562 * process.c (wait_reading_process_output): Check if GnuTLS
10563 buffered some data internally if no FDs are set for TLS
10566 * makefile.w32-in (OBJ2): Add gnutls.$(O).
10567 (LIBS): Link to USER_LIBS.
10568 ($(BLD)/gnutls.$(0)): New target.
10570 2011-04-24 Eli Zaretskii <eliz@gnu.org>
10572 * xdisp.c (handle_single_display_spec): Rename the
10573 display_replaced_before_p argument into display_replaced_p, to
10574 make it consistent with the commentary. Fix typos in the
10577 * textprop.c (syms_of_textprop): Remove dead code.
10578 (copy_text_properties): Delete obsolete commentary about an
10579 interface that was deleted long ago. Fix typos in the description
10582 * msdos.c (XMenuActivate, XMenuAddSelection): Adjust argument list
10583 to changes in oldXMenu/XMenu.h from 2011-04-16.
10584 <menu_help_message, prev_menu_help_message>: Constify.
10585 (IT_menu_make_room): menu->help_text is now `const char **';
10588 * msdos.h (XMenuActivate, XMenuAddSelection): Adjust prototypes
10589 to changes in oldXMenu/XMenu.h from 2011-04-16.
10590 (struct XMenu): Declare `help_text' `const char **'.
10592 * xfaces.c <Qunspecified>: Make extern again.
10594 * syntax.c: Include sys/types.h before including regex.h, as
10597 * doc.c (get_doc_string): Improve the format passed to `error'.
10599 * doprnt.c (doprnt): Improve commentary.
10601 * term.c (init_tty) [MSDOS]: Fix 1st argument to maybe_fatal.
10603 * Makefile.in (TAGS): Depend on $(M_FILE) and $(S_FILE), and scan
10606 * makefile.w32-in (globals.h): Add a dummy recipe, to make any
10607 changes in globals.h immediately force recompilation.
10608 (TAGS): Depend on $(CURDIR)/m/intel386.h and
10609 $(CURDIR)/s/ms-w32.h.
10610 (TAGS-gmake): Scan $(CURDIR)/m/intel386.h and $(CURDIR)/s/ms-w32.h.
10612 * character.c (Fchar_direction): Function deleted.
10613 (syms_of_character): Don't defsubr it.
10614 <char-direction-table>: Deleted.
10616 2011-04-23 Eli Zaretskii <eliz@gnu.org>
10618 Fix doprnt so it could be used again safely in `verror'. (Bug#8435)
10619 * doprnt.c: Include limits.h.
10620 (SIZE_MAX): New macro.
10621 (doprnt): Return a size_t value. 2nd arg is now size_t.
10622 Many local variables are now size_t instead of int or unsigned.
10623 Improve overflow protection. Support `l' modifier for integer
10624 conversions. Support %l conversion. Don't assume an EMACS_INT
10625 argument for integer conversions and for %c.
10627 * lisp.h (doprnt): Restore prototype.
10629 * makefile.w32-in ($(BLD)/callint.$(O)): Depend on
10630 $(SRC)/character.h.
10632 * Makefile.in (base_obj): Add back doprnt.o.
10634 * deps.mk (doprnt.o): Add back prerequisites.
10635 (callint.o): Depend on character.h.
10637 * eval.c (internal_lisp_condition_case): Include the handler
10638 representation in the error message.
10639 (verror): Call doprnt instead of vsnprintf. Fix an off-by-one bug
10640 when breaking from the loop.
10642 * xdisp.c (vmessage): Call doprnt instead of vsnprintf.
10644 * callint.c (Fcall_interactively): When displaying error message
10645 about invalid control letter, pass the character's codepoint, not
10646 a pointer to its multibyte form. Improve display of the character
10647 in octal and display also its hex code.
10649 * character.c (char_string): Use %x to display the (unsigned)
10650 codepoint of an invalid character, to avoid displaying a bogus
10653 * font.c (check_otf_features): Pass SDATA of SYMBOL_NAME to
10654 `error', not SYMBOL_NAME itself.
10656 * coding.c (Fencode_sjis_char, Fencode_big5_char): Use %c for
10657 character arguments to `error'.
10659 * charset.c (check_iso_charset_parameter): Fix incorrect argument
10660 to `error' in error message about FINAL_CHAR argument. Make sure
10661 FINAL_CHAR is a character, and use %c when it is passed as
10662 argument to `error'.
10664 2011-04-23 Eli Zaretskii <eliz@gnu.org>
10666 * s/ms-w32.h (localtime): Redirect to sys_localtime.
10668 * w32.c: Include <time.h>.
10669 (sys_localtime): New function.
10671 2011-04-23 Chong Yidong <cyd@stupidchicken.com>
10673 * xdisp.c (init_xdisp): Initialize echo_area_window (Bug#6451).
10675 * buffer.c (syms_of_buffer): Doc fix (Bug#6902).
10677 2011-04-23 Samuel Thibault <sthibault@debian.org> (tiny change)
10679 * sysdep.c (wait_for_termination): On GNU Hurd, kill returns -1 on
10680 zombies (Bug#8467).
10682 2011-04-19 Eli Zaretskii <eliz@gnu.org>
10684 * syntax.h (SETUP_SYNTAX_TABLE_FOR_OBJECT): Fix setting of
10685 gl_state.e_property when gl_state.object is Qt.
10687 * insdel.c (make_gap_larger): Remove limitation of buffer size
10690 2011-04-18 Chong Yidong <cyd@stupidchicken.com>
10692 * xdisp.c (lookup_glyphless_char_display)
10693 (produce_glyphless_glyph): Handle cons cell entry in
10694 glyphless-char-display.
10695 (Vglyphless_char_display): Document it.
10697 * term.c (produce_glyphless_glyph): Handle cons cell entry in
10698 glyphless-char-display.
10700 2011-04-17 Chong Yidong <cyd@stupidchicken.com>
10702 * xdisp.c (get_next_display_element): Remove unnecessary ifdefs.
10704 * termhooks.h (FRAME_WINDOW_P): Remove duplicated definitions.
10706 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): Add missing
10707 definition for no-X builds.
10709 2011-04-16 Paul Eggert <eggert@cs.ucla.edu>
10711 Static checks with GCC 4.6.0 and non-default toolkits.
10713 * s/sol2-6.h, s/unixware.h (PTY_TTY_NAME_SPRINTF): Protoize decl.
10715 * process.c (keyboard_bit_set): Define only if SIGIO.
10716 (send_process_trap): Mark it with NO_RETURN if it doesn't return.
10717 (send_process): Repair possible setjmp clobbering.
10719 * s/usg5-4-common.h (SETUP_SLAVE_PTY): Don't pass extra arg to 'fatal'.
10721 * eval.c: Include <stdio.h>, for vsnprintf on non-GNU/Linux hosts.
10723 * data.c (arith_error): Mark with NO_RETURN if it doesn't return.
10725 * alloc.c (bytes_used_when_full, SPARE_MEMORY, BYTES_USED):
10726 Define only if needed.
10728 * sysdep.c (_FILE_OFFSET_BITS): Make this hack even uglier
10729 by pacifying GCC about it. Maybe it's time to retire it?
10730 * xfaces.c (USG, __TIMEVAL__): Likewise.
10732 * dispextern.h (struct redisplay_interface): Rename param
10733 to avoid shadowing.
10734 * termhooks.h (struct terminal): Likewise.
10735 * xterm.c (xembed_send_message): Likewise.
10737 * insdel.c (make_gap_smaller): Define only if
10738 USE_MMAP_FOR_BUFFERS || REL_ALLOC || DOUG_LEA_MALLOC.
10740 * keyboard.c (read_char): Make a var volatile so longjmp won't clobber
10743 * emacs.c (MAX_HEAP_BSS_DIFF, my_edata): Move to where they're used,
10744 so that we aren't warned about unused symbols.
10746 * xfns.c (Fx_file_dialog): Rename local to avoid shadowing.
10748 * xdisp.c (x_produce_glyphs): Mark var as initialized (Bug#8512).
10750 * xfns.c (x_real_positions): Mark locals as initialized.
10752 * xmenu.c (xmenu_show): Don't use uninitialized vars.
10754 * xterm.c: Fix problems found by static analysis with other toolkits.
10755 (toolkit_scroll_bar_interaction): Define and use only if USE_X_TOOLKIT.
10756 (x_dispatch_event): Declare static if USE_GTK, and
10757 define if USE_GTK || USE_X_TOOLKIT.
10758 (SET_SAVED_BUTTON_EVENT): Define only if USE_X_TOOLKIT || USE_GTK.
10759 * xterm.h (x_dispatch_event): Extern only if USE_X_TOOLKIT.
10760 * xterm.c, xterm.h (x_mouse_leave): Bring this function back, but only
10761 if defined HAVE_MENUS && !defined USE_X_TOOLKIT && !defined USE_GTK.
10763 * xmenu.c (menu_help_callback): Pointer type fixes.
10764 Use const pointers when pointing at readonly data. Avoid pointer
10765 signedness clashes.
10766 (FALSE): Remove unused macro.
10767 (update_frame_menubar): Remove unused decl.
10769 * xfns.c (Fx_hide_tip): Move locals to avoid shadowing.
10771 * menu.c (push_submenu_start, push_submenu_end): Do not define unless
10772 USE_X_TOOLKIT || USE_GTK || HAVE_NS || defined HAVE_NTGUI.
10773 (single_menu_item): Rename local to avoid shadowing.
10775 * keyboard.c (make_lispy_event): Remove unused local var.
10777 * frame.c, frame.h (x_get_resource_string): Bring this back, but
10778 only if HAVE_X_WINDOWS && !USE_X_TOOLKIT.
10780 * bitmaps: Change bitmaps from unsigned char back to the X11
10781 compatible char. Avoid the old compiler warnings about
10782 out-of-range initializers by using, for example, '\xab' rather
10785 * xgselect.c (xgselect_initialize): Check vs interface
10786 even if ! (defined (USE_GTK) || defined (HAVE_GCONF)).
10788 * xmenu.c (xmenu_show): Rename parm to avoid shadowing.
10790 * xterm.c (x_create_toolkit_scroll_bar): Use const * for pointers
10791 to read-only memory.
10793 * fns.c (vector): Remove; this old hack is no longer needed.
10795 * xsmfns.c (create_client_leader_window): Rename shadowing arg.
10797 (gdk_x11_set_sm_client_id) [!USE_GTK]: Don't define.
10799 * xrdb.c (x_load_resources): Omit unused local.
10801 * xfns.c (free_frame_menubar, atof): Remove duplicate decls.
10802 (x_window): Rename locals to avoid shadowing.
10803 (USG): Use the kludged USG macro, to pacify gcc.
10805 * xterm.c (x_alloc_nearest_color_for_widget): Remove; unused.
10806 (x_term_init): Remove local to avoid shadowing.
10808 * xfns.c, xterm.c (_XEditResCheckMessages): Protoize decl.
10810 * xdisp.c, dispextern.h (set_vertical_scroll_bar): Now extern if
10811 USE_TOOLKIT_SCROLL_BARS && !USE_GTK, as xterm.c needs it then.
10813 2011-04-16 Eli Zaretskii <eliz@gnu.org>
10815 * gnutls.c (Fgnutls_boot): Don't pass Lisp_Object to `error'.
10817 Fix regex.c, syntax.c and friends for buffers > 2GB.
10818 * syntax.h (struct gl_state_s): Declare character position members
10821 * syntax.c (update_syntax_table): Declare 2nd argument EMACS_INT.
10823 * textprop.c (verify_interval_modification, interval_of):
10824 Declare arguments EMACS_INT.
10826 * intervals.c (adjust_intervals_for_insertion): Declare arguments
10829 * intervals.h (CHECK_TOTAL_LENGTH): Cast to EMACS_INT, not `int'.
10831 * indent.c (Fvertical_motion): Local variable it_start is now
10834 * regex.c (re_match, re_match_2, re_match_2_internal)
10835 (bcmp_translate, regcomp, regexec, print_double_string)
10836 (group_in_compile_stack, re_search, re_search_2, regex_compile)
10837 (re_compile_pattern, re_exec): Declare arguments and local
10838 variables `size_t' and `ssize_t' and return values `regoff_t', as
10840 (POP_FAILURE_REG_OR_COUNT) <pfreg>: Declare `long'.
10841 (CHECK_INFINITE_LOOP) <failure>: Declare `ssize_t'.
10842 <compile_stack_type>: `size' and `avail' are now `size_t'.
10844 * regex.h <regoff_t>: Use ssize_t, not int.
10845 (re_search, re_search_2, re_match, re_match_2): Arguments that
10846 specify buffer/string position and length are now ssize_t and
10847 size_t. Return type is regoff_t.
10849 2011-04-16 Ben Key <bkey76@gmail.com>
10851 * nsfont.m: Fixed bugs in ns_get_family and
10852 ns_descriptor_to_entity that were caused by using free to
10853 deallocate memory blocks that were allocated by xmalloc (via
10854 xstrdup). This caused Emacs to crash when compiled with
10855 XMALLOC_OVERRUN_CHECK defined (when Emacs was configured with
10856 --enable-checking=xmallocoverrun). xfree is now used to
10857 deallocate these memory blocks.
10859 2011-04-15 Paul Eggert <eggert@cs.ucla.edu>
10861 * sysdep.c (emacs_read): Remove unnecessary check vs MAX_RW_COUNT.
10863 emacs_write: Accept and return EMACS_INT for sizes.
10864 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html
10866 * gnutls.c, gnutls.h (emacs_gnutls_read, emacs_gnutls_write):
10867 Accept and return EMACS_INT.
10868 (emacs_gnutls_write): Return the number of bytes written on
10870 * sysdep.c, lisp.h (emacs_read, emacs_write): Likewise.
10871 (emacs_read, emacs_write): Remove check for negative size, as the
10872 Emacs source code has been audited now.
10873 * sysdep.c (MAX_RW_COUNT): New macro, to work around kernel bugs.
10874 (emacs_read, emacs_write): Use it.
10875 * process.c (send_process): Adjust to the new signatures of
10876 emacs_write and emacs_gnutls_write. Do not attempt to store
10877 a byte offset into an 'int'; it might overflow.
10878 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00483.html
10880 * sound.c: Don't assume sizes fit in 'int'.
10881 (struct sound_device.period_size, alsa_period_size):
10882 Return EMACS_INT, not int.
10883 (struct sound_device.write, vox_write, alsa_write):
10884 Accept EMACS_INT, not int.
10885 (wav_play, au_play): Use EMACS_INT to store sizes and to
10886 record read return values.
10888 2011-04-15 Ben Key <bkey76@gmail.com>
10890 * keyboard.c (Qundefined): Don't declare static since it is used
10892 * xfaces.c (Qbold, Qexpanded, Qitalic, Qcondensed): Don't declare
10893 static since they are used in nsfont.m.
10895 2011-04-15 Stefan Monnier <monnier@iro.umontreal.ca>
10897 * process.c (Qprocessp): Don't declare static.
10898 * lisp.h (Qprocessp): Declare again.
10900 2011-04-15 Juanma Barranquero <lekktu@gmail.com>
10902 * font.c (Qopentype): Don't make static (used from w32uniscribe.c).
10904 2011-04-14 Paul Eggert <eggert@cs.ucla.edu>
10906 Improve C-level modularity by making more things 'static'.
10908 Don't publish debugger-only interfaces to other modules.
10909 * lisp.h (safe_debug_print, debug_output_compilation_hack):
10910 (verify_bytepos, count_markers): Move decls to the only modules
10912 * region-cache.h (pp_cache): Likewise.
10913 * window.h (check_all_windows): Likewise.
10914 * marker.c, print.c, region-cache.c, window.c: Decls moved here.
10916 * sysdep.c (croak): Now static, if
10917 defined TIOCNOTTY || defined USG5 || defined CYGWIN.
10918 * syssignal.h (croak): Declare only if not static.
10920 * alloc.c (refill_memory_reserve): Now static if
10921 !defined REL_ALLOC || defined SYSTEM_MALLOC.
10922 * lisp.h (refill_memory_reserve): Declare only if not static.
10924 * xsettings.c, xsettings.h (xsettings_get_system_normal_font):
10925 Define only if USE_LUCID.
10927 * xrdb.c (x_customization_string, x_rm_string): Now static.
10929 * xmenu.c (x_menu_wait_for_event): Export only if USE_MOTIF.
10930 * xterm.h (x_menu_wait_for_event): Declare only if USE_MOTIF.
10932 * xdisp.c (draw_row_with_mouse_face): Now static.
10933 * dispextern.h (draw_row_with_mouse_fave): Remove decl.
10935 * window.h (check_all_windows): Mark externally visible.
10937 * window.c (window_deletion_count): Now static.
10939 * undo.c: Make symbols static if they're not exported.
10940 (last_undo_buffer, last_boundary_position, pending_boundary):
10943 * textprop.c (interval_insert_behind_hooks): Now static.
10944 (interval_insert_in_front_hooks): Likewise.
10946 * term.c: Make symbols static if they're not exported.
10947 (tty_turn_off_highlight, get_tty_terminal, max_frame_cols):
10948 (max_frame_lines, tty_set_terminal_modes):
10949 (tty_reset_terminal_modes, tty_turn_off_highlight):
10950 (get_tty_terminal): Now static.
10951 (term_mouse_moveto): Do not define if HAVE_WINDOW_SYSTEM.
10952 * termhooks.h (term_mouse_moveto): Do not declare if
10953 HAVE_WINDOW_SYSTEM.
10954 * dispextern.h (tty_set_terminal_modes, tty_reset_terminal_modes):
10955 (tty_turn_off_highlight, get_tty_terminal): Remove decls.
10957 * sysdep.c: Make symbols static if they're not exported.
10958 (emacs_get_tty, emacs_set_tty, old_fcntl_flags, old_fcntl_owner):
10960 (sigprocmask_set, full_mask): Remove; unused.
10961 (wait_debugging): Mark as visible.
10962 * syssignal.h (SIGFULLMASK, full_mask): Remove decls.
10963 * systty.h (emacs_get_tty, emacs_set_tty): Remove decls.
10965 * syntax.c (syntax_temp): Define only if !__GNUC__.
10967 * sound.c (current_sound_device, current_sound): Now static.
10969 * search.c (searchbufs, searchbuf_head): Now static.
10971 * scroll.c (scroll_cost): Remove; unused.
10972 * dispextern.h (scroll_cost): Remove decl.
10974 * region-cache.h (pp_cache): Mark as externally visible.
10976 * process.c: Make symbols static if they're not exported.
10977 (process_tick, update_tick, create_process, chan_process):
10978 (Vprocess_alist, proc_buffered_char, datagram_access):
10979 (fd_callback_data, send_process_frame, process_sent_to): Now static.
10980 (deactivate_process): Mark defn as static, as well as decl.
10981 * lisp.h (create_process): Remove decl.
10982 * process.h (chan_process, Vprocess_alist): Remove decls.
10984 * print.c: Make symbols static if they're not exported.
10985 (print_depth, new_backquote_output, being_printed, print_buffer):
10986 (print_buffer_size, print_buffer_pos, print_buffer_pos_byte):
10987 (print_interval, print_number_index, initial_stderr_stream):
10989 * lisp.h (Fprinc): Remove decl.
10990 (debug_output_compilation_hack): Mark as externally visible.
10992 * sysdep.c (croak): Move decl from here to syssignal.h.
10993 * syssignal.h (croak): Put it here, so the API can be checked when
10994 'croak' is called from dissociate_if_controlling_tty.
10996 * minibuf.c: Make symbols static if they're not exported.
10997 (minibuf_save_list, choose_minibuf_frame): Now static.
10998 * lisp.h (choose_minibuf_frame): Remove decl.
11000 * lisp.h (verify_bytepos, count_markers): Mark as externally visible.
11002 * lread.c: Make symbols static if they're not exported.
11003 (read_objects, initial_obarray, oblookup_last_bucket_number):
11005 (make_symbol): Remove; unused.
11006 * lisp.h (initial_obarray, make_symbol): Remove decls.
11008 * keyboard.c: Make symbols static if they're not exported.
11009 (single_kboard, recent_keys_index, total_keys, recent_keys):
11010 (this_command_key_count_reset, raw_keybuf, raw_keybuf_count):
11011 (this_single_command_key_start, echoing, last_auto_save):
11012 (read_key_sequence_cmd, dribble, recursive_edit_unwind):
11013 (command_loop, echo_now, keyboard_init_hook, help_char_p):
11014 (quit_throw_to_read_char, command_loop_2, top_level_1, poll_timer):
11015 (Vlispy_mouse_stem, double_click_count):
11017 (force_auto_save_soon): Define only if SIGDANGER.
11018 (ignore_mouse_drag_p): Now static if
11019 !defined HAVE_WINDOW_SYSTEM || defined USE_GTK || defined HAVE_NS.
11020 (print_help): Remove; unused.
11021 (stop_character, last_timer_event): Mark as externally visible.
11022 * keyboard.h (ignore_mouse_drag_p): Declare only if
11023 defined HAVE_WINDOW_SYSTEM && !defined USE_GTK && !defined HAVE_NS.
11024 (echo_now, help_char_p, quit_throw_to_read_char): Remove decls.
11025 * lisp.h (echoing): Remove decl.
11026 (force_auto_save_soon): Declare only if SIGDANGER.
11027 * xdisp.c (redisplay_window): Simplify code, to make it more
11028 obvious that ignore_mouse_drag_p is not accessed if !defined
11029 USE_GTK && !defined HAVE_NS.
11031 * intervals.c: Make symbols static if they're not exported.
11032 (merge_properties_sticky, merge_interval_right, delete_interval):
11034 * intervals.h (merge_interval_right, delete_interval): Remove decls.
11036 * insdel.c: Make symbols static if they're not exported.
11037 However, leave prepare_to_modify_buffer alone. It's never
11038 called from outside this function, but that appears to be a bug.
11039 (combine_after_change_list, combine_after_change_buffer):
11040 (adjust_after_replace, signal_before_change): Now static.
11041 (adjust_after_replace_noundo): Remove; unused.
11042 * lisp.h (adjust_after_replace, adjust_after_replace_noundo):
11043 (signal_before_change): Remove decls.
11045 * indent.c (val_compute_motion, val_vmotion): Now static.
11047 * image.c: Make symbols static if they're not exported.
11048 * dispextern.h (x_create_bitmap_from_xpm_data): Do not declare
11050 * image.c (x_create_bitmap_from_xpm_data): Do not define if USE_GTK.
11051 (xpm_color_cache, ct_table, ct_colors_allocated): Now static.
11053 * fringe.c (standard_bitmaps): Now static.
11054 (max_used_fringe_bitmap): Now static, unless HAVE_NS.
11056 * frame.c: Make symbols static if they're not exported.
11057 (x_report_frame_params, make_terminal_frame): Now static.
11058 (get_frame_param): Now static, unless HAVE_NS.
11059 (x_fullscreen_adjust): Define if WINDOWSNT, not if HAVE_WINDOW_SYSTEM.
11060 (x_get_resource_string): Remove; not used.
11061 * frame.h (make_terminal_frame, x_report_frame_params):
11062 (x_get_resource_string); Remove decls.
11063 (x_fullscreen_adjust): Declare only if WINDOWSNT.
11064 * lisp.h (get_frame_param): Declare only if HAVE_NS.
11066 * font.c, fontset.c: Make symbols static if they're not exported.
11067 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): New macro.
11068 (FACE_SUITABLE_FOR_CHAR_P): Use it.
11069 * font.c (font_close_object): Now static.
11070 * font.h (font_close_object): Remove.
11071 * fontset.c (FONTSET_OBJLIST): Remove.
11072 (free_realized_fontset) #if-0 the body, which does nothing.
11073 (face_suitable_for_char_p): #if-0, as it's never called.
11074 * fontset.h (face_suitable_for_char_p): Remove decl.
11075 * xfaces.c (face_at_string_position):
11076 Use FACE_SUITABLE_FOR_ASCII_CHAR_P, not FACE_SUITABLE_FOR_CHAR_P,
11077 since 0 is always ASCII.
11079 * fns.c (weak_hash_tables): Now static.
11081 * fileio.c: Make symbols static if they're not exported.
11082 (auto_saving, auto_save_mode_bits, auto_save_error_occurred):
11083 (Vwrite_region_annotation_buffers): Now static.
11085 * eval.c: Make symbols static if they're not exported.
11086 (backtrace_list, lisp_eval_depth, when_entered_debugger): Now static.
11087 * lisp.h (backtrace_list): Remove decl.
11089 * emacs.c: Make symbols static if they're not exported.
11090 (malloc_state_ptr, malloc_using_checking, syms_of_emacs):
11091 (fatal_error_code, fatal_error_signal_hook, standard_args):
11093 (fatal_error_signal): Now static, unless FLOAT_CATCH_SIGKILL.
11094 (DEFINE_DUMMY_FUNCTION): Mark function as externally visible.
11095 (__CTOR_LIST__, __DTOR_LIST__): Now externally visible.
11096 * lisp.h (fatal_error_signal_hook): Remove decl.
11097 (fatal_error_signal): Declare only if FLOAT_CATCH_SIGKILL.
11099 * editfns.c: Move a (normally-unused) function to its only use.
11100 * editfns.c, lisp.h (get_operating_system_release): Remove.
11101 * process.c (init_process) [DARWIN_OS]: Do it inline, as it is not
11102 worth the hassle of breaking this out.
11104 * xterm.c: Make symbols static if they're not exported.
11105 (x_raise_frame, x_lower_frame, x_wm_set_window_state):
11106 (x_wm_set_icon_pixmap, x_initialize, XTread_socket_fake_io_error):
11107 (x_destroy_window, x_delete_display):
11109 (x_dispatch_event): Now static if ! (USE_MOTIF || USE_X_TOOLKIT).
11110 (x_mouse_leave): Remove; unused.
11111 * xterm.h (x_display_info_for_name, x_raise_frame, x_lower_frame):
11112 (x_destroy_window, x_wm_set_window_state, x_wm_set_icon_pixmap):
11113 (x_delete_display, x_initialize, x_set_border_pixel, x_screen_planes):
11115 (x_mouse_leave): Declare only if WINDOWSNT.
11116 (x_dispatch_event): Declare only if USE_MOTIF or USE_X_TOOLKIT.
11117 (xic_create_fontsetname): Declare only if HAVE_X_WINDOWS &&
11120 * ftxfont.c: Make symbols static if they're not exported.
11121 (ftxfont_driver): Export only if !defined HAVE_XFT && def8ined
11123 * font.h (ftxfont_driver): Likewise.
11125 * xfns.c: Make symbols static if they're not exported.
11126 (x_last_font_name, x_display_info_for_name):
11127 (x_set_foreground_color, x_set_background_color, x_set_mouse_color):
11128 (x_set_cursor_color, x_set_border_pixel, x_set_border_color):
11129 (x_set_cursor_type, x_set_icon_type, x_set_icon_name):
11130 (x_set_scroll_bar_foreground, x_set_scroll_bar_background):
11131 (x_explicitly_set_name, x_set_title, xic_defaut_fontset, tip_timer):
11132 (last_show_tip_args): Now static.
11133 (xic_defaut_fontset, xic_create_fontsetname): Define only if
11134 defined HAVE_X_WINDOWS && defined USE_X_TOOLKIT
11135 (x_screen_planes): Remove; unused.
11136 * dispextern.h (x_screen_planes): Remove decl.
11138 * dispnew.c: Make symbols static if they're not exported.
11139 * dispextern.h (redraw_garbaged_frames, scrolling):
11140 (increment_row_positions): Remove.
11141 * dispnew.c (new_glyph_matrix, increment_row_positions, scrolling):
11142 (delayed_size_change, glyph_matrix_count, glyph_pool_count):
11144 (redraw_garbaged_frames): Remove; unused.
11146 * xfaces.c: Make symbols static if they're not exported.
11147 * dispextern.h (ascii_face_of_lisp_face, free_realized_face):
11149 * xterm.h (defined_color): Remove decls.
11150 (x_free_dpy_colors): Declare only if USE_X_TOOLKIT.
11151 * xfaces.c (tty_suppress_bold_inverse_default_colors_p):
11152 (menu_face_changed_default, defined_color, free_realized_face):
11153 (x_free_dpy_colors): Define only if USE_X_TOOLKIT.
11154 (ascii_face_of_lisp_face): Remove; unused.
11156 * xdisp.c: Make symbols static if they're not exported.
11157 * dispextern.h (scratch_glyph_row, window_box_edges):
11158 (glyph_to_pixel_coords, set_cursor_from_row):
11159 (get_next_display_element, set_iterator_to_next):
11160 (highlight_trailing_whitespace, frame_to_window_pixel_xy):
11161 (show_mouse_face): Remove decls
11162 * frame.h (message_buf_print): Likewise.
11163 * lisp.h (pop_message, set_message, check_point_in_composition):
11165 * xterm.h (set_vertical_scroll_bar): Likewise.
11166 * xdisp.c (list_of_error, Vmessage_stack, line_number_displayed):
11167 (message_buf_print, scratch_glyph_row, displayed_buffer):
11168 (set_iterator_to_next, pop_message, set_message, set_cursor_from_row):
11169 (get_next_display_element, show_mouse_face, window_box_edges):
11170 (frame_to_window_pixel_xy, check_point_in_composition):
11171 (set_vertical_scroll_bar, highlight_trailing_whitespace): Now static.
11172 (glyph_to_pixel_coords): Remove; unused.
11174 * dired.c (file_name_completion): Now static.
11176 * dbusbind.c (xd_in_read_queued_messages): Now static.
11178 * lisp.h (circular_list_error, FOREACH): Remove; unused.
11179 * data.c (circular_list_error): Remove.
11181 * commands.h (last_point_position, last_point_position_buffer):
11182 (last_point_position_window): Remove decls.
11183 * keyboard.c: Make these variables static.
11185 * coding.h (coding, code_convert_region, encode_coding_gap):
11187 * coding.c (Vsjis_coding_system, Vbig5_coding_system):
11188 (iso_code_class, detect_coding, code_convert_region): Now static.
11189 (encode_coding_gap): Remove; unused.
11191 * chartab.c (chartab_chars, chartab_bits): Now static.
11193 * charset.h (charset_iso_8859_1): Remove decl.
11194 * charset.c (charset_iso_8859_1, charset_emacs, map_charset_for_dump):
11197 * ccl.h (check_ccl_update, Vccl_program_table): Remove decls.
11198 * ccl.c (Vccl_program_table): Now static.
11199 (check_ccl_update): Remove; unused.
11201 * category.c (SET_CATEGORY_SET, set_category_set): Move here.
11202 * category.h: ... from here.
11203 * category.c (check_category_table, set_category_set): Now static.
11205 * casetab.c (Vascii_upcase_table, Vascii_eqv_table): Now static.
11206 * lisp.h: Remove these decls.
11208 * buffer.c (buffer_count): Remove unused var.
11210 * bidi.c (bidi_dump_cached_states): Mark as externally visible,
11211 so that it's not optimized away.
11212 (bidi_ignore_explicit_marks_for_paragraph_level): Likewise.
11213 * dispextern.h (bidi_dump_cached_states): Remove, since it's
11214 exported only to the debugger.
11216 * atimer.c (alarm_signal_handler, run_all_atimers): Now static.
11217 * atimer.h (run_all_atimers): Remove; not exported.
11219 font.c: Make copy_font_spec and merge_font_spec ordinary C functions.
11220 * font.c (copy_font_spec): Rename from Fcopy_font_spec, since it
11221 was inaccessible from Lisp.
11222 (merge_font_spec): Likewise, renaming from Fmerge_font_spec.
11223 * font.c, font.h, fontset.c, xfaces.c, xfont.c: Change all uses.
11225 alloc.c: Import and export fewer symbols, and remove unused items.
11226 * lisp.h (suppress_checking, die): Declare only if ENABLE_CHECKING
11228 (suppress_checking): Add EXTERNALLY_VISIBLE attribute, so that
11229 it's not optimized away by whole-program optimization.
11230 (message_enable_multibyte, free_misc): Remove.
11231 (catchlist, handlerlist, mark_backtrace):
11232 Declare only if BYTE_MARK_STACK.
11233 (mark_byte_stack): Likewise, fixing a ifdef-vs-if typo.
11234 * alloc.c (pure): Export only if VIRT_ADDR_VARIES is defined.
11235 (message_enable_multibyte): Remove decl.
11236 (free_misc, interval_free_list, float_block, float_block_index):
11237 (n_float_blocks, float_free_list, cons_block, cons_block_index):
11238 (cons_free_list, last_marked_index):
11240 (suppress_checking, die): Define only if ENABLE_CHECKING is defined.
11241 * eval.c (catchlist, handlerlist): Export only if BYTE_MARK_STACK.
11242 (mark_backtrace): Define only if BYTE_MARK_STACK.
11243 * xdisp.c (message_enable_multibyte): Now static.
11245 Declare Lisp_Object Q* variables to be 'static' if not exported.
11246 This makes it easier for human readers (and static analyzers)
11247 to see whether these variables are used from other modules.
11248 * alloc.c, buffer.c, bytecode.c, callint.c, casetab.c, category.c:
11249 * ccl.c, character.c, charset.c, cmds.c, coding.c, composite.c:
11250 * data.c, dbusbind.c, dired.c, editfns.c, eval.c, fileio.c, fns.c:
11251 * font.c, frame.c, fringe.c, ftfont.c, image.c, keyboard.c, keymap.c:
11252 * lread.c, macros.c, minibuf.c, print.c, process.c, search.c:
11253 * sound.c, syntax.c, textprop.c, window.c, xdisp.c, xfaces.c, xfns.c:
11254 * xmenu.c, xselect.c:
11255 Declare Q* vars static if they are not used in other modules.
11256 * ccl.h, character.h, charset.h, coding.h, composite.h, font.h:
11257 * frame.h, intervals.h, keyboard.h, lisp.h, process.h, syntax.h:
11258 Remove decls of unexported vars.
11259 * keyboard.h (EVENT_HEAD_UNMODIFIED): Remove now-unused macro.
11261 * lisp.h (DEFINE_FUNC): Make sname 'static'.
11263 Make Emacs functions such as Fatom 'static' by default.
11264 This makes it easier for human readers (and static analyzers)
11265 to see whether these functions can be called from other modules.
11266 DEFUN now defines a static function. To make the function external
11267 so that it can be used in other C modules, use the new macro DEFUE.
11268 * lisp.h (Funibyte_char_to_multibyte, Fsyntax_table_p):
11269 (Finit_image_library):
11270 (Feval_region, Fbacktrace, Ffetch_bytecode, Fswitch_to_buffer):
11271 (Ffile_executable_p, Fmake_symbolic_link, Fcommand_execute):
11272 (Fget_process, Fdocumentation_property, Fbyte_code, Ffile_attributes):
11273 Remove decls, since these functions are now static.
11274 (Funintern, Fget_internal_run_time): New decls, since these functions
11275 were already external.
11277 * alloc.c, buffer.c, callint.c, callproc.c, casefiddle.c, casetab.c:
11278 * ccl.c, character.c, chartab.c, cmds.c, coding.c, data.c, dispnew.c:
11279 * doc.c, editfns.c, emacs.c, eval.c, fileio.c, filelock.c, floatfns.c:
11280 * fns.c, font.c, fontset.c, frame.c, image.c, indent.c:
11281 * keyboard.c, keymap.c, lread.c:
11282 * macros.c, marker.c, menu.c, minibuf.c, print.c, process.c, search.c:
11283 * syntax.c, term.c, terminal.c, textprop.c, undo.c:
11284 * window.c, xdisp.c, xfaces.c, xfns.c, xmenu.c, xsettings.c:
11285 Mark functions with DEFUE instead of DEFUN,
11286 if they are used in other modules.
11287 * buffer.c (Fset_buffer_major_mode, Fdelete_overlay): New forward
11288 decls for now-static functions.
11289 * buffer.h (Fdelete_overlay): Remove decl.
11290 * callproc.c (Fgetenv_internal): Mark as internal.
11291 * composite.c (Fremove_list_of_text_properties): Remove decl.
11292 (Fcomposition_get_gstring): New forward static decl.
11293 * composite.h (Fcomposite_get_gstring): Remove decl.
11294 * dired.c (Ffile_attributes): New forward static decl.
11295 * doc.c (Fdocumntation_property): New forward static decl.
11296 * eval.c (Ffetch_bytecode): New forward static decl.
11297 (Funintern): Remove extern decl; now in .h file where it belongs.
11298 * fileio.c (Fmake_symbolic_link): New forward static decl.
11299 * image.c (Finit_image_library): New forward static decl.
11300 * insdel.c (Fcombine_after_change_execute): Make forward decl static.
11301 * intervals.h (Fprevious_property_change):
11302 (Fremove_list_of_text_properties): Remove decls.
11303 * keyboard.c (Fthis_command_keys): Remove decl.
11304 (Fcommand_execute): New forward static decl.
11305 * keymap.c (Flookup_key): New forward static decl.
11306 (Fcopy_keymap): Now static.
11307 * keymap.h (Flookup_key): Remove decl.
11308 * process.c (Fget_process): New forward static decl.
11309 (Fprocess_datagram_address): Mark as internal.
11310 * syntax.c (Fsyntax_table_p): New forward static decl.
11311 (skip_chars): Remove duplicate decl.
11312 * textprop.c (Fprevious_property_change): New forward static decl.
11313 * window.c (Fset_window_fringes, Fset_window_scroll_bars):
11315 (Fset_window_margins, Fset_window_vscroll): New forward static decls.
11316 * window.h (Fset_window_vscroll, Fset_window_margins): Remove decls.
11318 * editfns.c (Fformat): Remove unreachable code.
11320 2011-04-14 Andreas Schwab <schwab@linux-m68k.org>
11322 * fileio.c (Finsert_file_contents): Fix typo in 2005-05-13
11325 2011-04-13 Eli Zaretskii <eliz@gnu.org>
11327 * xdisp.c (handle_invisible_prop): Don't call bidi_paragraph_init
11328 when at ZV. (Bug#8487)
11330 2011-04-12 Andreas Schwab <schwab@linux-m68k.org>
11332 * charset.c (Fclear_charset_maps): Use xfree instead of free.
11334 * keyboard.c (parse_tool_bar_item): Likewise.
11335 * sound.c (sound_cleanup, alsa_close): Likewise.
11336 * termcap.c (tgetent): Likewise.
11337 * xfns.c (x_default_font_parameter): Likewise.
11338 * xsettings.c (read_and_apply_settings): Likewise.
11340 * alloc.c (overrun_check_malloc, overrun_check_realloc)
11341 (overrun_check_free): Protoize.
11343 2011-04-12 Paul Eggert <eggert@cs.ucla.edu>
11345 * sysdep.c (emacs_read, emacs_write): Check for negative sizes
11346 since callers should never pass a negative size.
11347 Change the signature to match that of plain 'read' and 'write'; see
11348 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00397.html>.
11349 * lisp.h: Update prototypes of emacs_write and emacs_read.
11351 2011-04-11 Eli Zaretskii <eliz@gnu.org>
11353 * xdisp.c (redisplay_window): Don't try to determine the character
11354 position of the scroll margin if the window start point w->startp
11355 is outside the buffer's accessible region. (Bug#8468)
11357 2011-04-10 Eli Zaretskii <eliz@gnu.org>
11359 Fix write-region and its subroutines for buffers > 2GB.
11360 * fileio.c (a_write, e_write): Modify declaration of arguments and
11361 local variables to support buffers larger than 2GB.
11362 (Fcopy_file): Use EMACS_INT for return value of emacs_read.
11364 * sysdep.c (emacs_write, emacs_read): Use ssize_t for last
11365 argument, local variables, and return value.
11367 * lisp.h: Update prototypes of emacs_write and emacs_read.
11369 * sound.c (vox_write): Use ssize_t for return value of emacs_write.
11371 2011-04-10 Paul Eggert <eggert@cs.ucla.edu>
11373 * xdisp.c (vmessage): Use memchr, not strnlen, which some hosts lack.
11375 Fix more problems found by GCC 4.6.0's static checks.
11377 * xdisp.c (vmessage): Use a better test for character truncation.
11379 * charset.c (load_charset_map): <, not <=, for optimization,
11380 and to avoid potential problems with integer overflow.
11381 * chartab.c (sub_char_table_set_range, char_table_set_range): Likewise.
11382 * casetab.c (set_identity, shuffle): Likewise.
11383 * editfns.c (Fformat): Likewise.
11384 * syntax.c (skip_chars): Likewise.
11386 * xmenu.c (set_frame_menubar): Allocate smaller local vectors.
11387 This also lets GCC 4.6.0 generate slightly better loop code.
11389 * callint.c (Fcall_interactively): <, not <=, for optimization.
11390 (Fcall_interactively): Count the number of arguments produced,
11391 not the number of arguments given. This is simpler and lets GCC
11392 4.6.0 generate slightly better code.
11394 * ftfont.c: Distingish more carefully between FcChar8 and char.
11395 The previous code passed unsigned char * to a functions like
11396 strlen and xstrcasecmp that expect char *, which does not
11397 conform to the C standard.
11398 (get_adstyle_property, ftfont_pattern_entity): Use FcChar8 for
11399 arguments to FcPatternGetString, and explicitly cast FcChar8 * to
11400 char * when the C standard requires it.
11402 * keyboard.c (read_char): Remove unused var.
11404 * eval.c: Port to Windows vsnprintf (Bug#8435).
11405 Include <limits.h>.
11406 (SIZE_MAX): Define if the headers do not.
11407 (verror): Do not give up if vsnprintf returns a negative count.
11408 Instead, grow the buffer. This ports to Windows vsnprintf, which
11409 does not conform to C99. Problem reported by Eli Zaretskii.
11410 Also, simplify the allocation scheme, by avoiding the need for
11411 calling realloc, and removing the ALLOCATED variable.
11413 * eval.c (verror): Initial buffer size is 4000 (not 200) bytes.
11415 Remove invocations of doprnt, as Emacs now uses vsnprintf.
11416 But keep the doprint source code for now, as we might revamp it
11417 and use it again (Bug#8435).
11418 * lisp.h (doprnt): Remove.
11419 * Makefile.in (base_obj): Remove doprnt.o.
11420 * deps.mk (doprnt.o): Remove.
11422 error: Print 32- and 64-bit integers portably (Bug#8435).
11423 Without this change, on typical 64-bit hosts error ("...%d...", N)
11424 was used to print both 32- and 64-bit integers N, which relied on
11425 undefined behavior.
11426 * lisp.h, m/amdx86-64.h, m/ia64.h, m/ibms390x.h (pEd): New macro.
11427 * lisp.h (error, verror): Mark as printf-like functions.
11428 * eval.c (verror): Use vsnprintf, not doprnt, to do the real work.
11429 Report overflow in size calculations when allocating printf buffer.
11430 Do not truncate output string at its first null byte.
11431 * xdisp.c (vmessage): Use vsnprintf, not doprnt, to do the real work.
11432 Truncate the output at a character boundary, since vsnprintf does not
11434 * charset.c (check_iso_charset_parameter): Convert internal
11435 character to string before calling 'error', since %c now has the
11437 * coding.c (Fdecode_sjis_char, Fdecode_big5_char): Avoid int
11438 overflow when computing char to be passed to 'error'. Do not
11439 pass Lisp_Object to 'error'; pass the integer instead.
11440 * nsfns.m (Fns_do_applescript): Use int, not long, since it's
11441 formatted with plain %d.
11443 * eval.c (internal_lisp_condition_case): Don't pass spurious arg.
11445 * keyboard.c (access_keymap_keyremap): Print func name, not garbage.
11447 * coding.c (Fdecode_sjis_char): Don't assume CODE fits in int.
11449 * xterm.c (x_catch_errors): Remove duplicate declaration.
11451 * term.c (maybe_fatal): Mark its 3rd arg as a printf format, too.
11453 * xdisp.c, lisp.h (message_nolog): Remove; unused.
11455 2011-04-10 Jim Meyering <meyering@redhat.com>
11457 use ssize_t and size_t for read- and write-like emacs_gnutls_* functions
11458 * gnutls.c (emacs_gnutls_read): Adjust signature to be more read-like:
11459 return ssize_t not "int", and use size_t as the buffer length.
11460 (emacs_gnutls_write): Likewise, and make the buffer pointer "const".
11461 * gnutls.h: Update declarations.
11462 * process.c (read_process_output): Use ssize_t, to match.
11463 (send_process): Likewise.
11465 2011-04-09 Chong Yidong <cyd@stupidchicken.com>
11467 * image.c (Fimagemagick_types): Doc fix, and comment cleanup.
11469 2011-04-09 Chong Yidong <cyd@stupidchicken.com>
11471 * ftfont.c (get_adstyle_property, ftfont_pattern_entity):
11472 Use unsigned char, to match FcChar8 type definition.
11474 * xterm.c (handle_one_xevent):
11475 * xmenu.c (create_and_show_popup_menu):
11476 * xselect.c (x_decline_selection_request)
11477 (x_reply_selection_request): Avoid type-punned deref of X events.
11479 2011-04-09 Eli Zaretskii <eliz@gnu.org>
11481 Fix some uses of `int' instead of EMACS_INT.
11482 * search.c (string_match_1, fast_string_match)
11483 (fast_c_string_match_ignore_case, fast_string_match_ignore_case)
11484 (scan_buffer, find_next_newline_no_quit)
11485 (find_before_next_newline, search_command, Freplace_match)
11486 (Fmatch_data): Make some `int' variables be EMACS_INT.
11488 * xdisp.c (display_count_lines): 3rd argument and return value now
11489 EMACS_INT. All callers changed.
11490 (pint2hrstr): Last argument is now EMACS_INT.
11492 * coding.c (detect_coding_utf_8, detect_coding_emacs_mule)
11493 (detect_coding_iso_2022, detect_coding_sjis, detect_coding_big5)
11494 (detect_coding_ccl, detect_coding_charset, decode_coding_utf_8)
11495 (decode_coding_utf_16, decode_coding_emacs_mule)
11496 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5)
11497 (decode_coding_ccl, decode_coding_charset)
11498 <consumed_chars, consumed_chars_base>: Declare EMACS_INT.
11499 (decode_coding_iso_2022, decode_coding_emacs_mule)
11500 (decode_coding_sjis, decode_coding_big5, decode_coding_charset)
11501 <char_offset, last_offset>: Declare EMACS_INT.
11502 (encode_coding_utf_8, encode_coding_utf_16)
11503 (encode_coding_emacs_mule, encode_invocation_designation)
11504 (encode_designation_at_bol, encode_coding_iso_2022)
11505 (encode_coding_sjis, encode_coding_big5, encode_coding_ccl)
11506 (encode_coding_raw_text, encode_coding_charset) <produced_chars>:
11508 (ASSURE_DESTINATION): Declare more_bytes EMACS_INT.
11509 (encode_invocation_designation): Last argument P_NCHARS is now
11511 (decode_eol): Declare pos_byte, pos, and pos_end EMACS_INT.
11512 (produce_chars): from_nchars and to_nchars are now EMACS_INT.
11514 * coding.h (struct coding_system) <head_ascii>: Declare EMACS_INT.
11517 * ccl.c (Fccl_execute_on_string): Declare some variables
11520 2011-04-08 Samuel Thibault <sthibault@debian.org> (tiny change)
11522 * term.c (init_tty): Fix incorrect ifdef placement (Bug#8450).
11524 2011-03-19 Christoph Scholtes <cschol2112@googlemail.com>
11526 * process.c (Fformat_network_address): Doc fix.
11528 2011-04-08 T.V. Raman <tv.raman.tv@gmail.com> (tiny change)
11530 * xml.c (parse_region): Avoid creating spurious whitespace nodes.
11532 2011-04-08 Chong Yidong <cyd@stupidchicken.com>
11534 * keyboard.c (read_char): Call Lisp function help-form-show,
11535 instead of using internal_with_output_to_temp_buffer.
11536 (Qhelp_form_show): New var.
11537 (syms_of_keyboard): Use DEFSYM macro.
11539 * print.c (internal_with_output_to_temp_buffer): Function deleted.
11541 * lisp.h (internal_with_output_to_temp_buffer): Remove prototype.
11543 2011-04-06 Chong Yidong <cyd@stupidchicken.com>
11545 * process.c (Flist_processes): Remove to Lisp.
11546 (list_processes_1): Delete.
11548 2011-04-06 Eli Zaretskii <eliz@gnu.org>
11550 * msdos.c (careadlinkat, careadlinkatcwd): MS-DOS replacements.
11552 * w32.c (careadlinkat, careadlinkatcwd): New always-fail stubs.
11554 2011-04-06 Paul Eggert <eggert@cs.ucla.edu>
11556 Fix more problems found by GCC 4.6.0's static checks.
11558 * xmenu.c (Fx_popup_dialog): Don't assume string is free of formats.
11560 * menu.c (Fx_popup_menu): Don't assume error_name lacks printf formats.
11562 * lisp.h (message, message_nolog, fatal): Mark as printf-like.
11564 * xdisp.c (vmessage): Mark as a printf-like function.
11566 * term.c (vfatal, maybe_fatal): Mark as printf-like functions.
11568 * sound.c (sound_warning): Don't crash if arg contains a printf format.
11570 * image.c (tiff_error_handler, tiff_warning_handler): Mark as
11571 printf-like functions.
11572 (tiff_load): Add casts to remove these marks before passing them
11573 to system-supplied API.
11575 * eval.c (Fsignal): Remove excess argument to 'fatal'.
11577 * coding.c (EMIT_ONE_BYTE, EMIT_TWO_BYTES): Use unsigned, not int.
11578 This avoids several warnings with gcc -Wstrict-overflow.
11579 (DECODE_COMPOSITION_RULE): If the rule is invalid, goto invalid_code
11580 directly, rather than having caller test rule sign. This avoids
11581 some unnecessary tests.
11582 * composite.h (COMPOSITION_ENCODE_RULE_VALID): New macro.
11583 (COMPOSITION_ENCODE_RULE): Arguments now must be valid. This
11584 affects only one use, in DECODE_COMPOSITION_RULE, which is changed.
11586 * xfont.c (xfont_text_extents): Remove var that was set but not used.
11587 (xfont_open): Avoid unnecessary tests.
11589 * composite.c (composition_gstring_put_cache): Use unsigned integer.
11591 * composite.h, composite.c (composition_gstring_put_cache):
11592 Use EMACS_INT, not int, for length.
11594 * composite.h (COMPOSITION_DECODE_REFS): New macro,
11595 breaking out part of COMPOSITION_DECODE_RULE.
11596 (COMPOSITION_DECODE_RULE): Use it.
11597 * composite.c (get_composition_id): Remove unused local vars,
11598 by using the new macro.
11600 * textprop.c (set_text_properties_1): Change while to do-while,
11601 since the condition is always true at first.
11603 * intervals.c (graft_intervals_into_buffer): Mark var as used.
11604 (interval_deletion_adjustment): Return unsigned value.
11607 * process.c (list_processes_1, create_pty, read_process_output):
11608 (exec_sentinel): Remove vars that were set but not used.
11609 (create_pty): Remove unnecessary "volatile"s.
11610 (Fnetwork_interface_info): Avoid possibility of int overflow.
11611 (read_process_output): Do adaptive read buffering even if carryover.
11612 (read_process_output): Simplify nbytes computation if buffered.
11614 * bytecode.c (exec_byte_code): Rename local to avoid shadowing.
11616 * syntax.c (scan_words): Remove var that was set but not used.
11617 (update_syntax_table): Use unsigned instead of int.
11619 * lread.c (lisp_file_lexically_bound_p): Use ints rather than endptrs.
11620 (lisp_file_lexically_bound_p, read1): Use unsigned instead of int.
11621 (safe_to_load_p): Make the end-of-loop test the inverse of the in-loop.
11623 * print.c (print_error_message): Avoid int overflow.
11625 * font.c (font_list_entities): Redo for clarity,
11626 so that reader need not know FONT_DPI_INDEX + 1 == FONT_SPACING_INDEX.
11628 * font.c (font_find_for_lface, Ffont_get_glyphs): Remove unused vars.
11629 (font_score): Avoid potential overflow in diff calculation.
11631 * fns.c (substring_both): Remove var that is set but not used.
11632 (sxhash): Redo loop for clarity and to avoid wraparound warning.
11634 * eval.c (funcall_lambda): Rename local to avoid shadowing.
11636 * alloc.c (mark_object_loop_halt, mark_object): Use size_t, not int.
11637 Otherwise, GCC 4.6.0 optimizes the loop check away since the check
11638 can always succeed if overflow has undefined behavior.
11640 * search.c (boyer_moore, wordify): Remove vars set but not used.
11641 (wordify): Omit three unnecessary tests.
11643 * indent.c (MULTIBYTE_BYTES_WIDTH): Don't compute wide_column.
11644 All callers changed. This avoids the need for an unused var.
11646 * casefiddle.c (casify_region): Remove var that is set but not used.
11648 * dired.c (file_name_completion): Remove var that is set but not used.
11650 * fileio.c (Finsert_file_contents): Make EOF condition clearer.
11652 * fileio.c (Finsert_file_contents): Avoid signed integer overflow.
11653 (Finsert_file_contents): Remove unnecessary code checking fd.
11655 * minibuf.c (read_minibuf_noninteractive): Use size_t for sizes.
11656 Check for integer overflow on size calculations.
11658 * buffer.c (Fprevious_overlay_change): Remove var that is set
11661 * keyboard.c (menu_bar_items, read_char_minibuf_menu_prompt):
11662 Remove vars that are set but not used.
11663 (timer_check_2): Don't assume timer-list and idle-timer-list are lists.
11664 (timer_check_2): Mark vars as initialized.
11666 * gtkutil.c (xg_get_file_with_chooser): Mark var as initialized.
11668 * image.c (lookup_image): Remove var that is set but not used.
11669 (xbm_load): Use parse_p, for gcc -Werror=unused-but-set-variable.
11671 * fontset.c (Finternal_char_font, Ffontset_info): Remove vars
11672 that are set but not used.
11674 * xfns.c (make_invisible_cursor): Don't return garbage
11675 if XCreateBitmapFromData fails (Bug#8410).
11677 * xselect.c (x_get_local_selection, x_handle_property_notify):
11678 Remove vars that are set but not used.
11680 * xfns.c (x_create_tip_frame): Remove var that is set but not used.
11681 (make_invisible_cursor): Initialize a possibly-uninitialized variable.
11683 * xterm.c (x_scroll_bar_to_input_event) [!USE_GTK]:
11684 Remove var that is set but not used.
11685 (scroll_bar_windows_size): Now size_t, not int.
11686 (x_send_scroll_bar_event): Use size_t, not int, for sizes.
11687 Check for overflow.
11689 * xfaces.c (realize_named_face): Remove vars that are set but not used.
11690 (map_tty_color) [!defined MSDOS]: Likewise.
11692 * term.c (tty_write_glyphs): Use size_t; this avoids overflow warning.
11694 * coding.c: Remove vars that are set but not used.
11695 (DECODE_COMPOSITION_RULE): Remove 2nd arg, which is unused.
11696 All callers changed.
11697 (decode_coding_utf_8, decode_coding_utf_16 decode_coding_emacs_mule):
11698 (decode_coding_iso_2022, encode_coding_sjis, encode_coding_big5):
11699 (decode_coding_charset): Remove vars that are set but not used.
11701 * bytecode.c (Fbyte_code) [!defined BYTE_CODE_SAFE]: Remove var
11702 that is set but not used.
11704 * print.c (print_object): Remove var that is set but not used.
11706 Replace 2 copies of readlink code with 1 gnulib version (Bug#8401).
11707 The gnulib version avoids calling malloc in the usual case,
11708 and on 64-bit hosts doesn't have some arbitrary 32-bit limits.
11709 * fileio.c (Ffile_symlink_p): Use emacs_readlink.
11710 * filelock.c (current_lock_owner): Likewise.
11711 * lisp.h (READLINK_BUFSIZE, emacs_readlink): New function.
11712 * sysdep.c: Include allocator.h, careadlinkat.h.
11713 (emacs_no_realloc_allocator): New static constant.
11714 (emacs_readlink): New function.
11715 * deps.mk (sysdep.o): Depend on ../lib/allocator.h and on
11716 ../lib/careadlinkat.h.
11718 2011-04-04 Stefan Monnier <monnier@iro.umontreal.ca>
11720 * keyboard.c (safe_run_hook_funcall): Fix last change (don't stop at the
11721 first non-nil return value).
11723 2011-04-03 Jan Djärv <jan.h.d@swipnet.se>
11725 * nsterm.m (ns_update_auto_hide_menu_bar): Define MAC_OS_X_VERSION_10_6
11726 if not defined (Bug#8403).
11728 2011-04-02 Juanma Barranquero <lekktu@gmail.com>
11730 * xdisp.c (display_count_lines): Remove parameter `start',
11731 unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
11732 (get_char_face_and_encoding): Remove parameter `multibyte_p',
11733 unused since 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
11734 (fill_stretch_glyph_string): Remove parameters `row' and `area',
11735 unused at least since Kim's GUI unification at 2003-03-16T20:45:46Z!storm@cua.dk
11736 and thereabouts. All callers changed.
11737 (get_per_char_metric): Remove parameter `f', unused since
11738 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
11740 2011-04-02 Jim Meyering <meyering@redhat.com>
11742 do not dereference NULL upon failed strdup
11743 * nsfont.m (ns_descriptor_to_entity): Use xstrdup, not strdup.
11744 (ns_get_family): Likewise.
11746 2011-04-02 Juanma Barranquero <lekktu@gmail.com>
11748 * eval.c (unwind_to_catch) [DEBUG_GCPRO]: Remove redundant assignment.
11750 2011-04-02 Jan Djärv <jan.h.d@swipnet.se>
11752 * nsterm.m (ns_update_auto_hide_menu_bar): Only for OSX 10.6 or
11755 2011-04-01 Stefan Monnier <monnier@iro.umontreal.ca>
11757 Add lexical binding.
11759 * window.c (Ftemp_output_buffer_show): New fun.
11760 (Fsave_window_excursion):
11761 * print.c (Fwith_output_to_temp_buffer): Move to subr.el.
11763 * lread.c (lisp_file_lexically_bound_p): New function.
11764 (Fload): Bind Qlexical_binding.
11765 (readevalloop): Remove `evalfun' arg.
11766 Bind Qinternal_interpreter_environment.
11767 (Feval_buffer): Bind Qlexical_binding.
11768 (defvar_int, defvar_bool, defvar_lisp_nopro, defvar_kboard):
11770 (syms_of_lread): Declare `lexical-binding'.
11772 * lisp.h (struct Lisp_Symbol): New field `declared_special'.
11774 * keyboard.c (eval_dyn): New fun.
11775 (menu_item_eval_property): Use it.
11777 * image.c (parse_image_spec): Use Ffunctionp.
11779 * fns.c (concat, mapcar1): Accept byte-code-functions.
11781 * eval.c (Fsetq): Handle lexical vars.
11782 (Fdefun, Fdefmacro, Ffunction): Make closures when needed.
11783 (Fdefconst, Fdefvaralias, Fdefvar): Mark as dynamic.
11784 (FletX, Flet): Obey lexical binding.
11785 (Fcommandp): Handle closures.
11786 (Feval): New `lexical' arg.
11787 (eval_sub): New function extracted from Feval. Use it almost
11788 everywhere where Feval was used. Look up vars in lexical env.
11790 (Ffunctionp): Move from subr.el.
11791 (Ffuncall): Handle closures.
11792 (apply_lambda): Remove `eval_flags'.
11793 (funcall_lambda): Handle closures and new byte-code-functions.
11794 (Fspecial_variable_p): New function.
11795 (syms_of_eval): Initialize the Vinternal_interpreter_environment var,
11796 but without exporting it to Lisp.
11798 * doc.c (Fdocumentation, store_function_docstring):
11799 * data.c (Finteractive_form): Handle closures.
11801 * callint.c (Fcall_interactively): Preserve lexical-binding mode for
11804 * bytecode.c (Bstack_ref, Bstack_set, Bstack_set2, BdiscardN):
11806 (exec_byte_code): New function extracted from Fbyte_code to handle new
11807 calling convention for byte-code-functions. Add new byte-codes.
11809 * buffer.c (defvar_per_buffer): Set new `declared_special' field.
11811 * alloc.c (Fmake_symbol): Init new `declared_special' field.
11813 2011-03-31 Juanma Barranquero <lekktu@gmail.com>
11815 * xdisp.c (redisplay_internal): Fix prototype.
11817 2011-03-31 Eli Zaretskii <eliz@gnu.org>
11819 * xdisp.c (SCROLL_LIMIT): New macro.
11820 (try_scrolling): Use it when setting scroll_limit.
11821 Limit scrolling to 100 screen lines.
11822 (redisplay_window): Even when falling back on "recentering",
11823 position point in the window according to scroll-conservatively,
11824 scroll-margin, and scroll-*-aggressively variables. (Bug#6671)
11826 (try_scrolling): When point is above the window, allow searching
11827 as far as scroll_max, or one screenful, to compute vertical
11828 distance from PT to the scroll margin position. This prevents
11829 try_scrolling from unnecessarily failing when
11830 scroll-conservatively is set to a value slightly larger than the
11831 window height. Clean up the case of PT below the margin at bottom
11832 of window: scroll_max can no longer be INT_MAX. When aggressive
11833 scrolling is in use, don't let point enter the opposite scroll
11834 margin as result of the scroll.
11835 (syms_of_xdisp) <scroll-conservatively>: Document the
11836 threshold of 100 lines for never-recentering scrolling.
11838 2011-03-31 Juanma Barranquero <lekktu@gmail.com>
11840 * dispextern.h (move_it_by_lines):
11841 * xdisp.c (move_it_by_lines): Remove parameter `need_y_p', unused
11842 since 2000-12-29T14:24:09Z!gerd@gnu.org. All callers changed.
11843 (message_log_check_duplicate): Remove parameters `prev_bol' and
11844 `this_bol', unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
11845 (redisplay_internal): Remove parameter `preserve_echo_area',
11846 unused since 1999-07-21T21:43:52Z!gerd@gnu.org. All callers changed.
11848 * indent.c (Fvertical_motion):
11849 * window.c (window_scroll_pixel_based, Frecenter):
11850 Don't pass `need_y_p' to `move_it_by_lines'.
11852 2011-03-30 Stefan Monnier <monnier@iro.umontreal.ca>
11854 * eval.c (struct backtrace): Don't cheat with negative numbers, but do
11855 steal a few bits to be more compact.
11856 (interactive_p, Fbacktrace, Fbacktrace_frame, mark_backtrace):
11857 Remove unneeded casts.
11859 * bytecode.c (Fbyte_code): CAR and CDR can GC.
11861 2011-03-30 Zachary Kanfer <zkanfer@gmail.com> (tiny change)
11863 * keyboard.c (Fexecute_extended_command): Do log the "suggest key
11864 binding" message (bug#7967).
11866 2011-03-30 Paul Eggert <eggert@cs.ucla.edu>
11868 Fix more problems found by GCC 4.6.0's static checks.
11870 * unexelf.c (unexec) [! (defined _SYSTYPE_SYSV || defined __sgi)]:
11871 Remove unused local var.
11873 * editfns.c (Fmessage_box): Remove unused local var.
11875 * xdisp.c (try_window_reusing_current_matrix, x_produce_glyphs):
11876 (note_mode_line_or_margin_highlight, note_mouse_highlight):
11877 Omit unused local vars.
11878 * window.c (shrink_windows): Omit unused local var.
11879 * menu.c (digest_single_submenu): Omit unused local var.
11880 * dispnew.c (update_window) [PERIODIC_PREEMPTION_CHECKING]:
11881 Omit unused local var.
11883 * keyboard.c (parse_modifiers_uncached, parse_modifiers):
11884 Don't assume string length fits in int.
11885 (keyremap_step, read_key_sequence): Use size_t for sizes.
11886 (read_key_sequence): Don't check last_real_key_start redundantly.
11888 * callproc.c (Fcall_process, Fcall_process_region): Use SAFE_ALLOCA
11889 instead of alloca (Bug#8344).
11891 * eval.c (Fbacktrace): Don't assume nargs fits in int.
11892 (Fbacktrace_frame): Don't assume nframes fits in int.
11894 * syntax.c (scan_sexps_forward): Avoid pointer wraparound.
11896 * xterm.c (x_make_frame_visible, same_x_server): Redo to avoid overflow
11899 * term.c (produce_glyphless_glyph): Remove unnecessary test.
11901 * cm.c (calccost): Turn while-do into do-while, for clarity.
11903 * keyboard.c (syms_of_keyboard): Use the same style as later
11904 in this function when indexing through an array. This also
11905 works around GCC bug 48267.
11907 * image.c (tiff_load): Fix off-by-one image count (Bug#8336).
11909 * xselect.c (x_check_property_data): Return correct size (Bug#8335).
11911 * chartab.c (sub_char_table_ref_and_range): Redo for slight
11912 efficiency gain, and to bypass a gcc -Wstrict-overflow warning.
11914 * keyboard.c, keyboard.h (num_input_events): Now size_t.
11915 This avoids undefined behavior on integer overflow, and is a bit
11916 more convenient anyway since it is compared to a size_t variable.
11918 Variadic C functions now count arguments with size_t, not int.
11919 This avoids an unnecessary limitation on 64-bit machines, which
11920 caused (substring ...) to crash on large vectors (Bug#8344).
11921 * lisp.h (struct Lisp_Subr.function.aMANY): Now takes size_t, not int.
11922 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call): Likewise.
11923 All variadic functions and their callers changed accordingly.
11924 (struct gcpro.nvars): Now size_t, not int. All uses changed.
11925 * data.c (arith_driver, float_arith_driver): Likewise.
11926 * editfns.c (general_insert_function): Likewise.
11927 * eval.c (struct backtrace.nargs, interactive_p)
11928 (internal_condition_case_n, run_hook_with_args, apply_lambda)
11929 (funcall_lambda, mark_backtrace): Likewise.
11930 * fns.c (concat): Likewise.
11931 * frame.c (x_set_frame_parameters): Likewise.
11932 * fns.c (get_key_arg): Now accepts and returns size_t, and returns
11933 0 if not found, not -1. All callers changed.
11935 * alloc.c (garbage_collect): Don't assume stack size fits in int.
11936 (stack_copy_size): Now size_t, not int.
11937 (stack_copy, stack_copy_size): Define only if MAX_SAVE_STACK > 0.
11939 2011-03-28 Juanma Barranquero <lekktu@gmail.com>
11941 * coding.c (encode_designation_at_bol): Remove parameter `charbuf_end',
11942 unused since 2002-03-01T01:17:24Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
11943 All callers changed.
11945 * lisp.h (multibyte_char_to_unibyte):
11946 * character.c (multibyte_char_to_unibyte): Remove parameter `rev_tbl',
11947 unused since 2002-03-01T01:16:34Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
11948 * character.h (CHAR_TO_BYTE8):
11949 * cmds.c (internal_self_insert):
11950 * editfns.c (general_insert_function):
11951 * keymap.c (push_key_description):
11952 * search.c (Freplace_match):
11953 * xdisp.c (message_dolog, set_message_1): All callers changed.
11955 2011-03-28 Stefan Monnier <monnier@iro.umontreal.ca>
11957 * keyboard.c (safe_run_hook_funcall): New function.
11958 (safe_run_hooks_1, safe_run_hooks_error, safe_run_hooks): On error,
11959 don't set the hook to nil, but remove the offending function instead.
11960 (Qcommand_hook_internal): Remove, unused.
11961 (syms_of_keyboard): Don't initialize Qcommand_hook_internal nor define
11962 Vcommand_hook_internal.
11964 * eval.c (enum run_hooks_condition): Remove.
11965 (funcall_nil, funcall_not): New functions.
11966 (run_hook_with_args): Call each function through a `funcall' argument.
11967 Remove `cond' argument, now redundant.
11968 (Frun_hooks, Frun_hook_with_args, Frun_hook_with_args_until_success)
11969 (Frun_hook_with_args_until_failure): Adjust accordingly.
11970 (run_hook_wrapped_funcall, Frun_hook_wrapped): New functions.
11972 2011-03-28 Juanma Barranquero <lekktu@gmail.com>
11974 * dispextern.h (string_buffer_position): Remove declaration.
11976 * print.c (strout): Remove parameter `multibyte', unused since
11977 1999-08-21T19:30:21Z!gerd@gnu.org. All callers changed.
11979 * search.c (boyer_moore): Remove parameters `len', `pos' and `lim',
11980 never used since function introduction in 1998-02-08T21:33:56Z!rms@gnu.org.
11981 All callers changed.
11983 * w32.c (_wsa_errlist): Use braces for struct initializers.
11985 * xdisp.c (string_buffer_position_lim): Remove parameter `w',
11986 never used since function introduction in 2001-03-09T18:41:50Z!gerd@gnu.org.
11987 All callers changed.
11988 (string_buffer_position): Likewise. Also, make static (it's never
11989 used outside xdisp.c).
11990 (cursor_row_p): Remove parameter `w', unused since
11991 2000-10-17T16:08:57Z!gerd@gnu.org. All callers changed.
11992 (decode_mode_spec): Remove parameter `precision', introduced during
11993 Gerd Moellmann's rewrite at 1999-07-21T21:43:52Z!gerd@gnu.org, but never used.
11994 All callers changed.
11996 2011-03-27 Jan Djärv <jan.h.d@swipnet.se>
11998 * nsterm.m (syms_of_nsterm): Use doc: for ns-auto-hide-menu-bar.
12000 2011-03-27 Anders Lindgren <andlind@gmail.com>
12002 * nsterm.m (ns_menu_bar_is_hidden): New variable.
12003 (ns_constrain_all_frames, ns_menu_bar_should_be_hidden)
12004 (ns_update_auto_hide_menu_bar): New functions.
12005 (ns_update_begin): Call ns_update_auto_hide_menu_bar.
12006 (applicationDidBecomeActive): Call ns_update_auto_hide_menu_bar and
12007 ns_constrain_all_frames.
12008 (constrainFrameRect): Return at once if ns_menu_bar_should_be_hidden.
12009 (syms_of_nsterm): DEFVAR ns-auto-hide-menu-bar, init to Qnil.
12011 2011-03-27 Jan Djärv <jan.h.d@swipnet.se>
12013 * nsmenu.m (runDialogAt): Remove argument to timer_check.
12015 2011-03-27 Glenn Morris <rgm@gnu.org>
12017 * syssignal.h: Replace RETSIGTYPE with void.
12018 * atimer.c, data.c, dispnew.c, emacs.c, floatfns.c, keyboard.c:
12019 * keyboard.h, lisp.h, process.c, sysdep.c, xterm.c:
12020 Replace SIGTYPE with void everywhere.
12021 * s/usg5-4-common.h (SIGTYPE): Remove definition.
12022 * s/template.h (SIGTYPE): Remove commented out definition.
12024 2011-03-26 Eli Zaretskii <eliz@gnu.org>
12026 * xdisp.c (redisplay_window): Don't check buffer's clip_changed
12027 flag as a prerequisite for invoking try_scrolling. (Bug#6671)
12029 2011-03-26 Juanma Barranquero <lekktu@gmail.com>
12031 * w32.c (read_unc_volume): Use parameter `henum', instead of
12032 global variable `wget_enum_handle'.
12034 * keymap.c (describe_vector): Remove parameters `indices' and
12035 `char_table_depth', unused since 2002-03-01T01:43:26Z!handa@m17n.org.
12036 (describe_map, Fdescribe_vector): Adjust calls to `describe_vector'.
12038 * keyboard.h (timer_check, show_help_echo): Remove unused parameters.
12040 * keyboard.c (timer_check): Remove parameter `do_it_now',
12041 unused since 1996-04-12T06:01:29Z!rms@gnu.org.
12042 (show_help_echo): Remove parameter `ok_to_overwrite_keystroke_echo',
12043 unused since 2008-04-19T19:30:53Z!monnier@iro.umontreal.ca.
12045 * keyboard.c (read_char):
12046 * w32menu.c (w32_menu_display_help):
12047 * xmenu.c (show_help_event, menu_help_callback):
12048 Adjust calls to `show_help_echo'.
12050 * gtkutil.c (xg_maybe_add_timer):
12051 * keyboard.c (readable_events):
12052 * process.c (wait_reading_process_output):
12053 * xmenu.c (x_menu_wait_for_event): Adjust calls to `timer_check'.
12055 * insdel.c (adjust_markers_gap_motion):
12056 Remove; no-op since 1998-01-02T21:29:48Z!rms@gnu.org.
12057 (gap_left, gap_right): Don't call it.
12059 2011-03-25 Chong Yidong <cyd@stupidchicken.com>
12061 * xdisp.c (handle_fontified_prop): Discard changes to clip_changed
12062 incurred during fontification.
12064 2011-03-25 Juanma Barranquero <lekktu@gmail.com>
12066 * buffer.c (defvar_per_buffer): Remove unused parameter `doc'.
12067 (DEFVAR_PER_BUFFER): Don't pass it.
12069 * dispnew.c (row_equal_p, add_row_entry): Remove unused parameter `w'.
12070 (scrolling_window): Don't pass it.
12072 2011-03-25 Juanma Barranquero <lekktu@gmail.com>
12074 * dispextern.h (glyph_matric): Use #if GLYPH_DEBUG, not #ifdef.
12076 * fileio.c (check_executable) [DOS_NT]: Remove unused variables `len'
12078 (Fset_file_selinux_context) [HAVE_LIBSELINUX]: Move here declaration
12079 of variables specific to SELinux and computation of `encoded_absname'.
12081 * image.c (XPutPixel): Remove unused variable `height'.
12083 * keyboard.c (make_lispy_event): Remove unused variable `hpos'.
12085 * unexw32.c (get_section_info): Remove unused variable `section'.
12087 * w32.c (stat): Remove unused variables `drive_root' and `devtype'.
12088 (system_process_attributes): Remove unused variable `sess'.
12089 (sys_read): Remove unused variable `err'.
12091 * w32fns.c (top): Wrap variables with #if GLYPH_DEBUG, not #ifdef.
12092 (w32_wnd_proc): Remove unused variable `isdead'.
12093 (unwind_create_frame): Use #if GLYPH_DEBUG, not #ifdef.
12094 (Fx_server_max_request_size): Remove unused variable `dpyinfo'.
12095 (x_create_tip_frame): Remove unused variable `tem'.
12097 * w32inevt.c (w32_console_read_socket):
12098 Remove unused variable `no_events'.
12100 * w32term.c (x_draw_composite_glyph_string_foreground):
12101 Remove unused variable `width'.
12103 2011-03-24 Juanma Barranquero <lekktu@gmail.com>
12105 * w32term.c (x_set_glyph_string_clipping):
12106 Don't pass uninitialized region to CombineRgn.
12108 2011-03-23 Juanma Barranquero <lekktu@gmail.com>
12110 * w32fns.c (x_set_menu_bar_lines): Remove unused variable `olines'.
12111 (w32_wnd_proc): Pass NULL to Windows API, not uninitialized buffer.
12112 (Fx_close_connection): Remove unused variable `i'.
12114 * w32font.c (w32font_draw): Return number of glyphs.
12115 (w32font_open_internal): Remove unused variable `i'.
12116 (w32font_driver): Add missing initializer.
12118 * w32menu.c (utf8to16): Remove unused variable `utf16'.
12119 (fill_in_menu): Remove unused variable `items_added'.
12121 * w32term.c (last_mouse_press_frame): Remove static global variable.
12122 (w32_clip_to_row): Remove unused variable `f'.
12123 (x_delete_terminal): Remove unused variable `i'.
12125 * w32uniscribe.c (uniscribe_shape): Remove unused variable `nclusters'.
12126 (NOTHING): Remove unused static global variable.
12127 (uniscribe_check_otf): Remove unused variable `table'.
12128 (uniscribe_font_driver): Add missing initializers.
12130 2011-03-23 Julien Danjou <julien@danjou.info>
12132 * term.c (Fsuspend_tty, Fresume_tty):
12133 * minibuf.c (read_minibuf, run_exit_minibuf_hook):
12134 * window.c (temp_output_buffer_show):
12135 * insdel.c (signal_before_change):
12136 * frame.c (Fhandle_switch_frame):
12137 * fileio.c (Fdo_auto_save):
12138 * emacs.c (Fkill_emacs):
12139 * editfns.c (save_excursion_restore):
12140 * cmds.c (internal_self_insert):
12141 * callint.c (Fcall_interactively):
12142 * buffer.c (Fkill_all_local_variables):
12143 * keyboard.c (Fcommand_execute, Fsuspend_emacs, safe_run_hooks_1):
12145 (command_loop_1): Use Frun_hooks. Call safe_run_hooks
12146 unconditionally since it does the check itself.
12148 2011-03-23 Paul Eggert <eggert@cs.ucla.edu>
12150 Fix more problems found by GCC 4.5.2's static checks.
12152 * coding.c (encode_coding_raw_text): Avoid unnecessary test
12153 the first time through the loop, since we know p0 < p1 then.
12154 This also avoids a gcc -Wstrict-overflow warning.
12156 * lisp.h (SAFE_ALLOCA, SAFE_ALLOCA_LISP): Avoid 'int' overflow
12157 leading to a memory leak, possible in functions like
12158 load_charset_map_from_file that can allocate an unbounded number
12159 of objects (Bug#8318).
12161 * xmenu.c (set_frame_menubar): Use EMACS_UINT, not int, for indexes
12162 that could (at least in theory) be that large.
12164 * xdisp.c (message_log_check_duplicate): Return unsigned long, not int.
12165 This is less likely to overflow, and avoids undefined behavior if
12166 overflow does occur. All callers changed. Use strtoul to scan
12167 for the unsigned long integer.
12168 (pint2hrstr): Simplify and tune code slightly.
12169 This also avoids a (bogus) GCC warning with gcc -Wstrict-overflow.
12171 * scroll.c (do_scrolling): Work around GCC bug 48228.
12172 See <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=48228>.
12174 * frame.c (Fmodify_frame_parameters): Simplify loop counter.
12175 This also avoids a warning with gcc -Wstrict-overflow.
12176 (validate_x_resource_name): Simplify count usage.
12177 This also avoids a warning with gcc -Wstrict-overflow.
12179 * fileio.c (Fcopy_file): Report error if fchown or fchmod
12182 * emacs.c (Fdaemon_initialized): Do not ignore I/O errors (Bug#8303).
12184 * process.c (Fmake_network_process): Use socklen_t, not int,
12185 where POSIX says socklen_t is required in portable programs.
12186 This fixes a porting bug on hosts like 64-bit HP-UX, where
12187 socklen_t is wider than int (Bug#8277).
12188 (Fmake_network_process, server_accept_connection):
12189 (wait_reading_process_output, read_process_output):
12192 * process.c: Rename or move locals to avoid shadowing.
12193 (list_processes_1, Fmake_network_process):
12194 (read_process_output_error_handler, exec_sentinel_error_handler):
12195 Rename or move locals.
12196 (Fmake_network_process): Define label "retry_connect" only if needed.
12197 (Fnetwork_interface_info): Fix pointer signedness.
12198 (process_send_signal): Add cast to avoid pointer signedness problem.
12199 (FIRST_PROC_DESC, IF_NON_BLOCKING_CONNECT): Remove unused macros.
12200 (create_process): Use 'volatile' to avoid vfork clobbering (Bug#8298).
12202 Make tparam.h and terminfo.c consistent.
12203 * cm.c (tputs, tgoto, BC, UP): Remove extern decls.
12204 Include tparam.h instead, since it declares them.
12205 * cm.h (PC): Remove extern decl; tparam.h now does this.
12206 * deps.mk (cm.o, terminfo.o): Depend on tparam.h.
12207 * terminfo.c: Include tparam.h, to check interfaces.
12208 (tparm): Make 1st arg a const pointer in decl. Put it at top level.
12209 (tparam): Adjust signature to match interface in tparam.h;
12210 this removes some undefined behavior. Check that outstring and len
12211 are zero, which they always are with Emacs.
12212 * tparam.h (PC, BC, UP): New extern decls.
12214 * xftfont.c (xftfont_shape): Now static, and defined only if needed.
12215 (xftfont_open): Rename locals to avoid shadowing.
12217 * ftfont.c (ftfont_resolve_generic_family): Fix pointer signedness.
12218 (ftfont_otf_capability, ftfont_shape): Omit decls if not needed.
12219 (OTF_TAG_SYM): Omit macro if not needed.
12220 (ftfont_list): Remove unused local.
12221 (get_adstyle_property, ftfont_pattern_entity):
12222 (ftfont_lookup_cache, ftfont_open, ftfont_anchor_point):
12223 Rename locals to avoid shadowing.
12225 * xfont.c (xfont_list_family): Mark var as initialized.
12227 * xml.c (make_dom): Now static.
12229 * composite.c (composition_compute_stop_pos): Rename local to
12231 (composition_reseat_it): Remove unused locals.
12232 (find_automatic_composition, composition_adjust_point): Likewise.
12233 (composition_update_it): Mark var as initialized.
12234 (find_automatic_composition): Mark vars as initialized,
12235 with a FIXME (Bug#8290).
12237 character.h: Rename locals to avoid shadowing.
12238 * character.h (PREV_CHAR_BOUNDARY, FETCH_STRING_CHAR_ADVANCE):
12239 (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE, FETCH_CHAR_ADVANCE):
12240 (FETCH_CHAR_ADVANCE_NO_CHECK, INC_POS, DEC_POS, BUF_INC_POS):
12241 (BUF_DEC_POS): Be more systematic about renaming local temporaries
12242 to avoid shadowing.
12244 * textprop.c (property_change_between_p): Remove; unused.
12246 * intervals.c (interval_start_pos): Now static.
12248 * intervals.h (CHECK_TOTAL_LENGTH): Avoid empty "else".
12250 * atimer.c (start_atimer, append_atimer_lists, set_alarm):
12251 Rename locals to avoid shadowing.
12253 * sound.c (wav_play, au_play, Fplay_sound_internal):
12254 Fix pointer signedness.
12255 (alsa_choose_format): Remove unused local var.
12256 (wav_play): Initialize a variable to 0, to prevent undefined
12257 behavior (Bug#8278).
12259 * region-cache.c (insert_cache_boundary): Redo var to avoid shadowing.
12261 * region-cache.h (pp_cache): New decl, for gcc -Wmissing-prototypes.
12263 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork
12264 clobbering (Bug#8298).
12265 * sysdep.c (sys_subshell): Likewise.
12266 Previously, the sys_subshell 'volatile' was incorrectly IF_LINTted out.
12268 * lisp.h (child_setup): Now NO_RETURN unless DOS_NT.
12269 This should get cleaned up, so that child_setup has the
12270 same signature on all platforms.
12272 * callproc.c (call_process_cleanup): Now static.
12273 (relocate_fd): Rename locals to avoid shadowing.
12275 2011-03-22 Chong Yidong <cyd@stupidchicken.com>
12277 * xterm.c (x_clear_frame): Remove XClearWindow call. This appears
12278 not to be necessary, and produces flickering.
12280 2011-03-20 Glenn Morris <rgm@gnu.org>
12282 * config.in: Remove file.
12284 2011-03-20 Juanma Barranquero <lekktu@gmail.com>
12286 * minibuf.c (Vcompleting_read_function): Don't declare, global variables
12287 are now in src/globals.h.
12288 (syms_of_minibuf): Remove spurious & from previous change.
12290 2011-03-20 Leo Liu <sdl.web@gmail.com>
12292 * minibuf.c (completing-read-function): New variable.
12293 (completing-read-default): Rename from completing-read.
12294 (completing-read): Call completing-read-function.
12296 2011-03-19 Juanma Barranquero <lekktu@gmail.com>
12298 * xfaces.c (Fx_load_color_file):
12299 Read color file from absolute filename (bug#8250).
12301 2011-03-19 Juanma Barranquero <lekktu@gmail.com>
12303 * makefile.w32-in: Update dependencies.
12305 2011-03-17 Eli Zaretskii <eliz@gnu.org>
12307 * makefile.w32-in ($(BLD)/unexw32.$(O)): Depend on $(SRC)/unexec.h.
12309 2011-03-17 Paul Eggert <eggert@cs.ucla.edu>
12311 Fix more problems found by GCC 4.5.2's static checks.
12313 * process.c (make_serial_process_unwind, send_process_trap):
12314 (sigchld_handler): Now static.
12316 * process.c (allocate_pty): Let PTY_ITERATION declare iteration vars.
12317 That way, the code declares only the vars that it needs.
12318 * s/aix4-2.h (PTY_ITERATION): Declare iteration vars.
12319 * s/cygwin.h (PTY_ITERATION): Likewise.
12320 * s/darwin.h (PTY_ITERATION): Likewise.
12321 * s/gnu-linux.h (PTY_ITERATION): Likewise.
12323 * s/irix6-5.h (PTY_OPEN): Declare stb, to loosen coupling.
12324 * process.c (allocate_pty): Don't declare stb unless it's needed.
12326 * bytecode.c (MAYBE_GC): Rewrite so as not to use empty "else".
12327 (CONSTANTLIM): Remove; unused.
12328 (METER_CODE, Bscan_buffer, Bread_char, Bset_mark):
12329 Define only if needed.
12331 * unexelf.c (unexec): Name an expression,
12332 to avoid gcc -Wbad-function-cast warning.
12333 Use a different way to cause a compilation error if anyone uses
12334 n rather than nn, a way that does not involve shadowing.
12335 (ELF_BSS_SECTION_NAME, OLD_PROGRAM_H): Remove; unused.
12337 * deps.mk (unexalpha.o): Remove; unused.
12339 New file unexec.h, the (simple) interface for unexec (Bug#8267).
12340 * unexec.h: New file.
12341 * deps.mk (emacs.o, unexaix.o, unexcw.o, unexcoff.o, unexelf.o):
12342 (unexhp9k800.o, unexmacosx.o, unexsol.o, unexw32.o):
12343 Depend on unexec.h.
12344 * emacs.c [!defined CANNOT_DUMP]: Include unexec.h.
12345 * unexaix.c, unexcoff.c, unexcw.c, unexelf.c, unexhp9k800.c:
12346 * unexmacosx.c, unexsol.c, unexw32.c: Include unexec.h.
12347 Change as necessary to match prototype in unexec.h.
12349 * syntax.c (Fforward_comment, scan_lists): Rename locals to avoid
12351 (back_comment, skip_chars): Mark vars as initialized.
12353 * character.h (FETCH_STRING_CHAR_ADVANCE_NO_CHECK, BUF_INC_POS):
12354 Rename locals to avoid shadowing.
12356 * lread.c (read1): Rewrite so as not to use empty "else".
12357 (Fload, readevalloop, read1): Rename locals to avoid shadowing.
12359 * print.c (Fredirect_debugging_output): Fix pointer signedess.
12361 * lisp.h (debug_output_compilation_hack): Add decl here, to avoid
12362 warning when compiling print.c.
12364 * font.c (font_unparse_fcname): Abort in an "impossible" situation
12365 instead of using an uninitialized var.
12366 (font_sort_entities): Mark var as initialized.
12368 * character.h (FETCH_CHAR_ADVANCE): Rename locals to avoid shadowing.
12370 * font.c (font_unparse_xlfd): Don't mix pointers to variables with
12371 pointers to constants.
12372 (font_parse_fcname): Remove unused vars.
12373 (font_delete_unmatched): Now static.
12374 (font_get_spec): Remove; unused.
12375 (font_style_to_value, font_prop_validate_style, font_unparse_fcname):
12376 (font_update_drivers, Ffont_get_glyphs, font_add_log):
12377 Rename or move locals to avoid shadowing.
12379 * fns.c (require_nesting_list, require_unwind): Now static.
12380 (Ffillarray): Rename locals to avoid shadowing.
12382 * floatfns.c (domain_error2): Define only if needed.
12383 (Ffrexp, Fldexp): Rename locals to avoid shadowing.
12385 * alloc.c (mark_backtrace): Move decl from here ...
12386 * lisp.h: ... to here, so that it can be checked.
12388 * eval.c (call_debugger, do_debug_on_call, grow_specpdl): Now static.
12389 (Fdefvar): Rewrite so as not to use empty "else".
12390 (lisp_indirect_variable): Name an expression,
12391 to avoid gcc -Wbad-function-cast warning.
12392 (Fdefvar): Rename locals to avoid shadowing.
12394 * callint.c (quotify_arg, quotify_args): Now static.
12395 (Fcall_interactively): Rename locals to avoid shadowing.
12396 Use const pointer when appropriate.
12398 * lisp.h (get_system_name, get_operating_system_release):
12399 Move decls here, to check interfaces.
12400 * process.c (get_operating_system_release): Move decl to lisp.h.
12401 * xrdb.c (get_system_name): Likewise.
12402 * editfns.c (init_editfns, Fuser_login_name, Fuser_uid):
12403 (Fuser_real_uid, Fuser_full_name): Remove unnecessary casts,
12404 some of which prompt warnings from gcc -Wbad-function-cast.
12405 (Fformat_time_string, Fencode_time, Finsert_char):
12406 (Ftranslate_region_internal, Fformat):
12407 Rename or remove local vars to avoid shadowing.
12408 (Ftranslate_region_internal): Mark var as initialized.
12410 * doc.c (Fdocumentation, Fsnarf_documentation): Move locals to
12413 * lisp.h (eassert): Check that the argument compiles, even if
12414 ENABLE_CHECKING is not defined.
12416 * data.c (Findirect_variable): Name an expression, to avoid
12417 gcc -Wbad-function-cast warning.
12418 (default_value, arithcompare, arith_driver, arith_error): Now static.
12419 (store_symval_forwarding): Rename local to avoid shadowing.
12420 (Fmake_variable_buffer_local, Fmake_local_variable):
12421 Mark variables as initialized.
12422 (do_blv_forwarding, do_symval_forwarding): Remove; unused.
12424 * alloc.c (check_cons_list): Do not define unless GC_CHECK_CONS_LIST.
12425 (Fmake_vector, Fvector, Fmake_byte_code, Fgarbage_collect):
12426 Rename locals to avoid shadowing.
12427 (mark_stack): Move local variables into the #ifdef region where
12429 (BLOCK_INPUT_ALLOC, UNBLOCK_INPUT_ALLOC): Define only if
12430 ! defined SYSTEM_MALLOC && ! defined SYNC_INPUT, as they are not
12432 (CHECK_ALLOCATED): Define only if GC_CHECK_MARKED_OBJECTS.
12433 (GC_STRING_CHARS): Remove; not used.
12434 (Fmemory_limit): Cast sbrk's returned value to char *.
12436 * lisp.h (check_cons_list): Declare if GC_CHECK_CONS_LIST; this
12437 avoids undefined behavior in theory.
12439 * regex.c (IF_LINT): Add defn, for benefit of ../lib-src.
12441 Use functions, not macros, for up- and down-casing (Bug#8254).
12442 * buffer.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
12443 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Remove. All callers changed
12444 to use the following functions instead of these macros.
12445 (downcase): Adjust to lack of DOWNCASE_TABLE. Return int, not
12446 EMACS_INT, since callers assume the returned value fits in int.
12447 (upcase1): Likewise, for UPCASE_TABLE.
12448 (uppercasep, lowercasep, upcase): New static inline functions.
12449 * editfns.c (Fchar_equal): Remove no-longer-needed workaround for
12450 the race-condition problem in the old DOWNCASE.
12452 * regex.c (CHARSET_LOOKUP_RANGE_TABLE_RAW, POP_FAILURE_REG_OR_COUNT):
12453 Rename locals to avoid shadowing.
12454 (regex_compile, re_match_2_internal): Move locals to avoid shadowing.
12455 (regex_compile, re_search_2, re_match_2_internal):
12456 Remove unused local vars.
12457 (FREE_VAR): Rewrite so as not to use empty "else",
12458 which gcc can warn about.
12459 (regex_compile, re_match_2_internal): Mark locals as initialized.
12460 (RETALLOC_IF): Define only if needed.
12461 (WORDCHAR_P): Likewise. This one is never needed, but is used
12462 only in a comment talking about a compiler bug, so put inside
12463 the #if 0 of that comment.
12464 (CHARSET_LOOKUP_BITMAP, FAIL_STACK_FULL, RESET_FAIL_STACK):
12465 (PUSH_FAILURE_ELT, BUF_PUSH_3, STOP_ADDR_VSTRING):
12468 * search.c (boyer_moore): Rename locals to avoid shadowing.
12469 * character.h (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE):
12470 (PREV_CHAR_BOUNDARY): Likewise.
12472 * search.c (simple_search): Remove unused var.
12474 * dired.c (compile_pattern): Move decl from here ...
12475 * lisp.h: ... to here, so that it can be checked.
12476 (struct re_registers): New forward decl.
12478 * character.h (INC_POS, DEC_POS): Rename locals to avoid shadowing.
12480 * indent.c (MULTIBYTE_BYTES_WIDTH): New args bytes, width.
12482 (MULTIBYTE_BYTES_WIDTH, scan_for_column, compute_motion):
12483 Rename locals to avoid shadowing.
12484 (Fvertical_motion): Mark locals as initialized.
12486 * casefiddle.c (casify_object, casify_region): Now static.
12487 (casify_region): Mark local as initialized.
12489 * cmds.c (internal_self_insert): Rename local to avoid shadowing.
12491 * lisp.h (GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR, GCPRO5_VAR, GCPRO6_VAR):
12492 New macros, so that the caller can use some names other than
12493 gcpro1, gcpro2, etc.
12494 (GCPRO2, GCPRO3, GCPRO4, GCPRO5, GCPRO6): Reimplement in terms
12496 (GCPRO1_VAR, UNGCPRO_VAR): Change the meaning of the second
12497 argument, for consistency with GCPRO2_VAR, etc: it is now the
12498 prefix of the variable, not the variable itself. All uses
12500 * dired.c (directory_files_internal, file_name_completion):
12501 Rename locals to avoid shadowing.
12503 Fix a race condition diagnosed by gcc -Wsequence-point (Bug#8254).
12504 An expression of the form (DOWNCASE (x) == DOWNCASE (y)), found in
12505 dired.c's scmp function, had undefined behavior.
12506 * lisp.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
12507 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Move from here ...
12508 * buffer.h: ... to here, because these macros use current_buffer,
12509 and the new implementation with inline functions needs to have
12510 current_buffer in scope now, rather than later when the macros
12512 (downcase, upcase1): New static inline functions.
12513 (DOWNCASE, UPCASE1): Reimplement using these functions.
12514 This avoids undefined behavior in expressions like
12515 DOWNCASE (x) == DOWNCASE (y), which previously suffered
12516 from race conditions in accessing the global variables
12517 case_temp1 and case_temp2.
12518 * casetab.c (case_temp1, case_temp2): Remove; no longer needed.
12519 * lisp.h (case_temp1, case_temp2): Remove their decls.
12520 * character.h (ASCII_CHAR_P): Move from here ...
12521 * lisp.h: ... to here, so that the inline functions mentioned
12522 above can use them.
12524 * dired.c (directory_files_internal_unwind): Now static.
12526 * fileio.c (file_name_as_directory, directory_file_name):
12527 (barf_or_query_if_file_exists, auto_save_error, auto_save_1):
12529 (file_name_as_directory): Use const pointers when appropriate.
12530 (Fexpand_file_name): Likewise. In particular, newdir might
12531 point at constant storage, so make it a const pointer.
12532 (Fmake_directory_internal, Fread_file_name): Remove unused vars.
12533 (Ffile_selinux_context, Fset_file_selinux_context): Fix pointer
12535 (Fset_file_times, Finsert_file_contents, auto_save_error):
12536 Rename locals to avoid shadowing.
12538 * minibuf.c (choose_minibuf_frame_1): Now static.
12539 (Ftry_completion, Fall_completions): Rename or remove locals
12540 to avoid shadowing.
12542 * marker.c (bytepos_to_charpos): Remove; unused.
12544 * lisp.h (verify_bytepos, count_markers): New decls,
12545 so that gcc does not warn that these functions aren't declared.
12547 * insdel.c (check_markers, make_gap_larger, make_gap_smaller):
12548 (reset_var_on_error, Fcombine_after_change_execute_1): Now static.
12549 (CHECK_MARKERS): Redo to avoid gcc -Wempty-body diagnostic.
12550 (copy_text): Remove unused local var.
12552 * filelock.c (within_one_second): Now static.
12553 (lock_file_1): Rename local to avoid shadowing.
12555 * buffer.c (fix_overlays_before): Mark locals as initialized.
12556 (fix_start_end_in_overlays): Likewise. This function should be
12557 simplified by using pointers-to-pointers, but that's a different
12559 (switch_to_buffer_1): Now static.
12560 (Fkill_buffer, record_buffer, Fbury_buffer, Fset_buffer_multibyte):
12561 (report_overlay_modification): Rename locals to avoid shadowing.
12563 * sysdep.c (system_process_attributes): Rename vars to avoid shadowing.
12564 Fix pointer signedness issue.
12565 (sys_subshell): Mark local as volatile if checking for lint,
12566 to suppress a gcc -Wclobbered warning that does not seem to be right.
12567 (MAXPATHLEN): Define only if needed.
12569 * process.c (serial_open, serial_configure): Move decls from here ...
12570 * systty.h: ... to here, so that they can be checked.
12572 * fns.c (get_random, seed_random): Move extern decls from here ...
12573 * lisp.h: ... to here, so that they can be checked.
12575 * sysdep.c (reset_io): Now static.
12576 (wait_for_termination_signal): Remove; unused.
12578 * keymap.c (keymap_parent, keymap_memberp, map_keymap_internal):
12579 (copy_keymap_item, append_key, push_text_char_description):
12581 (Fwhere_is_internal): Don't test CONSP (sequences) unnecessarily.
12582 (DENSE_TABLE_SIZE): Remove; unused.
12583 (get_keymap, access_keymap, Fdefine_key, Fwhere_is_internal):
12584 (describe_map_tree):
12585 Rename locals to avoid shadowing.
12587 * keyboard.c: Declare functions static if they are not used elsewhere.
12588 (echo_char, echo_dash, cmd_error, top_level_2):
12589 (poll_for_input, handle_async_input): Now static.
12590 (read_char, kbd_buffer_get_event, make_lispy_position):
12591 (make_lispy_event, make_lispy_movement, apply_modifiers):
12592 (decode_keyboard_code, tty_read_avail_input, menu_bar_items):
12593 (parse_tool_bar_item, read_key_sequence, Fread_key_sequence):
12594 (Fread_key_sequence_vector): Rename locals to avoid shadowing.
12595 (read_key_sequence, read_char): Mark locals as initialized.
12596 (Fexit_recursive_edit, Fabort_recursive_edit): Mark with NO_RETURN.
12598 * keyboard.h (make_ctrl_char): New decl.
12599 (mark_kboards): Move decl here ...
12600 * alloc.c (mark_kboards): ... from here.
12602 * lisp.h (force_auto_save_soon): New decl.
12604 * emacs.c (init_cmdargs): Rename local to avoid shadowing.
12605 (DEFINE_DUMMY_FUNCTION): New macro.
12606 (__do_global_ctors, __do_global_ctors_aux, __do_global_dtors, __main):
12608 (main): Add casts to avoid warnings
12609 if GCC considers string literals to be constants.
12611 * lisp.h (fatal_error_signal): Add decl, since it's exported.
12613 * dbusbind.c: Pointer signedness fixes.
12614 (xd_signature, xd_append_arg, xd_initialize):
12615 (Fdbus_call_method, Fdbus_call_method_asynchronously):
12616 (Fdbus_method_return_internal, Fdbus_method_error_internal):
12617 (Fdbus_send_signal, xd_read_message_1, Fdbus_register_service):
12618 (Fdbus_register_signal): Use SSDATA when the context wants char *.
12620 * dbusbind.c (Fdbus_init_bus): Add cast to avoid warning
12621 if GCC considers string literals to be constants.
12622 (Fdbus_register_service, Fdbus_register_method): Remove unused vars.
12624 2011-03-16 Stefan Monnier <monnier@iro.umontreal.ca>
12626 * print.c (PRINT_CIRCLE_CANDIDATE_P): New macro.
12627 (print_preprocess, print_object): New macro to fix last change.
12629 * print.c (print_preprocess): Don't forget font objects.
12631 2011-03-16 Juanma Barranquero <lekktu@gmail.com>
12633 * emacs.c (USAGE3): Doc fixes.
12635 2011-03-15 Andreas Schwab <schwab@linux-m68k.org>
12637 * coding.c (detect_coding_iso_2022): Reorganize code to clarify
12640 2011-03-14 Juanma Barranquero <lekktu@gmail.com>
12642 * lisp.h (VWindow_system, Qfile_name_history):
12643 * keyboard.h (lispy_function_keys) [WINDOWSNT]:
12644 * w32term.h (w32_system_caret_hwnd, w32_system_caret_height)
12645 (w32_system_caret_x, w32_system_caret_y): Declare extern.
12647 * w32select.c: Don't #include "keyboard.h".
12648 (run_protected): Add extern declaration for waiting_for_input.
12650 * w32.c (Qlocal, noninteractive1, inhibit_window_system):
12651 * w32console.c (detect_input_pending, read_input_pending)
12652 (encode_terminal_code):
12653 * w32fns.c (quit_char, lispy_function_keys, Qtooltip)
12654 (w32_system_caret_hwnd, w32_system_caret_height, w32_system_caret_x)
12655 (w32_system_caret_y, Qfile_name_history):
12656 * w32font.c (w32font_driver, QCantialias, QCotf, QClang):
12657 * w32inevt.c (reinvoke_input_signal, lispy_function_keys):
12658 * w32menu.c (Qmenu_bar, QCtoggle, QCradio, Qoverriding_local_map)
12659 (Qoverriding_terminal_local_map, Qmenu_bar_update_hook):
12660 * w32proc.c (Qlocal, report_file_error):
12661 * w32term.c (Vwindow_system, updating_frame):
12662 * w32uniscribe.c (initialized, uniscribe_font_driver):
12663 Remove unneeded extern declarations.
12665 2011-03-14 Chong Yidong <cyd@stupidchicken.com>
12667 * buffer.c (Fmake_indirect_buffer): Fix incorrect assertions.
12669 2011-03-13 Chong Yidong <cyd@stupidchicken.com>
12671 * buffer.h (BUF_BEGV, BUF_BEGV_BYTE, BUF_ZV, BUF_ZV_BYTE, BUF_PT)
12672 (BUF_PT_BYTE): Rewrite to handle indirect buffers (Bug#8219).
12673 These macros can no longer be used for assignment.
12675 * buffer.c (Fget_buffer_create, Fmake_indirect_buffer):
12676 Assign struct members directly, instead of using BUF_BEGV etc.
12677 (record_buffer_markers, fetch_buffer_markers): New functions for
12678 recording and fetching special buffer markers.
12679 (set_buffer_internal_1, set_buffer_temp): Use them.
12681 * lread.c (unreadchar): Use SET_BUF_PT_BOTH.
12683 * insdel.c (adjust_point): Use SET_BUF_PT_BOTH.
12685 * intervals.c (temp_set_point_both): Use SET_BUF_PT_BOTH.
12686 (get_local_map): Use SET_BUF_BEGV_BOTH and SET_BUF_ZV_BOTH.
12688 * xdisp.c (hscroll_window_tree):
12689 (reconsider_clip_changes): Use PT instead of BUF_PT.
12691 2011-03-13 Eli Zaretskii <eliz@gnu.org>
12693 * makefile.w32-in ($(BLD)/editfns.$(O)): Depend on
12694 $(EMACS_ROOT)/lib/intprops.h.
12696 2011-03-13 Paul Eggert <eggert@cs.ucla.edu>
12698 Fix more problems found by GCC 4.5.2's static checks.
12700 * gtkutil.c (xg_get_pixbuf_from_pixmap): Add cast from char *
12701 to unsigned char * to avoid compiler diagnostic.
12702 (xg_free_frame_widgets): Make it clear that a local variable is
12703 needed only if USE_GTK_TOOLTIP.
12704 (gdk_window_get_screen): Make it clear that this macro is needed
12705 only if USE_GTK_TOOLTIP.
12706 (int_gtk_range_get_value): New function, which avoids a diagnostic
12707 from gcc -Wbad-function-cast.
12708 (xg_set_toolkit_scroll_bar_thumb): Use it.
12709 (xg_tool_bar_callback, xg_tool_item_stale_p): Rewrite to avoid
12710 diagnostic from gcc -Wbad-function-cast.
12711 (get_utf8_string, xg_get_file_with_chooser):
12712 Rename locals to avoid shadowing.
12713 (create_dialog): Move locals to avoid shadowing.
12715 * xgselect.c (xg_select): Remove unused var.
12717 * image.c (four_corners_best): Mark locals as initialized.
12718 (gif_load): Initialize transparent_p to zero (Bug#8238).
12719 Mark another local as initialized.
12720 (my_png_error, my_error_exit): Mark with NO_RETURN.
12722 * image.c (clear_image_cache): Now static.
12723 (DIM, HAVE_STDLIB_H_1): Remove unused macros.
12724 (xpm_load): Redo to avoid "discards qualifiers" gcc warning.
12725 (x_edge_detection): Remove unnecessary cast that
12726 gcc -Wbad-function-cast diagnoses.
12727 (gif_load): Fix pointer signedness.
12728 (clear_image_cache, xbm_read_bitmap_data, x_detect_edges):
12729 (jpeg_load, gif_load): Rename locals to avoid shadowing.
12731 2011-03-12 Paul Eggert <eggert@cs.ucla.edu>
12733 Improve quality of tests for time stamp overflow.
12734 For example, without this patch (encode-time 0 0 0 1 1
12735 1152921504606846976) returns the obviously-bogus value (-948597
12736 62170) on my RHEL 5.5 x86-64 host. With the patch, it correctly
12737 reports time overflow. See
12738 <http://lists.gnu.org/archive/html/emacs-devel/2011-03/msg00470.html>.
12739 * deps.mk (editfns.o): Depend on ../lib/intprops.h.
12740 * editfns.c: Include limits.h and intprops.h.
12741 (TIME_T_MIN, TIME_T_MAX): New macros.
12742 (time_overflow): Move earlier, to before first use.
12743 (hi_time, lo_time): New functions, for an accurate test for
12744 out-of-range times.
12745 (Fcurrent_time, Fget_internal_run_time, make_time): Use them.
12746 (Fget_internal_run_time): Don't assume time_t fits in int.
12747 (make_time): Use list2 instead of Fcons twice.
12748 (Fdecode_time): More accurate test for out-of-range times.
12749 (check_tm_member): New function.
12750 (Fencode_time): Use it, to test for out-of-range times.
12751 (lisp_time_argument): Don't rely on undefined left-shift and
12752 right-shift behavior when checking for time stamp overflow.
12754 * editfns.c (time_overflow): New function, refactoring common code.
12755 (Fformat_time_string, Fdecode_time, Fencode_time):
12756 (Fcurrent_time_string): Use it.
12758 Move 'make_time' to be next to its inverse 'lisp_time_argument'.
12759 * dired.c (make_time): Move to ...
12760 * editfns.c (make_time): ... here.
12761 * systime.h: Note the move.
12763 2011-03-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
12765 * fringe.c (update_window_fringes): Remove unused variables.
12767 * unexmacosx.c (copy_data_segment): Also copy __got section.
12770 2011-03-12 Eli Zaretskii <eliz@gnu.org>
12772 * termcap.c [MSDOS]: Include "msdos.h".
12773 (find_capability, tgetnum, tgetflag, tgetstr, tputs, tgetent):
12774 Constify `char *' arguments and their references according to
12775 prototypes in tparam.h.
12777 * deps.mk (termcap.o): Depend on tparam.h and msdos.h.
12779 * msdos.c (XMenuAddPane): 3rd argument is `const char *' now.
12780 Adapt all references accordingly.
12782 * msdos.h (XMenuAddPane): 3rd argument is `const char *' now.
12784 2011-03-11 Tom Tromey <tromey@redhat.com>
12786 * buffer.c (syms_of_buffer): Remove obsolete comment.
12788 2011-03-11 Eli Zaretskii <eliz@gnu.org>
12790 * termhooks.h (encode_terminal_code): Declare prototype.
12792 * msdos.c (encode_terminal_code): Don't declare prototype.
12794 * term.c (encode_terminal_code): Now external again, used by
12795 w32console.c and msdos.c.
12797 * makefile.w32-in ($(BLD)/term.$(O), ($(BLD)/tparam.$(O)):
12798 Depend on $(SRC)/tparam.h, see 2011-03-11T07:24:21Z!eggert@cs.ucla.edu.
12800 2011-03-11 Paul Eggert <eggert@cs.ucla.edu>
12802 Fix some minor problems found by GCC 4.5.2's static checks.
12804 * fringe.c (update_window_fringes): Mark locals as initialized
12806 (destroy_fringe_bitmap, init_fringe_bitmap): Now static.
12808 * alloc.c (mark_fringe_data): Move decl from here ...
12809 * lisp.h (mark_fringe_data) [HAVE_WINDOW_SYSTEM]: ... to here,
12810 to check its interface.
12811 (init_fringe_once): Do not declare unless HAVE_WINDOW_SYSTEM.
12813 * fontset.c (free_realized_fontset): Now static.
12814 (Fset_fontset_font): Rename local to avoid shadowing.
12815 (fontset_font): Mark local as initialized.
12816 (FONTSET_SPEC, FONTSET_REPERTORY, RFONT_DEF_REPERTORY): Remove; unused.
12818 * xrdb.c: Include "xterm.h", to check x_load_resources's interface.
12820 * xselect.c (x_disown_buffer_selections): Remove; not used.
12821 (TRACE3) [!defined TRACE_SELECTION]: Remove; not used.
12822 (x_own_selection, Fx_disown_selection_internal): Rename locals
12823 to avoid shadowing.
12824 (x_handle_dnd_message): Remove local to avoid shadowing.
12826 * lisp.h (GCPRO1_VAR, UNGCPRO_VAR): New macros,
12827 so that the caller can use some name other than gcpro1.
12828 (GCPRO1, UNGCPRO): Reimplement in terms of the new macros.
12829 * xfns.c (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
12830 (Fx_backspace_delete_keys_p):
12831 Use them to avoid shadowing, and rename vars to avoid shadowing.
12832 (x_decode_color, x_set_name, x_window): Now static.
12833 (Fx_create_frame): Add braces to silence GCC warning.
12834 (Fx_file_dialog, Fx_select_font): Fix pointer signedness.
12835 (x_real_positions, xg_set_icon_from_xpm_data, x_create_tip_frame):
12836 Remove unused locals.
12837 (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
12838 (Fx_backspace_delete_keys_p): Rename locals to avoid shadowing.
12839 Some of these renamings use the new GCPRO1_VAR and UNGCPRO_VAR
12842 * xterm.h (x_mouse_leave): New decl.
12844 * xterm.c (x_copy_dpy_color, x_focus_on_frame, x_unfocus_frame):
12845 Remove unused functions.
12846 (x_shift_glyphs_for_insert, XTflash, XTring_bell):
12847 (x_calc_absolute_position): Now static.
12848 (XTread_socket): Don't define label "out" unless it's used.
12849 Don't declare local "event" unless it's used.
12850 (x_iconify_frame, x_free_frame_resources): Don't declare locals
12851 unless they are used.
12852 (XEMBED_VERSION, xembed_set_info): Don't define unless needed.
12853 (x_fatal_error_signal): Remove; not used.
12854 (x_draw_image_foreground, redo_mouse_highlight, XTmouse_position):
12855 (x_scroll_bar_report_motion, handle_one_xevent, x_draw_bar_cursor):
12856 (x_error_catcher, x_connection_closed, x_error_handler):
12857 (x_error_quitter, xembed_send_message, x_iconify_frame):
12858 (my_log_handler): Rename locals to avoid shadowing.
12859 (x_delete_glyphs, x_ins_del_lines): Mark with NO_RETURN.
12860 (x_connection_closed): Tell GCC not to suggest NO_RETURN.
12862 * xfaces.c (clear_face_cache, Fx_list_fonts, Fface_font):
12863 Rename or move locals to avoid shadowing.
12864 (tty_defined_color, merge_face_heights): Now static.
12865 (free_realized_faces_for_fontset): Remove; not used.
12866 (Fx_list_fonts): Mark variable that gcc -Wuninitialized
12867 does not deduce is never used uninitialized.
12868 (STRDUPA, LSTRDUPA, FONT_POINT_SIZE_QUANTUM): Remove; not used.
12869 (LFACEP): Define only if XASSERTS, as it's not needed otherwise.
12871 * terminal.c (store_terminal_param): Now static.
12873 * xmenu.c (menu_highlight_callback): Now static.
12874 (set_frame_menubar): Remove unused local.
12875 (xmenu_show): Rename parameter to avoid shadowing.
12876 (xmenu_show, xdialog_show, xmenu_show): Make local pointers "const"
12877 since they might point to immutable storage.
12878 (next_menubar_widget_id): Declare only if USE_X_TOOLKIT,
12879 since it's unused otherwise.
12881 * xdisp.c (produce_glyphless_glyph): Initialize lower_xoff.
12882 Add a FIXME, since the code still doesn't look right. (Bug#8215)
12883 (Fcurrent_bidi_paragraph_direction): Simplify slightly; this
12884 avoids a gcc -Wuninitialized diagnostic.
12885 (display_line, BUILD_COMPOSITE_GLYPH_STRING, draw_glyphs):
12886 (note_mouse_highlight): Mark variables that gcc -Wuninitialized
12887 does not deduce are never used uninitialized.
12889 * lisp.h (IF_LINT): New macro, copied from ../lib-src/emacsclient.c.
12891 * xdisp.c (redisplay_window): Rename local to avoid shadowing.
12892 * window.c (window_loop, size_window):
12893 (run_window_configuration_change_hook, enlarge_window): Likewise.
12895 * window.c (display_buffer): Now static.
12896 (size_window): Mark variables that gcc -Wuninitialized
12897 does not deduce are never used uninitialized.
12898 * window.h (check_all_windows): New decl, to forestall
12899 gcc -Wmissing-prototypes diagnostic.
12900 * dispextern.h (bidi_dump_cached_states): Likewise.
12902 * charset.h (CHECK_CHARSET_GET_CHARSET): Rename locals to avoid
12904 * charset.c (map_charset_for_dump, Fchar_charset): Likewise.
12905 Include <limits.h>.
12906 (Fsort_charsets): Redo min/max calculation to shorten the code a bit
12907 and to avoid gcc -Wuninitialized warning.
12908 (load_charset_map): Mark variables that gcc -Wuninitialized
12909 does not deduce are never used uninitialized.
12910 (load_charset): Abort instead of using uninitialized var (Bug#8229).
12912 * coding.c (coding_set_source, coding_set_destination):
12913 Use "else { /* comment */ }" rather than "else /* comment */;"
12914 for clarity, and to avoid gcc -Wempty-body warning.
12915 (Fdefine_coding_system_internal): Don't redeclare 'i' inside
12916 a block, when the outer 'i' will do.
12917 (decode_coding_utf_8, decode_coding_utf_16, detect_coding_emacs_mule):
12918 (emacs_mule_char, decode_coding_emacs_mule, detect_coding_iso_2022):
12919 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5):
12920 (decode_coding_raw_text, decode_coding_charset, get_translation_table):
12921 (Fdecode_sjis_char, Fdefine_coding_system_internal):
12922 Rename locals to avoid shadowing.
12923 * character.h (FETCH_STRING_CHAR_ADVANCE): Likewise.
12924 * coding.c (emacs_mule_char, encode_invocation_designation):
12925 Now static, since they're not used elsewhere.
12926 (decode_coding_iso_2022): Add "default: abort ();" as a safety check.
12927 (decode_coding_object, encode_coding_object, detect_coding_system):
12928 (decode_coding_emacs_mule): Mark variables that gcc
12929 -Wuninitialized does not deduce are never used uninitialized.
12930 (detect_coding_iso_2022): Initialize a local variable that might
12931 be used uninitialized. Leave a FIXME because it's not clear that
12932 this initialization is needed. (Bug#8211)
12933 (ISO_CODE_LF, ISO_CODE_CR, CODING_ISO_FLAG_EUC_TW_SHIFT):
12934 (ONE_MORE_BYTE_NO_CHECK, UTF_BOM, UTF_16_INVALID_P):
12935 (SHIFT_OUT_OK, ENCODE_CONTROL_SEQUENCE_INTRODUCER):
12936 (ENCODE_DIRECTION_R2L, ENCODE_DIRECTION_L2R):
12937 Remove unused macros.
12939 * category.c (hash_get_category_set): Remove unused local var.
12940 (copy_category_table): Now static, since it's not used elsewhere.
12941 * character.c (string_count_byte8): Likewise.
12943 * ccl.c (CCL_WRITE_STRING, CCL_ENCODE_CHAR, Fccl_execute_on_string):
12944 (Fregister_code_conversion_map): Rename locals to avoid shadowing.
12946 * chartab.c (copy_sub_char_table): Now static, since it's not used
12948 (sub_char_table_ref_and_range, char_table_ref_and_range):
12949 Rename locals to avoid shadowing.
12950 (ASET_RANGE, GET_SUB_CHAR_TABLE): Remove unused macros.
12952 * bidi.c (bidi_check_type): Now static, since it's not used elsewhere.
12953 (BIDI_BOB): Remove unused macro.
12955 * cm.c (cmgoto): Mark variables that gcc -Wuninitialized does not
12956 deduce are never used uninitialized.
12957 * term.c (encode_terminal_code): Likewise.
12959 * term.c (encode_terminal_code): Now static. Remove unused local.
12961 * tparam.h: New file.
12962 * term.c, tparam.h: Include it.
12963 * deps.mk (term.o, tparam.o): Depend on tparam.h.
12964 * term.c (tputs, tgetent, tgetflag, tgetnum, tparam, tgetstr):
12965 Move these decls to tparam.h, and make them agree with what
12966 is actually in tparam.c. The previous trick of using incompatible
12967 decls in different modules does not conform to the C standard.
12968 All callers of tparam changed to use tparam's actual API.
12969 * tparam.c (tparam1, tparam, tgoto):
12970 Use const pointers where appropriate.
12972 * cm.c (calccost, cmgoto): Use const pointers where appropriate.
12973 * cm.h (struct cm): Likewise.
12974 * dispextern.h (do_line_insertion_deletion_costs): Likewise.
12975 * scroll.c (ins_del_costs, do_line_insertion_deletion_costs): Likewise.
12976 * term.c (tty_ins_del_lines, calculate_costs, struct fkey_table):
12977 (term_get_fkeys_1, append_glyphless_glyph, produce_glyphless_glyph):
12978 (turn_on_face, init_tty): Likewise.
12979 * termchar.h (struct tty_display_info): Likewise.
12981 * term.c (term_mouse_position): Rename local to avoid shadowing.
12983 * alloc.c (mark_ttys): Move decl from here ...
12984 * lisp.h (mark_ttys): ... to here, so that it's checked against defn.
12986 2011-03-11 Andreas Schwab <schwab@linux-m68k.org>
12988 * .gdbinit (pwinx, xbuffer): Fix access to buffer name.
12990 2011-03-09 Juanma Barranquero <lekktu@gmail.com>
12992 * search.c (compile_pattern_1): Remove argument regp, unused since
12993 revid:rms@gnu.org-19941211082627-3x1g1wyqkjmwloig.
12994 (compile_pattern): Don't pass it.
12996 2011-03-08 Jan Djärv <jan.h.d@swipnet.se>
12998 * xterm.h (DEFAULT_GDK_DISPLAY): New define.
12999 (GDK_WINDOW_XID, gtk_widget_get_preferred_size): New defines
13001 (GTK_WIDGET_TO_X_WIN): Use GDK_WINDOW_XID.
13003 * xmenu.c (menu_position_func): Call gtk_widget_get_preferred_size.
13005 * gtkutil.c: Include gtkx.h if HAVE_GTK3. If ! HAVE_GTK3, define
13006 gdk_window_get_screen, gdk_window_get_geometry,
13007 gdk_x11_window_lookup_for_display and GDK_KEY_g.
13008 (xg_set_screen): Use DEFAULT_GDK_DISPLAY.
13009 (xg_get_pixbuf_from_pixmap): New function.
13010 (xg_get_pixbuf_from_pix_and_mask): Change parameters from GdkPixmap
13011 to Pixmap, take frame as parameter, remove GdkColormap parameter.
13012 Call xg_get_pixbuf_from_pixmap instead of
13013 gdk_pixbuf_get_from_drawable.
13014 (xg_get_image_for_pixmap): Do not make GdkPixmaps, call
13015 xg_get_pixbuf_from_pix_and_mask with Pixmap parameters instead.
13016 (xg_check_special_colors): Use GtkStyleContext and its functions
13018 (xg_prepare_tooltip, xg_hide_tooltip): Call gdk_window_get_screen.
13019 (xg_prepare_tooltip, create_dialog, menubar_map_cb)
13020 (xg_update_frame_menubar, xg_tool_bar_detach_callback)
13021 (xg_tool_bar_attach_callback, xg_update_tool_bar_sizes):
13022 Call gtk_widget_get_preferred_size.
13023 (xg_frame_resized): gdk_window_get_geometry only takes 5
13025 (xg_win_to_widget, xg_event_is_for_menubar):
13026 Call gdk_x11_window_lookup_for_display.
13027 (xg_set_widget_bg): New function.
13028 (delete_cb): New function.
13029 (xg_create_frame_widgets): Connect delete-event to delete_cb.
13030 Call xg_set_widget_bg. Only set background pixmap for ! HAVE_GTK3
13031 (xg_set_background_color): Call xg_set_widget_bg.
13032 (xg_set_frame_icon): Call xg_get_pixbuf_from_pix_and_mask.
13033 (xg_create_scroll_bar): vadj is a GtkAdjustment for HAVE_GTK3.
13034 Only call gtk_range_set_update_policy if ! HAVE_GTK3.
13035 (xg_make_tool_item): Only connect xg_tool_bar_item_expose_callback
13037 (update_frame_tool_bar): Call gtk_widget_hide.
13038 (xg_initialize): Use GDK_KEY_g.
13040 * xsmfns.c (gdk_set_sm_client_id): Define to gdk_set_sm_client_id
13042 (x_session_initialize): Call gdk_x11_set_sm_client_id.
13044 * xterm.c (XFillRectangle): Use cairo routines for HAVE_GTK3.
13045 (x_term_init): Disable Xinput(2) with GDK_CORE_DEVICE_EVENTS.
13046 Load ~/emacs.d/gtkrc only for ! HAVE_GTK3.
13048 2011-03-08 Juanma Barranquero <lekktu@gmail.com>
13050 * w32xfns.c (select_palette): Check success of RealizePalette against
13051 GDI_ERROR, not zero.
13053 See ChangeLog.11 for earlier changes.
13055 ;; Local Variables:
13059 Copyright (C) 2011-2012 Free Software Foundation, Inc.
13061 This file is part of GNU Emacs.
13063 GNU Emacs is free software: you can redistribute it and/or modify
13064 it under the terms of the GNU General Public License as published by
13065 the Free Software Foundation, either version 3 of the License, or
13066 (at your option) any later version.
13068 GNU Emacs is distributed in the hope that it will be useful,
13069 but WITHOUT ANY WARRANTY; without even the implied warranty of
13070 MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
13071 GNU General Public License for more details.
13073 You should have received a copy of the GNU General Public License
13074 along with GNU Emacs. If not, see <http://www.gnu.org/licenses/>.