1 2012-07-31 Dmitry Antipov <dmantipov@yandex.ru>
3 Miscellaneous fixes for non-default X toolkits.
4 * xfns.c (Fx_file_dialog): Change to SSDATA to avoid warnings.
5 * xterm.c (x_frame_of_widget): Remove redundant prototype.
6 Move under #ifdef USE_LUCID.
7 (x_create_toolkit_scroll_bar): Adjust scroll_bar_name
8 definition and usage to avoid warnings.
10 2012-07-31 Jan Djärv <jan.h.d@swipnet.se>
12 * nsterm.m (openFiles): Fix previous checkin.
14 2012-07-31 Paul Eggert <eggert@cs.ucla.edu>
16 * indent.c (compute_motion): Remove unused local.
18 2012-07-31 Glenn Morris <rgm@gnu.org>
20 * s/usg5-4-common.h (wait3, WRETCODE): Let configure set them.
22 * conf_post.h [USG5_4]:
23 Move remaining contents of s/usg5-4-common.h here.
24 * s/usg5-4-common.h: Remove file.
26 * conf_post.h [IRIX6_5]: Move remaining contents of s/irix6-5.h here.
27 * s/irix6-5.h: Remove file.
29 * conf_post.h [DARWIN_OS]: Move remaining contents of s/darwin.h here.
30 * s/darwin.h: Remove file.
32 * conf_post.h [HPUX]: Move random, srandom here from s/hpux10-20.h.
33 * s/hpux10-20.h: Remove file, which is now empty.
35 2012-07-30 Glenn Morris <rgm@gnu.org>
37 * conf_post.h: New, split from configure.ac's AH_BOTTOM.
38 * Makefile.in (config_h): Add conf_post.h.
39 * makefile.w32-in (CONFIG_H): Add conf_post.h.
41 2012-07-30 Jan Djärv <jan.h.d@swipnet.se>
43 * nsterm.m (ns_do_open_file): New variable.
44 (ns_term_init): Set ns_do_open_file to YES after run returns.
45 (openFile, openTempFile, openFileWithoutUI, openFiles): Open
46 files only if ns_do_open_file.
48 2012-07-30 Paul Eggert <eggert@cs.ucla.edu>
50 * lisp.h (SWITCH_ENUM_CAST): Remove. All uses removed.
51 This no-op macro hasn't been needed for many years.
52 * src/regex.c (SWITCH_ENUM_CAST) [!emacs]: Likewise.
54 Export DIRECTORY_SEP, TYPEMASK, VALMASK to GDB.
55 * alloc.c (gdb_make_enums_visible) [USE_LSB_TAG]: Add lsb_bits.
56 * lisp.h (enum lsb_bits) [USE_LSB_TAG]: New enum, for
57 gdb_make_enums_visible.
58 (TYPEMASK, VALMASK) [USE_LSB_TAGS]: Now enum constants, not macros.
59 (DIRECTORY_SEP): Now a constant, not a macro.
61 2012-07-30 Eli Zaretskii <eliz@gnu.org>
63 * w32fns.c (w32_wnd_proc): Pass w32_keyboard_codepage to
64 w32_kbd_patch_key as the 2nd arg. (Bug#12082)
66 * w32term.c <w32_keyboard_codepage>: Renamed from
67 keyboard_codepage and now external. All users changed.
69 * w32term.h: Add declaration of w32_keyboard_codepage.
71 * w32inevt.c (w32_kbd_patch_key): Accept an additional argument --
72 the codepage to translate keys to Unicode. If this argument is
73 -1, use the value returned by GetConsoleCP. All callers changed.
75 2012-07-30 Paul Eggert <eggert@cs.ucla.edu>
77 Update .PHONY listings in makefiles.
78 * Makefile.in (.PHONY): Add all, mostlyclean, clean,
79 bootstrap-clean, distclean, maintainer-clean, versioclean,
82 * lisp.h (STRING_BYTES_BOUND): Cast entire result to ptrdiff_t.
83 This is a bit clearer. Fix some commentary typos.
85 2012-07-30 Glenn Morris <rgm@gnu.org>
87 * s/netbsd.h: Let configure include signal.h if needed.
88 Remove file, which is now empty.
90 * s/usg5-4-common.h (_longjmp, _setjmp, TIOCSIGSEND):
91 Let configure set them.
92 * s/irix6-5.h (_longjmp, _setjmp, TIOCSIGSEND):
93 No more need to undefine.
95 2012-07-30 Andreas Schwab <schwab@linux-m68k.org>
97 * keymap.c (Fkey_description): Don't remove 0x80 bit from
98 non-single-byte char when adding meta modifier. (Bug#12090)
100 2012-07-30 Dmitry Antipov <dmantipov@yandex.ru>
102 Convert safe_call to use variable number of arguments.
103 * xdisp.c (safe_call): Convert to use varargs. Adjust users.
104 (safe_call2): Fix comment.
105 * lisp.h (safe_call): Adjust prototype.
106 * coding.c (encode_coding_object): Change to use safe_call2.
107 * xfaces.c (merge_face_heights): Change to use safe_call1.
109 2012-07-30 Glenn Morris <rgm@gnu.org>
111 * s/aix4-2.h (sigmask): No need to undefine it, since syssignal.h
112 does that unconditionally. Remove file, which is now empty.
114 * s/freebsd.h, s/gnu-linux.h, s/sol2-6.h, s/unixware.h:
117 2012-07-30 Paul Eggert <eggert@cs.ucla.edu>
119 Export to GDB most of lisp.h's remaining object-like macros.
120 * lisp.h (min, max): Move earlier, because they're used earlier now.
121 (INTMASK, ARRAY_MARK_FLAG, PSEUDOVECTOR_FLAG, VALMASK)
122 (CHAR_TABLE_STANDARD_SLOTS, CHARTAB_SIZE_BITS_0)
123 (CHARTAB_SIZE_BITS_1, CHARTAB_SIZE_BITS_2, CHARTAB_SIZE_BITS_3)
124 (DEFAULT_HASH_SIZE, COMPILED_ARGLIST, COMPILED_BYTECODE)
125 (COMPILED_CONSTANTS, COMPILED_STACK_DEPTH, COMPILED_DOC_STRING)
126 (COMPILED_INTERACTIVE, CHAR_ALT, CHAR_SUPER, CHAR_HYPER, CHAR_SHIFT)
127 (CHAR_CTL, CHAR_META, CHAR_MODIFIER_MASK, CHARACTERBITS)
128 (MANY, UNEVALLED, FLOAT_TO_STRING_BUFSIZE, MAX_ALLOCA):
129 Now constants, for GDB. They need not be macros.
130 (MOST_POSITIVE_FIXNUM, MOST_NEGATIVE_FIXNUM, STRING_BYTES_BOUND):
131 Now constants, for GDB, as well as macros, for static initializers.
132 (CHAR_TABLE_STANDARD_SLOTS, CHAR_TABLE_EXTRA_SLOTS):
133 Move to after the definition of struct Lisp_Char_Table,
134 since the former now needs that type defined.
135 (enum CHARTAB_SIZE_BITS, enum CHAR_TABLE_STANDARD_SLOTS)
136 (enum DEFAULT_HASH_SIZE, enum Lisp_Compiled, enum char_bits)
137 (enum maxargs, enum FLOAT_TO_STRING_BUFSIZE, enum MAX_ALLOCA):
138 New enums, for gdb_make_enums_visible.
139 (GLYPH_MODE_LINE_FACE): Remove; unused.
140 * alloc.c (STRING_BYTES_MAX): Now a constant, not a macro.
141 (gdb_make_enums_visible): Add enum CHARTAB_SIZE_BITS, enum
142 CHAR_TABLE_STANDARD_SLOTS, enum char_bits, enum DEFAULT_HASH_SIZE,
143 enum FLOAT_TO_STRING_BUFSIZE, enum Lisp_Bits, enum Lisp_Compiled,
144 enum maxargs, enum MAX_ALLOCA.
145 (ARRAY_MARK_FLAG_VAL, PSEUDOVECTOR_FLAG_VAL, VALMASK_VAL): Remove.
146 (ARRAY_MARK_FLAG, PSEUDOVECTOR_FLAG, VALMASK): Remove;
147 no longer needed, now that they are done in lisp.h.
149 2012-07-30 Dmitry Antipov <dmantipov@yandex.ru>
151 Cleanup string bytes checking.
152 * alloc.c (GC_STRING_BYTES, CHECK_STRING_BYTES): Remove. Convert
153 all users to STRING_BYTES or string_bytes if GC_CHECK_STRING_BYTES.
154 (check_string_bytes): Define to empty if not GC_CHECK_STRING_BYTES.
155 (check_sblock, compact_small_strings): Simplify.
157 2012-07-29 Paul Eggert <eggert@cs.ucla.edu>
159 * lisp.h (LISP_INT_TAG, LISP_INT1_TAG, LISP_STRING_TAG): Remove.
160 These macros are confusing and no longer need to be defined, as
161 the enum values now suffice. All uses replaced with definiens.
162 (Lisp_Int1, Lisp_String): Define directly; this is clearer.
164 2012-07-29 Juanma Barranquero <lekktu@gmail.com>
166 * makefile.w32-in (LISP_H, $(BLD)/emacs.$(O), $(BLD)/w32inevt.$(O))
167 ($(BLD)/w32console.$(O)): Update dependencies.
169 2012-07-29 Dmitry Antipov <dmantipov@yandex.ru>
171 Remove HIDE_LISP_IMPLEMENTATION and cleanup cons free list check.
172 * lisp.h (HIDE_LISP_IMPLEMENTATION): Remove as useless for a long
174 (CHECK_CONS_LIST): Remove. Convert all users to check_cons_list.
176 2012-07-29 Jan Djärv <jan.h.d@swipnet.se>
178 * lread.c (init_lread): Remove if-statement in ifdef HAVE_NS before
179 setting sitelisp (Bug#12010).
181 2012-07-29 Eli Zaretskii <eliz@gnu.org>
183 * w32heap.h (OS_9X): Renamed from OS_WINDOWS_95.
185 * w32heap.c (cache_system_info):
186 * w32.c (sys_rename):
187 * w32proc.c (find_child_console, sys_kill): All users changed.
189 2012-07-29 Paul Eggert <eggert@cs.ucla.edu>
191 * alloc.c (Fgarbage_collect): Indent as per usual Emacs style.
193 2012-07-29 Eli Zaretskii <eliz@gnu.org>
195 * makefile.w32-in (LISP_H): Add $(NT_INC)/stdalign.h.
197 2012-07-29 Dmitry Antipov <dmantipov@yandex.ru>
199 Cleanup statistics calculation in Fgarbage_collect.
200 * alloc.c (Fgarbage_collect): Rename t1 to meaningful start. Fix
201 zombies percentage calculation. Simplify elapsed time calculation.
203 2012-07-29 Dmitry Antipov <dmantipov@yandex.ru>
205 Generalize marker debugging code under MARKER_DEBUG and use eassert.
206 * insdel.c (CHECK_MARKERS, check_markers_debug_flag): Remove.
207 (gap_left, gap_right, adjust_markers_for_delete, insert_1_both)
208 (insert_from_string_1, insert_from_gap, insert_from_buffer_1)
209 (replace_range, replace_range_2, del_range_2): Change to eassert.
210 * marker.c (byte_char_debug_check): Adjust style.
212 2012-07-29 Paul Eggert <eggert@cs.ucla.edu>
214 Don't use the abbreviation "win" to refer to Windows (Bug#10421).
215 * regex.c (MAX_BUF_SIZE): Remove some incorrect and
216 long-ago-commented-out code that talks about "WIN32".
217 * w32heap.h (OS_WINDOWS_95): Rename from OS_WIN95.
220 2012-07-28 Paul Eggert <eggert@cs.ucla.edu>
222 Use Gnulib stdalign module (Bug#9772, Bug#9960).
223 * alloc.c (XMALLOC_BASE_ALIGNMENT, GC_POINTER_ALIGNMENT, pure_alloc):
224 Simplify by using alignof.
225 (pure_alloc) [! USE_LSB_TAG]: Don't over-align EMACS_INT values.
226 * lisp.h: Include <stdalign.h>.
227 (GCALIGNMENT): New macro and constant.
228 (DECL_ALIGN): Remove. All uses replaced by alignas (GCALIGNMENT).
229 (USE_LSB_TAG): ifdef on alignas, not on DECL_ALIGN.
230 (stdalign): New macro, if not already defined.
232 2012-07-28 Eli Zaretskii <eliz@gnu.org>
234 Fix non-ASCII input in non-GUI frames on MS-Windows. (Bug#12055)
235 * w32inevt.c: Include w32inevt.h.
236 (w32_read_console_input): New inline function, calls either
237 ReadConsoleInputA or ReadConsoleInputW, depending on the value of
238 w32_console_unicode_input.
239 (fill_queue): Call w32_read_console_input instead of ReadConsoleInput.
240 (w32_kbd_patch_key, key_event): Use the codepage returned by
241 GetConsoleCP, rather than the ANSI codepage returned by GetLocaleInfo.
242 (key_event): use uChar.UnicodeChar only if
243 w32_console_unicode_input is non-zero.
245 * w32console.c: Include w32heap.h.
246 <w32_console_unicode_input>: New global variable.
247 (initialize_w32_display): Set w32_console_unicode_input to 1 on NT
248 family of Windows, zero otherwise.
250 * w32inevt.h: Declare w32_console_unicode_input.
252 * xdisp.c (init_iterator): Don't reference tip_frame in a build
253 --without-x. (Bug#11742)
255 2012-07-27 Paul Eggert <eggert@cs.ucla.edu>
257 Adjust GDB to reflect pvec_type changes (Bug#12036).
258 * .gdbinit (xvectype, xpr, xbacktrace): Adjust to reflect the
259 2012-07-04 changes to pseudovector representation. Problem
260 reported by Eli Zaretskii in <http://bugs.gnu.org/12036#30>.
262 2012-07-27 Michael Albinus <michael.albinus@gmx.de>
264 * dbusbind.c (XD_DBUS_VALIDATE_BUS_ADDRESS): Canonicalize session
266 (xd_close_bus, Fdbus_init_bus): Handle reference counter properly.
268 2012-07-27 Eli Zaretskii <eliz@gnu.org>
270 * alloc.c (listn): Fix the order the arguments are consed onto the
273 * lisp.h (enum constype): Use CONSTYPE_HEAP and CONSTYPE_PURE for
274 enumeration constants, as PURE and HEAP are too general, and clash
275 with other headers and sources, such as gmalloc.c and the
276 MS-Windows system headers. All users changed.
278 2012-07-27 Dmitry Antipov <dmantipov@yandex.ru>
280 Revert last save_excursion_save and save_excursion_restore changes.
281 * alloc.c, editfns.c, marker.c, lisp.h: Revert.
282 Lots of crashes reported by Chong Yidong <cyd@gnu.org>.
284 2012-07-27 Dmitry Antipov <dmantipov@yandex.ru>
286 Fix recently-introduced typos in Windows port.
287 Reported by Martin Rudalics <rudalics@gmx.at>.
288 * w32.c (init_environment): Replace comma with semicolon.
289 * w32fns.c (syms_of_w32fns): Add missing parenthesis.
291 2012-07-27 Paul Eggert <eggert@cs.ucla.edu>
293 Improve GDB symbol export (Bug#12036).
294 * .gdbinit (xgetptr, xgetint, xgettype): Set $bugfix in different
295 arms of an 'if', not using conditional expressions; otherwise GDB
296 complains about the types in the unevaluated arm when the argument
297 is an integer literal.
298 (xgetint): Simplify expression.
299 * alloc.c (gdb_make_enums_visible): New constant. This ports to
300 GCC 3.4.2 the export of symbols to GDB. Problem reported by Eli
301 Zaretskii in <http://bugs.gnu.org/12036#13>.
302 * lisp.h (PUBLISH_TO_GDB): Remove. All uses removed. No longer
303 needed now that we have gdb_make_enums_visible.
304 (enum CHECK_LISP_OBJECT_TYPE, enum Lisp_Bits, enum More_Lisp_Bits)
305 (enum enum_USE_LSB_TAG):
306 New enum types, packaging up enums that need to be exported to GDB.
308 2012-07-27 Dmitry Antipov <dmantipov@yandex.ru>
310 Utility function to make a list from specified amount of objects.
311 * lisp.h (enum constype): New datatype.
312 (listn): New prototype.
313 * alloc.c (listn): New function.
314 (Fmemory_use_count, syms_of_alloc): Use it.
315 * buffer.c (syms_of_buffer): Likewise.
316 * callint.c (syms_of_callint): Likewise.
317 * charset.c (define_charset_internal): Likewise.
318 * coding.c (syms_of_coding): Likewise.
319 * keymap.c (syms_of_keymap): Likewise.
320 * search.c (syms_of_search): Likewise.
321 * syntax.c (syms_of_syntax): Likewise.
322 * w32.c (init_environment): Likewise.
323 * w32fns.c (Fw32_battery_status, syms_of_w32fns): Likewise.
324 * xdisp.c (syms_of_xdisp): Likewise.
325 * xfns.c (syms_of_xfns): Likewise.
327 2012-07-27 Dmitry Antipov <dmantipov@yandex.ru>
329 Fast save_excursion_save and save_excursion_restore.
330 * lisp.h (struct Lisp_Excursion): New data type.
331 (PVEC_EXCURSION): New pseudovector type.
332 (XEXCURSION, XSETEXCURSION, EXCURSIONP): Convenient macros
333 to deal with it. Adjust comments.
334 (init_marker, attach_marker): New prototype.
335 (unchain_marker): Adjust prototype.
336 * marker.c (attach_marker): Change to global.
337 (init_marker): New function.
338 * alloc.c (Fmake_marker, build_marker): Use it.
339 (build_marker): More easserts.
340 (mark_object): Handle struct Lisp_Excursion.
341 * editfns.c (save_excursion_save, save_excursion_restore):
342 Reimplement to use struct Lisp_Excursion. Add comments.
344 2012-07-26 Paul Eggert <eggert@cs.ucla.edu>
346 Fix export of symbols to GDB (Bug#12036).
347 * alloc.c (ARRAY_MARK_FLAG_VAL, PSEUDOVECTOR_FLAG_VAL, VALMASK_VAL)
348 (ARRAY_MARK_FLAG, PSEUDOVECTOR_FLAG, VALMASK): Move these here from
349 emacs.c, as this is a more-suitable home. Had this been done earlier
350 the fix for 12036 would have avoided some of the problems noted in
351 <http://bugs.gnu.org/12036#13> by Eli Zaretskii, as the scope problems
352 would have been more obvious.
353 * emacs.c: Do not include <verify.h>; no longer needed.
354 (gdb_CHECK_LISP_OBJECT_TYPE, gdb_DATA_SEG_BITS)
355 (gdb_GCTYPEBITS, gdb_USE_LSB_TAG)
356 (CHECK_LISP_OBJECT_TYPE, DATA_SEG_BITS, GCTYPEBITS, USE_LSB_TAG):
357 Remove; now done in lisp.h.
358 * lisp.h (PUBLISH_TO_GDB): New macro.
359 (GCTYPEBITS, USE_LSB_TAG, CHECK_LISP_OBJECT_TYPE, enum pvec_type)
360 (DATA_SEG_BITS): Use it.
361 (GCTYPEBITS, USE_LSB_TAG): Now also an enum, for GDB.
362 (CHECK_LISP_OBJECT_TYPE, DATA_SEG_BITS): Now just an enum, for GDB.
363 * mem-limits.h (EXCEEDS_LISP_PTR): Redo so that DATA_SEG_BITS need
364 not be usable in #if. This simplifies things.
366 2012-07-26 Juanma Barranquero <lekktu@gmail.com>
368 * makefile.w32-in ($(BLD)/emacs.$(O)): Update dependencies.
370 2012-07-26 Paul Eggert <eggert@cs.ucla.edu>
372 Simplify export of symbols to GDB (Bug#12036).
373 * .gdbinit (xgetptr, xgetint, xgettype): Don't use "set $bugfix =
374 $bugfix.i", as this doesn't work (with GDB 7.4.1, anyway).
375 (xgetptr, xgetint, xgettype, xcoding, xcharset, xprintbytestr):
376 Adjust to changes in lisp.h and emacs.c, by using
377 CHECK_LISP_OBJECT_TYPE rather than gdb_use_struct, VALMASK instead
378 of $valmask, DATA_SEG_BITS instead of gdb_data_seg_bits,
379 INTTYPEBITS instead of gdb_gctypebits - 1, USE_LSB_TAG instead of
380 gdb_use_lsb, (1 << GCTYPEBITS) - 1 instead of $tagmask, VALBITS
381 instead of gdb_valbits.
382 (xvectype, xvector, xpr, xprintstr, xbacktrace): Similarly, use
383 PSEUDOVECTOR_FLAG instead of PVEC_FLAG, and ARRAY_MARK_FLAG
384 instead of gdb_array_mark_flag.
385 (xboolvector): Get size from $->size, not $->header.size.
386 Use BOOL_VECTOR_BITS_PER_CHAR rather than mystery constants.
387 (xreload, hook-run, hookpost-run): Remove.
388 * emacs.c: Include <verify.h>.
389 (gdb_use_lsb, gdb_use_struct, gdb_valbits, gdb_gctypebits)
390 (gdb_data_seg_bits, PVEC_FLAG, gdb_array_mark_flag, gdb_pvec_type):
392 (gdb_CHECK_LISP_OBJECT_TYPE, gdb_DATA_SEG_BITS, gdb_GCTYPEBITS)
393 (gdb_USE_LSB_TAG): New enum constants.
394 (CHECK_LISP_OBJECT_TYPE, DATA_SEG_BITS, GCTYPEBITS, USE_LSB_TAG):
395 Also define these as enum constants, so they're visible to GDB.
396 (ARRAY_MARK_FLAG_VAL, PSEUDOVECTOR_FLAG_VAL, VALMASK_VAL): New macros.
397 (ARRAY_MARK_FLAG, PSEUDOVECTOR_FLAG, VALMASK): Also define these
398 as constants, so they're visible to GDB.
399 * lisp.h (VALBITS, INTTYPEBITS, FIXNUM_BITS, PSEUDOVECTOR_SIZE_BITS)
400 (PSEUDOVECTOR_SIZE_MASK, PVEC_TYPE_MASK, BOOL_VECTOR_BITS_PER_CHAR):
401 Now enum constants, not macros, so they're visible to GDB.
402 (CHECK_LISP_OBJECT_TYPE, DATA_SEG_BITS): Default to 0, as this is
403 more convenient now. All uses changed.
404 (VALMASK) [USE_LSB_TAG]: Also define in this case.
405 * mem-limits.h (EXCEEDS_LISP_PTR): Adjust to DATA_SEG_BITS change.
407 2012-07-26 Dmitry Antipov <dmantipov@yandex.ru>
409 Explicitly free restriction data that are not needed anymore.
410 * editfns.c (save_restriction_restore): Free restriction data.
412 2012-07-26 Stefan Monnier <monnier@iro.umontreal.ca>
414 * eval.c (Fautoload_do_load): Rename from do_autoload, export to Lisp,
415 add argument, tune behavior, and adjust all callers.
417 2012-07-25 Paul Eggert <eggert@cs.ucla.edu>
419 Use typedef for EMACS_INT, EMACS_UINT.
420 * lisp.h, s/ms-w32.h (EMACS_INT, EMACS_UINT): Use typedefs rather
421 than macros. This simplifies debugging in the usual case, since
422 it lets GDB show addresses as 'EMACS_INT *' rather than 'long int *'
423 and it allows expressions involving EMACS_INT casts.
424 * .gdbinit (xreload): Simplify by using EMACS_INT cast.
426 2012-07-25 Jan Djärv <jan.h.d@swipnet.se>
428 * nsterm.m (ns_read_socket): Return early if there is a modal
431 2012-07-25 Martin Rudalics <rudalics@gmx.at>
433 * frame.c (Fredirect_frame_focus): In doc-string don't mention
434 that FOCUS-FRAME can be omitted.
436 2012-07-25 Dmitry Antipov <dmantipov@yandex.ru>
438 Adjust buffer text indirection counters at the end of Fkill_buffer.
439 * buffer.c (Fkill_buffer): Adjust indirection counters when the
440 buffer is definitely dead. This should really fix an issue reported
441 by Christoph Scholtes again. (Bug#12007).
442 (init_buffer_once): Initialize indirection counters of
443 buffer_defaults and buffer_local_symbols (for sanity and safety).
445 2012-07-24 Eli Zaretskii <eliz@gnu.org>
447 * xdisp.c (init_iterator): Don't compute dimensions of truncation
448 and continuation glyphs on tooltip frames, leave them at zero.
449 Avoids continued lines in tooltips. (Bug#11832)
451 2012-07-24 Dmitry Antipov <dmantipov@yandex.ru>
453 Simplify copy_overlay.
454 * buffer.c (copy_overlay): Simplify. Use build_marker.
455 * lisp.h (struct Lisp_Overlay): Restore comment with minor tweaks.
457 2012-07-23 Eli Zaretskii <eliz@gnu.org>
459 * print.c (print_object): Don't crash when a frame's name is nil
460 or invalid. (Bug#12025)
462 * window.c (decode_any_window): Disable CHECK_LIVE_FRAME test, as
463 it signals an error when a tooltip frame is being created.
465 2012-07-23 Dmitry Antipov <dmantipov@yandex.ru>
467 Cleanup miscellaneous objects allocation and initialization.
468 * alloc.c (allocate_misc): Change to static. Add argument to
469 specify the subtype. Adjust comment and users.
470 (build_overlay): New function.
471 * buffer.c (copy_overlays, Fmake_overlay): Use it.
472 * lisp.h (struct Lisp_Overlay): Remove obsolete comment.
473 (allocate_misc): Remove prototype.
474 (build_overlay): Add prototype.
476 2012-07-23 Dmitry Antipov <dmantipov@yandex.ru>
478 Swap buffer text indirection counters in Fbuffer_swap_text.
479 * buffer.c (Fbuffer_swap_text): Swap indirections too.
480 This avoids crash reported by Christoph Scholtes at
481 http://lists.gnu.org/archive/html/bug-gnu-emacs/2012-07/msg00785.html.
483 2012-07-22 Jan Djärv <jan.h.d@swipnet.se>
485 * nsmenu.m (Popdown_data): New struct.
486 (pop_down_menu): p->pointer is Popdown_data. Release the pool and
488 (ns_popup_dialog): Use NSAutoreleasePool and pass it to pop_down_menu.
489 (initWithContentRect): Make imgView and contentView non-static
490 and autorelease them. Also autorelease img and matrix (Bug#12005).
491 (dealloc): Remove (Bug#12005).
493 2012-07-22 Dmitry Antipov <dmantipov@yandex.ru>
495 Adjust consing_since_gc when objects are explicitly freed.
496 * alloc.c (GC_DEFAULT_THRESHOLD): New macro.
497 (Fgarbage_collect): Use it. Change minimum to 1/10 of default.
498 (free_cons, free_misc): Subtract object size from consing_since_gc.
500 2012-07-22 Dmitry Antipov <dmantipov@yandex.ru>
502 Simplify and cleanup markers positioning code.
503 * marker.c (attach_marker): More useful eassert.
504 (live_buffer, set_marker_internal): New function.
505 (Fset_marker, set_marker_restricted): Use set_marker_internal.
506 (set_marker_both, set_marker_restricted_both): Use live_buffer.
508 2012-07-22 Paul Eggert <eggert@cs.ucla.edu>
510 * buffer.h (struct buffer.indirections): Now ptrdiff_t, not int,
511 as it's limited by the amount of memory, not by INT_MAX.
513 2012-07-21 Eli Zaretskii <eliz@gnu.org>
515 * keyboard.c (keys_of_keyboard): Bind language-change to 'ignore'
516 in special-event-map. See the discussion at
517 http://lists.gnu.org/archive/html/emacs-devel/2012-06/msg00417.html
520 * w32menu.c (add_menu_item): Cast to ULONG_PTR when assigning
521 info.dwItemData. Fixes crashes on 64-bit Windows. Suggested by
522 Fabrice Popineau <fabrice.popineau@supelec.fr>.
524 2012-07-21 Jan Djärv <jan.h.d@swipnet.se>
526 * nsterm.m (accessibilityAttributeValue): New function. (Bug#11134).
527 (conversationIdentifier): Return value is NSInteger.
528 * nsterm.m (accessibilityAttributeValue): Surround with NS_IMPL_COCOA.
530 2012-07-21 Chong Yidong <cyd@gnu.org>
532 * window.c (decode_any_window): Signal an error if the window is
533 on a dead frame (Bug#11984).
535 2012-07-20 Dmitry Antipov <dmantipov@yandex.ru>
537 Add indirection counting to speed up Fkill_buffer.
538 * buffer.h (struct buffer): New member.
539 * buffer.c (Fget_buffer_create): Set indirection counter to 0.
540 (Fmake_indirect_buffer): Set indirection counter to -1, increment
541 base buffer indirection counter.
542 (compact_buffer): If ENABLE_CHECKING, verify indirection counters.
543 (Fkill_buffer): Adjust indirection counters as needed, don't walk
544 through buffer list if indirection counter is 0.
546 2012-07-20 Dmitry Antipov <dmantipov@yandex.ru>
548 Extend the value returned by Fgarbage_collect with heap statistics.
549 * alloc.c (Qheap): New symbol.
550 (syms_of_alloc): DEFSYM it.
551 (Fgarbage_collect): If DOUG_LEA_MALLOC, add mallinfo data.
552 (Fmemory_free): Remove.
553 (syms_of_alloc): Don't defsubr it.
554 * buffer.c (Fcompact_buffer): Remove.
555 (syms_of_buffer): Don't defsubr it.
557 2012-07-20 Dmitry Antipov <dmantipov@yandex.ru>
559 Make maybe_gc inline.
560 Verify that inlining is always possible (GCC 4.7.1, -O3 -Winline).
561 * lisp.h (consing_since_gc, gc_relative_threshold)
562 (memory_full_cons_threshold): Revert declaration.
563 (maybe_gc): Remove prototype, define as inline.
564 * alloc.c: Remove old commented-out code.
565 (consing_since_gc, gc_relative_threshold)
566 (memory_full_cons_threshold): Revert to global.
569 2012-07-20 Dmitry Antipov <dmantipov@yandex.ru>
571 Simple wrapper for make_unibyte_string, adjust font_open_by_name.
572 * lisp.h (build_unibyte_string): New function.
573 * dosfns.c, fileio.c, fns.c, ftfont.c, process.c:
574 * sysdep.c, w32fns.c, xfns.c: Use it.
575 * font.c (font_open_by_name): Change 2nd and 3rd args to the only arg
576 of type Lisp_Object to avoid redundant calls to make_unibyte_string.
577 Adjust users accordingly.
578 * font.h (font_open_by_name): Adjust prototype.
580 2012-07-20 Dmitry Antipov <dmantipov@yandex.ru>
582 Cleanup calls to Fgarbage_collect.
583 * lisp.h (maybe_gc): New prototype.
584 (consing_since_gc, gc_relative_threshold, memory_full_cons_threshold):
586 * alloc.c (maybe_gc): New function.
587 (consing_since_gc, gc_relative_threshold, memory_full_cons_threshold):
589 * bytecode.c (MAYBE_GC): Use maybe_gc.
590 * eval.c (eval_sub, Ffuncall): Likewise.
591 * keyboard.c (read_char): Likewise. Adjust call to maybe_gc
592 to avoid dependency from auto-save feature.
594 2012-07-19 Paul Eggert <eggert@cs.ucla.edu>
596 * buffer.h (FOR_EACH_BUFFER): Rename from 'for_each_buffer'.
597 (FOR_EACH_PER_BUFFER_OBJECT_AT): Rename from
598 'for_each_per_buffer_object_at'.
599 All uses changed. It's better to use upper-case for macros that
600 cannot be implemented as functions, to give the reader a clue
601 that they're special.
603 2012-07-19 Stefan Monnier <monnier@iro.umontreal.ca>
605 * alloc.c (Fgarbage_collect): Tweak docstring.
607 2012-07-19 Dmitry Antipov <dmantipov@yandex.ru>
609 Tweak the value returned from Fgarbage_collect again.
610 * alloc.c (Fgarbage_collect): New return value, as confirmed in
611 http://lists.gnu.org/archive/html/emacs-devel/2012-07/msg00418.html.
612 Adjust documentation.
613 (total_vector_bytes): Rename to total_vector_slots, adjust
615 (total_free_vector_bytes): Rename to total_free_vector_slots,
617 (Qstring_bytes, Qvector_slots): New symbols.
618 (syms_of_alloc): DEFSYM them.
620 2012-07-19 Dmitry Antipov <dmantipov@yandex.ru>
622 Buffer compaction primitive which may be used from Lisp.
623 * buffer.c (compact_buffer, Fcompact_buffer): New function.
624 (syms_of_buffer): Register Fcompact_buffer.
625 * alloc.c (Fgarbage_collect): Use compact_buffer.
626 * buffer.h (compact_buffer): New prototype.
627 (struct buffer_text): New member.
629 2012-07-19 Dmitry Antipov <dmantipov@yandex.ru>
631 New macro to iterate over all buffers, miscellaneous cleanups.
632 * lisp.h (all_buffers): Remove declaration.
633 * buffer.h (all_buffers): Add declaration, with comment.
634 (for_each_buffer): New macro.
635 * alloc.c (Fgarbage_collect, mark_object): Use it.
636 * buffer.c (Fkill_buffer, Fbuffer_swap_text, Fset_buffer_multibyte)
637 (init_buffer): Likewise.
638 * data.c (Fset_default): Likewise.
639 * coding.c (code_conversion_restore): Remove redundant check
641 * buffer.c (Fkill_buffer): Likewise. Remove obsolete comment.
643 2012-07-18 Andreas Schwab <schwab@linux-m68k.org>
645 Fix bug that created negative-length intervals.
646 * intervals.c (merge_interval_right, merge_interval_left):
647 Do not zero out this interval if it is absorbed by its children,
648 as this interval's total length doesn't change in that case. See
649 <http://lists.gnu.org/archive/html/emacs-devel/2012-07/msg00403.html>.
651 2012-07-18 Paul Eggert <eggert@cs.ucla.edu>
653 * alloc.c (Fmake_bool_vector): Fix off-by-8 bug
654 when invoking (make-bool-vector N t) and N is a positive
655 multiple of 8 -- the last 8 bits were mistakenly cleared.
657 Remove some struct layout assumptions in bool vectors.
658 * alloc.c (bool_header_size): New constant.
659 (header_size, word_size): Move earlier, as they're now used earlier.
660 Use 'word_size' in a few more places, where it's appropriate.
661 (Fmake_bool_vector, sweep_vectors): Don't assume that there is no
662 padding before the data member of a bool vector.
663 (sweep_vectors): Use PSEUDOVECTOR_TYPEP, in an eassert, rather
664 than doing the check by hand with an abort ().
666 2012-07-18 Stefan Monnier <monnier@iro.umontreal.ca>
668 * eval.c (Fdefvar): Don't check constants since we only set the var if
669 it's not yet defined anyway (bug#11904).
671 * lisp.h (last_undo_boundary): Declare new var.
672 * keyboard.c (command_loop_1): Set it.
673 * cmds.c (Fself_insert_command): Use it to only remove boundaries that
674 were auto-added by the command loop (bug#11774).
676 2012-07-18 Andreas Schwab <schwab@linux-m68k.org>
678 * w32font.c (Qsymbol): Remove local definition.
679 (syms_of_w32font): Don't DEFSYM it.
681 2012-07-18 Dmitry Antipov <dmantipov@yandex.ru>
683 Fix sweep_vectors to handle large bool vectors correctly.
684 * alloc.c (sweep_vectors): Account total_vector_bytes for
685 bool vectors larger than VBLOCK_BYTES_MAX.
687 2012-07-18 Chong Yidong <cyd@gnu.org>
689 * frame.c (x_set_frame_parameters): Revert bogus change introduced
690 in 2012-05-25 commit by Paul Eggert (Bug#11738).
692 2012-07-18 Dmitry Antipov <dmantipov@yandex.ru>
694 Return more descriptive data from Fgarbage_collect.
695 Suggested by Stefan Monnier in
696 http://lists.gnu.org/archive/html/emacs-devel/2012-07/msg00369.html.
697 * alloc.c (bounded_number): New function.
698 (total_buffers, total_vectors): New variable.
699 (total_string_size): Rename to total_string_bytes, adjust users.
700 (total_vector_size): Rename to total_vector_bytes, adjust users.
701 (sweep_vectors): Account total_vectors and total_vector_bytes.
702 (Fgarbage_collect): New return value. Adjust documentation.
703 (gc_sweep): Account total_buffers.
704 (Fmemory_free, Fmemory_use_counts): Use bounded_number.
705 (VECTOR_SIZE): Remove.
706 * data.c (Qfloat, Qvector, Qsymbol, Qstring, Qcons): Make global.
707 (Qinterval, Qmisc): New symbols.
708 (syms_of_data): Initialize them.
709 * lisp.h (Qinterval, Qsymbol, Qstring, Qmisc, Qvector, Qfloat)
710 (Qcons, Qbuffer): New declarations.
712 2012-07-17 Paul Eggert <eggert@cs.ucla.edu>
714 * alloc.c (Fmemory_free): Account for memory-free's own storage.
715 Round up, not down. Improve doc.
717 2012-07-17 Dmitry Antipov <dmantipov@yandex.ru>
719 Restore old code in allocate_string_data to avoid Faset breakage.
720 Reported by Julien Danjou <julien@danjou.info> in
721 http://lists.gnu.org/archive/html/emacs-devel/2012-07/msg00371.html.
722 * alloc.c (allocate_string_data): Restore old code with minor
723 adjustments, fix comment to explain this subtle issue.
725 2012-07-17 Eli Zaretskii <eliz@gnu.org>
727 Remove FILE_SYSTEM_CASE.
728 * s/msdos.h (FILE_SYSTEM_CASE): Don't define.
730 * fileio.c (FILE_SYSTEM_CASE): Don't define.
731 (Ffile_name_directory, Fexpand_file_name): Don't use FILE_SYSTEM_CASE.
732 Fixes problems on MS-DOS with Vtemp_file_name_pattern when
733 call-process-region passes it through expand-file-name.
735 * dired.c (file_name_completion): Don't use FILE_SYSTEM_CASE.
737 2012-07-17 Andreas Schwab <schwab@linux-m68k.org>
739 Fix crash when creating indirect buffer (Bug#11917)
740 * buffer.c (buffer_lisp_local_variables): Add argument CLONE.
741 Don't handle unbound variables specially if non-zero.
742 (Fbuffer_local_variables): Pass zero.
743 (clone_per_buffer_values): Pass non-zero.
745 2012-07-17 Andreas Schwab <schwab@linux-m68k.org>
747 * gnutls.c (emacs_gnutls_handshake): Revert last change. Add QUIT
748 to make the loop interruptible.
750 2012-07-17 Andreas Schwab <schwab@linux-m68k.org>
752 * gnutls.c (emacs_gnutls_handshake): Only retry if
753 GNUTLS_E_INTERRUPTED.
755 2012-07-17 Dmitry Antipov <dmantipov@yandex.ru>
757 Cleanup and convert miscellaneous checks to eassert.
758 * alloc.c (mark_interval): Fix comment, partially rephrase
759 old comment from intervals.h (see below).
760 * intervals.c (find_interval, adjust_intervals_for_insertion)
761 (delete_interval, adjust_intervals_for_deletion)
762 (graft_intervals_into_buffer, temp_set_point_both, copy_intervals):
764 (adjust_intervals_for_insertion, make_new_interval):
765 Remove obsolete and unused code.
766 * intervals.h (struct interval): Remove obsolete comment.
767 * textprotp.c (erase_properties): Remove unused code.
768 (Fadd_text_properties, set_text_properties_1, Fremove_text_properties)
769 (Fremove_list_of_text_properties): Convert to eassert.
771 2012-07-17 Chong Yidong <cyd@gnu.org>
773 * editfns.c (Finsert_char): Doc fix.
775 2012-07-17 Dmitry Antipov <dmantipov@yandex.ru>
777 Fix previous change to make Fmemory_free always accurate.
778 * alloc.c (make_interval): Update total_free_intervals.
779 (make_float): Likewise for total_free_floats.
780 (free_cons, Fcons): Likewise for total_free_conses.
781 (SETUP_ON_FREE_LIST, allocate_vector_from_block):
782 Likewise for total_free_vector_bytes.
783 (Fmake_symbol): Likewise for total_free_symbols.
784 (bytes_free): Remove.
786 2012-07-17 Dmitry Antipov <dmantipov@yandex.ru>
788 Simple free memory accounting feature.
789 * alloc.c (bytes_free, total_free_vector_bytes): New variable.
790 (sweep_vectors): Accumulate size of free vectors.
791 (Fgarbage_collect): Setup bytes_free.
792 (Fmemory_free): New function.
793 (syms_of_alloc): Register it.
795 2012-07-17 Dmitry Antipov <dmantipov@yandex.ru>
797 Cleanup overlays checking.
798 * buffer.h (OVERLAY_VALID): Remove as useless synonym of OVERLAYP.
799 * buffer.c (overlay_touches_p, recenter_overlay_lists): Change to
800 eassert and OVERLAYP.
801 (sort_overlays): Change to use OVERLAYP.
803 2012-07-16 René Kyllingstad <Rene@Kyllingstad.com> (tiny change)
805 * editfns.c (Finsert_char): Make it interactive, and make the
806 second arg optional. Copy interactive spec and docstring from
809 2012-07-17 Paul Eggert <eggert@cs.ucla.edu>
811 * floatfns.c (Fabs): Do not wrap fabs inside IN_FLOAT (Bug#11913).
812 Unlike the other wrapped functions, fabs has an unspecified
815 2012-07-16 Jan Djärv <jan.h.d@swipnet.se>
817 * nsterm.m (keyDown): Interpret flags without left/right bits
818 as the left key (Bug#11670).
820 2012-07-16 Dmitry Antipov <dmantipov@yandex.ru>
822 Remove empty and useless init functions.
823 * lisp.h (init_character_once, init_fns, init_image)
824 (init_filelock, init_sound): Remove prototype.
825 * character.c (init_character_once): Remove.
826 * filelock.c (init_filelock): Likewise.
827 * fns.c (init_fns): Likewise.
828 * image.c (init_image): Likewise.
829 * sound.c (init_sound): Likewise.
830 * emacs.c (main): Adjust accordingly.
832 2012-07-16 Dmitry Antipov <dmantipov@yandex.ru>
834 * gtkutil.h: Tiny cleanups.
835 (use_old_gtk_file_dialog): Remove useless declaration.
836 (xg_uses_old_file_dialog): Add suggested const attribute.
838 2012-07-15 Eli Zaretskii <eliz@gnu.org>
840 * bidi.c (MAX_STRONG_CHAR_SEARCH): New macro.
841 (bidi_paragraph_init): Use it to limit search forward for a strong
842 directional character in abnormally large paragraphs full of
843 neutral or weak characters. (Bug#11943)
845 2012-07-15 Stefano Facchini <stefano.facchini@gmail.com> (tiny change)
847 * gtkutil.c (xg_create_tool_bar): Apply "primary-toolbar" style to
848 the toolbar (Bug#9451).
849 (xg_make_tool_item): Give the widget event box a transparent
852 2012-07-15 Dmitry Antipov <dmantipov@yandex.ru>
854 Cleanup basic allocation variables and functions.
855 * alloc.c (ignore_warnings, init_intervals, init_float)
856 (init_cons, init_symbol, init_marker): Remove.
857 (interval_block_index): Initialize to INTERVAL_BLOCK_SIZE.
858 (float_block_index): Initialize to FLOAT_BLOCK_SIZE.
859 (cons_block_index): Initialize to CONS_BLOCK_SIZE.
860 (symbol_block_size): Initialize to SYMBOL_BLOCK_SIZE.
861 (marker_block_index): Initialize to MARKER_BLOCK_SIZE.
862 (staticidx, init_alloc_once, init_strings, free_ablock):
863 Remove redundant initialization.
864 * fns.c (init_weak_hash_tables): Remove.
865 * lisp.h (init_weak_hash_tables): Remove prototype.
867 2012-07-15 Dmitry Antipov <dmantipov@yandex.ru>
869 Use zero_vector where appropriate.
870 * alloc.c (zero_vector): Define as Lisp_Object. Adjust users
872 * lisp.h (zero_vector): New declaration.
873 * font.c (null_vector): Remove.
874 (syms_of_font): Remove initialization and staticpro.
875 (font_list_entities, font_find_for_lface): Change to use zero_vector.
876 * keymap.c (Faccessible_keymaps): Likewise.
878 2012-07-15 Leo Liu <sdl.web@gmail.com>
880 * fringe.c: Fix typo in comments.
882 2012-07-14 Leo Liu <sdl.web@gmail.com>
884 * fringe.c: Add a new bitmap exclamation-mark.
886 2012-07-14 Eli Zaretskii <eliz@gnu.org>
888 * gmalloc.c (GMALLOC_INHIBIT_VALLOC): Don't reference.
890 * s/msdos.h (BSD_SYSTEM, DATA_START, GC_SETJMP_WORKS, HAVE_MOUSE)
891 (HAVE_MENUS): Don't define, defined by editing config.in with
893 (GMALLOC_INHIBIT_VALLOC): Don't define.
894 (MODE_LINE_BINARY_TEXT): Remove, not used anymore.
896 2012-07-14 Juanma Barranquero <lekktu@gmail.com>
898 * s/ms-w32.h (GC_SETJMP_WORKS, GC_MARK_STACK): Set in nt/config.nt.
900 2012-07-14 Glenn Morris <rgm@gnu.org>
902 * s/aix4-2.h, s/freebsd.h, s/gnu-linux.h, s/hpux10-20.h:
903 * s/irix6-5.h, s/netbsd.h, s/sol2-6.h, s/unixware.h:
904 Let configure set GC_SETJMP_WORKS, GC_MARK_STACK.
906 2012-07-13 Glenn Morris <rgm@gnu.org>
908 * s/gnu-linux.h (GC_MARK_SECONDARY_STACK): Let configure set it.
910 * s/usg5-4-common.h (SETUP_SLAVE_PTY): Let configure set it.
911 * s/irix6-5.h (SETUP_SLAVE_PTY): No more need to unset it.
913 2012-07-13 Jan Djärv <jan.h.d@swipnet.se>
915 * nsterm.m (uRect): Only define if NS_IMPL_GNUSTEP.
916 (x_free_frame_resources): Pass x_free_frame_resources to NSTRACE.
917 (ns_lisp_to_color, ns_string_to_lispmod, ns_term_init)
918 (ns_term_shutdown, requestService, initFrameFromEmacs): Use SSDATA
920 (ns_exec_path, ns_load_path, changeFont): Put () around assignment used
921 as boolean expression.
922 (x_set_window_size): Remove unused variable toolbar.
923 (ns_get_color_default, ns_mod_to_lisp): Remove.
924 (ns_mouse_position): Remove unused variables xchar and ychar.
925 (ns_compute_glyph_string_overhangs): Remove unused variable face.
926 (ns_set_vertical_scroll_bar): Remove unused variable count.
927 (ns_delete_terminal): Remove unused variable i.
928 (ns_term_init): Remove unused variables r, g and b.
929 (mouseDown): Remove unused variable window.
930 (windowDidResize): Move definition of theWindow inside NS_IMPL_GNUSTEP.
931 (initFrameFromEmacs): Remove unused variable vbextra.
932 (mouseEntered): Remove unused variables p and dpyinfo.
933 (mouseExited): Remove unused variables p and r.
934 (ns_define_frame_cursor, ns_clear_frame_area)
935 (ns_draw_window_cursor, ns_initialize_display_info): Make static.
936 (menuDown): Assign [sender tag] to variable and cast the variable.
938 * nsterm.h (menuDown): Add id as type to argument sender.
939 (ns_display_info_for_name): Add Lisp_Object argument.
940 (ns_term_init): Add Lisp_Object argument.
941 (ns_map_event_to_object): Add void argument.
942 (ns_string_from_pasteboard, ns_string_to_pasteboard): Add correct
943 prototype with arguments and only declare if __OBJC__.
944 (nxatoms_of_nsselect): Add void argument.
945 (ns_lisp_to_cursor_type): Add Lisp_Object argument.
946 (ns_alloc_autorelease_pool): Add void argument.
947 (ns_release_autorelease_pool): Add void* argument.
948 (ns_get_defaults_value): Add const char* argument.
950 * nsmenu.m (ns_update_menubar, ns_menu_show, process_dialog)
951 (initFromContents): Use SSDATA where appropriate.
952 (ns_update_menubar): Add braces to ambigous if-else.
953 (initWithTitle): Put () around assignment in if statement.
954 (ns_menu_show): Remove unused variables window and keymap.
955 (update_frame_tool_bar): Remove unused variable selected_p.
956 (initWithContentRect): Remove unused variable this_cmd_name.
958 * nsimage.m (ns_load_image, allocInitFromFile): Use SSDATA where
960 (setXBMColor): Remove unused variable len.
961 (setPixmapData): Put () around assignment in loop statement.
963 * nsfont.m (ns_get_family, ns_lang_to_script, ns_otf_to_script)
964 (ns_registry_to_script, ns_get_req_script, nsfont_open): Use SSDATA
966 (ns_get_covering_families, ns_findfonts, nsfont_list_family): Put ()
967 around assignment in loop statement.
968 (nsfont_open): Remove unused variable i.
969 (nsfont_open): Remove unused variable len.
970 (nsfont_draw): Remove unused variable cs.
972 * nsfns.m (x_set_icon_name, ns_set_name_internal)
973 (ns_set_name_as_filename, ns_implicitly_set_icon_type)
974 (x_set_icon_type, ns_lisp_to_cursor_type, Fns_read_file_name)
975 (Fns_get_resource, Fns_set_resource, Fx_open_connection)
976 (Fns_font_name, Fns_perform_service)
977 (Fns_convert_utf8_nfd_to_nfc, ns_do_applescript)
978 (Fns_do_applescript, Fx_show_tip): Use SSDATA where appropriate.
979 (ns_set_name): Remove unused variable view.
980 (x_set_menu_bar_lines): Remove unused variable olines.
981 (x_set_tool_bar_lines): Remove unused variable root_window.
982 (Fns_list_colors): Put () around assignment in while statement.
983 (Fns_perform_service): Remove unused variable len.
984 (Fns_display_usable_bounds): Remove unused variable top.
985 (syms_of_nsfns): Remove unused variable i.
987 * nsmenu.m (ns_update_menubar): Exchange place of argument 2 and 3 to
990 2012-07-13 Kalle Kankare <kalle.kankare@iki.fi> (tiny change)
992 * image.c (Fimagemagick_types): Initialize ex with GetExceptionInfo
993 and free it with DestroyExceptionInfo (Bug#11558).
995 2012-07-13 Juanma Barranquero <lekktu@gmail.com>
997 * s/ms-w32.h (FIRST_PTY_LETTER, HAVE_SOCKETS): Move to nt/config.nt.
998 (HAVE_ATTRIBUTE_ALIGNED, HAVE_C99_STRTOLD, HAVE___BUILTIN_UNWIND_INIT):
999 Set here, not in nt/config.nt.
1001 2012-07-13 Eli Zaretskii <eliz@gnu.org>
1003 * xdisp.c (move_it_in_display_line_to): On GUI terminals, allow
1004 cursor overflow into the last glyph on display line when the right
1005 fringe is off. (Bug#11832)
1007 2012-07-13 Paul Eggert <eggert@cs.ucla.edu>
1009 * xdisp.c (produce_special_glyphs): Now static.
1010 * dispextern.h (produce_special_glyphs): Remove decl.
1012 2012-07-13 Glenn Morris <rgm@gnu.org>
1014 * s/bsd-common, s/cygwin.h: Remove empty files.
1015 * s/freebsd.h, s/netbsd.h: Do not include bsd-common.h.
1017 * s/usg5-4-common.h (USG, USG5):
1018 * s/template.h (USG5, USG, HPUX, BSD4_2, BSD_SYSTEM):
1019 * s/sol2-6.h (SOLARIS2):
1020 * s/irix6-5.h (IRIX6_5):
1021 * s/hpux10-20.h (USG, USG5, HPUX):
1022 * s/gnu-linux.h (USG, GNU_LINUX):
1023 * s/freebsd.h (BSD_SYSTEM):
1024 * s/darwin.h (BSD4_2, BSD_SYSTEM, DARWIN_OS):
1025 * s/cygwin.h (CYGWIN):
1026 * s/bsd-common.h (BSD_SYSTEM, BSD4_2):
1027 * s/aix4-2.h (USG, USG5, _AIX): Move "system type" macros to configure.
1029 2012-07-13 BT Templeton <bpt@hcoop.net> (tiny change)
1031 * nsfont.m (ns_charset_covers): Don't abort if no bitmap (Bug#11853).
1033 2012-07-13 Glenn Morris <rgm@gnu.org>
1035 * s/usg5-4-common.h (NSIG_MINIMUM): Let configure set it.
1037 * s/gnu-linux.h, s/irix6-5.h: Let configure set ULIMIT_BREAK_VALUE.
1039 * process.c (init_process_emacs): Replace MIN_PTY_KERNEL_VERSION.
1040 * s/darwin.h (MIN_PTY_KERNEL_VERSION): Remove single-use macro.
1042 2012-07-12 Glenn Morris <rgm@gnu.org>
1044 * s/darwin.h (SYSTEM_PURESIZE_EXTRA): Move to configure.
1046 * process.c (init_process_emacs): Rename from init_process.
1047 The old name is also the name of a Mach system call.
1048 * lisp.h, emacs.c: Update for this name change.
1049 * nsgui.h, sysselect.h, s/darwin.h: Remove workaround that is no
1052 2012-07-12 Eli Zaretskii <eliz@gnu.org>
1054 * xdisp.c (insert_left_trunc_glyphs): Fix incorrect size in
1055 memmove call that removes glyphs covered by the left truncation
1056 glyph. Improve commentary.
1057 (display_line): Fix display of continuation glyphs on GUI frames
1058 when the right fringe is turned off and variable-size fonts are
1059 used in the window. Move the code that appends a stretch glyph to
1060 produce_special_glyphs, so that it could be used for truncation
1061 and continuation glyphs alike.
1062 (produce_special_glyphs) [HAVE_WINDOW_SYSTEM]: Produce a stretch
1063 glyph of a suitably computed width, to align the special glyphs at
1064 the window margin. Code moved from display_line. (Bug#11832)
1066 2012-07-12 Glenn Morris <rgm@gnu.org>
1068 * s/aix4-2.h, s/hpux10-20.h: Let configure set NO_EDITRES.
1070 * s/gnu-linux.h, s/hpux10-20.h:
1071 Do not unconditionally define HAVE_XRMSETDATABASE.
1073 * s/gnu-linux.h (UNIX98_PTYS): Let configure set it.
1075 2012-07-12 Paul Eggert <eggert@cs.ucla.edu>
1077 Fix typos that broke OS X build.
1078 Reported by Randal L. Schwartz in
1079 <http://lists.gnu.org/archive/html/emacs-devel/2012-07/msg00225.html>.
1080 * nsterm.m (ns_timeout): Add missing local decl.
1081 (ns_get_color): snprintf -> sprintf, to fix typo.
1083 2012-07-12 Glenn Morris <rgm@gnu.org>
1085 * src/s/aix4-2.h, src/s/cygwin.h, src/s/darwin.h:
1086 * src/s/gnu-linux.h, src/s/hpux10-20.h, src/s/irix6-5.h:
1087 * src/s/sol2-6.h, src/s/unixware.h, src/s/usg5-4-common.h:
1088 Move PTY_NAME_SPRINTF, PTY_TTY_NAME_SPRINTF to configure.
1090 * s/cygwin.h, s/darwin.h, s/gnu-linux.h, s/irix6-5.h:
1091 Move PTY_OPEN to configure.
1093 * s/aix4-2.h, s/bsd-common.h, s/cygwin.h, s/darwin.h:
1094 * s/gnu-linux.h, s/hpux10-20.h, s/irix6-5.h, s/template.h:
1095 * s/usg5-4-common.h: Move FIRST_PTY_LETTER, PTY_ITERATION to configure.
1097 2012-07-12 Dmitry Antipov <dmantipov@yandex.ru>
1099 Use empty_unibyte_string where applicable.
1100 * keyboard.c (parse_tool_bar_item): Use empty_unibyte_string.
1101 * lread.c (read1): Likewise.
1102 * xsettings.c (syms_of_xsettings): Likewise.
1104 2012-07-12 Glenn Morris <rgm@gnu.org>
1106 * s/cygwin.h (G_SLICE_ALWAYS_MALLOC):
1107 * s/freebsd.h (BROKEN_PTY_READ_AFTER_EAGAIN):
1108 * s/irix6-5.h (SETPGRP_RELEASES_CTTY, PREFER_VSUSP):
1109 * s/hpux10-20.h (RUN_TIME_REMAP):
1110 * s/bsd-common.h (TABDLY): Move to configure.
1112 * s/hpux10-20.h, s/sol2-6.h: Move XOS_NEEDS_TIME_H to configure.
1114 * s/bsd-common.h, s/darwin.h: Move TAB3 to configure.
1116 * s/aix4-2.h (BROKEN_FIONREAD, BROKEN_SIGAIO, BROKEN_SIGPTY)
1117 (BROKEN_SIGPOLL, BROKEN_GET_CURRENT_DIR_NAME): Let configure set them.
1119 * s/darwin.h (NO_ABORT, NO_MATHERR): Let configure set them.
1121 * s/bsd-common.h, s/cygwin.h, s/gnu-linux.h, s/irix6-5.h:
1122 * s/template.h: Move NARROWPROTO to configure.
1124 2012-07-11 Glenn Morris <rgm@gnu.org>
1126 * s/gnu-linux.h, s/sol2-6.h: No longer define POSIX,
1127 unused since 2011-01-17 change to systty.h.
1129 * s/aix4-2.h, s/bsd-common.h, s/cygwin.h, s/darwin.h, s/gnu-linux.h:
1130 * s/hpux10-20.h, s/template.h, s/usg5-4-common.h:
1131 Move HAVE_PTYS and HAVE_SOCKETS to configure.
1133 2012-07-11 Paul Eggert <eggert@cs.ucla.edu>
1135 * s/sol2-6.h (HAVE_LIBKSTAT): Remove. (Bug#11914)
1137 2012-07-11 Glenn Morris <rgm@gnu.org>
1139 * s/darwin.h, s/gnu-linux.h, s/template.h:
1140 Move INTERRUPT_INPUT to configure.
1142 2012-07-11 Dmitry Antipov <dmantipov@yandex.ru>
1144 Minor adjustments to interning code.
1145 * lisp.h (intern, intern_c_string): Redefine as static inline
1146 wrappers for intern_1 and intern_c_string_1, respectively.
1147 (intern_1, intern_c_string_1): Rename prototypes.
1148 * lread.c (intern_1, intern_c_string_1, oblookup): Simplify
1150 * font.c (font_intern_prop): Likewise. Adjust comment.
1151 * w32font.c (intern_font_name): Likewise.
1153 2012-07-11 Andreas Schwab <schwab@linux-m68k.org>
1155 * gnutls.c (Fgnutls_boot): Properly parse :keylist argument.
1157 * coding.c (Fdefine_coding_system_internal): Use XCAR/XCDR instead
1158 of Fcar/Fcdr if possible.
1159 * font.c (check_otf_features): Likewise.
1160 * fontset.c (Fnew_fontset): Likewise.
1161 * gnutls.c (Fgnutls_boot): Likewise.
1162 * minibuf.c (read_minibuf): Likewise.
1163 * msdos.c (IT_set_frame_parameters): Likewise.
1164 * xmenu.c (Fx_popup_dialog): Likewise.
1165 * w32menu.c (Fx_popup_dialog): Likewise.
1167 2012-07-11 Glenn Morris <rgm@gnu.org>
1169 * s/bsd-common.h, s/cygwin.h: No need to undefine INTERRUPT_INPUT,
1170 since nothing has defined it on these platforms.
1172 * s/aix4-2.h, s/bsd-common.h, s/cygwin.h, s/gnu-linux.h:
1173 * s/irix6-5.h: Move SIGNALS_VIA_CHARACTERS to configure.
1175 * s/aix4-2.h, s/bsd-common.h, s/cygwin.h, s/darwin.h:
1176 * s/gnu-linux.h, s/hpux10-20.h, s/template.h, s/usg5-4-common.h:
1177 Move CLASH_DETECTION to configure.
1179 * s/gnu.h: Remove file, which is now empty.
1181 * s/gnu.h, s/gnu-linux.h:
1182 Move GNU_LIBRARY_PENDING_OUTPUT_COUNT to configure.
1184 2012-07-11 John Wiegley <johnw@newartisans.com>
1186 * alloc.c (mark_memory): Guard the "no_address_safety_analysis"
1187 function attribute, so we only use it if it exists in the
1190 2012-07-11 Dmitry Antipov <dmantipov@yandex.ru>
1192 Avoid call to strlen in fast_c_string_match_ignore_case.
1193 * search.c (fast_c_string_match_ignore_case): Change to use
1194 length argument. Adjust users accordingly.
1195 * lisp.h (fast_c_string_match_ignore_case): Adjust prototype.
1197 2012-07-11 Paul Eggert <eggert@cs.ucla.edu>
1199 Assume mkdir, rmdir.
1200 * sysdep.c (mkdir) [!HAVE_MKDIR]: Remove.
1201 * sysdep.c (rmdir) [!HAVE_RMDIR]: Remove.
1204 * sysdep.c (rename) [!HAVE_RENAME]: Remove.
1207 * s/hpux10-20.h (HAVE_PERROR): Remove.
1208 * sysdep.c (perror) [HPUX && !HAVE_PERROR]:
1209 Remove dummy definition, as this problem was obsolete long ago.
1212 * sysdep.c (strerror) [!HAVE_STRERROR && !WINDOWSNT]: Remove.
1214 2012-07-11 Dmitry Antipov <dmantipov@yandex.ru>
1216 Avoid calls to strlen in font processing functions.
1217 * font.c (font_parse_name, font_parse_xlfd, font_parse_fcname)
1218 (font_open_by_name): Change to use length argument. Adjust
1220 * font.h (font_open_by_name, font_parse_xlfd, font_unparse_xlfd):
1222 * xfont.c (xfont_decode_coding_xlfd, font_unparse_xlfd):
1223 Change to return ptrdiff_t.
1224 (xfont_list_pattern, xfont_match): Use length returned by
1225 xfont_decode_coding_xlfd.
1226 * xfns.c (x_default_font_parameter): Omit useless xstrdup.
1228 2012-07-11 Glenn Morris <rgm@gnu.org>
1230 * s/darwin.h, s/freebsd.h, s/netbsd.h:
1231 Move DONT_REOPEN_PTY to configure.
1233 * sound.c (DEFAULT_SOUND_DEVICE) [!WINDOWSNT]:
1234 * s/netbsd.h (DEFAULT_SOUND_DEVICE): Let configure set it.
1236 2012-07-10 Paul Eggert <eggert@cs.ucla.edu>
1238 Remove "#define unix" that is no longer needed (Bug#11905).
1239 * s/aix4-2.h (unix): Remove; no longer needed.
1241 EMACS_TIME simplification (Bug#11875).
1242 This replaces macros (which typically do not work in GDB)
1243 with functions, typedefs and enums, making the code easier to debug.
1244 The functional style also makes code easier to read and maintain.
1245 * systime.h: Include <sys/time.h> on all hosts, not just if
1246 WINDOWSNT, since 'struct timeval' is needed in general.
1247 (EMACS_TIME): Now a typedef, not a macro.
1248 (EMACS_TIME_RESOLUTION, LOG10_EMACS_TIME_RESOLUTION): Now constants,
1250 (EMACS_SECS, EMACS_NSECS, EMACS_TIME_SIGN, EMACS_TIME_VALID_P)
1251 (EMACS_TIME_FROM_DOUBLE, EMACS_TIME_TO_DOUBLE, EMACS_TIME_EQ)
1252 (EMACS_TIME_NE, EMACS_TIME_GT, EMACS_TIME_GE, EMACS_TIME_LT)
1253 (EMACS_TIME_LE): Now functions, not macros.
1254 (EMACS_SET_SECS, EMACS_SET_NSECS, EMACS_SET_SECS_NSECS)
1255 (EMACS_SET_USECS, EMACS_SET_SECS_USECS): Remove these macros,
1256 which are not functions. All uses rewritten to use:
1257 (make_emacs_time): New function.
1258 (EMACS_SECS_ADDR, EMACS_SET_INVALID_TIME, EMACS_GET_TIME)
1259 (EMACS_ADD_TIME, EMACS_SUB_TIME): Remove these macros, which are
1260 not functions. All uses rewritten to use the following, respectively:
1261 (emacs_secs_addr, invalid_emacs_time, get_emacs_time)
1262 (add_emacs_time, sub_emacs_time): New functions.
1263 * atimer.c: Don't include <sys/time.h>, as "systime.h" does this.
1264 * fileio.c (Fcopy_file):
1265 * xterm.c (XTflash): Get the current time closer to when it's used.
1266 * makefile.w32-in ($(BLD)/atimer.$(O)): Update dependencies.
1268 * bytecode.c (targets): Suppress -Woverride-init warnings.
1270 Simplify by avoiding confusing use of strncpy etc.
1271 * doc.c (Fsnarf_documentation):
1272 * fileio.c (Ffile_name_directory, Fsubstitute_in_file_name):
1273 * frame.c (Fmake_terminal_frame):
1274 * gtkutil.c (get_utf8_string):
1276 * nsmenu.m (ns_update_menubar):
1277 * regex.c (regerror):
1278 Prefer memcpy to strncpy and strncat when either will do.
1279 * fileio.c (Fsubstitute_in_file_name):
1280 * keyboard.c (MULTI_LETTER_MOD, parse_modifiers_uncached)
1281 (menu_separator_name_p):
1282 * nsmenu.m (ns_update_menubar):
1283 Prefer memcmp to strncmp when either will do.
1284 * nsterm.m: Include <ftoastr.h>.
1286 * s/gnu-linux.h, s/sol2-6.h, s/unixware.h (PTY_TTY_NAME_SPRINTF):
1287 Prefer snprintf to strncpy.
1288 * nsterm.m (ns_term_init):
1289 * widget.c (set_frame_size) [0]: Prefer xstrdup to xmalloc + strncpy.
1290 * nsterm.m (ns_term_init):
1291 Avoid the need for strncpy, by using build_string or
1292 make_unibyte_string directly. Use dtoastr, not snprintf.
1293 * process.c (Fmake_network_process): Diagnose service names that
1294 are too long, rather than silently truncating them or creating
1295 non-null-terminated names.
1296 (Fnetwork_interface_info): Likewise, for interface names.
1297 * sysdep.c (system_process_attributes) [GNU_LINUX]:
1298 Prefer sprintf to strncat.
1299 * xdisp.c (debug_method_add) [GLYPH_DEBUG]:
1300 Prefer vsnprintf to vsprintf + strncpy.
1302 2012-07-10 Glenn Morris <rgm@gnu.org>
1304 * dispnew.c (PENDING_OUTPUT_COUNT) [!__GNU_LIBRARY__]:
1305 Clarify fallback case.
1307 2012-07-10 Dmitry Antipov <dmantipov@yandex.ru>
1309 Use XCAR and XCDR instead of Fcar and Fcdr where possible.
1310 * callint.c, coding.c, doc.c, editfns.c, eval.c, font.c, fontset.c,
1311 * frame.c, gnutls.c, minibuf.c, msdos.c, textprop.c, w32fns.c,
1312 * w32menu.c, window.c, xmenu.c: Change to use XCAR and XCDR
1313 where argument type is known to be a Lisp_Cons.
1315 2012-07-10 Tom Tromey <tromey@redhat.com>
1317 * bytecode.c (BYTE_CODE_THREADED): New macro.
1318 (BYTE_CODES): New macro. Replaces all old byte-code defines.
1319 (enum byte_code_op): New type.
1320 (CASE, NEXT, FIRST, CASE_DEFAULT, CASE_ABORT): New macros.
1321 (exec_byte_code): Use them. Use token threading when applicable.
1323 2012-07-10 Dmitry Antipov <dmantipov@yandex.ru>
1325 Optimize pure C strings initialization.
1326 * lisp.h (make_pure_string): Fix prototype.
1327 (build_pure_c_string): New function, defined as static inline. This
1328 provides a better opportunity to optimize away calls to strlen when
1329 the function is called with compile-time constant argument.
1330 * alloc.c (make_pure_c_string): Fix comment. Change to add nchars
1331 argument, adjust users accordingly. Use build_pure_c_string where
1333 * buffer.c, coding.c, data.c, dbusbind.c, fileio.c, fontset.c, frame.c,
1334 * keyboard.c, keymap.c, lread.c, search.c, syntax.c, w32fns.c, xdisp.c,
1335 * xfaces.c, xfns.c, xterm.c: Use build_pure_c_string where appropriate.
1337 2012-07-10 Dmitry Antipov <dmantipov@yandex.ru>
1339 Avoid calls to strlen in miscellaneous functions.
1340 * buffer.c (init_buffer): Use precalculated len, adjust if needed.
1341 * font.c (Ffont_xlfd_name): Likewise. Change to call make_string.
1342 * lread.c (openp): Likewise.
1344 2012-07-10 Dmitry Antipov <dmantipov@yandex.ru>
1346 Avoid calls to strlen in path processing functions.
1347 * fileio.c (file_name_as_directory): Add comment. Change to add
1348 srclen argument and return the length of result. Adjust users
1350 (directory_file_name): Fix comment. Change to add srclen argument,
1351 swap 1st and 2nd arguments to obey the common convention. Adjust
1353 * filelock.c (fill_in_lock_file_name): Avoid calls to strlen.
1355 2012-07-10 Glenn Morris <rgm@gnu.org>
1357 * s/cygwin.h, s/darwin.h, s/freebsd.h, s/netbsd.h, s/unixware.h:
1358 Move PENDING_OUTPUT_COUNT definition to configure.
1360 * s/irix6-5.h (DATA_START, DATA_SEG_BITS):
1361 * s/hpux10-20.h (DATA_SEG_BITS, DATA_START):
1362 * s/gnu.h (DATA_START): Move definitions to configure.
1364 * s/irix6-5.h (SETUP_SLAVE_PTY, PTY_NAME_SPRINTF): Drop ifdef guards.
1365 We include usg5-4-common.h, which defines them both.
1367 * s/gnu.h: Don't include fcntl.h (every file in Emacs that uses
1368 O_RDONLY already includes it).
1370 Stop ns builds setting the EMACSLOADPATH environment variable.
1371 * nsterm.m (ns_load_path): Rename from ns_init_paths.
1372 Now it does not set EMACSLOADPATH, just returns the load-path string.
1373 * nsterm.h: Update accordingly.
1374 * lread.c [HAVE_NS]: Include nsterm.h.
1375 (init_lread) [HAVE_NS]: Use ns_load_path.
1376 * emacs.c (main) [HAVE_NS]: No longer call ns_init_paths.
1378 2012-07-09 Glenn Morris <rgm@gnu.org>
1380 * s/gnu.h (SIGNALS_VIA_CHARACTERS): No need to define it here,
1381 since the included bsd-common.h does so.
1383 Stop ns builds setting the EMACSPATH environment variable.
1384 * nsterm.m (ns_exec_path): New function, split from ns_init_paths.
1385 (ns_init_paths): Do not set EMACSPATH.
1386 * nsterm.h (ns_exec_path): Add it.
1387 * callproc.c (init_callproc_1, init_callproc) [HAVE_NS]:
1390 * nsterm.m, nsterm.h (ns_etc_directory): Fix type, empty return.
1392 2012-07-09 Paul Eggert <eggert@cs.ucla.edu>
1394 * process.c (wait_reading_process_output): 'waitchannels' was unset
1395 when read_kbd || !NILP (wait_for_cell); fix this.
1397 Add GCC-style 'const' attribute to functions that can use it.
1398 * character.h (char_resolve_modifier_mask):
1399 * keyboard.h (make_ctrl_char):
1400 * lisp.h (multibyte_char_to_unibyte, multibyte_char_to_unibyte_safe)
1401 (init_character_once, next_almost_prime, init_fns, init_image)
1402 (flush_pending_output, init_sound):
1403 * mem-limits.h (start_of_data):
1404 * menu.h (finish_menu_items):
1405 Add ATTRIBUTE_CONST.
1406 * emacs.c (DEFINE_DUMMY_FUNCTION):
1407 Declare the dummy function with ATTRIBUTE_CONST.
1408 * lisp.h (Fbyteorder, Fmax_char, Fidentity):
1409 Add decls with ATTRIBUTE_CONST.
1411 Minor improvements to make_formatted_string.
1412 * alloc.c (make_formatted_string): Prefer int to ptrdiff_t
1413 where int is good enough, as vsprintf returns an int.
1414 * lisp.h (make_formatted_string): Add ATTRIBUTE_FORMAT_PRINTF.
1416 2012-07-09 Dmitry Antipov <dmantipov@yandex.ru>
1418 Use make_formatted_string to avoid double length calculation.
1419 * lisp.h (make_formatted_string): New prototype.
1420 * alloc.c (make_formatted_string): New function.
1421 * buffer.c (Fgenerate_new_buffer_name): Use it.
1422 * dbus.c (syms_of_dbusbind): Likewise.
1423 * editfns.c (Fcurrent_time_zone): Likewise.
1424 * filelock.c (get_boot_time): Likewise.
1425 * frame.c (make_terminal_frame, set_term_frame_name)
1426 (x_report_frame_params): Likewise.
1427 * image.c (gs_load): Likewise.
1428 * minibuf.c (get_minibuffer): Likewise.
1429 * msdos.c (dos_set_window_size): Likewise.
1430 * process.c (make_process): Likewise.
1431 * xdisp.c (ensure_echo_area_buffers): Likewise.
1432 * xsettings.c (apply_xft_settings): Likewise.
1434 2012-07-09 Glenn Morris <rgm@gnu.org>
1436 Stop ns builds polluting the environment with EMACSDATA, EMACSDOC.
1437 * nsterm.m (ns_etc_directory): New function, split from ns_init_paths.
1438 (ns_init_paths): Do not set EMACSDATA, EMACSDOC.
1439 * nsterm.h (ns_etc_directory): Add it.
1440 * callproc.c [HAVE_NS]: Include nsterm.h.
1441 (init_callproc_1, init_callproc) [HAVE_NS]: Use ns_etc_directory.
1443 2012-07-09 Dmitry Antipov <dmantipov@yandex.ru>
1445 Move marker debugging code under MARKER_DEBUG.
1446 * marker.c (MARKER_DEBUG): Move marker debugging code under
1447 #ifdef MARKER_DEBUG because byte_char_debug_check is too slow
1448 for bootstrap with --enable-checking (~3x slowdown reported
1449 by Juanma Barranquero <lekktu@gmail.com>).
1450 (verify_bytepos): Move under #ifdef MARKER_DEBUG.
1452 2012-07-08 Paul Eggert <eggert@cs.ucla.edu>
1454 * systime.h (EMACS_SUB_TIME): Clarify behavior with unsigned time_t.
1455 See <http://bugs.gnu.org/11825#29>.
1457 2012-07-08 Eli Zaretskii <eliz@gnu.org>
1459 * xdisp.c (fill_glyphless_glyph_string): If the face of the glyph
1460 has no font, use the frame's font. (Bug#11813)
1461 (display_line): Add commentary about displaying truncation glyphs
1463 (produce_special_glyphs): Move here from term.c.
1465 * term.c (produce_special_glyphs): Move to xdisp.c.
1467 * dispextern.h (produce_special_glyphs): Move prototype to xdisp.c
1470 2012-07-07 Andreas Schwab <schwab@linux-m68k.org>
1472 * xdisp.c (display_line): Avoid warning about implicit declaration
1475 * frame.c (get_frame_param): Define only if HAVE_WINDOW_SYSTEM.
1477 * lisp.h: Remove empty conditional.
1479 2012-07-07 Paul Eggert <eggert@cs.ucla.edu>
1481 * lread.c (load_path_check): Now static.
1483 Fix some minor --with-ns problems found by static checking.
1484 * frame.c (Ftool_bar_pixel_width) [!FRAME_TOOLBAR_WIDTH]:
1485 (x_set_font) [!HAVE_X_WINDOWS]:
1486 * image.c (xpm_load_image) [HAVE_NS]:
1487 (x_to_xcolors) [!HAVE_X_WINDOWS && !HAVE_NTGUI]:
1488 (x_disable_image) [!HAVE_NS && !HAVE_NTGUI]:
1489 Remove unused local.
1490 (Fx_parse_geometry) [HAVE_NS]: Don't return garbage.
1491 (xpm_load_image) [HAVE_NS && !HAVE_XPM]: Remove unused label.
1492 * image.c (x_create_bitmap_from_file) [HAVE_NS]:
1493 (xpm_load_image, xpm_load) [HAVE_NS && !HAVE_XPM]:
1494 * nsselect.m (symbol_to_nsstring, ns_string_to_pasteboard_internal):
1495 * xfaces.c (Fx_load_color_file) [!HAVE_X_WINDOWS]:
1496 Fix pointer signedness problem.
1497 * xfaces.c (FRAME_X_FONT_TABLE):
1498 * xterm.h (FRAME_X_FONT_TABLE): Remove unused, incompatible macros.
1500 2012-07-07 Glenn Morris <rgm@gnu.org>
1502 * lread.c (load_path_check): New function, split from init_lread.
1503 (init_lread): Reorganize. Motivation:
1504 If EMACSLOADPATH is set, check/warn about that rather than the
1505 defaults, which we are not going to use. Hence we can remove
1506 the turn_off_warning and WINDOWSNT || HAVE_NS tests.
1507 Don't warn if site-lisp directories are missing.
1508 If not installed, start from a blank load-path, since
1509 PATH_LOADSEARCH refers to the eventual installation directories.
1511 2012-07-07 Eli Zaretskii <eliz@gnu.org>
1513 Support truncation and continuation glyphs on GUI frames, when
1514 fringes are disabled. (Bug#11832)
1515 * xdisp.c (init_iterator): Get dimensions of truncation and
1516 continuation glyphs even if on GUI frames. Adjust
1517 it->last_visible_x on GUI frames when the left or right fringes,
1518 or both, are absent.
1519 (start_display, move_it_in_display_line_to): Handle the case of a
1520 GUI frame without a fringe to display continuation or truncation
1522 (insert_left_trunc_glyphs): Support GUI frames: make sure
1523 truncation glyphs overwrite enough glyphs from the current line to
1524 have sufficient space in pixels.
1525 (display_line): Support truncation and continuation glyphs on GUI
1526 frames. If some spare pixels are left on the line after inserting
1527 the truncation glyphs, fill that space with a stretch glyph of a
1528 suitably computed width.
1530 * term.c (produce_special_glyphs): Call PRODUCE_GLYPHS, not
1531 produce_glyphs, to support GUI sessions.
1533 2012-07-07 Paul Eggert <eggert@cs.ucla.edu>
1535 * sysdep.c (ULLONG_MAX): Define if not already defined (Bug#11781).
1537 * sysdep.c (list_system_processes): Port to NetBSD-current (Bug#11797).
1539 Do not require float-time's arg to fit in time_t (Bug#11825).
1540 This works better on hosts where time_t is unsigned, and where
1541 float-time is applied to the (negative) difference between two times.
1542 * editfns.c (decode_time_components): Last arg is now double *,
1543 not int *, and means to store all the result as a double, without
1544 worrying about whether the seconds part fits in time_t.
1545 All callers changed.
1546 (lisp_time_argument): Remove last int * arg, as it's no longer needed.
1547 All callers changed.
1548 (Ffloat_time): Do not fail merely because the specified time falls
1549 outside of time_t range.
1551 2012-07-07 Glenn Morris <rgm@gnu.org>
1553 * s/darwin.h (HAVE_RES_INIT, HAVE_LIBRESOLV):
1554 * s/hpux10-20.h (HAVE_RINT, HAVE_RANDOM):
1555 * s/unixware.h (HAVE_GETWD): Move undefs to configure (effectively).
1557 2012-07-07 Juanma Barranquero <lekktu@gmail.com>
1559 * makefile.w32-in (DISPEXTERN_H, $(BLD)/regex.$(O)):
1560 Update dependencies.
1562 * s/ms-w32.h [_MSC_VER]: Remove strcasecmp, strncasecmp.
1564 2012-07-06 Paul Eggert <eggert@cs.ucla.edu>
1566 Use c_strcasecmp for ASCII case-insensitive comparison (Bug#11786).
1567 * dispextern.h, nsfns.m, nsterm.m: Include <c-strcase.h>.
1568 * dispextern.h (xstrcasecmp): Rewrite using c_strcasecmp.
1569 * nsfns.m (x_get_string_resource): Use c_strncasecmp, not strncasecmp.
1570 * nsterm.m (ns_default): Use c_strcasecmp, not strcasecmp.
1571 * xfaces.c (xstrcasecmp) [!HAVE_STRCASECMP]: Remove.
1573 * xfont.c (compare_font_names): Redo to omit the need for casts.
1575 2012-07-06 Andreas Schwab <schwab@linux-m68k.org>
1577 * xfns.c (Fx_change_window_property): Doc fix.
1578 * w32fns.c (Fx_change_window_property): Doc fix.
1580 * w32fns.c (Fx_window_property): Accept the same arguments as the
1581 X Windows version. Doc fix.
1582 * xfns.c (Fx_window_property): Doc fix. (Bug#11870)
1584 2012-07-06 Juanma Barranquero <lekktu@gmail.com>
1585 Eli Zaretskii <eliz@gnu.org>
1587 * s/ms-w32.h: Settings not specific to Windows moved to nt/config.nt.
1588 Windows-specific code from nt/config.nt moved here.
1589 Obsolete settings removed.
1591 2012-07-06 Paul Eggert <eggert@cs.ucla.edu>
1593 * process.c: Avoid unnecessary calls to gettime.
1594 (wait_reading_process_output): Don't get the time of day
1595 when gobbling data immediately and not waiting, as there's no need
1596 for it in that case. This removes a FIXME.
1598 2012-07-06 Jan Djärv <jan.h.d@swipnet.se>
1600 * gtkutil.c (xg_event_is_for_scrollbar): Assign gwin when HAVE_GTK3
1601 is defined (Bug#11768).
1603 2012-07-06 Dmitry Antipov <dmantipov@yandex.ru>
1605 Fix marker debugging code.
1606 * marker.c (byte_char_debug_check): Do not perform the check
1607 if buffer is not multibyte.
1608 (buf_charpos_to_bytepos, buf_bytepos_to_charpos):
1609 Call byte_char_debug_check with correct arguments.
1611 2012-07-06 Dmitry Antipov <dmantipov@yandex.ru>
1613 Compile marker debugging code only if ENABLE_CHECKING is defined.
1614 * marker.c (byte_char_debug_check, count_markers):
1615 Use only if ENABLE_CHECKING is defined.
1616 (byte_debug_flag): Remove.
1617 (CONSIDER, buf_charpos_to_bytepos, buf_bytepos_to_charpos):
1618 Always call byte_char_debug_check if ENABLE_CHECKING is defined.
1620 2012-07-06 Dmitry Antipov <dmantipov@yandex.ru>
1622 Avoid code repetition in marker-related functions.
1623 * marker.c (attach_marker): New function.
1624 (Fset_marker, set_marker_restricted, set_marker_both)
1625 (set_marker_restricted_both): Use it.
1626 (Fset_marker, set_marker_restricted, Fbuffer_has_markers_at):
1627 Consistently rename charno to charpos.
1628 (marker_position): Add eassert.
1629 (marker_byte_position): Convert to eassert.
1631 2012-07-06 Dmitry Antipov <dmantipov@yandex.ru>
1633 Simplify list operations in unchain_overlay and unchain_marker.
1634 * buffer.c (unchain_overlay): Simplify. Add comment.
1635 * marker.c (unchain_marker): Simplify. Fix comments.
1637 2012-07-06 Dmitry Antipov <dmantipov@yandex.ru>
1639 Introduce fast path for the widely used marker operation.
1640 * alloc.c (build_marker): New function.
1641 * lisp.h (build_marker): New prototype.
1642 * buffer.c (clone_per_buffer_values, Fmake_indirect_buffer): Use it.
1643 * composite.c (autocmp_chars): Likewise.
1644 * editfns.c (buildmark): Remove.
1645 (Fpoint_marker, Fpoint_min_marker, Fpoint_max_marker)
1646 (save_restriction_save): Use build_marker.
1647 * marker.c (buf_charpos_to_bytepos, buf_bytepos_to_charpos): Likewise.
1648 * window.c (save_window_save): Likewise.
1650 2012-07-06 Dmitry Antipov <dmantipov@yandex.ru>
1652 Do not use Fdelete_overlay in delete_all_overlays
1653 to avoid redundant calls to unchain_overlay.
1654 * buffer.c (drop_overlay): New function.
1655 (delete_all_overlays, Fdelete_overlay): Use it.
1656 * minibuf.c (get_minibuffer): Fix comment.
1658 2012-07-06 Paul Eggert <eggert@cs.ucla.edu>
1660 Port to OpenBSD 5.1 amd64.
1661 * sysdep.c [BSD_SYSTEM]: Include <sys/param.h> before <sys/sysctl.h>.
1662 This is needed for OpenBSD, and should be harmless on all BSD systems.
1663 Also, include <sys/sysctl.h>, as it should be available on all
1664 BSD_SYSTEM hosts given that we're already calling sysctl in that case.
1665 (list_system_processes) [__OpenBSD__]: Use DARWIN_OS style mib, but
1666 use p_pid member, not kp_proc.pid.
1668 2012-07-06 Glenn Morris <rgm@gnu.org>
1670 * Makefile.in (emacs$(EXEEXT)): Don't check for load-path shadows.
1672 2012-07-05 Paul Eggert <eggert@cs.ucla.edu>
1674 More xmalloc and related cleanup.
1675 * alloc.c, bidi.c, buffer.c, buffer.h, bytecode.c, callint.c:
1676 * callproc.c, charset.c, coding.c, composite.c, data.c, dispnew.c:
1677 * doc.c, editfns.c, emacs.c, eval.c, fileio.c, filelock.c, fns.c:
1678 * font.c, fontset.c, frame.c, fringe.c, ftfont.c, ftxfont.c, gmalloc.c:
1679 * gtkutil.c, image.c, keyboard.c, keymap.c, lread.c, macros.c, menu.c:
1680 * nsfns.m, nsfont.m, nsmenu.m, nsterm.m, print.c, process.c, ralloc.c:
1681 * regex.c, region-cache.c, scroll.c, search.c, sound.c, syntax.c:
1682 * sysdep.c, term.c, termcap.c, unexmacosx.c, window.c, xdisp.c:
1683 * xfaces.c, xfns.c, xftfont.c, xgselect.c, xmenu.c, xrdb.c, xselect.c:
1685 Omit needless casts involving void * pointers and allocation.
1686 Prefer "P = xmalloc (sizeof *P)" to "P = xmalloc (sizeof (TYPE_OF_P))",
1687 as the former is more robust if P's type is changed.
1688 Prefer xzalloc to xmalloc + memset 0.
1689 Simplify malloc-or-realloc to realloc.
1690 Don't worry about xmalloc returning a null pointer.
1691 Prefer xstrdup to xmalloc + strcpy.
1692 * editfns.c (Fmessage_box): Grow message_text by at least 80 when
1694 * keyboard.c (apply_modifiers_uncached): Prefer local array to
1695 alloca of a constant.
1697 2012-07-05 Eli Zaretskii <eliz@gnu.org>
1699 * xdisp.c (display_line): Fix horizontal pixel coordinates when
1700 hscroll is larger than the line width. Fixes long and futile
1701 looping inside extend_face_to_end_of_line (on a TTY) producing
1702 glyphs that are not needed and thrown away.
1704 2012-07-05 Dmitry Antipov <dmantipov@yandex.ru>
1706 * marker.c (set_marker_restricted_both): Simplify by using
1709 2012-07-05 Paul Eggert <eggert@cs.ucla.edu>
1711 * editfns.c (region_limit): Simplify by using clip_to_bounds.
1713 2012-07-05 Jan Djärv <jan.h.d@swipnet.se>
1715 * gtkutil.c (gtk_scrollbar_new, gtk_box_new): Define when HAVE_GTK3 is
1716 not defined (Bug#11768).
1717 (xg_create_frame_widgets): Use gtk_plug_new_for_display (Bug#11768).
1718 (xg_create_frame_widgets, create_dialog, xg_get_file_with_chooser)
1719 (make_widget_for_menu_item, xg_make_tool_item): Use gtk_box_new
1720 followed by gtk_box_set_homogeneous (Bug#11768).
1721 (xg_update_menu_item): Use GTK_IS_BOX (Bug#11768).
1722 (update_theme_scrollbar_width, xg_create_scroll_bar):
1723 Use gtk_scrollbar_new (Bug#11768).
1724 (xg_event_is_for_scrollbar): Use Gdk Device functions for HAVE_GTK3.
1725 (is_box_type): New function (Bug#11768).
1726 (xg_tool_item_stale_p): Call is_box_type.
1727 (xg_initialize): Get settings by calling gtk_settings_get_for_screen
1728 with default display (Bug#11768).
1730 2012-07-05 Eli Zaretskii <eliz@gnu.org>
1732 * xdisp.c (window_hscroll_limited): New function.
1733 (pos_visible_p, init_iterator): Use it to avoid overflow of pixel
1734 coordinates when window's hscroll is set to insanely large
1737 2012-07-05 Juanma Barranquero <lekktu@gmail.com>
1739 * makefile.w32-in ($(BLD)/dired.$(O), $(BLD)/fileio.$(O)): Fix typo.
1740 ($(BLD)/terminal.$(O), $(BLD)/syntax.$(O)): Update dependencies.
1742 2012-07-05 Dmitry Antipov <dmantipov@yandex.ru>
1745 * lisp.h (xzalloc): New prototype. Omit needless casts.
1746 * alloc.c (xzalloc): New function. Omit needless casts.
1747 * charset.c: Omit needless casts. Convert all calls to
1748 xmalloc with following memset to xzalloc.
1749 * dispnew.c: Likewise.
1750 * fringe.c: Likewise.
1751 * image.c: Likewise.
1752 * sound.c: Likewise.
1754 * w32fns.c: Likewise.
1755 * w32font.c: Likewise.
1756 * w32term.c: Likewise.
1757 * xfaces.c: Likewise.
1759 * xterm.c: Likewise.
1760 * atimer.c: Omit needless casts.
1761 * buffer.c: Likewise.
1762 * callproc.c: Likewise.
1764 * coding.c: Likewise.
1765 * composite.c: Likewise.
1767 * doprnt.c: Likewise.
1768 * editfns.c: Likewise.
1769 * emacs.c: Likewise.
1771 * filelock.c: Likewise.
1773 * gtkutil.c: Likewise.
1774 * keyboard.c: Likewise.
1776 * lread.c: Likewise.
1777 * minibuf.c: Likewise.
1778 * msdos.c: Likewise.
1779 * print.c: Likewise.
1780 * process.c: Likewise.
1781 * region-cache.c: Likewise.
1782 * search.c: Likewise.
1783 * sysdep.c: Likewise.
1784 * termcap.c: Likewise.
1785 * terminal.c: Likewise.
1786 * tparam.c: Likewise.
1787 * w16select.c: Likewise.
1789 * w32reg.c: Likewise.
1790 * w32select.c: Likewise.
1791 * w32uniscribe.c: Likewise.
1792 * widget.c: Likewise.
1793 * xdisp.c: Likewise.
1794 * xmenu.c: Likewise.
1796 * xselect.c: Likewise.
1798 2012-07-05 Paul Eggert <eggert@cs.ucla.edu>
1800 * fileio.c (time_error_value): Check the right error number.
1801 Problem reported by Troels Nielsen in
1802 <http://lists.gnu.org/archive/html/emacs-devel/2012-07/msg00095.html>.
1804 2012-07-04 Paul Eggert <eggert@cs.ucla.edu>
1806 * window.c (set_window_hscroll): Revert the 100000 hscroll limit.
1807 This should be fixed in a better way; see Eli Zaretskii in
1808 <http://lists.gnu.org/archive/html/emacs-devel/2012-07/msg00088.html>.
1809 (HSCROLL_MAX): Remove; this is now internal to set_window_hscroll.
1811 * fileio.c (time_error_value): Rename from special_mtime.
1812 The old name's problems were noted by Eli Zaretskii in
1813 <http://lists.gnu.org/archive/html/emacs-devel/2012-07/msg00087.html>.
1815 * emacs.c (gdb_pvec_type): Change it back to enum pvec_type.
1816 This variable's comment says Emacs needs at least one GDB-visible
1817 symbol of type enum pvec_type, to work around GDB problems.
1818 The symbol's value doesn't matter.
1820 * alloc.c (PSEUDOVECTOR_NBYTES): Remove stray ';'
1821 that causes compilation to fail on pre-C99 compilers.
1823 2012-07-04 Juanma Barranquero <lekktu@gmail.com>
1825 * s/ms-w32.h (LISP_FLOAT_TYPE, HAVE_MEMCMP, HAVE_MEMCPY)
1826 (HAVE_MEMMOVE, HAVE_MEMSET): Don't set, obsolete.
1828 2012-07-04 Dmitry Antipov <dmantipov@yandex.ru>
1830 * buffer.c (init_buffer_once): Fix initialization of
1831 headers for buffer_defaults and buffer_local_symbols.
1832 Reported by Juanma Barranquero <lekktu@gmail.com>.
1834 2012-07-04 Stefan Monnier <monnier@iro.umontreal.ca>
1836 Turn VECTOR_FREE_LIST_FLAG into PVEC_FREE.
1837 * lisp.h (enum pvec_type): Use fewer bits.
1838 (PSEUDOVECTOR_SIZE_BITS): New constant.
1839 (PSEUDOVECTOR_SIZE_MASK, PVEC_TYPE_MASK): Use it.
1840 (XSETPVECTYPESIZE, XSETTYPED_PSEUDOVECTOR, DEFUN): Adapt code to
1841 change in pvec_type.
1842 (PSEUDOVECTOR_TYPEP): New macro.
1843 (TYPED_PSEUDOVECTORP): Use it.
1844 * fns.c (internal_equal): Adapt code to extract pvectype.
1845 * emacs.c (gdb_pvec_type): Update type.
1846 * alloc.c (PSEUDOVECTOR_NBYTES): New macro.
1847 (VECTOR_FREE_LIST_SIZE_MASK): Remove (=> PSEUDOVECTOR_SIZE_MASK).
1848 (VECTOR_FREE_LIST_FLAG): Remove (=> PVEC_FREE).
1849 (SETUP_ON_FREE_LIST): Use XSETPVECTYPESIZE.
1850 (sweep_vectors): Use it. Use local var `total_bytes' instead of
1851 abusing vector->header.next.nbytes.
1852 (live_vector_p): Use PVEC_TYPE.
1853 (mark_object): Adapt code to extract pvectype. Use switch.
1855 2012-07-04 Paul Eggert <eggert@cs.ucla.edu>
1857 * doprnt.c (doprnt): Don't assume string length fits in 'int'.
1858 Tighten new eassert a bit.
1860 2012-07-04 Dmitry Antipov <dmantipov@yandex.ru>
1862 Fix compilation with --enable-gcc-warnings and -O1
1864 * doprnt.c (doprnt): Change type of tem to int, initialize
1865 to avoid compiler warning. Add eassert.
1866 * search.c (simple_search): Initialize match_byte to avoid
1867 compiler warning. Add eassert.
1869 2012-07-04 Paul Eggert <eggert@cs.ucla.edu>
1871 Avoid weird behavior with large horizontal scrolls.
1872 Without this change, for example, large hscroll values would
1873 mess up Emacs's display on Fedora 15 x86, presumably due to
1874 overflows in int calculations in the display code.
1875 Also, if buffers had long lines, Emacs would freeze.
1876 * window.c (HSCROLL_MAX): Reduce to 100000, and make it visible to GDB.
1877 (set_window_hscroll): New function, containing the old guts of
1878 Fset_window_hscroll. Return the clipped value.
1879 (Fset_window_hscroll, Fscroll_left, Fscroll_right): Use it.
1880 This avoids the need to check against PTRDIFF_MAX.
1882 * buffer.c (Fgenerate_new_buffer_name): Fix sprintf format mismatch.
1884 2012-07-04 Dmitry Antipov <dmantipov@yandex.ru>
1886 * buffer.c (Fgenerate_new_buffer_name): Fix type mismatch.
1888 2012-07-04 Paul Eggert <eggert@cs.ucla.edu>
1890 * regex.c: Suppress GCC warning on RHEL 6. (Bug#11207)
1891 Conditionalize the pragmas on GCC 4.5 or later, not GCC 4.3 or later,
1892 since GCC 4.4.6 issues a bogus warning for them.
1894 Fix bugs in file timestamp newness comparisons.
1895 * fileio.c (Ffile_newer_than_file_p):
1896 * lread.c (Fload): Use full timestamp resolution of files,
1897 not just the 1-second resolution, so that files that are only
1898 slightly newer still count as newer.
1899 * fileio.c (Ffile_newer_than_file_p): Don't assume file
1900 timestamps fit in 'int'; this fixes a Y2038 bug on most hosts.
1902 2012-07-03 Paul Eggert <eggert@cs.ucla.edu>
1904 * fileio.c: Improve handling of file time marker. (Bug#11852)
1905 (special_mtime): New function.
1906 (Finsert_file_contents, Fverify_visited_file_modtime):
1907 Use it to set special mtime values consistently.
1909 2012-07-03 Andreas Schwab <schwab@linux-m68k.org>
1911 * fileio.c (Finsert_file_contents): Properly handle st_mtime
1912 marker for non-existing file. (Bug#11852)
1914 2012-07-03 Glenn Morris <rgm@gnu.org>
1916 * lisp.h (Fread_file_name): Restore EXFUN (it's not a normal DEFUN
1917 and did not make it into globals.h).
1919 2012-07-03 Tom Tromey <tromey@redhat.com>
1921 * window.c (Fset_window_margins, Fset_window_fringes)
1922 (Fset_window_scroll_bars, Fset_window_vscroll): No longer static.
1923 * textprop.c (Fprevious_property_change): No longer static.
1924 * syntax.c (Fsyntax_table_p): No longer static.
1925 * process.c (Fget_process, Fprocess_datagram_address): No longer
1927 * keymap.c (Flookup_key, Fcopy_keymap): No longer static.
1928 * keyboard.c (Fcommand_execute): No longer static.
1930 * insdel.c (Fcombine_after_change_execute): No longer static.
1931 * image.c (Finit_image_library): No longer static.
1932 * fileio.c (Fmake_symbolic_link): No longer static.
1933 * eval.c (Ffetch_bytecode): No longer static.
1934 * editfns.c (Fuser_full_name): No longer static.
1935 * doc.c (Fdocumentation_property, Fsnarf_documentation):
1937 * buffer.c (Fset_buffer_major_mode, Fdelete_overlay): No longer
1939 * dired.c (Ffile_attributes): No longer static.
1940 * composite.c (Fcomposition_get_gstring): No longer static.
1941 * callproc.c (Fgetenv_internal): No longer static.
1943 * ccl.h: Remove EXFUNs.
1944 * buffer.h: Remove EXFUNs.
1945 * dispextern.h: Remove EXFUNs.
1946 * intervals.h: Remove EXFUNs.
1947 * fontset.h: Remove EXFUN.
1948 * font.h: Remove EXFUNs.
1949 * dosfns.c (system_process_attributes): Remove EXFUN.
1950 * keymap.h: Remove EXFUNs.
1951 * lisp.h: Remove EXFUNs.
1952 * w32term.h: Remove EXFUNs.
1953 * window.h: Remove EXFUNs.
1954 * xsettings.h: Remove EXFUN.
1955 * xterm.h: Remove EXFUN.
1957 2012-07-03 Glenn Morris <rgm@gnu.org>
1959 * lisp.h (Frandom): Make it visible to C.
1960 * buffer.c (Fgenerate_new_buffer_name): Speed up finding a new
1961 buffer for invisible buffers. (Bug#1229)
1963 2012-07-03 Dmitry Antipov <dmantipov@yandex.ru>
1965 Fix block vector allocation code to allow VECTOR_BLOCK_SIZE
1966 values which aren't power of 2.
1967 * alloc.c (VECTOR_FREE_LIST_SIZE_MASK): New macro. Verify
1968 it's value and the value of VECTOR_BLOCK_SIZE. Adjust users
1971 2012-07-03 Stefan Monnier <monnier@iro.umontreal.ca>
1973 * lisp.h (Lisp_Misc, Lisp_Fwd): Move around to group better.
1975 * alloc.c (mark_object): Revert part of last patch to use `switch'.
1977 2012-07-03 Dmitry Antipov <dmantipov@yandex.ru>
1979 * alloc.c (allocate_vector_block): Remove redundant
1980 calls to mallopt if DOUG_LEA_MALLOC is defined.
1981 (allocate_vectorlike): If DOUG_LEA_MALLOC is defined,
1982 avoid calls to mallopt if zero_vector is returned.
1984 2012-07-03 Dmitry Antipov <dmantipov@yandex.ru>
1986 * alloc.c (check_string_bytes): If GC_CHECK_STRING_BYTES
1987 is enabled, avoid dereferencing NULL current_sblock if
1990 2012-07-03 Dmitry Antipov <dmantipov@yandex.ru>
1992 Cleanup basic buffer management.
1993 * buffer.h (struct buffer): Change layout to use generic vector
1994 marking code. Fix some comments. Change type of 'clip_changed'
1995 to bitfield. Remove unused #ifndef old.
1996 (FIRST_FIELD_PER_BUFFER, LAST_FIELD_PER_BUFFER): Remove.
1997 (GET_OVERLAYS_AT): Fix indentation.
1998 (for_each_per_buffer_object_at): New macro.
1999 * buffer.c (clone_per_buffer_values, reset_buffer_local_variables)
2000 (Fbuffer_local_variables): Use it.
2001 (init_buffer_once, syms_of_buffer): Remove unused #ifndef old.
2002 * alloc.c (allocate_buffer): Adjust to match new layout of
2003 struct buffer. Fix comment.
2004 (mark_overlay): New function.
2005 (mark_buffer): Use it. Use mark_vectorlike to mark normal
2006 Lisp area of struct buffer.
2007 (mark_object): Use it. Adjust marking of misc objects
2008 and related comments.
2010 2012-07-02 Paul Eggert <eggert@cs.ucla.edu>
2012 * alloc.c (mark_object): Remove "#ifdef GC_CHECK_MARKED_OBJECTS"
2013 wrapper that is not needed because the wrapped code is a no-op (zero
2014 machine instructions) when GC_CHECK_MARKED_OBJECTS is not defined.
2015 This avoids a -Wunused-macros diagnostic with GCC 4.7.1 x86-64.
2017 2012-07-02 Dmitry Antipov <dmantipov@yandex.ru>
2019 * alloc.c (mark_buffer): Simplify. Remove prototype.
2020 (mark_object): Add comment. Reorganize marking of vector-like
2021 objects. Use CHECK_LIVE for all vector-like objects except buffers
2022 and subroutines when GC_CHECK_MARKED_OBJECTS is defined. Avoid
2023 redundant calls to mark_vectorlike for bool vectors.
2025 2012-06-30 Glenn Morris <rgm@gnu.org>
2027 * nsterm.m (ns_init_paths): Ignore site-lisp if --no-site-lisp.
2029 * epaths.in (PATH_SITELOADSEARCH): New.
2030 * lread.c (init_lread): Use PATH_SITELOADSEARCH.
2031 This is rather than relying on --enable-locallisppath elements
2032 having "site-lisp" in their names. (Bug#10208#25, 11658)
2034 2012-06-30 Eli Zaretskii <eliz@gnu.org>
2036 * w32proc.c (sys_select): Accept and ignore one more argument.
2038 * w32.c (emacs_gnutls_pull): Call select with one more argument.
2040 * sysselect.h [DOS_NT]: Don't include sys/select.h.
2041 (pselect) [!MS_DOS]: Redirect to sys_select.
2043 * sysdep.c: Don't include dos.h and dosfns.h.
2045 * process.c (sys_select):
2046 * msdos.c (sys_select): Accept one more argument and ignore it.
2048 * msdos.c (event_timestamp, sys_select): Use gnulib's gettime;
2049 adapt data types and code to that.
2052 * msdos.c (gettime, settime): Define away the prototypes in dos.h,
2053 which clashes with the gnulib function of the same name.
2055 2012-06-30 Andreas Schwab <schwab@linux-m68k.org>
2057 * font.c (font_style_to_value, font_style_symbolic)
2058 (font_prop_validate_style): Add type checks for values in
2061 * lisp.h (CHECK_RANGED_INTEGER): Make value to check the first
2063 * character.c, charset.c, menu.c, process.c, window.c: Adjust all
2066 2012-06-29 Eli Zaretskii <eliz@gnu.org>
2068 * xdisp.c (try_window_id): Undo last change.
2070 * w32.c (getwd): Adjust commentary about startup_dir.
2071 (init_environment): Always call sys_access, even in non-MSVC
2072 builds. Don't chdir to the directory of the Emacs executable.
2073 This undoes code from 1997 which was justified by the need to
2074 "avoid conflicts when removing and renaming directories". But its
2075 downside was that every relative file name was being interpreted
2076 relative to the directory of the Emacs executable, which can never
2077 be TRT. In particular, it broke sys_access when called with
2078 relative file names.
2079 (sys_access): Map GetLastError to errno.
2081 2012-06-29 Dmitry Antipov <dmantipov@yandex.ru>
2083 * window.h (struct window): Change type of 'fringes_outside_margins'
2084 to bitfield. Fix comment. Adjust users accordingly.
2085 (struct window): Change type of 'window_end_bytepos' to ptrdiff_t.
2087 * xdisp.c (try_window_id): Change type of 'first_vpos' and 'vpos'
2090 2012-06-29 Andreas Schwab <schwab@linux-m68k.org>
2092 * gnutls.c (emacs_gnutls_handshake):
2093 Add QUIT to make the loop interruptible.
2095 2012-06-29 Glenn Morris <rgm@gnu.org>
2097 * charset.c (init_charset): Make lack of etc/charsets fatal.
2099 2012-06-29 Dmitry Antipov <dmantipov@yandex.ru>
2101 * editfns.c (region_limit): Fix type mismatch.
2103 2012-06-29 Dmitry Antipov <dmantipov@yandex.ru>
2105 * nsfns.m: Fix GLYPH_DEBUG usage assuming that it may be
2106 undefined. Convert from xassert to eassert.
2107 * nsmenu.m: Convert from xassert to eassert.
2108 * nsterm.m: Likewise.
2110 2012-06-28 Stefan Monnier <monnier@iro.umontreal.ca>
2112 * editfns.c (region_limit): Clip to narrowing (bug#11770).
2114 2012-06-28 Paul Eggert <eggert@cs.ucla.edu>
2116 Avoid integer overflow on scroll-left and scroll-right.
2117 * window.c (HSCROLL_MAX): New macro.
2118 (Fscroll_left, Fscroll_right): Avoid undefined behavior on integer
2119 overflow when requested scroll falls outside ptrdiff_t range.
2121 2012-06-28 Dmitry Antipov <dmantipov@yandex.ru>
2123 * window.h (struct window): Change type of 'hscroll',
2124 'min_hscroll' and 'last_point' from Lisp_Object to ptrdiff_t,
2125 'last_modified' and 'last_overlay_modified' to EMACS_INT.
2126 Adjust users accordingly.
2127 * xdisp.c (try_cursor_movement): Replace type check with eassert.
2128 * window.c (Fscroll_left, Fscroll_right): Change type of 'hscroll'
2129 from EMACS_INT to ptrdiff_t.
2130 (make_window): Omit redundant initialization.
2132 2012-06-28 Juanma Barranquero <lekktu@gmail.com>
2134 * makefile.w32-in ($(BLD)/regex.$(O)): Update dependencies.
2136 2012-06-28 Dmitry Antipov <dmantipov@yandex.ru>
2138 * window.h (struct window): Change type of 'use_time' and
2139 'sequence_number' from Lisp_Object to int.
2140 * frame.c (make_frame): Adjust users accordingly.
2141 * print.c (print_object): Likewise.
2142 * window.c (select_window, Fwindow_use_time, make_parent_window)
2143 (make_window): Likewise.
2145 2012-06-28 Dmitry Antipov <dmantipov@yandex.ru>
2147 * dispextern.h (GLYPH_DEBUG): Now defined in config.h if
2148 enabled with --enable-checking=[all,glyphs] configure option.
2149 Fix GLYPH_DEBUG usage assuming that it may be undefined,
2150 adjust comments accordingly.
2151 * dispnew.c: Fix GLYPH_DEBUG usage assuming that it may be
2152 undefined, adjust comments accordingly.
2153 * image.c: Likewise.
2154 * scroll.c: Likewise.
2155 * w32fns.c: Likewise.
2156 * w32term.c: Likewise.
2157 * xdisp.c: Likewise.
2158 * xfaces.c: Likewise.
2160 * xterm.c: Likewise.
2162 2012-06-28 Dmitry Antipov <dmantipov@yandex.ru>
2164 Generalize run-time debugging checks.
2165 * dispextern.h (XASSERTS): Remove.
2166 * fontset.c (xassert): Remove.
2167 Convert from xassert to eassert.
2168 * alloc.c: Convert from xassert to eassert.
2170 * dispnew.c: Likewise.
2172 * fringe.c: Likewise.
2173 * ftfont.c: Likewise.
2174 * gtkutil.c: Likewise.
2175 * image.c: Likewise.
2176 * keyboard.c: Likewise.
2178 * process.c: Likewise.
2179 * scroll.c: Likewise.
2180 * sound.c: Likewise.
2182 * w32console.c: Likewise.
2183 * w32fns.c: Likewise.
2184 * w32term.c: Likewise.
2185 * window.c: Likewise.
2186 * xdisp.c: Likewise.
2187 * xfaces.c: Likewise.
2189 * xselect.c: Likewise.
2190 * xterm.c: Likewise.
2192 2012-06-27 Stefan Monnier <monnier@iro.umontreal.ca>
2194 * fns.c (maybe_resize_hash_table): Output message when growing the
2197 2012-06-27 Dmitry Antipov <dmantipov@yandex.ru>
2199 * alloc.c (allocate_string_data): Remove dead code.
2200 * xsettings.c (XSETTINGS_FONT_NAME): Move under HAVE_XFT to
2201 avoid GCC warning about unused macro.
2203 2012-06-27 Dmitry Antipov <dmantipov@yandex.ru>
2205 * alloc.c (allocate_string): Omit intervals initialization.
2206 * alloc.c (make_uninit_multibyte_string): Initialize intervals
2207 as in make_pure_string and make_pure_c_string.
2209 2012-06-27 Dmitry Antipov <dmantipov@yandex.ru>
2211 * alloc.c (allocate_string): Fix last change.
2213 2012-06-27 Dmitry Antipov <dmantipov@yandex.ru>
2215 * alloc.c (allocate_string): Remove two redundant calls
2216 to memset, add explicit initialization where appropriate.
2218 2012-06-27 Glenn Morris <rgm@gnu.org>
2220 * lisp.mk (lisp): Remove paths.elc.
2222 2012-06-27 Chong Yidong <cyd@gnu.org>
2224 * doc.c (Fsubstitute_command_keys): Fix punctuation.
2226 2012-06-26 John Wiegley <johnw@newartisans.com>
2228 * unexmacosx.c (copy_data_segment): Add two section names used
2229 on Mac OS X Lion: __mod_init_func and __mod_term_func.
2231 * alloc.c (mark_memory): Do not check with -faddress-sanitizer
2232 when building with Clang.
2234 2012-06-26 Stefan Monnier <monnier@iro.umontreal.ca>
2236 * eval.c (Fapply): Allow calling it with a single argument.
2238 2012-06-26 Eli Zaretskii <eliz@gnu.org>
2240 * s/ms-w32.h (strcasecmp, strncasecmp) [_MSC_VER]: Redirect to
2241 _stricmp and _strnicmp.
2242 (HAVE_STRCASECMP, HAVE_STRNCASECMP): Define to 1.
2244 2012-06-26 Dmitry Antipov <dmantipov@yandex.ru>
2246 * alloc.c (allocate_window): Zero out non-Lisp part of newly
2248 (allocate_process): Likewise for new process.
2249 (allocate_terminal): Change to use offsetof.
2250 (allocate_frame): Likewise.
2251 * frame.c (make_frame): Omit redundant initialization.
2252 * window.c (make_parent_window): Use memset.
2253 (make_window): Omit redundant initialization.
2254 * process.c (make_process): Omit redundant initialization.
2255 * terminal.c (create_terminal): Likewise.
2257 2012-06-26 Dmitry Antipov <dmantipov@yandex.ru>
2259 * term.c (delete_tty): Remove redundant call to memset.
2261 2012-06-26 Dmitry Antipov <dmantipov@yandex.ru>
2263 * alloc.c: Remove build_string.
2264 * lisp.h: Define build_string as static inline. This provides
2265 a better opportunity to optimize away calls to strlen when the
2266 function is called with compile-time constant argument.
2267 * image.c (imagemagick_error): Convert to build_string.
2268 * w32proc.c (sys_spawnve): Likewise.
2269 * xterm.c (x_term_init): Likewise.
2271 2012-06-26 Paul Eggert <eggert@cs.ucla.edu>
2273 Use sprintf return value instead of invoking strlen on result.
2274 In the old days this wasn't portable, since some sprintf
2275 implementations returned char *. But they died out years ago and
2276 Emacs already assumes sprintf returns int.
2277 Similarly for float_to_string.
2278 This patch speeds up (number-to-string 1000) by 3% on Fedora 15 x86-64.
2279 * ccl.c (ccl_driver):
2280 * character.c (string_escape_byte8):
2281 * data.c (Fnumber_to_string):
2282 * doprnt.c (doprnt):
2283 * print.c (print_object):
2284 * xdisp.c (message_dolog):
2285 * xfns.c (syms_of_xfns):
2286 Use sprintf or float_to_string result to avoid need to call strlen.
2287 * data.c (Fnumber_to_string):
2288 Use make_unibyte_string, since the string must be ASCII.
2289 * lisp.h, print.c (float_to_string): Now returns int length.
2290 * term.c (produce_glyphless_glyph):
2291 Use sprintf result rather than recomputing it.
2293 Clean out last vestiges of the old HAVE_CONFIG_H stuff.
2294 * Makefile.in (ALL_CFLAGS):
2295 * makefile.w32-in (LOCAL_FLAGS): Remove -DHAVE_CONFIG_H.
2296 * gmalloc.c, regex.c: Include <config.h> unconditionally.
2298 2012-06-25 Dmitry Antipov <dmantipov@yandex.ru>
2300 * dispextern.h (xstrcasecmp): Define to library function
2301 strcasecmp if available.
2302 * xfaces.c: Do not use xstrcasecmp if strcasecmp is available.
2304 2012-06-25 Andreas Schwab <schwab@linux-m68k.org>
2306 * keyboard.c (menu_bar_items, menu_bar_item, read_key_sequence):
2307 Avoid comma operator.
2308 * menu.c (push_submenu_start, push_submenu_end)
2309 (push_left_right_boundary, push_menu_pane): Likewise.
2310 * msdos.c (dos_rawgetc): Likewise.
2312 2012-06-25 Dmitry Antipov <dmantipov@yandex.ru>
2314 * xfns.c (xic_create_fontsetname): Remove redundant calls
2317 2012-06-25 Paul Eggert <eggert@cs.ucla.edu>
2319 * gtkutil.c (get_utf8_string): Remove redundant assignment.
2320 sprintf already null-terminates its output.
2322 * xfns.c (x_window): Remove redundant cast.
2324 2012-06-25 Dmitry Antipov <dmantipov@yandex.ru>
2326 * xmenu.c (xmenu_show, xdialog_show): Explicit cast from
2327 `const char *' to `char *' to avoid compiler warning.
2329 2012-06-24 Paul Eggert <eggert@cs.ucla.edu>
2331 * xterm.c (x_term_init): Build proper-sized _XSETTINGS_Snnn string
2332 instead of truncating it to 63 (admittedly a generous limit).
2334 * process.c: Fix spelling and caps in comments.
2336 2012-06-24 Dan Nicolaescu <dann@ics.uci.edu>
2338 * emacs.c (setpgrp): Remove definition, unused.
2339 * sysdep.c (setpgrp): Remove definition, not used in this file.
2341 2012-06-24 Juanma Barranquero <lekktu@gmail.com>
2343 * makefile.w32-in: Update dependencies.
2345 2012-06-24 Eli Zaretskii <eliz@gnu.org>
2347 * makefile.w32-in (TIMESPEC_H): Remove nt/inc/sys/time.h.
2348 (SYSTIME_H): Add nt/inc/sys/time.h.
2350 * systime.h [WINDOWSNT]: Include sys/time.h.
2352 * s/ms-w32.h (struct timespec): Definition moved from
2353 nt/inc/sys/time.h. Suggested by Paul Eggert <eggert@cs.ucla.edu>.
2355 2012-06-24 Paul Eggert <eggert@cs.ucla.edu>
2357 Switch from NO_RETURN to C11's _Noreturn (Bug#11750).
2358 * buffer.h (buffer_slot_type_mismatch):
2359 * data.c (arith_error) [!FORWARD_SIGNAL_TO_MAIN_THREAD]:
2360 * eval.c (unwind_to_catch):
2361 * image.c (my_png_error, my_error_exit):
2362 * keyboard.c (quit_throw_to_read_char, user_error)
2363 (Fexit_recursive_edit, Fabort_recursive_edit):
2364 * lisp.h (die, args_out_of_range, args_out_of_range_3)
2365 (wrong_type_argument, buffer_overflow, __executable_start)
2366 (memory_full, buffer_memory_full, string_overflow, Fthrow)
2367 (xsignal, xsignal0, xsignal1, xsignal2, xsignal3, signal_error)
2368 (error, verror, nsberror, report_file_error, Ftop_level, Fkill_emacs)
2370 (child_setup) [!DOS_NT]:
2371 * lread.c (end_of_file_error, invalid_syntax):
2372 * process.c (send_process_trap) [!FORWARD_SIGNAL_TO_MAIN_THREAD]:
2373 * puresize.h (pure_write_error):
2374 * search.c (matcher_overflow):
2375 * sound.c (sound_perror, alsa_sound_perror):
2376 * sysdep.c, syssignal.h (croak):
2377 * term.c (maybe_fatal, vfatal):
2378 * textprop.c (text_read_only):
2379 * undo.c (user_error):
2380 * unexmacosx.c (unexec_error):
2381 * xterm.c (x_ins_del_lines, x_delete_glyphs):
2382 Use _Noreturn rather than NO_RETURN.
2383 No need for separate decl merely because of _Noreturn.
2384 * sound.c (sound_warning, parse_sound):
2385 Remove unnecessary forward decls.
2387 2012-06-24 Paul Eggert <eggert@cs.ucla.edu>
2389 Fix bug when time_t is unsigned and as wide as intmax_t (Bug#9000).
2390 * lisp.h (WAIT_READING_MAX): New macro.
2391 * dispnew.c (Fsleep_for, sit_for):
2392 * keyboard.c (kbd_buffer_get_event):
2393 * process.c (Faccept_process_output):
2394 Use it to avoid bogus compiler warnings with obsolescent GCC versions.
2395 This improves on the previous patch, which introduced a bug
2396 when time_t is unsigned and as wide as intmax_t.
2397 See <http://bugs.gnu.org/9000#51>.
2399 2012-06-23 Eli Zaretskii <eliz@gnu.org>
2401 * dispnew.c (sit_for, Fsleep_for):
2402 * keyboard.c (kbd_buffer_get_event):
2403 * process.c (Faccept_process_output): Avoid compiler warnings when
2404 comparing a 32-bit time_t with a 64-bit INTMAX_MAX.
2406 2012-06-23 Juanma Barranquero <lekktu@gmail.com>
2408 * makefile.w32-in: Update dependencies.
2410 * w32.c (ltime): Add return type and declare static.
2411 (w32_get_internal_run_time): Remove usused variable `time_100ns'.
2413 2012-06-23 Paul Eggert <eggert@cs.ucla.edu>
2415 * sysdep.c [__FreeBSD__]: Fix more recently-introduced typos.
2416 Privately reported by Herbert J. Skuhra.
2417 (make_lisp_timeval) [__FreeBSD__]: Rename from TIMELIST.
2419 (system_process_attributes) [__FreeBSD__]: Invoke make_lisp_time,
2420 not make_lisp_timeval, when the argument is of type EMACS_TIME.
2422 2012-06-23 Eli Zaretskii <eliz@gnu.org>
2424 * w32proc.c (Fw32_get_locale_info): Fix an off-by-one error in
2425 last argument of make_unibyte_string.
2427 * keyboard.c (kbd_buffer_get_event): Include the codepage and the
2428 language ID in the event parameters.
2430 * w32term.c (w32_read_socket): Put the new keyboard codepage into
2431 event.code, not the obscure "character set ID".
2433 2012-06-23 Chong Yidong <cyd@gnu.org>
2435 * xmenu.c (x_menu_wait_for_event): Adapt GTK3 to new xg_select.
2437 2012-06-23 Eli Zaretskii <eliz@gnu.org>
2439 Fix the MS-Windows build broken by 2012-06-22T21:17:42Z!eggert@cs.ucla.edu.
2440 * w32.c (fdutimens): New function.
2442 * w32proc.c (sys_select): Adapt to change in the EMACS_TIME type.
2444 * s/ms-w32.h (pselect): Redirect to sys_select.
2446 * sysselect.h [WINDOWSNT]: Don't include sys/select.h.
2448 * ralloc.c (r_alloc_inhibit_buffer_relocation): Fix stupid thinko
2449 in the logic of incrementing and decrementing the value of
2450 use_relocatable_buffers.
2452 2012-06-23 Paul Eggert <eggert@cs.ucla.edu>
2454 * sysdep.c [__FreeBSD__]: Fix recently-introduced typos.
2455 Privately reported by Herbert J. Skuhra.
2456 [__FreeBSD__]: Remove "*/" typo after "#include".
2457 (timeval_to_EMACS_TIME) [__FreeBSD__]: New static function.
2458 (TIMEVAL) [__FreeBSD__]: Now a static function rather than a macro.
2459 (TIMEVAL, system_process_attributes) [__FreeBSD__]:
2460 Don't assume EMACS_TIME and struct timeval are the same type.
2462 2012-06-22 Paul Eggert <eggert@cs.ucla.edu>
2464 Support higher-resolution time stamps (Bug#9000).
2465 The time stamps are only nanosecond-resolution at the C level,
2466 since that's the best that any real-world system supports now.
2467 But they are picosecond-resolution at the Lisp level, as that's
2468 easy, and leaves room for future OS improvements.
2470 * Makefile.in (LIB_CLOCK_GETTIME): New macro.
2473 * alloc.c (Fgarbage_collect): Port to higher-res time stamps.
2474 Don't get current time unless it's needed.
2476 * atimer.c: Include <sys/time.h> unconditionally, since gnulib
2477 now provides it if it's absent.
2478 (start_atimer): Port to higher-res time stamps.
2479 Check for time stamp overflow. Don't get current time more
2480 often than is needed.
2482 * buffer.h (struct buffer): Buffer modtime now has high resolution.
2483 Include systime.h, not time.h.
2484 (NONEXISTENT_MODTIME_NSECS, UNKNOWN_MODTIME_NSECS): New macros.
2486 * dired.c: Include stat-time.h.
2487 (Ffile-attributes): File times now have higher resolution.
2489 * dispextern.h [HAVE_WINDOW_SYSTEM]: Include systime.h.
2490 (struct image): Timestamp now has higher resolution.
2492 * dispnew.c (PERIODIC_PREEMPTION_CHECKING): Remove, as Emacs always
2493 has at least microseconds now. All uses removed.
2494 (update_frame, update_single_window, update_window, update_frame_1)
2495 (Fsleep_for, sit_for): Port to higher-resolution time stamps.
2497 * editfns.c (time_overflow): Now extern.
2498 (Fcurrent_time, Fget_internal_run_time, make_time, lisp_time_argument)
2499 (float-time, Fformat_time_string, Fcurrent_time_string)
2500 (Fcurrent_time_zone): Accept and generate higher-resolution
2502 (make_time_tail, make_lisp_time, dissassemble_lisp_time)
2503 (decode_time_components, lisp_seconds_argument): New functions.
2504 (make_time): Now static.
2505 (lisp_time_argument): Now returns EMACS_TIME. New arg ppsec.
2506 Report an error if the time is invalid, rather than having the caller
2509 * fileio.c: Include <stat-time.h>
2510 (Fcopy_file): Copy higher-resolution time stamps.
2511 Prefer to set the time stamp via a file descriptor if that works.
2512 (Fset_file_times, Finsert_file_contents, Fwrite_region)
2513 (Fverify_visited_file_modtime, Fclear_visited_file_modtime)
2514 (Fvisited_file_modtime, Fset_visited_file_modtime):
2515 Support higher-resolution time stamps.
2517 * fns.c (Frandom): Use nanoseconds, not microseconds, for seed.
2519 * gtkutil.c (xg_maybe_add_timer): Port to higher-res time stamps.
2521 * image.c (prepare_image_for_display, clear_image_cache)
2522 (lookup_image): Port to higer-resolution time stamps.
2524 * keyboard.c (start_polling, bind_polling_period):
2525 Check for time stamp overflow.
2526 (read_char, kbd_buffer_get_event, timer_start_idle)
2527 (timer_stop_idle, timer_resume_idle, timer_check_2, timer_check)
2528 (Fcurrent_idle_time, init_keyboard, set_waiting_for_input):
2529 Port to higher-resolution time stamps. Do not assume time_t is signed.
2530 (decode_timer): New function. Timers are now vectors of length 9,
2531 not 8, to accommodate the picosecond component.
2532 (timer_check_2): Use it.
2534 * nsterm.m (select_timeout, timeval_subtract): Remove.
2535 (ns_timeout): Use Emacs's facilities for time stamp arithmetic,
2536 as they're a bit more accurate and handle overflow better.
2537 (ns_select): Change prototype to be compatible with pselect.
2538 (ns_select, ns_term_shutdown): Port to ns-resolution time stamps.
2539 * nsterm.h (ns_select): Adjust prototype.
2541 * msdos.c (EMACS_TIME_ZERO_OR_NEG_P): Remove, as it assumes
2542 us-resolution time stamps.
2543 (sys_select): Use the new EMACS_TIME_SIGN macro instead.
2545 * lread.c (read_filtered_event): Port to ns-resolution time stamps.
2547 * lisp.h (time_overflow): New decl.
2548 (wait_reading_process_output): First arg is now intmax_t, not int,
2549 to accommodate larger waits.
2551 * process.h (struct Lisp_Process.read_output_delay):
2552 Now counts nanoseconds, not microseconds.
2553 * process.c (ADAPTIVE_READ_BUFFERING): Don't worry about
2555 (READ_OUTPUT_DELAY_INCREMENT, Faccept_process_output)
2556 (wait_reading_process_output):
2557 Port to ns-resolution time stamps.
2558 (Faccept_process_output, wait_reading_process_output):
2559 Check for time stamp overflow. Do not assume time_t is signed.
2560 (select_wrapper): Remove; we now use pselect.
2561 (Fprocess_attributes): Now generates ns-resolution time stamps.
2563 * sysdep.c: Include utimens.h. Don't include utime.h
2564 or worry about struct utimbuf; gnulib does that for us now.
2565 (gettimeofday): Remove; gnulib provides a substitute.
2566 (make_timeval): New function.
2567 (set_file_times): Now sets ns-resolution time stamps.
2568 New arg FD; all uses changed.
2569 (time_from_jiffies, ltime_from_jiffies, get_up_time)
2570 (system_process_attributes):
2571 Now returns ns-resolution time stamp. All uses changed.
2572 Check for time stamp overflow.
2574 * sysselect.h: Don't depend on HAVE_SYS_SELECT_H; gnulib
2575 provides a substitute now.
2577 * systime.h: Include timespec.h rather than sys/time.h and time.h,
2578 since it guarantees struct timespec.
2579 (EMACS_TIME): Now struct timespec, so that we can support
2580 ns-resolution time stamps.
2581 (EMACS_TIME_RESOLUTION, LOG10_EMACS_TIME_RESOLUTION): New macros.
2582 (EMACS_HAS_USECS): Remove; Emacs always has sub-second time stamps now.
2583 (EMACS_USECS): Remove.
2584 (EMACS_SET_USECS): The underlying time stamp now has ns resolution,
2585 so multiply the arg by 1000 before storing it.
2586 (EMACS_NSECS, EMACS_SECS_ADDR, EMACS_SET_NSECS, EMACS_SET_SECS_NSECS):
2588 (EMACS_GET_TIME, EMACS_ADD_TIME, EMACS_SUB_TIME):
2589 Port to ns-resolution time stamps.
2590 (EMACS_TIME_NEG_P): Remove; replaced by....
2591 (EMACS_TIME_SIGN): New macro.
2592 (EMACS_SET_INVALID_TIME, EMACS_TIME_VALID_P)
2593 (EMACS_TIME_FROM_DOUBLE, EMACS_TIME_TO_DOUBLE): New macros.
2594 (set_file_times, make_time, lisp_time_argument): Adjust signature.
2595 (make_timeval, make_lisp_time, decode_time_components): New decls.
2596 (EMACS_TIME_CMP): Remove; no longer used. Plus, it was buggy, in
2597 that it mishandled time_t overflow. You can't compare by subtracting!
2598 (EMACS_TIME_EQ, EMACS_TIME_NE, EMACS_TIME_GT, EMACS_TIME_GE)
2599 (EMACS_TIME_LT, EMACS_TIME_LE): Rewrite in terms of timespec_cmp.
2601 * term.c: Include <sys/time.h>.
2602 (timeval_to_Time): New function, for proper overflow wraparound.
2603 (term_mouse_position, term_mouse_click): Use it.
2605 * undo.c (record_first_change): Support higher-resolution time stamps
2607 (Fprimitive_undo): Use them when restoring time stamps.
2609 * w32.c (ltime, U64_TO_LISP_TIME, process_times, emacs_gnutls_pull)
2610 (w32_get_internal_run_time):
2611 Port to higher-resolution Emacs time stamps.
2612 (ltime): Now accepts single 64-bit integer, as that's more convenient
2615 * xdisp.c (start_hourglass): Port to ns-resolution time stamps.
2617 * xgselect.c, xgselect.h (xg_select): Add sigmask argument,
2618 for compatibility with pselect. Support ns-resolution time stamps.
2620 * xmenu.c (x_menu_wait_for_event): Support ns-resolution time stamps.
2622 * xselect.c (wait_for_property_change, x_get_foreign_selection):
2623 Check for time stamp overflow, and support ns-resolution time stamps.
2625 * xterm.c: Don't include sys/time.h; gnulib does that for us now.
2626 Don't worry about whether HAVE_TIMEVAL and HAVE_SELECT are set.
2627 (timeval_subtract): Remove; no longer needed.
2628 (XTflash, XTring_bell, x_wait_for_event):
2629 Port to ns-resolution time stamps. Don't assume time_t is signed.
2631 2012-06-22 Chong Yidong <cyd@gnu.org>
2633 * xdisp.c (x_consider_frame_title): Revert last change.
2635 2012-06-22 Eli Zaretskii <eliz@gnu.org>
2637 * alloc.c (NSTATICS): Enlarge to 0x650. Otherwise, Emacs compiled
2638 with -DENABLE_CHECKING -DXASSERTS -DGLYPH_DEBUG=1 -DBYTE_CODE_METER
2639 aborts in staticpro during startup. (Without -DBYTE_CODE_METER,
2640 staticidx goes up to 1597 out of 1600 = 0x640.)
2642 2012-06-20 Paul Eggert <eggert@cs.ucla.edu>
2644 * fileio.c (Fdefault_file_modes): Block input while fiddling with umask.
2645 Otherwise, the umask might be mistakenly 0 while handling input signals.
2647 2012-06-19 Stefan Monnier <monnier@iro.umontreal.ca>
2649 * minibuf.c (Fread_string): Bind minibuffer-completion-table.
2651 2012-06-19 Dmitry Antipov <dmantipov@yandex.ru>
2653 * alloc.c, bytecode.c, ccl.c, coding.c, composite.c, data.c, dosfns.c:
2654 * font.c, image.c, keyboard.c, lread.c, menu.c, minibuf.c, msdos.c:
2655 * print.c, syntax.c, window.c, xmenu.c, xselect.c: Replace direct
2656 access to `contents' member of Lisp_Vector objects with AREF and ASET
2659 2012-06-19 Chong Yidong <cyd@gnu.org>
2661 * frame.c (delete_frame): When selecting a frame on a different
2662 text terminal, do not alter the terminal's top-frame.
2664 * xdisp.c (format_mode_line_unwind_data): Record the target
2665 frame's selected window and its terminal's top-frame.
2666 (unwind_format_mode_line): Restore them.
2667 (x_consider_frame_title, display_mode_line, Fformat_mode_line):
2669 (x_consider_frame_title): Do not condition on HAVE_WINDOW_SYSTEM,
2670 since tty frames can be explicitly named.
2671 (prepare_menu_bars): Likewise.
2673 * term.c (Ftty_top_frame): New function.
2675 2012-06-18 Paul Eggert <eggert@cs.ucla.edu>
2677 Port byte-code-meter to modern targets.
2678 * bytecode.c (METER_CODE) [BYTE_CODE_METER]: Don't assume
2679 !CHECK_LISP_OBJECT_TYPE && !USE_LSB_TAG. Problem with
2680 CHECK_LISP_OBJECT_TYPE reported by Dmitry Antipov in
2681 <http://lists.gnu.org/archive/html/emacs-devel/2012-06/msg00282.html>.
2682 (METER_1, METER_2): Simplify.
2684 2012-06-18 Stefan Monnier <monnier@iro.umontreal.ca>
2686 * data.c (Fdefalias): Return `symbol' (bug#11686).
2688 2012-06-18 Martin Rudalics <rudalics@gmx.at>
2690 * buffer.c (Fkill_buffer): Don't throw an error when the buffer
2691 gets killed during executing of this function (Bug#11665).
2692 Try to always return Qt when the buffer has been actually killed.
2693 (Vkill_buffer_query_functions): In doc-string say that functions
2694 run by this hook should not change the current buffer.
2696 2012-06-18 Paul Eggert <eggert@cs.ucla.edu>
2698 Fix recently-introduced process.c problems found by static checking.
2699 * process.c (write_queue_push, write_queue_pop, send_process):
2700 Use ptrdiff_t, not int or EMACS_INT, for buffer lengths and offsets.
2701 (write_queue_pop): Fix pointer signedness problem.
2702 (send_process): Remove unused local.
2704 2012-06-17 Chong Yidong <cyd@gnu.org>
2706 * xdisp.c (redisplay_internal): No need to redisplay terminal
2707 frames that are not on top.
2709 2012-06-17 Troels Nielsen <bn.troels@gmail.com>
2711 * process.c (make_process): Initialize write_queue.
2712 (write_queue_push, write_queue_pop): New functions.
2713 (send_process): Use them to maintain correct ordering of process
2716 2012-06-17 Paul Eggert <eggert@cs.ucla.edu>
2718 * lisp.h (eassert): Assume C89 or later.
2719 This removes the need for CHECK.
2720 (CHECK): Remove. Its comments about always evaluating its
2721 argument were confusing, as 'eassert' typically does not evaluate
2724 * coding.c (produce_chars): Use ptrdiff_t, not int.
2726 * xterm.c (x_draw_underwave): Check for integer overflow.
2727 This pacifies gcc 4.7.0 -Wunsafe-loop-optimizations on x86-64.
2729 2012-06-17 Jan Djärv <jan.h.d@swipnet.se>
2731 * nsterm.m (x_free_frame_resources): Move xfree so freed memory isn't
2732 referenced (Bug#11583).
2734 2012-06-16 Aurelien Aptel <aurelien.aptel@gmail.com>
2736 Implement wave-style variant of underlining.
2737 * dispextern.h (face_underline_type): New enum.
2738 (face): Add field for underline type.
2739 * nsterm.m (ns_draw_underwave): New function.
2740 (ns_draw_text_decoration): Use it.
2741 * w32term.c (w32_restore_glyph_string_clip, w32_draw_underwave):
2743 (x_draw_glyph_string): Use them.
2744 * xfaces.c (Qline, Qwave): New Lisp objects.
2745 (check_lface_attrs, merge_face_ref)
2746 (Finternal_set_lisp_face_attribute, realize_x_face):
2747 Handle wave-style underline face attributes.
2748 * xterm.c (x_draw_underwave): New function.
2749 (x_draw_glyph_string): Use it.
2751 2012-06-16 Juanma Barranquero <lekktu@gmail.com>
2753 * makefile.w32-in ($(BLD)/emacs.$(O), $(BLD)/fringe.$(O))
2754 ($(BLD)/xml.$(O), $(BLD)/intervals.$(O), $(BLD)/macros.$(O))
2755 ($(BLD)/minibuf.$(O), $(BLD)/regex.$(O), $(BLD)/region-cache.$(O))
2756 ($(BLD)/textprop.$(O), $(BLD)/undo.$(O), $(BLD)/window.$(O))
2757 ($(BLD)/w32select.$(O)): Update dependencies.
2759 2012-06-16 Andreas Schwab <schwab@linux-m68k.org>
2761 * buffer.h (FETCH_MULTIBYTE_CHAR): Define as inline.
2762 (BUF_FETCH_MULTIBYTE_CHAR): Likewise.
2763 * character.c (_fetch_multibyte_char_p): Remove.
2764 * alloc.c: Include "character.h" before "buffer.h".
2766 * buffer.c: Likewise.
2767 * bytecode.c: Likewise.
2768 * callint.c: Likewise.
2769 * callproc.c: Likewise.
2770 * casefiddle.c: Likewise.
2771 * casetab.c: Likewise.
2772 * category.c: Likewise.
2774 * coding.c: Likewise.
2775 * composite.c: Likewise.
2776 * dired.c: Likewise.
2777 * dispnew.c: Likewise.
2779 * dosfns.c: Likewise.
2780 * editfns.c: Likewise.
2781 * emacs.c: Likewise.
2782 * fileio.c: Likewise.
2783 * filelock.c: Likewise.
2785 * fontset.c: Likewise.
2786 * fringe.c: Likewise.
2787 * indent.c: Likewise.
2788 * insdel.c: Likewise.
2789 * intervals.c: Likewise.
2790 * keyboard.c: Likewise.
2791 * keymap.c: Likewise.
2792 * lread.c: Likewise.
2793 * macros.c: Likewise.
2794 * marker.c: Likewise.
2795 * minibuf.c: Likewise.
2796 * nsfns.m: Likewise.
2797 * nsmenu.m: Likewise.
2798 * print.c: Likewise.
2799 * process.c: Likewise.
2800 * regex.c: Likewise.
2801 * region-cache.c: Likewise.
2802 * search.c: Likewise.
2803 * syntax.c: Likewise.
2805 * textprop.c: Likewise.
2807 * unexsol.c: Likewise.
2808 * w16select.c: Likewise.
2809 * w32fns.c: Likewise.
2810 * w32menu.c: Likewise.
2811 * window.c: Likewise.
2812 * xdisp.c: Likewise.
2814 * xmenu.c: Likewise.
2816 * xselect.c: Likewise.
2818 2012-06-16 Eli Zaretskii <eliz@gnu.org>
2820 * xdisp.c (set_cursor_from_row): Don't dereference glyphs_end.
2821 If all the glyphs of the glyph row came from strings, and we have no
2822 cursor positioning clues, put the cursor on the first glyph of the
2824 (handle_face_prop): Use chunk-relative overlay string index when
2825 indexing into it->string_overlays array. (Bug#11653)
2826 (set_cursor_from_row): Use the leftmost glyph as GLYPH_BEFORE, not
2827 the rightmost. (Bug#11720)
2829 2012-06-16 Andreas Schwab <schwab@linux-m68k.org>
2831 * category.h (CHAR_HAS_CATEGORY): Define as inline.
2832 (CATEGORY_MEMBER): Enforce 1/0 value.
2833 * category.c (_temp_category_set): Remove.
2835 2012-06-16 Eli Zaretskii <eliz@gnu.org>
2837 * window.c (Fdelete_other_windows_internal)
2838 (Fdelete_window_internal): Don't access frame's mouse highlight
2839 info of the initial frame. (Bug#11677)
2841 2012-06-14 Paul Eggert <eggert@cs.ucla.edu>
2843 * .gdbinit (xgetint): Fix recently-introduced paren typo.
2844 Assume USE_2_TAGS_FOR_INTS.
2845 (xreload): Adjust $tagmask width to match recent lisp.h change.
2847 Simplify lisp.h in minor ways that should not affect code.
2848 * lisp.h (USE_2_TAGS_FOR_INTS): Remove, as it was always defined.
2849 (LISP_INT_TAG, case_Lisp_Int, LISP_STRING_TAG, LISP_INT_TAG_P)
2850 (LISP_INT1_TAG, enum Lisp_Type, XINT, XUINT, make_number):
2851 Simplify under the assumption that USE_2_TAGS_FOR_INTS is defined.
2852 (INTTYPEBITS): New macro, for clarity.
2853 (INTMASK, MOST_POSITIVE_FIXNUM): Use it.
2854 (LISP_INT1_TAG, LISP_STRING_TAG, LISP_INT_TAG_P):
2855 Simplify now that USE_LSB_TAG is always defined.
2856 (TYPEMASK, XINT) [USE_LSB_TAG]: Remove unnecessary cast.
2857 (make_number) [!USE_LSB_TAG]: Use INTMASK; that's simpler.
2859 2012-06-13 Juanma Barranquero <lekktu@gmail.com>
2861 * makefile.w32-in ($(BLD)/data.$(O)): Update dependencies.
2863 2012-06-13 Glenn Morris <rgm@gnu.org>
2865 * s/bsd-common.h (BSD4_3):
2866 * s/usg5-4-common.h (USG5_4): No longer define; unused.
2868 2012-06-13 Andreas Schwab <schwab@linux-m68k.org>
2870 * lisp.h (Lisp_Object) [CHECK_LISP_OBJECT_TYPE]: Define as struct
2873 (XHASH, XTYPE, XINT, XUINT, make_number, XSET, XPNTR, XUNTAG):
2875 * emacs.c (gdb_use_struct): Rename from gdb_use_union.
2876 * .gdbinit: Check gdb_use_struct instead of gdb_use_union.
2877 * alloc.c (widen_to_Lisp_Object): Remove.
2878 (mark_memory): Use XIL instead of widen_to_Lisp_Object.
2879 * frame.c (delete_frame): Remove outdated comment.
2880 * w32fns.c (Fw32_register_hot_key): Use XLI instead of checking
2881 USE_LISP_UNION_TYPE.
2882 (Fw32_unregister_hot_key): Likewise.
2883 (Fw32_toggle_lock_key): Likewise.
2884 * w32menu.c (add_menu_item): Likewise.
2885 (w32_menu_display_help): Use XIL instead of checking
2886 USE_LISP_UNION_TYPE.
2887 * w32heap.c (allocate_heap): Don't check USE_LISP_UNION_TYPE.
2888 (init_heap): Likewise.
2889 * w32term.c (w32_read_socket): Update comment.
2891 2012-06-13 Glenn Morris <rgm@gnu.org>
2893 * s/usg5-4-common.h, src/s/unixware.h:
2894 Remove define/undef of HAVE_SYSV_SIGPAUSE (not used since 2010-05-04).
2896 * s/gnu.h (POSIX_SIGNALS): Remove (not used since 2010-05-04).
2898 2012-06-13 Paul Eggert <eggert@cs.ucla.edu>
2900 USE_LISP_UNION_TYPE + USE_LSB_TAG cleanup (Bug#11604)
2901 * alloc.c (make_number) [!defined make_number]:
2902 Remove, as lisp.h always defines this now.
2903 (mark_maybe_pointer): Simplify since USE_LSB_TAG is always defined now.
2904 (roundup_size): Verify that it is a power of 2.
2905 * data.c (Fmake_variable_buffer_local, Fmake_local_variable):
2906 * ftfont.c (ftfont_driver): Use LISP_INITIALLY_ZERO.
2907 * lisp.h (USE_LSB_TAG): Allow the builder to compile with
2908 -DUSE_LSB_TAG=0, to override the automatically-selected default.
2909 USE_LSB_TAG now is always defined to be either 0 or 1.
2911 (union Lisp_Object): Don't worry about WORDS_BIGENDIAN; the
2912 code works fine either way, and efficiency is not a concern here,
2913 as the union type is for debugging, not for production.
2914 (LISP_MAKE_RVALUE, make_number) [USE_LISP_UNION_TYPE]:
2915 Use an inline function on all platforms when using the union type,
2916 since this is simpler and 'static inline' can be used portably
2918 (LISP_INITIALLY_ZERO): New macro.
2919 (XFASTINT, XSETFASTINT) [USE_LISP_UNION_TYPE]: Remove.
2920 (XSET) [USE_LISP_UNION_TYPE]: Don't overparenthesize.
2922 2012-06-12 Glenn Morris <rgm@gnu.org>
2924 * s/gnu-kfreebsd.h, s/hpux11.h, s/openbsd.h, s/sol2-10.h: Remove files.
2926 * s/gnu-linux.h (HAVE_PROCFS): Move to configure.
2928 * s/hpux10-20.h, s/openbsd.h, s/usg5-4-common.h:
2929 Move BROKEN_SIGIO to configure.
2931 * s/bsd-common.h, s/darwin.h, s/gnu-kfreebsd.h, s/hpux10-20.h:
2932 Move NO_TERMIO to configure.
2934 2012-06-12 Chong Yidong <cyd@gnu.org>
2936 * image.c (imagemagick_load_image): Use MagickFlattenImage if
2937 MagickMergeImageLayers is undefined. Use pixel pusher loop if
2938 MagickExportImagePixels is undefined.
2940 2012-06-12 Paul Eggert <eggert@cs.ucla.edu>
2942 * image.c (imagemagick_load_image): Remove unused label.
2944 2012-06-11 Glenn Morris <rgm@gnu.org>
2946 * s/aix4-2.h, s/bsd-common.h, s/cygwin.h, s/darwin.h:
2947 * s/gnu-kfreebsd.h, s/gnu-linux.h, s/gnu.h, s/hpux10-20.h:
2948 * s/irix6-5.h, s/ms-w32.h, s/msdos.h, s/template.h:
2949 * s/usg5-4-common.h: Move SYSTEM_TYPE to configure.
2951 2012-06-11 Stefan Monnier <monnier@iro.umontreal.ca>
2953 * alloc.c (make_byte_code): New function.
2954 (Fmake_byte_code): Use it. Don't purify here.
2955 * lread.c (read1): Use it as well to avoid extra allocation.
2957 2012-06-11 Chong Yidong <cyd@gnu.org>
2959 * image.c (imagemagick_load_image): Implement transparency.
2961 2012-06-10 Andreas Schwab <schwab@linux-m68k.org>
2963 * regex.c (at_begline_loc_p): Also recognize `(?N:' and correctly
2964 account for preceding backslashes. (Bug#11663)
2966 2012-06-09 Chong Yidong <cyd@gnu.org>
2968 * term.c: Support italics in capable terminals (Bug#9652).
2969 (no_color_bit): Replace unused NC_BLINK with NC_ITALIC.
2970 (turn_on_face): Output using TS_enter_italic_mode if available.
2971 Don't handle unused blinking and alt-charset cases.
2972 (turn_off_face): Handle italic case; discard unused tty_blinking_p
2973 and tty_alt_charset_p cases.
2974 (tty_capable_p, init_tty): Support italics.
2976 * termchar.h (struct tty_display_info): Add field for italics.
2977 Remove unused blink field.
2979 * xfaces.c (tty_supports_face_attributes_p, realize_tty_face):
2982 * dispextern.h: Replace unused TTY_CAP_BLINK with TTY_CAP_ITALIC.
2983 (struct face): Remove unused fields tty_dim_p, tty_blinking_p, and
2984 tty_alt_charset_p. Add tty_italic_p.
2986 2012-06-09 Michael Albinus <michael.albinus@gmx.de>
2988 * dbusbind.c (XD_BASIC_DBUS_TYPE): Use dbus_type_is_valid and
2989 dbus_type_is_basic if available.
2990 (xd_extract_signed, xd_extract_unsigned): Rename from
2991 extract_signed and extract_unsigned, respectively. Adapt callers.
2993 2012-06-09 Chong Yidong <cyd@gnu.org>
2995 * xfaces.c (face_for_overlay_string): Handle face remapping (Bug#2066).
2997 * fringe.c (Fset_fringe_bitmap_face): Handle the noninteractive
3000 2012-06-08 Paul Eggert <eggert@cs.ucla.edu>
3002 * xdisp.c (vmessage): Treat frame message as multibyte.
3003 Without this change, (let ((§ 1)) (make-variable-buffer-local '§))
3004 would generate the diagnostic "Making \302\247 buffer-local while
3007 2012-06-08 Eli Zaretskii <eliz@gnu.org>
3009 * dispnew.c (showing_window_margins_p): Undo last change, which
3010 was done due to an inadvertent commit.
3011 (adjust_frame_glyphs_for_frame_redisplay): Do call
3012 showing_window_margins_p.
3014 2012-06-08 Stefan Monnier <monnier@iro.umontreal.ca>
3016 * eval.c (Fmake_var_non_special): New primitive.
3017 (syms_of_eval): Defsubr it.
3018 * lread.c (syms_of_lread): Mark `values' as lexically scoped.
3020 2012-06-08 Juanma Barranquero <lekktu@gmail.com>
3022 * dispnew.c (showing_window_margins_p): Wrap in #if 0 to prevent unused
3023 function warning (the only call is inside #if 0 since 2012-06-08T08:44:45Z!eliz@gnu.org).
3025 2012-06-08 Eli Zaretskii <eliz@gnu.org>
3027 * alloc.c (allocate_vectorlike): Fix last change.
3029 2012-06-08 Dmitry Antipov <dmantipov@yandex.ru>
3031 Block-based vector allocation of small vectors.
3032 * lisp.h (struct vectorlike_header): New field `nbytes',
3033 adjust comment accordingly.
3034 * alloc.c (enum mem_type): New type `MEM_TYPE_VECTOR_BLOCK'
3035 to denote vector blocks. Adjust users (live_vector_p,
3036 mark_maybe_pointer, valid_lisp_object_p) accordingly.
3037 (COMMON_MULTIPLE): Move outside #if USE_LSB_TAG.
3038 (VECTOR_BLOCK_SIZE, vroundup, VECTOR_BLOCK_BYTES),
3039 (VBLOCK_BYTES_MIN, VBLOCK_BYTES_MAX, VECTOR_MAX_FREE_LIST_INDEX),
3040 (VECTOR_FREE_LIST_FLAG, ADVANCE, VINDEX, SETUP_ON_FREE_LIST),
3041 (VECTOR_SIZE, VECTOR_IN_BLOCK): New macros.
3042 (roundup_size): New constant.
3043 (struct vector_block): New data type.
3044 (vector_blocks, vector_free_lists, zero_vector): New variables.
3045 (all_vectors): Rename to `large_vectors'.
3046 (allocate_vector_from_block, init_vectors, allocate_vector_from_block)
3047 (sweep_vectors): New functions.
3048 (allocate_vectorlike): Return `zero_vector' as the only vector of
3049 0 items. Allocate new vector from block if vector size is less than
3050 or equal to VBLOCK_BYTES_MAX.
3051 (Fgarbage_collect): Move all vector sweeping code to sweep_vectors.
3052 (init_alloc_once): Add call to init_vectors.
3054 2012-06-08 Stefan Monnier <monnier@iro.umontreal.ca>
3056 * eval.c (Fmacroexpand): Stop if the macro returns the same form.
3058 2012-06-07 Paul Eggert <eggert@cs.ucla.edu>
3060 * doprnt.c (doprnt): Truncate multibyte char correctly.
3061 Without this change, doprnt (buf, 2, "%s", FORMAT_END, AP)
3062 would mishandle a string argument "Xc" if X was a multibyte
3063 character of length 2: it would truncate after X's first byte
3064 rather than including all of X.
3066 2012-06-06 Chong Yidong <cyd@gnu.org>
3068 * buffer.c (word_wrap): Doc fix.
3070 2012-06-04 Paul Eggert <eggert@cs.ucla.edu>
3072 * xdisp.c (note_mode_line_or_margin_highlight): Pacify gcc -Wall.
3074 2012-06-03 Glenn Morris <rgm@gnu.org>
3076 * xdisp.c (tool-bar-style): Doc fix.
3078 2012-06-03 Ulrich Müller <ulm@gentoo.org>
3080 * Makefile.in (PAXCTL): Define.
3081 (temacs$(EXEEXT)): Disable memory randomization for the temacs
3082 binary via PaX flags if the paxctl utility is available.
3083 (emacs$(EXEEXT), bootstrap-emacs$(EXEEXT)):
3084 Restore PaX flags to their default. (Bug#11398)
3086 2012-06-03 Chong Yidong <cyd@gnu.org>
3088 * xdisp.c (decode_mode_spec_coding): Display a space for a unibyte
3091 2012-06-03 Chong Yidong <cyd@gnu.org>
3093 * xdisp.c (calc_pixel_width_or_height): Use Fbuffer_local_value.
3094 (note_mode_line_or_margin_highlight): If there is no help echo,
3095 use mode-line-default-help-echo. Handle the case where the mouse
3096 position is past the end of the mode line string.
3098 * buffer.c (buffer_local_value_1): New function, split from
3099 Fbuffer_local_value; can return Qunbound.
3100 (Fbuffer_local_value): Use it.
3101 (Vmode_line_format): Docstring tweaks.
3103 2012-06-02 Paul Eggert <eggert@cs.ucla.edu>
3105 * sysdep.c (system_process_attributes): Improve comment.
3107 2012-06-02 Stefan Monnier <monnier@iro.umontreal.ca>
3109 * keyboard.c: Export real-this-command to Elisp.
3110 (syms_of_keyboard): Rename real_this_command to Vreal_this_command
3111 and DEFVAR it. Update all users.
3113 2012-06-02 Paul Eggert <eggert@cs.ucla.edu>
3115 * minibuf.c (Fassoc_string): Remove duplicate declaration.
3117 * sysdep.c (system_process_attributes) [SOLARIS2 && HAVE_PROCFS]:
3118 Convert pctcpu and pctmem to Lisp float properly.
3119 Let the compiler fold better, as 100.0/0x8000 is exact.
3121 2012-06-02 Andreas Schwab <schwab@linux-m68k.org>
3123 * alloc.c (CONS_BLOCK_SIZE): Account for padding at the end of
3126 2012-06-01 Paul Eggert <eggert@cs.ucla.edu>
3128 * xfns.c (x_set_tool_bar_lines) [USE_GTK]: Adjust to bitfield change.
3130 2012-06-01 Dmitry Antipov <dmantipov@yandex.ru>
3132 For a 'struct window', replace some Lisp_Object fields to
3133 bitfields where appropriate, remove unused fields.
3134 * window.h (struct window): Remove unused 'last_mark_x' and
3135 'last_mark_y' fields. Rename 'mini_p' field to 'mini',
3136 change it's type from Lisp_Object to bitfield.
3137 Change type of 'force_start', 'optional_new_start',
3138 'last_had_star', 'update_mode_line' and 'start_at_line_beg'
3139 fields from Lisp_Object to bitfield. Adjust users accordingly.
3141 2012-05-31 Paul Eggert <eggert@cs.ucla.edu>
3143 Pacify gcc -Wdouble-precision when using Xaw.
3144 * xterm.c (xaw_jump_callback, x_set_toolkit_scroll_bar_thumb)
3145 [HAVE_X_WINDOWS && USE_TOOLKIT_SCROLL_BARS && !USE_MOTIF && !USE_GTK]:
3146 Use 'float' consistently, rather than 'float' in most places
3147 and 'double' in a couple of places.
3149 2012-05-31 Eli Zaretskii <eliz@gnu.org>
3151 * xdisp.c (handle_stop): Detect whether we have overlay strings
3152 loaded by testing it->current.overlay_string_index to be
3153 non-negative, instead of checking whether n_overlay_strings is
3154 positive. (Bug#11587)
3156 2012-05-31 Chong Yidong <cyd@gnu.org>
3158 * keymap.c (describe_map_tree): Revert 2011-07-07 change (Bug#1169).
3160 * doc.c (Fsubstitute_command_keys): Doc fix.
3162 2012-05-31 Eli Zaretskii <eliz@gnu.org>
3164 * search.c (search_buffer): Remove calls to
3165 r_alloc_inhibit_buffer_relocation, as it is now called by
3166 maybe_unify_char, which was the cause of relocation of buffer text
3169 2012-05-31 Eli Zaretskii <eliz@gnu.org>
3171 * charset.c (maybe_unify_char): Inhibit relocation of buffer text
3172 for the duration of call to load_charset, to avoid problems with
3173 callers of maybe_unify_char that access buffer text through C
3176 * ralloc.c (r_alloc_inhibit_buffer_relocation): Increment and
3177 decrement the inhibition flag, instead of just setting or
3180 2012-05-31 Paul Eggert <eggert@cs.ucla.edu>
3182 Remove obsolete '#define static' cruft.
3183 * s/hpux10-20.h (_FILE_OFFSET_BITS): Don't #undef.
3184 This #undef was "temporary" in 2000; it is no longer needed
3185 now that '#define static' has gone away.
3186 * xfns.c, xterm.h (gray_bitmap_width, gray_bitmap_height)
3187 (gray_bitmap_bits): Remove; no longer needed.
3188 All uses replaced with definiens.
3189 * xterm.c: Include "bitmaps/gray.xbm".
3191 2012-05-30 Paul Eggert <eggert@cs.ucla.edu>
3193 Clean up __executable_start, monstartup when --enable-profiling.
3194 The following changes affect the code only when profiling.
3195 * dispnew.c (__executable_start): Rename from safe_bcopy.
3196 Define only on platforms that need it.
3197 * emacs.c: Include <sys/gmon.h> when profiling.
3198 (_mcleanup): Remove decl, since <sys/gmon.h> does it now.
3199 (__executable_start): Remove decl, since lisp.h does it now.
3200 (safe_bcopy): Remove decl; no longer has that name.
3201 (main): Coalesce #if into single bit of code, for simplicity.
3202 Cast pointers to uintptr_t, since standard libraries want integers
3204 * lisp.h (__executable_start): New decl.
3206 2012-05-31 Glenn Morris <rgm@gnu.org>
3208 * image.c (Fimagemagick_types): Doc fix.
3210 2012-05-30 Jim Meyering <meyering@redhat.com>
3212 * callproc.c (Fcall_process_region): Include directory component
3213 in mkstemp error message (Bug#11586).
3215 2012-05-30 Paul Eggert <eggert@cs.ucla.edu>
3217 * alloc.c, lisp.h (make_pure_vector): Now static.
3219 2012-05-30 Stefan Monnier <monnier@iro.umontreal.ca>
3221 * eval.c (Fdefun, Fdefmacro, Vmacro_declaration_function):
3222 Move to byte-run.el.
3223 (Fautoload): Do the hash-doc more carefully.
3224 * data.c (Fdefalias): Purify definition, except for keymaps.
3225 (Qdefun): Move from eval.c.
3226 * lisp.h (Qdefun): Remove.
3227 * lread.c (read1): Tiny simplification.
3229 2012-05-29 Troels Nielsen <bn.troels@gmail.com>
3231 Do not create empty overlays with the evaporate property (Bug#9642).
3232 * buffer.c (Fmove_overlay): Reinstate the earlier fix for
3233 Bug#9642, but explicitly check that the buffer the overlay would
3234 be moved to is live and rearrange lines to make sure that errors
3235 will not put the overlay in an inconsistent state.
3236 (Fdelete_overlay): Cosmetics.
3238 2012-05-28 Eli Zaretskii <eliz@gnu.org>
3240 * w32term.c (my_bring_window_to_top): New function.
3241 (x_raise_frame): Use handle returned by DeferWindowPos, which
3242 could be different from the original one.
3243 Call my_bring_window_to_top instead of my_set_foreground_window.
3246 * w32fns.c (w32_wnd_proc): Accept and process WM_EMACS_BRINGTOTOP
3247 by calling BringWindowToTop.
3249 * w32term.h (WM_EMACS_BRINGTOTOP): New message.
3250 (WM_EMACS_END): Increase by one.
3252 2012-05-28 Paul Eggert <eggert@cs.ucla.edu>
3254 * bidi.c (bidi_mirror_char): Put eassert before conversion to int.
3255 This avoids undefined behavior that might cause the eassert
3256 to not catch an out-of-range value.
3258 2012-05-28 Juanma Barranquero <lekktu@gmail.com>
3260 * makefile.w32-in ($(BLD)/w32inevt.$(O), $(BLD)/w32console.$(O)):
3261 Update dependencies.
3263 2012-05-27 Eli Zaretskii <eliz@gnu.org>
3265 * bidi.c (bidi_mirror_char): Fix last change.
3267 2012-05-27 Andreas Schwab <schwab@linux-m68k.org>
3269 * unexmacosx.c (copy_data_segment): Truncate after 16 characters
3270 when referring to sectname field in printf format.
3272 2012-05-27 Paul Eggert <eggert@cs.ucla.edu>
3274 * lisp.h [REL_ALLOC]: Omit duplicate prototypes.
3275 Only r_alloc_inhibit_buffer_relocation needed to be added;
3276 the others were already declared.
3278 * bidi.c (bidi_mirror_char): Don't possibly truncate the integer
3279 before checking whether it's out of range. Put the check inside
3281 <http://lists.gnu.org/archive/html/emacs-devel/2012-05/msg00485.html>.
3283 2012-05-27 Ken Brown <kbrown@cornell.edu>
3285 * callproc.c (Fcall_process): Restore a line that was accidentally
3286 commented out in the 2011-02-13 change (bug#11547).
3288 2012-05-27 Eli Zaretskii <eliz@gnu.org>
3290 * lisp.h [REL_ALLOC]: Add prototypes for external functions
3291 defined on ralloc.c.
3293 * buffer.c [REL_ALLOC]: Remove prototypes of
3294 r_alloc_reset_variable, r_alloc, r_re_alloc, and r_alloc_free,
3295 they are now on lisp.h.
3297 * ralloc.c (r_alloc_inhibit_buffer_relocation): New function.
3299 * search.c (search_buffer): Use it to inhibit relocation of buffer
3300 text while re_search_2 is doing its job, because re_search_2 is
3301 passed C pointers to buffer text. (Bug#11519)
3303 * msdos.c (internal_terminal_init) <Vwindow_system_version>:
3306 * xdisp.c (move_it_to): Under MOVE_TO_Y, when restoring iterator
3307 state after an additional call to move_it_in_display_line_to, keep
3308 the values of it->max_ascent and it->max_descent found for the
3310 (pos_visible_p): Revert the comparison against bottom_y to what it
3311 was in revid eliz@gnu.org-20120513182235-4p6386j761ld0nwb.
3314 2012-05-26 Paul Eggert <eggert@cs.ucla.edu>
3316 Fix coding-related core dumps with gcc -ftrapv.
3317 The code was computing A - B, where A and B are pointers, and B is
3318 random garbage. This can lead to core dumps on platforms that
3319 have special pointer registers, and it also leads to core dumps on
3320 x86-64 when compiled with gcc -ftrapv. The fix is to compute
3321 A - B only when B is initialized properly.
3322 * coding.c (coding_set_source, coding_set_destination): Return void.
3323 (coding_change_source, coding_change_destinations): New functions,
3324 with the old behaviors of coding_set_source and coding_set_destination.
3325 All callers that need an offset changed to use these new functions.
3327 2012-05-26 Glenn Morris <rgm@gnu.org>
3329 * nsterm.m (ns_init_paths): Don't mess with INFOPATH. (Bug#2791)
3331 2012-05-26 Eli Zaretskii <eliz@gnu.org>
3333 Extend mouse support on W32 text-mode console.
3334 * xdisp.c (draw_row_with_mouse_face):
3335 Call tty_draw_row_with_mouse_face for WINDOWSNT as well.
3337 * w32console.c: Include window.h.
3338 (w32con_write_glyphs_with_face, tty_draw_row_with_mouse_face):
3340 (initialize_w32_display): Initialize mouse-highlight data.
3342 * w32inevt.c: Include termchar.h and window.h.
3343 (do_mouse_event): Support mouse-autoselect-window. When the mouse
3344 moves, call note_mouse_highlight. If help_echo changed, call
3345 gen_help_event to produce help-echo message in the echo area.
3346 Call clear_mouse_face if mouse_face_hidden is set in the mouse
3349 2012-05-26 Paul Eggert <eggert@cs.ucla.edu>
3351 * lread.c (read1): Simplify slightly to avoid an overflow warning
3352 with GCC 4.7.0 on x86-64.
3354 2012-05-26 Eli Zaretskii <eliz@gnu.org>
3356 * bidi.c (bidi_mirror_char): Revert last change: an int is
3357 definitely wide enough here.
3359 2012-05-25 Paul Eggert <eggert@cs.ucla.edu>
3361 Fix integer width and related bugs (Bug#9874).
3362 * alloc.c (pure_bytes_used_lisp, pure_bytes_used_non_lisp):
3363 (allocate_vectorlike, buffer_memory_full, struct sdata, SDATA_SIZE)
3364 (string_bytes, check_sblock, allocate_string_data):
3365 (compact_small_strings, Fmake_bool_vector, make_string)
3366 (make_unibyte_string, make_multibyte_string)
3367 (make_string_from_bytes, make_specified_string)
3368 (allocate_vectorlike, Fmake_vector, find_string_data_in_pure)
3369 (make_pure_string, make_pure_c_string, make_pure_vector, Fpurecopy)
3371 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3372 (allocate_pseudovector):
3373 Use int, not EMACS_INT, where int is wide enough.
3374 (inhibit_garbage_collection, Fgarbage_collect):
3375 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3376 * bidi.c (bidi_mirror_char): Use EMACS_INT, not int, where
3377 int might not be wide enough.
3378 (bidi_cache_search, bidi_cache_find, bidi_init_it)
3379 (bidi_count_bytes, bidi_char_at_pos, bidi_fetch_char)
3380 (bidi_at_paragraph_end, bidi_find_paragraph_start)
3381 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak)
3382 (bidi_level_of_next_char, bidi_move_to_visually_next):
3383 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3384 * buffer.c (copy_overlays, Fgenerate_new_buffer_name)
3385 (Fkill_buffer, Fset_buffer_major_mode)
3386 (advance_to_char_boundary, Fbuffer_swap_text)
3387 (Fset_buffer_multibyte, overlays_at, overlays_in)
3388 (overlay_touches_p, struct sortvec, record_overlay_string)
3389 (overlay_strings, recenter_overlay_lists)
3390 (adjust_overlays_for_insert, adjust_overlays_for_delete)
3391 (fix_start_end_in_overlays, fix_overlays_before, modify_overlay)
3392 (Fmove_overlay, Fnext_overlay_change, Fprevious_overlay_change)
3393 (Foverlay_recenter, last_overlay_modification_hooks_used)
3394 (report_overlay_modification, evaporate_overlays, enlarge_buffer_text):
3395 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3396 (validate_region): Omit unnecessary test for b <= e,
3397 since that's guaranteed by the previous test.
3398 (adjust_overlays_for_delete): Avoid pos + length overflow.
3399 (Fmove_overlay, Fdelete_overlay, add_overlay_mod_hooklist)
3400 (report_overlay_modification):
3401 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3402 (Foverlays_at, Fnext_overlay_change, Fprevious_overlay_change):
3403 Omit pointer cast, which isn't needed anyway, and doesn't work
3404 after the EMACS_INT -> ptrdiff_t change.
3405 (Fmove_overlay): Clip BEG and END to ptrdiff_t to avoid overflow.
3406 * buffer.h: Adjust decls to match defn changes elsewhere.
3407 (struct buffer_text, struct buffer):
3408 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3409 Use EMACS_INT, not int, where int might not be wide enough.
3410 * bytecode.c (unmark_byte_stack, exec_byte_code): Use ptrdiff_t,
3411 not int, to avoid needless 32-bit limit on 64-bit hosts.
3412 (exec_byte_code): Use tighter memory-full test, one that checks
3413 for alloca overflow. Don't compute the address of the object just
3414 before an array, as that's not portable. Use EMACS_INT, not
3415 ptrdiff_t or int, where ptrdiff_t or int might not be wide enough.
3416 * callint.c (Fcall_interactively):
3417 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3418 * callproc.c (call_process_kill, Fcall_process):
3419 Don't assume pid_t fits into an Emacs fixnum.
3420 (call_process_cleanup, Fcall_process, child_setup):
3421 Don't assume pid_t fits into int.
3422 (call_process_cleanup, Fcall_process, delete_temp_file)
3423 (Fcall_process_region):
3424 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3425 (Fcall_process): Simplify handling of volatile integers.
3426 Use int, not EMACS_INT, where int will do.
3427 * casefiddle.c (casify_object, casify_region, operate_on_word)
3428 (Fupcase_word, Fdowncase_word, Fcapitalize_word):
3429 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3430 (casify_object): Avoid integer overflow when overallocating buffer.
3431 * casetab.c (set_identity, shuffle): Prefer int to unsigned when
3432 either works. Use lint_assume to convince GCC 4.6.1 that it's OK.
3433 * category.c (Fchar_category_set): Don't assume fixnum fits in int.
3434 * category.h (CATEGORYP): Don't assume arg is nonnegative.
3435 * ccl.c (GET_CCL_INT): Remove; no longer needed, since the
3436 integers are now checked earlier. All uses replaced with XINT.
3438 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3439 For CCL_MapSingle, check that content and value are in int range.
3440 (ccl_driver, Fregister_code_conversion_map):
3441 Check that Vcode_version_map_vector is a vector.
3442 (resolve_symbol_ccl_program): Check that vector header is in range.
3443 Always copy the vector, so that we can check its contents reliably
3444 now rather than having to recheck each instruction as it's being
3445 executed. Check that vector words fit in 'int'.
3446 (ccl_get_compiled_code, Fregister_ccl_program)
3447 (Fregister_code_conversion_map): Use ptrdiff_t, not int, for
3448 program indexes, to avoid needless 32-bit limit on 64-bit hosts.
3449 (Fccl_execute, Fccl_execute_on_string): Check that initial reg
3450 contents are in range.
3451 (Fccl_execute_on_string): Check that status is in range.
3452 * ccl.h (struct ccl_program.idx): Now ptrdiff_t, not int.
3453 * character.c (char_resolve_modifier_mask, Fchar_resolve_modifiers):
3454 Accept and return EMACS_INT, not int, because callers can pass values
3456 (c_string_width, strwidth, lisp_string_width, chars_in_text)
3457 (multibyte_chars_in_text, parse_str_as_multibyte)
3458 (str_as_multibyte, count_size_as_multibyte, str_to_multibyte)
3459 (str_as_unibyte, str_to_unibyte, string_count_byte8)
3460 (string_escape_byte8, Fget_byte):
3461 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3462 (Funibyte_string): Use CHECK_RANGED_INTEGER, not CHECK_NATNUM, to
3463 avoid mishandling large integers.
3464 * character.h: Adjust decls to match defn changes elsewhere.
3465 * charset.c (load_charset_map_from_file, find_charsets_in_text)
3466 (Ffind_charset_region):
3467 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3468 (load_charset_map_from_file): Redo idx calculation to avoid overflow.
3469 (load_charset_map_from_vector, Fdefine_charset_internal):
3470 Don't assume fixnum fits in int.
3471 (load_charset_map_from_vector, Fmap_charset_chars):
3472 Remove now-unnecessary CHECK_NATNUMs.
3473 (Fdefine_charset_internal): Check ranges here, more carefully.
3474 Don't rely on undefined behavior with signed left shift overflow.
3475 Don't assume unsigned int fits into fixnum, or that fixnum fits
3476 into unsigned int. Don't require max_code to be a valid fixnum;
3477 that's not true for gb10830 4-byte on a 32-bit host. Allow
3478 invalid_code to be a cons, for the same reason. Require code_offset
3479 to be a character. Avoid int overflow if max_char is close
3481 (CODE_POINT_TO_INDEX): On 32-bit hosts, return int, not unsigned;
3482 this is intended anyway and avoids some undefined behavior.
3483 (load_charset_map): Pass unsigned, not int, as 2nd arg of
3484 INDEX_TO_CODE_POINT, as that's what it expects.
3485 (Funify_charset, encode_char): Don't stuff unsigned vals into int vars.
3486 * charset.h (DECODE_CHAR): Return int, not unsigned;
3487 this is what was intended anyway, and it avoids undefined behavior.
3488 (CHARSET_OFFSET): Remove unused macro, instead of fixing its
3489 integer-overflow issues.
3490 (ENCODE_CHAR): Return unsigned on all hosts, not just on 32-bit hosts.
3491 Formerly, it returned EMACS_INT on 64-bit hosts in the common case
3492 where the argument is EMACS_INT, and this behavior is not intended.
3493 * chartab.c (Fmake_char_table, Fset_char_table_range)
3494 (uniprop_get_decoder, uniprop_get_encoder):
3495 Don't assume fixnum fits in int.
3496 * cmds.c (move_point): New function, that does the gist of
3497 Fforward_char and Fbackward_char, but does so while checking
3498 for integer overflow more accurately.
3499 (Fforward_char, Fbackward_char): Use it.
3500 (Fforward_line, Fend_of_line, internal_self_insert)
3501 (internal_self_insert):
3502 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3503 Fix a FIXME, by checking for integer overflow when calculating
3504 target_clm and actual_clm.
3505 * coding.c (detect_coding_XXX, encode_coding_XXX, CODING_DECODE_CHAR)
3506 (CODING_ENCODE_CHAR, CODING_CHAR_CHARSET, CODING_CHAR_CHARSET_P)
3507 (ASSURE_DESTINATION, coding_alloc_by_realloc)
3508 (coding_alloc_by_making_gap, alloc_destination)
3509 (detect_coding_utf_8, encode_coding_utf_8, decode_coding_utf_16)
3510 (encode_coding_utf_16, detect_coding_emacs_mule)
3511 (decode_coding_emacs_mule, encode_coding_emacs_mule)
3512 (detect_coding_iso_2022, decode_coding_iso_2022)
3513 (encode_invocation_designation, encode_designation_at_bol)
3514 (encode_coding_iso_2022, detect_coding_sjis, detect_coding_big5)
3515 (decode_coding_sjis, decode_coding_big5, encode_coding_sjis)
3516 (encode_coding_big5, detect_coding_ccl, decode_coding_ccl)
3517 (encode_coding_ccl, encode_coding_raw_text)
3518 (detect_coding_charset, decode_coding_charset)
3519 (encode_coding_charset, detect_eol, decode_eol, produce_chars)
3520 (produce_composition, produce_charset, produce_annotation)
3521 (decode_coding, handle_composition_annotation)
3522 (handle_charset_annotation, consume_chars, decode_coding_gap)
3523 (decode_coding_object, encode_coding_object, detect_coding_system)
3524 (Ffind_coding_systems_region_internal, Fcheck_coding_systems_region)
3525 (code_convert_region, code_convert_string)
3526 (Fdefine_coding_system_internal)
3527 (coding_set_source, coding_set_destination):
3528 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3529 (setup_iso_safe_charsets, consume_chars, Funencodable_char_position)
3530 (Fdefine_coding_system_internal):
3531 Don't assume fixnums fit in int.
3532 (decode_coding_gap, decode_coding_object, encode_coding_object)
3533 (Fread_coding_system, Fdetect_coding_region)
3534 (Funencodable_char_position, Fcheck_coding_systems_region)
3535 (get_translation, handle_composition_annotation, consume_chars):
3536 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3537 (consume_chars): Rewrite to not calculate an address outside buffer.
3538 (Ffind_operation_coding_system): NATNUMP can eval its arg twice.
3539 Don't access memory outside of the args array.
3540 (Fdefine_coding_system_internal): Check for charset-id overflow.
3541 (ENCODE_ISO_CHARACTER): Use unsigned, not int, to store the unsigned
3542 result of ENCODE_CHAR.
3543 * coding.h: Adjust decls to match defn changes elsewhere.
3544 (struct coding_system):
3545 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3546 * composite.c (get_composition_id, find_composition)
3547 (run_composition_function, update_compositions)
3548 (compose_text, composition_gstring_put_cache)
3549 (composition_gstring_p, composition_gstring_width)
3550 (fill_gstring_header, fill_gstring_body, autocmp_chars)
3551 (composition_compute_stop_pos, composition_reseat_it)
3552 (composition_update_it, struct position_record)
3553 (find_automatic_composition, composition_adjust_point)
3554 (Fcomposition_get_gstring, Ffind_composition_internal):
3555 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3556 (update_compositions):
3557 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3558 * composite.h: Adjust decls to match defn changes elsewhere.
3559 (struct composition):
3560 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3561 * data.c (let_shadows_buffer_binding_p, let_shadows_global_binding_p):
3562 Do not attempt to compute the address of the object just before a
3563 buffer; this is not portable.
3565 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3566 (Faset): Use int, not EMACS_INT, where int is wide enough.
3567 (Fstring_to_number): Don't assume fixnums fit in int.
3568 (Frem): Don't assume arg is nonnegative.
3569 * dbusbind.c (xd_append_arg): Check for integers out of range.
3570 (Fdbus_call_method): Don't overflow the timeout int.
3571 (extract_signed, extract_unsigned): New functions.
3572 (XD_CHECK_DBUS_SERIAL): Remove; superseded by extract_unsigned.
3573 (xd_get_connection_references): Return ptrdiff_t, not int.
3575 (xd_signature, xd_append_arg, xd_retrieve_arg, Fdbus_message_internal)
3576 (xd_read_message_1):
3577 Use int, not unsigned, where the dbus API uses int.
3578 (Fdbus_message_internal): Don't overflow mtype.
3579 (syms_of_dbusbind): Allocate right-sized buffer for integers.
3580 * dired.c (directory_files_internal, file_name_completion, scmp)
3581 (file_name_completion_stat):
3582 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3583 (file_name_completion): Don't overflow matchcount.
3584 (file_name_completion_stat): Use SAFE_ALLOCA, not alloca.
3585 * dispextern.h: Adjust decls to match defn changes elsewhere.
3586 (struct text_pos, struct glyph, struct bidi_saved_info)
3587 (struct bidi_string_data, struct bidi_it, struct composition_it)
3589 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3590 (struct display_pos, struct composition_it, struct it):
3591 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3592 * dispnew.c (increment_matrix_positions)
3593 (increment_row_positions, mode_line_string)
3594 (marginal_area_string):
3595 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3596 (change_frame_size_1, Fredisplay, Fframe_or_buffer_changed_p):
3597 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3598 (duration_to_sec_usec): New function, to check for overflow better.
3599 (Fsleep_for, sit_for): Use it.
3600 * doc.c (get_doc_string, store_function_docstring):
3601 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3602 (get_doc_string, Fsnarf_documentation):
3603 Use int, not EMACS_INT, where int is wide enough.
3605 Use SAFE_ALLOCA, not alloca.
3606 Check for overflow when converting EMACS_INT to off_t.
3607 * doprnt.c (doprnt):
3608 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3609 * editfns.c (init_editfns, Fuser_uid, Fuser_real_uid):
3610 Don't assume uid_t fits into fixnum.
3611 (buildmark, Fgoto_char, overlays_around, find_field, Fdelete_field)
3612 (Ffield_string, Ffield_string_no_properties, Ffield_beginning)
3613 (Ffield_end, Fconstrain_to_field, Fline_beginning_position)
3614 (Fline_end_position, Fprevious_char, Fchar_after, Fchar_before)
3615 (general_insert_function)
3616 (Finsert_char, make_buffer_string, make_buffer_string_both)
3617 (update_buffer_properties, Fbuffer_substring)
3618 (Fbuffer_substring_no_properties, Fcompare_buffer_substrings)
3619 (Fsubst_char_in_region, check_translation)
3620 (Ftranslate_region_internal, save_restriction_restore, Fformat)
3621 (transpose_markers, Ftranspose_regions):
3622 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3623 (clip_to_bounds): Move to lisp.h as an inline function).
3624 (Fconstrain_to_field): Don't assume integers are nonnegative.
3625 (Fline_beginning_position, Fsave_excursion, Fsave_current_buffer):
3626 (Fsubst_char_in_region, Fsave_restriction):
3627 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3628 (Femacs_pid): Don't assume pid_t fits into fixnum.
3629 (lo_time): Use int, not EMACS_INT, when int suffices.
3630 (lisp_time_argument): Check for usec out of range.
3631 (Fencode_time): Don't assume fixnum fits in int.
3632 (Fuser_login_name, Fuser_full_name): Signal an error
3633 if a uid argument is out of range, rather than relying on
3635 (Fformat_time_string): Remove now-unnecessary check.
3636 lisp_time_argument checks for out-of-range usec now.
3637 Use ptrdiff_t, not size_t, where ptrdiff_t will do.
3638 * emacs.c (gdb_valbits, gdb_gctypebits): Now int, not EMACS_INT.
3639 (gdb_data_seg_bits): Now uintptr_t, not EMACS_INT.
3640 (PVEC_FLAG, gdb_array_mark_flag): Now ptrdiff_t, not EMACS_INT.
3641 (init_cmdargs, Fdump_emacs):
3642 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3643 (Fkill_emacs): Don't assume fixnum fits in int; instead, take just
3644 the bottom (typically) 32 bits of the fixnum.
3645 * eval.c (specpdl_size, call_debugger):
3646 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3647 (when_entered_debugger, Fbacktrace_debug):
3648 Don't assume fixnum can fit in int.
3649 (Fdefvaralias, Fdefvar): Do not attempt to compute the address of
3650 the object just before a buffer; this is not portable.
3651 (FletX, Flet, Funwind_protect, do_autoload, Feval, funcall_lambda)
3652 (grow_specpdl, unbind_to):
3653 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3654 (Fapply, apply_lambda): Don't assume ptrdiff_t can hold fixnum.
3655 (grow_specpdl): Simplify allocation by using xpalloc.
3656 (Fprog1, Fprog2): Don't assume list length fits in int. Simplify.
3657 * fileio.c (Ffind_file_name_handler, Fcopy_file, Frename_file)
3658 (Finsert_file_contents, Fwrite_region, Fdo_auto_save):
3659 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3660 (Ffind_file_name_handler, non_regular_inserted, Finsert_file_contents)
3662 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3663 (Fcopy_file, non_regular_nbytes, read_non_regular)
3664 (Finsert_file_contents):
3665 Use int, not EMACS_INT, where int is wide enough.
3666 (READ_BUF_SIZE): Verify that it fits in int.
3667 (Finsert_file_contents): Check that counts are in proper range,
3668 rather than assuming fixnums fit into ptrdiff_t etc.
3669 Don't assume fixnums fit into int.
3670 * floatfns.c (Fexpt): Avoid undefined signed * signed overflow.
3671 * fns.c (Fcompare_strings, Fstring_lessp, struct textprop_rec, concat)
3672 (string_char_byte_cache_charpos, string_char_byte_cache_bytepos)
3673 (string_char_to_byte, string_byte_to_char)
3674 (string_make_multibyte, string_to_multibyte)
3675 (string_make_unibyte, Fstring_as_unibyte, Fstring_as_multibyte)
3676 (Fstring_to_unibyte, Fsubstring, Fsubstring_no_properties)
3677 (substring_both, Fdelete, internal_equal, Ffillarray)
3678 (Fclear_string, mapcar1)
3679 (Fbase64_encode_region, Fbase64_encode_string, base64_encode_1)
3680 (Fbase64_decode_region, Fbase64_decode_string, base64_decode_1)
3681 (larger_vector, make_hash_table, maybe_resize_hash_table)
3682 (hash_lookup, hash_remove_from_table, hash_clear, sweep_weak_table)
3683 (Fmaphash, secure_hash):
3684 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3685 (concat): Check for string index and length overflow.
3686 (Fmapconcat): Don't assume fixnums fit into ptrdiff_t.
3688 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3689 (larger_vector): New API (vec, incr_min, size_max) replaces old
3690 one (vec, new_size, init). This catches size overflow.
3691 INIT was removed because it was always Qnil.
3692 All callers changed.
3693 (INDEX_SIZE_BOUND): New macro, which calculates more precisely
3694 the upper bound on a hash table index size.
3695 (make_hash_table, maybe_resize_hash_table): Use it.
3696 (secure_hash): Computer start_byte and end_byte only after
3697 they're known to be in ptrdiff_t range.
3698 * font.c (font_intern_prop, font_at, font_range, Ffont_shape_gstring)
3699 (Ffont_get_glyphs, Ffont_at):
3700 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3701 (font_style_to_value, font_prop_validate_style, font_expand_wildcards)
3702 (Flist_fonts, Fopen_font):
3703 Don't assume fixnum can fit in int.
3704 (check_gstring): Don't assume index can fit in int.
3705 (font_match_p): Check that fixnum is a character, not a nonnegative
3706 fixnum, since the later code needs to stuff it into an int.
3707 (font_find_for_lface): Use SAFE_ALLOCA_LISP, not alloca.
3708 (font_fill_lglyph_metrics): Use unsigned, not EMACS_INT, to avoid
3709 conversion overflow issues.
3710 (Fopen_font): Check for integer out of range.
3711 (Ffont_get_glyphs): Don't assume index can fit in int.
3712 * font.h: Adjust decls to match defn changes elsewhere.
3713 * fontset.c (reorder_font_vector): Redo score calculation to avoid
3715 (num_auto_fontsets, fontset_from_font): Use ptrdiff_t, not
3716 printmax_t, where ptrdiff_t is wide enough.
3717 (Finternal_char_font):
3718 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3719 * frame.c (Fset_mouse_position, Fset_mouse_pixel_position)
3720 (Fset_frame_height, Fset_frame_width, Fset_frame_size)
3721 (Fset_frame_position, x_set_frame_parameters)
3722 (x_set_line_spacing, x_set_border_width)
3723 (x_set_internal_border_width, x_set_alpha, x_figure_window_size):
3724 Check that fixnums are in proper range for system types.
3725 (frame_name_fnn_p, Fframe_parameter, Fmodify_frame_parameters):
3726 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3727 (Fmodify_frame_parameters): Don't assume fixnum fits in int.
3728 Use SAFE_ALLOCA_LISP, not alloca.
3729 * frame.h (struct frame): Use intptr_t, not EMACS_INT, where
3730 intptr_t is wide enough.
3731 * fringe.c (lookup_fringe_bitmap, get_logical_fringe_bitmap)
3732 (Fdefine_fringe_bitmap): Don't assume fixnum fits in int.
3733 (Ffringe_bitmaps_at_pos): Don't assume index fits in int.
3734 Check for fixnum out of range.
3735 * ftfont.c (ftfont_list): Don't assume index fits in int.
3736 Check that fixnums are in proper range for system types.
3737 (ftfont_shape_by_flt):
3738 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3739 * gnutls.c (emacs_gnutls_write, emacs_gnutls_read):
3740 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3741 (Fgnutls_error_fatalp, Fgnutls_error_string, Fgnutls_boot):
3742 Check that fixnums are in proper range for system types.
3743 * gnutls.h: Adjust decls to match defn changes elsewhere.
3744 * gtkutil.c (xg_dialog_run):
3745 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3746 (update_frame_tool_bar):
3747 Check that fixnums are in proper range for system types.
3748 * image.c (parse_image_spec): Redo count calculation to avoid overflow.
3749 (lookup_image): Check that fixnums are in range for system types.
3750 * indent.c (last_known_column, last_known_column_point):
3751 (current_column_bol_cache):
3752 (skip_invisible, current_column, check_display_width):
3753 (check_display_width, scan_for_column, current_column_1)
3754 (Findent_to, Fcurrent_indentation, position_indentation)
3755 (indented_beyond_p, Fmove_to_column, compute_motion):
3756 (Fcompute_motion, Fvertical_motion):
3757 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3758 (last_known_column_modified): Use EMACS_INT, not int.
3759 (check_display_width):
3761 Check that fixnums and floats are in proper range for system types.
3762 (compute_motion): Don't assume index or fixnum fits in int.
3763 (compute_motion, Fcompute_motion):
3764 Use int, not EMACS_INT, when it is wide enough.
3765 (vmotion): Omit local var start_hpos that is always 0; that way
3766 we don't need to worry about overflow in expressions involving it.
3767 * indent.h: Adjust decls to match defn changes elsewhere.
3769 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3770 Use int, not EMACS_INT, where int is wide enough.
3771 Remove unused members ovstring_chars_done and tab_offset;
3773 * insdel.c (move_gap, move_gap_both, gap_left, gap_right)
3774 (adjust_markers_for_delete, adjust_markers_for_insert, adjust_point)
3775 (adjust_markers_for_replace, make_gap_larger, make_gap_smaller)
3776 (make_gap, copy_text, insert, insert_and_inherit)
3777 (insert_before_markers, insert_before_markers_and_inherit)
3778 (insert_1, count_combining_before, count_combining_after)
3779 (insert_1_both, insert_from_string)
3780 (insert_from_string_before_markers, insert_from_string_1)
3781 (insert_from_gap, insert_from_buffer, insert_from_buffer_1)
3782 (adjust_after_replace, adjust_after_insert, replace_range)
3783 (replace_range_2, del_range, del_range_1, del_range_byte)
3784 (del_range_both, del_range_2, modify_region)
3785 (prepare_to_modify_buffer, signal_before_change)
3786 (signal_after_change, Fcombine_after_change_execute):
3787 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3788 * intervals.c (traverse_intervals, rotate_right, rotate_left)
3789 (balance_an_interval, split_interval_right, split_interval_left)
3790 (find_interval, next_interval, update_interval)
3791 (adjust_intervals_for_insertion, delete_node, delete_interval)
3792 (interval_deletion_adjustment, adjust_intervals_for_deletion)
3793 (static_offset_intervals, offset_intervals)
3794 (merge_interval_right, merge_interval_left, make_new_interval)
3795 (graft_intervals_into_buffer, temp_set_point_both)
3796 (temp_set_point, set_point, adjust_for_invis_intang)
3797 (set_point_both, move_if_not_intangible, get_property_and_range)
3798 (get_local_map, copy_intervals, copy_intervals_to_string)
3799 (compare_string_intervals, set_intervals_multibyte_1):
3800 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3801 * intervals.h: Adjust decls to match defn changes elsewhere.
3803 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3804 * keyboard.c (this_command_key_count, this_single_command_key_start)
3805 (before_command_key_count, before_command_echo_length, echo_now)
3806 (echo_length, recursive_edit_1, Frecursive_edit, Ftrack_mouse)
3807 (command_loop_1, safe_run_hooks, read_char, timer_check_2)
3808 (menu_item_eval_property, read_key_sequence, Fread_key_sequence)
3809 (Fread_key_sequence_vector, Fexecute_extended_command, Fsuspend_emacs):
3810 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3811 (last_non_minibuf_size, last_point_position, echo_truncate)
3812 (command_loop_1, adjust_point_for_property, read_char, gen_help_event)
3813 (make_lispy_position, make_lispy_event, parse_modifiers_uncached)
3814 (parse_modifiers, modify_event_symbol, Fexecute_extended_command)
3815 (stuff_buffered_input):
3816 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3817 (last_auto_save, command_loop_1, read_char):
3818 Use EMACS_INT, not int, to avoid integer overflow.
3819 (record_char): Avoid overflow in total_keys computation.
3820 (parse_modifiers_uncached): Redo index calculation to avoid overflow.
3821 * keyboard.h: Adjust decls to match defn changes elsewhere.
3822 * keymap.c (Fdefine_key, Fcurrent_active_maps, accessible_keymaps_1)
3823 (Fkey_description, Fdescribe_vector, Flookup_key):
3824 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3825 (click_position): New function, to check that positions are in range.
3826 (Fcurrent_active_maps):
3828 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3829 (Faccessible_keymaps, Fkey_description):
3830 (preferred_sequence_p):
3831 Don't assume fixnum can fit into int.
3832 (Fkey_description): Use SAFE_ALLOCA_LISP, not alloca.
3833 Check for integer overflow in size calculations.
3834 (Ftext_char_description): Use CHECK_CHARACTER, not CHECK_NUMBER, to
3835 avoid mishandling large integers.
3836 * lisp.h: Adjust decls to match defn changes elsewhere.
3837 (ARRAY_MARK_FLAG, PSEUDOVECTOR_FLAG, struct Lisp_String)
3838 (struct vectorlike_header, struct Lisp_Subr, struct Lisp_Hash_Table)
3839 (struct Lisp_Marker):
3840 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3841 (clip_to_bounds): Now an inline function, moved here from editfns.c.
3842 (GLYPH_CODE_P): Check for overflow in system types, subsuming the
3843 need for GLYPH_CODE_CHAR_VALID_P and doing proper checking ourselves.
3844 All callers changed.
3845 (GLYPH_CODE_CHAR, GLYPH_CODE_FACE):
3846 Assume the arg has valid form, since it always does.
3847 (TYPE_RANGED_INTEGERP): Avoid bug when checking against a wide
3848 unsigned integer system type.
3849 (CHECK_RANGED_INTEGER, CHECK_TYPE_RANGED_INTEGER): New macros.
3850 (struct catchtag, specpdl_size, SPECPDL_INDEX, USE_SAFE_ALLOCA):
3851 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3852 (struct catchtag): Use EMACS_INT, not int, since it may be a fixnum.
3853 (duration_to_sec_usec): New decl.
3854 * lread.c (read_from_string_index, read_from_string_index_byte)
3855 (read_from_string_limit, readchar, unreadchar, openp)
3856 (read_internal_start, read1, oblookup):
3857 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3858 (Fload, readevalloop, Feval_buffer, Feval_region):
3859 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3860 (openp): Check for out-of-range argument to 'access'.
3861 (read1): Use int, not EMACS_INT, where int is wide enough.
3862 Don't assume fixnum fits into int.
3863 Fix off-by-one error that can read outside a buffer.
3864 (read_filtered_event): Use duration_to_sec_usec
3865 to do proper overflow checking on durations.
3866 * macros.c (Fstart_kbd_macro): Use xpalloc to check for overflow
3867 in size calculation.
3868 (Fexecute_kbd_macro):
3869 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3870 * marker.c (cached_charpos, cached_bytepos, CONSIDER)
3871 (byte_char_debug_check, buf_charpos_to_bytepos, verify_bytepos)
3872 (buf_bytepos_to_charpos, Fset_marker, set_marker_restricted)
3873 (set_marker_both, set_marker_restricted_both, marker_position)
3874 (marker_byte_position, Fbuffer_has_markers_at):
3875 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3876 (Fset_marker, set_marker_restricted): Don't assume fixnum fits in int.
3877 * menu.c (ensure_menu_items): Rename from grow_menu_items.
3878 It now merely ensures that the menu is large enough, without
3879 necessarily growing it, as this avoids some integer overflow issues.
3880 All callers changed.
3881 (keymap_panes, parse_single_submenu, Fx_popup_menu):
3882 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3883 (parse_single_submenu, Fx_popup_menu): Don't assume fixnum fits in int.
3884 Use SAFE_ALLOCA_LISP, not alloca.
3885 (find_and_return_menu_selection): Avoid unnecessary casts of pointers
3886 to EMACS_INT. Check that fixnums are in proper range for system types.
3887 * minibuf.c (minibuf_prompt_width, string_to_object)
3888 (Fminibuffer_contents, Fminibuffer_contents_no_properties)
3889 (Fminibuffer_completion_contents, Ftry_completion, Fall_completions):
3890 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3891 (get_minibuffer, read_minibuf_unwind):
3892 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3893 (read_minibuf): Omit unnecessary arg BACKUP_N, which is always nil;
3894 this simplifies overflow checking. All callers changed.
3895 (read_minibuf, Fread_buffer, Ftry_completion, Fall_completions)
3897 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3898 * nsfns.m (check_ns_display_info): Don't assume fixnum fits in long.
3899 (x_set_menu_bar_lines, x_set_tool_bar_lines, Fx_create_frame):
3900 Check that fixnums are in proper range for system types.
3901 (Fx_create_frame, Fx_show_tip):
3902 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3903 * nsfont.m (ns_findfonts, nsfont_list_family):
3904 Don't assume fixnum fits in long.
3905 * nsmenu.m (ns_update_menubar, ns_menu_show, ns_popup_dialog):
3906 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3907 (ns_update_menubar): Use intptr_t, not EMACS_INT, when intptr_t is
3909 * nsselect.m (ns_get_local_selection, clean_local_selection_data):
3910 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3911 * print.c (print_buffer_size, print_buffer_pos, print_buffer_pos_byte)
3912 (PRINTDECLARE, PRINTPREPARE):
3913 (strout, print_string):
3914 (print, print_preprocess, print_check_string_charset_prop)
3916 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3918 (temp_output_buffer_setup, Fprin1_to_string, print_object):
3919 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3920 (PRINTPREPARE): Use int, not ptrdiff_t, where int is wide enough.
3921 (printchar, strout): Use xpalloc to catch size calculation overflow.
3922 (Fexternal_debugging_output): Don't overflow EMACS_INT->int conversion.
3923 (print_error_message): Use SAFE_ALLOCA, not alloca.
3924 (print_object): Use int, not EMACS_INT, where int is wide enough.
3925 (print_depth, new_backquote_output, print_number_index):
3926 Use ptrdiff_t, not int, where int might not be wide enough.
3927 * process.c (Fdelete_process): Don't assume pid fits into EMACS_INT.
3928 (Fset_process_window_size, Fformat_network_address)
3929 (get_lisp_to_sockaddr_size, set_socket_option, Fmake_network_process)
3931 Check that fixnums are in proper range for system types.
3932 (Fsignal_process): Simplify by avoiding a goto.
3933 Check for process-ids out of pid_t range rather than relying on
3935 (process_tick, update_tick): Use EMACS_INT, not int.
3936 (Fformat_network_address, read_process_output, send_process)
3937 (Fprocess_send_region, status_notify):
3938 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3939 (Fformat_network_address, Fmake_serial_process, Fmake_network_process)
3940 (wait_reading_process_output, read_process_output, exec_sentinel):
3941 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3942 (conv_lisp_to_sockaddr): Don't assume fixnums fit into int.
3943 (Faccept_process_output): Use duration_to_sec_usec to do proper
3944 overflow checking on durations.
3945 (emacs_get_tty_pgrp, Fprocess_running_child_p, process_send_signal):
3946 Don't assume pid_t fits in int.
3947 * process.h (struct Lisp_Process): Members tick and update_tick
3948 are now of type EMACS_INT, not int.
3949 * puresize.h (PURESIZE_RATIO): Shrink this to 8/6 on 32-bit hosts
3950 configured --with-wide-int.
3951 * scroll.c (calculate_scrolling, calculate_direct_scrolling)
3952 (line_ins_del): Use int, not EMACS_INT, where int is wide enough.
3953 * search.c (looking_at_1, string_match_1):
3954 (fast_string_match, fast_c_string_match_ignore_case)
3955 (fast_string_match_ignore_case, fast_looking_at, scan_buffer)
3956 (scan_newline, find_before_next_newline, search_command)
3957 (trivial_regexp_p, search_buffer, simple_search, boyer_moore)
3958 (set_search_regs, wordify):
3961 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3962 (string_match_1, search_buffer, set_search_regs):
3964 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3965 (wordify): Check for overflow in size calculation.
3966 (Freplace_match): Avoid potential buffer overflow in search_regs.start.
3967 (Fset_match_data): Don't assume fixnum fits in ptrdiff_t.
3968 Check that fixnums are in proper range for system types.
3969 * sound.c (struct sound_device)
3970 (wav_play, au_play, vox_write, alsa_period_size, alsa_write):
3971 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3972 (Fplay_sound_internal):
3973 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3974 * syntax.c (struct lisp_parse_state, find_start_modiff)
3975 (Finternal_describe_syntax_value, scan_lists, scan_sexps_forward):
3976 (Fparse_partial_sexp):
3977 Don't assume fixnums can fit in int.
3978 (struct lisp_parse_state, find_start_pos, find_start_value)
3979 (find_start_value_byte, find_start_begv)
3980 (update_syntax_table, char_quoted, dec_bytepos)
3981 (find_defun_start, prev_char_comend_first, back_comment):
3982 (scan_words, skip_chars, skip_syntaxes, forw_comment, Fforward_comment)
3983 (scan_lists, Fbackward_prefix_chars, scan_sexps_forward):
3984 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3985 (Finternal_describe_syntax_value): Check that match_lisp is a
3986 character, not an integer, since the code stuffs it into int.
3987 (scan_words, scan_sexps_forward):
3988 Check that fixnums are in proper range for system types.
3990 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3991 (scan_sexps_forward):
3992 Use CHARACTERP, not INTEGERP, since the value must fit into int.
3993 (Fparse_partial_sexp): Fix doc; element 8 is not ignored.
3994 * syntax.h: Adjust decls to match defn changes elsewhere.
3995 (struct gl_state_s):
3996 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3997 (SETUP_SYNTAX_TABLE_FOR_OBJECT): Use PTRDIFF_MAX, not
3998 MOST_POSITIVE_FIXNUM.
3999 * sysdep.c (wait_for_termination_1, wait_for_termination)
4000 (interruptible_wait_for_termination, mkdir):
4001 Don't assume pid_t fits in int; on 64-bit AIX pid_t is 64-bit.
4002 (emacs_read, emacs_write):
4003 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
4004 (system_process_attributes): Don't assume uid_t, gid_t, EMACS_INT,
4005 and double all fit in int.
4006 * term.c (set_tty_color_mode):
4007 Check that fixnums are in proper range for system types.
4008 * termhooks.h (struct input_event):
4009 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
4010 * textprop.c (validate_interval_range, interval_of)
4011 (Fadd_text_properties, set_text_properties_1)
4012 (Fremove_text_properties, Fremove_list_of_text_properties)
4013 (Ftext_property_any, Ftext_property_not_all)
4014 (copy_text_properties, text_property_list, extend_property_ranges)
4015 (verify_interval_modification):
4016 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
4017 (Fnext_single_char_property_change)
4018 (Fprevious_single_char_property_change):
4019 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
4020 (copy_text_properties):
4021 Check for integer overflow in index calculation.
4022 * undo.c (last_boundary_position, record_point, record_insert)
4023 (record_delete, record_marker_adjustment, record_change)
4024 (record_property_change):
4025 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
4026 (truncate_undo_list, Fprimitive_undo): Don't assume fixnum fits in int.
4027 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
4028 * w32fns.c (Fx_create_frame, x_create_tip_frame, Fx_show_tip)
4029 (Fx_hide_tip, Fx_file_dialog):
4030 * w32menu.c (set_frame_menubar):
4031 Use ptrdiff_t, not int, for consistency with rest of code.
4032 * window.c (window_scroll_preserve_hpos, window_scroll_preserve_vpos)
4033 (select_window, Fdelete_other_windows_internal)
4034 (window_scroll_pixel_based, window_scroll_line_based)
4035 (Frecenter, Fset_window_configuration):
4036 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
4037 (Fset_window_hscroll, run_window_configuration_change_hook)
4038 (set_window_buffer, temp_output_buffer_show, scroll_command)
4039 (Fscroll_other_window, Frecenter):
4040 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
4041 (Fwindow_line_height, window_scroll, Fscroll_left, Fscroll_right):
4042 Don't assume fixnum fits in int.
4043 (Fset_window_scroll_bars):
4044 Check that fixnums are in proper range for system types.
4045 * xdisp.c (help_echo_pos, pos_visible_p, string_pos_nchars_ahead)
4046 (string_pos, c_string_pos, number_of_chars, init_iterator)
4047 (in_ellipses_for_invisible_text_p, init_from_display_pos)
4048 (compute_stop_pos, next_overlay_change, compute_display_string_pos)
4049 (compute_display_string_end, handle_face_prop)
4050 (face_before_or_after_it_pos, handle_invisible_prop)
4051 (handle_display_prop, handle_display_spec, handle_single_display_spec)
4052 (display_prop_intangible_p, string_buffer_position_lim)
4053 (string_buffer_position, handle_composition_prop, load_overlay_strings)
4054 (get_overlay_strings_1, get_overlay_strings)
4055 (iterate_out_of_display_property, forward_to_next_line_start)
4056 (back_to_previous_visible_line_start, reseat, reseat_to_string)
4057 (get_next_display_element, set_iterator_to_next)
4058 (get_visually_first_element, compute_stop_pos_backwards)
4059 (handle_stop_backwards, next_element_from_buffer)
4060 (move_it_in_display_line_to, move_it_in_display_line)
4061 (move_it_to, move_it_vertically_backward, move_it_by_lines)
4062 (add_to_log, message_dolog, message_log_check_duplicate)
4063 (message2, message2_nolog, message3, message3_nolog
4064 (with_echo_area_buffer, display_echo_area_1, resize_mini_window_1)
4065 (current_message_1, truncate_echo_area, truncate_message_1)
4066 (set_message, set_message_1, store_mode_line_noprop)
4067 (hscroll_window_tree, debug_delta, debug_delta_bytes, debug_end_vpos)
4068 (text_outside_line_unchanged_p, check_point_in_composition)
4069 (reconsider_clip_changes)
4070 (redisplay_internal, set_cursor_from_row, try_scrolling)
4071 (try_cursor_movement, set_vertical_scroll_bar, redisplay_window)
4072 (redisplay_window, find_last_unchanged_at_beg_row)
4073 (find_first_unchanged_at_end_row, row_containing_pos, try_window_id)
4074 (trailing_whitespace_p, find_row_edges, display_line)
4075 (RECORD_MAX_MIN_POS, Fcurrent_bidi_paragraph_direction)
4076 (display_mode_element, store_mode_line_string)
4077 (pint2str, pint2hrstr, decode_mode_spec)
4078 (display_count_lines, display_string, draw_glyphs)
4079 (x_produce_glyphs, x_insert_glyphs)
4080 (rows_from_pos_range, mouse_face_from_buffer_pos)
4081 (fast_find_string_pos, mouse_face_from_string_pos)
4082 (note_mode_line_or_margin_highlight, note_mouse_highlight):
4083 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
4084 (safe_call, init_from_display_pos, handle_fontified_prop)
4085 (handle_single_display_spec, load_overlay_strings)
4086 (with_echo_area_buffer, setup_echo_area_for_printing)
4087 (display_echo_area, echo_area_display)
4088 (x_consider_frame_title, prepare_menu_bars, update_menu_bar)
4089 (update_tool_bar, hscroll_window_tree, redisplay_internal)
4090 (redisplay_window, dump_glyph_row, display_mode_line)
4091 (Fformat_mode_line, decode_mode_spec, on_hot_spot_p):
4092 (handle_display_spec, display_prop_string_p):
4093 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
4094 (handle_single_display_spec, build_desired_tool_bar_string)
4095 (redisplay_tool_bar, scroll_window_tree, Fdump_glyph_matrix)
4096 (get_specified_cursor_type):
4097 Check that fixnums are in proper range for system types.
4098 (struct overlay_entry, resize_mini_window, Fdump_glyph_row)
4099 (Flookup_image_map):
4100 Don't assume fixnums fit in int.
4101 (compare_overlay_entries):
4102 Avoid mishandling comparisons due to subtraction overflow.
4103 (load_overlay_strings): Use SAFE_NALLOCA, not alloca.
4104 (last_escape_glyph_face_id, last_glyphless_glyph_face_id):
4105 (handle_tool_bar_click):
4106 Use int, not unsigned, since we prefer signed and the signedness
4107 doesn't matter here.
4108 (get_next_display_element, next_element_from_display_vector):
4109 Use int, not EMACS_INT, when int is wide enough.
4110 (start_hourglass): Use duration_to_sec_usec to do proper
4111 overflow checking on durations.
4112 * xfaces.c (Fbitmap_spec_p):
4113 Check that fixnums are in proper range for system types.
4114 (compare_fonts_by_sort_order):
4115 Avoid mishandling comparisons due to subtraction overflow.
4116 (Fx_family_fonts, realize_basic_faces):
4117 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
4119 Don't assume fixnum fits in int.
4120 Use SAFE_ALLOCA_LISP, not alloca.
4121 (merge_face_heights): Remove unnecessary cast to EMACS_INT.
4122 (Finternal_make_lisp_face): Don't allocate more than MAX_FACE_ID.
4123 (face_at_buffer_position, face_for_overlay_string)
4124 (face_at_string_position):
4125 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
4126 (merge_faces): Use int, not EMACS_INT, where int is wide enough.
4127 * xfns.c (x_set_menu_bar_lines, x_set_tool_bar_lines, x_icon_verify)
4129 Check that fixnums are in proper range for system types.
4130 (Fx_create_frame, x_create_tip_frame, Fx_show_tip)
4131 (Fx_hide_tip, Fx_file_dialog, Fx_select_font):
4132 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
4133 (Fx_change_window_property): Don't assume fixnums fit in int.
4134 * xfont.c (xfont_chars_supported):
4135 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
4136 * xmenu.c (Fx_popup_dialog, set_frame_menubar)
4137 (create_and_show_popup_menu, create_and_show_dialog, xmenu_show):
4138 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
4139 * xml.c (parse_region):
4140 * xrdb.c (magic_file_p):
4141 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
4142 * xselect.c (TRACE1): Don't assume pid_t promotes to int.
4143 (x_get_local_selection, x_reply_selection_request)
4144 (x_handle_selection_request, wait_for_property_change):
4145 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
4146 (selection_data_to_lisp_data): Use short, not EMACS_INT, where
4147 short is wide enough.
4148 (x_send_client_event): Don't assume fixnum fits in int.
4149 * xterm.c (x_x_to_emacs_modifiers):
4150 Don't assume EMACS_INT overflows nicely into int.
4151 (x_emacs_to_x_modifiers): Use EMACS_INT, not int, because values
4153 (handle_one_xevent): NATNUMP can eval its arg twice.
4154 (x_connection_closed):
4155 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
4156 * xterm.h: Adjust decls to match defn changes elsewhere.
4157 (struct scroll_bar): Use struct vectorlike_header
4158 rather than rolling our own approximation.
4159 (SCROLL_BAR_VEC_SIZE): Remove; not used.
4161 2012-05-25 Glenn Morris <rgm@gnu.org>
4163 * lisp.mk (lisp): Update for more files being compiled now.
4165 2012-05-25 Stefan Monnier <monnier@iro.umontreal.ca>
4167 * lread.c: Remove `read_pure' which makes no difference.
4168 (read_pure): Remove var.
4169 (unreadpure): Remove function.
4170 (readevalloop): Don't call read_list with -1 flag.
4171 (read1, read_vector): Don't test read_pure any more.
4172 (read_list): Simplify.
4174 * fileio.c, character.h: Minor style tweaks.
4176 2012-05-24 Dmitry Antipov <dmantipov@yandex.ru>
4178 * window.h (clip_changed): Remove useless declaration.
4180 2012-05-22 Juanma Barranquero <lekktu@gmail.com>
4182 * makefile.w32-in: Follow-up to 2012-05-22T16:20:27Z!eggert@cs.ucla.edu.
4183 (TAGS, TAGS-gmake, CONFIG_H): Remove further references to m/intel386.h.
4185 2012-05-22 Paul Eggert <eggert@cs.ucla.edu>
4188 This directory predates autoconf and is no longer needed nowadays.
4189 Move its few remaining bits of functionality to where they're needed.
4190 * m/README, m/alpha.h, m/amdx86-64.h, m/ia64.h, m/ibmrs6000.h:
4191 * m/ibms390x.h, m/intel386.h, m/m68k.h, m/macppc.h, m/sparc.h:
4192 * m/template.h: Remove.
4193 * Makefile.in (M_FILE): Remove. All uses removed.
4194 * alloc.c (POINTERS_MIGHT_HIDE_IN_OBJECTS):
4195 * lisp.h (USE_LSB_TAG):
4196 * mem-limits.h (EXCEEDS_LISP_PTR):
4197 Use VAL_MAX, not VALBITS, in #if.
4198 * lisp.h (EMACS_INT_MAX): New macro, useful in #if.
4199 (EMACS_UINT): Define unconditionally now.
4200 (BITS_PER_CHAR, BITS_PER_SHORT, BITS_PER_INT, BITS_PER_LONG)
4201 (BITS_PER_EMACS_INT): New constants, replacing
4202 what used to be in config.h, but not useful in #if.
4203 (GCTYPEBITS, VALBITS): Define unconditionally, since m/* files don't
4204 define them any more.
4205 (VAL_MAX): New macro.
4207 * puresize.h (PURESIZE_RATIO): Use EMACS_INT_MAX, not
4208 BITS_PER_EMACS_INT, in #if.
4209 * s/aix4-2.h (BROKEN_FIONREAD, BROKEN_SIGAIO, BROKEN_SIGPTY)
4210 (BROKEN_SIGPOLL): Move here from m/ibmrs6000.h, which was removed.
4211 * s/gnu-linux.h (ULIMIT_BREAK_VALUE) [__i386__]:
4212 * s/ms-w32.h (DATA_START):
4213 Move here from removed file m/intel386.h.
4214 * s/gnu.h (NLIST_STRUCT): Remove undef; 'configure' does this.
4215 * s/irix6-5.h (_LP64): Remove; lisp.h no longer needs this.
4217 2012-05-21 Paul Eggert <eggert@cs.ucla.edu>
4219 Assume C89 or later.
4220 * alloc.c, buffer.c, lisp.h: Replace POINTER_TYPE with void.
4221 * alloc.c (overrun_check_malloc, overrun_check_realloc, xmalloc)
4223 * buffer.c (mmap_free_1, mmap_enlarge): Omit needless casts.
4224 * editfns.c, fns.c, gmalloc.c, insdel.c, sysdep.c, termcap.c (NULL):
4225 * textprop.c, tparam.c (NULL): Remove.
4226 * ralloc.c, vm-limit.c (POINTER): Assume void * works.
4227 * regex.c (SIGN_EXTEND_CHAR): Assume signed char works.
4228 * regex.h (_RE_ARGS): Remove. All uses rewritten to use prototypes.
4229 * unexelf.c (ElfBitsW): Assume c89 preprocessor or better.
4230 * xterm.c (input_signal_count): Assume volatile works.
4232 2012-05-21 Ken Brown <kbrown@cornell.edu>
4234 * xgselect.c (xg_select): Fix first argument in call to 'select'
4237 2012-05-20 Ken Brown <kbrown@cornell.edu>
4239 * gmalloc.c (_free_internal_nolock, _realloc_internal_nolock)
4240 [CYGWIN]: Cast ptr to (char *) before comparing to _heapbase.
4242 2012-05-19 Ken Brown <kbrown@cornell.edu>
4244 * xfns.c (x_in_use): Remove `static' qualifier.
4245 * xterm.h (x_in_use): Declare.
4246 * xgselect.c: Include xterm.h.
4247 (xg_select): Test `x_in_use' instead of `inhibit_window_system'
4248 and `display_arg' (bug#9754).
4250 2012-05-19 Paul Eggert <eggert@cs.ucla.edu>
4252 * s/ms-w32.h (HAVE_GETDOMAINNAME): Remove; not needed.
4254 * m/vax.h: Remove; no longer needed since HAVE_FTIME is being removed.
4255 * s/ms-w32.h (HAVE_FTIME): Remove; not needed.
4257 2012-05-18 Eli Zaretskii <eliz@gnu.org>
4259 Fix compilation with -DGLYPH_DEBUG=1 on MS-Windows.
4261 * w32term.c [GLYPH_DEBUG]: Add prototype for x_check_font.
4262 (x_check_font) [GLYPH_DEBUG]: New function, copied from xterm.c.
4264 * w32fns.c (unwind_create_frame) [GLYPH_DEBUG]: Fix broken
4265 reference to image_cache->refcount.
4266 (x_create_tip_frame): Fix broken use of FRAME_IMAGE_CACHE.
4268 2012-05-17 Juri Linkov <juri@jurta.org>
4270 * search.c (Fword_search_regexp, Fword_search_backward)
4271 (Fword_search_forward, Fword_search_backward_lax)
4272 (Fword_search_forward_lax): Move functions to isearch.el
4273 (bug#10145, bug#11381).
4275 2012-05-16 Paul Eggert <eggert@cs.ucla.edu>
4277 * xgselect.c (xg_select): Just invoke 'select' if -nw (Bug#9754).
4279 2012-05-15 Stefan Monnier <monnier@iro.umontreal.ca>
4281 * lread.c (init_obarray): Declare Qt and Qnil as special.
4283 2012-05-14 Glenn Morris <rgm@gnu.org>
4285 * nsterm.m (ns_init_paths): Fix typo ("libexec" not "lib-exec").
4286 Put "libexec" before "bin", for the sake of init_callproc_1.
4288 2012-05-14 Paul Eggert <eggert@cs.ucla.edu>
4290 * keyboard.c (kbd_buffer_get_event) [!HAVE_DBUS]: Omit unused local.
4292 * unexaix.c: Port to more-recent AIX compilers.
4293 (report_error, report_error_1, make_hdr, copy_sym)
4294 (mark_x, adjust_lnnoptrs, unrelocate_symbols):
4295 Make arguments const char *, not char *, to avoid violations of C
4296 standard and to fix some AIX warnings reported by Gilles Pion.
4298 2012-05-14 Eli Zaretskii <eliz@gnu.org>
4300 * xdisp.c (handle_stop): Don't call get_overlay_strings_1 if we
4301 already have overlays loaded.
4302 (handle_single_display_spec): Before returning without displaying
4303 fringe bitmap, synchronize the bidi iterator with the main display
4304 iterator, by calling iterate_out_of_display_property.
4305 (iterate_out_of_display_property): Detect buffer iteration by
4306 testing that it->string is a Lisp string.
4307 (get_next_display_element): When the current object is exhausted,
4308 and there's something on it->stack, call set_iterator_to_next to
4309 proceed with what's on the stack, instead of returning zero.
4310 (set_iterator_to_next): If called at the end of a Lisp string,
4311 proceed to consider_string_end without incrementing string
4312 position. Don't increment display vector index past the end of
4313 the display vector. (Bug#11417)
4314 (pos_visible_p): Don't report a position visible when move_it_to
4315 stopped at the last line of window, which happens to be scanned
4316 backwards by the bidi iteration. (Bug#11464)
4318 2012-05-14 Eli Zaretskii <eliz@gnu.org>
4320 * xdisp.c (handle_single_display_spec): Return 1 for left-margin
4321 and right-margin display specs even if the spec is invalid or we
4322 are on a TTY, and thus unable to display on the fringes.
4323 That's because the text with the property will not be displayed anyway,
4324 so we need to signal to the caller that this is a "replacing"
4325 display spec. This fixes display when the spec is invalid or we
4328 2012-05-14 Paul Eggert <eggert@cs.ucla.edu>
4330 * unexaix.c (make_hdr): Fix typo in prototype.
4331 This bug broke the build on AIX. Problem reported by Gilles Pion.
4333 2012-05-14 Michael Albinus <michael.albinus@gmx.de>
4335 * keyboard.c (kbd_buffer_get_event): Read special events also in
4336 batch mode. (Bug#11415)
4338 2012-05-12 Glenn Morris <rgm@gnu.org>
4340 * ns.mk: Update for ns_appbindir no longer having trailing "/".
4342 2012-05-12 Eli Zaretskii <eliz@gnu.org>
4344 * lisp.mk (lisp): Add newcomment.elc.
4346 2012-05-12 Glenn Morris <rgm@gnu.org>
4348 * Makefile.in (MKDIR_P): New, set by configure.
4349 * ns.mk (${ns_appdir}, ${ns_appbindir}Emacs): Use $MKDIR_P.
4351 2012-05-11 Paul Eggert <eggert@cs.ucla.edu>
4353 Remove unused function hourglass_started.
4354 * dispextern.h (hourglass_started):
4355 * w32fns.c (hourglass_started):
4356 * xdisp.c (hourglass_started): Remove.
4358 2012-05-10 Juanma Barranquero <lekktu@gmail.com>
4360 * makefile.w32-in ($(BLD)/gmalloc.$(O), $(BLD)/w32menu.$(O)):
4361 Update dependencies.
4363 2012-05-10 Paul Eggert <eggert@cs.ucla.edu>
4365 * xgselect.c (xg_select): Put maxfds+1 into a var.
4366 This is slightly clearer, and pacifies Ubuntu 12.04 gcc.
4368 * sound.c (DEFAULT_ALSA_SOUND_DEVICE): Define only if HAVE_ALSA.
4370 2012-05-10 Dave Abrahams <dave@boostpro.com>
4372 * filelock.c (syms_of_filelock): New boolean create-lockfiles.
4373 (lock_file): If create_lockfiles is 0, do nothing. (Bug#11227)
4375 2012-05-09 Michael Albinus <michael.albinus@gmx.de>
4377 * dbusbind.c (xd_registered_buses): New internal Lisp object.
4378 Rename all occurences of Vdbus_registered_buses to xd_registered_buses.
4379 (syms_of_dbusbind): Remove declaration of Vdbus_registered_buses.
4380 Initialize xd_registered_buses.
4382 2012-05-09 Paul Eggert <eggert@cs.ucla.edu>
4384 Untag more efficiently if USE_LSB_TAG.
4385 This is based on a proposal by YAMAMOTO Mitsuharu in
4386 <http://lists.gnu.org/archive/html/emacs-devel/2008-01/msg01876.html>.
4387 For an admittedly artificial (nth 8000 longlist) benchmark on
4388 Fedora 15 x86-64, this yields a 25% CPU speedup. Also, it shrinks
4389 Emacs's overall text size by 1%.
4390 * lisp.h (XUNTAG): New macro.
4391 (XCONS, XVECTOR, XSTRING, XSYMBOL, XFLOAT, XMISC, XPROCESS, XWINDOW)
4392 (XTERMINAL, XSUBR, XBUFFER, XCHAR_TABLE, XSUB_CHAR_TABLE, XBOOL_VECTOR)
4393 (XSETTYPED_PSEUDOVECTOR, XHASH_TABLE, TYPED_PSEUDOVECTORP): Use it.
4394 * eval.c (Fautoload):
4395 * font.h (XFONT_SPEC, XFONT_ENTITY, XFONT_OBJECT):
4396 * frame.h (XFRAME): Use XUNTAG.
4398 Port recent dbusbind.c changes to 32-bit --with-wide-int.
4399 * dbusbind.c (xd_append_arg, xd_retrieve_arg, Fdbus_message_internal):
4400 Remove unportable assumptions about print widths of types like
4402 (xd_get_connection_address, Fdbus_init_bus): Cast Emacs integer to
4403 intptr_t when converting between pointer and integer, to avoid GCC
4404 warnings about wrong width.
4406 2012-05-09 Eli Zaretskii <eliz@gnu.org>
4408 * w32proc.c (new_child): Force Windows to reserve only 64KB of
4409 stack for each reader_thread, instead of defaulting to 8MB
4410 determined by the linker. This avoids failures in creating
4411 subprocesses on Windows 7, see the discussion in this thread:
4412 http://lists.gnu.org/archive/html/emacs-devel/2012-03/msg00119.html.
4414 2012-05-07 Jérémy Compostella <jeremy.compostella@gmail.com>
4416 Fix up display of the *Minibuf-0* buffer in the mini window.
4417 * keyboard.c (read_char): Don't clear the echo area if there's no
4419 * xdisp.c (redisplay_internal): Redisplay the mini window (with the
4420 contents of *Minibuf-0*) if there's no message displayed in its stead.
4422 2012-05-07 Michael Albinus <michael.albinus@gmx.de>
4424 * dbusbind.c (XD_DEBUG_MESSAGE): Don't print message twice in
4427 2012-05-06 Chong Yidong <cyd@gnu.org>
4429 * lisp.mk (lisp): Update.
4431 2012-05-05 Jim Meyering <meyering@redhat.com>
4433 * w32font.c (fill_in_logfont): NUL-terminate a string (Bug#11372).
4435 2012-05-04 Stefan Monnier <monnier@iro.umontreal.ca>
4437 * data.c (PUT_ERROR): New macro.
4438 (syms_of_data): Use it. Add new error type `user-error'.
4439 * undo.c (user_error): New function.
4440 (Fprimitive_undo): Use it.
4441 * print.c (print_error_message): Adjust print style for `user-error'.
4442 * keyboard.c (user_error): New function.
4443 (Fexit_recursive_edit, Fabort_recursive_edit): Use it.
4445 2012-05-03 Paul Eggert <eggert@cs.ucla.edu>
4447 Do not limit current-time-string to years 1000..9999.
4448 * editfns.c (TM_YEAR_IN_ASCTIME_RANGE): Remove.
4449 (Fcurrent_time_string): Support any year that is supported by the
4450 underlying localtime representation. Don't use asctime, as it
4451 has undefined behavior for years outside the range -999..9999.
4453 2012-05-02 Paul Eggert <eggert@cs.ucla.edu>
4455 Fix race conditions involving setenv, gmtime, localtime, asctime.
4456 Without this fix, interrupts could mess up code that uses these
4457 nonreentrant functions, since setting TZ invalidates existing
4458 tm_zone or tzname values, and since most of these functions return
4459 pointers to static storage.
4460 * editfns.c (format_time_string, Fdecode_time, Fencode_time)
4461 (Fcurrent_time_string, Fcurrent_time_zone, Fset_time_zone_rule):
4462 Grow the critical sections to include not just invoking
4463 localtime/gmtime, but also accessing these functions' results
4464 including their tm_zone values if any, and any related TZ setting.
4465 (format_time_string): Last arg is now struct tm *, not struct tm **,
4466 so that the struct tm is saved in the critical section.
4467 All callers changed. Simplify allocation of initial buffer, partly
4468 motivated by the fact that memory allocation needs to be outside
4469 the critical section.
4471 2012-05-02 Dmitry Antipov <dmantipov@yandex.ru>
4473 * intervals.c (adjust_intervals_for_insertion): Initialize `newi'
4474 with RESET_INTERVAL.
4476 * buffer.c (Fget_buffer_create, Fmake_indirect_buffer):
4477 Remove duplicated buffer name initialization.
4479 2012-05-02 Jim Meyering <jim@meyering.net>
4481 * xterm.c (x_term_init): Use memcpy instead of strncpy (Bug#11373).
4483 * xfns.c (x_window): Use xstrdup (Bug#11375).
4485 2012-05-02 Eli Zaretskii <eliz@gnu.org>
4487 * xdisp.c (pos_visible_p): If already at a newline from the
4488 display string before the 'while' loop, don't walk back the glyphs
4489 from it3.glyph_row. Solves assertion violation when the display
4490 string begins with a newline (egg.el). (Bug#11367)
4492 2012-05-01 Stefan Monnier <monnier@iro.umontreal.ca>
4494 * keyboard.c (Fexecute_extended_command, Vsuggest_key_bindings):
4497 2012-05-01 Glenn Morris <rgm@gnu.org>
4499 * syssignal.h: Remove reference to BROKEN_SIGINFO (last used in
4500 s/ptx4.h), BROKEN_SIGTSTP (last used in m/ustation.h, m/dpx2.h),
4501 and BROKEN_SIGURG (was in s/gnu-linux.h prior to 2008-02-10).
4502 All were removed before 23.1.
4504 * dispnew.c: Remove HAVE_LIBNCURSES test;
4505 it is always true on relevant platforms.
4507 * Makefile.in (LD_SWITCH_X_SITE_RPATH):
4508 Rename from LD_SWITCH_X_SITE_AUX_RPATH.
4510 * Makefile.in (LD_SWITCH_X_SITE_AUX): Remove; no longer used.
4512 2012-04-30 Andreas Schwab <schwab@linux-m68k.org>
4514 * .gdbinit (xpr): Remove checks for no longer existing misc types.
4515 (xintfwd, xboolfwd, xobjfwd, xbufobjfwd, xkbobjfwd, xbuflocal):
4518 2012-04-28 Paul Eggert <eggert@cs.ucla.edu>
4520 Do not avoid creating empty evaporating overlays (Bug#9642).
4521 * buffer.c (Fmove_overlay): Revert the change of 2012-04-23.
4522 That is, do not delete an evaporating overlay if it becomes
4523 empty after its bounds are adjusted to fit within its buffer.
4524 This fix caused other problems, and I'm reverting it until we get
4525 to the bottom of them.
4527 2012-04-27 Chong Yidong <cyd@gnu.org>
4529 * xselect.c (x_convert_selection): Initialize a pointer (Bug#11315).
4531 2012-04-27 Eli Zaretskii <eliz@gnu.org>
4533 * xdisp.c (pos_visible_p): If the window start position is beyond
4534 ZV, start the display from buffer beginning. Prevents assertion
4535 violation in init_iterator when the minibuffer window is scrolled
4538 * window.c (window_scroll_pixel_based): Likewise.
4540 2012-04-27 Chong Yidong <cyd@gnu.org>
4542 * keymap.c (where_is_internal): Doc fix (Bug#10872).
4544 2012-04-27 Glenn Morris <rgm@gnu.org>
4546 * fileio.c (Fcopy_file, Fset_file_selinux_context):
4547 Ignore ENOTSUP failures from setfilecon functions. (Bug#11245)
4549 2012-04-27 Eli Zaretskii <eliz@gnu.org>
4551 * dispnew.c (swap_glyph_pointers, copy_row_except_pointers):
4552 Don't overrun array limits of glyph row's used[] array. (Bug#11288)
4554 2012-04-26 Eli Zaretskii <eliz@gnu.org>
4556 * xdisp.c (IT_DISPLAYING_WHITESPACE): In addition to the loaded
4557 display element, check also the underlying string or buffer
4558 character. (Bug#11341)
4560 * w32menu.c: Include w32heap.h.
4561 (add_menu_item): If the call to AppendMenuW (via
4562 unicode_append_menu) fails, disable Unicode menus only if we are
4563 running on Windows 9X/Me.
4565 2012-04-24 Andreas Schwab <schwab@linux-m68k.org>
4567 * .gdbinit (xpr): Handle USE_2_TAGS_FOR_INTS.
4568 (xgetint): Add missing shift for LSB tags.
4570 2012-04-24 Martin Rudalics <rudalics@gmx.at>
4572 * keyboard.c (read_char): Don't wipe echo area for select window
4573 events: These might get delayed via `mouse-autoselect-window'
4576 2012-04-24 Juanma Barranquero <lekktu@gmail.com>
4578 * gnutls.c (init_gnutls_functions): Protect against (unlikely)
4579 manipulation of :loaded-from data.
4581 2012-04-23 Juanma Barranquero <lekktu@gmail.com>
4583 * gnutls.c (init_gnutls_functions): The value of :loaded-from is
4584 now a cons (bug#11311).
4586 2012-04-23 Paul Eggert <eggert@cs.ucla.edu>
4588 Do not create empty overlays with the evaporate property (Bug#9642).
4589 * buffer.c (Fmove_overlay): Delete an evaporating overlay
4590 if it becomes empty after its bounds are adjusted to fit within
4591 its buffer. Without this fix, in a nonempty buffer (let ((o
4592 (make-overlay 1 2))) (overlay-put o 'evaporate t) (move-overlay o 0 1))
4593 yields an empty overlay that has the evaporate property, which is
4594 not supposed to happen.
4596 Fix minor GTK3 problems found by static checking.
4597 * emacsgtkfixed.c (EMACS_TYPE_FIXED, EMACS_FIXED, EmacsFixed)
4598 (EmacsFixedPrivate, EmacsFixedClass, struct _EmacsFixed)
4599 (struct _EmacsFixedClass, emacs_fixed_get_type):
4600 Move decls here from emacsgtkfixed.h, since they needn't be public.
4601 (emacs_fixed_get_type): Now static.
4602 (emacs_fixed_class_init): Omit unused local.
4603 (emacs_fixed_child_type): Remove; unused.
4604 * emacsgtkfixed.h (EMACS_TYPE_FIXED, EMACS_FIXED, EmacsFixed)
4605 (EmacsFixedPrivate, EmacsFixedClass, struct _EmacsFixed)
4606 (struct _EmacsFixedClass): Move to emacsgtkfixed.c.
4607 (EMACS_FIXED_CLASS, EMACS_IS_FIXED, EMACS_IS_FIXED_CLASS)
4608 (EMACS_FIXED_GET_CLASS): Remove; unused.
4609 * gtkutil.c (xg_create_frame_widgets) [!HAVE_GTK3]: Omit unused local.
4611 * keyboard.c (handle_async_input): Define only if SYNC_INPUT || SIGIO.
4612 Problem reported by Juanma Barranquero for Windows -Wunused-function.
4614 2012-04-22 Paul Eggert <eggert@cs.ucla.edu>
4616 Modernize and clean up gmalloc.c to assume C89 (Bug#9119).
4617 * gmalloc.c (_MALLOC_INTERNAL, _MALLOC_H, _PP, __ptr_t)
4618 (__malloc_size_t, __malloc_ptrdiff_t):
4619 Remove. All uses removed, replaced by the definiens if needed,
4620 since we can assume C89 or better now.
4621 Include <stdint.h>, for PTRDIFF_MAX, uintptr_t.
4622 (protect_malloc_state, align, get_contiguous_space)
4623 (malloc_atfork_handler_prepare, malloc_atfork_handler_parent)
4624 (malloc_atfork_handler_child, malloc_enable_thread)
4625 (malloc_initialize_1, __malloc_initialize, morecore_nolock)
4626 (_malloc_internal_nolock, _malloc_internal, malloc, _malloc)
4627 (_free, _realloc, _free_internal_nolock, _free_internal, free, cfree)
4628 (special_realloc, _realloc_internal_nolock, _realloc_internal)
4629 (realloc, calloc, __default_morecore, memalign, valloc, checkhdr)
4630 (freehook, mallochook, reallochook, mabort, mcheck, mprobe):
4631 Define using prototypes, not old style.
4632 (align, _malloc_internal_nolock, _free_internal_nolock, memalign):
4633 Don't assume ptrdiff_t and uintptr_t are no wider than unsigned long.
4634 (align): Don't assume that signed integer overflow wraps around.
4635 Omit unused local var.
4636 (malloc_initialize_1, morecore_nolock, _malloc_internal_nolock)
4637 (_free_internal_nolock, memalign, mallochook, reallochook):
4638 Omit no-longer-needed casts.
4639 (valloc): Use getpagesize, not __getpagesize.
4640 (MAGICWORD, MAGICFREE): Now randomish size_t values, not 32-bit.
4641 (struct hdr): The 'magic' member is now size_t, not unsigned long.
4643 * dbusbind.c (XD_DBUS_VALIDATE_OBJECT): Define only if needed.
4645 2012-04-22 Michael Albinus <michael.albinus@gmx.de>
4647 Move functions from C to Lisp. Make non-blocking method calls
4648 the default. Implement further D-Bus standard interfaces.
4650 * dbusbind.c (DBUS_NUM_MESSAGE_TYPES): Declare.
4651 (QCdbus_request_name_allow_replacement)
4652 (QCdbus_request_name_replace_existing)
4653 (QCdbus_request_name_do_not_queue)
4654 (QCdbus_request_name_reply_primary_owner)
4655 (QCdbus_request_name_reply_in_queue)
4656 (QCdbus_request_name_reply_exists)
4657 (QCdbus_request_name_reply_already_owner): Move to dbus.el.
4658 (QCdbus_registered_serial, QCdbus_registered_method)
4659 (QCdbus_registered_signal): New Lisp objects.
4660 (XD_DEBUG_MESSAGE): Use sizeof.
4661 (XD_MESSAGE_TYPE_TO_STRING, XD_OBJECT_TO_STRING)
4662 (XD_DBUS_VALIDATE_BUS_ADDRESS, XD_DBUS_VALIDATE_OBJECT)
4663 (XD_DBUS_VALIDATE_BUS_NAME, XD_DBUS_VALIDATE_PATH)
4664 (XD_DBUS_VALIDATE_INTERFACE, XD_DBUS_VALIDATE_MEMBER): New macros.
4665 (XD_CHECK_DBUS_SERIAL): Rename from CHECK_DBUS_SERIAL_GET_SERIAL.
4666 (xd_signature, xd_append_arg): Allow float for integer types.
4667 (xd_get_connection_references): New function.
4668 (xd_get_connection_address): Rename from xd_initialize.
4669 Return cached address.
4670 (xd_remove_watch): Do not unset $DBUS_SESSION_BUS_ADDRESS.
4671 (xd_close_bus): Rename from Fdbus_close_bus. Not needed on Lisp
4673 (Fdbus_init_bus): New optional arg PRIVATE. Cache address.
4674 Return number of refcounts.
4675 (Fdbus_get_unique_name): Make stronger parameter check.
4676 (Fdbus_message_internal): New defun.
4677 (Fdbus_call_method, Fdbus_call_method_asynchronously)
4678 (Fdbus_method_return_internal, Fdbus_method_error_internal)
4679 (Fdbus_send_signal, Fdbus_register_service)
4680 (Fdbus_register_signal, Fdbus_register_method): Move to dbus.el.
4681 (xd_read_message_1): Obey new structure of Vdbus_registered_objects.
4682 (xd_read_queued_messages): Obey new structure of Vdbus_registered_buses.
4683 (Vdbus_compiled_version, Vdbus_runtime_version)
4684 (Vdbus_message_type_invalid, Vdbus_message_type_method_call)
4685 (Vdbus_message_type_method_return, Vdbus_message_type_error)
4686 (Vdbus_message_type_signal): New defvars.
4687 (Vdbus_registered_buses, Vdbus_registered_objects_table):
4690 2012-04-22 Paul Eggert <eggert@cs.ucla.edu>
4692 Fix GC_MALLOC_CHECK debugging output on 64-bit hosts.
4693 * alloc.c (emacs_blocked_malloc) [GC_MALLOC_CHECK]:
4694 Do not assume ptrdiff_t is the same width as 'int'.
4696 * alloc.c: Handle unusual debugging option combinations.
4697 (GC_CHECK_MARKED_OBJECTS): Undef if ! GC_MARK_STACK,
4698 since the two debugging options are incompatible.
4699 (GC_MALLOC_CHECK): Similarly, undef if GC_CHECK_MARKED_OBJECTS
4701 (mem_init, mem_insert, mem_insert_fixup):
4702 Define if GC_MARK_STACK || GC_MALLOC_CHECK.
4703 (NEED_MEM_INSERT): Remove; no longer needed.
4705 2012-04-22 Leo Liu <sdl.web@gmail.com>
4707 * sysdep.c (list_system_processes): Support Darwin (Bug#5725).
4709 2012-04-22 Paul Eggert <eggert@cs.ucla.edu>
4711 * sysdep.c [__FreeBSD__]: Minor cleanups.
4712 (list_system_processes, system_process_attributes) [__FreeBSD__]:
4713 Use Emacs indenting style more consistently. Avoid some casts.
4714 Use 'double' consistently rather than mixing 'float' and 'double'.
4716 2012-04-21 Eduard Wiebe <usenet@pusto.de>
4718 * sysdep.c (list_system_processes, system_process_attributes):
4719 Add implementation for FreeBSD (Bug#5243).
4721 2012-04-21 Andreas Schwab <schwab@linux-m68k.org>
4723 * lisp.mk (lisp): Update.
4725 2012-04-20 Paul Eggert <eggert@cs.ucla.edu>
4727 * keyboard.c (process_pending_signals): Define only if SYNC_INPUT.
4728 It is never used otherwise.
4730 2012-04-20 Stefan Monnier <monnier@iro.umontreal.ca>
4732 * print.c (print_preprocess): Only check print_depth if print-circle
4734 (print_object): Check for cycles even when print-circle is nil and
4735 print-gensym is t, but only check print_depth if print-circle is nil.
4737 2012-04-20 Chong Yidong <cyd@gnu.org>
4739 * process.c (wait_reading_process_output): If EIO occurs on a pty,
4740 set the status to "failed" and ensure that sentinel is run.
4742 2012-04-20 Glenn Morris <rgm@gnu.org>
4744 * process.c (Fset_process_inherit_coding_system_flag)
4745 (Fset_process_query_on_exit_flag): Doc fix (mention return value).
4746 (Fmake_network_process, Fmake_serial_process): Doc fix.
4748 2012-04-20 Eli Zaretskii <eliz@gnu.org>
4750 * xdisp.c (string_buffer_position_lim): Limit starting position to
4752 (set_cursor_from_row): If called for a mode-line or header-line
4753 row, return zero immediately.
4754 (try_cursor_movement): If inside continuation line, don't back up
4755 farther than the first row after the header line, if any.
4756 Don't consider the header-line row as "partially visible", even if
4757 MATRIX_ROW_PARTIALLY_VISIBLE_P returns non-zero. (Bug#11261)
4759 2012-04-20 Atsuo Ohki <ohki@gssm.otsuka.tsukuba.ac.jp> (tiny change)
4761 * lread.c (lisp_file_lexically_bound_p): Fix hang at ";-*-\n"
4764 2012-04-20 Teodor Zlatanov <tzz@lifelogs.com>
4765 2012-04-18 Paul Eggert <eggert@cs.ucla.edu>
4767 configure: new option --enable-gcc-warnings (Bug#11207)
4768 * Makefile.in (C_WARNINGS_SWITCH): Remove.
4769 (WARN_CFLAGS, WERROR_CFLAGS): New macros.
4770 (ALL_CFLAGS): Use new macros rather than old.
4771 * process.c: Ignore -Wstrict-overflow to work around GCC bug 52904.
4772 * regex.c: Ignore -Wstrict-overflow. If !emacs, also ignore
4773 -Wunused-but-set-variable, -Wunused-function, -Wunused-macros,
4774 -Wunused-result, -Wunused-variable. This should go away once
4775 the Emacs and Gnulib regex code is merged.
4776 (xmalloc, xrealloc): Now static.
4778 2012-04-17 Paul Eggert <eggert@cs.ucla.edu>
4780 * dired.c (Fsystem_groups): Remove unused local.
4782 2012-04-17 Glenn Morris <rgm@gnu.org>
4784 * dired.c (Fsystem_users): Doc fix.
4786 2012-04-17 Dmitry Antipov <dmantipov@yandex.ru>
4788 * dired.c (Fsystem_users, Fsystem_groups): New functions. (Bug#7900)
4789 (syms_of_dired): Add them.
4791 2012-04-16 Paul Eggert <eggert@cs.ucla.edu>
4793 Fix minor alloc.c problems found by static checking.
4794 * alloc.c (_malloc_internal, _free_internal) [!DOUG_LEA_MALLOC]:
4795 New extern decls, to avoid calling undeclared functions.
4796 (dont_register_blocks): Define if ((!SYSTEM_MALLOC && !SYNC_INPUT)
4797 && GC_MALLOC_CHECK), not if ((GC_MARK_STACK || defined
4798 GC_MALLOC_CHECK) && GC_MALLOC_CHECK), to match when it's used.
4799 (NEED_MEM_INSERT): New macro.
4800 (mem_insert, mem_insert_fixup) [!NEED_MEM_INSERT]: Remove; unused.
4801 Remove one incorrect comment and fix another.
4803 Fix minor ralloc.c problems found by static checking.
4804 See http://lists.gnu.org/archive/html/emacs-devel/2011-12/msg00720.html
4805 * ralloc.c (ALIGNED, ROUND_TO_PAGE, HEAP_PTR_SIZE)
4806 (r_alloc_size_in_use, r_alloc_freeze, r_alloc_thaw): Remove; unused.
4807 (r_alloc_sbrk): Now static.
4809 Improve ralloc.c interface checking.
4810 See http://lists.gnu.org/archive/html/emacs-devel/2011-12/msg00720.html
4811 * buffer.c (ralloc_reset_variable, r_alloc, r_re_alloc)
4812 (r_alloc_free) [REL_ALLOC]: Move decls from here ...
4813 * lisp.h (r_alloc, r_alloc_free, r_re_alloc, r_alloc_reset_variable)
4814 [REL_ALLOC]: ... to here, to check interface.
4815 * m/ia64.h (r_alloc, r_alloc_free) [REL_ALLOC && !_MALLOC_INTERNAL]:
4816 Remove decls. This fixes an "It stinks!".
4818 * alloc.c (which_symbols): Fix alignment issue / type clash.
4820 2012-04-15 Andreas Schwab <schwab@linux-m68k.org>
4822 * lisp.h (struct Lisp_Symbol): Remove explicit padding.
4823 (struct Lisp_Misc_Any): Likewise.
4824 (struct Lisp_Free): Likewise.
4825 * alloc.c (union aligned_Lisp_Symbol): Define.
4826 (SYMBOL_BLOCK_SIZE, struct symbol_block): Use union
4827 aligned_Lisp_Symbol instead of struct Lisp_Symbol.
4828 (union aligned_Lisp_Misc): Define.
4829 (MARKER_BLOCK_SIZE, struct marker_block): Use union
4830 aligned_Lisp_Misc instead of union Lisp_Misc.
4831 (Fmake_symbol, allocate_misc, gc_sweep): Adjust.
4833 2012-04-14 Paul Eggert <eggert@cs.ucla.edu>
4835 Make GC_MAKE_GCPROS_NOOPS the default (Bug#9926).
4836 * lisp.h (GC_MARK_STACK): Default to GC_MAKE_GCPROS_NOOPS.
4837 * s/cygwin.h, s/darwin.h, s/freebsd.h, s/gnu.h, s/irix6-5.h, s/msdos.h:
4838 * s/netbsd.h, s/sol2-6.h:
4839 Remove definition of GC_MARK_STACK, since the default now works.
4840 * s/aix4-2.h, s/hpux10-20.h, s/unixware.h:
4841 Define GC_MARK_STACK to GC_USE_GCPROS_AS_BEFORE, since that's
4842 no longer the default.
4843 * s/gnu-linux.h (GC_MARK_STACK): Adjust to change in default.
4845 2012-04-14 Atsuo Ohki <ohki@gssm.otsuka.tsukuba.ac.jp> (tiny change)
4847 * lread.c (lisp_file_lexically_bound_p):
4848 Fix hang at ";-*-\n" (bug#11238).
4850 2012-04-14 Eli Zaretskii <eliz@gnu.org>
4852 * xdisp.c (find_last_unchanged_at_beg_row): Don't consider a row
4853 "unchanged" if its end.pos is beyond ZV. (Bug#11199)
4855 2012-04-14 Jan Djärv <jan.h.d@swipnet.se>
4857 * nsterm.m (constrainFrameRect): Always constrain when there is only
4858 one screen (Bug#10962).
4860 2012-04-13 Ken Brown <kbrown@cornell.edu>
4862 * s/cygwin.h (PTY_OPEN): Don't try to close a bogus file descriptor.
4864 2012-04-13 Reuben Thomas <rrt@sc3d.org>
4866 * indent.c (Fmove_to_column): Change interactive spec (Bug#739).
4868 2012-04-11 Daniel Colascione <dancol@dancol.org>
4870 * s/cygwin.h: The vfork the #define in cygwin.h was protecting
4871 against is gone. It's better to use vfork now so that when Cygwin
4872 gains a new, working vfork, we use it automatically (bug#10398).
4874 2012-04-11 Stefan Monnier <monnier@iro.umontreal.ca>
4876 * window.c (save_window_save): Obey window-point-insertion-type.
4878 2012-04-11 Glenn Morris <rgm@gnu.org>
4880 * Makefile.in (GNUSTEP_CFLAGS): Rename from C_SWITCH_X_SYSTEM.
4882 2012-04-11 Stefan Monnier <monnier@iro.umontreal.ca>
4884 * alloc.c (lisp_align_malloc): Remove unneeded prototype.
4886 2012-04-10 Jason S. Cornez <jcornez@ravenpack.com> (tiny change)
4888 * keyboard.c: Override inhibit-quit after the third C-g (bug#6585).
4889 (force_quit_count): New var.
4890 (handle_interrupt): Use it.
4892 2012-04-10 Juanma Barranquero <lekktu@gmail.com>
4894 * w32.c (w32_delayed_load): Record the full path of the library
4895 being loaded (bug#10424).
4897 2012-04-09 Glenn Morris <rgm@gnu.org>
4899 * doc.c (Fsnarf_documentation): Check variables, functions are bound,
4900 not just in the obarray, before snarfing them. (Bug#11036)
4902 * Makefile.in ($(leimdir)/leim-list.el):
4903 Pass EMACS rather than BUILT_EMACS.
4905 2012-04-09 Teodor Zlatanov <tzz@lifelogs.com>
4907 * process.c (make_process):
4908 * process.h: Add integer `gnutls_handshakes_tried' member to
4911 * gnutls.h: Add `GNUTLS_EMACS_HANDSHAKES_LIMIT' upper limit.
4912 Add convenience `GNUTLS_LOG2i' macro.
4914 * gnutls.c (gnutls_log_function2i): Convenience log function.
4915 (emacs_gnutls_read): Use new log functions,
4916 `gnutls_handshakes_tried' process member, and
4917 `GNUTLS_EMACS_HANDSHAKES_LIMIT' to limit the number of handshake
4918 attempts per process (connection).
4920 2012-04-09 Chong Yidong <cyd@gnu.org>
4922 * eval.c (Fuser_variable_p, user_variable_p_eh)
4923 (lisp_indirect_variable): Functions deleted.
4924 (Fdefvar): Caller changed.
4926 * callint.c (Finteractive, Fcall_interactively):
4927 * minibuf.c (Fread_variable): Callers changed.
4929 2012-04-09 Eli Zaretskii <eliz@gnu.org>
4931 * xdisp.c (set_cursor_from_row): If the display string appears in
4932 the buffer at position that is closer to point than the position
4933 after the display string, display the cursor on the first glyph of
4934 the display string. Fixes cursor display when a 'display' text
4935 property immediately follows invisible text. (Bug#11094)
4937 2012-04-09 Paul Eggert <eggert@cs.ucla.edu>
4939 composite.c: use 'double' consistently
4940 * composite.c (get_composition_id): Use 'double' consistently
4941 instead of converting 'float' to 'double' and vice versa; this is
4942 easier to understand and avoids a GCC warning.
4944 2012-04-09 Glenn Morris <rgm@gnu.org>
4946 * Makefile.in: Generate leim-list with bootstrap-emacs, in
4947 preparation for dumping it with emacs. (Bug#4789)
4948 (leimdir): New variable.
4949 ($(leimdir)/leim-list.el): New rule.
4950 (emacs$(EXEEXT)): Depend on leim-list.el.
4952 * buffer.c (Qucs_set_table_for_input): Remove. (Bug#9821)
4953 (Fget_buffer_create): Don't call Qucs_set_table_for_input.
4954 (init_buffer_once, syms_of_buffer): Remove Qucs_set_table_for_input.
4956 2012-04-08 Andreas Schwab <schwab@linux-m68k.org>
4958 * lisp.h (struct Lisp_Symbol): Add explicit padding to ensure
4961 2012-04-07 Juanma Barranquero <lekktu@gmail.com>
4963 * xml.c (init_libxml2_functions) [WINDOWSNT]:
4964 Remove unused local variable.
4966 2012-04-07 Paul Eggert <eggert@cs.ucla.edu>
4968 Avoid unnecessary pointer scanning in garbage collection (Bug#10780).
4969 * alloc.c (POINTERS_MIGHT_HIDE_IN_OBJECTS): New macro.
4970 (mark_memory): Mark Lisp_Objects only if pointers might hide in
4971 objects, as mark_maybe_pointer will catch them otherwise.
4972 (GC_LISP_OBJECT_ALIGNMENT): Remove; no longer needed.
4973 * s/gnu-linux.h (GC_LISP_OBJECT_ALIGNMENT) [__mc68000__]: Likewise.
4975 2012-04-07 Paul Eggert <eggert@cs.ucla.edu>
4977 Fix typo that broke non-Windows builds.
4978 * xml.c (libxml2_loaded_p) [!!WINDOWSNT]: 'inine' -> 'inline'.
4980 2012-04-07 Eli Zaretskii <eliz@gnu.org>
4982 Support building on MS-Windows with libxml2.
4984 * makefile.w32-in (OBJ2): Add xml.$(O).
4985 (GLOBAL_SOURCES): Add xml.c.
4986 ($(BLD)/xml.$(O)): New dependency list.
4988 * xml.c (DEF_XML2_FN, LOAD_XML2_FN) [WINDOWSNT]: New macros.
4989 (fn_htmlReadMemory, fn_xmlReadMemory, fn_xmlDocGetRootElement)
4990 (fn_xmlFreeDoc, fn_xmlCleanupParser, fn_xmlCheckVersion)
4991 [!WINDOWSNT]: New macros.
4992 (init_libxml2_functions, libxml2_loaded_p): New functions.
4993 (parse_region): Call fn_xmlCheckVersion instead of using the macro
4994 LIBXML_TEST_VERSION. Call libxml2 functions via the fn_* macros.
4995 (xml_cleanup_parser): New function, export for fn_xmlCleanupParser.
4996 Calls xmlCleanupParser only if libxml2 was loaded (or statically
4998 (Flibxml_parse_html_region, Flibxml_parse_xml_region):
4999 Call init_libxml2_functions before calling libxml2 functions.
5000 (syms_of_xml) <Qlibxml2_dll>: DEFSYM it.
5002 * emacs.c: Don't include libxml/parser.h.
5003 (shut_down_emacs): Call xml_cleanup_parser, instead of calling
5004 xmlCleanupParser directly.
5006 * lisp.h [HAVE_LIBXML2]: Add prototype for xml_cleanup_parser.
5008 2012-04-07 Eli Zaretskii <eliz@gnu.org>
5010 * indent.c (Fvertical_motion): If there is a display string at
5011 point, use it.vpos to compute how many lines to backtrack after
5012 move_it_to point. (Bug#11133)
5014 2012-04-06 Eli Zaretskii <eliz@gnu.org>
5016 * buffer.h (FETCH_CHAR, FETCH_MULTIBYTE_CHAR):
5017 * character.h (STRING_CHAR, STRING_CHAR_AND_LENGTH): Add comments
5018 about subtle differences between FETCH_CHAR* and STRING_CHAR*
5019 macros related to unification of CJK characters. For the details,
5020 see the discussion following the message here:
5021 http://debbugs.gnu.org/cgi/bugreport.cgi?bug=11073#14.
5023 2012-04-04 Chong Yidong <cyd@gnu.org>
5025 * keyboard.c (Vdelayed_warnings_list): Doc fix.
5027 2012-04-01 Eli Zaretskii <eliz@gnu.org>
5029 * w32menu.c (simple_dialog_show, add_menu_item): Use SAFE_ALLOCA
5030 instead of alloca. (Bug#11138)
5032 2012-04-01 Andreas Schwab <schwab@linux-m68k.org>
5034 * w32menu.c (is_simple_dialog): Properly check lisp types.
5037 2012-03-31 Eli Zaretskii <eliz@gnu.org>
5039 * xdisp.c (move_it_by_lines): When DVPOS is positive, and the
5040 position we get to after a call to move_it_to fails the
5041 IS_POS_VALID_AFTER_MOVE_P test, move to the next buffer position
5042 only if we wind up in a string from display property. (Bug#11063)
5044 * window.c (Fdelete_other_windows_internal): Invalidate the row
5045 and column information about mouse highlight, so that redisplay
5046 restores it after reallocating the glyph matrices. (Bug#7464)
5048 * xdisp.c (set_cursor_from_row): If `cursor' property on a display
5049 string comes from a `display' text property, use the buffer
5050 position of that property as if we actually saw that position in
5052 (move_it_by_lines): Remove the assertion that
5053 "it->current_x == 0 && it->hpos == 0" which can be legitimately
5054 violated when there's a before-string at the beginning of a line.
5057 2012-03-30 Eli Zaretskii <eliz@gnu.org>
5059 * xdisp.c (append_space_for_newline): If the default face was
5060 remapped, use the remapped face for the appended newline.
5061 (extend_face_to_end_of_line): Use the remapped default face for
5062 extending the face to the end of the line.
5063 (display_line): Call extend_face_to_end_of_line when the default
5064 face was remapped. (Bug#11068)
5066 2012-03-29 Eli Zaretskii <eliz@gnu.org>
5068 * s/ms-w32.h: Discourage from defining HAVE_GETCWD.
5070 2012-03-28 Stefan Monnier <monnier@iro.umontreal.ca>
5072 * keyboard.c (safe_run_hooks_error): Don't unquote strings.
5074 2012-03-27 Glenn Morris <rgm@gnu.org>
5076 * search.c (Fword_search_backward_lax, Fword_search_forward_lax):
5079 2012-03-26 Kenichi Handa <handa@m17n.org>
5081 * dispextern.h (struct glyph): Fix previous change. Change the
5082 bit length of glyphless.ch to 25 (Bug#11082).
5084 2012-03-26 Chong Yidong <cyd@gnu.org>
5086 * keyboard.c (Vselection_inhibit_update_commands): New variable.
5087 (command_loop_1): Use it; inhibit selection update for
5088 handle-select-window too (Bug#8996).
5090 2012-03-25 Fabrice Popineau <fabrice.popineau@supelec.fr>
5092 * w32heap.c (_heap_init, _heap_term): Remove dead MSVC-specific code.
5094 2012-03-25 Kenichi Handa <handa@m17n.org>
5096 * dispextern.h (struct glyph): Change the bit length of
5097 glyphless.ch to 22 to make the member glyphless fit in 32 bits.
5099 2012-03-24 Eli Zaretskii <eliz@gnu.org>
5101 * s/ms-w32.h (tzname): Include time.h before redirecting to
5102 _tzname. Fixes the MSVC build. (Bug#9960)
5104 2012-03-24 Andreas Schwab <schwab@linux-m68k.org>
5106 * xdisp.c (produce_glyphless_glyph): Limit length of acronym to 6
5109 * xterm.c (XTread_socket): Only modify handling_signal if
5110 !SYNC_INPUT. (Bug#11080)
5112 2012-03-23 Eli Zaretskii <eliz@gnu.org>
5114 * bidi.c (bidi_fetch_char): Use STRING_CHAR_AND_LENGTH instead of
5115 FETCH_MULTIBYTE_CHAR followed by CHAR_BYTES. Prevents crashes
5116 when fetching a multibyte character consumes more bytes than
5117 CHAR_BYTES returns, due to unification of CJK characters in
5118 string_char. (Bug#11073)
5120 2012-03-23 Troels Nielsen <bn.troels@gmail.com> (tiny change)
5122 * process.c (wait_reading_process_output): Handle pty disconnect
5123 by refraining from sending oneself a SIGCHLD (bug#10933).
5125 2012-03-22 Chong Yidong <cyd@gnu.org>
5127 * dispextern.h (struct it): New member string_from_prefix_prop_p.
5129 * xdisp.c (push_prefix_prop): Rename from push_display_prop.
5130 Mark string as coming from a prefix property.
5131 (handle_face_prop): Use default face for prefix strings (Bug#4281).
5132 (pop_it, reseat_1): Save and restore string_from_prefix_prop_p.
5134 2012-03-21 Chong Yidong <cyd@gnu.org>
5136 * xfaces.c (Vface_remapping_alist): Doc fix.
5138 2012-03-20 Eli Zaretskii <eliz@gnu.org>
5140 * w32proc.c (Fw32_set_console_codepage)
5141 (Fw32_set_console_output_codepage, Fw32_get_codepage_charset):
5144 2012-03-20 Chong Yidong <cyd@gnu.org>
5146 * dispnew.c (Fredisplay, Vredisplay_preemption_period): Update doc
5147 to reflect default non-nil value of redisplay-dont-pause.
5149 2012-03-19 Kenichi Handa <handa@m17n.org>
5151 * ftfont.c (ftfont_drive_otf): Mask bits of character code to make
5152 it fit in a valid range (Bug#11003).
5154 2012-03-18 Eli Zaretskii <eliz@gnu.org>
5156 * xdisp.c (cursor_row_p): Even if the glyph row ends in a string
5157 that is not from display property, accept the row as a "cursor
5158 row" if one of the string's character has a non-nil `cursor'
5159 property. Fixes cursor positioning when there are newlines in
5160 overlay strings, e.g. in icomplete.el. (Bug#11035)
5162 2012-03-12 Paul Eggert <eggert@cs.ucla.edu>
5164 * buffer.c (compare_overlays): Don't assume args differ (Bug#6830).
5166 2012-03-12 Chong Yidong <cyd@gnu.org>
5168 * eval.c (inhibit_lisp_code): Rename from
5169 inhibit_window_configuration_change_hook; move from window.c.
5171 * xfns.c (unwind_create_frame_1, Fx_create_frame):
5172 * window.c (run_window_configuration_change_hook)
5173 (syms_of_window): Callers changed.
5175 2012-03-11 Chong Yidong <cyd@gnu.org>
5177 * keymap.c (Fkey_description): Doc fix (Bug#9700).
5179 * editfns.c (Fconstrain_to_field): Doc fix (Bug#9452).
5181 2012-03-10 Chong Yidong <cyd@gnu.org>
5183 * frame.c (other_visible_frames): Don't assume the selected frame
5184 is visible (Bug#10955).
5186 2012-03-09 Stefan Monnier <monnier@iro.umontreal.ca>
5188 * buffer.c (compare_overlays): Avoid qsort's instability (bug#6830).
5190 2012-03-08 Jan Djärv <jan.h.d@swipnet.se>
5192 * gtkutil.c (x_wm_set_size_hint): Use one row in call to
5193 FRAME_TEXT_LINES_TO_PIXEL_HEIGHT so base_height is greater than
5196 2012-03-03 Glenn Morris <rgm@gnu.org>
5198 * alloc.c (Fgarbage_collect, misc-objects-consed): Doc fixes.
5200 2012-03-02 Eli Zaretskii <eliz@gnu.org>
5202 * xdisp.c (try_window_reusing_current_matrix): Don't move cursor
5203 position past the first glyph_row that ends at ZV. (Bug#10902)
5204 (redisplay_window, next_element_from_string): Fix typos in
5206 (redisplay_window): Pass to move_it_vertically the margin in
5207 pixels, not in screen lines.
5209 2012-03-02 Glenn Morris <rgm@gnu.org>
5211 * buffer.c (buffer-list-update-hook): Doc fix.
5213 2012-02-29 Eli Zaretskii <eliz@gnu.org>
5215 * xdisp.c (get_overlay_strings_1): Under bidi redisplay, call
5216 push_it before setting up the iterator for the first overlay
5217 string, even if we have an empty string loaded.
5218 (next_overlay_string): If there's an empty string on the iterator
5219 stack, pop the stack. (Bug#10903)
5221 2012-02-25 Paul Eggert <eggert@cs.ucla.edu>
5223 Generalize fix for crash due to non-contiguous EMACS_INT (Bug#10780).
5224 Suggested by Stefan Monnier in
5225 <http://lists.gnu.org/archive/html/emacs-devel/2012-02/msg00692.html>.
5226 * alloc.c (widen_to_Lisp_Object): New static function.
5227 (mark_memory): Also mark Lisp_Objects by fetching pointer words
5228 and widening them to Lisp_Objects. This would work even if
5229 USE_LSB_TAG is defined and wide integers are used, which might
5230 happen in a future version of Emacs.
5232 2012-02-25 Chong Yidong <cyd@gnu.org>
5234 * fileio.c (Ffile_selinux_context, Fset_file_selinux_context):
5237 * xselect.c (Fx_selection_exists_p): Doc fix.
5238 (x_clipboard_manager_save_all): Print an informative message
5239 before saving to clipboard manager.
5241 2012-02-24 Chong Yidong <cyd@gnu.org>
5243 * keyboard.c (process_special_events): Handle all X selection
5244 requests in kbd_buffer, not just the next one (Bug#8869).
5246 2012-02-23 Chong Yidong <cyd@gnu.org>
5248 * xfns.c (Fx_create_frame): Avoid window-configuration-change-hook
5249 call when setting menu-bar-lines and tool-bar-lines parameters.
5250 (unwind_create_frame_1): New helper function.
5252 * window.c (inhibit_window_configuration_change_hook): New var.
5253 (run_window_configuration_change_hook): Obey it.
5254 (syms_of_window): Initialize it.
5256 2012-02-22 Chong Yidong <cyd@gnu.org>
5258 * xterm.c (x_draw_image_relief): Add missing type check for
5259 Vtool_bar_button_margin (Bug#10743).
5261 2012-02-21 Chong Yidong <cyd@gnu.org>
5263 * fileio.c (Vfile_name_handler_alist): Doc fix.
5265 * buffer.c (Fget_file_buffer): Protect against invalid file
5266 handler return value.
5268 2012-02-20 Paul Eggert <eggert@cs.ucla.edu>
5270 * .gdbinit (xreload): Don't assume EMACS_INT fits in 'long'
5271 when computing $valmask.
5273 Fix crash due to non-contiguous EMACS_INT (Bug#10780).
5274 * lisp.h (VALBITS): Move definition up, so that USE_LSB_TAG can use it.
5275 (USE_LSB_TAG): Do not define if UINTPTR_MAX >> VALBITS == 0.
5276 It's useless in that case, and it can cause problems on hosts
5277 that allocate halves of EMACS_INT values separately.
5278 Reported by Dan Horák. Diagnosed by Andreas Schwab in
5279 <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=10780#30>.
5280 * mem-limits.h (EXCEEDS_LISP_PTR): Define to 0 on hosts where
5281 UINTPTR_MAX >> VALBITS == 0. This is required by the above change;
5282 it avoids undefined behavior on hosts where shifting right by more
5283 than the word width has undefined behavior.
5285 2012-02-19 Chong Yidong <cyd@gnu.org>
5287 * fileio.c (Ffile_name_directory, Ffile_name_nondirectory)
5288 (Funhandled_file_name_directory, Ffile_name_as_directory)
5289 (Fdirectory_file_name, Fexpand_file_name)
5290 (Fsubstitute_in_file_name): Protect against invalid file handler
5291 return values (Bug#10845).
5293 2012-02-18 Eli Zaretskii <eliz@gnu.org>
5295 * .gdbinit (pitx): Fix incorrect references to fields of the
5298 2012-02-17 Chong Yidong <cyd@gnu.org>
5300 * syntax.c (Fscan_lists): Doc fix (Bug#10833).
5302 2012-02-15 Paul Eggert <eggert@cs.ucla.edu>
5304 * image.c (MAX_IMAGE_SIZE): Increase from 6.0 to 10.0; see
5305 <http://lists.gnu.org/archive/html/emacs-devel/2012-02/msg00540.html>.
5307 2012-02-15 Chong Yidong <cyd@gnu.org>
5309 * eval.c (Fdefvar, Fdefconst): Doc fix; note that the variable is
5310 marked as special. Also, starting docstrings with * is obsolete.
5312 2012-02-13 Andreas Schwab <schwab@linux-m68k.org>
5314 * gnutls.c (emacs_gnutls_write): Fix last change.
5316 2012-02-13 Lars Ingebrigtsen <larsi@gnus.org>
5318 * gnutls.c (emacs_gnutls_write): Set errno appropriately for
5321 2012-02-13 Stefan Monnier <monnier@iro.umontreal.ca>
5323 * keymap.c (Fsingle_key_description): Handle char ranges.
5325 2012-02-12 Chong Yidong <cyd@gnu.org>
5327 * xdisp.c (handle_stop): Avoid assigning -1 to it->face_id here,
5328 as that creates a dangerous corner case.
5330 * window.c (Fdelete_window_internal): Invalidate the mouse
5331 highlight (Bug#9904).
5333 2012-02-12 Glenn Morris <rgm@gnu.org>
5335 * xselect.c (Fx_own_selection_internal)
5336 (Fx_get_selection_internal, Fx_disown_selection_internal)
5337 (Fx_selection_owner_p, Fx_selection_exists_p): Doc fixes.
5338 * nsselect.m (Fx_own_selection_internal)
5339 (Fx_disown_selection_internal, Fx_selection_exists_p)
5340 (Fx_selection_owner_p, Fx_get_selection_internal):
5341 Sync docs and argument specs with the xselect.c versions.
5343 2012-02-11 Lars Ingebrigtsen <larsi@gnus.org>
5345 * gnutls.c (emacs_gnutls_write): Don't infloop if sendto fails.
5347 2012-02-11 Eli Zaretskii <eliz@gnu.org>
5349 * w32select.c (Fx_selection_exists_p): Sync doc string and
5350 argument list with xselect.c. (Bug#10783)
5352 * w16select.c (Fx_selection_exists_p): Sync doc string and
5353 argument list with xselect.c. (Bug#10783)
5355 2012-02-10 Glenn Morris <rgm@gnu.org>
5357 * fns.c (Fsecure_hash): Doc fix.
5359 2012-02-09 Kenichi Handa <handa@m17n.org>
5361 * coding.c (produce_chars): Fix updating of src_end (Bug#10701).
5363 2012-02-07 Chong Yidong <cyd@gnu.org>
5365 * buffer.c (Fbuffer_local_variables)
5366 (buffer_lisp_local_variables): Handle unbound vars correctly;
5367 don't let Qunbound leak into Lisp.
5369 2012-02-07 Glenn Morris <rgm@gnu.org>
5371 * image.c (Fimagemagick_types): Doc fix.
5373 * image.c (imagemagick-render-type): Change it from a lisp object
5374 to an integer. Move the doc here from the lisp manual.
5375 Treat all values not equal to 0 the same.
5377 2012-02-06 Chong Yidong <cyd@gnu.org>
5379 * doc.c (store_function_docstring): Avoid applying docstring of
5380 alias to base function (Bug#2603).
5382 2012-02-04 Andreas Schwab <schwab@linux-m68k.org>
5384 * .gdbinit (pp1, pv1): Remove redundant defines.
5387 2012-02-04 Chong Yidong <cyd@gnu.org>
5389 * nsterm.m: Declare a global (Bug#10694).
5391 2012-02-04 Eli Zaretskii <eliz@gnu.org>
5393 * w32.c (get_emacs_configuration_options):
5394 Include --enable-checking, if specified, in the return value.
5396 2012-02-04 Martin Rudalics <rudalics@gmx.at>
5398 * dispnew.c (change_frame_size_1): Calculate new_frame_total_cols
5399 after rounding frame sizes. (Bug#9723)
5401 2012-02-04 Eli Zaretskii <eliz@gnu.org>
5403 * keyboard.c (adjust_point_for_property): Don't position point
5404 before BEGV. (Bug#10696)
5406 2012-02-03 Paul Eggert <eggert@cs.ucla.edu>
5408 Handle overflow when computing char display width (Bug#9496).
5409 * character.c (char_width): Return EMACS_INT, not int.
5410 (char_width, c_string_width): Check for overflow when
5411 computing the width; this is possible now that individual
5412 characters can have unbounded width. Problem introduced
5413 by merge from Emacs 23 on 2012-01-19.
5415 2012-02-02 Michael Albinus <michael.albinus@gmx.de>
5417 * dbusbind.c (Fdbus_register_method): Mention the return value
5418 :ignore in the docstring.
5420 2012-02-02 Glenn Morris <rgm@gnu.org>
5422 * callproc.c (Fcall_process, Fcall_process_region): Doc fix.
5424 * nsterm.m (syms_of_nsterm) <x-toolkit-scroll-bars>:
5425 Unconditionally set to t. (Bug#10673)
5426 * nsterm.m (syms_of_nsterm) <x-toolkit-scroll-bars>:
5427 * w32term.c (syms_of_w32term) <x-toolkit-scroll-bars>:
5428 * xterm.c (syms_of_xterm) <x-toolkit-scroll-bars>: Doc fix.
5430 2012-02-02 Kenichi Handa <handa@m17n.org>
5432 (x_produce_glyphs): Cancel previous change. If cmp->glyph_len is
5433 0, do not call append_composite_glyph.
5435 2012-02-02 Kenichi Handa <handa@m17n.org>
5437 * xdisp.c (BUILD_COMPOSITE_GLYPH_STRING): Initialize first_s to
5439 (x_produce_glyphs): If the component of a composition is a null
5440 string, set it->pixel_width to 1 to avoid zero-width glyph.
5442 2012-02-01 Eli Zaretskii <eliz@gnu.org>
5444 * ralloc.c (resize_bloc, r_alloc_sbrk): Don't call memmove if its
5445 first 2 arguments are identical. This makes inserting large
5446 output from a subprocess an order of magnitude faster on
5447 MS-Windows, where all sbrk'ed memory is always contiguous.
5449 2012-01-31 Glenn Morris <rgm@gnu.org>
5451 * nsterm.m (syms_of_nsterm) <x-toolkit-scroll-bars>:
5452 * w32term.c (syms_of_w32term) <x-toolkit-scroll-bars>:
5453 * xterm.c (syms_of_xterm) <x-toolkit-scroll-bars>: Sync docs.
5455 2012-01-29 Glenn Morris <rgm@gnu.org>
5457 * gnutls.c (syms_of_gnutls): More doc (from etc/NEWS).
5459 2012-01-28 Samuel Thibault <sthibault@debian.org> (tiny change)
5461 * s/gnu.h: Define POSIX_SIGNALS (Bug#10552).
5463 2012-01-28 Chong Yidong <cyd@gnu.org>
5465 * minibuf.c (syms_of_minibuf): Doc fix (Bug#10550).
5467 2012-01-26 Chong Yidong <cyd@gnu.org>
5469 * keyboard.c (Vecho_keystrokes): Document zero value (Bug#10503).
5471 * search.c (Fsearch_forward, Fsearch_backward): Document negative
5472 repeat counts (Bug#10507).
5474 2012-01-26 Glenn Morris <rgm@gnu.org>
5476 * lread.c (syms_of_lread): Doc fix.
5478 2012-01-25 HIROSHI OOTA <nil@mad.dog.cx> (tiny change)
5480 * coding.c (encode_designation_at_bol): Change return value to
5483 2012-01-25 Chong Yidong <cyd@gnu.org>
5485 * eval.c (Fuser_variable_p): Doc fix; mention custom-variable-p.
5487 2012-01-21 Chong Yidong <cyd@gnu.org>
5489 * floatfns.c (Fcopysign): Make the second argument non-optional,
5490 since nil is not allowed anyway.
5492 2012-01-21 Andreas Schwab <schwab@linux-m68k.org>
5494 * process.c (read_process_output): Use p instead of XPROCESS (proc).
5495 (send_process): Likewise.
5497 2012-01-19 Martin Rudalics <rudalics@gmx.at>
5499 * window.c (save_window_save, Fcurrent_window_configuration)
5500 (Vwindow_persistent_parameters): Do not use Qstate.
5501 Rewrite doc-strings.
5503 2012-01-19 Kenichi Handa <handa@m17n.org>
5505 * character.c (char_width): New function.
5506 (Fchar_width, c_string_width, lisp_string_width):
5507 Use char_width (Bug#9496).
5509 2012-01-16 Martin Rudalics <rudalics@gmx.at>
5511 * window.c (Vwindow_persistent_parameters): New variable.
5512 (Fset_window_configuration, save_window_save): Handle persistent
5515 2012-01-14 Eli Zaretskii <eliz@gnu.org>
5517 * w32fns.c (signal_user_input): Don't do a QUIT, to avoid
5518 thrashing the stack of the thread. (Bug#9087)
5520 2012-01-12 Paul Eggert <eggert@cs.ucla.edu>
5522 * xdisp.c (rows_from_pos_range): Add parens as per gcc -Wparentheses.
5524 2012-01-11 Eli Zaretskii <eliz@gnu.org>
5526 * xdisp.c (rows_from_pos_range): Handle the case where the
5527 highlight ends on a newline. (Bug#10464)
5528 (mouse_face_from_buffer_pos): Fix off-by-one error in calculating
5529 he end column for display of highlight that ends on a newline
5532 2012-01-11 Glenn Morris <rgm@gnu.org>
5534 * lread.c (init_lread): If no-site-lisp, remove site-lisp dirs
5535 from load-path also when installation-directory is nil. (Bug#10208)
5537 2012-01-10 Glenn Morris <rgm@gnu.org>
5539 * emacs.c (syms_of_emacs) <installation-directory>: Doc fix.
5541 * epaths.in (PATH_LOADSEARCH, PATH_EXEC, PATH_DATA, PATH_DOC):
5542 Update template values to be closer to their typical values these days.
5544 2012-01-09 Eli Zaretskii <eliz@gnu.org>
5546 * xdisp.c (rows_from_pos_range): Accept additional argument
5547 DISP_STRING, and accept any glyph in a row whose object is that
5548 string as eligible for mouse highlight. Fixes mouse highlight of
5549 display strings from overlays. (Bug#10464)
5551 2012-01-07 Paul Eggert <eggert@cs.ucla.edu>
5553 emacs: fix an auto-save permissions race condition (Bug#10400)
5554 * fileio.c (auto_saving_dir_umask): New static var.
5555 (Fmake_directory_internal): Use it.
5556 (do_auto_save_make_dir): Set it, instead of invoking chmod after
5557 creating the directory. The old code temporarily assigns
5558 too-generous permissions to the directory.
5559 (do_auto_save_eh): Clear it.
5560 (Fdo_auto_save): Catch all errors, not just file errors, so
5561 that the var is always cleared.
5563 2012-01-07 Eli Zaretskii <eliz@gnu.org>
5565 * search.c (scan_buffer): Pass character positions to
5566 know_region_cache, not byte positions. (Bug#6540)
5568 2012-01-07 LynX <_LynX@bk.ru> (tiny change)
5570 * w32.c (sys_rename): Report EXDEV when rename of a directory
5571 fails because the target is on another logical disk. (Bug#10284)
5573 2012-01-07 David Benjamin <davidben@mit.edu> (tiny change)
5575 * xterm.c (x_embed_request_focus): New function.
5577 * xterm.h: Add prototype.
5579 * xfns.c (Fx_focus_frame): Use it for embedded frames (Bug#9977).
5581 2012-01-05 Glenn Morris <rgm@gnu.org>
5583 * emacs.c (emacs_copyright): Update short copyright year to 2012.
5585 2012-01-01 Eli Zaretskii <eliz@gnu.org>
5587 * gnutls.c (init_gnutls_functions): Load gnutls_check_version.
5588 Load gnutls_transport_set_lowat only if GnuTLS version is below
5590 (emacs_gnutls_handshake): Call gnutls_transport_set_lowat only for
5591 GnuTLS versions below 2.11.1.
5593 2011-12-31 Antoine Levitt <antoine.levitt@gmail.com>
5595 * xdisp.c (syms_of_xdisp) <window-scroll-functions>: Add warning
5596 to the doc string advising against its use for altering the way
5597 windows are scrolled.
5599 2011-12-28 Kenichi Handa <handa@m17n.org>
5601 * coding.c (Fdefine_coding_system_internal): Make an utf-8 base
5602 coding-system ASCII compatible only when it does not produce BOM
5603 on encoding (Bug#10383).
5605 2011-12-26 Jan Djärv <jan.h.d@swipnet.se>
5607 * xmenu.c (x_menu_wait_for_event): Use xg_select for Gtk3 so menus
5609 (create_and_show_popup_menu): Always use menu_position_func for
5612 2011-12-24 Andreas Schwab <schwab@linux-m68k.org>
5614 * callint.c (Fcall_interactively): Don't truncate prompt string.
5616 2011-12-23 Eli Zaretskii <eliz@gnu.org>
5618 * xdisp.c (handle_invisible_prop): Handle correctly an invisible
5619 property that ends at ZV, so that the bidi iteration could be
5620 resumed from there (after widening). (Bug#10360)
5622 2011-12-22 Jan Djärv <jan.h.d@swipnet.se>
5624 * nsfont.m (ns_spec_to_descriptor): Do not autorelease fdesc.
5626 2011-12-21 Jan Djärv <jan.h.d@swipnet.se>
5628 * nsterm.m (x_free_frame_resources):
5629 Release f->output_data.ns->miniimage.
5630 (ns_index_color): Fix indentation. Do not retain
5631 color_table->colors[i].
5633 * nsmenu.m (ns_update_menubar): Call free_menubar_widget_value_tree
5636 * nsfns.m (x_set_background_color): Assign return value from
5637 ns_index_color to face-background instead of NSColor*.
5638 (ns_implicitly_set_icon_type): Fix indentation.
5639 Change assignment in for loop to comparison.
5641 * emacs.c (ns_pool): New variable.
5642 (main): Assign ns_pool.
5643 (Fkill_emacs): Call ns_release_autorelease_pool.
5645 * nsfont.m (ns_spec_to_descriptor): Fix indentation,
5646 autorelease fdesc, release fdAttrs and tdict.
5647 (ns_get_covering_families): Release charset.
5648 (ns_findfonts): Release NSFontDescriptor created with new.
5649 (ns_uni_to_glyphs): Fix indentation.
5650 (setString): Release attrStr before assigning new value.
5652 2011-12-18 Jan Djärv <jan.h.d@swipnet.se>
5654 * nsmenu.m (NSMenuDidBeginTrackingNotification): Declare if OSX < 10.5
5656 (trackingNotification): Surround with ifdef NS_IMPL_COCOA.
5657 (syms_of_nsmenu): Set trackingMenu to 1 if not NS_IMPL_COCOA.
5659 2011-12-18 David Reitter <reitter@cmu.edu>
5661 * nsterm.m (ns_term_init): Subscribe for notifications
5662 NSMenuDidBeginTrackingNotification and NSMenuDidEndTrackingNotification
5663 to method trackingNotification in EmacsMenu.
5665 * nsmenu.m (trackingMenu): New variable.
5666 (trackingNotification): New method (from Aquamacs).
5667 (menuNeedsUpdate): Expand comment and return if trackingMenu is 0,
5668 from Aquamacs (Bug#7030).
5670 2011-12-18 Jan Djärv <jan.h.d@swipnet.se>
5672 * nsselect.m (CUT_BUFFER_SUPPORT): Remove define.
5673 (symbol_to_nsstring): Fix indentation.
5674 (ns_symbol_to_pb): New function.
5675 (Fns_get_selection_internal): Rename from Fns_get_cut_buffer_internal.
5676 (Fns_rotate_cut_buffers_internal): Remove.
5677 (Fns_store_selection_internal): Rename from
5678 Fns_store_cut_buffer_internal.
5679 (ns_get_foreign_selection, Fx_own_selection_internal)
5680 (Fx_disown_selection_internal, Fx_selection_exists_p)
5681 (Fns_get_selection_internal, Fns_store_selection_internal):
5682 Use ns_symbol_to_pb and check if return value is nil.
5683 (syms_of_nsselect): Remove ifdef CUT_BUFFER_SUPPORT. Remove defsubr
5684 Sns_rotate_cut_buffers_internal. Sns_get_cut_buffer_internal
5685 renamed to Sns_get_selection_internal, Sns_store_cut_buffer_internal
5686 renamed to Sns_store_selection_internal.
5687 (ns_handle_selection_request): Move code to Fx_own_selection_internal
5688 and remove this function.
5689 (ns_handle_selection_clear): Remove, never used.
5690 (Fx_own_selection_internal): Move code from ns_handle_selection_request
5693 2011-12-17 Ken Brown <kbrown@cornell.edu>
5695 * fileio.c (check_writable) [CYGWIN]: Return non-zero if UID or
5696 GID is unknown (Bug#10257).
5698 2011-12-17 Paul Eggert <eggert@cs.ucla.edu>
5700 * s/gnu-linux.h: Fix mark_memory typo (Bug#10286).
5701 (GC_MARK_SECONDARY_STACK): Omit removed 3rd arg to mark_memory,
5702 which caused a build failure on GNU/Linux IA-64. This problem was
5703 introduced by my 2011-10-07 patch.
5705 2011-12-15 Juri Linkov <juri@jurta.org>
5707 * image.c (imagemagick_error): New function. (Bug#10112)
5708 (imagemagick_load_image): Comment out `MagickSetResolution' call.
5709 Use `imagemagick_error' where ImageMagick functions return
5711 (Fimagemagick_types): Add `Fnreverse' to return the list in the
5714 2011-12-15 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
5716 * xftfont.c (xftfont_draw): Use the font metrics of s->font to
5717 fill background (Bug#8992).
5719 2011-12-13 Martin Rudalics <rudalics@gmx.at>
5721 * window.c (Vwindow_combination_resize)
5722 (Vwindow_combination_limit): Use t instead of non-nil in
5724 (Vrecenter_redisplay): Add first sentence of doc-string on
5726 (Frecenter): Fix doc-string typo.
5728 2011-12-11 Kenichi Handa <handa@m17n.org>
5730 * coding.c (Funencodable_char_position): Pay attention to the
5731 buffer text relocation (Bug#9389).
5733 2011-12-10 Jan Djärv <jan.h.d@swipnet.se>
5735 * xterm.c (x_term_init): Move call to gdk_window_add_filter before
5736 gtk_init (Bug#10100).
5738 2011-12-10 Eli Zaretskii <eliz@gnu.org>
5740 * xdisp.c (RECORD_MAX_MIN_POS): Use IT->cmp_it.charpos only if
5741 IT->string is nil. (Bug#10263)
5743 2011-12-10 Jan Djärv <jan.h.d@swipnet.se>
5745 * nsterm.h (x_free_frame_resources): Declare.
5747 * nsfns.m (ns_get_defaults_value): New function (Bug#10103).
5748 (Fns_get_resource, x_get_string_resource): Call ns_get_defaults_value.
5750 * nsterm.h (ns_get_defaults_value): Declare.
5752 * nsterm.m (ns_default): Call ns_get_defaults_value.
5754 2011-12-09 Eli Zaretskii <eliz@gnu.org>
5756 * xdisp.c (try_scrolling): Don't set scroll_down_p if dy is zero.
5759 2011-12-09 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
5761 * unexelf.c (unexec) [NS_IMPL_GNUSTEP]: Take account of the case
5762 that where the value of an _OBJC_* symbol points to is in the .bss
5763 section (Bug#10240).
5765 2011-12-08 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny change)
5767 * coding.c (encode_coding_ccl): Check (charbuf < charbuf_end)
5768 after the loop to call ccl_driver at least once (Bug#8619).
5770 2011-12-08 Kenichi Handa <handa@m17n.org>
5772 * ftfont.c (get_adstyle_property): Fix previous change
5775 2011-12-07 Juanma Barranquero <lekktu@gmail.com>
5777 * w32.c (init_environment): If no_site_lisp, remove site-lisp
5778 dirs from the default value of EMACSLOADPATH (bug#10208).
5780 2011-12-07 Glenn Morris <rgm@gnu.org>
5782 * lread.c (init_lread): If no_site_lisp, exclude site-lisp/ in
5783 installation and source directories as well. (Bug#10208)
5785 2011-12-06 Chong Yidong <cyd@gnu.org>
5787 * minibuf.c (Fread_from_minibuffer): Doc fix (Bug#10228).
5789 2011-12-06 Glenn Morris <rgm@gnu.org>
5791 * process.c (start_process_unwind): Treat any pid <= 0, except -2,
5792 as an error, not just -1. (Bug#10217)
5794 2011-12-05 Chong Yidong <cyd@gnu.org>
5796 * keyboard.c (process_special_events): New function.
5797 (swallow_events, Finput_pending_p): Use it (Bug#10195).
5799 2011-12-05 Paul Eggert <eggert@cs.ucla.edu>
5801 * coding.c (encode_designation_at_bol): Don't use uninitialized
5802 local variable (Bug#9318).
5804 2011-12-05 Kenichi Handa <handa@m17n.org>
5806 * ftfont.c (get_adstyle_property): If the font is not BDF nor PCF,
5807 return Qnil (Bug#8046, Bug#10193).
5809 2011-12-05 Kenichi Handa <handa@m17n.org>
5811 * coding.c (encode_designation_at_bol): New args charbuf_end and
5812 dst. Return the number of produced bytes. Callers changed.
5813 (coding_set_source): Return how many bytes coding->source was
5815 (coding_set_destination): Return how many bytes
5816 coding->destination was relocated.
5817 (CODING_DECODE_CHAR, CODING_ENCODE_CHAR, CODING_CHAR_CHARSET)
5818 (CODING_CHAR_CHARSET_P): Adjust for the avove changes.
5820 2011-12-05 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny change)
5822 * coding.c (CODING_CHAR_CHARSET_P): New macro.
5823 (encode_coding_emacs_mule, encode_coding_iso_2022): Use the above
5826 2011-12-05 Andreas Schwab <schwab@linux-m68k.org>
5828 The following changes are to fix Bug#9318.
5830 * coding.c (CODING_ENCODE_CHAR, CODING_CHAR_CHARSET): New macros.
5831 (encode_coding_emacs_mule, ENCODE_ISO_CHARACTER)
5832 (encode_coding_iso_2022, encode_coding_sjis)
5833 (encode_coding_big5, encode_coding_charset): Use the above macros.
5835 2011-12-05 Juanma Barranquero <lekktu@gmail.com>
5837 * lisp.h (process_quit_flag): Fix external declaration.
5839 2011-12-04 Stefan Monnier <monnier@iro.umontreal.ca>
5841 Don't macro-inline non-performance-critical code.
5842 * eval.c (process_quit_flag): New function.
5843 * lisp.h (QUIT): Use it.
5845 2011-12-04 Jan Djärv <jan.h.d@swipnet.se>
5847 * nsfns.m (get_geometry_from_preferences): New function.
5848 (Fx_create_frame): Call get_geometry_from_preferences (Bug#10103).
5850 2011-12-04 Andreas Schwab <schwab@linux-m68k.org>
5852 * emacs.c (Qkill_emacs): Define.
5853 (syms_of_emacs): Initialize it.
5854 * keyboard.c (interrupt_signal): Don't call Fkill_emacs here, set
5855 Qquit_flag to `kill-emacs' instead.
5856 (quit_throw_to_read_char): Add parameter `from_signal'.
5857 All callers changed. Call Fkill_emacs if requested and safe.
5858 * lisp.h (QUIT): Call Fkill_emacs if requested.
5860 2011-12-03 Jan Djärv <jan.h.d@swipnet.se>
5862 * widget.c (update_wm_hints): Return if wmshell is null.
5863 (widget_update_wm_size_hints): New function.
5865 * widget.h (widget_update_wm_size_hints): Declare.
5867 * xterm.c (x_wm_set_size_hint): If USE_X_TOOLKIT, call
5868 widget_update_wm_size_hints (Bug#10104).
5870 2011-12-03 Eli Zaretskii <eliz@gnu.org>
5872 * xdisp.c (handle_invisible_prop): If the invisible text ends just
5873 before a newline, prepare the bidi iterator for consuming the
5874 newline, and keep the current paragraph direction. (Bug#10183)
5875 (redisplay_window): Don't let `margin' become negative. (Bug#10192)
5877 2011-12-02 Juri Linkov <juri@jurta.org>
5879 * search.c (Fword_search_regexp): New Lisp function created from
5880 `wordify'. Change type of arg `lax' from `int' to `Lisp_Object'.
5881 (Fword_search_backward, Fword_search_forward)
5882 (Fword_search_backward_lax, Fword_search_forward_lax):
5883 Use `Fword_search_regexp' instead of `wordify'. Doc fix.
5884 (syms_of_search): Define `Sword_search_regexp'. (Bug#10145)
5886 2011-12-01 Stefan Monnier <monnier@iro.umontreal.ca>
5888 * fileio.c (Finsert_file_contents): Move after-change-function call
5889 to before the "handled:" label, since all "goto handled" appear in
5890 cases where the *-change-functions have already been properly called
5893 2011-12-01 Andreas Schwab <schwab@linux-m68k.org>
5895 * keyboard.c (interrupt_signal): Don't call kill-emacs when
5896 waiting for input. (Bug#10169)
5898 2011-11-30 Eli Zaretskii <eliz@gnu.org>
5900 * dispnew.c (adjust_glyph_matrix): Remove the assertion that
5901 verifies glyph row's hash code--we have just reallocated the
5902 glyphs, so their contents can be complete garbage. (Bug#10164)
5904 2011-11-30 Juanma Barranquero <lekktu@gmail.com>
5906 * dispnew.c (adjust_glyph_matrix) [XASSERTS]: Add missing check.
5908 2011-11-30 Eli Zaretskii <eliz@gnu.org>
5910 * dispnew.c (adjust_glyph_matrix) [XASSERTS]: Ensure ROW's
5911 attributes are tested _before_ calling verify_row_hash, to protect
5912 against GCC re-ordering of the tests. (Bug#10164)
5914 2011-11-29 Jan Djärv <jan.h.d@swipnet.se>
5916 * xterm.h (struct x_output): net_wm_state_hidden_seen is new.
5918 * xterm.c (handle_one_xevent): Only set async_visible and friends
5919 if net_wm_state_hidden_seen is non-zero (Bug#10002)
5920 (get_current_wm_state): Set net_wm_state_hidden_seen to 1 if
5921 _NET_WM_STATE_HIDDEN is in NET_WM_STATE.
5923 2011-11-28 Paul Eggert <eggert@cs.ucla.edu>
5925 Remove GCPRO-related macros that exist only to avoid shadowing locals.
5926 * lisp.h (GCPRO1_VAR, GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR, GCPRO5_VAR)
5927 (GCPRO6_VAR, UNGCPRO_VAR): Remove. See
5928 <http://lists.gnu.org/archive/html/emacs-diffs/2011-11/msg00265.html>.
5929 All uses changed to use GCPRO1 etc.
5930 (GCPRO1, GCPRO2, GCPRO3, GCPRO4, GCPRO5, GCPRO6, UNGCPRO):
5931 Revert to old implementation (i.e., before 2011-03-11).
5933 2011-11-28 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
5935 * dispnew.c (scrolling_window): Truncate overlaps in copy destination
5936 of scroll runs so as to avoid assigning disabled bogus rows and
5937 unnecessary graphics copy operations.
5939 2011-11-27 Eli Zaretskii <eliz@gnu.org>
5941 * s/ms-w32.h (utimbuf) [_MSC_VER]: Don't define.
5942 (snprintf) [_MSC_VER]: Redirect to _snprintf.
5943 (strtoll) [_MSC_VER]: Redirect to _strtoi64.
5944 (malloc, free, realloc, calloc): Redirect to e_* only when
5947 * lisp.h (GCTYPEBITS): Move before first use.
5948 (ALIGN_GCTYPEBITS) [_MSC_VER]: Define.
5949 (DECL_ALIGN) [_MSC_VER]: Use it, as MSVC doesn't like bit ops in
5950 this macro definition.
5952 * s/ms-w32.h (tzname): Redirect to _tzname for all values of
5955 2011-11-27 Jan Djärv <jan.h.d@swipnet.se>
5957 * gtkutil.c (xg_create_frame_widgets):
5958 Call gtk_window_set_has_resize_grip (FALSE) if that function is
5959 present with Gtk+ 2.0.
5961 2011-11-26 Paul Eggert <eggert@cs.ucla.edu>
5963 * fileio.c (Finsert_file_contents): Undo previous change; see
5964 <http://lists.gnu.org/archive/html/emacs-diffs/2011-11/msg00265.html>.
5966 2011-11-26 Paul Eggert <eggert@cs.ucla.edu>
5968 Rename locals to avoid shadowing.
5969 * fileio.c (Finsert_file_contents):
5970 Rename inner 'gcpro1' to 'inner_gcpro1' to avoid shadowing.
5971 * process.c (wait_reading_process_output):
5972 Rename inner 'proc' to 'p' to avoid shadowing.
5973 Indent for consistency with usual Emacs style.
5975 2011-11-25 Eli Zaretskii <eliz@gnu.org>
5977 * xdisp.c (redisplay_window): If cursor row is not fully visible
5978 after recentering, and scroll-conservatively is set to a large
5979 number, scroll window by a few more lines to make the cursor fully
5980 visible and out of scroll-margin. (Bug#10105)
5981 (start_display): Don't move to the next line if the display should
5982 start at a newline that is part of a display vector or an overlay
5985 2011-11-24 Juri Linkov <juri@jurta.org>
5987 * image.c (imagemagick_load_image): Move `MagickSetResolution' down
5988 after the `MagickPingImage' call. (Bug#10112)
5990 2011-11-23 Chong Yidong <cyd@gnu.org>
5992 * window.c (Fcoordinates_in_window_p): Accept only live windows.
5994 2011-11-23 Martin Rudalics <rudalics@gmx.at>
5996 * buffer.c (Fkill_buffer): Run replace_buffer_in_windows before
5997 making another buffer current. (Bug#10114)
5999 2011-11-23 Glenn Morris <rgm@gnu.org>
6001 * font.c (font_find_for_lface) [HAVE_NS]: Ignore case. (Bug#2526)
6003 2011-11-23 Chong Yidong <cyd@gnu.org>
6005 * xdisp.c (compute_stop_pos): Check validity of end_charpos before
6006 using it (Bug#5984).
6008 2011-11-22 Eli Zaretskii <eliz@gnu.org>
6010 * dispnew.c (adjust_glyph_matrix): Don't verify hash code of mode-
6011 and header-lines, as they don't have one computed for them.
6014 * .gdbinit (prow): Make displayed values more self-explaining.
6015 Add row's hash code.
6017 2011-11-21 Lars Magne Ingebrigtsen <larsi@gnus.org>
6019 * process.c (wait_reading_process_output): Fix asynchrounous
6020 GnuTLS socket handling on some versions of the GnuTLS library.
6021 (wait_reading_process_output): Add comment and URL.
6023 2011-11-21 Jan Djärv <jan.h.d@swipnet.se>
6025 * xterm.c (x_clear_frame): Reinstate the XClearWindow call.
6027 2011-11-21 Chong Yidong <cyd@gnu.org>
6029 * window.c (Fnext_window, Fprevious_window): Doc fix.
6031 2011-11-20 Stefan Monnier <monnier@iro.umontreal.ca>
6033 * window.c (get_phys_cursor_glyph): Fix Lisp_Object/int mixup.
6035 2011-11-20 Juanma Barranquero <lekktu@gmail.com>
6037 * nsfont.m (syms_of_nsfont) <ns-reg-to-script>: Fix typo.
6039 2011-11-20 Martin Rudalics <rudalics@gmx.at>
6041 * window.c (Fset_window_combination_limit): Rename argument
6043 (Vwindow_combination_limit): Remove "status" from doc-string.
6045 2011-11-20 Andreas Schwab <schwab@linux-m68k.org>
6047 * m/ibms390.h: Remove.
6048 * m/ibms390x.h: Don't include "ibms390.h".
6050 2011-11-20 Stefan Monnier <monnier@iro.umontreal.ca>
6052 * fileio.c (Finsert_file_contents): Add missing gcpro1 variable.
6053 Suggested by Dmitry Antipov <dmantipov@yandex.ru>.
6055 2011-11-20 Juanma Barranquero <lekktu@gmail.com>
6057 * casetab.c (Fset_case_table):
6058 * charset.c (Fcharset_after): Fix typos.
6060 2011-11-20 Paul Eggert <eggert@cs.ucla.edu>
6062 Standardize on VIRT_ADDR_VARIES behavior (Bug#10042).
6063 Otherwise, valgrind does not work on some platforms.
6064 Problem reported by Andreas Schwab in
6065 <http://lists.gnu.org/archive/html/emacs-devel/2011-11/msg00081.html>.
6066 * puresize.h (pure, PURE_P): Always behave as if VIRT_ADDR_VARIES
6067 is set, removing the need for VIRT_ADDRESS_VARIES.
6068 (PURE_P): Use a more-efficient implementation that needs just one
6069 comparison, not two: on x86-64 with GCC 4.6.2, this cut down the
6070 number of instructions from 6 (xorl, cmpq, jge, xorl, cmpq, setge)
6071 to 4 (xorl, subq, cmpq, setbe).
6072 * alloc.c (pure): Always extern now, since that's the
6073 VIRT_ADDR_VARIES behavior.
6074 (PURE_POINTER_P): Use a single comparison, not two, for
6075 consistency with the new puresize.h.
6076 * lisp.h (PNTR_COMPARISON_TYPE): Remove; no longer needed.
6077 * m/ibms390.h, m/intel386.h, m/template.h, s/cygwin.h, s/hpux10-20.h:
6078 Remove VIRT_ADDR_VARIES no longer needed.
6080 2011-11-19 Eli Zaretskii <eliz@gnu.org>
6082 * xdisp.c (x_write_glyphs, draw_phys_cursor_glyph)
6083 (erase_phys_cursor, update_window_cursor, show_mouse_face)
6084 (cursor_in_mouse_face_p): If the cursor position is out of bounds,
6085 behave as if the cursor position were at the window margin.
6087 * window.c (get_phys_cursor_glyph): If the window is hscrolled,
6088 and the cursor position is out of bounds, behave as if the cursor
6089 position were at the window margin. (Bug#10075)
6091 2011-11-18 Chong Yidong <cyd@gnu.org>
6093 * window.c (Fwindow_combination_limit): Make first argument
6094 non-optional, since it is meaningless for live windows like the
6097 2011-11-18 Dmitry Antipov <dmantipov@yandex.ru>
6099 * keymap.c (Fwhere_is_internal): Add missing RETURN_UNGCPROs.
6101 2011-11-18 Stefan Monnier <monnier@iro.umontreal.ca>
6103 * intervals.c: Fix grafting over the whole buffer (bug#10071).
6104 (graft_intervals_into_buffer): Simplify.
6106 2011-11-18 Eli Zaretskii <eliz@gnu.org>
6108 * dispnew.c (swap_glyph_pointers): Swap the used[] arrays and the
6109 hash values of the two rows.
6110 (copy_row_except_pointers): Preserve the used[] arrays and the
6111 hash values of the two rows. (Bug#10035)
6112 (add_row_entry): Add xassert to verify that ROW's hash code is valid.
6114 * xdisp.c (row_hash): New function, body extracted from
6115 compute_line_metrics.
6116 (compute_line_metrics): Call row_hash, instead of computing the
6119 * dispnew.c (verify_row_hash): Call row_hash for computing the
6120 hash code of a row, instead of duplicating code from xdisp.c.
6122 * dispextern.h (row_hash): Add prototype.
6124 2011-11-18 Tassilo Horn <tassilo@member.fsf.org>
6126 * frame.c (delete_frame): Don't delete the terminal when the last
6127 X frame is closed if emacs is built with GTK toolkit.
6129 2011-11-17 Juanma Barranquero <lekktu@gmail.com>
6131 * window.c (syms_of_window) <window-combination-resize>: Fix typo.
6133 2011-11-17 Martin Rudalics <rudalics@gmx.at>
6135 * window.c (Vwindow_splits): Rename to
6136 Vwindow_combination_resize. Suggested by Juri Linkov.
6137 (Fsplit_window_internal): Use Vwindow_combination_resize instead
6140 2011-11-16 Juanma Barranquero <lekktu@gmail.com>
6142 * nsfns.m (Fns_font_name):
6143 * window.c (syms_of_window) <window-combination-limit>: Fix typos.
6145 2011-11-16 Martin Rudalics <rudalics@gmx.at>
6147 * window.h (window): Rename slot "nest" to "combination_limit".
6148 * window.c (Fwindow_nest): Rename to Fwindow_combination_limit.
6149 (Fset_window_nest): Rename to Fset_window_combination_limit.
6150 (Vwindow_nest): Rename to Vwindow_combination_limit.
6151 (recombine_windows, make_parent_window, make_window)
6152 (Fsplit_window_internal, saved_window)
6153 (Fset_window_configuration, save_window_save): Rename all
6154 occurrences of window_nest to window_combination_limit.
6156 2011-11-15 Juanma Barranquero <lekktu@gmail.com>
6158 * image.c (imagemagick_load_image): Fix typo.
6160 2011-11-14 Eli Zaretskii <eliz@gnu.org>
6162 * xdisp.c (display_line): Move the call to
6163 highlight_trailing_whitespace before the call to
6164 compute_line_metrics, since the latter needs to see the final
6165 faces of all the glyphs to compute ROW's hash value.
6166 Fixes assertion violations in row_equal_p. (Bug#10035)
6168 2011-11-14 Juanma Barranquero <lekktu@gmail.com>
6170 * w32proc.c (reader_thread): Don't check pending input if cp->fd < 0,
6171 just return (bug#10044).
6173 2011-11-12 Eli Zaretskii <eliz@gnu.org>
6175 * makefile.w32-in (HEAPSIZE): New variable, allows to build temacs
6176 with user-defined heap size. Bump the default size of the temacs
6177 heap to 27MB, to avoid memory warning when running temacs.
6178 ($(TEMACS)): Use HEAPSIZE instead of a hardcoded value.
6180 * dispnew.c (scrolling_window): Fix incorrect indices in accessing
6181 current_matrix and desired_matrix. (Bug#9990)
6182 (verify_row_hash) [XASSERTS]: New function.
6183 (adjust_glyph_matrix, row_equal_p): Use it in xassert to verify
6184 that the hash value of glyph rows is correct.
6186 2011-11-12 Martin Rudalics <rudalics@gmx.at>
6188 * window.h (window): Remove splits slot.
6189 * window.c (Fwindow_splits, Fset_window_splits): Remove.
6190 (Fdelete_other_windows_internal, make_parent_window)
6191 (make_window, Fsplit_window_internal, Fdelete_window_internal)
6192 (Fset_window_configuration, save_window_save): Don't deal with
6193 split status of windows.
6194 (saved_window): Remove splits slot.
6195 (Vwindow_splits): Rewrite doc-string.
6197 2011-11-11 Jan Djärv <jan.h.d@swipnet.se>
6199 * xfns.c (unwind_create_frame):
6200 * nsfns.m (unwind_create_frame):
6201 * w32fns.c (unwind_create_frame): Use Fmemq to check if frame is in
6202 Vframe_list (Bug#9999).
6204 2011-11-11 Dmitry Antipov <dmantipov@yandex.ru>
6206 * xdisp.c (syms_of_xdisp): Remove duplicated definition of Qtext.
6208 2011-11-11 Kenichi Handa <handa@m17n.org>
6210 * callproc.c (Fcall_process): Set the member dst_multibyte of
6213 2011-11-11 Johan Bockgård <bojohan@gnu.org>
6215 * xdisp.c (fill_composite_glyph_string): Always set s->face, to
6216 avoid a crash (bug#9496).
6218 2011-11-09 Chong Yidong <cyd@gnu.org>
6220 * window.c (Fwindow_inside_edges, Fwindow_inside_pixel_edges)
6221 (Fwindow_inside_absolute_pixel_edges): Only allow live windows.
6223 2011-11-08 Paul Eggert <eggert@cs.ucla.edu>
6225 * s/gnu.h (GC_MARK_STACK): Define to GC_MAKE_GCPROS_NOOPS (Bug#9926).
6227 2011-11-08 Paul Eggert <eggert@cs.ucla.edu>
6229 Avoid some portability problems by eschewing 'extern inline' functions.
6230 The trivial performance wins aren't worth the portability hassles; see
6231 <http://lists.gnu.org/archive/html/emacs-devel/2011-11/msg00084.html>
6233 * dispextern.h (window_box, window_box_height, window_text_bottom_y)
6234 (window_box_width, window_box_left, window_box_left_offset)
6235 (window_box_right, window_box_right_offset): Undo previous change,
6236 by removing the "extern"s.
6237 * intervals.c (adjust_intervals_for_insertion)
6238 (adjust_intervals_for_deletion): Undo previous change,
6239 making these static again.
6240 (offset_intervals, temp_set_point_both, temp_set_point)
6241 (copy_intervals_to_string): No longer inline.
6242 * xdisp.c (window_text_bottom_y, window_box_width)
6243 (window_box_height, window_box_left_offset)
6244 (window_box_right_offset, window_box_left, window_box_right)
6245 (window_box): No longer inline.
6247 2011-11-08 Chong Yidong <cyd@gnu.org>
6249 * window.c (Fwindow_left_column, Fwindow_top_line): Doc fix.
6250 (Fwindow_body_height, Fwindow_body_width): Move from Lisp.
6251 Signal an error if not a live window.
6252 (Fwindow_total_width, Fwindow_total_height): Move from Lisp.
6253 (Fwindow_total_size, Fwindow_body_size): Move to Lisp.
6255 2011-11-07 Juanma Barranquero <lekktu@gmail.com>
6257 * lisp.h (syms_of_abbrev): Remove declaration.
6258 Reported by CHENG Gao <chenggao@royau.me>.
6260 2011-11-07 Eli Zaretskii <eliz@gnu.org>
6262 * w32.c (check_windows_init_file): Don't look for term/w32-win.el
6263 if Vpurify_flag is non-nil. Fixes a crash when running w32 build
6264 of temacs in GUI mode.
6266 2011-11-07 Martin Rudalics <rudalics@gmx.at>
6268 * window.h: Declare delete_all_child_windows instead of
6269 delete_all_subwindows.
6270 * window.c (Fwindow_nest, Fset_window_nest)
6271 (Fset_window_new_total, Fset_window_new_normal)
6272 (Fwindow_resize_apply): Don't use term subwindow in doc-strings.
6273 (delete_all_subwindows): Rename to delete_all_child_windows.
6274 (Fdelete_other_windows_internal, Fset_window_configuration):
6275 Call delete_all_child_windows instead of delete_all_subwindows.
6276 * frame.c (delete_frame): Call delete_all_child_windows instead
6277 of delete_all_subwindows.
6279 2011-11-07 Paul Eggert <eggert@cs.ucla.edu>
6281 * alloc.c (DEADP): New macro, for porting to GNU/Hurd (Bug#9926).
6282 This is also needed for porting to any host where GC_MARK_STACK is
6283 not GC_MAKE_GCPROS_NOOPS.
6284 (which_symbols): Use it.
6286 2011-11-07 Kenichi Handa <handa@m17n.org>
6288 * coding.c (coding_set_destination): Check coding->src_pos only
6289 when coding->src_object is a buffer (bug#9910).
6291 * process.c (send_process): Set the member src_multibyte of coding
6292 to 0 (bug#9911) when sending a unibyte text.
6294 * callproc.c (Fcall_process): Set the member src_multibyte of
6295 process_coding to 0 (bug#9912).
6297 2011-11-06 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
6299 * xmenu.c (cleanup_widget_value_tree): New function.
6300 (xmenu_show, xdialog_show): Use it in record_unwind_protect instead of
6301 calling free_menubar_widget_value_tree directly (Bug#9830).
6303 2011-11-06 Paul Eggert <eggert@cs.ucla.edu>
6305 Fix some portability problems with 'inline'.
6306 * dispextern.h (window_box, window_box_height, window_text_bottom_y)
6307 (window_box_width, window_box_left, window_box_left_offset)
6308 (window_box_right, window_box_right_offset): Declare extern.
6309 Otherwise, these inline functions do not conform to C99 and
6310 are miscompiled by Microsoft compilers. Reported by Eli Zaretskii in
6311 <http://lists.gnu.org/archive/html/emacs-devel/2011-11/msg00084.html>.
6312 * intervals.c (adjust_intervals_for_insertion)
6313 (adjust_intervals_for_deletion): Now extern, because otherwise the
6314 extern inline functions 'offset_intervals' couldn't refer to it.
6315 (static_offset_intervals): Remove.
6316 (offset_intervals): Rewrite using the old contents of
6317 static_offset_intervals. The old version didn't conform to C99
6318 because an extern inline function contained a reference to an
6319 identifier with static linkage.
6321 2011-11-06 Andreas Schwab <schwab@linux-m68k.org>
6323 * keyboard.c (interrupt_signal): Don't call kill-emacs while in
6326 2011-11-06 Eli Zaretskii <eliz@gnu.org>
6328 * xdisp.c (init_iterator, reseat_to_string): Don't set the
6329 iterator's bidi_p flag if Vpurify_flag is non-nil. (Bug#9963)
6330 (Fcurrent_bidi_paragraph_direction): If Vpurify_flag is non-nil,
6331 return Qleft_to_right.
6333 2011-11-06 Chong Yidong <cyd@gnu.org>
6335 * window.c (Fwindow_live_p, Fwindow_frame, Fframe_root_window)
6336 (Fminibuffer_window, Fwindow_buffer, Fwindow_splits)
6337 (Fset_window_splits, Fwindow_nest, Fset_window_nest)
6338 (Fwindow_use_time, Fwindow_total_size, Fwindow_normal_size)
6339 (Fwindow_new_normal, Fwindow_left_column, Fwindow_top_line)
6340 (Fwindow_margins, Fwindow_fringes, Fwindow_scroll_bars)
6341 (Fwindow_vscroll): Doc fix.
6342 (Fwindow_top_child, Fwindow_left_child): Eliminate a nil default
6343 argument, since it makes no sense to pass a live window and for
6344 consistency with window-child.
6346 2011-11-05 Christoph Scholtes <cschol2112@googlemail.com>
6348 * makefile.w32-in ($(TEMACS), (gl-stamp)): Use $(THISDIR) to
6351 2011-11-05 Jason Rumney <jasonr@gnu.org>
6353 * w32font.c (font_matches_spec): Filter out non-Japanese kana fonts.
6354 (add_font_entity_to_list): Filter out non-Japanese Shift-JIS
6356 (add_font_entity_to_list): Fix logic errors in mixed boolean and
6357 bitwise arithmetic preventing use of unicode-sip and non-truetype
6360 2011-11-05 Eli Zaretskii <eliz@gnu.org>
6362 * s/ms-w32.h (fstat, stat, utime): Move redirections to
6365 * w32fns.c (x_create_tip_frame, Fx_create_frame): Rearrange
6366 initialization code to keep similarity to xfns.c after changes
6369 2011-11-05 Jan Djärv <jan.h.d@swipnet.se>
6371 * nsfns.m: Declare image_cache_refcount if GLYPH_DEBUG.
6372 (unwind_create_frame): New function (Bug#9943).
6373 (Fx_create_frame): Restructure code to be more similar to the one in
6374 xfns.c. Call record_unwind_protect with unwind_create_frame (Bug#9943).
6375 Initialize image_cache_refcount if GLYPH_DEBUG (Bug#9943).
6376 Move terminal->reference_count++ just before making the frame official
6379 * nsterm.m (x_free_frame_resources): New function.
6380 (x_destroy_window): Move code to x_free_frame_resources.
6382 * xfns.c (unwind_create_frame): Fix comment.
6383 (Fx_create_frame, x_create_tip_frame):
6384 Move terminal->reference_count++ just before making the frame
6385 official. Move initialization of image_cache_refcount and
6386 dpyinfo_refcount before calling init_frame_faces (Bug#9943).
6388 2011-11-05 Eli Zaretskii <eliz@gnu.org>
6390 Support MSVC build with newer versions of Visual Studio.
6391 * makefile.w32-in (TAGS-gmake): Don't use $(patsubst ...), as
6392 Nmake barfs on that. Use $(OBJ*_c) variables instead, defined on
6395 * lisp.h (ENUM_BF): New macro, for enumerated types in bitfields,
6396 which are not supported by MSVC.
6397 (Lisp_Symbol, Lisp_Misc_Any, Lisp_Marker, Lisp_Misc_Overlay)
6398 (Lisp_Save_Value, Lisp_Free): Use ENUM_BF for enumerated types in
6400 (Lisp_Object) [USE_LISP_UNION_TYPE]: Use ENUM_BF for enumerated
6402 (DEFUN) [_MSC_VER]: Define in a different way for MSVC.
6404 * w32fns.c [_MSC_VER]: DECLARE_HANDLE for any MSVC version.
6406 2011-11-05 Fabrice Popineau <fabrice.popineau@supelec.fr> (tiny change)
6408 Support MSVC build with newer versions of Visual Studio.
6409 * w32.c: Don't include w32api.h for MSVC.
6410 (init_environment) [_MSC_VER]: Call sys_access, not _access.
6412 * s/ms-w32.h <sigset_t, ssize_t> [_MSC_VER]: Typedefs for MSVC.
6413 [_MSC_VER]: Include sys/timeb.h, sys/stat.h, and signal.h.
6414 (fstat, stat, utime) [_MSC_VER]: Redirect to their sys_* cousins.
6415 (malloc, free, realloc, calloc) [_MSC_VER]: Always redirect to the
6417 (alloca) [_MSC_VER]: Define to _alloca.
6419 * lisp.h (DECL_ALIGN) [_MSC_VER]: Define for MSVC.
6421 * regex.c <re_char> [_MSC_VER]: A separate definition for MSVC.
6423 2011-11-04 Eli Zaretskii <eliz@gnu.org>
6425 * xdisp.c (note_mouse_highlight): If either of
6426 previous/next-single-property-change returns nil, treat that as
6427 the beginning or the end of the buffer. (Bug#9955)
6429 2011-11-04 Jan Djärv <jan.h.d@swipnet.se>
6431 * gtkutil.c (xg_make_tool_item): Add callbacks if one of wimage or
6432 label is not null (Bug#9951).
6433 (xg_tool_item_stale_p): Handle the fact that wimage and/or wlbl
6436 2011-11-04 Eli Zaretskii <eliz@gnu.org>
6438 * window.c (Fwindow_body_size): Mention in the doc string that the
6439 return value is in frame's canonical units. (Bug#9949)
6441 2011-11-03 Eli Zaretskii <eliz@gnu.org>
6443 * xdisp.c (note_mouse_highlight): Initialize `area'. (Bug#9947)
6445 * w32fns.c (unwind_create_frame): If needed, free the glyph
6446 matrices of the partially constructed frame. (Bug#9943)
6447 * xfns.c (unwind_create_frame): Likewise.
6449 2011-11-01 Eli Zaretskii <eliz@gnu.org>
6451 * xdisp.c (mouse_face_from_buffer_pos): Fix a typo in a comment.
6452 Don't stop backward scan on the continuation glyph, even though
6453 its CHARPOS is positive.
6454 (mouse_face_from_buffer_pos, note_mouse_highlight):
6455 Rename cover_string to disp_string.
6457 2011-11-01 Martin Rudalics <rudalics@gmx.at>
6459 * window.c (temp_output_buffer_show): Don't use
6460 Vtemp_buffer_show_specifiers.
6461 (Vtemp_buffer_show_specifiers): Remove unused variable.
6463 2011-10-30 Eli Zaretskii <eliz@gnu.org>
6465 * xdisp.c (try_cursor_movement): Make sure ROW isn't decremented
6466 past the beginning of the current glyph matrix.
6468 2011-10-30 Adam Sjøgren <asjo@koldfront.dk> (tiny change)
6470 * xterm.c: Include X11/Xproto.h if HAVE_GTK3.
6471 (x_error_handler): Ignore BadMatch for X_SetInputFocus for
6472 HAVE_GTK3 (Bug#9869).
6474 * gtkutil.c (xg_win_to_widget, xg_event_is_for_menubar): Initialize
6475 type to GDK_NOTHING so valgrind does not complain (Bug#9901).
6477 * xterm.h (x_display_info): Add Xatom_net_wm_state_hidden (Bug#9893).
6479 * xterm.c: Declare x_handle_net_wm_state to return int.
6480 (handle_one_xevent): Check if we are iconified but don't have
6481 _NET_WM_STATE_HIDDEN. If do, treat as deiconify (Bug#9893).
6482 (get_current_wm_state): Return non-zero if not hidden,
6483 check for _NET_WM_STATE_HIDDEN (Bug#9893).
6484 (do_ewmh_fullscreen): Ignore return value from get_current_wm_state.
6485 (x_handle_net_wm_state): Return what get_current_wm_state returns.
6486 (x_term_init): Initialize dpyinfo->Xatom_net_wm_state_hidden.
6488 2011-10-29 Paul Eggert <eggert@cs.ucla.edu>
6490 * alloc.c (which_symbols): Declare EXTERNALLY_VISIBLE,
6491 so that this new function doesn't get optimized away by a
6492 whole-program optimizer. Make the 2nd arg EMACS_INT, not int.
6494 2011-10-29 Andreas Schwab <schwab@linux-m68k.org>
6496 * frame.h (MOUSE_HL_INFO): Remove excess parens.
6498 2011-10-29 Eli Zaretskii <eliz@gnu.org>
6500 Fix the `xbytecode' command.
6501 * .gdbinit (xprintbytestr): New command.
6502 (xwhichsymbols): Rename from `which'; all callers changed.
6503 (xbytecode): Print the byte-code string as well.
6505 2011-10-29 Kim Storm <storm@cua.dk>
6507 * alloc.c (which_symbols): New function.
6509 2011-10-29 Andreas Schwab <schwab@linux-m68k.org>
6511 * minibuf.c (read_minibuf_noninteractive): Allow reading empty
6514 2011-10-29 Glenn Morris <rgm@gnu.org>
6516 * process.c (wait_reading_process_output): Revert 2009-08-30 change.
6517 Not clear what it was for, and it causes various bugs. (Bug#9839)
6519 2011-10-28 Eli Zaretskii <eliz@gnu.org>
6521 * xdisp.c (note_mouse_highlight): Initialize `part', to avoid a
6522 possible random value that matches one of those tested as
6523 condition to clear the mouse face.
6525 2011-10-28 Chong Yidong <cyd@gnu.org>
6527 * xdisp.c (note_mouse_highlight): Fix use of uninitialized var.
6529 2011-10-28 Dan Nicolaescu <dann@ics.uci.edu>
6531 * window.c (make_window): Initialize phys_cursor_on_p.
6533 2011-10-28 Stefan Monnier <monnier@iro.umontreal.ca>
6535 * lisp.h (struct Lisp_Symbol): Update comments.
6537 2011-10-28 Juanma Barranquero <lekktu@gmail.com>
6539 * w32font.c (w32_load_unicows_or_gdi32): Add missing return.
6541 2011-10-28 Eli Zaretskii <eliz@gnu.org>
6543 Fix Emacs on Windows 9X (bug#8562). Thanks to oslsachem
6544 <oslsachem@gmail.com> for helping to debug this.
6546 * w32font.c (g_b_init_is_w9x, g_b_init_get_outline_metrics_w)
6547 (g_b_init_get_text_metrics_w, g_b_init_get_glyph_outline_w)
6548 (g_b_init_get_glyph_outline_w): New static variables.
6549 (GetOutlineTextMetricsW_Proc, GetTextMetricsW_Proc)
6550 (GetGlyphOutlineW_Proc): New typedefs.
6551 (w32_load_unicows_or_gdi32, get_outline_metrics_w)
6552 (get_text_metrics_w, get_glyph_outline_w, globals_of_w32font):
6554 (w32font_open_internal, compute_metrics):
6555 Call get_outline_metrics_w, get_text_metrics_w, and get_glyph_outline_w
6556 instead of calling the "wide" APIs directly.
6558 * emacs.c (main) [HAVE_NTGUI]: Call globals_of_w32font.
6560 * w32.h (syms_of_w32font): Add prototype.
6562 2011-10-27 Juanma Barranquero <lekktu@gmail.com>
6564 * window.c (Fframe_root_window, Fframe_first_window, Fwindow_end)
6565 (Fframe_selected_window, Ftemp_output_buffer_show, Fnext_window)
6566 (Fdelete_window_internal, Fwindow_parameters): Fix typos in docstrings.
6567 (Fmove_to_window_line): Doc fix.
6569 2011-10-27 Chong Yidong <cyd@gnu.org>
6571 * process.c (make_process): Set gnutls_state to NULL.
6573 * gnutls.c (emacs_gnutls_deinit): Deinit the gnutls_state if it is
6574 non-NULL, regardless of GNUTLS_INITSTAGE.
6575 (Fgnutls_boot): Cleanups. Call emacs_gnutls_deinit if we signal
6576 an error. Set process slots as soon as we allocate them.
6578 * gnutls.h (GNUTLS_LOG, GNUTLS_LOG2): Fix macros.
6580 2011-10-27 Chong Yidong <cyd@gnu.org>
6582 * gnutls.c (emacs_gnutls_deinit): New function.
6583 Deallocate credentials structures as well as calling gnutls_deinit.
6584 (Fgnutls_deinit, Fgnutls_boot): Use it.
6586 * process.c (make_process): Initialize GnuTLS credentials to NULL.
6587 (deactivate_process): Call emacs_gnutls_deinit.
6589 2011-10-27 Juanma Barranquero <lekktu@gmail.com>
6591 * image.c (x_create_x_image_and_pixmap):
6592 * w32.c (sys_rename, w32_delayed_load):
6593 * w32font.c (fill_in_logfont):
6594 * w32reg.c (x_get_string_resource): Silence compiler warnings.
6596 2011-10-26 Juanma Barranquero <lekktu@gmail.com>
6598 * w32fns.c (w32_default_color_map): New function,
6599 extracted from Fw32_default_color_map.
6600 (Fw32_default_color_map, Fx_open_connection): Use it. (Bug#9785)
6602 2011-10-25 Paul Eggert <eggert@cs.ucla.edu>
6604 * dispextern.h (Fcontrolling_tty_p): New decl (Bug#6649 part 2).
6606 2011-10-25 Stefan Monnier <monnier@iro.umontreal.ca>
6608 * keyboard.c (test_undefined): New function (bug#9751).
6609 (read_key_sequence): Use it to detect when a key is bound to `undefined'.
6611 2011-10-25 Enami Tsugutomo <tsugutomo.enami@jp.sony.com>
6613 * sysdep.c (init_sys_modes): Fix the check for the controlling
6614 terminal (Bug#6649).
6616 2011-10-20 Eli Zaretskii <eliz@gnu.org>
6618 * dispextern.h (struct bidi_it): New member next_en_type.
6620 * bidi.c (bidi_line_init): Initialize the next_en_type member.
6621 (bidi_resolve_explicit_1): When next_en_pos is valid for the
6622 current character, check also for next_en_type being WEAK_EN.
6623 (bidi_resolve_weak): Don't enter the expensive loop if the current
6624 position is before next_en_pos. Record the bidi type of the first
6625 non-ET, non-BN character we find, in addition to its position.
6626 (bidi_level_of_next_char): Invalidate next_en_type when
6627 next_en_pos is over-stepped.
6629 2011-10-20 Paul Eggert <eggert@cs.ucla.edu>
6631 Time zone name fixes for non-ASCII locales (Bug#641, Bug#9794)
6632 * editfns.c: Rewrite current-time-zone so that it invokes
6633 the equivalent of (format-time-string "%Z") to get the time zone name.
6634 This fixes a bug when the time zone name contains characters that
6635 need converting from the system time locale to Emacs internal format.
6636 This fixes a shortcoming that I introduced in my 1999-10-19 patch:
6637 that patch fixed format-time-string to do the conversion, but
6638 I forgot to fix current-time-zone.
6639 (format_time_string): New function, containing most of
6640 what Fformat_time_string used to contain.
6641 (Fformat_time_string): Rewrite in terms of format_time_string.
6642 This doesn't change this function's behavior.
6643 (current-time-zone): Rewrite to use format_time_string.
6644 This fixes the bug reported by Michael Schierl in
6645 <http://lists.gnu.org/archive/html/emacs-devel/2007-06/msg00334.html>.
6646 Jason Rumney's 2007-06-07 change worked around this bug, but
6648 * systime.h (tzname, timezone): Remove no-longer-used declarations.
6650 2011-10-19 Eli Zaretskii <eliz@gnu.org>
6652 * xdisp.c (start_display): If the character at POS is displayed
6653 via a display vector, reset IT->current.dpvec_index to zero.
6654 (try_window_reusing_current_matrix): If a line ends in a display
6655 vector or the next line starts in a display vector, continue
6656 redrawing the window even though the character position of
6657 start_row was reached.
6660 2011-10-18 Chong Yidong <cyd@gnu.org>
6662 * xdisp.c (get_next_display_element): Handle U+2010 and U+2011
6663 with nobreak-char-display too.
6665 2011-10-18 Eli Zaretskii <eliz@gnu.org>
6667 Fix part 3 of bug#9771.
6668 * bidi.c (bidi_line_init): Initialize next_en_pos to zero, not -1.
6669 (bidi_resolve_neutral): Don't enter the expensive loop looking for
6670 non-neutral characters if the current character is a paragraph
6671 separator (a.k.a. Newline). This avoids running the same
6672 expensive loop twice, once when we consume the preceding newline
6673 and the other time when the line actually needs to be displayed.
6674 Avoid the loop when we see neutrals on the base embedding level
6675 following a character whose directionality is the same as the
6676 paragraph's. This avoids running the expensive loop when a line
6677 ends in a long sequence of neutrals, like control characters.
6678 Add assertion against STRONG_AL type. Slightly rearrange code
6679 that determines the type of a neutral given the first non-neutral
6681 (bidi_level_of_next_char): Set next_en_pos to zero when
6682 invalidating its info.
6684 2011-10-17 Eli Zaretskii <eliz@gnu.org>
6686 * xdisp.c (push_display_prop): Determine whether to record string
6687 or buffer position by IT->string, not by IT->method. Allow
6688 GET_FROM_DISPLAY_VECTOR as IT->method on entry. (Bug#9771, part 4)
6689 (move_it_vertically_backward): Don't look for character position
6690 immediately after the newline when in a continuation line.
6693 2011-10-15 Martin Rudalics <rudalics@gmx.at>
6695 * window.c (coordinates_in_window): Rewrite and delabelize
6696 vertical border check. (Bug#5357) (Bug#9618)
6698 2011-10-14 Stefan Monnier <monnier@iro.umontreal.ca>
6700 * xterm.c (frame_highlight, frame_unhighlight): Ignore unexplained
6701 errors in XSetWindowBorder (bug#9310).
6703 2011-10-13 Dmitry Antipov <dmantipov@yandex.ru>
6705 * editfns.c (Fset_time_zone_rule): Replace free with xfree to
6706 avoid crash when xmalloc overrun checking is enabled.
6708 2011-10-13 Eli Zaretskii <eliz@gnu.org>
6710 * xdisp.c (Fcurrent_bidi_paragraph_direction): Initialize
6711 itb.paragraph_dir to NEUTRAL_DIR. Fixes an occasional incorrect
6712 cursor motion with <left> and <right> arrow keys.
6714 * bidi.c (bidi_init_it): Don't initialize paragraph_dir here, as
6715 some callers set that themselves.
6717 2011-10-12 Eli Zaretskii <eliz@gnu.org>
6719 * xdisp.c (find_row_edges): Handle the case where ROW comes from a
6720 display string and the previous row comes from the same string and
6721 is empty. (Bug#9739) (Bug#9738)
6723 2011-10-12 Stefan Monnier <monnier@iro.umontreal.ca>
6725 * doc.c (get_doc_string): Encode file name (bug#9735).
6727 2011-10-12 Eli Zaretskii <eliz@gnu.org>
6729 * bidi.c (bidi_level_of_next_char):
6730 * xdisp.c (get_visually_first_element): Remove old incorrect
6731 comments regarding the Unicode Line Separator character.
6733 * bidi.c (bidi_init_it): Initialize paragraph_dir to NEUTRAL_DIR.
6735 2011-10-12 Dmitry Antipov <dmantipov@yandex.ru>
6737 * alloc.c (Fgc_status): Do not access beyond zombies array
6738 boundary if nzombies > MAX_ZOMBIES.
6739 * alloc.c (dump_zombies): Add missing format specifier.
6741 2011-10-12 Paul Eggert <eggert@cs.ucla.edu>
6743 * xdisp.c (set_cursor_from_row): Simplify conditionals,
6744 to pacify GCC 4.6.1 x86-64 with -O2 -Wstrict-overflow.
6746 * lread.c (read_escape): Allow hex escapes as large as ?\xfffffff.
6747 Some packages use them to denote characters with modifiers.
6749 2011-10-11 Andreas Schwab <schwab@linux-m68k.org>
6751 * lisp.h (GCPRO1_VAR, GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR)
6752 (GCPRO5_VAR, GCPRO6_VAR, UNGCPRO_VAR): Add whitespace to avoid
6753 matching a pp-number. Rename parameter var to var1.
6755 2011-10-11 Stefan Monnier <monnier@iro.umontreal.ca>
6757 * minibuf.c (Finternal_complete_buffer): Fix last change (bug#9709).
6759 2011-10-08 Glenn Morris <rgm@gnu.org>
6761 * callint.c (Fcall_interactively): Give a more explicit error for the
6762 'c' case with a non-character input. (Bug#8479)
6764 2011-10-08 Eli Zaretskii <eliz@gnu.org>
6766 * xdisp.c (hscroll_window_tree): Support hscroll in right-to-left
6768 (set_cursor_from_row): Fix cursor positioning in mixed L2R+R2L
6769 lines that are hscrolled on the left.
6771 * dispnew.c (buffer_posn_from_coords): Account for a possible
6772 presence of header-line. (Bug#4426)
6774 2011-10-07 Stefan Monnier <monnier@iro.umontreal.ca>
6776 * buffer.c (syms_of_buffer) <enable-multibyte-characters>:
6777 Don't advertise functionality which we discourage or doesn't work.
6779 2011-10-07 Paul Eggert <eggert@cs.ucla.edu>
6781 * alloc.c (GC_LISP_OBJECT_ALIGNMENT): Use offsetof, not __alignof__
6782 or sizeof. __alignof__ gives the wrong answer on Fedora x86-64
6783 with GCC 4.6.1 when configured with CC='gcc -m32' --with-wide-int;
6784 this makes Emacs dump core during garbage collection on rare
6785 occasions. sizeof is obviously inferior to offsetof here, so
6786 stick with offsetof.
6787 (GC_POINTER_ALIGNMENT): New macro.
6788 (mark_memory): Omit 3rd (offset) arg; caller changed.
6789 Don't assume EMACS_INT alignment is the same as pointer alignment.
6791 2011-10-03 Stefan Monnier <monnier@iro.umontreal.ca>
6793 * keyboard.c (read_key_sequence_remapped): New var.
6794 (read_key_sequence): Compute remapping in the right buffer.
6795 (command_loop_1): Use read_key_sequence's remapping directly.
6797 2011-10-02 Stefan Monnier <monnier@iro.umontreal.ca>
6799 * dired.c (file_name_completion): Don't expand file name.
6800 (Ffile_name_completion, Ffile_name_all_completions): Expand file name
6801 before checking file name handler.
6803 * minibuf.c (Finternal_complete_buffer): Only show internal buffers if
6804 they've been requested explicitly (bug#9591).
6806 2011-10-01 Andreas Schwab <schwab@linux-m68k.org>
6808 * keymap.c (Fsingle_key_description): Use make_specified_string
6809 instead of build_string to build string from push_key_description.
6812 2011-09-30 Paul Eggert <eggert@cs.ucla.edu>
6814 * buffer.h (struct buffer): Use time_t, not int, for a time stamp.
6815 This fixes a Y2038 bug on 64-bit hosts.
6816 * buffer.c (reset_buffer):
6817 * fileio.c (Fdo_auto_save, Fset_buffer_auto_saved)
6818 (Fclear_buffer_auto_save_failure):
6819 Use 0, not -1, to represent an unset failure time, since time_t
6820 might not be signed.
6822 Remove dependency on glibc malloc internals.
6823 * alloc.c (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
6824 Move back here from lisp.h, but with their new implementations.
6825 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
6826 (XMALLOC_OVERRUN_SIZE_SIZE): Move these new lisp.h macros here.
6827 * charset.c (charset_table_init): New static var.
6828 (syms_of_charset): Use it instead of xmalloc. This removes a
6829 dependency on glibc malloc internals. See Eli Zaretskii's comment in
6830 <http://lists.gnu.org/archive/html/emacs-devel/2011-09/msg00815.html>.
6831 * lisp.h (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
6832 Move back to alloc.c.
6833 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
6834 (XMALLOC_OVERRUN_SIZE_SIZE): Move to alloc.c.
6836 2011-09-30 Jan Djärv <jan.h.d@swipnet.se>
6838 * nsterm.m (windowDidResize): Call x_set_window_size only when
6839 ns_in_resize is true. Otherwise set pixelwidth/height and
6840 call change_frame_size (Bug#9628).
6842 2011-09-30 Paul Eggert <eggert@cs.ucla.edu>
6844 Port --enable-checking=all to Fedora 14 x86-64.
6845 * charset.c (syms_of_charset): Also account for glibc malloc's
6846 internal overhead when calculating the initial malloc maximum.
6848 Port --enable-checking=all to Fedora 14 x86.
6849 * alloc.c (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
6851 (xmalloc_put_size, xmalloc_get_size, overrun_check_malloc)
6852 (overrun_check_realloc, overrun_check_free):
6853 Use XMALLOC_OVERRUN_SIZE_SIZE, not sizeof (size_t).
6854 That way, xmalloc returns a properly-aligned pointer even if
6855 XMALLOC_OVERRUN_CHECK is defined. The old debugging code happened
6856 to align OK on typical 64-bit hosts, but not on Fedora 14 x86.
6857 * charset.c (syms_of_charset): Take XMALLOC_OVERRUN_CHECK_OVERHEAD
6858 into account when calculating the initial malloc maximum.
6859 * lisp.h (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
6860 Move here from alloc.c, so that charset.c can use it too.
6861 Properly align; the old code wasn't right for common 32-bit hosts
6862 when configured with --enable-checking=all.
6863 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
6864 (XMALLOC_OVERRUN_SIZE_SIZE): New macros.
6866 2011-09-29 Eli Zaretskii <eliz@gnu.org>
6868 * sysdep.c (snprintf) [!EOVERFLOW]: If EOVERFLOW is not defined,
6871 2011-09-28 Eli Zaretskii <eliz@gnu.org>
6873 * xdisp.c (compute_display_string_end): If there's no display
6874 string at CHARPOS, return -1.
6876 * bidi.c (bidi_fetch_char): When compute_display_string_end
6877 returns a negative value, treat the character as a normal
6878 character not covered by a display string. (Bug#9624)
6880 2011-09-28 Juanma Barranquero <lekktu@gmail.com>
6882 * lread.c (Fread_from_string): Fix typo in docstring.
6884 2011-09-27 Eli Zaretskii <eliz@gnu.org>
6886 * xdisp.c (handle_invisible_prop): If invisible text ends on a
6887 newline, reseat the iterator instead of bidi-iterating there one
6888 character at a time. (Bug#9610)
6889 (BUFFER_POS_REACHED_P, move_it_in_display_line_to): Bail when past
6890 TO_CHARPOS if the bidi iterator is at base embedding level.
6892 2011-09-27 Andreas Schwab <schwab@linux-m68k.org>
6894 * lread.c (readevalloop): Use correct code for NBSP.
6895 (read1): Likewise. (Bug#9608)
6897 2011-09-25 Michael Albinus <michael.albinus@gmx.de>
6899 * dbusbind.c (Fdbus_register_signal): When service is not
6900 registered, use nil in Vdbus_registered_objects_table. (Bug#9581)
6902 2011-09-25 Glenn Morris <rgm@gnu.org>
6904 * buffer.c (truncate-lines): Doc fix.
6906 2011-09-24 Chong Yidong <cyd@stupidchicken.com>
6908 * window.c (Fwindow_prev_buffers, Fset_window_prev_buffers)
6909 (Fset_window_next_buffers): Doc fix.
6911 2011-09-24 Glenn Morris <rgm@gnu.org>
6913 * minibuf.c (read_minibuf): Disable line truncation. (Bug#5715)
6915 2011-09-24 Paul Eggert <eggert@cs.ucla.edu>
6917 Fix minor problems found by static checking.
6918 * xdisp.c (string_from_display_spec): Don't assume vecsize fits in int.
6919 * indent.c (Fvertical_motion): Fix == vs = typo.
6921 2011-09-24 Eli Zaretskii <eliz@gnu.org>
6923 * dispnew.c (syms_of_display) <redisplay-dont-pause>:
6924 Default value is now t. Doc fix.
6926 * indent.c (Fvertical_motion): Compute and apply the overshoot
6927 logic when moving up, not only when moving down. Fix the
6928 confusing name and values of the it_overshoot_expected variable;
6929 logic changes accordingly. (Bug#9254) (Bug#9549)
6931 * xdisp.c (pos_visible_p): Produce correct pixel coordinates when
6932 CHARPOS is covered by a display string which includes newlines.
6933 (move_it_vertically_backward): Avoid inflooping when START_CHARPOS
6934 is covered by a display string with embedded newlines.
6936 2011-09-24 Michael Albinus <michael.albinus@gmx.de>
6938 * dbusbind.c (Fdbus_register_signal): Add match rule to
6939 Vdbus_registered_objects_table. (Bug#9581)
6940 (Fdbus_register_method, Vdbus_registered_objects_table):
6943 2011-09-24 Jim Meyering <meyering@redhat.com>
6945 do not ignore write error for any output size
6946 The previous change was incomplete.
6947 While it makes emacs --batch detect the vast majority of stdout
6948 write failures, errors were still ignored whenever the output size is
6949 k * (BUFSIZ+1) - 4. E.g., on a system with BUFSIZ of 4096,
6950 $ emacs --batch --eval '(print (format "%4093d" 0))' > /dev/full \
6951 && echo FAIL: ignored write error
6952 FAIL: ignored write error
6953 $ emacs --batch --eval '(print (format "%20481d" 0))' > /dev/full \
6954 && echo FAIL: ignored write error
6955 FAIL: ignored write error
6956 * emacs.c (Fkill_emacs): Also test ferror. (Bug#9574)
6958 2011-09-23 Andreas Schwab <schwab@linux-m68k.org>
6960 * emacs.c (Fkill_emacs): In noninteractive mode exit
6961 non-successfully if a write error occurred on stdout. (Bug#9574)
6963 2011-09-21 Eli Zaretskii <eliz@gnu.org>
6965 * xdisp.c (pop_it): Allow it->object that is a cons cell to pass
6968 * dispextern.h (struct it): Update the comment documenting what
6971 2011-09-20 Eli Zaretskii <eliz@gnu.org>
6973 * xdisp.c (set_cursor_from_row): If the row ends in a newline from
6974 a display string, extend search for cursor position to end of row.
6975 (find_row_edges): If the row ends in a newline from a display
6976 string, increment its MATRIX_ROW_END_CHARPOS by one. (Bug#9549)
6977 Handle the case of a display string with multiple newlines.
6978 (Fcurrent_bidi_paragraph_direction): Fix search for previous
6979 non-empty line. Fixes confusing cursor motion with arrow keys at
6980 the beginning of a line that starts with whitespace.
6982 2011-09-19 Lars Magne Ingebrigtsen <larsi@gnus.org>
6984 * lread.c (Fread_from_string): Document what FINAL-STRING-INDEX is
6987 2011-09-18 Chong Yidong <cyd@stupidchicken.com>
6989 * xfns.c (Fx_create_frame): Handle the bitmapIcon resource as
6992 2011-09-18 Eli Zaretskii <eliz@gnu.org>
6994 * xdisp.c (display_line): Record maximum and minimum buffer
6995 positions even if no glyphs were produced (e.g., by a zero-width
6996 stretch). Fixes bug#9530 on a TTY. Under word-wrap, don't record
6997 buffer positions that will be removed from the glyph row because
6999 (produce_stretch_glyph): Fix a bug in :align-to on a TTY when the
7000 column is beyond frame width: don't subtract 1 "pixel" when
7001 computing width of the stretch.
7002 (reseat_at_next_visible_line_start): Undo the change made on
7003 2011-09-17 that saved paragraph information and restored it after
7004 the call to `reseat'. (Bug#9545)
7006 2011-09-18 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
7008 * xdisp.c (expose_window): Save original value of phys_cursor_on_p
7009 and turn window cursor on if cleared (Bug#9415).
7011 2011-09-18 Andreas Schwab <schwab@linux-m68k.org>
7013 * search.c (boyer_moore): Take unibyte characters from pattern
7014 literally. (Bug#9458)
7016 2011-09-18 Eli Zaretskii <eliz@gnu.org>
7018 * xdisp.c (reseat_at_next_visible_line_start): Fix last change.
7020 2011-09-18 Paul Eggert <eggert@cs.ucla.edu>
7022 Fix minor problem found by static checking.
7023 * xdisp.c (reseat_at_next_visible_line_start): Mark locals as
7024 initialized, to pacify gcc -Wuninitialized.
7026 * fileio.c: Report proper errno when syscall falls.
7027 (Finsert_file_contents): Save and restore errno,
7028 so that report_file_error outputs the correct diagnostic.
7029 (Fwrite_region) [CLASH_DETECTION]: Likewise.
7031 2011-09-18 Eli Zaretskii <eliz@gnu.org>
7033 * .gdbinit (pgx): Fix references to fields of `struct glyph'.
7035 2011-09-17 Eli Zaretskii <eliz@gnu.org>
7037 * xdisp.c (produce_stretch_glyph): Another fix for changes made on
7038 2011-08-30T17:32:44Z!eliz@gnu.org. (Bug#9530)
7040 2011-09-17 Eli Zaretskii <eliz@gnu.org>
7042 * xdisp.c (reseat_at_next_visible_line_start): Keep information
7043 about the current paragraph and restore it after the call to reseat.
7045 * bidi.c (MAX_PARAGRAPH_SEARCH): New macro.
7046 (bidi_find_paragraph_start): Search back for paragraph beginning
7047 at most MAX_PARAGRAPH_SEARCH lines; if not found, return BEGV_BYTE.
7048 (bidi_move_to_visually_next): Only trigger paragraph-related
7049 computations when the last character is a newline or at EOB, not
7050 just any NEUTRAL_B. (Bug#9470)
7052 * xdisp.c (set_cursor_from_row): Don't invoke special treatment of
7053 truncated lines if point is covered by a display string. (Bug#9524)
7055 2011-09-16 Paul Eggert <eggert@cs.ucla.edu>
7057 * xselect.c: Relax test for outgoing X longs (Bug#9498).
7058 (cons_to_x_long): New function.
7059 (lisp_data_to_selection_data): Use it. Correct the test for
7060 short-versus-long data; it was negated. Break out of vector
7061 loop, for efficiency, when a long datum is discovered.
7063 2011-09-16 Stefan Monnier <monnier@iro.umontreal.ca>
7065 * eval.c (Fquote): Document its non-consing behavior (bug#9482).
7067 2011-09-16 Eli Zaretskii <eliz@gnu.org>
7069 * image.c (tiff_handler): Work around a bug in MinGW GCC 3.x (see
7070 GCC PR/17406) by declaring this function with external scope.
7072 2011-09-15 Paul Eggert <eggert@cs.ucla.edu>
7074 * editfns.c (Fformat): Fix bug in text-property fix (Bug#9514).
7075 Don't mishandle (length (format "%%")) and (format "%4000s%%" "").
7077 2011-09-15 Andreas Schwab <schwab@linux-m68k.org>
7079 * editfns.c (Fformat): Correctly handle text properties on "%%".
7081 2011-09-15 Eli Zaretskii <eliz@gnu.org>
7083 * xterm.c (x_draw_composite_glyph_string_foreground):
7084 * w32term.c (x_draw_composite_glyph_string_foreground):
7085 * term.c (encode_terminal_code):
7086 * composite.c (composition_update_it, get_composition_id):
7087 * xdisp.c (get_next_display_element)
7088 (fill_composite_glyph_string): Add comments about special meaning
7089 of TAB characters in a composition.
7091 2011-09-15 Paul Eggert <eggert@cs.ucla.edu>
7093 * editfns.c (Fformat): Fix off-by-1 bug for "%%b" (Bug#9514).
7094 This occurs when processing a multibyte format.
7095 Problem reported by Wolfgang Jenker.
7097 2011-09-15 Johan Bockgård <bojohan@gnu.org>
7099 * xdisp.c (try_cursor_movement): Only check for exact match if
7100 cursor hpos found by set_cursor_from_row is valid. (Bug#9495)
7102 2011-09-14 Paul Eggert <eggert@cs.ucla.edu>
7104 Remove unused external symbols.
7105 * dispextern.h (calc_pixel_width_or_height): Remove decl.
7106 * xdisp.c (calc_pixel_width_or_height): Now static.
7107 * doprnt.c (exprintf) [! (HAVE_X_WINDOWS && USE_X_TOOLKIT)]: Remove.
7108 * indent.c (check_display_width):
7109 * w32term.c: Fix comment to match code.
7110 * xterm.c, xterm.h (x_catching_errors): Remove.
7112 2011-09-14 Paul Eggert <eggert@cs.ucla.edu>
7114 * xselect.c: Use signed conversions more consistently (Bug#9498).
7115 (selection_data_to_lisp_data): Assume incoming selection data are
7116 signed integers, not unsigned. This is to be consistent with
7117 outgoing selection data, which was modified to use signed integers
7118 in as part of the fix to Bug#9196 in response to Jan D.'s comment
7119 in <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9196#32> that X11
7120 expects long, not unsigned long.
7122 2011-09-14 Eli Zaretskii <eliz@gnu.org>
7124 * xdisp.c (try_window_reusing_current_matrix): Fix incorrect
7125 computation of loop end. Reported by Johan Bockgård
7128 2011-09-13 Chong Yidong <cyd@stupidchicken.com>
7130 * frame.c (Fother_visible_frames_p): Function deleted.
7132 2011-09-12 Eli Zaretskii <eliz@gnu.org>
7134 * indent.c (compute_motion): Process display vector front to back
7135 rather than the other way around. (Bug#2496)
7137 2011-09-12 Stefan Monnier <monnier@iro.umontreal.ca>
7139 * fileio.c (Finsert_file_contents): Don't assume beg_offset is 0.
7141 2011-09-11 Chong Yidong <cyd@stupidchicken.com>
7143 * minibuf.c (Fread_from_minibuffer): Doc fix.
7145 2011-09-11 Eli Zaretskii <eliz@gnu.org>
7147 * xdisp.c (produce_stretch_glyph): Fix a typo made in changes from
7148 2011-08-30T17:32:44Z!eliz@gnu.org. (Bug#9475)
7150 2011-09-11 Lars Magne Ingebrigtsen <larsi@gnus.org>
7152 * fileio.c (Fvisited_file_modtime): Document `(-1 65535)' as a
7153 value for non-existent files.
7155 2011-09-11 Eli Zaretskii <eliz@gnu.org>
7157 * fileio.c (Finsert_file_contents): If the file cannot be opened,
7158 set its "size" to -1. This will set the modtime_size field of
7159 the corresponding buffer to -1, which is what
7160 verify-visited-file-modtime expects for files that do not exist.
7163 2011-09-11 Paul Eggert <eggert@cs.ucla.edu>
7165 * keymap.h (KEY_DESCRIPTION_SIZE, push_key_description): Move decls
7167 * lisp.h: ... from here. push_key_description is no longer
7168 defined in keyboard.c, so its declaration should not be in
7169 lisp.h's "Defined in keyboard.c" section, and KEY_DESCRIPTION_SIZE
7170 logically belongs with push_key_description.
7172 2011-09-10 Paul Eggert <eggert@cs.ucla.edu>
7174 * buffer.h: Include <sys/types.h> instead of <time.h>.
7175 Otherwise, off_t wasn't defined on FreeBSD 9.0-BETA2 i386.
7176 Problem reported by Herbert J. Skuhra.
7178 2011-09-10 Lars Magne Ingebrigtsen <larsi@gnus.org>
7180 * xml.c (parse_region): Make the parsing work for
7181 non-comment-starting XML files again (bug#9144).
7183 2011-09-10 Andreas Schwab <schwab@linux-m68k.org>
7185 * image.c (gif_load): Fix calculation of bottom and right corner.
7188 2011-09-10 Eli Zaretskii <eliz@gnu.org>
7190 * xdisp.c (MAX_DISP_SCAN): Decrease to 250. Prevents sluggish
7191 redisplay in small windows.
7193 2011-09-09 Eli Zaretskii <eliz@gnu.org>
7195 * frame.c (x_report_frame_params): Cast to avoid compiler warnings.
7197 2011-09-08 Martin Rudalics <rudalics@gmx.at>
7199 * window.c (Fset_window_prev_buffers, Fset_window_next_buffers):
7200 Operate on live windows only.
7202 2011-09-08 Juanma Barranquero <lekktu@gmail.com>
7204 * emacs.c (my_heap_start): #ifdef to avoid warnings when unused.
7206 2011-09-07 Eli Zaretskii <eliz@gnu.org>
7208 * xdisp.c (move_it_in_display_line_to): Call RESTORE_IT on ppos_it
7209 only under bidi iteration.
7211 2011-09-07 Jan Djärv <jan.h.d@swipnet.se>
7213 * gtkutil.c (xg_make_tool_item): Insert comment about eventbox.
7215 2011-09-06 Paul Eggert <eggert@cs.ucla.edu>
7217 isnan: Fix porting problem to Solaris 10 with bundled gcc.
7218 Without this fix, the command to link temacs failed due to an
7219 undefined symbol __builtin_isnan. This is because
7220 /usr/include/iso/math_c99.h #defines isnan(x) to
7221 __builtin_isnan(x), but the bundled gcc, which identifies itself
7222 as gcc 3.4.3 (csl-sol210-3_4-branch+sol_rpath), does not have
7224 * floatfns.c (isnan): #undef, and then #define to a clone of
7226 (Fisnan): Always define, since it's always available now.
7227 (syms_of_floatfns): Always define isnan at the Lisp level.
7229 2011-09-06 Paul Eggert <eggert@cs.ucla.edu>
7231 * Makefile.in (gl-stamp): move-if-change now in build-aux (Bug#9169).
7233 2011-09-06 Paul Eggert <eggert@cs.ucla.edu>
7235 * fileio.c: Fix bugs with large file offsets (Bug#9428).
7236 The previous code assumed that file offsets (off_t values) fit in
7237 EMACS_INT variables, which is not true on typical 32-bit hosts.
7238 The code messed up by falsely reporting buffer overflow in cases
7239 such as (insert-file-contents "big" nil 1 2) into an empty buffer
7240 when "big" contains more than 2**29 bytes, even though this
7241 inserts just one byte and does not overflow the buffer.
7242 (Finsert_file_contents): Store file offsets as off_t
7243 values, not as EMACS_INT values. Check for overflow when
7244 converting between EMACS_INT and off_t. When checking for
7245 buffer overflow or for overlap, take the offsets into account.
7246 Don't use EMACS_INT for small values where int suffices.
7247 When checking for overlap, fix a typo: ZV was used where
7248 ZV_BYTE was intended.
7249 (Fwrite_region): Don't assume off_t fits into 'long'.
7250 * buffer.h (struct buffer.modtime_size): Now off_t, not EMACS_INT.
7252 2011-09-05 Michael Albinus <michael.albinus@gmx.de>
7254 * dbusbind.c (xd_signature_cat): Rename from signature_cat.
7256 2011-09-04 Paul Eggert <eggert@cs.ucla.edu>
7258 sprintf-related integer and memory overflow issues (Bug#9412).
7260 * doprnt.c (doprnt): Support printing ptrdiff_t and intmax_t values.
7261 (esprintf, exprintf, evxprintf): New functions.
7262 * keyboard.c (command_loop_level): Now EMACS_INT, not int.
7263 (cmd_error): Kbd macro iterations count is now EMACS_INT, not int.
7264 (modify_event_symbol): Do not assume that the length of
7265 name_alist_or_stem is safe to alloca and fits in int.
7266 (Fexecute_extended_command): Likewise for function name and binding.
7267 (Frecursion_depth): Wrap around reliably on integer overflow.
7268 * keymap.c (push_key_description): First arg is now EMACS_INT, not int,
7269 since some callers pass EMACS_INT values.
7270 (Fsingle_key_description): Don't crash if symbol name contains more
7271 than MAX_ALLOCA bytes.
7272 * minibuf.c (minibuf_level): Now EMACS_INT, not int.
7273 (get_minibuffer): Arg is now EMACS_INT, not int.
7274 * lisp.h (get_minibuffer, push_key_description): Reflect API changes.
7275 (esprintf, exprintf, evxprintf): New decls.
7276 * window.h (command_loop_level, minibuf_level): Reflect API changes.
7278 * dbusbind.c (signature_cat): New function.
7279 (xd_signature, Fdbus_register_signal):
7280 Do not overrun buffer; instead, report string overflow.
7282 * dispnew.c (add_window_display_history): Don't overrun buffer.
7283 Truncate instead; this is OK since it's just a log.
7285 * editfns.c (Fcurrent_time_zone): Don't overrun buffer
7286 even if the time zone offset is outlandishly large.
7287 Don't mishandle offset == INT_MIN.
7289 * emacs.c (main) [NS_IMPL_COCOA]: Don't overrun buffer
7290 when creating daemon; the previous buffer-overflow check was incorrect.
7292 * eval.c (verror): Simplify by rewriting in terms of evxprintf,
7293 which has the guts of the old verror function.
7295 * filelock.c (lock_file_1, lock_file): Don't blindly alloca long name;
7296 use SAFE_ALLOCA instead. Use esprintf to avoid int-overflow issues.
7298 * font.c: Include <float.h>, for DBL_MAX_10_EXP.
7299 (font_unparse_xlfd): Don't blindly alloca long strings.
7300 Don't assume XINT result fits in int, or that XFLOAT_DATA * 10
7301 fits in int, when using sprintf. Use single snprintf to count
7302 length of string rather than counting it via multiple sprintfs;
7303 that's simpler and more reliable.
7304 (font_unparse_fcname): Use it to avoid sprintf buffer overrun.
7305 (generate_otf_features) [0 && HAVE_LIBOTF]: Use esprintf, not
7306 sprintf, in case result does not fit in int.
7308 * fontset.c (num_auto_fontsets): Now printmax_t, not int.
7309 (fontset_from_font): Print it.
7311 * frame.c (tty_frame_count): Now printmax_t, not int.
7312 (make_terminal_frame, set_term_frame_name): Print it.
7313 (x_report_frame_params): In X, window IDs are unsigned long,
7314 not signed long, so print them as unsigned.
7315 (validate_x_resource_name): Check for implausibly long names,
7316 and don't assume name length fits in 'int'.
7317 (x_get_resource_string): Don't blindly alloca invocation name;
7318 use SAFE_ALLOCA. Use esprintf, not sprintf, in case result does
7321 * gtkutil.c: Include <float.h>, for DBL_MAX_10_EXP.
7322 (xg_check_special_colors, xg_set_geometry):
7323 Make sprintf buffers a bit bigger, to avoid potential buffer overrun.
7325 * lread.c (dir_warning): Don't blindly alloca buffer; use SAFE_ALLOCA.
7326 Use esprintf, not sprintf, in case result does not fit in int.
7328 * macros.c (executing_kbd_macro_iterations): Now EMACS_INT, not int.
7329 (Fend_kbd_macro): Don't mishandle MOST_NEGATIVE_FIXNUM by treating
7330 it as a large positive number.
7331 (Fexecute_kbd_macro): Don't assume repeat count fits in int.
7332 * macros.h (executing_kbd_macro_iterations): Now EMACS_INT, not int.
7334 * nsterm.m ((NSSize)windowWillResize): Use esprintf, not sprintf,
7335 in case result does not fit in int.
7337 * print.c (float_to_string): Detect width overflow more reliably.
7338 (print_object): Make sprintf buffer a bit bigger, to avoid potential
7339 buffer overrun. Don't assume list length fits in 'int'. Treat
7340 print length of 0 as 0, not as infinity; to be consistent with other
7341 uses of print length in this function. Don't overflow print length
7342 index. Don't assume hash table size fits in 'long', or that
7343 vectorlike size fits in 'unsigned long'.
7345 * process.c (make_process): Use printmax_t, not int, to format
7346 process-name gensyms.
7348 * sysdep.c (snprintf) [! HAVE_SNPRINTF]: New function.
7350 * term.c (produce_glyphless_glyph): Make sprintf buffer a bit bigger
7351 to avoid potential buffer overrun.
7353 * xfaces.c (x_update_menu_appearance): Don't overrun buffer
7354 if X resource line is longer than 512 bytes.
7356 * xfns.c (x_window): Make sprintf buffer a bit bigger
7357 to avoid potential buffer overrun.
7359 * xterm.c (x_io_error_quitter): Don't overrun sprintf buffer.
7361 * xterm.h (x_check_errors): Add ATTRIBUTE_FORMAT_PRINTF.
7363 2011-09-04 Paul Eggert <eggert@cs.ucla.edu>
7365 Integer overflow fixes for scrolling, etc.
7366 Without these, Emacs silently mishandles large integers sometimes.
7367 For example, "C-u 4294967297 M-x recenter" was treated as if
7368 it were "C-u 1 M-x recenter" on a typical 64-bit host.
7370 * xdisp.c (try_window_id): Check Emacs fixnum range before
7371 converting to 'int'.
7373 * window.c (window_scroll_line_based, Frecenter):
7374 Check that an Emacs fixnum is in range before assigning it to 'int'.
7375 (Frecenter, Fmove_to_window_line): Use EMACS_INT, not int, for
7376 values converted from Emacs fixnums.
7377 (Frecenter): Don't wrap around a line count if it is out of 'int'
7378 range; instead, treat it as an extreme value.
7379 (Fset_window_configuration, compare_window_configurations):
7380 Use ptrdiff_t, not int, for index that might exceed 2 GiB.
7382 * search.c (Freplace_match): Use ptrdiff_t, not int, for indexes
7383 that can exceed INT_MAX. Check that EMACS_INT value is in range
7384 before assigning it to the (possibly-narrower) index.
7385 (match_limit): Don't assume that a fixnum can fit in 'int'.
7387 * print.c (print_object): Use ptrdiff_t, not int, for index that can
7390 * indent.c (position_indentation): Now takes ptrdiff_t, not int.
7391 (Fvertical_motion): Don't wrap around LINES values that don't fit
7392 in 'int'. Instead, treat them as extreme values. This is good
7393 enough for windows, which can't have more than INT_MAX lines anyway.
7395 2011-09-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
7397 * Require libxml/parser.h to avoid compilation warning.
7399 * emacs.c (shut_down_emacs): Call xmlCleanupParser on shutdown.
7401 * xml.c (parse_region): Don't call xmlCleanupParser after parsing,
7402 since this reportedly can destroy thread storage.
7404 2011-08-30 Chong Yidong <cyd@stupidchicken.com>
7406 * syntax.c (find_defun_start): Update all cache variables if
7407 exiting early (Bug#9401).
7409 2011-08-30 Eli Zaretskii <eliz@gnu.org>
7411 * image.c (x_bitmap_pixmap): Cast to int to avoid compiler warnings.
7413 * xdisp.c (produce_stretch_glyph): No longer static, compiled also
7414 when HAVE_WINDOW_SYSTEM is not defined. Support both GUI and TTY
7415 frames. Call tty_append_glyph in the TTY case. (Bug#9402)
7417 * term.c (tty_append_glyph): New function.
7418 (produce_stretch_glyph): Static function and its prototype deleted.
7420 * dispextern.h (produce_stretch_glyph, tty_append_glyph):
7423 2011-08-29 Paul Eggert <eggert@cs.ucla.edu>
7425 * image.c (parse_image_spec): Check for nonnegative, not for positive,
7426 when checking :margin (Bug#9390).
7427 (IMAGE_NON_NEGATIVE_INTEGER_VALUE_OR_PAIR):
7428 Rename from IMAGE_POSITIVE_INTEGER_VALUE_OR_PAIR,
7429 so that the name doesn't mislead. All uses changed.
7431 2011-08-28 Johan Bockgård <bojohan@gnu.org>
7433 * term.c (init_tty) [HAVE_GPM]: Move mouse settings after
7436 2011-08-27 Eli Zaretskii <eliz@gnu.org>
7438 * xdisp.c (move_it_to): Don't bail out early when reaching
7439 position beyond to_charpos, if we are scanning backwards.
7440 (move_it_vertically_backward): When DY == 0, make sure we get to
7441 the first character in the line after the newline.
7443 2011-08-27 Paul Eggert <eggert@cs.ucla.edu>
7445 * ccl.c: Improve and simplify overflow checking (Bug#9196).
7446 (ccl_driver): Do not generate an out-of-range pointer.
7447 (Fccl_execute_on_string): Remove unnecessary check for
7448 integer overflow, noted by Stefan Monnier in
7449 <http://lists.gnu.org/archive/html/emacs-devel/2011-08/msg00979.html>.
7450 Remove a FIXME that didn't need fixing.
7451 Simplify the newly-introduced buffer reallocation code.
7453 2011-08-27 Juanma Barranquero <lekktu@gmail.com>
7455 * makefile.w32-in ($(BLD)/alloc.$(O)): Depend on lib/verify.h.
7457 2011-08-26 Paul Eggert <eggert@cs.ucla.edu>
7459 Integer and memory overflow issues (Bug#9196).
7461 * doc.c (get_doc_string): Rework so that
7462 get_doc_string_buffer_size is the actual buffer size, rather than
7463 being 1 less than the actual buffer size; this makes xpalloc more
7466 * image.c (x_allocate_bitmap_record, cache_image):
7467 * xselect.c (Fx_register_dnd_atom):
7468 Simplify previous changes by using xpalloc.
7470 * buffer.c (overlay_str_len): Now ptrdiff_t, not EMACS_INT,
7471 since either will do and ptrdiff_t is convenient with xpalloc.
7473 * charset.c (charset_table_size)
7474 (struct charset_sort_data.priority): Now ptrdiff_t.
7475 (charset_compare): Don't overflow if priorities differ greatly.
7476 (Fsort_charsets): Don't assume list length fits in int.
7477 Check for size-calculation overflow when allocating sort data.
7478 (syms_of_charset): Allocate an initial charset table that is
7479 just under 64 KiB, to avoid problems with glibc malloc and mmap.
7481 * cmds.c (internal_self_insert): Check for size-calculation overflow.
7483 * composite.h (struct composition.glyph_len): Now int, not unsigned.
7484 The actual value is always <= INT_MAX, and leaving it unsigned made
7485 overflow checking harder.
7487 * dispextern.h (struct glyph_matrix.rows_allocated)
7488 (struct face_cache.size): Now ptrdiff_t, for convenience in use
7489 with xpalloc. The values are still always <= INT_MAX.
7491 * indent.c (compute_motion): Adjust to region_cache_forward sig change.
7493 * lisp.h (xnmalloc, xnrealloc, xpalloc): New decls.
7494 (SAFE_NALLOCA): New macro.
7496 * region-cache.c (struct boundary.pos, find_cache_boundary)
7497 (move_cache_gap, insert_cache_boundary, delete_cache_boundaries)
7498 (set_cache_region, invalidate_region_cache)
7499 (revalidate_region_cache, know_region_cache, region_cache_forward)
7500 (region_cache_backward, pp_cache):
7501 Use ptrdiff_t, not EMACS_INT, since either will do. This is needed
7502 so that ptrdiff_t * can be passed to xpalloc.
7503 (struct region_cache): Similarly, for gap_start, gap_len, cache_len,
7504 beg_unchanged, end_unchanged, buffer_beg, buffer_end members.
7505 (pp_cache): Don't assume cache_len fits in int.
7506 * region-cache.h: Adjust extern decls to match.
7508 * search.c (scan_buffer, Freplace_match): Use ptrdiff_t, not
7509 EMACS_INT, since either will do, for xpalloc.
7511 * alloc.c: Include verify.h, and check that int fits in ptrdiff_t.
7512 (xnmalloc, xnrealloc, xpalloc): New functions.
7514 * bidi.c (bidi_shelve_header_size): New constant.
7515 (bidi_cache_ensure_space, bidi_shelve_cache): Use it.
7516 (bidi_cache_ensure_space): Avoid integer overflow when allocating.
7518 * bidi.c (bidi_cache_shrink):
7519 * buffer.c (overlays_at, overlays_in, record_overlay_string)
7521 Don't update size of array until after memory allocation succeeds,
7522 because xmalloc/xrealloc may not return.
7523 (struct sortstrlist.bytes): Now ptrdiff_t, as EMACS_INT doesn't help
7524 now that we have proper integer overflow checking.
7525 (record_overlay_string, overlay_strings): Catch overflows when
7526 calculating size of overlay_str_buf.
7528 * callproc.c (Fcall_process): Check for size overflow when
7529 calculating size of args2.
7530 (child_setup): Avoid overflow by using size_t rather than ptrdiff_t.
7531 Normally we prefer signed values, but sticking with ptrdiff_t would
7532 require adding more-complicated checks.
7534 * ccl.c (Fccl_execute_on_string): Check for memory overflow.
7535 Use ptrdiff_t rather than EMACS_INT where ptrdiff_t will do.
7536 Redo buffer-overflow calculations to avoid integer overflow.
7537 Add a FIXME comment where memory seems to be over-allocated.
7539 * character.c (Fstring): Check for size-calculation overflow.
7541 * coding.c (produce_chars): Redo buffer-overflow calculations to avoid
7542 unnecessary integer overflow. Check for size overflow.
7543 (encode_coding_object): Don't update size until xmalloc succeeds.
7545 * composite.c (get_composition_id): Check for overflow in glyph
7546 length calculations.
7548 Integer and memory overflow fixes for display code.
7549 * dispextern.h (struct glyph_pool.nglyphs): Now ptrdiff_t, not int.
7550 * dispnew.c (adjust_glyph_matrix, realloc_glyph_pool)
7551 (scrolling_window): Check for overflow in size calculations.
7552 (line_draw_cost, realloc_glyph_pool, add_row_entry):
7553 Don't assume glyph table len fits in int.
7554 (struct row_entry.bucket, row_entry_pool_size, row_entry_idx)
7555 (row_table_size): Now ptrdiff_t, not int.
7556 (scrolling_window): Avoid overflow in size calculations.
7557 Don't update size until allocation succeeds.
7558 * fns.c (concat): Check for overflow in size calculations.
7559 (next_almost_prime): Verify NEXT_ALMOST_PRIME_LIMIT.
7560 * lisp.h (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): New macros.
7561 (NEXT_ALMOST_PRIME_LIMIT): New constant.
7563 * doc.c (get_doc_string_buffer_size): Now ptrdiff_t, not int.
7564 (get_doc_string): Check for size calculation overflow.
7565 Don't update size until allocation succeeds.
7566 (get_doc_string, Fsubstitute_command_keys): Use ptrdiff_t, not
7567 EMACS_INT, where ptrdiff_t will do.
7568 (Fsubstitute_command_keys): Check for string overflow.
7570 * editfns.c (set_time_zone_rule): Don't assume environment length
7572 (message_length): Now ptrdiff_t, not int.
7573 (Fmessage_box): Don't update size until allocation succeeds.
7574 Don't assume message length fits in int.
7575 (Fformat): Use ptrdiff_t, not EMACS_INT, where ptrdiff_t will do.
7577 * emacs.c (main): Do not reallocate argv, since there is a null at
7578 the end that can be overwritten, and this way there's no need to
7579 worry about size-calculation overflow.
7580 (sort_args): Check for size-calculation overflow.
7582 * eval.c (init_eval_once, grow_specpdl): Don't update size until
7584 (call_debugger, grow_specpdl): Redo calculations to avoid overflow.
7586 * frame.c (set_menu_bar_lines, x_set_frame_parameters)
7587 (x_set_scroll_bar_width, x_figure_window_size):
7588 Check for integer overflow.
7589 (x_set_alpha): Do not assume XINT fits in int.
7591 * frame.h (struct frame): Use int, not EMACS_INT, where int works.
7592 This is for the members text_lines, text_cols, total_lines, total_cols,
7593 where the system imposes an 'int' limit.
7595 * fringe.c (Fdefine_fringe_bitmap):
7596 Don't update size until alloc works.
7598 * ftfont.c (ftfont_get_open_type_spec, setup_otf_gstring)
7599 (ftfont_shape_by_flt): Check for integer overflow in size calculations.
7601 * gtkutil.c (get_utf8_string, xg_store_widget_in_map):
7602 Check for size-calculation overflow.
7603 (get_utf8_string): Use ptrdiff_t, not size_t, where either will
7604 do, as we prefer signed integers.
7605 (id_to_widget.max_size, id_to_widget.used)
7606 (xg_store_widget_in_map, xg_remove_widget_from_map)
7607 (xg_get_widget_from_map, xg_get_scroll_id_for_window)
7608 (xg_remove_scroll_bar, xg_update_scrollbar_pos):
7609 Use and return ptrdiff_t, not int.
7610 (xg_gtk_scroll_destroy): Don't assume ptrdiff_t fits in int.
7611 * gtkutil.h: Change prototypes to match the above.
7613 * image.c (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): Remove; these
7614 are duplicate now that they've been promoted to lisp.h.
7615 (x_allocate_bitmap_record, x_alloc_image_color)
7616 (make_image_cache, cache_image, xpm_load):
7617 Don't update size until alloc is done.
7618 (xpm_load, lookup_rgb_color, lookup_pixel_color, x_to_xcolors)
7620 Check for size calculation overflow.
7621 (ct_colors_allocated_max): New constant.
7622 (x_to_xcolors, x_detect_edges): Reorder multiplicands to avoid
7625 * keyboard.c (read_char, menu_bar_items, tool_bar_items)
7626 (read_char_x_menu_prompt, read_char_minibuf_menu_width)
7627 (read_char_minibuf_menu_prompt, follow_key, read_key_sequence):
7628 Use ptrdiff_t, not int, to count maps.
7629 (read_char_minibuf_menu_prompt): Check for overflow in size
7630 calculations. Don't update size until allocation succeeds.
7631 Redo calculations to avoid overflow.
7632 * keyboard.h: Change prototypes to match the above.
7634 * keymap.c (cmm_size, current_minor_maps): Use ptrdiff_t, not int,
7636 (current_minor_maps): Check for size calculation overflow.
7637 * keymap.h: Change prototypes to match the above.
7639 * lread.c (read1, init_obarray): Don't update size until alloc done.
7641 * macros.c (Fstart_kbd_macro): Don't update size until alloc done.
7642 (store_kbd_macro_char): Reorder multiplicands to avoid overflow.
7644 * nsterm.h (struct ns_color_table.size, struct ns_color_table.avail):
7645 Now ptrdiff_t, not int.
7646 * nsterm.m (ns_index_color): Use ptrdiff_t, not int, for table indexes.
7647 (ns_draw_fringe_bitmap): Rewrite to avoid overflow.
7649 * process.c (Fnetwork_interface_list): Check for overflow
7650 in size calculation.
7652 * region-cache.c (move_cache_gap): Check for size calculation overflow.
7654 * scroll.c (do_line_insertion_deletion_costs): Check for size calc
7655 overflow. Don't bother calling xmalloc when xrealloc will do.
7657 * search.c (Freplace_match): Check for size calculation overflow.
7658 (Fset_match_data): Don't assume list lengths fit in 'int'.
7660 * sysdep.c (system_process_attributes): Use ptrdiff_t, not int,
7661 for command line length. Do not attempt to address one before the
7662 beginning of an array, as that's not portable.
7664 * term.c (max_frame_lines): Remove; unused.
7665 (encode_terminal_src_size, encode_terminal_dst_size): Now ptrdiff_t,
7667 (encode_terminal_code, calculate_costs): Check for size
7668 calculation overflow.
7669 (encode_terminal_code): Use ptrdiff_t, not int, to record glyph
7670 table lengths and related sizes. Don't update size until alloc
7671 done. Redo calculations to avoid overflow.
7672 (calculate_costs): Don't bother calling xmalloc when xrealloc will do.
7674 * termcap.c (tgetent): Use ptrdiff_t, not int, to record results of
7675 subtracting pointers.
7676 (gobble_line): Check for overflow more carefully. Don't update size
7679 * tparam.c (tparam1): Use ptrdiff_t, not int, for sizes.
7680 Don't update size until alloc done.
7681 Redo size calculations to avoid overflow.
7682 Check for size calculation overflow.
7683 (main) [DEBUG]: Fix typo in invoking tparam1.
7685 * xdisp.c (store_mode_line_noprop_char, x_consider_frame_title):
7686 Use ptrdiff_t, not int, for sizes.
7687 (store_mode_line_noprop_char): Don't update size until alloc done.
7689 * xfaces.c (lface_id_to_name_size, Finternal_make_lisp_face):
7690 Use ptrdiff_t, not int, for sizes.
7691 (Finternal_make_lisp_face, cache_face):
7692 Check for size calculation overflow.
7693 (cache_face): Treat size calculation overflows as if they were
7694 memory exhaustion (the usual treatment), rather than aborting.
7696 * xfns.c (x_encode_text, x_set_name_internal)
7697 (Fx_change_window_property): Use ptrdiff_t, not int, to count
7698 sizes, since they can exceed INT_MAX in size. Check for size
7699 calculation overflow.
7701 * xgselect.c (gfds_size): Now ptrdiff_t, for convenience with xpalloc.
7702 (xg_select): Check for size calculation overflow.
7703 Don't update size until alloc done.
7705 * xrdb.c (get_environ_db): Don't assume path length fits in int,
7706 as sprintf is limited to int lengths.
7708 * xselect.c (X_LONG_SIZE, X_SHRT_MAX, X_SHRT_MIN, X_LONG_MAX)
7709 (X_LONG_MIN): New macros.
7710 Use them to make the following changes clearer.
7711 (MAX_SELECTION_QUANTUM): Make the other bounds on this value clearer.
7712 This change doesn't affect the value now, but it may help remind
7713 future maintainers not to raise the value too much later.
7714 (SELECTION_QUANTUM): Remove, replacing with ...
7715 (selection_quantum): ... new function, which avoids overflow.
7717 (struct selection_data.size): Now ptrdiff_t, not int, to avoid
7718 assumption that selection length fits in 'int'.
7719 (x_reply_selection_request, x_handle_selection_request)
7720 (x_get_window_property, receive_incremental_selection)
7721 (x_get_window_property_as_lisp_data, selection_data_to_lisp_data)
7722 (lisp_data_to_selection_data, clean_local_selection_data):
7723 Use ptrdiff_t, not int, to record length of selection.
7724 (x_reply_selection_request, x_get_window_property)
7725 (receive_incremental_selection, x_property_data_to_lisp):
7726 Redo calculations to avoid overflow.
7727 (x_reply_selection_request): When sending hint, ceiling it at
7728 X_LONG_MAX rather than relying on wraparound overflow to send
7730 (x_get_window_property, receive_incremental_selection)
7731 (lisp_data_to_selection_data, x_property_data_to_lisp):
7732 Check for size-calculation overflow.
7733 (x_get_window_property, receive_incremental_selection)
7734 (lisp_data_to_selection_data, Fx_register_dnd_atom):
7735 Don't store size until memory allocation succeeds.
7736 (x_get_window_property): Plug memory leak on memory exhaustion.
7737 Don't double-block input; malloc is safe here. Don't assume 2**34
7738 - 4 fits in unsigned long. Add an xassert to check
7739 XGetWindowProperty overflow. Be more careful about overflow
7740 calculations, and distinguish size from memory overflow better.
7741 (receive_incremental_selection): When tracing, don't assume
7742 unsigned int is less than INT_MAX.
7743 (x_selection_data_to_lisp_data): Remove unnecessary (and in theory
7744 harmful) conversions of unsigned short to int.
7745 (lisp_data_to_selection_data): Don't assume that integers
7746 in the range -65535 through -1 fit in an X unsigned short.
7747 Don't assume that ULONG_MAX == X_ULONG_MAX. Don't store into
7748 result parameters unless successful. Rely on cons_to_unsigned
7749 to report problems with elements; the old code wasn't right anyway.
7750 (x_check_property_data): Check for int overflow; we cannot use
7751 a wider type due to X limits.
7752 (x_handle_dnd_message): Use unsigned int, to avoid int overflow.
7754 * xsmfns.c (smc_save_yourself_CB): Check for size calc overflow.
7756 * xterm.c (x_color_cells, x_send_scrollbar_event, handle_one_xevent)
7757 (x_term_init): Check for size calculation overflow.
7758 (x_color_cells): Don't store size until memory allocation succeeds.
7759 (handle_one_xevent): Use ptrdiff_t, not int, for byte counts.
7760 Don't assume alloca size is less than MAX_ALLOCA.
7761 (x_term_init): Don't assume length fits in int (sprintf is limited
7764 Use ptrdiff_t for composition IDs.
7765 * character.c (lisp_string_width):
7766 * composite.c (composition_table_size, n_compositions)
7767 (get_composition_id, composition_gstring_from_id):
7768 * dispextern.h (struct glyph_string.cmp_id, struct composition_it.id):
7769 * xdisp.c (BUILD_COMPOSITE_GLYPH_STRING):
7770 * window.c (Frecenter):
7771 Use ptrdiff_t, not int, for composition IDs.
7772 * composite.c (get_composition_id): Check for integer overflow.
7773 * composite.h: Adjust prototypes to match the above changes.
7775 Use ptrdiff_t for hash table indexes.
7776 * category.c (hash_get_category_set):
7777 * ccl.c (ccl_driver):
7778 * charset.h (struct charset.hash_index, CHECK_CHARSET_GET_ID):
7779 * coding.c (coding_system_charset_list, detect_coding_system):
7780 * coding.h (struct coding_system.id):
7781 * composite.c (get_composition_id, gstring_lookup_cache):
7782 * fns.c (hash_lookup, hash_put, Fgethash, Fputhash):
7783 * image.c (xpm_get_color_table_h):
7784 * lisp.h (hash_lookup, hash_put):
7785 * minibuf.c (Ftest_completion):
7786 Use ptrdiff_t for hash table indexes, not int (which is too
7787 narrow, on 64-bit hosts) or EMACS_INT (which is too wide, on
7788 32-bit --with-wide-int hosts).
7790 * charset.c (Fdefine_charset_internal): Check for integer overflow.
7791 Add a FIXME comment about memory leaks.
7792 (syms_of_charset): Don't assume xmalloc returns.
7794 Don't assume that stated character widths fit in int.
7795 * character.c (Fchar_width, c_string_width, lisp_string_width):
7796 * character.h (CHAR_WIDTH):
7797 * indent.c (MULTIBYTE_BYTES_WIDTH):
7798 Use sanitize_char_width to avoid undefined and/or bad behavior
7799 with outlandish widths.
7800 * character.h (sanitize_tab_width): Rename from sanitize_width,
7801 now that we have two such functions. All uses changed.
7802 (sanitize_char_width): New inline function.
7804 Don't assume that tab-width fits in int.
7805 * character.h (sanitize_width): New inline function.
7806 (SANE_TAB_WIDTH): New macro.
7807 (ASCII_CHAR_WIDTH): Use it.
7808 * indent.c (sane_tab_width): Remove. All uses replaced by
7809 SANE_TAB_WIDTH (current_buffer).
7810 * xdisp.c (init_iterator): Use SANE_TAB_WIDTH.
7812 * fileio.c: Integer overflow issues with file modes.
7813 (Fset_file_modes, auto_save_1): Don't assume EMACS_INT fits in int.
7815 * charset.c (read_hex): New arg OVERFLOW. All uses changed.
7816 Remove unreachable code.
7817 (read_hex, load_charset_map_from_file): Check for integer overflow.
7819 * xterm.c: Don't go over XClientMessageEvent limit.
7820 (scroll_bar_windows_size): Now ptrdiff_t, as we prefer signed.
7821 (x_send_scroll_bar_event): Likewise. Check that the size does not
7822 exceed limits imposed by XClientMessageEvent, as well as the usual
7823 ptrdiff_t and size_t limits.
7825 * keyboard.c: Overflow, signedness and related fixes.
7826 (make_lispy_movement): Use same integer type in forward decl
7827 that is used in the definition.
7828 (read_key_sequence, keyremap_step):
7829 Change bufsize argument back to int, undoing my 2011-03-30 change.
7830 We prefer signed types, and int is wide enough here.
7831 (parse_tool_bar_item): Don't assume tool_bar_max_label_size is less
7832 than TYPE_MAXIMUM (EMACS_INT) / 2. Don't let the label size grow
7833 larger than STRING_BYTES_BOUND. Use ptrdiff_t for Emacs string
7834 length, not size_t. Use ptrdiff_t for index, not int.
7835 (keyremap_step, read_key_sequence): Redo bufsize check to avoid
7836 possibility of integer overflow.
7838 Overflow, signedness and related fixes for images.
7840 * dispextern.h (struct it.stack[0].u.image.image_id)
7841 (struct_it.image_id, struct image.id, struct image_cache.size)
7842 (struct image_cache.used, struct image_cache.ref_count):
7843 * gtkutil.c (update_frame_tool_bar):
7844 * image.c (x_reference_bitmap, Fimage_size, Fimage_mask_p)
7845 (Fimage_metadata, free_image_cache, clear_image_cache, lookup_image)
7846 (cache_image, mark_image_cache, x_kill_gs_process, Flookup_image):
7847 * nsmenu.m (update_frame_tool_bar):
7848 * xdisp.c (calc_pixel_width_or_height):
7849 * xfns.c (image_cache_refcount):
7850 Image IDs are now ptrdiff_t, not int, to avoid arbitrary limits
7851 on typical 64-bit hosts.
7853 * image.c (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): New macros.
7854 (x_bitmap_pixmap, x_create_x_image_and_pixmap):
7855 Omit unnecessary casts to int.
7856 (parse_image_spec): Check that integers fall into 'int' range
7857 when the callers expect that.
7858 (image_ascent): Redo ascent calculation to avoid int overflow.
7859 (clear_image_cache): Avoid overflow when sqrt (INT_MAX) < nimages.
7860 (lookup_image): Remove unnecessary tests.
7861 (xbm_image_p): Locals are now of int, not EMACS_INT,
7862 since parse_image_check makes sure they fit into int.
7863 (png_load, gif_load, svg_load_image):
7864 Prefer int to unsigned where either will do.
7865 (tiff_handler): New function, combining the cores of the
7866 old tiff_error_handler and tiff_warning_handler.
7867 This function is rewritten to use vsnprintf and thereby avoid
7868 stack buffer overflows. It uses only the features of vsnprintf
7869 that are common to both POSIX and native Microsoft.
7870 (tiff_error_handler, tiff_warning_handler): Use it.
7871 (tiff_load, gif_load, imagemagick_load_image):
7872 Don't assume :index value fits in 'int'.
7873 (gif_load): Omit unnecessary cast to double, and avoid double-rounding.
7874 (imagemagick_load_image): Check that crop parameters fit into
7875 the integer types that MagickCropImage accepts. Don't assume
7876 Vimagemagick_render_type has a nonnegative value. Don't assume
7877 size_t fits in 'long'.
7878 (gs_load): Use printmax_t to print the widest integers possible.
7879 Check for integer overflow when computing image height and width.
7881 2011-08-26 Eli Zaretskii <eliz@gnu.org>
7883 * xdisp.c (redisplay_window): Don't force window start if point
7884 will be invisible in the resulting window. (Bug#9324)
7886 2011-08-25 Eli Zaretskii <eliz@gnu.org>
7888 * xdisp.c (compute_display_string_pos): Return 2 in DISP_PROP when
7889 the display spec is of the form `(space ...)'.
7890 (handle_display_spec): Return the value returned by
7891 handle_single_display_spec, not just 1 or zero.
7892 (handle_single_display_spec): If the display spec is of the form
7893 `(space ...)', and specifies display in the text area, return 2
7895 (try_cursor_movement): Check for the need to scroll more
7896 accurately, and prefer exact match for point under bidi.
7897 Don't advance `row' beyond the last row of the window.
7899 * dispextern.h (struct bidi_it): Rename the disp_prop_p member
7900 into disp_prop; all users changed.
7902 * bidi.c (bidi_fetch_char): If compute_display_string_pos returns
7903 DISP_PROP = 2, substitute the u+2029 PARAGRAPH SEPARATOR character
7904 for the text covered by the display property.
7906 2011-08-25 Chong Yidong <cyd@stupidchicken.com>
7908 * buffer.c (Fbury_buffer_internal): Rename from Funrecord_buffer.
7909 Change return value to nil.
7910 (Frecord_buffer): Delete unused function.
7912 2011-08-24 Eli Zaretskii <eliz@gnu.org>
7914 * xdisp.c (Fcurrent_bidi_paragraph_direction): For unibyte
7915 buffers, return left-to-right.
7916 (set_cursor_from_row): Consider candidate row a win if its glyph
7917 represents a newline and point is on that newline. Fixes cursor
7918 positioning on the newline at EOL of R2L text within L2R
7919 paragraph, and vice versa.
7920 (try_cursor_movement): Check continued rows, in addition to
7921 continuation rows. Fixes unwarranted scroll when point enters a
7922 continued line of R2L text within an L2R paragraph, or vice versa.
7923 (cursor_row_p): Consider the case of point being equal to
7924 MATRIX_ROW_END_CHARPOS. Prevents cursor being stuck when moving
7925 from the end of a short line to the beginning of a continued line
7926 of R2L text within L2R paragraph.
7927 (RECORD_MAX_MIN_POS): For max_pos, use IT_CHARPOS even for
7928 composed characters.
7930 * bidi.c (bidi_check_type): Use xassert.
7931 (bidi_cache_iterator_state): Update the disp_pos and disp_prop_p
7934 2011-08-23 Eli Zaretskii <eliz@gnu.org>
7936 * bidi.c (bidi_get_type): Abort if we get zero as the bidi type of
7939 2011-08-23 Chong Yidong <cyd@stupidchicken.com>
7941 * nsfont.m (ns_otf_to_script): Fix typo.
7943 2011-08-22 Kenichi Handa <handa@m17n.org>
7945 * chartab.c (Fset_char_table_extra_slot): Do not inhibit setting a
7946 extra slot even if the purpose is char-code-property-table.
7948 2011-08-23 Eli Zaretskii <eliz@gnu.org>
7950 * xdisp.c (redisplay_window): When computing centering_position,
7951 account for the height of the header line. (Bug#8874)
7953 * dispnew.c (buffer_posn_from_coords): Use buf_charpos_to_bytepos
7954 instead of CHAR_TO_BYTE. Fixes a crash when a completion
7955 candidate is selected by the mouse, and that candidate has a
7956 composed character under the mouse.
7958 * xdisp.c (x_produce_glyphs): Set it->nglyphs to 1. Fixes pixel
7959 coordinates reported by pos-visible-in-window-p for a composed
7960 character in column zero.
7962 2011-08-23 Stefan Monnier <monnier@iro.umontreal.ca>
7964 * cmds.c (Fself_insert_command): Mention post-self-insert-hook.
7966 2011-08-22 Eli Zaretskii <eliz@gnu.org>
7968 * xdisp.c (BUFFER_POS_REACHED_P): If this is a composition,
7969 consider it a hit if to_charpos is anywhere in the range of the
7970 composed buffer positions.
7972 2011-08-22 Chong Yidong <cyd@stupidchicken.com>
7974 * image.c (gif_load): Don't assume that each subimage has the same
7975 dimensions as the base image. Handle disposal method that is
7976 "undefined" by the gif spec (Bug#9335).
7978 2011-08-20 Chong Yidong <cyd@stupidchicken.com>
7980 * eval.c (Fsignal): Handle `debug' symbol in error handler (Bug#9329).
7981 (Fcondition_case): Document `debug' symbol in error handler.
7983 2011-08-19 Eli Zaretskii <eliz@gnu.org>
7985 * xfaces.c (face_at_buffer_position): Avoid repeated evaluation of
7986 face ID by FACE_FROM_ID, and avoid a crash when mouse is moved
7987 from an Org mode buffer to a Speedbar frame.
7989 * xdisp.c (RECORD_MAX_MIN_POS): If the display element comes from
7990 a composition, take its buffer position from IT->cmp_it.charpos.
7991 Fixes cursor positioning at the beginning of a line that begins
7992 with a composed character.
7994 2011-08-18 Eli Zaretskii <eliz@gnu.org>
7996 * bidi.c (bidi_get_type): If bidi_type_table reports zero as the
7997 character bidirectional type, use STRONG_L instead. Fixes crashes
7998 in a buffer produced by `describe-categories'.
8000 * dispextern.h (struct bidi_it): Move disp_pos and disp_prop_p
8001 members before the level stack, so they would be saved and
8002 restored when copying iterator state. Fixes incorrect reordering
8003 around TABs covered by display properties.
8005 2011-08-18 Andreas Schwab <schwab@linux-m68k.org>
8007 * process.c (Fnetwork_interface_list): Correctly determine buffer size.
8009 2011-08-17 Chong Yidong <cyd@stupidchicken.com>
8011 * eval.c (internal_condition_case, internal_condition_case_1)
8012 (internal_condition_case_2, internal_condition_case_n):
8013 Remove unnecessary aborts (Bug#9081).
8015 2011-08-17 Eli Zaretskii <eliz@gnu.org>
8017 * lread.c (Fload) [DOS_NT]: If `openp' returns -2, but the file
8018 has no `load' handler, try opening the file locally. (Bug#9311)
8020 2011-08-16 Ken Brown <kbrown@cornell.edu>
8022 * gmalloc.c: Expand comment.
8024 2011-08-16 Eli Zaretskii <eliz@gnu.org>
8026 * xdisp.c (set_cursor_from_row): Don't accept a previous candidate
8027 if it fails the cursor_row_p test. Fixes cursor positioning at ZV.
8029 2011-08-16 Ken Brown <kbrown@cornell.edu>
8031 Fix memory allocation problems in Cygwin build (Bug#9273).
8033 * unexcw.c ( __malloc_initialized): Declare external variable.
8034 (fixup_executable): Force the dumped emacs to reinitialize malloc.
8036 * gmalloc.c [CYGWIN] (bss_sbrk_heapbase, bss_sbrk_heapinfo):
8038 (malloc_initialize_1) [CYGWIN]: Prepare for reinitializing the
8040 (_free_internal_nolock) [CYGWIN]: Ignore requests to free storage
8042 [CYGWIN] (special_realloc): New function.
8043 (_realloc_internal_nolock) [CYGWIN]: Use the new function on
8044 requests to realloc storage in the static heap.
8046 2011-08-15 Paul Eggert <eggert@cs.ucla.edu>
8048 * bidi.c (bidi_initialize): Remove unused local.
8050 2011-08-15 Eli Zaretskii <eliz@gnu.org>
8053 * biditype.h: Remove file.
8054 * makefile.w32-in ($(BLD)/bidi.$(O)):
8055 * deps.mk (bidi.o): Remove biditype.h and bidimirror.h.
8057 * dispextern.h: Fix a typo in the comment to bidi_type_t.
8059 * chartab.c: Improve commentary for the uniprop_table API.
8061 * bidi.c (bidi_paragraph_init): Support zero value of
8062 bidi_ignore_explicit_marks_for_paragraph_level.
8063 (bidi_initialize): Use uniprop_table instead of including
8064 biditype.h and bidimirror.h.
8066 * xdisp.c (move_it_in_display_line_to): Don't reset pixel
8067 coordinates of the iterator when restoring from ppos_it.
8070 2011-08-14 Kenichi Handa <handa@m17n.org>
8072 * process.c (create_process): Call setup_process_coding_systems
8073 after the pid of the process is set to -1 (Bug#8162).
8075 2011-08-14 Eli Zaretskii <eliz@gnu.org>
8077 * xdisp.c (move_it_in_display_line_to): Don't invoke
8078 IT_RESET_X_ASCENT_DESCENT when iterator position was restored from
8079 ppos_it. Fixes vertical cursor motion when line beginning is
8080 covered by an image. (Bug#9296)
8082 2011-08-14 Jan Djärv <jan.h.d@swipnet.se>
8084 * nsterm.h (ns_run_ascript): Declare.
8085 (NSAPP_DATA2_RUNASSCRIPT): Define.
8087 * nsfns.m (as_script, as_result, as_status): New static variables.
8088 (ns_run_ascript): New function.
8089 (Fns_do_applescript): Set variables as_*. Make an NSApplicationDefined
8090 event with data2 set to NSAPP_DATA2_RUNASSCRIPT, post it and then start
8091 the event loop. Get status from as_status (Bug#7276).
8093 * nsterm.m (sendEvent): If event is NSApplicationDefined and
8094 data2 is NSAPP_DATA2_RUNASSCRIPT, call ns_run_ascript and then exit
8095 the event loop (Bug#7276).
8097 2011-08-14 Andreas Schwab <schwab@linux-m68k.org>
8099 * gnutls.c (QCgnutls_bootprop_priority)
8100 (QCgnutls_bootprop_trustfiles, QCgnutls_bootprop_keylist)
8101 (QCgnutls_bootprop_crlfiles, QCgnutls_bootprop_callbacks)
8102 (QCgnutls_bootprop_loglevel, QCgnutls_bootprop_hostname)
8103 (QCgnutls_bootprop_min_prime_bits, QCgnutls_bootprop_verify_flags)
8104 (QCgnutls_bootprop_verify_hostname_error)
8105 (QCgnutls_bootprop_callbacks_verify): Rename from
8106 Qgnutls_bootprop_..., all uses changed.
8108 * xfaces.c (QCignore_defface): Rename from Qignore_defface, all
8111 2011-08-14 Paul Eggert <eggert@cs.ucla.edu>
8113 * xfaces.c (Qframe_set_background_mode): Now static.
8114 * dispextern.h (Qframe_set_background_mode): Remove decl.
8116 * process.c (Fnetwork_interface_info): Declare local only if needed.
8118 2011-08-13 Jan Djärv <jan.h.d@swipnet.se>
8120 * process.c: Include ifaddrs.h and net/if_dl.h if available (Bug#8477).
8121 (Fnetwork_interface_list): Allocate in increments of bytes instead
8122 of sizeof (struct ifreq). Iterate over ifconf.ifc_req by counting
8123 bytes (Bug#8477). Count bytes correctly when ifr_addr is a struct
8125 (struct ifflag_def): notrailers is smart on OSX.
8126 (Fnetwork_interface_info): Handle case when ifr_flags is negative.
8127 Get hardware address with getifaddrs if available.
8129 2011-08-12 Eli Zaretskii <eliz@gnu.org>
8131 * xdisp.c (iterate_out_of_display_property): xassert that
8132 IT->position is set to within IT->object's boundaries. Break from
8133 the loop as soon as EOB is reached; avoids infloops in redisplay
8134 when IT->position is set up wrongly due to some bug.
8135 Set IT->current to match the bidi iterator unconditionally.
8136 (push_display_prop): Allow GET_FROM_STRING as IT->method on
8137 entry. Force push_it to save on the stack the current
8138 buffer/string position, to be restored by pop_it. Fix flags in
8139 the iterator structure wrt the object coming from a display
8140 property, as `line-prefix' and `wrap-prefix' are not ``replacing''
8141 properties. (Bug#9284)
8143 2011-08-09 Andreas Schwab <schwab@linux-m68k.org>
8145 * fontset.c (fontset_get_font_group): Add proper type checks.
8148 2011-08-09 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
8150 * unexmacosx.c (print_load_command_name): Add cases LC_FUNCTION_STARTS
8151 and LC_VERSION_MIN_MACOSX.
8152 (copy_linkedit_data) [LC_FUNCTION_STARTS]: New function.
8153 (dump_it) [LC_FUNCTION_STARTS]: Use it.
8155 2011-08-08 Eli Zaretskii <eliz@gnu.org>
8157 * xdisp.c (forward_to_next_line_start): Allow to use the
8158 no-display-properties-and-no-overlays under bidi display.
8159 Set disp_pos in the bidi iterator to avoid searches for display
8160 properties and overlays.
8162 2011-08-08 Chong Yidong <cyd@stupidchicken.com>
8164 * editfns.c (Fset_time_zone_rule): Document relationship with the
8167 * ftfont.c (ftfont_pattern_entity): Copy the extras argument to
8168 the font entity extracted from the cache (Bug#8109).
8170 2011-08-07 Chong Yidong <cyd@stupidchicken.com>
8172 * composite.c (autocmp_chars): Don't reset point. That is done by
8173 restore_point_unwind (Bug#5984).
8175 2011-08-07 Juri Linkov <juri@jurta.org>
8177 * editfns.c (Fformat_time_string): Doc fix, add tag `usage:'
8178 to show the arg `TIME' instead of `TIMEVAL'.
8180 2011-08-06 Eli Zaretskii <eliz@gnu.org>
8182 * xdisp.c (set_cursor_from_row): Fix cursor positioning when a
8183 display property strides EOL and includes a newline, as in
8184 longlines-mode. (Bug#9254)
8185 (move_it_in_display_line_to): Fix vertical-motion in a buffer with
8186 word-wrap under bidirectional display. (Bug#9224)
8188 * bidi.c (bidi_unshelve_cache): Don't reset the cache if JUST_FREE
8189 is non-zero, even if the data buffer is NULL. Fixes a crash in
8190 vertical-motion with longlines-mode. (Bug#9254)
8192 2011-08-05 Eli Zaretskii <eliz@gnu.org>
8194 * bidi.c <bidi_cache_total_alloc>: Now static.
8195 (bidi_initialize): Initialize bidi_cache_total_alloc.
8197 * xdisp.c (display_line): Release buffer allocated for shelved bidi
8200 * bidi.c (bidi_shelve_cache, bidi_unshelve_cache): Track total
8201 amount allocated this far in `bidi_cache_total_alloc'.
8202 (bidi_unshelve_cache): Accept an additional argument JUST_FREE; if
8203 non-zero, only free the data buffer without restoring the cache
8204 contents. All callers changed.
8206 * dispextern.h (bidi_unshelve_cache): Update prototype.
8208 * xdisp.c (SAVE_IT, pos_visible_p, move_it_in_display_line_to)
8209 (move_it_in_display_line, move_it_to)
8210 (move_it_vertically_backward, move_it_by_lines): Replace the call
8211 to xfree to an equivalent call to bidi_unshelve_cache.
8212 (move_it_in_display_line_to): Fix logic of returning
8213 MOVE_POS_MATCH_OR_ZV in the bidi case. (Bug#9224)
8215 2011-08-05 Eli Zaretskii <eliz@gnu.org>
8217 * xdisp.c (set_cursor_from_row): Prefer the candidate glyph that
8218 came from a string character with a `cursor' property. (Bug#9229)
8220 2011-08-04 Jan Djärv <jan.h.d@swipnet.se>
8222 * Makefile.in (LIB_PTHREAD): New variable.
8223 (LIBES): Add LIB_PTHREAD (Bug#9216).
8225 * alloc.c, emacs.c, gmalloc.c, gtkutil.c, keyboard.c, syssignal.h:
8226 Rename HAVE_GTK_AND_PTHREAD to HAVE_PTHREAD (Bug#9216).
8228 2011-08-04 Andreas Schwab <schwab@linux-m68k.org>
8230 * regex.c (re_iswctype): Remove some redundant boolean conversions.
8232 2011-08-04 Jan Djärv <jan.h.d@swipnet.se>
8234 * xterm.c (x_find_topmost_parent): New function.
8235 (x_set_frame_alpha): Find topmost parent window with
8236 x_find_topmost_parent and set the property there also (bug#9181).
8237 (handle_one_xevent): Call x_set_frame_alpha on ReparentNotify.
8239 2011-08-04 Paul Eggert <eggert@cs.ucla.edu>
8241 * callproc.c (Fcall_process): Avoid vfork clobbering
8242 the local vars buffer, coding_systems, current_dir.
8244 2011-08-03 Stefan Monnier <monnier@iro.umontreal.ca>
8246 * keymap.c (Fmake_composed_keymap): Move to subr.el.
8248 2011-08-03 Paul Eggert <eggert@cs.ucla.edu>
8250 * fontset.c (dump_fontset) [FONTSET_DEBUG]: Declare EXTERNALLY_VISIBLE
8251 so that it is not optimized away.
8253 * xdisp.c (compute_display_string_pos): Remove unused local.
8255 2011-08-02 Eli Zaretskii <eliz@gnu.org>
8257 Fix slow cursor motion and scrolling in large buffers with
8258 selective display, like Org Mode buffers. (Bug#9218)
8260 * dispextern.h (struct bidi_it): New member disp_prop_p.
8262 * xdisp.c: Remove one-slot cache of display string positions.
8263 (compute_display_string_pos): Accept an additional argument
8264 DISP_PROP_P; callers changed. Scan at most 5K characters forward
8265 for a display string or property. If found, set DISP_PROP_P
8268 * bidi.c (bidi_fetch_char): Accept an additional argument
8269 DISP_PROP_P, and pass it to compute_display_string_pos.
8270 Only handle text covered by a display string if DISP_PROP_P is returned
8271 non-zero. All callers of bidi_fetch_char changed.
8273 2011-08-02 Stefan Monnier <monnier@iro.umontreal.ca>
8275 * keymap.c (Fdefine_key): Fix Lisp_Object/int mixup; apply some CSE.
8277 2010-12-03 Don March <don@ohspite.net>
8279 * keymap.c (Fdefine_key): Fix non-prefix key error message when
8280 last character M-[char] is translated to ESC [char] (bug#7541).
8282 2011-08-02 Kenichi Handa <handa@m17n.org>
8284 * lisp.h (uniprop_table): Extern it.
8286 * chartab.c (uniprop_table): Make it non-static.
8288 2011-08-01 Eli Zaretskii <eliz@gnu.org>
8290 * xdisp.c (forward_to_next_line_start): Accept additional argument
8291 BIDI_IT_PREV, and store into it the state of the bidi iterator had
8293 (reseat_at_next_visible_line_start): Use the bidi iterator state
8294 returned by forward_to_next_line_start to restore the state of
8295 it->bidi_it after backing up to previous newline. (Bug#9212)
8297 2011-07-30 Andreas Schwab <schwab@linux-m68k.org>
8299 * regex.c (re_comp): Protoize.
8300 (re_exec): Fix return type.
8301 (regexec): Fix type of `ret'. (Bug#9203)
8303 2011-07-28 Paul Eggert <eggert@cs.ucla.edu>
8305 * image.c (check_image_size): Use 1024x1024 if unknown frame (Bug#9189).
8306 This is needed if max-image-size is a floating-point number.
8308 2011-07-28 Andreas Schwab <schwab@linux-m68k.org>
8310 * print.c (print_object): Print empty symbol as ##.
8312 * lread.c (read1): Read ## as empty symbol.
8314 2011-07-28 Alp Aker <alp.tekin.aker@gmail.com>
8316 * nsfns.m (x_set_foreground_color): Set f->foreground_pixel when
8317 setting frame foreground color (Bug#9175).
8318 (x_set_background_color): Likewise.
8320 * nsmenu.m (-setText): Size tooltip dimensions precisely to
8321 contents (Bug#9176).
8322 (EmacsTooltip -init): Remove bezels and add shadows to
8325 * nsterm.m (ns_dumpglyphs_stretch): Avoid overwriting left fringe
8326 or scroll bar (Bug#8470).
8328 * nsfont.m (nsfont_open): Remove assignment to voffset and
8329 unnecessary vars hshink, expand, hd, full_height, min_height.
8330 (nsfont_draw): Use s->ybase as baseline for glyph drawing (Bug#8913).
8332 * nsterm.h (nsfont_info): Remove voffset field.
8334 2011-07-28 Alp Aker <alp.tekin.aker@gmail.com>
8336 Implement strike-through and overline on NextStep (Bug#8863).
8338 * nsfont.m (nsfont_open): Use underline position provided by font,
8339 instead of hard-coded value of 2.
8340 (nsfont_draw): Call ns_draw_text_decoration instead.
8342 * nsterm.h: Add declaration for ns_draw_text_decoration.
8344 * nsterm.m (ns_draw_text_decoration): New function for drawing
8345 underline, overline, and strike-through.
8346 (ns_dumpglyphs_image, ns_dumpglyphs_stretch): Add call to
8347 ns_draw_text_decoration. Change treatment of cursor drawing to
8348 accommodate underlining, etc.
8350 2011-07-28 Eli Zaretskii <eliz@gnu.org>
8352 * buffer.c (init_buffer_once): Set bidi-display-reordering to t by
8355 2011-07-28 Paul Eggert <eggert@cs.ucla.edu>
8357 * alloc.c (memory_full) [!SYNC_INPUT]: Fix signal-related race.
8358 Without this fix, if a signal arrives just after memory fills up,
8359 'malloc' might be invoked reentrantly.
8361 * image.c (x_check_image_size) [!HAVE_X_WINDOWS]: Return 1.
8362 In other words, assume that every image size is allowed, on non-X
8363 hosts. This assumption is probably wrong, but it lets Emacs compile.
8365 2011-07-28 Andreas Schwab <schwab@linux-m68k.org>
8367 * regex.c (re_iswctype): Convert return values to boolean.
8369 2011-07-28 Eli Zaretskii <eliz@fencepost.gnu.org>
8371 * xdisp.c (compute_display_string_pos): Don't use cached display
8372 string position if the buffer had its restriction changed.
8375 2011-07-28 Paul Eggert <eggert@cs.ucla.edu>
8377 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
8379 2011-07-28 Paul Eggert <eggert@cs.ucla.edu>
8381 Integer signedness and overflow and related fixes. (Bug#9079)
8383 * bidi.c: Integer size and overflow fixes.
8384 (bidi_cache_size, bidi_cache_idx, bidi_cache_last_idx)
8385 (bidi_cache_start, bidi_cache_fetch_state, bidi_cache_search)
8386 (bidi_cache_find_level_change, bidi_cache_ensure_space)
8387 (bidi_cache_iterator_state, bidi_cache_find, bidi_cache_start_stack)
8388 (bidi_find_other_level_edge):
8389 Use ptrdiff_t instead of EMACS_INT where either will do.
8390 This works better on 32-bit hosts configured --with-wide-int.
8391 (bidi_cache_ensure_space): Check for size-calculation overflow.
8392 Use % rather than repeated addition, for better worst-case speed.
8393 Don't set bidi_cache_size until after xrealloc returns, because it
8395 (bidi_dump_cached_states): Use ptrdiff_t, not int, to avoid overflow.
8396 (bidi_cache_ensure_space): Also check that the bidi cache size
8397 does not exceed that of the largest Lisp string or buffer. See Eli
8398 Zaretskii in <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9079#29>.
8400 * alloc.c (__malloc_size_t): Remove.
8401 All uses replaced by size_t. See Andreas Schwab's note
8402 <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9079#8>.
8404 * image.c: Improve checking for integer overflow.
8405 (check_image_size): Assume that f is nonnull, since
8406 it is always nonnull in practice. This is one less thing to
8407 worry about when checking for integer overflow later.
8408 (x_check_image_size): New function, which checks for integer
8409 overflow issues inside X.
8410 (x_create_x_image_and_pixmap, xbm_read_bitmap_data): Use it.
8411 This removes the need for a memory_full check.
8412 (xbm_image_p): Rewrite to avoid integer multiplication overflow.
8413 (Create_Pixmap_From_Bitmap_Data, xbm_load): Use x_check_image_size.
8414 (xbm_read_bitmap_data): Change locals back to 'int', since
8415 their values must fit in 'int'.
8416 (xpm_load_image, png_load, tiff_load):
8417 Invoke x_create_x_image_and_pixmap earlier,
8418 to avoid much needless work if the image is too large.
8419 (tiff_load): Treat overly large images as if
8420 x_create_x_image_and_pixmap failed, not as malloc failures.
8421 (gs_load): Use x_check_image_size.
8423 * gtkutil.c: Omit integer casts.
8424 (xg_get_pixbuf_from_pixmap): Remove unnecessary cast.
8425 (xg_set_toolkit_scroll_bar_thumb): Rewrite to avoid need for cast.
8427 * image.c (png_load): Don't assume height * row_bytes fits in 'int'.
8429 * xfaces.c (Fbitmap_spec_p): Fix integer overflow bug.
8430 Without this fix, (bitmap-spec-p '(34359738368 1 "x"))
8431 would wrongly return t on a 64-bit host.
8433 * dispnew.c (init_display): Use *_RANGE_OVERFLOW macros.
8434 The plain *_OVERFLOW macros run afoul of GCC bug 49705
8435 <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=49705>
8436 and therefore cause GCC to emit a bogus diagnostic in some cases.
8438 * image.c: Integer signedness and overflow and related fixes.
8439 This is not an exhaustive set of fixes, but it's time to
8440 record what I've got.
8441 (lookup_pixel_color, check_image_size): Remove redundant decls.
8442 (check_image_size): Don't assume that arbitrary EMACS_INT values
8443 fit in 'int', or that arbitrary 'double' values fit in 'int'.
8444 (x_alloc_image_color, x_create_x_image_and_pixmap, png_load)
8445 (tiff_load, imagemagick_load_image):
8446 Check for overflow in size calculations.
8447 (x_create_x_image_and_pixmap): Remove unnecessary test for
8448 xmalloc returning NULL; that can't happen.
8449 (xbm_read_bitmap_data): Don't assume sizes fit into 'int'.
8450 (xpm_color_bucket): Use better integer hashing function.
8451 (xpm_cache_color): Don't possibly over-allocate memory.
8452 (struct png_memory_storage, tiff_memory_source, tiff_seek_in_memory)
8453 (gif_memory_source):
8454 Use ptrdiff_t, not int or size_t, to record sizes.
8455 (png_load): Don't assume values greater than 2**31 fit in 'int'.
8456 (our_stdio_fill_input_buffer): Prefer ptrdiff_t to size_t when
8457 either works, as we prefer signed integers.
8458 (tiff_read_from_memory, tiff_write_from_memory):
8459 Return tsize_t, not size_t, since that's what the TIFF API wants.
8460 (tiff_read_from_memory): Don't fail simply because the read would
8461 go past EOF; instead, return a short read.
8462 (tiff_load): Omit no-longer-needed casts.
8463 (Fimagemagick_types): Don't assume size fits into 'int'.
8465 Improve hashing quality when configured --with-wide-int.
8466 * fns.c (hash_string): New function, taken from sxhash_string.
8467 Do not discard information about ASCII character case; this
8468 discarding is no longer needed.
8469 (sxhash-string): Use it. Change sig to match it. Caller changed.
8470 * lisp.h: Declare it.
8471 * lread.c (hash_string): Remove, since we now use fns.c's version.
8472 The fns.c version returns a wider integer if --with-wide-int is
8473 specified, so this should help the quality of the hashing a bit.
8475 * emacs.c: Integer overflow minor fix.
8476 (heap_bss_diff): Now uprintmax_t, not unsigned long. All used changed.
8477 Define only if GNU_LINUX.
8478 (main, Fdump_emacs): Set and use heap_bss_diff only if GNU_LINUX.
8480 * dispnew.c: Integer signedness and overflow fixes.
8481 Remove unnecessary forward decls, that were a maintenance hassle.
8482 (history_tick): Now uprintmax_t, so it's more likely to avoid overflow.
8484 (adjust_glyph_matrix, realloc_glyph_pool, adjust_frame_message_buffer)
8485 (scrolling_window): Use ptrdiff_t, not int, for byte count.
8486 (prepare_desired_row, line_draw_cost):
8487 Use int, not unsigned, where either works.
8488 (save_current_matrix, restore_current_matrix):
8489 Use ptrdiff_t, not size_t, where either works.
8490 (init_display): Check for overflow more accurately, and without
8491 relying on undefined behavior.
8493 * editfns.c (pWIDE, pWIDElen, signed_wide, unsigned_wide):
8494 Remove, replacing with the new symbols in lisp.h. All uses changed.
8495 * fileio.c (make_temp_name):
8496 * filelock.c (lock_file_1, lock_file):
8497 * xdisp.c (message_dolog):
8498 Don't assume PRIdMAX etc. works; this isn't portable to pre-C99 hosts.
8499 Use pMd etc. instead.
8500 * lisp.h (printmax_t, uprintmax_t, pMd, pMu): New types and macros,
8501 replacing the pWIDE etc. symbols removed from editfns.c.
8503 * keyboard.h (num_input_events): Now uintmax_t.
8504 This is (very slightly) less likely to mess up due to wraparound.
8507 * buffer.c: Integer signedness fixes.
8508 (alloc_buffer_text, enlarge_buffer_text):
8509 Use ptrdiff_t rather than size_t when either will do, as we prefer
8512 * alloc.c: Integer signedness and overflow fixes.
8513 Do not impose an arbitrary 32-bit limit on malloc sizes when debugging.
8514 (__malloc_size_t): Default to size_t, not to int.
8515 (pure_size, pure_bytes_used_before_overflow, stack_copy_size)
8516 (Fgarbage_collect, mark_object_loop_halt, mark_object):
8517 Prefer ptrdiff_t to size_t when either would do, as we prefer
8519 (XMALLOC_OVERRUN_CHECK_OVERHEAD): New macro.
8520 (xmalloc_overrun_check_header, xmalloc_overrun_check_trailer):
8521 Now const. Initialize with values that are in range even if char
8523 (XMALLOC_PUT_SIZE, XMALLOC_GET_SIZE): Remove, replacing with ...
8524 (xmalloc_put_size, xmalloc_get_size): New functions. All uses changed.
8525 These functions do the right thing with sizes > 2**32.
8526 (check_depth): Now ptrdiff_t, not int.
8527 (overrun_check_malloc, overrun_check_realloc, overrun_check_free):
8528 Adjust to new way of storing sizes. Check for size overflow bugs
8530 (STRING_BYTES_MAX): Adjust to new overheads. The old code was
8531 slightly wrong anyway, as it missed one instance of
8532 XMALLOC_OVERRUN_CHECK_OVERHEAD.
8533 (refill_memory_reserve): Omit needless cast to size_t.
8534 (mark_object_loop_halt): Mark as externally visible.
8536 * xselect.c: Integer signedness and overflow fixes.
8537 (Fx_register_dnd_atom, x_handle_dnd_message):
8538 Use ptrdiff_t, not size_t, since we prefer signed.
8539 (Fx_register_dnd_atom): Check for ptrdiff_t (and size_t) overflow.
8540 * xterm.h (struct x_display_info): Use ptrdiff_t, not size_t, for
8541 x_dnd_atoms_size and x_dnd_atoms_length.
8543 * doprnt.c: Prefer signed to unsigned when either works.
8545 * doprnt.c (doprnt):
8547 * xdisp.c (vmessage):
8548 Use ptrdiff_t, not size_t, when using or implementing doprnt,
8549 since the sizes cannot exceed ptrdiff_t bounds anyway, and we
8550 prefer signed arithmetic to avoid comparison confusion.
8551 * doprnt.c (doprnt): Avoid a "+ 1" that can't overflow,
8552 but is a bit tricky.
8554 Assume freestanding C89 headers, string.h, stdlib.h.
8555 * data.c, doprnt.c, floatfns.c, print.c:
8556 Include float.h unconditionally.
8557 * gmalloc.c: Assume C89-at-least behavior for preprocessor,
8558 limits.h, stddef.h, string.h. Use memset instead of 'flood'.
8559 * regex.c: Likewise for stddef.h, string.h.
8560 (ISASCII): Remove; can assume it returns 1 now. All uses removed.
8561 * s/aix4-2.h (HAVE_STRING_H): Remove obsolete undef.
8562 * s/ms-w32.h (HAVE_LIMITS_H, HAVE_STRING_H, HAVE_STDLIB_H)
8563 (STDC_HEADERS): Remove obsolete defines.
8564 * sysdep.c: Include limits.h unconditionally.
8566 Assume support for memcmp, memcpy, memmove, memset.
8567 * lisp.h, sysdep.c (memcmp, memcpy, memmove, memset):
8568 * regex.c (memcmp, memcpy):
8569 Remove; we assume C89 now.
8571 * gmalloc.c (memcpy, memset, memmove): Remove; we assume C89 now.
8572 (__malloc_safe_bcopy): Remove; no longer needed.
8574 * lisp.h (struct vectorlike_header, struct Lisp_Subr): Signed sizes.
8575 Use EMACS_INT, not EMACS_UINT, for sizes. The code works equally
8576 well either way, and we prefer signed to unsigned.
8578 2011-07-27 Lars Magne Ingebrigtsen <larsi@gnus.org>
8580 * gnutls.c (emacs_gnutls_read): Don't message anything if the peer
8581 closes the connection while we're reading (bug#9182).
8583 2011-07-25 Jan Djärv <jan.h.d@swipnet.se>
8585 * nsmenu.m (ns_popup_dialog): Add an "ok" button if no buttons
8586 are specified (Bug#9168).
8588 2011-07-25 Paul Eggert <eggert@cs.ucla.edu>
8590 * bidi.c (bidi_dump_cached_states): Fix printf format mismatch.
8591 Found by GCC static checking and --with-wide-int on a 32-bit host.
8593 2011-07-25 Eli Zaretskii <eliz@gnu.org>
8595 * xdisp.c (compute_display_string_pos): Fix logic of caching
8596 previous display string position. Initialize cached_prev_pos to
8597 -1. Fixes slow-down at the beginning of a buffer.
8599 2011-07-24 Eli Zaretskii <eliz@gnu.org>
8601 * xfaces.c (check_lface_attrs) [HAVE_WINDOW_SYSTEM]: Allow `nil'
8602 for attrs[LFACE_FONTSET_INDEX].
8604 2011-07-23 Paul Eggert <eggert@cs.ucla.edu>
8606 * xml.c (parse_region): Remove unused local
8607 that was recently introduced.
8609 2011-07-23 Eli Zaretskii <eliz@gnu.org>
8611 * xfns.c (unwind_create_frame) [GLYPH_DEBUG]: Adapt to changes in
8612 2008-02-22T17:42:09Z!monnier@iro.umontreal.ca.
8614 * xdisp.c (move_it_in_display_line_to): Record the best matching
8615 position for TO_CHARPOS while scanning the line, and restore it on
8616 exit if none of the characters scanned was an exact match.
8617 Fixes vertical-motion and pos-visible-in-window-p under bidi redisplay
8618 when exact match is impossible due to invisible text, and the
8619 lines are truncated.
8621 2011-07-23 Jan Djärv <jan.h.d@swipnet.se>
8623 * nsterm.m (initFrameFromEmacs): Set NSTitledWindowMask in styleMask
8626 2011-07-22 Eli Zaretskii <eliz@gnu.org>
8628 Fix a significant slow-down of cursor motion with C-n, C-p,
8629 C-f/C-b, and C-v/M-v that couldn't keep up with keyboard
8630 auto-repeat under bidi redisplay in fontified buffers.
8631 * xdisp.c (compute_stop_pos_backwards): New function.
8632 (next_element_from_buffer): Call compute_stop_pos_backwards to
8633 find a suitable prev_stop when we find ourselves before
8635 (reseat): Don't look for prev_stop, as that could mean a very long
8637 <cached_disp_pos, cached_disp_buffer, cached_disp_modiff>
8638 <cached_disp_overlay_modiff>: Cache for last found display string
8640 (compute_display_string_pos): Return the cached position if asked
8641 about the same buffer in the same area of character positions, and
8642 the buffer wasn't changed since the time the display string
8643 position was cached.
8645 2011-07-22 Eli Zaretskii <eliz@gnu.org>
8647 * xdisp.c (rows_from_pos_range): Don't ignore glyphs whose object
8648 is an integer, which is important for empty lines. (Bug#9149)
8650 2011-07-22 Chong Yidong <cyd@stupidchicken.com>
8652 * frame.c (Fmodify_frame_parameters): In tty case, update the
8653 default face if necessary (Bug#4238).
8655 2011-07-21 Chong Yidong <cyd@stupidchicken.com>
8657 * editfns.c (Fstring_to_char): No need to explain what a character
8658 is in the docstring (Bug#6576).
8660 2011-07-20 Lars Magne Ingebrigtsen <larsi@gnus.org>
8662 * xml.c (parse_region): Make sure we always return a tree.
8664 2011-07-20 HAMANO Kiyoto <khiker.mail@gmail.com>
8666 * xml.c (parse_region): If a document contains only comments,
8669 2011-07-20 Lars Magne Ingebrigtsen <larsi@gnus.org>
8671 * xml.c (make_dom): Return comments, too.
8673 2011-07-19 Paul Eggert <eggert@cs.ucla.edu>
8676 See http://lists.gnu.org/archive/html/emacs-devel/2011-07/msg00688.html
8677 and the surrounding thread.
8678 * minibuf.c (read_minibuf_noninteractive): Rewrite to use getchar
8679 rather than fgets, and retry after EINTR. Otherwise, 'emacs
8680 --batch -f byte-compile-file' fails on OpenBSD if an inactivity
8682 * s/openbsd.h (BROKEN_SIGIO): Define.
8683 * unexelf.c (unexec) [__OpenBSD__]:
8684 Don't update the .mdebug section of the Alpha COFF symbol table.
8686 2011-07-19 Lars Magne Ingebrigtsen <larsi@gnus.org>
8688 * lread.c (syms_of_lread): Clarify when `lexical-binding' is used
8691 2011-07-18 Paul Eggert <eggert@cs.ucla.edu>
8693 * fileio.c (Fcopy_file) [!MSDOS]: Tighten created file's mask.
8694 This fixes some race conditions on the permissions of any newly
8697 * alloc.c (valid_pointer_p): Use pipe, not open.
8698 This fixes some permissions issues when debugging.
8700 * fileio.c (Fcopy_file): Adjust mode if fchown fails. (Bug#9002)
8701 If fchown fails to set both uid and gid, try to set just gid,
8702 as that is sometimes allowed. Adjust the file's mode to eliminate
8703 setuid or setgid bits that are inappropriate if fchown fails.
8705 2011-07-18 Stefan Monnier <monnier@iro.umontreal.ca>
8707 * xdisp.c (next_element_from_string, next_element_from_buffer): Use EQ
8708 to compare Lisp_Objects.
8709 * gnutls.c (syms_of_gnutls): Rename Vgnutls_log_level to
8710 global_gnutls_log_level, don't mistake it for a Lisp_Object.
8711 (init_gnutls_functions, emacs_gnutls_handle_error): Fix up uses.
8713 2011-07-17 Andreas Schwab <schwab@linux-m68k.org>
8715 * lread.c (read_integer): Unread even EOF character.
8716 (read1): Likewise. Properly record start position of symbol.
8718 * lread.c (read1): Read `#:' as empty uninterned symbol if no
8719 symbol character follows.
8721 2011-07-17 Paul Eggert <eggert@cs.ucla.edu>
8723 * fileio.c (Fcopy_file): Pacify gcc re fchown. (Bug#9002)
8724 This works around a problem with the previous change to Fcopy_file.
8725 Recent glibc declares fchown with __attribute__((warn_unused_result)),
8726 and without this change, GCC might complain about discarding
8727 fchown's return value.
8729 2011-07-16 Juanma Barranquero <lekktu@gmail.com>
8731 * makefile.w32-in (GLOBAL_SOURCES): Add gnutls.c (followup to bug#9059).
8733 2011-07-16 Paul Eggert <eggert@cs.ucla.edu>
8735 * fileio.c (Fcopy_file): Don't diagnose fchown failures. (Bug#9002)
8737 2011-07-16 Lars Magne Ingebrigtsen <larsi@gnus.org>
8739 * gnutls.c (syms_of_gnutls): Define `gnutls-log-level' here, since
8740 it's used from the C level.
8742 * process.c: Use the same condition for POLL_FOR_INPUT in both
8743 keyboard.c and process.c (bug#1858).
8745 2011-07-09 Lawrence Mitchell <wence@gmx.li>
8747 * gnutls.c (Qgnutls_bootprop_min_prime_bits): New variable.
8748 (Fgnutls_boot): Use it.
8750 2011-07-15 Andreas Schwab <schwab@linux-m68k.org>
8752 * doc.c (Fsubstitute_command_keys): Revert last change.
8754 2011-07-15 Lars Magne Ingebrigtsen <larsi@gnus.org>
8756 * doc.c (Fsubstitute_command_keys): Clarify that \= really only
8757 quotes the next character, and doesn't affect other longer
8758 sequences (bug#8935).
8760 * lread.c (syms_of_lread): Clarify that is isn't only
8761 `eval-buffer' and `eval-defun' that's affected by
8762 `lexical-binding' (bug#8460).
8764 2011-07-15 Eli Zaretskii <eliz@gnu.org>
8766 * xdisp.c (move_it_in_display_line_to): Fix vertical motion with
8767 bidi redisplay when a line includes both an image and is truncated.
8769 2011-07-14 Paul Eggert <eggert@cs.ucla.edu>
8771 Fix minor problems found by static checking.
8772 * bidi.c (bidi_cache_size): Now EMACS_INT, not size_t.
8773 (elsz): Now a signed constant, not a size_t var. We prefer signed
8774 types to unsigned, to avoid integer comparison confusion. Without
8775 this change, GCC 4.6.1 with -Wunsafe-loop-optimizations complains
8776 "cannot optimize loop, the loop counter may overflow", a symptom
8778 * indent.c (Fvertical_motion): Mark locals as initialized.
8779 * xdisp.c (reseat_to_string): Fix pointer signedness issue.
8781 2011-07-14 Lars Magne Ingebrigtsen <larsi@gnus.org>
8783 * search.c (Fre_search_backward): Mention `case-fold-search' in
8784 all the re_search_* functions (bug#8138).
8786 * keyboard.c (Fopen_dribble_file): Document when the file is
8789 2011-07-14 Eli Zaretskii <eliz@gnu.org>
8791 * bidi.c (bidi_dump_cached_states): Fix format of displaying
8794 Support bidi reordering of display and overlay strings.
8795 * xdisp.c (compute_display_string_pos)
8796 (compute_display_string_end): Accept additional argument STRING.
8797 (init_iterator, reseat_1): Initialize bidi_it->string.s to NULL.
8798 (reseat_to_string): Initialize bidi_it->string.s and
8799 bidi_it->string.schars.
8800 (Fcurrent_bidi_paragraph_direction): Initialize itb.string.s to
8801 NULL (avoids a crash in bidi_paragraph_init).
8802 Initialize itb.string.lstring.
8803 (init_iterator): Call bidi_init_it only of a valid
8804 buffer position was specified. Initialize paragraph_embedding to
8806 (reseat_to_string): Initialize the bidi iterator.
8807 (display_string): If we need to ignore text properties of
8808 LISP_STRING, set IT->stop_charpos to IT->end_charpos. (The
8809 original value of -1 will not work with bidi.)
8810 (compute_display_string_pos): First arg is now struct
8811 `text_pos *'; all callers changed. Support display properties on
8813 (compute_display_string_end): Support display properties on Lisp
8815 (init_iterator, reseat_1, reseat_to_string): Initialize the
8816 string.bufpos member to 0 (zero, for compatibility with IT_CHARPOS
8817 when iterating on a string not from display properties).
8818 (compute_display_string_pos, compute_display_string_end):
8819 Fix calculation of the object to scan. Fixes an error when using
8821 (next_element_from_buffer): Don't abort when IT_CHARPOS is before
8822 base_level_stop; instead, set base_level_stop to BEGV.
8823 Fixes crashes in vertical-motion.
8824 (next_element_from_buffer): Improve commentary for when
8825 the iterator is before prev_stop.
8826 (init_iterator): Initialize bidi_p from the default value of
8827 bidi-display-reordering, not from buffer-local value. Use the
8828 buffer-local value only if initializing for buffer iteration.
8829 (handle_invisible_prop): Support invisible properties on strings
8830 that are being bidi-reordered.
8831 (set_iterator_to_next): Support bidi reordering of C strings and
8833 (next_element_from_string): Support bidi reordering of Lisp
8835 (handle_stop_backwards): Support Lisp strings as well.
8836 (display_string): Support display of R2L glyph rows.
8837 Use IT_STRING_CHARPOS when displaying from a Lisp string.
8838 (init_iterator): Don't initialize it->bidi_p for strings
8840 (reseat_to_string): Initialize it->bidi_p for strings here.
8841 (next_element_from_string, next_element_from_c_string)
8842 (next_element_from_buffer): Add xassert's for correspondence
8843 between IT's object being iterated and it->bidi_it.string
8845 (face_before_or_after_it_pos): Support bidi iteration.
8846 (next_element_from_c_string): Handle the case of the first string
8847 character that is not the first one in the visual order.
8848 (get_visually_first_element): New function, refactored from common
8849 parts of next_element_from_buffer, next_element_from_string, and
8850 next_element_from_c_string.
8851 (tool_bar_lines_needed, redisplay_tool_bar)
8852 (display_menu_bar): Force left-to-right direction. Add a FIXME
8853 comment for making that be controlled by a user option.
8854 (push_it, pop_it): Save and restore the state of the
8855 bidi iterator. Save and restore the bidi_p flag.
8856 (pop_it): Iterate out of display property for string iteration as
8858 (iterate_out_of_display_property): Support iteration over strings.
8859 (handle_single_display_spec): Set up it->bidi_it for iteration
8860 over a display string, and call bidi_init_it.
8861 (handle_single_display_spec, next_overlay_string)
8862 (get_overlay_strings_1, push_display_prop): Set up the bidi
8863 iterator for displaying display or overlay strings.
8864 (forward_to_next_line_start): Don't use the shortcut if
8866 (back_to_previous_visible_line_start): If handle_display_prop
8867 pushed the iterator stack, restore the internal state of the bidi
8868 iterator by calling bidi_pop_it same number of times.
8869 (reseat_at_next_visible_line_start): If ON_NEWLINE_P is non-zero,
8870 and we are bidi-iterating, don't decrement the iterator position;
8871 instead, set the first_elt flag in the bidi iterator, to produce
8873 (reseat_1): Remove redundant setting of string_from_display_prop_p.
8874 (push_display_prop): xassert that we are iterating a buffer.
8875 (push_it, pop_it): Save and restore paragraph_embedding member.
8876 (handle_single_display_spec, next_overlay_string)
8877 (get_overlay_strings_1, reseat_1, reseat_to_string)
8878 (push_display_prop): Set up the `unibyte' member of bidi_it.string
8879 correctly. Don't assume unibyte strings are not bidi-reordered.
8880 (compute_display_string_pos)
8881 (compute_display_string_end): Fix handling the case of C string.
8882 (push_it, pop_it): Save and restore from_disp_prop_p.
8883 (handle_single_display_spec, push_display_prop): Set the
8884 from_disp_prop_p flag.
8885 (get_overlay_strings_1): Reset the from_disp_prop_p flag.
8886 (pop_it): Call iterate_out_of_display_property only if we are
8887 popping after iteration over a string that came from a display
8888 property. Fix a typo in popping stretch info. Add an assertion
8889 for verifying that the iterator position is in sync with the bidi
8891 (handle_single_display_spec, get_overlay_strings_1)
8892 (push_display_prop): Fix initialization of paragraph direction for
8893 string when that of the parent object is not yet determined.
8894 (reseat_1): Call bidi_init_it to resync the bidi
8895 iterator with IT's position. (Bug#7616)
8896 (find_row_edges): If ROW->start.pos gives position
8897 smaller than min_pos, use it as ROW->minpos. (Bug#7616)
8898 (handle_stop, back_to_previous_visible_line_start, reseat_1):
8899 Reset the from_disp_prop_p flag.
8900 (SAVE_IT, RESTORE_IT): New macros.
8901 (pos_visible_p, face_before_or_after_it_pos)
8902 (back_to_previous_visible_line_start)
8903 (move_it_in_display_line_to, move_it_in_display_line)
8904 (move_it_to, move_it_vertically_backward, move_it_by_lines)
8905 (try_scrolling, redisplay_window, display_line): Use them when
8906 saving a temporary copy of the iterator and restoring it back.
8907 (back_to_previous_visible_line_start, reseat_1)
8908 (init_iterator): Empty the bidi cache "stack".
8909 (move_it_in_display_line_to): If iterator ended up at
8910 EOL, but we never saw any buffer positions smaller than
8911 to_charpos, return MOVE_POS_MATCH_OR_ZV. Fixes vertical cursor
8912 motion in bidi-reordered lines.
8913 (move_it_in_display_line_to): Record prev_method and prev_pos
8914 immediately before the call to set_iterator_to_next. Fixes cursor
8915 motion in bidi-reordered lines with stretch glyphs and strings
8916 displayed in margins. (Bug#8133) (Bug#8867)
8917 Return MOVE_POS_MATCH_OR_ZV only if iterator position is past
8919 (pos_visible_p): Support positions in bidi-reordered lines.
8920 Save and restore bidi cache.
8922 * bidi.c (bidi_level_of_next_char): clen should be EMACS_NT, not int.
8923 (bidi_paragraph_info): Delete unused struct.
8924 (bidi_cache_idx, bidi_cache_last_idx): Declare EMACS_INT.
8925 (bidi_cache_start): New variable.
8926 (bidi_cache_reset): Reset bidi_cache_idx to bidi_cache_start, not
8928 (bidi_cache_fetch_state, bidi_cache_search)
8929 (bidi_cache_find_level_change, bidi_cache_iterator_state)
8930 (bidi_cache_find, bidi_peek_at_next_level)
8931 (bidi_level_of_next_char, bidi_find_other_level_edge)
8932 (bidi_move_to_visually_next): Compare cache index with
8933 bidi_cache_start rather than with zero.
8934 (bidi_fetch_char): Accept new argument STRING; all callers
8935 changed. Support iteration over a string. Support strings with
8936 display properties. Support unibyte strings. Fix the type of
8937 `len' according to what STRING_CHAR_AND_LENGTH expects.
8938 (bidi_paragraph_init, bidi_resolve_explicit_1)
8939 (bidi_resolve_explicit, bidi_resolve_weak)
8940 (bidi_level_of_next_char, bidi_move_to_visually_next):
8941 Support iteration over a string.
8942 (bidi_set_sor_type, bidi_resolve_explicit_1)
8943 (bidi_resolve_explicit, bidi_type_of_next_char): ignore_bn_limit
8944 can now be zero (for strings); special values 0 and -1 were
8945 changed to -1 and -2, respectively.
8946 (bidi_char_at_pos): New function.
8947 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak):
8948 Call it instead of FETCH_MULTIBYTE_CHAR.
8949 (bidi_move_to_visually_next): Abort if charpos or bytepos were not
8950 initialized to valid values.
8951 (bidi_init_it): Don't initialize charpos and bytepos with invalid
8953 (bidi_level_of_next_char): Allow the sentinel "position" to pass
8954 the test for valid cached positions. Fix the logic for looking up
8955 the sentinel state in the cache. GCPRO the Lisp string we are
8957 (bidi_push_it, bidi_pop_it): New functions.
8958 (bidi_initialize): Initialize the bidi cache start stack pointer.
8959 (bidi_cache_ensure_space): New function, refactored from part of
8960 bidi_cache_iterator_state. Don't assume the required size is just
8961 one BIDI_CACHE_CHUNK away.
8962 (bidi_cache_start_stack, bidi_push_it): Use IT_STACK_SIZE.
8963 (bidi_count_bytes, bidi_char_at_pos): New functions.
8964 (bidi_cache_search): Don't assume bidi_cache_last_idx is
8965 always valid if bidi_cache_idx is valid.
8966 (bidi_cache_find_level_change): xassert that bidi_cache_last_idx
8967 is valid if it's going to be used.
8968 (bidi_shelve_cache, bidi_unshelve_cache): New functions.
8969 (bidi_cache_fetch_state, bidi_cache_search)
8970 (bidi_cache_find_level_change, bidi_cache_ensure_space)
8971 (bidi_cache_iterator_state, bidi_cache_find)
8972 (bidi_find_other_level_edge, bidi_cache_start_stack):
8973 All variables related to cache indices are now EMACS_INT.
8975 * dispextern.h (struct bidi_string_data): New structure.
8976 (struct bidi_it): New member `string'. Make flag members be 1-bit
8977 fields, and put them last in the struct.
8978 (compute_display_string_pos, compute_display_string_end):
8980 (bidi_push_it, bidi_pop_it): Add prototypes.
8981 (struct iterator_stack_entry): New members bidi_p,
8982 paragraph_embedding, and from_disp_prop_p.
8983 (struct it): Member bidi_p is now a bit field 1 bit wide.
8984 (bidi_shelve_cache, bidi_unshelve_cache):
8987 * .gdbinit (xvectype, xvector, xcompiled, xchartable, xboolvector)
8988 (xpr, xfont, xbacktrace): Use "header.size" when accessing vectors
8989 and vector-like objects.
8991 * dispnew.c (buffer_posn_from_coords): Save and restore the bidi
8992 cache around display iteration.
8994 * window.c (Fwindow_end, window_scroll_pixel_based)
8995 (displayed_window_lines, Frecenter): Save and restore the bidi
8996 cache around display iteration.
8998 2011-07-14 Lars Magne Ingebrigtsen <larsi@gnus.org>
9000 * editfns.c (Fdelete_region): Clarify the use of the named
9001 parameters (bug#6788).
9003 2011-07-14 Martin Rudalics <rudalics@gmx.at>
9005 * indent.c (Fvertical_motion): Set and restore w->pointm when
9006 saving and restoring the window's buffer (Bug#9006).
9008 2011-07-13 Lars Magne Ingebrigtsen <larsi@gnus.org>
9010 * editfns.c (Fstring_to_char): Clarify just what is returned
9011 (bug#6576). Text by Eli Zaretskii.
9013 2011-07-13 Juanma Barranquero <lekktu@gmail.com>
9015 * gnutls.c (init_gnutls_functions): Honor gnutls_log_level (bug#9059).
9017 2011-07-13 Eli Zaretskii <eliz@gnu.org>
9019 * buffer.c (mmap_find): Fix a typo.
9021 2011-07-13 Johan Bockgård <bojohan@gnu.org>
9023 Fix execution of x selection hooks.
9024 * xselect.c (Qx_lost_selection_functions)
9025 (Qx_sent_selection_functions): New vars.
9026 (syms_of_xselect): DEFSYM them.
9027 (x_handle_selection_request): Pass Qx_sent_selection_functions
9028 rather than Vx_sent_selection_functions to Frun_hook_with_args.
9029 (x_handle_selection_clear,x_clear_frame_selections):
9030 Pass Qx_lost_selection_functions rather than
9031 Vx_lost_selection_functions to Frun_hook_with_args.
9033 2011-07-13 Paul Eggert <eggert@cs.ucla.edu>
9035 * buffer.c (Fget_buffer_create): Initialize inhibit_shrinking.
9036 The old code sometimes used this field without initializing it.
9038 * alloc.c (gc_sweep): Don't read past end of array.
9039 In theory, the old code could also have corrupted Emacs internals,
9040 though it'd be very unlikely.
9042 2011-07-12 Andreas Schwab <schwab@linux-m68k.org>
9044 * character.c (Fcharacterp): Don't advertise optional ignored
9045 argument. (Bug#4026)
9047 2011-07-12 Lars Magne Ingebrigtsen <larsi@gnus.org>
9049 * keymap.c (syms_of_keymap): Clarify that "modifier" is "modifier
9052 * window.c (Fset_window_start): Doc fix (bug#4199).
9053 (Fset_window_hscroll): Ditto.
9055 2011-07-12 Paul Eggert <eggert@cs.ucla.edu>
9057 Fix minor new problems caught by GCC 4.6.1.
9058 * term.c (init_tty): Remove unused local.
9059 * xsettings.c (store_monospaced_changed): Define this function only
9060 if (defined HAVE_GSETTINGS || defined HAVE_GCONF), as it's
9063 2011-07-12 Chong Yidong <cyd@stupidchicken.com>
9065 * xdisp.c (Vresize_mini_windows): Minor doc fix (Bug#3300).
9067 2011-07-11 Lars Magne Ingebrigtsen <larsi@gnus.org>
9069 * xdisp.c (syms_of_xdisp): Make it explicit that the mini-windows
9070 are the mini-buffer and the echo area (bug#3320).
9072 * term.c (init_tty): Remove support for supdup, c10 and perq
9073 terminals, which are no longer supported (bug#1482).
9075 2011-07-10 Johan Bockgård <bojohan@gnu.org>
9077 * xdisp.c (Ftool_bar_lines_needed): Fix WINDOWP check.
9079 2011-07-10 Jan Djärv <jan.h.d@swipnet.se>
9081 * xmenu.c (menu_highlight_callback): Only pass frame to show_help_event
9082 for non-popups (Bug#3642).
9084 2011-07-10 Andreas Schwab <schwab@linux-m68k.org>
9086 * alloc.c (reset_malloc_hooks): Protoize.
9087 * buffer.c (mmap_init, mmap_find, mmap_free_1, mmap_enlarge)
9088 (mmap_set_vars, mmap_alloc, mmap_free, mmap_realloc): Likewise.
9089 * cm.c (losecursor): Likewise.
9090 * data.c (fmod): Likewise.
9091 * dispnew.c (swap_glyphs_in_rows): Likewise.
9092 * emacs.c (memory_warning_signal): Likewise.
9093 * floatfns.c (float_error): Likewise.
9094 * font.c (check_gstring, check_otf_features, otf_tag_symbol)
9095 (otf_open, font_otf_capability, generate_otf_features)
9096 (font_otf_DeviceTable, font_otf_ValueRecord, font_otf_Anchor):
9098 * image.c (pbm_read_file): Likewise.
9099 * indent.c (string_display_width): Likewise.
9100 * intervals.c (check_for_interval, search_for_interval)
9101 (inc_interval_count, count_intervals, root_interval)
9102 (adjust_intervals_for_insertion, make_new_interval): Likewise.
9103 * lread.c (defalias): Likewise.
9104 * ralloc.c (r_alloc_check): Likewise.
9105 * regex.c (set_image_of_range_1, set_image_of_range)
9106 (regex_grow_registers): Likewise.
9107 * sysdep.c (strerror): Likewise.
9108 * termcap.c (valid_filename_p, tprint, main): Likewise.
9109 * tparam.c (main): Likewise.
9110 * unexhp9k800.c (run_time_remap, save_data_space)
9111 (update_file_ptrs, read_header, write_header, calculate_checksum)
9112 (copy_file, copy_rest, display_header): Likewise.
9113 * widget.c (mark_shell_size_user_specified, create_frame_gcs):
9115 * xdisp.c (check_it): Likewise.
9116 * xfaces.c (register_color, unregister_color, unregister_colors):
9118 * xfns.c (print_fontset_result): Likewise.
9119 * xrdb.c (member, fatal, main): Likewise.
9121 2011-07-10 Paul Eggert <eggert@cs.ucla.edu>
9123 Fix minor problems found by static checking (Bug#9031).
9124 * chartab.c (char_table_set_range, map_sub_char_table):
9125 Remove unused locals.
9126 (uniprop_table): Now static.
9127 * composite.c (_work_char): Remove unused static var.
9129 2011-07-09 Juanma Barranquero <lekktu@gmail.com>
9131 * chartab.c (uniprop_table_uncompress): Remove unused local variable.
9133 2011-07-09 Jan Djärv <jan.h.d@swipnet.se>
9135 * gtkutil.c (qttip_cb): Remove code without function.
9137 2011-07-09 Eli Zaretskii <eliz@gnu.org>
9139 * w32.c (pthread_sigmask): New stub.
9141 2011-07-08 Paul Eggert <eggert@cs.ucla.edu>
9143 Use pthread_sigmask, not sigprocmask (Bug#9010).
9144 sigprocmask is portable only for single-threaded applications, and
9145 Emacs can be multi-threaded when it uses GTK.
9146 * Makefile.in (LIB_PTHREAD_SIGMASK): New macro.
9148 * callproc.c (Fcall_process):
9149 * process.c (create_process):
9150 * sysdep.c (sys_sigblock, sys_sigunblock, sys_sigsetmask):
9151 Use pthread_sigmask, not sigprocmask.
9153 2011-07-08 Jan Djärv <jan.h.d@swipnet.se>
9155 * gtkutil.c (qttip_cb): Set line wrap to FALSE for tooltip widget.
9156 (xg_prepare_tooltip): Revert text in x->ttip_lbl, margins was
9159 2011-07-08 Jan Djärv <jan.h.d@swipnet.se>
9161 * gtkutil.c (xg_prepare_tooltip): Fix indentation and comment.
9162 Put text in x->ttip_lbl instead of gtk_tooltip_set_text (Bug#8591).
9163 (xg_hide_tooltip): Fix comment.
9165 * nsterm.m (initFrameFromEmacs): Don't use ns_return_types
9166 in registerServicesMenuSendTypes.
9167 (validRequestorForSendType): Don't check ns_return_types.
9169 * nsfns.m (Fx_open_connection): Put NSStringPboardType into
9172 2011-07-08 Jason Rumney <jasonr@gnu.org>
9174 * w32term.c (x_make_frame_visible): Use SH_SHOWNORMAL rather than
9175 SH_SHOW for hidden windows (Bug#5482).
9177 * w32fns.c (w32_wnd_proc) [WM_TIMER, WM_SET_CURSOR]: Avoid using
9178 frame struct members of non-existent frames (Bug#6284).
9180 2011-07-08 Jan Djärv <jan.h.d@swipnet.se>
9182 * nsterm.m (keyDown): Call to wantsToDelayTextChangeNotifications and
9183 variable firstTime not needed on OSX >= 10.6.
9184 (setPosition): setFloatValue:knobProportion: is deprecated on OSX
9185 >= 10.5. Use setKnobProportion, setDoubleValue.
9187 * nsterm.h (MAC_OS_X_VERSION_10_3, MAC_OS_X_VERSION_10_4)
9188 (MAC_OS_X_VERSION_10_5): Define if not defined.
9189 (EmacsView, EmacsTooltip): Implements NSWindowDelegate on OSX >= 10.6.
9190 (EmacsMenu): Implements NSMenuDelegate on OSX >= 10.6.
9191 (EmacsToolbar): Implements NSToolbarDelegate on OSX >= 10.6.
9193 * nsselect.m (ns_string_from_pasteboard): Don't use deprecated methods
9194 cString and lossyCString on OSX >= 10.4.
9196 * nsmenu.m (fillWithWidgetValue): Don't use deprecated method
9197 sizeToFit on OSX >= 10.2.
9199 * nsimage.m (allocInitFromFile): Don't use deprecated method
9200 bestRepresentationForDevice on OSX >= 10.6.
9202 * nsfns.m (check_ns_display_info): Cast to long and use %ld in error
9205 * emacs.c: Declare unexec_init_emacs_zone.
9207 * nsgui.h: Fix compiler warning about gnulib redefining verify.
9209 * nsselect.m (ns_get_local_selection): Change to extern (Bug#8842).
9211 * nsmenu.m (ns_update_menubar): Remove useless setDelegate call
9212 on svcsMenu (Bug#8842).
9214 * nsfns.m (Fx_open_connection): Remove NSStringPboardType from
9216 (Fns_list_services): Just return Qnil on 10.6, code not working there.
9218 * nsterm.m (QUTF8_STRING): Declare.
9219 (initFrameFromEmacs): Call registerServicesMenuSendTypes.
9220 (validRequestorForSendType): Return type is (id).
9221 Change indexOfObjectIdenticalTo to indexOfObject.
9222 Check if we have local selection before returning self (Bug#8842).
9223 (writeSelectionToPasteboard): Put local selection into paste board
9224 if we have a local selection (Bug#8842).
9225 (syms_of_nsterm): DEFSYM QUTF8_STRING.
9227 * nsterm.h (MAC_OS_X_VERSION_10_6): Define here instead of nsterm.m.
9228 (ns_get_local_selection): Declare.
9230 2011-07-07 Lars Magne Ingebrigtsen <larsi@gnus.org>
9232 * keymap.c (describe_map_tree): Don't insert a double newline at
9233 the end of the buffer (bug#1169) and return whether we inserted
9236 * callint.c (Fcall_interactively): Change "reading args" to
9237 "providing args" to try to clarify what it does (bug#1010).
9239 2011-07-07 Kenichi Handa <handa@m17n.org>
9241 * composite.c (composition_compute_stop_pos): Ignore a static
9242 composition starting before CHARPOS (Bug#8915).
9244 * xdisp.c (handle_composition_prop): Likewise.
9246 2011-07-07 Eli Zaretskii <eliz@gnu.org>
9248 * term.c (produce_glyphs) <xassert>: Allow IT_GLYPHLESS in it->what.
9251 2011-07-07 Kenichi Handa <handa@m17n.org>
9253 * character.h (unicode_category_t): New enum type.
9255 * chartab.c (uniprop_decoder_t, uniprop_encoder_t): New types.
9256 (Qchar_code_property_table): New variable.
9257 (UNIPROP_TABLE_P, UNIPROP_GET_DECODER)
9258 (UNIPROP_COMPRESSED_FORM_P): New macros.
9259 (char_table_ascii): Uncompress the compressed values.
9260 (sub_char_table_ref): New arg is_uniprop. Callers changed.
9261 Uncompress the compressed values.
9262 (sub_char_table_ref_and_range): Likewise.
9263 (char_table_ref_and_range): Uncompress the compressed values.
9264 (sub_char_table_set): New arg is_uniprop. Callers changed.
9265 Uncompress the compressed values.
9266 (sub_char_table_set_range): Args changed. Callers changed.
9267 (char_table_set_range): Adjuted for the above change.
9268 (map_sub_char_table): Delete args default_val and parent. Add arg
9269 top. Give decoded values to a Lisp function.
9270 (map_char_table): Adjust for the above change. Give decoded
9271 values to a Lisp function. Gcpro more variables.
9272 (uniprop_table_uncompress)
9273 (uniprop_decode_value_run_length): New functions.
9274 (uniprop_decoder, uniprop_decoder_count): New variables.
9275 (uniprop_get_decoder, uniprop_encode_value_character)
9276 (uniprop_encode_value_run_length, uniprop_encode_value_numeric):
9278 (uniprop_encoder, uniprop_encoder_count): New variables.
9279 (uniprop_get_encoder, uniprop_table)
9280 (Funicode_property_table_internal, Fget_unicode_property_internal)
9281 (Fput_unicode_property_internal): New functions.
9282 (syms_of_chartab): DEFSYM Qchar_code_property_table, defsubr
9283 Sunicode_property_table_internal, Sget_unicode_property_internal,
9284 and Sput_unicode_property_internal. Defvar_lisp
9285 char-code-property-alist.
9287 * composite.c (CHAR_COMPOSABLE_P): Adjust for the change of
9288 Vunicode_category_table.
9290 * font.c (font_range): Adjust for the change of
9291 Vunicode_category_table.
9293 2011-07-07 Dan Nicolaescu <dann@ics.uci.edu>
9295 * m/iris4d.h: Remove file, move contents ...
9296 * s/irix6-5.h: ... here.
9298 2011-07-06 Paul Eggert <eggert@cs.ucla.edu>
9300 Remove unportable assumption about struct layout (Bug#8884).
9301 * alloc.c (mark_buffer):
9302 * buffer.c (reset_buffer_local_variables, Fbuffer_local_variables)
9303 (clone_per_buffer_values): Don't assume that
9304 sizeof (struct buffer) is a multiple of sizeof (Lisp_Object).
9305 This isn't true in general, and it's particularly not true
9306 if Emacs is configured with --with-wide-int.
9307 * buffer.h (FIRST_FIELD_PER_BUFFER, LAST_FIELD_PER_BUFFER):
9308 New macros, used in the buffer.c change.
9310 2011-07-05 Jan Djärv <jan.h.d@swipnet.se>
9312 * xsettings.c: Use both GConf and GSettings if both are available.
9313 (store_config_changed_event): Add comment.
9314 (dpyinfo_valid, store_font_name_changed, map_tool_bar_style)
9315 (store_tool_bar_style_changed): New functions.
9316 (store_monospaced_changed): Add comment. Call dpyinfo_valid.
9317 (struct xsettings): Move font inside HAVE_XFT.
9318 (GSETTINGS_TOOL_BAR_STYLE, GSETTINGS_FONT_NAME): New defines.
9319 (GSETTINGS_MONO_FONT): Rename from SYSTEM_MONO_FONT.
9320 Move inside HAVE_XFT.
9321 (something_changed_gsettingsCB): Rename from something_changedCB.
9322 Check for changes in GSETTINGS_TOOL_BAR_STYLE and GSETTINGS_FONT_NAME
9324 (GCONF_TOOL_BAR_STYLE, GCONF_FONT_NAME): New defines.
9325 (GCONF_MONO_FONT): Rename from SYSTEM_MONO_FONT. Move inside HAVE_XFT.
9326 (something_changed_gconfCB): Rename from something_changedCB.
9327 Check for changes in GCONF_TOOL_BAR_STYLE and GCONF_FONT_NAME also.
9328 (parse_settings): Move check for font inside HAVE_XFT.
9329 (read_settings, apply_xft_settings): Add comment.
9330 (read_and_apply_settings): Add comment. Call map_tool_bar_style and
9331 store_tool_bar_style_changed. Move check for font inside HAVE_XFT and
9332 call store_font_name_changed.
9333 (xft_settings_event): Add comment.
9334 (init_gsettings): Add comment. Get values for GSETTINGS_TOOL_BAR_STYLE
9335 and GSETTINGS_FONT_NAME. Move check for fonts within HAVE_XFT.
9336 (init_gconf): Add comment. Get values for GCONF_TOOL_BAR_STYLE
9337 and GCONF_FONT_NAME. Move check for fonts within HAVE_XFT.
9338 (xsettings_initialize): Call init_gsettings last.
9339 (xsettings_get_system_font, xsettings_get_system_normal_font):
9342 2011-07-05 Paul Eggert <eggert@cs.ucla.edu>
9344 Random fixes. E.g., (random) never returned negative values.
9345 * fns.c (Frandom): Use GET_EMACS_TIME for random seed, and add the
9346 subseconds part to the entropy, as that's a bit more random.
9347 Prefer signed to unsigned, since the signedness doesn't matter and
9348 in general we prefer signed. When given a limit, use a
9349 denominator equal to INTMASK + 1, not to VALMASK + 1, because the
9350 latter isn't right if USE_2_TAGS_FOR_INTS.
9351 * sysdep.c (get_random): Return a value in the range 0..INTMASK,
9352 not 0..VALMASK. Don't discard "excess" bits that random () returns.
9354 2011-07-04 Stefan Monnier <monnier@iro.umontreal.ca>
9356 * textprop.c (text_property_stickiness):
9357 Obey Vtext_property_default_nonsticky.
9358 (syms_of_textprop): Add `display' to Vtext_property_default_nonsticky.
9359 * w32fns.c (syms_of_w32fns):
9360 * xfns.c (syms_of_xfns): Don't Add `display' since it's there by default.
9362 2011-07-04 Paul Eggert <eggert@cs.ucla.edu>
9364 * fileio.c (barf_or_query_if_file_exists): Use S_ISDIR.
9365 This is more efficient than Ffile_directory_p and avoids a minor race.
9367 2011-07-04 Lars Magne Ingebrigtsen <larsi@gnus.org>
9369 * buffer.c (Foverlay_put): Say what the return value is
9372 * fileio.c (barf_or_query_if_file_exists): Check first if the file
9373 is a directory before asking whether to use the file name
9375 (barf_or_query_if_file_exists): Make the "File is a directory"
9376 error be more correct.
9378 * fns.c (Frequire): Remove the mention of the .gz files, since
9379 that's installation-specific, but keep the mention of
9380 `get-load-suffixes'.
9382 2011-07-04 Paul Eggert <eggert@cs.ucla.edu>
9384 * editfns.c (Fformat_time_string): Don't assume strlen fits in int.
9385 Report string overflow if the output is too long.
9387 2011-07-04 Juanma Barranquero <lekktu@gmail.com>
9389 * gnutls.c (Fgnutls_boot): Don't mention :verify-error.
9390 (syms_of_gnutls): Remove duplicate DEFSYM for
9391 Qgnutls_bootprop_verify_hostname_error, an error for
9392 Qgnutls_bootprop_verify_error (which is no longer used).
9394 * eval.c (find_handler_clause): Remove parameters `sig' and `data',
9395 unused since 2011-01-26T20:02:07Z!monnier@iro.umontreal.ca. All callers changed.
9396 Also (re)move comments that are misplaced or no longer relevant.
9398 2011-07-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
9400 * callint.c (Finteractive): Clarify the meaning of "@" (bug#8813).
9402 2011-07-03 Chong Yidong <cyd@stupidchicken.com>
9404 * xfaces.c (Finternal_merge_in_global_face): Modify the foreground
9405 and background color parameters if they have been changed.
9407 2011-07-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
9409 * editfns.c (Fformat): Clarify the - and 0 flags (bug#6659).
9411 2011-07-03 Paul Eggert <eggert@cs.ucla.edu>
9413 * xsettings.c (SYSTEM_FONT): Define only when used.
9414 No need to define when HAVE_GSETTINGS || !HAVE_XFT.
9416 * keymap.c (access_keymap_1): Now static.
9418 2011-07-02 Chong Yidong <cyd@stupidchicken.com>
9420 * keyboard.c (command_loop_1): If a down-mouse event is unbound,
9421 leave any prefix arg for the up event (Bug#1586).
9423 2011-07-02 Lars Magne Ingebrigtsen <larsi@gnus.org>
9425 * lread.c (syms_of_lread): Mention single symbols defined by
9426 `defvar' or `defconst' (bug#7154).
9428 * fns.c (Frequire): Mention .el.gz files (bug#7314).
9429 (Frequire): Mention get-load-suffixes.
9431 2011-07-02 Martin Rudalics <rudalics@gmx.at>
9433 * window.h (window): Remove clone_number slot.
9434 * window.c (Fwindow_clone_number, Fset_window_clone_number):
9436 (make_parent_window, make_window, saved_window)
9437 (Fset_window_configuration, save_window_save): Don't deal with
9439 * buffer.c (Qclone_number): Remove declaration.
9440 (sort_overlays, overlay_strings): Don't deal with clone numbers.
9442 2011-07-02 Stefan Monnier <monnier@iro.umontreal.ca>
9444 Add multiple inheritance to keymaps.
9445 * keymap.c (Fmake_composed_keymap): New function.
9446 (Fset_keymap_parent): Simplify.
9447 (fix_submap_inheritance): Remove.
9448 (access_keymap_1): New function extracted from access_keymap to handle
9449 embedded parents and handle lists of maps.
9450 (access_keymap): Use it.
9451 (Fkeymap_prompt, map_keymap_internal, map_keymap, store_in_keymap)
9452 (Fcopy_keymap): Handle embedded parents.
9453 (Fcommand_remapping, define_as_prefix): Simplify.
9454 (Fkey_binding): Simplify.
9455 (syms_of_keymap): Move minibuffer-local-completion-map,
9456 minibuffer-local-filename-completion-map,
9457 minibuffer-local-must-match-map, and
9458 minibuffer-local-filename-must-match-map to Elisp.
9459 (syms_of_keymap): Defsubr make-composed-keymap.
9460 * keyboard.c (menu_bar_items): Use map_keymap_canonical.
9461 (parse_menu_item): Trivial simplification.
9463 2011-07-01 Glenn Morris <rgm@gnu.org>
9465 * Makefile.in (SETTINGS_LIBS): Fix typo.
9467 2011-07-01 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny patch)
9469 * coding.c (Fencode_coding_string): Record the last coding system
9470 used, as the function doc string says (bug#8738).
9472 2011-07-01 Jan Djärv <jan.h.d@swipnet.se>
9474 * xsettings.c (store_monospaced_changed): Take new font as arg and
9475 check for change against current_mono_font.
9476 (EMACS_TYPE_SETTINGS): Remove this and related defines.
9477 (emacs_settings_constructor, emacs_settings_get_property)
9478 (emacs_settings_set_property, emacs_settings_class_init)
9479 (emacs_settings_init, gsettings_obj): Remove.
9480 (something_changedCB): New function for HAVE_GSETTINGS.
9481 (something_changedCB): HAVE_GCONF: Call store_monospaced_changed
9482 with value as argument.
9483 (init_gsettings): Check that GSETTINGS_SCHEMA exists before calling
9484 g_settings_new (Bug#8967). Do not create gsettings_obj.
9485 Remove calls to g_settings_bind. Connect something_changedCB to
9488 * xgselect.c: Add defined (HAVE_GSETTINGS).
9489 (xgselect_initialize): Ditto.
9491 * process.c: Add defined (HAVE_GSETTINGS) for xgselect.h
9492 (wait_reading_process_output): Add defined (HAVE_GSETTINGS) for
9495 2011-07-01 Paul Eggert <eggert@cs.ucla.edu>
9497 * eval.c (struct backtrace): Simplify and port the data structure.
9498 Do not assume that "int nargs : BITS_PER_INT - 2;" produces a
9499 signed bit field, as this assumption is not portable and it makes
9500 Emacs crash when compiled with Sun C 5.8 on sparc. Do not use
9501 "char debug_on_exit : 1" as this is not portable either; instead,
9502 use the portable "unsigned int debug_on_exit : 1". Remove unused
9503 member evalargs. Remove obsolete comments about cc bombing out.
9505 2011-06-30 Jan Djärv <jan.h.d@swipnet.se>
9507 * xsettings.c: Include glib-object.h, gio/gio.h if HAVE_GSETTINGS.
9508 Let HAVE_GSETTINGS override HAVE_GCONF.
9509 (store_monospaced_changed): New function.
9510 (EMACS_SETTINGS): A new type derived from GObject to handle
9511 GSettings notifications.
9512 (emacs_settings_constructor, emacs_settings_get_property)
9513 (emacs_settings_set_property, emacs_settings_class_init):
9515 (gsettings_client, gsettings_obj): New variables.
9516 (GSETTINGS_SCHEMA): New define.
9517 (something_changedCB): Call store_monospaced_changed.
9518 (init_gsettings): New function.
9519 (xsettings_initialize): Call init_gsettings.
9520 (syms_of_xsettings): Initialize gsettings_client, gsettings_obj
9523 * Makefile.in (SETTINGS_CFLAGS, SETTINGS_LIBS): Rename from
9526 2011-06-29 Martin Rudalics <rudalics@gmx.at>
9528 * window.c (resize_root_window, grow_mini_window)
9529 (shrink_mini_window): Rename Qresize_root_window to
9530 Qwindow_resize_root_window and Qresize_root_window_vertically to
9531 Qwindow_resize_root_window_vertically.
9533 2011-06-28 Paul Eggert <eggert@cs.ucla.edu>
9535 * gnutls.c (Qgnutls_bootprop_verify_error): Remove unused var.
9537 2011-06-27 Juanma Barranquero <lekktu@gmail.com>
9539 * makefile.w32-in: Redesign dependencies so they reflect more
9540 clearly which files are directly included by each source file,
9541 and not through other includes.
9543 2011-06-27 Martin Rudalics <rudalics@gmx.at>
9545 * buffer.c (Qclone_number): Declare static and DEFSYM it.
9546 (sort_overlays, overlay_strings): When an overlay's clone number
9547 matches the window's clone number process the overlay even if
9548 the overlay's window property doesn't match the current window.
9550 * window.c (Fwindow_vchild): Rename to Fwindow_top_child.
9551 (Fwindow_hchild): Rename to Fwindow_left_child.
9552 (Fwindow_next): Rename to Fwindow_next_sibling.
9553 (Fwindow_prev): Rename to Fwindow_prev_sibling.
9554 (resize_window_check): Rename to window_resize_check.
9555 (resize_window_apply): Rename to window_resize_apply.
9556 (Fresize_window_apply): Rename to Fwindow_resize_apply.
9557 (Fdelete_other_windows_internal, resize_frame_windows)
9558 (Fsplit_window_internal, Fdelete_window_internal)
9559 (grow_mini_window, shrink_mini_window)
9560 (Fresize_mini_window_internal): Fix callers accordingly.
9562 2011-06-26 Jan Djärv <jan.h.d@swipnet.se>
9564 * emacsgtkfixed.h: State that this is only used with Gtk+3.
9565 (emacs_fixed_set_min_size): Remove.
9566 (emacs_fixed_new): Take frame as argument.
9568 * emacsgtkfixed.c: State that this is only used with Gtk+3.
9569 (_EmacsFixedPrivate): Remove minwidth/height.
9570 Add struct frame *f.
9571 (emacs_fixed_init): Initialize priv->f.
9572 (get_parent_class, emacs_fixed_set_min_size): Remove.
9573 (emacs_fixed_new): Set priv->f to argument.
9574 (emacs_fixed_get_preferred_width)
9575 (emacs_fixed_get_preferred_height): Use min_width/height from
9576 frames size_hint to set minimum and natural (Bug#8919).
9577 (XSetWMSizeHints, XSetWMNormalHints): Override these functions
9578 and use min_width/height from frames size_hint to set
9579 min_width/height (Bug#8919).
9581 * gtkutil.c (xg_create_frame_widgets): Pass f to emacs_fixed_new.
9582 (x_wm_set_size_hint): Remove call to emacs_fixed_set_min_size.
9585 2011-06-26 Eli Zaretskii <eliz@gnu.org>
9587 * bidi.c (bidi_paragraph_init): Test for ZV_BYTE before calling
9588 bidi_at_paragraph_end, since fast_looking_at doesn't like to be
9591 2011-06-26 Chong Yidong <cyd@stupidchicken.com>
9593 * process.c (wait_reading_process_output): Bypass select if
9594 waiting for a cell while ignoring keyboard input, and input is
9595 pending. Suggested by Jan Djärv (Bug#8869).
9597 2011-06-25 Paul Eggert <eggert@cs.ucla.edu>
9599 Use gnulib's dup2 module instead of rolling our own.
9600 * sysdep.c (dup2) [!HAVE_DUP2]: Remove; gnulib now does this.
9602 2011-06-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
9604 * dispnew.c (scrolling_window): Before scrolling, turn off a
9605 mouse-highlight in the window being scrolled.
9607 2011-06-24 Juanma Barranquero <lekktu@gmail.com>
9609 Move DEFSYM to lisp.h and use everywhere.
9611 * character.h (DEFSYM): Move declaration...
9612 * lisp.h (DEFSYM): ...here.
9618 * w32select.c: Don't include character.h.
9620 * alloc.c (syms_of_alloc):
9621 * buffer.c (syms_of_buffer):
9622 * bytecode.c (syms_of_bytecode):
9623 * callint.c (syms_of_callint):
9624 * casefiddle.c (syms_of_casefiddle):
9625 * casetab.c (init_casetab_once):
9626 * category.c (init_category_once, syms_of_category):
9627 * ccl.c (syms_of_ccl):
9628 * cmds.c (syms_of_cmds):
9629 * composite.c (syms_of_composite):
9630 * dbusbind.c (syms_of_dbusbind):
9631 * dired.c (syms_of_dired):
9632 * dispnew.c (syms_of_display):
9633 * doc.c (syms_of_doc):
9634 * editfns.c (syms_of_editfns):
9635 * emacs.c (syms_of_emacs):
9636 * eval.c (syms_of_eval):
9637 * fileio.c (syms_of_fileio):
9638 * fns.c (syms_of_fns):
9639 * frame.c (syms_of_frame):
9640 * fringe.c (syms_of_fringe):
9641 * insdel.c (syms_of_insdel):
9642 * keymap.c (syms_of_keymap):
9643 * lread.c (init_obarray, syms_of_lread):
9644 * macros.c (syms_of_macros):
9645 * msdos.c (syms_of_msdos):
9646 * print.c (syms_of_print):
9647 * process.c (syms_of_process):
9648 * search.c (syms_of_search):
9649 * sound.c (syms_of_sound):
9650 * syntax.c (init_syntax_once, syms_of_syntax):
9651 * terminal.c (syms_of_terminal):
9652 * textprop.c (syms_of_textprop):
9653 * undo.c (syms_of_undo):
9654 * w32.c (globals_of_w32):
9655 * window.c (syms_of_window):
9656 * xdisp.c (syms_of_xdisp):
9657 * xfaces.c (syms_of_xfaces):
9658 * xfns.c (syms_of_xfns):
9659 * xmenu.c (syms_of_xmenu):
9660 * xsettings.c (syms_of_xsettings):
9661 * xterm.c (syms_of_xterm): Use DEFSYM.
9663 2011-06-24 Teodor Zlatanov <tzz@lifelogs.com>
9665 * gnutls.c (syms_of_gnutls): Use the DEFSYM macro from character.h.
9667 2011-06-23 Paul Eggert <eggert@cs.ucla.edu>
9669 Integer and buffer overflow fixes (Bug#8873).
9671 * print.c (printchar, strout): Check for string overflow.
9672 (PRINTPREPARE, printchar, strout):
9673 Don't set size unless allocation succeeds.
9675 * minibuf.c (read_minibuf_noninteractive): Use ptrdiff_t, not int,
9676 for sizes. Check for string overflow more accurately.
9677 Simplify newline removal at end; this suppresses a GCC 4.6.0 warning.
9679 * macros.c: Integer and buffer overflow fixes.
9680 * keyboard.h (struct keyboard.kbd_macro_bufsize):
9681 * macros.c (Fstart_kbd_macro, store_kbd_macro_char):
9682 Use ptrdiff_t, not int, for sizes.
9683 Don't increment bufsize until after realloc succeeds.
9684 Check for size-calculation overflow.
9685 (Fstart_kbd_macro): Use EMACS_INT, not int, for XINT result.
9687 * lisp.h (DEFVAR_KBOARD): Use offsetof instead of char * finagling.
9689 * lread.c: Integer overflow fixes.
9690 (read_integer): Radix is now EMACS_INT, not int,
9691 to improve quality of diagnostics for out-of-range radices.
9692 Calculate buffer size correctly for out-of-range radices.
9693 (read1): Check for integer overflow in radices, and in
9694 read-circle numbers.
9695 (read_escape): Avoid int overflow.
9696 (Fload, openp, read_buffer_size, read1)
9697 (substitute_object_recurse, read_vector, read_list, map_obarray):
9698 Use ptrdiff_t, not int, for sizes.
9699 (read1): Use EMACS_INT, not int, for sizes.
9700 Check for size overflow.
9702 * image.c (cache_image): Check for size arithmetic overflow.
9704 * lread.c: Integer overflow issues.
9705 (saved_doc_string_size, saved_doc_string_length)
9706 (prev_saved_doc_string_size, prev_saved_doc_string_length):
9707 Now ptrdiff_t, not int.
9708 (read1): Don't assume doc string length fits in int. Check for
9709 out-of-range doc string lengths.
9710 (read_list): Don't assume file position fits in int.
9711 (read_escape): Check for hex character overflow.
9713 2011-06-22 Leo Liu <sdl.web@gmail.com>
9715 * minibuf.c (Fcompleting_read_default, Vcompleting_read_function):
9716 Move to minibuffer.el.
9718 2011-06-22 Paul Eggert <eggert@cs.ucla.edu>
9720 Fixes for GLYPH_DEBUG found by GCC 4.6.0 static checking.
9721 The following patches are for when GLYPH_DEBUG && !XASSERT.
9722 * dispextern.h (trace_redisplay_p, dump_glyph_string):
9723 * dispnew.c (flush_stdout):
9724 * xdisp.c (dump_glyph_row, dump_glyph_matrix, dump_glyph):
9725 Mark as externally visible.
9726 * dispnew.c (check_window_matrix_pointers): Now static.
9727 * dispnew.c (window_to_frame_vpos):
9728 * xfns.c (unwind_create_frame):
9729 * xterm.c (x_check_font): Remove unused local.
9730 * scroll.c (CHECK_BOUNDS):
9731 * xfaces.c (cache_fache): Rename local to avoid shadowing.
9732 * xfns.c, w32fns.c (image_cache_refcount, dpyinfo_refcount): Now static.
9733 * xdisp.c (check_window_end): Now a no-op if !XASSERTS.
9734 (debug_first_unchanged_at_end_vpos, debug_last_unchanged_at_beg_vpos)
9735 (debug_dvpos, debug_dy, debug_delta, debug_delta_bytes, debug_end_vpos):
9737 (debug_method_add): Use va_list and vsprintf rather than relying
9738 on undefined behavior with wrong number of arguments.
9739 (dump_glyph, dump_glyph_row, Fdump_glyph_matrix):
9740 Don't assume ptrdiff_t and EMACS_INT are the same width as int.
9741 In this code, it's OK to assume C99 behavior for ptrdiff_t formats
9742 since we're not interested in debugging glyphs with old libraries.
9743 * xfaces.c (cache_face): Move debugging code earlier; this pacifies
9744 GCC 4.6.0's static checking.
9746 2011-06-22 Paul Eggert <eggert@cs.ucla.edu>
9748 Integer overflow and signedness fixes (Bug#8873).
9749 A few related buffer overrun fixes, too.
9751 * font.c (font_score): Use EMACS_INT, not int, to store XINT value.
9753 * dispextern.h (struct face.stipple):
9754 * image.c (x_bitmap_height, x_bitmap_width, x_bitmap_pixmap)
9755 (x_bitmap_mask, x_allocate_bitmap_record)
9756 (x_create_bitmap_from_data, x_create_bitmap_from_file)
9757 (x_destroy_bitmap, x_destroy_all_bitmaps, x_create_bitmap_mask)
9758 (x_create_bitmap_from_xpm_data):
9759 * nsterm.h (struct ns_display_info.bitmaps_size, .bitmaps_last):
9760 * w32term.h (struct w32_display_info.icon_bitmap_id, .bitmaps_size)
9762 * xfaces.c (load_pixmap):
9763 * xterm.c (x_bitmap_icon, x_wm_set_icon_pixmap):
9764 * xterm.h (struct x_display_info.icon_bitmap_id, .bitmaps_size)
9765 (.bitmaps_last, struct x_output.icon_bitmap):
9766 Use ptrdiff_t, not int, for bitmap indexes.
9767 (x_allocate_bitmap_record): Check for size overflow.
9768 * dispextern.h, lisp.h: Adjust to API changes elsewhere.
9770 Use ptrdiff_t, not int, for overlay counts.
9771 * buffer.h (overlays_at, sort_overlays, GET_OVERLAYS_AT):
9772 * editfns.c (overlays_around, get_pos_property):
9773 * textprop.c (get_char_property_and_overlay):
9774 * xdisp.c (next_overlay_change, note_mouse_highlight):
9775 * xfaces.c (face_at_buffer_position):
9776 * buffer.c (OVERLAY_COUNT_MAX): New macro.
9777 (overlays_at, overlays_in, sort_overlays, Foverlays_at)
9778 (Fnext_overlay_change, Fprevious_overlay_change)
9779 (mouse_face_overlay_overlaps, Foverlays_in):
9780 Use ptrdiff_t, not int, for sizes.
9781 (overlays_at, overlays_in): Check for size-calculation overflow.
9783 * xterm.c (xim_initialize, same_x_server): Strlen may not fit in int.
9785 * xsmfns.c (smc_save_yourself_CB, x_session_initialize): Avoid strlen.
9786 (x_session_initialize): Do not assume string length fits in int.
9788 * xsettings.c (apply_xft_settings): Fix potential buffer overrun.
9789 This is unlikely, but can occur if DPI is outlandish.
9791 * xsettings.c (Ffont_get_system_normal_font, Ffont_get_system_font):
9792 * xselect.c (Fx_get_atom_name): Avoid need for strlen.
9794 * xrdb.c: Don't assume strlen fits in int; avoid some strlens.
9795 * xrdb.c (magic_file_p, search_magic_path):
9796 Omit last arg SUFFIX; it was always 0. All callers changed.
9797 (magic_file_p): Use ptrdiff_t, not int. Check for size overflow.
9799 * xfont.c (xfont_match): Avoid need for strlen.
9801 * xfns.c: Don't assume strlen fits in int.
9802 (xic_create_fontsetname, x_window): Use ptrdiff_t, not int.
9804 * xdisp.c (message_log_check_duplicate): Return intmax_t,
9805 not unsigned long, as we prefer signed integers. All callers changed.
9806 Detect integer overflow in repeat count.
9807 (message_dolog): Don't assume print length fits in 39 bytes.
9808 (display_mode_element): Don't assume strlen fits in int.
9810 * termcap.c: Don't assume sizes fit in int and never overflow.
9811 (struct termcap_buffer, tgetent): Use ptrdiff_t, not int, for sizes.
9812 (gobble_line): Check for size-calculation overflow.
9814 * minibuf.c (Fread_buffer):
9815 * lread.c (intern, intern_c_string):
9816 * image.c (xpm_scan) [HAVE_NS && !HAVE_XPM]:
9817 Don't assume string length fits in int.
9819 * keyboard.c (parse_tool_bar_item):
9820 * gtkutil.c (style_changed_cb): Avoid need for strlen.
9822 * font.c: Don't assume string length fits in int.
9823 (font_parse_xlfd, font_parse_fcname, font_unparse_fcname):
9824 Use ptrdiff_t, not int.
9825 (font_intern_prop): Don't assume string length fits in int.
9826 Don't assume integer property fits in fixnum.
9827 * font.h (font_intern_prop): 2nd arg is now ptrdiff_t, not int.
9829 * filelock.c: Fix some buffer overrun and integer overflow issues.
9830 (get_boot_time): Don't assume gzip command string fits in 100 bytes.
9831 Reformulate so as not to need the command string.
9832 Invoke gzip -cd rather than gunzip, as it's more portable.
9833 (lock_info_type, lock_file_1, lock_file):
9834 Don't assume pid_t and time_t fit in unsigned long.
9835 (LOCK_PID_MAX): Remove; we now use more-reliable bounds.
9836 (current_lock_owner): Prefer signed type for sizes.
9837 Use memcpy, not strncpy, where memcpy is what is really wanted.
9838 Don't assume (via atoi) that time_t and pid_t fit in int.
9839 Check for time_t and/or pid_t out of range, e.g., via a network share.
9840 Don't alloca where an auto var works fine.
9842 * fileio.c: Fix some integer overflow issues.
9843 (file_name_as_directory, Fexpand_file_name, Fsubstitute_in_file_name):
9844 Don't assume string length fits in int.
9845 (directory_file_name): Don't assume string length fits in long.
9846 (make_temp_name): Don't assume pid fits in int, or that its print
9847 length is less than 20.
9849 * data.c (Fsubr_name): Rewrite to avoid a strlen call.
9851 * coding.c (make_subsidiaries): Don't assume string length fits in int.
9853 * callproc.c (child_setup): Rewrite to avoid two strlen calls.
9855 * process.c (Fformat_network_address): Use EMACS_INT, not EMACS_UINT.
9856 We prefer signed integers, even for size calculations.
9858 * emacs.c: Don't assume string length fits in 'int'.
9859 (DEFINE_DUMMY_FUNCTION, sort_args): Use ptrdiff_t, not int.
9860 (main): Don't invoke strlen when not needed.
9862 * dbusbind.c (XD_ERROR): Don't arbitrarily truncate string.
9863 (XD_DEBUG_MESSAGE): Don't waste a byte.
9865 * callproc.c (getenv_internal_1, getenv_internal)
9867 * buffer.c (init_buffer): Don't assume string length fits in 'int'.
9869 * lread.c (invalid_syntax): Omit length argument.
9870 All uses changed. This doesn't fix a bug, but it simplifies the
9871 code away from its former Hollerith-constant appearance, and it's
9872 one less 'int' to worry about when looking at integer-overflow issues.
9873 (string_to_number): Simplify 2011-04-26 change by invoking xsignal1.
9875 * lisp.h (DEFUN): Remove bogus use of sizeof (struct Lisp_Subr).
9876 This didn't break anything, but it didn't help either.
9877 It's confusing to put a bogus integer in a place where the actual
9878 value does not matter.
9879 (LIST_END_P): Remove unused macro and its bogus comment.
9880 (make_fixnum_or_float): Remove unnecessary cast to EMACS_INT.
9882 * lisp.h (union Lisp_Object.i): EMACS_INT, not EMACS_UINT.
9883 This is for consistency with the ordinary, non-USE_LISP_UNION_TYPE,
9885 (struct Lisp_Bool_Vector.size): EMACS_INT, not EMACS_UINT.
9886 We prefer signed types, and the value cannot exceed the EMACS_INT
9887 range anyway (because otherwise the length would not be representable).
9888 (XSET) [USE_LISP_UNION_TYPE]: Use uintptr_t and intptr_t,
9889 not EMACS_UINT and EMACS_INT, when converting pointer to integer.
9890 This avoids a GCC warning when WIDE_EMACS_INT.
9892 * indent.c (sane_tab_width): New function.
9893 (current_column, scan_for_column, Findent_to, position_indentation)
9894 (compute_motion): Use it. This is just for clarity.
9895 (Fcompute_motion): Don't assume hscroll and tab offset fit in int.
9897 * image.c (xbm_image_p): Don't assume stated width, height fit in int.
9899 * lisp.h (lint_assume): New macro.
9900 * composite.c (composition_gstring_put_cache):
9901 * ftfont.c (ftfont_shape_by_flt): Use it to pacify GCC 4.6.0.
9903 * editfns.c, insdel.c:
9904 Omit unnecessary forward decls, to simplify future changes.
9906 * ftfont.c (ftfont_shape_by_flt): Use signed integers for lengths.
9908 * font.c (Ffont_shape_gstring): Don't assume glyph len fits in 'int'.
9910 * fns.c (Ffillarray): Don't assume bool vector size fits in 'int'.
9911 Use much-faster test for byte-length change.
9912 Don't assume string byte-length fits in 'int'.
9913 Check that character arg fits in 'int'.
9914 (mapcar1): Declare byte as byte, for clarity.
9916 * alloc.c (Fmake_bool_vector): Avoid unnecessary multiplication.
9918 * fns.c (concat): Catch string overflow earlier.
9919 Do not rely on integer wraparound.
9921 * dispextern.h (struct it.overlay_strings_charpos)
9922 (struct it.selective): Now EMACS_INT, not int.
9923 * xdisp.c (forward_to_next_line_start)
9924 (back_to_previous_visible_line_start)
9925 (reseat_at_next_visible_line_start, next_element_from_buffer):
9926 Don't arbitrarily truncate the value of 'selective' to int.
9928 * xdisp.c (init_iterator): Use XINT, not XFASTINT; it might be < 0.
9930 * composite.c: Don't truncate sizes to 'int'.
9931 (composition_gstring_p, composition_reseat_it)
9932 (composition_adjust_point): Use EMACS_INT, not int.
9933 (get_composition_id, composition_gstring_put_cache): Use EMACS_INT,
9934 not EMACS_UINT, for indexes.
9936 * category.h (CATEGORY_SET_P): Remove unnecessary cast to EMACS_INT.
9938 * buffer.c: Include <verify.h>.
9939 (struct sortvec.priority, struct sortstr.priority):
9940 Now EMACS_INT, not int.
9941 (compare_overlays, cmp_for_strings): Avoid subtraction overflow.
9942 (struct sortstr.size, record_overlay_string)
9943 (struct sortstrlist.size, struct sortlist.used):
9944 Don't truncate size to int.
9945 (record_overlay_string): Check for size-calculation overflow.
9946 (init_buffer_once): Check at compile-time, not run-time.
9948 2011-06-22 Jim Meyering <meyering@redhat.com>
9950 Don't leak an XBM-image-sized buffer
9951 * image.c (xbm_load): Free the image buffer after using it.
9953 2011-06-21 Paul Eggert <eggert@cs.ucla.edu>
9956 * composite.c (find_automatic_composition): Omit needless 'return 0;'
9957 that Sun C diagnosed.
9958 * fns.c (secure_hash): Fix pointer signedness issue.
9959 * intervals.c (static_offset_intervals): New function.
9960 (offset_intervals): Use it.
9962 2011-06-21 Leo Liu <sdl.web@gmail.com>
9965 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha256.h and
9968 * fns.c (secure_hash): Rename from crypto_hash_function and change
9969 the first arg to accept symbols.
9970 (Fsecure_hash): New primitive.
9971 (syms_of_fns): New symbols.
9973 2011-06-20 Deniz Dogan <deniz@dogan.se>
9975 * process.c (Fset_process_buffer): Clarify return value in
9978 2011-06-18 Chong Yidong <cyd@stupidchicken.com>
9980 * dispnew.c (add_window_display_history): Use BVAR.
9982 * xdisp.c (debug_method_add): Use BVAR.
9983 (check_window_end, dump_glyph_matrix, dump_glyph)
9984 (dump_glyph_row, dump_glyph_string): Convert arglist to ANSI C.
9986 * xfaces.c (check_lface_attrs, check_lface, dump_realized_face):
9989 * xfns.c (Fx_create_frame, x_create_tip_frame): Delay image cache
9990 check till after the cache is created in init_frame_faces.
9992 2011-06-17 Stefan Monnier <monnier@iro.umontreal.ca>
9994 * fns.c (Fsafe_length): Yet another int/Lisp_Object mixup.
9996 2011-06-16 Paul Eggert <eggert@cs.ucla.edu>
9998 * lisp.h: Include <limits.h>, for INT_MAX, LONG_MAX, LLONG_MAX.
9999 Without this, prin1 mishandles Lisp_Misc_Save_Value printing on
10000 hosts with pre-C99 libraries, because pD is wrongly defined to "t".
10002 Improve buffer-overflow checking (Bug#8873).
10003 * fileio.c (Finsert_file_contents):
10004 * insdel.c (insert_from_buffer_1, replace_range, replace_range_2):
10005 Remove the old (too-loose) buffer overflow checks.
10006 They weren't needed, since make_gap checks for buffer overflow.
10007 * insdel.c (make_gap_larger): Catch buffer overflows that were missed.
10008 The old code merely checked for Emacs fixnum overflow, and relied
10009 on undefined (wraparound) behavior. The new code avoids undefined
10010 behavior, and also checks for ptrdiff_t and/or size_t overflow.
10012 * editfns.c (Finsert_char): Don't dump core with very negative counts.
10013 Tune. Don't use wider integers than needed. Don't use alloca.
10014 Use a bigger 'string' buffer. Rewrite to avoid 'n > 0' test.
10016 * insdel.c (replace_range): Fix buf overflow when insbytes < outgoing.
10018 * insdel.c, lisp.h (buffer_overflow): New function.
10019 (insert_from_buffer_1, replace_range, replace_range_2):
10020 * insdel.c (make_gap_larger):
10021 * editfns.c (Finsert_char):
10022 * fileio.c (Finsert_file_contents): Use it, to normalize wording.
10024 * buffer.h (BUF_BYTES_MAX): Cast to ptrdiff_t so that it's signed.
10026 2011-06-15 Paul Eggert <eggert@cs.ucla.edu>
10028 Integer overflow and signedness fixes (Bug#8873, Bug#8828).
10030 * ccl.c (ASCENDING_ORDER): New macro, to work around GCC bug 43772.
10031 (GET_CCL_RANGE, IN_INT_RANGE): Use it.
10033 * fileio.c: Don't assume EMACS_INT fits in off_t.
10034 (emacs_lseek): New static function.
10035 (Finsert_file_contents, Fwrite_region): Use it.
10036 Use SEEK_SET, SEEK_CUR, SEEK_END as appropriate.
10038 * fns.c (Fload_average): Don't assume 100 * load average fits in int.
10040 * fns.c: Don't overflow int when computing a list length.
10041 * fns.c (QUIT_COUNT_HEURISTIC): New constant.
10042 (Flength, Fsafe_length): Use EMACS_INT, not int, to avoid unwanted
10043 truncation on 64-bit hosts. Check for QUIT every
10044 QUIT_COUNT_HEURISTIC entries rather than every other entry; that's
10045 faster and is responsive enough.
10046 (Flength): Report an error instead of overflowing an integer.
10047 (Fsafe_length): Return a float if the value is not representable
10048 as a fixnum. This shouldn't happen except in contrived situations.
10049 (Fnthcdr, Fsort): Don't assume list length fits in int.
10050 (Fcopy_sequence): Don't assume vector length fits in int.
10052 * alloc.c: Check that resized vectors' lengths fit in fixnums.
10053 (header_size, word_size): New constants.
10054 (allocate_vectorlike): Don't check size overflow here.
10055 (allocate_vector): Check it here instead, since this is the only
10056 caller of allocate_vectorlike that could cause overflow.
10057 Check that the new vector's length is representable as a fixnum.
10059 * fns.c (next_almost_prime): Don't return a multiple of 3 or 5.
10060 The previous code was bogus. For example, next_almost_prime (32)
10061 returned 39, which is undesirable as it is a multiple of 3; and
10062 next_almost_prime (24) returned 25, which is a multiple of 5 so
10063 why was the code bothering to check for multiples of 7?
10065 * bytecode.c (exec_byte_code): Use ptrdiff_t, not int, for vector length.
10067 * eval.c, doprnt.c (SIZE_MAX): Remove; inttypes.h defines this now.
10069 Variadic C functions now count arguments with ptrdiff_t.
10070 This partly undoes my 2011-03-30 change, which replaced int with size_t.
10071 Back then I didn't know that the Emacs coding style prefers signed int.
10072 Also, in the meantime I found a few more instances where arguments
10073 were being counted with int, which may truncate counts on 64-bit
10074 machines, or EMACS_INT, which may be unnecessarily wide.
10075 * lisp.h (struct Lisp_Subr.function.aMANY)
10076 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call):
10077 Arg counts are now ptrdiff_t, not size_t.
10078 All variadic functions and their callers changed accordingly.
10079 (struct gcpro.nvars): Now size_t, not size_t. All uses changed.
10080 * bytecode.c (exec_byte_code): Check maxdepth for overflow,
10081 to avoid potential buffer overrun. Don't assume arg counts fit in 'int'.
10082 * callint.c (Fcall_interactively): Check arg count for overflow,
10083 to avoid potential buffer overrun. Use signed char, not 'int',
10084 for 'varies' array, so that we needn't bother to check its size
10085 calculation for overflow.
10086 * editfns.c (Fformat): Use ptrdiff_t, not EMACS_INT, to count args.
10087 * eval.c (apply_lambda):
10088 * fns.c (Fmapconcat): Use XFASTINT, not XINT, to get args length.
10089 (struct textprop_rec.argnum): Now ptrdiff_t, not int. All uses changed.
10090 (mapconcat): Use ptrdiff_t, not int and EMACS_INT, to count args.
10092 * callint.c (Fcall_interactively): Don't use index var as event count.
10094 * vm-limit.c (check_memory_limits): Fix incorrect extern function decls.
10095 * mem-limits.h (SIZE): Remove; no longer used.
10097 * xterm.c (x_alloc_nearest_color_1): Prefer int to long when int works.
10099 Remove unnecessary casts.
10100 * xterm.c (x_term_init):
10101 * xfns.c (x_set_border_pixel):
10102 * widget.c (create_frame_gcs): Remove casts to unsigned long etc.
10103 These aren't needed now that we assume ANSI C.
10105 * sound.c (Fplay_sound_internal): Remove cast to unsigned long.
10106 It's more likely to cause problems (due to unsigned overflow)
10109 * dired.c (Ffile_attributes): Don't use 32-bit hack on 64-bit hosts.
10111 * unexelf.c (unexec): Don't assume BSS addr fits in unsigned.
10113 * xterm.c (handle_one_xevent): Omit unnecessary casts to unsigned.
10115 * keyboard.c (modify_event_symbol): Don't limit alist len to UINT_MAX.
10117 * lisp.h (CHAR_TABLE_SET): Omit now-redundant test.
10119 * lread.c (Fload): Don't compare a possibly-garbage time_t value.
10121 GLYPH_CODE_FACE returns EMACS_INT, not int.
10122 * dispextern.h (merge_faces):
10123 * xfaces.c (merge_faces):
10124 * xdisp.c (get_next_display_element, next_element_from_display_vector):
10125 Don't assume EMACS_INT fits in int.
10127 * character.h (CHAR_VALID_P): Remove unused parameter.
10128 * fontset.c, lisp.h, xdisp.c: All uses changed.
10130 * editfns.c (Ftranslate_region_internal): Omit redundant test.
10132 * fns.c (concat): Minor tuning based on overflow analysis.
10133 This doesn't fix any bugs. Use int to hold character, instead
10134 of constantly refetching from Emacs object. Use XFASTINT, not
10135 XINT, for value known to be a character. Don't bother comparing
10136 a single byte to 0400, as it's always less.
10138 * floatfns.c (Fexpt):
10139 * fileio.c (make_temp_name): Omit unnecessary cast to unsigned.
10141 * editfns.c (Ftranslate_region_internal): Use int, not EMACS_INT
10144 * doc.c (get_doc_string): Omit (unsigned)c that mishandled negatives.
10146 * data.c (Faset): If ARRAY is a string, check that NEWELT is a char.
10147 Without this fix, on a 64-bit host (aset S 0 4294967386) would
10148 incorrectly succeed when S was a string, because 4294967386 was
10149 truncated before it was used.
10151 * chartab.c (Fchar_table_range): Use CHARACTERP to check range.
10152 Otherwise, an out-of-range integer could cause undefined behavior
10155 * composite.c: Use int, not EMACS_INT, for characters.
10156 (fill_gstring_body, composition_compute_stop_pos): Use int, not
10157 EMACS_INT, for values that are known to be in character range.
10158 This doesn't fix any bugs but is the usual style inside Emacs and
10159 may generate better code on 32-bit machines.
10161 Make sure a 64-bit char is never passed to ENCODE_CHAR.
10162 This is for reasons similar to the recent CHAR_STRING fix.
10163 * charset.c (Fencode_char): Check that character arg is actually
10164 a character. Pass an int to ENCODE_CHAR.
10165 * charset.h (ENCODE_CHAR): Verify that the character argument is no
10166 wider than 'int', as a compile-time check to prevent future regressions
10169 * character.c (char_string): Remove unnecessary casts.
10171 Make sure a 64-bit char is never passed to CHAR_STRING.
10172 Otherwise, CHAR_STRING would do the wrong thing on a 64-bit platform,
10173 by silently ignoring the top 32 bits, allowing some values
10174 that were far too large to be valid characters.
10175 * character.h: Include <verify.h>.
10176 (CHAR_STRING, CHAR_STRING_ADVANCE): Verify that the character
10177 arguments are no wider than unsigned, as a compile-time check
10178 to prevent future regressions in this area.
10180 * editfns.c (Fchar_to_string, general_insert_function, Finsert_char)
10181 (Fsubst_char_in_region):
10183 * xdisp.c (decode_mode_spec_coding):
10184 Adjust to CHAR_STRING's new requirement.
10185 * editfns.c (Finsert_char, Fsubst_char_in_region):
10186 * fns.c (concat): Check that character args are actually
10187 characters. Without this test, these functions did the wrong
10188 thing with wildly out-of-range values on 64-bit hosts.
10190 Remove incorrect casts to 'unsigned' that lose info on 64-bit hosts.
10191 These casts should not be needed on 32-bit hosts, either.
10192 * keyboard.c (read_char):
10193 * lread.c (Fload): Remove casts to unsigned.
10195 * lisp.h (UNSIGNED_CMP): New macro.
10196 This fixes comparison bugs on 64-bit hosts.
10197 (ASCII_CHAR_P): Use it.
10198 * casefiddle.c (casify_object):
10199 * character.h (ASCII_BYTE_P, CHAR_VALID_P)
10200 (SINGLE_BYTE_CHAR_P, CHAR_STRING):
10201 * composite.h (COMPOSITION_ENCODE_RULE_VALID):
10202 * dispextern.h (FACE_FROM_ID):
10203 * keyboard.c (read_char): Use UNSIGNED_CMP.
10205 * xmenu.c (dialog_selection_callback) [!USE_GTK]: Cast to intptr_t,
10206 not to EMACS_INT, to avoid GCC warning.
10208 * xfns.c (x_set_scroll_bar_default_width): Remove unused 'int' locals.
10210 * buffer.h (PTR_BYTE_POS, BUF_PTR_BYTE_POS): Remove harmful cast.
10211 The cast incorrectly truncated 64-bit byte offsets to 32 bits, and
10212 isn't needed on 32-bit machines.
10214 * buffer.c (Fgenerate_new_buffer_name):
10215 Use EMACS_INT for count, not int.
10216 (advance_to_char_boundary): Return EMACS_INT, not int.
10218 * data.c (Qcompiled_function): Now static.
10220 * window.c (window_body_lines): Now static.
10222 * image.c (gif_load): Rename local to avoid shadowing.
10224 * lisp.h (SAFE_ALLOCA_LISP): Check for integer overflow.
10225 (struct Lisp_Save_Value): Use ptrdiff_t, not int, for 'integer' member.
10226 * alloc.c (make_save_value): Integer argument is now of type
10227 ptrdiff_t, not int.
10228 (mark_object): Use ptrdiff_t, not int.
10229 * lisp.h (pD): New macro.
10230 * print.c (print_object): Use it.
10232 * alloc.c: Use EMACS_INT, not int, to count objects.
10233 (total_conses, total_markers, total_symbols, total_vector_size)
10234 (total_free_conses, total_free_markers, total_free_symbols)
10235 (total_free_floats, total_floats, total_free_intervals)
10236 (total_intervals, total_strings, total_free_strings):
10237 Now EMACS_INT, not int. All uses changed.
10238 (Fgarbage_collect): Compute overall total using a double, so that
10239 integer overflow is less likely to be a problem. Check for overflow
10240 when converting back to an integer.
10241 (n_interval_blocks, n_string_blocks, n_float_blocks, n_cons_blocks)
10242 (n_vectors, n_symbol_blocks, n_marker_blocks): Remove.
10243 These were 'int' variables that could overflow on 64-bit hosts;
10244 they were never used, so remove them instead of repairing them.
10245 (nzombies, ngcs, max_live, max_zombies): Now EMACS_INT, not 'int'.
10246 (inhibit_garbage_collection): Set gc_cons_threshold to max value.
10247 Previously, this ceilinged at INT_MAX, but that doesn't work on
10249 (allocate_pseudovector): Don't use EMACS_INT when int would do.
10251 * alloc.c (Fmake_bool_vector): Don't assume vector size fits in int.
10252 (allocate_vectorlike): Check for ptrdiff_t overflow.
10253 (mark_vectorlike, mark_char_table, mark_object): Avoid EMACS_UINT
10254 when a (possibly-narrower) signed value would do just as well.
10255 We prefer using signed arithmetic, to avoid comparison confusion.
10257 * alloc.c: Catch some string size overflows that we were missing.
10258 (XMALLOC_OVERRUN_CHECK_SIZE) [!XMALLOC_OVERRUN_CHECK]: Define to 0,
10259 for convenience in STRING_BYTES_MAX.
10260 (STRING_BYTES_MAX): New macro, superseding the old one in lisp.h.
10261 The definition here is exact; the one in lisp.h was approximate.
10262 (allocate_string_data): Check for string overflow. This catches
10263 some instances we weren't catching before. Also, it catches
10264 size_t overflow on (unusual) hosts where SIZE_MAX <= min
10265 (PTRDIFF_MAX, MOST_POSITIVE_FIXNUM), e.g., when size_t is 32 bits
10266 and ptrdiff_t and EMACS_INT are both 64 bits.
10268 * character.c, coding.c, doprnt.c, editfns.c, eval.c:
10269 All uses of STRING_BYTES_MAX replaced by STRING_BYTES_BOUND.
10270 * lisp.h (STRING_BYTES_BOUND): Rename from STRING_BYTES_MAX.
10272 * character.c (string_escape_byte8): Fix nbytes/nchars typo.
10274 * alloc.c (Fmake_string): Check for out-of-range init.
10276 2011-06-15 Stefan Monnier <monnier@iro.umontreal.ca>
10278 * eval.c (Fdefvaralias): Also mark the target as variable-special-p.
10280 2011-06-14 Jan Djärv <jan.h.d@swipnet.se>
10282 * xfns.c (x_set_scroll_bar_default_width): Remove argument to
10283 xg_get_default_scrollbar_width.
10285 * gtkutil.c: Include emacsgtkfixed.h if HAVE_GTK3.
10286 (int_gtk_range_get_value): Move to the scroll bar part of the file.
10287 (style_changed_cb): Call update_theme_scrollbar_width and call
10288 x_set_scroll_bar_default_width and xg_frame_set_char_size for
10289 all frames (Bug#8505).
10290 (xg_create_frame_widgets): Call emacs_fixed_new if HAVE_GTK3 (Bug#8505).
10291 Call gtk_window_set_resizable if HAVE_GTK3.
10292 (x_wm_set_size_hint): Call emacs_fixed_set_min_size with min width
10293 and height if HAVE_GTK3 (Bug#8505).
10294 (scroll_bar_width_for_theme): New variable.
10295 (update_theme_scrollbar_width): New function.
10296 (xg_get_default_scrollbar_width): Move code to
10297 update_theme_scrollbar_width, just return scroll_bar_width_for_theme.
10298 (xg_initialize): Call update_theme_scrollbar_width.
10300 * gtkutil.h (xg_get_default_scrollbar_width): Remove argument.
10302 * emacsgtkfixed.c, emacsgtkfixed.h: New files.
10304 2011-06-12 Martin Rudalics <rudalics@gmx.at>
10306 * frame.c (make_frame): Call other_buffer_safely instead of
10309 * window.c (temp_output_buffer_show): Call display_buffer with
10310 second argument Vtemp_buffer_show_specifiers and reset latter
10311 immediately after the call.
10312 (Vtemp_buffer_show_specifiers): New variable.
10313 (auto_window_vscroll_p, next_screen_context_lines)
10314 (Vscroll_preserve_screen_position): Remove leading asterisks from
10317 2011-06-12 Paul Eggert <eggert@cs.ucla.edu>
10319 Fix minor problems found by GCC 4.6.0 static checking.
10320 * buffer.c (Qclone_number): Remove for now, as it's unused.
10321 (record_buffer, Funrecord_buffer): Rename local to avoid shadowing.
10322 (record_buffer): Remove unused local.
10323 * frame.c (other_visible_frames, frame_buffer_list): Now static.
10324 (set_frame_buffer_list): Remove; unused.
10325 * frame.h (other_visible_frames): Remove decl.
10326 * keyboard.h (menu_items_inuse): Declare only if USE_GTK || USE_MOTIF.
10327 * lisp.h (frame_buffer_list, set_frame_buffer_list): Remove decls.
10328 (add_gpm_wait_descriptor, delete_gpm_wait_descriptor): Declare only
10330 * menu.c (menu_items_inuse): Now static unless USE_GTK || USE_MOTIF.
10331 * process.c (add_gpm_wait_descriptor, delete_gpm_wait_descriptor):
10332 Define only if HAVE_GPM.
10333 * widget.c (EmacsFrameResize, emacsFrameClassRec): Now static.
10334 (update_hints_inhibit): Remove; never set. All uses removed.
10335 * widgetprv.h (emacsFrameClassRec): Remove decl.
10336 * window.c (delete_deletable_window): Now returns void, since it
10337 wasn't returning anything.
10338 (compare_window_configurations): Remove unused locals.
10339 * xfns.c (x_set_scroll_bar_default_width): Remove unused locals.
10340 * xmenu.c (x_menu_set_in_use): Define only if USE_GTK || USE_MOTIF.
10341 (dialog_selection_callback) [!USE_GTK]: Prefer intptr_t for integers
10342 the same widths as pointers. This follows up on the 2011-05-06 patch.
10343 * xterm.c (x_alloc_lighter_color_for_widget): Define only if USE_LUCID.
10344 * xterm.h: Likewise.
10345 (x_menu_set_in_use): Declare only if USE_GTK || USE_MOTIF.
10347 2011-06-12 Juanma Barranquero <lekktu@gmail.com>
10349 * makefile.w32-in: Update dependencies.
10350 (LISP_H): Add lib/intprops.h.
10352 2011-06-11 Chong Yidong <cyd@stupidchicken.com>
10354 * image.c (gif_load): Add animation frame delay to the metadata.
10355 (syms_of_image): Use DEFSYM. New symbol `delay'.
10357 2011-06-11 Martin Rudalics <rudalics@gmx.at>
10359 * window.c (delete_deletable_window): Re-add.
10360 (Fset_window_configuration): Rewrite to handle dead buffers and
10361 consequently deletable windows.
10362 (window_tree, Fwindow_tree): Remove. Supply functionality in
10364 (compare_window_configurations): Simplify code.
10366 2011-06-11 Andreas Schwab <schwab@linux-m68k.org>
10368 * image.c (imagemagick_load_image): Fix type mismatch.
10369 (Fimagemagick_types): Likewise.
10371 * window.h (replace_buffer_in_windows): Declare.
10373 2011-06-11 Martin Rudalics <rudalics@gmx.at>
10375 * buffer.c: New Lisp objects Qbuffer_list_update_hook and
10376 Qclone_number. Remove external declaration of Qdelete_window.
10377 (Fbuffer_list): Rewrite doc-string. Minor restructuring of
10379 (Fget_buffer_create, Fmake_indirect_buffer, Frename_buffer):
10380 Run Qbuffer_list_update_hook if allowed.
10381 (Fother_buffer): Rewrite doc-string. Major rewrite for new
10382 buffer list implementation.
10383 (other_buffer_safely): New function.
10384 (Fkill_buffer): Replace call to replace_buffer_in_all_windows by
10385 calls to replace_buffer_in_windows and
10386 replace_buffer_in_windows_safely. Run Qbuffer_list_update_hook
10388 (record_buffer): Inhibit quitting and rewrite using quittable
10389 functions. Run Qbuffer_list_update_hook if allowed.
10390 (Frecord_buffer, Funrecord_buffer): New functions.
10391 (switch_to_buffer_1, Fswitch_to_buffer): Remove.
10392 Move switch-to-buffer to window.el.
10393 (bury-buffer): Move to window.el.
10394 (Vbuffer_list_update_hook): New variable.
10396 * lisp.h (other_buffer_safely): Add prototype in buffer.c
10399 * window.h (resize_frame_windows): Move up in code.
10400 (Fwindow_frame): Remove EXFUN.
10401 (replace_buffer_in_all_windows): Remove prototype.
10402 (replace_buffer_in_windows_safely): Add prototype.
10404 * window.c: Declare Qdelete_window static again. Move down
10405 declaration of select_count.
10406 (Fnext_window, Fprevious_window): Rewrite doc-strings.
10407 (Fother_window): Move to window.el.
10408 (window_loop): Remove DELETE_BUFFER_WINDOWS and UNSHOW_BUFFER
10409 cases. Add REPLACE_BUFFER_IN_WINDOWS_SAFELY case.
10410 (Fdelete_windows_on, Freplace_buffer_in_windows): Move to
10412 (replace_buffer_in_windows): Implement by calling
10413 Qreplace_buffer_in_windows.
10414 (replace_buffer_in_all_windows): Remove with some functionality
10415 moved into replace_buffer_in_windows_safely.
10416 (replace_buffer_in_windows_safely): New function.
10417 (select_window_norecord, select_frame_norecord): Move in front
10418 of run_window_configuration_change_hook. Remove now obsolete
10420 (Fset_window_buffer): Rewrite doc-string.
10421 Call Qrecord_window_buffer.
10422 (keys_of_window): Move binding for other-window to window.el.
10424 2011-06-11 Chong Yidong <cyd@stupidchicken.com>
10426 * dispextern.h (struct image): Replace data member, whose int_val
10427 and ptr_val fields were not used by anything, with a single
10430 * image.c (Fimage_metadata, make_image, mark_image, tiff_load)
10431 (gif_clear_image, gif_load, imagemagick_load_image)
10432 (gs_clear_image, gs_load): Callers changed.
10434 2011-06-10 Paul Eggert <eggert@cs.ucla.edu>
10436 * buffer.h: Include <time.h>, for time_t.
10437 Needed to build on FreeBSD 8.2. Problem reported by Herbert J. Skuhra.
10439 Fix minor problems found by static checking.
10441 * image.c (PixelGetMagickColor): Declare if ImageMagick headers don't.
10443 Make identifiers static if they are not used in other modules.
10444 * data.c (Qcompiled_function, Qframe, Qvector):
10445 * image.c (QimageMagick, Qsvg):
10446 * minibuf.c (Qmetadata):
10447 * window.c (resize_window_check, resize_root_window): Now static.
10448 * window.h (resize_window_check, resize_root_window): Remove decls.
10450 * window.c (window_deletion_count, delete_deletable_window):
10452 (window_body_lines): Now static.
10453 (Fdelete_other_windows_internal): Mark vars as initialized.
10454 Make sure 'resize_failed' is initialized.
10455 (run_window_configuration_change_hook): Rename local to avoid shadowing.
10456 (resize_window_apply): Remove unused local.
10457 * window.h (delete_deletable_window): Remove decl.
10459 * image.c (gif_load, svg_load_image): Rename locals to avoid shadowing.
10460 (imagemagick_load_image): Fix pointer signedness problem by changing
10461 last arg from unsigned char * to char *. All uses changed.
10462 Also, fix a local for similar reasons.
10463 Remove unused locals. Remove locals to avoid shadowing.
10464 (fn_rsvg_handle_free): Remove; unused.
10465 (svg_load, svg_load_image): Fix pointer signedness problem.
10466 (imagemagick_load_image): Don't use garbage pointer image_wand.
10468 * ftfont.c (ftfont_get_metrics, ftfont_drive_otf): Remove unused locals.
10470 2011-06-10 Chong Yidong <cyd@stupidchicken.com>
10472 * image.c (gif_load): Fix omitted cast error introduced by
10475 2011-06-10 Martin Rudalics <rudalics@gmx.at>
10477 * window.h (resize_proportionally, orig_total_lines)
10478 (orig_top_line): Remove from window structure.
10479 (set_window_height, set_window_width, change_window_heights)
10480 (Fdelete_window): Remove prototypes.
10481 (resize_frame_windows): Remove duplicate declaration.
10483 2011-06-10 Eli Zaretskii <eliz@gnu.org>
10485 * window.h (resize_frame_windows, resize_window_check)
10486 (delete_deletable_window, resize_root_window)
10487 (resize_frame_windows): Declare prototypes.
10489 * window.c (resize_window_apply): Make definition be "static" to
10490 match the prototype.
10492 2011-06-10 Martin Rudalics <rudalics@gmx.at>
10494 * window.c: Remove declarations of Qwindow_size_fixed,
10495 window_min_size_1, window_min_size_2, window_min_size,
10496 size_window, window_fixed_size_p, enlarge_window, delete_window.
10497 Remove static from declaration of Qdelete_window, it's
10498 temporarily needed by Fbury_buffer.
10499 (replace_window): Don't assign orig_top_line and
10501 (Fdelete_window, delete_window): Remove. Window deletion is
10502 handled by window.el.
10503 (window_loop): Remove DELETE_OTHER_WINDOWS case.
10504 Replace Fdelete_window calls with calls to Qdelete_window.
10505 (Fdelete_other_windows): Remove. Deleting other windows is
10506 handled by window.el.
10507 (window_fixed_size_p): Remove. Fixed-sizeness of windows is
10508 handled in window.el.
10509 (window_min_size_2, window_min_size_1, window_min_size): Remove.
10510 Window minimum sizes are handled in window.el.
10511 (shrink_windows, size_window, set_window_height)
10512 (set_window_width, change_window_heights, window_height)
10513 (window_width, CURBEG, CURSIZE, enlarge_window)
10514 (adjust_window_trailing_edge, Fadjust_window_trailing_edge)
10515 (Fenlarge_window, Fshrink_window): Remove. Window resizing is
10516 handled in window.el.
10517 (make_dummy_parent): Rename to make_parent_window and give it a
10518 second argument horflag.
10519 (make_window): Don't set resize_proportionally any more.
10520 (Fsplit_window): Remove. Windows are split in window.el.
10521 (save_restore_action, save_restore_orig_size)
10522 (shrink_window_lowest_first, save_restore_orig_size): Remove.
10523 Resize mini windows in window.el.
10524 (grow_mini_window, shrink_mini_window): Implement by calling
10525 Qresize_root_window_vertically, resize_window_check and
10526 resize_window_apply.
10527 (saved_window, Fset_window_configuration, save_window_save):
10528 Do not handle orig_top_line, orig_total_lines, and
10529 resize_proportionally.
10530 (window_min_height, window_min_width): Move to window.el.
10531 (keys_of_window): Move bindings for delete-other-windows,
10532 split-window, delete-window and enlarge-window to window.el.
10534 * buffer.c: Temporarily extern Qdelete_window.
10535 (Fbury_buffer): Temporarily call Qdelete_window instead of
10536 Fdelete_window (Fbury_buffer will move to window.el soon).
10538 * frame.c (set_menu_bar_lines_1): Remove code handling
10539 orig_top_line and orig_total_lines.
10541 * dispnew.c (adjust_frame_glyphs_initially): Don't use
10542 set_window_height but set heights directly.
10543 (change_frame_size_1): Use resize_frame_windows.
10545 * xdisp.c (init_xdisp): Don't use set_window_height but set
10548 * xfns.c (x_set_menu_bar_lines, x_set_tool_bar_lines):
10549 Use resize_frame_windows instead of change_window_heights and run
10550 run_window_configuration_change_hook.
10552 * w32fns.c (x_set_tool_bar_lines): Use resize_frame_windows
10553 instead of change_window_heights and run
10554 run_window_configuration_change_hook.
10556 2011-06-09 Martin Rudalics <rudalics@gmx.at>
10558 * window.c (replace_window): Rename second argument REPLACEMENT to
10559 NEW. New third argument SETFLAG. Rewrite.
10560 (delete_window, make_dummy_parent): Call replace_window with
10562 (window_list_1): Move down in code.
10563 (run_window_configuration_change_hook): Move set_buffer part
10564 before select_frame_norecord part in order to unwind correctly.
10565 Rename count1 to count.
10566 (recombine_windows, delete_deletable_window, resize_root_window)
10567 (Fdelete_other_windows_internal)
10568 (Frun_window_configuration_change_hook, make_parent_window)
10569 (resize_window_check, resize_window_apply, Fresize_window_apply)
10570 (resize_frame_windows, Fsplit_window_internal)
10571 (Fdelete_window_internal, Fresize_mini_window_internal):
10573 (syms_of_window): New variables Vwindow_splits and Vwindow_nest.
10575 2011-06-08 Martin Rudalics <rudalics@gmx.at>
10577 * window.h (window): Add some new members to window structure -
10578 normal_lines, normal_cols, new_total, new_normal, clone_number,
10579 splits, nest, prev_buffers, next_buffers.
10580 (WINDOW_TOTAL_SIZE): Move here from window.c.
10581 (MIN_SAFE_WINDOW_WIDTH, MIN_SAFE_WINDOW_HEIGHT): Define here.
10583 * window.c (Fwindow_height, Fwindow_width, Fwindow_full_width_p):
10585 (make_dummy_parent): Set new members of windows structure.
10586 (make_window): Move down in code. Handle new members of window
10588 (Fwindow_clone_number, Fwindow_splits, Fset_window_splits)
10589 (Fwindow_nest, Fset_window_nest, Fwindow_new_total)
10590 (Fwindow_normal_size, Fwindow_new_normal, Fwindow_prev_buffers)
10591 (Fset_window_prev_buffers, Fwindow_next_buffers)
10592 (Fset_window_next_buffers, Fset_window_clone_number):
10594 (Fwindow_hscroll, Fwindow_at, Fwindow_point, Fwindow_start)
10595 (Fwindow_end, Fwindow_line_height, Fset_window_dedicated_p):
10597 (Fwindow_parameters, Fwindow_parameter, Fset_window_parameter):
10598 Argument WINDOW can be now internal window too.
10599 (Fwindow_use_time): Move up in code.
10600 (Fget_buffer_window): Rename argument FRAME to ALL-FRAMES.
10601 Rewrite doc-string.
10602 (Fset_window_configuration, saved_window)
10603 (Fcurrent_window_configuration, save_window_save): Handle new
10604 members of window structure.
10605 (WINDOW_TOTAL_SIZE, MIN_SAFE_WINDOW_WIDTH)
10606 (MIN_SAFE_WINDOW_HEIGHT): Move to window.h.
10607 (syms_of_window): New Lisp objects Qrecord_window_buffer,
10608 Qwindow_deletable_p, Qdelete_window, Qreplace_buffer_in_windows,
10609 Qget_mru_window, Qresize_root_window,
10610 Qresize_root_window_vertically, Qsafe, Qabove, Qbelow,
10611 Qauto_buffer_name; staticpro them.
10613 2011-06-07 Martin Rudalics <rudalics@gmx.at>
10615 * window.c (Fwindow_total_size, Fwindow_left_column)
10616 (Fwindow_top_line, window_body_lines, Fwindow_body_size)
10617 (Fwindow_list_1): New functions.
10618 (window_box_text_cols): Replace with window_body_cols.
10619 (Fwindow_width, Fscroll_left, Fscroll_right):
10620 Use window_body_cols instead of window_box_text_cols.
10621 (delete_window, Fset_window_configuration):
10622 Call delete_all_subwindows with window as argument.
10623 (delete_all_subwindows): Take a window as argument and not a
10624 structure. Rewrite.
10625 (window_loop): Remove handling of GET_LRU_WINDOW and
10626 GET_LARGEST_WINDOW.
10627 (Fget_lru_window, Fget_largest_window): Move to window.el.
10629 * window.h: Extern window_body_cols instead of
10630 window_box_text_cols. delete_all_subwindows now takes a
10631 Lisp_Object as argument.
10633 * indent.c (compute_motion, Fcompute_motion):
10634 Use window_body_cols instead of window_box_text_cols.
10636 * frame.c (delete_frame): Call delete_all_subwindows with root
10637 window as argument.
10639 2011-06-07 Daniel Colascione <dan.colascione@gmail.com>
10641 * fns.c (Fputhash): Document return value.
10643 2011-06-06 Chong Yidong <cyd@stupidchicken.com>
10645 * image.c (gif_load): Implement gif89a spec "no disposal" method.
10647 2011-06-06 Paul Eggert <eggert@cs.ucla.edu>
10649 Cons<->int and similar integer overflow fixes (Bug#8794).
10651 Check for overflow when converting integer to cons and back.
10652 * charset.c (Fdefine_charset_internal, Fdecode_char):
10653 Use cons_to_unsigned to catch overflow.
10654 (Fencode_char): Use INTEGER_TO_CONS.
10655 * composite.h (LGLYPH_CODE): Use cons_to_unsigned.
10656 (LGLYPH_SET_CODE): Use INTEGER_TO_CONS.
10657 * data.c (long_to_cons, cons_to_long): Remove.
10658 (cons_to_unsigned, cons_to_signed): New functions.
10659 These signal an error for invalid or out-of-range values.
10660 * dired.c (Ffile_attributes): Use INTEGER_TO_CONS.
10661 * fileio.c (Fset_visited_file_modtime): Use CONS_TO_INTEGER.
10662 * font.c (Ffont_variation_glyphs):
10663 * fontset.c (Finternal_char_font): Use INTEGER_TO_CONS.
10664 * lisp.h: Include <intprops.h>.
10665 (INTEGER_TO_CONS, CONS_TO_INTEGER): New macros.
10666 (cons_to_signed, cons_to_unsigned): New decls.
10667 (long_to_cons, cons_to_long): Remove decls.
10668 * undo.c (record_first_change): Use INTEGER_TO_CONS.
10669 (Fprimitive_undo): Use CONS_TO_INTEGER.
10670 * xfns.c (Fx_window_property): Likewise.
10671 * xselect.c: Include <limits.h>.
10672 (x_own_selection, selection_data_to_lisp_data):
10673 Use INTEGER_TO_CONS.
10674 (x_handle_selection_request, x_handle_selection_clear)
10675 (x_get_foreign_selection, Fx_disown_selection_internal)
10676 (Fx_get_atom_name, x_send_client_event): Use CONS_TO_INTEGER.
10677 (lisp_data_to_selection_data): Use cons_to_unsigned.
10678 (x_fill_property_data): Use cons_to_signed.
10679 Report values out of range.
10681 Check for buffer and string overflow more precisely.
10682 * buffer.h (BUF_BYTES_MAX): New macro.
10683 * lisp.h (STRING_BYTES_MAX): New macro.
10684 * alloc.c (Fmake_string):
10685 * character.c (string_escape_byte8):
10686 * coding.c (coding_alloc_by_realloc):
10687 * doprnt.c (doprnt):
10688 * editfns.c (Fformat):
10690 Use STRING_BYTES_MAX, not MOST_POSITIVE_FIXNUM,
10691 since they may not be the same number.
10692 * editfns.c (Finsert_char):
10693 * fileio.c (Finsert_file_contents):
10694 Likewise for BUF_BYTES_MAX.
10696 * image.c: Use ptrdiff_t, not int, for sizes.
10697 (slurp_file): Switch from int to ptrdiff_t.
10699 (slurp_file): Check that file size fits in both size_t (for
10700 malloc) and ptrdiff_t (for sanity and safety).
10702 * fileio.c (Fverify_visited_file_modtime): Avoid time overflow
10703 if b->modtime has its maximal value.
10705 * dired.c (Ffile_attributes): Don't assume EMACS_INT has >32 bits.
10707 Don't assume time_t can fit into int.
10708 * buffer.h (struct buffer.modtime): Now time_t, not int.
10709 * fileio.c (Fvisited_file_modtime): No need for time_t cast now.
10710 * undo.c (Fprimitive_undo): Use time_t, not int, for time_t value.
10712 Minor fixes for signed vs unsigned integers.
10713 * character.h (MAYBE_UNIFY_CHAR):
10714 * charset.c (maybe_unify_char):
10715 * keyboard.c (read_char, reorder_modifiers):
10716 XINT -> XFASTINT, since the integer must be nonnegative.
10717 * ftfont.c (ftfont_spec_pattern):
10718 * keymap.c (access_keymap, silly_event_symbol_error):
10719 XUINT -> XFASTINT, since the integer must be nonnegative.
10720 (Fsingle_key_description, preferred_sequence_p): XUINT -> XINT,
10721 since it makes no difference and we prefer signed.
10722 * keyboard.c (record_char): Use XUINT when all the neighbors do.
10723 (access_keymap): NATNUMP -> INTEGERP, since the integer must be
10726 2011-06-06 Stefan Monnier <monnier@iro.umontreal.ca>
10728 * window.h (Fwindow_frame): Declare.
10730 2011-06-06 Paul Eggert <eggert@cs.ucla.edu>
10732 * alloc.c: Simplify handling of large-request failures (Bug#8800).
10733 (SPARE_MEMORY): Always define.
10734 (LARGE_REQUEST): Remove.
10735 (memory_full): Use SPARE_MEMORY rather than LARGE_REQUEST.
10737 2011-06-06 Martin Rudalics <rudalics@gmx.at>
10739 * lisp.h: Move EXFUNS for Fframe_root_window,
10740 Fframe_first_window and Fset_frame_selected_window to window.h.
10742 * window.h: Move EXFUNS for Fframe_root_window,
10743 Fframe_first_window and Fset_frame_selected_window here from
10746 * frame.c (Fwindow_frame, Fframe_first_window)
10747 (Fframe_root_window, Fframe_selected_window)
10748 (Fset_frame_selected_window): Move to window.c.
10749 (Factive_minibuffer_window): Move to minibuf.c.
10750 (Fother_visible_frames_p): New function.
10752 * minibuf.c (Factive_minibuffer_window): Move here from frame.c.
10754 * window.c (decode_window, decode_any_window): Move up in code.
10755 (Fwindowp, Fwindow_live_p): Rewrite doc-strings.
10756 (inhibit_frame_unsplittable): Remove unused variable.
10757 (Fwindow_buffer): Move up and rewrite doc-string.
10758 (Fwindow_parent, Fwindow_vchild, Fwindow_hchild, Fwindow_next)
10759 (Fwindow_prev): New functions.
10760 (Fwindow_frame): Move here from frame.c. Accept any window as
10762 (Fframe_root_window, Fframe_first_window)
10763 (Fframe_selected_window): Move here from frame.c. Accept frame
10764 or arbitrary window as argument. Update doc-strings.
10765 (Fminibuffer_window): Move up in code.
10766 (Fwindow_minibuffer_p): Move up in code and simplify.
10767 (Fset_frame_selected_window): Move here from frame.c.
10769 (Fselected_window, select_window, Fselect_window): Move up in
10770 code. Minor doc-string fixes.
10772 2011-06-06 Paul Eggert <eggert@cs.ucla.edu>
10774 * alloc.c (memory_full) [SYSTEM_MALLOC]: Port to MacOS (Bug#8800).
10775 Do not assume that spare memory exists; that assumption is valid
10776 only if SYSTEM_MALLOC.
10777 (LARGE_REQUEST): New macro, so that the issue of large requests
10778 is separated from the issue of spare memory.
10780 2011-06-05 Andreas Schwab <schwab@linux-m68k.org>
10782 * editfns.c (Fformat): Correctly handle zero flag with hexadecimal
10785 * gtkutil.c (xg_get_default_scrollbar_width): Avoid warning.
10787 * xfns.c (x_set_scroll_bar_default_width): Move declarations
10790 2011-06-05 Jan Djärv <jan.h.d@swipnet.se>
10792 * gtkutil.c (xg_get_default_scrollbar_width): New function.
10794 * gtkutil.h: Declare xg_get_default_scrollbar_width.
10796 * xfns.c (x_set_scroll_bar_default_width): If USE_GTK, get
10797 min width by calling x_set_scroll_bar_default_width (Bug#8505).
10799 2011-06-05 Juanma Barranquero <lekktu@gmail.com>
10801 * xdisp.c (single_display_spec_intangible_p): Remove declaration.
10803 2011-06-04 Chong Yidong <cyd@stupidchicken.com>
10805 * xselect.c (x_clipboard_manager_save): Remove redundant arg.
10806 (x_clipboard_manager_save): Add return value.
10807 (x_clipboard_manager_error_1, x_clipboard_manager_error_2):
10808 New error handlers.
10809 (x_clipboard_manager_save_frame, x_clipboard_manager_save_all):
10810 Obey Vx_select_enable_clipboard_manager. Catch errors in
10811 x_clipboard_manager_save (Bug#8779).
10812 (Vx_select_enable_clipboard_manager): New variable.
10813 (x_get_foreign_selection): Reduce scope of x_catch_errors (Bug#8790).
10815 2011-06-04 Dan Nicolaescu <dann@ics.uci.edu>
10817 * emacs.c (main): Warn when starting a GTK emacs in daemon mode.
10819 2011-06-04 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
10821 * fringe.c (update_window_fringes): Don't update overlay arrow bitmap
10822 in the current matrix if keep_current_p is non-zero.
10824 2011-06-04 Eli Zaretskii <eliz@gnu.org>
10826 * bidi.c (bidi_level_of_next_char): Fix last change.
10828 2011-06-03 Eli Zaretskii <eliz@gnu.org>
10830 Support bidi reordering of text covered by display properties.
10832 * bidi.c (bidi_copy_it): Use offsetof instead of emulating it.
10833 (bidi_fetch_char, bidi_fetch_char_advance): New functions.
10834 (bidi_cache_search, bidi_cache_iterator_state)
10835 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak)
10836 (bidi_level_of_next_char, bidi_move_to_visually_next):
10837 Support character positions inside a run of characters covered by a
10839 (bidi_paragraph_init, bidi_resolve_explicit_1)
10840 (bidi_level_of_next_char): Call bidi_fetch_char and
10841 bidi_fetch_char_advance instead of FETCH_CHAR and
10842 FETCH_CHAR_ADVANCE.
10843 (bidi_init_it): Initialize new members.
10844 (LRE_CHAR, RLE_CHAR, PDF_CHAR, LRO_CHAR, RLO_CHAR): Remove macro
10846 (bidi_explicit_dir_char): Lookup character type in bidi_type_table,
10847 instead of using explicit *_CHAR codes.
10848 (bidi_resolve_explicit, bidi_resolve_weak):
10849 Use FETCH_MULTIBYTE_CHAR instead of FETCH_CHAR, as reordering of
10850 bidirectional text is supported only in multibyte buffers.
10851 (bidi_init_it): Accept additional argument FRAME_WINDOW_P and use
10852 it to initialize the frame_window_p member of struct bidi_it.
10853 (bidi_cache_iterator_state, bidi_resolve_explicit_1)
10854 (bidi_resolve_explicit, bidi_resolve_weak)
10855 (bidi_level_of_next_char, bidi_move_to_visually_next): Abort if
10856 bidi_it->nchars is non-positive.
10857 (bidi_level_of_next_char): Don't try to lookup the cache for the
10858 next/previous character if nothing is cached there yet, or if we
10859 were just reseat()'ed to a new position.
10861 * xdisp.c (set_cursor_from_row): Set start and stop points
10862 according to the row's direction when priming the loop that looks
10863 for the glyph on which to display cursor.
10864 (single_display_spec_intangible_p): Function deleted.
10865 (display_prop_intangible_p): Reimplement to call
10866 handle_display_spec instead of single_display_spec_intangible_p.
10867 Accept 3 additional arguments needed by handle_display_spec.
10868 This fixes incorrect cursor motion across display property with complex
10869 values: lists, `(when COND...)' forms, etc.
10870 (single_display_spec_string_p): Support property values that are
10871 lists with the argument STRING its top-level element.
10872 (display_prop_string_p): Fix the condition for processing a
10873 property that is a list to be consistent with handle_display_spec.
10874 (handle_display_spec): New function, refactored from the
10875 last portion of handle_display_prop.
10876 (compute_display_string_pos): Accept additional argument
10877 FRAME_WINDOW_P. Call handle_display_spec to determine whether the
10878 value of a `display' property is a "replacing spec".
10879 (handle_single_display_spec): Accept 2 additional arguments BUFPOS
10880 and FRAME_WINDOW_P. If IT is NULL, don't set up the iterator from
10881 the display property, but just return a value indicating whether
10882 the display property will replace the characters it covers.
10883 (Fcurrent_bidi_paragraph_direction): Initialize the nchars and
10884 frame_window_p members of struct bidi_it.
10885 (compute_display_string_pos, compute_display_string_end):
10887 (push_it): Accept second argument POSITION, where pop_it should
10888 jump to continue iteration.
10889 (reseat_1): Initialize bidi_it.disp_pos.
10891 * keyboard.c (adjust_point_for_property): Adjust the call to
10892 display_prop_intangible_p to its new signature.
10894 * dispextern.h (struct bidi_it): New member frame_window_p.
10895 (bidi_init_it): Update prototypes.
10896 (display_prop_intangible_p): Update prototype.
10897 (compute_display_string_pos, compute_display_string_end):
10898 Declare prototypes.
10899 (struct bidi_it): New members nchars and disp_pos. ch_len is now
10902 2011-06-02 Paul Eggert <eggert@cs.ucla.edu>
10904 Malloc failure behavior now depends on size of allocation.
10905 * alloc.c (buffer_memory_full, memory_full): New arg NBYTES.
10906 * lisp.h: Change signatures accordingly.
10907 * alloc.c, buffer.c, editfns.c, menu.c, minibuf.c, xterm.c:
10908 All callers changed. (Bug#8762)
10910 * gnutls.c: Use Emacs's memory allocators.
10911 Without this change, the gnutls library would invoke malloc etc.
10912 directly, which causes problems on non-SYNC_INPUT hosts, and which
10913 runs afoul of improving memory_full behavior. (Bug#8761)
10914 (fn_gnutls_global_set_mem_functions): New macro or function pointer.
10915 (emacs_gnutls_global_init): Use it to specify xmalloc, xrealloc,
10916 xfree instead of the default malloc, realloc, free.
10917 (Fgnutls_boot): No need to check for memory allocation failure,
10918 since xmalloc does that for us.
10920 Remove arbitrary limit of 2**31 entries in hash tables. (Bug#8771)
10921 * category.c (hash_get_category_set):
10922 * ccl.c (ccl_driver):
10923 * charset.c (Fdefine_charset_internal):
10924 * charset.h (struct charset.hash_index):
10925 * composite.c (get_composition_id, gstring_lookup_cache)
10926 (composition_gstring_put_cache):
10927 * composite.h (struct composition.hash_index):
10928 * dispextern.h (struct image.hash):
10929 * fns.c (next_almost_prime, larger_vector, cmpfn_eql)
10930 (cmpfn_equal, cmpfn_user_defined, hashfn_eq, hashfn_eql)
10931 (hashfn_equal, hashfn_user_defined, make_hash_table)
10932 (maybe_resize_hash_table, hash_lookup, hash_put)
10933 (hash_remove_from_table, hash_clear, sweep_weak_table, SXHASH_COMBINE)
10934 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector)
10935 (Fsxhash, Fgethash, Fputhash, Fmaphash):
10936 * image.c (make_image, search_image_cache, lookup_image)
10937 (xpm_put_color_table_h):
10938 * lisp.h (struct Lisp_Hash_Table):
10939 * minibuf.c (Ftry_completion, Fall_completions, Ftest_completion):
10940 * print.c (print): Use 'EMACS_UINT' and 'EMACS_INT'
10941 for hashes and hash indexes, instead of 'unsigned' and 'int'.
10942 * alloc.c (allocate_vectorlike):
10943 Check for overflow in vector size calculations.
10944 * ccl.c (ccl_driver):
10945 Check for overflow when converting EMACS_INT to int.
10946 * fns.c, image.c: Remove unnecessary static decls that would otherwise
10947 need to be updated by these changes.
10948 * fns.c (make_hash_table, maybe_resize_hash_table):
10949 Check for integer overflow with large hash tables.
10950 (make_hash_table, maybe_resize_hash_table, Fmake_hash_table):
10951 Prefer the faster XFLOAT_DATA to XFLOATINT where either will do.
10952 (SXHASH_REDUCE): New macro.
10953 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector):
10954 Use it instead of discarding useful hash info with large hash values.
10955 (sxhash_float): New function.
10956 (sxhash): Use it. No more need for "& INTMASK" due to above changes.
10957 * lisp.h (FIXNUM_BITS): New macro, useful for SXHASH_REDUCE etc.
10958 (MOST_NEGATIVE_FIXNUM, MOST_POSITIVE_FIXNUM, INTMASK):
10959 Rewrite to use FIXNUM_BITS, as this simplifies things.
10960 (next_almost_prime, larger_vector, sxhash, hash_lookup, hash_put):
10961 Adjust signatures to match updated version of code.
10962 (consing_since_gc): Now EMACS_INT, since a single hash table can
10963 use more than INT_MAX bytes.
10965 2011-06-01 Dan Nicolaescu <dann@ics.uci.edu>
10967 Make it possible to build with GCC-4.6+ -O2 -flto.
10969 * emacs.c (__malloc_initialize_hook): Mark as EXTERNALLY_VISIBLE.
10971 2011-06-01 Stefan Monnier <monnier@iro.umontreal.ca>
10973 * minibuf.c (get_minibuffer, read_minibuf_unwind):
10974 Call minibuffer-inactive-mode.
10976 2011-05-31 Juanma Barranquero <lekktu@gmail.com>
10978 * makefile.w32-in ($(BLD)/data.$(O), $(BLD)/editfns.$(O)):
10979 Update dependencies.
10981 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
10983 * data.c (init_data): Remove code for UTS, this system is not
10986 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
10988 Don't force ./temacs to start in terminal mode.
10990 * frame.c (make_initial_frame): Initialize faces in all cases, not
10991 only when CANNOT_DUMP is defined.
10992 * dispnew.c (init_display): Remove CANNOT_DUMP condition.
10994 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
10996 * dispnew.c (add_window_display_history): Use const for the string
10997 pointer. Remove declaration, not needed.
10999 2011-05-31 Paul Eggert <eggert@cs.ucla.edu>
11001 Use 'inline', not 'INLINE'.
11002 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00914.html>
11003 * alloc.c, fontset.c (INLINE): Remove.
11004 * alloc.c, bidi.c, charset.c, coding.c, dispnew.c, fns.c, image.c:
11005 * intervals.c, keyboard.c, process.c, syntax.c, textprop.c, w32term.c:
11006 * xdisp.c, xfaces.c, xterm.c: Replace all uses of INLINE with inline.
11007 * gmalloc.c (register_heapinfo): Use inline unconditionally.
11008 * lisp.h (LISP_MAKE_RVALUE): Use inline, not __inline__.
11010 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
11012 Make it possible to run ./temacs.
11014 * callproc.c (set_initial_environment): Remove CANNOT_DUMP code,
11015 syms_of_callproc does the same thing. Remove test for
11016 "initialized", do it in the caller.
11017 * emacs.c (main): Avoid calling set_initial_environment when dumping.
11019 2011-05-31 Stefan Monnier <monnier@iro.umontreal.ca>
11021 * minibuf.c (Finternal_complete_buffer): Return `category' metadata.
11022 (read_minibuf): Use get_minibuffer.
11023 (syms_of_minibuf): Use DEFSYM.
11024 (Qmetadata): New var.
11025 * data.c (Qbuffer): Don't make it static.
11026 (syms_of_data): Use DEFSYM.
11028 2011-05-31 Paul Eggert <eggert@cs.ucla.edu>
11030 * ccl.c (CCL_CODE_RANGE): Allow negative numbers. (Bug#8751)
11031 (CCL_CODE_MIN): New macro.
11033 2011-05-30 Paul Eggert <eggert@cs.ucla.edu>
11035 * alloc.c (lisp_align_malloc): Omit unnecessary val==NULL tests.
11037 * eval.c (Qdebug): Now static.
11038 * lisp.h (Qdebug): Remove decl. This reverts a part of the
11039 2011-04-26T11:26:05Z!dan.colascione@gmail.com that inadvertently undid part of
11040 2011-04-14T06:48:41Z!eggert@cs.ucla.edu.
11042 2011-05-29 Chong Yidong <cyd@stupidchicken.com>
11044 * image.c: Various fixes to ImageMagick code comments.
11045 (Fimagemagick_types): Doc fix.
11047 2011-05-29 Paul Eggert <eggert@cs.ucla.edu>
11049 Minor fixes prompted by GCC 4.6.0 warnings.
11051 * xselect.c (converted_selections, conversion_fail_tag): Now static.
11053 * emacs.c [HAVE_X_WINDOWS]: Include "xterm.h".
11054 (x_clipboard_manager_save_all): Move extern decl to ...
11055 * xterm.h: ... here, so that it can be checked for consistency.
11057 2011-05-29 Chong Yidong <cyd@stupidchicken.com>
11059 * xselect.c (x_clipboard_manager_save_frame)
11060 (x_clipboard_manager_save_all): New functions.
11061 (Fx_clipboard_manager_save): Lisp function deleted.
11063 * emacs.c (Fkill_emacs): Call x_clipboard_manager_save_all.
11064 * frame.c (delete_frame): Call x_clipboard_manager_save_frame.
11066 * xterm.h: Update prototype.
11068 2011-05-28 William Xu <william.xwl@gmail.com>
11070 * nsterm.m (ns_term_shutdown): Synchronize user defaults before
11071 exiting (Bug#8239).
11073 2011-05-28 Jim Meyering <meyering@redhat.com>
11075 Avoid a sign-extension bug in crypto_hash_function.
11076 * fns.c (to_uchar): Define.
11077 (crypto_hash_function): Use it to convert some newly-signed
11078 variables to unsigned, to avoid sign-extension bugs. For example,
11079 without this change, (md5 "truc") would evaluate to
11080 45723a2aff78ff4fff7fff1114760e62 rather than the expected
11081 45723a2af3788c4ff17f8d1114760e62. Reported by Antoine Levitt in
11082 https://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00883.html.
11084 2011-05-27 Paul Eggert <eggert@cs.ucla.edu>
11086 Integer overflow fixes.
11088 * dbusbind.c: Serial number integer overflow fixes.
11089 (CHECK_DBUS_SERIAL_GET_SERIAL): New macro.
11090 (Fdbus_call_method_asynchronously, xd_read_message_1): Use a float
11091 to hold a serial number that is too large for a fixnum.
11092 (Fdbus_method_return_internal, Fdbus_method_error_internal):
11093 Check for serial numbers out of range. Decode any serial number
11094 that was so large that it became a float. (Bug#8722)
11096 * dbusbind.c: Use XFASTINT rather than XUINT, and check for nonneg.
11097 (Fdbus_call_method, Fdbus_call_method_asynchronously):
11098 Use XFASTINT rather than XUINT when numbers are nonnegative.
11099 (xd_append_arg, Fdbus_method_return_internal):
11100 (Fdbus_method_error_internal): Likewise. Also, for unsigned
11101 arguments, check that Lisp number is nonnegative, rather than
11102 silently wrapping negative numbers around. (Bug#8722)
11103 (xd_read_message_1): Don't assume dbus_uint32_t can fit in int.
11106 * data.c (arith_driver, Flsh): Avoid unnecessary casts to EMACS_UINT.
11108 * ccl.c (ccl_driver): Redo slightly to avoid the need for 'unsigned'.
11110 ccl: Add integer overflow checks.
11111 * ccl.c (CCL_CODE_MAX, GET_CCL_RANGE, GET_CCL_CODE, GET_CCL_INT):
11112 (IN_INT_RANGE): New macros.
11113 (ccl_driver): Use them to check for integer overflow when
11114 decoding a CCL program. Many of the new checks are whether XINT (x)
11115 fits in int; it doesn't always, on 64-bit hosts. The new version
11116 doesn't catch all possible integer overflows, but it's an
11117 improvement. (Bug#8719)
11119 * alloc.c (make_event_array): Use XINT, not XUINT.
11120 There's no need for unsigned here.
11122 * mem-limits.h (EXCEEDS_LISP_PTR) [!USE_LSB_TAG]: EMACS_UINT -> uintptr_t
11123 This follows up to the 2011-05-06 change that substituted uintptr_t
11124 for EMACS_INT. This case wasn't caught back then.
11126 Rework Fformat to avoid integer overflow issues.
11127 * editfns.c: Include <float.h> unconditionally, as it's everywhere
11128 now (part of C89). Include <verify.h>.
11129 (MAX_10_EXP, CONVERTED_BYTE_SIZE): Remove; no longer needed.
11130 (pWIDE, pWIDElen, signed_wide, unsigned_wide): New defns.
11131 (Fformat): Avoid the prepass trying to compute sizes; it was only
11132 approximate and thus did not catch overflow reliably. Instead, walk
11133 through the format just once, formatting and computing sizes as we go,
11134 checking for integer overflow at every step, and allocating a larger
11135 buffer as needed. Keep track separately whether the format is
11136 multibyte. Keep only the most-recently calculated precision, rather
11137 than them all. Record whether each argument has been converted to
11138 string. Use EMACS_INT, not int, for byte and char and arg counts.
11139 Support field widths and precisions larger than INT_MAX. Avoid
11140 sprintf's undefined behavior with conversion specifications such as %#d
11141 and %.0c. Fix bug with strchr succeeding on '\0' when looking for
11142 flags. Fix bug with (format "%c" 256.0). Avoid integer overflow when
11143 formatting out-of-range floating point numbers with int
11144 formats. (Bug#8668)
11146 * lisp.h (FIXNUM_OVERFLOW_P): Work even if arg is a NaN.
11148 * data.c: Avoid integer truncation in expressions involving floats.
11149 * data.c: Include <intprops.h>.
11150 (arith_driver): When there's an integer overflow in an expression
11151 involving floating point, convert the integers to floating point
11152 so that the resulting value does not suffer from catastrophic
11153 integer truncation. For example, on a 64-bit host (* 4
11154 most-negative-fixnum 0.5) should yield about -4.6e+18, not zero.
11155 Do not rely on undefined behavior after integer overflow.
11157 merge count_size_as_multibyte, parse_str_to_multibyte
11158 * character.c, character.h (count_size_as_multibyte):
11159 Rename from parse_str_to_multibyte; all uses changed.
11160 Check for integer overflow.
11161 * insdel.c, lisp.h (count_size_as_multibyte): Remove,
11162 since it's now a duplicate of the other. This is more of
11163 a character than a buffer op, so better that it's in character.c.
11164 * fns.c, print.c: Adjust to above changes.
11166 2011-05-27 Stefan Monnier <monnier@iro.umontreal.ca>
11168 * xselect.c (x_convert_selection): Yet another int/Lisp_Object mixup.
11170 2011-05-27 Paul Eggert <eggert@cs.ucla.edu>
11172 * xselect.c: Fix minor problems prompted by GCC 4.6.0 warnings.
11173 (x_handle_selection_request, frame_for_x_selection): Remove unused vars.
11174 (x_clipboard_manager_save): Now static.
11175 (Fx_clipboard_manager_save): Rename local to avoid shadowing.
11177 * fns.c: Fix minor problems prompted by GCC 4.6.0 warnings.
11178 (crypto_hash_function): Now static.
11179 Fix pointer signedness problems. Avoid unnecessary initializations.
11181 2011-05-27 Chong Yidong <cyd@stupidchicken.com>
11183 * termhooks.h (Vselection_alist): Make it terminal-local.
11185 * terminal.c (create_terminal): Initialize it.
11187 * xselect.c: Support for clipboard managers.
11188 (Vselection_alist): Move to termhooks.h as terminal-local var.
11189 (LOCAL_SELECTION): New macro.
11190 (x_atom_to_symbol): Handle x_display_info_for_display fail case.
11191 (symbol_to_x_atom): Remove gratuitous arg.
11192 (x_handle_selection_request, lisp_data_to_selection_data)
11193 (x_get_foreign_selection, Fx_register_dnd_atom): Callers changed.
11194 (x_own_selection, x_get_local_selection, x_convert_selection):
11195 New arg, specifying work frame. Use terminal-local Vselection_alist.
11196 (some_frame_on_display): Delete unused function.
11197 (Fx_own_selection_internal, Fx_get_selection_internal)
11198 (Fx_disown_selection_internal, Fx_selection_owner_p)
11199 (Fx_selection_exists_p): New optional frame arg.
11200 (frame_for_x_selection, Fx_clipboard_manager_save): New functions.
11201 (x_handle_selection_clear): Don't treat other terminals with the
11202 same keyboard specially. Use the terminal-local Vselection_alist.
11203 (x_clear_frame_selections): Use Frun_hook_with_args.
11205 * xterm.c (x_term_init): Intern ATOM and CLIPBOARD_MANAGER atoms.
11207 * xterm.h: Add support for those atoms.
11209 2011-05-26 Chong Yidong <cyd@stupidchicken.com>
11211 * xselect.c: ICCCM-compliant handling of MULTIPLE targets.
11212 (converted_selections, conversion_fail_tag): New global variables.
11213 (x_selection_request_lisp_error): Free the above.
11214 (x_get_local_selection): Remove unnecessary code.
11215 (x_reply_selection_request): Args changed; handle arbitrary array
11216 of converted selections stored in converted_selections.
11217 Separate the XChangeProperty and SelectionNotify steps.
11218 (x_handle_selection_request): Rewrite to handle MULTIPLE target.
11219 (x_convert_selection): New function.
11220 (x_handle_selection_event): Simplify.
11221 (x_get_foreign_selection): Don't ignore incoming requests while
11222 waiting for an answer; this will fail when we implement
11223 SAVE_TARGETS, and seems unnecessary anyway.
11224 (selection_data_to_lisp_data): Recognize ATOM_PAIR type.
11225 (Vx_sent_selection_functions): Doc fix.
11227 2011-05-26 Leo Liu <sdl.web@gmail.com>
11229 * editfns.c (Ftranspose_regions): Allow empty regions. (Bug#8699)
11231 2011-05-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
11233 * dispextern.h (struct glyph_row): New member fringe_bitmap_periodic_p.
11235 * dispnew.c (shift_glyph_matrix, scrolling_window): Mark scrolled row
11236 for fringe update if it has periodic bitmap.
11237 (row_equal_p): Also compare left_fringe_offset, right_fringe_offset,
11238 and fringe_bitmap_periodic_p.
11240 * fringe.c (get_fringe_bitmap_data): New function.
11241 (draw_fringe_bitmap_1, update_window_fringes): Use it.
11242 (update_window_fringes): Record periodicity of fringe bitmap in glyph
11243 row. Mark glyph row for fringe update if periodicity changed.
11245 * xdisp.c (try_window_reusing_current_matrix): Don't mark scrolled row
11246 for fringe update unless it has periodic bitmap.
11248 2011-05-25 Kenichi Handa <handa@m17n.org>
11250 * xdisp.c (get_next_display_element): Set correct it->face_id for
11251 a static composition.
11253 2011-05-24 Leo Liu <sdl.web@gmail.com>
11256 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha1.h.
11258 * fns.c (crypto_hash_function, Fsha1): New function.
11259 (Fmd5): Use crypto_hash_function.
11260 (syms_of_fns): Add Ssha1.
11262 2011-05-22 Paul Eggert <eggert@cs.ucla.edu>
11264 * gnutls.c: Remove unused macros.
11265 (fn_gnutls_transport_set_lowat, fn_gnutls_transport_set_pull_function):
11266 (fn_gnutls_transport_set_push_function) [!WINDOWSNT]:
11267 Remove macros that are defined and never used.
11268 Caught by gcc -Wunused-macros (GCC 4.6.0, Fedora 14).
11270 2011-05-22 Chong Yidong <cyd@stupidchicken.com>
11272 * xselect.c (syms_of_xselect): Remove unused symbol SAVE_TARGETS.
11273 (Fx_get_selection_internal): Minor cleanup.
11274 (Fx_own_selection_internal): Rename arguments for consistency with
11277 2011-05-22 Paul Eggert <eggert@cs.ucla.edu>
11279 * xselect.c (QSAVE_TARGETS): New static var, to fix build failure.
11281 2011-05-22 Chong Yidong <cyd@stupidchicken.com>
11283 * xselect.c (syms_of_xselect): Include character.h; use DEFSYM.
11285 2011-05-21 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
11287 * dispnew.c (scrolling_window): Don't exclude the case that the
11288 last enabled row in the desired matrix touches the bottom boundary.
11290 2011-05-21 Glenn Morris <rgm@gnu.org>
11292 * Makefile.in ($(etc)/DOC): Make second command line even shorter.
11293 (SOME_MACHINE_OBJECTS): Replace FONT_OBJ by its maximal expansion,
11294 and add some more files.
11296 2011-05-20 Eli Zaretskii <eliz@gnu.org>
11298 * callproc.c (Fcall_process) [MSDOS]: Fix arguments to
11299 report_file_error introduced by the change from 2011-05-07.
11301 2011-05-20 Paul Eggert <eggert@cs.ucla.edu>
11303 * systime.h (Time): Define only if emacs is defined.
11304 This is to allow ../lib-src/profile.c to be compiled on FreeBSD,
11305 where the include path doesn't have X11/X.h by default. See
11306 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00561.html>.
11308 2011-05-20 Kenichi Handa <handa@m17n.org>
11310 * composite.c (find_automatic_composition): Fix previous change.
11312 2011-05-20 Glenn Morris <rgm@gnu.org>
11314 * lisp.mk: New file, split from Makefile.in.
11315 * Makefile.in (lisp): Move to separate file, inserted by @lisp_frag@.
11316 (shortlisp): Remove.
11317 ($(etc)/DOC): Edit lisp.mk rather than using $shortlisp.
11319 2011-05-19 Glenn Morris <rgm@gnu.org>
11321 * Makefile.in (MSDOS_SUPPORT_REAL, MSDOS_SUPPORT, NS_SUPPORT)
11322 (REAL_MOUSE_SUPPORT, GPM_MOUSE_SUPPORT, MOUSE_SUPPORT, TOOLTIP_SUPPORT)
11323 (BASE_WINDOW_SUPPORT, X_WINDOW_SUPPORT, WINDOW_SUPPORT): Remove.
11324 (lisp): Set the order to that of loadup.el.
11325 (shortlisp): Make it a copy of $lisp.
11326 (SOME_MACHINE_LISP): Remove.
11327 ($(etc)/DOC): Depend just on $lisp, not $SOME_MACHINE_LISP too.
11328 Use just $shortlisp, not $SOME_MACHINE_LISP too.
11330 2011-05-18 Kenichi Handa <handa@m17n.org>
11332 * composite.c (CHAR_COMPOSABLE_P): Add more check for efficiency.
11333 (BACKWARD_CHAR): Wrap the arg STOP by parenthesis.
11334 (find_automatic_composition): Mostly rewrite for efficiency.
11336 2011-05-18 Juanma Barranquero <lekktu@gmail.com>
11338 * makefile.w32-in: Update dependencies.
11340 2011-05-18 Christoph Scholtes <cschol2112@googlemail.com>
11342 * menu.c: Include limits.h (fixes the MS-Windows build broken by
11343 2011-06-18T18:49:19Z!cyd@stupidchicken.com).
11345 2011-05-18 Paul Eggert <eggert@cs.ucla.edu>
11347 Fix some integer overflow issues, such as string length overflow.
11349 * insdel.c (count_size_as_multibyte): Check for string overflow.
11351 * character.c (lisp_string_width): Check for string overflow.
11352 Use EMACS_INT, not int, for string indexes and lengths; in
11353 particular, 2nd arg is now EMACS_INT, not int. Do not crash if
11354 the resulting string length overflows an EMACS_INT; instead,
11355 report a string overflow if no precision given. When checking for
11356 precision exhaustion, use a check that cannot possibly have
11357 integer overflow. (Bug#8675)
11358 * character.h (lisp_string_width): Adjust to new signature.
11360 * alloc.c (string_overflow): New function.
11361 (Fmake_string): Use it. This doesn't change behavior, but saves
11362 a few bytes and will simplify future changes.
11363 * character.c (string_escape_byte8): Likewise.
11364 * lisp.h (string_overflow): New decl.
11366 Fixups, following up to the user-interface timestamp change.
11367 * nsterm.m (last_mouse_movement_time, ns_mouse_position): Use Time
11368 for UI timestamps, instead of unsigned long.
11369 * msdos.c (mouse_get_pos): Likewise.
11370 * w32inevt.c (movement_time, w32_console_mouse_position): Likewise.
11371 * w32gui.h (Time): Define by including "systime.h" rather than by
11372 declaring it ourselves. (Bug#8664)
11374 * dispextern.h (struct image): Don't assume time_t <= unsigned long.
11375 * image.c (clear_image_cache): Likewise.
11377 * term.c (term_mouse_position): Don't assume time_t wraparound.
11379 Be more systematic about user-interface timestamps.
11380 Before, the code sometimes used 'Time', sometimes 'unsigned long',
11381 and sometimes 'EMACS_UINT', to represent these timestamps.
11382 This change causes it to use 'Time' uniformly, as that's what X uses.
11383 This makes the code easier to follow, and makes it easier to catch
11384 integer overflow bugs such as Bug#8664.
11385 * frame.c (Fmouse_position, Fmouse_pixel_position):
11386 Use Time, not unsigned long, for user-interface timestamps.
11387 * keyboard.c (last_event_timestamp, kbd_buffer_get_event): Likewise.
11388 (button_down_time, make_lispy_position, make_lispy_movement): Likewise.
11389 * keyboard.h (last_event_timestamp): Likewise.
11390 * menu.c (Fx_popup_menu) [!HAVE_X_WINDOWS]: Likewise.
11391 * menu.h (xmenu_show): Likewise.
11392 * term.c (term_mouse_position): Likewise.
11393 * termhooks.h (struct input_event.timestamp): Likewise.
11394 (struct terminal.mouse_position_hook): Likewise.
11395 * xmenu.c (create_and_show_popup_menu, xmenu_show): Likewise.
11396 * xterm.c (XTmouse_position, x_scroll_bar_report_motion): Likewise.
11397 * systime.h (Time): New decl. Pull it in from <X11/X.h> if
11398 HAVE_X_WINDOWS, otherwise define it as unsigned long, which is
11399 what it was before.
11400 * menu.h, termhooks.h: Include "systime.h", for Time.
11402 * keyboard.c (make_lispy_event): Fix problem in integer overflow.
11403 Don't assume that the difference between two unsigned long values
11404 can fit into an integer. At this point, we know button_down_time
11405 <= event->timestamp, so the difference must be nonnegative, so
11406 there's no need to cast the result if double-click-time is
11407 nonnegative, as it should be; check that it's nonnegative, just in
11408 case. This bug is triggered when events are more than 2**31 ms
11409 apart (about 25 days). (Bug#8664)
11411 * xselect.c (last_event_timestamp): Remove duplicate decl.
11412 (x_own_selection): Remove needless cast to unsigned long.
11414 * xmenu.c (set_frame_menubar): Use int, not EMACS_UINT, for indexes
11415 that always fit in int. Use a sentinel instead of a counter, to
11416 avoid a temp and to allay GCC's concerns about possible int overflow.
11417 * frame.h (struct frame): Use int for menu_bar_items_used
11418 instead of EMACS_INT, since it always fits in int.
11420 * menu.c (grow_menu_items): Check for int overflow.
11422 * xmenu.c (set_frame_menubar): Don't mishandle vectors with no nils.
11424 * xterm.c: Use EMACS_INT for Emacs modifiers, and int for X modifiers.
11425 Before, the code was not consistent. These values cannot exceed
11426 2**31 - 1 so there's no need to make them unsigned.
11427 (x_x_to_emacs_modifiers): Accept int and return EMACS_INT.
11428 (x_emacs_to_x_modifiers): Accept EMACS_INT and return int.
11429 (x_x_to_emacs_modifiers, x_emacs_to_x_modifiers): Reject non-integers
11431 * xterm.h (x_x_to_emacs_modifiers): Adjust to signature change.
11433 * lisp.h (XINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_INT.
11434 (XUINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_UINT.
11435 Otherwise, GCC 4.6.0 warns about printf (pI, XINT (...)),
11436 presumably because the widths might not match.
11438 * window.c (size_window): Avoid needless test at loop start.
11440 2011-05-18 Courtney Bane <emacs-bugs-7626@cbane.org> (tiny change)
11442 * term.c (Fresume_tty): Restore hooks before reinitializing (bug#8687).
11444 2011-05-12 Drew Adams <drew.adams@oracle.com>
11446 * textprop.c (Fprevious_single_char_property_change): Doc fix (bug#8655).
11448 2011-05-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
11450 * w32term.c (w32_draw_fringe_bitmap): Rename local vars `left' and
11451 `width' to `bar_area_x' and `bar_area_width', respectively.
11452 (x_scroll_run): Take account of fringe background extension.
11454 * xterm.c (x_draw_fringe_bitmap) [USE_TOOLKIT_SCROLL_BARS]:
11455 Rename local vars `left' and `width' to `bar_area_x' and
11456 `bar_area_width', respectively.
11457 (x_scroll_run) [USE_TOOLKIT_SCROLL_BARS]: Take account of fringe
11458 background extension.
11460 2011-05-10 Jim Meyering <meyering@redhat.com>
11462 * xdisp.c (x_intersect_rectangles): Fix typo "the the -> the".
11464 2011-05-10 Juanma Barranquero <lekktu@gmail.com>
11466 * image.c (Finit_image_library): Return t for built-in image types,
11467 like pbm and xbm. (Bug#8640)
11469 2011-05-09 Andreas Schwab <schwab@linux-m68k.org>
11471 * w32menu.c (set_frame_menubar): Fix submenu allocation.
11473 2011-05-07 Eli Zaretskii <eliz@gnu.org>
11475 * w32console.c (Fset_screen_color): Doc fix.
11476 (Fget_screen_color): New function.
11477 (syms_of_ntterm): Defsubr it.
11479 * callproc.c (call_process_cleanup) [MSDOS]: Don't close and
11480 unlink the temporary file if Fcall_process didn't create it in the
11482 (Fcall_process) [MSDOS]: Don't create tempfile if stdout of the
11483 child process will be redirected to a file specified with `:file'.
11484 Don't try to re-open tempfile in that case, and set fd[0] to -1 as
11485 cue to call_process_cleanup not to close that handle.
11487 2011-05-07 Ben Key <bkey76@gmail.com>
11489 * makefile.w32-in: The bootstrap-temacs rule now makes use of
11490 one of two shell specific rules, either bootstrap-temacs-CMD or
11491 bootstrap-temacs-SH. The bootstrap-temacs-SH rule is identical
11492 to the previous implementation of the bootstrap-temacs rule.
11493 The bootstrap-temacs-CMD rule is similar to the previous
11494 implementation of the bootstrap-temacs rule except that it
11495 makes use of the ESC_CFLAGS variable instead of the CFLAGS
11498 These changes, along with some changes to nt/configure.bat,
11499 nt/gmake.defs, and nt/nmake.defs, are required to extend my
11500 earlier fix to add support for --cflags and --ldflags options
11501 that include quotes so that it works whether make uses cmd or
11504 2011-05-06 Michael Albinus <michael.albinus@gmx.de>
11506 * dbusbind.c (QCdbus_type_unix_fd): Declare static.
11507 (xd_remove_watch): Don't check QCdbus_type_unix_fd for SYMBOLP, it
11509 (Fdbus_init_bus, xd_read_queued_messages): Bus can be a symbol or
11510 a string. Handle both cases.
11511 (Fdbus_call_method_asynchronously, Fdbus_register_signal)
11512 (Fdbus_register_method): Use Qinvalid_function.
11514 2011-05-06 Juanma Barranquero <lekktu@gmail.com>
11516 * makefile.w32-in: Update dependencies.
11517 (LISP_H): Add inttypes.h and stdin.h.
11518 (PROCESS_H): Add unistd.h.
11520 2011-05-06 Eli Zaretskii <eliz@gnu.org>
11522 * lread.c: Include limits.h (fixes the MS-Windows build broken by
11523 2011-05-06T07:13:19Z!eggert@cs.ucla.edu).
11525 2011-05-06 Paul Eggert <eggert@cs.ucla.edu>
11527 * image.c (Finit_image_library) [!HAVE_NTGUI]: Omit unused local.
11529 * term.c (vfatal): Remove stray call to va_end.
11530 It's not needed and the C Standard doesn't allow it here anyway.
11532 Use C99's va_copy to avoid undefined behavior on x86-64 GNU/Linux.
11533 * eval.c (verror): doprnt a copy of ap, not the original. (Bug#8545)
11535 * eval.c (verror): OK to create a string of up to MOST_POSITIVE_FIXNUM
11538 * term.c: Don't include <stdarg.h>, as <lisp.h> does that.
11540 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
11542 * process.c (Fformat_network_address): Fix typo: args2 -> *args2.
11544 * xmenu.c (set_frame_menubar): Fix typo: int * -> int (3 times).
11546 * coding.c (detect_coding_charset): Fix typo: * 2 -> *4 (Bug#8601).
11548 * charset.h (struct charset.code_space): Now has 15 elements, not 16.
11549 * charset.c (Fdefine_charset_internal): Don't initialize
11550 charset.code_space[15]. The value was garbage, on hosts with
11551 32-bit int (Bug#8600).
11553 * lread.c (read_integer): Be more consistent with string-to-number.
11554 Use string_to_number to do the actual conversion; this avoids
11555 rounding errors and fixes some other screwups. Without this fix,
11556 for example, #x1fffffffffffffff was misread as -2305843009213693952.
11557 (digit_to_number): Move earlier, for benefit of read_integer.
11558 Return -1 if the digit is out of range for the base, -2 if it is
11559 not a digit in any supported base. (Bug#8602)
11561 * doprnt.c (doprnt): Support arbitrary pI values, such as "I64".
11563 * dispnew.c (scrolling_window): Return 1 if we scrolled,
11564 to match comment at start of function. This also removes a
11565 GCC warning about overflow in a 32+64-bit port.
11567 * lisp.h (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Simplify.
11569 * dbusbind.c: Do not use XPNTR on a value that may be an integer.
11570 Reported by Stefan Monnier in
11571 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00919.html>.
11572 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
11573 Use SYMBOLP-guarded XSYMBOL, not XPNTR.
11575 * lisp.h (EMACS_INTPTR): Remove. All uses changed to intptr_t.
11576 (EMACS_UINTPTR): Likewise, with uintptr_t.
11578 * lisp.h: Prefer 64-bit EMACS_INT if available.
11579 (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Define to 64-bit
11580 on 32-bit hosts that have 64-bit int, so that they can access
11582 However, temporarily disable this change unless the temporary
11583 symbol WIDE_EMACS_INT is defined.
11585 * lread.c, process.c: Do not include <inttypes.h>; lisp.h does it now.
11587 Prefer intptr_t/uintptr_t for integers the same widths as pointers.
11588 This removes an assumption that EMACS_INT and long are the same
11589 width as pointers. The assumption is true for Emacs porting targets
11590 now, but we want to make other targets possible.
11591 * lisp.h: Include <inttypes.h>, for INTPTR_MAX, UINTPTR_MAX.
11592 (EMACS_INTPTR, EMACS_UINTPTR): New macros.
11593 In the rest of the code, change types of integers that hold casted
11594 pointers to EMACS_INTPTR and EMACS_UINTPTR, systematically
11595 replacing EMACS_INT, long, EMACS_UINT, and unsigned long.
11596 (XTYPE): Don't cast arg to EMACS_UINT; normally is not needed.
11597 (XSET): Cast type of XTYPE arg to EMACS_INTPTR; it is needed here.
11598 No need to cast type when ORing.
11599 (XPNTR): Return a value of type EMACS_INTPTR or EMACS_UINTPTR.
11600 * alloc.c (lisp_align_malloc): Remove a no-longer-needed cast.
11601 * doc.c (store_function_docstring): Use EMACS_INTPTR, so as not to
11602 assume EMACS_INT is the same width as char *.
11603 * gtkutil.c (xg_gtk_scroll_destroy, xg_tool_bar_button_cb):
11604 (xg_tool_bar_callback, xg_tool_bar_help_callback, xg_make_tool_item):
11605 Remove no-longer-needed casts.
11606 (xg_create_scroll_bar, xg_tool_bar_button_cb, xg_tool_bar_callback):
11607 (xg_tool_bar_help_callback, xg_make_tool_item):
11608 Use EMACS_INTPTR to hold an integer
11609 that will be cast to void *; this can avoid a GCC warning
11610 if EMACS_INT is not the same width as void *.
11611 * menu.c (find_and_call_menu_selection): Remove no-longer-needed cast.
11612 * xdisp.c (display_echo_area_1, resize_mini_window_1):
11613 (current_message_1, set_message_1):
11614 Use a local to convert to proper width without a cast.
11615 * xmenu.c (dialog_selection_callback): Likewise.
11617 * sysdep.c (get_random): Don't assume EMACS_INT is no wider than long.
11618 Also, don't assume VALBITS / RAND_BITS is less than 5,
11619 and don't rely on undefined behavior when shifting a 1 left into
11621 * lisp.h (get_random): Change signature to match.
11623 * lread.c (hash_string): Use size_t, not int, for hash computation.
11624 Normally we prefer signed values; but hashing is special, because
11625 it's better to use unsigned division on hash table sizes so that
11626 the remainder is nonnegative. Also, size_t is the natural width
11627 for hashing into memory. The previous code used 'int', which doesn't
11628 retain enough info to hash well into very large tables.
11629 (oblookup, oblookup_last_bucket_number, Funintern): Likewise.
11631 * dbusbind.c: Don't possibly lose pointer info when converting.
11632 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
11633 Use XPNTR rather than XHASH, so that the high-order bits of
11634 the pointer aren't lost when converting through void *.
11636 * eval.c (Fautoload): Don't double-shift a pointer.
11638 * fns.c (Frandom): Let EMACS_UINT be wider than unsigned long.
11640 2011-05-06 Juanma Barranquero <lekktu@gmail.com>
11642 * gnutls.c (DEF_GNUTLS_FN):
11643 * image.c (DEF_IMGLIB_FN): Make function pointers static.
11645 2011-05-05 Andreas Schwab <schwab@linux-m68k.org>
11647 * lread.c (lisp_file_lexically_bound_p): Stop scanning at end
11650 2011-05-05 Eli Zaretskii <eliz@gnu.org>
11652 * w32heap.c (allocate_heap) [USE_LISP_UNION_TYPE || USE_LSB_TAG]:
11653 New version that can reserve upto 2GB of heap space.
11655 2011-05-05 Chong Yidong <cyd@stupidchicken.com>
11657 * nsfns.m (Fns_read_file_name): Doc fix (Bug#8534).
11659 2011-05-05 Teodor Zlatanov <tzz@lifelogs.com>
11661 * gnutls.c (fn_gnutls_certificate_set_x509_key_file): Add alias to
11662 `gnutls_certificate_set_x509_key_file'.
11664 2011-05-05 Juanma Barranquero <lekktu@gmail.com>
11666 * makefile.w32-in ($(BLD)/image.$(O), $(BLD)/process.$(O)):
11667 Update dependencies.
11669 2011-05-04 Juanma Barranquero <lekktu@gmail.com>
11671 * gnutls.h (emacs_gnutls_write, emacs_gnutls_read):
11672 * gnutls.c (emacs_gnutls_write, emacs_gnutls_read):
11673 Remove unused parameter `fildes'.
11674 * process.c (read_process_output, send_process): Don't pass it.
11676 2011-05-04 Juanma Barranquero <lekktu@gmail.com>
11678 Fix previous change: the library cache is defined in w32.c.
11679 * image.c (CACHE_IMAGE_TYPE) [!HAVE_NTGUI]: Define to noop.
11680 (Finit_image_library): Wrap Vlibrary_cache on "#ifdef HAVE_NTGUI".
11682 2011-05-04 Juanma Barranquero <lekktu@gmail.com>
11684 Implement dynamic loading of GnuTLS on Windows.
11686 * gnutls.h (GNUTLS_EMACS_ERROR_NOT_LOADED): New macro.
11687 (emacs_gnutls_write, emacs_gnutls_read): Mark as extern.
11688 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
11691 * gnutls.c (Qgnutls_dll): Define.
11692 (DEF_GNUTLS_FN, LOAD_GNUTLS_FN): New macros.
11693 (gnutls_*): Declare function pointers.
11694 (init_gnutls_functions): New function to initialize function pointers.
11695 (emacs_gnutls_handshake, Fgnutls_error_string, Fgnutls_deinit)
11696 (emacs_gnutls_global_init, Fgnutls_bye): Use function pointers.
11697 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
11698 Wrappers for gnutls_record_check_pending and gnutls_transport_set_errno.
11699 (emacs_gnutls_write, emacs_gnutls_read)
11700 (emacs_gnutls_handle_error, Fgnutls_error_fatalp)
11701 (Fgnutls_available_p): New function.
11702 (Fgnutls_boot): Call Fgnutls_available_p. Use function pointers.
11703 (syms_of_gnutls) <Qgnutls_dll>: Initialize and staticpro it.
11704 (syms_of_gnutls) <Sgnutls_available_p>: defsubr it.
11706 * image.c: Include w32.h.
11707 (Vimage_type_cache): Delete.
11708 (syms_of_image) <Vimage_type_cache>: Don't initialize and staticpro it.
11709 (CACHE_IMAGE_TYPE, Finit_image_library): Use Vlibrary_cache instead.
11710 (w32_delayed_load): Move to w32.c.
11712 * w32.h (VlibraryCache, QCloaded_from, w32_delayed_load): Declare.
11714 * w32.c (QCloaded_from, Vlibrary_cache): Define.
11715 (w32_delayed_load): Move from image.c. When loading a library, record
11716 its filename in the :loaded-from property of the library id.
11717 (globals_of_w32) <QCloaded_from, Vlibrary_cache>:
11718 Initialize and staticpro them.
11719 (emacs_gnutls_pull, emacs_gnutls_push): Call emacs_gnutls_* functions.
11721 * process.c: Include lisp.h before w32.h, not after.
11722 (wait_reading_process_output): Call emacs_gnutls_record_check_pending
11723 instead of gnutls_record_check_pending.
11725 * callproc.c, emacs.c: Include lisp.h before w32.h, not after.
11727 2011-05-04 Teodor Zlatanov <tzz@lifelogs.com>
11729 * gnutls.c (Fgnutls_boot): Support :keylist and :crlfiles options
11730 instead of :keyfiles. Give GnuTLS the keylist and the CRL lists
11733 2011-05-03 Jan Djärv <jan.h.d@swipnet.se>
11735 * xterm.c (x_set_frame_alpha): Do not set property on anything
11736 else than FRAME_X_OUTER_WINDOW (Bug#8608).
11738 2011-05-02 Juanma Barranquero <lekktu@gmail.com>
11740 * sysdep.c (get_tty_size) [WINDOWSNT]: Implement. (Bug#8596)
11742 2011-05-02 Juanma Barranquero <lekktu@gmail.com>
11744 * gnutls.c (Qgnutls_log_level, Qgnutls_code, Qgnutls_anon)
11745 (Qgnutls_x509pki, Qgnutls_e_interrupted, Qgnutls_e_again)
11746 (Qgnutls_e_invalid_session, Qgnutls_e_not_ready_for_handshake)
11747 (gnutls_global_initialized, Qgnutls_bootprop_priority)
11748 (Qgnutls_bootprop_trustfiles, Qgnutls_bootprop_keyfiles)
11749 (Qgnutls_bootprop_callbacks, Qgnutls_bootprop_loglevel)
11750 (Qgnutls_bootprop_hostname, Qgnutls_bootprop_verify_flags)
11751 (Qgnutls_bootprop_verify_error, Qgnutls_bootprop_verify_hostname_error)
11752 (Qgnutls_bootprop_callbacks_verify): Make static.
11754 2011-05-01 Andreas Schwab <schwab@linux-m68k.org>
11756 * callproc.c: Indentation fixup.
11758 * sysdep.c (wait_for_termination_1): Make static.
11759 (wait_for_termination, interruptible_wait_for_termination):
11760 Move after wait_for_termination_1.
11762 2011-05-01 Lars Magne Ingebrigtsen <larsi@gnus.org>
11764 * sysdep.c (interruptible_wait_for_termination): New function
11765 which is like wait_for_termination, but allows keyboard
11768 * callproc.c (Fcall_process): Add (:file "file") as an option for
11770 (Fcall_process_region): Ditto.
11772 2011-04-30 Eli Zaretskii <eliz@gnu.org>
11774 * dosfns.c (Fint86, Fdos_memget, Fdos_memput): Use `ASIZE (FOO)'
11775 rather than `XVECTOR (FOO)->size'.
11777 * process.c: Remove HAVE_INTTYPES_H condition from inclusion of
11778 inttypes.h, as a gnulib replacement is used if it not available in
11781 2011-04-21 Eli Zaretskii <eliz@gnu.org>
11783 Lift the MOST_POSITIVE_FIXNUM/4 limitation on visited files.
11784 * fileio.c (Finsert_file_contents): Don't limit file size to 1/4
11785 of MOST_POSITIVE_FIXNUM. (Bug#8528)
11787 * coding.c (coding_alloc_by_realloc): Error out if destination
11788 will grow beyond MOST_POSITIVE_FIXNUM.
11789 (decode_coding_emacs_mule): Abort if there isn't enough place in
11790 charbuf for the composition carryover bytes. Reserve an extra
11791 space for up to 2 characters produced in a loop.
11792 (decode_coding_iso_2022): Abort if there isn't enough place in
11793 charbuf for the composition carryover bytes.
11795 2011-04-21 Eli Zaretskii <eliz@gnu.org>
11797 * doprnt.c (doprnt) [!HAVE_LONG_LONG_INT]: Error out instead of
11798 aborting when %lld or %lll format is passed.
11799 [!HAVE_UNSIGNED_LONG_LONG_INT]: Error out instead of aborting when
11800 %llo or %llx format is passed. (Bug#8545)
11802 * window.c (window_scroll_line_based): Use a marker instead of
11803 simple variables to record original value of point. (Bug#7952)
11805 * doprnt.c (doprnt): Fix the case where a multibyte sequence
11806 produced by %s or %c overflows available buffer space. (Bug#8545)
11808 2011-04-28 Paul Eggert <eggert@cs.ucla.edu>
11810 * doprnt.c (doprnt): Omit useless test; int overflow check (Bug#8545).
11811 (SIZE_MAX): Move defn after all includes, as they might #define it.
11813 2011-04-28 Juanma Barranquero <lekktu@gmail.com>
11815 * w32.c (init_environment): Warn about defaulting HOME to C:\.
11817 2011-04-28 Juanma Barranquero <lekktu@gmail.com>
11819 * keyboard.c (Qdelayed_warnings_hook): Define.
11820 (command_loop_1): Run `delayed-warnings-hook'
11821 if Vdelayed_warnings_list is non-nil.
11822 (syms_of_keyboard) <delayed-warnings-hook>: DEFSYM it.
11823 (syms_of_keyboard) <delayed-warnings-list>: DEFVAR_LISP it.
11825 2011-04-28 Eli Zaretskii <eliz@gnu.org>
11827 * doprnt.c (doprnt): Don't return value smaller than the buffer
11828 size if the message was truncated. (Bug#8545).
11830 2011-04-28 Juanma Barranquero <lekktu@gmail.com>
11832 * w32fns.c (Fx_change_window_property, Fx_delete_window_property)
11833 (Fx_window_property): #if-0 the whole functions, not just the bodies.
11835 2011-04-27 Paul Eggert <eggert@cs.ucla.edu>
11837 * doprnt.c (doprnt): Support "ll" length modifier, for long long.
11839 2011-04-27 Juanma Barranquero <lekktu@gmail.com>
11841 * makefile.w32-in: Update dependencies.
11843 2011-04-27 Eli Zaretskii <eliz@gnu.org>
11845 Improve `doprnt' and its usage. (Bug#8545)
11846 * doprnt.c (doprnt): Make sure `format' is never accessed beyond
11847 `format_end'. Remove support for %l as a conversion specifier.
11848 Don't use xrealloc. Improve diagnostics when the %l size modifier
11849 is used. Update the commentary.
11851 * eval.c (verror): Simplify calculation of size_t.
11853 * coding.c (Ffind_operation_coding_system): Fix diagnostic error
11856 2011-04-27 Yoshiaki Kasahara <kasahara@nc.kyushu-u.ac.jp> (tiny change)
11858 * buffer.c (init_buffer) [USE_MMAP_FOR_BUFFERS]: Adjust to aliasing
11861 2011-04-27 Paul Eggert <eggert@cs.ucla.edu>
11863 * nsmenu.m: Replace all uses of XVECTOR with ASIZE and AREF.
11864 This makes this file independent of the recent pseudovector change.
11866 2011-04-26 Paul Eggert <eggert@cs.ucla.edu>
11868 * keyboard.c (handle_user_signal): Fix pointer signedness problem.
11870 * gnutls.c (emacs_gnutls_handle_error): Remove unused local.
11871 (Fgnutls_boot): gnutls_certificate_verify_peers2 wants unsigned *.
11872 Remove unused local.
11873 (emacs_gnutls_write): Don't use uninitialized rtnval if nbyte <= 0.
11875 * lisp.h: Fix a problem with aliasing and vector headers. (Bug#8546)
11876 GCC 4.6.0 optimizes based on type-based alias analysis.
11877 For example, if b is of type struct buffer * and v of type struct
11878 Lisp_Vector *, then gcc -O2 was incorrectly assuming that &b->size
11879 != &v->size, and therefore "v->size = 1; b->size = 2; return
11880 v->size;" must therefore return 1. This assumption is incorrect
11881 for Emacs, since it type-puns struct Lisp_Vector * with many other
11882 types. To fix this problem, this patch adds a new type struct
11883 vectorlike_header that documents the constraints on layout of vectors
11884 and pseudovectors, and helps optimizing compilers not get fooled
11885 by Emacs's type punning. It also adds the macros XSETTYPED_PVECTYPE
11886 XSETTYPED_PSEUDOVECTOR, TYPED_PSEUDOVECTORP, for similar reasons.
11887 * lisp.h (XSETTYPED_PVECTYPE): New macro, specifying the name of
11889 (XSETPVECTYPE): Rewrite in terms of new macro.
11890 (XSETPVECTYPESIZE): New macro, specifying both type and size.
11891 This is a bit clearer, and further avoids the possibility of
11892 undesirable aliasing.
11893 (XSETTYPED_PSEUDOVECTOR): New macro, specifying the size.
11894 (XSETPSEUDOVECTOR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR.
11895 (XSETSUBR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR and XSIZE,
11896 since Lisp_Subr is a special case (no "next" field).
11897 (ASIZE): Now uses header.size rather than size.
11898 All previous uses of XVECTOR (foo)->size replaced to use this macro,
11899 to avoid the hassle of writing XVECTOR (foo)->header.size.
11900 (struct vectorlike_header): New type.
11901 (TYPED_PSEUDOVECTORP): New macro, also specifying the C type of the
11902 object, to help avoid aliasing.
11903 (PSEUDOVECTORP): Rewrite in terms of TYPED_PSEUDOVECTORP.
11904 (SUBRP): Likewise, since Lisp_Subr is a special case.
11905 * lisp.h (struct Lisp_Vector, struct Lisp_Char_Table):
11906 (struct Lisp_Sub_Char_Table, struct Lisp_Bool_Vector):
11907 (struct Lisp_Hash_Table): Combine first two members into a single
11908 struct vectorlike_header member. All uses of "size" and "next" members
11909 changed to be "header.size" and "header.next".
11910 * buffer.h (struct buffer): Likewise.
11911 * font.h (struct font_spec, struct font_entity, struct font): Likewise.
11912 * frame.h (struct frame): Likewise.
11913 * process.h (struct Lisp_Process): Likewise.
11914 * termhooks.h (struct terminal): Likewise.
11915 * window.c (struct save_window_data, struct saved_window): Likewise.
11916 * window.h (struct window): Likewise.
11917 * alloc.c (allocate_buffer, Fmake_bool_vector, allocate_pseudovector):
11918 Use XSETPVECTYPESIZE, not XSETPVECTYPE, to avoid aliasing problems.
11919 * buffer.c (init_buffer_once): Likewise.
11920 * lread.c (defsubr): Use XSETTYPED_PVECTYPE, since Lisp_Subr is a
11922 * process.c (Fformat_network_address): Use local var for size,
11925 * bytecode.c (exec_byte_code): Don't use XVECTOR before CHECK_VECTOR.
11927 Make the Lisp reader and string-to-float more consistent (Bug#8525)
11928 * data.c (atof): Remove decl; no longer used or needed.
11929 (digit_to_number): Move to lread.c.
11930 (Fstring_to_number): Use new string_to_number function, to be
11931 consistent with how the Lisp reader treats infinities and NaNs.
11932 Do not assume that floating-point numbers represent EMACS_INT
11933 without losing information; this is not true on most 64-bit hosts.
11934 Avoid double-rounding errors, by insisting on integers when
11935 parsing non-base-10 numbers, as the documentation specifies.
11936 * lisp.h (string_to_number): New decl, replacing ...
11937 (isfloat_string): Remove.
11938 * lread.c: Include <inttypes.h>, for uintmax_t and strtoumax.
11939 (read1): Do not accept +. and -. as integers; this
11940 appears to have been a coding error. Similarly, do not accept
11941 strings like +-1e0 as floating point numbers. Do not report
11942 overflow for integer overflows unless the base is not 10 which
11943 means we have no simple and reliable way to continue.
11944 Break out the floating-point parsing into a new
11945 function string_to_number, so that Fstring_to_number parses
11946 floating point numbers consistently with the Lisp reader.
11947 (digit_to_number): Move here from data.c. Make it static inline.
11948 (E_CHAR, EXP_INT): Remove, replacing with ...
11949 (E_EXP): New macro, to solve the "1.0e+" problem mentioned below.
11950 (string_to_number): New function, replacing isfloat_string.
11951 This function checks for valid syntax and produces the resulting
11952 Lisp float number too. Rework it so that string-to-number
11953 no longer mishandles examples like "1.0e+". Use strtoumax,
11954 so that overflow for non-base-10 numbers is reported only when
11955 there's no portable and simple way to convert to floating point.
11957 * textprop.c (set_text_properties_1): Rewrite for clarity,
11958 and to avoid GCC warning about integer overflow.
11960 * intervals.h (struct interval): Use EMACS_INT for members
11961 where EMACS_UINT might cause problems. See
11962 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html>.
11963 (CHECK_TOTAL_LENGTH): Remove cast to EMACS_INT; no longer needed.
11964 * intervals.c (interval_deletion_adjustment): Now returns EMACS_INT.
11966 (offset_intervals): Tell GCC not to worry about length overflow
11967 when negating a negative length.
11969 * alloc.c (overrun_check_malloc, overrun_check_realloc): Now static.
11970 (overrun_check_free): Likewise.
11972 * alloc.c (SDATA_SIZE) [!GC_CHECK_STRING_BYTES]: Avoid runtime check
11973 in the common case where SDATA_DATA_OFFSET is a multiple of Emacs
11976 * gnutls.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
11977 (gnutls_make_error): Rename local to avoid shadowing.
11978 (gnutls_emacs_global_deinit): ifdef out; not used.
11979 (Fgnutls_boot): Use const for pointer to readonly storage.
11980 Comment out unused local. Fix pointer signedness problems.
11982 * lread.c (openp): Don't stuff size_t into an 'int'.
11983 Use <= on length, not < on length + 1, to avoid GCC 4.6.0 warning
11984 about possible signed overflow.
11986 * gtkutil.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
11987 (GDK_KEY_g): Don't define if already defined.
11988 (xg_prepare_tooltip): Avoid pointer signedness problem.
11989 (xg_set_toolkit_scroll_bar_thumb): Redo to avoid two casts.
11991 * process.c (Fnetwork_interface_info): Avoid left-shift undefined
11992 behavior with 1 << 31. GCC 4.6.0 warns about this on 32-bit hosts.
11994 * xfns.c (Fx_window_property): Simplify a bit,
11995 to make a bit faster and to avoid GCC 4.6.0 warning.
11996 * xselect.c (x_get_window_property, x_handle_dnd_message): Likewise.
11998 * fns.c (internal_equal): Don't assume size_t fits in int.
12000 * alloc.c (compact_small_strings): Tighten assertion a little.
12002 Replace pEd with more-general pI, and fix some printf arg casts.
12003 * lisp.h (pI): New macro, generalizing old pEd macro to other
12004 conversion specifiers. For example, use "...%"pI"d..." rather
12005 than "...%"pEd"...".
12006 (pEd): Remove. All uses replaced with similar uses of pI.
12007 * m/amdx86-64.h, m/ia64.h, m/ibms390x.h: Likewise.
12008 * alloc.c (check_pure_size): Don't overflow by converting size to int.
12009 * bidi.c (bidi_dump_cached_states): Use pI to avoid cast.
12010 * data.c (Fnumber_to_string): Use pI instead of if-then-else-abort.
12011 * dbusbind.c (xd_append_arg): Use pI to avoid cast.
12012 (Fdbus_method_return_internal, Fdbus_method_error_internal): Likewise.
12013 * font.c (font_unparse_xlfd): Avoid potential buffer overrun on
12015 (font_unparse_xlfd, font_unparse_fcname): Use pI to avoid casts.
12016 * keyboard.c (record_char, modify_event_symbol): Use pI to avoid casts.
12017 * print.c (safe_debug_print, print_object): Likewise.
12018 (print_object): Don't overflow by converting EMACS_INT or EMACS_UINT
12020 Use pI instead of if-then-else-abort. Use %p to avoid casts,
12021 avoiding the 0 flag, which is not portable.
12022 * process.c (Fmake_network_process): Use pI to avoid cast.
12023 * region-cache.c (pp_cache): Likewise.
12024 * xdisp.c (decode_mode_spec): Likewise.
12025 * xrdb.c (x_load_resources) [USE_MOTIF]: Use pI to avoid undefined
12026 behavior on 64-bit hosts with printf arg.
12027 * xselect.c (x_queue_event): Use %p to avoid casts, avoiding 0 flag.
12028 (x_stop_queuing_selection_requests): Likewise.
12029 (x_get_window_property): Don't truncate byte count to an 'int'
12032 * frame.c (frame_name_fnn_p): Get rid of strtol, which isn't right
12033 here, since it parses constructs like leading '-' and spaces,
12034 which are not wanted; and it overflows with large numbers.
12035 Instead, simply match F[0-9]+, which is what is wanted anyway.
12037 * alloc.c: Remove unportable assumptions about struct layout.
12038 (SDATA_SELECTOR, SDATA_DATA_OFFSET): New macros.
12039 (SDATA_OF_STRING, SDATA_SIZE, allocate_string_data):
12040 (allocate_vectorlike, make_pure_vector): Use the new macros,
12041 plus offsetof, to remove unportable assumptions about struct layout.
12042 These assumptions hold on all porting targets that I know of, but
12043 they are not guaranteed, they're easy to remove, and removing them
12044 makes further changes easier.
12046 * alloc.c (BLOCK BYTES): Fix typo by changing "ablock" to "ablocks".
12047 This doesn't fix a bug but makes the code clearer.
12048 (string_overrun_cookie): Now const. Use initializers that
12049 don't formally overflow signed char, to avoid warnings.
12050 (allocate_string_data) [GC_CHECK_STRING_OVERRUN]: Fix typo that
12051 can cause Emacs to crash when string overrun checking is enabled.
12052 (allocate_buffer): Don't assume sizeof (struct buffer) is a
12053 multiple of sizeof (EMACS_INT); it need not be, if
12054 alignof(EMACS_INT) < sizeof (EMACS_INT).
12055 (check_sblock, check_string_bytes, check_string_free_list): Protoize.
12057 2011-04-26 Juanma Barranquero <lekktu@gmail.com>
12059 * keyboard.c (QCrtl): Rename from Qrtl. All uses changed.
12061 2011-04-26 Teodor Zlatanov <tzz@lifelogs.com>
12063 * gnutls.c (emacs_gnutls_handshake): Return an error if we're not
12064 supposed to be handshaking. (Bug#8556)
12065 Reported by Paul Eggert <eggert@cs.ucla.edu>.
12067 2011-04-26 Daniel Colascione <dan.colascione@gmail.com>
12069 * lisp.h (Qdebug): List symbol.
12070 * eval.c (Qdebug): Restore global linkage.
12071 * keyboard.c (debug-on-event): New variable.
12072 (handle_user_signal): Break into debugger when debug-on-event
12073 matches the current signal symbol.
12075 2011-04-25 Dan Nicolaescu <dann@ics.uci.edu>
12077 * alloc.c (check_sblock, check_string_bytes)
12078 (check_string_free_list): Convert to standard C.
12080 2011-04-25 Teodor Zlatanov <tzz@lifelogs.com>
12082 * w32.c (emacs_gnutls_push): Fix typo.
12084 2011-04-25 Eli Zaretskii <eliz@gnu.org>
12086 * gnutls.c (emacs_gnutls_handshake): Avoid compiler warnings about
12087 "cast to pointer from integer of different size".
12089 Improve doprnt and its use in verror. (Bug#8545)
12090 * doprnt.c (doprnt): Document the set of format control sequences
12091 supported by the function. Use SAFE_ALLOCA instead of always
12094 * eval.c (verror): Don't limit the buffer size at size_max-1, that
12095 is one byte too soon. Don't use xrealloc; instead xfree and
12098 2011-04-24 Teodor Zlatanov <tzz@lifelogs.com>
12100 * gnutls.h: Add GNUTLS_STAGE_CALLBACKS enum to denote we're in the
12103 * gnutls.c: Renamed global_initialized to
12104 gnutls_global_initialized. Added internals for the
12105 :verify-hostname-error, :verify-error, and :verify-flags
12106 parameters of `gnutls-boot' and documented those parameters in the
12107 docstring. Start callback support.
12108 (emacs_gnutls_handshake): Add Woe32 support. Retry handshake
12109 unless a fatal error occurred. Call gnutls_alert_send_appropriate
12110 on error. Return error code.
12111 (emacs_gnutls_write): Call emacs_gnutls_handle_error.
12112 (emacs_gnutls_read): Likewise.
12113 (Fgnutls_boot): Return handshake error code.
12114 (emacs_gnutls_handle_error): New function.
12115 (wsaerror_to_errno): Likewise.
12117 * w32.h (emacs_gnutls_pull): Add prototype.
12118 (emacs_gnutls_push): Likewise.
12120 * w32.c (emacs_gnutls_pull): New function for GnuTLS on Woe32.
12121 (emacs_gnutls_push): Likewise.
12123 2011-04-24 Claudio Bley <claudio.bley@gmail.com> (tiny change)
12125 * process.c (wait_reading_process_output): Check if GnuTLS
12126 buffered some data internally if no FDs are set for TLS
12129 * makefile.w32-in (OBJ2): Add gnutls.$(O).
12130 (LIBS): Link to USER_LIBS.
12131 ($(BLD)/gnutls.$(0)): New target.
12133 2011-04-24 Eli Zaretskii <eliz@gnu.org>
12135 * xdisp.c (handle_single_display_spec): Rename the
12136 display_replaced_before_p argument into display_replaced_p, to
12137 make it consistent with the commentary. Fix typos in the
12140 * textprop.c (syms_of_textprop): Remove dead code.
12141 (copy_text_properties): Delete obsolete commentary about an
12142 interface that was deleted long ago. Fix typos in the description
12145 * msdos.c (XMenuActivate, XMenuAddSelection): Adjust argument list
12146 to changes in oldXMenu/XMenu.h from 2011-04-16.
12147 <menu_help_message, prev_menu_help_message>: Constify.
12148 (IT_menu_make_room): menu->help_text is now `const char **';
12151 * msdos.h (XMenuActivate, XMenuAddSelection): Adjust prototypes
12152 to changes in oldXMenu/XMenu.h from 2011-04-16.
12153 (struct XMenu): Declare `help_text' `const char **'.
12155 * xfaces.c <Qunspecified>: Make extern again.
12157 * syntax.c: Include sys/types.h before including regex.h, as
12160 * doc.c (get_doc_string): Improve the format passed to `error'.
12162 * doprnt.c (doprnt): Improve commentary.
12164 * term.c (init_tty) [MSDOS]: Fix 1st argument to maybe_fatal.
12166 * Makefile.in (TAGS): Depend on $(M_FILE) and $(S_FILE), and scan
12169 * makefile.w32-in (globals.h): Add a dummy recipe, to make any
12170 changes in globals.h immediately force recompilation.
12171 (TAGS): Depend on $(CURDIR)/m/intel386.h and
12172 $(CURDIR)/s/ms-w32.h.
12173 (TAGS-gmake): Scan $(CURDIR)/m/intel386.h and $(CURDIR)/s/ms-w32.h.
12175 * character.c (Fchar_direction): Function deleted.
12176 (syms_of_character): Don't defsubr it.
12177 <char-direction-table>: Deleted.
12179 2011-04-23 Eli Zaretskii <eliz@gnu.org>
12181 Fix doprnt so it could be used again safely in `verror'. (Bug#8435)
12182 * doprnt.c: Include limits.h.
12183 (SIZE_MAX): New macro.
12184 (doprnt): Return a size_t value. 2nd arg is now size_t.
12185 Many local variables are now size_t instead of int or unsigned.
12186 Improve overflow protection. Support `l' modifier for integer
12187 conversions. Support %l conversion. Don't assume an EMACS_INT
12188 argument for integer conversions and for %c.
12190 * lisp.h (doprnt): Restore prototype.
12192 * makefile.w32-in ($(BLD)/callint.$(O)): Depend on
12193 $(SRC)/character.h.
12195 * Makefile.in (base_obj): Add back doprnt.o.
12197 * deps.mk (doprnt.o): Add back prerequisites.
12198 (callint.o): Depend on character.h.
12200 * eval.c (internal_lisp_condition_case): Include the handler
12201 representation in the error message.
12202 (verror): Call doprnt instead of vsnprintf. Fix an off-by-one bug
12203 when breaking from the loop.
12205 * xdisp.c (vmessage): Call doprnt instead of vsnprintf.
12207 * callint.c (Fcall_interactively): When displaying error message
12208 about invalid control letter, pass the character's codepoint, not
12209 a pointer to its multibyte form. Improve display of the character
12210 in octal and display also its hex code.
12212 * character.c (char_string): Use %x to display the (unsigned)
12213 codepoint of an invalid character, to avoid displaying a bogus
12216 * font.c (check_otf_features): Pass SDATA of SYMBOL_NAME to
12217 `error', not SYMBOL_NAME itself.
12219 * coding.c (Fencode_sjis_char, Fencode_big5_char): Use %c for
12220 character arguments to `error'.
12222 * charset.c (check_iso_charset_parameter): Fix incorrect argument
12223 to `error' in error message about FINAL_CHAR argument. Make sure
12224 FINAL_CHAR is a character, and use %c when it is passed as
12225 argument to `error'.
12227 2011-04-23 Eli Zaretskii <eliz@gnu.org>
12229 * s/ms-w32.h (localtime): Redirect to sys_localtime.
12231 * w32.c: Include <time.h>.
12232 (sys_localtime): New function.
12234 2011-04-23 Chong Yidong <cyd@stupidchicken.com>
12236 * xdisp.c (init_xdisp): Initialize echo_area_window (Bug#6451).
12238 * buffer.c (syms_of_buffer): Doc fix (Bug#6902).
12240 2011-04-23 Samuel Thibault <sthibault@debian.org> (tiny change)
12242 * sysdep.c (wait_for_termination): On GNU Hurd, kill returns -1 on
12243 zombies (Bug#8467).
12245 2011-04-19 Eli Zaretskii <eliz@gnu.org>
12247 * syntax.h (SETUP_SYNTAX_TABLE_FOR_OBJECT): Fix setting of
12248 gl_state.e_property when gl_state.object is Qt.
12250 * insdel.c (make_gap_larger): Remove limitation of buffer size
12253 2011-04-18 Chong Yidong <cyd@stupidchicken.com>
12255 * xdisp.c (lookup_glyphless_char_display)
12256 (produce_glyphless_glyph): Handle cons cell entry in
12257 glyphless-char-display.
12258 (Vglyphless_char_display): Document it.
12260 * term.c (produce_glyphless_glyph): Handle cons cell entry in
12261 glyphless-char-display.
12263 2011-04-17 Chong Yidong <cyd@stupidchicken.com>
12265 * xdisp.c (get_next_display_element): Remove unnecessary ifdefs.
12267 * termhooks.h (FRAME_WINDOW_P): Remove duplicated definitions.
12269 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): Add missing
12270 definition for no-X builds.
12272 2011-04-16 Paul Eggert <eggert@cs.ucla.edu>
12274 Static checks with GCC 4.6.0 and non-default toolkits.
12276 * s/sol2-6.h, s/unixware.h (PTY_TTY_NAME_SPRINTF): Protoize decl.
12278 * process.c (keyboard_bit_set): Define only if SIGIO.
12279 (send_process_trap): Mark it with NO_RETURN if it doesn't return.
12280 (send_process): Repair possible setjmp clobbering.
12282 * s/usg5-4-common.h (SETUP_SLAVE_PTY): Don't pass extra arg to 'fatal'.
12284 * eval.c: Include <stdio.h>, for vsnprintf on non-GNU/Linux hosts.
12286 * data.c (arith_error): Mark with NO_RETURN if it doesn't return.
12288 * alloc.c (bytes_used_when_full, SPARE_MEMORY, BYTES_USED):
12289 Define only if needed.
12291 * sysdep.c (_FILE_OFFSET_BITS): Make this hack even uglier
12292 by pacifying GCC about it. Maybe it's time to retire it?
12293 * xfaces.c (USG, __TIMEVAL__): Likewise.
12295 * dispextern.h (struct redisplay_interface): Rename param
12296 to avoid shadowing.
12297 * termhooks.h (struct terminal): Likewise.
12298 * xterm.c (xembed_send_message): Likewise.
12300 * insdel.c (make_gap_smaller): Define only if
12301 USE_MMAP_FOR_BUFFERS || REL_ALLOC || DOUG_LEA_MALLOC.
12303 * keyboard.c (read_char): Make a var volatile so longjmp won't clobber
12306 * emacs.c (MAX_HEAP_BSS_DIFF, my_edata): Move to where they're used,
12307 so that we aren't warned about unused symbols.
12309 * xfns.c (Fx_file_dialog): Rename local to avoid shadowing.
12311 * xdisp.c (x_produce_glyphs): Mark var as initialized (Bug#8512).
12313 * xfns.c (x_real_positions): Mark locals as initialized.
12315 * xmenu.c (xmenu_show): Don't use uninitialized vars.
12317 * xterm.c: Fix problems found by static analysis with other toolkits.
12318 (toolkit_scroll_bar_interaction): Define and use only if USE_X_TOOLKIT.
12319 (x_dispatch_event): Declare static if USE_GTK, and
12320 define if USE_GTK || USE_X_TOOLKIT.
12321 (SET_SAVED_BUTTON_EVENT): Define only if USE_X_TOOLKIT || USE_GTK.
12322 * xterm.h (x_dispatch_event): Extern only if USE_X_TOOLKIT.
12323 * xterm.c, xterm.h (x_mouse_leave): Bring this function back, but only
12324 if defined HAVE_MENUS && !defined USE_X_TOOLKIT && !defined USE_GTK.
12326 * xmenu.c (menu_help_callback): Pointer type fixes.
12327 Use const pointers when pointing at readonly data. Avoid pointer
12328 signedness clashes.
12329 (FALSE): Remove unused macro.
12330 (update_frame_menubar): Remove unused decl.
12332 * xfns.c (Fx_hide_tip): Move locals to avoid shadowing.
12334 * menu.c (push_submenu_start, push_submenu_end): Do not define unless
12335 USE_X_TOOLKIT || USE_GTK || HAVE_NS || defined HAVE_NTGUI.
12336 (single_menu_item): Rename local to avoid shadowing.
12338 * keyboard.c (make_lispy_event): Remove unused local var.
12340 * frame.c, frame.h (x_get_resource_string): Bring this back, but
12341 only if HAVE_X_WINDOWS && !USE_X_TOOLKIT.
12343 * bitmaps: Change bitmaps from unsigned char back to the X11
12344 compatible char. Avoid the old compiler warnings about
12345 out-of-range initializers by using, for example, '\xab' rather
12348 * xgselect.c (xgselect_initialize): Check vs interface
12349 even if ! (defined (USE_GTK) || defined (HAVE_GCONF)).
12351 * xmenu.c (xmenu_show): Rename parm to avoid shadowing.
12353 * xterm.c (x_create_toolkit_scroll_bar): Use const * for pointers
12354 to read-only memory.
12356 * fns.c (vector): Remove; this old hack is no longer needed.
12358 * xsmfns.c (create_client_leader_window): Rename shadowing arg.
12360 (gdk_x11_set_sm_client_id) [!USE_GTK]: Don't define.
12362 * xrdb.c (x_load_resources): Omit unused local.
12364 * xfns.c (free_frame_menubar, atof): Remove duplicate decls.
12365 (x_window): Rename locals to avoid shadowing.
12366 (USG): Use the kludged USG macro, to pacify gcc.
12368 * xterm.c (x_alloc_nearest_color_for_widget): Remove; unused.
12369 (x_term_init): Remove local to avoid shadowing.
12371 * xfns.c, xterm.c (_XEditResCheckMessages): Protoize decl.
12373 * xdisp.c, dispextern.h (set_vertical_scroll_bar): Now extern if
12374 USE_TOOLKIT_SCROLL_BARS && !USE_GTK, as xterm.c needs it then.
12376 2011-04-16 Eli Zaretskii <eliz@gnu.org>
12378 * gnutls.c (Fgnutls_boot): Don't pass Lisp_Object to `error'.
12380 Fix regex.c, syntax.c and friends for buffers > 2GB.
12381 * syntax.h (struct gl_state_s): Declare character position members
12384 * syntax.c (update_syntax_table): Declare 2nd argument EMACS_INT.
12386 * textprop.c (verify_interval_modification, interval_of):
12387 Declare arguments EMACS_INT.
12389 * intervals.c (adjust_intervals_for_insertion): Declare arguments
12392 * intervals.h (CHECK_TOTAL_LENGTH): Cast to EMACS_INT, not `int'.
12394 * indent.c (Fvertical_motion): Local variable it_start is now
12397 * regex.c (re_match, re_match_2, re_match_2_internal)
12398 (bcmp_translate, regcomp, regexec, print_double_string)
12399 (group_in_compile_stack, re_search, re_search_2, regex_compile)
12400 (re_compile_pattern, re_exec): Declare arguments and local
12401 variables `size_t' and `ssize_t' and return values `regoff_t', as
12403 (POP_FAILURE_REG_OR_COUNT) <pfreg>: Declare `long'.
12404 (CHECK_INFINITE_LOOP) <failure>: Declare `ssize_t'.
12405 <compile_stack_type>: `size' and `avail' are now `size_t'.
12407 * regex.h <regoff_t>: Use ssize_t, not int.
12408 (re_search, re_search_2, re_match, re_match_2): Arguments that
12409 specify buffer/string position and length are now ssize_t and
12410 size_t. Return type is regoff_t.
12412 2011-04-16 Ben Key <bkey76@gmail.com>
12414 * nsfont.m: Fixed bugs in ns_get_family and
12415 ns_descriptor_to_entity that were caused by using free to
12416 deallocate memory blocks that were allocated by xmalloc (via
12417 xstrdup). This caused Emacs to crash when compiled with
12418 XMALLOC_OVERRUN_CHECK defined (when Emacs was configured with
12419 --enable-checking=xmallocoverrun). xfree is now used to
12420 deallocate these memory blocks.
12422 2011-04-15 Paul Eggert <eggert@cs.ucla.edu>
12424 * sysdep.c (emacs_read): Remove unnecessary check vs MAX_RW_COUNT.
12426 emacs_write: Accept and return EMACS_INT for sizes.
12427 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html
12429 * gnutls.c, gnutls.h (emacs_gnutls_read, emacs_gnutls_write):
12430 Accept and return EMACS_INT.
12431 (emacs_gnutls_write): Return the number of bytes written on
12433 * sysdep.c, lisp.h (emacs_read, emacs_write): Likewise.
12434 (emacs_read, emacs_write): Remove check for negative size, as the
12435 Emacs source code has been audited now.
12436 * sysdep.c (MAX_RW_COUNT): New macro, to work around kernel bugs.
12437 (emacs_read, emacs_write): Use it.
12438 * process.c (send_process): Adjust to the new signatures of
12439 emacs_write and emacs_gnutls_write. Do not attempt to store
12440 a byte offset into an 'int'; it might overflow.
12441 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00483.html
12443 * sound.c: Don't assume sizes fit in 'int'.
12444 (struct sound_device.period_size, alsa_period_size):
12445 Return EMACS_INT, not int.
12446 (struct sound_device.write, vox_write, alsa_write):
12447 Accept EMACS_INT, not int.
12448 (wav_play, au_play): Use EMACS_INT to store sizes and to
12449 record read return values.
12451 2011-04-15 Ben Key <bkey76@gmail.com>
12453 * keyboard.c (Qundefined): Don't declare static since it is used
12455 * xfaces.c (Qbold, Qexpanded, Qitalic, Qcondensed): Don't declare
12456 static since they are used in nsfont.m.
12458 2011-04-15 Stefan Monnier <monnier@iro.umontreal.ca>
12460 * process.c (Qprocessp): Don't declare static.
12461 * lisp.h (Qprocessp): Declare again.
12463 2011-04-15 Juanma Barranquero <lekktu@gmail.com>
12465 * font.c (Qopentype): Don't make static (used from w32uniscribe.c).
12467 2011-04-14 Paul Eggert <eggert@cs.ucla.edu>
12469 Improve C-level modularity by making more things 'static'.
12471 Don't publish debugger-only interfaces to other modules.
12472 * lisp.h (safe_debug_print, debug_output_compilation_hack):
12473 (verify_bytepos, count_markers): Move decls to the only modules
12475 * region-cache.h (pp_cache): Likewise.
12476 * window.h (check_all_windows): Likewise.
12477 * marker.c, print.c, region-cache.c, window.c: Decls moved here.
12479 * sysdep.c (croak): Now static, if
12480 defined TIOCNOTTY || defined USG5 || defined CYGWIN.
12481 * syssignal.h (croak): Declare only if not static.
12483 * alloc.c (refill_memory_reserve): Now static if
12484 !defined REL_ALLOC || defined SYSTEM_MALLOC.
12485 * lisp.h (refill_memory_reserve): Declare only if not static.
12487 * xsettings.c, xsettings.h (xsettings_get_system_normal_font):
12488 Define only if USE_LUCID.
12490 * xrdb.c (x_customization_string, x_rm_string): Now static.
12492 * xmenu.c (x_menu_wait_for_event): Export only if USE_MOTIF.
12493 * xterm.h (x_menu_wait_for_event): Declare only if USE_MOTIF.
12495 * xdisp.c (draw_row_with_mouse_face): Now static.
12496 * dispextern.h (draw_row_with_mouse_fave): Remove decl.
12498 * window.h (check_all_windows): Mark externally visible.
12500 * window.c (window_deletion_count): Now static.
12502 * undo.c: Make symbols static if they're not exported.
12503 (last_undo_buffer, last_boundary_position, pending_boundary):
12506 * textprop.c (interval_insert_behind_hooks): Now static.
12507 (interval_insert_in_front_hooks): Likewise.
12509 * term.c: Make symbols static if they're not exported.
12510 (tty_turn_off_highlight, get_tty_terminal, max_frame_cols):
12511 (max_frame_lines, tty_set_terminal_modes):
12512 (tty_reset_terminal_modes, tty_turn_off_highlight):
12513 (get_tty_terminal): Now static.
12514 (term_mouse_moveto): Do not define if HAVE_WINDOW_SYSTEM.
12515 * termhooks.h (term_mouse_moveto): Do not declare if
12516 HAVE_WINDOW_SYSTEM.
12517 * dispextern.h (tty_set_terminal_modes, tty_reset_terminal_modes):
12518 (tty_turn_off_highlight, get_tty_terminal): Remove decls.
12520 * sysdep.c: Make symbols static if they're not exported.
12521 (emacs_get_tty, emacs_set_tty, old_fcntl_flags, old_fcntl_owner):
12523 (sigprocmask_set, full_mask): Remove; unused.
12524 (wait_debugging): Mark as visible.
12525 * syssignal.h (SIGFULLMASK, full_mask): Remove decls.
12526 * systty.h (emacs_get_tty, emacs_set_tty): Remove decls.
12528 * syntax.c (syntax_temp): Define only if !__GNUC__.
12530 * sound.c (current_sound_device, current_sound): Now static.
12532 * search.c (searchbufs, searchbuf_head): Now static.
12534 * scroll.c (scroll_cost): Remove; unused.
12535 * dispextern.h (scroll_cost): Remove decl.
12537 * region-cache.h (pp_cache): Mark as externally visible.
12539 * process.c: Make symbols static if they're not exported.
12540 (process_tick, update_tick, create_process, chan_process):
12541 (Vprocess_alist, proc_buffered_char, datagram_access):
12542 (fd_callback_data, send_process_frame, process_sent_to): Now static.
12543 (deactivate_process): Mark defn as static, as well as decl.
12544 * lisp.h (create_process): Remove decl.
12545 * process.h (chan_process, Vprocess_alist): Remove decls.
12547 * print.c: Make symbols static if they're not exported.
12548 (print_depth, new_backquote_output, being_printed, print_buffer):
12549 (print_buffer_size, print_buffer_pos, print_buffer_pos_byte):
12550 (print_interval, print_number_index, initial_stderr_stream):
12552 * lisp.h (Fprinc): Remove decl.
12553 (debug_output_compilation_hack): Mark as externally visible.
12555 * sysdep.c (croak): Move decl from here to syssignal.h.
12556 * syssignal.h (croak): Put it here, so the API can be checked when
12557 'croak' is called from dissociate_if_controlling_tty.
12559 * minibuf.c: Make symbols static if they're not exported.
12560 (minibuf_save_list, choose_minibuf_frame): Now static.
12561 * lisp.h (choose_minibuf_frame): Remove decl.
12563 * lisp.h (verify_bytepos, count_markers): Mark as externally visible.
12565 * lread.c: Make symbols static if they're not exported.
12566 (read_objects, initial_obarray, oblookup_last_bucket_number):
12568 (make_symbol): Remove; unused.
12569 * lisp.h (initial_obarray, make_symbol): Remove decls.
12571 * keyboard.c: Make symbols static if they're not exported.
12572 (single_kboard, recent_keys_index, total_keys, recent_keys):
12573 (this_command_key_count_reset, raw_keybuf, raw_keybuf_count):
12574 (this_single_command_key_start, echoing, last_auto_save):
12575 (read_key_sequence_cmd, dribble, recursive_edit_unwind):
12576 (command_loop, echo_now, keyboard_init_hook, help_char_p):
12577 (quit_throw_to_read_char, command_loop_2, top_level_1, poll_timer):
12578 (Vlispy_mouse_stem, double_click_count):
12580 (force_auto_save_soon): Define only if SIGDANGER.
12581 (ignore_mouse_drag_p): Now static if
12582 !defined HAVE_WINDOW_SYSTEM || defined USE_GTK || defined HAVE_NS.
12583 (print_help): Remove; unused.
12584 (stop_character, last_timer_event): Mark as externally visible.
12585 * keyboard.h (ignore_mouse_drag_p): Declare only if
12586 defined HAVE_WINDOW_SYSTEM && !defined USE_GTK && !defined HAVE_NS.
12587 (echo_now, help_char_p, quit_throw_to_read_char): Remove decls.
12588 * lisp.h (echoing): Remove decl.
12589 (force_auto_save_soon): Declare only if SIGDANGER.
12590 * xdisp.c (redisplay_window): Simplify code, to make it more
12591 obvious that ignore_mouse_drag_p is not accessed if !defined
12592 USE_GTK && !defined HAVE_NS.
12594 * intervals.c: Make symbols static if they're not exported.
12595 (merge_properties_sticky, merge_interval_right, delete_interval):
12597 * intervals.h (merge_interval_right, delete_interval): Remove decls.
12599 * insdel.c: Make symbols static if they're not exported.
12600 However, leave prepare_to_modify_buffer alone. It's never
12601 called from outside this function, but that appears to be a bug.
12602 (combine_after_change_list, combine_after_change_buffer):
12603 (adjust_after_replace, signal_before_change): Now static.
12604 (adjust_after_replace_noundo): Remove; unused.
12605 * lisp.h (adjust_after_replace, adjust_after_replace_noundo):
12606 (signal_before_change): Remove decls.
12608 * indent.c (val_compute_motion, val_vmotion): Now static.
12610 * image.c: Make symbols static if they're not exported.
12611 * dispextern.h (x_create_bitmap_from_xpm_data): Do not declare
12613 * image.c (x_create_bitmap_from_xpm_data): Do not define if USE_GTK.
12614 (xpm_color_cache, ct_table, ct_colors_allocated): Now static.
12616 * fringe.c (standard_bitmaps): Now static.
12617 (max_used_fringe_bitmap): Now static, unless HAVE_NS.
12619 * frame.c: Make symbols static if they're not exported.
12620 (x_report_frame_params, make_terminal_frame): Now static.
12621 (get_frame_param): Now static, unless HAVE_NS.
12622 (x_fullscreen_adjust): Define if WINDOWSNT, not if HAVE_WINDOW_SYSTEM.
12623 (x_get_resource_string): Remove; not used.
12624 * frame.h (make_terminal_frame, x_report_frame_params):
12625 (x_get_resource_string); Remove decls.
12626 (x_fullscreen_adjust): Declare only if WINDOWSNT.
12627 * lisp.h (get_frame_param): Declare only if HAVE_NS.
12629 * font.c, fontset.c: Make symbols static if they're not exported.
12630 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): New macro.
12631 (FACE_SUITABLE_FOR_CHAR_P): Use it.
12632 * font.c (font_close_object): Now static.
12633 * font.h (font_close_object): Remove.
12634 * fontset.c (FONTSET_OBJLIST): Remove.
12635 (free_realized_fontset) #if-0 the body, which does nothing.
12636 (face_suitable_for_char_p): #if-0, as it's never called.
12637 * fontset.h (face_suitable_for_char_p): Remove decl.
12638 * xfaces.c (face_at_string_position):
12639 Use FACE_SUITABLE_FOR_ASCII_CHAR_P, not FACE_SUITABLE_FOR_CHAR_P,
12640 since 0 is always ASCII.
12642 * fns.c (weak_hash_tables): Now static.
12644 * fileio.c: Make symbols static if they're not exported.
12645 (auto_saving, auto_save_mode_bits, auto_save_error_occurred):
12646 (Vwrite_region_annotation_buffers): Now static.
12648 * eval.c: Make symbols static if they're not exported.
12649 (backtrace_list, lisp_eval_depth, when_entered_debugger): Now static.
12650 * lisp.h (backtrace_list): Remove decl.
12652 * emacs.c: Make symbols static if they're not exported.
12653 (malloc_state_ptr, malloc_using_checking, syms_of_emacs):
12654 (fatal_error_code, fatal_error_signal_hook, standard_args):
12656 (fatal_error_signal): Now static, unless FLOAT_CATCH_SIGKILL.
12657 (DEFINE_DUMMY_FUNCTION): Mark function as externally visible.
12658 (__CTOR_LIST__, __DTOR_LIST__): Now externally visible.
12659 * lisp.h (fatal_error_signal_hook): Remove decl.
12660 (fatal_error_signal): Declare only if FLOAT_CATCH_SIGKILL.
12662 * editfns.c: Move a (normally-unused) function to its only use.
12663 * editfns.c, lisp.h (get_operating_system_release): Remove.
12664 * process.c (init_process) [DARWIN_OS]: Do it inline, as it is not
12665 worth the hassle of breaking this out.
12667 * xterm.c: Make symbols static if they're not exported.
12668 (x_raise_frame, x_lower_frame, x_wm_set_window_state):
12669 (x_wm_set_icon_pixmap, x_initialize, XTread_socket_fake_io_error):
12670 (x_destroy_window, x_delete_display):
12672 (x_dispatch_event): Now static if ! (USE_MOTIF || USE_X_TOOLKIT).
12673 (x_mouse_leave): Remove; unused.
12674 * xterm.h (x_display_info_for_name, x_raise_frame, x_lower_frame):
12675 (x_destroy_window, x_wm_set_window_state, x_wm_set_icon_pixmap):
12676 (x_delete_display, x_initialize, x_set_border_pixel, x_screen_planes):
12678 (x_mouse_leave): Declare only if WINDOWSNT.
12679 (x_dispatch_event): Declare only if USE_MOTIF or USE_X_TOOLKIT.
12680 (xic_create_fontsetname): Declare only if HAVE_X_WINDOWS &&
12683 * ftxfont.c: Make symbols static if they're not exported.
12684 (ftxfont_driver): Export only if !defined HAVE_XFT && def8ined
12686 * font.h (ftxfont_driver): Likewise.
12688 * xfns.c: Make symbols static if they're not exported.
12689 (x_last_font_name, x_display_info_for_name):
12690 (x_set_foreground_color, x_set_background_color, x_set_mouse_color):
12691 (x_set_cursor_color, x_set_border_pixel, x_set_border_color):
12692 (x_set_cursor_type, x_set_icon_type, x_set_icon_name):
12693 (x_set_scroll_bar_foreground, x_set_scroll_bar_background):
12694 (x_explicitly_set_name, x_set_title, xic_defaut_fontset, tip_timer):
12695 (last_show_tip_args): Now static.
12696 (xic_defaut_fontset, xic_create_fontsetname): Define only if
12697 defined HAVE_X_WINDOWS && defined USE_X_TOOLKIT
12698 (x_screen_planes): Remove; unused.
12699 * dispextern.h (x_screen_planes): Remove decl.
12701 * dispnew.c: Make symbols static if they're not exported.
12702 * dispextern.h (redraw_garbaged_frames, scrolling):
12703 (increment_row_positions): Remove.
12704 * dispnew.c (new_glyph_matrix, increment_row_positions, scrolling):
12705 (delayed_size_change, glyph_matrix_count, glyph_pool_count):
12707 (redraw_garbaged_frames): Remove; unused.
12709 * xfaces.c: Make symbols static if they're not exported.
12710 * dispextern.h (ascii_face_of_lisp_face, free_realized_face):
12712 * xterm.h (defined_color): Remove decls.
12713 (x_free_dpy_colors): Declare only if USE_X_TOOLKIT.
12714 * xfaces.c (tty_suppress_bold_inverse_default_colors_p):
12715 (menu_face_changed_default, defined_color, free_realized_face):
12716 (x_free_dpy_colors): Define only if USE_X_TOOLKIT.
12717 (ascii_face_of_lisp_face): Remove; unused.
12719 * xdisp.c: Make symbols static if they're not exported.
12720 * dispextern.h (scratch_glyph_row, window_box_edges):
12721 (glyph_to_pixel_coords, set_cursor_from_row):
12722 (get_next_display_element, set_iterator_to_next):
12723 (highlight_trailing_whitespace, frame_to_window_pixel_xy):
12724 (show_mouse_face): Remove decls
12725 * frame.h (message_buf_print): Likewise.
12726 * lisp.h (pop_message, set_message, check_point_in_composition):
12728 * xterm.h (set_vertical_scroll_bar): Likewise.
12729 * xdisp.c (list_of_error, Vmessage_stack, line_number_displayed):
12730 (message_buf_print, scratch_glyph_row, displayed_buffer):
12731 (set_iterator_to_next, pop_message, set_message, set_cursor_from_row):
12732 (get_next_display_element, show_mouse_face, window_box_edges):
12733 (frame_to_window_pixel_xy, check_point_in_composition):
12734 (set_vertical_scroll_bar, highlight_trailing_whitespace): Now static.
12735 (glyph_to_pixel_coords): Remove; unused.
12737 * dired.c (file_name_completion): Now static.
12739 * dbusbind.c (xd_in_read_queued_messages): Now static.
12741 * lisp.h (circular_list_error, FOREACH): Remove; unused.
12742 * data.c (circular_list_error): Remove.
12744 * commands.h (last_point_position, last_point_position_buffer):
12745 (last_point_position_window): Remove decls.
12746 * keyboard.c: Make these variables static.
12748 * coding.h (coding, code_convert_region, encode_coding_gap):
12750 * coding.c (Vsjis_coding_system, Vbig5_coding_system):
12751 (iso_code_class, detect_coding, code_convert_region): Now static.
12752 (encode_coding_gap): Remove; unused.
12754 * chartab.c (chartab_chars, chartab_bits): Now static.
12756 * charset.h (charset_iso_8859_1): Remove decl.
12757 * charset.c (charset_iso_8859_1, charset_emacs, map_charset_for_dump):
12760 * ccl.h (check_ccl_update, Vccl_program_table): Remove decls.
12761 * ccl.c (Vccl_program_table): Now static.
12762 (check_ccl_update): Remove; unused.
12764 * category.c (SET_CATEGORY_SET, set_category_set): Move here.
12765 * category.h: ... from here.
12766 * category.c (check_category_table, set_category_set): Now static.
12768 * casetab.c (Vascii_upcase_table, Vascii_eqv_table): Now static.
12769 * lisp.h: Remove these decls.
12771 * buffer.c (buffer_count): Remove unused var.
12773 * bidi.c (bidi_dump_cached_states): Mark as externally visible,
12774 so that it's not optimized away.
12775 (bidi_ignore_explicit_marks_for_paragraph_level): Likewise.
12776 * dispextern.h (bidi_dump_cached_states): Remove, since it's
12777 exported only to the debugger.
12779 * atimer.c (alarm_signal_handler, run_all_atimers): Now static.
12780 * atimer.h (run_all_atimers): Remove; not exported.
12782 font.c: Make copy_font_spec and merge_font_spec ordinary C functions.
12783 * font.c (copy_font_spec): Rename from Fcopy_font_spec, since it
12784 was inaccessible from Lisp.
12785 (merge_font_spec): Likewise, renaming from Fmerge_font_spec.
12786 * font.c, font.h, fontset.c, xfaces.c, xfont.c: Change all uses.
12788 alloc.c: Import and export fewer symbols, and remove unused items.
12789 * lisp.h (suppress_checking, die): Declare only if ENABLE_CHECKING
12791 (suppress_checking): Add EXTERNALLY_VISIBLE attribute, so that
12792 it's not optimized away by whole-program optimization.
12793 (message_enable_multibyte, free_misc): Remove.
12794 (catchlist, handlerlist, mark_backtrace):
12795 Declare only if BYTE_MARK_STACK.
12796 (mark_byte_stack): Likewise, fixing a ifdef-vs-if typo.
12797 * alloc.c (pure): Export only if VIRT_ADDR_VARIES is defined.
12798 (message_enable_multibyte): Remove decl.
12799 (free_misc, interval_free_list, float_block, float_block_index):
12800 (n_float_blocks, float_free_list, cons_block, cons_block_index):
12801 (cons_free_list, last_marked_index):
12803 (suppress_checking, die): Define only if ENABLE_CHECKING is defined.
12804 * eval.c (catchlist, handlerlist): Export only if BYTE_MARK_STACK.
12805 (mark_backtrace): Define only if BYTE_MARK_STACK.
12806 * xdisp.c (message_enable_multibyte): Now static.
12808 Declare Lisp_Object Q* variables to be 'static' if not exported.
12809 This makes it easier for human readers (and static analyzers)
12810 to see whether these variables are used from other modules.
12811 * alloc.c, buffer.c, bytecode.c, callint.c, casetab.c, category.c:
12812 * ccl.c, character.c, charset.c, cmds.c, coding.c, composite.c:
12813 * data.c, dbusbind.c, dired.c, editfns.c, eval.c, fileio.c, fns.c:
12814 * font.c, frame.c, fringe.c, ftfont.c, image.c, keyboard.c, keymap.c:
12815 * lread.c, macros.c, minibuf.c, print.c, process.c, search.c:
12816 * sound.c, syntax.c, textprop.c, window.c, xdisp.c, xfaces.c, xfns.c:
12817 * xmenu.c, xselect.c:
12818 Declare Q* vars static if they are not used in other modules.
12819 * ccl.h, character.h, charset.h, coding.h, composite.h, font.h:
12820 * frame.h, intervals.h, keyboard.h, lisp.h, process.h, syntax.h:
12821 Remove decls of unexported vars.
12822 * keyboard.h (EVENT_HEAD_UNMODIFIED): Remove now-unused macro.
12824 * lisp.h (DEFINE_FUNC): Make sname 'static'.
12826 Make Emacs functions such as Fatom 'static' by default.
12827 This makes it easier for human readers (and static analyzers)
12828 to see whether these functions can be called from other modules.
12829 DEFUN now defines a static function. To make the function external
12830 so that it can be used in other C modules, use the new macro DEFUE.
12831 * lisp.h (Funibyte_char_to_multibyte, Fsyntax_table_p):
12832 (Finit_image_library):
12833 (Feval_region, Fbacktrace, Ffetch_bytecode, Fswitch_to_buffer):
12834 (Ffile_executable_p, Fmake_symbolic_link, Fcommand_execute):
12835 (Fget_process, Fdocumentation_property, Fbyte_code, Ffile_attributes):
12836 Remove decls, since these functions are now static.
12837 (Funintern, Fget_internal_run_time): New decls, since these functions
12838 were already external.
12840 * alloc.c, buffer.c, callint.c, callproc.c, casefiddle.c, casetab.c:
12841 * ccl.c, character.c, chartab.c, cmds.c, coding.c, data.c, dispnew.c:
12842 * doc.c, editfns.c, emacs.c, eval.c, fileio.c, filelock.c, floatfns.c:
12843 * fns.c, font.c, fontset.c, frame.c, image.c, indent.c:
12844 * keyboard.c, keymap.c, lread.c:
12845 * macros.c, marker.c, menu.c, minibuf.c, print.c, process.c, search.c:
12846 * syntax.c, term.c, terminal.c, textprop.c, undo.c:
12847 * window.c, xdisp.c, xfaces.c, xfns.c, xmenu.c, xsettings.c:
12848 Mark functions with DEFUE instead of DEFUN,
12849 if they are used in other modules.
12850 * buffer.c (Fset_buffer_major_mode, Fdelete_overlay): New forward
12851 decls for now-static functions.
12852 * buffer.h (Fdelete_overlay): Remove decl.
12853 * callproc.c (Fgetenv_internal): Mark as internal.
12854 * composite.c (Fremove_list_of_text_properties): Remove decl.
12855 (Fcomposition_get_gstring): New forward static decl.
12856 * composite.h (Fcomposite_get_gstring): Remove decl.
12857 * dired.c (Ffile_attributes): New forward static decl.
12858 * doc.c (Fdocumntation_property): New forward static decl.
12859 * eval.c (Ffetch_bytecode): New forward static decl.
12860 (Funintern): Remove extern decl; now in .h file where it belongs.
12861 * fileio.c (Fmake_symbolic_link): New forward static decl.
12862 * image.c (Finit_image_library): New forward static decl.
12863 * insdel.c (Fcombine_after_change_execute): Make forward decl static.
12864 * intervals.h (Fprevious_property_change):
12865 (Fremove_list_of_text_properties): Remove decls.
12866 * keyboard.c (Fthis_command_keys): Remove decl.
12867 (Fcommand_execute): New forward static decl.
12868 * keymap.c (Flookup_key): New forward static decl.
12869 (Fcopy_keymap): Now static.
12870 * keymap.h (Flookup_key): Remove decl.
12871 * process.c (Fget_process): New forward static decl.
12872 (Fprocess_datagram_address): Mark as internal.
12873 * syntax.c (Fsyntax_table_p): New forward static decl.
12874 (skip_chars): Remove duplicate decl.
12875 * textprop.c (Fprevious_property_change): New forward static decl.
12876 * window.c (Fset_window_fringes, Fset_window_scroll_bars):
12878 (Fset_window_margins, Fset_window_vscroll): New forward static decls.
12879 * window.h (Fset_window_vscroll, Fset_window_margins): Remove decls.
12881 * editfns.c (Fformat): Remove unreachable code.
12883 2011-04-14 Andreas Schwab <schwab@linux-m68k.org>
12885 * fileio.c (Finsert_file_contents): Fix typo in 2005-05-13
12888 2011-04-13 Eli Zaretskii <eliz@gnu.org>
12890 * xdisp.c (handle_invisible_prop): Don't call bidi_paragraph_init
12891 when at ZV. (Bug#8487)
12893 2011-04-12 Andreas Schwab <schwab@linux-m68k.org>
12895 * charset.c (Fclear_charset_maps): Use xfree instead of free.
12897 * keyboard.c (parse_tool_bar_item): Likewise.
12898 * sound.c (sound_cleanup, alsa_close): Likewise.
12899 * termcap.c (tgetent): Likewise.
12900 * xfns.c (x_default_font_parameter): Likewise.
12901 * xsettings.c (read_and_apply_settings): Likewise.
12903 * alloc.c (overrun_check_malloc, overrun_check_realloc)
12904 (overrun_check_free): Protoize.
12906 2011-04-12 Paul Eggert <eggert@cs.ucla.edu>
12908 * sysdep.c (emacs_read, emacs_write): Check for negative sizes
12909 since callers should never pass a negative size.
12910 Change the signature to match that of plain 'read' and 'write'; see
12911 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00397.html>.
12912 * lisp.h: Update prototypes of emacs_write and emacs_read.
12914 2011-04-11 Eli Zaretskii <eliz@gnu.org>
12916 * xdisp.c (redisplay_window): Don't try to determine the character
12917 position of the scroll margin if the window start point w->startp
12918 is outside the buffer's accessible region. (Bug#8468)
12920 2011-04-10 Eli Zaretskii <eliz@gnu.org>
12922 Fix write-region and its subroutines for buffers > 2GB.
12923 * fileio.c (a_write, e_write): Modify declaration of arguments and
12924 local variables to support buffers larger than 2GB.
12925 (Fcopy_file): Use EMACS_INT for return value of emacs_read.
12927 * sysdep.c (emacs_write, emacs_read): Use ssize_t for last
12928 argument, local variables, and return value.
12930 * lisp.h: Update prototypes of emacs_write and emacs_read.
12932 * sound.c (vox_write): Use ssize_t for return value of emacs_write.
12934 2011-04-10 Paul Eggert <eggert@cs.ucla.edu>
12936 * xdisp.c (vmessage): Use memchr, not strnlen, which some hosts lack.
12938 Fix more problems found by GCC 4.6.0's static checks.
12940 * xdisp.c (vmessage): Use a better test for character truncation.
12942 * charset.c (load_charset_map): <, not <=, for optimization,
12943 and to avoid potential problems with integer overflow.
12944 * chartab.c (sub_char_table_set_range, char_table_set_range): Likewise.
12945 * casetab.c (set_identity, shuffle): Likewise.
12946 * editfns.c (Fformat): Likewise.
12947 * syntax.c (skip_chars): Likewise.
12949 * xmenu.c (set_frame_menubar): Allocate smaller local vectors.
12950 This also lets GCC 4.6.0 generate slightly better loop code.
12952 * callint.c (Fcall_interactively): <, not <=, for optimization.
12953 (Fcall_interactively): Count the number of arguments produced,
12954 not the number of arguments given. This is simpler and lets GCC
12955 4.6.0 generate slightly better code.
12957 * ftfont.c: Distingish more carefully between FcChar8 and char.
12958 The previous code passed unsigned char * to a functions like
12959 strlen and xstrcasecmp that expect char *, which does not
12960 conform to the C standard.
12961 (get_adstyle_property, ftfont_pattern_entity): Use FcChar8 for
12962 arguments to FcPatternGetString, and explicitly cast FcChar8 * to
12963 char * when the C standard requires it.
12965 * keyboard.c (read_char): Remove unused var.
12967 * eval.c: Port to Windows vsnprintf (Bug#8435).
12968 Include <limits.h>.
12969 (SIZE_MAX): Define if the headers do not.
12970 (verror): Do not give up if vsnprintf returns a negative count.
12971 Instead, grow the buffer. This ports to Windows vsnprintf, which
12972 does not conform to C99. Problem reported by Eli Zaretskii.
12973 Also, simplify the allocation scheme, by avoiding the need for
12974 calling realloc, and removing the ALLOCATED variable.
12976 * eval.c (verror): Initial buffer size is 4000 (not 200) bytes.
12978 Remove invocations of doprnt, as Emacs now uses vsnprintf.
12979 But keep the doprint source code for now, as we might revamp it
12980 and use it again (Bug#8435).
12981 * lisp.h (doprnt): Remove.
12982 * Makefile.in (base_obj): Remove doprnt.o.
12983 * deps.mk (doprnt.o): Remove.
12985 error: Print 32- and 64-bit integers portably (Bug#8435).
12986 Without this change, on typical 64-bit hosts error ("...%d...", N)
12987 was used to print both 32- and 64-bit integers N, which relied on
12988 undefined behavior.
12989 * lisp.h, m/amdx86-64.h, m/ia64.h, m/ibms390x.h (pEd): New macro.
12990 * lisp.h (error, verror): Mark as printf-like functions.
12991 * eval.c (verror): Use vsnprintf, not doprnt, to do the real work.
12992 Report overflow in size calculations when allocating printf buffer.
12993 Do not truncate output string at its first null byte.
12994 * xdisp.c (vmessage): Use vsnprintf, not doprnt, to do the real work.
12995 Truncate the output at a character boundary, since vsnprintf does not
12997 * charset.c (check_iso_charset_parameter): Convert internal
12998 character to string before calling 'error', since %c now has the
13000 * coding.c (Fdecode_sjis_char, Fdecode_big5_char): Avoid int
13001 overflow when computing char to be passed to 'error'. Do not
13002 pass Lisp_Object to 'error'; pass the integer instead.
13003 * nsfns.m (Fns_do_applescript): Use int, not long, since it's
13004 formatted with plain %d.
13006 * eval.c (internal_lisp_condition_case): Don't pass spurious arg.
13008 * keyboard.c (access_keymap_keyremap): Print func name, not garbage.
13010 * coding.c (Fdecode_sjis_char): Don't assume CODE fits in int.
13012 * xterm.c (x_catch_errors): Remove duplicate declaration.
13014 * term.c (maybe_fatal): Mark its 3rd arg as a printf format, too.
13016 * xdisp.c, lisp.h (message_nolog): Remove; unused.
13018 2011-04-10 Jim Meyering <meyering@redhat.com>
13020 use ssize_t and size_t for read- and write-like emacs_gnutls_* functions
13021 * gnutls.c (emacs_gnutls_read): Adjust signature to be more read-like:
13022 return ssize_t not "int", and use size_t as the buffer length.
13023 (emacs_gnutls_write): Likewise, and make the buffer pointer "const".
13024 * gnutls.h: Update declarations.
13025 * process.c (read_process_output): Use ssize_t, to match.
13026 (send_process): Likewise.
13028 2011-04-09 Chong Yidong <cyd@stupidchicken.com>
13030 * image.c (Fimagemagick_types): Doc fix, and comment cleanup.
13032 2011-04-09 Chong Yidong <cyd@stupidchicken.com>
13034 * ftfont.c (get_adstyle_property, ftfont_pattern_entity):
13035 Use unsigned char, to match FcChar8 type definition.
13037 * xterm.c (handle_one_xevent):
13038 * xmenu.c (create_and_show_popup_menu):
13039 * xselect.c (x_decline_selection_request)
13040 (x_reply_selection_request): Avoid type-punned deref of X events.
13042 2011-04-09 Eli Zaretskii <eliz@gnu.org>
13044 Fix some uses of `int' instead of EMACS_INT.
13045 * search.c (string_match_1, fast_string_match)
13046 (fast_c_string_match_ignore_case, fast_string_match_ignore_case)
13047 (scan_buffer, find_next_newline_no_quit)
13048 (find_before_next_newline, search_command, Freplace_match)
13049 (Fmatch_data): Make some `int' variables be EMACS_INT.
13051 * xdisp.c (display_count_lines): 3rd argument and return value now
13052 EMACS_INT. All callers changed.
13053 (pint2hrstr): Last argument is now EMACS_INT.
13055 * coding.c (detect_coding_utf_8, detect_coding_emacs_mule)
13056 (detect_coding_iso_2022, detect_coding_sjis, detect_coding_big5)
13057 (detect_coding_ccl, detect_coding_charset, decode_coding_utf_8)
13058 (decode_coding_utf_16, decode_coding_emacs_mule)
13059 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5)
13060 (decode_coding_ccl, decode_coding_charset)
13061 <consumed_chars, consumed_chars_base>: Declare EMACS_INT.
13062 (decode_coding_iso_2022, decode_coding_emacs_mule)
13063 (decode_coding_sjis, decode_coding_big5, decode_coding_charset)
13064 <char_offset, last_offset>: Declare EMACS_INT.
13065 (encode_coding_utf_8, encode_coding_utf_16)
13066 (encode_coding_emacs_mule, encode_invocation_designation)
13067 (encode_designation_at_bol, encode_coding_iso_2022)
13068 (encode_coding_sjis, encode_coding_big5, encode_coding_ccl)
13069 (encode_coding_raw_text, encode_coding_charset) <produced_chars>:
13071 (ASSURE_DESTINATION): Declare more_bytes EMACS_INT.
13072 (encode_invocation_designation): Last argument P_NCHARS is now
13074 (decode_eol): Declare pos_byte, pos, and pos_end EMACS_INT.
13075 (produce_chars): from_nchars and to_nchars are now EMACS_INT.
13077 * coding.h (struct coding_system) <head_ascii>: Declare EMACS_INT.
13080 * ccl.c (Fccl_execute_on_string): Declare some variables
13083 2011-04-08 Samuel Thibault <sthibault@debian.org> (tiny change)
13085 * term.c (init_tty): Fix incorrect ifdef placement (Bug#8450).
13087 2011-03-19 Christoph Scholtes <cschol2112@googlemail.com>
13089 * process.c (Fformat_network_address): Doc fix.
13091 2011-04-08 T.V. Raman <tv.raman.tv@gmail.com> (tiny change)
13093 * xml.c (parse_region): Avoid creating spurious whitespace nodes.
13095 2011-04-08 Chong Yidong <cyd@stupidchicken.com>
13097 * keyboard.c (read_char): Call Lisp function help-form-show,
13098 instead of using internal_with_output_to_temp_buffer.
13099 (Qhelp_form_show): New var.
13100 (syms_of_keyboard): Use DEFSYM macro.
13102 * print.c (internal_with_output_to_temp_buffer): Function deleted.
13104 * lisp.h (internal_with_output_to_temp_buffer): Remove prototype.
13106 2011-04-06 Chong Yidong <cyd@stupidchicken.com>
13108 * process.c (Flist_processes): Remove to Lisp.
13109 (list_processes_1): Delete.
13111 2011-04-06 Eli Zaretskii <eliz@gnu.org>
13113 * msdos.c (careadlinkat, careadlinkatcwd): MS-DOS replacements.
13115 * w32.c (careadlinkat, careadlinkatcwd): New always-fail stubs.
13117 2011-04-06 Paul Eggert <eggert@cs.ucla.edu>
13119 Fix more problems found by GCC 4.6.0's static checks.
13121 * xmenu.c (Fx_popup_dialog): Don't assume string is free of formats.
13123 * menu.c (Fx_popup_menu): Don't assume error_name lacks printf formats.
13125 * lisp.h (message, message_nolog, fatal): Mark as printf-like.
13127 * xdisp.c (vmessage): Mark as a printf-like function.
13129 * term.c (vfatal, maybe_fatal): Mark as printf-like functions.
13131 * sound.c (sound_warning): Don't crash if arg contains a printf format.
13133 * image.c (tiff_error_handler, tiff_warning_handler): Mark as
13134 printf-like functions.
13135 (tiff_load): Add casts to remove these marks before passing them
13136 to system-supplied API.
13138 * eval.c (Fsignal): Remove excess argument to 'fatal'.
13140 * coding.c (EMIT_ONE_BYTE, EMIT_TWO_BYTES): Use unsigned, not int.
13141 This avoids several warnings with gcc -Wstrict-overflow.
13142 (DECODE_COMPOSITION_RULE): If the rule is invalid, goto invalid_code
13143 directly, rather than having caller test rule sign. This avoids
13144 some unnecessary tests.
13145 * composite.h (COMPOSITION_ENCODE_RULE_VALID): New macro.
13146 (COMPOSITION_ENCODE_RULE): Arguments now must be valid. This
13147 affects only one use, in DECODE_COMPOSITION_RULE, which is changed.
13149 * xfont.c (xfont_text_extents): Remove var that was set but not used.
13150 (xfont_open): Avoid unnecessary tests.
13152 * composite.c (composition_gstring_put_cache): Use unsigned integer.
13154 * composite.h, composite.c (composition_gstring_put_cache):
13155 Use EMACS_INT, not int, for length.
13157 * composite.h (COMPOSITION_DECODE_REFS): New macro,
13158 breaking out part of COMPOSITION_DECODE_RULE.
13159 (COMPOSITION_DECODE_RULE): Use it.
13160 * composite.c (get_composition_id): Remove unused local vars,
13161 by using the new macro.
13163 * textprop.c (set_text_properties_1): Change while to do-while,
13164 since the condition is always true at first.
13166 * intervals.c (graft_intervals_into_buffer): Mark var as used.
13167 (interval_deletion_adjustment): Return unsigned value.
13170 * process.c (list_processes_1, create_pty, read_process_output):
13171 (exec_sentinel): Remove vars that were set but not used.
13172 (create_pty): Remove unnecessary "volatile"s.
13173 (Fnetwork_interface_info): Avoid possibility of int overflow.
13174 (read_process_output): Do adaptive read buffering even if carryover.
13175 (read_process_output): Simplify nbytes computation if buffered.
13177 * bytecode.c (exec_byte_code): Rename local to avoid shadowing.
13179 * syntax.c (scan_words): Remove var that was set but not used.
13180 (update_syntax_table): Use unsigned instead of int.
13182 * lread.c (lisp_file_lexically_bound_p): Use ints rather than endptrs.
13183 (lisp_file_lexically_bound_p, read1): Use unsigned instead of int.
13184 (safe_to_load_p): Make the end-of-loop test the inverse of the in-loop.
13186 * print.c (print_error_message): Avoid int overflow.
13188 * font.c (font_list_entities): Redo for clarity,
13189 so that reader need not know FONT_DPI_INDEX + 1 == FONT_SPACING_INDEX.
13191 * font.c (font_find_for_lface, Ffont_get_glyphs): Remove unused vars.
13192 (font_score): Avoid potential overflow in diff calculation.
13194 * fns.c (substring_both): Remove var that is set but not used.
13195 (sxhash): Redo loop for clarity and to avoid wraparound warning.
13197 * eval.c (funcall_lambda): Rename local to avoid shadowing.
13199 * alloc.c (mark_object_loop_halt, mark_object): Use size_t, not int.
13200 Otherwise, GCC 4.6.0 optimizes the loop check away since the check
13201 can always succeed if overflow has undefined behavior.
13203 * search.c (boyer_moore, wordify): Remove vars set but not used.
13204 (wordify): Omit three unnecessary tests.
13206 * indent.c (MULTIBYTE_BYTES_WIDTH): Don't compute wide_column.
13207 All callers changed. This avoids the need for an unused var.
13209 * casefiddle.c (casify_region): Remove var that is set but not used.
13211 * dired.c (file_name_completion): Remove var that is set but not used.
13213 * fileio.c (Finsert_file_contents): Make EOF condition clearer.
13215 * fileio.c (Finsert_file_contents): Avoid signed integer overflow.
13216 (Finsert_file_contents): Remove unnecessary code checking fd.
13218 * minibuf.c (read_minibuf_noninteractive): Use size_t for sizes.
13219 Check for integer overflow on size calculations.
13221 * buffer.c (Fprevious_overlay_change): Remove var that is set
13224 * keyboard.c (menu_bar_items, read_char_minibuf_menu_prompt):
13225 Remove vars that are set but not used.
13226 (timer_check_2): Don't assume timer-list and idle-timer-list are lists.
13227 (timer_check_2): Mark vars as initialized.
13229 * gtkutil.c (xg_get_file_with_chooser): Mark var as initialized.
13231 * image.c (lookup_image): Remove var that is set but not used.
13232 (xbm_load): Use parse_p, for gcc -Werror=unused-but-set-variable.
13234 * fontset.c (Finternal_char_font, Ffontset_info): Remove vars
13235 that are set but not used.
13237 * xfns.c (make_invisible_cursor): Don't return garbage
13238 if XCreateBitmapFromData fails (Bug#8410).
13240 * xselect.c (x_get_local_selection, x_handle_property_notify):
13241 Remove vars that are set but not used.
13243 * xfns.c (x_create_tip_frame): Remove var that is set but not used.
13244 (make_invisible_cursor): Initialize a possibly-uninitialized variable.
13246 * xterm.c (x_scroll_bar_to_input_event) [!USE_GTK]:
13247 Remove var that is set but not used.
13248 (scroll_bar_windows_size): Now size_t, not int.
13249 (x_send_scroll_bar_event): Use size_t, not int, for sizes.
13250 Check for overflow.
13252 * xfaces.c (realize_named_face): Remove vars that are set but not used.
13253 (map_tty_color) [!defined MSDOS]: Likewise.
13255 * term.c (tty_write_glyphs): Use size_t; this avoids overflow warning.
13257 * coding.c: Remove vars that are set but not used.
13258 (DECODE_COMPOSITION_RULE): Remove 2nd arg, which is unused.
13259 All callers changed.
13260 (decode_coding_utf_8, decode_coding_utf_16 decode_coding_emacs_mule):
13261 (decode_coding_iso_2022, encode_coding_sjis, encode_coding_big5):
13262 (decode_coding_charset): Remove vars that are set but not used.
13264 * bytecode.c (Fbyte_code) [!defined BYTE_CODE_SAFE]: Remove var
13265 that is set but not used.
13267 * print.c (print_object): Remove var that is set but not used.
13269 Replace 2 copies of readlink code with 1 gnulib version (Bug#8401).
13270 The gnulib version avoids calling malloc in the usual case,
13271 and on 64-bit hosts doesn't have some arbitrary 32-bit limits.
13272 * fileio.c (Ffile_symlink_p): Use emacs_readlink.
13273 * filelock.c (current_lock_owner): Likewise.
13274 * lisp.h (READLINK_BUFSIZE, emacs_readlink): New function.
13275 * sysdep.c: Include allocator.h, careadlinkat.h.
13276 (emacs_no_realloc_allocator): New static constant.
13277 (emacs_readlink): New function.
13278 * deps.mk (sysdep.o): Depend on ../lib/allocator.h and on
13279 ../lib/careadlinkat.h.
13281 2011-04-04 Stefan Monnier <monnier@iro.umontreal.ca>
13283 * keyboard.c (safe_run_hook_funcall): Fix last change (don't stop at the
13284 first non-nil return value).
13286 2011-04-03 Jan Djärv <jan.h.d@swipnet.se>
13288 * nsterm.m (ns_update_auto_hide_menu_bar): Define MAC_OS_X_VERSION_10_6
13289 if not defined (Bug#8403).
13291 2011-04-02 Juanma Barranquero <lekktu@gmail.com>
13293 * xdisp.c (display_count_lines): Remove parameter `start',
13294 unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
13295 (get_char_face_and_encoding): Remove parameter `multibyte_p',
13296 unused since 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
13297 (fill_stretch_glyph_string): Remove parameters `row' and `area',
13298 unused at least since Kim's GUI unification at 2003-03-16T20:45:46Z!storm@cua.dk
13299 and thereabouts. All callers changed.
13300 (get_per_char_metric): Remove parameter `f', unused since
13301 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
13303 2011-04-02 Jim Meyering <meyering@redhat.com>
13305 do not dereference NULL upon failed strdup
13306 * nsfont.m (ns_descriptor_to_entity): Use xstrdup, not strdup.
13307 (ns_get_family): Likewise.
13309 2011-04-02 Juanma Barranquero <lekktu@gmail.com>
13311 * eval.c (unwind_to_catch) [DEBUG_GCPRO]: Remove redundant assignment.
13313 2011-04-02 Jan Djärv <jan.h.d@swipnet.se>
13315 * nsterm.m (ns_update_auto_hide_menu_bar): Only for OSX 10.6 or
13318 2011-04-01 Stefan Monnier <monnier@iro.umontreal.ca>
13320 Add lexical binding.
13322 * window.c (Ftemp_output_buffer_show): New fun.
13323 (Fsave_window_excursion):
13324 * print.c (Fwith_output_to_temp_buffer): Move to subr.el.
13326 * lread.c (lisp_file_lexically_bound_p): New function.
13327 (Fload): Bind Qlexical_binding.
13328 (readevalloop): Remove `evalfun' arg.
13329 Bind Qinternal_interpreter_environment.
13330 (Feval_buffer): Bind Qlexical_binding.
13331 (defvar_int, defvar_bool, defvar_lisp_nopro, defvar_kboard):
13333 (syms_of_lread): Declare `lexical-binding'.
13335 * lisp.h (struct Lisp_Symbol): New field `declared_special'.
13337 * keyboard.c (eval_dyn): New fun.
13338 (menu_item_eval_property): Use it.
13340 * image.c (parse_image_spec): Use Ffunctionp.
13342 * fns.c (concat, mapcar1): Accept byte-code-functions.
13344 * eval.c (Fsetq): Handle lexical vars.
13345 (Fdefun, Fdefmacro, Ffunction): Make closures when needed.
13346 (Fdefconst, Fdefvaralias, Fdefvar): Mark as dynamic.
13347 (FletX, Flet): Obey lexical binding.
13348 (Fcommandp): Handle closures.
13349 (Feval): New `lexical' arg.
13350 (eval_sub): New function extracted from Feval. Use it almost
13351 everywhere where Feval was used. Look up vars in lexical env.
13353 (Ffunctionp): Move from subr.el.
13354 (Ffuncall): Handle closures.
13355 (apply_lambda): Remove `eval_flags'.
13356 (funcall_lambda): Handle closures and new byte-code-functions.
13357 (Fspecial_variable_p): New function.
13358 (syms_of_eval): Initialize the Vinternal_interpreter_environment var,
13359 but without exporting it to Lisp.
13361 * doc.c (Fdocumentation, store_function_docstring):
13362 * data.c (Finteractive_form): Handle closures.
13364 * callint.c (Fcall_interactively): Preserve lexical-binding mode for
13367 * bytecode.c (Bstack_ref, Bstack_set, Bstack_set2, BdiscardN):
13369 (exec_byte_code): New function extracted from Fbyte_code to handle new
13370 calling convention for byte-code-functions. Add new byte-codes.
13372 * buffer.c (defvar_per_buffer): Set new `declared_special' field.
13374 * alloc.c (Fmake_symbol): Init new `declared_special' field.
13376 2011-03-31 Juanma Barranquero <lekktu@gmail.com>
13378 * xdisp.c (redisplay_internal): Fix prototype.
13380 2011-03-31 Eli Zaretskii <eliz@gnu.org>
13382 * xdisp.c (SCROLL_LIMIT): New macro.
13383 (try_scrolling): Use it when setting scroll_limit.
13384 Limit scrolling to 100 screen lines.
13385 (redisplay_window): Even when falling back on "recentering",
13386 position point in the window according to scroll-conservatively,
13387 scroll-margin, and scroll-*-aggressively variables. (Bug#6671)
13389 (try_scrolling): When point is above the window, allow searching
13390 as far as scroll_max, or one screenful, to compute vertical
13391 distance from PT to the scroll margin position. This prevents
13392 try_scrolling from unnecessarily failing when
13393 scroll-conservatively is set to a value slightly larger than the
13394 window height. Clean up the case of PT below the margin at bottom
13395 of window: scroll_max can no longer be INT_MAX. When aggressive
13396 scrolling is in use, don't let point enter the opposite scroll
13397 margin as result of the scroll.
13398 (syms_of_xdisp) <scroll-conservatively>: Document the
13399 threshold of 100 lines for never-recentering scrolling.
13401 2011-03-31 Juanma Barranquero <lekktu@gmail.com>
13403 * dispextern.h (move_it_by_lines):
13404 * xdisp.c (move_it_by_lines): Remove parameter `need_y_p', unused
13405 since 2000-12-29T14:24:09Z!gerd@gnu.org. All callers changed.
13406 (message_log_check_duplicate): Remove parameters `prev_bol' and
13407 `this_bol', unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
13408 (redisplay_internal): Remove parameter `preserve_echo_area',
13409 unused since 1999-07-21T21:43:52Z!gerd@gnu.org. All callers changed.
13411 * indent.c (Fvertical_motion):
13412 * window.c (window_scroll_pixel_based, Frecenter):
13413 Don't pass `need_y_p' to `move_it_by_lines'.
13415 2011-03-30 Stefan Monnier <monnier@iro.umontreal.ca>
13417 * eval.c (struct backtrace): Don't cheat with negative numbers, but do
13418 steal a few bits to be more compact.
13419 (interactive_p, Fbacktrace, Fbacktrace_frame, mark_backtrace):
13420 Remove unneeded casts.
13422 * bytecode.c (Fbyte_code): CAR and CDR can GC.
13424 2011-03-30 Zachary Kanfer <zkanfer@gmail.com> (tiny change)
13426 * keyboard.c (Fexecute_extended_command): Do log the "suggest key
13427 binding" message (bug#7967).
13429 2011-03-30 Paul Eggert <eggert@cs.ucla.edu>
13431 Fix more problems found by GCC 4.6.0's static checks.
13433 * unexelf.c (unexec) [! (defined _SYSTYPE_SYSV || defined __sgi)]:
13434 Remove unused local var.
13436 * editfns.c (Fmessage_box): Remove unused local var.
13438 * xdisp.c (try_window_reusing_current_matrix, x_produce_glyphs):
13439 (note_mode_line_or_margin_highlight, note_mouse_highlight):
13440 Omit unused local vars.
13441 * window.c (shrink_windows): Omit unused local var.
13442 * menu.c (digest_single_submenu): Omit unused local var.
13443 * dispnew.c (update_window) [PERIODIC_PREEMPTION_CHECKING]:
13444 Omit unused local var.
13446 * keyboard.c (parse_modifiers_uncached, parse_modifiers):
13447 Don't assume string length fits in int.
13448 (keyremap_step, read_key_sequence): Use size_t for sizes.
13449 (read_key_sequence): Don't check last_real_key_start redundantly.
13451 * callproc.c (Fcall_process, Fcall_process_region): Use SAFE_ALLOCA
13452 instead of alloca (Bug#8344).
13454 * eval.c (Fbacktrace): Don't assume nargs fits in int.
13455 (Fbacktrace_frame): Don't assume nframes fits in int.
13457 * syntax.c (scan_sexps_forward): Avoid pointer wraparound.
13459 * xterm.c (x_make_frame_visible, same_x_server): Redo to avoid overflow
13462 * term.c (produce_glyphless_glyph): Remove unnecessary test.
13464 * cm.c (calccost): Turn while-do into do-while, for clarity.
13466 * keyboard.c (syms_of_keyboard): Use the same style as later
13467 in this function when indexing through an array. This also
13468 works around GCC bug 48267.
13470 * image.c (tiff_load): Fix off-by-one image count (Bug#8336).
13472 * xselect.c (x_check_property_data): Return correct size (Bug#8335).
13474 * chartab.c (sub_char_table_ref_and_range): Redo for slight
13475 efficiency gain, and to bypass a gcc -Wstrict-overflow warning.
13477 * keyboard.c, keyboard.h (num_input_events): Now size_t.
13478 This avoids undefined behavior on integer overflow, and is a bit
13479 more convenient anyway since it is compared to a size_t variable.
13481 Variadic C functions now count arguments with size_t, not int.
13482 This avoids an unnecessary limitation on 64-bit machines, which
13483 caused (substring ...) to crash on large vectors (Bug#8344).
13484 * lisp.h (struct Lisp_Subr.function.aMANY): Now takes size_t, not int.
13485 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call): Likewise.
13486 All variadic functions and their callers changed accordingly.
13487 (struct gcpro.nvars): Now size_t, not int. All uses changed.
13488 * data.c (arith_driver, float_arith_driver): Likewise.
13489 * editfns.c (general_insert_function): Likewise.
13490 * eval.c (struct backtrace.nargs, interactive_p)
13491 (internal_condition_case_n, run_hook_with_args, apply_lambda)
13492 (funcall_lambda, mark_backtrace): Likewise.
13493 * fns.c (concat): Likewise.
13494 * frame.c (x_set_frame_parameters): Likewise.
13495 * fns.c (get_key_arg): Now accepts and returns size_t, and returns
13496 0 if not found, not -1. All callers changed.
13498 * alloc.c (garbage_collect): Don't assume stack size fits in int.
13499 (stack_copy_size): Now size_t, not int.
13500 (stack_copy, stack_copy_size): Define only if MAX_SAVE_STACK > 0.
13502 2011-03-28 Juanma Barranquero <lekktu@gmail.com>
13504 * coding.c (encode_designation_at_bol): Remove parameter `charbuf_end',
13505 unused since 2002-03-01T01:17:24Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
13506 All callers changed.
13508 * lisp.h (multibyte_char_to_unibyte):
13509 * character.c (multibyte_char_to_unibyte): Remove parameter `rev_tbl',
13510 unused since 2002-03-01T01:16:34Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
13511 * character.h (CHAR_TO_BYTE8):
13512 * cmds.c (internal_self_insert):
13513 * editfns.c (general_insert_function):
13514 * keymap.c (push_key_description):
13515 * search.c (Freplace_match):
13516 * xdisp.c (message_dolog, set_message_1): All callers changed.
13518 2011-03-28 Stefan Monnier <monnier@iro.umontreal.ca>
13520 * keyboard.c (safe_run_hook_funcall): New function.
13521 (safe_run_hooks_1, safe_run_hooks_error, safe_run_hooks): On error,
13522 don't set the hook to nil, but remove the offending function instead.
13523 (Qcommand_hook_internal): Remove, unused.
13524 (syms_of_keyboard): Don't initialize Qcommand_hook_internal nor define
13525 Vcommand_hook_internal.
13527 * eval.c (enum run_hooks_condition): Remove.
13528 (funcall_nil, funcall_not): New functions.
13529 (run_hook_with_args): Call each function through a `funcall' argument.
13530 Remove `cond' argument, now redundant.
13531 (Frun_hooks, Frun_hook_with_args, Frun_hook_with_args_until_success)
13532 (Frun_hook_with_args_until_failure): Adjust accordingly.
13533 (run_hook_wrapped_funcall, Frun_hook_wrapped): New functions.
13535 2011-03-28 Juanma Barranquero <lekktu@gmail.com>
13537 * dispextern.h (string_buffer_position): Remove declaration.
13539 * print.c (strout): Remove parameter `multibyte', unused since
13540 1999-08-21T19:30:21Z!gerd@gnu.org. All callers changed.
13542 * search.c (boyer_moore): Remove parameters `len', `pos' and `lim',
13543 never used since function introduction in 1998-02-08T21:33:56Z!rms@gnu.org.
13544 All callers changed.
13546 * w32.c (_wsa_errlist): Use braces for struct initializers.
13548 * xdisp.c (string_buffer_position_lim): Remove parameter `w',
13549 never used since function introduction in 2001-03-09T18:41:50Z!gerd@gnu.org.
13550 All callers changed.
13551 (string_buffer_position): Likewise. Also, make static (it's never
13552 used outside xdisp.c).
13553 (cursor_row_p): Remove parameter `w', unused since
13554 2000-10-17T16:08:57Z!gerd@gnu.org. All callers changed.
13555 (decode_mode_spec): Remove parameter `precision', introduced during
13556 Gerd Moellmann's rewrite at 1999-07-21T21:43:52Z!gerd@gnu.org, but never used.
13557 All callers changed.
13559 2011-03-27 Jan Djärv <jan.h.d@swipnet.se>
13561 * nsterm.m (syms_of_nsterm): Use doc: for ns-auto-hide-menu-bar.
13563 2011-03-27 Anders Lindgren <andlind@gmail.com>
13565 * nsterm.m (ns_menu_bar_is_hidden): New variable.
13566 (ns_constrain_all_frames, ns_menu_bar_should_be_hidden)
13567 (ns_update_auto_hide_menu_bar): New functions.
13568 (ns_update_begin): Call ns_update_auto_hide_menu_bar.
13569 (applicationDidBecomeActive): Call ns_update_auto_hide_menu_bar and
13570 ns_constrain_all_frames.
13571 (constrainFrameRect): Return at once if ns_menu_bar_should_be_hidden.
13572 (syms_of_nsterm): DEFVAR ns-auto-hide-menu-bar, init to Qnil.
13574 2011-03-27 Jan Djärv <jan.h.d@swipnet.se>
13576 * nsmenu.m (runDialogAt): Remove argument to timer_check.
13578 2011-03-27 Glenn Morris <rgm@gnu.org>
13580 * syssignal.h: Replace RETSIGTYPE with void.
13581 * atimer.c, data.c, dispnew.c, emacs.c, floatfns.c, keyboard.c:
13582 * keyboard.h, lisp.h, process.c, sysdep.c, xterm.c:
13583 Replace SIGTYPE with void everywhere.
13584 * s/usg5-4-common.h (SIGTYPE): Remove definition.
13585 * s/template.h (SIGTYPE): Remove commented out definition.
13587 2011-03-26 Eli Zaretskii <eliz@gnu.org>
13589 * xdisp.c (redisplay_window): Don't check buffer's clip_changed
13590 flag as a prerequisite for invoking try_scrolling. (Bug#6671)
13592 2011-03-26 Juanma Barranquero <lekktu@gmail.com>
13594 * w32.c (read_unc_volume): Use parameter `henum', instead of
13595 global variable `wget_enum_handle'.
13597 * keymap.c (describe_vector): Remove parameters `indices' and
13598 `char_table_depth', unused since 2002-03-01T01:43:26Z!handa@m17n.org.
13599 (describe_map, Fdescribe_vector): Adjust calls to `describe_vector'.
13601 * keyboard.h (timer_check, show_help_echo): Remove unused parameters.
13603 * keyboard.c (timer_check): Remove parameter `do_it_now',
13604 unused since 1996-04-12T06:01:29Z!rms@gnu.org.
13605 (show_help_echo): Remove parameter `ok_to_overwrite_keystroke_echo',
13606 unused since 2008-04-19T19:30:53Z!monnier@iro.umontreal.ca.
13608 * keyboard.c (read_char):
13609 * w32menu.c (w32_menu_display_help):
13610 * xmenu.c (show_help_event, menu_help_callback):
13611 Adjust calls to `show_help_echo'.
13613 * gtkutil.c (xg_maybe_add_timer):
13614 * keyboard.c (readable_events):
13615 * process.c (wait_reading_process_output):
13616 * xmenu.c (x_menu_wait_for_event): Adjust calls to `timer_check'.
13618 * insdel.c (adjust_markers_gap_motion):
13619 Remove; no-op since 1998-01-02T21:29:48Z!rms@gnu.org.
13620 (gap_left, gap_right): Don't call it.
13622 2011-03-25 Chong Yidong <cyd@stupidchicken.com>
13624 * xdisp.c (handle_fontified_prop): Discard changes to clip_changed
13625 incurred during fontification.
13627 2011-03-25 Juanma Barranquero <lekktu@gmail.com>
13629 * buffer.c (defvar_per_buffer): Remove unused parameter `doc'.
13630 (DEFVAR_PER_BUFFER): Don't pass it.
13632 * dispnew.c (row_equal_p, add_row_entry): Remove unused parameter `w'.
13633 (scrolling_window): Don't pass it.
13635 2011-03-25 Juanma Barranquero <lekktu@gmail.com>
13637 * dispextern.h (glyph_matric): Use #if GLYPH_DEBUG, not #ifdef.
13639 * fileio.c (check_executable) [DOS_NT]: Remove unused variables `len'
13641 (Fset_file_selinux_context) [HAVE_LIBSELINUX]: Move here declaration
13642 of variables specific to SELinux and computation of `encoded_absname'.
13644 * image.c (XPutPixel): Remove unused variable `height'.
13646 * keyboard.c (make_lispy_event): Remove unused variable `hpos'.
13648 * unexw32.c (get_section_info): Remove unused variable `section'.
13650 * w32.c (stat): Remove unused variables `drive_root' and `devtype'.
13651 (system_process_attributes): Remove unused variable `sess'.
13652 (sys_read): Remove unused variable `err'.
13654 * w32fns.c (top): Wrap variables with #if GLYPH_DEBUG, not #ifdef.
13655 (w32_wnd_proc): Remove unused variable `isdead'.
13656 (unwind_create_frame): Use #if GLYPH_DEBUG, not #ifdef.
13657 (Fx_server_max_request_size): Remove unused variable `dpyinfo'.
13658 (x_create_tip_frame): Remove unused variable `tem'.
13660 * w32inevt.c (w32_console_read_socket):
13661 Remove unused variable `no_events'.
13663 * w32term.c (x_draw_composite_glyph_string_foreground):
13664 Remove unused variable `width'.
13666 2011-03-24 Juanma Barranquero <lekktu@gmail.com>
13668 * w32term.c (x_set_glyph_string_clipping):
13669 Don't pass uninitialized region to CombineRgn.
13671 2011-03-23 Juanma Barranquero <lekktu@gmail.com>
13673 * w32fns.c (x_set_menu_bar_lines): Remove unused variable `olines'.
13674 (w32_wnd_proc): Pass NULL to Windows API, not uninitialized buffer.
13675 (Fx_close_connection): Remove unused variable `i'.
13677 * w32font.c (w32font_draw): Return number of glyphs.
13678 (w32font_open_internal): Remove unused variable `i'.
13679 (w32font_driver): Add missing initializer.
13681 * w32menu.c (utf8to16): Remove unused variable `utf16'.
13682 (fill_in_menu): Remove unused variable `items_added'.
13684 * w32term.c (last_mouse_press_frame): Remove static global variable.
13685 (w32_clip_to_row): Remove unused variable `f'.
13686 (x_delete_terminal): Remove unused variable `i'.
13688 * w32uniscribe.c (uniscribe_shape): Remove unused variable `nclusters'.
13689 (NOTHING): Remove unused static global variable.
13690 (uniscribe_check_otf): Remove unused variable `table'.
13691 (uniscribe_font_driver): Add missing initializers.
13693 2011-03-23 Julien Danjou <julien@danjou.info>
13695 * term.c (Fsuspend_tty, Fresume_tty):
13696 * minibuf.c (read_minibuf, run_exit_minibuf_hook):
13697 * window.c (temp_output_buffer_show):
13698 * insdel.c (signal_before_change):
13699 * frame.c (Fhandle_switch_frame):
13700 * fileio.c (Fdo_auto_save):
13701 * emacs.c (Fkill_emacs):
13702 * editfns.c (save_excursion_restore):
13703 * cmds.c (internal_self_insert):
13704 * callint.c (Fcall_interactively):
13705 * buffer.c (Fkill_all_local_variables):
13706 * keyboard.c (Fcommand_execute, Fsuspend_emacs, safe_run_hooks_1):
13708 (command_loop_1): Use Frun_hooks. Call safe_run_hooks
13709 unconditionally since it does the check itself.
13711 2011-03-23 Paul Eggert <eggert@cs.ucla.edu>
13713 Fix more problems found by GCC 4.5.2's static checks.
13715 * coding.c (encode_coding_raw_text): Avoid unnecessary test
13716 the first time through the loop, since we know p0 < p1 then.
13717 This also avoids a gcc -Wstrict-overflow warning.
13719 * lisp.h (SAFE_ALLOCA, SAFE_ALLOCA_LISP): Avoid 'int' overflow
13720 leading to a memory leak, possible in functions like
13721 load_charset_map_from_file that can allocate an unbounded number
13722 of objects (Bug#8318).
13724 * xmenu.c (set_frame_menubar): Use EMACS_UINT, not int, for indexes
13725 that could (at least in theory) be that large.
13727 * xdisp.c (message_log_check_duplicate): Return unsigned long, not int.
13728 This is less likely to overflow, and avoids undefined behavior if
13729 overflow does occur. All callers changed. Use strtoul to scan
13730 for the unsigned long integer.
13731 (pint2hrstr): Simplify and tune code slightly.
13732 This also avoids a (bogus) GCC warning with gcc -Wstrict-overflow.
13734 * scroll.c (do_scrolling): Work around GCC bug 48228.
13735 See <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=48228>.
13737 * frame.c (Fmodify_frame_parameters): Simplify loop counter.
13738 This also avoids a warning with gcc -Wstrict-overflow.
13739 (validate_x_resource_name): Simplify count usage.
13740 This also avoids a warning with gcc -Wstrict-overflow.
13742 * fileio.c (Fcopy_file): Report error if fchown or fchmod
13745 * emacs.c (Fdaemon_initialized): Do not ignore I/O errors (Bug#8303).
13747 * process.c (Fmake_network_process): Use socklen_t, not int,
13748 where POSIX says socklen_t is required in portable programs.
13749 This fixes a porting bug on hosts like 64-bit HP-UX, where
13750 socklen_t is wider than int (Bug#8277).
13751 (Fmake_network_process, server_accept_connection):
13752 (wait_reading_process_output, read_process_output):
13755 * process.c: Rename or move locals to avoid shadowing.
13756 (list_processes_1, Fmake_network_process):
13757 (read_process_output_error_handler, exec_sentinel_error_handler):
13758 Rename or move locals.
13759 (Fmake_network_process): Define label "retry_connect" only if needed.
13760 (Fnetwork_interface_info): Fix pointer signedness.
13761 (process_send_signal): Add cast to avoid pointer signedness problem.
13762 (FIRST_PROC_DESC, IF_NON_BLOCKING_CONNECT): Remove unused macros.
13763 (create_process): Use 'volatile' to avoid vfork clobbering (Bug#8298).
13765 Make tparam.h and terminfo.c consistent.
13766 * cm.c (tputs, tgoto, BC, UP): Remove extern decls.
13767 Include tparam.h instead, since it declares them.
13768 * cm.h (PC): Remove extern decl; tparam.h now does this.
13769 * deps.mk (cm.o, terminfo.o): Depend on tparam.h.
13770 * terminfo.c: Include tparam.h, to check interfaces.
13771 (tparm): Make 1st arg a const pointer in decl. Put it at top level.
13772 (tparam): Adjust signature to match interface in tparam.h;
13773 this removes some undefined behavior. Check that outstring and len
13774 are zero, which they always are with Emacs.
13775 * tparam.h (PC, BC, UP): New extern decls.
13777 * xftfont.c (xftfont_shape): Now static, and defined only if needed.
13778 (xftfont_open): Rename locals to avoid shadowing.
13780 * ftfont.c (ftfont_resolve_generic_family): Fix pointer signedness.
13781 (ftfont_otf_capability, ftfont_shape): Omit decls if not needed.
13782 (OTF_TAG_SYM): Omit macro if not needed.
13783 (ftfont_list): Remove unused local.
13784 (get_adstyle_property, ftfont_pattern_entity):
13785 (ftfont_lookup_cache, ftfont_open, ftfont_anchor_point):
13786 Rename locals to avoid shadowing.
13788 * xfont.c (xfont_list_family): Mark var as initialized.
13790 * xml.c (make_dom): Now static.
13792 * composite.c (composition_compute_stop_pos): Rename local to
13794 (composition_reseat_it): Remove unused locals.
13795 (find_automatic_composition, composition_adjust_point): Likewise.
13796 (composition_update_it): Mark var as initialized.
13797 (find_automatic_composition): Mark vars as initialized,
13798 with a FIXME (Bug#8290).
13800 character.h: Rename locals to avoid shadowing.
13801 * character.h (PREV_CHAR_BOUNDARY, FETCH_STRING_CHAR_ADVANCE):
13802 (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE, FETCH_CHAR_ADVANCE):
13803 (FETCH_CHAR_ADVANCE_NO_CHECK, INC_POS, DEC_POS, BUF_INC_POS):
13804 (BUF_DEC_POS): Be more systematic about renaming local temporaries
13805 to avoid shadowing.
13807 * textprop.c (property_change_between_p): Remove; unused.
13809 * intervals.c (interval_start_pos): Now static.
13811 * intervals.h (CHECK_TOTAL_LENGTH): Avoid empty "else".
13813 * atimer.c (start_atimer, append_atimer_lists, set_alarm):
13814 Rename locals to avoid shadowing.
13816 * sound.c (wav_play, au_play, Fplay_sound_internal):
13817 Fix pointer signedness.
13818 (alsa_choose_format): Remove unused local var.
13819 (wav_play): Initialize a variable to 0, to prevent undefined
13820 behavior (Bug#8278).
13822 * region-cache.c (insert_cache_boundary): Redo var to avoid shadowing.
13824 * region-cache.h (pp_cache): New decl, for gcc -Wmissing-prototypes.
13826 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork
13827 clobbering (Bug#8298).
13828 * sysdep.c (sys_subshell): Likewise.
13829 Previously, the sys_subshell 'volatile' was incorrectly IF_LINTted out.
13831 * lisp.h (child_setup): Now NO_RETURN unless DOS_NT.
13832 This should get cleaned up, so that child_setup has the
13833 same signature on all platforms.
13835 * callproc.c (call_process_cleanup): Now static.
13836 (relocate_fd): Rename locals to avoid shadowing.
13838 2011-03-22 Chong Yidong <cyd@stupidchicken.com>
13840 * xterm.c (x_clear_frame): Remove XClearWindow call. This appears
13841 not to be necessary, and produces flickering.
13843 2011-03-20 Glenn Morris <rgm@gnu.org>
13845 * config.in: Remove file.
13847 2011-03-20 Juanma Barranquero <lekktu@gmail.com>
13849 * minibuf.c (Vcompleting_read_function): Don't declare, global variables
13850 are now in src/globals.h.
13851 (syms_of_minibuf): Remove spurious & from previous change.
13853 2011-03-20 Leo Liu <sdl.web@gmail.com>
13855 * minibuf.c (completing-read-function): New variable.
13856 (completing-read-default): Rename from completing-read.
13857 (completing-read): Call completing-read-function.
13859 2011-03-19 Juanma Barranquero <lekktu@gmail.com>
13861 * xfaces.c (Fx_load_color_file):
13862 Read color file from absolute filename (bug#8250).
13864 2011-03-19 Juanma Barranquero <lekktu@gmail.com>
13866 * makefile.w32-in: Update dependencies.
13868 2011-03-17 Eli Zaretskii <eliz@gnu.org>
13870 * makefile.w32-in ($(BLD)/unexw32.$(O)): Depend on $(SRC)/unexec.h.
13872 2011-03-17 Paul Eggert <eggert@cs.ucla.edu>
13874 Fix more problems found by GCC 4.5.2's static checks.
13876 * process.c (make_serial_process_unwind, send_process_trap):
13877 (sigchld_handler): Now static.
13879 * process.c (allocate_pty): Let PTY_ITERATION declare iteration vars.
13880 That way, the code declares only the vars that it needs.
13881 * s/aix4-2.h (PTY_ITERATION): Declare iteration vars.
13882 * s/cygwin.h (PTY_ITERATION): Likewise.
13883 * s/darwin.h (PTY_ITERATION): Likewise.
13884 * s/gnu-linux.h (PTY_ITERATION): Likewise.
13886 * s/irix6-5.h (PTY_OPEN): Declare stb, to loosen coupling.
13887 * process.c (allocate_pty): Don't declare stb unless it's needed.
13889 * bytecode.c (MAYBE_GC): Rewrite so as not to use empty "else".
13890 (CONSTANTLIM): Remove; unused.
13891 (METER_CODE, Bscan_buffer, Bread_char, Bset_mark):
13892 Define only if needed.
13894 * unexelf.c (unexec): Name an expression,
13895 to avoid gcc -Wbad-function-cast warning.
13896 Use a different way to cause a compilation error if anyone uses
13897 n rather than nn, a way that does not involve shadowing.
13898 (ELF_BSS_SECTION_NAME, OLD_PROGRAM_H): Remove; unused.
13900 * deps.mk (unexalpha.o): Remove; unused.
13902 New file unexec.h, the (simple) interface for unexec (Bug#8267).
13903 * unexec.h: New file.
13904 * deps.mk (emacs.o, unexaix.o, unexcw.o, unexcoff.o, unexelf.o):
13905 (unexhp9k800.o, unexmacosx.o, unexsol.o, unexw32.o):
13906 Depend on unexec.h.
13907 * emacs.c [!defined CANNOT_DUMP]: Include unexec.h.
13908 * unexaix.c, unexcoff.c, unexcw.c, unexelf.c, unexhp9k800.c:
13909 * unexmacosx.c, unexsol.c, unexw32.c: Include unexec.h.
13910 Change as necessary to match prototype in unexec.h.
13912 * syntax.c (Fforward_comment, scan_lists): Rename locals to avoid
13914 (back_comment, skip_chars): Mark vars as initialized.
13916 * character.h (FETCH_STRING_CHAR_ADVANCE_NO_CHECK, BUF_INC_POS):
13917 Rename locals to avoid shadowing.
13919 * lread.c (read1): Rewrite so as not to use empty "else".
13920 (Fload, readevalloop, read1): Rename locals to avoid shadowing.
13922 * print.c (Fredirect_debugging_output): Fix pointer signedess.
13924 * lisp.h (debug_output_compilation_hack): Add decl here, to avoid
13925 warning when compiling print.c.
13927 * font.c (font_unparse_fcname): Abort in an "impossible" situation
13928 instead of using an uninitialized var.
13929 (font_sort_entities): Mark var as initialized.
13931 * character.h (FETCH_CHAR_ADVANCE): Rename locals to avoid shadowing.
13933 * font.c (font_unparse_xlfd): Don't mix pointers to variables with
13934 pointers to constants.
13935 (font_parse_fcname): Remove unused vars.
13936 (font_delete_unmatched): Now static.
13937 (font_get_spec): Remove; unused.
13938 (font_style_to_value, font_prop_validate_style, font_unparse_fcname):
13939 (font_update_drivers, Ffont_get_glyphs, font_add_log):
13940 Rename or move locals to avoid shadowing.
13942 * fns.c (require_nesting_list, require_unwind): Now static.
13943 (Ffillarray): Rename locals to avoid shadowing.
13945 * floatfns.c (domain_error2): Define only if needed.
13946 (Ffrexp, Fldexp): Rename locals to avoid shadowing.
13948 * alloc.c (mark_backtrace): Move decl from here ...
13949 * lisp.h: ... to here, so that it can be checked.
13951 * eval.c (call_debugger, do_debug_on_call, grow_specpdl): Now static.
13952 (Fdefvar): Rewrite so as not to use empty "else".
13953 (lisp_indirect_variable): Name an expression,
13954 to avoid gcc -Wbad-function-cast warning.
13955 (Fdefvar): Rename locals to avoid shadowing.
13957 * callint.c (quotify_arg, quotify_args): Now static.
13958 (Fcall_interactively): Rename locals to avoid shadowing.
13959 Use const pointer when appropriate.
13961 * lisp.h (get_system_name, get_operating_system_release):
13962 Move decls here, to check interfaces.
13963 * process.c (get_operating_system_release): Move decl to lisp.h.
13964 * xrdb.c (get_system_name): Likewise.
13965 * editfns.c (init_editfns, Fuser_login_name, Fuser_uid):
13966 (Fuser_real_uid, Fuser_full_name): Remove unnecessary casts,
13967 some of which prompt warnings from gcc -Wbad-function-cast.
13968 (Fformat_time_string, Fencode_time, Finsert_char):
13969 (Ftranslate_region_internal, Fformat):
13970 Rename or remove local vars to avoid shadowing.
13971 (Ftranslate_region_internal): Mark var as initialized.
13973 * doc.c (Fdocumentation, Fsnarf_documentation): Move locals to
13976 * lisp.h (eassert): Check that the argument compiles, even if
13977 ENABLE_CHECKING is not defined.
13979 * data.c (Findirect_variable): Name an expression, to avoid
13980 gcc -Wbad-function-cast warning.
13981 (default_value, arithcompare, arith_driver, arith_error): Now static.
13982 (store_symval_forwarding): Rename local to avoid shadowing.
13983 (Fmake_variable_buffer_local, Fmake_local_variable):
13984 Mark variables as initialized.
13985 (do_blv_forwarding, do_symval_forwarding): Remove; unused.
13987 * alloc.c (check_cons_list): Do not define unless GC_CHECK_CONS_LIST.
13988 (Fmake_vector, Fvector, Fmake_byte_code, Fgarbage_collect):
13989 Rename locals to avoid shadowing.
13990 (mark_stack): Move local variables into the #ifdef region where
13992 (BLOCK_INPUT_ALLOC, UNBLOCK_INPUT_ALLOC): Define only if
13993 ! defined SYSTEM_MALLOC && ! defined SYNC_INPUT, as they are not
13995 (CHECK_ALLOCATED): Define only if GC_CHECK_MARKED_OBJECTS.
13996 (GC_STRING_CHARS): Remove; not used.
13997 (Fmemory_limit): Cast sbrk's returned value to char *.
13999 * lisp.h (check_cons_list): Declare if GC_CHECK_CONS_LIST; this
14000 avoids undefined behavior in theory.
14002 * regex.c (IF_LINT): Add defn, for benefit of ../lib-src.
14004 Use functions, not macros, for up- and down-casing (Bug#8254).
14005 * buffer.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
14006 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Remove. All callers changed
14007 to use the following functions instead of these macros.
14008 (downcase): Adjust to lack of DOWNCASE_TABLE. Return int, not
14009 EMACS_INT, since callers assume the returned value fits in int.
14010 (upcase1): Likewise, for UPCASE_TABLE.
14011 (uppercasep, lowercasep, upcase): New static inline functions.
14012 * editfns.c (Fchar_equal): Remove no-longer-needed workaround for
14013 the race-condition problem in the old DOWNCASE.
14015 * regex.c (CHARSET_LOOKUP_RANGE_TABLE_RAW, POP_FAILURE_REG_OR_COUNT):
14016 Rename locals to avoid shadowing.
14017 (regex_compile, re_match_2_internal): Move locals to avoid shadowing.
14018 (regex_compile, re_search_2, re_match_2_internal):
14019 Remove unused local vars.
14020 (FREE_VAR): Rewrite so as not to use empty "else",
14021 which gcc can warn about.
14022 (regex_compile, re_match_2_internal): Mark locals as initialized.
14023 (RETALLOC_IF): Define only if needed.
14024 (WORDCHAR_P): Likewise. This one is never needed, but is used
14025 only in a comment talking about a compiler bug, so put inside
14026 the #if 0 of that comment.
14027 (CHARSET_LOOKUP_BITMAP, FAIL_STACK_FULL, RESET_FAIL_STACK):
14028 (PUSH_FAILURE_ELT, BUF_PUSH_3, STOP_ADDR_VSTRING):
14031 * search.c (boyer_moore): Rename locals to avoid shadowing.
14032 * character.h (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE):
14033 (PREV_CHAR_BOUNDARY): Likewise.
14035 * search.c (simple_search): Remove unused var.
14037 * dired.c (compile_pattern): Move decl from here ...
14038 * lisp.h: ... to here, so that it can be checked.
14039 (struct re_registers): New forward decl.
14041 * character.h (INC_POS, DEC_POS): Rename locals to avoid shadowing.
14043 * indent.c (MULTIBYTE_BYTES_WIDTH): New args bytes, width.
14045 (MULTIBYTE_BYTES_WIDTH, scan_for_column, compute_motion):
14046 Rename locals to avoid shadowing.
14047 (Fvertical_motion): Mark locals as initialized.
14049 * casefiddle.c (casify_object, casify_region): Now static.
14050 (casify_region): Mark local as initialized.
14052 * cmds.c (internal_self_insert): Rename local to avoid shadowing.
14054 * lisp.h (GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR, GCPRO5_VAR, GCPRO6_VAR):
14055 New macros, so that the caller can use some names other than
14056 gcpro1, gcpro2, etc.
14057 (GCPRO2, GCPRO3, GCPRO4, GCPRO5, GCPRO6): Reimplement in terms
14059 (GCPRO1_VAR, UNGCPRO_VAR): Change the meaning of the second
14060 argument, for consistency with GCPRO2_VAR, etc: it is now the
14061 prefix of the variable, not the variable itself. All uses
14063 * dired.c (directory_files_internal, file_name_completion):
14064 Rename locals to avoid shadowing.
14066 Fix a race condition diagnosed by gcc -Wsequence-point (Bug#8254).
14067 An expression of the form (DOWNCASE (x) == DOWNCASE (y)), found in
14068 dired.c's scmp function, had undefined behavior.
14069 * lisp.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
14070 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Move from here ...
14071 * buffer.h: ... to here, because these macros use current_buffer,
14072 and the new implementation with inline functions needs to have
14073 current_buffer in scope now, rather than later when the macros
14075 (downcase, upcase1): New static inline functions.
14076 (DOWNCASE, UPCASE1): Reimplement using these functions.
14077 This avoids undefined behavior in expressions like
14078 DOWNCASE (x) == DOWNCASE (y), which previously suffered
14079 from race conditions in accessing the global variables
14080 case_temp1 and case_temp2.
14081 * casetab.c (case_temp1, case_temp2): Remove; no longer needed.
14082 * lisp.h (case_temp1, case_temp2): Remove their decls.
14083 * character.h (ASCII_CHAR_P): Move from here ...
14084 * lisp.h: ... to here, so that the inline functions mentioned
14085 above can use them.
14087 * dired.c (directory_files_internal_unwind): Now static.
14089 * fileio.c (file_name_as_directory, directory_file_name):
14090 (barf_or_query_if_file_exists, auto_save_error, auto_save_1):
14092 (file_name_as_directory): Use const pointers when appropriate.
14093 (Fexpand_file_name): Likewise. In particular, newdir might
14094 point at constant storage, so make it a const pointer.
14095 (Fmake_directory_internal, Fread_file_name): Remove unused vars.
14096 (Ffile_selinux_context, Fset_file_selinux_context): Fix pointer
14098 (Fset_file_times, Finsert_file_contents, auto_save_error):
14099 Rename locals to avoid shadowing.
14101 * minibuf.c (choose_minibuf_frame_1): Now static.
14102 (Ftry_completion, Fall_completions): Rename or remove locals
14103 to avoid shadowing.
14105 * marker.c (bytepos_to_charpos): Remove; unused.
14107 * lisp.h (verify_bytepos, count_markers): New decls,
14108 so that gcc does not warn that these functions aren't declared.
14110 * insdel.c (check_markers, make_gap_larger, make_gap_smaller):
14111 (reset_var_on_error, Fcombine_after_change_execute_1): Now static.
14112 (CHECK_MARKERS): Redo to avoid gcc -Wempty-body diagnostic.
14113 (copy_text): Remove unused local var.
14115 * filelock.c (within_one_second): Now static.
14116 (lock_file_1): Rename local to avoid shadowing.
14118 * buffer.c (fix_overlays_before): Mark locals as initialized.
14119 (fix_start_end_in_overlays): Likewise. This function should be
14120 simplified by using pointers-to-pointers, but that's a different
14122 (switch_to_buffer_1): Now static.
14123 (Fkill_buffer, record_buffer, Fbury_buffer, Fset_buffer_multibyte):
14124 (report_overlay_modification): Rename locals to avoid shadowing.
14126 * sysdep.c (system_process_attributes): Rename vars to avoid shadowing.
14127 Fix pointer signedness issue.
14128 (sys_subshell): Mark local as volatile if checking for lint,
14129 to suppress a gcc -Wclobbered warning that does not seem to be right.
14130 (MAXPATHLEN): Define only if needed.
14132 * process.c (serial_open, serial_configure): Move decls from here ...
14133 * systty.h: ... to here, so that they can be checked.
14135 * fns.c (get_random, seed_random): Move extern decls from here ...
14136 * lisp.h: ... to here, so that they can be checked.
14138 * sysdep.c (reset_io): Now static.
14139 (wait_for_termination_signal): Remove; unused.
14141 * keymap.c (keymap_parent, keymap_memberp, map_keymap_internal):
14142 (copy_keymap_item, append_key, push_text_char_description):
14144 (Fwhere_is_internal): Don't test CONSP (sequences) unnecessarily.
14145 (DENSE_TABLE_SIZE): Remove; unused.
14146 (get_keymap, access_keymap, Fdefine_key, Fwhere_is_internal):
14147 (describe_map_tree):
14148 Rename locals to avoid shadowing.
14150 * keyboard.c: Declare functions static if they are not used elsewhere.
14151 (echo_char, echo_dash, cmd_error, top_level_2):
14152 (poll_for_input, handle_async_input): Now static.
14153 (read_char, kbd_buffer_get_event, make_lispy_position):
14154 (make_lispy_event, make_lispy_movement, apply_modifiers):
14155 (decode_keyboard_code, tty_read_avail_input, menu_bar_items):
14156 (parse_tool_bar_item, read_key_sequence, Fread_key_sequence):
14157 (Fread_key_sequence_vector): Rename locals to avoid shadowing.
14158 (read_key_sequence, read_char): Mark locals as initialized.
14159 (Fexit_recursive_edit, Fabort_recursive_edit): Mark with NO_RETURN.
14161 * keyboard.h (make_ctrl_char): New decl.
14162 (mark_kboards): Move decl here ...
14163 * alloc.c (mark_kboards): ... from here.
14165 * lisp.h (force_auto_save_soon): New decl.
14167 * emacs.c (init_cmdargs): Rename local to avoid shadowing.
14168 (DEFINE_DUMMY_FUNCTION): New macro.
14169 (__do_global_ctors, __do_global_ctors_aux, __do_global_dtors, __main):
14171 (main): Add casts to avoid warnings
14172 if GCC considers string literals to be constants.
14174 * lisp.h (fatal_error_signal): Add decl, since it's exported.
14176 * dbusbind.c: Pointer signedness fixes.
14177 (xd_signature, xd_append_arg, xd_initialize):
14178 (Fdbus_call_method, Fdbus_call_method_asynchronously):
14179 (Fdbus_method_return_internal, Fdbus_method_error_internal):
14180 (Fdbus_send_signal, xd_read_message_1, Fdbus_register_service):
14181 (Fdbus_register_signal): Use SSDATA when the context wants char *.
14183 * dbusbind.c (Fdbus_init_bus): Add cast to avoid warning
14184 if GCC considers string literals to be constants.
14185 (Fdbus_register_service, Fdbus_register_method): Remove unused vars.
14187 2011-03-16 Stefan Monnier <monnier@iro.umontreal.ca>
14189 * print.c (PRINT_CIRCLE_CANDIDATE_P): New macro.
14190 (print_preprocess, print_object): New macro to fix last change.
14192 * print.c (print_preprocess): Don't forget font objects.
14194 2011-03-16 Juanma Barranquero <lekktu@gmail.com>
14196 * emacs.c (USAGE3): Doc fixes.
14198 2011-03-15 Andreas Schwab <schwab@linux-m68k.org>
14200 * coding.c (detect_coding_iso_2022): Reorganize code to clarify
14203 2011-03-14 Juanma Barranquero <lekktu@gmail.com>
14205 * lisp.h (VWindow_system, Qfile_name_history):
14206 * keyboard.h (lispy_function_keys) [WINDOWSNT]:
14207 * w32term.h (w32_system_caret_hwnd, w32_system_caret_height)
14208 (w32_system_caret_x, w32_system_caret_y): Declare extern.
14210 * w32select.c: Don't #include "keyboard.h".
14211 (run_protected): Add extern declaration for waiting_for_input.
14213 * w32.c (Qlocal, noninteractive1, inhibit_window_system):
14214 * w32console.c (detect_input_pending, read_input_pending)
14215 (encode_terminal_code):
14216 * w32fns.c (quit_char, lispy_function_keys, Qtooltip)
14217 (w32_system_caret_hwnd, w32_system_caret_height, w32_system_caret_x)
14218 (w32_system_caret_y, Qfile_name_history):
14219 * w32font.c (w32font_driver, QCantialias, QCotf, QClang):
14220 * w32inevt.c (reinvoke_input_signal, lispy_function_keys):
14221 * w32menu.c (Qmenu_bar, QCtoggle, QCradio, Qoverriding_local_map)
14222 (Qoverriding_terminal_local_map, Qmenu_bar_update_hook):
14223 * w32proc.c (Qlocal, report_file_error):
14224 * w32term.c (Vwindow_system, updating_frame):
14225 * w32uniscribe.c (initialized, uniscribe_font_driver):
14226 Remove unneeded extern declarations.
14228 2011-03-14 Chong Yidong <cyd@stupidchicken.com>
14230 * buffer.c (Fmake_indirect_buffer): Fix incorrect assertions.
14232 2011-03-13 Chong Yidong <cyd@stupidchicken.com>
14234 * buffer.h (BUF_BEGV, BUF_BEGV_BYTE, BUF_ZV, BUF_ZV_BYTE, BUF_PT)
14235 (BUF_PT_BYTE): Rewrite to handle indirect buffers (Bug#8219).
14236 These macros can no longer be used for assignment.
14238 * buffer.c (Fget_buffer_create, Fmake_indirect_buffer):
14239 Assign struct members directly, instead of using BUF_BEGV etc.
14240 (record_buffer_markers, fetch_buffer_markers): New functions for
14241 recording and fetching special buffer markers.
14242 (set_buffer_internal_1, set_buffer_temp): Use them.
14244 * lread.c (unreadchar): Use SET_BUF_PT_BOTH.
14246 * insdel.c (adjust_point): Use SET_BUF_PT_BOTH.
14248 * intervals.c (temp_set_point_both): Use SET_BUF_PT_BOTH.
14249 (get_local_map): Use SET_BUF_BEGV_BOTH and SET_BUF_ZV_BOTH.
14251 * xdisp.c (hscroll_window_tree):
14252 (reconsider_clip_changes): Use PT instead of BUF_PT.
14254 2011-03-13 Eli Zaretskii <eliz@gnu.org>
14256 * makefile.w32-in ($(BLD)/editfns.$(O)): Depend on
14257 $(EMACS_ROOT)/lib/intprops.h.
14259 2011-03-13 Paul Eggert <eggert@cs.ucla.edu>
14261 Fix more problems found by GCC 4.5.2's static checks.
14263 * gtkutil.c (xg_get_pixbuf_from_pixmap): Add cast from char *
14264 to unsigned char * to avoid compiler diagnostic.
14265 (xg_free_frame_widgets): Make it clear that a local variable is
14266 needed only if USE_GTK_TOOLTIP.
14267 (gdk_window_get_screen): Make it clear that this macro is needed
14268 only if USE_GTK_TOOLTIP.
14269 (int_gtk_range_get_value): New function, which avoids a diagnostic
14270 from gcc -Wbad-function-cast.
14271 (xg_set_toolkit_scroll_bar_thumb): Use it.
14272 (xg_tool_bar_callback, xg_tool_item_stale_p): Rewrite to avoid
14273 diagnostic from gcc -Wbad-function-cast.
14274 (get_utf8_string, xg_get_file_with_chooser):
14275 Rename locals to avoid shadowing.
14276 (create_dialog): Move locals to avoid shadowing.
14278 * xgselect.c (xg_select): Remove unused var.
14280 * image.c (four_corners_best): Mark locals as initialized.
14281 (gif_load): Initialize transparent_p to zero (Bug#8238).
14282 Mark another local as initialized.
14283 (my_png_error, my_error_exit): Mark with NO_RETURN.
14285 * image.c (clear_image_cache): Now static.
14286 (DIM, HAVE_STDLIB_H_1): Remove unused macros.
14287 (xpm_load): Redo to avoid "discards qualifiers" gcc warning.
14288 (x_edge_detection): Remove unnecessary cast that
14289 gcc -Wbad-function-cast diagnoses.
14290 (gif_load): Fix pointer signedness.
14291 (clear_image_cache, xbm_read_bitmap_data, x_detect_edges):
14292 (jpeg_load, gif_load): Rename locals to avoid shadowing.
14294 2011-03-12 Paul Eggert <eggert@cs.ucla.edu>
14296 Improve quality of tests for time stamp overflow.
14297 For example, without this patch (encode-time 0 0 0 1 1
14298 1152921504606846976) returns the obviously-bogus value (-948597
14299 62170) on my RHEL 5.5 x86-64 host. With the patch, it correctly
14300 reports time overflow. See
14301 <http://lists.gnu.org/archive/html/emacs-devel/2011-03/msg00470.html>.
14302 * deps.mk (editfns.o): Depend on ../lib/intprops.h.
14303 * editfns.c: Include limits.h and intprops.h.
14304 (TIME_T_MIN, TIME_T_MAX): New macros.
14305 (time_overflow): Move earlier, to before first use.
14306 (hi_time, lo_time): New functions, for an accurate test for
14307 out-of-range times.
14308 (Fcurrent_time, Fget_internal_run_time, make_time): Use them.
14309 (Fget_internal_run_time): Don't assume time_t fits in int.
14310 (make_time): Use list2 instead of Fcons twice.
14311 (Fdecode_time): More accurate test for out-of-range times.
14312 (check_tm_member): New function.
14313 (Fencode_time): Use it, to test for out-of-range times.
14314 (lisp_time_argument): Don't rely on undefined left-shift and
14315 right-shift behavior when checking for time stamp overflow.
14317 * editfns.c (time_overflow): New function, refactoring common code.
14318 (Fformat_time_string, Fdecode_time, Fencode_time):
14319 (Fcurrent_time_string): Use it.
14321 Move 'make_time' to be next to its inverse 'lisp_time_argument'.
14322 * dired.c (make_time): Move to ...
14323 * editfns.c (make_time): ... here.
14324 * systime.h: Note the move.
14326 2011-03-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
14328 * fringe.c (update_window_fringes): Remove unused variables.
14330 * unexmacosx.c (copy_data_segment): Also copy __got section.
14333 2011-03-12 Eli Zaretskii <eliz@gnu.org>
14335 * termcap.c [MSDOS]: Include "msdos.h".
14336 (find_capability, tgetnum, tgetflag, tgetstr, tputs, tgetent):
14337 Constify `char *' arguments and their references according to
14338 prototypes in tparam.h.
14340 * deps.mk (termcap.o): Depend on tparam.h and msdos.h.
14342 * msdos.c (XMenuAddPane): 3rd argument is `const char *' now.
14343 Adapt all references accordingly.
14345 * msdos.h (XMenuAddPane): 3rd argument is `const char *' now.
14347 2011-03-11 Tom Tromey <tromey@redhat.com>
14349 * buffer.c (syms_of_buffer): Remove obsolete comment.
14351 2011-03-11 Eli Zaretskii <eliz@gnu.org>
14353 * termhooks.h (encode_terminal_code): Declare prototype.
14355 * msdos.c (encode_terminal_code): Don't declare prototype.
14357 * term.c (encode_terminal_code): Now external again, used by
14358 w32console.c and msdos.c.
14360 * makefile.w32-in ($(BLD)/term.$(O), ($(BLD)/tparam.$(O)):
14361 Depend on $(SRC)/tparam.h, see 2011-03-11T07:24:21Z!eggert@cs.ucla.edu.
14363 2011-03-11 Paul Eggert <eggert@cs.ucla.edu>
14365 Fix some minor problems found by GCC 4.5.2's static checks.
14367 * fringe.c (update_window_fringes): Mark locals as initialized
14369 (destroy_fringe_bitmap, init_fringe_bitmap): Now static.
14371 * alloc.c (mark_fringe_data): Move decl from here ...
14372 * lisp.h (mark_fringe_data) [HAVE_WINDOW_SYSTEM]: ... to here,
14373 to check its interface.
14374 (init_fringe_once): Do not declare unless HAVE_WINDOW_SYSTEM.
14376 * fontset.c (free_realized_fontset): Now static.
14377 (Fset_fontset_font): Rename local to avoid shadowing.
14378 (fontset_font): Mark local as initialized.
14379 (FONTSET_SPEC, FONTSET_REPERTORY, RFONT_DEF_REPERTORY): Remove; unused.
14381 * xrdb.c: Include "xterm.h", to check x_load_resources's interface.
14383 * xselect.c (x_disown_buffer_selections): Remove; not used.
14384 (TRACE3) [!defined TRACE_SELECTION]: Remove; not used.
14385 (x_own_selection, Fx_disown_selection_internal): Rename locals
14386 to avoid shadowing.
14387 (x_handle_dnd_message): Remove local to avoid shadowing.
14389 * lisp.h (GCPRO1_VAR, UNGCPRO_VAR): New macros,
14390 so that the caller can use some name other than gcpro1.
14391 (GCPRO1, UNGCPRO): Reimplement in terms of the new macros.
14392 * xfns.c (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
14393 (Fx_backspace_delete_keys_p):
14394 Use them to avoid shadowing, and rename vars to avoid shadowing.
14395 (x_decode_color, x_set_name, x_window): Now static.
14396 (Fx_create_frame): Add braces to silence GCC warning.
14397 (Fx_file_dialog, Fx_select_font): Fix pointer signedness.
14398 (x_real_positions, xg_set_icon_from_xpm_data, x_create_tip_frame):
14399 Remove unused locals.
14400 (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
14401 (Fx_backspace_delete_keys_p): Rename locals to avoid shadowing.
14402 Some of these renamings use the new GCPRO1_VAR and UNGCPRO_VAR
14405 * xterm.h (x_mouse_leave): New decl.
14407 * xterm.c (x_copy_dpy_color, x_focus_on_frame, x_unfocus_frame):
14408 Remove unused functions.
14409 (x_shift_glyphs_for_insert, XTflash, XTring_bell):
14410 (x_calc_absolute_position): Now static.
14411 (XTread_socket): Don't define label "out" unless it's used.
14412 Don't declare local "event" unless it's used.
14413 (x_iconify_frame, x_free_frame_resources): Don't declare locals
14414 unless they are used.
14415 (XEMBED_VERSION, xembed_set_info): Don't define unless needed.
14416 (x_fatal_error_signal): Remove; not used.
14417 (x_draw_image_foreground, redo_mouse_highlight, XTmouse_position):
14418 (x_scroll_bar_report_motion, handle_one_xevent, x_draw_bar_cursor):
14419 (x_error_catcher, x_connection_closed, x_error_handler):
14420 (x_error_quitter, xembed_send_message, x_iconify_frame):
14421 (my_log_handler): Rename locals to avoid shadowing.
14422 (x_delete_glyphs, x_ins_del_lines): Mark with NO_RETURN.
14423 (x_connection_closed): Tell GCC not to suggest NO_RETURN.
14425 * xfaces.c (clear_face_cache, Fx_list_fonts, Fface_font):
14426 Rename or move locals to avoid shadowing.
14427 (tty_defined_color, merge_face_heights): Now static.
14428 (free_realized_faces_for_fontset): Remove; not used.
14429 (Fx_list_fonts): Mark variable that gcc -Wuninitialized
14430 does not deduce is never used uninitialized.
14431 (STRDUPA, LSTRDUPA, FONT_POINT_SIZE_QUANTUM): Remove; not used.
14432 (LFACEP): Define only if XASSERTS, as it's not needed otherwise.
14434 * terminal.c (store_terminal_param): Now static.
14436 * xmenu.c (menu_highlight_callback): Now static.
14437 (set_frame_menubar): Remove unused local.
14438 (xmenu_show): Rename parameter to avoid shadowing.
14439 (xmenu_show, xdialog_show, xmenu_show): Make local pointers "const"
14440 since they might point to immutable storage.
14441 (next_menubar_widget_id): Declare only if USE_X_TOOLKIT,
14442 since it's unused otherwise.
14444 * xdisp.c (produce_glyphless_glyph): Initialize lower_xoff.
14445 Add a FIXME, since the code still doesn't look right. (Bug#8215)
14446 (Fcurrent_bidi_paragraph_direction): Simplify slightly; this
14447 avoids a gcc -Wuninitialized diagnostic.
14448 (display_line, BUILD_COMPOSITE_GLYPH_STRING, draw_glyphs):
14449 (note_mouse_highlight): Mark variables that gcc -Wuninitialized
14450 does not deduce are never used uninitialized.
14452 * lisp.h (IF_LINT): New macro, copied from ../lib-src/emacsclient.c.
14454 * xdisp.c (redisplay_window): Rename local to avoid shadowing.
14455 * window.c (window_loop, size_window):
14456 (run_window_configuration_change_hook, enlarge_window): Likewise.
14458 * window.c (display_buffer): Now static.
14459 (size_window): Mark variables that gcc -Wuninitialized
14460 does not deduce are never used uninitialized.
14461 * window.h (check_all_windows): New decl, to forestall
14462 gcc -Wmissing-prototypes diagnostic.
14463 * dispextern.h (bidi_dump_cached_states): Likewise.
14465 * charset.h (CHECK_CHARSET_GET_CHARSET): Rename locals to avoid
14467 * charset.c (map_charset_for_dump, Fchar_charset): Likewise.
14468 Include <limits.h>.
14469 (Fsort_charsets): Redo min/max calculation to shorten the code a bit
14470 and to avoid gcc -Wuninitialized warning.
14471 (load_charset_map): Mark variables that gcc -Wuninitialized
14472 does not deduce are never used uninitialized.
14473 (load_charset): Abort instead of using uninitialized var (Bug#8229).
14475 * coding.c (coding_set_source, coding_set_destination):
14476 Use "else { /* comment */ }" rather than "else /* comment */;"
14477 for clarity, and to avoid gcc -Wempty-body warning.
14478 (Fdefine_coding_system_internal): Don't redeclare 'i' inside
14479 a block, when the outer 'i' will do.
14480 (decode_coding_utf_8, decode_coding_utf_16, detect_coding_emacs_mule):
14481 (emacs_mule_char, decode_coding_emacs_mule, detect_coding_iso_2022):
14482 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5):
14483 (decode_coding_raw_text, decode_coding_charset, get_translation_table):
14484 (Fdecode_sjis_char, Fdefine_coding_system_internal):
14485 Rename locals to avoid shadowing.
14486 * character.h (FETCH_STRING_CHAR_ADVANCE): Likewise.
14487 * coding.c (emacs_mule_char, encode_invocation_designation):
14488 Now static, since they're not used elsewhere.
14489 (decode_coding_iso_2022): Add "default: abort ();" as a safety check.
14490 (decode_coding_object, encode_coding_object, detect_coding_system):
14491 (decode_coding_emacs_mule): Mark variables that gcc
14492 -Wuninitialized does not deduce are never used uninitialized.
14493 (detect_coding_iso_2022): Initialize a local variable that might
14494 be used uninitialized. Leave a FIXME because it's not clear that
14495 this initialization is needed. (Bug#8211)
14496 (ISO_CODE_LF, ISO_CODE_CR, CODING_ISO_FLAG_EUC_TW_SHIFT):
14497 (ONE_MORE_BYTE_NO_CHECK, UTF_BOM, UTF_16_INVALID_P):
14498 (SHIFT_OUT_OK, ENCODE_CONTROL_SEQUENCE_INTRODUCER):
14499 (ENCODE_DIRECTION_R2L, ENCODE_DIRECTION_L2R):
14500 Remove unused macros.
14502 * category.c (hash_get_category_set): Remove unused local var.
14503 (copy_category_table): Now static, since it's not used elsewhere.
14504 * character.c (string_count_byte8): Likewise.
14506 * ccl.c (CCL_WRITE_STRING, CCL_ENCODE_CHAR, Fccl_execute_on_string):
14507 (Fregister_code_conversion_map): Rename locals to avoid shadowing.
14509 * chartab.c (copy_sub_char_table): Now static, since it's not used
14511 (sub_char_table_ref_and_range, char_table_ref_and_range):
14512 Rename locals to avoid shadowing.
14513 (ASET_RANGE, GET_SUB_CHAR_TABLE): Remove unused macros.
14515 * bidi.c (bidi_check_type): Now static, since it's not used elsewhere.
14516 (BIDI_BOB): Remove unused macro.
14518 * cm.c (cmgoto): Mark variables that gcc -Wuninitialized does not
14519 deduce are never used uninitialized.
14520 * term.c (encode_terminal_code): Likewise.
14522 * term.c (encode_terminal_code): Now static. Remove unused local.
14524 * tparam.h: New file.
14525 * term.c, tparam.h: Include it.
14526 * deps.mk (term.o, tparam.o): Depend on tparam.h.
14527 * term.c (tputs, tgetent, tgetflag, tgetnum, tparam, tgetstr):
14528 Move these decls to tparam.h, and make them agree with what
14529 is actually in tparam.c. The previous trick of using incompatible
14530 decls in different modules does not conform to the C standard.
14531 All callers of tparam changed to use tparam's actual API.
14532 * tparam.c (tparam1, tparam, tgoto):
14533 Use const pointers where appropriate.
14535 * cm.c (calccost, cmgoto): Use const pointers where appropriate.
14536 * cm.h (struct cm): Likewise.
14537 * dispextern.h (do_line_insertion_deletion_costs): Likewise.
14538 * scroll.c (ins_del_costs, do_line_insertion_deletion_costs): Likewise.
14539 * term.c (tty_ins_del_lines, calculate_costs, struct fkey_table):
14540 (term_get_fkeys_1, append_glyphless_glyph, produce_glyphless_glyph):
14541 (turn_on_face, init_tty): Likewise.
14542 * termchar.h (struct tty_display_info): Likewise.
14544 * term.c (term_mouse_position): Rename local to avoid shadowing.
14546 * alloc.c (mark_ttys): Move decl from here ...
14547 * lisp.h (mark_ttys): ... to here, so that it's checked against defn.
14549 2011-03-11 Andreas Schwab <schwab@linux-m68k.org>
14551 * .gdbinit (pwinx, xbuffer): Fix access to buffer name.
14553 2011-03-09 Juanma Barranquero <lekktu@gmail.com>
14555 * search.c (compile_pattern_1): Remove argument regp, unused since
14556 revid:rms@gnu.org-19941211082627-3x1g1wyqkjmwloig.
14557 (compile_pattern): Don't pass it.
14559 2011-03-08 Jan Djärv <jan.h.d@swipnet.se>
14561 * xterm.h (DEFAULT_GDK_DISPLAY): New define.
14562 (GDK_WINDOW_XID, gtk_widget_get_preferred_size): New defines
14564 (GTK_WIDGET_TO_X_WIN): Use GDK_WINDOW_XID.
14566 * xmenu.c (menu_position_func): Call gtk_widget_get_preferred_size.
14568 * gtkutil.c: Include gtkx.h if HAVE_GTK3. If ! HAVE_GTK3, define
14569 gdk_window_get_screen, gdk_window_get_geometry,
14570 gdk_x11_window_lookup_for_display and GDK_KEY_g.
14571 (xg_set_screen): Use DEFAULT_GDK_DISPLAY.
14572 (xg_get_pixbuf_from_pixmap): New function.
14573 (xg_get_pixbuf_from_pix_and_mask): Change parameters from GdkPixmap
14574 to Pixmap, take frame as parameter, remove GdkColormap parameter.
14575 Call xg_get_pixbuf_from_pixmap instead of
14576 gdk_pixbuf_get_from_drawable.
14577 (xg_get_image_for_pixmap): Do not make GdkPixmaps, call
14578 xg_get_pixbuf_from_pix_and_mask with Pixmap parameters instead.
14579 (xg_check_special_colors): Use GtkStyleContext and its functions
14581 (xg_prepare_tooltip, xg_hide_tooltip): Call gdk_window_get_screen.
14582 (xg_prepare_tooltip, create_dialog, menubar_map_cb)
14583 (xg_update_frame_menubar, xg_tool_bar_detach_callback)
14584 (xg_tool_bar_attach_callback, xg_update_tool_bar_sizes):
14585 Call gtk_widget_get_preferred_size.
14586 (xg_frame_resized): gdk_window_get_geometry only takes 5
14588 (xg_win_to_widget, xg_event_is_for_menubar):
14589 Call gdk_x11_window_lookup_for_display.
14590 (xg_set_widget_bg): New function.
14591 (delete_cb): New function.
14592 (xg_create_frame_widgets): Connect delete-event to delete_cb.
14593 Call xg_set_widget_bg. Only set background pixmap for ! HAVE_GTK3
14594 (xg_set_background_color): Call xg_set_widget_bg.
14595 (xg_set_frame_icon): Call xg_get_pixbuf_from_pix_and_mask.
14596 (xg_create_scroll_bar): vadj is a GtkAdjustment for HAVE_GTK3.
14597 Only call gtk_range_set_update_policy if ! HAVE_GTK3.
14598 (xg_make_tool_item): Only connect xg_tool_bar_item_expose_callback
14600 (update_frame_tool_bar): Call gtk_widget_hide.
14601 (xg_initialize): Use GDK_KEY_g.
14603 * xsmfns.c (gdk_set_sm_client_id): Define to gdk_set_sm_client_id
14605 (x_session_initialize): Call gdk_x11_set_sm_client_id.
14607 * xterm.c (XFillRectangle): Use cairo routines for HAVE_GTK3.
14608 (x_term_init): Disable Xinput(2) with GDK_CORE_DEVICE_EVENTS.
14609 Load ~/emacs.d/gtkrc only for ! HAVE_GTK3.
14611 2011-03-08 Juanma Barranquero <lekktu@gmail.com>
14613 * w32xfns.c (select_palette): Check success of RealizePalette against
14614 GDI_ERROR, not zero.
14616 See ChangeLog.11 for earlier changes.
14618 ;; Local Variables:
14622 Copyright (C) 2011-2012 Free Software Foundation, Inc.
14624 This file is part of GNU Emacs.
14626 GNU Emacs is free software: you can redistribute it and/or modify
14627 it under the terms of the GNU General Public License as published by
14628 the Free Software Foundation, either version 3 of the License, or
14629 (at your option) any later version.
14631 GNU Emacs is distributed in the hope that it will be useful,
14632 but WITHOUT ANY WARRANTY; without even the implied warranty of
14633 MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
14634 GNU General Public License for more details.
14636 You should have received a copy of the GNU General Public License
14637 along with GNU Emacs. If not, see <http://www.gnu.org/licenses/>.